{"action":"created","issue":{"url":"https://api.github.com/repos/restify/node-restify/issues/1319","repository_url":"https://api.github.com/repos/restify/node-restify","labels_url":"https://api.github.com/repos/restify/node-restify/issues/1319/labels{/name}","comments_url":"https://api.github.com/repos/restify/node-restify/issues/1319/comments","events_url":"https://api.github.com/repos/restify/node-restify/issues/1319/events","html_url":"https://github.com/restify/node-restify/pull/1319","id":224639143,"number":1319,"title":"Close connection on error","user":{"login":"retrohacker","id":1081565,"avatar_url":"https://avatars0.githubusercontent.com/u/1081565?v=3","gravatar_id":"","url":"https://api.github.com/users/retrohacker","html_url":"https://github.com/retrohacker","followers_url":"https://api.github.com/users/retrohacker/followers","following_url":"https://api.github.com/users/retrohacker/following{/other_user}","gists_url":"https://api.github.com/users/retrohacker/gists{/gist_id}","starred_url":"https://api.github.com/users/retrohacker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/retrohacker/subscriptions","organizations_url":"https://api.github.com/users/retrohacker/orgs","repos_url":"https://api.github.com/users/retrohacker/repos","events_url":"https://api.github.com/users/retrohacker/events{/privacy}","received_events_url":"https://api.github.com/users/retrohacker/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2017-04-27T00:52:05Z","updated_at":"2017-04-27T21:37:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/restify/node-restify/pulls/1319","html_url":"https://github.com/restify/node-restify/pull/1319","diff_url":"https://github.com/restify/node-restify/pull/1319.diff","patch_url":"https://github.com/restify/node-restify/pull/1319.patch"},"body":"See #1308 for context\r\n\r\nFixes #1308"},"comment":{"url":"https://api.github.com/repos/restify/node-restify/issues/comments/297846354","html_url":"https://github.com/restify/node-restify/pull/1319#issuecomment-297846354","issue_url":"https://api.github.com/repos/restify/node-restify/issues/1319","id":297846354,"user":{"login":"yunong","id":1226256,"avatar_url":"https://avatars2.githubusercontent.com/u/1226256?v=3","gravatar_id":"","url":"https://api.github.com/users/yunong","html_url":"https://github.com/yunong","followers_url":"https://api.github.com/users/yunong/followers","following_url":"https://api.github.com/users/yunong/following{/other_user}","gists_url":"https://api.github.com/users/yunong/gists{/gist_id}","starred_url":"https://api.github.com/users/yunong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yunong/subscriptions","organizations_url":"https://api.github.com/users/yunong/orgs","repos_url":"https://api.github.com/users/yunong/repos","events_url":"https://api.github.com/users/yunong/events{/privacy}","received_events_url":"https://api.github.com/users/yunong/received_events","type":"User","site_admin":false},"created_at":"2017-04-27T21:37:24Z","updated_at":"2017-04-27T21:37:24Z","body":"@retrohacker I appreciate the discussion 👍 . One thing to be mindful of which is a subtle but important distinction is \r\n\r\n>  if you gracefully cleanup before shutting down \r\n\r\nThis is generally not recommended if you wish to capture the process state via a core dump and debug post-mortem. If you're performing additional work before shutdown on an UncaughtException, it means at least a few things. First there's no way of knowing if any of the work you're doing is correct; second, performing additional work after the error means you're not mutating the process state, which makes it much harder to debug and get root cause on what actually caused the error.\r\n\r\n"}}
{"actor":{"display_login":"yunong"}}