{"action":"closed","number":103,"pull_request":{"url":"https://api.github.com/repos/jenkins-infra/account-app/pulls/103","id":117265300,"html_url":"https://github.com/jenkins-infra/account-app/pull/103","diff_url":"https://github.com/jenkins-infra/account-app/pull/103.diff","patch_url":"https://github.com/jenkins-infra/account-app/pull/103.patch","issue_url":"https://api.github.com/repos/jenkins-infra/account-app/issues/103","number":103,"state":"closed","locked":false,"title":"Add application configuration through env variables","user":{"login":"olblak","id":2360224,"avatar_url":"https://avatars2.githubusercontent.com/u/2360224?v=3","gravatar_id":"","url":"https://api.github.com/users/olblak","html_url":"https://github.com/olblak","followers_url":"https://api.github.com/users/olblak/followers","following_url":"https://api.github.com/users/olblak/following{/other_user}","gists_url":"https://api.github.com/users/olblak/gists{/gist_id}","starred_url":"https://api.github.com/users/olblak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olblak/subscriptions","organizations_url":"https://api.github.com/users/olblak/orgs","repos_url":"https://api.github.com/users/olblak/repos","events_url":"https://api.github.com/users/olblak/events{/privacy}","received_events_url":"https://api.github.com/users/olblak/received_events","type":"User","site_admin":false},"body":"This PR add an additional way to configure 'accountapp' trough environment variables that simplify deployment on kubernetes cluster.\r\n\r\nI added a docker-compose file only for testing purpose.\r\n\r\n! This PR doesn't take into account [#96](https://github.com/jenkins-infra/account-app/pull/96) as it is not up to date with master.","created_at":"2017-04-24T13:30:43Z","updated_at":"2017-04-24T15:59:21Z","closed_at":"2017-04-24T15:59:21Z","merged_at":"2017-04-24T15:59:21Z","merge_commit_sha":"6df93b17f3dd789af6811884e193176e12bcf405","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/jenkins-infra/account-app/pulls/103/commits","review_comments_url":"https://api.github.com/repos/jenkins-infra/account-app/pulls/103/comments","review_comment_url":"https://api.github.com/repos/jenkins-infra/account-app/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jenkins-infra/account-app/issues/103/comments","statuses_url":"https://api.github.com/repos/jenkins-infra/account-app/statuses/b47531272876b11647d837e9fafe84b5435dd86e","head":{"label":"olblak:config/01","ref":"config/01","sha":"b47531272876b11647d837e9fafe84b5435dd86e","user":{"login":"olblak","id":2360224,"avatar_url":"https://avatars2.githubusercontent.com/u/2360224?v=3","gravatar_id":"","url":"https://api.github.com/users/olblak","html_url":"https://github.com/olblak","followers_url":"https://api.github.com/users/olblak/followers","following_url":"https://api.github.com/users/olblak/following{/other_user}","gists_url":"https://api.github.com/users/olblak/gists{/gist_id}","starred_url":"https://api.github.com/users/olblak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olblak/subscriptions","organizations_url":"https://api.github.com/users/olblak/orgs","repos_url":"https://api.github.com/users/olblak/repos","events_url":"https://api.github.com/users/olblak/events{/privacy}","received_events_url":"https://api.github.com/users/olblak/received_events","type":"User","site_admin":false},"repo":{"id":88169369,"name":"account-app","full_name":"olblak/account-app","owner":{"login":"olblak","id":2360224,"avatar_url":"https://avatars2.githubusercontent.com/u/2360224?v=3","gravatar_id":"","url":"https://api.github.com/users/olblak","html_url":"https://github.com/olblak","followers_url":"https://api.github.com/users/olblak/followers","following_url":"https://api.github.com/users/olblak/following{/other_user}","gists_url":"https://api.github.com/users/olblak/gists{/gist_id}","starred_url":"https://api.github.com/users/olblak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olblak/subscriptions","organizations_url":"https://api.github.com/users/olblak/orgs","repos_url":"https://api.github.com/users/olblak/repos","events_url":"https://api.github.com/users/olblak/events{/privacy}","received_events_url":"https://api.github.com/users/olblak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/olblak/account-app","description":null,"fork":true,"url":"https://api.github.com/repos/olblak/account-app","forks_url":"https://api.github.com/repos/olblak/account-app/forks","keys_url":"https://api.github.com/repos/olblak/account-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/olblak/account-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/olblak/account-app/teams","hooks_url":"https://api.github.com/repos/olblak/account-app/hooks","issue_events_url":"https://api.github.com/repos/olblak/account-app/issues/events{/number}","events_url":"https://api.github.com/repos/olblak/account-app/events","assignees_url":"https://api.github.com/repos/olblak/account-app/assignees{/user}","branches_url":"https://api.github.com/repos/olblak/account-app/branches{/branch}","tags_url":"https://api.github.com/repos/olblak/account-app/tags","blobs_url":"https://api.github.com/repos/olblak/account-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/olblak/account-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/olblak/account-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/olblak/account-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/olblak/account-app/statuses/{sha}","languages_url":"https://api.github.com/repos/olblak/account-app/languages","stargazers_url":"https://api.github.com/repos/olblak/account-app/stargazers","contributors_url":"https://api.github.com/repos/olblak/account-app/contributors","subscribers_url":"https://api.github.com/repos/olblak/account-app/subscribers","subscription_url":"https://api.github.com/repos/olblak/account-app/subscription","commits_url":"https://api.github.com/repos/olblak/account-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/olblak/account-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/olblak/account-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/olblak/account-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/olblak/account-app/contents/{+path}","compare_url":"https://api.github.com/repos/olblak/account-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/olblak/account-app/merges","archive_url":"https://api.github.com/repos/olblak/account-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/olblak/account-app/downloads","issues_url":"https://api.github.com/repos/olblak/account-app/issues{/number}","pulls_url":"https://api.github.com/repos/olblak/account-app/pulls{/number}","milestones_url":"https://api.github.com/repos/olblak/account-app/milestones{/number}","notifications_url":"https://api.github.com/repos/olblak/account-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/olblak/account-app/labels{/name}","releases_url":"https://api.github.com/repos/olblak/account-app/releases{/id}","deployments_url":"https://api.github.com/repos/olblak/account-app/deployments","created_at":"2017-04-13T13:45:06Z","updated_at":"2017-04-13T13:45:07Z","pushed_at":"2017-04-24T13:29:32Z","git_url":"git://github.com/olblak/account-app.git","ssh_url":"git@github.com:olblak/account-app.git","clone_url":"https://github.com/olblak/account-app.git","svn_url":"https://github.com/olblak/account-app","homepage":"","size":386,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jenkins-infra:master","ref":"master","sha":"5a2c1ed8383e24e20dd008087741eeb283c64009","user":{"login":"jenkins-infra","id":7422698,"avatar_url":"https://avatars1.githubusercontent.com/u/7422698?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkins-infra","html_url":"https://github.com/jenkins-infra","followers_url":"https://api.github.com/users/jenkins-infra/followers","following_url":"https://api.github.com/users/jenkins-infra/following{/other_user}","gists_url":"https://api.github.com/users/jenkins-infra/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkins-infra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkins-infra/subscriptions","organizations_url":"https://api.github.com/users/jenkins-infra/orgs","repos_url":"https://api.github.com/users/jenkins-infra/repos","events_url":"https://api.github.com/users/jenkins-infra/events{/privacy}","received_events_url":"https://api.github.com/users/jenkins-infra/received_events","type":"Organization","site_admin":false},"repo":{"id":7154069,"name":"account-app","full_name":"jenkins-infra/account-app","owner":{"login":"jenkins-infra","id":7422698,"avatar_url":"https://avatars1.githubusercontent.com/u/7422698?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkins-infra","html_url":"https://github.com/jenkins-infra","followers_url":"https://api.github.com/users/jenkins-infra/followers","following_url":"https://api.github.com/users/jenkins-infra/following{/other_user}","gists_url":"https://api.github.com/users/jenkins-infra/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkins-infra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkins-infra/subscriptions","organizations_url":"https://api.github.com/users/jenkins-infra/orgs","repos_url":"https://api.github.com/users/jenkins-infra/repos","events_url":"https://api.github.com/users/jenkins-infra/events{/privacy}","received_events_url":"https://api.github.com/users/jenkins-infra/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jenkins-infra/account-app","description":null,"fork":false,"url":"https://api.github.com/repos/jenkins-infra/account-app","forks_url":"https://api.github.com/repos/jenkins-infra/account-app/forks","keys_url":"https://api.github.com/repos/jenkins-infra/account-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkins-infra/account-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkins-infra/account-app/teams","hooks_url":"https://api.github.com/repos/jenkins-infra/account-app/hooks","issue_events_url":"https://api.github.com/repos/jenkins-infra/account-app/issues/events{/number}","events_url":"https://api.github.com/repos/jenkins-infra/account-app/events","assignees_url":"https://api.github.com/repos/jenkins-infra/account-app/assignees{/user}","branches_url":"https://api.github.com/repos/jenkins-infra/account-app/branches{/branch}","tags_url":"https://api.github.com/repos/jenkins-infra/account-app/tags","blobs_url":"https://api.github.com/repos/jenkins-infra/account-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkins-infra/account-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkins-infra/account-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkins-infra/account-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkins-infra/account-app/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkins-infra/account-app/languages","stargazers_url":"https://api.github.com/repos/jenkins-infra/account-app/stargazers","contributors_url":"https://api.github.com/repos/jenkins-infra/account-app/contributors","subscribers_url":"https://api.github.com/repos/jenkins-infra/account-app/subscribers","subscription_url":"https://api.github.com/repos/jenkins-infra/account-app/subscription","commits_url":"https://api.github.com/repos/jenkins-infra/account-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkins-infra/account-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkins-infra/account-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkins-infra/account-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenkins-infra/account-app/contents/{+path}","compare_url":"https://api.github.com/repos/jenkins-infra/account-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkins-infra/account-app/merges","archive_url":"https://api.github.com/repos/jenkins-infra/account-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkins-infra/account-app/downloads","issues_url":"https://api.github.com/repos/jenkins-infra/account-app/issues{/number}","pulls_url":"https://api.github.com/repos/jenkins-infra/account-app/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkins-infra/account-app/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkins-infra/account-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkins-infra/account-app/labels{/name}","releases_url":"https://api.github.com/repos/jenkins-infra/account-app/releases{/id}","deployments_url":"https://api.github.com/repos/jenkins-infra/account-app/deployments","created_at":"2012-12-13T19:33:52Z","updated_at":"2017-01-17T06:20:06Z","pushed_at":"2017-04-24T15:59:21Z","git_url":"git://github.com/jenkins-infra/account-app.git","ssh_url":"git@github.com:jenkins-infra/account-app.git","clone_url":"https://github.com/jenkins-infra/account-app.git","svn_url":"https://github.com/jenkins-infra/account-app","homepage":"","size":386,"stargazers_count":5,"watchers_count":5,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":1,"forks":8,"open_issues":1,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jenkins-infra/account-app/pulls/103"},"html":{"href":"https://github.com/jenkins-infra/account-app/pull/103"},"issue":{"href":"https://api.github.com/repos/jenkins-infra/account-app/issues/103"},"comments":{"href":"https://api.github.com/repos/jenkins-infra/account-app/issues/103/comments"},"review_comments":{"href":"https://api.github.com/repos/jenkins-infra/account-app/pulls/103/comments"},"review_comment":{"href":"https://api.github.com/repos/jenkins-infra/account-app/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jenkins-infra/account-app/pulls/103/commits"},"statuses":{"href":"https://api.github.com/repos/jenkins-infra/account-app/statuses/b47531272876b11647d837e9fafe84b5435dd86e"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"rtyler","id":26594,"avatar_url":"https://avatars3.githubusercontent.com/u/26594?v=3","gravatar_id":"","url":"https://api.github.com/users/rtyler","html_url":"https://github.com/rtyler","followers_url":"https://api.github.com/users/rtyler/followers","following_url":"https://api.github.com/users/rtyler/following{/other_user}","gists_url":"https://api.github.com/users/rtyler/gists{/gist_id}","starred_url":"https://api.github.com/users/rtyler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rtyler/subscriptions","organizations_url":"https://api.github.com/users/rtyler/orgs","repos_url":"https://api.github.com/users/rtyler/repos","events_url":"https://api.github.com/users/rtyler/events{/privacy}","received_events_url":"https://api.github.com/users/rtyler/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":145,"deletions":9,"changed_files":6}}
{"actor":{"display_login":"rtyler"}}