{"action":"created","issue":{"url":"https://api.github.com/repos/CartoDB/deep-insights.js/issues/566","repository_url":"https://api.github.com/repos/CartoDB/deep-insights.js","labels_url":"https://api.github.com/repos/CartoDB/deep-insights.js/issues/566/labels{/name}","comments_url":"https://api.github.com/repos/CartoDB/deep-insights.js/issues/566/comments","events_url":"https://api.github.com/repos/CartoDB/deep-insights.js/issues/566/events","html_url":"https://github.com/CartoDB/deep-insights.js/pull/566","id":247009928,"number":566,"title":"widgets: time-series: responsive [WIP]","user":{"login":"matallo","id":36676,"avatar_url":"https://avatars2.githubusercontent.com/u/36676?v=4","gravatar_id":"","url":"https://api.github.com/users/matallo","html_url":"https://github.com/matallo","followers_url":"https://api.github.com/users/matallo/followers","following_url":"https://api.github.com/users/matallo/following{/other_user}","gists_url":"https://api.github.com/users/matallo/gists{/gist_id}","starred_url":"https://api.github.com/users/matallo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matallo/subscriptions","organizations_url":"https://api.github.com/users/matallo/orgs","repos_url":"https://api.github.com/users/matallo/repos","events_url":"https://api.github.com/users/matallo/events{/privacy}","received_events_url":"https://api.github.com/users/matallo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-08-01T09:33:14Z","updated_at":"2017-08-03T17:50:06Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/CartoDB/deep-insights.js/pulls/566","html_url":"https://github.com/CartoDB/deep-insights.js/pull/566","diff_url":"https://github.com/CartoDB/deep-insights.js/pull/566.diff","patch_url":"https://github.com/CartoDB/deep-insights.js/pull/566.patch"},"body":"re: https://github.com/CartoDB/cartodb/issues/12470\r\n\r\nthis will eventually point to `master`, when https://github.com/CartoDB/deep-insights.js/pull/562 is merged\r\n\r\n---\r\n\r\ncartodb PR: https://github.com/CartoDB/cartodb/pull/12543\r\ndeep-insights.js PR: https://github.com/CartoDB/deep-insights.js/pull/566\r\ncartodb.js PR: https://github.com/CartoDB/cartodb.js/pull/1709\r\n\r\n---\r\n\r\npulling the changes from time-series aggregations, and timezones, plus:\r\n\r\n- [x] implemented responsive behaviour for Tablet and Mobile viewports\r\n- [x] added timeslider tip to timeslider view, and static tips to time-slider header\r\n- [x] added viewport utils\r\n- [ ] tests\r\n\r\nthere's only one thing I'm not specially happy about which is updating the static tips, when dragging the handles, however I couldn't find a better approach using the rangeFilter, as it is only updated on brush end\r\n\r\n**acceptance**\r\n\r\n- test time-series, animated time-series, AND normal histogram in desktop, tablet, and mobile viewport, selecting range, playing, and updating the timezone and local timezone for timestamps\r\n- heights should vary\r\n- timestamps should vary, and update on dragging and click interactions\r\n- tips should change behaviour\r\n\r\ntest again with `number` type column, they should work as expected\r\n\r\ncheck the Invision project for the designs"},"comment":{"url":"https://api.github.com/repos/CartoDB/deep-insights.js/issues/comments/320042061","html_url":"https://github.com/CartoDB/deep-insights.js/pull/566#issuecomment-320042061","issue_url":"https://api.github.com/repos/CartoDB/deep-insights.js/issues/566","id":320042061,"user":{"login":"matallo","id":36676,"avatar_url":"https://avatars2.githubusercontent.com/u/36676?v=4","gravatar_id":"","url":"https://api.github.com/users/matallo","html_url":"https://github.com/matallo","followers_url":"https://api.github.com/users/matallo/followers","following_url":"https://api.github.com/users/matallo/following{/other_user}","gists_url":"https://api.github.com/users/matallo/gists{/gist_id}","starred_url":"https://api.github.com/users/matallo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matallo/subscriptions","organizations_url":"https://api.github.com/users/matallo/orgs","repos_url":"https://api.github.com/users/matallo/repos","events_url":"https://api.github.com/users/matallo/events{/privacy}","received_events_url":"https://api.github.com/users/matallo/received_events","type":"User","site_admin":false},"created_at":"2017-08-03T17:50:06Z","updated_at":"2017-08-03T17:50:06Z","body":"finished the specs, I didn't test the X position for the tip at the beginning / middle / end of the timeline, just the Y because it could be crazytown (and it wasn't actually the scope of the PR, just for the timeslider tip)"}}
{"actor":{"display_login":"matallo"}}