{"action":"created","comment":{"url":"https://api.github.com/repos/RestComm/mediaserver/pulls/comments/153578878","pull_request_review_id":79605232,"id":153578878,"diff_hunk":"@@ -36,21 +36,21 @@\n  */\n public class MgcpChannelInitializer extends ChannelInitializer<Channel> {\n \n-    private static final int BUFFER_SIZE = 5000;\n+    private static int mgcpBufferSize;\n     private static final ChannelHandler[] NO_HANDLERS = new ChannelHandler[0];\n \n     private final ChannelHandler[] handlers;\n \n-    public MgcpChannelInitializer(ChannelHandler... handlers) {\n-        this.handlers = (handlers == null || handlers.length == 0) ? NO_HANDLERS : handlers;\n+    public MgcpChannelInitializer(int mgcpBufferSize, ChannelHandler... handlers) {","path":"controls/mgcp2/src/main/java/org/restcomm/media/control/mgcp/network/netty/MgcpChannelInitializer.java","position":null,"original_position":12,"commit_id":"3dde84f36f183ff3b27a48885b10b122af67155b","original_commit_id":"589240dd8b143e483e07a97b0726db1364e5f0a9","user":{"login":"ibrarahmad","id":3592946,"avatar_url":"https://avatars1.githubusercontent.com/u/3592946?v=4","gravatar_id":"","url":"https://api.github.com/users/ibrarahmad","html_url":"https://github.com/ibrarahmad","followers_url":"https://api.github.com/users/ibrarahmad/followers","following_url":"https://api.github.com/users/ibrarahmad/following{/other_user}","gists_url":"https://api.github.com/users/ibrarahmad/gists{/gist_id}","starred_url":"https://api.github.com/users/ibrarahmad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibrarahmad/subscriptions","organizations_url":"https://api.github.com/users/ibrarahmad/orgs","repos_url":"https://api.github.com/users/ibrarahmad/repos","events_url":"https://api.github.com/users/ibrarahmad/events{/privacy}","received_events_url":"https://api.github.com/users/ibrarahmad/received_events","type":"User","site_admin":false},"body":"I have created new constructor to avoid backward compatibility. ","created_at":"2017-11-28T18:19:11Z","updated_at":"2017-11-28T18:19:11Z","html_url":"https://github.com/RestComm/mediaserver/pull/700#discussion_r153578878","pull_request_url":"https://api.github.com/repos/RestComm/mediaserver/pulls/700","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/RestComm/mediaserver/pulls/comments/153578878"},"html":{"href":"https://github.com/RestComm/mediaserver/pull/700#discussion_r153578878"},"pull_request":{"href":"https://api.github.com/repos/RestComm/mediaserver/pulls/700"}},"in_reply_to_id":153524598},"pull_request":{"url":"https://api.github.com/repos/RestComm/mediaserver/pulls/700","id":154899169,"html_url":"https://github.com/RestComm/mediaserver/pull/700","diff_url":"https://github.com/RestComm/mediaserver/pull/700.diff","patch_url":"https://github.com/RestComm/mediaserver/pull/700.patch","issue_url":"https://api.github.com/repos/RestComm/mediaserver/issues/700","number":700,"state":"open","locked":false,"title":"#476 Make MGCP channel buffer size configurable.","user":{"login":"ibrarahmad","id":3592946,"avatar_url":"https://avatars1.githubusercontent.com/u/3592946?v=4","gravatar_id":"","url":"https://api.github.com/users/ibrarahmad","html_url":"https://github.com/ibrarahmad","followers_url":"https://api.github.com/users/ibrarahmad/followers","following_url":"https://api.github.com/users/ibrarahmad/following{/other_user}","gists_url":"https://api.github.com/users/ibrarahmad/gists{/gist_id}","starred_url":"https://api.github.com/users/ibrarahmad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibrarahmad/subscriptions","organizations_url":"https://api.github.com/users/ibrarahmad/orgs","repos_url":"https://api.github.com/users/ibrarahmad/repos","events_url":"https://api.github.com/users/ibrarahmad/events{/privacy}","received_events_url":"https://api.github.com/users/ibrarahmad/received_events","type":"User","site_admin":false},"body":"A new configuration parameter added in mediaserver.xml file called mgcpBuffer's size. The default value for that variable set to 5000.","created_at":"2017-11-27T19:43:43Z","updated_at":"2017-11-28T18:19:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fc305159d3f2c6da702e7e8f9339783a8fe07259","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/RestComm/mediaserver/pulls/700/commits","review_comments_url":"https://api.github.com/repos/RestComm/mediaserver/pulls/700/comments","review_comment_url":"https://api.github.com/repos/RestComm/mediaserver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RestComm/mediaserver/issues/700/comments","statuses_url":"https://api.github.com/repos/RestComm/mediaserver/statuses/3dde84f36f183ff3b27a48885b10b122af67155b","head":{"label":"ibrarahmad:feature-branch","ref":"feature-branch","sha":"3dde84f36f183ff3b27a48885b10b122af67155b","user":{"login":"ibrarahmad","id":3592946,"avatar_url":"https://avatars1.githubusercontent.com/u/3592946?v=4","gravatar_id":"","url":"https://api.github.com/users/ibrarahmad","html_url":"https://github.com/ibrarahmad","followers_url":"https://api.github.com/users/ibrarahmad/followers","following_url":"https://api.github.com/users/ibrarahmad/following{/other_user}","gists_url":"https://api.github.com/users/ibrarahmad/gists{/gist_id}","starred_url":"https://api.github.com/users/ibrarahmad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibrarahmad/subscriptions","organizations_url":"https://api.github.com/users/ibrarahmad/orgs","repos_url":"https://api.github.com/users/ibrarahmad/repos","events_url":"https://api.github.com/users/ibrarahmad/events{/privacy}","received_events_url":"https://api.github.com/users/ibrarahmad/received_events","type":"User","site_admin":false},"repo":{"id":112239581,"name":"mediaserver","full_name":"ibrarahmad/mediaserver","owner":{"login":"ibrarahmad","id":3592946,"avatar_url":"https://avatars1.githubusercontent.com/u/3592946?v=4","gravatar_id":"","url":"https://api.github.com/users/ibrarahmad","html_url":"https://github.com/ibrarahmad","followers_url":"https://api.github.com/users/ibrarahmad/followers","following_url":"https://api.github.com/users/ibrarahmad/following{/other_user}","gists_url":"https://api.github.com/users/ibrarahmad/gists{/gist_id}","starred_url":"https://api.github.com/users/ibrarahmad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibrarahmad/subscriptions","organizations_url":"https://api.github.com/users/ibrarahmad/orgs","repos_url":"https://api.github.com/users/ibrarahmad/repos","events_url":"https://api.github.com/users/ibrarahmad/events{/privacy}","received_events_url":"https://api.github.com/users/ibrarahmad/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ibrarahmad/mediaserver","description":"RMS - Restcomm Media Server for Real Time Cloud Communications","fork":true,"url":"https://api.github.com/repos/ibrarahmad/mediaserver","forks_url":"https://api.github.com/repos/ibrarahmad/mediaserver/forks","keys_url":"https://api.github.com/repos/ibrarahmad/mediaserver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ibrarahmad/mediaserver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ibrarahmad/mediaserver/teams","hooks_url":"https://api.github.com/repos/ibrarahmad/mediaserver/hooks","issue_events_url":"https://api.github.com/repos/ibrarahmad/mediaserver/issues/events{/number}","events_url":"https://api.github.com/repos/ibrarahmad/mediaserver/events","assignees_url":"https://api.github.com/repos/ibrarahmad/mediaserver/assignees{/user}","branches_url":"https://api.github.com/repos/ibrarahmad/mediaserver/branches{/branch}","tags_url":"https://api.github.com/repos/ibrarahmad/mediaserver/tags","blobs_url":"https://api.github.com/repos/ibrarahmad/mediaserver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ibrarahmad/mediaserver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ibrarahmad/mediaserver/git/refs{/sha}","trees_url":"https://api.github.com/repos/ibrarahmad/mediaserver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ibrarahmad/mediaserver/statuses/{sha}","languages_url":"https://api.github.com/repos/ibrarahmad/mediaserver/languages","stargazers_url":"https://api.github.com/repos/ibrarahmad/mediaserver/stargazers","contributors_url":"https://api.github.com/repos/ibrarahmad/mediaserver/contributors","subscribers_url":"https://api.github.com/repos/ibrarahmad/mediaserver/subscribers","subscription_url":"https://api.github.com/repos/ibrarahmad/mediaserver/subscription","commits_url":"https://api.github.com/repos/ibrarahmad/mediaserver/commits{/sha}","git_commits_url":"https://api.github.com/repos/ibrarahmad/mediaserver/git/commits{/sha}","comments_url":"https://api.github.com/repos/ibrarahmad/mediaserver/comments{/number}","issue_comment_url":"https://api.github.com/repos/ibrarahmad/mediaserver/issues/comments{/number}","contents_url":"https://api.github.com/repos/ibrarahmad/mediaserver/contents/{+path}","compare_url":"https://api.github.com/repos/ibrarahmad/mediaserver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ibrarahmad/mediaserver/merges","archive_url":"https://api.github.com/repos/ibrarahmad/mediaserver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ibrarahmad/mediaserver/downloads","issues_url":"https://api.github.com/repos/ibrarahmad/mediaserver/issues{/number}","pulls_url":"https://api.github.com/repos/ibrarahmad/mediaserver/pulls{/number}","milestones_url":"https://api.github.com/repos/ibrarahmad/mediaserver/milestones{/number}","notifications_url":"https://api.github.com/repos/ibrarahmad/mediaserver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ibrarahmad/mediaserver/labels{/name}","releases_url":"https://api.github.com/repos/ibrarahmad/mediaserver/releases{/id}","deployments_url":"https://api.github.com/repos/ibrarahmad/mediaserver/deployments","created_at":"2017-11-27T19:33:59Z","updated_at":"2017-11-27T19:34:05Z","pushed_at":"2017-11-28T18:17:07Z","git_url":"git://github.com/ibrarahmad/mediaserver.git","ssh_url":"git@github.com:ibrarahmad/mediaserver.git","clone_url":"https://github.com/ibrarahmad/mediaserver.git","svn_url":"https://github.com/ibrarahmad/mediaserver","homepage":"","size":94648,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"RestComm:master","ref":"master","sha":"76dc378a1ba7acf78067d12c5ce65ccc96eb7e78","user":{"login":"RestComm","id":667380,"avatar_url":"https://avatars3.githubusercontent.com/u/667380?v=4","gravatar_id":"","url":"https://api.github.com/users/RestComm","html_url":"https://github.com/RestComm","followers_url":"https://api.github.com/users/RestComm/followers","following_url":"https://api.github.com/users/RestComm/following{/other_user}","gists_url":"https://api.github.com/users/RestComm/gists{/gist_id}","starred_url":"https://api.github.com/users/RestComm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RestComm/subscriptions","organizations_url":"https://api.github.com/users/RestComm/orgs","repos_url":"https://api.github.com/users/RestComm/repos","events_url":"https://api.github.com/users/RestComm/events{/privacy}","received_events_url":"https://api.github.com/users/RestComm/received_events","type":"Organization","site_admin":false},"repo":{"id":5455433,"name":"mediaserver","full_name":"RestComm/mediaserver","owner":{"login":"RestComm","id":667380,"avatar_url":"https://avatars3.githubusercontent.com/u/667380?v=4","gravatar_id":"","url":"https://api.github.com/users/RestComm","html_url":"https://github.com/RestComm","followers_url":"https://api.github.com/users/RestComm/followers","following_url":"https://api.github.com/users/RestComm/following{/other_user}","gists_url":"https://api.github.com/users/RestComm/gists{/gist_id}","starred_url":"https://api.github.com/users/RestComm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RestComm/subscriptions","organizations_url":"https://api.github.com/users/RestComm/orgs","repos_url":"https://api.github.com/users/RestComm/repos","events_url":"https://api.github.com/users/RestComm/events{/privacy}","received_events_url":"https://api.github.com/users/RestComm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RestComm/mediaserver","description":"RMS - Restcomm Media Server for Real Time Cloud Communications","fork":false,"url":"https://api.github.com/repos/RestComm/mediaserver","forks_url":"https://api.github.com/repos/RestComm/mediaserver/forks","keys_url":"https://api.github.com/repos/RestComm/mediaserver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RestComm/mediaserver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RestComm/mediaserver/teams","hooks_url":"https://api.github.com/repos/RestComm/mediaserver/hooks","issue_events_url":"https://api.github.com/repos/RestComm/mediaserver/issues/events{/number}","events_url":"https://api.github.com/repos/RestComm/mediaserver/events","assignees_url":"https://api.github.com/repos/RestComm/mediaserver/assignees{/user}","branches_url":"https://api.github.com/repos/RestComm/mediaserver/branches{/branch}","tags_url":"https://api.github.com/repos/RestComm/mediaserver/tags","blobs_url":"https://api.github.com/repos/RestComm/mediaserver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RestComm/mediaserver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RestComm/mediaserver/git/refs{/sha}","trees_url":"https://api.github.com/repos/RestComm/mediaserver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RestComm/mediaserver/statuses/{sha}","languages_url":"https://api.github.com/repos/RestComm/mediaserver/languages","stargazers_url":"https://api.github.com/repos/RestComm/mediaserver/stargazers","contributors_url":"https://api.github.com/repos/RestComm/mediaserver/contributors","subscribers_url":"https://api.github.com/repos/RestComm/mediaserver/subscribers","subscription_url":"https://api.github.com/repos/RestComm/mediaserver/subscription","commits_url":"https://api.github.com/repos/RestComm/mediaserver/commits{/sha}","git_commits_url":"https://api.github.com/repos/RestComm/mediaserver/git/commits{/sha}","comments_url":"https://api.github.com/repos/RestComm/mediaserver/comments{/number}","issue_comment_url":"https://api.github.com/repos/RestComm/mediaserver/issues/comments{/number}","contents_url":"https://api.github.com/repos/RestComm/mediaserver/contents/{+path}","compare_url":"https://api.github.com/repos/RestComm/mediaserver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RestComm/mediaserver/merges","archive_url":"https://api.github.com/repos/RestComm/mediaserver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RestComm/mediaserver/downloads","issues_url":"https://api.github.com/repos/RestComm/mediaserver/issues{/number}","pulls_url":"https://api.github.com/repos/RestComm/mediaserver/pulls{/number}","milestones_url":"https://api.github.com/repos/RestComm/mediaserver/milestones{/number}","notifications_url":"https://api.github.com/repos/RestComm/mediaserver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RestComm/mediaserver/labels{/name}","releases_url":"https://api.github.com/repos/RestComm/mediaserver/releases{/id}","deployments_url":"https://api.github.com/repos/RestComm/mediaserver/deployments","created_at":"2012-08-17T17:45:39Z","updated_at":"2017-11-24T07:11:51Z","pushed_at":"2017-11-28T18:17:08Z","git_url":"git://github.com/RestComm/mediaserver.git","ssh_url":"git@github.com:RestComm/mediaserver.git","clone_url":"https://github.com/RestComm/mediaserver.git","svn_url":"https://github.com/RestComm/mediaserver","homepage":"","size":94704,"stargazers_count":80,"watchers_count":80,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":82,"mirror_url":null,"archived":false,"open_issues_count":199,"forks":82,"open_issues":199,"watchers":80,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RestComm/mediaserver/pulls/700"},"html":{"href":"https://github.com/RestComm/mediaserver/pull/700"},"issue":{"href":"https://api.github.com/repos/RestComm/mediaserver/issues/700"},"comments":{"href":"https://api.github.com/repos/RestComm/mediaserver/issues/700/comments"},"review_comments":{"href":"https://api.github.com/repos/RestComm/mediaserver/pulls/700/comments"},"review_comment":{"href":"https://api.github.com/repos/RestComm/mediaserver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RestComm/mediaserver/pulls/700/commits"},"statuses":{"href":"https://api.github.com/repos/RestComm/mediaserver/statuses/3dde84f36f183ff3b27a48885b10b122af67155b"}},"author_association":"NONE"}}
{"actor":{"display_login":"ibrarahmad"}}