{"action":"created","issue":{"url":"https://api.github.com/repos/cundd/rest/issues/39","repository_url":"https://api.github.com/repos/cundd/rest","labels_url":"https://api.github.com/repos/cundd/rest/issues/39/labels{/name}","comments_url":"https://api.github.com/repos/cundd/rest/issues/39/comments","events_url":"https://api.github.com/repos/cundd/rest/issues/39/events","html_url":"https://github.com/cundd/rest/pull/39","id":255885636,"number":39,"title":"No access control on OPTIONS method","user":{"login":"stuartmcfarlane","id":695727,"avatar_url":"https://avatars2.githubusercontent.com/u/695727?v=4","gravatar_id":"","url":"https://api.github.com/users/stuartmcfarlane","html_url":"https://github.com/stuartmcfarlane","followers_url":"https://api.github.com/users/stuartmcfarlane/followers","following_url":"https://api.github.com/users/stuartmcfarlane/following{/other_user}","gists_url":"https://api.github.com/users/stuartmcfarlane/gists{/gist_id}","starred_url":"https://api.github.com/users/stuartmcfarlane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stuartmcfarlane/subscriptions","organizations_url":"https://api.github.com/users/stuartmcfarlane/orgs","repos_url":"https://api.github.com/users/stuartmcfarlane/repos","events_url":"https://api.github.com/users/stuartmcfarlane/events{/privacy}","received_events_url":"https://api.github.com/users/stuartmcfarlane/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-09-07T10:11:13Z","updated_at":"2017-09-07T11:04:42Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/cundd/rest/pulls/39","html_url":"https://github.com/cundd/rest/pull/39","diff_url":"https://github.com/cundd/rest/pull/39.diff","patch_url":"https://github.com/cundd/rest/pull/39.patch"},"body":"The OPTIONS method is neither a read nor write\r\noperation. When used for preflight CORS header\r\ndiscovery no auth can be sent.\r\n\r\nThis solution changed the isWrite method to\r\nassert that an OPTIONS request is not a write\r\nrequest. Further the ConfigurationBasedAccessController\r\nis changed to allow requests are neither read\r\nnor write."},"comment":{"url":"https://api.github.com/repos/cundd/rest/issues/comments/327767644","html_url":"https://github.com/cundd/rest/pull/39#issuecomment-327767644","issue_url":"https://api.github.com/repos/cundd/rest/issues/39","id":327767644,"user":{"login":"cundd","id":743122,"avatar_url":"https://avatars2.githubusercontent.com/u/743122?v=4","gravatar_id":"","url":"https://api.github.com/users/cundd","html_url":"https://github.com/cundd","followers_url":"https://api.github.com/users/cundd/followers","following_url":"https://api.github.com/users/cundd/following{/other_user}","gists_url":"https://api.github.com/users/cundd/gists{/gist_id}","starred_url":"https://api.github.com/users/cundd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cundd/subscriptions","organizations_url":"https://api.github.com/users/cundd/orgs","repos_url":"https://api.github.com/users/cundd/repos","events_url":"https://api.github.com/users/cundd/events{/privacy}","received_events_url":"https://api.github.com/users/cundd/received_events","type":"User","site_admin":false},"created_at":"2017-09-07T11:04:42Z","updated_at":"2017-09-07T11:04:42Z","author_association":"OWNER","body":"Thank you for the clarification. I think I would prefer a separate method in addition to `isRead` and `isWrite`. Maybe called `isPreflight` or just `isOption`."}}
{"actor":{"display_login":"cundd"}}