{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/corefx/issues/19525","repository_url":"https://api.github.com/repos/dotnet/corefx","labels_url":"https://api.github.com/repos/dotnet/corefx/issues/19525/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/19525/comments","events_url":"https://api.github.com/repos/dotnet/corefx/issues/19525/events","html_url":"https://github.com/dotnet/corefx/pull/19525","id":227268076,"number":19525,"title":"Enable System.Net.Requests.Tests to run in parallel again","user":{"login":"safern","id":22899328,"avatar_url":"https://avatars2.githubusercontent.com/u/22899328?v=3","gravatar_id":"","url":"https://api.github.com/users/safern","html_url":"https://github.com/safern","followers_url":"https://api.github.com/users/safern/followers","following_url":"https://api.github.com/users/safern/following{/other_user}","gists_url":"https://api.github.com/users/safern/gists{/gist_id}","starred_url":"https://api.github.com/users/safern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/safern/subscriptions","organizations_url":"https://api.github.com/users/safern/orgs","repos_url":"https://api.github.com/users/safern/repos","events_url":"https://api.github.com/users/safern/events{/privacy}","received_events_url":"https://api.github.com/users/safern/received_events","type":"User","site_admin":false},"labels":[{"id":497898703,"url":"https://api.github.com/repos/dotnet/corefx/labels/area-System.Net.Http","name":"area-System.Net.Http","color":"d4c5f9","default":false},{"id":197706871,"url":"https://api.github.com/repos/dotnet/corefx/labels/cla-already-signed","name":"cla-already-signed","color":"009800","default":false}],"state":"open","locked":false,"assignee":{"login":"safern","id":22899328,"avatar_url":"https://avatars2.githubusercontent.com/u/22899328?v=3","gravatar_id":"","url":"https://api.github.com/users/safern","html_url":"https://github.com/safern","followers_url":"https://api.github.com/users/safern/followers","following_url":"https://api.github.com/users/safern/following{/other_user}","gists_url":"https://api.github.com/users/safern/gists{/gist_id}","starred_url":"https://api.github.com/users/safern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/safern/subscriptions","organizations_url":"https://api.github.com/users/safern/orgs","repos_url":"https://api.github.com/users/safern/repos","events_url":"https://api.github.com/users/safern/events{/privacy}","received_events_url":"https://api.github.com/users/safern/received_events","type":"User","site_admin":false},"assignees":[{"login":"safern","id":22899328,"avatar_url":"https://avatars2.githubusercontent.com/u/22899328?v=3","gravatar_id":"","url":"https://api.github.com/users/safern","html_url":"https://github.com/safern","followers_url":"https://api.github.com/users/safern/followers","following_url":"https://api.github.com/users/safern/following{/other_user}","gists_url":"https://api.github.com/users/safern/gists{/gist_id}","starred_url":"https://api.github.com/users/safern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/safern/subscriptions","organizations_url":"https://api.github.com/users/safern/orgs","repos_url":"https://api.github.com/users/safern/repos","events_url":"https://api.github.com/users/safern/events{/privacy}","received_events_url":"https://api.github.com/users/safern/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/dotnet/corefx/milestones/4","html_url":"https://github.com/dotnet/corefx/milestone/4","labels_url":"https://api.github.com/repos/dotnet/corefx/milestones/4/labels","id":1248719,"number":4,"title":"2.0.0","description":".NET Core 2.0, next major release. The due date 5/10 is [ZBB](https://github.com/dotnet/corefx/issues/17619) and expected time of last FI from master into release branch. See [official release dates](https://github.com/dotnet/core/blob/master/roadmap.md) for details.","creator":{"login":"joshfree","id":1302850,"avatar_url":"https://avatars2.githubusercontent.com/u/1302850?v=3","gravatar_id":"","url":"https://api.github.com/users/joshfree","html_url":"https://github.com/joshfree","followers_url":"https://api.github.com/users/joshfree/followers","following_url":"https://api.github.com/users/joshfree/following{/other_user}","gists_url":"https://api.github.com/users/joshfree/gists{/gist_id}","starred_url":"https://api.github.com/users/joshfree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshfree/subscriptions","organizations_url":"https://api.github.com/users/joshfree/orgs","repos_url":"https://api.github.com/users/joshfree/repos","events_url":"https://api.github.com/users/joshfree/events{/privacy}","received_events_url":"https://api.github.com/users/joshfree/received_events","type":"User","site_admin":false},"open_issues":62,"closed_issues":7769,"state":"open","created_at":"2015-08-10T18:04:00Z","updated_at":"2017-05-09T14:05:51Z","due_on":"2017-05-10T07:00:00Z","closed_at":null},"comments":3,"created_at":"2017-05-09T06:56:21Z","updated_at":"2017-05-09T15:32:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/19525","html_url":"https://github.com/dotnet/corefx/pull/19525","diff_url":"https://github.com/dotnet/corefx/pull/19525.diff","patch_url":"https://github.com/dotnet/corefx/pull/19525.patch"},"body":"In helix the timeout is to small that the tests where timing out when running not in parallel. Parallelization was disabled to avoid hangs due to ServicePointManager.DefaultConnectionLimit small limit in Desktop, but we already take care of that by setting it to int.MaxValue, so we can enable paralellization again to avoid time out issues.\r\n\r\nThe errors we where getting where like this one: \r\n```\r\n2017-05-09 06:09:40,006: INFO: proc(54): run_and_log_output: Output: xUnit.net Console Runner (64-bit Desktop .NET 4.0.30319.42000)\r\n2017-05-09 06:09:40,131: INFO: proc(54): run_and_log_output: Output:   Discovering: System.Net.Requests.Tests\r\n2017-05-09 06:09:40,334: INFO: proc(54): run_and_log_output: Output:   Discovered:  System.Net.Requests.Tests\r\n2017-05-09 06:09:40,349: INFO: proc(54): run_and_log_output: Output:   Starting:    System.Net.Requests.Tests\r\n2017-05-09 06:11:42,687: INFO: proc(54): run_and_log_output: Output:     System.Net.Tests.HttpWebRequestTest.ContentLength_SetAfterRequestSubmitted_ThrowsInvalidOperationException(remoteServer: http://corefx-net.cloudapp.net/Echo.ashx) [FAIL]\r\n2017-05-09 06:11:42,687: INFO: proc(54): run_and_log_output: Output:       System.Net.WebException : The operation has timed out\r\n2017-05-09 06:11:42,701: INFO: proc(54): run_and_log_output: Output:       Stack Trace:\r\n2017-05-09 06:11:42,701: INFO: proc(54): run_and_log_output: Output:            at System.Net.HttpWebRequest.GetResponse()\r\n2017-05-09 06:11:42,701: INFO: proc(54): run_and_log_output: Output:         D:\\repos\\corefx\\src\\System.Net.Requests\\tests\\HttpWebRequestTest.cs(146,0): at System.Net.Tests.HttpWebRequestTest.ContentLength_SetAfterRequestSubmitted_ThrowsInvalidOperationException(Uri remoteServer)\r\n```\r\n\r\nSometimes it wouldn't even show a test failure, it would just not finish running.\r\n\r\ncc: @danmosemsft "},"comment":{"url":"https://api.github.com/repos/dotnet/corefx/issues/comments/300202756","html_url":"https://github.com/dotnet/corefx/pull/19525#issuecomment-300202756","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/19525","id":300202756,"user":{"login":"davidsh","id":7684835,"avatar_url":"https://avatars3.githubusercontent.com/u/7684835?v=3","gravatar_id":"","url":"https://api.github.com/users/davidsh","html_url":"https://github.com/davidsh","followers_url":"https://api.github.com/users/davidsh/followers","following_url":"https://api.github.com/users/davidsh/following{/other_user}","gists_url":"https://api.github.com/users/davidsh/gists{/gist_id}","starred_url":"https://api.github.com/users/davidsh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidsh/subscriptions","organizations_url":"https://api.github.com/users/davidsh/orgs","repos_url":"https://api.github.com/users/davidsh/repos","events_url":"https://api.github.com/users/davidsh/events{/privacy}","received_events_url":"https://api.github.com/users/davidsh/received_events","type":"User","site_admin":false},"created_at":"2017-05-09T15:32:45Z","updated_at":"2017-05-09T15:32:45Z","body":">In helix the timeout is to small that the tests where timing out when running not in parallel. \r\n\r\nWhat sort of \"timeout\" are you talking about? Was this timeout something different than timeouts in HttpClient etc.?\r\n\r\nAnd regarding this:\r\n\r\n>I'd suggest auditing the tests in the assembly looking for places where process-wide state is being mutated,\r\n\r\nWouldn't running these tests (both inner and outer loop) as a dev machine help flush out problems before we merge this?\r\n\r\n"}}
{"actor":{"display_login":"davidsh"}}