{"action":"created","issue":{"url":"https://api.github.com/repos/openwrt/luci/issues/962","repository_url":"https://api.github.com/repos/openwrt/luci","labels_url":"https://api.github.com/repos/openwrt/luci/issues/962/labels{/name}","comments_url":"https://api.github.com/repos/openwrt/luci/issues/962/comments","events_url":"https://api.github.com/repos/openwrt/luci/issues/962/events","html_url":"https://github.com/openwrt/luci/issues/962","id":202024071,"number":962,"title":"Confusing Buttons in /view/admin_uci/changes.htm \"Unsaved Changes\" Page: consider renaming? Cleanup Page.","user":{"login":"NvrBst","id":963526,"avatar_url":"https://avatars.githubusercontent.com/u/963526?v=3","gravatar_id":"","url":"https://api.github.com/users/NvrBst","html_url":"https://github.com/NvrBst","followers_url":"https://api.github.com/users/NvrBst/followers","following_url":"https://api.github.com/users/NvrBst/following{/other_user}","gists_url":"https://api.github.com/users/NvrBst/gists{/gist_id}","starred_url":"https://api.github.com/users/NvrBst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NvrBst/subscriptions","organizations_url":"https://api.github.com/users/NvrBst/orgs","repos_url":"https://api.github.com/users/NvrBst/repos","events_url":"https://api.github.com/users/NvrBst/events{/privacy}","received_events_url":"https://api.github.com/users/NvrBst/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2017-01-20T01:27:00Z","updated_at":"2017-01-22T23:22:36Z","closed_at":null,"body":"This is more opinions, but are all easy to change, and would make the \"Unsaved Changes\" page a lot clearer to new users. Basic ideas to clean up the /view/admin_uci/changes.htm page.\r\n\r\n**REORDER THE BUTTONS:** \"Apply & Save\", \"Apply\",  then \"Revert\"\r\nTo match the rest of luci's button ordering which is: \"Save & Apply\", \"Save\", \"Revert\". Except on the changes page, it says \"Apply\", \"Apply & Save\" then \"Revert\". Should order them to the **\"Apply & Save\", \"Apply\",  then \"Revert\"**, to more closely match luci's button theme.\r\n\r\n**CONFUSING \"Unsaved Changes\" BUTTON**: Rename to something else\r\nWhen you make changes and click the \"Save\" button it goes into the \"UNSAVED Changes\" page. This doesn't really make sense that clicking \"Save\" moves something to \"Unsaved\". This page is more of a \"Unapplied Changes\" or \"Not Applied Changes\" or just a log of changes, which could be just renamed to \"Changelog\". I would rename it to what it is, just a \"Log of Changes\", or **\"Changelog\"** where when u make a change and save it, it goes into the log, and you can \"Apply\" the changes or \"Revert\" in that page. This button is named in the theme's header.htm, so someone would have to alter the 4 theme's header.htm name to change this button's name.\r\n\r\n**CONFUSING \"Apply & Save\" vs \"Apply\" BUTTON ON UNSAVED CHANGES PAGE**: Rename \"Apply & Save\" to something else\r\n_Not to be confused with the \"Save & Apply\" button found everywhere else._ The \"Apply & Save\" button is very confusing. We already clicked a \"Save\" button to put changes into this page, and now we have a Log of all the changes, what will \"Apply & Save\" do over just \"Apply\". This is a VERY confusing button. \"Save\" and \"Apply\" in this sense mean the same thing, since the changes are already \"saved\".\r\nUpon testing this, what \"Apply & Save\" does is just Apply the Changes, and CLEARS THE LOG. If you just click \"Apply\" it'll Apply the changes, but keep the changes in the log. That's the difference between these two buttons. The name of the button should be renamed to match the function.\r\nAssuming you agree that this page is more of a \"Log of Changes\" or a \"Log of Saved Changes\" or a \"Changelog\", then you should renamed the \"Apply & Save\" to something like **\"Apply & Clear Log\"**. It would help new Luci people understand what is going on."},"comment":{"url":"https://api.github.com/repos/openwrt/luci/issues/comments/274368917","html_url":"https://github.com/openwrt/luci/issues/962#issuecomment-274368917","issue_url":"https://api.github.com/repos/openwrt/luci/issues/962","id":274368917,"user":{"login":"cshoredaniel","id":20735818,"avatar_url":"https://avatars.githubusercontent.com/u/20735818?v=3","gravatar_id":"","url":"https://api.github.com/users/cshoredaniel","html_url":"https://github.com/cshoredaniel","followers_url":"https://api.github.com/users/cshoredaniel/followers","following_url":"https://api.github.com/users/cshoredaniel/following{/other_user}","gists_url":"https://api.github.com/users/cshoredaniel/gists{/gist_id}","starred_url":"https://api.github.com/users/cshoredaniel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cshoredaniel/subscriptions","organizations_url":"https://api.github.com/users/cshoredaniel/orgs","repos_url":"https://api.github.com/users/cshoredaniel/repos","events_url":"https://api.github.com/users/cshoredaniel/events{/privacy}","received_events_url":"https://api.github.com/users/cshoredaniel/received_events","type":"User","site_admin":false},"created_at":"2017-01-22T23:22:36Z","updated_at":"2017-01-22T23:22:36Z","body":"Not sure when I'd get to this, so unassigning; thinking just add a 'confirmed' label just to be able indicate it's triaged ( @hnyman would you think that okay )?"}}
{"actor":{"display_login":"cshoredaniel"}}