{"action":"created","comment":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments/158885982","pull_request_review_id":85753694,"id":158885982,"diff_hunk":"@@ -1,7 +1,7 @@\n import * as React from 'react';\n-import Loadable, { LoadingComponentProps } from 'react-loadable';\n+import * as Loadable from 'react-loadable';","path":"types/react-loadable/test/index.tsx","position":3,"original_position":3,"commit_id":"c291cba57b9b6cc6d14adbab58d29df424c8c102","original_commit_id":"c291cba57b9b6cc6d14adbab58d29df424c8c102","user":{"login":"Kovensky","id":73085,"avatar_url":"https://avatars1.githubusercontent.com/u/73085?v=4","gravatar_id":"","url":"https://api.github.com/users/Kovensky","html_url":"https://github.com/Kovensky","followers_url":"https://api.github.com/users/Kovensky/followers","following_url":"https://api.github.com/users/Kovensky/following{/other_user}","gists_url":"https://api.github.com/users/Kovensky/gists{/gist_id}","starred_url":"https://api.github.com/users/Kovensky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kovensky/subscriptions","organizations_url":"https://api.github.com/users/Kovensky/orgs","repos_url":"https://api.github.com/users/Kovensky/repos","events_url":"https://api.github.com/users/Kovensky/events{/privacy}","received_events_url":"https://api.github.com/users/Kovensky/received_events","type":"User","site_admin":false},"body":"`import Loadable = require('react-loadable')`\r\n\r\nThe `React` import probably should be changed to this import style as well.","created_at":"2017-12-28T01:22:00Z","updated_at":"2017-12-28T01:26:07Z","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/22340#discussion_r158885982","pull_request_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/22340","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments/158885982"},"html":{"href":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/22340#discussion_r158885982"},"pull_request":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/22340"}}},"pull_request":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/22340","id":159489049,"html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/22340","diff_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/22340.diff","patch_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/22340.patch","issue_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/22340","number":22340,"state":"open","locked":false,"title":"Make react-loadable export an assignment","user":{"login":"ianks","id":3303032,"avatar_url":"https://avatars0.githubusercontent.com/u/3303032?v=4","gravatar_id":"","url":"https://api.github.com/users/ianks","html_url":"https://github.com/ianks","followers_url":"https://api.github.com/users/ianks/followers","following_url":"https://api.github.com/users/ianks/following{/other_user}","gists_url":"https://api.github.com/users/ianks/gists{/gist_id}","starred_url":"https://api.github.com/users/ianks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianks/subscriptions","organizations_url":"https://api.github.com/users/ianks/orgs","repos_url":"https://api.github.com/users/ianks/repos","events_url":"https://api.github.com/users/ianks/events{/privacy}","received_events_url":"https://api.github.com/users/ianks/received_events","type":"User","site_admin":false},"body":"`react-loadable` does *not* actually have a default export. This can be shown\r\nby running:\r\n\r\n```\r\n> var L = require('react-loadable')\r\nundefined\r\n> L\r\n{ [Function: Loadable]\r\n  Map: [Function: LoadableMap],\r\n  Capture:\r\n   { [Function: Capture]\r\n     propTypes: { report: [Function: bound checkType] },\r\n     childContextTypes: { loadable: [Function: bound checkType] } },\r\n  preloadAll: [Function],\r\n  preloadReady: [Function] }\r\n```\r\n\r\nAs a result, when attempting to use this with commonjs modules, an error error\r\nis thrown when `allowSyntheticDefaultExports` is set.\r\n\r\n```\r\nTypeError: react_loadable_1.default is not a function\r\n```\r\n\r\nThis PR exports the module as an assignment, so now `import * as Loadable from\r\n'react-loadable'` should be used to import the module.\r\n\r\nI am not entirely sure that I have used the best pattern for typings here; but\r\nmy goal was to export the proper assignment yet still allow all of the\r\nnamespace to be accessible via `(i.e.) Loadable.LoadingComponentProps`. If there\r\nis a better way, please let me know and I will be happy to adjust!\r\n\r\n<hr />\r\n\r\n### Please fill in this template.\r\n\r\n- [x] Use a meaningful title for the pull request. Include the name of the package modified.\r\n- [x] Test the change in your own code. (Compile and run.)\r\n- [x] Follow the advice from the [readme](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#make-a-pull-request).\r\n- [x] Avoid [common mistakes](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#common-mistakes).\r\n- [x] Run `npm run lint package-name` (or `tsc` if no `tslint.json` is present).\r\n\r\nSelect one of these and delete the others:\r\n\r\nIf changing an existing definition:\r\n- [x] Provide a URL to documentation or source code which provides context for the suggested changes: https://github.com/thejameskyle/react-loadable/blob/master/src/index.js#L297","created_at":"2017-12-20T18:37:28Z","updated_at":"2017-12-28T01:26:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eaa4d85c1a70f7dab292ad265ec02a1efef18173","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/22340/commits","review_comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/22340/comments","review_comment_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/22340/comments","statuses_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/c291cba57b9b6cc6d14adbab58d29df424c8c102","head":{"label":"ianks:react-loadable-export","ref":"react-loadable-export","sha":"c291cba57b9b6cc6d14adbab58d29df424c8c102","user":{"login":"ianks","id":3303032,"avatar_url":"https://avatars0.githubusercontent.com/u/3303032?v=4","gravatar_id":"","url":"https://api.github.com/users/ianks","html_url":"https://github.com/ianks","followers_url":"https://api.github.com/users/ianks/followers","following_url":"https://api.github.com/users/ianks/following{/other_user}","gists_url":"https://api.github.com/users/ianks/gists{/gist_id}","starred_url":"https://api.github.com/users/ianks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianks/subscriptions","organizations_url":"https://api.github.com/users/ianks/orgs","repos_url":"https://api.github.com/users/ianks/repos","events_url":"https://api.github.com/users/ianks/events{/privacy}","received_events_url":"https://api.github.com/users/ianks/received_events","type":"User","site_admin":false},"repo":{"id":47443422,"name":"DefinitelyTyped","full_name":"ianks/DefinitelyTyped","owner":{"login":"ianks","id":3303032,"avatar_url":"https://avatars0.githubusercontent.com/u/3303032?v=4","gravatar_id":"","url":"https://api.github.com/users/ianks","html_url":"https://github.com/ianks","followers_url":"https://api.github.com/users/ianks/followers","following_url":"https://api.github.com/users/ianks/following{/other_user}","gists_url":"https://api.github.com/users/ianks/gists{/gist_id}","starred_url":"https://api.github.com/users/ianks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianks/subscriptions","organizations_url":"https://api.github.com/users/ianks/orgs","repos_url":"https://api.github.com/users/ianks/repos","events_url":"https://api.github.com/users/ianks/events{/privacy}","received_events_url":"https://api.github.com/users/ianks/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ianks/DefinitelyTyped","description":"The repository for high quality TypeScript type definitions.","fork":true,"url":"https://api.github.com/repos/ianks/DefinitelyTyped","forks_url":"https://api.github.com/repos/ianks/DefinitelyTyped/forks","keys_url":"https://api.github.com/repos/ianks/DefinitelyTyped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ianks/DefinitelyTyped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ianks/DefinitelyTyped/teams","hooks_url":"https://api.github.com/repos/ianks/DefinitelyTyped/hooks","issue_events_url":"https://api.github.com/repos/ianks/DefinitelyTyped/issues/events{/number}","events_url":"https://api.github.com/repos/ianks/DefinitelyTyped/events","assignees_url":"https://api.github.com/repos/ianks/DefinitelyTyped/assignees{/user}","branches_url":"https://api.github.com/repos/ianks/DefinitelyTyped/branches{/branch}","tags_url":"https://api.github.com/repos/ianks/DefinitelyTyped/tags","blobs_url":"https://api.github.com/repos/ianks/DefinitelyTyped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ianks/DefinitelyTyped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ianks/DefinitelyTyped/git/refs{/sha}","trees_url":"https://api.github.com/repos/ianks/DefinitelyTyped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ianks/DefinitelyTyped/statuses/{sha}","languages_url":"https://api.github.com/repos/ianks/DefinitelyTyped/languages","stargazers_url":"https://api.github.com/repos/ianks/DefinitelyTyped/stargazers","contributors_url":"https://api.github.com/repos/ianks/DefinitelyTyped/contributors","subscribers_url":"https://api.github.com/repos/ianks/DefinitelyTyped/subscribers","subscription_url":"https://api.github.com/repos/ianks/DefinitelyTyped/subscription","commits_url":"https://api.github.com/repos/ianks/DefinitelyTyped/commits{/sha}","git_commits_url":"https://api.github.com/repos/ianks/DefinitelyTyped/git/commits{/sha}","comments_url":"https://api.github.com/repos/ianks/DefinitelyTyped/comments{/number}","issue_comment_url":"https://api.github.com/repos/ianks/DefinitelyTyped/issues/comments{/number}","contents_url":"https://api.github.com/repos/ianks/DefinitelyTyped/contents/{+path}","compare_url":"https://api.github.com/repos/ianks/DefinitelyTyped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ianks/DefinitelyTyped/merges","archive_url":"https://api.github.com/repos/ianks/DefinitelyTyped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ianks/DefinitelyTyped/downloads","issues_url":"https://api.github.com/repos/ianks/DefinitelyTyped/issues{/number}","pulls_url":"https://api.github.com/repos/ianks/DefinitelyTyped/pulls{/number}","milestones_url":"https://api.github.com/repos/ianks/DefinitelyTyped/milestones{/number}","notifications_url":"https://api.github.com/repos/ianks/DefinitelyTyped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ianks/DefinitelyTyped/labels{/name}","releases_url":"https://api.github.com/repos/ianks/DefinitelyTyped/releases{/id}","deployments_url":"https://api.github.com/repos/ianks/DefinitelyTyped/deployments","created_at":"2015-12-05T05:14:59Z","updated_at":"2015-12-05T05:15:03Z","pushed_at":"2017-12-20T18:34:36Z","git_url":"git://github.com/ianks/DefinitelyTyped.git","ssh_url":"git@github.com:ianks/DefinitelyTyped.git","clone_url":"https://github.com/ianks/DefinitelyTyped.git","svn_url":"https://github.com/ianks/DefinitelyTyped","homepage":"http://definitelytyped.org/","size":262245,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DefinitelyTyped:master","ref":"master","sha":"38098d403765f83e9c0eb559b4cd1fd6fbc48c8a","user":{"login":"DefinitelyTyped","id":3637556,"avatar_url":"https://avatars1.githubusercontent.com/u/3637556?v=4","gravatar_id":"","url":"https://api.github.com/users/DefinitelyTyped","html_url":"https://github.com/DefinitelyTyped","followers_url":"https://api.github.com/users/DefinitelyTyped/followers","following_url":"https://api.github.com/users/DefinitelyTyped/following{/other_user}","gists_url":"https://api.github.com/users/DefinitelyTyped/gists{/gist_id}","starred_url":"https://api.github.com/users/DefinitelyTyped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DefinitelyTyped/subscriptions","organizations_url":"https://api.github.com/users/DefinitelyTyped/orgs","repos_url":"https://api.github.com/users/DefinitelyTyped/repos","events_url":"https://api.github.com/users/DefinitelyTyped/events{/privacy}","received_events_url":"https://api.github.com/users/DefinitelyTyped/received_events","type":"Organization","site_admin":false},"repo":{"id":6093316,"name":"DefinitelyTyped","full_name":"DefinitelyTyped/DefinitelyTyped","owner":{"login":"DefinitelyTyped","id":3637556,"avatar_url":"https://avatars1.githubusercontent.com/u/3637556?v=4","gravatar_id":"","url":"https://api.github.com/users/DefinitelyTyped","html_url":"https://github.com/DefinitelyTyped","followers_url":"https://api.github.com/users/DefinitelyTyped/followers","following_url":"https://api.github.com/users/DefinitelyTyped/following{/other_user}","gists_url":"https://api.github.com/users/DefinitelyTyped/gists{/gist_id}","starred_url":"https://api.github.com/users/DefinitelyTyped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DefinitelyTyped/subscriptions","organizations_url":"https://api.github.com/users/DefinitelyTyped/orgs","repos_url":"https://api.github.com/users/DefinitelyTyped/repos","events_url":"https://api.github.com/users/DefinitelyTyped/events{/privacy}","received_events_url":"https://api.github.com/users/DefinitelyTyped/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped","description":"The repository for high quality TypeScript type definitions.","fork":false,"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped","forks_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/forks","keys_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/teams","hooks_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/hooks","issue_events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/events{/number}","events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/events","assignees_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/assignees{/user}","branches_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/branches{/branch}","tags_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/tags","blobs_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/refs{/sha}","trees_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/{sha}","languages_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/languages","stargazers_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/stargazers","contributors_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/contributors","subscribers_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/subscribers","subscription_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/subscription","commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/commits{/sha}","git_commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/commits{/sha}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/comments{/number}","issue_comment_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/comments{/number}","contents_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/contents/{+path}","compare_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/merges","archive_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/downloads","issues_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues{/number}","pulls_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls{/number}","milestones_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/milestones{/number}","notifications_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels{/name}","releases_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/releases{/id}","deployments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/deployments","created_at":"2012-10-05T16:39:45Z","updated_at":"2017-12-28T01:21:04Z","pushed_at":"2017-12-28T01:23:30Z","git_url":"git://github.com/DefinitelyTyped/DefinitelyTyped.git","ssh_url":"git@github.com:DefinitelyTyped/DefinitelyTyped.git","clone_url":"https://github.com/DefinitelyTyped/DefinitelyTyped.git","svn_url":"https://github.com/DefinitelyTyped/DefinitelyTyped","homepage":"http://definitelytyped.org/","size":276256,"stargazers_count":13590,"watchers_count":13590,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11330,"mirror_url":null,"archived":false,"open_issues_count":2053,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":11330,"open_issues":2053,"watchers":13590,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/22340"},"html":{"href":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/22340"},"issue":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/22340"},"comments":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/22340/comments"},"review_comments":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/22340/comments"},"review_comment":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/22340/commits"},"statuses":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/c291cba57b9b6cc6d14adbab58d29df424c8c102"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Kovensky"}}