{"action":"created","comment":{"url":"https://api.github.com/repos/elifesciences/journal-cms/pulls/comments/141345433","pull_request_review_id":65544606,"id":141345433,"diff_hunk":"@@ -359,9 +360,14 @@ protected function filterPageAndOrder(QueryInterface &$query, $sort_by = NULL) {\n    * Apply filter by show parameter: all, open or closed.\n    *\n    * @param \\Drupal\\Core\\Entity\\Query\\QueryInterface $query\n-   * @param string\n+   * @param string $filterFieldName The name of the field to filter on\n+   * @param bool $isTimeStamp whether $field is a Timestamp field\n+   * @throws InvalidArgumentException if the filter field name argument is not supplied\n    */\n-  protected function filterShow(QueryInterface &$query) {\n+  protected function filterShow(QueryInterface &$query, string $filterFieldName = '', bool $isTimeStamp = FALSE) {","path":"src/modules/jcms_rest/src/Plugin/rest/resource/AbstractRestResourceBase.php","position":18,"original_position":18,"commit_id":"0b1a79112965c4929765f9a99d49cda5db0778ab","original_commit_id":"0b1a79112965c4929765f9a99d49cda5db0778ab","user":{"login":"giorgiosironi","id":160299,"avatar_url":"https://avatars3.githubusercontent.com/u/160299?v=4","gravatar_id":"","url":"https://api.github.com/users/giorgiosironi","html_url":"https://github.com/giorgiosironi","followers_url":"https://api.github.com/users/giorgiosironi/followers","following_url":"https://api.github.com/users/giorgiosironi/following{/other_user}","gists_url":"https://api.github.com/users/giorgiosironi/gists{/gist_id}","starred_url":"https://api.github.com/users/giorgiosironi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giorgiosironi/subscriptions","organizations_url":"https://api.github.com/users/giorgiosironi/orgs","repos_url":"https://api.github.com/users/giorgiosironi/repos","events_url":"https://api.github.com/users/giorgiosironi/events{/privacy}","received_events_url":"https://api.github.com/users/giorgiosironi/received_events","type":"User","site_admin":false},"body":"not a big problem for now but I'll keep in mind http://www.informit.com/articles/article.aspx?p=1392524 as this class expands","created_at":"2017-09-27T13:40:28Z","updated_at":"2017-09-27T13:40:28Z","html_url":"https://github.com/elifesciences/journal-cms/pull/256#discussion_r141345433","pull_request_url":"https://api.github.com/repos/elifesciences/journal-cms/pulls/256","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/elifesciences/journal-cms/pulls/comments/141345433"},"html":{"href":"https://github.com/elifesciences/journal-cms/pull/256#discussion_r141345433"},"pull_request":{"href":"https://api.github.com/repos/elifesciences/journal-cms/pulls/256"}}},"pull_request":{"url":"https://api.github.com/repos/elifesciences/journal-cms/pulls/256","id":141629398,"html_url":"https://github.com/elifesciences/journal-cms/pull/256","diff_url":"https://github.com/elifesciences/journal-cms/pull/256.diff","patch_url":"https://github.com/elifesciences/journal-cms/pull/256.patch","issue_url":"https://api.github.com/repos/elifesciences/journal-cms/issues/256","number":256,"state":"open","locked":false,"title":"ELPP 3160 implement jobs advert api","user":{"login":"davidcmoulton","id":2893480,"avatar_url":"https://avatars0.githubusercontent.com/u/2893480?v=4","gravatar_id":"","url":"https://api.github.com/users/davidcmoulton","html_url":"https://github.com/davidcmoulton","followers_url":"https://api.github.com/users/davidcmoulton/followers","following_url":"https://api.github.com/users/davidcmoulton/following{/other_user}","gists_url":"https://api.github.com/users/davidcmoulton/gists{/gist_id}","starred_url":"https://api.github.com/users/davidcmoulton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidcmoulton/subscriptions","organizations_url":"https://api.github.com/users/davidcmoulton/orgs","repos_url":"https://api.github.com/users/davidcmoulton/repos","events_url":"https://api.github.com/users/davidcmoulton/events{/privacy}","received_events_url":"https://api.github.com/users/davidcmoulton/received_events","type":"User","site_admin":false},"body":"In Drupal terms, the job advert closing date is currently a `Timestamp`. But could be made a `Date` with minimal rework if that's a better choice. ","created_at":"2017-09-18T15:13:37Z","updated_at":"2017-09-27T13:40:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f79f31667922e3bf3db8c7b8d792dbc193304ab1","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/elifesciences/journal-cms/pulls/256/commits","review_comments_url":"https://api.github.com/repos/elifesciences/journal-cms/pulls/256/comments","review_comment_url":"https://api.github.com/repos/elifesciences/journal-cms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elifesciences/journal-cms/issues/256/comments","statuses_url":"https://api.github.com/repos/elifesciences/journal-cms/statuses/0b1a79112965c4929765f9a99d49cda5db0778ab","head":{"label":"elifesciences:ELPP-3160-implement-jobs-advert-api","ref":"ELPP-3160-implement-jobs-advert-api","sha":"0b1a79112965c4929765f9a99d49cda5db0778ab","user":{"login":"elifesciences","id":1777367,"avatar_url":"https://avatars2.githubusercontent.com/u/1777367?v=4","gravatar_id":"","url":"https://api.github.com/users/elifesciences","html_url":"https://github.com/elifesciences","followers_url":"https://api.github.com/users/elifesciences/followers","following_url":"https://api.github.com/users/elifesciences/following{/other_user}","gists_url":"https://api.github.com/users/elifesciences/gists{/gist_id}","starred_url":"https://api.github.com/users/elifesciences/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elifesciences/subscriptions","organizations_url":"https://api.github.com/users/elifesciences/orgs","repos_url":"https://api.github.com/users/elifesciences/repos","events_url":"https://api.github.com/users/elifesciences/events{/privacy}","received_events_url":"https://api.github.com/users/elifesciences/received_events","type":"Organization","site_admin":false},"repo":{"id":54658808,"name":"journal-cms","full_name":"elifesciences/journal-cms","owner":{"login":"elifesciences","id":1777367,"avatar_url":"https://avatars2.githubusercontent.com/u/1777367?v=4","gravatar_id":"","url":"https://api.github.com/users/elifesciences","html_url":"https://github.com/elifesciences","followers_url":"https://api.github.com/users/elifesciences/followers","following_url":"https://api.github.com/users/elifesciences/following{/other_user}","gists_url":"https://api.github.com/users/elifesciences/gists{/gist_id}","starred_url":"https://api.github.com/users/elifesciences/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elifesciences/subscriptions","organizations_url":"https://api.github.com/users/elifesciences/orgs","repos_url":"https://api.github.com/users/elifesciences/repos","events_url":"https://api.github.com/users/elifesciences/events{/privacy}","received_events_url":"https://api.github.com/users/elifesciences/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elifesciences/journal-cms","description":null,"fork":false,"url":"https://api.github.com/repos/elifesciences/journal-cms","forks_url":"https://api.github.com/repos/elifesciences/journal-cms/forks","keys_url":"https://api.github.com/repos/elifesciences/journal-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elifesciences/journal-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elifesciences/journal-cms/teams","hooks_url":"https://api.github.com/repos/elifesciences/journal-cms/hooks","issue_events_url":"https://api.github.com/repos/elifesciences/journal-cms/issues/events{/number}","events_url":"https://api.github.com/repos/elifesciences/journal-cms/events","assignees_url":"https://api.github.com/repos/elifesciences/journal-cms/assignees{/user}","branches_url":"https://api.github.com/repos/elifesciences/journal-cms/branches{/branch}","tags_url":"https://api.github.com/repos/elifesciences/journal-cms/tags","blobs_url":"https://api.github.com/repos/elifesciences/journal-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elifesciences/journal-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elifesciences/journal-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/elifesciences/journal-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elifesciences/journal-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/elifesciences/journal-cms/languages","stargazers_url":"https://api.github.com/repos/elifesciences/journal-cms/stargazers","contributors_url":"https://api.github.com/repos/elifesciences/journal-cms/contributors","subscribers_url":"https://api.github.com/repos/elifesciences/journal-cms/subscribers","subscription_url":"https://api.github.com/repos/elifesciences/journal-cms/subscription","commits_url":"https://api.github.com/repos/elifesciences/journal-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/elifesciences/journal-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/elifesciences/journal-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/elifesciences/journal-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/elifesciences/journal-cms/contents/{+path}","compare_url":"https://api.github.com/repos/elifesciences/journal-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elifesciences/journal-cms/merges","archive_url":"https://api.github.com/repos/elifesciences/journal-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elifesciences/journal-cms/downloads","issues_url":"https://api.github.com/repos/elifesciences/journal-cms/issues{/number}","pulls_url":"https://api.github.com/repos/elifesciences/journal-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/elifesciences/journal-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/elifesciences/journal-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elifesciences/journal-cms/labels{/name}","releases_url":"https://api.github.com/repos/elifesciences/journal-cms/releases{/id}","deployments_url":"https://api.github.com/repos/elifesciences/journal-cms/deployments","created_at":"2016-03-24T16:54:36Z","updated_at":"2016-10-25T09:45:39Z","pushed_at":"2017-09-27T13:29:43Z","git_url":"git://github.com/elifesciences/journal-cms.git","ssh_url":"git@github.com:elifesciences/journal-cms.git","clone_url":"https://github.com/elifesciences/journal-cms.git","svn_url":"https://github.com/elifesciences/journal-cms","homepage":null,"size":251233,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":4,"forks":5,"open_issues":4,"watchers":1,"default_branch":"develop"}},"base":{"label":"elifesciences:develop","ref":"develop","sha":"b33db4ef5da0a459dd76cfe1196f5c980c6364c9","user":{"login":"elifesciences","id":1777367,"avatar_url":"https://avatars2.githubusercontent.com/u/1777367?v=4","gravatar_id":"","url":"https://api.github.com/users/elifesciences","html_url":"https://github.com/elifesciences","followers_url":"https://api.github.com/users/elifesciences/followers","following_url":"https://api.github.com/users/elifesciences/following{/other_user}","gists_url":"https://api.github.com/users/elifesciences/gists{/gist_id}","starred_url":"https://api.github.com/users/elifesciences/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elifesciences/subscriptions","organizations_url":"https://api.github.com/users/elifesciences/orgs","repos_url":"https://api.github.com/users/elifesciences/repos","events_url":"https://api.github.com/users/elifesciences/events{/privacy}","received_events_url":"https://api.github.com/users/elifesciences/received_events","type":"Organization","site_admin":false},"repo":{"id":54658808,"name":"journal-cms","full_name":"elifesciences/journal-cms","owner":{"login":"elifesciences","id":1777367,"avatar_url":"https://avatars2.githubusercontent.com/u/1777367?v=4","gravatar_id":"","url":"https://api.github.com/users/elifesciences","html_url":"https://github.com/elifesciences","followers_url":"https://api.github.com/users/elifesciences/followers","following_url":"https://api.github.com/users/elifesciences/following{/other_user}","gists_url":"https://api.github.com/users/elifesciences/gists{/gist_id}","starred_url":"https://api.github.com/users/elifesciences/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elifesciences/subscriptions","organizations_url":"https://api.github.com/users/elifesciences/orgs","repos_url":"https://api.github.com/users/elifesciences/repos","events_url":"https://api.github.com/users/elifesciences/events{/privacy}","received_events_url":"https://api.github.com/users/elifesciences/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elifesciences/journal-cms","description":null,"fork":false,"url":"https://api.github.com/repos/elifesciences/journal-cms","forks_url":"https://api.github.com/repos/elifesciences/journal-cms/forks","keys_url":"https://api.github.com/repos/elifesciences/journal-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elifesciences/journal-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elifesciences/journal-cms/teams","hooks_url":"https://api.github.com/repos/elifesciences/journal-cms/hooks","issue_events_url":"https://api.github.com/repos/elifesciences/journal-cms/issues/events{/number}","events_url":"https://api.github.com/repos/elifesciences/journal-cms/events","assignees_url":"https://api.github.com/repos/elifesciences/journal-cms/assignees{/user}","branches_url":"https://api.github.com/repos/elifesciences/journal-cms/branches{/branch}","tags_url":"https://api.github.com/repos/elifesciences/journal-cms/tags","blobs_url":"https://api.github.com/repos/elifesciences/journal-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elifesciences/journal-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elifesciences/journal-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/elifesciences/journal-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elifesciences/journal-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/elifesciences/journal-cms/languages","stargazers_url":"https://api.github.com/repos/elifesciences/journal-cms/stargazers","contributors_url":"https://api.github.com/repos/elifesciences/journal-cms/contributors","subscribers_url":"https://api.github.com/repos/elifesciences/journal-cms/subscribers","subscription_url":"https://api.github.com/repos/elifesciences/journal-cms/subscription","commits_url":"https://api.github.com/repos/elifesciences/journal-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/elifesciences/journal-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/elifesciences/journal-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/elifesciences/journal-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/elifesciences/journal-cms/contents/{+path}","compare_url":"https://api.github.com/repos/elifesciences/journal-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elifesciences/journal-cms/merges","archive_url":"https://api.github.com/repos/elifesciences/journal-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elifesciences/journal-cms/downloads","issues_url":"https://api.github.com/repos/elifesciences/journal-cms/issues{/number}","pulls_url":"https://api.github.com/repos/elifesciences/journal-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/elifesciences/journal-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/elifesciences/journal-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elifesciences/journal-cms/labels{/name}","releases_url":"https://api.github.com/repos/elifesciences/journal-cms/releases{/id}","deployments_url":"https://api.github.com/repos/elifesciences/journal-cms/deployments","created_at":"2016-03-24T16:54:36Z","updated_at":"2016-10-25T09:45:39Z","pushed_at":"2017-09-27T13:29:43Z","git_url":"git://github.com/elifesciences/journal-cms.git","ssh_url":"git@github.com:elifesciences/journal-cms.git","clone_url":"https://github.com/elifesciences/journal-cms.git","svn_url":"https://github.com/elifesciences/journal-cms","homepage":null,"size":251233,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":4,"forks":5,"open_issues":4,"watchers":1,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/elifesciences/journal-cms/pulls/256"},"html":{"href":"https://github.com/elifesciences/journal-cms/pull/256"},"issue":{"href":"https://api.github.com/repos/elifesciences/journal-cms/issues/256"},"comments":{"href":"https://api.github.com/repos/elifesciences/journal-cms/issues/256/comments"},"review_comments":{"href":"https://api.github.com/repos/elifesciences/journal-cms/pulls/256/comments"},"review_comment":{"href":"https://api.github.com/repos/elifesciences/journal-cms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elifesciences/journal-cms/pulls/256/commits"},"statuses":{"href":"https://api.github.com/repos/elifesciences/journal-cms/statuses/0b1a79112965c4929765f9a99d49cda5db0778ab"}},"author_association":"OWNER"}}
{"actor":{"display_login":"giorgiosironi"}}