{"action":"created","comment":{"url":"https://api.github.com/repos/whatwg/url/pulls/comments/107461281","pull_request_review_id":28435392,"id":107461281,"diff_hunk":"@@ -2113,6 +2121,12 @@ string <var>input</var>, optionally with a <a>base URL</a> <var>base</var>, opti\n \n        <li><p>Set <var>buffer</var> to the empty string.\n \n+       <li><p>If <var>url</var>'s <a for=url>scheme</a> is \"<code>file</code>\" and <a>c</a> is\n+       <a>EOF code point</a>, \"<code>?</code>\", or \"<code>#</code>\", then while <var>url</var>'s\n+       <a for=url>path</a>'s <a for=list>size</a> is not 1 and <var>url</var>'s\n+       <a for=url>path</a>[0] is the empty string, <a>validation error</a>, <a for=list>remove</a>","path":"url.bs","position":37,"original_position":37,"commit_id":"cefb0d39c038ee7f26d8b7c7f629511ffe94ac50","original_commit_id":"cefb0d39c038ee7f26d8b7c7f629511ffe94ac50","user":{"login":"annevk","id":1544111,"avatar_url":"https://avatars3.githubusercontent.com/u/1544111?v=3","gravatar_id":"","url":"https://api.github.com/users/annevk","html_url":"https://github.com/annevk","followers_url":"https://api.github.com/users/annevk/followers","following_url":"https://api.github.com/users/annevk/following{/other_user}","gists_url":"https://api.github.com/users/annevk/gists{/gist_id}","starred_url":"https://api.github.com/users/annevk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/annevk/subscriptions","organizations_url":"https://api.github.com/users/annevk/orgs","repos_url":"https://api.github.com/users/annevk/repos","events_url":"https://api.github.com/users/annevk/events{/privacy}","received_events_url":"https://api.github.com/users/annevk/received_events","type":"User","site_admin":false},"body":"Yeah, that's what I figured. Should maybe assert for length being 0 to make sure we have coverage.\r\n\r\nWe should probably also clarify in the Infra Standard that [] indexing only works for actual entries (or make it work like JavaScript somehow, but not sure that's better).","created_at":"2017-03-22T16:22:35Z","updated_at":"2017-03-22T16:22:35Z","html_url":"https://github.com/whatwg/url/pull/278#discussion_r107461281","pull_request_url":"https://api.github.com/repos/whatwg/url/pulls/278","_links":{"self":{"href":"https://api.github.com/repos/whatwg/url/pulls/comments/107461281"},"html":{"href":"https://github.com/whatwg/url/pull/278#discussion_r107461281"},"pull_request":{"href":"https://api.github.com/repos/whatwg/url/pulls/278"}}},"pull_request":{"url":"https://api.github.com/repos/whatwg/url/pulls/278","id":111975682,"html_url":"https://github.com/whatwg/url/pull/278","diff_url":"https://github.com/whatwg/url/pull/278.diff","patch_url":"https://github.com/whatwg/url/pull/278.patch","issue_url":"https://api.github.com/repos/whatwg/url/issues/278","number":278,"state":"open","locked":false,"title":"URL: trim leading slashes of file URL paths","user":{"login":"annevk","id":1544111,"avatar_url":"https://avatars3.githubusercontent.com/u/1544111?v=3","gravatar_id":"","url":"https://api.github.com/users/annevk","html_url":"https://github.com/annevk","followers_url":"https://api.github.com/users/annevk/followers","following_url":"https://api.github.com/users/annevk/following{/other_user}","gists_url":"https://api.github.com/users/annevk/gists{/gist_id}","starred_url":"https://api.github.com/users/annevk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/annevk/subscriptions","organizations_url":"https://api.github.com/users/annevk/orgs","repos_url":"https://api.github.com/users/annevk/repos","events_url":"https://api.github.com/users/annevk/events{/privacy}","received_events_url":"https://api.github.com/users/annevk/received_events","type":"User","site_admin":false},"body":"Tests: https://github.com/w3c/web-platform-tests/pull/5195.\n\nCloses #234 by superseding it. Fixes #232.\n\n\n<!--\n    This comment and the below content is programatically generated.\n    You may add a comma-separated list of anchors you'd like a\n    direct link to below (e.g. #idl-serializers, #idl-sequence):\n\n    Don't remove this comment or modify anything below this line.\n    If you don't want a preview generated for this pull request,\n    just replace the whole of this comment's content by \"no preview\"\n    and remove what's below.\n-->\n***\n[Preview](https://url.spec.whatwg.org/branch-snapshots/annevk/file-url-path-slashes/) | [Diff](https://s3.amazonaws.com/pr-preview/whatwg/url/8fb8684...cefb0d3.html)","created_at":"2017-03-22T10:31:06Z","updated_at":"2017-03-22T16:22:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bd98ca9ba5deae0268bc3f8c652871310980121d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/whatwg/url/pulls/278/commits","review_comments_url":"https://api.github.com/repos/whatwg/url/pulls/278/comments","review_comment_url":"https://api.github.com/repos/whatwg/url/pulls/comments{/number}","comments_url":"https://api.github.com/repos/whatwg/url/issues/278/comments","statuses_url":"https://api.github.com/repos/whatwg/url/statuses/cefb0d39c038ee7f26d8b7c7f629511ffe94ac50","head":{"label":"whatwg:annevk/file-url-path-slashes","ref":"annevk/file-url-path-slashes","sha":"cefb0d39c038ee7f26d8b7c7f629511ffe94ac50","user":{"login":"whatwg","id":2226336,"avatar_url":"https://avatars2.githubusercontent.com/u/2226336?v=3","gravatar_id":"","url":"https://api.github.com/users/whatwg","html_url":"https://github.com/whatwg","followers_url":"https://api.github.com/users/whatwg/followers","following_url":"https://api.github.com/users/whatwg/following{/other_user}","gists_url":"https://api.github.com/users/whatwg/gists{/gist_id}","starred_url":"https://api.github.com/users/whatwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whatwg/subscriptions","organizations_url":"https://api.github.com/users/whatwg/orgs","repos_url":"https://api.github.com/users/whatwg/repos","events_url":"https://api.github.com/users/whatwg/events{/privacy}","received_events_url":"https://api.github.com/users/whatwg/received_events","type":"Organization","site_admin":false},"repo":{"id":5871569,"name":"url","full_name":"whatwg/url","owner":{"login":"whatwg","id":2226336,"avatar_url":"https://avatars2.githubusercontent.com/u/2226336?v=3","gravatar_id":"","url":"https://api.github.com/users/whatwg","html_url":"https://github.com/whatwg","followers_url":"https://api.github.com/users/whatwg/followers","following_url":"https://api.github.com/users/whatwg/following{/other_user}","gists_url":"https://api.github.com/users/whatwg/gists{/gist_id}","starred_url":"https://api.github.com/users/whatwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whatwg/subscriptions","organizations_url":"https://api.github.com/users/whatwg/orgs","repos_url":"https://api.github.com/users/whatwg/repos","events_url":"https://api.github.com/users/whatwg/events{/privacy}","received_events_url":"https://api.github.com/users/whatwg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/whatwg/url","description":"URL Standard","fork":false,"url":"https://api.github.com/repos/whatwg/url","forks_url":"https://api.github.com/repos/whatwg/url/forks","keys_url":"https://api.github.com/repos/whatwg/url/keys{/key_id}","collaborators_url":"https://api.github.com/repos/whatwg/url/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/whatwg/url/teams","hooks_url":"https://api.github.com/repos/whatwg/url/hooks","issue_events_url":"https://api.github.com/repos/whatwg/url/issues/events{/number}","events_url":"https://api.github.com/repos/whatwg/url/events","assignees_url":"https://api.github.com/repos/whatwg/url/assignees{/user}","branches_url":"https://api.github.com/repos/whatwg/url/branches{/branch}","tags_url":"https://api.github.com/repos/whatwg/url/tags","blobs_url":"https://api.github.com/repos/whatwg/url/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/whatwg/url/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/whatwg/url/git/refs{/sha}","trees_url":"https://api.github.com/repos/whatwg/url/git/trees{/sha}","statuses_url":"https://api.github.com/repos/whatwg/url/statuses/{sha}","languages_url":"https://api.github.com/repos/whatwg/url/languages","stargazers_url":"https://api.github.com/repos/whatwg/url/stargazers","contributors_url":"https://api.github.com/repos/whatwg/url/contributors","subscribers_url":"https://api.github.com/repos/whatwg/url/subscribers","subscription_url":"https://api.github.com/repos/whatwg/url/subscription","commits_url":"https://api.github.com/repos/whatwg/url/commits{/sha}","git_commits_url":"https://api.github.com/repos/whatwg/url/git/commits{/sha}","comments_url":"https://api.github.com/repos/whatwg/url/comments{/number}","issue_comment_url":"https://api.github.com/repos/whatwg/url/issues/comments{/number}","contents_url":"https://api.github.com/repos/whatwg/url/contents/{+path}","compare_url":"https://api.github.com/repos/whatwg/url/compare/{base}...{head}","merges_url":"https://api.github.com/repos/whatwg/url/merges","archive_url":"https://api.github.com/repos/whatwg/url/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/whatwg/url/downloads","issues_url":"https://api.github.com/repos/whatwg/url/issues{/number}","pulls_url":"https://api.github.com/repos/whatwg/url/pulls{/number}","milestones_url":"https://api.github.com/repos/whatwg/url/milestones{/number}","notifications_url":"https://api.github.com/repos/whatwg/url/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/whatwg/url/labels{/name}","releases_url":"https://api.github.com/repos/whatwg/url/releases{/id}","deployments_url":"https://api.github.com/repos/whatwg/url/deployments","created_at":"2012-09-19T12:44:40Z","updated_at":"2017-03-21T09:18:33Z","pushed_at":"2017-03-22T13:36:11Z","git_url":"git://github.com/whatwg/url.git","ssh_url":"git@github.com:whatwg/url.git","clone_url":"https://github.com/whatwg/url.git","svn_url":"https://github.com/whatwg/url","homepage":"https://url.spec.whatwg.org/","size":3335,"stargazers_count":125,"watchers_count":125,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":52,"mirror_url":null,"open_issues_count":27,"forks":52,"open_issues":27,"watchers":125,"default_branch":"master"}},"base":{"label":"whatwg:master","ref":"master","sha":"8fb8684a19b449db4c8920aee6cd3efb41bcdcfd","user":{"login":"whatwg","id":2226336,"avatar_url":"https://avatars2.githubusercontent.com/u/2226336?v=3","gravatar_id":"","url":"https://api.github.com/users/whatwg","html_url":"https://github.com/whatwg","followers_url":"https://api.github.com/users/whatwg/followers","following_url":"https://api.github.com/users/whatwg/following{/other_user}","gists_url":"https://api.github.com/users/whatwg/gists{/gist_id}","starred_url":"https://api.github.com/users/whatwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whatwg/subscriptions","organizations_url":"https://api.github.com/users/whatwg/orgs","repos_url":"https://api.github.com/users/whatwg/repos","events_url":"https://api.github.com/users/whatwg/events{/privacy}","received_events_url":"https://api.github.com/users/whatwg/received_events","type":"Organization","site_admin":false},"repo":{"id":5871569,"name":"url","full_name":"whatwg/url","owner":{"login":"whatwg","id":2226336,"avatar_url":"https://avatars2.githubusercontent.com/u/2226336?v=3","gravatar_id":"","url":"https://api.github.com/users/whatwg","html_url":"https://github.com/whatwg","followers_url":"https://api.github.com/users/whatwg/followers","following_url":"https://api.github.com/users/whatwg/following{/other_user}","gists_url":"https://api.github.com/users/whatwg/gists{/gist_id}","starred_url":"https://api.github.com/users/whatwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whatwg/subscriptions","organizations_url":"https://api.github.com/users/whatwg/orgs","repos_url":"https://api.github.com/users/whatwg/repos","events_url":"https://api.github.com/users/whatwg/events{/privacy}","received_events_url":"https://api.github.com/users/whatwg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/whatwg/url","description":"URL Standard","fork":false,"url":"https://api.github.com/repos/whatwg/url","forks_url":"https://api.github.com/repos/whatwg/url/forks","keys_url":"https://api.github.com/repos/whatwg/url/keys{/key_id}","collaborators_url":"https://api.github.com/repos/whatwg/url/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/whatwg/url/teams","hooks_url":"https://api.github.com/repos/whatwg/url/hooks","issue_events_url":"https://api.github.com/repos/whatwg/url/issues/events{/number}","events_url":"https://api.github.com/repos/whatwg/url/events","assignees_url":"https://api.github.com/repos/whatwg/url/assignees{/user}","branches_url":"https://api.github.com/repos/whatwg/url/branches{/branch}","tags_url":"https://api.github.com/repos/whatwg/url/tags","blobs_url":"https://api.github.com/repos/whatwg/url/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/whatwg/url/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/whatwg/url/git/refs{/sha}","trees_url":"https://api.github.com/repos/whatwg/url/git/trees{/sha}","statuses_url":"https://api.github.com/repos/whatwg/url/statuses/{sha}","languages_url":"https://api.github.com/repos/whatwg/url/languages","stargazers_url":"https://api.github.com/repos/whatwg/url/stargazers","contributors_url":"https://api.github.com/repos/whatwg/url/contributors","subscribers_url":"https://api.github.com/repos/whatwg/url/subscribers","subscription_url":"https://api.github.com/repos/whatwg/url/subscription","commits_url":"https://api.github.com/repos/whatwg/url/commits{/sha}","git_commits_url":"https://api.github.com/repos/whatwg/url/git/commits{/sha}","comments_url":"https://api.github.com/repos/whatwg/url/comments{/number}","issue_comment_url":"https://api.github.com/repos/whatwg/url/issues/comments{/number}","contents_url":"https://api.github.com/repos/whatwg/url/contents/{+path}","compare_url":"https://api.github.com/repos/whatwg/url/compare/{base}...{head}","merges_url":"https://api.github.com/repos/whatwg/url/merges","archive_url":"https://api.github.com/repos/whatwg/url/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/whatwg/url/downloads","issues_url":"https://api.github.com/repos/whatwg/url/issues{/number}","pulls_url":"https://api.github.com/repos/whatwg/url/pulls{/number}","milestones_url":"https://api.github.com/repos/whatwg/url/milestones{/number}","notifications_url":"https://api.github.com/repos/whatwg/url/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/whatwg/url/labels{/name}","releases_url":"https://api.github.com/repos/whatwg/url/releases{/id}","deployments_url":"https://api.github.com/repos/whatwg/url/deployments","created_at":"2012-09-19T12:44:40Z","updated_at":"2017-03-21T09:18:33Z","pushed_at":"2017-03-22T13:36:11Z","git_url":"git://github.com/whatwg/url.git","ssh_url":"git@github.com:whatwg/url.git","clone_url":"https://github.com/whatwg/url.git","svn_url":"https://github.com/whatwg/url","homepage":"https://url.spec.whatwg.org/","size":3335,"stargazers_count":125,"watchers_count":125,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":52,"mirror_url":null,"open_issues_count":27,"forks":52,"open_issues":27,"watchers":125,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/whatwg/url/pulls/278"},"html":{"href":"https://github.com/whatwg/url/pull/278"},"issue":{"href":"https://api.github.com/repos/whatwg/url/issues/278"},"comments":{"href":"https://api.github.com/repos/whatwg/url/issues/278/comments"},"review_comments":{"href":"https://api.github.com/repos/whatwg/url/pulls/278/comments"},"review_comment":{"href":"https://api.github.com/repos/whatwg/url/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/whatwg/url/pulls/278/commits"},"statuses":{"href":"https://api.github.com/repos/whatwg/url/statuses/cefb0d39c038ee7f26d8b7c7f629511ffe94ac50"}}}}
{"actor":{"display_login":"annevk"}}