{"action":"created","comment":{"url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments/109055206","pull_request_review_id":30132749,"id":109055206,"diff_hunk":"@@ -42,3 +42,36 @@ ERROR:  syntax error at or near \"with syntax\"\n LINE 1: SELECT with syntax error\n                ^\n QUERY:  SELECT with syntax error\n+\n+-- Test partition tables \n+SELECT gp_dump_query_oids('SELECT * FROM p3_sales_1_prt_11_2_prt_3');\n+                  gp_dump_query_oids\n+------------------------------------------------------\n+ {\"relids\": \"29359,29380,29401,29423\", \"funcids\": \"\"}\n+(1 row)\n+\n+SELECT gp_dump_query_oids('SELECT * FROM p3_sales_1_prt_11_2_prt_3; SELECT * FROM pg_class');\n+                    gp_dump_query_oids\n+-----------------------------------------------------------\n+ {\"relids\": \"29359,29380,29401,29423,1259\", \"funcids\": \"\"}\n+(1 row)\n+\n+SELECT gp_dump_query_oids('SELECT * FROM p3_sales');\n+\n+\n+          gp_dump_query_oids\n+\n+\n+----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------\n+----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------\n+----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------\n+----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------\n+--------------------------------------\n+ {\"relids\": \"26427,26705,26807,26849,26871,26828,26893,26935,26957,26914,26725,26765,26786,26745,26979,27081,27123,27145,27102,27167,27209,27231,27188,26999,27039,27060,27019,27253,27355,27397,27419,27376,27441,274\n+83,27505,27462,27273,27313,27334,27293,27527,27629,27671,27693,27650,27715,27757,27779,27736,27547,27587,27608,27567,27801,27903,27945,27967,27924,27989,28031,28053,28010,27821,27861,27882,27841,28075,28177,28219,2\n+8241,28198,28263,28305,28327,28284,28095,28135,28156,28115,28349,28451,28493,28515,28472,28537,28579,28601,28558,28369,28409,28430,28389,28623,28725,28767,28789,28746,28811,28853,28875,28832,28643,28683,28704,28663\n+,28897,28999,29041,29063,29020,29085,29127,29149,29106,28917,28957,28978,28937,29171,29273,29315,29337,29294,29359,29401,29423,29380,29191,29231,29252,29211,26433,26539,26580,26601,26560,26622,26663,26684,26643,264\n+53,26497,26518,26475\", \"funcids\": \"\"}\n+(1 row)\n+\n+","path":"src/test/regress/expected/gp_dump_query_oids.out","position":195,"original_position":36,"commit_id":"65012560c2041db3cd1f2501f21787836f74e5f9","original_commit_id":"5f7895387a069d4dcf98df3d48b528f8d967d2c1","user":{"login":"ginobiliwang","id":3192108,"avatar_url":"https://avatars0.githubusercontent.com/u/3192108?v=3","gravatar_id":"","url":"https://api.github.com/users/ginobiliwang","html_url":"https://github.com/ginobiliwang","followers_url":"https://api.github.com/users/ginobiliwang/followers","following_url":"https://api.github.com/users/ginobiliwang/following{/other_user}","gists_url":"https://api.github.com/users/ginobiliwang/gists{/gist_id}","starred_url":"https://api.github.com/users/ginobiliwang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ginobiliwang/subscriptions","organizations_url":"https://api.github.com/users/ginobiliwang/orgs","repos_url":"https://api.github.com/users/ginobiliwang/repos","events_url":"https://api.github.com/users/ginobiliwang/events{/privacy}","received_events_url":"https://api.github.com/users/ginobiliwang/received_events","type":"User","site_admin":false},"body":"so, i am not sure what should i do with these tests? is it possible to find some system relation that has been partitioned?","created_at":"2017-03-30T22:44:07Z","updated_at":"2017-03-30T22:44:07Z","html_url":"https://github.com/greenplum-db/gpdb/pull/2072#discussion_r109055206","pull_request_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/2072","_links":{"self":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments/109055206"},"html":{"href":"https://github.com/greenplum-db/gpdb/pull/2072#discussion_r109055206"},"pull_request":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/2072"}}},"pull_request":{"url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/2072","id":111605633,"html_url":"https://github.com/greenplum-db/gpdb/pull/2072","diff_url":"https://github.com/greenplum-db/gpdb/pull/2072.diff","patch_url":"https://github.com/greenplum-db/gpdb/pull/2072.patch","issue_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/2072","number":2072,"state":"open","locked":false,"title":"Add partitioned tables' complete schema information for minirepro ","user":{"login":"ginobiliwang","id":3192108,"avatar_url":"https://avatars0.githubusercontent.com/u/3192108?v=3","gravatar_id":"","url":"https://api.github.com/users/ginobiliwang","html_url":"https://github.com/ginobiliwang","followers_url":"https://api.github.com/users/ginobiliwang/followers","following_url":"https://api.github.com/users/ginobiliwang/following{/other_user}","gists_url":"https://api.github.com/users/ginobiliwang/gists{/gist_id}","starred_url":"https://api.github.com/users/ginobiliwang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ginobiliwang/subscriptions","organizations_url":"https://api.github.com/users/ginobiliwang/orgs","repos_url":"https://api.github.com/users/ginobiliwang/repos","events_url":"https://api.github.com/users/ginobiliwang/events{/privacy}","received_events_url":"https://api.github.com/users/ginobiliwang/received_events","type":"User","site_admin":false},"body":"Hi Team,\r\n  We have found that minirepro does not dump complete partitioned tables' schema information. Root table for a partitioned table is dumped, but leaf tables. Both ddl, pg_class and pg_statistic has that phenomenon. \r\n\r\n  Attachement is a simple repro that shows that only the statistics of the root table are extracted and not the statistics of thee leaf tables.\r\n[Repro_minirepro_partition.tar.gz](https://github.com/greenplum-db/gpdb/files/855778/Repro_minirepro_partition.tar.gz)\r\n\r\n We have added another function called \"pg_add_partition_table_oids\" to fix the issue. Basically, it uses  \"gp_toolkit.gp_size_of_partition_and_indexes_disk\" to get leaf table information and append oids to original json file.","created_at":"2017-03-20T17:20:18Z","updated_at":"2017-03-30T22:44:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7654a7b1dd88cdff00c9facaacbe5bee978f9636","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/2072/commits","review_comments_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/2072/comments","review_comment_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/2072/comments","statuses_url":"https://api.github.com/repos/greenplum-db/gpdb/statuses/65012560c2041db3cd1f2501f21787836f74e5f9","head":{"label":"ginobiliwang:minirepro_pr","ref":"minirepro_pr","sha":"65012560c2041db3cd1f2501f21787836f74e5f9","user":{"login":"ginobiliwang","id":3192108,"avatar_url":"https://avatars0.githubusercontent.com/u/3192108?v=3","gravatar_id":"","url":"https://api.github.com/users/ginobiliwang","html_url":"https://github.com/ginobiliwang","followers_url":"https://api.github.com/users/ginobiliwang/followers","following_url":"https://api.github.com/users/ginobiliwang/following{/other_user}","gists_url":"https://api.github.com/users/ginobiliwang/gists{/gist_id}","starred_url":"https://api.github.com/users/ginobiliwang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ginobiliwang/subscriptions","organizations_url":"https://api.github.com/users/ginobiliwang/orgs","repos_url":"https://api.github.com/users/ginobiliwang/repos","events_url":"https://api.github.com/users/ginobiliwang/events{/privacy}","received_events_url":"https://api.github.com/users/ginobiliwang/received_events","type":"User","site_admin":false},"repo":{"id":85590178,"name":"gpdb","full_name":"ginobiliwang/gpdb","owner":{"login":"ginobiliwang","id":3192108,"avatar_url":"https://avatars0.githubusercontent.com/u/3192108?v=3","gravatar_id":"","url":"https://api.github.com/users/ginobiliwang","html_url":"https://github.com/ginobiliwang","followers_url":"https://api.github.com/users/ginobiliwang/followers","following_url":"https://api.github.com/users/ginobiliwang/following{/other_user}","gists_url":"https://api.github.com/users/ginobiliwang/gists{/gist_id}","starred_url":"https://api.github.com/users/ginobiliwang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ginobiliwang/subscriptions","organizations_url":"https://api.github.com/users/ginobiliwang/orgs","repos_url":"https://api.github.com/users/ginobiliwang/repos","events_url":"https://api.github.com/users/ginobiliwang/events{/privacy}","received_events_url":"https://api.github.com/users/ginobiliwang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ginobiliwang/gpdb","description":"Greenplum Database","fork":true,"url":"https://api.github.com/repos/ginobiliwang/gpdb","forks_url":"https://api.github.com/repos/ginobiliwang/gpdb/forks","keys_url":"https://api.github.com/repos/ginobiliwang/gpdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ginobiliwang/gpdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ginobiliwang/gpdb/teams","hooks_url":"https://api.github.com/repos/ginobiliwang/gpdb/hooks","issue_events_url":"https://api.github.com/repos/ginobiliwang/gpdb/issues/events{/number}","events_url":"https://api.github.com/repos/ginobiliwang/gpdb/events","assignees_url":"https://api.github.com/repos/ginobiliwang/gpdb/assignees{/user}","branches_url":"https://api.github.com/repos/ginobiliwang/gpdb/branches{/branch}","tags_url":"https://api.github.com/repos/ginobiliwang/gpdb/tags","blobs_url":"https://api.github.com/repos/ginobiliwang/gpdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ginobiliwang/gpdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ginobiliwang/gpdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/ginobiliwang/gpdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ginobiliwang/gpdb/statuses/{sha}","languages_url":"https://api.github.com/repos/ginobiliwang/gpdb/languages","stargazers_url":"https://api.github.com/repos/ginobiliwang/gpdb/stargazers","contributors_url":"https://api.github.com/repos/ginobiliwang/gpdb/contributors","subscribers_url":"https://api.github.com/repos/ginobiliwang/gpdb/subscribers","subscription_url":"https://api.github.com/repos/ginobiliwang/gpdb/subscription","commits_url":"https://api.github.com/repos/ginobiliwang/gpdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/ginobiliwang/gpdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/ginobiliwang/gpdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/ginobiliwang/gpdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/ginobiliwang/gpdb/contents/{+path}","compare_url":"https://api.github.com/repos/ginobiliwang/gpdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ginobiliwang/gpdb/merges","archive_url":"https://api.github.com/repos/ginobiliwang/gpdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ginobiliwang/gpdb/downloads","issues_url":"https://api.github.com/repos/ginobiliwang/gpdb/issues{/number}","pulls_url":"https://api.github.com/repos/ginobiliwang/gpdb/pulls{/number}","milestones_url":"https://api.github.com/repos/ginobiliwang/gpdb/milestones{/number}","notifications_url":"https://api.github.com/repos/ginobiliwang/gpdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ginobiliwang/gpdb/labels{/name}","releases_url":"https://api.github.com/repos/ginobiliwang/gpdb/releases{/id}","deployments_url":"https://api.github.com/repos/ginobiliwang/gpdb/deployments","created_at":"2017-03-20T14:58:19Z","updated_at":"2017-03-20T14:59:08Z","pushed_at":"2017-03-30T15:38:23Z","git_url":"git://github.com/ginobiliwang/gpdb.git","ssh_url":"git@github.com:ginobiliwang/gpdb.git","clone_url":"https://github.com/ginobiliwang/gpdb.git","svn_url":"https://github.com/ginobiliwang/gpdb","homepage":"http://greenplum.org","size":208713,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"greenplum-db:master","ref":"master","sha":"e8dd6b61db858dde66eb229de9bfbd3b6cf50918","user":{"login":"greenplum-db","id":14097842,"avatar_url":"https://avatars1.githubusercontent.com/u/14097842?v=3","gravatar_id":"","url":"https://api.github.com/users/greenplum-db","html_url":"https://github.com/greenplum-db","followers_url":"https://api.github.com/users/greenplum-db/followers","following_url":"https://api.github.com/users/greenplum-db/following{/other_user}","gists_url":"https://api.github.com/users/greenplum-db/gists{/gist_id}","starred_url":"https://api.github.com/users/greenplum-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenplum-db/subscriptions","organizations_url":"https://api.github.com/users/greenplum-db/orgs","repos_url":"https://api.github.com/users/greenplum-db/repos","events_url":"https://api.github.com/users/greenplum-db/events{/privacy}","received_events_url":"https://api.github.com/users/greenplum-db/received_events","type":"Organization","site_admin":false},"repo":{"id":44781140,"name":"gpdb","full_name":"greenplum-db/gpdb","owner":{"login":"greenplum-db","id":14097842,"avatar_url":"https://avatars1.githubusercontent.com/u/14097842?v=3","gravatar_id":"","url":"https://api.github.com/users/greenplum-db","html_url":"https://github.com/greenplum-db","followers_url":"https://api.github.com/users/greenplum-db/followers","following_url":"https://api.github.com/users/greenplum-db/following{/other_user}","gists_url":"https://api.github.com/users/greenplum-db/gists{/gist_id}","starred_url":"https://api.github.com/users/greenplum-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenplum-db/subscriptions","organizations_url":"https://api.github.com/users/greenplum-db/orgs","repos_url":"https://api.github.com/users/greenplum-db/repos","events_url":"https://api.github.com/users/greenplum-db/events{/privacy}","received_events_url":"https://api.github.com/users/greenplum-db/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/greenplum-db/gpdb","description":"Greenplum Database","fork":false,"url":"https://api.github.com/repos/greenplum-db/gpdb","forks_url":"https://api.github.com/repos/greenplum-db/gpdb/forks","keys_url":"https://api.github.com/repos/greenplum-db/gpdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/greenplum-db/gpdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/greenplum-db/gpdb/teams","hooks_url":"https://api.github.com/repos/greenplum-db/gpdb/hooks","issue_events_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/events{/number}","events_url":"https://api.github.com/repos/greenplum-db/gpdb/events","assignees_url":"https://api.github.com/repos/greenplum-db/gpdb/assignees{/user}","branches_url":"https://api.github.com/repos/greenplum-db/gpdb/branches{/branch}","tags_url":"https://api.github.com/repos/greenplum-db/gpdb/tags","blobs_url":"https://api.github.com/repos/greenplum-db/gpdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/greenplum-db/gpdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/greenplum-db/gpdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/greenplum-db/gpdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/greenplum-db/gpdb/statuses/{sha}","languages_url":"https://api.github.com/repos/greenplum-db/gpdb/languages","stargazers_url":"https://api.github.com/repos/greenplum-db/gpdb/stargazers","contributors_url":"https://api.github.com/repos/greenplum-db/gpdb/contributors","subscribers_url":"https://api.github.com/repos/greenplum-db/gpdb/subscribers","subscription_url":"https://api.github.com/repos/greenplum-db/gpdb/subscription","commits_url":"https://api.github.com/repos/greenplum-db/gpdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/greenplum-db/gpdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/greenplum-db/gpdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/greenplum-db/gpdb/contents/{+path}","compare_url":"https://api.github.com/repos/greenplum-db/gpdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/greenplum-db/gpdb/merges","archive_url":"https://api.github.com/repos/greenplum-db/gpdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/greenplum-db/gpdb/downloads","issues_url":"https://api.github.com/repos/greenplum-db/gpdb/issues{/number}","pulls_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls{/number}","milestones_url":"https://api.github.com/repos/greenplum-db/gpdb/milestones{/number}","notifications_url":"https://api.github.com/repos/greenplum-db/gpdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/greenplum-db/gpdb/labels{/name}","releases_url":"https://api.github.com/repos/greenplum-db/gpdb/releases{/id}","deployments_url":"https://api.github.com/repos/greenplum-db/gpdb/deployments","created_at":"2015-10-23T00:25:17Z","updated_at":"2017-03-30T20:21:36Z","pushed_at":"2017-03-30T22:43:37Z","git_url":"git://github.com/greenplum-db/gpdb.git","ssh_url":"git@github.com:greenplum-db/gpdb.git","clone_url":"https://github.com/greenplum-db/gpdb.git","svn_url":"https://github.com/greenplum-db/gpdb","homepage":"http://greenplum.org","size":209078,"stargazers_count":1871,"watchers_count":1871,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":572,"mirror_url":null,"open_issues_count":144,"forks":572,"open_issues":144,"watchers":1871,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/2072"},"html":{"href":"https://github.com/greenplum-db/gpdb/pull/2072"},"issue":{"href":"https://api.github.com/repos/greenplum-db/gpdb/issues/2072"},"comments":{"href":"https://api.github.com/repos/greenplum-db/gpdb/issues/2072/comments"},"review_comments":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/2072/comments"},"review_comment":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/2072/commits"},"statuses":{"href":"https://api.github.com/repos/greenplum-db/gpdb/statuses/65012560c2041db3cd1f2501f21787836f74e5f9"}}}}
{"actor":{"display_login":"ginobiliwang"}}