{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node-inspect/issues/55","repository_url":"https://api.github.com/repos/nodejs/node-inspect","labels_url":"https://api.github.com/repos/nodejs/node-inspect/issues/55/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node-inspect/issues/55/comments","events_url":"https://api.github.com/repos/nodejs/node-inspect/issues/55/events","html_url":"https://github.com/nodejs/node-inspect/issues/55","id":272869092,"number":55,"title":"Purpose of double Debugger.setPauseOnExceptions","user":{"login":"Delapouite","id":39315,"avatar_url":"https://avatars0.githubusercontent.com/u/39315?v=4","gravatar_id":"","url":"https://api.github.com/users/Delapouite","html_url":"https://github.com/Delapouite","followers_url":"https://api.github.com/users/Delapouite/followers","following_url":"https://api.github.com/users/Delapouite/following{/other_user}","gists_url":"https://api.github.com/users/Delapouite/gists{/gist_id}","starred_url":"https://api.github.com/users/Delapouite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Delapouite/subscriptions","organizations_url":"https://api.github.com/users/Delapouite/orgs","repos_url":"https://api.github.com/users/Delapouite/repos","events_url":"https://api.github.com/users/Delapouite/events{/privacy}","received_events_url":"https://api.github.com/users/Delapouite/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-11-10T09:22:58Z","updated_at":"2017-11-13T16:21:14Z","closed_at":null,"author_association":"MEMBER","body":"Hi\r\n\r\nDuring the init phase: https://github.com/nodejs/node-inspect/blob/master/lib/internal/inspect_repl.js#L1041\r\n\r\n```js\r\n  function initAfterStart() {\r\n    const setupTasks = [\r\n      Runtime.enable(),\r\n      Profiler.enable(),\r\n      Profiler.setSamplingInterval({ interval: 100 }),\r\n      Debugger.enable(),\r\n      Debugger.setPauseOnExceptions({ state: 'none' }),\r\n      Debugger.setAsyncCallStackDepth({ maxDepth: 0 }),\r\n      Debugger.setBlackboxPatterns({ patterns: [] }),\r\n      Debugger.setPauseOnExceptions({ state: pauseOnExceptionState }),\r\n      restoreBreakpoints(),\r\n      Runtime.runIfWaitingForDebugger(),\r\n    ];\r\n    return Promise.all(setupTasks);\r\n  }\r\n```\r\n\r\nWhat's the purpose of doing `Debugger.setPauseOnExceptions` twice?\r\n```js\r\nDebugger.setPauseOnExceptions({ state: 'none' }),\r\nDebugger.setPauseOnExceptions({ state: pauseOnExceptionState }),\r\n```"},"comment":{"url":"https://api.github.com/repos/nodejs/node-inspect/issues/comments/343972106","html_url":"https://github.com/nodejs/node-inspect/issues/55#issuecomment-343972106","issue_url":"https://api.github.com/repos/nodejs/node-inspect/issues/55","id":343972106,"user":{"login":"ak239","id":426418,"avatar_url":"https://avatars3.githubusercontent.com/u/426418?v=4","gravatar_id":"","url":"https://api.github.com/users/ak239","html_url":"https://github.com/ak239","followers_url":"https://api.github.com/users/ak239/followers","following_url":"https://api.github.com/users/ak239/following{/other_user}","gists_url":"https://api.github.com/users/ak239/gists{/gist_id}","starred_url":"https://api.github.com/users/ak239/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ak239/subscriptions","organizations_url":"https://api.github.com/users/ak239/orgs","repos_url":"https://api.github.com/users/ak239/repos","events_url":"https://api.github.com/users/ak239/events{/privacy}","received_events_url":"https://api.github.com/users/ak239/received_events","type":"User","site_admin":false},"created_at":"2017-11-13T16:21:14Z","updated_at":"2017-11-13T16:21:14Z","author_association":"MEMBER","body":"I think we should support this case on backend side. When at least one protocol client requests pause on all exceptions - debugger should issue Debugger.paused event for each exception, if at least one client request pause on uncaught exception - issue event for uncaught exception.\r\nI filled bug against V8: [issue](crbug.com/v8/7077)\r\n"}}
{"actor":{"display_login":"ak239"}}