{"action":"created","issue":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/9588","repository_url":"https://api.github.com/repos/scikit-learn/scikit-learn","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/9588/labels{/name}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/9588/comments","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/9588/events","html_url":"https://github.com/scikit-learn/scikit-learn/pull/9588","id":251517374,"number":9588,"title":"[MRG+1] Adds helpful messages in all error assertions in estimator_checks","user":{"login":"thechargedneutron","id":25536866,"avatar_url":"https://avatars1.githubusercontent.com/u/25536866?v=4","gravatar_id":"","url":"https://api.github.com/users/thechargedneutron","html_url":"https://github.com/thechargedneutron","followers_url":"https://api.github.com/users/thechargedneutron/followers","following_url":"https://api.github.com/users/thechargedneutron/following{/other_user}","gists_url":"https://api.github.com/users/thechargedneutron/gists{/gist_id}","starred_url":"https://api.github.com/users/thechargedneutron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thechargedneutron/subscriptions","organizations_url":"https://api.github.com/users/thechargedneutron/orgs","repos_url":"https://api.github.com/users/thechargedneutron/repos","events_url":"https://api.github.com/users/thechargedneutron/events{/privacy}","received_events_url":"https://api.github.com/users/thechargedneutron/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2017-08-20T21:54:59Z","updated_at":"2017-08-28T21:05:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/9588","html_url":"https://github.com/scikit-learn/scikit-learn/pull/9588","diff_url":"https://github.com/scikit-learn/scikit-learn/pull/9588.diff","patch_url":"https://github.com/scikit-learn/scikit-learn/pull/9588.patch"},"body":"<!--\r\nThanks for contributing a pull request! Please ensure you have taken a look at\r\nthe contribution guidelines: https://github.com/scikit-learn/scikit-learn/blob/master/CONTRIBUTING.md#Contributing-Pull-Requests\r\n-->\r\n#### Reference Issue\r\nFixes #9572 \r\n\r\n\r\n#### What does this implement/fix? Explain your changes.\r\nAdded a context manager for each occurrence of `assert_raises`. \r\nThe `msg` arguments have not been changed which returns nice error messages. \r\n\r\n\r\n<!--\r\nPlease be aware that we are a loose team of volunteers so patience is\r\nnecessary; assistance handling other issues is very welcome. We value\r\nall user contributions, no matter how minor they are. If we are slow to\r\nreview, either the pull request needs some benchmarking, tinkering,\r\nconvincing, etc. or more likely the reviewers are simply busy. In either\r\ncase, we ask for your understanding during the review process.\r\nFor more information, see our FAQ on this topic:\r\nhttp://scikit-learn.org/dev/faq.html#why-is-my-pull-request-not-getting-any-attention.\r\n\r\nThanks for contributing!\r\n-->\r\n"},"comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments/325481436","html_url":"https://github.com/scikit-learn/scikit-learn/pull/9588#issuecomment-325481436","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/9588","id":325481436,"user":{"login":"thechargedneutron","id":25536866,"avatar_url":"https://avatars1.githubusercontent.com/u/25536866?v=4","gravatar_id":"","url":"https://api.github.com/users/thechargedneutron","html_url":"https://github.com/thechargedneutron","followers_url":"https://api.github.com/users/thechargedneutron/followers","following_url":"https://api.github.com/users/thechargedneutron/following{/other_user}","gists_url":"https://api.github.com/users/thechargedneutron/gists{/gist_id}","starred_url":"https://api.github.com/users/thechargedneutron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thechargedneutron/subscriptions","organizations_url":"https://api.github.com/users/thechargedneutron/orgs","repos_url":"https://api.github.com/users/thechargedneutron/repos","events_url":"https://api.github.com/users/thechargedneutron/events{/privacy}","received_events_url":"https://api.github.com/users/thechargedneutron/received_events","type":"User","site_admin":false},"created_at":"2017-08-28T21:05:32Z","updated_at":"2017-08-28T21:05:32Z","body":"@amueller Changes added. Kindly suggest if any more change is required."}}
{"actor":{"display_login":"thechargedneutron"}}