{"action":"created","issue":{"url":"https://api.github.com/repos/shouldjs/should.js/issues/135","repository_url":"https://api.github.com/repos/shouldjs/should.js","labels_url":"https://api.github.com/repos/shouldjs/should.js/issues/135/labels{/name}","comments_url":"https://api.github.com/repos/shouldjs/should.js/issues/135/comments","events_url":"https://api.github.com/repos/shouldjs/should.js/issues/135/events","html_url":"https://github.com/shouldjs/should.js/issues/135","id":203583673,"number":135,"title":"`.not` is an antipattern","user":{"login":"btd","id":334851,"avatar_url":"https://avatars0.githubusercontent.com/u/334851?v=3","gravatar_id":"","url":"https://api.github.com/users/btd","html_url":"https://github.com/btd","followers_url":"https://api.github.com/users/btd/followers","following_url":"https://api.github.com/users/btd/following{/other_user}","gists_url":"https://api.github.com/users/btd/gists{/gist_id}","starred_url":"https://api.github.com/users/btd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/btd/subscriptions","organizations_url":"https://api.github.com/users/btd/orgs","repos_url":"https://api.github.com/users/btd/repos","events_url":"https://api.github.com/users/btd/events{/privacy}","received_events_url":"https://api.github.com/users/btd/received_events","type":"User","site_admin":false},"labels":[{"id":197248035,"url":"https://api.github.com/repos/shouldjs/should.js/labels/discussion","name":"discussion","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-01-27T08:51:45Z","updated_at":"2017-05-26T17:29:20Z","closed_at":null,"body":"`.not` modifier, while it looks very usefull from breaf view is clearly antipattern. I personally avoiding use it.\r\nIt produce additional class of possible problems like:\r\n```js\r\n(10).should.not.be.a.Number()\r\n```\r\nThere we see assertion object 10 to not be a Number, but assume you have more complex object you get from API response. So each time .not used need clearly rereview its usage.\r\n\r\nSingle usefull case for .not it is usage with .eql and .equal based assertions. When we know the actual object should not be equal to given in some way.\r\n\r\nSo probably it is worth to deprecate .not for everything by not .eql and .equal"},"comment":{"url":"https://api.github.com/repos/shouldjs/should.js/issues/comments/304342252","html_url":"https://github.com/shouldjs/should.js/issues/135#issuecomment-304342252","issue_url":"https://api.github.com/repos/shouldjs/should.js/issues/135","id":304342252,"user":{"login":"tonylukasavage","id":594112,"avatar_url":"https://avatars0.githubusercontent.com/u/594112?v=3","gravatar_id":"","url":"https://api.github.com/users/tonylukasavage","html_url":"https://github.com/tonylukasavage","followers_url":"https://api.github.com/users/tonylukasavage/followers","following_url":"https://api.github.com/users/tonylukasavage/following{/other_user}","gists_url":"https://api.github.com/users/tonylukasavage/gists{/gist_id}","starred_url":"https://api.github.com/users/tonylukasavage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tonylukasavage/subscriptions","organizations_url":"https://api.github.com/users/tonylukasavage/orgs","repos_url":"https://api.github.com/users/tonylukasavage/repos","events_url":"https://api.github.com/users/tonylukasavage/events{/privacy}","received_events_url":"https://api.github.com/users/tonylukasavage/received_events","type":"User","site_admin":false},"created_at":"2017-05-26T17:29:20Z","updated_at":"2017-05-26T17:29:20Z","body":"ditto above, been using should.js for years and have almost never used `.not` "}}
{"actor":{"display_login":"tonylukasavage"}}