{"action":"created","comment":{"url":"https://api.github.com/repos/postmates/cernan/pulls/comments/140874247","pull_request_review_id":65008347,"id":140874247,"diff_hunk":"@@ -1,11 +1,30 @@\n //! Prometheus is a pull-based aggregation server\n+//!\n+//! This sink emits all cernan aggregations into prometheus according to the\n+//! following method:\n+//!\n+//!   - SET -> gauge\n+//!   - SUM -> counter\n+//!   - QUANTILES -> summary \n+//!   - HISTOGRAM -> histogram\n+//!\n+//! All points are retained in a sliding window defined by\n+//! `retain_limit`. Points will persist indefinately unless new points come\n+//! behind them to push them out of the `retain_limit` window.","path":"src/sink/prometheus.rs","position":13,"original_position":13,"commit_id":"da80ac412cc2bfccbea6b157c67f07f3744089a7","original_commit_id":"58f8b25afcd8d53399b452f0f15a94e4cc5b598e","user":{"login":"benley","id":1432730,"avatar_url":"https://avatars1.githubusercontent.com/u/1432730?v=4","gravatar_id":"","url":"https://api.github.com/users/benley","html_url":"https://github.com/benley","followers_url":"https://api.github.com/users/benley/followers","following_url":"https://api.github.com/users/benley/following{/other_user}","gists_url":"https://api.github.com/users/benley/gists{/gist_id}","starred_url":"https://api.github.com/users/benley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benley/subscriptions","organizations_url":"https://api.github.com/users/benley/orgs","repos_url":"https://api.github.com/users/benley/repos","events_url":"https://api.github.com/users/benley/events{/privacy}","received_events_url":"https://api.github.com/users/benley/received_events","type":"User","site_admin":false},"body":"Configuration per time series would be cool but I'd settle for a time-based window for the quantiles instead of a count-based one.\r\n\r\nOne thing I haven't checked but should have: are the `<summaryname>_sum`  and `<summaryname>_count` metrics totals since forever?  If not, can you make them that away?","created_at":"2017-09-25T19:27:24Z","updated_at":"2017-09-25T19:27:24Z","html_url":"https://github.com/postmates/cernan/pull/306#discussion_r140874247","pull_request_url":"https://api.github.com/repos/postmates/cernan/pulls/306","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/postmates/cernan/pulls/comments/140874247"},"html":{"href":"https://github.com/postmates/cernan/pull/306#discussion_r140874247"},"pull_request":{"href":"https://api.github.com/repos/postmates/cernan/pulls/306"}},"in_reply_to_id":139770087},"pull_request":{"url":"https://api.github.com/repos/postmates/cernan/pulls/306","id":139692324,"html_url":"https://github.com/postmates/cernan/pull/306","diff_url":"https://github.com/postmates/cernan/pull/306.diff","patch_url":"https://github.com/postmates/cernan/pull/306.patch","issue_url":"https://api.github.com/repos/postmates/cernan/issues/306","number":306,"state":"open","locked":false,"title":"Make Prometheus sink obey aggregations","user":{"login":"blt","id":3579,"avatar_url":"https://avatars0.githubusercontent.com/u/3579?v=4","gravatar_id":"","url":"https://api.github.com/users/blt","html_url":"https://github.com/blt","followers_url":"https://api.github.com/users/blt/followers","following_url":"https://api.github.com/users/blt/following{/other_user}","gists_url":"https://api.github.com/users/blt/gists{/gist_id}","starred_url":"https://api.github.com/users/blt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blt/subscriptions","organizations_url":"https://api.github.com/users/blt/orgs","repos_url":"https://api.github.com/users/blt/repos","events_url":"https://api.github.com/users/blt/events{/privacy}","received_events_url":"https://api.github.com/users/blt/received_events","type":"User","site_admin":false},"body":"This commit makes the prometheus sink send a variety of types, rather\r\nthan the quantile, now that Telemetry is backed by different and\r\ndistinct kinds.\r\n\r\nThis is part of the work for #290.\r\n\r\nThis is related to the work of #285.\r\n\r\nSigned-off-by: Brian L. Troutwine <blt@postmates.com>","created_at":"2017-09-07T00:22:32Z","updated_at":"2017-09-25T19:27:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bfa5d1994e9c4b3f4a055f09a2f9c2c8a738fa67","assignee":{"login":"benley","id":1432730,"avatar_url":"https://avatars1.githubusercontent.com/u/1432730?v=4","gravatar_id":"","url":"https://api.github.com/users/benley","html_url":"https://github.com/benley","followers_url":"https://api.github.com/users/benley/followers","following_url":"https://api.github.com/users/benley/following{/other_user}","gists_url":"https://api.github.com/users/benley/gists{/gist_id}","starred_url":"https://api.github.com/users/benley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benley/subscriptions","organizations_url":"https://api.github.com/users/benley/orgs","repos_url":"https://api.github.com/users/benley/repos","events_url":"https://api.github.com/users/benley/events{/privacy}","received_events_url":"https://api.github.com/users/benley/received_events","type":"User","site_admin":false},"assignees":[{"login":"benley","id":1432730,"avatar_url":"https://avatars1.githubusercontent.com/u/1432730?v=4","gravatar_id":"","url":"https://api.github.com/users/benley","html_url":"https://github.com/benley","followers_url":"https://api.github.com/users/benley/followers","following_url":"https://api.github.com/users/benley/following{/other_user}","gists_url":"https://api.github.com/users/benley/gists{/gist_id}","starred_url":"https://api.github.com/users/benley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benley/subscriptions","organizations_url":"https://api.github.com/users/benley/orgs","repos_url":"https://api.github.com/users/benley/repos","events_url":"https://api.github.com/users/benley/events{/privacy}","received_events_url":"https://api.github.com/users/benley/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"lynchc","id":3439990,"avatar_url":"https://avatars1.githubusercontent.com/u/3439990?v=4","gravatar_id":"","url":"https://api.github.com/users/lynchc","html_url":"https://github.com/lynchc","followers_url":"https://api.github.com/users/lynchc/followers","following_url":"https://api.github.com/users/lynchc/following{/other_user}","gists_url":"https://api.github.com/users/lynchc/gists{/gist_id}","starred_url":"https://api.github.com/users/lynchc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lynchc/subscriptions","organizations_url":"https://api.github.com/users/lynchc/orgs","repos_url":"https://api.github.com/users/lynchc/repos","events_url":"https://api.github.com/users/lynchc/events{/privacy}","received_events_url":"https://api.github.com/users/lynchc/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/postmates/cernan/pulls/306/commits","review_comments_url":"https://api.github.com/repos/postmates/cernan/pulls/306/comments","review_comment_url":"https://api.github.com/repos/postmates/cernan/pulls/comments{/number}","comments_url":"https://api.github.com/repos/postmates/cernan/issues/306/comments","statuses_url":"https://api.github.com/repos/postmates/cernan/statuses/da80ac412cc2bfccbea6b157c67f07f3744089a7","head":{"label":"postmates:prometheus_obeys_aggregation","ref":"prometheus_obeys_aggregation","sha":"da80ac412cc2bfccbea6b157c67f07f3744089a7","user":{"login":"postmates","id":426014,"avatar_url":"https://avatars1.githubusercontent.com/u/426014?v=4","gravatar_id":"","url":"https://api.github.com/users/postmates","html_url":"https://github.com/postmates","followers_url":"https://api.github.com/users/postmates/followers","following_url":"https://api.github.com/users/postmates/following{/other_user}","gists_url":"https://api.github.com/users/postmates/gists{/gist_id}","starred_url":"https://api.github.com/users/postmates/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/postmates/subscriptions","organizations_url":"https://api.github.com/users/postmates/orgs","repos_url":"https://api.github.com/users/postmates/repos","events_url":"https://api.github.com/users/postmates/events{/privacy}","received_events_url":"https://api.github.com/users/postmates/received_events","type":"Organization","site_admin":false},"repo":{"id":60210125,"name":"cernan","full_name":"postmates/cernan","owner":{"login":"postmates","id":426014,"avatar_url":"https://avatars1.githubusercontent.com/u/426014?v=4","gravatar_id":"","url":"https://api.github.com/users/postmates","html_url":"https://github.com/postmates","followers_url":"https://api.github.com/users/postmates/followers","following_url":"https://api.github.com/users/postmates/following{/other_user}","gists_url":"https://api.github.com/users/postmates/gists{/gist_id}","starred_url":"https://api.github.com/users/postmates/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/postmates/subscriptions","organizations_url":"https://api.github.com/users/postmates/orgs","repos_url":"https://api.github.com/users/postmates/repos","events_url":"https://api.github.com/users/postmates/events{/privacy}","received_events_url":"https://api.github.com/users/postmates/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/postmates/cernan","description":"telemetry aggregation and shipping, last up the ladder","fork":false,"url":"https://api.github.com/repos/postmates/cernan","forks_url":"https://api.github.com/repos/postmates/cernan/forks","keys_url":"https://api.github.com/repos/postmates/cernan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/postmates/cernan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/postmates/cernan/teams","hooks_url":"https://api.github.com/repos/postmates/cernan/hooks","issue_events_url":"https://api.github.com/repos/postmates/cernan/issues/events{/number}","events_url":"https://api.github.com/repos/postmates/cernan/events","assignees_url":"https://api.github.com/repos/postmates/cernan/assignees{/user}","branches_url":"https://api.github.com/repos/postmates/cernan/branches{/branch}","tags_url":"https://api.github.com/repos/postmates/cernan/tags","blobs_url":"https://api.github.com/repos/postmates/cernan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/postmates/cernan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/postmates/cernan/git/refs{/sha}","trees_url":"https://api.github.com/repos/postmates/cernan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/postmates/cernan/statuses/{sha}","languages_url":"https://api.github.com/repos/postmates/cernan/languages","stargazers_url":"https://api.github.com/repos/postmates/cernan/stargazers","contributors_url":"https://api.github.com/repos/postmates/cernan/contributors","subscribers_url":"https://api.github.com/repos/postmates/cernan/subscribers","subscription_url":"https://api.github.com/repos/postmates/cernan/subscription","commits_url":"https://api.github.com/repos/postmates/cernan/commits{/sha}","git_commits_url":"https://api.github.com/repos/postmates/cernan/git/commits{/sha}","comments_url":"https://api.github.com/repos/postmates/cernan/comments{/number}","issue_comment_url":"https://api.github.com/repos/postmates/cernan/issues/comments{/number}","contents_url":"https://api.github.com/repos/postmates/cernan/contents/{+path}","compare_url":"https://api.github.com/repos/postmates/cernan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/postmates/cernan/merges","archive_url":"https://api.github.com/repos/postmates/cernan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/postmates/cernan/downloads","issues_url":"https://api.github.com/repos/postmates/cernan/issues{/number}","pulls_url":"https://api.github.com/repos/postmates/cernan/pulls{/number}","milestones_url":"https://api.github.com/repos/postmates/cernan/milestones{/number}","notifications_url":"https://api.github.com/repos/postmates/cernan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/postmates/cernan/labels{/name}","releases_url":"https://api.github.com/repos/postmates/cernan/releases{/id}","deployments_url":"https://api.github.com/repos/postmates/cernan/deployments","created_at":"2016-06-01T20:54:53Z","updated_at":"2017-09-24T14:21:23Z","pushed_at":"2017-09-25T18:18:17Z","git_url":"git://github.com/postmates/cernan.git","ssh_url":"git@github.com:postmates/cernan.git","clone_url":"https://github.com/postmates/cernan.git","svn_url":"https://github.com/postmates/cernan","homepage":null,"size":1264,"stargazers_count":160,"watchers_count":160,"language":"Rust","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":28,"forks":6,"open_issues":28,"watchers":160,"default_branch":"master"}},"base":{"label":"postmates:master","ref":"master","sha":"8cea57a145dad5f3f1836e4ef8ead19f31586794","user":{"login":"postmates","id":426014,"avatar_url":"https://avatars1.githubusercontent.com/u/426014?v=4","gravatar_id":"","url":"https://api.github.com/users/postmates","html_url":"https://github.com/postmates","followers_url":"https://api.github.com/users/postmates/followers","following_url":"https://api.github.com/users/postmates/following{/other_user}","gists_url":"https://api.github.com/users/postmates/gists{/gist_id}","starred_url":"https://api.github.com/users/postmates/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/postmates/subscriptions","organizations_url":"https://api.github.com/users/postmates/orgs","repos_url":"https://api.github.com/users/postmates/repos","events_url":"https://api.github.com/users/postmates/events{/privacy}","received_events_url":"https://api.github.com/users/postmates/received_events","type":"Organization","site_admin":false},"repo":{"id":60210125,"name":"cernan","full_name":"postmates/cernan","owner":{"login":"postmates","id":426014,"avatar_url":"https://avatars1.githubusercontent.com/u/426014?v=4","gravatar_id":"","url":"https://api.github.com/users/postmates","html_url":"https://github.com/postmates","followers_url":"https://api.github.com/users/postmates/followers","following_url":"https://api.github.com/users/postmates/following{/other_user}","gists_url":"https://api.github.com/users/postmates/gists{/gist_id}","starred_url":"https://api.github.com/users/postmates/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/postmates/subscriptions","organizations_url":"https://api.github.com/users/postmates/orgs","repos_url":"https://api.github.com/users/postmates/repos","events_url":"https://api.github.com/users/postmates/events{/privacy}","received_events_url":"https://api.github.com/users/postmates/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/postmates/cernan","description":"telemetry aggregation and shipping, last up the ladder","fork":false,"url":"https://api.github.com/repos/postmates/cernan","forks_url":"https://api.github.com/repos/postmates/cernan/forks","keys_url":"https://api.github.com/repos/postmates/cernan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/postmates/cernan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/postmates/cernan/teams","hooks_url":"https://api.github.com/repos/postmates/cernan/hooks","issue_events_url":"https://api.github.com/repos/postmates/cernan/issues/events{/number}","events_url":"https://api.github.com/repos/postmates/cernan/events","assignees_url":"https://api.github.com/repos/postmates/cernan/assignees{/user}","branches_url":"https://api.github.com/repos/postmates/cernan/branches{/branch}","tags_url":"https://api.github.com/repos/postmates/cernan/tags","blobs_url":"https://api.github.com/repos/postmates/cernan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/postmates/cernan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/postmates/cernan/git/refs{/sha}","trees_url":"https://api.github.com/repos/postmates/cernan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/postmates/cernan/statuses/{sha}","languages_url":"https://api.github.com/repos/postmates/cernan/languages","stargazers_url":"https://api.github.com/repos/postmates/cernan/stargazers","contributors_url":"https://api.github.com/repos/postmates/cernan/contributors","subscribers_url":"https://api.github.com/repos/postmates/cernan/subscribers","subscription_url":"https://api.github.com/repos/postmates/cernan/subscription","commits_url":"https://api.github.com/repos/postmates/cernan/commits{/sha}","git_commits_url":"https://api.github.com/repos/postmates/cernan/git/commits{/sha}","comments_url":"https://api.github.com/repos/postmates/cernan/comments{/number}","issue_comment_url":"https://api.github.com/repos/postmates/cernan/issues/comments{/number}","contents_url":"https://api.github.com/repos/postmates/cernan/contents/{+path}","compare_url":"https://api.github.com/repos/postmates/cernan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/postmates/cernan/merges","archive_url":"https://api.github.com/repos/postmates/cernan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/postmates/cernan/downloads","issues_url":"https://api.github.com/repos/postmates/cernan/issues{/number}","pulls_url":"https://api.github.com/repos/postmates/cernan/pulls{/number}","milestones_url":"https://api.github.com/repos/postmates/cernan/milestones{/number}","notifications_url":"https://api.github.com/repos/postmates/cernan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/postmates/cernan/labels{/name}","releases_url":"https://api.github.com/repos/postmates/cernan/releases{/id}","deployments_url":"https://api.github.com/repos/postmates/cernan/deployments","created_at":"2016-06-01T20:54:53Z","updated_at":"2017-09-24T14:21:23Z","pushed_at":"2017-09-25T18:18:17Z","git_url":"git://github.com/postmates/cernan.git","ssh_url":"git@github.com:postmates/cernan.git","clone_url":"https://github.com/postmates/cernan.git","svn_url":"https://github.com/postmates/cernan","homepage":null,"size":1264,"stargazers_count":160,"watchers_count":160,"language":"Rust","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":28,"forks":6,"open_issues":28,"watchers":160,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/postmates/cernan/pulls/306"},"html":{"href":"https://github.com/postmates/cernan/pull/306"},"issue":{"href":"https://api.github.com/repos/postmates/cernan/issues/306"},"comments":{"href":"https://api.github.com/repos/postmates/cernan/issues/306/comments"},"review_comments":{"href":"https://api.github.com/repos/postmates/cernan/pulls/306/comments"},"review_comment":{"href":"https://api.github.com/repos/postmates/cernan/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/postmates/cernan/pulls/306/commits"},"statuses":{"href":"https://api.github.com/repos/postmates/cernan/statuses/da80ac412cc2bfccbea6b157c67f07f3744089a7"}},"author_association":"OWNER"}}
{"actor":{"display_login":"benley"}}