{"action":"closed","number":878,"pull_request":{"url":"https://api.github.com/repos/restsharp/RestSharp/pulls/878","id":86176675,"html_url":"https://github.com/restsharp/RestSharp/pull/878","diff_url":"https://github.com/restsharp/RestSharp/pull/878.diff","patch_url":"https://github.com/restsharp/RestSharp/pull/878.patch","issue_url":"https://api.github.com/repos/restsharp/RestSharp/issues/878","number":878,"state":"closed","locked":false,"title":"Change restricted header action for If-Modified-Since to use Invariant CultureInfo","user":{"login":"mrknmc","id":738351,"avatar_url":"https://avatars0.githubusercontent.com/u/738351?v=4","gravatar_id":"","url":"https://api.github.com/users/mrknmc","html_url":"https://github.com/mrknmc","followers_url":"https://api.github.com/users/mrknmc/followers","following_url":"https://api.github.com/users/mrknmc/following{/other_user}","gists_url":"https://api.github.com/users/mrknmc/gists{/gist_id}","starred_url":"https://api.github.com/users/mrknmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrknmc/subscriptions","organizations_url":"https://api.github.com/users/mrknmc/orgs","repos_url":"https://api.github.com/users/mrknmc/repos","events_url":"https://api.github.com/users/mrknmc/events{/privacy}","received_events_url":"https://api.github.com/users/mrknmc/received_events","type":"User","site_admin":false},"body":"We were having issues communicating between services using different calendar formats, because the date restriction in the header action was not accepting a gregorian calendar date from the caller as its culture was set to th-TH (using a buddhist calendar), but the receiving service would not have accepted a th-TH style date. \nThe fix is to change the date formatting of the `If-Modified-Since` header to use the invariant CultureInfo. This allows services to use RFC1123 formatting for the `If-Modified-Since` header to get around any localization issues.\n\nFor example: currently, with the current culture of the service set to th-TH and the `If-Modified-Since` header equal to `\"Thu, 15 Sep 2016 20:07:00 GMT\"` the Execute method returns an error response with the following trace:\n\n```\n   at System.DateTimeParse.Parse(String s, DateTimeFormatInfo dtfi, DateTimeStyles styles)\n   at System.Convert.ToDateTime(String value)\n   at RestSharp.Http.<AddSyncHeaderActions>b__25(HttpWebRequest r, String v)\n   at RestSharp.Http.AppendHeaders(HttpWebRequest webRequest)\n   at RestSharp.Http.ConfigureWebRequest(String method, Uri url)\n   at RestSharp.Http.GetStyleMethodInternal(String method)\n   at RestSharp.RestClient.Execute(IRestRequest request, String httpMethod, Func`3 getResponse)\n```\n\nWith this fix in place, Execute allows the header to be in the RFC1123 format no matter what the current culture of the service is.\n","created_at":"2016-09-21T14:43:10Z","updated_at":"2017-11-09T08:58:07Z","closed_at":"2017-11-09T08:58:07Z","merged_at":"2017-11-09T08:58:07Z","merge_commit_sha":"6748787e4036875d141e6085533d4f0dc7aacf53","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/restsharp/RestSharp/pulls/878/commits","review_comments_url":"https://api.github.com/repos/restsharp/RestSharp/pulls/878/comments","review_comment_url":"https://api.github.com/repos/restsharp/RestSharp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/restsharp/RestSharp/issues/878/comments","statuses_url":"https://api.github.com/repos/restsharp/RestSharp/statuses/a0e68ab36b00f4b84bdfbf42bbb7b0a0d0434723","head":{"label":"Skyscanner:if-modified-since-header-invariant-culture","ref":"if-modified-since-header-invariant-culture","sha":"a0e68ab36b00f4b84bdfbf42bbb7b0a0d0434723","user":{"login":"Skyscanner","id":522811,"avatar_url":"https://avatars2.githubusercontent.com/u/522811?v=4","gravatar_id":"","url":"https://api.github.com/users/Skyscanner","html_url":"https://github.com/Skyscanner","followers_url":"https://api.github.com/users/Skyscanner/followers","following_url":"https://api.github.com/users/Skyscanner/following{/other_user}","gists_url":"https://api.github.com/users/Skyscanner/gists{/gist_id}","starred_url":"https://api.github.com/users/Skyscanner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Skyscanner/subscriptions","organizations_url":"https://api.github.com/users/Skyscanner/orgs","repos_url":"https://api.github.com/users/Skyscanner/repos","events_url":"https://api.github.com/users/Skyscanner/events{/privacy}","received_events_url":"https://api.github.com/users/Skyscanner/received_events","type":"Organization","site_admin":false},"repo":{"id":68817508,"name":"RestSharp","full_name":"Skyscanner/RestSharp","owner":{"login":"Skyscanner","id":522811,"avatar_url":"https://avatars2.githubusercontent.com/u/522811?v=4","gravatar_id":"","url":"https://api.github.com/users/Skyscanner","html_url":"https://github.com/Skyscanner","followers_url":"https://api.github.com/users/Skyscanner/followers","following_url":"https://api.github.com/users/Skyscanner/following{/other_user}","gists_url":"https://api.github.com/users/Skyscanner/gists{/gist_id}","starred_url":"https://api.github.com/users/Skyscanner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Skyscanner/subscriptions","organizations_url":"https://api.github.com/users/Skyscanner/orgs","repos_url":"https://api.github.com/users/Skyscanner/repos","events_url":"https://api.github.com/users/Skyscanner/events{/privacy}","received_events_url":"https://api.github.com/users/Skyscanner/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Skyscanner/RestSharp","description":"Simple REST and HTTP API Client for .NET","fork":true,"url":"https://api.github.com/repos/Skyscanner/RestSharp","forks_url":"https://api.github.com/repos/Skyscanner/RestSharp/forks","keys_url":"https://api.github.com/repos/Skyscanner/RestSharp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Skyscanner/RestSharp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Skyscanner/RestSharp/teams","hooks_url":"https://api.github.com/repos/Skyscanner/RestSharp/hooks","issue_events_url":"https://api.github.com/repos/Skyscanner/RestSharp/issues/events{/number}","events_url":"https://api.github.com/repos/Skyscanner/RestSharp/events","assignees_url":"https://api.github.com/repos/Skyscanner/RestSharp/assignees{/user}","branches_url":"https://api.github.com/repos/Skyscanner/RestSharp/branches{/branch}","tags_url":"https://api.github.com/repos/Skyscanner/RestSharp/tags","blobs_url":"https://api.github.com/repos/Skyscanner/RestSharp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Skyscanner/RestSharp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Skyscanner/RestSharp/git/refs{/sha}","trees_url":"https://api.github.com/repos/Skyscanner/RestSharp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Skyscanner/RestSharp/statuses/{sha}","languages_url":"https://api.github.com/repos/Skyscanner/RestSharp/languages","stargazers_url":"https://api.github.com/repos/Skyscanner/RestSharp/stargazers","contributors_url":"https://api.github.com/repos/Skyscanner/RestSharp/contributors","subscribers_url":"https://api.github.com/repos/Skyscanner/RestSharp/subscribers","subscription_url":"https://api.github.com/repos/Skyscanner/RestSharp/subscription","commits_url":"https://api.github.com/repos/Skyscanner/RestSharp/commits{/sha}","git_commits_url":"https://api.github.com/repos/Skyscanner/RestSharp/git/commits{/sha}","comments_url":"https://api.github.com/repos/Skyscanner/RestSharp/comments{/number}","issue_comment_url":"https://api.github.com/repos/Skyscanner/RestSharp/issues/comments{/number}","contents_url":"https://api.github.com/repos/Skyscanner/RestSharp/contents/{+path}","compare_url":"https://api.github.com/repos/Skyscanner/RestSharp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Skyscanner/RestSharp/merges","archive_url":"https://api.github.com/repos/Skyscanner/RestSharp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Skyscanner/RestSharp/downloads","issues_url":"https://api.github.com/repos/Skyscanner/RestSharp/issues{/number}","pulls_url":"https://api.github.com/repos/Skyscanner/RestSharp/pulls{/number}","milestones_url":"https://api.github.com/repos/Skyscanner/RestSharp/milestones{/number}","notifications_url":"https://api.github.com/repos/Skyscanner/RestSharp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Skyscanner/RestSharp/labels{/name}","releases_url":"https://api.github.com/repos/Skyscanner/RestSharp/releases{/id}","deployments_url":"https://api.github.com/repos/Skyscanner/RestSharp/deployments","created_at":"2016-09-21T13:04:20Z","updated_at":"2017-08-11T18:27:47Z","pushed_at":"2017-11-09T08:52:36Z","git_url":"git://github.com/Skyscanner/RestSharp.git","ssh_url":"git@github.com:Skyscanner/RestSharp.git","clone_url":"https://github.com/Skyscanner/RestSharp.git","svn_url":"https://github.com/Skyscanner/RestSharp","homepage":"http://restsharp.org","size":36593,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"restsharp:develop","ref":"develop","sha":"5bfd52f65bc1c117d71a38396d68ee36d6be301f","user":{"login":"restsharp","id":1057779,"avatar_url":"https://avatars2.githubusercontent.com/u/1057779?v=4","gravatar_id":"","url":"https://api.github.com/users/restsharp","html_url":"https://github.com/restsharp","followers_url":"https://api.github.com/users/restsharp/followers","following_url":"https://api.github.com/users/restsharp/following{/other_user}","gists_url":"https://api.github.com/users/restsharp/gists{/gist_id}","starred_url":"https://api.github.com/users/restsharp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/restsharp/subscriptions","organizations_url":"https://api.github.com/users/restsharp/orgs","repos_url":"https://api.github.com/users/restsharp/repos","events_url":"https://api.github.com/users/restsharp/events{/privacy}","received_events_url":"https://api.github.com/users/restsharp/received_events","type":"Organization","site_admin":false},"repo":{"id":374228,"name":"RestSharp","full_name":"restsharp/RestSharp","owner":{"login":"restsharp","id":1057779,"avatar_url":"https://avatars2.githubusercontent.com/u/1057779?v=4","gravatar_id":"","url":"https://api.github.com/users/restsharp","html_url":"https://github.com/restsharp","followers_url":"https://api.github.com/users/restsharp/followers","following_url":"https://api.github.com/users/restsharp/following{/other_user}","gists_url":"https://api.github.com/users/restsharp/gists{/gist_id}","starred_url":"https://api.github.com/users/restsharp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/restsharp/subscriptions","organizations_url":"https://api.github.com/users/restsharp/orgs","repos_url":"https://api.github.com/users/restsharp/repos","events_url":"https://api.github.com/users/restsharp/events{/privacy}","received_events_url":"https://api.github.com/users/restsharp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/restsharp/RestSharp","description":"Simple REST and HTTP API Client for .NET","fork":false,"url":"https://api.github.com/repos/restsharp/RestSharp","forks_url":"https://api.github.com/repos/restsharp/RestSharp/forks","keys_url":"https://api.github.com/repos/restsharp/RestSharp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/restsharp/RestSharp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/restsharp/RestSharp/teams","hooks_url":"https://api.github.com/repos/restsharp/RestSharp/hooks","issue_events_url":"https://api.github.com/repos/restsharp/RestSharp/issues/events{/number}","events_url":"https://api.github.com/repos/restsharp/RestSharp/events","assignees_url":"https://api.github.com/repos/restsharp/RestSharp/assignees{/user}","branches_url":"https://api.github.com/repos/restsharp/RestSharp/branches{/branch}","tags_url":"https://api.github.com/repos/restsharp/RestSharp/tags","blobs_url":"https://api.github.com/repos/restsharp/RestSharp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/restsharp/RestSharp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/restsharp/RestSharp/git/refs{/sha}","trees_url":"https://api.github.com/repos/restsharp/RestSharp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/restsharp/RestSharp/statuses/{sha}","languages_url":"https://api.github.com/repos/restsharp/RestSharp/languages","stargazers_url":"https://api.github.com/repos/restsharp/RestSharp/stargazers","contributors_url":"https://api.github.com/repos/restsharp/RestSharp/contributors","subscribers_url":"https://api.github.com/repos/restsharp/RestSharp/subscribers","subscription_url":"https://api.github.com/repos/restsharp/RestSharp/subscription","commits_url":"https://api.github.com/repos/restsharp/RestSharp/commits{/sha}","git_commits_url":"https://api.github.com/repos/restsharp/RestSharp/git/commits{/sha}","comments_url":"https://api.github.com/repos/restsharp/RestSharp/comments{/number}","issue_comment_url":"https://api.github.com/repos/restsharp/RestSharp/issues/comments{/number}","contents_url":"https://api.github.com/repos/restsharp/RestSharp/contents/{+path}","compare_url":"https://api.github.com/repos/restsharp/RestSharp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/restsharp/RestSharp/merges","archive_url":"https://api.github.com/repos/restsharp/RestSharp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/restsharp/RestSharp/downloads","issues_url":"https://api.github.com/repos/restsharp/RestSharp/issues{/number}","pulls_url":"https://api.github.com/repos/restsharp/RestSharp/pulls{/number}","milestones_url":"https://api.github.com/repos/restsharp/RestSharp/milestones{/number}","notifications_url":"https://api.github.com/repos/restsharp/RestSharp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/restsharp/RestSharp/labels{/name}","releases_url":"https://api.github.com/repos/restsharp/RestSharp/releases{/id}","deployments_url":"https://api.github.com/repos/restsharp/RestSharp/deployments","created_at":"2009-11-16T02:01:45Z","updated_at":"2017-11-09T01:50:17Z","pushed_at":"2017-11-09T08:58:07Z","git_url":"git://github.com/restsharp/RestSharp.git","ssh_url":"git@github.com:restsharp/RestSharp.git","clone_url":"https://github.com/restsharp/RestSharp.git","svn_url":"https://github.com/restsharp/RestSharp","homepage":"http://restsharp.org","size":37540,"stargazers_count":4720,"watchers_count":4720,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1557,"mirror_url":null,"archived":false,"open_issues_count":148,"forks":1557,"open_issues":148,"watchers":4720,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/restsharp/RestSharp/pulls/878"},"html":{"href":"https://github.com/restsharp/RestSharp/pull/878"},"issue":{"href":"https://api.github.com/repos/restsharp/RestSharp/issues/878"},"comments":{"href":"https://api.github.com/repos/restsharp/RestSharp/issues/878/comments"},"review_comments":{"href":"https://api.github.com/repos/restsharp/RestSharp/pulls/878/comments"},"review_comment":{"href":"https://api.github.com/repos/restsharp/RestSharp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/restsharp/RestSharp/pulls/878/commits"},"statuses":{"href":"https://api.github.com/repos/restsharp/RestSharp/statuses/a0e68ab36b00f4b84bdfbf42bbb7b0a0d0434723"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"alexeyzimarev","id":2821205,"avatar_url":"https://avatars3.githubusercontent.com/u/2821205?v=4","gravatar_id":"","url":"https://api.github.com/users/alexeyzimarev","html_url":"https://github.com/alexeyzimarev","followers_url":"https://api.github.com/users/alexeyzimarev/followers","following_url":"https://api.github.com/users/alexeyzimarev/following{/other_user}","gists_url":"https://api.github.com/users/alexeyzimarev/gists{/gist_id}","starred_url":"https://api.github.com/users/alexeyzimarev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexeyzimarev/subscriptions","organizations_url":"https://api.github.com/users/alexeyzimarev/orgs","repos_url":"https://api.github.com/users/alexeyzimarev/repos","events_url":"https://api.github.com/users/alexeyzimarev/events{/privacy}","received_events_url":"https://api.github.com/users/alexeyzimarev/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":2,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"alexeyzimarev"}}