{"action":"created","comment":{"url":"https://api.github.com/repos/domoticz/domoticz/pulls/comments/125997381","pull_request_review_id":48442941,"id":125997381,"diff_hunk":"@@ -1235,7 +1254,28 @@ void CEventSystem::EvaluateEvent(const std::string &reason, const uint64_t Devic\n \t\t{\n \t\t\tif (reason == \"device\" && filename.find(\"_device_\") != std::string::npos)\n \t\t\t{\n-\t\t\t\tEvaluateLua(reason, lua_Dir + filename, \"\", DeviceID, devname, nValue, sValue, nValueWording, 0);\n+\t\t\t\tbDeviceFileFound = false;","path":"main/EventSystem.cpp","position":81,"original_position":81,"commit_id":"dfb6d6e0fb837b5fc084cb9a42775819e81ce7fa","original_commit_id":"74b59052883611b869e17b482c7fb95bbcdafad3","user":{"login":"jvandenbroek","id":3118327,"avatar_url":"https://avatars3.githubusercontent.com/u/3118327?v=3","gravatar_id":"","url":"https://api.github.com/users/jvandenbroek","html_url":"https://github.com/jvandenbroek","followers_url":"https://api.github.com/users/jvandenbroek/followers","following_url":"https://api.github.com/users/jvandenbroek/following{/other_user}","gists_url":"https://api.github.com/users/jvandenbroek/gists{/gist_id}","starred_url":"https://api.github.com/users/jvandenbroek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jvandenbroek/subscriptions","organizations_url":"https://api.github.com/users/jvandenbroek/orgs","repos_url":"https://api.github.com/users/jvandenbroek/repos","events_url":"https://api.github.com/users/jvandenbroek/events{/privacy}","received_events_url":"https://api.github.com/users/jvandenbroek/received_events","type":"User","site_admin":false},"body":"It's intended, just rename the script to some name that doesn't exist. You're right about updating the wiki, will look into it, thanks for noticing.","created_at":"2017-07-06T19:44:27Z","updated_at":"2017-07-06T19:44:27Z","html_url":"https://github.com/domoticz/domoticz/pull/1655#discussion_r125997381","pull_request_url":"https://api.github.com/repos/domoticz/domoticz/pulls/1655","_links":{"self":{"href":"https://api.github.com/repos/domoticz/domoticz/pulls/comments/125997381"},"html":{"href":"https://github.com/domoticz/domoticz/pull/1655#discussion_r125997381"},"pull_request":{"href":"https://api.github.com/repos/domoticz/domoticz/pulls/1655"}}},"pull_request":{"url":"https://api.github.com/repos/domoticz/domoticz/pulls/1655","id":128123170,"html_url":"https://github.com/domoticz/domoticz/pull/1655","diff_url":"https://github.com/domoticz/domoticz/pull/1655.diff","patch_url":"https://github.com/domoticz/domoticz/pull/1655.patch","issue_url":"https://api.github.com/repos/domoticz/domoticz/issues/1655","number":1655,"state":"closed","locked":false,"title":"EventSystem Lua match device and file name / disable dzVents when not used","user":{"login":"jvandenbroek","id":3118327,"avatar_url":"https://avatars3.githubusercontent.com/u/3118327?v=3","gravatar_id":"","url":"https://api.github.com/users/jvandenbroek","html_url":"https://github.com/jvandenbroek","followers_url":"https://api.github.com/users/jvandenbroek/followers","following_url":"https://api.github.com/users/jvandenbroek/following{/other_user}","gists_url":"https://api.github.com/users/jvandenbroek/gists{/gist_id}","starred_url":"https://api.github.com/users/jvandenbroek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jvandenbroek/subscriptions","organizations_url":"https://api.github.com/users/jvandenbroek/orgs","repos_url":"https://api.github.com/users/jvandenbroek/repos","events_url":"https://api.github.com/users/jvandenbroek/events{/privacy}","received_events_url":"https://api.github.com/users/jvandenbroek/received_events","type":"User","site_admin":false},"body":"To simplify things, I left the threaded part out as implemented in this pull: https://github.com/domoticz/domoticz/pull/1633\r\n\r\nThis pull is easier to read / debug, so let's do the basic implementation on file matching first. Also left out Python part completely, since I don't use Python scripts, I really don't care much (however I do believe that device name matching with Python would improve it's performance also considerably).\r\n\r\nThe introduction of dzVents made the execution of my Lua scripts really really slow, like 1 sec extra duration on each device update. I've disabled the dzVents code in EvaluateLua when dzVents is disabled, so things now run smoothly again.","created_at":"2017-06-29T10:56:49Z","updated_at":"2017-07-06T19:44:27Z","closed_at":"2017-07-02T07:50:23Z","merged_at":"2017-07-02T07:50:23Z","merge_commit_sha":"a9ad9b67bb9608ea6d2d818f44a6c14999b36f10","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/domoticz/domoticz/pulls/1655/commits","review_comments_url":"https://api.github.com/repos/domoticz/domoticz/pulls/1655/comments","review_comment_url":"https://api.github.com/repos/domoticz/domoticz/pulls/comments{/number}","comments_url":"https://api.github.com/repos/domoticz/domoticz/issues/1655/comments","statuses_url":"https://api.github.com/repos/domoticz/domoticz/statuses/dfb6d6e0fb837b5fc084cb9a42775819e81ce7fa","head":{"label":"jvandenbroek:eventsystem-file-device","ref":"eventsystem-file-device","sha":"dfb6d6e0fb837b5fc084cb9a42775819e81ce7fa","user":{"login":"jvandenbroek","id":3118327,"avatar_url":"https://avatars3.githubusercontent.com/u/3118327?v=3","gravatar_id":"","url":"https://api.github.com/users/jvandenbroek","html_url":"https://github.com/jvandenbroek","followers_url":"https://api.github.com/users/jvandenbroek/followers","following_url":"https://api.github.com/users/jvandenbroek/following{/other_user}","gists_url":"https://api.github.com/users/jvandenbroek/gists{/gist_id}","starred_url":"https://api.github.com/users/jvandenbroek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jvandenbroek/subscriptions","organizations_url":"https://api.github.com/users/jvandenbroek/orgs","repos_url":"https://api.github.com/users/jvandenbroek/repos","events_url":"https://api.github.com/users/jvandenbroek/events{/privacy}","received_events_url":"https://api.github.com/users/jvandenbroek/received_events","type":"User","site_admin":false},"repo":{"id":47962301,"name":"domoticz","full_name":"jvandenbroek/domoticz","owner":{"login":"jvandenbroek","id":3118327,"avatar_url":"https://avatars3.githubusercontent.com/u/3118327?v=3","gravatar_id":"","url":"https://api.github.com/users/jvandenbroek","html_url":"https://github.com/jvandenbroek","followers_url":"https://api.github.com/users/jvandenbroek/followers","following_url":"https://api.github.com/users/jvandenbroek/following{/other_user}","gists_url":"https://api.github.com/users/jvandenbroek/gists{/gist_id}","starred_url":"https://api.github.com/users/jvandenbroek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jvandenbroek/subscriptions","organizations_url":"https://api.github.com/users/jvandenbroek/orgs","repos_url":"https://api.github.com/users/jvandenbroek/repos","events_url":"https://api.github.com/users/jvandenbroek/events{/privacy}","received_events_url":"https://api.github.com/users/jvandenbroek/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jvandenbroek/domoticz","description":"Open source Home Automation System","fork":true,"url":"https://api.github.com/repos/jvandenbroek/domoticz","forks_url":"https://api.github.com/repos/jvandenbroek/domoticz/forks","keys_url":"https://api.github.com/repos/jvandenbroek/domoticz/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jvandenbroek/domoticz/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jvandenbroek/domoticz/teams","hooks_url":"https://api.github.com/repos/jvandenbroek/domoticz/hooks","issue_events_url":"https://api.github.com/repos/jvandenbroek/domoticz/issues/events{/number}","events_url":"https://api.github.com/repos/jvandenbroek/domoticz/events","assignees_url":"https://api.github.com/repos/jvandenbroek/domoticz/assignees{/user}","branches_url":"https://api.github.com/repos/jvandenbroek/domoticz/branches{/branch}","tags_url":"https://api.github.com/repos/jvandenbroek/domoticz/tags","blobs_url":"https://api.github.com/repos/jvandenbroek/domoticz/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jvandenbroek/domoticz/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jvandenbroek/domoticz/git/refs{/sha}","trees_url":"https://api.github.com/repos/jvandenbroek/domoticz/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jvandenbroek/domoticz/statuses/{sha}","languages_url":"https://api.github.com/repos/jvandenbroek/domoticz/languages","stargazers_url":"https://api.github.com/repos/jvandenbroek/domoticz/stargazers","contributors_url":"https://api.github.com/repos/jvandenbroek/domoticz/contributors","subscribers_url":"https://api.github.com/repos/jvandenbroek/domoticz/subscribers","subscription_url":"https://api.github.com/repos/jvandenbroek/domoticz/subscription","commits_url":"https://api.github.com/repos/jvandenbroek/domoticz/commits{/sha}","git_commits_url":"https://api.github.com/repos/jvandenbroek/domoticz/git/commits{/sha}","comments_url":"https://api.github.com/repos/jvandenbroek/domoticz/comments{/number}","issue_comment_url":"https://api.github.com/repos/jvandenbroek/domoticz/issues/comments{/number}","contents_url":"https://api.github.com/repos/jvandenbroek/domoticz/contents/{+path}","compare_url":"https://api.github.com/repos/jvandenbroek/domoticz/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jvandenbroek/domoticz/merges","archive_url":"https://api.github.com/repos/jvandenbroek/domoticz/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jvandenbroek/domoticz/downloads","issues_url":"https://api.github.com/repos/jvandenbroek/domoticz/issues{/number}","pulls_url":"https://api.github.com/repos/jvandenbroek/domoticz/pulls{/number}","milestones_url":"https://api.github.com/repos/jvandenbroek/domoticz/milestones{/number}","notifications_url":"https://api.github.com/repos/jvandenbroek/domoticz/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jvandenbroek/domoticz/labels{/name}","releases_url":"https://api.github.com/repos/jvandenbroek/domoticz/releases{/id}","deployments_url":"https://api.github.com/repos/jvandenbroek/domoticz/deployments","created_at":"2015-12-14T08:40:29Z","updated_at":"2016-01-17T22:03:34Z","pushed_at":"2017-07-06T14:39:43Z","git_url":"git://github.com/jvandenbroek/domoticz.git","ssh_url":"git@github.com:jvandenbroek/domoticz.git","clone_url":"https://github.com/jvandenbroek/domoticz.git","svn_url":"https://github.com/jvandenbroek/domoticz","homepage":"http://www.domoticz.com","size":167816,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"domoticz:master","ref":"master","sha":"37b51336d3ab8804244f9d4633c6c0594fdd7457","user":{"login":"domoticz","id":6067010,"avatar_url":"https://avatars1.githubusercontent.com/u/6067010?v=3","gravatar_id":"","url":"https://api.github.com/users/domoticz","html_url":"https://github.com/domoticz","followers_url":"https://api.github.com/users/domoticz/followers","following_url":"https://api.github.com/users/domoticz/following{/other_user}","gists_url":"https://api.github.com/users/domoticz/gists{/gist_id}","starred_url":"https://api.github.com/users/domoticz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domoticz/subscriptions","organizations_url":"https://api.github.com/users/domoticz/orgs","repos_url":"https://api.github.com/users/domoticz/repos","events_url":"https://api.github.com/users/domoticz/events{/privacy}","received_events_url":"https://api.github.com/users/domoticz/received_events","type":"Organization","site_admin":false},"repo":{"id":40759227,"name":"domoticz","full_name":"domoticz/domoticz","owner":{"login":"domoticz","id":6067010,"avatar_url":"https://avatars1.githubusercontent.com/u/6067010?v=3","gravatar_id":"","url":"https://api.github.com/users/domoticz","html_url":"https://github.com/domoticz","followers_url":"https://api.github.com/users/domoticz/followers","following_url":"https://api.github.com/users/domoticz/following{/other_user}","gists_url":"https://api.github.com/users/domoticz/gists{/gist_id}","starred_url":"https://api.github.com/users/domoticz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domoticz/subscriptions","organizations_url":"https://api.github.com/users/domoticz/orgs","repos_url":"https://api.github.com/users/domoticz/repos","events_url":"https://api.github.com/users/domoticz/events{/privacy}","received_events_url":"https://api.github.com/users/domoticz/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/domoticz/domoticz","description":"Open source Home Automation System","fork":false,"url":"https://api.github.com/repos/domoticz/domoticz","forks_url":"https://api.github.com/repos/domoticz/domoticz/forks","keys_url":"https://api.github.com/repos/domoticz/domoticz/keys{/key_id}","collaborators_url":"https://api.github.com/repos/domoticz/domoticz/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/domoticz/domoticz/teams","hooks_url":"https://api.github.com/repos/domoticz/domoticz/hooks","issue_events_url":"https://api.github.com/repos/domoticz/domoticz/issues/events{/number}","events_url":"https://api.github.com/repos/domoticz/domoticz/events","assignees_url":"https://api.github.com/repos/domoticz/domoticz/assignees{/user}","branches_url":"https://api.github.com/repos/domoticz/domoticz/branches{/branch}","tags_url":"https://api.github.com/repos/domoticz/domoticz/tags","blobs_url":"https://api.github.com/repos/domoticz/domoticz/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/domoticz/domoticz/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/domoticz/domoticz/git/refs{/sha}","trees_url":"https://api.github.com/repos/domoticz/domoticz/git/trees{/sha}","statuses_url":"https://api.github.com/repos/domoticz/domoticz/statuses/{sha}","languages_url":"https://api.github.com/repos/domoticz/domoticz/languages","stargazers_url":"https://api.github.com/repos/domoticz/domoticz/stargazers","contributors_url":"https://api.github.com/repos/domoticz/domoticz/contributors","subscribers_url":"https://api.github.com/repos/domoticz/domoticz/subscribers","subscription_url":"https://api.github.com/repos/domoticz/domoticz/subscription","commits_url":"https://api.github.com/repos/domoticz/domoticz/commits{/sha}","git_commits_url":"https://api.github.com/repos/domoticz/domoticz/git/commits{/sha}","comments_url":"https://api.github.com/repos/domoticz/domoticz/comments{/number}","issue_comment_url":"https://api.github.com/repos/domoticz/domoticz/issues/comments{/number}","contents_url":"https://api.github.com/repos/domoticz/domoticz/contents/{+path}","compare_url":"https://api.github.com/repos/domoticz/domoticz/compare/{base}...{head}","merges_url":"https://api.github.com/repos/domoticz/domoticz/merges","archive_url":"https://api.github.com/repos/domoticz/domoticz/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/domoticz/domoticz/downloads","issues_url":"https://api.github.com/repos/domoticz/domoticz/issues{/number}","pulls_url":"https://api.github.com/repos/domoticz/domoticz/pulls{/number}","milestones_url":"https://api.github.com/repos/domoticz/domoticz/milestones{/number}","notifications_url":"https://api.github.com/repos/domoticz/domoticz/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/domoticz/domoticz/labels{/name}","releases_url":"https://api.github.com/repos/domoticz/domoticz/releases{/id}","deployments_url":"https://api.github.com/repos/domoticz/domoticz/deployments","created_at":"2015-08-15T12:49:39Z","updated_at":"2017-07-06T03:07:29Z","pushed_at":"2017-07-06T10:27:02Z","git_url":"git://github.com/domoticz/domoticz.git","ssh_url":"git@github.com:domoticz/domoticz.git","clone_url":"https://github.com/domoticz/domoticz.git","svn_url":"https://github.com/domoticz/domoticz","homepage":"http://www.domoticz.com","size":301523,"stargazers_count":743,"watchers_count":743,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":454,"mirror_url":null,"open_issues_count":40,"forks":454,"open_issues":40,"watchers":743,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/domoticz/domoticz/pulls/1655"},"html":{"href":"https://github.com/domoticz/domoticz/pull/1655"},"issue":{"href":"https://api.github.com/repos/domoticz/domoticz/issues/1655"},"comments":{"href":"https://api.github.com/repos/domoticz/domoticz/issues/1655/comments"},"review_comments":{"href":"https://api.github.com/repos/domoticz/domoticz/pulls/1655/comments"},"review_comment":{"href":"https://api.github.com/repos/domoticz/domoticz/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/domoticz/domoticz/pulls/1655/commits"},"statuses":{"href":"https://api.github.com/repos/domoticz/domoticz/statuses/dfb6d6e0fb837b5fc084cb9a42775819e81ce7fa"}}}}
{"actor":{"display_login":"jvandenbroek"}}