{"action":"created","issue":{"url":"https://api.github.com/repos/clab/dynet/issues/422","repository_url":"https://api.github.com/repos/clab/dynet","labels_url":"https://api.github.com/repos/clab/dynet/issues/422/labels{/name}","comments_url":"https://api.github.com/repos/clab/dynet/issues/422/comments","events_url":"https://api.github.com/repos/clab/dynet/issues/422/events","html_url":"https://github.com/clab/dynet/pull/422","id":218957114,"number":422,"title":"Implement native serialization and deserialization logic for ParameterCollection and support partial save/load.","user":{"login":"xunzhang","id":554159,"avatar_url":"https://avatars3.githubusercontent.com/u/554159?v=3","gravatar_id":"","url":"https://api.github.com/users/xunzhang","html_url":"https://github.com/xunzhang","followers_url":"https://api.github.com/users/xunzhang/followers","following_url":"https://api.github.com/users/xunzhang/following{/other_user}","gists_url":"https://api.github.com/users/xunzhang/gists{/gist_id}","starred_url":"https://api.github.com/users/xunzhang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xunzhang/subscriptions","organizations_url":"https://api.github.com/users/xunzhang/orgs","repos_url":"https://api.github.com/users/xunzhang/repos","events_url":"https://api.github.com/users/xunzhang/events{/privacy}","received_events_url":"https://api.github.com/users/xunzhang/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2017-04-03T14:45:52Z","updated_at":"2017-04-05T22:05:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/clab/dynet/pulls/422","html_url":"https://github.com/clab/dynet/pull/422","diff_url":"https://github.com/clab/dynet/pull/422.diff","patch_url":"https://github.com/clab/dynet/pull/422.patch"},"body":"This pull request means to implement native save/load serialization and deserialization logic without Boost. https://github.com/clab/dynet/issues/230 https://github.com/clab/dynet/issues/84\r\n\r\nThere are still some commits need to be finished in this pull request.\r\n- [x] Checking existing model file to avoid confliction.\r\n- [x] Add more save and load interfaces.\r\n- [x] Refactor and add more tests.\r\n\r\nMoreover, there are still some ideas need to be discussed.\r\n1. Do we need to support save/load a single `Parameter` and `LookupParameter`? If yes, although current mechanism can also apply while some existing code(exclude pull request) need to be refactored a lot.\r\n2. Current implementation doesn't support Builder load which is supported in current version.\r\n3. Current format is text based one considering readability, it is kind of a mimic version of JSON/YAML, but this will take more space and might lose some precision."},"comment":{"url":"https://api.github.com/repos/clab/dynet/issues/comments/292011109","html_url":"https://github.com/clab/dynet/pull/422#issuecomment-292011109","issue_url":"https://api.github.com/repos/clab/dynet/issues/422","id":292011109,"user":{"login":"xunzhang","id":554159,"avatar_url":"https://avatars3.githubusercontent.com/u/554159?v=3","gravatar_id":"","url":"https://api.github.com/users/xunzhang","html_url":"https://github.com/xunzhang","followers_url":"https://api.github.com/users/xunzhang/followers","following_url":"https://api.github.com/users/xunzhang/following{/other_user}","gists_url":"https://api.github.com/users/xunzhang/gists{/gist_id}","starred_url":"https://api.github.com/users/xunzhang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xunzhang/subscriptions","organizations_url":"https://api.github.com/users/xunzhang/orgs","repos_url":"https://api.github.com/users/xunzhang/repos","events_url":"https://api.github.com/users/xunzhang/events{/privacy}","received_events_url":"https://api.github.com/users/xunzhang/received_events","type":"User","site_admin":false},"created_at":"2017-04-05T22:05:30Z","updated_at":"2017-04-05T22:05:30Z","body":"@pmichel31415 Hi, the order of doing python binding and support Parameters in my last comment depends on the engineering effort I think. Both of them have high priority in our next release(v1.1)."}}
{"actor":{"display_login":"xunzhang"}}