{"action":"created","comment":{"url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/pulls/comments/120701215","pull_request_review_id":42686597,"id":120701215,"diff_hunk":"@@ -12,7 +12,7 @@ const Knowledge = imports.app.knowledge;\n const Module = imports.app.interfaces.module;\n const Utils = imports.app.utils;\n \n-const SPACING_MAX = 50;\n+const SPACING_MAX = 0;","path":"js/app/modules/arrangement/sideBySide.js","position":5,"original_position":5,"commit_id":"cf61240e943c5d7c06c57ce471a4f3e9895b08ee","original_commit_id":"cf61240e943c5d7c06c57ce471a4f3e9895b08ee","user":{"login":"xjuan","id":17505171,"avatar_url":"https://avatars3.githubusercontent.com/u/17505171?v=3","gravatar_id":"","url":"https://api.github.com/users/xjuan","html_url":"https://github.com/xjuan","followers_url":"https://api.github.com/users/xjuan/followers","following_url":"https://api.github.com/users/xjuan/following{/other_user}","gists_url":"https://api.github.com/users/xjuan/gists{/gist_id}","starred_url":"https://api.github.com/users/xjuan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xjuan/subscriptions","organizations_url":"https://api.github.com/users/xjuan/orgs","repos_url":"https://api.github.com/users/xjuan/repos","events_url":"https://api.github.com/users/xjuan/events{/privacy}","received_events_url":"https://api.github.com/users/xjuan/received_events","type":"User","site_admin":false},"body":"OK, I am asking because a good chunk of the work I did on the topbar was to have that responsive spacing between cards. I wish I knew beforehand :D\r\nSo, I think the ideal thing would be to replace that constant with a property with a default of 0, let me know if you want me to do it","created_at":"2017-06-07T18:03:33Z","updated_at":"2017-06-07T18:03:33Z","html_url":"https://github.com/endlessm/eos-knowledge-lib/pull/1447#discussion_r120701215","pull_request_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/pulls/1447","_links":{"self":{"href":"https://api.github.com/repos/endlessm/eos-knowledge-lib/pulls/comments/120701215"},"html":{"href":"https://github.com/endlessm/eos-knowledge-lib/pull/1447#discussion_r120701215"},"pull_request":{"href":"https://api.github.com/repos/endlessm/eos-knowledge-lib/pulls/1447"}}},"pull_request":{"url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/pulls/1447","id":124088936,"html_url":"https://github.com/endlessm/eos-knowledge-lib/pull/1447","diff_url":"https://github.com/endlessm/eos-knowledge-lib/pull/1447.diff","patch_url":"https://github.com/endlessm/eos-knowledge-lib/pull/1447.patch","issue_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/issues/1447","number":1447,"state":"open","locked":false,"title":"Refactoring some News CSS & YAML","user":{"login":"katelk28","id":6823252,"avatar_url":"https://avatars0.githubusercontent.com/u/6823252?v=3","gravatar_id":"","url":"https://api.github.com/users/katelk28","html_url":"https://github.com/katelk28","followers_url":"https://api.github.com/users/katelk28/followers","following_url":"https://api.github.com/users/katelk28/following{/other_user}","gists_url":"https://api.github.com/users/katelk28/gists{/gist_id}","starred_url":"https://api.github.com/users/katelk28/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/katelk28/subscriptions","organizations_url":"https://api.github.com/users/katelk28/orgs","repos_url":"https://api.github.com/users/katelk28/repos","events_url":"https://api.github.com/users/katelk28/events{/privacy}","received_events_url":"https://api.github.com/users/katelk28/received_events","type":"User","site_admin":false},"body":"Some extra CSS removal from the News template that is not necessary on the template level.\r\n- Deleted CSS having to do with text-transform, color, and some margin on content groups that\r\n  should inherit from other content group styling\r\n- Moved .ContentGroup--outercontainer upward in code for readability\r\n- Combined CSS for .ContentGroup--complementarycontent and .LayoutResponsiveMargins--complementarycontent\r\n- Changed trigger text to \"More news from ....\"\r\n\r\nAnd, some default theme design QA on the Layout.TopMenu and its new dropdown menu for news template\r\n\r\nhttps://phabricator.endlessm.com/T17424","created_at":"2017-06-06T00:42:47Z","updated_at":"2017-06-07T18:03:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fe5ef95f9f15cd3f9be4c84350d0334f14e4db0b","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/pulls/1447/commits","review_comments_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/pulls/1447/comments","review_comment_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/issues/1447/comments","statuses_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/statuses/cf61240e943c5d7c06c57ce471a4f3e9895b08ee","head":{"label":"endlessm:T17424","ref":"T17424","sha":"cf61240e943c5d7c06c57ce471a4f3e9895b08ee","user":{"login":"endlessm","id":1930958,"avatar_url":"https://avatars2.githubusercontent.com/u/1930958?v=3","gravatar_id":"","url":"https://api.github.com/users/endlessm","html_url":"https://github.com/endlessm","followers_url":"https://api.github.com/users/endlessm/followers","following_url":"https://api.github.com/users/endlessm/following{/other_user}","gists_url":"https://api.github.com/users/endlessm/gists{/gist_id}","starred_url":"https://api.github.com/users/endlessm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endlessm/subscriptions","organizations_url":"https://api.github.com/users/endlessm/orgs","repos_url":"https://api.github.com/users/endlessm/repos","events_url":"https://api.github.com/users/endlessm/events{/privacy}","received_events_url":"https://api.github.com/users/endlessm/received_events","type":"Organization","site_admin":false},"repo":{"id":18152801,"name":"eos-knowledge-lib","full_name":"endlessm/eos-knowledge-lib","owner":{"login":"endlessm","id":1930958,"avatar_url":"https://avatars2.githubusercontent.com/u/1930958?v=3","gravatar_id":"","url":"https://api.github.com/users/endlessm","html_url":"https://github.com/endlessm","followers_url":"https://api.github.com/users/endlessm/followers","following_url":"https://api.github.com/users/endlessm/following{/other_user}","gists_url":"https://api.github.com/users/endlessm/gists{/gist_id}","starred_url":"https://api.github.com/users/endlessm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endlessm/subscriptions","organizations_url":"https://api.github.com/users/endlessm/orgs","repos_url":"https://api.github.com/users/endlessm/repos","events_url":"https://api.github.com/users/endlessm/events{/privacy}","received_events_url":"https://api.github.com/users/endlessm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/endlessm/eos-knowledge-lib","description":"GUI library for knowledge apps","fork":false,"url":"https://api.github.com/repos/endlessm/eos-knowledge-lib","forks_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/forks","keys_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/teams","hooks_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/hooks","issue_events_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/issues/events{/number}","events_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/events","assignees_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/assignees{/user}","branches_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/branches{/branch}","tags_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/tags","blobs_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/git/refs{/sha}","trees_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/statuses/{sha}","languages_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/languages","stargazers_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/stargazers","contributors_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/contributors","subscribers_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/subscribers","subscription_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/subscription","commits_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/commits{/sha}","git_commits_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/git/commits{/sha}","comments_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/comments{/number}","issue_comment_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/issues/comments{/number}","contents_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/contents/{+path}","compare_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/merges","archive_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/downloads","issues_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/issues{/number}","pulls_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/pulls{/number}","milestones_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/milestones{/number}","notifications_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/labels{/name}","releases_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/releases{/id}","deployments_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/deployments","created_at":"2014-03-26T20:28:39Z","updated_at":"2017-04-01T21:06:15Z","pushed_at":"2017-06-07T16:25:23Z","git_url":"git://github.com/endlessm/eos-knowledge-lib.git","ssh_url":"git@github.com:endlessm/eos-knowledge-lib.git","clone_url":"https://github.com/endlessm/eos-knowledge-lib.git","svn_url":"https://github.com/endlessm/eos-knowledge-lib","homepage":null,"size":38704,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":3,"mirror_url":null,"open_issues_count":15,"forks":3,"open_issues":15,"watchers":6,"default_branch":"master"}},"base":{"label":"endlessm:master","ref":"master","sha":"14d642898d4ef4e06c94855c80bc9263eb35b318","user":{"login":"endlessm","id":1930958,"avatar_url":"https://avatars2.githubusercontent.com/u/1930958?v=3","gravatar_id":"","url":"https://api.github.com/users/endlessm","html_url":"https://github.com/endlessm","followers_url":"https://api.github.com/users/endlessm/followers","following_url":"https://api.github.com/users/endlessm/following{/other_user}","gists_url":"https://api.github.com/users/endlessm/gists{/gist_id}","starred_url":"https://api.github.com/users/endlessm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endlessm/subscriptions","organizations_url":"https://api.github.com/users/endlessm/orgs","repos_url":"https://api.github.com/users/endlessm/repos","events_url":"https://api.github.com/users/endlessm/events{/privacy}","received_events_url":"https://api.github.com/users/endlessm/received_events","type":"Organization","site_admin":false},"repo":{"id":18152801,"name":"eos-knowledge-lib","full_name":"endlessm/eos-knowledge-lib","owner":{"login":"endlessm","id":1930958,"avatar_url":"https://avatars2.githubusercontent.com/u/1930958?v=3","gravatar_id":"","url":"https://api.github.com/users/endlessm","html_url":"https://github.com/endlessm","followers_url":"https://api.github.com/users/endlessm/followers","following_url":"https://api.github.com/users/endlessm/following{/other_user}","gists_url":"https://api.github.com/users/endlessm/gists{/gist_id}","starred_url":"https://api.github.com/users/endlessm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endlessm/subscriptions","organizations_url":"https://api.github.com/users/endlessm/orgs","repos_url":"https://api.github.com/users/endlessm/repos","events_url":"https://api.github.com/users/endlessm/events{/privacy}","received_events_url":"https://api.github.com/users/endlessm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/endlessm/eos-knowledge-lib","description":"GUI library for knowledge apps","fork":false,"url":"https://api.github.com/repos/endlessm/eos-knowledge-lib","forks_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/forks","keys_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/teams","hooks_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/hooks","issue_events_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/issues/events{/number}","events_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/events","assignees_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/assignees{/user}","branches_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/branches{/branch}","tags_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/tags","blobs_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/git/refs{/sha}","trees_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/statuses/{sha}","languages_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/languages","stargazers_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/stargazers","contributors_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/contributors","subscribers_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/subscribers","subscription_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/subscription","commits_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/commits{/sha}","git_commits_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/git/commits{/sha}","comments_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/comments{/number}","issue_comment_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/issues/comments{/number}","contents_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/contents/{+path}","compare_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/merges","archive_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/downloads","issues_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/issues{/number}","pulls_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/pulls{/number}","milestones_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/milestones{/number}","notifications_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/labels{/name}","releases_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/releases{/id}","deployments_url":"https://api.github.com/repos/endlessm/eos-knowledge-lib/deployments","created_at":"2014-03-26T20:28:39Z","updated_at":"2017-04-01T21:06:15Z","pushed_at":"2017-06-07T16:25:23Z","git_url":"git://github.com/endlessm/eos-knowledge-lib.git","ssh_url":"git@github.com:endlessm/eos-knowledge-lib.git","clone_url":"https://github.com/endlessm/eos-knowledge-lib.git","svn_url":"https://github.com/endlessm/eos-knowledge-lib","homepage":null,"size":38704,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":3,"mirror_url":null,"open_issues_count":15,"forks":3,"open_issues":15,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/endlessm/eos-knowledge-lib/pulls/1447"},"html":{"href":"https://github.com/endlessm/eos-knowledge-lib/pull/1447"},"issue":{"href":"https://api.github.com/repos/endlessm/eos-knowledge-lib/issues/1447"},"comments":{"href":"https://api.github.com/repos/endlessm/eos-knowledge-lib/issues/1447/comments"},"review_comments":{"href":"https://api.github.com/repos/endlessm/eos-knowledge-lib/pulls/1447/comments"},"review_comment":{"href":"https://api.github.com/repos/endlessm/eos-knowledge-lib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/endlessm/eos-knowledge-lib/pulls/1447/commits"},"statuses":{"href":"https://api.github.com/repos/endlessm/eos-knowledge-lib/statuses/cf61240e943c5d7c06c57ce471a4f3e9895b08ee"}}}}
{"actor":{"display_login":"xjuan"}}