{"action":"created","comment":{"url":"https://api.github.com/repos/vedo98/VedadProjekat/pulls/comments/144000170","pull_request_review_id":68592894,"id":144000170,"diff_hunk":"@@ -82,31 +95,46 @@ public void onResponse(Call<ActorModel> call, Response<ActorModel> response) {\n                 if (response.isSuccessful()) {\n                     mActorDetailsLayout.setVisibility(View.VISIBLE);\n                     mDataSet = response.body();\n-                    String imageUrl = IMAGE_BASE_URL + \"h632\" + mDataSet.getProfilePath();\n-                    Glide.with(getApplicationContext())\n+\n+                    String imageUrl = null;\n+                    if(mDataSet.getProfilePath() != null && !mDataSet.getProfilePath().isEmpty()){\n+                        imageUrl = IMAGE_BASE_URL + \"h632\" + mDataSet.getProfilePath();\n+                    }\n+                    Glide.with(ActorActivity.this)\n                             .load(imageUrl)\n                             .centerCrop()\n                             .into(actorPictureImageView);\n \n-                    actorNameTextView.setText(mDataSet.getName());\n+                    if(mDataSet.getName() != null && !mDataSet.getName().isEmpty())\n+                        actorNameTextView.setText(mDataSet.getName());\n+                    else\n+                        actorNameTextView.setVisibility(View.GONE);\n                     String birthdayFormated;\n-                    if(mDataSet.getBirthday() != null && mDataSet.getPlaceOfBirth() != null){\n+                    if ((mDataSet.getBirthday() != null && !mDataSet.getBirthday().isEmpty()) && (mDataSet.getPlaceOfBirth() != null && !mDataSet.getPlaceOfBirth().isEmpty())) {\n                         birthdayFormated = DateUtils.returnMonth(mDataSet.getBirthday());\n                         actorBirthdayPlaceTextView.setText(birthdayFormated + \", \" + mDataSet.getPlaceOfBirth());\n-                    }\n-                    else if(mDataSet.getBirthday() != null){\n+                    } else if (mDataSet.getBirthday() != null && !mDataSet.getBirthday().isEmpty()) {\n                         birthdayFormated = DateUtils.returnMonth(mDataSet.getBirthday());\n                         actorBirthdayPlaceTextView.setText(birthdayFormated);\n+                    } else {\n+                        dateOfBirthLayout.setVisibility(View.GONE);\n                     }\n-                    else{\n-                        actorBirthdayPlaceTextView.setText(mDataSet.getPlaceOfBirth());\n-                    }\n-                    if(mDataSet.getHomepage() != null) actorWebsiteTextView.setText(mDataSet.getHomepage());\n-                    else actorWebsiteTextView.setText(\"N/A\");\n-//                    actorWebsiteTextView.setText(mDataSet.g);\n-                    actorBiographyTextView.setText(mDataSet.getBiography());\n-\n-                    actorFilmographyRecyclerView.setAdapter(new FilmographyGalleryAdapter(mDataSet.getCombinedCredits().getCastList(), getApplicationContext()));\n+                    if (mDataSet.getHomepage() != null && !mDataSet.getHomepage().isEmpty())","path":"app/src/main/java/com/albosdevelopment/moviesdatabase/activity/ActorActivity.java","position":94,"original_position":94,"commit_id":"d864eef30c1282d43a0249bc036b2c26cd8c11ad","original_commit_id":"d864eef30c1282d43a0249bc036b2c26cd8c11ad","user":{"login":"adipr","id":20042614,"avatar_url":"https://avatars1.githubusercontent.com/u/20042614?v=4","gravatar_id":"","url":"https://api.github.com/users/adipr","html_url":"https://github.com/adipr","followers_url":"https://api.github.com/users/adipr/followers","following_url":"https://api.github.com/users/adipr/following{/other_user}","gists_url":"https://api.github.com/users/adipr/gists{/gist_id}","starred_url":"https://api.github.com/users/adipr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adipr/subscriptions","organizations_url":"https://api.github.com/users/adipr/orgs","repos_url":"https://api.github.com/users/adipr/repos","events_url":"https://api.github.com/users/adipr/events{/privacy}","received_events_url":"https://api.github.com/users/adipr/received_events","type":"User","site_admin":false},"body":"For if else add {}","created_at":"2017-10-11T12:50:28Z","updated_at":"2017-10-11T12:50:28Z","html_url":"https://github.com/vedo98/VedadProjekat/pull/8#discussion_r144000170","pull_request_url":"https://api.github.com/repos/vedo98/VedadProjekat/pulls/8","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/vedo98/VedadProjekat/pulls/comments/144000170"},"html":{"href":"https://github.com/vedo98/VedadProjekat/pull/8#discussion_r144000170"},"pull_request":{"href":"https://api.github.com/repos/vedo98/VedadProjekat/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/vedo98/VedadProjekat/pulls/8","id":145816615,"html_url":"https://github.com/vedo98/VedadProjekat/pull/8","diff_url":"https://github.com/vedo98/VedadProjekat/pull/8.diff","patch_url":"https://github.com/vedo98/VedadProjekat/pull/8.patch","issue_url":"https://api.github.com/repos/vedo98/VedadProjekat/issues/8","number":8,"state":"open","locked":false,"title":"Search options","user":{"login":"vedo98","id":25328905,"avatar_url":"https://avatars2.githubusercontent.com/u/25328905?v=4","gravatar_id":"","url":"https://api.github.com/users/vedo98","html_url":"https://github.com/vedo98","followers_url":"https://api.github.com/users/vedo98/followers","following_url":"https://api.github.com/users/vedo98/following{/other_user}","gists_url":"https://api.github.com/users/vedo98/gists{/gist_id}","starred_url":"https://api.github.com/users/vedo98/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vedo98/subscriptions","organizations_url":"https://api.github.com/users/vedo98/orgs","repos_url":"https://api.github.com/users/vedo98/repos","events_url":"https://api.github.com/users/vedo98/events{/privacy}","received_events_url":"https://api.github.com/users/vedo98/received_events","type":"User","site_admin":false},"body":"-search is partually implemented;\r\n-pagination is fixed up;\r\n-worst cases are handled(i.e. when \"director\" is not available etc.);\r\n-progress bars are added in whole app to show that items are loading;\r\n-progress bar added on the end when pagination is occuring;\r\n-gradle versions are fixed up;\r\n-icons are partually fixed;\r\n-strings are extracted to constants;\r\n-toolbars in \"galleryScreenSlidePagerActivity\" and \"GalleryActivity\" are replaced with text views;\r\n-LOT OF OTHER FIXES ARE ADDED;\r\nNOTE: \"I will fix up icons in next push\"\r\nNOTE: \"Some things like showing/hiding some informations in layout are arranged by my opinion, on example I hide whole \"Date of birth\" layout in actor activity if there is no informations at all and if there is only place of birth. I can chanhe it on request without any problems\" :)","created_at":"2017-10-10T22:26:54Z","updated_at":"2017-10-11T12:50:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"36c543f68655371b8362e743a194489d7de5df46","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/vedo98/VedadProjekat/pulls/8/commits","review_comments_url":"https://api.github.com/repos/vedo98/VedadProjekat/pulls/8/comments","review_comment_url":"https://api.github.com/repos/vedo98/VedadProjekat/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vedo98/VedadProjekat/issues/8/comments","statuses_url":"https://api.github.com/repos/vedo98/VedadProjekat/statuses/d864eef30c1282d43a0249bc036b2c26cd8c11ad","head":{"label":"vedo98:search_options","ref":"search_options","sha":"d864eef30c1282d43a0249bc036b2c26cd8c11ad","user":{"login":"vedo98","id":25328905,"avatar_url":"https://avatars2.githubusercontent.com/u/25328905?v=4","gravatar_id":"","url":"https://api.github.com/users/vedo98","html_url":"https://github.com/vedo98","followers_url":"https://api.github.com/users/vedo98/followers","following_url":"https://api.github.com/users/vedo98/following{/other_user}","gists_url":"https://api.github.com/users/vedo98/gists{/gist_id}","starred_url":"https://api.github.com/users/vedo98/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vedo98/subscriptions","organizations_url":"https://api.github.com/users/vedo98/orgs","repos_url":"https://api.github.com/users/vedo98/repos","events_url":"https://api.github.com/users/vedo98/events{/privacy}","received_events_url":"https://api.github.com/users/vedo98/received_events","type":"User","site_admin":false},"repo":{"id":104798715,"name":"VedadProjekat","full_name":"vedo98/VedadProjekat","owner":{"login":"vedo98","id":25328905,"avatar_url":"https://avatars2.githubusercontent.com/u/25328905?v=4","gravatar_id":"","url":"https://api.github.com/users/vedo98","html_url":"https://github.com/vedo98","followers_url":"https://api.github.com/users/vedo98/followers","following_url":"https://api.github.com/users/vedo98/following{/other_user}","gists_url":"https://api.github.com/users/vedo98/gists{/gist_id}","starred_url":"https://api.github.com/users/vedo98/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vedo98/subscriptions","organizations_url":"https://api.github.com/users/vedo98/orgs","repos_url":"https://api.github.com/users/vedo98/repos","events_url":"https://api.github.com/users/vedo98/events{/privacy}","received_events_url":"https://api.github.com/users/vedo98/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vedo98/VedadProjekat","description":null,"fork":false,"url":"https://api.github.com/repos/vedo98/VedadProjekat","forks_url":"https://api.github.com/repos/vedo98/VedadProjekat/forks","keys_url":"https://api.github.com/repos/vedo98/VedadProjekat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vedo98/VedadProjekat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vedo98/VedadProjekat/teams","hooks_url":"https://api.github.com/repos/vedo98/VedadProjekat/hooks","issue_events_url":"https://api.github.com/repos/vedo98/VedadProjekat/issues/events{/number}","events_url":"https://api.github.com/repos/vedo98/VedadProjekat/events","assignees_url":"https://api.github.com/repos/vedo98/VedadProjekat/assignees{/user}","branches_url":"https://api.github.com/repos/vedo98/VedadProjekat/branches{/branch}","tags_url":"https://api.github.com/repos/vedo98/VedadProjekat/tags","blobs_url":"https://api.github.com/repos/vedo98/VedadProjekat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vedo98/VedadProjekat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vedo98/VedadProjekat/git/refs{/sha}","trees_url":"https://api.github.com/repos/vedo98/VedadProjekat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vedo98/VedadProjekat/statuses/{sha}","languages_url":"https://api.github.com/repos/vedo98/VedadProjekat/languages","stargazers_url":"https://api.github.com/repos/vedo98/VedadProjekat/stargazers","contributors_url":"https://api.github.com/repos/vedo98/VedadProjekat/contributors","subscribers_url":"https://api.github.com/repos/vedo98/VedadProjekat/subscribers","subscription_url":"https://api.github.com/repos/vedo98/VedadProjekat/subscription","commits_url":"https://api.github.com/repos/vedo98/VedadProjekat/commits{/sha}","git_commits_url":"https://api.github.com/repos/vedo98/VedadProjekat/git/commits{/sha}","comments_url":"https://api.github.com/repos/vedo98/VedadProjekat/comments{/number}","issue_comment_url":"https://api.github.com/repos/vedo98/VedadProjekat/issues/comments{/number}","contents_url":"https://api.github.com/repos/vedo98/VedadProjekat/contents/{+path}","compare_url":"https://api.github.com/repos/vedo98/VedadProjekat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vedo98/VedadProjekat/merges","archive_url":"https://api.github.com/repos/vedo98/VedadProjekat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vedo98/VedadProjekat/downloads","issues_url":"https://api.github.com/repos/vedo98/VedadProjekat/issues{/number}","pulls_url":"https://api.github.com/repos/vedo98/VedadProjekat/pulls{/number}","milestones_url":"https://api.github.com/repos/vedo98/VedadProjekat/milestones{/number}","notifications_url":"https://api.github.com/repos/vedo98/VedadProjekat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vedo98/VedadProjekat/labels{/name}","releases_url":"https://api.github.com/repos/vedo98/VedadProjekat/releases{/id}","deployments_url":"https://api.github.com/repos/vedo98/VedadProjekat/deployments","created_at":"2017-09-25T20:27:48Z","updated_at":"2017-09-25T20:28:23Z","pushed_at":"2017-10-10T22:26:55Z","git_url":"git://github.com/vedo98/VedadProjekat.git","ssh_url":"git@github.com:vedo98/VedadProjekat.git","clone_url":"https://github.com/vedo98/VedadProjekat.git","svn_url":"https://github.com/vedo98/VedadProjekat","homepage":null,"size":749,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"vedo98:master","ref":"master","sha":"0b7ce13f1151d505c7a01c9f4151bd27ba1dbdb7","user":{"login":"vedo98","id":25328905,"avatar_url":"https://avatars2.githubusercontent.com/u/25328905?v=4","gravatar_id":"","url":"https://api.github.com/users/vedo98","html_url":"https://github.com/vedo98","followers_url":"https://api.github.com/users/vedo98/followers","following_url":"https://api.github.com/users/vedo98/following{/other_user}","gists_url":"https://api.github.com/users/vedo98/gists{/gist_id}","starred_url":"https://api.github.com/users/vedo98/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vedo98/subscriptions","organizations_url":"https://api.github.com/users/vedo98/orgs","repos_url":"https://api.github.com/users/vedo98/repos","events_url":"https://api.github.com/users/vedo98/events{/privacy}","received_events_url":"https://api.github.com/users/vedo98/received_events","type":"User","site_admin":false},"repo":{"id":104798715,"name":"VedadProjekat","full_name":"vedo98/VedadProjekat","owner":{"login":"vedo98","id":25328905,"avatar_url":"https://avatars2.githubusercontent.com/u/25328905?v=4","gravatar_id":"","url":"https://api.github.com/users/vedo98","html_url":"https://github.com/vedo98","followers_url":"https://api.github.com/users/vedo98/followers","following_url":"https://api.github.com/users/vedo98/following{/other_user}","gists_url":"https://api.github.com/users/vedo98/gists{/gist_id}","starred_url":"https://api.github.com/users/vedo98/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vedo98/subscriptions","organizations_url":"https://api.github.com/users/vedo98/orgs","repos_url":"https://api.github.com/users/vedo98/repos","events_url":"https://api.github.com/users/vedo98/events{/privacy}","received_events_url":"https://api.github.com/users/vedo98/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vedo98/VedadProjekat","description":null,"fork":false,"url":"https://api.github.com/repos/vedo98/VedadProjekat","forks_url":"https://api.github.com/repos/vedo98/VedadProjekat/forks","keys_url":"https://api.github.com/repos/vedo98/VedadProjekat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vedo98/VedadProjekat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vedo98/VedadProjekat/teams","hooks_url":"https://api.github.com/repos/vedo98/VedadProjekat/hooks","issue_events_url":"https://api.github.com/repos/vedo98/VedadProjekat/issues/events{/number}","events_url":"https://api.github.com/repos/vedo98/VedadProjekat/events","assignees_url":"https://api.github.com/repos/vedo98/VedadProjekat/assignees{/user}","branches_url":"https://api.github.com/repos/vedo98/VedadProjekat/branches{/branch}","tags_url":"https://api.github.com/repos/vedo98/VedadProjekat/tags","blobs_url":"https://api.github.com/repos/vedo98/VedadProjekat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vedo98/VedadProjekat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vedo98/VedadProjekat/git/refs{/sha}","trees_url":"https://api.github.com/repos/vedo98/VedadProjekat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vedo98/VedadProjekat/statuses/{sha}","languages_url":"https://api.github.com/repos/vedo98/VedadProjekat/languages","stargazers_url":"https://api.github.com/repos/vedo98/VedadProjekat/stargazers","contributors_url":"https://api.github.com/repos/vedo98/VedadProjekat/contributors","subscribers_url":"https://api.github.com/repos/vedo98/VedadProjekat/subscribers","subscription_url":"https://api.github.com/repos/vedo98/VedadProjekat/subscription","commits_url":"https://api.github.com/repos/vedo98/VedadProjekat/commits{/sha}","git_commits_url":"https://api.github.com/repos/vedo98/VedadProjekat/git/commits{/sha}","comments_url":"https://api.github.com/repos/vedo98/VedadProjekat/comments{/number}","issue_comment_url":"https://api.github.com/repos/vedo98/VedadProjekat/issues/comments{/number}","contents_url":"https://api.github.com/repos/vedo98/VedadProjekat/contents/{+path}","compare_url":"https://api.github.com/repos/vedo98/VedadProjekat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vedo98/VedadProjekat/merges","archive_url":"https://api.github.com/repos/vedo98/VedadProjekat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vedo98/VedadProjekat/downloads","issues_url":"https://api.github.com/repos/vedo98/VedadProjekat/issues{/number}","pulls_url":"https://api.github.com/repos/vedo98/VedadProjekat/pulls{/number}","milestones_url":"https://api.github.com/repos/vedo98/VedadProjekat/milestones{/number}","notifications_url":"https://api.github.com/repos/vedo98/VedadProjekat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vedo98/VedadProjekat/labels{/name}","releases_url":"https://api.github.com/repos/vedo98/VedadProjekat/releases{/id}","deployments_url":"https://api.github.com/repos/vedo98/VedadProjekat/deployments","created_at":"2017-09-25T20:27:48Z","updated_at":"2017-09-25T20:28:23Z","pushed_at":"2017-10-10T22:26:55Z","git_url":"git://github.com/vedo98/VedadProjekat.git","ssh_url":"git@github.com:vedo98/VedadProjekat.git","clone_url":"https://github.com/vedo98/VedadProjekat.git","svn_url":"https://github.com/vedo98/VedadProjekat","homepage":null,"size":749,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vedo98/VedadProjekat/pulls/8"},"html":{"href":"https://github.com/vedo98/VedadProjekat/pull/8"},"issue":{"href":"https://api.github.com/repos/vedo98/VedadProjekat/issues/8"},"comments":{"href":"https://api.github.com/repos/vedo98/VedadProjekat/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/vedo98/VedadProjekat/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/vedo98/VedadProjekat/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vedo98/VedadProjekat/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/vedo98/VedadProjekat/statuses/d864eef30c1282d43a0249bc036b2c26cd8c11ad"}},"author_association":"OWNER"}}
{"actor":{"display_login":"adipr"}}