{"action":"created","comment":{"url":"https://api.github.com/repos/prometheus/prometheus/pulls/comments/115683053","pull_request_review_id":37241193,"id":115683053,"diff_hunk":"@@ -25,6 +25,7 @@ import (\n \t\"sync\"\n \t\"time\"\n \n+\t\"github.com/blang/semver\"","path":"documentation/examples/remote_storage/remote_storage_adapter/main.go","position":4,"original_position":4,"commit_id":"d91689580364f3f8d03cd4446d202d25508ddc09","original_commit_id":"d91689580364f3f8d03cd4446d202d25508ddc09","user":{"login":"brian-brazil","id":7115638,"avatar_url":"https://avatars3.githubusercontent.com/u/7115638?v=3","gravatar_id":"","url":"https://api.github.com/users/brian-brazil","html_url":"https://github.com/brian-brazil","followers_url":"https://api.github.com/users/brian-brazil/followers","following_url":"https://api.github.com/users/brian-brazil/following{/other_user}","gists_url":"https://api.github.com/users/brian-brazil/gists{/gist_id}","starred_url":"https://api.github.com/users/brian-brazil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brian-brazil/subscriptions","organizations_url":"https://api.github.com/users/brian-brazil/orgs","repos_url":"https://api.github.com/users/brian-brazil/repos","events_url":"https://api.github.com/users/brian-brazil/events{/privacy}","received_events_url":"https://api.github.com/users/brian-brazil/received_events","type":"User","site_admin":false},"body":"I think it's something to make clear with the 1.7 release, we could time submission accordingly.\r\n\r\nThe other adapter in this repo also needs changing.","created_at":"2017-05-10T08:33:22Z","updated_at":"2017-05-10T08:33:22Z","html_url":"https://github.com/prometheus/prometheus/pull/2696#discussion_r115683053","pull_request_url":"https://api.github.com/repos/prometheus/prometheus/pulls/2696","_links":{"self":{"href":"https://api.github.com/repos/prometheus/prometheus/pulls/comments/115683053"},"html":{"href":"https://github.com/prometheus/prometheus/pull/2696#discussion_r115683053"},"pull_request":{"href":"https://api.github.com/repos/prometheus/prometheus/pulls/2696"}}},"pull_request":{"url":"https://api.github.com/repos/prometheus/prometheus/pulls/2696","id":119653908,"html_url":"https://github.com/prometheus/prometheus/pull/2696","diff_url":"https://github.com/prometheus/prometheus/pull/2696.diff","patch_url":"https://github.com/prometheus/prometheus/pull/2696.patch","issue_url":"https://api.github.com/repos/prometheus/prometheus/issues/2696","number":2696,"state":"open","locked":false,"title":"Compress remote storage requests and responses with unframed/raw snappy.","user":{"login":"tomwilkie","id":444037,"avatar_url":"https://avatars2.githubusercontent.com/u/444037?v=3","gravatar_id":"","url":"https://api.github.com/users/tomwilkie","html_url":"https://github.com/tomwilkie","followers_url":"https://api.github.com/users/tomwilkie/followers","following_url":"https://api.github.com/users/tomwilkie/following{/other_user}","gists_url":"https://api.github.com/users/tomwilkie/gists{/gist_id}","starred_url":"https://api.github.com/users/tomwilkie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomwilkie/subscriptions","organizations_url":"https://api.github.com/users/tomwilkie/orgs","repos_url":"https://api.github.com/users/tomwilkie/repos","events_url":"https://api.github.com/users/tomwilkie/events{/privacy}","received_events_url":"https://api.github.com/users/tomwilkie/received_events","type":"User","site_admin":false},"body":"For compatibility with other languages.  Fixes #2692.\r\n\r\nIt turns out snappy framing is not part of the standard, so the use of `snappy.New{Reader,Writer}` makes Prometheus remote storage APIs hard to consume in other languages.\r\n\r\nThis change:\r\n- Makes Prometheus use `snappy.{Encode,Decode}`, which should work across languages (confirmed here: https://github.com/weaveworks-experiments/prometheus-benchmarks/tree/master/cmd/snappy). \r\n- Bumps the `X-Prometheus-Remote-{Read,Write}-Version` headers from `0.0.1` to `0.1.0`, to allow existing implementations to detect the change (*cough* Cortex *cough*)\r\n- Update the example remote storage adapter so it can accept both encodings and return the correctly encoded response to older Prometheus'.\r\n- Makes the remote storage adapter return the `Content-Encoding: snappy` header for read responses.\r\n\r\nI haven't made the response side of read requests backwards compatible in the Prometheus code - I reasoned that people running bleeding edge Prometheus can probably run bleeding edge storage adapter.  This means new Prometheus will fail to talk to old storage adapter for reads, buts thats the case anyway, as they won't understand the raw snappy encoding.","created_at":"2017-05-09T12:59:15Z","updated_at":"2017-05-10T08:33:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7e989324389c2de0985e220fe114917ba9b2a55c","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/prometheus/prometheus/pulls/2696/commits","review_comments_url":"https://api.github.com/repos/prometheus/prometheus/pulls/2696/comments","review_comment_url":"https://api.github.com/repos/prometheus/prometheus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/prometheus/prometheus/issues/2696/comments","statuses_url":"https://api.github.com/repos/prometheus/prometheus/statuses/d91689580364f3f8d03cd4446d202d25508ddc09","head":{"label":"tomwilkie:2692-no-snappy-framing","ref":"2692-no-snappy-framing","sha":"d91689580364f3f8d03cd4446d202d25508ddc09","user":{"login":"tomwilkie","id":444037,"avatar_url":"https://avatars2.githubusercontent.com/u/444037?v=3","gravatar_id":"","url":"https://api.github.com/users/tomwilkie","html_url":"https://github.com/tomwilkie","followers_url":"https://api.github.com/users/tomwilkie/followers","following_url":"https://api.github.com/users/tomwilkie/following{/other_user}","gists_url":"https://api.github.com/users/tomwilkie/gists{/gist_id}","starred_url":"https://api.github.com/users/tomwilkie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomwilkie/subscriptions","organizations_url":"https://api.github.com/users/tomwilkie/orgs","repos_url":"https://api.github.com/users/tomwilkie/repos","events_url":"https://api.github.com/users/tomwilkie/events{/privacy}","received_events_url":"https://api.github.com/users/tomwilkie/received_events","type":"User","site_admin":false},"repo":{"id":61650324,"name":"prometheus","full_name":"tomwilkie/prometheus","owner":{"login":"tomwilkie","id":444037,"avatar_url":"https://avatars2.githubusercontent.com/u/444037?v=3","gravatar_id":"","url":"https://api.github.com/users/tomwilkie","html_url":"https://github.com/tomwilkie","followers_url":"https://api.github.com/users/tomwilkie/followers","following_url":"https://api.github.com/users/tomwilkie/following{/other_user}","gists_url":"https://api.github.com/users/tomwilkie/gists{/gist_id}","starred_url":"https://api.github.com/users/tomwilkie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomwilkie/subscriptions","organizations_url":"https://api.github.com/users/tomwilkie/orgs","repos_url":"https://api.github.com/users/tomwilkie/repos","events_url":"https://api.github.com/users/tomwilkie/events{/privacy}","received_events_url":"https://api.github.com/users/tomwilkie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tomwilkie/prometheus","description":"The Prometheus monitoring system and time series database.","fork":true,"url":"https://api.github.com/repos/tomwilkie/prometheus","forks_url":"https://api.github.com/repos/tomwilkie/prometheus/forks","keys_url":"https://api.github.com/repos/tomwilkie/prometheus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tomwilkie/prometheus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tomwilkie/prometheus/teams","hooks_url":"https://api.github.com/repos/tomwilkie/prometheus/hooks","issue_events_url":"https://api.github.com/repos/tomwilkie/prometheus/issues/events{/number}","events_url":"https://api.github.com/repos/tomwilkie/prometheus/events","assignees_url":"https://api.github.com/repos/tomwilkie/prometheus/assignees{/user}","branches_url":"https://api.github.com/repos/tomwilkie/prometheus/branches{/branch}","tags_url":"https://api.github.com/repos/tomwilkie/prometheus/tags","blobs_url":"https://api.github.com/repos/tomwilkie/prometheus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tomwilkie/prometheus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tomwilkie/prometheus/git/refs{/sha}","trees_url":"https://api.github.com/repos/tomwilkie/prometheus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tomwilkie/prometheus/statuses/{sha}","languages_url":"https://api.github.com/repos/tomwilkie/prometheus/languages","stargazers_url":"https://api.github.com/repos/tomwilkie/prometheus/stargazers","contributors_url":"https://api.github.com/repos/tomwilkie/prometheus/contributors","subscribers_url":"https://api.github.com/repos/tomwilkie/prometheus/subscribers","subscription_url":"https://api.github.com/repos/tomwilkie/prometheus/subscription","commits_url":"https://api.github.com/repos/tomwilkie/prometheus/commits{/sha}","git_commits_url":"https://api.github.com/repos/tomwilkie/prometheus/git/commits{/sha}","comments_url":"https://api.github.com/repos/tomwilkie/prometheus/comments{/number}","issue_comment_url":"https://api.github.com/repos/tomwilkie/prometheus/issues/comments{/number}","contents_url":"https://api.github.com/repos/tomwilkie/prometheus/contents/{+path}","compare_url":"https://api.github.com/repos/tomwilkie/prometheus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tomwilkie/prometheus/merges","archive_url":"https://api.github.com/repos/tomwilkie/prometheus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tomwilkie/prometheus/downloads","issues_url":"https://api.github.com/repos/tomwilkie/prometheus/issues{/number}","pulls_url":"https://api.github.com/repos/tomwilkie/prometheus/pulls{/number}","milestones_url":"https://api.github.com/repos/tomwilkie/prometheus/milestones{/number}","notifications_url":"https://api.github.com/repos/tomwilkie/prometheus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tomwilkie/prometheus/labels{/name}","releases_url":"https://api.github.com/repos/tomwilkie/prometheus/releases{/id}","deployments_url":"https://api.github.com/repos/tomwilkie/prometheus/deployments","created_at":"2016-06-21T16:41:01Z","updated_at":"2017-03-08T04:38:24Z","pushed_at":"2017-05-09T12:50:23Z","git_url":"git://github.com/tomwilkie/prometheus.git","ssh_url":"git@github.com:tomwilkie/prometheus.git","clone_url":"https://github.com/tomwilkie/prometheus.git","svn_url":"https://github.com/tomwilkie/prometheus","homepage":"https://prometheus.io/","size":18811,"stargazers_count":3,"watchers_count":3,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"prometheus:master","ref":"master","sha":"14d0604aba95c7bb434f3a7687f7903bbe4fd81f","user":{"login":"prometheus","id":3380462,"avatar_url":"https://avatars0.githubusercontent.com/u/3380462?v=3","gravatar_id":"","url":"https://api.github.com/users/prometheus","html_url":"https://github.com/prometheus","followers_url":"https://api.github.com/users/prometheus/followers","following_url":"https://api.github.com/users/prometheus/following{/other_user}","gists_url":"https://api.github.com/users/prometheus/gists{/gist_id}","starred_url":"https://api.github.com/users/prometheus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prometheus/subscriptions","organizations_url":"https://api.github.com/users/prometheus/orgs","repos_url":"https://api.github.com/users/prometheus/repos","events_url":"https://api.github.com/users/prometheus/events{/privacy}","received_events_url":"https://api.github.com/users/prometheus/received_events","type":"Organization","site_admin":false},"repo":{"id":6838921,"name":"prometheus","full_name":"prometheus/prometheus","owner":{"login":"prometheus","id":3380462,"avatar_url":"https://avatars0.githubusercontent.com/u/3380462?v=3","gravatar_id":"","url":"https://api.github.com/users/prometheus","html_url":"https://github.com/prometheus","followers_url":"https://api.github.com/users/prometheus/followers","following_url":"https://api.github.com/users/prometheus/following{/other_user}","gists_url":"https://api.github.com/users/prometheus/gists{/gist_id}","starred_url":"https://api.github.com/users/prometheus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prometheus/subscriptions","organizations_url":"https://api.github.com/users/prometheus/orgs","repos_url":"https://api.github.com/users/prometheus/repos","events_url":"https://api.github.com/users/prometheus/events{/privacy}","received_events_url":"https://api.github.com/users/prometheus/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/prometheus/prometheus","description":"The Prometheus monitoring system and time series database.","fork":false,"url":"https://api.github.com/repos/prometheus/prometheus","forks_url":"https://api.github.com/repos/prometheus/prometheus/forks","keys_url":"https://api.github.com/repos/prometheus/prometheus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prometheus/prometheus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prometheus/prometheus/teams","hooks_url":"https://api.github.com/repos/prometheus/prometheus/hooks","issue_events_url":"https://api.github.com/repos/prometheus/prometheus/issues/events{/number}","events_url":"https://api.github.com/repos/prometheus/prometheus/events","assignees_url":"https://api.github.com/repos/prometheus/prometheus/assignees{/user}","branches_url":"https://api.github.com/repos/prometheus/prometheus/branches{/branch}","tags_url":"https://api.github.com/repos/prometheus/prometheus/tags","blobs_url":"https://api.github.com/repos/prometheus/prometheus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prometheus/prometheus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prometheus/prometheus/git/refs{/sha}","trees_url":"https://api.github.com/repos/prometheus/prometheus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prometheus/prometheus/statuses/{sha}","languages_url":"https://api.github.com/repos/prometheus/prometheus/languages","stargazers_url":"https://api.github.com/repos/prometheus/prometheus/stargazers","contributors_url":"https://api.github.com/repos/prometheus/prometheus/contributors","subscribers_url":"https://api.github.com/repos/prometheus/prometheus/subscribers","subscription_url":"https://api.github.com/repos/prometheus/prometheus/subscription","commits_url":"https://api.github.com/repos/prometheus/prometheus/commits{/sha}","git_commits_url":"https://api.github.com/repos/prometheus/prometheus/git/commits{/sha}","comments_url":"https://api.github.com/repos/prometheus/prometheus/comments{/number}","issue_comment_url":"https://api.github.com/repos/prometheus/prometheus/issues/comments{/number}","contents_url":"https://api.github.com/repos/prometheus/prometheus/contents/{+path}","compare_url":"https://api.github.com/repos/prometheus/prometheus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prometheus/prometheus/merges","archive_url":"https://api.github.com/repos/prometheus/prometheus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prometheus/prometheus/downloads","issues_url":"https://api.github.com/repos/prometheus/prometheus/issues{/number}","pulls_url":"https://api.github.com/repos/prometheus/prometheus/pulls{/number}","milestones_url":"https://api.github.com/repos/prometheus/prometheus/milestones{/number}","notifications_url":"https://api.github.com/repos/prometheus/prometheus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prometheus/prometheus/labels{/name}","releases_url":"https://api.github.com/repos/prometheus/prometheus/releases{/id}","deployments_url":"https://api.github.com/repos/prometheus/prometheus/deployments","created_at":"2012-11-24T11:14:12Z","updated_at":"2017-05-10T08:21:59Z","pushed_at":"2017-05-10T08:14:03Z","git_url":"git://github.com/prometheus/prometheus.git","ssh_url":"git@github.com:prometheus/prometheus.git","clone_url":"https://github.com/prometheus/prometheus.git","svn_url":"https://github.com/prometheus/prometheus","homepage":"https://prometheus.io/","size":22077,"stargazers_count":9427,"watchers_count":9427,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":996,"mirror_url":null,"open_issues_count":213,"forks":996,"open_issues":213,"watchers":9427,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prometheus/prometheus/pulls/2696"},"html":{"href":"https://github.com/prometheus/prometheus/pull/2696"},"issue":{"href":"https://api.github.com/repos/prometheus/prometheus/issues/2696"},"comments":{"href":"https://api.github.com/repos/prometheus/prometheus/issues/2696/comments"},"review_comments":{"href":"https://api.github.com/repos/prometheus/prometheus/pulls/2696/comments"},"review_comment":{"href":"https://api.github.com/repos/prometheus/prometheus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/prometheus/prometheus/pulls/2696/commits"},"statuses":{"href":"https://api.github.com/repos/prometheus/prometheus/statuses/d91689580364f3f8d03cd4446d202d25508ddc09"}}}}
{"actor":{"display_login":"brian-brazil"}}