{"action":"created","comment":{"url":"https://api.github.com/repos/01org/zephyr.js/pulls/comments/123109965","pull_request_review_id":45283021,"id":123109965,"diff_hunk":"@@ -1,17 +1,22 @@\n {\n     \"module\": \"fs\",\n     \"require\": \"fs\",\n-    \"targets\": [\"arduino_101\"],\n+    \"targets\": [\"arduino_101\", \"frdm_k64f\"],\n     \"zephyr_conf\": {\n         \"all\": [\n             \"CONFIG_FILE_SYSTEM=y\",\n             \"CONFIG_FILE_SYSTEM_FAT=y\",\n-            \"CONFIG_DISK_ACCESS_FLASH=y\",\n             \"CONFIG_FLASH=y\",\n             \"CONFIG_SPI=y\",\n             \"CONFIG_GPIO=y\"\n         ],\n-        \"arduino_101\": [\"CONFIG_FS_FAT_FLASH_DISK_W25QXXDV=y\"]\n+        \"arduino_101\": [\n+            \"CONFIG_DISK_ACCESS_FLASH=y\",\n+            \"CONFIG_FS_FAT_FLASH_DISK_W25QXXDV=y\"\n+        ],\n+        \"frdm_k64f\": [\n+            \"CONFIG_DISk_ACCESS_RAM=y\"","path":"src/zjs_fs.json","position":21,"original_position":21,"commit_id":"9c15989633f7471df4d5d0b692ae441cbbd58dc5","original_commit_id":"9c15989633f7471df4d5d0b692ae441cbbd58dc5","user":{"login":"jimmy-huang","id":1037247,"avatar_url":"https://avatars3.githubusercontent.com/u/1037247?v=3","gravatar_id":"","url":"https://api.github.com/users/jimmy-huang","html_url":"https://github.com/jimmy-huang","followers_url":"https://api.github.com/users/jimmy-huang/followers","following_url":"https://api.github.com/users/jimmy-huang/following{/other_user}","gists_url":"https://api.github.com/users/jimmy-huang/gists{/gist_id}","starred_url":"https://api.github.com/users/jimmy-huang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimmy-huang/subscriptions","organizations_url":"https://api.github.com/users/jimmy-huang/orgs","repos_url":"https://api.github.com/users/jimmy-huang/repos","events_url":"https://api.github.com/users/jimmy-huang/events{/privacy}","received_events_url":"https://api.github.com/users/jimmy-huang/received_events","type":"User","site_admin":false},"body":"good catch, a typo","created_at":"2017-06-20T22:12:33Z","updated_at":"2017-06-20T22:12:33Z","html_url":"https://github.com/01org/zephyr.js/pull/1275#discussion_r123109965","pull_request_url":"https://api.github.com/repos/01org/zephyr.js/pulls/1275","_links":{"self":{"href":"https://api.github.com/repos/01org/zephyr.js/pulls/comments/123109965"},"html":{"href":"https://github.com/01org/zephyr.js/pull/1275#discussion_r123109965"},"pull_request":{"href":"https://api.github.com/repos/01org/zephyr.js/pulls/1275"}}},"pull_request":{"url":"https://api.github.com/repos/01org/zephyr.js/pulls/1275","id":126407760,"html_url":"https://github.com/01org/zephyr.js/pull/1275","diff_url":"https://github.com/01org/zephyr.js/pull/1275.diff","patch_url":"https://github.com/01org/zephyr.js/pull/1275.patch","issue_url":"https://api.github.com/repos/01org/zephyr.js/issues/1275","number":1275,"state":"open","locked":false,"title":"[fs] Fixed broken FileSystem module on FRDM-K64F","user":{"login":"jimmy-huang","id":1037247,"avatar_url":"https://avatars3.githubusercontent.com/u/1037247?v=3","gravatar_id":"","url":"https://api.github.com/users/jimmy-huang","html_url":"https://github.com/jimmy-huang","followers_url":"https://api.github.com/users/jimmy-huang/followers","following_url":"https://api.github.com/users/jimmy-huang/following{/other_user}","gists_url":"https://api.github.com/users/jimmy-huang/gists{/gist_id}","starred_url":"https://api.github.com/users/jimmy-huang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimmy-huang/subscriptions","organizations_url":"https://api.github.com/users/jimmy-huang/orgs","repos_url":"https://api.github.com/users/jimmy-huang/repos","events_url":"https://api.github.com/users/jimmy-huang/events{/privacy}","received_events_url":"https://api.github.com/users/jimmy-huang/received_events","type":"User","site_admin":false},"body":"Fixes #1272\r\n\r\nSigned-off-by: Jimmy Huang <jimmy.huang@intel.com>","created_at":"2017-06-19T22:04:23Z","updated_at":"2017-06-20T22:12:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a31a96d590eb3d8187b050a3f63517bb42758929","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/01org/zephyr.js/pulls/1275/commits","review_comments_url":"https://api.github.com/repos/01org/zephyr.js/pulls/1275/comments","review_comment_url":"https://api.github.com/repos/01org/zephyr.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/01org/zephyr.js/issues/1275/comments","statuses_url":"https://api.github.com/repos/01org/zephyr.js/statuses/9c15989633f7471df4d5d0b692ae441cbbd58dc5","head":{"label":"jimmy-huang:fix-fs-k64f","ref":"fix-fs-k64f","sha":"9c15989633f7471df4d5d0b692ae441cbbd58dc5","user":{"login":"jimmy-huang","id":1037247,"avatar_url":"https://avatars3.githubusercontent.com/u/1037247?v=3","gravatar_id":"","url":"https://api.github.com/users/jimmy-huang","html_url":"https://github.com/jimmy-huang","followers_url":"https://api.github.com/users/jimmy-huang/followers","following_url":"https://api.github.com/users/jimmy-huang/following{/other_user}","gists_url":"https://api.github.com/users/jimmy-huang/gists{/gist_id}","starred_url":"https://api.github.com/users/jimmy-huang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimmy-huang/subscriptions","organizations_url":"https://api.github.com/users/jimmy-huang/orgs","repos_url":"https://api.github.com/users/jimmy-huang/repos","events_url":"https://api.github.com/users/jimmy-huang/events{/privacy}","received_events_url":"https://api.github.com/users/jimmy-huang/received_events","type":"User","site_admin":false},"repo":{"id":70281286,"name":"zephyr.js","full_name":"jimmy-huang/zephyr.js","owner":{"login":"jimmy-huang","id":1037247,"avatar_url":"https://avatars3.githubusercontent.com/u/1037247?v=3","gravatar_id":"","url":"https://api.github.com/users/jimmy-huang","html_url":"https://github.com/jimmy-huang","followers_url":"https://api.github.com/users/jimmy-huang/followers","following_url":"https://api.github.com/users/jimmy-huang/following{/other_user}","gists_url":"https://api.github.com/users/jimmy-huang/gists{/gist_id}","starred_url":"https://api.github.com/users/jimmy-huang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimmy-huang/subscriptions","organizations_url":"https://api.github.com/users/jimmy-huang/orgs","repos_url":"https://api.github.com/users/jimmy-huang/repos","events_url":"https://api.github.com/users/jimmy-huang/events{/privacy}","received_events_url":"https://api.github.com/users/jimmy-huang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jimmy-huang/zephyr.js","description":"JavaScript* Runtime for Zephyr* OS","fork":true,"url":"https://api.github.com/repos/jimmy-huang/zephyr.js","forks_url":"https://api.github.com/repos/jimmy-huang/zephyr.js/forks","keys_url":"https://api.github.com/repos/jimmy-huang/zephyr.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jimmy-huang/zephyr.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jimmy-huang/zephyr.js/teams","hooks_url":"https://api.github.com/repos/jimmy-huang/zephyr.js/hooks","issue_events_url":"https://api.github.com/repos/jimmy-huang/zephyr.js/issues/events{/number}","events_url":"https://api.github.com/repos/jimmy-huang/zephyr.js/events","assignees_url":"https://api.github.com/repos/jimmy-huang/zephyr.js/assignees{/user}","branches_url":"https://api.github.com/repos/jimmy-huang/zephyr.js/branches{/branch}","tags_url":"https://api.github.com/repos/jimmy-huang/zephyr.js/tags","blobs_url":"https://api.github.com/repos/jimmy-huang/zephyr.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jimmy-huang/zephyr.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jimmy-huang/zephyr.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/jimmy-huang/zephyr.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jimmy-huang/zephyr.js/statuses/{sha}","languages_url":"https://api.github.com/repos/jimmy-huang/zephyr.js/languages","stargazers_url":"https://api.github.com/repos/jimmy-huang/zephyr.js/stargazers","contributors_url":"https://api.github.com/repos/jimmy-huang/zephyr.js/contributors","subscribers_url":"https://api.github.com/repos/jimmy-huang/zephyr.js/subscribers","subscription_url":"https://api.github.com/repos/jimmy-huang/zephyr.js/subscription","commits_url":"https://api.github.com/repos/jimmy-huang/zephyr.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/jimmy-huang/zephyr.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/jimmy-huang/zephyr.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/jimmy-huang/zephyr.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/jimmy-huang/zephyr.js/contents/{+path}","compare_url":"https://api.github.com/repos/jimmy-huang/zephyr.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jimmy-huang/zephyr.js/merges","archive_url":"https://api.github.com/repos/jimmy-huang/zephyr.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jimmy-huang/zephyr.js/downloads","issues_url":"https://api.github.com/repos/jimmy-huang/zephyr.js/issues{/number}","pulls_url":"https://api.github.com/repos/jimmy-huang/zephyr.js/pulls{/number}","milestones_url":"https://api.github.com/repos/jimmy-huang/zephyr.js/milestones{/number}","notifications_url":"https://api.github.com/repos/jimmy-huang/zephyr.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jimmy-huang/zephyr.js/labels{/name}","releases_url":"https://api.github.com/repos/jimmy-huang/zephyr.js/releases{/id}","deployments_url":"https://api.github.com/repos/jimmy-huang/zephyr.js/deployments","created_at":"2016-10-07T20:39:52Z","updated_at":"2016-10-07T20:39:53Z","pushed_at":"2017-06-20T22:10:27Z","git_url":"git://github.com/jimmy-huang/zephyr.js.git","ssh_url":"git@github.com:jimmy-huang/zephyr.js.git","clone_url":"https://github.com/jimmy-huang/zephyr.js.git","svn_url":"https://github.com/jimmy-huang/zephyr.js","homepage":"","size":2368,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"01org:master","ref":"master","sha":"78c97490a3d1d69a68f7d8edf32b5838d4b942d7","user":{"login":"01org","id":1635439,"avatar_url":"https://avatars2.githubusercontent.com/u/1635439?v=3","gravatar_id":"","url":"https://api.github.com/users/01org","html_url":"https://github.com/01org","followers_url":"https://api.github.com/users/01org/followers","following_url":"https://api.github.com/users/01org/following{/other_user}","gists_url":"https://api.github.com/users/01org/gists{/gist_id}","starred_url":"https://api.github.com/users/01org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/01org/subscriptions","organizations_url":"https://api.github.com/users/01org/orgs","repos_url":"https://api.github.com/users/01org/repos","events_url":"https://api.github.com/users/01org/events{/privacy}","received_events_url":"https://api.github.com/users/01org/received_events","type":"Organization","site_admin":false},"repo":{"id":61588342,"name":"zephyr.js","full_name":"01org/zephyr.js","owner":{"login":"01org","id":1635439,"avatar_url":"https://avatars2.githubusercontent.com/u/1635439?v=3","gravatar_id":"","url":"https://api.github.com/users/01org","html_url":"https://github.com/01org","followers_url":"https://api.github.com/users/01org/followers","following_url":"https://api.github.com/users/01org/following{/other_user}","gists_url":"https://api.github.com/users/01org/gists{/gist_id}","starred_url":"https://api.github.com/users/01org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/01org/subscriptions","organizations_url":"https://api.github.com/users/01org/orgs","repos_url":"https://api.github.com/users/01org/repos","events_url":"https://api.github.com/users/01org/events{/privacy}","received_events_url":"https://api.github.com/users/01org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/01org/zephyr.js","description":"JavaScript* Runtime for Zephyr* OS","fork":false,"url":"https://api.github.com/repos/01org/zephyr.js","forks_url":"https://api.github.com/repos/01org/zephyr.js/forks","keys_url":"https://api.github.com/repos/01org/zephyr.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/01org/zephyr.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/01org/zephyr.js/teams","hooks_url":"https://api.github.com/repos/01org/zephyr.js/hooks","issue_events_url":"https://api.github.com/repos/01org/zephyr.js/issues/events{/number}","events_url":"https://api.github.com/repos/01org/zephyr.js/events","assignees_url":"https://api.github.com/repos/01org/zephyr.js/assignees{/user}","branches_url":"https://api.github.com/repos/01org/zephyr.js/branches{/branch}","tags_url":"https://api.github.com/repos/01org/zephyr.js/tags","blobs_url":"https://api.github.com/repos/01org/zephyr.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/01org/zephyr.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/01org/zephyr.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/01org/zephyr.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/01org/zephyr.js/statuses/{sha}","languages_url":"https://api.github.com/repos/01org/zephyr.js/languages","stargazers_url":"https://api.github.com/repos/01org/zephyr.js/stargazers","contributors_url":"https://api.github.com/repos/01org/zephyr.js/contributors","subscribers_url":"https://api.github.com/repos/01org/zephyr.js/subscribers","subscription_url":"https://api.github.com/repos/01org/zephyr.js/subscription","commits_url":"https://api.github.com/repos/01org/zephyr.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/01org/zephyr.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/01org/zephyr.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/01org/zephyr.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/01org/zephyr.js/contents/{+path}","compare_url":"https://api.github.com/repos/01org/zephyr.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/01org/zephyr.js/merges","archive_url":"https://api.github.com/repos/01org/zephyr.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/01org/zephyr.js/downloads","issues_url":"https://api.github.com/repos/01org/zephyr.js/issues{/number}","pulls_url":"https://api.github.com/repos/01org/zephyr.js/pulls{/number}","milestones_url":"https://api.github.com/repos/01org/zephyr.js/milestones{/number}","notifications_url":"https://api.github.com/repos/01org/zephyr.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/01org/zephyr.js/labels{/name}","releases_url":"https://api.github.com/repos/01org/zephyr.js/releases{/id}","deployments_url":"https://api.github.com/repos/01org/zephyr.js/deployments","created_at":"2016-06-20T23:53:57Z","updated_at":"2017-05-25T17:35:10Z","pushed_at":"2017-06-20T22:10:29Z","git_url":"git://github.com/01org/zephyr.js.git","ssh_url":"git@github.com:01org/zephyr.js.git","clone_url":"https://github.com/01org/zephyr.js.git","svn_url":"https://github.com/01org/zephyr.js","homepage":"","size":2254,"stargazers_count":64,"watchers_count":64,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":43,"mirror_url":null,"open_issues_count":120,"forks":43,"open_issues":120,"watchers":64,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/01org/zephyr.js/pulls/1275"},"html":{"href":"https://github.com/01org/zephyr.js/pull/1275"},"issue":{"href":"https://api.github.com/repos/01org/zephyr.js/issues/1275"},"comments":{"href":"https://api.github.com/repos/01org/zephyr.js/issues/1275/comments"},"review_comments":{"href":"https://api.github.com/repos/01org/zephyr.js/pulls/1275/comments"},"review_comment":{"href":"https://api.github.com/repos/01org/zephyr.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/01org/zephyr.js/pulls/1275/commits"},"statuses":{"href":"https://api.github.com/repos/01org/zephyr.js/statuses/9c15989633f7471df4d5d0b692ae441cbbd58dc5"}}}}
{"actor":{"display_login":"jimmy-huang"}}