{"action":"created","issue":{"url":"https://api.github.com/repos/junit-team/junit5/issues/801","repository_url":"https://api.github.com/repos/junit-team/junit5","labels_url":"https://api.github.com/repos/junit-team/junit5/issues/801/labels{/name}","comments_url":"https://api.github.com/repos/junit-team/junit5/issues/801/comments","events_url":"https://api.github.com/repos/junit-team/junit5/issues/801/events","html_url":"https://github.com/junit-team/junit5/issues/801","id":223450194,"number":801,"title":"JUnit vintage failing with \"The forked VM terminated without properly saying goodbye\"","user":{"login":"vmassol","id":628267,"avatar_url":"https://avatars0.githubusercontent.com/u/628267?v=3","gravatar_id":"","url":"https://api.github.com/users/vmassol","html_url":"https://github.com/vmassol","followers_url":"https://api.github.com/users/vmassol/followers","following_url":"https://api.github.com/users/vmassol/following{/other_user}","gists_url":"https://api.github.com/users/vmassol/gists{/gist_id}","starred_url":"https://api.github.com/users/vmassol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmassol/subscriptions","organizations_url":"https://api.github.com/users/vmassol/orgs","repos_url":"https://api.github.com/users/vmassol/repos","events_url":"https://api.github.com/users/vmassol/events{/privacy}","received_events_url":"https://api.github.com/users/vmassol/received_events","type":"User","site_admin":false},"labels":[{"id":508765159,"url":"https://api.github.com/repos/junit-team/junit5/labels/component:%20Surefire","name":"component: Surefire","color":"d93f0b","default":false},{"id":420912143,"url":"https://api.github.com/repos/junit-team/junit5/labels/component:%20Vintage","name":"component: Vintage","color":"11cc99","default":false},{"id":371966680,"url":"https://api.github.com/repos/junit-team/junit5/labels/theme:%20build","name":"theme: build","color":"0052cc","default":false},{"id":165165178,"url":"https://api.github.com/repos/junit-team/junit5/labels/type:%20bug","name":"type: bug","color":"fc2929","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/junit-team/junit5/milestones/8","html_url":"https://github.com/junit-team/junit5/milestone/8","labels_url":"https://api.github.com/repos/junit-team/junit5/milestones/8/labels","id":1902232,"number":8,"title":"5.0 M5","description":"Theme: Dynamic Containers and minor API changes","creator":{"login":"sbrannen","id":104798,"avatar_url":"https://avatars3.githubusercontent.com/u/104798?v=3","gravatar_id":"","url":"https://api.github.com/users/sbrannen","html_url":"https://github.com/sbrannen","followers_url":"https://api.github.com/users/sbrannen/followers","following_url":"https://api.github.com/users/sbrannen/following{/other_user}","gists_url":"https://api.github.com/users/sbrannen/gists{/gist_id}","starred_url":"https://api.github.com/users/sbrannen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbrannen/subscriptions","organizations_url":"https://api.github.com/users/sbrannen/orgs","repos_url":"https://api.github.com/users/sbrannen/repos","events_url":"https://api.github.com/users/sbrannen/events{/privacy}","received_events_url":"https://api.github.com/users/sbrannen/received_events","type":"User","site_admin":false},"open_issues":63,"closed_issues":40,"state":"open","created_at":"2016-07-25T11:53:46Z","updated_at":"2017-05-05T11:26:48Z","due_on":"2017-06-18T07:00:00Z","closed_at":null},"comments":21,"created_at":"2017-04-21T17:40:27Z","updated_at":"2017-05-05T11:50:42Z","closed_at":null,"body":"While building https://github.com/xwiki/xwiki-platform/tree/master/xwiki-platform-core/xwiki-platform-oldcore with vintage 4.12.0-M4 I get the error: \r\n\r\n\"The forked VM terminated without properly saying goodbye. VM crash or System.exit called?\"\r\n\r\nThis module builds fine with \"standard\" Maven surefire:\r\n\r\n`````\r\n        <plugin>\r\n          <groupId>org.apache.maven.plugins</groupId>\r\n          <artifactId>maven-surefire-plugin</artifactId>\r\n          <version>2.19.1</version>\r\n        </plugin>\r\n`````\r\n\r\nBut it fails when using:\r\n\r\n`````\r\n<junit5.version>5.0.0-M4</junit5.version>\r\n...\r\n        <plugin>\r\n          <groupId>org.apache.maven.plugins</groupId>\r\n          <artifactId>maven-surefire-plugin</artifactId>\r\n          <version>2.19.1</version>\r\n          <dependencies>\r\n            <!-- Allow running both JUnit4 and JUnit5 tests -->\r\n            <dependency>\r\n              <groupId>org.junit.platform</groupId>\r\n              <artifactId>junit-platform-surefire-provider</artifactId>\r\n              <version>1.0.0-M4</version>\r\n            </dependency>\r\n            <dependency>\r\n              <groupId>org.junit.jupiter</groupId>\r\n              <artifactId>junit-jupiter-engine</artifactId>\r\n              <version>${junit5.version}</version>\r\n            </dependency>\r\n            <dependency>\r\n              <groupId>org.junit.vintage</groupId>\r\n              <artifactId>junit-vintage-engine</artifactId>\r\n              <version>4.12.0-M4</version>\r\n            </dependency>\r\n          </dependencies>\r\n        </plugin>\r\n`````\r\n\r\nThe console has:\r\n\r\n````\r\n[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test (default-test) on project xwiki-platform-oldcore: Execution default-test of goal org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test failed: The forked VM terminated without properly saying goodbye. VM crash or System.exit called?\r\n[ERROR] Command was /bin/sh -c cd /Users/vmassol/dev/xwiki/xwiki-platform/xwiki-platform-core/xwiki-platform-oldcore && /Library/Java/JavaVirtualMachines/jdk1.8.0_112.jdk/Contents/Home/jre/bin/java -jar /Users/vmassol/dev/xwiki/xwiki-platform/xwiki-platform-core/xwiki-platform-oldcore/target/surefire/surefirebooter7554021871729302969.jar /Users/vmassol/dev/xwiki/xwiki-platform/xwiki-platform-core/xwiki-platform-oldcore/target/surefire/surefire4900910245539098485tmp /Users/vmassol/dev/xwiki/xwiki-platform/xwiki-platform-core/xwiki-platform-oldcore/target/surefire/surefire_02307687931243988789tmp\r\n[ERROR] -> [Help 1]\r\norg.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test (default-test) on project xwiki-platform-oldcore: Execution default-test of goal org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test failed: The forked VM terminated without properly saying goodbye. VM crash or System.exit called?\r\nCommand was /bin/sh -c cd /Users/vmassol/dev/xwiki/xwiki-platform/xwiki-platform-core/xwiki-platform-oldcore && /Library/Java/JavaVirtualMachines/jdk1.8.0_112.jdk/Contents/Home/jre/bin/java -jar /Users/vmassol/dev/xwiki/xwiki-platform/xwiki-platform-core/xwiki-platform-oldcore/target/surefire/surefirebooter7554021871729302969.jar /Users/vmassol/dev/xwiki/xwiki-platform/xwiki-platform-core/xwiki-platform-oldcore/target/surefire/surefire4900910245539098485tmp /Users/vmassol/dev/xwiki/xwiki-platform/xwiki-platform-core/xwiki-platform-oldcore/target/surefire/surefire_02307687931243988789tmp\r\n\tat org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:213)\r\n\tat org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:154)\r\n\tat org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:146)\r\n\tat org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:117)\r\n\tat org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:81)\r\n\tat org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)\r\n\tat org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)\r\n\tat org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:309)\r\n\tat org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:194)\r\n\tat org.apache.maven.DefaultMaven.execute(DefaultMaven.java:107)\r\n\tat org.apache.maven.cli.MavenCli.execute(MavenCli.java:993)\r\n\tat org.apache.maven.cli.MavenCli.doMain(MavenCli.java:345)\r\n\tat org.apache.maven.cli.MavenCli.main(MavenCli.java:191)\r\n\tat sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)\r\n\tat sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)\r\n\tat sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)\r\n\tat java.lang.reflect.Method.invoke(Method.java:498)\r\n\tat org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)\r\n\tat org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)\r\n\tat org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)\r\n\tat org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)\r\nCaused by: org.apache.maven.plugin.PluginExecutionException: Execution default-test of goal org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test failed: The forked VM terminated without properly saying goodbye. VM crash or System.exit called?\r\nCommand was /bin/sh -c cd /Users/vmassol/dev/xwiki/xwiki-platform/xwiki-platform-core/xwiki-platform-oldcore && /Library/Java/JavaVirtualMachines/jdk1.8.0_112.jdk/Contents/Home/jre/bin/java -jar /Users/vmassol/dev/xwiki/xwiki-platform/xwiki-platform-core/xwiki-platform-oldcore/target/surefire/surefirebooter7554021871729302969.jar /Users/vmassol/dev/xwiki/xwiki-platform/xwiki-platform-core/xwiki-platform-oldcore/target/surefire/surefire4900910245539098485tmp /Users/vmassol/dev/xwiki/xwiki-platform/xwiki-platform-core/xwiki-platform-oldcore/target/surefire/surefire_02307687931243988789tmp\r\n\tat org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:145)\r\n\tat org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208)\r\n\t... 20 more\r\nCaused by: java.lang.RuntimeException: The forked VM terminated without properly saying goodbye. VM crash or System.exit called?\r\nCommand was /bin/sh -c cd /Users/vmassol/dev/xwiki/xwiki-platform/xwiki-platform-core/xwiki-platform-oldcore && /Library/Java/JavaVirtualMachines/jdk1.8.0_112.jdk/Contents/Home/jre/bin/java -jar /Users/vmassol/dev/xwiki/xwiki-platform/xwiki-platform-core/xwiki-platform-oldcore/target/surefire/surefirebooter7554021871729302969.jar /Users/vmassol/dev/xwiki/xwiki-platform/xwiki-platform-core/xwiki-platform-oldcore/target/surefire/surefire4900910245539098485tmp /Users/vmassol/dev/xwiki/xwiki-platform/xwiki-platform-core/xwiki-platform-oldcore/target/surefire/surefire_02307687931243988789tmp\r\n\tat org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:590)\r\n\tat org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:460)\r\n\tat org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:229)\r\n\tat org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:201)\r\n\tat org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeProvider(AbstractSurefireMojo.java:1026)\r\n\tat org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeAfterPreconditionsChecked(AbstractSurefireMojo.java:862)\r\n\tat org.apache.maven.plugin.surefire.AbstractSurefireMojo.execute(AbstractSurefireMojo.java:755)\r\n\tat org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)\r\n\t... 21 more\r\n[ERROR] \r\n[ERROR] Re-run Maven using the -X switch to enable full debug logging.\r\n[ERROR] \r\n[ERROR] For more information about the errors and possible solutions, please read the following articles:\r\n[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/PluginExecutionException\r\n`````\r\n\r\nTo reproduce:\r\n* Git clone https://github.com/xwiki/xwiki-platform.git (see https://github.com/xwiki/xwiki-platform)\r\n* Configure you maven ~/.m2/settings.xml with what's on http://dev.xwiki.org/xwiki/bin/view/Community/Building#HInstallingMaven\r\n* Run: `mvn clean install -rf xwiki-platform-core/xwiki-platform-oldcore/`\r\n\r\nThanks!"},"comment":{"url":"https://api.github.com/repos/junit-team/junit5/issues/comments/299445042","html_url":"https://github.com/junit-team/junit5/issues/801#issuecomment-299445042","issue_url":"https://api.github.com/repos/junit-team/junit5/issues/801","id":299445042,"user":{"login":"vmassol","id":628267,"avatar_url":"https://avatars0.githubusercontent.com/u/628267?v=3","gravatar_id":"","url":"https://api.github.com/users/vmassol","html_url":"https://github.com/vmassol","followers_url":"https://api.github.com/users/vmassol/followers","following_url":"https://api.github.com/users/vmassol/following{/other_user}","gists_url":"https://api.github.com/users/vmassol/gists{/gist_id}","starred_url":"https://api.github.com/users/vmassol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmassol/subscriptions","organizations_url":"https://api.github.com/users/vmassol/orgs","repos_url":"https://api.github.com/users/vmassol/repos","events_url":"https://api.github.com/users/vmassol/events{/privacy}","received_events_url":"https://api.github.com/users/vmassol/received_events","type":"User","site_admin":false},"created_at":"2017-05-05T11:50:42Z","updated_at":"2017-05-05T11:50:42Z","body":"So to make it clear:\r\n* Regarding \"the logger\" you were referring to the log appearing in the content of the dump file. So tests are not allowed to log anything to the console anymore? However this is not failing the build and is not related to this junit5 issue per see. However when executing with plain surefire I get to see the logs printed on the console and they're not with the junit5 surefire provider so that's another difference that should probably be fixed in junit5/vintage codebase:\r\n````\r\n[INFO] Running com.xpn.xwiki.api.ContextTest\r\n[WARNING] Tests run: 1, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 0.064 s - in com.xpn.xwiki.api.ContextTest\r\n[INFO] Running com.xpn.xwiki.api.DocumentTest\r\n13:46:09.791 [main] WARN  com.xpn.xwiki.doc.XWikiDocument - Failed to find parser for the default syntax [XWiki 1.0]. Defaulting to xwiki/2.1 syntax.\r\n13:46:09.848 [main] WARN  com.xpn.xwiki.doc.XWikiDocument - Failed to find parser for the default syntax [XWiki 1.0]. Defaulting to xwiki/2.1 syntax.\r\n13:46:09.884 [main] WARN  com.xpn.xwiki.doc.XWikiDocument - Failed to find parser for the default syntax [XWiki 1.0]. Defaulting to xwiki/2.1 syntax.\r\n13:46:09.907 [main] WARN  com.xpn.xwiki.doc.XWikiDocument - Failed to find parser for the default syntax [XWiki 1.0]. Defaulting to xwiki/2.1 syntax.\r\n[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.367 s - in com.xpn.xwiki.api.DocumentTest\r\n````\r\n* DOMXMLWriterTest is making the junit5 surefire provider fail the build with \"The forked VM terminated without properly saying goodbye. VM crash or System.exit called?\". The build doesn't fail with plain surefire. If you want to see the test for DOMXMLWriterTest: https://github.com/xwiki/xwiki-platform/blob/c210de4fa72bb651ff4bd1581c2f31a2fc4d7787/xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/internal/xml/DOMXMLWriterTest.java#L35-L35\r\n\r\nThanks"}}
{"actor":{"display_login":"vmassol"}}