{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/charts/issues/1057","repository_url":"https://api.github.com/repos/kubernetes/charts","labels_url":"https://api.github.com/repos/kubernetes/charts/issues/1057/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/charts/issues/1057/comments","events_url":"https://api.github.com/repos/kubernetes/charts/issues/1057/events","html_url":"https://github.com/kubernetes/charts/pull/1057","id":227517549,"number":1057,"title":"[stable/drupal] PV hostPath","user":{"login":"scottrigby","id":407675,"avatar_url":"https://avatars1.githubusercontent.com/u/407675?v=3","gravatar_id":"","url":"https://api.github.com/users/scottrigby","html_url":"https://github.com/scottrigby","followers_url":"https://api.github.com/users/scottrigby/followers","following_url":"https://api.github.com/users/scottrigby/following{/other_user}","gists_url":"https://api.github.com/users/scottrigby/gists{/gist_id}","starred_url":"https://api.github.com/users/scottrigby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scottrigby/subscriptions","organizations_url":"https://api.github.com/users/scottrigby/orgs","repos_url":"https://api.github.com/users/scottrigby/repos","events_url":"https://api.github.com/users/scottrigby/events{/privacy}","received_events_url":"https://api.github.com/users/scottrigby/received_events","type":"User","site_admin":false},"labels":[{"id":484586588,"url":"https://api.github.com/repos/kubernetes/charts/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"ededed","default":false},{"id":582594847,"url":"https://api.github.com/repos/kubernetes/charts/labels/needs-ok-to-test","name":"needs-ok-to-test","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":14,"created_at":"2017-05-09T22:33:43Z","updated_at":"2017-06-13T20:35:31Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/charts/pulls/1057","html_url":"https://github.com/kubernetes/charts/pull/1057","diff_url":"https://github.com/kubernetes/charts/pull/1057.diff","patch_url":"https://github.com/kubernetes/charts/pull/1057.patch"},"body":"# Initial issue\r\n\r\n## Initial Rationale\r\nIf the ideal local development workflow is to have as much parity with Prod as possible, and if K8S (and helm/charts) is how Prod is deployed, then a local chart (deployed to minikube etc) seems to be the perfect recipe for local development. \r\n\r\nCharts were never intended for local development, but there's no reason to not to extend charts to fit this use case! This PR is an attempt to add this to stable/drupal as an example chart.\r\n\r\n## Initial status\r\nI've brainstormed this idea with @prydonius on Slack. This is as far as I was able to get using the PV route you suggested.\r\n\r\nAs I understand from our Slack chat, the next step is to somehow bind the PVC to the new PV created here. Based on PV documentation, it would seem this PV should be used since it is created to match the PVC request - but that is not happening, it's still generating a PV dynamically.\r\n\r\nWe are then supposed to use existingClaim in the chart to mount our volume. I'm also not quite clear on this step. I've gone ahead and opened this PR just to get feedback, and work out any kinks through review/discussion/changes.\r\n\r\nI also want to note, that the diff below works perfectly fine without PVC, by setting `--set persistence.enabled=false --set hostpath=/PATH/TO/HOST/MOUNT`:\r\n<details>\r\n\r\n```diff\r\n$ git diff\r\ndiff --git a/stable/drupal/templates/deployment.yaml b/stable/drupal/templates/deployment.yaml\r\nindex 4df9332..f5944ed 100644\r\n--- a/stable/drupal/templates/deployment.yaml\r\n+++ b/stable/drupal/templates/deployment.yaml\r\n@@ -66,6 +66,9 @@ spec:\r\n       {{- if .Values.persistence.enabled }}\r\n         persistentVolumeClaim:\r\n           claimName: {{ template \"fullname\" . }}-drupal\r\n+      {{- else if .Values.hostpath }}\r\n+        hostPath:\r\n+          path: {{ .Values.hostpath }}\r\n       {{- else }}\r\n         emptyDir: {}\r\n       {{- end }}\r\n```\r\n\r\n</details>\r\nHowever, I am trying to get this to work with/as a PV in this PR.\r\n\r\nFeedback and ideas very much welcome!\r\n\r\n## Related issues\r\nI have opened an issue in the bitnami-docker-drupal project to [Mount drupal/core just like modules and themes](https://github.com/bitnami/bitnami-docker-drupal/issues/83), so that this PR would work not only for Drupal site builders and contrib maintainers, but also for local Drupal core development using kubernetes charts."},"comment":{"url":"https://api.github.com/repos/kubernetes/charts/issues/comments/308240551","html_url":"https://github.com/kubernetes/charts/pull/1057#issuecomment-308240551","issue_url":"https://api.github.com/repos/kubernetes/charts/issues/1057","id":308240551,"user":{"login":"scottrigby","id":407675,"avatar_url":"https://avatars1.githubusercontent.com/u/407675?v=3","gravatar_id":"","url":"https://api.github.com/users/scottrigby","html_url":"https://github.com/scottrigby","followers_url":"https://api.github.com/users/scottrigby/followers","following_url":"https://api.github.com/users/scottrigby/following{/other_user}","gists_url":"https://api.github.com/users/scottrigby/gists{/gist_id}","starred_url":"https://api.github.com/users/scottrigby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scottrigby/subscriptions","organizations_url":"https://api.github.com/users/scottrigby/orgs","repos_url":"https://api.github.com/users/scottrigby/repos","events_url":"https://api.github.com/users/scottrigby/events{/privacy}","received_events_url":"https://api.github.com/users/scottrigby/received_events","type":"User","site_admin":false},"created_at":"2017-06-13T20:35:31Z","updated_at":"2017-06-13T20:35:31Z","body":"@prydonius Tl;dr, I think I update the README now to cover all our bases. If you agree, I think this is ready."}}
{"actor":{"display_login":"scottrigby"}}