{"action":"created","issue":{"url":"https://api.github.com/repos/edx/edx-enterprise/issues/104","repository_url":"https://api.github.com/repos/edx/edx-enterprise","labels_url":"https://api.github.com/repos/edx/edx-enterprise/issues/104/labels{/name}","comments_url":"https://api.github.com/repos/edx/edx-enterprise/issues/104/comments","events_url":"https://api.github.com/repos/edx/edx-enterprise/issues/104/events","html_url":"https://github.com/edx/edx-enterprise/pull/104","id":228086051,"number":104,"title":"[ENT-290] Enable switch in Enterprise setup to hide Audit track","user":{"login":"replaceafill","id":560781,"avatar_url":"https://avatars1.githubusercontent.com/u/560781?v=3","gravatar_id":"","url":"https://api.github.com/users/replaceafill","html_url":"https://github.com/replaceafill","followers_url":"https://api.github.com/users/replaceafill/followers","following_url":"https://api.github.com/users/replaceafill/following{/other_user}","gists_url":"https://api.github.com/users/replaceafill/gists{/gist_id}","starred_url":"https://api.github.com/users/replaceafill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/replaceafill/subscriptions","organizations_url":"https://api.github.com/users/replaceafill/orgs","repos_url":"https://api.github.com/users/replaceafill/repos","events_url":"https://api.github.com/users/replaceafill/events{/privacy}","received_events_url":"https://api.github.com/users/replaceafill/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-05-11T18:47:50Z","updated_at":"2017-05-11T21:03:06Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/edx/edx-enterprise/pulls/104","html_url":"https://github.com/edx/edx-enterprise/pull/104","diff_url":"https://github.com/edx/edx-enterprise/pull/104.diff","patch_url":"https://github.com/edx/edx-enterprise/pull/104.patch"},"body":"**Description:** This PR adds a boolean flag \"Hide audit track\" to the EnterpriseCustomer model and adjusts the new landing page to filter course modes accodingly.\r\n\r\n**JIRA:** [ENT-290](https://openedx.atlassian.net/browse/ENT-290)\r\n\r\n**Dependencies:**  \r\n[PR on edx/edx-platform for the new `ENTERPRISE_COURSE_ENROLLMENT_AUDIT_MODES` setting](https://github.com/edx/edx-platform/pull/15095)\r\n\r\n** Screenshots:**\r\n![1](https://cloud.githubusercontent.com/assets/560781/25966911/aadbae12-3649-11e7-9eef-12d1917ca690.png)\r\n![2](https://cloud.githubusercontent.com/assets/560781/25966910/aadb5f0c-3649-11e7-8cbf-2ef3835eb37c.png)\r\n![3](https://cloud.githubusercontent.com/assets/560781/25966909/aad9f3d8-3649-11e7-94f0-b762a56bda0f.png)\r\n![4](https://cloud.githubusercontent.com/assets/560781/25966912/aadf4a5e-3649-11e7-979e-ad13631ca44c.png)\r\n\r\n**Testing instructions:**\r\n\r\n1. Add an Enterprise Customer in the Django admin. Check its ID\r\n2. Add a course in the customer catalog. Check its ID.\r\n3. Visit the new landing page for the enterprise customer and course by typing a URL like this:\r\n\r\nhttp://localhost:8000/enterprise/7c3c286a-9834-46ae-809e-e01b114ba980/course/course-v1:edX+DemoX+Demo_Course/enroll/\r\n\r\nwhere 7c3c286a-9834-46ae-809e-e01b114ba980 should be the ID of the customer and 'course-v1:edX+DemoX+Demo_Course' should be the ID of the course\r\n\r\n4. Check that the landing page shows both course modes (Enroll and Audit).\r\n5. Go to the Enterprise Customer and check the \"Hide audit track\" flag\r\n6. Go back to the landing page and verify that the Audit track is now hidden\r\n\r\n**Merge checklist:**\r\n\r\n- [ ] Regenerate requirements with `make upgrade && make requirements` (and make sure to fix any errors).\r\n  **DO NOT** just add dependencies to `requirements/*.txt` files.\r\n- [ ] All reviewers approved\r\n- [ ] CI build is green\r\n- [ ] Version bumped\r\n- [ ] Changelog record added\r\n- [ ] Documentation updated (not only docstrings)\r\n- [ ] Commits are (reasonably) squashed\r\n- [ ] Translations are updated\r\n- [ ] PR author is listed in AUTHORS\r\n\r\n**Post merge:**\r\n- [ ] Create a tag\r\n- [ ] Check new version is pushed to PyPi after tag-triggered build is finished.\r\n- [ ] Delete working branch (if not needed anymore)\r\n\r\n**Reviewers**\r\n- [ ] @haikuginger"},"comment":{"url":"https://api.github.com/repos/edx/edx-enterprise/issues/comments/300916213","html_url":"https://github.com/edx/edx-enterprise/pull/104#issuecomment-300916213","issue_url":"https://api.github.com/repos/edx/edx-enterprise/issues/104","id":300916213,"user":{"login":"bradenmacdonald","id":945577,"avatar_url":"https://avatars1.githubusercontent.com/u/945577?v=3","gravatar_id":"","url":"https://api.github.com/users/bradenmacdonald","html_url":"https://github.com/bradenmacdonald","followers_url":"https://api.github.com/users/bradenmacdonald/followers","following_url":"https://api.github.com/users/bradenmacdonald/following{/other_user}","gists_url":"https://api.github.com/users/bradenmacdonald/gists{/gist_id}","starred_url":"https://api.github.com/users/bradenmacdonald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradenmacdonald/subscriptions","organizations_url":"https://api.github.com/users/bradenmacdonald/orgs","repos_url":"https://api.github.com/users/bradenmacdonald/repos","events_url":"https://api.github.com/users/bradenmacdonald/events{/privacy}","received_events_url":"https://api.github.com/users/bradenmacdonald/received_events","type":"User","site_admin":false},"created_at":"2017-05-11T21:03:06Z","updated_at":"2017-05-11T21:03:06Z","body":"Just asking in case this hasn't been discussed yet: Are we certain that the only use case for this is every going to be \"hide audit mode\"? Because if not, it could make sense to replace the new boolean field with a comma-separated list field on the EnterpriseCustomer where we can specify \"excluded modes\", which could also make the code simpler and remove the need for that setting."}}
{"actor":{"display_login":"bradenmacdonald"}}