{"action":"created","issue":{"url":"https://api.github.com/repos/namhyung/uftrace/issues/187","repository_url":"https://api.github.com/repos/namhyung/uftrace","labels_url":"https://api.github.com/repos/namhyung/uftrace/issues/187/labels{/name}","comments_url":"https://api.github.com/repos/namhyung/uftrace/issues/187/comments","events_url":"https://api.github.com/repos/namhyung/uftrace/issues/187/events","html_url":"https://github.com/namhyung/uftrace/issues/187","id":267290372,"number":187,"title":"reserved identifier violation","user":{"login":"elfring","id":660477,"avatar_url":"https://avatars1.githubusercontent.com/u/660477?v=4","gravatar_id":"","url":"https://api.github.com/users/elfring","html_url":"https://github.com/elfring","followers_url":"https://api.github.com/users/elfring/followers","following_url":"https://api.github.com/users/elfring/following{/other_user}","gists_url":"https://api.github.com/users/elfring/gists{/gist_id}","starred_url":"https://api.github.com/users/elfring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elfring/subscriptions","organizations_url":"https://api.github.com/users/elfring/orgs","repos_url":"https://api.github.com/users/elfring/repos","events_url":"https://api.github.com/users/elfring/events{/privacy}","received_events_url":"https://api.github.com/users/elfring/received_events","type":"User","site_admin":false},"labels":[{"id":718627690,"url":"https://api.github.com/repos/namhyung/uftrace/labels/help%20wanted","name":"help wanted","color":"0e8a16","default":true}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2017-10-20T20:05:02Z","updated_at":"2017-11-24T07:58:37Z","closed_at":"2017-11-16T10:48:44Z","author_association":"NONE","body":"I would like to point out that identifiers like “[`__UFTRACE_H__`](https://github.com/namhyung/uftrace/blob/bf488d9bcaf9ca109c755468c8332be406710cee/uftrace.h#L1 \"Update candidate\")” and “[`__FTRACE_UTILS_H__`](https://github.com/namhyung/uftrace/blob/66d5e54ce3f132a962ef30747ad6c1d212297f9c/utils/utils.h#L9 \"Another update candidate\")” [do not fit](https://www.securecoding.cert.org/confluence/display/cplusplus/DCL51-CPP.+Do+not+declare+or+define+a+reserved+identifier#DCL51-CPP.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29 \"Do not declare an identifier which is reserved for the compiler implementation.\") to the expected naming convention of the C++ language standard.\r\nWould you like to adjust your selection for unique names?"},"comment":{"url":"https://api.github.com/repos/namhyung/uftrace/issues/comments/346764769","html_url":"https://github.com/namhyung/uftrace/issues/187#issuecomment-346764769","issue_url":"https://api.github.com/repos/namhyung/uftrace/issues/187","id":346764769,"user":{"login":"elfring","id":660477,"avatar_url":"https://avatars1.githubusercontent.com/u/660477?v=4","gravatar_id":"","url":"https://api.github.com/users/elfring","html_url":"https://github.com/elfring","followers_url":"https://api.github.com/users/elfring/followers","following_url":"https://api.github.com/users/elfring/following{/other_user}","gists_url":"https://api.github.com/users/elfring/gists{/gist_id}","starred_url":"https://api.github.com/users/elfring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elfring/subscriptions","organizations_url":"https://api.github.com/users/elfring/orgs","repos_url":"https://api.github.com/users/elfring/repos","events_url":"https://api.github.com/users/elfring/events{/privacy}","received_events_url":"https://api.github.com/users/elfring/received_events","type":"User","site_admin":false},"created_at":"2017-11-24T07:58:37Z","updated_at":"2017-11-24T07:58:37Z","author_association":"NONE","body":"How do you think about to avoid that this software [depends on undefined behaviour](https://www.securecoding.cert.org/confluence/display/c/CC.+Undefined+Behavior#CC.UndefinedBehavior-ub_106 \"Avoiding undefined behaviour?\")?"}}
{"actor":{"display_login":"elfring"}}