{"action":"created","comment":{"url":"https://api.github.com/repos/jesperfj/force-rest-api/pulls/comments/102811965","pull_request_review_id":23580414,"id":102811965,"diff_hunk":"@@ -0,0 +1,95 @@\n+package com.force.api;\n+\n+\n+/**\n+ * represents a single supported API version as reported by the <code>/services/data</code> resource\n+ * for the instance endpoint returned on authentication.\n+ *\n+ * {@link com.frejo.api.ApiVersion} was originally used to set the current API version and manage the complete list\n+ * of versions as an enum. It will likely be phased out in favor of using plain version strings along with this class\n+ * for more extended version information.\n+ *\n+ * This is a tweak to an original proposal by @cswendrowski.\n+ *\n+ */\n+public class ExtendedApiVersion implements Comparable<ExtendedApiVersion> {\n+\n+    public enum Season {\n+        WINTER(),\n+        SPRING(),\n+        SUMMER();\n+    }\n+\n+    public ExtendedApiVersion() {}\n+\n+    public ExtendedApiVersion(float version) {\n+        this.version = version;\n+    }\n+\n+    public ExtendedApiVersion(Season s, int y) {","path":"src/main/java/com/force/api/ExtendedApiVersion.java","position":29,"original_position":29,"commit_id":"b858022eee8345eacc31b4b7cea08fd70b7dca0e","original_commit_id":"01f67ff5e7d1dc869dc9463e9596ec387bff5936","user":{"login":"jesperfj","id":283820,"avatar_url":"https://avatars.githubusercontent.com/u/283820?v=3","gravatar_id":"","url":"https://api.github.com/users/jesperfj","html_url":"https://github.com/jesperfj","followers_url":"https://api.github.com/users/jesperfj/followers","following_url":"https://api.github.com/users/jesperfj/following{/other_user}","gists_url":"https://api.github.com/users/jesperfj/gists{/gist_id}","starred_url":"https://api.github.com/users/jesperfj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jesperfj/subscriptions","organizations_url":"https://api.github.com/users/jesperfj/orgs","repos_url":"https://api.github.com/users/jesperfj/repos","events_url":"https://api.github.com/users/jesperfj/events{/privacy}","received_events_url":"https://api.github.com/users/jesperfj/received_events","type":"User","site_admin":false},"body":"Good point. I'll update in master and it'll make its way into a future release","created_at":"2017-02-23T20:37:03Z","updated_at":"2017-02-23T20:37:03Z","html_url":"https://github.com/jesperfj/force-rest-api/pull/40#discussion_r102811965","pull_request_url":"https://api.github.com/repos/jesperfj/force-rest-api/pulls/40","_links":{"self":{"href":"https://api.github.com/repos/jesperfj/force-rest-api/pulls/comments/102811965"},"html":{"href":"https://github.com/jesperfj/force-rest-api/pull/40#discussion_r102811965"},"pull_request":{"href":"https://api.github.com/repos/jesperfj/force-rest-api/pulls/40"}}},"pull_request":{"url":"https://api.github.com/repos/jesperfj/force-rest-api/pulls/40","id":107559317,"html_url":"https://github.com/jesperfj/force-rest-api/pull/40","diff_url":"https://github.com/jesperfj/force-rest-api/pull/40.diff","patch_url":"https://github.com/jesperfj/force-rest-api/pull/40.patch","issue_url":"https://api.github.com/repos/jesperfj/force-rest-api/issues/40","number":40,"state":"closed","locked":false,"title":"New version features","user":{"login":"jesperfj","id":283820,"avatar_url":"https://avatars.githubusercontent.com/u/283820?v=3","gravatar_id":"","url":"https://api.github.com/users/jesperfj","html_url":"https://github.com/jesperfj","followers_url":"https://api.github.com/users/jesperfj/followers","following_url":"https://api.github.com/users/jesperfj/following{/other_user}","gists_url":"https://api.github.com/users/jesperfj/gists{/gist_id}","starred_url":"https://api.github.com/users/jesperfj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jesperfj/subscriptions","organizations_url":"https://api.github.com/users/jesperfj/orgs","repos_url":"https://api.github.com/users/jesperfj/repos","events_url":"https://api.github.com/users/jesperfj/events{/privacy}","received_events_url":"https://api.github.com/users/jesperfj/received_events","type":"User","site_admin":false},"body":"This is a tweak to #39 proposed by @cswendrowski. As stated in commit:\r\n\r\nRenamed VersionRepresentation to ExtendedApiVersion. The\r\nXXXRepresentation naming scheme didn't really apply to this class.\r\nIt's called \"Extended\" because it has more info about a version than\r\nApiVersion. I can see the library moving towards deprecating the original\r\nApiVersion enum and just using this class and plain string to set version.\r\n\r\nI also moved some convenience methods from ForceApi to the\r\nExtendedApiVersion and SupportedVersions classes to keep ForceApi neat\r\nand tidy.\r\n\r\n@cswendrowski: What do you think?\r\n\r\n\r\n","created_at":"2017-02-23T05:43:26Z","updated_at":"2017-02-23T20:37:03Z","closed_at":"2017-02-23T18:07:09Z","merged_at":"2017-02-23T18:07:09Z","merge_commit_sha":"67179ac84a0a32ccf3727137513205d3251fdf2a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/jesperfj/force-rest-api/pulls/40/commits","review_comments_url":"https://api.github.com/repos/jesperfj/force-rest-api/pulls/40/comments","review_comment_url":"https://api.github.com/repos/jesperfj/force-rest-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jesperfj/force-rest-api/issues/40/comments","statuses_url":"https://api.github.com/repos/jesperfj/force-rest-api/statuses/b858022eee8345eacc31b4b7cea08fd70b7dca0e","head":{"label":"jesperfj:cswendrowski-version-features","ref":"cswendrowski-version-features","sha":"b858022eee8345eacc31b4b7cea08fd70b7dca0e","user":{"login":"jesperfj","id":283820,"avatar_url":"https://avatars.githubusercontent.com/u/283820?v=3","gravatar_id":"","url":"https://api.github.com/users/jesperfj","html_url":"https://github.com/jesperfj","followers_url":"https://api.github.com/users/jesperfj/followers","following_url":"https://api.github.com/users/jesperfj/following{/other_user}","gists_url":"https://api.github.com/users/jesperfj/gists{/gist_id}","starred_url":"https://api.github.com/users/jesperfj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jesperfj/subscriptions","organizations_url":"https://api.github.com/users/jesperfj/orgs","repos_url":"https://api.github.com/users/jesperfj/repos","events_url":"https://api.github.com/users/jesperfj/events{/privacy}","received_events_url":"https://api.github.com/users/jesperfj/received_events","type":"User","site_admin":false},"repo":{"id":2743895,"name":"force-rest-api","full_name":"jesperfj/force-rest-api","owner":{"login":"jesperfj","id":283820,"avatar_url":"https://avatars.githubusercontent.com/u/283820?v=3","gravatar_id":"","url":"https://api.github.com/users/jesperfj","html_url":"https://github.com/jesperfj","followers_url":"https://api.github.com/users/jesperfj/followers","following_url":"https://api.github.com/users/jesperfj/following{/other_user}","gists_url":"https://api.github.com/users/jesperfj/gists{/gist_id}","starred_url":"https://api.github.com/users/jesperfj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jesperfj/subscriptions","organizations_url":"https://api.github.com/users/jesperfj/orgs","repos_url":"https://api.github.com/users/jesperfj/repos","events_url":"https://api.github.com/users/jesperfj/events{/privacy}","received_events_url":"https://api.github.com/users/jesperfj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jesperfj/force-rest-api","description":null,"fork":false,"url":"https://api.github.com/repos/jesperfj/force-rest-api","forks_url":"https://api.github.com/repos/jesperfj/force-rest-api/forks","keys_url":"https://api.github.com/repos/jesperfj/force-rest-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jesperfj/force-rest-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jesperfj/force-rest-api/teams","hooks_url":"https://api.github.com/repos/jesperfj/force-rest-api/hooks","issue_events_url":"https://api.github.com/repos/jesperfj/force-rest-api/issues/events{/number}","events_url":"https://api.github.com/repos/jesperfj/force-rest-api/events","assignees_url":"https://api.github.com/repos/jesperfj/force-rest-api/assignees{/user}","branches_url":"https://api.github.com/repos/jesperfj/force-rest-api/branches{/branch}","tags_url":"https://api.github.com/repos/jesperfj/force-rest-api/tags","blobs_url":"https://api.github.com/repos/jesperfj/force-rest-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jesperfj/force-rest-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jesperfj/force-rest-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/jesperfj/force-rest-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jesperfj/force-rest-api/statuses/{sha}","languages_url":"https://api.github.com/repos/jesperfj/force-rest-api/languages","stargazers_url":"https://api.github.com/repos/jesperfj/force-rest-api/stargazers","contributors_url":"https://api.github.com/repos/jesperfj/force-rest-api/contributors","subscribers_url":"https://api.github.com/repos/jesperfj/force-rest-api/subscribers","subscription_url":"https://api.github.com/repos/jesperfj/force-rest-api/subscription","commits_url":"https://api.github.com/repos/jesperfj/force-rest-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/jesperfj/force-rest-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/jesperfj/force-rest-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/jesperfj/force-rest-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/jesperfj/force-rest-api/contents/{+path}","compare_url":"https://api.github.com/repos/jesperfj/force-rest-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jesperfj/force-rest-api/merges","archive_url":"https://api.github.com/repos/jesperfj/force-rest-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jesperfj/force-rest-api/downloads","issues_url":"https://api.github.com/repos/jesperfj/force-rest-api/issues{/number}","pulls_url":"https://api.github.com/repos/jesperfj/force-rest-api/pulls{/number}","milestones_url":"https://api.github.com/repos/jesperfj/force-rest-api/milestones{/number}","notifications_url":"https://api.github.com/repos/jesperfj/force-rest-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jesperfj/force-rest-api/labels{/name}","releases_url":"https://api.github.com/repos/jesperfj/force-rest-api/releases{/id}","deployments_url":"https://api.github.com/repos/jesperfj/force-rest-api/deployments","created_at":"2011-11-09T19:31:14Z","updated_at":"2017-02-13T19:34:09Z","pushed_at":"2017-02-23T20:35:37Z","git_url":"git://github.com/jesperfj/force-rest-api.git","ssh_url":"git@github.com:jesperfj/force-rest-api.git","clone_url":"https://github.com/jesperfj/force-rest-api.git","svn_url":"https://github.com/jesperfj/force-rest-api","homepage":"","size":1012,"stargazers_count":55,"watchers_count":55,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":58,"mirror_url":null,"open_issues_count":8,"forks":58,"open_issues":8,"watchers":55,"default_branch":"master"}},"base":{"label":"jesperfj:master","ref":"master","sha":"d06af2cc1655f60b0da4f996b92ecd89b9a4e665","user":{"login":"jesperfj","id":283820,"avatar_url":"https://avatars.githubusercontent.com/u/283820?v=3","gravatar_id":"","url":"https://api.github.com/users/jesperfj","html_url":"https://github.com/jesperfj","followers_url":"https://api.github.com/users/jesperfj/followers","following_url":"https://api.github.com/users/jesperfj/following{/other_user}","gists_url":"https://api.github.com/users/jesperfj/gists{/gist_id}","starred_url":"https://api.github.com/users/jesperfj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jesperfj/subscriptions","organizations_url":"https://api.github.com/users/jesperfj/orgs","repos_url":"https://api.github.com/users/jesperfj/repos","events_url":"https://api.github.com/users/jesperfj/events{/privacy}","received_events_url":"https://api.github.com/users/jesperfj/received_events","type":"User","site_admin":false},"repo":{"id":2743895,"name":"force-rest-api","full_name":"jesperfj/force-rest-api","owner":{"login":"jesperfj","id":283820,"avatar_url":"https://avatars.githubusercontent.com/u/283820?v=3","gravatar_id":"","url":"https://api.github.com/users/jesperfj","html_url":"https://github.com/jesperfj","followers_url":"https://api.github.com/users/jesperfj/followers","following_url":"https://api.github.com/users/jesperfj/following{/other_user}","gists_url":"https://api.github.com/users/jesperfj/gists{/gist_id}","starred_url":"https://api.github.com/users/jesperfj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jesperfj/subscriptions","organizations_url":"https://api.github.com/users/jesperfj/orgs","repos_url":"https://api.github.com/users/jesperfj/repos","events_url":"https://api.github.com/users/jesperfj/events{/privacy}","received_events_url":"https://api.github.com/users/jesperfj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jesperfj/force-rest-api","description":null,"fork":false,"url":"https://api.github.com/repos/jesperfj/force-rest-api","forks_url":"https://api.github.com/repos/jesperfj/force-rest-api/forks","keys_url":"https://api.github.com/repos/jesperfj/force-rest-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jesperfj/force-rest-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jesperfj/force-rest-api/teams","hooks_url":"https://api.github.com/repos/jesperfj/force-rest-api/hooks","issue_events_url":"https://api.github.com/repos/jesperfj/force-rest-api/issues/events{/number}","events_url":"https://api.github.com/repos/jesperfj/force-rest-api/events","assignees_url":"https://api.github.com/repos/jesperfj/force-rest-api/assignees{/user}","branches_url":"https://api.github.com/repos/jesperfj/force-rest-api/branches{/branch}","tags_url":"https://api.github.com/repos/jesperfj/force-rest-api/tags","blobs_url":"https://api.github.com/repos/jesperfj/force-rest-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jesperfj/force-rest-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jesperfj/force-rest-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/jesperfj/force-rest-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jesperfj/force-rest-api/statuses/{sha}","languages_url":"https://api.github.com/repos/jesperfj/force-rest-api/languages","stargazers_url":"https://api.github.com/repos/jesperfj/force-rest-api/stargazers","contributors_url":"https://api.github.com/repos/jesperfj/force-rest-api/contributors","subscribers_url":"https://api.github.com/repos/jesperfj/force-rest-api/subscribers","subscription_url":"https://api.github.com/repos/jesperfj/force-rest-api/subscription","commits_url":"https://api.github.com/repos/jesperfj/force-rest-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/jesperfj/force-rest-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/jesperfj/force-rest-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/jesperfj/force-rest-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/jesperfj/force-rest-api/contents/{+path}","compare_url":"https://api.github.com/repos/jesperfj/force-rest-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jesperfj/force-rest-api/merges","archive_url":"https://api.github.com/repos/jesperfj/force-rest-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jesperfj/force-rest-api/downloads","issues_url":"https://api.github.com/repos/jesperfj/force-rest-api/issues{/number}","pulls_url":"https://api.github.com/repos/jesperfj/force-rest-api/pulls{/number}","milestones_url":"https://api.github.com/repos/jesperfj/force-rest-api/milestones{/number}","notifications_url":"https://api.github.com/repos/jesperfj/force-rest-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jesperfj/force-rest-api/labels{/name}","releases_url":"https://api.github.com/repos/jesperfj/force-rest-api/releases{/id}","deployments_url":"https://api.github.com/repos/jesperfj/force-rest-api/deployments","created_at":"2011-11-09T19:31:14Z","updated_at":"2017-02-13T19:34:09Z","pushed_at":"2017-02-23T20:35:37Z","git_url":"git://github.com/jesperfj/force-rest-api.git","ssh_url":"git@github.com:jesperfj/force-rest-api.git","clone_url":"https://github.com/jesperfj/force-rest-api.git","svn_url":"https://github.com/jesperfj/force-rest-api","homepage":"","size":1012,"stargazers_count":55,"watchers_count":55,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":58,"mirror_url":null,"open_issues_count":8,"forks":58,"open_issues":8,"watchers":55,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jesperfj/force-rest-api/pulls/40"},"html":{"href":"https://github.com/jesperfj/force-rest-api/pull/40"},"issue":{"href":"https://api.github.com/repos/jesperfj/force-rest-api/issues/40"},"comments":{"href":"https://api.github.com/repos/jesperfj/force-rest-api/issues/40/comments"},"review_comments":{"href":"https://api.github.com/repos/jesperfj/force-rest-api/pulls/40/comments"},"review_comment":{"href":"https://api.github.com/repos/jesperfj/force-rest-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jesperfj/force-rest-api/pulls/40/commits"},"statuses":{"href":"https://api.github.com/repos/jesperfj/force-rest-api/statuses/b858022eee8345eacc31b4b7cea08fd70b7dca0e"}}}}
{"actor":{"display_login":"jesperfj"}}