{"action":"created","issue":{"url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/2870","repository_url":"https://api.github.com/repos/cfpb/cfgov-refresh","labels_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/2870/labels{/name}","comments_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/2870/comments","events_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/2870/events","html_url":"https://github.com/cfpb/cfgov-refresh/pull/2870","id":224228452,"number":2870,"title":"Set app namespaces in include_if_app_enabled","user":{"login":"willbarton","id":10562538,"avatar_url":"https://avatars3.githubusercontent.com/u/10562538?v=3","gravatar_id":"","url":"https://api.github.com/users/willbarton","html_url":"https://github.com/willbarton","followers_url":"https://api.github.com/users/willbarton/followers","following_url":"https://api.github.com/users/willbarton/following{/other_user}","gists_url":"https://api.github.com/users/willbarton/gists{/gist_id}","starred_url":"https://api.github.com/users/willbarton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willbarton/subscriptions","organizations_url":"https://api.github.com/users/willbarton/orgs","repos_url":"https://api.github.com/users/willbarton/repos","events_url":"https://api.github.com/users/willbarton/events{/privacy}","received_events_url":"https://api.github.com/users/willbarton/received_events","type":"User","site_admin":false},"labels":[{"id":429618409,"url":"https://api.github.com/repos/cfpb/cfgov-refresh/labels/hold","name":"hold","color":"b60205","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-04-25T18:18:06Z","updated_at":"2017-04-25T18:36:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/2870","html_url":"https://github.com/cfpb/cfgov-refresh/pull/2870","diff_url":"https://github.com/cfpb/cfgov-refresh/pull/2870.diff","patch_url":"https://github.com/cfpb/cfgov-refresh/pull/2870.patch"},"body":"We have the `include_if_app_enabled` function that we use to include satellite app URLs in `cfgov/urls.py` if the app is enabled. Some of our satellite's unit tests rely on URL namespacing to resolve their app's URLs. This change sets the namespace to the app name in the URL `include()` if the app is included.\r\n\r\nI've also written some tests for `include_if_app_enabled` while I was there.\r\n\r\nThis is part of GHE/CFGOV/platform/issues/798\r\n\r\n## Changes\r\n\r\n- Set an app's namespace in include_if_app_enabled\r\n\r\n## Checklist\r\n\r\n* [x] PR has an informative and human-readable title\r\n* [x] Changes are limited to a single goal (no scope creep)\r\n* [x] Code can be automatically merged (no conflicts)\r\n* [ ] Code follows the standards laid out in the [front end playbook](https://github.com/cfpb/front-end)\r\n* [x] Passes all existing automated tests\r\n* [x] New functions include new tests\r\n* [ ] New functions are documented (with a description, list of inputs, and expected output)\r\n* [ ] Placeholder code is flagged\r\n* [ ] Visually tested in supported browsers and devices\r\n* [ ] Project documentation has been updated\r\n* [x] Reviewers requested with the [Assignee tool](https://help.github.com/articles/assigning-issues-and-pull-requests-to-other-github-users/) :arrow_right:\r\n"},"comment":{"url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/comments/297125033","html_url":"https://github.com/cfpb/cfgov-refresh/pull/2870#issuecomment-297125033","issue_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/2870","id":297125033,"user":{"login":"willbarton","id":10562538,"avatar_url":"https://avatars3.githubusercontent.com/u/10562538?v=3","gravatar_id":"","url":"https://api.github.com/users/willbarton","html_url":"https://github.com/willbarton","followers_url":"https://api.github.com/users/willbarton/followers","following_url":"https://api.github.com/users/willbarton/following{/other_user}","gists_url":"https://api.github.com/users/willbarton/gists{/gist_id}","starred_url":"https://api.github.com/users/willbarton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willbarton/subscriptions","organizations_url":"https://api.github.com/users/willbarton/orgs","repos_url":"https://api.github.com/users/willbarton/repos","events_url":"https://api.github.com/users/willbarton/events{/privacy}","received_events_url":"https://api.github.com/users/willbarton/received_events","type":"User","site_admin":false},"created_at":"2017-04-25T18:36:16Z","updated_at":"2017-04-25T18:36:16Z","body":"I'm going to hold this for now — namespacing might not be the right approach to the test problem, but it would be good to have the tests merged in regardless. "}}
{"actor":{"display_login":"willbarton"}}