{"action":"created","issue":{"url":"https://api.github.com/repos/octokit/node-github/issues/650","repository_url":"https://api.github.com/repos/octokit/node-github","labels_url":"https://api.github.com/repos/octokit/node-github/issues/650/labels{/name}","comments_url":"https://api.github.com/repos/octokit/node-github/issues/650/comments","events_url":"https://api.github.com/repos/octokit/node-github/issues/650/events","html_url":"https://github.com/octokit/node-github/issues/650","id":275024173,"number":650,"title":"Handling Enterprise specific routes for GitHub Apps","user":{"login":"tcbyrd","id":13207348,"avatar_url":"https://avatars0.githubusercontent.com/u/13207348?v=4","gravatar_id":"","url":"https://api.github.com/users/tcbyrd","html_url":"https://github.com/tcbyrd","followers_url":"https://api.github.com/users/tcbyrd/followers","following_url":"https://api.github.com/users/tcbyrd/following{/other_user}","gists_url":"https://api.github.com/users/tcbyrd/gists{/gist_id}","starred_url":"https://api.github.com/users/tcbyrd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tcbyrd/subscriptions","organizations_url":"https://api.github.com/users/tcbyrd/orgs","repos_url":"https://api.github.com/users/tcbyrd/repos","events_url":"https://api.github.com/users/tcbyrd/events{/privacy}","received_events_url":"https://api.github.com/users/tcbyrd/received_events","type":"User","site_admin":true},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-11-17T23:13:09Z","updated_at":"2017-11-20T03:31:11Z","closed_at":null,"author_association":"NONE","body":"Due to a need to avoid route conflicts with customers that have Organizations in GHE called `/apps`, once Apps ships in Enterprise, the route will be:\r\n\r\n`http(s)://[hostname]/github-apps/[app]/`\r\n\r\ninstead of\r\n\r\n`https://github.com/apps/[app]`\r\n\r\nI think this means we'll need to add Enterprise specific logic for these routes:\r\n\r\nhttps://github.com/octokit/node-github/blob/072a53f6d8f5e8fe642284c13af93177def6abbe/lib/routes.json#L1079\r\nhttps://github.com/octokit/node-github/blob/072a53f6d8f5e8fe642284c13af93177def6abbe/lib/routes.json#L1163\r\nhttps://github.com/octokit/node-github/blob/072a53f6d8f5e8fe642284c13af93177def6abbe/lib/routes.json#L1172\r\n\r\nI wasn't sure what the optimal way would be to implement, so I wanted to open this issue first so we can discuss. I'm happy to help test once we have release candidates of GHE with Apps enabled.\r\n"},"comment":{"url":"https://api.github.com/repos/octokit/node-github/issues/comments/345582465","html_url":"https://github.com/octokit/node-github/issues/650#issuecomment-345582465","issue_url":"https://api.github.com/repos/octokit/node-github/issues/650","id":345582465,"user":{"login":"gr2m","id":39992,"avatar_url":"https://avatars3.githubusercontent.com/u/39992?v=4","gravatar_id":"","url":"https://api.github.com/users/gr2m","html_url":"https://github.com/gr2m","followers_url":"https://api.github.com/users/gr2m/followers","following_url":"https://api.github.com/users/gr2m/following{/other_user}","gists_url":"https://api.github.com/users/gr2m/gists{/gist_id}","starred_url":"https://api.github.com/users/gr2m/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gr2m/subscriptions","organizations_url":"https://api.github.com/users/gr2m/orgs","repos_url":"https://api.github.com/users/gr2m/repos","events_url":"https://api.github.com/users/gr2m/events{/privacy}","received_events_url":"https://api.github.com/users/gr2m/received_events","type":"User","site_admin":false},"created_at":"2017-11-20T03:31:11Z","updated_at":"2017-11-20T03:31:11Z","author_association":"COLLABORATOR","body":"perfect, thanks for the heads-up @tcbyrd 👍 \r\n\r\nI think we shouldn’t be affected by the App installation routes that you open in the browser, `node-github` is only using the API endpoints for which I don’t think the conflict will apply? E.g. the full route for [`GET /app/installations`](https://developer.github.com/v3/apps/#find-installations) is `https://<host name>/api/v3/app/installations`. The route to an organization called `app` would be https://<host name>/api/v3/orgs/app`.\r\n\r\nOr am I missing something?"}}
{"actor":{"display_login":"gr2m"}}