{"action":"created","issue":{"url":"https://api.github.com/repos/mono/libgdiplus/issues/73","repository_url":"https://api.github.com/repos/mono/libgdiplus","labels_url":"https://api.github.com/repos/mono/libgdiplus/issues/73/labels{/name}","comments_url":"https://api.github.com/repos/mono/libgdiplus/issues/73/comments","events_url":"https://api.github.com/repos/mono/libgdiplus/issues/73/events","html_url":"https://github.com/mono/libgdiplus/pull/73","id":239991637,"number":73,"title":"Fix redefinition of non-GDI Windows basic types in win32structs.h","user":{"login":"hughbe","id":1275900,"avatar_url":"https://avatars0.githubusercontent.com/u/1275900?v=4","gravatar_id":"","url":"https://api.github.com/users/hughbe","html_url":"https://github.com/hughbe","followers_url":"https://api.github.com/users/hughbe/followers","following_url":"https://api.github.com/users/hughbe/following{/other_user}","gists_url":"https://api.github.com/users/hughbe/gists{/gist_id}","starred_url":"https://api.github.com/users/hughbe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hughbe/subscriptions","organizations_url":"https://api.github.com/users/hughbe/orgs","repos_url":"https://api.github.com/users/hughbe/repos","events_url":"https://api.github.com/users/hughbe/events{/privacy}","received_events_url":"https://api.github.com/users/hughbe/received_events","type":"User","site_admin":false},"labels":[{"id":358615265,"url":"https://api.github.com/repos/mono/libgdiplus/labels/cla-already-signed","name":"cla-already-signed","color":"009800","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2017-07-02T06:08:16Z","updated_at":"2017-07-19T12:00:04Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mono/libgdiplus/pulls/73","html_url":"https://github.com/mono/libgdiplus/pull/73","diff_url":"https://github.com/mono/libgdiplus/pull/73.diff","patch_url":"https://github.com/mono/libgdiplus/pull/73.patch"},"body":"This causes some of the unit tests to fail to compile on Windows:\r\n\r\n> c:\\users\\hugh\\documents\\github\\libgdiplus\\src\\win32structs.h(129): error C2371: 'TCHAR': redefinition; different basic types\r\n> c:\\program files (x86)\\windows kits\\10\\include\\10.0.15063.0\\ucrt\\tchar.h(180): note: see declaration of 'TCHAR'"},"comment":{"url":"https://api.github.com/repos/mono/libgdiplus/issues/comments/316363247","html_url":"https://github.com/mono/libgdiplus/pull/73#issuecomment-316363247","issue_url":"https://api.github.com/repos/mono/libgdiplus/issues/73","id":316363247,"user":{"login":"qmfrederik","id":9918129,"avatar_url":"https://avatars0.githubusercontent.com/u/9918129?v=4","gravatar_id":"","url":"https://api.github.com/users/qmfrederik","html_url":"https://github.com/qmfrederik","followers_url":"https://api.github.com/users/qmfrederik/followers","following_url":"https://api.github.com/users/qmfrederik/following{/other_user}","gists_url":"https://api.github.com/users/qmfrederik/gists{/gist_id}","starred_url":"https://api.github.com/users/qmfrederik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qmfrederik/subscriptions","organizations_url":"https://api.github.com/users/qmfrederik/orgs","repos_url":"https://api.github.com/users/qmfrederik/repos","events_url":"https://api.github.com/users/qmfrederik/events{/privacy}","received_events_url":"https://api.github.com/users/qmfrederik/received_events","type":"User","site_admin":false},"created_at":"2017-07-19T12:00:04Z","updated_at":"2017-07-19T12:00:04Z","body":"@hughbe Got it. Yeah, you can either create a `.vcxproj` file for each test - that would be closes to what's done in the Unix world.\r\n\r\nAlternatively, you could try something like having one test executable, where you pass the name of the test as a command line argument.\r\n\r\nFor each test, you could rename the `main` method if being compiled as part of a `vcxprpoj` - for example by detecting `_MSC_VER` or a preprocessor variable you define on your own.\r\n\r\n```\r\nint\r\n#if _MSC_VER\r\ntest_name_main (int argc, char **argv)\r\n#else\r\nmain (int argc, char **argv)\r\n{\r\n#endif\r\n```\r\n\r\nIt's still not ideal but may be a starting point."}}
{"actor":{"display_login":"qmfrederik"}}