{"action":"opened","number":10680,"pull_request":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/10680","id":125474349,"html_url":"https://github.com/highfidelity/hifi/pull/10680","diff_url":"https://github.com/highfidelity/hifi/pull/10680.diff","patch_url":"https://github.com/highfidelity/hifi/pull/10680.patch","issue_url":"https://api.github.com/repos/highfidelity/hifi/issues/10680","number":10680,"state":"open","locked":false,"title":"Small rendering improvements based on spectator-camera changes","user":{"login":"zfox23","id":3409031,"avatar_url":"https://avatars2.githubusercontent.com/u/3409031?v=3","gravatar_id":"","url":"https://api.github.com/users/zfox23","html_url":"https://github.com/zfox23","followers_url":"https://api.github.com/users/zfox23/followers","following_url":"https://api.github.com/users/zfox23/following{/other_user}","gists_url":"https://api.github.com/users/zfox23/gists{/gist_id}","starred_url":"https://api.github.com/users/zfox23/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zfox23/subscriptions","organizations_url":"https://api.github.com/users/zfox23/orgs","repos_url":"https://api.github.com/users/zfox23/repos","events_url":"https://api.github.com/users/zfox23/events{/privacy}","received_events_url":"https://api.github.com/users/zfox23/received_events","type":"User","site_admin":false},"body":"At @samcake's request, this PR takes some rendering changes present in PR #10678 (whose target is the `spectator-camera` branch) and applies them to the `master` branch. These changes reduce the system's dependency on the `FramebufferCache` singleton.\r\n\r\n**Test Plan:**\r\n- General rendering smoke test: go to `dev-welcome` and verify that everything renders as you'd expect both in desktop mode and in HMD.","created_at":"2017-06-13T22:20:53Z","updated_at":"2017-06-13T22:20:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[{"login":"samcake","id":2230265,"avatar_url":"https://avatars1.githubusercontent.com/u/2230265?v=3","gravatar_id":"","url":"https://api.github.com/users/samcake","html_url":"https://github.com/samcake","followers_url":"https://api.github.com/users/samcake/followers","following_url":"https://api.github.com/users/samcake/following{/other_user}","gists_url":"https://api.github.com/users/samcake/gists{/gist_id}","starred_url":"https://api.github.com/users/samcake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samcake/subscriptions","organizations_url":"https://api.github.com/users/samcake/orgs","repos_url":"https://api.github.com/users/samcake/repos","events_url":"https://api.github.com/users/samcake/events{/privacy}","received_events_url":"https://api.github.com/users/samcake/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/highfidelity/hifi/pulls/10680/commits","review_comments_url":"https://api.github.com/repos/highfidelity/hifi/pulls/10680/comments","review_comment_url":"https://api.github.com/repos/highfidelity/hifi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/highfidelity/hifi/issues/10680/comments","statuses_url":"https://api.github.com/repos/highfidelity/hifi/statuses/52ea7e799435dddd01ed81467482219f6065ba4c","head":{"label":"zfox23:ZachRenderingImprovements1","ref":"ZachRenderingImprovements1","sha":"52ea7e799435dddd01ed81467482219f6065ba4c","user":{"login":"zfox23","id":3409031,"avatar_url":"https://avatars2.githubusercontent.com/u/3409031?v=3","gravatar_id":"","url":"https://api.github.com/users/zfox23","html_url":"https://github.com/zfox23","followers_url":"https://api.github.com/users/zfox23/followers","following_url":"https://api.github.com/users/zfox23/following{/other_user}","gists_url":"https://api.github.com/users/zfox23/gists{/gist_id}","starred_url":"https://api.github.com/users/zfox23/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zfox23/subscriptions","organizations_url":"https://api.github.com/users/zfox23/orgs","repos_url":"https://api.github.com/users/zfox23/repos","events_url":"https://api.github.com/users/zfox23/events{/privacy}","received_events_url":"https://api.github.com/users/zfox23/received_events","type":"User","site_admin":false},"repo":{"id":72575800,"name":"hifi","full_name":"zfox23/hifi","owner":{"login":"zfox23","id":3409031,"avatar_url":"https://avatars2.githubusercontent.com/u/3409031?v=3","gravatar_id":"","url":"https://api.github.com/users/zfox23","html_url":"https://github.com/zfox23","followers_url":"https://api.github.com/users/zfox23/followers","following_url":"https://api.github.com/users/zfox23/following{/other_user}","gists_url":"https://api.github.com/users/zfox23/gists{/gist_id}","starred_url":"https://api.github.com/users/zfox23/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zfox23/subscriptions","organizations_url":"https://api.github.com/users/zfox23/orgs","repos_url":"https://api.github.com/users/zfox23/repos","events_url":"https://api.github.com/users/zfox23/events{/privacy}","received_events_url":"https://api.github.com/users/zfox23/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zfox23/hifi","description":"Open source software for shared virtual worlds using HMDs and dynamically assigned devices as servers.  San Francisco based startup, we are hiring: http://highfidelity.com/jobs  Documentation at http://docs.highfidelity.com  Contribute by reporting bugs & doing jobs on http://worklist.net","fork":true,"url":"https://api.github.com/repos/zfox23/hifi","forks_url":"https://api.github.com/repos/zfox23/hifi/forks","keys_url":"https://api.github.com/repos/zfox23/hifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zfox23/hifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zfox23/hifi/teams","hooks_url":"https://api.github.com/repos/zfox23/hifi/hooks","issue_events_url":"https://api.github.com/repos/zfox23/hifi/issues/events{/number}","events_url":"https://api.github.com/repos/zfox23/hifi/events","assignees_url":"https://api.github.com/repos/zfox23/hifi/assignees{/user}","branches_url":"https://api.github.com/repos/zfox23/hifi/branches{/branch}","tags_url":"https://api.github.com/repos/zfox23/hifi/tags","blobs_url":"https://api.github.com/repos/zfox23/hifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zfox23/hifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zfox23/hifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/zfox23/hifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zfox23/hifi/statuses/{sha}","languages_url":"https://api.github.com/repos/zfox23/hifi/languages","stargazers_url":"https://api.github.com/repos/zfox23/hifi/stargazers","contributors_url":"https://api.github.com/repos/zfox23/hifi/contributors","subscribers_url":"https://api.github.com/repos/zfox23/hifi/subscribers","subscription_url":"https://api.github.com/repos/zfox23/hifi/subscription","commits_url":"https://api.github.com/repos/zfox23/hifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/zfox23/hifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/zfox23/hifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/zfox23/hifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/zfox23/hifi/contents/{+path}","compare_url":"https://api.github.com/repos/zfox23/hifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zfox23/hifi/merges","archive_url":"https://api.github.com/repos/zfox23/hifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zfox23/hifi/downloads","issues_url":"https://api.github.com/repos/zfox23/hifi/issues{/number}","pulls_url":"https://api.github.com/repos/zfox23/hifi/pulls{/number}","milestones_url":"https://api.github.com/repos/zfox23/hifi/milestones{/number}","notifications_url":"https://api.github.com/repos/zfox23/hifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zfox23/hifi/labels{/name}","releases_url":"https://api.github.com/repos/zfox23/hifi/releases{/id}","deployments_url":"https://api.github.com/repos/zfox23/hifi/deployments","created_at":"2016-11-01T20:54:04Z","updated_at":"2016-11-01T20:54:14Z","pushed_at":"2017-06-13T22:19:39Z","git_url":"git://github.com/zfox23/hifi.git","ssh_url":"git@github.com:zfox23/hifi.git","clone_url":"https://github.com/zfox23/hifi.git","svn_url":"https://github.com/zfox23/hifi","homepage":"","size":358464,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"highfidelity:master","ref":"master","sha":"ae81738f1f651d8c0512eff49916c51b410cdb43","user":{"login":"highfidelity","id":1565370,"avatar_url":"https://avatars3.githubusercontent.com/u/1565370?v=3","gravatar_id":"","url":"https://api.github.com/users/highfidelity","html_url":"https://github.com/highfidelity","followers_url":"https://api.github.com/users/highfidelity/followers","following_url":"https://api.github.com/users/highfidelity/following{/other_user}","gists_url":"https://api.github.com/users/highfidelity/gists{/gist_id}","starred_url":"https://api.github.com/users/highfidelity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highfidelity/subscriptions","organizations_url":"https://api.github.com/users/highfidelity/orgs","repos_url":"https://api.github.com/users/highfidelity/repos","events_url":"https://api.github.com/users/highfidelity/events{/privacy}","received_events_url":"https://api.github.com/users/highfidelity/received_events","type":"Organization","site_admin":false},"repo":{"id":5372872,"name":"hifi","full_name":"highfidelity/hifi","owner":{"login":"highfidelity","id":1565370,"avatar_url":"https://avatars3.githubusercontent.com/u/1565370?v=3","gravatar_id":"","url":"https://api.github.com/users/highfidelity","html_url":"https://github.com/highfidelity","followers_url":"https://api.github.com/users/highfidelity/followers","following_url":"https://api.github.com/users/highfidelity/following{/other_user}","gists_url":"https://api.github.com/users/highfidelity/gists{/gist_id}","starred_url":"https://api.github.com/users/highfidelity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highfidelity/subscriptions","organizations_url":"https://api.github.com/users/highfidelity/orgs","repos_url":"https://api.github.com/users/highfidelity/repos","events_url":"https://api.github.com/users/highfidelity/events{/privacy}","received_events_url":"https://api.github.com/users/highfidelity/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/highfidelity/hifi","description":"Open source client/server software for creating shared VR environments.  Docs at http://wiki.highfidelity.com  We are hiring: http://highfidelity.com/jobs  Also, PT work available at http://worklist.net","fork":false,"url":"https://api.github.com/repos/highfidelity/hifi","forks_url":"https://api.github.com/repos/highfidelity/hifi/forks","keys_url":"https://api.github.com/repos/highfidelity/hifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/highfidelity/hifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/highfidelity/hifi/teams","hooks_url":"https://api.github.com/repos/highfidelity/hifi/hooks","issue_events_url":"https://api.github.com/repos/highfidelity/hifi/issues/events{/number}","events_url":"https://api.github.com/repos/highfidelity/hifi/events","assignees_url":"https://api.github.com/repos/highfidelity/hifi/assignees{/user}","branches_url":"https://api.github.com/repos/highfidelity/hifi/branches{/branch}","tags_url":"https://api.github.com/repos/highfidelity/hifi/tags","blobs_url":"https://api.github.com/repos/highfidelity/hifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/highfidelity/hifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/highfidelity/hifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/highfidelity/hifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/highfidelity/hifi/statuses/{sha}","languages_url":"https://api.github.com/repos/highfidelity/hifi/languages","stargazers_url":"https://api.github.com/repos/highfidelity/hifi/stargazers","contributors_url":"https://api.github.com/repos/highfidelity/hifi/contributors","subscribers_url":"https://api.github.com/repos/highfidelity/hifi/subscribers","subscription_url":"https://api.github.com/repos/highfidelity/hifi/subscription","commits_url":"https://api.github.com/repos/highfidelity/hifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/highfidelity/hifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/highfidelity/hifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/highfidelity/hifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/highfidelity/hifi/contents/{+path}","compare_url":"https://api.github.com/repos/highfidelity/hifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/highfidelity/hifi/merges","archive_url":"https://api.github.com/repos/highfidelity/hifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/highfidelity/hifi/downloads","issues_url":"https://api.github.com/repos/highfidelity/hifi/issues{/number}","pulls_url":"https://api.github.com/repos/highfidelity/hifi/pulls{/number}","milestones_url":"https://api.github.com/repos/highfidelity/hifi/milestones{/number}","notifications_url":"https://api.github.com/repos/highfidelity/hifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/highfidelity/hifi/labels{/name}","releases_url":"https://api.github.com/repos/highfidelity/hifi/releases{/id}","deployments_url":"https://api.github.com/repos/highfidelity/hifi/deployments","created_at":"2012-08-10T18:26:22Z","updated_at":"2017-06-12T04:45:32Z","pushed_at":"2017-06-13T22:01:26Z","git_url":"git://github.com/highfidelity/hifi.git","ssh_url":"git@github.com:highfidelity/hifi.git","clone_url":"https://github.com/highfidelity/hifi.git","svn_url":"https://github.com/highfidelity/hifi","homepage":"","size":358958,"stargazers_count":522,"watchers_count":522,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":330,"mirror_url":null,"open_issues_count":120,"forks":330,"open_issues":120,"watchers":522,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/10680"},"html":{"href":"https://github.com/highfidelity/hifi/pull/10680"},"issue":{"href":"https://api.github.com/repos/highfidelity/hifi/issues/10680"},"comments":{"href":"https://api.github.com/repos/highfidelity/hifi/issues/10680/comments"},"review_comments":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/10680/comments"},"review_comment":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/10680/commits"},"statuses":{"href":"https://api.github.com/repos/highfidelity/hifi/statuses/52ea7e799435dddd01ed81467482219f6065ba4c"}},"merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":9,"deletions":16,"changed_files":4}}
{"actor":{"display_login":"zfox23"}}