{"action":"created","issue":{"url":"https://api.github.com/repos/alphagov/licence-finder/issues/113","repository_url":"https://api.github.com/repos/alphagov/licence-finder","labels_url":"https://api.github.com/repos/alphagov/licence-finder/issues/113/labels{/name}","comments_url":"https://api.github.com/repos/alphagov/licence-finder/issues/113/comments","events_url":"https://api.github.com/repos/alphagov/licence-finder/issues/113/events","html_url":"https://github.com/alphagov/licence-finder/pull/113","id":255966548,"number":113,"title":"[WIP] Allow Elasticsearch URI","user":{"login":"surminus","id":5610276,"avatar_url":"https://avatars0.githubusercontent.com/u/5610276?v=4","gravatar_id":"","url":"https://api.github.com/users/surminus","html_url":"https://github.com/surminus","followers_url":"https://api.github.com/users/surminus/followers","following_url":"https://api.github.com/users/surminus/following{/other_user}","gists_url":"https://api.github.com/users/surminus/gists{/gist_id}","starred_url":"https://api.github.com/users/surminus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/surminus/subscriptions","organizations_url":"https://api.github.com/users/surminus/orgs","repos_url":"https://api.github.com/users/surminus/repos","events_url":"https://api.github.com/users/surminus/events{/privacy}","received_events_url":"https://api.github.com/users/surminus/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-09-07T14:56:54Z","updated_at":"2017-09-07T15:30:30Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/alphagov/licence-finder/pulls/113","html_url":"https://github.com/alphagov/licence-finder/pull/113","diff_url":"https://github.com/alphagov/licence-finder/pull/113.diff","patch_url":"https://github.com/alphagov/licence-finder/pull/113.patch"},"body":null},"comment":{"url":"https://api.github.com/repos/alphagov/licence-finder/issues/comments/327835879","html_url":"https://github.com/alphagov/licence-finder/pull/113#issuecomment-327835879","issue_url":"https://api.github.com/repos/alphagov/licence-finder/issues/113","id":327835879,"user":{"login":"cbaines","id":1130010,"avatar_url":"https://avatars1.githubusercontent.com/u/1130010?v=4","gravatar_id":"","url":"https://api.github.com/users/cbaines","html_url":"https://github.com/cbaines","followers_url":"https://api.github.com/users/cbaines/followers","following_url":"https://api.github.com/users/cbaines/following{/other_user}","gists_url":"https://api.github.com/users/cbaines/gists{/gist_id}","starred_url":"https://api.github.com/users/cbaines/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbaines/subscriptions","organizations_url":"https://api.github.com/users/cbaines/orgs","repos_url":"https://api.github.com/users/cbaines/repos","events_url":"https://api.github.com/users/cbaines/events{/privacy}","received_events_url":"https://api.github.com/users/cbaines/received_events","type":"User","site_admin":false},"created_at":"2017-09-07T15:30:30Z","updated_at":"2017-09-07T15:30:30Z","author_association":"CONTRIBUTOR","body":"> Thanks @cbaines, I've pushed an update which is a slightly different approach. What do you think? I'll try to add some tests for this.\r\n\r\nPersonally, I prefer your original approach. It's a bit more consistent with the configuration of other GOV.UK apps (which for better or worse, also use ERB/YAML), and is also more expressive, as you can set the Elasticsearch URI just by using the configuration file.\r\n\r\nI've tested this snippet locally, and I think its all that is required to make the config you had originally work, which would go here [1]: \r\n\r\n```ruby\r\n    client_config = HashWithIndifferentAccess.new(\r\n      YAML.load(ERB.new(File.read(config_path)).result)\r\n    )\r\n```\r\n\r\n1: https://github.com/alphagov/licence-finder/blob/master/lib/search.rb#L8"}}
{"actor":{"display_login":"cbaines"}}