{"action":"closed","number":679,"pull_request":{"url":"https://api.github.com/repos/mobify/platform-scaffold/pulls/679","id":123613425,"html_url":"https://github.com/mobify/platform-scaffold/pull/679","diff_url":"https://github.com/mobify/platform-scaffold/pull/679.diff","patch_url":"https://github.com/mobify/platform-scaffold/pull/679.patch","issue_url":"https://api.github.com/repos/mobify/platform-scaffold/issues/679","number":679,"state":"closed","locked":false,"title":"[Checkout Schema] move billingSameAsShipping key","user":{"login":"jnurse","id":1301857,"avatar_url":"https://avatars1.githubusercontent.com/u/1301857?v=3","gravatar_id":"","url":"https://api.github.com/users/jnurse","html_url":"https://github.com/jnurse","followers_url":"https://api.github.com/users/jnurse/followers","following_url":"https://api.github.com/users/jnurse/following{/other_user}","gists_url":"https://api.github.com/users/jnurse/gists{/gist_id}","starred_url":"https://api.github.com/users/jnurse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnurse/subscriptions","organizations_url":"https://api.github.com/users/jnurse/orgs","repos_url":"https://api.github.com/users/jnurse/repos","events_url":"https://api.github.com/users/jnurse/events{/privacy}","received_events_url":"https://api.github.com/users/jnurse/received_events","type":"User","site_admin":false},"body":"This PR moves the billingSameAsShipping key to the root of the checkout store.\r\n\r\n **JIRA**: https://mobify.atlassian.net/browse/WEBDATA-69\r\n **Linked PRs**: n/a\r\n\r\n## Changes\r\n- Renamed the billingSameAsShipping input to follow our naming conventions (ie. no underscores)\r\n- Moved billingSameAsShipping to the root of the checkout store (results, reducers, selectors updated)\r\n- Updated commands & actions to handle new location for billingSameAsShipping key\r\n- Created new selector for billing address initial values that combines billingAddress with billingSameAsShipping\r\n\r\n## How to test-drive this PR\r\n- Run `npm run dev`\r\n- Preview [Merlin's Potions](https://preview.mobify.com/?url=https%3A%2F%2Fwww.merlinspotions.com%2F&site_folder=https%3A%2F%2Flocalhost%3A8443%2Floader.js&disabled=0&domain=&scope=1)\r\n- add an item to the cart\r\n- proceed through the checkout \r\n- test placing an order with billing same as shipping and with billing different from shipping\r\n- repeat the steps using the [SFCC Site](https://preview.mobify.com/?url=https%3A%2F%2Fmobify-tech-prtnr-na03-dw.demandware.net%2Fon%2Fdemandware.store%2FSites-2017refresh-Site%2Fdefault%2FHome-Show&site_folder=https%3A%2F%2Flocalhost%3A8443%2Floader.js&disabled=0&domain=&scope=1)","created_at":"2017-06-01T23:17:08Z","updated_at":"2017-06-02T16:06:29Z","closed_at":"2017-06-02T16:06:29Z","merged_at":"2017-06-02T16:06:29Z","merge_commit_sha":"86a21af76d7a4c652c93d512cc9c3c28ff11ad44","assignee":null,"assignees":[],"requested_reviewers":[{"login":"DanielBrookRoberge","id":9043311,"avatar_url":"https://avatars2.githubusercontent.com/u/9043311?v=3","gravatar_id":"","url":"https://api.github.com/users/DanielBrookRoberge","html_url":"https://github.com/DanielBrookRoberge","followers_url":"https://api.github.com/users/DanielBrookRoberge/followers","following_url":"https://api.github.com/users/DanielBrookRoberge/following{/other_user}","gists_url":"https://api.github.com/users/DanielBrookRoberge/gists{/gist_id}","starred_url":"https://api.github.com/users/DanielBrookRoberge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanielBrookRoberge/subscriptions","organizations_url":"https://api.github.com/users/DanielBrookRoberge/orgs","repos_url":"https://api.github.com/users/DanielBrookRoberge/repos","events_url":"https://api.github.com/users/DanielBrookRoberge/events{/privacy}","received_events_url":"https://api.github.com/users/DanielBrookRoberge/received_events","type":"User","site_admin":false},{"login":"Cdok","id":16109837,"avatar_url":"https://avatars3.githubusercontent.com/u/16109837?v=3","gravatar_id":"","url":"https://api.github.com/users/Cdok","html_url":"https://github.com/Cdok","followers_url":"https://api.github.com/users/Cdok/followers","following_url":"https://api.github.com/users/Cdok/following{/other_user}","gists_url":"https://api.github.com/users/Cdok/gists{/gist_id}","starred_url":"https://api.github.com/users/Cdok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cdok/subscriptions","organizations_url":"https://api.github.com/users/Cdok/orgs","repos_url":"https://api.github.com/users/Cdok/repos","events_url":"https://api.github.com/users/Cdok/events{/privacy}","received_events_url":"https://api.github.com/users/Cdok/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/mobify/platform-scaffold/pulls/679/commits","review_comments_url":"https://api.github.com/repos/mobify/platform-scaffold/pulls/679/comments","review_comment_url":"https://api.github.com/repos/mobify/platform-scaffold/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mobify/platform-scaffold/issues/679/comments","statuses_url":"https://api.github.com/repos/mobify/platform-scaffold/statuses/055147a773e8a3423371e9c77ee89f957fb123da","head":{"label":"mobify:im-move-billing-same-as-shipping","ref":"im-move-billing-same-as-shipping","sha":"055147a773e8a3423371e9c77ee89f957fb123da","user":{"login":"mobify","id":73539,"avatar_url":"https://avatars3.githubusercontent.com/u/73539?v=3","gravatar_id":"","url":"https://api.github.com/users/mobify","html_url":"https://github.com/mobify","followers_url":"https://api.github.com/users/mobify/followers","following_url":"https://api.github.com/users/mobify/following{/other_user}","gists_url":"https://api.github.com/users/mobify/gists{/gist_id}","starred_url":"https://api.github.com/users/mobify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mobify/subscriptions","organizations_url":"https://api.github.com/users/mobify/orgs","repos_url":"https://api.github.com/users/mobify/repos","events_url":"https://api.github.com/users/mobify/events{/privacy}","received_events_url":"https://api.github.com/users/mobify/received_events","type":"Organization","site_admin":false},"repo":{"id":62259838,"name":"platform-scaffold","full_name":"mobify/platform-scaffold","owner":{"login":"mobify","id":73539,"avatar_url":"https://avatars3.githubusercontent.com/u/73539?v=3","gravatar_id":"","url":"https://api.github.com/users/mobify","html_url":"https://github.com/mobify","followers_url":"https://api.github.com/users/mobify/followers","following_url":"https://api.github.com/users/mobify/following{/other_user}","gists_url":"https://api.github.com/users/mobify/gists{/gist_id}","starred_url":"https://api.github.com/users/mobify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mobify/subscriptions","organizations_url":"https://api.github.com/users/mobify/orgs","repos_url":"https://api.github.com/users/mobify/repos","events_url":"https://api.github.com/users/mobify/events{/privacy}","received_events_url":"https://api.github.com/users/mobify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mobify/platform-scaffold","description":"👉  Starter kit for the Mobify Platform","fork":false,"url":"https://api.github.com/repos/mobify/platform-scaffold","forks_url":"https://api.github.com/repos/mobify/platform-scaffold/forks","keys_url":"https://api.github.com/repos/mobify/platform-scaffold/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mobify/platform-scaffold/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mobify/platform-scaffold/teams","hooks_url":"https://api.github.com/repos/mobify/platform-scaffold/hooks","issue_events_url":"https://api.github.com/repos/mobify/platform-scaffold/issues/events{/number}","events_url":"https://api.github.com/repos/mobify/platform-scaffold/events","assignees_url":"https://api.github.com/repos/mobify/platform-scaffold/assignees{/user}","branches_url":"https://api.github.com/repos/mobify/platform-scaffold/branches{/branch}","tags_url":"https://api.github.com/repos/mobify/platform-scaffold/tags","blobs_url":"https://api.github.com/repos/mobify/platform-scaffold/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mobify/platform-scaffold/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mobify/platform-scaffold/git/refs{/sha}","trees_url":"https://api.github.com/repos/mobify/platform-scaffold/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mobify/platform-scaffold/statuses/{sha}","languages_url":"https://api.github.com/repos/mobify/platform-scaffold/languages","stargazers_url":"https://api.github.com/repos/mobify/platform-scaffold/stargazers","contributors_url":"https://api.github.com/repos/mobify/platform-scaffold/contributors","subscribers_url":"https://api.github.com/repos/mobify/platform-scaffold/subscribers","subscription_url":"https://api.github.com/repos/mobify/platform-scaffold/subscription","commits_url":"https://api.github.com/repos/mobify/platform-scaffold/commits{/sha}","git_commits_url":"https://api.github.com/repos/mobify/platform-scaffold/git/commits{/sha}","comments_url":"https://api.github.com/repos/mobify/platform-scaffold/comments{/number}","issue_comment_url":"https://api.github.com/repos/mobify/platform-scaffold/issues/comments{/number}","contents_url":"https://api.github.com/repos/mobify/platform-scaffold/contents/{+path}","compare_url":"https://api.github.com/repos/mobify/platform-scaffold/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mobify/platform-scaffold/merges","archive_url":"https://api.github.com/repos/mobify/platform-scaffold/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mobify/platform-scaffold/downloads","issues_url":"https://api.github.com/repos/mobify/platform-scaffold/issues{/number}","pulls_url":"https://api.github.com/repos/mobify/platform-scaffold/pulls{/number}","milestones_url":"https://api.github.com/repos/mobify/platform-scaffold/milestones{/number}","notifications_url":"https://api.github.com/repos/mobify/platform-scaffold/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mobify/platform-scaffold/labels{/name}","releases_url":"https://api.github.com/repos/mobify/platform-scaffold/releases{/id}","deployments_url":"https://api.github.com/repos/mobify/platform-scaffold/deployments","created_at":"2016-06-29T21:42:48Z","updated_at":"2017-05-10T17:51:05Z","pushed_at":"2017-06-02T16:06:29Z","git_url":"git://github.com/mobify/platform-scaffold.git","ssh_url":"git@github.com:mobify/platform-scaffold.git","clone_url":"https://github.com/mobify/platform-scaffold.git","svn_url":"https://github.com/mobify/platform-scaffold","homepage":"https://www.merlinspotions.com","size":43686,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":12,"forks":1,"open_issues":12,"watchers":2,"default_branch":"develop"}},"base":{"label":"mobify:develop","ref":"develop","sha":"d5b9734943e9cde331e6b11402061eee8c9254fa","user":{"login":"mobify","id":73539,"avatar_url":"https://avatars3.githubusercontent.com/u/73539?v=3","gravatar_id":"","url":"https://api.github.com/users/mobify","html_url":"https://github.com/mobify","followers_url":"https://api.github.com/users/mobify/followers","following_url":"https://api.github.com/users/mobify/following{/other_user}","gists_url":"https://api.github.com/users/mobify/gists{/gist_id}","starred_url":"https://api.github.com/users/mobify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mobify/subscriptions","organizations_url":"https://api.github.com/users/mobify/orgs","repos_url":"https://api.github.com/users/mobify/repos","events_url":"https://api.github.com/users/mobify/events{/privacy}","received_events_url":"https://api.github.com/users/mobify/received_events","type":"Organization","site_admin":false},"repo":{"id":62259838,"name":"platform-scaffold","full_name":"mobify/platform-scaffold","owner":{"login":"mobify","id":73539,"avatar_url":"https://avatars3.githubusercontent.com/u/73539?v=3","gravatar_id":"","url":"https://api.github.com/users/mobify","html_url":"https://github.com/mobify","followers_url":"https://api.github.com/users/mobify/followers","following_url":"https://api.github.com/users/mobify/following{/other_user}","gists_url":"https://api.github.com/users/mobify/gists{/gist_id}","starred_url":"https://api.github.com/users/mobify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mobify/subscriptions","organizations_url":"https://api.github.com/users/mobify/orgs","repos_url":"https://api.github.com/users/mobify/repos","events_url":"https://api.github.com/users/mobify/events{/privacy}","received_events_url":"https://api.github.com/users/mobify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mobify/platform-scaffold","description":"👉  Starter kit for the Mobify Platform","fork":false,"url":"https://api.github.com/repos/mobify/platform-scaffold","forks_url":"https://api.github.com/repos/mobify/platform-scaffold/forks","keys_url":"https://api.github.com/repos/mobify/platform-scaffold/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mobify/platform-scaffold/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mobify/platform-scaffold/teams","hooks_url":"https://api.github.com/repos/mobify/platform-scaffold/hooks","issue_events_url":"https://api.github.com/repos/mobify/platform-scaffold/issues/events{/number}","events_url":"https://api.github.com/repos/mobify/platform-scaffold/events","assignees_url":"https://api.github.com/repos/mobify/platform-scaffold/assignees{/user}","branches_url":"https://api.github.com/repos/mobify/platform-scaffold/branches{/branch}","tags_url":"https://api.github.com/repos/mobify/platform-scaffold/tags","blobs_url":"https://api.github.com/repos/mobify/platform-scaffold/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mobify/platform-scaffold/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mobify/platform-scaffold/git/refs{/sha}","trees_url":"https://api.github.com/repos/mobify/platform-scaffold/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mobify/platform-scaffold/statuses/{sha}","languages_url":"https://api.github.com/repos/mobify/platform-scaffold/languages","stargazers_url":"https://api.github.com/repos/mobify/platform-scaffold/stargazers","contributors_url":"https://api.github.com/repos/mobify/platform-scaffold/contributors","subscribers_url":"https://api.github.com/repos/mobify/platform-scaffold/subscribers","subscription_url":"https://api.github.com/repos/mobify/platform-scaffold/subscription","commits_url":"https://api.github.com/repos/mobify/platform-scaffold/commits{/sha}","git_commits_url":"https://api.github.com/repos/mobify/platform-scaffold/git/commits{/sha}","comments_url":"https://api.github.com/repos/mobify/platform-scaffold/comments{/number}","issue_comment_url":"https://api.github.com/repos/mobify/platform-scaffold/issues/comments{/number}","contents_url":"https://api.github.com/repos/mobify/platform-scaffold/contents/{+path}","compare_url":"https://api.github.com/repos/mobify/platform-scaffold/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mobify/platform-scaffold/merges","archive_url":"https://api.github.com/repos/mobify/platform-scaffold/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mobify/platform-scaffold/downloads","issues_url":"https://api.github.com/repos/mobify/platform-scaffold/issues{/number}","pulls_url":"https://api.github.com/repos/mobify/platform-scaffold/pulls{/number}","milestones_url":"https://api.github.com/repos/mobify/platform-scaffold/milestones{/number}","notifications_url":"https://api.github.com/repos/mobify/platform-scaffold/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mobify/platform-scaffold/labels{/name}","releases_url":"https://api.github.com/repos/mobify/platform-scaffold/releases{/id}","deployments_url":"https://api.github.com/repos/mobify/platform-scaffold/deployments","created_at":"2016-06-29T21:42:48Z","updated_at":"2017-05-10T17:51:05Z","pushed_at":"2017-06-02T16:06:29Z","git_url":"git://github.com/mobify/platform-scaffold.git","ssh_url":"git@github.com:mobify/platform-scaffold.git","clone_url":"https://github.com/mobify/platform-scaffold.git","svn_url":"https://github.com/mobify/platform-scaffold","homepage":"https://www.merlinspotions.com","size":43686,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":12,"forks":1,"open_issues":12,"watchers":2,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/mobify/platform-scaffold/pulls/679"},"html":{"href":"https://github.com/mobify/platform-scaffold/pull/679"},"issue":{"href":"https://api.github.com/repos/mobify/platform-scaffold/issues/679"},"comments":{"href":"https://api.github.com/repos/mobify/platform-scaffold/issues/679/comments"},"review_comments":{"href":"https://api.github.com/repos/mobify/platform-scaffold/pulls/679/comments"},"review_comment":{"href":"https://api.github.com/repos/mobify/platform-scaffold/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mobify/platform-scaffold/pulls/679/commits"},"statuses":{"href":"https://api.github.com/repos/mobify/platform-scaffold/statuses/055147a773e8a3423371e9c77ee89f957fb123da"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"jnurse","id":1301857,"avatar_url":"https://avatars1.githubusercontent.com/u/1301857?v=3","gravatar_id":"","url":"https://api.github.com/users/jnurse","html_url":"https://github.com/jnurse","followers_url":"https://api.github.com/users/jnurse/followers","following_url":"https://api.github.com/users/jnurse/following{/other_user}","gists_url":"https://api.github.com/users/jnurse/gists{/gist_id}","starred_url":"https://api.github.com/users/jnurse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnurse/subscriptions","organizations_url":"https://api.github.com/users/jnurse/orgs","repos_url":"https://api.github.com/users/jnurse/repos","events_url":"https://api.github.com/users/jnurse/events{/privacy}","received_events_url":"https://api.github.com/users/jnurse/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":6,"additions":35,"deletions":16,"changed_files":11}}
{"actor":{"display_login":"jnurse"}}