{"action":"created","comment":{"url":"https://api.github.com/repos/patternfly/angular-patternfly/pulls/comments/112536165","pull_request_review_id":33859753,"id":112536165,"diff_hunk":"@@ -61,6 +62,11 @@ angular.module('patternfly.toolbars').component('pfToolbar', {\n       return ctrl.config.viewsConfig && (ctrl.config.viewsConfig.currentView === viewId);\n     }\n \n+    function isTableViewSelected () {\n+      return (ctrl.config.viewsConfig && (ctrl.config.viewsConfig.currentView === 'tableView')) ||\n+             (!ctrl.config.viewsConfig && ctrl.config.isTableView);\n+    }\n+","path":"src/toolbars/toolbar-component.js","position":25,"original_position":25,"commit_id":"883e6c05edc3c4d927bcfd3162ac93e4579d35f9","original_commit_id":"883e6c05edc3c4d927bcfd3162ac93e4579d35f9","user":{"login":"jeff-phillips-18","id":11633780,"avatar_url":"https://avatars2.githubusercontent.com/u/11633780?v=3","gravatar_id":"","url":"https://api.github.com/users/jeff-phillips-18","html_url":"https://github.com/jeff-phillips-18","followers_url":"https://api.github.com/users/jeff-phillips-18/followers","following_url":"https://api.github.com/users/jeff-phillips-18/following{/other_user}","gists_url":"https://api.github.com/users/jeff-phillips-18/gists{/gist_id}","starred_url":"https://api.github.com/users/jeff-phillips-18/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeff-phillips-18/subscriptions","organizations_url":"https://api.github.com/users/jeff-phillips-18/orgs","repos_url":"https://api.github.com/users/jeff-phillips-18/repos","events_url":"https://api.github.com/users/jeff-phillips-18/events{/privacy}","received_events_url":"https://api.github.com/users/jeff-phillips-18/received_events","type":"User","site_admin":false},"body":"More readable:\r\n\r\nreturn ctrl.config.viewsConfig ? (ctrl.config.viewsConfig.currentView === 'tableView') : ctrl.config.isTableView);","created_at":"2017-04-20T19:06:55Z","updated_at":"2017-04-20T19:06:55Z","html_url":"https://github.com/patternfly/angular-patternfly/pull/452#discussion_r112536165","pull_request_url":"https://api.github.com/repos/patternfly/angular-patternfly/pulls/452","_links":{"self":{"href":"https://api.github.com/repos/patternfly/angular-patternfly/pulls/comments/112536165"},"html":{"href":"https://github.com/patternfly/angular-patternfly/pull/452#discussion_r112536165"},"pull_request":{"href":"https://api.github.com/repos/patternfly/angular-patternfly/pulls/452"}}},"pull_request":{"url":"https://api.github.com/repos/patternfly/angular-patternfly/pulls/452","id":116613423,"html_url":"https://github.com/patternfly/angular-patternfly/pull/452","diff_url":"https://github.com/patternfly/angular-patternfly/pull/452.diff","patch_url":"https://github.com/patternfly/angular-patternfly/pull/452.patch","issue_url":"https://api.github.com/repos/patternfly/angular-patternfly/issues/452","number":452,"state":"open","locked":false,"title":"pfTableView Fixes","user":{"login":"dtaylor113","id":12733153,"avatar_url":"https://avatars1.githubusercontent.com/u/12733153?v=3","gravatar_id":"","url":"https://api.github.com/users/dtaylor113","html_url":"https://github.com/dtaylor113","followers_url":"https://api.github.com/users/dtaylor113/followers","following_url":"https://api.github.com/users/dtaylor113/following{/other_user}","gists_url":"https://api.github.com/users/dtaylor113/gists{/gist_id}","starred_url":"https://api.github.com/users/dtaylor113/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dtaylor113/subscriptions","organizations_url":"https://api.github.com/users/dtaylor113/orgs","repos_url":"https://api.github.com/users/dtaylor113/repos","events_url":"https://api.github.com/users/dtaylor113/events{/privacy}","received_events_url":"https://api.github.com/users/dtaylor113/received_events","type":"User","site_admin":false},"body":"Fixes #441 'pfTableView: error when items have more properties than the defined columns'\r\nFixes #440 'pfTableView: error when items array is empty'\r\nFixes #449 'pfTableView with toolbar - inconsistent with design'\r\n\r\n![image](https://cloud.githubusercontent.com/assets/12733153/25196017/5290bb5a-250d-11e7-9a88-46dc06886c76.png)\r\n\r\n**When no filter:**\r\n![image](https://cloud.githubusercontent.com/assets/12733153/25196039/5ffa8866-250d-11e7-9907-4445db559b0c.png)\r\n","created_at":"2017-04-19T18:35:43Z","updated_at":"2017-04-20T19:06:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"91785cf2c9d6b09c5df840b5c9d9057cfa323a8e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/patternfly/angular-patternfly/pulls/452/commits","review_comments_url":"https://api.github.com/repos/patternfly/angular-patternfly/pulls/452/comments","review_comment_url":"https://api.github.com/repos/patternfly/angular-patternfly/pulls/comments{/number}","comments_url":"https://api.github.com/repos/patternfly/angular-patternfly/issues/452/comments","statuses_url":"https://api.github.com/repos/patternfly/angular-patternfly/statuses/883e6c05edc3c4d927bcfd3162ac93e4579d35f9","head":{"label":"patternfly:pf-table-view","ref":"pf-table-view","sha":"883e6c05edc3c4d927bcfd3162ac93e4579d35f9","user":{"login":"patternfly","id":6391110,"avatar_url":"https://avatars0.githubusercontent.com/u/6391110?v=3","gravatar_id":"","url":"https://api.github.com/users/patternfly","html_url":"https://github.com/patternfly","followers_url":"https://api.github.com/users/patternfly/followers","following_url":"https://api.github.com/users/patternfly/following{/other_user}","gists_url":"https://api.github.com/users/patternfly/gists{/gist_id}","starred_url":"https://api.github.com/users/patternfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patternfly/subscriptions","organizations_url":"https://api.github.com/users/patternfly/orgs","repos_url":"https://api.github.com/users/patternfly/repos","events_url":"https://api.github.com/users/patternfly/events{/privacy}","received_events_url":"https://api.github.com/users/patternfly/received_events","type":"Organization","site_admin":false},"repo":{"id":17672427,"name":"angular-patternfly","full_name":"patternfly/angular-patternfly","owner":{"login":"patternfly","id":6391110,"avatar_url":"https://avatars0.githubusercontent.com/u/6391110?v=3","gravatar_id":"","url":"https://api.github.com/users/patternfly","html_url":"https://github.com/patternfly","followers_url":"https://api.github.com/users/patternfly/followers","following_url":"https://api.github.com/users/patternfly/following{/other_user}","gists_url":"https://api.github.com/users/patternfly/gists{/gist_id}","starred_url":"https://api.github.com/users/patternfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patternfly/subscriptions","organizations_url":"https://api.github.com/users/patternfly/orgs","repos_url":"https://api.github.com/users/patternfly/repos","events_url":"https://api.github.com/users/patternfly/events{/privacy}","received_events_url":"https://api.github.com/users/patternfly/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/patternfly/angular-patternfly","description":"A set of common AngularJS directives for use with the PatternFly reference implementation.","fork":false,"url":"https://api.github.com/repos/patternfly/angular-patternfly","forks_url":"https://api.github.com/repos/patternfly/angular-patternfly/forks","keys_url":"https://api.github.com/repos/patternfly/angular-patternfly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/patternfly/angular-patternfly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/patternfly/angular-patternfly/teams","hooks_url":"https://api.github.com/repos/patternfly/angular-patternfly/hooks","issue_events_url":"https://api.github.com/repos/patternfly/angular-patternfly/issues/events{/number}","events_url":"https://api.github.com/repos/patternfly/angular-patternfly/events","assignees_url":"https://api.github.com/repos/patternfly/angular-patternfly/assignees{/user}","branches_url":"https://api.github.com/repos/patternfly/angular-patternfly/branches{/branch}","tags_url":"https://api.github.com/repos/patternfly/angular-patternfly/tags","blobs_url":"https://api.github.com/repos/patternfly/angular-patternfly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/patternfly/angular-patternfly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/patternfly/angular-patternfly/git/refs{/sha}","trees_url":"https://api.github.com/repos/patternfly/angular-patternfly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/patternfly/angular-patternfly/statuses/{sha}","languages_url":"https://api.github.com/repos/patternfly/angular-patternfly/languages","stargazers_url":"https://api.github.com/repos/patternfly/angular-patternfly/stargazers","contributors_url":"https://api.github.com/repos/patternfly/angular-patternfly/contributors","subscribers_url":"https://api.github.com/repos/patternfly/angular-patternfly/subscribers","subscription_url":"https://api.github.com/repos/patternfly/angular-patternfly/subscription","commits_url":"https://api.github.com/repos/patternfly/angular-patternfly/commits{/sha}","git_commits_url":"https://api.github.com/repos/patternfly/angular-patternfly/git/commits{/sha}","comments_url":"https://api.github.com/repos/patternfly/angular-patternfly/comments{/number}","issue_comment_url":"https://api.github.com/repos/patternfly/angular-patternfly/issues/comments{/number}","contents_url":"https://api.github.com/repos/patternfly/angular-patternfly/contents/{+path}","compare_url":"https://api.github.com/repos/patternfly/angular-patternfly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/patternfly/angular-patternfly/merges","archive_url":"https://api.github.com/repos/patternfly/angular-patternfly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/patternfly/angular-patternfly/downloads","issues_url":"https://api.github.com/repos/patternfly/angular-patternfly/issues{/number}","pulls_url":"https://api.github.com/repos/patternfly/angular-patternfly/pulls{/number}","milestones_url":"https://api.github.com/repos/patternfly/angular-patternfly/milestones{/number}","notifications_url":"https://api.github.com/repos/patternfly/angular-patternfly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/patternfly/angular-patternfly/labels{/name}","releases_url":"https://api.github.com/repos/patternfly/angular-patternfly/releases{/id}","deployments_url":"https://api.github.com/repos/patternfly/angular-patternfly/deployments","created_at":"2014-03-12T15:43:51Z","updated_at":"2017-04-20T14:19:41Z","pushed_at":"2017-04-20T19:02:21Z","git_url":"git://github.com/patternfly/angular-patternfly.git","ssh_url":"git@github.com:patternfly/angular-patternfly.git","clone_url":"https://github.com/patternfly/angular-patternfly.git","svn_url":"https://github.com/patternfly/angular-patternfly","homepage":"http://www.patternfly.org/angular-patternfly/","size":12379,"stargazers_count":84,"watchers_count":84,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":67,"mirror_url":null,"open_issues_count":47,"forks":67,"open_issues":47,"watchers":84,"default_branch":"master"}},"base":{"label":"patternfly:branch-4.0-dev","ref":"branch-4.0-dev","sha":"e1311877cfcb881b1fee77a11e9da4b735adc911","user":{"login":"patternfly","id":6391110,"avatar_url":"https://avatars0.githubusercontent.com/u/6391110?v=3","gravatar_id":"","url":"https://api.github.com/users/patternfly","html_url":"https://github.com/patternfly","followers_url":"https://api.github.com/users/patternfly/followers","following_url":"https://api.github.com/users/patternfly/following{/other_user}","gists_url":"https://api.github.com/users/patternfly/gists{/gist_id}","starred_url":"https://api.github.com/users/patternfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patternfly/subscriptions","organizations_url":"https://api.github.com/users/patternfly/orgs","repos_url":"https://api.github.com/users/patternfly/repos","events_url":"https://api.github.com/users/patternfly/events{/privacy}","received_events_url":"https://api.github.com/users/patternfly/received_events","type":"Organization","site_admin":false},"repo":{"id":17672427,"name":"angular-patternfly","full_name":"patternfly/angular-patternfly","owner":{"login":"patternfly","id":6391110,"avatar_url":"https://avatars0.githubusercontent.com/u/6391110?v=3","gravatar_id":"","url":"https://api.github.com/users/patternfly","html_url":"https://github.com/patternfly","followers_url":"https://api.github.com/users/patternfly/followers","following_url":"https://api.github.com/users/patternfly/following{/other_user}","gists_url":"https://api.github.com/users/patternfly/gists{/gist_id}","starred_url":"https://api.github.com/users/patternfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patternfly/subscriptions","organizations_url":"https://api.github.com/users/patternfly/orgs","repos_url":"https://api.github.com/users/patternfly/repos","events_url":"https://api.github.com/users/patternfly/events{/privacy}","received_events_url":"https://api.github.com/users/patternfly/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/patternfly/angular-patternfly","description":"A set of common AngularJS directives for use with the PatternFly reference implementation.","fork":false,"url":"https://api.github.com/repos/patternfly/angular-patternfly","forks_url":"https://api.github.com/repos/patternfly/angular-patternfly/forks","keys_url":"https://api.github.com/repos/patternfly/angular-patternfly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/patternfly/angular-patternfly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/patternfly/angular-patternfly/teams","hooks_url":"https://api.github.com/repos/patternfly/angular-patternfly/hooks","issue_events_url":"https://api.github.com/repos/patternfly/angular-patternfly/issues/events{/number}","events_url":"https://api.github.com/repos/patternfly/angular-patternfly/events","assignees_url":"https://api.github.com/repos/patternfly/angular-patternfly/assignees{/user}","branches_url":"https://api.github.com/repos/patternfly/angular-patternfly/branches{/branch}","tags_url":"https://api.github.com/repos/patternfly/angular-patternfly/tags","blobs_url":"https://api.github.com/repos/patternfly/angular-patternfly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/patternfly/angular-patternfly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/patternfly/angular-patternfly/git/refs{/sha}","trees_url":"https://api.github.com/repos/patternfly/angular-patternfly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/patternfly/angular-patternfly/statuses/{sha}","languages_url":"https://api.github.com/repos/patternfly/angular-patternfly/languages","stargazers_url":"https://api.github.com/repos/patternfly/angular-patternfly/stargazers","contributors_url":"https://api.github.com/repos/patternfly/angular-patternfly/contributors","subscribers_url":"https://api.github.com/repos/patternfly/angular-patternfly/subscribers","subscription_url":"https://api.github.com/repos/patternfly/angular-patternfly/subscription","commits_url":"https://api.github.com/repos/patternfly/angular-patternfly/commits{/sha}","git_commits_url":"https://api.github.com/repos/patternfly/angular-patternfly/git/commits{/sha}","comments_url":"https://api.github.com/repos/patternfly/angular-patternfly/comments{/number}","issue_comment_url":"https://api.github.com/repos/patternfly/angular-patternfly/issues/comments{/number}","contents_url":"https://api.github.com/repos/patternfly/angular-patternfly/contents/{+path}","compare_url":"https://api.github.com/repos/patternfly/angular-patternfly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/patternfly/angular-patternfly/merges","archive_url":"https://api.github.com/repos/patternfly/angular-patternfly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/patternfly/angular-patternfly/downloads","issues_url":"https://api.github.com/repos/patternfly/angular-patternfly/issues{/number}","pulls_url":"https://api.github.com/repos/patternfly/angular-patternfly/pulls{/number}","milestones_url":"https://api.github.com/repos/patternfly/angular-patternfly/milestones{/number}","notifications_url":"https://api.github.com/repos/patternfly/angular-patternfly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/patternfly/angular-patternfly/labels{/name}","releases_url":"https://api.github.com/repos/patternfly/angular-patternfly/releases{/id}","deployments_url":"https://api.github.com/repos/patternfly/angular-patternfly/deployments","created_at":"2014-03-12T15:43:51Z","updated_at":"2017-04-20T14:19:41Z","pushed_at":"2017-04-20T19:02:21Z","git_url":"git://github.com/patternfly/angular-patternfly.git","ssh_url":"git@github.com:patternfly/angular-patternfly.git","clone_url":"https://github.com/patternfly/angular-patternfly.git","svn_url":"https://github.com/patternfly/angular-patternfly","homepage":"http://www.patternfly.org/angular-patternfly/","size":12379,"stargazers_count":84,"watchers_count":84,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":67,"mirror_url":null,"open_issues_count":47,"forks":67,"open_issues":47,"watchers":84,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/patternfly/angular-patternfly/pulls/452"},"html":{"href":"https://github.com/patternfly/angular-patternfly/pull/452"},"issue":{"href":"https://api.github.com/repos/patternfly/angular-patternfly/issues/452"},"comments":{"href":"https://api.github.com/repos/patternfly/angular-patternfly/issues/452/comments"},"review_comments":{"href":"https://api.github.com/repos/patternfly/angular-patternfly/pulls/452/comments"},"review_comment":{"href":"https://api.github.com/repos/patternfly/angular-patternfly/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/patternfly/angular-patternfly/pulls/452/commits"},"statuses":{"href":"https://api.github.com/repos/patternfly/angular-patternfly/statuses/883e6c05edc3c4d927bcfd3162ac93e4579d35f9"}}}}
{"actor":{"display_login":"jeff-phillips-18"}}