{"action":"created","issue":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/10201","repository_url":"https://api.github.com/repos/bitcoin/bitcoin","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/10201/labels{/name}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/10201/comments","events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/10201/events","html_url":"https://github.com/bitcoin/bitcoin/pull/10201","id":221567849,"number":10201,"title":"pass Consensus::Params& to ReceivedBlockTransactions()","user":{"login":"mariodian","id":3636406,"avatar_url":"https://avatars3.githubusercontent.com/u/3636406?v=3","gravatar_id":"","url":"https://api.github.com/users/mariodian","html_url":"https://github.com/mariodian","followers_url":"https://api.github.com/users/mariodian/followers","following_url":"https://api.github.com/users/mariodian/following{/other_user}","gists_url":"https://api.github.com/users/mariodian/gists{/gist_id}","starred_url":"https://api.github.com/users/mariodian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mariodian/subscriptions","organizations_url":"https://api.github.com/users/mariodian/orgs","repos_url":"https://api.github.com/users/mariodian/repos","events_url":"https://api.github.com/users/mariodian/events{/privacy}","received_events_url":"https://api.github.com/users/mariodian/received_events","type":"User","site_admin":false},"labels":[{"id":118379652,"url":"https://api.github.com/repos/bitcoin/bitcoin/labels/Validation","name":"Validation","color":"6060aa","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2017-04-13T13:45:38Z","updated_at":"2017-04-20T21:38:36Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/10201","html_url":"https://github.com/bitcoin/bitcoin/pull/10201","diff_url":"https://github.com/bitcoin/bitcoin/pull/10201.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/10201.patch"},"body":"Pass Consensus::Params& to ReceivedBlockTransactions() as requested in #7829"},"comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments/295926132","html_url":"https://github.com/bitcoin/bitcoin/pull/10201#issuecomment-295926132","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/10201","id":295926132,"user":{"login":"jtimon","id":1008458,"avatar_url":"https://avatars0.githubusercontent.com/u/1008458?v=3","gravatar_id":"","url":"https://api.github.com/users/jtimon","html_url":"https://github.com/jtimon","followers_url":"https://api.github.com/users/jtimon/followers","following_url":"https://api.github.com/users/jtimon/following{/other_user}","gists_url":"https://api.github.com/users/jtimon/gists{/gist_id}","starred_url":"https://api.github.com/users/jtimon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtimon/subscriptions","organizations_url":"https://api.github.com/users/jtimon/orgs","repos_url":"https://api.github.com/users/jtimon/repos","events_url":"https://api.github.com/users/jtimon/events{/privacy}","received_events_url":"https://api.github.com/users/jtimon/received_events","type":"User","site_admin":false},"created_at":"2017-04-20T21:38:36Z","updated_at":"2017-04-20T21:38:36Z","body":"ACK 25660e91ef2d399d2db87edb2243122fd4093ede\r\nAdded to the list in #7829\r\nIf you feel like doing more functions in one go, maybe I can close #10227 (sorry I didn't see this before opening it, you need to \"ping @jtimon\" to get the promised review faster). Just by equaling it I would be more than happy to close #10227, but it occurs to me that I didn't do an exhaustive search on all the functions in validation.o that could be made static (independently on whether they use CChainParams or Consensus::Params or not). If you do that, I bet not only nobody will complain for increasing the scope of a PR with 3 acks but people will actually praise you (at least I will) for every new function that can be static you find apart from the 3 in #10227.\r\nI think it's also a more interesting and rewarding task than what #7829 proposes.\r\n"}}
{"actor":{"display_login":"jtimon"}}