{"action":"closed","number":5,"pull_request":{"url":"https://api.github.com/repos/gdkrmr/dimRed/pulls/5","id":104064624,"html_url":"https://github.com/gdkrmr/dimRed/pull/5","diff_url":"https://github.com/gdkrmr/dimRed/pull/5.diff","patch_url":"https://github.com/gdkrmr/dimRed/pull/5.patch","issue_url":"https://api.github.com/repos/gdkrmr/dimRed/issues/5","number":5,"state":"closed","locked":false,"title":"some Isomap procedural tweaks","user":{"login":"topepo","id":5731043,"avatar_url":"https://avatars.githubusercontent.com/u/5731043?v=3","gravatar_id":"","url":"https://api.github.com/users/topepo","html_url":"https://github.com/topepo","followers_url":"https://api.github.com/users/topepo/followers","following_url":"https://api.github.com/users/topepo/following{/other_user}","gists_url":"https://api.github.com/users/topepo/gists{/gist_id}","starred_url":"https://api.github.com/users/topepo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/topepo/subscriptions","organizations_url":"https://api.github.com/users/topepo/orgs","repos_url":"https://api.github.com/users/topepo/repos","events_url":"https://api.github.com/users/topepo/events{/privacy}","received_events_url":"https://api.github.com/users/topepo/received_events","type":"User","site_admin":false},"body":"* Added a `verbose` option and set to `TRUE`. This will be good once these get wrapped inside of  resampling routines\r\n* Added a cap on the number of neighbors. Otherwise, there is an error: \r\n```r\r\nError in RANN::nn2(data = x, query = x, k = k + 1, treetype = treetype,  : \r\n  Cannot find more nearest neighbours than there are points\r\n```\r\n\r\nFo the apply function, where you `rbind` the out of sample data with the training set, I used \r\n```r\r\nlknng <- makeKNNgraph(rbind(indata, orgdata),\r\n                      k = min(norg, pars$knn), eps = pars$eps)\r\n```\r\nbut that may not be the best idea (I have no idea). ","created_at":"2017-02-01T02:23:38Z","updated_at":"2017-02-07T16:57:29Z","closed_at":"2017-02-07T16:57:29Z","merged_at":null,"merge_commit_sha":"1cbec24ee621acecc778bc72bd35fe2ebc10ba2c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/gdkrmr/dimRed/pulls/5/commits","review_comments_url":"https://api.github.com/repos/gdkrmr/dimRed/pulls/5/comments","review_comment_url":"https://api.github.com/repos/gdkrmr/dimRed/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gdkrmr/dimRed/issues/5/comments","statuses_url":"https://api.github.com/repos/gdkrmr/dimRed/statuses/d2d8f9af35d53c29e7a4fba42c3f8b1ed94b38a9","head":{"label":"topepo:master","ref":"master","sha":"d2d8f9af35d53c29e7a4fba42c3f8b1ed94b38a9","user":{"login":"topepo","id":5731043,"avatar_url":"https://avatars.githubusercontent.com/u/5731043?v=3","gravatar_id":"","url":"https://api.github.com/users/topepo","html_url":"https://github.com/topepo","followers_url":"https://api.github.com/users/topepo/followers","following_url":"https://api.github.com/users/topepo/following{/other_user}","gists_url":"https://api.github.com/users/topepo/gists{/gist_id}","starred_url":"https://api.github.com/users/topepo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/topepo/subscriptions","organizations_url":"https://api.github.com/users/topepo/orgs","repos_url":"https://api.github.com/users/topepo/repos","events_url":"https://api.github.com/users/topepo/events{/privacy}","received_events_url":"https://api.github.com/users/topepo/received_events","type":"User","site_admin":false},"repo":{"id":79956424,"name":"dimRed","full_name":"topepo/dimRed","owner":{"login":"topepo","id":5731043,"avatar_url":"https://avatars.githubusercontent.com/u/5731043?v=3","gravatar_id":"","url":"https://api.github.com/users/topepo","html_url":"https://github.com/topepo","followers_url":"https://api.github.com/users/topepo/followers","following_url":"https://api.github.com/users/topepo/following{/other_user}","gists_url":"https://api.github.com/users/topepo/gists{/gist_id}","starred_url":"https://api.github.com/users/topepo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/topepo/subscriptions","organizations_url":"https://api.github.com/users/topepo/orgs","repos_url":"https://api.github.com/users/topepo/repos","events_url":"https://api.github.com/users/topepo/events{/privacy}","received_events_url":"https://api.github.com/users/topepo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/topepo/dimRed","description":"A Framework for Dimensionality Reduction","fork":true,"url":"https://api.github.com/repos/topepo/dimRed","forks_url":"https://api.github.com/repos/topepo/dimRed/forks","keys_url":"https://api.github.com/repos/topepo/dimRed/keys{/key_id}","collaborators_url":"https://api.github.com/repos/topepo/dimRed/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/topepo/dimRed/teams","hooks_url":"https://api.github.com/repos/topepo/dimRed/hooks","issue_events_url":"https://api.github.com/repos/topepo/dimRed/issues/events{/number}","events_url":"https://api.github.com/repos/topepo/dimRed/events","assignees_url":"https://api.github.com/repos/topepo/dimRed/assignees{/user}","branches_url":"https://api.github.com/repos/topepo/dimRed/branches{/branch}","tags_url":"https://api.github.com/repos/topepo/dimRed/tags","blobs_url":"https://api.github.com/repos/topepo/dimRed/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/topepo/dimRed/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/topepo/dimRed/git/refs{/sha}","trees_url":"https://api.github.com/repos/topepo/dimRed/git/trees{/sha}","statuses_url":"https://api.github.com/repos/topepo/dimRed/statuses/{sha}","languages_url":"https://api.github.com/repos/topepo/dimRed/languages","stargazers_url":"https://api.github.com/repos/topepo/dimRed/stargazers","contributors_url":"https://api.github.com/repos/topepo/dimRed/contributors","subscribers_url":"https://api.github.com/repos/topepo/dimRed/subscribers","subscription_url":"https://api.github.com/repos/topepo/dimRed/subscription","commits_url":"https://api.github.com/repos/topepo/dimRed/commits{/sha}","git_commits_url":"https://api.github.com/repos/topepo/dimRed/git/commits{/sha}","comments_url":"https://api.github.com/repos/topepo/dimRed/comments{/number}","issue_comment_url":"https://api.github.com/repos/topepo/dimRed/issues/comments{/number}","contents_url":"https://api.github.com/repos/topepo/dimRed/contents/{+path}","compare_url":"https://api.github.com/repos/topepo/dimRed/compare/{base}...{head}","merges_url":"https://api.github.com/repos/topepo/dimRed/merges","archive_url":"https://api.github.com/repos/topepo/dimRed/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/topepo/dimRed/downloads","issues_url":"https://api.github.com/repos/topepo/dimRed/issues{/number}","pulls_url":"https://api.github.com/repos/topepo/dimRed/pulls{/number}","milestones_url":"https://api.github.com/repos/topepo/dimRed/milestones{/number}","notifications_url":"https://api.github.com/repos/topepo/dimRed/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/topepo/dimRed/labels{/name}","releases_url":"https://api.github.com/repos/topepo/dimRed/releases{/id}","deployments_url":"https://api.github.com/repos/topepo/dimRed/deployments","created_at":"2017-01-24T21:31:02Z","updated_at":"2017-01-24T21:31:05Z","pushed_at":"2017-02-01T02:18:12Z","git_url":"git://github.com/topepo/dimRed.git","ssh_url":"git@github.com:topepo/dimRed.git","clone_url":"https://github.com/topepo/dimRed.git","svn_url":"https://github.com/topepo/dimRed","homepage":null,"size":5410,"stargazers_count":0,"watchers_count":0,"language":"R","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gdkrmr:master","ref":"master","sha":"2d62c455bca83b6ef03d31513a57e9e4ae41004d","user":{"login":"gdkrmr","id":12512930,"avatar_url":"https://avatars.githubusercontent.com/u/12512930?v=3","gravatar_id":"","url":"https://api.github.com/users/gdkrmr","html_url":"https://github.com/gdkrmr","followers_url":"https://api.github.com/users/gdkrmr/followers","following_url":"https://api.github.com/users/gdkrmr/following{/other_user}","gists_url":"https://api.github.com/users/gdkrmr/gists{/gist_id}","starred_url":"https://api.github.com/users/gdkrmr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gdkrmr/subscriptions","organizations_url":"https://api.github.com/users/gdkrmr/orgs","repos_url":"https://api.github.com/users/gdkrmr/repos","events_url":"https://api.github.com/users/gdkrmr/events{/privacy}","received_events_url":"https://api.github.com/users/gdkrmr/received_events","type":"User","site_admin":false},"repo":{"id":70895041,"name":"dimRed","full_name":"gdkrmr/dimRed","owner":{"login":"gdkrmr","id":12512930,"avatar_url":"https://avatars.githubusercontent.com/u/12512930?v=3","gravatar_id":"","url":"https://api.github.com/users/gdkrmr","html_url":"https://github.com/gdkrmr","followers_url":"https://api.github.com/users/gdkrmr/followers","following_url":"https://api.github.com/users/gdkrmr/following{/other_user}","gists_url":"https://api.github.com/users/gdkrmr/gists{/gist_id}","starred_url":"https://api.github.com/users/gdkrmr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gdkrmr/subscriptions","organizations_url":"https://api.github.com/users/gdkrmr/orgs","repos_url":"https://api.github.com/users/gdkrmr/repos","events_url":"https://api.github.com/users/gdkrmr/events{/privacy}","received_events_url":"https://api.github.com/users/gdkrmr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gdkrmr/dimRed","description":"A Framework for Dimensionality Reduction","fork":false,"url":"https://api.github.com/repos/gdkrmr/dimRed","forks_url":"https://api.github.com/repos/gdkrmr/dimRed/forks","keys_url":"https://api.github.com/repos/gdkrmr/dimRed/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gdkrmr/dimRed/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gdkrmr/dimRed/teams","hooks_url":"https://api.github.com/repos/gdkrmr/dimRed/hooks","issue_events_url":"https://api.github.com/repos/gdkrmr/dimRed/issues/events{/number}","events_url":"https://api.github.com/repos/gdkrmr/dimRed/events","assignees_url":"https://api.github.com/repos/gdkrmr/dimRed/assignees{/user}","branches_url":"https://api.github.com/repos/gdkrmr/dimRed/branches{/branch}","tags_url":"https://api.github.com/repos/gdkrmr/dimRed/tags","blobs_url":"https://api.github.com/repos/gdkrmr/dimRed/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gdkrmr/dimRed/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gdkrmr/dimRed/git/refs{/sha}","trees_url":"https://api.github.com/repos/gdkrmr/dimRed/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gdkrmr/dimRed/statuses/{sha}","languages_url":"https://api.github.com/repos/gdkrmr/dimRed/languages","stargazers_url":"https://api.github.com/repos/gdkrmr/dimRed/stargazers","contributors_url":"https://api.github.com/repos/gdkrmr/dimRed/contributors","subscribers_url":"https://api.github.com/repos/gdkrmr/dimRed/subscribers","subscription_url":"https://api.github.com/repos/gdkrmr/dimRed/subscription","commits_url":"https://api.github.com/repos/gdkrmr/dimRed/commits{/sha}","git_commits_url":"https://api.github.com/repos/gdkrmr/dimRed/git/commits{/sha}","comments_url":"https://api.github.com/repos/gdkrmr/dimRed/comments{/number}","issue_comment_url":"https://api.github.com/repos/gdkrmr/dimRed/issues/comments{/number}","contents_url":"https://api.github.com/repos/gdkrmr/dimRed/contents/{+path}","compare_url":"https://api.github.com/repos/gdkrmr/dimRed/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gdkrmr/dimRed/merges","archive_url":"https://api.github.com/repos/gdkrmr/dimRed/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gdkrmr/dimRed/downloads","issues_url":"https://api.github.com/repos/gdkrmr/dimRed/issues{/number}","pulls_url":"https://api.github.com/repos/gdkrmr/dimRed/pulls{/number}","milestones_url":"https://api.github.com/repos/gdkrmr/dimRed/milestones{/number}","notifications_url":"https://api.github.com/repos/gdkrmr/dimRed/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gdkrmr/dimRed/labels{/name}","releases_url":"https://api.github.com/repos/gdkrmr/dimRed/releases{/id}","deployments_url":"https://api.github.com/repos/gdkrmr/dimRed/deployments","created_at":"2016-10-14T09:25:34Z","updated_at":"2017-02-02T10:04:42Z","pushed_at":"2017-02-01T02:23:39Z","git_url":"git://github.com/gdkrmr/dimRed.git","ssh_url":"git@github.com:gdkrmr/dimRed.git","clone_url":"https://github.com/gdkrmr/dimRed.git","svn_url":"https://github.com/gdkrmr/dimRed","homepage":null,"size":5414,"stargazers_count":6,"watchers_count":6,"language":"R","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gdkrmr/dimRed/pulls/5"},"html":{"href":"https://github.com/gdkrmr/dimRed/pull/5"},"issue":{"href":"https://api.github.com/repos/gdkrmr/dimRed/issues/5"},"comments":{"href":"https://api.github.com/repos/gdkrmr/dimRed/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/gdkrmr/dimRed/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/gdkrmr/dimRed/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gdkrmr/dimRed/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/gdkrmr/dimRed/statuses/d2d8f9af35d53c29e7a4fba42c3f8b1ed94b38a9"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":5,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":23,"deletions":12,"changed_files":1}}
{"actor":{"display_login":"gdkrmr"}}