{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/cli/issues/6180","repository_url":"https://api.github.com/repos/dotnet/cli","labels_url":"https://api.github.com/repos/dotnet/cli/issues/6180/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/cli/issues/6180/comments","events_url":"https://api.github.com/repos/dotnet/cli/issues/6180/events","html_url":"https://github.com/dotnet/cli/pull/6180","id":217706800,"number":6180,"title":"Adds Microsoft.Docker.Sdk to CLI","user":{"login":"dazhao-msft","id":24704261,"avatar_url":"https://avatars1.githubusercontent.com/u/24704261?v=3","gravatar_id":"","url":"https://api.github.com/users/dazhao-msft","html_url":"https://github.com/dazhao-msft","followers_url":"https://api.github.com/users/dazhao-msft/followers","following_url":"https://api.github.com/users/dazhao-msft/following{/other_user}","gists_url":"https://api.github.com/users/dazhao-msft/gists{/gist_id}","starred_url":"https://api.github.com/users/dazhao-msft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dazhao-msft/subscriptions","organizations_url":"https://api.github.com/users/dazhao-msft/orgs","repos_url":"https://api.github.com/users/dazhao-msft/repos","events_url":"https://api.github.com/users/dazhao-msft/events{/privacy}","received_events_url":"https://api.github.com/users/dazhao-msft/received_events","type":"User","site_admin":false},"labels":[{"id":287140557,"url":"https://api.github.com/repos/dotnet/cli/labels/cla-required","name":"cla-required","color":"e11d21","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":20,"created_at":"2017-03-28T22:05:38Z","updated_at":"2017-03-30T23:28:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dotnet/cli/pulls/6180","html_url":"https://github.com/dotnet/cli/pull/6180","diff_url":"https://github.com/dotnet/cli/pull/6180.diff","patch_url":"https://github.com/dotnet/cli/pull/6180.patch"},"body":"This change is to add Sdk.props and Sdk.targets of Microsoft.Docker.Sdk into CLI. This unblocks the scenario where a VS solution contains a few .NET Core projects as well as a docker-compose.dcproj project and people want to build the solution from command line with .NET Core CLI. With the Sdk.props and Sdk.targets being present in CLI, building docker-compose.dcproj becomes no-op so it won't block building the other .NET Core projects.\r\n"},"comment":{"url":"https://api.github.com/repos/dotnet/cli/issues/comments/290573673","html_url":"https://github.com/dotnet/cli/pull/6180#issuecomment-290573673","issue_url":"https://api.github.com/repos/dotnet/cli/issues/6180","id":290573673,"user":{"login":"billpratt","id":2847527,"avatar_url":"https://avatars0.githubusercontent.com/u/2847527?v=3","gravatar_id":"","url":"https://api.github.com/users/billpratt","html_url":"https://github.com/billpratt","followers_url":"https://api.github.com/users/billpratt/followers","following_url":"https://api.github.com/users/billpratt/following{/other_user}","gists_url":"https://api.github.com/users/billpratt/gists{/gist_id}","starred_url":"https://api.github.com/users/billpratt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/billpratt/subscriptions","organizations_url":"https://api.github.com/users/billpratt/orgs","repos_url":"https://api.github.com/users/billpratt/repos","events_url":"https://api.github.com/users/billpratt/events{/privacy}","received_events_url":"https://api.github.com/users/billpratt/received_events","type":"User","site_admin":false},"created_at":"2017-03-30T23:28:00Z","updated_at":"2017-03-30T23:28:00Z","body":"+1 for a fix. I ran into this issue and submitted #6178. That issue was closed because of this PR. Right now, having a dcproj project in a solution breaks the usage of the cli targeting a solution. The aspnetcore-build docker image works because the SDK reference was added. Since I work with both VS and non-VS devs, the dcproj reference blocks them from building the solution. "}}
{"actor":{"display_login":"billpratt"}}