{"action":"closed","number":5,"pull_request":{"url":"https://api.github.com/repos/mjrider/flysystem-factory/pulls/5","id":160585945,"html_url":"https://github.com/mjrider/flysystem-factory/pull/5","diff_url":"https://github.com/mjrider/flysystem-factory/pull/5.diff","patch_url":"https://github.com/mjrider/flysystem-factory/pull/5.patch","issue_url":"https://api.github.com/repos/mjrider/flysystem-factory/issues/5","number":5,"state":"closed","locked":false,"title":"Remove code duplication in S3/S3v2 Adapter","user":{"login":"mjrider","id":213105,"avatar_url":"https://avatars2.githubusercontent.com/u/213105?v=4","gravatar_id":"","url":"https://api.github.com/users/mjrider","html_url":"https://github.com/mjrider","followers_url":"https://api.github.com/users/mjrider/followers","following_url":"https://api.github.com/users/mjrider/following{/other_user}","gists_url":"https://api.github.com/users/mjrider/gists{/gist_id}","starred_url":"https://api.github.com/users/mjrider/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjrider/subscriptions","organizations_url":"https://api.github.com/users/mjrider/orgs","repos_url":"https://api.github.com/users/mjrider/repos","events_url":"https://api.github.com/users/mjrider/events{/privacy}","received_events_url":"https://api.github.com/users/mjrider/received_events","type":"User","site_admin":false},"body":"split create function in 2 helpers, which are called with late\r\nstatic binding to use the v3 or the v2 S3 flysystem adapter and\r\ncompensating for the difference between the s3 client versions\r\n\r\nalso added codestyling fixes from scrutinizer","created_at":"2017-12-30T10:49:08Z","updated_at":"2017-12-31T08:24:09Z","closed_at":"2017-12-31T08:24:09Z","merged_at":"2017-12-31T08:24:09Z","merge_commit_sha":"14eb0583c7febd1066982e80d0c9d4764818abdf","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/mjrider/flysystem-factory/pulls/5/commits","review_comments_url":"https://api.github.com/repos/mjrider/flysystem-factory/pulls/5/comments","review_comment_url":"https://api.github.com/repos/mjrider/flysystem-factory/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mjrider/flysystem-factory/issues/5/comments","statuses_url":"https://api.github.com/repos/mjrider/flysystem-factory/statuses/b67140c9f4c795aa6f68c55facb086fc3d518dd5","head":{"label":"mjrider:remove-code-duplication-in-s3","ref":"remove-code-duplication-in-s3","sha":"b67140c9f4c795aa6f68c55facb086fc3d518dd5","user":{"login":"mjrider","id":213105,"avatar_url":"https://avatars2.githubusercontent.com/u/213105?v=4","gravatar_id":"","url":"https://api.github.com/users/mjrider","html_url":"https://github.com/mjrider","followers_url":"https://api.github.com/users/mjrider/followers","following_url":"https://api.github.com/users/mjrider/following{/other_user}","gists_url":"https://api.github.com/users/mjrider/gists{/gist_id}","starred_url":"https://api.github.com/users/mjrider/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjrider/subscriptions","organizations_url":"https://api.github.com/users/mjrider/orgs","repos_url":"https://api.github.com/users/mjrider/repos","events_url":"https://api.github.com/users/mjrider/events{/privacy}","received_events_url":"https://api.github.com/users/mjrider/received_events","type":"User","site_admin":false},"repo":{"id":101796413,"name":"flysystem-factory","full_name":"mjrider/flysystem-factory","owner":{"login":"mjrider","id":213105,"avatar_url":"https://avatars2.githubusercontent.com/u/213105?v=4","gravatar_id":"","url":"https://api.github.com/users/mjrider","html_url":"https://github.com/mjrider","followers_url":"https://api.github.com/users/mjrider/followers","following_url":"https://api.github.com/users/mjrider/following{/other_user}","gists_url":"https://api.github.com/users/mjrider/gists{/gist_id}","starred_url":"https://api.github.com/users/mjrider/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjrider/subscriptions","organizations_url":"https://api.github.com/users/mjrider/orgs","repos_url":"https://api.github.com/users/mjrider/repos","events_url":"https://api.github.com/users/mjrider/events{/privacy}","received_events_url":"https://api.github.com/users/mjrider/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mjrider/flysystem-factory","description":"Simple flysystem factory for simple usecases","fork":false,"url":"https://api.github.com/repos/mjrider/flysystem-factory","forks_url":"https://api.github.com/repos/mjrider/flysystem-factory/forks","keys_url":"https://api.github.com/repos/mjrider/flysystem-factory/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mjrider/flysystem-factory/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mjrider/flysystem-factory/teams","hooks_url":"https://api.github.com/repos/mjrider/flysystem-factory/hooks","issue_events_url":"https://api.github.com/repos/mjrider/flysystem-factory/issues/events{/number}","events_url":"https://api.github.com/repos/mjrider/flysystem-factory/events","assignees_url":"https://api.github.com/repos/mjrider/flysystem-factory/assignees{/user}","branches_url":"https://api.github.com/repos/mjrider/flysystem-factory/branches{/branch}","tags_url":"https://api.github.com/repos/mjrider/flysystem-factory/tags","blobs_url":"https://api.github.com/repos/mjrider/flysystem-factory/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mjrider/flysystem-factory/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mjrider/flysystem-factory/git/refs{/sha}","trees_url":"https://api.github.com/repos/mjrider/flysystem-factory/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mjrider/flysystem-factory/statuses/{sha}","languages_url":"https://api.github.com/repos/mjrider/flysystem-factory/languages","stargazers_url":"https://api.github.com/repos/mjrider/flysystem-factory/stargazers","contributors_url":"https://api.github.com/repos/mjrider/flysystem-factory/contributors","subscribers_url":"https://api.github.com/repos/mjrider/flysystem-factory/subscribers","subscription_url":"https://api.github.com/repos/mjrider/flysystem-factory/subscription","commits_url":"https://api.github.com/repos/mjrider/flysystem-factory/commits{/sha}","git_commits_url":"https://api.github.com/repos/mjrider/flysystem-factory/git/commits{/sha}","comments_url":"https://api.github.com/repos/mjrider/flysystem-factory/comments{/number}","issue_comment_url":"https://api.github.com/repos/mjrider/flysystem-factory/issues/comments{/number}","contents_url":"https://api.github.com/repos/mjrider/flysystem-factory/contents/{+path}","compare_url":"https://api.github.com/repos/mjrider/flysystem-factory/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mjrider/flysystem-factory/merges","archive_url":"https://api.github.com/repos/mjrider/flysystem-factory/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mjrider/flysystem-factory/downloads","issues_url":"https://api.github.com/repos/mjrider/flysystem-factory/issues{/number}","pulls_url":"https://api.github.com/repos/mjrider/flysystem-factory/pulls{/number}","milestones_url":"https://api.github.com/repos/mjrider/flysystem-factory/milestones{/number}","notifications_url":"https://api.github.com/repos/mjrider/flysystem-factory/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mjrider/flysystem-factory/labels{/name}","releases_url":"https://api.github.com/repos/mjrider/flysystem-factory/releases{/id}","deployments_url":"https://api.github.com/repos/mjrider/flysystem-factory/deployments","created_at":"2017-08-29T19:01:19Z","updated_at":"2017-12-06T12:54:35Z","pushed_at":"2017-12-31T08:24:09Z","git_url":"git://github.com/mjrider/flysystem-factory.git","ssh_url":"git@github.com:mjrider/flysystem-factory.git","clone_url":"https://github.com/mjrider/flysystem-factory.git","svn_url":"https://github.com/mjrider/flysystem-factory","homepage":"","size":92,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"mjrider:master","ref":"master","sha":"6131fc64f6474d798dfe6837b1ee9285114b283b","user":{"login":"mjrider","id":213105,"avatar_url":"https://avatars2.githubusercontent.com/u/213105?v=4","gravatar_id":"","url":"https://api.github.com/users/mjrider","html_url":"https://github.com/mjrider","followers_url":"https://api.github.com/users/mjrider/followers","following_url":"https://api.github.com/users/mjrider/following{/other_user}","gists_url":"https://api.github.com/users/mjrider/gists{/gist_id}","starred_url":"https://api.github.com/users/mjrider/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjrider/subscriptions","organizations_url":"https://api.github.com/users/mjrider/orgs","repos_url":"https://api.github.com/users/mjrider/repos","events_url":"https://api.github.com/users/mjrider/events{/privacy}","received_events_url":"https://api.github.com/users/mjrider/received_events","type":"User","site_admin":false},"repo":{"id":101796413,"name":"flysystem-factory","full_name":"mjrider/flysystem-factory","owner":{"login":"mjrider","id":213105,"avatar_url":"https://avatars2.githubusercontent.com/u/213105?v=4","gravatar_id":"","url":"https://api.github.com/users/mjrider","html_url":"https://github.com/mjrider","followers_url":"https://api.github.com/users/mjrider/followers","following_url":"https://api.github.com/users/mjrider/following{/other_user}","gists_url":"https://api.github.com/users/mjrider/gists{/gist_id}","starred_url":"https://api.github.com/users/mjrider/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjrider/subscriptions","organizations_url":"https://api.github.com/users/mjrider/orgs","repos_url":"https://api.github.com/users/mjrider/repos","events_url":"https://api.github.com/users/mjrider/events{/privacy}","received_events_url":"https://api.github.com/users/mjrider/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mjrider/flysystem-factory","description":"Simple flysystem factory for simple usecases","fork":false,"url":"https://api.github.com/repos/mjrider/flysystem-factory","forks_url":"https://api.github.com/repos/mjrider/flysystem-factory/forks","keys_url":"https://api.github.com/repos/mjrider/flysystem-factory/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mjrider/flysystem-factory/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mjrider/flysystem-factory/teams","hooks_url":"https://api.github.com/repos/mjrider/flysystem-factory/hooks","issue_events_url":"https://api.github.com/repos/mjrider/flysystem-factory/issues/events{/number}","events_url":"https://api.github.com/repos/mjrider/flysystem-factory/events","assignees_url":"https://api.github.com/repos/mjrider/flysystem-factory/assignees{/user}","branches_url":"https://api.github.com/repos/mjrider/flysystem-factory/branches{/branch}","tags_url":"https://api.github.com/repos/mjrider/flysystem-factory/tags","blobs_url":"https://api.github.com/repos/mjrider/flysystem-factory/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mjrider/flysystem-factory/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mjrider/flysystem-factory/git/refs{/sha}","trees_url":"https://api.github.com/repos/mjrider/flysystem-factory/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mjrider/flysystem-factory/statuses/{sha}","languages_url":"https://api.github.com/repos/mjrider/flysystem-factory/languages","stargazers_url":"https://api.github.com/repos/mjrider/flysystem-factory/stargazers","contributors_url":"https://api.github.com/repos/mjrider/flysystem-factory/contributors","subscribers_url":"https://api.github.com/repos/mjrider/flysystem-factory/subscribers","subscription_url":"https://api.github.com/repos/mjrider/flysystem-factory/subscription","commits_url":"https://api.github.com/repos/mjrider/flysystem-factory/commits{/sha}","git_commits_url":"https://api.github.com/repos/mjrider/flysystem-factory/git/commits{/sha}","comments_url":"https://api.github.com/repos/mjrider/flysystem-factory/comments{/number}","issue_comment_url":"https://api.github.com/repos/mjrider/flysystem-factory/issues/comments{/number}","contents_url":"https://api.github.com/repos/mjrider/flysystem-factory/contents/{+path}","compare_url":"https://api.github.com/repos/mjrider/flysystem-factory/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mjrider/flysystem-factory/merges","archive_url":"https://api.github.com/repos/mjrider/flysystem-factory/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mjrider/flysystem-factory/downloads","issues_url":"https://api.github.com/repos/mjrider/flysystem-factory/issues{/number}","pulls_url":"https://api.github.com/repos/mjrider/flysystem-factory/pulls{/number}","milestones_url":"https://api.github.com/repos/mjrider/flysystem-factory/milestones{/number}","notifications_url":"https://api.github.com/repos/mjrider/flysystem-factory/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mjrider/flysystem-factory/labels{/name}","releases_url":"https://api.github.com/repos/mjrider/flysystem-factory/releases{/id}","deployments_url":"https://api.github.com/repos/mjrider/flysystem-factory/deployments","created_at":"2017-08-29T19:01:19Z","updated_at":"2017-12-06T12:54:35Z","pushed_at":"2017-12-31T08:24:09Z","git_url":"git://github.com/mjrider/flysystem-factory.git","ssh_url":"git@github.com:mjrider/flysystem-factory.git","clone_url":"https://github.com/mjrider/flysystem-factory.git","svn_url":"https://github.com/mjrider/flysystem-factory","homepage":"","size":92,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mjrider/flysystem-factory/pulls/5"},"html":{"href":"https://github.com/mjrider/flysystem-factory/pull/5"},"issue":{"href":"https://api.github.com/repos/mjrider/flysystem-factory/issues/5"},"comments":{"href":"https://api.github.com/repos/mjrider/flysystem-factory/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/mjrider/flysystem-factory/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/mjrider/flysystem-factory/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mjrider/flysystem-factory/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/mjrider/flysystem-factory/statuses/b67140c9f4c795aa6f68c55facb086fc3d518dd5"}},"author_association":"OWNER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"mjrider","id":213105,"avatar_url":"https://avatars2.githubusercontent.com/u/213105?v=4","gravatar_id":"","url":"https://api.github.com/users/mjrider","html_url":"https://github.com/mjrider","followers_url":"https://api.github.com/users/mjrider/followers","following_url":"https://api.github.com/users/mjrider/following{/other_user}","gists_url":"https://api.github.com/users/mjrider/gists{/gist_id}","starred_url":"https://api.github.com/users/mjrider/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjrider/subscriptions","organizations_url":"https://api.github.com/users/mjrider/orgs","repos_url":"https://api.github.com/users/mjrider/repos","events_url":"https://api.github.com/users/mjrider/events{/privacy}","received_events_url":"https://api.github.com/users/mjrider/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":31,"deletions":40,"changed_files":4}}
{"actor":{"display_login":"mjrider"}}