{"action":"closed","number":10646,"pull_request":{"url":"https://api.github.com/repos/elastic/kibana/pulls/10646","id":108680852,"html_url":"https://github.com/elastic/kibana/pull/10646","diff_url":"https://github.com/elastic/kibana/pull/10646.diff","patch_url":"https://github.com/elastic/kibana/pull/10646.patch","issue_url":"https://api.github.com/repos/elastic/kibana/issues/10646","number":10646,"state":"closed","locked":false,"title":"[UI Framework] Create Button React components in UI Framework.","user":{"login":"cjcenizal","id":1238659,"avatar_url":"https://avatars1.githubusercontent.com/u/1238659?v=3","gravatar_id":"","url":"https://api.github.com/users/cjcenizal","html_url":"https://github.com/cjcenizal","followers_url":"https://api.github.com/users/cjcenizal/followers","following_url":"https://api.github.com/users/cjcenizal/following{/other_user}","gists_url":"https://api.github.com/users/cjcenizal/gists{/gist_id}","starred_url":"https://api.github.com/users/cjcenizal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjcenizal/subscriptions","organizations_url":"https://api.github.com/users/cjcenizal/orgs","repos_url":"https://api.github.com/users/cjcenizal/repos","events_url":"https://api.github.com/users/cjcenizal/events{/privacy}","received_events_url":"https://api.github.com/users/cjcenizal/received_events","type":"User","site_admin":false},"body":"To-do:\r\n\r\n- [x] ~~Add `LoadingButton` abstraction~~\r\n- [x] Add `SubmitButton` abstraction\r\n- [x] Add Jest tests for Button, ButtonGroup, and ButtonIcon.\r\n- [x] Show HTML examples for React components (for people who aren't using React and need to use CSS)\r\n- [x] Update README for instructions on how to import the components.\r\n- [x] Update README for instructions on how to write unit tests.\r\n- [x] Add `aria-label` property (Button now supports all HTML attributes).\r\n- [x] Include UI Framework in linting task.\r\n- [x] Get buy-in on Jest.\r\n- [x] Split up testing task into one with watch enabled, and one with coverage report generation enabled.\r\n- [x] Ensure test task is run by our CI (i.e. when `npm test` is run).\r\n- [x] Make sure none of the CSS changes affect kuiButton throughout Kibana, especially regarding `disabled` state.\r\n\r\nTo-do in other PRs:\r\n\r\n- [ ] Add support for tooltip, possibly using CSS only (e.g. http://ubnt-css.herokuapp.com/#/app/tooltip)\r\n- [ ] Rename all `.jsx` files to `.js`","created_at":"2017-03-02T03:45:08Z","updated_at":"2017-03-29T20:25:44Z","closed_at":"2017-03-29T20:25:43Z","merged_at":"2017-03-29T20:25:43Z","merge_commit_sha":"b604911720a4fdcbbbe9587ee73100567c34dbec","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/kibana/pulls/10646/commits","review_comments_url":"https://api.github.com/repos/elastic/kibana/pulls/10646/comments","review_comment_url":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/kibana/issues/10646/comments","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/98e1e3881cbb4f70a7ed422a79b8b48ed474af7d","head":{"label":"cjcenizal:feature/react-commponents-ui-framework","ref":"feature/react-commponents-ui-framework","sha":"98e1e3881cbb4f70a7ed422a79b8b48ed474af7d","user":{"login":"cjcenizal","id":1238659,"avatar_url":"https://avatars1.githubusercontent.com/u/1238659?v=3","gravatar_id":"","url":"https://api.github.com/users/cjcenizal","html_url":"https://github.com/cjcenizal","followers_url":"https://api.github.com/users/cjcenizal/followers","following_url":"https://api.github.com/users/cjcenizal/following{/other_user}","gists_url":"https://api.github.com/users/cjcenizal/gists{/gist_id}","starred_url":"https://api.github.com/users/cjcenizal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjcenizal/subscriptions","organizations_url":"https://api.github.com/users/cjcenizal/orgs","repos_url":"https://api.github.com/users/cjcenizal/repos","events_url":"https://api.github.com/users/cjcenizal/events{/privacy}","received_events_url":"https://api.github.com/users/cjcenizal/received_events","type":"User","site_admin":false},"repo":{"id":60198225,"name":"kibana","full_name":"cjcenizal/kibana","owner":{"login":"cjcenizal","id":1238659,"avatar_url":"https://avatars1.githubusercontent.com/u/1238659?v=3","gravatar_id":"","url":"https://api.github.com/users/cjcenizal","html_url":"https://github.com/cjcenizal","followers_url":"https://api.github.com/users/cjcenizal/followers","following_url":"https://api.github.com/users/cjcenizal/following{/other_user}","gists_url":"https://api.github.com/users/cjcenizal/gists{/gist_id}","starred_url":"https://api.github.com/users/cjcenizal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjcenizal/subscriptions","organizations_url":"https://api.github.com/users/cjcenizal/orgs","repos_url":"https://api.github.com/users/cjcenizal/repos","events_url":"https://api.github.com/users/cjcenizal/events{/privacy}","received_events_url":"https://api.github.com/users/cjcenizal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cjcenizal/kibana","description":":bar_chart: Kibana analytics and search dashboard for Elasticsearch","fork":true,"url":"https://api.github.com/repos/cjcenizal/kibana","forks_url":"https://api.github.com/repos/cjcenizal/kibana/forks","keys_url":"https://api.github.com/repos/cjcenizal/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cjcenizal/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cjcenizal/kibana/teams","hooks_url":"https://api.github.com/repos/cjcenizal/kibana/hooks","issue_events_url":"https://api.github.com/repos/cjcenizal/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/cjcenizal/kibana/events","assignees_url":"https://api.github.com/repos/cjcenizal/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/cjcenizal/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/cjcenizal/kibana/tags","blobs_url":"https://api.github.com/repos/cjcenizal/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cjcenizal/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cjcenizal/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/cjcenizal/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cjcenizal/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/cjcenizal/kibana/languages","stargazers_url":"https://api.github.com/repos/cjcenizal/kibana/stargazers","contributors_url":"https://api.github.com/repos/cjcenizal/kibana/contributors","subscribers_url":"https://api.github.com/repos/cjcenizal/kibana/subscribers","subscription_url":"https://api.github.com/repos/cjcenizal/kibana/subscription","commits_url":"https://api.github.com/repos/cjcenizal/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/cjcenizal/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/cjcenizal/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/cjcenizal/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/cjcenizal/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/cjcenizal/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cjcenizal/kibana/merges","archive_url":"https://api.github.com/repos/cjcenizal/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cjcenizal/kibana/downloads","issues_url":"https://api.github.com/repos/cjcenizal/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/cjcenizal/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/cjcenizal/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/cjcenizal/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cjcenizal/kibana/labels{/name}","releases_url":"https://api.github.com/repos/cjcenizal/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/cjcenizal/kibana/deployments","created_at":"2016-06-01T17:41:59Z","updated_at":"2016-06-01T17:42:04Z","pushed_at":"2017-03-29T20:21:29Z","git_url":"git://github.com/cjcenizal/kibana.git","ssh_url":"git@github.com:cjcenizal/kibana.git","clone_url":"https://github.com/cjcenizal/kibana.git","svn_url":"https://github.com/cjcenizal/kibana","homepage":"https://www.elastic.co/products/kibana","size":235101,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"753327cfac314f120705c957e037e36597368380","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars3.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":7833168,"name":"kibana","full_name":"elastic/kibana","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars3.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/kibana","description":":bar_chart: Kibana analytics and search dashboard for Elasticsearch","fork":false,"url":"https://api.github.com/repos/elastic/kibana","forks_url":"https://api.github.com/repos/elastic/kibana/forks","keys_url":"https://api.github.com/repos/elastic/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/kibana/teams","hooks_url":"https://api.github.com/repos/elastic/kibana/hooks","issue_events_url":"https://api.github.com/repos/elastic/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/kibana/events","assignees_url":"https://api.github.com/repos/elastic/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/kibana/tags","blobs_url":"https://api.github.com/repos/elastic/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/kibana/languages","stargazers_url":"https://api.github.com/repos/elastic/kibana/stargazers","contributors_url":"https://api.github.com/repos/elastic/kibana/contributors","subscribers_url":"https://api.github.com/repos/elastic/kibana/subscribers","subscription_url":"https://api.github.com/repos/elastic/kibana/subscription","commits_url":"https://api.github.com/repos/elastic/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/kibana/merges","archive_url":"https://api.github.com/repos/elastic/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/kibana/downloads","issues_url":"https://api.github.com/repos/elastic/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/kibana/labels{/name}","releases_url":"https://api.github.com/repos/elastic/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/kibana/deployments","created_at":"2013-01-26T04:00:59Z","updated_at":"2017-03-29T14:57:10Z","pushed_at":"2017-03-29T20:25:43Z","git_url":"git://github.com/elastic/kibana.git","ssh_url":"git@github.com:elastic/kibana.git","clone_url":"https://github.com/elastic/kibana.git","svn_url":"https://github.com/elastic/kibana","homepage":"https://www.elastic.co/products/kibana","size":235459,"stargazers_count":7029,"watchers_count":7029,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2659,"mirror_url":null,"open_issues_count":1499,"forks":2659,"open_issues":1499,"watchers":7029,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/10646"},"html":{"href":"https://github.com/elastic/kibana/pull/10646"},"issue":{"href":"https://api.github.com/repos/elastic/kibana/issues/10646"},"comments":{"href":"https://api.github.com/repos/elastic/kibana/issues/10646/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/kibana/pulls/10646/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/kibana/pulls/10646/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/kibana/statuses/98e1e3881cbb4f70a7ed422a79b8b48ed474af7d"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"cjcenizal","id":1238659,"avatar_url":"https://avatars1.githubusercontent.com/u/1238659?v=3","gravatar_id":"","url":"https://api.github.com/users/cjcenizal","html_url":"https://github.com/cjcenizal","followers_url":"https://api.github.com/users/cjcenizal/followers","following_url":"https://api.github.com/users/cjcenizal/following{/other_user}","gists_url":"https://api.github.com/users/cjcenizal/gists{/gist_id}","starred_url":"https://api.github.com/users/cjcenizal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjcenizal/subscriptions","organizations_url":"https://api.github.com/users/cjcenizal/orgs","repos_url":"https://api.github.com/users/cjcenizal/repos","events_url":"https://api.github.com/users/cjcenizal/events{/privacy}","received_events_url":"https://api.github.com/users/cjcenizal/received_events","type":"User","site_admin":false},"comments":23,"review_comments":45,"maintainer_can_modify":false,"commits":33,"additions":2123,"deletions":315,"changed_files":60}}
{"actor":{"display_login":"cjcenizal"}}