{"action":"created","issue":{"url":"https://api.github.com/repos/servo/servo/issues/17619","repository_url":"https://api.github.com/repos/servo/servo","labels_url":"https://api.github.com/repos/servo/servo/issues/17619/labels{/name}","comments_url":"https://api.github.com/repos/servo/servo/issues/17619/comments","events_url":"https://api.github.com/repos/servo/servo/issues/17619/events","html_url":"https://github.com/servo/servo/pull/17619","id":240843460,"number":17619,"title":"Update parse-hosts.","user":{"login":"clarcharr","id":15850505,"avatar_url":"https://avatars2.githubusercontent.com/u/15850505?v=3","gravatar_id":"","url":"https://api.github.com/users/clarcharr","html_url":"https://github.com/clarcharr","followers_url":"https://api.github.com/users/clarcharr/followers","following_url":"https://api.github.com/users/clarcharr/following{/other_user}","gists_url":"https://api.github.com/users/clarcharr/gists{/gist_id}","starred_url":"https://api.github.com/users/clarcharr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clarcharr/subscriptions","organizations_url":"https://api.github.com/users/clarcharr/orgs","repos_url":"https://api.github.com/users/clarcharr/repos","events_url":"https://api.github.com/users/clarcharr/events{/privacy}","received_events_url":"https://api.github.com/users/clarcharr/received_events","type":"User","site_admin":false},"labels":[{"id":152310043,"url":"https://api.github.com/repos/servo/servo/labels/S-awaiting-review","name":"S-awaiting-review","color":"d4c5f9","default":false},{"id":152311003,"url":"https://api.github.com/repos/servo/servo/labels/S-needs-rebase","name":"S-needs-rebase","color":"d4c5f9","default":false}],"state":"open","locked":false,"assignee":{"login":"glennw","id":2350882,"avatar_url":"https://avatars3.githubusercontent.com/u/2350882?v=3","gravatar_id":"","url":"https://api.github.com/users/glennw","html_url":"https://github.com/glennw","followers_url":"https://api.github.com/users/glennw/followers","following_url":"https://api.github.com/users/glennw/following{/other_user}","gists_url":"https://api.github.com/users/glennw/gists{/gist_id}","starred_url":"https://api.github.com/users/glennw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glennw/subscriptions","organizations_url":"https://api.github.com/users/glennw/orgs","repos_url":"https://api.github.com/users/glennw/repos","events_url":"https://api.github.com/users/glennw/events{/privacy}","received_events_url":"https://api.github.com/users/glennw/received_events","type":"User","site_admin":false},"assignees":[{"login":"glennw","id":2350882,"avatar_url":"https://avatars3.githubusercontent.com/u/2350882?v=3","gravatar_id":"","url":"https://api.github.com/users/glennw","html_url":"https://github.com/glennw","followers_url":"https://api.github.com/users/glennw/followers","following_url":"https://api.github.com/users/glennw/following{/other_user}","gists_url":"https://api.github.com/users/glennw/gists{/gist_id}","starred_url":"https://api.github.com/users/glennw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glennw/subscriptions","organizations_url":"https://api.github.com/users/glennw/orgs","repos_url":"https://api.github.com/users/glennw/repos","events_url":"https://api.github.com/users/glennw/events{/privacy}","received_events_url":"https://api.github.com/users/glennw/received_events","type":"User","site_admin":false}],"milestone":null,"comments":7,"created_at":"2017-07-06T04:47:00Z","updated_at":"2017-07-06T21:07:51Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/17619","html_url":"https://github.com/servo/servo/pull/17619","diff_url":"https://github.com/servo/servo/pull/17619.diff","patch_url":"https://github.com/servo/servo/pull/17619.patch"},"body":"The `parse-hosts` crate was recently updated so that it doesn't use any unstable features.\r\n\r\n---\r\n- [ ] `./mach build -d` does not report any errors\r\n- [x] `./mach test-tidy` does not report any errors\r\n- [X] These changes do not require tests because tests were already implemented.\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/servo/servo/17619)\r\n<!-- Reviewable:end -->\r\n"},"comment":{"url":"https://api.github.com/repos/servo/servo/issues/comments/313519738","html_url":"https://github.com/servo/servo/pull/17619#issuecomment-313519738","issue_url":"https://api.github.com/repos/servo/servo/issues/17619","id":313519738,"user":{"login":"SimonSapin","id":291359,"avatar_url":"https://avatars3.githubusercontent.com/u/291359?v=3","gravatar_id":"","url":"https://api.github.com/users/SimonSapin","html_url":"https://github.com/SimonSapin","followers_url":"https://api.github.com/users/SimonSapin/followers","following_url":"https://api.github.com/users/SimonSapin/following{/other_user}","gists_url":"https://api.github.com/users/SimonSapin/gists{/gist_id}","starred_url":"https://api.github.com/users/SimonSapin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimonSapin/subscriptions","organizations_url":"https://api.github.com/users/SimonSapin/orgs","repos_url":"https://api.github.com/users/SimonSapin/repos","events_url":"https://api.github.com/users/SimonSapin/events{/privacy}","received_events_url":"https://api.github.com/users/SimonSapin/received_events","type":"User","site_admin":false},"created_at":"2017-07-06T21:07:51Z","updated_at":"2017-07-06T21:07:51Z","body":"Thanks. This uncovers another issue, though: many dependencies end up duplicated, which would prevent this PR from being merged. `./mach test-tidy` shows details. The root reason is that quickcheck (added in this PR) depends on env_logger 0.3.x where as several other crates depend on 0.4.x. (And from there two versions of regex, two versions of memchr, etc.) Usually the way to fix this is to go make changes to quickcheck. But in this case, does it really need to be added in the first place? My understanding is that it’s a testing thing. Could you make it a dev-dependency in multistr and only compile its usage under `#[cfg(test)]`?"}}
{"actor":{"display_login":"SimonSapin"}}