{"action":"created","issue":{"url":"https://api.github.com/repos/elastic/elasticsearch/issues/23976","repository_url":"https://api.github.com/repos/elastic/elasticsearch","labels_url":"https://api.github.com/repos/elastic/elasticsearch/issues/23976/labels{/name}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/issues/23976/comments","events_url":"https://api.github.com/repos/elastic/elasticsearch/issues/23976/events","html_url":"https://github.com/elastic/elasticsearch/pull/23976","id":220263376,"number":23976,"title":"Settings: Disallow secure setting to exist in normal settings","user":{"login":"rjernst","id":289412,"avatar_url":"https://avatars0.githubusercontent.com/u/289412?v=3","gravatar_id":"","url":"https://api.github.com/users/rjernst","html_url":"https://github.com/rjernst","followers_url":"https://api.github.com/users/rjernst/followers","following_url":"https://api.github.com/users/rjernst/following{/other_user}","gists_url":"https://api.github.com/users/rjernst/gists{/gist_id}","starred_url":"https://api.github.com/users/rjernst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjernst/subscriptions","organizations_url":"https://api.github.com/users/rjernst/orgs","repos_url":"https://api.github.com/users/rjernst/repos","events_url":"https://api.github.com/users/rjernst/events{/privacy}","received_events_url":"https://api.github.com/users/rjernst/received_events","type":"User","site_admin":false},"labels":[{"id":144457604,"url":"https://api.github.com/repos/elastic/elasticsearch/labels/:Settings","name":":Settings","color":"009800","default":false},{"id":73544,"url":"https://api.github.com/repos/elastic/elasticsearch/labels/non-issue","name":"non-issue","color":"cfcfcf","default":false},{"id":534335216,"url":"https://api.github.com/repos/elastic/elasticsearch/labels/v5.4.0","name":"v5.4.0","color":"dddddd","default":false},{"id":334286612,"url":"https://api.github.com/repos/elastic/elasticsearch/labels/v6.0.0","name":"v6.0.0","color":"dddddd","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-04-07T16:26:13Z","updated_at":"2017-04-07T16:28:41Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/23976","html_url":"https://github.com/elastic/elasticsearch/pull/23976","diff_url":"https://github.com/elastic/elasticsearch/pull/23976.diff","patch_url":"https://github.com/elastic/elasticsearch/pull/23976.patch"},"body":"This commit removes the \"legacy\" feature of secure settings, which setup\r\na parallel setting that was a fallback in the insecure\r\nelasticsearch.yml. This was previously used to allow the new secure\r\nsetting name to be that of the old setting name, but is now not in use\r\ndue to other refactorings. It is much cleaner to just have all secure\r\nsettings use new setting names. If in the future we want to reuse the\r\nprevious setting name, once support for the insecure settings have been\r\nremoved, we can then rename the secure setting.  This also adds a test\r\nfor the behavior.\r\n"},"comment":{"url":"https://api.github.com/repos/elastic/elasticsearch/issues/comments/292584447","html_url":"https://github.com/elastic/elasticsearch/pull/23976#issuecomment-292584447","issue_url":"https://api.github.com/repos/elastic/elasticsearch/issues/23976","id":292584447,"user":{"login":"rjernst","id":289412,"avatar_url":"https://avatars0.githubusercontent.com/u/289412?v=3","gravatar_id":"","url":"https://api.github.com/users/rjernst","html_url":"https://github.com/rjernst","followers_url":"https://api.github.com/users/rjernst/followers","following_url":"https://api.github.com/users/rjernst/following{/other_user}","gists_url":"https://api.github.com/users/rjernst/gists{/gist_id}","starred_url":"https://api.github.com/users/rjernst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjernst/subscriptions","organizations_url":"https://api.github.com/users/rjernst/orgs","repos_url":"https://api.github.com/users/rjernst/repos","events_url":"https://api.github.com/users/rjernst/events{/privacy}","received_events_url":"https://api.github.com/users/rjernst/received_events","type":"User","site_admin":false},"created_at":"2017-04-07T16:28:41Z","updated_at":"2017-04-07T16:28:41Z","body":"Note that before this change, if a setting had `allowLegacy=false` (which all of them did), and the setting name existed in elasticsearch.yml, the value would have simply been ignored."}}
{"actor":{"display_login":"rjernst"}}