{"action":"created","issue":{"url":"https://api.github.com/repos/xbmc/xbmc/issues/11520","repository_url":"https://api.github.com/repos/xbmc/xbmc","labels_url":"https://api.github.com/repos/xbmc/xbmc/issues/11520/labels{/name}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/11520/comments","events_url":"https://api.github.com/repos/xbmc/xbmc/issues/11520/events","html_url":"https://github.com/xbmc/xbmc/pull/11520","id":202384040,"number":11520,"title":"[win32][fix] This is the non-backport version of the addon installation fix","user":{"login":"Paxxi","id":874927,"avatar_url":"https://avatars0.githubusercontent.com/u/874927?v=4","gravatar_id":"","url":"https://api.github.com/users/Paxxi","html_url":"https://github.com/Paxxi","followers_url":"https://api.github.com/users/Paxxi/followers","following_url":"https://api.github.com/users/Paxxi/following{/other_user}","gists_url":"https://api.github.com/users/Paxxi/gists{/gist_id}","starred_url":"https://api.github.com/users/Paxxi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Paxxi/subscriptions","organizations_url":"https://api.github.com/users/Paxxi/orgs","repos_url":"https://api.github.com/users/Paxxi/repos","events_url":"https://api.github.com/users/Paxxi/events{/privacy}","received_events_url":"https://api.github.com/users/Paxxi/received_events","type":"User","site_admin":false},"labels":[{"id":276939482,"url":"https://api.github.com/repos/xbmc/xbmc/labels/Addons","name":"Addons","color":"009800","default":false},{"id":241676408,"url":"https://api.github.com/repos/xbmc/xbmc/labels/Backport-Done","name":"Backport-Done","color":"5319e7","default":false},{"id":1659186,"url":"https://api.github.com/repos/xbmc/xbmc/labels/Fix","name":"Fix","color":"0b02e1","default":false},{"id":400751192,"url":"https://api.github.com/repos/xbmc/xbmc/labels/v18%20Leia","name":"v18 Leia","color":"fbca04","default":false},{"id":278156475,"url":"https://api.github.com/repos/xbmc/xbmc/labels/Windows","name":"Windows","color":"006b75","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/xbmc/xbmc/milestones/95","html_url":"https://github.com/xbmc/xbmc/milestone/95","labels_url":"https://api.github.com/repos/xbmc/xbmc/milestones/95/labels","id":2166828,"number":95,"title":"L 18.0-alpha1","description":"","creator":{"login":"MartijnKaijser","id":907436,"avatar_url":"https://avatars1.githubusercontent.com/u/907436?v=4","gravatar_id":"","url":"https://api.github.com/users/MartijnKaijser","html_url":"https://github.com/MartijnKaijser","followers_url":"https://api.github.com/users/MartijnKaijser/followers","following_url":"https://api.github.com/users/MartijnKaijser/following{/other_user}","gists_url":"https://api.github.com/users/MartijnKaijser/gists{/gist_id}","starred_url":"https://api.github.com/users/MartijnKaijser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MartijnKaijser/subscriptions","organizations_url":"https://api.github.com/users/MartijnKaijser/orgs","repos_url":"https://api.github.com/users/MartijnKaijser/repos","events_url":"https://api.github.com/users/MartijnKaijser/events{/privacy}","received_events_url":"https://api.github.com/users/MartijnKaijser/received_events","type":"User","site_admin":false},"open_issues":15,"closed_issues":996,"state":"open","created_at":"2016-11-30T16:58:49Z","updated_at":"2017-07-17T17:32:55Z","due_on":"2017-07-31T07:00:00Z","closed_at":null},"comments":17,"created_at":"2017-01-22T13:48:17Z","updated_at":"2017-07-17T18:17:42Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/11520","html_url":"https://github.com/xbmc/xbmc/pull/11520","diff_url":"https://github.com/xbmc/xbmc/pull/11520.diff","patch_url":"https://github.com/xbmc/xbmc/pull/11520.patch"},"body":"<!--- Provide a general summary of your change in the Title above -->\r\n\r\n## Description\r\n<!--- Describe your change in detail -->\r\n\r\n## Motivation and Context\r\n<!--- Why is this change required? What problem does it solve? -->\r\n<!--- If it fixes an open issue, please link to the issue here -->\r\n\r\n## How Has This Been Tested?\r\n<!--- Please describe in detail how you tested your change -->\r\n<!--- Include details of your testing environment, and the tests you ran to -->\r\n<!--- see how your change affects other areas of the code, etc -->\r\n\r\n## Screenshots (if appropriate):\r\n\r\n## Types of change\r\n<!--- What type of change does your code introduce? Put an `x` in all the boxes that apply like this: [X] -->\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply like this: [X] -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [ ] My code follows the [Code guidelines](https://codedocs.xyz/xbmc/xbmc/code_guidelines.html) of this project \r\n- [ ] My change requires a change to the documentation, either Doxygen or wiki\r\n- [ ] I have updated the documentation accordingly\r\n- [ ] I have read the [CONTRIBUTING](https://github.com/xbmc/xbmc/blob/master/CONTRIBUTING.md) document\r\n- [ ] I have added tests to cover my change\r\n- [ ] All new and existing tests passed\r\n"},"comment":{"url":"https://api.github.com/repos/xbmc/xbmc/issues/comments/315837591","html_url":"https://github.com/xbmc/xbmc/pull/11520#issuecomment-315837591","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/11520","id":315837591,"user":{"login":"Paxxi","id":874927,"avatar_url":"https://avatars0.githubusercontent.com/u/874927?v=4","gravatar_id":"","url":"https://api.github.com/users/Paxxi","html_url":"https://github.com/Paxxi","followers_url":"https://api.github.com/users/Paxxi/followers","following_url":"https://api.github.com/users/Paxxi/following{/other_user}","gists_url":"https://api.github.com/users/Paxxi/gists{/gist_id}","starred_url":"https://api.github.com/users/Paxxi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Paxxi/subscriptions","organizations_url":"https://api.github.com/users/Paxxi/orgs","repos_url":"https://api.github.com/users/Paxxi/repos","events_url":"https://api.github.com/users/Paxxi/events{/privacy}","received_events_url":"https://api.github.com/users/Paxxi/received_events","type":"User","site_admin":false},"created_at":"2017-07-17T18:17:42Z","updated_at":"2017-07-17T18:17:42Z","body":"It's quite simple and fairly reliable.\r\nThe issue we're facing is that antivirus software will notice the extracted addon files and scan them for virus. This wasn't an issue before when we extracted in place. Now that we extract and move there is a window where the files might be locked by an antivirus software.\r\n\r\nThe workaround allows for a reasonable amount of time for the files to be scanned and available to us.\r\n\r\nWe can't handle a case where the file is locked indefinitely and it's not our intention. This works around a specific real world scenario that's causing addon installs to fail. The fix is proven in v17.x as it solved all? reported issues.\r\n\r\nmoving the old addon folder and then removing it isn't an issue as there's no new files so no scan should be triggered."}}
{"actor":{"display_login":"Paxxi"}}