{"action":"created","issue":{"url":"https://api.github.com/repos/travitch/taffybar/issues/209","repository_url":"https://api.github.com/repos/travitch/taffybar","labels_url":"https://api.github.com/repos/travitch/taffybar/issues/209/labels{/name}","comments_url":"https://api.github.com/repos/travitch/taffybar/issues/209/comments","events_url":"https://api.github.com/repos/travitch/taffybar/issues/209/events","html_url":"https://github.com/travitch/taffybar/pull/209","id":244759344,"number":209,"title":"workspace-images: fix preferCustomIcon","user":{"login":"teleshoes","id":592062,"avatar_url":"https://avatars0.githubusercontent.com/u/592062?v=4","gravatar_id":"","url":"https://api.github.com/users/teleshoes","html_url":"https://github.com/teleshoes","followers_url":"https://api.github.com/users/teleshoes/followers","following_url":"https://api.github.com/users/teleshoes/following{/other_user}","gists_url":"https://api.github.com/users/teleshoes/gists{/gist_id}","starred_url":"https://api.github.com/users/teleshoes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teleshoes/subscriptions","organizations_url":"https://api.github.com/users/teleshoes/orgs","repos_url":"https://api.github.com/users/teleshoes/repos","events_url":"https://api.github.com/users/teleshoes/events{/privacy}","received_events_url":"https://api.github.com/users/teleshoes/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-07-21T19:16:21Z","updated_at":"2017-07-21T21:59:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/travitch/taffybar/pulls/209","html_url":"https://github.com/travitch/taffybar/pull/209","diff_url":"https://github.com/travitch/taffybar/pull/209.diff","patch_url":"https://github.com/travitch/taffybar/pull/209.patch"},"body":"tested in `WSS` and `WSHUD`\r\n\r\nthe old prefer-custom-icon behaviour makes `preferCustomIcon=True` useless, as it always overrides the EWMH icon if you use an \"unknown\" icon.\r\n\r\nthis replaces the boolean `preferCustomIcon` with a boolean `hasIcon` param to `customIcon`, letting the pager config handle the situation intelligently.\r\n\r\nthis also allows case-by-case basis for preferring custom icon.\r\n(i use this to override \"unknown\" icon and also certain websites in firefox, and otherwise prefer system icon instead of custom)\r\n\r\nfor folks that use custom icon, this requires tiny change to pagerConfig. if you use system icons only, no change required.\r\n`customIcon t c -> fct t c,` => `customIcon _ t c -> fct t c,`\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/travitch/taffybar/issues/comments/317122291","html_url":"https://github.com/travitch/taffybar/pull/209#issuecomment-317122291","issue_url":"https://api.github.com/repos/travitch/taffybar/issues/209","id":317122291,"user":{"login":"IvanMalison","id":1246619,"avatar_url":"https://avatars3.githubusercontent.com/u/1246619?v=4","gravatar_id":"","url":"https://api.github.com/users/IvanMalison","html_url":"https://github.com/IvanMalison","followers_url":"https://api.github.com/users/IvanMalison/followers","following_url":"https://api.github.com/users/IvanMalison/following{/other_user}","gists_url":"https://api.github.com/users/IvanMalison/gists{/gist_id}","starred_url":"https://api.github.com/users/IvanMalison/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IvanMalison/subscriptions","organizations_url":"https://api.github.com/users/IvanMalison/orgs","repos_url":"https://api.github.com/users/IvanMalison/repos","events_url":"https://api.github.com/users/IvanMalison/events{/privacy}","received_events_url":"https://api.github.com/users/IvanMalison/received_events","type":"User","site_admin":false},"created_at":"2017-07-21T21:59:10Z","updated_at":"2017-07-21T21:59:10Z","body":"kinda a bummer that we have to change the interface here. I also think that Ideally the customIcon function would actually take in as an argument whatever the current icon is instead of taking in a bool. That way you get rid of the conditional logic around whether there is a customIcon/ewmhIcon, and simply always return the result of the customIcon function (which can just return whatever it was passed in if it does not want to override)."}}
{"actor":{"display_login":"IvanMalison"}}