{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/16570","repository_url":"https://api.github.com/repos/ManageIQ/manageiq","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/16570/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/16570/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/16570/events","html_url":"https://github.com/ManageIQ/manageiq/pull/16570","id":278266478,"number":16570,"title":"Use USS (unique set size) instead of PSS for all the things","user":{"login":"jrafanie","id":19339,"avatar_url":"https://avatars0.githubusercontent.com/u/19339?v=4","gravatar_id":"","url":"https://api.github.com/users/jrafanie","html_url":"https://github.com/jrafanie","followers_url":"https://api.github.com/users/jrafanie/followers","following_url":"https://api.github.com/users/jrafanie/following{/other_user}","gists_url":"https://api.github.com/users/jrafanie/gists{/gist_id}","starred_url":"https://api.github.com/users/jrafanie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrafanie/subscriptions","organizations_url":"https://api.github.com/users/jrafanie/orgs","repos_url":"https://api.github.com/users/jrafanie/repos","events_url":"https://api.github.com/users/jrafanie/events{/privacy}","received_events_url":"https://api.github.com/users/jrafanie/received_events","type":"User","site_admin":false},"labels":[{"id":228191939,"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/core/workers","name":"core/workers","color":"5319e7","default":false},{"id":736076551,"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/gaprindashvili/yes","name":"gaprindashvili/yes","color":"000000","default":false},{"id":129042774,"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/performance","name":"performance","color":"e99695","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-11-30T20:54:44Z","updated_at":"2017-12-15T21:58:24Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/16570","html_url":"https://github.com/ManageIQ/manageiq/pull/16570","diff_url":"https://github.com/ManageIQ/manageiq/pull/16570.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/16570.patch"},"body":"Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1479356\r\n\r\nBuilds on top of https://github.com/ManageIQ/manageiq/pull/16569 [MERGED]\r\n\r\n* Change worker validation to check USS not PSS \r\n* Show USS instead of PSS in rake evm:status\r\n* Also log the server/worker unique set size (USS)\r\n\r\nThe first bullet point should alleviate the false positives where a large server process was causing new forked workers to exceed PSS memory thresholds very quickly.  If the server process grows over time, that's a separate problem.  We shouldn't flag and kill workers that inherited a large shared memory, only ones that grow beyond the thresholds on their own.\r\n\r\nFor prior versions such as [euwe](https://github.com/ManageIQ/manageiq/pull/16480) and [fine](https://github.com/ManageIQ/manageiq-gems-pending/pull/313), we can accomplish a similar result by storing the USS in the existing PSS column:\r\n"},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments/352122328","html_url":"https://github.com/ManageIQ/manageiq/pull/16570#issuecomment-352122328","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/16570","id":352122328,"user":{"login":"miq-bot","id":7806257,"avatar_url":"https://avatars1.githubusercontent.com/u/7806257?v=4","gravatar_id":"","url":"https://api.github.com/users/miq-bot","html_url":"https://github.com/miq-bot","followers_url":"https://api.github.com/users/miq-bot/followers","following_url":"https://api.github.com/users/miq-bot/following{/other_user}","gists_url":"https://api.github.com/users/miq-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/miq-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miq-bot/subscriptions","organizations_url":"https://api.github.com/users/miq-bot/orgs","repos_url":"https://api.github.com/users/miq-bot/repos","events_url":"https://api.github.com/users/miq-bot/events{/privacy}","received_events_url":"https://api.github.com/users/miq-bot/received_events","type":"User","site_admin":false},"created_at":"2017-12-15T21:58:24Z","updated_at":"2017-12-15T21:58:24Z","author_association":"MEMBER","body":"<rubocop />Checked commits https://github.com/jrafanie/manageiq/compare/2d758778b55484a96e423317bbf832c5293eb0ed~...ef84a880817385e5f0edc6cbb4410819140999a4 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0\n4 files checked, 0 offenses detected\nEverything looks fine. :cookie:\n"}}
{"actor":{"display_login":"miq-bot"}}