{"action":"created","issue":{"url":"https://api.github.com/repos/google/ExoPlayer/issues/1781","repository_url":"https://api.github.com/repos/google/ExoPlayer","labels_url":"https://api.github.com/repos/google/ExoPlayer/issues/1781/labels{/name}","comments_url":"https://api.github.com/repos/google/ExoPlayer/issues/1781/comments","events_url":"https://api.github.com/repos/google/ExoPlayer/issues/1781/events","html_url":"https://github.com/google/ExoPlayer/pull/1781","id":173393347,"number":1781,"title":"Add DVB subtitles support","user":{"login":"tresvecesseis","id":10452415,"avatar_url":"https://avatars2.githubusercontent.com/u/10452415?v=3","gravatar_id":"","url":"https://api.github.com/users/tresvecesseis","html_url":"https://github.com/tresvecesseis","followers_url":"https://api.github.com/users/tresvecesseis/followers","following_url":"https://api.github.com/users/tresvecesseis/following{/other_user}","gists_url":"https://api.github.com/users/tresvecesseis/gists{/gist_id}","starred_url":"https://api.github.com/users/tresvecesseis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tresvecesseis/subscriptions","organizations_url":"https://api.github.com/users/tresvecesseis/orgs","repos_url":"https://api.github.com/users/tresvecesseis/repos","events_url":"https://api.github.com/users/tresvecesseis/events{/privacy}","received_events_url":"https://api.github.com/users/tresvecesseis/received_events","type":"User","site_admin":false},"labels":[{"id":278711100,"url":"https://api.github.com/repos/google/ExoPlayer/labels/cla:%20yes","name":"cla: yes","color":"159818","default":false}],"state":"open","locked":false,"assignee":{"login":"AquilesCanta","id":8539544,"avatar_url":"https://avatars2.githubusercontent.com/u/8539544?v=3","gravatar_id":"","url":"https://api.github.com/users/AquilesCanta","html_url":"https://github.com/AquilesCanta","followers_url":"https://api.github.com/users/AquilesCanta/followers","following_url":"https://api.github.com/users/AquilesCanta/following{/other_user}","gists_url":"https://api.github.com/users/AquilesCanta/gists{/gist_id}","starred_url":"https://api.github.com/users/AquilesCanta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AquilesCanta/subscriptions","organizations_url":"https://api.github.com/users/AquilesCanta/orgs","repos_url":"https://api.github.com/users/AquilesCanta/repos","events_url":"https://api.github.com/users/AquilesCanta/events{/privacy}","received_events_url":"https://api.github.com/users/AquilesCanta/received_events","type":"User","site_admin":false},"assignees":[{"login":"AquilesCanta","id":8539544,"avatar_url":"https://avatars2.githubusercontent.com/u/8539544?v=3","gravatar_id":"","url":"https://api.github.com/users/AquilesCanta","html_url":"https://github.com/AquilesCanta","followers_url":"https://api.github.com/users/AquilesCanta/followers","following_url":"https://api.github.com/users/AquilesCanta/following{/other_user}","gists_url":"https://api.github.com/users/AquilesCanta/gists{/gist_id}","starred_url":"https://api.github.com/users/AquilesCanta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AquilesCanta/subscriptions","organizations_url":"https://api.github.com/users/AquilesCanta/orgs","repos_url":"https://api.github.com/users/AquilesCanta/repos","events_url":"https://api.github.com/users/AquilesCanta/events{/privacy}","received_events_url":"https://api.github.com/users/AquilesCanta/received_events","type":"User","site_admin":false}],"milestone":null,"comments":30,"created_at":"2016-08-26T08:01:39Z","updated_at":"2017-03-16T18:36:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/google/ExoPlayer/pulls/1781","html_url":"https://github.com/google/ExoPlayer/pull/1781","diff_url":"https://github.com/google/ExoPlayer/pull/1781.diff","patch_url":"https://github.com/google/ExoPlayer/pull/1781.patch"},"body":"Added support for graphic subtitles and use that infrastructure to provide DVB subtitles over MP2T\n"},"comment":{"url":"https://api.github.com/repos/google/ExoPlayer/issues/comments/287152224","html_url":"https://github.com/google/ExoPlayer/pull/1781#issuecomment-287152224","issue_url":"https://api.github.com/repos/google/ExoPlayer/issues/1781","id":287152224,"user":{"login":"kiall","id":52713,"avatar_url":"https://avatars0.githubusercontent.com/u/52713?v=3","gravatar_id":"","url":"https://api.github.com/users/kiall","html_url":"https://github.com/kiall","followers_url":"https://api.github.com/users/kiall/followers","following_url":"https://api.github.com/users/kiall/following{/other_user}","gists_url":"https://api.github.com/users/kiall/gists{/gist_id}","starred_url":"https://api.github.com/users/kiall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiall/subscriptions","organizations_url":"https://api.github.com/users/kiall/orgs","repos_url":"https://api.github.com/users/kiall/repos","events_url":"https://api.github.com/users/kiall/events{/privacy}","received_events_url":"https://api.github.com/users/kiall/received_events","type":"User","site_admin":false},"created_at":"2017-03-16T18:36:44Z","updated_at":"2017-03-16T18:36:44Z","body":"I gave that a shot, and also added a few log statements, diff below. Interestingly, Log.d(TAG, \"TEST: isTextCue \" + isTextCue); only triggers for subrip captions, for dvbsub, it's never triggered. I'll trace through and see what's going on (if I get time tonight..). Anyway, I'm fairly sure this is my issue, rather than yours.. \r\n\r\n    kiall@kiall-z620:~/StudioProjects/ExoPlayer> git diff\r\n    diff --git a/library/src/main/java/com/google/android/exoplayer2/ui/SubtitlePainter.java b/library/src/main/java/com/google/android/exoplayer2/ui/SubtitlePainter.java\r\n    index d4f09b1..1688098 100644\r\n    --- a/library/src/main/java/com/google/android/exoplayer2/ui/SubtitlePainter.java\r\n    +++ b/library/src/main/java/com/google/android/exoplayer2/ui/SubtitlePainter.java\r\n    @@ -146,6 +146,7 @@ import com.google.android.exoplayer2.util.Util;\r\n        float bottomPaddingFraction, Canvas canvas, int cueBoxLeft, int cueBoxTop, int cueBoxRight,\r\n        int cueBoxBottom) {\r\n        boolean isTextCue = cue.bitmap == null;\r\n    +    Log.d(TAG, \"TEST: isTextCue \" + isTextCue);\r\n        CharSequence cueText = null;\r\n        Bitmap cueBitmap = null;\r\n        int windowColor = Color.BLACK;\r\n    @@ -317,7 +318,8 @@ import com.google.android.exoplayer2.util.Util;\r\n            : cueLineAnchor == Cue.ANCHOR_TYPE_MIDDLE ? (anchorX - (width / 2)) : anchorX);\r\n        int y = Math.round(cuePositionAnchor == Cue.ANCHOR_TYPE_END ? (anchorY - height)\r\n            : cuePositionAnchor == Cue.ANCHOR_TYPE_MIDDLE ? (anchorY - (height / 2)) : anchorY);\r\n    -    bitmapRect = new Rect(x, y, x + width, y + height);\r\n    +    Log.d(TAG, \"TEST: In setupBitmapLayout\");\r\n    +    bitmapRect = new Rect(0,0,1920,1080);\r\n    }\r\n    \r\n    private void drawLayout(Canvas canvas, boolean isTextCue) {\r\n    diff --git a/library/src/main/java/com/google/android/exoplayer2/util/MimeTypes.java b/library/src/main/java/com/google/android/exoplayer2/util/MimeTypes.java\r\n    index d3752ea..ea669e6 100644\r\n    --- a/library/src/main/java/com/google/android/exoplayer2/util/MimeTypes.java\r\n    +++ b/library/src/main/java/com/google/android/exoplayer2/util/MimeTypes.java\r\n    @@ -223,7 +223,7 @@ public final class MimeTypes {\r\n            || APPLICATION_SUBRIP.equals(mimeType) || APPLICATION_TTML.equals(mimeType)\r\n            || APPLICATION_TX3G.equals(mimeType) || APPLICATION_MP4VTT.equals(mimeType)\r\n            || APPLICATION_RAWCC.equals(mimeType) || APPLICATION_VOBSUB.equals(mimeType)\r\n    -        || APPLICATION_PGS.equals(mimeType)) {\r\n    +        || APPLICATION_PGS.equals(mimeType) || APPLICATION_DVBSUBS.equals(mimeType)) {\r\n        return C.TRACK_TYPE_TEXT;\r\n        } else if (APPLICATION_ID3.equals(mimeType)\r\n            || APPLICATION_EMSG.equals(mimeType)\r\n"}}
{"actor":{"display_login":"kiall"}}