{"action":"created","issue":{"url":"https://api.github.com/repos/jupyterlab/jupyterlab/issues/3188","repository_url":"https://api.github.com/repos/jupyterlab/jupyterlab","labels_url":"https://api.github.com/repos/jupyterlab/jupyterlab/issues/3188/labels{/name}","comments_url":"https://api.github.com/repos/jupyterlab/jupyterlab/issues/3188/comments","events_url":"https://api.github.com/repos/jupyterlab/jupyterlab/issues/3188/events","html_url":"https://github.com/jupyterlab/jupyterlab/pull/3188","id":271178379,"number":3188,"title":"Fixing codemirror sizing within codeeditor extension","user":{"login":"SimonBiggs","id":6559099,"avatar_url":"https://avatars1.githubusercontent.com/u/6559099?v=4","gravatar_id":"","url":"https://api.github.com/users/SimonBiggs","html_url":"https://github.com/SimonBiggs","followers_url":"https://api.github.com/users/SimonBiggs/followers","following_url":"https://api.github.com/users/SimonBiggs/following{/other_user}","gists_url":"https://api.github.com/users/SimonBiggs/gists{/gist_id}","starred_url":"https://api.github.com/users/SimonBiggs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimonBiggs/subscriptions","organizations_url":"https://api.github.com/users/SimonBiggs/orgs","repos_url":"https://api.github.com/users/SimonBiggs/repos","events_url":"https://api.github.com/users/SimonBiggs/events{/privacy}","received_events_url":"https://api.github.com/users/SimonBiggs/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2017-11-04T09:14:29Z","updated_at":"2017-11-06T13:41:05Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/jupyterlab/jupyterlab/pulls/3188","html_url":"https://github.com/jupyterlab/jupyterlab/pull/3188","diff_url":"https://github.com/jupyterlab/jupyterlab/pull/3188.diff","patch_url":"https://github.com/jupyterlab/jupyterlab/pull/3188.patch"},"body":"Hi @blink1073,\r\n\r\nI noticed a codeeditor overflow issue: \r\n\r\n![image](https://user-images.githubusercontent.com/6559099/32404037-514ad434-c19c-11e7-923c-95b2aca402f1.png)\r\n\r\nThe codemirror sizing was larger than the actual viewable area. This results in the x and y overflows being cut off. I imagine the culprits were a border in the x direction and the ::before in the y direction.\r\n\r\nI fixed this by making a hard coded adjustment to account for the ::before and the border. I imagine this isn't what the final code should be though. Is there a way to reference css variables within javascript?"},"comment":{"url":"https://api.github.com/repos/jupyterlab/jupyterlab/issues/comments/342151446","html_url":"https://github.com/jupyterlab/jupyterlab/pull/3188#issuecomment-342151446","issue_url":"https://api.github.com/repos/jupyterlab/jupyterlab/issues/3188","id":342151446,"user":{"login":"sccolbert","id":137289,"avatar_url":"https://avatars0.githubusercontent.com/u/137289?v=4","gravatar_id":"","url":"https://api.github.com/users/sccolbert","html_url":"https://github.com/sccolbert","followers_url":"https://api.github.com/users/sccolbert/followers","following_url":"https://api.github.com/users/sccolbert/following{/other_user}","gists_url":"https://api.github.com/users/sccolbert/gists{/gist_id}","starred_url":"https://api.github.com/users/sccolbert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sccolbert/subscriptions","organizations_url":"https://api.github.com/users/sccolbert/orgs","repos_url":"https://api.github.com/users/sccolbert/repos","events_url":"https://api.github.com/users/sccolbert/events{/privacy}","received_events_url":"https://api.github.com/users/sccolbert/received_events","type":"User","site_admin":false},"created_at":"2017-11-06T13:41:04Z","updated_at":"2017-11-06T13:41:04Z","author_association":"CONTRIBUTOR","body":"Best solution is don't use pseudoelements for that top bar.\n\nOn Nov 6, 2017 06:57, \"Steven Silvester\" <notifications@github.com> wrote:\n\n> I think you can use height - cmEl.offsetTop and width - cmEl.offsetBottom\n> where cmEl is the first child of this.node. I don't think we want to use\n> flex here given the nested flex bug on Firefox. cf #1639 (comment)\n> <https://github.com/jupyterlab/jupyterlab/issues/1639#issuecomment-310179661>\n>\n> —\n> You are receiving this because you are subscribed to this thread.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/jupyterlab/jupyterlab/pull/3188#issuecomment-342140749>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/AAIYSXqB0kO0RLO5Q-aUa78cBmILPQprks5szwIzgaJpZM4QR8aL>\n> .\n>\n"}}
{"actor":{"display_login":"sccolbert"}}