{"action":"created","comment":{"url":"https://api.github.com/repos/opentx/opentx/pulls/comments/153650499","pull_request_review_id":79688222,"id":153650499,"diff_hunk":"@@ -37,12 +38,16 @@ class LogicalSwitchesPanel : public ModelPanel\n     virtual void update();\n \n   private slots:\n-    void edited();\n+    void setDataModels();\n+    void functionChanged();\n     void v1Edited(int value);\n     void v2Edited(int value);\n     void andEdited(int value);\n     void durationEdited(double duration);\n     void delayEdited(double delay);\n+    void offsetEdited();","path":"companion/src/modeledit/logicalswitches.h","position":20,"original_position":20,"commit_id":"a2fab20ff2023fdd3323515ba5fccf8ec8240cf7","original_commit_id":"a2fab20ff2023fdd3323515ba5fccf8ec8240cf7","user":{"login":"opentx-sonar","id":33784529,"avatar_url":"https://avatars3.githubusercontent.com/u/33784529?v=4","gravatar_id":"","url":"https://api.github.com/users/opentx-sonar","html_url":"https://github.com/opentx-sonar","followers_url":"https://api.github.com/users/opentx-sonar/followers","following_url":"https://api.github.com/users/opentx-sonar/following{/other_user}","gists_url":"https://api.github.com/users/opentx-sonar/gists{/gist_id}","starred_url":"https://api.github.com/users/opentx-sonar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opentx-sonar/subscriptions","organizations_url":"https://api.github.com/users/opentx-sonar/orgs","repos_url":"https://api.github.com/users/opentx-sonar/repos","events_url":"https://api.github.com/users/opentx-sonar/events{/privacy}","received_events_url":"https://api.github.com/users/opentx-sonar/received_events","type":"User","site_admin":false},"body":"![MAJOR](https://sonarsource.github.io/sonar-github/severity-major.png 'Severity: MAJOR') Remove this unused private function. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonarcloud.io/coding_rules#rule_key=cpp%3AS1144)\n","created_at":"2017-11-28T23:05:00Z","updated_at":"2017-11-28T23:05:00Z","html_url":"https://github.com/opentx/opentx/pull/5437#discussion_r153650499","pull_request_url":"https://api.github.com/repos/opentx/opentx/pulls/5437","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/opentx/opentx/pulls/comments/153650499"},"html":{"href":"https://github.com/opentx/opentx/pull/5437#discussion_r153650499"},"pull_request":{"href":"https://api.github.com/repos/opentx/opentx/pulls/5437"}}},"pull_request":{"url":"https://api.github.com/repos/opentx/opentx/pulls/5437","id":155204834,"html_url":"https://github.com/opentx/opentx/pull/5437","diff_url":"https://github.com/opentx/opentx/pull/5437.diff","patch_url":"https://github.com/opentx/opentx/pull/5437.patch","issue_url":"https://api.github.com/repos/opentx/opentx/issues/5437","number":5437,"state":"open","locked":false,"title":"[Companion] Timers & RTC ranges and editors in LS/CF/Telemetry","user":{"login":"mpaperno","id":1366615,"avatar_url":"https://avatars2.githubusercontent.com/u/1366615?v=4","gravatar_id":"","url":"https://api.github.com/users/mpaperno","html_url":"https://github.com/mpaperno","followers_url":"https://api.github.com/users/mpaperno/followers","following_url":"https://api.github.com/users/mpaperno/following{/other_user}","gists_url":"https://api.github.com/users/mpaperno/gists{/gist_id}","starred_url":"https://api.github.com/users/mpaperno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpaperno/subscriptions","organizations_url":"https://api.github.com/users/mpaperno/orgs","repos_url":"https://api.github.com/users/mpaperno/repos","events_url":"https://api.github.com/users/mpaperno/events{/privacy}","received_events_url":"https://api.github.com/users/mpaperno/received_events","type":"User","site_admin":false},"body":"Went down a rabbit hole with regards to timer and RTC ranges and how they're used/limited/edited in regards to LS (comparison functions), CF (set timerN action), and telemetry display bar limits.  Seems there's a bit of confusion here both in Companion and on radio (probably due to legacy issues).\r\n\r\nFixes #2984\r\nFixes #5362  (also negative values were not possible)\r\nFixes #5374\r\nFixes #5375\r\nFixes timer and RTC time ranges to comply with firmware limits.\r\nFixes not being able to use RTC time in LSs.\r\nFixes newly-added LS not being available in source lists (except when pasting).\r\nFixes bug with timer/rtc comparison values getting reset to value of spin box instead of time editor.\r\nNew TimerEdit GUI component for negative and other typically \"invalid\" times.\r\n\r\nThere are some issues/questions on the firmware side... I found a couple small bugs and will open a separate PR and bring them up there.  \r\n\r\nBut the main question is why the limit of +/- 23m59s on timer values for LS comparison functions and telem. bar display min/max since the variable types (in firmware) can handle a lot more than that.","created_at":"2017-11-28T22:51:29Z","updated_at":"2017-11-28T23:05:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a174f402fd9bdcb446f0c16f4d02744433167acf","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/opentx/opentx/pulls/5437/commits","review_comments_url":"https://api.github.com/repos/opentx/opentx/pulls/5437/comments","review_comment_url":"https://api.github.com/repos/opentx/opentx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opentx/opentx/issues/5437/comments","statuses_url":"https://api.github.com/repos/opentx/opentx/statuses/a2fab20ff2023fdd3323515ba5fccf8ec8240cf7","head":{"label":"opentx:mpaperno/cpn_timers_range","ref":"mpaperno/cpn_timers_range","sha":"a2fab20ff2023fdd3323515ba5fccf8ec8240cf7","user":{"login":"opentx","id":6073522,"avatar_url":"https://avatars2.githubusercontent.com/u/6073522?v=4","gravatar_id":"","url":"https://api.github.com/users/opentx","html_url":"https://github.com/opentx","followers_url":"https://api.github.com/users/opentx/followers","following_url":"https://api.github.com/users/opentx/following{/other_user}","gists_url":"https://api.github.com/users/opentx/gists{/gist_id}","starred_url":"https://api.github.com/users/opentx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opentx/subscriptions","organizations_url":"https://api.github.com/users/opentx/orgs","repos_url":"https://api.github.com/users/opentx/repos","events_url":"https://api.github.com/users/opentx/events{/privacy}","received_events_url":"https://api.github.com/users/opentx/received_events","type":"Organization","site_admin":false},"repo":{"id":14794708,"name":"opentx","full_name":"opentx/opentx","owner":{"login":"opentx","id":6073522,"avatar_url":"https://avatars2.githubusercontent.com/u/6073522?v=4","gravatar_id":"","url":"https://api.github.com/users/opentx","html_url":"https://github.com/opentx","followers_url":"https://api.github.com/users/opentx/followers","following_url":"https://api.github.com/users/opentx/following{/other_user}","gists_url":"https://api.github.com/users/opentx/gists{/gist_id}","starred_url":"https://api.github.com/users/opentx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opentx/subscriptions","organizations_url":"https://api.github.com/users/opentx/orgs","repos_url":"https://api.github.com/users/opentx/repos","events_url":"https://api.github.com/users/opentx/events{/privacy}","received_events_url":"https://api.github.com/users/opentx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opentx/opentx","description":"OpenTX custom firmware for Transmitters","fork":false,"url":"https://api.github.com/repos/opentx/opentx","forks_url":"https://api.github.com/repos/opentx/opentx/forks","keys_url":"https://api.github.com/repos/opentx/opentx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opentx/opentx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opentx/opentx/teams","hooks_url":"https://api.github.com/repos/opentx/opentx/hooks","issue_events_url":"https://api.github.com/repos/opentx/opentx/issues/events{/number}","events_url":"https://api.github.com/repos/opentx/opentx/events","assignees_url":"https://api.github.com/repos/opentx/opentx/assignees{/user}","branches_url":"https://api.github.com/repos/opentx/opentx/branches{/branch}","tags_url":"https://api.github.com/repos/opentx/opentx/tags","blobs_url":"https://api.github.com/repos/opentx/opentx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opentx/opentx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opentx/opentx/git/refs{/sha}","trees_url":"https://api.github.com/repos/opentx/opentx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opentx/opentx/statuses/{sha}","languages_url":"https://api.github.com/repos/opentx/opentx/languages","stargazers_url":"https://api.github.com/repos/opentx/opentx/stargazers","contributors_url":"https://api.github.com/repos/opentx/opentx/contributors","subscribers_url":"https://api.github.com/repos/opentx/opentx/subscribers","subscription_url":"https://api.github.com/repos/opentx/opentx/subscription","commits_url":"https://api.github.com/repos/opentx/opentx/commits{/sha}","git_commits_url":"https://api.github.com/repos/opentx/opentx/git/commits{/sha}","comments_url":"https://api.github.com/repos/opentx/opentx/comments{/number}","issue_comment_url":"https://api.github.com/repos/opentx/opentx/issues/comments{/number}","contents_url":"https://api.github.com/repos/opentx/opentx/contents/{+path}","compare_url":"https://api.github.com/repos/opentx/opentx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opentx/opentx/merges","archive_url":"https://api.github.com/repos/opentx/opentx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opentx/opentx/downloads","issues_url":"https://api.github.com/repos/opentx/opentx/issues{/number}","pulls_url":"https://api.github.com/repos/opentx/opentx/pulls{/number}","milestones_url":"https://api.github.com/repos/opentx/opentx/milestones{/number}","notifications_url":"https://api.github.com/repos/opentx/opentx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opentx/opentx/labels{/name}","releases_url":"https://api.github.com/repos/opentx/opentx/releases{/id}","deployments_url":"https://api.github.com/repos/opentx/opentx/deployments","created_at":"2013-11-29T07:02:56Z","updated_at":"2017-11-23T13:44:52Z","pushed_at":"2017-11-28T22:51:30Z","git_url":"git://github.com/opentx/opentx.git","ssh_url":"git@github.com:opentx/opentx.git","clone_url":"https://github.com/opentx/opentx.git","svn_url":"https://github.com/opentx/opentx","homepage":"","size":150809,"stargazers_count":640,"watchers_count":640,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":349,"mirror_url":null,"archived":false,"open_issues_count":518,"license":null,"forks":349,"open_issues":518,"watchers":640,"default_branch":"2.2"}},"base":{"label":"opentx:2.2","ref":"2.2","sha":"0f34bf38504b1e6078b2d8c957db610d27b8b51b","user":{"login":"opentx","id":6073522,"avatar_url":"https://avatars2.githubusercontent.com/u/6073522?v=4","gravatar_id":"","url":"https://api.github.com/users/opentx","html_url":"https://github.com/opentx","followers_url":"https://api.github.com/users/opentx/followers","following_url":"https://api.github.com/users/opentx/following{/other_user}","gists_url":"https://api.github.com/users/opentx/gists{/gist_id}","starred_url":"https://api.github.com/users/opentx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opentx/subscriptions","organizations_url":"https://api.github.com/users/opentx/orgs","repos_url":"https://api.github.com/users/opentx/repos","events_url":"https://api.github.com/users/opentx/events{/privacy}","received_events_url":"https://api.github.com/users/opentx/received_events","type":"Organization","site_admin":false},"repo":{"id":14794708,"name":"opentx","full_name":"opentx/opentx","owner":{"login":"opentx","id":6073522,"avatar_url":"https://avatars2.githubusercontent.com/u/6073522?v=4","gravatar_id":"","url":"https://api.github.com/users/opentx","html_url":"https://github.com/opentx","followers_url":"https://api.github.com/users/opentx/followers","following_url":"https://api.github.com/users/opentx/following{/other_user}","gists_url":"https://api.github.com/users/opentx/gists{/gist_id}","starred_url":"https://api.github.com/users/opentx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opentx/subscriptions","organizations_url":"https://api.github.com/users/opentx/orgs","repos_url":"https://api.github.com/users/opentx/repos","events_url":"https://api.github.com/users/opentx/events{/privacy}","received_events_url":"https://api.github.com/users/opentx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opentx/opentx","description":"OpenTX custom firmware for Transmitters","fork":false,"url":"https://api.github.com/repos/opentx/opentx","forks_url":"https://api.github.com/repos/opentx/opentx/forks","keys_url":"https://api.github.com/repos/opentx/opentx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opentx/opentx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opentx/opentx/teams","hooks_url":"https://api.github.com/repos/opentx/opentx/hooks","issue_events_url":"https://api.github.com/repos/opentx/opentx/issues/events{/number}","events_url":"https://api.github.com/repos/opentx/opentx/events","assignees_url":"https://api.github.com/repos/opentx/opentx/assignees{/user}","branches_url":"https://api.github.com/repos/opentx/opentx/branches{/branch}","tags_url":"https://api.github.com/repos/opentx/opentx/tags","blobs_url":"https://api.github.com/repos/opentx/opentx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opentx/opentx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opentx/opentx/git/refs{/sha}","trees_url":"https://api.github.com/repos/opentx/opentx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opentx/opentx/statuses/{sha}","languages_url":"https://api.github.com/repos/opentx/opentx/languages","stargazers_url":"https://api.github.com/repos/opentx/opentx/stargazers","contributors_url":"https://api.github.com/repos/opentx/opentx/contributors","subscribers_url":"https://api.github.com/repos/opentx/opentx/subscribers","subscription_url":"https://api.github.com/repos/opentx/opentx/subscription","commits_url":"https://api.github.com/repos/opentx/opentx/commits{/sha}","git_commits_url":"https://api.github.com/repos/opentx/opentx/git/commits{/sha}","comments_url":"https://api.github.com/repos/opentx/opentx/comments{/number}","issue_comment_url":"https://api.github.com/repos/opentx/opentx/issues/comments{/number}","contents_url":"https://api.github.com/repos/opentx/opentx/contents/{+path}","compare_url":"https://api.github.com/repos/opentx/opentx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opentx/opentx/merges","archive_url":"https://api.github.com/repos/opentx/opentx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opentx/opentx/downloads","issues_url":"https://api.github.com/repos/opentx/opentx/issues{/number}","pulls_url":"https://api.github.com/repos/opentx/opentx/pulls{/number}","milestones_url":"https://api.github.com/repos/opentx/opentx/milestones{/number}","notifications_url":"https://api.github.com/repos/opentx/opentx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opentx/opentx/labels{/name}","releases_url":"https://api.github.com/repos/opentx/opentx/releases{/id}","deployments_url":"https://api.github.com/repos/opentx/opentx/deployments","created_at":"2013-11-29T07:02:56Z","updated_at":"2017-11-23T13:44:52Z","pushed_at":"2017-11-28T22:51:30Z","git_url":"git://github.com/opentx/opentx.git","ssh_url":"git@github.com:opentx/opentx.git","clone_url":"https://github.com/opentx/opentx.git","svn_url":"https://github.com/opentx/opentx","homepage":"","size":150809,"stargazers_count":640,"watchers_count":640,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":349,"mirror_url":null,"archived":false,"open_issues_count":518,"license":null,"forks":349,"open_issues":518,"watchers":640,"default_branch":"2.2"}},"_links":{"self":{"href":"https://api.github.com/repos/opentx/opentx/pulls/5437"},"html":{"href":"https://github.com/opentx/opentx/pull/5437"},"issue":{"href":"https://api.github.com/repos/opentx/opentx/issues/5437"},"comments":{"href":"https://api.github.com/repos/opentx/opentx/issues/5437/comments"},"review_comments":{"href":"https://api.github.com/repos/opentx/opentx/pulls/5437/comments"},"review_comment":{"href":"https://api.github.com/repos/opentx/opentx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opentx/opentx/pulls/5437/commits"},"statuses":{"href":"https://api.github.com/repos/opentx/opentx/statuses/a2fab20ff2023fdd3323515ba5fccf8ec8240cf7"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"opentx-sonar"}}