{"action":"created","issue":{"url":"https://api.github.com/repos/MahdiSafsafi/zcontrols/issues/15","repository_url":"https://api.github.com/repos/MahdiSafsafi/zcontrols","labels_url":"https://api.github.com/repos/MahdiSafsafi/zcontrols/issues/15/labels{/name}","comments_url":"https://api.github.com/repos/MahdiSafsafi/zcontrols/issues/15/comments","events_url":"https://api.github.com/repos/MahdiSafsafi/zcontrols/issues/15/events","html_url":"https://github.com/MahdiSafsafi/zcontrols/pull/15","id":231257953,"number":15,"title":"Fixed AV occurs on change component while editing some property","user":{"login":"benok","id":5987609,"avatar_url":"https://avatars2.githubusercontent.com/u/5987609?v=3","gravatar_id":"","url":"https://api.github.com/users/benok","html_url":"https://github.com/benok","followers_url":"https://api.github.com/users/benok/followers","following_url":"https://api.github.com/users/benok/following{/other_user}","gists_url":"https://api.github.com/users/benok/gists{/gist_id}","starred_url":"https://api.github.com/users/benok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benok/subscriptions","organizations_url":"https://api.github.com/users/benok/orgs","repos_url":"https://api.github.com/users/benok/repos","events_url":"https://api.github.com/users/benok/events{/privacy}","received_events_url":"https://api.github.com/users/benok/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-05-25T07:02:55Z","updated_at":"2017-05-29T05:16:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/MahdiSafsafi/zcontrols/pulls/15","html_url":"https://github.com/MahdiSafsafi/zcontrols/pull/15","diff_url":"https://github.com/MahdiSafsafi/zcontrols/pull/15.diff","patch_url":"https://github.com/MahdiSafsafi/zcontrols/pull/15.patch"},"body":"Hi, I added additional quick fix for [the AV problem you wrote](https://github.com/MahdiSafsafi/zcontrols/pull/12#issuecomment-300127663\r\n) before.\r\n\r\nI can confirm the problem with [madExcept](http://www.madshi.net/madExceptDescription.htm) with[ \"instantly crash on buffer overrun\" option](http://help.madshi.net/madExceptSettings1.htm).\r\n(Without madExcept with this option, whether AV occurs or not depends on the contents of the current memory. That's why I can't reproduce the AV before.)\r\n\r\nWithout this patch, UpdateButton is called before SetPropItem is called.\r\n(You can see FPropItem has invalid address below)\r\n![\"call stack\"](http://i.imgur.com/PMcjoRK.png \"call stack\")\r\n\r\nThis patch may not be best solution to fix the problem, but It seems to work :-)"},"comment":{"url":"https://api.github.com/repos/MahdiSafsafi/zcontrols/issues/comments/304574187","html_url":"https://github.com/MahdiSafsafi/zcontrols/pull/15#issuecomment-304574187","issue_url":"https://api.github.com/repos/MahdiSafsafi/zcontrols/issues/15","id":304574187,"user":{"login":"benok","id":5987609,"avatar_url":"https://avatars2.githubusercontent.com/u/5987609?v=3","gravatar_id":"","url":"https://api.github.com/users/benok","html_url":"https://github.com/benok","followers_url":"https://api.github.com/users/benok/followers","following_url":"https://api.github.com/users/benok/following{/other_user}","gists_url":"https://api.github.com/users/benok/gists{/gist_id}","starred_url":"https://api.github.com/users/benok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benok/subscriptions","organizations_url":"https://api.github.com/users/benok/orgs","repos_url":"https://api.github.com/users/benok/repos","events_url":"https://api.github.com/users/benok/events{/privacy}","received_events_url":"https://api.github.com/users/benok/received_events","type":"User","site_admin":false},"created_at":"2017-05-29T05:15:59Z","updated_at":"2017-05-29T05:15:59Z","body":"Hmm, could you try [madExcept](http://www.madshi.net/madExceptDescription.htm) with[ \"instantly crash on buffer overrun\" option](http://help.madshi.net/madExceptSettings1.htm) ? \r\nWithout this, the sample program runs without error.\r\n\r\nBut checking with madExcpet and the above option, Access Violation occurs 100%.\r\nPlease check the order of the above handlers I wrote called.\r\nI think you will find this patch or other additional logic is required to fix the AV.\r\n\r\np.s.\r\nmadExcept is very informative for every Delphi developers.\r\nI used madExcept  several years to collect the call stack of the occurred exception on the user's environment.\r\nBut I didn't notice the power of \"instantly crush on buffer overrun\" option until last month.\r\nWith the aid of this option, I could fix some rarely happened and head aching Access Violation problem from our developing product."}}
{"actor":{"display_login":"benok"}}