{"action":"created","comment":{"url":"https://api.github.com/repos/ansible/ansible/pulls/comments/143353946","pull_request_review_id":67856641,"id":143353946,"diff_hunk":"@@ -31,7 +32,7 @@\n   datacenter_name:\n     description:\n     - Name of the datacenter to add the host.\n-    required: yes\n+    required: no","path":"lib/ansible/modules/cloud/vmware/vmware_host.py","position":19,"original_position":19,"commit_id":"b85c7e7e203d27f30966f2dabc725ff6f70fce76","original_commit_id":"b85c7e7e203d27f30966f2dabc725ff6f70fce76","user":{"login":"Akasurde","id":633765,"avatar_url":"https://avatars1.githubusercontent.com/u/633765?v=4","gravatar_id":"","url":"https://api.github.com/users/Akasurde","html_url":"https://github.com/Akasurde","followers_url":"https://api.github.com/users/Akasurde/followers","following_url":"https://api.github.com/users/Akasurde/following{/other_user}","gists_url":"https://api.github.com/users/Akasurde/gists{/gist_id}","starred_url":"https://api.github.com/users/Akasurde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Akasurde/subscriptions","organizations_url":"https://api.github.com/users/Akasurde/orgs","repos_url":"https://api.github.com/users/Akasurde/repos","events_url":"https://api.github.com/users/Akasurde/events{/privacy}","received_events_url":"https://api.github.com/users/Akasurde/received_events","type":"User","site_admin":false},"body":"datacenter_name is required parameter.","created_at":"2017-10-08T12:57:24Z","updated_at":"2017-10-08T13:03:52Z","html_url":"https://github.com/ansible/ansible/pull/30582#discussion_r143353946","pull_request_url":"https://api.github.com/repos/ansible/ansible/pulls/30582","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ansible/ansible/pulls/comments/143353946"},"html":{"href":"https://github.com/ansible/ansible/pull/30582#discussion_r143353946"},"pull_request":{"href":"https://api.github.com/repos/ansible/ansible/pulls/30582"}}},"pull_request":{"url":"https://api.github.com/repos/ansible/ansible/pulls/30582","id":141966518,"html_url":"https://github.com/ansible/ansible/pull/30582","diff_url":"https://github.com/ansible/ansible/pull/30582.diff","patch_url":"https://github.com/ansible/ansible/pull/30582.patch","issue_url":"https://api.github.com/repos/ansible/ansible/issues/30582","number":30582,"state":"open","locked":false,"title":"vmware_host: add reconnect and add_or_reconnect states","user":{"login":"tchernomax","id":6161102,"avatar_url":"https://avatars2.githubusercontent.com/u/6161102?v=4","gravatar_id":"","url":"https://api.github.com/users/tchernomax","html_url":"https://github.com/tchernomax","followers_url":"https://api.github.com/users/tchernomax/followers","following_url":"https://api.github.com/users/tchernomax/following{/other_user}","gists_url":"https://api.github.com/users/tchernomax/gists{/gist_id}","starred_url":"https://api.github.com/users/tchernomax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tchernomax/subscriptions","organizations_url":"https://api.github.com/users/tchernomax/orgs","repos_url":"https://api.github.com/users/tchernomax/repos","events_url":"https://api.github.com/users/tchernomax/events{/privacy}","received_events_url":"https://api.github.com/users/tchernomax/received_events","type":"User","site_admin":false},"body":"##### SUMMARY\r\n\r\nAdd \"reconnect\" and \"add_or_reconnect\" choices for \"state\" in vmware_host module.\r\n\r\n* reconnect: reconnect an esxi to a vcenter (imply it is present).\r\n* add_or_reconnect: do the same but add the esxi if absent.\r\n\r\nAlso:\r\n* tag the cluster_name as required (because it is).\r\n* tag esxi_username and esxi_password as not required because\r\n    they aren't when the esxi isn't added.\r\n\r\n##### ISSUE TYPE\r\n\r\n - Feature Pull Request\r\n\r\n##### COMPONENT NAME\r\n\r\nvmware_host\r\n\r\n##### ANSIBLE VERSION\r\n\r\n```\r\nansible 2.5.0 (vmware_host 7fe1b45ba6) last updated 2017/09/19 23:52:13 (GMT +200)\r\n  config file = /home/max/.ansible.cfg\r\n  configured module search path = ['/home/max/.ansible/modules']\r\n  ansible python module location = /home/max/Documents/repositories-github/ansible/lib/ansible\r\n  executable location = /home/max/Documents/repositories-github/ansible/bin/ansible\r\n  python version = 3.6.2 (default, Jul 20 2017, 03:52:27) [GCC 7.1.1 20170630]\r\n```","created_at":"2017-09-19T21:57:15Z","updated_at":"2017-10-08T13:03:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f1a0f36f3804ef28741ab72f55bbc1c732fe2405","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ansible/ansible/pulls/30582/commits","review_comments_url":"https://api.github.com/repos/ansible/ansible/pulls/30582/comments","review_comment_url":"https://api.github.com/repos/ansible/ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ansible/ansible/issues/30582/comments","statuses_url":"https://api.github.com/repos/ansible/ansible/statuses/b85c7e7e203d27f30966f2dabc725ff6f70fce76","head":{"label":"tchernomax:vmware_host","ref":"vmware_host","sha":"b85c7e7e203d27f30966f2dabc725ff6f70fce76","user":{"login":"tchernomax","id":6161102,"avatar_url":"https://avatars2.githubusercontent.com/u/6161102?v=4","gravatar_id":"","url":"https://api.github.com/users/tchernomax","html_url":"https://github.com/tchernomax","followers_url":"https://api.github.com/users/tchernomax/followers","following_url":"https://api.github.com/users/tchernomax/following{/other_user}","gists_url":"https://api.github.com/users/tchernomax/gists{/gist_id}","starred_url":"https://api.github.com/users/tchernomax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tchernomax/subscriptions","organizations_url":"https://api.github.com/users/tchernomax/orgs","repos_url":"https://api.github.com/users/tchernomax/repos","events_url":"https://api.github.com/users/tchernomax/events{/privacy}","received_events_url":"https://api.github.com/users/tchernomax/received_events","type":"User","site_admin":false},"repo":{"id":75485802,"name":"ansible","full_name":"tchernomax/ansible","owner":{"login":"tchernomax","id":6161102,"avatar_url":"https://avatars2.githubusercontent.com/u/6161102?v=4","gravatar_id":"","url":"https://api.github.com/users/tchernomax","html_url":"https://github.com/tchernomax","followers_url":"https://api.github.com/users/tchernomax/followers","following_url":"https://api.github.com/users/tchernomax/following{/other_user}","gists_url":"https://api.github.com/users/tchernomax/gists{/gist_id}","starred_url":"https://api.github.com/users/tchernomax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tchernomax/subscriptions","organizations_url":"https://api.github.com/users/tchernomax/orgs","repos_url":"https://api.github.com/users/tchernomax/repos","events_url":"https://api.github.com/users/tchernomax/events{/privacy}","received_events_url":"https://api.github.com/users/tchernomax/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tchernomax/ansible","description":"Ansible is a radically simple IT automation platform that makes your applications and systems easier to deploy. Avoid writing scripts or custom code to deploy and update your applications— automate in a language that approaches plain English, using SSH, with no agents to install on remote systems.","fork":true,"url":"https://api.github.com/repos/tchernomax/ansible","forks_url":"https://api.github.com/repos/tchernomax/ansible/forks","keys_url":"https://api.github.com/repos/tchernomax/ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tchernomax/ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tchernomax/ansible/teams","hooks_url":"https://api.github.com/repos/tchernomax/ansible/hooks","issue_events_url":"https://api.github.com/repos/tchernomax/ansible/issues/events{/number}","events_url":"https://api.github.com/repos/tchernomax/ansible/events","assignees_url":"https://api.github.com/repos/tchernomax/ansible/assignees{/user}","branches_url":"https://api.github.com/repos/tchernomax/ansible/branches{/branch}","tags_url":"https://api.github.com/repos/tchernomax/ansible/tags","blobs_url":"https://api.github.com/repos/tchernomax/ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tchernomax/ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tchernomax/ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/tchernomax/ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tchernomax/ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/tchernomax/ansible/languages","stargazers_url":"https://api.github.com/repos/tchernomax/ansible/stargazers","contributors_url":"https://api.github.com/repos/tchernomax/ansible/contributors","subscribers_url":"https://api.github.com/repos/tchernomax/ansible/subscribers","subscription_url":"https://api.github.com/repos/tchernomax/ansible/subscription","commits_url":"https://api.github.com/repos/tchernomax/ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/tchernomax/ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/tchernomax/ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/tchernomax/ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/tchernomax/ansible/contents/{+path}","compare_url":"https://api.github.com/repos/tchernomax/ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tchernomax/ansible/merges","archive_url":"https://api.github.com/repos/tchernomax/ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tchernomax/ansible/downloads","issues_url":"https://api.github.com/repos/tchernomax/ansible/issues{/number}","pulls_url":"https://api.github.com/repos/tchernomax/ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/tchernomax/ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/tchernomax/ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tchernomax/ansible/labels{/name}","releases_url":"https://api.github.com/repos/tchernomax/ansible/releases{/id}","deployments_url":"https://api.github.com/repos/tchernomax/ansible/deployments","created_at":"2016-12-03T16:34:26Z","updated_at":"2016-12-03T16:34:38Z","pushed_at":"2017-09-28T20:56:30Z","git_url":"git://github.com/tchernomax/ansible.git","ssh_url":"git@github.com:tchernomax/ansible.git","clone_url":"https://github.com/tchernomax/ansible.git","svn_url":"https://github.com/tchernomax/ansible","homepage":"http://ansible.com/","size":85576,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"devel"}},"base":{"label":"ansible:devel","ref":"devel","sha":"79839615e7a210d4a30377c96ab70ead25697b03","user":{"login":"ansible","id":1507452,"avatar_url":"https://avatars2.githubusercontent.com/u/1507452?v=4","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"repo":{"id":3638964,"name":"ansible","full_name":"ansible/ansible","owner":{"login":"ansible","id":1507452,"avatar_url":"https://avatars2.githubusercontent.com/u/1507452?v=4","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ansible/ansible","description":"Ansible is a radically simple IT automation platform that makes your applications and systems easier to deploy. Avoid writing scripts or custom code to deploy and update your applications— automate in a language that approaches plain English, using SSH, with no agents to install on remote systems.","fork":false,"url":"https://api.github.com/repos/ansible/ansible","forks_url":"https://api.github.com/repos/ansible/ansible/forks","keys_url":"https://api.github.com/repos/ansible/ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ansible/ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ansible/ansible/teams","hooks_url":"https://api.github.com/repos/ansible/ansible/hooks","issue_events_url":"https://api.github.com/repos/ansible/ansible/issues/events{/number}","events_url":"https://api.github.com/repos/ansible/ansible/events","assignees_url":"https://api.github.com/repos/ansible/ansible/assignees{/user}","branches_url":"https://api.github.com/repos/ansible/ansible/branches{/branch}","tags_url":"https://api.github.com/repos/ansible/ansible/tags","blobs_url":"https://api.github.com/repos/ansible/ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ansible/ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ansible/ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/ansible/ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ansible/ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/ansible/ansible/languages","stargazers_url":"https://api.github.com/repos/ansible/ansible/stargazers","contributors_url":"https://api.github.com/repos/ansible/ansible/contributors","subscribers_url":"https://api.github.com/repos/ansible/ansible/subscribers","subscription_url":"https://api.github.com/repos/ansible/ansible/subscription","commits_url":"https://api.github.com/repos/ansible/ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/ansible/ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/ansible/ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/ansible/ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/ansible/ansible/contents/{+path}","compare_url":"https://api.github.com/repos/ansible/ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ansible/ansible/merges","archive_url":"https://api.github.com/repos/ansible/ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ansible/ansible/downloads","issues_url":"https://api.github.com/repos/ansible/ansible/issues{/number}","pulls_url":"https://api.github.com/repos/ansible/ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/ansible/ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/ansible/ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ansible/ansible/labels{/name}","releases_url":"https://api.github.com/repos/ansible/ansible/releases{/id}","deployments_url":"https://api.github.com/repos/ansible/ansible/deployments","created_at":"2012-03-06T14:58:02Z","updated_at":"2017-10-08T12:03:30Z","pushed_at":"2017-10-08T12:58:18Z","git_url":"git://github.com/ansible/ansible.git","ssh_url":"git@github.com:ansible/ansible.git","clone_url":"https://github.com/ansible/ansible.git","svn_url":"https://github.com/ansible/ansible","homepage":"https://www.ansible.com/","size":96367,"stargazers_count":25850,"watchers_count":25850,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9081,"mirror_url":null,"open_issues_count":4437,"forks":9081,"open_issues":4437,"watchers":25850,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/ansible/ansible/pulls/30582"},"html":{"href":"https://github.com/ansible/ansible/pull/30582"},"issue":{"href":"https://api.github.com/repos/ansible/ansible/issues/30582"},"comments":{"href":"https://api.github.com/repos/ansible/ansible/issues/30582/comments"},"review_comments":{"href":"https://api.github.com/repos/ansible/ansible/pulls/30582/comments"},"review_comment":{"href":"https://api.github.com/repos/ansible/ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ansible/ansible/pulls/30582/commits"},"statuses":{"href":"https://api.github.com/repos/ansible/ansible/statuses/b85c7e7e203d27f30966f2dabc725ff6f70fce76"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Akasurde"}}