{"comment":{"url":"https://api.github.com/repos/Nikhil22/splitter/comments/23878421","html_url":"https://github.com/Nikhil22/splitter/commit/8d53c27bd38ef6aa8b1eb3b1ddfec43489314ca4#commitcomment-23878421","id":23878421,"user":{"login":"rob-Hitchens","id":26111999,"avatar_url":"https://avatars1.githubusercontent.com/u/26111999?v=4","gravatar_id":"","url":"https://api.github.com/users/rob-Hitchens","html_url":"https://github.com/rob-Hitchens","followers_url":"https://api.github.com/users/rob-Hitchens/followers","following_url":"https://api.github.com/users/rob-Hitchens/following{/other_user}","gists_url":"https://api.github.com/users/rob-Hitchens/gists{/gist_id}","starred_url":"https://api.github.com/users/rob-Hitchens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rob-Hitchens/subscriptions","organizations_url":"https://api.github.com/users/rob-Hitchens/orgs","repos_url":"https://api.github.com/users/rob-Hitchens/repos","events_url":"https://api.github.com/users/rob-Hitchens/events{/privacy}","received_events_url":"https://api.github.com/users/rob-Hitchens/received_events","type":"User","site_admin":false},"position":null,"line":null,"path":null,"commit_id":"8d53c27bd38ef6aa8b1eb3b1ddfec43489314ca4","created_at":"2017-08-25T19:53:32Z","updated_at":"2017-08-25T19:53:32Z","body":"Near line 65, you do a state change after `transfer` - where you zero out the balance. This is not re-entrance safe. \r\n\r\nDo \r\n\r\n1. Optimistic accounting\r\n2. Try transfer/send/call\r\n3. Revert, if needed. `transfer` gives you that behavior for free. \r\n"}}
{"actor":{"display_login":"rob-Hitchens"}}