{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/2250","repository_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic","labels_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/2250/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/2250/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/2250/events","html_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/2250","id":261065841,"number":2250,"title":"Extended service, vm, instance & orch. stack retirement functionality","user":{"login":"mzazrivec","id":6648365,"avatar_url":"https://avatars2.githubusercontent.com/u/6648365?v=4","gravatar_id":"","url":"https://api.github.com/users/mzazrivec","html_url":"https://github.com/mzazrivec","followers_url":"https://api.github.com/users/mzazrivec/followers","following_url":"https://api.github.com/users/mzazrivec/following{/other_user}","gists_url":"https://api.github.com/users/mzazrivec/gists{/gist_id}","starred_url":"https://api.github.com/users/mzazrivec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mzazrivec/subscriptions","organizations_url":"https://api.github.com/users/mzazrivec/orgs","repos_url":"https://api.github.com/users/mzazrivec/repos","events_url":"https://api.github.com/users/mzazrivec/events{/privacy}","received_events_url":"https://api.github.com/users/mzazrivec/received_events","type":"User","site_admin":false},"labels":[{"id":505074431,"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":571047353,"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/labels/fine/no","name":"fine/no","color":"000000","default":false},{"id":534298512,"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/labels/services","name":"services","color":"5319e7","default":false}],"state":"open","locked":false,"assignee":{"login":"dclarizio","id":3433754,"avatar_url":"https://avatars3.githubusercontent.com/u/3433754?v=4","gravatar_id":"","url":"https://api.github.com/users/dclarizio","html_url":"https://github.com/dclarizio","followers_url":"https://api.github.com/users/dclarizio/followers","following_url":"https://api.github.com/users/dclarizio/following{/other_user}","gists_url":"https://api.github.com/users/dclarizio/gists{/gist_id}","starred_url":"https://api.github.com/users/dclarizio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dclarizio/subscriptions","organizations_url":"https://api.github.com/users/dclarizio/orgs","repos_url":"https://api.github.com/users/dclarizio/repos","events_url":"https://api.github.com/users/dclarizio/events{/privacy}","received_events_url":"https://api.github.com/users/dclarizio/received_events","type":"User","site_admin":false},"assignees":[{"login":"dclarizio","id":3433754,"avatar_url":"https://avatars3.githubusercontent.com/u/3433754?v=4","gravatar_id":"","url":"https://api.github.com/users/dclarizio","html_url":"https://github.com/dclarizio","followers_url":"https://api.github.com/users/dclarizio/followers","following_url":"https://api.github.com/users/dclarizio/following{/other_user}","gists_url":"https://api.github.com/users/dclarizio/gists{/gist_id}","starred_url":"https://api.github.com/users/dclarizio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dclarizio/subscriptions","organizations_url":"https://api.github.com/users/dclarizio/orgs","repos_url":"https://api.github.com/users/dclarizio/repos","events_url":"https://api.github.com/users/dclarizio/events{/privacy}","received_events_url":"https://api.github.com/users/dclarizio/received_events","type":"User","site_admin":false}],"milestone":null,"comments":10,"created_at":"2017-09-27T18:01:14Z","updated_at":"2017-09-30T16:15:32Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/2250","html_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/2250","diff_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/2250.diff","patch_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/2250.patch"},"body":"This change allows for setting retirement date & time for services, virtual machines and orchestration templates. In the past, the form would only allow to select retirement date. From now on, we're able\r\nto select the time to retire as well (all in UTC time zone).\r\n\r\nThis change also introduces date & time picker from Patternfly. For it to work nicely with our application\r\nand angular, we're using a new angular directive `datetimepicker`.\r\n\r\nhttps://www.pivotaltracker.com/story/show/150934417\r\n\r\nWhat won't currently work:\r\n* translated month names: with some locales (e.g. Japanese) the widget would throw an ugly\r\njavascript error. This would have to be addressed on the datepicker upstream side.\r\n* localized date formats: for this to work, we'd need to supply a date format that moment.js would understand. For now, we're using `MM/DD/YYYY HH:mm`.\r\n\r\nInitial retirement screen:\r\n![retirement01](https://user-images.githubusercontent.com/6648365/30962252-53bb7202-a449-11e7-933f-ecfb8f81d26b.jpg)\r\n\r\nDate / time picker, the date selection part:\r\n![retirement02](https://user-images.githubusercontent.com/6648365/30962268-5fdf349c-a449-11e7-9b7f-1eb31ebb4537.jpg)\r\n\r\nDate / time picker, the time selection part:\r\n![retirement03](https://user-images.githubusercontent.com/6648365/30962279-6906c62a-a449-11e7-9d13-e7592744b210.jpg)\r\n\r\nThe retirement date & time has been set:\r\n![retirement04](https://user-images.githubusercontent.com/6648365/30962300-83f3d220-a449-11e7-843b-b9ed90cef63d.jpg)\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/comments/333318815","html_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/2250#issuecomment-333318815","issue_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/2250","id":333318815,"user":{"login":"martinpovolny","id":51095,"avatar_url":"https://avatars3.githubusercontent.com/u/51095?v=4","gravatar_id":"","url":"https://api.github.com/users/martinpovolny","html_url":"https://github.com/martinpovolny","followers_url":"https://api.github.com/users/martinpovolny/followers","following_url":"https://api.github.com/users/martinpovolny/following{/other_user}","gists_url":"https://api.github.com/users/martinpovolny/gists{/gist_id}","starred_url":"https://api.github.com/users/martinpovolny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinpovolny/subscriptions","organizations_url":"https://api.github.com/users/martinpovolny/orgs","repos_url":"https://api.github.com/users/martinpovolny/repos","events_url":"https://api.github.com/users/martinpovolny/events{/privacy}","received_events_url":"https://api.github.com/users/martinpovolny/received_events","type":"User","site_admin":false},"created_at":"2017-09-30T16:15:31Z","updated_at":"2017-09-30T16:15:31Z","author_association":"COLLABORATOR","body":"Fixes:\r\n\r\n```link: function(scope, elem, attr, ctrl) {```\r\n\r\nThis is the first line of a function. That function does not have a return statement. Just add a `return`. That fixes the CC issue.\r\n\r\n2nd issue is here:\r\n```\r\n +        } else {\r\n￼ +          return null;\r\n￼ +        }\r\n```\r\n\r\nThis can be changed to:\r\n```\r\n}\r\nreturn null;\r\n```\r\n\r\nThe `return null;` does not need to be inside the `else` branch because the positive branch returns ;-)"}}
{"actor":{"display_login":"martinpovolny"}}