{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/54932","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/54932/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/54932/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/54932/events","html_url":"https://github.com/kubernetes/kubernetes/issues/54932","id":270272789,"number":54932,"title":"oc rollout history should show me the images that each revision run","user":{"login":"kargakis","id":3900799,"avatar_url":"https://avatars3.githubusercontent.com/u/3900799?v=4","gravatar_id":"","url":"https://api.github.com/users/kargakis","html_url":"https://github.com/kargakis","followers_url":"https://api.github.com/users/kargakis/followers","following_url":"https://api.github.com/users/kargakis/following{/other_user}","gists_url":"https://api.github.com/users/kargakis/gists{/gist_id}","starred_url":"https://api.github.com/users/kargakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kargakis/subscriptions","organizations_url":"https://api.github.com/users/kargakis/orgs","repos_url":"https://api.github.com/users/kargakis/repos","events_url":"https://api.github.com/users/kargakis/events{/privacy}","received_events_url":"https://api.github.com/users/kargakis/received_events","type":"User","site_admin":false},"labels":[{"id":134645162,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/area/usability","name":"area/usability","color":"0052cc","default":false},{"id":267761362,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/feature","name":"kind/feature","color":"c7def8","default":false},{"id":404091735,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/apps","name":"sig/apps","color":"d2b48c","default":false},{"id":450823910,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/cli","name":"sig/cli","color":"d2b48c","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2017-11-01T11:03:27Z","updated_at":"2017-11-09T16:58:26Z","closed_at":null,"author_association":"MEMBER","body":"@kubernetes/sig-cli-feature-requests @kubernetes/sig-apps-feature-requests "},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/343219839","html_url":"https://github.com/kubernetes/kubernetes/issues/54932#issuecomment-343219839","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/54932","id":343219839,"user":{"login":"jekohk","id":12895773,"avatar_url":"https://avatars3.githubusercontent.com/u/12895773?v=4","gravatar_id":"","url":"https://api.github.com/users/jekohk","html_url":"https://github.com/jekohk","followers_url":"https://api.github.com/users/jekohk/followers","following_url":"https://api.github.com/users/jekohk/following{/other_user}","gists_url":"https://api.github.com/users/jekohk/gists{/gist_id}","starred_url":"https://api.github.com/users/jekohk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jekohk/subscriptions","organizations_url":"https://api.github.com/users/jekohk/orgs","repos_url":"https://api.github.com/users/jekohk/repos","events_url":"https://api.github.com/users/jekohk/events{/privacy}","received_events_url":"https://api.github.com/users/jekohk/received_events","type":"User","site_admin":false},"created_at":"2017-11-09T16:58:25Z","updated_at":"2017-11-09T16:58:25Z","author_association":"CONTRIBUTOR","body":"@gregory-lyons thanks for the feedback. I had the same concern, as to what would happen when a Deployment has multiple containers, and I agree it could get messy printing that out. But printing the full change command is also messy imo.\r\n\r\nI think there is a general aversion the change-cause annotation & --record flag as it is (see #40422) and there are a few options to deal with this:\r\n\r\n1. Keep the `--record` flag of kubectl, but support safely overriding the change-cause annotation by letting a new value in the Deployment spec always take priority\r\n2. Deprecate the `--record` flag entirely, and leave it up to the user how `change-cause` gets populated (probably as part of their CI/CD pipeline)\r\n3. Keep the current functionality of `change-cause` and `--record` flag, but add a new optional annotation i.e. `change-desc` that is manually set by user , and also displayed by `rollout history` \r\n4. Deprecate `--record` and have `change-cause` be automatically populated by the server with more useful information (maybe instead of the entire apply/patch command, just short descriptions of what actually changed like \"Image: nginx:1.4 -> nginx1.5\")\r\n\r\nPersonally I am in favor of deprecating `--record` as it has raised many issues in the past, and just recording the kubectl command does not provide much context.\r\n\r\nI am in favor of option 2, however I can see how option 1 would be safer while still allowing users to override the default behavior and associate with each revision whatever info is relevant to their setup (whether it is container images, a git commit, or build number).\r\n\r\n@kargakis thoughts?\r\n"}}
{"actor":{"display_login":"jekohk"}}