{"action":"closed","number":3778,"pull_request":{"url":"https://api.github.com/repos/tinymce/tinymce/pulls/3778","id":128178972,"html_url":"https://github.com/tinymce/tinymce/pull/3778","diff_url":"https://github.com/tinymce/tinymce/pull/3778.diff","patch_url":"https://github.com/tinymce/tinymce/pull/3778.patch","issue_url":"https://api.github.com/repos/tinymce/tinymce/issues/3778","number":3778,"state":"closed","locked":false,"title":"do variable replacement when comparing class name in formatter.match()","user":{"login":"jerryorr","id":1598167,"avatar_url":"https://avatars0.githubusercontent.com/u/1598167?v=4","gravatar_id":"","url":"https://api.github.com/users/jerryorr","html_url":"https://github.com/jerryorr","followers_url":"https://api.github.com/users/jerryorr/followers","following_url":"https://api.github.com/users/jerryorr/following{/other_user}","gists_url":"https://api.github.com/users/jerryorr/gists{/gist_id}","starred_url":"https://api.github.com/users/jerryorr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerryorr/subscriptions","organizations_url":"https://api.github.com/users/jerryorr/orgs","repos_url":"https://api.github.com/users/jerryorr/repos","events_url":"https://api.github.com/users/jerryorr/events{/privacy}","received_events_url":"https://api.github.com/users/jerryorr/received_events","type":"User","site_admin":false},"body":"fixes #1189\r\n\r\n**Before submitting a pull request** please do the following:\r\n\r\n1. Fork [the repository](https://github.com/tinymce/tinymce) and create your branch from `master`\r\n2. Have you added some code that should be tested? Write some tests! (Are you unsure how to write the test you want to write, ask us for help!)\r\n3. Ensure that the tests pass: `grunt test`\r\n4. Ensure that your code passes the linter: `grunt lint`\r\n5. Make sure to sign the CLA.","created_at":"2017-06-29T15:20:06Z","updated_at":"2017-10-15T11:18:04Z","closed_at":"2017-10-15T11:18:03Z","merged_at":null,"merge_commit_sha":"031b3c425e89c33b507a34206e772cc390c9e3c6","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/tinymce/tinymce/pulls/3778/commits","review_comments_url":"https://api.github.com/repos/tinymce/tinymce/pulls/3778/comments","review_comment_url":"https://api.github.com/repos/tinymce/tinymce/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tinymce/tinymce/issues/3778/comments","statuses_url":"https://api.github.com/repos/tinymce/tinymce/statuses/130b435d1974c79649054fc0d4175bec3d7c978a","head":{"label":"SpiderStrategies:issue-1189-formatter-match-fails-when-variables-used","ref":"issue-1189-formatter-match-fails-when-variables-used","sha":"130b435d1974c79649054fc0d4175bec3d7c978a","user":{"login":"SpiderStrategies","id":1259401,"avatar_url":"https://avatars1.githubusercontent.com/u/1259401?v=4","gravatar_id":"","url":"https://api.github.com/users/SpiderStrategies","html_url":"https://github.com/SpiderStrategies","followers_url":"https://api.github.com/users/SpiderStrategies/followers","following_url":"https://api.github.com/users/SpiderStrategies/following{/other_user}","gists_url":"https://api.github.com/users/SpiderStrategies/gists{/gist_id}","starred_url":"https://api.github.com/users/SpiderStrategies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpiderStrategies/subscriptions","organizations_url":"https://api.github.com/users/SpiderStrategies/orgs","repos_url":"https://api.github.com/users/SpiderStrategies/repos","events_url":"https://api.github.com/users/SpiderStrategies/events{/privacy}","received_events_url":"https://api.github.com/users/SpiderStrategies/received_events","type":"Organization","site_admin":false},"repo":{"id":95785802,"name":"tinymce","full_name":"SpiderStrategies/tinymce","owner":{"login":"SpiderStrategies","id":1259401,"avatar_url":"https://avatars1.githubusercontent.com/u/1259401?v=4","gravatar_id":"","url":"https://api.github.com/users/SpiderStrategies","html_url":"https://github.com/SpiderStrategies","followers_url":"https://api.github.com/users/SpiderStrategies/followers","following_url":"https://api.github.com/users/SpiderStrategies/following{/other_user}","gists_url":"https://api.github.com/users/SpiderStrategies/gists{/gist_id}","starred_url":"https://api.github.com/users/SpiderStrategies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpiderStrategies/subscriptions","organizations_url":"https://api.github.com/users/SpiderStrategies/orgs","repos_url":"https://api.github.com/users/SpiderStrategies/repos","events_url":"https://api.github.com/users/SpiderStrategies/events{/privacy}","received_events_url":"https://api.github.com/users/SpiderStrategies/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SpiderStrategies/tinymce","description":"TinyMCE is a JavaScript library for platform independent 'WYSIWYG' or rich text editing. It is released as open source under the LGPL.","fork":true,"url":"https://api.github.com/repos/SpiderStrategies/tinymce","forks_url":"https://api.github.com/repos/SpiderStrategies/tinymce/forks","keys_url":"https://api.github.com/repos/SpiderStrategies/tinymce/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SpiderStrategies/tinymce/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SpiderStrategies/tinymce/teams","hooks_url":"https://api.github.com/repos/SpiderStrategies/tinymce/hooks","issue_events_url":"https://api.github.com/repos/SpiderStrategies/tinymce/issues/events{/number}","events_url":"https://api.github.com/repos/SpiderStrategies/tinymce/events","assignees_url":"https://api.github.com/repos/SpiderStrategies/tinymce/assignees{/user}","branches_url":"https://api.github.com/repos/SpiderStrategies/tinymce/branches{/branch}","tags_url":"https://api.github.com/repos/SpiderStrategies/tinymce/tags","blobs_url":"https://api.github.com/repos/SpiderStrategies/tinymce/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SpiderStrategies/tinymce/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SpiderStrategies/tinymce/git/refs{/sha}","trees_url":"https://api.github.com/repos/SpiderStrategies/tinymce/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SpiderStrategies/tinymce/statuses/{sha}","languages_url":"https://api.github.com/repos/SpiderStrategies/tinymce/languages","stargazers_url":"https://api.github.com/repos/SpiderStrategies/tinymce/stargazers","contributors_url":"https://api.github.com/repos/SpiderStrategies/tinymce/contributors","subscribers_url":"https://api.github.com/repos/SpiderStrategies/tinymce/subscribers","subscription_url":"https://api.github.com/repos/SpiderStrategies/tinymce/subscription","commits_url":"https://api.github.com/repos/SpiderStrategies/tinymce/commits{/sha}","git_commits_url":"https://api.github.com/repos/SpiderStrategies/tinymce/git/commits{/sha}","comments_url":"https://api.github.com/repos/SpiderStrategies/tinymce/comments{/number}","issue_comment_url":"https://api.github.com/repos/SpiderStrategies/tinymce/issues/comments{/number}","contents_url":"https://api.github.com/repos/SpiderStrategies/tinymce/contents/{+path}","compare_url":"https://api.github.com/repos/SpiderStrategies/tinymce/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SpiderStrategies/tinymce/merges","archive_url":"https://api.github.com/repos/SpiderStrategies/tinymce/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SpiderStrategies/tinymce/downloads","issues_url":"https://api.github.com/repos/SpiderStrategies/tinymce/issues{/number}","pulls_url":"https://api.github.com/repos/SpiderStrategies/tinymce/pulls{/number}","milestones_url":"https://api.github.com/repos/SpiderStrategies/tinymce/milestones{/number}","notifications_url":"https://api.github.com/repos/SpiderStrategies/tinymce/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SpiderStrategies/tinymce/labels{/name}","releases_url":"https://api.github.com/repos/SpiderStrategies/tinymce/releases{/id}","deployments_url":"https://api.github.com/repos/SpiderStrategies/tinymce/deployments","created_at":"2017-06-29T14:24:09Z","updated_at":"2017-06-29T14:24:15Z","pushed_at":"2017-06-29T15:27:18Z","git_url":"git://github.com/SpiderStrategies/tinymce.git","ssh_url":"git@github.com:SpiderStrategies/tinymce.git","clone_url":"https://github.com/SpiderStrategies/tinymce.git","svn_url":"https://github.com/SpiderStrategies/tinymce","homepage":"https://www.tinymce.com/","size":33490,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tinymce:master","ref":"master","sha":"a6e1f00c60e4a7ee6d864b14f877b3a10ca75556","user":{"login":"tinymce","id":119815,"avatar_url":"https://avatars3.githubusercontent.com/u/119815?v=4","gravatar_id":"","url":"https://api.github.com/users/tinymce","html_url":"https://github.com/tinymce","followers_url":"https://api.github.com/users/tinymce/followers","following_url":"https://api.github.com/users/tinymce/following{/other_user}","gists_url":"https://api.github.com/users/tinymce/gists{/gist_id}","starred_url":"https://api.github.com/users/tinymce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tinymce/subscriptions","organizations_url":"https://api.github.com/users/tinymce/orgs","repos_url":"https://api.github.com/users/tinymce/repos","events_url":"https://api.github.com/users/tinymce/events{/privacy}","received_events_url":"https://api.github.com/users/tinymce/received_events","type":"Organization","site_admin":false},"repo":{"id":467471,"name":"tinymce","full_name":"tinymce/tinymce","owner":{"login":"tinymce","id":119815,"avatar_url":"https://avatars3.githubusercontent.com/u/119815?v=4","gravatar_id":"","url":"https://api.github.com/users/tinymce","html_url":"https://github.com/tinymce","followers_url":"https://api.github.com/users/tinymce/followers","following_url":"https://api.github.com/users/tinymce/following{/other_user}","gists_url":"https://api.github.com/users/tinymce/gists{/gist_id}","starred_url":"https://api.github.com/users/tinymce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tinymce/subscriptions","organizations_url":"https://api.github.com/users/tinymce/orgs","repos_url":"https://api.github.com/users/tinymce/repos","events_url":"https://api.github.com/users/tinymce/events{/privacy}","received_events_url":"https://api.github.com/users/tinymce/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tinymce/tinymce","description":"TinyMCE Community Edition - JavaScript rich text editing component for web apps","fork":false,"url":"https://api.github.com/repos/tinymce/tinymce","forks_url":"https://api.github.com/repos/tinymce/tinymce/forks","keys_url":"https://api.github.com/repos/tinymce/tinymce/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tinymce/tinymce/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tinymce/tinymce/teams","hooks_url":"https://api.github.com/repos/tinymce/tinymce/hooks","issue_events_url":"https://api.github.com/repos/tinymce/tinymce/issues/events{/number}","events_url":"https://api.github.com/repos/tinymce/tinymce/events","assignees_url":"https://api.github.com/repos/tinymce/tinymce/assignees{/user}","branches_url":"https://api.github.com/repos/tinymce/tinymce/branches{/branch}","tags_url":"https://api.github.com/repos/tinymce/tinymce/tags","blobs_url":"https://api.github.com/repos/tinymce/tinymce/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tinymce/tinymce/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tinymce/tinymce/git/refs{/sha}","trees_url":"https://api.github.com/repos/tinymce/tinymce/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tinymce/tinymce/statuses/{sha}","languages_url":"https://api.github.com/repos/tinymce/tinymce/languages","stargazers_url":"https://api.github.com/repos/tinymce/tinymce/stargazers","contributors_url":"https://api.github.com/repos/tinymce/tinymce/contributors","subscribers_url":"https://api.github.com/repos/tinymce/tinymce/subscribers","subscription_url":"https://api.github.com/repos/tinymce/tinymce/subscription","commits_url":"https://api.github.com/repos/tinymce/tinymce/commits{/sha}","git_commits_url":"https://api.github.com/repos/tinymce/tinymce/git/commits{/sha}","comments_url":"https://api.github.com/repos/tinymce/tinymce/comments{/number}","issue_comment_url":"https://api.github.com/repos/tinymce/tinymce/issues/comments{/number}","contents_url":"https://api.github.com/repos/tinymce/tinymce/contents/{+path}","compare_url":"https://api.github.com/repos/tinymce/tinymce/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tinymce/tinymce/merges","archive_url":"https://api.github.com/repos/tinymce/tinymce/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tinymce/tinymce/downloads","issues_url":"https://api.github.com/repos/tinymce/tinymce/issues{/number}","pulls_url":"https://api.github.com/repos/tinymce/tinymce/pulls{/number}","milestones_url":"https://api.github.com/repos/tinymce/tinymce/milestones{/number}","notifications_url":"https://api.github.com/repos/tinymce/tinymce/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tinymce/tinymce/labels{/name}","releases_url":"https://api.github.com/repos/tinymce/tinymce/releases{/id}","deployments_url":"https://api.github.com/repos/tinymce/tinymce/deployments","created_at":"2010-01-11T14:46:42Z","updated_at":"2017-10-14T02:54:33Z","pushed_at":"2017-10-10T12:26:28Z","git_url":"git://github.com/tinymce/tinymce.git","ssh_url":"git@github.com:tinymce/tinymce.git","clone_url":"https://github.com/tinymce/tinymce.git","svn_url":"https://github.com/tinymce/tinymce","homepage":"https://www.tinymce.com/","size":34868,"stargazers_count":4738,"watchers_count":4738,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1289,"mirror_url":null,"open_issues_count":866,"forks":1289,"open_issues":866,"watchers":4738,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tinymce/tinymce/pulls/3778"},"html":{"href":"https://github.com/tinymce/tinymce/pull/3778"},"issue":{"href":"https://api.github.com/repos/tinymce/tinymce/issues/3778"},"comments":{"href":"https://api.github.com/repos/tinymce/tinymce/issues/3778/comments"},"review_comments":{"href":"https://api.github.com/repos/tinymce/tinymce/pulls/3778/comments"},"review_comment":{"href":"https://api.github.com/repos/tinymce/tinymce/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tinymce/tinymce/pulls/3778/commits"},"statuses":{"href":"https://api.github.com/repos/tinymce/tinymce/statuses/130b435d1974c79649054fc0d4175bec3d7c978a"}},"author_association":"NONE","merged":false,"mergeable":false,"rebaseable":false,"mergeable_state":"dirty","merged_by":null,"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":12,"deletions":1,"changed_files":2}}
{"actor":{"display_login":"jayarjo"}}