{"action":"created","issue":{"url":"https://api.github.com/repos/scala/scala-xml/issues/113","repository_url":"https://api.github.com/repos/scala/scala-xml","labels_url":"https://api.github.com/repos/scala/scala-xml/issues/113/labels{/name}","comments_url":"https://api.github.com/repos/scala/scala-xml/issues/113/comments","events_url":"https://api.github.com/repos/scala/scala-xml/issues/113/events","html_url":"https://github.com/scala/scala-xml/pull/113","id":181321478,"number":113,"title":"Utility.trim collapse whitespace for adjacent text nodes #73","user":{"login":"EdgeCaseBerg","id":1691564,"avatar_url":"https://avatars.githubusercontent.com/u/1691564?v=3","gravatar_id":"","url":"https://api.github.com/users/EdgeCaseBerg","html_url":"https://github.com/EdgeCaseBerg","followers_url":"https://api.github.com/users/EdgeCaseBerg/followers","following_url":"https://api.github.com/users/EdgeCaseBerg/following{/other_user}","gists_url":"https://api.github.com/users/EdgeCaseBerg/gists{/gist_id}","starred_url":"https://api.github.com/users/EdgeCaseBerg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EdgeCaseBerg/subscriptions","organizations_url":"https://api.github.com/users/EdgeCaseBerg/orgs","repos_url":"https://api.github.com/users/EdgeCaseBerg/repos","events_url":"https://api.github.com/users/EdgeCaseBerg/events{/privacy}","received_events_url":"https://api.github.com/users/EdgeCaseBerg/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-10-06T04:21:36Z","updated_at":"2017-02-07T15:20:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/scala/scala-xml/pulls/113","html_url":"https://github.com/scala/scala-xml/pull/113","diff_url":"https://github.com/scala/scala-xml/pull/113.diff","patch_url":"https://github.com/scala/scala-xml/pull/113.patch"},"body":"This fixes #73. I've got a few unit tests that are passing that verify the text is trimmed.\n\nI have a couple questions regarding the new `combineAdjacentTextNodes` method though:\n1. I have it as private right now since it's internal to trimming, but should it be a general utility method? If so, is the method name ok?\n2. In the `foldLeft` within that function, I'm accumulating with an immutable `Seq`. If we're going over a lot of nodes that seems like a lost of wasted time copying over arrays, would it be alright to use a mutable `Seq` here for performance, or is there some other buffer I should use? \n"},"comment":{"url":"https://api.github.com/repos/scala/scala-xml/issues/comments/278031571","html_url":"https://github.com/scala/scala-xml/pull/113#issuecomment-278031571","issue_url":"https://api.github.com/repos/scala/scala-xml/issues/113","id":278031571,"user":{"login":"EdgeCaseBerg","id":1691564,"avatar_url":"https://avatars.githubusercontent.com/u/1691564?v=3","gravatar_id":"","url":"https://api.github.com/users/EdgeCaseBerg","html_url":"https://github.com/EdgeCaseBerg","followers_url":"https://api.github.com/users/EdgeCaseBerg/followers","following_url":"https://api.github.com/users/EdgeCaseBerg/following{/other_user}","gists_url":"https://api.github.com/users/EdgeCaseBerg/gists{/gist_id}","starred_url":"https://api.github.com/users/EdgeCaseBerg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EdgeCaseBerg/subscriptions","organizations_url":"https://api.github.com/users/EdgeCaseBerg/orgs","repos_url":"https://api.github.com/users/EdgeCaseBerg/repos","events_url":"https://api.github.com/users/EdgeCaseBerg/events{/privacy}","received_events_url":"https://api.github.com/users/EdgeCaseBerg/received_events","type":"User","site_admin":false},"created_at":"2017-02-07T15:20:44Z","updated_at":"2017-02-07T15:20:44Z","body":"@SethTisue \r\nJust saw this. I think I'll have time to rebase this later tonight"}}
{"actor":{"display_login":"EdgeCaseBerg"}}