{"action":"created","comment":{"url":"https://api.github.com/repos/servo/servo/pulls/comments/136855798","pull_request_review_id":60452910,"id":136855798,"diff_hunk":"@@ -177,6 +177,10 @@ impl Performance {\n \n     /// Remove a PerformanceObserver from the list of observers.\n     pub fn remove_observer(&self, observer: &DOMPerformanceObserver) {\n+        if self.pending_notification_observers_task.get() {\n+            self.notify_observers();","path":"components/script/dom/performance.rs","position":131,"original_position":5,"commit_id":"643ae57d2ed58f9cb4f4cb5fa6afccec2fccaa9f","original_commit_id":"643ae57d2ed58f9cb4f4cb5fa6afccec2fccaa9f","user":{"login":"pylbrecht","id":11317687,"avatar_url":"https://avatars1.githubusercontent.com/u/11317687?v=4","gravatar_id":"","url":"https://api.github.com/users/pylbrecht","html_url":"https://github.com/pylbrecht","followers_url":"https://api.github.com/users/pylbrecht/followers","following_url":"https://api.github.com/users/pylbrecht/following{/other_user}","gists_url":"https://api.github.com/users/pylbrecht/gists{/gist_id}","starred_url":"https://api.github.com/users/pylbrecht/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pylbrecht/subscriptions","organizations_url":"https://api.github.com/users/pylbrecht/orgs","repos_url":"https://api.github.com/users/pylbrecht/repos","events_url":"https://api.github.com/users/pylbrecht/events{/privacy}","received_events_url":"https://api.github.com/users/pylbrecht/received_events","type":"User","site_admin":false},"body":"Alright, I'll fix that. Thanks for your input!","created_at":"2017-09-04T17:12:12Z","updated_at":"2017-09-04T17:12:12Z","html_url":"https://github.com/servo/servo/pull/18370#discussion_r136855798","pull_request_url":"https://api.github.com/repos/servo/servo/pulls/18370","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/servo/servo/pulls/comments/136855798"},"html":{"href":"https://github.com/servo/servo/pull/18370#discussion_r136855798"},"pull_request":{"href":"https://api.github.com/repos/servo/servo/pulls/18370"}},"in_reply_to_id":136854833},"pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/18370","id":139186403,"html_url":"https://github.com/servo/servo/pull/18370","diff_url":"https://github.com/servo/servo/pull/18370.diff","patch_url":"https://github.com/servo/servo/pull/18370.patch","issue_url":"https://api.github.com/repos/servo/servo/issues/18370","number":18370,"state":"open","locked":false,"title":"An observer disconnected after a mark must receive the mark","user":{"login":"pylbrecht","id":11317687,"avatar_url":"https://avatars1.githubusercontent.com/u/11317687?v=4","gravatar_id":"","url":"https://api.github.com/users/pylbrecht","html_url":"https://github.com/pylbrecht","followers_url":"https://api.github.com/users/pylbrecht/followers","following_url":"https://api.github.com/users/pylbrecht/following{/other_user}","gists_url":"https://api.github.com/users/pylbrecht/gists{/gist_id}","starred_url":"https://api.github.com/users/pylbrecht/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pylbrecht/subscriptions","organizations_url":"https://api.github.com/users/pylbrecht/orgs","repos_url":"https://api.github.com/users/pylbrecht/repos","events_url":"https://api.github.com/users/pylbrecht/events{/privacy}","received_events_url":"https://api.github.com/users/pylbrecht/received_events","type":"User","site_admin":false},"body":"<!-- Please describe your changes on the following line: -->\r\nI worked on top of #18283 as suggested [here](https://github.com/servo/servo/issues/18284#issuecomment-326043873).\r\n\r\nr? @ferjm \r\n\r\n<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->\r\n- [X] `./mach build -d` does not report any errors\r\n- [X] `./mach test-tidy` does not report any errors\r\n- [X] These changes fix #18284 (github issue number if applicable).\r\n\r\n<!-- Either: -->\r\n- [X] There are tests for these changes\r\n\r\n<!-- Also, please make sure that \"Allow edits from maintainers\" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->\r\n\r\n<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/servo/servo/18370)\n<!-- Reviewable:end -->\n","created_at":"2017-09-04T16:10:54Z","updated_at":"2017-09-04T17:12:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8e67871db0b75b26f48d4afd8dddf7ab701ed560","assignee":{"login":"ferjm","id":480202,"avatar_url":"https://avatars0.githubusercontent.com/u/480202?v=4","gravatar_id":"","url":"https://api.github.com/users/ferjm","html_url":"https://github.com/ferjm","followers_url":"https://api.github.com/users/ferjm/followers","following_url":"https://api.github.com/users/ferjm/following{/other_user}","gists_url":"https://api.github.com/users/ferjm/gists{/gist_id}","starred_url":"https://api.github.com/users/ferjm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferjm/subscriptions","organizations_url":"https://api.github.com/users/ferjm/orgs","repos_url":"https://api.github.com/users/ferjm/repos","events_url":"https://api.github.com/users/ferjm/events{/privacy}","received_events_url":"https://api.github.com/users/ferjm/received_events","type":"User","site_admin":false},"assignees":[{"login":"ferjm","id":480202,"avatar_url":"https://avatars0.githubusercontent.com/u/480202?v=4","gravatar_id":"","url":"https://api.github.com/users/ferjm","html_url":"https://github.com/ferjm","followers_url":"https://api.github.com/users/ferjm/followers","following_url":"https://api.github.com/users/ferjm/following{/other_user}","gists_url":"https://api.github.com/users/ferjm/gists{/gist_id}","starred_url":"https://api.github.com/users/ferjm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferjm/subscriptions","organizations_url":"https://api.github.com/users/ferjm/orgs","repos_url":"https://api.github.com/users/ferjm/repos","events_url":"https://api.github.com/users/ferjm/events{/privacy}","received_events_url":"https://api.github.com/users/ferjm/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/servo/servo/pulls/18370/commits","review_comments_url":"https://api.github.com/repos/servo/servo/pulls/18370/comments","review_comment_url":"https://api.github.com/repos/servo/servo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/servo/servo/issues/18370/comments","statuses_url":"https://api.github.com/repos/servo/servo/statuses/643ae57d2ed58f9cb4f4cb5fa6afccec2fccaa9f","head":{"label":"pylbrecht:observer","ref":"observer","sha":"643ae57d2ed58f9cb4f4cb5fa6afccec2fccaa9f","user":{"login":"pylbrecht","id":11317687,"avatar_url":"https://avatars1.githubusercontent.com/u/11317687?v=4","gravatar_id":"","url":"https://api.github.com/users/pylbrecht","html_url":"https://github.com/pylbrecht","followers_url":"https://api.github.com/users/pylbrecht/followers","following_url":"https://api.github.com/users/pylbrecht/following{/other_user}","gists_url":"https://api.github.com/users/pylbrecht/gists{/gist_id}","starred_url":"https://api.github.com/users/pylbrecht/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pylbrecht/subscriptions","organizations_url":"https://api.github.com/users/pylbrecht/orgs","repos_url":"https://api.github.com/users/pylbrecht/repos","events_url":"https://api.github.com/users/pylbrecht/events{/privacy}","received_events_url":"https://api.github.com/users/pylbrecht/received_events","type":"User","site_admin":false},"repo":{"id":101892852,"name":"servo","full_name":"pylbrecht/servo","owner":{"login":"pylbrecht","id":11317687,"avatar_url":"https://avatars1.githubusercontent.com/u/11317687?v=4","gravatar_id":"","url":"https://api.github.com/users/pylbrecht","html_url":"https://github.com/pylbrecht","followers_url":"https://api.github.com/users/pylbrecht/followers","following_url":"https://api.github.com/users/pylbrecht/following{/other_user}","gists_url":"https://api.github.com/users/pylbrecht/gists{/gist_id}","starred_url":"https://api.github.com/users/pylbrecht/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pylbrecht/subscriptions","organizations_url":"https://api.github.com/users/pylbrecht/orgs","repos_url":"https://api.github.com/users/pylbrecht/repos","events_url":"https://api.github.com/users/pylbrecht/events{/privacy}","received_events_url":"https://api.github.com/users/pylbrecht/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pylbrecht/servo","description":"The Servo Browser Engine","fork":true,"url":"https://api.github.com/repos/pylbrecht/servo","forks_url":"https://api.github.com/repos/pylbrecht/servo/forks","keys_url":"https://api.github.com/repos/pylbrecht/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pylbrecht/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pylbrecht/servo/teams","hooks_url":"https://api.github.com/repos/pylbrecht/servo/hooks","issue_events_url":"https://api.github.com/repos/pylbrecht/servo/issues/events{/number}","events_url":"https://api.github.com/repos/pylbrecht/servo/events","assignees_url":"https://api.github.com/repos/pylbrecht/servo/assignees{/user}","branches_url":"https://api.github.com/repos/pylbrecht/servo/branches{/branch}","tags_url":"https://api.github.com/repos/pylbrecht/servo/tags","blobs_url":"https://api.github.com/repos/pylbrecht/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pylbrecht/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pylbrecht/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/pylbrecht/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pylbrecht/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/pylbrecht/servo/languages","stargazers_url":"https://api.github.com/repos/pylbrecht/servo/stargazers","contributors_url":"https://api.github.com/repos/pylbrecht/servo/contributors","subscribers_url":"https://api.github.com/repos/pylbrecht/servo/subscribers","subscription_url":"https://api.github.com/repos/pylbrecht/servo/subscription","commits_url":"https://api.github.com/repos/pylbrecht/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/pylbrecht/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/pylbrecht/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/pylbrecht/servo/issues/comments{/number}","contents_url":"https://api.github.com/repos/pylbrecht/servo/contents/{+path}","compare_url":"https://api.github.com/repos/pylbrecht/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pylbrecht/servo/merges","archive_url":"https://api.github.com/repos/pylbrecht/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pylbrecht/servo/downloads","issues_url":"https://api.github.com/repos/pylbrecht/servo/issues{/number}","pulls_url":"https://api.github.com/repos/pylbrecht/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/pylbrecht/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/pylbrecht/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pylbrecht/servo/labels{/name}","releases_url":"https://api.github.com/repos/pylbrecht/servo/releases{/id}","deployments_url":"https://api.github.com/repos/pylbrecht/servo/deployments","created_at":"2017-08-30T14:40:05Z","updated_at":"2017-08-30T13:07:56Z","pushed_at":"2017-09-04T16:00:58Z","git_url":"git://github.com/pylbrecht/servo.git","ssh_url":"git@github.com:pylbrecht/servo.git","clone_url":"https://github.com/pylbrecht/servo.git","svn_url":"https://github.com/pylbrecht/servo","homepage":"https://servo.org/","size":285587,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"servo:master","ref":"master","sha":"293ffa06daa5cd2c3588833af3ed211ed3935d36","user":{"login":"servo","id":2566135,"avatar_url":"https://avatars1.githubusercontent.com/u/2566135?v=4","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"repo":{"id":3390243,"name":"servo","full_name":"servo/servo","owner":{"login":"servo","id":2566135,"avatar_url":"https://avatars1.githubusercontent.com/u/2566135?v=4","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/servo/servo","description":"The Servo Browser Engine","fork":false,"url":"https://api.github.com/repos/servo/servo","forks_url":"https://api.github.com/repos/servo/servo/forks","keys_url":"https://api.github.com/repos/servo/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/servo/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/servo/servo/teams","hooks_url":"https://api.github.com/repos/servo/servo/hooks","issue_events_url":"https://api.github.com/repos/servo/servo/issues/events{/number}","events_url":"https://api.github.com/repos/servo/servo/events","assignees_url":"https://api.github.com/repos/servo/servo/assignees{/user}","branches_url":"https://api.github.com/repos/servo/servo/branches{/branch}","tags_url":"https://api.github.com/repos/servo/servo/tags","blobs_url":"https://api.github.com/repos/servo/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/servo/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/servo/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/servo/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/servo/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/servo/servo/languages","stargazers_url":"https://api.github.com/repos/servo/servo/stargazers","contributors_url":"https://api.github.com/repos/servo/servo/contributors","subscribers_url":"https://api.github.com/repos/servo/servo/subscribers","subscription_url":"https://api.github.com/repos/servo/servo/subscription","commits_url":"https://api.github.com/repos/servo/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/servo/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/servo/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/servo/servo/issues/comments{/number}","contents_url":"https://api.github.com/repos/servo/servo/contents/{+path}","compare_url":"https://api.github.com/repos/servo/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/servo/servo/merges","archive_url":"https://api.github.com/repos/servo/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/servo/servo/downloads","issues_url":"https://api.github.com/repos/servo/servo/issues{/number}","pulls_url":"https://api.github.com/repos/servo/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/servo/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/servo/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/servo/servo/labels{/name}","releases_url":"https://api.github.com/repos/servo/servo/releases{/id}","deployments_url":"https://api.github.com/repos/servo/servo/deployments","created_at":"2012-02-08T19:07:25Z","updated_at":"2017-09-04T16:40:58Z","pushed_at":"2017-09-04T17:02:15Z","git_url":"git://github.com/servo/servo.git","ssh_url":"git@github.com:servo/servo.git","clone_url":"https://github.com/servo/servo.git","svn_url":"https://github.com/servo/servo","homepage":"https://servo.org/","size":362719,"stargazers_count":9976,"watchers_count":9976,"language":null,"has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1718,"mirror_url":null,"open_issues_count":2309,"forks":1718,"open_issues":2309,"watchers":9976,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/servo/servo/pulls/18370"},"html":{"href":"https://github.com/servo/servo/pull/18370"},"issue":{"href":"https://api.github.com/repos/servo/servo/issues/18370"},"comments":{"href":"https://api.github.com/repos/servo/servo/issues/18370/comments"},"review_comments":{"href":"https://api.github.com/repos/servo/servo/pulls/18370/comments"},"review_comment":{"href":"https://api.github.com/repos/servo/servo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/servo/servo/pulls/18370/commits"},"statuses":{"href":"https://api.github.com/repos/servo/servo/statuses/643ae57d2ed58f9cb4f4cb5fa6afccec2fccaa9f"}},"author_association":"NONE"}}
{"actor":{"display_login":"pylbrecht"}}