{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/16690","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/16690/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/16690/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/16690/events","html_url":"https://github.com/nodejs/node/pull/16690","id":270669066,"number":16690,"title":"test: fix flaky test-http2-server-rst-stream.js","user":{"login":"apapirovski","id":20809,"avatar_url":"https://avatars2.githubusercontent.com/u/20809?v=4","gravatar_id":"","url":"https://api.github.com/users/apapirovski","html_url":"https://github.com/apapirovski","followers_url":"https://api.github.com/users/apapirovski/followers","following_url":"https://api.github.com/users/apapirovski/following{/other_user}","gists_url":"https://api.github.com/users/apapirovski/gists{/gist_id}","starred_url":"https://api.github.com/users/apapirovski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apapirovski/subscriptions","organizations_url":"https://api.github.com/users/apapirovski/orgs","repos_url":"https://api.github.com/users/apapirovski/repos","events_url":"https://api.github.com/users/apapirovski/events{/privacy}","received_events_url":"https://api.github.com/users/apapirovski/received_events","type":"User","site_admin":false},"labels":[{"id":647282877,"url":"https://api.github.com/repos/nodejs/node/labels/http2","name":"http2","color":"c2e0c6","default":false},{"id":176240519,"url":"https://api.github.com/repos/nodejs/node/labels/test","name":"test","color":"990099","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2017-11-02T14:16:16Z","updated_at":"2017-11-02T15:24:02Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/16690","html_url":"https://github.com/nodejs/node/pull/16690","diff_url":"https://github.com/nodejs/node/pull/16690.diff","patch_url":"https://github.com/nodejs/node/pull/16690.patch"},"body":"I believe this test has some problems with concurrency but not 100% certain yet. Previous version was failing when I ran a heavy duty stress test on my machine but it's also possible there's something wrong in the http2 code. (Will run stress test CIs to try & confirm.)\r\n\r\nPlease don't approve until stress tests are done. I'm not even sure myself if this is correct. 😆 \r\n\r\nFixes: https://github.com/nodejs/node/issues/16688\r\n\r\n<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines)\r\n\r\n##### Affected core subsystem(s)\r\n<!-- Provide affected core subsystem(s) (like doc, cluster, crypto, etc). -->\r\ntest"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/341457270","html_url":"https://github.com/nodejs/node/pull/16690#issuecomment-341457270","issue_url":"https://api.github.com/repos/nodejs/node/issues/16690","id":341457270,"user":{"login":"jasnell","id":439929,"avatar_url":"https://avatars2.githubusercontent.com/u/439929?v=4","gravatar_id":"","url":"https://api.github.com/users/jasnell","html_url":"https://github.com/jasnell","followers_url":"https://api.github.com/users/jasnell/followers","following_url":"https://api.github.com/users/jasnell/following{/other_user}","gists_url":"https://api.github.com/users/jasnell/gists{/gist_id}","starred_url":"https://api.github.com/users/jasnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasnell/subscriptions","organizations_url":"https://api.github.com/users/jasnell/orgs","repos_url":"https://api.github.com/users/jasnell/repos","events_url":"https://api.github.com/users/jasnell/events{/privacy}","received_events_url":"https://api.github.com/users/jasnell/received_events","type":"User","site_admin":false},"created_at":"2017-11-02T15:24:02Z","updated_at":"2017-11-02T15:24:02Z","author_association":"OWNER","body":"That needs a bit of linting :-)"}}
{"actor":{"display_login":"jasnell"}}