{"comment":{"url":"https://api.github.com/repos/bp-kelley/freesasa/comments/22397881","html_url":"https://github.com/bp-kelley/freesasa/commit/126df0aaaa4c38668acd01b40eff16d1131bb1d1#commitcomment-22397881","id":22397881,"user":{"login":"mittinatten","id":2842140,"avatar_url":"https://avatars2.githubusercontent.com/u/2842140?v=3","gravatar_id":"","url":"https://api.github.com/users/mittinatten","html_url":"https://github.com/mittinatten","followers_url":"https://api.github.com/users/mittinatten/followers","following_url":"https://api.github.com/users/mittinatten/following{/other_user}","gists_url":"https://api.github.com/users/mittinatten/gists{/gist_id}","starred_url":"https://api.github.com/users/mittinatten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mittinatten/subscriptions","organizations_url":"https://api.github.com/users/mittinatten/orgs","repos_url":"https://api.github.com/users/mittinatten/repos","events_url":"https://api.github.com/users/mittinatten/events{/privacy}","received_events_url":"https://api.github.com/users/mittinatten/received_events","type":"User","site_admin":false},"position":null,"line":null,"path":null,"commit_id":"126df0aaaa4c38668acd01b40eff16d1131bb1d1","created_at":"2017-06-05T10:27:22Z","updated_at":"2017-06-05T10:27:22Z","body":"Looking at the diff it seems compatibility should be pretty easy to achieve with some minor adjustments and a few macros\r\n\r\n* Variable length arrays: A few of them could be regular stack arrays, and the rest should probably rather have been malloc'd with error checks in the first place (for safety).\r\n* Restrict: could be fixed by a macro in `freesasa.h`.\r\n~~~c\r\n#ifdef FLAG_FOR_MSVS_... // do you know what to put here?\r\n#define restrict __restrict\r\n#endif\r\n~~~\r\n* `lexer.c`: This is autogenerated, so we can't maintain any changes here. But, the offending header can be excluded by the compiler flag `-DYY_NO_UNISTD_H` or whatever the equivalent command would be with the MS compiler\r\n* The NAN hack is already gone from `rsa.c` (it prints \"N/A\" in that field instead).\r\n\r\nSince these are very limited problems, creating source that adds Visual Studio compatibility should probably be simple, but I don't have access to a Windows system for testing. There have been quite a few changes in the last year so there might of course be new incompatibilities as well.\r\n\r\nIf either of you could help me with testing (or want to bring the changes up to date and PR yourselves) that would be great."}}
{"actor":{"display_login":"mittinatten"}}