{"action":"created","comment":{"url":"https://api.github.com/repos/yiisoft/yii2/pulls/comments/102415729","pull_request_review_id":23168981,"id":102415729,"diff_hunk":"@@ -415,7 +415,15 @@ private function findFixtures(array $fixtures = [])\n         $foundFixtures = [];\n \n         foreach ($files as $fixture) {\n-            $foundFixtures[] = basename($fixture, 'Fixture.php');\n+            // strip $fixturesPath from $fixture's full path\n+            $relativeName = str_replace($fixturesPath . \"/\", \"\", $fixture);\n+            // get fixtures's directory\n+            $relativeDir = dirname($relativeName) == '.' ? '' : dirname($relativeName) . '/';\n+            // get fixture name relatively to $fixturesPath\n+            $relativeName = $relativeDir . basename($fixture, 'Fixture.php');\n+            // normalize path to unix format\n+            $relativeName = str_replace(\"\\\\\", \"/\", $relativeName);","path":"framework/console/controllers/FixtureController.php","position":12,"original_position":12,"commit_id":"76b8f393be248b18fd21fbb48178071e48bcd4e8","original_commit_id":"76b8f393be248b18fd21fbb48178071e48bcd4e8","user":{"login":"d1rtyf1ng3rs","id":7011469,"avatar_url":"https://avatars.githubusercontent.com/u/7011469?v=3","gravatar_id":"","url":"https://api.github.com/users/d1rtyf1ng3rs","html_url":"https://github.com/d1rtyf1ng3rs","followers_url":"https://api.github.com/users/d1rtyf1ng3rs/followers","following_url":"https://api.github.com/users/d1rtyf1ng3rs/following{/other_user}","gists_url":"https://api.github.com/users/d1rtyf1ng3rs/gists{/gist_id}","starred_url":"https://api.github.com/users/d1rtyf1ng3rs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d1rtyf1ng3rs/subscriptions","organizations_url":"https://api.github.com/users/d1rtyf1ng3rs/orgs","repos_url":"https://api.github.com/users/d1rtyf1ng3rs/repos","events_url":"https://api.github.com/users/d1rtyf1ng3rs/events{/privacy}","received_events_url":"https://api.github.com/users/d1rtyf1ng3rs/received_events","type":"User","site_admin":false},"body":"Good point. Yes, there might be a problem - `$fixture` is calculated automatically, whereas `$fixturesPath` is provided or may be provided by user. So it's not guaranteed they're in the same format.\r\nI'll provide corresponding changes soon.","created_at":"2017-02-22T09:25:52Z","updated_at":"2017-02-22T09:25:52Z","html_url":"https://github.com/yiisoft/yii2/pull/13553#discussion_r102415729","pull_request_url":"https://api.github.com/repos/yiisoft/yii2/pulls/13553","_links":{"self":{"href":"https://api.github.com/repos/yiisoft/yii2/pulls/comments/102415729"},"html":{"href":"https://github.com/yiisoft/yii2/pull/13553#discussion_r102415729"},"pull_request":{"href":"https://api.github.com/repos/yiisoft/yii2/pulls/13553"}}},"pull_request":{"url":"https://api.github.com/repos/yiisoft/yii2/pulls/13553","id":105637026,"html_url":"https://github.com/yiisoft/yii2/pull/13553","diff_url":"https://github.com/yiisoft/yii2/pull/13553.diff","patch_url":"https://github.com/yiisoft/yii2/pull/13553.patch","issue_url":"https://api.github.com/repos/yiisoft/yii2/issues/13553","number":13553,"state":"open","locked":false,"title":"Issue 13551: loading fixtures in subdirectories","user":{"login":"d1rtyf1ng3rs","id":7011469,"avatar_url":"https://avatars.githubusercontent.com/u/7011469?v=3","gravatar_id":"","url":"https://api.github.com/users/d1rtyf1ng3rs","html_url":"https://github.com/d1rtyf1ng3rs","followers_url":"https://api.github.com/users/d1rtyf1ng3rs/followers","following_url":"https://api.github.com/users/d1rtyf1ng3rs/following{/other_user}","gists_url":"https://api.github.com/users/d1rtyf1ng3rs/gists{/gist_id}","starred_url":"https://api.github.com/users/d1rtyf1ng3rs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d1rtyf1ng3rs/subscriptions","organizations_url":"https://api.github.com/users/d1rtyf1ng3rs/orgs","repos_url":"https://api.github.com/users/d1rtyf1ng3rs/repos","events_url":"https://api.github.com/users/d1rtyf1ng3rs/events{/privacy}","received_events_url":"https://api.github.com/users/d1rtyf1ng3rs/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Is bugfix?    | yes\r\n| New feature?  | -\r\n| Breaks BC?    | no\r\n| Tests pass?   | yes\r\n| Fixed issues  | #13551 \r\n\r\nAn attempt to fix #13551.\r\nWould like hear some comments / critics first, expecially about `getFixturesConfig()` changes.\r\n","created_at":"2017-02-10T14:24:59Z","updated_at":"2017-02-22T09:25:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b6c65335596e56a675c9e3704a0420b47f352bee","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/yiisoft/yii2/milestones/21","html_url":"https://github.com/yiisoft/yii2/milestone/21","labels_url":"https://api.github.com/repos/yiisoft/yii2/milestones/21/labels","id":1875845,"number":21,"title":"2.0.12","description":"","creator":{"login":"cebe","id":189796,"avatar_url":"https://avatars.githubusercontent.com/u/189796?v=3","gravatar_id":"","url":"https://api.github.com/users/cebe","html_url":"https://github.com/cebe","followers_url":"https://api.github.com/users/cebe/followers","following_url":"https://api.github.com/users/cebe/following{/other_user}","gists_url":"https://api.github.com/users/cebe/gists{/gist_id}","starred_url":"https://api.github.com/users/cebe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cebe/subscriptions","organizations_url":"https://api.github.com/users/cebe/orgs","repos_url":"https://api.github.com/users/cebe/repos","events_url":"https://api.github.com/users/cebe/events{/privacy}","received_events_url":"https://api.github.com/users/cebe/received_events","type":"User","site_admin":false},"open_issues":161,"closed_issues":70,"state":"open","created_at":"2016-07-11T13:42:09Z","updated_at":"2017-02-21T21:58:57Z","due_on":"2017-03-26T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/yiisoft/yii2/pulls/13553/commits","review_comments_url":"https://api.github.com/repos/yiisoft/yii2/pulls/13553/comments","review_comment_url":"https://api.github.com/repos/yiisoft/yii2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yiisoft/yii2/issues/13553/comments","statuses_url":"https://api.github.com/repos/yiisoft/yii2/statuses/76b8f393be248b18fd21fbb48178071e48bcd4e8","head":{"label":"d1rtyf1ng3rs:13551-load-fixtures-in-subdirectories","ref":"13551-load-fixtures-in-subdirectories","sha":"76b8f393be248b18fd21fbb48178071e48bcd4e8","user":{"login":"d1rtyf1ng3rs","id":7011469,"avatar_url":"https://avatars.githubusercontent.com/u/7011469?v=3","gravatar_id":"","url":"https://api.github.com/users/d1rtyf1ng3rs","html_url":"https://github.com/d1rtyf1ng3rs","followers_url":"https://api.github.com/users/d1rtyf1ng3rs/followers","following_url":"https://api.github.com/users/d1rtyf1ng3rs/following{/other_user}","gists_url":"https://api.github.com/users/d1rtyf1ng3rs/gists{/gist_id}","starred_url":"https://api.github.com/users/d1rtyf1ng3rs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d1rtyf1ng3rs/subscriptions","organizations_url":"https://api.github.com/users/d1rtyf1ng3rs/orgs","repos_url":"https://api.github.com/users/d1rtyf1ng3rs/repos","events_url":"https://api.github.com/users/d1rtyf1ng3rs/events{/privacy}","received_events_url":"https://api.github.com/users/d1rtyf1ng3rs/received_events","type":"User","site_admin":false},"repo":{"id":81444937,"name":"yii2","full_name":"d1rtyf1ng3rs/yii2","owner":{"login":"d1rtyf1ng3rs","id":7011469,"avatar_url":"https://avatars.githubusercontent.com/u/7011469?v=3","gravatar_id":"","url":"https://api.github.com/users/d1rtyf1ng3rs","html_url":"https://github.com/d1rtyf1ng3rs","followers_url":"https://api.github.com/users/d1rtyf1ng3rs/followers","following_url":"https://api.github.com/users/d1rtyf1ng3rs/following{/other_user}","gists_url":"https://api.github.com/users/d1rtyf1ng3rs/gists{/gist_id}","starred_url":"https://api.github.com/users/d1rtyf1ng3rs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d1rtyf1ng3rs/subscriptions","organizations_url":"https://api.github.com/users/d1rtyf1ng3rs/orgs","repos_url":"https://api.github.com/users/d1rtyf1ng3rs/repos","events_url":"https://api.github.com/users/d1rtyf1ng3rs/events{/privacy}","received_events_url":"https://api.github.com/users/d1rtyf1ng3rs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/d1rtyf1ng3rs/yii2","description":"Yii 2: The Fast, Secure and Professional PHP Framework","fork":true,"url":"https://api.github.com/repos/d1rtyf1ng3rs/yii2","forks_url":"https://api.github.com/repos/d1rtyf1ng3rs/yii2/forks","keys_url":"https://api.github.com/repos/d1rtyf1ng3rs/yii2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/d1rtyf1ng3rs/yii2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/d1rtyf1ng3rs/yii2/teams","hooks_url":"https://api.github.com/repos/d1rtyf1ng3rs/yii2/hooks","issue_events_url":"https://api.github.com/repos/d1rtyf1ng3rs/yii2/issues/events{/number}","events_url":"https://api.github.com/repos/d1rtyf1ng3rs/yii2/events","assignees_url":"https://api.github.com/repos/d1rtyf1ng3rs/yii2/assignees{/user}","branches_url":"https://api.github.com/repos/d1rtyf1ng3rs/yii2/branches{/branch}","tags_url":"https://api.github.com/repos/d1rtyf1ng3rs/yii2/tags","blobs_url":"https://api.github.com/repos/d1rtyf1ng3rs/yii2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/d1rtyf1ng3rs/yii2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/d1rtyf1ng3rs/yii2/git/refs{/sha}","trees_url":"https://api.github.com/repos/d1rtyf1ng3rs/yii2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/d1rtyf1ng3rs/yii2/statuses/{sha}","languages_url":"https://api.github.com/repos/d1rtyf1ng3rs/yii2/languages","stargazers_url":"https://api.github.com/repos/d1rtyf1ng3rs/yii2/stargazers","contributors_url":"https://api.github.com/repos/d1rtyf1ng3rs/yii2/contributors","subscribers_url":"https://api.github.com/repos/d1rtyf1ng3rs/yii2/subscribers","subscription_url":"https://api.github.com/repos/d1rtyf1ng3rs/yii2/subscription","commits_url":"https://api.github.com/repos/d1rtyf1ng3rs/yii2/commits{/sha}","git_commits_url":"https://api.github.com/repos/d1rtyf1ng3rs/yii2/git/commits{/sha}","comments_url":"https://api.github.com/repos/d1rtyf1ng3rs/yii2/comments{/number}","issue_comment_url":"https://api.github.com/repos/d1rtyf1ng3rs/yii2/issues/comments{/number}","contents_url":"https://api.github.com/repos/d1rtyf1ng3rs/yii2/contents/{+path}","compare_url":"https://api.github.com/repos/d1rtyf1ng3rs/yii2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/d1rtyf1ng3rs/yii2/merges","archive_url":"https://api.github.com/repos/d1rtyf1ng3rs/yii2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/d1rtyf1ng3rs/yii2/downloads","issues_url":"https://api.github.com/repos/d1rtyf1ng3rs/yii2/issues{/number}","pulls_url":"https://api.github.com/repos/d1rtyf1ng3rs/yii2/pulls{/number}","milestones_url":"https://api.github.com/repos/d1rtyf1ng3rs/yii2/milestones{/number}","notifications_url":"https://api.github.com/repos/d1rtyf1ng3rs/yii2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/d1rtyf1ng3rs/yii2/labels{/name}","releases_url":"https://api.github.com/repos/d1rtyf1ng3rs/yii2/releases{/id}","deployments_url":"https://api.github.com/repos/d1rtyf1ng3rs/yii2/deployments","created_at":"2017-02-09T11:49:14Z","updated_at":"2017-02-09T11:49:21Z","pushed_at":"2017-02-16T15:27:26Z","git_url":"git://github.com/d1rtyf1ng3rs/yii2.git","ssh_url":"git@github.com:d1rtyf1ng3rs/yii2.git","clone_url":"https://github.com/d1rtyf1ng3rs/yii2.git","svn_url":"https://github.com/d1rtyf1ng3rs/yii2","homepage":"http://www.yiiframework.com","size":53052,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yiisoft:master","ref":"master","sha":"95b7ffc066c03f2510ef4e6681e1ddf1494e916f","user":{"login":"yiisoft","id":993323,"avatar_url":"https://avatars.githubusercontent.com/u/993323?v=3","gravatar_id":"","url":"https://api.github.com/users/yiisoft","html_url":"https://github.com/yiisoft","followers_url":"https://api.github.com/users/yiisoft/followers","following_url":"https://api.github.com/users/yiisoft/following{/other_user}","gists_url":"https://api.github.com/users/yiisoft/gists{/gist_id}","starred_url":"https://api.github.com/users/yiisoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yiisoft/subscriptions","organizations_url":"https://api.github.com/users/yiisoft/orgs","repos_url":"https://api.github.com/users/yiisoft/repos","events_url":"https://api.github.com/users/yiisoft/events{/privacy}","received_events_url":"https://api.github.com/users/yiisoft/received_events","type":"Organization","site_admin":false},"repo":{"id":3431193,"name":"yii2","full_name":"yiisoft/yii2","owner":{"login":"yiisoft","id":993323,"avatar_url":"https://avatars.githubusercontent.com/u/993323?v=3","gravatar_id":"","url":"https://api.github.com/users/yiisoft","html_url":"https://github.com/yiisoft","followers_url":"https://api.github.com/users/yiisoft/followers","following_url":"https://api.github.com/users/yiisoft/following{/other_user}","gists_url":"https://api.github.com/users/yiisoft/gists{/gist_id}","starred_url":"https://api.github.com/users/yiisoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yiisoft/subscriptions","organizations_url":"https://api.github.com/users/yiisoft/orgs","repos_url":"https://api.github.com/users/yiisoft/repos","events_url":"https://api.github.com/users/yiisoft/events{/privacy}","received_events_url":"https://api.github.com/users/yiisoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yiisoft/yii2","description":"Yii 2: The Fast, Secure and Professional PHP Framework","fork":false,"url":"https://api.github.com/repos/yiisoft/yii2","forks_url":"https://api.github.com/repos/yiisoft/yii2/forks","keys_url":"https://api.github.com/repos/yiisoft/yii2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yiisoft/yii2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yiisoft/yii2/teams","hooks_url":"https://api.github.com/repos/yiisoft/yii2/hooks","issue_events_url":"https://api.github.com/repos/yiisoft/yii2/issues/events{/number}","events_url":"https://api.github.com/repos/yiisoft/yii2/events","assignees_url":"https://api.github.com/repos/yiisoft/yii2/assignees{/user}","branches_url":"https://api.github.com/repos/yiisoft/yii2/branches{/branch}","tags_url":"https://api.github.com/repos/yiisoft/yii2/tags","blobs_url":"https://api.github.com/repos/yiisoft/yii2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yiisoft/yii2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yiisoft/yii2/git/refs{/sha}","trees_url":"https://api.github.com/repos/yiisoft/yii2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yiisoft/yii2/statuses/{sha}","languages_url":"https://api.github.com/repos/yiisoft/yii2/languages","stargazers_url":"https://api.github.com/repos/yiisoft/yii2/stargazers","contributors_url":"https://api.github.com/repos/yiisoft/yii2/contributors","subscribers_url":"https://api.github.com/repos/yiisoft/yii2/subscribers","subscription_url":"https://api.github.com/repos/yiisoft/yii2/subscription","commits_url":"https://api.github.com/repos/yiisoft/yii2/commits{/sha}","git_commits_url":"https://api.github.com/repos/yiisoft/yii2/git/commits{/sha}","comments_url":"https://api.github.com/repos/yiisoft/yii2/comments{/number}","issue_comment_url":"https://api.github.com/repos/yiisoft/yii2/issues/comments{/number}","contents_url":"https://api.github.com/repos/yiisoft/yii2/contents/{+path}","compare_url":"https://api.github.com/repos/yiisoft/yii2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yiisoft/yii2/merges","archive_url":"https://api.github.com/repos/yiisoft/yii2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yiisoft/yii2/downloads","issues_url":"https://api.github.com/repos/yiisoft/yii2/issues{/number}","pulls_url":"https://api.github.com/repos/yiisoft/yii2/pulls{/number}","milestones_url":"https://api.github.com/repos/yiisoft/yii2/milestones{/number}","notifications_url":"https://api.github.com/repos/yiisoft/yii2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yiisoft/yii2/labels{/name}","releases_url":"https://api.github.com/repos/yiisoft/yii2/releases{/id}","deployments_url":"https://api.github.com/repos/yiisoft/yii2/deployments","created_at":"2012-02-13T15:32:36Z","updated_at":"2017-02-22T08:03:19Z","pushed_at":"2017-02-21T21:58:39Z","git_url":"git://github.com/yiisoft/yii2.git","ssh_url":"git@github.com:yiisoft/yii2.git","clone_url":"https://github.com/yiisoft/yii2.git","svn_url":"https://github.com/yiisoft/yii2","homepage":"http://www.yiiframework.com","size":53837,"stargazers_count":9675,"watchers_count":9675,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5478,"mirror_url":null,"open_issues_count":735,"forks":5478,"open_issues":735,"watchers":9675,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yiisoft/yii2/pulls/13553"},"html":{"href":"https://github.com/yiisoft/yii2/pull/13553"},"issue":{"href":"https://api.github.com/repos/yiisoft/yii2/issues/13553"},"comments":{"href":"https://api.github.com/repos/yiisoft/yii2/issues/13553/comments"},"review_comments":{"href":"https://api.github.com/repos/yiisoft/yii2/pulls/13553/comments"},"review_comment":{"href":"https://api.github.com/repos/yiisoft/yii2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yiisoft/yii2/pulls/13553/commits"},"statuses":{"href":"https://api.github.com/repos/yiisoft/yii2/statuses/76b8f393be248b18fd21fbb48178071e48bcd4e8"}}}}
{"actor":{"display_login":"d1rtyf1ng3rs"}}