{"action":"created","issue":{"url":"https://api.github.com/repos/slapperwan/gh4a/issues/714","repository_url":"https://api.github.com/repos/slapperwan/gh4a","labels_url":"https://api.github.com/repos/slapperwan/gh4a/issues/714/labels{/name}","comments_url":"https://api.github.com/repos/slapperwan/gh4a/issues/714/comments","events_url":"https://api.github.com/repos/slapperwan/gh4a/issues/714/events","html_url":"https://github.com/slapperwan/gh4a/issues/714","id":256404261,"number":714,"title":"Hard-coded Extra parameters","user":{"login":"MattiaPrimavera","id":11927970,"avatar_url":"https://avatars1.githubusercontent.com/u/11927970?v=4","gravatar_id":"","url":"https://api.github.com/users/MattiaPrimavera","html_url":"https://github.com/MattiaPrimavera","followers_url":"https://api.github.com/users/MattiaPrimavera/followers","following_url":"https://api.github.com/users/MattiaPrimavera/following{/other_user}","gists_url":"https://api.github.com/users/MattiaPrimavera/gists{/gist_id}","starred_url":"https://api.github.com/users/MattiaPrimavera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MattiaPrimavera/subscriptions","organizations_url":"https://api.github.com/users/MattiaPrimavera/orgs","repos_url":"https://api.github.com/users/MattiaPrimavera/repos","events_url":"https://api.github.com/users/MattiaPrimavera/events{/privacy}","received_events_url":"https://api.github.com/users/MattiaPrimavera/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-09-09T01:09:53Z","updated_at":"2017-09-09T11:01:44Z","closed_at":null,"author_association":"NONE","body":"Bundles extra parameters are hard-coded, this being above all **error-prone**, furthermore causing some code duplication ... plus hard-coding would require changing the variable name in several spots since they do not all refer to the same **final constant** value ... \r\n\r\n**Proposed solution**: create a **Parameters.java** file where to store all **extra** (added by **putExtra**) parameters, and refactor the code base in order for hard-coded strings to disappear. "},"comment":{"url":"https://api.github.com/repos/slapperwan/gh4a/issues/comments/328270176","html_url":"https://github.com/slapperwan/gh4a/issues/714#issuecomment-328270176","issue_url":"https://api.github.com/repos/slapperwan/gh4a/issues/714","id":328270176,"user":{"login":"MattiaPrimavera","id":11927970,"avatar_url":"https://avatars1.githubusercontent.com/u/11927970?v=4","gravatar_id":"","url":"https://api.github.com/users/MattiaPrimavera","html_url":"https://github.com/MattiaPrimavera","followers_url":"https://api.github.com/users/MattiaPrimavera/followers","following_url":"https://api.github.com/users/MattiaPrimavera/following{/other_user}","gists_url":"https://api.github.com/users/MattiaPrimavera/gists{/gist_id}","starred_url":"https://api.github.com/users/MattiaPrimavera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MattiaPrimavera/subscriptions","organizations_url":"https://api.github.com/users/MattiaPrimavera/orgs","repos_url":"https://api.github.com/users/MattiaPrimavera/repos","events_url":"https://api.github.com/users/MattiaPrimavera/events{/privacy}","received_events_url":"https://api.github.com/users/MattiaPrimavera/received_events","type":"User","site_admin":false},"created_at":"2017-09-09T11:01:44Z","updated_at":"2017-09-09T11:01:44Z","author_association":"NONE","body":"Well it's simply not good practise to hard-code strings : \n\n- that would be **Extras.OWNER**, yes more readable, highlighted as a final constant by the **IDE**, directly showing it's a **key** string.\n\n- the main interest is sharing those constants among multiple screens, instead of declare them again. In case of changing one constant parameter value, the change would be restrained to the **Extras** file \n\nOnce the **OWNER** param declared in a file, we don't worry anymore of its actual value ..."}}
{"actor":{"display_login":"MattiaPrimavera"}}