{"action":"created","comment":{"url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/comments/154127284","pull_request_review_id":80240976,"id":154127284,"diff_hunk":"@@ -77,6 +77,54 @@ bool IsSupportOptionalVulkan_1_0(uint32_t capability) {\n   return false;\n }\n \n+bool IsSupportGuaranteedOpenCL_1_2(uint32_t capability) {\n+  switch (capability) {\n+    case SpvCapabilityAddresses:\n+    case SpvCapabilityFloat16Buffer:\n+    case SpvCapabilityGroups:\n+    case SpvCapabilityInt64:","path":"source/validate_capability.cpp","position":9,"original_position":9,"commit_id":"f9693775b33705740b13e8c0a8303ea553cf0d7d","original_commit_id":"f9693775b33705740b13e8c0a8303ea553cf0d7d","user":{"login":"dneto0","id":13054574,"avatar_url":"https://avatars0.githubusercontent.com/u/13054574?v=4","gravatar_id":"","url":"https://api.github.com/users/dneto0","html_url":"https://github.com/dneto0","followers_url":"https://api.github.com/users/dneto0/followers","following_url":"https://api.github.com/users/dneto0/following{/other_user}","gists_url":"https://api.github.com/users/dneto0/gists{/gist_id}","starred_url":"https://api.github.com/users/dneto0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dneto0/subscriptions","organizations_url":"https://api.github.com/users/dneto0/orgs","repos_url":"https://api.github.com/users/dneto0/repos","events_url":"https://api.github.com/users/dneto0/events{/privacy}","received_events_url":"https://api.github.com/users/dneto0/received_events","type":"User","site_admin":false},"body":"The embedded profile requires cles_khr_int64 in order to support Int64","created_at":"2017-11-30T16:26:02Z","updated_at":"2017-11-30T16:32:31Z","html_url":"https://github.com/KhronosGroup/SPIRV-Tools/pull/1039#discussion_r154127284","pull_request_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/1039","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/comments/154127284"},"html":{"href":"https://github.com/KhronosGroup/SPIRV-Tools/pull/1039#discussion_r154127284"},"pull_request":{"href":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/1039"}}},"pull_request":{"url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/1039","id":155488252,"html_url":"https://github.com/KhronosGroup/SPIRV-Tools/pull/1039","diff_url":"https://github.com/KhronosGroup/SPIRV-Tools/pull/1039.diff","patch_url":"https://github.com/KhronosGroup/SPIRV-Tools/pull/1039.patch","issue_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/issues/1039","number":1039,"state":"open","locked":false,"title":"WIP: Validate capabilities in OpenCL SPIR-V binaries","user":{"login":"pierremoreau","id":9851680,"avatar_url":"https://avatars0.githubusercontent.com/u/9851680?v=4","gravatar_id":"","url":"https://api.github.com/users/pierremoreau","html_url":"https://github.com/pierremoreau","followers_url":"https://api.github.com/users/pierremoreau/followers","following_url":"https://api.github.com/users/pierremoreau/following{/other_user}","gists_url":"https://api.github.com/users/pierremoreau/gists{/gist_id}","starred_url":"https://api.github.com/users/pierremoreau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pierremoreau/subscriptions","organizations_url":"https://api.github.com/users/pierremoreau/orgs","repos_url":"https://api.github.com/users/pierremoreau/repos","events_url":"https://api.github.com/users/pierremoreau/events{/privacy}","received_events_url":"https://api.github.com/users/pierremoreau/received_events","type":"User","site_admin":false},"body":"Extends the validator to not only check for Vulkan SPIR-V capabilities, but also for OpenCL SPIR-V ones. OpenCL 1.2 and 2.0 can ingest SPIR-V binaries thanks to the cl_khr_program_il extension, therefore add target environment enums for those.","created_at":"2017-11-30T00:18:59Z","updated_at":"2017-11-30T16:32:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eb219674918a3421d26724898a0a8a828ae95adb","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/1039/commits","review_comments_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/1039/comments","review_comment_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/issues/1039/comments","statuses_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/statuses/f9693775b33705740b13e8c0a8303ea553cf0d7d","head":{"label":"pierremoreau:validate_opencl_capabilities","ref":"validate_opencl_capabilities","sha":"f9693775b33705740b13e8c0a8303ea553cf0d7d","user":{"login":"pierremoreau","id":9851680,"avatar_url":"https://avatars0.githubusercontent.com/u/9851680?v=4","gravatar_id":"","url":"https://api.github.com/users/pierremoreau","html_url":"https://github.com/pierremoreau","followers_url":"https://api.github.com/users/pierremoreau/followers","following_url":"https://api.github.com/users/pierremoreau/following{/other_user}","gists_url":"https://api.github.com/users/pierremoreau/gists{/gist_id}","starred_url":"https://api.github.com/users/pierremoreau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pierremoreau/subscriptions","organizations_url":"https://api.github.com/users/pierremoreau/orgs","repos_url":"https://api.github.com/users/pierremoreau/repos","events_url":"https://api.github.com/users/pierremoreau/events{/privacy}","received_events_url":"https://api.github.com/users/pierremoreau/received_events","type":"User","site_admin":false},"repo":{"id":46379351,"name":"SPIRV-Tools","full_name":"pierremoreau/SPIRV-Tools","owner":{"login":"pierremoreau","id":9851680,"avatar_url":"https://avatars0.githubusercontent.com/u/9851680?v=4","gravatar_id":"","url":"https://api.github.com/users/pierremoreau","html_url":"https://github.com/pierremoreau","followers_url":"https://api.github.com/users/pierremoreau/followers","following_url":"https://api.github.com/users/pierremoreau/following{/other_user}","gists_url":"https://api.github.com/users/pierremoreau/gists{/gist_id}","starred_url":"https://api.github.com/users/pierremoreau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pierremoreau/subscriptions","organizations_url":"https://api.github.com/users/pierremoreau/orgs","repos_url":"https://api.github.com/users/pierremoreau/repos","events_url":"https://api.github.com/users/pierremoreau/events{/privacy}","received_events_url":"https://api.github.com/users/pierremoreau/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pierremoreau/SPIRV-Tools","description":null,"fork":true,"url":"https://api.github.com/repos/pierremoreau/SPIRV-Tools","forks_url":"https://api.github.com/repos/pierremoreau/SPIRV-Tools/forks","keys_url":"https://api.github.com/repos/pierremoreau/SPIRV-Tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pierremoreau/SPIRV-Tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pierremoreau/SPIRV-Tools/teams","hooks_url":"https://api.github.com/repos/pierremoreau/SPIRV-Tools/hooks","issue_events_url":"https://api.github.com/repos/pierremoreau/SPIRV-Tools/issues/events{/number}","events_url":"https://api.github.com/repos/pierremoreau/SPIRV-Tools/events","assignees_url":"https://api.github.com/repos/pierremoreau/SPIRV-Tools/assignees{/user}","branches_url":"https://api.github.com/repos/pierremoreau/SPIRV-Tools/branches{/branch}","tags_url":"https://api.github.com/repos/pierremoreau/SPIRV-Tools/tags","blobs_url":"https://api.github.com/repos/pierremoreau/SPIRV-Tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pierremoreau/SPIRV-Tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pierremoreau/SPIRV-Tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/pierremoreau/SPIRV-Tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pierremoreau/SPIRV-Tools/statuses/{sha}","languages_url":"https://api.github.com/repos/pierremoreau/SPIRV-Tools/languages","stargazers_url":"https://api.github.com/repos/pierremoreau/SPIRV-Tools/stargazers","contributors_url":"https://api.github.com/repos/pierremoreau/SPIRV-Tools/contributors","subscribers_url":"https://api.github.com/repos/pierremoreau/SPIRV-Tools/subscribers","subscription_url":"https://api.github.com/repos/pierremoreau/SPIRV-Tools/subscription","commits_url":"https://api.github.com/repos/pierremoreau/SPIRV-Tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/pierremoreau/SPIRV-Tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/pierremoreau/SPIRV-Tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/pierremoreau/SPIRV-Tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/pierremoreau/SPIRV-Tools/contents/{+path}","compare_url":"https://api.github.com/repos/pierremoreau/SPIRV-Tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pierremoreau/SPIRV-Tools/merges","archive_url":"https://api.github.com/repos/pierremoreau/SPIRV-Tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pierremoreau/SPIRV-Tools/downloads","issues_url":"https://api.github.com/repos/pierremoreau/SPIRV-Tools/issues{/number}","pulls_url":"https://api.github.com/repos/pierremoreau/SPIRV-Tools/pulls{/number}","milestones_url":"https://api.github.com/repos/pierremoreau/SPIRV-Tools/milestones{/number}","notifications_url":"https://api.github.com/repos/pierremoreau/SPIRV-Tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pierremoreau/SPIRV-Tools/labels{/name}","releases_url":"https://api.github.com/repos/pierremoreau/SPIRV-Tools/releases{/id}","deployments_url":"https://api.github.com/repos/pierremoreau/SPIRV-Tools/deployments","created_at":"2015-11-17T22:25:29Z","updated_at":"2017-07-01T15:37:11Z","pushed_at":"2017-11-30T01:06:47Z","git_url":"git://github.com/pierremoreau/SPIRV-Tools.git","ssh_url":"git@github.com:pierremoreau/SPIRV-Tools.git","clone_url":"https://github.com/pierremoreau/SPIRV-Tools.git","svn_url":"https://github.com/pierremoreau/SPIRV-Tools","homepage":null,"size":4675,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"KhronosGroup:master","ref":"master","sha":"8cfa0c40e0afd5b6fcbedf622fd45afd2de2a055","user":{"login":"KhronosGroup","id":1608701,"avatar_url":"https://avatars3.githubusercontent.com/u/1608701?v=4","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"repo":{"id":45981801,"name":"SPIRV-Tools","full_name":"KhronosGroup/SPIRV-Tools","owner":{"login":"KhronosGroup","id":1608701,"avatar_url":"https://avatars3.githubusercontent.com/u/1608701?v=4","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KhronosGroup/SPIRV-Tools","description":null,"fork":false,"url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools","forks_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/forks","keys_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/teams","hooks_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/hooks","issue_events_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/issues/events{/number}","events_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/events","assignees_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/assignees{/user}","branches_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/branches{/branch}","tags_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/tags","blobs_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/statuses/{sha}","languages_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/languages","stargazers_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/stargazers","contributors_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/contributors","subscribers_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/subscribers","subscription_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/subscription","commits_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/contents/{+path}","compare_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/merges","archive_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/downloads","issues_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/issues{/number}","pulls_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls{/number}","milestones_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/milestones{/number}","notifications_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/labels{/name}","releases_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/releases{/id}","deployments_url":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/deployments","created_at":"2015-11-11T12:56:25Z","updated_at":"2017-11-30T01:34:01Z","pushed_at":"2017-11-30T16:01:53Z","git_url":"git://github.com/KhronosGroup/SPIRV-Tools.git","ssh_url":"git@github.com:KhronosGroup/SPIRV-Tools.git","clone_url":"https://github.com/KhronosGroup/SPIRV-Tools.git","svn_url":"https://github.com/KhronosGroup/SPIRV-Tools","homepage":null,"size":4691,"stargazers_count":223,"watchers_count":223,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":92,"mirror_url":null,"archived":false,"open_issues_count":166,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":92,"open_issues":166,"watchers":223,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/1039"},"html":{"href":"https://github.com/KhronosGroup/SPIRV-Tools/pull/1039"},"issue":{"href":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/issues/1039"},"comments":{"href":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/issues/1039/comments"},"review_comments":{"href":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/1039/comments"},"review_comment":{"href":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/pulls/1039/commits"},"statuses":{"href":"https://api.github.com/repos/KhronosGroup/SPIRV-Tools/statuses/f9693775b33705740b13e8c0a8303ea553cf0d7d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dneto0"}}