{"action":"created","comment":{"url":"https://api.github.com/repos/firebase/FirebaseUI-Android/pulls/comments/151460984","pull_request_review_id":77166878,"id":151460984,"diff_hunk":"@@ -33,20 +34,25 @@\n  */\n public class IdpResponse implements Parcelable {\n     private final User mUser;\n+\n     private final String mToken;\n     private final String mSecret;\n \n-    private final int mErrorCode;\n+    @Nullable private final Exception mException;","path":"auth/src/main/java/com/firebase/ui/auth/IdpResponse.java","position":17,"original_position":17,"commit_id":"1c162e31c157559d98d398eaeb6143c80cbee5ec","original_commit_id":"1c162e31c157559d98d398eaeb6143c80cbee5ec","user":{"login":"samtstern","id":8466666,"avatar_url":"https://avatars2.githubusercontent.com/u/8466666?v=4","gravatar_id":"","url":"https://api.github.com/users/samtstern","html_url":"https://github.com/samtstern","followers_url":"https://api.github.com/users/samtstern/followers","following_url":"https://api.github.com/users/samtstern/following{/other_user}","gists_url":"https://api.github.com/users/samtstern/gists{/gist_id}","starred_url":"https://api.github.com/users/samtstern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samtstern/subscriptions","organizations_url":"https://api.github.com/users/samtstern/orgs","repos_url":"https://api.github.com/users/samtstern/repos","events_url":"https://api.github.com/users/samtstern/events{/privacy}","received_events_url":"https://api.github.com/users/samtstern/received_events","type":"User","site_admin":false},"body":"Maybe instead of having a raw `Exception` class here we could have `FirebaseUIException` that has a \"cause\" (the underlying `Exception`) and an `ErrorCode` field.\r\n\r\nThen we wouldn't have to check `instanceof NetworkException` later and it gives us more room to expand.","created_at":"2017-11-16T16:12:22Z","updated_at":"2017-11-16T16:15:23Z","html_url":"https://github.com/firebase/FirebaseUI-Android/pull/1010#discussion_r151460984","pull_request_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/pulls/1010","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/firebase/FirebaseUI-Android/pulls/comments/151460984"},"html":{"href":"https://github.com/firebase/FirebaseUI-Android/pull/1010#discussion_r151460984"},"pull_request":{"href":"https://api.github.com/repos/firebase/FirebaseUI-Android/pulls/1010"}}},"pull_request":{"url":"https://api.github.com/repos/firebase/FirebaseUI-Android/pulls/1010","id":152966616,"html_url":"https://github.com/firebase/FirebaseUI-Android/pull/1010","diff_url":"https://github.com/firebase/FirebaseUI-Android/pull/1010.diff","patch_url":"https://github.com/firebase/FirebaseUI-Android/pull/1010.patch","issue_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/issues/1010","number":1010,"state":"open","locked":false,"title":"Rewrite relevant parts of the public API","user":{"login":"SUPERCILEX","id":9490724,"avatar_url":"https://avatars2.githubusercontent.com/u/9490724?v=4","gravatar_id":"","url":"https://api.github.com/users/SUPERCILEX","html_url":"https://github.com/SUPERCILEX","followers_url":"https://api.github.com/users/SUPERCILEX/followers","following_url":"https://api.github.com/users/SUPERCILEX/following{/other_user}","gists_url":"https://api.github.com/users/SUPERCILEX/gists{/gist_id}","starred_url":"https://api.github.com/users/SUPERCILEX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUPERCILEX/subscriptions","organizations_url":"https://api.github.com/users/SUPERCILEX/orgs","repos_url":"https://api.github.com/users/SUPERCILEX/repos","events_url":"https://api.github.com/users/SUPERCILEX/events{/privacy}","received_events_url":"https://api.github.com/users/SUPERCILEX/received_events","type":"User","site_admin":false},"body":"Built on top of #1009, starts work on #1007, `fixes` #997, preps for a future `fixing` #526.\r\n\r\nThis PR fixes some bugs in the sample app, fixes a bug where deleting a user doesn't sign it out from the idp providers, and migrates `IdpResponse` to using exceptions for its errors (#526).","created_at":"2017-11-16T07:11:50Z","updated_at":"2017-11-16T16:15:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5760a61c4f41f976d447983c58ce905a9392a5f1","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/firebase/FirebaseUI-Android/milestones/22","html_url":"https://github.com/firebase/FirebaseUI-Android/milestone/22","labels_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/milestones/22/labels","id":2844477,"number":22,"title":"3.1.1","description":"","creator":{"login":"samtstern","id":8466666,"avatar_url":"https://avatars2.githubusercontent.com/u/8466666?v=4","gravatar_id":"","url":"https://api.github.com/users/samtstern","html_url":"https://github.com/samtstern","followers_url":"https://api.github.com/users/samtstern/followers","following_url":"https://api.github.com/users/samtstern/following{/other_user}","gists_url":"https://api.github.com/users/samtstern/gists{/gist_id}","starred_url":"https://api.github.com/users/samtstern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samtstern/subscriptions","organizations_url":"https://api.github.com/users/samtstern/orgs","repos_url":"https://api.github.com/users/samtstern/repos","events_url":"https://api.github.com/users/samtstern/events{/privacy}","received_events_url":"https://api.github.com/users/samtstern/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":6,"state":"open","created_at":"2017-10-17T20:22:42Z","updated_at":"2017-11-16T16:15:31Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/pulls/1010/commits","review_comments_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/pulls/1010/comments","review_comment_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/issues/1010/comments","statuses_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/statuses/1c162e31c157559d98d398eaeb6143c80cbee5ec","head":{"label":"SUPERCILEX:public-api-rewrite","ref":"public-api-rewrite","sha":"1c162e31c157559d98d398eaeb6143c80cbee5ec","user":{"login":"SUPERCILEX","id":9490724,"avatar_url":"https://avatars2.githubusercontent.com/u/9490724?v=4","gravatar_id":"","url":"https://api.github.com/users/SUPERCILEX","html_url":"https://github.com/SUPERCILEX","followers_url":"https://api.github.com/users/SUPERCILEX/followers","following_url":"https://api.github.com/users/SUPERCILEX/following{/other_user}","gists_url":"https://api.github.com/users/SUPERCILEX/gists{/gist_id}","starred_url":"https://api.github.com/users/SUPERCILEX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUPERCILEX/subscriptions","organizations_url":"https://api.github.com/users/SUPERCILEX/orgs","repos_url":"https://api.github.com/users/SUPERCILEX/repos","events_url":"https://api.github.com/users/SUPERCILEX/events{/privacy}","received_events_url":"https://api.github.com/users/SUPERCILEX/received_events","type":"User","site_admin":false},"repo":{"id":67086210,"name":"FirebaseUI-Android","full_name":"SUPERCILEX/FirebaseUI-Android","owner":{"login":"SUPERCILEX","id":9490724,"avatar_url":"https://avatars2.githubusercontent.com/u/9490724?v=4","gravatar_id":"","url":"https://api.github.com/users/SUPERCILEX","html_url":"https://github.com/SUPERCILEX","followers_url":"https://api.github.com/users/SUPERCILEX/followers","following_url":"https://api.github.com/users/SUPERCILEX/following{/other_user}","gists_url":"https://api.github.com/users/SUPERCILEX/gists{/gist_id}","starred_url":"https://api.github.com/users/SUPERCILEX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUPERCILEX/subscriptions","organizations_url":"https://api.github.com/users/SUPERCILEX/orgs","repos_url":"https://api.github.com/users/SUPERCILEX/repos","events_url":"https://api.github.com/users/SUPERCILEX/events{/privacy}","received_events_url":"https://api.github.com/users/SUPERCILEX/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SUPERCILEX/FirebaseUI-Android","description":null,"fork":true,"url":"https://api.github.com/repos/SUPERCILEX/FirebaseUI-Android","forks_url":"https://api.github.com/repos/SUPERCILEX/FirebaseUI-Android/forks","keys_url":"https://api.github.com/repos/SUPERCILEX/FirebaseUI-Android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SUPERCILEX/FirebaseUI-Android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SUPERCILEX/FirebaseUI-Android/teams","hooks_url":"https://api.github.com/repos/SUPERCILEX/FirebaseUI-Android/hooks","issue_events_url":"https://api.github.com/repos/SUPERCILEX/FirebaseUI-Android/issues/events{/number}","events_url":"https://api.github.com/repos/SUPERCILEX/FirebaseUI-Android/events","assignees_url":"https://api.github.com/repos/SUPERCILEX/FirebaseUI-Android/assignees{/user}","branches_url":"https://api.github.com/repos/SUPERCILEX/FirebaseUI-Android/branches{/branch}","tags_url":"https://api.github.com/repos/SUPERCILEX/FirebaseUI-Android/tags","blobs_url":"https://api.github.com/repos/SUPERCILEX/FirebaseUI-Android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SUPERCILEX/FirebaseUI-Android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SUPERCILEX/FirebaseUI-Android/git/refs{/sha}","trees_url":"https://api.github.com/repos/SUPERCILEX/FirebaseUI-Android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SUPERCILEX/FirebaseUI-Android/statuses/{sha}","languages_url":"https://api.github.com/repos/SUPERCILEX/FirebaseUI-Android/languages","stargazers_url":"https://api.github.com/repos/SUPERCILEX/FirebaseUI-Android/stargazers","contributors_url":"https://api.github.com/repos/SUPERCILEX/FirebaseUI-Android/contributors","subscribers_url":"https://api.github.com/repos/SUPERCILEX/FirebaseUI-Android/subscribers","subscription_url":"https://api.github.com/repos/SUPERCILEX/FirebaseUI-Android/subscription","commits_url":"https://api.github.com/repos/SUPERCILEX/FirebaseUI-Android/commits{/sha}","git_commits_url":"https://api.github.com/repos/SUPERCILEX/FirebaseUI-Android/git/commits{/sha}","comments_url":"https://api.github.com/repos/SUPERCILEX/FirebaseUI-Android/comments{/number}","issue_comment_url":"https://api.github.com/repos/SUPERCILEX/FirebaseUI-Android/issues/comments{/number}","contents_url":"https://api.github.com/repos/SUPERCILEX/FirebaseUI-Android/contents/{+path}","compare_url":"https://api.github.com/repos/SUPERCILEX/FirebaseUI-Android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SUPERCILEX/FirebaseUI-Android/merges","archive_url":"https://api.github.com/repos/SUPERCILEX/FirebaseUI-Android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SUPERCILEX/FirebaseUI-Android/downloads","issues_url":"https://api.github.com/repos/SUPERCILEX/FirebaseUI-Android/issues{/number}","pulls_url":"https://api.github.com/repos/SUPERCILEX/FirebaseUI-Android/pulls{/number}","milestones_url":"https://api.github.com/repos/SUPERCILEX/FirebaseUI-Android/milestones{/number}","notifications_url":"https://api.github.com/repos/SUPERCILEX/FirebaseUI-Android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SUPERCILEX/FirebaseUI-Android/labels{/name}","releases_url":"https://api.github.com/repos/SUPERCILEX/FirebaseUI-Android/releases{/id}","deployments_url":"https://api.github.com/repos/SUPERCILEX/FirebaseUI-Android/deployments","created_at":"2016-09-01T01:14:01Z","updated_at":"2017-07-19T18:34:25Z","pushed_at":"2017-11-16T15:57:10Z","git_url":"git://github.com/SUPERCILEX/FirebaseUI-Android.git","ssh_url":"git@github.com:SUPERCILEX/FirebaseUI-Android.git","clone_url":"https://github.com/SUPERCILEX/FirebaseUI-Android.git","svn_url":"https://github.com/SUPERCILEX/FirebaseUI-Android","homepage":null,"size":20231,"stargazers_count":4,"watchers_count":4,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":4,"default_branch":"master"}},"base":{"label":"firebase:version-3.1.1-dev","ref":"version-3.1.1-dev","sha":"8721480a8ca9061f41c35c02bf0badceb64aa093","user":{"login":"firebase","id":1335026,"avatar_url":"https://avatars2.githubusercontent.com/u/1335026?v=4","gravatar_id":"","url":"https://api.github.com/users/firebase","html_url":"https://github.com/firebase","followers_url":"https://api.github.com/users/firebase/followers","following_url":"https://api.github.com/users/firebase/following{/other_user}","gists_url":"https://api.github.com/users/firebase/gists{/gist_id}","starred_url":"https://api.github.com/users/firebase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firebase/subscriptions","organizations_url":"https://api.github.com/users/firebase/orgs","repos_url":"https://api.github.com/users/firebase/repos","events_url":"https://api.github.com/users/firebase/events{/privacy}","received_events_url":"https://api.github.com/users/firebase/received_events","type":"Organization","site_admin":false},"repo":{"id":38835213,"name":"FirebaseUI-Android","full_name":"firebase/FirebaseUI-Android","owner":{"login":"firebase","id":1335026,"avatar_url":"https://avatars2.githubusercontent.com/u/1335026?v=4","gravatar_id":"","url":"https://api.github.com/users/firebase","html_url":"https://github.com/firebase","followers_url":"https://api.github.com/users/firebase/followers","following_url":"https://api.github.com/users/firebase/following{/other_user}","gists_url":"https://api.github.com/users/firebase/gists{/gist_id}","starred_url":"https://api.github.com/users/firebase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firebase/subscriptions","organizations_url":"https://api.github.com/users/firebase/orgs","repos_url":"https://api.github.com/users/firebase/repos","events_url":"https://api.github.com/users/firebase/events{/privacy}","received_events_url":"https://api.github.com/users/firebase/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/firebase/FirebaseUI-Android","description":"Optimized UI components for Firebase","fork":false,"url":"https://api.github.com/repos/firebase/FirebaseUI-Android","forks_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/forks","keys_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/teams","hooks_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/hooks","issue_events_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/issues/events{/number}","events_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/events","assignees_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/assignees{/user}","branches_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/branches{/branch}","tags_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/tags","blobs_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/git/refs{/sha}","trees_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/statuses/{sha}","languages_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/languages","stargazers_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/stargazers","contributors_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/contributors","subscribers_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/subscribers","subscription_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/subscription","commits_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/commits{/sha}","git_commits_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/git/commits{/sha}","comments_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/comments{/number}","issue_comment_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/issues/comments{/number}","contents_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/contents/{+path}","compare_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/merges","archive_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/downloads","issues_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/issues{/number}","pulls_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/pulls{/number}","milestones_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/milestones{/number}","notifications_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/labels{/name}","releases_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/releases{/id}","deployments_url":"https://api.github.com/repos/firebase/FirebaseUI-Android/deployments","created_at":"2015-07-09T17:31:09Z","updated_at":"2017-11-16T08:54:16Z","pushed_at":"2017-11-16T15:55:43Z","git_url":"git://github.com/firebase/FirebaseUI-Android.git","ssh_url":"git@github.com:firebase/FirebaseUI-Android.git","clone_url":"https://github.com/firebase/FirebaseUI-Android.git","svn_url":"https://github.com/firebase/FirebaseUI-Android","homepage":"https://opensource.google.com/projects/firebaseui","size":18811,"stargazers_count":2241,"watchers_count":2241,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":892,"mirror_url":null,"archived":false,"open_issues_count":47,"forks":892,"open_issues":47,"watchers":2241,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/firebase/FirebaseUI-Android/pulls/1010"},"html":{"href":"https://github.com/firebase/FirebaseUI-Android/pull/1010"},"issue":{"href":"https://api.github.com/repos/firebase/FirebaseUI-Android/issues/1010"},"comments":{"href":"https://api.github.com/repos/firebase/FirebaseUI-Android/issues/1010/comments"},"review_comments":{"href":"https://api.github.com/repos/firebase/FirebaseUI-Android/pulls/1010/comments"},"review_comment":{"href":"https://api.github.com/repos/firebase/FirebaseUI-Android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/firebase/FirebaseUI-Android/pulls/1010/commits"},"statuses":{"href":"https://api.github.com/repos/firebase/FirebaseUI-Android/statuses/1c162e31c157559d98d398eaeb6143c80cbee5ec"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"samtstern"}}