{"action":"created","comment":{"url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/pulls/comments/144431012","pull_request_review_id":69088400,"id":144431012,"diff_hunk":"@@ -1572,14 +1574,19 @@ TraceablePeerConnection.prototype.setLocalDescription = function(\n \n     this.trace('setLocalDescription::preTransform', dumpSDP(localSdp));\n \n-    if (this.options.preferH264) {\n+    if (this.options.disableH264 || this.options.preferH264) {","path":"modules/RTC/TraceablePeerConnection.js","position":14,"original_position":14,"commit_id":"f5b0d29480dcf353475dd7e84a130343ba58da6a","original_commit_id":"633eb80d9e9471661c39939971282647c0b0cfe2","user":{"login":"bgrozev","id":3264699,"avatar_url":"https://avatars0.githubusercontent.com/u/3264699?v=4","gravatar_id":"","url":"https://api.github.com/users/bgrozev","html_url":"https://github.com/bgrozev","followers_url":"https://api.github.com/users/bgrozev/followers","following_url":"https://api.github.com/users/bgrozev/following{/other_user}","gists_url":"https://api.github.com/users/bgrozev/gists{/gist_id}","starred_url":"https://api.github.com/users/bgrozev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgrozev/subscriptions","organizations_url":"https://api.github.com/users/bgrozev/orgs","repos_url":"https://api.github.com/users/bgrozev/repos","events_url":"https://api.github.com/users/bgrozev/events{/privacy}","received_events_url":"https://api.github.com/users/bgrozev/received_events","type":"User","site_admin":false},"body":"One more place where the lack of overridable config parameters makes things harder. ","created_at":"2017-10-12T23:00:37Z","updated_at":"2017-10-12T23:00:37Z","html_url":"https://github.com/jitsi/lib-jitsi-meet/pull/610#discussion_r144431012","pull_request_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/pulls/610","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/jitsi/lib-jitsi-meet/pulls/comments/144431012"},"html":{"href":"https://github.com/jitsi/lib-jitsi-meet/pull/610#discussion_r144431012"},"pull_request":{"href":"https://api.github.com/repos/jitsi/lib-jitsi-meet/pulls/610"}},"in_reply_to_id":144383697},"pull_request":{"url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/pulls/610","id":146288710,"html_url":"https://github.com/jitsi/lib-jitsi-meet/pull/610","diff_url":"https://github.com/jitsi/lib-jitsi-meet/pull/610.diff","patch_url":"https://github.com/jitsi/lib-jitsi-meet/pull/610.patch","issue_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/issues/610","number":610,"state":"closed","locked":false,"title":"feat(h264): add ability to disable H.264","user":{"login":"saghul","id":317464,"avatar_url":"https://avatars0.githubusercontent.com/u/317464?v=4","gravatar_id":"","url":"https://api.github.com/users/saghul","html_url":"https://github.com/saghul","followers_url":"https://api.github.com/users/saghul/followers","following_url":"https://api.github.com/users/saghul/following{/other_user}","gists_url":"https://api.github.com/users/saghul/gists{/gist_id}","starred_url":"https://api.github.com/users/saghul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saghul/subscriptions","organizations_url":"https://api.github.com/users/saghul/orgs","repos_url":"https://api.github.com/users/saghul/repos","events_url":"https://api.github.com/users/saghul/events{/privacy}","received_events_url":"https://api.github.com/users/saghul/received_events","type":"User","site_admin":false},"body":"This is performed by stripping all traces of H.264 from the local SDP before\r\npassing it to `setLocalDescription`.","created_at":"2017-10-12T19:02:27Z","updated_at":"2017-10-12T23:00:37Z","closed_at":"2017-10-12T22:58:04Z","merged_at":"2017-10-12T22:58:04Z","merge_commit_sha":"1387e283d4d27beaeb2845f2be1a26c038c6fd32","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/pulls/610/commits","review_comments_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/pulls/610/comments","review_comment_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/issues/610/comments","statuses_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/statuses/f5b0d29480dcf353475dd7e84a130343ba58da6a","head":{"label":"saghul:disable-h264","ref":"disable-h264","sha":"f5b0d29480dcf353475dd7e84a130343ba58da6a","user":{"login":"saghul","id":317464,"avatar_url":"https://avatars0.githubusercontent.com/u/317464?v=4","gravatar_id":"","url":"https://api.github.com/users/saghul","html_url":"https://github.com/saghul","followers_url":"https://api.github.com/users/saghul/followers","following_url":"https://api.github.com/users/saghul/following{/other_user}","gists_url":"https://api.github.com/users/saghul/gists{/gist_id}","starred_url":"https://api.github.com/users/saghul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saghul/subscriptions","organizations_url":"https://api.github.com/users/saghul/orgs","repos_url":"https://api.github.com/users/saghul/repos","events_url":"https://api.github.com/users/saghul/events{/privacy}","received_events_url":"https://api.github.com/users/saghul/received_events","type":"User","site_admin":false},"repo":{"id":79503764,"name":"lib-jitsi-meet","full_name":"saghul/lib-jitsi-meet","owner":{"login":"saghul","id":317464,"avatar_url":"https://avatars0.githubusercontent.com/u/317464?v=4","gravatar_id":"","url":"https://api.github.com/users/saghul","html_url":"https://github.com/saghul","followers_url":"https://api.github.com/users/saghul/followers","following_url":"https://api.github.com/users/saghul/following{/other_user}","gists_url":"https://api.github.com/users/saghul/gists{/gist_id}","starred_url":"https://api.github.com/users/saghul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saghul/subscriptions","organizations_url":"https://api.github.com/users/saghul/orgs","repos_url":"https://api.github.com/users/saghul/repos","events_url":"https://api.github.com/users/saghul/events{/privacy}","received_events_url":"https://api.github.com/users/saghul/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/saghul/lib-jitsi-meet","description":null,"fork":true,"url":"https://api.github.com/repos/saghul/lib-jitsi-meet","forks_url":"https://api.github.com/repos/saghul/lib-jitsi-meet/forks","keys_url":"https://api.github.com/repos/saghul/lib-jitsi-meet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saghul/lib-jitsi-meet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saghul/lib-jitsi-meet/teams","hooks_url":"https://api.github.com/repos/saghul/lib-jitsi-meet/hooks","issue_events_url":"https://api.github.com/repos/saghul/lib-jitsi-meet/issues/events{/number}","events_url":"https://api.github.com/repos/saghul/lib-jitsi-meet/events","assignees_url":"https://api.github.com/repos/saghul/lib-jitsi-meet/assignees{/user}","branches_url":"https://api.github.com/repos/saghul/lib-jitsi-meet/branches{/branch}","tags_url":"https://api.github.com/repos/saghul/lib-jitsi-meet/tags","blobs_url":"https://api.github.com/repos/saghul/lib-jitsi-meet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saghul/lib-jitsi-meet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saghul/lib-jitsi-meet/git/refs{/sha}","trees_url":"https://api.github.com/repos/saghul/lib-jitsi-meet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saghul/lib-jitsi-meet/statuses/{sha}","languages_url":"https://api.github.com/repos/saghul/lib-jitsi-meet/languages","stargazers_url":"https://api.github.com/repos/saghul/lib-jitsi-meet/stargazers","contributors_url":"https://api.github.com/repos/saghul/lib-jitsi-meet/contributors","subscribers_url":"https://api.github.com/repos/saghul/lib-jitsi-meet/subscribers","subscription_url":"https://api.github.com/repos/saghul/lib-jitsi-meet/subscription","commits_url":"https://api.github.com/repos/saghul/lib-jitsi-meet/commits{/sha}","git_commits_url":"https://api.github.com/repos/saghul/lib-jitsi-meet/git/commits{/sha}","comments_url":"https://api.github.com/repos/saghul/lib-jitsi-meet/comments{/number}","issue_comment_url":"https://api.github.com/repos/saghul/lib-jitsi-meet/issues/comments{/number}","contents_url":"https://api.github.com/repos/saghul/lib-jitsi-meet/contents/{+path}","compare_url":"https://api.github.com/repos/saghul/lib-jitsi-meet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saghul/lib-jitsi-meet/merges","archive_url":"https://api.github.com/repos/saghul/lib-jitsi-meet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saghul/lib-jitsi-meet/downloads","issues_url":"https://api.github.com/repos/saghul/lib-jitsi-meet/issues{/number}","pulls_url":"https://api.github.com/repos/saghul/lib-jitsi-meet/pulls{/number}","milestones_url":"https://api.github.com/repos/saghul/lib-jitsi-meet/milestones{/number}","notifications_url":"https://api.github.com/repos/saghul/lib-jitsi-meet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saghul/lib-jitsi-meet/labels{/name}","releases_url":"https://api.github.com/repos/saghul/lib-jitsi-meet/releases{/id}","deployments_url":"https://api.github.com/repos/saghul/lib-jitsi-meet/deployments","created_at":"2017-01-19T22:58:50Z","updated_at":"2017-01-19T22:58:54Z","pushed_at":"2017-10-12T20:03:14Z","git_url":"git://github.com/saghul/lib-jitsi-meet.git","ssh_url":"git@github.com:saghul/lib-jitsi-meet.git","clone_url":"https://github.com/saghul/lib-jitsi-meet.git","svn_url":"https://github.com/saghul/lib-jitsi-meet","homepage":null,"size":6548,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jitsi:master","ref":"master","sha":"7257ca8a6f799ae5f0067f1ad1e763b66d512645","user":{"login":"jitsi","id":3671647,"avatar_url":"https://avatars2.githubusercontent.com/u/3671647?v=4","gravatar_id":"","url":"https://api.github.com/users/jitsi","html_url":"https://github.com/jitsi","followers_url":"https://api.github.com/users/jitsi/followers","following_url":"https://api.github.com/users/jitsi/following{/other_user}","gists_url":"https://api.github.com/users/jitsi/gists{/gist_id}","starred_url":"https://api.github.com/users/jitsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jitsi/subscriptions","organizations_url":"https://api.github.com/users/jitsi/orgs","repos_url":"https://api.github.com/users/jitsi/repos","events_url":"https://api.github.com/users/jitsi/events{/privacy}","received_events_url":"https://api.github.com/users/jitsi/received_events","type":"Organization","site_admin":false},"repo":{"id":50543360,"name":"lib-jitsi-meet","full_name":"jitsi/lib-jitsi-meet","owner":{"login":"jitsi","id":3671647,"avatar_url":"https://avatars2.githubusercontent.com/u/3671647?v=4","gravatar_id":"","url":"https://api.github.com/users/jitsi","html_url":"https://github.com/jitsi","followers_url":"https://api.github.com/users/jitsi/followers","following_url":"https://api.github.com/users/jitsi/following{/other_user}","gists_url":"https://api.github.com/users/jitsi/gists{/gist_id}","starred_url":"https://api.github.com/users/jitsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jitsi/subscriptions","organizations_url":"https://api.github.com/users/jitsi/orgs","repos_url":"https://api.github.com/users/jitsi/repos","events_url":"https://api.github.com/users/jitsi/events{/privacy}","received_events_url":"https://api.github.com/users/jitsi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jitsi/lib-jitsi-meet","description":"A low-level JS video API that allows adding a completely custom video experience to web apps.","fork":false,"url":"https://api.github.com/repos/jitsi/lib-jitsi-meet","forks_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/forks","keys_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/teams","hooks_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/hooks","issue_events_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/issues/events{/number}","events_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/events","assignees_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/assignees{/user}","branches_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/branches{/branch}","tags_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/tags","blobs_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/git/refs{/sha}","trees_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/statuses/{sha}","languages_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/languages","stargazers_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/stargazers","contributors_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/contributors","subscribers_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/subscribers","subscription_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/subscription","commits_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/commits{/sha}","git_commits_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/git/commits{/sha}","comments_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/comments{/number}","issue_comment_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/issues/comments{/number}","contents_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/contents/{+path}","compare_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/merges","archive_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/downloads","issues_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/issues{/number}","pulls_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/pulls{/number}","milestones_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/milestones{/number}","notifications_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/labels{/name}","releases_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/releases{/id}","deployments_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/deployments","created_at":"2016-01-27T22:44:09Z","updated_at":"2017-10-09T19:43:12Z","pushed_at":"2017-10-12T22:58:04Z","git_url":"git://github.com/jitsi/lib-jitsi-meet.git","ssh_url":"git@github.com:jitsi/lib-jitsi-meet.git","clone_url":"https://github.com/jitsi/lib-jitsi-meet.git","svn_url":"https://github.com/jitsi/lib-jitsi-meet","homepage":"","size":6645,"stargazers_count":60,"watchers_count":60,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":95,"mirror_url":null,"open_issues_count":42,"forks":95,"open_issues":42,"watchers":60,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jitsi/lib-jitsi-meet/pulls/610"},"html":{"href":"https://github.com/jitsi/lib-jitsi-meet/pull/610"},"issue":{"href":"https://api.github.com/repos/jitsi/lib-jitsi-meet/issues/610"},"comments":{"href":"https://api.github.com/repos/jitsi/lib-jitsi-meet/issues/610/comments"},"review_comments":{"href":"https://api.github.com/repos/jitsi/lib-jitsi-meet/pulls/610/comments"},"review_comment":{"href":"https://api.github.com/repos/jitsi/lib-jitsi-meet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jitsi/lib-jitsi-meet/pulls/610/commits"},"statuses":{"href":"https://api.github.com/repos/jitsi/lib-jitsi-meet/statuses/f5b0d29480dcf353475dd7e84a130343ba58da6a"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"bgrozev"}}