{"push_id":1813068657,"size":1,"distinct_size":1,"ref":"refs/heads/master","head":"494648f679a15104dd11f45354bec61867e35691","before":"5225f39062651a5e277fd358f8edf6b501a050d8","commits":[{"sha":"494648f679a15104dd11f45354bec61867e35691","author":{"name":"vlasov","email":"f77552915b3e687525f36288dc74ee5f8110c7bb@mail.ru"},"message":"--fixed\n1)\nhttps://github.com/vlasovjr/VL/blob/master/src/main/java/sample/CityCoins.java#L17\n if(valid(input))\n        for(int i=0, index=0; input.get(i).charAt(0)!='0';i++,index++){\n===\nyou can change to\n\nif (!valid(input))\n{ return; }\n\n...\n\n--removed\n2)\nhttps://github.com/vlasovjr/VL/blob/master/src/main/java/sample/CityCoins.java#L75\nfor(int i=0; i<25;i++)\n            for(int j=0; j<25; j++)\n\n25 - is a magic number? define the constant somewhere\n\n--removed\n3)\n\nhttps://github.com/vlasovjr/VL/blob/master/src/main/java/sample/CityCoins.java#L84\n\nremove commented line\n\n--removed\n4)\nhttps://github.com/vlasovjr/VL/blob/master/src/main/java/sample/CityCoins.java#L126\n    private void makeTransaction(CityGrid[][] cityGrid){\n        for(int i=0; i<cityGrid.length; i++)\n\n==\nthe whole method is a nightmare. Why do you fill 25x25 grid and check empty cells everytime for being filled in?????? Can't you just make a dynamic container in 21th century??? '\n\n--fixed\n5)\nhttps://github.com/vlasovjr/VL/blob/master/src/main/java/sample/CityCoins.java#L86\n                        if(m==n)\n                        {\n                            cityGrid[i][j].coins[m] = new Coins();\n                            cityGrid[i][j].coins[m].count = 1000000;\n                            cityGrid[i][j].coins[m].countryName = countries[m].name;\n\nthere is no difference between if (m==n) and else conditions, remove this if at all.\n\n--fixed\n6)\nhttps://github.com/vlasovjr/VL/blob/master/src/main/java/sample/Main.java#L14\nremove commented line\n\n--fixed\n7)\nIn general - there is no even code style in your code. in what way do you prefer to place brackets?\nif () {\n}\nelse {\n}\n\nor\nif ()\n{\n}\nelse\n{\n}\n\nor\n\nif () {\n} else {\n}\n\n--removed\n8)\nhttps://github.com/vlasovjr/VL/blob/master/src/main/java/sample/CityCoins.java#L82\n                    cityGrid[i][j].countryName = countries[n].name;\n==\nduplicating names leds to redundancy, please remove. What about oop? can't you just use aggregation of Country to CityGrid?","distinct":true,"url":"https://api.github.com/repos/vlasovjr/VL/commits/494648f679a15104dd11f45354bec61867e35691"}]}
{"actor":{"display_login":"vlasovjr"}}