{"action":"created","comment":{"url":"https://api.github.com/repos/okta/okta-signin-widget/pulls/comments/135582735","pull_request_review_id":59009460,"id":135582735,"diff_hunk":"@@ -93,72 +105,73 @@ function (Okta, FormController, Enums, FormType, ValidationUtil, ContactSupport,\n               innerTooltip: Okta.loc('password.forgot.email.or.username.tooltip', 'login'),\n               icon: 'person-16-gray'\n             }\n-          })\n-        ];\n-        var smsEnabled = this.settings.get('features.smsRecovery');\n-        var callEnabled = this.settings.get('features.callRecovery');\n-        if (smsEnabled || callEnabled) {\n-          formChildren.push(FormType.View({\n-            View: Okta.View.extend({\n-              template: '\\\n-                <p class=\"mobile-recovery-hint\">\\\n-                  {{i18n code=\"recovery.mobile.hint\" bundle=\"login\" arguments=\"mobileFactors\"}}\\\n-                </p>',\n-              getTemplateData: function () {\n-                var mobileFactors;\n-                if (smsEnabled && callEnabled) {\n-                  mobileFactors = Okta.loc('recovery.smsOrCall');\n-                }\n-                else if (callEnabled) {\n-                  mobileFactors = Okta.loc('recovery.call');\n-                }\n-                else {\n-                  mobileFactors = Okta.loc('recovery.sms');\n-                }\n-                return { mobileFactors : mobileFactors };\n-              }\n-            })\n           }));\n+          if (smsEnabled || callEnabled) {\n+            formChildren.push(FormType.View({\n+              View: Okta.View.extend({\n+                template: '\\\n+                  <p class=\"mobile-recovery-hint\">\\\n+                    {{i18n code=\"recovery.mobile.hint\" bundle=\"login\" arguments=\"mobileFactors\"}}\\\n+                  </p>',\n+                getTemplateData: function () {\n+                  var mobileFactors;\n+                  if (smsEnabled && callEnabled) {\n+                    mobileFactors = Okta.loc('recovery.smsOrCall');\n+                  }\n+                  else if (callEnabled) {\n+                    mobileFactors = Okta.loc('recovery.call');\n+                  }\n+                  else {\n+                    mobileFactors = Okta.loc('recovery.sms');\n+                  }\n+                  return { mobileFactors : mobileFactors };\n+                }\n+              })\n+            }));\n+          }\n+          if(smsEnabled) {\n+            this.$el.addClass('forgot-password-sms-enabled');\n+            formChildren.push(this.addRecoveryFactorButton('sms-button', 'password.forgot.sendText',\n+              Enums.RECOVERY_FACTOR_TYPE_SMS, this));\n+          }\n+          if(callEnabled) {\n+            this.$el.addClass('forgot-password-call-enabled');\n+            formChildren.push(this.addRecoveryFactorButton('call-button', 'password.forgot.call',\n+              Enums.RECOVERY_FACTOR_TYPE_CALL, this));\n+          }\n+          if(emailEnabled) {\n+            this.$el.addClass('forgot-password-email-enabled');\n+            formChildren.push(this.addRecoveryFactorButton('email-button', 'password.forgot.sendEmail',\n+              Enums.RECOVERY_FACTOR_TYPE_EMAIL, this));\n+          }\n         }\n \n         return formChildren;\n       },\n       initialize: function () {\n-        var form = this;\n-\n-        if (this.settings.get('features.callRecovery')) {\n-          this.$el.addClass('forgot-password-call-enabled');\n-          this.addRecoveryFactorButton('call-button', 'password.forgot.call',\n-            Enums.RECOVERY_FACTOR_TYPE_CALL, form);\n-        }\n-        if (this.settings.get('features.smsRecovery')) {\n-          this.$el.addClass('forgot-password-sms-enabled');\n-          this.addRecoveryFactorButton('sms-button', 'password.forgot.sendText',\n-            Enums.RECOVERY_FACTOR_TYPE_SMS, form);\n-        }\n \n         this.listenTo(this.state, 'contactSupport', function () {\n           this.add(ContactSupport, '.o-form-error-container');\n         });\n \n         this.listenTo(this, 'save', function () {\n           this.options.appState.set('username', this.model.get('username'));\n+          this.model.save();\n         });\n       },\n       addRecoveryFactorButton: function (className, labelCode, factorType, form) {","path":"src/ForgotPasswordController.js","position":137,"original_position":137,"commit_id":"c066de357959c91a1fbd0a15453ec0dc68d4e9e5","original_commit_id":"c066de357959c91a1fbd0a15453ec0dc68d4e9e5","user":{"login":"mauriciocastillosilva-okta","id":6979296,"avatar_url":"https://avatars1.githubusercontent.com/u/6979296?v=4","gravatar_id":"","url":"https://api.github.com/users/mauriciocastillosilva-okta","html_url":"https://github.com/mauriciocastillosilva-okta","followers_url":"https://api.github.com/users/mauriciocastillosilva-okta/followers","following_url":"https://api.github.com/users/mauriciocastillosilva-okta/following{/other_user}","gists_url":"https://api.github.com/users/mauriciocastillosilva-okta/gists{/gist_id}","starred_url":"https://api.github.com/users/mauriciocastillosilva-okta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mauriciocastillosilva-okta/subscriptions","organizations_url":"https://api.github.com/users/mauriciocastillosilva-okta/orgs","repos_url":"https://api.github.com/users/mauriciocastillosilva-okta/repos","events_url":"https://api.github.com/users/mauriciocastillosilva-okta/events{/privacy}","received_events_url":"https://api.github.com/users/mauriciocastillosilva-okta/received_events","type":"User","site_admin":false},"body":"nit: rename this to ```createRecoveryFactorButton``` or something similar, since this function no longer adds a button","created_at":"2017-08-28T17:28:23Z","updated_at":"2017-08-28T17:40:04Z","html_url":"https://github.com/okta/okta-signin-widget/pull/287#discussion_r135582735","pull_request_url":"https://api.github.com/repos/okta/okta-signin-widget/pulls/287","_links":{"self":{"href":"https://api.github.com/repos/okta/okta-signin-widget/pulls/comments/135582735"},"html":{"href":"https://github.com/okta/okta-signin-widget/pull/287#discussion_r135582735"},"pull_request":{"href":"https://api.github.com/repos/okta/okta-signin-widget/pulls/287"}}},"pull_request":{"url":"https://api.github.com/repos/okta/okta-signin-widget/pulls/287","id":137034028,"html_url":"https://github.com/okta/okta-signin-widget/pull/287","diff_url":"https://github.com/okta/okta-signin-widget/pull/287.diff","patch_url":"https://github.com/okta/okta-signin-widget/pull/287.patch","issue_url":"https://api.github.com/repos/okta/okta-signin-widget/issues/287","number":287,"state":"open","locked":false,"title":":seedling: Adds option to hide email from recovery flow","user":{"login":"gowthamidommety-okta","id":26014318,"avatar_url":"https://avatars0.githubusercontent.com/u/26014318?v=4","gravatar_id":"","url":"https://api.github.com/users/gowthamidommety-okta","html_url":"https://github.com/gowthamidommety-okta","followers_url":"https://api.github.com/users/gowthamidommety-okta/followers","following_url":"https://api.github.com/users/gowthamidommety-okta/following{/other_user}","gists_url":"https://api.github.com/users/gowthamidommety-okta/gists{/gist_id}","starred_url":"https://api.github.com/users/gowthamidommety-okta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gowthamidommety-okta/subscriptions","organizations_url":"https://api.github.com/users/gowthamidommety-okta/orgs","repos_url":"https://api.github.com/users/gowthamidommety-okta/repos","events_url":"https://api.github.com/users/gowthamidommety-okta/events{/privacy}","received_events_url":"https://api.github.com/users/gowthamidommety-okta/received_events","type":"User","site_admin":false},"body":"Resolves: OKTA-136405\r\n\r\n<img width=\"454\" alt=\"screen shot 2017-08-22 at 10 27 13 am\" src=\"https://user-images.githubusercontent.com/26014318/29578580-8f74edec-8724-11e7-998e-d6c87232b806.png\">\r\n\r\n<img width=\"409\" alt=\"screen shot 2017-08-22 at 3 25 38 pm\" src=\"https://user-images.githubusercontent.com/26014318/29590942-2fc1b344-8751-11e7-84d7-cecfff37ee99.png\">\r\n","created_at":"2017-08-22T17:14:14Z","updated_at":"2017-08-28T17:40:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b012668761251dab3319a08c3f9dbd654e2e81a5","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/okta/okta-signin-widget/pulls/287/commits","review_comments_url":"https://api.github.com/repos/okta/okta-signin-widget/pulls/287/comments","review_comment_url":"https://api.github.com/repos/okta/okta-signin-widget/pulls/comments{/number}","comments_url":"https://api.github.com/repos/okta/okta-signin-widget/issues/287/comments","statuses_url":"https://api.github.com/repos/okta/okta-signin-widget/statuses/c066de357959c91a1fbd0a15453ec0dc68d4e9e5","head":{"label":"gowthamidommety-okta:gd-OKTA-136405-hideEmailFromRecovery","ref":"gd-OKTA-136405-hideEmailFromRecovery","sha":"c066de357959c91a1fbd0a15453ec0dc68d4e9e5","user":{"login":"gowthamidommety-okta","id":26014318,"avatar_url":"https://avatars0.githubusercontent.com/u/26014318?v=4","gravatar_id":"","url":"https://api.github.com/users/gowthamidommety-okta","html_url":"https://github.com/gowthamidommety-okta","followers_url":"https://api.github.com/users/gowthamidommety-okta/followers","following_url":"https://api.github.com/users/gowthamidommety-okta/following{/other_user}","gists_url":"https://api.github.com/users/gowthamidommety-okta/gists{/gist_id}","starred_url":"https://api.github.com/users/gowthamidommety-okta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gowthamidommety-okta/subscriptions","organizations_url":"https://api.github.com/users/gowthamidommety-okta/orgs","repos_url":"https://api.github.com/users/gowthamidommety-okta/repos","events_url":"https://api.github.com/users/gowthamidommety-okta/events{/privacy}","received_events_url":"https://api.github.com/users/gowthamidommety-okta/received_events","type":"User","site_admin":false},"repo":{"id":84500444,"name":"okta-signin-widget","full_name":"gowthamidommety-okta/okta-signin-widget","owner":{"login":"gowthamidommety-okta","id":26014318,"avatar_url":"https://avatars0.githubusercontent.com/u/26014318?v=4","gravatar_id":"","url":"https://api.github.com/users/gowthamidommety-okta","html_url":"https://github.com/gowthamidommety-okta","followers_url":"https://api.github.com/users/gowthamidommety-okta/followers","following_url":"https://api.github.com/users/gowthamidommety-okta/following{/other_user}","gists_url":"https://api.github.com/users/gowthamidommety-okta/gists{/gist_id}","starred_url":"https://api.github.com/users/gowthamidommety-okta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gowthamidommety-okta/subscriptions","organizations_url":"https://api.github.com/users/gowthamidommety-okta/orgs","repos_url":"https://api.github.com/users/gowthamidommety-okta/repos","events_url":"https://api.github.com/users/gowthamidommety-okta/events{/privacy}","received_events_url":"https://api.github.com/users/gowthamidommety-okta/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gowthamidommety-okta/okta-signin-widget","description":"Okta SignIn widget that renders the new login/auth/recovery flows","fork":true,"url":"https://api.github.com/repos/gowthamidommety-okta/okta-signin-widget","forks_url":"https://api.github.com/repos/gowthamidommety-okta/okta-signin-widget/forks","keys_url":"https://api.github.com/repos/gowthamidommety-okta/okta-signin-widget/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gowthamidommety-okta/okta-signin-widget/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gowthamidommety-okta/okta-signin-widget/teams","hooks_url":"https://api.github.com/repos/gowthamidommety-okta/okta-signin-widget/hooks","issue_events_url":"https://api.github.com/repos/gowthamidommety-okta/okta-signin-widget/issues/events{/number}","events_url":"https://api.github.com/repos/gowthamidommety-okta/okta-signin-widget/events","assignees_url":"https://api.github.com/repos/gowthamidommety-okta/okta-signin-widget/assignees{/user}","branches_url":"https://api.github.com/repos/gowthamidommety-okta/okta-signin-widget/branches{/branch}","tags_url":"https://api.github.com/repos/gowthamidommety-okta/okta-signin-widget/tags","blobs_url":"https://api.github.com/repos/gowthamidommety-okta/okta-signin-widget/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gowthamidommety-okta/okta-signin-widget/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gowthamidommety-okta/okta-signin-widget/git/refs{/sha}","trees_url":"https://api.github.com/repos/gowthamidommety-okta/okta-signin-widget/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gowthamidommety-okta/okta-signin-widget/statuses/{sha}","languages_url":"https://api.github.com/repos/gowthamidommety-okta/okta-signin-widget/languages","stargazers_url":"https://api.github.com/repos/gowthamidommety-okta/okta-signin-widget/stargazers","contributors_url":"https://api.github.com/repos/gowthamidommety-okta/okta-signin-widget/contributors","subscribers_url":"https://api.github.com/repos/gowthamidommety-okta/okta-signin-widget/subscribers","subscription_url":"https://api.github.com/repos/gowthamidommety-okta/okta-signin-widget/subscription","commits_url":"https://api.github.com/repos/gowthamidommety-okta/okta-signin-widget/commits{/sha}","git_commits_url":"https://api.github.com/repos/gowthamidommety-okta/okta-signin-widget/git/commits{/sha}","comments_url":"https://api.github.com/repos/gowthamidommety-okta/okta-signin-widget/comments{/number}","issue_comment_url":"https://api.github.com/repos/gowthamidommety-okta/okta-signin-widget/issues/comments{/number}","contents_url":"https://api.github.com/repos/gowthamidommety-okta/okta-signin-widget/contents/{+path}","compare_url":"https://api.github.com/repos/gowthamidommety-okta/okta-signin-widget/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gowthamidommety-okta/okta-signin-widget/merges","archive_url":"https://api.github.com/repos/gowthamidommety-okta/okta-signin-widget/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gowthamidommety-okta/okta-signin-widget/downloads","issues_url":"https://api.github.com/repos/gowthamidommety-okta/okta-signin-widget/issues{/number}","pulls_url":"https://api.github.com/repos/gowthamidommety-okta/okta-signin-widget/pulls{/number}","milestones_url":"https://api.github.com/repos/gowthamidommety-okta/okta-signin-widget/milestones{/number}","notifications_url":"https://api.github.com/repos/gowthamidommety-okta/okta-signin-widget/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gowthamidommety-okta/okta-signin-widget/labels{/name}","releases_url":"https://api.github.com/repos/gowthamidommety-okta/okta-signin-widget/releases{/id}","deployments_url":"https://api.github.com/repos/gowthamidommety-okta/okta-signin-widget/deployments","created_at":"2017-03-10T00:05:00Z","updated_at":"2017-03-10T00:05:03Z","pushed_at":"2017-08-25T23:20:48Z","git_url":"git://github.com/gowthamidommety-okta/okta-signin-widget.git","ssh_url":"git@github.com:gowthamidommety-okta/okta-signin-widget.git","clone_url":"https://github.com/gowthamidommety-okta/okta-signin-widget.git","svn_url":"https://github.com/gowthamidommety-okta/okta-signin-widget","homepage":null,"size":16407,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"okta:master","ref":"master","sha":"af51f2c73279139c430e4e6c8a4071f66cbe8748","user":{"login":"okta","id":362460,"avatar_url":"https://avatars1.githubusercontent.com/u/362460?v=4","gravatar_id":"","url":"https://api.github.com/users/okta","html_url":"https://github.com/okta","followers_url":"https://api.github.com/users/okta/followers","following_url":"https://api.github.com/users/okta/following{/other_user}","gists_url":"https://api.github.com/users/okta/gists{/gist_id}","starred_url":"https://api.github.com/users/okta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/okta/subscriptions","organizations_url":"https://api.github.com/users/okta/orgs","repos_url":"https://api.github.com/users/okta/repos","events_url":"https://api.github.com/users/okta/events{/privacy}","received_events_url":"https://api.github.com/users/okta/received_events","type":"Organization","site_admin":false},"repo":{"id":46365690,"name":"okta-signin-widget","full_name":"okta/okta-signin-widget","owner":{"login":"okta","id":362460,"avatar_url":"https://avatars1.githubusercontent.com/u/362460?v=4","gravatar_id":"","url":"https://api.github.com/users/okta","html_url":"https://github.com/okta","followers_url":"https://api.github.com/users/okta/followers","following_url":"https://api.github.com/users/okta/following{/other_user}","gists_url":"https://api.github.com/users/okta/gists{/gist_id}","starred_url":"https://api.github.com/users/okta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/okta/subscriptions","organizations_url":"https://api.github.com/users/okta/orgs","repos_url":"https://api.github.com/users/okta/repos","events_url":"https://api.github.com/users/okta/events{/privacy}","received_events_url":"https://api.github.com/users/okta/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/okta/okta-signin-widget","description":"Okta SignIn widget that renders the new login/auth/recovery flows","fork":false,"url":"https://api.github.com/repos/okta/okta-signin-widget","forks_url":"https://api.github.com/repos/okta/okta-signin-widget/forks","keys_url":"https://api.github.com/repos/okta/okta-signin-widget/keys{/key_id}","collaborators_url":"https://api.github.com/repos/okta/okta-signin-widget/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/okta/okta-signin-widget/teams","hooks_url":"https://api.github.com/repos/okta/okta-signin-widget/hooks","issue_events_url":"https://api.github.com/repos/okta/okta-signin-widget/issues/events{/number}","events_url":"https://api.github.com/repos/okta/okta-signin-widget/events","assignees_url":"https://api.github.com/repos/okta/okta-signin-widget/assignees{/user}","branches_url":"https://api.github.com/repos/okta/okta-signin-widget/branches{/branch}","tags_url":"https://api.github.com/repos/okta/okta-signin-widget/tags","blobs_url":"https://api.github.com/repos/okta/okta-signin-widget/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/okta/okta-signin-widget/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/okta/okta-signin-widget/git/refs{/sha}","trees_url":"https://api.github.com/repos/okta/okta-signin-widget/git/trees{/sha}","statuses_url":"https://api.github.com/repos/okta/okta-signin-widget/statuses/{sha}","languages_url":"https://api.github.com/repos/okta/okta-signin-widget/languages","stargazers_url":"https://api.github.com/repos/okta/okta-signin-widget/stargazers","contributors_url":"https://api.github.com/repos/okta/okta-signin-widget/contributors","subscribers_url":"https://api.github.com/repos/okta/okta-signin-widget/subscribers","subscription_url":"https://api.github.com/repos/okta/okta-signin-widget/subscription","commits_url":"https://api.github.com/repos/okta/okta-signin-widget/commits{/sha}","git_commits_url":"https://api.github.com/repos/okta/okta-signin-widget/git/commits{/sha}","comments_url":"https://api.github.com/repos/okta/okta-signin-widget/comments{/number}","issue_comment_url":"https://api.github.com/repos/okta/okta-signin-widget/issues/comments{/number}","contents_url":"https://api.github.com/repos/okta/okta-signin-widget/contents/{+path}","compare_url":"https://api.github.com/repos/okta/okta-signin-widget/compare/{base}...{head}","merges_url":"https://api.github.com/repos/okta/okta-signin-widget/merges","archive_url":"https://api.github.com/repos/okta/okta-signin-widget/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/okta/okta-signin-widget/downloads","issues_url":"https://api.github.com/repos/okta/okta-signin-widget/issues{/number}","pulls_url":"https://api.github.com/repos/okta/okta-signin-widget/pulls{/number}","milestones_url":"https://api.github.com/repos/okta/okta-signin-widget/milestones{/number}","notifications_url":"https://api.github.com/repos/okta/okta-signin-widget/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/okta/okta-signin-widget/labels{/name}","releases_url":"https://api.github.com/repos/okta/okta-signin-widget/releases{/id}","deployments_url":"https://api.github.com/repos/okta/okta-signin-widget/deployments","created_at":"2015-11-17T18:08:41Z","updated_at":"2017-08-24T15:29:27Z","pushed_at":"2017-08-28T12:25:26Z","git_url":"git://github.com/okta/okta-signin-widget.git","ssh_url":"git@github.com:okta/okta-signin-widget.git","clone_url":"https://github.com/okta/okta-signin-widget.git","svn_url":"https://github.com/okta/okta-signin-widget","homepage":null,"size":16264,"stargazers_count":17,"watchers_count":17,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":38,"mirror_url":null,"open_issues_count":31,"forks":38,"open_issues":31,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/okta/okta-signin-widget/pulls/287"},"html":{"href":"https://github.com/okta/okta-signin-widget/pull/287"},"issue":{"href":"https://api.github.com/repos/okta/okta-signin-widget/issues/287"},"comments":{"href":"https://api.github.com/repos/okta/okta-signin-widget/issues/287/comments"},"review_comments":{"href":"https://api.github.com/repos/okta/okta-signin-widget/pulls/287/comments"},"review_comment":{"href":"https://api.github.com/repos/okta/okta-signin-widget/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/okta/okta-signin-widget/pulls/287/commits"},"statuses":{"href":"https://api.github.com/repos/okta/okta-signin-widget/statuses/c066de357959c91a1fbd0a15453ec0dc68d4e9e5"}}}}
{"actor":{"display_login":"mauriciocastillosilva-okta"}}