{"action":"created","issue":{"url":"https://api.github.com/repos/btc1/bitcoin/issues/131","repository_url":"https://api.github.com/repos/btc1/bitcoin","labels_url":"https://api.github.com/repos/btc1/bitcoin/issues/131/labels{/name}","comments_url":"https://api.github.com/repos/btc1/bitcoin/issues/131/comments","events_url":"https://api.github.com/repos/btc1/bitcoin/issues/131/events","html_url":"https://github.com/btc1/bitcoin/pull/131","id":264272633,"number":131,"title":"Add opt-in replay protection towards 1X chain","user":{"login":"matsjj","id":4670837,"avatar_url":"https://avatars2.githubusercontent.com/u/4670837?v=4","gravatar_id":"","url":"https://api.github.com/users/matsjj","html_url":"https://github.com/matsjj","followers_url":"https://api.github.com/users/matsjj/followers","following_url":"https://api.github.com/users/matsjj/following{/other_user}","gists_url":"https://api.github.com/users/matsjj/gists{/gist_id}","starred_url":"https://api.github.com/users/matsjj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matsjj/subscriptions","organizations_url":"https://api.github.com/users/matsjj/orgs","repos_url":"https://api.github.com/users/matsjj/repos","events_url":"https://api.github.com/users/matsjj/events{/privacy}","received_events_url":"https://api.github.com/users/matsjj/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2017-10-10T15:27:29Z","updated_at":"2017-10-10T17:35:15Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/btc1/bitcoin/pulls/131","html_url":"https://github.com/btc1/bitcoin/pull/131","diff_url":"https://github.com/btc1/bitcoin/pull/131.diff","patch_url":"https://github.com/btc1/bitcoin/pull/131.patch"},"body":"This is a WIP branch. \r\n\r\nThe initial idea is to take something that is currently forbidden in bitcoin, but only checked by full nodes, and allow it. By doing this, we allow wallets to create transactions that are only valid on this chain.\r\n\r\nFor this PR I've chosen a new SIGHASH id, similar to the approach taken by Bitcoin Cash (except that we don't *require* this SIGHASH, we barely allow it). We need to assess whether there are any light wallets that do actually do any sanity checks on the SIGHASH field. Unless there are, this change should satisfy the condition, of _not breaking consumer wallets_. \r\n\r\nI am aware that this change adds some technical debt. Ideally we also add a sunset clause, although it would need to have a large time horizon (2 years+).\r\n\r\nThere are other approaches, as described in https://github.com/btc1/bitcoin/issues/34#issuecomment-324431253 - they might have other merits or downsides, I am open for discussion.\r\n\r\nTests haven't been written/fixed yet, as I first want to see if this approach has consensus."},"comment":{"url":"https://api.github.com/repos/btc1/bitcoin/issues/comments/335550191","html_url":"https://github.com/btc1/bitcoin/pull/131#issuecomment-335550191","issue_url":"https://api.github.com/repos/btc1/bitcoin/issues/131","id":335550191,"user":{"login":"matsjj","id":4670837,"avatar_url":"https://avatars2.githubusercontent.com/u/4670837?v=4","gravatar_id":"","url":"https://api.github.com/users/matsjj","html_url":"https://github.com/matsjj","followers_url":"https://api.github.com/users/matsjj/followers","following_url":"https://api.github.com/users/matsjj/following{/other_user}","gists_url":"https://api.github.com/users/matsjj/gists{/gist_id}","starred_url":"https://api.github.com/users/matsjj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matsjj/subscriptions","organizations_url":"https://api.github.com/users/matsjj/orgs","repos_url":"https://api.github.com/users/matsjj/repos","events_url":"https://api.github.com/users/matsjj/events{/privacy}","received_events_url":"https://api.github.com/users/matsjj/received_events","type":"User","site_admin":false},"created_at":"2017-10-10T17:35:15Z","updated_at":"2017-10-10T17:35:15Z","author_association":"NONE","body":"> This patch appears to only affect policy and not consensus.\r\n\r\nMind to elaborate? :)\r\n\r\nFrom my understanding, adding the flag to allow for an additional SIGHASH type in ConnectBlock \r\n\r\nhttps://github.com/btc1/bitcoin/pull/131/files#diff-24efdb00bfbe56b140fb006b562cc70bR1738\r\n\r\nis a consensus change (making a previously invalid block, one that contains a transaction with a new SIGHASH type, valid). "}}
{"actor":{"display_login":"matsjj"}}