{"action":"created","issue":{"url":"https://api.github.com/repos/apache/kafka/issues/3894","repository_url":"https://api.github.com/repos/apache/kafka","labels_url":"https://api.github.com/repos/apache/kafka/issues/3894/labels{/name}","comments_url":"https://api.github.com/repos/apache/kafka/issues/3894/comments","events_url":"https://api.github.com/repos/apache/kafka/issues/3894/events","html_url":"https://github.com/apache/kafka/pull/3894","id":258681996,"number":3894,"title":"KAFKA-5928: Avoid redundant requests to zookeeper when reassign topic partition","user":{"login":"uncleGen","id":7402327,"avatar_url":"https://avatars1.githubusercontent.com/u/7402327?v=4","gravatar_id":"","url":"https://api.github.com/users/uncleGen","html_url":"https://github.com/uncleGen","followers_url":"https://api.github.com/users/uncleGen/followers","following_url":"https://api.github.com/users/uncleGen/following{/other_user}","gists_url":"https://api.github.com/users/uncleGen/gists{/gist_id}","starred_url":"https://api.github.com/users/uncleGen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uncleGen/subscriptions","organizations_url":"https://api.github.com/users/uncleGen/orgs","repos_url":"https://api.github.com/users/uncleGen/repos","events_url":"https://api.github.com/users/uncleGen/events{/privacy}","received_events_url":"https://api.github.com/users/uncleGen/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2017-09-19T03:06:32Z","updated_at":"2017-11-15T05:33:24Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/apache/kafka/pulls/3894","html_url":"https://github.com/apache/kafka/pull/3894","diff_url":"https://github.com/apache/kafka/pull/3894.diff","patch_url":"https://github.com/apache/kafka/pull/3894.patch"},"body":"We mistakenly request topic level information according to partitions config in the assignment json file. For example https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala#L550:\r\n```\r\nval validPartitions = proposedPartitionAssignment.filter { case (p, _) => validatePartition(zkUtils, p.topic, p.partition) } \r\n```\r\nIf reassign 1000 partitions (in 10 topics), we need to request zookeeper 1000 times here. But actually we only need to request just 10 (topics) times. We test a large-scale assignment, about 10K partitions. It takes tens of minutes. After optimization, it will reduce to less than 1minute."},"comment":{"url":"https://api.github.com/repos/apache/kafka/issues/comments/344490671","html_url":"https://github.com/apache/kafka/pull/3894#issuecomment-344490671","issue_url":"https://api.github.com/repos/apache/kafka/issues/3894","id":344490671,"user":{"login":"asfgit","id":1341245,"avatar_url":"https://avatars1.githubusercontent.com/u/1341245?v=4","gravatar_id":"","url":"https://api.github.com/users/asfgit","html_url":"https://github.com/asfgit","followers_url":"https://api.github.com/users/asfgit/followers","following_url":"https://api.github.com/users/asfgit/following{/other_user}","gists_url":"https://api.github.com/users/asfgit/gists{/gist_id}","starred_url":"https://api.github.com/users/asfgit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asfgit/subscriptions","organizations_url":"https://api.github.com/users/asfgit/orgs","repos_url":"https://api.github.com/users/asfgit/repos","events_url":"https://api.github.com/users/asfgit/events{/privacy}","received_events_url":"https://api.github.com/users/asfgit/received_events","type":"User","site_admin":false},"created_at":"2017-11-15T05:33:24Z","updated_at":"2017-11-15T05:33:24Z","author_association":"NONE","body":"FAILURE\n 7959 tests run, 5 skipped, 1 failed.\n--none--"}}
{"actor":{"display_login":"asfgit"}}