{"action":"created","comment":{"url":"https://api.github.com/repos/classmethod-sandbox/sparrow/pulls/comments/108213003","pull_request_review_id":29229943,"id":108213003,"diff_hunk":"@@ -0,0 +1,28 @@\n+/*\n+ * Copyright 2017 the original author or authors.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ *     http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+package jp.classmethod.sparrow.model;\n+\n+import java.io.IOException;\n+\n+/**\n+ * Created by kunita.fumiko on 2017/03/22.\n+ */\n+\n+public interface Converter {\n+\tString convert(String result) throws IOException;","path":"src/main/java/jp/classmethod/sparrow/model/Converter.java","position":25,"original_position":25,"commit_id":"f14f072d50d66809165c789c83c61903e067af1a","original_commit_id":"f14f072d50d66809165c789c83c61903e067af1a","user":{"login":"dai0304","id":134860,"avatar_url":"https://avatars3.githubusercontent.com/u/134860?v=3","gravatar_id":"","url":"https://api.github.com/users/dai0304","html_url":"https://github.com/dai0304","followers_url":"https://api.github.com/users/dai0304/followers","following_url":"https://api.github.com/users/dai0304/following{/other_user}","gists_url":"https://api.github.com/users/dai0304/gists{/gist_id}","starred_url":"https://api.github.com/users/dai0304/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dai0304/subscriptions","organizations_url":"https://api.github.com/users/dai0304/orgs","repos_url":"https://api.github.com/users/dai0304/repos","events_url":"https://api.github.com/users/dai0304/events{/privacy}","received_events_url":"https://api.github.com/users/dai0304/received_events","type":"User","site_admin":false},"body":"L24（クラス宣言の行）とL25（1つ目のメンバー宣言）の間には空行を入れるように統一しています。\r\n世間一般必ずそうしているというわけではない（空行を入れない、と決めているプロジェクトも恐らくある）ですが、プロジェクト内で何らかの統一はしたほうがいいです。（他のクラスの同様の指摘は省略します。）","created_at":"2017-03-27T16:16:10Z","updated_at":"2017-03-27T16:32:03Z","html_url":"https://github.com/classmethod-sandbox/sparrow/pull/5#discussion_r108213003","pull_request_url":"https://api.github.com/repos/classmethod-sandbox/sparrow/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/classmethod-sandbox/sparrow/pulls/comments/108213003"},"html":{"href":"https://github.com/classmethod-sandbox/sparrow/pull/5#discussion_r108213003"},"pull_request":{"href":"https://api.github.com/repos/classmethod-sandbox/sparrow/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/classmethod-sandbox/sparrow/pulls/5","id":112654439,"html_url":"https://github.com/classmethod-sandbox/sparrow/pull/5","diff_url":"https://github.com/classmethod-sandbox/sparrow/pull/5.diff","patch_url":"https://github.com/classmethod-sandbox/sparrow/pull/5.patch","issue_url":"https://api.github.com/repos/classmethod-sandbox/sparrow/issues/5","number":5,"state":"open","locked":false,"title":"httpリクエストGET/POSTの練習","user":{"login":"kuni02","id":22971740,"avatar_url":"https://avatars0.githubusercontent.com/u/22971740?v=3","gravatar_id":"","url":"https://api.github.com/users/kuni02","html_url":"https://github.com/kuni02","followers_url":"https://api.github.com/users/kuni02/followers","following_url":"https://api.github.com/users/kuni02/following{/other_user}","gists_url":"https://api.github.com/users/kuni02/gists{/gist_id}","starred_url":"https://api.github.com/users/kuni02/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kuni02/subscriptions","organizations_url":"https://api.github.com/users/kuni02/orgs","repos_url":"https://api.github.com/users/kuni02/repos","events_url":"https://api.github.com/users/kuni02/events{/privacy}","received_events_url":"https://api.github.com/users/kuni02/received_events","type":"User","site_admin":false},"body":"# 概要\r\n・GET/POST練習\r\n・httpリクエストからの文字加工処理\r\n<!--\r\n* この pull request の目的を書いてください。\r\n* ほとんどの場合は対応する issue が存在するため、`See #xxx` のように issue ID を記載することで issue と関連づけてください。\r\n-->\r\n\r\n# 内容\r\nhttpリクエストをGET/POSTで取得する練習\r\nhttpリクエストからPOSTでconverterTypeと処理する文字列を受け取って、文字加工処理します\r\n<!--\r\n* 修正の方針や実装であらかじめ指摘を受けそうな箇所について補足してください。\r\n* 迷っている場合は WIP として相談したい旨を書いてください。\r\n-->\r\n","created_at":"2017-03-27T01:10:24Z","updated_at":"2017-03-27T16:32:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"776ae01274cc21d0f3f5dc339189f15661f95c8f","assignee":{"login":"kuni02","id":22971740,"avatar_url":"https://avatars0.githubusercontent.com/u/22971740?v=3","gravatar_id":"","url":"https://api.github.com/users/kuni02","html_url":"https://github.com/kuni02","followers_url":"https://api.github.com/users/kuni02/followers","following_url":"https://api.github.com/users/kuni02/following{/other_user}","gists_url":"https://api.github.com/users/kuni02/gists{/gist_id}","starred_url":"https://api.github.com/users/kuni02/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kuni02/subscriptions","organizations_url":"https://api.github.com/users/kuni02/orgs","repos_url":"https://api.github.com/users/kuni02/repos","events_url":"https://api.github.com/users/kuni02/events{/privacy}","received_events_url":"https://api.github.com/users/kuni02/received_events","type":"User","site_admin":false},"assignees":[{"login":"kuni02","id":22971740,"avatar_url":"https://avatars0.githubusercontent.com/u/22971740?v=3","gravatar_id":"","url":"https://api.github.com/users/kuni02","html_url":"https://github.com/kuni02","followers_url":"https://api.github.com/users/kuni02/followers","following_url":"https://api.github.com/users/kuni02/following{/other_user}","gists_url":"https://api.github.com/users/kuni02/gists{/gist_id}","starred_url":"https://api.github.com/users/kuni02/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kuni02/subscriptions","organizations_url":"https://api.github.com/users/kuni02/orgs","repos_url":"https://api.github.com/users/kuni02/repos","events_url":"https://api.github.com/users/kuni02/events{/privacy}","received_events_url":"https://api.github.com/users/kuni02/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/classmethod-sandbox/sparrow/pulls/5/commits","review_comments_url":"https://api.github.com/repos/classmethod-sandbox/sparrow/pulls/5/comments","review_comment_url":"https://api.github.com/repos/classmethod-sandbox/sparrow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/classmethod-sandbox/sparrow/issues/5/comments","statuses_url":"https://api.github.com/repos/classmethod-sandbox/sparrow/statuses/f14f072d50d66809165c789c83c61903e067af1a","head":{"label":"classmethod-sandbox:feature/training3","ref":"feature/training3","sha":"f14f072d50d66809165c789c83c61903e067af1a","user":{"login":"classmethod-sandbox","id":18157736,"avatar_url":"https://avatars1.githubusercontent.com/u/18157736?v=3","gravatar_id":"","url":"https://api.github.com/users/classmethod-sandbox","html_url":"https://github.com/classmethod-sandbox","followers_url":"https://api.github.com/users/classmethod-sandbox/followers","following_url":"https://api.github.com/users/classmethod-sandbox/following{/other_user}","gists_url":"https://api.github.com/users/classmethod-sandbox/gists{/gist_id}","starred_url":"https://api.github.com/users/classmethod-sandbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/classmethod-sandbox/subscriptions","organizations_url":"https://api.github.com/users/classmethod-sandbox/orgs","repos_url":"https://api.github.com/users/classmethod-sandbox/repos","events_url":"https://api.github.com/users/classmethod-sandbox/events{/privacy}","received_events_url":"https://api.github.com/users/classmethod-sandbox/received_events","type":"Organization","site_admin":false},"repo":{"id":81514328,"name":"sparrow","full_name":"classmethod-sandbox/sparrow","owner":{"login":"classmethod-sandbox","id":18157736,"avatar_url":"https://avatars1.githubusercontent.com/u/18157736?v=3","gravatar_id":"","url":"https://api.github.com/users/classmethod-sandbox","html_url":"https://github.com/classmethod-sandbox","followers_url":"https://api.github.com/users/classmethod-sandbox/followers","following_url":"https://api.github.com/users/classmethod-sandbox/following{/other_user}","gists_url":"https://api.github.com/users/classmethod-sandbox/gists{/gist_id}","starred_url":"https://api.github.com/users/classmethod-sandbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/classmethod-sandbox/subscriptions","organizations_url":"https://api.github.com/users/classmethod-sandbox/orgs","repos_url":"https://api.github.com/users/classmethod-sandbox/repos","events_url":"https://api.github.com/users/classmethod-sandbox/events{/privacy}","received_events_url":"https://api.github.com/users/classmethod-sandbox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/classmethod-sandbox/sparrow","description":null,"fork":false,"url":"https://api.github.com/repos/classmethod-sandbox/sparrow","forks_url":"https://api.github.com/repos/classmethod-sandbox/sparrow/forks","keys_url":"https://api.github.com/repos/classmethod-sandbox/sparrow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/classmethod-sandbox/sparrow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/classmethod-sandbox/sparrow/teams","hooks_url":"https://api.github.com/repos/classmethod-sandbox/sparrow/hooks","issue_events_url":"https://api.github.com/repos/classmethod-sandbox/sparrow/issues/events{/number}","events_url":"https://api.github.com/repos/classmethod-sandbox/sparrow/events","assignees_url":"https://api.github.com/repos/classmethod-sandbox/sparrow/assignees{/user}","branches_url":"https://api.github.com/repos/classmethod-sandbox/sparrow/branches{/branch}","tags_url":"https://api.github.com/repos/classmethod-sandbox/sparrow/tags","blobs_url":"https://api.github.com/repos/classmethod-sandbox/sparrow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/classmethod-sandbox/sparrow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/classmethod-sandbox/sparrow/git/refs{/sha}","trees_url":"https://api.github.com/repos/classmethod-sandbox/sparrow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/classmethod-sandbox/sparrow/statuses/{sha}","languages_url":"https://api.github.com/repos/classmethod-sandbox/sparrow/languages","stargazers_url":"https://api.github.com/repos/classmethod-sandbox/sparrow/stargazers","contributors_url":"https://api.github.com/repos/classmethod-sandbox/sparrow/contributors","subscribers_url":"https://api.github.com/repos/classmethod-sandbox/sparrow/subscribers","subscription_url":"https://api.github.com/repos/classmethod-sandbox/sparrow/subscription","commits_url":"https://api.github.com/repos/classmethod-sandbox/sparrow/commits{/sha}","git_commits_url":"https://api.github.com/repos/classmethod-sandbox/sparrow/git/commits{/sha}","comments_url":"https://api.github.com/repos/classmethod-sandbox/sparrow/comments{/number}","issue_comment_url":"https://api.github.com/repos/classmethod-sandbox/sparrow/issues/comments{/number}","contents_url":"https://api.github.com/repos/classmethod-sandbox/sparrow/contents/{+path}","compare_url":"https://api.github.com/repos/classmethod-sandbox/sparrow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/classmethod-sandbox/sparrow/merges","archive_url":"https://api.github.com/repos/classmethod-sandbox/sparrow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/classmethod-sandbox/sparrow/downloads","issues_url":"https://api.github.com/repos/classmethod-sandbox/sparrow/issues{/number}","pulls_url":"https://api.github.com/repos/classmethod-sandbox/sparrow/pulls{/number}","milestones_url":"https://api.github.com/repos/classmethod-sandbox/sparrow/milestones{/number}","notifications_url":"https://api.github.com/repos/classmethod-sandbox/sparrow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/classmethod-sandbox/sparrow/labels{/name}","releases_url":"https://api.github.com/repos/classmethod-sandbox/sparrow/releases{/id}","deployments_url":"https://api.github.com/repos/classmethod-sandbox/sparrow/deployments","created_at":"2017-02-10T01:47:48Z","updated_at":"2017-02-13T07:59:35Z","pushed_at":"2017-03-27T15:40:29Z","git_url":"git://github.com/classmethod-sandbox/sparrow.git","ssh_url":"git@github.com:classmethod-sandbox/sparrow.git","clone_url":"https://github.com/classmethod-sandbox/sparrow.git","svn_url":"https://github.com/classmethod-sandbox/sparrow","homepage":null,"size":130,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"base":{"label":"classmethod-sandbox:develop","ref":"develop","sha":"329212f6e78b05fef5c56c9480f892620abd19c0","user":{"login":"classmethod-sandbox","id":18157736,"avatar_url":"https://avatars1.githubusercontent.com/u/18157736?v=3","gravatar_id":"","url":"https://api.github.com/users/classmethod-sandbox","html_url":"https://github.com/classmethod-sandbox","followers_url":"https://api.github.com/users/classmethod-sandbox/followers","following_url":"https://api.github.com/users/classmethod-sandbox/following{/other_user}","gists_url":"https://api.github.com/users/classmethod-sandbox/gists{/gist_id}","starred_url":"https://api.github.com/users/classmethod-sandbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/classmethod-sandbox/subscriptions","organizations_url":"https://api.github.com/users/classmethod-sandbox/orgs","repos_url":"https://api.github.com/users/classmethod-sandbox/repos","events_url":"https://api.github.com/users/classmethod-sandbox/events{/privacy}","received_events_url":"https://api.github.com/users/classmethod-sandbox/received_events","type":"Organization","site_admin":false},"repo":{"id":81514328,"name":"sparrow","full_name":"classmethod-sandbox/sparrow","owner":{"login":"classmethod-sandbox","id":18157736,"avatar_url":"https://avatars1.githubusercontent.com/u/18157736?v=3","gravatar_id":"","url":"https://api.github.com/users/classmethod-sandbox","html_url":"https://github.com/classmethod-sandbox","followers_url":"https://api.github.com/users/classmethod-sandbox/followers","following_url":"https://api.github.com/users/classmethod-sandbox/following{/other_user}","gists_url":"https://api.github.com/users/classmethod-sandbox/gists{/gist_id}","starred_url":"https://api.github.com/users/classmethod-sandbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/classmethod-sandbox/subscriptions","organizations_url":"https://api.github.com/users/classmethod-sandbox/orgs","repos_url":"https://api.github.com/users/classmethod-sandbox/repos","events_url":"https://api.github.com/users/classmethod-sandbox/events{/privacy}","received_events_url":"https://api.github.com/users/classmethod-sandbox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/classmethod-sandbox/sparrow","description":null,"fork":false,"url":"https://api.github.com/repos/classmethod-sandbox/sparrow","forks_url":"https://api.github.com/repos/classmethod-sandbox/sparrow/forks","keys_url":"https://api.github.com/repos/classmethod-sandbox/sparrow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/classmethod-sandbox/sparrow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/classmethod-sandbox/sparrow/teams","hooks_url":"https://api.github.com/repos/classmethod-sandbox/sparrow/hooks","issue_events_url":"https://api.github.com/repos/classmethod-sandbox/sparrow/issues/events{/number}","events_url":"https://api.github.com/repos/classmethod-sandbox/sparrow/events","assignees_url":"https://api.github.com/repos/classmethod-sandbox/sparrow/assignees{/user}","branches_url":"https://api.github.com/repos/classmethod-sandbox/sparrow/branches{/branch}","tags_url":"https://api.github.com/repos/classmethod-sandbox/sparrow/tags","blobs_url":"https://api.github.com/repos/classmethod-sandbox/sparrow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/classmethod-sandbox/sparrow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/classmethod-sandbox/sparrow/git/refs{/sha}","trees_url":"https://api.github.com/repos/classmethod-sandbox/sparrow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/classmethod-sandbox/sparrow/statuses/{sha}","languages_url":"https://api.github.com/repos/classmethod-sandbox/sparrow/languages","stargazers_url":"https://api.github.com/repos/classmethod-sandbox/sparrow/stargazers","contributors_url":"https://api.github.com/repos/classmethod-sandbox/sparrow/contributors","subscribers_url":"https://api.github.com/repos/classmethod-sandbox/sparrow/subscribers","subscription_url":"https://api.github.com/repos/classmethod-sandbox/sparrow/subscription","commits_url":"https://api.github.com/repos/classmethod-sandbox/sparrow/commits{/sha}","git_commits_url":"https://api.github.com/repos/classmethod-sandbox/sparrow/git/commits{/sha}","comments_url":"https://api.github.com/repos/classmethod-sandbox/sparrow/comments{/number}","issue_comment_url":"https://api.github.com/repos/classmethod-sandbox/sparrow/issues/comments{/number}","contents_url":"https://api.github.com/repos/classmethod-sandbox/sparrow/contents/{+path}","compare_url":"https://api.github.com/repos/classmethod-sandbox/sparrow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/classmethod-sandbox/sparrow/merges","archive_url":"https://api.github.com/repos/classmethod-sandbox/sparrow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/classmethod-sandbox/sparrow/downloads","issues_url":"https://api.github.com/repos/classmethod-sandbox/sparrow/issues{/number}","pulls_url":"https://api.github.com/repos/classmethod-sandbox/sparrow/pulls{/number}","milestones_url":"https://api.github.com/repos/classmethod-sandbox/sparrow/milestones{/number}","notifications_url":"https://api.github.com/repos/classmethod-sandbox/sparrow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/classmethod-sandbox/sparrow/labels{/name}","releases_url":"https://api.github.com/repos/classmethod-sandbox/sparrow/releases{/id}","deployments_url":"https://api.github.com/repos/classmethod-sandbox/sparrow/deployments","created_at":"2017-02-10T01:47:48Z","updated_at":"2017-02-13T07:59:35Z","pushed_at":"2017-03-27T15:40:29Z","git_url":"git://github.com/classmethod-sandbox/sparrow.git","ssh_url":"git@github.com:classmethod-sandbox/sparrow.git","clone_url":"https://github.com/classmethod-sandbox/sparrow.git","svn_url":"https://github.com/classmethod-sandbox/sparrow","homepage":null,"size":130,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/classmethod-sandbox/sparrow/pulls/5"},"html":{"href":"https://github.com/classmethod-sandbox/sparrow/pull/5"},"issue":{"href":"https://api.github.com/repos/classmethod-sandbox/sparrow/issues/5"},"comments":{"href":"https://api.github.com/repos/classmethod-sandbox/sparrow/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/classmethod-sandbox/sparrow/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/classmethod-sandbox/sparrow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/classmethod-sandbox/sparrow/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/classmethod-sandbox/sparrow/statuses/f14f072d50d66809165c789c83c61903e067af1a"}}}}
{"actor":{"display_login":"dai0304"}}