{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/18618","repository_url":"https://api.github.com/repos/cms-sw/cmssw","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/18618/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/18618/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/18618/events","html_url":"https://github.com/cms-sw/cmssw/pull/18618","id":227035753,"number":18618,"title":"HCALDQM: fix RecHitTask crash, adc2fC from DB, fix TPTask","user":{"login":"DryRun","id":1634307,"avatar_url":"https://avatars1.githubusercontent.com/u/1634307?v=3","gravatar_id":"","url":"https://api.github.com/users/DryRun","html_url":"https://github.com/DryRun","followers_url":"https://api.github.com/users/DryRun/followers","following_url":"https://api.github.com/users/DryRun/following{/other_user}","gists_url":"https://api.github.com/users/DryRun/gists{/gist_id}","starred_url":"https://api.github.com/users/DryRun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DryRun/subscriptions","organizations_url":"https://api.github.com/users/DryRun/orgs","repos_url":"https://api.github.com/users/DryRun/repos","events_url":"https://api.github.com/users/DryRun/events{/privacy}","received_events_url":"https://api.github.com/users/DryRun/received_events","type":"User","site_admin":false},"labels":[{"id":88653795,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-pending","name":"comparison-pending","color":"fbca04","default":false},{"id":52820549,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/dqm-pending","name":"dqm-pending","color":"fbca04","default":false},{"id":56953091,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04","default":false},{"id":53167770,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"eb6420","default":false},{"id":56131152,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-pending","name":"tests-pending","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/66","html_url":"https://github.com/cms-sw/cmssw/milestone/66","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/66/labels","id":2497352,"number":66,"title":"CMSSW_9_2_X","description":"","creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars0.githubusercontent.com/u/4115138?v=3","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":68,"closed_issues":22,"state":"open","created_at":"2017-05-03T13:18:43Z","updated_at":"2017-05-08T12:51:31Z","due_on":null,"closed_at":null},"comments":0,"created_at":"2017-05-08T12:51:19Z","updated_at":"2017-05-08T12:51:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/18618","html_url":"https://github.com/cms-sw/cmssw/pull/18618","diff_url":"https://github.com/cms-sw/cmssw/pull/18618.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/18618.patch"},"body":"A few updates:\r\n\r\n- Fix crash in RecHitTask exposed by beam splashes. For the plan-1 collapsed RecHits that do not exist in the actual detector, the HcalElectronicsId must not be used. One such case was hidden by an energy cut, so wasn't noticed earlier.\r\n- Take adc2fC conversion from conditions instead of a hard-coded table.\r\n- Integrated a fix for the number of samples in trigger primitive emulation, needed for TPTask to work.\r\n- Add HF dual anode asymmetry plots.\r\n- Smaller fixes: adjustments to axis ranges, ADC vs TDC plot, fix uMNIO crate# in fed2crate map, add HEP17 to local run tasks (LEDTask, PedestalTask, LaserTask)."},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/299857955","html_url":"https://github.com/cms-sw/cmssw/pull/18618#issuecomment-299857955","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/18618","id":299857955,"user":{"login":"cmsbuild","id":4170616,"avatar_url":"https://avatars2.githubusercontent.com/u/4170616?v=3","gravatar_id":"","url":"https://api.github.com/users/cmsbuild","html_url":"https://github.com/cmsbuild","followers_url":"https://api.github.com/users/cmsbuild/followers","following_url":"https://api.github.com/users/cmsbuild/following{/other_user}","gists_url":"https://api.github.com/users/cmsbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/cmsbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmsbuild/subscriptions","organizations_url":"https://api.github.com/users/cmsbuild/orgs","repos_url":"https://api.github.com/users/cmsbuild/repos","events_url":"https://api.github.com/users/cmsbuild/events{/privacy}","received_events_url":"https://api.github.com/users/cmsbuild/received_events","type":"User","site_admin":false},"created_at":"2017-05-08T12:51:37Z","updated_at":"2017-05-08T12:51:37Z","body":"A new Pull Request was created by  @DryRun (David Yu) for master.\n\nIt involves the following packages:\n\nDQM/HcalCommon\nDQM/HcalTasks\nDQM/Integration\n\n\n@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.\n@threus, @batinkov, @deguio this is something you requested to watch as well.\n@davidlange6 you are the release manager for this.\n\ncms-bot commands are listed <a href=\"http://cms-sw.github.io/cms-bot-cmssw-cmds.html\">here</a>\n"}}
{"actor":{"display_login":"cmsbuild"}}