{"action":"created","issue":{"url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/issues/375","repository_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle","labels_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/issues/375/labels{/name}","comments_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/issues/375/comments","events_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/issues/375/events","html_url":"https://github.com/KnpLabs/KnpMenuBundle/issues/375","id":281821804,"number":375,"title":"Quick win - Fixing 3.4 deprecated warning","user":{"login":"stphane","id":1629789,"avatar_url":"https://avatars3.githubusercontent.com/u/1629789?v=4","gravatar_id":"","url":"https://api.github.com/users/stphane","html_url":"https://github.com/stphane","followers_url":"https://api.github.com/users/stphane/followers","following_url":"https://api.github.com/users/stphane/following{/other_user}","gists_url":"https://api.github.com/users/stphane/gists{/gist_id}","starred_url":"https://api.github.com/users/stphane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stphane/subscriptions","organizations_url":"https://api.github.com/users/stphane/orgs","repos_url":"https://api.github.com/users/stphane/repos","events_url":"https://api.github.com/users/stphane/events{/privacy}","received_events_url":"https://api.github.com/users/stphane/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2017-12-13T16:55:02Z","updated_at":"2017-12-19T10:43:49Z","closed_at":null,"author_association":"NONE","body":"Fix [deprecation message](https://github.com/symfony/symfony/blob/020664e1efbf8a81dbcc0f7b9dcbfa9ac58c0ed7/src/Symfony/Component/HttpKernel/Kernel.php#L237) introduced in Symfony 3.4\r\n\r\nMy attempt to push a new branch to issue a new PR was denied and so here might be the tiny change required.\r\n\r\n```\r\n--- a/src/Provider/BuilderAliasProvider.php\r\n+++ b/src/Provider/BuilderAliasProvider.php\r\n@@ -101,7 +101,7 @@ class BuilderAliasProvider implements MenuProviderInterface\r\n             $logs = array();\r\n             $bundles = array();\r\n \r\n-            $allBundles = $this->kernel->getBundle($bundleName, false);\r\n+            $allBundles = $this->kernel->getBundle($bundleName);\r\n \r\n             // In Symfony 4, bundle inheritance is gone, so there is no way to get an array anymore.\r\n\r\n```"},"comment":{"url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/issues/comments/352706972","html_url":"https://github.com/KnpLabs/KnpMenuBundle/issues/375#issuecomment-352706972","issue_url":"https://api.github.com/repos/KnpLabs/KnpMenuBundle/issues/375","id":352706972,"user":{"login":"stof","id":439401,"avatar_url":"https://avatars0.githubusercontent.com/u/439401?v=4","gravatar_id":"","url":"https://api.github.com/users/stof","html_url":"https://github.com/stof","followers_url":"https://api.github.com/users/stof/followers","following_url":"https://api.github.com/users/stof/following{/other_user}","gists_url":"https://api.github.com/users/stof/gists{/gist_id}","starred_url":"https://api.github.com/users/stof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stof/subscriptions","organizations_url":"https://api.github.com/users/stof/orgs","repos_url":"https://api.github.com/users/stof/repos","events_url":"https://api.github.com/users/stof/events{/privacy}","received_events_url":"https://api.github.com/users/stof/received_events","type":"User","site_admin":false},"created_at":"2017-12-19T10:43:49Z","updated_at":"2017-12-19T10:43:49Z","author_association":"COLLABORATOR","body":"@stphane Symfony 3.4 also supports bundle inheritance, even though it is deprecated. So removing this code entirely would be done only when dropping support for SF 3.4 itself too."}}
{"actor":{"display_login":"stof"}}