{"action":"created","comment":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments/103596801","pull_request_review_id":24387318,"id":103596801,"diff_hunk":"@@ -8,15 +8,16 @@\n import homeassistant.components.microsoft_face as mf\n \n from tests.common import (\n-    get_test_home_assistant, assert_setup_component, load_fixture, mock_coro)\n+    get_test_home_assistant_http, assert_setup_component, load_fixture,\n+    mock_coro)\n \n \n class TestMicrosoftFaceDetectSetup(object):\n     \"\"\"Test class for image processing.\"\"\"\n \n     def setup_method(self):\n         \"\"\"Setup things to be run when tests are started.\"\"\"\n-        self.hass = get_test_home_assistant()\n+        self.hass = get_test_home_assistant_http()","path":"tests/components/image_processing/test_microsoft_face_detect.py","position":15,"original_position":15,"commit_id":"b9504c06d0d2a534927dbdff39dd4833aa887fa4","original_commit_id":"b9504c06d0d2a534927dbdff39dd4833aa887fa4","user":{"login":"armills","id":1386547,"avatar_url":"https://avatars1.githubusercontent.com/u/1386547?v=3","gravatar_id":"","url":"https://api.github.com/users/armills","html_url":"https://github.com/armills","followers_url":"https://api.github.com/users/armills/followers","following_url":"https://api.github.com/users/armills/following{/other_user}","gists_url":"https://api.github.com/users/armills/gists{/gist_id}","starred_url":"https://api.github.com/users/armills/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/armills/subscriptions","organizations_url":"https://api.github.com/users/armills/orgs","repos_url":"https://api.github.com/users/armills/repos","events_url":"https://api.github.com/users/armills/events{/privacy}","received_events_url":"https://api.github.com/users/armills/received_events","type":"User","site_admin":false},"body":"So I've started down this road, and I'm starting to think it's not worth the distinction. Some of these aren't using network functions, but they do use other portions initialized by the http component, such as the base_url or the iframe test uses the FINGERPRINTS, etc.\r\n\r\nI think even if we got it right here, it would be more confusing when people implement future tests, and would probably end up messed up.","created_at":"2017-03-01T02:01:03Z","updated_at":"2017-03-01T02:01:04Z","html_url":"https://github.com/home-assistant/home-assistant/pull/6232#discussion_r103596801","pull_request_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/6232","_links":{"self":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments/103596801"},"html":{"href":"https://github.com/home-assistant/home-assistant/pull/6232#discussion_r103596801"},"pull_request":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/6232"}}},"pull_request":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/6232","id":107990866,"html_url":"https://github.com/home-assistant/home-assistant/pull/6232","diff_url":"https://github.com/home-assistant/home-assistant/pull/6232.diff","patch_url":"https://github.com/home-assistant/home-assistant/pull/6232.patch","issue_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/6232","number":6232,"state":"open","locked":false,"title":"Use dynamic port allocation for tests","user":{"login":"armills","id":1386547,"avatar_url":"https://avatars1.githubusercontent.com/u/1386547?v=3","gravatar_id":"","url":"https://api.github.com/users/armills","html_url":"https://github.com/armills","followers_url":"https://api.github.com/users/armills/followers","following_url":"https://api.github.com/users/armills/following{/other_user}","gists_url":"https://api.github.com/users/armills/gists{/gist_id}","starred_url":"https://api.github.com/users/armills/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/armills/subscriptions","organizations_url":"https://api.github.com/users/armills/orgs","repos_url":"https://api.github.com/users/armills/repos","events_url":"https://api.github.com/users/armills/events{/privacy}","received_events_url":"https://api.github.com/users/armills/received_events","type":"User","site_admin":false},"body":"## Description:\r\nThis PR changes the test system to use dynamic port assignment for the http component. By passing 0 as the port, the OS will assign an unused port from the dynamic port range.\r\n\r\nIn order to accomplish this, the socket is bound early in the HomeAssistantWSGI constructor, and then passed to the event loop create_server. This also has the nice side-effect of allowing us to know ahead of time in component setup if the port is invalid.\r\n\r\nThe end goal is to move towards parallelization of the test system. This allows each test to get a unique port assignment without requiring coordination.","created_at":"2017-02-26T05:09:46Z","updated_at":"2017-03-01T02:01:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"92d285d1defca7d0b8a49def7da534bc2b95560c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/6232/commits","review_comments_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/6232/comments","review_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments{/number}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/6232/comments","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/b9504c06d0d2a534927dbdff39dd4833aa887fa4","head":{"label":"armills:dynamic-test-ports","ref":"dynamic-test-ports","sha":"b9504c06d0d2a534927dbdff39dd4833aa887fa4","user":{"login":"armills","id":1386547,"avatar_url":"https://avatars1.githubusercontent.com/u/1386547?v=3","gravatar_id":"","url":"https://api.github.com/users/armills","html_url":"https://github.com/armills","followers_url":"https://api.github.com/users/armills/followers","following_url":"https://api.github.com/users/armills/following{/other_user}","gists_url":"https://api.github.com/users/armills/gists{/gist_id}","starred_url":"https://api.github.com/users/armills/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/armills/subscriptions","organizations_url":"https://api.github.com/users/armills/orgs","repos_url":"https://api.github.com/users/armills/repos","events_url":"https://api.github.com/users/armills/events{/privacy}","received_events_url":"https://api.github.com/users/armills/received_events","type":"User","site_admin":false},"repo":{"id":60287084,"name":"home-assistant","full_name":"armills/home-assistant","owner":{"login":"armills","id":1386547,"avatar_url":"https://avatars1.githubusercontent.com/u/1386547?v=3","gravatar_id":"","url":"https://api.github.com/users/armills","html_url":"https://github.com/armills","followers_url":"https://api.github.com/users/armills/followers","following_url":"https://api.github.com/users/armills/following{/other_user}","gists_url":"https://api.github.com/users/armills/gists{/gist_id}","starred_url":"https://api.github.com/users/armills/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/armills/subscriptions","organizations_url":"https://api.github.com/users/armills/orgs","repos_url":"https://api.github.com/users/armills/repos","events_url":"https://api.github.com/users/armills/events{/privacy}","received_events_url":"https://api.github.com/users/armills/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/armills/home-assistant","description":":house_with_garden: Open-source home automation platform running on Python 3","fork":true,"url":"https://api.github.com/repos/armills/home-assistant","forks_url":"https://api.github.com/repos/armills/home-assistant/forks","keys_url":"https://api.github.com/repos/armills/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/armills/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/armills/home-assistant/teams","hooks_url":"https://api.github.com/repos/armills/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/armills/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/armills/home-assistant/events","assignees_url":"https://api.github.com/repos/armills/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/armills/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/armills/home-assistant/tags","blobs_url":"https://api.github.com/repos/armills/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/armills/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/armills/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/armills/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/armills/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/armills/home-assistant/languages","stargazers_url":"https://api.github.com/repos/armills/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/armills/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/armills/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/armills/home-assistant/subscription","commits_url":"https://api.github.com/repos/armills/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/armills/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/armills/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/armills/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/armills/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/armills/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/armills/home-assistant/merges","archive_url":"https://api.github.com/repos/armills/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/armills/home-assistant/downloads","issues_url":"https://api.github.com/repos/armills/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/armills/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/armills/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/armills/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/armills/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/armills/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/armills/home-assistant/deployments","created_at":"2016-06-02T18:17:19Z","updated_at":"2016-06-02T18:17:21Z","pushed_at":"2017-02-27T18:43:21Z","git_url":"git://github.com/armills/home-assistant.git","ssh_url":"git@github.com:armills/home-assistant.git","clone_url":"https://github.com/armills/home-assistant.git","svn_url":"https://github.com/armills/home-assistant","homepage":"https://home-assistant.io","size":93184,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"home-assistant:dev","ref":"dev","sha":"31ddcc6278f1439f383a6672bd3a9078d4892904","user":{"login":"home-assistant","id":13844975,"avatar_url":"https://avatars0.githubusercontent.com/u/13844975?v=3","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"repo":{"id":12888993,"name":"home-assistant","full_name":"home-assistant/home-assistant","owner":{"login":"home-assistant","id":13844975,"avatar_url":"https://avatars0.githubusercontent.com/u/13844975?v=3","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/home-assistant/home-assistant","description":":house_with_garden: Open-source home automation platform running on Python 3","fork":false,"url":"https://api.github.com/repos/home-assistant/home-assistant","forks_url":"https://api.github.com/repos/home-assistant/home-assistant/forks","keys_url":"https://api.github.com/repos/home-assistant/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/home-assistant/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/home-assistant/home-assistant/teams","hooks_url":"https://api.github.com/repos/home-assistant/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/home-assistant/home-assistant/events","assignees_url":"https://api.github.com/repos/home-assistant/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/home-assistant/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/home-assistant/home-assistant/tags","blobs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/home-assistant/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/home-assistant/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/home-assistant/home-assistant/languages","stargazers_url":"https://api.github.com/repos/home-assistant/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/home-assistant/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/home-assistant/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/home-assistant/home-assistant/subscription","commits_url":"https://api.github.com/repos/home-assistant/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/home-assistant/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/home-assistant/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/home-assistant/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/home-assistant/home-assistant/merges","archive_url":"https://api.github.com/repos/home-assistant/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/home-assistant/home-assistant/downloads","issues_url":"https://api.github.com/repos/home-assistant/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/home-assistant/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/home-assistant/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/home-assistant/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/home-assistant/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/home-assistant/home-assistant/deployments","created_at":"2013-09-17T07:29:48Z","updated_at":"2017-03-01T01:46:07Z","pushed_at":"2017-03-01T01:04:56Z","git_url":"git://github.com/home-assistant/home-assistant.git","ssh_url":"git@github.com:home-assistant/home-assistant.git","clone_url":"https://github.com/home-assistant/home-assistant.git","svn_url":"https://github.com/home-assistant/home-assistant","homepage":"https://home-assistant.io","size":53720,"stargazers_count":6009,"watchers_count":6009,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1732,"mirror_url":null,"open_issues_count":485,"forks":1732,"open_issues":485,"watchers":6009,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/6232"},"html":{"href":"https://github.com/home-assistant/home-assistant/pull/6232"},"issue":{"href":"https://api.github.com/repos/home-assistant/home-assistant/issues/6232"},"comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant/issues/6232/comments"},"review_comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/6232/comments"},"review_comment":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/6232/commits"},"statuses":{"href":"https://api.github.com/repos/home-assistant/home-assistant/statuses/b9504c06d0d2a534927dbdff39dd4833aa887fa4"}}}}
{"actor":{"display_login":"armills"}}