{"action":"created","comment":{"url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls/comments/119836308","pull_request_review_id":41752719,"id":119836308,"diff_hunk":"@@ -475,25 +473,24 @@ function JournalController(Journal, Sorting, Grouping,\n   }\n \n   vm.toggleTransactionGroup = function toggleTransactionGroup() {\n-    if (vm.grouping.getCurrentGroupingColumn()) {\n-      vm.grouping.removeGrouping('trans_id');\n-\n-      // save grids state to keep track of this change\n-      state.saveGridState(false);\n-\n-      // @FIXME temporary cahced variable to track the grouped state - this should be encapsulated in a component\n-      vm.grouped = cache.grouped = false;\n-    } else {\n-      vm.grouping.changeGrouping('trans_id');\n-\n-      // save grids state to keep track of this change\n-      state.saveGridState(false);\n+    var transactionColumnKey = 'trans_id';\n \n-      // @FIXME temporary cahced variable to track the grouped state - this should be encapsulated in a component\n-      vm.grouped = cache.grouped = true;\n+    // column grouping is permenantly saved if the user saves the current grid state\n+    if (vm.grouping.getCurrentGroupingColumn()) {","path":"client/src/modules/journal/journal.js","position":37,"original_position":37,"commit_id":"2eaad2908e7300877bb4a0b422a800600cc71fa4","original_commit_id":"2eaad2908e7300877bb4a0b422a800600cc71fa4","user":{"login":"jniles","id":896472,"avatar_url":"https://avatars3.githubusercontent.com/u/896472?v=3","gravatar_id":"","url":"https://api.github.com/users/jniles","html_url":"https://github.com/jniles","followers_url":"https://api.github.com/users/jniles/followers","following_url":"https://api.github.com/users/jniles/following{/other_user}","gists_url":"https://api.github.com/users/jniles/gists{/gist_id}","starred_url":"https://api.github.com/users/jniles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jniles/subscriptions","organizations_url":"https://api.github.com/users/jniles/orgs","repos_url":"https://api.github.com/users/jniles/repos","events_url":"https://api.github.com/users/jniles/events{/privacy}","received_events_url":"https://api.github.com/users/jniles/received_events","type":"User","site_admin":false},"body":"Nice cleanup!","created_at":"2017-06-02T11:35:22Z","updated_at":"2017-06-02T11:35:59Z","html_url":"https://github.com/IMA-WorldHealth/bhima-2.X/pull/1753#discussion_r119836308","pull_request_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls/1753","_links":{"self":{"href":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls/comments/119836308"},"html":{"href":"https://github.com/IMA-WorldHealth/bhima-2.X/pull/1753#discussion_r119836308"},"pull_request":{"href":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls/1753"}}},"pull_request":{"url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls/1753","id":123696078,"html_url":"https://github.com/IMA-WorldHealth/bhima-2.X/pull/1753","diff_url":"https://github.com/IMA-WorldHealth/bhima-2.X/pull/1753.diff","patch_url":"https://github.com/IMA-WorldHealth/bhima-2.X/pull/1753.patch","issue_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/issues/1753","number":1753,"state":"open","locked":false,"title":"refactor(grids): Remove implicit grid save state","user":{"login":"sfount","id":2844572,"avatar_url":"https://avatars0.githubusercontent.com/u/2844572?v=3","gravatar_id":"","url":"https://api.github.com/users/sfount","html_url":"https://github.com/sfount","followers_url":"https://api.github.com/users/sfount/followers","following_url":"https://api.github.com/users/sfount/following{/other_user}","gists_url":"https://api.github.com/users/sfount/gists{/gist_id}","starred_url":"https://api.github.com/users/sfount/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfount/subscriptions","organizations_url":"https://api.github.com/users/sfount/orgs","repos_url":"https://api.github.com/users/sfount/repos","events_url":"https://api.github.com/users/sfount/events{/privacy}","received_events_url":"https://api.github.com/users/sfount/received_events","type":"User","site_admin":false},"body":"This commit removes the implicit save state from the Journal grid,\r\ncalled when the columns are changed and groups are updated. This\r\nimproves the UX by ensuring the grid settings will only ever be cached\r\nif the user has selected to save the grid state.\r\n\r\nIt also updates the grouping utility to check if the grid is in a\r\ngrouped state. This should be optimised in the future.\r\n\r\nContributes to https://github.com/IMA-WorldHealth/bhima-2.X/issues/1738\r\n","created_at":"2017-06-02T11:20:19Z","updated_at":"2017-06-02T11:35:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"605735a0872a0e738d25112a332b8c14f75f3e6a","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls/1753/commits","review_comments_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls/1753/comments","review_comment_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls/comments{/number}","comments_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/issues/1753/comments","statuses_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/statuses/2eaad2908e7300877bb4a0b422a800600cc71fa4","head":{"label":"sfount:refactor-grid-save-state","ref":"refactor-grid-save-state","sha":"2eaad2908e7300877bb4a0b422a800600cc71fa4","user":{"login":"sfount","id":2844572,"avatar_url":"https://avatars0.githubusercontent.com/u/2844572?v=3","gravatar_id":"","url":"https://api.github.com/users/sfount","html_url":"https://github.com/sfount","followers_url":"https://api.github.com/users/sfount/followers","following_url":"https://api.github.com/users/sfount/following{/other_user}","gists_url":"https://api.github.com/users/sfount/gists{/gist_id}","starred_url":"https://api.github.com/users/sfount/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfount/subscriptions","organizations_url":"https://api.github.com/users/sfount/orgs","repos_url":"https://api.github.com/users/sfount/repos","events_url":"https://api.github.com/users/sfount/events{/privacy}","received_events_url":"https://api.github.com/users/sfount/received_events","type":"User","site_admin":false},"repo":{"id":49060358,"name":"bhima-2.X","full_name":"sfount/bhima-2.X","owner":{"login":"sfount","id":2844572,"avatar_url":"https://avatars0.githubusercontent.com/u/2844572?v=3","gravatar_id":"","url":"https://api.github.com/users/sfount","html_url":"https://github.com/sfount","followers_url":"https://api.github.com/users/sfount/followers","following_url":"https://api.github.com/users/sfount/following{/other_user}","gists_url":"https://api.github.com/users/sfount/gists{/gist_id}","starred_url":"https://api.github.com/users/sfount/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfount/subscriptions","organizations_url":"https://api.github.com/users/sfount/orgs","repos_url":"https://api.github.com/users/sfount/repos","events_url":"https://api.github.com/users/sfount/events{/privacy}","received_events_url":"https://api.github.com/users/sfount/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sfount/bhima-2.X","description":"A fresh start for bhima to remove large commits","fork":true,"url":"https://api.github.com/repos/sfount/bhima-2.X","forks_url":"https://api.github.com/repos/sfount/bhima-2.X/forks","keys_url":"https://api.github.com/repos/sfount/bhima-2.X/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sfount/bhima-2.X/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sfount/bhima-2.X/teams","hooks_url":"https://api.github.com/repos/sfount/bhima-2.X/hooks","issue_events_url":"https://api.github.com/repos/sfount/bhima-2.X/issues/events{/number}","events_url":"https://api.github.com/repos/sfount/bhima-2.X/events","assignees_url":"https://api.github.com/repos/sfount/bhima-2.X/assignees{/user}","branches_url":"https://api.github.com/repos/sfount/bhima-2.X/branches{/branch}","tags_url":"https://api.github.com/repos/sfount/bhima-2.X/tags","blobs_url":"https://api.github.com/repos/sfount/bhima-2.X/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sfount/bhima-2.X/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sfount/bhima-2.X/git/refs{/sha}","trees_url":"https://api.github.com/repos/sfount/bhima-2.X/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sfount/bhima-2.X/statuses/{sha}","languages_url":"https://api.github.com/repos/sfount/bhima-2.X/languages","stargazers_url":"https://api.github.com/repos/sfount/bhima-2.X/stargazers","contributors_url":"https://api.github.com/repos/sfount/bhima-2.X/contributors","subscribers_url":"https://api.github.com/repos/sfount/bhima-2.X/subscribers","subscription_url":"https://api.github.com/repos/sfount/bhima-2.X/subscription","commits_url":"https://api.github.com/repos/sfount/bhima-2.X/commits{/sha}","git_commits_url":"https://api.github.com/repos/sfount/bhima-2.X/git/commits{/sha}","comments_url":"https://api.github.com/repos/sfount/bhima-2.X/comments{/number}","issue_comment_url":"https://api.github.com/repos/sfount/bhima-2.X/issues/comments{/number}","contents_url":"https://api.github.com/repos/sfount/bhima-2.X/contents/{+path}","compare_url":"https://api.github.com/repos/sfount/bhima-2.X/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sfount/bhima-2.X/merges","archive_url":"https://api.github.com/repos/sfount/bhima-2.X/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sfount/bhima-2.X/downloads","issues_url":"https://api.github.com/repos/sfount/bhima-2.X/issues{/number}","pulls_url":"https://api.github.com/repos/sfount/bhima-2.X/pulls{/number}","milestones_url":"https://api.github.com/repos/sfount/bhima-2.X/milestones{/number}","notifications_url":"https://api.github.com/repos/sfount/bhima-2.X/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sfount/bhima-2.X/labels{/name}","releases_url":"https://api.github.com/repos/sfount/bhima-2.X/releases{/id}","deployments_url":"https://api.github.com/repos/sfount/bhima-2.X/deployments","created_at":"2016-01-05T10:55:13Z","updated_at":"2016-03-27T15:46:19Z","pushed_at":"2017-06-02T11:16:52Z","git_url":"git://github.com/sfount/bhima-2.X.git","ssh_url":"git@github.com:sfount/bhima-2.X.git","clone_url":"https://github.com/sfount/bhima-2.X.git","svn_url":"https://github.com/sfount/bhima-2.X","homepage":null,"size":9640,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"IMA-WorldHealth:master","ref":"master","sha":"76c0f0b865302ecda046742d8855ba1fb0dc9411","user":{"login":"IMA-WorldHealth","id":5330583,"avatar_url":"https://avatars2.githubusercontent.com/u/5330583?v=3","gravatar_id":"","url":"https://api.github.com/users/IMA-WorldHealth","html_url":"https://github.com/IMA-WorldHealth","followers_url":"https://api.github.com/users/IMA-WorldHealth/followers","following_url":"https://api.github.com/users/IMA-WorldHealth/following{/other_user}","gists_url":"https://api.github.com/users/IMA-WorldHealth/gists{/gist_id}","starred_url":"https://api.github.com/users/IMA-WorldHealth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IMA-WorldHealth/subscriptions","organizations_url":"https://api.github.com/users/IMA-WorldHealth/orgs","repos_url":"https://api.github.com/users/IMA-WorldHealth/repos","events_url":"https://api.github.com/users/IMA-WorldHealth/events{/privacy}","received_events_url":"https://api.github.com/users/IMA-WorldHealth/received_events","type":"Organization","site_admin":false},"repo":{"id":49052669,"name":"bhima-2.X","full_name":"IMA-WorldHealth/bhima-2.X","owner":{"login":"IMA-WorldHealth","id":5330583,"avatar_url":"https://avatars2.githubusercontent.com/u/5330583?v=3","gravatar_id":"","url":"https://api.github.com/users/IMA-WorldHealth","html_url":"https://github.com/IMA-WorldHealth","followers_url":"https://api.github.com/users/IMA-WorldHealth/followers","following_url":"https://api.github.com/users/IMA-WorldHealth/following{/other_user}","gists_url":"https://api.github.com/users/IMA-WorldHealth/gists{/gist_id}","starred_url":"https://api.github.com/users/IMA-WorldHealth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IMA-WorldHealth/subscriptions","organizations_url":"https://api.github.com/users/IMA-WorldHealth/orgs","repos_url":"https://api.github.com/users/IMA-WorldHealth/repos","events_url":"https://api.github.com/users/IMA-WorldHealth/events{/privacy}","received_events_url":"https://api.github.com/users/IMA-WorldHealth/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/IMA-WorldHealth/bhima-2.X","description":"A hospital information management application for rural Congolese hospitals","fork":false,"url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X","forks_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/forks","keys_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/teams","hooks_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/hooks","issue_events_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/issues/events{/number}","events_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/events","assignees_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/assignees{/user}","branches_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/branches{/branch}","tags_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/tags","blobs_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/git/refs{/sha}","trees_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/statuses/{sha}","languages_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/languages","stargazers_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/stargazers","contributors_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/contributors","subscribers_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/subscribers","subscription_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/subscription","commits_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/commits{/sha}","git_commits_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/git/commits{/sha}","comments_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/comments{/number}","issue_comment_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/issues/comments{/number}","contents_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/contents/{+path}","compare_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/merges","archive_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/downloads","issues_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/issues{/number}","pulls_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls{/number}","milestones_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/milestones{/number}","notifications_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/labels{/name}","releases_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/releases{/id}","deployments_url":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/deployments","created_at":"2016-01-05T08:30:30Z","updated_at":"2017-06-02T01:59:18Z","pushed_at":"2017-06-02T11:26:38Z","git_url":"git://github.com/IMA-WorldHealth/bhima-2.X.git","ssh_url":"git@github.com:IMA-WorldHealth/bhima-2.X.git","clone_url":"https://github.com/IMA-WorldHealth/bhima-2.X.git","svn_url":"https://github.com/IMA-WorldHealth/bhima-2.X","homepage":"","size":9717,"stargazers_count":40,"watchers_count":40,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":281,"forks":21,"open_issues":281,"watchers":40,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls/1753"},"html":{"href":"https://github.com/IMA-WorldHealth/bhima-2.X/pull/1753"},"issue":{"href":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/issues/1753"},"comments":{"href":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/issues/1753/comments"},"review_comments":{"href":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls/1753/comments"},"review_comment":{"href":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/pulls/1753/commits"},"statuses":{"href":"https://api.github.com/repos/IMA-WorldHealth/bhima-2.X/statuses/2eaad2908e7300877bb4a0b422a800600cc71fa4"}}}}
{"actor":{"display_login":"jniles"}}