{"action":"created","comment":{"url":"https://api.github.com/repos/Shopify/shipit-engine/pulls/comments/100108182","pull_request_review_id":20803798,"id":100108182,"diff_hunk":"@@ -171,6 +172,11 @@ def github_pull_request=(github_pull_request)\n       self.head = find_or_create_commit_from_github_by_sha!(github_pull_request.head.sha, detached: true)\n     end\n \n+    def merge_message\n+      return title unless merge_requested_by\n+      \"#{title}\\n\\nMerge-Requested-By: #{merge_requested_by.login}\\n\"","path":"app/models/shipit/pull_request.rb","position":23,"original_position":23,"commit_id":"afe1441abd0e4b6d80da1bf1d375a43e65907ea2","original_commit_id":"afe1441abd0e4b6d80da1bf1d375a43e65907ea2","user":{"login":"wvanbergen","id":15870,"avatar_url":"https://avatars.githubusercontent.com/u/15870?v=3","gravatar_id":"","url":"https://api.github.com/users/wvanbergen","html_url":"https://github.com/wvanbergen","followers_url":"https://api.github.com/users/wvanbergen/followers","following_url":"https://api.github.com/users/wvanbergen/following{/other_user}","gists_url":"https://api.github.com/users/wvanbergen/gists{/gist_id}","starred_url":"https://api.github.com/users/wvanbergen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wvanbergen/subscriptions","organizations_url":"https://api.github.com/users/wvanbergen/orgs","repos_url":"https://api.github.com/users/wvanbergen/repos","events_url":"https://api.github.com/users/wvanbergen/events{/privacy}","received_events_url":"https://api.github.com/users/wvanbergen/received_events","type":"User","site_admin":false},"body":"Any reason why we can't use spaces instead of `-` here?","created_at":"2017-02-08T16:31:05Z","updated_at":"2017-02-08T16:32:10Z","html_url":"https://github.com/Shopify/shipit-engine/pull/645#discussion_r100108182","pull_request_url":"https://api.github.com/repos/Shopify/shipit-engine/pulls/645","_links":{"self":{"href":"https://api.github.com/repos/Shopify/shipit-engine/pulls/comments/100108182"},"html":{"href":"https://github.com/Shopify/shipit-engine/pull/645#discussion_r100108182"},"pull_request":{"href":"https://api.github.com/repos/Shopify/shipit-engine/pulls/645"}}},"pull_request":{"url":"https://api.github.com/repos/Shopify/shipit-engine/pulls/645","id":105251047,"html_url":"https://github.com/Shopify/shipit-engine/pull/645","diff_url":"https://github.com/Shopify/shipit-engine/pull/645.diff","patch_url":"https://github.com/Shopify/shipit-engine/pull/645.patch","issue_url":"https://api.github.com/repos/Shopify/shipit-engine/issues/645","number":645,"state":"open","locked":false,"title":"Link merge commits and pull requests together","user":{"login":"casperisfine","id":19192189,"avatar_url":"https://avatars.githubusercontent.com/u/19192189?v=3","gravatar_id":"","url":"https://api.github.com/users/casperisfine","html_url":"https://github.com/casperisfine","followers_url":"https://api.github.com/users/casperisfine/followers","following_url":"https://api.github.com/users/casperisfine/following{/other_user}","gists_url":"https://api.github.com/users/casperisfine/gists{/gist_id}","starred_url":"https://api.github.com/users/casperisfine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/casperisfine/subscriptions","organizations_url":"https://api.github.com/users/casperisfine/orgs","repos_url":"https://api.github.com/users/casperisfine/repos","events_url":"https://api.github.com/users/casperisfine/events{/privacy}","received_events_url":"https://api.github.com/users/casperisfine/received_events","type":"User","site_admin":false},"body":"Followup to: https://github.com/Shopify/shipit-engine/pull/643\r\n\r\nOne of the main drawback of the merge queue is that now the merge commits are authored by the Shipit user. In itself it's not a big deal, as it's the reality, but it's quite a breaking change for the Shipit API and the Shipit Hooks.\r\n\r\nSo this makes a few changes for usability:\r\n  - The merge commit will contain a `Merge-Requested-By: @login` field for traceability\r\n  - If the merge commit is identified and match a known pull request, the merge commit will be recorded in Shipit as if it was authored by the merge requester.\r\n\r\nAnother thing we could eventually do is that Shipit could do the merge on the behalf of the requester. This isn't guaranteed to work as the requester might not have sufficient permissions.\r\n\r\n@Shopify/pipeline @etiennebarrie thoughts ?","created_at":"2017-02-08T16:22:34Z","updated_at":"2017-02-08T16:32:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"98c5727a773e5bd5024b337b3c503e2dae67074b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Shopify/shipit-engine/pulls/645/commits","review_comments_url":"https://api.github.com/repos/Shopify/shipit-engine/pulls/645/comments","review_comment_url":"https://api.github.com/repos/Shopify/shipit-engine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Shopify/shipit-engine/issues/645/comments","statuses_url":"https://api.github.com/repos/Shopify/shipit-engine/statuses/afe1441abd0e4b6d80da1bf1d375a43e65907ea2","head":{"label":"Shopify:merge-queue-link-prs-and-merge-commits","ref":"merge-queue-link-prs-and-merge-commits","sha":"afe1441abd0e4b6d80da1bf1d375a43e65907ea2","user":{"login":"Shopify","id":8085,"avatar_url":"https://avatars.githubusercontent.com/u/8085?v=3","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"repo":{"id":17228890,"name":"shipit-engine","full_name":"Shopify/shipit-engine","owner":{"login":"Shopify","id":8085,"avatar_url":"https://avatars.githubusercontent.com/u/8085?v=3","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Shopify/shipit-engine","description":"Deployment coordination","fork":false,"url":"https://api.github.com/repos/Shopify/shipit-engine","forks_url":"https://api.github.com/repos/Shopify/shipit-engine/forks","keys_url":"https://api.github.com/repos/Shopify/shipit-engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shopify/shipit-engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shopify/shipit-engine/teams","hooks_url":"https://api.github.com/repos/Shopify/shipit-engine/hooks","issue_events_url":"https://api.github.com/repos/Shopify/shipit-engine/issues/events{/number}","events_url":"https://api.github.com/repos/Shopify/shipit-engine/events","assignees_url":"https://api.github.com/repos/Shopify/shipit-engine/assignees{/user}","branches_url":"https://api.github.com/repos/Shopify/shipit-engine/branches{/branch}","tags_url":"https://api.github.com/repos/Shopify/shipit-engine/tags","blobs_url":"https://api.github.com/repos/Shopify/shipit-engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shopify/shipit-engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shopify/shipit-engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shopify/shipit-engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shopify/shipit-engine/statuses/{sha}","languages_url":"https://api.github.com/repos/Shopify/shipit-engine/languages","stargazers_url":"https://api.github.com/repos/Shopify/shipit-engine/stargazers","contributors_url":"https://api.github.com/repos/Shopify/shipit-engine/contributors","subscribers_url":"https://api.github.com/repos/Shopify/shipit-engine/subscribers","subscription_url":"https://api.github.com/repos/Shopify/shipit-engine/subscription","commits_url":"https://api.github.com/repos/Shopify/shipit-engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shopify/shipit-engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shopify/shipit-engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shopify/shipit-engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shopify/shipit-engine/contents/{+path}","compare_url":"https://api.github.com/repos/Shopify/shipit-engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shopify/shipit-engine/merges","archive_url":"https://api.github.com/repos/Shopify/shipit-engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shopify/shipit-engine/downloads","issues_url":"https://api.github.com/repos/Shopify/shipit-engine/issues{/number}","pulls_url":"https://api.github.com/repos/Shopify/shipit-engine/pulls{/number}","milestones_url":"https://api.github.com/repos/Shopify/shipit-engine/milestones{/number}","notifications_url":"https://api.github.com/repos/Shopify/shipit-engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shopify/shipit-engine/labels{/name}","releases_url":"https://api.github.com/repos/Shopify/shipit-engine/releases{/id}","deployments_url":"https://api.github.com/repos/Shopify/shipit-engine/deployments","created_at":"2014-02-26T22:59:57Z","updated_at":"2017-02-06T15:21:01Z","pushed_at":"2017-02-08T16:27:24Z","git_url":"git://github.com/Shopify/shipit-engine.git","ssh_url":"git@github.com:Shopify/shipit-engine.git","clone_url":"https://github.com/Shopify/shipit-engine.git","svn_url":"https://github.com/Shopify/shipit-engine","homepage":"https://www.shopify.com/technology/34281221-introducing-shipit","size":2210,"stargazers_count":490,"watchers_count":490,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":37,"mirror_url":null,"open_issues_count":36,"forks":37,"open_issues":36,"watchers":490,"default_branch":"master"}},"base":{"label":"Shopify:master","ref":"master","sha":"b027f51bfb261ac4e989848644cb16fe01750d34","user":{"login":"Shopify","id":8085,"avatar_url":"https://avatars.githubusercontent.com/u/8085?v=3","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"repo":{"id":17228890,"name":"shipit-engine","full_name":"Shopify/shipit-engine","owner":{"login":"Shopify","id":8085,"avatar_url":"https://avatars.githubusercontent.com/u/8085?v=3","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Shopify/shipit-engine","description":"Deployment coordination","fork":false,"url":"https://api.github.com/repos/Shopify/shipit-engine","forks_url":"https://api.github.com/repos/Shopify/shipit-engine/forks","keys_url":"https://api.github.com/repos/Shopify/shipit-engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shopify/shipit-engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shopify/shipit-engine/teams","hooks_url":"https://api.github.com/repos/Shopify/shipit-engine/hooks","issue_events_url":"https://api.github.com/repos/Shopify/shipit-engine/issues/events{/number}","events_url":"https://api.github.com/repos/Shopify/shipit-engine/events","assignees_url":"https://api.github.com/repos/Shopify/shipit-engine/assignees{/user}","branches_url":"https://api.github.com/repos/Shopify/shipit-engine/branches{/branch}","tags_url":"https://api.github.com/repos/Shopify/shipit-engine/tags","blobs_url":"https://api.github.com/repos/Shopify/shipit-engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shopify/shipit-engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shopify/shipit-engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shopify/shipit-engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shopify/shipit-engine/statuses/{sha}","languages_url":"https://api.github.com/repos/Shopify/shipit-engine/languages","stargazers_url":"https://api.github.com/repos/Shopify/shipit-engine/stargazers","contributors_url":"https://api.github.com/repos/Shopify/shipit-engine/contributors","subscribers_url":"https://api.github.com/repos/Shopify/shipit-engine/subscribers","subscription_url":"https://api.github.com/repos/Shopify/shipit-engine/subscription","commits_url":"https://api.github.com/repos/Shopify/shipit-engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shopify/shipit-engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shopify/shipit-engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shopify/shipit-engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shopify/shipit-engine/contents/{+path}","compare_url":"https://api.github.com/repos/Shopify/shipit-engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shopify/shipit-engine/merges","archive_url":"https://api.github.com/repos/Shopify/shipit-engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shopify/shipit-engine/downloads","issues_url":"https://api.github.com/repos/Shopify/shipit-engine/issues{/number}","pulls_url":"https://api.github.com/repos/Shopify/shipit-engine/pulls{/number}","milestones_url":"https://api.github.com/repos/Shopify/shipit-engine/milestones{/number}","notifications_url":"https://api.github.com/repos/Shopify/shipit-engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shopify/shipit-engine/labels{/name}","releases_url":"https://api.github.com/repos/Shopify/shipit-engine/releases{/id}","deployments_url":"https://api.github.com/repos/Shopify/shipit-engine/deployments","created_at":"2014-02-26T22:59:57Z","updated_at":"2017-02-06T15:21:01Z","pushed_at":"2017-02-08T16:27:24Z","git_url":"git://github.com/Shopify/shipit-engine.git","ssh_url":"git@github.com:Shopify/shipit-engine.git","clone_url":"https://github.com/Shopify/shipit-engine.git","svn_url":"https://github.com/Shopify/shipit-engine","homepage":"https://www.shopify.com/technology/34281221-introducing-shipit","size":2210,"stargazers_count":490,"watchers_count":490,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":37,"mirror_url":null,"open_issues_count":36,"forks":37,"open_issues":36,"watchers":490,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Shopify/shipit-engine/pulls/645"},"html":{"href":"https://github.com/Shopify/shipit-engine/pull/645"},"issue":{"href":"https://api.github.com/repos/Shopify/shipit-engine/issues/645"},"comments":{"href":"https://api.github.com/repos/Shopify/shipit-engine/issues/645/comments"},"review_comments":{"href":"https://api.github.com/repos/Shopify/shipit-engine/pulls/645/comments"},"review_comment":{"href":"https://api.github.com/repos/Shopify/shipit-engine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Shopify/shipit-engine/pulls/645/commits"},"statuses":{"href":"https://api.github.com/repos/Shopify/shipit-engine/statuses/afe1441abd0e4b6d80da1bf1d375a43e65907ea2"}}}}
{"actor":{"display_login":"wvanbergen"}}