{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/54773","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/54773/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/54773/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/54773/events","html_url":"https://github.com/kubernetes/kubernetes/pull/54773","id":269468917,"number":54773,"title":"Support copying \"options\" in resolv.conf into pod sandbox when dnsPolicy is Default","user":{"login":"phsiao","id":31624,"avatar_url":"https://avatars0.githubusercontent.com/u/31624?v=4","gravatar_id":"","url":"https://api.github.com/users/phsiao","html_url":"https://github.com/phsiao","followers_url":"https://api.github.com/users/phsiao/followers","following_url":"https://api.github.com/users/phsiao/following{/other_user}","gists_url":"https://api.github.com/users/phsiao/gists{/gist_id}","starred_url":"https://api.github.com/users/phsiao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phsiao/subscriptions","organizations_url":"https://api.github.com/users/phsiao/orgs","repos_url":"https://api.github.com/users/phsiao/repos","events_url":"https://api.github.com/users/phsiao/events{/privacy}","received_events_url":"https://api.github.com/users/phsiao/received_events","type":"User","site_admin":false},"labels":[{"id":477397086,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":200149833,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note","name":"release-note","color":"c2e0c6","default":false},{"id":116712108,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/network","name":"sig/network","color":"d2b48c","default":false},{"id":253450978,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/L","name":"size/L","color":"ee9900","default":false}],"state":"open","locked":false,"assignee":{"login":"bowei","id":837034,"avatar_url":"https://avatars1.githubusercontent.com/u/837034?v=4","gravatar_id":"","url":"https://api.github.com/users/bowei","html_url":"https://github.com/bowei","followers_url":"https://api.github.com/users/bowei/followers","following_url":"https://api.github.com/users/bowei/following{/other_user}","gists_url":"https://api.github.com/users/bowei/gists{/gist_id}","starred_url":"https://api.github.com/users/bowei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bowei/subscriptions","organizations_url":"https://api.github.com/users/bowei/orgs","repos_url":"https://api.github.com/users/bowei/repos","events_url":"https://api.github.com/users/bowei/events{/privacy}","received_events_url":"https://api.github.com/users/bowei/received_events","type":"User","site_admin":false},"assignees":[{"login":"bowei","id":837034,"avatar_url":"https://avatars1.githubusercontent.com/u/837034?v=4","gravatar_id":"","url":"https://api.github.com/users/bowei","html_url":"https://github.com/bowei","followers_url":"https://api.github.com/users/bowei/followers","following_url":"https://api.github.com/users/bowei/following{/other_user}","gists_url":"https://api.github.com/users/bowei/gists{/gist_id}","starred_url":"https://api.github.com/users/bowei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bowei/subscriptions","organizations_url":"https://api.github.com/users/bowei/orgs","repos_url":"https://api.github.com/users/bowei/repos","events_url":"https://api.github.com/users/bowei/events{/privacy}","received_events_url":"https://api.github.com/users/bowei/received_events","type":"User","site_admin":false},{"login":"thockin","id":5595220,"avatar_url":"https://avatars0.githubusercontent.com/u/5595220?v=4","gravatar_id":"","url":"https://api.github.com/users/thockin","html_url":"https://github.com/thockin","followers_url":"https://api.github.com/users/thockin/followers","following_url":"https://api.github.com/users/thockin/following{/other_user}","gists_url":"https://api.github.com/users/thockin/gists{/gist_id}","starred_url":"https://api.github.com/users/thockin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thockin/subscriptions","organizations_url":"https://api.github.com/users/thockin/orgs","repos_url":"https://api.github.com/users/thockin/repos","events_url":"https://api.github.com/users/thockin/events{/privacy}","received_events_url":"https://api.github.com/users/thockin/received_events","type":"User","site_admin":false},{"login":"MrHohn","id":8681801,"avatar_url":"https://avatars0.githubusercontent.com/u/8681801?v=4","gravatar_id":"","url":"https://api.github.com/users/MrHohn","html_url":"https://github.com/MrHohn","followers_url":"https://api.github.com/users/MrHohn/followers","following_url":"https://api.github.com/users/MrHohn/following{/other_user}","gists_url":"https://api.github.com/users/MrHohn/gists{/gist_id}","starred_url":"https://api.github.com/users/MrHohn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrHohn/subscriptions","organizations_url":"https://api.github.com/users/MrHohn/orgs","repos_url":"https://api.github.com/users/MrHohn/repos","events_url":"https://api.github.com/users/MrHohn/events{/privacy}","received_events_url":"https://api.github.com/users/MrHohn/received_events","type":"User","site_admin":false}],"milestone":null,"comments":21,"created_at":"2017-10-30T03:05:35Z","updated_at":"2017-11-07T14:06:59Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/54773","html_url":"https://github.com/kubernetes/kubernetes/pull/54773","diff_url":"https://github.com/kubernetes/kubernetes/pull/54773.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/54773.patch"},"body":"**What this PR does / why we need it**:\r\n\r\nThis PR adds support for copying \"options\" from host's /etc/resolv.conf (or --resolv-conf) into pod's resolv.conf when dnsPolicy is Default.  Being able to customize options is important because it is common to leverage options to fine-tune the behavior of DNS client.\r\n\r\n**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #42542\r\n\r\n**Special notes for your reviewer**:\r\n\r\nI originally wanted to also tackle the issue of copying options for when dnsPolicy is ClusterFirst, but with ability to \"merge\" with default options (ndots:5 more specifically) when it makes sense.  I decided to leave it off for now because the \"merging\" may need more discussions.   Happy to add that to this PR or create another PR for that if it makes sense and is clear what should be done.   I think even when dnsPolicy is ClusterFirst it is important to allow customization.\r\n\r\n**Release note**:\r\n\r\n```kubelet: add support for copying \"options\" from /etc/resolv.conf (or --resolv-conf if it is used) into pod's /etc/resolv.conf when dnsPolicy is Default.```"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/342492351","html_url":"https://github.com/kubernetes/kubernetes/pull/54773#issuecomment-342492351","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/54773","id":342492351,"user":{"login":"phsiao","id":31624,"avatar_url":"https://avatars0.githubusercontent.com/u/31624?v=4","gravatar_id":"","url":"https://api.github.com/users/phsiao","html_url":"https://github.com/phsiao","followers_url":"https://api.github.com/users/phsiao/followers","following_url":"https://api.github.com/users/phsiao/following{/other_user}","gists_url":"https://api.github.com/users/phsiao/gists{/gist_id}","starred_url":"https://api.github.com/users/phsiao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phsiao/subscriptions","organizations_url":"https://api.github.com/users/phsiao/orgs","repos_url":"https://api.github.com/users/phsiao/repos","events_url":"https://api.github.com/users/phsiao/events{/privacy}","received_events_url":"https://api.github.com/users/phsiao/received_events","type":"User","site_admin":false},"created_at":"2017-11-07T14:06:59Z","updated_at":"2017-11-07T14:06:59Z","author_association":"CONTRIBUTOR","body":"/retest."}}
{"actor":{"display_login":"phsiao"}}