{"action":"created","comment":{"url":"https://api.github.com/repos/ceph/ceph/pulls/comments/133344026","pull_request_review_id":56513375,"id":133344026,"diff_hunk":"@@ -179,6 +183,8 @@ namespace librbd {\n     uint32_t readahead_trigger_requests;\n     uint64_t readahead_max_bytes;\n     uint64_t readahead_disable_after_bytes;\n+    uint64_t write_iops_limit;","path":"src/librbd/ImageCtx.h","position":22,"original_position":22,"commit_id":"86f40744dd4ab1b64f3d8d94dde9760cddf496d7","original_commit_id":"86f40744dd4ab1b64f3d8d94dde9760cddf496d7","user":{"login":"dillaman","id":4739042,"avatar_url":"https://avatars0.githubusercontent.com/u/4739042?v=4","gravatar_id":"","url":"https://api.github.com/users/dillaman","html_url":"https://github.com/dillaman","followers_url":"https://api.github.com/users/dillaman/followers","following_url":"https://api.github.com/users/dillaman/following{/other_user}","gists_url":"https://api.github.com/users/dillaman/gists{/gist_id}","starred_url":"https://api.github.com/users/dillaman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dillaman/subscriptions","organizations_url":"https://api.github.com/users/dillaman/orgs","repos_url":"https://api.github.com/users/dillaman/repos","events_url":"https://api.github.com/users/dillaman/events{/privacy}","received_events_url":"https://api.github.com/users/dillaman/received_events","type":"User","site_admin":false},"body":"Nit: these are unused","created_at":"2017-08-16T01:54:22Z","updated_at":"2017-08-16T02:00:47Z","html_url":"https://github.com/ceph/ceph/pull/17032#discussion_r133344026","pull_request_url":"https://api.github.com/repos/ceph/ceph/pulls/17032","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments/133344026"},"html":{"href":"https://github.com/ceph/ceph/pull/17032#discussion_r133344026"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph/pulls/17032"}}},"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/17032","id":135771366,"html_url":"https://github.com/ceph/ceph/pull/17032","diff_url":"https://github.com/ceph/ceph/pull/17032.diff","patch_url":"https://github.com/ceph/ceph/pull/17032.patch","issue_url":"https://api.github.com/repos/ceph/ceph/issues/17032","number":17032,"state":"open","locked":false,"title":"rbd: implement image qos in tokenbucket algorithm. ","user":{"login":"yangdongsheng","id":3012925,"avatar_url":"https://avatars0.githubusercontent.com/u/3012925?v=4","gravatar_id":"","url":"https://api.github.com/users/yangdongsheng","html_url":"https://github.com/yangdongsheng","followers_url":"https://api.github.com/users/yangdongsheng/followers","following_url":"https://api.github.com/users/yangdongsheng/following{/other_user}","gists_url":"https://api.github.com/users/yangdongsheng/gists{/gist_id}","starred_url":"https://api.github.com/users/yangdongsheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yangdongsheng/subscriptions","organizations_url":"https://api.github.com/users/yangdongsheng/orgs","repos_url":"https://api.github.com/users/yangdongsheng/repos","events_url":"https://api.github.com/users/yangdongsheng/events{/privacy}","received_events_url":"https://api.github.com/users/yangdongsheng/received_events","type":"User","site_admin":false},"body":"Same with https://github.com/ceph/ceph/pull/16865. But recreated on correct branch of my repo.\r\n\r\n@dillaman  please help to review. thanx","created_at":"2017-08-15T10:07:32Z","updated_at":"2017-08-16T02:00:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"af29a728f44df4ba127ba2d0e46101106c6d251a","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph/pulls/17032/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph/pulls/17032/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/17032/comments","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/86f40744dd4ab1b64f3d8d94dde9760cddf496d7","head":{"label":"yangdongsheng:rbd_qos","ref":"rbd_qos","sha":"86f40744dd4ab1b64f3d8d94dde9760cddf496d7","user":{"login":"yangdongsheng","id":3012925,"avatar_url":"https://avatars0.githubusercontent.com/u/3012925?v=4","gravatar_id":"","url":"https://api.github.com/users/yangdongsheng","html_url":"https://github.com/yangdongsheng","followers_url":"https://api.github.com/users/yangdongsheng/followers","following_url":"https://api.github.com/users/yangdongsheng/following{/other_user}","gists_url":"https://api.github.com/users/yangdongsheng/gists{/gist_id}","starred_url":"https://api.github.com/users/yangdongsheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yangdongsheng/subscriptions","organizations_url":"https://api.github.com/users/yangdongsheng/orgs","repos_url":"https://api.github.com/users/yangdongsheng/repos","events_url":"https://api.github.com/users/yangdongsheng/events{/privacy}","received_events_url":"https://api.github.com/users/yangdongsheng/received_events","type":"User","site_admin":false},"repo":{"id":51970029,"name":"ceph","full_name":"yangdongsheng/ceph","owner":{"login":"yangdongsheng","id":3012925,"avatar_url":"https://avatars0.githubusercontent.com/u/3012925?v=4","gravatar_id":"","url":"https://api.github.com/users/yangdongsheng","html_url":"https://github.com/yangdongsheng","followers_url":"https://api.github.com/users/yangdongsheng/followers","following_url":"https://api.github.com/users/yangdongsheng/following{/other_user}","gists_url":"https://api.github.com/users/yangdongsheng/gists{/gist_id}","starred_url":"https://api.github.com/users/yangdongsheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yangdongsheng/subscriptions","organizations_url":"https://api.github.com/users/yangdongsheng/orgs","repos_url":"https://api.github.com/users/yangdongsheng/repos","events_url":"https://api.github.com/users/yangdongsheng/events{/privacy}","received_events_url":"https://api.github.com/users/yangdongsheng/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yangdongsheng/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":true,"url":"https://api.github.com/repos/yangdongsheng/ceph","forks_url":"https://api.github.com/repos/yangdongsheng/ceph/forks","keys_url":"https://api.github.com/repos/yangdongsheng/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yangdongsheng/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yangdongsheng/ceph/teams","hooks_url":"https://api.github.com/repos/yangdongsheng/ceph/hooks","issue_events_url":"https://api.github.com/repos/yangdongsheng/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/yangdongsheng/ceph/events","assignees_url":"https://api.github.com/repos/yangdongsheng/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/yangdongsheng/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/yangdongsheng/ceph/tags","blobs_url":"https://api.github.com/repos/yangdongsheng/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yangdongsheng/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yangdongsheng/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/yangdongsheng/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yangdongsheng/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/yangdongsheng/ceph/languages","stargazers_url":"https://api.github.com/repos/yangdongsheng/ceph/stargazers","contributors_url":"https://api.github.com/repos/yangdongsheng/ceph/contributors","subscribers_url":"https://api.github.com/repos/yangdongsheng/ceph/subscribers","subscription_url":"https://api.github.com/repos/yangdongsheng/ceph/subscription","commits_url":"https://api.github.com/repos/yangdongsheng/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/yangdongsheng/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/yangdongsheng/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/yangdongsheng/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/yangdongsheng/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/yangdongsheng/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yangdongsheng/ceph/merges","archive_url":"https://api.github.com/repos/yangdongsheng/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yangdongsheng/ceph/downloads","issues_url":"https://api.github.com/repos/yangdongsheng/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/yangdongsheng/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/yangdongsheng/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/yangdongsheng/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yangdongsheng/ceph/labels{/name}","releases_url":"https://api.github.com/repos/yangdongsheng/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/yangdongsheng/ceph/deployments","created_at":"2016-02-18T01:49:20Z","updated_at":"2016-02-18T01:49:37Z","pushed_at":"2017-08-15T04:53:58Z","git_url":"git://github.com/yangdongsheng/ceph.git","ssh_url":"git@github.com:yangdongsheng/ceph.git","clone_url":"https://github.com/yangdongsheng/ceph.git","svn_url":"https://github.com/yangdongsheng/ceph","homepage":"http://ceph.com","size":234752,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"21d93377353ba8a9ef9580669491a4b420205312","user":{"login":"ceph","id":1015767,"avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":2310495,"name":"ceph","full_name":"ceph/ceph","owner":{"login":"ceph","id":1015767,"avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":false,"url":"https://api.github.com/repos/ceph/ceph","forks_url":"https://api.github.com/repos/ceph/ceph/forks","keys_url":"https://api.github.com/repos/ceph/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph/teams","hooks_url":"https://api.github.com/repos/ceph/ceph/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph/events","assignees_url":"https://api.github.com/repos/ceph/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph/tags","blobs_url":"https://api.github.com/repos/ceph/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph/subscription","commits_url":"https://api.github.com/repos/ceph/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph/merges","archive_url":"https://api.github.com/repos/ceph/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph/downloads","issues_url":"https://api.github.com/repos/ceph/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph/deployments","created_at":"2011-09-01T21:41:26Z","updated_at":"2017-08-16T01:45:31Z","pushed_at":"2017-08-16T01:59:29Z","git_url":"git://github.com/ceph/ceph.git","ssh_url":"git@github.com:ceph/ceph.git","clone_url":"https://github.com/ceph/ceph.git","svn_url":"https://github.com/ceph/ceph","homepage":"http://ceph.com","size":236477,"stargazers_count":3507,"watchers_count":3507,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2041,"mirror_url":null,"open_issues_count":512,"forks":2041,"open_issues":512,"watchers":3507,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/17032"},"html":{"href":"https://github.com/ceph/ceph/pull/17032"},"issue":{"href":"https://api.github.com/repos/ceph/ceph/issues/17032"},"comments":{"href":"https://api.github.com/repos/ceph/ceph/issues/17032/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph/pulls/17032/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph/pulls/17032/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph/statuses/86f40744dd4ab1b64f3d8d94dde9760cddf496d7"}}}}
{"actor":{"display_login":"dillaman"}}