{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kops/pulls/comments/131309661","pull_request_review_id":54277581,"id":131309661,"diff_hunk":"@@ -123,16 +132,32 @@ func RunReplace(f *util.Factory, cmd *cobra.Command, out io.Writer, c *ReplaceOp\n \t\t\t\tif cluster == nil {\n \t\t\t\t\treturn fmt.Errorf(\"cluster %q not found\", clusterName)\n \t\t\t\t}\n-\t\t\t\t_, err = clientset.InstanceGroupsFor(cluster).Update(v)\n+\t\t\t\t// @check if the instancegroup exists already","path":"cmd/kops/replace.go","position":85,"original_position":85,"commit_id":"fc2bd6f74f5891573e2c337d1bca98e5cdbfc00d","original_commit_id":"fc2bd6f74f5891573e2c337d1bca98e5cdbfc00d","user":{"login":"justinsb","id":100893,"avatar_url":"https://avatars2.githubusercontent.com/u/100893?v=4","gravatar_id":"","url":"https://api.github.com/users/justinsb","html_url":"https://github.com/justinsb","followers_url":"https://api.github.com/users/justinsb/followers","following_url":"https://api.github.com/users/justinsb/following{/other_user}","gists_url":"https://api.github.com/users/justinsb/gists{/gist_id}","starred_url":"https://api.github.com/users/justinsb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinsb/subscriptions","organizations_url":"https://api.github.com/users/justinsb/orgs","repos_url":"https://api.github.com/users/justinsb/repos","events_url":"https://api.github.com/users/justinsb/events{/privacy}","received_events_url":"https://api.github.com/users/justinsb/received_events","type":"User","site_admin":false},"body":"Out of interest, why the `@check` and not just `check`?","created_at":"2017-08-04T04:26:04Z","updated_at":"2017-08-04T04:34:18Z","html_url":"https://github.com/kubernetes/kops/pull/3089#discussion_r131309661","pull_request_url":"https://api.github.com/repos/kubernetes/kops/pulls/3089","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kops/pulls/comments/131309661"},"html":{"href":"https://github.com/kubernetes/kops/pull/3089#discussion_r131309661"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kops/pulls/3089"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kops/pulls/3089","id":133090355,"html_url":"https://github.com/kubernetes/kops/pull/3089","diff_url":"https://github.com/kubernetes/kops/pull/3089.diff","patch_url":"https://github.com/kubernetes/kops/pull/3089.patch","issue_url":"https://api.github.com/repos/kubernetes/kops/issues/3089","number":3089,"state":"open","locked":false,"title":"Kops Replace Command - create unprovisioned","user":{"login":"gambol99","id":4280679,"avatar_url":"https://avatars3.githubusercontent.com/u/4280679?v=4","gravatar_id":"","url":"https://api.github.com/users/gambol99","html_url":"https://github.com/gambol99","followers_url":"https://api.github.com/users/gambol99/followers","following_url":"https://api.github.com/users/gambol99/following{/other_user}","gists_url":"https://api.github.com/users/gambol99/gists{/gist_id}","starred_url":"https://api.github.com/users/gambol99/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gambol99/subscriptions","organizations_url":"https://api.github.com/users/gambol99/orgs","repos_url":"https://api.github.com/users/gambol99/repos","events_url":"https://api.github.com/users/gambol99/events{/privacy}","received_events_url":"https://api.github.com/users/gambol99/received_events","type":"User","site_admin":false},"body":"The current 'kops replace' fails if the resource does not exist, which is annoying if you want to use the feature to drive your CI. This PR adds a --create option to create any resource which does not exist. At the moment we limit this to instanceGroups only. I'd also like to see this command perhaps be renamed to kops apply?\r\n\r\n- added a --create command line option to the replace command to create unprovisioned resources","created_at":"2017-07-29T11:51:25Z","updated_at":"2017-08-04T04:34:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f8aa57ec5fc7571a2872999b64e717d5dfede23a","assignee":{"login":"justinsb","id":100893,"avatar_url":"https://avatars2.githubusercontent.com/u/100893?v=4","gravatar_id":"","url":"https://api.github.com/users/justinsb","html_url":"https://github.com/justinsb","followers_url":"https://api.github.com/users/justinsb/followers","following_url":"https://api.github.com/users/justinsb/following{/other_user}","gists_url":"https://api.github.com/users/justinsb/gists{/gist_id}","starred_url":"https://api.github.com/users/justinsb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinsb/subscriptions","organizations_url":"https://api.github.com/users/justinsb/orgs","repos_url":"https://api.github.com/users/justinsb/repos","events_url":"https://api.github.com/users/justinsb/events{/privacy}","received_events_url":"https://api.github.com/users/justinsb/received_events","type":"User","site_admin":false},"assignees":[{"login":"justinsb","id":100893,"avatar_url":"https://avatars2.githubusercontent.com/u/100893?v=4","gravatar_id":"","url":"https://api.github.com/users/justinsb","html_url":"https://github.com/justinsb","followers_url":"https://api.github.com/users/justinsb/followers","following_url":"https://api.github.com/users/justinsb/following{/other_user}","gists_url":"https://api.github.com/users/justinsb/gists{/gist_id}","starred_url":"https://api.github.com/users/justinsb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinsb/subscriptions","organizations_url":"https://api.github.com/users/justinsb/orgs","repos_url":"https://api.github.com/users/justinsb/repos","events_url":"https://api.github.com/users/justinsb/events{/privacy}","received_events_url":"https://api.github.com/users/justinsb/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kops/pulls/3089/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kops/pulls/3089/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kops/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kops/issues/3089/comments","statuses_url":"https://api.github.com/repos/kubernetes/kops/statuses/fc2bd6f74f5891573e2c337d1bca98e5cdbfc00d","head":{"label":"gambol99:replace_cmd","ref":"replace_cmd","sha":"fc2bd6f74f5891573e2c337d1bca98e5cdbfc00d","user":{"login":"gambol99","id":4280679,"avatar_url":"https://avatars3.githubusercontent.com/u/4280679?v=4","gravatar_id":"","url":"https://api.github.com/users/gambol99","html_url":"https://github.com/gambol99","followers_url":"https://api.github.com/users/gambol99/followers","following_url":"https://api.github.com/users/gambol99/following{/other_user}","gists_url":"https://api.github.com/users/gambol99/gists{/gist_id}","starred_url":"https://api.github.com/users/gambol99/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gambol99/subscriptions","organizations_url":"https://api.github.com/users/gambol99/orgs","repos_url":"https://api.github.com/users/gambol99/repos","events_url":"https://api.github.com/users/gambol99/events{/privacy}","received_events_url":"https://api.github.com/users/gambol99/received_events","type":"User","site_admin":false},"repo":{"id":95773659,"name":"kops","full_name":"gambol99/kops","owner":{"login":"gambol99","id":4280679,"avatar_url":"https://avatars3.githubusercontent.com/u/4280679?v=4","gravatar_id":"","url":"https://api.github.com/users/gambol99","html_url":"https://github.com/gambol99","followers_url":"https://api.github.com/users/gambol99/followers","following_url":"https://api.github.com/users/gambol99/following{/other_user}","gists_url":"https://api.github.com/users/gambol99/gists{/gist_id}","starred_url":"https://api.github.com/users/gambol99/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gambol99/subscriptions","organizations_url":"https://api.github.com/users/gambol99/orgs","repos_url":"https://api.github.com/users/gambol99/repos","events_url":"https://api.github.com/users/gambol99/events{/privacy}","received_events_url":"https://api.github.com/users/gambol99/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gambol99/kops","description":"Kubernetes Operations (kops) - Production Grade K8s Installation, Upgrades, and Management","fork":true,"url":"https://api.github.com/repos/gambol99/kops","forks_url":"https://api.github.com/repos/gambol99/kops/forks","keys_url":"https://api.github.com/repos/gambol99/kops/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gambol99/kops/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gambol99/kops/teams","hooks_url":"https://api.github.com/repos/gambol99/kops/hooks","issue_events_url":"https://api.github.com/repos/gambol99/kops/issues/events{/number}","events_url":"https://api.github.com/repos/gambol99/kops/events","assignees_url":"https://api.github.com/repos/gambol99/kops/assignees{/user}","branches_url":"https://api.github.com/repos/gambol99/kops/branches{/branch}","tags_url":"https://api.github.com/repos/gambol99/kops/tags","blobs_url":"https://api.github.com/repos/gambol99/kops/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gambol99/kops/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gambol99/kops/git/refs{/sha}","trees_url":"https://api.github.com/repos/gambol99/kops/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gambol99/kops/statuses/{sha}","languages_url":"https://api.github.com/repos/gambol99/kops/languages","stargazers_url":"https://api.github.com/repos/gambol99/kops/stargazers","contributors_url":"https://api.github.com/repos/gambol99/kops/contributors","subscribers_url":"https://api.github.com/repos/gambol99/kops/subscribers","subscription_url":"https://api.github.com/repos/gambol99/kops/subscription","commits_url":"https://api.github.com/repos/gambol99/kops/commits{/sha}","git_commits_url":"https://api.github.com/repos/gambol99/kops/git/commits{/sha}","comments_url":"https://api.github.com/repos/gambol99/kops/comments{/number}","issue_comment_url":"https://api.github.com/repos/gambol99/kops/issues/comments{/number}","contents_url":"https://api.github.com/repos/gambol99/kops/contents/{+path}","compare_url":"https://api.github.com/repos/gambol99/kops/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gambol99/kops/merges","archive_url":"https://api.github.com/repos/gambol99/kops/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gambol99/kops/downloads","issues_url":"https://api.github.com/repos/gambol99/kops/issues{/number}","pulls_url":"https://api.github.com/repos/gambol99/kops/pulls{/number}","milestones_url":"https://api.github.com/repos/gambol99/kops/milestones{/number}","notifications_url":"https://api.github.com/repos/gambol99/kops/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gambol99/kops/labels{/name}","releases_url":"https://api.github.com/repos/gambol99/kops/releases{/id}","deployments_url":"https://api.github.com/repos/gambol99/kops/deployments","created_at":"2017-06-29T12:07:54Z","updated_at":"2017-06-29T12:07:59Z","pushed_at":"2017-08-03T21:13:10Z","git_url":"git://github.com/gambol99/kops.git","ssh_url":"git@github.com:gambol99/kops.git","clone_url":"https://github.com/gambol99/kops.git","svn_url":"https://github.com/gambol99/kops","homepage":"","size":136407,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"0fa00f36536fb3684c2644338485826fe096ebf9","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":62091339,"name":"kops","full_name":"kubernetes/kops","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kops","description":"Kubernetes Operations (kops) - Production Grade K8s Installation, Upgrades, and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kops","forks_url":"https://api.github.com/repos/kubernetes/kops/forks","keys_url":"https://api.github.com/repos/kubernetes/kops/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kops/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kops/teams","hooks_url":"https://api.github.com/repos/kubernetes/kops/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kops/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kops/events","assignees_url":"https://api.github.com/repos/kubernetes/kops/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kops/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kops/tags","blobs_url":"https://api.github.com/repos/kubernetes/kops/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kops/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kops/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kops/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kops/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kops/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kops/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kops/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kops/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kops/subscription","commits_url":"https://api.github.com/repos/kubernetes/kops/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kops/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kops/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kops/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kops/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kops/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kops/merges","archive_url":"https://api.github.com/repos/kubernetes/kops/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kops/downloads","issues_url":"https://api.github.com/repos/kubernetes/kops/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kops/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kops/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kops/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kops/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kops/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kops/deployments","created_at":"2016-06-27T22:01:15Z","updated_at":"2017-08-04T00:44:48Z","pushed_at":"2017-08-04T04:05:03Z","git_url":"git://github.com/kubernetes/kops.git","ssh_url":"git@github.com:kubernetes/kops.git","clone_url":"https://github.com/kubernetes/kops.git","svn_url":"https://github.com/kubernetes/kops","homepage":"","size":148869,"stargazers_count":2400,"watchers_count":2400,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":634,"mirror_url":null,"open_issues_count":816,"forks":634,"open_issues":816,"watchers":2400,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kops/pulls/3089"},"html":{"href":"https://github.com/kubernetes/kops/pull/3089"},"issue":{"href":"https://api.github.com/repos/kubernetes/kops/issues/3089"},"comments":{"href":"https://api.github.com/repos/kubernetes/kops/issues/3089/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kops/pulls/3089/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kops/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kops/pulls/3089/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kops/statuses/fc2bd6f74f5891573e2c337d1bca98e5cdbfc00d"}}}}
{"actor":{"display_login":"justinsb"}}