{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/45582","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/45582/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/45582/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/45582/events","html_url":"https://github.com/kubernetes/kubernetes/pull/45582","id":227615600,"number":45582,"title":"Fix odd help message of \"kubectl set\"","user":{"login":"CaoShuFeng","id":20855209,"avatar_url":"https://avatars3.githubusercontent.com/u/20855209?v=3","gravatar_id":"","url":"https://api.github.com/users/CaoShuFeng","html_url":"https://github.com/CaoShuFeng","followers_url":"https://api.github.com/users/CaoShuFeng/followers","following_url":"https://api.github.com/users/CaoShuFeng/following{/other_user}","gists_url":"https://api.github.com/users/CaoShuFeng/gists{/gist_id}","starred_url":"https://api.github.com/users/CaoShuFeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CaoShuFeng/subscriptions","organizations_url":"https://api.github.com/users/CaoShuFeng/orgs","repos_url":"https://api.github.com/users/CaoShuFeng/repos","events_url":"https://api.github.com/users/CaoShuFeng/events{/privacy}","received_events_url":"https://api.github.com/users/CaoShuFeng/received_events","type":"User","site_admin":false},"labels":[{"id":477397086,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":200149833,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note","name":"release-note","color":"c2e0c6","default":false},{"id":253450895,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/S","name":"size/S","color":"77bb00","default":false}],"state":"open","locked":false,"assignee":{"login":"rootfs","id":7062400,"avatar_url":"https://avatars3.githubusercontent.com/u/7062400?v=3","gravatar_id":"","url":"https://api.github.com/users/rootfs","html_url":"https://github.com/rootfs","followers_url":"https://api.github.com/users/rootfs/followers","following_url":"https://api.github.com/users/rootfs/following{/other_user}","gists_url":"https://api.github.com/users/rootfs/gists{/gist_id}","starred_url":"https://api.github.com/users/rootfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rootfs/subscriptions","organizations_url":"https://api.github.com/users/rootfs/orgs","repos_url":"https://api.github.com/users/rootfs/repos","events_url":"https://api.github.com/users/rootfs/events{/privacy}","received_events_url":"https://api.github.com/users/rootfs/received_events","type":"User","site_admin":false},"assignees":[{"login":"janetkuo","id":4876867,"avatar_url":"https://avatars2.githubusercontent.com/u/4876867?v=3","gravatar_id":"","url":"https://api.github.com/users/janetkuo","html_url":"https://github.com/janetkuo","followers_url":"https://api.github.com/users/janetkuo/followers","following_url":"https://api.github.com/users/janetkuo/following{/other_user}","gists_url":"https://api.github.com/users/janetkuo/gists{/gist_id}","starred_url":"https://api.github.com/users/janetkuo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janetkuo/subscriptions","organizations_url":"https://api.github.com/users/janetkuo/orgs","repos_url":"https://api.github.com/users/janetkuo/repos","events_url":"https://api.github.com/users/janetkuo/events{/privacy}","received_events_url":"https://api.github.com/users/janetkuo/received_events","type":"User","site_admin":false},{"login":"rootfs","id":7062400,"avatar_url":"https://avatars3.githubusercontent.com/u/7062400?v=3","gravatar_id":"","url":"https://api.github.com/users/rootfs","html_url":"https://github.com/rootfs","followers_url":"https://api.github.com/users/rootfs/followers","following_url":"https://api.github.com/users/rootfs/following{/other_user}","gists_url":"https://api.github.com/users/rootfs/gists{/gist_id}","starred_url":"https://api.github.com/users/rootfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rootfs/subscriptions","organizations_url":"https://api.github.com/users/rootfs/orgs","repos_url":"https://api.github.com/users/rootfs/repos","events_url":"https://api.github.com/users/rootfs/events{/privacy}","received_events_url":"https://api.github.com/users/rootfs/received_events","type":"User","site_admin":false}],"milestone":null,"comments":9,"created_at":"2017-05-10T09:15:57Z","updated_at":"2017-05-14T10:43:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/45582","html_url":"https://github.com/kubernetes/kubernetes/pull/45582","diff_url":"https://github.com/kubernetes/kubernetes/pull/45582.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/45582.patch"},"body":"Before this change:\r\n```console\r\n$ kubectl set subject\r\nerror: You must provide one or more resources by argument or filename.\r\nExample resource specifications include:\r\n   '-f rsrc.yaml'\r\n   '--filename=rsrc.json'\r\n   'pods my-pod'\r\n   'services'\r\n```\r\n\r\nAfter this change:\r\n```console\r\n$ kubectl set subject\r\nerror: -f option or \"TYPE NAME\" is requried\r\nSee 'kubectl set subject -h' for help and examples.\r\n```\r\n\r\n**Release note**:\r\n<!--  Steps to write your release note:\r\n1. Use the release-note-* labels to set the release note state (if you have access) \r\n2. Enter your extended release note in the below block; leaving it blank means using the PR title as the release note. If no release note is required, just write `NONE`. \r\n-->\r\n```release-note\r\nProvide user friendly help message for \"kubectl set\"\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/301304089","html_url":"https://github.com/kubernetes/kubernetes/pull/45582#issuecomment-301304089","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/45582","id":301304089,"user":{"login":"CaoShuFeng","id":20855209,"avatar_url":"https://avatars3.githubusercontent.com/u/20855209?v=3","gravatar_id":"","url":"https://api.github.com/users/CaoShuFeng","html_url":"https://github.com/CaoShuFeng","followers_url":"https://api.github.com/users/CaoShuFeng/followers","following_url":"https://api.github.com/users/CaoShuFeng/following{/other_user}","gists_url":"https://api.github.com/users/CaoShuFeng/gists{/gist_id}","starred_url":"https://api.github.com/users/CaoShuFeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CaoShuFeng/subscriptions","organizations_url":"https://api.github.com/users/CaoShuFeng/orgs","repos_url":"https://api.github.com/users/CaoShuFeng/repos","events_url":"https://api.github.com/users/CaoShuFeng/events{/privacy}","received_events_url":"https://api.github.com/users/CaoShuFeng/received_events","type":"User","site_admin":false},"created_at":"2017-05-14T10:43:27Z","updated_at":"2017-05-14T10:43:27Z","body":"> Please put the options validation code in Validate\r\n\r\nI tried your suggestion, but I found that error happens before we call Validate(), so it's default to check options in Validate()."}}
{"actor":{"display_login":"CaoShuFeng"}}