{"action":"created","issue":{"url":"https://api.github.com/repos/callstack-io/haul/issues/139","repository_url":"https://api.github.com/repos/callstack-io/haul","labels_url":"https://api.github.com/repos/callstack-io/haul/issues/139/labels{/name}","comments_url":"https://api.github.com/repos/callstack-io/haul/issues/139/comments","events_url":"https://api.github.com/repos/callstack-io/haul/issues/139/events","html_url":"https://github.com/callstack-io/haul/pull/139","id":223701464,"number":139,"title":"Opens an editor when tapping a stack frame.","user":{"login":"skellock","id":68273,"avatar_url":"https://avatars3.githubusercontent.com/u/68273?v=3","gravatar_id":"","url":"https://api.github.com/users/skellock","html_url":"https://github.com/skellock","followers_url":"https://api.github.com/users/skellock/followers","following_url":"https://api.github.com/users/skellock/following{/other_user}","gists_url":"https://api.github.com/users/skellock/gists{/gist_id}","starred_url":"https://api.github.com/users/skellock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skellock/subscriptions","organizations_url":"https://api.github.com/users/skellock/orgs","repos_url":"https://api.github.com/users/skellock/repos","events_url":"https://api.github.com/users/skellock/events{/privacy}","received_events_url":"https://api.github.com/users/skellock/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2017-04-24T04:29:00Z","updated_at":"2017-04-28T13:36:35Z","closed_at":"2017-04-28T13:27:18Z","pull_request":{"url":"https://api.github.com/repos/callstack-io/haul/pulls/139","html_url":"https://github.com/callstack-io/haul/pull/139","diff_url":"https://github.com/callstack-io/haul/pull/139.diff","patch_url":"https://github.com/callstack-io/haul/pull/139.patch"},"body":"This PR adds support for tapping on a stack trace in the simulator.  It will open the user's editor to the right line/column.\r\n\r\nThere's a few ways to use it, here's the easiest:\r\n\r\n```sh\r\nexport REACT_EDITOR=code\r\n```\r\n\r\nThis works too:\r\n\r\n```sh\r\nexport REACT_EDITOR=/usr/local/bin/code\r\n```\r\n\r\n[The library we're using](https://github.com/lahmatiy/open-in-editor) supports about a dozen editors and it knows where to look for the standard installs.  It knows how to launch them and use the right order for parameters.\r\n\r\nFor custom installs, we had to invent some things:\r\n\r\n```sh\r\nexport HAUL_EDITOR=sublime\r\nexport HAUL_EDITOR_CMD=\"/path/to/Sublime Super Mega Beta.app\"\r\nexport HAUL_EDITOR_PATTERN=\"-r -g {filename}:{line}:{column}\"\r\n```\r\n\r\nThat's for more advanced setups.\r\n\r\nOut of the box, if no environment variables are found, it prints some instructions:\r\n\r\n![image](https://cloud.githubusercontent.com/assets/68273/25322280/789cc2d4-2883-11e7-8a4c-916488f0d076.png)\r\n\r\nI've tried atom, code, vim, and sublime on MacOS 10.11.6.  I haven't tried on Windows or Linux, however, the library we're using supports those.  I will give it a test tomorrow on both and sound the air raid horns if something is awry.\r\n\r\nVim opens up in Terminal, not iTerm.  This makes me sad in the pants.  I don't know how to fix.\r\n\r\nFeedback welcome. (e.g. should we add a command line option too?).\r\n\r\nFixes #123 \r\n"},"comment":{"url":"https://api.github.com/repos/callstack-io/haul/issues/comments/297999578","html_url":"https://github.com/callstack-io/haul/pull/139#issuecomment-297999578","issue_url":"https://api.github.com/repos/callstack-io/haul/issues/139","id":297999578,"user":{"login":"skellock","id":68273,"avatar_url":"https://avatars3.githubusercontent.com/u/68273?v=3","gravatar_id":"","url":"https://api.github.com/users/skellock","html_url":"https://github.com/skellock","followers_url":"https://api.github.com/users/skellock/followers","following_url":"https://api.github.com/users/skellock/following{/other_user}","gists_url":"https://api.github.com/users/skellock/gists{/gist_id}","starred_url":"https://api.github.com/users/skellock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skellock/subscriptions","organizations_url":"https://api.github.com/users/skellock/orgs","repos_url":"https://api.github.com/users/skellock/repos","events_url":"https://api.github.com/users/skellock/events{/privacy}","received_events_url":"https://api.github.com/users/skellock/received_events","type":"User","site_admin":false},"created_at":"2017-04-28T13:36:35Z","updated_at":"2017-04-28T13:36:35Z","body":"[ScreenFlow](https://www.telestream.net/screenflow/overview.htm).  Pricey, but worth it every Canadian peso.\r\n\r\nI don't use most of the features, but, the timeline editor is 💯 .\r\n\r\n* record me flailing around\r\n* crop the viewport\r\n* set some in & out points by clicking\r\n* slice up & delete some dead air\r\n* double-click a slice and speed up some of them to 400%\r\n* export as gif\r\n\r\nKap (and kin) is great if you're a one-take no-mistake kinda fellow.  And that is decidedly not me.\r\n\r\nCheers for the merge!\r\n\r\n"}}
{"actor":{"display_login":"skellock"}}