{"action":"created","comment":{"url":"https://api.github.com/repos/angular/material2/pulls/comments/131730768","pull_request_review_id":54735100,"id":131730768,"diff_hunk":"@@ -58,20 +93,12 @@ export class ListKeyManager<T extends CanDisable> {\n    */\n   onKeydown(event: KeyboardEvent): void {\n     switch (event.keyCode) {\n-      case DOWN_ARROW:\n-        this.setNextItemActive();\n-        break;\n-      case UP_ARROW:\n-        this.setPreviousItemActive();\n-        break;\n-      case TAB:\n-        // Note that we shouldn't prevent the default action on tab.\n-        this._tabOut.next();\n-        return;\n-      default:\n-        return;\n+      case DOWN_ARROW: this.setNextItemActive(); break;\n+      case UP_ARROW: this.setPreviousItemActive(); break;\n+      default: this._nonNavigationKeyStream.next(event.keyCode); return;","path":"src/cdk/a11y/list-key-manager.ts","position":107,"original_position":107,"commit_id":"72e245d5251d32a0d5df56f4446e3fe494c22c3f","original_commit_id":"72e245d5251d32a0d5df56f4446e3fe494c22c3f","user":{"login":"jelbourn","id":838736,"avatar_url":"https://avatars3.githubusercontent.com/u/838736?v=4","gravatar_id":"","url":"https://api.github.com/users/jelbourn","html_url":"https://github.com/jelbourn","followers_url":"https://api.github.com/users/jelbourn/followers","following_url":"https://api.github.com/users/jelbourn/following{/other_user}","gists_url":"https://api.github.com/users/jelbourn/gists{/gist_id}","starred_url":"https://api.github.com/users/jelbourn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jelbourn/subscriptions","organizations_url":"https://api.github.com/users/jelbourn/orgs","repos_url":"https://api.github.com/users/jelbourn/repos","events_url":"https://api.github.com/users/jelbourn/events{/privacy}","received_events_url":"https://api.github.com/users/jelbourn/received_events","type":"User","site_admin":false},"body":"Add back comment about using `return` here to skip `preventDefault`?","created_at":"2017-08-07T18:33:48Z","updated_at":"2017-08-07T18:58:47Z","html_url":"https://github.com/angular/material2/pull/2907#discussion_r131730768","pull_request_url":"https://api.github.com/repos/angular/material2/pulls/2907","_links":{"self":{"href":"https://api.github.com/repos/angular/material2/pulls/comments/131730768"},"html":{"href":"https://github.com/angular/material2/pull/2907#discussion_r131730768"},"pull_request":{"href":"https://api.github.com/repos/angular/material2/pulls/2907"}}},"pull_request":{"url":"https://api.github.com/repos/angular/material2/pulls/2907","id":104424574,"html_url":"https://github.com/angular/material2/pull/2907","diff_url":"https://github.com/angular/material2/pull/2907.diff","patch_url":"https://github.com/angular/material2/pull/2907.patch","issue_url":"https://api.github.com/repos/angular/material2/issues/2907","number":2907,"state":"open","locked":false,"title":"feat(select): allow focusing items by typing","user":{"login":"crisbeto","id":4450522,"avatar_url":"https://avatars0.githubusercontent.com/u/4450522?v=4","gravatar_id":"","url":"https://api.github.com/users/crisbeto","html_url":"https://github.com/crisbeto","followers_url":"https://api.github.com/users/crisbeto/followers","following_url":"https://api.github.com/users/crisbeto/following{/other_user}","gists_url":"https://api.github.com/users/crisbeto/gists{/gist_id}","starred_url":"https://api.github.com/users/crisbeto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crisbeto/subscriptions","organizations_url":"https://api.github.com/users/crisbeto/orgs","repos_url":"https://api.github.com/users/crisbeto/repos","events_url":"https://api.github.com/users/crisbeto/events{/privacy}","received_events_url":"https://api.github.com/users/crisbeto/received_events","type":"User","site_admin":false},"body":"Allows for users to skip to a select item by typing, similar to the native select.\r\n\r\nFixes #2668.","created_at":"2017-02-02T21:12:21Z","updated_at":"2017-08-07T18:58:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"49eb738369eb0a719a18fcff6d54774c110808fa","assignee":{"login":"jelbourn","id":838736,"avatar_url":"https://avatars3.githubusercontent.com/u/838736?v=4","gravatar_id":"","url":"https://api.github.com/users/jelbourn","html_url":"https://github.com/jelbourn","followers_url":"https://api.github.com/users/jelbourn/followers","following_url":"https://api.github.com/users/jelbourn/following{/other_user}","gists_url":"https://api.github.com/users/jelbourn/gists{/gist_id}","starred_url":"https://api.github.com/users/jelbourn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jelbourn/subscriptions","organizations_url":"https://api.github.com/users/jelbourn/orgs","repos_url":"https://api.github.com/users/jelbourn/repos","events_url":"https://api.github.com/users/jelbourn/events{/privacy}","received_events_url":"https://api.github.com/users/jelbourn/received_events","type":"User","site_admin":false},"assignees":[{"login":"jelbourn","id":838736,"avatar_url":"https://avatars3.githubusercontent.com/u/838736?v=4","gravatar_id":"","url":"https://api.github.com/users/jelbourn","html_url":"https://github.com/jelbourn","followers_url":"https://api.github.com/users/jelbourn/followers","following_url":"https://api.github.com/users/jelbourn/following{/other_user}","gists_url":"https://api.github.com/users/jelbourn/gists{/gist_id}","starred_url":"https://api.github.com/users/jelbourn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jelbourn/subscriptions","organizations_url":"https://api.github.com/users/jelbourn/orgs","repos_url":"https://api.github.com/users/jelbourn/repos","events_url":"https://api.github.com/users/jelbourn/events{/privacy}","received_events_url":"https://api.github.com/users/jelbourn/received_events","type":"User","site_admin":false},{"login":"kara","id":3871688,"avatar_url":"https://avatars3.githubusercontent.com/u/3871688?v=4","gravatar_id":"","url":"https://api.github.com/users/kara","html_url":"https://github.com/kara","followers_url":"https://api.github.com/users/kara/followers","following_url":"https://api.github.com/users/kara/following{/other_user}","gists_url":"https://api.github.com/users/kara/gists{/gist_id}","starred_url":"https://api.github.com/users/kara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kara/subscriptions","organizations_url":"https://api.github.com/users/kara/orgs","repos_url":"https://api.github.com/users/kara/repos","events_url":"https://api.github.com/users/kara/events{/privacy}","received_events_url":"https://api.github.com/users/kara/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"kara","id":3871688,"avatar_url":"https://avatars3.githubusercontent.com/u/3871688?v=4","gravatar_id":"","url":"https://api.github.com/users/kara","html_url":"https://github.com/kara","followers_url":"https://api.github.com/users/kara/followers","following_url":"https://api.github.com/users/kara/following{/other_user}","gists_url":"https://api.github.com/users/kara/gists{/gist_id}","starred_url":"https://api.github.com/users/kara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kara/subscriptions","organizations_url":"https://api.github.com/users/kara/orgs","repos_url":"https://api.github.com/users/kara/repos","events_url":"https://api.github.com/users/kara/events{/privacy}","received_events_url":"https://api.github.com/users/kara/received_events","type":"User","site_admin":false},{"login":"DevVersion","id":4987015,"avatar_url":"https://avatars3.githubusercontent.com/u/4987015?v=4","gravatar_id":"","url":"https://api.github.com/users/DevVersion","html_url":"https://github.com/DevVersion","followers_url":"https://api.github.com/users/DevVersion/followers","following_url":"https://api.github.com/users/DevVersion/following{/other_user}","gists_url":"https://api.github.com/users/DevVersion/gists{/gist_id}","starred_url":"https://api.github.com/users/DevVersion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DevVersion/subscriptions","organizations_url":"https://api.github.com/users/DevVersion/orgs","repos_url":"https://api.github.com/users/DevVersion/repos","events_url":"https://api.github.com/users/DevVersion/events{/privacy}","received_events_url":"https://api.github.com/users/DevVersion/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/angular/material2/pulls/2907/commits","review_comments_url":"https://api.github.com/repos/angular/material2/pulls/2907/comments","review_comment_url":"https://api.github.com/repos/angular/material2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/material2/issues/2907/comments","statuses_url":"https://api.github.com/repos/angular/material2/statuses/72e245d5251d32a0d5df56f4446e3fe494c22c3f","head":{"label":"crisbeto:2668/select-typing-focus","ref":"2668/select-typing-focus","sha":"72e245d5251d32a0d5df56f4446e3fe494c22c3f","user":{"login":"crisbeto","id":4450522,"avatar_url":"https://avatars0.githubusercontent.com/u/4450522?v=4","gravatar_id":"","url":"https://api.github.com/users/crisbeto","html_url":"https://github.com/crisbeto","followers_url":"https://api.github.com/users/crisbeto/followers","following_url":"https://api.github.com/users/crisbeto/following{/other_user}","gists_url":"https://api.github.com/users/crisbeto/gists{/gist_id}","starred_url":"https://api.github.com/users/crisbeto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crisbeto/subscriptions","organizations_url":"https://api.github.com/users/crisbeto/orgs","repos_url":"https://api.github.com/users/crisbeto/repos","events_url":"https://api.github.com/users/crisbeto/events{/privacy}","received_events_url":"https://api.github.com/users/crisbeto/received_events","type":"User","site_admin":false},"repo":{"id":60285287,"name":"material2","full_name":"crisbeto/material2","owner":{"login":"crisbeto","id":4450522,"avatar_url":"https://avatars0.githubusercontent.com/u/4450522?v=4","gravatar_id":"","url":"https://api.github.com/users/crisbeto","html_url":"https://github.com/crisbeto","followers_url":"https://api.github.com/users/crisbeto/followers","following_url":"https://api.github.com/users/crisbeto/following{/other_user}","gists_url":"https://api.github.com/users/crisbeto/gists{/gist_id}","starred_url":"https://api.github.com/users/crisbeto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crisbeto/subscriptions","organizations_url":"https://api.github.com/users/crisbeto/orgs","repos_url":"https://api.github.com/users/crisbeto/repos","events_url":"https://api.github.com/users/crisbeto/events{/privacy}","received_events_url":"https://api.github.com/users/crisbeto/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/crisbeto/material2","description":"Material Design components for Angular 2","fork":true,"url":"https://api.github.com/repos/crisbeto/material2","forks_url":"https://api.github.com/repos/crisbeto/material2/forks","keys_url":"https://api.github.com/repos/crisbeto/material2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crisbeto/material2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crisbeto/material2/teams","hooks_url":"https://api.github.com/repos/crisbeto/material2/hooks","issue_events_url":"https://api.github.com/repos/crisbeto/material2/issues/events{/number}","events_url":"https://api.github.com/repos/crisbeto/material2/events","assignees_url":"https://api.github.com/repos/crisbeto/material2/assignees{/user}","branches_url":"https://api.github.com/repos/crisbeto/material2/branches{/branch}","tags_url":"https://api.github.com/repos/crisbeto/material2/tags","blobs_url":"https://api.github.com/repos/crisbeto/material2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crisbeto/material2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crisbeto/material2/git/refs{/sha}","trees_url":"https://api.github.com/repos/crisbeto/material2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crisbeto/material2/statuses/{sha}","languages_url":"https://api.github.com/repos/crisbeto/material2/languages","stargazers_url":"https://api.github.com/repos/crisbeto/material2/stargazers","contributors_url":"https://api.github.com/repos/crisbeto/material2/contributors","subscribers_url":"https://api.github.com/repos/crisbeto/material2/subscribers","subscription_url":"https://api.github.com/repos/crisbeto/material2/subscription","commits_url":"https://api.github.com/repos/crisbeto/material2/commits{/sha}","git_commits_url":"https://api.github.com/repos/crisbeto/material2/git/commits{/sha}","comments_url":"https://api.github.com/repos/crisbeto/material2/comments{/number}","issue_comment_url":"https://api.github.com/repos/crisbeto/material2/issues/comments{/number}","contents_url":"https://api.github.com/repos/crisbeto/material2/contents/{+path}","compare_url":"https://api.github.com/repos/crisbeto/material2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crisbeto/material2/merges","archive_url":"https://api.github.com/repos/crisbeto/material2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crisbeto/material2/downloads","issues_url":"https://api.github.com/repos/crisbeto/material2/issues{/number}","pulls_url":"https://api.github.com/repos/crisbeto/material2/pulls{/number}","milestones_url":"https://api.github.com/repos/crisbeto/material2/milestones{/number}","notifications_url":"https://api.github.com/repos/crisbeto/material2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crisbeto/material2/labels{/name}","releases_url":"https://api.github.com/repos/crisbeto/material2/releases{/id}","deployments_url":"https://api.github.com/repos/crisbeto/material2/deployments","created_at":"2016-06-02T17:50:34Z","updated_at":"2016-06-02T17:50:36Z","pushed_at":"2017-08-07T17:42:17Z","git_url":"git://github.com/crisbeto/material2.git","ssh_url":"git@github.com:crisbeto/material2.git","clone_url":"https://github.com/crisbeto/material2.git","svn_url":"https://github.com/crisbeto/material2","homepage":"https://material.angular.io/","size":7827,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"08509816b2d1c3dc3d68334f4f7bbadf342057c6","user":{"login":"angular","id":139426,"avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":49016322,"name":"material2","full_name":"angular/material2","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/material2","description":"Material Design components for Angular","fork":false,"url":"https://api.github.com/repos/angular/material2","forks_url":"https://api.github.com/repos/angular/material2/forks","keys_url":"https://api.github.com/repos/angular/material2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/material2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/material2/teams","hooks_url":"https://api.github.com/repos/angular/material2/hooks","issue_events_url":"https://api.github.com/repos/angular/material2/issues/events{/number}","events_url":"https://api.github.com/repos/angular/material2/events","assignees_url":"https://api.github.com/repos/angular/material2/assignees{/user}","branches_url":"https://api.github.com/repos/angular/material2/branches{/branch}","tags_url":"https://api.github.com/repos/angular/material2/tags","blobs_url":"https://api.github.com/repos/angular/material2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/material2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/material2/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/material2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/material2/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/material2/languages","stargazers_url":"https://api.github.com/repos/angular/material2/stargazers","contributors_url":"https://api.github.com/repos/angular/material2/contributors","subscribers_url":"https://api.github.com/repos/angular/material2/subscribers","subscription_url":"https://api.github.com/repos/angular/material2/subscription","commits_url":"https://api.github.com/repos/angular/material2/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/material2/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/material2/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/material2/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/material2/contents/{+path}","compare_url":"https://api.github.com/repos/angular/material2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/material2/merges","archive_url":"https://api.github.com/repos/angular/material2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/material2/downloads","issues_url":"https://api.github.com/repos/angular/material2/issues{/number}","pulls_url":"https://api.github.com/repos/angular/material2/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/material2/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/material2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/material2/labels{/name}","releases_url":"https://api.github.com/repos/angular/material2/releases{/id}","deployments_url":"https://api.github.com/repos/angular/material2/deployments","created_at":"2016-01-04T18:50:02Z","updated_at":"2017-08-07T18:29:46Z","pushed_at":"2017-08-07T18:56:17Z","git_url":"git://github.com/angular/material2.git","ssh_url":"git@github.com:angular/material2.git","clone_url":"https://github.com/angular/material2.git","svn_url":"https://github.com/angular/material2","homepage":"https://material.angular.io","size":7208,"stargazers_count":10180,"watchers_count":10180,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2351,"mirror_url":null,"open_issues_count":694,"forks":2351,"open_issues":694,"watchers":10180,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/material2/pulls/2907"},"html":{"href":"https://github.com/angular/material2/pull/2907"},"issue":{"href":"https://api.github.com/repos/angular/material2/issues/2907"},"comments":{"href":"https://api.github.com/repos/angular/material2/issues/2907/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/material2/pulls/2907/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/material2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/material2/pulls/2907/commits"},"statuses":{"href":"https://api.github.com/repos/angular/material2/statuses/72e245d5251d32a0d5df56f4446e3fe494c22c3f"}}}}
{"actor":{"display_login":"jelbourn"}}