{"push_id":1943818184,"size":53,"distinct_size":48,"ref":"refs/heads/some_gui2_refactoring","head":"0230d467b65ea9f4c360252107dc52183dd2a0a1","before":"23fad6d44ce7762a6f13c47b65b988e247e6cb39","commits":[{"sha":"20e6ee719077ee5e6df809a931c104df94b9ec06","author":{"name":"ln-zookeeper","email":"470310a68d8b8bdfc5d2e2f6dd77fcd8ca76cf2e@iki.fi"},"message":"Added a terrain description for oasis, and other tweaks to the entry\n\nRemoved it from the forest editor group since it doesn't really belong there even if the images have some palm trees, and changed the way the aliasing is defined to allow it to show up in the sands terrain help group.","distinct":false,"url":"https://api.github.com/repos/wesnoth/wesnoth/commits/20e6ee719077ee5e6df809a931c104df94b9ec06"},{"sha":"16333326fe0a4f61d868840dd7af74fd0e224c1e","author":{"name":"Richard Kettering","email":"9c8167f0b7eb74f7fcf253998735894dc76c0ea4@gmail.com"},"message":"Added a full set of animations for the human knight.","distinct":false,"url":"https://api.github.com/repos/wesnoth/wesnoth/commits/16333326fe0a4f61d868840dd7af74fd0e224c1e"},{"sha":"c784cdb6038c3d1c1a068545e0b54e954a31adda","author":{"name":"Richard Kettering","email":"9c8167f0b7eb74f7fcf253998735894dc76c0ea4@gmail.com"},"message":"Animation markup for the new knight frames.","distinct":false,"url":"https://api.github.com/repos/wesnoth/wesnoth/commits/c784cdb6038c3d1c1a068545e0b54e954a31adda"},{"sha":"95b4d89eda4c314404279e0d14d79b0199be93f6","author":{"name":"jostephd","email":"969bfbb1d05ddeab603a03aaf0dc0e3995a6b1b4@fastmail.com"},"message":"Fix grammar in Merman Netcaster description (#1913)\n\nSimilar to #908.","distinct":false,"url":"https://api.github.com/repos/wesnoth/wesnoth/commits/95b4d89eda4c314404279e0d14d79b0199be93f6"},{"sha":"6d7a7ba883be8fb7cae5ae3d97b868da3f888300","author":{"name":"Charles Dang","email":"090e37c98ddcb29bdfba0b3f8a051a0364d4c160@gmail.com"},"message":"Variant: used standard library helpers for the list op implementations","distinct":false,"url":"https://api.github.com/repos/wesnoth/wesnoth/commits/6d7a7ba883be8fb7cae5ae3d97b868da3f888300"},{"sha":"6df92493ba6a89a46d966dc6a2e7a471ec357e15","author":{"name":"Charles Dang","email":"090e37c98ddcb29bdfba0b3f8a051a0364d4c160@gmail.com"},"message":"GUI2/Settings: minor formatting cleanup","distinct":true,"url":"https://api.github.com/repos/wesnoth/wesnoth/commits/6df92493ba6a89a46d966dc6a2e7a471ec357e15"},{"sha":"7ceb770bac2e54ee6319d40cded82e44765bcd6a","author":{"name":"Charles Dang","email":"090e37c98ddcb29bdfba0b3f8a051a0364d4c160@gmail.com"},"message":"GUI2/Window Builder: added function to generate a single widget instance with its builder\n\nThis will be used in some upcoming changes. The main benefit of this over directly initializing a new widget\nobject is any extra builder steps can also be executed.\n\nI'm not entirely happy with the design, though, especially with having to specify both the type and type ID...","distinct":true,"url":"https://api.github.com/repos/wesnoth/wesnoth/commits/7ceb770bac2e54ee6319d40cded82e44765bcd6a"},{"sha":"df3496088aa1a8db9a19a45b2f98b2052d3d1fc3","author":{"name":"Charles Dang","email":"090e37c98ddcb29bdfba0b3f8a051a0364d4c160@gmail.com"},"message":"GUI2: refactored widget initialization process\n\nEssentially, this utilizes the second styled_widget overload that takes a builder reference to allow widgets\nto initialize themselves without the extra init_control call. It also removes the need for extra functions such\nas styled_widget::load_config_extra or styled_widget::init since the widget definition config and canvases are\nloaded in the styled_widget ctor. Any code from the uses of the former function were moved either to widget\nbuilders or their ctors.","distinct":true,"url":"https://api.github.com/repos/wesnoth/wesnoth/commits/df3496088aa1a8db9a19a45b2f98b2052d3d1fc3"},{"sha":"709ea279b3e74da6f3bfeffe1d123c0df27cc24e","author":{"name":"Charles Dang","email":"090e37c98ddcb29bdfba0b3f8a051a0364d4c160@gmail.com"},"message":"GUI2: prevented Scrollbar (and by extension Slider) step size from being set to 0\n\nThis can potentially cause division-by-0 crashes.","distinct":true,"url":"https://api.github.com/repos/wesnoth/wesnoth/commits/709ea279b3e74da6f3bfeffe1d123c0df27cc24e"},{"sha":"ad07ec58f49aa2f17266fe2e99dec8fc01d11b78","author":{"name":"Charles Dang","email":"090e37c98ddcb29bdfba0b3f8a051a0364d4c160@gmail.com"},"message":"GUI2/Window: pass definition pointer to ctor instead of individual arguments","distinct":true,"url":"https://api.github.com/repos/wesnoth/wesnoth/commits/ad07ec58f49aa2f17266fe2e99dec8fc01d11b78"},{"sha":"e9651c5bd50c0fb93612632336bc3d83cdf50802","author":{"name":"Charles Dang","email":"090e37c98ddcb29bdfba0b3f8a051a0364d4c160@gmail.com"},"message":"GUI2/Window Builder: removed build_widget function and used std::make_shared directly\n\nThis function's name was rather misleading. It didn't actually build a widget, just created a an\nobject (usually a builder, as it was utilized in REGISTER_WIDGET) with the config argument as its\nctor parameters.\n\nLamdas render the need of a separate function to pass as an std::function argument obsolete.","distinct":true,"url":"https://api.github.com/repos/wesnoth/wesnoth/commits/e9651c5bd50c0fb93612632336bc3d83cdf50802"},{"sha":"f9c2dbe30517aa778f3d74112f797e3a3439ec91","author":{"name":"Charles Dang","email":"090e37c98ddcb29bdfba0b3f8a051a0364d4c160@gmail.com"},"message":"GUI2/Window Builder: added comment clarifying Window how resolution options are used","distinct":true,"url":"https://api.github.com/repos/wesnoth/wesnoth/commits/f9c2dbe30517aa778f3d74112f797e3a3439ec91"},{"sha":"3b4b7b93dcb63407bb0866cfea1cc10da594bd9c","author":{"name":"Charles Dang","email":"090e37c98ddcb29bdfba0b3f8a051a0364d4c160@gmail.com"},"message":"GUI2: allow REGISTER_WIDGET to implement get_control_type overrides\n\nThis is similar to what REGISER_WINDOW does with window_id().\n\nExcludes the following class instances since they are not registered with REGISTER_WIDGET:\n* tree_view_node\n* scrollbar_container\n* password_box (uses REGISTER_WIDGET3)","distinct":true,"url":"https://api.github.com/repos/wesnoth/wesnoth/commits/3b4b7b93dcb63407bb0866cfea1cc10da594bd9c"},{"sha":"a85137e433b53fb401646c119997f0f14933e57a","author":{"name":"Charles Dang","email":"090e37c98ddcb29bdfba0b3f8a051a0364d4c160@gmail.com"},"message":"GUI2: don't use `0` to initialize nullptrs","distinct":true,"url":"https://api.github.com/repos/wesnoth/wesnoth/commits/a85137e433b53fb401646c119997f0f14933e57a"},{"sha":"93d2e8bd528b990a20ef7b2d42e576061f1d1177","author":{"name":"Charles Dang","email":"090e37c98ddcb29bdfba0b3f8a051a0364d4c160@gmail.com"},"message":"Fixup tests for ea15d45","distinct":true,"url":"https://api.github.com/repos/wesnoth/wesnoth/commits/93d2e8bd528b990a20ef7b2d42e576061f1d1177"},{"sha":"2325092cf270906265a7008183db09a63f7be391","author":{"name":"Charles Dang","email":"090e37c98ddcb29bdfba0b3f8a051a0364d4c160@gmail.com"},"message":"GUI2/Status Label Helper: minor cleanup and added documentation\n\nRenamed default_value_getter so it can be used outside the context of this class without being\nconfusing.","distinct":true,"url":"https://api.github.com/repos/wesnoth/wesnoth/commits/2325092cf270906265a7008183db09a63f7be391"},{"sha":"c27aa6e248d72a7099cfe6004889b62242031d32","author":{"name":"Charles Dang","email":"090e37c98ddcb29bdfba0b3f8a051a0364d4c160@gmail.com"},"message":"GUI2/Status Label Helper: take source containing widget as a pointer\n\nThey were only used in the context of pointers anyway,","distinct":true,"url":"https://api.github.com/repos/wesnoth/wesnoth/commits/c27aa6e248d72a7099cfe6004889b62242031d32"},{"sha":"04bfecfe2dacf3ee4b12394545ad4a02ec5c3361","author":{"name":"Charles Dang","email":"090e37c98ddcb29bdfba0b3f8a051a0364d4c160@gmail.com"},"message":"GUI2/Preferences Dialog: use standard status label value getters instead of lambdas where possible\n\nOnly reason I was using lambdas was since I needed to specify the fourth argument. I didn't realize I\ncould just bind the default value getters, especially since the functionality was equivalent.\n\nMenu buttons can't use them yet.","distinct":true,"url":"https://api.github.com/repos/wesnoth/wesnoth/commits/04bfecfe2dacf3ee4b12394545ad4a02ec5c3361"},{"sha":"da617e73f49ac271d458cc1290c4badfd1ea8c27","author":{"name":"Charles Dang","email":"090e37c98ddcb29bdfba0b3f8a051a0364d4c160@gmail.com"},"message":"GUI2/Listbox: move some common code for key handling to its own function","distinct":true,"url":"https://api.github.com/repos/wesnoth/wesnoth/commits/da617e73f49ac271d458cc1290c4badfd1ea8c27"},{"sha":"2fd098fd971bafbc0120662f29fbfb090ee93421","author":{"name":"Charles Dang","email":"090e37c98ddcb29bdfba0b3f8a051a0364d4c160@gmail.com"},"message":"GUI2/Listbox: fire NOTIFY_MODIFIED events where callback_value_changed_ is called\n\nThis is the beginning of an effort to finish converting the event callbacks to signal handles instead\nof function callbacks.","distinct":true,"url":"https://api.github.com/repos/wesnoth/wesnoth/commits/2fd098fd971bafbc0120662f29fbfb090ee93421"}]}
{"actor":{"display_login":"Vultraz"}}