{"action":"created","issue":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/8624","repository_url":"https://api.github.com/repos/scikit-learn/scikit-learn","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/8624/labels{/name}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/8624/comments","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/8624/events","html_url":"https://github.com/scikit-learn/scikit-learn/pull/8624","id":215812532,"number":8624,"title":"[MRG] enhance make_blobs to accept lists for samples per cluster","user":{"login":"kkatrio","id":18125046,"avatar_url":"https://avatars0.githubusercontent.com/u/18125046?v=4","gravatar_id":"","url":"https://api.github.com/users/kkatrio","html_url":"https://github.com/kkatrio","followers_url":"https://api.github.com/users/kkatrio/followers","following_url":"https://api.github.com/users/kkatrio/following{/other_user}","gists_url":"https://api.github.com/users/kkatrio/gists{/gist_id}","starred_url":"https://api.github.com/users/kkatrio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkatrio/subscriptions","organizations_url":"https://api.github.com/users/kkatrio/orgs","repos_url":"https://api.github.com/users/kkatrio/repos","events_url":"https://api.github.com/users/kkatrio/events{/privacy}","received_events_url":"https://api.github.com/users/kkatrio/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2017-03-21T17:08:40Z","updated_at":"2017-08-06T10:57:08Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/8624","html_url":"https://github.com/scikit-learn/scikit-learn/pull/8624","diff_url":"https://github.com/scikit-learn/scikit-learn/pull/8624.diff","patch_url":"https://github.com/scikit-learn/scikit-learn/pull/8624.patch"},"body":"<!--\r\nThanks for contributing a pull request! Please ensure you have taken a look at\r\nthe contribution guidelines: https://github.com/scikit-learn/scikit-learn/blob/master/CONTRIBUTING.md#Contributing-Pull-Requests\r\n-->\r\n#### Reference Issue\r\nFixes #8617 \r\n\r\n#### What does this implement/fix? Explain your changes.\r\n`make_blobs` accepts a list for `n_samples`, to indicate the number of samples per cluster. `[n_samples]` always has priority against `[centers]` in terms of configuring the `n_centers`. If `n_samples` is passed as a list, then `n_centers = len(n_samples)`. `centers` is considered only if it is a list of same length with `n_samples` to calculate the center coordinates. \r\n\r\n\r\n#### Any other comments?\r\nI added some tests and an example script. \r\n![plot_example](https://cloud.githubusercontent.com/assets/18125046/24170545/eafeb8d2-0e89-11e7-9edf-b92c198d75dc.png)\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments/320499737","html_url":"https://github.com/scikit-learn/scikit-learn/pull/8624#issuecomment-320499737","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/8624","id":320499737,"user":{"login":"jnothman","id":78827,"avatar_url":"https://avatars2.githubusercontent.com/u/78827?v=4","gravatar_id":"","url":"https://api.github.com/users/jnothman","html_url":"https://github.com/jnothman","followers_url":"https://api.github.com/users/jnothman/followers","following_url":"https://api.github.com/users/jnothman/following{/other_user}","gists_url":"https://api.github.com/users/jnothman/gists{/gist_id}","starred_url":"https://api.github.com/users/jnothman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnothman/subscriptions","organizations_url":"https://api.github.com/users/jnothman/orgs","repos_url":"https://api.github.com/users/jnothman/repos","events_url":"https://api.github.com/users/jnothman/events{/privacy}","received_events_url":"https://api.github.com/users/jnothman/received_events","type":"User","site_admin":false},"created_at":"2017-08-06T10:57:08Z","updated_at":"2017-08-06T10:57:08Z","body":"codecov is complaining that your errors are untested."}}
{"actor":{"display_login":"jnothman"}}