{"action":"created","comment":{"url":"https://api.github.com/repos/snapcore/snapcraft/pulls/comments/158340293","pull_request_review_id":85137728,"id":158340293,"diff_hunk":"@@ -96,10 +97,14 @@ def _get_source_handler(self, properties):\n         # the default '.'\n         source_handler = None\n         if properties['source']:\n+            if 'source' in self._part_property_grammar:\n+                source = self._grammar_processor.get_source()","path":"snapcraft/internal/pluginhandler/__init__.py","position":13,"original_position":13,"commit_id":"a7cf9a50ddb73f14b1c489a47b2e10ba024086c5","original_commit_id":"a7cf9a50ddb73f14b1c489a47b2e10ba024086c5","user":{"login":"sergiusens","id":1146853,"avatar_url":"https://avatars2.githubusercontent.com/u/1146853?v=4","gravatar_id":"","url":"https://api.github.com/users/sergiusens","html_url":"https://github.com/sergiusens","followers_url":"https://api.github.com/users/sergiusens/followers","following_url":"https://api.github.com/users/sergiusens/following{/other_user}","gists_url":"https://api.github.com/users/sergiusens/gists{/gist_id}","starred_url":"https://api.github.com/users/sergiusens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergiusens/subscriptions","organizations_url":"https://api.github.com/users/sergiusens/orgs","repos_url":"https://api.github.com/users/sergiusens/repos","events_url":"https://api.github.com/users/sergiusens/events{/privacy}","received_events_url":"https://api.github.com/users/sergiusens/received_events","type":"User","site_admin":false},"body":"can you expand or maybe just fix it? :slightly_smiling_face: ","created_at":"2017-12-21T17:59:14Z","updated_at":"2017-12-21T17:59:15Z","html_url":"https://github.com/snapcore/snapcraft/pull/1817#discussion_r158340293","pull_request_url":"https://api.github.com/repos/snapcore/snapcraft/pulls/1817","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/snapcore/snapcraft/pulls/comments/158340293"},"html":{"href":"https://github.com/snapcore/snapcraft/pull/1817#discussion_r158340293"},"pull_request":{"href":"https://api.github.com/repos/snapcore/snapcraft/pulls/1817"}},"in_reply_to_id":158332930},"pull_request":{"url":"https://api.github.com/repos/snapcore/snapcraft/pulls/1817","id":159155136,"html_url":"https://github.com/snapcore/snapcraft/pull/1817","diff_url":"https://github.com/snapcore/snapcraft/pull/1817.diff","patch_url":"https://github.com/snapcore/snapcraft/pull/1817.patch","issue_url":"https://api.github.com/repos/snapcore/snapcraft/issues/1817","number":1817,"state":"open","locked":false,"title":"grammar: support strings","user":{"login":"kalikiana","id":1204189,"avatar_url":"https://avatars0.githubusercontent.com/u/1204189?v=4","gravatar_id":"","url":"https://api.github.com/users/kalikiana","html_url":"https://github.com/kalikiana","followers_url":"https://api.github.com/users/kalikiana/followers","following_url":"https://api.github.com/users/kalikiana/following{/other_user}","gists_url":"https://api.github.com/users/kalikiana/gists{/gist_id}","starred_url":"https://api.github.com/users/kalikiana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalikiana/subscriptions","organizations_url":"https://api.github.com/users/kalikiana/orgs","repos_url":"https://api.github.com/users/kalikiana/repos","events_url":"https://api.github.com/users/kalikiana/events{/privacy}","received_events_url":"https://api.github.com/users/kalikiana/received_events","type":"User","site_admin":false},"body":"- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?\r\n- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?\r\n- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?\r\n- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?\r\n- [x] Have you successfully run `./runtests.sh static`?\r\n- [x] Have you successfully run `./runtests.sh unit`?\r\n\r\n-----\r\nThis adds generic support for processing grammar of string values. `source` is the first property to support it, although adding more should be just a matter of updating the schema.\r\n\r\nCloses: #1686 ","created_at":"2017-12-19T12:31:49Z","updated_at":"2017-12-21T17:59:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8b81c2d4042b5bc35decd689bb8a54d975204bd9","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/snapcore/snapcraft/pulls/1817/commits","review_comments_url":"https://api.github.com/repos/snapcore/snapcraft/pulls/1817/comments","review_comment_url":"https://api.github.com/repos/snapcore/snapcraft/pulls/comments{/number}","comments_url":"https://api.github.com/repos/snapcore/snapcraft/issues/1817/comments","statuses_url":"https://api.github.com/repos/snapcore/snapcraft/statuses/a7cf9a50ddb73f14b1c489a47b2e10ba024086c5","head":{"label":"kalikiana:grammar-strings","ref":"grammar-strings","sha":"a7cf9a50ddb73f14b1c489a47b2e10ba024086c5","user":{"login":"kalikiana","id":1204189,"avatar_url":"https://avatars0.githubusercontent.com/u/1204189?v=4","gravatar_id":"","url":"https://api.github.com/users/kalikiana","html_url":"https://github.com/kalikiana","followers_url":"https://api.github.com/users/kalikiana/followers","following_url":"https://api.github.com/users/kalikiana/following{/other_user}","gists_url":"https://api.github.com/users/kalikiana/gists{/gist_id}","starred_url":"https://api.github.com/users/kalikiana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalikiana/subscriptions","organizations_url":"https://api.github.com/users/kalikiana/orgs","repos_url":"https://api.github.com/users/kalikiana/repos","events_url":"https://api.github.com/users/kalikiana/events{/privacy}","received_events_url":"https://api.github.com/users/kalikiana/received_events","type":"User","site_admin":false},"repo":{"id":73799360,"name":"snapcraft","full_name":"kalikiana/snapcraft","owner":{"login":"kalikiana","id":1204189,"avatar_url":"https://avatars0.githubusercontent.com/u/1204189?v=4","gravatar_id":"","url":"https://api.github.com/users/kalikiana","html_url":"https://github.com/kalikiana","followers_url":"https://api.github.com/users/kalikiana/followers","following_url":"https://api.github.com/users/kalikiana/following{/other_user}","gists_url":"https://api.github.com/users/kalikiana/gists{/gist_id}","starred_url":"https://api.github.com/users/kalikiana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalikiana/subscriptions","organizations_url":"https://api.github.com/users/kalikiana/orgs","repos_url":"https://api.github.com/users/kalikiana/repos","events_url":"https://api.github.com/users/kalikiana/events{/privacy}","received_events_url":"https://api.github.com/users/kalikiana/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kalikiana/snapcraft","description":"Snapcraft is a delightful packaging tool","fork":true,"url":"https://api.github.com/repos/kalikiana/snapcraft","forks_url":"https://api.github.com/repos/kalikiana/snapcraft/forks","keys_url":"https://api.github.com/repos/kalikiana/snapcraft/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kalikiana/snapcraft/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kalikiana/snapcraft/teams","hooks_url":"https://api.github.com/repos/kalikiana/snapcraft/hooks","issue_events_url":"https://api.github.com/repos/kalikiana/snapcraft/issues/events{/number}","events_url":"https://api.github.com/repos/kalikiana/snapcraft/events","assignees_url":"https://api.github.com/repos/kalikiana/snapcraft/assignees{/user}","branches_url":"https://api.github.com/repos/kalikiana/snapcraft/branches{/branch}","tags_url":"https://api.github.com/repos/kalikiana/snapcraft/tags","blobs_url":"https://api.github.com/repos/kalikiana/snapcraft/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kalikiana/snapcraft/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kalikiana/snapcraft/git/refs{/sha}","trees_url":"https://api.github.com/repos/kalikiana/snapcraft/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kalikiana/snapcraft/statuses/{sha}","languages_url":"https://api.github.com/repos/kalikiana/snapcraft/languages","stargazers_url":"https://api.github.com/repos/kalikiana/snapcraft/stargazers","contributors_url":"https://api.github.com/repos/kalikiana/snapcraft/contributors","subscribers_url":"https://api.github.com/repos/kalikiana/snapcraft/subscribers","subscription_url":"https://api.github.com/repos/kalikiana/snapcraft/subscription","commits_url":"https://api.github.com/repos/kalikiana/snapcraft/commits{/sha}","git_commits_url":"https://api.github.com/repos/kalikiana/snapcraft/git/commits{/sha}","comments_url":"https://api.github.com/repos/kalikiana/snapcraft/comments{/number}","issue_comment_url":"https://api.github.com/repos/kalikiana/snapcraft/issues/comments{/number}","contents_url":"https://api.github.com/repos/kalikiana/snapcraft/contents/{+path}","compare_url":"https://api.github.com/repos/kalikiana/snapcraft/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kalikiana/snapcraft/merges","archive_url":"https://api.github.com/repos/kalikiana/snapcraft/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kalikiana/snapcraft/downloads","issues_url":"https://api.github.com/repos/kalikiana/snapcraft/issues{/number}","pulls_url":"https://api.github.com/repos/kalikiana/snapcraft/pulls{/number}","milestones_url":"https://api.github.com/repos/kalikiana/snapcraft/milestones{/number}","notifications_url":"https://api.github.com/repos/kalikiana/snapcraft/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kalikiana/snapcraft/labels{/name}","releases_url":"https://api.github.com/repos/kalikiana/snapcraft/releases{/id}","deployments_url":"https://api.github.com/repos/kalikiana/snapcraft/deployments","created_at":"2016-11-15T09:45:46Z","updated_at":"2016-11-15T09:45:48Z","pushed_at":"2017-12-21T17:15:49Z","git_url":"git://github.com/kalikiana/snapcraft.git","ssh_url":"git@github.com:kalikiana/snapcraft.git","clone_url":"https://github.com/kalikiana/snapcraft.git","svn_url":"https://github.com/kalikiana/snapcraft","homepage":null,"size":8878,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"snapcore:master","ref":"master","sha":"89ce407184371f63e38280ea4f2c48b21d06bf1c","user":{"login":"snapcore","id":19532717,"avatar_url":"https://avatars1.githubusercontent.com/u/19532717?v=4","gravatar_id":"","url":"https://api.github.com/users/snapcore","html_url":"https://github.com/snapcore","followers_url":"https://api.github.com/users/snapcore/followers","following_url":"https://api.github.com/users/snapcore/following{/other_user}","gists_url":"https://api.github.com/users/snapcore/gists{/gist_id}","starred_url":"https://api.github.com/users/snapcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snapcore/subscriptions","organizations_url":"https://api.github.com/users/snapcore/orgs","repos_url":"https://api.github.com/users/snapcore/repos","events_url":"https://api.github.com/users/snapcore/events{/privacy}","received_events_url":"https://api.github.com/users/snapcore/received_events","type":"Organization","site_admin":false},"repo":{"id":45199136,"name":"snapcraft","full_name":"snapcore/snapcraft","owner":{"login":"snapcore","id":19532717,"avatar_url":"https://avatars1.githubusercontent.com/u/19532717?v=4","gravatar_id":"","url":"https://api.github.com/users/snapcore","html_url":"https://github.com/snapcore","followers_url":"https://api.github.com/users/snapcore/followers","following_url":"https://api.github.com/users/snapcore/following{/other_user}","gists_url":"https://api.github.com/users/snapcore/gists{/gist_id}","starred_url":"https://api.github.com/users/snapcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snapcore/subscriptions","organizations_url":"https://api.github.com/users/snapcore/orgs","repos_url":"https://api.github.com/users/snapcore/repos","events_url":"https://api.github.com/users/snapcore/events{/privacy}","received_events_url":"https://api.github.com/users/snapcore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/snapcore/snapcraft","description":"Snapcraft is a delightful packaging tool","fork":false,"url":"https://api.github.com/repos/snapcore/snapcraft","forks_url":"https://api.github.com/repos/snapcore/snapcraft/forks","keys_url":"https://api.github.com/repos/snapcore/snapcraft/keys{/key_id}","collaborators_url":"https://api.github.com/repos/snapcore/snapcraft/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/snapcore/snapcraft/teams","hooks_url":"https://api.github.com/repos/snapcore/snapcraft/hooks","issue_events_url":"https://api.github.com/repos/snapcore/snapcraft/issues/events{/number}","events_url":"https://api.github.com/repos/snapcore/snapcraft/events","assignees_url":"https://api.github.com/repos/snapcore/snapcraft/assignees{/user}","branches_url":"https://api.github.com/repos/snapcore/snapcraft/branches{/branch}","tags_url":"https://api.github.com/repos/snapcore/snapcraft/tags","blobs_url":"https://api.github.com/repos/snapcore/snapcraft/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/snapcore/snapcraft/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/snapcore/snapcraft/git/refs{/sha}","trees_url":"https://api.github.com/repos/snapcore/snapcraft/git/trees{/sha}","statuses_url":"https://api.github.com/repos/snapcore/snapcraft/statuses/{sha}","languages_url":"https://api.github.com/repos/snapcore/snapcraft/languages","stargazers_url":"https://api.github.com/repos/snapcore/snapcraft/stargazers","contributors_url":"https://api.github.com/repos/snapcore/snapcraft/contributors","subscribers_url":"https://api.github.com/repos/snapcore/snapcraft/subscribers","subscription_url":"https://api.github.com/repos/snapcore/snapcraft/subscription","commits_url":"https://api.github.com/repos/snapcore/snapcraft/commits{/sha}","git_commits_url":"https://api.github.com/repos/snapcore/snapcraft/git/commits{/sha}","comments_url":"https://api.github.com/repos/snapcore/snapcraft/comments{/number}","issue_comment_url":"https://api.github.com/repos/snapcore/snapcraft/issues/comments{/number}","contents_url":"https://api.github.com/repos/snapcore/snapcraft/contents/{+path}","compare_url":"https://api.github.com/repos/snapcore/snapcraft/compare/{base}...{head}","merges_url":"https://api.github.com/repos/snapcore/snapcraft/merges","archive_url":"https://api.github.com/repos/snapcore/snapcraft/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/snapcore/snapcraft/downloads","issues_url":"https://api.github.com/repos/snapcore/snapcraft/issues{/number}","pulls_url":"https://api.github.com/repos/snapcore/snapcraft/pulls{/number}","milestones_url":"https://api.github.com/repos/snapcore/snapcraft/milestones{/number}","notifications_url":"https://api.github.com/repos/snapcore/snapcraft/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/snapcore/snapcraft/labels{/name}","releases_url":"https://api.github.com/repos/snapcore/snapcraft/releases{/id}","deployments_url":"https://api.github.com/repos/snapcore/snapcraft/deployments","created_at":"2015-10-29T17:23:15Z","updated_at":"2017-12-20T20:30:52Z","pushed_at":"2017-12-21T17:47:52Z","git_url":"git://github.com/snapcore/snapcraft.git","ssh_url":"git@github.com:snapcore/snapcraft.git","clone_url":"https://github.com/snapcore/snapcraft.git","svn_url":"https://github.com/snapcore/snapcraft","homepage":null,"size":8382,"stargazers_count":462,"watchers_count":462,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":227,"mirror_url":null,"archived":false,"open_issues_count":86,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":227,"open_issues":86,"watchers":462,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/snapcore/snapcraft/pulls/1817"},"html":{"href":"https://github.com/snapcore/snapcraft/pull/1817"},"issue":{"href":"https://api.github.com/repos/snapcore/snapcraft/issues/1817"},"comments":{"href":"https://api.github.com/repos/snapcore/snapcraft/issues/1817/comments"},"review_comments":{"href":"https://api.github.com/repos/snapcore/snapcraft/pulls/1817/comments"},"review_comment":{"href":"https://api.github.com/repos/snapcore/snapcraft/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/snapcore/snapcraft/pulls/1817/commits"},"statuses":{"href":"https://api.github.com/repos/snapcore/snapcraft/statuses/a7cf9a50ddb73f14b1c489a47b2e10ba024086c5"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"sergiusens"}}