{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/vscode/issues/35322","repository_url":"https://api.github.com/repos/Microsoft/vscode","labels_url":"https://api.github.com/repos/Microsoft/vscode/issues/35322/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/vscode/issues/35322/comments","events_url":"https://api.github.com/repos/Microsoft/vscode/issues/35322/events","html_url":"https://github.com/Microsoft/vscode/issues/35322","id":261351797,"number":35322,"title":"Modernize Snippets","user":{"login":"jrieken","id":1794099,"avatar_url":"https://avatars2.githubusercontent.com/u/1794099?v=4","gravatar_id":"","url":"https://api.github.com/users/jrieken","html_url":"https://github.com/jrieken","followers_url":"https://api.github.com/users/jrieken/followers","following_url":"https://api.github.com/users/jrieken/following{/other_user}","gists_url":"https://api.github.com/users/jrieken/gists{/gist_id}","starred_url":"https://api.github.com/users/jrieken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrieken/subscriptions","organizations_url":"https://api.github.com/users/jrieken/orgs","repos_url":"https://api.github.com/users/jrieken/repos","events_url":"https://api.github.com/users/jrieken/events{/privacy}","received_events_url":"https://api.github.com/users/jrieken/received_events","type":"User","site_admin":false},"labels":[{"id":335611370,"url":"https://api.github.com/repos/Microsoft/vscode/labels/good%20first%20issue","name":"good first issue","color":"fef2c0","default":true},{"id":256129996,"url":"https://api.github.com/repos/Microsoft/vscode/labels/help%20wanted","name":"help wanted","color":"fef2c0","default":true},{"id":291124272,"url":"https://api.github.com/repos/Microsoft/vscode/labels/javascript","name":"javascript","color":"1d76db","default":false},{"id":403204290,"url":"https://api.github.com/repos/Microsoft/vscode/labels/snippets","name":"snippets","color":"c5def5","default":false},{"id":291055694,"url":"https://api.github.com/repos/Microsoft/vscode/labels/typescript","name":"typescript","color":"1d76db","default":false},{"id":400270121,"url":"https://api.github.com/repos/Microsoft/vscode/labels/verification-needed","name":"verification-needed","color":"d4c5f9","default":false}],"state":"open","locked":false,"assignee":{"login":"mjbvz","id":12821956,"avatar_url":"https://avatars2.githubusercontent.com/u/12821956?v=4","gravatar_id":"","url":"https://api.github.com/users/mjbvz","html_url":"https://github.com/mjbvz","followers_url":"https://api.github.com/users/mjbvz/followers","following_url":"https://api.github.com/users/mjbvz/following{/other_user}","gists_url":"https://api.github.com/users/mjbvz/gists{/gist_id}","starred_url":"https://api.github.com/users/mjbvz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjbvz/subscriptions","organizations_url":"https://api.github.com/users/mjbvz/orgs","repos_url":"https://api.github.com/users/mjbvz/repos","events_url":"https://api.github.com/users/mjbvz/events{/privacy}","received_events_url":"https://api.github.com/users/mjbvz/received_events","type":"User","site_admin":false},"assignees":[{"login":"mjbvz","id":12821956,"avatar_url":"https://avatars2.githubusercontent.com/u/12821956?v=4","gravatar_id":"","url":"https://api.github.com/users/mjbvz","html_url":"https://github.com/mjbvz","followers_url":"https://api.github.com/users/mjbvz/followers","following_url":"https://api.github.com/users/mjbvz/following{/other_user}","gists_url":"https://api.github.com/users/mjbvz/gists{/gist_id}","starred_url":"https://api.github.com/users/mjbvz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjbvz/subscriptions","organizations_url":"https://api.github.com/users/mjbvz/orgs","repos_url":"https://api.github.com/users/mjbvz/repos","events_url":"https://api.github.com/users/mjbvz/events{/privacy}","received_events_url":"https://api.github.com/users/mjbvz/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/Microsoft/vscode/milestones/52","html_url":"https://github.com/Microsoft/vscode/milestone/52","labels_url":"https://api.github.com/repos/Microsoft/vscode/milestones/52/labels","id":2743006,"number":52,"title":"October 2017","description":"","creator":{"login":"weinand","id":1898161,"avatar_url":"https://avatars0.githubusercontent.com/u/1898161?v=4","gravatar_id":"","url":"https://api.github.com/users/weinand","html_url":"https://github.com/weinand","followers_url":"https://api.github.com/users/weinand/followers","following_url":"https://api.github.com/users/weinand/following{/other_user}","gists_url":"https://api.github.com/users/weinand/gists{/gist_id}","starred_url":"https://api.github.com/users/weinand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weinand/subscriptions","organizations_url":"https://api.github.com/users/weinand/orgs","repos_url":"https://api.github.com/users/weinand/repos","events_url":"https://api.github.com/users/weinand/events{/privacy}","received_events_url":"https://api.github.com/users/weinand/received_events","type":"User","site_admin":false},"open_issues":86,"closed_issues":411,"state":"open","created_at":"2017-09-04T12:33:25Z","updated_at":"2017-10-31T15:28:16Z","due_on":"2017-11-03T07:00:00Z","closed_at":null},"comments":4,"created_at":"2017-09-28T15:02:46Z","updated_at":"2017-10-31T15:32:21Z","closed_at":null,"author_association":"MEMBER","body":"The TypeScript extension ships some old-school snippets, like a for-loop snippet using var and not a for-of-loop snippet. We should revisit those"},"comment":{"url":"https://api.github.com/repos/Microsoft/vscode/issues/comments/340800608","html_url":"https://github.com/Microsoft/vscode/issues/35322#issuecomment-340800608","issue_url":"https://api.github.com/repos/Microsoft/vscode/issues/35322","id":340800608,"user":{"login":"prog-rajkamal","id":11518519,"avatar_url":"https://avatars2.githubusercontent.com/u/11518519?v=4","gravatar_id":"","url":"https://api.github.com/users/prog-rajkamal","html_url":"https://github.com/prog-rajkamal","followers_url":"https://api.github.com/users/prog-rajkamal/followers","following_url":"https://api.github.com/users/prog-rajkamal/following{/other_user}","gists_url":"https://api.github.com/users/prog-rajkamal/gists{/gist_id}","starred_url":"https://api.github.com/users/prog-rajkamal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prog-rajkamal/subscriptions","organizations_url":"https://api.github.com/users/prog-rajkamal/orgs","repos_url":"https://api.github.com/users/prog-rajkamal/repos","events_url":"https://api.github.com/users/prog-rajkamal/events{/privacy}","received_events_url":"https://api.github.com/users/prog-rajkamal/received_events","type":"User","site_admin":false},"created_at":"2017-10-31T15:32:20Z","updated_at":"2017-10-31T15:32:20Z","author_association":"CONTRIBUTOR","body":"Okay, this is embarrassing. Well I somehow missed snippets file in typescript directory (no idea how i thappened).\r\n\r\nSo, I added it in javascript snippets which _did_ work for  typescript.\r\n \r\n--------------------------\r\n\r\nRight now, I am checking in vscode 1.17.2 .\r\n\r\n\"For of\" and \"For in\" are implemented  with both let and const variants (though they share the same shortcut [`fof` and `fin`])\r\n\r\n\r\nTypescript `for loop` , however, still uses `var`. \r\n\r\nI suggest I make the change `var` to `let` and you review the PR. \r\n\r\n@jrieken your thoughts?\r\n"}}
{"actor":{"display_login":"prog-rajkamal"}}