{"action":"created","issue":{"url":"https://api.github.com/repos/lxde/libqtxdg/issues/119","repository_url":"https://api.github.com/repos/lxde/libqtxdg","labels_url":"https://api.github.com/repos/lxde/libqtxdg/issues/119/labels{/name}","comments_url":"https://api.github.com/repos/lxde/libqtxdg/issues/119/comments","events_url":"https://api.github.com/repos/lxde/libqtxdg/issues/119/events","html_url":"https://github.com/lxde/libqtxdg/pull/119","id":217509936,"number":119,"title":"Support symbolic SVG icons","user":{"login":"tsujan","id":981076,"avatar_url":"https://avatars0.githubusercontent.com/u/981076?v=3","gravatar_id":"","url":"https://api.github.com/users/tsujan","html_url":"https://github.com/tsujan","followers_url":"https://api.github.com/users/tsujan/followers","following_url":"https://api.github.com/users/tsujan/following{/other_user}","gists_url":"https://api.github.com/users/tsujan/gists{/gist_id}","starred_url":"https://api.github.com/users/tsujan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsujan/subscriptions","organizations_url":"https://api.github.com/users/tsujan/orgs","repos_url":"https://api.github.com/users/tsujan/repos","events_url":"https://api.github.com/users/tsujan/events{/privacy}","received_events_url":"https://api.github.com/users/tsujan/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":23,"created_at":"2017-03-28T10:08:47Z","updated_at":"2017-03-28T12:40:03Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/lxde/libqtxdg/pulls/119","html_url":"https://github.com/lxde/libqtxdg/pull/119","diff_url":"https://github.com/lxde/libqtxdg/pull/119.diff","patch_url":"https://github.com/lxde/libqtxdg/pull/119.patch"},"body":"Fixes https://github.com/lxde/lxqt/issues/1181.\r\n\r\nThat means changing their colors so that they always have a high contrast with their backgrounds. Symbolic icons should have SVG stylesheets (as the Breeze icons do) and the style engine should support them (as the Breeze and Kvantum styles do).\r\n\r\nThe code is stolen from KDE's `kiconloader.cpp` (see the comments).\r\n\r\nCurrently Panel and those LXQt apps that use stylesheets will show the wrong icon color if their stylesheets have a high contrast with the active Qt style. This issue should be fixed in their codes before this PR is merged."},"comment":{"url":"https://api.github.com/repos/lxde/libqtxdg/issues/comments/289756567","html_url":"https://github.com/lxde/libqtxdg/pull/119#issuecomment-289756567","issue_url":"https://api.github.com/repos/lxde/libqtxdg/issues/119","id":289756567,"user":{"login":"palinek","id":10990929,"avatar_url":"https://avatars0.githubusercontent.com/u/10990929?v=3","gravatar_id":"","url":"https://api.github.com/users/palinek","html_url":"https://github.com/palinek","followers_url":"https://api.github.com/users/palinek/followers","following_url":"https://api.github.com/users/palinek/following{/other_user}","gists_url":"https://api.github.com/users/palinek/gists{/gist_id}","starred_url":"https://api.github.com/users/palinek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palinek/subscriptions","organizations_url":"https://api.github.com/users/palinek/orgs","repos_url":"https://api.github.com/users/palinek/repos","events_url":"https://api.github.com/users/palinek/events{/privacy}","received_events_url":"https://api.github.com/users/palinek/received_events","type":"User","site_admin":false},"created_at":"2017-03-28T12:40:03Z","updated_at":"2017-03-28T12:40:03Z","body":"> OK! You're right. My hypotheses were wrong. svgIcon is parsed before. I'll try to add FollowsColorScheme.\r\n\r\nI'm allready on it... but found some problem outside this PR."}}
{"actor":{"display_login":"palinek"}}