{"action":"opened","issue":{"url":"https://api.github.com/repos/angular/flex-layout/issues/326","repository_url":"https://api.github.com/repos/angular/flex-layout","labels_url":"https://api.github.com/repos/angular/flex-layout/issues/326/labels{/name}","comments_url":"https://api.github.com/repos/angular/flex-layout/issues/326/comments","events_url":"https://api.github.com/repos/angular/flex-layout/issues/326/events","html_url":"https://github.com/angular/flex-layout/issues/326","id":238248436,"number":326,"title":"Flex-layout needs to upgrade to Renderer2","user":{"login":"matsko","id":93018,"avatar_url":"https://avatars1.githubusercontent.com/u/93018?v=3","gravatar_id":"","url":"https://api.github.com/users/matsko","html_url":"https://github.com/matsko","followers_url":"https://api.github.com/users/matsko/followers","following_url":"https://api.github.com/users/matsko/following{/other_user}","gists_url":"https://api.github.com/users/matsko/gists{/gist_id}","starred_url":"https://api.github.com/users/matsko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matsko/subscriptions","organizations_url":"https://api.github.com/users/matsko/orgs","repos_url":"https://api.github.com/users/matsko/repos","events_url":"https://api.github.com/users/matsko/events{/privacy}","received_events_url":"https://api.github.com/users/matsko/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-06-23T20:41:09Z","updated_at":"2017-06-23T20:41:09Z","closed_at":null,"body":"There have been some recent refactorings in angular/angular that change NgClass and other directives to use Renderer2 instead of Renderer. While this change is transparent to the public API of Angular, it is still a change that causes issues to code that extends the base directives that Angular has to offer.\r\n\r\nWith flex-layout, the NgClass, NgStyle and other directives are extended. This is an anti-pattern and isn't encouraged by Angular itself. Therefore there are two things that need to be changed in flex-layouts so that it's compatible with future versions of Angular.\r\n\r\n1) Use Renderer2 instead of Renderer\r\n2) Do not extend the Angular base directives, but instead inject them into the constructor.\r\n\r\nOnce this code changes have been made then flex-layouts can work with both Angular4 and Angular5."}}
{"actor":{"display_login":"matsko"}}