{"action":"created","issue":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/25568","repository_url":"https://api.github.com/repos/NixOS/nixpkgs","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/25568/labels{/name}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/25568/comments","events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/25568/events","html_url":"https://github.com/NixOS/nixpkgs/pull/25568","id":226806544,"number":25568,"title":"go: 1.8 -> 1.8.1","user":{"login":"sigma","id":16090,"avatar_url":"https://avatars1.githubusercontent.com/u/16090?v=3","gravatar_id":"","url":"https://api.github.com/users/sigma","html_url":"https://github.com/sigma","followers_url":"https://api.github.com/users/sigma/followers","following_url":"https://api.github.com/users/sigma/following{/other_user}","gists_url":"https://api.github.com/users/sigma/gists{/gist_id}","starred_url":"https://api.github.com/users/sigma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sigma/subscriptions","organizations_url":"https://api.github.com/users/sigma/orgs","repos_url":"https://api.github.com/users/sigma/repos","events_url":"https://api.github.com/users/sigma/events{/privacy}","received_events_url":"https://api.github.com/users/sigma/received_events","type":"User","site_admin":false},"labels":[{"id":290122819,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/8.has:%20package%20(update)","name":"8.has: package (update)","color":"009800","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-05-06T21:47:24Z","updated_at":"2017-05-07T16:45:15Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/25568","html_url":"https://github.com/NixOS/nixpkgs/pull/25568","diff_url":"https://github.com/NixOS/nixpkgs/pull/25568.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/25568.patch"},"body":"###### Motivation for this change\r\n\r\n1.8.1 fixes some issues with MacOS Sierra (https://github.com/golang/go/issues/19734)\r\nas part of this, a fix for https://github.com/golang/go/issues/19772 is bringing to light a bug in the way we invoke `dsymutil`, which happens to be a stub in darwin `cctools` (during the build), and generally `/usr/bin/dsymutil` at runtime.\r\nI'm not entirely sure of the correctness of the fix though, so feedback highly welcome !\r\n\r\nI ran `nox-review` on both MacOS and NixOS, and some compilations failed (like `gcsfuse` and `qsyncthingtray` on NixOS, `consul`, `heroku` and `cadvisor` on MacOS) but as far as I can tell are already failing in master.\r\n\r\n###### Things done\r\n\r\n- [x] Tested using sandboxing\r\n  ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS,\r\n    or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file)\r\n    on non-NixOS)\r\n- Built on platform(s)\r\n   - [x] NixOS\r\n   - [x] macOS\r\n   - [ ] Linux\r\n- [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [ ] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments/299718543","html_url":"https://github.com/NixOS/nixpkgs/pull/25568#issuecomment-299718543","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/25568","id":299718543,"user":{"login":"sigma","id":16090,"avatar_url":"https://avatars1.githubusercontent.com/u/16090?v=3","gravatar_id":"","url":"https://api.github.com/users/sigma","html_url":"https://github.com/sigma","followers_url":"https://api.github.com/users/sigma/followers","following_url":"https://api.github.com/users/sigma/following{/other_user}","gists_url":"https://api.github.com/users/sigma/gists{/gist_id}","starred_url":"https://api.github.com/users/sigma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sigma/subscriptions","organizations_url":"https://api.github.com/users/sigma/orgs","repos_url":"https://api.github.com/users/sigma/repos","events_url":"https://api.github.com/users/sigma/events{/privacy}","received_events_url":"https://api.github.com/users/sigma/received_events","type":"User","site_admin":false},"created_at":"2017-05-07T16:45:15Z","updated_at":"2017-05-07T16:45:15Z","body":"@LnL7 yep, clang 4 works too"}}
{"actor":{"display_login":"sigma"}}