{"action":"created","issue":{"url":"https://api.github.com/repos/tectonic-typesetting/tectonic/issues/107","repository_url":"https://api.github.com/repos/tectonic-typesetting/tectonic","labels_url":"https://api.github.com/repos/tectonic-typesetting/tectonic/issues/107/labels{/name}","comments_url":"https://api.github.com/repos/tectonic-typesetting/tectonic/issues/107/comments","events_url":"https://api.github.com/repos/tectonic-typesetting/tectonic/issues/107/events","html_url":"https://github.com/tectonic-typesetting/tectonic/pull/107","id":236728746,"number":107,"title":"C cleanups","user":{"login":"ronnychevalier","id":7366035,"avatar_url":"https://avatars3.githubusercontent.com/u/7366035?v=3","gravatar_id":"","url":"https://api.github.com/users/ronnychevalier","html_url":"https://github.com/ronnychevalier","followers_url":"https://api.github.com/users/ronnychevalier/followers","following_url":"https://api.github.com/users/ronnychevalier/following{/other_user}","gists_url":"https://api.github.com/users/ronnychevalier/gists{/gist_id}","starred_url":"https://api.github.com/users/ronnychevalier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ronnychevalier/subscriptions","organizations_url":"https://api.github.com/users/ronnychevalier/orgs","repos_url":"https://api.github.com/users/ronnychevalier/repos","events_url":"https://api.github.com/users/ronnychevalier/events{/privacy}","received_events_url":"https://api.github.com/users/ronnychevalier/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2017-06-18T15:47:21Z","updated_at":"2017-06-21T12:39:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/tectonic-typesetting/tectonic/pulls/107","html_url":"https://github.com/tectonic-typesetting/tectonic/pull/107","diff_url":"https://github.com/tectonic-typesetting/tectonic/pull/107.diff","patch_url":"https://github.com/tectonic-typesetting/tectonic/pull/107.patch"},"body":"Another batch of cleanups for the C code in `tectonic/`."},"comment":{"url":"https://api.github.com/repos/tectonic-typesetting/tectonic/issues/comments/310065821","html_url":"https://github.com/tectonic-typesetting/tectonic/pull/107#issuecomment-310065821","issue_url":"https://api.github.com/repos/tectonic-typesetting/tectonic/issues/107","id":310065821,"user":{"login":"pkgw","id":59598,"avatar_url":"https://avatars3.githubusercontent.com/u/59598?v=3","gravatar_id":"","url":"https://api.github.com/users/pkgw","html_url":"https://github.com/pkgw","followers_url":"https://api.github.com/users/pkgw/followers","following_url":"https://api.github.com/users/pkgw/following{/other_user}","gists_url":"https://api.github.com/users/pkgw/gists{/gist_id}","starred_url":"https://api.github.com/users/pkgw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkgw/subscriptions","organizations_url":"https://api.github.com/users/pkgw/orgs","repos_url":"https://api.github.com/users/pkgw/repos","events_url":"https://api.github.com/users/pkgw/events{/privacy}","received_events_url":"https://api.github.com/users/pkgw/received_events","type":"User","site_admin":false},"created_at":"2017-06-21T12:39:34Z","updated_at":"2017-06-21T12:39:34Z","body":"- OK, if `inline` is specified in C99, I'm happy to use it. There's a part of me that still feels a little uncomfortable using some C99 constructs, but seriously, the standard is almost 20 years old at this point. The discomfort says more about when I started learning C (before 1999!) than it does about what's portable.\r\n- Thanks for explaining the `_ptr` suffix. I can't say that it feels especially \"right\" to me, but it's fine to keep the function with the suffix as-is. For what it's worth I have the impression that systemd has lots of careful, clean C code, so if the suffix is coming from their style that genuinely encourages me to give it a try.\r\n- Accesses like `mem[q].hh.u.B0` are basically accesses to fields of the various structures used by the TeX engine. TeX manages memory manually by manipulating \"pointers\" (offsets) within its big loosely-typed `mem` array. Because of the way the WEB2C translation works, unfortunately the symbolic information was all lost in the translation to C. I'd really like to make all of these references symbolic again, but I have trouble seeing how to make the change incrementally, which means it would be a very big project."}}
{"actor":{"display_login":"pkgw"}}