{"action":"created","comment":{"url":"https://api.github.com/repos/projectcalico/calicoctl/pulls/comments/143311765","pull_request_review_id":67813454,"id":143311765,"diff_hunk":"@@ -0,0 +1,57 @@\n+// Copyright (c) 2017 Tigera, Inc. All rights reserved.\n+\n+// Licensed under the Apache License, Version 2.0 (the \"License\");\n+// you may not use this file except in compliance with the License.\n+// You may obtain a copy of the License at\n+//\n+//     http://www.apache.org/licenses/LICENSE-2.0\n+//\n+// Unless required by applicable law or agreed to in writing, software\n+// distributed under the License is distributed on an \"AS IS\" BASIS,\n+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+// See the License for the specific language governing permissions and\n+// limitations under the License.\n+\n+package resourcemgr\n+\n+import (\n+\t\"context\"\n+\n+\tapi \"github.com/projectcalico/libcalico-go/lib/apiv2\"\n+\tclient \"github.com/projectcalico/libcalico-go/lib/clientv2\"\n+\t\"github.com/projectcalico/libcalico-go/lib/options\"\n+)\n+\n+func init() {\n+\tregisterResource(\n+\t\tapi.NewBGPConfiguration(),\n+\t\tapi.NewBGPConfigurationList(),\n+\t\tfalse,\n+\t\t[]string{\"bgpconfiguration\", \"bgpconfigurations\", \"bgpconfig\", \"bgpconfigs\"},\n+\t\t[]string{\"NAME\"},","path":"calicoctl/resourcemgr/bgpconfig.go","position":31,"original_position":31,"commit_id":"fc406e6ce15681adafa6ecd1e84c690493b8f515","original_commit_id":"fc406e6ce15681adafa6ecd1e84c690493b8f515","user":{"login":"robbrockbank","id":3227729,"avatar_url":"https://avatars0.githubusercontent.com/u/3227729?v=4","gravatar_id":"","url":"https://api.github.com/users/robbrockbank","html_url":"https://github.com/robbrockbank","followers_url":"https://api.github.com/users/robbrockbank/followers","following_url":"https://api.github.com/users/robbrockbank/following{/other_user}","gists_url":"https://api.github.com/users/robbrockbank/gists{/gist_id}","starred_url":"https://api.github.com/users/robbrockbank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robbrockbank/subscriptions","organizations_url":"https://api.github.com/users/robbrockbank/orgs","repos_url":"https://api.github.com/users/robbrockbank/repos","events_url":"https://api.github.com/users/robbrockbank/events{/privacy}","received_events_url":"https://api.github.com/users/robbrockbank/received_events","type":"User","site_admin":false},"body":"you might need to do some magic to handle nil values in the go template below. \r\n\r\nfor now, maybe just display nil as a dash...?","created_at":"2017-10-06T23:21:35Z","updated_at":"2017-10-06T23:21:35Z","html_url":"https://github.com/projectcalico/calicoctl/pull/1715#discussion_r143311765","pull_request_url":"https://api.github.com/repos/projectcalico/calicoctl/pulls/1715","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/projectcalico/calicoctl/pulls/comments/143311765"},"html":{"href":"https://github.com/projectcalico/calicoctl/pull/1715#discussion_r143311765"},"pull_request":{"href":"https://api.github.com/repos/projectcalico/calicoctl/pulls/1715"}},"in_reply_to_id":143311648},"pull_request":{"url":"https://api.github.com/repos/projectcalico/calicoctl/pulls/1715","id":145262714,"html_url":"https://github.com/projectcalico/calicoctl/pull/1715","diff_url":"https://github.com/projectcalico/calicoctl/pull/1715.diff","patch_url":"https://github.com/projectcalico/calicoctl/pull/1715.patch","issue_url":"https://api.github.com/repos/projectcalico/calicoctl/issues/1715","number":1715,"state":"open","locked":false,"title":"Added calicoctl ability to operate on bgpconfig, felixconfig, and clusterinfo","user":{"login":"mgleung","id":1366219,"avatar_url":"https://avatars0.githubusercontent.com/u/1366219?v=4","gravatar_id":"","url":"https://api.github.com/users/mgleung","html_url":"https://github.com/mgleung","followers_url":"https://api.github.com/users/mgleung/followers","following_url":"https://api.github.com/users/mgleung/following{/other_user}","gists_url":"https://api.github.com/users/mgleung/gists{/gist_id}","starred_url":"https://api.github.com/users/mgleung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgleung/subscriptions","organizations_url":"https://api.github.com/users/mgleung/orgs","repos_url":"https://api.github.com/users/mgleung/repos","events_url":"https://api.github.com/users/mgleung/events{/privacy}","received_events_url":"https://api.github.com/users/mgleung/received_events","type":"User","site_admin":false},"body":"## Description\r\nAdded the resource types and commands for `FelixConfiguration`, `BGPConfiguration`, and `ClusterInformation`.  Also added the tests against the basic operations.\r\n\r\n## Todos\r\n- [x] Tests\r\n- [x] Documentation (not needed here)\r\n- [x] Release note\r\n\r\n## Release Note\r\n<!-- Writing a release note:\r\n- By default, no release note action is required.\r\n- If you're unsure whether or not your PR needs a note, ask your reviewer for guidance.\r\n- If this PR requires a release note, update the block below to include a concise note describing\r\n  the change and any important impacts this PR may have.\r\n-->\r\n\r\n```release-note\r\nNone required\r\n```\r\n","created_at":"2017-10-06T23:09:29Z","updated_at":"2017-10-06T23:21:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3574c03bb4944c21245c542a0204fca68fc0b127","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/projectcalico/calicoctl/pulls/1715/commits","review_comments_url":"https://api.github.com/repos/projectcalico/calicoctl/pulls/1715/comments","review_comment_url":"https://api.github.com/repos/projectcalico/calicoctl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/projectcalico/calicoctl/issues/1715/comments","statuses_url":"https://api.github.com/repos/projectcalico/calicoctl/statuses/fc406e6ce15681adafa6ecd1e84c690493b8f515","head":{"label":"mgleung:add-bgpconfig-felixconfig","ref":"add-bgpconfig-felixconfig","sha":"fc406e6ce15681adafa6ecd1e84c690493b8f515","user":{"login":"mgleung","id":1366219,"avatar_url":"https://avatars0.githubusercontent.com/u/1366219?v=4","gravatar_id":"","url":"https://api.github.com/users/mgleung","html_url":"https://github.com/mgleung","followers_url":"https://api.github.com/users/mgleung/followers","following_url":"https://api.github.com/users/mgleung/following{/other_user}","gists_url":"https://api.github.com/users/mgleung/gists{/gist_id}","starred_url":"https://api.github.com/users/mgleung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgleung/subscriptions","organizations_url":"https://api.github.com/users/mgleung/orgs","repos_url":"https://api.github.com/users/mgleung/repos","events_url":"https://api.github.com/users/mgleung/events{/privacy}","received_events_url":"https://api.github.com/users/mgleung/received_events","type":"User","site_admin":false},"repo":{"id":93881169,"name":"calicoctl","full_name":"mgleung/calicoctl","owner":{"login":"mgleung","id":1366219,"avatar_url":"https://avatars0.githubusercontent.com/u/1366219?v=4","gravatar_id":"","url":"https://api.github.com/users/mgleung","html_url":"https://github.com/mgleung","followers_url":"https://api.github.com/users/mgleung/followers","following_url":"https://api.github.com/users/mgleung/following{/other_user}","gists_url":"https://api.github.com/users/mgleung/gists{/gist_id}","starred_url":"https://api.github.com/users/mgleung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgleung/subscriptions","organizations_url":"https://api.github.com/users/mgleung/orgs","repos_url":"https://api.github.com/users/mgleung/repos","events_url":"https://api.github.com/users/mgleung/events{/privacy}","received_events_url":"https://api.github.com/users/mgleung/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mgleung/calicoctl","description":"Calico CLI tool and calico/node container","fork":true,"url":"https://api.github.com/repos/mgleung/calicoctl","forks_url":"https://api.github.com/repos/mgleung/calicoctl/forks","keys_url":"https://api.github.com/repos/mgleung/calicoctl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mgleung/calicoctl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mgleung/calicoctl/teams","hooks_url":"https://api.github.com/repos/mgleung/calicoctl/hooks","issue_events_url":"https://api.github.com/repos/mgleung/calicoctl/issues/events{/number}","events_url":"https://api.github.com/repos/mgleung/calicoctl/events","assignees_url":"https://api.github.com/repos/mgleung/calicoctl/assignees{/user}","branches_url":"https://api.github.com/repos/mgleung/calicoctl/branches{/branch}","tags_url":"https://api.github.com/repos/mgleung/calicoctl/tags","blobs_url":"https://api.github.com/repos/mgleung/calicoctl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mgleung/calicoctl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mgleung/calicoctl/git/refs{/sha}","trees_url":"https://api.github.com/repos/mgleung/calicoctl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mgleung/calicoctl/statuses/{sha}","languages_url":"https://api.github.com/repos/mgleung/calicoctl/languages","stargazers_url":"https://api.github.com/repos/mgleung/calicoctl/stargazers","contributors_url":"https://api.github.com/repos/mgleung/calicoctl/contributors","subscribers_url":"https://api.github.com/repos/mgleung/calicoctl/subscribers","subscription_url":"https://api.github.com/repos/mgleung/calicoctl/subscription","commits_url":"https://api.github.com/repos/mgleung/calicoctl/commits{/sha}","git_commits_url":"https://api.github.com/repos/mgleung/calicoctl/git/commits{/sha}","comments_url":"https://api.github.com/repos/mgleung/calicoctl/comments{/number}","issue_comment_url":"https://api.github.com/repos/mgleung/calicoctl/issues/comments{/number}","contents_url":"https://api.github.com/repos/mgleung/calicoctl/contents/{+path}","compare_url":"https://api.github.com/repos/mgleung/calicoctl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mgleung/calicoctl/merges","archive_url":"https://api.github.com/repos/mgleung/calicoctl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mgleung/calicoctl/downloads","issues_url":"https://api.github.com/repos/mgleung/calicoctl/issues{/number}","pulls_url":"https://api.github.com/repos/mgleung/calicoctl/pulls{/number}","milestones_url":"https://api.github.com/repos/mgleung/calicoctl/milestones{/number}","notifications_url":"https://api.github.com/repos/mgleung/calicoctl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mgleung/calicoctl/labels{/name}","releases_url":"https://api.github.com/repos/mgleung/calicoctl/releases{/id}","deployments_url":"https://api.github.com/repos/mgleung/calicoctl/deployments","created_at":"2017-06-09T17:20:29Z","updated_at":"2017-06-19T22:53:37Z","pushed_at":"2017-10-06T23:07:23Z","git_url":"git://github.com/mgleung/calicoctl.git","ssh_url":"git@github.com:mgleung/calicoctl.git","clone_url":"https://github.com/mgleung/calicoctl.git","svn_url":"https://github.com/mgleung/calicoctl","homepage":"http://www.projectcalico.org","size":37449,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"projectcalico:v3.0-integration","ref":"v3.0-integration","sha":"805d2e47b30b9c476108b746c57cc4915ee60b51","user":{"login":"projectcalico","id":12304728,"avatar_url":"https://avatars3.githubusercontent.com/u/12304728?v=4","gravatar_id":"","url":"https://api.github.com/users/projectcalico","html_url":"https://github.com/projectcalico","followers_url":"https://api.github.com/users/projectcalico/followers","following_url":"https://api.github.com/users/projectcalico/following{/other_user}","gists_url":"https://api.github.com/users/projectcalico/gists{/gist_id}","starred_url":"https://api.github.com/users/projectcalico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectcalico/subscriptions","organizations_url":"https://api.github.com/users/projectcalico/orgs","repos_url":"https://api.github.com/users/projectcalico/repos","events_url":"https://api.github.com/users/projectcalico/events{/privacy}","received_events_url":"https://api.github.com/users/projectcalico/received_events","type":"Organization","site_admin":false},"repo":{"id":29629333,"name":"calicoctl","full_name":"projectcalico/calicoctl","owner":{"login":"projectcalico","id":12304728,"avatar_url":"https://avatars3.githubusercontent.com/u/12304728?v=4","gravatar_id":"","url":"https://api.github.com/users/projectcalico","html_url":"https://github.com/projectcalico","followers_url":"https://api.github.com/users/projectcalico/followers","following_url":"https://api.github.com/users/projectcalico/following{/other_user}","gists_url":"https://api.github.com/users/projectcalico/gists{/gist_id}","starred_url":"https://api.github.com/users/projectcalico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectcalico/subscriptions","organizations_url":"https://api.github.com/users/projectcalico/orgs","repos_url":"https://api.github.com/users/projectcalico/repos","events_url":"https://api.github.com/users/projectcalico/events{/privacy}","received_events_url":"https://api.github.com/users/projectcalico/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/projectcalico/calicoctl","description":"Calico CLI tool","fork":false,"url":"https://api.github.com/repos/projectcalico/calicoctl","forks_url":"https://api.github.com/repos/projectcalico/calicoctl/forks","keys_url":"https://api.github.com/repos/projectcalico/calicoctl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/projectcalico/calicoctl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/projectcalico/calicoctl/teams","hooks_url":"https://api.github.com/repos/projectcalico/calicoctl/hooks","issue_events_url":"https://api.github.com/repos/projectcalico/calicoctl/issues/events{/number}","events_url":"https://api.github.com/repos/projectcalico/calicoctl/events","assignees_url":"https://api.github.com/repos/projectcalico/calicoctl/assignees{/user}","branches_url":"https://api.github.com/repos/projectcalico/calicoctl/branches{/branch}","tags_url":"https://api.github.com/repos/projectcalico/calicoctl/tags","blobs_url":"https://api.github.com/repos/projectcalico/calicoctl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/projectcalico/calicoctl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/projectcalico/calicoctl/git/refs{/sha}","trees_url":"https://api.github.com/repos/projectcalico/calicoctl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/projectcalico/calicoctl/statuses/{sha}","languages_url":"https://api.github.com/repos/projectcalico/calicoctl/languages","stargazers_url":"https://api.github.com/repos/projectcalico/calicoctl/stargazers","contributors_url":"https://api.github.com/repos/projectcalico/calicoctl/contributors","subscribers_url":"https://api.github.com/repos/projectcalico/calicoctl/subscribers","subscription_url":"https://api.github.com/repos/projectcalico/calicoctl/subscription","commits_url":"https://api.github.com/repos/projectcalico/calicoctl/commits{/sha}","git_commits_url":"https://api.github.com/repos/projectcalico/calicoctl/git/commits{/sha}","comments_url":"https://api.github.com/repos/projectcalico/calicoctl/comments{/number}","issue_comment_url":"https://api.github.com/repos/projectcalico/calicoctl/issues/comments{/number}","contents_url":"https://api.github.com/repos/projectcalico/calicoctl/contents/{+path}","compare_url":"https://api.github.com/repos/projectcalico/calicoctl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/projectcalico/calicoctl/merges","archive_url":"https://api.github.com/repos/projectcalico/calicoctl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/projectcalico/calicoctl/downloads","issues_url":"https://api.github.com/repos/projectcalico/calicoctl/issues{/number}","pulls_url":"https://api.github.com/repos/projectcalico/calicoctl/pulls{/number}","milestones_url":"https://api.github.com/repos/projectcalico/calicoctl/milestones{/number}","notifications_url":"https://api.github.com/repos/projectcalico/calicoctl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/projectcalico/calicoctl/labels{/name}","releases_url":"https://api.github.com/repos/projectcalico/calicoctl/releases{/id}","deployments_url":"https://api.github.com/repos/projectcalico/calicoctl/deployments","created_at":"2015-01-21T23:46:47Z","updated_at":"2017-09-29T06:52:33Z","pushed_at":"2017-10-06T23:09:30Z","git_url":"git://github.com/projectcalico/calicoctl.git","ssh_url":"git@github.com:projectcalico/calicoctl.git","clone_url":"https://github.com/projectcalico/calicoctl.git","svn_url":"https://github.com/projectcalico/calicoctl","homepage":"http://www.projectcalico.org","size":37478,"stargazers_count":649,"watchers_count":649,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":186,"mirror_url":null,"open_issues_count":37,"forks":186,"open_issues":37,"watchers":649,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/projectcalico/calicoctl/pulls/1715"},"html":{"href":"https://github.com/projectcalico/calicoctl/pull/1715"},"issue":{"href":"https://api.github.com/repos/projectcalico/calicoctl/issues/1715"},"comments":{"href":"https://api.github.com/repos/projectcalico/calicoctl/issues/1715/comments"},"review_comments":{"href":"https://api.github.com/repos/projectcalico/calicoctl/pulls/1715/comments"},"review_comment":{"href":"https://api.github.com/repos/projectcalico/calicoctl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/projectcalico/calicoctl/pulls/1715/commits"},"statuses":{"href":"https://api.github.com/repos/projectcalico/calicoctl/statuses/fc406e6ce15681adafa6ecd1e84c690493b8f515"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"robbrockbank"}}