{"action":"created","issue":{"url":"https://api.github.com/repos/brave/browser-laptop/issues/12054","repository_url":"https://api.github.com/repos/brave/browser-laptop","labels_url":"https://api.github.com/repos/brave/browser-laptop/issues/12054/labels{/name}","comments_url":"https://api.github.com/repos/brave/browser-laptop/issues/12054/comments","events_url":"https://api.github.com/repos/brave/browser-laptop/issues/12054/events","html_url":"https://github.com/brave/browser-laptop/issues/12054","id":275840731,"number":12054,"title":"USD conversion for wallet balance always shows 1.00","user":{"login":"evq","id":8796196,"avatar_url":"https://avatars3.githubusercontent.com/u/8796196?v=4","gravatar_id":"","url":"https://api.github.com/users/evq","html_url":"https://github.com/evq","followers_url":"https://api.github.com/users/evq/followers","following_url":"https://api.github.com/users/evq/following{/other_user}","gists_url":"https://api.github.com/users/evq/gists{/gist_id}","starred_url":"https://api.github.com/users/evq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evq/subscriptions","organizations_url":"https://api.github.com/users/evq/orgs","repos_url":"https://api.github.com/users/evq/repos","events_url":"https://api.github.com/users/evq/events{/privacy}","received_events_url":"https://api.github.com/users/evq/received_events","type":"User","site_admin":false},"labels":[{"id":737382373,"url":"https://api.github.com/repos/brave/browser-laptop/labels/0.19.x","name":"0.19.x","color":"f9d0c4","default":false},{"id":291742587,"url":"https://api.github.com/repos/brave/browser-laptop/labels/bug","name":"bug","color":"fc2929","default":true},{"id":408464251,"url":"https://api.github.com/repos/brave/browser-laptop/labels/feature/ledger","name":"feature/ledger","color":"ff5000","default":false},{"id":517539438,"url":"https://api.github.com/repos/brave/browser-laptop/labels/QA/test-plan-required","name":"QA/test-plan-required","color":"c2e0c6","default":false}],"state":"closed","locked":false,"assignee":{"login":"NejcZdovc","id":9574457,"avatar_url":"https://avatars1.githubusercontent.com/u/9574457?v=4","gravatar_id":"","url":"https://api.github.com/users/NejcZdovc","html_url":"https://github.com/NejcZdovc","followers_url":"https://api.github.com/users/NejcZdovc/followers","following_url":"https://api.github.com/users/NejcZdovc/following{/other_user}","gists_url":"https://api.github.com/users/NejcZdovc/gists{/gist_id}","starred_url":"https://api.github.com/users/NejcZdovc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NejcZdovc/subscriptions","organizations_url":"https://api.github.com/users/NejcZdovc/orgs","repos_url":"https://api.github.com/users/NejcZdovc/repos","events_url":"https://api.github.com/users/NejcZdovc/events{/privacy}","received_events_url":"https://api.github.com/users/NejcZdovc/received_events","type":"User","site_admin":false},"assignees":[{"login":"NejcZdovc","id":9574457,"avatar_url":"https://avatars1.githubusercontent.com/u/9574457?v=4","gravatar_id":"","url":"https://api.github.com/users/NejcZdovc","html_url":"https://github.com/NejcZdovc","followers_url":"https://api.github.com/users/NejcZdovc/followers","following_url":"https://api.github.com/users/NejcZdovc/following{/other_user}","gists_url":"https://api.github.com/users/NejcZdovc/gists{/gist_id}","starred_url":"https://api.github.com/users/NejcZdovc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NejcZdovc/subscriptions","organizations_url":"https://api.github.com/users/NejcZdovc/orgs","repos_url":"https://api.github.com/users/NejcZdovc/repos","events_url":"https://api.github.com/users/NejcZdovc/events{/privacy}","received_events_url":"https://api.github.com/users/NejcZdovc/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/brave/browser-laptop/milestones/90","html_url":"https://github.com/brave/browser-laptop/milestone/90","labels_url":"https://api.github.com/repos/brave/browser-laptop/milestones/90/labels","id":2894976,"number":90,"title":"0.19.x Hotfix 6 (Release channel)","description":"","creator":{"login":"bsclifton","id":4733304,"avatar_url":"https://avatars3.githubusercontent.com/u/4733304?v=4","gravatar_id":"","url":"https://api.github.com/users/bsclifton","html_url":"https://github.com/bsclifton","followers_url":"https://api.github.com/users/bsclifton/followers","following_url":"https://api.github.com/users/bsclifton/following{/other_user}","gists_url":"https://api.github.com/users/bsclifton/gists{/gist_id}","starred_url":"https://api.github.com/users/bsclifton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsclifton/subscriptions","organizations_url":"https://api.github.com/users/bsclifton/orgs","repos_url":"https://api.github.com/users/bsclifton/repos","events_url":"https://api.github.com/users/bsclifton/events{/privacy}","received_events_url":"https://api.github.com/users/bsclifton/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":54,"state":"open","created_at":"2017-11-07T18:31:04Z","updated_at":"2017-11-29T21:58:30Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2017-11-21T19:58:10Z","updated_at":"2017-11-30T15:16:25Z","closed_at":"2017-11-22T16:27:38Z","author_association":"OWNER","body":"<!--\r\nHave you searched for similar issues? We have received a lot of feedback and bug reports that we have closed as duplicates. Before submitting this issue, please visit our community site for common ones: https://community.brave.com/c/common-issues\r\n-->\r\n\r\n### Description\r\n<!--\r\n[Description of the issue]\r\n-->\r\nEssentially despite rates being successfully retrieved, the calculated conversion value is never updated and shows `1.00`:\r\n\r\n<img width=\"240\" alt=\"screen shot 2017-11-15 at 12 21 37 pm\" src=\"https://user-images.githubusercontent.com/11330831/32858212-9cffadbc-c9ff-11e7-8d2f-7dea07c15ca7.png\">\r\n\r\nSee https://github.com/brave/browser-laptop/issues/11931#issuecomment-344743334 after it was closed for original discussion on this issue.\r\n\r\n`LEDGER_VERBOSE=1` logs:\r\n```\r\n[ response for GET https://balance.mercury.basicattentiontoken.org/v2/wallet/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx/balance ]                                                                                                        [321/10438]\r\n>>> HTTP/1.1 200\r\n>>> accept-ranges: bytes\r\n>>> cache-control: private\r\n>>> connection: keep-alive\r\n>>> content-length: 207\r\n>>> content-type: application/json; charset=utf-8\r\n>>> date: Wed, 15 Nov 2017 23:24:47 GMT\r\n>>> server: Cowboy\r\n>>> vary: accept-encoding\r\n>>> via: 1.1 vegur\r\n>>> x-rate-limit-limit: 60\r\n>>> x-rate-limit-remaining: 57\r\n>>> x-rate-limit-reset: 1510788301\r\n>>>\r\n>>> {\"altcurrency\":\"BAT\",\"probi\":\"7.309622404968674704085e+21\",\"balance\":\"7309.6224\",\"unconfirmed\":\"0.0000\",\"rates\":{\"BTC\":\"0.00001966\",\"ETH\":0.00042591989579941384,\"USD\":0.1433458965,\"EUR\":0.12100429176330299}}\r\n[ response for GET https://mercury-proxy.privateinternetaccess.com/v3/publisher/timestamp ]\r\n>>> HTTP/1.1 200\r\n>>> accept-ranges: bytes\r\n>>> cache-control: private\r\n>>> connection: keep-alive\r\n>>> content-length: 35\r\n>>> content-type: application/json; charset=utf-8\r\n>>> date: Wed, 15 Nov 2017 23:24:47 GMT\r\n>>> server: Cowboy\r\n>>> strict-transport-security: max-age=31536000\r\n>>> vary: accept-encoding\r\n>>> via: 1.1 vegur\r\n>>> x-rate-limit-limit: 9007199254740991\r\n>>> x-rate-limit-remaining: 9007199254740990\r\n>>> x-rate-limit-reset: 1510788288\r\n>>>\r\n>>> {\"timestamp\":\"6488746555397373953\"}\r\n[ response for GET https://balance.mercury.basicattentiontoken.org/v2/wallet/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx/balance ]\r\n>>> HTTP/1.1 200\r\n>>> accept-ranges: bytes\r\n>>> cache-control: private\r\n>>> connection: keep-alive\r\n>>> content-length: 207\r\n>>> content-type: application/json; charset=utf-8\r\n>>> date: Wed, 15 Nov 2017 23:24:47 GMT\r\n>>> server: Cowboy\r\n>>> vary: accept-encoding\r\n>>> via: 1.1 vegur\r\n>>> x-rate-limit-limit: 60\r\n>>> x-rate-limit-remaining: 56\r\n>>> x-rate-limit-reset: 1510788300\r\n>>>\r\n>>> {\"altcurrency\":\"BAT\",\"probi\":\"7.309622404968674704085e+21\",\"balance\":\"7309.6224\",\"unconfirmed\":\"0.0000\",\"rates\":{\"BTC\":\"0.00001966\",\"ETH\":0.00042591989579941384,\"USD\":0.1433458965,\"EUR\":0.12100429176330299}}\r\n\r\ngetBalance refreshes ledger info: 0\r\n```\r\n\r\n### Steps to Reproduce\r\n<!--\r\nPlease add a series of steps to reproduce the problem. See https://stackoverflow.com/help/mcve for in depth information on how to create a minimal, complete, and verifiable example.\r\n-->\r\n\r\n  1.\r\n  2.\r\n  3.\r\n\r\n\r\n**Actual result:**\r\n<!--\r\nPlease add screenshots if needed.\r\n-->\r\n\r\n\r\n**Expected result:**\r\n\r\n\r\n**Reproduces how often:**\r\n<!--\r\nWhat percentage of the time does it reproduce?\r\n-->\r\n\r\n\r\n### Brave Version\r\n\r\nBrave: 0.19.93\r\nrev: 25085d0\r\nMuon: 4.5.16\r\nlibchromiumcontent: 62.0.3202.94\r\nV8: 6.2.414.42\r\nNode.js: 7.9.0\r\nUpdate Channel: Release\r\nOS Platform: macOS\r\nOS Release: 16.7.0\r\nOS Architecture: x64\r\n<!--\r\nPlease open about:brave, copy the version information, and paste it.\r\n-->\r\n\r\n\r\n**Reproducible on current live release:**\r\n<!--\r\nIs this a problem with the live build? It matters for triage reasons.\r\n-->\r\nyes (with @darkdh profile)\r\n\r\n### Additional Information\r\n<!--\r\nAny additional information, related issues, extra QA steps, configuration or data that might be necessary to reproduce the issue.\r\n-->\r\n"},"comment":{"url":"https://api.github.com/repos/brave/browser-laptop/issues/comments/348218228","html_url":"https://github.com/brave/browser-laptop/issues/12054#issuecomment-348218228","issue_url":"https://api.github.com/repos/brave/browser-laptop/issues/12054","id":348218228,"user":{"login":"kjozwiak","id":2602313,"avatar_url":"https://avatars0.githubusercontent.com/u/2602313?v=4","gravatar_id":"","url":"https://api.github.com/users/kjozwiak","html_url":"https://github.com/kjozwiak","followers_url":"https://api.github.com/users/kjozwiak/followers","following_url":"https://api.github.com/users/kjozwiak/following{/other_user}","gists_url":"https://api.github.com/users/kjozwiak/gists{/gist_id}","starred_url":"https://api.github.com/users/kjozwiak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kjozwiak/subscriptions","organizations_url":"https://api.github.com/users/kjozwiak/orgs","repos_url":"https://api.github.com/users/kjozwiak/repos","events_url":"https://api.github.com/users/kjozwiak/events{/privacy}","received_events_url":"https://api.github.com/users/kjozwiak/received_events","type":"User","site_admin":false},"created_at":"2017-11-30T15:16:25Z","updated_at":"2017-11-30T15:16:25Z","author_association":"MEMBER","body":"Thanks @darkdh! I'm going to mark this as tested as it fixed the issue @darkdh was having as well. I talked to @evq last night and this would be difficult to test for QA unless we create a wallet with a huge balance... Either way, it looks like it's working."}}
{"actor":{"display_login":"kjozwiak"}}