{"action":"created","comment":{"url":"https://api.github.com/repos/HadoukenIO/core/pulls/comments/155047465","pull_request_review_id":81297895,"id":155047465,"diff_hunk":"@@ -371,28 +372,55 @@ Application.pingChildWindow = function() {\n     console.warn('Deprecated');\n };\n Application.registerCustomData = function(identity, data, callback, errorCallback) {\n-    let app = Application.wrap(identity.uuid);\n+    console.warn('Deprecated');\n+    errorCallback(new Error('This function has been deprecated - please use Application.registerUser instead.'));\n+};\n+\n+Application.registerUser = function(identity, userName, appName, callback, errorCallback) {\n+    let uuid = identity.uuid;\n+    let app = coreState.getAppByUuid(uuid) || coreState.getExternalAppObjByUuid(uuid);\n \n     if (!app) {\n-        errorCallback(new Error(`application with uuid ${identity.uuid} does not exist`));\n+        errorCallback(new Error(`application with uuid ${uuid} does not exist`));\n+        return;\n+    }\n+\n+    let licenseKey = app.licenseKey;","path":"src/browser/api/application.js","position":27,"original_position":27,"commit_id":"546b63bfdf67d7408c3514a4756f2567a3dd49dc","original_commit_id":"546b63bfdf67d7408c3514a4756f2567a3dd49dc","user":{"login":"HarsimranSingh","id":2280130,"avatar_url":"https://avatars1.githubusercontent.com/u/2280130?v=4","gravatar_id":"","url":"https://api.github.com/users/HarsimranSingh","html_url":"https://github.com/HarsimranSingh","followers_url":"https://api.github.com/users/HarsimranSingh/followers","following_url":"https://api.github.com/users/HarsimranSingh/following{/other_user}","gists_url":"https://api.github.com/users/HarsimranSingh/gists{/gist_id}","starred_url":"https://api.github.com/users/HarsimranSingh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HarsimranSingh/subscriptions","organizations_url":"https://api.github.com/users/HarsimranSingh/orgs","repos_url":"https://api.github.com/users/HarsimranSingh/repos","events_url":"https://api.github.com/users/HarsimranSingh/events{/privacy}","received_events_url":"https://api.github.com/users/HarsimranSingh/received_events","type":"User","site_admin":false},"body":"const","created_at":"2017-12-05T19:12:42Z","updated_at":"2017-12-05T19:14:23Z","html_url":"https://github.com/HadoukenIO/core/pull/263#discussion_r155047465","pull_request_url":"https://api.github.com/repos/HadoukenIO/core/pulls/263","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/HadoukenIO/core/pulls/comments/155047465"},"html":{"href":"https://github.com/HadoukenIO/core/pull/263#discussion_r155047465"},"pull_request":{"href":"https://api.github.com/repos/HadoukenIO/core/pulls/263"}}},"pull_request":{"url":"https://api.github.com/repos/HadoukenIO/core/pulls/263","id":156338804,"html_url":"https://github.com/HadoukenIO/core/pull/263","diff_url":"https://github.com/HadoukenIO/core/pull/263.diff","patch_url":"https://github.com/HadoukenIO/core/pull/263.patch","issue_url":"https://api.github.com/repos/HadoukenIO/core/issues/263","number":263,"state":"open","locked":false,"title":"RUN-3588 add support for registerUser API","user":{"login":"patpao","id":27218757,"avatar_url":"https://avatars2.githubusercontent.com/u/27218757?v=4","gravatar_id":"","url":"https://api.github.com/users/patpao","html_url":"https://github.com/patpao","followers_url":"https://api.github.com/users/patpao/followers","following_url":"https://api.github.com/users/patpao/following{/other_user}","gists_url":"https://api.github.com/users/patpao/gists{/gist_id}","starred_url":"https://api.github.com/users/patpao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patpao/subscriptions","organizations_url":"https://api.github.com/users/patpao/orgs","repos_url":"https://api.github.com/users/patpao/repos","events_url":"https://api.github.com/users/patpao/events{/privacy}","received_events_url":"https://api.github.com/users/patpao/received_events","type":"User","site_admin":false},"body":"https://appoji.jira.com/browse/RUN-3588\r\n\r\nThis PR is for the new \"registerUser\" API that will replace the currently unused registerCustomData (see: https://github.com/openfin/Internal-Wiki/wiki/Custom-License-Registration)\r\n\r\nTests:\r\n[W10](https://testing-dashboard.openfin.co/#/app/sessions/api/completed/5a25cfba299179466481952a)\r\n[W7](https://testing-dashboard.openfin.co/#/app/sessions/api/completed/5a25cf3e2991794664819529)\r\n[New Test](https://testing-dashboard.openfin.co/#/app/tests/5a25ce482991794664819528/edit) (I have more tests that need to be made public once the new RVM goes stable)\r\n\r\nRelated javascript-adapter PR: https://github.com/openfin/javascript-adapter/pull/365\r\n","created_at":"2017-12-04T23:59:53Z","updated_at":"2017-12-05T19:14:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"60e976ce6276040ffe49b93997a980f4690a944d","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/HadoukenIO/core/pulls/263/commits","review_comments_url":"https://api.github.com/repos/HadoukenIO/core/pulls/263/comments","review_comment_url":"https://api.github.com/repos/HadoukenIO/core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HadoukenIO/core/issues/263/comments","statuses_url":"https://api.github.com/repos/HadoukenIO/core/statuses/546b63bfdf67d7408c3514a4756f2567a3dd49dc","head":{"label":"patpao:feature/register-user-api","ref":"feature/register-user-api","sha":"546b63bfdf67d7408c3514a4756f2567a3dd49dc","user":{"login":"patpao","id":27218757,"avatar_url":"https://avatars2.githubusercontent.com/u/27218757?v=4","gravatar_id":"","url":"https://api.github.com/users/patpao","html_url":"https://github.com/patpao","followers_url":"https://api.github.com/users/patpao/followers","following_url":"https://api.github.com/users/patpao/following{/other_user}","gists_url":"https://api.github.com/users/patpao/gists{/gist_id}","starred_url":"https://api.github.com/users/patpao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patpao/subscriptions","organizations_url":"https://api.github.com/users/patpao/orgs","repos_url":"https://api.github.com/users/patpao/repos","events_url":"https://api.github.com/users/patpao/events{/privacy}","received_events_url":"https://api.github.com/users/patpao/received_events","type":"User","site_admin":false},"repo":{"id":113108621,"name":"core","full_name":"patpao/core","owner":{"login":"patpao","id":27218757,"avatar_url":"https://avatars2.githubusercontent.com/u/27218757?v=4","gravatar_id":"","url":"https://api.github.com/users/patpao","html_url":"https://github.com/patpao","followers_url":"https://api.github.com/users/patpao/followers","following_url":"https://api.github.com/users/patpao/following{/other_user}","gists_url":"https://api.github.com/users/patpao/gists{/gist_id}","starred_url":"https://api.github.com/users/patpao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patpao/subscriptions","organizations_url":"https://api.github.com/users/patpao/orgs","repos_url":"https://api.github.com/users/patpao/repos","events_url":"https://api.github.com/users/patpao/events{/privacy}","received_events_url":"https://api.github.com/users/patpao/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/patpao/core","description":"Hadouken is an open-source runtime for building web applications with desktop experience. The OpenFin Core is the  reference implementation Javascript API for the Hadouken runtime.","fork":true,"url":"https://api.github.com/repos/patpao/core","forks_url":"https://api.github.com/repos/patpao/core/forks","keys_url":"https://api.github.com/repos/patpao/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/patpao/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/patpao/core/teams","hooks_url":"https://api.github.com/repos/patpao/core/hooks","issue_events_url":"https://api.github.com/repos/patpao/core/issues/events{/number}","events_url":"https://api.github.com/repos/patpao/core/events","assignees_url":"https://api.github.com/repos/patpao/core/assignees{/user}","branches_url":"https://api.github.com/repos/patpao/core/branches{/branch}","tags_url":"https://api.github.com/repos/patpao/core/tags","blobs_url":"https://api.github.com/repos/patpao/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/patpao/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/patpao/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/patpao/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/patpao/core/statuses/{sha}","languages_url":"https://api.github.com/repos/patpao/core/languages","stargazers_url":"https://api.github.com/repos/patpao/core/stargazers","contributors_url":"https://api.github.com/repos/patpao/core/contributors","subscribers_url":"https://api.github.com/repos/patpao/core/subscribers","subscription_url":"https://api.github.com/repos/patpao/core/subscription","commits_url":"https://api.github.com/repos/patpao/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/patpao/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/patpao/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/patpao/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/patpao/core/contents/{+path}","compare_url":"https://api.github.com/repos/patpao/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/patpao/core/merges","archive_url":"https://api.github.com/repos/patpao/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/patpao/core/downloads","issues_url":"https://api.github.com/repos/patpao/core/issues{/number}","pulls_url":"https://api.github.com/repos/patpao/core/pulls{/number}","milestones_url":"https://api.github.com/repos/patpao/core/milestones{/number}","notifications_url":"https://api.github.com/repos/patpao/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/patpao/core/labels{/name}","releases_url":"https://api.github.com/repos/patpao/core/releases{/id}","deployments_url":"https://api.github.com/repos/patpao/core/deployments","created_at":"2017-12-04T23:52:46Z","updated_at":"2017-12-04T23:52:48Z","pushed_at":"2017-12-05T16:11:07Z","git_url":"git://github.com/patpao/core.git","ssh_url":"git@github.com:patpao/core.git","clone_url":"https://github.com/patpao/core.git","svn_url":"https://github.com/patpao/core","homepage":"http://hadouken.io/","size":934,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"HadoukenIO:develop","ref":"develop","sha":"e5277fb4a56a7b35045d82c6f4f6d344384a3519","user":{"login":"HadoukenIO","id":28318664,"avatar_url":"https://avatars0.githubusercontent.com/u/28318664?v=4","gravatar_id":"","url":"https://api.github.com/users/HadoukenIO","html_url":"https://github.com/HadoukenIO","followers_url":"https://api.github.com/users/HadoukenIO/followers","following_url":"https://api.github.com/users/HadoukenIO/following{/other_user}","gists_url":"https://api.github.com/users/HadoukenIO/gists{/gist_id}","starred_url":"https://api.github.com/users/HadoukenIO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HadoukenIO/subscriptions","organizations_url":"https://api.github.com/users/HadoukenIO/orgs","repos_url":"https://api.github.com/users/HadoukenIO/repos","events_url":"https://api.github.com/users/HadoukenIO/events{/privacy}","received_events_url":"https://api.github.com/users/HadoukenIO/received_events","type":"Organization","site_admin":false},"repo":{"id":90180083,"name":"core","full_name":"HadoukenIO/core","owner":{"login":"HadoukenIO","id":28318664,"avatar_url":"https://avatars0.githubusercontent.com/u/28318664?v=4","gravatar_id":"","url":"https://api.github.com/users/HadoukenIO","html_url":"https://github.com/HadoukenIO","followers_url":"https://api.github.com/users/HadoukenIO/followers","following_url":"https://api.github.com/users/HadoukenIO/following{/other_user}","gists_url":"https://api.github.com/users/HadoukenIO/gists{/gist_id}","starred_url":"https://api.github.com/users/HadoukenIO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HadoukenIO/subscriptions","organizations_url":"https://api.github.com/users/HadoukenIO/orgs","repos_url":"https://api.github.com/users/HadoukenIO/repos","events_url":"https://api.github.com/users/HadoukenIO/events{/privacy}","received_events_url":"https://api.github.com/users/HadoukenIO/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HadoukenIO/core","description":"Hadouken is an open-source runtime for building web applications with desktop experience. The OpenFin Core is the  reference implementation Javascript API for the Hadouken runtime.","fork":false,"url":"https://api.github.com/repos/HadoukenIO/core","forks_url":"https://api.github.com/repos/HadoukenIO/core/forks","keys_url":"https://api.github.com/repos/HadoukenIO/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HadoukenIO/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HadoukenIO/core/teams","hooks_url":"https://api.github.com/repos/HadoukenIO/core/hooks","issue_events_url":"https://api.github.com/repos/HadoukenIO/core/issues/events{/number}","events_url":"https://api.github.com/repos/HadoukenIO/core/events","assignees_url":"https://api.github.com/repos/HadoukenIO/core/assignees{/user}","branches_url":"https://api.github.com/repos/HadoukenIO/core/branches{/branch}","tags_url":"https://api.github.com/repos/HadoukenIO/core/tags","blobs_url":"https://api.github.com/repos/HadoukenIO/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HadoukenIO/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HadoukenIO/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/HadoukenIO/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HadoukenIO/core/statuses/{sha}","languages_url":"https://api.github.com/repos/HadoukenIO/core/languages","stargazers_url":"https://api.github.com/repos/HadoukenIO/core/stargazers","contributors_url":"https://api.github.com/repos/HadoukenIO/core/contributors","subscribers_url":"https://api.github.com/repos/HadoukenIO/core/subscribers","subscription_url":"https://api.github.com/repos/HadoukenIO/core/subscription","commits_url":"https://api.github.com/repos/HadoukenIO/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/HadoukenIO/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/HadoukenIO/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/HadoukenIO/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/HadoukenIO/core/contents/{+path}","compare_url":"https://api.github.com/repos/HadoukenIO/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HadoukenIO/core/merges","archive_url":"https://api.github.com/repos/HadoukenIO/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HadoukenIO/core/downloads","issues_url":"https://api.github.com/repos/HadoukenIO/core/issues{/number}","pulls_url":"https://api.github.com/repos/HadoukenIO/core/pulls{/number}","milestones_url":"https://api.github.com/repos/HadoukenIO/core/milestones{/number}","notifications_url":"https://api.github.com/repos/HadoukenIO/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HadoukenIO/core/labels{/name}","releases_url":"https://api.github.com/repos/HadoukenIO/core/releases{/id}","deployments_url":"https://api.github.com/repos/HadoukenIO/core/deployments","created_at":"2017-05-03T18:21:22Z","updated_at":"2017-11-30T04:54:04Z","pushed_at":"2017-12-05T16:26:30Z","git_url":"git://github.com/HadoukenIO/core.git","ssh_url":"git@github.com:HadoukenIO/core.git","clone_url":"https://github.com/HadoukenIO/core.git","svn_url":"https://github.com/HadoukenIO/core","homepage":"http://hadouken.io/","size":930,"stargazers_count":56,"watchers_count":56,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":31,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":31,"open_issues":9,"watchers":56,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/HadoukenIO/core/pulls/263"},"html":{"href":"https://github.com/HadoukenIO/core/pull/263"},"issue":{"href":"https://api.github.com/repos/HadoukenIO/core/issues/263"},"comments":{"href":"https://api.github.com/repos/HadoukenIO/core/issues/263/comments"},"review_comments":{"href":"https://api.github.com/repos/HadoukenIO/core/pulls/263/comments"},"review_comment":{"href":"https://api.github.com/repos/HadoukenIO/core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HadoukenIO/core/pulls/263/commits"},"statuses":{"href":"https://api.github.com/repos/HadoukenIO/core/statuses/546b63bfdf67d7408c3514a4756f2567a3dd49dc"}},"author_association":"NONE"}}
{"actor":{"display_login":"HarsimranSingh"}}