{"action":"created","comment":{"url":"https://api.github.com/repos/amethyst/amethyst/pulls/comments/138646226","pull_request_review_id":62467329,"id":138646226,"diff_hunk":"@@ -98,11 +100,18 @@ impl Pipeline {\n     pub fn enabled_stages(&self) -> Stages {\n         Stages(self.stages.iter().filter(|s| s.is_enabled()))\n     }\n-\n+\t/// Get the mutable stages\n+    pub fn stages_mut(&mut self)->&mut Vec<Stage>{","path":"amethyst_renderer/src/pipe/mod.rs","position":19,"original_position":19,"commit_id":"245a36e17ce41236b9027aa5775c4c4584d7f67d","original_commit_id":"245a36e17ce41236b9027aa5775c4c4584d7f67d","user":{"login":"torkleyy","id":23152057,"avatar_url":"https://avatars1.githubusercontent.com/u/23152057?v=4","gravatar_id":"","url":"https://api.github.com/users/torkleyy","html_url":"https://github.com/torkleyy","followers_url":"https://api.github.com/users/torkleyy/followers","following_url":"https://api.github.com/users/torkleyy/following{/other_user}","gists_url":"https://api.github.com/users/torkleyy/gists{/gist_id}","starred_url":"https://api.github.com/users/torkleyy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/torkleyy/subscriptions","organizations_url":"https://api.github.com/users/torkleyy/orgs","repos_url":"https://api.github.com/users/torkleyy/repos","events_url":"https://api.github.com/users/torkleyy/events{/privacy}","received_events_url":"https://api.github.com/users/torkleyy/received_events","type":"User","site_admin":false},"body":"Any reason why you made the field public **and** added a getter? Additionally, is every possible safe modification of the stages vector valid API usage?","created_at":"2017-09-13T15:00:28Z","updated_at":"2017-09-13T15:09:52Z","html_url":"https://github.com/amethyst/amethyst/pull/334#discussion_r138646226","pull_request_url":"https://api.github.com/repos/amethyst/amethyst/pulls/334","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/amethyst/amethyst/pulls/comments/138646226"},"html":{"href":"https://github.com/amethyst/amethyst/pull/334#discussion_r138646226"},"pull_request":{"href":"https://api.github.com/repos/amethyst/amethyst/pulls/334"}}},"pull_request":{"url":"https://api.github.com/repos/amethyst/amethyst/pulls/334","id":139617317,"html_url":"https://github.com/amethyst/amethyst/pull/334","diff_url":"https://github.com/amethyst/amethyst/pull/334.diff","patch_url":"https://github.com/amethyst/amethyst/pull/334.patch","issue_url":"https://api.github.com/repos/amethyst/amethyst/issues/334","number":334,"state":"open","locked":false,"title":"Window resize fix","user":{"login":"jojolepro","id":4755185,"avatar_url":"https://avatars2.githubusercontent.com/u/4755185?v=4","gravatar_id":"","url":"https://api.github.com/users/jojolepro","html_url":"https://github.com/jojolepro","followers_url":"https://api.github.com/users/jojolepro/followers","following_url":"https://api.github.com/users/jojolepro/following{/other_user}","gists_url":"https://api.github.com/users/jojolepro/gists{/gist_id}","starred_url":"https://api.github.com/users/jojolepro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jojolepro/subscriptions","organizations_url":"https://api.github.com/users/jojolepro/orgs","repos_url":"https://api.github.com/users/jojolepro/repos","events_url":"https://api.github.com/users/jojolepro/events{/privacy}","received_events_url":"https://api.github.com/users/jojolepro/received_events","type":"User","site_admin":false},"body":"For review.\r\nKnown bug: Crashes when running a debug build and resizing(without --release).\r\nThis is due to gfx having a debug_assert in his code to resize the code.\r\nhttps://github.com/gfx-rs/gfx/blob/master/src/core/src/pso.rs#L279","created_at":"2017-09-06T17:11:39Z","updated_at":"2017-09-13T15:09:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ef3f6da5bf59ed6a7fb26f8706fe00ecf9574822","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ebkalderon","id":322831,"avatar_url":"https://avatars2.githubusercontent.com/u/322831?v=4","gravatar_id":"","url":"https://api.github.com/users/ebkalderon","html_url":"https://github.com/ebkalderon","followers_url":"https://api.github.com/users/ebkalderon/followers","following_url":"https://api.github.com/users/ebkalderon/following{/other_user}","gists_url":"https://api.github.com/users/ebkalderon/gists{/gist_id}","starred_url":"https://api.github.com/users/ebkalderon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebkalderon/subscriptions","organizations_url":"https://api.github.com/users/ebkalderon/orgs","repos_url":"https://api.github.com/users/ebkalderon/repos","events_url":"https://api.github.com/users/ebkalderon/events{/privacy}","received_events_url":"https://api.github.com/users/ebkalderon/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/amethyst/amethyst/pulls/334/commits","review_comments_url":"https://api.github.com/repos/amethyst/amethyst/pulls/334/comments","review_comment_url":"https://api.github.com/repos/amethyst/amethyst/pulls/comments{/number}","comments_url":"https://api.github.com/repos/amethyst/amethyst/issues/334/comments","statuses_url":"https://api.github.com/repos/amethyst/amethyst/statuses/245a36e17ce41236b9027aa5775c4c4584d7f67d","head":{"label":"jojolepro:develop","ref":"develop","sha":"245a36e17ce41236b9027aa5775c4c4584d7f67d","user":{"login":"jojolepro","id":4755185,"avatar_url":"https://avatars2.githubusercontent.com/u/4755185?v=4","gravatar_id":"","url":"https://api.github.com/users/jojolepro","html_url":"https://github.com/jojolepro","followers_url":"https://api.github.com/users/jojolepro/followers","following_url":"https://api.github.com/users/jojolepro/following{/other_user}","gists_url":"https://api.github.com/users/jojolepro/gists{/gist_id}","starred_url":"https://api.github.com/users/jojolepro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jojolepro/subscriptions","organizations_url":"https://api.github.com/users/jojolepro/orgs","repos_url":"https://api.github.com/users/jojolepro/repos","events_url":"https://api.github.com/users/jojolepro/events{/privacy}","received_events_url":"https://api.github.com/users/jojolepro/received_events","type":"User","site_admin":false},"repo":{"id":102265356,"name":"amethyst","full_name":"jojolepro/amethyst","owner":{"login":"jojolepro","id":4755185,"avatar_url":"https://avatars2.githubusercontent.com/u/4755185?v=4","gravatar_id":"","url":"https://api.github.com/users/jojolepro","html_url":"https://github.com/jojolepro","followers_url":"https://api.github.com/users/jojolepro/followers","following_url":"https://api.github.com/users/jojolepro/following{/other_user}","gists_url":"https://api.github.com/users/jojolepro/gists{/gist_id}","starred_url":"https://api.github.com/users/jojolepro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jojolepro/subscriptions","organizations_url":"https://api.github.com/users/jojolepro/orgs","repos_url":"https://api.github.com/users/jojolepro/repos","events_url":"https://api.github.com/users/jojolepro/events{/privacy}","received_events_url":"https://api.github.com/users/jojolepro/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jojolepro/amethyst","description":"Data-oriented game engine written in Rust","fork":true,"url":"https://api.github.com/repos/jojolepro/amethyst","forks_url":"https://api.github.com/repos/jojolepro/amethyst/forks","keys_url":"https://api.github.com/repos/jojolepro/amethyst/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jojolepro/amethyst/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jojolepro/amethyst/teams","hooks_url":"https://api.github.com/repos/jojolepro/amethyst/hooks","issue_events_url":"https://api.github.com/repos/jojolepro/amethyst/issues/events{/number}","events_url":"https://api.github.com/repos/jojolepro/amethyst/events","assignees_url":"https://api.github.com/repos/jojolepro/amethyst/assignees{/user}","branches_url":"https://api.github.com/repos/jojolepro/amethyst/branches{/branch}","tags_url":"https://api.github.com/repos/jojolepro/amethyst/tags","blobs_url":"https://api.github.com/repos/jojolepro/amethyst/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jojolepro/amethyst/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jojolepro/amethyst/git/refs{/sha}","trees_url":"https://api.github.com/repos/jojolepro/amethyst/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jojolepro/amethyst/statuses/{sha}","languages_url":"https://api.github.com/repos/jojolepro/amethyst/languages","stargazers_url":"https://api.github.com/repos/jojolepro/amethyst/stargazers","contributors_url":"https://api.github.com/repos/jojolepro/amethyst/contributors","subscribers_url":"https://api.github.com/repos/jojolepro/amethyst/subscribers","subscription_url":"https://api.github.com/repos/jojolepro/amethyst/subscription","commits_url":"https://api.github.com/repos/jojolepro/amethyst/commits{/sha}","git_commits_url":"https://api.github.com/repos/jojolepro/amethyst/git/commits{/sha}","comments_url":"https://api.github.com/repos/jojolepro/amethyst/comments{/number}","issue_comment_url":"https://api.github.com/repos/jojolepro/amethyst/issues/comments{/number}","contents_url":"https://api.github.com/repos/jojolepro/amethyst/contents/{+path}","compare_url":"https://api.github.com/repos/jojolepro/amethyst/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jojolepro/amethyst/merges","archive_url":"https://api.github.com/repos/jojolepro/amethyst/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jojolepro/amethyst/downloads","issues_url":"https://api.github.com/repos/jojolepro/amethyst/issues{/number}","pulls_url":"https://api.github.com/repos/jojolepro/amethyst/pulls{/number}","milestones_url":"https://api.github.com/repos/jojolepro/amethyst/milestones{/number}","notifications_url":"https://api.github.com/repos/jojolepro/amethyst/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jojolepro/amethyst/labels{/name}","releases_url":"https://api.github.com/repos/jojolepro/amethyst/releases{/id}","deployments_url":"https://api.github.com/repos/jojolepro/amethyst/deployments","created_at":"2017-09-03T13:08:20Z","updated_at":"2017-09-03T13:08:22Z","pushed_at":"2017-09-12T21:00:26Z","git_url":"git://github.com/jojolepro/amethyst.git","ssh_url":"git@github.com:jojolepro/amethyst.git","clone_url":"https://github.com/jojolepro/amethyst.git","svn_url":"https://github.com/jojolepro/amethyst","homepage":"https://www.amethyst.rs/","size":23963,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"amethyst:develop","ref":"develop","sha":"ccdd0bdcc69bf0970bbee42fa73df1d3974f5b3d","user":{"login":"amethyst","id":17814736,"avatar_url":"https://avatars1.githubusercontent.com/u/17814736?v=4","gravatar_id":"","url":"https://api.github.com/users/amethyst","html_url":"https://github.com/amethyst","followers_url":"https://api.github.com/users/amethyst/followers","following_url":"https://api.github.com/users/amethyst/following{/other_user}","gists_url":"https://api.github.com/users/amethyst/gists{/gist_id}","starred_url":"https://api.github.com/users/amethyst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amethyst/subscriptions","organizations_url":"https://api.github.com/users/amethyst/orgs","repos_url":"https://api.github.com/users/amethyst/repos","events_url":"https://api.github.com/users/amethyst/events{/privacy}","received_events_url":"https://api.github.com/users/amethyst/received_events","type":"Organization","site_admin":false},"repo":{"id":48364554,"name":"amethyst","full_name":"amethyst/amethyst","owner":{"login":"amethyst","id":17814736,"avatar_url":"https://avatars1.githubusercontent.com/u/17814736?v=4","gravatar_id":"","url":"https://api.github.com/users/amethyst","html_url":"https://github.com/amethyst","followers_url":"https://api.github.com/users/amethyst/followers","following_url":"https://api.github.com/users/amethyst/following{/other_user}","gists_url":"https://api.github.com/users/amethyst/gists{/gist_id}","starred_url":"https://api.github.com/users/amethyst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amethyst/subscriptions","organizations_url":"https://api.github.com/users/amethyst/orgs","repos_url":"https://api.github.com/users/amethyst/repos","events_url":"https://api.github.com/users/amethyst/events{/privacy}","received_events_url":"https://api.github.com/users/amethyst/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/amethyst/amethyst","description":"Data-oriented game engine written in Rust","fork":false,"url":"https://api.github.com/repos/amethyst/amethyst","forks_url":"https://api.github.com/repos/amethyst/amethyst/forks","keys_url":"https://api.github.com/repos/amethyst/amethyst/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amethyst/amethyst/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amethyst/amethyst/teams","hooks_url":"https://api.github.com/repos/amethyst/amethyst/hooks","issue_events_url":"https://api.github.com/repos/amethyst/amethyst/issues/events{/number}","events_url":"https://api.github.com/repos/amethyst/amethyst/events","assignees_url":"https://api.github.com/repos/amethyst/amethyst/assignees{/user}","branches_url":"https://api.github.com/repos/amethyst/amethyst/branches{/branch}","tags_url":"https://api.github.com/repos/amethyst/amethyst/tags","blobs_url":"https://api.github.com/repos/amethyst/amethyst/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amethyst/amethyst/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amethyst/amethyst/git/refs{/sha}","trees_url":"https://api.github.com/repos/amethyst/amethyst/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amethyst/amethyst/statuses/{sha}","languages_url":"https://api.github.com/repos/amethyst/amethyst/languages","stargazers_url":"https://api.github.com/repos/amethyst/amethyst/stargazers","contributors_url":"https://api.github.com/repos/amethyst/amethyst/contributors","subscribers_url":"https://api.github.com/repos/amethyst/amethyst/subscribers","subscription_url":"https://api.github.com/repos/amethyst/amethyst/subscription","commits_url":"https://api.github.com/repos/amethyst/amethyst/commits{/sha}","git_commits_url":"https://api.github.com/repos/amethyst/amethyst/git/commits{/sha}","comments_url":"https://api.github.com/repos/amethyst/amethyst/comments{/number}","issue_comment_url":"https://api.github.com/repos/amethyst/amethyst/issues/comments{/number}","contents_url":"https://api.github.com/repos/amethyst/amethyst/contents/{+path}","compare_url":"https://api.github.com/repos/amethyst/amethyst/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amethyst/amethyst/merges","archive_url":"https://api.github.com/repos/amethyst/amethyst/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amethyst/amethyst/downloads","issues_url":"https://api.github.com/repos/amethyst/amethyst/issues{/number}","pulls_url":"https://api.github.com/repos/amethyst/amethyst/pulls{/number}","milestones_url":"https://api.github.com/repos/amethyst/amethyst/milestones{/number}","notifications_url":"https://api.github.com/repos/amethyst/amethyst/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amethyst/amethyst/labels{/name}","releases_url":"https://api.github.com/repos/amethyst/amethyst/releases{/id}","deployments_url":"https://api.github.com/repos/amethyst/amethyst/deployments","created_at":"2015-12-21T09:59:29Z","updated_at":"2017-09-13T12:52:48Z","pushed_at":"2017-09-12T23:06:36Z","git_url":"git://github.com/amethyst/amethyst.git","ssh_url":"git@github.com:amethyst/amethyst.git","clone_url":"https://github.com/amethyst/amethyst.git","svn_url":"https://github.com/amethyst/amethyst","homepage":"https://www.amethyst.rs/","size":23939,"stargazers_count":688,"watchers_count":688,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":68,"mirror_url":null,"open_issues_count":63,"forks":68,"open_issues":63,"watchers":688,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/amethyst/amethyst/pulls/334"},"html":{"href":"https://github.com/amethyst/amethyst/pull/334"},"issue":{"href":"https://api.github.com/repos/amethyst/amethyst/issues/334"},"comments":{"href":"https://api.github.com/repos/amethyst/amethyst/issues/334/comments"},"review_comments":{"href":"https://api.github.com/repos/amethyst/amethyst/pulls/334/comments"},"review_comment":{"href":"https://api.github.com/repos/amethyst/amethyst/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/amethyst/amethyst/pulls/334/commits"},"statuses":{"href":"https://api.github.com/repos/amethyst/amethyst/statuses/245a36e17ce41236b9027aa5775c4c4584d7f67d"}},"author_association":"NONE"}}
{"actor":{"display_login":"torkleyy"}}