{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/pulls/comments/116126865","pull_request_review_id":37726690,"id":116126865,"diff_hunk":"@@ -159,6 +163,11 @@ function activate(agent) {\n         if (patchedRoot !== null) {\n           return patchedRoot;\n         }\n+      } else {\n+        var modulePath = Module._resolveFilename(request, parent).replace('/', path.sep);","path":"src/trace-plugin-loader.js","position":33,"original_position":33,"commit_id":"16166461a16d6c5c723d58c9975cf1bce1e6c6e3","original_commit_id":"16166461a16d6c5c723d58c9975cf1bce1e6c6e3","user":{"login":"matthewloring","id":1485909,"avatar_url":"https://avatars0.githubusercontent.com/u/1485909?v=3","gravatar_id":"","url":"https://api.github.com/users/matthewloring","html_url":"https://github.com/matthewloring","followers_url":"https://api.github.com/users/matthewloring/followers","following_url":"https://api.github.com/users/matthewloring/following{/other_user}","gists_url":"https://api.github.com/users/matthewloring/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewloring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewloring/subscriptions","organizations_url":"https://api.github.com/users/matthewloring/orgs","repos_url":"https://api.github.com/users/matthewloring/repos","events_url":"https://api.github.com/users/matthewloring/events{/privacy}","received_events_url":"https://api.github.com/users/matthewloring/received_events","type":"User","site_admin":false},"body":"Why is this logic not needed in the patch case?","created_at":"2017-05-11T23:41:32Z","updated_at":"2017-05-11T23:41:44Z","html_url":"https://github.com/GoogleCloudPlatform/cloud-trace-nodejs/pull/480#discussion_r116126865","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/pulls/480","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/pulls/comments/116126865"},"html":{"href":"https://github.com/GoogleCloudPlatform/cloud-trace-nodejs/pull/480#discussion_r116126865"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/pulls/480"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/pulls/480","id":119776276,"html_url":"https://github.com/GoogleCloudPlatform/cloud-trace-nodejs/pull/480","diff_url":"https://github.com/GoogleCloudPlatform/cloud-trace-nodejs/pull/480.diff","patch_url":"https://github.com/GoogleCloudPlatform/cloud-trace-nodejs/pull/480.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/issues/480","number":480,"state":"open","locked":false,"title":"patching: fix module-internal requires not being intercepted","user":{"login":"kjin","id":2365820,"avatar_url":"https://avatars0.githubusercontent.com/u/2365820?v=3","gravatar_id":"","url":"https://api.github.com/users/kjin","html_url":"https://github.com/kjin","followers_url":"https://api.github.com/users/kjin/followers","following_url":"https://api.github.com/users/kjin/following{/other_user}","gists_url":"https://api.github.com/users/kjin/gists{/gist_id}","starred_url":"https://api.github.com/users/kjin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kjin/subscriptions","organizations_url":"https://api.github.com/users/kjin/orgs","repos_url":"https://api.github.com/users/kjin/repos","events_url":"https://api.github.com/users/kjin/events{/privacy}","received_events_url":"https://api.github.com/users/kjin/received_events","type":"User","site_admin":false},"body":"Intercepts are only being done for top-level modules -- in other words, files being required internally within modules won't be intercepted.\r\n\r\nIn this fix, we cache modules that were intercepted in a separate object so that when loaded, we'll return the replaced value instead.","created_at":"2017-05-09T23:38:19Z","updated_at":"2017-05-11T23:41:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2cdd012c5fcaeaafb3de3172ed12956767f2fb83","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ofrobots","id":79017,"avatar_url":"https://avatars2.githubusercontent.com/u/79017?v=3","gravatar_id":"","url":"https://api.github.com/users/ofrobots","html_url":"https://github.com/ofrobots","followers_url":"https://api.github.com/users/ofrobots/followers","following_url":"https://api.github.com/users/ofrobots/following{/other_user}","gists_url":"https://api.github.com/users/ofrobots/gists{/gist_id}","starred_url":"https://api.github.com/users/ofrobots/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofrobots/subscriptions","organizations_url":"https://api.github.com/users/ofrobots/orgs","repos_url":"https://api.github.com/users/ofrobots/repos","events_url":"https://api.github.com/users/ofrobots/events{/privacy}","received_events_url":"https://api.github.com/users/ofrobots/received_events","type":"User","site_admin":false},{"login":"DominicKramer","id":14253877,"avatar_url":"https://avatars0.githubusercontent.com/u/14253877?v=3","gravatar_id":"","url":"https://api.github.com/users/DominicKramer","html_url":"https://github.com/DominicKramer","followers_url":"https://api.github.com/users/DominicKramer/followers","following_url":"https://api.github.com/users/DominicKramer/following{/other_user}","gists_url":"https://api.github.com/users/DominicKramer/gists{/gist_id}","starred_url":"https://api.github.com/users/DominicKramer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DominicKramer/subscriptions","organizations_url":"https://api.github.com/users/DominicKramer/orgs","repos_url":"https://api.github.com/users/DominicKramer/repos","events_url":"https://api.github.com/users/DominicKramer/events{/privacy}","received_events_url":"https://api.github.com/users/DominicKramer/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/pulls/480/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/pulls/480/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/issues/480/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/statuses/16166461a16d6c5c723d58c9975cf1bce1e6c6e3","head":{"label":"kjin:internal-intercepts","ref":"internal-intercepts","sha":"16166461a16d6c5c723d58c9975cf1bce1e6c6e3","user":{"login":"kjin","id":2365820,"avatar_url":"https://avatars0.githubusercontent.com/u/2365820?v=3","gravatar_id":"","url":"https://api.github.com/users/kjin","html_url":"https://github.com/kjin","followers_url":"https://api.github.com/users/kjin/followers","following_url":"https://api.github.com/users/kjin/following{/other_user}","gists_url":"https://api.github.com/users/kjin/gists{/gist_id}","starred_url":"https://api.github.com/users/kjin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kjin/subscriptions","organizations_url":"https://api.github.com/users/kjin/orgs","repos_url":"https://api.github.com/users/kjin/repos","events_url":"https://api.github.com/users/kjin/events{/privacy}","received_events_url":"https://api.github.com/users/kjin/received_events","type":"User","site_admin":false},"repo":{"id":68134606,"name":"cloud-trace-nodejs","full_name":"kjin/cloud-trace-nodejs","owner":{"login":"kjin","id":2365820,"avatar_url":"https://avatars0.githubusercontent.com/u/2365820?v=3","gravatar_id":"","url":"https://api.github.com/users/kjin","html_url":"https://github.com/kjin","followers_url":"https://api.github.com/users/kjin/followers","following_url":"https://api.github.com/users/kjin/following{/other_user}","gists_url":"https://api.github.com/users/kjin/gists{/gist_id}","starred_url":"https://api.github.com/users/kjin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kjin/subscriptions","organizations_url":"https://api.github.com/users/kjin/orgs","repos_url":"https://api.github.com/users/kjin/repos","events_url":"https://api.github.com/users/kjin/events{/privacy}","received_events_url":"https://api.github.com/users/kjin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kjin/cloud-trace-nodejs","description":"Experimental Node.js support for Google Cloud Trace","fork":true,"url":"https://api.github.com/repos/kjin/cloud-trace-nodejs","forks_url":"https://api.github.com/repos/kjin/cloud-trace-nodejs/forks","keys_url":"https://api.github.com/repos/kjin/cloud-trace-nodejs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kjin/cloud-trace-nodejs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kjin/cloud-trace-nodejs/teams","hooks_url":"https://api.github.com/repos/kjin/cloud-trace-nodejs/hooks","issue_events_url":"https://api.github.com/repos/kjin/cloud-trace-nodejs/issues/events{/number}","events_url":"https://api.github.com/repos/kjin/cloud-trace-nodejs/events","assignees_url":"https://api.github.com/repos/kjin/cloud-trace-nodejs/assignees{/user}","branches_url":"https://api.github.com/repos/kjin/cloud-trace-nodejs/branches{/branch}","tags_url":"https://api.github.com/repos/kjin/cloud-trace-nodejs/tags","blobs_url":"https://api.github.com/repos/kjin/cloud-trace-nodejs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kjin/cloud-trace-nodejs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kjin/cloud-trace-nodejs/git/refs{/sha}","trees_url":"https://api.github.com/repos/kjin/cloud-trace-nodejs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kjin/cloud-trace-nodejs/statuses/{sha}","languages_url":"https://api.github.com/repos/kjin/cloud-trace-nodejs/languages","stargazers_url":"https://api.github.com/repos/kjin/cloud-trace-nodejs/stargazers","contributors_url":"https://api.github.com/repos/kjin/cloud-trace-nodejs/contributors","subscribers_url":"https://api.github.com/repos/kjin/cloud-trace-nodejs/subscribers","subscription_url":"https://api.github.com/repos/kjin/cloud-trace-nodejs/subscription","commits_url":"https://api.github.com/repos/kjin/cloud-trace-nodejs/commits{/sha}","git_commits_url":"https://api.github.com/repos/kjin/cloud-trace-nodejs/git/commits{/sha}","comments_url":"https://api.github.com/repos/kjin/cloud-trace-nodejs/comments{/number}","issue_comment_url":"https://api.github.com/repos/kjin/cloud-trace-nodejs/issues/comments{/number}","contents_url":"https://api.github.com/repos/kjin/cloud-trace-nodejs/contents/{+path}","compare_url":"https://api.github.com/repos/kjin/cloud-trace-nodejs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kjin/cloud-trace-nodejs/merges","archive_url":"https://api.github.com/repos/kjin/cloud-trace-nodejs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kjin/cloud-trace-nodejs/downloads","issues_url":"https://api.github.com/repos/kjin/cloud-trace-nodejs/issues{/number}","pulls_url":"https://api.github.com/repos/kjin/cloud-trace-nodejs/pulls{/number}","milestones_url":"https://api.github.com/repos/kjin/cloud-trace-nodejs/milestones{/number}","notifications_url":"https://api.github.com/repos/kjin/cloud-trace-nodejs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kjin/cloud-trace-nodejs/labels{/name}","releases_url":"https://api.github.com/repos/kjin/cloud-trace-nodejs/releases{/id}","deployments_url":"https://api.github.com/repos/kjin/cloud-trace-nodejs/deployments","created_at":"2016-09-13T18:12:30Z","updated_at":"2016-09-13T18:12:32Z","pushed_at":"2017-05-11T23:26:57Z","git_url":"git://github.com/kjin/cloud-trace-nodejs.git","ssh_url":"git@github.com:kjin/cloud-trace-nodejs.git","clone_url":"https://github.com/kjin/cloud-trace-nodejs.git","svn_url":"https://github.com/kjin/cloud-trace-nodejs","homepage":"https://cloud.google.com/cloud-trace/","size":1704,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"5080bfc306c34e03487fa90389c3952e276cab9e","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars3.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":41170869,"name":"cloud-trace-nodejs","full_name":"GoogleCloudPlatform/cloud-trace-nodejs","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars3.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/cloud-trace-nodejs","description":"Experimental Node.js support for Google Cloud Trace","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/deployments","created_at":"2015-08-21T18:23:09Z","updated_at":"2017-05-09T00:42:17Z","pushed_at":"2017-05-11T23:26:58Z","git_url":"git://github.com/GoogleCloudPlatform/cloud-trace-nodejs.git","ssh_url":"git@github.com:GoogleCloudPlatform/cloud-trace-nodejs.git","clone_url":"https://github.com/GoogleCloudPlatform/cloud-trace-nodejs.git","svn_url":"https://github.com/GoogleCloudPlatform/cloud-trace-nodejs","homepage":"https://cloud.google.com/cloud-trace/","size":1532,"stargazers_count":93,"watchers_count":93,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":39,"mirror_url":null,"open_issues_count":9,"forks":39,"open_issues":9,"watchers":93,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/pulls/480"},"html":{"href":"https://github.com/GoogleCloudPlatform/cloud-trace-nodejs/pull/480"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/issues/480"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/issues/480/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/pulls/480/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/pulls/480/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/statuses/16166461a16d6c5c723d58c9975cf1bce1e6c6e3"}}}}
{"actor":{"display_login":"matthewloring"}}