{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/abi-stable-node/issues/232","repository_url":"https://api.github.com/repos/nodejs/abi-stable-node","labels_url":"https://api.github.com/repos/nodejs/abi-stable-node/issues/232/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/abi-stable-node/issues/232/comments","events_url":"https://api.github.com/repos/nodejs/abi-stable-node/issues/232/events","html_url":"https://github.com/nodejs/abi-stable-node/issues/232","id":222215997,"number":232,"title":"Can't use node::FatalError()","user":{"login":"gabrielschulhof","id":976081,"avatar_url":"https://avatars1.githubusercontent.com/u/976081?v=3","gravatar_id":"","url":"https://api.github.com/users/gabrielschulhof","html_url":"https://github.com/gabrielschulhof","followers_url":"https://api.github.com/users/gabrielschulhof/followers","following_url":"https://api.github.com/users/gabrielschulhof/following{/other_user}","gists_url":"https://api.github.com/users/gabrielschulhof/gists{/gist_id}","starred_url":"https://api.github.com/users/gabrielschulhof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabrielschulhof/subscriptions","organizations_url":"https://api.github.com/users/gabrielschulhof/orgs","repos_url":"https://api.github.com/users/gabrielschulhof/repos","events_url":"https://api.github.com/users/gabrielschulhof/events{/privacy}","received_events_url":"https://api.github.com/users/gabrielschulhof/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2017-04-17T20:01:58Z","updated_at":"2017-05-04T22:40:12Z","closed_at":null,"body":"... because node_internals.h is not available outside of node. So, if we want node-api to contain unaltered versions of the implementation, we must not rely on any node internals.\r\n\r\nI guess we could simply throw a JS exception. Since `Isolate::GetCurrent()` is going away, and since we don't have an env from which to extract an isolate, is there some other way we can signal that we wish to throw an exception?"},"comment":{"url":"https://api.github.com/repos/nodejs/abi-stable-node/issues/comments/299328986","html_url":"https://github.com/nodejs/abi-stable-node/issues/232#issuecomment-299328986","issue_url":"https://api.github.com/repos/nodejs/abi-stable-node/issues/232","id":299328986,"user":{"login":"jasongin","id":13093042,"avatar_url":"https://avatars3.githubusercontent.com/u/13093042?v=3","gravatar_id":"","url":"https://api.github.com/users/jasongin","html_url":"https://github.com/jasongin","followers_url":"https://api.github.com/users/jasongin/followers","following_url":"https://api.github.com/users/jasongin/following{/other_user}","gists_url":"https://api.github.com/users/jasongin/gists{/gist_id}","starred_url":"https://api.github.com/users/jasongin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasongin/subscriptions","organizations_url":"https://api.github.com/users/jasongin/orgs","repos_url":"https://api.github.com/users/jasongin/repos","events_url":"https://api.github.com/users/jasongin/events{/privacy}","received_events_url":"https://api.github.com/users/jasongin/received_events","type":"User","site_admin":false},"created_at":"2017-05-04T22:40:12Z","updated_at":"2017-05-04T22:40:12Z","body":"We might want to actually expose `node::FatalError()` (or similar) as a `napi_fatal_error()` API. See https://github.com/nodejs/node-api/pull/32#discussion_r114903602 for a scenario where it is needed."}}
{"actor":{"display_login":"jasongin"}}