{"action":"created","comment":{"url":"https://api.github.com/repos/apache/carbondata/pulls/comments/129598686","pull_request_review_id":52389478,"id":129598686,"diff_hunk":"@@ -440,9 +510,16 @@ protected Expression getFilterPredicates(Configuration configuration) {\n         for (Map.Entry<SegmentTaskIndexStore.TaskBucketHolder, AbstractIndex> entry :\n             segmentIndexMap.entrySet()) {\n           SegmentTaskIndexStore.TaskBucketHolder taskHolder = entry.getKey();\n-          int taskId = CarbonTablePath.DataFileUtil.getTaskIdFromTaskNo(taskHolder.taskNo);\n+          int partitionId = CarbonTablePath.DataFileUtil.getTaskIdFromTaskNo(taskHolder.taskNo);\n+          //oldPartitionIdList is only used in alter table partition command because it change\n+          //partition info first and then read data.\n+          //for other normal query should use newest partitionIdList","path":"hadoop/src/main/java/org/apache/carbondata/hadoop/CarbonInputFormat.java","position":135,"original_position":135,"commit_id":"f851ec6230ca183f66ebaa2a6e55dc874f063959","original_commit_id":"f851ec6230ca183f66ebaa2a6e55dc874f063959","user":{"login":"chenerlu","id":20926078,"avatar_url":"https://avatars1.githubusercontent.com/u/20926078?v=4","gravatar_id":"","url":"https://api.github.com/users/chenerlu","html_url":"https://github.com/chenerlu","followers_url":"https://api.github.com/users/chenerlu/followers","following_url":"https://api.github.com/users/chenerlu/following{/other_user}","gists_url":"https://api.github.com/users/chenerlu/gists{/gist_id}","starred_url":"https://api.github.com/users/chenerlu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chenerlu/subscriptions","organizations_url":"https://api.github.com/users/chenerlu/orgs","repos_url":"https://api.github.com/users/chenerlu/repos","events_url":"https://api.github.com/users/chenerlu/events{/privacy}","received_events_url":"https://api.github.com/users/chenerlu/received_events","type":"User","site_admin":false},"body":"use /** */ instead if multi line notes.","created_at":"2017-07-26T15:03:02Z","updated_at":"2017-07-26T15:03:02Z","html_url":"https://github.com/apache/carbondata/pull/1192#discussion_r129598686","pull_request_url":"https://api.github.com/repos/apache/carbondata/pulls/1192","_links":{"self":{"href":"https://api.github.com/repos/apache/carbondata/pulls/comments/129598686"},"html":{"href":"https://github.com/apache/carbondata/pull/1192#discussion_r129598686"},"pull_request":{"href":"https://api.github.com/repos/apache/carbondata/pulls/1192"}}},"pull_request":{"url":"https://api.github.com/repos/apache/carbondata/pulls/1192","id":131928370,"html_url":"https://github.com/apache/carbondata/pull/1192","diff_url":"https://github.com/apache/carbondata/pull/1192.diff","patch_url":"https://github.com/apache/carbondata/pull/1192.patch","issue_url":"https://api.github.com/repos/apache/carbondata/issues/1192","number":1192,"state":"open","locked":false,"title":"[CARBONDATA-940] alter table add/split partition for spark 2.1","user":{"login":"lionelcao","id":5790174,"avatar_url":"https://avatars3.githubusercontent.com/u/5790174?v=4","gravatar_id":"","url":"https://api.github.com/users/lionelcao","html_url":"https://github.com/lionelcao","followers_url":"https://api.github.com/users/lionelcao/followers","following_url":"https://api.github.com/users/lionelcao/following{/other_user}","gists_url":"https://api.github.com/users/lionelcao/gists{/gist_id}","starred_url":"https://api.github.com/users/lionelcao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lionelcao/subscriptions","organizations_url":"https://api.github.com/users/lionelcao/orgs","repos_url":"https://api.github.com/users/lionelcao/repos","events_url":"https://api.github.com/users/lionelcao/events{/privacy}","received_events_url":"https://api.github.com/users/lionelcao/received_events","type":"User","site_admin":false},"body":"add/split partition function","created_at":"2017-07-23T09:44:12Z","updated_at":"2017-07-26T15:03:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d13b5b893aabf97151e9d3caec4e87d34882e429","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/carbondata/pulls/1192/commits","review_comments_url":"https://api.github.com/repos/apache/carbondata/pulls/1192/comments","review_comment_url":"https://api.github.com/repos/apache/carbondata/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/carbondata/issues/1192/comments","statuses_url":"https://api.github.com/repos/apache/carbondata/statuses/f851ec6230ca183f66ebaa2a6e55dc874f063959","head":{"label":"lionelcao:carbon_910_06","ref":"carbon_910_06","sha":"f851ec6230ca183f66ebaa2a6e55dc874f063959","user":{"login":"lionelcao","id":5790174,"avatar_url":"https://avatars3.githubusercontent.com/u/5790174?v=4","gravatar_id":"","url":"https://api.github.com/users/lionelcao","html_url":"https://github.com/lionelcao","followers_url":"https://api.github.com/users/lionelcao/followers","following_url":"https://api.github.com/users/lionelcao/following{/other_user}","gists_url":"https://api.github.com/users/lionelcao/gists{/gist_id}","starred_url":"https://api.github.com/users/lionelcao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lionelcao/subscriptions","organizations_url":"https://api.github.com/users/lionelcao/orgs","repos_url":"https://api.github.com/users/lionelcao/repos","events_url":"https://api.github.com/users/lionelcao/events{/privacy}","received_events_url":"https://api.github.com/users/lionelcao/received_events","type":"User","site_admin":false},"repo":{"id":75699428,"name":"carbondata","full_name":"lionelcao/carbondata","owner":{"login":"lionelcao","id":5790174,"avatar_url":"https://avatars3.githubusercontent.com/u/5790174?v=4","gravatar_id":"","url":"https://api.github.com/users/lionelcao","html_url":"https://github.com/lionelcao","followers_url":"https://api.github.com/users/lionelcao/followers","following_url":"https://api.github.com/users/lionelcao/following{/other_user}","gists_url":"https://api.github.com/users/lionelcao/gists{/gist_id}","starred_url":"https://api.github.com/users/lionelcao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lionelcao/subscriptions","organizations_url":"https://api.github.com/users/lionelcao/orgs","repos_url":"https://api.github.com/users/lionelcao/repos","events_url":"https://api.github.com/users/lionelcao/events{/privacy}","received_events_url":"https://api.github.com/users/lionelcao/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lionelcao/carbondata","description":"Mirror of Apache CarbonData","fork":true,"url":"https://api.github.com/repos/lionelcao/carbondata","forks_url":"https://api.github.com/repos/lionelcao/carbondata/forks","keys_url":"https://api.github.com/repos/lionelcao/carbondata/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lionelcao/carbondata/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lionelcao/carbondata/teams","hooks_url":"https://api.github.com/repos/lionelcao/carbondata/hooks","issue_events_url":"https://api.github.com/repos/lionelcao/carbondata/issues/events{/number}","events_url":"https://api.github.com/repos/lionelcao/carbondata/events","assignees_url":"https://api.github.com/repos/lionelcao/carbondata/assignees{/user}","branches_url":"https://api.github.com/repos/lionelcao/carbondata/branches{/branch}","tags_url":"https://api.github.com/repos/lionelcao/carbondata/tags","blobs_url":"https://api.github.com/repos/lionelcao/carbondata/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lionelcao/carbondata/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lionelcao/carbondata/git/refs{/sha}","trees_url":"https://api.github.com/repos/lionelcao/carbondata/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lionelcao/carbondata/statuses/{sha}","languages_url":"https://api.github.com/repos/lionelcao/carbondata/languages","stargazers_url":"https://api.github.com/repos/lionelcao/carbondata/stargazers","contributors_url":"https://api.github.com/repos/lionelcao/carbondata/contributors","subscribers_url":"https://api.github.com/repos/lionelcao/carbondata/subscribers","subscription_url":"https://api.github.com/repos/lionelcao/carbondata/subscription","commits_url":"https://api.github.com/repos/lionelcao/carbondata/commits{/sha}","git_commits_url":"https://api.github.com/repos/lionelcao/carbondata/git/commits{/sha}","comments_url":"https://api.github.com/repos/lionelcao/carbondata/comments{/number}","issue_comment_url":"https://api.github.com/repos/lionelcao/carbondata/issues/comments{/number}","contents_url":"https://api.github.com/repos/lionelcao/carbondata/contents/{+path}","compare_url":"https://api.github.com/repos/lionelcao/carbondata/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lionelcao/carbondata/merges","archive_url":"https://api.github.com/repos/lionelcao/carbondata/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lionelcao/carbondata/downloads","issues_url":"https://api.github.com/repos/lionelcao/carbondata/issues{/number}","pulls_url":"https://api.github.com/repos/lionelcao/carbondata/pulls{/number}","milestones_url":"https://api.github.com/repos/lionelcao/carbondata/milestones{/number}","notifications_url":"https://api.github.com/repos/lionelcao/carbondata/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lionelcao/carbondata/labels{/name}","releases_url":"https://api.github.com/repos/lionelcao/carbondata/releases{/id}","deployments_url":"https://api.github.com/repos/lionelcao/carbondata/deployments","created_at":"2016-12-06T05:55:28Z","updated_at":"2017-05-13T12:02:57Z","pushed_at":"2017-07-24T07:47:00Z","git_url":"git://github.com/lionelcao/carbondata.git","ssh_url":"git@github.com:lionelcao/carbondata.git","clone_url":"https://github.com/lionelcao/carbondata.git","svn_url":"https://github.com/lionelcao/carbondata","homepage":"","size":46880,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"cf2a829db49be36a746a4460d03d5b1f0de909c4","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":62117818,"name":"carbondata","full_name":"apache/carbondata","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/carbondata","description":"Mirror of Apache CarbonData","fork":false,"url":"https://api.github.com/repos/apache/carbondata","forks_url":"https://api.github.com/repos/apache/carbondata/forks","keys_url":"https://api.github.com/repos/apache/carbondata/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/carbondata/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/carbondata/teams","hooks_url":"https://api.github.com/repos/apache/carbondata/hooks","issue_events_url":"https://api.github.com/repos/apache/carbondata/issues/events{/number}","events_url":"https://api.github.com/repos/apache/carbondata/events","assignees_url":"https://api.github.com/repos/apache/carbondata/assignees{/user}","branches_url":"https://api.github.com/repos/apache/carbondata/branches{/branch}","tags_url":"https://api.github.com/repos/apache/carbondata/tags","blobs_url":"https://api.github.com/repos/apache/carbondata/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/carbondata/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/carbondata/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/carbondata/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/carbondata/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/carbondata/languages","stargazers_url":"https://api.github.com/repos/apache/carbondata/stargazers","contributors_url":"https://api.github.com/repos/apache/carbondata/contributors","subscribers_url":"https://api.github.com/repos/apache/carbondata/subscribers","subscription_url":"https://api.github.com/repos/apache/carbondata/subscription","commits_url":"https://api.github.com/repos/apache/carbondata/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/carbondata/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/carbondata/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/carbondata/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/carbondata/contents/{+path}","compare_url":"https://api.github.com/repos/apache/carbondata/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/carbondata/merges","archive_url":"https://api.github.com/repos/apache/carbondata/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/carbondata/downloads","issues_url":"https://api.github.com/repos/apache/carbondata/issues{/number}","pulls_url":"https://api.github.com/repos/apache/carbondata/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/carbondata/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/carbondata/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/carbondata/labels{/name}","releases_url":"https://api.github.com/repos/apache/carbondata/releases{/id}","deployments_url":"https://api.github.com/repos/apache/carbondata/deployments","created_at":"2016-06-28T07:00:06Z","updated_at":"2017-07-26T07:56:36Z","pushed_at":"2017-07-26T14:37:22Z","git_url":"git://github.com/apache/carbondata.git","ssh_url":"git@github.com:apache/carbondata.git","clone_url":"https://github.com/apache/carbondata.git","svn_url":"https://github.com/apache/carbondata","homepage":"","size":47153,"stargazers_count":448,"watchers_count":448,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":321,"mirror_url":"git://git.apache.org/carbondata.git","open_issues_count":101,"forks":321,"open_issues":101,"watchers":448,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/carbondata/pulls/1192"},"html":{"href":"https://github.com/apache/carbondata/pull/1192"},"issue":{"href":"https://api.github.com/repos/apache/carbondata/issues/1192"},"comments":{"href":"https://api.github.com/repos/apache/carbondata/issues/1192/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/carbondata/pulls/1192/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/carbondata/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/carbondata/pulls/1192/commits"},"statuses":{"href":"https://api.github.com/repos/apache/carbondata/statuses/f851ec6230ca183f66ebaa2a6e55dc874f063959"}}}}
{"actor":{"display_login":"chenerlu"}}