{"push_id":2076706252,"size":31,"distinct_size":30,"ref":"refs/heads/10232017-clang_format-sanitize","head":"8d802a3aa4fd67a0a7a43dcfb1e30012802e98d8","before":"ec1e314889f599b3a61d4dc4a73ce38db02e8a1d","commits":[{"sha":"e67f3af48c94c9456c3ff376dc30c82a4bf982cd","author":{"name":"Yong Tang","email":"c7f96a9af986d7b6079b1ae942cbbfb7d768044b@outlook.com"},"message":"Use 'LABEL maintainer=' in Dockerfile (#13961)\n\n* Use 'LABEL maintainer=' in Dockerfile\r\n\r\nThis fix is a follow up of 13661 to replace `MAINTAINER`\r\nwith `LABEL maintainer=` in Dockerfile. The keyword\r\n`MAINTAINER` has long been deprecated and is replaced by `LABEL`,\r\nwhich is much more flexible and is easily searchable through `docker inspect`.\r\n\r\nThis fix replaces remaining `MAINTAINER` with `LABEL`.\r\n\r\nSigned-off-by: Yong Tang <yong.tang.github@outlook.com>\r\n\r\n* Additional `MAITAINER` -> `LABEL`\r\n\r\nSigned-off-by: Yong Tang <yong.tang.github@outlook.com>","distinct":false,"url":"https://api.github.com/repos/yongtang/tensorflow/commits/e67f3af48c94c9456c3ff376dc30c82a4bf982cd"},{"sha":"f35fe139527c7d48b81c2d6d16ae7692fa310e5d","author":{"name":"Yong Tang","email":"c7f96a9af986d7b6079b1ae942cbbfb7d768044b@outlook.com"},"message":"Add clang style check as part of the sanity check.\n\nThis fix is an effort to add clang style check as part of the sanity check.\n\nIn `CONTRIBUTING.md` it has been advised to run `clang-format --style=google file.cc`\nso that Google coding style is conformed. However, there is no sanity check\nin the current Jenkins build so current .cc and .h files in the repo are not really\nconforming to the coding style.\n\nThis actually causes issues. In case a PR is submitted with `clang-format --style=google file.cc`,\nthe reviewer may see additional unrelated changes which might be a distraction. The\ndeveloper may also spent additional time to manually check for any discrepancies manually with additional\nunrelated style changes.\n\nThis fix adds the clang-format check to the ci build so that when `ci_sanity.sh` is running,\nit will use clang-format to make sure the code is conforming to the coding style as specified\nin `CONTRIBUTING.md`.\n\nOne thing that might need to take notice is the header order of the Eigen library. See\nhttps://github.com/tensorflow/tensorflow/pull/13907#issuecomment-338718110\nfor further details.\n\nBasically, if Eigen headers could be placed in any order, then no additional steps are needed.\nOtherwise, it is always possible to place the Eigen headers at the top, then leave one empty\nline like:\n```cpp\n\n```\n\nIn this way, even a run of `clang-format -i --style=google file.cc` will still respect\nthe order and leave Eigen header at the top.\n\nThis PR is experimeal so it only checks `tensorflow/core/ops` directory. Other files could be\nadded if this PR is OK.\n\nThis PR also sanitizes all files in `tensorflow/core/ops` directory so that it conforms to\ncoding style requirement.\n\nSigned-off-by: Yong Tang <yong.tang.github@outlook.com>","distinct":true,"url":"https://api.github.com/repos/yongtang/tensorflow/commits/f35fe139527c7d48b81c2d6d16ae7692fa310e5d"},{"sha":"b2c929083ddbf6c2f6e16b15a4de8d82244d72f2","author":{"name":"Yong Tang","email":"c7f96a9af986d7b6079b1ae942cbbfb7d768044b@outlook.com"},"message":"Add installation of clang-format-3.8, this will not conflict with clang\n\nAdd installation of clang-format-3.8, this will not conflict with clang\nas command line needs to run with `clang-format-3.8 -i --style=Google`\n\nSigned-off-by: Yong Tang <yong.tang.github@outlook.com>","distinct":true,"url":"https://api.github.com/repos/yongtang/tensorflow/commits/b2c929083ddbf6c2f6e16b15a4de8d82244d72f2"},{"sha":"af9f2d87cb42d398f5d4968bc7155ec8d9fceda6","author":{"name":"Yong Tang","email":"c7f96a9af986d7b6079b1ae942cbbfb7d768044b@outlook.com"},"message":"Sanitize files in tensorflow/core/ops with clang-format -i\n\nSigned-off-by: Yong Tang <yong.tang.github@outlook.com>","distinct":true,"url":"https://api.github.com/repos/yongtang/tensorflow/commits/af9f2d87cb42d398f5d4968bc7155ec8d9fceda6"},{"sha":"f2b973568d94facc833013aa98e7b0c48c7c5a5e","author":{"name":"Yong Tang","email":"c7f96a9af986d7b6079b1ae942cbbfb7d768044b@outlook.com"},"message":"Add the option to do an incremental clang  style check.\n\nSigned-off-by: Yong Tang <yong.tang.github@outlook.com>","distinct":true,"url":"https://api.github.com/repos/yongtang/tensorflow/commits/f2b973568d94facc833013aa98e7b0c48c7c5a5e"},{"sha":"16b11051fd48719448293b2525d0929be38cb31c","author":{"name":"Yong Tang","email":"c7f96a9af986d7b6079b1ae942cbbfb7d768044b@outlook.com"},"message":"Sanitize with clang-format for tensorflow/c\n\nSigned-off-by: Yong Tang <yong.tang.github@outlook.com>","distinct":true,"url":"https://api.github.com/repos/yongtang/tensorflow/commits/16b11051fd48719448293b2525d0929be38cb31c"},{"sha":"e623fecf5a44388f729eccfc8b740f6840ee949f","author":{"name":"Yong Tang","email":"c7f96a9af986d7b6079b1ae942cbbfb7d768044b@outlook.com"},"message":"Sanitize with clang-format for tensorflow/cc\n\nSigned-off-by: Yong Tang <yong.tang.github@outlook.com>","distinct":true,"url":"https://api.github.com/repos/yongtang/tensorflow/commits/e623fecf5a44388f729eccfc8b740f6840ee949f"},{"sha":"bf00302fcca81d8f295718121a9ff732446dff49","author":{"name":"Yong Tang","email":"c7f96a9af986d7b6079b1ae942cbbfb7d768044b@outlook.com"},"message":"Sanitize with clang-format for tensorflow/compiler\n\nSigned-off-by: Yong Tang <yong.tang.github@outlook.com>","distinct":true,"url":"https://api.github.com/repos/yongtang/tensorflow/commits/bf00302fcca81d8f295718121a9ff732446dff49"},{"sha":"fa2b069db96191a0258f1586856776cd1607a481","author":{"name":"Yong Tang","email":"c7f96a9af986d7b6079b1ae942cbbfb7d768044b@outlook.com"},"message":"Sanitize with clang-format for tensorflow/contrib\n\nSigned-off-by: Yong Tang <yong.tang.github@outlook.com>","distinct":true,"url":"https://api.github.com/repos/yongtang/tensorflow/commits/fa2b069db96191a0258f1586856776cd1607a481"},{"sha":"111d57faf3ad0349f8d8d484d4426f244c393cb5","author":{"name":"Yong Tang","email":"c7f96a9af986d7b6079b1ae942cbbfb7d768044b@outlook.com"},"message":"Sanitize with clang-format for tensorflow/examples\n\nSigned-off-by: Yong Tang <yong.tang.github@outlook.com>","distinct":true,"url":"https://api.github.com/repos/yongtang/tensorflow/commits/111d57faf3ad0349f8d8d484d4426f244c393cb5"},{"sha":"2030c7c6a7fd1fffbd479c43c0c4a59c6195eb64","author":{"name":"Yong Tang","email":"c7f96a9af986d7b6079b1ae942cbbfb7d768044b@outlook.com"},"message":"Sanitize with clang-format for tensorflow/java\n\nSigned-off-by: Yong Tang <yong.tang.github@outlook.com>","distinct":true,"url":"https://api.github.com/repos/yongtang/tensorflow/commits/2030c7c6a7fd1fffbd479c43c0c4a59c6195eb64"},{"sha":"831bc1466276d5dbe3b1f8e70caeabbea0be6309","author":{"name":"Yong Tang","email":"c7f96a9af986d7b6079b1ae942cbbfb7d768044b@outlook.com"},"message":"Sanitize with clang-format for tensorflow/python\n\nSigned-off-by: Yong Tang <yong.tang.github@outlook.com>","distinct":true,"url":"https://api.github.com/repos/yongtang/tensorflow/commits/831bc1466276d5dbe3b1f8e70caeabbea0be6309"},{"sha":"1e63db2f110830a6578f75a903560622a53a0710","author":{"name":"Yong Tang","email":"c7f96a9af986d7b6079b1ae942cbbfb7d768044b@outlook.com"},"message":"Sanitize with clang-format for tensorflow/stream_executor\n\nSigned-off-by: Yong Tang <yong.tang.github@outlook.com>","distinct":true,"url":"https://api.github.com/repos/yongtang/tensorflow/commits/1e63db2f110830a6578f75a903560622a53a0710"},{"sha":"0abe71a1de7f0366da6cfd74a3a1b20b5fa7a386","author":{"name":"Yong Tang","email":"c7f96a9af986d7b6079b1ae942cbbfb7d768044b@outlook.com"},"message":"Sanitize with clang-format for tensorflow/tools\n\nSigned-off-by: Yong Tang <yong.tang.github@outlook.com>","distinct":true,"url":"https://api.github.com/repos/yongtang/tensorflow/commits/0abe71a1de7f0366da6cfd74a3a1b20b5fa7a386"},{"sha":"e04ce6666fe1a9a38d9091fb97c9f41dbb6428f6","author":{"name":"Yong Tang","email":"c7f96a9af986d7b6079b1ae942cbbfb7d768044b@outlook.com"},"message":"Sanitize with clang-format for tensorflow/user_ops\n\nSigned-off-by: Yong Tang <yong.tang.github@outlook.com>","distinct":true,"url":"https://api.github.com/repos/yongtang/tensorflow/commits/e04ce6666fe1a9a38d9091fb97c9f41dbb6428f6"},{"sha":"adb070c09f5c12f733c1df3053b40dafb9051ea0","author":{"name":"Yong Tang","email":"c7f96a9af986d7b6079b1ae942cbbfb7d768044b@outlook.com"},"message":"Sanitize with clang-format for tensorflow/core/api_def\n\nSigned-off-by: Yong Tang <yong.tang.github@outlook.com>","distinct":true,"url":"https://api.github.com/repos/yongtang/tensorflow/commits/adb070c09f5c12f733c1df3053b40dafb9051ea0"},{"sha":"37e328b5a5e55b4e5e2b35f0956ecc9c43016293","author":{"name":"Yong Tang","email":"c7f96a9af986d7b6079b1ae942cbbfb7d768044b@outlook.com"},"message":"Sanitize with clang-format for tensorflow/core/common_runtime\n\nSigned-off-by: Yong Tang <yong.tang.github@outlook.com>","distinct":true,"url":"https://api.github.com/repos/yongtang/tensorflow/commits/37e328b5a5e55b4e5e2b35f0956ecc9c43016293"},{"sha":"a79f2de855308fc0b42b67de33e97c6cc8601c7b","author":{"name":"Yong Tang","email":"c7f96a9af986d7b6079b1ae942cbbfb7d768044b@outlook.com"},"message":"Sanitize with clang-format for tensorflow/core/debug\n\nSigned-off-by: Yong Tang <yong.tang.github@outlook.com>","distinct":true,"url":"https://api.github.com/repos/yongtang/tensorflow/commits/a79f2de855308fc0b42b67de33e97c6cc8601c7b"},{"sha":"d5befbbe58896213330e64b7c1d8fea0f1b7d54f","author":{"name":"Yong Tang","email":"c7f96a9af986d7b6079b1ae942cbbfb7d768044b@outlook.com"},"message":"Sanitize with clang-format for tensorflow/core/distributed_runtime\n\nSigned-off-by: Yong Tang <yong.tang.github@outlook.com>","distinct":true,"url":"https://api.github.com/repos/yongtang/tensorflow/commits/d5befbbe58896213330e64b7c1d8fea0f1b7d54f"},{"sha":"5d6fd5dd6cd6d5cfe4b2730f8ca0e9f1db09d245","author":{"name":"Yong Tang","email":"c7f96a9af986d7b6079b1ae942cbbfb7d768044b@outlook.com"},"message":"Sanitize with clang-format for tensorflow/core/example\n\nSigned-off-by: Yong Tang <yong.tang.github@outlook.com>","distinct":true,"url":"https://api.github.com/repos/yongtang/tensorflow/commits/5d6fd5dd6cd6d5cfe4b2730f8ca0e9f1db09d245"}]}
{"actor":{"display_login":"yongtang"}}