{"action":"created","comment":{"url":"https://api.github.com/repos/juju/juju-gui/pulls/comments/120539211","pull_request_review_id":42508133,"id":120539211,"diff_hunk":"@@ -272,6 +285,8 @@ YUI.add('store', function() {\n               <h2>Kubernetes</h2>\n               {kubernetesButton}\n             </div>\n+            <span onClick={this._handleSearchClick}","path":"jujugui/static/gui/src/app/components/store/store.js","position":63,"original_position":63,"commit_id":"a4c06cfc7c5c6d85ea91af023e1c4245273d43b1","original_commit_id":"a4c06cfc7c5c6d85ea91af023e1c4245273d43b1","user":{"login":"huwshimi","id":361637,"avatar_url":"https://avatars3.githubusercontent.com/u/361637?v=3","gravatar_id":"","url":"https://api.github.com/users/huwshimi","html_url":"https://github.com/huwshimi","followers_url":"https://api.github.com/users/huwshimi/followers","following_url":"https://api.github.com/users/huwshimi/following{/other_user}","gists_url":"https://api.github.com/users/huwshimi/gists{/gist_id}","starred_url":"https://api.github.com/users/huwshimi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huwshimi/subscriptions","organizations_url":"https://api.github.com/users/huwshimi/orgs","repos_url":"https://api.github.com/users/huwshimi/repos","events_url":"https://api.github.com/users/huwshimi/events{/privacy}","received_events_url":"https://api.github.com/users/huwshimi/received_events","type":"User","site_admin":false},"body":"That would be because `_handleSearchClick` uses `evt.target` instead of `evt.currentTarget`, it doesn't look like changing it will be break the other links, but might be worth a quick check. ","created_at":"2017-06-07T05:47:16Z","updated_at":"2017-06-07T05:47:16Z","html_url":"https://github.com/juju/juju-gui/pull/2974#discussion_r120539211","pull_request_url":"https://api.github.com/repos/juju/juju-gui/pulls/2974","_links":{"self":{"href":"https://api.github.com/repos/juju/juju-gui/pulls/comments/120539211"},"html":{"href":"https://github.com/juju/juju-gui/pull/2974#discussion_r120539211"},"pull_request":{"href":"https://api.github.com/repos/juju/juju-gui/pulls/2974"}}},"pull_request":{"url":"https://api.github.com/repos/juju/juju-gui/pulls/2974","id":123939862,"html_url":"https://github.com/juju/juju-gui/pull/2974","diff_url":"https://github.com/juju/juju-gui/pull/2974.diff","patch_url":"https://github.com/juju/juju-gui/pull/2974.patch","issue_url":"https://api.github.com/repos/juju/juju-gui/issues/2974","number":2974,"state":"open","locked":false,"title":"Makes store hero boxes clickable","user":{"login":"Lukewh","id":479384,"avatar_url":"https://avatars0.githubusercontent.com/u/479384?v=3","gravatar_id":"","url":"https://api.github.com/users/Lukewh","html_url":"https://github.com/Lukewh","followers_url":"https://api.github.com/users/Lukewh/followers","following_url":"https://api.github.com/users/Lukewh/following{/other_user}","gists_url":"https://api.github.com/users/Lukewh/gists{/gist_id}","starred_url":"https://api.github.com/users/Lukewh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lukewh/subscriptions","organizations_url":"https://api.github.com/users/Lukewh/orgs","repos_url":"https://api.github.com/users/Lukewh/repos","events_url":"https://api.github.com/users/Lukewh/events{/privacy}","received_events_url":"https://api.github.com/users/Lukewh/received_events","type":"User","site_admin":false},"body":"... to perform a search for those items. The 'find out more' button still links to jujucharms.com/:page","created_at":"2017-06-05T09:07:36Z","updated_at":"2017-06-07T05:47:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2c32f75ec7b764f0f9ad220f7912911f7af6c73a","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/juju/juju-gui/milestones/31","html_url":"https://github.com/juju/juju-gui/milestone/31","labels_url":"https://api.github.com/repos/juju/juju-gui/milestones/31/labels","id":2443551,"number":31,"title":"jovial janeway","description":"","creator":{"login":"frankban","id":1408172,"avatar_url":"https://avatars3.githubusercontent.com/u/1408172?v=3","gravatar_id":"","url":"https://api.github.com/users/frankban","html_url":"https://github.com/frankban","followers_url":"https://api.github.com/users/frankban/followers","following_url":"https://api.github.com/users/frankban/following{/other_user}","gists_url":"https://api.github.com/users/frankban/gists{/gist_id}","starred_url":"https://api.github.com/users/frankban/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frankban/subscriptions","organizations_url":"https://api.github.com/users/frankban/orgs","repos_url":"https://api.github.com/users/frankban/repos","events_url":"https://api.github.com/users/frankban/events{/privacy}","received_events_url":"https://api.github.com/users/frankban/received_events","type":"User","site_admin":false},"open_issues":32,"closed_issues":7,"state":"open","created_at":"2017-04-07T16:05:28Z","updated_at":"2017-06-07T05:39:52Z","due_on":"2017-06-15T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/juju/juju-gui/pulls/2974/commits","review_comments_url":"https://api.github.com/repos/juju/juju-gui/pulls/2974/comments","review_comment_url":"https://api.github.com/repos/juju/juju-gui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/juju/juju-gui/issues/2974/comments","statuses_url":"https://api.github.com/repos/juju/juju-gui/statuses/a4c06cfc7c5c6d85ea91af023e1c4245273d43b1","head":{"label":"Lukewh:store-hero-click","ref":"store-hero-click","sha":"a4c06cfc7c5c6d85ea91af023e1c4245273d43b1","user":{"login":"Lukewh","id":479384,"avatar_url":"https://avatars0.githubusercontent.com/u/479384?v=3","gravatar_id":"","url":"https://api.github.com/users/Lukewh","html_url":"https://github.com/Lukewh","followers_url":"https://api.github.com/users/Lukewh/followers","following_url":"https://api.github.com/users/Lukewh/following{/other_user}","gists_url":"https://api.github.com/users/Lukewh/gists{/gist_id}","starred_url":"https://api.github.com/users/Lukewh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lukewh/subscriptions","organizations_url":"https://api.github.com/users/Lukewh/orgs","repos_url":"https://api.github.com/users/Lukewh/repos","events_url":"https://api.github.com/users/Lukewh/events{/privacy}","received_events_url":"https://api.github.com/users/Lukewh/received_events","type":"User","site_admin":false},"repo":{"id":79209822,"name":"juju-gui","full_name":"Lukewh/juju-gui","owner":{"login":"Lukewh","id":479384,"avatar_url":"https://avatars0.githubusercontent.com/u/479384?v=3","gravatar_id":"","url":"https://api.github.com/users/Lukewh","html_url":"https://github.com/Lukewh","followers_url":"https://api.github.com/users/Lukewh/followers","following_url":"https://api.github.com/users/Lukewh/following{/other_user}","gists_url":"https://api.github.com/users/Lukewh/gists{/gist_id}","starred_url":"https://api.github.com/users/Lukewh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lukewh/subscriptions","organizations_url":"https://api.github.com/users/Lukewh/orgs","repos_url":"https://api.github.com/users/Lukewh/repos","events_url":"https://api.github.com/users/Lukewh/events{/privacy}","received_events_url":"https://api.github.com/users/Lukewh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Lukewh/juju-gui","description":"Juju-GUI is a web-based GUI for Juju <https://jujucharms.com/>.","fork":true,"url":"https://api.github.com/repos/Lukewh/juju-gui","forks_url":"https://api.github.com/repos/Lukewh/juju-gui/forks","keys_url":"https://api.github.com/repos/Lukewh/juju-gui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Lukewh/juju-gui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Lukewh/juju-gui/teams","hooks_url":"https://api.github.com/repos/Lukewh/juju-gui/hooks","issue_events_url":"https://api.github.com/repos/Lukewh/juju-gui/issues/events{/number}","events_url":"https://api.github.com/repos/Lukewh/juju-gui/events","assignees_url":"https://api.github.com/repos/Lukewh/juju-gui/assignees{/user}","branches_url":"https://api.github.com/repos/Lukewh/juju-gui/branches{/branch}","tags_url":"https://api.github.com/repos/Lukewh/juju-gui/tags","blobs_url":"https://api.github.com/repos/Lukewh/juju-gui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Lukewh/juju-gui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Lukewh/juju-gui/git/refs{/sha}","trees_url":"https://api.github.com/repos/Lukewh/juju-gui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Lukewh/juju-gui/statuses/{sha}","languages_url":"https://api.github.com/repos/Lukewh/juju-gui/languages","stargazers_url":"https://api.github.com/repos/Lukewh/juju-gui/stargazers","contributors_url":"https://api.github.com/repos/Lukewh/juju-gui/contributors","subscribers_url":"https://api.github.com/repos/Lukewh/juju-gui/subscribers","subscription_url":"https://api.github.com/repos/Lukewh/juju-gui/subscription","commits_url":"https://api.github.com/repos/Lukewh/juju-gui/commits{/sha}","git_commits_url":"https://api.github.com/repos/Lukewh/juju-gui/git/commits{/sha}","comments_url":"https://api.github.com/repos/Lukewh/juju-gui/comments{/number}","issue_comment_url":"https://api.github.com/repos/Lukewh/juju-gui/issues/comments{/number}","contents_url":"https://api.github.com/repos/Lukewh/juju-gui/contents/{+path}","compare_url":"https://api.github.com/repos/Lukewh/juju-gui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Lukewh/juju-gui/merges","archive_url":"https://api.github.com/repos/Lukewh/juju-gui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Lukewh/juju-gui/downloads","issues_url":"https://api.github.com/repos/Lukewh/juju-gui/issues{/number}","pulls_url":"https://api.github.com/repos/Lukewh/juju-gui/pulls{/number}","milestones_url":"https://api.github.com/repos/Lukewh/juju-gui/milestones{/number}","notifications_url":"https://api.github.com/repos/Lukewh/juju-gui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Lukewh/juju-gui/labels{/name}","releases_url":"https://api.github.com/repos/Lukewh/juju-gui/releases{/id}","deployments_url":"https://api.github.com/repos/Lukewh/juju-gui/deployments","created_at":"2017-01-17T09:16:02Z","updated_at":"2017-01-17T09:16:08Z","pushed_at":"2017-06-05T09:59:43Z","git_url":"git://github.com/Lukewh/juju-gui.git","ssh_url":"git@github.com:Lukewh/juju-gui.git","clone_url":"https://github.com/Lukewh/juju-gui.git","svn_url":"https://github.com/Lukewh/juju-gui","homepage":"","size":123080,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"juju:develop","ref":"develop","sha":"4987d80540887983acfc78fe66747ca72a95c19c","user":{"login":"juju","id":4604548,"avatar_url":"https://avatars3.githubusercontent.com/u/4604548?v=3","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"repo":{"id":14960387,"name":"juju-gui","full_name":"juju/juju-gui","owner":{"login":"juju","id":4604548,"avatar_url":"https://avatars3.githubusercontent.com/u/4604548?v=3","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/juju/juju-gui","description":"Juju-GUI is a web-based GUI for Juju <https://jujucharms.com/>.","fork":false,"url":"https://api.github.com/repos/juju/juju-gui","forks_url":"https://api.github.com/repos/juju/juju-gui/forks","keys_url":"https://api.github.com/repos/juju/juju-gui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juju/juju-gui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juju/juju-gui/teams","hooks_url":"https://api.github.com/repos/juju/juju-gui/hooks","issue_events_url":"https://api.github.com/repos/juju/juju-gui/issues/events{/number}","events_url":"https://api.github.com/repos/juju/juju-gui/events","assignees_url":"https://api.github.com/repos/juju/juju-gui/assignees{/user}","branches_url":"https://api.github.com/repos/juju/juju-gui/branches{/branch}","tags_url":"https://api.github.com/repos/juju/juju-gui/tags","blobs_url":"https://api.github.com/repos/juju/juju-gui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juju/juju-gui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juju/juju-gui/git/refs{/sha}","trees_url":"https://api.github.com/repos/juju/juju-gui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juju/juju-gui/statuses/{sha}","languages_url":"https://api.github.com/repos/juju/juju-gui/languages","stargazers_url":"https://api.github.com/repos/juju/juju-gui/stargazers","contributors_url":"https://api.github.com/repos/juju/juju-gui/contributors","subscribers_url":"https://api.github.com/repos/juju/juju-gui/subscribers","subscription_url":"https://api.github.com/repos/juju/juju-gui/subscription","commits_url":"https://api.github.com/repos/juju/juju-gui/commits{/sha}","git_commits_url":"https://api.github.com/repos/juju/juju-gui/git/commits{/sha}","comments_url":"https://api.github.com/repos/juju/juju-gui/comments{/number}","issue_comment_url":"https://api.github.com/repos/juju/juju-gui/issues/comments{/number}","contents_url":"https://api.github.com/repos/juju/juju-gui/contents/{+path}","compare_url":"https://api.github.com/repos/juju/juju-gui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juju/juju-gui/merges","archive_url":"https://api.github.com/repos/juju/juju-gui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juju/juju-gui/downloads","issues_url":"https://api.github.com/repos/juju/juju-gui/issues{/number}","pulls_url":"https://api.github.com/repos/juju/juju-gui/pulls{/number}","milestones_url":"https://api.github.com/repos/juju/juju-gui/milestones{/number}","notifications_url":"https://api.github.com/repos/juju/juju-gui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juju/juju-gui/labels{/name}","releases_url":"https://api.github.com/repos/juju/juju-gui/releases{/id}","deployments_url":"https://api.github.com/repos/juju/juju-gui/deployments","created_at":"2013-12-05T17:15:48Z","updated_at":"2017-06-06T21:33:37Z","pushed_at":"2017-06-07T05:39:53Z","git_url":"git://github.com/juju/juju-gui.git","ssh_url":"git@github.com:juju/juju-gui.git","clone_url":"https://github.com/juju/juju-gui.git","svn_url":"https://github.com/juju/juju-gui","homepage":"","size":123236,"stargazers_count":118,"watchers_count":118,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":64,"mirror_url":null,"open_issues_count":102,"forks":64,"open_issues":102,"watchers":118,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/juju/juju-gui/pulls/2974"},"html":{"href":"https://github.com/juju/juju-gui/pull/2974"},"issue":{"href":"https://api.github.com/repos/juju/juju-gui/issues/2974"},"comments":{"href":"https://api.github.com/repos/juju/juju-gui/issues/2974/comments"},"review_comments":{"href":"https://api.github.com/repos/juju/juju-gui/pulls/2974/comments"},"review_comment":{"href":"https://api.github.com/repos/juju/juju-gui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/juju/juju-gui/pulls/2974/commits"},"statuses":{"href":"https://api.github.com/repos/juju/juju-gui/statuses/a4c06cfc7c5c6d85ea91af023e1c4245273d43b1"}}}}
{"actor":{"display_login":"huwshimi"}}