{"action":"created","comment":{"url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/comments/123271167","pull_request_review_id":45457972,"id":123271167,"diff_hunk":"@@ -72,22 +78,18 @@ export const saving = createReducer( false, {\n  * @return {Object}        Updated state\n  */\n export const items = createReducer( {}, {\n-\t[ DOMAIN_MANAGEMENT_CONTACT_DETAILS_CACHE_RECEIVE ]: ( state, { cacheData } ) => ( { ...state, _contactDetailsCache: cacheData } ),\n-\t[ DOMAIN_MANAGEMENT_CONTACT_DETAILS_CACHE_UPDATE ]:\n-\t\t( state, { cacheData } ) =>\n-\t\t\tmerge( {}, state, { _contactDetailsCache: cacheData } ),\n+\t[ DOMAIN_MANAGEMENT_CONTACT_DETAILS_CACHE_RECEIVE ]: ( state, { data } ) => ( { ...state, _contactDetailsCache: data } ),\n+\t[ DOMAIN_MANAGEMENT_CONTACT_DETAILS_CACHE_UPDATE ]: ( state, { data } ) => {\n+\t\treturn merge( {}, state, { _contactDetailsCache: data } );","path":"client/state/domains/management/reducer.js","position":62,"original_position":62,"commit_id":"9290cb6d8175a0fe543cf0a51505dd69cd9bb140","original_commit_id":"9290cb6d8175a0fe543cf0a51505dd69cd9bb140","user":{"login":"mcsf","id":150562,"avatar_url":"https://avatars3.githubusercontent.com/u/150562?v=3","gravatar_id":"","url":"https://api.github.com/users/mcsf","html_url":"https://github.com/mcsf","followers_url":"https://api.github.com/users/mcsf/followers","following_url":"https://api.github.com/users/mcsf/following{/other_user}","gists_url":"https://api.github.com/users/mcsf/gists{/gist_id}","starred_url":"https://api.github.com/users/mcsf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcsf/subscriptions","organizations_url":"https://api.github.com/users/mcsf/orgs","repos_url":"https://api.github.com/users/mcsf/repos","events_url":"https://api.github.com/users/mcsf/events{/privacy}","received_events_url":"https://api.github.com/users/mcsf/received_events","type":"User","site_admin":false},"body":"`merge` is kind of the bulldozer of object transforms :), mainly because it's a recursive operation. I don't think it's appropriate in this case, as the following would be equivalent:\r\n\r\n```js\r\n( state, { data } ) => ( { ...state, _contactDetailsCache: data } )\r\n```","created_at":"2017-06-21T14:49:49Z","updated_at":"2017-06-21T15:01:59Z","html_url":"https://github.com/Automattic/wp-calypso/pull/15114#discussion_r123271167","pull_request_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/15114","_links":{"self":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/comments/123271167"},"html":{"href":"https://github.com/Automattic/wp-calypso/pull/15114#discussion_r123271167"},"pull_request":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/15114"}}},"pull_request":{"url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/15114","id":125623706,"html_url":"https://github.com/Automattic/wp-calypso/pull/15114","diff_url":"https://github.com/Automattic/wp-calypso/pull/15114.diff","patch_url":"https://github.com/Automattic/wp-calypso/pull/15114.patch","issue_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/15114","number":15114,"state":"closed","locked":false,"title":"Update/domain management redux","user":{"login":"hewsut","id":2006764,"avatar_url":"https://avatars1.githubusercontent.com/u/2006764?v=3","gravatar_id":"","url":"https://api.github.com/users/hewsut","html_url":"https://github.com/hewsut","followers_url":"https://api.github.com/users/hewsut/followers","following_url":"https://api.github.com/users/hewsut/following{/other_user}","gists_url":"https://api.github.com/users/hewsut/gists{/gist_id}","starred_url":"https://api.github.com/users/hewsut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hewsut/subscriptions","organizations_url":"https://api.github.com/users/hewsut/orgs","repos_url":"https://api.github.com/users/hewsut/repos","events_url":"https://api.github.com/users/hewsut/events{/privacy}","received_events_url":"https://api.github.com/users/hewsut/received_events","type":"User","site_admin":false},"body":"This PR cleans up sloppy corners of #14701.","created_at":"2017-06-14T15:21:47Z","updated_at":"2017-06-21T15:01:59Z","closed_at":"2017-06-21T02:24:57Z","merged_at":"2017-06-21T02:24:57Z","merge_commit_sha":"661c55c00acb129c6a82e43013986c28f1ca8f8c","assignee":{"login":"hewsut","id":2006764,"avatar_url":"https://avatars1.githubusercontent.com/u/2006764?v=3","gravatar_id":"","url":"https://api.github.com/users/hewsut","html_url":"https://github.com/hewsut","followers_url":"https://api.github.com/users/hewsut/followers","following_url":"https://api.github.com/users/hewsut/following{/other_user}","gists_url":"https://api.github.com/users/hewsut/gists{/gist_id}","starred_url":"https://api.github.com/users/hewsut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hewsut/subscriptions","organizations_url":"https://api.github.com/users/hewsut/orgs","repos_url":"https://api.github.com/users/hewsut/repos","events_url":"https://api.github.com/users/hewsut/events{/privacy}","received_events_url":"https://api.github.com/users/hewsut/received_events","type":"User","site_admin":false},"assignees":[{"login":"hewsut","id":2006764,"avatar_url":"https://avatars1.githubusercontent.com/u/2006764?v=3","gravatar_id":"","url":"https://api.github.com/users/hewsut","html_url":"https://github.com/hewsut","followers_url":"https://api.github.com/users/hewsut/followers","following_url":"https://api.github.com/users/hewsut/following{/other_user}","gists_url":"https://api.github.com/users/hewsut/gists{/gist_id}","starred_url":"https://api.github.com/users/hewsut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hewsut/subscriptions","organizations_url":"https://api.github.com/users/hewsut/orgs","repos_url":"https://api.github.com/users/hewsut/repos","events_url":"https://api.github.com/users/hewsut/events{/privacy}","received_events_url":"https://api.github.com/users/hewsut/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/15114/commits","review_comments_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/15114/comments","review_comment_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/15114/comments","statuses_url":"https://api.github.com/repos/Automattic/wp-calypso/statuses/9290cb6d8175a0fe543cf0a51505dd69cd9bb140","head":{"label":"Automattic:update/domain-management-redux","ref":"update/domain-management-redux","sha":"9290cb6d8175a0fe543cf0a51505dd69cd9bb140","user":{"login":"Automattic","id":887802,"avatar_url":"https://avatars2.githubusercontent.com/u/887802?v=3","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"repo":{"id":45936895,"name":"wp-calypso","full_name":"Automattic/wp-calypso","owner":{"login":"Automattic","id":887802,"avatar_url":"https://avatars2.githubusercontent.com/u/887802?v=3","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Automattic/wp-calypso","description":"The new JavaScript- and API-powered WordPress.com","fork":false,"url":"https://api.github.com/repos/Automattic/wp-calypso","forks_url":"https://api.github.com/repos/Automattic/wp-calypso/forks","keys_url":"https://api.github.com/repos/Automattic/wp-calypso/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Automattic/wp-calypso/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Automattic/wp-calypso/teams","hooks_url":"https://api.github.com/repos/Automattic/wp-calypso/hooks","issue_events_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/events{/number}","events_url":"https://api.github.com/repos/Automattic/wp-calypso/events","assignees_url":"https://api.github.com/repos/Automattic/wp-calypso/assignees{/user}","branches_url":"https://api.github.com/repos/Automattic/wp-calypso/branches{/branch}","tags_url":"https://api.github.com/repos/Automattic/wp-calypso/tags","blobs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Automattic/wp-calypso/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/refs{/sha}","trees_url":"https://api.github.com/repos/Automattic/wp-calypso/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Automattic/wp-calypso/statuses/{sha}","languages_url":"https://api.github.com/repos/Automattic/wp-calypso/languages","stargazers_url":"https://api.github.com/repos/Automattic/wp-calypso/stargazers","contributors_url":"https://api.github.com/repos/Automattic/wp-calypso/contributors","subscribers_url":"https://api.github.com/repos/Automattic/wp-calypso/subscribers","subscription_url":"https://api.github.com/repos/Automattic/wp-calypso/subscription","commits_url":"https://api.github.com/repos/Automattic/wp-calypso/commits{/sha}","git_commits_url":"https://api.github.com/repos/Automattic/wp-calypso/git/commits{/sha}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/comments{/number}","issue_comment_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/comments{/number}","contents_url":"https://api.github.com/repos/Automattic/wp-calypso/contents/{+path}","compare_url":"https://api.github.com/repos/Automattic/wp-calypso/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Automattic/wp-calypso/merges","archive_url":"https://api.github.com/repos/Automattic/wp-calypso/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Automattic/wp-calypso/downloads","issues_url":"https://api.github.com/repos/Automattic/wp-calypso/issues{/number}","pulls_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls{/number}","milestones_url":"https://api.github.com/repos/Automattic/wp-calypso/milestones{/number}","notifications_url":"https://api.github.com/repos/Automattic/wp-calypso/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/labels{/name}","releases_url":"https://api.github.com/repos/Automattic/wp-calypso/releases{/id}","deployments_url":"https://api.github.com/repos/Automattic/wp-calypso/deployments","created_at":"2015-11-10T20:00:16Z","updated_at":"2017-06-21T08:24:15Z","pushed_at":"2017-06-21T14:56:39Z","git_url":"git://github.com/Automattic/wp-calypso.git","ssh_url":"git@github.com:Automattic/wp-calypso.git","clone_url":"https://github.com/Automattic/wp-calypso.git","svn_url":"https://github.com/Automattic/wp-calypso","homepage":"https://developer.wordpress.com/calypso/","size":67188,"stargazers_count":8849,"watchers_count":8849,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1162,"mirror_url":null,"open_issues_count":2156,"forks":1162,"open_issues":2156,"watchers":8849,"default_branch":"master"}},"base":{"label":"Automattic:master","ref":"master","sha":"75e0ab99aa4c64f9941c6db169a0528ebca8f37f","user":{"login":"Automattic","id":887802,"avatar_url":"https://avatars2.githubusercontent.com/u/887802?v=3","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"repo":{"id":45936895,"name":"wp-calypso","full_name":"Automattic/wp-calypso","owner":{"login":"Automattic","id":887802,"avatar_url":"https://avatars2.githubusercontent.com/u/887802?v=3","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Automattic/wp-calypso","description":"The new JavaScript- and API-powered WordPress.com","fork":false,"url":"https://api.github.com/repos/Automattic/wp-calypso","forks_url":"https://api.github.com/repos/Automattic/wp-calypso/forks","keys_url":"https://api.github.com/repos/Automattic/wp-calypso/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Automattic/wp-calypso/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Automattic/wp-calypso/teams","hooks_url":"https://api.github.com/repos/Automattic/wp-calypso/hooks","issue_events_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/events{/number}","events_url":"https://api.github.com/repos/Automattic/wp-calypso/events","assignees_url":"https://api.github.com/repos/Automattic/wp-calypso/assignees{/user}","branches_url":"https://api.github.com/repos/Automattic/wp-calypso/branches{/branch}","tags_url":"https://api.github.com/repos/Automattic/wp-calypso/tags","blobs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Automattic/wp-calypso/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/refs{/sha}","trees_url":"https://api.github.com/repos/Automattic/wp-calypso/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Automattic/wp-calypso/statuses/{sha}","languages_url":"https://api.github.com/repos/Automattic/wp-calypso/languages","stargazers_url":"https://api.github.com/repos/Automattic/wp-calypso/stargazers","contributors_url":"https://api.github.com/repos/Automattic/wp-calypso/contributors","subscribers_url":"https://api.github.com/repos/Automattic/wp-calypso/subscribers","subscription_url":"https://api.github.com/repos/Automattic/wp-calypso/subscription","commits_url":"https://api.github.com/repos/Automattic/wp-calypso/commits{/sha}","git_commits_url":"https://api.github.com/repos/Automattic/wp-calypso/git/commits{/sha}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/comments{/number}","issue_comment_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/comments{/number}","contents_url":"https://api.github.com/repos/Automattic/wp-calypso/contents/{+path}","compare_url":"https://api.github.com/repos/Automattic/wp-calypso/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Automattic/wp-calypso/merges","archive_url":"https://api.github.com/repos/Automattic/wp-calypso/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Automattic/wp-calypso/downloads","issues_url":"https://api.github.com/repos/Automattic/wp-calypso/issues{/number}","pulls_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls{/number}","milestones_url":"https://api.github.com/repos/Automattic/wp-calypso/milestones{/number}","notifications_url":"https://api.github.com/repos/Automattic/wp-calypso/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/labels{/name}","releases_url":"https://api.github.com/repos/Automattic/wp-calypso/releases{/id}","deployments_url":"https://api.github.com/repos/Automattic/wp-calypso/deployments","created_at":"2015-11-10T20:00:16Z","updated_at":"2017-06-21T08:24:15Z","pushed_at":"2017-06-21T14:56:39Z","git_url":"git://github.com/Automattic/wp-calypso.git","ssh_url":"git@github.com:Automattic/wp-calypso.git","clone_url":"https://github.com/Automattic/wp-calypso.git","svn_url":"https://github.com/Automattic/wp-calypso","homepage":"https://developer.wordpress.com/calypso/","size":67188,"stargazers_count":8849,"watchers_count":8849,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1162,"mirror_url":null,"open_issues_count":2156,"forks":1162,"open_issues":2156,"watchers":8849,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/15114"},"html":{"href":"https://github.com/Automattic/wp-calypso/pull/15114"},"issue":{"href":"https://api.github.com/repos/Automattic/wp-calypso/issues/15114"},"comments":{"href":"https://api.github.com/repos/Automattic/wp-calypso/issues/15114/comments"},"review_comments":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/15114/comments"},"review_comment":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/15114/commits"},"statuses":{"href":"https://api.github.com/repos/Automattic/wp-calypso/statuses/9290cb6d8175a0fe543cf0a51505dd69cd9bb140"}}}}
{"actor":{"display_login":"mcsf"}}