{"action":"opened","number":1224,"pull_request":{"url":"https://api.github.com/repos/simplabs/ember-simple-auth/pulls/1224","id":107069488,"html_url":"https://github.com/simplabs/ember-simple-auth/pull/1224","diff_url":"https://github.com/simplabs/ember-simple-auth/pull/1224.diff","patch_url":"https://github.com/simplabs/ember-simple-auth/pull/1224.patch","issue_url":"https://api.github.com/repos/simplabs/ember-simple-auth/issues/1224","number":1224,"state":"open","locked":false,"title":"Provide opt outs for async infinite sync loop","user":{"login":"gfmartinez","id":14170693,"avatar_url":"https://avatars.githubusercontent.com/u/14170693?v=3","gravatar_id":"","url":"https://api.github.com/users/gfmartinez","html_url":"https://github.com/gfmartinez","followers_url":"https://api.github.com/users/gfmartinez/followers","following_url":"https://api.github.com/users/gfmartinez/following{/other_user}","gists_url":"https://api.github.com/users/gfmartinez/gists{/gist_id}","starred_url":"https://api.github.com/users/gfmartinez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gfmartinez/subscriptions","organizations_url":"https://api.github.com/users/gfmartinez/orgs","repos_url":"https://api.github.com/users/gfmartinez/repos","events_url":"https://api.github.com/users/gfmartinez/events{/privacy}","received_events_url":"https://api.github.com/users/gfmartinez/received_events","type":"User","site_admin":false},"body":"For context, I work with a dev team on http://dailyuv.com\r\nEmber version: 2.8.3 - Fastboot enabled\r\nEmber-simple-auth: 1.1.0 (we did update to 1.2.0 for testing)\r\n\r\nWe are using fastboot and have been running into many issues with its implementation and support in add-on libraries.\r\n\r\nOne issue we noticed in our application is that the ember-simple-auth cookie.js file (at https://github.com/simplabs/ember-simple-auth/blob/master/addon/session-stores/cookie.js#L257) creates an infinite loop. For our application it is unnecessary.\r\n\r\nSo, this Pull Request is meant to provide options for opting out of that infinite loop or to change its interval. Same with the expiration renewal interval. In our testing this does not affect our ability to maintain the current user or with any other functionality.","created_at":"2017-02-20T20:08:34Z","updated_at":"2017-02-20T20:08:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/simplabs/ember-simple-auth/pulls/1224/commits","review_comments_url":"https://api.github.com/repos/simplabs/ember-simple-auth/pulls/1224/comments","review_comment_url":"https://api.github.com/repos/simplabs/ember-simple-auth/pulls/comments{/number}","comments_url":"https://api.github.com/repos/simplabs/ember-simple-auth/issues/1224/comments","statuses_url":"https://api.github.com/repos/simplabs/ember-simple-auth/statuses/713d860aae443a2416f98784cd223edfe8e431bd","head":{"label":"gfmartinez:feature/provide-async-optout-and-options","ref":"feature/provide-async-optout-and-options","sha":"713d860aae443a2416f98784cd223edfe8e431bd","user":{"login":"gfmartinez","id":14170693,"avatar_url":"https://avatars.githubusercontent.com/u/14170693?v=3","gravatar_id":"","url":"https://api.github.com/users/gfmartinez","html_url":"https://github.com/gfmartinez","followers_url":"https://api.github.com/users/gfmartinez/followers","following_url":"https://api.github.com/users/gfmartinez/following{/other_user}","gists_url":"https://api.github.com/users/gfmartinez/gists{/gist_id}","starred_url":"https://api.github.com/users/gfmartinez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gfmartinez/subscriptions","organizations_url":"https://api.github.com/users/gfmartinez/orgs","repos_url":"https://api.github.com/users/gfmartinez/repos","events_url":"https://api.github.com/users/gfmartinez/events{/privacy}","received_events_url":"https://api.github.com/users/gfmartinez/received_events","type":"User","site_admin":false},"repo":{"id":82395924,"name":"ember-simple-auth","full_name":"gfmartinez/ember-simple-auth","owner":{"login":"gfmartinez","id":14170693,"avatar_url":"https://avatars.githubusercontent.com/u/14170693?v=3","gravatar_id":"","url":"https://api.github.com/users/gfmartinez","html_url":"https://github.com/gfmartinez","followers_url":"https://api.github.com/users/gfmartinez/followers","following_url":"https://api.github.com/users/gfmartinez/following{/other_user}","gists_url":"https://api.github.com/users/gfmartinez/gists{/gist_id}","starred_url":"https://api.github.com/users/gfmartinez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gfmartinez/subscriptions","organizations_url":"https://api.github.com/users/gfmartinez/orgs","repos_url":"https://api.github.com/users/gfmartinez/repos","events_url":"https://api.github.com/users/gfmartinez/events{/privacy}","received_events_url":"https://api.github.com/users/gfmartinez/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gfmartinez/ember-simple-auth","description":"A library for implementing authentication/authorization in Ember.js applications.","fork":true,"url":"https://api.github.com/repos/gfmartinez/ember-simple-auth","forks_url":"https://api.github.com/repos/gfmartinez/ember-simple-auth/forks","keys_url":"https://api.github.com/repos/gfmartinez/ember-simple-auth/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gfmartinez/ember-simple-auth/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gfmartinez/ember-simple-auth/teams","hooks_url":"https://api.github.com/repos/gfmartinez/ember-simple-auth/hooks","issue_events_url":"https://api.github.com/repos/gfmartinez/ember-simple-auth/issues/events{/number}","events_url":"https://api.github.com/repos/gfmartinez/ember-simple-auth/events","assignees_url":"https://api.github.com/repos/gfmartinez/ember-simple-auth/assignees{/user}","branches_url":"https://api.github.com/repos/gfmartinez/ember-simple-auth/branches{/branch}","tags_url":"https://api.github.com/repos/gfmartinez/ember-simple-auth/tags","blobs_url":"https://api.github.com/repos/gfmartinez/ember-simple-auth/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gfmartinez/ember-simple-auth/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gfmartinez/ember-simple-auth/git/refs{/sha}","trees_url":"https://api.github.com/repos/gfmartinez/ember-simple-auth/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gfmartinez/ember-simple-auth/statuses/{sha}","languages_url":"https://api.github.com/repos/gfmartinez/ember-simple-auth/languages","stargazers_url":"https://api.github.com/repos/gfmartinez/ember-simple-auth/stargazers","contributors_url":"https://api.github.com/repos/gfmartinez/ember-simple-auth/contributors","subscribers_url":"https://api.github.com/repos/gfmartinez/ember-simple-auth/subscribers","subscription_url":"https://api.github.com/repos/gfmartinez/ember-simple-auth/subscription","commits_url":"https://api.github.com/repos/gfmartinez/ember-simple-auth/commits{/sha}","git_commits_url":"https://api.github.com/repos/gfmartinez/ember-simple-auth/git/commits{/sha}","comments_url":"https://api.github.com/repos/gfmartinez/ember-simple-auth/comments{/number}","issue_comment_url":"https://api.github.com/repos/gfmartinez/ember-simple-auth/issues/comments{/number}","contents_url":"https://api.github.com/repos/gfmartinez/ember-simple-auth/contents/{+path}","compare_url":"https://api.github.com/repos/gfmartinez/ember-simple-auth/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gfmartinez/ember-simple-auth/merges","archive_url":"https://api.github.com/repos/gfmartinez/ember-simple-auth/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gfmartinez/ember-simple-auth/downloads","issues_url":"https://api.github.com/repos/gfmartinez/ember-simple-auth/issues{/number}","pulls_url":"https://api.github.com/repos/gfmartinez/ember-simple-auth/pulls{/number}","milestones_url":"https://api.github.com/repos/gfmartinez/ember-simple-auth/milestones{/number}","notifications_url":"https://api.github.com/repos/gfmartinez/ember-simple-auth/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gfmartinez/ember-simple-auth/labels{/name}","releases_url":"https://api.github.com/repos/gfmartinez/ember-simple-auth/releases{/id}","deployments_url":"https://api.github.com/repos/gfmartinez/ember-simple-auth/deployments","created_at":"2017-02-18T15:27:29Z","updated_at":"2017-02-18T15:27:31Z","pushed_at":"2017-02-20T19:36:34Z","git_url":"git://github.com/gfmartinez/ember-simple-auth.git","ssh_url":"git@github.com:gfmartinez/ember-simple-auth.git","clone_url":"https://github.com/gfmartinez/ember-simple-auth.git","svn_url":"https://github.com/gfmartinez/ember-simple-auth","homepage":"http://ember-simple-auth.com","size":7761,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"simplabs:master","ref":"master","sha":"8101ab3f54ccddeeb664a2387f17240d3e40d5c8","user":{"login":"simplabs","id":56627,"avatar_url":"https://avatars.githubusercontent.com/u/56627?v=3","gravatar_id":"","url":"https://api.github.com/users/simplabs","html_url":"https://github.com/simplabs","followers_url":"https://api.github.com/users/simplabs/followers","following_url":"https://api.github.com/users/simplabs/following{/other_user}","gists_url":"https://api.github.com/users/simplabs/gists{/gist_id}","starred_url":"https://api.github.com/users/simplabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simplabs/subscriptions","organizations_url":"https://api.github.com/users/simplabs/orgs","repos_url":"https://api.github.com/users/simplabs/repos","events_url":"https://api.github.com/users/simplabs/events{/privacy}","received_events_url":"https://api.github.com/users/simplabs/received_events","type":"Organization","site_admin":false},"repo":{"id":12570984,"name":"ember-simple-auth","full_name":"simplabs/ember-simple-auth","owner":{"login":"simplabs","id":56627,"avatar_url":"https://avatars.githubusercontent.com/u/56627?v=3","gravatar_id":"","url":"https://api.github.com/users/simplabs","html_url":"https://github.com/simplabs","followers_url":"https://api.github.com/users/simplabs/followers","following_url":"https://api.github.com/users/simplabs/following{/other_user}","gists_url":"https://api.github.com/users/simplabs/gists{/gist_id}","starred_url":"https://api.github.com/users/simplabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simplabs/subscriptions","organizations_url":"https://api.github.com/users/simplabs/orgs","repos_url":"https://api.github.com/users/simplabs/repos","events_url":"https://api.github.com/users/simplabs/events{/privacy}","received_events_url":"https://api.github.com/users/simplabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/simplabs/ember-simple-auth","description":"A library for implementing authentication/authorization in Ember.js applications.","fork":false,"url":"https://api.github.com/repos/simplabs/ember-simple-auth","forks_url":"https://api.github.com/repos/simplabs/ember-simple-auth/forks","keys_url":"https://api.github.com/repos/simplabs/ember-simple-auth/keys{/key_id}","collaborators_url":"https://api.github.com/repos/simplabs/ember-simple-auth/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/simplabs/ember-simple-auth/teams","hooks_url":"https://api.github.com/repos/simplabs/ember-simple-auth/hooks","issue_events_url":"https://api.github.com/repos/simplabs/ember-simple-auth/issues/events{/number}","events_url":"https://api.github.com/repos/simplabs/ember-simple-auth/events","assignees_url":"https://api.github.com/repos/simplabs/ember-simple-auth/assignees{/user}","branches_url":"https://api.github.com/repos/simplabs/ember-simple-auth/branches{/branch}","tags_url":"https://api.github.com/repos/simplabs/ember-simple-auth/tags","blobs_url":"https://api.github.com/repos/simplabs/ember-simple-auth/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/simplabs/ember-simple-auth/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/simplabs/ember-simple-auth/git/refs{/sha}","trees_url":"https://api.github.com/repos/simplabs/ember-simple-auth/git/trees{/sha}","statuses_url":"https://api.github.com/repos/simplabs/ember-simple-auth/statuses/{sha}","languages_url":"https://api.github.com/repos/simplabs/ember-simple-auth/languages","stargazers_url":"https://api.github.com/repos/simplabs/ember-simple-auth/stargazers","contributors_url":"https://api.github.com/repos/simplabs/ember-simple-auth/contributors","subscribers_url":"https://api.github.com/repos/simplabs/ember-simple-auth/subscribers","subscription_url":"https://api.github.com/repos/simplabs/ember-simple-auth/subscription","commits_url":"https://api.github.com/repos/simplabs/ember-simple-auth/commits{/sha}","git_commits_url":"https://api.github.com/repos/simplabs/ember-simple-auth/git/commits{/sha}","comments_url":"https://api.github.com/repos/simplabs/ember-simple-auth/comments{/number}","issue_comment_url":"https://api.github.com/repos/simplabs/ember-simple-auth/issues/comments{/number}","contents_url":"https://api.github.com/repos/simplabs/ember-simple-auth/contents/{+path}","compare_url":"https://api.github.com/repos/simplabs/ember-simple-auth/compare/{base}...{head}","merges_url":"https://api.github.com/repos/simplabs/ember-simple-auth/merges","archive_url":"https://api.github.com/repos/simplabs/ember-simple-auth/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/simplabs/ember-simple-auth/downloads","issues_url":"https://api.github.com/repos/simplabs/ember-simple-auth/issues{/number}","pulls_url":"https://api.github.com/repos/simplabs/ember-simple-auth/pulls{/number}","milestones_url":"https://api.github.com/repos/simplabs/ember-simple-auth/milestones{/number}","notifications_url":"https://api.github.com/repos/simplabs/ember-simple-auth/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/simplabs/ember-simple-auth/labels{/name}","releases_url":"https://api.github.com/repos/simplabs/ember-simple-auth/releases{/id}","deployments_url":"https://api.github.com/repos/simplabs/ember-simple-auth/deployments","created_at":"2013-09-03T18:03:26Z","updated_at":"2017-02-19T05:04:22Z","pushed_at":"2017-02-20T16:06:27Z","git_url":"git://github.com/simplabs/ember-simple-auth.git","ssh_url":"git@github.com:simplabs/ember-simple-auth.git","clone_url":"https://github.com/simplabs/ember-simple-auth.git","svn_url":"https://github.com/simplabs/ember-simple-auth","homepage":"http://ember-simple-auth.com","size":7761,"stargazers_count":1665,"watchers_count":1665,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":480,"mirror_url":null,"open_issues_count":39,"forks":480,"open_issues":39,"watchers":1665,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/simplabs/ember-simple-auth/pulls/1224"},"html":{"href":"https://github.com/simplabs/ember-simple-auth/pull/1224"},"issue":{"href":"https://api.github.com/repos/simplabs/ember-simple-auth/issues/1224"},"comments":{"href":"https://api.github.com/repos/simplabs/ember-simple-auth/issues/1224/comments"},"review_comments":{"href":"https://api.github.com/repos/simplabs/ember-simple-auth/pulls/1224/comments"},"review_comment":{"href":"https://api.github.com/repos/simplabs/ember-simple-auth/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/simplabs/ember-simple-auth/pulls/1224/commits"},"statuses":{"href":"https://api.github.com/repos/simplabs/ember-simple-auth/statuses/713d860aae443a2416f98784cd223edfe8e431bd"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":27,"deletions":4,"changed_files":1}}
{"actor":{"display_login":"gfmartinez"}}