{"action":"created","comment":{"url":"https://api.github.com/repos/google/trillian/pulls/comments/98504995","pull_request_review_id":19141095,"id":98504995,"diff_hunk":"@@ -0,0 +1,40 @@\n+// Copyright 2016 Google Inc. All Rights Reserved.\n+//\n+// Licensed under the Apache License, Version 2.0 (the \"License\");\n+// you may not use this file except in compliance with the License.\n+// You may obtain a copy of the License at\n+//\n+//     http://www.apache.org/licenses/LICENSE-2.0\n+//\n+// Unless required by applicable law or agreed to in writing, software\n+// distributed under the License is distributed on an \"AS IS\" BASIS,\n+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+// See the License for the specific language governing permissions and\n+// limitations under the License.\n+\n+package testonly\n+\n+// This file implements the hashing functions that are part of a Trillian\n+// personality.\n+\n+import \"crypto/sha256\"\n+\n+// HashKey converts an identity string into a map index using SHA256.","path":"testonly/hasher.go","position":22,"original_position":22,"commit_id":"adead8f00fd3f1f830486769db3cc8c1940f4c67","original_commit_id":"adead8f00fd3f1f830486769db3cc8c1940f4c67","user":{"login":"AlCutter","id":7648032,"avatar_url":"https://avatars.githubusercontent.com/u/7648032?v=3","gravatar_id":"","url":"https://api.github.com/users/AlCutter","html_url":"https://github.com/AlCutter","followers_url":"https://api.github.com/users/AlCutter/followers","following_url":"https://api.github.com/users/AlCutter/following{/other_user}","gists_url":"https://api.github.com/users/AlCutter/gists{/gist_id}","starred_url":"https://api.github.com/users/AlCutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlCutter/subscriptions","organizations_url":"https://api.github.com/users/AlCutter/orgs","repos_url":"https://api.github.com/users/AlCutter/repos","events_url":"https://api.github.com/users/AlCutter/events{/privacy}","received_events_url":"https://api.github.com/users/AlCutter/received_events","type":"User","site_admin":false},"body":"/an identity string/a map key/ ?","created_at":"2017-01-30T18:19:28Z","updated_at":"2017-01-30T18:29:19Z","html_url":"https://github.com/google/trillian/pull/336#discussion_r98504995","pull_request_url":"https://api.github.com/repos/google/trillian/pulls/336","_links":{"self":{"href":"https://api.github.com/repos/google/trillian/pulls/comments/98504995"},"html":{"href":"https://github.com/google/trillian/pull/336#discussion_r98504995"},"pull_request":{"href":"https://api.github.com/repos/google/trillian/pulls/336"}}},"pull_request":{"url":"https://api.github.com/repos/google/trillian/pulls/336","id":103477197,"html_url":"https://github.com/google/trillian/pull/336","diff_url":"https://github.com/google/trillian/pull/336.diff","patch_url":"https://github.com/google/trillian/pull/336.patch","issue_url":"https://api.github.com/repos/google/trillian/issues/336","number":336,"state":"open","locked":false,"title":"Move HashKey to the personality layer","user":{"login":"gdbelvin","id":198478,"avatar_url":"https://avatars.githubusercontent.com/u/198478?v=3","gravatar_id":"","url":"https://api.github.com/users/gdbelvin","html_url":"https://github.com/gdbelvin","followers_url":"https://api.github.com/users/gdbelvin/followers","following_url":"https://api.github.com/users/gdbelvin/following{/other_user}","gists_url":"https://api.github.com/users/gdbelvin/gists{/gist_id}","starred_url":"https://api.github.com/users/gdbelvin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gdbelvin/subscriptions","organizations_url":"https://api.github.com/users/gdbelvin/orgs","repos_url":"https://api.github.com/users/gdbelvin/repos","events_url":"https://api.github.com/users/gdbelvin/events{/privacy}","received_events_url":"https://api.github.com/users/gdbelvin/received_events","type":"User","site_admin":false},"body":"The personality should be responsible for computing the index\r\nof values in the map.\r\n\r\n- Creates a personality layer hasher in testonly.\r\n- Renames HashKey to index.\r\n\r\nCloses #332 ","created_at":"2017-01-27T11:36:10Z","updated_at":"2017-01-30T18:29:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8bbfc75b5e2c31377d3ccbf436be4d7058876ed7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/google/trillian/pulls/336/commits","review_comments_url":"https://api.github.com/repos/google/trillian/pulls/336/comments","review_comment_url":"https://api.github.com/repos/google/trillian/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/trillian/issues/336/comments","statuses_url":"https://api.github.com/repos/google/trillian/statuses/adead8f00fd3f1f830486769db3cc8c1940f4c67","head":{"label":"gdbelvin:index","ref":"index","sha":"adead8f00fd3f1f830486769db3cc8c1940f4c67","user":{"login":"gdbelvin","id":198478,"avatar_url":"https://avatars.githubusercontent.com/u/198478?v=3","gravatar_id":"","url":"https://api.github.com/users/gdbelvin","html_url":"https://github.com/gdbelvin","followers_url":"https://api.github.com/users/gdbelvin/followers","following_url":"https://api.github.com/users/gdbelvin/following{/other_user}","gists_url":"https://api.github.com/users/gdbelvin/gists{/gist_id}","starred_url":"https://api.github.com/users/gdbelvin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gdbelvin/subscriptions","organizations_url":"https://api.github.com/users/gdbelvin/orgs","repos_url":"https://api.github.com/users/gdbelvin/repos","events_url":"https://api.github.com/users/gdbelvin/events{/privacy}","received_events_url":"https://api.github.com/users/gdbelvin/received_events","type":"User","site_admin":false},"repo":{"id":79220930,"name":"trillian","full_name":"gdbelvin/trillian","owner":{"login":"gdbelvin","id":198478,"avatar_url":"https://avatars.githubusercontent.com/u/198478?v=3","gravatar_id":"","url":"https://api.github.com/users/gdbelvin","html_url":"https://github.com/gdbelvin","followers_url":"https://api.github.com/users/gdbelvin/followers","following_url":"https://api.github.com/users/gdbelvin/following{/other_user}","gists_url":"https://api.github.com/users/gdbelvin/gists{/gist_id}","starred_url":"https://api.github.com/users/gdbelvin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gdbelvin/subscriptions","organizations_url":"https://api.github.com/users/gdbelvin/orgs","repos_url":"https://api.github.com/users/gdbelvin/repos","events_url":"https://api.github.com/users/gdbelvin/events{/privacy}","received_events_url":"https://api.github.com/users/gdbelvin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gdbelvin/trillian","description":null,"fork":true,"url":"https://api.github.com/repos/gdbelvin/trillian","forks_url":"https://api.github.com/repos/gdbelvin/trillian/forks","keys_url":"https://api.github.com/repos/gdbelvin/trillian/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gdbelvin/trillian/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gdbelvin/trillian/teams","hooks_url":"https://api.github.com/repos/gdbelvin/trillian/hooks","issue_events_url":"https://api.github.com/repos/gdbelvin/trillian/issues/events{/number}","events_url":"https://api.github.com/repos/gdbelvin/trillian/events","assignees_url":"https://api.github.com/repos/gdbelvin/trillian/assignees{/user}","branches_url":"https://api.github.com/repos/gdbelvin/trillian/branches{/branch}","tags_url":"https://api.github.com/repos/gdbelvin/trillian/tags","blobs_url":"https://api.github.com/repos/gdbelvin/trillian/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gdbelvin/trillian/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gdbelvin/trillian/git/refs{/sha}","trees_url":"https://api.github.com/repos/gdbelvin/trillian/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gdbelvin/trillian/statuses/{sha}","languages_url":"https://api.github.com/repos/gdbelvin/trillian/languages","stargazers_url":"https://api.github.com/repos/gdbelvin/trillian/stargazers","contributors_url":"https://api.github.com/repos/gdbelvin/trillian/contributors","subscribers_url":"https://api.github.com/repos/gdbelvin/trillian/subscribers","subscription_url":"https://api.github.com/repos/gdbelvin/trillian/subscription","commits_url":"https://api.github.com/repos/gdbelvin/trillian/commits{/sha}","git_commits_url":"https://api.github.com/repos/gdbelvin/trillian/git/commits{/sha}","comments_url":"https://api.github.com/repos/gdbelvin/trillian/comments{/number}","issue_comment_url":"https://api.github.com/repos/gdbelvin/trillian/issues/comments{/number}","contents_url":"https://api.github.com/repos/gdbelvin/trillian/contents/{+path}","compare_url":"https://api.github.com/repos/gdbelvin/trillian/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gdbelvin/trillian/merges","archive_url":"https://api.github.com/repos/gdbelvin/trillian/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gdbelvin/trillian/downloads","issues_url":"https://api.github.com/repos/gdbelvin/trillian/issues{/number}","pulls_url":"https://api.github.com/repos/gdbelvin/trillian/pulls{/number}","milestones_url":"https://api.github.com/repos/gdbelvin/trillian/milestones{/number}","notifications_url":"https://api.github.com/repos/gdbelvin/trillian/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gdbelvin/trillian/labels{/name}","releases_url":"https://api.github.com/repos/gdbelvin/trillian/releases{/id}","deployments_url":"https://api.github.com/repos/gdbelvin/trillian/deployments","created_at":"2017-01-17T11:27:31Z","updated_at":"2017-01-17T11:27:34Z","pushed_at":"2017-01-30T17:40:01Z","git_url":"git://github.com/gdbelvin/trillian.git","ssh_url":"git@github.com:gdbelvin/trillian.git","clone_url":"https://github.com/gdbelvin/trillian.git","svn_url":"https://github.com/gdbelvin/trillian","homepage":null,"size":2208,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"21fa859348124101bd19f7902946e4947ae22834","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":58654489,"name":"trillian","full_name":"google/trillian","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/trillian","description":null,"fork":false,"url":"https://api.github.com/repos/google/trillian","forks_url":"https://api.github.com/repos/google/trillian/forks","keys_url":"https://api.github.com/repos/google/trillian/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/trillian/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/trillian/teams","hooks_url":"https://api.github.com/repos/google/trillian/hooks","issue_events_url":"https://api.github.com/repos/google/trillian/issues/events{/number}","events_url":"https://api.github.com/repos/google/trillian/events","assignees_url":"https://api.github.com/repos/google/trillian/assignees{/user}","branches_url":"https://api.github.com/repos/google/trillian/branches{/branch}","tags_url":"https://api.github.com/repos/google/trillian/tags","blobs_url":"https://api.github.com/repos/google/trillian/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/trillian/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/trillian/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/trillian/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/trillian/statuses/{sha}","languages_url":"https://api.github.com/repos/google/trillian/languages","stargazers_url":"https://api.github.com/repos/google/trillian/stargazers","contributors_url":"https://api.github.com/repos/google/trillian/contributors","subscribers_url":"https://api.github.com/repos/google/trillian/subscribers","subscription_url":"https://api.github.com/repos/google/trillian/subscription","commits_url":"https://api.github.com/repos/google/trillian/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/trillian/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/trillian/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/trillian/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/trillian/contents/{+path}","compare_url":"https://api.github.com/repos/google/trillian/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/trillian/merges","archive_url":"https://api.github.com/repos/google/trillian/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/trillian/downloads","issues_url":"https://api.github.com/repos/google/trillian/issues{/number}","pulls_url":"https://api.github.com/repos/google/trillian/pulls{/number}","milestones_url":"https://api.github.com/repos/google/trillian/milestones{/number}","notifications_url":"https://api.github.com/repos/google/trillian/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/trillian/labels{/name}","releases_url":"https://api.github.com/repos/google/trillian/releases{/id}","deployments_url":"https://api.github.com/repos/google/trillian/deployments","created_at":"2016-05-12T15:37:35Z","updated_at":"2017-01-28T15:22:43Z","pushed_at":"2017-01-30T17:40:03Z","git_url":"git://github.com/google/trillian.git","ssh_url":"git@github.com:google/trillian.git","clone_url":"https://github.com/google/trillian.git","svn_url":"https://github.com/google/trillian","homepage":null,"size":2086,"stargazers_count":162,"watchers_count":162,"language":"Go","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":27,"forks":25,"open_issues":27,"watchers":162,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/trillian/pulls/336"},"html":{"href":"https://github.com/google/trillian/pull/336"},"issue":{"href":"https://api.github.com/repos/google/trillian/issues/336"},"comments":{"href":"https://api.github.com/repos/google/trillian/issues/336/comments"},"review_comments":{"href":"https://api.github.com/repos/google/trillian/pulls/336/comments"},"review_comment":{"href":"https://api.github.com/repos/google/trillian/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/trillian/pulls/336/commits"},"statuses":{"href":"https://api.github.com/repos/google/trillian/statuses/adead8f00fd3f1f830486769db3cc8c1940f4c67"}}}}
{"actor":{"display_login":"AlCutter"}}