{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/18118","repository_url":"https://api.github.com/repos/cms-sw/cmssw","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/18118/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/18118/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/18118/events","html_url":"https://github.com/cms-sw/cmssw/pull/18118","id":217854907,"number":18118,"title":"Updated radiation damage models for HBHE scintillator and SiPMs","user":{"login":"kpedro88","id":4672808,"avatar_url":"https://avatars3.githubusercontent.com/u/4672808?v=3","gravatar_id":"","url":"https://api.github.com/users/kpedro88","html_url":"https://github.com/kpedro88","followers_url":"https://api.github.com/users/kpedro88/followers","following_url":"https://api.github.com/users/kpedro88/following{/other_user}","gists_url":"https://api.github.com/users/kpedro88/gists{/gist_id}","starred_url":"https://api.github.com/users/kpedro88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kpedro88/subscriptions","organizations_url":"https://api.github.com/users/kpedro88/orgs","repos_url":"https://api.github.com/users/kpedro88/repos","events_url":"https://api.github.com/users/kpedro88/events{/privacy}","received_events_url":"https://api.github.com/users/kpedro88/received_events","type":"User","site_admin":false},"labels":[{"id":52881463,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/alca-pending","name":"alca-pending","color":"fbca04","default":false},{"id":88653795,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-pending","name":"comparison-pending","color":"fbca04","default":false},{"id":52881671,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/db-pending","name":"db-pending","color":"fbca04","default":false},{"id":56953091,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04","default":false},{"id":53167770,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"eb6420","default":false},{"id":52820010,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/reconstruction-pending","name":"reconstruction-pending","color":"fbca04","default":false},{"id":52820523,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/simulation-pending","name":"simulation-pending","color":"fbca04","default":false},{"id":56131152,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-pending","name":"tests-pending","color":"fbca04","default":false},{"id":530655448,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/upgrade-pending","name":"upgrade-pending","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/65","html_url":"https://github.com/cms-sw/cmssw/milestone/65","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/65/labels","id":2358370,"number":65,"title":"Next CMSSW_9_1_X","description":"","creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars0.githubusercontent.com/u/4115138?v=3","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":89,"closed_issues":325,"state":"open","created_at":"2017-03-02T09:15:47Z","updated_at":"2017-04-10T19:22:59Z","due_on":null,"closed_at":null},"comments":95,"created_at":"2017-03-29T12:09:33Z","updated_at":"2017-04-10T19:29:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/18118","html_url":"https://github.com/cms-sw/cmssw/pull/18118","diff_url":"https://github.com/cms-sw/cmssw/pull/18118.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/18118.patch"},"body":"The new aging features introduced in this PR are primarily intended to be used for HB Phase2 TDR studies, but can also be used for nearer-term HE studies.\r\n\r\nScintillator radiation damage:\r\n* New classes `HBHEDarkening`, `HBHERecalibration`\r\n* Headers describe the ingredients/models\r\n* Can be configured for HB or HE (in Python)\r\n* `HBHEDarkeningAnalyzer` prints out darkening and recalibration factors for given lumi:\r\n```\r\ncmsRun CalibCalorimetry/HcalPlugins/test/hbhedarkeninganalyzer_cfg.py\r\n```\r\n\r\nSiPM radiation damage:\r\n* New class `HcalSiPMRadiationDamage`\r\n* Header describes the ingredients (simple parameterization of dark current vs. temperature, lumi/dose)\r\n* Can be configured for HB or HE (in Python)\r\n* Dark current updated in hardcode conditions - can be dumped to see values\r\n* Zero suppression thresholds may need to be updated for high lumis - not investigated yet\r\n* Had to add hack in `HBHEPhase1Reconstructor` to account for dark current contribution to pedestal mean (only enabled for phase2), eventually this can be redone in a better way - attn: @abdoulline, @igv4321, @mariadalfonso \r\n\r\nAdd aging and recalibration to cmsRun config:\r\n```\r\nfrom SLHCUpgradeSimulations.Configuration.aging import ageHcal\r\nprocess = ageHcal(process,3000)\r\n```\r\n\r\n***NOTA BENE*** model parameters in Python are ***NOT*** final and may change, depending on ongoing studies!\r\n\r\nSee [presentation](https://indico.cern.ch/event/623426/contributions/2520814/attachments/1431939/2200131/phase2_hcal_software_status_mar_22_2017.pdf) in last week's upgrade studies meeting; a more in-depth presentation will be given during upcoming CMS week."},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/293053969","html_url":"https://github.com/cms-sw/cmssw/pull/18118#issuecomment-293053969","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/18118","id":293053969,"user":{"login":"cmsbuild","id":4170616,"avatar_url":"https://avatars2.githubusercontent.com/u/4170616?v=3","gravatar_id":"","url":"https://api.github.com/users/cmsbuild","html_url":"https://github.com/cmsbuild","followers_url":"https://api.github.com/users/cmsbuild/followers","following_url":"https://api.github.com/users/cmsbuild/following{/other_user}","gists_url":"https://api.github.com/users/cmsbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/cmsbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmsbuild/subscriptions","organizations_url":"https://api.github.com/users/cmsbuild/orgs","repos_url":"https://api.github.com/users/cmsbuild/repos","events_url":"https://api.github.com/users/cmsbuild/events{/privacy}","received_events_url":"https://api.github.com/users/cmsbuild/received_events","type":"User","site_admin":false},"created_at":"2017-04-10T19:29:47Z","updated_at":"2017-04-10T19:29:47Z","body":"Pull request #18118 was updated. @perrotta, @ghellwig, @civanch, @arunhep, @mdhildreth, @cmsbuild, @franzoni, @kpedro88, @cerminar, @slava77, @ggovi, @mmusich, @davidlange6 can you please check and sign again."}}
{"actor":{"display_login":"cmsbuild"}}