{"action":"created","issue":{"url":"https://api.github.com/repos/pydicom/pydicom/issues/454","repository_url":"https://api.github.com/repos/pydicom/pydicom","labels_url":"https://api.github.com/repos/pydicom/pydicom/issues/454/labels{/name}","comments_url":"https://api.github.com/repos/pydicom/pydicom/issues/454/comments","events_url":"https://api.github.com/repos/pydicom/pydicom/issues/454/events","html_url":"https://github.com/pydicom/pydicom/pull/454","id":246654325,"number":454,"title":"[WIP] Add test coverage for dataset","user":{"login":"scaramallion","id":10226372,"avatar_url":"https://avatars2.githubusercontent.com/u/10226372?v=4","gravatar_id":"","url":"https://api.github.com/users/scaramallion","html_url":"https://github.com/scaramallion","followers_url":"https://api.github.com/users/scaramallion/followers","following_url":"https://api.github.com/users/scaramallion/following{/other_user}","gists_url":"https://api.github.com/users/scaramallion/gists{/gist_id}","starred_url":"https://api.github.com/users/scaramallion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scaramallion/subscriptions","organizations_url":"https://api.github.com/users/scaramallion/orgs","repos_url":"https://api.github.com/users/scaramallion/repos","events_url":"https://api.github.com/users/scaramallion/events{/privacy}","received_events_url":"https://api.github.com/users/scaramallion/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-07-31T06:12:49Z","updated_at":"2017-07-31T06:12:51Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/pydicom/pydicom/pulls/454","html_url":"https://github.com/pydicom/pydicom/pull/454","diff_url":"https://github.com/pydicom/pydicom/pull/454.diff","patch_url":"https://github.com/pydicom/pydicom/pull/454.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/pydicom/pydicom/issues/comments/318977493","html_url":"https://github.com/pydicom/pydicom/pull/454#issuecomment-318977493","issue_url":"https://api.github.com/repos/pydicom/pydicom/issues/454","id":318977493,"user":{"login":"pep8speaks","id":24736507,"avatar_url":"https://avatars1.githubusercontent.com/u/24736507?v=4","gravatar_id":"","url":"https://api.github.com/users/pep8speaks","html_url":"https://github.com/pep8speaks","followers_url":"https://api.github.com/users/pep8speaks/followers","following_url":"https://api.github.com/users/pep8speaks/following{/other_user}","gists_url":"https://api.github.com/users/pep8speaks/gists{/gist_id}","starred_url":"https://api.github.com/users/pep8speaks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pep8speaks/subscriptions","organizations_url":"https://api.github.com/users/pep8speaks/orgs","repos_url":"https://api.github.com/users/pep8speaks/repos","events_url":"https://api.github.com/users/pep8speaks/events{/privacy}","received_events_url":"https://api.github.com/users/pep8speaks/received_events","type":"User","site_admin":false},"created_at":"2017-07-31T06:12:51Z","updated_at":"2017-07-31T06:12:51Z","body":"Hello @scaramallion! Thanks for submitting the PR.\n\n\n\n - In the file [`pydicom/tests/test_dataset.py`](https://github.com/pydicom/pydicom/blob/5028fce45519b2b04dba6801e43799e23b13d013/pydicom/tests/test_dataset.py), following are the PEP8 issues :\n\n> [Line 182:28](https://github.com/pydicom/pydicom/blob/5028fce45519b2b04dba6801e43799e23b13d013/pydicom/tests/test_dataset.py#L182): [E231](https://duckduckgo.com/?q=pep8%20E231) missing whitespace after ','\n> [Line 257:28](https://github.com/pydicom/pydicom/blob/5028fce45519b2b04dba6801e43799e23b13d013/pydicom/tests/test_dataset.py#L257): [E231](https://duckduckgo.com/?q=pep8%20E231) missing whitespace after ','\n> [Line 258:1](https://github.com/pydicom/pydicom/blob/5028fce45519b2b04dba6801e43799e23b13d013/pydicom/tests/test_dataset.py#L258): [W293](https://duckduckgo.com/?q=pep8%20W293) blank line contains whitespace\n> [Line 902:38](https://github.com/pydicom/pydicom/blob/5028fce45519b2b04dba6801e43799e23b13d013/pydicom/tests/test_dataset.py#L902): [E231](https://duckduckgo.com/?q=pep8%20E231) missing whitespace after ','\n> [Line 902:80](https://github.com/pydicom/pydicom/blob/5028fce45519b2b04dba6801e43799e23b13d013/pydicom/tests/test_dataset.py#L902): [E501](https://duckduckgo.com/?q=pep8%20E501) line too long (83 > 79 characters)\n> [Line 903:31](https://github.com/pydicom/pydicom/blob/5028fce45519b2b04dba6801e43799e23b13d013/pydicom/tests/test_dataset.py#L903): [E231](https://duckduckgo.com/?q=pep8%20E231) missing whitespace after ','\n> [Line 905:26](https://github.com/pydicom/pydicom/blob/5028fce45519b2b04dba6801e43799e23b13d013/pydicom/tests/test_dataset.py#L905): [E231](https://duckduckgo.com/?q=pep8%20E231) missing whitespace after ','\n> [Line 906:31](https://github.com/pydicom/pydicom/blob/5028fce45519b2b04dba6801e43799e23b13d013/pydicom/tests/test_dataset.py#L906): [E231](https://duckduckgo.com/?q=pep8%20E231) missing whitespace after ','\n> [Line 915:16](https://github.com/pydicom/pydicom/blob/5028fce45519b2b04dba6801e43799e23b13d013/pydicom/tests/test_dataset.py#L915): [E713](https://duckduckgo.com/?q=pep8%20E713) test for membership should be 'not in'\n> [Line 1004:1](https://github.com/pydicom/pydicom/blob/5028fce45519b2b04dba6801e43799e23b13d013/pydicom/tests/test_dataset.py#L1004): [E305](https://duckduckgo.com/?q=pep8%20E305) expected 2 blank lines after class or function definition, found 1\n\n"}}
{"actor":{"display_login":"pep8speaks"}}