{"action":"created","comment":{"url":"https://api.github.com/repos/status-im/status-go/pulls/comments/135235287","pull_request_review_id":58625044,"id":135235287,"diff_hunk":"@@ -550,6 +575,25 @@ func (m *NodeManager) RPCClient() (*rpc.Client, error) {\n \treturn m.rpcClient, nil\n }\n \n+// RPCClient exposes reference to RPC client connected to the running node.\n+func (m *NodeManager) RPCClient() (*rpc.Client, error) {","path":"geth/node/manager.go","position":74,"original_position":75,"commit_id":"37835d36f9512379657c65b2f6d6fc343b3957a2","original_commit_id":"02d290c20fc4d38cc5e6a73148269c6e80e44d84","user":{"login":"adambabik","id":277870,"avatar_url":"https://avatars1.githubusercontent.com/u/277870?v=4","gravatar_id":"","url":"https://api.github.com/users/adambabik","html_url":"https://github.com/adambabik","followers_url":"https://api.github.com/users/adambabik/followers","following_url":"https://api.github.com/users/adambabik/following{/other_user}","gists_url":"https://api.github.com/users/adambabik/gists{/gist_id}","starred_url":"https://api.github.com/users/adambabik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adambabik/subscriptions","organizations_url":"https://api.github.com/users/adambabik/orgs","repos_url":"https://api.github.com/users/adambabik/repos","events_url":"https://api.github.com/users/adambabik/events{/privacy}","received_events_url":"https://api.github.com/users/adambabik/received_events","type":"User","site_admin":false},"body":"As I mentioned above, I am not sure we need this one. It might introduce some confusion which method use and can also result in bugs that will be hard to figure out. Caller should be 100% sure which client it needs to use.","created_at":"2017-08-25T11:09:43Z","updated_at":"2017-08-25T11:10:05Z","html_url":"https://github.com/status-im/status-go/pull/276#discussion_r135235287","pull_request_url":"https://api.github.com/repos/status-im/status-go/pulls/276","_links":{"self":{"href":"https://api.github.com/repos/status-im/status-go/pulls/comments/135235287"},"html":{"href":"https://github.com/status-im/status-go/pull/276#discussion_r135235287"},"pull_request":{"href":"https://api.github.com/repos/status-im/status-go/pulls/276"}}},"pull_request":{"url":"https://api.github.com/repos/status-im/status-go/pulls/276","id":137649076,"html_url":"https://github.com/status-im/status-go/pull/276","diff_url":"https://github.com/status-im/status-go/pull/276.diff","patch_url":"https://github.com/status-im/status-go/pull/276.patch","issue_url":"https://api.github.com/repos/status-im/status-go/issues/276","number":276,"state":"open","locked":false,"title":"Refactor jail to handle ssh_* methods specially","user":{"login":"influx6","id":131629,"avatar_url":"https://avatars2.githubusercontent.com/u/131629?v=4","gravatar_id":"","url":"https://api.github.com/users/influx6","html_url":"https://github.com/influx6","followers_url":"https://api.github.com/users/influx6/followers","following_url":"https://api.github.com/users/influx6/following{/other_user}","gists_url":"https://api.github.com/users/influx6/gists{/gist_id}","starred_url":"https://api.github.com/users/influx6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/influx6/subscriptions","organizations_url":"https://api.github.com/users/influx6/orgs","repos_url":"https://api.github.com/users/influx6/repos","events_url":"https://api.github.com/users/influx6/events{/privacy}","received_events_url":"https://api.github.com/users/influx6/received_events","type":"User","site_admin":false},"body":"PR refactors jail to handle specific RPC request for `ssh_*` based methods using the local node's `rpc.Client`. This ensure whispers rpc calls are handle  internally.\r\n\r\nRelated to issue #274.","created_at":"2017-08-25T10:58:31Z","updated_at":"2017-08-25T11:10:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b809c127f91bc83e3da31c16cb14ce8a3b78d72d","assignee":{"login":"influx6","id":131629,"avatar_url":"https://avatars2.githubusercontent.com/u/131629?v=4","gravatar_id":"","url":"https://api.github.com/users/influx6","html_url":"https://github.com/influx6","followers_url":"https://api.github.com/users/influx6/followers","following_url":"https://api.github.com/users/influx6/following{/other_user}","gists_url":"https://api.github.com/users/influx6/gists{/gist_id}","starred_url":"https://api.github.com/users/influx6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/influx6/subscriptions","organizations_url":"https://api.github.com/users/influx6/orgs","repos_url":"https://api.github.com/users/influx6/repos","events_url":"https://api.github.com/users/influx6/events{/privacy}","received_events_url":"https://api.github.com/users/influx6/received_events","type":"User","site_admin":false},"assignees":[{"login":"influx6","id":131629,"avatar_url":"https://avatars2.githubusercontent.com/u/131629?v=4","gravatar_id":"","url":"https://api.github.com/users/influx6","html_url":"https://github.com/influx6","followers_url":"https://api.github.com/users/influx6/followers","following_url":"https://api.github.com/users/influx6/following{/other_user}","gists_url":"https://api.github.com/users/influx6/gists{/gist_id}","starred_url":"https://api.github.com/users/influx6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/influx6/subscriptions","organizations_url":"https://api.github.com/users/influx6/orgs","repos_url":"https://api.github.com/users/influx6/repos","events_url":"https://api.github.com/users/influx6/events{/privacy}","received_events_url":"https://api.github.com/users/influx6/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"tiabc","id":2167748,"avatar_url":"https://avatars2.githubusercontent.com/u/2167748?v=4","gravatar_id":"","url":"https://api.github.com/users/tiabc","html_url":"https://github.com/tiabc","followers_url":"https://api.github.com/users/tiabc/followers","following_url":"https://api.github.com/users/tiabc/following{/other_user}","gists_url":"https://api.github.com/users/tiabc/gists{/gist_id}","starred_url":"https://api.github.com/users/tiabc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiabc/subscriptions","organizations_url":"https://api.github.com/users/tiabc/orgs","repos_url":"https://api.github.com/users/tiabc/repos","events_url":"https://api.github.com/users/tiabc/events{/privacy}","received_events_url":"https://api.github.com/users/tiabc/received_events","type":"User","site_admin":false},{"login":"rgeraldes","id":26251983,"avatar_url":"https://avatars2.githubusercontent.com/u/26251983?v=4","gravatar_id":"","url":"https://api.github.com/users/rgeraldes","html_url":"https://github.com/rgeraldes","followers_url":"https://api.github.com/users/rgeraldes/followers","following_url":"https://api.github.com/users/rgeraldes/following{/other_user}","gists_url":"https://api.github.com/users/rgeraldes/gists{/gist_id}","starred_url":"https://api.github.com/users/rgeraldes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgeraldes/subscriptions","organizations_url":"https://api.github.com/users/rgeraldes/orgs","repos_url":"https://api.github.com/users/rgeraldes/repos","events_url":"https://api.github.com/users/rgeraldes/events{/privacy}","received_events_url":"https://api.github.com/users/rgeraldes/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/status-im/status-go/pulls/276/commits","review_comments_url":"https://api.github.com/repos/status-im/status-go/pulls/276/comments","review_comment_url":"https://api.github.com/repos/status-im/status-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/status-im/status-go/issues/276/comments","statuses_url":"https://api.github.com/repos/status-im/status-go/statuses/37835d36f9512379657c65b2f6d6fc343b3957a2","head":{"label":"status-im:bug/ssh_method_with_jail#274","ref":"bug/ssh_method_with_jail#274","sha":"37835d36f9512379657c65b2f6d6fc343b3957a2","user":{"login":"status-im","id":11767950,"avatar_url":"https://avatars1.githubusercontent.com/u/11767950?v=4","gravatar_id":"","url":"https://api.github.com/users/status-im","html_url":"https://github.com/status-im","followers_url":"https://api.github.com/users/status-im/followers","following_url":"https://api.github.com/users/status-im/following{/other_user}","gists_url":"https://api.github.com/users/status-im/gists{/gist_id}","starred_url":"https://api.github.com/users/status-im/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/status-im/subscriptions","organizations_url":"https://api.github.com/users/status-im/orgs","repos_url":"https://api.github.com/users/status-im/repos","events_url":"https://api.github.com/users/status-im/events{/privacy}","received_events_url":"https://api.github.com/users/status-im/received_events","type":"Organization","site_admin":false},"repo":{"id":61047867,"name":"status-go","full_name":"status-im/status-go","owner":{"login":"status-im","id":11767950,"avatar_url":"https://avatars1.githubusercontent.com/u/11767950?v=4","gravatar_id":"","url":"https://api.github.com/users/status-im","html_url":"https://github.com/status-im","followers_url":"https://api.github.com/users/status-im/followers","following_url":"https://api.github.com/users/status-im/following{/other_user}","gists_url":"https://api.github.com/users/status-im/gists{/gist_id}","starred_url":"https://api.github.com/users/status-im/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/status-im/subscriptions","organizations_url":"https://api.github.com/users/status-im/orgs","repos_url":"https://api.github.com/users/status-im/repos","events_url":"https://api.github.com/users/status-im/events{/privacy}","received_events_url":"https://api.github.com/users/status-im/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/status-im/status-go","description":"The Status module that consumes go-ethereum","fork":false,"url":"https://api.github.com/repos/status-im/status-go","forks_url":"https://api.github.com/repos/status-im/status-go/forks","keys_url":"https://api.github.com/repos/status-im/status-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/status-im/status-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/status-im/status-go/teams","hooks_url":"https://api.github.com/repos/status-im/status-go/hooks","issue_events_url":"https://api.github.com/repos/status-im/status-go/issues/events{/number}","events_url":"https://api.github.com/repos/status-im/status-go/events","assignees_url":"https://api.github.com/repos/status-im/status-go/assignees{/user}","branches_url":"https://api.github.com/repos/status-im/status-go/branches{/branch}","tags_url":"https://api.github.com/repos/status-im/status-go/tags","blobs_url":"https://api.github.com/repos/status-im/status-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/status-im/status-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/status-im/status-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/status-im/status-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/status-im/status-go/statuses/{sha}","languages_url":"https://api.github.com/repos/status-im/status-go/languages","stargazers_url":"https://api.github.com/repos/status-im/status-go/stargazers","contributors_url":"https://api.github.com/repos/status-im/status-go/contributors","subscribers_url":"https://api.github.com/repos/status-im/status-go/subscribers","subscription_url":"https://api.github.com/repos/status-im/status-go/subscription","commits_url":"https://api.github.com/repos/status-im/status-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/status-im/status-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/status-im/status-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/status-im/status-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/status-im/status-go/contents/{+path}","compare_url":"https://api.github.com/repos/status-im/status-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/status-im/status-go/merges","archive_url":"https://api.github.com/repos/status-im/status-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/status-im/status-go/downloads","issues_url":"https://api.github.com/repos/status-im/status-go/issues{/number}","pulls_url":"https://api.github.com/repos/status-im/status-go/pulls{/number}","milestones_url":"https://api.github.com/repos/status-im/status-go/milestones{/number}","notifications_url":"https://api.github.com/repos/status-im/status-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/status-im/status-go/labels{/name}","releases_url":"https://api.github.com/repos/status-im/status-go/releases{/id}","deployments_url":"https://api.github.com/repos/status-im/status-go/deployments","created_at":"2016-06-13T15:32:03Z","updated_at":"2017-08-25T03:07:03Z","pushed_at":"2017-08-25T11:02:55Z","git_url":"git://github.com/status-im/status-go.git","ssh_url":"git@github.com:status-im/status-go.git","clone_url":"https://github.com/status-im/status-go.git","svn_url":"https://github.com/status-im/status-go","homepage":"https://status.im","size":20755,"stargazers_count":157,"watchers_count":157,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":39,"mirror_url":null,"open_issues_count":79,"forks":39,"open_issues":79,"watchers":157,"default_branch":"develop"}},"base":{"label":"status-im:develop","ref":"develop","sha":"a4d2fdfa4aa5c846567fbd54f283a60c052fa91c","user":{"login":"status-im","id":11767950,"avatar_url":"https://avatars1.githubusercontent.com/u/11767950?v=4","gravatar_id":"","url":"https://api.github.com/users/status-im","html_url":"https://github.com/status-im","followers_url":"https://api.github.com/users/status-im/followers","following_url":"https://api.github.com/users/status-im/following{/other_user}","gists_url":"https://api.github.com/users/status-im/gists{/gist_id}","starred_url":"https://api.github.com/users/status-im/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/status-im/subscriptions","organizations_url":"https://api.github.com/users/status-im/orgs","repos_url":"https://api.github.com/users/status-im/repos","events_url":"https://api.github.com/users/status-im/events{/privacy}","received_events_url":"https://api.github.com/users/status-im/received_events","type":"Organization","site_admin":false},"repo":{"id":61047867,"name":"status-go","full_name":"status-im/status-go","owner":{"login":"status-im","id":11767950,"avatar_url":"https://avatars1.githubusercontent.com/u/11767950?v=4","gravatar_id":"","url":"https://api.github.com/users/status-im","html_url":"https://github.com/status-im","followers_url":"https://api.github.com/users/status-im/followers","following_url":"https://api.github.com/users/status-im/following{/other_user}","gists_url":"https://api.github.com/users/status-im/gists{/gist_id}","starred_url":"https://api.github.com/users/status-im/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/status-im/subscriptions","organizations_url":"https://api.github.com/users/status-im/orgs","repos_url":"https://api.github.com/users/status-im/repos","events_url":"https://api.github.com/users/status-im/events{/privacy}","received_events_url":"https://api.github.com/users/status-im/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/status-im/status-go","description":"The Status module that consumes go-ethereum","fork":false,"url":"https://api.github.com/repos/status-im/status-go","forks_url":"https://api.github.com/repos/status-im/status-go/forks","keys_url":"https://api.github.com/repos/status-im/status-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/status-im/status-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/status-im/status-go/teams","hooks_url":"https://api.github.com/repos/status-im/status-go/hooks","issue_events_url":"https://api.github.com/repos/status-im/status-go/issues/events{/number}","events_url":"https://api.github.com/repos/status-im/status-go/events","assignees_url":"https://api.github.com/repos/status-im/status-go/assignees{/user}","branches_url":"https://api.github.com/repos/status-im/status-go/branches{/branch}","tags_url":"https://api.github.com/repos/status-im/status-go/tags","blobs_url":"https://api.github.com/repos/status-im/status-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/status-im/status-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/status-im/status-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/status-im/status-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/status-im/status-go/statuses/{sha}","languages_url":"https://api.github.com/repos/status-im/status-go/languages","stargazers_url":"https://api.github.com/repos/status-im/status-go/stargazers","contributors_url":"https://api.github.com/repos/status-im/status-go/contributors","subscribers_url":"https://api.github.com/repos/status-im/status-go/subscribers","subscription_url":"https://api.github.com/repos/status-im/status-go/subscription","commits_url":"https://api.github.com/repos/status-im/status-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/status-im/status-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/status-im/status-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/status-im/status-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/status-im/status-go/contents/{+path}","compare_url":"https://api.github.com/repos/status-im/status-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/status-im/status-go/merges","archive_url":"https://api.github.com/repos/status-im/status-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/status-im/status-go/downloads","issues_url":"https://api.github.com/repos/status-im/status-go/issues{/number}","pulls_url":"https://api.github.com/repos/status-im/status-go/pulls{/number}","milestones_url":"https://api.github.com/repos/status-im/status-go/milestones{/number}","notifications_url":"https://api.github.com/repos/status-im/status-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/status-im/status-go/labels{/name}","releases_url":"https://api.github.com/repos/status-im/status-go/releases{/id}","deployments_url":"https://api.github.com/repos/status-im/status-go/deployments","created_at":"2016-06-13T15:32:03Z","updated_at":"2017-08-25T03:07:03Z","pushed_at":"2017-08-25T11:02:55Z","git_url":"git://github.com/status-im/status-go.git","ssh_url":"git@github.com:status-im/status-go.git","clone_url":"https://github.com/status-im/status-go.git","svn_url":"https://github.com/status-im/status-go","homepage":"https://status.im","size":20755,"stargazers_count":157,"watchers_count":157,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":39,"mirror_url":null,"open_issues_count":79,"forks":39,"open_issues":79,"watchers":157,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/status-im/status-go/pulls/276"},"html":{"href":"https://github.com/status-im/status-go/pull/276"},"issue":{"href":"https://api.github.com/repos/status-im/status-go/issues/276"},"comments":{"href":"https://api.github.com/repos/status-im/status-go/issues/276/comments"},"review_comments":{"href":"https://api.github.com/repos/status-im/status-go/pulls/276/comments"},"review_comment":{"href":"https://api.github.com/repos/status-im/status-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/status-im/status-go/pulls/276/commits"},"statuses":{"href":"https://api.github.com/repos/status-im/status-go/statuses/37835d36f9512379657c65b2f6d6fc343b3957a2"}}}}
{"actor":{"display_login":"adambabik"}}