{"action":"created","comment":{"url":"https://api.github.com/repos/paritytech/parity/pulls/comments/127089105","pull_request_review_id":49638071,"id":127089105,"diff_hunk":"@@ -109,6 +112,7 @@ impl http::RequestMiddleware for Router {\n \t\t\t\t=>\n \t\t\t{\n \t\t\t\ttrace!(target: \"dapps\", \"Resolving to 404.\");\n+\t\t\t\trefresh.unwrap().refresh_local_dapps();","path":"dapps/src/router.rs","position":null,"original_position":44,"commit_id":"04bd4d9559e1f99259fcc41b5a5fd7e4e69f2c7e","original_commit_id":"960731c55da6b4b94394c2c726d9d9a91c2819ae","user":{"login":"CraigglesO","id":5249140,"avatar_url":"https://avatars2.githubusercontent.com/u/5249140?v=3","gravatar_id":"","url":"https://api.github.com/users/CraigglesO","html_url":"https://github.com/CraigglesO","followers_url":"https://api.github.com/users/CraigglesO/followers","following_url":"https://api.github.com/users/CraigglesO/following{/other_user}","gists_url":"https://api.github.com/users/CraigglesO/gists{/gist_id}","starred_url":"https://api.github.com/users/CraigglesO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CraigglesO/subscriptions","organizations_url":"https://api.github.com/users/CraigglesO/orgs","repos_url":"https://api.github.com/users/CraigglesO/repos","events_url":"https://api.github.com/users/CraigglesO/events{/privacy}","received_events_url":"https://api.github.com/users/CraigglesO/received_events","type":"User","site_admin":false},"body":"I didn't want to dispute this, but now that I am re-incorporating it, I want to do it as so SINCE the code is only run upon the condition `self.endpoints.is_some()`","created_at":"2017-07-12T22:30:25Z","updated_at":"2017-07-12T22:30:25Z","html_url":"https://github.com/paritytech/parity/pull/5752#discussion_r127089105","pull_request_url":"https://api.github.com/repos/paritytech/parity/pulls/5752","_links":{"self":{"href":"https://api.github.com/repos/paritytech/parity/pulls/comments/127089105"},"html":{"href":"https://github.com/paritytech/parity/pull/5752#discussion_r127089105"},"pull_request":{"href":"https://api.github.com/repos/paritytech/parity/pulls/5752"}}},"pull_request":{"url":"https://api.github.com/repos/paritytech/parity/pulls/5752","id":123768885,"html_url":"https://github.com/paritytech/parity/pull/5752","diff_url":"https://github.com/paritytech/parity/pull/5752.diff","patch_url":"https://github.com/paritytech/parity/pull/5752.patch","issue_url":"https://api.github.com/repos/paritytech/parity/issues/5752","number":5752,"state":"open","locked":false,"title":"Dapp refresh","user":{"login":"CraigglesO","id":5249140,"avatar_url":"https://avatars2.githubusercontent.com/u/5249140?v=3","gravatar_id":"","url":"https://api.github.com/users/CraigglesO","html_url":"https://github.com/CraigglesO","followers_url":"https://api.github.com/users/CraigglesO/followers","following_url":"https://api.github.com/users/CraigglesO/following{/other_user}","gists_url":"https://api.github.com/users/CraigglesO/gists{/gist_id}","starred_url":"https://api.github.com/users/CraigglesO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CraigglesO/subscriptions","organizations_url":"https://api.github.com/users/CraigglesO/orgs","repos_url":"https://api.github.com/users/CraigglesO/repos","events_url":"https://api.github.com/users/CraigglesO/events{/privacy}","received_events_url":"https://api.github.com/users/CraigglesO/received_events","type":"User","site_admin":false},"body":"Closes: #4194\r\n\r\n![alt1](https://www.dropbox.com/s/6b9a5w8tozvyeav/Screen%20Shot%202017-07-04%20at%2011.05.33%20PM.png?dl=1)\r\n![alt2](https://www.dropbox.com/s/06pqfxtyutslvah/Screen%20Shot%202017-07-04%20at%2011.05.53%20PM.png?dl=1)\r\n\r\nIf adding or removing a dapp, this will update the list upon:\r\n* removing a dapp from the dapps folder\r\n* linking a dapp\r\n* a 404.\r\n\r\nIf you want to quickly test it:\r\n`git clone https://github.com/paritytech/skeleton mydapp`\r\n`git cd mydapp`\r\n\r\n`ln -s $PWD/dist $HOME/Library/Application\\ Support/io.parity.ethereum/dapps/mydapp`\r\n(If you are using windows go to the tutorial... :P)\r\n\r\n**Click refresh**\r\n\r\nand to test removal:\r\n`cd ~/Library/Application Support/io.parity.ethereum/dapps`\r\nor `cd /Users/$USER/Library/Application Support/io.parity.ethereum/dapps`\r\n\r\n`rm -rf mydapp`","created_at":"2017-06-02T17:55:35Z","updated_at":"2017-07-12T22:30:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"85dd68313185df93f27fa0daf86e5d5b361bdfdb","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/paritytech/parity/pulls/5752/commits","review_comments_url":"https://api.github.com/repos/paritytech/parity/pulls/5752/comments","review_comment_url":"https://api.github.com/repos/paritytech/parity/pulls/comments{/number}","comments_url":"https://api.github.com/repos/paritytech/parity/issues/5752/comments","statuses_url":"https://api.github.com/repos/paritytech/parity/statuses/04bd4d9559e1f99259fcc41b5a5fd7e4e69f2c7e","head":{"label":"paritytech:dapp-refresh","ref":"dapp-refresh","sha":"04bd4d9559e1f99259fcc41b5a5fd7e4e69f2c7e","user":{"login":"paritytech","id":14176906,"avatar_url":"https://avatars1.githubusercontent.com/u/14176906?v=3","gravatar_id":"","url":"https://api.github.com/users/paritytech","html_url":"https://github.com/paritytech","followers_url":"https://api.github.com/users/paritytech/followers","following_url":"https://api.github.com/users/paritytech/following{/other_user}","gists_url":"https://api.github.com/users/paritytech/gists{/gist_id}","starred_url":"https://api.github.com/users/paritytech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paritytech/subscriptions","organizations_url":"https://api.github.com/users/paritytech/orgs","repos_url":"https://api.github.com/users/paritytech/repos","events_url":"https://api.github.com/users/paritytech/events{/privacy}","received_events_url":"https://api.github.com/users/paritytech/received_events","type":"Organization","site_admin":false},"repo":{"id":46714939,"name":"parity","full_name":"paritytech/parity","owner":{"login":"paritytech","id":14176906,"avatar_url":"https://avatars1.githubusercontent.com/u/14176906?v=3","gravatar_id":"","url":"https://api.github.com/users/paritytech","html_url":"https://github.com/paritytech","followers_url":"https://api.github.com/users/paritytech/followers","following_url":"https://api.github.com/users/paritytech/following{/other_user}","gists_url":"https://api.github.com/users/paritytech/gists{/gist_id}","starred_url":"https://api.github.com/users/paritytech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paritytech/subscriptions","organizations_url":"https://api.github.com/users/paritytech/orgs","repos_url":"https://api.github.com/users/paritytech/repos","events_url":"https://api.github.com/users/paritytech/events{/privacy}","received_events_url":"https://api.github.com/users/paritytech/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/paritytech/parity","description":"Fast, light, robust Ethereum implementation","fork":false,"url":"https://api.github.com/repos/paritytech/parity","forks_url":"https://api.github.com/repos/paritytech/parity/forks","keys_url":"https://api.github.com/repos/paritytech/parity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paritytech/parity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paritytech/parity/teams","hooks_url":"https://api.github.com/repos/paritytech/parity/hooks","issue_events_url":"https://api.github.com/repos/paritytech/parity/issues/events{/number}","events_url":"https://api.github.com/repos/paritytech/parity/events","assignees_url":"https://api.github.com/repos/paritytech/parity/assignees{/user}","branches_url":"https://api.github.com/repos/paritytech/parity/branches{/branch}","tags_url":"https://api.github.com/repos/paritytech/parity/tags","blobs_url":"https://api.github.com/repos/paritytech/parity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paritytech/parity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paritytech/parity/git/refs{/sha}","trees_url":"https://api.github.com/repos/paritytech/parity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paritytech/parity/statuses/{sha}","languages_url":"https://api.github.com/repos/paritytech/parity/languages","stargazers_url":"https://api.github.com/repos/paritytech/parity/stargazers","contributors_url":"https://api.github.com/repos/paritytech/parity/contributors","subscribers_url":"https://api.github.com/repos/paritytech/parity/subscribers","subscription_url":"https://api.github.com/repos/paritytech/parity/subscription","commits_url":"https://api.github.com/repos/paritytech/parity/commits{/sha}","git_commits_url":"https://api.github.com/repos/paritytech/parity/git/commits{/sha}","comments_url":"https://api.github.com/repos/paritytech/parity/comments{/number}","issue_comment_url":"https://api.github.com/repos/paritytech/parity/issues/comments{/number}","contents_url":"https://api.github.com/repos/paritytech/parity/contents/{+path}","compare_url":"https://api.github.com/repos/paritytech/parity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paritytech/parity/merges","archive_url":"https://api.github.com/repos/paritytech/parity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paritytech/parity/downloads","issues_url":"https://api.github.com/repos/paritytech/parity/issues{/number}","pulls_url":"https://api.github.com/repos/paritytech/parity/pulls{/number}","milestones_url":"https://api.github.com/repos/paritytech/parity/milestones{/number}","notifications_url":"https://api.github.com/repos/paritytech/parity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paritytech/parity/labels{/name}","releases_url":"https://api.github.com/repos/paritytech/parity/releases{/id}","deployments_url":"https://api.github.com/repos/paritytech/parity/deployments","created_at":"2015-11-23T11:07:32Z","updated_at":"2017-07-12T20:49:40Z","pushed_at":"2017-07-12T21:54:52Z","git_url":"git://github.com/paritytech/parity.git","ssh_url":"git@github.com:paritytech/parity.git","clone_url":"https://github.com/paritytech/parity.git","svn_url":"https://github.com/paritytech/parity","homepage":"","size":99020,"stargazers_count":1534,"watchers_count":1534,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":310,"mirror_url":null,"open_issues_count":362,"forks":310,"open_issues":362,"watchers":1534,"default_branch":"master"}},"base":{"label":"paritytech:master","ref":"master","sha":"02f2c611d47e6b8bf2e53bd2791651c3cbc3cccf","user":{"login":"paritytech","id":14176906,"avatar_url":"https://avatars1.githubusercontent.com/u/14176906?v=3","gravatar_id":"","url":"https://api.github.com/users/paritytech","html_url":"https://github.com/paritytech","followers_url":"https://api.github.com/users/paritytech/followers","following_url":"https://api.github.com/users/paritytech/following{/other_user}","gists_url":"https://api.github.com/users/paritytech/gists{/gist_id}","starred_url":"https://api.github.com/users/paritytech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paritytech/subscriptions","organizations_url":"https://api.github.com/users/paritytech/orgs","repos_url":"https://api.github.com/users/paritytech/repos","events_url":"https://api.github.com/users/paritytech/events{/privacy}","received_events_url":"https://api.github.com/users/paritytech/received_events","type":"Organization","site_admin":false},"repo":{"id":46714939,"name":"parity","full_name":"paritytech/parity","owner":{"login":"paritytech","id":14176906,"avatar_url":"https://avatars1.githubusercontent.com/u/14176906?v=3","gravatar_id":"","url":"https://api.github.com/users/paritytech","html_url":"https://github.com/paritytech","followers_url":"https://api.github.com/users/paritytech/followers","following_url":"https://api.github.com/users/paritytech/following{/other_user}","gists_url":"https://api.github.com/users/paritytech/gists{/gist_id}","starred_url":"https://api.github.com/users/paritytech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paritytech/subscriptions","organizations_url":"https://api.github.com/users/paritytech/orgs","repos_url":"https://api.github.com/users/paritytech/repos","events_url":"https://api.github.com/users/paritytech/events{/privacy}","received_events_url":"https://api.github.com/users/paritytech/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/paritytech/parity","description":"Fast, light, robust Ethereum implementation","fork":false,"url":"https://api.github.com/repos/paritytech/parity","forks_url":"https://api.github.com/repos/paritytech/parity/forks","keys_url":"https://api.github.com/repos/paritytech/parity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paritytech/parity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paritytech/parity/teams","hooks_url":"https://api.github.com/repos/paritytech/parity/hooks","issue_events_url":"https://api.github.com/repos/paritytech/parity/issues/events{/number}","events_url":"https://api.github.com/repos/paritytech/parity/events","assignees_url":"https://api.github.com/repos/paritytech/parity/assignees{/user}","branches_url":"https://api.github.com/repos/paritytech/parity/branches{/branch}","tags_url":"https://api.github.com/repos/paritytech/parity/tags","blobs_url":"https://api.github.com/repos/paritytech/parity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paritytech/parity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paritytech/parity/git/refs{/sha}","trees_url":"https://api.github.com/repos/paritytech/parity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paritytech/parity/statuses/{sha}","languages_url":"https://api.github.com/repos/paritytech/parity/languages","stargazers_url":"https://api.github.com/repos/paritytech/parity/stargazers","contributors_url":"https://api.github.com/repos/paritytech/parity/contributors","subscribers_url":"https://api.github.com/repos/paritytech/parity/subscribers","subscription_url":"https://api.github.com/repos/paritytech/parity/subscription","commits_url":"https://api.github.com/repos/paritytech/parity/commits{/sha}","git_commits_url":"https://api.github.com/repos/paritytech/parity/git/commits{/sha}","comments_url":"https://api.github.com/repos/paritytech/parity/comments{/number}","issue_comment_url":"https://api.github.com/repos/paritytech/parity/issues/comments{/number}","contents_url":"https://api.github.com/repos/paritytech/parity/contents/{+path}","compare_url":"https://api.github.com/repos/paritytech/parity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paritytech/parity/merges","archive_url":"https://api.github.com/repos/paritytech/parity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paritytech/parity/downloads","issues_url":"https://api.github.com/repos/paritytech/parity/issues{/number}","pulls_url":"https://api.github.com/repos/paritytech/parity/pulls{/number}","milestones_url":"https://api.github.com/repos/paritytech/parity/milestones{/number}","notifications_url":"https://api.github.com/repos/paritytech/parity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paritytech/parity/labels{/name}","releases_url":"https://api.github.com/repos/paritytech/parity/releases{/id}","deployments_url":"https://api.github.com/repos/paritytech/parity/deployments","created_at":"2015-11-23T11:07:32Z","updated_at":"2017-07-12T20:49:40Z","pushed_at":"2017-07-12T21:54:52Z","git_url":"git://github.com/paritytech/parity.git","ssh_url":"git@github.com:paritytech/parity.git","clone_url":"https://github.com/paritytech/parity.git","svn_url":"https://github.com/paritytech/parity","homepage":"","size":99020,"stargazers_count":1534,"watchers_count":1534,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":310,"mirror_url":null,"open_issues_count":362,"forks":310,"open_issues":362,"watchers":1534,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/paritytech/parity/pulls/5752"},"html":{"href":"https://github.com/paritytech/parity/pull/5752"},"issue":{"href":"https://api.github.com/repos/paritytech/parity/issues/5752"},"comments":{"href":"https://api.github.com/repos/paritytech/parity/issues/5752/comments"},"review_comments":{"href":"https://api.github.com/repos/paritytech/parity/pulls/5752/comments"},"review_comment":{"href":"https://api.github.com/repos/paritytech/parity/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/paritytech/parity/pulls/5752/commits"},"statuses":{"href":"https://api.github.com/repos/paritytech/parity/statuses/04bd4d9559e1f99259fcc41b5a5fd7e4e69f2c7e"}}}}
{"actor":{"display_login":"CraigglesO"}}