{"action":"created","issue":{"url":"https://api.github.com/repos/MonoGame/MonoGame/issues/5401","repository_url":"https://api.github.com/repos/MonoGame/MonoGame","labels_url":"https://api.github.com/repos/MonoGame/MonoGame/issues/5401/labels{/name}","comments_url":"https://api.github.com/repos/MonoGame/MonoGame/issues/5401/comments","events_url":"https://api.github.com/repos/MonoGame/MonoGame/issues/5401/events","html_url":"https://github.com/MonoGame/MonoGame/pull/5401","id":199299343,"number":5401,"title":"Inline/Optimize SpriteBatch.DrawInternal() & SpriteFont.DrawInto()","user":{"login":"nkast","id":3018589,"avatar_url":"https://avatars.githubusercontent.com/u/3018589?v=3","gravatar_id":"","url":"https://api.github.com/users/nkast","html_url":"https://github.com/nkast","followers_url":"https://api.github.com/users/nkast/followers","following_url":"https://api.github.com/users/nkast/following{/other_user}","gists_url":"https://api.github.com/users/nkast/gists{/gist_id}","starred_url":"https://api.github.com/users/nkast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nkast/subscriptions","organizations_url":"https://api.github.com/users/nkast/orgs","repos_url":"https://api.github.com/users/nkast/repos","events_url":"https://api.github.com/users/nkast/events{/privacy}","received_events_url":"https://api.github.com/users/nkast/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2017-01-06T21:55:13Z","updated_at":"2017-02-16T14:20:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/MonoGame/MonoGame/pulls/5401","html_url":"https://github.com/MonoGame/MonoGame/pull/5401","diff_url":"https://github.com/MonoGame/MonoGame/pull/5401.diff","patch_url":"https://github.com/MonoGame/MonoGame/pull/5401.patch"},"body":"Inline SpriteBatch.DrawInternal() & SpriteFont.DrawInto().\r\nRemove temporary Variables and unnecessary Computations.\r\n#5347\r\n\r\nMethod|Develop|this PR|difference\r\n------------ | ------------- | ------------- | -------------\r\nDraw(Texture2D, Vector2, Color)|0.18652|0.14050|75.3%\r\nDraw(Texture2D, Rectangle, Color)|0.21533|0.12461|57.9%\r\nDraw(Texture2D, Vector2, Rectangle, Color)|0.23807|0.17247|72.4%\r\nDraw(Texture2D, Rectangle, Rectangle, Color)|0.25178|0.15590|61.9%\r\nDraw(Texture2D, Vector2, Rectangle?, Color, float, Vector2, Vector2, SpriteEffects, float)|0.31193|0.29355|94.1%\r\nDraw(Texture2D, Rectangle, Rectangle?, Color, float, Vector2, SpriteEffects, float)|0.31487|0.28922|91.9%\r\nDrawString(SpriteFont, string, Vector2, Color)|0.48899|0.37718|77.1%\r\nDrawString(SpriteFont, string, Vector2, Color, float, Vector2, Vector2, SpriteEffects, float)|0.69743|0.40235|57.7%\r\n"},"comment":{"url":"https://api.github.com/repos/MonoGame/MonoGame/issues/comments/280342449","html_url":"https://github.com/MonoGame/MonoGame/pull/5401#issuecomment-280342449","issue_url":"https://api.github.com/repos/MonoGame/MonoGame/issues/5401","id":280342449,"user":{"login":"nkast","id":3018589,"avatar_url":"https://avatars.githubusercontent.com/u/3018589?v=3","gravatar_id":"","url":"https://api.github.com/users/nkast","html_url":"https://github.com/nkast","followers_url":"https://api.github.com/users/nkast/followers","following_url":"https://api.github.com/users/nkast/following{/other_user}","gists_url":"https://api.github.com/users/nkast/gists{/gist_id}","starred_url":"https://api.github.com/users/nkast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nkast/subscriptions","organizations_url":"https://api.github.com/users/nkast/orgs","repos_url":"https://api.github.com/users/nkast/repos","events_url":"https://api.github.com/users/nkast/events{/privacy}","received_events_url":"https://api.github.com/users/nkast/received_events","type":"User","site_admin":false},"created_at":"2017-02-16T14:20:55Z","updated_at":"2017-02-16T14:20:55Z","body":"@KonajuGames \r\n> Were @tomspilman's comments on Jan 11 addressed?\r\n\r\nCommit [DrawString tests ad80453](https://github.com/MonoGame/MonoGame/pull/5401/commits/ad80453829c50e70c5a089166153964b12301543) improve code coverage of Draw()/DrawString(), including newlines.\r\nex: https://github.com/nkast/MonoGame/blob/ad80453829c50e70c5a089166153964b12301543/Test/Framework/Graphics/SpriteFontTest.cs#L495-L503\r\n\r\n@KonajuGames , @tomspilman \r\nWould you like to move the Tests on another PR or is it good this way?\r\n"}}
{"actor":{"display_login":"nkast"}}