{"action":"created","comment":{"url":"https://api.github.com/repos/mitodl/release-script/pulls/comments/95468452","pull_request_review_id":16024261,"id":95468452,"diff_hunk":"@@ -0,0 +1,60 @@\n+#!/usr/bin/env bash\n+\n+. ./release.sh\n+\n+merge_release_candidate (){\n+    echo \"Merge release-candidate into release\"\n+    git checkout -t origin/release\n+    git merge origin/release-candidate\n+    git push\n+}\n+\n+tag_release () {\n+    echo \"Tag release...\"\n+    git tag -a -m \"Release $VERSION\" v$VERSION\n+    git push --follow-tags\n+}\n+\n+merge_release () {\n+    echo \"Merge release to master\"\n+    git checkout -q master\n+    git pull\n+    git merge release\n+    git push\n+}\n+\n+main () {\n+    validate_dependencies\n+    create_working_dir\n+    merge_release_candidate\n+    tag_release\n+    merge_release\n+    delete_working_dir","path":"finish_release.sh","position":32,"original_position":32,"commit_id":"b2a09c652713d2b4e4b0ced741bd7db2dcd68549","original_commit_id":"b2a09c652713d2b4e4b0ced741bd7db2dcd68549","user":{"login":"gsidebo","id":14932219,"avatar_url":"https://avatars.githubusercontent.com/u/14932219?v=3","gravatar_id":"","url":"https://api.github.com/users/gsidebo","html_url":"https://github.com/gsidebo","followers_url":"https://api.github.com/users/gsidebo/followers","following_url":"https://api.github.com/users/gsidebo/following{/other_user}","gists_url":"https://api.github.com/users/gsidebo/gists{/gist_id}","starred_url":"https://api.github.com/users/gsidebo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gsidebo/subscriptions","organizations_url":"https://api.github.com/users/gsidebo/orgs","repos_url":"https://api.github.com/users/gsidebo/repos","events_url":"https://api.github.com/users/gsidebo/events{/privacy}","received_events_url":"https://api.github.com/users/gsidebo/received_events","type":"User","site_admin":false},"body":"ok i see now. i think part of my confusion was that `create_working_dir` doesn't just create the directory, it also cd's into that directory","created_at":"2017-01-10T22:05:43Z","updated_at":"2017-01-10T22:05:50Z","html_url":"https://github.com/mitodl/release-script/pull/17#discussion_r95468452","pull_request_url":"https://api.github.com/repos/mitodl/release-script/pulls/17","_links":{"self":{"href":"https://api.github.com/repos/mitodl/release-script/pulls/comments/95468452"},"html":{"href":"https://github.com/mitodl/release-script/pull/17#discussion_r95468452"},"pull_request":{"href":"https://api.github.com/repos/mitodl/release-script/pulls/17"}}},"pull_request":{"url":"https://api.github.com/repos/mitodl/release-script/pulls/17","id":99579319,"html_url":"https://github.com/mitodl/release-script/pull/17","diff_url":"https://github.com/mitodl/release-script/pull/17.diff","patch_url":"https://github.com/mitodl/release-script/pull/17.patch","issue_url":"https://api.github.com/repos/mitodl/release-script/issues/17","number":17,"state":"open","locked":false,"title":"Finish release script","user":{"login":"annagav","id":7574259,"avatar_url":"https://avatars.githubusercontent.com/u/7574259?v=3","gravatar_id":"","url":"https://api.github.com/users/annagav","html_url":"https://github.com/annagav","followers_url":"https://api.github.com/users/annagav/followers","following_url":"https://api.github.com/users/annagav/following{/other_user}","gists_url":"https://api.github.com/users/annagav/gists{/gist_id}","starred_url":"https://api.github.com/users/annagav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/annagav/subscriptions","organizations_url":"https://api.github.com/users/annagav/orgs","repos_url":"https://api.github.com/users/annagav/repos","events_url":"https://api.github.com/users/annagav/events{/privacy}","received_events_url":"https://api.github.com/users/annagav/received_events","type":"User","site_admin":false},"body":"Fix #16","created_at":"2016-12-28T18:34:00Z","updated_at":"2017-01-10T22:05:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bbff65ebc8d905b1f70154a7b22ddf39a9d9976a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mitodl/release-script/pulls/17/commits","review_comments_url":"https://api.github.com/repos/mitodl/release-script/pulls/17/comments","review_comment_url":"https://api.github.com/repos/mitodl/release-script/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mitodl/release-script/issues/17/comments","statuses_url":"https://api.github.com/repos/mitodl/release-script/statuses/b2a09c652713d2b4e4b0ced741bd7db2dcd68549","head":{"label":"mitodl:ag/finish_release","ref":"ag/finish_release","sha":"b2a09c652713d2b4e4b0ced741bd7db2dcd68549","user":{"login":"mitodl","id":7918516,"avatar_url":"https://avatars.githubusercontent.com/u/7918516?v=3","gravatar_id":"","url":"https://api.github.com/users/mitodl","html_url":"https://github.com/mitodl","followers_url":"https://api.github.com/users/mitodl/followers","following_url":"https://api.github.com/users/mitodl/following{/other_user}","gists_url":"https://api.github.com/users/mitodl/gists{/gist_id}","starred_url":"https://api.github.com/users/mitodl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitodl/subscriptions","organizations_url":"https://api.github.com/users/mitodl/orgs","repos_url":"https://api.github.com/users/mitodl/repos","events_url":"https://api.github.com/users/mitodl/events{/privacy}","received_events_url":"https://api.github.com/users/mitodl/received_events","type":"Organization","site_admin":false},"repo":{"id":51475352,"name":"release-script","full_name":"mitodl/release-script","owner":{"login":"mitodl","id":7918516,"avatar_url":"https://avatars.githubusercontent.com/u/7918516?v=3","gravatar_id":"","url":"https://api.github.com/users/mitodl","html_url":"https://github.com/mitodl","followers_url":"https://api.github.com/users/mitodl/followers","following_url":"https://api.github.com/users/mitodl/following{/other_user}","gists_url":"https://api.github.com/users/mitodl/gists{/gist_id}","starred_url":"https://api.github.com/users/mitodl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitodl/subscriptions","organizations_url":"https://api.github.com/users/mitodl/orgs","repos_url":"https://api.github.com/users/mitodl/repos","events_url":"https://api.github.com/users/mitodl/events{/privacy}","received_events_url":"https://api.github.com/users/mitodl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mitodl/release-script","description":"Scripts to automate the release process.","fork":false,"url":"https://api.github.com/repos/mitodl/release-script","forks_url":"https://api.github.com/repos/mitodl/release-script/forks","keys_url":"https://api.github.com/repos/mitodl/release-script/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mitodl/release-script/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mitodl/release-script/teams","hooks_url":"https://api.github.com/repos/mitodl/release-script/hooks","issue_events_url":"https://api.github.com/repos/mitodl/release-script/issues/events{/number}","events_url":"https://api.github.com/repos/mitodl/release-script/events","assignees_url":"https://api.github.com/repos/mitodl/release-script/assignees{/user}","branches_url":"https://api.github.com/repos/mitodl/release-script/branches{/branch}","tags_url":"https://api.github.com/repos/mitodl/release-script/tags","blobs_url":"https://api.github.com/repos/mitodl/release-script/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mitodl/release-script/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mitodl/release-script/git/refs{/sha}","trees_url":"https://api.github.com/repos/mitodl/release-script/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mitodl/release-script/statuses/{sha}","languages_url":"https://api.github.com/repos/mitodl/release-script/languages","stargazers_url":"https://api.github.com/repos/mitodl/release-script/stargazers","contributors_url":"https://api.github.com/repos/mitodl/release-script/contributors","subscribers_url":"https://api.github.com/repos/mitodl/release-script/subscribers","subscription_url":"https://api.github.com/repos/mitodl/release-script/subscription","commits_url":"https://api.github.com/repos/mitodl/release-script/commits{/sha}","git_commits_url":"https://api.github.com/repos/mitodl/release-script/git/commits{/sha}","comments_url":"https://api.github.com/repos/mitodl/release-script/comments{/number}","issue_comment_url":"https://api.github.com/repos/mitodl/release-script/issues/comments{/number}","contents_url":"https://api.github.com/repos/mitodl/release-script/contents/{+path}","compare_url":"https://api.github.com/repos/mitodl/release-script/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mitodl/release-script/merges","archive_url":"https://api.github.com/repos/mitodl/release-script/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mitodl/release-script/downloads","issues_url":"https://api.github.com/repos/mitodl/release-script/issues{/number}","pulls_url":"https://api.github.com/repos/mitodl/release-script/pulls{/number}","milestones_url":"https://api.github.com/repos/mitodl/release-script/milestones{/number}","notifications_url":"https://api.github.com/repos/mitodl/release-script/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mitodl/release-script/labels{/name}","releases_url":"https://api.github.com/repos/mitodl/release-script/releases{/id}","deployments_url":"https://api.github.com/repos/mitodl/release-script/deployments","created_at":"2016-02-10T21:55:18Z","updated_at":"2016-03-04T19:27:20Z","pushed_at":"2017-01-03T20:00:23Z","git_url":"git://github.com/mitodl/release-script.git","ssh_url":"git@github.com:mitodl/release-script.git","clone_url":"https://github.com/mitodl/release-script.git","svn_url":"https://github.com/mitodl/release-script","homepage":null,"size":1088,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":9,"forks":0,"open_issues":9,"watchers":0,"default_branch":"master"}},"base":{"label":"mitodl:master","ref":"master","sha":"403564567fd0779d996ffce6421c19e8551630ce","user":{"login":"mitodl","id":7918516,"avatar_url":"https://avatars.githubusercontent.com/u/7918516?v=3","gravatar_id":"","url":"https://api.github.com/users/mitodl","html_url":"https://github.com/mitodl","followers_url":"https://api.github.com/users/mitodl/followers","following_url":"https://api.github.com/users/mitodl/following{/other_user}","gists_url":"https://api.github.com/users/mitodl/gists{/gist_id}","starred_url":"https://api.github.com/users/mitodl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitodl/subscriptions","organizations_url":"https://api.github.com/users/mitodl/orgs","repos_url":"https://api.github.com/users/mitodl/repos","events_url":"https://api.github.com/users/mitodl/events{/privacy}","received_events_url":"https://api.github.com/users/mitodl/received_events","type":"Organization","site_admin":false},"repo":{"id":51475352,"name":"release-script","full_name":"mitodl/release-script","owner":{"login":"mitodl","id":7918516,"avatar_url":"https://avatars.githubusercontent.com/u/7918516?v=3","gravatar_id":"","url":"https://api.github.com/users/mitodl","html_url":"https://github.com/mitodl","followers_url":"https://api.github.com/users/mitodl/followers","following_url":"https://api.github.com/users/mitodl/following{/other_user}","gists_url":"https://api.github.com/users/mitodl/gists{/gist_id}","starred_url":"https://api.github.com/users/mitodl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitodl/subscriptions","organizations_url":"https://api.github.com/users/mitodl/orgs","repos_url":"https://api.github.com/users/mitodl/repos","events_url":"https://api.github.com/users/mitodl/events{/privacy}","received_events_url":"https://api.github.com/users/mitodl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mitodl/release-script","description":"Scripts to automate the release process.","fork":false,"url":"https://api.github.com/repos/mitodl/release-script","forks_url":"https://api.github.com/repos/mitodl/release-script/forks","keys_url":"https://api.github.com/repos/mitodl/release-script/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mitodl/release-script/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mitodl/release-script/teams","hooks_url":"https://api.github.com/repos/mitodl/release-script/hooks","issue_events_url":"https://api.github.com/repos/mitodl/release-script/issues/events{/number}","events_url":"https://api.github.com/repos/mitodl/release-script/events","assignees_url":"https://api.github.com/repos/mitodl/release-script/assignees{/user}","branches_url":"https://api.github.com/repos/mitodl/release-script/branches{/branch}","tags_url":"https://api.github.com/repos/mitodl/release-script/tags","blobs_url":"https://api.github.com/repos/mitodl/release-script/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mitodl/release-script/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mitodl/release-script/git/refs{/sha}","trees_url":"https://api.github.com/repos/mitodl/release-script/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mitodl/release-script/statuses/{sha}","languages_url":"https://api.github.com/repos/mitodl/release-script/languages","stargazers_url":"https://api.github.com/repos/mitodl/release-script/stargazers","contributors_url":"https://api.github.com/repos/mitodl/release-script/contributors","subscribers_url":"https://api.github.com/repos/mitodl/release-script/subscribers","subscription_url":"https://api.github.com/repos/mitodl/release-script/subscription","commits_url":"https://api.github.com/repos/mitodl/release-script/commits{/sha}","git_commits_url":"https://api.github.com/repos/mitodl/release-script/git/commits{/sha}","comments_url":"https://api.github.com/repos/mitodl/release-script/comments{/number}","issue_comment_url":"https://api.github.com/repos/mitodl/release-script/issues/comments{/number}","contents_url":"https://api.github.com/repos/mitodl/release-script/contents/{+path}","compare_url":"https://api.github.com/repos/mitodl/release-script/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mitodl/release-script/merges","archive_url":"https://api.github.com/repos/mitodl/release-script/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mitodl/release-script/downloads","issues_url":"https://api.github.com/repos/mitodl/release-script/issues{/number}","pulls_url":"https://api.github.com/repos/mitodl/release-script/pulls{/number}","milestones_url":"https://api.github.com/repos/mitodl/release-script/milestones{/number}","notifications_url":"https://api.github.com/repos/mitodl/release-script/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mitodl/release-script/labels{/name}","releases_url":"https://api.github.com/repos/mitodl/release-script/releases{/id}","deployments_url":"https://api.github.com/repos/mitodl/release-script/deployments","created_at":"2016-02-10T21:55:18Z","updated_at":"2016-03-04T19:27:20Z","pushed_at":"2017-01-03T20:00:23Z","git_url":"git://github.com/mitodl/release-script.git","ssh_url":"git@github.com:mitodl/release-script.git","clone_url":"https://github.com/mitodl/release-script.git","svn_url":"https://github.com/mitodl/release-script","homepage":null,"size":1088,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":9,"forks":0,"open_issues":9,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mitodl/release-script/pulls/17"},"html":{"href":"https://github.com/mitodl/release-script/pull/17"},"issue":{"href":"https://api.github.com/repos/mitodl/release-script/issues/17"},"comments":{"href":"https://api.github.com/repos/mitodl/release-script/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/mitodl/release-script/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/mitodl/release-script/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mitodl/release-script/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/mitodl/release-script/statuses/b2a09c652713d2b4e4b0ced741bd7db2dcd68549"}}}}
{"actor":{"display_login":"gsidebo"}}