{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/roslyn/issues/20561","repository_url":"https://api.github.com/repos/dotnet/roslyn","labels_url":"https://api.github.com/repos/dotnet/roslyn/issues/20561/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/20561/comments","events_url":"https://api.github.com/repos/dotnet/roslyn/issues/20561/events","html_url":"https://github.com/dotnet/roslyn/pull/20561","id":239679981,"number":20561,"title":"Classify discards as identifier","user":{"login":"jcouv","id":12466233,"avatar_url":"https://avatars1.githubusercontent.com/u/12466233?v=3","gravatar_id":"","url":"https://api.github.com/users/jcouv","html_url":"https://github.com/jcouv","followers_url":"https://api.github.com/users/jcouv/followers","following_url":"https://api.github.com/users/jcouv/following{/other_user}","gists_url":"https://api.github.com/users/jcouv/gists{/gist_id}","starred_url":"https://api.github.com/users/jcouv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcouv/subscriptions","organizations_url":"https://api.github.com/users/jcouv/orgs","repos_url":"https://api.github.com/users/jcouv/repos","events_url":"https://api.github.com/users/jcouv/events{/privacy}","received_events_url":"https://api.github.com/users/jcouv/received_events","type":"User","site_admin":false},"labels":[{"id":166377917,"url":"https://api.github.com/repos/dotnet/roslyn/labels/Area-IDE","name":"Area-IDE","color":"5319e7","default":false},{"id":197452922,"url":"https://api.github.com/repos/dotnet/roslyn/labels/cla-already-signed","name":"cla-already-signed","color":"FFFFFF","default":false}],"state":"open","locked":false,"assignee":{"login":"jcouv","id":12466233,"avatar_url":"https://avatars1.githubusercontent.com/u/12466233?v=3","gravatar_id":"","url":"https://api.github.com/users/jcouv","html_url":"https://github.com/jcouv","followers_url":"https://api.github.com/users/jcouv/followers","following_url":"https://api.github.com/users/jcouv/following{/other_user}","gists_url":"https://api.github.com/users/jcouv/gists{/gist_id}","starred_url":"https://api.github.com/users/jcouv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcouv/subscriptions","organizations_url":"https://api.github.com/users/jcouv/orgs","repos_url":"https://api.github.com/users/jcouv/repos","events_url":"https://api.github.com/users/jcouv/events{/privacy}","received_events_url":"https://api.github.com/users/jcouv/received_events","type":"User","site_admin":false},"assignees":[{"login":"jcouv","id":12466233,"avatar_url":"https://avatars1.githubusercontent.com/u/12466233?v=3","gravatar_id":"","url":"https://api.github.com/users/jcouv","html_url":"https://github.com/jcouv","followers_url":"https://api.github.com/users/jcouv/followers","following_url":"https://api.github.com/users/jcouv/following{/other_user}","gists_url":"https://api.github.com/users/jcouv/gists{/gist_id}","starred_url":"https://api.github.com/users/jcouv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcouv/subscriptions","organizations_url":"https://api.github.com/users/jcouv/orgs","repos_url":"https://api.github.com/users/jcouv/repos","events_url":"https://api.github.com/users/jcouv/events{/privacy}","received_events_url":"https://api.github.com/users/jcouv/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/dotnet/roslyn/milestones/30","html_url":"https://github.com/dotnet/roslyn/milestone/30","labels_url":"https://api.github.com/repos/dotnet/roslyn/milestones/30/labels","id":2495537,"number":30,"title":"15.5","description":"","creator":{"login":"sharwell","id":1408396,"avatar_url":"https://avatars2.githubusercontent.com/u/1408396?v=3","gravatar_id":"","url":"https://api.github.com/users/sharwell","html_url":"https://github.com/sharwell","followers_url":"https://api.github.com/users/sharwell/followers","following_url":"https://api.github.com/users/sharwell/following{/other_user}","gists_url":"https://api.github.com/users/sharwell/gists{/gist_id}","starred_url":"https://api.github.com/users/sharwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharwell/subscriptions","organizations_url":"https://api.github.com/users/sharwell/orgs","repos_url":"https://api.github.com/users/sharwell/repos","events_url":"https://api.github.com/users/sharwell/events{/privacy}","received_events_url":"https://api.github.com/users/sharwell/received_events","type":"User","site_admin":false},"open_issues":385,"closed_issues":86,"state":"open","created_at":"2017-05-02T17:12:16Z","updated_at":"2017-06-30T23:07:20Z","due_on":null,"closed_at":null},"comments":10,"created_at":"2017-06-30T05:21:48Z","updated_at":"2017-07-01T02:32:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/20561","html_url":"https://github.com/dotnet/roslyn/pull/20561","diff_url":"https://github.com/dotnet/roslyn/pull/20561.diff","patch_url":"https://github.com/dotnet/roslyn/pull/20561.patch"},"body":"Adds classification for discard designation syntax, and identifier syntax represents a discard symbol.\r\n\r\n@CyrusNajmabadi @roslyn-ide \r\nTwo questions:\r\n- Is `Identifier` the correct classification for discards?\r\n- Although I verified the classification in unittest and also by debugging the dev hive, the colors still seem wrong. Any tips on how to troubleshoot that?\r\n\r\n![image](https://user-images.githubusercontent.com/12466233/27721885-88b9ebb4-5d18-11e7-9cdd-352682c3e8e2.png)\r\n"},"comment":{"url":"https://api.github.com/repos/dotnet/roslyn/issues/comments/312405295","html_url":"https://github.com/dotnet/roslyn/pull/20561#issuecomment-312405295","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/20561","id":312405295,"user":{"login":"jcouv","id":12466233,"avatar_url":"https://avatars1.githubusercontent.com/u/12466233?v=3","gravatar_id":"","url":"https://api.github.com/users/jcouv","html_url":"https://github.com/jcouv","followers_url":"https://api.github.com/users/jcouv/followers","following_url":"https://api.github.com/users/jcouv/following{/other_user}","gists_url":"https://api.github.com/users/jcouv/gists{/gist_id}","starred_url":"https://api.github.com/users/jcouv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcouv/subscriptions","organizations_url":"https://api.github.com/users/jcouv/orgs","repos_url":"https://api.github.com/users/jcouv/repos","events_url":"https://api.github.com/users/jcouv/events{/privacy}","received_events_url":"https://api.github.com/users/jcouv/received_events","type":"User","site_admin":false},"created_at":"2017-07-01T02:32:13Z","updated_at":"2017-07-01T02:32:13Z","body":"It's unclear what is the VS integration error. ([details](https://ci.dot.net/job/dotnet_roslyn/job/master/job/windows_debug_vs-integration_prtest/5766/))\r\nI'll re-run.\r\n\r\n```\r\n18:34:07 Running 1 test assemblies in 1 partitions\r\n18:34:14    1 running,  0 queued,  0 completed\r\n18:59:18    0 running,  0 queued,  1 completed,  1 failures\r\n18:59:18 Errors Roslyn.VisualStudio.IntegrationTests.dll: \r\n18:59:18 \r\n18:59:18 Command: C:\\Users\\dotnet-bot\\.nuget\\packages\\xunit.runner.console\\2.2.0-beta4-build3444\\tools\\xunit.console.x86.exe \"D:\\j\\workspace\\windows_debug---0c191de0\\Binaries\\Debug\\UnitTests\\VisualStudioIntegrationTests\\Roslyn.VisualStudio.IntegrationTests.dll\"  -xml \"D:\\j\\workspace\\windows_debug---0c191de0\\Binaries\\Debug\\UnitTests\\VisualStudioIntegrationTests\\xUnitResults\\Roslyn.VisualStudio.IntegrationTests.dll.xml\" -noshadow -verbose\r\n18:59:18 xUnit output log: D:\\j\\workspace\\windows_debug---0c191de0\\Binaries\\Debug\\UnitTests\\VisualStudioIntegrationTests\\xUnitResults\\Roslyn.VisualStudio.IntegrationTests.dll.out.log\r\n18:59:18 \r\nxunit produced no error output but had exit code 1\r\n18:59:18 ================\r\n```"}}
{"actor":{"display_login":"jcouv"}}