{"action":"opened","number":1646,"pull_request":{"url":"https://api.github.com/repos/googlefonts/fontbakery/pulls/1646","id":151633308,"html_url":"https://github.com/googlefonts/fontbakery/pull/1646","diff_url":"https://github.com/googlefonts/fontbakery/pull/1646.diff","patch_url":"https://github.com/googlefonts/fontbakery/pull/1646.patch","issue_url":"https://api.github.com/repos/googlefonts/fontbakery/issues/1646","number":1646,"state":"open","locked":false,"title":"com_google_fonts_test_118: improve detection of modified glyphs","user":{"login":"m4rc1e","id":7525512,"avatar_url":"https://avatars0.githubusercontent.com/u/7525512?v=4","gravatar_id":"","url":"https://api.github.com/users/m4rc1e","html_url":"https://github.com/m4rc1e","followers_url":"https://api.github.com/users/m4rc1e/followers","following_url":"https://api.github.com/users/m4rc1e/following{/other_user}","gists_url":"https://api.github.com/users/m4rc1e/gists{/gist_id}","starred_url":"https://api.github.com/users/m4rc1e/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m4rc1e/subscriptions","organizations_url":"https://api.github.com/users/m4rc1e/orgs","repos_url":"https://api.github.com/users/m4rc1e/repos","events_url":"https://api.github.com/users/m4rc1e/events{/privacy}","received_events_url":"https://api.github.com/users/m4rc1e/received_events","type":"User","site_admin":false},"body":"I have revised this check because of https://github.com/huertatipografica/Alegreya-Sans/issues/11\r\n\r\nThere are two problems this pr addresses\r\n\r\n1.\r\nIn the previous implementation, if the fonts have different upms, all glyphs would be flagged as modified.\r\n\r\nWhen a font's upm increases and the glyphs are scaled accordingly, the surface area of each glyph will also increase. I've updated the check so the upms are used when calculating the surface area.\r\n\r\n2.\r\nThe previous glyph difference value was too high. This mean't Alegreya's tbar issue slipped through.","created_at":"2017-11-09T12:01:20Z","updated_at":"2017-11-09T12:01:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/googlefonts/fontbakery/pulls/1646/commits","review_comments_url":"https://api.github.com/repos/googlefonts/fontbakery/pulls/1646/comments","review_comment_url":"https://api.github.com/repos/googlefonts/fontbakery/pulls/comments{/number}","comments_url":"https://api.github.com/repos/googlefonts/fontbakery/issues/1646/comments","statuses_url":"https://api.github.com/repos/googlefonts/fontbakery/statuses/6b2a0e5607a2e620a74c3f4d3a38729ff2a57206","head":{"label":"m4rc1e:normalize","ref":"normalize","sha":"6b2a0e5607a2e620a74c3f4d3a38729ff2a57206","user":{"login":"m4rc1e","id":7525512,"avatar_url":"https://avatars0.githubusercontent.com/u/7525512?v=4","gravatar_id":"","url":"https://api.github.com/users/m4rc1e","html_url":"https://github.com/m4rc1e","followers_url":"https://api.github.com/users/m4rc1e/followers","following_url":"https://api.github.com/users/m4rc1e/following{/other_user}","gists_url":"https://api.github.com/users/m4rc1e/gists{/gist_id}","starred_url":"https://api.github.com/users/m4rc1e/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m4rc1e/subscriptions","organizations_url":"https://api.github.com/users/m4rc1e/orgs","repos_url":"https://api.github.com/users/m4rc1e/repos","events_url":"https://api.github.com/users/m4rc1e/events{/privacy}","received_events_url":"https://api.github.com/users/m4rc1e/received_events","type":"User","site_admin":false},"repo":{"id":67598331,"name":"fontbakery","full_name":"m4rc1e/fontbakery","owner":{"login":"m4rc1e","id":7525512,"avatar_url":"https://avatars0.githubusercontent.com/u/7525512?v=4","gravatar_id":"","url":"https://api.github.com/users/m4rc1e","html_url":"https://github.com/m4rc1e","followers_url":"https://api.github.com/users/m4rc1e/followers","following_url":"https://api.github.com/users/m4rc1e/following{/other_user}","gists_url":"https://api.github.com/users/m4rc1e/gists{/gist_id}","starred_url":"https://api.github.com/users/m4rc1e/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m4rc1e/subscriptions","organizations_url":"https://api.github.com/users/m4rc1e/orgs","repos_url":"https://api.github.com/users/m4rc1e/repos","events_url":"https://api.github.com/users/m4rc1e/events{/privacy}","received_events_url":"https://api.github.com/users/m4rc1e/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/m4rc1e/fontbakery","description":"Tools to prepare font families for inclusion in github.com/google/fonts","fork":true,"url":"https://api.github.com/repos/m4rc1e/fontbakery","forks_url":"https://api.github.com/repos/m4rc1e/fontbakery/forks","keys_url":"https://api.github.com/repos/m4rc1e/fontbakery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/m4rc1e/fontbakery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/m4rc1e/fontbakery/teams","hooks_url":"https://api.github.com/repos/m4rc1e/fontbakery/hooks","issue_events_url":"https://api.github.com/repos/m4rc1e/fontbakery/issues/events{/number}","events_url":"https://api.github.com/repos/m4rc1e/fontbakery/events","assignees_url":"https://api.github.com/repos/m4rc1e/fontbakery/assignees{/user}","branches_url":"https://api.github.com/repos/m4rc1e/fontbakery/branches{/branch}","tags_url":"https://api.github.com/repos/m4rc1e/fontbakery/tags","blobs_url":"https://api.github.com/repos/m4rc1e/fontbakery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/m4rc1e/fontbakery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/m4rc1e/fontbakery/git/refs{/sha}","trees_url":"https://api.github.com/repos/m4rc1e/fontbakery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/m4rc1e/fontbakery/statuses/{sha}","languages_url":"https://api.github.com/repos/m4rc1e/fontbakery/languages","stargazers_url":"https://api.github.com/repos/m4rc1e/fontbakery/stargazers","contributors_url":"https://api.github.com/repos/m4rc1e/fontbakery/contributors","subscribers_url":"https://api.github.com/repos/m4rc1e/fontbakery/subscribers","subscription_url":"https://api.github.com/repos/m4rc1e/fontbakery/subscription","commits_url":"https://api.github.com/repos/m4rc1e/fontbakery/commits{/sha}","git_commits_url":"https://api.github.com/repos/m4rc1e/fontbakery/git/commits{/sha}","comments_url":"https://api.github.com/repos/m4rc1e/fontbakery/comments{/number}","issue_comment_url":"https://api.github.com/repos/m4rc1e/fontbakery/issues/comments{/number}","contents_url":"https://api.github.com/repos/m4rc1e/fontbakery/contents/{+path}","compare_url":"https://api.github.com/repos/m4rc1e/fontbakery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/m4rc1e/fontbakery/merges","archive_url":"https://api.github.com/repos/m4rc1e/fontbakery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/m4rc1e/fontbakery/downloads","issues_url":"https://api.github.com/repos/m4rc1e/fontbakery/issues{/number}","pulls_url":"https://api.github.com/repos/m4rc1e/fontbakery/pulls{/number}","milestones_url":"https://api.github.com/repos/m4rc1e/fontbakery/milestones{/number}","notifications_url":"https://api.github.com/repos/m4rc1e/fontbakery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/m4rc1e/fontbakery/labels{/name}","releases_url":"https://api.github.com/repos/m4rc1e/fontbakery/releases{/id}","deployments_url":"https://api.github.com/repos/m4rc1e/fontbakery/deployments","created_at":"2016-09-07T10:52:14Z","updated_at":"2016-09-07T10:52:15Z","pushed_at":"2017-11-09T11:56:22Z","git_url":"git://github.com/m4rc1e/fontbakery.git","ssh_url":"git@github.com:m4rc1e/fontbakery.git","clone_url":"https://github.com/m4rc1e/fontbakery.git","svn_url":"https://github.com/m4rc1e/fontbakery","homepage":"http://googlefonts.github.io/fontbakery","size":31900,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"googlefonts:master","ref":"master","sha":"2bb534d380fd160ae78185bdaecab94810e60a00","user":{"login":"googlefonts","id":6466306,"avatar_url":"https://avatars2.githubusercontent.com/u/6466306?v=4","gravatar_id":"","url":"https://api.github.com/users/googlefonts","html_url":"https://github.com/googlefonts","followers_url":"https://api.github.com/users/googlefonts/followers","following_url":"https://api.github.com/users/googlefonts/following{/other_user}","gists_url":"https://api.github.com/users/googlefonts/gists{/gist_id}","starred_url":"https://api.github.com/users/googlefonts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googlefonts/subscriptions","organizations_url":"https://api.github.com/users/googlefonts/orgs","repos_url":"https://api.github.com/users/googlefonts/repos","events_url":"https://api.github.com/users/googlefonts/events{/privacy}","received_events_url":"https://api.github.com/users/googlefonts/received_events","type":"Organization","site_admin":false},"repo":{"id":8233105,"name":"fontbakery","full_name":"googlefonts/fontbakery","owner":{"login":"googlefonts","id":6466306,"avatar_url":"https://avatars2.githubusercontent.com/u/6466306?v=4","gravatar_id":"","url":"https://api.github.com/users/googlefonts","html_url":"https://github.com/googlefonts","followers_url":"https://api.github.com/users/googlefonts/followers","following_url":"https://api.github.com/users/googlefonts/following{/other_user}","gists_url":"https://api.github.com/users/googlefonts/gists{/gist_id}","starred_url":"https://api.github.com/users/googlefonts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googlefonts/subscriptions","organizations_url":"https://api.github.com/users/googlefonts/orgs","repos_url":"https://api.github.com/users/googlefonts/repos","events_url":"https://api.github.com/users/googlefonts/events{/privacy}","received_events_url":"https://api.github.com/users/googlefonts/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/googlefonts/fontbakery","description":"Tools to prepare font families for inclusion in github.com/google/fonts","fork":false,"url":"https://api.github.com/repos/googlefonts/fontbakery","forks_url":"https://api.github.com/repos/googlefonts/fontbakery/forks","keys_url":"https://api.github.com/repos/googlefonts/fontbakery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/googlefonts/fontbakery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/googlefonts/fontbakery/teams","hooks_url":"https://api.github.com/repos/googlefonts/fontbakery/hooks","issue_events_url":"https://api.github.com/repos/googlefonts/fontbakery/issues/events{/number}","events_url":"https://api.github.com/repos/googlefonts/fontbakery/events","assignees_url":"https://api.github.com/repos/googlefonts/fontbakery/assignees{/user}","branches_url":"https://api.github.com/repos/googlefonts/fontbakery/branches{/branch}","tags_url":"https://api.github.com/repos/googlefonts/fontbakery/tags","blobs_url":"https://api.github.com/repos/googlefonts/fontbakery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/googlefonts/fontbakery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/googlefonts/fontbakery/git/refs{/sha}","trees_url":"https://api.github.com/repos/googlefonts/fontbakery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/googlefonts/fontbakery/statuses/{sha}","languages_url":"https://api.github.com/repos/googlefonts/fontbakery/languages","stargazers_url":"https://api.github.com/repos/googlefonts/fontbakery/stargazers","contributors_url":"https://api.github.com/repos/googlefonts/fontbakery/contributors","subscribers_url":"https://api.github.com/repos/googlefonts/fontbakery/subscribers","subscription_url":"https://api.github.com/repos/googlefonts/fontbakery/subscription","commits_url":"https://api.github.com/repos/googlefonts/fontbakery/commits{/sha}","git_commits_url":"https://api.github.com/repos/googlefonts/fontbakery/git/commits{/sha}","comments_url":"https://api.github.com/repos/googlefonts/fontbakery/comments{/number}","issue_comment_url":"https://api.github.com/repos/googlefonts/fontbakery/issues/comments{/number}","contents_url":"https://api.github.com/repos/googlefonts/fontbakery/contents/{+path}","compare_url":"https://api.github.com/repos/googlefonts/fontbakery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/googlefonts/fontbakery/merges","archive_url":"https://api.github.com/repos/googlefonts/fontbakery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/googlefonts/fontbakery/downloads","issues_url":"https://api.github.com/repos/googlefonts/fontbakery/issues{/number}","pulls_url":"https://api.github.com/repos/googlefonts/fontbakery/pulls{/number}","milestones_url":"https://api.github.com/repos/googlefonts/fontbakery/milestones{/number}","notifications_url":"https://api.github.com/repos/googlefonts/fontbakery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/googlefonts/fontbakery/labels{/name}","releases_url":"https://api.github.com/repos/googlefonts/fontbakery/releases{/id}","deployments_url":"https://api.github.com/repos/googlefonts/fontbakery/deployments","created_at":"2013-02-16T07:47:27Z","updated_at":"2017-10-27T03:50:13Z","pushed_at":"2017-11-08T16:31:28Z","git_url":"git://github.com/googlefonts/fontbakery.git","ssh_url":"git@github.com:googlefonts/fontbakery.git","clone_url":"https://github.com/googlefonts/fontbakery.git","svn_url":"https://github.com/googlefonts/fontbakery","homepage":"","size":31972,"stargazers_count":134,"watchers_count":134,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":33,"mirror_url":null,"archived":false,"open_issues_count":65,"forks":33,"open_issues":65,"watchers":134,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/googlefonts/fontbakery/pulls/1646"},"html":{"href":"https://github.com/googlefonts/fontbakery/pull/1646"},"issue":{"href":"https://api.github.com/repos/googlefonts/fontbakery/issues/1646"},"comments":{"href":"https://api.github.com/repos/googlefonts/fontbakery/issues/1646/comments"},"review_comments":{"href":"https://api.github.com/repos/googlefonts/fontbakery/pulls/1646/comments"},"review_comment":{"href":"https://api.github.com/repos/googlefonts/fontbakery/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/googlefonts/fontbakery/pulls/1646/commits"},"statuses":{"href":"https://api.github.com/repos/googlefonts/fontbakery/statuses/6b2a0e5607a2e620a74c3f4d3a38729ff2a57206"}},"author_association":"COLLABORATOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":2,"additions":8,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"m4rc1e"}}