{"action":"created","issue":{"url":"https://api.github.com/repos/spotify/luigi/issues/2044","repository_url":"https://api.github.com/repos/spotify/luigi","labels_url":"https://api.github.com/repos/spotify/luigi/issues/2044/labels{/name}","comments_url":"https://api.github.com/repos/spotify/luigi/issues/2044/comments","events_url":"https://api.github.com/repos/spotify/luigi/issues/2044/events","html_url":"https://github.com/spotify/luigi/pull/2044","id":210378182,"number":2044,"title":"Initial pass at metrics collection for Central Scheduler","user":{"login":"chrispalmer","id":362534,"avatar_url":"https://avatars.githubusercontent.com/u/362534?v=3","gravatar_id":"","url":"https://api.github.com/users/chrispalmer","html_url":"https://github.com/chrispalmer","followers_url":"https://api.github.com/users/chrispalmer/followers","following_url":"https://api.github.com/users/chrispalmer/following{/other_user}","gists_url":"https://api.github.com/users/chrispalmer/gists{/gist_id}","starred_url":"https://api.github.com/users/chrispalmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrispalmer/subscriptions","organizations_url":"https://api.github.com/users/chrispalmer/orgs","repos_url":"https://api.github.com/users/chrispalmer/repos","events_url":"https://api.github.com/users/chrispalmer/events{/privacy}","received_events_url":"https://api.github.com/users/chrispalmer/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-02-27T03:19:07Z","updated_at":"2017-02-27T03:19:08Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/spotify/luigi/pulls/2044","html_url":"https://github.com/spotify/luigi/pull/2044","diff_url":"https://github.com/spotify/luigi/pull/2044.diff","patch_url":"https://github.com/spotify/luigi/pull/2044.patch"},"body":"## Description\r\nThis is an initial pass at adding metric collection functionality to the Central Scheduler, and is still a work in progress. I'm looking for feedback on the general approach.\r\n\r\nSummary of changes:\r\n\r\n- Dummy `MetricsCollector` class (luigi/metrics.py) with no-op methods, but can be subclassed for a specific metric collection tool.\r\n- `PrometheusMetricsCollector` class (luigi/contrib/prometheus.py) that subclasses the above, as an example implementation.\r\n- New `scheduler` config option/parameter to select the metric collection tool.\r\n- changes to `SimpleTaskState` to identify and trigger metric updates.\r\n- Added `Scheduler.remove_worker` rpc_method to related `Worker._remove_worker` method to allow workers to tell the scheduler when they are finishing and disconnecting. This allows us to distinguish between deliberate disconnects and worker failures.\r\n\r\n\r\n## Motivation and Context\r\nThis is an attempt to provide functionality desired in [issue 2306](https://github.com/spotify/luigi/issues/2036)\r\n\r\n## Have you tested this? If so, how?\r\nDoes not yet include any tests.\r\nI have run it against some very simple pipelines and it seems to do as expected.\r\n"},"comment":{"url":"https://api.github.com/repos/spotify/luigi/issues/comments/282618715","html_url":"https://github.com/spotify/luigi/pull/2044#issuecomment-282618715","issue_url":"https://api.github.com/repos/spotify/luigi/issues/2044","id":282618715,"user":{"login":"mention-bot","id":15710697,"avatar_url":"https://avatars.githubusercontent.com/u/15710697?v=3","gravatar_id":"","url":"https://api.github.com/users/mention-bot","html_url":"https://github.com/mention-bot","followers_url":"https://api.github.com/users/mention-bot/followers","following_url":"https://api.github.com/users/mention-bot/following{/other_user}","gists_url":"https://api.github.com/users/mention-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/mention-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mention-bot/subscriptions","organizations_url":"https://api.github.com/users/mention-bot/orgs","repos_url":"https://api.github.com/users/mention-bot/repos","events_url":"https://api.github.com/users/mention-bot/events{/privacy}","received_events_url":"https://api.github.com/users/mention-bot/received_events","type":"User","site_admin":false},"created_at":"2017-02-27T03:19:08Z","updated_at":"2017-02-27T03:19:08Z","body":"@chrispalmer, thanks for your PR! By analyzing the history of the files in this pull request, we identified @daveFNbuck, @erikbern and @DavW to be potential reviewers."}}
{"actor":{"display_login":"mention-bot"}}