{"action":"created","issue":{"url":"https://api.github.com/repos/highfidelity/hifi/issues/11184","repository_url":"https://api.github.com/repos/highfidelity/hifi","labels_url":"https://api.github.com/repos/highfidelity/hifi/issues/11184/labels{/name}","comments_url":"https://api.github.com/repos/highfidelity/hifi/issues/11184/comments","events_url":"https://api.github.com/repos/highfidelity/hifi/issues/11184/events","html_url":"https://github.com/highfidelity/hifi/pull/11184","id":250050080,"number":11184,"title":"Fade edition bug fix","user":{"login":"Zvork","id":14199381,"avatar_url":"https://avatars3.githubusercontent.com/u/14199381?v=4","gravatar_id":"","url":"https://api.github.com/users/Zvork","html_url":"https://github.com/Zvork","followers_url":"https://api.github.com/users/Zvork/followers","following_url":"https://api.github.com/users/Zvork/following{/other_user}","gists_url":"https://api.github.com/users/Zvork/gists{/gist_id}","starred_url":"https://api.github.com/users/Zvork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zvork/subscriptions","organizations_url":"https://api.github.com/users/Zvork/orgs","repos_url":"https://api.github.com/users/Zvork/repos","events_url":"https://api.github.com/users/Zvork/events{/privacy}","received_events_url":"https://api.github.com/users/Zvork/received_events","type":"User","site_admin":false},"labels":[{"id":313595519,"url":"https://api.github.com/repos/highfidelity/hifi/labels/QA%20Ready","name":"QA Ready","color":"bfd4f2","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2017-08-14T14:35:20Z","updated_at":"2017-08-15T19:22:42Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/11184","html_url":"https://github.com/highfidelity/hifi/pull/11184","diff_url":"https://github.com/highfidelity/hifi/pull/11184.diff","patch_url":"https://github.com/highfidelity/hifi/pull/11184.patch"},"body":"This PR fixes two small bugs when editing fade events with the *debugFade.js* script in *scripts\\developer\\utilities\\render* concerning the \"invert\" and \"Base gradient size\" parameters. Testers should refer to the description of PR #10964 and #11021 to understand the gradient based fade effect.\r\n\r\n# TEST PLAN\r\n1. With the \"debugFade.js\" script running, checking the \"Edit Fade\" checkbox should apply the event selected to the combobox at the right side of the checkbox on the object in front of you.\r\n2. With the \"debugFade.js\" script running, the \"Edit Fade\" checkbox checked and any event selected except the last \"change avatar\", modifying the \"Invert\" parameter of the edit window should modify the fade visuals by inverting the transparency\r\n3.  With the \"debugFade.js\" script running, the \"Edit Fade\" checkbox checked and any event selected except the last two events, \"user enters/leaves\" and \"change avatar\", modifying the \"Base gradient size\" X, Y or Z parameters of the edit window with the \"Base gradient level\" set to a value greater than 0.0 should modify the fade visuals accordingly. Turning down the \"Noise gradient level\" to zero can help visualize this better.\r\n"},"comment":{"url":"https://api.github.com/repos/highfidelity/hifi/issues/comments/322563074","html_url":"https://github.com/highfidelity/hifi/pull/11184#issuecomment-322563074","issue_url":"https://api.github.com/repos/highfidelity/hifi/issues/11184","id":322563074,"user":{"login":"Nex-Pro","id":7314019,"avatar_url":"https://avatars2.githubusercontent.com/u/7314019?v=4","gravatar_id":"","url":"https://api.github.com/users/Nex-Pro","html_url":"https://github.com/Nex-Pro","followers_url":"https://api.github.com/users/Nex-Pro/followers","following_url":"https://api.github.com/users/Nex-Pro/following{/other_user}","gists_url":"https://api.github.com/users/Nex-Pro/gists{/gist_id}","starred_url":"https://api.github.com/users/Nex-Pro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nex-Pro/subscriptions","organizations_url":"https://api.github.com/users/Nex-Pro/orgs","repos_url":"https://api.github.com/users/Nex-Pro/repos","events_url":"https://api.github.com/users/Nex-Pro/events{/privacy}","received_events_url":"https://api.github.com/users/Nex-Pro/received_events","type":"User","site_admin":false},"created_at":"2017-08-15T19:22:41Z","updated_at":"2017-08-15T19:22:41Z","body":"With the \"debugFade.js\" script running, checking the \"Edit Fade\" checkbox should apply the event selected to the combobox at the right side of the checkbox on the object in front of you. **SUCCESS**\r\nWith the \"debugFade.js\" script running, the \"Edit Fade\" checkbox checked and any event selected except the last \"change avatar\", modifying the \"Invert\" parameter of the edit window should modify the fade visuals by inverting the transparency **SUCCSESS**\r\nWith the \"debugFade.js\" script running, the \"Edit Fade\" checkbox checked and any event selected except the last two events, \"user enters/leaves\" and \"change avatar\", modifying the \"Base gradient size\" X, Y or Z parameters of the edit window with the \"Base gradient level\" set to a value greater than 0.0 should modify the fade visuals accordingly. **SUCCESS**\r\n\r\nTurning down the \"Noise gradient level\" to zero can help visualize this better.\r\n\r\nThere is an issue with textures or possibly lighting that I am seeing. After the effect appears to have completed some entities appear to be extremely dark or maybe black.\r\n\r\nSee image.  Compare the two plants.  They should look more or less the same. The one on the left is too dark. It is the one that has had the fade effect. Second image the one on right has had effect. Third image neither has had effect.\r\n\r\n![hifi-snap-by--on-2017-08-15_18-56-38](https://user-images.githubusercontent.com/7314019/29332290-6e3ee0d8-81f7-11e7-82dc-621b6217f6fa.jpg)\r\n\r\n\r\n![hifi-snap-by--on-2017-08-15_19-00-09](https://user-images.githubusercontent.com/7314019/29332294-73a54724-81f7-11e7-8a4f-cc3e640c1078.jpg)\r\n\r\n![hifi-snap-by--on-2017-08-15_19-00-23](https://user-images.githubusercontent.com/7314019/29332297-79bd3518-81f7-11e7-970b-fd6804cc9740.jpg)\r\n"}}
{"actor":{"display_login":"Nex-Pro"}}