{"action":"created","comment":{"url":"https://api.github.com/repos/joomla-projects/media-manager-improvement/pulls/comments/121251216","pull_request_review_id":43291825,"id":121251216,"diff_hunk":"@@ -13,4 +13,18 @@\n \t\t<filename plugin=\"local\">local.php</filename>\n \t\t<folder>adapter</folder>\n \t</files>\n+\n+\t<config>\n+\t\t<fields name=\"params\">\n+\t\t\t<fieldset name=\"basic\">\n+\t\t\t\t<field\n+\t\t\t\t\t\tname=\"display_name\"\n+\t\t\t\t\t\ttype=\"text\"\n+\t\t\t\t\t\tlabel=\"Display Name\"\n+\t\t\t\t\t\tdescription=\"Local Filesystem plugin\"","path":"plugins/filesystem/local/local.xml","position":12,"original_position":12,"commit_id":"14981b89bf37f57bafa9b2eea936b98ed3179a7f","original_commit_id":"14981b89bf37f57bafa9b2eea936b98ed3179a7f","user":{"login":"laoneo","id":251072,"avatar_url":"https://avatars0.githubusercontent.com/u/251072?v=3","gravatar_id":"","url":"https://api.github.com/users/laoneo","html_url":"https://github.com/laoneo","followers_url":"https://api.github.com/users/laoneo/followers","following_url":"https://api.github.com/users/laoneo/following{/other_user}","gists_url":"https://api.github.com/users/laoneo/gists{/gist_id}","starred_url":"https://api.github.com/users/laoneo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laoneo/subscriptions","organizations_url":"https://api.github.com/users/laoneo/orgs","repos_url":"https://api.github.com/users/laoneo/repos","events_url":"https://api.github.com/users/laoneo/events{/privacy}","received_events_url":"https://api.github.com/users/laoneo/received_events","type":"User","site_admin":false},"body":"Needs to be a a translatable key.","created_at":"2017-06-10T06:50:31Z","updated_at":"2017-06-10T06:54:55Z","html_url":"https://github.com/joomla-projects/media-manager-improvement/pull/244#discussion_r121251216","pull_request_url":"https://api.github.com/repos/joomla-projects/media-manager-improvement/pulls/244","_links":{"self":{"href":"https://api.github.com/repos/joomla-projects/media-manager-improvement/pulls/comments/121251216"},"html":{"href":"https://github.com/joomla-projects/media-manager-improvement/pull/244#discussion_r121251216"},"pull_request":{"href":"https://api.github.com/repos/joomla-projects/media-manager-improvement/pulls/244"}}},"pull_request":{"url":"https://api.github.com/repos/joomla-projects/media-manager-improvement/pulls/244","id":124914602,"html_url":"https://github.com/joomla-projects/media-manager-improvement/pull/244","diff_url":"https://github.com/joomla-projects/media-manager-improvement/pull/244.diff","patch_url":"https://github.com/joomla-projects/media-manager-improvement/pull/244.patch","issue_url":"https://api.github.com/repos/joomla-projects/media-manager-improvement/issues/244","number":244,"state":"open","locked":false,"title":"Feature/multiple adapter support","user":{"login":"kasvith","id":13379595,"avatar_url":"https://avatars3.githubusercontent.com/u/13379595?v=3","gravatar_id":"","url":"https://api.github.com/users/kasvith","html_url":"https://github.com/kasvith","followers_url":"https://api.github.com/users/kasvith/followers","following_url":"https://api.github.com/users/kasvith/following{/other_user}","gists_url":"https://api.github.com/users/kasvith/gists{/gist_id}","starred_url":"https://api.github.com/users/kasvith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kasvith/subscriptions","organizations_url":"https://api.github.com/users/kasvith/orgs","repos_url":"https://api.github.com/users/kasvith/repos","events_url":"https://api.github.com/users/kasvith/events{/privacy}","received_events_url":"https://api.github.com/users/kasvith/received_events","type":"User","site_admin":false},"body":"Pull Request for Issue #190  .\r\n\r\n### Summary of Changes\r\n- Added config param to Local File System plugin for set Display Name\r\n- Added Foo File System Plugin\r\n- Added multiple adapter support to API\r\n- Added multiple adapter support to Controller\r\n- Injected config params to Media View\r\n\r\n\r\n### Testing Instructions\r\n- Discover **Foo Filesystem**\r\n- Go to NMM\r\n- HTTP 200OK message will be shown, ignore for now\r\n- Try these urls on browser\r\n  - http://localhost/media-manager-improvement/administrator/index.php?option=com_media&format=json&task=api.files&path=local:/banners\r\n  - http://localhost/media-manager-improvement/administrator/index.php?option=com_media&format=json&task=api.files&path=foo:/\r\n\r\n### Expected result\r\n- A JSON response containing all the files\r\n\r\n\r\n### Actual result\r\n\r\n\r\n\r\n@dneukirchen @dgt41 if this is ok we can go with frontend implementation\r\n\r\n","created_at":"2017-06-09T17:28:13Z","updated_at":"2017-06-10T06:54:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"52c9f08da72dd4415ddb435320c24c7b1bf6334e","assignee":{"login":"kasvith","id":13379595,"avatar_url":"https://avatars3.githubusercontent.com/u/13379595?v=3","gravatar_id":"","url":"https://api.github.com/users/kasvith","html_url":"https://github.com/kasvith","followers_url":"https://api.github.com/users/kasvith/followers","following_url":"https://api.github.com/users/kasvith/following{/other_user}","gists_url":"https://api.github.com/users/kasvith/gists{/gist_id}","starred_url":"https://api.github.com/users/kasvith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kasvith/subscriptions","organizations_url":"https://api.github.com/users/kasvith/orgs","repos_url":"https://api.github.com/users/kasvith/repos","events_url":"https://api.github.com/users/kasvith/events{/privacy}","received_events_url":"https://api.github.com/users/kasvith/received_events","type":"User","site_admin":false},"assignees":[{"login":"kasvith","id":13379595,"avatar_url":"https://avatars3.githubusercontent.com/u/13379595?v=3","gravatar_id":"","url":"https://api.github.com/users/kasvith","html_url":"https://github.com/kasvith","followers_url":"https://api.github.com/users/kasvith/followers","following_url":"https://api.github.com/users/kasvith/following{/other_user}","gists_url":"https://api.github.com/users/kasvith/gists{/gist_id}","starred_url":"https://api.github.com/users/kasvith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kasvith/subscriptions","organizations_url":"https://api.github.com/users/kasvith/orgs","repos_url":"https://api.github.com/users/kasvith/repos","events_url":"https://api.github.com/users/kasvith/events{/privacy}","received_events_url":"https://api.github.com/users/kasvith/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"yvesh","id":897638,"avatar_url":"https://avatars3.githubusercontent.com/u/897638?v=3","gravatar_id":"","url":"https://api.github.com/users/yvesh","html_url":"https://github.com/yvesh","followers_url":"https://api.github.com/users/yvesh/followers","following_url":"https://api.github.com/users/yvesh/following{/other_user}","gists_url":"https://api.github.com/users/yvesh/gists{/gist_id}","starred_url":"https://api.github.com/users/yvesh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yvesh/subscriptions","organizations_url":"https://api.github.com/users/yvesh/orgs","repos_url":"https://api.github.com/users/yvesh/repos","events_url":"https://api.github.com/users/yvesh/events{/privacy}","received_events_url":"https://api.github.com/users/yvesh/received_events","type":"User","site_admin":false},{"login":"dneukirchen","id":1134007,"avatar_url":"https://avatars1.githubusercontent.com/u/1134007?v=3","gravatar_id":"","url":"https://api.github.com/users/dneukirchen","html_url":"https://github.com/dneukirchen","followers_url":"https://api.github.com/users/dneukirchen/followers","following_url":"https://api.github.com/users/dneukirchen/following{/other_user}","gists_url":"https://api.github.com/users/dneukirchen/gists{/gist_id}","starred_url":"https://api.github.com/users/dneukirchen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dneukirchen/subscriptions","organizations_url":"https://api.github.com/users/dneukirchen/orgs","repos_url":"https://api.github.com/users/dneukirchen/repos","events_url":"https://api.github.com/users/dneukirchen/events{/privacy}","received_events_url":"https://api.github.com/users/dneukirchen/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/joomla-projects/media-manager-improvement/pulls/244/commits","review_comments_url":"https://api.github.com/repos/joomla-projects/media-manager-improvement/pulls/244/comments","review_comment_url":"https://api.github.com/repos/joomla-projects/media-manager-improvement/pulls/comments{/number}","comments_url":"https://api.github.com/repos/joomla-projects/media-manager-improvement/issues/244/comments","statuses_url":"https://api.github.com/repos/joomla-projects/media-manager-improvement/statuses/14981b89bf37f57bafa9b2eea936b98ed3179a7f","head":{"label":"kasvith:feature/multiple-adapter-support","ref":"feature/multiple-adapter-support","sha":"14981b89bf37f57bafa9b2eea936b98ed3179a7f","user":{"login":"kasvith","id":13379595,"avatar_url":"https://avatars3.githubusercontent.com/u/13379595?v=3","gravatar_id":"","url":"https://api.github.com/users/kasvith","html_url":"https://github.com/kasvith","followers_url":"https://api.github.com/users/kasvith/followers","following_url":"https://api.github.com/users/kasvith/following{/other_user}","gists_url":"https://api.github.com/users/kasvith/gists{/gist_id}","starred_url":"https://api.github.com/users/kasvith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kasvith/subscriptions","organizations_url":"https://api.github.com/users/kasvith/orgs","repos_url":"https://api.github.com/users/kasvith/repos","events_url":"https://api.github.com/users/kasvith/events{/privacy}","received_events_url":"https://api.github.com/users/kasvith/received_events","type":"User","site_admin":false},"repo":{"id":87625518,"name":"media-manager-improvement","full_name":"kasvith/media-manager-improvement","owner":{"login":"kasvith","id":13379595,"avatar_url":"https://avatars3.githubusercontent.com/u/13379595?v=3","gravatar_id":"","url":"https://api.github.com/users/kasvith","html_url":"https://github.com/kasvith","followers_url":"https://api.github.com/users/kasvith/followers","following_url":"https://api.github.com/users/kasvith/following{/other_user}","gists_url":"https://api.github.com/users/kasvith/gists{/gist_id}","starred_url":"https://api.github.com/users/kasvith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kasvith/subscriptions","organizations_url":"https://api.github.com/users/kasvith/orgs","repos_url":"https://api.github.com/users/kasvith/repos","events_url":"https://api.github.com/users/kasvith/events{/privacy}","received_events_url":"https://api.github.com/users/kasvith/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kasvith/media-manager-improvement","description":"Repository for the improvement of Media Manager","fork":true,"url":"https://api.github.com/repos/kasvith/media-manager-improvement","forks_url":"https://api.github.com/repos/kasvith/media-manager-improvement/forks","keys_url":"https://api.github.com/repos/kasvith/media-manager-improvement/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kasvith/media-manager-improvement/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kasvith/media-manager-improvement/teams","hooks_url":"https://api.github.com/repos/kasvith/media-manager-improvement/hooks","issue_events_url":"https://api.github.com/repos/kasvith/media-manager-improvement/issues/events{/number}","events_url":"https://api.github.com/repos/kasvith/media-manager-improvement/events","assignees_url":"https://api.github.com/repos/kasvith/media-manager-improvement/assignees{/user}","branches_url":"https://api.github.com/repos/kasvith/media-manager-improvement/branches{/branch}","tags_url":"https://api.github.com/repos/kasvith/media-manager-improvement/tags","blobs_url":"https://api.github.com/repos/kasvith/media-manager-improvement/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kasvith/media-manager-improvement/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kasvith/media-manager-improvement/git/refs{/sha}","trees_url":"https://api.github.com/repos/kasvith/media-manager-improvement/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kasvith/media-manager-improvement/statuses/{sha}","languages_url":"https://api.github.com/repos/kasvith/media-manager-improvement/languages","stargazers_url":"https://api.github.com/repos/kasvith/media-manager-improvement/stargazers","contributors_url":"https://api.github.com/repos/kasvith/media-manager-improvement/contributors","subscribers_url":"https://api.github.com/repos/kasvith/media-manager-improvement/subscribers","subscription_url":"https://api.github.com/repos/kasvith/media-manager-improvement/subscription","commits_url":"https://api.github.com/repos/kasvith/media-manager-improvement/commits{/sha}","git_commits_url":"https://api.github.com/repos/kasvith/media-manager-improvement/git/commits{/sha}","comments_url":"https://api.github.com/repos/kasvith/media-manager-improvement/comments{/number}","issue_comment_url":"https://api.github.com/repos/kasvith/media-manager-improvement/issues/comments{/number}","contents_url":"https://api.github.com/repos/kasvith/media-manager-improvement/contents/{+path}","compare_url":"https://api.github.com/repos/kasvith/media-manager-improvement/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kasvith/media-manager-improvement/merges","archive_url":"https://api.github.com/repos/kasvith/media-manager-improvement/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kasvith/media-manager-improvement/downloads","issues_url":"https://api.github.com/repos/kasvith/media-manager-improvement/issues{/number}","pulls_url":"https://api.github.com/repos/kasvith/media-manager-improvement/pulls{/number}","milestones_url":"https://api.github.com/repos/kasvith/media-manager-improvement/milestones{/number}","notifications_url":"https://api.github.com/repos/kasvith/media-manager-improvement/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kasvith/media-manager-improvement/labels{/name}","releases_url":"https://api.github.com/repos/kasvith/media-manager-improvement/releases{/id}","deployments_url":"https://api.github.com/repos/kasvith/media-manager-improvement/deployments","created_at":"2017-04-08T10:19:00Z","updated_at":"2017-04-08T10:19:13Z","pushed_at":"2017-06-09T18:16:08Z","git_url":"git://github.com/kasvith/media-manager-improvement.git","ssh_url":"git@github.com:kasvith/media-manager-improvement.git","clone_url":"https://github.com/kasvith/media-manager-improvement.git","svn_url":"https://github.com/kasvith/media-manager-improvement","homepage":"https://volunteers.joomla.org/teams/new-media-manager-team","size":161983,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"milestone1"}},"base":{"label":"joomla-projects:milestone1","ref":"milestone1","sha":"25ce473cdef17f40d9bf60ab8125e0c5956f4a47","user":{"login":"joomla-projects","id":4417437,"avatar_url":"https://avatars3.githubusercontent.com/u/4417437?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla-projects","html_url":"https://github.com/joomla-projects","followers_url":"https://api.github.com/users/joomla-projects/followers","following_url":"https://api.github.com/users/joomla-projects/following{/other_user}","gists_url":"https://api.github.com/users/joomla-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla-projects/subscriptions","organizations_url":"https://api.github.com/users/joomla-projects/orgs","repos_url":"https://api.github.com/users/joomla-projects/repos","events_url":"https://api.github.com/users/joomla-projects/events{/privacy}","received_events_url":"https://api.github.com/users/joomla-projects/received_events","type":"Organization","site_admin":false},"repo":{"id":47698650,"name":"media-manager-improvement","full_name":"joomla-projects/media-manager-improvement","owner":{"login":"joomla-projects","id":4417437,"avatar_url":"https://avatars3.githubusercontent.com/u/4417437?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla-projects","html_url":"https://github.com/joomla-projects","followers_url":"https://api.github.com/users/joomla-projects/followers","following_url":"https://api.github.com/users/joomla-projects/following{/other_user}","gists_url":"https://api.github.com/users/joomla-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla-projects/subscriptions","organizations_url":"https://api.github.com/users/joomla-projects/orgs","repos_url":"https://api.github.com/users/joomla-projects/repos","events_url":"https://api.github.com/users/joomla-projects/events{/privacy}","received_events_url":"https://api.github.com/users/joomla-projects/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/joomla-projects/media-manager-improvement","description":"Repository for the improvement of Media Manager","fork":false,"url":"https://api.github.com/repos/joomla-projects/media-manager-improvement","forks_url":"https://api.github.com/repos/joomla-projects/media-manager-improvement/forks","keys_url":"https://api.github.com/repos/joomla-projects/media-manager-improvement/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joomla-projects/media-manager-improvement/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joomla-projects/media-manager-improvement/teams","hooks_url":"https://api.github.com/repos/joomla-projects/media-manager-improvement/hooks","issue_events_url":"https://api.github.com/repos/joomla-projects/media-manager-improvement/issues/events{/number}","events_url":"https://api.github.com/repos/joomla-projects/media-manager-improvement/events","assignees_url":"https://api.github.com/repos/joomla-projects/media-manager-improvement/assignees{/user}","branches_url":"https://api.github.com/repos/joomla-projects/media-manager-improvement/branches{/branch}","tags_url":"https://api.github.com/repos/joomla-projects/media-manager-improvement/tags","blobs_url":"https://api.github.com/repos/joomla-projects/media-manager-improvement/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joomla-projects/media-manager-improvement/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joomla-projects/media-manager-improvement/git/refs{/sha}","trees_url":"https://api.github.com/repos/joomla-projects/media-manager-improvement/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joomla-projects/media-manager-improvement/statuses/{sha}","languages_url":"https://api.github.com/repos/joomla-projects/media-manager-improvement/languages","stargazers_url":"https://api.github.com/repos/joomla-projects/media-manager-improvement/stargazers","contributors_url":"https://api.github.com/repos/joomla-projects/media-manager-improvement/contributors","subscribers_url":"https://api.github.com/repos/joomla-projects/media-manager-improvement/subscribers","subscription_url":"https://api.github.com/repos/joomla-projects/media-manager-improvement/subscription","commits_url":"https://api.github.com/repos/joomla-projects/media-manager-improvement/commits{/sha}","git_commits_url":"https://api.github.com/repos/joomla-projects/media-manager-improvement/git/commits{/sha}","comments_url":"https://api.github.com/repos/joomla-projects/media-manager-improvement/comments{/number}","issue_comment_url":"https://api.github.com/repos/joomla-projects/media-manager-improvement/issues/comments{/number}","contents_url":"https://api.github.com/repos/joomla-projects/media-manager-improvement/contents/{+path}","compare_url":"https://api.github.com/repos/joomla-projects/media-manager-improvement/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joomla-projects/media-manager-improvement/merges","archive_url":"https://api.github.com/repos/joomla-projects/media-manager-improvement/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joomla-projects/media-manager-improvement/downloads","issues_url":"https://api.github.com/repos/joomla-projects/media-manager-improvement/issues{/number}","pulls_url":"https://api.github.com/repos/joomla-projects/media-manager-improvement/pulls{/number}","milestones_url":"https://api.github.com/repos/joomla-projects/media-manager-improvement/milestones{/number}","notifications_url":"https://api.github.com/repos/joomla-projects/media-manager-improvement/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joomla-projects/media-manager-improvement/labels{/name}","releases_url":"https://api.github.com/repos/joomla-projects/media-manager-improvement/releases{/id}","deployments_url":"https://api.github.com/repos/joomla-projects/media-manager-improvement/deployments","created_at":"2015-12-09T15:08:53Z","updated_at":"2017-05-24T15:52:36Z","pushed_at":"2017-06-09T18:16:10Z","git_url":"git://github.com/joomla-projects/media-manager-improvement.git","ssh_url":"git@github.com:joomla-projects/media-manager-improvement.git","clone_url":"https://github.com/joomla-projects/media-manager-improvement.git","svn_url":"https://github.com/joomla-projects/media-manager-improvement","homepage":"https://volunteers.joomla.org/teams/new-media-manager-team","size":161875,"stargazers_count":11,"watchers_count":11,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":40,"forks":25,"open_issues":40,"watchers":11,"default_branch":"milestone1"}},"_links":{"self":{"href":"https://api.github.com/repos/joomla-projects/media-manager-improvement/pulls/244"},"html":{"href":"https://github.com/joomla-projects/media-manager-improvement/pull/244"},"issue":{"href":"https://api.github.com/repos/joomla-projects/media-manager-improvement/issues/244"},"comments":{"href":"https://api.github.com/repos/joomla-projects/media-manager-improvement/issues/244/comments"},"review_comments":{"href":"https://api.github.com/repos/joomla-projects/media-manager-improvement/pulls/244/comments"},"review_comment":{"href":"https://api.github.com/repos/joomla-projects/media-manager-improvement/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/joomla-projects/media-manager-improvement/pulls/244/commits"},"statuses":{"href":"https://api.github.com/repos/joomla-projects/media-manager-improvement/statuses/14981b89bf37f57bafa9b2eea936b98ed3179a7f"}}}}
{"actor":{"display_login":"laoneo"}}