{"action":"created","comment":{"url":"https://api.github.com/repos/openSUSE/linuxrc/pulls/comments/96636830","pull_request_review_id":17223406,"id":96636830,"diff_hunk":"@@ -2269,19 +2270,30 @@ static int test_is_repo(url_t *url)\n \n     if(\n       url->is.mountable &&\n-      (util_is_mountable(buf) || !util_check_exist(buf)) &&\n+      (copy || util_is_mountable(buf) || !util_check_exist(buf)) &&\n       !config.rescue &&\n       (!config.download.instsys || util_check_exist(buf) == 'd')\n     ) {\n       if(!util_check_exist(buf) && opt) {\n-        log_info(\"mount %s -> %s failed (ignored)\\n\", buf, sl->value);\n+        log_info(\"%s %s -> %s failed (ignored)\\n\", copy ? \"copy\" : \"mount\", buf, sl->value);\n       }\n       else {\n-        log_info(\"mount %s -> %s\\n\", buf, sl->value);\n-\n-        i = util_mount_ro(buf, sl->value, url->file_list) ? 0 : 1;\n-        ok &= i;\n-        if(!i) log_info(\"instsys mount failed: %s\\n\", sl->value);\n+        if(copy) {\n+          char *argv[3];\n+          char *dst = strrchr(t, '/') ?: t;\n+          log_info(\"copy %s -> %s\\n\", buf, dst);\n+          argv[1] = buf;","path":"url.c","position":40,"original_position":40,"commit_id":"38bed9a786d683815ebd32f27b6f53a914c0b3a8","original_commit_id":"38bed9a786d683815ebd32f27b6f53a914c0b3a8","user":{"login":"shundhammer","id":11538225,"avatar_url":"https://avatars.githubusercontent.com/u/11538225?v=3","gravatar_id":"","url":"https://api.github.com/users/shundhammer","html_url":"https://github.com/shundhammer","followers_url":"https://api.github.com/users/shundhammer/followers","following_url":"https://api.github.com/users/shundhammer/following{/other_user}","gists_url":"https://api.github.com/users/shundhammer/gists{/gist_id}","starred_url":"https://api.github.com/users/shundhammer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shundhammer/subscriptions","organizations_url":"https://api.github.com/users/shundhammer/orgs","repos_url":"https://api.github.com/users/shundhammer/repos","events_url":"https://api.github.com/users/shundhammer/events{/privacy}","received_events_url":"https://api.github.com/users/shundhammer/received_events","type":"User","site_admin":false},"body":"What about argv[0]? This remains uninitialized here.","created_at":"2017-01-18T13:47:35Z","updated_at":"2017-01-18T13:47:35Z","html_url":"https://github.com/openSUSE/linuxrc/pull/134#discussion_r96636830","pull_request_url":"https://api.github.com/repos/openSUSE/linuxrc/pulls/134","_links":{"self":{"href":"https://api.github.com/repos/openSUSE/linuxrc/pulls/comments/96636830"},"html":{"href":"https://github.com/openSUSE/linuxrc/pull/134#discussion_r96636830"},"pull_request":{"href":"https://api.github.com/repos/openSUSE/linuxrc/pulls/134"}}},"pull_request":{"url":"https://api.github.com/repos/openSUSE/linuxrc/pulls/134","id":102048468,"html_url":"https://github.com/openSUSE/linuxrc/pull/134","diff_url":"https://github.com/openSUSE/linuxrc/pull/134.diff","patch_url":"https://github.com/openSUSE/linuxrc/pull/134.patch","issue_url":"https://api.github.com/repos/openSUSE/linuxrc/issues/134","number":134,"state":"open","locked":false,"title":"allow reading of config files from instsys location (/boot/ARCH/) (fate #322283)","user":{"login":"wfeldt","id":927244,"avatar_url":"https://avatars.githubusercontent.com/u/927244?v=3","gravatar_id":"","url":"https://api.github.com/users/wfeldt","html_url":"https://github.com/wfeldt","followers_url":"https://api.github.com/users/wfeldt/followers","following_url":"https://api.github.com/users/wfeldt/following{/other_user}","gists_url":"https://api.github.com/users/wfeldt/gists{/gist_id}","starred_url":"https://api.github.com/users/wfeldt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wfeldt/subscriptions","organizations_url":"https://api.github.com/users/wfeldt/orgs","repos_url":"https://api.github.com/users/wfeldt/repos","events_url":"https://api.github.com/users/wfeldt/events{/privacy}","received_events_url":"https://api.github.com/users/wfeldt/received_events","type":"User","site_admin":false},"body":"This works by extending the /boot/ARCH/config file syntax (see docs):\r\n\r\nAppending '?copy=1' to a component tells linuxrc that this is not an image\r\nto mount but a file to copy to the '/' directoy.","created_at":"2017-01-18T11:37:49Z","updated_at":"2017-01-18T13:47:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5d2fd2c5b2ccc24700582b556481c793aa9c67b5","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/openSUSE/linuxrc/pulls/134/commits","review_comments_url":"https://api.github.com/repos/openSUSE/linuxrc/pulls/134/comments","review_comment_url":"https://api.github.com/repos/openSUSE/linuxrc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openSUSE/linuxrc/issues/134/comments","statuses_url":"https://api.github.com/repos/openSUSE/linuxrc/statuses/38bed9a786d683815ebd32f27b6f53a914c0b3a8","head":{"label":"openSUSE:fate_322283","ref":"fate_322283","sha":"38bed9a786d683815ebd32f27b6f53a914c0b3a8","user":{"login":"openSUSE","id":623819,"avatar_url":"https://avatars.githubusercontent.com/u/623819?v=3","gravatar_id":"","url":"https://api.github.com/users/openSUSE","html_url":"https://github.com/openSUSE","followers_url":"https://api.github.com/users/openSUSE/followers","following_url":"https://api.github.com/users/openSUSE/following{/other_user}","gists_url":"https://api.github.com/users/openSUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/openSUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openSUSE/subscriptions","organizations_url":"https://api.github.com/users/openSUSE/orgs","repos_url":"https://api.github.com/users/openSUSE/repos","events_url":"https://api.github.com/users/openSUSE/events{/privacy}","received_events_url":"https://api.github.com/users/openSUSE/received_events","type":"Organization","site_admin":false},"repo":{"id":11577324,"name":"linuxrc","full_name":"openSUSE/linuxrc","owner":{"login":"openSUSE","id":623819,"avatar_url":"https://avatars.githubusercontent.com/u/623819?v=3","gravatar_id":"","url":"https://api.github.com/users/openSUSE","html_url":"https://github.com/openSUSE","followers_url":"https://api.github.com/users/openSUSE/followers","following_url":"https://api.github.com/users/openSUSE/following{/other_user}","gists_url":"https://api.github.com/users/openSUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/openSUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openSUSE/subscriptions","organizations_url":"https://api.github.com/users/openSUSE/orgs","repos_url":"https://api.github.com/users/openSUSE/repos","events_url":"https://api.github.com/users/openSUSE/events{/privacy}","received_events_url":"https://api.github.com/users/openSUSE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openSUSE/linuxrc","description":"Installation Setup","fork":false,"url":"https://api.github.com/repos/openSUSE/linuxrc","forks_url":"https://api.github.com/repos/openSUSE/linuxrc/forks","keys_url":"https://api.github.com/repos/openSUSE/linuxrc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openSUSE/linuxrc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openSUSE/linuxrc/teams","hooks_url":"https://api.github.com/repos/openSUSE/linuxrc/hooks","issue_events_url":"https://api.github.com/repos/openSUSE/linuxrc/issues/events{/number}","events_url":"https://api.github.com/repos/openSUSE/linuxrc/events","assignees_url":"https://api.github.com/repos/openSUSE/linuxrc/assignees{/user}","branches_url":"https://api.github.com/repos/openSUSE/linuxrc/branches{/branch}","tags_url":"https://api.github.com/repos/openSUSE/linuxrc/tags","blobs_url":"https://api.github.com/repos/openSUSE/linuxrc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openSUSE/linuxrc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openSUSE/linuxrc/git/refs{/sha}","trees_url":"https://api.github.com/repos/openSUSE/linuxrc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openSUSE/linuxrc/statuses/{sha}","languages_url":"https://api.github.com/repos/openSUSE/linuxrc/languages","stargazers_url":"https://api.github.com/repos/openSUSE/linuxrc/stargazers","contributors_url":"https://api.github.com/repos/openSUSE/linuxrc/contributors","subscribers_url":"https://api.github.com/repos/openSUSE/linuxrc/subscribers","subscription_url":"https://api.github.com/repos/openSUSE/linuxrc/subscription","commits_url":"https://api.github.com/repos/openSUSE/linuxrc/commits{/sha}","git_commits_url":"https://api.github.com/repos/openSUSE/linuxrc/git/commits{/sha}","comments_url":"https://api.github.com/repos/openSUSE/linuxrc/comments{/number}","issue_comment_url":"https://api.github.com/repos/openSUSE/linuxrc/issues/comments{/number}","contents_url":"https://api.github.com/repos/openSUSE/linuxrc/contents/{+path}","compare_url":"https://api.github.com/repos/openSUSE/linuxrc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openSUSE/linuxrc/merges","archive_url":"https://api.github.com/repos/openSUSE/linuxrc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openSUSE/linuxrc/downloads","issues_url":"https://api.github.com/repos/openSUSE/linuxrc/issues{/number}","pulls_url":"https://api.github.com/repos/openSUSE/linuxrc/pulls{/number}","milestones_url":"https://api.github.com/repos/openSUSE/linuxrc/milestones{/number}","notifications_url":"https://api.github.com/repos/openSUSE/linuxrc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openSUSE/linuxrc/labels{/name}","releases_url":"https://api.github.com/repos/openSUSE/linuxrc/releases{/id}","deployments_url":"https://api.github.com/repos/openSUSE/linuxrc/deployments","created_at":"2013-07-22T09:08:56Z","updated_at":"2016-11-18T14:14:09Z","pushed_at":"2017-01-18T12:40:52Z","git_url":"git://github.com/openSUSE/linuxrc.git","ssh_url":"git@github.com:openSUSE/linuxrc.git","clone_url":"https://github.com/openSUSE/linuxrc.git","svn_url":"https://github.com/openSUSE/linuxrc","homepage":null,"size":15612,"stargazers_count":2,"watchers_count":2,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":6,"forks":15,"open_issues":6,"watchers":2,"default_branch":"master"}},"base":{"label":"openSUSE:master","ref":"master","sha":"3d43d381e2e4ed0561fff34acdb06bc6a2bb6ef6","user":{"login":"openSUSE","id":623819,"avatar_url":"https://avatars.githubusercontent.com/u/623819?v=3","gravatar_id":"","url":"https://api.github.com/users/openSUSE","html_url":"https://github.com/openSUSE","followers_url":"https://api.github.com/users/openSUSE/followers","following_url":"https://api.github.com/users/openSUSE/following{/other_user}","gists_url":"https://api.github.com/users/openSUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/openSUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openSUSE/subscriptions","organizations_url":"https://api.github.com/users/openSUSE/orgs","repos_url":"https://api.github.com/users/openSUSE/repos","events_url":"https://api.github.com/users/openSUSE/events{/privacy}","received_events_url":"https://api.github.com/users/openSUSE/received_events","type":"Organization","site_admin":false},"repo":{"id":11577324,"name":"linuxrc","full_name":"openSUSE/linuxrc","owner":{"login":"openSUSE","id":623819,"avatar_url":"https://avatars.githubusercontent.com/u/623819?v=3","gravatar_id":"","url":"https://api.github.com/users/openSUSE","html_url":"https://github.com/openSUSE","followers_url":"https://api.github.com/users/openSUSE/followers","following_url":"https://api.github.com/users/openSUSE/following{/other_user}","gists_url":"https://api.github.com/users/openSUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/openSUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openSUSE/subscriptions","organizations_url":"https://api.github.com/users/openSUSE/orgs","repos_url":"https://api.github.com/users/openSUSE/repos","events_url":"https://api.github.com/users/openSUSE/events{/privacy}","received_events_url":"https://api.github.com/users/openSUSE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openSUSE/linuxrc","description":"Installation Setup","fork":false,"url":"https://api.github.com/repos/openSUSE/linuxrc","forks_url":"https://api.github.com/repos/openSUSE/linuxrc/forks","keys_url":"https://api.github.com/repos/openSUSE/linuxrc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openSUSE/linuxrc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openSUSE/linuxrc/teams","hooks_url":"https://api.github.com/repos/openSUSE/linuxrc/hooks","issue_events_url":"https://api.github.com/repos/openSUSE/linuxrc/issues/events{/number}","events_url":"https://api.github.com/repos/openSUSE/linuxrc/events","assignees_url":"https://api.github.com/repos/openSUSE/linuxrc/assignees{/user}","branches_url":"https://api.github.com/repos/openSUSE/linuxrc/branches{/branch}","tags_url":"https://api.github.com/repos/openSUSE/linuxrc/tags","blobs_url":"https://api.github.com/repos/openSUSE/linuxrc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openSUSE/linuxrc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openSUSE/linuxrc/git/refs{/sha}","trees_url":"https://api.github.com/repos/openSUSE/linuxrc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openSUSE/linuxrc/statuses/{sha}","languages_url":"https://api.github.com/repos/openSUSE/linuxrc/languages","stargazers_url":"https://api.github.com/repos/openSUSE/linuxrc/stargazers","contributors_url":"https://api.github.com/repos/openSUSE/linuxrc/contributors","subscribers_url":"https://api.github.com/repos/openSUSE/linuxrc/subscribers","subscription_url":"https://api.github.com/repos/openSUSE/linuxrc/subscription","commits_url":"https://api.github.com/repos/openSUSE/linuxrc/commits{/sha}","git_commits_url":"https://api.github.com/repos/openSUSE/linuxrc/git/commits{/sha}","comments_url":"https://api.github.com/repos/openSUSE/linuxrc/comments{/number}","issue_comment_url":"https://api.github.com/repos/openSUSE/linuxrc/issues/comments{/number}","contents_url":"https://api.github.com/repos/openSUSE/linuxrc/contents/{+path}","compare_url":"https://api.github.com/repos/openSUSE/linuxrc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openSUSE/linuxrc/merges","archive_url":"https://api.github.com/repos/openSUSE/linuxrc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openSUSE/linuxrc/downloads","issues_url":"https://api.github.com/repos/openSUSE/linuxrc/issues{/number}","pulls_url":"https://api.github.com/repos/openSUSE/linuxrc/pulls{/number}","milestones_url":"https://api.github.com/repos/openSUSE/linuxrc/milestones{/number}","notifications_url":"https://api.github.com/repos/openSUSE/linuxrc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openSUSE/linuxrc/labels{/name}","releases_url":"https://api.github.com/repos/openSUSE/linuxrc/releases{/id}","deployments_url":"https://api.github.com/repos/openSUSE/linuxrc/deployments","created_at":"2013-07-22T09:08:56Z","updated_at":"2016-11-18T14:14:09Z","pushed_at":"2017-01-18T12:40:52Z","git_url":"git://github.com/openSUSE/linuxrc.git","ssh_url":"git@github.com:openSUSE/linuxrc.git","clone_url":"https://github.com/openSUSE/linuxrc.git","svn_url":"https://github.com/openSUSE/linuxrc","homepage":null,"size":15612,"stargazers_count":2,"watchers_count":2,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":6,"forks":15,"open_issues":6,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openSUSE/linuxrc/pulls/134"},"html":{"href":"https://github.com/openSUSE/linuxrc/pull/134"},"issue":{"href":"https://api.github.com/repos/openSUSE/linuxrc/issues/134"},"comments":{"href":"https://api.github.com/repos/openSUSE/linuxrc/issues/134/comments"},"review_comments":{"href":"https://api.github.com/repos/openSUSE/linuxrc/pulls/134/comments"},"review_comment":{"href":"https://api.github.com/repos/openSUSE/linuxrc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openSUSE/linuxrc/pulls/134/commits"},"statuses":{"href":"https://api.github.com/repos/openSUSE/linuxrc/statuses/38bed9a786d683815ebd32f27b6f53a914c0b3a8"}}}}
{"actor":{"display_login":"shundhammer"}}