{"action":"created","comment":{"url":"https://api.github.com/repos/betaflight/betaflight/pulls/comments/139385058","pull_request_review_id":63307440,"id":139385058,"diff_hunk":"@@ -152,18 +149,14 @@ void ws2811LedStripDMAEnable(void)\n         return;\n     }\n \n-    if (timerNChannel) {\n-        if (HAL_TIMEx_PWMN_Start_DMA(&TimHandle, timerChannel, ledStripDMABuffer, WS2811_DMA_BUFFER_SIZE) != HAL_OK) {\n-            /* Starting PWM generation Error */\n-            ws2811LedDataTransferInProgress = 0;\n-            return;\n-        }\n-    } else {\n-        if (HAL_TIM_PWM_Start_DMA(&TimHandle, timerChannel, ledStripDMABuffer, WS2811_DMA_BUFFER_SIZE) != HAL_OK) {\n-            /* Starting PWM generation Error */\n-            ws2811LedDataTransferInProgress = 0;\n-            return;\n-        }\n+    if (DMA_SetCurrDataCounter(&TimHandle, timerChannel, ledStripDMABuffer, WS2811_DMA_BUFFER_SIZE) != HAL_OK) {\n+        /* DMA set error */\n+        ws2811LedDataTransferInProgress = 0;\n+        return;\n     }\n+    /* Reset timer counter */\n+    __HAL_TIM_SET_COUNTER(&TimHandle,0);\n+    /* Enable channel DMA requests */\n+    TIM_DMACmd(&TimHandle,timerChannel,ENABLE);","path":"src/main/drivers/light_ws2811strip_hal.c","position":92,"original_position":92,"commit_id":"274ed9e7065c898577821a834ebf9312c8a9a9d5","original_commit_id":"274ed9e7065c898577821a834ebf9312c8a9a9d5","user":{"login":"ledvinap","id":2318015,"avatar_url":"https://avatars2.githubusercontent.com/u/2318015?v=4","gravatar_id":"","url":"https://api.github.com/users/ledvinap","html_url":"https://github.com/ledvinap","followers_url":"https://api.github.com/users/ledvinap/followers","following_url":"https://api.github.com/users/ledvinap/following{/other_user}","gists_url":"https://api.github.com/users/ledvinap/gists{/gist_id}","starred_url":"https://api.github.com/users/ledvinap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ledvinap/subscriptions","organizations_url":"https://api.github.com/users/ledvinap/orgs","repos_url":"https://api.github.com/users/ledvinap/repos","events_url":"https://api.github.com/users/ledvinap/events{/privacy}","received_events_url":"https://api.github.com/users/ledvinap/received_events","type":"User","site_admin":false},"body":"This is problematic - it will probably trigger DMA transfer immediately (DMA request is already set). With DMA FIFO enabled, this may fail the transfer (no data in FIFO to satisfy peripheral request, see reference manual).\r\nIt will work now, but can cause big headache when someone tries to optimize it","created_at":"2017-09-18T10:24:40Z","updated_at":"2017-09-18T11:00:11Z","html_url":"https://github.com/betaflight/betaflight/pull/4165#discussion_r139385058","pull_request_url":"https://api.github.com/repos/betaflight/betaflight/pulls/4165","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/betaflight/betaflight/pulls/comments/139385058"},"html":{"href":"https://github.com/betaflight/betaflight/pull/4165#discussion_r139385058"},"pull_request":{"href":"https://api.github.com/repos/betaflight/betaflight/pulls/4165"}}},"pull_request":{"url":"https://api.github.com/repos/betaflight/betaflight/pulls/4165","id":141498220,"html_url":"https://github.com/betaflight/betaflight/pull/4165","diff_url":"https://github.com/betaflight/betaflight/pull/4165.diff","patch_url":"https://github.com/betaflight/betaflight/pull/4165.patch","issue_url":"https://api.github.com/repos/betaflight/betaflight/issues/4165","number":4165,"state":"open","locked":false,"title":"F7 Dshot fix part 2","user":{"login":"sambas","id":2865403,"avatar_url":"https://avatars3.githubusercontent.com/u/2865403?v=4","gravatar_id":"","url":"https://api.github.com/users/sambas","html_url":"https://github.com/sambas","followers_url":"https://api.github.com/users/sambas/followers","following_url":"https://api.github.com/users/sambas/following{/other_user}","gists_url":"https://api.github.com/users/sambas/gists{/gist_id}","starred_url":"https://api.github.com/users/sambas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sambas/subscriptions","organizations_url":"https://api.github.com/users/sambas/orgs","repos_url":"https://api.github.com/users/sambas/repos","events_url":"https://api.github.com/users/sambas/events{/privacy}","received_events_url":"https://api.github.com/users/sambas/received_events","type":"User","site_admin":false},"body":"Rework Digital pwm, keep timer running all the time.\r\nFix N channel usage on F7","created_at":"2017-09-17T19:07:44Z","updated_at":"2017-09-18T11:00:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e1006860dc98ee418570f567585e601ca80fa568","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/betaflight/betaflight/pulls/4165/commits","review_comments_url":"https://api.github.com/repos/betaflight/betaflight/pulls/4165/comments","review_comment_url":"https://api.github.com/repos/betaflight/betaflight/pulls/comments{/number}","comments_url":"https://api.github.com/repos/betaflight/betaflight/issues/4165/comments","statuses_url":"https://api.github.com/repos/betaflight/betaflight/statuses/274ed9e7065c898577821a834ebf9312c8a9a9d5","head":{"label":"sambas:F7dhothack","ref":"F7dhothack","sha":"274ed9e7065c898577821a834ebf9312c8a9a9d5","user":{"login":"sambas","id":2865403,"avatar_url":"https://avatars3.githubusercontent.com/u/2865403?v=4","gravatar_id":"","url":"https://api.github.com/users/sambas","html_url":"https://github.com/sambas","followers_url":"https://api.github.com/users/sambas/followers","following_url":"https://api.github.com/users/sambas/following{/other_user}","gists_url":"https://api.github.com/users/sambas/gists{/gist_id}","starred_url":"https://api.github.com/users/sambas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sambas/subscriptions","organizations_url":"https://api.github.com/users/sambas/orgs","repos_url":"https://api.github.com/users/sambas/repos","events_url":"https://api.github.com/users/sambas/events{/privacy}","received_events_url":"https://api.github.com/users/sambas/received_events","type":"User","site_admin":false},"repo":{"id":30191080,"name":"cleanflight","full_name":"sambas/cleanflight","owner":{"login":"sambas","id":2865403,"avatar_url":"https://avatars3.githubusercontent.com/u/2865403?v=4","gravatar_id":"","url":"https://api.github.com/users/sambas","html_url":"https://github.com/sambas","followers_url":"https://api.github.com/users/sambas/followers","following_url":"https://api.github.com/users/sambas/following{/other_user}","gists_url":"https://api.github.com/users/sambas/gists{/gist_id}","starred_url":"https://api.github.com/users/sambas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sambas/subscriptions","organizations_url":"https://api.github.com/users/sambas/orgs","repos_url":"https://api.github.com/users/sambas/repos","events_url":"https://api.github.com/users/sambas/events{/privacy}","received_events_url":"https://api.github.com/users/sambas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sambas/cleanflight","description":"Clean-code version of the baseflight flight controller firmware","fork":true,"url":"https://api.github.com/repos/sambas/cleanflight","forks_url":"https://api.github.com/repos/sambas/cleanflight/forks","keys_url":"https://api.github.com/repos/sambas/cleanflight/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sambas/cleanflight/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sambas/cleanflight/teams","hooks_url":"https://api.github.com/repos/sambas/cleanflight/hooks","issue_events_url":"https://api.github.com/repos/sambas/cleanflight/issues/events{/number}","events_url":"https://api.github.com/repos/sambas/cleanflight/events","assignees_url":"https://api.github.com/repos/sambas/cleanflight/assignees{/user}","branches_url":"https://api.github.com/repos/sambas/cleanflight/branches{/branch}","tags_url":"https://api.github.com/repos/sambas/cleanflight/tags","blobs_url":"https://api.github.com/repos/sambas/cleanflight/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sambas/cleanflight/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sambas/cleanflight/git/refs{/sha}","trees_url":"https://api.github.com/repos/sambas/cleanflight/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sambas/cleanflight/statuses/{sha}","languages_url":"https://api.github.com/repos/sambas/cleanflight/languages","stargazers_url":"https://api.github.com/repos/sambas/cleanflight/stargazers","contributors_url":"https://api.github.com/repos/sambas/cleanflight/contributors","subscribers_url":"https://api.github.com/repos/sambas/cleanflight/subscribers","subscription_url":"https://api.github.com/repos/sambas/cleanflight/subscription","commits_url":"https://api.github.com/repos/sambas/cleanflight/commits{/sha}","git_commits_url":"https://api.github.com/repos/sambas/cleanflight/git/commits{/sha}","comments_url":"https://api.github.com/repos/sambas/cleanflight/comments{/number}","issue_comment_url":"https://api.github.com/repos/sambas/cleanflight/issues/comments{/number}","contents_url":"https://api.github.com/repos/sambas/cleanflight/contents/{+path}","compare_url":"https://api.github.com/repos/sambas/cleanflight/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sambas/cleanflight/merges","archive_url":"https://api.github.com/repos/sambas/cleanflight/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sambas/cleanflight/downloads","issues_url":"https://api.github.com/repos/sambas/cleanflight/issues{/number}","pulls_url":"https://api.github.com/repos/sambas/cleanflight/pulls{/number}","milestones_url":"https://api.github.com/repos/sambas/cleanflight/milestones{/number}","notifications_url":"https://api.github.com/repos/sambas/cleanflight/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sambas/cleanflight/labels{/name}","releases_url":"https://api.github.com/repos/sambas/cleanflight/releases{/id}","deployments_url":"https://api.github.com/repos/sambas/cleanflight/deployments","created_at":"2015-02-02T14:36:10Z","updated_at":"2017-06-16T15:28:21Z","pushed_at":"2017-09-17T19:01:59Z","git_url":"git://github.com/sambas/cleanflight.git","ssh_url":"git@github.com:sambas/cleanflight.git","clone_url":"https://github.com/sambas/cleanflight.git","svn_url":"https://github.com/sambas/cleanflight","homepage":"http://cleanflight.com","size":198731,"stargazers_count":15,"watchers_count":15,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":15,"default_branch":"master"}},"base":{"label":"betaflight:master","ref":"master","sha":"ce824a60d6f8d87c9fb7ef85f22c51c5aa4b0555","user":{"login":"betaflight","id":19597933,"avatar_url":"https://avatars1.githubusercontent.com/u/19597933?v=4","gravatar_id":"","url":"https://api.github.com/users/betaflight","html_url":"https://github.com/betaflight","followers_url":"https://api.github.com/users/betaflight/followers","following_url":"https://api.github.com/users/betaflight/following{/other_user}","gists_url":"https://api.github.com/users/betaflight/gists{/gist_id}","starred_url":"https://api.github.com/users/betaflight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/betaflight/subscriptions","organizations_url":"https://api.github.com/users/betaflight/orgs","repos_url":"https://api.github.com/users/betaflight/repos","events_url":"https://api.github.com/users/betaflight/events{/privacy}","received_events_url":"https://api.github.com/users/betaflight/received_events","type":"Organization","site_admin":false},"repo":{"id":37060852,"name":"betaflight","full_name":"betaflight/betaflight","owner":{"login":"betaflight","id":19597933,"avatar_url":"https://avatars1.githubusercontent.com/u/19597933?v=4","gravatar_id":"","url":"https://api.github.com/users/betaflight","html_url":"https://github.com/betaflight","followers_url":"https://api.github.com/users/betaflight/followers","following_url":"https://api.github.com/users/betaflight/following{/other_user}","gists_url":"https://api.github.com/users/betaflight/gists{/gist_id}","starred_url":"https://api.github.com/users/betaflight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/betaflight/subscriptions","organizations_url":"https://api.github.com/users/betaflight/orgs","repos_url":"https://api.github.com/users/betaflight/repos","events_url":"https://api.github.com/users/betaflight/events{/privacy}","received_events_url":"https://api.github.com/users/betaflight/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/betaflight/betaflight","description":null,"fork":true,"url":"https://api.github.com/repos/betaflight/betaflight","forks_url":"https://api.github.com/repos/betaflight/betaflight/forks","keys_url":"https://api.github.com/repos/betaflight/betaflight/keys{/key_id}","collaborators_url":"https://api.github.com/repos/betaflight/betaflight/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/betaflight/betaflight/teams","hooks_url":"https://api.github.com/repos/betaflight/betaflight/hooks","issue_events_url":"https://api.github.com/repos/betaflight/betaflight/issues/events{/number}","events_url":"https://api.github.com/repos/betaflight/betaflight/events","assignees_url":"https://api.github.com/repos/betaflight/betaflight/assignees{/user}","branches_url":"https://api.github.com/repos/betaflight/betaflight/branches{/branch}","tags_url":"https://api.github.com/repos/betaflight/betaflight/tags","blobs_url":"https://api.github.com/repos/betaflight/betaflight/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/betaflight/betaflight/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/betaflight/betaflight/git/refs{/sha}","trees_url":"https://api.github.com/repos/betaflight/betaflight/git/trees{/sha}","statuses_url":"https://api.github.com/repos/betaflight/betaflight/statuses/{sha}","languages_url":"https://api.github.com/repos/betaflight/betaflight/languages","stargazers_url":"https://api.github.com/repos/betaflight/betaflight/stargazers","contributors_url":"https://api.github.com/repos/betaflight/betaflight/contributors","subscribers_url":"https://api.github.com/repos/betaflight/betaflight/subscribers","subscription_url":"https://api.github.com/repos/betaflight/betaflight/subscription","commits_url":"https://api.github.com/repos/betaflight/betaflight/commits{/sha}","git_commits_url":"https://api.github.com/repos/betaflight/betaflight/git/commits{/sha}","comments_url":"https://api.github.com/repos/betaflight/betaflight/comments{/number}","issue_comment_url":"https://api.github.com/repos/betaflight/betaflight/issues/comments{/number}","contents_url":"https://api.github.com/repos/betaflight/betaflight/contents/{+path}","compare_url":"https://api.github.com/repos/betaflight/betaflight/compare/{base}...{head}","merges_url":"https://api.github.com/repos/betaflight/betaflight/merges","archive_url":"https://api.github.com/repos/betaflight/betaflight/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/betaflight/betaflight/downloads","issues_url":"https://api.github.com/repos/betaflight/betaflight/issues{/number}","pulls_url":"https://api.github.com/repos/betaflight/betaflight/pulls{/number}","milestones_url":"https://api.github.com/repos/betaflight/betaflight/milestones{/number}","notifications_url":"https://api.github.com/repos/betaflight/betaflight/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/betaflight/betaflight/labels{/name}","releases_url":"https://api.github.com/repos/betaflight/betaflight/releases{/id}","deployments_url":"https://api.github.com/repos/betaflight/betaflight/deployments","created_at":"2015-06-08T10:37:44Z","updated_at":"2017-09-17T08:28:33Z","pushed_at":"2017-09-18T10:21:27Z","git_url":"git://github.com/betaflight/betaflight.git","ssh_url":"git@github.com:betaflight/betaflight.git","clone_url":"https://github.com/betaflight/betaflight.git","svn_url":"https://github.com/betaflight/betaflight","homepage":"","size":182788,"stargazers_count":1226,"watchers_count":1226,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":540,"mirror_url":null,"open_issues_count":432,"forks":540,"open_issues":432,"watchers":1226,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/betaflight/betaflight/pulls/4165"},"html":{"href":"https://github.com/betaflight/betaflight/pull/4165"},"issue":{"href":"https://api.github.com/repos/betaflight/betaflight/issues/4165"},"comments":{"href":"https://api.github.com/repos/betaflight/betaflight/issues/4165/comments"},"review_comments":{"href":"https://api.github.com/repos/betaflight/betaflight/pulls/4165/comments"},"review_comment":{"href":"https://api.github.com/repos/betaflight/betaflight/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/betaflight/betaflight/pulls/4165/commits"},"statuses":{"href":"https://api.github.com/repos/betaflight/betaflight/statuses/274ed9e7065c898577821a834ebf9312c8a9a9d5"}},"author_association":"NONE"}}
{"actor":{"display_login":"ledvinap"}}