{"action":"created","issue":{"url":"https://api.github.com/repos/openaps/oref0/issues/742","repository_url":"https://api.github.com/repos/openaps/oref0","labels_url":"https://api.github.com/repos/openaps/oref0/issues/742/labels{/name}","comments_url":"https://api.github.com/repos/openaps/oref0/issues/742/comments","events_url":"https://api.github.com/repos/openaps/oref0/issues/742/events","html_url":"https://github.com/openaps/oref0/pull/742","id":267439032,"number":742,"title":"disable SMB if either avgDelta is >20%","user":{"login":"scottleibrand","id":6982790,"avatar_url":"https://avatars1.githubusercontent.com/u/6982790?v=4","gravatar_id":"","url":"https://api.github.com/users/scottleibrand","html_url":"https://github.com/scottleibrand","followers_url":"https://api.github.com/users/scottleibrand/followers","following_url":"https://api.github.com/users/scottleibrand/following{/other_user}","gists_url":"https://api.github.com/users/scottleibrand/gists{/gist_id}","starred_url":"https://api.github.com/users/scottleibrand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scottleibrand/subscriptions","organizations_url":"https://api.github.com/users/scottleibrand/orgs","repos_url":"https://api.github.com/users/scottleibrand/repos","events_url":"https://api.github.com/users/scottleibrand/events{/privacy}","received_events_url":"https://api.github.com/users/scottleibrand/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-10-22T06:06:42Z","updated_at":"2017-10-23T04:38:55Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/openaps/oref0/pulls/742","html_url":"https://github.com/openaps/oref0/pull/742","diff_url":"https://github.com/openaps/oref0/pull/742.diff","patch_url":"https://github.com/openaps/oref0/pull/742.patch"},"body":"When hot-swapping a sensor and looping off raw data, there is a very large initial jump in the reported raw BG value, which then quickly comes down and levels out at whatever level the new sensor is reading.  The current SMB safety check disallows SMBs on the initial jump, but allows them on subsequent readings (if IOB is low enough to warrant dosing off the high value despite the downtick).  To prevent SMBing off a falsely high reading, this change disallows SMBs if any of the delta, short_avgdelta, or long_avgdelta is > 20% of the current BG. "},"comment":{"url":"https://api.github.com/repos/openaps/oref0/issues/comments/338546022","html_url":"https://github.com/openaps/oref0/pull/742#issuecomment-338546022","issue_url":"https://api.github.com/repos/openaps/oref0/issues/742","id":338546022,"user":{"login":"tim2000s","id":14833174,"avatar_url":"https://avatars3.githubusercontent.com/u/14833174?v=4","gravatar_id":"","url":"https://api.github.com/users/tim2000s","html_url":"https://github.com/tim2000s","followers_url":"https://api.github.com/users/tim2000s/followers","following_url":"https://api.github.com/users/tim2000s/following{/other_user}","gists_url":"https://api.github.com/users/tim2000s/gists{/gist_id}","starred_url":"https://api.github.com/users/tim2000s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tim2000s/subscriptions","organizations_url":"https://api.github.com/users/tim2000s/orgs","repos_url":"https://api.github.com/users/tim2000s/repos","events_url":"https://api.github.com/users/tim2000s/events{/privacy}","received_events_url":"https://api.github.com/users/tim2000s/received_events","type":"User","site_admin":false},"created_at":"2017-10-23T04:38:55Z","updated_at":"2017-10-23T04:38:55Z","author_association":"CONTRIBUTOR","body":"If all you’ve done is change the configured threshold in determine-basal from 0.1 to 0.2*bg, then I hardwired the rig to do that in the previous dev version with no issues. "}}
{"actor":{"display_login":"tim2000s"}}