{"action":"created","comment":{"url":"https://api.github.com/repos/apache/kafka/pulls/comments/94432322","pull_request_review_id":14959437,"id":94432322,"diff_hunk":"@@ -456,6 +456,20 @@ public static String formatAddress(String host, Integer port) {\n         return sb.toString();\n     }\n \n+    public static <K, V> String join(Map<K, V> map,","path":"clients/src/main/java/org/apache/kafka/common/utils/Utils.java","position":4,"original_position":4,"commit_id":"408f785bee202f5a175186fe9abd37801e27c2b8","original_commit_id":"408f785bee202f5a175186fe9abd37801e27c2b8","user":{"login":"ijuma","id":24747,"avatar_url":"https://avatars.githubusercontent.com/u/24747?v=3","gravatar_id":"","url":"https://api.github.com/users/ijuma","html_url":"https://github.com/ijuma","followers_url":"https://api.github.com/users/ijuma/followers","following_url":"https://api.github.com/users/ijuma/following{/other_user}","gists_url":"https://api.github.com/users/ijuma/gists{/gist_id}","starred_url":"https://api.github.com/users/ijuma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ijuma/subscriptions","organizations_url":"https://api.github.com/users/ijuma/orgs","repos_url":"https://api.github.com/users/ijuma/repos","events_url":"https://api.github.com/users/ijuma/events{/privacy}","received_events_url":"https://api.github.com/users/ijuma/received_events","type":"User","site_admin":false},"body":"There is a `mkString` method in the same class so maybe we should use that name to be consistent. Or we could rename the other one to `join` (which is what the Java standard library uses).","created_at":"2017-01-03T16:15:18Z","updated_at":"2017-01-03T16:15:18Z","html_url":"https://github.com/apache/kafka/pull/2262#discussion_r94432322","pull_request_url":"https://api.github.com/repos/apache/kafka/pulls/2262","_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments/94432322"},"html":{"href":"https://github.com/apache/kafka/pull/2262#discussion_r94432322"},"pull_request":{"href":"https://api.github.com/repos/apache/kafka/pulls/2262"}}},"pull_request":{"url":"https://api.github.com/repos/apache/kafka/pulls/2262","id":98244999,"html_url":"https://github.com/apache/kafka/pull/2262","diff_url":"https://github.com/apache/kafka/pull/2262.diff","patch_url":"https://github.com/apache/kafka/pull/2262.patch","issue_url":"https://api.github.com/repos/apache/kafka/issues/2262","number":2262,"state":"open","locked":false,"title":"KAFKA-4548: Add CompatibilityTest to verify that individual features …","user":{"login":"cmccabe","id":1095624,"avatar_url":"https://avatars.githubusercontent.com/u/1095624?v=3","gravatar_id":"","url":"https://api.github.com/users/cmccabe","html_url":"https://github.com/cmccabe","followers_url":"https://api.github.com/users/cmccabe/followers","following_url":"https://api.github.com/users/cmccabe/following{/other_user}","gists_url":"https://api.github.com/users/cmccabe/gists{/gist_id}","starred_url":"https://api.github.com/users/cmccabe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmccabe/subscriptions","organizations_url":"https://api.github.com/users/cmccabe/orgs","repos_url":"https://api.github.com/users/cmccabe/repos","events_url":"https://api.github.com/users/cmccabe/events{/privacy}","received_events_url":"https://api.github.com/users/cmccabe/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-12-15T22:36:47Z","updated_at":"2017-01-03T16:15:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5971c61ad1043af79b4979bf3b37eebe90a60c46","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/kafka/pulls/2262/commits","review_comments_url":"https://api.github.com/repos/apache/kafka/pulls/2262/comments","review_comment_url":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/kafka/issues/2262/comments","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/408f785bee202f5a175186fe9abd37801e27c2b8","head":{"label":"cmccabe:KAFKA-4548","ref":"KAFKA-4548","sha":"408f785bee202f5a175186fe9abd37801e27c2b8","user":{"login":"cmccabe","id":1095624,"avatar_url":"https://avatars.githubusercontent.com/u/1095624?v=3","gravatar_id":"","url":"https://api.github.com/users/cmccabe","html_url":"https://github.com/cmccabe","followers_url":"https://api.github.com/users/cmccabe/followers","following_url":"https://api.github.com/users/cmccabe/following{/other_user}","gists_url":"https://api.github.com/users/cmccabe/gists{/gist_id}","starred_url":"https://api.github.com/users/cmccabe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmccabe/subscriptions","organizations_url":"https://api.github.com/users/cmccabe/orgs","repos_url":"https://api.github.com/users/cmccabe/repos","events_url":"https://api.github.com/users/cmccabe/events{/privacy}","received_events_url":"https://api.github.com/users/cmccabe/received_events","type":"User","site_admin":false},"repo":{"id":74628042,"name":"kafka","full_name":"cmccabe/kafka","owner":{"login":"cmccabe","id":1095624,"avatar_url":"https://avatars.githubusercontent.com/u/1095624?v=3","gravatar_id":"","url":"https://api.github.com/users/cmccabe","html_url":"https://github.com/cmccabe","followers_url":"https://api.github.com/users/cmccabe/followers","following_url":"https://api.github.com/users/cmccabe/following{/other_user}","gists_url":"https://api.github.com/users/cmccabe/gists{/gist_id}","starred_url":"https://api.github.com/users/cmccabe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmccabe/subscriptions","organizations_url":"https://api.github.com/users/cmccabe/orgs","repos_url":"https://api.github.com/users/cmccabe/repos","events_url":"https://api.github.com/users/cmccabe/events{/privacy}","received_events_url":"https://api.github.com/users/cmccabe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cmccabe/kafka","description":"Mirror of Apache Kafka","fork":true,"url":"https://api.github.com/repos/cmccabe/kafka","forks_url":"https://api.github.com/repos/cmccabe/kafka/forks","keys_url":"https://api.github.com/repos/cmccabe/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cmccabe/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cmccabe/kafka/teams","hooks_url":"https://api.github.com/repos/cmccabe/kafka/hooks","issue_events_url":"https://api.github.com/repos/cmccabe/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/cmccabe/kafka/events","assignees_url":"https://api.github.com/repos/cmccabe/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/cmccabe/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/cmccabe/kafka/tags","blobs_url":"https://api.github.com/repos/cmccabe/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cmccabe/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cmccabe/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/cmccabe/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cmccabe/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/cmccabe/kafka/languages","stargazers_url":"https://api.github.com/repos/cmccabe/kafka/stargazers","contributors_url":"https://api.github.com/repos/cmccabe/kafka/contributors","subscribers_url":"https://api.github.com/repos/cmccabe/kafka/subscribers","subscription_url":"https://api.github.com/repos/cmccabe/kafka/subscription","commits_url":"https://api.github.com/repos/cmccabe/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/cmccabe/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/cmccabe/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/cmccabe/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/cmccabe/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/cmccabe/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cmccabe/kafka/merges","archive_url":"https://api.github.com/repos/cmccabe/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cmccabe/kafka/downloads","issues_url":"https://api.github.com/repos/cmccabe/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/cmccabe/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/cmccabe/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/cmccabe/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cmccabe/kafka/labels{/name}","releases_url":"https://api.github.com/repos/cmccabe/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/cmccabe/kafka/deployments","created_at":"2016-11-24T01:40:33Z","updated_at":"2016-11-24T01:40:38Z","pushed_at":"2016-12-16T22:21:26Z","git_url":"git://github.com/cmccabe/kafka.git","ssh_url":"git@github.com:cmccabe/kafka.git","clone_url":"https://github.com/cmccabe/kafka.git","svn_url":"https://github.com/cmccabe/kafka","homepage":null,"size":37938,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"trunk"}},"base":{"label":"apache:trunk","ref":"trunk","sha":"908b6d1148df963d21a70aaa73a7a87571b965a9","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":2211243,"name":"kafka","full_name":"apache/kafka","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/kafka","description":"Mirror of Apache Kafka","fork":false,"url":"https://api.github.com/repos/apache/kafka","forks_url":"https://api.github.com/repos/apache/kafka/forks","keys_url":"https://api.github.com/repos/apache/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/kafka/teams","hooks_url":"https://api.github.com/repos/apache/kafka/hooks","issue_events_url":"https://api.github.com/repos/apache/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/apache/kafka/events","assignees_url":"https://api.github.com/repos/apache/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/apache/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/apache/kafka/tags","blobs_url":"https://api.github.com/repos/apache/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/kafka/languages","stargazers_url":"https://api.github.com/repos/apache/kafka/stargazers","contributors_url":"https://api.github.com/repos/apache/kafka/contributors","subscribers_url":"https://api.github.com/repos/apache/kafka/subscribers","subscription_url":"https://api.github.com/repos/apache/kafka/subscription","commits_url":"https://api.github.com/repos/apache/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/apache/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/kafka/merges","archive_url":"https://api.github.com/repos/apache/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/kafka/downloads","issues_url":"https://api.github.com/repos/apache/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/apache/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/kafka/labels{/name}","releases_url":"https://api.github.com/repos/apache/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/apache/kafka/deployments","created_at":"2011-08-15T18:06:16Z","updated_at":"2017-01-03T14:05:17Z","pushed_at":"2017-01-03T16:08:14Z","git_url":"git://github.com/apache/kafka.git","ssh_url":"git@github.com:apache/kafka.git","clone_url":"https://github.com/apache/kafka.git","svn_url":"https://github.com/apache/kafka","homepage":null,"size":38298,"stargazers_count":4371,"watchers_count":4371,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2702,"mirror_url":"git://git.apache.org/kafka.git","open_issues_count":268,"forks":2702,"open_issues":268,"watchers":4371,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/2262"},"html":{"href":"https://github.com/apache/kafka/pull/2262"},"issue":{"href":"https://api.github.com/repos/apache/kafka/issues/2262"},"comments":{"href":"https://api.github.com/repos/apache/kafka/issues/2262/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/kafka/pulls/2262/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/kafka/pulls/2262/commits"},"statuses":{"href":"https://api.github.com/repos/apache/kafka/statuses/408f785bee202f5a175186fe9abd37801e27c2b8"}}}}
{"actor":{"display_login":"ijuma"}}