{"action":"opened","issue":{"url":"https://api.github.com/repos/PowerShell/xNetworking/issues/264","repository_url":"https://api.github.com/repos/PowerShell/xNetworking","labels_url":"https://api.github.com/repos/PowerShell/xNetworking/issues/264/labels{/name}","comments_url":"https://api.github.com/repos/PowerShell/xNetworking/issues/264/comments","events_url":"https://api.github.com/repos/PowerShell/xNetworking/issues/264/events","html_url":"https://github.com/PowerShell/xNetworking/issues/264","id":254755211,"number":264,"title":"Fix Failing Tests due to changes in DSCResource.Tests","user":{"login":"PlagueHO","id":7589164,"avatar_url":"https://avatars2.githubusercontent.com/u/7589164?v=4","gravatar_id":"","url":"https://api.github.com/users/PlagueHO","html_url":"https://github.com/PlagueHO","followers_url":"https://api.github.com/users/PlagueHO/followers","following_url":"https://api.github.com/users/PlagueHO/following{/other_user}","gists_url":"https://api.github.com/users/PlagueHO/gists{/gist_id}","starred_url":"https://api.github.com/users/PlagueHO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PlagueHO/subscriptions","organizations_url":"https://api.github.com/users/PlagueHO/orgs","repos_url":"https://api.github.com/users/PlagueHO/repos","events_url":"https://api.github.com/users/PlagueHO/events{/privacy}","received_events_url":"https://api.github.com/users/PlagueHO/received_events","type":"User","site_admin":false},"labels":[{"id":200151915,"url":"https://api.github.com/repos/PowerShell/xNetworking/labels/bug","name":"bug","color":"fc2929","default":true},{"id":204944471,"url":"https://api.github.com/repos/PowerShell/xNetworking/labels/in%20progress","name":"in progress","color":"99ffcc","default":false}],"state":"open","locked":false,"assignee":{"login":"PlagueHO","id":7589164,"avatar_url":"https://avatars2.githubusercontent.com/u/7589164?v=4","gravatar_id":"","url":"https://api.github.com/users/PlagueHO","html_url":"https://github.com/PlagueHO","followers_url":"https://api.github.com/users/PlagueHO/followers","following_url":"https://api.github.com/users/PlagueHO/following{/other_user}","gists_url":"https://api.github.com/users/PlagueHO/gists{/gist_id}","starred_url":"https://api.github.com/users/PlagueHO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PlagueHO/subscriptions","organizations_url":"https://api.github.com/users/PlagueHO/orgs","repos_url":"https://api.github.com/users/PlagueHO/repos","events_url":"https://api.github.com/users/PlagueHO/events{/privacy}","received_events_url":"https://api.github.com/users/PlagueHO/received_events","type":"User","site_admin":false},"assignees":[{"login":"PlagueHO","id":7589164,"avatar_url":"https://avatars2.githubusercontent.com/u/7589164?v=4","gravatar_id":"","url":"https://api.github.com/users/PlagueHO","html_url":"https://github.com/PlagueHO","followers_url":"https://api.github.com/users/PlagueHO/followers","following_url":"https://api.github.com/users/PlagueHO/following{/other_user}","gists_url":"https://api.github.com/users/PlagueHO/gists{/gist_id}","starred_url":"https://api.github.com/users/PlagueHO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PlagueHO/subscriptions","organizations_url":"https://api.github.com/users/PlagueHO/orgs","repos_url":"https://api.github.com/users/PlagueHO/repos","events_url":"https://api.github.com/users/PlagueHO/events{/privacy}","received_events_url":"https://api.github.com/users/PlagueHO/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2017-09-01T21:25:25Z","updated_at":"2017-09-01T21:25:25Z","closed_at":null,"author_association":"COLLABORATOR","body":"A recent change in DSCResource.Tests (https://github.com/PowerShell/DscResource.Tests/pull/186) caused the unit tests for the DSCResource.Tests module itself to be executed during the test run in this module.\r\n\r\nFor non-harness type modules this is being fixed in DSCResource.Tests itself, but for harness type, this must be fixed using this suggested change:\r\nhttps://github.com/PowerShell/xNetworking/pull/263#issuecomment-326367362\r\n\r\nIf you replace these rows\r\n\r\nhttps://github.com/PowerShell/xNetworking/blob/0a99574386a0f1d9596ea587d2a6131b55727c8f/Tests/TestHarness.psm1#L42-L45\r\n\r\nWith these rows, it will not run the test that is failing \r\n\r\n```powershell\r\n    if ($PSBoundParameters.ContainsKey('DscTestsPath') -eq $true)\r\n    {\r\n        $getChildItemParameters = @{\r\n            Path = $DscTestsPath\r\n            Recurse = $true\r\n            Filter = '*.Tests.ps1'\r\n        }\r\n\r\n        # Get all tests '*.Tests.ps1'.\r\n        $commonTestFiles = Get-ChildItem @getChildItemParameters\r\n\r\n        # Remove DscResource.Tests unit and integration tests.\r\n        $commonTestFiles = $commonTestFiles | Where-Object -FilterScript {\r\n            $_.FullName -notmatch 'DSCResource.Tests\\\\Tests'\r\n        }\r\n\r\n        $testsToRun += @( $commonTestFiles.FullName )\r\n    }\r\n```\r\n"}}
{"actor":{"display_login":"PlagueHO"}}