{"action":"opened","number":1445,"pull_request":{"url":"https://api.github.com/repos/jasmine/jasmine/pulls/1445","id":149932381,"html_url":"https://github.com/jasmine/jasmine/pull/1445","diff_url":"https://github.com/jasmine/jasmine/pull/1445.diff","patch_url":"https://github.com/jasmine/jasmine/pull/1445.patch","issue_url":"https://api.github.com/repos/jasmine/jasmine/issues/1445","number":1445,"state":"open","locked":false,"title":"Fix equality computation for ES6 Sets.","user":{"login":"b-3-n","id":7460509,"avatar_url":"https://avatars2.githubusercontent.com/u/7460509?v=4","gravatar_id":"","url":"https://api.github.com/users/b-3-n","html_url":"https://github.com/b-3-n","followers_url":"https://api.github.com/users/b-3-n/followers","following_url":"https://api.github.com/users/b-3-n/following{/other_user}","gists_url":"https://api.github.com/users/b-3-n/gists{/gist_id}","starred_url":"https://api.github.com/users/b-3-n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/b-3-n/subscriptions","organizations_url":"https://api.github.com/users/b-3-n/orgs","repos_url":"https://api.github.com/users/b-3-n/repos","events_url":"https://api.github.com/users/b-3-n/events{/privacy}","received_events_url":"https://api.github.com/users/b-3-n/received_events","type":"User","site_admin":false},"body":"Provides a fix for https://github.com/jasmine/jasmine/issues/1444\r\n\r\nThe underlying problem is that the eq function does not pop stackA and stackB in the case of inequality being determined. This might be desirable for performance but requires callers to take care of this case. In particular the Set equality is currently determined by comparing all elements of the first with all elements of the second set (and vice versa). Obviously there can be failed comparisons without the two sets being necessarily different. In these cases we must pop the stacks.\r\n\r\nI did not look at the ES6 Map equality code but probably it suffers from the same problem.","created_at":"2017-10-31T23:35:43Z","updated_at":"2017-10-31T23:35:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/jasmine/jasmine/pulls/1445/commits","review_comments_url":"https://api.github.com/repos/jasmine/jasmine/pulls/1445/comments","review_comment_url":"https://api.github.com/repos/jasmine/jasmine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jasmine/jasmine/issues/1445/comments","statuses_url":"https://api.github.com/repos/jasmine/jasmine/statuses/d92de0cec6e43093c7ab36470caf00da27601e30","head":{"label":"b-3-n:master","ref":"master","sha":"d92de0cec6e43093c7ab36470caf00da27601e30","user":{"login":"b-3-n","id":7460509,"avatar_url":"https://avatars2.githubusercontent.com/u/7460509?v=4","gravatar_id":"","url":"https://api.github.com/users/b-3-n","html_url":"https://github.com/b-3-n","followers_url":"https://api.github.com/users/b-3-n/followers","following_url":"https://api.github.com/users/b-3-n/following{/other_user}","gists_url":"https://api.github.com/users/b-3-n/gists{/gist_id}","starred_url":"https://api.github.com/users/b-3-n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/b-3-n/subscriptions","organizations_url":"https://api.github.com/users/b-3-n/orgs","repos_url":"https://api.github.com/users/b-3-n/repos","events_url":"https://api.github.com/users/b-3-n/events{/privacy}","received_events_url":"https://api.github.com/users/b-3-n/received_events","type":"User","site_admin":false},"repo":{"id":109061399,"name":"jasmine","full_name":"b-3-n/jasmine","owner":{"login":"b-3-n","id":7460509,"avatar_url":"https://avatars2.githubusercontent.com/u/7460509?v=4","gravatar_id":"","url":"https://api.github.com/users/b-3-n","html_url":"https://github.com/b-3-n","followers_url":"https://api.github.com/users/b-3-n/followers","following_url":"https://api.github.com/users/b-3-n/following{/other_user}","gists_url":"https://api.github.com/users/b-3-n/gists{/gist_id}","starred_url":"https://api.github.com/users/b-3-n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/b-3-n/subscriptions","organizations_url":"https://api.github.com/users/b-3-n/orgs","repos_url":"https://api.github.com/users/b-3-n/repos","events_url":"https://api.github.com/users/b-3-n/events{/privacy}","received_events_url":"https://api.github.com/users/b-3-n/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/b-3-n/jasmine","description":"Simple JavaScript testing framework for browsers and node.js","fork":true,"url":"https://api.github.com/repos/b-3-n/jasmine","forks_url":"https://api.github.com/repos/b-3-n/jasmine/forks","keys_url":"https://api.github.com/repos/b-3-n/jasmine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/b-3-n/jasmine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/b-3-n/jasmine/teams","hooks_url":"https://api.github.com/repos/b-3-n/jasmine/hooks","issue_events_url":"https://api.github.com/repos/b-3-n/jasmine/issues/events{/number}","events_url":"https://api.github.com/repos/b-3-n/jasmine/events","assignees_url":"https://api.github.com/repos/b-3-n/jasmine/assignees{/user}","branches_url":"https://api.github.com/repos/b-3-n/jasmine/branches{/branch}","tags_url":"https://api.github.com/repos/b-3-n/jasmine/tags","blobs_url":"https://api.github.com/repos/b-3-n/jasmine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/b-3-n/jasmine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/b-3-n/jasmine/git/refs{/sha}","trees_url":"https://api.github.com/repos/b-3-n/jasmine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/b-3-n/jasmine/statuses/{sha}","languages_url":"https://api.github.com/repos/b-3-n/jasmine/languages","stargazers_url":"https://api.github.com/repos/b-3-n/jasmine/stargazers","contributors_url":"https://api.github.com/repos/b-3-n/jasmine/contributors","subscribers_url":"https://api.github.com/repos/b-3-n/jasmine/subscribers","subscription_url":"https://api.github.com/repos/b-3-n/jasmine/subscription","commits_url":"https://api.github.com/repos/b-3-n/jasmine/commits{/sha}","git_commits_url":"https://api.github.com/repos/b-3-n/jasmine/git/commits{/sha}","comments_url":"https://api.github.com/repos/b-3-n/jasmine/comments{/number}","issue_comment_url":"https://api.github.com/repos/b-3-n/jasmine/issues/comments{/number}","contents_url":"https://api.github.com/repos/b-3-n/jasmine/contents/{+path}","compare_url":"https://api.github.com/repos/b-3-n/jasmine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/b-3-n/jasmine/merges","archive_url":"https://api.github.com/repos/b-3-n/jasmine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/b-3-n/jasmine/downloads","issues_url":"https://api.github.com/repos/b-3-n/jasmine/issues{/number}","pulls_url":"https://api.github.com/repos/b-3-n/jasmine/pulls{/number}","milestones_url":"https://api.github.com/repos/b-3-n/jasmine/milestones{/number}","notifications_url":"https://api.github.com/repos/b-3-n/jasmine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/b-3-n/jasmine/labels{/name}","releases_url":"https://api.github.com/repos/b-3-n/jasmine/releases{/id}","deployments_url":"https://api.github.com/repos/b-3-n/jasmine/deployments","created_at":"2017-10-31T23:04:07Z","updated_at":"2017-10-31T23:04:10Z","pushed_at":"2017-10-31T23:25:16Z","git_url":"git://github.com/b-3-n/jasmine.git","ssh_url":"git@github.com:b-3-n/jasmine.git","clone_url":"https://github.com/b-3-n/jasmine.git","svn_url":"https://github.com/b-3-n/jasmine","homepage":"http://jasmine.github.io/","size":7942,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jasmine:master","ref":"master","sha":"554d0efab75758e3babe9b8b38eb2390ef7dfaf4","user":{"login":"jasmine","id":4624349,"avatar_url":"https://avatars0.githubusercontent.com/u/4624349?v=4","gravatar_id":"","url":"https://api.github.com/users/jasmine","html_url":"https://github.com/jasmine","followers_url":"https://api.github.com/users/jasmine/followers","following_url":"https://api.github.com/users/jasmine/following{/other_user}","gists_url":"https://api.github.com/users/jasmine/gists{/gist_id}","starred_url":"https://api.github.com/users/jasmine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasmine/subscriptions","organizations_url":"https://api.github.com/users/jasmine/orgs","repos_url":"https://api.github.com/users/jasmine/repos","events_url":"https://api.github.com/users/jasmine/events{/privacy}","received_events_url":"https://api.github.com/users/jasmine/received_events","type":"Organization","site_admin":false},"repo":{"id":84009,"name":"jasmine","full_name":"jasmine/jasmine","owner":{"login":"jasmine","id":4624349,"avatar_url":"https://avatars0.githubusercontent.com/u/4624349?v=4","gravatar_id":"","url":"https://api.github.com/users/jasmine","html_url":"https://github.com/jasmine","followers_url":"https://api.github.com/users/jasmine/followers","following_url":"https://api.github.com/users/jasmine/following{/other_user}","gists_url":"https://api.github.com/users/jasmine/gists{/gist_id}","starred_url":"https://api.github.com/users/jasmine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasmine/subscriptions","organizations_url":"https://api.github.com/users/jasmine/orgs","repos_url":"https://api.github.com/users/jasmine/repos","events_url":"https://api.github.com/users/jasmine/events{/privacy}","received_events_url":"https://api.github.com/users/jasmine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jasmine/jasmine","description":"Simple JavaScript testing framework for browsers and node.js","fork":false,"url":"https://api.github.com/repos/jasmine/jasmine","forks_url":"https://api.github.com/repos/jasmine/jasmine/forks","keys_url":"https://api.github.com/repos/jasmine/jasmine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jasmine/jasmine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jasmine/jasmine/teams","hooks_url":"https://api.github.com/repos/jasmine/jasmine/hooks","issue_events_url":"https://api.github.com/repos/jasmine/jasmine/issues/events{/number}","events_url":"https://api.github.com/repos/jasmine/jasmine/events","assignees_url":"https://api.github.com/repos/jasmine/jasmine/assignees{/user}","branches_url":"https://api.github.com/repos/jasmine/jasmine/branches{/branch}","tags_url":"https://api.github.com/repos/jasmine/jasmine/tags","blobs_url":"https://api.github.com/repos/jasmine/jasmine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jasmine/jasmine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jasmine/jasmine/git/refs{/sha}","trees_url":"https://api.github.com/repos/jasmine/jasmine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jasmine/jasmine/statuses/{sha}","languages_url":"https://api.github.com/repos/jasmine/jasmine/languages","stargazers_url":"https://api.github.com/repos/jasmine/jasmine/stargazers","contributors_url":"https://api.github.com/repos/jasmine/jasmine/contributors","subscribers_url":"https://api.github.com/repos/jasmine/jasmine/subscribers","subscription_url":"https://api.github.com/repos/jasmine/jasmine/subscription","commits_url":"https://api.github.com/repos/jasmine/jasmine/commits{/sha}","git_commits_url":"https://api.github.com/repos/jasmine/jasmine/git/commits{/sha}","comments_url":"https://api.github.com/repos/jasmine/jasmine/comments{/number}","issue_comment_url":"https://api.github.com/repos/jasmine/jasmine/issues/comments{/number}","contents_url":"https://api.github.com/repos/jasmine/jasmine/contents/{+path}","compare_url":"https://api.github.com/repos/jasmine/jasmine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jasmine/jasmine/merges","archive_url":"https://api.github.com/repos/jasmine/jasmine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jasmine/jasmine/downloads","issues_url":"https://api.github.com/repos/jasmine/jasmine/issues{/number}","pulls_url":"https://api.github.com/repos/jasmine/jasmine/pulls{/number}","milestones_url":"https://api.github.com/repos/jasmine/jasmine/milestones{/number}","notifications_url":"https://api.github.com/repos/jasmine/jasmine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jasmine/jasmine/labels{/name}","releases_url":"https://api.github.com/repos/jasmine/jasmine/releases{/id}","deployments_url":"https://api.github.com/repos/jasmine/jasmine/deployments","created_at":"2008-12-02T23:46:37Z","updated_at":"2017-10-31T22:14:21Z","pushed_at":"2017-10-31T20:21:10Z","git_url":"git://github.com/jasmine/jasmine.git","ssh_url":"git@github.com:jasmine/jasmine.git","clone_url":"https://github.com/jasmine/jasmine.git","svn_url":"https://github.com/jasmine/jasmine","homepage":"http://jasmine.github.io/","size":7942,"stargazers_count":12969,"watchers_count":12969,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1943,"mirror_url":null,"archived":false,"open_issues_count":43,"forks":1943,"open_issues":43,"watchers":12969,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jasmine/jasmine/pulls/1445"},"html":{"href":"https://github.com/jasmine/jasmine/pull/1445"},"issue":{"href":"https://api.github.com/repos/jasmine/jasmine/issues/1445"},"comments":{"href":"https://api.github.com/repos/jasmine/jasmine/issues/1445/comments"},"review_comments":{"href":"https://api.github.com/repos/jasmine/jasmine/pulls/1445/comments"},"review_comment":{"href":"https://api.github.com/repos/jasmine/jasmine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jasmine/jasmine/pulls/1445/commits"},"statuses":{"href":"https://api.github.com/repos/jasmine/jasmine/statuses/d92de0cec6e43093c7ab36470caf00da27601e30"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":25,"deletions":6,"changed_files":2}}
{"actor":{"display_login":"b-3-n"}}