{"action":"created","issue":{"url":"https://api.github.com/repos/LeafyCode/express-firebase-auth/issues/1","repository_url":"https://api.github.com/repos/LeafyCode/express-firebase-auth","labels_url":"https://api.github.com/repos/LeafyCode/express-firebase-auth/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/LeafyCode/express-firebase-auth/issues/1/comments","events_url":"https://api.github.com/repos/LeafyCode/express-firebase-auth/issues/1/events","html_url":"https://github.com/LeafyCode/express-firebase-auth/issues/1","id":262101126,"number":1,"title":"Additional features and improvements?","user":{"login":"nicolasgarnier","id":3766663,"avatar_url":"https://avatars1.githubusercontent.com/u/3766663?v=4","gravatar_id":"","url":"https://api.github.com/users/nicolasgarnier","html_url":"https://github.com/nicolasgarnier","followers_url":"https://api.github.com/users/nicolasgarnier/followers","following_url":"https://api.github.com/users/nicolasgarnier/following{/other_user}","gists_url":"https://api.github.com/users/nicolasgarnier/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolasgarnier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolasgarnier/subscriptions","organizations_url":"https://api.github.com/users/nicolasgarnier/orgs","repos_url":"https://api.github.com/users/nicolasgarnier/repos","events_url":"https://api.github.com/users/nicolasgarnier/events{/privacy}","received_events_url":"https://api.github.com/users/nicolasgarnier/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-10-02T14:19:43Z","updated_at":"2017-10-05T08:15:38Z","closed_at":"2017-10-05T08:15:38Z","author_association":"NONE","body":"Hey @THPubs !\r\n\r\nI'm Nicolas and I work on the Firebase team.\r\n\r\nI just noticed your middleware. It's nice work! :)\r\n\r\nI was wondering if you would be willing to implement additional features? I was about to release a Firebase Middleware myself but we'd rather build on top of the community's work if it exists :)\r\n\r\nHere is the improvements that would be awesome:\r\n - [ ] Allowing The ID Token to be passed in Cookies too (rather than just auth headers).\r\n - [ ] Configurable Cookies names.\r\n - [ ] Requires the keyword `Bearer` in the Authentication header since that's more consistent with ID Token authentication specs.\r\n - [ ] If no Service accounts file is passed then instantiate a Firebase admin instance using the default app credentials (available in Google Cloud Environment) automatically.\r\n - [ ] Option to generate Custom auth tokens for the authenticated User.\r\n\r\nI have implemented all these features in this file: https://github.com/nicolasgarnier/friendlypix-web-react/blob/master/microservices/firebase-express-middleware.js feel free to check it out!\r\n\r\nWould you be willing to implement these or opened to contribution for me (I could send a Pull Request with this code)? \r\n\r\nI'd like to use these in some blog post/article I will write up later on and in some official Firebase sample which is why I'm looking for all these features :)\r\n\r\nCheers!"},"comment":{"url":"https://api.github.com/repos/LeafyCode/express-firebase-auth/issues/comments/334392452","html_url":"https://github.com/LeafyCode/express-firebase-auth/issues/1#issuecomment-334392452","issue_url":"https://api.github.com/repos/LeafyCode/express-firebase-auth/issues/1","id":334392452,"user":{"login":"nicolasgarnier","id":3766663,"avatar_url":"https://avatars1.githubusercontent.com/u/3766663?v=4","gravatar_id":"","url":"https://api.github.com/users/nicolasgarnier","html_url":"https://github.com/nicolasgarnier","followers_url":"https://api.github.com/users/nicolasgarnier/followers","following_url":"https://api.github.com/users/nicolasgarnier/following{/other_user}","gists_url":"https://api.github.com/users/nicolasgarnier/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolasgarnier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolasgarnier/subscriptions","organizations_url":"https://api.github.com/users/nicolasgarnier/orgs","repos_url":"https://api.github.com/users/nicolasgarnier/repos","events_url":"https://api.github.com/users/nicolasgarnier/events{/privacy}","received_events_url":"https://api.github.com/users/nicolasgarnier/received_events","type":"User","site_admin":false},"created_at":"2017-10-05T08:15:37Z","updated_at":"2017-10-05T08:15:37Z","author_association":"NONE","body":"Reached out to you by email instead"}}
{"actor":{"display_login":"nicolasgarnier"}}