{"action":"closed","number":89,"pull_request":{"url":"https://api.github.com/repos/zignd/HTML-CSS-Class-Completion/pulls/89","id":146220950,"html_url":"https://github.com/zignd/HTML-CSS-Class-Completion/pull/89","diff_url":"https://github.com/zignd/HTML-CSS-Class-Completion/pull/89.diff","patch_url":"https://github.com/zignd/HTML-CSS-Class-Completion/pull/89.patch","issue_url":"https://api.github.com/repos/zignd/HTML-CSS-Class-Completion/issues/89","number":89,"state":"closed","locked":false,"title":"Exclude npm_modules when fetching files to index","user":{"login":"egamma","id":172399,"avatar_url":"https://avatars1.githubusercontent.com/u/172399?v=4","gravatar_id":"","url":"https://api.github.com/users/egamma","html_url":"https://github.com/egamma","followers_url":"https://api.github.com/users/egamma/followers","following_url":"https://api.github.com/users/egamma/following{/other_user}","gists_url":"https://api.github.com/users/egamma/gists{/gist_id}","starred_url":"https://api.github.com/users/egamma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/egamma/subscriptions","organizations_url":"https://api.github.com/users/egamma/orgs","repos_url":"https://api.github.com/users/egamma/repos","events_url":"https://api.github.com/users/egamma/events{/privacy}","received_events_url":"https://api.github.com/users/egamma/received_events","type":"User","site_admin":false},"body":"Hi, I'm a member of the VS Code team. In 1.17 we have unintentionally changed the behavior of `workspace.findFiles`. In 1.16 it was hard coded to exclude the node_modules from searching. In 1.17 this is no longer the case. Not excluding the node_modules folder can have a huge impact on startup performance in a large workspace. It will also result in polluting the problems view with many errors/warnings.\r\n\r\nThe PR changes the fetcher to explicitly exclude the node_modules. ","created_at":"2017-10-12T14:15:32Z","updated_at":"2017-10-12T14:38:38Z","closed_at":"2017-10-12T14:38:38Z","merged_at":"2017-10-12T14:38:38Z","merge_commit_sha":"db978bf338144bee8d784877ffa78190b4a31660","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/zignd/HTML-CSS-Class-Completion/pulls/89/commits","review_comments_url":"https://api.github.com/repos/zignd/HTML-CSS-Class-Completion/pulls/89/comments","review_comment_url":"https://api.github.com/repos/zignd/HTML-CSS-Class-Completion/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zignd/HTML-CSS-Class-Completion/issues/89/comments","statuses_url":"https://api.github.com/repos/zignd/HTML-CSS-Class-Completion/statuses/a5f366f357bcc424852f2c6ee209720cc70bdc5a","head":{"label":"egamma:master","ref":"master","sha":"a5f366f357bcc424852f2c6ee209720cc70bdc5a","user":{"login":"egamma","id":172399,"avatar_url":"https://avatars1.githubusercontent.com/u/172399?v=4","gravatar_id":"","url":"https://api.github.com/users/egamma","html_url":"https://github.com/egamma","followers_url":"https://api.github.com/users/egamma/followers","following_url":"https://api.github.com/users/egamma/following{/other_user}","gists_url":"https://api.github.com/users/egamma/gists{/gist_id}","starred_url":"https://api.github.com/users/egamma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/egamma/subscriptions","organizations_url":"https://api.github.com/users/egamma/orgs","repos_url":"https://api.github.com/users/egamma/repos","events_url":"https://api.github.com/users/egamma/events{/privacy}","received_events_url":"https://api.github.com/users/egamma/received_events","type":"User","site_admin":false},"repo":{"id":106700658,"name":"HTML-CSS-Class-Completion","full_name":"egamma/HTML-CSS-Class-Completion","owner":{"login":"egamma","id":172399,"avatar_url":"https://avatars1.githubusercontent.com/u/172399?v=4","gravatar_id":"","url":"https://api.github.com/users/egamma","html_url":"https://github.com/egamma","followers_url":"https://api.github.com/users/egamma/followers","following_url":"https://api.github.com/users/egamma/following{/other_user}","gists_url":"https://api.github.com/users/egamma/gists{/gist_id}","starred_url":"https://api.github.com/users/egamma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/egamma/subscriptions","organizations_url":"https://api.github.com/users/egamma/orgs","repos_url":"https://api.github.com/users/egamma/repos","events_url":"https://api.github.com/users/egamma/events{/privacy}","received_events_url":"https://api.github.com/users/egamma/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/egamma/HTML-CSS-Class-Completion","description":"A Visual Studio Code extension that provides CSS class name completion for the HTML class attribute based on the CSS files in your workspace. Also supports React's className attribute.","fork":true,"url":"https://api.github.com/repos/egamma/HTML-CSS-Class-Completion","forks_url":"https://api.github.com/repos/egamma/HTML-CSS-Class-Completion/forks","keys_url":"https://api.github.com/repos/egamma/HTML-CSS-Class-Completion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/egamma/HTML-CSS-Class-Completion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/egamma/HTML-CSS-Class-Completion/teams","hooks_url":"https://api.github.com/repos/egamma/HTML-CSS-Class-Completion/hooks","issue_events_url":"https://api.github.com/repos/egamma/HTML-CSS-Class-Completion/issues/events{/number}","events_url":"https://api.github.com/repos/egamma/HTML-CSS-Class-Completion/events","assignees_url":"https://api.github.com/repos/egamma/HTML-CSS-Class-Completion/assignees{/user}","branches_url":"https://api.github.com/repos/egamma/HTML-CSS-Class-Completion/branches{/branch}","tags_url":"https://api.github.com/repos/egamma/HTML-CSS-Class-Completion/tags","blobs_url":"https://api.github.com/repos/egamma/HTML-CSS-Class-Completion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/egamma/HTML-CSS-Class-Completion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/egamma/HTML-CSS-Class-Completion/git/refs{/sha}","trees_url":"https://api.github.com/repos/egamma/HTML-CSS-Class-Completion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/egamma/HTML-CSS-Class-Completion/statuses/{sha}","languages_url":"https://api.github.com/repos/egamma/HTML-CSS-Class-Completion/languages","stargazers_url":"https://api.github.com/repos/egamma/HTML-CSS-Class-Completion/stargazers","contributors_url":"https://api.github.com/repos/egamma/HTML-CSS-Class-Completion/contributors","subscribers_url":"https://api.github.com/repos/egamma/HTML-CSS-Class-Completion/subscribers","subscription_url":"https://api.github.com/repos/egamma/HTML-CSS-Class-Completion/subscription","commits_url":"https://api.github.com/repos/egamma/HTML-CSS-Class-Completion/commits{/sha}","git_commits_url":"https://api.github.com/repos/egamma/HTML-CSS-Class-Completion/git/commits{/sha}","comments_url":"https://api.github.com/repos/egamma/HTML-CSS-Class-Completion/comments{/number}","issue_comment_url":"https://api.github.com/repos/egamma/HTML-CSS-Class-Completion/issues/comments{/number}","contents_url":"https://api.github.com/repos/egamma/HTML-CSS-Class-Completion/contents/{+path}","compare_url":"https://api.github.com/repos/egamma/HTML-CSS-Class-Completion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/egamma/HTML-CSS-Class-Completion/merges","archive_url":"https://api.github.com/repos/egamma/HTML-CSS-Class-Completion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/egamma/HTML-CSS-Class-Completion/downloads","issues_url":"https://api.github.com/repos/egamma/HTML-CSS-Class-Completion/issues{/number}","pulls_url":"https://api.github.com/repos/egamma/HTML-CSS-Class-Completion/pulls{/number}","milestones_url":"https://api.github.com/repos/egamma/HTML-CSS-Class-Completion/milestones{/number}","notifications_url":"https://api.github.com/repos/egamma/HTML-CSS-Class-Completion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/egamma/HTML-CSS-Class-Completion/labels{/name}","releases_url":"https://api.github.com/repos/egamma/HTML-CSS-Class-Completion/releases{/id}","deployments_url":"https://api.github.com/repos/egamma/HTML-CSS-Class-Completion/deployments","created_at":"2017-10-12T14:03:59Z","updated_at":"2017-10-12T14:04:01Z","pushed_at":"2017-10-12T14:10:11Z","git_url":"git://github.com/egamma/HTML-CSS-Class-Completion.git","ssh_url":"git@github.com:egamma/HTML-CSS-Class-Completion.git","clone_url":"https://github.com/egamma/HTML-CSS-Class-Completion.git","svn_url":"https://github.com/egamma/HTML-CSS-Class-Completion","homepage":"https://marketplace.visualstudio.com/items?itemName=Zignd.html-css-class-completion","size":141,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zignd:master","ref":"master","sha":"7ad94443cabf9c61b4376941fb3bf182a3df4103","user":{"login":"zignd","id":3194806,"avatar_url":"https://avatars2.githubusercontent.com/u/3194806?v=4","gravatar_id":"","url":"https://api.github.com/users/zignd","html_url":"https://github.com/zignd","followers_url":"https://api.github.com/users/zignd/followers","following_url":"https://api.github.com/users/zignd/following{/other_user}","gists_url":"https://api.github.com/users/zignd/gists{/gist_id}","starred_url":"https://api.github.com/users/zignd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zignd/subscriptions","organizations_url":"https://api.github.com/users/zignd/orgs","repos_url":"https://api.github.com/users/zignd/repos","events_url":"https://api.github.com/users/zignd/events{/privacy}","received_events_url":"https://api.github.com/users/zignd/received_events","type":"User","site_admin":false},"repo":{"id":50760184,"name":"HTML-CSS-Class-Completion","full_name":"zignd/HTML-CSS-Class-Completion","owner":{"login":"zignd","id":3194806,"avatar_url":"https://avatars2.githubusercontent.com/u/3194806?v=4","gravatar_id":"","url":"https://api.github.com/users/zignd","html_url":"https://github.com/zignd","followers_url":"https://api.github.com/users/zignd/followers","following_url":"https://api.github.com/users/zignd/following{/other_user}","gists_url":"https://api.github.com/users/zignd/gists{/gist_id}","starred_url":"https://api.github.com/users/zignd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zignd/subscriptions","organizations_url":"https://api.github.com/users/zignd/orgs","repos_url":"https://api.github.com/users/zignd/repos","events_url":"https://api.github.com/users/zignd/events{/privacy}","received_events_url":"https://api.github.com/users/zignd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zignd/HTML-CSS-Class-Completion","description":"A Visual Studio Code extension that provides CSS class name completion for the HTML class attribute based on the CSS files in your workspace. Also supports React's className attribute.","fork":false,"url":"https://api.github.com/repos/zignd/HTML-CSS-Class-Completion","forks_url":"https://api.github.com/repos/zignd/HTML-CSS-Class-Completion/forks","keys_url":"https://api.github.com/repos/zignd/HTML-CSS-Class-Completion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zignd/HTML-CSS-Class-Completion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zignd/HTML-CSS-Class-Completion/teams","hooks_url":"https://api.github.com/repos/zignd/HTML-CSS-Class-Completion/hooks","issue_events_url":"https://api.github.com/repos/zignd/HTML-CSS-Class-Completion/issues/events{/number}","events_url":"https://api.github.com/repos/zignd/HTML-CSS-Class-Completion/events","assignees_url":"https://api.github.com/repos/zignd/HTML-CSS-Class-Completion/assignees{/user}","branches_url":"https://api.github.com/repos/zignd/HTML-CSS-Class-Completion/branches{/branch}","tags_url":"https://api.github.com/repos/zignd/HTML-CSS-Class-Completion/tags","blobs_url":"https://api.github.com/repos/zignd/HTML-CSS-Class-Completion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zignd/HTML-CSS-Class-Completion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zignd/HTML-CSS-Class-Completion/git/refs{/sha}","trees_url":"https://api.github.com/repos/zignd/HTML-CSS-Class-Completion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zignd/HTML-CSS-Class-Completion/statuses/{sha}","languages_url":"https://api.github.com/repos/zignd/HTML-CSS-Class-Completion/languages","stargazers_url":"https://api.github.com/repos/zignd/HTML-CSS-Class-Completion/stargazers","contributors_url":"https://api.github.com/repos/zignd/HTML-CSS-Class-Completion/contributors","subscribers_url":"https://api.github.com/repos/zignd/HTML-CSS-Class-Completion/subscribers","subscription_url":"https://api.github.com/repos/zignd/HTML-CSS-Class-Completion/subscription","commits_url":"https://api.github.com/repos/zignd/HTML-CSS-Class-Completion/commits{/sha}","git_commits_url":"https://api.github.com/repos/zignd/HTML-CSS-Class-Completion/git/commits{/sha}","comments_url":"https://api.github.com/repos/zignd/HTML-CSS-Class-Completion/comments{/number}","issue_comment_url":"https://api.github.com/repos/zignd/HTML-CSS-Class-Completion/issues/comments{/number}","contents_url":"https://api.github.com/repos/zignd/HTML-CSS-Class-Completion/contents/{+path}","compare_url":"https://api.github.com/repos/zignd/HTML-CSS-Class-Completion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zignd/HTML-CSS-Class-Completion/merges","archive_url":"https://api.github.com/repos/zignd/HTML-CSS-Class-Completion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zignd/HTML-CSS-Class-Completion/downloads","issues_url":"https://api.github.com/repos/zignd/HTML-CSS-Class-Completion/issues{/number}","pulls_url":"https://api.github.com/repos/zignd/HTML-CSS-Class-Completion/pulls{/number}","milestones_url":"https://api.github.com/repos/zignd/HTML-CSS-Class-Completion/milestones{/number}","notifications_url":"https://api.github.com/repos/zignd/HTML-CSS-Class-Completion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zignd/HTML-CSS-Class-Completion/labels{/name}","releases_url":"https://api.github.com/repos/zignd/HTML-CSS-Class-Completion/releases{/id}","deployments_url":"https://api.github.com/repos/zignd/HTML-CSS-Class-Completion/deployments","created_at":"2016-01-31T05:23:12Z","updated_at":"2017-10-08T09:56:31Z","pushed_at":"2017-10-12T14:38:38Z","git_url":"git://github.com/zignd/HTML-CSS-Class-Completion.git","ssh_url":"git@github.com:zignd/HTML-CSS-Class-Completion.git","clone_url":"https://github.com/zignd/HTML-CSS-Class-Completion.git","svn_url":"https://github.com/zignd/HTML-CSS-Class-Completion","homepage":"https://marketplace.visualstudio.com/items?itemName=Zignd.html-css-class-completion","size":141,"stargazers_count":45,"watchers_count":45,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":32,"forks":18,"open_issues":32,"watchers":45,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zignd/HTML-CSS-Class-Completion/pulls/89"},"html":{"href":"https://github.com/zignd/HTML-CSS-Class-Completion/pull/89"},"issue":{"href":"https://api.github.com/repos/zignd/HTML-CSS-Class-Completion/issues/89"},"comments":{"href":"https://api.github.com/repos/zignd/HTML-CSS-Class-Completion/issues/89/comments"},"review_comments":{"href":"https://api.github.com/repos/zignd/HTML-CSS-Class-Completion/pulls/89/comments"},"review_comment":{"href":"https://api.github.com/repos/zignd/HTML-CSS-Class-Completion/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zignd/HTML-CSS-Class-Completion/pulls/89/commits"},"statuses":{"href":"https://api.github.com/repos/zignd/HTML-CSS-Class-Completion/statuses/a5f366f357bcc424852f2c6ee209720cc70bdc5a"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"zignd","id":3194806,"avatar_url":"https://avatars2.githubusercontent.com/u/3194806?v=4","gravatar_id":"","url":"https://api.github.com/users/zignd","html_url":"https://github.com/zignd","followers_url":"https://api.github.com/users/zignd/followers","following_url":"https://api.github.com/users/zignd/following{/other_user}","gists_url":"https://api.github.com/users/zignd/gists{/gist_id}","starred_url":"https://api.github.com/users/zignd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zignd/subscriptions","organizations_url":"https://api.github.com/users/zignd/orgs","repos_url":"https://api.github.com/users/zignd/repos","events_url":"https://api.github.com/users/zignd/events{/privacy}","received_events_url":"https://api.github.com/users/zignd/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"zignd"}}