{"action":"created","comment":{"url":"https://api.github.com/repos/gemini-testing/retry-limiter/pulls/comments/125422106","pull_request_review_id":47808601,"id":125422106,"diff_hunk":"@@ -0,0 +1,35 @@\n+'use strict';\n+\n+const _ = require('lodash');\n+const configParser = require('gemini-configparser');\n+\n+const root = configParser.root;\n+const section = configParser.section;\n+const option = configParser.option;\n+\n+const ENV_PREFIX = 'retry_limiter_';\n+\n+module.exports = (options) => getParser()({options, env: process.env, argv: []});\n+\n+function getParser() {\n+    return root(section({\n+        enabled: option({\n+            defaultValue: true,\n+            parseEnv: JSON.parse,\n+            validate: (value) => !_.isBoolean(value) && thr('Option \"enabled\" must be boolean')","path":"lib/plugin-opts.js","position":19,"original_position":19,"commit_id":"e9e06552a436daca6b0feffa05f1b7442e078149","original_commit_id":"e9e06552a436daca6b0feffa05f1b7442e078149","user":{"login":"eGavr","id":6376693,"avatar_url":"https://avatars0.githubusercontent.com/u/6376693?v=3","gravatar_id":"","url":"https://api.github.com/users/eGavr","html_url":"https://github.com/eGavr","followers_url":"https://api.github.com/users/eGavr/followers","following_url":"https://api.github.com/users/eGavr/following{/other_user}","gists_url":"https://api.github.com/users/eGavr/gists{/gist_id}","starred_url":"https://api.github.com/users/eGavr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eGavr/subscriptions","organizations_url":"https://api.github.com/users/eGavr/orgs","repos_url":"https://api.github.com/users/eGavr/repos","events_url":"https://api.github.com/users/eGavr/events{/privacy}","received_events_url":"https://api.github.com/users/eGavr/received_events","type":"User","site_admin":false},"body":"Та ёлки палки :)\r\n\r\nСколько можно говорить, что конфиг парсер не умеет такого, он не будет ругаться, если писать так, как ты предлагаешь, надо явно кидать `throw`","created_at":"2017-07-04T08:56:20Z","updated_at":"2017-07-04T08:56:20Z","html_url":"https://github.com/gemini-testing/retry-limiter/pull/2#discussion_r125422106","pull_request_url":"https://api.github.com/repos/gemini-testing/retry-limiter/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/gemini-testing/retry-limiter/pulls/comments/125422106"},"html":{"href":"https://github.com/gemini-testing/retry-limiter/pull/2#discussion_r125422106"},"pull_request":{"href":"https://api.github.com/repos/gemini-testing/retry-limiter/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/gemini-testing/retry-limiter/pulls/2","id":128130149,"html_url":"https://github.com/gemini-testing/retry-limiter/pull/2","diff_url":"https://github.com/gemini-testing/retry-limiter/pull/2.diff","patch_url":"https://github.com/gemini-testing/retry-limiter/pull/2.patch","issue_url":"https://api.github.com/repos/gemini-testing/retry-limiter/issues/2","number":2,"state":"open","locked":false,"title":"Plugin implementation","user":{"login":"eGavr","id":6376693,"avatar_url":"https://avatars0.githubusercontent.com/u/6376693?v=3","gravatar_id":"","url":"https://api.github.com/users/eGavr","html_url":"https://github.com/eGavr","followers_url":"https://api.github.com/users/eGavr/followers","following_url":"https://api.github.com/users/eGavr/following{/other_user}","gists_url":"https://api.github.com/users/eGavr/gists{/gist_id}","starred_url":"https://api.github.com/users/eGavr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eGavr/subscriptions","organizations_url":"https://api.github.com/users/eGavr/orgs","repos_url":"https://api.github.com/users/eGavr/repos","events_url":"https://api.github.com/users/eGavr/events{/privacy}","received_events_url":"https://api.github.com/users/eGavr/received_events","type":"User","site_admin":false},"body":"cc @sipayRT ","created_at":"2017-06-29T11:37:18Z","updated_at":"2017-07-04T08:56:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0e36e6bd9337ccb05e057f3b99d2ec1793d5fbc9","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/gemini-testing/retry-limiter/pulls/2/commits","review_comments_url":"https://api.github.com/repos/gemini-testing/retry-limiter/pulls/2/comments","review_comment_url":"https://api.github.com/repos/gemini-testing/retry-limiter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gemini-testing/retry-limiter/issues/2/comments","statuses_url":"https://api.github.com/repos/gemini-testing/retry-limiter/statuses/e9e06552a436daca6b0feffa05f1b7442e078149","head":{"label":"gemini-testing:plugin-implementation","ref":"plugin-implementation","sha":"e9e06552a436daca6b0feffa05f1b7442e078149","user":{"login":"gemini-testing","id":11424134,"avatar_url":"https://avatars0.githubusercontent.com/u/11424134?v=3","gravatar_id":"","url":"https://api.github.com/users/gemini-testing","html_url":"https://github.com/gemini-testing","followers_url":"https://api.github.com/users/gemini-testing/followers","following_url":"https://api.github.com/users/gemini-testing/following{/other_user}","gists_url":"https://api.github.com/users/gemini-testing/gists{/gist_id}","starred_url":"https://api.github.com/users/gemini-testing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gemini-testing/subscriptions","organizations_url":"https://api.github.com/users/gemini-testing/orgs","repos_url":"https://api.github.com/users/gemini-testing/repos","events_url":"https://api.github.com/users/gemini-testing/events{/privacy}","received_events_url":"https://api.github.com/users/gemini-testing/received_events","type":"Organization","site_admin":false},"repo":{"id":95589177,"name":"retry-limiter","full_name":"gemini-testing/retry-limiter","owner":{"login":"gemini-testing","id":11424134,"avatar_url":"https://avatars0.githubusercontent.com/u/11424134?v=3","gravatar_id":"","url":"https://api.github.com/users/gemini-testing","html_url":"https://github.com/gemini-testing","followers_url":"https://api.github.com/users/gemini-testing/followers","following_url":"https://api.github.com/users/gemini-testing/following{/other_user}","gists_url":"https://api.github.com/users/gemini-testing/gists{/gist_id}","starred_url":"https://api.github.com/users/gemini-testing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gemini-testing/subscriptions","organizations_url":"https://api.github.com/users/gemini-testing/orgs","repos_url":"https://api.github.com/users/gemini-testing/repos","events_url":"https://api.github.com/users/gemini-testing/events{/privacy}","received_events_url":"https://api.github.com/users/gemini-testing/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gemini-testing/retry-limiter","description":"Plugin for gemini and hermione to disable retries at runtime","fork":false,"url":"https://api.github.com/repos/gemini-testing/retry-limiter","forks_url":"https://api.github.com/repos/gemini-testing/retry-limiter/forks","keys_url":"https://api.github.com/repos/gemini-testing/retry-limiter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gemini-testing/retry-limiter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gemini-testing/retry-limiter/teams","hooks_url":"https://api.github.com/repos/gemini-testing/retry-limiter/hooks","issue_events_url":"https://api.github.com/repos/gemini-testing/retry-limiter/issues/events{/number}","events_url":"https://api.github.com/repos/gemini-testing/retry-limiter/events","assignees_url":"https://api.github.com/repos/gemini-testing/retry-limiter/assignees{/user}","branches_url":"https://api.github.com/repos/gemini-testing/retry-limiter/branches{/branch}","tags_url":"https://api.github.com/repos/gemini-testing/retry-limiter/tags","blobs_url":"https://api.github.com/repos/gemini-testing/retry-limiter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gemini-testing/retry-limiter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gemini-testing/retry-limiter/git/refs{/sha}","trees_url":"https://api.github.com/repos/gemini-testing/retry-limiter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gemini-testing/retry-limiter/statuses/{sha}","languages_url":"https://api.github.com/repos/gemini-testing/retry-limiter/languages","stargazers_url":"https://api.github.com/repos/gemini-testing/retry-limiter/stargazers","contributors_url":"https://api.github.com/repos/gemini-testing/retry-limiter/contributors","subscribers_url":"https://api.github.com/repos/gemini-testing/retry-limiter/subscribers","subscription_url":"https://api.github.com/repos/gemini-testing/retry-limiter/subscription","commits_url":"https://api.github.com/repos/gemini-testing/retry-limiter/commits{/sha}","git_commits_url":"https://api.github.com/repos/gemini-testing/retry-limiter/git/commits{/sha}","comments_url":"https://api.github.com/repos/gemini-testing/retry-limiter/comments{/number}","issue_comment_url":"https://api.github.com/repos/gemini-testing/retry-limiter/issues/comments{/number}","contents_url":"https://api.github.com/repos/gemini-testing/retry-limiter/contents/{+path}","compare_url":"https://api.github.com/repos/gemini-testing/retry-limiter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gemini-testing/retry-limiter/merges","archive_url":"https://api.github.com/repos/gemini-testing/retry-limiter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gemini-testing/retry-limiter/downloads","issues_url":"https://api.github.com/repos/gemini-testing/retry-limiter/issues{/number}","pulls_url":"https://api.github.com/repos/gemini-testing/retry-limiter/pulls{/number}","milestones_url":"https://api.github.com/repos/gemini-testing/retry-limiter/milestones{/number}","notifications_url":"https://api.github.com/repos/gemini-testing/retry-limiter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gemini-testing/retry-limiter/labels{/name}","releases_url":"https://api.github.com/repos/gemini-testing/retry-limiter/releases{/id}","deployments_url":"https://api.github.com/repos/gemini-testing/retry-limiter/deployments","created_at":"2017-06-27T18:35:45Z","updated_at":"2017-06-30T08:43:42Z","pushed_at":"2017-07-03T10:48:46Z","git_url":"git://github.com/gemini-testing/retry-limiter.git","ssh_url":"git@github.com:gemini-testing/retry-limiter.git","clone_url":"https://github.com/gemini-testing/retry-limiter.git","svn_url":"https://github.com/gemini-testing/retry-limiter","homepage":"","size":11,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"gemini-testing:master","ref":"master","sha":"20cd6d27f85edea2885177dbe71717afbf1a09a4","user":{"login":"gemini-testing","id":11424134,"avatar_url":"https://avatars0.githubusercontent.com/u/11424134?v=3","gravatar_id":"","url":"https://api.github.com/users/gemini-testing","html_url":"https://github.com/gemini-testing","followers_url":"https://api.github.com/users/gemini-testing/followers","following_url":"https://api.github.com/users/gemini-testing/following{/other_user}","gists_url":"https://api.github.com/users/gemini-testing/gists{/gist_id}","starred_url":"https://api.github.com/users/gemini-testing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gemini-testing/subscriptions","organizations_url":"https://api.github.com/users/gemini-testing/orgs","repos_url":"https://api.github.com/users/gemini-testing/repos","events_url":"https://api.github.com/users/gemini-testing/events{/privacy}","received_events_url":"https://api.github.com/users/gemini-testing/received_events","type":"Organization","site_admin":false},"repo":{"id":95589177,"name":"retry-limiter","full_name":"gemini-testing/retry-limiter","owner":{"login":"gemini-testing","id":11424134,"avatar_url":"https://avatars0.githubusercontent.com/u/11424134?v=3","gravatar_id":"","url":"https://api.github.com/users/gemini-testing","html_url":"https://github.com/gemini-testing","followers_url":"https://api.github.com/users/gemini-testing/followers","following_url":"https://api.github.com/users/gemini-testing/following{/other_user}","gists_url":"https://api.github.com/users/gemini-testing/gists{/gist_id}","starred_url":"https://api.github.com/users/gemini-testing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gemini-testing/subscriptions","organizations_url":"https://api.github.com/users/gemini-testing/orgs","repos_url":"https://api.github.com/users/gemini-testing/repos","events_url":"https://api.github.com/users/gemini-testing/events{/privacy}","received_events_url":"https://api.github.com/users/gemini-testing/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gemini-testing/retry-limiter","description":"Plugin for gemini and hermione to disable retries at runtime","fork":false,"url":"https://api.github.com/repos/gemini-testing/retry-limiter","forks_url":"https://api.github.com/repos/gemini-testing/retry-limiter/forks","keys_url":"https://api.github.com/repos/gemini-testing/retry-limiter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gemini-testing/retry-limiter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gemini-testing/retry-limiter/teams","hooks_url":"https://api.github.com/repos/gemini-testing/retry-limiter/hooks","issue_events_url":"https://api.github.com/repos/gemini-testing/retry-limiter/issues/events{/number}","events_url":"https://api.github.com/repos/gemini-testing/retry-limiter/events","assignees_url":"https://api.github.com/repos/gemini-testing/retry-limiter/assignees{/user}","branches_url":"https://api.github.com/repos/gemini-testing/retry-limiter/branches{/branch}","tags_url":"https://api.github.com/repos/gemini-testing/retry-limiter/tags","blobs_url":"https://api.github.com/repos/gemini-testing/retry-limiter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gemini-testing/retry-limiter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gemini-testing/retry-limiter/git/refs{/sha}","trees_url":"https://api.github.com/repos/gemini-testing/retry-limiter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gemini-testing/retry-limiter/statuses/{sha}","languages_url":"https://api.github.com/repos/gemini-testing/retry-limiter/languages","stargazers_url":"https://api.github.com/repos/gemini-testing/retry-limiter/stargazers","contributors_url":"https://api.github.com/repos/gemini-testing/retry-limiter/contributors","subscribers_url":"https://api.github.com/repos/gemini-testing/retry-limiter/subscribers","subscription_url":"https://api.github.com/repos/gemini-testing/retry-limiter/subscription","commits_url":"https://api.github.com/repos/gemini-testing/retry-limiter/commits{/sha}","git_commits_url":"https://api.github.com/repos/gemini-testing/retry-limiter/git/commits{/sha}","comments_url":"https://api.github.com/repos/gemini-testing/retry-limiter/comments{/number}","issue_comment_url":"https://api.github.com/repos/gemini-testing/retry-limiter/issues/comments{/number}","contents_url":"https://api.github.com/repos/gemini-testing/retry-limiter/contents/{+path}","compare_url":"https://api.github.com/repos/gemini-testing/retry-limiter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gemini-testing/retry-limiter/merges","archive_url":"https://api.github.com/repos/gemini-testing/retry-limiter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gemini-testing/retry-limiter/downloads","issues_url":"https://api.github.com/repos/gemini-testing/retry-limiter/issues{/number}","pulls_url":"https://api.github.com/repos/gemini-testing/retry-limiter/pulls{/number}","milestones_url":"https://api.github.com/repos/gemini-testing/retry-limiter/milestones{/number}","notifications_url":"https://api.github.com/repos/gemini-testing/retry-limiter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gemini-testing/retry-limiter/labels{/name}","releases_url":"https://api.github.com/repos/gemini-testing/retry-limiter/releases{/id}","deployments_url":"https://api.github.com/repos/gemini-testing/retry-limiter/deployments","created_at":"2017-06-27T18:35:45Z","updated_at":"2017-06-30T08:43:42Z","pushed_at":"2017-07-03T10:48:46Z","git_url":"git://github.com/gemini-testing/retry-limiter.git","ssh_url":"git@github.com:gemini-testing/retry-limiter.git","clone_url":"https://github.com/gemini-testing/retry-limiter.git","svn_url":"https://github.com/gemini-testing/retry-limiter","homepage":"","size":11,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gemini-testing/retry-limiter/pulls/2"},"html":{"href":"https://github.com/gemini-testing/retry-limiter/pull/2"},"issue":{"href":"https://api.github.com/repos/gemini-testing/retry-limiter/issues/2"},"comments":{"href":"https://api.github.com/repos/gemini-testing/retry-limiter/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/gemini-testing/retry-limiter/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/gemini-testing/retry-limiter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gemini-testing/retry-limiter/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/gemini-testing/retry-limiter/statuses/e9e06552a436daca6b0feffa05f1b7442e078149"}}}}
{"actor":{"display_login":"eGavr"}}