{"action":"closed","number":236,"pull_request":{"url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/pulls/236","id":105254789,"html_url":"https://github.com/DroidKaigi/conference-app-2017/pull/236","diff_url":"https://github.com/DroidKaigi/conference-app-2017/pull/236.diff","patch_url":"https://github.com/DroidKaigi/conference-app-2017/pull/236.patch","issue_url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/issues/236","number":236,"state":"closed","locked":false,"title":"Manage Disposable with lifecycle in SearchFragment","user":{"login":"yatatsu","id":949882,"avatar_url":"https://avatars.githubusercontent.com/u/949882?v=3","gravatar_id":"","url":"https://api.github.com/users/yatatsu","html_url":"https://github.com/yatatsu","followers_url":"https://api.github.com/users/yatatsu/followers","following_url":"https://api.github.com/users/yatatsu/following{/other_user}","gists_url":"https://api.github.com/users/yatatsu/gists{/gist_id}","starred_url":"https://api.github.com/users/yatatsu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yatatsu/subscriptions","organizations_url":"https://api.github.com/users/yatatsu/orgs","repos_url":"https://api.github.com/users/yatatsu/repos","events_url":"https://api.github.com/users/yatatsu/events{/privacy}","received_events_url":"https://api.github.com/users/yatatsu/received_events","type":"User","site_admin":false},"body":"## Issue\r\n- None\r\n\r\n## Overview (Required)\r\n- SearchFragment subscribed in `onCreateView`, but it was never disposed.\r\n- Clear disposables in `onDestroyView`, and dispose all in `onDetach`.\r\n- And I also destroy viewModel in `onDestroy` (Because it looks to be designed so).\r\n\r\n## Links\r\n-\r\n\r\n## Screenshot\r\nBefore | After\r\n:--: | :--:\r\n<img src=\"\" width=\"300\" /> | <img src=\"\" width=\"300\" />\r\n","created_at":"2017-02-08T16:39:14Z","updated_at":"2017-02-08T16:51:35Z","closed_at":"2017-02-08T16:51:35Z","merged_at":"2017-02-08T16:51:35Z","merge_commit_sha":"26f3362fcb8930542d31bb4d7b94ed0122f26d25","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/pulls/236/commits","review_comments_url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/pulls/236/comments","review_comment_url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/issues/236/comments","statuses_url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/statuses/88f1c838e1e48461c4e9a64eeecaa95f979a73c1","head":{"label":"yatatsu:fix-search-fragment-disposable","ref":"fix-search-fragment-disposable","sha":"88f1c838e1e48461c4e9a64eeecaa95f979a73c1","user":{"login":"yatatsu","id":949882,"avatar_url":"https://avatars.githubusercontent.com/u/949882?v=3","gravatar_id":"","url":"https://api.github.com/users/yatatsu","html_url":"https://github.com/yatatsu","followers_url":"https://api.github.com/users/yatatsu/followers","following_url":"https://api.github.com/users/yatatsu/following{/other_user}","gists_url":"https://api.github.com/users/yatatsu/gists{/gist_id}","starred_url":"https://api.github.com/users/yatatsu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yatatsu/subscriptions","organizations_url":"https://api.github.com/users/yatatsu/orgs","repos_url":"https://api.github.com/users/yatatsu/repos","events_url":"https://api.github.com/users/yatatsu/events{/privacy}","received_events_url":"https://api.github.com/users/yatatsu/received_events","type":"User","site_admin":false},"repo":{"id":81226002,"name":"conference-app-2017","full_name":"yatatsu/conference-app-2017","owner":{"login":"yatatsu","id":949882,"avatar_url":"https://avatars.githubusercontent.com/u/949882?v=3","gravatar_id":"","url":"https://api.github.com/users/yatatsu","html_url":"https://github.com/yatatsu","followers_url":"https://api.github.com/users/yatatsu/followers","following_url":"https://api.github.com/users/yatatsu/following{/other_user}","gists_url":"https://api.github.com/users/yatatsu/gists{/gist_id}","starred_url":"https://api.github.com/users/yatatsu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yatatsu/subscriptions","organizations_url":"https://api.github.com/users/yatatsu/orgs","repos_url":"https://api.github.com/users/yatatsu/repos","events_url":"https://api.github.com/users/yatatsu/events{/privacy}","received_events_url":"https://api.github.com/users/yatatsu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yatatsu/conference-app-2017","description":"The Official Conference App for DroidKaigi 2017 Tokyo","fork":true,"url":"https://api.github.com/repos/yatatsu/conference-app-2017","forks_url":"https://api.github.com/repos/yatatsu/conference-app-2017/forks","keys_url":"https://api.github.com/repos/yatatsu/conference-app-2017/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yatatsu/conference-app-2017/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yatatsu/conference-app-2017/teams","hooks_url":"https://api.github.com/repos/yatatsu/conference-app-2017/hooks","issue_events_url":"https://api.github.com/repos/yatatsu/conference-app-2017/issues/events{/number}","events_url":"https://api.github.com/repos/yatatsu/conference-app-2017/events","assignees_url":"https://api.github.com/repos/yatatsu/conference-app-2017/assignees{/user}","branches_url":"https://api.github.com/repos/yatatsu/conference-app-2017/branches{/branch}","tags_url":"https://api.github.com/repos/yatatsu/conference-app-2017/tags","blobs_url":"https://api.github.com/repos/yatatsu/conference-app-2017/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yatatsu/conference-app-2017/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yatatsu/conference-app-2017/git/refs{/sha}","trees_url":"https://api.github.com/repos/yatatsu/conference-app-2017/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yatatsu/conference-app-2017/statuses/{sha}","languages_url":"https://api.github.com/repos/yatatsu/conference-app-2017/languages","stargazers_url":"https://api.github.com/repos/yatatsu/conference-app-2017/stargazers","contributors_url":"https://api.github.com/repos/yatatsu/conference-app-2017/contributors","subscribers_url":"https://api.github.com/repos/yatatsu/conference-app-2017/subscribers","subscription_url":"https://api.github.com/repos/yatatsu/conference-app-2017/subscription","commits_url":"https://api.github.com/repos/yatatsu/conference-app-2017/commits{/sha}","git_commits_url":"https://api.github.com/repos/yatatsu/conference-app-2017/git/commits{/sha}","comments_url":"https://api.github.com/repos/yatatsu/conference-app-2017/comments{/number}","issue_comment_url":"https://api.github.com/repos/yatatsu/conference-app-2017/issues/comments{/number}","contents_url":"https://api.github.com/repos/yatatsu/conference-app-2017/contents/{+path}","compare_url":"https://api.github.com/repos/yatatsu/conference-app-2017/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yatatsu/conference-app-2017/merges","archive_url":"https://api.github.com/repos/yatatsu/conference-app-2017/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yatatsu/conference-app-2017/downloads","issues_url":"https://api.github.com/repos/yatatsu/conference-app-2017/issues{/number}","pulls_url":"https://api.github.com/repos/yatatsu/conference-app-2017/pulls{/number}","milestones_url":"https://api.github.com/repos/yatatsu/conference-app-2017/milestones{/number}","notifications_url":"https://api.github.com/repos/yatatsu/conference-app-2017/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yatatsu/conference-app-2017/labels{/name}","releases_url":"https://api.github.com/repos/yatatsu/conference-app-2017/releases{/id}","deployments_url":"https://api.github.com/repos/yatatsu/conference-app-2017/deployments","created_at":"2017-02-07T15:57:11Z","updated_at":"2017-02-07T15:57:12Z","pushed_at":"2017-02-08T16:31:48Z","git_url":"git://github.com/yatatsu/conference-app-2017.git","ssh_url":"git@github.com:yatatsu/conference-app-2017.git","clone_url":"https://github.com/yatatsu/conference-app-2017.git","svn_url":"https://github.com/yatatsu/conference-app-2017","homepage":"","size":11377,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DroidKaigi:master","ref":"master","sha":"c07a20e30ebad75868de0b26a5a4a5a5d5590fb4","user":{"login":"DroidKaigi","id":10727543,"avatar_url":"https://avatars.githubusercontent.com/u/10727543?v=3","gravatar_id":"","url":"https://api.github.com/users/DroidKaigi","html_url":"https://github.com/DroidKaigi","followers_url":"https://api.github.com/users/DroidKaigi/followers","following_url":"https://api.github.com/users/DroidKaigi/following{/other_user}","gists_url":"https://api.github.com/users/DroidKaigi/gists{/gist_id}","starred_url":"https://api.github.com/users/DroidKaigi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DroidKaigi/subscriptions","organizations_url":"https://api.github.com/users/DroidKaigi/orgs","repos_url":"https://api.github.com/users/DroidKaigi/repos","events_url":"https://api.github.com/users/DroidKaigi/events{/privacy}","received_events_url":"https://api.github.com/users/DroidKaigi/received_events","type":"Organization","site_admin":false},"repo":{"id":79104433,"name":"conference-app-2017","full_name":"DroidKaigi/conference-app-2017","owner":{"login":"DroidKaigi","id":10727543,"avatar_url":"https://avatars.githubusercontent.com/u/10727543?v=3","gravatar_id":"","url":"https://api.github.com/users/DroidKaigi","html_url":"https://github.com/DroidKaigi","followers_url":"https://api.github.com/users/DroidKaigi/followers","following_url":"https://api.github.com/users/DroidKaigi/following{/other_user}","gists_url":"https://api.github.com/users/DroidKaigi/gists{/gist_id}","starred_url":"https://api.github.com/users/DroidKaigi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DroidKaigi/subscriptions","organizations_url":"https://api.github.com/users/DroidKaigi/orgs","repos_url":"https://api.github.com/users/DroidKaigi/repos","events_url":"https://api.github.com/users/DroidKaigi/events{/privacy}","received_events_url":"https://api.github.com/users/DroidKaigi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DroidKaigi/conference-app-2017","description":"The Official Conference App for DroidKaigi 2017 Tokyo","fork":false,"url":"https://api.github.com/repos/DroidKaigi/conference-app-2017","forks_url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/forks","keys_url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/teams","hooks_url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/hooks","issue_events_url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/issues/events{/number}","events_url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/events","assignees_url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/assignees{/user}","branches_url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/branches{/branch}","tags_url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/tags","blobs_url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/git/refs{/sha}","trees_url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/statuses/{sha}","languages_url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/languages","stargazers_url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/stargazers","contributors_url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/contributors","subscribers_url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/subscribers","subscription_url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/subscription","commits_url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/commits{/sha}","git_commits_url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/git/commits{/sha}","comments_url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/comments{/number}","issue_comment_url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/issues/comments{/number}","contents_url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/contents/{+path}","compare_url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/merges","archive_url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/downloads","issues_url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/issues{/number}","pulls_url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/pulls{/number}","milestones_url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/milestones{/number}","notifications_url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/labels{/name}","releases_url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/releases{/id}","deployments_url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/deployments","created_at":"2017-01-16T09:47:53Z","updated_at":"2017-02-08T16:46:37Z","pushed_at":"2017-02-08T16:51:35Z","git_url":"git://github.com/DroidKaigi/conference-app-2017.git","ssh_url":"git@github.com:DroidKaigi/conference-app-2017.git","clone_url":"https://github.com/DroidKaigi/conference-app-2017.git","svn_url":"https://github.com/DroidKaigi/conference-app-2017","homepage":"","size":11489,"stargazers_count":242,"watchers_count":242,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":70,"mirror_url":null,"open_issues_count":40,"forks":70,"open_issues":40,"watchers":242,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DroidKaigi/conference-app-2017/pulls/236"},"html":{"href":"https://github.com/DroidKaigi/conference-app-2017/pull/236"},"issue":{"href":"https://api.github.com/repos/DroidKaigi/conference-app-2017/issues/236"},"comments":{"href":"https://api.github.com/repos/DroidKaigi/conference-app-2017/issues/236/comments"},"review_comments":{"href":"https://api.github.com/repos/DroidKaigi/conference-app-2017/pulls/236/comments"},"review_comment":{"href":"https://api.github.com/repos/DroidKaigi/conference-app-2017/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DroidKaigi/conference-app-2017/pulls/236/commits"},"statuses":{"href":"https://api.github.com/repos/DroidKaigi/conference-app-2017/statuses/88f1c838e1e48461c4e9a64eeecaa95f979a73c1"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"konifar","id":1269214,"avatar_url":"https://avatars.githubusercontent.com/u/1269214?v=3","gravatar_id":"","url":"https://api.github.com/users/konifar","html_url":"https://github.com/konifar","followers_url":"https://api.github.com/users/konifar/followers","following_url":"https://api.github.com/users/konifar/following{/other_user}","gists_url":"https://api.github.com/users/konifar/gists{/gist_id}","starred_url":"https://api.github.com/users/konifar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/konifar/subscriptions","organizations_url":"https://api.github.com/users/konifar/orgs","repos_url":"https://api.github.com/users/konifar/repos","events_url":"https://api.github.com/users/konifar/events{/privacy}","received_events_url":"https://api.github.com/users/konifar/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":25,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"konifar"}}