{"action":"created","comment":{"url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/pulls/comments/103067386","pull_request_review_id":23847483,"id":103067386,"diff_hunk":"@@ -38,22 +46,71 @@ public static boolean isValidAddress(String test) {\n \n     @Override\n     public String toString() {\n-        return value;\n+        return blockNum.getBlockNum() + \", \" + streetNum.getStreetNum() + \", \" + \n+        \t\tunitNum.getUnitNum() + \", \" + postalCode.getPostalCode();\n     }\n \n     @Override\n     public boolean equals(Object other) {\n         return other == this // short circuit if same object\n                 || (other instanceof Address // instanceof handles nulls\n-                && this.value.equals(((Address) other).value)); // state check\n+                && this.toString().equals(((Address) other).toString())); // state check\n     }\n \n     @Override\n     public int hashCode() {\n-        return value.hashCode();\n+        return toString().hashCode();\n     }\n \n     public boolean isPrivate() {\n         return isPrivate;\n     }\n+    \n+    private class BlockNum {\n+    \tString blockNum;\n+    \tpublic BlockNum(String blockNum) {\n+    \t\tthis.blockNum = blockNum;\n+    \t}\n+    \t\n+    \t//accessor\n+    \tpublic String getBlockNum() {\n+    \t\treturn blockNum;\n+    \t}\n+    }\n+    \n+    private class StreetNum {\n+    \tString streetNum;","path":"src/seedu/addressbook/data/person/Address.java","position":72,"original_position":72,"commit_id":"0576242d0c8a7aa6a39c4fbdfc3a60db22fec52e","original_commit_id":"0576242d0c8a7aa6a39c4fbdfc3a60db22fec52e","user":{"login":"codacy-bot","id":19940114,"avatar_url":"https://avatars.githubusercontent.com/u/19940114?v=3","gravatar_id":"","url":"https://api.github.com/users/codacy-bot","html_url":"https://github.com/codacy-bot","followers_url":"https://api.github.com/users/codacy-bot/followers","following_url":"https://api.github.com/users/codacy-bot/following{/other_user}","gists_url":"https://api.github.com/users/codacy-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/codacy-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codacy-bot/subscriptions","organizations_url":"https://api.github.com/users/codacy-bot/orgs","repos_url":"https://api.github.com/users/codacy-bot/repos","events_url":"https://api.github.com/users/codacy-bot/events{/privacy}","received_events_url":"https://api.github.com/users/codacy-bot/received_events","type":"User","site_admin":false},"body":"![Codacy](https://www.codacy.com/assets/images/favicon.png) Issue found: [Use explicit scoping instead of the default package private level](https://www.codacy.com/app/se-edu/AY1617S2-AB-Level2/pullRequest?prid=505743)","created_at":"2017-02-25T02:15:19Z","updated_at":"2017-02-25T02:15:19Z","html_url":"https://github.com/nus-cs2103-AY1617S2/addressbook-level2/pull/345#discussion_r103067386","pull_request_url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/pulls/345","_links":{"self":{"href":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/pulls/comments/103067386"},"html":{"href":"https://github.com/nus-cs2103-AY1617S2/addressbook-level2/pull/345#discussion_r103067386"},"pull_request":{"href":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/pulls/345"}}},"pull_request":{"url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/pulls/345","id":104285630,"html_url":"https://github.com/nus-cs2103-AY1617S2/addressbook-level2/pull/345","diff_url":"https://github.com/nus-cs2103-AY1617S2/addressbook-level2/pull/345.diff","patch_url":"https://github.com/nus-cs2103-AY1617S2/addressbook-level2/pull/345.patch","issue_url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/issues/345","number":345,"state":"open","locked":false,"title":"[T3A3][W15-A1] Ng Shao Hui","user":{"login":"shinlos","id":18242337,"avatar_url":"https://avatars.githubusercontent.com/u/18242337?v=3","gravatar_id":"","url":"https://api.github.com/users/shinlos","html_url":"https://github.com/shinlos","followers_url":"https://api.github.com/users/shinlos/followers","following_url":"https://api.github.com/users/shinlos/following{/other_user}","gists_url":"https://api.github.com/users/shinlos/gists{/gist_id}","starred_url":"https://api.github.com/users/shinlos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shinlos/subscriptions","organizations_url":"https://api.github.com/users/shinlos/orgs","repos_url":"https://api.github.com/users/shinlos/repos","events_url":"https://api.github.com/users/shinlos/events{/privacy}","received_events_url":"https://api.github.com/users/shinlos/received_events","type":"User","site_admin":false},"body":"Ready for review","created_at":"2017-02-02T07:12:05Z","updated_at":"2017-02-25T02:15:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"369b6868127b5b365cd52b54e1cb3845763b726e","assignee":{"login":"mauris","id":996939,"avatar_url":"https://avatars.githubusercontent.com/u/996939?v=3","gravatar_id":"","url":"https://api.github.com/users/mauris","html_url":"https://github.com/mauris","followers_url":"https://api.github.com/users/mauris/followers","following_url":"https://api.github.com/users/mauris/following{/other_user}","gists_url":"https://api.github.com/users/mauris/gists{/gist_id}","starred_url":"https://api.github.com/users/mauris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mauris/subscriptions","organizations_url":"https://api.github.com/users/mauris/orgs","repos_url":"https://api.github.com/users/mauris/repos","events_url":"https://api.github.com/users/mauris/events{/privacy}","received_events_url":"https://api.github.com/users/mauris/received_events","type":"User","site_admin":false},"assignees":[{"login":"mauris","id":996939,"avatar_url":"https://avatars.githubusercontent.com/u/996939?v=3","gravatar_id":"","url":"https://api.github.com/users/mauris","html_url":"https://github.com/mauris","followers_url":"https://api.github.com/users/mauris/followers","following_url":"https://api.github.com/users/mauris/following{/other_user}","gists_url":"https://api.github.com/users/mauris/gists{/gist_id}","starred_url":"https://api.github.com/users/mauris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mauris/subscriptions","organizations_url":"https://api.github.com/users/mauris/orgs","repos_url":"https://api.github.com/users/mauris/repos","events_url":"https://api.github.com/users/mauris/events{/privacy}","received_events_url":"https://api.github.com/users/mauris/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/pulls/345/commits","review_comments_url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/pulls/345/comments","review_comment_url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/issues/345/comments","statuses_url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/statuses/0576242d0c8a7aa6a39c4fbdfc3a60db22fec52e","head":{"label":"shinlos:T3A3","ref":"T3A3","sha":"0576242d0c8a7aa6a39c4fbdfc3a60db22fec52e","user":{"login":"shinlos","id":18242337,"avatar_url":"https://avatars.githubusercontent.com/u/18242337?v=3","gravatar_id":"","url":"https://api.github.com/users/shinlos","html_url":"https://github.com/shinlos","followers_url":"https://api.github.com/users/shinlos/followers","following_url":"https://api.github.com/users/shinlos/following{/other_user}","gists_url":"https://api.github.com/users/shinlos/gists{/gist_id}","starred_url":"https://api.github.com/users/shinlos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shinlos/subscriptions","organizations_url":"https://api.github.com/users/shinlos/orgs","repos_url":"https://api.github.com/users/shinlos/repos","events_url":"https://api.github.com/users/shinlos/events{/privacy}","received_events_url":"https://api.github.com/users/shinlos/received_events","type":"User","site_admin":false},"repo":{"id":80570927,"name":"addressbook-level2","full_name":"shinlos/addressbook-level2","owner":{"login":"shinlos","id":18242337,"avatar_url":"https://avatars.githubusercontent.com/u/18242337?v=3","gravatar_id":"","url":"https://api.github.com/users/shinlos","html_url":"https://github.com/shinlos","followers_url":"https://api.github.com/users/shinlos/followers","following_url":"https://api.github.com/users/shinlos/following{/other_user}","gists_url":"https://api.github.com/users/shinlos/gists{/gist_id}","starred_url":"https://api.github.com/users/shinlos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shinlos/subscriptions","organizations_url":"https://api.github.com/users/shinlos/orgs","repos_url":"https://api.github.com/users/shinlos/repos","events_url":"https://api.github.com/users/shinlos/events{/privacy}","received_events_url":"https://api.github.com/users/shinlos/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shinlos/addressbook-level2","description":"A Java sample application for students. An AddressBook application that uses OOP basics.","fork":true,"url":"https://api.github.com/repos/shinlos/addressbook-level2","forks_url":"https://api.github.com/repos/shinlos/addressbook-level2/forks","keys_url":"https://api.github.com/repos/shinlos/addressbook-level2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shinlos/addressbook-level2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shinlos/addressbook-level2/teams","hooks_url":"https://api.github.com/repos/shinlos/addressbook-level2/hooks","issue_events_url":"https://api.github.com/repos/shinlos/addressbook-level2/issues/events{/number}","events_url":"https://api.github.com/repos/shinlos/addressbook-level2/events","assignees_url":"https://api.github.com/repos/shinlos/addressbook-level2/assignees{/user}","branches_url":"https://api.github.com/repos/shinlos/addressbook-level2/branches{/branch}","tags_url":"https://api.github.com/repos/shinlos/addressbook-level2/tags","blobs_url":"https://api.github.com/repos/shinlos/addressbook-level2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shinlos/addressbook-level2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shinlos/addressbook-level2/git/refs{/sha}","trees_url":"https://api.github.com/repos/shinlos/addressbook-level2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shinlos/addressbook-level2/statuses/{sha}","languages_url":"https://api.github.com/repos/shinlos/addressbook-level2/languages","stargazers_url":"https://api.github.com/repos/shinlos/addressbook-level2/stargazers","contributors_url":"https://api.github.com/repos/shinlos/addressbook-level2/contributors","subscribers_url":"https://api.github.com/repos/shinlos/addressbook-level2/subscribers","subscription_url":"https://api.github.com/repos/shinlos/addressbook-level2/subscription","commits_url":"https://api.github.com/repos/shinlos/addressbook-level2/commits{/sha}","git_commits_url":"https://api.github.com/repos/shinlos/addressbook-level2/git/commits{/sha}","comments_url":"https://api.github.com/repos/shinlos/addressbook-level2/comments{/number}","issue_comment_url":"https://api.github.com/repos/shinlos/addressbook-level2/issues/comments{/number}","contents_url":"https://api.github.com/repos/shinlos/addressbook-level2/contents/{+path}","compare_url":"https://api.github.com/repos/shinlos/addressbook-level2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shinlos/addressbook-level2/merges","archive_url":"https://api.github.com/repos/shinlos/addressbook-level2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shinlos/addressbook-level2/downloads","issues_url":"https://api.github.com/repos/shinlos/addressbook-level2/issues{/number}","pulls_url":"https://api.github.com/repos/shinlos/addressbook-level2/pulls{/number}","milestones_url":"https://api.github.com/repos/shinlos/addressbook-level2/milestones{/number}","notifications_url":"https://api.github.com/repos/shinlos/addressbook-level2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shinlos/addressbook-level2/labels{/name}","releases_url":"https://api.github.com/repos/shinlos/addressbook-level2/releases{/id}","deployments_url":"https://api.github.com/repos/shinlos/addressbook-level2/deployments","created_at":"2017-01-31T22:58:09Z","updated_at":"2017-01-31T22:58:11Z","pushed_at":"2017-02-09T02:46:05Z","git_url":"git://github.com/shinlos/addressbook-level2.git","ssh_url":"git@github.com:shinlos/addressbook-level2.git","clone_url":"https://github.com/shinlos/addressbook-level2.git","svn_url":"https://github.com/shinlos/addressbook-level2","homepage":null,"size":3114,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nus-cs2103-AY1617S2:master","ref":"master","sha":"70f60ba80f0bbf2477c3f7cfca46efe21848d8c6","user":{"login":"nus-cs2103-AY1617S2","id":24604536,"avatar_url":"https://avatars.githubusercontent.com/u/24604536?v=3","gravatar_id":"","url":"https://api.github.com/users/nus-cs2103-AY1617S2","html_url":"https://github.com/nus-cs2103-AY1617S2","followers_url":"https://api.github.com/users/nus-cs2103-AY1617S2/followers","following_url":"https://api.github.com/users/nus-cs2103-AY1617S2/following{/other_user}","gists_url":"https://api.github.com/users/nus-cs2103-AY1617S2/gists{/gist_id}","starred_url":"https://api.github.com/users/nus-cs2103-AY1617S2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nus-cs2103-AY1617S2/subscriptions","organizations_url":"https://api.github.com/users/nus-cs2103-AY1617S2/orgs","repos_url":"https://api.github.com/users/nus-cs2103-AY1617S2/repos","events_url":"https://api.github.com/users/nus-cs2103-AY1617S2/events{/privacy}","received_events_url":"https://api.github.com/users/nus-cs2103-AY1617S2/received_events","type":"Organization","site_admin":false},"repo":{"id":76956252,"name":"addressbook-level2","full_name":"nus-cs2103-AY1617S2/addressbook-level2","owner":{"login":"nus-cs2103-AY1617S2","id":24604536,"avatar_url":"https://avatars.githubusercontent.com/u/24604536?v=3","gravatar_id":"","url":"https://api.github.com/users/nus-cs2103-AY1617S2","html_url":"https://github.com/nus-cs2103-AY1617S2","followers_url":"https://api.github.com/users/nus-cs2103-AY1617S2/followers","following_url":"https://api.github.com/users/nus-cs2103-AY1617S2/following{/other_user}","gists_url":"https://api.github.com/users/nus-cs2103-AY1617S2/gists{/gist_id}","starred_url":"https://api.github.com/users/nus-cs2103-AY1617S2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nus-cs2103-AY1617S2/subscriptions","organizations_url":"https://api.github.com/users/nus-cs2103-AY1617S2/orgs","repos_url":"https://api.github.com/users/nus-cs2103-AY1617S2/repos","events_url":"https://api.github.com/users/nus-cs2103-AY1617S2/events{/privacy}","received_events_url":"https://api.github.com/users/nus-cs2103-AY1617S2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nus-cs2103-AY1617S2/addressbook-level2","description":"A Java sample application for students. An AddressBook application that uses OOP basics.","fork":true,"url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2","forks_url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/forks","keys_url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/teams","hooks_url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/hooks","issue_events_url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/issues/events{/number}","events_url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/events","assignees_url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/assignees{/user}","branches_url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/branches{/branch}","tags_url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/tags","blobs_url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/git/refs{/sha}","trees_url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/statuses/{sha}","languages_url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/languages","stargazers_url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/stargazers","contributors_url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/contributors","subscribers_url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/subscribers","subscription_url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/subscription","commits_url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/commits{/sha}","git_commits_url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/git/commits{/sha}","comments_url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/comments{/number}","issue_comment_url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/issues/comments{/number}","contents_url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/contents/{+path}","compare_url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/merges","archive_url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/downloads","issues_url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/issues{/number}","pulls_url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/pulls{/number}","milestones_url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/milestones{/number}","notifications_url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/labels{/name}","releases_url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/releases{/id}","deployments_url":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/deployments","created_at":"2016-12-20T12:51:37Z","updated_at":"2017-02-01T14:41:26Z","pushed_at":"2017-02-25T01:51:54Z","git_url":"git://github.com/nus-cs2103-AY1617S2/addressbook-level2.git","ssh_url":"git@github.com:nus-cs2103-AY1617S2/addressbook-level2.git","clone_url":"https://github.com/nus-cs2103-AY1617S2/addressbook-level2.git","svn_url":"https://github.com/nus-cs2103-AY1617S2/addressbook-level2","homepage":null,"size":3101,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":166,"mirror_url":null,"open_issues_count":560,"forks":166,"open_issues":560,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/pulls/345"},"html":{"href":"https://github.com/nus-cs2103-AY1617S2/addressbook-level2/pull/345"},"issue":{"href":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/issues/345"},"comments":{"href":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/issues/345/comments"},"review_comments":{"href":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/pulls/345/comments"},"review_comment":{"href":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/pulls/345/commits"},"statuses":{"href":"https://api.github.com/repos/nus-cs2103-AY1617S2/addressbook-level2/statuses/0576242d0c8a7aa6a39c4fbdfc3a60db22fec52e"}}}}
{"actor":{"display_login":"codacy-bot"}}