{"action":"created","comment":{"url":"https://api.github.com/repos/Financial-Times/factset-reader/pulls/comments/147454742","pull_request_review_id":72557739,"id":147454742,"diff_hunk":"@@ -8,3 +8,6 @@ spec:\n   resources:","path":"helm/factset-reader/templates/pvc.yaml","position":1,"original_position":1,"commit_id":"6d6181b244f9017783285b2c16d54afeb9ba75f7","original_commit_id":"6d6181b244f9017783285b2c16d54afeb9ba75f7","user":{"login":"sbuliarca","id":8848332,"avatar_url":"https://avatars0.githubusercontent.com/u/8848332?v=4","gravatar_id":"","url":"https://api.github.com/users/sbuliarca","html_url":"https://github.com/sbuliarca","followers_url":"https://api.github.com/users/sbuliarca/followers","following_url":"https://api.github.com/users/sbuliarca/following{/other_user}","gists_url":"https://api.github.com/users/sbuliarca/gists{/gist_id}","starred_url":"https://api.github.com/users/sbuliarca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbuliarca/subscriptions","organizations_url":"https://api.github.com/users/sbuliarca/orgs","repos_url":"https://api.github.com/users/sbuliarca/repos","events_url":"https://api.github.com/users/sbuliarca/events{/privacy}","received_events_url":"https://api.github.com/users/sbuliarca/received_events","type":"User","site_admin":false},"body":"I think it is enough how it is now, as using the service-name+\"pvc\". In this case if we have many services the won't collide.","created_at":"2017-10-27T16:19:38Z","updated_at":"2017-10-27T16:19:38Z","html_url":"https://github.com/Financial-Times/factset-reader/pull/14#discussion_r147454742","pull_request_url":"https://api.github.com/repos/Financial-Times/factset-reader/pulls/14","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Financial-Times/factset-reader/pulls/comments/147454742"},"html":{"href":"https://github.com/Financial-Times/factset-reader/pull/14#discussion_r147454742"},"pull_request":{"href":"https://api.github.com/repos/Financial-Times/factset-reader/pulls/14"}},"in_reply_to_id":147361572},"pull_request":{"url":"https://api.github.com/repos/Financial-Times/factset-reader/pulls/14","id":148947671,"html_url":"https://github.com/Financial-Times/factset-reader/pull/14","diff_url":"https://github.com/Financial-Times/factset-reader/pull/14.diff","patch_url":"https://github.com/Financial-Times/factset-reader/pull/14.patch","issue_url":"https://api.github.com/repos/Financial-Times/factset-reader/issues/14","number":14,"state":"open","locked":false,"title":"Moved Persistent Volume to global-config.","user":{"login":"sbuliarca","id":8848332,"avatar_url":"https://avatars0.githubusercontent.com/u/8848332?v=4","gravatar_id":"","url":"https://api.github.com/users/sbuliarca","html_url":"https://github.com/sbuliarca","followers_url":"https://api.github.com/users/sbuliarca/followers","following_url":"https://api.github.com/users/sbuliarca/following{/other_user}","gists_url":"https://api.github.com/users/sbuliarca/gists{/gist_id}","starred_url":"https://api.github.com/users/sbuliarca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbuliarca/subscriptions","organizations_url":"https://api.github.com/users/sbuliarca/orgs","repos_url":"https://api.github.com/users/sbuliarca/repos","events_url":"https://api.github.com/users/sbuliarca/events{/privacy}","received_events_url":"https://api.github.com/users/sbuliarca/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-10-26T14:15:56Z","updated_at":"2017-10-27T16:19:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0ba8c940ee2f73d1ef0a40017a30ee90964e1c36","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Financial-Times/factset-reader/pulls/14/commits","review_comments_url":"https://api.github.com/repos/Financial-Times/factset-reader/pulls/14/comments","review_comment_url":"https://api.github.com/repos/Financial-Times/factset-reader/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Financial-Times/factset-reader/issues/14/comments","statuses_url":"https://api.github.com/repos/Financial-Times/factset-reader/statuses/6d6181b244f9017783285b2c16d54afeb9ba75f7","head":{"label":"Financial-Times:deploy-on-push/k8sCT/move-pv-to-global","ref":"deploy-on-push/k8sCT/move-pv-to-global","sha":"6d6181b244f9017783285b2c16d54afeb9ba75f7","user":{"login":"Financial-Times","id":3502508,"avatar_url":"https://avatars1.githubusercontent.com/u/3502508?v=4","gravatar_id":"","url":"https://api.github.com/users/Financial-Times","html_url":"https://github.com/Financial-Times","followers_url":"https://api.github.com/users/Financial-Times/followers","following_url":"https://api.github.com/users/Financial-Times/following{/other_user}","gists_url":"https://api.github.com/users/Financial-Times/gists{/gist_id}","starred_url":"https://api.github.com/users/Financial-Times/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Financial-Times/subscriptions","organizations_url":"https://api.github.com/users/Financial-Times/orgs","repos_url":"https://api.github.com/users/Financial-Times/repos","events_url":"https://api.github.com/users/Financial-Times/events{/privacy}","received_events_url":"https://api.github.com/users/Financial-Times/received_events","type":"Organization","site_admin":false},"repo":{"id":67216986,"name":"factset-reader","full_name":"Financial-Times/factset-reader","owner":{"login":"Financial-Times","id":3502508,"avatar_url":"https://avatars1.githubusercontent.com/u/3502508?v=4","gravatar_id":"","url":"https://api.github.com/users/Financial-Times","html_url":"https://github.com/Financial-Times","followers_url":"https://api.github.com/users/Financial-Times/followers","following_url":"https://api.github.com/users/Financial-Times/following{/other_user}","gists_url":"https://api.github.com/users/Financial-Times/gists{/gist_id}","starred_url":"https://api.github.com/users/Financial-Times/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Financial-Times/subscriptions","organizations_url":"https://api.github.com/users/Financial-Times/orgs","repos_url":"https://api.github.com/users/Financial-Times/repos","events_url":"https://api.github.com/users/Financial-Times/events{/privacy}","received_events_url":"https://api.github.com/users/Financial-Times/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Financial-Times/factset-reader","description":"This application reads files from Factset FTP server and stores them to Amazon S3","fork":false,"url":"https://api.github.com/repos/Financial-Times/factset-reader","forks_url":"https://api.github.com/repos/Financial-Times/factset-reader/forks","keys_url":"https://api.github.com/repos/Financial-Times/factset-reader/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Financial-Times/factset-reader/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Financial-Times/factset-reader/teams","hooks_url":"https://api.github.com/repos/Financial-Times/factset-reader/hooks","issue_events_url":"https://api.github.com/repos/Financial-Times/factset-reader/issues/events{/number}","events_url":"https://api.github.com/repos/Financial-Times/factset-reader/events","assignees_url":"https://api.github.com/repos/Financial-Times/factset-reader/assignees{/user}","branches_url":"https://api.github.com/repos/Financial-Times/factset-reader/branches{/branch}","tags_url":"https://api.github.com/repos/Financial-Times/factset-reader/tags","blobs_url":"https://api.github.com/repos/Financial-Times/factset-reader/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Financial-Times/factset-reader/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Financial-Times/factset-reader/git/refs{/sha}","trees_url":"https://api.github.com/repos/Financial-Times/factset-reader/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Financial-Times/factset-reader/statuses/{sha}","languages_url":"https://api.github.com/repos/Financial-Times/factset-reader/languages","stargazers_url":"https://api.github.com/repos/Financial-Times/factset-reader/stargazers","contributors_url":"https://api.github.com/repos/Financial-Times/factset-reader/contributors","subscribers_url":"https://api.github.com/repos/Financial-Times/factset-reader/subscribers","subscription_url":"https://api.github.com/repos/Financial-Times/factset-reader/subscription","commits_url":"https://api.github.com/repos/Financial-Times/factset-reader/commits{/sha}","git_commits_url":"https://api.github.com/repos/Financial-Times/factset-reader/git/commits{/sha}","comments_url":"https://api.github.com/repos/Financial-Times/factset-reader/comments{/number}","issue_comment_url":"https://api.github.com/repos/Financial-Times/factset-reader/issues/comments{/number}","contents_url":"https://api.github.com/repos/Financial-Times/factset-reader/contents/{+path}","compare_url":"https://api.github.com/repos/Financial-Times/factset-reader/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Financial-Times/factset-reader/merges","archive_url":"https://api.github.com/repos/Financial-Times/factset-reader/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Financial-Times/factset-reader/downloads","issues_url":"https://api.github.com/repos/Financial-Times/factset-reader/issues{/number}","pulls_url":"https://api.github.com/repos/Financial-Times/factset-reader/pulls{/number}","milestones_url":"https://api.github.com/repos/Financial-Times/factset-reader/milestones{/number}","notifications_url":"https://api.github.com/repos/Financial-Times/factset-reader/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Financial-Times/factset-reader/labels{/name}","releases_url":"https://api.github.com/repos/Financial-Times/factset-reader/releases{/id}","deployments_url":"https://api.github.com/repos/Financial-Times/factset-reader/deployments","created_at":"2016-09-02T11:26:13Z","updated_at":"2017-06-15T02:09:17Z","pushed_at":"2017-10-26T14:15:56Z","git_url":"git://github.com/Financial-Times/factset-reader.git","ssh_url":"git@github.com:Financial-Times/factset-reader.git","clone_url":"https://github.com/Financial-Times/factset-reader.git","svn_url":"https://github.com/Financial-Times/factset-reader","homepage":null,"size":102,"stargazers_count":2,"watchers_count":2,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":2,"default_branch":"master"}},"base":{"label":"Financial-Times:master","ref":"master","sha":"140e934197666a939692862da85de84eaa9487a9","user":{"login":"Financial-Times","id":3502508,"avatar_url":"https://avatars1.githubusercontent.com/u/3502508?v=4","gravatar_id":"","url":"https://api.github.com/users/Financial-Times","html_url":"https://github.com/Financial-Times","followers_url":"https://api.github.com/users/Financial-Times/followers","following_url":"https://api.github.com/users/Financial-Times/following{/other_user}","gists_url":"https://api.github.com/users/Financial-Times/gists{/gist_id}","starred_url":"https://api.github.com/users/Financial-Times/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Financial-Times/subscriptions","organizations_url":"https://api.github.com/users/Financial-Times/orgs","repos_url":"https://api.github.com/users/Financial-Times/repos","events_url":"https://api.github.com/users/Financial-Times/events{/privacy}","received_events_url":"https://api.github.com/users/Financial-Times/received_events","type":"Organization","site_admin":false},"repo":{"id":67216986,"name":"factset-reader","full_name":"Financial-Times/factset-reader","owner":{"login":"Financial-Times","id":3502508,"avatar_url":"https://avatars1.githubusercontent.com/u/3502508?v=4","gravatar_id":"","url":"https://api.github.com/users/Financial-Times","html_url":"https://github.com/Financial-Times","followers_url":"https://api.github.com/users/Financial-Times/followers","following_url":"https://api.github.com/users/Financial-Times/following{/other_user}","gists_url":"https://api.github.com/users/Financial-Times/gists{/gist_id}","starred_url":"https://api.github.com/users/Financial-Times/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Financial-Times/subscriptions","organizations_url":"https://api.github.com/users/Financial-Times/orgs","repos_url":"https://api.github.com/users/Financial-Times/repos","events_url":"https://api.github.com/users/Financial-Times/events{/privacy}","received_events_url":"https://api.github.com/users/Financial-Times/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Financial-Times/factset-reader","description":"This application reads files from Factset FTP server and stores them to Amazon S3","fork":false,"url":"https://api.github.com/repos/Financial-Times/factset-reader","forks_url":"https://api.github.com/repos/Financial-Times/factset-reader/forks","keys_url":"https://api.github.com/repos/Financial-Times/factset-reader/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Financial-Times/factset-reader/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Financial-Times/factset-reader/teams","hooks_url":"https://api.github.com/repos/Financial-Times/factset-reader/hooks","issue_events_url":"https://api.github.com/repos/Financial-Times/factset-reader/issues/events{/number}","events_url":"https://api.github.com/repos/Financial-Times/factset-reader/events","assignees_url":"https://api.github.com/repos/Financial-Times/factset-reader/assignees{/user}","branches_url":"https://api.github.com/repos/Financial-Times/factset-reader/branches{/branch}","tags_url":"https://api.github.com/repos/Financial-Times/factset-reader/tags","blobs_url":"https://api.github.com/repos/Financial-Times/factset-reader/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Financial-Times/factset-reader/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Financial-Times/factset-reader/git/refs{/sha}","trees_url":"https://api.github.com/repos/Financial-Times/factset-reader/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Financial-Times/factset-reader/statuses/{sha}","languages_url":"https://api.github.com/repos/Financial-Times/factset-reader/languages","stargazers_url":"https://api.github.com/repos/Financial-Times/factset-reader/stargazers","contributors_url":"https://api.github.com/repos/Financial-Times/factset-reader/contributors","subscribers_url":"https://api.github.com/repos/Financial-Times/factset-reader/subscribers","subscription_url":"https://api.github.com/repos/Financial-Times/factset-reader/subscription","commits_url":"https://api.github.com/repos/Financial-Times/factset-reader/commits{/sha}","git_commits_url":"https://api.github.com/repos/Financial-Times/factset-reader/git/commits{/sha}","comments_url":"https://api.github.com/repos/Financial-Times/factset-reader/comments{/number}","issue_comment_url":"https://api.github.com/repos/Financial-Times/factset-reader/issues/comments{/number}","contents_url":"https://api.github.com/repos/Financial-Times/factset-reader/contents/{+path}","compare_url":"https://api.github.com/repos/Financial-Times/factset-reader/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Financial-Times/factset-reader/merges","archive_url":"https://api.github.com/repos/Financial-Times/factset-reader/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Financial-Times/factset-reader/downloads","issues_url":"https://api.github.com/repos/Financial-Times/factset-reader/issues{/number}","pulls_url":"https://api.github.com/repos/Financial-Times/factset-reader/pulls{/number}","milestones_url":"https://api.github.com/repos/Financial-Times/factset-reader/milestones{/number}","notifications_url":"https://api.github.com/repos/Financial-Times/factset-reader/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Financial-Times/factset-reader/labels{/name}","releases_url":"https://api.github.com/repos/Financial-Times/factset-reader/releases{/id}","deployments_url":"https://api.github.com/repos/Financial-Times/factset-reader/deployments","created_at":"2016-09-02T11:26:13Z","updated_at":"2017-06-15T02:09:17Z","pushed_at":"2017-10-26T14:15:56Z","git_url":"git://github.com/Financial-Times/factset-reader.git","ssh_url":"git@github.com:Financial-Times/factset-reader.git","clone_url":"https://github.com/Financial-Times/factset-reader.git","svn_url":"https://github.com/Financial-Times/factset-reader","homepage":null,"size":102,"stargazers_count":2,"watchers_count":2,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Financial-Times/factset-reader/pulls/14"},"html":{"href":"https://github.com/Financial-Times/factset-reader/pull/14"},"issue":{"href":"https://api.github.com/repos/Financial-Times/factset-reader/issues/14"},"comments":{"href":"https://api.github.com/repos/Financial-Times/factset-reader/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/Financial-Times/factset-reader/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/Financial-Times/factset-reader/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Financial-Times/factset-reader/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/Financial-Times/factset-reader/statuses/6d6181b244f9017783285b2c16d54afeb9ba75f7"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"sbuliarca"}}