{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/113277748","pull_request_review_id":34652337,"id":113277748,"diff_hunk":"@@ -3,7 +3,11 @@ class ServiceAnsiblePlaybook < ServiceGeneric\n \n   # A chance for taking options from automate script to override options from a service dialog\n   def preprocess(action, add_options = {})\n-    _log.info(\"Override with new options: #{add_options}\") unless add_options.blank?\n+    unless add_options.blank?\n+      _log.info(\"Override with new options:\")\n+      $log.log_hashes(add_options)","path":"app/models/service_ansible_playbook.rb","position":7,"original_position":7,"commit_id":"e9f0154c98ec90c62ce63b12fbf5998734480859","original_commit_id":"e9f0154c98ec90c62ce63b12fbf5998734480859","user":{"login":"lfu","id":2593270,"avatar_url":"https://avatars0.githubusercontent.com/u/2593270?v=3","gravatar_id":"","url":"https://api.github.com/users/lfu","html_url":"https://github.com/lfu","followers_url":"https://api.github.com/users/lfu/followers","following_url":"https://api.github.com/users/lfu/following{/other_user}","gists_url":"https://api.github.com/users/lfu/gists{/gist_id}","starred_url":"https://api.github.com/users/lfu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lfu/subscriptions","organizations_url":"https://api.github.com/users/lfu/orgs","repos_url":"https://api.github.com/users/lfu/repos","events_url":"https://api.github.com/users/lfu/events{/privacy}","received_events_url":"https://api.github.com/users/lfu/received_events","type":"User","site_admin":false},"body":"That is how it is being used: https://github.com/ManageIQ/manageiq/blob/16c43457b788ae12d49929ce1e696fd1f3e445cb/app/models/miq_worker/runner.rb#L296","created_at":"2017-04-25T18:43:02Z","updated_at":"2017-04-25T18:43:02Z","html_url":"https://github.com/ManageIQ/manageiq/pull/14878#discussion_r113277748","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/14878","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/113277748"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/14878#discussion_r113277748"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/14878"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/14878","id":117519832,"html_url":"https://github.com/ManageIQ/manageiq/pull/14878","diff_url":"https://github.com/ManageIQ/manageiq/pull/14878.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/14878.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/14878","number":14878,"state":"open","locked":false,"title":"Use $log.log_hashes to filter out sensitive data.","user":{"login":"lfu","id":2593270,"avatar_url":"https://avatars0.githubusercontent.com/u/2593270?v=3","gravatar_id":"","url":"https://api.github.com/users/lfu","html_url":"https://github.com/lfu","followers_url":"https://api.github.com/users/lfu/followers","following_url":"https://api.github.com/users/lfu/following{/other_user}","gists_url":"https://api.github.com/users/lfu/gists{/gist_id}","starred_url":"https://api.github.com/users/lfu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lfu/subscriptions","organizations_url":"https://api.github.com/users/lfu/orgs","repos_url":"https://api.github.com/users/lfu/repos","events_url":"https://api.github.com/users/lfu/events{/privacy}","received_events_url":"https://api.github.com/users/lfu/received_events","type":"User","site_admin":false},"body":"Use $log.log_hashes to filter out sensitive data.\r\n\r\nDepends on [#manageiq-gems-pending/pull/135](https://github.com/ManageIQ/manageiq-gems-pending/pull/135).\r\n\r\n@miq-bot assign @gmcculloug \r\n@miq-bot add_label fine/yes","created_at":"2017-04-25T15:54:22Z","updated_at":"2017-04-25T18:43:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3ea1cbcf9045ce41e755711c09119459ffa97dc5","assignee":{"login":"gmcculloug","id":2591569,"avatar_url":"https://avatars3.githubusercontent.com/u/2591569?v=3","gravatar_id":"","url":"https://api.github.com/users/gmcculloug","html_url":"https://github.com/gmcculloug","followers_url":"https://api.github.com/users/gmcculloug/followers","following_url":"https://api.github.com/users/gmcculloug/following{/other_user}","gists_url":"https://api.github.com/users/gmcculloug/gists{/gist_id}","starred_url":"https://api.github.com/users/gmcculloug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmcculloug/subscriptions","organizations_url":"https://api.github.com/users/gmcculloug/orgs","repos_url":"https://api.github.com/users/gmcculloug/repos","events_url":"https://api.github.com/users/gmcculloug/events{/privacy}","received_events_url":"https://api.github.com/users/gmcculloug/received_events","type":"User","site_admin":false},"assignees":[{"login":"gmcculloug","id":2591569,"avatar_url":"https://avatars3.githubusercontent.com/u/2591569?v=3","gravatar_id":"","url":"https://api.github.com/users/gmcculloug","html_url":"https://github.com/gmcculloug","followers_url":"https://api.github.com/users/gmcculloug/followers","following_url":"https://api.github.com/users/gmcculloug/following{/other_user}","gists_url":"https://api.github.com/users/gmcculloug/gists{/gist_id}","starred_url":"https://api.github.com/users/gmcculloug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmcculloug/subscriptions","organizations_url":"https://api.github.com/users/gmcculloug/orgs","repos_url":"https://api.github.com/users/gmcculloug/repos","events_url":"https://api.github.com/users/gmcculloug/events{/privacy}","received_events_url":"https://api.github.com/users/gmcculloug/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/14878/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/14878/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/14878/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/e9f0154c98ec90c62ce63b12fbf5998734480859","head":{"label":"lfu:ansible_log_hashes","ref":"ansible_log_hashes","sha":"e9f0154c98ec90c62ce63b12fbf5998734480859","user":{"login":"lfu","id":2593270,"avatar_url":"https://avatars0.githubusercontent.com/u/2593270?v=3","gravatar_id":"","url":"https://api.github.com/users/lfu","html_url":"https://github.com/lfu","followers_url":"https://api.github.com/users/lfu/followers","following_url":"https://api.github.com/users/lfu/following{/other_user}","gists_url":"https://api.github.com/users/lfu/gists{/gist_id}","starred_url":"https://api.github.com/users/lfu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lfu/subscriptions","organizations_url":"https://api.github.com/users/lfu/orgs","repos_url":"https://api.github.com/users/lfu/repos","events_url":"https://api.github.com/users/lfu/events{/privacy}","received_events_url":"https://api.github.com/users/lfu/received_events","type":"User","site_admin":false},"repo":{"id":20816972,"name":"manageiq","full_name":"lfu/manageiq","owner":{"login":"lfu","id":2593270,"avatar_url":"https://avatars0.githubusercontent.com/u/2593270?v=3","gravatar_id":"","url":"https://api.github.com/users/lfu","html_url":"https://github.com/lfu","followers_url":"https://api.github.com/users/lfu/followers","following_url":"https://api.github.com/users/lfu/following{/other_user}","gists_url":"https://api.github.com/users/lfu/gists{/gist_id}","starred_url":"https://api.github.com/users/lfu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lfu/subscriptions","organizations_url":"https://api.github.com/users/lfu/orgs","repos_url":"https://api.github.com/users/lfu/repos","events_url":"https://api.github.com/users/lfu/events{/privacy}","received_events_url":"https://api.github.com/users/lfu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lfu/manageiq","description":"ManageIQ Cloud Management Platform","fork":true,"url":"https://api.github.com/repos/lfu/manageiq","forks_url":"https://api.github.com/repos/lfu/manageiq/forks","keys_url":"https://api.github.com/repos/lfu/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lfu/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lfu/manageiq/teams","hooks_url":"https://api.github.com/repos/lfu/manageiq/hooks","issue_events_url":"https://api.github.com/repos/lfu/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/lfu/manageiq/events","assignees_url":"https://api.github.com/repos/lfu/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/lfu/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/lfu/manageiq/tags","blobs_url":"https://api.github.com/repos/lfu/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lfu/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lfu/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/lfu/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lfu/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/lfu/manageiq/languages","stargazers_url":"https://api.github.com/repos/lfu/manageiq/stargazers","contributors_url":"https://api.github.com/repos/lfu/manageiq/contributors","subscribers_url":"https://api.github.com/repos/lfu/manageiq/subscribers","subscription_url":"https://api.github.com/repos/lfu/manageiq/subscription","commits_url":"https://api.github.com/repos/lfu/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/lfu/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/lfu/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/lfu/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/lfu/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/lfu/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lfu/manageiq/merges","archive_url":"https://api.github.com/repos/lfu/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lfu/manageiq/downloads","issues_url":"https://api.github.com/repos/lfu/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/lfu/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/lfu/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/lfu/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lfu/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/lfu/manageiq/releases{/id}","deployments_url":"https://api.github.com/repos/lfu/manageiq/deployments","created_at":"2014-06-13T20:33:14Z","updated_at":"2014-06-17T21:01:03Z","pushed_at":"2017-04-25T15:51:59Z","git_url":"git://github.com/lfu/manageiq.git","ssh_url":"git@github.com:lfu/manageiq.git","clone_url":"https://github.com/lfu/manageiq.git","svn_url":"https://github.com/lfu/manageiq","homepage":null,"size":173314,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"a3cafd81b6d1d579343374a32e2c3078e16d7816","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars3.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":20789757,"name":"manageiq","full_name":"ManageIQ/manageiq","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars3.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq","description":"ManageIQ Open-Source Management Platform","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq","forks_url":"https://api.github.com/repos/ManageIQ/manageiq/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq/releases{/id}","deployments_url":"https://api.github.com/repos/ManageIQ/manageiq/deployments","created_at":"2014-06-13T02:31:26Z","updated_at":"2017-04-24T11:15:06Z","pushed_at":"2017-04-25T18:35:57Z","git_url":"git://github.com/ManageIQ/manageiq.git","ssh_url":"git@github.com:ManageIQ/manageiq.git","clone_url":"https://github.com/ManageIQ/manageiq.git","svn_url":"https://github.com/ManageIQ/manageiq","homepage":"manageiq.org","size":194019,"stargazers_count":446,"watchers_count":446,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":461,"mirror_url":null,"open_issues_count":872,"forks":461,"open_issues":872,"watchers":446,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/14878"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/14878"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/14878"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/14878/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/14878/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/14878/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq/statuses/e9f0154c98ec90c62ce63b12fbf5998734480859"}}}}
{"actor":{"display_login":"lfu"}}