{"action":"closed","number":255,"pull_request":{"url":"https://api.github.com/repos/prescottprue/react-redux-firebase/pulls/255","id":137558763,"html_url":"https://github.com/prescottprue/react-redux-firebase/pull/255","diff_url":"https://github.com/prescottprue/react-redux-firebase/pull/255.diff","patch_url":"https://github.com/prescottprue/react-redux-firebase/pull/255.patch","issue_url":"https://api.github.com/repos/prescottprue/react-redux-firebase/issues/255","number":255,"state":"closed","locked":false,"title":"fix(reducer):  MERGE action added and SET action to reverted to v1 behavior","user":{"login":"marekolszewski","id":999594,"avatar_url":"https://avatars2.githubusercontent.com/u/999594?v=4","gravatar_id":"","url":"https://api.github.com/users/marekolszewski","html_url":"https://github.com/marekolszewski","followers_url":"https://api.github.com/users/marekolszewski/followers","following_url":"https://api.github.com/users/marekolszewski/following{/other_user}","gists_url":"https://api.github.com/users/marekolszewski/gists{/gist_id}","starred_url":"https://api.github.com/users/marekolszewski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marekolszewski/subscriptions","organizations_url":"https://api.github.com/users/marekolszewski/orgs","repos_url":"https://api.github.com/users/marekolszewski/repos","events_url":"https://api.github.com/users/marekolszewski/events{/privacy}","received_events_url":"https://api.github.com/users/marekolszewski/received_events","type":"User","site_admin":false},"body":"### Description\r\n\r\nI previously made the v2.0.0 SET action merge redux state data rather than overwrite it. This fixed a bug with multiple queries using population (and likely also issue #130), but it had unintended consequences for regular data subscriptions (most notably: if a field is deleted from a single object being subscribed to, it won't get deleted by the reducer).\r\n\r\nThis PR reverts that change and introduces a new MERGE action that keeps this merge semantics when useful. For now, I use MERGE when populating data only to fix the aforementioned bug. Down the road, it can be exposed to end-users as an option in a query. This may be useful, for example, when subscribing to collections of objects that one might not want to overwrite across different containers.\r\n\r\n### Check List\r\nIf not relevant to pull request, check off as complete\r\n\r\n- [X] All tests passing\r\n- [X] Docs updated with any changes or examples if applicable\r\n- [X] Added tests to ensure new feature(s) work properly\r\n\r\n\r\n","created_at":"2017-08-24T21:45:47Z","updated_at":"2017-08-27T22:07:36Z","closed_at":"2017-08-27T22:07:36Z","merged_at":"2017-08-27T22:07:36Z","merge_commit_sha":"f64239bb5473e27173307cd5e38a2fef0268c567","assignee":{"login":"prescottprue","id":2992224,"avatar_url":"https://avatars0.githubusercontent.com/u/2992224?v=4","gravatar_id":"","url":"https://api.github.com/users/prescottprue","html_url":"https://github.com/prescottprue","followers_url":"https://api.github.com/users/prescottprue/followers","following_url":"https://api.github.com/users/prescottprue/following{/other_user}","gists_url":"https://api.github.com/users/prescottprue/gists{/gist_id}","starred_url":"https://api.github.com/users/prescottprue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prescottprue/subscriptions","organizations_url":"https://api.github.com/users/prescottprue/orgs","repos_url":"https://api.github.com/users/prescottprue/repos","events_url":"https://api.github.com/users/prescottprue/events{/privacy}","received_events_url":"https://api.github.com/users/prescottprue/received_events","type":"User","site_admin":false},"assignees":[{"login":"prescottprue","id":2992224,"avatar_url":"https://avatars0.githubusercontent.com/u/2992224?v=4","gravatar_id":"","url":"https://api.github.com/users/prescottprue","html_url":"https://github.com/prescottprue","followers_url":"https://api.github.com/users/prescottprue/followers","following_url":"https://api.github.com/users/prescottprue/following{/other_user}","gists_url":"https://api.github.com/users/prescottprue/gists{/gist_id}","starred_url":"https://api.github.com/users/prescottprue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prescottprue/subscriptions","organizations_url":"https://api.github.com/users/prescottprue/orgs","repos_url":"https://api.github.com/users/prescottprue/repos","events_url":"https://api.github.com/users/prescottprue/events{/privacy}","received_events_url":"https://api.github.com/users/prescottprue/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/prescottprue/react-redux-firebase/pulls/255/commits","review_comments_url":"https://api.github.com/repos/prescottprue/react-redux-firebase/pulls/255/comments","review_comment_url":"https://api.github.com/repos/prescottprue/react-redux-firebase/pulls/comments{/number}","comments_url":"https://api.github.com/repos/prescottprue/react-redux-firebase/issues/255/comments","statuses_url":"https://api.github.com/repos/prescottprue/react-redux-firebase/statuses/42c2fb1953800aece5dbcac17b6c73dbcf423641","head":{"label":"marekolszewski:immutable-set","ref":"immutable-set","sha":"42c2fb1953800aece5dbcac17b6c73dbcf423641","user":{"login":"marekolszewski","id":999594,"avatar_url":"https://avatars2.githubusercontent.com/u/999594?v=4","gravatar_id":"","url":"https://api.github.com/users/marekolszewski","html_url":"https://github.com/marekolszewski","followers_url":"https://api.github.com/users/marekolszewski/followers","following_url":"https://api.github.com/users/marekolszewski/following{/other_user}","gists_url":"https://api.github.com/users/marekolszewski/gists{/gist_id}","starred_url":"https://api.github.com/users/marekolszewski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marekolszewski/subscriptions","organizations_url":"https://api.github.com/users/marekolszewski/orgs","repos_url":"https://api.github.com/users/marekolszewski/repos","events_url":"https://api.github.com/users/marekolszewski/events{/privacy}","received_events_url":"https://api.github.com/users/marekolszewski/received_events","type":"User","site_admin":false},"repo":{"id":99458971,"name":"react-redux-firebase","full_name":"marekolszewski/react-redux-firebase","owner":{"login":"marekolszewski","id":999594,"avatar_url":"https://avatars2.githubusercontent.com/u/999594?v=4","gravatar_id":"","url":"https://api.github.com/users/marekolszewski","html_url":"https://github.com/marekolszewski","followers_url":"https://api.github.com/users/marekolszewski/followers","following_url":"https://api.github.com/users/marekolszewski/following{/other_user}","gists_url":"https://api.github.com/users/marekolszewski/gists{/gist_id}","starred_url":"https://api.github.com/users/marekolszewski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marekolszewski/subscriptions","organizations_url":"https://api.github.com/users/marekolszewski/orgs","repos_url":"https://api.github.com/users/marekolszewski/repos","events_url":"https://api.github.com/users/marekolszewski/events{/privacy}","received_events_url":"https://api.github.com/users/marekolszewski/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/marekolszewski/react-redux-firebase","description":"Redux bindings for Firebase. Includes Higher Order Component for use with React.","fork":true,"url":"https://api.github.com/repos/marekolszewski/react-redux-firebase","forks_url":"https://api.github.com/repos/marekolszewski/react-redux-firebase/forks","keys_url":"https://api.github.com/repos/marekolszewski/react-redux-firebase/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marekolszewski/react-redux-firebase/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marekolszewski/react-redux-firebase/teams","hooks_url":"https://api.github.com/repos/marekolszewski/react-redux-firebase/hooks","issue_events_url":"https://api.github.com/repos/marekolszewski/react-redux-firebase/issues/events{/number}","events_url":"https://api.github.com/repos/marekolszewski/react-redux-firebase/events","assignees_url":"https://api.github.com/repos/marekolszewski/react-redux-firebase/assignees{/user}","branches_url":"https://api.github.com/repos/marekolszewski/react-redux-firebase/branches{/branch}","tags_url":"https://api.github.com/repos/marekolszewski/react-redux-firebase/tags","blobs_url":"https://api.github.com/repos/marekolszewski/react-redux-firebase/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marekolszewski/react-redux-firebase/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marekolszewski/react-redux-firebase/git/refs{/sha}","trees_url":"https://api.github.com/repos/marekolszewski/react-redux-firebase/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marekolszewski/react-redux-firebase/statuses/{sha}","languages_url":"https://api.github.com/repos/marekolszewski/react-redux-firebase/languages","stargazers_url":"https://api.github.com/repos/marekolszewski/react-redux-firebase/stargazers","contributors_url":"https://api.github.com/repos/marekolszewski/react-redux-firebase/contributors","subscribers_url":"https://api.github.com/repos/marekolszewski/react-redux-firebase/subscribers","subscription_url":"https://api.github.com/repos/marekolszewski/react-redux-firebase/subscription","commits_url":"https://api.github.com/repos/marekolszewski/react-redux-firebase/commits{/sha}","git_commits_url":"https://api.github.com/repos/marekolszewski/react-redux-firebase/git/commits{/sha}","comments_url":"https://api.github.com/repos/marekolszewski/react-redux-firebase/comments{/number}","issue_comment_url":"https://api.github.com/repos/marekolszewski/react-redux-firebase/issues/comments{/number}","contents_url":"https://api.github.com/repos/marekolszewski/react-redux-firebase/contents/{+path}","compare_url":"https://api.github.com/repos/marekolszewski/react-redux-firebase/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marekolszewski/react-redux-firebase/merges","archive_url":"https://api.github.com/repos/marekolszewski/react-redux-firebase/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marekolszewski/react-redux-firebase/downloads","issues_url":"https://api.github.com/repos/marekolszewski/react-redux-firebase/issues{/number}","pulls_url":"https://api.github.com/repos/marekolszewski/react-redux-firebase/pulls{/number}","milestones_url":"https://api.github.com/repos/marekolszewski/react-redux-firebase/milestones{/number}","notifications_url":"https://api.github.com/repos/marekolszewski/react-redux-firebase/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marekolszewski/react-redux-firebase/labels{/name}","releases_url":"https://api.github.com/repos/marekolszewski/react-redux-firebase/releases{/id}","deployments_url":"https://api.github.com/repos/marekolszewski/react-redux-firebase/deployments","created_at":"2017-08-06T02:18:04Z","updated_at":"2017-08-06T02:18:06Z","pushed_at":"2017-08-25T23:07:14Z","git_url":"git://github.com/marekolszewski/react-redux-firebase.git","ssh_url":"git@github.com:marekolszewski/react-redux-firebase.git","clone_url":"https://github.com/marekolszewski/react-redux-firebase.git","svn_url":"https://github.com/marekolszewski/react-redux-firebase","homepage":"http://react-redux-firebase.com","size":11596,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"prescottprue:v2.0.0-beta.8","ref":"v2.0.0-beta.8","sha":"568ab141949ec0b3b155b1caee7e3871a943945b","user":{"login":"prescottprue","id":2992224,"avatar_url":"https://avatars0.githubusercontent.com/u/2992224?v=4","gravatar_id":"","url":"https://api.github.com/users/prescottprue","html_url":"https://github.com/prescottprue","followers_url":"https://api.github.com/users/prescottprue/followers","following_url":"https://api.github.com/users/prescottprue/following{/other_user}","gists_url":"https://api.github.com/users/prescottprue/gists{/gist_id}","starred_url":"https://api.github.com/users/prescottprue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prescottprue/subscriptions","organizations_url":"https://api.github.com/users/prescottprue/orgs","repos_url":"https://api.github.com/users/prescottprue/repos","events_url":"https://api.github.com/users/prescottprue/events{/privacy}","received_events_url":"https://api.github.com/users/prescottprue/received_events","type":"User","site_admin":false},"repo":{"id":70860202,"name":"react-redux-firebase","full_name":"prescottprue/react-redux-firebase","owner":{"login":"prescottprue","id":2992224,"avatar_url":"https://avatars0.githubusercontent.com/u/2992224?v=4","gravatar_id":"","url":"https://api.github.com/users/prescottprue","html_url":"https://github.com/prescottprue","followers_url":"https://api.github.com/users/prescottprue/followers","following_url":"https://api.github.com/users/prescottprue/following{/other_user}","gists_url":"https://api.github.com/users/prescottprue/gists{/gist_id}","starred_url":"https://api.github.com/users/prescottprue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prescottprue/subscriptions","organizations_url":"https://api.github.com/users/prescottprue/orgs","repos_url":"https://api.github.com/users/prescottprue/repos","events_url":"https://api.github.com/users/prescottprue/events{/privacy}","received_events_url":"https://api.github.com/users/prescottprue/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/prescottprue/react-redux-firebase","description":"Redux bindings for Firebase. Includes Higher Order Component for use with React.","fork":false,"url":"https://api.github.com/repos/prescottprue/react-redux-firebase","forks_url":"https://api.github.com/repos/prescottprue/react-redux-firebase/forks","keys_url":"https://api.github.com/repos/prescottprue/react-redux-firebase/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prescottprue/react-redux-firebase/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prescottprue/react-redux-firebase/teams","hooks_url":"https://api.github.com/repos/prescottprue/react-redux-firebase/hooks","issue_events_url":"https://api.github.com/repos/prescottprue/react-redux-firebase/issues/events{/number}","events_url":"https://api.github.com/repos/prescottprue/react-redux-firebase/events","assignees_url":"https://api.github.com/repos/prescottprue/react-redux-firebase/assignees{/user}","branches_url":"https://api.github.com/repos/prescottprue/react-redux-firebase/branches{/branch}","tags_url":"https://api.github.com/repos/prescottprue/react-redux-firebase/tags","blobs_url":"https://api.github.com/repos/prescottprue/react-redux-firebase/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prescottprue/react-redux-firebase/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prescottprue/react-redux-firebase/git/refs{/sha}","trees_url":"https://api.github.com/repos/prescottprue/react-redux-firebase/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prescottprue/react-redux-firebase/statuses/{sha}","languages_url":"https://api.github.com/repos/prescottprue/react-redux-firebase/languages","stargazers_url":"https://api.github.com/repos/prescottprue/react-redux-firebase/stargazers","contributors_url":"https://api.github.com/repos/prescottprue/react-redux-firebase/contributors","subscribers_url":"https://api.github.com/repos/prescottprue/react-redux-firebase/subscribers","subscription_url":"https://api.github.com/repos/prescottprue/react-redux-firebase/subscription","commits_url":"https://api.github.com/repos/prescottprue/react-redux-firebase/commits{/sha}","git_commits_url":"https://api.github.com/repos/prescottprue/react-redux-firebase/git/commits{/sha}","comments_url":"https://api.github.com/repos/prescottprue/react-redux-firebase/comments{/number}","issue_comment_url":"https://api.github.com/repos/prescottprue/react-redux-firebase/issues/comments{/number}","contents_url":"https://api.github.com/repos/prescottprue/react-redux-firebase/contents/{+path}","compare_url":"https://api.github.com/repos/prescottprue/react-redux-firebase/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prescottprue/react-redux-firebase/merges","archive_url":"https://api.github.com/repos/prescottprue/react-redux-firebase/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prescottprue/react-redux-firebase/downloads","issues_url":"https://api.github.com/repos/prescottprue/react-redux-firebase/issues{/number}","pulls_url":"https://api.github.com/repos/prescottprue/react-redux-firebase/pulls{/number}","milestones_url":"https://api.github.com/repos/prescottprue/react-redux-firebase/milestones{/number}","notifications_url":"https://api.github.com/repos/prescottprue/react-redux-firebase/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prescottprue/react-redux-firebase/labels{/name}","releases_url":"https://api.github.com/repos/prescottprue/react-redux-firebase/releases{/id}","deployments_url":"https://api.github.com/repos/prescottprue/react-redux-firebase/deployments","created_at":"2016-10-14T00:47:53Z","updated_at":"2017-08-27T03:30:40Z","pushed_at":"2017-08-27T22:07:36Z","git_url":"git://github.com/prescottprue/react-redux-firebase.git","ssh_url":"git@github.com:prescottprue/react-redux-firebase.git","clone_url":"https://github.com/prescottprue/react-redux-firebase.git","svn_url":"https://github.com/prescottprue/react-redux-firebase","homepage":"http://react-redux-firebase.com","size":11634,"stargazers_count":450,"watchers_count":450,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":116,"mirror_url":null,"open_issues_count":22,"forks":116,"open_issues":22,"watchers":450,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prescottprue/react-redux-firebase/pulls/255"},"html":{"href":"https://github.com/prescottprue/react-redux-firebase/pull/255"},"issue":{"href":"https://api.github.com/repos/prescottprue/react-redux-firebase/issues/255"},"comments":{"href":"https://api.github.com/repos/prescottprue/react-redux-firebase/issues/255/comments"},"review_comments":{"href":"https://api.github.com/repos/prescottprue/react-redux-firebase/pulls/255/comments"},"review_comment":{"href":"https://api.github.com/repos/prescottprue/react-redux-firebase/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/prescottprue/react-redux-firebase/pulls/255/commits"},"statuses":{"href":"https://api.github.com/repos/prescottprue/react-redux-firebase/statuses/42c2fb1953800aece5dbcac17b6c73dbcf423641"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"prescottprue","id":2992224,"avatar_url":"https://avatars0.githubusercontent.com/u/2992224?v=4","gravatar_id":"","url":"https://api.github.com/users/prescottprue","html_url":"https://github.com/prescottprue","followers_url":"https://api.github.com/users/prescottprue/followers","following_url":"https://api.github.com/users/prescottprue/following{/other_user}","gists_url":"https://api.github.com/users/prescottprue/gists{/gist_id}","starred_url":"https://api.github.com/users/prescottprue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prescottprue/subscriptions","organizations_url":"https://api.github.com/users/prescottprue/orgs","repos_url":"https://api.github.com/users/prescottprue/repos","events_url":"https://api.github.com/users/prescottprue/events{/privacy}","received_events_url":"https://api.github.com/users/prescottprue/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":114,"deletions":9,"changed_files":4}}
{"actor":{"display_login":"prescottprue"}}