{"action":"created","issue":{"url":"https://api.github.com/repos/eslint/eslint/issues/8365","repository_url":"https://api.github.com/repos/eslint/eslint","labels_url":"https://api.github.com/repos/eslint/eslint/issues/8365/labels{/name}","comments_url":"https://api.github.com/repos/eslint/eslint/issues/8365/comments","events_url":"https://api.github.com/repos/eslint/eslint/issues/8365/events","html_url":"https://github.com/eslint/eslint/pull/8365","id":218287256,"number":8365,"title":"Breaking: Traverse into type annotations (fixes #7129)","user":{"login":"kaicataldo","id":7041728,"avatar_url":"https://avatars1.githubusercontent.com/u/7041728?v=3","gravatar_id":"","url":"https://api.github.com/users/kaicataldo","html_url":"https://github.com/kaicataldo","followers_url":"https://api.github.com/users/kaicataldo/followers","following_url":"https://api.github.com/users/kaicataldo/following{/other_user}","gists_url":"https://api.github.com/users/kaicataldo/gists{/gist_id}","starred_url":"https://api.github.com/users/kaicataldo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaicataldo/subscriptions","organizations_url":"https://api.github.com/users/kaicataldo/orgs","repos_url":"https://api.github.com/users/kaicataldo/repos","events_url":"https://api.github.com/users/kaicataldo/events{/privacy}","received_events_url":"https://api.github.com/users/kaicataldo/received_events","type":"User","site_admin":false},"labels":[{"id":131106229,"url":"https://api.github.com/repos/eslint/eslint/labels/accepted","name":"accepted","color":"0052cc","default":false},{"id":185518888,"url":"https://api.github.com/repos/eslint/eslint/labels/breaking","name":"breaking","color":"e11d21","default":false},{"id":82922548,"url":"https://api.github.com/repos/eslint/eslint/labels/core","name":"core","color":"c7def8","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2017-03-30T18:29:25Z","updated_at":"2017-04-02T20:55:22Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/eslint/eslint/pulls/8365","html_url":"https://github.com/eslint/eslint/pull/8365","diff_url":"https://github.com/eslint/eslint/pull/8365.diff","patch_url":"https://github.com/eslint/eslint/pull/8365.patch"},"body":"**What is the purpose of this pull request? (put an \"X\" next to item)**\r\n\r\n[ ] Documentation update\r\n[ ] Bug fix ([template](https://raw.githubusercontent.com/eslint/eslint/master/templates/bug-report.md))\r\n[ ] New rule ([template](https://raw.githubusercontent.com/eslint/eslint/master/templates/rule-proposal.md))\r\n[ ] Changes an existing rule ([template](https://raw.githubusercontent.com/eslint/eslint/master/templates/rule-change-proposal.md))\r\n[ ] Add autofixing to a rule\r\n[ ] Add a CLI option\r\n[x] Add something to the core\r\n[ ] Other, please explain:\r\n\r\n<!--\r\n    If the item you've checked above has a template, please paste the template questions below and answer them. (If this pull request is addressing an issue, you can just paste a link to the issue here instead.)\r\n-->\r\n\r\n<!--\r\n    Please ensure your pull request is ready:\r\n\r\n    - Read the pull request guide (http://eslint.org/docs/developer-guide/contributing/pull-requests)\r\n    - Include tests for this change\r\n    - Update documentation for this change (if appropriate)\r\n-->\r\n\r\n<!--\r\n    The following is required for all pull requests:\r\n-->\r\n\r\n**What changes did you make? (Give an overview)**\r\nFixes #7129. Modified `estraverse.VisitorKeys` to include type annotation traversal.\r\n\r\n**Is there anything you'd like reviewers to focus on?**\r\nDo you think these tests are adequate? I initially had a test that checked that the type annotations for params of a function would be visited, but then thought that seemed like overkill. Happy to add them back if consensus is to add them, though.\r\n"},"comment":{"url":"https://api.github.com/repos/eslint/eslint/issues/comments/291014425","html_url":"https://github.com/eslint/eslint/pull/8365#issuecomment-291014425","issue_url":"https://api.github.com/repos/eslint/eslint/issues/8365","id":291014425,"user":{"login":"kaicataldo","id":7041728,"avatar_url":"https://avatars1.githubusercontent.com/u/7041728?v=3","gravatar_id":"","url":"https://api.github.com/users/kaicataldo","html_url":"https://github.com/kaicataldo","followers_url":"https://api.github.com/users/kaicataldo/followers","following_url":"https://api.github.com/users/kaicataldo/following{/other_user}","gists_url":"https://api.github.com/users/kaicataldo/gists{/gist_id}","starred_url":"https://api.github.com/users/kaicataldo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaicataldo/subscriptions","organizations_url":"https://api.github.com/users/kaicataldo/orgs","repos_url":"https://api.github.com/users/kaicataldo/repos","events_url":"https://api.github.com/users/kaicataldo/events{/privacy}","received_events_url":"https://api.github.com/users/kaicataldo/received_events","type":"User","site_admin":false},"created_at":"2017-04-02T20:55:22Z","updated_at":"2017-04-02T20:55:22Z","body":"I believe the `Property` in estraverse is referencing [properties of object literals](https://github.com/estree/estree/blob/8ab62755743819a524c3d9a2537f34208ce26d68/es5.md#property). Babylon doesn't actually follow the ESTree spec, so there are a number of differences.\r\n\r\nWhen you say class properties do you mean the public class fields proposal? Just want to make sure we're on the same page."}}
{"actor":{"display_login":"kaicataldo"}}