{"action":"created","comment":{"url":"https://api.github.com/repos/Spirals-Team/librepair/pulls/comments/100016587","pull_request_review_id":20707745,"id":100016587,"diff_hunk":"@@ -26,22 +26,22 @@\n  * Created by urli on 26/12/2016.\n  */\n public class ProjectInspector {\n-    private final Logger logger = LoggerFactory.getLogger(ProjectInspector.class);\n+    protected final Logger logger = LoggerFactory.getLogger(ProjectInspector.class);","path":"repairnator/src/main/java/fr/inria/spirals/repairnator/process/ProjectInspector.java","position":5,"original_position":5,"commit_id":"2c29a635e1801454aa372d49425f2b65f10d5259","original_commit_id":"2c29a635e1801454aa372d49425f2b65f10d5259","user":{"login":"surli","id":1478232,"avatar_url":"https://avatars.githubusercontent.com/u/1478232?v=3","gravatar_id":"","url":"https://api.github.com/users/surli","html_url":"https://github.com/surli","followers_url":"https://api.github.com/users/surli/followers","following_url":"https://api.github.com/users/surli/following{/other_user}","gists_url":"https://api.github.com/users/surli/gists{/gist_id}","starred_url":"https://api.github.com/users/surli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/surli/subscriptions","organizations_url":"https://api.github.com/users/surli/orgs","repos_url":"https://api.github.com/users/surli/repos","events_url":"https://api.github.com/users/surli/events{/privacy}","received_events_url":"https://api.github.com/users/surli/received_events","type":"User","site_admin":false},"body":"I don't agree: Loggers are private to their class you should not use inheritance of logger, but create your own in the subclass.","created_at":"2017-02-08T08:55:10Z","updated_at":"2017-02-08T08:55:10Z","html_url":"https://github.com/Spirals-Team/librepair/pull/25#discussion_r100016587","pull_request_url":"https://api.github.com/repos/Spirals-Team/librepair/pulls/25","_links":{"self":{"href":"https://api.github.com/repos/Spirals-Team/librepair/pulls/comments/100016587"},"html":{"href":"https://github.com/Spirals-Team/librepair/pull/25#discussion_r100016587"},"pull_request":{"href":"https://api.github.com/repos/Spirals-Team/librepair/pulls/25"}}},"pull_request":{"url":"https://api.github.com/repos/Spirals-Team/librepair/pulls/25","id":105034613,"html_url":"https://github.com/Spirals-Team/librepair/pull/25","diff_url":"https://github.com/Spirals-Team/librepair/pull/25.diff","patch_url":"https://github.com/Spirals-Team/librepair/pull/25.patch","issue_url":"https://api.github.com/repos/Spirals-Team/librepair/issues/25","number":25,"state":"open","locked":false,"title":"Initial changes towards getting builds for the construction of the Bears.","user":{"login":"fermadeiral","id":8786002,"avatar_url":"https://avatars.githubusercontent.com/u/8786002?v=3","gravatar_id":"","url":"https://api.github.com/users/fermadeiral","html_url":"https://github.com/fermadeiral","followers_url":"https://api.github.com/users/fermadeiral/followers","following_url":"https://api.github.com/users/fermadeiral/following{/other_user}","gists_url":"https://api.github.com/users/fermadeiral/gists{/gist_id}","starred_url":"https://api.github.com/users/fermadeiral/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fermadeiral/subscriptions","organizations_url":"https://api.github.com/users/fermadeiral/orgs","repos_url":"https://api.github.com/users/fermadeiral/repos","events_url":"https://api.github.com/users/fermadeiral/events{/privacy}","received_events_url":"https://api.github.com/users/fermadeiral/received_events","type":"User","site_admin":false},"body":"These changes are the first ones towards getting builds for the construction of the Bears.\r\n\r\nFirst things first, I have changed the **ProjectScanner** class to also scan passing builds. The key changes consist in the \"addition\" of the ```getListOfBuildsFromProjectsByBuildStatus``` method, which is the previous ```getListOfFailingBuildFromProjects```, but now it receives the build status of interest. This build status is also used in the ```testBuild``` method, where the builds are actually tested for what we want---Simon wants failing builds, so the build status of interest is FAILED, while I want passing builds, so the build status of interest is PASSED.\r\n\r\nI added the **ProjectInspector4Bears** class, which extends **ProjectInspector**. For now, **ProjectInspector4Bears** does basically the same thing than **ProjectInspector**, just ignoring Nopol in its code (I have rewritten the ```processRepair``` method in **ProjectInspector4Bears** to ignore Nopol). The reason I created this class is because I think I will create different steps to inspect the projects (for example, I don't need **NopolRepair** step, but I think I will need other types of steps).\r\n\r\nIn the **Launcher** class, I put the variables related to input args as global ones, and I added some conditions using **RepairMode.FORBEARS**, a new mode, since for Bears there are some things that are not necessary (e.g., repair by Nopol). I also added the ```inspectBuildsForBears``` method, which is similar to the ```cloneAndRepair``` method, but for the **ProjectInspector4Bears**.\r\n\r\nIn the **GoogleSpreadSheetFactory** class, I only changed the **SPREADSHEET_ID** and the **GOOGLE_SECRET_PATH** to test my changes. We have to define a way to integrate this.","created_at":"2017-02-07T15:56:38Z","updated_at":"2017-02-08T08:55:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a7da42999be2d51123ba4a5bdbe05698dbb75aad","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Spirals-Team/librepair/pulls/25/commits","review_comments_url":"https://api.github.com/repos/Spirals-Team/librepair/pulls/25/comments","review_comment_url":"https://api.github.com/repos/Spirals-Team/librepair/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Spirals-Team/librepair/issues/25/comments","statuses_url":"https://api.github.com/repos/Spirals-Team/librepair/statuses/2c29a635e1801454aa372d49425f2b65f10d5259","head":{"label":"fermadeiral:first-pr","ref":"first-pr","sha":"2c29a635e1801454aa372d49425f2b65f10d5259","user":{"login":"fermadeiral","id":8786002,"avatar_url":"https://avatars.githubusercontent.com/u/8786002?v=3","gravatar_id":"","url":"https://api.github.com/users/fermadeiral","html_url":"https://github.com/fermadeiral","followers_url":"https://api.github.com/users/fermadeiral/followers","following_url":"https://api.github.com/users/fermadeiral/following{/other_user}","gists_url":"https://api.github.com/users/fermadeiral/gists{/gist_id}","starred_url":"https://api.github.com/users/fermadeiral/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fermadeiral/subscriptions","organizations_url":"https://api.github.com/users/fermadeiral/orgs","repos_url":"https://api.github.com/users/fermadeiral/repos","events_url":"https://api.github.com/users/fermadeiral/events{/privacy}","received_events_url":"https://api.github.com/users/fermadeiral/received_events","type":"User","site_admin":false},"repo":{"id":80627331,"name":"librepair","full_name":"fermadeiral/librepair","owner":{"login":"fermadeiral","id":8786002,"avatar_url":"https://avatars.githubusercontent.com/u/8786002?v=3","gravatar_id":"","url":"https://api.github.com/users/fermadeiral","html_url":"https://github.com/fermadeiral","followers_url":"https://api.github.com/users/fermadeiral/followers","following_url":"https://api.github.com/users/fermadeiral/following{/other_user}","gists_url":"https://api.github.com/users/fermadeiral/gists{/gist_id}","starred_url":"https://api.github.com/users/fermadeiral/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fermadeiral/subscriptions","organizations_url":"https://api.github.com/users/fermadeiral/orgs","repos_url":"https://api.github.com/users/fermadeiral/repos","events_url":"https://api.github.com/users/fermadeiral/events{/privacy}","received_events_url":"https://api.github.com/users/fermadeiral/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fermadeiral/librepair","description":"Source code for the LibRepair InriaHub / ADT ","fork":true,"url":"https://api.github.com/repos/fermadeiral/librepair","forks_url":"https://api.github.com/repos/fermadeiral/librepair/forks","keys_url":"https://api.github.com/repos/fermadeiral/librepair/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fermadeiral/librepair/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fermadeiral/librepair/teams","hooks_url":"https://api.github.com/repos/fermadeiral/librepair/hooks","issue_events_url":"https://api.github.com/repos/fermadeiral/librepair/issues/events{/number}","events_url":"https://api.github.com/repos/fermadeiral/librepair/events","assignees_url":"https://api.github.com/repos/fermadeiral/librepair/assignees{/user}","branches_url":"https://api.github.com/repos/fermadeiral/librepair/branches{/branch}","tags_url":"https://api.github.com/repos/fermadeiral/librepair/tags","blobs_url":"https://api.github.com/repos/fermadeiral/librepair/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fermadeiral/librepair/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fermadeiral/librepair/git/refs{/sha}","trees_url":"https://api.github.com/repos/fermadeiral/librepair/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fermadeiral/librepair/statuses/{sha}","languages_url":"https://api.github.com/repos/fermadeiral/librepair/languages","stargazers_url":"https://api.github.com/repos/fermadeiral/librepair/stargazers","contributors_url":"https://api.github.com/repos/fermadeiral/librepair/contributors","subscribers_url":"https://api.github.com/repos/fermadeiral/librepair/subscribers","subscription_url":"https://api.github.com/repos/fermadeiral/librepair/subscription","commits_url":"https://api.github.com/repos/fermadeiral/librepair/commits{/sha}","git_commits_url":"https://api.github.com/repos/fermadeiral/librepair/git/commits{/sha}","comments_url":"https://api.github.com/repos/fermadeiral/librepair/comments{/number}","issue_comment_url":"https://api.github.com/repos/fermadeiral/librepair/issues/comments{/number}","contents_url":"https://api.github.com/repos/fermadeiral/librepair/contents/{+path}","compare_url":"https://api.github.com/repos/fermadeiral/librepair/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fermadeiral/librepair/merges","archive_url":"https://api.github.com/repos/fermadeiral/librepair/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fermadeiral/librepair/downloads","issues_url":"https://api.github.com/repos/fermadeiral/librepair/issues{/number}","pulls_url":"https://api.github.com/repos/fermadeiral/librepair/pulls{/number}","milestones_url":"https://api.github.com/repos/fermadeiral/librepair/milestones{/number}","notifications_url":"https://api.github.com/repos/fermadeiral/librepair/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fermadeiral/librepair/labels{/name}","releases_url":"https://api.github.com/repos/fermadeiral/librepair/releases{/id}","deployments_url":"https://api.github.com/repos/fermadeiral/librepair/deployments","created_at":"2017-02-01T14:23:59Z","updated_at":"2017-02-01T14:24:00Z","pushed_at":"2017-02-07T15:52:34Z","git_url":"git://github.com/fermadeiral/librepair.git","ssh_url":"git@github.com:fermadeiral/librepair.git","clone_url":"https://github.com/fermadeiral/librepair.git","svn_url":"https://github.com/fermadeiral/librepair","homepage":null,"size":418,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Spirals-Team:master","ref":"master","sha":"bc25a6dca9e72abf3e2aeae0fe5c1b9460696b98","user":{"login":"Spirals-Team","id":9421796,"avatar_url":"https://avatars.githubusercontent.com/u/9421796?v=3","gravatar_id":"","url":"https://api.github.com/users/Spirals-Team","html_url":"https://github.com/Spirals-Team","followers_url":"https://api.github.com/users/Spirals-Team/followers","following_url":"https://api.github.com/users/Spirals-Team/following{/other_user}","gists_url":"https://api.github.com/users/Spirals-Team/gists{/gist_id}","starred_url":"https://api.github.com/users/Spirals-Team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Spirals-Team/subscriptions","organizations_url":"https://api.github.com/users/Spirals-Team/orgs","repos_url":"https://api.github.com/users/Spirals-Team/repos","events_url":"https://api.github.com/users/Spirals-Team/events{/privacy}","received_events_url":"https://api.github.com/users/Spirals-Team/received_events","type":"Organization","site_admin":false},"repo":{"id":77066767,"name":"librepair","full_name":"Spirals-Team/librepair","owner":{"login":"Spirals-Team","id":9421796,"avatar_url":"https://avatars.githubusercontent.com/u/9421796?v=3","gravatar_id":"","url":"https://api.github.com/users/Spirals-Team","html_url":"https://github.com/Spirals-Team","followers_url":"https://api.github.com/users/Spirals-Team/followers","following_url":"https://api.github.com/users/Spirals-Team/following{/other_user}","gists_url":"https://api.github.com/users/Spirals-Team/gists{/gist_id}","starred_url":"https://api.github.com/users/Spirals-Team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Spirals-Team/subscriptions","organizations_url":"https://api.github.com/users/Spirals-Team/orgs","repos_url":"https://api.github.com/users/Spirals-Team/repos","events_url":"https://api.github.com/users/Spirals-Team/events{/privacy}","received_events_url":"https://api.github.com/users/Spirals-Team/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Spirals-Team/librepair","description":"Source code for the LibRepair InriaHub / ADT ","fork":false,"url":"https://api.github.com/repos/Spirals-Team/librepair","forks_url":"https://api.github.com/repos/Spirals-Team/librepair/forks","keys_url":"https://api.github.com/repos/Spirals-Team/librepair/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Spirals-Team/librepair/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Spirals-Team/librepair/teams","hooks_url":"https://api.github.com/repos/Spirals-Team/librepair/hooks","issue_events_url":"https://api.github.com/repos/Spirals-Team/librepair/issues/events{/number}","events_url":"https://api.github.com/repos/Spirals-Team/librepair/events","assignees_url":"https://api.github.com/repos/Spirals-Team/librepair/assignees{/user}","branches_url":"https://api.github.com/repos/Spirals-Team/librepair/branches{/branch}","tags_url":"https://api.github.com/repos/Spirals-Team/librepair/tags","blobs_url":"https://api.github.com/repos/Spirals-Team/librepair/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Spirals-Team/librepair/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Spirals-Team/librepair/git/refs{/sha}","trees_url":"https://api.github.com/repos/Spirals-Team/librepair/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Spirals-Team/librepair/statuses/{sha}","languages_url":"https://api.github.com/repos/Spirals-Team/librepair/languages","stargazers_url":"https://api.github.com/repos/Spirals-Team/librepair/stargazers","contributors_url":"https://api.github.com/repos/Spirals-Team/librepair/contributors","subscribers_url":"https://api.github.com/repos/Spirals-Team/librepair/subscribers","subscription_url":"https://api.github.com/repos/Spirals-Team/librepair/subscription","commits_url":"https://api.github.com/repos/Spirals-Team/librepair/commits{/sha}","git_commits_url":"https://api.github.com/repos/Spirals-Team/librepair/git/commits{/sha}","comments_url":"https://api.github.com/repos/Spirals-Team/librepair/comments{/number}","issue_comment_url":"https://api.github.com/repos/Spirals-Team/librepair/issues/comments{/number}","contents_url":"https://api.github.com/repos/Spirals-Team/librepair/contents/{+path}","compare_url":"https://api.github.com/repos/Spirals-Team/librepair/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Spirals-Team/librepair/merges","archive_url":"https://api.github.com/repos/Spirals-Team/librepair/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Spirals-Team/librepair/downloads","issues_url":"https://api.github.com/repos/Spirals-Team/librepair/issues{/number}","pulls_url":"https://api.github.com/repos/Spirals-Team/librepair/pulls{/number}","milestones_url":"https://api.github.com/repos/Spirals-Team/librepair/milestones{/number}","notifications_url":"https://api.github.com/repos/Spirals-Team/librepair/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Spirals-Team/librepair/labels{/name}","releases_url":"https://api.github.com/repos/Spirals-Team/librepair/releases{/id}","deployments_url":"https://api.github.com/repos/Spirals-Team/librepair/deployments","created_at":"2016-12-21T16:12:54Z","updated_at":"2017-01-17T19:27:29Z","pushed_at":"2017-02-07T15:56:39Z","git_url":"git://github.com/Spirals-Team/librepair.git","ssh_url":"git@github.com:Spirals-Team/librepair.git","clone_url":"https://github.com/Spirals-Team/librepair.git","svn_url":"https://github.com/Spirals-Team/librepair","homepage":null,"size":424,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":11,"forks":1,"open_issues":11,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Spirals-Team/librepair/pulls/25"},"html":{"href":"https://github.com/Spirals-Team/librepair/pull/25"},"issue":{"href":"https://api.github.com/repos/Spirals-Team/librepair/issues/25"},"comments":{"href":"https://api.github.com/repos/Spirals-Team/librepair/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/Spirals-Team/librepair/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/Spirals-Team/librepair/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Spirals-Team/librepair/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/Spirals-Team/librepair/statuses/2c29a635e1801454aa372d49425f2b65f10d5259"}}}}
{"actor":{"display_login":"surli"}}