{"action":"created","issue":{"url":"https://api.github.com/repos/XPIR-team/XPIR/issues/35","repository_url":"https://api.github.com/repos/XPIR-team/XPIR","labels_url":"https://api.github.com/repos/XPIR-team/XPIR/issues/35/labels{/name}","comments_url":"https://api.github.com/repos/XPIR-team/XPIR/issues/35/comments","events_url":"https://api.github.com/repos/XPIR-team/XPIR/issues/35/events","html_url":"https://github.com/XPIR-team/XPIR/pull/35","id":231156761,"number":35,"title":"New security estimation - More secure","user":{"login":"nicolasAmat","id":28620859,"avatar_url":"https://avatars1.githubusercontent.com/u/28620859?v=3","gravatar_id":"","url":"https://api.github.com/users/nicolasAmat","html_url":"https://github.com/nicolasAmat","followers_url":"https://api.github.com/users/nicolasAmat/followers","following_url":"https://api.github.com/users/nicolasAmat/following{/other_user}","gists_url":"https://api.github.com/users/nicolasAmat/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolasAmat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolasAmat/subscriptions","organizations_url":"https://api.github.com/users/nicolasAmat/orgs","repos_url":"https://api.github.com/users/nicolasAmat/repos","events_url":"https://api.github.com/users/nicolasAmat/events{/privacy}","received_events_url":"https://api.github.com/users/nicolasAmat/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2017-05-24T20:09:52Z","updated_at":"2017-06-08T07:41:19Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/XPIR-team/XPIR/pulls/35","html_url":"https://github.com/XPIR-team/XPIR/pull/35","diff_url":"https://github.com/XPIR-team/XPIR/pull/35.diff","patch_url":"https://github.com/XPIR-team/XPIR/pull/35.patch"},"body":"Hi !\r\n\r\nThis PR changes the security estimation, and the security checking.\r\n\r\nRun the python script named 'security_estimator.py' with SageMath. \r\nIt will write new security estimations (number of bits of security) in the text file named 'security_estimations.txt'. But it's needed to run XPIR one time before to have XPIR parameters (n and q) ! This text file exists already if the user won't actualize the security (it permits to don't have the sage dependency...).\r\n\r\nNext in 'NFLLWE.cpp', the function 'estimateSecurity' reads parmaters in the text file and the function 'checkParamsSecure' calls the function 'estimateSecurity'. I needed to change the function 'findMaxModulusBitsize' to make it correct and faster.\r\n\r\nI wrote a readme file to explain how to use the security estimator.\r\n\r\nAll checks passed. And XPIR worked normally.\r\n\r\nI hope you will like it.\r\n\r\nThx !\r\n\r\nNicolas"},"comment":{"url":"https://api.github.com/repos/XPIR-team/XPIR/issues/comments/307025246","html_url":"https://github.com/XPIR-team/XPIR/pull/35#issuecomment-307025246","issue_url":"https://api.github.com/repos/XPIR-team/XPIR/issues/35","id":307025246,"user":{"login":"carlosaguilarmelchor","id":10304162,"avatar_url":"https://avatars0.githubusercontent.com/u/10304162?v=3","gravatar_id":"","url":"https://api.github.com/users/carlosaguilarmelchor","html_url":"https://github.com/carlosaguilarmelchor","followers_url":"https://api.github.com/users/carlosaguilarmelchor/followers","following_url":"https://api.github.com/users/carlosaguilarmelchor/following{/other_user}","gists_url":"https://api.github.com/users/carlosaguilarmelchor/gists{/gist_id}","starred_url":"https://api.github.com/users/carlosaguilarmelchor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlosaguilarmelchor/subscriptions","organizations_url":"https://api.github.com/users/carlosaguilarmelchor/orgs","repos_url":"https://api.github.com/users/carlosaguilarmelchor/repos","events_url":"https://api.github.com/users/carlosaguilarmelchor/events{/privacy}","received_events_url":"https://api.github.com/users/carlosaguilarmelchor/received_events","type":"User","site_admin":false},"created_at":"2017-06-08T07:41:19Z","updated_at":"2017-06-08T07:41:19Z","body":"Thank you !"}}
{"actor":{"display_login":"carlosaguilarmelchor"}}