{"action":"closed","number":92,"pull_request":{"url":"https://api.github.com/repos/commanded/eventstore/pulls/92","id":156109633,"html_url":"https://github.com/commanded/eventstore/pull/92","diff_url":"https://github.com/commanded/eventstore/pull/92.diff","patch_url":"https://github.com/commanded/eventstore/pull/92.patch","issue_url":"https://api.github.com/repos/commanded/eventstore/issues/92","number":92,"state":"closed","locked":false,"title":"Timeout issue when using EventStore.read_stream_forward\\3","user":{"login":"eamontaaffe","id":7099155,"avatar_url":"https://avatars3.githubusercontent.com/u/7099155?v=4","gravatar_id":"","url":"https://api.github.com/users/eamontaaffe","html_url":"https://github.com/eamontaaffe","followers_url":"https://api.github.com/users/eamontaaffe/followers","following_url":"https://api.github.com/users/eamontaaffe/following{/other_user}","gists_url":"https://api.github.com/users/eamontaaffe/gists{/gist_id}","starred_url":"https://api.github.com/users/eamontaaffe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eamontaaffe/subscriptions","organizations_url":"https://api.github.com/users/eamontaaffe/orgs","repos_url":"https://api.github.com/users/eamontaaffe/repos","events_url":"https://api.github.com/users/eamontaaffe/events{/privacy}","received_events_url":"https://api.github.com/users/eamontaaffe/received_events","type":"User","site_admin":false},"body":"I am having a few issues when trying to read a large number of events from a stream (> 1,000). Obviously, I can just reduce the number of events to read and spread it out over many requests. However sometimes, my internet isn't the best (Australian internet can be shit) and reading a small number of events (~100) also fails. \r\n\r\nI would like to add a parameter or configuration option to the `read_stream_forward` method so that we can increase the `GenServer.call` timeout. \r\n\r\nThe attached changes do it in a pretty crude manner, but it works for my purposes. I am open to suggestions on how we can clean it up. We should also add the timeout options to other similar methods such as `EventStore.read_all_streams_forward`.","created_at":"2017-12-04T04:46:43Z","updated_at":"2017-12-04T14:25:37Z","closed_at":"2017-12-04T14:25:37Z","merged_at":"2017-12-04T14:25:37Z","merge_commit_sha":"d7bb8c08c8c2210aa01a8bf4b5da8208c14e47c1","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/commanded/eventstore/pulls/92/commits","review_comments_url":"https://api.github.com/repos/commanded/eventstore/pulls/92/comments","review_comment_url":"https://api.github.com/repos/commanded/eventstore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/commanded/eventstore/issues/92/comments","statuses_url":"https://api.github.com/repos/commanded/eventstore/statuses/b027b5943bd3af5bd35f18d4f82b1612155a3025","head":{"label":"eamontaaffe:fix/timeout_read_stream_forward","ref":"fix/timeout_read_stream_forward","sha":"b027b5943bd3af5bd35f18d4f82b1612155a3025","user":{"login":"eamontaaffe","id":7099155,"avatar_url":"https://avatars3.githubusercontent.com/u/7099155?v=4","gravatar_id":"","url":"https://api.github.com/users/eamontaaffe","html_url":"https://github.com/eamontaaffe","followers_url":"https://api.github.com/users/eamontaaffe/followers","following_url":"https://api.github.com/users/eamontaaffe/following{/other_user}","gists_url":"https://api.github.com/users/eamontaaffe/gists{/gist_id}","starred_url":"https://api.github.com/users/eamontaaffe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eamontaaffe/subscriptions","organizations_url":"https://api.github.com/users/eamontaaffe/orgs","repos_url":"https://api.github.com/users/eamontaaffe/repos","events_url":"https://api.github.com/users/eamontaaffe/events{/privacy}","received_events_url":"https://api.github.com/users/eamontaaffe/received_events","type":"User","site_admin":false},"repo":{"id":104179520,"name":"eventstore","full_name":"eamontaaffe/eventstore","owner":{"login":"eamontaaffe","id":7099155,"avatar_url":"https://avatars3.githubusercontent.com/u/7099155?v=4","gravatar_id":"","url":"https://api.github.com/users/eamontaaffe","html_url":"https://github.com/eamontaaffe","followers_url":"https://api.github.com/users/eamontaaffe/followers","following_url":"https://api.github.com/users/eamontaaffe/following{/other_user}","gists_url":"https://api.github.com/users/eamontaaffe/gists{/gist_id}","starred_url":"https://api.github.com/users/eamontaaffe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eamontaaffe/subscriptions","organizations_url":"https://api.github.com/users/eamontaaffe/orgs","repos_url":"https://api.github.com/users/eamontaaffe/repos","events_url":"https://api.github.com/users/eamontaaffe/events{/privacy}","received_events_url":"https://api.github.com/users/eamontaaffe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eamontaaffe/eventstore","description":"CQRS event store using PostgreSQL for persistence","fork":true,"url":"https://api.github.com/repos/eamontaaffe/eventstore","forks_url":"https://api.github.com/repos/eamontaaffe/eventstore/forks","keys_url":"https://api.github.com/repos/eamontaaffe/eventstore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eamontaaffe/eventstore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eamontaaffe/eventstore/teams","hooks_url":"https://api.github.com/repos/eamontaaffe/eventstore/hooks","issue_events_url":"https://api.github.com/repos/eamontaaffe/eventstore/issues/events{/number}","events_url":"https://api.github.com/repos/eamontaaffe/eventstore/events","assignees_url":"https://api.github.com/repos/eamontaaffe/eventstore/assignees{/user}","branches_url":"https://api.github.com/repos/eamontaaffe/eventstore/branches{/branch}","tags_url":"https://api.github.com/repos/eamontaaffe/eventstore/tags","blobs_url":"https://api.github.com/repos/eamontaaffe/eventstore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eamontaaffe/eventstore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eamontaaffe/eventstore/git/refs{/sha}","trees_url":"https://api.github.com/repos/eamontaaffe/eventstore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eamontaaffe/eventstore/statuses/{sha}","languages_url":"https://api.github.com/repos/eamontaaffe/eventstore/languages","stargazers_url":"https://api.github.com/repos/eamontaaffe/eventstore/stargazers","contributors_url":"https://api.github.com/repos/eamontaaffe/eventstore/contributors","subscribers_url":"https://api.github.com/repos/eamontaaffe/eventstore/subscribers","subscription_url":"https://api.github.com/repos/eamontaaffe/eventstore/subscription","commits_url":"https://api.github.com/repos/eamontaaffe/eventstore/commits{/sha}","git_commits_url":"https://api.github.com/repos/eamontaaffe/eventstore/git/commits{/sha}","comments_url":"https://api.github.com/repos/eamontaaffe/eventstore/comments{/number}","issue_comment_url":"https://api.github.com/repos/eamontaaffe/eventstore/issues/comments{/number}","contents_url":"https://api.github.com/repos/eamontaaffe/eventstore/contents/{+path}","compare_url":"https://api.github.com/repos/eamontaaffe/eventstore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eamontaaffe/eventstore/merges","archive_url":"https://api.github.com/repos/eamontaaffe/eventstore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eamontaaffe/eventstore/downloads","issues_url":"https://api.github.com/repos/eamontaaffe/eventstore/issues{/number}","pulls_url":"https://api.github.com/repos/eamontaaffe/eventstore/pulls{/number}","milestones_url":"https://api.github.com/repos/eamontaaffe/eventstore/milestones{/number}","notifications_url":"https://api.github.com/repos/eamontaaffe/eventstore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eamontaaffe/eventstore/labels{/name}","releases_url":"https://api.github.com/repos/eamontaaffe/eventstore/releases{/id}","deployments_url":"https://api.github.com/repos/eamontaaffe/eventstore/deployments","created_at":"2017-09-20T07:10:58Z","updated_at":"2017-09-20T07:11:00Z","pushed_at":"2017-12-04T04:40:20Z","git_url":"git://github.com/eamontaaffe/eventstore.git","ssh_url":"git@github.com:eamontaaffe/eventstore.git","clone_url":"https://github.com/eamontaaffe/eventstore.git","svn_url":"https://github.com/eamontaaffe/eventstore","homepage":"","size":579,"stargazers_count":0,"watchers_count":0,"language":"Elixir","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"commanded:master","ref":"master","sha":"5d8b7b64cf7493716504702ae9d367ce1cd3ed97","user":{"login":"commanded","id":31540302,"avatar_url":"https://avatars1.githubusercontent.com/u/31540302?v=4","gravatar_id":"","url":"https://api.github.com/users/commanded","html_url":"https://github.com/commanded","followers_url":"https://api.github.com/users/commanded/followers","following_url":"https://api.github.com/users/commanded/following{/other_user}","gists_url":"https://api.github.com/users/commanded/gists{/gist_id}","starred_url":"https://api.github.com/users/commanded/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/commanded/subscriptions","organizations_url":"https://api.github.com/users/commanded/orgs","repos_url":"https://api.github.com/users/commanded/repos","events_url":"https://api.github.com/users/commanded/events{/privacy}","received_events_url":"https://api.github.com/users/commanded/received_events","type":"Organization","site_admin":false},"repo":{"id":52314174,"name":"eventstore","full_name":"commanded/eventstore","owner":{"login":"commanded","id":31540302,"avatar_url":"https://avatars1.githubusercontent.com/u/31540302?v=4","gravatar_id":"","url":"https://api.github.com/users/commanded","html_url":"https://github.com/commanded","followers_url":"https://api.github.com/users/commanded/followers","following_url":"https://api.github.com/users/commanded/following{/other_user}","gists_url":"https://api.github.com/users/commanded/gists{/gist_id}","starred_url":"https://api.github.com/users/commanded/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/commanded/subscriptions","organizations_url":"https://api.github.com/users/commanded/orgs","repos_url":"https://api.github.com/users/commanded/repos","events_url":"https://api.github.com/users/commanded/events{/privacy}","received_events_url":"https://api.github.com/users/commanded/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/commanded/eventstore","description":"CQRS event store using PostgreSQL for persistence","fork":false,"url":"https://api.github.com/repos/commanded/eventstore","forks_url":"https://api.github.com/repos/commanded/eventstore/forks","keys_url":"https://api.github.com/repos/commanded/eventstore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/commanded/eventstore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/commanded/eventstore/teams","hooks_url":"https://api.github.com/repos/commanded/eventstore/hooks","issue_events_url":"https://api.github.com/repos/commanded/eventstore/issues/events{/number}","events_url":"https://api.github.com/repos/commanded/eventstore/events","assignees_url":"https://api.github.com/repos/commanded/eventstore/assignees{/user}","branches_url":"https://api.github.com/repos/commanded/eventstore/branches{/branch}","tags_url":"https://api.github.com/repos/commanded/eventstore/tags","blobs_url":"https://api.github.com/repos/commanded/eventstore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/commanded/eventstore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/commanded/eventstore/git/refs{/sha}","trees_url":"https://api.github.com/repos/commanded/eventstore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/commanded/eventstore/statuses/{sha}","languages_url":"https://api.github.com/repos/commanded/eventstore/languages","stargazers_url":"https://api.github.com/repos/commanded/eventstore/stargazers","contributors_url":"https://api.github.com/repos/commanded/eventstore/contributors","subscribers_url":"https://api.github.com/repos/commanded/eventstore/subscribers","subscription_url":"https://api.github.com/repos/commanded/eventstore/subscription","commits_url":"https://api.github.com/repos/commanded/eventstore/commits{/sha}","git_commits_url":"https://api.github.com/repos/commanded/eventstore/git/commits{/sha}","comments_url":"https://api.github.com/repos/commanded/eventstore/comments{/number}","issue_comment_url":"https://api.github.com/repos/commanded/eventstore/issues/comments{/number}","contents_url":"https://api.github.com/repos/commanded/eventstore/contents/{+path}","compare_url":"https://api.github.com/repos/commanded/eventstore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/commanded/eventstore/merges","archive_url":"https://api.github.com/repos/commanded/eventstore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/commanded/eventstore/downloads","issues_url":"https://api.github.com/repos/commanded/eventstore/issues{/number}","pulls_url":"https://api.github.com/repos/commanded/eventstore/pulls{/number}","milestones_url":"https://api.github.com/repos/commanded/eventstore/milestones{/number}","notifications_url":"https://api.github.com/repos/commanded/eventstore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/commanded/eventstore/labels{/name}","releases_url":"https://api.github.com/repos/commanded/eventstore/releases{/id}","deployments_url":"https://api.github.com/repos/commanded/eventstore/deployments","created_at":"2016-02-22T23:31:46Z","updated_at":"2017-12-04T09:30:53Z","pushed_at":"2017-12-04T14:25:37Z","git_url":"git://github.com/commanded/eventstore.git","ssh_url":"git@github.com:commanded/eventstore.git","clone_url":"https://github.com/commanded/eventstore.git","svn_url":"https://github.com/commanded/eventstore","homepage":"","size":581,"stargazers_count":301,"watchers_count":301,"language":"Elixir","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":24,"open_issues":10,"watchers":301,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/commanded/eventstore/pulls/92"},"html":{"href":"https://github.com/commanded/eventstore/pull/92"},"issue":{"href":"https://api.github.com/repos/commanded/eventstore/issues/92"},"comments":{"href":"https://api.github.com/repos/commanded/eventstore/issues/92/comments"},"review_comments":{"href":"https://api.github.com/repos/commanded/eventstore/pulls/92/comments"},"review_comment":{"href":"https://api.github.com/repos/commanded/eventstore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/commanded/eventstore/pulls/92/commits"},"statuses":{"href":"https://api.github.com/repos/commanded/eventstore/statuses/b027b5943bd3af5bd35f18d4f82b1612155a3025"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"slashdotdash","id":3167,"avatar_url":"https://avatars3.githubusercontent.com/u/3167?v=4","gravatar_id":"","url":"https://api.github.com/users/slashdotdash","html_url":"https://github.com/slashdotdash","followers_url":"https://api.github.com/users/slashdotdash/followers","following_url":"https://api.github.com/users/slashdotdash/following{/other_user}","gists_url":"https://api.github.com/users/slashdotdash/gists{/gist_id}","starred_url":"https://api.github.com/users/slashdotdash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slashdotdash/subscriptions","organizations_url":"https://api.github.com/users/slashdotdash/orgs","repos_url":"https://api.github.com/users/slashdotdash/repos","events_url":"https://api.github.com/users/slashdotdash/events{/privacy}","received_events_url":"https://api.github.com/users/slashdotdash/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":4,"deletions":4,"changed_files":2}}
{"actor":{"display_login":"slashdotdash"}}