{"action":"created","issue":{"url":"https://api.github.com/repos/PAIR-code/deeplearnjs/issues/21","repository_url":"https://api.github.com/repos/PAIR-code/deeplearnjs","labels_url":"https://api.github.com/repos/PAIR-code/deeplearnjs/issues/21/labels{/name}","comments_url":"https://api.github.com/repos/PAIR-code/deeplearnjs/issues/21/comments","events_url":"https://api.github.com/repos/PAIR-code/deeplearnjs/issues/21/events","html_url":"https://github.com/PAIR-code/deeplearnjs/pull/21","id":249108264,"number":21,"title":"Add support for {1D,2D,3D} arrays in shader compiler and migrate math ops","user":{"login":"dsmilkov","id":2294279,"avatar_url":"https://avatars2.githubusercontent.com/u/2294279?v=4","gravatar_id":"","url":"https://api.github.com/users/dsmilkov","html_url":"https://github.com/dsmilkov","followers_url":"https://api.github.com/users/dsmilkov/followers","following_url":"https://api.github.com/users/dsmilkov/following{/other_user}","gists_url":"https://api.github.com/users/dsmilkov/gists{/gist_id}","starred_url":"https://api.github.com/users/dsmilkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsmilkov/subscriptions","organizations_url":"https://api.github.com/users/dsmilkov/orgs","repos_url":"https://api.github.com/users/dsmilkov/repos","events_url":"https://api.github.com/users/dsmilkov/events{/privacy}","received_events_url":"https://api.github.com/users/dsmilkov/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-08-09T17:44:29Z","updated_at":"2017-08-10T14:51:18Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/PAIR-code/deeplearnjs/pulls/21","html_url":"https://github.com/PAIR-code/deeplearnjs/pull/21","diff_url":"https://github.com/PAIR-code/deeplearnjs/pull/21.diff","patch_url":"https://github.com/PAIR-code/deeplearnjs/pull/21.patch"},"body":"Also migrate to logical sampling\r\n - unary_op and its children (relu,log,exp,tanh,...)\r\n - reduce_sum\r\n - logsumexp\r\n - min/max\r\n - arg min/max\r\n - argmaxequals\r\n\r\nThis is related to #9 and #18"},"comment":{"url":"https://api.github.com/repos/PAIR-code/deeplearnjs/issues/comments/321574935","html_url":"https://github.com/PAIR-code/deeplearnjs/pull/21#issuecomment-321574935","issue_url":"https://api.github.com/repos/PAIR-code/deeplearnjs/issues/21","id":321574935,"user":{"login":"dsmilkov","id":2294279,"avatar_url":"https://avatars2.githubusercontent.com/u/2294279?v=4","gravatar_id":"","url":"https://api.github.com/users/dsmilkov","html_url":"https://github.com/dsmilkov","followers_url":"https://api.github.com/users/dsmilkov/followers","following_url":"https://api.github.com/users/dsmilkov/following{/other_user}","gists_url":"https://api.github.com/users/dsmilkov/gists{/gist_id}","starred_url":"https://api.github.com/users/dsmilkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsmilkov/subscriptions","organizations_url":"https://api.github.com/users/dsmilkov/orgs","repos_url":"https://api.github.com/users/dsmilkov/repos","events_url":"https://api.github.com/users/dsmilkov/events{/privacy}","received_events_url":"https://api.github.com/users/dsmilkov/received_events","type":"User","site_admin":false},"created_at":"2017-08-10T14:51:18Z","updated_at":"2017-08-10T14:51:18Z","body":"\n\n\n\nReview status: 34 of 35 files reviewed at latest revision, 2 unresolved discussions.\n\n---\n\n*[src/math/math_gpu.ts, line 452 at r1](https://reviewable.io:443/reviews/pair-code/deeplearnjs/21#-KrAivXPW1xj4M25iWIZ:-KrBbb4ueE2qbfrhXeQ_:b-mios8r) ([raw file](https://github.com/pair-code/deeplearnjs/blob/b3051209fead4bf068a21b3b0f0041b62da3a69c/src/math/math_gpu.ts#L452)):*\n<details><summary><i>Previously, dsmilkov (Daniel Smilkov) wrote…</i></summary><blockquote>\n\n+1 to most points here. The only thing I'll push back is to not have the gpgpuprogram allocate the result ndarray itself, since we have shaders like copy which don't need to allocate a new texture. Also it decouples the way we allocate next textures (texture manager) from the shader logical.\n</blockquote></details>\n\nOne more thing: I'm not 100% sure about having runProgram(binary, program). I like runProgram(binary, args) since you compile it once and run it many times with different input/output arguments, without the need to construct new Program() every time.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/pair-code/deeplearnjs/21)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"dsmilkov"}}