{"action":"created","comment":{"url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/comments/126712768","pull_request_review_id":49222163,"id":126712768,"diff_hunk":"@@ -416,6 +432,17 @@ define([\n         };\n     }\n \n+    // converts x and y coordinates such that after updating for drawing buffer position, the correct coordinates will be used\n+    function pickPrimitiveEqualsWrapper(actual, expected, x, y, width, height) {\n+        width = width || 3;\n+        height = height || width || 3;\n+        x = x || 0;\n+        y = y || 0;\n+        var adjustedX = x + ((width - 1) * 0.5);\n+        var adjustedY = -1 * (y + ((height - 1) * 0.5) - actual._context.drawingBufferHeight);\n+        return pickPrimitiveEquals(actual, expected, adjustedX, adjustedY, width, height);","path":"Specs/addDefaultMatchers.js","position":35,"original_position":35,"commit_id":"2617c07561b316bb29f999c964b1f996a94d2902","original_commit_id":"2617c07561b316bb29f999c964b1f996a94d2902","user":{"login":"lilleyse","id":915398,"avatar_url":"https://avatars1.githubusercontent.com/u/915398?v=3","gravatar_id":"","url":"https://api.github.com/users/lilleyse","html_url":"https://github.com/lilleyse","followers_url":"https://api.github.com/users/lilleyse/followers","following_url":"https://api.github.com/users/lilleyse/following{/other_user}","gists_url":"https://api.github.com/users/lilleyse/gists{/gist_id}","starred_url":"https://api.github.com/users/lilleyse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lilleyse/subscriptions","organizations_url":"https://api.github.com/users/lilleyse/orgs","repos_url":"https://api.github.com/users/lilleyse/repos","events_url":"https://api.github.com/users/lilleyse/events{/privacy}","received_events_url":"https://api.github.com/users/lilleyse/received_events","type":"User","site_admin":false},"body":"Ok, I see now. By changing to test to pass in x and y values other than 0 should also work.","created_at":"2017-07-11T14:52:04Z","updated_at":"2017-07-11T14:52:04Z","html_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/5602#discussion_r126712768","pull_request_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/5602","_links":{"self":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/comments/126712768"},"html":{"href":"https://github.com/AnalyticalGraphicsInc/cesium/pull/5602#discussion_r126712768"},"pull_request":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/5602"}}},"pull_request":{"url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/5602","id":129698591,"html_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/5602","diff_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/5602.diff","patch_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/5602.patch","issue_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/5602","number":5602,"state":"open","locked":false,"title":"Added feature to modify scene pick search size","user":{"login":"jason-crow","id":25822334,"avatar_url":"https://avatars2.githubusercontent.com/u/25822334?v=3","gravatar_id":"","url":"https://api.github.com/users/jason-crow","html_url":"https://github.com/jason-crow","followers_url":"https://api.github.com/users/jason-crow/followers","following_url":"https://api.github.com/users/jason-crow/following{/other_user}","gists_url":"https://api.github.com/users/jason-crow/gists{/gist_id}","starred_url":"https://api.github.com/users/jason-crow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jason-crow/subscriptions","organizations_url":"https://api.github.com/users/jason-crow/orgs","repos_url":"https://api.github.com/users/jason-crow/repos","events_url":"https://api.github.com/users/jason-crow/events{/privacy}","received_events_url":"https://api.github.com/users/jason-crow/received_events","type":"User","site_admin":false},"body":"This feature adds two optional arguments to the scene pick method, width and height, which allows for modifying the bounding box used to search for matching primitives at the provided window position. If only width is provided, the height is set to the value provided for width. To verify this feature, I added two tests, one to pick a primitive at the extent of the pick size and one to fail to pick the primitive when the pick size is reduced from the same window position.\r\n\r\nThis feature makes it easier to select narrow primitives such as wireframes in a 2d scene.\r\n","created_at":"2017-07-10T14:50:43Z","updated_at":"2017-07-11T14:52:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d2c3214ce7fc480f0a5180cee46a5299f3ef5705","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/5602/commits","review_comments_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/5602/comments","review_comment_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/5602/comments","statuses_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/statuses/2617c07561b316bb29f999c964b1f996a94d2902","head":{"label":"jason-crow:master","ref":"master","sha":"2617c07561b316bb29f999c964b1f996a94d2902","user":{"login":"jason-crow","id":25822334,"avatar_url":"https://avatars2.githubusercontent.com/u/25822334?v=3","gravatar_id":"","url":"https://api.github.com/users/jason-crow","html_url":"https://github.com/jason-crow","followers_url":"https://api.github.com/users/jason-crow/followers","following_url":"https://api.github.com/users/jason-crow/following{/other_user}","gists_url":"https://api.github.com/users/jason-crow/gists{/gist_id}","starred_url":"https://api.github.com/users/jason-crow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jason-crow/subscriptions","organizations_url":"https://api.github.com/users/jason-crow/orgs","repos_url":"https://api.github.com/users/jason-crow/repos","events_url":"https://api.github.com/users/jason-crow/events{/privacy}","received_events_url":"https://api.github.com/users/jason-crow/received_events","type":"User","site_admin":false},"repo":{"id":95924557,"name":"cesium","full_name":"jason-crow/cesium","owner":{"login":"jason-crow","id":25822334,"avatar_url":"https://avatars2.githubusercontent.com/u/25822334?v=3","gravatar_id":"","url":"https://api.github.com/users/jason-crow","html_url":"https://github.com/jason-crow","followers_url":"https://api.github.com/users/jason-crow/followers","following_url":"https://api.github.com/users/jason-crow/following{/other_user}","gists_url":"https://api.github.com/users/jason-crow/gists{/gist_id}","starred_url":"https://api.github.com/users/jason-crow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jason-crow/subscriptions","organizations_url":"https://api.github.com/users/jason-crow/orgs","repos_url":"https://api.github.com/users/jason-crow/repos","events_url":"https://api.github.com/users/jason-crow/events{/privacy}","received_events_url":"https://api.github.com/users/jason-crow/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jason-crow/cesium","description":"An open-source JavaScript library for world-class 3D globes and maps :earth_americas:","fork":true,"url":"https://api.github.com/repos/jason-crow/cesium","forks_url":"https://api.github.com/repos/jason-crow/cesium/forks","keys_url":"https://api.github.com/repos/jason-crow/cesium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jason-crow/cesium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jason-crow/cesium/teams","hooks_url":"https://api.github.com/repos/jason-crow/cesium/hooks","issue_events_url":"https://api.github.com/repos/jason-crow/cesium/issues/events{/number}","events_url":"https://api.github.com/repos/jason-crow/cesium/events","assignees_url":"https://api.github.com/repos/jason-crow/cesium/assignees{/user}","branches_url":"https://api.github.com/repos/jason-crow/cesium/branches{/branch}","tags_url":"https://api.github.com/repos/jason-crow/cesium/tags","blobs_url":"https://api.github.com/repos/jason-crow/cesium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jason-crow/cesium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jason-crow/cesium/git/refs{/sha}","trees_url":"https://api.github.com/repos/jason-crow/cesium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jason-crow/cesium/statuses/{sha}","languages_url":"https://api.github.com/repos/jason-crow/cesium/languages","stargazers_url":"https://api.github.com/repos/jason-crow/cesium/stargazers","contributors_url":"https://api.github.com/repos/jason-crow/cesium/contributors","subscribers_url":"https://api.github.com/repos/jason-crow/cesium/subscribers","subscription_url":"https://api.github.com/repos/jason-crow/cesium/subscription","commits_url":"https://api.github.com/repos/jason-crow/cesium/commits{/sha}","git_commits_url":"https://api.github.com/repos/jason-crow/cesium/git/commits{/sha}","comments_url":"https://api.github.com/repos/jason-crow/cesium/comments{/number}","issue_comment_url":"https://api.github.com/repos/jason-crow/cesium/issues/comments{/number}","contents_url":"https://api.github.com/repos/jason-crow/cesium/contents/{+path}","compare_url":"https://api.github.com/repos/jason-crow/cesium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jason-crow/cesium/merges","archive_url":"https://api.github.com/repos/jason-crow/cesium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jason-crow/cesium/downloads","issues_url":"https://api.github.com/repos/jason-crow/cesium/issues{/number}","pulls_url":"https://api.github.com/repos/jason-crow/cesium/pulls{/number}","milestones_url":"https://api.github.com/repos/jason-crow/cesium/milestones{/number}","notifications_url":"https://api.github.com/repos/jason-crow/cesium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jason-crow/cesium/labels{/name}","releases_url":"https://api.github.com/repos/jason-crow/cesium/releases{/id}","deployments_url":"https://api.github.com/repos/jason-crow/cesium/deployments","created_at":"2017-06-30T21:16:11Z","updated_at":"2017-06-30T21:16:24Z","pushed_at":"2017-07-10T14:58:16Z","git_url":"git://github.com/jason-crow/cesium.git","ssh_url":"git@github.com:jason-crow/cesium.git","clone_url":"https://github.com/jason-crow/cesium.git","svn_url":"https://github.com/jason-crow/cesium","homepage":"http://cesiumjs.org/","size":270006,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"AnalyticalGraphicsInc:master","ref":"master","sha":"ed536070dd0d64ec36776371c8b81f8ed6aab6a7","user":{"login":"AnalyticalGraphicsInc","id":1490220,"avatar_url":"https://avatars3.githubusercontent.com/u/1490220?v=3","gravatar_id":"","url":"https://api.github.com/users/AnalyticalGraphicsInc","html_url":"https://github.com/AnalyticalGraphicsInc","followers_url":"https://api.github.com/users/AnalyticalGraphicsInc/followers","following_url":"https://api.github.com/users/AnalyticalGraphicsInc/following{/other_user}","gists_url":"https://api.github.com/users/AnalyticalGraphicsInc/gists{/gist_id}","starred_url":"https://api.github.com/users/AnalyticalGraphicsInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnalyticalGraphicsInc/subscriptions","organizations_url":"https://api.github.com/users/AnalyticalGraphicsInc/orgs","repos_url":"https://api.github.com/users/AnalyticalGraphicsInc/repos","events_url":"https://api.github.com/users/AnalyticalGraphicsInc/events{/privacy}","received_events_url":"https://api.github.com/users/AnalyticalGraphicsInc/received_events","type":"Organization","site_admin":false},"repo":{"id":3606738,"name":"cesium","full_name":"AnalyticalGraphicsInc/cesium","owner":{"login":"AnalyticalGraphicsInc","id":1490220,"avatar_url":"https://avatars3.githubusercontent.com/u/1490220?v=3","gravatar_id":"","url":"https://api.github.com/users/AnalyticalGraphicsInc","html_url":"https://github.com/AnalyticalGraphicsInc","followers_url":"https://api.github.com/users/AnalyticalGraphicsInc/followers","following_url":"https://api.github.com/users/AnalyticalGraphicsInc/following{/other_user}","gists_url":"https://api.github.com/users/AnalyticalGraphicsInc/gists{/gist_id}","starred_url":"https://api.github.com/users/AnalyticalGraphicsInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnalyticalGraphicsInc/subscriptions","organizations_url":"https://api.github.com/users/AnalyticalGraphicsInc/orgs","repos_url":"https://api.github.com/users/AnalyticalGraphicsInc/repos","events_url":"https://api.github.com/users/AnalyticalGraphicsInc/events{/privacy}","received_events_url":"https://api.github.com/users/AnalyticalGraphicsInc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AnalyticalGraphicsInc/cesium","description":"An open-source JavaScript library for world-class 3D globes and maps :earth_americas:","fork":false,"url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium","forks_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/forks","keys_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/teams","hooks_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/hooks","issue_events_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/events{/number}","events_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/events","assignees_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/assignees{/user}","branches_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/branches{/branch}","tags_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/tags","blobs_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/git/refs{/sha}","trees_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/statuses/{sha}","languages_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/languages","stargazers_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/stargazers","contributors_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/contributors","subscribers_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/subscribers","subscription_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/subscription","commits_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/commits{/sha}","git_commits_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/git/commits{/sha}","comments_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/comments{/number}","issue_comment_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/comments{/number}","contents_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/contents/{+path}","compare_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/merges","archive_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/downloads","issues_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues{/number}","pulls_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls{/number}","milestones_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/milestones{/number}","notifications_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/labels{/name}","releases_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/releases{/id}","deployments_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/deployments","created_at":"2012-03-02T22:27:14Z","updated_at":"2017-07-11T13:55:13Z","pushed_at":"2017-07-11T14:40:29Z","git_url":"git://github.com/AnalyticalGraphicsInc/cesium.git","ssh_url":"git@github.com:AnalyticalGraphicsInc/cesium.git","clone_url":"https://github.com/AnalyticalGraphicsInc/cesium.git","svn_url":"https://github.com/AnalyticalGraphicsInc/cesium","homepage":"http://cesiumjs.org/","size":270311,"stargazers_count":2303,"watchers_count":2303,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1116,"mirror_url":null,"open_issues_count":566,"forks":1116,"open_issues":566,"watchers":2303,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/5602"},"html":{"href":"https://github.com/AnalyticalGraphicsInc/cesium/pull/5602"},"issue":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/5602"},"comments":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/issues/5602/comments"},"review_comments":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/5602/comments"},"review_comment":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/5602/commits"},"statuses":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/statuses/2617c07561b316bb29f999c964b1f996a94d2902"}}}}
{"actor":{"display_login":"lilleyse"}}