{"action":"created","comment":{"url":"https://api.github.com/repos/ianstormtaylor/slate/pulls/comments/155452986","pull_request_review_id":81772406,"id":155452986,"diff_hunk":"@@ -80,6 +80,10 @@ function scrollToSelection(selection) {\n     }\n \n     selectionRect = range.getBoundingClientRect()\n+\n+    if (selectionRect.top == 0 && selectionRect.height == 0) {","path":"packages/slate-react/src/utils/scroll-to-selection.js","position":5,"original_position":5,"commit_id":"424cb8187e11644985f7d6c6a2462a7ed003f860","original_commit_id":"6f108202398e0b66cd7b8c3d0b44f48316e8c9b9","user":{"login":"maddrag0n","id":3743052,"avatar_url":"https://avatars3.githubusercontent.com/u/3743052?v=4","gravatar_id":"","url":"https://api.github.com/users/maddrag0n","html_url":"https://github.com/maddrag0n","followers_url":"https://api.github.com/users/maddrag0n/followers","following_url":"https://api.github.com/users/maddrag0n/following{/other_user}","gists_url":"https://api.github.com/users/maddrag0n/gists{/gist_id}","starred_url":"https://api.github.com/users/maddrag0n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maddrag0n/subscriptions","organizations_url":"https://api.github.com/users/maddrag0n/orgs","repos_url":"https://api.github.com/users/maddrag0n/repos","events_url":"https://api.github.com/users/maddrag0n/events{/privacy}","received_events_url":"https://api.github.com/users/maddrag0n/received_events","type":"User","site_admin":false},"body":"as slate apparently uses improper `==` checks  throughout the code base... ignore this maybe?","created_at":"2017-12-07T08:11:30Z","updated_at":"2017-12-07T08:11:30Z","html_url":"https://github.com/ianstormtaylor/slate/pull/1446#discussion_r155452986","pull_request_url":"https://api.github.com/repos/ianstormtaylor/slate/pulls/1446","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/ianstormtaylor/slate/pulls/comments/155452986"},"html":{"href":"https://github.com/ianstormtaylor/slate/pull/1446#discussion_r155452986"},"pull_request":{"href":"https://api.github.com/repos/ianstormtaylor/slate/pulls/1446"}},"in_reply_to_id":155451186},"pull_request":{"url":"https://api.github.com/repos/ianstormtaylor/slate/pulls/1446","id":156428271,"html_url":"https://github.com/ianstormtaylor/slate/pull/1446","diff_url":"https://github.com/ianstormtaylor/slate/pull/1446.diff","patch_url":"https://github.com/ianstormtaylor/slate/pull/1446.patch","issue_url":"https://api.github.com/repos/ianstormtaylor/slate/issues/1446","number":1446,"state":"open","locked":false,"title":"fix(scroll-to-selection): use getClientRects when selectionRect.top/height is still 0 in Safari","user":{"login":"zGrav","id":1788045,"avatar_url":"https://avatars1.githubusercontent.com/u/1788045?v=4","gravatar_id":"","url":"https://api.github.com/users/zGrav","html_url":"https://github.com/zGrav","followers_url":"https://api.github.com/users/zGrav/followers","following_url":"https://api.github.com/users/zGrav/following{/other_user}","gists_url":"https://api.github.com/users/zGrav/gists{/gist_id}","starred_url":"https://api.github.com/users/zGrav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zGrav/subscriptions","organizations_url":"https://api.github.com/users/zGrav/orgs","repos_url":"https://api.github.com/users/zGrav/repos","events_url":"https://api.github.com/users/zGrav/events{/privacy}","received_events_url":"https://api.github.com/users/zGrav/received_events","type":"User","site_admin":false},"body":"Tested on Safari 11.0.1 on OS X 10.13.1 with a scrollable container.\r\n\r\nFixes #1445 .","created_at":"2017-12-05T10:46:01Z","updated_at":"2017-12-07T08:11:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2f50c21a97a5d7dab3a98cbfcd2e1b956478b7a5","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ianstormtaylor/slate/pulls/1446/commits","review_comments_url":"https://api.github.com/repos/ianstormtaylor/slate/pulls/1446/comments","review_comment_url":"https://api.github.com/repos/ianstormtaylor/slate/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ianstormtaylor/slate/issues/1446/comments","statuses_url":"https://api.github.com/repos/ianstormtaylor/slate/statuses/424cb8187e11644985f7d6c6a2462a7ed003f860","head":{"label":"zGrav:feature/fix-newline-scrolljump-safari","ref":"feature/fix-newline-scrolljump-safari","sha":"424cb8187e11644985f7d6c6a2462a7ed003f860","user":{"login":"zGrav","id":1788045,"avatar_url":"https://avatars1.githubusercontent.com/u/1788045?v=4","gravatar_id":"","url":"https://api.github.com/users/zGrav","html_url":"https://github.com/zGrav","followers_url":"https://api.github.com/users/zGrav/followers","following_url":"https://api.github.com/users/zGrav/following{/other_user}","gists_url":"https://api.github.com/users/zGrav/gists{/gist_id}","starred_url":"https://api.github.com/users/zGrav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zGrav/subscriptions","organizations_url":"https://api.github.com/users/zGrav/orgs","repos_url":"https://api.github.com/users/zGrav/repos","events_url":"https://api.github.com/users/zGrav/events{/privacy}","received_events_url":"https://api.github.com/users/zGrav/received_events","type":"User","site_admin":false},"repo":{"id":113168530,"name":"slate","full_name":"zGrav/slate","owner":{"login":"zGrav","id":1788045,"avatar_url":"https://avatars1.githubusercontent.com/u/1788045?v=4","gravatar_id":"","url":"https://api.github.com/users/zGrav","html_url":"https://github.com/zGrav","followers_url":"https://api.github.com/users/zGrav/followers","following_url":"https://api.github.com/users/zGrav/following{/other_user}","gists_url":"https://api.github.com/users/zGrav/gists{/gist_id}","starred_url":"https://api.github.com/users/zGrav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zGrav/subscriptions","organizations_url":"https://api.github.com/users/zGrav/orgs","repos_url":"https://api.github.com/users/zGrav/repos","events_url":"https://api.github.com/users/zGrav/events{/privacy}","received_events_url":"https://api.github.com/users/zGrav/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zGrav/slate","description":"A completely customizable framework for building rich text editors.","fork":true,"url":"https://api.github.com/repos/zGrav/slate","forks_url":"https://api.github.com/repos/zGrav/slate/forks","keys_url":"https://api.github.com/repos/zGrav/slate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zGrav/slate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zGrav/slate/teams","hooks_url":"https://api.github.com/repos/zGrav/slate/hooks","issue_events_url":"https://api.github.com/repos/zGrav/slate/issues/events{/number}","events_url":"https://api.github.com/repos/zGrav/slate/events","assignees_url":"https://api.github.com/repos/zGrav/slate/assignees{/user}","branches_url":"https://api.github.com/repos/zGrav/slate/branches{/branch}","tags_url":"https://api.github.com/repos/zGrav/slate/tags","blobs_url":"https://api.github.com/repos/zGrav/slate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zGrav/slate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zGrav/slate/git/refs{/sha}","trees_url":"https://api.github.com/repos/zGrav/slate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zGrav/slate/statuses/{sha}","languages_url":"https://api.github.com/repos/zGrav/slate/languages","stargazers_url":"https://api.github.com/repos/zGrav/slate/stargazers","contributors_url":"https://api.github.com/repos/zGrav/slate/contributors","subscribers_url":"https://api.github.com/repos/zGrav/slate/subscribers","subscription_url":"https://api.github.com/repos/zGrav/slate/subscription","commits_url":"https://api.github.com/repos/zGrav/slate/commits{/sha}","git_commits_url":"https://api.github.com/repos/zGrav/slate/git/commits{/sha}","comments_url":"https://api.github.com/repos/zGrav/slate/comments{/number}","issue_comment_url":"https://api.github.com/repos/zGrav/slate/issues/comments{/number}","contents_url":"https://api.github.com/repos/zGrav/slate/contents/{+path}","compare_url":"https://api.github.com/repos/zGrav/slate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zGrav/slate/merges","archive_url":"https://api.github.com/repos/zGrav/slate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zGrav/slate/downloads","issues_url":"https://api.github.com/repos/zGrav/slate/issues{/number}","pulls_url":"https://api.github.com/repos/zGrav/slate/pulls{/number}","milestones_url":"https://api.github.com/repos/zGrav/slate/milestones{/number}","notifications_url":"https://api.github.com/repos/zGrav/slate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zGrav/slate/labels{/name}","releases_url":"https://api.github.com/repos/zGrav/slate/releases{/id}","deployments_url":"https://api.github.com/repos/zGrav/slate/deployments","created_at":"2017-12-05T10:36:27Z","updated_at":"2017-12-05T10:36:31Z","pushed_at":"2017-12-07T08:10:29Z","git_url":"git://github.com/zGrav/slate.git","ssh_url":"git@github.com:zGrav/slate.git","clone_url":"https://github.com/zGrav/slate.git","svn_url":"https://github.com/zGrav/slate","homepage":"http://slatejs.org","size":177931,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ianstormtaylor:master","ref":"master","sha":"cef33de6aaa6747d9a89b0cc0637b2684fc85726","user":{"login":"ianstormtaylor","id":311752,"avatar_url":"https://avatars0.githubusercontent.com/u/311752?v=4","gravatar_id":"","url":"https://api.github.com/users/ianstormtaylor","html_url":"https://github.com/ianstormtaylor","followers_url":"https://api.github.com/users/ianstormtaylor/followers","following_url":"https://api.github.com/users/ianstormtaylor/following{/other_user}","gists_url":"https://api.github.com/users/ianstormtaylor/gists{/gist_id}","starred_url":"https://api.github.com/users/ianstormtaylor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianstormtaylor/subscriptions","organizations_url":"https://api.github.com/users/ianstormtaylor/orgs","repos_url":"https://api.github.com/users/ianstormtaylor/repos","events_url":"https://api.github.com/users/ianstormtaylor/events{/privacy}","received_events_url":"https://api.github.com/users/ianstormtaylor/received_events","type":"User","site_admin":false},"repo":{"id":61412022,"name":"slate","full_name":"ianstormtaylor/slate","owner":{"login":"ianstormtaylor","id":311752,"avatar_url":"https://avatars0.githubusercontent.com/u/311752?v=4","gravatar_id":"","url":"https://api.github.com/users/ianstormtaylor","html_url":"https://github.com/ianstormtaylor","followers_url":"https://api.github.com/users/ianstormtaylor/followers","following_url":"https://api.github.com/users/ianstormtaylor/following{/other_user}","gists_url":"https://api.github.com/users/ianstormtaylor/gists{/gist_id}","starred_url":"https://api.github.com/users/ianstormtaylor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianstormtaylor/subscriptions","organizations_url":"https://api.github.com/users/ianstormtaylor/orgs","repos_url":"https://api.github.com/users/ianstormtaylor/repos","events_url":"https://api.github.com/users/ianstormtaylor/events{/privacy}","received_events_url":"https://api.github.com/users/ianstormtaylor/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ianstormtaylor/slate","description":"A completely customizable framework for building rich text editors.","fork":false,"url":"https://api.github.com/repos/ianstormtaylor/slate","forks_url":"https://api.github.com/repos/ianstormtaylor/slate/forks","keys_url":"https://api.github.com/repos/ianstormtaylor/slate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ianstormtaylor/slate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ianstormtaylor/slate/teams","hooks_url":"https://api.github.com/repos/ianstormtaylor/slate/hooks","issue_events_url":"https://api.github.com/repos/ianstormtaylor/slate/issues/events{/number}","events_url":"https://api.github.com/repos/ianstormtaylor/slate/events","assignees_url":"https://api.github.com/repos/ianstormtaylor/slate/assignees{/user}","branches_url":"https://api.github.com/repos/ianstormtaylor/slate/branches{/branch}","tags_url":"https://api.github.com/repos/ianstormtaylor/slate/tags","blobs_url":"https://api.github.com/repos/ianstormtaylor/slate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ianstormtaylor/slate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ianstormtaylor/slate/git/refs{/sha}","trees_url":"https://api.github.com/repos/ianstormtaylor/slate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ianstormtaylor/slate/statuses/{sha}","languages_url":"https://api.github.com/repos/ianstormtaylor/slate/languages","stargazers_url":"https://api.github.com/repos/ianstormtaylor/slate/stargazers","contributors_url":"https://api.github.com/repos/ianstormtaylor/slate/contributors","subscribers_url":"https://api.github.com/repos/ianstormtaylor/slate/subscribers","subscription_url":"https://api.github.com/repos/ianstormtaylor/slate/subscription","commits_url":"https://api.github.com/repos/ianstormtaylor/slate/commits{/sha}","git_commits_url":"https://api.github.com/repos/ianstormtaylor/slate/git/commits{/sha}","comments_url":"https://api.github.com/repos/ianstormtaylor/slate/comments{/number}","issue_comment_url":"https://api.github.com/repos/ianstormtaylor/slate/issues/comments{/number}","contents_url":"https://api.github.com/repos/ianstormtaylor/slate/contents/{+path}","compare_url":"https://api.github.com/repos/ianstormtaylor/slate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ianstormtaylor/slate/merges","archive_url":"https://api.github.com/repos/ianstormtaylor/slate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ianstormtaylor/slate/downloads","issues_url":"https://api.github.com/repos/ianstormtaylor/slate/issues{/number}","pulls_url":"https://api.github.com/repos/ianstormtaylor/slate/pulls{/number}","milestones_url":"https://api.github.com/repos/ianstormtaylor/slate/milestones{/number}","notifications_url":"https://api.github.com/repos/ianstormtaylor/slate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ianstormtaylor/slate/labels{/name}","releases_url":"https://api.github.com/repos/ianstormtaylor/slate/releases{/id}","deployments_url":"https://api.github.com/repos/ianstormtaylor/slate/deployments","created_at":"2016-06-18T01:52:42Z","updated_at":"2017-12-07T06:41:01Z","pushed_at":"2017-12-07T08:10:31Z","git_url":"git://github.com/ianstormtaylor/slate.git","ssh_url":"git@github.com:ianstormtaylor/slate.git","clone_url":"https://github.com/ianstormtaylor/slate.git","svn_url":"https://github.com/ianstormtaylor/slate","homepage":"http://slatejs.org","size":177930,"stargazers_count":6107,"watchers_count":6107,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":400,"mirror_url":null,"archived":false,"open_issues_count":153,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":400,"open_issues":153,"watchers":6107,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ianstormtaylor/slate/pulls/1446"},"html":{"href":"https://github.com/ianstormtaylor/slate/pull/1446"},"issue":{"href":"https://api.github.com/repos/ianstormtaylor/slate/issues/1446"},"comments":{"href":"https://api.github.com/repos/ianstormtaylor/slate/issues/1446/comments"},"review_comments":{"href":"https://api.github.com/repos/ianstormtaylor/slate/pulls/1446/comments"},"review_comment":{"href":"https://api.github.com/repos/ianstormtaylor/slate/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ianstormtaylor/slate/pulls/1446/commits"},"statuses":{"href":"https://api.github.com/repos/ianstormtaylor/slate/statuses/424cb8187e11644985f7d6c6a2462a7ed003f860"}},"author_association":"NONE"}}
{"actor":{"display_login":"maddrag0n"}}