{"action":"created","comment":{"url":"https://api.github.com/repos/bjorn/tiled/pulls/comments/130243636","pull_request_review_id":53097686,"id":130243636,"diff_hunk":"@@ -73,9 +82,50 @@ void NewTemplateDialog::updateTemplateName()\n void NewTemplateDialog::updateOkButton()\n {\n     QPushButton *okButton = mUi->buttonBox->button(QDialogButtonBox::Ok);\n-    QString templateName = mUi->templateName->text();\n \n+    bool noTemplateName = mUi->templateName->text().isEmpty();\n     int index = mUi->groupsComboBox->currentIndex();\n \n-    okButton->setEnabled(!templateName.isEmpty() && index != -1);\n+    okButton->setDisabled(noTemplateName || index==-1);","path":"src/tiled/newtemplatedialog.cpp","position":63,"original_position":35,"commit_id":"3b46d51566201c889aab8d6e7f1431271475ea25","original_commit_id":"0ca0650a126ba8c363369a4354a92f92661ab9bb","user":{"login":"bjorn","id":531764,"avatar_url":"https://avatars3.githubusercontent.com/u/531764?v=4","gravatar_id":"","url":"https://api.github.com/users/bjorn","html_url":"https://github.com/bjorn","followers_url":"https://api.github.com/users/bjorn/followers","following_url":"https://api.github.com/users/bjorn/following{/other_user}","gists_url":"https://api.github.com/users/bjorn/gists{/gist_id}","starred_url":"https://api.github.com/users/bjorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjorn/subscriptions","organizations_url":"https://api.github.com/users/bjorn/orgs","repos_url":"https://api.github.com/users/bjorn/repos","events_url":"https://api.github.com/users/bjorn/events{/privacy}","received_events_url":"https://api.github.com/users/bjorn/received_events","type":"User","site_admin":false},"body":"Coding style: Missing space around `==`","created_at":"2017-07-30T14:16:46Z","updated_at":"2017-07-30T14:49:08Z","html_url":"https://github.com/bjorn/tiled/pull/1666#discussion_r130243636","pull_request_url":"https://api.github.com/repos/bjorn/tiled/pulls/1666","_links":{"self":{"href":"https://api.github.com/repos/bjorn/tiled/pulls/comments/130243636"},"html":{"href":"https://github.com/bjorn/tiled/pull/1666#discussion_r130243636"},"pull_request":{"href":"https://api.github.com/repos/bjorn/tiled/pulls/1666"}}},"pull_request":{"url":"https://api.github.com/repos/bjorn/tiled/pulls/1666","id":132824046,"html_url":"https://github.com/bjorn/tiled/pull/1666","diff_url":"https://github.com/bjorn/tiled/pull/1666.diff","patch_url":"https://github.com/bjorn/tiled/pull/1666.patch","issue_url":"https://api.github.com/repos/bjorn/tiled/issues/1666","number":1666,"state":"open","locked":false,"title":"Templates dock enhancements","user":{"login":"thabetx","id":7282243,"avatar_url":"https://avatars3.githubusercontent.com/u/7282243?v=4","gravatar_id":"","url":"https://api.github.com/users/thabetx","html_url":"https://github.com/thabetx","followers_url":"https://api.github.com/users/thabetx/followers","following_url":"https://api.github.com/users/thabetx/following{/other_user}","gists_url":"https://api.github.com/users/thabetx/gists{/gist_id}","starred_url":"https://api.github.com/users/thabetx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thabetx/subscriptions","organizations_url":"https://api.github.com/users/thabetx/orgs","repos_url":"https://api.github.com/users/thabetx/repos","events_url":"https://api.github.com/users/thabetx/events{/privacy}","received_events_url":"https://api.github.com/users/thabetx/received_events","type":"User","site_admin":false},"body":"This PR adds some convenience features to the templates dock and template saving.","created_at":"2017-07-27T19:13:00Z","updated_at":"2017-07-30T14:49:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3aab0ad2f85ff949eade7a37761e876902e7f390","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/bjorn/tiled/pulls/1666/commits","review_comments_url":"https://api.github.com/repos/bjorn/tiled/pulls/1666/comments","review_comment_url":"https://api.github.com/repos/bjorn/tiled/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bjorn/tiled/issues/1666/comments","statuses_url":"https://api.github.com/repos/bjorn/tiled/statuses/3b46d51566201c889aab8d6e7f1431271475ea25","head":{"label":"thabetx:templates-dock-enhancements","ref":"templates-dock-enhancements","sha":"3b46d51566201c889aab8d6e7f1431271475ea25","user":{"login":"thabetx","id":7282243,"avatar_url":"https://avatars3.githubusercontent.com/u/7282243?v=4","gravatar_id":"","url":"https://api.github.com/users/thabetx","html_url":"https://github.com/thabetx","followers_url":"https://api.github.com/users/thabetx/followers","following_url":"https://api.github.com/users/thabetx/following{/other_user}","gists_url":"https://api.github.com/users/thabetx/gists{/gist_id}","starred_url":"https://api.github.com/users/thabetx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thabetx/subscriptions","organizations_url":"https://api.github.com/users/thabetx/orgs","repos_url":"https://api.github.com/users/thabetx/repos","events_url":"https://api.github.com/users/thabetx/events{/privacy}","received_events_url":"https://api.github.com/users/thabetx/received_events","type":"User","site_admin":false},"repo":{"id":85113778,"name":"tiled","full_name":"thabetx/tiled","owner":{"login":"thabetx","id":7282243,"avatar_url":"https://avatars3.githubusercontent.com/u/7282243?v=4","gravatar_id":"","url":"https://api.github.com/users/thabetx","html_url":"https://github.com/thabetx","followers_url":"https://api.github.com/users/thabetx/followers","following_url":"https://api.github.com/users/thabetx/following{/other_user}","gists_url":"https://api.github.com/users/thabetx/gists{/gist_id}","starred_url":"https://api.github.com/users/thabetx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thabetx/subscriptions","organizations_url":"https://api.github.com/users/thabetx/orgs","repos_url":"https://api.github.com/users/thabetx/repos","events_url":"https://api.github.com/users/thabetx/events{/privacy}","received_events_url":"https://api.github.com/users/thabetx/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thabetx/tiled","description":"A generic tile map editor","fork":true,"url":"https://api.github.com/repos/thabetx/tiled","forks_url":"https://api.github.com/repos/thabetx/tiled/forks","keys_url":"https://api.github.com/repos/thabetx/tiled/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thabetx/tiled/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thabetx/tiled/teams","hooks_url":"https://api.github.com/repos/thabetx/tiled/hooks","issue_events_url":"https://api.github.com/repos/thabetx/tiled/issues/events{/number}","events_url":"https://api.github.com/repos/thabetx/tiled/events","assignees_url":"https://api.github.com/repos/thabetx/tiled/assignees{/user}","branches_url":"https://api.github.com/repos/thabetx/tiled/branches{/branch}","tags_url":"https://api.github.com/repos/thabetx/tiled/tags","blobs_url":"https://api.github.com/repos/thabetx/tiled/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thabetx/tiled/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thabetx/tiled/git/refs{/sha}","trees_url":"https://api.github.com/repos/thabetx/tiled/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thabetx/tiled/statuses/{sha}","languages_url":"https://api.github.com/repos/thabetx/tiled/languages","stargazers_url":"https://api.github.com/repos/thabetx/tiled/stargazers","contributors_url":"https://api.github.com/repos/thabetx/tiled/contributors","subscribers_url":"https://api.github.com/repos/thabetx/tiled/subscribers","subscription_url":"https://api.github.com/repos/thabetx/tiled/subscription","commits_url":"https://api.github.com/repos/thabetx/tiled/commits{/sha}","git_commits_url":"https://api.github.com/repos/thabetx/tiled/git/commits{/sha}","comments_url":"https://api.github.com/repos/thabetx/tiled/comments{/number}","issue_comment_url":"https://api.github.com/repos/thabetx/tiled/issues/comments{/number}","contents_url":"https://api.github.com/repos/thabetx/tiled/contents/{+path}","compare_url":"https://api.github.com/repos/thabetx/tiled/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thabetx/tiled/merges","archive_url":"https://api.github.com/repos/thabetx/tiled/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thabetx/tiled/downloads","issues_url":"https://api.github.com/repos/thabetx/tiled/issues{/number}","pulls_url":"https://api.github.com/repos/thabetx/tiled/pulls{/number}","milestones_url":"https://api.github.com/repos/thabetx/tiled/milestones{/number}","notifications_url":"https://api.github.com/repos/thabetx/tiled/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thabetx/tiled/labels{/name}","releases_url":"https://api.github.com/repos/thabetx/tiled/releases{/id}","deployments_url":"https://api.github.com/repos/thabetx/tiled/deployments","created_at":"2017-03-15T19:39:29Z","updated_at":"2017-03-15T19:39:33Z","pushed_at":"2017-07-30T08:31:53Z","git_url":"git://github.com/thabetx/tiled.git","ssh_url":"git@github.com:thabetx/tiled.git","clone_url":"https://github.com/thabetx/tiled.git","svn_url":"https://github.com/thabetx/tiled","homepage":"http://www.mapeditor.org/","size":25021,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bjorn:wip/templates","ref":"wip/templates","sha":"d141b8701b43a3f452644c97e4aac54e64b8a341","user":{"login":"bjorn","id":531764,"avatar_url":"https://avatars3.githubusercontent.com/u/531764?v=4","gravatar_id":"","url":"https://api.github.com/users/bjorn","html_url":"https://github.com/bjorn","followers_url":"https://api.github.com/users/bjorn/followers","following_url":"https://api.github.com/users/bjorn/following{/other_user}","gists_url":"https://api.github.com/users/bjorn/gists{/gist_id}","starred_url":"https://api.github.com/users/bjorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjorn/subscriptions","organizations_url":"https://api.github.com/users/bjorn/orgs","repos_url":"https://api.github.com/users/bjorn/repos","events_url":"https://api.github.com/users/bjorn/events{/privacy}","received_events_url":"https://api.github.com/users/bjorn/received_events","type":"User","site_admin":false},"repo":{"id":1418150,"name":"tiled","full_name":"bjorn/tiled","owner":{"login":"bjorn","id":531764,"avatar_url":"https://avatars3.githubusercontent.com/u/531764?v=4","gravatar_id":"","url":"https://api.github.com/users/bjorn","html_url":"https://github.com/bjorn","followers_url":"https://api.github.com/users/bjorn/followers","following_url":"https://api.github.com/users/bjorn/following{/other_user}","gists_url":"https://api.github.com/users/bjorn/gists{/gist_id}","starred_url":"https://api.github.com/users/bjorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjorn/subscriptions","organizations_url":"https://api.github.com/users/bjorn/orgs","repos_url":"https://api.github.com/users/bjorn/repos","events_url":"https://api.github.com/users/bjorn/events{/privacy}","received_events_url":"https://api.github.com/users/bjorn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bjorn/tiled","description":"A generic tile map editor","fork":false,"url":"https://api.github.com/repos/bjorn/tiled","forks_url":"https://api.github.com/repos/bjorn/tiled/forks","keys_url":"https://api.github.com/repos/bjorn/tiled/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bjorn/tiled/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bjorn/tiled/teams","hooks_url":"https://api.github.com/repos/bjorn/tiled/hooks","issue_events_url":"https://api.github.com/repos/bjorn/tiled/issues/events{/number}","events_url":"https://api.github.com/repos/bjorn/tiled/events","assignees_url":"https://api.github.com/repos/bjorn/tiled/assignees{/user}","branches_url":"https://api.github.com/repos/bjorn/tiled/branches{/branch}","tags_url":"https://api.github.com/repos/bjorn/tiled/tags","blobs_url":"https://api.github.com/repos/bjorn/tiled/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bjorn/tiled/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bjorn/tiled/git/refs{/sha}","trees_url":"https://api.github.com/repos/bjorn/tiled/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bjorn/tiled/statuses/{sha}","languages_url":"https://api.github.com/repos/bjorn/tiled/languages","stargazers_url":"https://api.github.com/repos/bjorn/tiled/stargazers","contributors_url":"https://api.github.com/repos/bjorn/tiled/contributors","subscribers_url":"https://api.github.com/repos/bjorn/tiled/subscribers","subscription_url":"https://api.github.com/repos/bjorn/tiled/subscription","commits_url":"https://api.github.com/repos/bjorn/tiled/commits{/sha}","git_commits_url":"https://api.github.com/repos/bjorn/tiled/git/commits{/sha}","comments_url":"https://api.github.com/repos/bjorn/tiled/comments{/number}","issue_comment_url":"https://api.github.com/repos/bjorn/tiled/issues/comments{/number}","contents_url":"https://api.github.com/repos/bjorn/tiled/contents/{+path}","compare_url":"https://api.github.com/repos/bjorn/tiled/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bjorn/tiled/merges","archive_url":"https://api.github.com/repos/bjorn/tiled/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bjorn/tiled/downloads","issues_url":"https://api.github.com/repos/bjorn/tiled/issues{/number}","pulls_url":"https://api.github.com/repos/bjorn/tiled/pulls{/number}","milestones_url":"https://api.github.com/repos/bjorn/tiled/milestones{/number}","notifications_url":"https://api.github.com/repos/bjorn/tiled/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bjorn/tiled/labels{/name}","releases_url":"https://api.github.com/repos/bjorn/tiled/releases{/id}","deployments_url":"https://api.github.com/repos/bjorn/tiled/deployments","created_at":"2011-02-27T15:18:22Z","updated_at":"2017-07-30T07:36:58Z","pushed_at":"2017-07-30T09:13:56Z","git_url":"git://github.com/bjorn/tiled.git","ssh_url":"git@github.com:bjorn/tiled.git","clone_url":"https://github.com/bjorn/tiled.git","svn_url":"https://github.com/bjorn/tiled","homepage":"http://www.mapeditor.org/","size":25865,"stargazers_count":4835,"watchers_count":4835,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1036,"mirror_url":null,"open_issues_count":364,"forks":1036,"open_issues":364,"watchers":4835,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bjorn/tiled/pulls/1666"},"html":{"href":"https://github.com/bjorn/tiled/pull/1666"},"issue":{"href":"https://api.github.com/repos/bjorn/tiled/issues/1666"},"comments":{"href":"https://api.github.com/repos/bjorn/tiled/issues/1666/comments"},"review_comments":{"href":"https://api.github.com/repos/bjorn/tiled/pulls/1666/comments"},"review_comment":{"href":"https://api.github.com/repos/bjorn/tiled/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bjorn/tiled/pulls/1666/commits"},"statuses":{"href":"https://api.github.com/repos/bjorn/tiled/statuses/3b46d51566201c889aab8d6e7f1431271475ea25"}}}}
{"actor":{"display_login":"bjorn"}}