{"action":"created","comment":{"url":"https://api.github.com/repos/analogdevicesinc/rfsom-box-gui/pulls/comments/139228368","pull_request_review_id":63136976,"id":139228368,"diff_hunk":"@@ -2,3 +2,6 @@\n \n PID=$(pidof modemd)\n kill -9 $PID \n+\n+PID=$(pidof wpa_supplicant)\n+kill -9 $PID ","path":"tun_tap/kill_modem.sh","position":6,"original_position":6,"commit_id":"d87c862b5b13ba0a27dbefc30b828232adc72b86","original_commit_id":"cdec3268a1f9a024721e48be6cca8343926abd1f","user":{"login":"emaclean-adi","id":29780300,"avatar_url":"https://avatars2.githubusercontent.com/u/29780300?v=4","gravatar_id":"","url":"https://api.github.com/users/emaclean-adi","html_url":"https://github.com/emaclean-adi","followers_url":"https://api.github.com/users/emaclean-adi/followers","following_url":"https://api.github.com/users/emaclean-adi/following{/other_user}","gists_url":"https://api.github.com/users/emaclean-adi/gists{/gist_id}","starred_url":"https://api.github.com/users/emaclean-adi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emaclean-adi/subscriptions","organizations_url":"https://api.github.com/users/emaclean-adi/orgs","repos_url":"https://api.github.com/users/emaclean-adi/repos","events_url":"https://api.github.com/users/emaclean-adi/events{/privacy}","received_events_url":"https://api.github.com/users/emaclean-adi/received_events","type":"User","site_admin":false},"body":"Yes I meant to add that as well. wpa_supplicant should stop running when you stop the modem since it requires the adi_radio device","created_at":"2017-09-15T19:10:13Z","updated_at":"2017-09-15T19:10:13Z","html_url":"https://github.com/analogdevicesinc/rfsom-box-gui/pull/2#discussion_r139228368","pull_request_url":"https://api.github.com/repos/analogdevicesinc/rfsom-box-gui/pulls/2","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/analogdevicesinc/rfsom-box-gui/pulls/comments/139228368"},"html":{"href":"https://github.com/analogdevicesinc/rfsom-box-gui/pull/2#discussion_r139228368"},"pull_request":{"href":"https://api.github.com/repos/analogdevicesinc/rfsom-box-gui/pulls/2"}},"in_reply_to_id":139226444},"pull_request":{"url":"https://api.github.com/repos/analogdevicesinc/rfsom-box-gui/pulls/2","id":141376497,"html_url":"https://github.com/analogdevicesinc/rfsom-box-gui/pull/2","diff_url":"https://github.com/analogdevicesinc/rfsom-box-gui/pull/2.diff","patch_url":"https://github.com/analogdevicesinc/rfsom-box-gui/pull/2.patch","issue_url":"https://api.github.com/repos/analogdevicesinc/rfsom-box-gui/issues/2","number":2,"state":"open","locked":false,"title":"Fix TAP IP fragmentation issue","user":{"login":"emaclean-adi","id":29780300,"avatar_url":"https://avatars2.githubusercontent.com/u/29780300?v=4","gravatar_id":"","url":"https://api.github.com/users/emaclean-adi","html_url":"https://github.com/emaclean-adi","followers_url":"https://api.github.com/users/emaclean-adi/followers","following_url":"https://api.github.com/users/emaclean-adi/following{/other_user}","gists_url":"https://api.github.com/users/emaclean-adi/gists{/gist_id}","starred_url":"https://api.github.com/users/emaclean-adi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emaclean-adi/subscriptions","organizations_url":"https://api.github.com/users/emaclean-adi/orgs","repos_url":"https://api.github.com/users/emaclean-adi/repos","events_url":"https://api.github.com/users/emaclean-adi/events{/privacy}","received_events_url":"https://api.github.com/users/emaclean-adi/received_events","type":"User","site_admin":false},"body":"The TAP interface did not work because the extra overhead from Ethernet reduced the effective MTU. The MTU of the IP layer defaults to 1500 bytes which is all that our MAC can handle, leaving no room for Ethernet overhead. When fragmenting IP packets larger than MTU, the fragmentation offset of the fragmented packet would be set incorrectly when using TAP. Reducing the MTU of the adi_radio device to allow for the Ethernet overhead allows fragmented IP packets to be sent correctly.\r\n\r\nThis update lowers the MTU of adi_radio by 10 bytes and also enables TAP instead of TUN and also enables encryption.","created_at":"2017-09-15T18:44:46Z","updated_at":"2017-09-15T19:10:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"63ecb9767aa6d886d65ecfdf43c178b1f346e7b1","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/analogdevicesinc/rfsom-box-gui/pulls/2/commits","review_comments_url":"https://api.github.com/repos/analogdevicesinc/rfsom-box-gui/pulls/2/comments","review_comment_url":"https://api.github.com/repos/analogdevicesinc/rfsom-box-gui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/analogdevicesinc/rfsom-box-gui/issues/2/comments","statuses_url":"https://api.github.com/repos/analogdevicesinc/rfsom-box-gui/statuses/d87c862b5b13ba0a27dbefc30b828232adc72b86","head":{"label":"emaclean-adi:master","ref":"master","sha":"d87c862b5b13ba0a27dbefc30b828232adc72b86","user":{"login":"emaclean-adi","id":29780300,"avatar_url":"https://avatars2.githubusercontent.com/u/29780300?v=4","gravatar_id":"","url":"https://api.github.com/users/emaclean-adi","html_url":"https://github.com/emaclean-adi","followers_url":"https://api.github.com/users/emaclean-adi/followers","following_url":"https://api.github.com/users/emaclean-adi/following{/other_user}","gists_url":"https://api.github.com/users/emaclean-adi/gists{/gist_id}","starred_url":"https://api.github.com/users/emaclean-adi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emaclean-adi/subscriptions","organizations_url":"https://api.github.com/users/emaclean-adi/orgs","repos_url":"https://api.github.com/users/emaclean-adi/repos","events_url":"https://api.github.com/users/emaclean-adi/events{/privacy}","received_events_url":"https://api.github.com/users/emaclean-adi/received_events","type":"User","site_admin":false},"repo":{"id":102734378,"name":"rfsom-box-gui","full_name":"emaclean-adi/rfsom-box-gui","owner":{"login":"emaclean-adi","id":29780300,"avatar_url":"https://avatars2.githubusercontent.com/u/29780300?v=4","gravatar_id":"","url":"https://api.github.com/users/emaclean-adi","html_url":"https://github.com/emaclean-adi","followers_url":"https://api.github.com/users/emaclean-adi/followers","following_url":"https://api.github.com/users/emaclean-adi/following{/other_user}","gists_url":"https://api.github.com/users/emaclean-adi/gists{/gist_id}","starred_url":"https://api.github.com/users/emaclean-adi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emaclean-adi/subscriptions","organizations_url":"https://api.github.com/users/emaclean-adi/orgs","repos_url":"https://api.github.com/users/emaclean-adi/repos","events_url":"https://api.github.com/users/emaclean-adi/events{/privacy}","received_events_url":"https://api.github.com/users/emaclean-adi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/emaclean-adi/rfsom-box-gui","description":"GUI application for the RFSOM Box ","fork":true,"url":"https://api.github.com/repos/emaclean-adi/rfsom-box-gui","forks_url":"https://api.github.com/repos/emaclean-adi/rfsom-box-gui/forks","keys_url":"https://api.github.com/repos/emaclean-adi/rfsom-box-gui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emaclean-adi/rfsom-box-gui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emaclean-adi/rfsom-box-gui/teams","hooks_url":"https://api.github.com/repos/emaclean-adi/rfsom-box-gui/hooks","issue_events_url":"https://api.github.com/repos/emaclean-adi/rfsom-box-gui/issues/events{/number}","events_url":"https://api.github.com/repos/emaclean-adi/rfsom-box-gui/events","assignees_url":"https://api.github.com/repos/emaclean-adi/rfsom-box-gui/assignees{/user}","branches_url":"https://api.github.com/repos/emaclean-adi/rfsom-box-gui/branches{/branch}","tags_url":"https://api.github.com/repos/emaclean-adi/rfsom-box-gui/tags","blobs_url":"https://api.github.com/repos/emaclean-adi/rfsom-box-gui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emaclean-adi/rfsom-box-gui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emaclean-adi/rfsom-box-gui/git/refs{/sha}","trees_url":"https://api.github.com/repos/emaclean-adi/rfsom-box-gui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emaclean-adi/rfsom-box-gui/statuses/{sha}","languages_url":"https://api.github.com/repos/emaclean-adi/rfsom-box-gui/languages","stargazers_url":"https://api.github.com/repos/emaclean-adi/rfsom-box-gui/stargazers","contributors_url":"https://api.github.com/repos/emaclean-adi/rfsom-box-gui/contributors","subscribers_url":"https://api.github.com/repos/emaclean-adi/rfsom-box-gui/subscribers","subscription_url":"https://api.github.com/repos/emaclean-adi/rfsom-box-gui/subscription","commits_url":"https://api.github.com/repos/emaclean-adi/rfsom-box-gui/commits{/sha}","git_commits_url":"https://api.github.com/repos/emaclean-adi/rfsom-box-gui/git/commits{/sha}","comments_url":"https://api.github.com/repos/emaclean-adi/rfsom-box-gui/comments{/number}","issue_comment_url":"https://api.github.com/repos/emaclean-adi/rfsom-box-gui/issues/comments{/number}","contents_url":"https://api.github.com/repos/emaclean-adi/rfsom-box-gui/contents/{+path}","compare_url":"https://api.github.com/repos/emaclean-adi/rfsom-box-gui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emaclean-adi/rfsom-box-gui/merges","archive_url":"https://api.github.com/repos/emaclean-adi/rfsom-box-gui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emaclean-adi/rfsom-box-gui/downloads","issues_url":"https://api.github.com/repos/emaclean-adi/rfsom-box-gui/issues{/number}","pulls_url":"https://api.github.com/repos/emaclean-adi/rfsom-box-gui/pulls{/number}","milestones_url":"https://api.github.com/repos/emaclean-adi/rfsom-box-gui/milestones{/number}","notifications_url":"https://api.github.com/repos/emaclean-adi/rfsom-box-gui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emaclean-adi/rfsom-box-gui/labels{/name}","releases_url":"https://api.github.com/repos/emaclean-adi/rfsom-box-gui/releases{/id}","deployments_url":"https://api.github.com/repos/emaclean-adi/rfsom-box-gui/deployments","created_at":"2017-09-07T12:28:56Z","updated_at":"2017-09-07T12:28:59Z","pushed_at":"2017-09-15T18:54:54Z","git_url":"git://github.com/emaclean-adi/rfsom-box-gui.git","ssh_url":"git@github.com:emaclean-adi/rfsom-box-gui.git","clone_url":"https://github.com/emaclean-adi/rfsom-box-gui.git","svn_url":"https://github.com/emaclean-adi/rfsom-box-gui","homepage":null,"size":5523,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"analogdevicesinc:master","ref":"master","sha":"d80da6fb739b8d9fbd533bf220a58c8937112ed7","user":{"login":"analogdevicesinc","id":2465527,"avatar_url":"https://avatars2.githubusercontent.com/u/2465527?v=4","gravatar_id":"","url":"https://api.github.com/users/analogdevicesinc","html_url":"https://github.com/analogdevicesinc","followers_url":"https://api.github.com/users/analogdevicesinc/followers","following_url":"https://api.github.com/users/analogdevicesinc/following{/other_user}","gists_url":"https://api.github.com/users/analogdevicesinc/gists{/gist_id}","starred_url":"https://api.github.com/users/analogdevicesinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/analogdevicesinc/subscriptions","organizations_url":"https://api.github.com/users/analogdevicesinc/orgs","repos_url":"https://api.github.com/users/analogdevicesinc/repos","events_url":"https://api.github.com/users/analogdevicesinc/events{/privacy}","received_events_url":"https://api.github.com/users/analogdevicesinc/received_events","type":"Organization","site_admin":false},"repo":{"id":100493394,"name":"rfsom-box-gui","full_name":"analogdevicesinc/rfsom-box-gui","owner":{"login":"analogdevicesinc","id":2465527,"avatar_url":"https://avatars2.githubusercontent.com/u/2465527?v=4","gravatar_id":"","url":"https://api.github.com/users/analogdevicesinc","html_url":"https://github.com/analogdevicesinc","followers_url":"https://api.github.com/users/analogdevicesinc/followers","following_url":"https://api.github.com/users/analogdevicesinc/following{/other_user}","gists_url":"https://api.github.com/users/analogdevicesinc/gists{/gist_id}","starred_url":"https://api.github.com/users/analogdevicesinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/analogdevicesinc/subscriptions","organizations_url":"https://api.github.com/users/analogdevicesinc/orgs","repos_url":"https://api.github.com/users/analogdevicesinc/repos","events_url":"https://api.github.com/users/analogdevicesinc/events{/privacy}","received_events_url":"https://api.github.com/users/analogdevicesinc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/analogdevicesinc/rfsom-box-gui","description":"GUI application for the RFSOM Box ","fork":false,"url":"https://api.github.com/repos/analogdevicesinc/rfsom-box-gui","forks_url":"https://api.github.com/repos/analogdevicesinc/rfsom-box-gui/forks","keys_url":"https://api.github.com/repos/analogdevicesinc/rfsom-box-gui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/analogdevicesinc/rfsom-box-gui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/analogdevicesinc/rfsom-box-gui/teams","hooks_url":"https://api.github.com/repos/analogdevicesinc/rfsom-box-gui/hooks","issue_events_url":"https://api.github.com/repos/analogdevicesinc/rfsom-box-gui/issues/events{/number}","events_url":"https://api.github.com/repos/analogdevicesinc/rfsom-box-gui/events","assignees_url":"https://api.github.com/repos/analogdevicesinc/rfsom-box-gui/assignees{/user}","branches_url":"https://api.github.com/repos/analogdevicesinc/rfsom-box-gui/branches{/branch}","tags_url":"https://api.github.com/repos/analogdevicesinc/rfsom-box-gui/tags","blobs_url":"https://api.github.com/repos/analogdevicesinc/rfsom-box-gui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/analogdevicesinc/rfsom-box-gui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/analogdevicesinc/rfsom-box-gui/git/refs{/sha}","trees_url":"https://api.github.com/repos/analogdevicesinc/rfsom-box-gui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/analogdevicesinc/rfsom-box-gui/statuses/{sha}","languages_url":"https://api.github.com/repos/analogdevicesinc/rfsom-box-gui/languages","stargazers_url":"https://api.github.com/repos/analogdevicesinc/rfsom-box-gui/stargazers","contributors_url":"https://api.github.com/repos/analogdevicesinc/rfsom-box-gui/contributors","subscribers_url":"https://api.github.com/repos/analogdevicesinc/rfsom-box-gui/subscribers","subscription_url":"https://api.github.com/repos/analogdevicesinc/rfsom-box-gui/subscription","commits_url":"https://api.github.com/repos/analogdevicesinc/rfsom-box-gui/commits{/sha}","git_commits_url":"https://api.github.com/repos/analogdevicesinc/rfsom-box-gui/git/commits{/sha}","comments_url":"https://api.github.com/repos/analogdevicesinc/rfsom-box-gui/comments{/number}","issue_comment_url":"https://api.github.com/repos/analogdevicesinc/rfsom-box-gui/issues/comments{/number}","contents_url":"https://api.github.com/repos/analogdevicesinc/rfsom-box-gui/contents/{+path}","compare_url":"https://api.github.com/repos/analogdevicesinc/rfsom-box-gui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/analogdevicesinc/rfsom-box-gui/merges","archive_url":"https://api.github.com/repos/analogdevicesinc/rfsom-box-gui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/analogdevicesinc/rfsom-box-gui/downloads","issues_url":"https://api.github.com/repos/analogdevicesinc/rfsom-box-gui/issues{/number}","pulls_url":"https://api.github.com/repos/analogdevicesinc/rfsom-box-gui/pulls{/number}","milestones_url":"https://api.github.com/repos/analogdevicesinc/rfsom-box-gui/milestones{/number}","notifications_url":"https://api.github.com/repos/analogdevicesinc/rfsom-box-gui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/analogdevicesinc/rfsom-box-gui/labels{/name}","releases_url":"https://api.github.com/repos/analogdevicesinc/rfsom-box-gui/releases{/id}","deployments_url":"https://api.github.com/repos/analogdevicesinc/rfsom-box-gui/deployments","created_at":"2017-08-16T13:38:52Z","updated_at":"2017-08-22T06:06:03Z","pushed_at":"2017-09-15T18:54:56Z","git_url":"git://github.com/analogdevicesinc/rfsom-box-gui.git","ssh_url":"git@github.com:analogdevicesinc/rfsom-box-gui.git","clone_url":"https://github.com/analogdevicesinc/rfsom-box-gui.git","svn_url":"https://github.com/analogdevicesinc/rfsom-box-gui","homepage":null,"size":5540,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/analogdevicesinc/rfsom-box-gui/pulls/2"},"html":{"href":"https://github.com/analogdevicesinc/rfsom-box-gui/pull/2"},"issue":{"href":"https://api.github.com/repos/analogdevicesinc/rfsom-box-gui/issues/2"},"comments":{"href":"https://api.github.com/repos/analogdevicesinc/rfsom-box-gui/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/analogdevicesinc/rfsom-box-gui/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/analogdevicesinc/rfsom-box-gui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/analogdevicesinc/rfsom-box-gui/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/analogdevicesinc/rfsom-box-gui/statuses/d87c862b5b13ba0a27dbefc30b828232adc72b86"}},"author_association":"NONE"}}
{"actor":{"display_login":"emaclean-adi"}}