{"action":"closed","number":256,"pull_request":{"url":"https://api.github.com/repos/guardian/support-frontend/pulls/256","id":144197643,"html_url":"https://github.com/guardian/support-frontend/pull/256","diff_url":"https://github.com/guardian/support-frontend/pull/256.diff","patch_url":"https://github.com/guardian/support-frontend/pull/256.patch","issue_url":"https://api.github.com/repos/guardian/support-frontend/issues/256","number":256,"state":"closed","locked":false,"title":"Expand Utilities Tests","user":{"login":"Ap0c","id":5131341,"avatar_url":"https://avatars3.githubusercontent.com/u/5131341?v=4","gravatar_id":"","url":"https://api.github.com/users/Ap0c","html_url":"https://github.com/Ap0c","followers_url":"https://api.github.com/users/Ap0c/followers","following_url":"https://api.github.com/users/Ap0c/following{/other_user}","gists_url":"https://api.github.com/users/Ap0c/gists{/gist_id}","starred_url":"https://api.github.com/users/Ap0c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ap0c/subscriptions","organizations_url":"https://api.github.com/users/Ap0c/orgs","repos_url":"https://api.github.com/users/Ap0c/repos","events_url":"https://api.github.com/users/Ap0c/events{/privacy}","received_events_url":"https://api.github.com/users/Ap0c/received_events","type":"User","site_admin":false},"body":"## Why are you doing this?\r\n\r\nThe utilities module didn't have full test coverage. Now it does. Also, I deleted a `titleCase` function that wasn't being used anywhere. In addition, believing I'd be able to use JavaScript's type system for `deserialiseJsonObject` was a fool's hope...\r\n\r\n[**Trello Card**](https://trello.com/c/FjrpCO4i/943-add-tests-for-utilities)\r\n\r\n## Changes\r\n\r\n- Added tests for:\r\n  + `roundDp`\r\n  + `generateClassName`\r\n  + `clickSubstituteKeyPressHandler`\r\n  + `parseBoolean`\r\n  + `deserialiseJson`\r\n- Removed unused `titleCase` function.\r\n- Added `getMockedKeypress` helper to mock keypress events.\r\n- Stopped checking for 'object' type in `deserialiseJsonObject`, renamed it to `deserialiseJson`.\r\n","created_at":"2017-10-02T14:27:54Z","updated_at":"2017-10-03T10:35:47Z","closed_at":"2017-10-03T10:35:47Z","merged_at":"2017-10-03T10:35:47Z","merge_commit_sha":"e5061e4514afca522b9e5d49c268be275ae1c7e5","assignee":null,"assignees":[],"requested_reviewers":[{"login":"rupertbates","id":181371,"avatar_url":"https://avatars2.githubusercontent.com/u/181371?v=4","gravatar_id":"","url":"https://api.github.com/users/rupertbates","html_url":"https://github.com/rupertbates","followers_url":"https://api.github.com/users/rupertbates/followers","following_url":"https://api.github.com/users/rupertbates/following{/other_user}","gists_url":"https://api.github.com/users/rupertbates/gists{/gist_id}","starred_url":"https://api.github.com/users/rupertbates/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rupertbates/subscriptions","organizations_url":"https://api.github.com/users/rupertbates/orgs","repos_url":"https://api.github.com/users/rupertbates/repos","events_url":"https://api.github.com/users/rupertbates/events{/privacy}","received_events_url":"https://api.github.com/users/rupertbates/received_events","type":"User","site_admin":false},{"login":"JustinPinner","id":690395,"avatar_url":"https://avatars2.githubusercontent.com/u/690395?v=4","gravatar_id":"","url":"https://api.github.com/users/JustinPinner","html_url":"https://github.com/JustinPinner","followers_url":"https://api.github.com/users/JustinPinner/followers","following_url":"https://api.github.com/users/JustinPinner/following{/other_user}","gists_url":"https://api.github.com/users/JustinPinner/gists{/gist_id}","starred_url":"https://api.github.com/users/JustinPinner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JustinPinner/subscriptions","organizations_url":"https://api.github.com/users/JustinPinner/orgs","repos_url":"https://api.github.com/users/JustinPinner/repos","events_url":"https://api.github.com/users/JustinPinner/events{/privacy}","received_events_url":"https://api.github.com/users/JustinPinner/received_events","type":"User","site_admin":false},{"login":"davidfurey","id":2619836,"avatar_url":"https://avatars0.githubusercontent.com/u/2619836?v=4","gravatar_id":"","url":"https://api.github.com/users/davidfurey","html_url":"https://github.com/davidfurey","followers_url":"https://api.github.com/users/davidfurey/followers","following_url":"https://api.github.com/users/davidfurey/following{/other_user}","gists_url":"https://api.github.com/users/davidfurey/gists{/gist_id}","starred_url":"https://api.github.com/users/davidfurey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidfurey/subscriptions","organizations_url":"https://api.github.com/users/davidfurey/orgs","repos_url":"https://api.github.com/users/davidfurey/repos","events_url":"https://api.github.com/users/davidfurey/events{/privacy}","received_events_url":"https://api.github.com/users/davidfurey/received_events","type":"User","site_admin":false},{"login":"jacobwinch","id":19384074,"avatar_url":"https://avatars3.githubusercontent.com/u/19384074?v=4","gravatar_id":"","url":"https://api.github.com/users/jacobwinch","html_url":"https://github.com/jacobwinch","followers_url":"https://api.github.com/users/jacobwinch/followers","following_url":"https://api.github.com/users/jacobwinch/following{/other_user}","gists_url":"https://api.github.com/users/jacobwinch/gists{/gist_id}","starred_url":"https://api.github.com/users/jacobwinch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacobwinch/subscriptions","organizations_url":"https://api.github.com/users/jacobwinch/orgs","repos_url":"https://api.github.com/users/jacobwinch/repos","events_url":"https://api.github.com/users/jacobwinch/events{/privacy}","received_events_url":"https://api.github.com/users/jacobwinch/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/guardian/support-frontend/pulls/256/commits","review_comments_url":"https://api.github.com/repos/guardian/support-frontend/pulls/256/comments","review_comment_url":"https://api.github.com/repos/guardian/support-frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/guardian/support-frontend/issues/256/comments","statuses_url":"https://api.github.com/repos/guardian/support-frontend/statuses/e898ddd6402c6493b12b5989bb4422f1a22776b4","head":{"label":"guardian:expand-utilities-tests","ref":"expand-utilities-tests","sha":"e898ddd6402c6493b12b5989bb4422f1a22776b4","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars0.githubusercontent.com/u/164318?v=4","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":87204582,"name":"support-frontend","full_name":"guardian/support-frontend","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars0.githubusercontent.com/u/164318?v=4","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/support-frontend","description":"Frontend for the new supporter platform","fork":false,"url":"https://api.github.com/repos/guardian/support-frontend","forks_url":"https://api.github.com/repos/guardian/support-frontend/forks","keys_url":"https://api.github.com/repos/guardian/support-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/support-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/support-frontend/teams","hooks_url":"https://api.github.com/repos/guardian/support-frontend/hooks","issue_events_url":"https://api.github.com/repos/guardian/support-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/support-frontend/events","assignees_url":"https://api.github.com/repos/guardian/support-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/support-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/support-frontend/tags","blobs_url":"https://api.github.com/repos/guardian/support-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/support-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/support-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/support-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/support-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/support-frontend/languages","stargazers_url":"https://api.github.com/repos/guardian/support-frontend/stargazers","contributors_url":"https://api.github.com/repos/guardian/support-frontend/contributors","subscribers_url":"https://api.github.com/repos/guardian/support-frontend/subscribers","subscription_url":"https://api.github.com/repos/guardian/support-frontend/subscription","commits_url":"https://api.github.com/repos/guardian/support-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/support-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/support-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/support-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/support-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/support-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/support-frontend/merges","archive_url":"https://api.github.com/repos/guardian/support-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/support-frontend/downloads","issues_url":"https://api.github.com/repos/guardian/support-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/support-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/support-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/support-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/support-frontend/labels{/name}","releases_url":"https://api.github.com/repos/guardian/support-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/guardian/support-frontend/deployments","created_at":"2017-04-04T15:37:12Z","updated_at":"2017-06-07T15:51:49Z","pushed_at":"2017-10-03T10:35:47Z","git_url":"git://github.com/guardian/support-frontend.git","ssh_url":"git@github.com:guardian/support-frontend.git","clone_url":"https://github.com/guardian/support-frontend.git","svn_url":"https://github.com/guardian/support-frontend","homepage":"https://support.theguardian.com/","size":1675,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":1,"default_branch":"master"}},"base":{"label":"guardian:master","ref":"master","sha":"ba9c9df54846df13f88da3dbf650a2d2bed66317","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars0.githubusercontent.com/u/164318?v=4","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":87204582,"name":"support-frontend","full_name":"guardian/support-frontend","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars0.githubusercontent.com/u/164318?v=4","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/support-frontend","description":"Frontend for the new supporter platform","fork":false,"url":"https://api.github.com/repos/guardian/support-frontend","forks_url":"https://api.github.com/repos/guardian/support-frontend/forks","keys_url":"https://api.github.com/repos/guardian/support-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/support-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/support-frontend/teams","hooks_url":"https://api.github.com/repos/guardian/support-frontend/hooks","issue_events_url":"https://api.github.com/repos/guardian/support-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/support-frontend/events","assignees_url":"https://api.github.com/repos/guardian/support-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/support-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/support-frontend/tags","blobs_url":"https://api.github.com/repos/guardian/support-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/support-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/support-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/support-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/support-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/support-frontend/languages","stargazers_url":"https://api.github.com/repos/guardian/support-frontend/stargazers","contributors_url":"https://api.github.com/repos/guardian/support-frontend/contributors","subscribers_url":"https://api.github.com/repos/guardian/support-frontend/subscribers","subscription_url":"https://api.github.com/repos/guardian/support-frontend/subscription","commits_url":"https://api.github.com/repos/guardian/support-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/support-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/support-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/support-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/support-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/support-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/support-frontend/merges","archive_url":"https://api.github.com/repos/guardian/support-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/support-frontend/downloads","issues_url":"https://api.github.com/repos/guardian/support-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/support-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/support-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/support-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/support-frontend/labels{/name}","releases_url":"https://api.github.com/repos/guardian/support-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/guardian/support-frontend/deployments","created_at":"2017-04-04T15:37:12Z","updated_at":"2017-06-07T15:51:49Z","pushed_at":"2017-10-03T10:35:47Z","git_url":"git://github.com/guardian/support-frontend.git","ssh_url":"git@github.com:guardian/support-frontend.git","clone_url":"https://github.com/guardian/support-frontend.git","svn_url":"https://github.com/guardian/support-frontend","homepage":"https://support.theguardian.com/","size":1675,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/guardian/support-frontend/pulls/256"},"html":{"href":"https://github.com/guardian/support-frontend/pull/256"},"issue":{"href":"https://api.github.com/repos/guardian/support-frontend/issues/256"},"comments":{"href":"https://api.github.com/repos/guardian/support-frontend/issues/256/comments"},"review_comments":{"href":"https://api.github.com/repos/guardian/support-frontend/pulls/256/comments"},"review_comment":{"href":"https://api.github.com/repos/guardian/support-frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/guardian/support-frontend/pulls/256/commits"},"statuses":{"href":"https://api.github.com/repos/guardian/support-frontend/statuses/e898ddd6402c6493b12b5989bb4422f1a22776b4"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"Ap0c","id":5131341,"avatar_url":"https://avatars3.githubusercontent.com/u/5131341?v=4","gravatar_id":"","url":"https://api.github.com/users/Ap0c","html_url":"https://github.com/Ap0c","followers_url":"https://api.github.com/users/Ap0c/followers","following_url":"https://api.github.com/users/Ap0c/following{/other_user}","gists_url":"https://api.github.com/users/Ap0c/gists{/gist_id}","starred_url":"https://api.github.com/users/Ap0c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ap0c/subscriptions","organizations_url":"https://api.github.com/users/Ap0c/orgs","repos_url":"https://api.github.com/users/Ap0c/repos","events_url":"https://api.github.com/users/Ap0c/events{/privacy}","received_events_url":"https://api.github.com/users/Ap0c/received_events","type":"User","site_admin":false},"comments":0,"review_comments":3,"maintainer_can_modify":false,"commits":11,"additions":111,"deletions":7,"changed_files":2}}
{"actor":{"display_login":"Ap0c"}}