{"action":"created","comment":{"url":"https://api.github.com/repos/FirebirdSQL/firebird/pulls/comments/159166391","pull_request_review_id":86068665,"id":159166391,"diff_hunk":"@@ -599,6 +599,8 @@ version:\t// 3.0 => 4.0\n \t// Batch API\n \tBatch createBatch(Status status, Transaction transaction, uint stmtLength, const string sqlStmt,\n \t\tuint dialect, MessageMetadata inMetadata, uint parLength, const uchar* par);\n+\n+\tuint getRemoteProtocolVersion(Status status);","path":"src/include/firebird/FirebirdInterface.idl","position":24,"original_position":24,"commit_id":"ec8f2a473eaa8352c6d327992920843edb303c35","original_commit_id":"ec8f2a473eaa8352c6d327992920843edb303c35","user":{"login":"asfernandes","id":529415,"avatar_url":"https://avatars0.githubusercontent.com/u/529415?v=4","gravatar_id":"","url":"https://api.github.com/users/asfernandes","html_url":"https://github.com/asfernandes","followers_url":"https://api.github.com/users/asfernandes/followers","following_url":"https://api.github.com/users/asfernandes/following{/other_user}","gists_url":"https://api.github.com/users/asfernandes/gists{/gist_id}","starred_url":"https://api.github.com/users/asfernandes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asfernandes/subscriptions","organizations_url":"https://api.github.com/users/asfernandes/orgs","repos_url":"https://api.github.com/users/asfernandes/repos","events_url":"https://api.github.com/users/asfernandes/events{/privacy}","received_events_url":"https://api.github.com/users/asfernandes/received_events","type":"User","site_admin":false},"body":"@AlexPeshkoff can't this be a method of another thing, for example IUtil receiving the attachment as parameter? It does not look good for me in IAttachment... Also, looks like a layer violation. Maybe something about consult capabilities information would be much better to consult in gbak.","created_at":"2018-01-01T23:48:58Z","updated_at":"2018-01-01T23:58:57Z","html_url":"https://github.com/FirebirdSQL/firebird/pull/139#discussion_r159166391","pull_request_url":"https://api.github.com/repos/FirebirdSQL/firebird/pulls/139","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/FirebirdSQL/firebird/pulls/comments/159166391"},"html":{"href":"https://github.com/FirebirdSQL/firebird/pull/139#discussion_r159166391"},"pull_request":{"href":"https://api.github.com/repos/FirebirdSQL/firebird/pulls/139"}}},"pull_request":{"url":"https://api.github.com/repos/FirebirdSQL/firebird/pulls/139","id":160249493,"html_url":"https://github.com/FirebirdSQL/firebird/pull/139","diff_url":"https://github.com/FirebirdSQL/firebird/pull/139.diff","patch_url":"https://github.com/FirebirdSQL/firebird/pull/139.patch","issue_url":"https://api.github.com/repos/FirebirdSQL/firebird/issues/139","number":139,"state":"open","locked":false,"title":"Gbak","user":{"login":"AlexPeshkoff","id":3786577,"avatar_url":"https://avatars3.githubusercontent.com/u/3786577?v=4","gravatar_id":"","url":"https://api.github.com/users/AlexPeshkoff","html_url":"https://github.com/AlexPeshkoff","followers_url":"https://api.github.com/users/AlexPeshkoff/followers","following_url":"https://api.github.com/users/AlexPeshkoff/following{/other_user}","gists_url":"https://api.github.com/users/AlexPeshkoff/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexPeshkoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexPeshkoff/subscriptions","organizations_url":"https://api.github.com/users/AlexPeshkoff/orgs","repos_url":"https://api.github.com/users/AlexPeshkoff/repos","events_url":"https://api.github.com/users/AlexPeshkoff/events{/privacy}","received_events_url":"https://api.github.com/users/AlexPeshkoff/received_events","type":"User","site_admin":false},"body":"Use of IBatch in gbak seriously increases performance of restore over the wire. In a case of localhost connection using TCP/IP restore runs 2 - 6 times faster. First case is with a real database, containing a lot of indices and some blobs, second - specially created test database without indices but with a lot of small blobs. \r\n\r\nThis also fixes http://tracker.firebirdsql.org/browse/CORE-5637 due to use of SQL instead BLR to restore tables like PLG$USERS which helps avoid conflict between old field length and new UNICODE_FSS rules.","created_at":"2017-12-27T13:28:46Z","updated_at":"2018-01-01T23:58:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"da73cc0e90eb609d243df75e6d78464a5ac75863","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/FirebirdSQL/firebird/pulls/139/commits","review_comments_url":"https://api.github.com/repos/FirebirdSQL/firebird/pulls/139/comments","review_comment_url":"https://api.github.com/repos/FirebirdSQL/firebird/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FirebirdSQL/firebird/issues/139/comments","statuses_url":"https://api.github.com/repos/FirebirdSQL/firebird/statuses/ec8f2a473eaa8352c6d327992920843edb303c35","head":{"label":"FirebirdSQL:gbak","ref":"gbak","sha":"ec8f2a473eaa8352c6d327992920843edb303c35","user":{"login":"FirebirdSQL","id":6057940,"avatar_url":"https://avatars3.githubusercontent.com/u/6057940?v=4","gravatar_id":"","url":"https://api.github.com/users/FirebirdSQL","html_url":"https://github.com/FirebirdSQL","followers_url":"https://api.github.com/users/FirebirdSQL/followers","following_url":"https://api.github.com/users/FirebirdSQL/following{/other_user}","gists_url":"https://api.github.com/users/FirebirdSQL/gists{/gist_id}","starred_url":"https://api.github.com/users/FirebirdSQL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FirebirdSQL/subscriptions","organizations_url":"https://api.github.com/users/FirebirdSQL/orgs","repos_url":"https://api.github.com/users/FirebirdSQL/repos","events_url":"https://api.github.com/users/FirebirdSQL/events{/privacy}","received_events_url":"https://api.github.com/users/FirebirdSQL/received_events","type":"Organization","site_admin":false},"repo":{"id":54005538,"name":"firebird","full_name":"FirebirdSQL/firebird","owner":{"login":"FirebirdSQL","id":6057940,"avatar_url":"https://avatars3.githubusercontent.com/u/6057940?v=4","gravatar_id":"","url":"https://api.github.com/users/FirebirdSQL","html_url":"https://github.com/FirebirdSQL","followers_url":"https://api.github.com/users/FirebirdSQL/followers","following_url":"https://api.github.com/users/FirebirdSQL/following{/other_user}","gists_url":"https://api.github.com/users/FirebirdSQL/gists{/gist_id}","starred_url":"https://api.github.com/users/FirebirdSQL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FirebirdSQL/subscriptions","organizations_url":"https://api.github.com/users/FirebirdSQL/orgs","repos_url":"https://api.github.com/users/FirebirdSQL/repos","events_url":"https://api.github.com/users/FirebirdSQL/events{/privacy}","received_events_url":"https://api.github.com/users/FirebirdSQL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FirebirdSQL/firebird","description":"Firebird server, client and tools","fork":false,"url":"https://api.github.com/repos/FirebirdSQL/firebird","forks_url":"https://api.github.com/repos/FirebirdSQL/firebird/forks","keys_url":"https://api.github.com/repos/FirebirdSQL/firebird/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FirebirdSQL/firebird/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FirebirdSQL/firebird/teams","hooks_url":"https://api.github.com/repos/FirebirdSQL/firebird/hooks","issue_events_url":"https://api.github.com/repos/FirebirdSQL/firebird/issues/events{/number}","events_url":"https://api.github.com/repos/FirebirdSQL/firebird/events","assignees_url":"https://api.github.com/repos/FirebirdSQL/firebird/assignees{/user}","branches_url":"https://api.github.com/repos/FirebirdSQL/firebird/branches{/branch}","tags_url":"https://api.github.com/repos/FirebirdSQL/firebird/tags","blobs_url":"https://api.github.com/repos/FirebirdSQL/firebird/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FirebirdSQL/firebird/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FirebirdSQL/firebird/git/refs{/sha}","trees_url":"https://api.github.com/repos/FirebirdSQL/firebird/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FirebirdSQL/firebird/statuses/{sha}","languages_url":"https://api.github.com/repos/FirebirdSQL/firebird/languages","stargazers_url":"https://api.github.com/repos/FirebirdSQL/firebird/stargazers","contributors_url":"https://api.github.com/repos/FirebirdSQL/firebird/contributors","subscribers_url":"https://api.github.com/repos/FirebirdSQL/firebird/subscribers","subscription_url":"https://api.github.com/repos/FirebirdSQL/firebird/subscription","commits_url":"https://api.github.com/repos/FirebirdSQL/firebird/commits{/sha}","git_commits_url":"https://api.github.com/repos/FirebirdSQL/firebird/git/commits{/sha}","comments_url":"https://api.github.com/repos/FirebirdSQL/firebird/comments{/number}","issue_comment_url":"https://api.github.com/repos/FirebirdSQL/firebird/issues/comments{/number}","contents_url":"https://api.github.com/repos/FirebirdSQL/firebird/contents/{+path}","compare_url":"https://api.github.com/repos/FirebirdSQL/firebird/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FirebirdSQL/firebird/merges","archive_url":"https://api.github.com/repos/FirebirdSQL/firebird/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FirebirdSQL/firebird/downloads","issues_url":"https://api.github.com/repos/FirebirdSQL/firebird/issues{/number}","pulls_url":"https://api.github.com/repos/FirebirdSQL/firebird/pulls{/number}","milestones_url":"https://api.github.com/repos/FirebirdSQL/firebird/milestones{/number}","notifications_url":"https://api.github.com/repos/FirebirdSQL/firebird/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FirebirdSQL/firebird/labels{/name}","releases_url":"https://api.github.com/repos/FirebirdSQL/firebird/releases{/id}","deployments_url":"https://api.github.com/repos/FirebirdSQL/firebird/deployments","created_at":"2016-03-16T06:10:37Z","updated_at":"2017-12-25T18:01:23Z","pushed_at":"2018-01-01T15:01:26Z","git_url":"git://github.com/FirebirdSQL/firebird.git","ssh_url":"git@github.com:FirebirdSQL/firebird.git","clone_url":"https://github.com/FirebirdSQL/firebird.git","svn_url":"https://github.com/FirebirdSQL/firebird","homepage":"http://www.firebirdsql.org/","size":150316,"stargazers_count":179,"watchers_count":179,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":59,"mirror_url":null,"archived":false,"open_issues_count":16,"license":null,"forks":59,"open_issues":16,"watchers":179,"default_branch":"master"}},"base":{"label":"FirebirdSQL:master","ref":"master","sha":"f5fe33bf61d93cf45e33a0b0c308f10262fba7cf","user":{"login":"FirebirdSQL","id":6057940,"avatar_url":"https://avatars3.githubusercontent.com/u/6057940?v=4","gravatar_id":"","url":"https://api.github.com/users/FirebirdSQL","html_url":"https://github.com/FirebirdSQL","followers_url":"https://api.github.com/users/FirebirdSQL/followers","following_url":"https://api.github.com/users/FirebirdSQL/following{/other_user}","gists_url":"https://api.github.com/users/FirebirdSQL/gists{/gist_id}","starred_url":"https://api.github.com/users/FirebirdSQL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FirebirdSQL/subscriptions","organizations_url":"https://api.github.com/users/FirebirdSQL/orgs","repos_url":"https://api.github.com/users/FirebirdSQL/repos","events_url":"https://api.github.com/users/FirebirdSQL/events{/privacy}","received_events_url":"https://api.github.com/users/FirebirdSQL/received_events","type":"Organization","site_admin":false},"repo":{"id":54005538,"name":"firebird","full_name":"FirebirdSQL/firebird","owner":{"login":"FirebirdSQL","id":6057940,"avatar_url":"https://avatars3.githubusercontent.com/u/6057940?v=4","gravatar_id":"","url":"https://api.github.com/users/FirebirdSQL","html_url":"https://github.com/FirebirdSQL","followers_url":"https://api.github.com/users/FirebirdSQL/followers","following_url":"https://api.github.com/users/FirebirdSQL/following{/other_user}","gists_url":"https://api.github.com/users/FirebirdSQL/gists{/gist_id}","starred_url":"https://api.github.com/users/FirebirdSQL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FirebirdSQL/subscriptions","organizations_url":"https://api.github.com/users/FirebirdSQL/orgs","repos_url":"https://api.github.com/users/FirebirdSQL/repos","events_url":"https://api.github.com/users/FirebirdSQL/events{/privacy}","received_events_url":"https://api.github.com/users/FirebirdSQL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FirebirdSQL/firebird","description":"Firebird server, client and tools","fork":false,"url":"https://api.github.com/repos/FirebirdSQL/firebird","forks_url":"https://api.github.com/repos/FirebirdSQL/firebird/forks","keys_url":"https://api.github.com/repos/FirebirdSQL/firebird/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FirebirdSQL/firebird/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FirebirdSQL/firebird/teams","hooks_url":"https://api.github.com/repos/FirebirdSQL/firebird/hooks","issue_events_url":"https://api.github.com/repos/FirebirdSQL/firebird/issues/events{/number}","events_url":"https://api.github.com/repos/FirebirdSQL/firebird/events","assignees_url":"https://api.github.com/repos/FirebirdSQL/firebird/assignees{/user}","branches_url":"https://api.github.com/repos/FirebirdSQL/firebird/branches{/branch}","tags_url":"https://api.github.com/repos/FirebirdSQL/firebird/tags","blobs_url":"https://api.github.com/repos/FirebirdSQL/firebird/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FirebirdSQL/firebird/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FirebirdSQL/firebird/git/refs{/sha}","trees_url":"https://api.github.com/repos/FirebirdSQL/firebird/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FirebirdSQL/firebird/statuses/{sha}","languages_url":"https://api.github.com/repos/FirebirdSQL/firebird/languages","stargazers_url":"https://api.github.com/repos/FirebirdSQL/firebird/stargazers","contributors_url":"https://api.github.com/repos/FirebirdSQL/firebird/contributors","subscribers_url":"https://api.github.com/repos/FirebirdSQL/firebird/subscribers","subscription_url":"https://api.github.com/repos/FirebirdSQL/firebird/subscription","commits_url":"https://api.github.com/repos/FirebirdSQL/firebird/commits{/sha}","git_commits_url":"https://api.github.com/repos/FirebirdSQL/firebird/git/commits{/sha}","comments_url":"https://api.github.com/repos/FirebirdSQL/firebird/comments{/number}","issue_comment_url":"https://api.github.com/repos/FirebirdSQL/firebird/issues/comments{/number}","contents_url":"https://api.github.com/repos/FirebirdSQL/firebird/contents/{+path}","compare_url":"https://api.github.com/repos/FirebirdSQL/firebird/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FirebirdSQL/firebird/merges","archive_url":"https://api.github.com/repos/FirebirdSQL/firebird/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FirebirdSQL/firebird/downloads","issues_url":"https://api.github.com/repos/FirebirdSQL/firebird/issues{/number}","pulls_url":"https://api.github.com/repos/FirebirdSQL/firebird/pulls{/number}","milestones_url":"https://api.github.com/repos/FirebirdSQL/firebird/milestones{/number}","notifications_url":"https://api.github.com/repos/FirebirdSQL/firebird/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FirebirdSQL/firebird/labels{/name}","releases_url":"https://api.github.com/repos/FirebirdSQL/firebird/releases{/id}","deployments_url":"https://api.github.com/repos/FirebirdSQL/firebird/deployments","created_at":"2016-03-16T06:10:37Z","updated_at":"2017-12-25T18:01:23Z","pushed_at":"2018-01-01T15:01:26Z","git_url":"git://github.com/FirebirdSQL/firebird.git","ssh_url":"git@github.com:FirebirdSQL/firebird.git","clone_url":"https://github.com/FirebirdSQL/firebird.git","svn_url":"https://github.com/FirebirdSQL/firebird","homepage":"http://www.firebirdsql.org/","size":150316,"stargazers_count":179,"watchers_count":179,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":59,"mirror_url":null,"archived":false,"open_issues_count":16,"license":null,"forks":59,"open_issues":16,"watchers":179,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/FirebirdSQL/firebird/pulls/139"},"html":{"href":"https://github.com/FirebirdSQL/firebird/pull/139"},"issue":{"href":"https://api.github.com/repos/FirebirdSQL/firebird/issues/139"},"comments":{"href":"https://api.github.com/repos/FirebirdSQL/firebird/issues/139/comments"},"review_comments":{"href":"https://api.github.com/repos/FirebirdSQL/firebird/pulls/139/comments"},"review_comment":{"href":"https://api.github.com/repos/FirebirdSQL/firebird/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FirebirdSQL/firebird/pulls/139/commits"},"statuses":{"href":"https://api.github.com/repos/FirebirdSQL/firebird/statuses/ec8f2a473eaa8352c6d327992920843edb303c35"}},"author_association":"OWNER"}}
{"actor":{"display_login":"asfernandes"}}