{"action":"created","comment":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments/97698228","pull_request_review_id":18315461,"id":97698228,"diff_hunk":"@@ -352,36 +352,37 @@ declare namespace WebdriverIO {\n         ): Client<P>;\n         getHTML<P>(includeSelectorTag: boolean): Client<P>;\n \n-        getLocation(selector?: string): Size;\n-        getLocation(selector: string, axis: string): number;\n-        getLocation(axis: string): number;\n+        getLocation(selector?: string): Location;\n+        getLocation(selector: string, axis: Axis): number;\n+        getLocation(axis: Axis): number;\n         getLocation<P>(selector?: string): Client<P>;\n         getLocation<P>(\n             selector: string,\n-            axis: string\n+            axis: Axis\n         ): Client<P>;\n-        getLocation<P>(axis: string): Client<P>;\n+        getLocation<P>(axis: Axis): Client<P>;\n \n-        getLocationInView(selector: string): Size;\n-        getLocationInView(selector: string): Size[];\n-        getLocationInView(): Size;\n-        getLocationInView(): Size[];\n+        getLocationInView(selector: string): Location;\n+        getLocationInView(selector: string): Location[];","path":"webdriverio/index.d.ts","position":24,"original_position":24,"commit_id":"65701d7b2b3d60b309a7acd2fda6c10d2a77aec1","original_commit_id":"65701d7b2b3d60b309a7acd2fda6c10d2a77aec1","user":{"login":"pmoleri","id":12942794,"avatar_url":"https://avatars.githubusercontent.com/u/12942794?v=3","gravatar_id":"","url":"https://api.github.com/users/pmoleri","html_url":"https://github.com/pmoleri","followers_url":"https://api.github.com/users/pmoleri/followers","following_url":"https://api.github.com/users/pmoleri/following{/other_user}","gists_url":"https://api.github.com/users/pmoleri/gists{/gist_id}","starred_url":"https://api.github.com/users/pmoleri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmoleri/subscriptions","organizations_url":"https://api.github.com/users/pmoleri/orgs","repos_url":"https://api.github.com/users/pmoleri/repos","events_url":"https://api.github.com/users/pmoleri/events{/privacy}","received_events_url":"https://api.github.com/users/pmoleri/received_events","type":"User","site_admin":false},"body":"Hi, I considered that, but I didn't want to introduce breaking changes just for these methods, when the the rest of the Api is written in this way.\r\n\r\nI think the whole Api needs to be expressed in a better way, for example:\r\n`client.getLocation(\".main\")`  => `Location | Location[]`\r\n`client.element(\".main\").getLocation()`  => `Location`\r\n\r\nBecause, as I tested, `element` method always returns a single Element.","created_at":"2017-01-25T02:22:05Z","updated_at":"2017-01-25T02:22:06Z","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/14052#discussion_r97698228","pull_request_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/14052","_links":{"self":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments/97698228"},"html":{"href":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/14052#discussion_r97698228"},"pull_request":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/14052"}}},"pull_request":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/14052","id":101744926,"html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/14052","diff_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/14052.diff","patch_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/14052.patch","issue_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/14052","number":14052,"state":"open","locked":false,"title":"Fix getLocation return type","user":{"login":"pmoleri","id":12942794,"avatar_url":"https://avatars.githubusercontent.com/u/12942794?v=3","gravatar_id":"","url":"https://api.github.com/users/pmoleri","html_url":"https://github.com/pmoleri","followers_url":"https://api.github.com/users/pmoleri/followers","following_url":"https://api.github.com/users/pmoleri/following{/other_user}","gists_url":"https://api.github.com/users/pmoleri/gists{/gist_id}","starred_url":"https://api.github.com/users/pmoleri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmoleri/subscriptions","organizations_url":"https://api.github.com/users/pmoleri/orgs","repos_url":"https://api.github.com/users/pmoleri/repos","events_url":"https://api.github.com/users/pmoleri/events{/privacy}","received_events_url":"https://api.github.com/users/pmoleri/received_events","type":"User","site_admin":false},"body":"Please fill in this template.\r\n\r\n- [x] Prefer to make your PR against the `master` branch.\r\n- [x] Use a meaningful title for the pull request. Include the name of the package modified.\r\n- [x] Test the change in your own code.\r\n- [x] Follow the advice from the [readme](https://github.com/DefinitelyTyped/DefinitelyTyped#make-a-pull-request).\r\n- [x] Avoid [common mistakes](https://github.com/DefinitelyTyped/DefinitelyTyped#common-mistakes).\r\n- [x] Run `npm run lint -- package-name` if a `tslint.json` is present.\r\n  _no lint_\r\n\r\nIf changing an existing definition:\r\n- [x] Provide a URL to documentation or source code which provides context for the suggested changes:\r\n  http://webdriver.io/api/property/getLocation.html\r\n- [x] Increase the version number in the header if appropriate.\r\n  _no need_\r\n\r\nThis is a correction of the getLocation and getLocationInView return types.\r\nIn the types is Size but it's supposed to be Location according to documentation and use.\r\nAlso renamed GeoLocation type because it was being incorrectly merged with Location type.\r\n\r\nThis is a new PR for what was already merged in #12994 but then mistakenly reverted in #13229.","created_at":"2017-01-16T19:18:12Z","updated_at":"2017-01-25T02:22:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e203f6266a696e6d33269426b2fc8a28e574a6f3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/14052/commits","review_comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/14052/comments","review_comment_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/14052/comments","statuses_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/65701d7b2b3d60b309a7acd2fda6c10d2a77aec1","head":{"label":"pmoleri:webdriverio-location","ref":"webdriverio-location","sha":"65701d7b2b3d60b309a7acd2fda6c10d2a77aec1","user":{"login":"pmoleri","id":12942794,"avatar_url":"https://avatars.githubusercontent.com/u/12942794?v=3","gravatar_id":"","url":"https://api.github.com/users/pmoleri","html_url":"https://github.com/pmoleri","followers_url":"https://api.github.com/users/pmoleri/followers","following_url":"https://api.github.com/users/pmoleri/following{/other_user}","gists_url":"https://api.github.com/users/pmoleri/gists{/gist_id}","starred_url":"https://api.github.com/users/pmoleri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmoleri/subscriptions","organizations_url":"https://api.github.com/users/pmoleri/orgs","repos_url":"https://api.github.com/users/pmoleri/repos","events_url":"https://api.github.com/users/pmoleri/events{/privacy}","received_events_url":"https://api.github.com/users/pmoleri/received_events","type":"User","site_admin":false},"repo":{"id":75113070,"name":"DefinitelyTyped","full_name":"pmoleri/DefinitelyTyped","owner":{"login":"pmoleri","id":12942794,"avatar_url":"https://avatars.githubusercontent.com/u/12942794?v=3","gravatar_id":"","url":"https://api.github.com/users/pmoleri","html_url":"https://github.com/pmoleri","followers_url":"https://api.github.com/users/pmoleri/followers","following_url":"https://api.github.com/users/pmoleri/following{/other_user}","gists_url":"https://api.github.com/users/pmoleri/gists{/gist_id}","starred_url":"https://api.github.com/users/pmoleri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmoleri/subscriptions","organizations_url":"https://api.github.com/users/pmoleri/orgs","repos_url":"https://api.github.com/users/pmoleri/repos","events_url":"https://api.github.com/users/pmoleri/events{/privacy}","received_events_url":"https://api.github.com/users/pmoleri/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pmoleri/DefinitelyTyped","description":"The repository for high quality TypeScript type definitions.","fork":true,"url":"https://api.github.com/repos/pmoleri/DefinitelyTyped","forks_url":"https://api.github.com/repos/pmoleri/DefinitelyTyped/forks","keys_url":"https://api.github.com/repos/pmoleri/DefinitelyTyped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pmoleri/DefinitelyTyped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pmoleri/DefinitelyTyped/teams","hooks_url":"https://api.github.com/repos/pmoleri/DefinitelyTyped/hooks","issue_events_url":"https://api.github.com/repos/pmoleri/DefinitelyTyped/issues/events{/number}","events_url":"https://api.github.com/repos/pmoleri/DefinitelyTyped/events","assignees_url":"https://api.github.com/repos/pmoleri/DefinitelyTyped/assignees{/user}","branches_url":"https://api.github.com/repos/pmoleri/DefinitelyTyped/branches{/branch}","tags_url":"https://api.github.com/repos/pmoleri/DefinitelyTyped/tags","blobs_url":"https://api.github.com/repos/pmoleri/DefinitelyTyped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pmoleri/DefinitelyTyped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pmoleri/DefinitelyTyped/git/refs{/sha}","trees_url":"https://api.github.com/repos/pmoleri/DefinitelyTyped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pmoleri/DefinitelyTyped/statuses/{sha}","languages_url":"https://api.github.com/repos/pmoleri/DefinitelyTyped/languages","stargazers_url":"https://api.github.com/repos/pmoleri/DefinitelyTyped/stargazers","contributors_url":"https://api.github.com/repos/pmoleri/DefinitelyTyped/contributors","subscribers_url":"https://api.github.com/repos/pmoleri/DefinitelyTyped/subscribers","subscription_url":"https://api.github.com/repos/pmoleri/DefinitelyTyped/subscription","commits_url":"https://api.github.com/repos/pmoleri/DefinitelyTyped/commits{/sha}","git_commits_url":"https://api.github.com/repos/pmoleri/DefinitelyTyped/git/commits{/sha}","comments_url":"https://api.github.com/repos/pmoleri/DefinitelyTyped/comments{/number}","issue_comment_url":"https://api.github.com/repos/pmoleri/DefinitelyTyped/issues/comments{/number}","contents_url":"https://api.github.com/repos/pmoleri/DefinitelyTyped/contents/{+path}","compare_url":"https://api.github.com/repos/pmoleri/DefinitelyTyped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pmoleri/DefinitelyTyped/merges","archive_url":"https://api.github.com/repos/pmoleri/DefinitelyTyped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pmoleri/DefinitelyTyped/downloads","issues_url":"https://api.github.com/repos/pmoleri/DefinitelyTyped/issues{/number}","pulls_url":"https://api.github.com/repos/pmoleri/DefinitelyTyped/pulls{/number}","milestones_url":"https://api.github.com/repos/pmoleri/DefinitelyTyped/milestones{/number}","notifications_url":"https://api.github.com/repos/pmoleri/DefinitelyTyped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pmoleri/DefinitelyTyped/labels{/name}","releases_url":"https://api.github.com/repos/pmoleri/DefinitelyTyped/releases{/id}","deployments_url":"https://api.github.com/repos/pmoleri/DefinitelyTyped/deployments","created_at":"2016-11-29T19:09:10Z","updated_at":"2016-11-29T19:09:19Z","pushed_at":"2017-01-18T17:04:36Z","git_url":"git://github.com/pmoleri/DefinitelyTyped.git","ssh_url":"git@github.com:pmoleri/DefinitelyTyped.git","clone_url":"https://github.com/pmoleri/DefinitelyTyped.git","svn_url":"https://github.com/pmoleri/DefinitelyTyped","homepage":"http://definitelytyped.org/","size":173149,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DefinitelyTyped:master","ref":"master","sha":"ae4fe7b6dec1fbbee9a2b454e7cc389b3bd2fd35","user":{"login":"DefinitelyTyped","id":3637556,"avatar_url":"https://avatars.githubusercontent.com/u/3637556?v=3","gravatar_id":"","url":"https://api.github.com/users/DefinitelyTyped","html_url":"https://github.com/DefinitelyTyped","followers_url":"https://api.github.com/users/DefinitelyTyped/followers","following_url":"https://api.github.com/users/DefinitelyTyped/following{/other_user}","gists_url":"https://api.github.com/users/DefinitelyTyped/gists{/gist_id}","starred_url":"https://api.github.com/users/DefinitelyTyped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DefinitelyTyped/subscriptions","organizations_url":"https://api.github.com/users/DefinitelyTyped/orgs","repos_url":"https://api.github.com/users/DefinitelyTyped/repos","events_url":"https://api.github.com/users/DefinitelyTyped/events{/privacy}","received_events_url":"https://api.github.com/users/DefinitelyTyped/received_events","type":"Organization","site_admin":false},"repo":{"id":6093316,"name":"DefinitelyTyped","full_name":"DefinitelyTyped/DefinitelyTyped","owner":{"login":"DefinitelyTyped","id":3637556,"avatar_url":"https://avatars.githubusercontent.com/u/3637556?v=3","gravatar_id":"","url":"https://api.github.com/users/DefinitelyTyped","html_url":"https://github.com/DefinitelyTyped","followers_url":"https://api.github.com/users/DefinitelyTyped/followers","following_url":"https://api.github.com/users/DefinitelyTyped/following{/other_user}","gists_url":"https://api.github.com/users/DefinitelyTyped/gists{/gist_id}","starred_url":"https://api.github.com/users/DefinitelyTyped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DefinitelyTyped/subscriptions","organizations_url":"https://api.github.com/users/DefinitelyTyped/orgs","repos_url":"https://api.github.com/users/DefinitelyTyped/repos","events_url":"https://api.github.com/users/DefinitelyTyped/events{/privacy}","received_events_url":"https://api.github.com/users/DefinitelyTyped/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped","description":"The repository for high quality TypeScript type definitions.","fork":false,"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped","forks_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/forks","keys_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/teams","hooks_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/hooks","issue_events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/events{/number}","events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/events","assignees_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/assignees{/user}","branches_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/branches{/branch}","tags_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/tags","blobs_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/refs{/sha}","trees_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/{sha}","languages_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/languages","stargazers_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/stargazers","contributors_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/contributors","subscribers_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/subscribers","subscription_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/subscription","commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/commits{/sha}","git_commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/commits{/sha}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/comments{/number}","issue_comment_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/comments{/number}","contents_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/contents/{+path}","compare_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/merges","archive_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/downloads","issues_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues{/number}","pulls_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls{/number}","milestones_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/milestones{/number}","notifications_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels{/name}","releases_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/releases{/id}","deployments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/deployments","created_at":"2012-10-05T16:39:45Z","updated_at":"2017-01-25T00:49:30Z","pushed_at":"2017-01-25T02:13:49Z","git_url":"git://github.com/DefinitelyTyped/DefinitelyTyped.git","ssh_url":"git@github.com:DefinitelyTyped/DefinitelyTyped.git","clone_url":"https://github.com/DefinitelyTyped/DefinitelyTyped.git","svn_url":"https://github.com/DefinitelyTyped/DefinitelyTyped","homepage":"http://definitelytyped.org/","size":175303,"stargazers_count":9540,"watchers_count":9540,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7716,"mirror_url":null,"open_issues_count":1156,"forks":7716,"open_issues":1156,"watchers":9540,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/14052"},"html":{"href":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/14052"},"issue":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/14052"},"comments":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/14052/comments"},"review_comments":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/14052/comments"},"review_comment":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/14052/commits"},"statuses":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/65701d7b2b3d60b309a7acd2fda6c10d2a77aec1"}}}}
{"actor":{"display_login":"pmoleri"}}