{"action":"created","issue":{"url":"https://api.github.com/repos/wa0x6e/cal-heatmap/issues/74","repository_url":"https://api.github.com/repos/wa0x6e/cal-heatmap","labels_url":"https://api.github.com/repos/wa0x6e/cal-heatmap/issues/74/labels{/name}","comments_url":"https://api.github.com/repos/wa0x6e/cal-heatmap/issues/74/comments","events_url":"https://api.github.com/repos/wa0x6e/cal-heatmap/issues/74/events","html_url":"https://github.com/wa0x6e/cal-heatmap/pull/74","id":26872538,"number":74,"title":"Let `empty` target cells with no data","user":{"login":"bartaelterman","id":2742677,"avatar_url":"https://avatars4.githubusercontent.com/u/2742677?v=4","gravatar_id":"","url":"https://api.github.com/users/bartaelterman","html_url":"https://github.com/bartaelterman","followers_url":"https://api.github.com/users/bartaelterman/followers","following_url":"https://api.github.com/users/bartaelterman/following{/other_user}","gists_url":"https://api.github.com/users/bartaelterman/gists{/gist_id}","starred_url":"https://api.github.com/users/bartaelterman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartaelterman/subscriptions","organizations_url":"https://api.github.com/users/bartaelterman/orgs","repos_url":"https://api.github.com/users/bartaelterman/repos","events_url":"https://api.github.com/users/bartaelterman/events{/privacy}","received_events_url":"https://api.github.com/users/bartaelterman/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"wa0x6e","id":495709,"avatar_url":"https://avatars5.githubusercontent.com/u/495709?v=4","gravatar_id":"","url":"https://api.github.com/users/wa0x6e","html_url":"https://github.com/wa0x6e","followers_url":"https://api.github.com/users/wa0x6e/followers","following_url":"https://api.github.com/users/wa0x6e/following{/other_user}","gists_url":"https://api.github.com/users/wa0x6e/gists{/gist_id}","starred_url":"https://api.github.com/users/wa0x6e/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wa0x6e/subscriptions","organizations_url":"https://api.github.com/users/wa0x6e/orgs","repos_url":"https://api.github.com/users/wa0x6e/repos","events_url":"https://api.github.com/users/wa0x6e/events{/privacy}","received_events_url":"https://api.github.com/users/wa0x6e/received_events","type":"User","site_admin":false},"assignees":[{"login":"wa0x6e","id":495709,"avatar_url":"https://avatars5.githubusercontent.com/u/495709?v=4","gravatar_id":"","url":"https://api.github.com/users/wa0x6e","html_url":"https://github.com/wa0x6e","followers_url":"https://api.github.com/users/wa0x6e/followers","following_url":"https://api.github.com/users/wa0x6e/following{/other_user}","gists_url":"https://api.github.com/users/wa0x6e/gists{/gist_id}","starred_url":"https://api.github.com/users/wa0x6e/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wa0x6e/subscriptions","organizations_url":"https://api.github.com/users/wa0x6e/orgs","repos_url":"https://api.github.com/users/wa0x6e/repos","events_url":"https://api.github.com/users/wa0x6e/events{/privacy}","received_events_url":"https://api.github.com/users/wa0x6e/received_events","type":"User","site_admin":false}],"milestone":null,"comments":12,"created_at":"2014-02-04T10:40:01Z","updated_at":"2017-07-17T01:41:34Z","closed_at":"2015-02-05T18:46:36Z","pull_request":{"url":"https://api.github.com/repos/wa0x6e/cal-heatmap/pulls/74","html_url":"https://github.com/wa0x6e/cal-heatmap/pull/74","diff_url":"https://github.com/wa0x6e/cal-heatmap/pull/74.diff","patch_url":"https://github.com/wa0x6e/cal-heatmap/pull/74.patch"},"body":"The documentation states that the optional property `empty` of the `legendColors` sets the color for dates with value == 0. This is confusing because the documentation also states that the property name `empty` of the `subDomainTitleFormat` targets dates without a value (so value == null).\n\nSo does `empty` target value == 0 or value == null?\n\nI would encourage the latter option. In the case of the first option, there is a value which can be colored with the default legend and it makes more sense to do so. Furthermore, there is currently no way to color dates where value == null, which happens to be what I'm currently trying to accomplish.\n\nI updated the code, but I get some failing unit tests. (I also get these before my modifications, so I assume I can ignore them).\n"},"comment":{"url":"https://api.github.com/repos/wa0x6e/cal-heatmap/issues/comments/315653717","html_url":"https://github.com/wa0x6e/cal-heatmap/pull/74#issuecomment-315653717","issue_url":"https://api.github.com/repos/wa0x6e/cal-heatmap/issues/74","id":315653717,"user":{"login":"joshuapinter","id":180819,"avatar_url":"https://avatars6.githubusercontent.com/u/180819?v=4","gravatar_id":"","url":"https://api.github.com/users/joshuapinter","html_url":"https://github.com/joshuapinter","followers_url":"https://api.github.com/users/joshuapinter/followers","following_url":"https://api.github.com/users/joshuapinter/following{/other_user}","gists_url":"https://api.github.com/users/joshuapinter/gists{/gist_id}","starred_url":"https://api.github.com/users/joshuapinter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshuapinter/subscriptions","organizations_url":"https://api.github.com/users/joshuapinter/orgs","repos_url":"https://api.github.com/users/joshuapinter/repos","events_url":"https://api.github.com/users/joshuapinter/events{/privacy}","received_events_url":"https://api.github.com/users/joshuapinter/received_events","type":"User","site_admin":false},"created_at":"2017-07-17T01:41:34Z","updated_at":"2017-07-17T01:41:34Z","body":"@bartaelterman Just wanted to say a quick thank you for sorting this out. Was driving me mad that `base` and `empty` weren't doing _anything_, let alone what they were supposed to do.\r\n\r\nAlso, the docs are still referencing version `3.3.10` in the [Installation section](http://cal-heatmap.com/#installation). That threw me for a loop as well."}}
{"actor":{"display_login":"joshuapinter"}}