{"action":"created","comment":{"url":"https://api.github.com/repos/debezium/docker-images/pulls/comments/129521534","pull_request_review_id":52301495,"id":129521534,"diff_hunk":"@@ -28,5 +28,15 @@ RUN mkdir $KAFKA_CONNECT_PLUGINS_DIR;\n # on the classpath, which results in arcane NoSuchMethodError exceptions.\n #\n \n+RUN cd $KAFKA_HOME/libs &&\\\n+    curl -O http://packages.confluent.io/maven/io/confluent/kafka-connect-avro-converter/$CONFLUENT_VERSION/kafka-connect-avro-converter-$CONFLUENT_VERSION.jar &&\\\n+    curl -O http://packages.confluent.io/maven/io/confluent/kafka-avro-serializer/$CONFLUENT_VERSION/kafka-avro-serializer-$CONFLUENT_VERSION.jar &&\\\n+    curl -O http://packages.confluent.io/maven/io/confluent/kafka-schema-registry-client/$CONFLUENT_VERSION/kafka-schema-registry-client-$CONFLUENT_VERSION.jar &&\\\n+    curl -O http://packages.confluent.io/maven/io/confluent/kafka-avro-serializer/$CONFLUENT_VERSION/kafka-avro-serializer-$CONFLUENT_VERSION.jar &&\\\n+    curl -O http://packages.confluent.io/maven/io/confluent/common-config/$CONFLUENT_VERSION/common-config-$CONFLUENT_VERSION.jar &&\\\n+    curl -O http://packages.confluent.io/maven/io/confluent/common-utils/$CONFLUENT_VERSION/common-utils-$CONFLUENT_VERSION.jar &&\\\n+    curl -O http://central.maven.org/maven2/org/codehaus/jackson/jackson-core-asl/1.9.13/jackson-core-asl-1.9.13.jar &&\\\n+    curl -O http://central.maven.org/maven2/org/codehaus/jackson/jackson-mapper-asl/1.9.13/jackson-mapper-asl-1.9.13.jar &&\\\n+    curl -O http://central.maven.org/maven2/org/apache/avro/avro/$AVRO_VERSION/avro-$AVRO_VERSION.jar","path":"connect-base/0.5/Dockerfile","position":null,"original_position":13,"commit_id":"e1074a3754e9a4774a68c280d3ae92e9b4817580","original_commit_id":"95cf4828372a0f67b354f9fe838f6f978c25446c","user":{"login":"jpechane","id":650600,"avatar_url":"https://avatars1.githubusercontent.com/u/650600?v=4","gravatar_id":"","url":"https://api.github.com/users/jpechane","html_url":"https://github.com/jpechane","followers_url":"https://api.github.com/users/jpechane/followers","following_url":"https://api.github.com/users/jpechane/following{/other_user}","gists_url":"https://api.github.com/users/jpechane/gists{/gist_id}","starred_url":"https://api.github.com/users/jpechane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpechane/subscriptions","organizations_url":"https://api.github.com/users/jpechane/orgs","repos_url":"https://api.github.com/users/jpechane/repos","events_url":"https://api.github.com/users/jpechane/events{/privacy}","received_events_url":"https://api.github.com/users/jpechane/received_events","type":"User","site_admin":false},"body":"But it is the same as we if we would embed those dependencies directly inside our connectors","created_at":"2017-07-26T09:19:20Z","updated_at":"2017-07-26T09:19:20Z","html_url":"https://github.com/debezium/docker-images/pull/45#discussion_r129521534","pull_request_url":"https://api.github.com/repos/debezium/docker-images/pulls/45","_links":{"self":{"href":"https://api.github.com/repos/debezium/docker-images/pulls/comments/129521534"},"html":{"href":"https://github.com/debezium/docker-images/pull/45#discussion_r129521534"},"pull_request":{"href":"https://api.github.com/repos/debezium/docker-images/pulls/45"}}},"pull_request":{"url":"https://api.github.com/repos/debezium/docker-images/pulls/45","id":132443859,"html_url":"https://github.com/debezium/docker-images/pull/45","diff_url":"https://github.com/debezium/docker-images/pull/45.diff","patch_url":"https://github.com/debezium/docker-images/pull/45.patch","issue_url":"https://api.github.com/repos/debezium/docker-images/issues/45","number":45,"state":"open","locked":false,"title":"DBZ-271 Avro converter baked into connect-base image","user":{"login":"jpechane","id":650600,"avatar_url":"https://avatars1.githubusercontent.com/u/650600?v=4","gravatar_id":"","url":"https://api.github.com/users/jpechane","html_url":"https://github.com/jpechane","followers_url":"https://api.github.com/users/jpechane/followers","following_url":"https://api.github.com/users/jpechane/following{/other_user}","gists_url":"https://api.github.com/users/jpechane/gists{/gist_id}","starred_url":"https://api.github.com/users/jpechane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpechane/subscriptions","organizations_url":"https://api.github.com/users/jpechane/orgs","repos_url":"https://api.github.com/users/jpechane/repos","events_url":"https://api.github.com/users/jpechane/events{/privacy}","received_events_url":"https://api.github.com/users/jpechane/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-07-26T07:02:14Z","updated_at":"2017-07-26T09:19:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d8b71acbb7b6dcdaa4f18cd2c1dc79a921650924","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/debezium/docker-images/pulls/45/commits","review_comments_url":"https://api.github.com/repos/debezium/docker-images/pulls/45/comments","review_comment_url":"https://api.github.com/repos/debezium/docker-images/pulls/comments{/number}","comments_url":"https://api.github.com/repos/debezium/docker-images/issues/45/comments","statuses_url":"https://api.github.com/repos/debezium/docker-images/statuses/e1074a3754e9a4774a68c280d3ae92e9b4817580","head":{"label":"jpechane:avro","ref":"avro","sha":"e1074a3754e9a4774a68c280d3ae92e9b4817580","user":{"login":"jpechane","id":650600,"avatar_url":"https://avatars1.githubusercontent.com/u/650600?v=4","gravatar_id":"","url":"https://api.github.com/users/jpechane","html_url":"https://github.com/jpechane","followers_url":"https://api.github.com/users/jpechane/followers","following_url":"https://api.github.com/users/jpechane/following{/other_user}","gists_url":"https://api.github.com/users/jpechane/gists{/gist_id}","starred_url":"https://api.github.com/users/jpechane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpechane/subscriptions","organizations_url":"https://api.github.com/users/jpechane/orgs","repos_url":"https://api.github.com/users/jpechane/repos","events_url":"https://api.github.com/users/jpechane/events{/privacy}","received_events_url":"https://api.github.com/users/jpechane/received_events","type":"User","site_admin":false},"repo":{"id":88943177,"name":"docker-images","full_name":"jpechane/docker-images","owner":{"login":"jpechane","id":650600,"avatar_url":"https://avatars1.githubusercontent.com/u/650600?v=4","gravatar_id":"","url":"https://api.github.com/users/jpechane","html_url":"https://github.com/jpechane","followers_url":"https://api.github.com/users/jpechane/followers","following_url":"https://api.github.com/users/jpechane/following{/other_user}","gists_url":"https://api.github.com/users/jpechane/gists{/gist_id}","starred_url":"https://api.github.com/users/jpechane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpechane/subscriptions","organizations_url":"https://api.github.com/users/jpechane/orgs","repos_url":"https://api.github.com/users/jpechane/repos","events_url":"https://api.github.com/users/jpechane/events{/privacy}","received_events_url":"https://api.github.com/users/jpechane/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jpechane/docker-images","description":"Docker images for Debezium. Please log issues in our JIRA at https://issues.jboss.org/projects/DBZ/issues","fork":true,"url":"https://api.github.com/repos/jpechane/docker-images","forks_url":"https://api.github.com/repos/jpechane/docker-images/forks","keys_url":"https://api.github.com/repos/jpechane/docker-images/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jpechane/docker-images/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jpechane/docker-images/teams","hooks_url":"https://api.github.com/repos/jpechane/docker-images/hooks","issue_events_url":"https://api.github.com/repos/jpechane/docker-images/issues/events{/number}","events_url":"https://api.github.com/repos/jpechane/docker-images/events","assignees_url":"https://api.github.com/repos/jpechane/docker-images/assignees{/user}","branches_url":"https://api.github.com/repos/jpechane/docker-images/branches{/branch}","tags_url":"https://api.github.com/repos/jpechane/docker-images/tags","blobs_url":"https://api.github.com/repos/jpechane/docker-images/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jpechane/docker-images/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jpechane/docker-images/git/refs{/sha}","trees_url":"https://api.github.com/repos/jpechane/docker-images/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jpechane/docker-images/statuses/{sha}","languages_url":"https://api.github.com/repos/jpechane/docker-images/languages","stargazers_url":"https://api.github.com/repos/jpechane/docker-images/stargazers","contributors_url":"https://api.github.com/repos/jpechane/docker-images/contributors","subscribers_url":"https://api.github.com/repos/jpechane/docker-images/subscribers","subscription_url":"https://api.github.com/repos/jpechane/docker-images/subscription","commits_url":"https://api.github.com/repos/jpechane/docker-images/commits{/sha}","git_commits_url":"https://api.github.com/repos/jpechane/docker-images/git/commits{/sha}","comments_url":"https://api.github.com/repos/jpechane/docker-images/comments{/number}","issue_comment_url":"https://api.github.com/repos/jpechane/docker-images/issues/comments{/number}","contents_url":"https://api.github.com/repos/jpechane/docker-images/contents/{+path}","compare_url":"https://api.github.com/repos/jpechane/docker-images/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jpechane/docker-images/merges","archive_url":"https://api.github.com/repos/jpechane/docker-images/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jpechane/docker-images/downloads","issues_url":"https://api.github.com/repos/jpechane/docker-images/issues{/number}","pulls_url":"https://api.github.com/repos/jpechane/docker-images/pulls{/number}","milestones_url":"https://api.github.com/repos/jpechane/docker-images/milestones{/number}","notifications_url":"https://api.github.com/repos/jpechane/docker-images/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jpechane/docker-images/labels{/name}","releases_url":"https://api.github.com/repos/jpechane/docker-images/releases{/id}","deployments_url":"https://api.github.com/repos/jpechane/docker-images/deployments","created_at":"2017-04-21T05:08:52Z","updated_at":"2017-04-21T05:08:53Z","pushed_at":"2017-07-26T09:02:45Z","git_url":"git://github.com/jpechane/docker-images.git","ssh_url":"git@github.com:jpechane/docker-images.git","clone_url":"https://github.com/jpechane/docker-images.git","svn_url":"https://github.com/jpechane/docker-images","homepage":"","size":561,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"debezium:master","ref":"master","sha":"3facf7adce222c115a7f5bd463b156a733b605a5","user":{"login":"debezium","id":11964329,"avatar_url":"https://avatars2.githubusercontent.com/u/11964329?v=4","gravatar_id":"","url":"https://api.github.com/users/debezium","html_url":"https://github.com/debezium","followers_url":"https://api.github.com/users/debezium/followers","following_url":"https://api.github.com/users/debezium/following{/other_user}","gists_url":"https://api.github.com/users/debezium/gists{/gist_id}","starred_url":"https://api.github.com/users/debezium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/debezium/subscriptions","organizations_url":"https://api.github.com/users/debezium/orgs","repos_url":"https://api.github.com/users/debezium/repos","events_url":"https://api.github.com/users/debezium/events{/privacy}","received_events_url":"https://api.github.com/users/debezium/received_events","type":"Organization","site_admin":false},"repo":{"id":52029495,"name":"docker-images","full_name":"debezium/docker-images","owner":{"login":"debezium","id":11964329,"avatar_url":"https://avatars2.githubusercontent.com/u/11964329?v=4","gravatar_id":"","url":"https://api.github.com/users/debezium","html_url":"https://github.com/debezium","followers_url":"https://api.github.com/users/debezium/followers","following_url":"https://api.github.com/users/debezium/following{/other_user}","gists_url":"https://api.github.com/users/debezium/gists{/gist_id}","starred_url":"https://api.github.com/users/debezium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/debezium/subscriptions","organizations_url":"https://api.github.com/users/debezium/orgs","repos_url":"https://api.github.com/users/debezium/repos","events_url":"https://api.github.com/users/debezium/events{/privacy}","received_events_url":"https://api.github.com/users/debezium/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/debezium/docker-images","description":"Docker images for Debezium. Please log issues in our JIRA at https://issues.jboss.org/projects/DBZ/issues","fork":false,"url":"https://api.github.com/repos/debezium/docker-images","forks_url":"https://api.github.com/repos/debezium/docker-images/forks","keys_url":"https://api.github.com/repos/debezium/docker-images/keys{/key_id}","collaborators_url":"https://api.github.com/repos/debezium/docker-images/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/debezium/docker-images/teams","hooks_url":"https://api.github.com/repos/debezium/docker-images/hooks","issue_events_url":"https://api.github.com/repos/debezium/docker-images/issues/events{/number}","events_url":"https://api.github.com/repos/debezium/docker-images/events","assignees_url":"https://api.github.com/repos/debezium/docker-images/assignees{/user}","branches_url":"https://api.github.com/repos/debezium/docker-images/branches{/branch}","tags_url":"https://api.github.com/repos/debezium/docker-images/tags","blobs_url":"https://api.github.com/repos/debezium/docker-images/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/debezium/docker-images/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/debezium/docker-images/git/refs{/sha}","trees_url":"https://api.github.com/repos/debezium/docker-images/git/trees{/sha}","statuses_url":"https://api.github.com/repos/debezium/docker-images/statuses/{sha}","languages_url":"https://api.github.com/repos/debezium/docker-images/languages","stargazers_url":"https://api.github.com/repos/debezium/docker-images/stargazers","contributors_url":"https://api.github.com/repos/debezium/docker-images/contributors","subscribers_url":"https://api.github.com/repos/debezium/docker-images/subscribers","subscription_url":"https://api.github.com/repos/debezium/docker-images/subscription","commits_url":"https://api.github.com/repos/debezium/docker-images/commits{/sha}","git_commits_url":"https://api.github.com/repos/debezium/docker-images/git/commits{/sha}","comments_url":"https://api.github.com/repos/debezium/docker-images/comments{/number}","issue_comment_url":"https://api.github.com/repos/debezium/docker-images/issues/comments{/number}","contents_url":"https://api.github.com/repos/debezium/docker-images/contents/{+path}","compare_url":"https://api.github.com/repos/debezium/docker-images/compare/{base}...{head}","merges_url":"https://api.github.com/repos/debezium/docker-images/merges","archive_url":"https://api.github.com/repos/debezium/docker-images/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/debezium/docker-images/downloads","issues_url":"https://api.github.com/repos/debezium/docker-images/issues{/number}","pulls_url":"https://api.github.com/repos/debezium/docker-images/pulls{/number}","milestones_url":"https://api.github.com/repos/debezium/docker-images/milestones{/number}","notifications_url":"https://api.github.com/repos/debezium/docker-images/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/debezium/docker-images/labels{/name}","releases_url":"https://api.github.com/repos/debezium/docker-images/releases{/id}","deployments_url":"https://api.github.com/repos/debezium/docker-images/deployments","created_at":"2016-02-18T18:37:26Z","updated_at":"2017-07-21T21:22:54Z","pushed_at":"2017-07-26T09:02:47Z","git_url":"git://github.com/debezium/docker-images.git","ssh_url":"git@github.com:debezium/docker-images.git","clone_url":"https://github.com/debezium/docker-images.git","svn_url":"https://github.com/debezium/docker-images","homepage":"","size":549,"stargazers_count":9,"watchers_count":9,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":6,"forks":15,"open_issues":6,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/debezium/docker-images/pulls/45"},"html":{"href":"https://github.com/debezium/docker-images/pull/45"},"issue":{"href":"https://api.github.com/repos/debezium/docker-images/issues/45"},"comments":{"href":"https://api.github.com/repos/debezium/docker-images/issues/45/comments"},"review_comments":{"href":"https://api.github.com/repos/debezium/docker-images/pulls/45/comments"},"review_comment":{"href":"https://api.github.com/repos/debezium/docker-images/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/debezium/docker-images/pulls/45/commits"},"statuses":{"href":"https://api.github.com/repos/debezium/docker-images/statuses/e1074a3754e9a4774a68c280d3ae92e9b4817580"}}}}
{"actor":{"display_login":"jpechane"}}