{"action":"created","comment":{"url":"https://api.github.com/repos/europeana/europeana-portal-collections/pulls/comments/130888635","pull_request_review_id":53810424,"id":130888635,"diff_hunk":"@@ -217,7 +206,7 @@ def entity_death\n \n   def entity_date(date)\n     # Just grab the first date in the array if present.\n-    date && date.is_a?(Array) && date.length && date.first.is_a?(String) ? date.first : nil\n+    date && date.is_a?(Array) && date.length && date.first.is_a?(String) ? date_eras_gregorian(date.first) : nil","path":"app/views/concerns/entity_displaying_view.rb","position":23,"original_position":23,"commit_id":"2d8e0aa39c5fe59b63123afa5346b8336da14dbc","original_commit_id":"eb29bcec88bab4003c043e3347136276f6d3c034","user":{"login":"rwd","id":218337,"avatar_url":"https://avatars3.githubusercontent.com/u/218337?v=4","gravatar_id":"","url":"https://api.github.com/users/rwd","html_url":"https://github.com/rwd","followers_url":"https://api.github.com/users/rwd/followers","following_url":"https://api.github.com/users/rwd/following{/other_user}","gists_url":"https://api.github.com/users/rwd/gists{/gist_id}","starred_url":"https://api.github.com/users/rwd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwd/subscriptions","organizations_url":"https://api.github.com/users/rwd/orgs","repos_url":"https://api.github.com/users/rwd/repos","events_url":"https://api.github.com/users/rwd/events{/privacy}","received_events_url":"https://api.github.com/users/rwd/received_events","type":"User","site_admin":false},"body":"We should not just use the first string value of an array but scan the array for the first string value having a format supported by `#date_eras_gregorian`, use that if present, else use the first value in the array.","created_at":"2017-08-02T14:15:43Z","updated_at":"2017-08-02T14:21:22Z","html_url":"https://github.com/europeana/europeana-portal-collections/pull/955#discussion_r130888635","pull_request_url":"https://api.github.com/repos/europeana/europeana-portal-collections/pulls/955","_links":{"self":{"href":"https://api.github.com/repos/europeana/europeana-portal-collections/pulls/comments/130888635"},"html":{"href":"https://github.com/europeana/europeana-portal-collections/pull/955#discussion_r130888635"},"pull_request":{"href":"https://api.github.com/repos/europeana/europeana-portal-collections/pulls/955"}}},"pull_request":{"url":"https://api.github.com/repos/europeana/europeana-portal-collections/pulls/955","id":133699113,"html_url":"https://github.com/europeana/europeana-portal-collections/pull/955","diff_url":"https://github.com/europeana/europeana-portal-collections/pull/955.diff","patch_url":"https://github.com/europeana/europeana-portal-collections/pull/955.patch","issue_url":"https://api.github.com/repos/europeana/europeana-portal-collections/issues/955","number":955,"state":"open","locked":false,"title":"Feat/2329 birth and death dates","user":{"login":"kgish","id":79195,"avatar_url":"https://avatars0.githubusercontent.com/u/79195?v=4","gravatar_id":"","url":"https://api.github.com/users/kgish","html_url":"https://github.com/kgish","followers_url":"https://api.github.com/users/kgish/followers","following_url":"https://api.github.com/users/kgish/following{/other_user}","gists_url":"https://api.github.com/users/kgish/gists{/gist_id}","starred_url":"https://api.github.com/users/kgish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kgish/subscriptions","organizations_url":"https://api.github.com/users/kgish/orgs","repos_url":"https://api.github.com/users/kgish/repos","events_url":"https://api.github.com/users/kgish/events{/privacy}","received_events_url":"https://api.github.com/users/kgish/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-08-02T12:45:34Z","updated_at":"2017-08-02T14:21:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e280fd121daa2763496a57127ada6d869f746e86","assignee":null,"assignees":[],"requested_reviewers":[{"login":"lbiedinger","id":1177719,"avatar_url":"https://avatars3.githubusercontent.com/u/1177719?v=4","gravatar_id":"","url":"https://api.github.com/users/lbiedinger","html_url":"https://github.com/lbiedinger","followers_url":"https://api.github.com/users/lbiedinger/followers","following_url":"https://api.github.com/users/lbiedinger/following{/other_user}","gists_url":"https://api.github.com/users/lbiedinger/gists{/gist_id}","starred_url":"https://api.github.com/users/lbiedinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lbiedinger/subscriptions","organizations_url":"https://api.github.com/users/lbiedinger/orgs","repos_url":"https://api.github.com/users/lbiedinger/repos","events_url":"https://api.github.com/users/lbiedinger/events{/privacy}","received_events_url":"https://api.github.com/users/lbiedinger/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/europeana/europeana-portal-collections/pulls/955/commits","review_comments_url":"https://api.github.com/repos/europeana/europeana-portal-collections/pulls/955/comments","review_comment_url":"https://api.github.com/repos/europeana/europeana-portal-collections/pulls/comments{/number}","comments_url":"https://api.github.com/repos/europeana/europeana-portal-collections/issues/955/comments","statuses_url":"https://api.github.com/repos/europeana/europeana-portal-collections/statuses/2d8e0aa39c5fe59b63123afa5346b8336da14dbc","head":{"label":"europeana:feat/2329-birth-and-death-dates","ref":"feat/2329-birth-and-death-dates","sha":"2d8e0aa39c5fe59b63123afa5346b8336da14dbc","user":{"login":"europeana","id":4570681,"avatar_url":"https://avatars3.githubusercontent.com/u/4570681?v=4","gravatar_id":"","url":"https://api.github.com/users/europeana","html_url":"https://github.com/europeana","followers_url":"https://api.github.com/users/europeana/followers","following_url":"https://api.github.com/users/europeana/following{/other_user}","gists_url":"https://api.github.com/users/europeana/gists{/gist_id}","starred_url":"https://api.github.com/users/europeana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/europeana/subscriptions","organizations_url":"https://api.github.com/users/europeana/orgs","repos_url":"https://api.github.com/users/europeana/repos","events_url":"https://api.github.com/users/europeana/events{/privacy}","received_events_url":"https://api.github.com/users/europeana/received_events","type":"Organization","site_admin":false},"repo":{"id":27171162,"name":"europeana-portal-collections","full_name":"europeana/europeana-portal-collections","owner":{"login":"europeana","id":4570681,"avatar_url":"https://avatars3.githubusercontent.com/u/4570681?v=4","gravatar_id":"","url":"https://api.github.com/users/europeana","html_url":"https://github.com/europeana","followers_url":"https://api.github.com/users/europeana/followers","following_url":"https://api.github.com/users/europeana/following{/other_user}","gists_url":"https://api.github.com/users/europeana/gists{/gist_id}","starred_url":"https://api.github.com/users/europeana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/europeana/subscriptions","organizations_url":"https://api.github.com/users/europeana/orgs","repos_url":"https://api.github.com/users/europeana/repos","events_url":"https://api.github.com/users/europeana/events{/privacy}","received_events_url":"https://api.github.com/users/europeana/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/europeana/europeana-portal-collections","description":"Europeana Collections portal as a Rails + Blacklight application.","fork":false,"url":"https://api.github.com/repos/europeana/europeana-portal-collections","forks_url":"https://api.github.com/repos/europeana/europeana-portal-collections/forks","keys_url":"https://api.github.com/repos/europeana/europeana-portal-collections/keys{/key_id}","collaborators_url":"https://api.github.com/repos/europeana/europeana-portal-collections/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/europeana/europeana-portal-collections/teams","hooks_url":"https://api.github.com/repos/europeana/europeana-portal-collections/hooks","issue_events_url":"https://api.github.com/repos/europeana/europeana-portal-collections/issues/events{/number}","events_url":"https://api.github.com/repos/europeana/europeana-portal-collections/events","assignees_url":"https://api.github.com/repos/europeana/europeana-portal-collections/assignees{/user}","branches_url":"https://api.github.com/repos/europeana/europeana-portal-collections/branches{/branch}","tags_url":"https://api.github.com/repos/europeana/europeana-portal-collections/tags","blobs_url":"https://api.github.com/repos/europeana/europeana-portal-collections/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/europeana/europeana-portal-collections/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/europeana/europeana-portal-collections/git/refs{/sha}","trees_url":"https://api.github.com/repos/europeana/europeana-portal-collections/git/trees{/sha}","statuses_url":"https://api.github.com/repos/europeana/europeana-portal-collections/statuses/{sha}","languages_url":"https://api.github.com/repos/europeana/europeana-portal-collections/languages","stargazers_url":"https://api.github.com/repos/europeana/europeana-portal-collections/stargazers","contributors_url":"https://api.github.com/repos/europeana/europeana-portal-collections/contributors","subscribers_url":"https://api.github.com/repos/europeana/europeana-portal-collections/subscribers","subscription_url":"https://api.github.com/repos/europeana/europeana-portal-collections/subscription","commits_url":"https://api.github.com/repos/europeana/europeana-portal-collections/commits{/sha}","git_commits_url":"https://api.github.com/repos/europeana/europeana-portal-collections/git/commits{/sha}","comments_url":"https://api.github.com/repos/europeana/europeana-portal-collections/comments{/number}","issue_comment_url":"https://api.github.com/repos/europeana/europeana-portal-collections/issues/comments{/number}","contents_url":"https://api.github.com/repos/europeana/europeana-portal-collections/contents/{+path}","compare_url":"https://api.github.com/repos/europeana/europeana-portal-collections/compare/{base}...{head}","merges_url":"https://api.github.com/repos/europeana/europeana-portal-collections/merges","archive_url":"https://api.github.com/repos/europeana/europeana-portal-collections/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/europeana/europeana-portal-collections/downloads","issues_url":"https://api.github.com/repos/europeana/europeana-portal-collections/issues{/number}","pulls_url":"https://api.github.com/repos/europeana/europeana-portal-collections/pulls{/number}","milestones_url":"https://api.github.com/repos/europeana/europeana-portal-collections/milestones{/number}","notifications_url":"https://api.github.com/repos/europeana/europeana-portal-collections/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/europeana/europeana-portal-collections/labels{/name}","releases_url":"https://api.github.com/repos/europeana/europeana-portal-collections/releases{/id}","deployments_url":"https://api.github.com/repos/europeana/europeana-portal-collections/deployments","created_at":"2014-11-26T10:14:22Z","updated_at":"2017-06-01T08:44:31Z","pushed_at":"2017-08-02T14:21:18Z","git_url":"git://github.com/europeana/europeana-portal-collections.git","ssh_url":"git@github.com:europeana/europeana-portal-collections.git","clone_url":"https://github.com/europeana/europeana-portal-collections.git","svn_url":"https://github.com/europeana/europeana-portal-collections","homepage":"http://www.europeana.eu/portal","size":4507,"stargazers_count":14,"watchers_count":14,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":4,"forks":5,"open_issues":4,"watchers":14,"default_branch":"develop"}},"base":{"label":"europeana:develop","ref":"develop","sha":"2519195c430bd307471ee2ed113cdfa5a65f900c","user":{"login":"europeana","id":4570681,"avatar_url":"https://avatars3.githubusercontent.com/u/4570681?v=4","gravatar_id":"","url":"https://api.github.com/users/europeana","html_url":"https://github.com/europeana","followers_url":"https://api.github.com/users/europeana/followers","following_url":"https://api.github.com/users/europeana/following{/other_user}","gists_url":"https://api.github.com/users/europeana/gists{/gist_id}","starred_url":"https://api.github.com/users/europeana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/europeana/subscriptions","organizations_url":"https://api.github.com/users/europeana/orgs","repos_url":"https://api.github.com/users/europeana/repos","events_url":"https://api.github.com/users/europeana/events{/privacy}","received_events_url":"https://api.github.com/users/europeana/received_events","type":"Organization","site_admin":false},"repo":{"id":27171162,"name":"europeana-portal-collections","full_name":"europeana/europeana-portal-collections","owner":{"login":"europeana","id":4570681,"avatar_url":"https://avatars3.githubusercontent.com/u/4570681?v=4","gravatar_id":"","url":"https://api.github.com/users/europeana","html_url":"https://github.com/europeana","followers_url":"https://api.github.com/users/europeana/followers","following_url":"https://api.github.com/users/europeana/following{/other_user}","gists_url":"https://api.github.com/users/europeana/gists{/gist_id}","starred_url":"https://api.github.com/users/europeana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/europeana/subscriptions","organizations_url":"https://api.github.com/users/europeana/orgs","repos_url":"https://api.github.com/users/europeana/repos","events_url":"https://api.github.com/users/europeana/events{/privacy}","received_events_url":"https://api.github.com/users/europeana/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/europeana/europeana-portal-collections","description":"Europeana Collections portal as a Rails + Blacklight application.","fork":false,"url":"https://api.github.com/repos/europeana/europeana-portal-collections","forks_url":"https://api.github.com/repos/europeana/europeana-portal-collections/forks","keys_url":"https://api.github.com/repos/europeana/europeana-portal-collections/keys{/key_id}","collaborators_url":"https://api.github.com/repos/europeana/europeana-portal-collections/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/europeana/europeana-portal-collections/teams","hooks_url":"https://api.github.com/repos/europeana/europeana-portal-collections/hooks","issue_events_url":"https://api.github.com/repos/europeana/europeana-portal-collections/issues/events{/number}","events_url":"https://api.github.com/repos/europeana/europeana-portal-collections/events","assignees_url":"https://api.github.com/repos/europeana/europeana-portal-collections/assignees{/user}","branches_url":"https://api.github.com/repos/europeana/europeana-portal-collections/branches{/branch}","tags_url":"https://api.github.com/repos/europeana/europeana-portal-collections/tags","blobs_url":"https://api.github.com/repos/europeana/europeana-portal-collections/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/europeana/europeana-portal-collections/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/europeana/europeana-portal-collections/git/refs{/sha}","trees_url":"https://api.github.com/repos/europeana/europeana-portal-collections/git/trees{/sha}","statuses_url":"https://api.github.com/repos/europeana/europeana-portal-collections/statuses/{sha}","languages_url":"https://api.github.com/repos/europeana/europeana-portal-collections/languages","stargazers_url":"https://api.github.com/repos/europeana/europeana-portal-collections/stargazers","contributors_url":"https://api.github.com/repos/europeana/europeana-portal-collections/contributors","subscribers_url":"https://api.github.com/repos/europeana/europeana-portal-collections/subscribers","subscription_url":"https://api.github.com/repos/europeana/europeana-portal-collections/subscription","commits_url":"https://api.github.com/repos/europeana/europeana-portal-collections/commits{/sha}","git_commits_url":"https://api.github.com/repos/europeana/europeana-portal-collections/git/commits{/sha}","comments_url":"https://api.github.com/repos/europeana/europeana-portal-collections/comments{/number}","issue_comment_url":"https://api.github.com/repos/europeana/europeana-portal-collections/issues/comments{/number}","contents_url":"https://api.github.com/repos/europeana/europeana-portal-collections/contents/{+path}","compare_url":"https://api.github.com/repos/europeana/europeana-portal-collections/compare/{base}...{head}","merges_url":"https://api.github.com/repos/europeana/europeana-portal-collections/merges","archive_url":"https://api.github.com/repos/europeana/europeana-portal-collections/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/europeana/europeana-portal-collections/downloads","issues_url":"https://api.github.com/repos/europeana/europeana-portal-collections/issues{/number}","pulls_url":"https://api.github.com/repos/europeana/europeana-portal-collections/pulls{/number}","milestones_url":"https://api.github.com/repos/europeana/europeana-portal-collections/milestones{/number}","notifications_url":"https://api.github.com/repos/europeana/europeana-portal-collections/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/europeana/europeana-portal-collections/labels{/name}","releases_url":"https://api.github.com/repos/europeana/europeana-portal-collections/releases{/id}","deployments_url":"https://api.github.com/repos/europeana/europeana-portal-collections/deployments","created_at":"2014-11-26T10:14:22Z","updated_at":"2017-06-01T08:44:31Z","pushed_at":"2017-08-02T14:21:18Z","git_url":"git://github.com/europeana/europeana-portal-collections.git","ssh_url":"git@github.com:europeana/europeana-portal-collections.git","clone_url":"https://github.com/europeana/europeana-portal-collections.git","svn_url":"https://github.com/europeana/europeana-portal-collections","homepage":"http://www.europeana.eu/portal","size":4507,"stargazers_count":14,"watchers_count":14,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":4,"forks":5,"open_issues":4,"watchers":14,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/europeana/europeana-portal-collections/pulls/955"},"html":{"href":"https://github.com/europeana/europeana-portal-collections/pull/955"},"issue":{"href":"https://api.github.com/repos/europeana/europeana-portal-collections/issues/955"},"comments":{"href":"https://api.github.com/repos/europeana/europeana-portal-collections/issues/955/comments"},"review_comments":{"href":"https://api.github.com/repos/europeana/europeana-portal-collections/pulls/955/comments"},"review_comment":{"href":"https://api.github.com/repos/europeana/europeana-portal-collections/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/europeana/europeana-portal-collections/pulls/955/commits"},"statuses":{"href":"https://api.github.com/repos/europeana/europeana-portal-collections/statuses/2d8e0aa39c5fe59b63123afa5346b8336da14dbc"}}}}
{"actor":{"display_login":"rwd"}}