{"action":"created","comment":{"url":"https://api.github.com/repos/NuGet/NuGet.Client/pulls/comments/94984301","pull_request_review_id":15529355,"id":94984301,"diff_hunk":"@@ -160,14 +161,14 @@ protected void SetDefaultCredentialProvider()\n         {\n             CredentialService = new CredentialService(GetCredentialProviders(), NonInteractive);\n \n-            HttpClient.DefaultCredentialProvider = new CredentialServiceAdapter(CredentialService);\n+            CoreV2.NuGet.HttpClient.DefaultCredentialProvider = new CredentialServiceAdapter(CredentialService);\n \n             HttpHandlerResourceV3.CredentialService = CredentialService;\n \n-            HttpHandlerResourceV3.CredentialsSuccessfullyUsed = (uri, credentials) =>\n+            HttpHandlerResourceV3.CredentialsSuccessfullyUsed = (uri, credentials) =>//","path":"src/NuGet.Clients/NuGet.CommandLine/Commands/Command.cs","position":26,"original_position":26,"commit_id":"4e4cc92a746defbaae9be526e03fd943b7d13f15","original_commit_id":"fdb11bfb98acc72ca5ebf738ed03efd8dad87be5","user":{"login":"joelverhagen","id":94054,"avatar_url":"https://avatars.githubusercontent.com/u/94054?v=3","gravatar_id":"","url":"https://api.github.com/users/joelverhagen","html_url":"https://github.com/joelverhagen","followers_url":"https://api.github.com/users/joelverhagen/followers","following_url":"https://api.github.com/users/joelverhagen/following{/other_user}","gists_url":"https://api.github.com/users/joelverhagen/gists{/gist_id}","starred_url":"https://api.github.com/users/joelverhagen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joelverhagen/subscriptions","organizations_url":"https://api.github.com/users/joelverhagen/orgs","repos_url":"https://api.github.com/users/joelverhagen/repos","events_url":"https://api.github.com/users/joelverhagen/events{/privacy}","received_events_url":"https://api.github.com/users/joelverhagen/received_events","type":"User","site_admin":false},"body":">>// [](start = 84, length = 3)\r\n\r\nUndo","created_at":"2017-01-06T17:28:11Z","updated_at":"2017-01-06T17:28:11Z","html_url":"https://github.com/NuGet/NuGet.Client/pull/1088#discussion_r94984301","pull_request_url":"https://api.github.com/repos/NuGet/NuGet.Client/pulls/1088","_links":{"self":{"href":"https://api.github.com/repos/NuGet/NuGet.Client/pulls/comments/94984301"},"html":{"href":"https://github.com/NuGet/NuGet.Client/pull/1088#discussion_r94984301"},"pull_request":{"href":"https://api.github.com/repos/NuGet/NuGet.Client/pulls/1088"}}},"pull_request":{"url":"https://api.github.com/repos/NuGet/NuGet.Client/pulls/1088","id":100149198,"html_url":"https://github.com/NuGet/NuGet.Client/pull/1088","diff_url":"https://github.com/NuGet/NuGet.Client/pull/1088.diff","patch_url":"https://github.com/NuGet/NuGet.Client/pull/1088.patch","issue_url":"https://api.github.com/repos/NuGet/NuGet.Client/issues/1088","number":1088,"state":"open","locked":false,"title":"Removing Core.V2 dependencies from the NuGet.exe List Command","user":{"login":"nkolev92","id":2878341,"avatar_url":"https://avatars.githubusercontent.com/u/2878341?v=3","gravatar_id":"","url":"https://api.github.com/users/nkolev92","html_url":"https://github.com/nkolev92","followers_url":"https://api.github.com/users/nkolev92/followers","following_url":"https://api.github.com/users/nkolev92/following{/other_user}","gists_url":"https://api.github.com/users/nkolev92/gists{/gist_id}","starred_url":"https://api.github.com/users/nkolev92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nkolev92/subscriptions","organizations_url":"https://api.github.com/users/nkolev92/orgs","repos_url":"https://api.github.com/users/nkolev92/repos","events_url":"https://api.github.com/users/nkolev92/events{/privacy}","received_events_url":"https://api.github.com/users/nkolev92/received_events","type":"User","site_admin":false},"body":"This change addresses issue NuGet/Home#3387\r\nDue to the scope of the Core.V2 dependencies the target was changed to:\r\n- Removal of Core.V2 code in the list command\r\n- Adding an alias for Core.V2 so it's clearer when old code is being used.\r\n\r\nBiggest problem why Core.V2 could not be fully removed is the extensibility point in Program.cs\r\n```\r\n                    using (var container = new CompositionContainer(catalog))\r\n                    {\r\n                        container.ComposeExportedValue(console);\r\n                        container.ComposeExportedValue<CoreV2.NuGet.IPackageRepositoryFactory>(new CommandLineRepositoryFactory(console));\r\n                        container.ComposeExportedValue(fileSystem);\r\n                        container.ComposeParts(this);\r\n                    }\r\n```\r\nA lot of code involving Core.V2 is just syntantic sugar with a few exceptions:\r\n- PackageRestoreConsent was moved from PackageManagement.VisualStudio to PackageManagement\r\n- EnvironmentUtility.SetRunningFromCommandLine() \r\n\r\nThe general design of the List Command:\r\nWe have a list command runner operating on multiple feeds:\r\nV2FeedListResource\r\nLocalPackageListResource - For FS packages, reuses the PackageSearchResource already used in the UI\r\n\r\nThere are 3 different providers:\r\nV2FeedListResourceProvider\r\nV3FeedListResourceProvider\r\nLocalPackageListResourceProvider\r\n\r\nBoth V2/V3 Resource Providers return a V2FeedListResource as currently V3 sources redirect to the V2 endpoint for Search\r\n\r\nThis change also fixes some issues from the old code like the handling of duplicate sources(no more dup calls) and -Delisted flag support if the server ever sets those values :)\r\n\r\n//cc @joelverhagen @emgarten @jainaashish @rohit21agrawal @mishra14 @alpaix \r\n\r\nPS: Ignore the commit msges, I will squash & merge","created_at":"2017-01-04T16:53:40Z","updated_at":"2017-01-06T17:28:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4e5089bfc0b982aae94c1d43d692adeaee271e05","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/NuGet/NuGet.Client/pulls/1088/commits","review_comments_url":"https://api.github.com/repos/NuGet/NuGet.Client/pulls/1088/comments","review_comment_url":"https://api.github.com/repos/NuGet/NuGet.Client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NuGet/NuGet.Client/issues/1088/comments","statuses_url":"https://api.github.com/repos/NuGet/NuGet.Client/statuses/4e4cc92a746defbaae9be526e03fd943b7d13f15","head":{"label":"NuGet:dev-nkolev92-list","ref":"dev-nkolev92-list","sha":"4e4cc92a746defbaae9be526e03fd943b7d13f15","user":{"login":"NuGet","id":968310,"avatar_url":"https://avatars.githubusercontent.com/u/968310?v=3","gravatar_id":"","url":"https://api.github.com/users/NuGet","html_url":"https://github.com/NuGet","followers_url":"https://api.github.com/users/NuGet/followers","following_url":"https://api.github.com/users/NuGet/following{/other_user}","gists_url":"https://api.github.com/users/NuGet/gists{/gist_id}","starred_url":"https://api.github.com/users/NuGet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NuGet/subscriptions","organizations_url":"https://api.github.com/users/NuGet/orgs","repos_url":"https://api.github.com/users/NuGet/repos","events_url":"https://api.github.com/users/NuGet/events{/privacy}","received_events_url":"https://api.github.com/users/NuGet/received_events","type":"Organization","site_admin":false},"repo":{"id":19330736,"name":"NuGet.Client","full_name":"NuGet/NuGet.Client","owner":{"login":"NuGet","id":968310,"avatar_url":"https://avatars.githubusercontent.com/u/968310?v=3","gravatar_id":"","url":"https://api.github.com/users/NuGet","html_url":"https://github.com/NuGet","followers_url":"https://api.github.com/users/NuGet/followers","following_url":"https://api.github.com/users/NuGet/following{/other_user}","gists_url":"https://api.github.com/users/NuGet/gists{/gist_id}","starred_url":"https://api.github.com/users/NuGet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NuGet/subscriptions","organizations_url":"https://api.github.com/users/NuGet/orgs","repos_url":"https://api.github.com/users/NuGet/repos","events_url":"https://api.github.com/users/NuGet/events{/privacy}","received_events_url":"https://api.github.com/users/NuGet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NuGet/NuGet.Client","description":"Core client libraries for NuGet Services","fork":false,"url":"https://api.github.com/repos/NuGet/NuGet.Client","forks_url":"https://api.github.com/repos/NuGet/NuGet.Client/forks","keys_url":"https://api.github.com/repos/NuGet/NuGet.Client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NuGet/NuGet.Client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NuGet/NuGet.Client/teams","hooks_url":"https://api.github.com/repos/NuGet/NuGet.Client/hooks","issue_events_url":"https://api.github.com/repos/NuGet/NuGet.Client/issues/events{/number}","events_url":"https://api.github.com/repos/NuGet/NuGet.Client/events","assignees_url":"https://api.github.com/repos/NuGet/NuGet.Client/assignees{/user}","branches_url":"https://api.github.com/repos/NuGet/NuGet.Client/branches{/branch}","tags_url":"https://api.github.com/repos/NuGet/NuGet.Client/tags","blobs_url":"https://api.github.com/repos/NuGet/NuGet.Client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NuGet/NuGet.Client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NuGet/NuGet.Client/git/refs{/sha}","trees_url":"https://api.github.com/repos/NuGet/NuGet.Client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NuGet/NuGet.Client/statuses/{sha}","languages_url":"https://api.github.com/repos/NuGet/NuGet.Client/languages","stargazers_url":"https://api.github.com/repos/NuGet/NuGet.Client/stargazers","contributors_url":"https://api.github.com/repos/NuGet/NuGet.Client/contributors","subscribers_url":"https://api.github.com/repos/NuGet/NuGet.Client/subscribers","subscription_url":"https://api.github.com/repos/NuGet/NuGet.Client/subscription","commits_url":"https://api.github.com/repos/NuGet/NuGet.Client/commits{/sha}","git_commits_url":"https://api.github.com/repos/NuGet/NuGet.Client/git/commits{/sha}","comments_url":"https://api.github.com/repos/NuGet/NuGet.Client/comments{/number}","issue_comment_url":"https://api.github.com/repos/NuGet/NuGet.Client/issues/comments{/number}","contents_url":"https://api.github.com/repos/NuGet/NuGet.Client/contents/{+path}","compare_url":"https://api.github.com/repos/NuGet/NuGet.Client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NuGet/NuGet.Client/merges","archive_url":"https://api.github.com/repos/NuGet/NuGet.Client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NuGet/NuGet.Client/downloads","issues_url":"https://api.github.com/repos/NuGet/NuGet.Client/issues{/number}","pulls_url":"https://api.github.com/repos/NuGet/NuGet.Client/pulls{/number}","milestones_url":"https://api.github.com/repos/NuGet/NuGet.Client/milestones{/number}","notifications_url":"https://api.github.com/repos/NuGet/NuGet.Client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NuGet/NuGet.Client/labels{/name}","releases_url":"https://api.github.com/repos/NuGet/NuGet.Client/releases{/id}","deployments_url":"https://api.github.com/repos/NuGet/NuGet.Client/deployments","created_at":"2014-04-30T23:46:11Z","updated_at":"2016-12-29T17:33:21Z","pushed_at":"2017-01-06T16:46:58Z","git_url":"git://github.com/NuGet/NuGet.Client.git","ssh_url":"git@github.com:NuGet/NuGet.Client.git","clone_url":"https://github.com/NuGet/NuGet.Client.git","svn_url":"https://github.com/NuGet/NuGet.Client","homepage":null,"size":24926,"stargazers_count":129,"watchers_count":129,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":169,"mirror_url":null,"open_issues_count":21,"forks":169,"open_issues":21,"watchers":129,"default_branch":"dev"}},"base":{"label":"NuGet:dev","ref":"dev","sha":"e0db9783fc3f3a4586397d922075f1f9a3217419","user":{"login":"NuGet","id":968310,"avatar_url":"https://avatars.githubusercontent.com/u/968310?v=3","gravatar_id":"","url":"https://api.github.com/users/NuGet","html_url":"https://github.com/NuGet","followers_url":"https://api.github.com/users/NuGet/followers","following_url":"https://api.github.com/users/NuGet/following{/other_user}","gists_url":"https://api.github.com/users/NuGet/gists{/gist_id}","starred_url":"https://api.github.com/users/NuGet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NuGet/subscriptions","organizations_url":"https://api.github.com/users/NuGet/orgs","repos_url":"https://api.github.com/users/NuGet/repos","events_url":"https://api.github.com/users/NuGet/events{/privacy}","received_events_url":"https://api.github.com/users/NuGet/received_events","type":"Organization","site_admin":false},"repo":{"id":19330736,"name":"NuGet.Client","full_name":"NuGet/NuGet.Client","owner":{"login":"NuGet","id":968310,"avatar_url":"https://avatars.githubusercontent.com/u/968310?v=3","gravatar_id":"","url":"https://api.github.com/users/NuGet","html_url":"https://github.com/NuGet","followers_url":"https://api.github.com/users/NuGet/followers","following_url":"https://api.github.com/users/NuGet/following{/other_user}","gists_url":"https://api.github.com/users/NuGet/gists{/gist_id}","starred_url":"https://api.github.com/users/NuGet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NuGet/subscriptions","organizations_url":"https://api.github.com/users/NuGet/orgs","repos_url":"https://api.github.com/users/NuGet/repos","events_url":"https://api.github.com/users/NuGet/events{/privacy}","received_events_url":"https://api.github.com/users/NuGet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NuGet/NuGet.Client","description":"Core client libraries for NuGet Services","fork":false,"url":"https://api.github.com/repos/NuGet/NuGet.Client","forks_url":"https://api.github.com/repos/NuGet/NuGet.Client/forks","keys_url":"https://api.github.com/repos/NuGet/NuGet.Client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NuGet/NuGet.Client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NuGet/NuGet.Client/teams","hooks_url":"https://api.github.com/repos/NuGet/NuGet.Client/hooks","issue_events_url":"https://api.github.com/repos/NuGet/NuGet.Client/issues/events{/number}","events_url":"https://api.github.com/repos/NuGet/NuGet.Client/events","assignees_url":"https://api.github.com/repos/NuGet/NuGet.Client/assignees{/user}","branches_url":"https://api.github.com/repos/NuGet/NuGet.Client/branches{/branch}","tags_url":"https://api.github.com/repos/NuGet/NuGet.Client/tags","blobs_url":"https://api.github.com/repos/NuGet/NuGet.Client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NuGet/NuGet.Client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NuGet/NuGet.Client/git/refs{/sha}","trees_url":"https://api.github.com/repos/NuGet/NuGet.Client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NuGet/NuGet.Client/statuses/{sha}","languages_url":"https://api.github.com/repos/NuGet/NuGet.Client/languages","stargazers_url":"https://api.github.com/repos/NuGet/NuGet.Client/stargazers","contributors_url":"https://api.github.com/repos/NuGet/NuGet.Client/contributors","subscribers_url":"https://api.github.com/repos/NuGet/NuGet.Client/subscribers","subscription_url":"https://api.github.com/repos/NuGet/NuGet.Client/subscription","commits_url":"https://api.github.com/repos/NuGet/NuGet.Client/commits{/sha}","git_commits_url":"https://api.github.com/repos/NuGet/NuGet.Client/git/commits{/sha}","comments_url":"https://api.github.com/repos/NuGet/NuGet.Client/comments{/number}","issue_comment_url":"https://api.github.com/repos/NuGet/NuGet.Client/issues/comments{/number}","contents_url":"https://api.github.com/repos/NuGet/NuGet.Client/contents/{+path}","compare_url":"https://api.github.com/repos/NuGet/NuGet.Client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NuGet/NuGet.Client/merges","archive_url":"https://api.github.com/repos/NuGet/NuGet.Client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NuGet/NuGet.Client/downloads","issues_url":"https://api.github.com/repos/NuGet/NuGet.Client/issues{/number}","pulls_url":"https://api.github.com/repos/NuGet/NuGet.Client/pulls{/number}","milestones_url":"https://api.github.com/repos/NuGet/NuGet.Client/milestones{/number}","notifications_url":"https://api.github.com/repos/NuGet/NuGet.Client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NuGet/NuGet.Client/labels{/name}","releases_url":"https://api.github.com/repos/NuGet/NuGet.Client/releases{/id}","deployments_url":"https://api.github.com/repos/NuGet/NuGet.Client/deployments","created_at":"2014-04-30T23:46:11Z","updated_at":"2016-12-29T17:33:21Z","pushed_at":"2017-01-06T16:46:58Z","git_url":"git://github.com/NuGet/NuGet.Client.git","ssh_url":"git@github.com:NuGet/NuGet.Client.git","clone_url":"https://github.com/NuGet/NuGet.Client.git","svn_url":"https://github.com/NuGet/NuGet.Client","homepage":null,"size":24926,"stargazers_count":129,"watchers_count":129,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":169,"mirror_url":null,"open_issues_count":21,"forks":169,"open_issues":21,"watchers":129,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/NuGet/NuGet.Client/pulls/1088"},"html":{"href":"https://github.com/NuGet/NuGet.Client/pull/1088"},"issue":{"href":"https://api.github.com/repos/NuGet/NuGet.Client/issues/1088"},"comments":{"href":"https://api.github.com/repos/NuGet/NuGet.Client/issues/1088/comments"},"review_comments":{"href":"https://api.github.com/repos/NuGet/NuGet.Client/pulls/1088/comments"},"review_comment":{"href":"https://api.github.com/repos/NuGet/NuGet.Client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NuGet/NuGet.Client/pulls/1088/commits"},"statuses":{"href":"https://api.github.com/repos/NuGet/NuGet.Client/statuses/4e4cc92a746defbaae9be526e03fd943b7d13f15"}}}}
{"actor":{"display_login":"joelverhagen"}}