{"push_id":1492259012,"size":1,"distinct_size":1,"ref":"refs/heads/master","head":"a26eed06a020530ee3f4e4756e03a41cacd85c05","before":"70b2a3c0a2a5e77ee9c54483d34909cc3b853bfa","commits":[{"sha":"a26eed06a020530ee3f4e4756e03a41cacd85c05","author":{"name":"gifi","email":"b2eba25e00ca5b993cc64d531d9ce446b4a56230@outlook.com"},"message":"The tzname issue should vanish with this cleanup\n\nThe attempt in https://github.com/gifi/readr/pull/1 was a knee-jerk reaction after many failing builds. Looking further into the code, it occurs to me that the ```tzname``` variable was only needed at the line deleted in this commit. That line seemed to sit there doing nothing, and tests should check if so was it. But which tests?\r\n\r\nProvided this Bash function:\r\n```Bash\r\nprintf \"%s\\n\" 'function where_used() { pcregrep --recursive --line-number --context=2 --binary-files=without-match --colour \"\\\\b$1\\\\b\" . }' > util.sh\r\n```\r\nLet's _manually_ chase the ```localsub``` function's call stack.\r\nNote-1. All outputs coming from the ```tests``` directory are ignored until after the second ```pushd```.\r\nNote-2. Line numbering refers to the code as it soon will be (there are some other minor commits coming).\r\n\r\n```Bash\r\n$ pushd /path/to/readr\r\n\r\n$ where_used localsub\r\n# ./src/localtime.c:1679 =>> time2sub\r\n# ./src/localtime.c:1773 =>> time1\r\n# ./src/localtime.c:1807 =>> my_mktime\r\n\r\n$ where_used time2sub\r\n# ./src/localtime.c:1729 =>> time2\r\n\r\n$ where_used time1\r\n# ./src/localtime.c:1807 =>> my_mktime\r\n\r\n$ where_used my_mktime\r\n# ./src/DateTime.h:161 =>> localtime\r\n\r\n$ where_used time2\r\n# ./src/localtime.c:1750 =>> time1\r\n# ./src/localtime.c:1763 =>> time1\r\n# ./src/localtime.c:1793 =>> time1\r\n\r\n$ where_used localtime\r\n# ./src/DateTime.h:96 =>> datetime\r\n\r\n$ where_used datetime\r\n# ./src/DateTime.cpp:21 =>> utctime\r\n# ./src/Collector.cpp:146 =>> CollectorDateTime::setValue\r\n# ./src/CollectorGuess.cpp:139 =>> collectorGuess\r\n# ./R/collectors.R:361 =>> col_datetime\r\n\r\n$ popd && pushd tests/testthat\r\n\r\n$ where_used datetime\r\n# ./test-parsing-datetime.R:1:context(\"Parsing, datetime\")\r\n\r\n$ where_used utctime\r\n# ./test-parsing-datetime.R:3,11,20,29,48,206\r\n\r\n$ popd\r\n```\r\n\r\nShould ```tests/test-parsing-datetime.R``` should passes, it would be safe to go on with this cleanup and get rid of the tzname failure once for all.\r\n\r\n```R\r\ndevtools::test(\"readr\")\r\n# ...\r\n# Parsing, count_fields: ...\r\n# Parsing, datetime: ............W..................................................\r\n# Parsing, factors: .......\r\n# ...\r\n```\r\n\r\nThat's it!","distinct":true,"url":"https://api.github.com/repos/gifi/readr/commits/a26eed06a020530ee3f4e4756e03a41cacd85c05"}]}
{"actor":{"display_login":"gifi"}}