{"action":"created","comment":{"url":"https://api.github.com/repos/xcat2/xcat-core/pulls/comments/116000236","pull_request_review_id":37586217,"id":116000236,"diff_hunk":"@@ -317,6 +342,73 @@ sub run_rspconfig {\n \n }\n \n+sub config_vlan {\n+    # checking for port number, switches is checked earlier\n+    if ($::PORT) {\n+       $port = $::PORT;\n+    } else {\n+        xCAT::MsgUtils->message(\"E\",\"Error - When setting vlan, a port must be provided.\");","path":"xCAT-server/share/xcat/scripts/configMellanox","position":211,"original_position":211,"commit_id":"e9b8a3bbbf96b068ec7add801c747487dc1e3169","original_commit_id":"e9b8a3bbbf96b068ec7add801c747487dc1e3169","user":{"login":"whowutwut","id":10049070,"avatar_url":"https://avatars3.githubusercontent.com/u/10049070?v=3","gravatar_id":"","url":"https://api.github.com/users/whowutwut","html_url":"https://github.com/whowutwut","followers_url":"https://api.github.com/users/whowutwut/followers","following_url":"https://api.github.com/users/whowutwut/following{/other_user}","gists_url":"https://api.github.com/users/whowutwut/gists{/gist_id}","starred_url":"https://api.github.com/users/whowutwut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whowutwut/subscriptions","organizations_url":"https://api.github.com/users/whowutwut/orgs","repos_url":"https://api.github.com/users/whowutwut/repos","events_url":"https://api.github.com/users/whowutwut/events{/privacy}","received_events_url":"https://api.github.com/users/whowutwut/received_events","type":"User","site_admin":false},"body":"Suggest:  \"Error - When configuring VLAN, a port must be provided.\"","created_at":"2017-05-11T14:11:54Z","updated_at":"2017-05-11T14:31:18Z","html_url":"https://github.com/xcat2/xcat-core/pull/2994#discussion_r116000236","pull_request_url":"https://api.github.com/repos/xcat2/xcat-core/pulls/2994","_links":{"self":{"href":"https://api.github.com/repos/xcat2/xcat-core/pulls/comments/116000236"},"html":{"href":"https://github.com/xcat2/xcat-core/pull/2994#discussion_r116000236"},"pull_request":{"href":"https://api.github.com/repos/xcat2/xcat-core/pulls/2994"}}},"pull_request":{"url":"https://api.github.com/repos/xcat2/xcat-core/pulls/2994","id":119183086,"html_url":"https://github.com/xcat2/xcat-core/pull/2994","diff_url":"https://github.com/xcat2/xcat-core/pull/2994.diff","patch_url":"https://github.com/xcat2/xcat-core/pull/2994.patch","issue_url":"https://api.github.com/repos/xcat2/xcat-core/issues/2994","number":2994,"state":"open","locked":false,"title":"Add configration support for Mellanox Ethernet switch","user":{"login":"cxhong","id":12398836,"avatar_url":"https://avatars1.githubusercontent.com/u/12398836?v=3","gravatar_id":"","url":"https://api.github.com/users/cxhong","html_url":"https://github.com/cxhong","followers_url":"https://api.github.com/users/cxhong/followers","following_url":"https://api.github.com/users/cxhong/following{/other_user}","gists_url":"https://api.github.com/users/cxhong/gists{/gist_id}","starred_url":"https://api.github.com/users/cxhong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cxhong/subscriptions","organizations_url":"https://api.github.com/users/cxhong/orgs","repos_url":"https://api.github.com/users/cxhong/repos","events_url":"https://api.github.com/users/cxhong/events{/privacy}","received_events_url":"https://api.github.com/users/cxhong/received_events","type":"User","site_admin":false},"body":"Add Vlan support for Mellanox Ethernet Switch (sx1410 and sx1400), command:\r\n```` To set Vlan for interface commmand (only for Mellanox Ethernet switch) :\r\n        configMellanox --switches switchnames --port port --vlan vlan --mode mode\r\n\r\n     The following mode are supported for switchport:\r\n      * access        Only untagged ingress Ethernet packets are allowed\r\n      * trunk         Only tagged ingress Ethernet packets are allowed\r\n      * hybrid        Both tagged and untagged ingress Ethernet packets are allowed\r\n      * access-dcb    Only untagged ingress Ethernet packets are allowed. Egress packets will be priority tagged\r\n      * dot1q-tunnel  Both tagged and untagged ingress Ethernet packets are allowed. Egress packets are tagged with a second VLAN (802.1Q) header\r\n`````\r\nTo config vlan 21 on coresw01 port 20 with access mode: \r\n````\r\n#/opt/xcat/share/xcat/script/configMellanox --switches coresw01 --port 20 --vlan 21 --mode access\r\n````\r\nThe vlan is configured on switch:\r\n````\r\ncoresw01 [standalone: master] > show vlan id 21\r\n\r\nVLAN    Name                    Ports\r\n----    -----------             --------------------------------------\r\n21                              Eth1/20\r\n`````\r\n\r\n","created_at":"2017-05-05T14:05:13Z","updated_at":"2017-05-11T14:31:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e695b81750d9daef0fc7ecc5a88fe999cc227d5c","assignee":{"login":"whowutwut","id":10049070,"avatar_url":"https://avatars3.githubusercontent.com/u/10049070?v=3","gravatar_id":"","url":"https://api.github.com/users/whowutwut","html_url":"https://github.com/whowutwut","followers_url":"https://api.github.com/users/whowutwut/followers","following_url":"https://api.github.com/users/whowutwut/following{/other_user}","gists_url":"https://api.github.com/users/whowutwut/gists{/gist_id}","starred_url":"https://api.github.com/users/whowutwut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whowutwut/subscriptions","organizations_url":"https://api.github.com/users/whowutwut/orgs","repos_url":"https://api.github.com/users/whowutwut/repos","events_url":"https://api.github.com/users/whowutwut/events{/privacy}","received_events_url":"https://api.github.com/users/whowutwut/received_events","type":"User","site_admin":false},"assignees":[{"login":"whowutwut","id":10049070,"avatar_url":"https://avatars3.githubusercontent.com/u/10049070?v=3","gravatar_id":"","url":"https://api.github.com/users/whowutwut","html_url":"https://github.com/whowutwut","followers_url":"https://api.github.com/users/whowutwut/followers","following_url":"https://api.github.com/users/whowutwut/following{/other_user}","gists_url":"https://api.github.com/users/whowutwut/gists{/gist_id}","starred_url":"https://api.github.com/users/whowutwut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whowutwut/subscriptions","organizations_url":"https://api.github.com/users/whowutwut/orgs","repos_url":"https://api.github.com/users/whowutwut/repos","events_url":"https://api.github.com/users/whowutwut/events{/privacy}","received_events_url":"https://api.github.com/users/whowutwut/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"immarvin","id":5668922,"avatar_url":"https://avatars2.githubusercontent.com/u/5668922?v=3","gravatar_id":"","url":"https://api.github.com/users/immarvin","html_url":"https://github.com/immarvin","followers_url":"https://api.github.com/users/immarvin/followers","following_url":"https://api.github.com/users/immarvin/following{/other_user}","gists_url":"https://api.github.com/users/immarvin/gists{/gist_id}","starred_url":"https://api.github.com/users/immarvin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/immarvin/subscriptions","organizations_url":"https://api.github.com/users/immarvin/orgs","repos_url":"https://api.github.com/users/immarvin/repos","events_url":"https://api.github.com/users/immarvin/events{/privacy}","received_events_url":"https://api.github.com/users/immarvin/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/xcat2/xcat-core/milestones/27","html_url":"https://github.com/xcat2/xcat-core/milestone/27","labels_url":"https://api.github.com/repos/xcat2/xcat-core/milestones/27/labels","id":2381922,"number":27,"title":"2.13.4","description":"","creator":{"login":"whowutwut","id":10049070,"avatar_url":"https://avatars3.githubusercontent.com/u/10049070?v=3","gravatar_id":"","url":"https://api.github.com/users/whowutwut","html_url":"https://github.com/whowutwut","followers_url":"https://api.github.com/users/whowutwut/followers","following_url":"https://api.github.com/users/whowutwut/following{/other_user}","gists_url":"https://api.github.com/users/whowutwut/gists{/gist_id}","starred_url":"https://api.github.com/users/whowutwut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whowutwut/subscriptions","organizations_url":"https://api.github.com/users/whowutwut/orgs","repos_url":"https://api.github.com/users/whowutwut/repos","events_url":"https://api.github.com/users/whowutwut/events{/privacy}","received_events_url":"https://api.github.com/users/whowutwut/received_events","type":"User","site_admin":false},"open_issues":72,"closed_issues":137,"state":"open","created_at":"2017-03-13T13:27:05Z","updated_at":"2017-05-11T13:12:59Z","due_on":"2017-05-19T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/xcat2/xcat-core/pulls/2994/commits","review_comments_url":"https://api.github.com/repos/xcat2/xcat-core/pulls/2994/comments","review_comment_url":"https://api.github.com/repos/xcat2/xcat-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xcat2/xcat-core/issues/2994/comments","statuses_url":"https://api.github.com/repos/xcat2/xcat-core/statuses/e9b8a3bbbf96b068ec7add801c747487dc1e3169","head":{"label":"cxhong:mvlan","ref":"mvlan","sha":"e9b8a3bbbf96b068ec7add801c747487dc1e3169","user":{"login":"cxhong","id":12398836,"avatar_url":"https://avatars1.githubusercontent.com/u/12398836?v=3","gravatar_id":"","url":"https://api.github.com/users/cxhong","html_url":"https://github.com/cxhong","followers_url":"https://api.github.com/users/cxhong/followers","following_url":"https://api.github.com/users/cxhong/following{/other_user}","gists_url":"https://api.github.com/users/cxhong/gists{/gist_id}","starred_url":"https://api.github.com/users/cxhong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cxhong/subscriptions","organizations_url":"https://api.github.com/users/cxhong/orgs","repos_url":"https://api.github.com/users/cxhong/repos","events_url":"https://api.github.com/users/cxhong/events{/privacy}","received_events_url":"https://api.github.com/users/cxhong/received_events","type":"User","site_admin":false},"repo":{"id":41100712,"name":"xcat-core","full_name":"cxhong/xcat-core","owner":{"login":"cxhong","id":12398836,"avatar_url":"https://avatars1.githubusercontent.com/u/12398836?v=3","gravatar_id":"","url":"https://api.github.com/users/cxhong","html_url":"https://github.com/cxhong","followers_url":"https://api.github.com/users/cxhong/followers","following_url":"https://api.github.com/users/cxhong/following{/other_user}","gists_url":"https://api.github.com/users/cxhong/gists{/gist_id}","starred_url":"https://api.github.com/users/cxhong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cxhong/subscriptions","organizations_url":"https://api.github.com/users/cxhong/orgs","repos_url":"https://api.github.com/users/cxhong/repos","events_url":"https://api.github.com/users/cxhong/events{/privacy}","received_events_url":"https://api.github.com/users/cxhong/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cxhong/xcat-core","description":"Code repo for xCAT core packages","fork":true,"url":"https://api.github.com/repos/cxhong/xcat-core","forks_url":"https://api.github.com/repos/cxhong/xcat-core/forks","keys_url":"https://api.github.com/repos/cxhong/xcat-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cxhong/xcat-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cxhong/xcat-core/teams","hooks_url":"https://api.github.com/repos/cxhong/xcat-core/hooks","issue_events_url":"https://api.github.com/repos/cxhong/xcat-core/issues/events{/number}","events_url":"https://api.github.com/repos/cxhong/xcat-core/events","assignees_url":"https://api.github.com/repos/cxhong/xcat-core/assignees{/user}","branches_url":"https://api.github.com/repos/cxhong/xcat-core/branches{/branch}","tags_url":"https://api.github.com/repos/cxhong/xcat-core/tags","blobs_url":"https://api.github.com/repos/cxhong/xcat-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cxhong/xcat-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cxhong/xcat-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/cxhong/xcat-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cxhong/xcat-core/statuses/{sha}","languages_url":"https://api.github.com/repos/cxhong/xcat-core/languages","stargazers_url":"https://api.github.com/repos/cxhong/xcat-core/stargazers","contributors_url":"https://api.github.com/repos/cxhong/xcat-core/contributors","subscribers_url":"https://api.github.com/repos/cxhong/xcat-core/subscribers","subscription_url":"https://api.github.com/repos/cxhong/xcat-core/subscription","commits_url":"https://api.github.com/repos/cxhong/xcat-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/cxhong/xcat-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/cxhong/xcat-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/cxhong/xcat-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/cxhong/xcat-core/contents/{+path}","compare_url":"https://api.github.com/repos/cxhong/xcat-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cxhong/xcat-core/merges","archive_url":"https://api.github.com/repos/cxhong/xcat-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cxhong/xcat-core/downloads","issues_url":"https://api.github.com/repos/cxhong/xcat-core/issues{/number}","pulls_url":"https://api.github.com/repos/cxhong/xcat-core/pulls{/number}","milestones_url":"https://api.github.com/repos/cxhong/xcat-core/milestones{/number}","notifications_url":"https://api.github.com/repos/cxhong/xcat-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cxhong/xcat-core/labels{/name}","releases_url":"https://api.github.com/repos/cxhong/xcat-core/releases{/id}","deployments_url":"https://api.github.com/repos/cxhong/xcat-core/deployments","created_at":"2015-08-20T14:36:07Z","updated_at":"2016-01-15T23:03:44Z","pushed_at":"2017-05-10T17:48:47Z","git_url":"git://github.com/cxhong/xcat-core.git","ssh_url":"git@github.com:cxhong/xcat-core.git","clone_url":"https://github.com/cxhong/xcat-core.git","svn_url":"https://github.com/cxhong/xcat-core","homepage":null,"size":189968,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xcat2:master","ref":"master","sha":"6331ada77447f9eaaf4e6b71224f38d4d6643eff","user":{"login":"xcat2","id":10124414,"avatar_url":"https://avatars0.githubusercontent.com/u/10124414?v=3","gravatar_id":"","url":"https://api.github.com/users/xcat2","html_url":"https://github.com/xcat2","followers_url":"https://api.github.com/users/xcat2/followers","following_url":"https://api.github.com/users/xcat2/following{/other_user}","gists_url":"https://api.github.com/users/xcat2/gists{/gist_id}","starred_url":"https://api.github.com/users/xcat2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xcat2/subscriptions","organizations_url":"https://api.github.com/users/xcat2/orgs","repos_url":"https://api.github.com/users/xcat2/repos","events_url":"https://api.github.com/users/xcat2/events{/privacy}","received_events_url":"https://api.github.com/users/xcat2/received_events","type":"Organization","site_admin":false},"repo":{"id":27747508,"name":"xcat-core","full_name":"xcat2/xcat-core","owner":{"login":"xcat2","id":10124414,"avatar_url":"https://avatars0.githubusercontent.com/u/10124414?v=3","gravatar_id":"","url":"https://api.github.com/users/xcat2","html_url":"https://github.com/xcat2","followers_url":"https://api.github.com/users/xcat2/followers","following_url":"https://api.github.com/users/xcat2/following{/other_user}","gists_url":"https://api.github.com/users/xcat2/gists{/gist_id}","starred_url":"https://api.github.com/users/xcat2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xcat2/subscriptions","organizations_url":"https://api.github.com/users/xcat2/orgs","repos_url":"https://api.github.com/users/xcat2/repos","events_url":"https://api.github.com/users/xcat2/events{/privacy}","received_events_url":"https://api.github.com/users/xcat2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xcat2/xcat-core","description":"Code repo for xCAT core packages","fork":false,"url":"https://api.github.com/repos/xcat2/xcat-core","forks_url":"https://api.github.com/repos/xcat2/xcat-core/forks","keys_url":"https://api.github.com/repos/xcat2/xcat-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xcat2/xcat-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xcat2/xcat-core/teams","hooks_url":"https://api.github.com/repos/xcat2/xcat-core/hooks","issue_events_url":"https://api.github.com/repos/xcat2/xcat-core/issues/events{/number}","events_url":"https://api.github.com/repos/xcat2/xcat-core/events","assignees_url":"https://api.github.com/repos/xcat2/xcat-core/assignees{/user}","branches_url":"https://api.github.com/repos/xcat2/xcat-core/branches{/branch}","tags_url":"https://api.github.com/repos/xcat2/xcat-core/tags","blobs_url":"https://api.github.com/repos/xcat2/xcat-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xcat2/xcat-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xcat2/xcat-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/xcat2/xcat-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xcat2/xcat-core/statuses/{sha}","languages_url":"https://api.github.com/repos/xcat2/xcat-core/languages","stargazers_url":"https://api.github.com/repos/xcat2/xcat-core/stargazers","contributors_url":"https://api.github.com/repos/xcat2/xcat-core/contributors","subscribers_url":"https://api.github.com/repos/xcat2/xcat-core/subscribers","subscription_url":"https://api.github.com/repos/xcat2/xcat-core/subscription","commits_url":"https://api.github.com/repos/xcat2/xcat-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/xcat2/xcat-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/xcat2/xcat-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/xcat2/xcat-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/xcat2/xcat-core/contents/{+path}","compare_url":"https://api.github.com/repos/xcat2/xcat-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xcat2/xcat-core/merges","archive_url":"https://api.github.com/repos/xcat2/xcat-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xcat2/xcat-core/downloads","issues_url":"https://api.github.com/repos/xcat2/xcat-core/issues{/number}","pulls_url":"https://api.github.com/repos/xcat2/xcat-core/pulls{/number}","milestones_url":"https://api.github.com/repos/xcat2/xcat-core/milestones{/number}","notifications_url":"https://api.github.com/repos/xcat2/xcat-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xcat2/xcat-core/labels{/name}","releases_url":"https://api.github.com/repos/xcat2/xcat-core/releases{/id}","deployments_url":"https://api.github.com/repos/xcat2/xcat-core/deployments","created_at":"2014-12-09T03:21:50Z","updated_at":"2017-05-09T01:36:51Z","pushed_at":"2017-05-11T13:57:17Z","git_url":"git://github.com/xcat2/xcat-core.git","ssh_url":"git@github.com:xcat2/xcat-core.git","clone_url":"https://github.com/xcat2/xcat-core.git","svn_url":"https://github.com/xcat2/xcat-core","homepage":null,"size":190269,"stargazers_count":89,"watchers_count":89,"language":"Perl","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":84,"mirror_url":null,"open_issues_count":193,"forks":84,"open_issues":193,"watchers":89,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xcat2/xcat-core/pulls/2994"},"html":{"href":"https://github.com/xcat2/xcat-core/pull/2994"},"issue":{"href":"https://api.github.com/repos/xcat2/xcat-core/issues/2994"},"comments":{"href":"https://api.github.com/repos/xcat2/xcat-core/issues/2994/comments"},"review_comments":{"href":"https://api.github.com/repos/xcat2/xcat-core/pulls/2994/comments"},"review_comment":{"href":"https://api.github.com/repos/xcat2/xcat-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xcat2/xcat-core/pulls/2994/commits"},"statuses":{"href":"https://api.github.com/repos/xcat2/xcat-core/statuses/e9b8a3bbbf96b068ec7add801c747487dc1e3169"}}}}
{"actor":{"display_login":"whowutwut"}}