{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/125191570","pull_request_review_id":47558049,"id":125191570,"diff_hunk":"@@ -1,44 +1,73 @@\n 'use strict';\n-// Original test written by Jakub Lekstan <kuebzky@gmail.com>\n const common = require('../common');\n \n+// Original test written by Jakub Lekstan <kuebzky@gmail.com>\n+\n // FIXME add sunos support\n if (common.isSunOS) {\n   return common.skip(`Unsupported platform [${process.platform}]`);\n }\n \n const assert = require('assert');\n-const exec = require('child_process').exec;\n+const { exec, spawn } = require('child_process');\n const path = require('path');\n-\n // The title shouldn't be too long; libuv's uv_set_process_title() out of\n // security considerations no longer overwrites envp, only argv, so the\n // maximum title length is possibly quite short.\n-let title = String(process.pid);\n+const title = String(Date.now()).substr(-4, 4);","path":"test/parallel/test-setproctitle.js","position":21,"original_position":21,"commit_id":"80bd1a50e437e125dd69c7dea5b1e8def6043cc5","original_commit_id":"80bd1a50e437e125dd69c7dea5b1e8def6043cc5","user":{"login":"refack","id":96947,"avatar_url":"https://avatars0.githubusercontent.com/u/96947?v=3","gravatar_id":"","url":"https://api.github.com/users/refack","html_url":"https://github.com/refack","followers_url":"https://api.github.com/users/refack/followers","following_url":"https://api.github.com/users/refack/following{/other_user}","gists_url":"https://api.github.com/users/refack/gists{/gist_id}","starred_url":"https://api.github.com/users/refack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/refack/subscriptions","organizations_url":"https://api.github.com/users/refack/orgs","repos_url":"https://api.github.com/users/refack/repos","events_url":"https://api.github.com/users/refack/events{/privacy}","received_events_url":"https://api.github.com/users/refack/received_events","type":"User","site_admin":false},"body":"Ohhh. that's a good idea!\r\n...\r\nBut it only give us node's \"internal\" view, while `ps` gives us how the external system sees the title\r\n...\r\nThe issue with a constant value is that zombies will give us a false positive. We need a secret that only know to the testing process","created_at":"2017-07-02T20:21:29Z","updated_at":"2017-07-02T20:21:30Z","html_url":"https://github.com/nodejs/node/pull/14042#discussion_r125191570","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/14042","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/125191570"},"html":{"href":"https://github.com/nodejs/node/pull/14042#discussion_r125191570"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/14042"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/14042","id":128532364,"html_url":"https://github.com/nodejs/node/pull/14042","diff_url":"https://github.com/nodejs/node/pull/14042.diff","patch_url":"https://github.com/nodejs/node/pull/14042.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/14042","number":14042,"state":"open","locked":false,"title":"test: implement setproctitle for windows","user":{"login":"refack","id":96947,"avatar_url":"https://avatars0.githubusercontent.com/u/96947?v=3","gravatar_id":"","url":"https://api.github.com/users/refack","html_url":"https://github.com/refack","followers_url":"https://api.github.com/users/refack/followers","following_url":"https://api.github.com/users/refack/following{/other_user}","gists_url":"https://api.github.com/users/refack/gists{/gist_id}","starred_url":"https://api.github.com/users/refack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/refack/subscriptions","organizations_url":"https://api.github.com/users/refack/orgs","repos_url":"https://api.github.com/users/refack/repos","events_url":"https://api.github.com/users/refack/events{/privacy}","received_events_url":"https://api.github.com/users/refack/received_events","type":"User","site_admin":false},"body":"Fixes: https://github.com/nodejs/node/issues/14039\r\n<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [X] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [X] tests and/or benchmarks are included\r\n- [X] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines)\r\n\r\n##### Affected core subsystem(s)\r\ntest,process,windows\r\n","created_at":"2017-07-02T20:07:31Z","updated_at":"2017-07-02T20:21:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8a6d852906f17c5e5cd4f3449c2a6b2943065f5f","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/14042/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/14042/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/14042/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/80bd1a50e437e125dd69c7dea5b1e8def6043cc5","head":{"label":"refack:complete-test-setproctitle","ref":"complete-test-setproctitle","sha":"80bd1a50e437e125dd69c7dea5b1e8def6043cc5","user":{"login":"refack","id":96947,"avatar_url":"https://avatars0.githubusercontent.com/u/96947?v=3","gravatar_id":"","url":"https://api.github.com/users/refack","html_url":"https://github.com/refack","followers_url":"https://api.github.com/users/refack/followers","following_url":"https://api.github.com/users/refack/following{/other_user}","gists_url":"https://api.github.com/users/refack/gists{/gist_id}","starred_url":"https://api.github.com/users/refack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/refack/subscriptions","organizations_url":"https://api.github.com/users/refack/orgs","repos_url":"https://api.github.com/users/refack/repos","events_url":"https://api.github.com/users/refack/events{/privacy}","received_events_url":"https://api.github.com/users/refack/received_events","type":"User","site_admin":false},"repo":{"id":81225016,"name":"node","full_name":"refack/node","owner":{"login":"refack","id":96947,"avatar_url":"https://avatars0.githubusercontent.com/u/96947?v=3","gravatar_id":"","url":"https://api.github.com/users/refack","html_url":"https://github.com/refack","followers_url":"https://api.github.com/users/refack/followers","following_url":"https://api.github.com/users/refack/following{/other_user}","gists_url":"https://api.github.com/users/refack/gists{/gist_id}","starred_url":"https://api.github.com/users/refack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/refack/subscriptions","organizations_url":"https://api.github.com/users/refack/orgs","repos_url":"https://api.github.com/users/refack/repos","events_url":"https://api.github.com/users/refack/events{/privacy}","received_events_url":"https://api.github.com/users/refack/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/refack/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/refack/node","forks_url":"https://api.github.com/repos/refack/node/forks","keys_url":"https://api.github.com/repos/refack/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/refack/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/refack/node/teams","hooks_url":"https://api.github.com/repos/refack/node/hooks","issue_events_url":"https://api.github.com/repos/refack/node/issues/events{/number}","events_url":"https://api.github.com/repos/refack/node/events","assignees_url":"https://api.github.com/repos/refack/node/assignees{/user}","branches_url":"https://api.github.com/repos/refack/node/branches{/branch}","tags_url":"https://api.github.com/repos/refack/node/tags","blobs_url":"https://api.github.com/repos/refack/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/refack/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/refack/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/refack/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/refack/node/statuses/{sha}","languages_url":"https://api.github.com/repos/refack/node/languages","stargazers_url":"https://api.github.com/repos/refack/node/stargazers","contributors_url":"https://api.github.com/repos/refack/node/contributors","subscribers_url":"https://api.github.com/repos/refack/node/subscribers","subscription_url":"https://api.github.com/repos/refack/node/subscription","commits_url":"https://api.github.com/repos/refack/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/refack/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/refack/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/refack/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/refack/node/contents/{+path}","compare_url":"https://api.github.com/repos/refack/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/refack/node/merges","archive_url":"https://api.github.com/repos/refack/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/refack/node/downloads","issues_url":"https://api.github.com/repos/refack/node/issues{/number}","pulls_url":"https://api.github.com/repos/refack/node/pulls{/number}","milestones_url":"https://api.github.com/repos/refack/node/milestones{/number}","notifications_url":"https://api.github.com/repos/refack/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/refack/node/labels{/name}","releases_url":"https://api.github.com/repos/refack/node/releases{/id}","deployments_url":"https://api.github.com/repos/refack/node/deployments","created_at":"2017-02-07T15:47:09Z","updated_at":"2017-03-14T22:19:54Z","pushed_at":"2017-07-02T20:05:25Z","git_url":"git://github.com/refack/node.git","ssh_url":"git@github.com:refack/node.git","clone_url":"https://github.com/refack/node.git","svn_url":"https://github.com/refack/node","homepage":"https://nodejs.org","size":299502,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"ea927b3711dbd8032709dfec6f9736a181a522b9","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars0.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars0.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2017-07-02T19:27:58Z","pushed_at":"2017-07-02T20:07:32Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":296863,"stargazers_count":36620,"watchers_count":36620,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7105,"mirror_url":null,"open_issues_count":1047,"forks":7105,"open_issues":1047,"watchers":36620,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/14042"},"html":{"href":"https://github.com/nodejs/node/pull/14042"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/14042"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/14042/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/14042/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/14042/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/80bd1a50e437e125dd69c7dea5b1e8def6043cc5"}}}}
{"actor":{"display_login":"refack"}}