{"action":"created","issue":{"url":"https://api.github.com/repos/platformsh/platformsh-docs/issues/614","repository_url":"https://api.github.com/repos/platformsh/platformsh-docs","labels_url":"https://api.github.com/repos/platformsh/platformsh-docs/issues/614/labels{/name}","comments_url":"https://api.github.com/repos/platformsh/platformsh-docs/issues/614/comments","events_url":"https://api.github.com/repos/platformsh/platformsh-docs/issues/614/events","html_url":"https://github.com/platformsh/platformsh-docs/pull/614","id":246394929,"number":614,"title":"Added clarifications that these are examples","user":{"login":"martinpierrefrenette","id":29860652,"avatar_url":"https://avatars1.githubusercontent.com/u/29860652?v=4","gravatar_id":"","url":"https://api.github.com/users/martinpierrefrenette","html_url":"https://github.com/martinpierrefrenette","followers_url":"https://api.github.com/users/martinpierrefrenette/followers","following_url":"https://api.github.com/users/martinpierrefrenette/following{/other_user}","gists_url":"https://api.github.com/users/martinpierrefrenette/gists{/gist_id}","starred_url":"https://api.github.com/users/martinpierrefrenette/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinpierrefrenette/subscriptions","organizations_url":"https://api.github.com/users/martinpierrefrenette/orgs","repos_url":"https://api.github.com/users/martinpierrefrenette/repos","events_url":"https://api.github.com/users/martinpierrefrenette/events{/privacy}","received_events_url":"https://api.github.com/users/martinpierrefrenette/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-07-28T16:19:27Z","updated_at":"2017-07-28T17:13:17Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/platformsh/platformsh-docs/pulls/614","html_url":"https://github.com/platformsh/platformsh-docs/pull/614","diff_url":"https://github.com/platformsh/platformsh-docs/pull/614.diff","patch_url":"https://github.com/platformsh/platformsh-docs/pull/614.patch"},"body":"We have a client who actually used the DNS examples from the documentation instead of their own DNS entries. This brought their site down, as they thought our documentation was showing the actual DNS entries to put.\r\n\r\nI added disclaimers to make it clear."},"comment":{"url":"https://api.github.com/repos/platformsh/platformsh-docs/issues/comments/318710962","html_url":"https://github.com/platformsh/platformsh-docs/pull/614#issuecomment-318710962","issue_url":"https://api.github.com/repos/platformsh/platformsh-docs/issues/614","id":318710962,"user":{"login":"sruggier","id":427071,"avatar_url":"https://avatars2.githubusercontent.com/u/427071?v=4","gravatar_id":"","url":"https://api.github.com/users/sruggier","html_url":"https://github.com/sruggier","followers_url":"https://api.github.com/users/sruggier/followers","following_url":"https://api.github.com/users/sruggier/following{/other_user}","gists_url":"https://api.github.com/users/sruggier/gists{/gist_id}","starred_url":"https://api.github.com/users/sruggier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sruggier/subscriptions","organizations_url":"https://api.github.com/users/sruggier/orgs","repos_url":"https://api.github.com/users/sruggier/repos","events_url":"https://api.github.com/users/sruggier/events{/privacy}","received_events_url":"https://api.github.com/users/sruggier/received_events","type":"User","site_admin":false},"created_at":"2017-07-28T17:13:17Z","updated_at":"2017-07-28T17:13:17Z","body":"I think this change adds a lot of unnecessary visual noise, given that the document already clearly states that it's an example at the beginning of the section.\r\n\r\nIf the goal is to prevent people from taking their site down by putting bogus values in the DNS, I think a better way to reduce the chance of that would be to move away from using example values that could be mistakenly used, such as `master-def456-abc123.us.platform.sh`, and instead use placeholders, like `master-7rqtwti-<your project ID>.us.platform.sh`. That should reduce the likelihood that a user would use the example value without customizing it for their site."}}
{"actor":{"display_login":"sruggier"}}