{"action":"created","issue":{"url":"https://api.github.com/repos/golang/go/issues/21844","repository_url":"https://api.github.com/repos/golang/go","labels_url":"https://api.github.com/repos/golang/go/issues/21844/labels{/name}","comments_url":"https://api.github.com/repos/golang/go/issues/21844/comments","events_url":"https://api.github.com/repos/golang/go/issues/21844/events","html_url":"https://github.com/golang/go/issues/21844","id":256955235,"number":21844,"title":"template/html: template.HTML strings escaped (Go 1.9 regression)","user":{"login":"bep","id":394382,"avatar_url":"https://avatars1.githubusercontent.com/u/394382?v=4","gravatar_id":"","url":"https://api.github.com/users/bep","html_url":"https://github.com/bep","followers_url":"https://api.github.com/users/bep/followers","following_url":"https://api.github.com/users/bep/following{/other_user}","gists_url":"https://api.github.com/users/bep/gists{/gist_id}","starred_url":"https://api.github.com/users/bep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bep/subscriptions","organizations_url":"https://api.github.com/users/bep/orgs","repos_url":"https://api.github.com/users/bep/repos","events_url":"https://api.github.com/users/bep/events{/privacy}","received_events_url":"https://api.github.com/users/bep/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/golang/go/milestones/60","html_url":"https://github.com/golang/go/milestone/60","labels_url":"https://api.github.com/repos/golang/go/milestones/60/labels","id":2814851,"number":60,"title":"Go1.9.2","description":"","creator":{"login":"rsc","id":104030,"avatar_url":"https://avatars1.githubusercontent.com/u/104030?v=4","gravatar_id":"","url":"https://api.github.com/users/rsc","html_url":"https://github.com/rsc","followers_url":"https://api.github.com/users/rsc/followers","following_url":"https://api.github.com/users/rsc/following{/other_user}","gists_url":"https://api.github.com/users/rsc/gists{/gist_id}","starred_url":"https://api.github.com/users/rsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsc/subscriptions","organizations_url":"https://api.github.com/users/rsc/orgs","repos_url":"https://api.github.com/users/rsc/repos","events_url":"https://api.github.com/users/rsc/events{/privacy}","received_events_url":"https://api.github.com/users/rsc/received_events","type":"User","site_admin":false},"open_issues":32,"closed_issues":0,"state":"open","created_at":"2017-10-04T15:40:09Z","updated_at":"2017-10-13T17:49:22Z","due_on":null,"closed_at":null},"comments":23,"created_at":"2017-09-12T08:12:55Z","updated_at":"2017-10-13T18:06:37Z","closed_at":null,"author_association":"NONE","body":"This has been reported by several users in the wild after we released Hugo 0.27 built on Go 1.9.\r\n\r\nI have tried to make a simple standalone and failing test case, not yet successful.\r\n\r\nI have, however, a failing test inside Hugo: \r\nhttps://travis-ci.org/gohugoio/hugo/builds/274496313?utm_source=github_status&utm_medium=notification\r\n\r\nIt passes fine on Go 1.8.3, fails on Go 1.9 and tip.\r\n\r\nSee https://github.com/gohugoio/hugo/pull/3878\r\n\r\nThe gist of it seems to be:\r\n\r\n* HTML strings put into the template context, i.e. data fetched from external resources such as Twitter (Tweets) and Instagram.\r\n* These are wrapped as `template.HTML` types to mark them as safe.\r\n\r\nNote that we have had plenty of similar and passing tests in Hugo, so there is a corner case here that I don't fully understand.\r\n\r\nI will go back to using Go 1.8.3 (where I can).\r\n"},"comment":{"url":"https://api.github.com/repos/golang/go/issues/comments/336526781","html_url":"https://github.com/golang/go/issues/21844#issuecomment-336526781","issue_url":"https://api.github.com/repos/golang/go/issues/21844","id":336526781,"user":{"login":"bep","id":394382,"avatar_url":"https://avatars1.githubusercontent.com/u/394382?v=4","gravatar_id":"","url":"https://api.github.com/users/bep","html_url":"https://github.com/bep","followers_url":"https://api.github.com/users/bep/followers","following_url":"https://api.github.com/users/bep/following{/other_user}","gists_url":"https://api.github.com/users/bep/gists{/gist_id}","starred_url":"https://api.github.com/users/bep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bep/subscriptions","organizations_url":"https://api.github.com/users/bep/orgs","repos_url":"https://api.github.com/users/bep/repos","events_url":"https://api.github.com/users/bep/events{/privacy}","received_events_url":"https://api.github.com/users/bep/received_events","type":"User","site_admin":false},"created_at":"2017-10-13T18:06:37Z","updated_at":"2017-10-13T18:06:37Z","author_association":"NONE","body":"@rsc Hugo is fine. We don't need this fix. As I understand the fix, we would still need to do the current workaround. Which is fine. \r\n\r\nWhether this qualifies as a 1.9.2 fix is a judgement you have to take: There may be unknown bugs in the wild from the Go 1.9 release because of this which would get an `Error` (better than not knowing) with this patch."}}
{"actor":{"display_login":"bep"}}