{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla/fxa-auth-server/issues/1873","repository_url":"https://api.github.com/repos/mozilla/fxa-auth-server","labels_url":"https://api.github.com/repos/mozilla/fxa-auth-server/issues/1873/labels{/name}","comments_url":"https://api.github.com/repos/mozilla/fxa-auth-server/issues/1873/comments","events_url":"https://api.github.com/repos/mozilla/fxa-auth-server/issues/1873/events","html_url":"https://github.com/mozilla/fxa-auth-server/issues/1873","id":225384335,"number":1873,"title":"Add an explicit push-endpoint-status flag to device records","user":{"login":"rfk","id":34695,"avatar_url":"https://avatars3.githubusercontent.com/u/34695?v=4","gravatar_id":"","url":"https://api.github.com/users/rfk","html_url":"https://github.com/rfk","followers_url":"https://api.github.com/users/rfk/followers","following_url":"https://api.github.com/users/rfk/following{/other_user}","gists_url":"https://api.github.com/users/rfk/gists{/gist_id}","starred_url":"https://api.github.com/users/rfk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rfk/subscriptions","organizations_url":"https://api.github.com/users/rfk/orgs","repos_url":"https://api.github.com/users/rfk/repos","events_url":"https://api.github.com/users/rfk/events{/privacy}","received_events_url":"https://api.github.com/users/rfk/received_events","type":"User","site_admin":false},"labels":[{"id":243443112,"url":"https://api.github.com/repos/mozilla/fxa-auth-server/labels/waffle:next","name":"waffle:next","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/mozilla/fxa-auth-server/milestones/82","html_url":"https://github.com/mozilla/fxa-auth-server/milestone/82","labels_url":"https://api.github.com/repos/mozilla/fxa-auth-server/milestones/82/labels","id":2484981,"number":82,"title":"FxA-123: Device manager quality","description":"https://api.github.com/repos/mozilla/fxa-features/issues/123","creator":{"login":"rfk","id":34695,"avatar_url":"https://avatars3.githubusercontent.com/u/34695?v=4","gravatar_id":"","url":"https://api.github.com/users/rfk","html_url":"https://github.com/rfk","followers_url":"https://api.github.com/users/rfk/followers","following_url":"https://api.github.com/users/rfk/following{/other_user}","gists_url":"https://api.github.com/users/rfk/gists{/gist_id}","starred_url":"https://api.github.com/users/rfk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rfk/subscriptions","organizations_url":"https://api.github.com/users/rfk/orgs","repos_url":"https://api.github.com/users/rfk/repos","events_url":"https://api.github.com/users/rfk/events{/privacy}","received_events_url":"https://api.github.com/users/rfk/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":3,"state":"open","created_at":"2017-04-27T02:40:54Z","updated_at":"2017-07-13T15:58:50Z","due_on":null,"closed_at":null},"comments":4,"created_at":"2017-05-01T04:43:48Z","updated_at":"2017-07-27T06:46:31Z","closed_at":null,"body":"Per discussion in https://bugzilla.mozilla.org/show_bug.cgi?id=1359279\r\n\r\nCurrently if we detect that a device's push endpoint is no longer working, we just delete the invalid endpoint from its device record.  To make it easier for the client to recover, we should instead set an explicit flag saying that the device record is state and needs to be updated.\r\n\r\nISTM the simplest possible thing is a \"pushEndpointExpired\" flag which can default to false, but be set to true when we discover that the push endpoint has expired.  It's probably useful to make this state visible to other connected devices as well.\r\n\r\n@vladikoff does this sound reasonable?  Always good to get a second opinion on these things :-)"},"comment":{"url":"https://api.github.com/repos/mozilla/fxa-auth-server/issues/comments/318274237","html_url":"https://github.com/mozilla/fxa-auth-server/issues/1873#issuecomment-318274237","issue_url":"https://api.github.com/repos/mozilla/fxa-auth-server/issues/1873","id":318274237,"user":{"login":"philbooth","id":64367,"avatar_url":"https://avatars2.githubusercontent.com/u/64367?v=4","gravatar_id":"","url":"https://api.github.com/users/philbooth","html_url":"https://github.com/philbooth","followers_url":"https://api.github.com/users/philbooth/followers","following_url":"https://api.github.com/users/philbooth/following{/other_user}","gists_url":"https://api.github.com/users/philbooth/gists{/gist_id}","starred_url":"https://api.github.com/users/philbooth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philbooth/subscriptions","organizations_url":"https://api.github.com/users/philbooth/orgs","repos_url":"https://api.github.com/users/philbooth/repos","events_url":"https://api.github.com/users/philbooth/events{/privacy}","received_events_url":"https://api.github.com/users/philbooth/received_events","type":"User","site_admin":false},"created_at":"2017-07-27T06:46:31Z","updated_at":"2017-07-27T06:46:31Z","body":"> I don't anticipate any additional changes we want to make to the devices table in the short-term so we could do this as a stand-alone migration; @philbooth can you think of any?\r\n\r\nI can't."}}
{"actor":{"display_login":"philbooth"}}