{"action":"opened","number":9368,"pull_request":{"url":"https://api.github.com/repos/magento/magento2/pulls/9368","id":117157703,"html_url":"https://github.com/magento/magento2/pull/9368","diff_url":"https://github.com/magento/magento2/pull/9368.diff","patch_url":"https://github.com/magento/magento2/pull/9368.patch","issue_url":"https://api.github.com/repos/magento/magento2/issues/9368","number":9368,"state":"open","locked":false,"title":"Redis sess: fix path for persistent_identifier & compression_threshold","user":{"login":"LukeHandle","id":799079,"avatar_url":"https://avatars0.githubusercontent.com/u/799079?v=3","gravatar_id":"","url":"https://api.github.com/users/LukeHandle","html_url":"https://github.com/LukeHandle","followers_url":"https://api.github.com/users/LukeHandle/followers","following_url":"https://api.github.com/users/LukeHandle/following{/other_user}","gists_url":"https://api.github.com/users/LukeHandle/gists{/gist_id}","starred_url":"https://api.github.com/users/LukeHandle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LukeHandle/subscriptions","organizations_url":"https://api.github.com/users/LukeHandle/orgs","repos_url":"https://api.github.com/users/LukeHandle/repos","events_url":"https://api.github.com/users/LukeHandle/events{/privacy}","received_events_url":"https://api.github.com/users/LukeHandle/received_events","type":"User","site_admin":false},"body":"Currently, the paths for both `persistent_identifier` & `compression_threshold` are prefixed with `param_`. This is against both the documentation and it does not follow the standard used throughout the configuration. This PR removes the prefix.\r\n\r\nDocs:\r\nhttps://github.com/magento/devdocs/blob/develop/guides/v2.0/config-guide/redis/redis-session.md#configure-magento-to-use-redis-for-session-storage\r\n\r\n### Fixed Issues (if relevant)\r\n\r\nCurrently, `persistent_identifier` and `compression_threshold` are ignored in the Redis session configuration (the documented options for configuring).\r\n\r\n### Manual testing scenarios\r\n\r\nChange `compression_threshold` to 1 and the sessions will not be compressed. Changing the name to be `param_compression_threshold` results in compression.\r\n\r\n### Contribution checklist\r\n - [x] Pull request has a meaningful description of its purpose\r\n - [x] All commits are accompanied by meaningful commit messages\r\n - [ ] All new or changed code is covered with unit/integration tests (if applicable)\r\n - [ ] All automated tests passed successfully (all builds on Travis CI are green)\r\n","created_at":"2017-04-23T17:17:38Z","updated_at":"2017-04-23T17:17:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/magento/magento2/pulls/9368/commits","review_comments_url":"https://api.github.com/repos/magento/magento2/pulls/9368/comments","review_comment_url":"https://api.github.com/repos/magento/magento2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/magento/magento2/issues/9368/comments","statuses_url":"https://api.github.com/repos/magento/magento2/statuses/e3862231f93a80d5dc5fa643404f4381f1a2e86a","head":{"label":"LukeHandle:patch-1","ref":"patch-1","sha":"e3862231f93a80d5dc5fa643404f4381f1a2e86a","user":{"login":"LukeHandle","id":799079,"avatar_url":"https://avatars0.githubusercontent.com/u/799079?v=3","gravatar_id":"","url":"https://api.github.com/users/LukeHandle","html_url":"https://github.com/LukeHandle","followers_url":"https://api.github.com/users/LukeHandle/followers","following_url":"https://api.github.com/users/LukeHandle/following{/other_user}","gists_url":"https://api.github.com/users/LukeHandle/gists{/gist_id}","starred_url":"https://api.github.com/users/LukeHandle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LukeHandle/subscriptions","organizations_url":"https://api.github.com/users/LukeHandle/orgs","repos_url":"https://api.github.com/users/LukeHandle/repos","events_url":"https://api.github.com/users/LukeHandle/events{/privacy}","received_events_url":"https://api.github.com/users/LukeHandle/received_events","type":"User","site_admin":false},"repo":{"id":89157395,"name":"magento2","full_name":"LukeHandle/magento2","owner":{"login":"LukeHandle","id":799079,"avatar_url":"https://avatars0.githubusercontent.com/u/799079?v=3","gravatar_id":"","url":"https://api.github.com/users/LukeHandle","html_url":"https://github.com/LukeHandle","followers_url":"https://api.github.com/users/LukeHandle/followers","following_url":"https://api.github.com/users/LukeHandle/following{/other_user}","gists_url":"https://api.github.com/users/LukeHandle/gists{/gist_id}","starred_url":"https://api.github.com/users/LukeHandle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LukeHandle/subscriptions","organizations_url":"https://api.github.com/users/LukeHandle/orgs","repos_url":"https://api.github.com/users/LukeHandle/repos","events_url":"https://api.github.com/users/LukeHandle/events{/privacy}","received_events_url":"https://api.github.com/users/LukeHandle/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/LukeHandle/magento2","description":"All Submissions you make to Magento Inc. (“Magento\") through GitHub are subject to the following terms and conditions: (1) You grant Magento a perpetual, worldwide, non-exclusive, no charge, royalty free, irrevocable license under your applicable copyrights and patents to reproduce, prepare derivative works of, display, publically perform, sublicense and distribute any feedback, ideas, code, or other information (“Submission\") you submit through GitHub. (2) Your Submission is an original work of authorship and you are the owner or are legally entitled to grant the license stated above. (3) You agree to the Contributor License Agreement found here:  https://github.com/magento/magento2/blob/master/CONTRIBUTOR_LICENSE_AGREEMENT.html","fork":true,"url":"https://api.github.com/repos/LukeHandle/magento2","forks_url":"https://api.github.com/repos/LukeHandle/magento2/forks","keys_url":"https://api.github.com/repos/LukeHandle/magento2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LukeHandle/magento2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LukeHandle/magento2/teams","hooks_url":"https://api.github.com/repos/LukeHandle/magento2/hooks","issue_events_url":"https://api.github.com/repos/LukeHandle/magento2/issues/events{/number}","events_url":"https://api.github.com/repos/LukeHandle/magento2/events","assignees_url":"https://api.github.com/repos/LukeHandle/magento2/assignees{/user}","branches_url":"https://api.github.com/repos/LukeHandle/magento2/branches{/branch}","tags_url":"https://api.github.com/repos/LukeHandle/magento2/tags","blobs_url":"https://api.github.com/repos/LukeHandle/magento2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LukeHandle/magento2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LukeHandle/magento2/git/refs{/sha}","trees_url":"https://api.github.com/repos/LukeHandle/magento2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LukeHandle/magento2/statuses/{sha}","languages_url":"https://api.github.com/repos/LukeHandle/magento2/languages","stargazers_url":"https://api.github.com/repos/LukeHandle/magento2/stargazers","contributors_url":"https://api.github.com/repos/LukeHandle/magento2/contributors","subscribers_url":"https://api.github.com/repos/LukeHandle/magento2/subscribers","subscription_url":"https://api.github.com/repos/LukeHandle/magento2/subscription","commits_url":"https://api.github.com/repos/LukeHandle/magento2/commits{/sha}","git_commits_url":"https://api.github.com/repos/LukeHandle/magento2/git/commits{/sha}","comments_url":"https://api.github.com/repos/LukeHandle/magento2/comments{/number}","issue_comment_url":"https://api.github.com/repos/LukeHandle/magento2/issues/comments{/number}","contents_url":"https://api.github.com/repos/LukeHandle/magento2/contents/{+path}","compare_url":"https://api.github.com/repos/LukeHandle/magento2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LukeHandle/magento2/merges","archive_url":"https://api.github.com/repos/LukeHandle/magento2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LukeHandle/magento2/downloads","issues_url":"https://api.github.com/repos/LukeHandle/magento2/issues{/number}","pulls_url":"https://api.github.com/repos/LukeHandle/magento2/pulls{/number}","milestones_url":"https://api.github.com/repos/LukeHandle/magento2/milestones{/number}","notifications_url":"https://api.github.com/repos/LukeHandle/magento2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LukeHandle/magento2/labels{/name}","releases_url":"https://api.github.com/repos/LukeHandle/magento2/releases{/id}","deployments_url":"https://api.github.com/repos/LukeHandle/magento2/deployments","created_at":"2017-04-23T16:50:26Z","updated_at":"2017-04-23T16:51:19Z","pushed_at":"2017-04-23T17:12:28Z","git_url":"git://github.com/LukeHandle/magento2.git","ssh_url":"git@github.com:LukeHandle/magento2.git","clone_url":"https://github.com/LukeHandle/magento2.git","svn_url":"https://github.com/LukeHandle/magento2","homepage":"http://www.magento.com","size":362054,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"magento:develop","ref":"develop","sha":"bbe3ee043c7a4dde2f85a0a49436bc033a5960a6","user":{"login":"magento","id":168457,"avatar_url":"https://avatars1.githubusercontent.com/u/168457?v=3","gravatar_id":"","url":"https://api.github.com/users/magento","html_url":"https://github.com/magento","followers_url":"https://api.github.com/users/magento/followers","following_url":"https://api.github.com/users/magento/following{/other_user}","gists_url":"https://api.github.com/users/magento/gists{/gist_id}","starred_url":"https://api.github.com/users/magento/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magento/subscriptions","organizations_url":"https://api.github.com/users/magento/orgs","repos_url":"https://api.github.com/users/magento/repos","events_url":"https://api.github.com/users/magento/events{/privacy}","received_events_url":"https://api.github.com/users/magento/received_events","type":"Organization","site_admin":false},"repo":{"id":2884111,"name":"magento2","full_name":"magento/magento2","owner":{"login":"magento","id":168457,"avatar_url":"https://avatars1.githubusercontent.com/u/168457?v=3","gravatar_id":"","url":"https://api.github.com/users/magento","html_url":"https://github.com/magento","followers_url":"https://api.github.com/users/magento/followers","following_url":"https://api.github.com/users/magento/following{/other_user}","gists_url":"https://api.github.com/users/magento/gists{/gist_id}","starred_url":"https://api.github.com/users/magento/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magento/subscriptions","organizations_url":"https://api.github.com/users/magento/orgs","repos_url":"https://api.github.com/users/magento/repos","events_url":"https://api.github.com/users/magento/events{/privacy}","received_events_url":"https://api.github.com/users/magento/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/magento/magento2","description":"All Submissions you make to Magento Inc. (“Magento\") through GitHub are subject to the following terms and conditions: (1) You grant Magento a perpetual, worldwide, non-exclusive, no charge, royalty free, irrevocable license under your applicable copyrights and patents to reproduce, prepare derivative works of, display, publically perform, sublicense and distribute any feedback, ideas, code, or other information (“Submission\") you submit through GitHub. (2) Your Submission is an original work of authorship and you are the owner or are legally entitled to grant the license stated above. (3) You agree to the Contributor License Agreement found here:  https://github.com/magento/magento2/blob/master/CONTRIBUTOR_LICENSE_AGREEMENT.html","fork":false,"url":"https://api.github.com/repos/magento/magento2","forks_url":"https://api.github.com/repos/magento/magento2/forks","keys_url":"https://api.github.com/repos/magento/magento2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/magento/magento2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/magento/magento2/teams","hooks_url":"https://api.github.com/repos/magento/magento2/hooks","issue_events_url":"https://api.github.com/repos/magento/magento2/issues/events{/number}","events_url":"https://api.github.com/repos/magento/magento2/events","assignees_url":"https://api.github.com/repos/magento/magento2/assignees{/user}","branches_url":"https://api.github.com/repos/magento/magento2/branches{/branch}","tags_url":"https://api.github.com/repos/magento/magento2/tags","blobs_url":"https://api.github.com/repos/magento/magento2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/magento/magento2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/magento/magento2/git/refs{/sha}","trees_url":"https://api.github.com/repos/magento/magento2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/magento/magento2/statuses/{sha}","languages_url":"https://api.github.com/repos/magento/magento2/languages","stargazers_url":"https://api.github.com/repos/magento/magento2/stargazers","contributors_url":"https://api.github.com/repos/magento/magento2/contributors","subscribers_url":"https://api.github.com/repos/magento/magento2/subscribers","subscription_url":"https://api.github.com/repos/magento/magento2/subscription","commits_url":"https://api.github.com/repos/magento/magento2/commits{/sha}","git_commits_url":"https://api.github.com/repos/magento/magento2/git/commits{/sha}","comments_url":"https://api.github.com/repos/magento/magento2/comments{/number}","issue_comment_url":"https://api.github.com/repos/magento/magento2/issues/comments{/number}","contents_url":"https://api.github.com/repos/magento/magento2/contents/{+path}","compare_url":"https://api.github.com/repos/magento/magento2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/magento/magento2/merges","archive_url":"https://api.github.com/repos/magento/magento2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/magento/magento2/downloads","issues_url":"https://api.github.com/repos/magento/magento2/issues{/number}","pulls_url":"https://api.github.com/repos/magento/magento2/pulls{/number}","milestones_url":"https://api.github.com/repos/magento/magento2/milestones{/number}","notifications_url":"https://api.github.com/repos/magento/magento2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/magento/magento2/labels{/name}","releases_url":"https://api.github.com/repos/magento/magento2/releases{/id}","deployments_url":"https://api.github.com/repos/magento/magento2/deployments","created_at":"2011-11-30T15:30:13Z","updated_at":"2017-04-23T08:26:04Z","pushed_at":"2017-04-23T15:12:33Z","git_url":"git://github.com/magento/magento2.git","ssh_url":"git@github.com:magento/magento2.git","clone_url":"https://github.com/magento/magento2.git","svn_url":"https://github.com/magento/magento2","homepage":"http://www.magento.com","size":362054,"stargazers_count":4308,"watchers_count":4308,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3212,"mirror_url":null,"open_issues_count":2248,"forks":3212,"open_issues":2248,"watchers":4308,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/magento/magento2/pulls/9368"},"html":{"href":"https://github.com/magento/magento2/pull/9368"},"issue":{"href":"https://api.github.com/repos/magento/magento2/issues/9368"},"comments":{"href":"https://api.github.com/repos/magento/magento2/issues/9368/comments"},"review_comments":{"href":"https://api.github.com/repos/magento/magento2/pulls/9368/comments"},"review_comment":{"href":"https://api.github.com/repos/magento/magento2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/magento/magento2/pulls/9368/commits"},"statuses":{"href":"https://api.github.com/repos/magento/magento2/statuses/e3862231f93a80d5dc5fa643404f4381f1a2e86a"}},"merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":1,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":2,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"LukeHandle"}}