{"action":"created","issue":{"url":"https://api.github.com/repos/IATI/iati.core/issues/98","repository_url":"https://api.github.com/repos/IATI/iati.core","labels_url":"https://api.github.com/repos/IATI/iati.core/issues/98/labels{/name}","comments_url":"https://api.github.com/repos/IATI/iati.core/issues/98/comments","events_url":"https://api.github.com/repos/IATI/iati.core/issues/98/events","html_url":"https://github.com/IATI/iati.core/issues/98","id":250310825,"number":98,"title":"Prevent accidental modification of defaults","user":{"login":"hayfield","id":720905,"avatar_url":"https://avatars3.githubusercontent.com/u/720905?v=4","gravatar_id":"","url":"https://api.github.com/users/hayfield","html_url":"https://github.com/hayfield","followers_url":"https://api.github.com/users/hayfield/followers","following_url":"https://api.github.com/users/hayfield/following{/other_user}","gists_url":"https://api.github.com/users/hayfield/gists{/gist_id}","starred_url":"https://api.github.com/users/hayfield/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hayfield/subscriptions","organizations_url":"https://api.github.com/users/hayfield/orgs","repos_url":"https://api.github.com/users/hayfield/repos","events_url":"https://api.github.com/users/hayfield/events{/privacy}","received_events_url":"https://api.github.com/users/hayfield/received_events","type":"User","site_admin":false},"labels":[{"id":525021812,"url":"https://api.github.com/repos/IATI/iati.core/labels/bug","name":"bug","color":"ee0701","default":true},{"id":646213766,"url":"https://api.github.com/repos/IATI/iati.core/labels/code-features","name":"code-features","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":{"login":"hayfield","id":720905,"avatar_url":"https://avatars3.githubusercontent.com/u/720905?v=4","gravatar_id":"","url":"https://api.github.com/users/hayfield","html_url":"https://github.com/hayfield","followers_url":"https://api.github.com/users/hayfield/followers","following_url":"https://api.github.com/users/hayfield/following{/other_user}","gists_url":"https://api.github.com/users/hayfield/gists{/gist_id}","starred_url":"https://api.github.com/users/hayfield/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hayfield/subscriptions","organizations_url":"https://api.github.com/users/hayfield/orgs","repos_url":"https://api.github.com/users/hayfield/repos","events_url":"https://api.github.com/users/hayfield/events{/privacy}","received_events_url":"https://api.github.com/users/hayfield/received_events","type":"User","site_admin":false},"assignees":[{"login":"hayfield","id":720905,"avatar_url":"https://avatars3.githubusercontent.com/u/720905?v=4","gravatar_id":"","url":"https://api.github.com/users/hayfield","html_url":"https://github.com/hayfield","followers_url":"https://api.github.com/users/hayfield/followers","following_url":"https://api.github.com/users/hayfield/following{/other_user}","gists_url":"https://api.github.com/users/hayfield/gists{/gist_id}","starred_url":"https://api.github.com/users/hayfield/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hayfield/subscriptions","organizations_url":"https://api.github.com/users/hayfield/orgs","repos_url":"https://api.github.com/users/hayfield/repos","events_url":"https://api.github.com/users/hayfield/events{/privacy}","received_events_url":"https://api.github.com/users/hayfield/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2017-08-15T13:14:48Z","updated_at":"2017-08-15T13:54:46Z","closed_at":null,"body":"At present, `default.py` contains a couple of caches to stop as much being read from disk. Due to the way objects are passed by reference rather than value, the whole cache thing probably needs thinking about properly, either:\r\n\r\n* Return a deep copy of objects from the cache\r\n* Remove the cache\r\n\r\nThis is because once you have a reference to a 'default' object, modifications to it can unintentionally also modify other references to the same default thing."},"comment":{"url":"https://api.github.com/repos/IATI/iati.core/issues/comments/322472504","html_url":"https://github.com/IATI/iati.core/issues/98#issuecomment-322472504","issue_url":"https://api.github.com/repos/IATI/iati.core/issues/98","id":322472504,"user":{"login":"hayfield","id":720905,"avatar_url":"https://avatars3.githubusercontent.com/u/720905?v=4","gravatar_id":"","url":"https://api.github.com/users/hayfield","html_url":"https://github.com/hayfield","followers_url":"https://api.github.com/users/hayfield/followers","following_url":"https://api.github.com/users/hayfield/following{/other_user}","gists_url":"https://api.github.com/users/hayfield/gists{/gist_id}","starred_url":"https://api.github.com/users/hayfield/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hayfield/subscriptions","organizations_url":"https://api.github.com/users/hayfield/orgs","repos_url":"https://api.github.com/users/hayfield/repos","events_url":"https://api.github.com/users/hayfield/events{/privacy}","received_events_url":"https://api.github.com/users/hayfield/received_events","type":"User","site_admin":false},"created_at":"2017-08-15T13:54:46Z","updated_at":"2017-08-15T13:54:46Z","body":"In terms of performance of `codelists`, times for running the 52 tests relating to accessing default Codelists:\r\n\r\n* With cache: `0.32s`\r\n* Removing the cache entirely: `3.69s`\r\n* Returning deep copies of cached values: `5.45s`"}}
{"actor":{"display_login":"hayfield"}}