{"action":"created","comment":{"url":"https://api.github.com/repos/Bilibili/ijkplayer/pulls/comments/105844302","pull_request_review_id":26740888,"id":105844302,"diff_hunk":"@@ -41,6 +41,28 @@ @implementation IJKSDLAudioQueueController {\n     NSLock *_lock;\n }\n \n+- (void) allocateAudioQueueBuffers {\n+    for (int i = 0; i < kIJKAudioQueueNumberBuffers; i++)\n+    {\n+        if (!_audioQueueBufferRefArray[i]) {\n+            AudioQueueAllocateBuffer(_audioQueueRef, _spec.size, &_audioQueueBufferRefArray[i]);\n+            _audioQueueBufferRefArray[i]->mAudioDataByteSize = _spec.size;\n+            memset(_audioQueueBufferRefArray[i]->mAudioData, 0, _spec.size);\n+            AudioQueueEnqueueBuffer(_audioQueueRef, _audioQueueBufferRefArray[i], 0, NULL);\n+        }\n+    }\n+}\n+\n+- (void) freeAudioQueueBuffers {","path":"ios/IJKMediaPlayer/IJKMediaPlayer/ijkmedia/ijksdl/ios/IJKSDLAudioQueueController.m","position":25,"original_position":25,"commit_id":"87f667474a22480846abcb32dec70191dfb707f0","original_commit_id":"87f667474a22480846abcb32dec70191dfb707f0","user":{"login":"wing1005","id":14172944,"avatar_url":"https://avatars1.githubusercontent.com/u/14172944?v=3","gravatar_id":"","url":"https://api.github.com/users/wing1005","html_url":"https://github.com/wing1005","followers_url":"https://api.github.com/users/wing1005/followers","following_url":"https://api.github.com/users/wing1005/following{/other_user}","gists_url":"https://api.github.com/users/wing1005/gists{/gist_id}","starred_url":"https://api.github.com/users/wing1005/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wing1005/subscriptions","organizations_url":"https://api.github.com/users/wing1005/orgs","repos_url":"https://api.github.com/users/wing1005/repos","events_url":"https://api.github.com/users/wing1005/events{/privacy}","received_events_url":"https://api.github.com/users/wing1005/received_events","type":"User","site_admin":false},"body":"freeAudioQueueBuffers is used just in my code logic, it is really no need after AudioQueueDispose, but I think it is needed after AudioQueueReset","created_at":"2017-03-14T07:56:22Z","updated_at":"2017-03-14T07:56:22Z","html_url":"https://github.com/Bilibili/ijkplayer/pull/2821#discussion_r105844302","pull_request_url":"https://api.github.com/repos/Bilibili/ijkplayer/pulls/2821","_links":{"self":{"href":"https://api.github.com/repos/Bilibili/ijkplayer/pulls/comments/105844302"},"html":{"href":"https://github.com/Bilibili/ijkplayer/pull/2821#discussion_r105844302"},"pull_request":{"href":"https://api.github.com/repos/Bilibili/ijkplayer/pulls/2821"}}},"pull_request":{"url":"https://api.github.com/repos/Bilibili/ijkplayer/pulls/2821","id":110108115,"html_url":"https://github.com/Bilibili/ijkplayer/pull/2821","diff_url":"https://github.com/Bilibili/ijkplayer/pull/2821.diff","patch_url":"https://github.com/Bilibili/ijkplayer/pull/2821.patch","issue_url":"https://api.github.com/repos/Bilibili/ijkplayer/issues/2821","number":2821,"state":"open","locked":false,"title":"fix while seek, play previous sound before play new sound","user":{"login":"wing1005","id":14172944,"avatar_url":"https://avatars1.githubusercontent.com/u/14172944?v=3","gravatar_id":"","url":"https://api.github.com/users/wing1005","html_url":"https://github.com/wing1005","followers_url":"https://api.github.com/users/wing1005/followers","following_url":"https://api.github.com/users/wing1005/following{/other_user}","gists_url":"https://api.github.com/users/wing1005/gists{/gist_id}","starred_url":"https://api.github.com/users/wing1005/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wing1005/subscriptions","organizations_url":"https://api.github.com/users/wing1005/orgs","repos_url":"https://api.github.com/users/wing1005/repos","events_url":"https://api.github.com/users/wing1005/events{/privacy}","received_events_url":"https://api.github.com/users/wing1005/received_events","type":"User","site_admin":false},"body":"问题现象：\r\n1.当 seek 后会播放之前位置的音频，长度为0.2s那样子，然后才会开始播放seek后的音频。\r\n2.暂停状态时seek 后也会出现播放长度为0.2s的之前位置的音频。\r\n解决方法：通过清除之前audio queue缓冲队列解决","created_at":"2017-03-10T11:12:15Z","updated_at":"2017-03-14T07:56:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"56e89a7fe2f700e5a17a0a35b72aab4358fda617","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Bilibili/ijkplayer/pulls/2821/commits","review_comments_url":"https://api.github.com/repos/Bilibili/ijkplayer/pulls/2821/comments","review_comment_url":"https://api.github.com/repos/Bilibili/ijkplayer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Bilibili/ijkplayer/issues/2821/comments","statuses_url":"https://api.github.com/repos/Bilibili/ijkplayer/statuses/87f667474a22480846abcb32dec70191dfb707f0","head":{"label":"wing1005:master","ref":"master","sha":"87f667474a22480846abcb32dec70191dfb707f0","user":{"login":"wing1005","id":14172944,"avatar_url":"https://avatars1.githubusercontent.com/u/14172944?v=3","gravatar_id":"","url":"https://api.github.com/users/wing1005","html_url":"https://github.com/wing1005","followers_url":"https://api.github.com/users/wing1005/followers","following_url":"https://api.github.com/users/wing1005/following{/other_user}","gists_url":"https://api.github.com/users/wing1005/gists{/gist_id}","starred_url":"https://api.github.com/users/wing1005/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wing1005/subscriptions","organizations_url":"https://api.github.com/users/wing1005/orgs","repos_url":"https://api.github.com/users/wing1005/repos","events_url":"https://api.github.com/users/wing1005/events{/privacy}","received_events_url":"https://api.github.com/users/wing1005/received_events","type":"User","site_admin":false},"repo":{"id":84536025,"name":"ijkplayer","full_name":"wing1005/ijkplayer","owner":{"login":"wing1005","id":14172944,"avatar_url":"https://avatars1.githubusercontent.com/u/14172944?v=3","gravatar_id":"","url":"https://api.github.com/users/wing1005","html_url":"https://github.com/wing1005","followers_url":"https://api.github.com/users/wing1005/followers","following_url":"https://api.github.com/users/wing1005/following{/other_user}","gists_url":"https://api.github.com/users/wing1005/gists{/gist_id}","starred_url":"https://api.github.com/users/wing1005/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wing1005/subscriptions","organizations_url":"https://api.github.com/users/wing1005/orgs","repos_url":"https://api.github.com/users/wing1005/repos","events_url":"https://api.github.com/users/wing1005/events{/privacy}","received_events_url":"https://api.github.com/users/wing1005/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wing1005/ijkplayer","description":"Android/iOS video player based on FFmpeg n3.2, with MediaCodec, VideoToolbox support.","fork":true,"url":"https://api.github.com/repos/wing1005/ijkplayer","forks_url":"https://api.github.com/repos/wing1005/ijkplayer/forks","keys_url":"https://api.github.com/repos/wing1005/ijkplayer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wing1005/ijkplayer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wing1005/ijkplayer/teams","hooks_url":"https://api.github.com/repos/wing1005/ijkplayer/hooks","issue_events_url":"https://api.github.com/repos/wing1005/ijkplayer/issues/events{/number}","events_url":"https://api.github.com/repos/wing1005/ijkplayer/events","assignees_url":"https://api.github.com/repos/wing1005/ijkplayer/assignees{/user}","branches_url":"https://api.github.com/repos/wing1005/ijkplayer/branches{/branch}","tags_url":"https://api.github.com/repos/wing1005/ijkplayer/tags","blobs_url":"https://api.github.com/repos/wing1005/ijkplayer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wing1005/ijkplayer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wing1005/ijkplayer/git/refs{/sha}","trees_url":"https://api.github.com/repos/wing1005/ijkplayer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wing1005/ijkplayer/statuses/{sha}","languages_url":"https://api.github.com/repos/wing1005/ijkplayer/languages","stargazers_url":"https://api.github.com/repos/wing1005/ijkplayer/stargazers","contributors_url":"https://api.github.com/repos/wing1005/ijkplayer/contributors","subscribers_url":"https://api.github.com/repos/wing1005/ijkplayer/subscribers","subscription_url":"https://api.github.com/repos/wing1005/ijkplayer/subscription","commits_url":"https://api.github.com/repos/wing1005/ijkplayer/commits{/sha}","git_commits_url":"https://api.github.com/repos/wing1005/ijkplayer/git/commits{/sha}","comments_url":"https://api.github.com/repos/wing1005/ijkplayer/comments{/number}","issue_comment_url":"https://api.github.com/repos/wing1005/ijkplayer/issues/comments{/number}","contents_url":"https://api.github.com/repos/wing1005/ijkplayer/contents/{+path}","compare_url":"https://api.github.com/repos/wing1005/ijkplayer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wing1005/ijkplayer/merges","archive_url":"https://api.github.com/repos/wing1005/ijkplayer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wing1005/ijkplayer/downloads","issues_url":"https://api.github.com/repos/wing1005/ijkplayer/issues{/number}","pulls_url":"https://api.github.com/repos/wing1005/ijkplayer/pulls{/number}","milestones_url":"https://api.github.com/repos/wing1005/ijkplayer/milestones{/number}","notifications_url":"https://api.github.com/repos/wing1005/ijkplayer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wing1005/ijkplayer/labels{/name}","releases_url":"https://api.github.com/repos/wing1005/ijkplayer/releases{/id}","deployments_url":"https://api.github.com/repos/wing1005/ijkplayer/deployments","created_at":"2017-03-10T08:13:30Z","updated_at":"2017-03-10T08:13:34Z","pushed_at":"2017-03-13T03:39:10Z","git_url":"git://github.com/wing1005/ijkplayer.git","ssh_url":"git@github.com:wing1005/ijkplayer.git","clone_url":"https://github.com/wing1005/ijkplayer.git","svn_url":"https://github.com/wing1005/ijkplayer","homepage":"","size":7663,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Bilibili:master","ref":"master","sha":"f80a1d073825491f6d07572bfba42bcb49b4f740","user":{"login":"Bilibili","id":12002442,"avatar_url":"https://avatars1.githubusercontent.com/u/12002442?v=3","gravatar_id":"","url":"https://api.github.com/users/Bilibili","html_url":"https://github.com/Bilibili","followers_url":"https://api.github.com/users/Bilibili/followers","following_url":"https://api.github.com/users/Bilibili/following{/other_user}","gists_url":"https://api.github.com/users/Bilibili/gists{/gist_id}","starred_url":"https://api.github.com/users/Bilibili/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bilibili/subscriptions","organizations_url":"https://api.github.com/users/Bilibili/orgs","repos_url":"https://api.github.com/users/Bilibili/repos","events_url":"https://api.github.com/users/Bilibili/events{/privacy}","received_events_url":"https://api.github.com/users/Bilibili/received_events","type":"Organization","site_admin":false},"repo":{"id":10446890,"name":"ijkplayer","full_name":"Bilibili/ijkplayer","owner":{"login":"Bilibili","id":12002442,"avatar_url":"https://avatars1.githubusercontent.com/u/12002442?v=3","gravatar_id":"","url":"https://api.github.com/users/Bilibili","html_url":"https://github.com/Bilibili","followers_url":"https://api.github.com/users/Bilibili/followers","following_url":"https://api.github.com/users/Bilibili/following{/other_user}","gists_url":"https://api.github.com/users/Bilibili/gists{/gist_id}","starred_url":"https://api.github.com/users/Bilibili/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bilibili/subscriptions","organizations_url":"https://api.github.com/users/Bilibili/orgs","repos_url":"https://api.github.com/users/Bilibili/repos","events_url":"https://api.github.com/users/Bilibili/events{/privacy}","received_events_url":"https://api.github.com/users/Bilibili/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Bilibili/ijkplayer","description":"Android/iOS video player based on FFmpeg n3.2, with MediaCodec, VideoToolbox support.","fork":false,"url":"https://api.github.com/repos/Bilibili/ijkplayer","forks_url":"https://api.github.com/repos/Bilibili/ijkplayer/forks","keys_url":"https://api.github.com/repos/Bilibili/ijkplayer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Bilibili/ijkplayer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Bilibili/ijkplayer/teams","hooks_url":"https://api.github.com/repos/Bilibili/ijkplayer/hooks","issue_events_url":"https://api.github.com/repos/Bilibili/ijkplayer/issues/events{/number}","events_url":"https://api.github.com/repos/Bilibili/ijkplayer/events","assignees_url":"https://api.github.com/repos/Bilibili/ijkplayer/assignees{/user}","branches_url":"https://api.github.com/repos/Bilibili/ijkplayer/branches{/branch}","tags_url":"https://api.github.com/repos/Bilibili/ijkplayer/tags","blobs_url":"https://api.github.com/repos/Bilibili/ijkplayer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Bilibili/ijkplayer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Bilibili/ijkplayer/git/refs{/sha}","trees_url":"https://api.github.com/repos/Bilibili/ijkplayer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Bilibili/ijkplayer/statuses/{sha}","languages_url":"https://api.github.com/repos/Bilibili/ijkplayer/languages","stargazers_url":"https://api.github.com/repos/Bilibili/ijkplayer/stargazers","contributors_url":"https://api.github.com/repos/Bilibili/ijkplayer/contributors","subscribers_url":"https://api.github.com/repos/Bilibili/ijkplayer/subscribers","subscription_url":"https://api.github.com/repos/Bilibili/ijkplayer/subscription","commits_url":"https://api.github.com/repos/Bilibili/ijkplayer/commits{/sha}","git_commits_url":"https://api.github.com/repos/Bilibili/ijkplayer/git/commits{/sha}","comments_url":"https://api.github.com/repos/Bilibili/ijkplayer/comments{/number}","issue_comment_url":"https://api.github.com/repos/Bilibili/ijkplayer/issues/comments{/number}","contents_url":"https://api.github.com/repos/Bilibili/ijkplayer/contents/{+path}","compare_url":"https://api.github.com/repos/Bilibili/ijkplayer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Bilibili/ijkplayer/merges","archive_url":"https://api.github.com/repos/Bilibili/ijkplayer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Bilibili/ijkplayer/downloads","issues_url":"https://api.github.com/repos/Bilibili/ijkplayer/issues{/number}","pulls_url":"https://api.github.com/repos/Bilibili/ijkplayer/pulls{/number}","milestones_url":"https://api.github.com/repos/Bilibili/ijkplayer/milestones{/number}","notifications_url":"https://api.github.com/repos/Bilibili/ijkplayer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Bilibili/ijkplayer/labels{/name}","releases_url":"https://api.github.com/repos/Bilibili/ijkplayer/releases{/id}","deployments_url":"https://api.github.com/repos/Bilibili/ijkplayer/deployments","created_at":"2013-06-03T04:12:04Z","updated_at":"2017-03-14T07:35:42Z","pushed_at":"2017-03-14T07:06:11Z","git_url":"git://github.com/Bilibili/ijkplayer.git","ssh_url":"git@github.com:Bilibili/ijkplayer.git","clone_url":"https://github.com/Bilibili/ijkplayer.git","svn_url":"https://github.com/Bilibili/ijkplayer","homepage":"","size":7658,"stargazers_count":11890,"watchers_count":11890,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3694,"mirror_url":null,"open_issues_count":1020,"forks":3694,"open_issues":1020,"watchers":11890,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Bilibili/ijkplayer/pulls/2821"},"html":{"href":"https://github.com/Bilibili/ijkplayer/pull/2821"},"issue":{"href":"https://api.github.com/repos/Bilibili/ijkplayer/issues/2821"},"comments":{"href":"https://api.github.com/repos/Bilibili/ijkplayer/issues/2821/comments"},"review_comments":{"href":"https://api.github.com/repos/Bilibili/ijkplayer/pulls/2821/comments"},"review_comment":{"href":"https://api.github.com/repos/Bilibili/ijkplayer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Bilibili/ijkplayer/pulls/2821/commits"},"statuses":{"href":"https://api.github.com/repos/Bilibili/ijkplayer/statuses/87f667474a22480846abcb32dec70191dfb707f0"}}}}
{"actor":{"display_login":"wing1005"}}