{"action":"opened","number":1,"pull_request":{"url":"https://api.github.com/repos/ismith/external-dns/pulls/1","id":121462010,"html_url":"https://github.com/ismith/external-dns/pull/1","diff_url":"https://github.com/ismith/external-dns/pull/1.diff","patch_url":"https://github.com/ismith/external-dns/pull/1.patch","issue_url":"https://api.github.com/repos/ismith/external-dns/issues/1","number":1,"state":"open","locked":false,"title":"ref: refactor source registration/lookup to be lazily initialized","user":{"login":"linki","id":36162,"avatar_url":"https://avatars2.githubusercontent.com/u/36162?v=3","gravatar_id":"","url":"https://api.github.com/users/linki","html_url":"https://github.com/linki","followers_url":"https://api.github.com/users/linki/followers","following_url":"https://api.github.com/users/linki/following{/other_user}","gists_url":"https://api.github.com/users/linki/gists{/gist_id}","starred_url":"https://api.github.com/users/linki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linki/subscriptions","organizations_url":"https://api.github.com/users/linki/orgs","repos_url":"https://api.github.com/users/linki/repos","events_url":"https://api.github.com/users/linki/events{/privacy}","received_events_url":"https://api.github.com/users/linki/received_events","type":"User","site_admin":false},"body":"This is a refactoring of how Sources are registered and lookup up. Its main goals are to:\r\n* cleanup if/else/switch stuff in `main.go`\r\n* make adding new Sources easier and more self-contained\r\n* make Source initialization lazy so that Kubernetes client is only initialized when needed.\r\n\r\nIt's based on @ismith's PR adding a `fakeSource` (https://github.com/kubernetes-incubator/external-dns/pull/205) which added a desire to run ExternalDNS without targetting a real Kubernetes cluster.\r\n\r\n/cc @ismith @ideahitme\r\n","created_at":"2017-05-19T09:40:23Z","updated_at":"2017-05-19T09:40:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ismith/external-dns/pulls/1/commits","review_comments_url":"https://api.github.com/repos/ismith/external-dns/pulls/1/comments","review_comment_url":"https://api.github.com/repos/ismith/external-dns/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ismith/external-dns/issues/1/comments","statuses_url":"https://api.github.com/repos/ismith/external-dns/statuses/ca2edd6ced7af3c9ce6af43fb898c5ed56076433","head":{"label":"linki:fake-source-refactor","ref":"fake-source-refactor","sha":"ca2edd6ced7af3c9ce6af43fb898c5ed56076433","user":{"login":"linki","id":36162,"avatar_url":"https://avatars2.githubusercontent.com/u/36162?v=3","gravatar_id":"","url":"https://api.github.com/users/linki","html_url":"https://github.com/linki","followers_url":"https://api.github.com/users/linki/followers","following_url":"https://api.github.com/users/linki/following{/other_user}","gists_url":"https://api.github.com/users/linki/gists{/gist_id}","starred_url":"https://api.github.com/users/linki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linki/subscriptions","organizations_url":"https://api.github.com/users/linki/orgs","repos_url":"https://api.github.com/users/linki/repos","events_url":"https://api.github.com/users/linki/events{/privacy}","received_events_url":"https://api.github.com/users/linki/received_events","type":"User","site_admin":false},"repo":{"id":82679323,"name":"external-dns","full_name":"linki/external-dns","owner":{"login":"linki","id":36162,"avatar_url":"https://avatars2.githubusercontent.com/u/36162?v=3","gravatar_id":"","url":"https://api.github.com/users/linki","html_url":"https://github.com/linki","followers_url":"https://api.github.com/users/linki/followers","following_url":"https://api.github.com/users/linki/following{/other_user}","gists_url":"https://api.github.com/users/linki/gists{/gist_id}","starred_url":"https://api.github.com/users/linki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linki/subscriptions","organizations_url":"https://api.github.com/users/linki/orgs","repos_url":"https://api.github.com/users/linki/repos","events_url":"https://api.github.com/users/linki/events{/privacy}","received_events_url":"https://api.github.com/users/linki/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/linki/external-dns","description":null,"fork":true,"url":"https://api.github.com/repos/linki/external-dns","forks_url":"https://api.github.com/repos/linki/external-dns/forks","keys_url":"https://api.github.com/repos/linki/external-dns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linki/external-dns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linki/external-dns/teams","hooks_url":"https://api.github.com/repos/linki/external-dns/hooks","issue_events_url":"https://api.github.com/repos/linki/external-dns/issues/events{/number}","events_url":"https://api.github.com/repos/linki/external-dns/events","assignees_url":"https://api.github.com/repos/linki/external-dns/assignees{/user}","branches_url":"https://api.github.com/repos/linki/external-dns/branches{/branch}","tags_url":"https://api.github.com/repos/linki/external-dns/tags","blobs_url":"https://api.github.com/repos/linki/external-dns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linki/external-dns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linki/external-dns/git/refs{/sha}","trees_url":"https://api.github.com/repos/linki/external-dns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linki/external-dns/statuses/{sha}","languages_url":"https://api.github.com/repos/linki/external-dns/languages","stargazers_url":"https://api.github.com/repos/linki/external-dns/stargazers","contributors_url":"https://api.github.com/repos/linki/external-dns/contributors","subscribers_url":"https://api.github.com/repos/linki/external-dns/subscribers","subscription_url":"https://api.github.com/repos/linki/external-dns/subscription","commits_url":"https://api.github.com/repos/linki/external-dns/commits{/sha}","git_commits_url":"https://api.github.com/repos/linki/external-dns/git/commits{/sha}","comments_url":"https://api.github.com/repos/linki/external-dns/comments{/number}","issue_comment_url":"https://api.github.com/repos/linki/external-dns/issues/comments{/number}","contents_url":"https://api.github.com/repos/linki/external-dns/contents/{+path}","compare_url":"https://api.github.com/repos/linki/external-dns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linki/external-dns/merges","archive_url":"https://api.github.com/repos/linki/external-dns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linki/external-dns/downloads","issues_url":"https://api.github.com/repos/linki/external-dns/issues{/number}","pulls_url":"https://api.github.com/repos/linki/external-dns/pulls{/number}","milestones_url":"https://api.github.com/repos/linki/external-dns/milestones{/number}","notifications_url":"https://api.github.com/repos/linki/external-dns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linki/external-dns/labels{/name}","releases_url":"https://api.github.com/repos/linki/external-dns/releases{/id}","deployments_url":"https://api.github.com/repos/linki/external-dns/deployments","created_at":"2017-02-21T12:50:38Z","updated_at":"2017-03-09T14:43:56Z","pushed_at":"2017-05-19T09:36:20Z","git_url":"git://github.com/linki/external-dns.git","ssh_url":"git@github.com:linki/external-dns.git","clone_url":"https://github.com/linki/external-dns.git","svn_url":"https://github.com/linki/external-dns","homepage":null,"size":25574,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ismith:fake-source","ref":"fake-source","sha":"381f134b5e9b91aeeaa8306ab4848fb8e1d17096","user":{"login":"ismith","id":172694,"avatar_url":"https://avatars0.githubusercontent.com/u/172694?v=3","gravatar_id":"","url":"https://api.github.com/users/ismith","html_url":"https://github.com/ismith","followers_url":"https://api.github.com/users/ismith/followers","following_url":"https://api.github.com/users/ismith/following{/other_user}","gists_url":"https://api.github.com/users/ismith/gists{/gist_id}","starred_url":"https://api.github.com/users/ismith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ismith/subscriptions","organizations_url":"https://api.github.com/users/ismith/orgs","repos_url":"https://api.github.com/users/ismith/repos","events_url":"https://api.github.com/users/ismith/events{/privacy}","received_events_url":"https://api.github.com/users/ismith/received_events","type":"User","site_admin":false},"repo":{"id":91218410,"name":"external-dns","full_name":"ismith/external-dns","owner":{"login":"ismith","id":172694,"avatar_url":"https://avatars0.githubusercontent.com/u/172694?v=3","gravatar_id":"","url":"https://api.github.com/users/ismith","html_url":"https://github.com/ismith","followers_url":"https://api.github.com/users/ismith/followers","following_url":"https://api.github.com/users/ismith/following{/other_user}","gists_url":"https://api.github.com/users/ismith/gists{/gist_id}","starred_url":"https://api.github.com/users/ismith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ismith/subscriptions","organizations_url":"https://api.github.com/users/ismith/orgs","repos_url":"https://api.github.com/users/ismith/repos","events_url":"https://api.github.com/users/ismith/events{/privacy}","received_events_url":"https://api.github.com/users/ismith/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ismith/external-dns","description":"Configure external DNS servers (AWS Route53, Google CloudDNS and others) for Kubernetes Ingresses and Services","fork":true,"url":"https://api.github.com/repos/ismith/external-dns","forks_url":"https://api.github.com/repos/ismith/external-dns/forks","keys_url":"https://api.github.com/repos/ismith/external-dns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ismith/external-dns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ismith/external-dns/teams","hooks_url":"https://api.github.com/repos/ismith/external-dns/hooks","issue_events_url":"https://api.github.com/repos/ismith/external-dns/issues/events{/number}","events_url":"https://api.github.com/repos/ismith/external-dns/events","assignees_url":"https://api.github.com/repos/ismith/external-dns/assignees{/user}","branches_url":"https://api.github.com/repos/ismith/external-dns/branches{/branch}","tags_url":"https://api.github.com/repos/ismith/external-dns/tags","blobs_url":"https://api.github.com/repos/ismith/external-dns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ismith/external-dns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ismith/external-dns/git/refs{/sha}","trees_url":"https://api.github.com/repos/ismith/external-dns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ismith/external-dns/statuses/{sha}","languages_url":"https://api.github.com/repos/ismith/external-dns/languages","stargazers_url":"https://api.github.com/repos/ismith/external-dns/stargazers","contributors_url":"https://api.github.com/repos/ismith/external-dns/contributors","subscribers_url":"https://api.github.com/repos/ismith/external-dns/subscribers","subscription_url":"https://api.github.com/repos/ismith/external-dns/subscription","commits_url":"https://api.github.com/repos/ismith/external-dns/commits{/sha}","git_commits_url":"https://api.github.com/repos/ismith/external-dns/git/commits{/sha}","comments_url":"https://api.github.com/repos/ismith/external-dns/comments{/number}","issue_comment_url":"https://api.github.com/repos/ismith/external-dns/issues/comments{/number}","contents_url":"https://api.github.com/repos/ismith/external-dns/contents/{+path}","compare_url":"https://api.github.com/repos/ismith/external-dns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ismith/external-dns/merges","archive_url":"https://api.github.com/repos/ismith/external-dns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ismith/external-dns/downloads","issues_url":"https://api.github.com/repos/ismith/external-dns/issues{/number}","pulls_url":"https://api.github.com/repos/ismith/external-dns/pulls{/number}","milestones_url":"https://api.github.com/repos/ismith/external-dns/milestones{/number}","notifications_url":"https://api.github.com/repos/ismith/external-dns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ismith/external-dns/labels{/name}","releases_url":"https://api.github.com/repos/ismith/external-dns/releases{/id}","deployments_url":"https://api.github.com/repos/ismith/external-dns/deployments","created_at":"2017-05-14T03:51:58Z","updated_at":"2017-05-14T03:52:00Z","pushed_at":"2017-05-18T13:25:51Z","git_url":"git://github.com/ismith/external-dns.git","ssh_url":"git@github.com:ismith/external-dns.git","clone_url":"https://github.com/ismith/external-dns.git","svn_url":"https://github.com/ismith/external-dns","homepage":"","size":24983,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ismith/external-dns/pulls/1"},"html":{"href":"https://github.com/ismith/external-dns/pull/1"},"issue":{"href":"https://api.github.com/repos/ismith/external-dns/issues/1"},"comments":{"href":"https://api.github.com/repos/ismith/external-dns/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/ismith/external-dns/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/ismith/external-dns/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ismith/external-dns/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/ismith/external-dns/statuses/ca2edd6ced7af3c9ce6af43fb898c5ed56076433"}},"merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":253,"deletions":136,"changed_files":12}}
{"actor":{"display_login":"linki"}}