{"action":"created","comment":{"url":"https://api.github.com/repos/Shopify/pyoozie/pulls/comments/108538215","pull_request_review_id":29576097,"id":108538215,"diff_hunk":"@@ -387,54 +380,63 @@ def parse_datetime(string):\n     return datetime.datetime.strptime(string, '%Y-%m-%dT%H:%MZ')\n \n \n-def test_coordinator(coordinator_xml, expected_coordinator_options):\n-    actual = tags.CoordinatorApp(**expected_coordinator_options).xml()\n-    assert tests.utils.xml_to_dict_unordered(coordinator_xml) == tests.utils.xml_to_dict_unordered(actual)\n+def test_minimal_coordinator(minimal_coordinator_options):\n+    actual_xml = tags.CoordinatorApp(**minimal_coordinator_options).xml(indent=True)\n+    actual_dict = tests.utils.xml_to_dict_unordered(actual_xml)\n \n+    expected_xml = None\n+    with open('tests/data/minimal_coordinator.xml', 'r') as fh:","path":"tests/pyoozie/test_tags.py","position":37,"original_position":37,"commit_id":"cb2d10bc15533238e95cd3640a5a63befa9d68be","original_commit_id":"cb2d10bc15533238e95cd3640a5a63befa9d68be","user":{"login":"cfournie","id":49264,"avatar_url":"https://avatars2.githubusercontent.com/u/49264?v=3","gravatar_id":"","url":"https://api.github.com/users/cfournie","html_url":"https://github.com/cfournie","followers_url":"https://api.github.com/users/cfournie/followers","following_url":"https://api.github.com/users/cfournie/following{/other_user}","gists_url":"https://api.github.com/users/cfournie/gists{/gist_id}","starred_url":"https://api.github.com/users/cfournie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfournie/subscriptions","organizations_url":"https://api.github.com/users/cfournie/orgs","repos_url":"https://api.github.com/users/cfournie/repos","events_url":"https://api.github.com/users/cfournie/events{/privacy}","received_events_url":"https://api.github.com/users/cfournie/received_events","type":"User","site_admin":false},"body":"Meh, no other tests use it.","created_at":"2017-03-28T21:11:49Z","updated_at":"2017-03-28T21:11:49Z","html_url":"https://github.com/Shopify/pyoozie/pull/36#discussion_r108538215","pull_request_url":"https://api.github.com/repos/Shopify/pyoozie/pulls/36","_links":{"self":{"href":"https://api.github.com/repos/Shopify/pyoozie/pulls/comments/108538215"},"html":{"href":"https://github.com/Shopify/pyoozie/pull/36#discussion_r108538215"},"pull_request":{"href":"https://api.github.com/repos/Shopify/pyoozie/pulls/36"}}},"pull_request":{"url":"https://api.github.com/repos/Shopify/pyoozie/pulls/36","id":113064690,"html_url":"https://github.com/Shopify/pyoozie/pull/36","diff_url":"https://github.com/Shopify/pyoozie/pull/36.diff","patch_url":"https://github.com/Shopify/pyoozie/pull/36.patch","issue_url":"https://api.github.com/repos/Shopify/pyoozie/issues/36","number":36,"state":"open","locked":false,"title":"Remove CoordinatorBuilder and refactor CoordinatorApp tests","user":{"login":"cfournie","id":49264,"avatar_url":"https://avatars2.githubusercontent.com/u/49264?v=3","gravatar_id":"","url":"https://api.github.com/users/cfournie","html_url":"https://github.com/cfournie","followers_url":"https://api.github.com/users/cfournie/followers","following_url":"https://api.github.com/users/cfournie/following{/other_user}","gists_url":"https://api.github.com/users/cfournie/gists{/gist_id}","starred_url":"https://api.github.com/users/cfournie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfournie/subscriptions","organizations_url":"https://api.github.com/users/cfournie/orgs","repos_url":"https://api.github.com/users/cfournie/repos","events_url":"https://api.github.com/users/cfournie/events{/privacy}","received_events_url":"https://api.github.com/users/cfournie/received_events","type":"User","site_admin":false},"body":"This PR:\r\n  - Removes the `CoordinatorBuilder` in favour of `CoordinatorApp.xml` being used to construct coordinators; and\r\n  - Refactors the `CoordinatorApp` tests to cover the same options that the `CoordinatorBuilder` covered.\r\n\r\nFixes https://github.com/Shopify/pyoozie/issues/34.","created_at":"2017-03-28T20:53:54Z","updated_at":"2017-03-28T21:11:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9ca5b230359d518f712456d3b94972aaf0c12964","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Shopify/pyoozie/pulls/36/commits","review_comments_url":"https://api.github.com/repos/Shopify/pyoozie/pulls/36/comments","review_comment_url":"https://api.github.com/repos/Shopify/pyoozie/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Shopify/pyoozie/issues/36/comments","statuses_url":"https://api.github.com/repos/Shopify/pyoozie/statuses/cb2d10bc15533238e95cd3640a5a63befa9d68be","head":{"label":"Shopify:remove_coordinator_builder","ref":"remove_coordinator_builder","sha":"cb2d10bc15533238e95cd3640a5a63befa9d68be","user":{"login":"Shopify","id":8085,"avatar_url":"https://avatars2.githubusercontent.com/u/8085?v=3","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"repo":{"id":80628591,"name":"pyoozie","full_name":"Shopify/pyoozie","owner":{"login":"Shopify","id":8085,"avatar_url":"https://avatars2.githubusercontent.com/u/8085?v=3","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Shopify/pyoozie","description":null,"fork":false,"url":"https://api.github.com/repos/Shopify/pyoozie","forks_url":"https://api.github.com/repos/Shopify/pyoozie/forks","keys_url":"https://api.github.com/repos/Shopify/pyoozie/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shopify/pyoozie/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shopify/pyoozie/teams","hooks_url":"https://api.github.com/repos/Shopify/pyoozie/hooks","issue_events_url":"https://api.github.com/repos/Shopify/pyoozie/issues/events{/number}","events_url":"https://api.github.com/repos/Shopify/pyoozie/events","assignees_url":"https://api.github.com/repos/Shopify/pyoozie/assignees{/user}","branches_url":"https://api.github.com/repos/Shopify/pyoozie/branches{/branch}","tags_url":"https://api.github.com/repos/Shopify/pyoozie/tags","blobs_url":"https://api.github.com/repos/Shopify/pyoozie/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shopify/pyoozie/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shopify/pyoozie/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shopify/pyoozie/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shopify/pyoozie/statuses/{sha}","languages_url":"https://api.github.com/repos/Shopify/pyoozie/languages","stargazers_url":"https://api.github.com/repos/Shopify/pyoozie/stargazers","contributors_url":"https://api.github.com/repos/Shopify/pyoozie/contributors","subscribers_url":"https://api.github.com/repos/Shopify/pyoozie/subscribers","subscription_url":"https://api.github.com/repos/Shopify/pyoozie/subscription","commits_url":"https://api.github.com/repos/Shopify/pyoozie/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shopify/pyoozie/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shopify/pyoozie/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shopify/pyoozie/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shopify/pyoozie/contents/{+path}","compare_url":"https://api.github.com/repos/Shopify/pyoozie/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shopify/pyoozie/merges","archive_url":"https://api.github.com/repos/Shopify/pyoozie/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shopify/pyoozie/downloads","issues_url":"https://api.github.com/repos/Shopify/pyoozie/issues{/number}","pulls_url":"https://api.github.com/repos/Shopify/pyoozie/pulls{/number}","milestones_url":"https://api.github.com/repos/Shopify/pyoozie/milestones{/number}","notifications_url":"https://api.github.com/repos/Shopify/pyoozie/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shopify/pyoozie/labels{/name}","releases_url":"https://api.github.com/repos/Shopify/pyoozie/releases{/id}","deployments_url":"https://api.github.com/repos/Shopify/pyoozie/deployments","created_at":"2017-02-01T14:38:03Z","updated_at":"2017-03-16T16:46:02Z","pushed_at":"2017-03-28T20:53:55Z","git_url":"git://github.com/Shopify/pyoozie.git","ssh_url":"git@github.com:Shopify/pyoozie.git","clone_url":"https://github.com/Shopify/pyoozie.git","svn_url":"https://github.com/Shopify/pyoozie","homepage":null,"size":179,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":8,"forks":1,"open_issues":8,"watchers":0,"default_branch":"master"}},"base":{"label":"Shopify:master","ref":"master","sha":"61b8e2ba789c1c00ea5eee1200c2137037e41df0","user":{"login":"Shopify","id":8085,"avatar_url":"https://avatars2.githubusercontent.com/u/8085?v=3","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"repo":{"id":80628591,"name":"pyoozie","full_name":"Shopify/pyoozie","owner":{"login":"Shopify","id":8085,"avatar_url":"https://avatars2.githubusercontent.com/u/8085?v=3","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Shopify/pyoozie","description":null,"fork":false,"url":"https://api.github.com/repos/Shopify/pyoozie","forks_url":"https://api.github.com/repos/Shopify/pyoozie/forks","keys_url":"https://api.github.com/repos/Shopify/pyoozie/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shopify/pyoozie/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shopify/pyoozie/teams","hooks_url":"https://api.github.com/repos/Shopify/pyoozie/hooks","issue_events_url":"https://api.github.com/repos/Shopify/pyoozie/issues/events{/number}","events_url":"https://api.github.com/repos/Shopify/pyoozie/events","assignees_url":"https://api.github.com/repos/Shopify/pyoozie/assignees{/user}","branches_url":"https://api.github.com/repos/Shopify/pyoozie/branches{/branch}","tags_url":"https://api.github.com/repos/Shopify/pyoozie/tags","blobs_url":"https://api.github.com/repos/Shopify/pyoozie/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shopify/pyoozie/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shopify/pyoozie/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shopify/pyoozie/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shopify/pyoozie/statuses/{sha}","languages_url":"https://api.github.com/repos/Shopify/pyoozie/languages","stargazers_url":"https://api.github.com/repos/Shopify/pyoozie/stargazers","contributors_url":"https://api.github.com/repos/Shopify/pyoozie/contributors","subscribers_url":"https://api.github.com/repos/Shopify/pyoozie/subscribers","subscription_url":"https://api.github.com/repos/Shopify/pyoozie/subscription","commits_url":"https://api.github.com/repos/Shopify/pyoozie/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shopify/pyoozie/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shopify/pyoozie/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shopify/pyoozie/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shopify/pyoozie/contents/{+path}","compare_url":"https://api.github.com/repos/Shopify/pyoozie/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shopify/pyoozie/merges","archive_url":"https://api.github.com/repos/Shopify/pyoozie/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shopify/pyoozie/downloads","issues_url":"https://api.github.com/repos/Shopify/pyoozie/issues{/number}","pulls_url":"https://api.github.com/repos/Shopify/pyoozie/pulls{/number}","milestones_url":"https://api.github.com/repos/Shopify/pyoozie/milestones{/number}","notifications_url":"https://api.github.com/repos/Shopify/pyoozie/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shopify/pyoozie/labels{/name}","releases_url":"https://api.github.com/repos/Shopify/pyoozie/releases{/id}","deployments_url":"https://api.github.com/repos/Shopify/pyoozie/deployments","created_at":"2017-02-01T14:38:03Z","updated_at":"2017-03-16T16:46:02Z","pushed_at":"2017-03-28T20:53:55Z","git_url":"git://github.com/Shopify/pyoozie.git","ssh_url":"git@github.com:Shopify/pyoozie.git","clone_url":"https://github.com/Shopify/pyoozie.git","svn_url":"https://github.com/Shopify/pyoozie","homepage":null,"size":179,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":8,"forks":1,"open_issues":8,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Shopify/pyoozie/pulls/36"},"html":{"href":"https://github.com/Shopify/pyoozie/pull/36"},"issue":{"href":"https://api.github.com/repos/Shopify/pyoozie/issues/36"},"comments":{"href":"https://api.github.com/repos/Shopify/pyoozie/issues/36/comments"},"review_comments":{"href":"https://api.github.com/repos/Shopify/pyoozie/pulls/36/comments"},"review_comment":{"href":"https://api.github.com/repos/Shopify/pyoozie/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Shopify/pyoozie/pulls/36/commits"},"statuses":{"href":"https://api.github.com/repos/Shopify/pyoozie/statuses/cb2d10bc15533238e95cd3640a5a63befa9d68be"}}}}
{"actor":{"display_login":"cfournie"}}