{"action":"created","issue":{"url":"https://api.github.com/repos/coa0329/BhaangWeb/issues/30","repository_url":"https://api.github.com/repos/coa0329/BhaangWeb","labels_url":"https://api.github.com/repos/coa0329/BhaangWeb/issues/30/labels{/name}","comments_url":"https://api.github.com/repos/coa0329/BhaangWeb/issues/30/comments","events_url":"https://api.github.com/repos/coa0329/BhaangWeb/issues/30/events","html_url":"https://github.com/coa0329/BhaangWeb/issues/30","id":259593202,"number":30,"title":"[PABP Email] Add some sort of 'outline' around stuff configured in Settings with helpful message","user":{"login":"daver78","id":7561473,"avatar_url":"https://avatars3.githubusercontent.com/u/7561473?v=4","gravatar_id":"","url":"https://api.github.com/users/daver78","html_url":"https://github.com/daver78","followers_url":"https://api.github.com/users/daver78/followers","following_url":"https://api.github.com/users/daver78/following{/other_user}","gists_url":"https://api.github.com/users/daver78/gists{/gist_id}","starred_url":"https://api.github.com/users/daver78/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daver78/subscriptions","organizations_url":"https://api.github.com/users/daver78/orgs","repos_url":"https://api.github.com/users/daver78/repos","events_url":"https://api.github.com/users/daver78/events{/privacy}","received_events_url":"https://api.github.com/users/daver78/received_events","type":"User","site_admin":false},"labels":[{"id":661015736,"url":"https://api.github.com/repos/coa0329/BhaangWeb/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"open","locked":false,"assignee":{"login":"daver78","id":7561473,"avatar_url":"https://avatars3.githubusercontent.com/u/7561473?v=4","gravatar_id":"","url":"https://api.github.com/users/daver78","html_url":"https://github.com/daver78","followers_url":"https://api.github.com/users/daver78/followers","following_url":"https://api.github.com/users/daver78/following{/other_user}","gists_url":"https://api.github.com/users/daver78/gists{/gist_id}","starred_url":"https://api.github.com/users/daver78/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daver78/subscriptions","organizations_url":"https://api.github.com/users/daver78/orgs","repos_url":"https://api.github.com/users/daver78/repos","events_url":"https://api.github.com/users/daver78/events{/privacy}","received_events_url":"https://api.github.com/users/daver78/received_events","type":"User","site_admin":false},"assignees":[{"login":"daver78","id":7561473,"avatar_url":"https://avatars3.githubusercontent.com/u/7561473?v=4","gravatar_id":"","url":"https://api.github.com/users/daver78","html_url":"https://github.com/daver78","followers_url":"https://api.github.com/users/daver78/followers","following_url":"https://api.github.com/users/daver78/following{/other_user}","gists_url":"https://api.github.com/users/daver78/gists{/gist_id}","starred_url":"https://api.github.com/users/daver78/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daver78/subscriptions","organizations_url":"https://api.github.com/users/daver78/orgs","repos_url":"https://api.github.com/users/daver78/repos","events_url":"https://api.github.com/users/daver78/events{/privacy}","received_events_url":"https://api.github.com/users/daver78/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/coa0329/BhaangWeb/milestones/4","html_url":"https://github.com/coa0329/BhaangWeb/milestone/4","labels_url":"https://api.github.com/repos/coa0329/BhaangWeb/milestones/4/labels","id":2803871,"number":4,"title":"Oct 27 2017","description":"","creator":{"login":"paagla123","id":29718335,"avatar_url":"https://avatars2.githubusercontent.com/u/29718335?v=4","gravatar_id":"","url":"https://api.github.com/users/paagla123","html_url":"https://github.com/paagla123","followers_url":"https://api.github.com/users/paagla123/followers","following_url":"https://api.github.com/users/paagla123/following{/other_user}","gists_url":"https://api.github.com/users/paagla123/gists{/gist_id}","starred_url":"https://api.github.com/users/paagla123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paagla123/subscriptions","organizations_url":"https://api.github.com/users/paagla123/orgs","repos_url":"https://api.github.com/users/paagla123/repos","events_url":"https://api.github.com/users/paagla123/events{/privacy}","received_events_url":"https://api.github.com/users/paagla123/received_events","type":"User","site_admin":false},"open_issues":18,"closed_issues":16,"state":"open","created_at":"2017-09-29T21:38:30Z","updated_at":"2017-11-01T10:25:04Z","due_on":"2017-10-27T07:00:00Z","closed_at":null},"comments":18,"created_at":"2017-09-21T18:41:48Z","updated_at":"2017-11-05T01:36:56Z","closed_at":null,"author_association":"COLLABORATOR","body":"As a User, I may not know how to edit my logo and email footer.  I think there should be a rollover 'outline' like we have for the editable stuff, but slightly different so the user gets pointed in the right direction.\r\n\r\n![image](https://user-images.githubusercontent.com/7561473/30712759-f014b74a-9ec1-11e7-8f7c-af645564fcda.png)\r\n\r\n@paweenwich I tired to edit `/templates/emails/COMPANY-EMAIL.html` but it didn't change what I saw in the UI.  Did I edit the wrong file?\r\n\r\nNote to self:\r\n- edit `COMPANY-EMAIL.html` (or whichever file @paweenwich says to edit)\r\n- edit `header.php` CSS\r\n"},"comment":{"url":"https://api.github.com/repos/coa0329/BhaangWeb/issues/comments/341942641","html_url":"https://github.com/coa0329/BhaangWeb/issues/30#issuecomment-341942641","issue_url":"https://api.github.com/repos/coa0329/BhaangWeb/issues/30","id":341942641,"user":{"login":"daver78","id":7561473,"avatar_url":"https://avatars3.githubusercontent.com/u/7561473?v=4","gravatar_id":"","url":"https://api.github.com/users/daver78","html_url":"https://github.com/daver78","followers_url":"https://api.github.com/users/daver78/followers","following_url":"https://api.github.com/users/daver78/following{/other_user}","gists_url":"https://api.github.com/users/daver78/gists{/gist_id}","starred_url":"https://api.github.com/users/daver78/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daver78/subscriptions","organizations_url":"https://api.github.com/users/daver78/orgs","repos_url":"https://api.github.com/users/daver78/repos","events_url":"https://api.github.com/users/daver78/events{/privacy}","received_events_url":"https://api.github.com/users/daver78/received_events","type":"User","site_admin":false},"created_at":"2017-11-05T01:36:56Z","updated_at":"2017-11-05T01:36:56Z","author_association":"COLLABORATOR","body":"@paagla123 I think I'm happier with this -- for now.  In order to test this, create a new email using template “Test 2 Image (Kwang)”.  Then roll over the various elements, including non-editable things.  Give me suggestions based on what you see.\r\n\r\nIf we like this, we need too apply the <div class> to the non-editable stuff in the templates we intend to go-live with.\r\n\r\nFor reference, header.php is the file that contains the modified CSS that controls this effect, called `tell_user_to_edit_in_settings`.\r\n\r\nHere's what I wrote:\r\n\r\n```\r\n\t.hover {\r\n\t\tborder: 2px solid transparent;\r\n\t}\r\n\r\n\t.hover:hover {\r\n\t\ttext-shadow: 2px 2px 20px #09d;\r\n\t\tborder: 2px dashed #09d;\r\n\t}\r\n\t\r\n\t\r\n\t\t.hover:hover:before {\r\n    display: block;\r\n\t\tmargin-top:-18px;\r\n\t\tposition:absolute; /* This is right leaves the text on top of other stuff */\r\n    clear: both;\r\n\t\ttext-align: center;\r\n\t\tpadding:0 8px;\r\n\t \twhite-space:nowrap;\r\n\t\tbackground-color: #09d;\r\n\t \tfont-size: x-small;\r\n\t \tcolor:#fff;\r\n\t \tborder-radius:4px;\r\n\t\tcontent: \"Click to edit\";\r\n\t}\r\n\t\r\n\t.tell_user_to_edit_in_settings {\r\n\t\tborder: 1px solid transparent;\r\n\t}\r\n\t\r\n\t.tell_user_to_edit_in_settings:hover {\r\n\t\tborder: 1px dashed grey;\r\n\t\ttext-shadow: 2px 2px 20px grey;\r\n\t\tcursor: not-allowed;\r\n\t}\r\n\r\n\t.tell_user_to_edit_in_settings:hover:before {\r\n    display: block;\r\n\t\tmargin-top:-18px;\r\n\t\tposition:absolute; /* This is right leaves the text on top of other stuff */\r\n    clear: both;\r\n\t\ttext-align: center;\r\n\t\tcursor: not-allowed;\r\n\t\tpadding:0 8px;\r\n\t \twhite-space:nowrap;\r\n\t\tbackground-color:#000000;\r\n\t \tfont-size: x-small;\r\n\t \tcolor:#fff;\r\n\t \tborder-radius:4px;\r\n\t\tcontent: \"Configure this element in your \\'Settings\\'\";\r\n\t}\r\n\t\r\n```\r\n@paweenwich and @coa0329 I'd like to rename the `hover` class to something more related to what it is used for (like `editable` or something).  When I created it I was rushed and didn't think of a good name.  If we change the class name, do we have to change our code too?  Let me know."}}
{"actor":{"display_login":"daver78"}}