{"action":"created","issue":{"url":"https://api.github.com/repos/minio/minio/issues/5039","repository_url":"https://api.github.com/repos/minio/minio","labels_url":"https://api.github.com/repos/minio/minio/issues/5039/labels{/name}","comments_url":"https://api.github.com/repos/minio/minio/issues/5039/comments","events_url":"https://api.github.com/repos/minio/minio/issues/5039/events","html_url":"https://github.com/minio/minio/pull/5039","id":263685365,"number":5039,"title":"Support all values in minio config to be honored through envs","user":{"login":"zerkms","id":302295,"avatar_url":"https://avatars0.githubusercontent.com/u/302295?v=4","gravatar_id":"","url":"https://api.github.com/users/zerkms","html_url":"https://github.com/zerkms","followers_url":"https://api.github.com/users/zerkms/followers","following_url":"https://api.github.com/users/zerkms/following{/other_user}","gists_url":"https://api.github.com/users/zerkms/gists{/gist_id}","starred_url":"https://api.github.com/users/zerkms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zerkms/subscriptions","organizations_url":"https://api.github.com/users/zerkms/orgs","repos_url":"https://api.github.com/users/zerkms/repos","events_url":"https://api.github.com/users/zerkms/events{/privacy}","received_events_url":"https://api.github.com/users/zerkms/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-10-08T01:41:08Z","updated_at":"2017-10-11T19:11:06Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/minio/minio/pulls/5039","html_url":"https://github.com/minio/minio/pull/5039","diff_url":"https://github.com/minio/minio/pull/5039.diff","patch_url":"https://github.com/minio/minio/pull/5039.patch"},"body":"<!--- Provide a general summary of your changes in the Title above -->\r\nThis is a possible solution for the #4998. It does not have all the necessary unit tests (it would take some time to write heaps of those), so this PR at the moment is more to confirm I'm moving the right direction.\r\n\r\n## Description\r\n<!--- Describe your changes in detail -->\r\nI made a huge refactoring on how the configuration is managed: I think this implementation is slightly more clear and is scalable to adding more environment variables.\r\n\r\n## Motivation and Context\r\n<!--- Why is this change required? What problem does it solve? -->\r\n<!--- If it fixes an open issue, please link to the issue here. -->\r\nMotivation is explained in #4998\r\n\r\n## How Has This Been Tested?\r\n<!--- Please describe in detail how you tested your changes. -->\r\n<!--- Include details of your testing environment, and the tests you ran to -->\r\n<!--- see how your change affects other areas of the code, etc. -->\r\nDuring development it was tested manually, and unit tests are WIP (it would take time to implement those and I need a confirmation this is an acceptable implementation).\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [x] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] My code follows the code style of this project.\r\n- [x] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\n- [ ] I have added tests to cover my changes.\r\n- [x] All new and existing tests passed."},"comment":{"url":"https://api.github.com/repos/minio/minio/issues/comments/335916746","html_url":"https://github.com/minio/minio/pull/5039#issuecomment-335916746","issue_url":"https://api.github.com/repos/minio/minio/issues/5039","id":335916746,"user":{"login":"zerkms","id":302295,"avatar_url":"https://avatars0.githubusercontent.com/u/302295?v=4","gravatar_id":"","url":"https://api.github.com/users/zerkms","html_url":"https://github.com/zerkms","followers_url":"https://api.github.com/users/zerkms/followers","following_url":"https://api.github.com/users/zerkms/following{/other_user}","gists_url":"https://api.github.com/users/zerkms/gists{/gist_id}","starred_url":"https://api.github.com/users/zerkms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zerkms/subscriptions","organizations_url":"https://api.github.com/users/zerkms/orgs","repos_url":"https://api.github.com/users/zerkms/repos","events_url":"https://api.github.com/users/zerkms/events{/privacy}","received_events_url":"https://api.github.com/users/zerkms/received_events","type":"User","site_admin":false},"created_at":"2017-10-11T19:11:06Z","updated_at":"2017-10-11T19:11:06Z","author_association":"NONE","body":"@vadmeste totally: I would add all the necessary tests as soon as the solution is proven to be acceptable (it's a lot of work and I don't want to waste my time if the implementation is rejected)."}}
{"actor":{"display_login":"zerkms"}}