{"action":"created","comment":{"url":"https://api.github.com/repos/SBWGroup/eScavenge/pulls/comments/149727614","pull_request_review_id":75167793,"id":149727614,"diff_hunk":"@@ -64,10 +68,13 @@ def list_landmarks(self) -> str:\n \t\treturn string_list\n \n \tdef create_team(self, name: str, password: str) -> bool:\n+\t\tif(self.myGame.has_user_by_name(name) is False):","path":"GameMaker.py","position":37,"original_position":37,"commit_id":"a816b11c94869748e693d58ab90999b3f4b18f30","original_commit_id":"a816b11c94869748e693d58ab90999b3f4b18f30","user":{"login":"teusday","id":6055251,"avatar_url":"https://avatars1.githubusercontent.com/u/6055251?v=4","gravatar_id":"","url":"https://api.github.com/users/teusday","html_url":"https://github.com/teusday","followers_url":"https://api.github.com/users/teusday/followers","following_url":"https://api.github.com/users/teusday/following{/other_user}","gists_url":"https://api.github.com/users/teusday/gists{/gist_id}","starred_url":"https://api.github.com/users/teusday/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teusday/subscriptions","organizations_url":"https://api.github.com/users/teusday/orgs","repos_url":"https://api.github.com/users/teusday/repos","events_url":"https://api.github.com/users/teusday/events{/privacy}","received_events_url":"https://api.github.com/users/teusday/received_events","type":"User","site_admin":false},"body":"For code quality reasons, this could be `if not self.myGame.has_user_by_name(name)`","created_at":"2017-11-08T16:48:26Z","updated_at":"2017-11-08T16:48:26Z","html_url":"https://github.com/SBWGroup/eScavenge/pull/62#discussion_r149727614","pull_request_url":"https://api.github.com/repos/SBWGroup/eScavenge/pulls/62","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/SBWGroup/eScavenge/pulls/comments/149727614"},"html":{"href":"https://github.com/SBWGroup/eScavenge/pull/62#discussion_r149727614"},"pull_request":{"href":"https://api.github.com/repos/SBWGroup/eScavenge/pulls/62"}}},"pull_request":{"url":"https://api.github.com/repos/SBWGroup/eScavenge/pulls/62","id":151429406,"html_url":"https://github.com/SBWGroup/eScavenge/pull/62","diff_url":"https://github.com/SBWGroup/eScavenge/pull/62.diff","patch_url":"https://github.com/SBWGroup/eScavenge/pull/62.patch","issue_url":"https://api.github.com/repos/SBWGroup/eScavenge/issues/62","number":62,"state":"open","locked":false,"title":"Worked through the tests...","user":{"login":"leithouse","id":27792659,"avatar_url":"https://avatars3.githubusercontent.com/u/27792659?v=4","gravatar_id":"","url":"https://api.github.com/users/leithouse","html_url":"https://github.com/leithouse","followers_url":"https://api.github.com/users/leithouse/followers","following_url":"https://api.github.com/users/leithouse/following{/other_user}","gists_url":"https://api.github.com/users/leithouse/gists{/gist_id}","starred_url":"https://api.github.com/users/leithouse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leithouse/subscriptions","organizations_url":"https://api.github.com/users/leithouse/orgs","repos_url":"https://api.github.com/users/leithouse/repos","events_url":"https://api.github.com/users/leithouse/events{/privacy}","received_events_url":"https://api.github.com/users/leithouse/received_events","type":"User","site_admin":false},"body":"Changed userList from dict { *user.name* : *user*} to just [ *user* ]\r\n    - get_user_index_by_name(*name*) returns int index of user list\r\n    - get_user_by_name(*name*) return User instance\r\n    - get_maker() returns User Instance\r\n    - (all in Game)\r\n\r\nChanged Confirmation.confirmation to Confirmation.answer (we have a lot of repeated words, we should try to avoid that. For example instances of User named user)\r\n\r\nMinor Changes:\r\n\r\n- Game was missing is_on from interface\r\n- Differentiated internal login exception from printed error message\r\n\r\nOtherwise just refactoring and tweaking to pass the tests, I didn't write any new ones, just got all the ones there to pass","created_at":"2017-11-08T16:25:54Z","updated_at":"2017-11-08T16:48:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e75ae59e2ea0fb1041229a67d2e988dc96fd4185","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/SBWGroup/eScavenge/pulls/62/commits","review_comments_url":"https://api.github.com/repos/SBWGroup/eScavenge/pulls/62/comments","review_comment_url":"https://api.github.com/repos/SBWGroup/eScavenge/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SBWGroup/eScavenge/issues/62/comments","statuses_url":"https://api.github.com/repos/SBWGroup/eScavenge/statuses/a816b11c94869748e693d58ab90999b3f4b18f30","head":{"label":"SBWGroup:Andrew_10_8_Morning","ref":"Andrew_10_8_Morning","sha":"a816b11c94869748e693d58ab90999b3f4b18f30","user":{"login":"SBWGroup","id":32341802,"avatar_url":"https://avatars3.githubusercontent.com/u/32341802?v=4","gravatar_id":"","url":"https://api.github.com/users/SBWGroup","html_url":"https://github.com/SBWGroup","followers_url":"https://api.github.com/users/SBWGroup/followers","following_url":"https://api.github.com/users/SBWGroup/following{/other_user}","gists_url":"https://api.github.com/users/SBWGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/SBWGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SBWGroup/subscriptions","organizations_url":"https://api.github.com/users/SBWGroup/orgs","repos_url":"https://api.github.com/users/SBWGroup/repos","events_url":"https://api.github.com/users/SBWGroup/events{/privacy}","received_events_url":"https://api.github.com/users/SBWGroup/received_events","type":"Organization","site_admin":false},"repo":{"id":107353616,"name":"eScavenge","full_name":"SBWGroup/eScavenge","owner":{"login":"SBWGroup","id":32341802,"avatar_url":"https://avatars3.githubusercontent.com/u/32341802?v=4","gravatar_id":"","url":"https://api.github.com/users/SBWGroup","html_url":"https://github.com/SBWGroup","followers_url":"https://api.github.com/users/SBWGroup/followers","following_url":"https://api.github.com/users/SBWGroup/following{/other_user}","gists_url":"https://api.github.com/users/SBWGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/SBWGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SBWGroup/subscriptions","organizations_url":"https://api.github.com/users/SBWGroup/orgs","repos_url":"https://api.github.com/users/SBWGroup/repos","events_url":"https://api.github.com/users/SBWGroup/events{/privacy}","received_events_url":"https://api.github.com/users/SBWGroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SBWGroup/eScavenge","description":"A scrum-built scavenger hunt enabling app","fork":false,"url":"https://api.github.com/repos/SBWGroup/eScavenge","forks_url":"https://api.github.com/repos/SBWGroup/eScavenge/forks","keys_url":"https://api.github.com/repos/SBWGroup/eScavenge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SBWGroup/eScavenge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SBWGroup/eScavenge/teams","hooks_url":"https://api.github.com/repos/SBWGroup/eScavenge/hooks","issue_events_url":"https://api.github.com/repos/SBWGroup/eScavenge/issues/events{/number}","events_url":"https://api.github.com/repos/SBWGroup/eScavenge/events","assignees_url":"https://api.github.com/repos/SBWGroup/eScavenge/assignees{/user}","branches_url":"https://api.github.com/repos/SBWGroup/eScavenge/branches{/branch}","tags_url":"https://api.github.com/repos/SBWGroup/eScavenge/tags","blobs_url":"https://api.github.com/repos/SBWGroup/eScavenge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SBWGroup/eScavenge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SBWGroup/eScavenge/git/refs{/sha}","trees_url":"https://api.github.com/repos/SBWGroup/eScavenge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SBWGroup/eScavenge/statuses/{sha}","languages_url":"https://api.github.com/repos/SBWGroup/eScavenge/languages","stargazers_url":"https://api.github.com/repos/SBWGroup/eScavenge/stargazers","contributors_url":"https://api.github.com/repos/SBWGroup/eScavenge/contributors","subscribers_url":"https://api.github.com/repos/SBWGroup/eScavenge/subscribers","subscription_url":"https://api.github.com/repos/SBWGroup/eScavenge/subscription","commits_url":"https://api.github.com/repos/SBWGroup/eScavenge/commits{/sha}","git_commits_url":"https://api.github.com/repos/SBWGroup/eScavenge/git/commits{/sha}","comments_url":"https://api.github.com/repos/SBWGroup/eScavenge/comments{/number}","issue_comment_url":"https://api.github.com/repos/SBWGroup/eScavenge/issues/comments{/number}","contents_url":"https://api.github.com/repos/SBWGroup/eScavenge/contents/{+path}","compare_url":"https://api.github.com/repos/SBWGroup/eScavenge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SBWGroup/eScavenge/merges","archive_url":"https://api.github.com/repos/SBWGroup/eScavenge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SBWGroup/eScavenge/downloads","issues_url":"https://api.github.com/repos/SBWGroup/eScavenge/issues{/number}","pulls_url":"https://api.github.com/repos/SBWGroup/eScavenge/pulls{/number}","milestones_url":"https://api.github.com/repos/SBWGroup/eScavenge/milestones{/number}","notifications_url":"https://api.github.com/repos/SBWGroup/eScavenge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SBWGroup/eScavenge/labels{/name}","releases_url":"https://api.github.com/repos/SBWGroup/eScavenge/releases{/id}","deployments_url":"https://api.github.com/repos/SBWGroup/eScavenge/deployments","created_at":"2017-10-18T03:19:24Z","updated_at":"2017-10-31T14:39:24Z","pushed_at":"2017-11-08T16:25:54Z","git_url":"git://github.com/SBWGroup/eScavenge.git","ssh_url":"git@github.com:SBWGroup/eScavenge.git","clone_url":"https://github.com/SBWGroup/eScavenge.git","svn_url":"https://github.com/SBWGroup/eScavenge","homepage":null,"size":1061,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":27,"forks":0,"open_issues":27,"watchers":0,"default_branch":"master"}},"base":{"label":"SBWGroup:master","ref":"master","sha":"3d7e9a9406f93058510ca96d9ac88ea98beedf77","user":{"login":"SBWGroup","id":32341802,"avatar_url":"https://avatars3.githubusercontent.com/u/32341802?v=4","gravatar_id":"","url":"https://api.github.com/users/SBWGroup","html_url":"https://github.com/SBWGroup","followers_url":"https://api.github.com/users/SBWGroup/followers","following_url":"https://api.github.com/users/SBWGroup/following{/other_user}","gists_url":"https://api.github.com/users/SBWGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/SBWGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SBWGroup/subscriptions","organizations_url":"https://api.github.com/users/SBWGroup/orgs","repos_url":"https://api.github.com/users/SBWGroup/repos","events_url":"https://api.github.com/users/SBWGroup/events{/privacy}","received_events_url":"https://api.github.com/users/SBWGroup/received_events","type":"Organization","site_admin":false},"repo":{"id":107353616,"name":"eScavenge","full_name":"SBWGroup/eScavenge","owner":{"login":"SBWGroup","id":32341802,"avatar_url":"https://avatars3.githubusercontent.com/u/32341802?v=4","gravatar_id":"","url":"https://api.github.com/users/SBWGroup","html_url":"https://github.com/SBWGroup","followers_url":"https://api.github.com/users/SBWGroup/followers","following_url":"https://api.github.com/users/SBWGroup/following{/other_user}","gists_url":"https://api.github.com/users/SBWGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/SBWGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SBWGroup/subscriptions","organizations_url":"https://api.github.com/users/SBWGroup/orgs","repos_url":"https://api.github.com/users/SBWGroup/repos","events_url":"https://api.github.com/users/SBWGroup/events{/privacy}","received_events_url":"https://api.github.com/users/SBWGroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SBWGroup/eScavenge","description":"A scrum-built scavenger hunt enabling app","fork":false,"url":"https://api.github.com/repos/SBWGroup/eScavenge","forks_url":"https://api.github.com/repos/SBWGroup/eScavenge/forks","keys_url":"https://api.github.com/repos/SBWGroup/eScavenge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SBWGroup/eScavenge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SBWGroup/eScavenge/teams","hooks_url":"https://api.github.com/repos/SBWGroup/eScavenge/hooks","issue_events_url":"https://api.github.com/repos/SBWGroup/eScavenge/issues/events{/number}","events_url":"https://api.github.com/repos/SBWGroup/eScavenge/events","assignees_url":"https://api.github.com/repos/SBWGroup/eScavenge/assignees{/user}","branches_url":"https://api.github.com/repos/SBWGroup/eScavenge/branches{/branch}","tags_url":"https://api.github.com/repos/SBWGroup/eScavenge/tags","blobs_url":"https://api.github.com/repos/SBWGroup/eScavenge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SBWGroup/eScavenge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SBWGroup/eScavenge/git/refs{/sha}","trees_url":"https://api.github.com/repos/SBWGroup/eScavenge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SBWGroup/eScavenge/statuses/{sha}","languages_url":"https://api.github.com/repos/SBWGroup/eScavenge/languages","stargazers_url":"https://api.github.com/repos/SBWGroup/eScavenge/stargazers","contributors_url":"https://api.github.com/repos/SBWGroup/eScavenge/contributors","subscribers_url":"https://api.github.com/repos/SBWGroup/eScavenge/subscribers","subscription_url":"https://api.github.com/repos/SBWGroup/eScavenge/subscription","commits_url":"https://api.github.com/repos/SBWGroup/eScavenge/commits{/sha}","git_commits_url":"https://api.github.com/repos/SBWGroup/eScavenge/git/commits{/sha}","comments_url":"https://api.github.com/repos/SBWGroup/eScavenge/comments{/number}","issue_comment_url":"https://api.github.com/repos/SBWGroup/eScavenge/issues/comments{/number}","contents_url":"https://api.github.com/repos/SBWGroup/eScavenge/contents/{+path}","compare_url":"https://api.github.com/repos/SBWGroup/eScavenge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SBWGroup/eScavenge/merges","archive_url":"https://api.github.com/repos/SBWGroup/eScavenge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SBWGroup/eScavenge/downloads","issues_url":"https://api.github.com/repos/SBWGroup/eScavenge/issues{/number}","pulls_url":"https://api.github.com/repos/SBWGroup/eScavenge/pulls{/number}","milestones_url":"https://api.github.com/repos/SBWGroup/eScavenge/milestones{/number}","notifications_url":"https://api.github.com/repos/SBWGroup/eScavenge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SBWGroup/eScavenge/labels{/name}","releases_url":"https://api.github.com/repos/SBWGroup/eScavenge/releases{/id}","deployments_url":"https://api.github.com/repos/SBWGroup/eScavenge/deployments","created_at":"2017-10-18T03:19:24Z","updated_at":"2017-10-31T14:39:24Z","pushed_at":"2017-11-08T16:25:54Z","git_url":"git://github.com/SBWGroup/eScavenge.git","ssh_url":"git@github.com:SBWGroup/eScavenge.git","clone_url":"https://github.com/SBWGroup/eScavenge.git","svn_url":"https://github.com/SBWGroup/eScavenge","homepage":null,"size":1061,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":27,"forks":0,"open_issues":27,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SBWGroup/eScavenge/pulls/62"},"html":{"href":"https://github.com/SBWGroup/eScavenge/pull/62"},"issue":{"href":"https://api.github.com/repos/SBWGroup/eScavenge/issues/62"},"comments":{"href":"https://api.github.com/repos/SBWGroup/eScavenge/issues/62/comments"},"review_comments":{"href":"https://api.github.com/repos/SBWGroup/eScavenge/pulls/62/comments"},"review_comment":{"href":"https://api.github.com/repos/SBWGroup/eScavenge/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SBWGroup/eScavenge/pulls/62/commits"},"statuses":{"href":"https://api.github.com/repos/SBWGroup/eScavenge/statuses/a816b11c94869748e693d58ab90999b3f4b18f30"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"teusday"}}