{"action":"created","issue":{"url":"https://api.github.com/repos/ropensci/onboarding/issues/34","repository_url":"https://api.github.com/repos/ropensci/onboarding","labels_url":"https://api.github.com/repos/ropensci/onboarding/issues/34/labels{/name}","comments_url":"https://api.github.com/repos/ropensci/onboarding/issues/34/comments","events_url":"https://api.github.com/repos/ropensci/onboarding/issues/34/events","html_url":"https://github.com/ropensci/onboarding/issues/34","id":147451591,"number":34,"title":"The Database of Odorant Responses (DoOR.functions)","user":{"login":"Dahaniel","id":2735008,"avatar_url":"https://avatars3.githubusercontent.com/u/2735008?v=4","gravatar_id":"","url":"https://api.github.com/users/Dahaniel","html_url":"https://github.com/Dahaniel","followers_url":"https://api.github.com/users/Dahaniel/followers","following_url":"https://api.github.com/users/Dahaniel/following{/other_user}","gists_url":"https://api.github.com/users/Dahaniel/gists{/gist_id}","starred_url":"https://api.github.com/users/Dahaniel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dahaniel/subscriptions","organizations_url":"https://api.github.com/users/Dahaniel/orgs","repos_url":"https://api.github.com/users/Dahaniel/repos","events_url":"https://api.github.com/users/Dahaniel/events{/privacy}","received_events_url":"https://api.github.com/users/Dahaniel/received_events","type":"User","site_admin":false},"labels":[{"id":213712178,"url":"https://api.github.com/repos/ropensci/onboarding/labels/4/review(s)-in-awaiting-changes","name":"4/review(s)-in-awaiting-changes","color":"bfd4f2","default":false},{"id":185501572,"url":"https://api.github.com/repos/ropensci/onboarding/labels/package","name":"package","color":"fbca04","default":false},{"id":356338783,"url":"https://api.github.com/repos/ropensci/onboarding/labels/topic:data-only-pkg","name":"topic:data-only-pkg","color":"2D7000","default":false},{"id":356339453,"url":"https://api.github.com/repos/ropensci/onboarding/labels/topic:physiology","name":"topic:physiology","color":"6ABF49","default":false}],"state":"open","locked":false,"assignee":{"login":"noamross","id":571752,"avatar_url":"https://avatars1.githubusercontent.com/u/571752?v=4","gravatar_id":"","url":"https://api.github.com/users/noamross","html_url":"https://github.com/noamross","followers_url":"https://api.github.com/users/noamross/followers","following_url":"https://api.github.com/users/noamross/following{/other_user}","gists_url":"https://api.github.com/users/noamross/gists{/gist_id}","starred_url":"https://api.github.com/users/noamross/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noamross/subscriptions","organizations_url":"https://api.github.com/users/noamross/orgs","repos_url":"https://api.github.com/users/noamross/repos","events_url":"https://api.github.com/users/noamross/events{/privacy}","received_events_url":"https://api.github.com/users/noamross/received_events","type":"User","site_admin":false},"assignees":[{"login":"noamross","id":571752,"avatar_url":"https://avatars1.githubusercontent.com/u/571752?v=4","gravatar_id":"","url":"https://api.github.com/users/noamross","html_url":"https://github.com/noamross","followers_url":"https://api.github.com/users/noamross/followers","following_url":"https://api.github.com/users/noamross/following{/other_user}","gists_url":"https://api.github.com/users/noamross/gists{/gist_id}","starred_url":"https://api.github.com/users/noamross/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noamross/subscriptions","organizations_url":"https://api.github.com/users/noamross/orgs","repos_url":"https://api.github.com/users/noamross/repos","events_url":"https://api.github.com/users/noamross/events{/privacy}","received_events_url":"https://api.github.com/users/noamross/received_events","type":"User","site_admin":false},{"login":"sckott","id":577668,"avatar_url":"https://avatars1.githubusercontent.com/u/577668?v=4","gravatar_id":"","url":"https://api.github.com/users/sckott","html_url":"https://github.com/sckott","followers_url":"https://api.github.com/users/sckott/followers","following_url":"https://api.github.com/users/sckott/following{/other_user}","gists_url":"https://api.github.com/users/sckott/gists{/gist_id}","starred_url":"https://api.github.com/users/sckott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sckott/subscriptions","organizations_url":"https://api.github.com/users/sckott/orgs","repos_url":"https://api.github.com/users/sckott/repos","events_url":"https://api.github.com/users/sckott/events{/privacy}","received_events_url":"https://api.github.com/users/sckott/received_events","type":"User","site_admin":false}],"milestone":null,"comments":26,"created_at":"2016-04-11T14:41:37Z","updated_at":"2017-08-25T14:20:14Z","closed_at":null,"body":"- 1. What does this package do? (explain in 50 words or less)\n\nPackage containing the functions for the DoOR project. DoOR provides a framework to merge heterogeneous response data into a single consensus database, thus creating a comprehensive view on olfactory coding.\n- 2. Paste the full DESCRIPTION file inside a code block below.\n\n```\nPackage: DoOR.functions\nType: Package\nTitle: Integrating Heterogeneous Odorant Response Data into a Common Response\n    Model: A DoOR to the Complete Olfactome\nVersion: 2.0.0\nDate: 2016-02-25\nAuthors@R: c(\n    person(\"Daniel\", \"Münch\", email = \"daniel.muench@uni-konstanz.de\", role = c(\"aut\", \"cre\")),\n    person(\"C. Giovanni\", \"Galizia\", email = \"giovanni.galizia@uni-konstanz.de\", role = \"aut\"),\n    person(\"Shouwen\", \"Ma\", role = \"aut\"),\n    person(\"Martin\", \"Strauch\", role = \"aut\"),\n    person(\"Anja\", \"Nissler\", role = \"aut\"),\n    person(\"Wolf\", \"Huetteroth\", role = \"ctb\"))\nURL: http://neuro.uni.kn/DoOR\nBugReports: https://github.com/Dahaniel/DoOR.data/issues\nDescription: This is a function package providing functions to perform data\n    manipulations and visualizations for DoOR.data. See http://dx.doi.org/10.1093/chemse/bjq042 for the original publication and http://dx.doi.org/10.1038/srep21841\n    regarding version 2.0.\nLicense: GPL-3\nEncoding: UTF-8\nImports:\n    utils\nDepends:\n    DoOR.data (>= 2.0.0),\n    R (>= 3.2.0)\nRemotes: Dahaniel/DoOR.data@v2.0.0\nSuggests:\n    ggplot2,\n    grid,\n    gridExtra (>= 2.0.0),\n    knitr,\n    class,\n    rmarkdown\nVignetteBuilder: knitr\nRoxygenNote: 5.0.1\n\n```\n- 3. URL for the package (the development repository, not a stylized html page)\n\nhttps://github.com/Dahaniel/DoOR.functions\n- 4. What data source(s) does it work with (if applicable)?\n\nIt provides its own data via the `DoOR.data` package (see corresponding onboarding issue).\n- 5. Who is the target audience?\n\nScientists working on olfactory coding, modelers and physiologists.\n- 6. Are there other R packages that accomplish the same thing? If so, what is different about yours?\n\nNo, to our knowledge DoOR is the only project providing this kind of data and using this approach to integrate heterogeneous data.\n- 7. Check the box next to each policy below, confirming that you agree. These are mandatory.\n  - [x] This package does not violate the Terms of Service of any service it interacts with.\n  - [x] The repository has continuous integration with Travis CI and/or another service\n  - [x] The package contains a vignette\n  - [x] The package contains a reasonably complete README with `devtools` install instructions\n  - [ ] The package contains unit tests\n  - [x] The package only exports functions to the NAMESPACE that are intended for end users\n- 8. Do you agree to follow the [rOpenSci packaging guidelines](https://github.com/ropensci/packaging_guide)? These aren't mandatory, but we strongly suggest you follow them. If you disagree with anything, please explain.\n  - [ ] Are there any package dependencies not on CRAN? - _no_\n  - [x] Do you intend for this package to go on CRAN?\n  - [x] Does the package have a CRAN accepted license?\n  - [ ] Did `devtools::check()` produce any errors or warnings? If so paste them below. - _no_\n- 9. Please add explanations below for any exceptions to the above:\n  - Not sure how to implement unit tests but am willing to learn, might need some help.\n- 10. If this is a resubmission following rejection, please explain the change in circumstances.  \n"},"comment":{"url":"https://api.github.com/repos/ropensci/onboarding/issues/comments/324934191","html_url":"https://github.com/ropensci/onboarding/issues/34#issuecomment-324934191","issue_url":"https://api.github.com/repos/ropensci/onboarding/issues/34","id":324934191,"user":{"login":"Dahaniel","id":2735008,"avatar_url":"https://avatars3.githubusercontent.com/u/2735008?v=4","gravatar_id":"","url":"https://api.github.com/users/Dahaniel","html_url":"https://github.com/Dahaniel","followers_url":"https://api.github.com/users/Dahaniel/followers","following_url":"https://api.github.com/users/Dahaniel/following{/other_user}","gists_url":"https://api.github.com/users/Dahaniel/gists{/gist_id}","starred_url":"https://api.github.com/users/Dahaniel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dahaniel/subscriptions","organizations_url":"https://api.github.com/users/Dahaniel/orgs","repos_url":"https://api.github.com/users/Dahaniel/repos","events_url":"https://api.github.com/users/Dahaniel/events{/privacy}","received_events_url":"https://api.github.com/users/Dahaniel/received_events","type":"User","site_admin":false},"created_at":"2017-08-25T14:20:14Z","updated_at":"2017-08-25T14:20:14Z","body":"Ok, should be done.\r\n\r\nI fixed:\r\n- [x] added basic unit tests to both packages\r\n- [x] fixed the 'no visible binding for global variable'\r\n- [x] moved CHANGELOG to NEWS.md\r\n- [x] added entries to .Rbuildignore \r\n\r\nthere remains: \r\n- [ ] a NOTE about loading data to the global environment  that will stay for now (see https://github.com/ropensci/onboarding/issues/35#issuecomment-218391691)\r\n- [ ] circularity: Not sure what is the appropriate solution: I kept `DoOR.data` in Depends as the algorithms in `DoOR.functions` need data from `DoOR.data` to run (vignettes and examples would not work without). `DoOR.functions` is in suggests in `DoOR.data` as  the two packages basically belong together."}}
{"actor":{"display_login":"Dahaniel"}}