{"action":"created","issue":{"url":"https://api.github.com/repos/business-science/tidyquant/issues/45","repository_url":"https://api.github.com/repos/business-science/tidyquant","labels_url":"https://api.github.com/repos/business-science/tidyquant/issues/45/labels{/name}","comments_url":"https://api.github.com/repos/business-science/tidyquant/issues/45/comments","events_url":"https://api.github.com/repos/business-science/tidyquant/issues/45/events","html_url":"https://github.com/business-science/tidyquant/pull/45","id":236305341,"number":45,"title":"Basic support for arbitrary exchange source in key.ratios","user":{"login":"mwaldstein","id":80634,"avatar_url":"https://avatars1.githubusercontent.com/u/80634?v=3","gravatar_id":"","url":"https://api.github.com/users/mwaldstein","html_url":"https://github.com/mwaldstein","followers_url":"https://api.github.com/users/mwaldstein/followers","following_url":"https://api.github.com/users/mwaldstein/following{/other_user}","gists_url":"https://api.github.com/users/mwaldstein/gists{/gist_id}","starred_url":"https://api.github.com/users/mwaldstein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwaldstein/subscriptions","organizations_url":"https://api.github.com/users/mwaldstein/orgs","repos_url":"https://api.github.com/users/mwaldstein/repos","events_url":"https://api.github.com/users/mwaldstein/events{/privacy}","received_events_url":"https://api.github.com/users/mwaldstein/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-06-15T20:29:47Z","updated_at":"2017-06-16T14:49:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/business-science/tidyquant/pulls/45","html_url":"https://github.com/business-science/tidyquant/pull/45","diff_url":"https://github.com/business-science/tidyquant/pull/45.diff","patch_url":"https://github.com/business-science/tidyquant/pull/45.patch"},"body":"Should address https://github.com/business-science/tidyquant/issues/26\r\n\r\nEnables basic fetching of key.ratios / morningstar financial data by splitting the collection of morningstar data from the calculation of valuation ratios."},"comment":{"url":"https://api.github.com/repos/business-science/tidyquant/issues/comments/309046520","html_url":"https://github.com/business-science/tidyquant/pull/45#issuecomment-309046520","issue_url":"https://api.github.com/repos/business-science/tidyquant/issues/45","id":309046520,"user":{"login":"mdancho84","id":13734662,"avatar_url":"https://avatars0.githubusercontent.com/u/13734662?v=3","gravatar_id":"","url":"https://api.github.com/users/mdancho84","html_url":"https://github.com/mdancho84","followers_url":"https://api.github.com/users/mdancho84/followers","following_url":"https://api.github.com/users/mdancho84/following{/other_user}","gists_url":"https://api.github.com/users/mdancho84/gists{/gist_id}","starred_url":"https://api.github.com/users/mdancho84/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdancho84/subscriptions","organizations_url":"https://api.github.com/users/mdancho84/orgs","repos_url":"https://api.github.com/users/mdancho84/repos","events_url":"https://api.github.com/users/mdancho84/events{/privacy}","received_events_url":"https://api.github.com/users/mdancho84/received_events","type":"User","site_admin":false},"created_at":"2017-06-16T14:49:55Z","updated_at":"2017-06-16T14:49:55Z","body":"@mwaldstein Code is spot on for providing two options. The big consideration we need to think about is how to ensure the P/E ratio is calculated correctly each time. If this is not possible, then we should not provide this data, and then only one option should be available. If we can do it, I think two options could be \"key.ratios\" and \"key.ratios.pe\" or something like this to keep the users on the same page with minor difference between options. What are your thoughts?"}}
{"actor":{"display_login":"mdancho84"}}