{"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/98001720","pull_request_review_id":18629467,"id":98001720,"diff_hunk":"@@ -28,8 +28,8 @@ public function __construct($documentRoot, $env, $address = null, $router = null\n             throw new \\InvalidArgumentException(sprintf('The document root directory \"%s\" does not exist.', $documentRoot));\n         }\n \n-        if (null === $file = $this->guessFrontController($documentRoot, $env)) {\n-            throw new \\InvalidArgumentException(sprintf('Unable to guess the front controller under \"%s\".', $documentRoot));\n+        if (null === $file = $this->findFrontController($documentRoot, $env)) {\n+            throw new \\InvalidArgumentException(sprintf('Unable to find the front controller under \"%s\" (expected to find it as: %s).', $documentRoot, implode(', ', $this->getFrontControllerFileNames($env))));","path":"src/Symfony/Bundle/WebServerBundle/WebServerConfig.php","position":7,"original_position":7,"commit_id":"c513142df8005ed01b2ea3ab53f561fc6dfa7c94","original_commit_id":"c513142df8005ed01b2ea3ab53f561fc6dfa7c94","user":{"login":"javiereguiluz","id":73419,"avatar_url":"https://avatars.githubusercontent.com/u/73419?v=3","gravatar_id":"","url":"https://api.github.com/users/javiereguiluz","html_url":"https://github.com/javiereguiluz","followers_url":"https://api.github.com/users/javiereguiluz/followers","following_url":"https://api.github.com/users/javiereguiluz/following{/other_user}","gists_url":"https://api.github.com/users/javiereguiluz/gists{/gist_id}","starred_url":"https://api.github.com/users/javiereguiluz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javiereguiluz/subscriptions","organizations_url":"https://api.github.com/users/javiereguiluz/orgs","repos_url":"https://api.github.com/users/javiereguiluz/repos","events_url":"https://api.github.com/users/javiereguiluz/events{/privacy}","received_events_url":"https://api.github.com/users/javiereguiluz/received_events","type":"User","site_admin":false},"body":"Instead of `(expected to find it as: %s)`\r\nwhy not: `(looked for these files: %s)` or `(none of these files exist: %s)` or something like that.","created_at":"2017-01-26T14:20:40Z","updated_at":"2017-01-26T14:20:40Z","html_url":"https://github.com/symfony/symfony/pull/21407#discussion_r98001720","pull_request_url":"https://api.github.com/repos/symfony/symfony/pulls/21407","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/98001720"},"html":{"href":"https://github.com/symfony/symfony/pull/21407#discussion_r98001720"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/21407"}}},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/21407","id":103150223,"html_url":"https://github.com/symfony/symfony/pull/21407","diff_url":"https://github.com/symfony/symfony/pull/21407.diff","patch_url":"https://github.com/symfony/symfony/pull/21407.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/21407","number":21407,"state":"open","locked":false,"title":"[WebServerBundle] Improved exception message","user":{"login":"wouterj","id":749025,"avatar_url":"https://avatars.githubusercontent.com/u/749025?v=3","gravatar_id":"","url":"https://api.github.com/users/wouterj","html_url":"https://github.com/wouterj","followers_url":"https://api.github.com/users/wouterj/followers","following_url":"https://api.github.com/users/wouterj/following{/other_user}","gists_url":"https://api.github.com/users/wouterj/gists{/gist_id}","starred_url":"https://api.github.com/users/wouterj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wouterj/subscriptions","organizations_url":"https://api.github.com/users/wouterj/orgs","repos_url":"https://api.github.com/users/wouterj/repos","events_url":"https://api.github.com/users/wouterj/events{/privacy}","received_events_url":"https://api.github.com/users/wouterj/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Branch?       | master\r\n| Bug fix?      | no\r\n| New feature?  | no\r\n| BC breaks?    | no\r\n| Deprecations? | no\r\n| Tests pass?   | yes\r\n| Fixed tickets | -\r\n| License       | MIT\r\n| Doc PR        | -\r\n\r\nThis is a quite minor one, but imo \"guessing\" is something that's optional. If I don't pass value X, a script will guess value X. However, in this case, the front controller file cannot be specified. It has to be one of the \"guessed\" file names. That's why I renamed \"guessing\" to \"finding\".\r\n\r\nWhile doing this, I also added the possible file names in the exception message to ease fixing problems.","created_at":"2017-01-25T16:11:15Z","updated_at":"2017-01-26T14:20:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6adafe8e4f8128c1a0b70e13916de6c85825b3c0","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/symfony/symfony/milestones/16","html_url":"https://github.com/symfony/symfony/milestone/16","labels_url":"https://api.github.com/repos/symfony/symfony/milestones/16/labels","id":2180800,"number":16,"title":"3.3","description":"https://symfony.com/roadmap?version=3.3#checker","creator":{"login":"xabbuh","id":1957048,"avatar_url":"https://avatars.githubusercontent.com/u/1957048?v=3","gravatar_id":"","url":"https://api.github.com/users/xabbuh","html_url":"https://github.com/xabbuh","followers_url":"https://api.github.com/users/xabbuh/followers","following_url":"https://api.github.com/users/xabbuh/following{/other_user}","gists_url":"https://api.github.com/users/xabbuh/gists{/gist_id}","starred_url":"https://api.github.com/users/xabbuh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xabbuh/subscriptions","organizations_url":"https://api.github.com/users/xabbuh/orgs","repos_url":"https://api.github.com/users/xabbuh/repos","events_url":"https://api.github.com/users/xabbuh/events{/privacy}","received_events_url":"https://api.github.com/users/xabbuh/received_events","type":"User","site_admin":false},"open_issues":32,"closed_issues":45,"state":"open","created_at":"2016-12-07T08:48:45Z","updated_at":"2017-01-26T07:22:50Z","due_on":"2018-01-31T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/21407/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/21407/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/21407/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/c513142df8005ed01b2ea3ab53f561fc6dfa7c94","head":{"label":"wouterj:patch-17","ref":"patch-17","sha":"c513142df8005ed01b2ea3ab53f561fc6dfa7c94","user":{"login":"wouterj","id":749025,"avatar_url":"https://avatars.githubusercontent.com/u/749025?v=3","gravatar_id":"","url":"https://api.github.com/users/wouterj","html_url":"https://github.com/wouterj","followers_url":"https://api.github.com/users/wouterj/followers","following_url":"https://api.github.com/users/wouterj/following{/other_user}","gists_url":"https://api.github.com/users/wouterj/gists{/gist_id}","starred_url":"https://api.github.com/users/wouterj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wouterj/subscriptions","organizations_url":"https://api.github.com/users/wouterj/orgs","repos_url":"https://api.github.com/users/wouterj/repos","events_url":"https://api.github.com/users/wouterj/events{/privacy}","received_events_url":"https://api.github.com/users/wouterj/received_events","type":"User","site_admin":false},"repo":{"id":5615183,"name":"symfony","full_name":"wouterj/symfony","owner":{"login":"wouterj","id":749025,"avatar_url":"https://avatars.githubusercontent.com/u/749025?v=3","gravatar_id":"","url":"https://api.github.com/users/wouterj","html_url":"https://github.com/wouterj","followers_url":"https://api.github.com/users/wouterj/followers","following_url":"https://api.github.com/users/wouterj/following{/other_user}","gists_url":"https://api.github.com/users/wouterj/gists{/gist_id}","starred_url":"https://api.github.com/users/wouterj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wouterj/subscriptions","organizations_url":"https://api.github.com/users/wouterj/orgs","repos_url":"https://api.github.com/users/wouterj/repos","events_url":"https://api.github.com/users/wouterj/events{/privacy}","received_events_url":"https://api.github.com/users/wouterj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wouterj/symfony","description":"The Symfony2 PHP framework","fork":true,"url":"https://api.github.com/repos/wouterj/symfony","forks_url":"https://api.github.com/repos/wouterj/symfony/forks","keys_url":"https://api.github.com/repos/wouterj/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wouterj/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wouterj/symfony/teams","hooks_url":"https://api.github.com/repos/wouterj/symfony/hooks","issue_events_url":"https://api.github.com/repos/wouterj/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/wouterj/symfony/events","assignees_url":"https://api.github.com/repos/wouterj/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/wouterj/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/wouterj/symfony/tags","blobs_url":"https://api.github.com/repos/wouterj/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wouterj/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wouterj/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/wouterj/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wouterj/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/wouterj/symfony/languages","stargazers_url":"https://api.github.com/repos/wouterj/symfony/stargazers","contributors_url":"https://api.github.com/repos/wouterj/symfony/contributors","subscribers_url":"https://api.github.com/repos/wouterj/symfony/subscribers","subscription_url":"https://api.github.com/repos/wouterj/symfony/subscription","commits_url":"https://api.github.com/repos/wouterj/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/wouterj/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/wouterj/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/wouterj/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/wouterj/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/wouterj/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wouterj/symfony/merges","archive_url":"https://api.github.com/repos/wouterj/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wouterj/symfony/downloads","issues_url":"https://api.github.com/repos/wouterj/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/wouterj/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/wouterj/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/wouterj/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wouterj/symfony/labels{/name}","releases_url":"https://api.github.com/repos/wouterj/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/wouterj/symfony/deployments","created_at":"2012-08-30T13:24:57Z","updated_at":"2014-08-16T18:38:32Z","pushed_at":"2017-01-26T09:59:34Z","git_url":"git://github.com/wouterj/symfony.git","ssh_url":"git@github.com:wouterj/symfony.git","clone_url":"https://github.com/wouterj/symfony.git","svn_url":"https://github.com/wouterj/symfony","homepage":"symfony.com","size":81033,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"symfony:master","ref":"master","sha":"b9b6ebd643cfb65bae14c6fc3d9339dbcd1c9210","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"name":"symfony","full_name":"symfony/symfony","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/symfony/symfony/deployments","created_at":"2010-01-04T14:21:21Z","updated_at":"2017-01-26T13:46:08Z","pushed_at":"2017-01-26T10:50:47Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"symfony.com","size":84188,"stargazers_count":13724,"watchers_count":13724,"language":"PHP","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":5318,"mirror_url":null,"open_issues_count":876,"forks":5318,"open_issues":876,"watchers":13724,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/21407"},"html":{"href":"https://github.com/symfony/symfony/pull/21407"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/21407"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/21407/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/21407/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/21407/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/c513142df8005ed01b2ea3ab53f561fc6dfa7c94"}}}}
{"actor":{"display_login":"javiereguiluz"}}