{"action":"created","issue":{"url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/4718","repository_url":"https://api.github.com/repos/ARMmbed/mbed-os","labels_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/4718/labels{/name}","comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/4718/comments","events_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/4718/events","html_url":"https://github.com/ARMmbed/mbed-os/pull/4718","id":241022359,"number":4718,"title":"Toolchain: Add a note about weak functions and header files","user":{"login":"geky","id":1075160,"avatar_url":"https://avatars4.githubusercontent.com/u/1075160?v=3","gravatar_id":"","url":"https://api.github.com/users/geky","html_url":"https://github.com/geky","followers_url":"https://api.github.com/users/geky/followers","following_url":"https://api.github.com/users/geky/following{/other_user}","gists_url":"https://api.github.com/users/geky/gists{/gist_id}","starred_url":"https://api.github.com/users/geky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geky/subscriptions","organizations_url":"https://api.github.com/users/geky/orgs","repos_url":"https://api.github.com/users/geky/repos","events_url":"https://api.github.com/users/geky/events{/privacy}","received_events_url":"https://api.github.com/users/geky/received_events","type":"User","site_admin":false},"labels":[{"id":390046351,"url":"https://api.github.com/repos/ARMmbed/mbed-os/labels/needs:%20CI","name":"needs: CI","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2017-07-06T16:58:46Z","updated_at":"2017-07-14T04:29:58Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/4718","html_url":"https://github.com/ARMmbed/mbed-os/pull/4718","diff_url":"https://github.com/ARMmbed/mbed-os/pull/4718.diff","patch_url":"https://github.com/ARMmbed/mbed-os/pull/4718.patch"},"body":"The subtlety of where to mark functions as weak created an issue for at least one user, so added a warning in the documentation.\r\n\r\ncc @marcuschangarm"},"comment":{"url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/comments/315267036","html_url":"https://github.com/ARMmbed/mbed-os/pull/4718#issuecomment-315267036","issue_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/4718","id":315267036,"user":{"login":"studavekar","id":25986241,"avatar_url":"https://avatars7.githubusercontent.com/u/25986241?v=4","gravatar_id":"","url":"https://api.github.com/users/studavekar","html_url":"https://github.com/studavekar","followers_url":"https://api.github.com/users/studavekar/followers","following_url":"https://api.github.com/users/studavekar/following{/other_user}","gists_url":"https://api.github.com/users/studavekar/gists{/gist_id}","starred_url":"https://api.github.com/users/studavekar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/studavekar/subscriptions","organizations_url":"https://api.github.com/users/studavekar/orgs","repos_url":"https://api.github.com/users/studavekar/repos","events_url":"https://api.github.com/users/studavekar/events{/privacy}","received_events_url":"https://api.github.com/users/studavekar/received_events","type":"User","site_admin":false},"created_at":"2017-07-14T04:29:57Z","updated_at":"2017-07-14T04:29:57Z","body":"@0xc0170 from logs looks like compile fails and tools raised an exception.\r\n\r\n```\r\n19:16:41 [DEBUG] Compile: C:\\Program Files (x86)\\IAR Systems\\Embedded Workbench 7.5\\arm\\bin\\iasmarm --cpu Cortex-M4F -DTRANSACTION_QUEUE_SIZE_SPI=2 -D__CORTEX_M4 -DUSB_STM_HAL -DARM_MATH_CM4 -D__FPU_PRESENT=1 -DUSBHOST_OTHER -D__MBED_CMSIS_RTOS_CM -D__CMSIS_RTOS -f .\\BUILD\\NUCLEO_F429ZI\\IAR\\.includes_cbca0c8e1454f47ce87e3d83bfd0ebfb.txt -o .\\BUILD\\NUCLEO_F429ZI\\IAR\\mbed-os\\rtos\\rtx5\\TARGET_CORTEX_M\\TARGET_RTOS_M4_M7\\TOOLCHAIN_IAR\\irq_cm4f.o .\\mbed-os\\rtos\\rtx5\\TARGET_CORTEX_M\\TARGET_RTOS_M4_M7\\TOOLCHAIN_IAR\\irq_cm4f.S\r\n19:16:41 [DEBUG] Return: 3\r\n19:16:42 Traceback (most recent call last):\r\n19:16:42   File \"C:\\mj\\workspace\\bm_wrap\\870\\examples\\mbed-os-example-mesh-minimal\\mbed-os\\tools\\make.py\", line 280, in <module>\r\n19:16:42     toolchain))\r\n19:16:42   File \"C:\\mj\\workspace\\bm_wrap\\870\\examples\\mbed-os-example-mesh-minimal\\mbed-os\\tools\\build_api.py\", line 536, in build_project\r\n19:16:42     objects = toolchain.compile_sources(resources, resources.inc_dirs)\r\n19:16:42   File \"C:\\mj\\workspace\\bm_wrap\\870\\examples\\mbed-os-example-mesh-minimal\\mbed-os\\tools\\toolchains\\__init__.py\", line 909, in compile_sources\r\n19:16:42     return self.compile_queue(queue, objects)\r\n19:16:42   File \"C:\\mj\\workspace\\bm_wrap\\870\\examples\\mbed-os-example-mesh-minimal\\mbed-os\\tools\\toolchains\\__init__.py\", line 972, in compile_queue\r\n19:16:42     raise ToolException(err)\r\n19:16:42 ToolException\r\n``` "}}
{"actor":{"display_login":"studavekar"}}