{"action":"created","comment":{"url":"https://api.github.com/repos/vmware/docker-volume-vsphere/pulls/comments/122180468","pull_request_review_id":44268630,"id":122180468,"diff_hunk":"@@ -47,3 +56,55 @@ func KillVM(esxHostIP, worldID string) bool {\n \t}\n \treturn true\n }\n+\n+// RetrieveVMNameFromIP util retrieves VM  name from passed VM IP\n+//esxcli vm.info -vm.ip=10.20.104.62 -json | jq -r .VirtualMachines[].Name\n+func RetrieveVMNameFromIP(ip string) string {\n+\tlog.Printf(\"Finding VM name from IP Address [%s]\\n\", ip)\n+\tcmd := esxcli.VMInfoByIP + ip + esxcli.JSONTypeOutput + \"| \" + esxcli.JSONParser + esxcli.VMName","path":"tests/utils/esxcli/cmd.go","position":30,"original_position":30,"commit_id":"5fb1a97b11e4f4567bc476b7d135001c1b972ee8","original_commit_id":"5fb1a97b11e4f4567bc476b7d135001c1b972ee8","user":{"login":"govint","id":15854712,"avatar_url":"https://avatars0.githubusercontent.com/u/15854712?v=3","gravatar_id":"","url":"https://api.github.com/users/govint","html_url":"https://github.com/govint","followers_url":"https://api.github.com/users/govint/followers","following_url":"https://api.github.com/users/govint/following{/other_user}","gists_url":"https://api.github.com/users/govint/gists{/gist_id}","starred_url":"https://api.github.com/users/govint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/govint/subscriptions","organizations_url":"https://api.github.com/users/govint/orgs","repos_url":"https://api.github.com/users/govint/repos","events_url":"https://api.github.com/users/govint/events{/privacy}","received_events_url":"https://api.github.com/users/govint/received_events","type":"User","site_admin":false},"body":"Can \"esxcli.JSONTypeOutput + vmName + \" | \" + esxcli.JSONParser\" be a constant in this file and use it here and in other functions.","created_at":"2017-06-15T11:24:52Z","updated_at":"2017-06-15T11:26:17Z","html_url":"https://github.com/vmware/docker-volume-vsphere/pull/1426#discussion_r122180468","pull_request_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/pulls/1426","_links":{"self":{"href":"https://api.github.com/repos/vmware/docker-volume-vsphere/pulls/comments/122180468"},"html":{"href":"https://github.com/vmware/docker-volume-vsphere/pull/1426#discussion_r122180468"},"pull_request":{"href":"https://api.github.com/repos/vmware/docker-volume-vsphere/pulls/1426"}}},"pull_request":{"url":"https://api.github.com/repos/vmware/docker-volume-vsphere/pulls/1426","id":125727082,"html_url":"https://github.com/vmware/docker-volume-vsphere/pull/1426","diff_url":"https://github.com/vmware/docker-volume-vsphere/pull/1426.diff","patch_url":"https://github.com/vmware/docker-volume-vsphere/pull/1426.patch","issue_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/issues/1426","number":1426,"state":"open","locked":false,"title":"Merge esxcli and govc test utils to single file","user":{"login":"ashahi1","id":23107823,"avatar_url":"https://avatars2.githubusercontent.com/u/23107823?v=3","gravatar_id":"","url":"https://api.github.com/users/ashahi1","html_url":"https://github.com/ashahi1","followers_url":"https://api.github.com/users/ashahi1/followers","following_url":"https://api.github.com/users/ashahi1/following{/other_user}","gists_url":"https://api.github.com/users/ashahi1/gists{/gist_id}","starred_url":"https://api.github.com/users/ashahi1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashahi1/subscriptions","organizations_url":"https://api.github.com/users/ashahi1/orgs","repos_url":"https://api.github.com/users/ashahi1/repos","events_url":"https://api.github.com/users/ashahi1/events{/privacy}","received_events_url":"https://api.github.com/users/ashahi1/received_events","type":"User","site_admin":false},"body":"govc and esxcli are just the different interfaces that are used to communicate with ESX. Its better if we combine them into single file. Hence creating a single ESX module.\r\n\r\nTested locally. Failed tests are the two swarm tests which did not run as my setup didn't have swarm configured. Rest all tests passed. \r\n\r\n\r\n```\r\ntarget e2e-test-runalways:\r\n\r\nOK: 4 passed\r\n--- PASS: Test (98.12s)\r\nPASS\r\n\r\n----------------\r\n\r\ntarget e2e-test-runonce:\r\n\r\nOOPS: 15 passed, 2 FAILED, 1 MISSED\r\n--- FAIL: Test (242.50s)\r\nFAIL\r\nexit status 1\r\nFAIL\tgithub.com/vmware/docker-volume-vsphere/tests/e2e\t242.502s\r\nmake: *** [e2e-test-runonce] Error 1\r\nmake: Leaving directory `/go/src/github.com/vmware/docker-volume-vsphere/vmdk_plugin'\r\nmake[1]: *** [e2e-test] Error 2\r\nmake: *** [e2e-test] Error 2\r\n\r\n```\r\n\r\nFailed tests ","created_at":"2017-06-15T01:55:01Z","updated_at":"2017-06-15T11:26:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3f89d35024a55bbd48e886984ad42f6fd88aa3c2","assignee":{"login":"ashahi1","id":23107823,"avatar_url":"https://avatars2.githubusercontent.com/u/23107823?v=3","gravatar_id":"","url":"https://api.github.com/users/ashahi1","html_url":"https://github.com/ashahi1","followers_url":"https://api.github.com/users/ashahi1/followers","following_url":"https://api.github.com/users/ashahi1/following{/other_user}","gists_url":"https://api.github.com/users/ashahi1/gists{/gist_id}","starred_url":"https://api.github.com/users/ashahi1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashahi1/subscriptions","organizations_url":"https://api.github.com/users/ashahi1/orgs","repos_url":"https://api.github.com/users/ashahi1/repos","events_url":"https://api.github.com/users/ashahi1/events{/privacy}","received_events_url":"https://api.github.com/users/ashahi1/received_events","type":"User","site_admin":false},"assignees":[{"login":"ashahi1","id":23107823,"avatar_url":"https://avatars2.githubusercontent.com/u/23107823?v=3","gravatar_id":"","url":"https://api.github.com/users/ashahi1","html_url":"https://github.com/ashahi1","followers_url":"https://api.github.com/users/ashahi1/followers","following_url":"https://api.github.com/users/ashahi1/following{/other_user}","gists_url":"https://api.github.com/users/ashahi1/gists{/gist_id}","starred_url":"https://api.github.com/users/ashahi1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashahi1/subscriptions","organizations_url":"https://api.github.com/users/ashahi1/orgs","repos_url":"https://api.github.com/users/ashahi1/repos","events_url":"https://api.github.com/users/ashahi1/events{/privacy}","received_events_url":"https://api.github.com/users/ashahi1/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"shuklanirdesh82","id":22988730,"avatar_url":"https://avatars2.githubusercontent.com/u/22988730?v=3","gravatar_id":"","url":"https://api.github.com/users/shuklanirdesh82","html_url":"https://github.com/shuklanirdesh82","followers_url":"https://api.github.com/users/shuklanirdesh82/followers","following_url":"https://api.github.com/users/shuklanirdesh82/following{/other_user}","gists_url":"https://api.github.com/users/shuklanirdesh82/gists{/gist_id}","starred_url":"https://api.github.com/users/shuklanirdesh82/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shuklanirdesh82/subscriptions","organizations_url":"https://api.github.com/users/shuklanirdesh82/orgs","repos_url":"https://api.github.com/users/shuklanirdesh82/repos","events_url":"https://api.github.com/users/shuklanirdesh82/events{/privacy}","received_events_url":"https://api.github.com/users/shuklanirdesh82/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/pulls/1426/commits","review_comments_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/pulls/1426/comments","review_comment_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/issues/1426/comments","statuses_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/statuses/5fb1a97b11e4f4567bc476b7d135001c1b972ee8","head":{"label":"ashahi1:mergeEsxAndGovcFiles.ashahi1","ref":"mergeEsxAndGovcFiles.ashahi1","sha":"5fb1a97b11e4f4567bc476b7d135001c1b972ee8","user":{"login":"ashahi1","id":23107823,"avatar_url":"https://avatars2.githubusercontent.com/u/23107823?v=3","gravatar_id":"","url":"https://api.github.com/users/ashahi1","html_url":"https://github.com/ashahi1","followers_url":"https://api.github.com/users/ashahi1/followers","following_url":"https://api.github.com/users/ashahi1/following{/other_user}","gists_url":"https://api.github.com/users/ashahi1/gists{/gist_id}","starred_url":"https://api.github.com/users/ashahi1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashahi1/subscriptions","organizations_url":"https://api.github.com/users/ashahi1/orgs","repos_url":"https://api.github.com/users/ashahi1/repos","events_url":"https://api.github.com/users/ashahi1/events{/privacy}","received_events_url":"https://api.github.com/users/ashahi1/received_events","type":"User","site_admin":false},"repo":{"id":72147782,"name":"docker-volume-vsphere","full_name":"ashahi1/docker-volume-vsphere","owner":{"login":"ashahi1","id":23107823,"avatar_url":"https://avatars2.githubusercontent.com/u/23107823?v=3","gravatar_id":"","url":"https://api.github.com/users/ashahi1","html_url":"https://github.com/ashahi1","followers_url":"https://api.github.com/users/ashahi1/followers","following_url":"https://api.github.com/users/ashahi1/following{/other_user}","gists_url":"https://api.github.com/users/ashahi1/gists{/gist_id}","starred_url":"https://api.github.com/users/ashahi1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashahi1/subscriptions","organizations_url":"https://api.github.com/users/ashahi1/orgs","repos_url":"https://api.github.com/users/ashahi1/repos","events_url":"https://api.github.com/users/ashahi1/events{/privacy}","received_events_url":"https://api.github.com/users/ashahi1/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ashahi1/docker-volume-vsphere","description":"Docker Volume Driver for vSphere.","fork":true,"url":"https://api.github.com/repos/ashahi1/docker-volume-vsphere","forks_url":"https://api.github.com/repos/ashahi1/docker-volume-vsphere/forks","keys_url":"https://api.github.com/repos/ashahi1/docker-volume-vsphere/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ashahi1/docker-volume-vsphere/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ashahi1/docker-volume-vsphere/teams","hooks_url":"https://api.github.com/repos/ashahi1/docker-volume-vsphere/hooks","issue_events_url":"https://api.github.com/repos/ashahi1/docker-volume-vsphere/issues/events{/number}","events_url":"https://api.github.com/repos/ashahi1/docker-volume-vsphere/events","assignees_url":"https://api.github.com/repos/ashahi1/docker-volume-vsphere/assignees{/user}","branches_url":"https://api.github.com/repos/ashahi1/docker-volume-vsphere/branches{/branch}","tags_url":"https://api.github.com/repos/ashahi1/docker-volume-vsphere/tags","blobs_url":"https://api.github.com/repos/ashahi1/docker-volume-vsphere/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ashahi1/docker-volume-vsphere/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ashahi1/docker-volume-vsphere/git/refs{/sha}","trees_url":"https://api.github.com/repos/ashahi1/docker-volume-vsphere/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ashahi1/docker-volume-vsphere/statuses/{sha}","languages_url":"https://api.github.com/repos/ashahi1/docker-volume-vsphere/languages","stargazers_url":"https://api.github.com/repos/ashahi1/docker-volume-vsphere/stargazers","contributors_url":"https://api.github.com/repos/ashahi1/docker-volume-vsphere/contributors","subscribers_url":"https://api.github.com/repos/ashahi1/docker-volume-vsphere/subscribers","subscription_url":"https://api.github.com/repos/ashahi1/docker-volume-vsphere/subscription","commits_url":"https://api.github.com/repos/ashahi1/docker-volume-vsphere/commits{/sha}","git_commits_url":"https://api.github.com/repos/ashahi1/docker-volume-vsphere/git/commits{/sha}","comments_url":"https://api.github.com/repos/ashahi1/docker-volume-vsphere/comments{/number}","issue_comment_url":"https://api.github.com/repos/ashahi1/docker-volume-vsphere/issues/comments{/number}","contents_url":"https://api.github.com/repos/ashahi1/docker-volume-vsphere/contents/{+path}","compare_url":"https://api.github.com/repos/ashahi1/docker-volume-vsphere/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ashahi1/docker-volume-vsphere/merges","archive_url":"https://api.github.com/repos/ashahi1/docker-volume-vsphere/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ashahi1/docker-volume-vsphere/downloads","issues_url":"https://api.github.com/repos/ashahi1/docker-volume-vsphere/issues{/number}","pulls_url":"https://api.github.com/repos/ashahi1/docker-volume-vsphere/pulls{/number}","milestones_url":"https://api.github.com/repos/ashahi1/docker-volume-vsphere/milestones{/number}","notifications_url":"https://api.github.com/repos/ashahi1/docker-volume-vsphere/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ashahi1/docker-volume-vsphere/labels{/name}","releases_url":"https://api.github.com/repos/ashahi1/docker-volume-vsphere/releases{/id}","deployments_url":"https://api.github.com/repos/ashahi1/docker-volume-vsphere/deployments","created_at":"2016-10-27T20:57:55Z","updated_at":"2016-10-27T20:57:56Z","pushed_at":"2017-06-15T04:05:11Z","git_url":"git://github.com/ashahi1/docker-volume-vsphere.git","ssh_url":"git@github.com:ashahi1/docker-volume-vsphere.git","clone_url":"https://github.com/ashahi1/docker-volume-vsphere.git","svn_url":"https://github.com/ashahi1/docker-volume-vsphere","homepage":"https://vmware.github.io/docker-volume-vsphere","size":8931,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"vmware:master","ref":"master","sha":"a0f002c9a7220e5f25367bb0c4a531e7a748d802","user":{"login":"vmware","id":473334,"avatar_url":"https://avatars3.githubusercontent.com/u/473334?v=3","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"repo":{"id":49599693,"name":"docker-volume-vsphere","full_name":"vmware/docker-volume-vsphere","owner":{"login":"vmware","id":473334,"avatar_url":"https://avatars3.githubusercontent.com/u/473334?v=3","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vmware/docker-volume-vsphere","description":"vSphere Docker Volume Service","fork":false,"url":"https://api.github.com/repos/vmware/docker-volume-vsphere","forks_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/forks","keys_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/teams","hooks_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/hooks","issue_events_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/issues/events{/number}","events_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/events","assignees_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/assignees{/user}","branches_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/branches{/branch}","tags_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/tags","blobs_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/git/refs{/sha}","trees_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/statuses/{sha}","languages_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/languages","stargazers_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/stargazers","contributors_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/contributors","subscribers_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/subscribers","subscription_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/subscription","commits_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/commits{/sha}","git_commits_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/git/commits{/sha}","comments_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/comments{/number}","issue_comment_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/issues/comments{/number}","contents_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/contents/{+path}","compare_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/merges","archive_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/downloads","issues_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/issues{/number}","pulls_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/pulls{/number}","milestones_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/milestones{/number}","notifications_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/labels{/name}","releases_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/releases{/id}","deployments_url":"https://api.github.com/repos/vmware/docker-volume-vsphere/deployments","created_at":"2016-01-13T20:25:36Z","updated_at":"2017-06-14T04:06:19Z","pushed_at":"2017-06-15T10:12:58Z","git_url":"git://github.com/vmware/docker-volume-vsphere.git","ssh_url":"git@github.com:vmware/docker-volume-vsphere.git","clone_url":"https://github.com/vmware/docker-volume-vsphere.git","svn_url":"https://github.com/vmware/docker-volume-vsphere","homepage":"https://vmware.github.io/docker-volume-vsphere","size":17172,"stargazers_count":138,"watchers_count":138,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":41,"mirror_url":null,"open_issues_count":188,"forks":41,"open_issues":188,"watchers":138,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vmware/docker-volume-vsphere/pulls/1426"},"html":{"href":"https://github.com/vmware/docker-volume-vsphere/pull/1426"},"issue":{"href":"https://api.github.com/repos/vmware/docker-volume-vsphere/issues/1426"},"comments":{"href":"https://api.github.com/repos/vmware/docker-volume-vsphere/issues/1426/comments"},"review_comments":{"href":"https://api.github.com/repos/vmware/docker-volume-vsphere/pulls/1426/comments"},"review_comment":{"href":"https://api.github.com/repos/vmware/docker-volume-vsphere/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vmware/docker-volume-vsphere/pulls/1426/commits"},"statuses":{"href":"https://api.github.com/repos/vmware/docker-volume-vsphere/statuses/5fb1a97b11e4f4567bc476b7d135001c1b972ee8"}}}}
{"actor":{"display_login":"govint"}}