{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/http2/pulls/comments/116491660","pull_request_review_id":38116683,"id":116491660,"diff_hunk":"@@ -386,7 +386,10 @@ class Http2ServerResponse extends Stream {\n     this.writeHead(statusCode);\n   }\n \n-  writeHead(statusCode, headers) {\n+  writeHead(statusCode, statusMessage, headers) {\n+    if (headers === undefined && typeof statusMessage === 'object') {\n+      headers = statusMessage;\n+    }","path":"lib/internal/http2/compat.js","position":null,"original_position":8,"commit_id":"33b88ae34fb0dfa3446fb429b4f20eb9e6a204a0","original_commit_id":"89ecb508bd007360272d0022f980b93a9dbf2f59","user":{"login":"sebdeckers","id":78718,"avatar_url":"https://avatars3.githubusercontent.com/u/78718?v=3","gravatar_id":"","url":"https://api.github.com/users/sebdeckers","html_url":"https://github.com/sebdeckers","followers_url":"https://api.github.com/users/sebdeckers/followers","following_url":"https://api.github.com/users/sebdeckers/following{/other_user}","gists_url":"https://api.github.com/users/sebdeckers/gists{/gist_id}","starred_url":"https://api.github.com/users/sebdeckers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebdeckers/subscriptions","organizations_url":"https://api.github.com/users/sebdeckers/orgs","repos_url":"https://api.github.com/users/sebdeckers/repos","events_url":"https://api.github.com/users/sebdeckers/events{/privacy}","received_events_url":"https://api.github.com/users/sebdeckers/received_events","type":"User","site_admin":false},"body":"Okay, updated. ✍️ (Feel free to rewrite the message. Not sure how verbose these comments ought to be.)","created_at":"2017-05-15T13:36:14Z","updated_at":"2017-05-15T13:36:14Z","html_url":"https://github.com/nodejs/http2/pull/112#discussion_r116491660","pull_request_url":"https://api.github.com/repos/nodejs/http2/pulls/112","_links":{"self":{"href":"https://api.github.com/repos/nodejs/http2/pulls/comments/116491660"},"html":{"href":"https://github.com/nodejs/http2/pull/112#discussion_r116491660"},"pull_request":{"href":"https://api.github.com/repos/nodejs/http2/pulls/112"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/http2/pulls/112","id":120545014,"html_url":"https://github.com/nodejs/http2/pull/112","diff_url":"https://github.com/nodejs/http2/pull/112.diff","patch_url":"https://github.com/nodejs/http2/pull/112.patch","issue_url":"https://api.github.com/repos/nodejs/http2/issues/112","number":112,"state":"open","locked":false,"title":"http2: writeHead optional statusMessage","user":{"login":"sebdeckers","id":78718,"avatar_url":"https://avatars3.githubusercontent.com/u/78718?v=3","gravatar_id":"","url":"https://api.github.com/users/sebdeckers","html_url":"https://github.com/sebdeckers","followers_url":"https://api.github.com/users/sebdeckers/followers","following_url":"https://api.github.com/users/sebdeckers/following{/other_user}","gists_url":"https://api.github.com/users/sebdeckers/gists{/gist_id}","starred_url":"https://api.github.com/users/sebdeckers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebdeckers/subscriptions","organizations_url":"https://api.github.com/users/sebdeckers/orgs","repos_url":"https://api.github.com/users/sebdeckers/repos","events_url":"https://api.github.com/users/sebdeckers/events{/privacy}","received_events_url":"https://api.github.com/users/sebdeckers/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\nAdds backwards compatible support for the optional `statusMessage` argument to [`response.writeHead`](https://nodejs.org/api/http.html#http_response_writehead_statuscode_statusmessage_headers).\r\n\r\nThe status message is [not used in HTTP/2](http://httpwg.org/specs/rfc7540.html#HttpResponse). This optional argument is only exposed to stay synched with the `require('http')` API.\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [ ] documentation is changed or added\r\n- [ ] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-guidelines)\r\n\r\n##### Affected core subsystem(s)\r\n<!-- Provide affected core subsystem(s) (like doc, cluster, crypto, etc). -->\r\n\r\nhttp2","created_at":"2017-05-15T08:07:52Z","updated_at":"2017-05-15T13:36:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7760c2b1a29d04644cc1b5d4cb87928852f23cdc","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/http2/pulls/112/commits","review_comments_url":"https://api.github.com/repos/nodejs/http2/pulls/112/comments","review_comment_url":"https://api.github.com/repos/nodejs/http2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/http2/issues/112/comments","statuses_url":"https://api.github.com/repos/nodejs/http2/statuses/33b88ae34fb0dfa3446fb429b4f20eb9e6a204a0","head":{"label":"sebdeckers:writehead-statusmessage","ref":"writehead-statusmessage","sha":"33b88ae34fb0dfa3446fb429b4f20eb9e6a204a0","user":{"login":"sebdeckers","id":78718,"avatar_url":"https://avatars3.githubusercontent.com/u/78718?v=3","gravatar_id":"","url":"https://api.github.com/users/sebdeckers","html_url":"https://github.com/sebdeckers","followers_url":"https://api.github.com/users/sebdeckers/followers","following_url":"https://api.github.com/users/sebdeckers/following{/other_user}","gists_url":"https://api.github.com/users/sebdeckers/gists{/gist_id}","starred_url":"https://api.github.com/users/sebdeckers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebdeckers/subscriptions","organizations_url":"https://api.github.com/users/sebdeckers/orgs","repos_url":"https://api.github.com/users/sebdeckers/repos","events_url":"https://api.github.com/users/sebdeckers/events{/privacy}","received_events_url":"https://api.github.com/users/sebdeckers/received_events","type":"User","site_admin":false},"repo":{"id":75345547,"name":"http2","full_name":"sebdeckers/http2","owner":{"login":"sebdeckers","id":78718,"avatar_url":"https://avatars3.githubusercontent.com/u/78718?v=3","gravatar_id":"","url":"https://api.github.com/users/sebdeckers","html_url":"https://github.com/sebdeckers","followers_url":"https://api.github.com/users/sebdeckers/followers","following_url":"https://api.github.com/users/sebdeckers/following{/other_user}","gists_url":"https://api.github.com/users/sebdeckers/gists{/gist_id}","starred_url":"https://api.github.com/users/sebdeckers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebdeckers/subscriptions","organizations_url":"https://api.github.com/users/sebdeckers/orgs","repos_url":"https://api.github.com/users/sebdeckers/repos","events_url":"https://api.github.com/users/sebdeckers/events{/privacy}","received_events_url":"https://api.github.com/users/sebdeckers/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sebdeckers/http2","description":"Working on an HTTP/2 implementation for Node.js Core","fork":true,"url":"https://api.github.com/repos/sebdeckers/http2","forks_url":"https://api.github.com/repos/sebdeckers/http2/forks","keys_url":"https://api.github.com/repos/sebdeckers/http2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sebdeckers/http2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sebdeckers/http2/teams","hooks_url":"https://api.github.com/repos/sebdeckers/http2/hooks","issue_events_url":"https://api.github.com/repos/sebdeckers/http2/issues/events{/number}","events_url":"https://api.github.com/repos/sebdeckers/http2/events","assignees_url":"https://api.github.com/repos/sebdeckers/http2/assignees{/user}","branches_url":"https://api.github.com/repos/sebdeckers/http2/branches{/branch}","tags_url":"https://api.github.com/repos/sebdeckers/http2/tags","blobs_url":"https://api.github.com/repos/sebdeckers/http2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sebdeckers/http2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sebdeckers/http2/git/refs{/sha}","trees_url":"https://api.github.com/repos/sebdeckers/http2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sebdeckers/http2/statuses/{sha}","languages_url":"https://api.github.com/repos/sebdeckers/http2/languages","stargazers_url":"https://api.github.com/repos/sebdeckers/http2/stargazers","contributors_url":"https://api.github.com/repos/sebdeckers/http2/contributors","subscribers_url":"https://api.github.com/repos/sebdeckers/http2/subscribers","subscription_url":"https://api.github.com/repos/sebdeckers/http2/subscription","commits_url":"https://api.github.com/repos/sebdeckers/http2/commits{/sha}","git_commits_url":"https://api.github.com/repos/sebdeckers/http2/git/commits{/sha}","comments_url":"https://api.github.com/repos/sebdeckers/http2/comments{/number}","issue_comment_url":"https://api.github.com/repos/sebdeckers/http2/issues/comments{/number}","contents_url":"https://api.github.com/repos/sebdeckers/http2/contents/{+path}","compare_url":"https://api.github.com/repos/sebdeckers/http2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sebdeckers/http2/merges","archive_url":"https://api.github.com/repos/sebdeckers/http2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sebdeckers/http2/downloads","issues_url":"https://api.github.com/repos/sebdeckers/http2/issues{/number}","pulls_url":"https://api.github.com/repos/sebdeckers/http2/pulls{/number}","milestones_url":"https://api.github.com/repos/sebdeckers/http2/milestones{/number}","notifications_url":"https://api.github.com/repos/sebdeckers/http2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sebdeckers/http2/labels{/name}","releases_url":"https://api.github.com/repos/sebdeckers/http2/releases{/id}","deployments_url":"https://api.github.com/repos/sebdeckers/http2/deployments","created_at":"2016-12-02T00:39:05Z","updated_at":"2016-12-02T00:39:11Z","pushed_at":"2017-05-15T13:34:30Z","git_url":"git://github.com/sebdeckers/http2.git","ssh_url":"git@github.com:sebdeckers/http2.git","clone_url":"https://github.com/sebdeckers/http2.git","svn_url":"https://github.com/sebdeckers/http2","homepage":null,"size":189094,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"de9241f26777d7b4df464f2a5dbe9e906f45bcd9","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars0.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":65843742,"name":"http2","full_name":"nodejs/http2","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars0.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/http2","description":"Working on an HTTP/2 implementation for Node.js Core","fork":false,"url":"https://api.github.com/repos/nodejs/http2","forks_url":"https://api.github.com/repos/nodejs/http2/forks","keys_url":"https://api.github.com/repos/nodejs/http2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/http2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/http2/teams","hooks_url":"https://api.github.com/repos/nodejs/http2/hooks","issue_events_url":"https://api.github.com/repos/nodejs/http2/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/http2/events","assignees_url":"https://api.github.com/repos/nodejs/http2/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/http2/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/http2/tags","blobs_url":"https://api.github.com/repos/nodejs/http2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/http2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/http2/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/http2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/http2/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/http2/languages","stargazers_url":"https://api.github.com/repos/nodejs/http2/stargazers","contributors_url":"https://api.github.com/repos/nodejs/http2/contributors","subscribers_url":"https://api.github.com/repos/nodejs/http2/subscribers","subscription_url":"https://api.github.com/repos/nodejs/http2/subscription","commits_url":"https://api.github.com/repos/nodejs/http2/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/http2/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/http2/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/http2/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/http2/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/http2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/http2/merges","archive_url":"https://api.github.com/repos/nodejs/http2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/http2/downloads","issues_url":"https://api.github.com/repos/nodejs/http2/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/http2/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/http2/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/http2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/http2/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/http2/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/http2/deployments","created_at":"2016-08-16T18:23:26Z","updated_at":"2017-05-15T03:26:06Z","pushed_at":"2017-05-15T13:34:31Z","git_url":"git://github.com/nodejs/http2.git","ssh_url":"git@github.com:nodejs/http2.git","clone_url":"https://github.com/nodejs/http2.git","svn_url":"https://github.com/nodejs/http2","homepage":null,"size":189138,"stargazers_count":385,"watchers_count":385,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":36,"mirror_url":null,"open_issues_count":23,"forks":36,"open_issues":23,"watchers":385,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/http2/pulls/112"},"html":{"href":"https://github.com/nodejs/http2/pull/112"},"issue":{"href":"https://api.github.com/repos/nodejs/http2/issues/112"},"comments":{"href":"https://api.github.com/repos/nodejs/http2/issues/112/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/http2/pulls/112/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/http2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/http2/pulls/112/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/http2/statuses/33b88ae34fb0dfa3446fb429b4f20eb9e6a204a0"}}}}
{"actor":{"display_login":"sebdeckers"}}