{"action":"created","comment":{"url":"https://api.github.com/repos/snapcore/snapd/pulls/comments/155841393","pull_request_review_id":82233405,"id":155841393,"diff_hunk":"@@ -19,32 +19,160 @@\n \n package builtin\n \n+import (\n+\t\"strings\"\n+\n+\t\"github.com/snapcore/snapd/interfaces\"\n+\t\"github.com/snapcore/snapd/interfaces/apparmor\"\n+\t\"github.com/snapcore/snapd/interfaces/seccomp\"\n+\t\"github.com/snapcore/snapd/interfaces/udev\"\n+\t\"github.com/snapcore/snapd/release\"\n+\t\"github.com/snapcore/snapd/snap\"\n+)\n+\n const waylandSummary = `allows access to compositors supporting wayland protocol`\n \n const waylandBaseDeclarationSlots = `\n   wayland:\n     allow-installation:\n       slot-snap-type:\n+        - app\n         - core\n+    deny-auto-connection: true\n+    deny-connection:\n+      on-classic: false\n+`\n+\n+const waylandPermanentSlotAppArmor = `\n+# Description: Allow operating as a Wayland display server. This gives privileged access\n+# to the system.\n+\n+# needed since Wayland is the display server, to configure tty devices\n+capability sys_tty_config,\n+/dev/tty[0-9]* rw,\n+\n+/{dev,run}/shm/\\#* mrw,","path":"interfaces/builtin/wayland.go","position":null,"original_position":36,"commit_id":"160417f27419c686ed2b5650a1c6370e8dbb8b40","original_commit_id":"b9b7c383dc9a31933681acce86872f1a1dc52d70","user":{"login":"jdstrand","id":1663079,"avatar_url":"https://avatars0.githubusercontent.com/u/1663079?v=4","gravatar_id":"","url":"https://api.github.com/users/jdstrand","html_url":"https://github.com/jdstrand","followers_url":"https://api.github.com/users/jdstrand/followers","following_url":"https://api.github.com/users/jdstrand/following{/other_user}","gists_url":"https://api.github.com/users/jdstrand/gists{/gist_id}","starred_url":"https://api.github.com/users/jdstrand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdstrand/subscriptions","organizations_url":"https://api.github.com/users/jdstrand/orgs","repos_url":"https://api.github.com/users/jdstrand/repos","events_url":"https://api.github.com/users/jdstrand/events{/privacy}","received_events_url":"https://api.github.com/users/jdstrand/received_events","type":"User","site_admin":false},"body":"Right, was only talking about the shm access.","created_at":"2017-12-08T18:22:55Z","updated_at":"2017-12-08T18:22:55Z","html_url":"https://github.com/snapcore/snapd/pull/4365#discussion_r155841393","pull_request_url":"https://api.github.com/repos/snapcore/snapd/pulls/4365","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/comments/155841393"},"html":{"href":"https://github.com/snapcore/snapd/pull/4365#discussion_r155841393"},"pull_request":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/4365"}},"in_reply_to_id":155542813},"pull_request":{"url":"https://api.github.com/repos/snapcore/snapd/pulls/4365","id":156767013,"html_url":"https://github.com/snapcore/snapd/pull/4365","diff_url":"https://github.com/snapcore/snapd/pull/4365.diff","patch_url":"https://github.com/snapcore/snapd/pull/4365.patch","issue_url":"https://api.github.com/repos/snapcore/snapd/issues/4365","number":4365,"state":"open","locked":false,"title":"interfaces/mir: allow Wayland socket and non-root sockets","user":{"login":"gerboland","id":632769,"avatar_url":"https://avatars2.githubusercontent.com/u/632769?v=4","gravatar_id":"","url":"https://api.github.com/users/gerboland","html_url":"https://github.com/gerboland","followers_url":"https://api.github.com/users/gerboland/followers","following_url":"https://api.github.com/users/gerboland/following{/other_user}","gists_url":"https://api.github.com/users/gerboland/gists{/gist_id}","starred_url":"https://api.github.com/users/gerboland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gerboland/subscriptions","organizations_url":"https://api.github.com/users/gerboland/orgs","repos_url":"https://api.github.com/users/gerboland/repos","events_url":"https://api.github.com/users/gerboland/events{/privacy}","received_events_url":"https://api.github.com/users/gerboland/received_events","type":"User","site_admin":false},"body":"Mir 0.28 and greater implements the Wayland protocol, and needs to create its socket. \r\n\r\nMir running as non-root will create those sockets in $XDG_RUNTIME_DIR which is typically /run/users/*, so allow that too.","created_at":"2017-12-06T15:55:35Z","updated_at":"2017-12-08T18:22:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7111430a0eb00230c9431bc4b4c88ce4126bae33","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/snapcore/snapd/pulls/4365/commits","review_comments_url":"https://api.github.com/repos/snapcore/snapd/pulls/4365/comments","review_comment_url":"https://api.github.com/repos/snapcore/snapd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/snapcore/snapd/issues/4365/comments","statuses_url":"https://api.github.com/repos/snapcore/snapd/statuses/160417f27419c686ed2b5650a1c6370e8dbb8b40","head":{"label":"gerboland:mir-add-wayland-socket","ref":"mir-add-wayland-socket","sha":"160417f27419c686ed2b5650a1c6370e8dbb8b40","user":{"login":"gerboland","id":632769,"avatar_url":"https://avatars2.githubusercontent.com/u/632769?v=4","gravatar_id":"","url":"https://api.github.com/users/gerboland","html_url":"https://github.com/gerboland","followers_url":"https://api.github.com/users/gerboland/followers","following_url":"https://api.github.com/users/gerboland/following{/other_user}","gists_url":"https://api.github.com/users/gerboland/gists{/gist_id}","starred_url":"https://api.github.com/users/gerboland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gerboland/subscriptions","organizations_url":"https://api.github.com/users/gerboland/orgs","repos_url":"https://api.github.com/users/gerboland/repos","events_url":"https://api.github.com/users/gerboland/events{/privacy}","received_events_url":"https://api.github.com/users/gerboland/received_events","type":"User","site_admin":false},"repo":{"id":113334715,"name":"snapd","full_name":"gerboland/snapd","owner":{"login":"gerboland","id":632769,"avatar_url":"https://avatars2.githubusercontent.com/u/632769?v=4","gravatar_id":"","url":"https://api.github.com/users/gerboland","html_url":"https://github.com/gerboland","followers_url":"https://api.github.com/users/gerboland/followers","following_url":"https://api.github.com/users/gerboland/following{/other_user}","gists_url":"https://api.github.com/users/gerboland/gists{/gist_id}","starred_url":"https://api.github.com/users/gerboland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gerboland/subscriptions","organizations_url":"https://api.github.com/users/gerboland/orgs","repos_url":"https://api.github.com/users/gerboland/repos","events_url":"https://api.github.com/users/gerboland/events{/privacy}","received_events_url":"https://api.github.com/users/gerboland/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gerboland/snapd","description":"The snapd and snap tools enable systems to work with .snap files.","fork":true,"url":"https://api.github.com/repos/gerboland/snapd","forks_url":"https://api.github.com/repos/gerboland/snapd/forks","keys_url":"https://api.github.com/repos/gerboland/snapd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gerboland/snapd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gerboland/snapd/teams","hooks_url":"https://api.github.com/repos/gerboland/snapd/hooks","issue_events_url":"https://api.github.com/repos/gerboland/snapd/issues/events{/number}","events_url":"https://api.github.com/repos/gerboland/snapd/events","assignees_url":"https://api.github.com/repos/gerboland/snapd/assignees{/user}","branches_url":"https://api.github.com/repos/gerboland/snapd/branches{/branch}","tags_url":"https://api.github.com/repos/gerboland/snapd/tags","blobs_url":"https://api.github.com/repos/gerboland/snapd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gerboland/snapd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gerboland/snapd/git/refs{/sha}","trees_url":"https://api.github.com/repos/gerboland/snapd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gerboland/snapd/statuses/{sha}","languages_url":"https://api.github.com/repos/gerboland/snapd/languages","stargazers_url":"https://api.github.com/repos/gerboland/snapd/stargazers","contributors_url":"https://api.github.com/repos/gerboland/snapd/contributors","subscribers_url":"https://api.github.com/repos/gerboland/snapd/subscribers","subscription_url":"https://api.github.com/repos/gerboland/snapd/subscription","commits_url":"https://api.github.com/repos/gerboland/snapd/commits{/sha}","git_commits_url":"https://api.github.com/repos/gerboland/snapd/git/commits{/sha}","comments_url":"https://api.github.com/repos/gerboland/snapd/comments{/number}","issue_comment_url":"https://api.github.com/repos/gerboland/snapd/issues/comments{/number}","contents_url":"https://api.github.com/repos/gerboland/snapd/contents/{+path}","compare_url":"https://api.github.com/repos/gerboland/snapd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gerboland/snapd/merges","archive_url":"https://api.github.com/repos/gerboland/snapd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gerboland/snapd/downloads","issues_url":"https://api.github.com/repos/gerboland/snapd/issues{/number}","pulls_url":"https://api.github.com/repos/gerboland/snapd/pulls{/number}","milestones_url":"https://api.github.com/repos/gerboland/snapd/milestones{/number}","notifications_url":"https://api.github.com/repos/gerboland/snapd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gerboland/snapd/labels{/name}","releases_url":"https://api.github.com/repos/gerboland/snapd/releases{/id}","deployments_url":"https://api.github.com/repos/gerboland/snapd/deployments","created_at":"2017-12-06T15:39:53Z","updated_at":"2017-12-06T15:39:59Z","pushed_at":"2017-12-08T18:14:41Z","git_url":"git://github.com/gerboland/snapd.git","ssh_url":"git@github.com:gerboland/snapd.git","clone_url":"https://github.com/gerboland/snapd.git","svn_url":"https://github.com/gerboland/snapd","homepage":"","size":56395,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"snapcore:master","ref":"master","sha":"e50b4afebb83eee409dc2254290b8ef1eeaa394b","user":{"login":"snapcore","id":19532717,"avatar_url":"https://avatars1.githubusercontent.com/u/19532717?v=4","gravatar_id":"","url":"https://api.github.com/users/snapcore","html_url":"https://github.com/snapcore","followers_url":"https://api.github.com/users/snapcore/followers","following_url":"https://api.github.com/users/snapcore/following{/other_user}","gists_url":"https://api.github.com/users/snapcore/gists{/gist_id}","starred_url":"https://api.github.com/users/snapcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snapcore/subscriptions","organizations_url":"https://api.github.com/users/snapcore/orgs","repos_url":"https://api.github.com/users/snapcore/repos","events_url":"https://api.github.com/users/snapcore/events{/privacy}","received_events_url":"https://api.github.com/users/snapcore/received_events","type":"Organization","site_admin":false},"repo":{"id":44672744,"name":"snapd","full_name":"snapcore/snapd","owner":{"login":"snapcore","id":19532717,"avatar_url":"https://avatars1.githubusercontent.com/u/19532717?v=4","gravatar_id":"","url":"https://api.github.com/users/snapcore","html_url":"https://github.com/snapcore","followers_url":"https://api.github.com/users/snapcore/followers","following_url":"https://api.github.com/users/snapcore/following{/other_user}","gists_url":"https://api.github.com/users/snapcore/gists{/gist_id}","starred_url":"https://api.github.com/users/snapcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snapcore/subscriptions","organizations_url":"https://api.github.com/users/snapcore/orgs","repos_url":"https://api.github.com/users/snapcore/repos","events_url":"https://api.github.com/users/snapcore/events{/privacy}","received_events_url":"https://api.github.com/users/snapcore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/snapcore/snapd","description":"The snapd and snap tools enable systems to work with .snap files.","fork":false,"url":"https://api.github.com/repos/snapcore/snapd","forks_url":"https://api.github.com/repos/snapcore/snapd/forks","keys_url":"https://api.github.com/repos/snapcore/snapd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/snapcore/snapd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/snapcore/snapd/teams","hooks_url":"https://api.github.com/repos/snapcore/snapd/hooks","issue_events_url":"https://api.github.com/repos/snapcore/snapd/issues/events{/number}","events_url":"https://api.github.com/repos/snapcore/snapd/events","assignees_url":"https://api.github.com/repos/snapcore/snapd/assignees{/user}","branches_url":"https://api.github.com/repos/snapcore/snapd/branches{/branch}","tags_url":"https://api.github.com/repos/snapcore/snapd/tags","blobs_url":"https://api.github.com/repos/snapcore/snapd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/snapcore/snapd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/snapcore/snapd/git/refs{/sha}","trees_url":"https://api.github.com/repos/snapcore/snapd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/snapcore/snapd/statuses/{sha}","languages_url":"https://api.github.com/repos/snapcore/snapd/languages","stargazers_url":"https://api.github.com/repos/snapcore/snapd/stargazers","contributors_url":"https://api.github.com/repos/snapcore/snapd/contributors","subscribers_url":"https://api.github.com/repos/snapcore/snapd/subscribers","subscription_url":"https://api.github.com/repos/snapcore/snapd/subscription","commits_url":"https://api.github.com/repos/snapcore/snapd/commits{/sha}","git_commits_url":"https://api.github.com/repos/snapcore/snapd/git/commits{/sha}","comments_url":"https://api.github.com/repos/snapcore/snapd/comments{/number}","issue_comment_url":"https://api.github.com/repos/snapcore/snapd/issues/comments{/number}","contents_url":"https://api.github.com/repos/snapcore/snapd/contents/{+path}","compare_url":"https://api.github.com/repos/snapcore/snapd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/snapcore/snapd/merges","archive_url":"https://api.github.com/repos/snapcore/snapd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/snapcore/snapd/downloads","issues_url":"https://api.github.com/repos/snapcore/snapd/issues{/number}","pulls_url":"https://api.github.com/repos/snapcore/snapd/pulls{/number}","milestones_url":"https://api.github.com/repos/snapcore/snapd/milestones{/number}","notifications_url":"https://api.github.com/repos/snapcore/snapd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/snapcore/snapd/labels{/name}","releases_url":"https://api.github.com/repos/snapcore/snapd/releases{/id}","deployments_url":"https://api.github.com/repos/snapcore/snapd/deployments","created_at":"2015-10-21T11:51:46Z","updated_at":"2017-12-08T07:40:54Z","pushed_at":"2017-12-08T18:14:42Z","git_url":"git://github.com/snapcore/snapd.git","ssh_url":"git@github.com:snapcore/snapd.git","clone_url":"https://github.com/snapcore/snapd.git","svn_url":"https://github.com/snapcore/snapd","homepage":"","size":56534,"stargazers_count":833,"watchers_count":833,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":204,"mirror_url":null,"archived":false,"open_issues_count":38,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":204,"open_issues":38,"watchers":833,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/4365"},"html":{"href":"https://github.com/snapcore/snapd/pull/4365"},"issue":{"href":"https://api.github.com/repos/snapcore/snapd/issues/4365"},"comments":{"href":"https://api.github.com/repos/snapcore/snapd/issues/4365/comments"},"review_comments":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/4365/comments"},"review_comment":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/4365/commits"},"statuses":{"href":"https://api.github.com/repos/snapcore/snapd/statuses/160417f27419c686ed2b5650a1c6370e8dbb8b40"}},"author_association":"NONE"}}
{"actor":{"display_login":"jdstrand"}}