{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/vscode/issues/39893","repository_url":"https://api.github.com/repos/Microsoft/vscode","labels_url":"https://api.github.com/repos/Microsoft/vscode/issues/39893/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/vscode/issues/39893/comments","events_url":"https://api.github.com/repos/Microsoft/vscode/issues/39893/events","html_url":"https://github.com/Microsoft/vscode/issues/39893","id":280273582,"number":39893,"title":"Text changes for completion CodeAction are affected by the completion","user":{"login":"andy-ms","id":19274678,"avatar_url":"https://avatars3.githubusercontent.com/u/19274678?v=4","gravatar_id":"","url":"https://api.github.com/users/andy-ms","html_url":"https://github.com/andy-ms","followers_url":"https://api.github.com/users/andy-ms/followers","following_url":"https://api.github.com/users/andy-ms/following{/other_user}","gists_url":"https://api.github.com/users/andy-ms/gists{/gist_id}","starred_url":"https://api.github.com/users/andy-ms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andy-ms/subscriptions","organizations_url":"https://api.github.com/users/andy-ms/orgs","repos_url":"https://api.github.com/users/andy-ms/repos","events_url":"https://api.github.com/users/andy-ms/events{/privacy}","received_events_url":"https://api.github.com/users/andy-ms/received_events","type":"User","site_admin":false},"labels":[{"id":256129993,"url":"https://api.github.com/repos/Microsoft/vscode/labels/bug","name":"bug","color":"8D6673","default":true},{"id":421907356,"url":"https://api.github.com/repos/Microsoft/vscode/labels/suggest","name":"suggest","color":"c5def5","default":false},{"id":291055694,"url":"https://api.github.com/repos/Microsoft/vscode/labels/typescript","name":"typescript","color":"1d76db","default":false}],"state":"open","locked":false,"assignee":{"login":"jrieken","id":1794099,"avatar_url":"https://avatars2.githubusercontent.com/u/1794099?v=4","gravatar_id":"","url":"https://api.github.com/users/jrieken","html_url":"https://github.com/jrieken","followers_url":"https://api.github.com/users/jrieken/followers","following_url":"https://api.github.com/users/jrieken/following{/other_user}","gists_url":"https://api.github.com/users/jrieken/gists{/gist_id}","starred_url":"https://api.github.com/users/jrieken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrieken/subscriptions","organizations_url":"https://api.github.com/users/jrieken/orgs","repos_url":"https://api.github.com/users/jrieken/repos","events_url":"https://api.github.com/users/jrieken/events{/privacy}","received_events_url":"https://api.github.com/users/jrieken/received_events","type":"User","site_admin":false},"assignees":[{"login":"jrieken","id":1794099,"avatar_url":"https://avatars2.githubusercontent.com/u/1794099?v=4","gravatar_id":"","url":"https://api.github.com/users/jrieken","html_url":"https://github.com/jrieken","followers_url":"https://api.github.com/users/jrieken/followers","following_url":"https://api.github.com/users/jrieken/following{/other_user}","gists_url":"https://api.github.com/users/jrieken/gists{/gist_id}","starred_url":"https://api.github.com/users/jrieken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrieken/subscriptions","organizations_url":"https://api.github.com/users/jrieken/orgs","repos_url":"https://api.github.com/users/jrieken/repos","events_url":"https://api.github.com/users/jrieken/events{/privacy}","received_events_url":"https://api.github.com/users/jrieken/received_events","type":"User","site_admin":false},{"login":"mjbvz","id":12821956,"avatar_url":"https://avatars2.githubusercontent.com/u/12821956?v=4","gravatar_id":"","url":"https://api.github.com/users/mjbvz","html_url":"https://github.com/mjbvz","followers_url":"https://api.github.com/users/mjbvz/followers","following_url":"https://api.github.com/users/mjbvz/following{/other_user}","gists_url":"https://api.github.com/users/mjbvz/gists{/gist_id}","starred_url":"https://api.github.com/users/mjbvz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjbvz/subscriptions","organizations_url":"https://api.github.com/users/mjbvz/orgs","repos_url":"https://api.github.com/users/mjbvz/repos","events_url":"https://api.github.com/users/mjbvz/events{/privacy}","received_events_url":"https://api.github.com/users/mjbvz/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/Microsoft/vscode/milestones/58","html_url":"https://github.com/Microsoft/vscode/milestone/58","labels_url":"https://api.github.com/repos/Microsoft/vscode/milestones/58/labels","id":2932942,"number":58,"title":"December 2017/January 2018","description":"","creator":{"login":"egamma","id":172399,"avatar_url":"https://avatars1.githubusercontent.com/u/172399?v=4","gravatar_id":"","url":"https://api.github.com/users/egamma","html_url":"https://github.com/egamma","followers_url":"https://api.github.com/users/egamma/followers","following_url":"https://api.github.com/users/egamma/following{/other_user}","gists_url":"https://api.github.com/users/egamma/gists{/gist_id}","starred_url":"https://api.github.com/users/egamma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/egamma/subscriptions","organizations_url":"https://api.github.com/users/egamma/orgs","repos_url":"https://api.github.com/users/egamma/repos","events_url":"https://api.github.com/users/egamma/events{/privacy}","received_events_url":"https://api.github.com/users/egamma/received_events","type":"User","site_admin":false},"open_issues":117,"closed_issues":78,"state":"open","created_at":"2017-11-23T09:16:43Z","updated_at":"2017-12-13T00:10:57Z","due_on":"2018-01-31T08:00:00Z","closed_at":null},"comments":3,"created_at":"2017-12-07T20:48:10Z","updated_at":"2017-12-13T00:19:11Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"- VSCode Version: Code - Insiders 1.19.0-insider (cd906f8af43a928b3c1060be820841538052a202, 2017-12-07T06:14:22.977Z)\r\n- OS Version: Linux x64 4.4.0-21-generic\r\n- Extensions: none\r\n---\r\n\r\nSteps to Reproduce:\r\n\r\n1. Create `b.ts` containing:\r\n```ts\r\nexport const foo = 0;\r\nexport const bar = 1;\r\n```\r\n2. Create `a.ts` containing:\r\n```ts\r\n; import { foo } from \"./b\";\r\n```\r\n3. Go to the start of the line, type `ba`, and accept the completion.\r\n4. You get `bar; import { fo, baro } from \"./b\";`\r\n(expected `bar; import { foo, bar } from \"./b\";`)\r\n\r\n@mjbvz We were talking about this at the meeting today."},"comment":{"url":"https://api.github.com/repos/Microsoft/vscode/issues/comments/351239429","html_url":"https://github.com/Microsoft/vscode/issues/39893#issuecomment-351239429","issue_url":"https://api.github.com/repos/Microsoft/vscode/issues/39893","id":351239429,"user":{"login":"mjbvz","id":12821956,"avatar_url":"https://avatars2.githubusercontent.com/u/12821956?v=4","gravatar_id":"","url":"https://api.github.com/users/mjbvz","html_url":"https://github.com/mjbvz","followers_url":"https://api.github.com/users/mjbvz/followers","following_url":"https://api.github.com/users/mjbvz/following{/other_user}","gists_url":"https://api.github.com/users/mjbvz/gists{/gist_id}","starred_url":"https://api.github.com/users/mjbvz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjbvz/subscriptions","organizations_url":"https://api.github.com/users/mjbvz/orgs","repos_url":"https://api.github.com/users/mjbvz/repos","events_url":"https://api.github.com/users/mjbvz/events{/privacy}","received_events_url":"https://api.github.com/users/mjbvz/received_events","type":"User","site_admin":false},"created_at":"2017-12-13T00:19:10Z","updated_at":"2017-12-13T00:19:10Z","author_association":"CONTRIBUTOR","body":"@jrieken Yes as we discussed I tried using the additional text edits for the code change, but this created the wrong undo order.\r\n\r\nHey @andy-ms, can we look into adding something akin to [`vscode's insertText`](https://github.com/Microsoft/vscode/blob/master/src/vs/vscode.d.ts#L2790) to the TypeScript API? This would be a much easier way for us to handle https://github.com/Microsoft/TypeScript/pull/20547 imo."}}
{"actor":{"display_login":"mjbvz"}}