{"action":"created","comment":{"url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/comments/96052870","pull_request_review_id":16629868,"id":96052870,"diff_hunk":"@@ -0,0 +1,112 @@\n+<!--\n+\n+/*\n+** Copyright (c) 2015 The Khronos Group Inc.\n+**\n+** Permission is hereby granted, free of charge, to any person obtaining a\n+** copy of this software and/or associated documentation files (the\n+** \"Materials\"), to deal in the Materials without restriction, including\n+** without limitation the rights to use, copy, modify, merge, publish,\n+** distribute, sublicense, and/or sell copies of the Materials, and to\n+** permit persons to whom the Materials are furnished to do so, subject to\n+** the following conditions:\n+**\n+** The above copyright notice and this permission notice shall be included\n+** in all copies or substantial portions of the Materials.\n+**\n+** THE MATERIALS ARE PROVIDED \"AS IS\", WITHOUT WARRANTY OF ANY KIND,\n+** EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF\n+** MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.\n+** IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY\n+** CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT,\n+** TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE\n+** MATERIALS OR THE USE OR OTHER DEALINGS IN THE MATERIALS.\n+*/\n+\n+-->\n+\n+<!DOCTYPE html>\n+<html>\n+<head>\n+<meta charset=\"utf-8\">\n+<title>WebGL cube map out of order upload test.</title>\n+<link rel=\"stylesheet\" href=\"../../../resources/js-test-style.css\"/>\n+<script src=\"../../../js/js-test-pre.js\"></script>\n+<script src=\"../../../js/webgl-test-utils.js\"></script>\n+<script src=\"../../../js/glsl-conformance-test.js\"></script>\n+</head>\n+<body>\n+<div id=\"description\"></div>\n+<div id=\"console\"></div>\n+<canvas id=\"example\" width=\"64\" height=\"64\">\n+</canvas>\n+<script>\n+\"use strict\";\n+description(\"Test out of order cube map uploads.\");\n+debug(\"Regression test for crbug.com/473739 / Apple Radar 20444072.\");\n+\n+<!-- Thanks to Gregg Tavares for the original report and test case. -->\n+\n+var wtu = WebGLTestUtils;\n+\n+var canvas = document.getElementById(\"example\");\n+canvas.addEventListener('webglcontextlost', contextLost, false);\n+\n+var contextWasLost = false;\n+\n+function contextLost(e) {\n+  e.preventDefault();\n+  contextWasLost = true;\n+  debug(\"***context lost -- should not happen***\");\n+}\n+\n+var dataWidth = 256;\n+var dataHeight = 256;\n+var gl = wtu.create3DContext(canvas);\n+var tex = gl.createTexture();\n+// start with 1x1 pixel cubemap\n+gl.bindTexture(gl.TEXTURE_CUBE_MAP, tex);\n+var color = new Uint8Array([128, 192, 255, 255]);\n+for (var ii = 0; ii < 6; ++ii) {\n+    gl.texImage2D(gl.TEXTURE_CUBE_MAP_POSITIVE_X + ii, 0, gl.RGBA, 1, 1, 0, gl.RGBA, gl.UNSIGNED_BYTE, color);\n+}\n+gl.bindTexture(gl.TEXTURE_CUBE_MAP, tex);\n+gl.generateMipmap(gl.TEXTURE_CUBE_MAP); // there's no need to call this but the code doesn't check the size.\n+\n+var textureData = new Uint8Array(dataWidth * dataHeight * 4);\n+\n+// The first texture has downlaoded","path":"sdk/tests/conformance/textures/misc/cube-map-uploads-out-of-order.html","position":78,"original_position":78,"commit_id":"2a2b421ef24a77712665497dc36567f931ec0c74","original_commit_id":"2a2b421ef24a77712665497dc36567f931ec0c74","user":{"login":"zhenyao","id":2073521,"avatar_url":"https://avatars.githubusercontent.com/u/2073521?v=3","gravatar_id":"","url":"https://api.github.com/users/zhenyao","html_url":"https://github.com/zhenyao","followers_url":"https://api.github.com/users/zhenyao/followers","following_url":"https://api.github.com/users/zhenyao/following{/other_user}","gists_url":"https://api.github.com/users/zhenyao/gists{/gist_id}","starred_url":"https://api.github.com/users/zhenyao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhenyao/subscriptions","organizations_url":"https://api.github.com/users/zhenyao/orgs","repos_url":"https://api.github.com/users/zhenyao/repos","events_url":"https://api.github.com/users/zhenyao/events{/privacy}","received_events_url":"https://api.github.com/users/zhenyao/received_events","type":"User","site_admin":false},"body":"downlaoded -> downloaded","created_at":"2017-01-13T19:05:32Z","updated_at":"2017-01-13T19:10:10Z","html_url":"https://github.com/KhronosGroup/WebGL/pull/2258#discussion_r96052870","pull_request_url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/2258","_links":{"self":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/comments/96052870"},"html":{"href":"https://github.com/KhronosGroup/WebGL/pull/2258#discussion_r96052870"},"pull_request":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/2258"}}},"pull_request":{"url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/2258","id":101373823,"html_url":"https://github.com/KhronosGroup/WebGL/pull/2258","diff_url":"https://github.com/KhronosGroup/WebGL/pull/2258.diff","patch_url":"https://github.com/KhronosGroup/WebGL/pull/2258.patch","issue_url":"https://api.github.com/repos/KhronosGroup/WebGL/issues/2258","number":2258,"state":"open","locked":false,"title":"Start running cube-map-uploads-out-of-order as part of conformance su…","user":{"login":"kenrussell","id":1149904,"avatar_url":"https://avatars.githubusercontent.com/u/1149904?v=3","gravatar_id":"","url":"https://api.github.com/users/kenrussell","html_url":"https://github.com/kenrussell","followers_url":"https://api.github.com/users/kenrussell/followers","following_url":"https://api.github.com/users/kenrussell/following{/other_user}","gists_url":"https://api.github.com/users/kenrussell/gists{/gist_id}","starred_url":"https://api.github.com/users/kenrussell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kenrussell/subscriptions","organizations_url":"https://api.github.com/users/kenrussell/orgs","repos_url":"https://api.github.com/users/kenrussell/repos","events_url":"https://api.github.com/users/kenrussell/events{/privacy}","received_events_url":"https://api.github.com/users/kenrussell/received_events","type":"User","site_admin":false},"body":"…ite.\r\n\r\nIt looks like the underlying driver bug has been fixed, per #932.","created_at":"2017-01-13T01:24:29Z","updated_at":"2017-01-13T19:10:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"13b7a87857f05f3a8df43f78c2afe73835491988","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/2258/commits","review_comments_url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/2258/comments","review_comment_url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KhronosGroup/WebGL/issues/2258/comments","statuses_url":"https://api.github.com/repos/KhronosGroup/WebGL/statuses/2a2b421ef24a77712665497dc36567f931ec0c74","head":{"label":"kenrussell:add-cube-map-out-of-order-upload-test","ref":"add-cube-map-out-of-order-upload-test","sha":"2a2b421ef24a77712665497dc36567f931ec0c74","user":{"login":"kenrussell","id":1149904,"avatar_url":"https://avatars.githubusercontent.com/u/1149904?v=3","gravatar_id":"","url":"https://api.github.com/users/kenrussell","html_url":"https://github.com/kenrussell","followers_url":"https://api.github.com/users/kenrussell/followers","following_url":"https://api.github.com/users/kenrussell/following{/other_user}","gists_url":"https://api.github.com/users/kenrussell/gists{/gist_id}","starred_url":"https://api.github.com/users/kenrussell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kenrussell/subscriptions","organizations_url":"https://api.github.com/users/kenrussell/orgs","repos_url":"https://api.github.com/users/kenrussell/repos","events_url":"https://api.github.com/users/kenrussell/events{/privacy}","received_events_url":"https://api.github.com/users/kenrussell/received_events","type":"User","site_admin":false},"repo":{"id":5265706,"name":"WebGL","full_name":"kenrussell/WebGL","owner":{"login":"kenrussell","id":1149904,"avatar_url":"https://avatars.githubusercontent.com/u/1149904?v=3","gravatar_id":"","url":"https://api.github.com/users/kenrussell","html_url":"https://github.com/kenrussell","followers_url":"https://api.github.com/users/kenrussell/followers","following_url":"https://api.github.com/users/kenrussell/following{/other_user}","gists_url":"https://api.github.com/users/kenrussell/gists{/gist_id}","starred_url":"https://api.github.com/users/kenrussell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kenrussell/subscriptions","organizations_url":"https://api.github.com/users/kenrussell/orgs","repos_url":"https://api.github.com/users/kenrussell/repos","events_url":"https://api.github.com/users/kenrussell/events{/privacy}","received_events_url":"https://api.github.com/users/kenrussell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kenrussell/WebGL","description":"The Official Khronos WebGL Repository","fork":true,"url":"https://api.github.com/repos/kenrussell/WebGL","forks_url":"https://api.github.com/repos/kenrussell/WebGL/forks","keys_url":"https://api.github.com/repos/kenrussell/WebGL/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kenrussell/WebGL/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kenrussell/WebGL/teams","hooks_url":"https://api.github.com/repos/kenrussell/WebGL/hooks","issue_events_url":"https://api.github.com/repos/kenrussell/WebGL/issues/events{/number}","events_url":"https://api.github.com/repos/kenrussell/WebGL/events","assignees_url":"https://api.github.com/repos/kenrussell/WebGL/assignees{/user}","branches_url":"https://api.github.com/repos/kenrussell/WebGL/branches{/branch}","tags_url":"https://api.github.com/repos/kenrussell/WebGL/tags","blobs_url":"https://api.github.com/repos/kenrussell/WebGL/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kenrussell/WebGL/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kenrussell/WebGL/git/refs{/sha}","trees_url":"https://api.github.com/repos/kenrussell/WebGL/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kenrussell/WebGL/statuses/{sha}","languages_url":"https://api.github.com/repos/kenrussell/WebGL/languages","stargazers_url":"https://api.github.com/repos/kenrussell/WebGL/stargazers","contributors_url":"https://api.github.com/repos/kenrussell/WebGL/contributors","subscribers_url":"https://api.github.com/repos/kenrussell/WebGL/subscribers","subscription_url":"https://api.github.com/repos/kenrussell/WebGL/subscription","commits_url":"https://api.github.com/repos/kenrussell/WebGL/commits{/sha}","git_commits_url":"https://api.github.com/repos/kenrussell/WebGL/git/commits{/sha}","comments_url":"https://api.github.com/repos/kenrussell/WebGL/comments{/number}","issue_comment_url":"https://api.github.com/repos/kenrussell/WebGL/issues/comments{/number}","contents_url":"https://api.github.com/repos/kenrussell/WebGL/contents/{+path}","compare_url":"https://api.github.com/repos/kenrussell/WebGL/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kenrussell/WebGL/merges","archive_url":"https://api.github.com/repos/kenrussell/WebGL/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kenrussell/WebGL/downloads","issues_url":"https://api.github.com/repos/kenrussell/WebGL/issues{/number}","pulls_url":"https://api.github.com/repos/kenrussell/WebGL/pulls{/number}","milestones_url":"https://api.github.com/repos/kenrussell/WebGL/milestones{/number}","notifications_url":"https://api.github.com/repos/kenrussell/WebGL/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kenrussell/WebGL/labels{/name}","releases_url":"https://api.github.com/repos/kenrussell/WebGL/releases{/id}","deployments_url":"https://api.github.com/repos/kenrussell/WebGL/deployments","created_at":"2012-08-01T22:34:06Z","updated_at":"2016-10-22T04:17:42Z","pushed_at":"2017-01-13T01:24:21Z","git_url":"git://github.com/kenrussell/WebGL.git","ssh_url":"git@github.com:kenrussell/WebGL.git","clone_url":"https://github.com/kenrussell/WebGL.git","svn_url":"https://github.com/kenrussell/WebGL","homepage":null,"size":29091,"stargazers_count":4,"watchers_count":4,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":4,"default_branch":"master"}},"base":{"label":"KhronosGroup:master","ref":"master","sha":"0f9608c495b3010e177f428a70f981348f2fbf52","user":{"login":"KhronosGroup","id":1608701,"avatar_url":"https://avatars.githubusercontent.com/u/1608701?v=3","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"repo":{"id":5207280,"name":"WebGL","full_name":"KhronosGroup/WebGL","owner":{"login":"KhronosGroup","id":1608701,"avatar_url":"https://avatars.githubusercontent.com/u/1608701?v=3","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KhronosGroup/WebGL","description":"The Official Khronos WebGL Repository","fork":false,"url":"https://api.github.com/repos/KhronosGroup/WebGL","forks_url":"https://api.github.com/repos/KhronosGroup/WebGL/forks","keys_url":"https://api.github.com/repos/KhronosGroup/WebGL/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KhronosGroup/WebGL/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KhronosGroup/WebGL/teams","hooks_url":"https://api.github.com/repos/KhronosGroup/WebGL/hooks","issue_events_url":"https://api.github.com/repos/KhronosGroup/WebGL/issues/events{/number}","events_url":"https://api.github.com/repos/KhronosGroup/WebGL/events","assignees_url":"https://api.github.com/repos/KhronosGroup/WebGL/assignees{/user}","branches_url":"https://api.github.com/repos/KhronosGroup/WebGL/branches{/branch}","tags_url":"https://api.github.com/repos/KhronosGroup/WebGL/tags","blobs_url":"https://api.github.com/repos/KhronosGroup/WebGL/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KhronosGroup/WebGL/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KhronosGroup/WebGL/git/refs{/sha}","trees_url":"https://api.github.com/repos/KhronosGroup/WebGL/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KhronosGroup/WebGL/statuses/{sha}","languages_url":"https://api.github.com/repos/KhronosGroup/WebGL/languages","stargazers_url":"https://api.github.com/repos/KhronosGroup/WebGL/stargazers","contributors_url":"https://api.github.com/repos/KhronosGroup/WebGL/contributors","subscribers_url":"https://api.github.com/repos/KhronosGroup/WebGL/subscribers","subscription_url":"https://api.github.com/repos/KhronosGroup/WebGL/subscription","commits_url":"https://api.github.com/repos/KhronosGroup/WebGL/commits{/sha}","git_commits_url":"https://api.github.com/repos/KhronosGroup/WebGL/git/commits{/sha}","comments_url":"https://api.github.com/repos/KhronosGroup/WebGL/comments{/number}","issue_comment_url":"https://api.github.com/repos/KhronosGroup/WebGL/issues/comments{/number}","contents_url":"https://api.github.com/repos/KhronosGroup/WebGL/contents/{+path}","compare_url":"https://api.github.com/repos/KhronosGroup/WebGL/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KhronosGroup/WebGL/merges","archive_url":"https://api.github.com/repos/KhronosGroup/WebGL/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KhronosGroup/WebGL/downloads","issues_url":"https://api.github.com/repos/KhronosGroup/WebGL/issues{/number}","pulls_url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls{/number}","milestones_url":"https://api.github.com/repos/KhronosGroup/WebGL/milestones{/number}","notifications_url":"https://api.github.com/repos/KhronosGroup/WebGL/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KhronosGroup/WebGL/labels{/name}","releases_url":"https://api.github.com/repos/KhronosGroup/WebGL/releases{/id}","deployments_url":"https://api.github.com/repos/KhronosGroup/WebGL/deployments","created_at":"2012-07-27T17:21:51Z","updated_at":"2017-01-13T11:49:00Z","pushed_at":"2017-01-13T01:24:30Z","git_url":"git://github.com/KhronosGroup/WebGL.git","ssh_url":"git@github.com:KhronosGroup/WebGL.git","clone_url":"https://github.com/KhronosGroup/WebGL.git","svn_url":"https://github.com/KhronosGroup/WebGL","homepage":null,"size":29068,"stargazers_count":745,"watchers_count":745,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":347,"mirror_url":null,"open_issues_count":87,"forks":347,"open_issues":87,"watchers":745,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/2258"},"html":{"href":"https://github.com/KhronosGroup/WebGL/pull/2258"},"issue":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/issues/2258"},"comments":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/issues/2258/comments"},"review_comments":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/2258/comments"},"review_comment":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/2258/commits"},"statuses":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/statuses/2a2b421ef24a77712665497dc36567f931ec0c74"}}}}
{"actor":{"display_login":"zhenyao"}}