{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/WinObjC/pulls/comments/111224318","pull_request_review_id":32455155,"id":111224318,"diff_hunk":"@@ -19,168 +20,333 @@\n #import \"Foundation/NSMutableData.h\"\n #import \"Foundation/NSError.h\"\n #import \"Foundation/NSRunLoop.h\"\n-#import \"NSURLConnectionState.h\"\n #import \"Foundation/NSURLConnection.h\"\n #import \"LoggingNative.h\"\n #import \"NSURLProtocolInternal.h\"\n \n+#import <algorithm>\n+#import <vector>\n+\n static const wchar_t* TAG = L\"NSURLConnection\";\n \n-@implementation NSURLConnection\n+// Private helper function that returns a NSURLProtocol object capable of handling a NSURLRequest\n+// Returns nil if one cannot be created\n+static NSURLProtocol* _protocolForRequest(NSURLRequest* request, id<NSURLProtocolClient> client) {","path":"Frameworks/Foundation/NSURLConnection.mm","position":23,"original_position":23,"commit_id":"ddf244de2dcf1114caf3f428fabd42b4c6ad4339","original_commit_id":"ddf244de2dcf1114caf3f428fabd42b4c6ad4339","user":{"login":"ms-jihua","id":16024095,"avatar_url":"https://avatars3.githubusercontent.com/u/16024095?v=3","gravatar_id":"","url":"https://api.github.com/users/ms-jihua","html_url":"https://github.com/ms-jihua","followers_url":"https://api.github.com/users/ms-jihua/followers","following_url":"https://api.github.com/users/ms-jihua/following{/other_user}","gists_url":"https://api.github.com/users/ms-jihua/gists{/gist_id}","starred_url":"https://api.github.com/users/ms-jihua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ms-jihua/subscriptions","organizations_url":"https://api.github.com/users/ms-jihua/orgs","repos_url":"https://api.github.com/users/ms-jihua/repos","events_url":"https://api.github.com/users/ms-jihua/events{/privacy}","received_events_url":"https://api.github.com/users/ms-jihua/received_events","type":"User","site_admin":false},"body":"Hmm, originally i only proposed this convention for within CoreText/Graphics, given that we had a Hhigh incidence of both file-private and framework-private functions. Did we begin to use this more broadly?","created_at":"2017-04-12T18:20:50Z","updated_at":"2017-04-12T18:20:51Z","html_url":"https://github.com/Microsoft/WinObjC/pull/2464#discussion_r111224318","pull_request_url":"https://api.github.com/repos/Microsoft/WinObjC/pulls/2464","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/WinObjC/pulls/comments/111224318"},"html":{"href":"https://github.com/Microsoft/WinObjC/pull/2464#discussion_r111224318"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/WinObjC/pulls/2464"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/WinObjC/pulls/2464","id":114888317,"html_url":"https://github.com/Microsoft/WinObjC/pull/2464","diff_url":"https://github.com/Microsoft/WinObjC/pull/2464.diff","patch_url":"https://github.com/Microsoft/WinObjC/pull/2464.patch","issue_url":"https://api.github.com/repos/Microsoft/WinObjC/issues/2464","number":2464,"state":"open","locked":false,"title":"Refactor parts of NSURLConnection","user":{"login":"ms-jihua","id":16024095,"avatar_url":"https://avatars3.githubusercontent.com/u/16024095?v=3","gravatar_id":"","url":"https://api.github.com/users/ms-jihua","html_url":"https://github.com/ms-jihua","followers_url":"https://api.github.com/users/ms-jihua/followers","following_url":"https://api.github.com/users/ms-jihua/following{/other_user}","gists_url":"https://api.github.com/users/ms-jihua/gists{/gist_id}","starred_url":"https://api.github.com/users/ms-jihua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ms-jihua/subscriptions","organizations_url":"https://api.github.com/users/ms-jihua/orgs","repos_url":"https://api.github.com/users/ms-jihua/repos","events_url":"https://api.github.com/users/ms-jihua/events{/privacy}","received_events_url":"https://api.github.com/users/ms-jihua/received_events","type":"User","site_admin":false},"body":"    - Implement [NSURLConnection sendAsynchronousRequest:]\r\n        - Re-implement [NSURLConnection sendSynchronousRequest:] on top of it, as stated in docs\r\n    - Implement a not-yet fully-working setDelegateQueue: (callbacks are not yet called on it)\r\n    - Remove NSURLConnectionState, replace with a lighter-weight, more flexible inner class\r\n    - Changed the NSURLConnection functional tests to no longer run on the main run loop.\r\n      This no longer works, which is correct (doesn't work on reference platform either)\r\n        - Instead, run on another thread's run loop, and an operation queue.\r\n        - Also added tests for sendSynchronousRequest:\r\n    - Change parts of NSURLProtocol, NSRunLoop to use stricter typing\r\n        - Change instances of NSRunLoopMode to actually say NSRunLoopMode instead of NSString*\r\n\r\nFixes #2298","created_at":"2017-04-07T19:52:41Z","updated_at":"2017-04-12T18:20:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fbfdd7814f6e38dbd091b1b775884811e2bc0b59","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/WinObjC/pulls/2464/commits","review_comments_url":"https://api.github.com/repos/Microsoft/WinObjC/pulls/2464/comments","review_comment_url":"https://api.github.com/repos/Microsoft/WinObjC/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/WinObjC/issues/2464/comments","statuses_url":"https://api.github.com/repos/Microsoft/WinObjC/statuses/ddf244de2dcf1114caf3f428fabd42b4c6ad4339","head":{"label":"ms-jihua:dataWithContentsOfURL5","ref":"dataWithContentsOfURL5","sha":"ddf244de2dcf1114caf3f428fabd42b4c6ad4339","user":{"login":"ms-jihua","id":16024095,"avatar_url":"https://avatars3.githubusercontent.com/u/16024095?v=3","gravatar_id":"","url":"https://api.github.com/users/ms-jihua","html_url":"https://github.com/ms-jihua","followers_url":"https://api.github.com/users/ms-jihua/followers","following_url":"https://api.github.com/users/ms-jihua/following{/other_user}","gists_url":"https://api.github.com/users/ms-jihua/gists{/gist_id}","starred_url":"https://api.github.com/users/ms-jihua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ms-jihua/subscriptions","organizations_url":"https://api.github.com/users/ms-jihua/orgs","repos_url":"https://api.github.com/users/ms-jihua/repos","events_url":"https://api.github.com/users/ms-jihua/events{/privacy}","received_events_url":"https://api.github.com/users/ms-jihua/received_events","type":"User","site_admin":false},"repo":{"id":63092436,"name":"WinObjC","full_name":"ms-jihua/WinObjC","owner":{"login":"ms-jihua","id":16024095,"avatar_url":"https://avatars3.githubusercontent.com/u/16024095?v=3","gravatar_id":"","url":"https://api.github.com/users/ms-jihua","html_url":"https://github.com/ms-jihua","followers_url":"https://api.github.com/users/ms-jihua/followers","following_url":"https://api.github.com/users/ms-jihua/following{/other_user}","gists_url":"https://api.github.com/users/ms-jihua/gists{/gist_id}","starred_url":"https://api.github.com/users/ms-jihua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ms-jihua/subscriptions","organizations_url":"https://api.github.com/users/ms-jihua/orgs","repos_url":"https://api.github.com/users/ms-jihua/repos","events_url":"https://api.github.com/users/ms-jihua/events{/privacy}","received_events_url":"https://api.github.com/users/ms-jihua/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ms-jihua/WinObjC","description":"Objective-C for Windows","fork":true,"url":"https://api.github.com/repos/ms-jihua/WinObjC","forks_url":"https://api.github.com/repos/ms-jihua/WinObjC/forks","keys_url":"https://api.github.com/repos/ms-jihua/WinObjC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ms-jihua/WinObjC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ms-jihua/WinObjC/teams","hooks_url":"https://api.github.com/repos/ms-jihua/WinObjC/hooks","issue_events_url":"https://api.github.com/repos/ms-jihua/WinObjC/issues/events{/number}","events_url":"https://api.github.com/repos/ms-jihua/WinObjC/events","assignees_url":"https://api.github.com/repos/ms-jihua/WinObjC/assignees{/user}","branches_url":"https://api.github.com/repos/ms-jihua/WinObjC/branches{/branch}","tags_url":"https://api.github.com/repos/ms-jihua/WinObjC/tags","blobs_url":"https://api.github.com/repos/ms-jihua/WinObjC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ms-jihua/WinObjC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ms-jihua/WinObjC/git/refs{/sha}","trees_url":"https://api.github.com/repos/ms-jihua/WinObjC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ms-jihua/WinObjC/statuses/{sha}","languages_url":"https://api.github.com/repos/ms-jihua/WinObjC/languages","stargazers_url":"https://api.github.com/repos/ms-jihua/WinObjC/stargazers","contributors_url":"https://api.github.com/repos/ms-jihua/WinObjC/contributors","subscribers_url":"https://api.github.com/repos/ms-jihua/WinObjC/subscribers","subscription_url":"https://api.github.com/repos/ms-jihua/WinObjC/subscription","commits_url":"https://api.github.com/repos/ms-jihua/WinObjC/commits{/sha}","git_commits_url":"https://api.github.com/repos/ms-jihua/WinObjC/git/commits{/sha}","comments_url":"https://api.github.com/repos/ms-jihua/WinObjC/comments{/number}","issue_comment_url":"https://api.github.com/repos/ms-jihua/WinObjC/issues/comments{/number}","contents_url":"https://api.github.com/repos/ms-jihua/WinObjC/contents/{+path}","compare_url":"https://api.github.com/repos/ms-jihua/WinObjC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ms-jihua/WinObjC/merges","archive_url":"https://api.github.com/repos/ms-jihua/WinObjC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ms-jihua/WinObjC/downloads","issues_url":"https://api.github.com/repos/ms-jihua/WinObjC/issues{/number}","pulls_url":"https://api.github.com/repos/ms-jihua/WinObjC/pulls{/number}","milestones_url":"https://api.github.com/repos/ms-jihua/WinObjC/milestones{/number}","notifications_url":"https://api.github.com/repos/ms-jihua/WinObjC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ms-jihua/WinObjC/labels{/name}","releases_url":"https://api.github.com/repos/ms-jihua/WinObjC/releases{/id}","deployments_url":"https://api.github.com/repos/ms-jihua/WinObjC/deployments","created_at":"2016-07-11T18:32:57Z","updated_at":"2016-07-11T18:33:10Z","pushed_at":"2017-04-12T00:37:11Z","git_url":"git://github.com/ms-jihua/WinObjC.git","ssh_url":"git@github.com:ms-jihua/WinObjC.git","clone_url":"https://github.com/ms-jihua/WinObjC.git","svn_url":"https://github.com/ms-jihua/WinObjC","homepage":"","size":342603,"stargazers_count":0,"watchers_count":0,"language":"Objective-C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"Microsoft:develop","ref":"develop","sha":"9cfd34731726e1d957943ff393da6c3f985a6f38","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars1.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":37950166,"name":"WinObjC","full_name":"Microsoft/WinObjC","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars1.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/WinObjC","description":"Objective-C for Windows","fork":false,"url":"https://api.github.com/repos/Microsoft/WinObjC","forks_url":"https://api.github.com/repos/Microsoft/WinObjC/forks","keys_url":"https://api.github.com/repos/Microsoft/WinObjC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/WinObjC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/WinObjC/teams","hooks_url":"https://api.github.com/repos/Microsoft/WinObjC/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/WinObjC/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/WinObjC/events","assignees_url":"https://api.github.com/repos/Microsoft/WinObjC/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/WinObjC/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/WinObjC/tags","blobs_url":"https://api.github.com/repos/Microsoft/WinObjC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/WinObjC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/WinObjC/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/WinObjC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/WinObjC/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/WinObjC/languages","stargazers_url":"https://api.github.com/repos/Microsoft/WinObjC/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/WinObjC/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/WinObjC/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/WinObjC/subscription","commits_url":"https://api.github.com/repos/Microsoft/WinObjC/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/WinObjC/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/WinObjC/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/WinObjC/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/WinObjC/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/WinObjC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/WinObjC/merges","archive_url":"https://api.github.com/repos/Microsoft/WinObjC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/WinObjC/downloads","issues_url":"https://api.github.com/repos/Microsoft/WinObjC/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/WinObjC/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/WinObjC/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/WinObjC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/WinObjC/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/WinObjC/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/WinObjC/deployments","created_at":"2015-06-23T23:14:58Z","updated_at":"2017-04-12T15:11:09Z","pushed_at":"2017-04-12T17:51:29Z","git_url":"git://github.com/Microsoft/WinObjC.git","ssh_url":"git@github.com:Microsoft/WinObjC.git","clone_url":"https://github.com/Microsoft/WinObjC.git","svn_url":"https://github.com/Microsoft/WinObjC","homepage":"","size":382278,"stargazers_count":5678,"watchers_count":5678,"language":"Objective-C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":747,"mirror_url":null,"open_issues_count":366,"forks":747,"open_issues":366,"watchers":5678,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/WinObjC/pulls/2464"},"html":{"href":"https://github.com/Microsoft/WinObjC/pull/2464"},"issue":{"href":"https://api.github.com/repos/Microsoft/WinObjC/issues/2464"},"comments":{"href":"https://api.github.com/repos/Microsoft/WinObjC/issues/2464/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/WinObjC/pulls/2464/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/WinObjC/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/WinObjC/pulls/2464/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/WinObjC/statuses/ddf244de2dcf1114caf3f428fabd42b4c6ad4339"}}}}
{"actor":{"display_login":"ms-jihua"}}