{"action":"opened","number":736,"pull_request":{"url":"https://api.github.com/repos/facebook/componentkit/pulls/736","id":103971078,"html_url":"https://github.com/facebook/componentkit/pull/736","diff_url":"https://github.com/facebook/componentkit/pull/736.diff","patch_url":"https://github.com/facebook/componentkit/pull/736.patch","issue_url":"https://api.github.com/repos/facebook/componentkit/issues/736","number":736,"state":"open","locked":false,"title":"Remove CKComponentLifecycleManager","user":{"login":"eczarny","id":28012,"avatar_url":"https://avatars.githubusercontent.com/u/28012?v=3","gravatar_id":"","url":"https://api.github.com/users/eczarny","html_url":"https://github.com/eczarny","followers_url":"https://api.github.com/users/eczarny/followers","following_url":"https://api.github.com/users/eczarny/following{/other_user}","gists_url":"https://api.github.com/users/eczarny/gists{/gist_id}","starred_url":"https://api.github.com/users/eczarny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eczarny/subscriptions","organizations_url":"https://api.github.com/users/eczarny/orgs","repos_url":"https://api.github.com/users/eczarny/repos","events_url":"https://api.github.com/users/eczarny/events{/privacy}","received_events_url":"https://api.github.com/users/eczarny/received_events","type":"User","site_admin":false},"body":"Apologies for such a large change. I started by removing `CKComponentLifecycleManager` and then realized it is still needed to help drive a few tests. As a result I needed to make a few more changes along the way.\r\n\r\nHere's a summary of those changes:\r\n\r\n1. Merge `ComponentKitTestLib` and `ComponentKitTestHelpers`\r\n2. Replace `CKComponentLifecycleManager` with `CKComponentLifecycleTestController`, a test-only helper that makes updating state and attaching component hierarchies to views easier\r\n3. Renamed `CKComponentViewInterface.h`/`CKComponentViewInterface.m` to `CKComponent+UIView.mm`/`CKComponent+UIView.mm`\r\n4. Replaced the deprecated, or soon to be deprecated (once I upgrade Xcode and our tvOS builds), calls to `OSMemoryBarrier` with `std::atomic_thread_fence`\r\n\r\nI also made a few key changes `CKComponentLifecycleTestController`: it is now main thread affined and it does not support asynchronous state updates. Any attempt to update state using `CKUpdateModeAsynchronous` will result in a synchronous state update. For testing purposes this is more than sufficient, and likely a bit more reliable anyway.","created_at":"2017-01-31T16:26:31Z","updated_at":"2017-01-31T16:26:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/componentkit/pulls/736/commits","review_comments_url":"https://api.github.com/repos/facebook/componentkit/pulls/736/comments","review_comment_url":"https://api.github.com/repos/facebook/componentkit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/componentkit/issues/736/comments","statuses_url":"https://api.github.com/repos/facebook/componentkit/statuses/9e453cb903d0fa358c77adf66326b387b5ca08dd","head":{"label":"eczarny:remove-ckcomponentlifecyclemanager","ref":"remove-ckcomponentlifecyclemanager","sha":"9e453cb903d0fa358c77adf66326b387b5ca08dd","user":{"login":"eczarny","id":28012,"avatar_url":"https://avatars.githubusercontent.com/u/28012?v=3","gravatar_id":"","url":"https://api.github.com/users/eczarny","html_url":"https://github.com/eczarny","followers_url":"https://api.github.com/users/eczarny/followers","following_url":"https://api.github.com/users/eczarny/following{/other_user}","gists_url":"https://api.github.com/users/eczarny/gists{/gist_id}","starred_url":"https://api.github.com/users/eczarny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eczarny/subscriptions","organizations_url":"https://api.github.com/users/eczarny/orgs","repos_url":"https://api.github.com/users/eczarny/repos","events_url":"https://api.github.com/users/eczarny/events{/privacy}","received_events_url":"https://api.github.com/users/eczarny/received_events","type":"User","site_admin":false},"repo":{"id":39351833,"name":"componentkit","full_name":"eczarny/componentkit","owner":{"login":"eczarny","id":28012,"avatar_url":"https://avatars.githubusercontent.com/u/28012?v=3","gravatar_id":"","url":"https://api.github.com/users/eczarny","html_url":"https://github.com/eczarny","followers_url":"https://api.github.com/users/eczarny/followers","following_url":"https://api.github.com/users/eczarny/following{/other_user}","gists_url":"https://api.github.com/users/eczarny/gists{/gist_id}","starred_url":"https://api.github.com/users/eczarny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eczarny/subscriptions","organizations_url":"https://api.github.com/users/eczarny/orgs","repos_url":"https://api.github.com/users/eczarny/repos","events_url":"https://api.github.com/users/eczarny/events{/privacy}","received_events_url":"https://api.github.com/users/eczarny/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eczarny/componentkit","description":"A React-inspired view framework for iOS.","fork":true,"url":"https://api.github.com/repos/eczarny/componentkit","forks_url":"https://api.github.com/repos/eczarny/componentkit/forks","keys_url":"https://api.github.com/repos/eczarny/componentkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eczarny/componentkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eczarny/componentkit/teams","hooks_url":"https://api.github.com/repos/eczarny/componentkit/hooks","issue_events_url":"https://api.github.com/repos/eczarny/componentkit/issues/events{/number}","events_url":"https://api.github.com/repos/eczarny/componentkit/events","assignees_url":"https://api.github.com/repos/eczarny/componentkit/assignees{/user}","branches_url":"https://api.github.com/repos/eczarny/componentkit/branches{/branch}","tags_url":"https://api.github.com/repos/eczarny/componentkit/tags","blobs_url":"https://api.github.com/repos/eczarny/componentkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eczarny/componentkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eczarny/componentkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/eczarny/componentkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eczarny/componentkit/statuses/{sha}","languages_url":"https://api.github.com/repos/eczarny/componentkit/languages","stargazers_url":"https://api.github.com/repos/eczarny/componentkit/stargazers","contributors_url":"https://api.github.com/repos/eczarny/componentkit/contributors","subscribers_url":"https://api.github.com/repos/eczarny/componentkit/subscribers","subscription_url":"https://api.github.com/repos/eczarny/componentkit/subscription","commits_url":"https://api.github.com/repos/eczarny/componentkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/eczarny/componentkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/eczarny/componentkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/eczarny/componentkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/eczarny/componentkit/contents/{+path}","compare_url":"https://api.github.com/repos/eczarny/componentkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eczarny/componentkit/merges","archive_url":"https://api.github.com/repos/eczarny/componentkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eczarny/componentkit/downloads","issues_url":"https://api.github.com/repos/eczarny/componentkit/issues{/number}","pulls_url":"https://api.github.com/repos/eczarny/componentkit/pulls{/number}","milestones_url":"https://api.github.com/repos/eczarny/componentkit/milestones{/number}","notifications_url":"https://api.github.com/repos/eczarny/componentkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eczarny/componentkit/labels{/name}","releases_url":"https://api.github.com/repos/eczarny/componentkit/releases{/id}","deployments_url":"https://api.github.com/repos/eczarny/componentkit/deployments","created_at":"2015-07-19T22:52:19Z","updated_at":"2016-10-25T21:35:55Z","pushed_at":"2017-01-31T15:24:00Z","git_url":"git://github.com/eczarny/componentkit.git","ssh_url":"git@github.com:eczarny/componentkit.git","clone_url":"https://github.com/eczarny/componentkit.git","svn_url":"https://github.com/eczarny/componentkit","homepage":"http://www.componentkit.org/","size":8739,"stargazers_count":0,"watchers_count":0,"language":"Objective-C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"eaac3ab310583235f6cd86c2fb342d03adb94eb0","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":32600951,"name":"componentkit","full_name":"facebook/componentkit","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/componentkit","description":"A React-inspired view framework for iOS.","fork":false,"url":"https://api.github.com/repos/facebook/componentkit","forks_url":"https://api.github.com/repos/facebook/componentkit/forks","keys_url":"https://api.github.com/repos/facebook/componentkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/componentkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/componentkit/teams","hooks_url":"https://api.github.com/repos/facebook/componentkit/hooks","issue_events_url":"https://api.github.com/repos/facebook/componentkit/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/componentkit/events","assignees_url":"https://api.github.com/repos/facebook/componentkit/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/componentkit/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/componentkit/tags","blobs_url":"https://api.github.com/repos/facebook/componentkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/componentkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/componentkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/componentkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/componentkit/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/componentkit/languages","stargazers_url":"https://api.github.com/repos/facebook/componentkit/stargazers","contributors_url":"https://api.github.com/repos/facebook/componentkit/contributors","subscribers_url":"https://api.github.com/repos/facebook/componentkit/subscribers","subscription_url":"https://api.github.com/repos/facebook/componentkit/subscription","commits_url":"https://api.github.com/repos/facebook/componentkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/componentkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/componentkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/componentkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/componentkit/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/componentkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/componentkit/merges","archive_url":"https://api.github.com/repos/facebook/componentkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/componentkit/downloads","issues_url":"https://api.github.com/repos/facebook/componentkit/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/componentkit/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/componentkit/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/componentkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/componentkit/labels{/name}","releases_url":"https://api.github.com/repos/facebook/componentkit/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/componentkit/deployments","created_at":"2015-03-20T18:42:47Z","updated_at":"2017-01-31T13:51:41Z","pushed_at":"2017-01-30T20:35:02Z","git_url":"git://github.com/facebook/componentkit.git","ssh_url":"git@github.com:facebook/componentkit.git","clone_url":"https://github.com/facebook/componentkit.git","svn_url":"https://github.com/facebook/componentkit","homepage":"http://www.componentkit.org/","size":8739,"stargazers_count":3650,"watchers_count":3650,"language":"Objective-C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":401,"mirror_url":null,"open_issues_count":35,"forks":401,"open_issues":35,"watchers":3650,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/componentkit/pulls/736"},"html":{"href":"https://github.com/facebook/componentkit/pull/736"},"issue":{"href":"https://api.github.com/repos/facebook/componentkit/issues/736"},"comments":{"href":"https://api.github.com/repos/facebook/componentkit/issues/736/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/componentkit/pulls/736/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/componentkit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/componentkit/pulls/736/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/componentkit/statuses/9e453cb903d0fa358c77adf66326b387b5ca08dd"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":682,"deletions":1323,"changed_files":42}}
{"actor":{"display_login":"eczarny"}}