{"action":"closed","number":148,"pull_request":{"url":"https://api.github.com/repos/RichardKnop/machinery/pulls/148","id":130094017,"html_url":"https://github.com/RichardKnop/machinery/pull/148","diff_url":"https://github.com/RichardKnop/machinery/pull/148.diff","patch_url":"https://github.com/RichardKnop/machinery/pull/148.patch","issue_url":"https://api.github.com/repos/RichardKnop/machinery/issues/148","number":148,"state":"closed","locked":false,"title":"Set read and write timeouts on the redis connection","user":{"login":"jurre","id":749864,"avatar_url":"https://avatars0.githubusercontent.com/u/749864?v=3","gravatar_id":"","url":"https://api.github.com/users/jurre","html_url":"https://github.com/jurre","followers_url":"https://api.github.com/users/jurre/followers","following_url":"https://api.github.com/users/jurre/following{/other_user}","gists_url":"https://api.github.com/users/jurre/gists{/gist_id}","starred_url":"https://api.github.com/users/jurre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jurre/subscriptions","organizations_url":"https://api.github.com/users/jurre/orgs","repos_url":"https://api.github.com/users/jurre/repos","events_url":"https://api.github.com/users/jurre/events{/privacy}","received_events_url":"https://api.github.com/users/jurre/received_events","type":"User","site_admin":false},"body":"First of all, thanks for writing Machinery, it's been a pleasure to use.\r\n\r\nWe've been running Machinery to schedule tasks for execution at a later time, using Redis as a broker. After running for a couple of days without restarting we have noticed no new tasks being picked up, even though they are scheduled for execution at those times. We don't get any errors, it just stops consuming.\r\n\r\nI suspect that this could happen due to the redis connection hanging on read or write, and I figured it would be a good idea to set a timeout on those.","created_at":"2017-07-12T09:32:44Z","updated_at":"2017-07-12T16:32:25Z","closed_at":"2017-07-12T16:32:24Z","merged_at":"2017-07-12T16:32:24Z","merge_commit_sha":"8e39a2dbb2b7063f22ca0bac04e3494ef649f2f9","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/RichardKnop/machinery/pulls/148/commits","review_comments_url":"https://api.github.com/repos/RichardKnop/machinery/pulls/148/comments","review_comment_url":"https://api.github.com/repos/RichardKnop/machinery/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RichardKnop/machinery/issues/148/comments","statuses_url":"https://api.github.com/repos/RichardKnop/machinery/statuses/fc05d7714ceffe1348e9b4bf1ede351c58893333","head":{"label":"jurre:jurre/redis-connection-timeouts","ref":"jurre/redis-connection-timeouts","sha":"fc05d7714ceffe1348e9b4bf1ede351c58893333","user":{"login":"jurre","id":749864,"avatar_url":"https://avatars0.githubusercontent.com/u/749864?v=3","gravatar_id":"","url":"https://api.github.com/users/jurre","html_url":"https://github.com/jurre","followers_url":"https://api.github.com/users/jurre/followers","following_url":"https://api.github.com/users/jurre/following{/other_user}","gists_url":"https://api.github.com/users/jurre/gists{/gist_id}","starred_url":"https://api.github.com/users/jurre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jurre/subscriptions","organizations_url":"https://api.github.com/users/jurre/orgs","repos_url":"https://api.github.com/users/jurre/repos","events_url":"https://api.github.com/users/jurre/events{/privacy}","received_events_url":"https://api.github.com/users/jurre/received_events","type":"User","site_admin":false},"repo":{"id":91456801,"name":"machinery","full_name":"jurre/machinery","owner":{"login":"jurre","id":749864,"avatar_url":"https://avatars0.githubusercontent.com/u/749864?v=3","gravatar_id":"","url":"https://api.github.com/users/jurre","html_url":"https://github.com/jurre","followers_url":"https://api.github.com/users/jurre/followers","following_url":"https://api.github.com/users/jurre/following{/other_user}","gists_url":"https://api.github.com/users/jurre/gists{/gist_id}","starred_url":"https://api.github.com/users/jurre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jurre/subscriptions","organizations_url":"https://api.github.com/users/jurre/orgs","repos_url":"https://api.github.com/users/jurre/repos","events_url":"https://api.github.com/users/jurre/events{/privacy}","received_events_url":"https://api.github.com/users/jurre/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jurre/machinery","description":"Machinery is an asynchronous task queue/job queue based on distributed message passing.","fork":true,"url":"https://api.github.com/repos/jurre/machinery","forks_url":"https://api.github.com/repos/jurre/machinery/forks","keys_url":"https://api.github.com/repos/jurre/machinery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jurre/machinery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jurre/machinery/teams","hooks_url":"https://api.github.com/repos/jurre/machinery/hooks","issue_events_url":"https://api.github.com/repos/jurre/machinery/issues/events{/number}","events_url":"https://api.github.com/repos/jurre/machinery/events","assignees_url":"https://api.github.com/repos/jurre/machinery/assignees{/user}","branches_url":"https://api.github.com/repos/jurre/machinery/branches{/branch}","tags_url":"https://api.github.com/repos/jurre/machinery/tags","blobs_url":"https://api.github.com/repos/jurre/machinery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jurre/machinery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jurre/machinery/git/refs{/sha}","trees_url":"https://api.github.com/repos/jurre/machinery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jurre/machinery/statuses/{sha}","languages_url":"https://api.github.com/repos/jurre/machinery/languages","stargazers_url":"https://api.github.com/repos/jurre/machinery/stargazers","contributors_url":"https://api.github.com/repos/jurre/machinery/contributors","subscribers_url":"https://api.github.com/repos/jurre/machinery/subscribers","subscription_url":"https://api.github.com/repos/jurre/machinery/subscription","commits_url":"https://api.github.com/repos/jurre/machinery/commits{/sha}","git_commits_url":"https://api.github.com/repos/jurre/machinery/git/commits{/sha}","comments_url":"https://api.github.com/repos/jurre/machinery/comments{/number}","issue_comment_url":"https://api.github.com/repos/jurre/machinery/issues/comments{/number}","contents_url":"https://api.github.com/repos/jurre/machinery/contents/{+path}","compare_url":"https://api.github.com/repos/jurre/machinery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jurre/machinery/merges","archive_url":"https://api.github.com/repos/jurre/machinery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jurre/machinery/downloads","issues_url":"https://api.github.com/repos/jurre/machinery/issues{/number}","pulls_url":"https://api.github.com/repos/jurre/machinery/pulls{/number}","milestones_url":"https://api.github.com/repos/jurre/machinery/milestones{/number}","notifications_url":"https://api.github.com/repos/jurre/machinery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jurre/machinery/labels{/name}","releases_url":"https://api.github.com/repos/jurre/machinery/releases{/id}","deployments_url":"https://api.github.com/repos/jurre/machinery/deployments","created_at":"2017-05-16T12:38:53Z","updated_at":"2017-05-16T12:38:55Z","pushed_at":"2017-07-12T09:24:21Z","git_url":"git://github.com/jurre/machinery.git","ssh_url":"git@github.com:jurre/machinery.git","clone_url":"https://github.com/jurre/machinery.git","svn_url":"https://github.com/jurre/machinery","homepage":"","size":3395,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"RichardKnop:master","ref":"master","sha":"bd86a68186b16010b67f8e9377ee2fd6a2927a7a","user":{"login":"RichardKnop","id":2325888,"avatar_url":"https://avatars3.githubusercontent.com/u/2325888?v=3","gravatar_id":"","url":"https://api.github.com/users/RichardKnop","html_url":"https://github.com/RichardKnop","followers_url":"https://api.github.com/users/RichardKnop/followers","following_url":"https://api.github.com/users/RichardKnop/following{/other_user}","gists_url":"https://api.github.com/users/RichardKnop/gists{/gist_id}","starred_url":"https://api.github.com/users/RichardKnop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RichardKnop/subscriptions","organizations_url":"https://api.github.com/users/RichardKnop/orgs","repos_url":"https://api.github.com/users/RichardKnop/repos","events_url":"https://api.github.com/users/RichardKnop/events{/privacy}","received_events_url":"https://api.github.com/users/RichardKnop/received_events","type":"User","site_admin":false},"repo":{"id":33452903,"name":"machinery","full_name":"RichardKnop/machinery","owner":{"login":"RichardKnop","id":2325888,"avatar_url":"https://avatars3.githubusercontent.com/u/2325888?v=3","gravatar_id":"","url":"https://api.github.com/users/RichardKnop","html_url":"https://github.com/RichardKnop","followers_url":"https://api.github.com/users/RichardKnop/followers","following_url":"https://api.github.com/users/RichardKnop/following{/other_user}","gists_url":"https://api.github.com/users/RichardKnop/gists{/gist_id}","starred_url":"https://api.github.com/users/RichardKnop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RichardKnop/subscriptions","organizations_url":"https://api.github.com/users/RichardKnop/orgs","repos_url":"https://api.github.com/users/RichardKnop/repos","events_url":"https://api.github.com/users/RichardKnop/events{/privacy}","received_events_url":"https://api.github.com/users/RichardKnop/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/RichardKnop/machinery","description":"Machinery is an asynchronous task queue/job queue based on distributed message passing.","fork":false,"url":"https://api.github.com/repos/RichardKnop/machinery","forks_url":"https://api.github.com/repos/RichardKnop/machinery/forks","keys_url":"https://api.github.com/repos/RichardKnop/machinery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RichardKnop/machinery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RichardKnop/machinery/teams","hooks_url":"https://api.github.com/repos/RichardKnop/machinery/hooks","issue_events_url":"https://api.github.com/repos/RichardKnop/machinery/issues/events{/number}","events_url":"https://api.github.com/repos/RichardKnop/machinery/events","assignees_url":"https://api.github.com/repos/RichardKnop/machinery/assignees{/user}","branches_url":"https://api.github.com/repos/RichardKnop/machinery/branches{/branch}","tags_url":"https://api.github.com/repos/RichardKnop/machinery/tags","blobs_url":"https://api.github.com/repos/RichardKnop/machinery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RichardKnop/machinery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RichardKnop/machinery/git/refs{/sha}","trees_url":"https://api.github.com/repos/RichardKnop/machinery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RichardKnop/machinery/statuses/{sha}","languages_url":"https://api.github.com/repos/RichardKnop/machinery/languages","stargazers_url":"https://api.github.com/repos/RichardKnop/machinery/stargazers","contributors_url":"https://api.github.com/repos/RichardKnop/machinery/contributors","subscribers_url":"https://api.github.com/repos/RichardKnop/machinery/subscribers","subscription_url":"https://api.github.com/repos/RichardKnop/machinery/subscription","commits_url":"https://api.github.com/repos/RichardKnop/machinery/commits{/sha}","git_commits_url":"https://api.github.com/repos/RichardKnop/machinery/git/commits{/sha}","comments_url":"https://api.github.com/repos/RichardKnop/machinery/comments{/number}","issue_comment_url":"https://api.github.com/repos/RichardKnop/machinery/issues/comments{/number}","contents_url":"https://api.github.com/repos/RichardKnop/machinery/contents/{+path}","compare_url":"https://api.github.com/repos/RichardKnop/machinery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RichardKnop/machinery/merges","archive_url":"https://api.github.com/repos/RichardKnop/machinery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RichardKnop/machinery/downloads","issues_url":"https://api.github.com/repos/RichardKnop/machinery/issues{/number}","pulls_url":"https://api.github.com/repos/RichardKnop/machinery/pulls{/number}","milestones_url":"https://api.github.com/repos/RichardKnop/machinery/milestones{/number}","notifications_url":"https://api.github.com/repos/RichardKnop/machinery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RichardKnop/machinery/labels{/name}","releases_url":"https://api.github.com/repos/RichardKnop/machinery/releases{/id}","deployments_url":"https://api.github.com/repos/RichardKnop/machinery/deployments","created_at":"2015-04-05T19:46:34Z","updated_at":"2017-07-12T14:38:42Z","pushed_at":"2017-07-12T16:32:24Z","git_url":"git://github.com/RichardKnop/machinery.git","ssh_url":"git@github.com:RichardKnop/machinery.git","clone_url":"https://github.com/RichardKnop/machinery.git","svn_url":"https://github.com/RichardKnop/machinery","homepage":"","size":3388,"stargazers_count":1570,"watchers_count":1570,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":152,"mirror_url":null,"open_issues_count":6,"forks":152,"open_issues":6,"watchers":1570,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RichardKnop/machinery/pulls/148"},"html":{"href":"https://github.com/RichardKnop/machinery/pull/148"},"issue":{"href":"https://api.github.com/repos/RichardKnop/machinery/issues/148"},"comments":{"href":"https://api.github.com/repos/RichardKnop/machinery/issues/148/comments"},"review_comments":{"href":"https://api.github.com/repos/RichardKnop/machinery/pulls/148/comments"},"review_comment":{"href":"https://api.github.com/repos/RichardKnop/machinery/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RichardKnop/machinery/pulls/148/commits"},"statuses":{"href":"https://api.github.com/repos/RichardKnop/machinery/statuses/fc05d7714ceffe1348e9b4bf1ede351c58893333"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"RichardKnop","id":2325888,"avatar_url":"https://avatars3.githubusercontent.com/u/2325888?v=3","gravatar_id":"","url":"https://api.github.com/users/RichardKnop","html_url":"https://github.com/RichardKnop","followers_url":"https://api.github.com/users/RichardKnop/followers","following_url":"https://api.github.com/users/RichardKnop/following{/other_user}","gists_url":"https://api.github.com/users/RichardKnop/gists{/gist_id}","starred_url":"https://api.github.com/users/RichardKnop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RichardKnop/subscriptions","organizations_url":"https://api.github.com/users/RichardKnop/orgs","repos_url":"https://api.github.com/users/RichardKnop/repos","events_url":"https://api.github.com/users/RichardKnop/events{/privacy}","received_events_url":"https://api.github.com/users/RichardKnop/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":6,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"RichardKnop"}}