{"action":"created","issue":{"url":"https://api.github.com/repos/django-wiki/django-wiki/issues/714","repository_url":"https://api.github.com/repos/django-wiki/django-wiki","labels_url":"https://api.github.com/repos/django-wiki/django-wiki/issues/714/labels{/name}","comments_url":"https://api.github.com/repos/django-wiki/django-wiki/issues/714/comments","events_url":"https://api.github.com/repos/django-wiki/django-wiki/issues/714/events","html_url":"https://github.com/django-wiki/django-wiki/pull/714","id":273186496,"number":714,"title":"Replace distinct with GROUP BY id","user":{"login":"duvholt","id":1637715,"avatar_url":"https://avatars3.githubusercontent.com/u/1637715?v=4","gravatar_id":"","url":"https://api.github.com/users/duvholt","html_url":"https://github.com/duvholt","followers_url":"https://api.github.com/users/duvholt/followers","following_url":"https://api.github.com/users/duvholt/following{/other_user}","gists_url":"https://api.github.com/users/duvholt/gists{/gist_id}","starred_url":"https://api.github.com/users/duvholt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duvholt/subscriptions","organizations_url":"https://api.github.com/users/duvholt/orgs","repos_url":"https://api.github.com/users/duvholt/repos","events_url":"https://api.github.com/users/duvholt/events{/privacy}","received_events_url":"https://api.github.com/users/duvholt/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-11-12T00:01:35Z","updated_at":"2017-11-12T00:08:37Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/django-wiki/django-wiki/pulls/714","html_url":"https://github.com/django-wiki/django-wiki/pull/714","diff_url":"https://github.com/django-wiki/django-wiki/pull/714.diff","patch_url":"https://github.com/django-wiki/django-wiki/pull/714.patch"},"body":"The performance of GROUP BY is much better on PostgreSQL\r\nannotate(Count('id')) is the easiest way to generate GROUP BY id.\r\n\r\nTested on a wiki with about 22 000 revisions the SQL query difference is 33542ms vs 81ms when loading the globalhistory page. \r\n\r\nPreferably this should be tested on other setups too. "},"comment":{"url":"https://api.github.com/repos/django-wiki/django-wiki/issues/comments/343703774","html_url":"https://github.com/django-wiki/django-wiki/pull/714#issuecomment-343703774","issue_url":"https://api.github.com/repos/django-wiki/django-wiki/issues/714","id":343703774,"user":{"login":"codecov[bot]","id":22429695,"avatar_url":"https://avatars2.githubusercontent.com/in/254?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov%5Bbot%5D","html_url":"https://github.com/apps/codecov","followers_url":"https://api.github.com/users/codecov%5Bbot%5D/followers","following_url":"https://api.github.com/users/codecov%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/codecov%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/codecov%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/codecov%5Bbot%5D/repos","events_url":"https://api.github.com/users/codecov%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/codecov%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2017-11-12T00:08:37Z","updated_at":"2017-11-12T00:08:37Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/django-wiki/django-wiki/pull/714?src=pr&el=h1) Report\n> Merging [#714](https://codecov.io/gh/django-wiki/django-wiki/pull/714?src=pr&el=desc) into [master](https://codecov.io/gh/django-wiki/django-wiki/commit/dc4354b4b01e6b2b86db49684cf11148ae5e5090?src=pr&el=desc) will **not change** coverage.\n> The diff coverage is `100%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/django-wiki/django-wiki/pull/714/graphs/tree.svg?width=650&token=uxNuRktuMw&height=150&src=pr)](https://codecov.io/gh/django-wiki/django-wiki/pull/714?src=pr&el=tree)\n\n```diff\n@@           Coverage Diff           @@\n##           master     #714   +/-   ##\n=======================================\n  Coverage   69.94%   69.94%           \n=======================================\n  Files          89       89           \n  Lines        4422     4422           \n=======================================\n  Hits         3093     3093           \n  Misses       1329     1329\n```\n\n\n| [Impacted Files](https://codecov.io/gh/django-wiki/django-wiki/pull/714?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/wiki/managers.py](https://codecov.io/gh/django-wiki/django-wiki/pull/714?src=pr&el=tree#diff-c3JjL3dpa2kvbWFuYWdlcnMucHk=) | `73.58% <100%> (ø)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/django-wiki/django-wiki/pull/714?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/django-wiki/django-wiki/pull/714?src=pr&el=footer). Last update [dc4354b...14cf383](https://codecov.io/gh/django-wiki/django-wiki/pull/714?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov"}}