{"action":"closed","number":60,"pull_request":{"url":"https://api.github.com/repos/docker/docker-ce/pulls/60","id":124970968,"html_url":"https://github.com/docker/docker-ce/pull/60","diff_url":"https://github.com/docker/docker-ce/pull/60.diff","patch_url":"https://github.com/docker/docker-ce/pull/60.patch","issue_url":"https://api.github.com/repos/docker/docker-ce/issues/60","number":60,"state":"closed","locked":false,"title":"Allow --detach and --quiet flags when using --rollback","user":{"login":"seemethere","id":1700823,"avatar_url":"https://avatars1.githubusercontent.com/u/1700823?v=3","gravatar_id":"","url":"https://api.github.com/users/seemethere","html_url":"https://github.com/seemethere","followers_url":"https://api.github.com/users/seemethere/followers","following_url":"https://api.github.com/users/seemethere/following{/other_user}","gists_url":"https://api.github.com/users/seemethere/gists{/gist_id}","starred_url":"https://api.github.com/users/seemethere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seemethere/subscriptions","organizations_url":"https://api.github.com/users/seemethere/orgs","repos_url":"https://api.github.com/users/seemethere/repos","events_url":"https://api.github.com/users/seemethere/events{/privacy}","received_events_url":"https://api.github.com/users/seemethere/received_events","type":"User","site_admin":false},"body":"Cherry-picked from: docker/cli#144\r\n\r\nCommit 78c204ef798c7380e11ba26e5cd231e04fc6efe4 added\r\n(f9bd8ec8b268581f93095c5a80679f0a8ff498bf in the moby repo)\r\na validation to prevent `--rollback` from being used\r\nin combination with other flags that update the\r\nservice spec.\r\n\r\nThis validation was not taking into account that\r\nsome flags only affect the CLI behavior, and\r\nare okay to be used when rolling back.\r\n\r\nThis patch updates the validation, and adds\r\n`--quiet` and `--detach` to the list of allowed\r\nflags.\r\n\r\nSigned-off-by: Sebastiaan van Stijn <github@gone.nl>\r\n(cherry picked from commit f10f29df8d7ffede3faa29120a06c199e52a1d0c)\r\nSigned-off-by: Eli Uriegas <eli.uriegas@docker.com>\r\n","created_at":"2017-06-10T00:32:11Z","updated_at":"2017-06-10T22:48:54Z","closed_at":"2017-06-10T22:48:54Z","merged_at":"2017-06-10T22:48:54Z","merge_commit_sha":"47c1b00158aad7ae4c84af4af6955c760dbc73b5","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/docker/docker-ce/pulls/60/commits","review_comments_url":"https://api.github.com/repos/docker/docker-ce/pulls/60/comments","review_comment_url":"https://api.github.com/repos/docker/docker-ce/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/docker-ce/issues/60/comments","statuses_url":"https://api.github.com/repos/docker/docker-ce/statuses/5ed0b2e10c03ec6d5c0fd5e14886cda012f25e3a","head":{"label":"seemethere:cherry_pick_144","ref":"cherry_pick_144","sha":"5ed0b2e10c03ec6d5c0fd5e14886cda012f25e3a","user":{"login":"seemethere","id":1700823,"avatar_url":"https://avatars1.githubusercontent.com/u/1700823?v=3","gravatar_id":"","url":"https://api.github.com/users/seemethere","html_url":"https://github.com/seemethere","followers_url":"https://api.github.com/users/seemethere/followers","following_url":"https://api.github.com/users/seemethere/following{/other_user}","gists_url":"https://api.github.com/users/seemethere/gists{/gist_id}","starred_url":"https://api.github.com/users/seemethere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seemethere/subscriptions","organizations_url":"https://api.github.com/users/seemethere/orgs","repos_url":"https://api.github.com/users/seemethere/repos","events_url":"https://api.github.com/users/seemethere/events{/privacy}","received_events_url":"https://api.github.com/users/seemethere/received_events","type":"User","site_admin":false},"repo":{"id":93083277,"name":"docker-ce","full_name":"seemethere/docker-ce","owner":{"login":"seemethere","id":1700823,"avatar_url":"https://avatars1.githubusercontent.com/u/1700823?v=3","gravatar_id":"","url":"https://api.github.com/users/seemethere","html_url":"https://github.com/seemethere","followers_url":"https://api.github.com/users/seemethere/followers","following_url":"https://api.github.com/users/seemethere/following{/other_user}","gists_url":"https://api.github.com/users/seemethere/gists{/gist_id}","starred_url":"https://api.github.com/users/seemethere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seemethere/subscriptions","organizations_url":"https://api.github.com/users/seemethere/orgs","repos_url":"https://api.github.com/users/seemethere/repos","events_url":"https://api.github.com/users/seemethere/events{/privacy}","received_events_url":"https://api.github.com/users/seemethere/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/seemethere/docker-ce","description":"Docker CE","fork":true,"url":"https://api.github.com/repos/seemethere/docker-ce","forks_url":"https://api.github.com/repos/seemethere/docker-ce/forks","keys_url":"https://api.github.com/repos/seemethere/docker-ce/keys{/key_id}","collaborators_url":"https://api.github.com/repos/seemethere/docker-ce/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/seemethere/docker-ce/teams","hooks_url":"https://api.github.com/repos/seemethere/docker-ce/hooks","issue_events_url":"https://api.github.com/repos/seemethere/docker-ce/issues/events{/number}","events_url":"https://api.github.com/repos/seemethere/docker-ce/events","assignees_url":"https://api.github.com/repos/seemethere/docker-ce/assignees{/user}","branches_url":"https://api.github.com/repos/seemethere/docker-ce/branches{/branch}","tags_url":"https://api.github.com/repos/seemethere/docker-ce/tags","blobs_url":"https://api.github.com/repos/seemethere/docker-ce/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/seemethere/docker-ce/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/seemethere/docker-ce/git/refs{/sha}","trees_url":"https://api.github.com/repos/seemethere/docker-ce/git/trees{/sha}","statuses_url":"https://api.github.com/repos/seemethere/docker-ce/statuses/{sha}","languages_url":"https://api.github.com/repos/seemethere/docker-ce/languages","stargazers_url":"https://api.github.com/repos/seemethere/docker-ce/stargazers","contributors_url":"https://api.github.com/repos/seemethere/docker-ce/contributors","subscribers_url":"https://api.github.com/repos/seemethere/docker-ce/subscribers","subscription_url":"https://api.github.com/repos/seemethere/docker-ce/subscription","commits_url":"https://api.github.com/repos/seemethere/docker-ce/commits{/sha}","git_commits_url":"https://api.github.com/repos/seemethere/docker-ce/git/commits{/sha}","comments_url":"https://api.github.com/repos/seemethere/docker-ce/comments{/number}","issue_comment_url":"https://api.github.com/repos/seemethere/docker-ce/issues/comments{/number}","contents_url":"https://api.github.com/repos/seemethere/docker-ce/contents/{+path}","compare_url":"https://api.github.com/repos/seemethere/docker-ce/compare/{base}...{head}","merges_url":"https://api.github.com/repos/seemethere/docker-ce/merges","archive_url":"https://api.github.com/repos/seemethere/docker-ce/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/seemethere/docker-ce/downloads","issues_url":"https://api.github.com/repos/seemethere/docker-ce/issues{/number}","pulls_url":"https://api.github.com/repos/seemethere/docker-ce/pulls{/number}","milestones_url":"https://api.github.com/repos/seemethere/docker-ce/milestones{/number}","notifications_url":"https://api.github.com/repos/seemethere/docker-ce/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/seemethere/docker-ce/labels{/name}","releases_url":"https://api.github.com/repos/seemethere/docker-ce/releases{/id}","deployments_url":"https://api.github.com/repos/seemethere/docker-ce/deployments","created_at":"2017-06-01T17:36:39Z","updated_at":"2017-06-01T17:36:47Z","pushed_at":"2017-06-10T00:38:15Z","git_url":"git://github.com/seemethere/docker-ce.git","ssh_url":"git@github.com:seemethere/docker-ce.git","clone_url":"https://github.com/seemethere/docker-ce.git","svn_url":"https://github.com/seemethere/docker-ce","homepage":"https://www.docker.com/community-edition","size":127107,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:17.06","ref":"17.06","sha":"897b692e1cef474773f021053e7bc3880bbf96c5","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars2.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":91851756,"name":"docker-ce","full_name":"docker/docker-ce","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars2.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/docker-ce","description":"Docker CE","fork":false,"url":"https://api.github.com/repos/docker/docker-ce","forks_url":"https://api.github.com/repos/docker/docker-ce/forks","keys_url":"https://api.github.com/repos/docker/docker-ce/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/docker-ce/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/docker-ce/teams","hooks_url":"https://api.github.com/repos/docker/docker-ce/hooks","issue_events_url":"https://api.github.com/repos/docker/docker-ce/issues/events{/number}","events_url":"https://api.github.com/repos/docker/docker-ce/events","assignees_url":"https://api.github.com/repos/docker/docker-ce/assignees{/user}","branches_url":"https://api.github.com/repos/docker/docker-ce/branches{/branch}","tags_url":"https://api.github.com/repos/docker/docker-ce/tags","blobs_url":"https://api.github.com/repos/docker/docker-ce/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/docker-ce/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/docker-ce/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/docker-ce/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/docker-ce/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/docker-ce/languages","stargazers_url":"https://api.github.com/repos/docker/docker-ce/stargazers","contributors_url":"https://api.github.com/repos/docker/docker-ce/contributors","subscribers_url":"https://api.github.com/repos/docker/docker-ce/subscribers","subscription_url":"https://api.github.com/repos/docker/docker-ce/subscription","commits_url":"https://api.github.com/repos/docker/docker-ce/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/docker-ce/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/docker-ce/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/docker-ce/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/docker-ce/contents/{+path}","compare_url":"https://api.github.com/repos/docker/docker-ce/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/docker-ce/merges","archive_url":"https://api.github.com/repos/docker/docker-ce/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/docker-ce/downloads","issues_url":"https://api.github.com/repos/docker/docker-ce/issues{/number}","pulls_url":"https://api.github.com/repos/docker/docker-ce/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/docker-ce/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/docker-ce/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/docker-ce/labels{/name}","releases_url":"https://api.github.com/repos/docker/docker-ce/releases{/id}","deployments_url":"https://api.github.com/repos/docker/docker-ce/deployments","created_at":"2017-05-19T23:09:47Z","updated_at":"2017-06-10T17:41:02Z","pushed_at":"2017-06-10T22:48:54Z","git_url":"git://github.com/docker/docker-ce.git","ssh_url":"git@github.com:docker/docker-ce.git","clone_url":"https://github.com/docker/docker-ce.git","svn_url":"https://github.com/docker/docker-ce","homepage":"https://www.docker.com/community-edition","size":127088,"stargazers_count":52,"watchers_count":52,"language":"Go","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":22,"mirror_url":null,"open_issues_count":8,"forks":22,"open_issues":8,"watchers":52,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/docker-ce/pulls/60"},"html":{"href":"https://github.com/docker/docker-ce/pull/60"},"issue":{"href":"https://api.github.com/repos/docker/docker-ce/issues/60"},"comments":{"href":"https://api.github.com/repos/docker/docker-ce/issues/60/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/docker-ce/pulls/60/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/docker-ce/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/docker-ce/pulls/60/commits"},"statuses":{"href":"https://api.github.com/repos/docker/docker-ce/statuses/5ed0b2e10c03ec6d5c0fd5e14886cda012f25e3a"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"andrewhsu","id":57640,"avatar_url":"https://avatars3.githubusercontent.com/u/57640?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewhsu","html_url":"https://github.com/andrewhsu","followers_url":"https://api.github.com/users/andrewhsu/followers","following_url":"https://api.github.com/users/andrewhsu/following{/other_user}","gists_url":"https://api.github.com/users/andrewhsu/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewhsu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewhsu/subscriptions","organizations_url":"https://api.github.com/users/andrewhsu/orgs","repos_url":"https://api.github.com/users/andrewhsu/repos","events_url":"https://api.github.com/users/andrewhsu/events{/privacy}","received_events_url":"https://api.github.com/users/andrewhsu/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"andrewhsu"}}