{"action":"created","issue":{"url":"https://api.github.com/repos/Financial-Times/o-share/issues/100","repository_url":"https://api.github.com/repos/Financial-Times/o-share","labels_url":"https://api.github.com/repos/Financial-Times/o-share/issues/100/labels{/name}","comments_url":"https://api.github.com/repos/Financial-Times/o-share/issues/100/comments","events_url":"https://api.github.com/repos/Financial-Times/o-share/issues/100/events","html_url":"https://github.com/Financial-Times/o-share/pull/100","id":265684997,"number":100,"title":"Remove the incorrect use of <i> tag","user":{"login":"GlynnPhillips","id":524573,"avatar_url":"https://avatars0.githubusercontent.com/u/524573?v=4","gravatar_id":"","url":"https://api.github.com/users/GlynnPhillips","html_url":"https://github.com/GlynnPhillips","followers_url":"https://api.github.com/users/GlynnPhillips/followers","following_url":"https://api.github.com/users/GlynnPhillips/following{/other_user}","gists_url":"https://api.github.com/users/GlynnPhillips/gists{/gist_id}","starred_url":"https://api.github.com/users/GlynnPhillips/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GlynnPhillips/subscriptions","organizations_url":"https://api.github.com/users/GlynnPhillips/orgs","repos_url":"https://api.github.com/users/GlynnPhillips/repos","events_url":"https://api.github.com/users/GlynnPhillips/events{/privacy}","received_events_url":"https://api.github.com/users/GlynnPhillips/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-10-16T08:27:10Z","updated_at":"2017-10-16T09:30:01Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/Financial-Times/o-share/pulls/100","html_url":"https://github.com/Financial-Times/o-share/pull/100","diff_url":"https://github.com/Financial-Times/o-share/pull/100.diff","patch_url":"https://github.com/Financial-Times/o-share/pull/100.patch"},"body":"Whilst I was looking at suggesting a different change to this component I noticed this use of the `<i>` and how the styles selectors were using it. I felt that future suggestions might be easier if this was updated first.\r\n\r\nI am aware this will be a breaking change and released as a new major version, so the documentation will need updating. I thought it was best to check first if this is a change that you will be happy with before writing the docs. If it is I will update the docs as part of this PR.\r\n\r\nIssues addressed\r\n- Remove the use of `<i>` tags\r\n- Remove type css selectors so consumer app has more control over the markup\r\n- Make it easier for future buttons to have icons and text"},"comment":{"url":"https://api.github.com/repos/Financial-Times/o-share/issues/comments/336832031","html_url":"https://github.com/Financial-Times/o-share/pull/100#issuecomment-336832031","issue_url":"https://api.github.com/repos/Financial-Times/o-share/issues/100","id":336832031,"user":{"login":"notlee","id":10405691,"avatar_url":"https://avatars3.githubusercontent.com/u/10405691?v=4","gravatar_id":"","url":"https://api.github.com/users/notlee","html_url":"https://github.com/notlee","followers_url":"https://api.github.com/users/notlee/followers","following_url":"https://api.github.com/users/notlee/following{/other_user}","gists_url":"https://api.github.com/users/notlee/gists{/gist_id}","starred_url":"https://api.github.com/users/notlee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/notlee/subscriptions","organizations_url":"https://api.github.com/users/notlee/orgs","repos_url":"https://api.github.com/users/notlee/repos","events_url":"https://api.github.com/users/notlee/events{/privacy}","received_events_url":"https://api.github.com/users/notlee/received_events","type":"User","site_admin":false},"created_at":"2017-10-16T09:30:01Z","updated_at":"2017-10-16T09:30:01Z","author_association":"NONE","body":"This looks great @GlynnPhillips! 👏 \r\n\r\nCouple of small things I spotted, the `.o-share__action button` and `.o-share__action a` styles should probably be moved under `.o-share__icon` too, so `.o-share__icon` can be used independently of `.o-share__action`. Here's how it looks if  `.o-share__icon` is a child of  `.o-share`.\r\n<img width=\"58\" alt=\"screen shot 2017-10-16 at 10 27 49\" src=\"https://user-images.githubusercontent.com/10405691/31604963-cff355f8-b25c-11e7-8d57-5f7c3a029bb3.png\">\r\nhttps://github.com/Financial-Times/o-share/pull/100/files#diff-9306c3c5f377e5a17434829af3af789fR33\r\n\r\nAnd `white-space: nowrap;` would be a nice addition to `.o-share__text`.\r\nhttps://medium.com/@jessebeach/beware-smushed-off-screen-accessible-text-5952a4c2cbfe\r\nhttps://github.com/Financial-Times/o-share/pull/100/files#diff-9306c3c5f377e5a17434829af3af789fR47"}}
{"actor":{"display_login":"notlee"}}