{"action":"created","comment":{"url":"https://api.github.com/repos/socrata/cetera/pulls/comments/103349562","pull_request_review_id":24132742,"id":103349562,"diff_hunk":"@@ -10,6 +10,9 @@ import com.socrata.cetera._\n import com.socrata.cetera.response.InternalTimings\n \n object LogHelper {\n+  val PathSeparator = \"/\"","path":"cetera-http/src/main/scala/com/socrata/cetera/util/LogHelper.scala","position":4,"original_position":4,"commit_id":"43cec80982489ae47be02095cefd63caec81405b","original_commit_id":"43cec80982489ae47be02095cefd63caec81405b","user":{"login":"aynleslie","id":6155686,"avatar_url":"https://avatars.githubusercontent.com/u/6155686?v=3","gravatar_id":"","url":"https://api.github.com/users/aynleslie","html_url":"https://github.com/aynleslie","followers_url":"https://api.github.com/users/aynleslie/followers","following_url":"https://api.github.com/users/aynleslie/following{/other_user}","gists_url":"https://api.github.com/users/aynleslie/gists{/gist_id}","starred_url":"https://api.github.com/users/aynleslie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aynleslie/subscriptions","organizations_url":"https://api.github.com/users/aynleslie/orgs","repos_url":"https://api.github.com/users/aynleslie/repos","events_url":"https://api.github.com/users/aynleslie/events{/privacy}","received_events_url":"https://api.github.com/users/aynleslie/received_events","type":"User","site_admin":false},"body":"all changes related to scalastyle and string reuse.","created_at":"2017-02-28T00:33:11Z","updated_at":"2017-02-28T00:33:11Z","html_url":"https://github.com/socrata/cetera/pull/255#discussion_r103349562","pull_request_url":"https://api.github.com/repos/socrata/cetera/pulls/255","_links":{"self":{"href":"https://api.github.com/repos/socrata/cetera/pulls/comments/103349562"},"html":{"href":"https://github.com/socrata/cetera/pull/255#discussion_r103349562"},"pull_request":{"href":"https://api.github.com/repos/socrata/cetera/pulls/255"}}},"pull_request":{"url":"https://api.github.com/repos/socrata/cetera/pulls/255","id":108232018,"html_url":"https://github.com/socrata/cetera/pull/255","diff_url":"https://github.com/socrata/cetera/pull/255.diff","patch_url":"https://github.com/socrata/cetera/pull/255.patch","issue_url":"https://api.github.com/repos/socrata/cetera/issues/255","number":255,"state":"open","locked":false,"title":"EN-12739 (part 2) have the domainCountService respect params","user":{"login":"aynleslie","id":6155686,"avatar_url":"https://avatars.githubusercontent.com/u/6155686?v=3","gravatar_id":"","url":"https://api.github.com/users/aynleslie","html_url":"https://github.com/aynleslie","followers_url":"https://api.github.com/users/aynleslie/followers","following_url":"https://api.github.com/users/aynleslie/following{/other_user}","gists_url":"https://api.github.com/users/aynleslie/gists{/gist_id}","starred_url":"https://api.github.com/users/aynleslie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aynleslie/subscriptions","organizations_url":"https://api.github.com/users/aynleslie/orgs","repos_url":"https://api.github.com/users/aynleslie/repos","events_url":"https://api.github.com/users/aynleslie/events{/privacy}","received_events_url":"https://api.github.com/users/aynleslie/received_events","type":"User","site_admin":false},"body":"#### What it do?\r\n\r\nBasically speaking it makes the domainCountService respect params.  A few notes on that:\r\n\r\n- as far as I could tell from my research and attempts, elasticsearch 1.7 can't support parent aggregations of children with queries, only filters. So you'll see several new category/tags filters that are to be applied in the searchParamsFilter if searching over domains. This also means I found no way to support the `q` param\r\n- rather than make every damn filter take a `domainAgg` boolean, I changed the DocumentFilters to be a class and made that a class field.  Happy to change the name of that arg btw. \r\n\r\nI also cleaned up the remaining scalaStyle warnings.\r\n\r\n#### How was it tested?\r\n\r\nI wrote boatloads of new tests in the DomainCountServiceSpec. and new tests for each of the category/tag filters I created. I also removed a lot of the duplication found in the DocumentFiltersSpec by adding `behaveLike` functions.\r\n\r\nI compared my local results to the staging results for each of these endpoints:\r\n\r\n- catalog/domains\r\n- catalog/domains?domains=stories.test-socrata.com\r\n- catalog/domains?search_context=stories.test-socrata.com \r\n- /catalog/domains?search_context=disco-cheetah1.test-socrata.com  (has RA and moderation)\r\n- /catalog/domains?domains=disco-cheetah2.test-socrata.com\\&search_context=disco-cheetah2.test-socrata.com\\&tags=spu\r\n- /catalog/domains?domains=disco-cheetah2.test-socrata.com\\&search_context=disco-cheetah2.test-socrata.com\\&categories=Fun\r\n- /catalog/domains?domains=disco-cheetah2.test-socrata.com\\&search_context=disco-cheetah2.test-socrata.com\\&only=links\r\n","created_at":"2017-02-28T00:20:16Z","updated_at":"2017-02-28T00:33:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1fe55d79f2b86cb665c6e3a5fe8762dcabd25211","assignee":{"login":"rlvoyer","id":172413,"avatar_url":"https://avatars.githubusercontent.com/u/172413?v=3","gravatar_id":"","url":"https://api.github.com/users/rlvoyer","html_url":"https://github.com/rlvoyer","followers_url":"https://api.github.com/users/rlvoyer/followers","following_url":"https://api.github.com/users/rlvoyer/following{/other_user}","gists_url":"https://api.github.com/users/rlvoyer/gists{/gist_id}","starred_url":"https://api.github.com/users/rlvoyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rlvoyer/subscriptions","organizations_url":"https://api.github.com/users/rlvoyer/orgs","repos_url":"https://api.github.com/users/rlvoyer/repos","events_url":"https://api.github.com/users/rlvoyer/events{/privacy}","received_events_url":"https://api.github.com/users/rlvoyer/received_events","type":"User","site_admin":false},"assignees":[{"login":"rlvoyer","id":172413,"avatar_url":"https://avatars.githubusercontent.com/u/172413?v=3","gravatar_id":"","url":"https://api.github.com/users/rlvoyer","html_url":"https://github.com/rlvoyer","followers_url":"https://api.github.com/users/rlvoyer/followers","following_url":"https://api.github.com/users/rlvoyer/following{/other_user}","gists_url":"https://api.github.com/users/rlvoyer/gists{/gist_id}","starred_url":"https://api.github.com/users/rlvoyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rlvoyer/subscriptions","organizations_url":"https://api.github.com/users/rlvoyer/orgs","repos_url":"https://api.github.com/users/rlvoyer/repos","events_url":"https://api.github.com/users/rlvoyer/events{/privacy}","received_events_url":"https://api.github.com/users/rlvoyer/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/socrata/cetera/pulls/255/commits","review_comments_url":"https://api.github.com/repos/socrata/cetera/pulls/255/comments","review_comment_url":"https://api.github.com/repos/socrata/cetera/pulls/comments{/number}","comments_url":"https://api.github.com/repos/socrata/cetera/issues/255/comments","statuses_url":"https://api.github.com/repos/socrata/cetera/statuses/43cec80982489ae47be02095cefd63caec81405b","head":{"label":"socrata:ayn/en-12739/respect-params-part-2","ref":"ayn/en-12739/respect-params-part-2","sha":"43cec80982489ae47be02095cefd63caec81405b","user":{"login":"socrata","id":57695,"avatar_url":"https://avatars.githubusercontent.com/u/57695?v=3","gravatar_id":"","url":"https://api.github.com/users/socrata","html_url":"https://github.com/socrata","followers_url":"https://api.github.com/users/socrata/followers","following_url":"https://api.github.com/users/socrata/following{/other_user}","gists_url":"https://api.github.com/users/socrata/gists{/gist_id}","starred_url":"https://api.github.com/users/socrata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/socrata/subscriptions","organizations_url":"https://api.github.com/users/socrata/orgs","repos_url":"https://api.github.com/users/socrata/repos","events_url":"https://api.github.com/users/socrata/events{/privacy}","received_events_url":"https://api.github.com/users/socrata/received_events","type":"Organization","site_admin":false},"repo":{"id":29320951,"name":"cetera","full_name":"socrata/cetera","owner":{"login":"socrata","id":57695,"avatar_url":"https://avatars.githubusercontent.com/u/57695?v=3","gravatar_id":"","url":"https://api.github.com/users/socrata","html_url":"https://github.com/socrata","followers_url":"https://api.github.com/users/socrata/followers","following_url":"https://api.github.com/users/socrata/following{/other_user}","gists_url":"https://api.github.com/users/socrata/gists{/gist_id}","starred_url":"https://api.github.com/users/socrata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/socrata/subscriptions","organizations_url":"https://api.github.com/users/socrata/orgs","repos_url":"https://api.github.com/users/socrata/repos","events_url":"https://api.github.com/users/socrata/events{/privacy}","received_events_url":"https://api.github.com/users/socrata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/socrata/cetera","description":"Cetera -- the golden-throated search service. Basically a wrapper around elasticsearch to enable keyword search to return dataset metadata for use by the front end in displaying search results.","fork":false,"url":"https://api.github.com/repos/socrata/cetera","forks_url":"https://api.github.com/repos/socrata/cetera/forks","keys_url":"https://api.github.com/repos/socrata/cetera/keys{/key_id}","collaborators_url":"https://api.github.com/repos/socrata/cetera/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/socrata/cetera/teams","hooks_url":"https://api.github.com/repos/socrata/cetera/hooks","issue_events_url":"https://api.github.com/repos/socrata/cetera/issues/events{/number}","events_url":"https://api.github.com/repos/socrata/cetera/events","assignees_url":"https://api.github.com/repos/socrata/cetera/assignees{/user}","branches_url":"https://api.github.com/repos/socrata/cetera/branches{/branch}","tags_url":"https://api.github.com/repos/socrata/cetera/tags","blobs_url":"https://api.github.com/repos/socrata/cetera/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/socrata/cetera/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/socrata/cetera/git/refs{/sha}","trees_url":"https://api.github.com/repos/socrata/cetera/git/trees{/sha}","statuses_url":"https://api.github.com/repos/socrata/cetera/statuses/{sha}","languages_url":"https://api.github.com/repos/socrata/cetera/languages","stargazers_url":"https://api.github.com/repos/socrata/cetera/stargazers","contributors_url":"https://api.github.com/repos/socrata/cetera/contributors","subscribers_url":"https://api.github.com/repos/socrata/cetera/subscribers","subscription_url":"https://api.github.com/repos/socrata/cetera/subscription","commits_url":"https://api.github.com/repos/socrata/cetera/commits{/sha}","git_commits_url":"https://api.github.com/repos/socrata/cetera/git/commits{/sha}","comments_url":"https://api.github.com/repos/socrata/cetera/comments{/number}","issue_comment_url":"https://api.github.com/repos/socrata/cetera/issues/comments{/number}","contents_url":"https://api.github.com/repos/socrata/cetera/contents/{+path}","compare_url":"https://api.github.com/repos/socrata/cetera/compare/{base}...{head}","merges_url":"https://api.github.com/repos/socrata/cetera/merges","archive_url":"https://api.github.com/repos/socrata/cetera/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/socrata/cetera/downloads","issues_url":"https://api.github.com/repos/socrata/cetera/issues{/number}","pulls_url":"https://api.github.com/repos/socrata/cetera/pulls{/number}","milestones_url":"https://api.github.com/repos/socrata/cetera/milestones{/number}","notifications_url":"https://api.github.com/repos/socrata/cetera/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/socrata/cetera/labels{/name}","releases_url":"https://api.github.com/repos/socrata/cetera/releases{/id}","deployments_url":"https://api.github.com/repos/socrata/cetera/deployments","created_at":"2015-01-15T22:15:58Z","updated_at":"2017-02-12T15:33:40Z","pushed_at":"2017-02-28T00:20:16Z","git_url":"git://github.com/socrata/cetera.git","ssh_url":"git@github.com:socrata/cetera.git","clone_url":"https://github.com/socrata/cetera.git","svn_url":"https://github.com/socrata/cetera","homepage":"","size":1441,"stargazers_count":11,"watchers_count":11,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":9,"forks":2,"open_issues":9,"watchers":11,"default_branch":"master"}},"base":{"label":"socrata:merge-me-post-summit","ref":"merge-me-post-summit","sha":"8ab1119c4d70fdef3393180abc429463a3471e9c","user":{"login":"socrata","id":57695,"avatar_url":"https://avatars.githubusercontent.com/u/57695?v=3","gravatar_id":"","url":"https://api.github.com/users/socrata","html_url":"https://github.com/socrata","followers_url":"https://api.github.com/users/socrata/followers","following_url":"https://api.github.com/users/socrata/following{/other_user}","gists_url":"https://api.github.com/users/socrata/gists{/gist_id}","starred_url":"https://api.github.com/users/socrata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/socrata/subscriptions","organizations_url":"https://api.github.com/users/socrata/orgs","repos_url":"https://api.github.com/users/socrata/repos","events_url":"https://api.github.com/users/socrata/events{/privacy}","received_events_url":"https://api.github.com/users/socrata/received_events","type":"Organization","site_admin":false},"repo":{"id":29320951,"name":"cetera","full_name":"socrata/cetera","owner":{"login":"socrata","id":57695,"avatar_url":"https://avatars.githubusercontent.com/u/57695?v=3","gravatar_id":"","url":"https://api.github.com/users/socrata","html_url":"https://github.com/socrata","followers_url":"https://api.github.com/users/socrata/followers","following_url":"https://api.github.com/users/socrata/following{/other_user}","gists_url":"https://api.github.com/users/socrata/gists{/gist_id}","starred_url":"https://api.github.com/users/socrata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/socrata/subscriptions","organizations_url":"https://api.github.com/users/socrata/orgs","repos_url":"https://api.github.com/users/socrata/repos","events_url":"https://api.github.com/users/socrata/events{/privacy}","received_events_url":"https://api.github.com/users/socrata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/socrata/cetera","description":"Cetera -- the golden-throated search service. Basically a wrapper around elasticsearch to enable keyword search to return dataset metadata for use by the front end in displaying search results.","fork":false,"url":"https://api.github.com/repos/socrata/cetera","forks_url":"https://api.github.com/repos/socrata/cetera/forks","keys_url":"https://api.github.com/repos/socrata/cetera/keys{/key_id}","collaborators_url":"https://api.github.com/repos/socrata/cetera/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/socrata/cetera/teams","hooks_url":"https://api.github.com/repos/socrata/cetera/hooks","issue_events_url":"https://api.github.com/repos/socrata/cetera/issues/events{/number}","events_url":"https://api.github.com/repos/socrata/cetera/events","assignees_url":"https://api.github.com/repos/socrata/cetera/assignees{/user}","branches_url":"https://api.github.com/repos/socrata/cetera/branches{/branch}","tags_url":"https://api.github.com/repos/socrata/cetera/tags","blobs_url":"https://api.github.com/repos/socrata/cetera/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/socrata/cetera/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/socrata/cetera/git/refs{/sha}","trees_url":"https://api.github.com/repos/socrata/cetera/git/trees{/sha}","statuses_url":"https://api.github.com/repos/socrata/cetera/statuses/{sha}","languages_url":"https://api.github.com/repos/socrata/cetera/languages","stargazers_url":"https://api.github.com/repos/socrata/cetera/stargazers","contributors_url":"https://api.github.com/repos/socrata/cetera/contributors","subscribers_url":"https://api.github.com/repos/socrata/cetera/subscribers","subscription_url":"https://api.github.com/repos/socrata/cetera/subscription","commits_url":"https://api.github.com/repos/socrata/cetera/commits{/sha}","git_commits_url":"https://api.github.com/repos/socrata/cetera/git/commits{/sha}","comments_url":"https://api.github.com/repos/socrata/cetera/comments{/number}","issue_comment_url":"https://api.github.com/repos/socrata/cetera/issues/comments{/number}","contents_url":"https://api.github.com/repos/socrata/cetera/contents/{+path}","compare_url":"https://api.github.com/repos/socrata/cetera/compare/{base}...{head}","merges_url":"https://api.github.com/repos/socrata/cetera/merges","archive_url":"https://api.github.com/repos/socrata/cetera/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/socrata/cetera/downloads","issues_url":"https://api.github.com/repos/socrata/cetera/issues{/number}","pulls_url":"https://api.github.com/repos/socrata/cetera/pulls{/number}","milestones_url":"https://api.github.com/repos/socrata/cetera/milestones{/number}","notifications_url":"https://api.github.com/repos/socrata/cetera/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/socrata/cetera/labels{/name}","releases_url":"https://api.github.com/repos/socrata/cetera/releases{/id}","deployments_url":"https://api.github.com/repos/socrata/cetera/deployments","created_at":"2015-01-15T22:15:58Z","updated_at":"2017-02-12T15:33:40Z","pushed_at":"2017-02-28T00:20:16Z","git_url":"git://github.com/socrata/cetera.git","ssh_url":"git@github.com:socrata/cetera.git","clone_url":"https://github.com/socrata/cetera.git","svn_url":"https://github.com/socrata/cetera","homepage":"","size":1441,"stargazers_count":11,"watchers_count":11,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":9,"forks":2,"open_issues":9,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/socrata/cetera/pulls/255"},"html":{"href":"https://github.com/socrata/cetera/pull/255"},"issue":{"href":"https://api.github.com/repos/socrata/cetera/issues/255"},"comments":{"href":"https://api.github.com/repos/socrata/cetera/issues/255/comments"},"review_comments":{"href":"https://api.github.com/repos/socrata/cetera/pulls/255/comments"},"review_comment":{"href":"https://api.github.com/repos/socrata/cetera/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/socrata/cetera/pulls/255/commits"},"statuses":{"href":"https://api.github.com/repos/socrata/cetera/statuses/43cec80982489ae47be02095cefd63caec81405b"}}}}
{"actor":{"display_login":"aynleslie"}}