{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/147252765","pull_request_review_id":72324518,"id":147252765,"diff_hunk":"@@ -0,0 +1,14 @@\n+'use strict';\n+require('../common');\n+const assert = require('assert');\n+const { execFileSync } = require('child_process');\n+\n+const node = process.argv[0];\n+\n+try {\n+  execFileSync(node, ['--experimental-modules', 'test/es-module/test-esm-ok']);\n+} catch (e) {","path":"test/parallel/test-module-main-extensions.js","position":10,"original_position":10,"commit_id":"07e09ca16eb81060388eea5740e5d0b0bd7765dc","original_commit_id":"07e09ca16eb81060388eea5740e5d0b0bd7765dc","user":{"login":"addaleax","id":899444,"avatar_url":"https://avatars2.githubusercontent.com/u/899444?v=4","gravatar_id":"","url":"https://api.github.com/users/addaleax","html_url":"https://github.com/addaleax","followers_url":"https://api.github.com/users/addaleax/followers","following_url":"https://api.github.com/users/addaleax/following{/other_user}","gists_url":"https://api.github.com/users/addaleax/gists{/gist_id}","starred_url":"https://api.github.com/users/addaleax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/addaleax/subscriptions","organizations_url":"https://api.github.com/users/addaleax/orgs","repos_url":"https://api.github.com/users/addaleax/repos","events_url":"https://api.github.com/users/addaleax/events{/privacy}","received_events_url":"https://api.github.com/users/addaleax/received_events","type":"User","site_admin":false},"body":"Should this ever throw an exception?","created_at":"2017-10-26T20:09:16Z","updated_at":"2017-10-26T20:09:46Z","html_url":"https://github.com/nodejs/node/pull/16526#discussion_r147252765","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/16526","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/147252765"},"html":{"href":"https://github.com/nodejs/node/pull/16526#discussion_r147252765"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/16526"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/16526","id":149029964,"html_url":"https://github.com/nodejs/node/pull/16526","diff_url":"https://github.com/nodejs/node/pull/16526.diff","patch_url":"https://github.com/nodejs/node/pull/16526.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/16526","number":16526,"state":"open","locked":false,"title":"module: fixes #16476 ensuring extension lookups for top main","user":{"login":"guybedford","id":598730,"avatar_url":"https://avatars1.githubusercontent.com/u/598730?v=4","gravatar_id":"","url":"https://api.github.com/users/guybedford","html_url":"https://github.com/guybedford","followers_url":"https://api.github.com/users/guybedford/followers","following_url":"https://api.github.com/users/guybedford/following{/other_user}","gists_url":"https://api.github.com/users/guybedford/gists{/gist_id}","starred_url":"https://api.github.com/users/guybedford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guybedford/subscriptions","organizations_url":"https://api.github.com/users/guybedford/orgs","repos_url":"https://api.github.com/users/guybedford/repos","events_url":"https://api.github.com/users/guybedford/events{/privacy}","received_events_url":"https://api.github.com/users/guybedford/received_events","type":"User","site_admin":false},"body":"The reason as stated in https://github.com/nodejs/node/issues/16476#issuecomment-339637581 is that absolute URLs do not go through extension and index checks.\r\n\r\nBy switching to an absolute path, the resolver still applies extensions properly to the top-level main.\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines)\r\n\r\n##### Affected core subsystem(s)\r\n<!-- Provide affected core subsystem(s) (like doc, cluster, crypto, etc). -->\r\nesmodules","created_at":"2017-10-26T19:54:56Z","updated_at":"2017-10-26T20:09:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8ec48f9fcb260cb543a764d2256acf3b2094b3a7","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/16526/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/16526/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/16526/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/07e09ca16eb81060388eea5740e5d0b0bd7765dc","head":{"label":"guybedford:esm-main-extensions","ref":"esm-main-extensions","sha":"07e09ca16eb81060388eea5740e5d0b0bd7765dc","user":{"login":"guybedford","id":598730,"avatar_url":"https://avatars1.githubusercontent.com/u/598730?v=4","gravatar_id":"","url":"https://api.github.com/users/guybedford","html_url":"https://github.com/guybedford","followers_url":"https://api.github.com/users/guybedford/followers","following_url":"https://api.github.com/users/guybedford/following{/other_user}","gists_url":"https://api.github.com/users/guybedford/gists{/gist_id}","starred_url":"https://api.github.com/users/guybedford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guybedford/subscriptions","organizations_url":"https://api.github.com/users/guybedford/orgs","repos_url":"https://api.github.com/users/guybedford/repos","events_url":"https://api.github.com/users/guybedford/events{/privacy}","received_events_url":"https://api.github.com/users/guybedford/received_events","type":"User","site_admin":false},"repo":{"id":102259337,"name":"node","full_name":"guybedford/node","owner":{"login":"guybedford","id":598730,"avatar_url":"https://avatars1.githubusercontent.com/u/598730?v=4","gravatar_id":"","url":"https://api.github.com/users/guybedford","html_url":"https://github.com/guybedford","followers_url":"https://api.github.com/users/guybedford/followers","following_url":"https://api.github.com/users/guybedford/following{/other_user}","gists_url":"https://api.github.com/users/guybedford/gists{/gist_id}","starred_url":"https://api.github.com/users/guybedford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guybedford/subscriptions","organizations_url":"https://api.github.com/users/guybedford/orgs","repos_url":"https://api.github.com/users/guybedford/repos","events_url":"https://api.github.com/users/guybedford/events{/privacy}","received_events_url":"https://api.github.com/users/guybedford/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/guybedford/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/guybedford/node","forks_url":"https://api.github.com/repos/guybedford/node/forks","keys_url":"https://api.github.com/repos/guybedford/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guybedford/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guybedford/node/teams","hooks_url":"https://api.github.com/repos/guybedford/node/hooks","issue_events_url":"https://api.github.com/repos/guybedford/node/issues/events{/number}","events_url":"https://api.github.com/repos/guybedford/node/events","assignees_url":"https://api.github.com/repos/guybedford/node/assignees{/user}","branches_url":"https://api.github.com/repos/guybedford/node/branches{/branch}","tags_url":"https://api.github.com/repos/guybedford/node/tags","blobs_url":"https://api.github.com/repos/guybedford/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guybedford/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guybedford/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/guybedford/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guybedford/node/statuses/{sha}","languages_url":"https://api.github.com/repos/guybedford/node/languages","stargazers_url":"https://api.github.com/repos/guybedford/node/stargazers","contributors_url":"https://api.github.com/repos/guybedford/node/contributors","subscribers_url":"https://api.github.com/repos/guybedford/node/subscribers","subscription_url":"https://api.github.com/repos/guybedford/node/subscription","commits_url":"https://api.github.com/repos/guybedford/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/guybedford/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/guybedford/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/guybedford/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/guybedford/node/contents/{+path}","compare_url":"https://api.github.com/repos/guybedford/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guybedford/node/merges","archive_url":"https://api.github.com/repos/guybedford/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guybedford/node/downloads","issues_url":"https://api.github.com/repos/guybedford/node/issues{/number}","pulls_url":"https://api.github.com/repos/guybedford/node/pulls{/number}","milestones_url":"https://api.github.com/repos/guybedford/node/milestones{/number}","notifications_url":"https://api.github.com/repos/guybedford/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guybedford/node/labels{/name}","releases_url":"https://api.github.com/repos/guybedford/node/releases{/id}","deployments_url":"https://api.github.com/repos/guybedford/node/deployments","created_at":"2017-09-03T11:18:55Z","updated_at":"2017-09-03T11:19:32Z","pushed_at":"2017-10-26T19:52:58Z","git_url":"git://github.com/guybedford/node.git","ssh_url":"git@github.com:guybedford/node.git","clone_url":"https://github.com/guybedford/node.git","svn_url":"https://github.com/guybedford/node","homepage":"https://nodejs.org","size":321783,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"75f1087f49698903a24cca55939e472ad34d2273","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2017-10-26T19:32:49Z","pushed_at":"2017-10-26T20:08:35Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":328172,"stargazers_count":41293,"watchers_count":41293,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8536,"mirror_url":null,"archived":false,"open_issues_count":765,"forks":8536,"open_issues":765,"watchers":41293,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/16526"},"html":{"href":"https://github.com/nodejs/node/pull/16526"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/16526"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/16526/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/16526/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/16526/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/07e09ca16eb81060388eea5740e5d0b0bd7765dc"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"addaleax"}}