{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-guacamole-client/pulls/comments/138402116","pull_request_review_id":62192014,"id":138402116,"diff_hunk":"@@ -0,0 +1,357 @@\n+/*\n+ * Licensed to the Apache Software Foundation (ASF) under one\n+ * or more contributor license agreements.  See the NOTICE file\n+ * distributed with this work for additional information\n+ * regarding copyright ownership.  The ASF licenses this file\n+ * to you under the Apache License, Version 2.0 (the\n+ * \"License\"); you may not use this file except in compliance\n+ * with the License.  You may obtain a copy of the License at\n+ *\n+ *   http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing,\n+ * software distributed under the License is distributed on an\n+ * \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY\n+ * KIND, either express or implied.  See the License for the\n+ * specific language governing permissions and limitations\n+ * under the License.\n+ */\n+\n+package org.apache.guacamole.auth.sqlserver;\n+\n+import org.apache.guacamole.GuacamoleException;\n+import org.apache.guacamole.auth.jdbc.JDBCEnvironment;\n+import org.slf4j.Logger;\n+import org.slf4j.LoggerFactory;\n+import org.apache.guacamole.auth.jdbc.security.PasswordPolicy;\n+\n+/**\n+ * A SQLServer-specific implementation of JDBCEnvironment provides database\n+ * properties specifically for SQLServer.\n+ */\n+public class SQLServerEnvironment extends JDBCEnvironment {\n+\n+    /**\n+     * Logger for this class.\n+     */\n+    private static final Logger logger = LoggerFactory.getLogger(SQLServerEnvironment.class);\n+\n+    /**\n+     * The default host to connect to, if SQLSERVER_HOSTNAME is not specified.\n+     */\n+    private static final String DEFAULT_HOSTNAME = \"localhost\";\n+\n+    /**\n+     * The default port to connect to, if SQLSERVER_PORT is not specified.\n+     */\n+    private static final int DEFAULT_PORT = 1433;\n+\n+    /**\n+     * Whether a database user account is required by default for authentication\n+     * to succeed.\n+     */\n+    private static final boolean DEFAULT_USER_REQUIRED = true;\n+\n+    /**\n+     * The default value for the maximum number of connections to be\n+     * allowed to the Guacamole server overall.\n+     */\n+    private final int DEFAULT_ABSOLUTE_MAX_CONNECTIONS = 0;\n+\n+    /**\n+     * The default value for the default maximum number of connections to be\n+     * allowed per user to any one connection. Note that, as long as the\n+     * legacy \"disallow duplicate\" and \"disallow simultaneous\" properties are\n+     * still supported, these cannot be constants, as the legacy properties\n+     * dictate the values that should be used in the absence of the correct\n+     * properties.\n+     */\n+    private int DEFAULT_MAX_CONNECTIONS_PER_USER = 1;\n+\n+    /**\n+     * The default value for the default maximum number of connections to be\n+     * allowed per user to any one connection group. Note that, as long as the\n+     * legacy \"disallow duplicate\" and \"disallow simultaneous\" properties are\n+     * still supported, these cannot be constants, as the legacy properties\n+     * dictate the values that should be used in the absence of the correct\n+     * properties.\n+     */\n+    private int DEFAULT_MAX_GROUP_CONNECTIONS_PER_USER = 1;\n+\n+    /**\n+     * The default value for the default maximum number of connections to be\n+     * allowed to any one connection. Note that, as long as the legacy\n+     * \"disallow duplicate\" and \"disallow simultaneous\" properties are still\n+     * supported, these cannot be constants, as the legacy properties dictate\n+     * the values that should be used in the absence of the correct properties.\n+     */\n+    private int DEFAULT_MAX_CONNECTIONS = 0;\n+\n+    /**\n+     * The default value for the default maximum number of connections to be\n+     * allowed to any one connection group. Note that, as long as the legacy\n+     * \"disallow duplicate\" and \"disallow simultaneous\" properties are still\n+     * supported, these cannot be constants, as the legacy properties dictate\n+     * the values that should be used in the absence of the correct properties.\n+     */\n+    private int DEFAULT_MAX_GROUP_CONNECTIONS = 0;\n+\n+    /**\n+     * The value for the sqlserver-driver property that triggers the use of\n+     * the open source JTDS driver.\n+     */\n+    public final static String SQLSERVER_DRIVER_JTDS = \"jtds\";\n+\n+    /**\n+     * The value for the sqlserver-driver property that triggers the use of\n+     * the DataDirect JDBC driver.\n+     */\n+    public final static String SQLSERVER_DRIVER_DATADIRECT = \"datadirect\";\n+\n+    /**\n+     * The value for the sqlserver-driver property that triggers the use of\n+     * the older Microsoft JDBC driver.\n+     */\n+    public final static String SQLSERVER_DRIVER_MS = \"microsoft\";\n+\n+    /**\n+     * The value for the sqlserver-driver property that triggers the use of\n+     * the Microsoft JDBC driver.  This is the default.\n+     */\n+    public final static String SQLSERVER_DRIVER_MS_2005 = \"microsoft2005\";\n+\n+    /**\n+     * Constructs a new SQLServerEnvironment, providing access to SQLServer-specific\n+     * configuration options.\n+     * \n+     * @throws GuacamoleException \n+     *     If an error occurs while setting up the underlying JDBCEnvironment\n+     *     or while parsing legacy SQLServer configuration options.\n+     */\n+    public SQLServerEnvironment() throws GuacamoleException {\n+\n+        // Init underlying JDBC environment\n+        super();\n+\n+        // Read legacy concurrency-related property\n+        Boolean disallowSimultaneous = getProperty(SQLServerGuacamoleProperties.SQLSERVER_DISALLOW_SIMULTANEOUS_CONNECTIONS);\n+        Boolean disallowDuplicate    = getProperty(SQLServerGuacamoleProperties.SQLSERVER_DISALLOW_DUPLICATE_CONNECTIONS);\n+\n+        // Legacy \"simultaneous\" property dictates only the maximum number of\n+        // connections per connection\n+        if (disallowSimultaneous != null) {\n+\n+            // Translate legacy property\n+            if (disallowSimultaneous) {\n+                DEFAULT_MAX_CONNECTIONS       = 1;\n+                DEFAULT_MAX_GROUP_CONNECTIONS = 0;\n+            }\n+            else {\n+                DEFAULT_MAX_CONNECTIONS       = 0;\n+                DEFAULT_MAX_GROUP_CONNECTIONS = 0;\n+            }\n+\n+            // Warn of deprecation\n+            logger.warn(\"The \\\"{}\\\" property is deprecated. Use \\\"{}\\\" and \\\"{}\\\" instead.\",\n+                    SQLServerGuacamoleProperties.SQLSERVER_DISALLOW_SIMULTANEOUS_CONNECTIONS.getName(),\n+                    SQLServerGuacamoleProperties.SQLSERVER_DEFAULT_MAX_CONNECTIONS.getName(),\n+                    SQLServerGuacamoleProperties.SQLSERVER_DEFAULT_MAX_GROUP_CONNECTIONS.getName());\n+\n+            // Inform of new equivalent\n+            logger.info(\"To achieve the same result of setting \\\"{}\\\" to \\\"{}\\\", set \\\"{}\\\" to \\\"{}\\\" and \\\"{}\\\" to \\\"{}\\\".\",\n+                    SQLServerGuacamoleProperties.SQLSERVER_DISALLOW_SIMULTANEOUS_CONNECTIONS.getName(), disallowSimultaneous,\n+                    SQLServerGuacamoleProperties.SQLSERVER_DEFAULT_MAX_CONNECTIONS.getName(),           DEFAULT_MAX_CONNECTIONS,\n+                    SQLServerGuacamoleProperties.SQLSERVER_DEFAULT_MAX_GROUP_CONNECTIONS.getName(),     DEFAULT_MAX_GROUP_CONNECTIONS);\n+\n+        }\n+\n+        // Legacy \"duplicate\" property dictates whether connections and groups\n+        // may be used concurrently only by different users\n+        if (disallowDuplicate != null) {\n+\n+            // Translate legacy property\n+            if (disallowDuplicate) {\n+                DEFAULT_MAX_CONNECTIONS_PER_USER       = 1;\n+                DEFAULT_MAX_GROUP_CONNECTIONS_PER_USER = 1;\n+            }\n+            else {\n+                DEFAULT_MAX_CONNECTIONS_PER_USER       = 0;\n+                DEFAULT_MAX_GROUP_CONNECTIONS_PER_USER = 0;\n+            }\n+\n+            // Warn of deprecation\n+            logger.warn(\"The \\\"{}\\\" property is deprecated. Use \\\"{}\\\" and \\\"{}\\\" instead.\",\n+                    SQLServerGuacamoleProperties.SQLSERVER_DISALLOW_DUPLICATE_CONNECTIONS.getName(),\n+                    SQLServerGuacamoleProperties.SQLSERVER_DEFAULT_MAX_CONNECTIONS_PER_USER.getName(),\n+                    SQLServerGuacamoleProperties.SQLSERVER_DEFAULT_MAX_GROUP_CONNECTIONS.getName());\n+\n+            // Inform of new equivalent\n+            logger.info(\"To achieve the same result of setting \\\"{}\\\" to \\\"{}\\\", set \\\"{}\\\" to \\\"{}\\\" and \\\"{}\\\" to \\\"{}\\\".\",\n+                    SQLServerGuacamoleProperties.SQLSERVER_DISALLOW_DUPLICATE_CONNECTIONS.getName(),         disallowDuplicate,\n+                    SQLServerGuacamoleProperties.SQLSERVER_DEFAULT_MAX_CONNECTIONS_PER_USER.getName(),       DEFAULT_MAX_CONNECTIONS_PER_USER,\n+                    SQLServerGuacamoleProperties.SQLSERVER_DEFAULT_MAX_GROUP_CONNECTIONS_PER_USER.getName(), DEFAULT_MAX_GROUP_CONNECTIONS_PER_USER);\n+\n+        }\n+\n+        // Check driver property is one of the acceptable values.\n+        String driver = getProperty(SQLServerGuacamoleProperties.SQLSERVER_DRIVER);\n+        if (driver != null && !(driver.equals(SQLSERVER_DRIVER_JTDS) ||\n+                                driver.equals(SQLSERVER_DRIVER_DATADIRECT) ||\n+                                driver.equals(SQLSERVER_DRIVER_MS) ||\n+                                driver.equals(SQLSERVER_DRIVER_MS_2005)))\n+            logger.warn(\"{} property has been set to an invalid value.  The default Microsoft 2005 driver will be used.\",","path":"extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-sqlserver/src/main/java/org/apache/guacamole/auth/sqlserver/SQLServerEnvironment.java","position":202,"original_position":202,"commit_id":"12b8f365469df69e22a02fec5770e4f0b5f76958","original_commit_id":"12b8f365469df69e22a02fec5770e4f0b5f76958","user":{"login":"mike-jumper","id":4632905,"avatar_url":"https://avatars1.githubusercontent.com/u/4632905?v=4","gravatar_id":"","url":"https://api.github.com/users/mike-jumper","html_url":"https://github.com/mike-jumper","followers_url":"https://api.github.com/users/mike-jumper/followers","following_url":"https://api.github.com/users/mike-jumper/following{/other_user}","gists_url":"https://api.github.com/users/mike-jumper/gists{/gist_id}","starred_url":"https://api.github.com/users/mike-jumper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mike-jumper/subscriptions","organizations_url":"https://api.github.com/users/mike-jumper/orgs","repos_url":"https://api.github.com/users/mike-jumper/repos","events_url":"https://api.github.com/users/mike-jumper/events{/privacy}","received_events_url":"https://api.github.com/users/mike-jumper/received_events","type":"User","site_admin":false},"body":"Rather than read and parse the driver property just to determine whether it's valid, only to parse it a second time later in independent code, it would make more sense to handle this within a common function that encapsulates that parsing, ideally masking the value behind an `enum` which Java can helpfully check at compile time.\r\n\r\nFor example:\r\n\r\nhttps://github.com/apache/incubator-guacamole-client/blob/1c0ee41d0ecd5bc4a3550804b74b73b901e074c2/extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/EncryptionMethodProperty.java","created_at":"2017-09-12T16:35:25Z","updated_at":"2017-09-12T16:35:25Z","html_url":"https://github.com/apache/incubator-guacamole-client/pull/182#discussion_r138402116","pull_request_url":"https://api.github.com/repos/apache/incubator-guacamole-client/pulls/182","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-guacamole-client/pulls/comments/138402116"},"html":{"href":"https://github.com/apache/incubator-guacamole-client/pull/182#discussion_r138402116"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-guacamole-client/pulls/182"}}},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-guacamole-client/pulls/182","id":135916420,"html_url":"https://github.com/apache/incubator-guacamole-client/pull/182","diff_url":"https://github.com/apache/incubator-guacamole-client/pull/182.diff","patch_url":"https://github.com/apache/incubator-guacamole-client/pull/182.patch","issue_url":"https://api.github.com/repos/apache/incubator-guacamole-client/issues/182","number":182,"state":"open","locked":false,"title":"GUACAMOLE-363: Add support for SQL Server authentication","user":{"login":"necouchman","id":4706000,"avatar_url":"https://avatars3.githubusercontent.com/u/4706000?v=4","gravatar_id":"","url":"https://api.github.com/users/necouchman","html_url":"https://github.com/necouchman","followers_url":"https://api.github.com/users/necouchman/followers","following_url":"https://api.github.com/users/necouchman/following{/other_user}","gists_url":"https://api.github.com/users/necouchman/gists{/gist_id}","starred_url":"https://api.github.com/users/necouchman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/necouchman/subscriptions","organizations_url":"https://api.github.com/users/necouchman/orgs","repos_url":"https://api.github.com/users/necouchman/repos","events_url":"https://api.github.com/users/necouchman/events{/privacy}","received_events_url":"https://api.github.com/users/necouchman/received_events","type":"User","site_admin":false},"body":"This pull request implements a SQL Server (sqlserver) module for the JDBC authentication backend, allowing the Guacamole database to be hosted in SQL Server.\r\n\r\nI went the route of creating a guacamole schema and renaming the tables a bit - I have a feeling I'll end up changing that to be more consistent with the other modules, but SQL Server uses a default \"dbo\" schema that's just different, anyway, so I took a stab at it this way.","created_at":"2017-08-16T00:00:36Z","updated_at":"2017-09-12T16:35:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"82de0ec33c9a199effda7ad98dbf130b71dfa7b4","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-guacamole-client/pulls/182/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-guacamole-client/pulls/182/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-guacamole-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-guacamole-client/issues/182/comments","statuses_url":"https://api.github.com/repos/apache/incubator-guacamole-client/statuses/12b8f365469df69e22a02fec5770e4f0b5f76958","head":{"label":"necouchman:GUACAMOLE-363","ref":"GUACAMOLE-363","sha":"12b8f365469df69e22a02fec5770e4f0b5f76958","user":{"login":"necouchman","id":4706000,"avatar_url":"https://avatars3.githubusercontent.com/u/4706000?v=4","gravatar_id":"","url":"https://api.github.com/users/necouchman","html_url":"https://github.com/necouchman","followers_url":"https://api.github.com/users/necouchman/followers","following_url":"https://api.github.com/users/necouchman/following{/other_user}","gists_url":"https://api.github.com/users/necouchman/gists{/gist_id}","starred_url":"https://api.github.com/users/necouchman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/necouchman/subscriptions","organizations_url":"https://api.github.com/users/necouchman/orgs","repos_url":"https://api.github.com/users/necouchman/repos","events_url":"https://api.github.com/users/necouchman/events{/privacy}","received_events_url":"https://api.github.com/users/necouchman/received_events","type":"User","site_admin":false},"repo":{"id":78248317,"name":"incubator-guacamole-client","full_name":"necouchman/incubator-guacamole-client","owner":{"login":"necouchman","id":4706000,"avatar_url":"https://avatars3.githubusercontent.com/u/4706000?v=4","gravatar_id":"","url":"https://api.github.com/users/necouchman","html_url":"https://github.com/necouchman","followers_url":"https://api.github.com/users/necouchman/followers","following_url":"https://api.github.com/users/necouchman/following{/other_user}","gists_url":"https://api.github.com/users/necouchman/gists{/gist_id}","starred_url":"https://api.github.com/users/necouchman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/necouchman/subscriptions","organizations_url":"https://api.github.com/users/necouchman/orgs","repos_url":"https://api.github.com/users/necouchman/repos","events_url":"https://api.github.com/users/necouchman/events{/privacy}","received_events_url":"https://api.github.com/users/necouchman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/necouchman/incubator-guacamole-client","description":"Mirror of Apache Guacamole Client (Incubating)","fork":true,"url":"https://api.github.com/repos/necouchman/incubator-guacamole-client","forks_url":"https://api.github.com/repos/necouchman/incubator-guacamole-client/forks","keys_url":"https://api.github.com/repos/necouchman/incubator-guacamole-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/necouchman/incubator-guacamole-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/necouchman/incubator-guacamole-client/teams","hooks_url":"https://api.github.com/repos/necouchman/incubator-guacamole-client/hooks","issue_events_url":"https://api.github.com/repos/necouchman/incubator-guacamole-client/issues/events{/number}","events_url":"https://api.github.com/repos/necouchman/incubator-guacamole-client/events","assignees_url":"https://api.github.com/repos/necouchman/incubator-guacamole-client/assignees{/user}","branches_url":"https://api.github.com/repos/necouchman/incubator-guacamole-client/branches{/branch}","tags_url":"https://api.github.com/repos/necouchman/incubator-guacamole-client/tags","blobs_url":"https://api.github.com/repos/necouchman/incubator-guacamole-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/necouchman/incubator-guacamole-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/necouchman/incubator-guacamole-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/necouchman/incubator-guacamole-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/necouchman/incubator-guacamole-client/statuses/{sha}","languages_url":"https://api.github.com/repos/necouchman/incubator-guacamole-client/languages","stargazers_url":"https://api.github.com/repos/necouchman/incubator-guacamole-client/stargazers","contributors_url":"https://api.github.com/repos/necouchman/incubator-guacamole-client/contributors","subscribers_url":"https://api.github.com/repos/necouchman/incubator-guacamole-client/subscribers","subscription_url":"https://api.github.com/repos/necouchman/incubator-guacamole-client/subscription","commits_url":"https://api.github.com/repos/necouchman/incubator-guacamole-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/necouchman/incubator-guacamole-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/necouchman/incubator-guacamole-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/necouchman/incubator-guacamole-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/necouchman/incubator-guacamole-client/contents/{+path}","compare_url":"https://api.github.com/repos/necouchman/incubator-guacamole-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/necouchman/incubator-guacamole-client/merges","archive_url":"https://api.github.com/repos/necouchman/incubator-guacamole-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/necouchman/incubator-guacamole-client/downloads","issues_url":"https://api.github.com/repos/necouchman/incubator-guacamole-client/issues{/number}","pulls_url":"https://api.github.com/repos/necouchman/incubator-guacamole-client/pulls{/number}","milestones_url":"https://api.github.com/repos/necouchman/incubator-guacamole-client/milestones{/number}","notifications_url":"https://api.github.com/repos/necouchman/incubator-guacamole-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/necouchman/incubator-guacamole-client/labels{/name}","releases_url":"https://api.github.com/repos/necouchman/incubator-guacamole-client/releases{/id}","deployments_url":"https://api.github.com/repos/necouchman/incubator-guacamole-client/deployments","created_at":"2017-01-07T00:10:55Z","updated_at":"2017-02-08T03:57:38Z","pushed_at":"2017-09-12T15:43:06Z","git_url":"git://github.com/necouchman/incubator-guacamole-client.git","ssh_url":"git@github.com:necouchman/incubator-guacamole-client.git","clone_url":"https://github.com/necouchman/incubator-guacamole-client.git","svn_url":"https://github.com/necouchman/incubator-guacamole-client","homepage":"","size":16578,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"a5ebc07349bcf43c80f404836d9964ac894bed26","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":54452622,"name":"incubator-guacamole-client","full_name":"apache/incubator-guacamole-client","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-guacamole-client","description":"Mirror of Apache Guacamole Client (Incubating)","fork":false,"url":"https://api.github.com/repos/apache/incubator-guacamole-client","forks_url":"https://api.github.com/repos/apache/incubator-guacamole-client/forks","keys_url":"https://api.github.com/repos/apache/incubator-guacamole-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-guacamole-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-guacamole-client/teams","hooks_url":"https://api.github.com/repos/apache/incubator-guacamole-client/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-guacamole-client/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-guacamole-client/events","assignees_url":"https://api.github.com/repos/apache/incubator-guacamole-client/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-guacamole-client/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-guacamole-client/tags","blobs_url":"https://api.github.com/repos/apache/incubator-guacamole-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-guacamole-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-guacamole-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-guacamole-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-guacamole-client/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-guacamole-client/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-guacamole-client/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-guacamole-client/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-guacamole-client/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-guacamole-client/subscription","commits_url":"https://api.github.com/repos/apache/incubator-guacamole-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-guacamole-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-guacamole-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-guacamole-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-guacamole-client/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-guacamole-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-guacamole-client/merges","archive_url":"https://api.github.com/repos/apache/incubator-guacamole-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-guacamole-client/downloads","issues_url":"https://api.github.com/repos/apache/incubator-guacamole-client/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-guacamole-client/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-guacamole-client/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-guacamole-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-guacamole-client/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-guacamole-client/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-guacamole-client/deployments","created_at":"2016-03-22T07:00:06Z","updated_at":"2017-09-07T17:46:56Z","pushed_at":"2017-09-12T15:43:07Z","git_url":"git://github.com/apache/incubator-guacamole-client.git","ssh_url":"git@github.com:apache/incubator-guacamole-client.git","clone_url":"https://github.com/apache/incubator-guacamole-client.git","svn_url":"https://github.com/apache/incubator-guacamole-client","homepage":null,"size":16101,"stargazers_count":263,"watchers_count":263,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":107,"mirror_url":"git://git.apache.org/incubator-guacamole-client.git","open_issues_count":12,"forks":107,"open_issues":12,"watchers":263,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-guacamole-client/pulls/182"},"html":{"href":"https://github.com/apache/incubator-guacamole-client/pull/182"},"issue":{"href":"https://api.github.com/repos/apache/incubator-guacamole-client/issues/182"},"comments":{"href":"https://api.github.com/repos/apache/incubator-guacamole-client/issues/182/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-guacamole-client/pulls/182/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-guacamole-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-guacamole-client/pulls/182/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-guacamole-client/statuses/12b8f365469df69e22a02fec5770e4f0b5f76958"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mike-jumper"}}