{"push_id":2177492110,"size":7,"distinct_size":7,"ref":"refs/heads/queue","head":"2b232dd17cfbfa568879d70b0176c05ad067615b","before":"8bbbfdb8bddaa538ae13cfdf86c1c997d3b20b1f","commits":[{"sha":"16df19376713689656d8f07a061bc942eb2d932a","author":{"name":"Eli Schwartz","email":"8c4aca8fedc4377c9e6301249eafe066ff96270a@archlinux.org"},"message":"makepkg: refactor checking for write permissions into a utility function\n\nAdditionally provide a separate error for the confusing if unlikely\nevent that the user tries to use an existing file as a package output\ndirectory.\n\nThis also means we now consistently try to create any nonexistent *DEST\ndirectories as needed before aborting with E_FS_PERMISSIONS. Previously\nonly $BUILDDIR received that kindness.\n\nFixes FS#43537","distinct":true,"url":"https://api.github.com/repos/eli-schwartz/pacman/commits/16df19376713689656d8f07a061bc942eb2d932a"},{"sha":"556d7384e3f0633a3390030b452e8ff4eeb736c1","author":{"name":"Eli Schwartz","email":"8c4aca8fedc4377c9e6301249eafe066ff96270a@archlinux.org"},"message":"makepkg: Add a config option to specify the location of debug sources\n\nIn commit 8b0d59b83a60eb504567590346119fe4cd891cad support was added for\nstoring the source files of binaries in debug packages. Allow the user\nto specify where those source files should be stored via makepkg.conf","distinct":true,"url":"https://api.github.com/repos/eli-schwartz/pacman/commits/556d7384e3f0633a3390030b452e8ff4eeb736c1"},{"sha":"37549e4f8454608c7f53e389ec3738f5c18f553a","author":{"name":"Eli Schwartz","email":"8c4aca8fedc4377c9e6301249eafe066ff96270a@archlinux.org"},"message":"makepkg: tell the compiler to record debugging info for debug packages\n\nIn commit 8b0d59b83a60eb504567590346119fe4cd891cad support was added for\nstoring the source files of binaries in debug packages. This made use of\nthe debugedit program which is part of the RPM package manager, which is\nnot very standalone.\n\nThe same effect can be achieved using -fdebug-prefix-map, an option\naccepted by both the gcc and clang compilers which modifies how the\ncompiler itself stores the references to the source files rather than\nrequiring us to later edit the produced binaries. This also removes the\ndependency on external programs like debugedit.\n\nAs a result of this change, source files will only be effectively added\nfor programs which actually use the exported CFLAGS. This is a reasonable\ntradeoff as we expect our CFLAGS to be used rather than ignored. Upstream\nsoftware which do not produce useful debug packages are expected to fix\ntheir build systems to respect the environment CFLAGS.\n\nAs a result of this change, the routine for extracting source filenames\nfrom binaries had to be modified to derive the source file from the\nfinal debug location, rather than the other way around.","distinct":true,"url":"https://api.github.com/repos/eli-schwartz/pacman/commits/37549e4f8454608c7f53e389ec3738f5c18f553a"},{"sha":"52ecd9315a6b584e66e258da9fec437ab4b06912","author":{"name":"Eli Schwartz","email":"8c4aca8fedc4377c9e6301249eafe066ff96270a@archlinux.org"},"message":"makepkg --packagelist: just list the built package files we will build\n\nCurrently this seems to be only theoretically useful. The most likely\nreason for wanting a packagelist is in order to script makepkg and\nderive the filenames for the packages we want to install or repo-add,\nbut in the current implementation this requires a lot of additional\npost-processing which must be duplicated in every utility to wrap\nmakepkg.\n\n- It is of minimal use to know what packages might get created on some\n  other device utilizing a different CPU/OS architecture, so don't list\n  them.\n- It is non-trivial to reimplement makepkg's logic for sourcing any of\n  several makepkg.conf configuration files, then applying environment\n  overrides in order to get the PKGDEST and PKGEXT, so include them\n  directly in the returned filenames.","distinct":true,"url":"https://api.github.com/repos/eli-schwartz/pacman/commits/52ecd9315a6b584e66e258da9fec437ab4b06912"},{"sha":"1154922458d99182e0556a03121e7f23fd3b8c88","author":{"name":"Eli Schwartz","email":"8c4aca8fedc4377c9e6301249eafe066ff96270a@archlinux.org"},"message":"makepkg: avoid false \"Signing package(s)\" msg when signing is disabled\n\nFollowup on c6b04c04653ba9933fe978829148312e412a9ea7 which refactored\nthe signing function to run outside of fakeroot, and in the process\nmoved the status message to outside the $SIGNPKG check.","distinct":true,"url":"https://api.github.com/repos/eli-schwartz/pacman/commits/1154922458d99182e0556a03121e7f23fd3b8c88"},{"sha":"b545abb192f13d237efb0743b52a6fc722dfaa1a","author":{"name":"Eli Schwartz","email":"8c4aca8fedc4377c9e6301249eafe066ff96270a@archlinux.org"},"message":"libmakepkg/integrity: fix regression that broke invalid file sigs\n\nIn 42e7020281d3ae260e1e9693495f527b7f476625 creating the gpg statusfile\nfor a source file was split into a separate function, which used the\nreturn code to indicate unsigned files and proto-specific errors.\nHowever, the fallback return code was set by the final gpg invocation,\nwhich would be 1 if the signature was somehow broken (for example, the\nkey was not available in the gpg keyring). As a result makepkg thought\nthat file did not have a signature and skipped over it rather than\nerroring out.\n\nFix this by explicitly setting the return code for all\nverify_*_signature() functions.","distinct":true,"url":"https://api.github.com/repos/eli-schwartz/pacman/commits/b545abb192f13d237efb0743b52a6fc722dfaa1a"},{"sha":"2b232dd17cfbfa568879d70b0176c05ad067615b","author":{"name":"Eli Schwartz","email":"8c4aca8fedc4377c9e6301249eafe066ff96270a@archlinux.org"},"message":"libmakepkg/integrity: fix git signatures not seen with multiple files\n\nIn eaa82b4d0775252856a4e54a6f2a9ea191cf0b8f source_has_signature() was\nmodified to check if git repositories are marked as signed. However, due\nto a typo the unused variable $netfile was checked. This worked as long\nas the last source element was marked as signed, due to $netfile being\nglobally set in check_vcs_software(), but usually failed with multiple\nsources.\n\nFix this by completely moving over to $netfile in source_has_signature()\nas netfile is more descriptive of the current state.\n\nAs an extra precaution declare $netfile as a local variable in\ncheck_vcs_software(). If this had not been mistakenly left as global,\nthe typo would have been immediately apparent.","distinct":true,"url":"https://api.github.com/repos/eli-schwartz/pacman/commits/2b232dd17cfbfa568879d70b0176c05ad067615b"}]}
{"actor":{"display_login":"eli-schwartz"}}