{"action":"created","comment":{"url":"https://api.github.com/repos/lxc/lxd/pulls/comments/143088046","pull_request_review_id":67549474,"id":143088046,"diff_hunk":"@@ -249,6 +286,20 @@ func (r *ProtocolLXD) rawWebsocket(url string) (*websocket.Conn, error) {\n \t\theaders.Set(\"User-Agent\", r.httpUserAgent)\n \t}\n \n+\tif r.requireAuthenticated {\n+\t\theaders.Set(\"X-LXD-authenticated\", \"true\")\n+\t}\n+\n+\t//Set macaroons headers if needed","path":"client/lxd.go","position":90,"original_position":90,"commit_id":"94e989699bdbeda2806be358c11443f8b706dc7e","original_commit_id":"ccf8e1d04fab489f16d8c3500a6ae8d1608fc040","user":{"login":"stgraber","id":2230599,"avatar_url":"https://avatars0.githubusercontent.com/u/2230599?v=4","gravatar_id":"","url":"https://api.github.com/users/stgraber","html_url":"https://github.com/stgraber","followers_url":"https://api.github.com/users/stgraber/followers","following_url":"https://api.github.com/users/stgraber/following{/other_user}","gists_url":"https://api.github.com/users/stgraber/gists{/gist_id}","starred_url":"https://api.github.com/users/stgraber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stgraber/subscriptions","organizations_url":"https://api.github.com/users/stgraber/orgs","repos_url":"https://api.github.com/users/stgraber/repos","events_url":"https://api.github.com/users/stgraber/events{/privacy}","received_events_url":"https://api.github.com/users/stgraber/received_events","type":"User","site_admin":false},"body":"Missing space","created_at":"2017-10-06T00:25:11Z","updated_at":"2017-10-06T00:25:11Z","html_url":"https://github.com/lxc/lxd/pull/3604#discussion_r143088046","pull_request_url":"https://api.github.com/repos/lxc/lxd/pulls/3604","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/lxc/lxd/pulls/comments/143088046"},"html":{"href":"https://github.com/lxc/lxd/pull/3604#discussion_r143088046"},"pull_request":{"href":"https://api.github.com/repos/lxc/lxd/pulls/3604"}}},"pull_request":{"url":"https://api.github.com/repos/lxc/lxd/pulls/3604","id":133006738,"html_url":"https://github.com/lxc/lxd/pull/3604","diff_url":"https://github.com/lxc/lxd/pull/3604.diff","patch_url":"https://github.com/lxc/lxd/pull/3604.patch","issue_url":"https://api.github.com/repos/lxc/lxd/issues/3604","number":3604,"state":"open","locked":false,"title":"Support for external authentication via Macaroons ","user":{"login":"albertodonato","id":3472143,"avatar_url":"https://avatars2.githubusercontent.com/u/3472143?v=4","gravatar_id":"","url":"https://api.github.com/users/albertodonato","html_url":"https://github.com/albertodonato","followers_url":"https://api.github.com/users/albertodonato/followers","following_url":"https://api.github.com/users/albertodonato/following{/other_user}","gists_url":"https://api.github.com/users/albertodonato/gists{/gist_id}","starred_url":"https://api.github.com/users/albertodonato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/albertodonato/subscriptions","organizations_url":"https://api.github.com/users/albertodonato/orgs","repos_url":"https://api.github.com/users/albertodonato/repos","events_url":"https://api.github.com/users/albertodonato/events{/privacy}","received_events_url":"https://api.github.com/users/albertodonato/received_events","type":"User","site_admin":false},"body":"Add support for external authentication via macaroons (https://github.com/go-macaroon/macaroon)","created_at":"2017-07-28T16:33:56Z","updated_at":"2017-10-06T00:25:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4d800a13ada7947f23905e68aa9729c2f6b5b502","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/lxc/lxd/pulls/3604/commits","review_comments_url":"https://api.github.com/repos/lxc/lxd/pulls/3604/comments","review_comment_url":"https://api.github.com/repos/lxc/lxd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lxc/lxd/issues/3604/comments","statuses_url":"https://api.github.com/repos/lxc/lxd/statuses/94e989699bdbeda2806be358c11443f8b706dc7e","head":{"label":"albertodonato:external-auth","ref":"external-auth","sha":"94e989699bdbeda2806be358c11443f8b706dc7e","user":{"login":"albertodonato","id":3472143,"avatar_url":"https://avatars2.githubusercontent.com/u/3472143?v=4","gravatar_id":"","url":"https://api.github.com/users/albertodonato","html_url":"https://github.com/albertodonato","followers_url":"https://api.github.com/users/albertodonato/followers","following_url":"https://api.github.com/users/albertodonato/following{/other_user}","gists_url":"https://api.github.com/users/albertodonato/gists{/gist_id}","starred_url":"https://api.github.com/users/albertodonato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/albertodonato/subscriptions","organizations_url":"https://api.github.com/users/albertodonato/orgs","repos_url":"https://api.github.com/users/albertodonato/repos","events_url":"https://api.github.com/users/albertodonato/events{/privacy}","received_events_url":"https://api.github.com/users/albertodonato/received_events","type":"User","site_admin":false},"repo":{"id":88206444,"name":"lxd","full_name":"albertodonato/lxd","owner":{"login":"albertodonato","id":3472143,"avatar_url":"https://avatars2.githubusercontent.com/u/3472143?v=4","gravatar_id":"","url":"https://api.github.com/users/albertodonato","html_url":"https://github.com/albertodonato","followers_url":"https://api.github.com/users/albertodonato/followers","following_url":"https://api.github.com/users/albertodonato/following{/other_user}","gists_url":"https://api.github.com/users/albertodonato/gists{/gist_id}","starred_url":"https://api.github.com/users/albertodonato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/albertodonato/subscriptions","organizations_url":"https://api.github.com/users/albertodonato/orgs","repos_url":"https://api.github.com/users/albertodonato/repos","events_url":"https://api.github.com/users/albertodonato/events{/privacy}","received_events_url":"https://api.github.com/users/albertodonato/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/albertodonato/lxd","description":"Daemon based on liblxc offering a REST API to manage containers","fork":true,"url":"https://api.github.com/repos/albertodonato/lxd","forks_url":"https://api.github.com/repos/albertodonato/lxd/forks","keys_url":"https://api.github.com/repos/albertodonato/lxd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/albertodonato/lxd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/albertodonato/lxd/teams","hooks_url":"https://api.github.com/repos/albertodonato/lxd/hooks","issue_events_url":"https://api.github.com/repos/albertodonato/lxd/issues/events{/number}","events_url":"https://api.github.com/repos/albertodonato/lxd/events","assignees_url":"https://api.github.com/repos/albertodonato/lxd/assignees{/user}","branches_url":"https://api.github.com/repos/albertodonato/lxd/branches{/branch}","tags_url":"https://api.github.com/repos/albertodonato/lxd/tags","blobs_url":"https://api.github.com/repos/albertodonato/lxd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/albertodonato/lxd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/albertodonato/lxd/git/refs{/sha}","trees_url":"https://api.github.com/repos/albertodonato/lxd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/albertodonato/lxd/statuses/{sha}","languages_url":"https://api.github.com/repos/albertodonato/lxd/languages","stargazers_url":"https://api.github.com/repos/albertodonato/lxd/stargazers","contributors_url":"https://api.github.com/repos/albertodonato/lxd/contributors","subscribers_url":"https://api.github.com/repos/albertodonato/lxd/subscribers","subscription_url":"https://api.github.com/repos/albertodonato/lxd/subscription","commits_url":"https://api.github.com/repos/albertodonato/lxd/commits{/sha}","git_commits_url":"https://api.github.com/repos/albertodonato/lxd/git/commits{/sha}","comments_url":"https://api.github.com/repos/albertodonato/lxd/comments{/number}","issue_comment_url":"https://api.github.com/repos/albertodonato/lxd/issues/comments{/number}","contents_url":"https://api.github.com/repos/albertodonato/lxd/contents/{+path}","compare_url":"https://api.github.com/repos/albertodonato/lxd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/albertodonato/lxd/merges","archive_url":"https://api.github.com/repos/albertodonato/lxd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/albertodonato/lxd/downloads","issues_url":"https://api.github.com/repos/albertodonato/lxd/issues{/number}","pulls_url":"https://api.github.com/repos/albertodonato/lxd/pulls{/number}","milestones_url":"https://api.github.com/repos/albertodonato/lxd/milestones{/number}","notifications_url":"https://api.github.com/repos/albertodonato/lxd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/albertodonato/lxd/labels{/name}","releases_url":"https://api.github.com/repos/albertodonato/lxd/releases{/id}","deployments_url":"https://api.github.com/repos/albertodonato/lxd/deployments","created_at":"2017-04-13T21:05:11Z","updated_at":"2017-04-13T21:05:14Z","pushed_at":"2017-10-05T21:57:46Z","git_url":"git://github.com/albertodonato/lxd.git","ssh_url":"git@github.com:albertodonato/lxd.git","clone_url":"https://github.com/albertodonato/lxd.git","svn_url":"https://github.com/albertodonato/lxd","homepage":"https://linuxcontainers.org/lxd","size":14147,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lxc:master","ref":"master","sha":"d908ecbff4bf8a7ccce4adf70881071f57d96a31","user":{"login":"lxc","id":2301756,"avatar_url":"https://avatars2.githubusercontent.com/u/2301756?v=4","gravatar_id":"","url":"https://api.github.com/users/lxc","html_url":"https://github.com/lxc","followers_url":"https://api.github.com/users/lxc/followers","following_url":"https://api.github.com/users/lxc/following{/other_user}","gists_url":"https://api.github.com/users/lxc/gists{/gist_id}","starred_url":"https://api.github.com/users/lxc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lxc/subscriptions","organizations_url":"https://api.github.com/users/lxc/orgs","repos_url":"https://api.github.com/users/lxc/repos","events_url":"https://api.github.com/users/lxc/events{/privacy}","received_events_url":"https://api.github.com/users/lxc/received_events","type":"Organization","site_admin":false},"repo":{"id":26192117,"name":"lxd","full_name":"lxc/lxd","owner":{"login":"lxc","id":2301756,"avatar_url":"https://avatars2.githubusercontent.com/u/2301756?v=4","gravatar_id":"","url":"https://api.github.com/users/lxc","html_url":"https://github.com/lxc","followers_url":"https://api.github.com/users/lxc/followers","following_url":"https://api.github.com/users/lxc/following{/other_user}","gists_url":"https://api.github.com/users/lxc/gists{/gist_id}","starred_url":"https://api.github.com/users/lxc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lxc/subscriptions","organizations_url":"https://api.github.com/users/lxc/orgs","repos_url":"https://api.github.com/users/lxc/repos","events_url":"https://api.github.com/users/lxc/events{/privacy}","received_events_url":"https://api.github.com/users/lxc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lxc/lxd","description":"Daemon based on liblxc offering a REST API to manage containers","fork":false,"url":"https://api.github.com/repos/lxc/lxd","forks_url":"https://api.github.com/repos/lxc/lxd/forks","keys_url":"https://api.github.com/repos/lxc/lxd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lxc/lxd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lxc/lxd/teams","hooks_url":"https://api.github.com/repos/lxc/lxd/hooks","issue_events_url":"https://api.github.com/repos/lxc/lxd/issues/events{/number}","events_url":"https://api.github.com/repos/lxc/lxd/events","assignees_url":"https://api.github.com/repos/lxc/lxd/assignees{/user}","branches_url":"https://api.github.com/repos/lxc/lxd/branches{/branch}","tags_url":"https://api.github.com/repos/lxc/lxd/tags","blobs_url":"https://api.github.com/repos/lxc/lxd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lxc/lxd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lxc/lxd/git/refs{/sha}","trees_url":"https://api.github.com/repos/lxc/lxd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lxc/lxd/statuses/{sha}","languages_url":"https://api.github.com/repos/lxc/lxd/languages","stargazers_url":"https://api.github.com/repos/lxc/lxd/stargazers","contributors_url":"https://api.github.com/repos/lxc/lxd/contributors","subscribers_url":"https://api.github.com/repos/lxc/lxd/subscribers","subscription_url":"https://api.github.com/repos/lxc/lxd/subscription","commits_url":"https://api.github.com/repos/lxc/lxd/commits{/sha}","git_commits_url":"https://api.github.com/repos/lxc/lxd/git/commits{/sha}","comments_url":"https://api.github.com/repos/lxc/lxd/comments{/number}","issue_comment_url":"https://api.github.com/repos/lxc/lxd/issues/comments{/number}","contents_url":"https://api.github.com/repos/lxc/lxd/contents/{+path}","compare_url":"https://api.github.com/repos/lxc/lxd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lxc/lxd/merges","archive_url":"https://api.github.com/repos/lxc/lxd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lxc/lxd/downloads","issues_url":"https://api.github.com/repos/lxc/lxd/issues{/number}","pulls_url":"https://api.github.com/repos/lxc/lxd/pulls{/number}","milestones_url":"https://api.github.com/repos/lxc/lxd/milestones{/number}","notifications_url":"https://api.github.com/repos/lxc/lxd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lxc/lxd/labels{/name}","releases_url":"https://api.github.com/repos/lxc/lxd/releases{/id}","deployments_url":"https://api.github.com/repos/lxc/lxd/deployments","created_at":"2014-11-04T22:40:52Z","updated_at":"2017-10-05T02:31:51Z","pushed_at":"2017-10-05T23:06:15Z","git_url":"git://github.com/lxc/lxd.git","ssh_url":"git@github.com:lxc/lxd.git","clone_url":"https://github.com/lxc/lxd.git","svn_url":"https://github.com/lxc/lxd","homepage":"https://linuxcontainers.org/lxd","size":14855,"stargazers_count":1482,"watchers_count":1482,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":360,"mirror_url":null,"open_issues_count":64,"forks":360,"open_issues":64,"watchers":1482,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lxc/lxd/pulls/3604"},"html":{"href":"https://github.com/lxc/lxd/pull/3604"},"issue":{"href":"https://api.github.com/repos/lxc/lxd/issues/3604"},"comments":{"href":"https://api.github.com/repos/lxc/lxd/issues/3604/comments"},"review_comments":{"href":"https://api.github.com/repos/lxc/lxd/pulls/3604/comments"},"review_comment":{"href":"https://api.github.com/repos/lxc/lxd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lxc/lxd/pulls/3604/commits"},"statuses":{"href":"https://api.github.com/repos/lxc/lxd/statuses/94e989699bdbeda2806be358c11443f8b706dc7e"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"stgraber"}}