{"action":"created","comment":{"url":"https://api.github.com/repos/palantir/blueprint/pulls/comments/156522294","pull_request_review_id":83014206,"id":156522294,"diff_hunk":"@@ -21,7 +21,7 @@ import {\n     Utils,\n } from \"@blueprintjs/core\";\n \n-import * as Classes from \"../../common/classes\";\n+import * as Classes from \"../classes\";","path":"packages/select/src/components/omnibar/omnibar.tsx","position":5,"original_position":5,"commit_id":"bc9feb6b55f9e87c97fe1e3f4e97bbac7d9a01b4","original_commit_id":"bc9feb6b55f9e87c97fe1e3f4e97bbac7d9a01b4","user":{"login":"adidahiya","id":723999,"avatar_url":"https://avatars1.githubusercontent.com/u/723999?v=4","gravatar_id":"","url":"https://api.github.com/users/adidahiya","html_url":"https://github.com/adidahiya","followers_url":"https://api.github.com/users/adidahiya/followers","following_url":"https://api.github.com/users/adidahiya/following{/other_user}","gists_url":"https://api.github.com/users/adidahiya/gists{/gist_id}","starred_url":"https://api.github.com/users/adidahiya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adidahiya/subscriptions","organizations_url":"https://api.github.com/users/adidahiya/orgs","repos_url":"https://api.github.com/users/adidahiya/repos","events_url":"https://api.github.com/users/adidahiya/events{/privacy}","received_events_url":"https://api.github.com/users/adidahiya/received_events","type":"User","site_admin":false},"body":"it's just nice to have the convention across packages","created_at":"2017-12-12T23:06:37Z","updated_at":"2017-12-12T23:06:37Z","html_url":"https://github.com/palantir/blueprint/pull/1889#discussion_r156522294","pull_request_url":"https://api.github.com/repos/palantir/blueprint/pulls/1889","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/palantir/blueprint/pulls/comments/156522294"},"html":{"href":"https://github.com/palantir/blueprint/pull/1889#discussion_r156522294"},"pull_request":{"href":"https://api.github.com/repos/palantir/blueprint/pulls/1889"}},"in_reply_to_id":156516269},"pull_request":{"url":"https://api.github.com/repos/palantir/blueprint/pulls/1889","id":157708601,"html_url":"https://github.com/palantir/blueprint/pull/1889","diff_url":"https://github.com/palantir/blueprint/pull/1889.diff","patch_url":"https://github.com/palantir/blueprint/pull/1889.patch","issue_url":"https://api.github.com/repos/palantir/blueprint/issues/1889","number":1889,"state":"open","locked":false,"title":"create select package, move stuff from labs over","user":{"login":"hellochar","id":1079495,"avatar_url":"https://avatars2.githubusercontent.com/u/1079495?v=4","gravatar_id":"","url":"https://api.github.com/users/hellochar","html_url":"https://github.com/hellochar","followers_url":"https://api.github.com/users/hellochar/followers","following_url":"https://api.github.com/users/hellochar/following{/other_user}","gists_url":"https://api.github.com/users/hellochar/gists{/gist_id}","starred_url":"https://api.github.com/users/hellochar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hellochar/subscriptions","organizations_url":"https://api.github.com/users/hellochar/orgs","repos_url":"https://api.github.com/users/hellochar/repos","events_url":"https://api.github.com/users/hellochar/events{/privacy}","received_events_url":"https://api.github.com/users/hellochar/received_events","type":"User","site_admin":false},"body":"Graduates the following components into their own package, `@blueprintjs/select`:\r\n\r\n* Select\r\n* Suggest\r\n* MultiSelect\r\n* Omnibar\r\n* QueryList\r\n\r\nThis PR currently fails due to \r\n\r\n- [x] Reference Popover2 and TagInput once they're in core (@cmslewis for SA), waiting on https://github.com/palantir/blueprint/pull/1881\r\n- [x] ensure the docs page works with the new package (and update https://github.com/palantir/blueprint/wiki/Creating-a-new-package accordingly)\r\n- [x] Look through unit tests and see how good we are (run tests with coverage and see if it fails)","created_at":"2017-12-12T00:37:20Z","updated_at":"2017-12-12T23:06:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"652cac916a4571ec0ec1431d554ed217b4aa88ef","assignee":null,"assignees":[],"requested_reviewers":[{"login":"giladgray","id":464822,"avatar_url":"https://avatars1.githubusercontent.com/u/464822?v=4","gravatar_id":"","url":"https://api.github.com/users/giladgray","html_url":"https://github.com/giladgray","followers_url":"https://api.github.com/users/giladgray/followers","following_url":"https://api.github.com/users/giladgray/following{/other_user}","gists_url":"https://api.github.com/users/giladgray/gists{/gist_id}","starred_url":"https://api.github.com/users/giladgray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giladgray/subscriptions","organizations_url":"https://api.github.com/users/giladgray/orgs","repos_url":"https://api.github.com/users/giladgray/repos","events_url":"https://api.github.com/users/giladgray/events{/privacy}","received_events_url":"https://api.github.com/users/giladgray/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/palantir/blueprint/pulls/1889/commits","review_comments_url":"https://api.github.com/repos/palantir/blueprint/pulls/1889/comments","review_comment_url":"https://api.github.com/repos/palantir/blueprint/pulls/comments{/number}","comments_url":"https://api.github.com/repos/palantir/blueprint/issues/1889/comments","statuses_url":"https://api.github.com/repos/palantir/blueprint/statuses/bc9feb6b55f9e87c97fe1e3f4e97bbac7d9a01b4","head":{"label":"palantir:xzhang/create-select-package","ref":"xzhang/create-select-package","sha":"bc9feb6b55f9e87c97fe1e3f4e97bbac7d9a01b4","user":{"login":"palantir","id":303157,"avatar_url":"https://avatars0.githubusercontent.com/u/303157?v=4","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"repo":{"id":71939872,"name":"blueprint","full_name":"palantir/blueprint","owner":{"login":"palantir","id":303157,"avatar_url":"https://avatars0.githubusercontent.com/u/303157?v=4","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/palantir/blueprint","description":"A React-based UI toolkit for the web","fork":false,"url":"https://api.github.com/repos/palantir/blueprint","forks_url":"https://api.github.com/repos/palantir/blueprint/forks","keys_url":"https://api.github.com/repos/palantir/blueprint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/palantir/blueprint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/palantir/blueprint/teams","hooks_url":"https://api.github.com/repos/palantir/blueprint/hooks","issue_events_url":"https://api.github.com/repos/palantir/blueprint/issues/events{/number}","events_url":"https://api.github.com/repos/palantir/blueprint/events","assignees_url":"https://api.github.com/repos/palantir/blueprint/assignees{/user}","branches_url":"https://api.github.com/repos/palantir/blueprint/branches{/branch}","tags_url":"https://api.github.com/repos/palantir/blueprint/tags","blobs_url":"https://api.github.com/repos/palantir/blueprint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/palantir/blueprint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/palantir/blueprint/git/refs{/sha}","trees_url":"https://api.github.com/repos/palantir/blueprint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/palantir/blueprint/statuses/{sha}","languages_url":"https://api.github.com/repos/palantir/blueprint/languages","stargazers_url":"https://api.github.com/repos/palantir/blueprint/stargazers","contributors_url":"https://api.github.com/repos/palantir/blueprint/contributors","subscribers_url":"https://api.github.com/repos/palantir/blueprint/subscribers","subscription_url":"https://api.github.com/repos/palantir/blueprint/subscription","commits_url":"https://api.github.com/repos/palantir/blueprint/commits{/sha}","git_commits_url":"https://api.github.com/repos/palantir/blueprint/git/commits{/sha}","comments_url":"https://api.github.com/repos/palantir/blueprint/comments{/number}","issue_comment_url":"https://api.github.com/repos/palantir/blueprint/issues/comments{/number}","contents_url":"https://api.github.com/repos/palantir/blueprint/contents/{+path}","compare_url":"https://api.github.com/repos/palantir/blueprint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/palantir/blueprint/merges","archive_url":"https://api.github.com/repos/palantir/blueprint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/palantir/blueprint/downloads","issues_url":"https://api.github.com/repos/palantir/blueprint/issues{/number}","pulls_url":"https://api.github.com/repos/palantir/blueprint/pulls{/number}","milestones_url":"https://api.github.com/repos/palantir/blueprint/milestones{/number}","notifications_url":"https://api.github.com/repos/palantir/blueprint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/palantir/blueprint/labels{/name}","releases_url":"https://api.github.com/repos/palantir/blueprint/releases{/id}","deployments_url":"https://api.github.com/repos/palantir/blueprint/deployments","created_at":"2016-10-25T21:17:50Z","updated_at":"2017-12-12T22:26:31Z","pushed_at":"2017-12-12T22:45:44Z","git_url":"git://github.com/palantir/blueprint.git","ssh_url":"git@github.com:palantir/blueprint.git","clone_url":"https://github.com/palantir/blueprint.git","svn_url":"https://github.com/palantir/blueprint","homepage":"http://blueprintjs.com/","size":56821,"stargazers_count":7769,"watchers_count":7769,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":470,"mirror_url":null,"archived":false,"open_issues_count":307,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":470,"open_issues":307,"watchers":7769,"default_branch":"master"}},"base":{"label":"palantir:master","ref":"master","sha":"77eac90e60252dc66d594cd12b9e73dec4c86966","user":{"login":"palantir","id":303157,"avatar_url":"https://avatars0.githubusercontent.com/u/303157?v=4","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"repo":{"id":71939872,"name":"blueprint","full_name":"palantir/blueprint","owner":{"login":"palantir","id":303157,"avatar_url":"https://avatars0.githubusercontent.com/u/303157?v=4","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/palantir/blueprint","description":"A React-based UI toolkit for the web","fork":false,"url":"https://api.github.com/repos/palantir/blueprint","forks_url":"https://api.github.com/repos/palantir/blueprint/forks","keys_url":"https://api.github.com/repos/palantir/blueprint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/palantir/blueprint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/palantir/blueprint/teams","hooks_url":"https://api.github.com/repos/palantir/blueprint/hooks","issue_events_url":"https://api.github.com/repos/palantir/blueprint/issues/events{/number}","events_url":"https://api.github.com/repos/palantir/blueprint/events","assignees_url":"https://api.github.com/repos/palantir/blueprint/assignees{/user}","branches_url":"https://api.github.com/repos/palantir/blueprint/branches{/branch}","tags_url":"https://api.github.com/repos/palantir/blueprint/tags","blobs_url":"https://api.github.com/repos/palantir/blueprint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/palantir/blueprint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/palantir/blueprint/git/refs{/sha}","trees_url":"https://api.github.com/repos/palantir/blueprint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/palantir/blueprint/statuses/{sha}","languages_url":"https://api.github.com/repos/palantir/blueprint/languages","stargazers_url":"https://api.github.com/repos/palantir/blueprint/stargazers","contributors_url":"https://api.github.com/repos/palantir/blueprint/contributors","subscribers_url":"https://api.github.com/repos/palantir/blueprint/subscribers","subscription_url":"https://api.github.com/repos/palantir/blueprint/subscription","commits_url":"https://api.github.com/repos/palantir/blueprint/commits{/sha}","git_commits_url":"https://api.github.com/repos/palantir/blueprint/git/commits{/sha}","comments_url":"https://api.github.com/repos/palantir/blueprint/comments{/number}","issue_comment_url":"https://api.github.com/repos/palantir/blueprint/issues/comments{/number}","contents_url":"https://api.github.com/repos/palantir/blueprint/contents/{+path}","compare_url":"https://api.github.com/repos/palantir/blueprint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/palantir/blueprint/merges","archive_url":"https://api.github.com/repos/palantir/blueprint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/palantir/blueprint/downloads","issues_url":"https://api.github.com/repos/palantir/blueprint/issues{/number}","pulls_url":"https://api.github.com/repos/palantir/blueprint/pulls{/number}","milestones_url":"https://api.github.com/repos/palantir/blueprint/milestones{/number}","notifications_url":"https://api.github.com/repos/palantir/blueprint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/palantir/blueprint/labels{/name}","releases_url":"https://api.github.com/repos/palantir/blueprint/releases{/id}","deployments_url":"https://api.github.com/repos/palantir/blueprint/deployments","created_at":"2016-10-25T21:17:50Z","updated_at":"2017-12-12T22:26:31Z","pushed_at":"2017-12-12T22:45:44Z","git_url":"git://github.com/palantir/blueprint.git","ssh_url":"git@github.com:palantir/blueprint.git","clone_url":"https://github.com/palantir/blueprint.git","svn_url":"https://github.com/palantir/blueprint","homepage":"http://blueprintjs.com/","size":56821,"stargazers_count":7769,"watchers_count":7769,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":470,"mirror_url":null,"archived":false,"open_issues_count":307,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":470,"open_issues":307,"watchers":7769,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/palantir/blueprint/pulls/1889"},"html":{"href":"https://github.com/palantir/blueprint/pull/1889"},"issue":{"href":"https://api.github.com/repos/palantir/blueprint/issues/1889"},"comments":{"href":"https://api.github.com/repos/palantir/blueprint/issues/1889/comments"},"review_comments":{"href":"https://api.github.com/repos/palantir/blueprint/pulls/1889/comments"},"review_comment":{"href":"https://api.github.com/repos/palantir/blueprint/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/palantir/blueprint/pulls/1889/commits"},"statuses":{"href":"https://api.github.com/repos/palantir/blueprint/statuses/bc9feb6b55f9e87c97fe1e3f4e97bbac7d9a01b4"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"adidahiya"}}