{"action":"created","comment":{"url":"https://api.github.com/repos/driftyco/ionic/pulls/comments/114148886","pull_request_review_id":35591853,"id":114148886,"diff_hunk":"@@ -27,7 +27,7 @@ export class Page1 {\n     });\n   }\n \n-  doStart(refresher: Refresher) {\n+  doStart() {","path":"src/components/refresher/test/navigation/app.module.ts","position":5,"original_position":5,"commit_id":"5f20c12078ac67c8cc62350082d9cef51a26d356","original_commit_id":"5f20c12078ac67c8cc62350082d9cef51a26d356","user":{"login":"manucorporat","id":127379,"avatar_url":"https://avatars1.githubusercontent.com/u/127379?v=3","gravatar_id":"","url":"https://api.github.com/users/manucorporat","html_url":"https://github.com/manucorporat","followers_url":"https://api.github.com/users/manucorporat/followers","following_url":"https://api.github.com/users/manucorporat/following{/other_user}","gists_url":"https://api.github.com/users/manucorporat/gists{/gist_id}","starred_url":"https://api.github.com/users/manucorporat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manucorporat/subscriptions","organizations_url":"https://api.github.com/users/manucorporat/orgs","repos_url":"https://api.github.com/users/manucorporat/repos","events_url":"https://api.github.com/users/manucorporat/events{/privacy}","received_events_url":"https://api.github.com/users/manucorporat/received_events","type":"User","site_admin":false},"body":"revert","created_at":"2017-05-01T16:20:55Z","updated_at":"2017-05-01T16:25:00Z","html_url":"https://github.com/driftyco/ionic/pull/11296#discussion_r114148886","pull_request_url":"https://api.github.com/repos/driftyco/ionic/pulls/11296","_links":{"self":{"href":"https://api.github.com/repos/driftyco/ionic/pulls/comments/114148886"},"html":{"href":"https://github.com/driftyco/ionic/pull/11296#discussion_r114148886"},"pull_request":{"href":"https://api.github.com/repos/driftyco/ionic/pulls/11296"}}},"pull_request":{"url":"https://api.github.com/repos/driftyco/ionic/pulls/11296","id":116806988,"html_url":"https://github.com/driftyco/ionic/pull/11296","diff_url":"https://github.com/driftyco/ionic/pull/11296.diff","patch_url":"https://github.com/driftyco/ionic/pull/11296.patch","issue_url":"https://api.github.com/repos/driftyco/ionic/issues/11296","number":11296,"state":"open","locked":false,"title":"refactor(): global refactoring to avoid IDE warnings and cleaner code","user":{"login":"AmitMY","id":5757359,"avatar_url":"https://avatars2.githubusercontent.com/u/5757359?v=3","gravatar_id":"","url":"https://api.github.com/users/AmitMY","html_url":"https://github.com/AmitMY","followers_url":"https://api.github.com/users/AmitMY/followers","following_url":"https://api.github.com/users/AmitMY/following{/other_user}","gists_url":"https://api.github.com/users/AmitMY/gists{/gist_id}","starred_url":"https://api.github.com/users/AmitMY/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AmitMY/subscriptions","organizations_url":"https://api.github.com/users/AmitMY/orgs","repos_url":"https://api.github.com/users/AmitMY/repos","events_url":"https://api.github.com/users/AmitMY/events{/privacy}","received_events_url":"https://api.github.com/users/AmitMY/received_events","type":"User","site_admin":false},"body":"#### Short description of what this resolves:\r\nSome doc issues, unused variables, and useless injections\r\nBasically, many code warning from tslint / WebStorm IDE, that are definitely volatile.\r\n\r\n\r\n#### Changes proposed in this pull request:\r\n- `refactor(style): redundant measure units` => `0` does not need `px` or `%`\r\n- `refactor(): change redundant 'if' statement` => replace `if(a) return true; else return false` to `return Boolean(a)`\r\n- `refactor(style): remove overwritten property value` => weird cases where an attribute is there twice\r\n- `fix(spellcheck): wrong attribute value` => `spellcheck` gets \"true\"|\"false\" not \"on\"|\"off\"\r\n- `refactor(datetime-test): There should be a space between attribute an…` => adds a missing space\r\n- `refactor(import): import can be shortened` => shortened import paths\r\n- `refactor(semicolon): add missing semicolon` => add missing semicolons\r\n- `docs(): fix incorrect parameter name` => fix parameter names/description where possible\r\n- `refactor(): remove trailing unused parameters` => remove unused parameters in methods if will not create an error\r\n- `fix(menu): create mock change signature` => fix of error from last commit\r\n- `refactor(): remove redundant imports ` => remove of unused imports after removing of parameters\r\n\r\nReverted:\r\n- `refactor(style): 'var' used instead of 'let' or 'const'` => ES2015 instead of ES5 where possible\r\n\r\nAll tests pass.\r\nIf you review this PR, it is better to go commit by commit instead of file by file, as every commit is a bunched up refactor\r\n\r\n**Ionic Version**: 3.1.x\r\n\r\n","created_at":"2017-04-20T15:59:44Z","updated_at":"2017-05-01T16:25:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7c4409d351070c0a4a07518b6deb61c4982477d8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/driftyco/ionic/pulls/11296/commits","review_comments_url":"https://api.github.com/repos/driftyco/ionic/pulls/11296/comments","review_comment_url":"https://api.github.com/repos/driftyco/ionic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/driftyco/ionic/issues/11296/comments","statuses_url":"https://api.github.com/repos/driftyco/ionic/statuses/5f20c12078ac67c8cc62350082d9cef51a26d356","head":{"label":"AmitMY:refactor","ref":"refactor","sha":"5f20c12078ac67c8cc62350082d9cef51a26d356","user":{"login":"AmitMY","id":5757359,"avatar_url":"https://avatars2.githubusercontent.com/u/5757359?v=3","gravatar_id":"","url":"https://api.github.com/users/AmitMY","html_url":"https://github.com/AmitMY","followers_url":"https://api.github.com/users/AmitMY/followers","following_url":"https://api.github.com/users/AmitMY/following{/other_user}","gists_url":"https://api.github.com/users/AmitMY/gists{/gist_id}","starred_url":"https://api.github.com/users/AmitMY/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AmitMY/subscriptions","organizations_url":"https://api.github.com/users/AmitMY/orgs","repos_url":"https://api.github.com/users/AmitMY/repos","events_url":"https://api.github.com/users/AmitMY/events{/privacy}","received_events_url":"https://api.github.com/users/AmitMY/received_events","type":"User","site_admin":false},"repo":{"id":84882301,"name":"ionic","full_name":"AmitMY/ionic","owner":{"login":"AmitMY","id":5757359,"avatar_url":"https://avatars2.githubusercontent.com/u/5757359?v=3","gravatar_id":"","url":"https://api.github.com/users/AmitMY","html_url":"https://github.com/AmitMY","followers_url":"https://api.github.com/users/AmitMY/followers","following_url":"https://api.github.com/users/AmitMY/following{/other_user}","gists_url":"https://api.github.com/users/AmitMY/gists{/gist_id}","starred_url":"https://api.github.com/users/AmitMY/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AmitMY/subscriptions","organizations_url":"https://api.github.com/users/AmitMY/orgs","repos_url":"https://api.github.com/users/AmitMY/repos","events_url":"https://api.github.com/users/AmitMY/events{/privacy}","received_events_url":"https://api.github.com/users/AmitMY/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AmitMY/ionic","description":"Build amazing native and progressive web apps with Angular and open web technologies. One app running on everything 🎉","fork":true,"url":"https://api.github.com/repos/AmitMY/ionic","forks_url":"https://api.github.com/repos/AmitMY/ionic/forks","keys_url":"https://api.github.com/repos/AmitMY/ionic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AmitMY/ionic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AmitMY/ionic/teams","hooks_url":"https://api.github.com/repos/AmitMY/ionic/hooks","issue_events_url":"https://api.github.com/repos/AmitMY/ionic/issues/events{/number}","events_url":"https://api.github.com/repos/AmitMY/ionic/events","assignees_url":"https://api.github.com/repos/AmitMY/ionic/assignees{/user}","branches_url":"https://api.github.com/repos/AmitMY/ionic/branches{/branch}","tags_url":"https://api.github.com/repos/AmitMY/ionic/tags","blobs_url":"https://api.github.com/repos/AmitMY/ionic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AmitMY/ionic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AmitMY/ionic/git/refs{/sha}","trees_url":"https://api.github.com/repos/AmitMY/ionic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AmitMY/ionic/statuses/{sha}","languages_url":"https://api.github.com/repos/AmitMY/ionic/languages","stargazers_url":"https://api.github.com/repos/AmitMY/ionic/stargazers","contributors_url":"https://api.github.com/repos/AmitMY/ionic/contributors","subscribers_url":"https://api.github.com/repos/AmitMY/ionic/subscribers","subscription_url":"https://api.github.com/repos/AmitMY/ionic/subscription","commits_url":"https://api.github.com/repos/AmitMY/ionic/commits{/sha}","git_commits_url":"https://api.github.com/repos/AmitMY/ionic/git/commits{/sha}","comments_url":"https://api.github.com/repos/AmitMY/ionic/comments{/number}","issue_comment_url":"https://api.github.com/repos/AmitMY/ionic/issues/comments{/number}","contents_url":"https://api.github.com/repos/AmitMY/ionic/contents/{+path}","compare_url":"https://api.github.com/repos/AmitMY/ionic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AmitMY/ionic/merges","archive_url":"https://api.github.com/repos/AmitMY/ionic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AmitMY/ionic/downloads","issues_url":"https://api.github.com/repos/AmitMY/ionic/issues{/number}","pulls_url":"https://api.github.com/repos/AmitMY/ionic/pulls{/number}","milestones_url":"https://api.github.com/repos/AmitMY/ionic/milestones{/number}","notifications_url":"https://api.github.com/repos/AmitMY/ionic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AmitMY/ionic/labels{/name}","releases_url":"https://api.github.com/repos/AmitMY/ionic/releases{/id}","deployments_url":"https://api.github.com/repos/AmitMY/ionic/deployments","created_at":"2017-03-13T22:54:27Z","updated_at":"2017-03-13T22:54:35Z","pushed_at":"2017-05-01T16:17:55Z","git_url":"git://github.com/AmitMY/ionic.git","ssh_url":"git@github.com:AmitMY/ionic.git","clone_url":"https://github.com/AmitMY/ionic.git","svn_url":"https://github.com/AmitMY/ionic","homepage":"http://ionicframework.com/","size":71753,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"driftyco:master","ref":"master","sha":"d701799d8b2db2ef5ee323aa5b8783b9632ccc11","user":{"login":"driftyco","id":3171503,"avatar_url":"https://avatars3.githubusercontent.com/u/3171503?v=3","gravatar_id":"","url":"https://api.github.com/users/driftyco","html_url":"https://github.com/driftyco","followers_url":"https://api.github.com/users/driftyco/followers","following_url":"https://api.github.com/users/driftyco/following{/other_user}","gists_url":"https://api.github.com/users/driftyco/gists{/gist_id}","starred_url":"https://api.github.com/users/driftyco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/driftyco/subscriptions","organizations_url":"https://api.github.com/users/driftyco/orgs","repos_url":"https://api.github.com/users/driftyco/repos","events_url":"https://api.github.com/users/driftyco/events{/privacy}","received_events_url":"https://api.github.com/users/driftyco/received_events","type":"Organization","site_admin":false},"repo":{"id":12256376,"name":"ionic","full_name":"driftyco/ionic","owner":{"login":"driftyco","id":3171503,"avatar_url":"https://avatars3.githubusercontent.com/u/3171503?v=3","gravatar_id":"","url":"https://api.github.com/users/driftyco","html_url":"https://github.com/driftyco","followers_url":"https://api.github.com/users/driftyco/followers","following_url":"https://api.github.com/users/driftyco/following{/other_user}","gists_url":"https://api.github.com/users/driftyco/gists{/gist_id}","starred_url":"https://api.github.com/users/driftyco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/driftyco/subscriptions","organizations_url":"https://api.github.com/users/driftyco/orgs","repos_url":"https://api.github.com/users/driftyco/repos","events_url":"https://api.github.com/users/driftyco/events{/privacy}","received_events_url":"https://api.github.com/users/driftyco/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/driftyco/ionic","description":"Build amazing native and progressive web apps with Angular and open web technologies. One app running on everything 🎉","fork":false,"url":"https://api.github.com/repos/driftyco/ionic","forks_url":"https://api.github.com/repos/driftyco/ionic/forks","keys_url":"https://api.github.com/repos/driftyco/ionic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/driftyco/ionic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/driftyco/ionic/teams","hooks_url":"https://api.github.com/repos/driftyco/ionic/hooks","issue_events_url":"https://api.github.com/repos/driftyco/ionic/issues/events{/number}","events_url":"https://api.github.com/repos/driftyco/ionic/events","assignees_url":"https://api.github.com/repos/driftyco/ionic/assignees{/user}","branches_url":"https://api.github.com/repos/driftyco/ionic/branches{/branch}","tags_url":"https://api.github.com/repos/driftyco/ionic/tags","blobs_url":"https://api.github.com/repos/driftyco/ionic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/driftyco/ionic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/driftyco/ionic/git/refs{/sha}","trees_url":"https://api.github.com/repos/driftyco/ionic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/driftyco/ionic/statuses/{sha}","languages_url":"https://api.github.com/repos/driftyco/ionic/languages","stargazers_url":"https://api.github.com/repos/driftyco/ionic/stargazers","contributors_url":"https://api.github.com/repos/driftyco/ionic/contributors","subscribers_url":"https://api.github.com/repos/driftyco/ionic/subscribers","subscription_url":"https://api.github.com/repos/driftyco/ionic/subscription","commits_url":"https://api.github.com/repos/driftyco/ionic/commits{/sha}","git_commits_url":"https://api.github.com/repos/driftyco/ionic/git/commits{/sha}","comments_url":"https://api.github.com/repos/driftyco/ionic/comments{/number}","issue_comment_url":"https://api.github.com/repos/driftyco/ionic/issues/comments{/number}","contents_url":"https://api.github.com/repos/driftyco/ionic/contents/{+path}","compare_url":"https://api.github.com/repos/driftyco/ionic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/driftyco/ionic/merges","archive_url":"https://api.github.com/repos/driftyco/ionic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/driftyco/ionic/downloads","issues_url":"https://api.github.com/repos/driftyco/ionic/issues{/number}","pulls_url":"https://api.github.com/repos/driftyco/ionic/pulls{/number}","milestones_url":"https://api.github.com/repos/driftyco/ionic/milestones{/number}","notifications_url":"https://api.github.com/repos/driftyco/ionic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/driftyco/ionic/labels{/name}","releases_url":"https://api.github.com/repos/driftyco/ionic/releases{/id}","deployments_url":"https://api.github.com/repos/driftyco/ionic/deployments","created_at":"2013-08-20T23:06:02Z","updated_at":"2017-05-01T16:02:24Z","pushed_at":"2017-05-01T16:17:56Z","git_url":"git://github.com/driftyco/ionic.git","ssh_url":"git@github.com:driftyco/ionic.git","clone_url":"https://github.com/driftyco/ionic.git","svn_url":"https://github.com/driftyco/ionic","homepage":"http://ionicframework.com/","size":71535,"stargazers_count":29291,"watchers_count":29291,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7474,"mirror_url":null,"open_issues_count":770,"forks":7474,"open_issues":770,"watchers":29291,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/driftyco/ionic/pulls/11296"},"html":{"href":"https://github.com/driftyco/ionic/pull/11296"},"issue":{"href":"https://api.github.com/repos/driftyco/ionic/issues/11296"},"comments":{"href":"https://api.github.com/repos/driftyco/ionic/issues/11296/comments"},"review_comments":{"href":"https://api.github.com/repos/driftyco/ionic/pulls/11296/comments"},"review_comment":{"href":"https://api.github.com/repos/driftyco/ionic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/driftyco/ionic/pulls/11296/commits"},"statuses":{"href":"https://api.github.com/repos/driftyco/ionic/statuses/5f20c12078ac67c8cc62350082d9cef51a26d356"}}}}
{"actor":{"display_login":"manucorporat"}}