{"action":"created","issue":{"url":"https://api.github.com/repos/Islandora/islandora_solr_metadata/issues/51","repository_url":"https://api.github.com/repos/Islandora/islandora_solr_metadata","labels_url":"https://api.github.com/repos/Islandora/islandora_solr_metadata/issues/51/labels{/name}","comments_url":"https://api.github.com/repos/Islandora/islandora_solr_metadata/issues/51/comments","events_url":"https://api.github.com/repos/Islandora/islandora_solr_metadata/issues/51/events","html_url":"https://github.com/Islandora/islandora_solr_metadata/pull/51","id":199276958,"number":51,"title":"7.x islandora 1872 - Allow custom value separator for Solr","user":{"login":"BrandonMorr","id":5700335,"avatar_url":"https://avatars.githubusercontent.com/u/5700335?v=3","gravatar_id":"","url":"https://api.github.com/users/BrandonMorr","html_url":"https://github.com/BrandonMorr","followers_url":"https://api.github.com/users/BrandonMorr/followers","following_url":"https://api.github.com/users/BrandonMorr/following{/other_user}","gists_url":"https://api.github.com/users/BrandonMorr/gists{/gist_id}","starred_url":"https://api.github.com/users/BrandonMorr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrandonMorr/subscriptions","organizations_url":"https://api.github.com/users/BrandonMorr/orgs","repos_url":"https://api.github.com/users/BrandonMorr/repos","events_url":"https://api.github.com/users/BrandonMorr/events{/privacy}","received_events_url":"https://api.github.com/users/BrandonMorr/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-01-06T20:08:12Z","updated_at":"2017-01-24T15:52:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Islandora/islandora_solr_metadata/pulls/51","html_url":"https://github.com/Islandora/islandora_solr_metadata/pull/51","diff_url":"https://github.com/Islandora/islandora_solr_metadata/pull/51.diff","patch_url":"https://github.com/Islandora/islandora_solr_metadata/pull/51.patch"},"body":"**JIRA Ticket**: https://jira.duraspace.org/browse/ISLANDORA-1872\r\n\r\n# What does this Pull Request do?\r\n\r\nThis will allow the user to specify a separator between multivalued fields in solr metadata display.\r\n\r\n# What's new?\r\n\r\n* added new textfield in the general configuration form 'islandora_solr_metadata_field_value_separator'.\r\n* added a check for empty values in the admin form validation handler. This is to prevent users from saving the form and having empty values passed to the display, causing results to look messy.\r\n* the separator usage has been added to islandora-solr-metadata-description.tpl.php & islandora-solr-metadata-display.tpl.php templates.\r\n\r\n# How should this be tested?\r\n\r\n* Ingest an object and create some multivalued fields (mods_name_personal_creator_namePart_ms for example).\r\n* Navigate to your.site/admin/islandora/search/islandora_solr/metadata and under the 'General Configuration' tab you will see a new field labelled 'Field value separator'.\r\n* Enter test values, and also test that empty values are being set to NULL and falling back to default separators.\r\n* Make sure your multivalued field is in a solr metadata display configuration.\r\n\r\n# Interested parties\r\n@Islandora/7-x-1-x-committers, @nhart"},"comment":{"url":"https://api.github.com/repos/Islandora/islandora_solr_metadata/issues/comments/274843684","html_url":"https://github.com/Islandora/islandora_solr_metadata/pull/51#issuecomment-274843684","issue_url":"https://api.github.com/repos/Islandora/islandora_solr_metadata/issues/51","id":274843684,"user":{"login":"nhart","id":766086,"avatar_url":"https://avatars.githubusercontent.com/u/766086?v=3","gravatar_id":"","url":"https://api.github.com/users/nhart","html_url":"https://github.com/nhart","followers_url":"https://api.github.com/users/nhart/followers","following_url":"https://api.github.com/users/nhart/following{/other_user}","gists_url":"https://api.github.com/users/nhart/gists{/gist_id}","starred_url":"https://api.github.com/users/nhart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nhart/subscriptions","organizations_url":"https://api.github.com/users/nhart/orgs","repos_url":"https://api.github.com/users/nhart/repos","events_url":"https://api.github.com/users/nhart/events{/privacy}","received_events_url":"https://api.github.com/users/nhart/received_events","type":"User","site_admin":false},"created_at":"2017-01-24T15:52:09Z","updated_at":"2017-01-24T15:52:09Z","body":"@whikloj are you able to have a look at this one as well? same functionality as https://github.com/Islandora/islandora_solr_search/pull/302, just in Solr metadata"}}
{"actor":{"display_login":"nhart"}}