{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/puppetlabs-iis/pulls/comments/130492121","pull_request_review_id":53372788,"id":130492121,"diff_hunk":"@@ -171,4 +180,19 @@ def self.to_bool(value)\n     return :false  if value == false  || value =~ (/(^$|false|f|no|n|0)$/i)\n     raise ArgumentError.new(\"invalid value for Boolean: \\\"#{value}\\\"\")\n   end\n+\n+  def verify_physicalpath","path":"lib/puppet/provider/iis_site/webadministration.rb","position":37,"original_position":37,"commit_id":"d9774bfea12f07998a2bbcfc35e190f24a7ad0d8","original_commit_id":"d9774bfea12f07998a2bbcfc35e190f24a7ad0d8","user":{"login":"jpogran","id":272569,"avatar_url":"https://avatars1.githubusercontent.com/u/272569?v=4","gravatar_id":"","url":"https://api.github.com/users/jpogran","html_url":"https://github.com/jpogran","followers_url":"https://api.github.com/users/jpogran/followers","following_url":"https://api.github.com/users/jpogran/following{/other_user}","gists_url":"https://api.github.com/users/jpogran/gists{/gist_id}","starred_url":"https://api.github.com/users/jpogran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpogran/subscriptions","organizations_url":"https://api.github.com/users/jpogran/orgs","repos_url":"https://api.github.com/users/jpogran/repos","events_url":"https://api.github.com/users/jpogran/events{/privacy}","received_events_url":"https://api.github.com/users/jpogran/received_events","type":"User","site_admin":false},"body":"We should move this to a helper method instead of having it in each provider","created_at":"2017-08-01T00:00:09Z","updated_at":"2017-08-01T00:03:45Z","html_url":"https://github.com/puppetlabs/puppetlabs-iis/pull/90#discussion_r130492121","pull_request_url":"https://api.github.com/repos/puppetlabs/puppetlabs-iis/pulls/90","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-iis/pulls/comments/130492121"},"html":{"href":"https://github.com/puppetlabs/puppetlabs-iis/pull/90#discussion_r130492121"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-iis/pulls/90"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppetlabs-iis/pulls/90","id":131844736,"html_url":"https://github.com/puppetlabs/puppetlabs-iis/pull/90","diff_url":"https://github.com/puppetlabs/puppetlabs-iis/pull/90.diff","patch_url":"https://github.com/puppetlabs/puppetlabs-iis/pull/90.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppetlabs-iis/issues/90","number":90,"state":"open","locked":false,"title":"(MODULES-5264) IIS: handle UNC paths","user":{"login":"tkishel","id":1613311,"avatar_url":"https://avatars0.githubusercontent.com/u/1613311?v=4","gravatar_id":"","url":"https://api.github.com/users/tkishel","html_url":"https://github.com/tkishel","followers_url":"https://api.github.com/users/tkishel/followers","following_url":"https://api.github.com/users/tkishel/following{/other_user}","gists_url":"https://api.github.com/users/tkishel/gists{/gist_id}","starred_url":"https://api.github.com/users/tkishel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkishel/subscriptions","organizations_url":"https://api.github.com/users/tkishel/orgs","repos_url":"https://api.github.com/users/tkishel/repos","events_url":"https://api.github.com/users/tkishel/events{/privacy}","received_events_url":"https://api.github.com/users/tkishel/received_events","type":"User","site_admin":false},"body":"Prior to this commit, the IIS module:\r\n\r\nincluded regular expressions that failed to a match a UNC paths\r\nattempted to use File.exists? to test a UNC path\r\nfailed to set iis_virtual_directory physicalpath to a UNC path\r\n\r\nAlso, these issues interfered with development and testing:\r\n\r\nran iis_virtual_directory update() after destroy()\r\nfailed to set the iis_site :ensure attribute to :present\r\nfailed to set the iis_virtual_directory :application attribute","created_at":"2017-07-21T19:40:52Z","updated_at":"2017-08-01T00:03:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6501ca486e0c8557abf9d8d3a67f1667e723934f","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppetlabs-iis/pulls/90/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-iis/pulls/90/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppetlabs-iis/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-iis/issues/90/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppetlabs-iis/statuses/d9774bfea12f07998a2bbcfc35e190f24a7ad0d8","head":{"label":"tkishel:MODULES-5264_handle_unc_paths","ref":"MODULES-5264_handle_unc_paths","sha":"d9774bfea12f07998a2bbcfc35e190f24a7ad0d8","user":{"login":"tkishel","id":1613311,"avatar_url":"https://avatars0.githubusercontent.com/u/1613311?v=4","gravatar_id":"","url":"https://api.github.com/users/tkishel","html_url":"https://github.com/tkishel","followers_url":"https://api.github.com/users/tkishel/followers","following_url":"https://api.github.com/users/tkishel/following{/other_user}","gists_url":"https://api.github.com/users/tkishel/gists{/gist_id}","starred_url":"https://api.github.com/users/tkishel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkishel/subscriptions","organizations_url":"https://api.github.com/users/tkishel/orgs","repos_url":"https://api.github.com/users/tkishel/repos","events_url":"https://api.github.com/users/tkishel/events{/privacy}","received_events_url":"https://api.github.com/users/tkishel/received_events","type":"User","site_admin":false},"repo":{"id":97652024,"name":"puppetlabs-iis","full_name":"tkishel/puppetlabs-iis","owner":{"login":"tkishel","id":1613311,"avatar_url":"https://avatars0.githubusercontent.com/u/1613311?v=4","gravatar_id":"","url":"https://api.github.com/users/tkishel","html_url":"https://github.com/tkishel","followers_url":"https://api.github.com/users/tkishel/followers","following_url":"https://api.github.com/users/tkishel/following{/other_user}","gists_url":"https://api.github.com/users/tkishel/gists{/gist_id}","starred_url":"https://api.github.com/users/tkishel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkishel/subscriptions","organizations_url":"https://api.github.com/users/tkishel/orgs","repos_url":"https://api.github.com/users/tkishel/repos","events_url":"https://api.github.com/users/tkishel/events{/privacy}","received_events_url":"https://api.github.com/users/tkishel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tkishel/puppetlabs-iis","description":"Manage IIS for Windows Server 2008 and above. Maintain application sites, pools, virtual applications, and many other IIS settings.","fork":true,"url":"https://api.github.com/repos/tkishel/puppetlabs-iis","forks_url":"https://api.github.com/repos/tkishel/puppetlabs-iis/forks","keys_url":"https://api.github.com/repos/tkishel/puppetlabs-iis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tkishel/puppetlabs-iis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tkishel/puppetlabs-iis/teams","hooks_url":"https://api.github.com/repos/tkishel/puppetlabs-iis/hooks","issue_events_url":"https://api.github.com/repos/tkishel/puppetlabs-iis/issues/events{/number}","events_url":"https://api.github.com/repos/tkishel/puppetlabs-iis/events","assignees_url":"https://api.github.com/repos/tkishel/puppetlabs-iis/assignees{/user}","branches_url":"https://api.github.com/repos/tkishel/puppetlabs-iis/branches{/branch}","tags_url":"https://api.github.com/repos/tkishel/puppetlabs-iis/tags","blobs_url":"https://api.github.com/repos/tkishel/puppetlabs-iis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tkishel/puppetlabs-iis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tkishel/puppetlabs-iis/git/refs{/sha}","trees_url":"https://api.github.com/repos/tkishel/puppetlabs-iis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tkishel/puppetlabs-iis/statuses/{sha}","languages_url":"https://api.github.com/repos/tkishel/puppetlabs-iis/languages","stargazers_url":"https://api.github.com/repos/tkishel/puppetlabs-iis/stargazers","contributors_url":"https://api.github.com/repos/tkishel/puppetlabs-iis/contributors","subscribers_url":"https://api.github.com/repos/tkishel/puppetlabs-iis/subscribers","subscription_url":"https://api.github.com/repos/tkishel/puppetlabs-iis/subscription","commits_url":"https://api.github.com/repos/tkishel/puppetlabs-iis/commits{/sha}","git_commits_url":"https://api.github.com/repos/tkishel/puppetlabs-iis/git/commits{/sha}","comments_url":"https://api.github.com/repos/tkishel/puppetlabs-iis/comments{/number}","issue_comment_url":"https://api.github.com/repos/tkishel/puppetlabs-iis/issues/comments{/number}","contents_url":"https://api.github.com/repos/tkishel/puppetlabs-iis/contents/{+path}","compare_url":"https://api.github.com/repos/tkishel/puppetlabs-iis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tkishel/puppetlabs-iis/merges","archive_url":"https://api.github.com/repos/tkishel/puppetlabs-iis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tkishel/puppetlabs-iis/downloads","issues_url":"https://api.github.com/repos/tkishel/puppetlabs-iis/issues{/number}","pulls_url":"https://api.github.com/repos/tkishel/puppetlabs-iis/pulls{/number}","milestones_url":"https://api.github.com/repos/tkishel/puppetlabs-iis/milestones{/number}","notifications_url":"https://api.github.com/repos/tkishel/puppetlabs-iis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tkishel/puppetlabs-iis/labels{/name}","releases_url":"https://api.github.com/repos/tkishel/puppetlabs-iis/releases{/id}","deployments_url":"https://api.github.com/repos/tkishel/puppetlabs-iis/deployments","created_at":"2017-07-18T23:22:39Z","updated_at":"2017-07-18T23:22:41Z","pushed_at":"2017-07-31T23:56:13Z","git_url":"git://github.com/tkishel/puppetlabs-iis.git","ssh_url":"git@github.com:tkishel/puppetlabs-iis.git","clone_url":"https://github.com/tkishel/puppetlabs-iis.git","svn_url":"https://github.com/tkishel/puppetlabs-iis","homepage":"","size":273,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"b972388d9e6df2e38dfd4260c71aaa185ea8ffea","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars0.githubusercontent.com/u/234268?v=4","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":63275859,"name":"puppetlabs-iis","full_name":"puppetlabs/puppetlabs-iis","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars0.githubusercontent.com/u/234268?v=4","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppetlabs-iis","description":"Manage IIS for Windows Server 2008 and above. Maintain application sites, pools, virtual applications, and many other IIS settings.","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppetlabs-iis","forks_url":"https://api.github.com/repos/puppetlabs/puppetlabs-iis/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppetlabs-iis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppetlabs-iis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppetlabs-iis/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppetlabs-iis/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppetlabs-iis/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppetlabs-iis/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppetlabs-iis/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppetlabs-iis/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppetlabs-iis/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppetlabs-iis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppetlabs-iis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppetlabs-iis/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppetlabs-iis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppetlabs-iis/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppetlabs-iis/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppetlabs-iis/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppetlabs-iis/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppetlabs-iis/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppetlabs-iis/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppetlabs-iis/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppetlabs-iis/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-iis/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppetlabs-iis/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/puppetlabs-iis/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppetlabs-iis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppetlabs-iis/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppetlabs-iis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppetlabs-iis/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppetlabs-iis/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppetlabs-iis/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppetlabs-iis/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppetlabs-iis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppetlabs-iis/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppetlabs-iis/releases{/id}","deployments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-iis/deployments","created_at":"2016-07-13T20:05:55Z","updated_at":"2017-06-24T11:37:40Z","pushed_at":"2017-07-31T23:56:15Z","git_url":"git://github.com/puppetlabs/puppetlabs-iis.git","ssh_url":"git@github.com:puppetlabs/puppetlabs-iis.git","clone_url":"https://github.com/puppetlabs/puppetlabs-iis.git","svn_url":"https://github.com/puppetlabs/puppetlabs-iis","homepage":"","size":261,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":22,"mirror_url":null,"open_issues_count":4,"forks":22,"open_issues":4,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-iis/pulls/90"},"html":{"href":"https://github.com/puppetlabs/puppetlabs-iis/pull/90"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-iis/issues/90"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-iis/issues/90/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-iis/pulls/90/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-iis/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-iis/pulls/90/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-iis/statuses/d9774bfea12f07998a2bbcfc35e190f24a7ad0d8"}}}}
{"actor":{"display_login":"jpogran"}}