{"action":"created","comment":{"url":"https://api.github.com/repos/saltstack/salt-testing/pulls/comments/99009716","pull_request_review_id":19658940,"id":99009716,"diff_hunk":"@@ -1251,26 +1686,37 @@ def build_default_test_command(options):\n             '--parallel-mode',\n         ])\n \n+    # Append basic command\n+    if getattr(options, 'windows', False):\n+        test_command.append(\n+            '{0}\\\\tests\\\\runtests.py'.format(options.package_source_dir))\n+    else:\n+        test_command.append(\n+            '/{0}/tests/runtests.py'.format(options.package_source_dir))\n     # Append basic command parameters\n     test_command.extend([\n-        '/testing/tests/runtests.py',\n         '-v',\n         '--run-destructive',\n         '--sysinfo',\n-        '--xml=/tmp/xml-unittests-output',\n         '--transport={0}'.format(options.test_transport),\n         '--output-columns={0}'.format(options.output_columns),\n     ])\n \n     # Append extra and conditional parameters\n     pillar = build_pillar_data(options, convert_to_yaml=False)\n     git_branch = pillar.get('git_branch', 'develop')\n-    if git_branch and git_branch not in('2014.1',):\n+    if git_branch and git_branch not in('2014.1',) and \\\n+            not getattr(options, 'windows', False):\n         test_command.append('--ssh')\n     if options.test_without_coverage is False and options.test_with_new_coverage is False:\n         test_command.append('--coverage-xml=/tmp/coverage.xml')\n     if options.no_color:\n         test_command.append('--no-color')\n+    if getattr(options, 'windows', False):\n+        test_command.append(\n+            '--names-file=\"{0}\\\\tests\\\\whitelist.txt\"'\n+            ''.format(options.package_source_dir))","path":"salttesting/jenkins.py","position":786,"original_position":786,"commit_id":"c52aabea02d85cfce463f5e1922ccafee2154f1b","original_commit_id":"c52aabea02d85cfce463f5e1922ccafee2154f1b","user":{"login":"cachedout","id":111616,"avatar_url":"https://avatars.githubusercontent.com/u/111616?v=3","gravatar_id":"","url":"https://api.github.com/users/cachedout","html_url":"https://github.com/cachedout","followers_url":"https://api.github.com/users/cachedout/followers","following_url":"https://api.github.com/users/cachedout/following{/other_user}","gists_url":"https://api.github.com/users/cachedout/gists{/gist_id}","starred_url":"https://api.github.com/users/cachedout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cachedout/subscriptions","organizations_url":"https://api.github.com/users/cachedout/orgs","repos_url":"https://api.github.com/users/cachedout/repos","events_url":"https://api.github.com/users/cachedout/events{/privacy}","received_events_url":"https://api.github.com/users/cachedout/received_events","type":"User","site_admin":false},"body":"What is the purpose of these two additional quotation marks?","created_at":"2017-02-01T22:14:23Z","updated_at":"2017-02-01T22:59:01Z","html_url":"https://github.com/saltstack/salt-testing/pull/113#discussion_r99009716","pull_request_url":"https://api.github.com/repos/saltstack/salt-testing/pulls/113","_links":{"self":{"href":"https://api.github.com/repos/saltstack/salt-testing/pulls/comments/99009716"},"html":{"href":"https://github.com/saltstack/salt-testing/pull/113#discussion_r99009716"},"pull_request":{"href":"https://api.github.com/repos/saltstack/salt-testing/pulls/113"}}},"pull_request":{"url":"https://api.github.com/repos/saltstack/salt-testing/pulls/113","id":104222845,"html_url":"https://github.com/saltstack/salt-testing/pull/113","diff_url":"https://github.com/saltstack/salt-testing/pull/113.diff","patch_url":"https://github.com/saltstack/salt-testing/pull/113.patch","issue_url":"https://api.github.com/repos/saltstack/salt-testing/issues/113","number":113,"state":"open","locked":false,"title":"Tests on Windows with Jenkins","user":{"login":"twangboy","id":9383935,"avatar_url":"https://avatars.githubusercontent.com/u/9383935?v=3","gravatar_id":"","url":"https://api.github.com/users/twangboy","html_url":"https://github.com/twangboy","followers_url":"https://api.github.com/users/twangboy/followers","following_url":"https://api.github.com/users/twangboy/following{/other_user}","gists_url":"https://api.github.com/users/twangboy/gists{/gist_id}","starred_url":"https://api.github.com/users/twangboy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twangboy/subscriptions","organizations_url":"https://api.github.com/users/twangboy/orgs","repos_url":"https://api.github.com/users/twangboy/repos","events_url":"https://api.github.com/users/twangboy/events{/privacy}","received_events_url":"https://api.github.com/users/twangboy/received_events","type":"User","site_admin":false},"body":"Adds two parameters:\r\n- `--windows` to designate that this is a Windows minion\r\n- `--update-winrepo` to update the winrepo on the master for the pkg tests and some of the setup states\r\n\r\nWhen the `--windows` switch is passed it will:\r\n- Use winexe in place of ssh\r\n- Use SMB to copy artifacts back to the slave\r\n\r\nAdds a reboot after the minion is installed in order for the `salt-call` commands to run.","created_at":"2017-02-01T21:12:49Z","updated_at":"2017-02-01T22:59:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"47baa575b94e0428f23ec5c9946911f941780187","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/saltstack/salt-testing/pulls/113/commits","review_comments_url":"https://api.github.com/repos/saltstack/salt-testing/pulls/113/comments","review_comment_url":"https://api.github.com/repos/saltstack/salt-testing/pulls/comments{/number}","comments_url":"https://api.github.com/repos/saltstack/salt-testing/issues/113/comments","statuses_url":"https://api.github.com/repos/saltstack/salt-testing/statuses/c52aabea02d85cfce463f5e1922ccafee2154f1b","head":{"label":"twangboy:win_jenkins","ref":"win_jenkins","sha":"c52aabea02d85cfce463f5e1922ccafee2154f1b","user":{"login":"twangboy","id":9383935,"avatar_url":"https://avatars.githubusercontent.com/u/9383935?v=3","gravatar_id":"","url":"https://api.github.com/users/twangboy","html_url":"https://github.com/twangboy","followers_url":"https://api.github.com/users/twangboy/followers","following_url":"https://api.github.com/users/twangboy/following{/other_user}","gists_url":"https://api.github.com/users/twangboy/gists{/gist_id}","starred_url":"https://api.github.com/users/twangboy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twangboy/subscriptions","organizations_url":"https://api.github.com/users/twangboy/orgs","repos_url":"https://api.github.com/users/twangboy/repos","events_url":"https://api.github.com/users/twangboy/events{/privacy}","received_events_url":"https://api.github.com/users/twangboy/received_events","type":"User","site_admin":false},"repo":{"id":62901653,"name":"salt-testing","full_name":"twangboy/salt-testing","owner":{"login":"twangboy","id":9383935,"avatar_url":"https://avatars.githubusercontent.com/u/9383935?v=3","gravatar_id":"","url":"https://api.github.com/users/twangboy","html_url":"https://github.com/twangboy","followers_url":"https://api.github.com/users/twangboy/followers","following_url":"https://api.github.com/users/twangboy/following{/other_user}","gists_url":"https://api.github.com/users/twangboy/gists{/gist_id}","starred_url":"https://api.github.com/users/twangboy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twangboy/subscriptions","organizations_url":"https://api.github.com/users/twangboy/orgs","repos_url":"https://api.github.com/users/twangboy/repos","events_url":"https://api.github.com/users/twangboy/events{/privacy}","received_events_url":"https://api.github.com/users/twangboy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/twangboy/salt-testing","description":"Common testing tools used in the Salt Stack projects","fork":true,"url":"https://api.github.com/repos/twangboy/salt-testing","forks_url":"https://api.github.com/repos/twangboy/salt-testing/forks","keys_url":"https://api.github.com/repos/twangboy/salt-testing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twangboy/salt-testing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twangboy/salt-testing/teams","hooks_url":"https://api.github.com/repos/twangboy/salt-testing/hooks","issue_events_url":"https://api.github.com/repos/twangboy/salt-testing/issues/events{/number}","events_url":"https://api.github.com/repos/twangboy/salt-testing/events","assignees_url":"https://api.github.com/repos/twangboy/salt-testing/assignees{/user}","branches_url":"https://api.github.com/repos/twangboy/salt-testing/branches{/branch}","tags_url":"https://api.github.com/repos/twangboy/salt-testing/tags","blobs_url":"https://api.github.com/repos/twangboy/salt-testing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twangboy/salt-testing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twangboy/salt-testing/git/refs{/sha}","trees_url":"https://api.github.com/repos/twangboy/salt-testing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twangboy/salt-testing/statuses/{sha}","languages_url":"https://api.github.com/repos/twangboy/salt-testing/languages","stargazers_url":"https://api.github.com/repos/twangboy/salt-testing/stargazers","contributors_url":"https://api.github.com/repos/twangboy/salt-testing/contributors","subscribers_url":"https://api.github.com/repos/twangboy/salt-testing/subscribers","subscription_url":"https://api.github.com/repos/twangboy/salt-testing/subscription","commits_url":"https://api.github.com/repos/twangboy/salt-testing/commits{/sha}","git_commits_url":"https://api.github.com/repos/twangboy/salt-testing/git/commits{/sha}","comments_url":"https://api.github.com/repos/twangboy/salt-testing/comments{/number}","issue_comment_url":"https://api.github.com/repos/twangboy/salt-testing/issues/comments{/number}","contents_url":"https://api.github.com/repos/twangboy/salt-testing/contents/{+path}","compare_url":"https://api.github.com/repos/twangboy/salt-testing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twangboy/salt-testing/merges","archive_url":"https://api.github.com/repos/twangboy/salt-testing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twangboy/salt-testing/downloads","issues_url":"https://api.github.com/repos/twangboy/salt-testing/issues{/number}","pulls_url":"https://api.github.com/repos/twangboy/salt-testing/pulls{/number}","milestones_url":"https://api.github.com/repos/twangboy/salt-testing/milestones{/number}","notifications_url":"https://api.github.com/repos/twangboy/salt-testing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twangboy/salt-testing/labels{/name}","releases_url":"https://api.github.com/repos/twangboy/salt-testing/releases{/id}","deployments_url":"https://api.github.com/repos/twangboy/salt-testing/deployments","created_at":"2016-07-08T16:18:17Z","updated_at":"2016-07-08T16:18:18Z","pushed_at":"2017-02-01T21:17:28Z","git_url":"git://github.com/twangboy/salt-testing.git","ssh_url":"git@github.com:twangboy/salt-testing.git","clone_url":"https://github.com/twangboy/salt-testing.git","svn_url":"https://github.com/twangboy/salt-testing","homepage":null,"size":1338,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"saltstack:develop","ref":"develop","sha":"60fe1d428b37e082e2c053be399f3c921d259b0d","user":{"login":"saltstack","id":1147473,"avatar_url":"https://avatars.githubusercontent.com/u/1147473?v=3","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"repo":{"id":10906119,"name":"salt-testing","full_name":"saltstack/salt-testing","owner":{"login":"saltstack","id":1147473,"avatar_url":"https://avatars.githubusercontent.com/u/1147473?v=3","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/saltstack/salt-testing","description":"Common testing tools used in the Salt Stack projects","fork":false,"url":"https://api.github.com/repos/saltstack/salt-testing","forks_url":"https://api.github.com/repos/saltstack/salt-testing/forks","keys_url":"https://api.github.com/repos/saltstack/salt-testing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saltstack/salt-testing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saltstack/salt-testing/teams","hooks_url":"https://api.github.com/repos/saltstack/salt-testing/hooks","issue_events_url":"https://api.github.com/repos/saltstack/salt-testing/issues/events{/number}","events_url":"https://api.github.com/repos/saltstack/salt-testing/events","assignees_url":"https://api.github.com/repos/saltstack/salt-testing/assignees{/user}","branches_url":"https://api.github.com/repos/saltstack/salt-testing/branches{/branch}","tags_url":"https://api.github.com/repos/saltstack/salt-testing/tags","blobs_url":"https://api.github.com/repos/saltstack/salt-testing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saltstack/salt-testing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saltstack/salt-testing/git/refs{/sha}","trees_url":"https://api.github.com/repos/saltstack/salt-testing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saltstack/salt-testing/statuses/{sha}","languages_url":"https://api.github.com/repos/saltstack/salt-testing/languages","stargazers_url":"https://api.github.com/repos/saltstack/salt-testing/stargazers","contributors_url":"https://api.github.com/repos/saltstack/salt-testing/contributors","subscribers_url":"https://api.github.com/repos/saltstack/salt-testing/subscribers","subscription_url":"https://api.github.com/repos/saltstack/salt-testing/subscription","commits_url":"https://api.github.com/repos/saltstack/salt-testing/commits{/sha}","git_commits_url":"https://api.github.com/repos/saltstack/salt-testing/git/commits{/sha}","comments_url":"https://api.github.com/repos/saltstack/salt-testing/comments{/number}","issue_comment_url":"https://api.github.com/repos/saltstack/salt-testing/issues/comments{/number}","contents_url":"https://api.github.com/repos/saltstack/salt-testing/contents/{+path}","compare_url":"https://api.github.com/repos/saltstack/salt-testing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saltstack/salt-testing/merges","archive_url":"https://api.github.com/repos/saltstack/salt-testing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saltstack/salt-testing/downloads","issues_url":"https://api.github.com/repos/saltstack/salt-testing/issues{/number}","pulls_url":"https://api.github.com/repos/saltstack/salt-testing/pulls{/number}","milestones_url":"https://api.github.com/repos/saltstack/salt-testing/milestones{/number}","notifications_url":"https://api.github.com/repos/saltstack/salt-testing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saltstack/salt-testing/labels{/name}","releases_url":"https://api.github.com/repos/saltstack/salt-testing/releases{/id}","deployments_url":"https://api.github.com/repos/saltstack/salt-testing/deployments","created_at":"2013-06-24T11:19:08Z","updated_at":"2017-01-06T21:00:35Z","pushed_at":"2017-02-01T21:17:29Z","git_url":"git://github.com/saltstack/salt-testing.git","ssh_url":"git@github.com:saltstack/salt-testing.git","clone_url":"https://github.com/saltstack/salt-testing.git","svn_url":"https://github.com/saltstack/salt-testing","homepage":null,"size":1099,"stargazers_count":24,"watchers_count":24,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":39,"mirror_url":null,"open_issues_count":14,"forks":39,"open_issues":14,"watchers":24,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/saltstack/salt-testing/pulls/113"},"html":{"href":"https://github.com/saltstack/salt-testing/pull/113"},"issue":{"href":"https://api.github.com/repos/saltstack/salt-testing/issues/113"},"comments":{"href":"https://api.github.com/repos/saltstack/salt-testing/issues/113/comments"},"review_comments":{"href":"https://api.github.com/repos/saltstack/salt-testing/pulls/113/comments"},"review_comment":{"href":"https://api.github.com/repos/saltstack/salt-testing/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/saltstack/salt-testing/pulls/113/commits"},"statuses":{"href":"https://api.github.com/repos/saltstack/salt-testing/statuses/c52aabea02d85cfce463f5e1922ccafee2154f1b"}}}}
{"actor":{"display_login":"cachedout"}}