{"action":"created","comment":{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments/127612806","pull_request_review_id":50216514,"id":127612806,"diff_hunk":"@@ -2239,14 +2241,21 @@ void AuraEffect::HandleFeignDeath(AuraApplication const* aurApp, uint8 mode, boo\n                 }\n             }\n         }\n-        target->CombatStop();\n+\n+        if (target->GetMap()->IsDungeon()) // feign death does not remove combat in dungeons","path":"src/server/game/Spells/Auras/SpellAuraEffects.cpp","position":24,"original_position":24,"commit_id":"c24128a9493478ba81b5e4ce17e900e6665243b5","original_commit_id":"c24128a9493478ba81b5e4ce17e900e6665243b5","user":{"login":"Shauren","id":297439,"avatar_url":"https://avatars4.githubusercontent.com/u/297439?v=4","gravatar_id":"","url":"https://api.github.com/users/Shauren","html_url":"https://github.com/Shauren","followers_url":"https://api.github.com/users/Shauren/followers","following_url":"https://api.github.com/users/Shauren/following{/other_user}","gists_url":"https://api.github.com/users/Shauren/gists{/gist_id}","starred_url":"https://api.github.com/users/Shauren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shauren/subscriptions","organizations_url":"https://api.github.com/users/Shauren/orgs","repos_url":"https://api.github.com/users/Shauren/repos","events_url":"https://api.github.com/users/Shauren/events{/privacy}","received_events_url":"https://api.github.com/users/Shauren/received_events","type":"User","site_admin":false},"body":"Does this mean that if the hunter is the last target alive during boss encounter and he uses feign death then boss doesn't evade with this change?","created_at":"2017-07-16T17:56:12Z","updated_at":"2017-07-16T17:58:00Z","html_url":"https://github.com/TrinityCore/TrinityCore/pull/19930#discussion_r127612806","pull_request_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/19930","_links":{"self":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments/127612806"},"html":{"href":"https://github.com/TrinityCore/TrinityCore/pull/19930#discussion_r127612806"},"pull_request":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/19930"}}},"pull_request":{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/19930","id":126625394,"html_url":"https://github.com/TrinityCore/TrinityCore/pull/19930","diff_url":"https://github.com/TrinityCore/TrinityCore/pull/19930.diff","patch_url":"https://github.com/TrinityCore/TrinityCore/pull/19930.patch","issue_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/19930","number":19930,"state":"open","locked":false,"title":"[3.3.5] Combat/threat system rewrite","user":{"login":"Treeston","id":14020072,"avatar_url":"https://avatars7.githubusercontent.com/u/14020072?v=4","gravatar_id":"","url":"https://api.github.com/users/Treeston","html_url":"https://github.com/Treeston","followers_url":"https://api.github.com/users/Treeston/followers","following_url":"https://api.github.com/users/Treeston/following{/other_user}","gists_url":"https://api.github.com/users/Treeston/gists{/gist_id}","starred_url":"https://api.github.com/users/Treeston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Treeston/subscriptions","organizations_url":"https://api.github.com/users/Treeston/orgs","repos_url":"https://api.github.com/users/Treeston/repos","events_url":"https://api.github.com/users/Treeston/events{/privacy}","received_events_url":"https://api.github.com/users/Treeston/received_events","type":"User","site_admin":false},"body":"Our current combat system is kind of a mess. Combat is not necessarily mutual, `IsInCombatWith` only works for units with a threat list, and so on and so forth. I'm ripping it all out and replacing it.\r\n\r\n**Improvements:**\r\n* Combat is now always mutual\r\n* PvP combat is tracked (which means we can easily reference a list of players that are engaging a given player)\r\n* `IsInCombatWith` is now reliable\r\n* Blizzlike engage behavior with projectile spells (combat on launch, threat on impact)\r\n* Threat system is no longer a steaming pile of hacks\r\n* Scripts can `AddThreat` without misdirection fucking them up (lol)\r\n* Vehicle aggro now properly goes to the \"main\" vehicle body (tagging #16542)\r\n* And various edge case behaviors that I didn't even notice\r\n\r\n**Todo:**\r\n* Bug hunting","created_at":"2017-06-20T20:44:02Z","updated_at":"2017-07-16T17:58:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"796056f0f8cb6766aec55eab86b855b901ba74bd","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/19930/commits","review_comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/19930/comments","review_comment_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/19930/comments","statuses_url":"https://api.github.com/repos/TrinityCore/TrinityCore/statuses/c24128a9493478ba81b5e4ce17e900e6665243b5","head":{"label":"Treeston:3.3.5-combatrewrite","ref":"3.3.5-combatrewrite","sha":"c24128a9493478ba81b5e4ce17e900e6665243b5","user":{"login":"Treeston","id":14020072,"avatar_url":"https://avatars7.githubusercontent.com/u/14020072?v=4","gravatar_id":"","url":"https://api.github.com/users/Treeston","html_url":"https://github.com/Treeston","followers_url":"https://api.github.com/users/Treeston/followers","following_url":"https://api.github.com/users/Treeston/following{/other_user}","gists_url":"https://api.github.com/users/Treeston/gists{/gist_id}","starred_url":"https://api.github.com/users/Treeston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Treeston/subscriptions","organizations_url":"https://api.github.com/users/Treeston/orgs","repos_url":"https://api.github.com/users/Treeston/repos","events_url":"https://api.github.com/users/Treeston/events{/privacy}","received_events_url":"https://api.github.com/users/Treeston/received_events","type":"User","site_admin":false},"repo":{"id":42188757,"name":"TrinityCore","full_name":"Treeston/TrinityCore","owner":{"login":"Treeston","id":14020072,"avatar_url":"https://avatars7.githubusercontent.com/u/14020072?v=4","gravatar_id":"","url":"https://api.github.com/users/Treeston","html_url":"https://github.com/Treeston","followers_url":"https://api.github.com/users/Treeston/followers","following_url":"https://api.github.com/users/Treeston/following{/other_user}","gists_url":"https://api.github.com/users/Treeston/gists{/gist_id}","starred_url":"https://api.github.com/users/Treeston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Treeston/subscriptions","organizations_url":"https://api.github.com/users/Treeston/orgs","repos_url":"https://api.github.com/users/Treeston/repos","events_url":"https://api.github.com/users/Treeston/events{/privacy}","received_events_url":"https://api.github.com/users/Treeston/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Treeston/TrinityCore","description":"TrinityCore Open Source MMO Framework","fork":true,"url":"https://api.github.com/repos/Treeston/TrinityCore","forks_url":"https://api.github.com/repos/Treeston/TrinityCore/forks","keys_url":"https://api.github.com/repos/Treeston/TrinityCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Treeston/TrinityCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Treeston/TrinityCore/teams","hooks_url":"https://api.github.com/repos/Treeston/TrinityCore/hooks","issue_events_url":"https://api.github.com/repos/Treeston/TrinityCore/issues/events{/number}","events_url":"https://api.github.com/repos/Treeston/TrinityCore/events","assignees_url":"https://api.github.com/repos/Treeston/TrinityCore/assignees{/user}","branches_url":"https://api.github.com/repos/Treeston/TrinityCore/branches{/branch}","tags_url":"https://api.github.com/repos/Treeston/TrinityCore/tags","blobs_url":"https://api.github.com/repos/Treeston/TrinityCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Treeston/TrinityCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Treeston/TrinityCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/Treeston/TrinityCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Treeston/TrinityCore/statuses/{sha}","languages_url":"https://api.github.com/repos/Treeston/TrinityCore/languages","stargazers_url":"https://api.github.com/repos/Treeston/TrinityCore/stargazers","contributors_url":"https://api.github.com/repos/Treeston/TrinityCore/contributors","subscribers_url":"https://api.github.com/repos/Treeston/TrinityCore/subscribers","subscription_url":"https://api.github.com/repos/Treeston/TrinityCore/subscription","commits_url":"https://api.github.com/repos/Treeston/TrinityCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/Treeston/TrinityCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/Treeston/TrinityCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/Treeston/TrinityCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/Treeston/TrinityCore/contents/{+path}","compare_url":"https://api.github.com/repos/Treeston/TrinityCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Treeston/TrinityCore/merges","archive_url":"https://api.github.com/repos/Treeston/TrinityCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Treeston/TrinityCore/downloads","issues_url":"https://api.github.com/repos/Treeston/TrinityCore/issues{/number}","pulls_url":"https://api.github.com/repos/Treeston/TrinityCore/pulls{/number}","milestones_url":"https://api.github.com/repos/Treeston/TrinityCore/milestones{/number}","notifications_url":"https://api.github.com/repos/Treeston/TrinityCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Treeston/TrinityCore/labels{/name}","releases_url":"https://api.github.com/repos/Treeston/TrinityCore/releases{/id}","deployments_url":"https://api.github.com/repos/Treeston/TrinityCore/deployments","created_at":"2015-09-09T15:54:20Z","updated_at":"2016-04-02T15:45:18Z","pushed_at":"2017-07-16T14:24:04Z","git_url":"git://github.com/Treeston/TrinityCore.git","ssh_url":"git@github.com:Treeston/TrinityCore.git","clone_url":"https://github.com/Treeston/TrinityCore.git","svn_url":"https://github.com/Treeston/TrinityCore","homepage":"http://www.trinitycore.org","size":389931,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"3.3.5"}},"base":{"label":"TrinityCore:3.3.5","ref":"3.3.5","sha":"3f8c0cb446327061c4d5ba06e72044fb8308f694","user":{"login":"TrinityCore","id":539602,"avatar_url":"https://avatars7.githubusercontent.com/u/539602?v=4","gravatar_id":"","url":"https://api.github.com/users/TrinityCore","html_url":"https://github.com/TrinityCore","followers_url":"https://api.github.com/users/TrinityCore/followers","following_url":"https://api.github.com/users/TrinityCore/following{/other_user}","gists_url":"https://api.github.com/users/TrinityCore/gists{/gist_id}","starred_url":"https://api.github.com/users/TrinityCore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrinityCore/subscriptions","organizations_url":"https://api.github.com/users/TrinityCore/orgs","repos_url":"https://api.github.com/users/TrinityCore/repos","events_url":"https://api.github.com/users/TrinityCore/events{/privacy}","received_events_url":"https://api.github.com/users/TrinityCore/received_events","type":"Organization","site_admin":false},"repo":{"id":1204412,"name":"TrinityCore","full_name":"TrinityCore/TrinityCore","owner":{"login":"TrinityCore","id":539602,"avatar_url":"https://avatars7.githubusercontent.com/u/539602?v=4","gravatar_id":"","url":"https://api.github.com/users/TrinityCore","html_url":"https://github.com/TrinityCore","followers_url":"https://api.github.com/users/TrinityCore/followers","following_url":"https://api.github.com/users/TrinityCore/following{/other_user}","gists_url":"https://api.github.com/users/TrinityCore/gists{/gist_id}","starred_url":"https://api.github.com/users/TrinityCore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrinityCore/subscriptions","organizations_url":"https://api.github.com/users/TrinityCore/orgs","repos_url":"https://api.github.com/users/TrinityCore/repos","events_url":"https://api.github.com/users/TrinityCore/events{/privacy}","received_events_url":"https://api.github.com/users/TrinityCore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TrinityCore/TrinityCore","description":"TrinityCore Open Source MMO Framework (master = 7.2.5.24461, 3.3.5 = 3.3.5a.12340)","fork":false,"url":"https://api.github.com/repos/TrinityCore/TrinityCore","forks_url":"https://api.github.com/repos/TrinityCore/TrinityCore/forks","keys_url":"https://api.github.com/repos/TrinityCore/TrinityCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TrinityCore/TrinityCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TrinityCore/TrinityCore/teams","hooks_url":"https://api.github.com/repos/TrinityCore/TrinityCore/hooks","issue_events_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/events{/number}","events_url":"https://api.github.com/repos/TrinityCore/TrinityCore/events","assignees_url":"https://api.github.com/repos/TrinityCore/TrinityCore/assignees{/user}","branches_url":"https://api.github.com/repos/TrinityCore/TrinityCore/branches{/branch}","tags_url":"https://api.github.com/repos/TrinityCore/TrinityCore/tags","blobs_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TrinityCore/TrinityCore/statuses/{sha}","languages_url":"https://api.github.com/repos/TrinityCore/TrinityCore/languages","stargazers_url":"https://api.github.com/repos/TrinityCore/TrinityCore/stargazers","contributors_url":"https://api.github.com/repos/TrinityCore/TrinityCore/contributors","subscribers_url":"https://api.github.com/repos/TrinityCore/TrinityCore/subscribers","subscription_url":"https://api.github.com/repos/TrinityCore/TrinityCore/subscription","commits_url":"https://api.github.com/repos/TrinityCore/TrinityCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/TrinityCore/TrinityCore/contents/{+path}","compare_url":"https://api.github.com/repos/TrinityCore/TrinityCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TrinityCore/TrinityCore/merges","archive_url":"https://api.github.com/repos/TrinityCore/TrinityCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TrinityCore/TrinityCore/downloads","issues_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues{/number}","pulls_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls{/number}","milestones_url":"https://api.github.com/repos/TrinityCore/TrinityCore/milestones{/number}","notifications_url":"https://api.github.com/repos/TrinityCore/TrinityCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TrinityCore/TrinityCore/labels{/name}","releases_url":"https://api.github.com/repos/TrinityCore/TrinityCore/releases{/id}","deployments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/deployments","created_at":"2010-12-28T23:40:07Z","updated_at":"2017-07-15T23:42:36Z","pushed_at":"2017-07-16T16:45:29Z","git_url":"git://github.com/TrinityCore/TrinityCore.git","ssh_url":"git@github.com:TrinityCore/TrinityCore.git","clone_url":"https://github.com/TrinityCore/TrinityCore.git","svn_url":"https://github.com/TrinityCore/TrinityCore","homepage":"http://www.trinitycore.org","size":456848,"stargazers_count":3876,"watchers_count":3876,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3819,"mirror_url":null,"open_issues_count":1527,"forks":3819,"open_issues":1527,"watchers":3876,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/19930"},"html":{"href":"https://github.com/TrinityCore/TrinityCore/pull/19930"},"issue":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/19930"},"comments":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/19930/comments"},"review_comments":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/19930/comments"},"review_comment":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/19930/commits"},"statuses":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/statuses/c24128a9493478ba81b5e4ce17e900e6665243b5"}}}}
{"actor":{"display_login":"Shauren"}}