{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/pulls/comments/134642088","pull_request_review_id":57956711,"id":134642088,"diff_hunk":"@@ -0,0 +1,227 @@\n+// Copyright 2017 Google Inc.\n+//\n+// Licensed under the Apache License, Version 2.0 (the \"License\");\n+// you may not use this file except in compliance with the License.\n+// You may obtain a copy of the License at\n+//\n+//      http://www.apache.org/licenses/LICENSE-2.0\n+//\n+// Unless required by applicable law or agreed to in writing, software\n+// distributed under the License is distributed on an \"AS IS\" BASIS,\n+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+// See the License for the specific language governing permissions and\n+// limitations under the License.\n+//\n+////////////////////////////////////////////////////////////////////////////////\n+\n+package com.google.pubsub.clients.config;\n+\n+import com.google.common.annotations.VisibleForTesting;\n+import java.util.Map;\n+import java.util.Set;\n+import java.util.HashMap;\n+import java.util.Properties;\n+\n+import org.apache.kafka.common.config.ConfigDef;\n+import org.apache.kafka.common.config.AbstractConfig;\n+import org.apache.kafka.common.config.ConfigDef.Type;\n+import org.apache.kafka.common.config.ConfigDef.Range;\n+import org.apache.kafka.common.serialization.Serializer;\n+import org.apache.kafka.common.config.ConfigDef.Importance;\n+import org.apache.kafka.common.config.ConfigDef.ValidString;\n+\n+/**\n+ * Provides the configurations for a KafkaProducer instance.\n+ */\n+public class ProducerConfig extends AbstractConfig {","path":"pubsub-mapped-api/src/main/java/com/google/pubsub/clients/config/ProducerConfig.java","position":36,"original_position":36,"commit_id":"dc69b2d20342fd77c33b83e85bcae22dfe3c4fc2","original_commit_id":"dc69b2d20342fd77c33b83e85bcae22dfe3c4fc2","user":{"login":"gewillovic","id":14205737,"avatar_url":"https://avatars0.githubusercontent.com/u/14205737?v=4","gravatar_id":"","url":"https://api.github.com/users/gewillovic","html_url":"https://github.com/gewillovic","followers_url":"https://api.github.com/users/gewillovic/followers","following_url":"https://api.github.com/users/gewillovic/following{/other_user}","gists_url":"https://api.github.com/users/gewillovic/gists{/gist_id}","starred_url":"https://api.github.com/users/gewillovic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gewillovic/subscriptions","organizations_url":"https://api.github.com/users/gewillovic/orgs","repos_url":"https://api.github.com/users/gewillovic/repos","events_url":"https://api.github.com/users/gewillovic/events{/privacy}","received_events_url":"https://api.github.com/users/gewillovic/received_events","type":"User","site_admin":false},"body":"I created a separate branch with the refactored configs, utilizing Kafka's configs as is, and CPS's as a separate layer over it.","created_at":"2017-08-23T01:58:06Z","updated_at":"2017-08-23T01:58:06Z","html_url":"https://github.com/GoogleCloudPlatform/pubsub/pull/114#discussion_r134642088","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/pulls/114","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/pulls/comments/134642088"},"html":{"href":"https://github.com/GoogleCloudPlatform/pubsub/pull/114#discussion_r134642088"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/pulls/114"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/pulls/114","id":135442308,"html_url":"https://github.com/GoogleCloudPlatform/pubsub/pull/114","diff_url":"https://github.com/GoogleCloudPlatform/pubsub/pull/114.diff","patch_url":"https://github.com/GoogleCloudPlatform/pubsub/pull/114.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/issues/114","number":114,"state":"open","locked":false,"title":"Mapped API Producer ","user":{"login":"gewillovic","id":14205737,"avatar_url":"https://avatars0.githubusercontent.com/u/14205737?v=4","gravatar_id":"","url":"https://api.github.com/users/gewillovic","html_url":"https://github.com/gewillovic","followers_url":"https://api.github.com/users/gewillovic/followers","following_url":"https://api.github.com/users/gewillovic/following{/other_user}","gists_url":"https://api.github.com/users/gewillovic/gists{/gist_id}","starred_url":"https://api.github.com/users/gewillovic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gewillovic/subscriptions","organizations_url":"https://api.github.com/users/gewillovic/orgs","repos_url":"https://api.github.com/users/gewillovic/repos","events_url":"https://api.github.com/users/gewillovic/events{/privacy}","received_events_url":"https://api.github.com/users/gewillovic/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-08-12T01:25:51Z","updated_at":"2017-08-23T01:58:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"befa398dcda11315afcc7b7ba0a728be809ad25f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mdietz94","id":1824618,"avatar_url":"https://avatars1.githubusercontent.com/u/1824618?v=4","gravatar_id":"","url":"https://api.github.com/users/mdietz94","html_url":"https://github.com/mdietz94","followers_url":"https://api.github.com/users/mdietz94/followers","following_url":"https://api.github.com/users/mdietz94/following{/other_user}","gists_url":"https://api.github.com/users/mdietz94/gists{/gist_id}","starred_url":"https://api.github.com/users/mdietz94/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdietz94/subscriptions","organizations_url":"https://api.github.com/users/mdietz94/orgs","repos_url":"https://api.github.com/users/mdietz94/repos","events_url":"https://api.github.com/users/mdietz94/events{/privacy}","received_events_url":"https://api.github.com/users/mdietz94/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/pulls/114/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/pulls/114/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/issues/114/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/statuses/dc69b2d20342fd77c33b83e85bcae22dfe3c4fc2","head":{"label":"GoogleCloudPlatform:mapped_api_producer_client","ref":"mapped_api_producer_client","sha":"dc69b2d20342fd77c33b83e85bcae22dfe3c4fc2","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":65505864,"name":"pubsub","full_name":"GoogleCloudPlatform/pubsub","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/pubsub","description":"This repository contains open-source projects managed by the owners of Google Cloud Pub/Sub.","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/pubsub","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/deployments","created_at":"2016-08-11T22:32:18Z","updated_at":"2017-08-08T18:28:36Z","pushed_at":"2017-08-23T01:50:26Z","git_url":"git://github.com/GoogleCloudPlatform/pubsub.git","ssh_url":"git@github.com:GoogleCloudPlatform/pubsub.git","clone_url":"https://github.com/GoogleCloudPlatform/pubsub.git","svn_url":"https://github.com/GoogleCloudPlatform/pubsub","homepage":"","size":1818,"stargazers_count":33,"watchers_count":33,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":31,"mirror_url":null,"open_issues_count":16,"forks":31,"open_issues":16,"watchers":33,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:mapped_api_develop","ref":"mapped_api_develop","sha":"ef906af3460abd21eea8ae735d3f7a8c38551fb1","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":65505864,"name":"pubsub","full_name":"GoogleCloudPlatform/pubsub","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/pubsub","description":"This repository contains open-source projects managed by the owners of Google Cloud Pub/Sub.","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/pubsub","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/deployments","created_at":"2016-08-11T22:32:18Z","updated_at":"2017-08-08T18:28:36Z","pushed_at":"2017-08-23T01:50:26Z","git_url":"git://github.com/GoogleCloudPlatform/pubsub.git","ssh_url":"git@github.com:GoogleCloudPlatform/pubsub.git","clone_url":"https://github.com/GoogleCloudPlatform/pubsub.git","svn_url":"https://github.com/GoogleCloudPlatform/pubsub","homepage":"","size":1818,"stargazers_count":33,"watchers_count":33,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":31,"mirror_url":null,"open_issues_count":16,"forks":31,"open_issues":16,"watchers":33,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/pulls/114"},"html":{"href":"https://github.com/GoogleCloudPlatform/pubsub/pull/114"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/issues/114"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/issues/114/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/pulls/114/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/pulls/114/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/pubsub/statuses/dc69b2d20342fd77c33b83e85bcae22dfe3c4fc2"}}}}
{"actor":{"display_login":"gewillovic"}}