{"push_id":1571609088,"size":2,"distinct_size":2,"ref":"refs/heads/ppc-for-2.9","head":"fe6272f5b6a3a2a9fad0e0cb1a228e1c50c728a6","before":"be5ab4d480660adb3b34bbcce5ff7883d515a898","commits":[{"sha":"15d4cb32049fc99901ee0b63e4acb7e890d435b6","author":{"name":"Thomas Huth","email":"88e8c2c9848c27f046284b2ccf48cd5b58fafc02@redhat.com"},"message":"hw/ppc/spapr: Check for valid page size when hot plugging memory\n\nOn POWER, the valid page sizes that the guest can use are bound\nto the CPU and not to the memory region. QEMU already has some\nfancy logic to find out the right maximum memory size to tell\nit to the guest during boot (see getrampagesize() in the file\ntarget/ppc/kvm.c for more information).\nHowever, once we're booted and the guest is using huge pages\nalready, it is currently still possible to hot-plug memory regions\nthat does not support huge pages - which of course does not work\non POWER, since the guest thinks that it is possible to use huge\npages everywhere. The KVM_RUN ioctl will then abort with -EFAULT,\nQEMU spills out a not very helpful error message together with\na register dump and the user is annoyed that the VM unexpectedly\ndied.\nTo avoid this situation, we should check the page size of hot-plugged\nDIMMs to see whether it is possible to use it in the current VM.\nIf it does not fit, we can print out a better error message and\nrefuse to add it, so that the VM does not die unexpectely and the\nuser has a second chance to plug a DIMM with a matching memory\nbackend instead.\n\nBuglink: https://bugzilla.redhat.com/show_bug.cgi?id=1419466\nSigned-off-by: Thomas Huth <thuth@redhat.com>\n[dwg: Fix a type error]\nSigned-off-by: David Gibson <david@gibson.dropbear.id.au>","distinct":true,"url":"https://api.github.com/repos/dgibson/qemu/commits/15d4cb32049fc99901ee0b63e4acb7e890d435b6"},{"sha":"fe6272f5b6a3a2a9fad0e0cb1a228e1c50c728a6","author":{"name":"Peter Maydell","email":"d4da0cae8bdd6af8ce5950fc7fec7c012df68229@linaro.org"},"message":"hw/ppc/ppc405_uc.c: Avoid integer overflows\n\nWhen performing clock calculations, the ppc405_uc code\nhas several places where it multiplies together two\n32-bit variables and assigns the result to a 64-bit\nvariable. This doesn't quite do what is intended because\nC will compute a 32-bit multiply result. Add casts to\nensure we don't truncate the result.\n\n(Spotted by Coverity, CID 1005504, 1005505.)\n\nSigned-off-by: Peter Maydell <peter.maydell@linaro.org>\nReviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>\nSigned-off-by: David Gibson <david@gibson.dropbear.id.au>","distinct":true,"url":"https://api.github.com/repos/dgibson/qemu/commits/fe6272f5b6a3a2a9fad0e0cb1a228e1c50c728a6"}]}
{"actor":{"display_login":"dgibson"}}