{"action":"opened","issue":{"url":"https://api.github.com/repos/marmelab/admin-on-rest/issues/1128","repository_url":"https://api.github.com/repos/marmelab/admin-on-rest","labels_url":"https://api.github.com/repos/marmelab/admin-on-rest/issues/1128/labels{/name}","comments_url":"https://api.github.com/repos/marmelab/admin-on-rest/issues/1128/comments","events_url":"https://api.github.com/repos/marmelab/admin-on-rest/issues/1128/events","html_url":"https://github.com/marmelab/admin-on-rest/issues/1128","id":262642254,"number":1128,"title":"[RFC] `make lint` reports 145 problems.","user":{"login":"DanThomson","id":3159900,"avatar_url":"https://avatars3.githubusercontent.com/u/3159900?v=4","gravatar_id":"","url":"https://api.github.com/users/DanThomson","html_url":"https://github.com/DanThomson","followers_url":"https://api.github.com/users/DanThomson/followers","following_url":"https://api.github.com/users/DanThomson/following{/other_user}","gists_url":"https://api.github.com/users/DanThomson/gists{/gist_id}","starred_url":"https://api.github.com/users/DanThomson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanThomson/subscriptions","organizations_url":"https://api.github.com/users/DanThomson/orgs","repos_url":"https://api.github.com/users/DanThomson/repos","events_url":"https://api.github.com/users/DanThomson/events{/privacy}","received_events_url":"https://api.github.com/users/DanThomson/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-10-04T01:45:32Z","updated_at":"2017-10-04T01:45:32Z","closed_at":null,"author_association":"NONE","body":"I want to start contributing to `admin-on-rest`, so I forked master, ran through the setup, then ran `make test`. I got some errors from the linter. This leaves me with a dilemma. Do fix the code in master so that the linter does not produce errors, or do I write small pull requests which are easy to read but violate [`.github/CONTRIBUTING.md`](https://github.com/marmelab/admin-on-rest/blob/master/.github/CONTRIBUTING.md#coding-style)?\r\n\r\n**What you were expecting:**\r\nI expected master to be clean of test errors.\r\n\r\n**Steps to reproduce:**\r\n```\r\n$ git clone git@github.com:marmelab/admin-on-rest.git\r\n$ cd admin-on-rest\r\n$ npm install\r\n$ make lint | tee lint-results\r\n```\r\n\r\n**What happened instead:**\r\n```\r\n✖ 145 problems (70 errors, 75 warnings)\r\n  67 errors, 0 warnings potentially fixable with the `--fix` option.\r\n\r\nmake: *** [lint] Error 1\r\n```\r\n\r\n**Other information:**\r\nI can make the full results available if needed, but reproducing my results should be trivial. If you cannot reproduce this please let me know.\r\n\r\n**The advice from .github/CONTRIBUTING.md would clean up some but not all of these errors**\r\n>### Coding style\r\n>\r\n>You must follow the coding style of the existing files. Admin-on-rest uses eslint and [prettier](https://github.com/prettier/prettier). You can reformat all the project files automatically by calling\r\n>\r\n> ```sh\r\n> make prettier\r\n> ```\r\n\r\nBtw, \"must\" is a pretty strong word given the results shown above and those which follow.\r\n\r\n```\r\n$ make prettier | tee prettier-results\r\n\r\nsuccess formatting 16 files with prettier-eslint\r\n224 files were unchanged\r\n\r\n$ git diff\r\n\r\nOn branch master\r\nYour branch is up-to-date with 'origin/master'.\r\n\r\nChanges not staged for commit:\r\n  (use \"git add <file>...\" to update what will be committed)\r\n  (use \"git checkout -- <file>...\" to discard changes in working directory)\r\n\r\n        modified:   src/auth/withPermissionsFilteredChildren.js\r\n        modified:   src/i18n/TranslationUtils.js\r\n        modified:   src/mui/field/SelectField.js\r\n        modified:   src/mui/form/TabbedForm.js\r\n        modified:   src/mui/input/CheckboxGroupInput.js\r\n        modified:   src/mui/input/Labeled.js\r\n        modified:   src/mui/input/RadioButtonGroupInput.js\r\n        modified:   src/mui/input/ReferenceArrayInput.js\r\n        modified:   src/mui/input/ReferenceInput.js\r\n        modified:   src/mui/input/SelectInput.js\r\n        modified:   src/mui/layout/Layout.js\r\n        modified:   src/mui/list/Datagrid.js\r\n        modified:   src/mui/list/DatagridBody.js\r\n        modified:   src/mui/list/DatagridHeaderCell.js\r\n        modified:   src/mui/list/List.js\r\n        modified:   src/util/FieldTitle.js\r\n```\r\n\r\nShould I make a pull request with these changes?\r\n\r\n**Even after running `make prettier` there are errors**\r\n```\r\n$ make lint | tee lint-results-post-prettier\r\n\r\n✖ 79 problems (4 errors, 75 warnings)\r\n\r\nmake: *** [lint] Error 1\r\n```\r\n\r\n**Environment**\r\n* Admin-on-rest version:\r\n`master branch`\r\n`release v1.3.2`\r\n`commit 07452f0efe31fda3309710f74e11f5988595206c`\r\n\r\n* React version:\r\n`15.6.2`\r\n\r\n* Node version:\r\n`v8.6.0`\r\n\r\n* NPM version:\r\n`5.3.0`\r\n\r\n\r\n**Research into which version was the last passing version**\r\n* Spoiler: no version has passed `make lint`\r\n\r\n```\r\n$ git reset HEAD --hard\r\nHEAD is now at 07452f0 Prepare 1.3.2\r\n\r\n$ git checkout  fe62e71\r\nNote: checking out 'fe62e71'.\r\nHEAD is now at fe62e71... Update changelog\r\n\r\n$ make lint | tee lint-results-one-version-prior\r\n\r\n✖ 142 problems (70 errors, 72 warnings)\r\n  67 errors, 0 warnings potentially fixable with the `--fix` option.\r\n\r\nmake: *** [lint] Error 1\r\n```\r\n\r\n```\r\n$ git checkout b9a7dd1\r\nPrevious HEAD position was fe62e71... Update changelog\r\nHEAD is now at b9a7dd1... Prepare v1.2.3\r\n\r\n\r\n$ make lint | tee lint-results-v1.2.3\r\nmake: *** No rule to make target `lint'.  Stop.\r\n```"}}
{"actor":{"display_login":"DanThomson"}}