{"action":"created","comment":{"url":"https://api.github.com/repos/bhegmanns/fin-business/pulls/comments/145278122","pull_request_review_id":70055650,"id":145278122,"diff_hunk":"@@ -1,11 +1,6 @@\n package de.hegmanns.test.utils;\n \n-import java.io.ByteArrayOutputStream;\n-import java.io.IOException;\n-import java.io.InvalidClassException;\n-import java.io.NotSerializableException;\n-import java.io.ObjectOutputStream;\n-import java.io.Serializable;\n+import java.io.*;","path":"test-utils/src/main/java/de/hegmanns/test/utils/SerializationTestHelper.java","position":null,"original_position":9,"commit_id":"d5112179bf3340bc90b3c8adaf2eeb9cceb1085f","original_commit_id":"54ed2b5ab9a933fa0288817a4d28c251c670ac4c","user":{"login":"cwancowicz","id":15522752,"avatar_url":"https://avatars3.githubusercontent.com/u/15522752?v=4","gravatar_id":"","url":"https://api.github.com/users/cwancowicz","html_url":"https://github.com/cwancowicz","followers_url":"https://api.github.com/users/cwancowicz/followers","following_url":"https://api.github.com/users/cwancowicz/following{/other_user}","gists_url":"https://api.github.com/users/cwancowicz/gists{/gist_id}","starred_url":"https://api.github.com/users/cwancowicz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cwancowicz/subscriptions","organizations_url":"https://api.github.com/users/cwancowicz/orgs","repos_url":"https://api.github.com/users/cwancowicz/repos","events_url":"https://api.github.com/users/cwancowicz/events{/privacy}","received_events_url":"https://api.github.com/users/cwancowicz/received_events","type":"User","site_admin":false},"body":"oh yeah, didn't mean to do that, made change and updated my IDE preferences.","created_at":"2017-10-17T22:53:28Z","updated_at":"2017-10-17T22:53:28Z","html_url":"https://github.com/bhegmanns/fin-business/pull/10#discussion_r145278122","pull_request_url":"https://api.github.com/repos/bhegmanns/fin-business/pulls/10","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/bhegmanns/fin-business/pulls/comments/145278122"},"html":{"href":"https://github.com/bhegmanns/fin-business/pull/10#discussion_r145278122"},"pull_request":{"href":"https://api.github.com/repos/bhegmanns/fin-business/pulls/10"}},"in_reply_to_id":145250247},"pull_request":{"url":"https://api.github.com/repos/bhegmanns/fin-business/pulls/10","id":146607938,"html_url":"https://github.com/bhegmanns/fin-business/pull/10","diff_url":"https://github.com/bhegmanns/fin-business/pull/10.diff","patch_url":"https://github.com/bhegmanns/fin-business/pull/10.patch","issue_url":"https://api.github.com/repos/bhegmanns/fin-business/issues/10","number":10,"state":"open","locked":false,"title":"add unit test for SerializationTestHelper class","user":{"login":"cwancowicz","id":15522752,"avatar_url":"https://avatars3.githubusercontent.com/u/15522752?v=4","gravatar_id":"","url":"https://api.github.com/users/cwancowicz","html_url":"https://github.com/cwancowicz","followers_url":"https://api.github.com/users/cwancowicz/followers","following_url":"https://api.github.com/users/cwancowicz/following{/other_user}","gists_url":"https://api.github.com/users/cwancowicz/gists{/gist_id}","starred_url":"https://api.github.com/users/cwancowicz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cwancowicz/subscriptions","organizations_url":"https://api.github.com/users/cwancowicz/orgs","repos_url":"https://api.github.com/users/cwancowicz/repos","events_url":"https://api.github.com/users/cwancowicz/events{/privacy}","received_events_url":"https://api.github.com/users/cwancowicz/received_events","type":"User","site_admin":false},"body":"I modified the method signature of SerializationTestHelper.serializeIntoStream to accept the ObjectOutput interface. This allowed easier mocking since the writeObject method is final (couldn't get PowerMockito to mock the final method after many attempts). This is also a little more cleaner in my opinion too.\r\n\r\nAlso - would it be better to change Object instance to Serializable instance ? I noticed in the javadoc comment \"Note, that the instance/class have to implement {@link Serializable}-interface.\" seems like changing it from Object -> Serializable would make more sense if thats a requirement.","created_at":"2017-10-14T15:39:53Z","updated_at":"2017-10-17T22:53:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4f5fb3e2bf31b7fc5f34d3b8bd38c17e3f6369c8","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/bhegmanns/fin-business/pulls/10/commits","review_comments_url":"https://api.github.com/repos/bhegmanns/fin-business/pulls/10/comments","review_comment_url":"https://api.github.com/repos/bhegmanns/fin-business/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bhegmanns/fin-business/issues/10/comments","statuses_url":"https://api.github.com/repos/bhegmanns/fin-business/statuses/d5112179bf3340bc90b3c8adaf2eeb9cceb1085f","head":{"label":"cwancowicz:add-unit-test","ref":"add-unit-test","sha":"d5112179bf3340bc90b3c8adaf2eeb9cceb1085f","user":{"login":"cwancowicz","id":15522752,"avatar_url":"https://avatars3.githubusercontent.com/u/15522752?v=4","gravatar_id":"","url":"https://api.github.com/users/cwancowicz","html_url":"https://github.com/cwancowicz","followers_url":"https://api.github.com/users/cwancowicz/followers","following_url":"https://api.github.com/users/cwancowicz/following{/other_user}","gists_url":"https://api.github.com/users/cwancowicz/gists{/gist_id}","starred_url":"https://api.github.com/users/cwancowicz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cwancowicz/subscriptions","organizations_url":"https://api.github.com/users/cwancowicz/orgs","repos_url":"https://api.github.com/users/cwancowicz/repos","events_url":"https://api.github.com/users/cwancowicz/events{/privacy}","received_events_url":"https://api.github.com/users/cwancowicz/received_events","type":"User","site_admin":false},"repo":{"id":106883736,"name":"fin-business","full_name":"cwancowicz/fin-business","owner":{"login":"cwancowicz","id":15522752,"avatar_url":"https://avatars3.githubusercontent.com/u/15522752?v=4","gravatar_id":"","url":"https://api.github.com/users/cwancowicz","html_url":"https://github.com/cwancowicz","followers_url":"https://api.github.com/users/cwancowicz/followers","following_url":"https://api.github.com/users/cwancowicz/following{/other_user}","gists_url":"https://api.github.com/users/cwancowicz/gists{/gist_id}","starred_url":"https://api.github.com/users/cwancowicz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cwancowicz/subscriptions","organizations_url":"https://api.github.com/users/cwancowicz/orgs","repos_url":"https://api.github.com/users/cwancowicz/repos","events_url":"https://api.github.com/users/cwancowicz/events{/privacy}","received_events_url":"https://api.github.com/users/cwancowicz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cwancowicz/fin-business","description":"useful apis for financial business","fork":true,"url":"https://api.github.com/repos/cwancowicz/fin-business","forks_url":"https://api.github.com/repos/cwancowicz/fin-business/forks","keys_url":"https://api.github.com/repos/cwancowicz/fin-business/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cwancowicz/fin-business/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cwancowicz/fin-business/teams","hooks_url":"https://api.github.com/repos/cwancowicz/fin-business/hooks","issue_events_url":"https://api.github.com/repos/cwancowicz/fin-business/issues/events{/number}","events_url":"https://api.github.com/repos/cwancowicz/fin-business/events","assignees_url":"https://api.github.com/repos/cwancowicz/fin-business/assignees{/user}","branches_url":"https://api.github.com/repos/cwancowicz/fin-business/branches{/branch}","tags_url":"https://api.github.com/repos/cwancowicz/fin-business/tags","blobs_url":"https://api.github.com/repos/cwancowicz/fin-business/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cwancowicz/fin-business/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cwancowicz/fin-business/git/refs{/sha}","trees_url":"https://api.github.com/repos/cwancowicz/fin-business/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cwancowicz/fin-business/statuses/{sha}","languages_url":"https://api.github.com/repos/cwancowicz/fin-business/languages","stargazers_url":"https://api.github.com/repos/cwancowicz/fin-business/stargazers","contributors_url":"https://api.github.com/repos/cwancowicz/fin-business/contributors","subscribers_url":"https://api.github.com/repos/cwancowicz/fin-business/subscribers","subscription_url":"https://api.github.com/repos/cwancowicz/fin-business/subscription","commits_url":"https://api.github.com/repos/cwancowicz/fin-business/commits{/sha}","git_commits_url":"https://api.github.com/repos/cwancowicz/fin-business/git/commits{/sha}","comments_url":"https://api.github.com/repos/cwancowicz/fin-business/comments{/number}","issue_comment_url":"https://api.github.com/repos/cwancowicz/fin-business/issues/comments{/number}","contents_url":"https://api.github.com/repos/cwancowicz/fin-business/contents/{+path}","compare_url":"https://api.github.com/repos/cwancowicz/fin-business/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cwancowicz/fin-business/merges","archive_url":"https://api.github.com/repos/cwancowicz/fin-business/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cwancowicz/fin-business/downloads","issues_url":"https://api.github.com/repos/cwancowicz/fin-business/issues{/number}","pulls_url":"https://api.github.com/repos/cwancowicz/fin-business/pulls{/number}","milestones_url":"https://api.github.com/repos/cwancowicz/fin-business/milestones{/number}","notifications_url":"https://api.github.com/repos/cwancowicz/fin-business/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cwancowicz/fin-business/labels{/name}","releases_url":"https://api.github.com/repos/cwancowicz/fin-business/releases{/id}","deployments_url":"https://api.github.com/repos/cwancowicz/fin-business/deployments","created_at":"2017-10-13T23:58:25Z","updated_at":"2017-10-13T23:58:27Z","pushed_at":"2017-10-17T22:52:25Z","git_url":"git://github.com/cwancowicz/fin-business.git","ssh_url":"git@github.com:cwancowicz/fin-business.git","clone_url":"https://github.com/cwancowicz/fin-business.git","svn_url":"https://github.com/cwancowicz/fin-business","homepage":null,"size":49,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bhegmanns:master","ref":"master","sha":"db3e6460479a91cfee3bd93649d9b004c6007e4f","user":{"login":"bhegmanns","id":1233993,"avatar_url":"https://avatars3.githubusercontent.com/u/1233993?v=4","gravatar_id":"","url":"https://api.github.com/users/bhegmanns","html_url":"https://github.com/bhegmanns","followers_url":"https://api.github.com/users/bhegmanns/followers","following_url":"https://api.github.com/users/bhegmanns/following{/other_user}","gists_url":"https://api.github.com/users/bhegmanns/gists{/gist_id}","starred_url":"https://api.github.com/users/bhegmanns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bhegmanns/subscriptions","organizations_url":"https://api.github.com/users/bhegmanns/orgs","repos_url":"https://api.github.com/users/bhegmanns/repos","events_url":"https://api.github.com/users/bhegmanns/events{/privacy}","received_events_url":"https://api.github.com/users/bhegmanns/received_events","type":"User","site_admin":false},"repo":{"id":58126346,"name":"fin-business","full_name":"bhegmanns/fin-business","owner":{"login":"bhegmanns","id":1233993,"avatar_url":"https://avatars3.githubusercontent.com/u/1233993?v=4","gravatar_id":"","url":"https://api.github.com/users/bhegmanns","html_url":"https://github.com/bhegmanns","followers_url":"https://api.github.com/users/bhegmanns/followers","following_url":"https://api.github.com/users/bhegmanns/following{/other_user}","gists_url":"https://api.github.com/users/bhegmanns/gists{/gist_id}","starred_url":"https://api.github.com/users/bhegmanns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bhegmanns/subscriptions","organizations_url":"https://api.github.com/users/bhegmanns/orgs","repos_url":"https://api.github.com/users/bhegmanns/repos","events_url":"https://api.github.com/users/bhegmanns/events{/privacy}","received_events_url":"https://api.github.com/users/bhegmanns/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bhegmanns/fin-business","description":"useful apis for financial business","fork":false,"url":"https://api.github.com/repos/bhegmanns/fin-business","forks_url":"https://api.github.com/repos/bhegmanns/fin-business/forks","keys_url":"https://api.github.com/repos/bhegmanns/fin-business/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bhegmanns/fin-business/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bhegmanns/fin-business/teams","hooks_url":"https://api.github.com/repos/bhegmanns/fin-business/hooks","issue_events_url":"https://api.github.com/repos/bhegmanns/fin-business/issues/events{/number}","events_url":"https://api.github.com/repos/bhegmanns/fin-business/events","assignees_url":"https://api.github.com/repos/bhegmanns/fin-business/assignees{/user}","branches_url":"https://api.github.com/repos/bhegmanns/fin-business/branches{/branch}","tags_url":"https://api.github.com/repos/bhegmanns/fin-business/tags","blobs_url":"https://api.github.com/repos/bhegmanns/fin-business/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bhegmanns/fin-business/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bhegmanns/fin-business/git/refs{/sha}","trees_url":"https://api.github.com/repos/bhegmanns/fin-business/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bhegmanns/fin-business/statuses/{sha}","languages_url":"https://api.github.com/repos/bhegmanns/fin-business/languages","stargazers_url":"https://api.github.com/repos/bhegmanns/fin-business/stargazers","contributors_url":"https://api.github.com/repos/bhegmanns/fin-business/contributors","subscribers_url":"https://api.github.com/repos/bhegmanns/fin-business/subscribers","subscription_url":"https://api.github.com/repos/bhegmanns/fin-business/subscription","commits_url":"https://api.github.com/repos/bhegmanns/fin-business/commits{/sha}","git_commits_url":"https://api.github.com/repos/bhegmanns/fin-business/git/commits{/sha}","comments_url":"https://api.github.com/repos/bhegmanns/fin-business/comments{/number}","issue_comment_url":"https://api.github.com/repos/bhegmanns/fin-business/issues/comments{/number}","contents_url":"https://api.github.com/repos/bhegmanns/fin-business/contents/{+path}","compare_url":"https://api.github.com/repos/bhegmanns/fin-business/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bhegmanns/fin-business/merges","archive_url":"https://api.github.com/repos/bhegmanns/fin-business/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bhegmanns/fin-business/downloads","issues_url":"https://api.github.com/repos/bhegmanns/fin-business/issues{/number}","pulls_url":"https://api.github.com/repos/bhegmanns/fin-business/pulls{/number}","milestones_url":"https://api.github.com/repos/bhegmanns/fin-business/milestones{/number}","notifications_url":"https://api.github.com/repos/bhegmanns/fin-business/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bhegmanns/fin-business/labels{/name}","releases_url":"https://api.github.com/repos/bhegmanns/fin-business/releases{/id}","deployments_url":"https://api.github.com/repos/bhegmanns/fin-business/deployments","created_at":"2016-05-05T11:31:07Z","updated_at":"2016-05-05T11:36:24Z","pushed_at":"2017-10-17T22:52:26Z","git_url":"git://github.com/bhegmanns/fin-business.git","ssh_url":"git@github.com:bhegmanns/fin-business.git","clone_url":"https://github.com/bhegmanns/fin-business.git","svn_url":"https://github.com/bhegmanns/fin-business","homepage":null,"size":47,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":5,"forks":4,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bhegmanns/fin-business/pulls/10"},"html":{"href":"https://github.com/bhegmanns/fin-business/pull/10"},"issue":{"href":"https://api.github.com/repos/bhegmanns/fin-business/issues/10"},"comments":{"href":"https://api.github.com/repos/bhegmanns/fin-business/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/bhegmanns/fin-business/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/bhegmanns/fin-business/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bhegmanns/fin-business/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/bhegmanns/fin-business/statuses/d5112179bf3340bc90b3c8adaf2eeb9cceb1085f"}},"author_association":"NONE"}}
{"actor":{"display_login":"cwancowicz"}}