{"action":"created","issue":{"url":"https://api.github.com/repos/kennethreitz/pipenv/issues/347","repository_url":"https://api.github.com/repos/kennethreitz/pipenv","labels_url":"https://api.github.com/repos/kennethreitz/pipenv/issues/347/labels{/name}","comments_url":"https://api.github.com/repos/kennethreitz/pipenv/issues/347/comments","events_url":"https://api.github.com/repos/kennethreitz/pipenv/issues/347/events","html_url":"https://github.com/kennethreitz/pipenv/pull/347","id":226870725,"number":347,"title":"create Pipfile from requirements.txt without installing","user":{"login":"nateprewitt","id":5271761,"avatar_url":"https://avatars3.githubusercontent.com/u/5271761?v=3","gravatar_id":"","url":"https://api.github.com/users/nateprewitt","html_url":"https://github.com/nateprewitt","followers_url":"https://api.github.com/users/nateprewitt/followers","following_url":"https://api.github.com/users/nateprewitt/following{/other_user}","gists_url":"https://api.github.com/users/nateprewitt/gists{/gist_id}","starred_url":"https://api.github.com/users/nateprewitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nateprewitt/subscriptions","organizations_url":"https://api.github.com/users/nateprewitt/orgs","repos_url":"https://api.github.com/users/nateprewitt/repos","events_url":"https://api.github.com/users/nateprewitt/events{/privacy}","received_events_url":"https://api.github.com/users/nateprewitt/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2017-05-07T15:56:29Z","updated_at":"2017-05-08T14:18:15Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kennethreitz/pipenv/pulls/347","html_url":"https://github.com/kennethreitz/pipenv/pull/347","diff_url":"https://github.com/kennethreitz/pipenv/pull/347.diff","patch_url":"https://github.com/kennethreitz/pipenv/pull/347.patch"},"body":"This PR is to address the issue pointed out in #342.\r\n\r\nThe install process is dependent upon the virtualenv existing which isn't always the case for fresh projects. This is the most common case this code will execute in, so we need to be able to create the Pipfile before the virtualenv is created. This will read the contents of the requirements.txt file and write them directly into a new Pipfile.\r\n\r\nThis approach required a little reworking of your initial implementation @kennethreitz, so I'd like you to sign off on this.\r\n\r\nI removed the install portion completely because not only was it broken, but I don't know if it makes sense to install with *any* command passed to pipenv. Things like `pipenv shell` and `pipenv check` currently install the requirements.txt into the new environment which probably isn't what the user would expect.\r\n\r\nI also removed the `BAD_PACKAGES` check because it *seems* to have been put in place to handle the fact those packages are always returned by `pip freeze`. If the user explicitly defines something like `appdirs` at a specific version in their requirements.txt file, I feel like we should move that to the Pipfile. They felt strongly enough to make it a requirement, so let's not silently delete it."},"comment":{"url":"https://api.github.com/repos/kennethreitz/pipenv/issues/comments/299879646","html_url":"https://github.com/kennethreitz/pipenv/pull/347#issuecomment-299879646","issue_url":"https://api.github.com/repos/kennethreitz/pipenv/issues/347","id":299879646,"user":{"login":"kennethreitz","id":119893,"avatar_url":"https://avatars1.githubusercontent.com/u/119893?v=3","gravatar_id":"","url":"https://api.github.com/users/kennethreitz","html_url":"https://github.com/kennethreitz","followers_url":"https://api.github.com/users/kennethreitz/followers","following_url":"https://api.github.com/users/kennethreitz/following{/other_user}","gists_url":"https://api.github.com/users/kennethreitz/gists{/gist_id}","starred_url":"https://api.github.com/users/kennethreitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kennethreitz/subscriptions","organizations_url":"https://api.github.com/users/kennethreitz/orgs","repos_url":"https://api.github.com/users/kennethreitz/repos","events_url":"https://api.github.com/users/kennethreitz/events{/privacy}","received_events_url":"https://api.github.com/users/kennethreitz/received_events","type":"User","site_admin":false},"created_at":"2017-05-08T14:18:14Z","updated_at":"2017-05-08T14:18:14Z","body":"Basically, I want to err on the side of removing them, then revisiting that if people have problems. "}}
{"actor":{"display_login":"kennethreitz"}}