{"action":"created","issue":{"url":"https://api.github.com/repos/mpolednik/script.kodi.hue.ambilight/issues/35","repository_url":"https://api.github.com/repos/mpolednik/script.kodi.hue.ambilight","labels_url":"https://api.github.com/repos/mpolednik/script.kodi.hue.ambilight/issues/35/labels{/name}","comments_url":"https://api.github.com/repos/mpolednik/script.kodi.hue.ambilight/issues/35/comments","events_url":"https://api.github.com/repos/mpolednik/script.kodi.hue.ambilight/issues/35/events","html_url":"https://github.com/mpolednik/script.kodi.hue.ambilight/pull/35","id":209920593,"number":35,"title":"Rewrite (v1.0?!)","user":{"login":"mpolednik","id":2596342,"avatar_url":"https://avatars.githubusercontent.com/u/2596342?v=3","gravatar_id":"","url":"https://api.github.com/users/mpolednik","html_url":"https://github.com/mpolednik","followers_url":"https://api.github.com/users/mpolednik/followers","following_url":"https://api.github.com/users/mpolednik/following{/other_user}","gists_url":"https://api.github.com/users/mpolednik/gists{/gist_id}","starred_url":"https://api.github.com/users/mpolednik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpolednik/subscriptions","organizations_url":"https://api.github.com/users/mpolednik/orgs","repos_url":"https://api.github.com/users/mpolednik/repos","events_url":"https://api.github.com/users/mpolednik/events{/privacy}","received_events_url":"https://api.github.com/users/mpolednik/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":30,"created_at":"2017-02-23T23:54:05Z","updated_at":"2017-02-27T17:27:26Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mpolednik/script.kodi.hue.ambilight/pulls/35","html_url":"https://github.com/mpolednik/script.kodi.hue.ambilight/pull/35","diff_url":"https://github.com/mpolednik/script.kodi.hue.ambilight/pull/35.diff","patch_url":"https://github.com/mpolednik/script.kodi.hue.ambilight/pull/35.patch"},"body":"So, the refactoring is somewhat shaping nicely I believe. It may be time to move on to master. About the patches themself, they are huge. I've managed to rewrite most of the code and untangle the state to current state_change and new Controller objects. Additionally, tests are also added (running on Travis, manually launchable by `PYTHONPATH=resources/lib pytest -v` in project's root dir (e.g. ~/script.kodi.hue.ambilight).\r\n\r\nWhole configuration is reworked, lights can now be dynamically selected from/to ambilight and theatre groups. As for the ambilight algorithm itself, I believe there are some changes that will require further testing and fine-tuning to get to the point where we were. There is no hue/saturation oveerride functionality *yet*; should be quite trivial to add but time consuming.\r\n\r\nAnnoyance I have noticed since owning the lighstrip (not directly related to the rework): it's color gamut is brutal compared to v1 bulbs. Anyone who wants to play with the constants in resources/lib/image.py is more than welcome to fix the difference. :) (I'd eventually think of light-specific gamut corrections now that the plugin is kinda more spread.)\r\n\r\nKnown issues: \r\n- credits undimming was removed, will be reimplemented when the state checking gets more robust\r\n- when configuring groups, for window to properly react, one has to press OK after selecting the bulbs and then OK to exit the configuration and re-enter it\r\n\r\nShould solve: #24 #21 #16 #15 #7 #6 #5 \r\nOnly v17+ is supported."},"comment":{"url":"https://api.github.com/repos/mpolednik/script.kodi.hue.ambilight/issues/comments/282789336","html_url":"https://github.com/mpolednik/script.kodi.hue.ambilight/pull/35#issuecomment-282789336","issue_url":"https://api.github.com/repos/mpolednik/script.kodi.hue.ambilight/issues/35","id":282789336,"user":{"login":"mpolednik","id":2596342,"avatar_url":"https://avatars.githubusercontent.com/u/2596342?v=3","gravatar_id":"","url":"https://api.github.com/users/mpolednik","html_url":"https://github.com/mpolednik","followers_url":"https://api.github.com/users/mpolednik/followers","following_url":"https://api.github.com/users/mpolednik/following{/other_user}","gists_url":"https://api.github.com/users/mpolednik/gists{/gist_id}","starred_url":"https://api.github.com/users/mpolednik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpolednik/subscriptions","organizations_url":"https://api.github.com/users/mpolednik/orgs","repos_url":"https://api.github.com/users/mpolednik/repos","events_url":"https://api.github.com/users/mpolednik/events{/privacy}","received_events_url":"https://api.github.com/users/mpolednik/received_events","type":"User","site_admin":false},"created_at":"2017-02-27T17:27:26Z","updated_at":"2017-02-27T17:27:26Z","body":"@hstamas No, download the refactoring-v9-candidate branch. I think it takes some time for github to regenerate the zip, so if you do it later you should be well set.\r\n\r\nAlso double check the settings - selecting lights, pressing OK and then opening the group dialog should already highlight the ones you selected before. If it doesn't, there is something wrong.\r\n\r\nBTW I actually really like the static group! :D (got 3 bulbs & lightstrip, so using ambilight=lightstrip; theater=2bulbs; static=1bulb is DAMN PERFECT!)"}}
{"actor":{"display_login":"mpolednik"}}