{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla/pdf.js/issues/9145","repository_url":"https://api.github.com/repos/mozilla/pdf.js","labels_url":"https://api.github.com/repos/mozilla/pdf.js/issues/9145/labels{/name}","comments_url":"https://api.github.com/repos/mozilla/pdf.js/issues/9145/comments","events_url":"https://api.github.com/repos/mozilla/pdf.js/issues/9145/events","html_url":"https://github.com/mozilla/pdf.js/pull/9145","id":274700698,"number":9145,"title":"Fix TypeError: Cannot read property 'getDestinationHash' of undefined","user":{"login":"wojtekmaj","id":5426427,"avatar_url":"https://avatars2.githubusercontent.com/u/5426427?v=4","gravatar_id":"","url":"https://api.github.com/users/wojtekmaj","html_url":"https://github.com/wojtekmaj","followers_url":"https://api.github.com/users/wojtekmaj/followers","following_url":"https://api.github.com/users/wojtekmaj/following{/other_user}","gists_url":"https://api.github.com/users/wojtekmaj/gists{/gist_id}","starred_url":"https://api.github.com/users/wojtekmaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wojtekmaj/subscriptions","organizations_url":"https://api.github.com/users/wojtekmaj/orgs","repos_url":"https://api.github.com/users/wojtekmaj/repos","events_url":"https://api.github.com/users/wojtekmaj/events{/privacy}","received_events_url":"https://api.github.com/users/wojtekmaj/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-11-16T23:29:05Z","updated_at":"2017-11-16T23:53:43Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/mozilla/pdf.js/pulls/9145","html_url":"https://github.com/mozilla/pdf.js/pull/9145","diff_url":"https://github.com/mozilla/pdf.js/pull/9145.diff","patch_url":"https://github.com/mozilla/pdf.js/pull/9145.patch"},"body":"If someone happened to call AnnotationLayer.render(params) without giving valid linkService in params, clicking internal link was causing said TypeError."},"comment":{"url":"https://api.github.com/repos/mozilla/pdf.js/issues/comments/345101320","html_url":"https://github.com/mozilla/pdf.js/pull/9145#issuecomment-345101320","issue_url":"https://api.github.com/repos/mozilla/pdf.js/issues/9145","id":345101320,"user":{"login":"Snuffleupagus","id":2692120,"avatar_url":"https://avatars0.githubusercontent.com/u/2692120?v=4","gravatar_id":"","url":"https://api.github.com/users/Snuffleupagus","html_url":"https://github.com/Snuffleupagus","followers_url":"https://api.github.com/users/Snuffleupagus/followers","following_url":"https://api.github.com/users/Snuffleupagus/following{/other_user}","gists_url":"https://api.github.com/users/Snuffleupagus/gists{/gist_id}","starred_url":"https://api.github.com/users/Snuffleupagus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Snuffleupagus/subscriptions","organizations_url":"https://api.github.com/users/Snuffleupagus/orgs","repos_url":"https://api.github.com/users/Snuffleupagus/repos","events_url":"https://api.github.com/users/Snuffleupagus/events{/privacy}","received_events_url":"https://api.github.com/users/Snuffleupagus/received_events","type":"User","site_admin":false},"created_at":"2017-11-16T23:53:43Z","updated_at":"2017-11-16T23:53:43Z","author_association":"MEMBER","body":"> As far as I know, external links do not require linkService, thus have no problem rendering without linkService.\r\n\r\nIf you use `AnnotationLayer.{render, update}`, you *must* pass in either a `PDFLinkService` (or a `SimpleLinkService`) instance (since the parameter isn't marked as `optional`).\r\nIf you search for `this.linkService` in https://github.com/mozilla/pdf.js/blob/master/src/display/annotation_layer.js, you'll see that it's used in a number of different situations. I'm really not keen on adding similar checks all over the place, and failing silently does not seem like a good idea to me.\r\n\r\n> Silently failing rendering internal link could help rendering the rest of them.\r\n\r\nMaybe, but that would also provide no indication whatsoever to the user that something actually went wrong!\r\n"}}
{"actor":{"display_login":"Snuffleupagus"}}