{"action":"closed","number":175,"pull_request":{"url":"https://api.github.com/repos/kennethreitz/pipenv/pulls/175","id":104062106,"html_url":"https://github.com/kennethreitz/pipenv/pull/175","diff_url":"https://github.com/kennethreitz/pipenv/pull/175.diff","patch_url":"https://github.com/kennethreitz/pipenv/pull/175.patch","issue_url":"https://api.github.com/repos/kennethreitz/pipenv/issues/175","number":175,"state":"closed","locked":false,"title":"Improve dashed version parsing","user":{"login":"natpen","id":1137088,"avatar_url":"https://avatars.githubusercontent.com/u/1137088?v=3","gravatar_id":"","url":"https://api.github.com/users/natpen","html_url":"https://github.com/natpen","followers_url":"https://api.github.com/users/natpen/followers","following_url":"https://api.github.com/users/natpen/following{/other_user}","gists_url":"https://api.github.com/users/natpen/gists{/gist_id}","starred_url":"https://api.github.com/users/natpen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natpen/subscriptions","organizations_url":"https://api.github.com/users/natpen/orgs","repos_url":"https://api.github.com/users/natpen/repos","events_url":"https://api.github.com/users/natpen/events{/privacy}","received_events_url":"https://api.github.com/users/natpen/received_events","type":"User","site_admin":false},"body":"Hi! Hope you don't mind that I wrote some quick code for this. It was breaking on the dash in version 3.2.3-2 of functools32, which is preventing me from sharing some pipenv code with colleagues.\r\n\r\nWith this PR, instead of truncating the ends of versions containing dashes, it will keep them intact. Also I added some tests for the parse_download_fname function.","created_at":"2017-02-01T01:55:16Z","updated_at":"2017-02-01T02:29:48Z","closed_at":"2017-02-01T02:29:48Z","merged_at":"2017-02-01T02:29:47Z","merge_commit_sha":"8714a6f07abeddc746ed2396c041a0dc2ef65785","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/kennethreitz/pipenv/pulls/175/commits","review_comments_url":"https://api.github.com/repos/kennethreitz/pipenv/pulls/175/comments","review_comment_url":"https://api.github.com/repos/kennethreitz/pipenv/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kennethreitz/pipenv/issues/175/comments","statuses_url":"https://api.github.com/repos/kennethreitz/pipenv/statuses/65dd2c323dfdbe67e5ef7292928c5500aee7e327","head":{"label":"natpen:improve-dashed-version-parsing","ref":"improve-dashed-version-parsing","sha":"65dd2c323dfdbe67e5ef7292928c5500aee7e327","user":{"login":"natpen","id":1137088,"avatar_url":"https://avatars.githubusercontent.com/u/1137088?v=3","gravatar_id":"","url":"https://api.github.com/users/natpen","html_url":"https://github.com/natpen","followers_url":"https://api.github.com/users/natpen/followers","following_url":"https://api.github.com/users/natpen/following{/other_user}","gists_url":"https://api.github.com/users/natpen/gists{/gist_id}","starred_url":"https://api.github.com/users/natpen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natpen/subscriptions","organizations_url":"https://api.github.com/users/natpen/orgs","repos_url":"https://api.github.com/users/natpen/repos","events_url":"https://api.github.com/users/natpen/events{/privacy}","received_events_url":"https://api.github.com/users/natpen/received_events","type":"User","site_admin":false},"repo":{"id":80581007,"name":"pipenv","full_name":"natpen/pipenv","owner":{"login":"natpen","id":1137088,"avatar_url":"https://avatars.githubusercontent.com/u/1137088?v=3","gravatar_id":"","url":"https://api.github.com/users/natpen","html_url":"https://github.com/natpen","followers_url":"https://api.github.com/users/natpen/followers","following_url":"https://api.github.com/users/natpen/following{/other_user}","gists_url":"https://api.github.com/users/natpen/gists{/gist_id}","starred_url":"https://api.github.com/users/natpen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natpen/subscriptions","organizations_url":"https://api.github.com/users/natpen/orgs","repos_url":"https://api.github.com/users/natpen/repos","events_url":"https://api.github.com/users/natpen/events{/privacy}","received_events_url":"https://api.github.com/users/natpen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/natpen/pipenv","description":"Sacred Marriage of Pipfile, Pip, & Virtualenv.","fork":true,"url":"https://api.github.com/repos/natpen/pipenv","forks_url":"https://api.github.com/repos/natpen/pipenv/forks","keys_url":"https://api.github.com/repos/natpen/pipenv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/natpen/pipenv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/natpen/pipenv/teams","hooks_url":"https://api.github.com/repos/natpen/pipenv/hooks","issue_events_url":"https://api.github.com/repos/natpen/pipenv/issues/events{/number}","events_url":"https://api.github.com/repos/natpen/pipenv/events","assignees_url":"https://api.github.com/repos/natpen/pipenv/assignees{/user}","branches_url":"https://api.github.com/repos/natpen/pipenv/branches{/branch}","tags_url":"https://api.github.com/repos/natpen/pipenv/tags","blobs_url":"https://api.github.com/repos/natpen/pipenv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/natpen/pipenv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/natpen/pipenv/git/refs{/sha}","trees_url":"https://api.github.com/repos/natpen/pipenv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/natpen/pipenv/statuses/{sha}","languages_url":"https://api.github.com/repos/natpen/pipenv/languages","stargazers_url":"https://api.github.com/repos/natpen/pipenv/stargazers","contributors_url":"https://api.github.com/repos/natpen/pipenv/contributors","subscribers_url":"https://api.github.com/repos/natpen/pipenv/subscribers","subscription_url":"https://api.github.com/repos/natpen/pipenv/subscription","commits_url":"https://api.github.com/repos/natpen/pipenv/commits{/sha}","git_commits_url":"https://api.github.com/repos/natpen/pipenv/git/commits{/sha}","comments_url":"https://api.github.com/repos/natpen/pipenv/comments{/number}","issue_comment_url":"https://api.github.com/repos/natpen/pipenv/issues/comments{/number}","contents_url":"https://api.github.com/repos/natpen/pipenv/contents/{+path}","compare_url":"https://api.github.com/repos/natpen/pipenv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/natpen/pipenv/merges","archive_url":"https://api.github.com/repos/natpen/pipenv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/natpen/pipenv/downloads","issues_url":"https://api.github.com/repos/natpen/pipenv/issues{/number}","pulls_url":"https://api.github.com/repos/natpen/pipenv/pulls{/number}","milestones_url":"https://api.github.com/repos/natpen/pipenv/milestones{/number}","notifications_url":"https://api.github.com/repos/natpen/pipenv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/natpen/pipenv/labels{/name}","releases_url":"https://api.github.com/repos/natpen/pipenv/releases{/id}","deployments_url":"https://api.github.com/repos/natpen/pipenv/deployments","created_at":"2017-02-01T01:51:08Z","updated_at":"2017-02-01T01:51:09Z","pushed_at":"2017-02-01T01:53:58Z","git_url":"git://github.com/natpen/pipenv.git","ssh_url":"git@github.com:natpen/pipenv.git","clone_url":"https://github.com/natpen/pipenv.git","svn_url":"https://github.com/natpen/pipenv","homepage":"http://pipenv.org/","size":395,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kennethreitz:master","ref":"master","sha":"59dbdb650957c2b3431f62cf23b4cdc16a626e78","user":{"login":"kennethreitz","id":119893,"avatar_url":"https://avatars.githubusercontent.com/u/119893?v=3","gravatar_id":"","url":"https://api.github.com/users/kennethreitz","html_url":"https://github.com/kennethreitz","followers_url":"https://api.github.com/users/kennethreitz/followers","following_url":"https://api.github.com/users/kennethreitz/following{/other_user}","gists_url":"https://api.github.com/users/kennethreitz/gists{/gist_id}","starred_url":"https://api.github.com/users/kennethreitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kennethreitz/subscriptions","organizations_url":"https://api.github.com/users/kennethreitz/orgs","repos_url":"https://api.github.com/users/kennethreitz/repos","events_url":"https://api.github.com/users/kennethreitz/events{/privacy}","received_events_url":"https://api.github.com/users/kennethreitz/received_events","type":"User","site_admin":false},"repo":{"id":79510167,"name":"pipenv","full_name":"kennethreitz/pipenv","owner":{"login":"kennethreitz","id":119893,"avatar_url":"https://avatars.githubusercontent.com/u/119893?v=3","gravatar_id":"","url":"https://api.github.com/users/kennethreitz","html_url":"https://github.com/kennethreitz","followers_url":"https://api.github.com/users/kennethreitz/followers","following_url":"https://api.github.com/users/kennethreitz/following{/other_user}","gists_url":"https://api.github.com/users/kennethreitz/gists{/gist_id}","starred_url":"https://api.github.com/users/kennethreitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kennethreitz/subscriptions","organizations_url":"https://api.github.com/users/kennethreitz/orgs","repos_url":"https://api.github.com/users/kennethreitz/repos","events_url":"https://api.github.com/users/kennethreitz/events{/privacy}","received_events_url":"https://api.github.com/users/kennethreitz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kennethreitz/pipenv","description":"Sacred Marriage of Pipfile, Pip, & Virtualenv.","fork":false,"url":"https://api.github.com/repos/kennethreitz/pipenv","forks_url":"https://api.github.com/repos/kennethreitz/pipenv/forks","keys_url":"https://api.github.com/repos/kennethreitz/pipenv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kennethreitz/pipenv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kennethreitz/pipenv/teams","hooks_url":"https://api.github.com/repos/kennethreitz/pipenv/hooks","issue_events_url":"https://api.github.com/repos/kennethreitz/pipenv/issues/events{/number}","events_url":"https://api.github.com/repos/kennethreitz/pipenv/events","assignees_url":"https://api.github.com/repos/kennethreitz/pipenv/assignees{/user}","branches_url":"https://api.github.com/repos/kennethreitz/pipenv/branches{/branch}","tags_url":"https://api.github.com/repos/kennethreitz/pipenv/tags","blobs_url":"https://api.github.com/repos/kennethreitz/pipenv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kennethreitz/pipenv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kennethreitz/pipenv/git/refs{/sha}","trees_url":"https://api.github.com/repos/kennethreitz/pipenv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kennethreitz/pipenv/statuses/{sha}","languages_url":"https://api.github.com/repos/kennethreitz/pipenv/languages","stargazers_url":"https://api.github.com/repos/kennethreitz/pipenv/stargazers","contributors_url":"https://api.github.com/repos/kennethreitz/pipenv/contributors","subscribers_url":"https://api.github.com/repos/kennethreitz/pipenv/subscribers","subscription_url":"https://api.github.com/repos/kennethreitz/pipenv/subscription","commits_url":"https://api.github.com/repos/kennethreitz/pipenv/commits{/sha}","git_commits_url":"https://api.github.com/repos/kennethreitz/pipenv/git/commits{/sha}","comments_url":"https://api.github.com/repos/kennethreitz/pipenv/comments{/number}","issue_comment_url":"https://api.github.com/repos/kennethreitz/pipenv/issues/comments{/number}","contents_url":"https://api.github.com/repos/kennethreitz/pipenv/contents/{+path}","compare_url":"https://api.github.com/repos/kennethreitz/pipenv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kennethreitz/pipenv/merges","archive_url":"https://api.github.com/repos/kennethreitz/pipenv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kennethreitz/pipenv/downloads","issues_url":"https://api.github.com/repos/kennethreitz/pipenv/issues{/number}","pulls_url":"https://api.github.com/repos/kennethreitz/pipenv/pulls{/number}","milestones_url":"https://api.github.com/repos/kennethreitz/pipenv/milestones{/number}","notifications_url":"https://api.github.com/repos/kennethreitz/pipenv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kennethreitz/pipenv/labels{/name}","releases_url":"https://api.github.com/repos/kennethreitz/pipenv/releases{/id}","deployments_url":"https://api.github.com/repos/kennethreitz/pipenv/deployments","created_at":"2017-01-20T00:44:02Z","updated_at":"2017-02-01T02:26:44Z","pushed_at":"2017-02-01T02:29:47Z","git_url":"git://github.com/kennethreitz/pipenv.git","ssh_url":"git@github.com:kennethreitz/pipenv.git","clone_url":"https://github.com/kennethreitz/pipenv.git","svn_url":"https://github.com/kennethreitz/pipenv","homepage":"http://pipenv.org/","size":395,"stargazers_count":2673,"watchers_count":2673,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":69,"mirror_url":null,"open_issues_count":3,"forks":69,"open_issues":3,"watchers":2673,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kennethreitz/pipenv/pulls/175"},"html":{"href":"https://github.com/kennethreitz/pipenv/pull/175"},"issue":{"href":"https://api.github.com/repos/kennethreitz/pipenv/issues/175"},"comments":{"href":"https://api.github.com/repos/kennethreitz/pipenv/issues/175/comments"},"review_comments":{"href":"https://api.github.com/repos/kennethreitz/pipenv/pulls/175/comments"},"review_comment":{"href":"https://api.github.com/repos/kennethreitz/pipenv/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kennethreitz/pipenv/pulls/175/commits"},"statuses":{"href":"https://api.github.com/repos/kennethreitz/pipenv/statuses/65dd2c323dfdbe67e5ef7292928c5500aee7e327"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"kennethreitz","id":119893,"avatar_url":"https://avatars.githubusercontent.com/u/119893?v=3","gravatar_id":"","url":"https://api.github.com/users/kennethreitz","html_url":"https://github.com/kennethreitz","followers_url":"https://api.github.com/users/kennethreitz/followers","following_url":"https://api.github.com/users/kennethreitz/following{/other_user}","gists_url":"https://api.github.com/users/kennethreitz/gists{/gist_id}","starred_url":"https://api.github.com/users/kennethreitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kennethreitz/subscriptions","organizations_url":"https://api.github.com/users/kennethreitz/orgs","repos_url":"https://api.github.com/users/kennethreitz/repos","events_url":"https://api.github.com/users/kennethreitz/events{/privacy}","received_events_url":"https://api.github.com/users/kennethreitz/received_events","type":"User","site_admin":false},"comments":0,"review_comments":1,"maintainer_can_modify":false,"commits":1,"additions":50,"deletions":14,"changed_files":2}}
{"actor":{"display_login":"kennethreitz"}}