{"action":"created","issue":{"url":"https://api.github.com/repos/pkp/pkp-lib/issues/2092","repository_url":"https://api.github.com/repos/pkp/pkp-lib","labels_url":"https://api.github.com/repos/pkp/pkp-lib/issues/2092/labels{/name}","comments_url":"https://api.github.com/repos/pkp/pkp-lib/issues/2092/comments","events_url":"https://api.github.com/repos/pkp/pkp-lib/issues/2092/events","html_url":"https://github.com/pkp/pkp-lib/issues/2092","id":195131905,"number":2092,"title":"[OJS] Reviewer doesn't have adequate permission to download review file","user":{"login":"jmacgreg","id":201446,"avatar_url":"https://avatars.githubusercontent.com/u/201446?v=3","gravatar_id":"","url":"https://api.github.com/users/jmacgreg","html_url":"https://github.com/jmacgreg","followers_url":"https://api.github.com/users/jmacgreg/followers","following_url":"https://api.github.com/users/jmacgreg/following{/other_user}","gists_url":"https://api.github.com/users/jmacgreg/gists{/gist_id}","starred_url":"https://api.github.com/users/jmacgreg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmacgreg/subscriptions","organizations_url":"https://api.github.com/users/jmacgreg/orgs","repos_url":"https://api.github.com/users/jmacgreg/repos","events_url":"https://api.github.com/users/jmacgreg/events{/privacy}","received_events_url":"https://api.github.com/users/jmacgreg/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"bozana","id":378421,"avatar_url":"https://avatars.githubusercontent.com/u/378421?v=3","gravatar_id":"","url":"https://api.github.com/users/bozana","html_url":"https://github.com/bozana","followers_url":"https://api.github.com/users/bozana/followers","following_url":"https://api.github.com/users/bozana/following{/other_user}","gists_url":"https://api.github.com/users/bozana/gists{/gist_id}","starred_url":"https://api.github.com/users/bozana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bozana/subscriptions","organizations_url":"https://api.github.com/users/bozana/orgs","repos_url":"https://api.github.com/users/bozana/repos","events_url":"https://api.github.com/users/bozana/events{/privacy}","received_events_url":"https://api.github.com/users/bozana/received_events","type":"User","site_admin":false},"assignees":[{"login":"bozana","id":378421,"avatar_url":"https://avatars.githubusercontent.com/u/378421?v=3","gravatar_id":"","url":"https://api.github.com/users/bozana","html_url":"https://github.com/bozana","followers_url":"https://api.github.com/users/bozana/followers","following_url":"https://api.github.com/users/bozana/following{/other_user}","gists_url":"https://api.github.com/users/bozana/gists{/gist_id}","starred_url":"https://api.github.com/users/bozana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bozana/subscriptions","organizations_url":"https://api.github.com/users/bozana/orgs","repos_url":"https://api.github.com/users/bozana/repos","events_url":"https://api.github.com/users/bozana/events{/privacy}","received_events_url":"https://api.github.com/users/bozana/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/pkp/pkp-lib/milestones/23","html_url":"https://github.com/pkp/pkp-lib/milestone/23","labels_url":"https://api.github.com/repos/pkp/pkp-lib/milestones/23/labels","id":2062894,"number":23,"title":"OJS 3.0.2","description":"Minor bugfix release following up on OJS 3.0.1.","creator":{"login":"asmecher","id":200411,"avatar_url":"https://avatars.githubusercontent.com/u/200411?v=3","gravatar_id":"","url":"https://api.github.com/users/asmecher","html_url":"https://github.com/asmecher","followers_url":"https://api.github.com/users/asmecher/followers","following_url":"https://api.github.com/users/asmecher/following{/other_user}","gists_url":"https://api.github.com/users/asmecher/gists{/gist_id}","starred_url":"https://api.github.com/users/asmecher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asmecher/subscriptions","organizations_url":"https://api.github.com/users/asmecher/orgs","repos_url":"https://api.github.com/users/asmecher/repos","events_url":"https://api.github.com/users/asmecher/events{/privacy}","received_events_url":"https://api.github.com/users/asmecher/received_events","type":"User","site_admin":false},"open_issues":85,"closed_issues":17,"state":"open","created_at":"2016-10-11T17:48:51Z","updated_at":"2016-12-22T16:42:49Z","due_on":"2017-02-01T08:00:00Z","closed_at":null},"comments":1,"created_at":"2016-12-13T01:05:54Z","updated_at":"2017-01-04T15:00:32Z","closed_at":null,"body":"The problem has been discussed here: http://forum.pkp.sfu.ca/t/ojs-3-the-current-role-does-not-have-access-to-this-operation/24614/16 and in addition we have just run into the same problem on a journal we host. \r\n\r\nProblem behaviour: a reviewer accepts a review, and goes to Step 3, where they should be able to download the review file. When they click on the review file, they receive the following JSON erorr: \r\n\r\n{\"status\":false,\"content\":\"The current role does not have access to this operation.\",\"elementId\":\"0\"}\r\n\r\nSome things I've confirmed: \r\n\r\n- access is via one-click, but I also tried by logging in as the reviewer, and no luck; \r\n- reviewer has been enrolled as a reviewer; \r\n- reviewer has accepted the review. \r\n\r\n"},"comment":{"url":"https://api.github.com/repos/pkp/pkp-lib/issues/comments/270390787","html_url":"https://github.com/pkp/pkp-lib/issues/2092#issuecomment-270390787","issue_url":"https://api.github.com/repos/pkp/pkp-lib/issues/2092","id":270390787,"user":{"login":"bozana","id":378421,"avatar_url":"https://avatars.githubusercontent.com/u/378421?v=3","gravatar_id":"","url":"https://api.github.com/users/bozana","html_url":"https://github.com/bozana","followers_url":"https://api.github.com/users/bozana/followers","following_url":"https://api.github.com/users/bozana/following{/other_user}","gists_url":"https://api.github.com/users/bozana/gists{/gist_id}","starred_url":"https://api.github.com/users/bozana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bozana/subscriptions","organizations_url":"https://api.github.com/users/bozana/orgs","repos_url":"https://api.github.com/users/bozana/repos","events_url":"https://api.github.com/users/bozana/events{/privacy}","received_events_url":"https://api.github.com/users/bozana/received_events","type":"User","site_admin":false},"created_at":"2017-01-04T15:00:32Z","updated_at":"2017-01-04T15:00:32Z","body":"@asmecher, I think this condition: `$submissionFile->getViewable()` is maybe not necessary for review assignments: In normal case, the files that an editor selects for the review i.e. in the \"Review Files\" grid are viewable. However, the editor can deselect the checkbox when editing such a file and the file will then have viewable = 0. But, if that file is assigned to a reviewer, in the \"Reviewers\" grid and inserted in the table review_files, it should be viewable for the reviewers no matter. Thus \"viewable\" for the files assigned to a reviewer (that editor defines selecting the checkbox in the \"Review Files\" grid) should not be considered for the reviewer to access the files. Don't you think so?"}}
{"actor":{"display_login":"bozana"}}