{"action":"created","comment":{"url":"https://api.github.com/repos/actionless/oomox/pulls/comments/103025353","pull_request_review_id":23804069,"id":103025353,"diff_hunk":"@@ -348,6 +355,21 @@ def __init__(self, *args, **kwargs):\n     def do_startup(self):\n         Gtk.Application.do_startup(self)\n \n+        quit_action = Gio.SimpleAction.new(\"quit\", None)\n+        quit_action.connect(\"activate\", self.on_quit)\n+        self.add_action(quit_action)\n+\n+        self.set_accels_for_action(\"app.quit\", [\"<Primary>Q\"])\n+\n+        self.set_accels_for_action(\"win.clone\", [\"<Primary>D\"])","path":"gui/main.py","position":229,"original_position":229,"commit_id":"3526e7fc7281178b976a1a4982a34e70fd9d28a9","original_commit_id":"3526e7fc7281178b976a1a4982a34e70fd9d28a9","user":{"login":"actionless","id":1655669,"avatar_url":"https://avatars.githubusercontent.com/u/1655669?v=3","gravatar_id":"","url":"https://api.github.com/users/actionless","html_url":"https://github.com/actionless","followers_url":"https://api.github.com/users/actionless/followers","following_url":"https://api.github.com/users/actionless/following{/other_user}","gists_url":"https://api.github.com/users/actionless/gists{/gist_id}","starred_url":"https://api.github.com/users/actionless/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/actionless/subscriptions","organizations_url":"https://api.github.com/users/actionless/orgs","repos_url":"https://api.github.com/users/actionless/repos","events_url":"https://api.github.com/users/actionless/events{/privacy}","received_events_url":"https://api.github.com/users/actionless/received_events","type":"User","site_admin":false},"body":"i would suggest using enum for menu instead of using strings (ie the same but without quotes), that will make easier for static analysis tools to catch typos\r\n\r\nalso it will be great to write shortcut in a button tooltip or start using GtkShortcutsShortcut for new gtk shortcut shortcut help concept","created_at":"2017-02-24T20:22:00Z","updated_at":"2017-02-24T20:22:00Z","html_url":"https://github.com/actionless/oomox/pull/68#discussion_r103025353","pull_request_url":"https://api.github.com/repos/actionless/oomox/pulls/68","_links":{"self":{"href":"https://api.github.com/repos/actionless/oomox/pulls/comments/103025353"},"html":{"href":"https://github.com/actionless/oomox/pull/68#discussion_r103025353"},"pull_request":{"href":"https://api.github.com/repos/actionless/oomox/pulls/68"}}},"pull_request":{"url":"https://api.github.com/repos/actionless/oomox/pulls/68","id":107871570,"html_url":"https://github.com/actionless/oomox/pull/68","diff_url":"https://github.com/actionless/oomox/pull/68.diff","patch_url":"https://github.com/actionless/oomox/pull/68.patch","issue_url":"https://api.github.com/repos/actionless/oomox/issues/68","number":68,"state":"open","locked":false,"title":"GUI: Add keyboard shortcuts (and small other fixes)","user":{"login":"cwendling","id":24433571,"avatar_url":"https://avatars.githubusercontent.com/u/24433571?v=3","gravatar_id":"","url":"https://api.github.com/users/cwendling","html_url":"https://github.com/cwendling","followers_url":"https://api.github.com/users/cwendling/followers","following_url":"https://api.github.com/users/cwendling/following{/other_user}","gists_url":"https://api.github.com/users/cwendling/gists{/gist_id}","starred_url":"https://api.github.com/users/cwendling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cwendling/subscriptions","organizations_url":"https://api.github.com/users/cwendling/orgs","repos_url":"https://api.github.com/users/cwendling/repos","events_url":"https://api.github.com/users/cwendling/events{/privacy}","received_events_url":"https://api.github.com/users/cwendling/received_events","type":"User","site_admin":false},"body":"Switch to GActions and associate shortcuts to them so they can be easily triggered with the keyboard.","created_at":"2017-02-24T17:20:19Z","updated_at":"2017-02-24T20:22:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bfe14efedc19bd7314020f00dbfc6920f661017e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/actionless/oomox/pulls/68/commits","review_comments_url":"https://api.github.com/repos/actionless/oomox/pulls/68/comments","review_comment_url":"https://api.github.com/repos/actionless/oomox/pulls/comments{/number}","comments_url":"https://api.github.com/repos/actionless/oomox/issues/68/comments","statuses_url":"https://api.github.com/repos/actionless/oomox/statuses/3526e7fc7281178b976a1a4982a34e70fd9d28a9","head":{"label":"cwendling:window-keyboard","ref":"window-keyboard","sha":"3526e7fc7281178b976a1a4982a34e70fd9d28a9","user":{"login":"cwendling","id":24433571,"avatar_url":"https://avatars.githubusercontent.com/u/24433571?v=3","gravatar_id":"","url":"https://api.github.com/users/cwendling","html_url":"https://github.com/cwendling","followers_url":"https://api.github.com/users/cwendling/followers","following_url":"https://api.github.com/users/cwendling/following{/other_user}","gists_url":"https://api.github.com/users/cwendling/gists{/gist_id}","starred_url":"https://api.github.com/users/cwendling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cwendling/subscriptions","organizations_url":"https://api.github.com/users/cwendling/orgs","repos_url":"https://api.github.com/users/cwendling/repos","events_url":"https://api.github.com/users/cwendling/events{/privacy}","received_events_url":"https://api.github.com/users/cwendling/received_events","type":"User","site_admin":false},"repo":{"id":82916978,"name":"oomox","full_name":"cwendling/oomox","owner":{"login":"cwendling","id":24433571,"avatar_url":"https://avatars.githubusercontent.com/u/24433571?v=3","gravatar_id":"","url":"https://api.github.com/users/cwendling","html_url":"https://github.com/cwendling","followers_url":"https://api.github.com/users/cwendling/followers","following_url":"https://api.github.com/users/cwendling/following{/other_user}","gists_url":"https://api.github.com/users/cwendling/gists{/gist_id}","starred_url":"https://api.github.com/users/cwendling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cwendling/subscriptions","organizations_url":"https://api.github.com/users/cwendling/orgs","repos_url":"https://api.github.com/users/cwendling/repos","events_url":"https://api.github.com/users/cwendling/events{/privacy}","received_events_url":"https://api.github.com/users/cwendling/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cwendling/oomox","description":"Graphical application for generating different color variations of Numix theme (GTK2, GTK3), Gnome-Colors and Archdroid icons","fork":true,"url":"https://api.github.com/repos/cwendling/oomox","forks_url":"https://api.github.com/repos/cwendling/oomox/forks","keys_url":"https://api.github.com/repos/cwendling/oomox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cwendling/oomox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cwendling/oomox/teams","hooks_url":"https://api.github.com/repos/cwendling/oomox/hooks","issue_events_url":"https://api.github.com/repos/cwendling/oomox/issues/events{/number}","events_url":"https://api.github.com/repos/cwendling/oomox/events","assignees_url":"https://api.github.com/repos/cwendling/oomox/assignees{/user}","branches_url":"https://api.github.com/repos/cwendling/oomox/branches{/branch}","tags_url":"https://api.github.com/repos/cwendling/oomox/tags","blobs_url":"https://api.github.com/repos/cwendling/oomox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cwendling/oomox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cwendling/oomox/git/refs{/sha}","trees_url":"https://api.github.com/repos/cwendling/oomox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cwendling/oomox/statuses/{sha}","languages_url":"https://api.github.com/repos/cwendling/oomox/languages","stargazers_url":"https://api.github.com/repos/cwendling/oomox/stargazers","contributors_url":"https://api.github.com/repos/cwendling/oomox/contributors","subscribers_url":"https://api.github.com/repos/cwendling/oomox/subscribers","subscription_url":"https://api.github.com/repos/cwendling/oomox/subscription","commits_url":"https://api.github.com/repos/cwendling/oomox/commits{/sha}","git_commits_url":"https://api.github.com/repos/cwendling/oomox/git/commits{/sha}","comments_url":"https://api.github.com/repos/cwendling/oomox/comments{/number}","issue_comment_url":"https://api.github.com/repos/cwendling/oomox/issues/comments{/number}","contents_url":"https://api.github.com/repos/cwendling/oomox/contents/{+path}","compare_url":"https://api.github.com/repos/cwendling/oomox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cwendling/oomox/merges","archive_url":"https://api.github.com/repos/cwendling/oomox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cwendling/oomox/downloads","issues_url":"https://api.github.com/repos/cwendling/oomox/issues{/number}","pulls_url":"https://api.github.com/repos/cwendling/oomox/pulls{/number}","milestones_url":"https://api.github.com/repos/cwendling/oomox/milestones{/number}","notifications_url":"https://api.github.com/repos/cwendling/oomox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cwendling/oomox/labels{/name}","releases_url":"https://api.github.com/repos/cwendling/oomox/releases{/id}","deployments_url":"https://api.github.com/repos/cwendling/oomox/deployments","created_at":"2017-02-23T10:42:14Z","updated_at":"2017-02-23T10:42:20Z","pushed_at":"2017-02-24T17:13:43Z","git_url":"git://github.com/cwendling/oomox.git","ssh_url":"git@github.com:cwendling/oomox.git","clone_url":"https://github.com/cwendling/oomox.git","svn_url":"https://github.com/cwendling/oomox","homepage":"","size":8938,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"actionless:master","ref":"master","sha":"525f525dbf7d72cc3a038d68acf39e66cea87e29","user":{"login":"actionless","id":1655669,"avatar_url":"https://avatars.githubusercontent.com/u/1655669?v=3","gravatar_id":"","url":"https://api.github.com/users/actionless","html_url":"https://github.com/actionless","followers_url":"https://api.github.com/users/actionless/followers","following_url":"https://api.github.com/users/actionless/following{/other_user}","gists_url":"https://api.github.com/users/actionless/gists{/gist_id}","starred_url":"https://api.github.com/users/actionless/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/actionless/subscriptions","organizations_url":"https://api.github.com/users/actionless/orgs","repos_url":"https://api.github.com/users/actionless/repos","events_url":"https://api.github.com/users/actionless/events{/privacy}","received_events_url":"https://api.github.com/users/actionless/received_events","type":"User","site_admin":false},"repo":{"id":20155470,"name":"oomox","full_name":"actionless/oomox","owner":{"login":"actionless","id":1655669,"avatar_url":"https://avatars.githubusercontent.com/u/1655669?v=3","gravatar_id":"","url":"https://api.github.com/users/actionless","html_url":"https://github.com/actionless","followers_url":"https://api.github.com/users/actionless/followers","following_url":"https://api.github.com/users/actionless/following{/other_user}","gists_url":"https://api.github.com/users/actionless/gists{/gist_id}","starred_url":"https://api.github.com/users/actionless/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/actionless/subscriptions","organizations_url":"https://api.github.com/users/actionless/orgs","repos_url":"https://api.github.com/users/actionless/repos","events_url":"https://api.github.com/users/actionless/events{/privacy}","received_events_url":"https://api.github.com/users/actionless/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/actionless/oomox","description":"Graphical application for generating different color variations of Numix theme (GTK2, GTK3), Gnome-Colors and Archdroid icons","fork":false,"url":"https://api.github.com/repos/actionless/oomox","forks_url":"https://api.github.com/repos/actionless/oomox/forks","keys_url":"https://api.github.com/repos/actionless/oomox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/actionless/oomox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/actionless/oomox/teams","hooks_url":"https://api.github.com/repos/actionless/oomox/hooks","issue_events_url":"https://api.github.com/repos/actionless/oomox/issues/events{/number}","events_url":"https://api.github.com/repos/actionless/oomox/events","assignees_url":"https://api.github.com/repos/actionless/oomox/assignees{/user}","branches_url":"https://api.github.com/repos/actionless/oomox/branches{/branch}","tags_url":"https://api.github.com/repos/actionless/oomox/tags","blobs_url":"https://api.github.com/repos/actionless/oomox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/actionless/oomox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/actionless/oomox/git/refs{/sha}","trees_url":"https://api.github.com/repos/actionless/oomox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/actionless/oomox/statuses/{sha}","languages_url":"https://api.github.com/repos/actionless/oomox/languages","stargazers_url":"https://api.github.com/repos/actionless/oomox/stargazers","contributors_url":"https://api.github.com/repos/actionless/oomox/contributors","subscribers_url":"https://api.github.com/repos/actionless/oomox/subscribers","subscription_url":"https://api.github.com/repos/actionless/oomox/subscription","commits_url":"https://api.github.com/repos/actionless/oomox/commits{/sha}","git_commits_url":"https://api.github.com/repos/actionless/oomox/git/commits{/sha}","comments_url":"https://api.github.com/repos/actionless/oomox/comments{/number}","issue_comment_url":"https://api.github.com/repos/actionless/oomox/issues/comments{/number}","contents_url":"https://api.github.com/repos/actionless/oomox/contents/{+path}","compare_url":"https://api.github.com/repos/actionless/oomox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/actionless/oomox/merges","archive_url":"https://api.github.com/repos/actionless/oomox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/actionless/oomox/downloads","issues_url":"https://api.github.com/repos/actionless/oomox/issues{/number}","pulls_url":"https://api.github.com/repos/actionless/oomox/pulls{/number}","milestones_url":"https://api.github.com/repos/actionless/oomox/milestones{/number}","notifications_url":"https://api.github.com/repos/actionless/oomox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/actionless/oomox/labels{/name}","releases_url":"https://api.github.com/repos/actionless/oomox/releases{/id}","deployments_url":"https://api.github.com/repos/actionless/oomox/deployments","created_at":"2014-05-25T13:45:31Z","updated_at":"2017-02-24T13:51:04Z","pushed_at":"2017-02-24T17:20:19Z","git_url":"git://github.com/actionless/oomox.git","ssh_url":"git@github.com:actionless/oomox.git","clone_url":"https://github.com/actionless/oomox.git","svn_url":"https://github.com/actionless/oomox","homepage":"","size":8928,"stargazers_count":214,"watchers_count":214,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":14,"mirror_url":null,"open_issues_count":12,"forks":14,"open_issues":12,"watchers":214,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/actionless/oomox/pulls/68"},"html":{"href":"https://github.com/actionless/oomox/pull/68"},"issue":{"href":"https://api.github.com/repos/actionless/oomox/issues/68"},"comments":{"href":"https://api.github.com/repos/actionless/oomox/issues/68/comments"},"review_comments":{"href":"https://api.github.com/repos/actionless/oomox/pulls/68/comments"},"review_comment":{"href":"https://api.github.com/repos/actionless/oomox/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/actionless/oomox/pulls/68/commits"},"statuses":{"href":"https://api.github.com/repos/actionless/oomox/statuses/3526e7fc7281178b976a1a4982a34e70fd9d28a9"}}}}
{"actor":{"display_login":"actionless"}}