{"action":"closed","number":16,"pull_request":{"url":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server/pulls/16","id":130851319,"html_url":"https://github.com/SpiNNakerManchester/spalloc_server/pull/16","diff_url":"https://github.com/SpiNNakerManchester/spalloc_server/pull/16.diff","patch_url":"https://github.com/SpiNNakerManchester/spalloc_server/pull/16.patch","issue_url":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server/issues/16","number":16,"state":"closed","locked":false,"title":"Protocol change","user":{"login":"dkfellows","id":1155878,"avatar_url":"https://avatars0.githubusercontent.com/u/1155878?v=4","gravatar_id":"","url":"https://api.github.com/users/dkfellows","html_url":"https://github.com/dkfellows","followers_url":"https://api.github.com/users/dkfellows/followers","following_url":"https://api.github.com/users/dkfellows/following{/other_user}","gists_url":"https://api.github.com/users/dkfellows/gists{/gist_id}","starred_url":"https://api.github.com/users/dkfellows/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkfellows/subscriptions","organizations_url":"https://api.github.com/users/dkfellows/orgs","repos_url":"https://api.github.com/users/dkfellows/repos","events_url":"https://api.github.com/users/dkfellows/events{/privacy}","received_events_url":"https://api.github.com/users/dkfellows/received_events","type":"User","site_admin":false},"body":"This PR alters the Spalloc protocol so that higher-level exceptions (i.e., not message envelope decoding failures!) cause a new kind of response message:\r\n\r\n```javascript\r\n{\"exception\": \"the message describing the error that happened\"}\r\n```\r\n\r\n(This is in addition to the `call`, `return` and `notification` messages already sent.)\r\n\r\nThis means that most failures due to passing wrong arguments (as opposed to failures due to bogus network handling or message serialization, either of which would be a direct spalloc client failure) can be represented as exceptions to the callers of the client, making higher-level failures significantly easier to debug.","created_at":"2017-07-17T13:08:24Z","updated_at":"2017-07-24T10:34:11Z","closed_at":"2017-07-24T10:34:11Z","merged_at":"2017-07-24T10:34:11Z","merge_commit_sha":"124c87a19bf32ef923704816703e9d38972750cf","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server/pulls/16/commits","review_comments_url":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server/pulls/16/comments","review_comment_url":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server/issues/16/comments","statuses_url":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server/statuses/ce051dfb6329151b274d51e847fc48ba91f3d247","head":{"label":"SpiNNakerManchester:protocol-change","ref":"protocol-change","sha":"ce051dfb6329151b274d51e847fc48ba91f3d247","user":{"login":"SpiNNakerManchester","id":7584947,"avatar_url":"https://avatars3.githubusercontent.com/u/7584947?v=4","gravatar_id":"","url":"https://api.github.com/users/SpiNNakerManchester","html_url":"https://github.com/SpiNNakerManchester","followers_url":"https://api.github.com/users/SpiNNakerManchester/followers","following_url":"https://api.github.com/users/SpiNNakerManchester/following{/other_user}","gists_url":"https://api.github.com/users/SpiNNakerManchester/gists{/gist_id}","starred_url":"https://api.github.com/users/SpiNNakerManchester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpiNNakerManchester/subscriptions","organizations_url":"https://api.github.com/users/SpiNNakerManchester/orgs","repos_url":"https://api.github.com/users/SpiNNakerManchester/repos","events_url":"https://api.github.com/users/SpiNNakerManchester/events{/privacy}","received_events_url":"https://api.github.com/users/SpiNNakerManchester/received_events","type":"Organization","site_admin":false},"repo":{"id":51764640,"name":"spalloc_server","full_name":"SpiNNakerManchester/spalloc_server","owner":{"login":"SpiNNakerManchester","id":7584947,"avatar_url":"https://avatars3.githubusercontent.com/u/7584947?v=4","gravatar_id":"","url":"https://api.github.com/users/SpiNNakerManchester","html_url":"https://github.com/SpiNNakerManchester","followers_url":"https://api.github.com/users/SpiNNakerManchester/followers","following_url":"https://api.github.com/users/SpiNNakerManchester/following{/other_user}","gists_url":"https://api.github.com/users/SpiNNakerManchester/gists{/gist_id}","starred_url":"https://api.github.com/users/SpiNNakerManchester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpiNNakerManchester/subscriptions","organizations_url":"https://api.github.com/users/SpiNNakerManchester/orgs","repos_url":"https://api.github.com/users/SpiNNakerManchester/repos","events_url":"https://api.github.com/users/SpiNNakerManchester/events{/privacy}","received_events_url":"https://api.github.com/users/SpiNNakerManchester/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SpiNNakerManchester/spalloc_server","description":"A SpiNNaker machine allocation and partitioning application.","fork":false,"url":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server","forks_url":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server/forks","keys_url":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server/teams","hooks_url":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server/hooks","issue_events_url":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server/issues/events{/number}","events_url":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server/events","assignees_url":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server/assignees{/user}","branches_url":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server/branches{/branch}","tags_url":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server/tags","blobs_url":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server/git/refs{/sha}","trees_url":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server/statuses/{sha}","languages_url":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server/languages","stargazers_url":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server/stargazers","contributors_url":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server/contributors","subscribers_url":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server/subscribers","subscription_url":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server/subscription","commits_url":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server/commits{/sha}","git_commits_url":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server/git/commits{/sha}","comments_url":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server/comments{/number}","issue_comment_url":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server/issues/comments{/number}","contents_url":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server/contents/{+path}","compare_url":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server/merges","archive_url":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server/downloads","issues_url":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server/issues{/number}","pulls_url":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server/pulls{/number}","milestones_url":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server/milestones{/number}","notifications_url":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server/labels{/name}","releases_url":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server/releases{/id}","deployments_url":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server/deployments","created_at":"2016-02-15T15:26:21Z","updated_at":"2016-08-22T18:39:57Z","pushed_at":"2017-07-24T10:34:11Z","git_url":"git://github.com/SpiNNakerManchester/spalloc_server.git","ssh_url":"git@github.com:SpiNNakerManchester/spalloc_server.git","clone_url":"https://github.com/SpiNNakerManchester/spalloc_server.git","svn_url":"https://github.com/SpiNNakerManchester/spalloc_server","homepage":null,"size":391,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":3,"forks":2,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"SpiNNakerManchester:master","ref":"master","sha":"0d41015502e8d11abf3c879f14cbe933a8f183b9","user":{"login":"SpiNNakerManchester","id":7584947,"avatar_url":"https://avatars3.githubusercontent.com/u/7584947?v=4","gravatar_id":"","url":"https://api.github.com/users/SpiNNakerManchester","html_url":"https://github.com/SpiNNakerManchester","followers_url":"https://api.github.com/users/SpiNNakerManchester/followers","following_url":"https://api.github.com/users/SpiNNakerManchester/following{/other_user}","gists_url":"https://api.github.com/users/SpiNNakerManchester/gists{/gist_id}","starred_url":"https://api.github.com/users/SpiNNakerManchester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpiNNakerManchester/subscriptions","organizations_url":"https://api.github.com/users/SpiNNakerManchester/orgs","repos_url":"https://api.github.com/users/SpiNNakerManchester/repos","events_url":"https://api.github.com/users/SpiNNakerManchester/events{/privacy}","received_events_url":"https://api.github.com/users/SpiNNakerManchester/received_events","type":"Organization","site_admin":false},"repo":{"id":51764640,"name":"spalloc_server","full_name":"SpiNNakerManchester/spalloc_server","owner":{"login":"SpiNNakerManchester","id":7584947,"avatar_url":"https://avatars3.githubusercontent.com/u/7584947?v=4","gravatar_id":"","url":"https://api.github.com/users/SpiNNakerManchester","html_url":"https://github.com/SpiNNakerManchester","followers_url":"https://api.github.com/users/SpiNNakerManchester/followers","following_url":"https://api.github.com/users/SpiNNakerManchester/following{/other_user}","gists_url":"https://api.github.com/users/SpiNNakerManchester/gists{/gist_id}","starred_url":"https://api.github.com/users/SpiNNakerManchester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpiNNakerManchester/subscriptions","organizations_url":"https://api.github.com/users/SpiNNakerManchester/orgs","repos_url":"https://api.github.com/users/SpiNNakerManchester/repos","events_url":"https://api.github.com/users/SpiNNakerManchester/events{/privacy}","received_events_url":"https://api.github.com/users/SpiNNakerManchester/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SpiNNakerManchester/spalloc_server","description":"A SpiNNaker machine allocation and partitioning application.","fork":false,"url":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server","forks_url":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server/forks","keys_url":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server/teams","hooks_url":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server/hooks","issue_events_url":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server/issues/events{/number}","events_url":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server/events","assignees_url":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server/assignees{/user}","branches_url":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server/branches{/branch}","tags_url":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server/tags","blobs_url":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server/git/refs{/sha}","trees_url":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server/statuses/{sha}","languages_url":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server/languages","stargazers_url":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server/stargazers","contributors_url":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server/contributors","subscribers_url":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server/subscribers","subscription_url":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server/subscription","commits_url":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server/commits{/sha}","git_commits_url":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server/git/commits{/sha}","comments_url":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server/comments{/number}","issue_comment_url":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server/issues/comments{/number}","contents_url":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server/contents/{+path}","compare_url":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server/merges","archive_url":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server/downloads","issues_url":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server/issues{/number}","pulls_url":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server/pulls{/number}","milestones_url":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server/milestones{/number}","notifications_url":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server/labels{/name}","releases_url":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server/releases{/id}","deployments_url":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server/deployments","created_at":"2016-02-15T15:26:21Z","updated_at":"2016-08-22T18:39:57Z","pushed_at":"2017-07-24T10:34:11Z","git_url":"git://github.com/SpiNNakerManchester/spalloc_server.git","ssh_url":"git@github.com:SpiNNakerManchester/spalloc_server.git","clone_url":"https://github.com/SpiNNakerManchester/spalloc_server.git","svn_url":"https://github.com/SpiNNakerManchester/spalloc_server","homepage":null,"size":391,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":3,"forks":2,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server/pulls/16"},"html":{"href":"https://github.com/SpiNNakerManchester/spalloc_server/pull/16"},"issue":{"href":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server/issues/16"},"comments":{"href":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/SpiNNakerManchester/spalloc_server/statuses/ce051dfb6329151b274d51e847fc48ba91f3d247"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"rowleya","id":7584931,"avatar_url":"https://avatars3.githubusercontent.com/u/7584931?v=4","gravatar_id":"","url":"https://api.github.com/users/rowleya","html_url":"https://github.com/rowleya","followers_url":"https://api.github.com/users/rowleya/followers","following_url":"https://api.github.com/users/rowleya/following{/other_user}","gists_url":"https://api.github.com/users/rowleya/gists{/gist_id}","starred_url":"https://api.github.com/users/rowleya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rowleya/subscriptions","organizations_url":"https://api.github.com/users/rowleya/orgs","repos_url":"https://api.github.com/users/rowleya/repos","events_url":"https://api.github.com/users/rowleya/events{/privacy}","received_events_url":"https://api.github.com/users/rowleya/received_events","type":"User","site_admin":false},"comments":4,"review_comments":0,"maintainer_can_modify":false,"commits":11,"additions":44,"deletions":18,"changed_files":5}}
{"actor":{"display_login":"rowleya"}}