{"action":"closed","number":25851,"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/25851","id":120987158,"html_url":"https://github.com/NixOS/nixpkgs/pull/25851","diff_url":"https://github.com/NixOS/nixpkgs/pull/25851.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/25851.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/25851","number":25851,"state":"closed","locked":false,"title":"nbstripout: fix build on darwin","user":{"login":"jluttine","id":2195834,"avatar_url":"https://avatars1.githubusercontent.com/u/2195834?v=3","gravatar_id":"","url":"https://api.github.com/users/jluttine","html_url":"https://github.com/jluttine","followers_url":"https://api.github.com/users/jluttine/followers","following_url":"https://api.github.com/users/jluttine/following{/other_user}","gists_url":"https://api.github.com/users/jluttine/gists{/gist_id}","starred_url":"https://api.github.com/users/jluttine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jluttine/subscriptions","organizations_url":"https://api.github.com/users/jluttine/orgs","repos_url":"https://api.github.com/users/jluttine/repos","events_url":"https://api.github.com/users/jluttine/events{/privacy}","received_events_url":"https://api.github.com/users/jluttine/received_events","type":"User","site_admin":false},"body":"###### Motivation for this change\r\n\r\nBuild fails on darwin because, for some reason, `echo -n` isn't handled properly: https://hydra.nixos.org/build/52896770/nixlog/14\r\n\r\nI patched the failing test on darwin to use `\\c` at the end of the string instead of `-n` flag.\r\n\r\n###### Things done\r\n\r\n- [x] Tested using sandboxing\r\n  ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS,\r\n    or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file)\r\n    on non-NixOS)\r\n- Built on platform(s)\r\n   - [x] NixOS\r\n   - [ ] macOS\r\n   - [ ] Linux\r\n- [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [x] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n","created_at":"2017-05-17T07:03:40Z","updated_at":"2017-05-17T10:41:53Z","closed_at":"2017-05-17T10:41:53Z","merged_at":"2017-05-17T10:41:53Z","merge_commit_sha":"4d9ebd3c23773aa6130440fa78be682cdc15c4c1","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/25851/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/25851/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/25851/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/4a9acbb79a6035333cc069b6ef1643c92c6518eb","head":{"label":"jluttine:fix-nbstripout-on-darwin","ref":"fix-nbstripout-on-darwin","sha":"4a9acbb79a6035333cc069b6ef1643c92c6518eb","user":{"login":"jluttine","id":2195834,"avatar_url":"https://avatars1.githubusercontent.com/u/2195834?v=3","gravatar_id":"","url":"https://api.github.com/users/jluttine","html_url":"https://github.com/jluttine","followers_url":"https://api.github.com/users/jluttine/followers","following_url":"https://api.github.com/users/jluttine/following{/other_user}","gists_url":"https://api.github.com/users/jluttine/gists{/gist_id}","starred_url":"https://api.github.com/users/jluttine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jluttine/subscriptions","organizations_url":"https://api.github.com/users/jluttine/orgs","repos_url":"https://api.github.com/users/jluttine/repos","events_url":"https://api.github.com/users/jluttine/events{/privacy}","received_events_url":"https://api.github.com/users/jluttine/received_events","type":"User","site_admin":false},"repo":{"id":71211679,"name":"nixpkgs","full_name":"jluttine/nixpkgs","owner":{"login":"jluttine","id":2195834,"avatar_url":"https://avatars1.githubusercontent.com/u/2195834?v=3","gravatar_id":"","url":"https://api.github.com/users/jluttine","html_url":"https://github.com/jluttine","followers_url":"https://api.github.com/users/jluttine/followers","following_url":"https://api.github.com/users/jluttine/following{/other_user}","gists_url":"https://api.github.com/users/jluttine/gists{/gist_id}","starred_url":"https://api.github.com/users/jluttine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jluttine/subscriptions","organizations_url":"https://api.github.com/users/jluttine/orgs","repos_url":"https://api.github.com/users/jluttine/repos","events_url":"https://api.github.com/users/jluttine/events{/privacy}","received_events_url":"https://api.github.com/users/jluttine/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jluttine/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/jluttine/nixpkgs","forks_url":"https://api.github.com/repos/jluttine/nixpkgs/forks","keys_url":"https://api.github.com/repos/jluttine/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jluttine/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jluttine/nixpkgs/teams","hooks_url":"https://api.github.com/repos/jluttine/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/jluttine/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/jluttine/nixpkgs/events","assignees_url":"https://api.github.com/repos/jluttine/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/jluttine/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/jluttine/nixpkgs/tags","blobs_url":"https://api.github.com/repos/jluttine/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jluttine/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jluttine/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/jluttine/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jluttine/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/jluttine/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/jluttine/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/jluttine/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/jluttine/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/jluttine/nixpkgs/subscription","commits_url":"https://api.github.com/repos/jluttine/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/jluttine/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/jluttine/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/jluttine/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/jluttine/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/jluttine/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jluttine/nixpkgs/merges","archive_url":"https://api.github.com/repos/jluttine/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jluttine/nixpkgs/downloads","issues_url":"https://api.github.com/repos/jluttine/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/jluttine/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/jluttine/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/jluttine/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jluttine/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/jluttine/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/jluttine/nixpkgs/deployments","created_at":"2016-10-18T05:20:44Z","updated_at":"2016-10-18T05:21:07Z","pushed_at":"2017-05-17T08:07:11Z","git_url":"git://github.com/jluttine/nixpkgs.git","ssh_url":"git@github.com:jluttine/nixpkgs.git","clone_url":"https://github.com/jluttine/nixpkgs.git","svn_url":"https://github.com/jluttine/nixpkgs","homepage":null,"size":455701,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"fb19aac85d9e630f3a8cd12621ff138f6a66da31","user":{"login":"NixOS","id":487568,"avatar_url":"https://avatars0.githubusercontent.com/u/487568?v=3","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"name":"nixpkgs","full_name":"NixOS/nixpkgs","owner":{"login":"NixOS","id":487568,"avatar_url":"https://avatars0.githubusercontent.com/u/487568?v=3","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2017-05-17T08:40:12Z","pushed_at":"2017-05-17T10:41:53Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":469579,"stargazers_count":1686,"watchers_count":1686,"language":"Nix","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2043,"mirror_url":null,"open_issues_count":2014,"forks":2043,"open_issues":2014,"watchers":1686,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/25851"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/25851"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/25851"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/25851/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/25851/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/25851/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/4a9acbb79a6035333cc069b6ef1643c92c6518eb"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"FRidh","id":2129135,"avatar_url":"https://avatars0.githubusercontent.com/u/2129135?v=3","gravatar_id":"","url":"https://api.github.com/users/FRidh","html_url":"https://github.com/FRidh","followers_url":"https://api.github.com/users/FRidh/followers","following_url":"https://api.github.com/users/FRidh/following{/other_user}","gists_url":"https://api.github.com/users/FRidh/gists{/gist_id}","starred_url":"https://api.github.com/users/FRidh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FRidh/subscriptions","organizations_url":"https://api.github.com/users/FRidh/orgs","repos_url":"https://api.github.com/users/FRidh/repos","events_url":"https://api.github.com/users/FRidh/events{/privacy}","received_events_url":"https://api.github.com/users/FRidh/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":7,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"FRidh"}}