{"action":"created","comment":{"url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/pulls/comments/141921396","pull_request_review_id":66216196,"id":141921396,"diff_hunk":"@@ -145,52 +145,27 @@ protected WebServiceRequestBase(Uri uri)\n \t\t/// <summary>\n \t\t/// Gets the response.\n \t\t/// </summary>\n-\t\t/// <returns>Makes a web request, blocking until the request has returned a response.</returns>\n-\t\tpublic TResponse GetResponse()\n-\t\t{\n-\t\t\treturn GetResponse(WorkState.None);\n-\t\t}\n-\n-\t\t/// <summary>\n-\t\t/// Gets the response.\n-\t\t/// </summary>\n-\t\t/// <param name=\"workState\">The work state.</param>\n+\t\t/// <param name=\"cancellationToken\">The token to monitor for cancellation requests.</param>\n \t\t/// <returns>Makes a web request, blocking until the request has returned a response. Returns default(TResponse) if cancelled.</returns>\n-\t\tpublic TResponse GetResponse(IWorkState workState)\n+\t\tpublic TResponse GetResponse(CancellationToken cancellationToken = default(CancellationToken))","path":"src/Faithlife.WebRequests/WebServiceRequestBase.cs","position":17,"original_position":17,"commit_id":"b792c6aea0a8b778cdf844e25a8c3ba07db2024e","original_commit_id":"b792c6aea0a8b778cdf844e25a8c3ba07db2024e","user":{"login":"ejball","id":197797,"avatar_url":"https://avatars1.githubusercontent.com/u/197797?v=4","gravatar_id":"","url":"https://api.github.com/users/ejball","html_url":"https://github.com/ejball","followers_url":"https://api.github.com/users/ejball/followers","following_url":"https://api.github.com/users/ejball/following{/other_user}","gists_url":"https://api.github.com/users/ejball/gists{/gist_id}","starred_url":"https://api.github.com/users/ejball/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ejball/subscriptions","organizations_url":"https://api.github.com/users/ejball/orgs","repos_url":"https://api.github.com/users/ejball/repos","events_url":"https://api.github.com/users/ejball/events{/privacy}","received_events_url":"https://api.github.com/users/ejball/received_events","type":"User","site_admin":false},"body":"Supporting cancellation on sync methods is highly unusual. If we must keep the sync method, we should drop the cancellation token; clients that need both that block on the async method themselves.","created_at":"2017-09-29T17:19:59Z","updated_at":"2017-09-29T17:19:59Z","html_url":"https://github.com/Faithlife/FaithlifeWebRequests/pull/1#discussion_r141921396","pull_request_url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/pulls/1","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/pulls/comments/141921396"},"html":{"href":"https://github.com/Faithlife/FaithlifeWebRequests/pull/1#discussion_r141921396"},"pull_request":{"href":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/pulls/1","id":143932940,"html_url":"https://github.com/Faithlife/FaithlifeWebRequests/pull/1","diff_url":"https://github.com/Faithlife/FaithlifeWebRequests/pull/1.diff","patch_url":"https://github.com/Faithlife/FaithlifeWebRequests/pull/1.patch","issue_url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/issues/1","number":1,"state":"open","locked":false,"title":"Change from IWorkState to CancellationToken.","user":{"login":"ddunkin","id":264744,"avatar_url":"https://avatars2.githubusercontent.com/u/264744?v=4","gravatar_id":"","url":"https://api.github.com/users/ddunkin","html_url":"https://github.com/ddunkin","followers_url":"https://api.github.com/users/ddunkin/followers","following_url":"https://api.github.com/users/ddunkin/following{/other_user}","gists_url":"https://api.github.com/users/ddunkin/gists{/gist_id}","starred_url":"https://api.github.com/users/ddunkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddunkin/subscriptions","organizations_url":"https://api.github.com/users/ddunkin/orgs","repos_url":"https://api.github.com/users/ddunkin/repos","events_url":"https://api.github.com/users/ddunkin/events{/privacy}","received_events_url":"https://api.github.com/users/ddunkin/received_events","type":"User","site_admin":false},"body":"`IWorkState` will be removed by Faithlife/FaithlifeUtility#7.","created_at":"2017-09-29T16:51:12Z","updated_at":"2017-09-29T17:19:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"69a3ed81a69112cd7cc89993696313cf4d1f8ee9","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/pulls/1/commits","review_comments_url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/pulls/1/comments","review_comment_url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/issues/1/comments","statuses_url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/statuses/b792c6aea0a8b778cdf844e25a8c3ba07db2024e","head":{"label":"ddunkin:cancellation-token","ref":"cancellation-token","sha":"b792c6aea0a8b778cdf844e25a8c3ba07db2024e","user":{"login":"ddunkin","id":264744,"avatar_url":"https://avatars2.githubusercontent.com/u/264744?v=4","gravatar_id":"","url":"https://api.github.com/users/ddunkin","html_url":"https://github.com/ddunkin","followers_url":"https://api.github.com/users/ddunkin/followers","following_url":"https://api.github.com/users/ddunkin/following{/other_user}","gists_url":"https://api.github.com/users/ddunkin/gists{/gist_id}","starred_url":"https://api.github.com/users/ddunkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddunkin/subscriptions","organizations_url":"https://api.github.com/users/ddunkin/orgs","repos_url":"https://api.github.com/users/ddunkin/repos","events_url":"https://api.github.com/users/ddunkin/events{/privacy}","received_events_url":"https://api.github.com/users/ddunkin/received_events","type":"User","site_admin":false},"repo":{"id":105295930,"name":"FaithlifeWebRequests","full_name":"ddunkin/FaithlifeWebRequests","owner":{"login":"ddunkin","id":264744,"avatar_url":"https://avatars2.githubusercontent.com/u/264744?v=4","gravatar_id":"","url":"https://api.github.com/users/ddunkin","html_url":"https://github.com/ddunkin","followers_url":"https://api.github.com/users/ddunkin/followers","following_url":"https://api.github.com/users/ddunkin/following{/other_user}","gists_url":"https://api.github.com/users/ddunkin/gists{/gist_id}","starred_url":"https://api.github.com/users/ddunkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddunkin/subscriptions","organizations_url":"https://api.github.com/users/ddunkin/orgs","repos_url":"https://api.github.com/users/ddunkin/repos","events_url":"https://api.github.com/users/ddunkin/events{/privacy}","received_events_url":"https://api.github.com/users/ddunkin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ddunkin/FaithlifeWebRequests","description":"Client code for making strongly-typed web service requests","fork":true,"url":"https://api.github.com/repos/ddunkin/FaithlifeWebRequests","forks_url":"https://api.github.com/repos/ddunkin/FaithlifeWebRequests/forks","keys_url":"https://api.github.com/repos/ddunkin/FaithlifeWebRequests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ddunkin/FaithlifeWebRequests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ddunkin/FaithlifeWebRequests/teams","hooks_url":"https://api.github.com/repos/ddunkin/FaithlifeWebRequests/hooks","issue_events_url":"https://api.github.com/repos/ddunkin/FaithlifeWebRequests/issues/events{/number}","events_url":"https://api.github.com/repos/ddunkin/FaithlifeWebRequests/events","assignees_url":"https://api.github.com/repos/ddunkin/FaithlifeWebRequests/assignees{/user}","branches_url":"https://api.github.com/repos/ddunkin/FaithlifeWebRequests/branches{/branch}","tags_url":"https://api.github.com/repos/ddunkin/FaithlifeWebRequests/tags","blobs_url":"https://api.github.com/repos/ddunkin/FaithlifeWebRequests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ddunkin/FaithlifeWebRequests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ddunkin/FaithlifeWebRequests/git/refs{/sha}","trees_url":"https://api.github.com/repos/ddunkin/FaithlifeWebRequests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ddunkin/FaithlifeWebRequests/statuses/{sha}","languages_url":"https://api.github.com/repos/ddunkin/FaithlifeWebRequests/languages","stargazers_url":"https://api.github.com/repos/ddunkin/FaithlifeWebRequests/stargazers","contributors_url":"https://api.github.com/repos/ddunkin/FaithlifeWebRequests/contributors","subscribers_url":"https://api.github.com/repos/ddunkin/FaithlifeWebRequests/subscribers","subscription_url":"https://api.github.com/repos/ddunkin/FaithlifeWebRequests/subscription","commits_url":"https://api.github.com/repos/ddunkin/FaithlifeWebRequests/commits{/sha}","git_commits_url":"https://api.github.com/repos/ddunkin/FaithlifeWebRequests/git/commits{/sha}","comments_url":"https://api.github.com/repos/ddunkin/FaithlifeWebRequests/comments{/number}","issue_comment_url":"https://api.github.com/repos/ddunkin/FaithlifeWebRequests/issues/comments{/number}","contents_url":"https://api.github.com/repos/ddunkin/FaithlifeWebRequests/contents/{+path}","compare_url":"https://api.github.com/repos/ddunkin/FaithlifeWebRequests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ddunkin/FaithlifeWebRequests/merges","archive_url":"https://api.github.com/repos/ddunkin/FaithlifeWebRequests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ddunkin/FaithlifeWebRequests/downloads","issues_url":"https://api.github.com/repos/ddunkin/FaithlifeWebRequests/issues{/number}","pulls_url":"https://api.github.com/repos/ddunkin/FaithlifeWebRequests/pulls{/number}","milestones_url":"https://api.github.com/repos/ddunkin/FaithlifeWebRequests/milestones{/number}","notifications_url":"https://api.github.com/repos/ddunkin/FaithlifeWebRequests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ddunkin/FaithlifeWebRequests/labels{/name}","releases_url":"https://api.github.com/repos/ddunkin/FaithlifeWebRequests/releases{/id}","deployments_url":"https://api.github.com/repos/ddunkin/FaithlifeWebRequests/deployments","created_at":"2017-09-29T16:48:30Z","updated_at":"2017-09-29T16:48:32Z","pushed_at":"2017-09-29T17:03:58Z","git_url":"git://github.com/ddunkin/FaithlifeWebRequests.git","ssh_url":"git@github.com:ddunkin/FaithlifeWebRequests.git","clone_url":"https://github.com/ddunkin/FaithlifeWebRequests.git","svn_url":"https://github.com/ddunkin/FaithlifeWebRequests","homepage":null,"size":106,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Faithlife:master","ref":"master","sha":"a355346d68cd42909d11496e28d1fcda006911c2","user":{"login":"Faithlife","id":7575190,"avatar_url":"https://avatars1.githubusercontent.com/u/7575190?v=4","gravatar_id":"","url":"https://api.github.com/users/Faithlife","html_url":"https://github.com/Faithlife","followers_url":"https://api.github.com/users/Faithlife/followers","following_url":"https://api.github.com/users/Faithlife/following{/other_user}","gists_url":"https://api.github.com/users/Faithlife/gists{/gist_id}","starred_url":"https://api.github.com/users/Faithlife/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Faithlife/subscriptions","organizations_url":"https://api.github.com/users/Faithlife/orgs","repos_url":"https://api.github.com/users/Faithlife/repos","events_url":"https://api.github.com/users/Faithlife/events{/privacy}","received_events_url":"https://api.github.com/users/Faithlife/received_events","type":"Organization","site_admin":false},"repo":{"id":102504986,"name":"FaithlifeWebRequests","full_name":"Faithlife/FaithlifeWebRequests","owner":{"login":"Faithlife","id":7575190,"avatar_url":"https://avatars1.githubusercontent.com/u/7575190?v=4","gravatar_id":"","url":"https://api.github.com/users/Faithlife","html_url":"https://github.com/Faithlife","followers_url":"https://api.github.com/users/Faithlife/followers","following_url":"https://api.github.com/users/Faithlife/following{/other_user}","gists_url":"https://api.github.com/users/Faithlife/gists{/gist_id}","starred_url":"https://api.github.com/users/Faithlife/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Faithlife/subscriptions","organizations_url":"https://api.github.com/users/Faithlife/orgs","repos_url":"https://api.github.com/users/Faithlife/repos","events_url":"https://api.github.com/users/Faithlife/events{/privacy}","received_events_url":"https://api.github.com/users/Faithlife/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Faithlife/FaithlifeWebRequests","description":"Client code for making strongly-typed web service requests","fork":false,"url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests","forks_url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/forks","keys_url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/teams","hooks_url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/hooks","issue_events_url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/issues/events{/number}","events_url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/events","assignees_url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/assignees{/user}","branches_url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/branches{/branch}","tags_url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/tags","blobs_url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/git/refs{/sha}","trees_url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/statuses/{sha}","languages_url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/languages","stargazers_url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/stargazers","contributors_url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/contributors","subscribers_url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/subscribers","subscription_url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/subscription","commits_url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/commits{/sha}","git_commits_url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/git/commits{/sha}","comments_url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/comments{/number}","issue_comment_url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/issues/comments{/number}","contents_url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/contents/{+path}","compare_url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/merges","archive_url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/downloads","issues_url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/issues{/number}","pulls_url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/pulls{/number}","milestones_url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/milestones{/number}","notifications_url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/labels{/name}","releases_url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/releases{/id}","deployments_url":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/deployments","created_at":"2017-09-05T16:28:43Z","updated_at":"2017-09-05T17:06:01Z","pushed_at":"2017-09-29T17:03:59Z","git_url":"git://github.com/Faithlife/FaithlifeWebRequests.git","ssh_url":"git@github.com:Faithlife/FaithlifeWebRequests.git","clone_url":"https://github.com/Faithlife/FaithlifeWebRequests.git","svn_url":"https://github.com/Faithlife/FaithlifeWebRequests","homepage":null,"size":106,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/pulls/1"},"html":{"href":"https://github.com/Faithlife/FaithlifeWebRequests/pull/1"},"issue":{"href":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/issues/1"},"comments":{"href":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/Faithlife/FaithlifeWebRequests/statuses/b792c6aea0a8b778cdf844e25a8c3ba07db2024e"}},"author_association":"OWNER"}}
{"actor":{"display_login":"ejball"}}