{"action":"created","issue":{"url":"https://api.github.com/repos/apache/flink/issues/5094","repository_url":"https://api.github.com/repos/apache/flink","labels_url":"https://api.github.com/repos/apache/flink/issues/5094/labels{/name}","comments_url":"https://api.github.com/repos/apache/flink/issues/5094/comments","events_url":"https://api.github.com/repos/apache/flink/issues/5094/events","html_url":"https://github.com/apache/flink/pull/5094","id":277364774,"number":5094,"title":"[FLINK-8158] [table] Fix rowtime window inner join emits late data bug","user":{"login":"hequn8128","id":4971479,"avatar_url":"https://avatars2.githubusercontent.com/u/4971479?v=4","gravatar_id":"","url":"https://api.github.com/users/hequn8128","html_url":"https://github.com/hequn8128","followers_url":"https://api.github.com/users/hequn8128/followers","following_url":"https://api.github.com/users/hequn8128/following{/other_user}","gists_url":"https://api.github.com/users/hequn8128/gists{/gist_id}","starred_url":"https://api.github.com/users/hequn8128/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hequn8128/subscriptions","organizations_url":"https://api.github.com/users/hequn8128/orgs","repos_url":"https://api.github.com/users/hequn8128/repos","events_url":"https://api.github.com/users/hequn8128/events{/privacy}","received_events_url":"https://api.github.com/users/hequn8128/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2017-11-28T12:20:44Z","updated_at":"2017-11-30T16:03:49Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/apache/flink/pulls/5094","html_url":"https://github.com/apache/flink/pull/5094","diff_url":"https://github.com/apache/flink/pull/5094.diff","patch_url":"https://github.com/apache/flink/pull/5094.patch"},"body":"\r\n## What is the purpose of the change\r\n\r\nThis pull request fixes rowtime window inner join emits late data bug. When executing the join, the join operator needs to make sure that no late data is emitted. However, the window border is not handled correctly.\r\n\r\n\r\n## Brief change log\r\n\r\n  - Set `WatermarkDelay` to `MaxOutputDelay + 1` instead of `MaxOutputDelay`\r\n  - Add tests in `JoinHarnessTest`\r\n\r\n\r\n## Verifying this change\r\n\r\nThis change added tests and can be verified as follows:\r\n\r\n  - *Added tests in `JoinHarnessTest` to check if late data is outputted*\r\n\r\n## Does this pull request potentially affect one of the following parts:\r\n\r\n  - Dependencies (does it add or upgrade a dependency): (no)\r\n  - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)\r\n  - The serializers: (no)\r\n  - The runtime per-record code paths (performance sensitive): (no)\r\n  - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)\r\n  - The S3 file system connector: (no)\r\n\r\n## Documentation\r\n\r\n  - Does this pull request introduce a new feature? (no)\r\n"},"comment":{"url":"https://api.github.com/repos/apache/flink/issues/comments/348233863","html_url":"https://github.com/apache/flink/pull/5094#issuecomment-348233863","issue_url":"https://api.github.com/repos/apache/flink/issues/5094","id":348233863,"user":{"login":"hequn8128","id":4971479,"avatar_url":"https://avatars2.githubusercontent.com/u/4971479?v=4","gravatar_id":"","url":"https://api.github.com/users/hequn8128","html_url":"https://github.com/hequn8128","followers_url":"https://api.github.com/users/hequn8128/followers","following_url":"https://api.github.com/users/hequn8128/following{/other_user}","gists_url":"https://api.github.com/users/hequn8128/gists{/gist_id}","starred_url":"https://api.github.com/users/hequn8128/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hequn8128/subscriptions","organizations_url":"https://api.github.com/users/hequn8128/orgs","repos_url":"https://api.github.com/users/hequn8128/repos","events_url":"https://api.github.com/users/hequn8128/events{/privacy}","received_events_url":"https://api.github.com/users/hequn8128/received_events","type":"User","site_admin":false},"created_at":"2017-11-30T16:03:49Z","updated_at":"2017-11-30T16:03:49Z","author_association":"CONTRIBUTOR","body":"Ooooops... finally understand what you mean. Thank your very much for your explain. @fhueske @xccui . I will close this pr :)"}}
{"actor":{"display_login":"hequn8128"}}