{"action":"created","comment":{"url":"https://api.github.com/repos/bedita/bedita/pulls/comments/152750518","pull_request_review_id":78657828,"id":152750518,"diff_hunk":"@@ -26,14 +26,26 @@\n  */\n class SchemaController extends AppController\n {\n+    /**\n+     * JSON Schema content type.\n+     *\n+     * @var string\n+     */\n+    const CONTENT_TYPE = 'application/schema+json';\n+\n     /**\n      * {@inheritDoc}\n      */\n     public function initialize()\n     {\n         parent::initialize();\n-        $this->components()->unload('JsonApi');\n-        $this->viewBuilder()->setClassName('Json');\n+        if ($this->components()->get('JsonApi')) {","path":"plugins/BEdita/API/src/Controller/Model/SchemaController.php","position":19,"original_position":19,"commit_id":"128981534193332d8b07aec4cbec29da075e4483","original_commit_id":"128981534193332d8b07aec4cbec29da075e4483","user":{"login":"fquffio","id":7108146,"avatar_url":"https://avatars1.githubusercontent.com/u/7108146?v=4","gravatar_id":"","url":"https://api.github.com/users/fquffio","html_url":"https://github.com/fquffio","followers_url":"https://api.github.com/users/fquffio/followers","following_url":"https://api.github.com/users/fquffio/following{/other_user}","gists_url":"https://api.github.com/users/fquffio/gists{/gist_id}","starred_url":"https://api.github.com/users/fquffio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fquffio/subscriptions","organizations_url":"https://api.github.com/users/fquffio/orgs","repos_url":"https://api.github.com/users/fquffio/repos","events_url":"https://api.github.com/users/fquffio/events{/privacy}","received_events_url":"https://api.github.com/users/fquffio/received_events","type":"User","site_admin":false},"body":"`$this->components()->has('JsonApi')` would be fine in this case.","created_at":"2017-11-23T09:20:27Z","updated_at":"2017-11-23T09:20:27Z","html_url":"https://github.com/bedita/bedita/pull/1390#discussion_r152750518","pull_request_url":"https://api.github.com/repos/bedita/bedita/pulls/1390","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/bedita/bedita/pulls/comments/152750518"},"html":{"href":"https://github.com/bedita/bedita/pull/1390#discussion_r152750518"},"pull_request":{"href":"https://api.github.com/repos/bedita/bedita/pulls/1390"}}},"pull_request":{"url":"https://api.github.com/repos/bedita/bedita/pulls/1390","id":154128014,"html_url":"https://github.com/bedita/bedita/pull/1390","diff_url":"https://github.com/bedita/bedita/pull/1390.diff","patch_url":"https://github.com/bedita/bedita/pull/1390.patch","issue_url":"https://api.github.com/repos/bedita/bedita/issues/1390","number":1390,"state":"open","locked":false,"title":"Use `application/schema+json` content type","user":{"login":"stefanorosanelli","id":2122280,"avatar_url":"https://avatars3.githubusercontent.com/u/2122280?v=4","gravatar_id":"","url":"https://api.github.com/users/stefanorosanelli","html_url":"https://github.com/stefanorosanelli","followers_url":"https://api.github.com/users/stefanorosanelli/followers","following_url":"https://api.github.com/users/stefanorosanelli/following{/other_user}","gists_url":"https://api.github.com/users/stefanorosanelli/gists{/gist_id}","starred_url":"https://api.github.com/users/stefanorosanelli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefanorosanelli/subscriptions","organizations_url":"https://api.github.com/users/stefanorosanelli/orgs","repos_url":"https://api.github.com/users/stefanorosanelli/repos","events_url":"https://api.github.com/users/stefanorosanelli/events{/privacy}","received_events_url":"https://api.github.com/users/stefanorosanelli/received_events","type":"User","site_admin":false},"body":"This PR introduces the expected content type `application/schema+json`  for `JSON Schema` on `/model/schema` endpoint\r\n\r\nThere is still no content type negotiation check on `Accept` headers (all types are accepted), but use of `Accept: application/schema+json` is recommended.\r\n\r\nTests on content type have been added.\r\n\r\n","created_at":"2017-11-22T11:27:00Z","updated_at":"2017-11-23T09:20:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"22f1a37e1022916b027e11c08b6ecee64c7087bb","assignee":{"login":"fquffio","id":7108146,"avatar_url":"https://avatars1.githubusercontent.com/u/7108146?v=4","gravatar_id":"","url":"https://api.github.com/users/fquffio","html_url":"https://github.com/fquffio","followers_url":"https://api.github.com/users/fquffio/followers","following_url":"https://api.github.com/users/fquffio/following{/other_user}","gists_url":"https://api.github.com/users/fquffio/gists{/gist_id}","starred_url":"https://api.github.com/users/fquffio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fquffio/subscriptions","organizations_url":"https://api.github.com/users/fquffio/orgs","repos_url":"https://api.github.com/users/fquffio/repos","events_url":"https://api.github.com/users/fquffio/events{/privacy}","received_events_url":"https://api.github.com/users/fquffio/received_events","type":"User","site_admin":false},"assignees":[{"login":"fquffio","id":7108146,"avatar_url":"https://avatars1.githubusercontent.com/u/7108146?v=4","gravatar_id":"","url":"https://api.github.com/users/fquffio","html_url":"https://github.com/fquffio","followers_url":"https://api.github.com/users/fquffio/followers","following_url":"https://api.github.com/users/fquffio/following{/other_user}","gists_url":"https://api.github.com/users/fquffio/gists{/gist_id}","starred_url":"https://api.github.com/users/fquffio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fquffio/subscriptions","organizations_url":"https://api.github.com/users/fquffio/orgs","repos_url":"https://api.github.com/users/fquffio/repos","events_url":"https://api.github.com/users/fquffio/events{/privacy}","received_events_url":"https://api.github.com/users/fquffio/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/bedita/bedita/milestones/17","html_url":"https://github.com/bedita/bedita/milestone/17","labels_url":"https://api.github.com/repos/bedita/bedita/milestones/17/labels","id":2759949,"number":17,"title":"4.0.0-beta","description":"","creator":{"login":"batopa","id":1306319,"avatar_url":"https://avatars2.githubusercontent.com/u/1306319?v=4","gravatar_id":"","url":"https://api.github.com/users/batopa","html_url":"https://github.com/batopa","followers_url":"https://api.github.com/users/batopa/followers","following_url":"https://api.github.com/users/batopa/following{/other_user}","gists_url":"https://api.github.com/users/batopa/gists{/gist_id}","starred_url":"https://api.github.com/users/batopa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/batopa/subscriptions","organizations_url":"https://api.github.com/users/batopa/orgs","repos_url":"https://api.github.com/users/batopa/repos","events_url":"https://api.github.com/users/batopa/events{/privacy}","received_events_url":"https://api.github.com/users/batopa/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":31,"state":"open","created_at":"2017-09-12T12:16:34Z","updated_at":"2017-11-22T11:27:00Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/bedita/bedita/pulls/1390/commits","review_comments_url":"https://api.github.com/repos/bedita/bedita/pulls/1390/comments","review_comment_url":"https://api.github.com/repos/bedita/bedita/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bedita/bedita/issues/1390/comments","statuses_url":"https://api.github.com/repos/bedita/bedita/statuses/128981534193332d8b07aec4cbec29da075e4483","head":{"label":"bedita:fix/v4/jsonschema-content-type","ref":"fix/v4/jsonschema-content-type","sha":"128981534193332d8b07aec4cbec29da075e4483","user":{"login":"bedita","id":2121737,"avatar_url":"https://avatars0.githubusercontent.com/u/2121737?v=4","gravatar_id":"","url":"https://api.github.com/users/bedita","html_url":"https://github.com/bedita","followers_url":"https://api.github.com/users/bedita/followers","following_url":"https://api.github.com/users/bedita/following{/other_user}","gists_url":"https://api.github.com/users/bedita/gists{/gist_id}","starred_url":"https://api.github.com/users/bedita/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bedita/subscriptions","organizations_url":"https://api.github.com/users/bedita/orgs","repos_url":"https://api.github.com/users/bedita/repos","events_url":"https://api.github.com/users/bedita/events{/privacy}","received_events_url":"https://api.github.com/users/bedita/received_events","type":"Organization","site_admin":false},"repo":{"id":5352389,"name":"bedita","full_name":"bedita/bedita","owner":{"login":"bedita","id":2121737,"avatar_url":"https://avatars0.githubusercontent.com/u/2121737?v=4","gravatar_id":"","url":"https://api.github.com/users/bedita","html_url":"https://github.com/bedita","followers_url":"https://api.github.com/users/bedita/followers","following_url":"https://api.github.com/users/bedita/following{/other_user}","gists_url":"https://api.github.com/users/bedita/gists{/gist_id}","starred_url":"https://api.github.com/users/bedita/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bedita/subscriptions","organizations_url":"https://api.github.com/users/bedita/orgs","repos_url":"https://api.github.com/users/bedita/repos","events_url":"https://api.github.com/users/bedita/events{/privacy}","received_events_url":"https://api.github.com/users/bedita/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bedita/bedita","description":"BEdita, ready to use back-end API, extensible API-first Content Management","fork":false,"url":"https://api.github.com/repos/bedita/bedita","forks_url":"https://api.github.com/repos/bedita/bedita/forks","keys_url":"https://api.github.com/repos/bedita/bedita/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bedita/bedita/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bedita/bedita/teams","hooks_url":"https://api.github.com/repos/bedita/bedita/hooks","issue_events_url":"https://api.github.com/repos/bedita/bedita/issues/events{/number}","events_url":"https://api.github.com/repos/bedita/bedita/events","assignees_url":"https://api.github.com/repos/bedita/bedita/assignees{/user}","branches_url":"https://api.github.com/repos/bedita/bedita/branches{/branch}","tags_url":"https://api.github.com/repos/bedita/bedita/tags","blobs_url":"https://api.github.com/repos/bedita/bedita/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bedita/bedita/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bedita/bedita/git/refs{/sha}","trees_url":"https://api.github.com/repos/bedita/bedita/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bedita/bedita/statuses/{sha}","languages_url":"https://api.github.com/repos/bedita/bedita/languages","stargazers_url":"https://api.github.com/repos/bedita/bedita/stargazers","contributors_url":"https://api.github.com/repos/bedita/bedita/contributors","subscribers_url":"https://api.github.com/repos/bedita/bedita/subscribers","subscription_url":"https://api.github.com/repos/bedita/bedita/subscription","commits_url":"https://api.github.com/repos/bedita/bedita/commits{/sha}","git_commits_url":"https://api.github.com/repos/bedita/bedita/git/commits{/sha}","comments_url":"https://api.github.com/repos/bedita/bedita/comments{/number}","issue_comment_url":"https://api.github.com/repos/bedita/bedita/issues/comments{/number}","contents_url":"https://api.github.com/repos/bedita/bedita/contents/{+path}","compare_url":"https://api.github.com/repos/bedita/bedita/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bedita/bedita/merges","archive_url":"https://api.github.com/repos/bedita/bedita/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bedita/bedita/downloads","issues_url":"https://api.github.com/repos/bedita/bedita/issues{/number}","pulls_url":"https://api.github.com/repos/bedita/bedita/pulls{/number}","milestones_url":"https://api.github.com/repos/bedita/bedita/milestones{/number}","notifications_url":"https://api.github.com/repos/bedita/bedita/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bedita/bedita/labels{/name}","releases_url":"https://api.github.com/repos/bedita/bedita/releases{/id}","deployments_url":"https://api.github.com/repos/bedita/bedita/deployments","created_at":"2012-08-09T07:13:29Z","updated_at":"2017-09-01T09:38:33Z","pushed_at":"2017-11-22T11:27:01Z","git_url":"git://github.com/bedita/bedita.git","ssh_url":"git@github.com:bedita/bedita.git","clone_url":"https://github.com/bedita/bedita.git","svn_url":"https://github.com/bedita/bedita","homepage":"https://www.bedita.com","size":42517,"stargazers_count":37,"watchers_count":37,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":76,"forks":11,"open_issues":76,"watchers":37,"default_branch":"4-cactus"}},"base":{"label":"bedita:4-cactus","ref":"4-cactus","sha":"aae2e4f17faae7f1906674f9a1b7f957a3264024","user":{"login":"bedita","id":2121737,"avatar_url":"https://avatars0.githubusercontent.com/u/2121737?v=4","gravatar_id":"","url":"https://api.github.com/users/bedita","html_url":"https://github.com/bedita","followers_url":"https://api.github.com/users/bedita/followers","following_url":"https://api.github.com/users/bedita/following{/other_user}","gists_url":"https://api.github.com/users/bedita/gists{/gist_id}","starred_url":"https://api.github.com/users/bedita/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bedita/subscriptions","organizations_url":"https://api.github.com/users/bedita/orgs","repos_url":"https://api.github.com/users/bedita/repos","events_url":"https://api.github.com/users/bedita/events{/privacy}","received_events_url":"https://api.github.com/users/bedita/received_events","type":"Organization","site_admin":false},"repo":{"id":5352389,"name":"bedita","full_name":"bedita/bedita","owner":{"login":"bedita","id":2121737,"avatar_url":"https://avatars0.githubusercontent.com/u/2121737?v=4","gravatar_id":"","url":"https://api.github.com/users/bedita","html_url":"https://github.com/bedita","followers_url":"https://api.github.com/users/bedita/followers","following_url":"https://api.github.com/users/bedita/following{/other_user}","gists_url":"https://api.github.com/users/bedita/gists{/gist_id}","starred_url":"https://api.github.com/users/bedita/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bedita/subscriptions","organizations_url":"https://api.github.com/users/bedita/orgs","repos_url":"https://api.github.com/users/bedita/repos","events_url":"https://api.github.com/users/bedita/events{/privacy}","received_events_url":"https://api.github.com/users/bedita/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bedita/bedita","description":"BEdita, ready to use back-end API, extensible API-first Content Management","fork":false,"url":"https://api.github.com/repos/bedita/bedita","forks_url":"https://api.github.com/repos/bedita/bedita/forks","keys_url":"https://api.github.com/repos/bedita/bedita/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bedita/bedita/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bedita/bedita/teams","hooks_url":"https://api.github.com/repos/bedita/bedita/hooks","issue_events_url":"https://api.github.com/repos/bedita/bedita/issues/events{/number}","events_url":"https://api.github.com/repos/bedita/bedita/events","assignees_url":"https://api.github.com/repos/bedita/bedita/assignees{/user}","branches_url":"https://api.github.com/repos/bedita/bedita/branches{/branch}","tags_url":"https://api.github.com/repos/bedita/bedita/tags","blobs_url":"https://api.github.com/repos/bedita/bedita/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bedita/bedita/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bedita/bedita/git/refs{/sha}","trees_url":"https://api.github.com/repos/bedita/bedita/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bedita/bedita/statuses/{sha}","languages_url":"https://api.github.com/repos/bedita/bedita/languages","stargazers_url":"https://api.github.com/repos/bedita/bedita/stargazers","contributors_url":"https://api.github.com/repos/bedita/bedita/contributors","subscribers_url":"https://api.github.com/repos/bedita/bedita/subscribers","subscription_url":"https://api.github.com/repos/bedita/bedita/subscription","commits_url":"https://api.github.com/repos/bedita/bedita/commits{/sha}","git_commits_url":"https://api.github.com/repos/bedita/bedita/git/commits{/sha}","comments_url":"https://api.github.com/repos/bedita/bedita/comments{/number}","issue_comment_url":"https://api.github.com/repos/bedita/bedita/issues/comments{/number}","contents_url":"https://api.github.com/repos/bedita/bedita/contents/{+path}","compare_url":"https://api.github.com/repos/bedita/bedita/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bedita/bedita/merges","archive_url":"https://api.github.com/repos/bedita/bedita/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bedita/bedita/downloads","issues_url":"https://api.github.com/repos/bedita/bedita/issues{/number}","pulls_url":"https://api.github.com/repos/bedita/bedita/pulls{/number}","milestones_url":"https://api.github.com/repos/bedita/bedita/milestones{/number}","notifications_url":"https://api.github.com/repos/bedita/bedita/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bedita/bedita/labels{/name}","releases_url":"https://api.github.com/repos/bedita/bedita/releases{/id}","deployments_url":"https://api.github.com/repos/bedita/bedita/deployments","created_at":"2012-08-09T07:13:29Z","updated_at":"2017-09-01T09:38:33Z","pushed_at":"2017-11-22T11:27:01Z","git_url":"git://github.com/bedita/bedita.git","ssh_url":"git@github.com:bedita/bedita.git","clone_url":"https://github.com/bedita/bedita.git","svn_url":"https://github.com/bedita/bedita","homepage":"https://www.bedita.com","size":42517,"stargazers_count":37,"watchers_count":37,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":76,"forks":11,"open_issues":76,"watchers":37,"default_branch":"4-cactus"}},"_links":{"self":{"href":"https://api.github.com/repos/bedita/bedita/pulls/1390"},"html":{"href":"https://github.com/bedita/bedita/pull/1390"},"issue":{"href":"https://api.github.com/repos/bedita/bedita/issues/1390"},"comments":{"href":"https://api.github.com/repos/bedita/bedita/issues/1390/comments"},"review_comments":{"href":"https://api.github.com/repos/bedita/bedita/pulls/1390/comments"},"review_comment":{"href":"https://api.github.com/repos/bedita/bedita/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bedita/bedita/pulls/1390/commits"},"statuses":{"href":"https://api.github.com/repos/bedita/bedita/statuses/128981534193332d8b07aec4cbec29da075e4483"}},"author_association":"OWNER"}}
{"actor":{"display_login":"fquffio"}}