{"action":"created","comment":{"url":"https://api.github.com/repos/yaseen95/subjecthub/pulls/comments/139943317","pull_request_review_id":63944648,"id":139943317,"diff_hunk":"@@ -111,17 +105,16 @@ public void setLength(String length) {\n         this.length = length;\n     }\n \n-    public AssessmentType getType() {\n-        return type;\n-    }\n+    public AssessmentType getType() { return type; }\n \n-    public void setType(AssessmentType type) {\n-        this.type = type;\n-    }\n+    public void setType(AssessmentType type) { this.type = type; }\n \n-    public Subject getSubject() {\n+    //Edited - This will cause infinite loop as a subject contains assessment object\n+    // assessment has a subject object, inside it will have assignment again, then loop infinite\n+    /*public Subject getSubject() {","path":"backend/src/main/java/com/example/subjecthub/entity/Assessment.java","position":32,"original_position":32,"commit_id":"9a944195e903fabd93221af81b41d283f72f3f60","original_commit_id":"9a944195e903fabd93221af81b41d283f72f3f60","user":{"login":"yaseen95","id":8746946,"avatar_url":"https://avatars1.githubusercontent.com/u/8746946?v=4","gravatar_id":"","url":"https://api.github.com/users/yaseen95","html_url":"https://github.com/yaseen95","followers_url":"https://api.github.com/users/yaseen95/followers","following_url":"https://api.github.com/users/yaseen95/following{/other_user}","gists_url":"https://api.github.com/users/yaseen95/gists{/gist_id}","starred_url":"https://api.github.com/users/yaseen95/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yaseen95/subscriptions","organizations_url":"https://api.github.com/users/yaseen95/orgs","repos_url":"https://api.github.com/users/yaseen95/repos","events_url":"https://api.github.com/users/yaseen95/events{/privacy}","received_events_url":"https://api.github.com/users/yaseen95/received_events","type":"User","site_admin":false},"body":"You should use the @JsonIgnore annotation to get around the recursive issue.","created_at":"2017-09-20T11:31:18Z","updated_at":"2017-09-20T11:33:14Z","html_url":"https://github.com/yaseen95/subjecthub/pull/14#discussion_r139943317","pull_request_url":"https://api.github.com/repos/yaseen95/subjecthub/pulls/14","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/yaseen95/subjecthub/pulls/comments/139943317"},"html":{"href":"https://github.com/yaseen95/subjecthub/pull/14#discussion_r139943317"},"pull_request":{"href":"https://api.github.com/repos/yaseen95/subjecthub/pulls/14"}}},"pull_request":{"url":"https://api.github.com/repos/yaseen95/subjecthub/pulls/14","id":141580183,"html_url":"https://github.com/yaseen95/subjecthub/pull/14","diff_url":"https://github.com/yaseen95/subjecthub/pull/14.diff","patch_url":"https://github.com/yaseen95/subjecthub/pull/14.patch","issue_url":"https://api.github.com/repos/yaseen95/subjecthub/issues/14","number":14,"state":"closed","locked":false,"title":"Added assessment service controller & api","user":{"login":"JetZhu8936","id":20963666,"avatar_url":"https://avatars3.githubusercontent.com/u/20963666?v=4","gravatar_id":"","url":"https://api.github.com/users/JetZhu8936","html_url":"https://github.com/JetZhu8936","followers_url":"https://api.github.com/users/JetZhu8936/followers","following_url":"https://api.github.com/users/JetZhu8936/following{/other_user}","gists_url":"https://api.github.com/users/JetZhu8936/gists{/gist_id}","starred_url":"https://api.github.com/users/JetZhu8936/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JetZhu8936/subscriptions","organizations_url":"https://api.github.com/users/JetZhu8936/orgs","repos_url":"https://api.github.com/users/JetZhu8936/repos","events_url":"https://api.github.com/users/JetZhu8936/events{/privacy}","received_events_url":"https://api.github.com/users/JetZhu8936/received_events","type":"User","site_admin":false},"body":"1. Added assessment service controller & api\r\n2. Modified Assessment.java to pass Integer to enum class, as 'type' is Integer type in data schema\r\n3. Inserted 2 new assignment information into data.sql\r\n\r\nURL for getAssessments() method:\r\nlocalhost:8080/api/universities/university/{universityId}/subjects/subject/{subjectId}/assessments\r\n\r\nURL for getAssessment() method:\r\nlocalhost:8080/api/universities/university/{universityId}/subjects/subject/{subjectId}/assessments/assessment/{assessmentId}\r\n\r\n\r\nFilter for weighting:\r\nlocalhost:8080/api/universities/university/1/subjects/subject/1/assessments?weighting=30\r\n\r\nFilter for type:\r\nlocalhost:8080/api/universities/university/1/subjects/subject/1/assessments?type=4\r\n\r\nFilter for group work:\r\nlocalhost:8080/api/universities/university/1/subjects/subject/1/assessments?isGroupWork=TRUE\r\n\r\n\r\n\r\n\r\n","created_at":"2017-09-18T11:36:36Z","updated_at":"2017-09-20T11:33:14Z","closed_at":"2017-09-19T09:43:09Z","merged_at":"2017-09-19T09:43:09Z","merge_commit_sha":"b5876ac8c92971f69c14561d59c85ffbec9be340","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/yaseen95/subjecthub/pulls/14/commits","review_comments_url":"https://api.github.com/repos/yaseen95/subjecthub/pulls/14/comments","review_comment_url":"https://api.github.com/repos/yaseen95/subjecthub/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yaseen95/subjecthub/issues/14/comments","statuses_url":"https://api.github.com/repos/yaseen95/subjecthub/statuses/9a944195e903fabd93221af81b41d283f72f3f60","head":{"label":"yaseen95:assessment","ref":"assessment","sha":"9a944195e903fabd93221af81b41d283f72f3f60","user":{"login":"yaseen95","id":8746946,"avatar_url":"https://avatars1.githubusercontent.com/u/8746946?v=4","gravatar_id":"","url":"https://api.github.com/users/yaseen95","html_url":"https://github.com/yaseen95","followers_url":"https://api.github.com/users/yaseen95/followers","following_url":"https://api.github.com/users/yaseen95/following{/other_user}","gists_url":"https://api.github.com/users/yaseen95/gists{/gist_id}","starred_url":"https://api.github.com/users/yaseen95/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yaseen95/subscriptions","organizations_url":"https://api.github.com/users/yaseen95/orgs","repos_url":"https://api.github.com/users/yaseen95/repos","events_url":"https://api.github.com/users/yaseen95/events{/privacy}","received_events_url":"https://api.github.com/users/yaseen95/received_events","type":"User","site_admin":false},"repo":{"id":101292552,"name":"subjecthub","full_name":"yaseen95/subjecthub","owner":{"login":"yaseen95","id":8746946,"avatar_url":"https://avatars1.githubusercontent.com/u/8746946?v=4","gravatar_id":"","url":"https://api.github.com/users/yaseen95","html_url":"https://github.com/yaseen95","followers_url":"https://api.github.com/users/yaseen95/followers","following_url":"https://api.github.com/users/yaseen95/following{/other_user}","gists_url":"https://api.github.com/users/yaseen95/gists{/gist_id}","starred_url":"https://api.github.com/users/yaseen95/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yaseen95/subscriptions","organizations_url":"https://api.github.com/users/yaseen95/orgs","repos_url":"https://api.github.com/users/yaseen95/repos","events_url":"https://api.github.com/users/yaseen95/events{/privacy}","received_events_url":"https://api.github.com/users/yaseen95/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yaseen95/subjecthub","description":"UTS Subject Handbook alternative. Project for Software Engineering Practice.","fork":false,"url":"https://api.github.com/repos/yaseen95/subjecthub","forks_url":"https://api.github.com/repos/yaseen95/subjecthub/forks","keys_url":"https://api.github.com/repos/yaseen95/subjecthub/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yaseen95/subjecthub/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yaseen95/subjecthub/teams","hooks_url":"https://api.github.com/repos/yaseen95/subjecthub/hooks","issue_events_url":"https://api.github.com/repos/yaseen95/subjecthub/issues/events{/number}","events_url":"https://api.github.com/repos/yaseen95/subjecthub/events","assignees_url":"https://api.github.com/repos/yaseen95/subjecthub/assignees{/user}","branches_url":"https://api.github.com/repos/yaseen95/subjecthub/branches{/branch}","tags_url":"https://api.github.com/repos/yaseen95/subjecthub/tags","blobs_url":"https://api.github.com/repos/yaseen95/subjecthub/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yaseen95/subjecthub/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yaseen95/subjecthub/git/refs{/sha}","trees_url":"https://api.github.com/repos/yaseen95/subjecthub/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yaseen95/subjecthub/statuses/{sha}","languages_url":"https://api.github.com/repos/yaseen95/subjecthub/languages","stargazers_url":"https://api.github.com/repos/yaseen95/subjecthub/stargazers","contributors_url":"https://api.github.com/repos/yaseen95/subjecthub/contributors","subscribers_url":"https://api.github.com/repos/yaseen95/subjecthub/subscribers","subscription_url":"https://api.github.com/repos/yaseen95/subjecthub/subscription","commits_url":"https://api.github.com/repos/yaseen95/subjecthub/commits{/sha}","git_commits_url":"https://api.github.com/repos/yaseen95/subjecthub/git/commits{/sha}","comments_url":"https://api.github.com/repos/yaseen95/subjecthub/comments{/number}","issue_comment_url":"https://api.github.com/repos/yaseen95/subjecthub/issues/comments{/number}","contents_url":"https://api.github.com/repos/yaseen95/subjecthub/contents/{+path}","compare_url":"https://api.github.com/repos/yaseen95/subjecthub/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yaseen95/subjecthub/merges","archive_url":"https://api.github.com/repos/yaseen95/subjecthub/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yaseen95/subjecthub/downloads","issues_url":"https://api.github.com/repos/yaseen95/subjecthub/issues{/number}","pulls_url":"https://api.github.com/repos/yaseen95/subjecthub/pulls{/number}","milestones_url":"https://api.github.com/repos/yaseen95/subjecthub/milestones{/number}","notifications_url":"https://api.github.com/repos/yaseen95/subjecthub/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yaseen95/subjecthub/labels{/name}","releases_url":"https://api.github.com/repos/yaseen95/subjecthub/releases{/id}","deployments_url":"https://api.github.com/repos/yaseen95/subjecthub/deployments","created_at":"2017-08-24T12:28:56Z","updated_at":"2017-09-15T05:37:10Z","pushed_at":"2017-09-20T11:24:18Z","git_url":"git://github.com/yaseen95/subjecthub.git","ssh_url":"git@github.com:yaseen95/subjecthub.git","clone_url":"https://github.com/yaseen95/subjecthub.git","svn_url":"https://github.com/yaseen95/subjecthub","homepage":"https://subject-hub.com","size":264,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"yaseen95:master","ref":"master","sha":"67a7df2774d1dd5a38e18070f70d6d898c301872","user":{"login":"yaseen95","id":8746946,"avatar_url":"https://avatars1.githubusercontent.com/u/8746946?v=4","gravatar_id":"","url":"https://api.github.com/users/yaseen95","html_url":"https://github.com/yaseen95","followers_url":"https://api.github.com/users/yaseen95/followers","following_url":"https://api.github.com/users/yaseen95/following{/other_user}","gists_url":"https://api.github.com/users/yaseen95/gists{/gist_id}","starred_url":"https://api.github.com/users/yaseen95/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yaseen95/subscriptions","organizations_url":"https://api.github.com/users/yaseen95/orgs","repos_url":"https://api.github.com/users/yaseen95/repos","events_url":"https://api.github.com/users/yaseen95/events{/privacy}","received_events_url":"https://api.github.com/users/yaseen95/received_events","type":"User","site_admin":false},"repo":{"id":101292552,"name":"subjecthub","full_name":"yaseen95/subjecthub","owner":{"login":"yaseen95","id":8746946,"avatar_url":"https://avatars1.githubusercontent.com/u/8746946?v=4","gravatar_id":"","url":"https://api.github.com/users/yaseen95","html_url":"https://github.com/yaseen95","followers_url":"https://api.github.com/users/yaseen95/followers","following_url":"https://api.github.com/users/yaseen95/following{/other_user}","gists_url":"https://api.github.com/users/yaseen95/gists{/gist_id}","starred_url":"https://api.github.com/users/yaseen95/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yaseen95/subscriptions","organizations_url":"https://api.github.com/users/yaseen95/orgs","repos_url":"https://api.github.com/users/yaseen95/repos","events_url":"https://api.github.com/users/yaseen95/events{/privacy}","received_events_url":"https://api.github.com/users/yaseen95/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yaseen95/subjecthub","description":"UTS Subject Handbook alternative. Project for Software Engineering Practice.","fork":false,"url":"https://api.github.com/repos/yaseen95/subjecthub","forks_url":"https://api.github.com/repos/yaseen95/subjecthub/forks","keys_url":"https://api.github.com/repos/yaseen95/subjecthub/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yaseen95/subjecthub/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yaseen95/subjecthub/teams","hooks_url":"https://api.github.com/repos/yaseen95/subjecthub/hooks","issue_events_url":"https://api.github.com/repos/yaseen95/subjecthub/issues/events{/number}","events_url":"https://api.github.com/repos/yaseen95/subjecthub/events","assignees_url":"https://api.github.com/repos/yaseen95/subjecthub/assignees{/user}","branches_url":"https://api.github.com/repos/yaseen95/subjecthub/branches{/branch}","tags_url":"https://api.github.com/repos/yaseen95/subjecthub/tags","blobs_url":"https://api.github.com/repos/yaseen95/subjecthub/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yaseen95/subjecthub/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yaseen95/subjecthub/git/refs{/sha}","trees_url":"https://api.github.com/repos/yaseen95/subjecthub/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yaseen95/subjecthub/statuses/{sha}","languages_url":"https://api.github.com/repos/yaseen95/subjecthub/languages","stargazers_url":"https://api.github.com/repos/yaseen95/subjecthub/stargazers","contributors_url":"https://api.github.com/repos/yaseen95/subjecthub/contributors","subscribers_url":"https://api.github.com/repos/yaseen95/subjecthub/subscribers","subscription_url":"https://api.github.com/repos/yaseen95/subjecthub/subscription","commits_url":"https://api.github.com/repos/yaseen95/subjecthub/commits{/sha}","git_commits_url":"https://api.github.com/repos/yaseen95/subjecthub/git/commits{/sha}","comments_url":"https://api.github.com/repos/yaseen95/subjecthub/comments{/number}","issue_comment_url":"https://api.github.com/repos/yaseen95/subjecthub/issues/comments{/number}","contents_url":"https://api.github.com/repos/yaseen95/subjecthub/contents/{+path}","compare_url":"https://api.github.com/repos/yaseen95/subjecthub/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yaseen95/subjecthub/merges","archive_url":"https://api.github.com/repos/yaseen95/subjecthub/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yaseen95/subjecthub/downloads","issues_url":"https://api.github.com/repos/yaseen95/subjecthub/issues{/number}","pulls_url":"https://api.github.com/repos/yaseen95/subjecthub/pulls{/number}","milestones_url":"https://api.github.com/repos/yaseen95/subjecthub/milestones{/number}","notifications_url":"https://api.github.com/repos/yaseen95/subjecthub/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yaseen95/subjecthub/labels{/name}","releases_url":"https://api.github.com/repos/yaseen95/subjecthub/releases{/id}","deployments_url":"https://api.github.com/repos/yaseen95/subjecthub/deployments","created_at":"2017-08-24T12:28:56Z","updated_at":"2017-09-15T05:37:10Z","pushed_at":"2017-09-20T11:24:18Z","git_url":"git://github.com/yaseen95/subjecthub.git","ssh_url":"git@github.com:yaseen95/subjecthub.git","clone_url":"https://github.com/yaseen95/subjecthub.git","svn_url":"https://github.com/yaseen95/subjecthub","homepage":"https://subject-hub.com","size":264,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yaseen95/subjecthub/pulls/14"},"html":{"href":"https://github.com/yaseen95/subjecthub/pull/14"},"issue":{"href":"https://api.github.com/repos/yaseen95/subjecthub/issues/14"},"comments":{"href":"https://api.github.com/repos/yaseen95/subjecthub/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/yaseen95/subjecthub/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/yaseen95/subjecthub/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yaseen95/subjecthub/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/yaseen95/subjecthub/statuses/9a944195e903fabd93221af81b41d283f72f3f60"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"yaseen95"}}