{"action":"created","comment":{"url":"https://api.github.com/repos/teamleadercrm/api/pulls/comments/145470064","pull_request_review_id":70275404,"id":145470064,"diff_hunk":"@@ -916,6 +916,9 @@ Get a list of deals.\n                 + customer (object)\n                     + _type: `contact`\n                     + id: 1 (string)\n+                    + represented_by (object)","path":"apiary.apib","position":4,"original_position":4,"commit_id":"ed71dea8034612d9514601fb2c4ec86379a65e34","original_commit_id":"ed71dea8034612d9514601fb2c4ec86379a65e34","user":{"login":"stivni","id":1628429,"avatar_url":"https://avatars2.githubusercontent.com/u/1628429?v=4","gravatar_id":"","url":"https://api.github.com/users/stivni","html_url":"https://github.com/stivni","followers_url":"https://api.github.com/users/stivni/followers","following_url":"https://api.github.com/users/stivni/following{/other_user}","gists_url":"https://api.github.com/users/stivni/gists{/gist_id}","starred_url":"https://api.github.com/users/stivni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stivni/subscriptions","organizations_url":"https://api.github.com/users/stivni/orgs","repos_url":"https://api.github.com/users/stivni/repos","events_url":"https://api.github.com/users/stivni/events{/privacy}","received_events_url":"https://api.github.com/users/stivni/received_events","type":"User","site_admin":false},"body":"I discussed this with @PieterReel, @bbouwmeister and @charlottevb ...\r\nIt seems we want to keep this closer to what we do in Invoicing...\r\n\r\nIt should look more like this : \r\n\r\n```\r\n                + customer (object)\r\n                    + customer (object)\r\n                        + _type: `contact`\r\n                        + id: 1 (string)\r\n                    + for_attention_of (object, optional)\r\n                         + name: `Radja Nainggolan` (string)\r\n                         + contact (object)\r\n                             + _type: `contact` (string)\r\n                             + id: `456` (string)\r\n```\r\n\r\nAlthough I'm not please with how we say customer twice now... In invoicing the top level one is called \"invoicee\", so we can reuse the \"customer\" fieldname without it feeling weird...\r\n\r\nAny suggestions?","created_at":"2017-10-18T16:30:04Z","updated_at":"2017-10-18T16:30:05Z","html_url":"https://github.com/teamleadercrm/api/pull/196#discussion_r145470064","pull_request_url":"https://api.github.com/repos/teamleadercrm/api/pulls/196","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/teamleadercrm/api/pulls/comments/145470064"},"html":{"href":"https://github.com/teamleadercrm/api/pull/196#discussion_r145470064"},"pull_request":{"href":"https://api.github.com/repos/teamleadercrm/api/pulls/196"}}},"pull_request":{"url":"https://api.github.com/repos/teamleadercrm/api/pulls/196","id":146970753,"html_url":"https://github.com/teamleadercrm/api/pull/196","diff_url":"https://github.com/teamleadercrm/api/pull/196.diff","patch_url":"https://github.com/teamleadercrm/api/pull/196.patch","issue_url":"https://api.github.com/repos/teamleadercrm/api/issues/196","number":196,"state":"open","locked":false,"title":"Add optional contact to deals.list API","user":{"login":"MathiasDL","id":19802404,"avatar_url":"https://avatars0.githubusercontent.com/u/19802404?v=4","gravatar_id":"","url":"https://api.github.com/users/MathiasDL","html_url":"https://github.com/MathiasDL","followers_url":"https://api.github.com/users/MathiasDL/followers","following_url":"https://api.github.com/users/MathiasDL/following{/other_user}","gists_url":"https://api.github.com/users/MathiasDL/gists{/gist_id}","starred_url":"https://api.github.com/users/MathiasDL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MathiasDL/subscriptions","organizations_url":"https://api.github.com/users/MathiasDL/orgs","repos_url":"https://api.github.com/users/MathiasDL/repos","events_url":"https://api.github.com/users/MathiasDL/events{/privacy}","received_events_url":"https://api.github.com/users/MathiasDL/received_events","type":"User","site_admin":false},"body":"Note: the same should be applied to deals.info","created_at":"2017-10-17T08:16:59Z","updated_at":"2017-10-18T16:30:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eda9155d4ca320226355aab74260deb6faa703e9","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jenssegers","id":194377,"avatar_url":"https://avatars1.githubusercontent.com/u/194377?v=4","gravatar_id":"","url":"https://api.github.com/users/jenssegers","html_url":"https://github.com/jenssegers","followers_url":"https://api.github.com/users/jenssegers/followers","following_url":"https://api.github.com/users/jenssegers/following{/other_user}","gists_url":"https://api.github.com/users/jenssegers/gists{/gist_id}","starred_url":"https://api.github.com/users/jenssegers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenssegers/subscriptions","organizations_url":"https://api.github.com/users/jenssegers/orgs","repos_url":"https://api.github.com/users/jenssegers/repos","events_url":"https://api.github.com/users/jenssegers/events{/privacy}","received_events_url":"https://api.github.com/users/jenssegers/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/teamleadercrm/api/pulls/196/commits","review_comments_url":"https://api.github.com/repos/teamleadercrm/api/pulls/196/comments","review_comment_url":"https://api.github.com/repos/teamleadercrm/api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/teamleadercrm/api/issues/196/comments","statuses_url":"https://api.github.com/repos/teamleadercrm/api/statuses/ed71dea8034612d9514601fb2c4ec86379a65e34","head":{"label":"teamleadercrm:proposal/deal-optional-contact","ref":"proposal/deal-optional-contact","sha":"ed71dea8034612d9514601fb2c4ec86379a65e34","user":{"login":"teamleadercrm","id":19797966,"avatar_url":"https://avatars3.githubusercontent.com/u/19797966?v=4","gravatar_id":"","url":"https://api.github.com/users/teamleadercrm","html_url":"https://github.com/teamleadercrm","followers_url":"https://api.github.com/users/teamleadercrm/followers","following_url":"https://api.github.com/users/teamleadercrm/following{/other_user}","gists_url":"https://api.github.com/users/teamleadercrm/gists{/gist_id}","starred_url":"https://api.github.com/users/teamleadercrm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teamleadercrm/subscriptions","organizations_url":"https://api.github.com/users/teamleadercrm/orgs","repos_url":"https://api.github.com/users/teamleadercrm/repos","events_url":"https://api.github.com/users/teamleadercrm/events{/privacy}","received_events_url":"https://api.github.com/users/teamleadercrm/received_events","type":"Organization","site_admin":false},"repo":{"id":87057787,"name":"api","full_name":"teamleadercrm/api","owner":{"login":"teamleadercrm","id":19797966,"avatar_url":"https://avatars3.githubusercontent.com/u/19797966?v=4","gravatar_id":"","url":"https://api.github.com/users/teamleadercrm","html_url":"https://github.com/teamleadercrm","followers_url":"https://api.github.com/users/teamleadercrm/followers","following_url":"https://api.github.com/users/teamleadercrm/following{/other_user}","gists_url":"https://api.github.com/users/teamleadercrm/gists{/gist_id}","starred_url":"https://api.github.com/users/teamleadercrm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teamleadercrm/subscriptions","organizations_url":"https://api.github.com/users/teamleadercrm/orgs","repos_url":"https://api.github.com/users/teamleadercrm/repos","events_url":"https://api.github.com/users/teamleadercrm/events{/privacy}","received_events_url":"https://api.github.com/users/teamleadercrm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/teamleadercrm/api","description":"The Teamleader API definition","fork":false,"url":"https://api.github.com/repos/teamleadercrm/api","forks_url":"https://api.github.com/repos/teamleadercrm/api/forks","keys_url":"https://api.github.com/repos/teamleadercrm/api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/teamleadercrm/api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/teamleadercrm/api/teams","hooks_url":"https://api.github.com/repos/teamleadercrm/api/hooks","issue_events_url":"https://api.github.com/repos/teamleadercrm/api/issues/events{/number}","events_url":"https://api.github.com/repos/teamleadercrm/api/events","assignees_url":"https://api.github.com/repos/teamleadercrm/api/assignees{/user}","branches_url":"https://api.github.com/repos/teamleadercrm/api/branches{/branch}","tags_url":"https://api.github.com/repos/teamleadercrm/api/tags","blobs_url":"https://api.github.com/repos/teamleadercrm/api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/teamleadercrm/api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/teamleadercrm/api/git/refs{/sha}","trees_url":"https://api.github.com/repos/teamleadercrm/api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/teamleadercrm/api/statuses/{sha}","languages_url":"https://api.github.com/repos/teamleadercrm/api/languages","stargazers_url":"https://api.github.com/repos/teamleadercrm/api/stargazers","contributors_url":"https://api.github.com/repos/teamleadercrm/api/contributors","subscribers_url":"https://api.github.com/repos/teamleadercrm/api/subscribers","subscription_url":"https://api.github.com/repos/teamleadercrm/api/subscription","commits_url":"https://api.github.com/repos/teamleadercrm/api/commits{/sha}","git_commits_url":"https://api.github.com/repos/teamleadercrm/api/git/commits{/sha}","comments_url":"https://api.github.com/repos/teamleadercrm/api/comments{/number}","issue_comment_url":"https://api.github.com/repos/teamleadercrm/api/issues/comments{/number}","contents_url":"https://api.github.com/repos/teamleadercrm/api/contents/{+path}","compare_url":"https://api.github.com/repos/teamleadercrm/api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/teamleadercrm/api/merges","archive_url":"https://api.github.com/repos/teamleadercrm/api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/teamleadercrm/api/downloads","issues_url":"https://api.github.com/repos/teamleadercrm/api/issues{/number}","pulls_url":"https://api.github.com/repos/teamleadercrm/api/pulls{/number}","milestones_url":"https://api.github.com/repos/teamleadercrm/api/milestones{/number}","notifications_url":"https://api.github.com/repos/teamleadercrm/api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/teamleadercrm/api/labels{/name}","releases_url":"https://api.github.com/repos/teamleadercrm/api/releases{/id}","deployments_url":"https://api.github.com/repos/teamleadercrm/api/deployments","created_at":"2017-04-03T09:27:04Z","updated_at":"2017-09-06T08:59:15Z","pushed_at":"2017-10-17T12:06:44Z","git_url":"git://github.com/teamleadercrm/api.git","ssh_url":"git@github.com:teamleadercrm/api.git","clone_url":"https://github.com/teamleadercrm/api.git","svn_url":"https://github.com/teamleadercrm/api","homepage":"http://apidocs.teamleader.eu/v2/","size":588,"stargazers_count":3,"watchers_count":3,"language":"API Blueprint","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":20,"forks":0,"open_issues":20,"watchers":3,"default_branch":"master"}},"base":{"label":"teamleadercrm:master","ref":"master","sha":"5ff30e9ac71d0887464261a9ad29a35544a4c66a","user":{"login":"teamleadercrm","id":19797966,"avatar_url":"https://avatars3.githubusercontent.com/u/19797966?v=4","gravatar_id":"","url":"https://api.github.com/users/teamleadercrm","html_url":"https://github.com/teamleadercrm","followers_url":"https://api.github.com/users/teamleadercrm/followers","following_url":"https://api.github.com/users/teamleadercrm/following{/other_user}","gists_url":"https://api.github.com/users/teamleadercrm/gists{/gist_id}","starred_url":"https://api.github.com/users/teamleadercrm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teamleadercrm/subscriptions","organizations_url":"https://api.github.com/users/teamleadercrm/orgs","repos_url":"https://api.github.com/users/teamleadercrm/repos","events_url":"https://api.github.com/users/teamleadercrm/events{/privacy}","received_events_url":"https://api.github.com/users/teamleadercrm/received_events","type":"Organization","site_admin":false},"repo":{"id":87057787,"name":"api","full_name":"teamleadercrm/api","owner":{"login":"teamleadercrm","id":19797966,"avatar_url":"https://avatars3.githubusercontent.com/u/19797966?v=4","gravatar_id":"","url":"https://api.github.com/users/teamleadercrm","html_url":"https://github.com/teamleadercrm","followers_url":"https://api.github.com/users/teamleadercrm/followers","following_url":"https://api.github.com/users/teamleadercrm/following{/other_user}","gists_url":"https://api.github.com/users/teamleadercrm/gists{/gist_id}","starred_url":"https://api.github.com/users/teamleadercrm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teamleadercrm/subscriptions","organizations_url":"https://api.github.com/users/teamleadercrm/orgs","repos_url":"https://api.github.com/users/teamleadercrm/repos","events_url":"https://api.github.com/users/teamleadercrm/events{/privacy}","received_events_url":"https://api.github.com/users/teamleadercrm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/teamleadercrm/api","description":"The Teamleader API definition","fork":false,"url":"https://api.github.com/repos/teamleadercrm/api","forks_url":"https://api.github.com/repos/teamleadercrm/api/forks","keys_url":"https://api.github.com/repos/teamleadercrm/api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/teamleadercrm/api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/teamleadercrm/api/teams","hooks_url":"https://api.github.com/repos/teamleadercrm/api/hooks","issue_events_url":"https://api.github.com/repos/teamleadercrm/api/issues/events{/number}","events_url":"https://api.github.com/repos/teamleadercrm/api/events","assignees_url":"https://api.github.com/repos/teamleadercrm/api/assignees{/user}","branches_url":"https://api.github.com/repos/teamleadercrm/api/branches{/branch}","tags_url":"https://api.github.com/repos/teamleadercrm/api/tags","blobs_url":"https://api.github.com/repos/teamleadercrm/api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/teamleadercrm/api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/teamleadercrm/api/git/refs{/sha}","trees_url":"https://api.github.com/repos/teamleadercrm/api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/teamleadercrm/api/statuses/{sha}","languages_url":"https://api.github.com/repos/teamleadercrm/api/languages","stargazers_url":"https://api.github.com/repos/teamleadercrm/api/stargazers","contributors_url":"https://api.github.com/repos/teamleadercrm/api/contributors","subscribers_url":"https://api.github.com/repos/teamleadercrm/api/subscribers","subscription_url":"https://api.github.com/repos/teamleadercrm/api/subscription","commits_url":"https://api.github.com/repos/teamleadercrm/api/commits{/sha}","git_commits_url":"https://api.github.com/repos/teamleadercrm/api/git/commits{/sha}","comments_url":"https://api.github.com/repos/teamleadercrm/api/comments{/number}","issue_comment_url":"https://api.github.com/repos/teamleadercrm/api/issues/comments{/number}","contents_url":"https://api.github.com/repos/teamleadercrm/api/contents/{+path}","compare_url":"https://api.github.com/repos/teamleadercrm/api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/teamleadercrm/api/merges","archive_url":"https://api.github.com/repos/teamleadercrm/api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/teamleadercrm/api/downloads","issues_url":"https://api.github.com/repos/teamleadercrm/api/issues{/number}","pulls_url":"https://api.github.com/repos/teamleadercrm/api/pulls{/number}","milestones_url":"https://api.github.com/repos/teamleadercrm/api/milestones{/number}","notifications_url":"https://api.github.com/repos/teamleadercrm/api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/teamleadercrm/api/labels{/name}","releases_url":"https://api.github.com/repos/teamleadercrm/api/releases{/id}","deployments_url":"https://api.github.com/repos/teamleadercrm/api/deployments","created_at":"2017-04-03T09:27:04Z","updated_at":"2017-09-06T08:59:15Z","pushed_at":"2017-10-17T12:06:44Z","git_url":"git://github.com/teamleadercrm/api.git","ssh_url":"git@github.com:teamleadercrm/api.git","clone_url":"https://github.com/teamleadercrm/api.git","svn_url":"https://github.com/teamleadercrm/api","homepage":"http://apidocs.teamleader.eu/v2/","size":588,"stargazers_count":3,"watchers_count":3,"language":"API Blueprint","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":20,"forks":0,"open_issues":20,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/teamleadercrm/api/pulls/196"},"html":{"href":"https://github.com/teamleadercrm/api/pull/196"},"issue":{"href":"https://api.github.com/repos/teamleadercrm/api/issues/196"},"comments":{"href":"https://api.github.com/repos/teamleadercrm/api/issues/196/comments"},"review_comments":{"href":"https://api.github.com/repos/teamleadercrm/api/pulls/196/comments"},"review_comment":{"href":"https://api.github.com/repos/teamleadercrm/api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/teamleadercrm/api/pulls/196/commits"},"statuses":{"href":"https://api.github.com/repos/teamleadercrm/api/statuses/ed71dea8034612d9514601fb2c4ec86379a65e34"}},"author_association":"NONE"}}
{"actor":{"display_login":"stivni"}}