{"action":"created","comment":{"url":"https://api.github.com/repos/gnocchixyz/gnocchi/pulls/comments/121594471","pull_request_review_id":43630761,"id":121594471,"diff_hunk":"@@ -234,14 +264,6 @@ class TestCase(base.BaseTestCase):\n     @classmethod\n     def setUpClass(self):\n         super(TestCase, self).setUpClass()\n-\n-        # NOTE(sileht): oslotest does this in setUp() but we\n-        # need it here","path":"gnocchi/tests/base.py","position":60,"original_position":60,"commit_id":"6558528e4104f80bf17433f55e96429e2b538ed8","original_commit_id":"6558528e4104f80bf17433f55e96429e2b538ed8","user":{"login":"sileht","id":200878,"avatar_url":"https://avatars3.githubusercontent.com/u/200878?v=3","gravatar_id":"","url":"https://api.github.com/users/sileht","html_url":"https://github.com/sileht","followers_url":"https://api.github.com/users/sileht/followers","following_url":"https://api.github.com/users/sileht/following{/other_user}","gists_url":"https://api.github.com/users/sileht/gists{/gist_id}","starred_url":"https://api.github.com/users/sileht/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sileht/subscriptions","organizations_url":"https://api.github.com/users/sileht/orgs","repos_url":"https://api.github.com/users/sileht/repos","events_url":"https://api.github.com/users/sileht/events{/privacy}","received_events_url":"https://api.github.com/users/sileht/received_events","type":"User","site_admin":false},"body":"I haven't test but I think all the logs/print done during service.prepare_service and indexer setup will be printed.","created_at":"2017-06-13T06:52:22Z","updated_at":"2017-06-13T06:53:32Z","html_url":"https://github.com/gnocchixyz/gnocchi/pull/102#discussion_r121594471","pull_request_url":"https://api.github.com/repos/gnocchixyz/gnocchi/pulls/102","_links":{"self":{"href":"https://api.github.com/repos/gnocchixyz/gnocchi/pulls/comments/121594471"},"html":{"href":"https://github.com/gnocchixyz/gnocchi/pull/102#discussion_r121594471"},"pull_request":{"href":"https://api.github.com/repos/gnocchixyz/gnocchi/pulls/102"}}},"pull_request":{"url":"https://api.github.com/repos/gnocchixyz/gnocchi/pulls/102","id":125162293,"html_url":"https://github.com/gnocchixyz/gnocchi/pull/102","diff_url":"https://github.com/gnocchixyz/gnocchi/pull/102.diff","patch_url":"https://github.com/gnocchixyz/gnocchi/pull/102.patch","issue_url":"https://api.github.com/repos/gnocchixyz/gnocchi/issues/102","number":102,"state":"open","locked":false,"title":"Remove oslotest dependency","user":{"login":"jd","id":2644,"avatar_url":"https://avatars3.githubusercontent.com/u/2644?v=3","gravatar_id":"","url":"https://api.github.com/users/jd","html_url":"https://github.com/jd","followers_url":"https://api.github.com/users/jd/followers","following_url":"https://api.github.com/users/jd/following{/other_user}","gists_url":"https://api.github.com/users/jd/gists{/gist_id}","starred_url":"https://api.github.com/users/jd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jd/subscriptions","organizations_url":"https://api.github.com/users/jd/orgs","repos_url":"https://api.github.com/users/jd/repos","events_url":"https://api.github.com/users/jd/events{/privacy}","received_events_url":"https://api.github.com/users/jd/received_events","type":"User","site_admin":false},"body":"Oslotest is OpenStack specific and we actually don't use any of its feature\nexcept stdout redirection and log silencing, which is really provided by\n`fixtures' and `daiquiri'.\nRemove it and use testtools directly. This avoids having OS_* variables used\neverywhere and makes sure we don't pull dependencies we don't need (mox3,\nos-client-config, etc).","created_at":"2017-06-12T15:20:36Z","updated_at":"2017-06-13T06:53:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bec12634ff8681f04736fb07d6bfadc23317614a","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/gnocchixyz/gnocchi/pulls/102/commits","review_comments_url":"https://api.github.com/repos/gnocchixyz/gnocchi/pulls/102/comments","review_comment_url":"https://api.github.com/repos/gnocchixyz/gnocchi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gnocchixyz/gnocchi/issues/102/comments","statuses_url":"https://api.github.com/repos/gnocchixyz/gnocchi/statuses/6558528e4104f80bf17433f55e96429e2b538ed8","head":{"label":"jd:jd/oslotest","ref":"jd/oslotest","sha":"6558528e4104f80bf17433f55e96429e2b538ed8","user":{"login":"jd","id":2644,"avatar_url":"https://avatars3.githubusercontent.com/u/2644?v=3","gravatar_id":"","url":"https://api.github.com/users/jd","html_url":"https://github.com/jd","followers_url":"https://api.github.com/users/jd/followers","following_url":"https://api.github.com/users/jd/following{/other_user}","gists_url":"https://api.github.com/users/jd/gists{/gist_id}","starred_url":"https://api.github.com/users/jd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jd/subscriptions","organizations_url":"https://api.github.com/users/jd/orgs","repos_url":"https://api.github.com/users/jd/repos","events_url":"https://api.github.com/users/jd/events{/privacy}","received_events_url":"https://api.github.com/users/jd/received_events","type":"User","site_admin":false},"repo":{"id":91824535,"name":"gnocchi","full_name":"jd/gnocchi","owner":{"login":"jd","id":2644,"avatar_url":"https://avatars3.githubusercontent.com/u/2644?v=3","gravatar_id":"","url":"https://api.github.com/users/jd","html_url":"https://github.com/jd","followers_url":"https://api.github.com/users/jd/followers","following_url":"https://api.github.com/users/jd/following{/other_user}","gists_url":"https://api.github.com/users/jd/gists{/gist_id}","starred_url":"https://api.github.com/users/jd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jd/subscriptions","organizations_url":"https://api.github.com/users/jd/orgs","repos_url":"https://api.github.com/users/jd/repos","events_url":"https://api.github.com/users/jd/events{/privacy}","received_events_url":"https://api.github.com/users/jd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jd/gnocchi","description":"Timeseries database","fork":true,"url":"https://api.github.com/repos/jd/gnocchi","forks_url":"https://api.github.com/repos/jd/gnocchi/forks","keys_url":"https://api.github.com/repos/jd/gnocchi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jd/gnocchi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jd/gnocchi/teams","hooks_url":"https://api.github.com/repos/jd/gnocchi/hooks","issue_events_url":"https://api.github.com/repos/jd/gnocchi/issues/events{/number}","events_url":"https://api.github.com/repos/jd/gnocchi/events","assignees_url":"https://api.github.com/repos/jd/gnocchi/assignees{/user}","branches_url":"https://api.github.com/repos/jd/gnocchi/branches{/branch}","tags_url":"https://api.github.com/repos/jd/gnocchi/tags","blobs_url":"https://api.github.com/repos/jd/gnocchi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jd/gnocchi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jd/gnocchi/git/refs{/sha}","trees_url":"https://api.github.com/repos/jd/gnocchi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jd/gnocchi/statuses/{sha}","languages_url":"https://api.github.com/repos/jd/gnocchi/languages","stargazers_url":"https://api.github.com/repos/jd/gnocchi/stargazers","contributors_url":"https://api.github.com/repos/jd/gnocchi/contributors","subscribers_url":"https://api.github.com/repos/jd/gnocchi/subscribers","subscription_url":"https://api.github.com/repos/jd/gnocchi/subscription","commits_url":"https://api.github.com/repos/jd/gnocchi/commits{/sha}","git_commits_url":"https://api.github.com/repos/jd/gnocchi/git/commits{/sha}","comments_url":"https://api.github.com/repos/jd/gnocchi/comments{/number}","issue_comment_url":"https://api.github.com/repos/jd/gnocchi/issues/comments{/number}","contents_url":"https://api.github.com/repos/jd/gnocchi/contents/{+path}","compare_url":"https://api.github.com/repos/jd/gnocchi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jd/gnocchi/merges","archive_url":"https://api.github.com/repos/jd/gnocchi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jd/gnocchi/downloads","issues_url":"https://api.github.com/repos/jd/gnocchi/issues{/number}","pulls_url":"https://api.github.com/repos/jd/gnocchi/pulls{/number}","milestones_url":"https://api.github.com/repos/jd/gnocchi/milestones{/number}","notifications_url":"https://api.github.com/repos/jd/gnocchi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jd/gnocchi/labels{/name}","releases_url":"https://api.github.com/repos/jd/gnocchi/releases{/id}","deployments_url":"https://api.github.com/repos/jd/gnocchi/deployments","created_at":"2017-05-19T16:20:08Z","updated_at":"2017-05-19T16:20:11Z","pushed_at":"2017-06-12T17:44:34Z","git_url":"git://github.com/jd/gnocchi.git","ssh_url":"git@github.com:jd/gnocchi.git","clone_url":"https://github.com/jd/gnocchi.git","svn_url":"https://github.com/jd/gnocchi","homepage":null,"size":3288,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gnocchixyz:master","ref":"master","sha":"f58db5b24ba954e338258ab6cecee63e4d7c32d7","user":{"login":"gnocchixyz","id":26142905,"avatar_url":"https://avatars3.githubusercontent.com/u/26142905?v=3","gravatar_id":"","url":"https://api.github.com/users/gnocchixyz","html_url":"https://github.com/gnocchixyz","followers_url":"https://api.github.com/users/gnocchixyz/followers","following_url":"https://api.github.com/users/gnocchixyz/following{/other_user}","gists_url":"https://api.github.com/users/gnocchixyz/gists{/gist_id}","starred_url":"https://api.github.com/users/gnocchixyz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnocchixyz/subscriptions","organizations_url":"https://api.github.com/users/gnocchixyz/orgs","repos_url":"https://api.github.com/users/gnocchixyz/repos","events_url":"https://api.github.com/users/gnocchixyz/events{/privacy}","received_events_url":"https://api.github.com/users/gnocchixyz/received_events","type":"Organization","site_admin":false},"repo":{"id":91715647,"name":"gnocchi","full_name":"gnocchixyz/gnocchi","owner":{"login":"gnocchixyz","id":26142905,"avatar_url":"https://avatars3.githubusercontent.com/u/26142905?v=3","gravatar_id":"","url":"https://api.github.com/users/gnocchixyz","html_url":"https://github.com/gnocchixyz","followers_url":"https://api.github.com/users/gnocchixyz/followers","following_url":"https://api.github.com/users/gnocchixyz/following{/other_user}","gists_url":"https://api.github.com/users/gnocchixyz/gists{/gist_id}","starred_url":"https://api.github.com/users/gnocchixyz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnocchixyz/subscriptions","organizations_url":"https://api.github.com/users/gnocchixyz/orgs","repos_url":"https://api.github.com/users/gnocchixyz/repos","events_url":"https://api.github.com/users/gnocchixyz/events{/privacy}","received_events_url":"https://api.github.com/users/gnocchixyz/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gnocchixyz/gnocchi","description":"Timeseries database","fork":false,"url":"https://api.github.com/repos/gnocchixyz/gnocchi","forks_url":"https://api.github.com/repos/gnocchixyz/gnocchi/forks","keys_url":"https://api.github.com/repos/gnocchixyz/gnocchi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gnocchixyz/gnocchi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gnocchixyz/gnocchi/teams","hooks_url":"https://api.github.com/repos/gnocchixyz/gnocchi/hooks","issue_events_url":"https://api.github.com/repos/gnocchixyz/gnocchi/issues/events{/number}","events_url":"https://api.github.com/repos/gnocchixyz/gnocchi/events","assignees_url":"https://api.github.com/repos/gnocchixyz/gnocchi/assignees{/user}","branches_url":"https://api.github.com/repos/gnocchixyz/gnocchi/branches{/branch}","tags_url":"https://api.github.com/repos/gnocchixyz/gnocchi/tags","blobs_url":"https://api.github.com/repos/gnocchixyz/gnocchi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gnocchixyz/gnocchi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gnocchixyz/gnocchi/git/refs{/sha}","trees_url":"https://api.github.com/repos/gnocchixyz/gnocchi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gnocchixyz/gnocchi/statuses/{sha}","languages_url":"https://api.github.com/repos/gnocchixyz/gnocchi/languages","stargazers_url":"https://api.github.com/repos/gnocchixyz/gnocchi/stargazers","contributors_url":"https://api.github.com/repos/gnocchixyz/gnocchi/contributors","subscribers_url":"https://api.github.com/repos/gnocchixyz/gnocchi/subscribers","subscription_url":"https://api.github.com/repos/gnocchixyz/gnocchi/subscription","commits_url":"https://api.github.com/repos/gnocchixyz/gnocchi/commits{/sha}","git_commits_url":"https://api.github.com/repos/gnocchixyz/gnocchi/git/commits{/sha}","comments_url":"https://api.github.com/repos/gnocchixyz/gnocchi/comments{/number}","issue_comment_url":"https://api.github.com/repos/gnocchixyz/gnocchi/issues/comments{/number}","contents_url":"https://api.github.com/repos/gnocchixyz/gnocchi/contents/{+path}","compare_url":"https://api.github.com/repos/gnocchixyz/gnocchi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gnocchixyz/gnocchi/merges","archive_url":"https://api.github.com/repos/gnocchixyz/gnocchi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gnocchixyz/gnocchi/downloads","issues_url":"https://api.github.com/repos/gnocchixyz/gnocchi/issues{/number}","pulls_url":"https://api.github.com/repos/gnocchixyz/gnocchi/pulls{/number}","milestones_url":"https://api.github.com/repos/gnocchixyz/gnocchi/milestones{/number}","notifications_url":"https://api.github.com/repos/gnocchixyz/gnocchi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gnocchixyz/gnocchi/labels{/name}","releases_url":"https://api.github.com/repos/gnocchixyz/gnocchi/releases{/id}","deployments_url":"https://api.github.com/repos/gnocchixyz/gnocchi/deployments","created_at":"2017-05-18T16:32:52Z","updated_at":"2017-06-13T04:22:49Z","pushed_at":"2017-06-12T20:44:16Z","git_url":"git://github.com/gnocchixyz/gnocchi.git","ssh_url":"git@github.com:gnocchixyz/gnocchi.git","clone_url":"https://github.com/gnocchixyz/gnocchi.git","svn_url":"https://github.com/gnocchixyz/gnocchi","homepage":null,"size":3287,"stargazers_count":13,"watchers_count":13,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":24,"forks":6,"open_issues":24,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gnocchixyz/gnocchi/pulls/102"},"html":{"href":"https://github.com/gnocchixyz/gnocchi/pull/102"},"issue":{"href":"https://api.github.com/repos/gnocchixyz/gnocchi/issues/102"},"comments":{"href":"https://api.github.com/repos/gnocchixyz/gnocchi/issues/102/comments"},"review_comments":{"href":"https://api.github.com/repos/gnocchixyz/gnocchi/pulls/102/comments"},"review_comment":{"href":"https://api.github.com/repos/gnocchixyz/gnocchi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gnocchixyz/gnocchi/pulls/102/commits"},"statuses":{"href":"https://api.github.com/repos/gnocchixyz/gnocchi/statuses/6558528e4104f80bf17433f55e96429e2b538ed8"}}}}
{"actor":{"display_login":"sileht"}}