{"action":"created","issue":{"url":"https://api.github.com/repos/magnumripper/JohnTheRipper/issues/2961","repository_url":"https://api.github.com/repos/magnumripper/JohnTheRipper","labels_url":"https://api.github.com/repos/magnumripper/JohnTheRipper/issues/2961/labels{/name}","comments_url":"https://api.github.com/repos/magnumripper/JohnTheRipper/issues/2961/comments","events_url":"https://api.github.com/repos/magnumripper/JohnTheRipper/issues/2961/events","html_url":"https://github.com/magnumripper/JohnTheRipper/issues/2961","id":278944244,"number":2961,"title":"MinGW build warnings","user":{"login":"magnumripper","id":1268598,"avatar_url":"https://avatars3.githubusercontent.com/u/1268598?v=4","gravatar_id":"","url":"https://api.github.com/users/magnumripper","html_url":"https://github.com/magnumripper","followers_url":"https://api.github.com/users/magnumripper/followers","following_url":"https://api.github.com/users/magnumripper/following{/other_user}","gists_url":"https://api.github.com/users/magnumripper/gists{/gist_id}","starred_url":"https://api.github.com/users/magnumripper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magnumripper/subscriptions","organizations_url":"https://api.github.com/users/magnumripper/orgs","repos_url":"https://api.github.com/users/magnumripper/repos","events_url":"https://api.github.com/users/magnumripper/events{/privacy}","received_events_url":"https://api.github.com/users/magnumripper/received_events","type":"User","site_admin":false},"labels":[{"id":51606860,"url":"https://api.github.com/repos/magnumripper/JohnTheRipper/labels/bug","name":"bug","color":"e11d21","default":true}],"state":"open","locked":false,"assignee":{"login":"jfoug","id":1270024,"avatar_url":"https://avatars0.githubusercontent.com/u/1270024?v=4","gravatar_id":"","url":"https://api.github.com/users/jfoug","html_url":"https://github.com/jfoug","followers_url":"https://api.github.com/users/jfoug/followers","following_url":"https://api.github.com/users/jfoug/following{/other_user}","gists_url":"https://api.github.com/users/jfoug/gists{/gist_id}","starred_url":"https://api.github.com/users/jfoug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfoug/subscriptions","organizations_url":"https://api.github.com/users/jfoug/orgs","repos_url":"https://api.github.com/users/jfoug/repos","events_url":"https://api.github.com/users/jfoug/events{/privacy}","received_events_url":"https://api.github.com/users/jfoug/received_events","type":"User","site_admin":false},"assignees":[{"login":"jfoug","id":1270024,"avatar_url":"https://avatars0.githubusercontent.com/u/1270024?v=4","gravatar_id":"","url":"https://api.github.com/users/jfoug","html_url":"https://github.com/jfoug","followers_url":"https://api.github.com/users/jfoug/followers","following_url":"https://api.github.com/users/jfoug/following{/other_user}","gists_url":"https://api.github.com/users/jfoug/gists{/gist_id}","starred_url":"https://api.github.com/users/jfoug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfoug/subscriptions","organizations_url":"https://api.github.com/users/jfoug/orgs","repos_url":"https://api.github.com/users/jfoug/repos","events_url":"https://api.github.com/users/jfoug/events{/privacy}","received_events_url":"https://api.github.com/users/jfoug/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2017-12-04T10:28:29Z","updated_at":"2017-12-04T10:39:20Z","closed_at":null,"author_association":"OWNER","body":"MinGW builds puke dozens of build warnings due to incorrect macro definitions in jumbo.h An example:\r\n```\r\nrar2john.c: In function 'process_file':\r\nrar2john.c:353:12: warning: format '%u' expects argument of type 'unsigned int', but argument 4 has type 'long long unsigned int' [-Wformat=]\r\n            \"! HEAD_SIZE: %d, PACK_SIZE: \"LLu\", UNP_SIZE: \"LLu\"\\n\",\r\n            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\r\nrar2john.c:355:12:\r\n            (unsigned long long)file_header_pack_size,\r\n            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\r\nIn file included from rar2john.c:56:0:\r\njumbo.h:370:18: note: format string is defined here\r\n #define LLu \"%I64u\"\r\n              ~~~~^\r\n              %I64llu\r\n```\r\nSo we print an unsigned long to LLu, which is correct, but then it translates to %I64u which ends up as %u... not correct. I guess the last line hints about a correct one being %I64llu."},"comment":{"url":"https://api.github.com/repos/magnumripper/JohnTheRipper/issues/comments/348924154","html_url":"https://github.com/magnumripper/JohnTheRipper/issues/2961#issuecomment-348924154","issue_url":"https://api.github.com/repos/magnumripper/JohnTheRipper/issues/2961","id":348924154,"user":{"login":"jfoug","id":1270024,"avatar_url":"https://avatars0.githubusercontent.com/u/1270024?v=4","gravatar_id":"","url":"https://api.github.com/users/jfoug","html_url":"https://github.com/jfoug","followers_url":"https://api.github.com/users/jfoug/followers","following_url":"https://api.github.com/users/jfoug/following{/other_user}","gists_url":"https://api.github.com/users/jfoug/gists{/gist_id}","starred_url":"https://api.github.com/users/jfoug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfoug/subscriptions","organizations_url":"https://api.github.com/users/jfoug/orgs","repos_url":"https://api.github.com/users/jfoug/repos","events_url":"https://api.github.com/users/jfoug/events{/privacy}","received_events_url":"https://api.github.com/users/jfoug/received_events","type":"User","site_admin":false},"created_at":"2017-12-04T10:39:20Z","updated_at":"2017-12-04T10:39:20Z","author_association":"COLLABORATOR","body":"This is a new perversion in mingw.  Mingw used to follow vc. VC only handled %I64type\r\n\r\nNow vc handles %lltype (just like unix), but mingw chose to go it on their own, jackasses.   One of the reasons I abandoned mingw years ago, and simply use cygwin.\r\n\r\nmingw simply chose to stop supporting the original non-standard way they Were doing things, and built a whole new non-standard way to do it, at the same time changing the original concept of the first non-standard method.  Boneheads :(\r\n\r\nI am not supporting this.   I know it was added for build bots, to do an 'automatic' build job.  But someone else is going to have to support this, if this is what is wanted.   I have never been overly happy about using Fedora as  a cross compiler on this type build.  "}}
{"actor":{"display_login":"jfoug"}}