{"push_id":1917099205,"size":13,"distinct_size":13,"ref":"refs/heads/dev-wip","head":"acce999a50d5046b1169eba9acdd74d8385c7861","before":"876cc01cdb03e86a1a0d921018924dfcabd1f021","commits":[{"sha":"1556ea119a5492dbf338b4879911a9badb00bfce","author":{"name":"Luca Favatella","email":"cc6b8f0a4ff75d3880209983dcb14324edb1d881@erlang-solutions.com"},"message":"Delete unused module `top`\n\nProcess for module `top` is not instantiated in any supervision tree.","distinct":true,"url":"https://api.github.com/repos/lucafavatella/testnet/commits/1556ea119a5492dbf338b4879911a9badb00bfce"},{"sha":"84a7808851fb8a5ae4423c928049eba9db5d600d","author":{"name":"Luca Favatella","email":"cc6b8f0a4ff75d3880209983dcb14324edb1d881@erlang-solutions.com"},"message":"Refactor `block_hashes`\n\n* Delete test, because only testing OTP module `gb_sets`;\n\n* Keep as separate gen_server because called from two processes - even\n  if unlikely to be concurrent:\n\n  * By process `tx_pool` - when it initializes chain at its startup;\n\n  * By process `block_absorber` - when absorbing block.\n\n* Log unknown requests;\n\n* Specify types;\n\n* Refactor following [gen_server template in\n  OTP](https://github.com/erlang/otp/blob/OTP-20.0.2/lib/tools/emacs/erlang-skels.el#L460-L572).","distinct":true,"url":"https://api.github.com/repos/lucafavatella/testnet/commits/84a7808851fb8a5ae4423c928049eba9db5d600d"},{"sha":"7ee6cbb03a1108d584c9eed0a38598351955862e","author":{"name":"Luca Favatella","email":"cc6b8f0a4ff75d3880209983dcb14324edb1d881@erlang-solutions.com"},"message":"Place persisting and retrieaval of block in same module\n\n... as refactoring for the sake of readability.\n\n`block_absorber:do_save/1` was called by:\n\n* `block:initialize_chain/0`, called by `tx_pool` init, called by\n  `testnet_sup`;\n\n* `block_absorber:absorb_internal/1`, called by:\n  * `handle_call` in `block_absorber`;\n  * `handle_cast` in `block_absorber`.","distinct":true,"url":"https://api.github.com/repos/lucafavatella/testnet/commits/7ee6cbb03a1108d584c9eed0a38598351955862e"},{"sha":"24fca123601a70b90e853d1db53a5100738da350","author":{"name":"Luca Favatella","email":"cc6b8f0a4ff75d3880209983dcb14324edb1d881@erlang-solutions.com"},"message":"Document node-local static model of blocks","distinct":true,"url":"https://api.github.com/repos/lucafavatella/testnet/commits/24fca123601a70b90e853d1db53a5100738da350"},{"sha":"f134cfa8f36596cfba902d77d73cd4e5d555147c","author":{"name":"Luca Favatella","email":"cc6b8f0a4ff75d3880209983dcb14324edb1d881@erlang-solutions.com"},"message":"XXX TODO Add unit test in trie dep GCing empty tree --- Garbage collect proof of burn tree even if not used yet\n\nAlso restore comment close to code.","distinct":true,"url":"https://api.github.com/repos/lucafavatella/testnet/commits/f134cfa8f36596cfba902d77d73cd4e5d555147c"},{"sha":"c57cc1ec2567e22817ef7b54855b4db3901bd3cc","author":{"name":"Luca Favatella","email":"cc6b8f0a4ff75d3880209983dcb14324edb1d881@erlang-solutions.com"},"message":"XXX Misc refactoring","distinct":true,"url":"https://api.github.com/repos/lucafavatella/testnet/commits/c57cc1ec2567e22817ef7b54855b4db3901bd3cc"},{"sha":"4562a6ad81a66a88c9d5eacc2f3e3c3b239c3609","author":{"name":"Luca Favatella","email":"cc6b8f0a4ff75d3880209983dcb14324edb1d881@erlang-solutions.com"},"message":"XXX DONOTCOMMIT 255 Check documented sizes","distinct":true,"url":"https://api.github.com/repos/lucafavatella/testnet/commits/4562a6ad81a66a88c9d5eacc2f3e3c3b239c3609"},{"sha":"71bae0ede1041c516c3ce217dd90639f14d4a48b","author":{"name":"Luca Favatella","email":"cc6b8f0a4ff75d3880209983dcb14324edb1d881@erlang-solutions.com"},"message":"XXX Force python2 for case when virtualenv was installed with broken python\n\nFrom https://virtualenv.pypa.io/en/latest/reference/#cmdoption-p:\n\n> ... The default is the interpreter that virtualenv was installed\n> with ...\n\nWhen running `make nose-env && make tests` symptom was:\n```\n...\nmake python-tests\nnose.config: INFO: Ignoring files matching ['^\\\\.', '^_', '^setup\\\\.py$']\nFailure: ModuleNotFoundError (No module named 'base') ... ERROR\n...\nFailure: ModuleNotFoundError (No module named 'swagger') ... ERROR\n...\n```\n\nAlso delete unused PYTHON variable as it may mislead.","distinct":true,"url":"https://api.github.com/repos/lucafavatella/testnet/commits/71bae0ede1041c516c3ce217dd90639f14d4a48b"},{"sha":"4e753685fc190906d2b52242b62efadadd9f25de","author":{"name":"Luca Favatella","email":"cc6b8f0a4ff75d3880209983dcb14324edb1d881@erlang-solutions.com"},"message":"XXX Prefer fully qualified name for easying connection on MacOS","distinct":true,"url":"https://api.github.com/repos/lucafavatella/testnet/commits/4e753685fc190906d2b52242b62efadadd9f25de"},{"sha":"e268f4e0b667dd9e2a34ba3d13dbf06edc7e0730","author":{"name":"Luca Favatella","email":"cc6b8f0a4ff75d3880209983dcb14324edb1d881@erlang-solutions.com"},"message":"XXX Easy running observer and debugger","distinct":true,"url":"https://api.github.com/repos/lucafavatella/testnet/commits/e268f4e0b667dd9e2a34ba3d13dbf06edc7e0730"},{"sha":"084ae3e3588c22b87bc1fc98e8ed0f49368972cb","author":{"name":"Luca Favatella","email":"cc6b8f0a4ff75d3880209983dcb14324edb1d881@erlang-solutions.com"},"message":"XXX DEVONLY Always print logs on CI","distinct":true,"url":"https://api.github.com/repos/lucafavatella/testnet/commits/084ae3e3588c22b87bc1fc98e8ed0f49368972cb"},{"sha":"445bc36c55a03cbab30ca39bfcbe35d69b88974a","author":{"name":"Luca Favatella","email":"cc6b8f0a4ff75d3880209983dcb14324edb1d881@erlang-solutions.com"},"message":"XXX 255 Document Merkle tree roots and ids","distinct":true,"url":"https://api.github.com/repos/lucafavatella/testnet/commits/445bc36c55a03cbab30ca39bfcbe35d69b88974a"},{"sha":"acce999a50d5046b1169eba9acdd74d8385c7861","author":{"name":"Luca Favatella","email":"cc6b8f0a4ff75d3880209983dcb14324edb1d881@erlang-solutions.com"},"message":"XXX Prefer Luca's fork of trie - for testing it","distinct":true,"url":"https://api.github.com/repos/lucafavatella/testnet/commits/acce999a50d5046b1169eba9acdd74d8385c7861"}]}
{"actor":{"display_login":"lucafavatella"}}