{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/19584","repository_url":"https://api.github.com/repos/cms-sw/cmssw","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/19584/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/19584/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/19584/events","html_url":"https://github.com/cms-sw/cmssw/pull/19584","id":240947669,"number":19584,"title":"Upgrades to HIPAlignmentAlgorithm functionality (part of May-July 2017 tracker alignment campaign for pixel/strips alignment)","user":{"login":"usarica","id":5451712,"avatar_url":"https://avatars1.githubusercontent.com/u/5451712?v=4","gravatar_id":"","url":"https://api.github.com/users/usarica","html_url":"https://github.com/usarica","followers_url":"https://api.github.com/users/usarica/followers","following_url":"https://api.github.com/users/usarica/following{/other_user}","gists_url":"https://api.github.com/users/usarica/gists{/gist_id}","starred_url":"https://api.github.com/users/usarica/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/usarica/subscriptions","organizations_url":"https://api.github.com/users/usarica/orgs","repos_url":"https://api.github.com/users/usarica/repos","events_url":"https://api.github.com/users/usarica/events{/privacy}","received_events_url":"https://api.github.com/users/usarica/received_events","type":"User","site_admin":false},"labels":[{"id":52881463,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/alca-pending","name":"alca-pending","color":"fbca04","default":false},{"id":88653795,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-pending","name":"comparison-pending","color":"fbca04","default":false},{"id":52881721,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/geometry-pending","name":"geometry-pending","color":"fbca04","default":false},{"id":56953091,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04","default":false},{"id":53167770,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"eb6420","default":false},{"id":52820010,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/reconstruction-pending","name":"reconstruction-pending","color":"fbca04","default":false},{"id":170521617,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-started","name":"tests-started","color":"eb6420","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/69","html_url":"https://github.com/cms-sw/cmssw/milestone/69","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/69/labels","id":2604328,"number":69,"title":"CMSSW_9_3_X","description":"","creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars3.githubusercontent.com/u/4115138?v=4","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":105,"closed_issues":243,"state":"open","created_at":"2017-06-26T12:15:20Z","updated_at":"2017-07-20T11:38:26Z","due_on":null,"closed_at":null},"comments":45,"created_at":"2017-07-06T12:56:55Z","updated_at":"2017-07-20T14:10:12Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/19584","html_url":"https://github.com/cms-sw/cmssw/pull/19584","diff_url":"https://github.com/cms-sw/cmssw/pull/19584.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/19584.patch"},"body":"Motivation:\r\n- The submitted jobs often required the submitter to watch them, and submission involved steps that could be automatized.\r\n- Alignment starting from slightly different conditions (GT, extra loads to GT) required extra intermediate steps\r\n1) Re-organized batchHippy and configureHippy\r\n2) Implemented an option parser class\r\n3) Changes were propagated to the templates cfg files that reside in python. Flexibility is given to change this directory, and the name of some of these files.\r\n- Hardcoded formula for track eta-dependent reweighting of chi-squared was present in the C++ code\r\n1) Option migrated to the cfi file, the exact formula string is kept in a commented line in align cfg.\r\n- A tight max. relative parameter error cut was present and was found to be ineffective\r\n1) Option defaulted to -1 everywhere\r\n- Alignable-specific cuts were added.\r\n- Per-alignable reweighting of chi-square based on different data samples is now supported as another way to reweight (not based on tracks but actually on hits count in the particular alignable).\r\n- The algorithm did not support the alignment of surface deformations. This feature is now supported.\r\n1) Additional options in the cfi file. Configuration example in common cfg in python/ (but disabled)\r\n2) Some revision and rearrangement was needed in HIPAlignmentAlgortihm, HIPUserVariables. New container classes were also added for the alignable-specific cuts.\r\n3) Alignment of surface deformations made optional through a flag in batchHippy.\r\n\r\nChecks: \r\n- Checks were done running different alignments with the pixel and strips at module, module unit or higher level alignments as part of the (ongoing) tracker alignment campaign.\r\n- See these slides for a quick overview of items implemented and checks done:\r\nhttps://indico.cern.ch/event/624094/contributions/2627981/attachments/1476471/2287406/20170614.pdf\r\nhttps://indico.cern.ch/event/624094/contributions/2627967/attachments/1476540/2287679/hpvalidation.pdf\r\nhttps://indico.cern.ch/event/649295/contributions/2653665/attachments/1488080/2312139/20170705.pdf\r\n\r\nNotes\r\n- Rebased on top of the commits in PR #19583 (includes #19541) because these changes are essential for the HIPAlignmentAlgorithm to function properly."},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/316715292","html_url":"https://github.com/cms-sw/cmssw/pull/19584#issuecomment-316715292","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/19584","id":316715292,"user":{"login":"cmsbuild","id":4170616,"avatar_url":"https://avatars1.githubusercontent.com/u/4170616?v=4","gravatar_id":"","url":"https://api.github.com/users/cmsbuild","html_url":"https://github.com/cmsbuild","followers_url":"https://api.github.com/users/cmsbuild/followers","following_url":"https://api.github.com/users/cmsbuild/following{/other_user}","gists_url":"https://api.github.com/users/cmsbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/cmsbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmsbuild/subscriptions","organizations_url":"https://api.github.com/users/cmsbuild/orgs","repos_url":"https://api.github.com/users/cmsbuild/repos","events_url":"https://api.github.com/users/cmsbuild/events{/privacy}","received_events_url":"https://api.github.com/users/cmsbuild/received_events","type":"User","site_admin":false},"created_at":"2017-07-20T14:10:12Z","updated_at":"2017-07-20T14:10:12Z","body":"+1\nTested at: 3bce98c82067a3ad76e40bf567cdb3e0dd2a0392\nhttps://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19584/21638/summary.html\n\nThe following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: \nhttps://github.com/cms-sw/cmssw/commit/e332c1da3835abea2691b6ce30994ec42f1a844d\nYou can see more details here:\nhttps://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19584/21638/git-log-recent-commits\nhttps://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19584/21638/git-merge-result\n"}}
{"actor":{"display_login":"cmsbuild"}}