{"action":"created","comment":{"url":"https://api.github.com/repos/apache/flink/pulls/comments/146573737","pull_request_review_id":71534418,"id":146573737,"diff_hunk":"@@ -116,8 +116,15 @@ public static JobManagerServices fromConfiguration(\n \t\tfinal String classLoaderResolveOrder =\n \t\t\tconfig.getString(CoreOptions.CLASSLOADER_RESOLVE_ORDER);\n \n+\t\tfinal String alwaysParentFirstLoaderString =\n+\t\t\tconfig.getString(CoreOptions.ALWAYS_PARENT_FIRST_LOADER);\n+\t\tfinal String[] alwaysParentFirstLoaderPatterns = alwaysParentFirstLoaderString.split(\",\");\n+\n \t\tfinal BlobLibraryCacheManager libraryCacheManager =\n-\t\t\tnew BlobLibraryCacheManager(blobServer, FlinkUserCodeClassLoaders.ResolveOrder.fromString(classLoaderResolveOrder));\n+\t\t\tnew BlobLibraryCacheManager(\n+\t\t\t\tblobServer,\n+\t\t\t\tFlinkUserCodeClassLoaders.ResolveOrder.fromString(classLoaderResolveOrder),","path":"flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobManagerServices.java","position":12,"original_position":12,"commit_id":"dda0dc6247e53724177d7754ae7add91f0697082","original_commit_id":"dda0dc6247e53724177d7754ae7add91f0697082","user":{"login":"StephanEwen","id":1727146,"avatar_url":"https://avatars3.githubusercontent.com/u/1727146?v=4","gravatar_id":"","url":"https://api.github.com/users/StephanEwen","html_url":"https://github.com/StephanEwen","followers_url":"https://api.github.com/users/StephanEwen/followers","following_url":"https://api.github.com/users/StephanEwen/following{/other_user}","gists_url":"https://api.github.com/users/StephanEwen/gists{/gist_id}","starred_url":"https://api.github.com/users/StephanEwen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StephanEwen/subscriptions","organizations_url":"https://api.github.com/users/StephanEwen/orgs","repos_url":"https://api.github.com/users/StephanEwen/repos","events_url":"https://api.github.com/users/StephanEwen/events{/privacy}","received_events_url":"https://api.github.com/users/StephanEwen/received_events","type":"User","site_admin":false},"body":"Okay, that works.","created_at":"2017-10-24T14:15:01Z","updated_at":"2017-10-24T14:15:02Z","html_url":"https://github.com/apache/flink/pull/4891#discussion_r146573737","pull_request_url":"https://api.github.com/repos/apache/flink/pulls/4891","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/comments/146573737"},"html":{"href":"https://github.com/apache/flink/pull/4891#discussion_r146573737"},"pull_request":{"href":"https://api.github.com/repos/apache/flink/pulls/4891"}},"in_reply_to_id":146336888},"pull_request":{"url":"https://api.github.com/repos/apache/flink/pulls/4891","id":148157914,"html_url":"https://github.com/apache/flink/pull/4891","diff_url":"https://github.com/apache/flink/pull/4891.diff","patch_url":"https://github.com/apache/flink/pull/4891.patch","issue_url":"https://api.github.com/repos/apache/flink/issues/4891","number":4891,"state":"open","locked":false,"title":" [FLINK-7669] Always load Flink classes via parent ClassLoader","user":{"login":"aljoscha","id":68551,"avatar_url":"https://avatars1.githubusercontent.com/u/68551?v=4","gravatar_id":"","url":"https://api.github.com/users/aljoscha","html_url":"https://github.com/aljoscha","followers_url":"https://api.github.com/users/aljoscha/followers","following_url":"https://api.github.com/users/aljoscha/following{/other_user}","gists_url":"https://api.github.com/users/aljoscha/gists{/gist_id}","starred_url":"https://api.github.com/users/aljoscha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aljoscha/subscriptions","organizations_url":"https://api.github.com/users/aljoscha/orgs","repos_url":"https://api.github.com/users/aljoscha/repos","events_url":"https://api.github.com/users/aljoscha/events{/privacy}","received_events_url":"https://api.github.com/users/aljoscha/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-10-23T15:07:21Z","updated_at":"2017-10-24T14:15:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7bb5161d329a791dd674e4d3369d0cf40f582775","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/flink/pulls/4891/commits","review_comments_url":"https://api.github.com/repos/apache/flink/pulls/4891/comments","review_comment_url":"https://api.github.com/repos/apache/flink/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/flink/issues/4891/comments","statuses_url":"https://api.github.com/repos/apache/flink/statuses/dda0dc6247e53724177d7754ae7add91f0697082","head":{"label":"aljoscha:jira-7669-classloader-fix-flink-always-parent","ref":"jira-7669-classloader-fix-flink-always-parent","sha":"dda0dc6247e53724177d7754ae7add91f0697082","user":{"login":"aljoscha","id":68551,"avatar_url":"https://avatars1.githubusercontent.com/u/68551?v=4","gravatar_id":"","url":"https://api.github.com/users/aljoscha","html_url":"https://github.com/aljoscha","followers_url":"https://api.github.com/users/aljoscha/followers","following_url":"https://api.github.com/users/aljoscha/following{/other_user}","gists_url":"https://api.github.com/users/aljoscha/gists{/gist_id}","starred_url":"https://api.github.com/users/aljoscha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aljoscha/subscriptions","organizations_url":"https://api.github.com/users/aljoscha/orgs","repos_url":"https://api.github.com/users/aljoscha/repos","events_url":"https://api.github.com/users/aljoscha/events{/privacy}","received_events_url":"https://api.github.com/users/aljoscha/received_events","type":"User","site_admin":false},"repo":{"id":22066189,"name":"flink","full_name":"aljoscha/flink","owner":{"login":"aljoscha","id":68551,"avatar_url":"https://avatars1.githubusercontent.com/u/68551?v=4","gravatar_id":"","url":"https://api.github.com/users/aljoscha","html_url":"https://github.com/aljoscha","followers_url":"https://api.github.com/users/aljoscha/followers","following_url":"https://api.github.com/users/aljoscha/following{/other_user}","gists_url":"https://api.github.com/users/aljoscha/gists{/gist_id}","starred_url":"https://api.github.com/users/aljoscha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aljoscha/subscriptions","organizations_url":"https://api.github.com/users/aljoscha/orgs","repos_url":"https://api.github.com/users/aljoscha/repos","events_url":"https://api.github.com/users/aljoscha/events{/privacy}","received_events_url":"https://api.github.com/users/aljoscha/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aljoscha/flink","description":"Mirror of Apache Flink","fork":true,"url":"https://api.github.com/repos/aljoscha/flink","forks_url":"https://api.github.com/repos/aljoscha/flink/forks","keys_url":"https://api.github.com/repos/aljoscha/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aljoscha/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aljoscha/flink/teams","hooks_url":"https://api.github.com/repos/aljoscha/flink/hooks","issue_events_url":"https://api.github.com/repos/aljoscha/flink/issues/events{/number}","events_url":"https://api.github.com/repos/aljoscha/flink/events","assignees_url":"https://api.github.com/repos/aljoscha/flink/assignees{/user}","branches_url":"https://api.github.com/repos/aljoscha/flink/branches{/branch}","tags_url":"https://api.github.com/repos/aljoscha/flink/tags","blobs_url":"https://api.github.com/repos/aljoscha/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aljoscha/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aljoscha/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/aljoscha/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aljoscha/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/aljoscha/flink/languages","stargazers_url":"https://api.github.com/repos/aljoscha/flink/stargazers","contributors_url":"https://api.github.com/repos/aljoscha/flink/contributors","subscribers_url":"https://api.github.com/repos/aljoscha/flink/subscribers","subscription_url":"https://api.github.com/repos/aljoscha/flink/subscription","commits_url":"https://api.github.com/repos/aljoscha/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/aljoscha/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/aljoscha/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/aljoscha/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/aljoscha/flink/contents/{+path}","compare_url":"https://api.github.com/repos/aljoscha/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aljoscha/flink/merges","archive_url":"https://api.github.com/repos/aljoscha/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aljoscha/flink/downloads","issues_url":"https://api.github.com/repos/aljoscha/flink/issues{/number}","pulls_url":"https://api.github.com/repos/aljoscha/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/aljoscha/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/aljoscha/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aljoscha/flink/labels{/name}","releases_url":"https://api.github.com/repos/aljoscha/flink/releases{/id}","deployments_url":"https://api.github.com/repos/aljoscha/flink/deployments","created_at":"2014-07-21T13:51:54Z","updated_at":"2016-11-04T09:18:59Z","pushed_at":"2017-10-24T13:07:54Z","git_url":"git://github.com/aljoscha/flink.git","ssh_url":"git@github.com:aljoscha/flink.git","clone_url":"https://github.com/aljoscha/flink.git","svn_url":"https://github.com/aljoscha/flink","homepage":null,"size":133569,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"e49bc428c396ffec501f13ba5fb9337fb4191818","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":20587599,"name":"flink","full_name":"apache/flink","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/flink","description":"Mirror of Apache Flink","fork":false,"url":"https://api.github.com/repos/apache/flink","forks_url":"https://api.github.com/repos/apache/flink/forks","keys_url":"https://api.github.com/repos/apache/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/flink/teams","hooks_url":"https://api.github.com/repos/apache/flink/hooks","issue_events_url":"https://api.github.com/repos/apache/flink/issues/events{/number}","events_url":"https://api.github.com/repos/apache/flink/events","assignees_url":"https://api.github.com/repos/apache/flink/assignees{/user}","branches_url":"https://api.github.com/repos/apache/flink/branches{/branch}","tags_url":"https://api.github.com/repos/apache/flink/tags","blobs_url":"https://api.github.com/repos/apache/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/flink/languages","stargazers_url":"https://api.github.com/repos/apache/flink/stargazers","contributors_url":"https://api.github.com/repos/apache/flink/contributors","subscribers_url":"https://api.github.com/repos/apache/flink/subscribers","subscription_url":"https://api.github.com/repos/apache/flink/subscription","commits_url":"https://api.github.com/repos/apache/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/flink/contents/{+path}","compare_url":"https://api.github.com/repos/apache/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/flink/merges","archive_url":"https://api.github.com/repos/apache/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/flink/downloads","issues_url":"https://api.github.com/repos/apache/flink/issues{/number}","pulls_url":"https://api.github.com/repos/apache/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/flink/labels{/name}","releases_url":"https://api.github.com/repos/apache/flink/releases{/id}","deployments_url":"https://api.github.com/repos/apache/flink/deployments","created_at":"2014-06-07T07:00:10Z","updated_at":"2017-10-24T14:07:03Z","pushed_at":"2017-10-24T14:14:29Z","git_url":"git://github.com/apache/flink.git","ssh_url":"git@github.com:apache/flink.git","clone_url":"https://github.com/apache/flink.git","svn_url":"https://github.com/apache/flink","homepage":null,"size":135977,"stargazers_count":2830,"watchers_count":2830,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1959,"mirror_url":"git://git.apache.org/flink.git","archived":false,"open_issues_count":333,"forks":1959,"open_issues":333,"watchers":2830,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/4891"},"html":{"href":"https://github.com/apache/flink/pull/4891"},"issue":{"href":"https://api.github.com/repos/apache/flink/issues/4891"},"comments":{"href":"https://api.github.com/repos/apache/flink/issues/4891/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/flink/pulls/4891/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/flink/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/flink/pulls/4891/commits"},"statuses":{"href":"https://api.github.com/repos/apache/flink/statuses/dda0dc6247e53724177d7754ae7add91f0697082"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"StephanEwen"}}