{"action":"created","issue":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/16945","repository_url":"https://api.github.com/repos/joomla/joomla-cms","labels_url":"https://api.github.com/repos/joomla/joomla-cms/issues/16945/labels{/name}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/16945/comments","events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/16945/events","html_url":"https://github.com/joomla/joomla-cms/pull/16945","id":240100518,"number":16945,"title":"Add filter by Tag to mod_article_category","user":{"login":"hans2103","id":639822,"avatar_url":"https://avatars2.githubusercontent.com/u/639822?v=4","gravatar_id":"","url":"https://api.github.com/users/hans2103","html_url":"https://github.com/hans2103","followers_url":"https://api.github.com/users/hans2103/followers","following_url":"https://api.github.com/users/hans2103/following{/other_user}","gists_url":"https://api.github.com/users/hans2103/gists{/gist_id}","starred_url":"https://api.github.com/users/hans2103/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hans2103/subscriptions","organizations_url":"https://api.github.com/users/hans2103/orgs","repos_url":"https://api.github.com/users/hans2103/repos","events_url":"https://api.github.com/users/hans2103/events{/privacy}","received_events_url":"https://api.github.com/users/hans2103/received_events","type":"User","site_admin":false},"labels":[{"id":32136390,"url":"https://api.github.com/repos/joomla/joomla-cms/labels/New%20Feature","name":"New Feature","color":"e102d8","default":false},{"id":60721348,"url":"https://api.github.com/repos/joomla/joomla-cms/labels/PR-staging","name":"PR-staging","color":"c7def8","default":false},{"id":32990672,"url":"https://api.github.com/repos/joomla/joomla-cms/labels/RTC","name":"RTC","color":"009800","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/joomla/joomla-cms/milestones/19","html_url":"https://github.com/joomla/joomla-cms/milestone/19","labels_url":"https://api.github.com/repos/joomla/joomla-cms/milestones/19/labels","id":2270567,"number":19,"title":"Joomla 3.8.0","description":"","creator":{"login":"zero-24","id":2596554,"avatar_url":"https://avatars2.githubusercontent.com/u/2596554?v=4","gravatar_id":"","url":"https://api.github.com/users/zero-24","html_url":"https://github.com/zero-24","followers_url":"https://api.github.com/users/zero-24/followers","following_url":"https://api.github.com/users/zero-24/following{/other_user}","gists_url":"https://api.github.com/users/zero-24/gists{/gist_id}","starred_url":"https://api.github.com/users/zero-24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zero-24/subscriptions","organizations_url":"https://api.github.com/users/zero-24/orgs","repos_url":"https://api.github.com/users/zero-24/repos","events_url":"https://api.github.com/users/zero-24/events{/privacy}","received_events_url":"https://api.github.com/users/zero-24/received_events","type":"User","site_admin":false},"open_issues":20,"closed_issues":100,"state":"open","created_at":"2017-01-23T08:05:30Z","updated_at":"2017-07-25T23:24:14Z","due_on":null,"closed_at":null},"comments":8,"created_at":"2017-07-03T08:26:19Z","updated_at":"2017-07-25T23:35:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/16945","html_url":"https://github.com/joomla/joomla-cms/pull/16945","diff_url":"https://github.com/joomla/joomla-cms/pull/16945.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/16945.patch"},"body":"Pull Request for missing feature\r\n\r\n### Summary of Changes\r\nThis Pull Request add the option to filter by tag.\r\n- When you create a menu item for Category Blog you can select both Category and Tag.\r\n- When you create the module mod_article_category you cannot filter by Tag. \r\nThis pull request adds the ability to filter by tag too. \r\n\r\n### Testing Instructions\r\n- Have com_content items with tags\r\n- Create a module mod_article_category\r\n- - assign to a visible module position\r\n- - select category to filter the content\r\n- - show X amount of items to display\r\n- - select tag to filter... oh boy... there is no tag filter\r\n\r\napply patch\r\n- Refresh backend\r\n- Open created module\r\n- - select tag to filter... yes... there is the option to filter by tag\r\n\r\n### Expected result\r\nBefore patch\r\n- Refresh frontend and notice X amount of items from a selected category. \r\n\r\nAfter patch\r\n- Refresh frontend and notice X amount of items from a selected category and filtered by tag\r\n\r\n### Documentation Changes Required\r\nBe sure you have content items with tags assigned to them. "},"comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments/317903523","html_url":"https://github.com/joomla/joomla-cms/pull/16945#issuecomment-317903523","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/16945","id":317903523,"user":{"login":"mbabker","id":368545,"avatar_url":"https://avatars2.githubusercontent.com/u/368545?v=4","gravatar_id":"","url":"https://api.github.com/users/mbabker","html_url":"https://github.com/mbabker","followers_url":"https://api.github.com/users/mbabker/followers","following_url":"https://api.github.com/users/mbabker/following{/other_user}","gists_url":"https://api.github.com/users/mbabker/gists{/gist_id}","starred_url":"https://api.github.com/users/mbabker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbabker/subscriptions","organizations_url":"https://api.github.com/users/mbabker/orgs","repos_url":"https://api.github.com/users/mbabker/repos","events_url":"https://api.github.com/users/mbabker/events{/privacy}","received_events_url":"https://api.github.com/users/mbabker/received_events","type":"User","site_admin":false},"created_at":"2017-07-25T23:35:32Z","updated_at":"2017-07-25T23:35:32Z","body":"This needs to be synced with staging before I can merge it.  We added a state filter to stop loading tags in the modules with https://github.com/joomla/joomla-cms/commit/008e5cd072119cfe49c5e5d4ec8369e5c064f2f9 and that is going to conflict with this PR."}}
{"actor":{"display_login":"mbabker"}}