{"action":"created","comment":{"url":"https://api.github.com/repos/angular/material2/pulls/comments/120228382","pull_request_review_id":42173444,"id":120228382,"diff_hunk":"@@ -105,7 +105,7 @@ export class ScrollDispatcher {\n   getScrollContainers(elementRef: ElementRef): Scrollable[] {\n     const scrollingContainers: Scrollable[] = [];\n \n-    this.scrollableReferences.forEach((subscription: Subscription, scrollable: Scrollable) => {\n+    this.scrollableReferences.forEach((_subscription: Subscription, scrollable: Scrollable) => {","path":"src/lib/core/overlay/scroll/scroll-dispatcher.ts","position":5,"original_position":5,"commit_id":"3e85d2a82a97b3dafd17a13647d86b47a29bc44b","original_commit_id":"3e85d2a82a97b3dafd17a13647d86b47a29bc44b","user":{"login":"jelbourn","id":838736,"avatar_url":"https://avatars0.githubusercontent.com/u/838736?v=3","gravatar_id":"","url":"https://api.github.com/users/jelbourn","html_url":"https://github.com/jelbourn","followers_url":"https://api.github.com/users/jelbourn/followers","following_url":"https://api.github.com/users/jelbourn/following{/other_user}","gists_url":"https://api.github.com/users/jelbourn/gists{/gist_id}","starred_url":"https://api.github.com/users/jelbourn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jelbourn/subscriptions","organizations_url":"https://api.github.com/users/jelbourn/orgs","repos_url":"https://api.github.com/users/jelbourn/repos","events_url":"https://api.github.com/users/jelbourn/events{/privacy}","received_events_url":"https://api.github.com/users/jelbourn/received_events","type":"User","site_admin":false},"body":"Change this to `this.scrollableReferences.keys().forEach(...)` ?","created_at":"2017-06-05T22:44:06Z","updated_at":"2017-06-05T22:55:26Z","html_url":"https://github.com/angular/material2/pull/4946#discussion_r120228382","pull_request_url":"https://api.github.com/repos/angular/material2/pulls/4946","_links":{"self":{"href":"https://api.github.com/repos/angular/material2/pulls/comments/120228382"},"html":{"href":"https://github.com/angular/material2/pull/4946#discussion_r120228382"},"pull_request":{"href":"https://api.github.com/repos/angular/material2/pulls/4946"}}},"pull_request":{"url":"https://api.github.com/repos/angular/material2/pulls/4946","id":123837133,"html_url":"https://github.com/angular/material2/pull/4946","diff_url":"https://github.com/angular/material2/pull/4946.diff","patch_url":"https://github.com/angular/material2/pull/4946.patch","issue_url":"https://api.github.com/repos/angular/material2/issues/4946","number":4946,"state":"open","locked":false,"title":"fix: make material work with noUnusedParameters","user":{"login":"DevVersion","id":4987015,"avatar_url":"https://avatars0.githubusercontent.com/u/4987015?v=3","gravatar_id":"","url":"https://api.github.com/users/DevVersion","html_url":"https://github.com/DevVersion","followers_url":"https://api.github.com/users/DevVersion/followers","following_url":"https://api.github.com/users/DevVersion/following{/other_user}","gists_url":"https://api.github.com/users/DevVersion/gists{/gist_id}","starred_url":"https://api.github.com/users/DevVersion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DevVersion/subscriptions","organizations_url":"https://api.github.com/users/DevVersion/orgs","repos_url":"https://api.github.com/users/DevVersion/repos","events_url":"https://api.github.com/users/DevVersion/events{/privacy}","received_events_url":"https://api.github.com/users/DevVersion/received_events","type":"User","site_admin":false},"body":"* Recently Angular core fixed most of their `noUnusedParameters` warnings in https://github.com/angular/angular/issues/15532 (this one is still left - https://github.com/angular/angular/issues/17131)\r\n* When using Angular with Material and the users has `noUnusedParameters` enabled the library will be checked and will throw right now.\r\n\r\n**Note**: I don't plan to add the `noUnusedParameters` to any build tsconfig files yet, because it would make the watching & live-reloading extremely bad. The `noUnusedParameters` should / can be tested on the CI in a follow-up.\r\n\r\nFixes #4443","created_at":"2017-06-03T09:56:34Z","updated_at":"2017-06-05T22:55:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"50cf99cbf524b03e90b8249a025d31c09cda9ec6","assignee":{"login":"jelbourn","id":838736,"avatar_url":"https://avatars0.githubusercontent.com/u/838736?v=3","gravatar_id":"","url":"https://api.github.com/users/jelbourn","html_url":"https://github.com/jelbourn","followers_url":"https://api.github.com/users/jelbourn/followers","following_url":"https://api.github.com/users/jelbourn/following{/other_user}","gists_url":"https://api.github.com/users/jelbourn/gists{/gist_id}","starred_url":"https://api.github.com/users/jelbourn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jelbourn/subscriptions","organizations_url":"https://api.github.com/users/jelbourn/orgs","repos_url":"https://api.github.com/users/jelbourn/repos","events_url":"https://api.github.com/users/jelbourn/events{/privacy}","received_events_url":"https://api.github.com/users/jelbourn/received_events","type":"User","site_admin":false},"assignees":[{"login":"jelbourn","id":838736,"avatar_url":"https://avatars0.githubusercontent.com/u/838736?v=3","gravatar_id":"","url":"https://api.github.com/users/jelbourn","html_url":"https://github.com/jelbourn","followers_url":"https://api.github.com/users/jelbourn/followers","following_url":"https://api.github.com/users/jelbourn/following{/other_user}","gists_url":"https://api.github.com/users/jelbourn/gists{/gist_id}","starred_url":"https://api.github.com/users/jelbourn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jelbourn/subscriptions","organizations_url":"https://api.github.com/users/jelbourn/orgs","repos_url":"https://api.github.com/users/jelbourn/repos","events_url":"https://api.github.com/users/jelbourn/events{/privacy}","received_events_url":"https://api.github.com/users/jelbourn/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/angular/material2/pulls/4946/commits","review_comments_url":"https://api.github.com/repos/angular/material2/pulls/4946/comments","review_comment_url":"https://api.github.com/repos/angular/material2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/material2/issues/4946/comments","statuses_url":"https://api.github.com/repos/angular/material2/statuses/3e85d2a82a97b3dafd17a13647d86b47a29bc44b","head":{"label":"DevVersion:fix/material-with-unused-locals","ref":"fix/material-with-unused-locals","sha":"3e85d2a82a97b3dafd17a13647d86b47a29bc44b","user":{"login":"DevVersion","id":4987015,"avatar_url":"https://avatars0.githubusercontent.com/u/4987015?v=3","gravatar_id":"","url":"https://api.github.com/users/DevVersion","html_url":"https://github.com/DevVersion","followers_url":"https://api.github.com/users/DevVersion/followers","following_url":"https://api.github.com/users/DevVersion/following{/other_user}","gists_url":"https://api.github.com/users/DevVersion/gists{/gist_id}","starred_url":"https://api.github.com/users/DevVersion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DevVersion/subscriptions","organizations_url":"https://api.github.com/users/DevVersion/orgs","repos_url":"https://api.github.com/users/DevVersion/repos","events_url":"https://api.github.com/users/DevVersion/events{/privacy}","received_events_url":"https://api.github.com/users/DevVersion/received_events","type":"User","site_admin":false},"repo":{"id":49230742,"name":"material2","full_name":"DevVersion/material2","owner":{"login":"DevVersion","id":4987015,"avatar_url":"https://avatars0.githubusercontent.com/u/4987015?v=3","gravatar_id":"","url":"https://api.github.com/users/DevVersion","html_url":"https://github.com/DevVersion","followers_url":"https://api.github.com/users/DevVersion/followers","following_url":"https://api.github.com/users/DevVersion/following{/other_user}","gists_url":"https://api.github.com/users/DevVersion/gists{/gist_id}","starred_url":"https://api.github.com/users/DevVersion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DevVersion/subscriptions","organizations_url":"https://api.github.com/users/DevVersion/orgs","repos_url":"https://api.github.com/users/DevVersion/repos","events_url":"https://api.github.com/users/DevVersion/events{/privacy}","received_events_url":"https://api.github.com/users/DevVersion/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DevVersion/material2","description":"Material Design components for Angular 2","fork":true,"url":"https://api.github.com/repos/DevVersion/material2","forks_url":"https://api.github.com/repos/DevVersion/material2/forks","keys_url":"https://api.github.com/repos/DevVersion/material2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DevVersion/material2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DevVersion/material2/teams","hooks_url":"https://api.github.com/repos/DevVersion/material2/hooks","issue_events_url":"https://api.github.com/repos/DevVersion/material2/issues/events{/number}","events_url":"https://api.github.com/repos/DevVersion/material2/events","assignees_url":"https://api.github.com/repos/DevVersion/material2/assignees{/user}","branches_url":"https://api.github.com/repos/DevVersion/material2/branches{/branch}","tags_url":"https://api.github.com/repos/DevVersion/material2/tags","blobs_url":"https://api.github.com/repos/DevVersion/material2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DevVersion/material2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DevVersion/material2/git/refs{/sha}","trees_url":"https://api.github.com/repos/DevVersion/material2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DevVersion/material2/statuses/{sha}","languages_url":"https://api.github.com/repos/DevVersion/material2/languages","stargazers_url":"https://api.github.com/repos/DevVersion/material2/stargazers","contributors_url":"https://api.github.com/repos/DevVersion/material2/contributors","subscribers_url":"https://api.github.com/repos/DevVersion/material2/subscribers","subscription_url":"https://api.github.com/repos/DevVersion/material2/subscription","commits_url":"https://api.github.com/repos/DevVersion/material2/commits{/sha}","git_commits_url":"https://api.github.com/repos/DevVersion/material2/git/commits{/sha}","comments_url":"https://api.github.com/repos/DevVersion/material2/comments{/number}","issue_comment_url":"https://api.github.com/repos/DevVersion/material2/issues/comments{/number}","contents_url":"https://api.github.com/repos/DevVersion/material2/contents/{+path}","compare_url":"https://api.github.com/repos/DevVersion/material2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DevVersion/material2/merges","archive_url":"https://api.github.com/repos/DevVersion/material2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DevVersion/material2/downloads","issues_url":"https://api.github.com/repos/DevVersion/material2/issues{/number}","pulls_url":"https://api.github.com/repos/DevVersion/material2/pulls{/number}","milestones_url":"https://api.github.com/repos/DevVersion/material2/milestones{/number}","notifications_url":"https://api.github.com/repos/DevVersion/material2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DevVersion/material2/labels{/name}","releases_url":"https://api.github.com/repos/DevVersion/material2/releases{/id}","deployments_url":"https://api.github.com/repos/DevVersion/material2/deployments","created_at":"2016-01-07T21:05:43Z","updated_at":"2016-10-26T16:55:18Z","pushed_at":"2017-06-05T22:08:17Z","git_url":"git://github.com/DevVersion/material2.git","ssh_url":"git@github.com:DevVersion/material2.git","clone_url":"https://github.com/DevVersion/material2.git","svn_url":"https://github.com/DevVersion/material2","homepage":"","size":5645,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"cebb516e9322f11507b91ad85fee98c5aff2d063","user":{"login":"angular","id":139426,"avatar_url":"https://avatars0.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":49016322,"name":"material2","full_name":"angular/material2","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars0.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/material2","description":"Material Design components for Angular","fork":false,"url":"https://api.github.com/repos/angular/material2","forks_url":"https://api.github.com/repos/angular/material2/forks","keys_url":"https://api.github.com/repos/angular/material2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/material2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/material2/teams","hooks_url":"https://api.github.com/repos/angular/material2/hooks","issue_events_url":"https://api.github.com/repos/angular/material2/issues/events{/number}","events_url":"https://api.github.com/repos/angular/material2/events","assignees_url":"https://api.github.com/repos/angular/material2/assignees{/user}","branches_url":"https://api.github.com/repos/angular/material2/branches{/branch}","tags_url":"https://api.github.com/repos/angular/material2/tags","blobs_url":"https://api.github.com/repos/angular/material2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/material2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/material2/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/material2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/material2/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/material2/languages","stargazers_url":"https://api.github.com/repos/angular/material2/stargazers","contributors_url":"https://api.github.com/repos/angular/material2/contributors","subscribers_url":"https://api.github.com/repos/angular/material2/subscribers","subscription_url":"https://api.github.com/repos/angular/material2/subscription","commits_url":"https://api.github.com/repos/angular/material2/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/material2/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/material2/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/material2/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/material2/contents/{+path}","compare_url":"https://api.github.com/repos/angular/material2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/material2/merges","archive_url":"https://api.github.com/repos/angular/material2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/material2/downloads","issues_url":"https://api.github.com/repos/angular/material2/issues{/number}","pulls_url":"https://api.github.com/repos/angular/material2/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/material2/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/material2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/material2/labels{/name}","releases_url":"https://api.github.com/repos/angular/material2/releases{/id}","deployments_url":"https://api.github.com/repos/angular/material2/deployments","created_at":"2016-01-04T18:50:02Z","updated_at":"2017-06-05T21:28:32Z","pushed_at":"2017-06-05T22:54:37Z","git_url":"git://github.com/angular/material2.git","ssh_url":"git@github.com:angular/material2.git","clone_url":"https://github.com/angular/material2.git","svn_url":"https://github.com/angular/material2","homepage":"https://material.angular.io/","size":5543,"stargazers_count":9054,"watchers_count":9054,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2046,"mirror_url":null,"open_issues_count":584,"forks":2046,"open_issues":584,"watchers":9054,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/material2/pulls/4946"},"html":{"href":"https://github.com/angular/material2/pull/4946"},"issue":{"href":"https://api.github.com/repos/angular/material2/issues/4946"},"comments":{"href":"https://api.github.com/repos/angular/material2/issues/4946/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/material2/pulls/4946/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/material2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/material2/pulls/4946/commits"},"statuses":{"href":"https://api.github.com/repos/angular/material2/statuses/3e85d2a82a97b3dafd17a13647d86b47a29bc44b"}}}}
{"actor":{"display_login":"jelbourn"}}