{"action":"created","comment":{"url":"https://api.github.com/repos/ansible/ansible/pulls/comments/131164210","pull_request_review_id":54118587,"id":131164210,"diff_hunk":"@@ -481,31 +481,31 @@ def _get_nodes_to_remove(self):\n \n \n def main():\n-    argument_spec = ec2_argument_spec()\n+    \"\"\" elasticache ansible module \"\"\"\n+    argument_spec             = ec2_argument_spec()\n     argument_spec.update(dict(\n-        state                 ={'required': True, 'choices': ['present', 'absent', 'rebooted']},\n-        name                  ={'required': True},\n-        engine                ={'required': False, 'default': 'memcached'},\n-        cache_engine_version  ={'required': False},\n-        node_type             ={'required': False, 'default': 'cache.m1.small'},\n-        num_nodes             ={'required': False, 'default': None, 'type': 'int'},\n+        state                 = {'required': True, 'choices': ['present', 'absent', 'rebooted']},","path":"lib/ansible/modules/cloud/amazon/elasticache.py","position":237,"original_position":237,"commit_id":"734c7d4d8824b464baf084b27b56b1f99a79b30f","original_commit_id":"734c7d4d8824b464baf084b27b56b1f99a79b30f","user":{"login":"memo42","id":3510139,"avatar_url":"https://avatars2.githubusercontent.com/u/3510139?v=4","gravatar_id":"","url":"https://api.github.com/users/memo42","html_url":"https://github.com/memo42","followers_url":"https://api.github.com/users/memo42/followers","following_url":"https://api.github.com/users/memo42/following{/other_user}","gists_url":"https://api.github.com/users/memo42/gists{/gist_id}","starred_url":"https://api.github.com/users/memo42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/memo42/subscriptions","organizations_url":"https://api.github.com/users/memo42/orgs","repos_url":"https://api.github.com/users/memo42/repos","events_url":"https://api.github.com/users/memo42/events{/privacy}","received_events_url":"https://api.github.com/users/memo42/received_events","type":"User","site_admin":false},"body":"OK, just thought it would be sooo much easier to read ;)","created_at":"2017-08-03T14:50:53Z","updated_at":"2017-08-03T14:50:53Z","html_url":"https://github.com/ansible/ansible/pull/27441#discussion_r131164210","pull_request_url":"https://api.github.com/repos/ansible/ansible/pulls/27441","_links":{"self":{"href":"https://api.github.com/repos/ansible/ansible/pulls/comments/131164210"},"html":{"href":"https://github.com/ansible/ansible/pull/27441#discussion_r131164210"},"pull_request":{"href":"https://api.github.com/repos/ansible/ansible/pulls/27441"}}},"pull_request":{"url":"https://api.github.com/repos/ansible/ansible/pulls/27441","id":133036078,"html_url":"https://github.com/ansible/ansible/pull/27441","diff_url":"https://github.com/ansible/ansible/pull/27441.diff","patch_url":"https://github.com/ansible/ansible/pull/27441.patch","issue_url":"https://api.github.com/repos/ansible/ansible/issues/27441","number":27441,"state":"open","locked":false,"title":"moved aws elasticache module to boto3","user":{"login":"memo42","id":3510139,"avatar_url":"https://avatars2.githubusercontent.com/u/3510139?v=4","gravatar_id":"","url":"https://api.github.com/users/memo42","html_url":"https://github.com/memo42","followers_url":"https://api.github.com/users/memo42/followers","following_url":"https://api.github.com/users/memo42/following{/other_user}","gists_url":"https://api.github.com/users/memo42/gists{/gist_id}","starred_url":"https://api.github.com/users/memo42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/memo42/subscriptions","organizations_url":"https://api.github.com/users/memo42/orgs","repos_url":"https://api.github.com/users/memo42/repos","events_url":"https://api.github.com/users/memo42/events{/privacy}","received_events_url":"https://api.github.com/users/memo42/received_events","type":"User","site_admin":false},"body":"##### SUMMARY\r\nto be able to implement new features I moved the module elasticache from boto to boto3\r\n\r\n\r\n##### ISSUE TYPE\r\n - Feature Pull Request\r\n\r\n##### COMPONENT NAME\r\n<!--- Name of the module/plugin/module/task -->\r\nelasticache\r\n##### ANSIBLE VERSION\r\n<!--- Paste verbatim output from “ansible --version” between quotes below -->\r\n```\r\nansible 2.4.0 (devel 2a9c6feb6a) last updated 2017/07/28 21:18:33 (GMT +200)\r\n  config file = /home/mo/playbooks/production.cfg\r\n  configured module search path = [u'/home/mo/playbooks/library']\r\n  ansible python module location = /home/mo/ansible/lib/ansible\r\n  executable location = /home/mo/ansible/bin/ansible\r\n  python version = 2.7.13 (default, Jan 19 2017, 14:48:08) [GCC 6.3.0 20170118]\r\n```","created_at":"2017-07-28T19:25:59Z","updated_at":"2017-08-03T14:50:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"19146ee75c42cbd8b21fbb207cc717a256036313","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ansible/ansible/pulls/27441/commits","review_comments_url":"https://api.github.com/repos/ansible/ansible/pulls/27441/comments","review_comment_url":"https://api.github.com/repos/ansible/ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ansible/ansible/issues/27441/comments","statuses_url":"https://api.github.com/repos/ansible/ansible/statuses/734c7d4d8824b464baf084b27b56b1f99a79b30f","head":{"label":"msales:devel","ref":"devel","sha":"734c7d4d8824b464baf084b27b56b1f99a79b30f","user":{"login":"msales","id":53617,"avatar_url":"https://avatars1.githubusercontent.com/u/53617?v=4","gravatar_id":"","url":"https://api.github.com/users/msales","html_url":"https://github.com/msales","followers_url":"https://api.github.com/users/msales/followers","following_url":"https://api.github.com/users/msales/following{/other_user}","gists_url":"https://api.github.com/users/msales/gists{/gist_id}","starred_url":"https://api.github.com/users/msales/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msales/subscriptions","organizations_url":"https://api.github.com/users/msales/orgs","repos_url":"https://api.github.com/users/msales/repos","events_url":"https://api.github.com/users/msales/events{/privacy}","received_events_url":"https://api.github.com/users/msales/received_events","type":"Organization","site_admin":false},"repo":{"id":98679003,"name":"ansible","full_name":"msales/ansible","owner":{"login":"msales","id":53617,"avatar_url":"https://avatars1.githubusercontent.com/u/53617?v=4","gravatar_id":"","url":"https://api.github.com/users/msales","html_url":"https://github.com/msales","followers_url":"https://api.github.com/users/msales/followers","following_url":"https://api.github.com/users/msales/following{/other_user}","gists_url":"https://api.github.com/users/msales/gists{/gist_id}","starred_url":"https://api.github.com/users/msales/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msales/subscriptions","organizations_url":"https://api.github.com/users/msales/orgs","repos_url":"https://api.github.com/users/msales/repos","events_url":"https://api.github.com/users/msales/events{/privacy}","received_events_url":"https://api.github.com/users/msales/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/msales/ansible","description":"Ansible is a radically simple IT automation platform that makes your applications and systems easier to deploy. Avoid writing scripts or custom code to deploy and update your applications— automate in a language that approaches plain English, using SSH, with no agents to install on remote systems.","fork":true,"url":"https://api.github.com/repos/msales/ansible","forks_url":"https://api.github.com/repos/msales/ansible/forks","keys_url":"https://api.github.com/repos/msales/ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/msales/ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/msales/ansible/teams","hooks_url":"https://api.github.com/repos/msales/ansible/hooks","issue_events_url":"https://api.github.com/repos/msales/ansible/issues/events{/number}","events_url":"https://api.github.com/repos/msales/ansible/events","assignees_url":"https://api.github.com/repos/msales/ansible/assignees{/user}","branches_url":"https://api.github.com/repos/msales/ansible/branches{/branch}","tags_url":"https://api.github.com/repos/msales/ansible/tags","blobs_url":"https://api.github.com/repos/msales/ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/msales/ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/msales/ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/msales/ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/msales/ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/msales/ansible/languages","stargazers_url":"https://api.github.com/repos/msales/ansible/stargazers","contributors_url":"https://api.github.com/repos/msales/ansible/contributors","subscribers_url":"https://api.github.com/repos/msales/ansible/subscribers","subscription_url":"https://api.github.com/repos/msales/ansible/subscription","commits_url":"https://api.github.com/repos/msales/ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/msales/ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/msales/ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/msales/ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/msales/ansible/contents/{+path}","compare_url":"https://api.github.com/repos/msales/ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/msales/ansible/merges","archive_url":"https://api.github.com/repos/msales/ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/msales/ansible/downloads","issues_url":"https://api.github.com/repos/msales/ansible/issues{/number}","pulls_url":"https://api.github.com/repos/msales/ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/msales/ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/msales/ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/msales/ansible/labels{/name}","releases_url":"https://api.github.com/repos/msales/ansible/releases{/id}","deployments_url":"https://api.github.com/repos/msales/ansible/deployments","created_at":"2017-07-28T18:53:45Z","updated_at":"2017-07-28T18:54:08Z","pushed_at":"2017-07-29T03:31:38Z","git_url":"git://github.com/msales/ansible.git","ssh_url":"git@github.com:msales/ansible.git","clone_url":"https://github.com/msales/ansible.git","svn_url":"https://github.com/msales/ansible","homepage":"http://ansible.com/","size":76106,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"devel"}},"base":{"label":"ansible:devel","ref":"devel","sha":"e241e15899d864fdad67e198c0bce3457622a01c","user":{"login":"ansible","id":1507452,"avatar_url":"https://avatars2.githubusercontent.com/u/1507452?v=4","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"repo":{"id":3638964,"name":"ansible","full_name":"ansible/ansible","owner":{"login":"ansible","id":1507452,"avatar_url":"https://avatars2.githubusercontent.com/u/1507452?v=4","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ansible/ansible","description":"Ansible is a radically simple IT automation platform that makes your applications and systems easier to deploy. Avoid writing scripts or custom code to deploy and update your applications— automate in a language that approaches plain English, using SSH, with no agents to install on remote systems.","fork":false,"url":"https://api.github.com/repos/ansible/ansible","forks_url":"https://api.github.com/repos/ansible/ansible/forks","keys_url":"https://api.github.com/repos/ansible/ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ansible/ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ansible/ansible/teams","hooks_url":"https://api.github.com/repos/ansible/ansible/hooks","issue_events_url":"https://api.github.com/repos/ansible/ansible/issues/events{/number}","events_url":"https://api.github.com/repos/ansible/ansible/events","assignees_url":"https://api.github.com/repos/ansible/ansible/assignees{/user}","branches_url":"https://api.github.com/repos/ansible/ansible/branches{/branch}","tags_url":"https://api.github.com/repos/ansible/ansible/tags","blobs_url":"https://api.github.com/repos/ansible/ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ansible/ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ansible/ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/ansible/ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ansible/ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/ansible/ansible/languages","stargazers_url":"https://api.github.com/repos/ansible/ansible/stargazers","contributors_url":"https://api.github.com/repos/ansible/ansible/contributors","subscribers_url":"https://api.github.com/repos/ansible/ansible/subscribers","subscription_url":"https://api.github.com/repos/ansible/ansible/subscription","commits_url":"https://api.github.com/repos/ansible/ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/ansible/ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/ansible/ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/ansible/ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/ansible/ansible/contents/{+path}","compare_url":"https://api.github.com/repos/ansible/ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ansible/ansible/merges","archive_url":"https://api.github.com/repos/ansible/ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ansible/ansible/downloads","issues_url":"https://api.github.com/repos/ansible/ansible/issues{/number}","pulls_url":"https://api.github.com/repos/ansible/ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/ansible/ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/ansible/ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ansible/ansible/labels{/name}","releases_url":"https://api.github.com/repos/ansible/ansible/releases{/id}","deployments_url":"https://api.github.com/repos/ansible/ansible/deployments","created_at":"2012-03-06T14:58:02Z","updated_at":"2017-08-03T14:17:33Z","pushed_at":"2017-08-03T14:49:48Z","git_url":"git://github.com/ansible/ansible.git","ssh_url":"git@github.com:ansible/ansible.git","clone_url":"https://github.com/ansible/ansible.git","svn_url":"https://github.com/ansible/ansible","homepage":"http://ansible.com/","size":85378,"stargazers_count":24566,"watchers_count":24566,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8492,"mirror_url":null,"open_issues_count":3557,"forks":8492,"open_issues":3557,"watchers":24566,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/ansible/ansible/pulls/27441"},"html":{"href":"https://github.com/ansible/ansible/pull/27441"},"issue":{"href":"https://api.github.com/repos/ansible/ansible/issues/27441"},"comments":{"href":"https://api.github.com/repos/ansible/ansible/issues/27441/comments"},"review_comments":{"href":"https://api.github.com/repos/ansible/ansible/pulls/27441/comments"},"review_comment":{"href":"https://api.github.com/repos/ansible/ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ansible/ansible/pulls/27441/commits"},"statuses":{"href":"https://api.github.com/repos/ansible/ansible/statuses/734c7d4d8824b464baf084b27b56b1f99a79b30f"}}}}
{"actor":{"display_login":"memo42"}}