{"action":"created","comment":{"url":"https://api.github.com/repos/quipucords/rho/pulls/comments/127801982","pull_request_review_id":50422158,"id":127801982,"diff_hunk":"@@ -50,57 +49,46 @@ def _create_ping_inventory(vault, vault_pass, profile_ranges, profile_port,\n     success_map = defaultdict(list)\n     best_map = defaultdict(list)\n     mapped_hosts = set()\n+    hosts_dict = dict()","path":"rho/scancommand.py","position":17,"original_position":17,"commit_id":"bf726981706594dd13bc791866b99115b3b1de2a","original_commit_id":"bf726981706594dd13bc791866b99115b3b1de2a","user":{"login":"elyezer","id":48132,"avatar_url":"https://avatars1.githubusercontent.com/u/48132?v=4","gravatar_id":"","url":"https://api.github.com/users/elyezer","html_url":"https://github.com/elyezer","followers_url":"https://api.github.com/users/elyezer/followers","following_url":"https://api.github.com/users/elyezer/following{/other_user}","gists_url":"https://api.github.com/users/elyezer/gists{/gist_id}","starred_url":"https://api.github.com/users/elyezer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elyezer/subscriptions","organizations_url":"https://api.github.com/users/elyezer/orgs","repos_url":"https://api.github.com/users/elyezer/repos","events_url":"https://api.github.com/users/elyezer/events{/privacy}","received_events_url":"https://api.github.com/users/elyezer/received_events","type":"User","site_admin":false},"body":"Out of curiosity I prefer the literal dict, instead of the constructor, because it is faster:\r\n\r\n```python\r\nIn [1]: %timeit d = dict()\r\nThe slowest run took 102.70 times longer than the fastest. This could mean that an intermediate result is being cached.\r\n10000000 loops, best of 3: 97.5 ns per loop\r\n\r\nIn [2]: %timeit d = {}\r\nThe slowest run took 95.34 times longer than the fastest. This could mean that an intermediate result is being cached.\r\n10000000 loops, best of 3: 22.5 ns per loop\r\n```","created_at":"2017-07-17T19:28:25Z","updated_at":"2017-07-17T19:28:26Z","html_url":"https://github.com/quipucords/rho/pull/66#discussion_r127801982","pull_request_url":"https://api.github.com/repos/quipucords/rho/pulls/66","_links":{"self":{"href":"https://api.github.com/repos/quipucords/rho/pulls/comments/127801982"},"html":{"href":"https://github.com/quipucords/rho/pull/66#discussion_r127801982"},"pull_request":{"href":"https://api.github.com/repos/quipucords/rho/pulls/66"}}},"pull_request":{"url":"https://api.github.com/repos/quipucords/rho/pulls/66","id":130925515,"html_url":"https://github.com/quipucords/rho/pull/66","diff_url":"https://github.com/quipucords/rho/pull/66.diff","patch_url":"https://github.com/quipucords/rho/pull/66.patch","issue_url":"https://api.github.com/repos/quipucords/rho/issues/66","number":66,"state":"open","locked":false,"title":"refactor scan commands to utilize yaml inventory instead of whitespac…","user":{"login":"chambridge","id":29379759,"avatar_url":"https://avatars3.githubusercontent.com/u/29379759?v=4","gravatar_id":"","url":"https://api.github.com/users/chambridge","html_url":"https://github.com/chambridge","followers_url":"https://api.github.com/users/chambridge/followers","following_url":"https://api.github.com/users/chambridge/following{/other_user}","gists_url":"https://api.github.com/users/chambridge/gists{/gist_id}","starred_url":"https://api.github.com/users/chambridge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chambridge/subscriptions","organizations_url":"https://api.github.com/users/chambridge/orgs","repos_url":"https://api.github.com/users/chambridge/repos","events_url":"https://api.github.com/users/chambridge/events{/privacy}","received_events_url":"https://api.github.com/users/chambridge/received_events","type":"User","site_admin":false},"body":"…e sensitive ini like files. Also add basic ansible module test for spit results.\r\n\r\nThis is more refactoring towards the refactoring issue #38 ","created_at":"2017-07-17T18:53:18Z","updated_at":"2017-07-17T19:28:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bc96614a87c1a9490ed80a97fab7a0366bbdf2a5","assignee":{"login":"elyezer","id":48132,"avatar_url":"https://avatars1.githubusercontent.com/u/48132?v=4","gravatar_id":"","url":"https://api.github.com/users/elyezer","html_url":"https://github.com/elyezer","followers_url":"https://api.github.com/users/elyezer/followers","following_url":"https://api.github.com/users/elyezer/following{/other_user}","gists_url":"https://api.github.com/users/elyezer/gists{/gist_id}","starred_url":"https://api.github.com/users/elyezer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elyezer/subscriptions","organizations_url":"https://api.github.com/users/elyezer/orgs","repos_url":"https://api.github.com/users/elyezer/repos","events_url":"https://api.github.com/users/elyezer/events{/privacy}","received_events_url":"https://api.github.com/users/elyezer/received_events","type":"User","site_admin":false},"assignees":[{"login":"elyezer","id":48132,"avatar_url":"https://avatars1.githubusercontent.com/u/48132?v=4","gravatar_id":"","url":"https://api.github.com/users/elyezer","html_url":"https://github.com/elyezer","followers_url":"https://api.github.com/users/elyezer/followers","following_url":"https://api.github.com/users/elyezer/following{/other_user}","gists_url":"https://api.github.com/users/elyezer/gists{/gist_id}","starred_url":"https://api.github.com/users/elyezer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elyezer/subscriptions","organizations_url":"https://api.github.com/users/elyezer/orgs","repos_url":"https://api.github.com/users/elyezer/repos","events_url":"https://api.github.com/users/elyezer/events{/privacy}","received_events_url":"https://api.github.com/users/elyezer/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/quipucords/rho/pulls/66/commits","review_comments_url":"https://api.github.com/repos/quipucords/rho/pulls/66/comments","review_comment_url":"https://api.github.com/repos/quipucords/rho/pulls/comments{/number}","comments_url":"https://api.github.com/repos/quipucords/rho/issues/66/comments","statuses_url":"https://api.github.com/repos/quipucords/rho/statuses/bf726981706594dd13bc791866b99115b3b1de2a","head":{"label":"quipucords:issues/38-part4","ref":"issues/38-part4","sha":"bf726981706594dd13bc791866b99115b3b1de2a","user":{"login":"quipucords","id":29148065,"avatar_url":"https://avatars0.githubusercontent.com/u/29148065?v=4","gravatar_id":"","url":"https://api.github.com/users/quipucords","html_url":"https://github.com/quipucords","followers_url":"https://api.github.com/users/quipucords/followers","following_url":"https://api.github.com/users/quipucords/following{/other_user}","gists_url":"https://api.github.com/users/quipucords/gists{/gist_id}","starred_url":"https://api.github.com/users/quipucords/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quipucords/subscriptions","organizations_url":"https://api.github.com/users/quipucords/orgs","repos_url":"https://api.github.com/users/quipucords/repos","events_url":"https://api.github.com/users/quipucords/events{/privacy}","received_events_url":"https://api.github.com/users/quipucords/received_events","type":"Organization","site_admin":false},"repo":{"id":93546150,"name":"rho","full_name":"quipucords/rho","owner":{"login":"quipucords","id":29148065,"avatar_url":"https://avatars0.githubusercontent.com/u/29148065?v=4","gravatar_id":"","url":"https://api.github.com/users/quipucords","html_url":"https://github.com/quipucords","followers_url":"https://api.github.com/users/quipucords/followers","following_url":"https://api.github.com/users/quipucords/following{/other_user}","gists_url":"https://api.github.com/users/quipucords/gists{/gist_id}","starred_url":"https://api.github.com/users/quipucords/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quipucords/subscriptions","organizations_url":"https://api.github.com/users/quipucords/orgs","repos_url":"https://api.github.com/users/quipucords/repos","events_url":"https://api.github.com/users/quipucords/events{/privacy}","received_events_url":"https://api.github.com/users/quipucords/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/quipucords/rho","description":"A tool for scanning a network, logging into systems using SSH, and retrieving information about available Unix and Linux servers.","fork":true,"url":"https://api.github.com/repos/quipucords/rho","forks_url":"https://api.github.com/repos/quipucords/rho/forks","keys_url":"https://api.github.com/repos/quipucords/rho/keys{/key_id}","collaborators_url":"https://api.github.com/repos/quipucords/rho/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/quipucords/rho/teams","hooks_url":"https://api.github.com/repos/quipucords/rho/hooks","issue_events_url":"https://api.github.com/repos/quipucords/rho/issues/events{/number}","events_url":"https://api.github.com/repos/quipucords/rho/events","assignees_url":"https://api.github.com/repos/quipucords/rho/assignees{/user}","branches_url":"https://api.github.com/repos/quipucords/rho/branches{/branch}","tags_url":"https://api.github.com/repos/quipucords/rho/tags","blobs_url":"https://api.github.com/repos/quipucords/rho/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/quipucords/rho/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/quipucords/rho/git/refs{/sha}","trees_url":"https://api.github.com/repos/quipucords/rho/git/trees{/sha}","statuses_url":"https://api.github.com/repos/quipucords/rho/statuses/{sha}","languages_url":"https://api.github.com/repos/quipucords/rho/languages","stargazers_url":"https://api.github.com/repos/quipucords/rho/stargazers","contributors_url":"https://api.github.com/repos/quipucords/rho/contributors","subscribers_url":"https://api.github.com/repos/quipucords/rho/subscribers","subscription_url":"https://api.github.com/repos/quipucords/rho/subscription","commits_url":"https://api.github.com/repos/quipucords/rho/commits{/sha}","git_commits_url":"https://api.github.com/repos/quipucords/rho/git/commits{/sha}","comments_url":"https://api.github.com/repos/quipucords/rho/comments{/number}","issue_comment_url":"https://api.github.com/repos/quipucords/rho/issues/comments{/number}","contents_url":"https://api.github.com/repos/quipucords/rho/contents/{+path}","compare_url":"https://api.github.com/repos/quipucords/rho/compare/{base}...{head}","merges_url":"https://api.github.com/repos/quipucords/rho/merges","archive_url":"https://api.github.com/repos/quipucords/rho/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/quipucords/rho/downloads","issues_url":"https://api.github.com/repos/quipucords/rho/issues{/number}","pulls_url":"https://api.github.com/repos/quipucords/rho/pulls{/number}","milestones_url":"https://api.github.com/repos/quipucords/rho/milestones{/number}","notifications_url":"https://api.github.com/repos/quipucords/rho/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/quipucords/rho/labels{/name}","releases_url":"https://api.github.com/repos/quipucords/rho/releases{/id}","deployments_url":"https://api.github.com/repos/quipucords/rho/deployments","created_at":"2017-06-06T17:37:50Z","updated_at":"2017-07-13T20:06:18Z","pushed_at":"2017-07-17T18:53:19Z","git_url":"git://github.com/quipucords/rho.git","ssh_url":"git@github.com:quipucords/rho.git","clone_url":"https://github.com/quipucords/rho.git","svn_url":"https://github.com/quipucords/rho","homepage":"https://quipucords.github.io/rho/","size":797,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":21,"forks":0,"open_issues":21,"watchers":0,"default_branch":"master"}},"base":{"label":"quipucords:master","ref":"master","sha":"ebc843422b48931e4bdd4f19871ca2e2b2826288","user":{"login":"quipucords","id":29148065,"avatar_url":"https://avatars0.githubusercontent.com/u/29148065?v=4","gravatar_id":"","url":"https://api.github.com/users/quipucords","html_url":"https://github.com/quipucords","followers_url":"https://api.github.com/users/quipucords/followers","following_url":"https://api.github.com/users/quipucords/following{/other_user}","gists_url":"https://api.github.com/users/quipucords/gists{/gist_id}","starred_url":"https://api.github.com/users/quipucords/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quipucords/subscriptions","organizations_url":"https://api.github.com/users/quipucords/orgs","repos_url":"https://api.github.com/users/quipucords/repos","events_url":"https://api.github.com/users/quipucords/events{/privacy}","received_events_url":"https://api.github.com/users/quipucords/received_events","type":"Organization","site_admin":false},"repo":{"id":93546150,"name":"rho","full_name":"quipucords/rho","owner":{"login":"quipucords","id":29148065,"avatar_url":"https://avatars0.githubusercontent.com/u/29148065?v=4","gravatar_id":"","url":"https://api.github.com/users/quipucords","html_url":"https://github.com/quipucords","followers_url":"https://api.github.com/users/quipucords/followers","following_url":"https://api.github.com/users/quipucords/following{/other_user}","gists_url":"https://api.github.com/users/quipucords/gists{/gist_id}","starred_url":"https://api.github.com/users/quipucords/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quipucords/subscriptions","organizations_url":"https://api.github.com/users/quipucords/orgs","repos_url":"https://api.github.com/users/quipucords/repos","events_url":"https://api.github.com/users/quipucords/events{/privacy}","received_events_url":"https://api.github.com/users/quipucords/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/quipucords/rho","description":"A tool for scanning a network, logging into systems using SSH, and retrieving information about available Unix and Linux servers.","fork":true,"url":"https://api.github.com/repos/quipucords/rho","forks_url":"https://api.github.com/repos/quipucords/rho/forks","keys_url":"https://api.github.com/repos/quipucords/rho/keys{/key_id}","collaborators_url":"https://api.github.com/repos/quipucords/rho/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/quipucords/rho/teams","hooks_url":"https://api.github.com/repos/quipucords/rho/hooks","issue_events_url":"https://api.github.com/repos/quipucords/rho/issues/events{/number}","events_url":"https://api.github.com/repos/quipucords/rho/events","assignees_url":"https://api.github.com/repos/quipucords/rho/assignees{/user}","branches_url":"https://api.github.com/repos/quipucords/rho/branches{/branch}","tags_url":"https://api.github.com/repos/quipucords/rho/tags","blobs_url":"https://api.github.com/repos/quipucords/rho/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/quipucords/rho/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/quipucords/rho/git/refs{/sha}","trees_url":"https://api.github.com/repos/quipucords/rho/git/trees{/sha}","statuses_url":"https://api.github.com/repos/quipucords/rho/statuses/{sha}","languages_url":"https://api.github.com/repos/quipucords/rho/languages","stargazers_url":"https://api.github.com/repos/quipucords/rho/stargazers","contributors_url":"https://api.github.com/repos/quipucords/rho/contributors","subscribers_url":"https://api.github.com/repos/quipucords/rho/subscribers","subscription_url":"https://api.github.com/repos/quipucords/rho/subscription","commits_url":"https://api.github.com/repos/quipucords/rho/commits{/sha}","git_commits_url":"https://api.github.com/repos/quipucords/rho/git/commits{/sha}","comments_url":"https://api.github.com/repos/quipucords/rho/comments{/number}","issue_comment_url":"https://api.github.com/repos/quipucords/rho/issues/comments{/number}","contents_url":"https://api.github.com/repos/quipucords/rho/contents/{+path}","compare_url":"https://api.github.com/repos/quipucords/rho/compare/{base}...{head}","merges_url":"https://api.github.com/repos/quipucords/rho/merges","archive_url":"https://api.github.com/repos/quipucords/rho/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/quipucords/rho/downloads","issues_url":"https://api.github.com/repos/quipucords/rho/issues{/number}","pulls_url":"https://api.github.com/repos/quipucords/rho/pulls{/number}","milestones_url":"https://api.github.com/repos/quipucords/rho/milestones{/number}","notifications_url":"https://api.github.com/repos/quipucords/rho/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/quipucords/rho/labels{/name}","releases_url":"https://api.github.com/repos/quipucords/rho/releases{/id}","deployments_url":"https://api.github.com/repos/quipucords/rho/deployments","created_at":"2017-06-06T17:37:50Z","updated_at":"2017-07-13T20:06:18Z","pushed_at":"2017-07-17T18:53:19Z","git_url":"git://github.com/quipucords/rho.git","ssh_url":"git@github.com:quipucords/rho.git","clone_url":"https://github.com/quipucords/rho.git","svn_url":"https://github.com/quipucords/rho","homepage":"https://quipucords.github.io/rho/","size":797,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":21,"forks":0,"open_issues":21,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/quipucords/rho/pulls/66"},"html":{"href":"https://github.com/quipucords/rho/pull/66"},"issue":{"href":"https://api.github.com/repos/quipucords/rho/issues/66"},"comments":{"href":"https://api.github.com/repos/quipucords/rho/issues/66/comments"},"review_comments":{"href":"https://api.github.com/repos/quipucords/rho/pulls/66/comments"},"review_comment":{"href":"https://api.github.com/repos/quipucords/rho/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/quipucords/rho/pulls/66/commits"},"statuses":{"href":"https://api.github.com/repos/quipucords/rho/statuses/bf726981706594dd13bc791866b99115b3b1de2a"}}}}
{"actor":{"display_login":"elyezer"}}