{"action":"created","issue":{"url":"https://api.github.com/repos/tanguyantoine/react-native-music-control/issues/84","repository_url":"https://api.github.com/repos/tanguyantoine/react-native-music-control","labels_url":"https://api.github.com/repos/tanguyantoine/react-native-music-control/issues/84/labels{/name}","comments_url":"https://api.github.com/repos/tanguyantoine/react-native-music-control/issues/84/comments","events_url":"https://api.github.com/repos/tanguyantoine/react-native-music-control/issues/84/events","html_url":"https://github.com/tanguyantoine/react-native-music-control/pull/84","id":253226912,"number":84,"title":"Multiple options for Swipe-to-close on Android Notification","user":{"login":"SteffeyDev","id":10255587,"avatar_url":"https://avatars3.githubusercontent.com/u/10255587?v=4","gravatar_id":"","url":"https://api.github.com/users/SteffeyDev","html_url":"https://github.com/SteffeyDev","followers_url":"https://api.github.com/users/SteffeyDev/followers","following_url":"https://api.github.com/users/SteffeyDev/following{/other_user}","gists_url":"https://api.github.com/users/SteffeyDev/gists{/gist_id}","starred_url":"https://api.github.com/users/SteffeyDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SteffeyDev/subscriptions","organizations_url":"https://api.github.com/users/SteffeyDev/orgs","repos_url":"https://api.github.com/users/SteffeyDev/repos","events_url":"https://api.github.com/users/SteffeyDev/events{/privacy}","received_events_url":"https://api.github.com/users/SteffeyDev/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-08-28T05:00:21Z","updated_at":"2017-08-28T23:04:22Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/tanguyantoine/react-native-music-control/pulls/84","html_url":"https://github.com/tanguyantoine/react-native-music-control/pull/84","diff_url":"https://github.com/tanguyantoine/react-native-music-control/pull/84.diff","patch_url":"https://github.com/tanguyantoine/react-native-music-control/pull/84.patch"},"body":"#### What's this PR do?\r\n\r\nNow the app developer can specify whether the Android audio notification will always\r\nclose on swipe, only close if the audio is paused, or will never close\r\nwhen swiped.  In addition, a new control was added to provide a\r\ncallback for when it is closed via swipe, so that the app developer can\r\nchoose to terminate the audio or do nothing.\r\n\r\n#### Which issue(s) is it related to?\r\n\r\nNone, it is a convenience feature that other developers may find useful.\r\n\r\n#### How to test:\r\n\r\nRun on device, enable the closeNotification control, optionally pass in a 'when' qualifier option, and try closing the notification.  If it is allowed to be closed, it should call the enabled callback on notification close, so that the app can react appropriately."},"comment":{"url":"https://api.github.com/repos/tanguyantoine/react-native-music-control/issues/comments/325507392","html_url":"https://github.com/tanguyantoine/react-native-music-control/pull/84#issuecomment-325507392","issue_url":"https://api.github.com/repos/tanguyantoine/react-native-music-control/issues/84","id":325507392,"user":{"login":"Guichaguri","id":1813032,"avatar_url":"https://avatars1.githubusercontent.com/u/1813032?v=4","gravatar_id":"","url":"https://api.github.com/users/Guichaguri","html_url":"https://github.com/Guichaguri","followers_url":"https://api.github.com/users/Guichaguri/followers","following_url":"https://api.github.com/users/Guichaguri/following{/other_user}","gists_url":"https://api.github.com/users/Guichaguri/gists{/gist_id}","starred_url":"https://api.github.com/users/Guichaguri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Guichaguri/subscriptions","organizations_url":"https://api.github.com/users/Guichaguri/orgs","repos_url":"https://api.github.com/users/Guichaguri/repos","events_url":"https://api.github.com/users/Guichaguri/events{/privacy}","received_events_url":"https://api.github.com/users/Guichaguri/received_events","type":"User","site_admin":false},"created_at":"2017-08-28T23:04:22Z","updated_at":"2017-08-28T23:04:22Z","body":"I can't think of one scenario where someone would want to change the swipe controls.\r\n\r\nIn the Android documentation, there's a music player article where they recommend making the notification \"on going\" when the music is playing, so the user will always have some way to control it and be prevented to remove it accidentally."}}
{"actor":{"display_login":"Guichaguri"}}