{"action":"created","comment":{"url":"https://api.github.com/repos/google/trillian/pulls/comments/118003709","pull_request_review_id":39755542,"id":118003709,"diff_hunk":"@@ -0,0 +1,30 @@\n+FROM golang\n+\n+ENV DB_USER=test \\","path":"server/trillian_log_server/Dockerfile","position":3,"original_position":3,"commit_id":"aeac74365ec58b8eb74e4b244047623a3a57e4ac","original_commit_id":"4645a45300507b29cffbd1657069993557c1ad88","user":{"login":"RJPercival","id":1949076,"avatar_url":"https://avatars1.githubusercontent.com/u/1949076?v=3","gravatar_id":"","url":"https://api.github.com/users/RJPercival","html_url":"https://github.com/RJPercival","followers_url":"https://api.github.com/users/RJPercival/followers","following_url":"https://api.github.com/users/RJPercival/following{/other_user}","gists_url":"https://api.github.com/users/RJPercival/gists{/gist_id}","starred_url":"https://api.github.com/users/RJPercival/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RJPercival/subscriptions","organizations_url":"https://api.github.com/users/RJPercival/orgs","repos_url":"https://api.github.com/users/RJPercival/repos","events_url":"https://api.github.com/users/RJPercival/events{/privacy}","received_events_url":"https://api.github.com/users/RJPercival/received_events","type":"User","site_admin":false},"body":"The documentation suggests using both, by declaring an ARG first and then using its value to initialize the ENV. I'm fine with leaving it as it is though, just thought I'd highlight this option.","created_at":"2017-05-23T14:15:10Z","updated_at":"2017-05-23T14:15:10Z","html_url":"https://github.com/google/trillian/pull/607#discussion_r118003709","pull_request_url":"https://api.github.com/repos/google/trillian/pulls/607","_links":{"self":{"href":"https://api.github.com/repos/google/trillian/pulls/comments/118003709"},"html":{"href":"https://github.com/google/trillian/pull/607#discussion_r118003709"},"pull_request":{"href":"https://api.github.com/repos/google/trillian/pulls/607"}}},"pull_request":{"url":"https://api.github.com/repos/google/trillian/pulls/607","id":120175085,"html_url":"https://github.com/google/trillian/pull/607","diff_url":"https://github.com/google/trillian/pull/607.diff","patch_url":"https://github.com/google/trillian/pull/607.patch","issue_url":"https://api.github.com/repos/google/trillian/issues/607","number":607,"state":"open","locked":false,"title":"Add Docker build files","user":{"login":"gdbelvin","id":198478,"avatar_url":"https://avatars2.githubusercontent.com/u/198478?v=3","gravatar_id":"","url":"https://api.github.com/users/gdbelvin","html_url":"https://github.com/gdbelvin","followers_url":"https://api.github.com/users/gdbelvin/followers","following_url":"https://api.github.com/users/gdbelvin/following{/other_user}","gists_url":"https://api.github.com/users/gdbelvin/gists{/gist_id}","starred_url":"https://api.github.com/users/gdbelvin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gdbelvin/subscriptions","organizations_url":"https://api.github.com/users/gdbelvin/orgs","repos_url":"https://api.github.com/users/gdbelvin/repos","events_url":"https://api.github.com/users/gdbelvin/events{/privacy}","received_events_url":"https://api.github.com/users/gdbelvin/received_events","type":"User","site_admin":false},"body":"Support building trillian clusters by defining docker build files.\r\nThey should be run like so:\r\n`docker build -f server/trillian_log_server/Dockerfile .` from `$GOPATH/src/github.com/google/trillian`\r\n\r\nPlease correct me if these are the wrong binaries to be defining definitions for. \r\nI see that there's also a `server/main.go` which has some duplicate functionality. ","created_at":"2017-05-11T18:45:48Z","updated_at":"2017-05-23T14:15:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"431796b07112a12822d92baaf8ec4e499bb7fa92","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/google/trillian/pulls/607/commits","review_comments_url":"https://api.github.com/repos/google/trillian/pulls/607/comments","review_comment_url":"https://api.github.com/repos/google/trillian/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/trillian/issues/607/comments","statuses_url":"https://api.github.com/repos/google/trillian/statuses/aeac74365ec58b8eb74e4b244047623a3a57e4ac","head":{"label":"gdbelvin:docker","ref":"docker","sha":"aeac74365ec58b8eb74e4b244047623a3a57e4ac","user":{"login":"gdbelvin","id":198478,"avatar_url":"https://avatars2.githubusercontent.com/u/198478?v=3","gravatar_id":"","url":"https://api.github.com/users/gdbelvin","html_url":"https://github.com/gdbelvin","followers_url":"https://api.github.com/users/gdbelvin/followers","following_url":"https://api.github.com/users/gdbelvin/following{/other_user}","gists_url":"https://api.github.com/users/gdbelvin/gists{/gist_id}","starred_url":"https://api.github.com/users/gdbelvin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gdbelvin/subscriptions","organizations_url":"https://api.github.com/users/gdbelvin/orgs","repos_url":"https://api.github.com/users/gdbelvin/repos","events_url":"https://api.github.com/users/gdbelvin/events{/privacy}","received_events_url":"https://api.github.com/users/gdbelvin/received_events","type":"User","site_admin":false},"repo":{"id":79220930,"name":"trillian","full_name":"gdbelvin/trillian","owner":{"login":"gdbelvin","id":198478,"avatar_url":"https://avatars2.githubusercontent.com/u/198478?v=3","gravatar_id":"","url":"https://api.github.com/users/gdbelvin","html_url":"https://github.com/gdbelvin","followers_url":"https://api.github.com/users/gdbelvin/followers","following_url":"https://api.github.com/users/gdbelvin/following{/other_user}","gists_url":"https://api.github.com/users/gdbelvin/gists{/gist_id}","starred_url":"https://api.github.com/users/gdbelvin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gdbelvin/subscriptions","organizations_url":"https://api.github.com/users/gdbelvin/orgs","repos_url":"https://api.github.com/users/gdbelvin/repos","events_url":"https://api.github.com/users/gdbelvin/events{/privacy}","received_events_url":"https://api.github.com/users/gdbelvin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gdbelvin/trillian","description":null,"fork":true,"url":"https://api.github.com/repos/gdbelvin/trillian","forks_url":"https://api.github.com/repos/gdbelvin/trillian/forks","keys_url":"https://api.github.com/repos/gdbelvin/trillian/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gdbelvin/trillian/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gdbelvin/trillian/teams","hooks_url":"https://api.github.com/repos/gdbelvin/trillian/hooks","issue_events_url":"https://api.github.com/repos/gdbelvin/trillian/issues/events{/number}","events_url":"https://api.github.com/repos/gdbelvin/trillian/events","assignees_url":"https://api.github.com/repos/gdbelvin/trillian/assignees{/user}","branches_url":"https://api.github.com/repos/gdbelvin/trillian/branches{/branch}","tags_url":"https://api.github.com/repos/gdbelvin/trillian/tags","blobs_url":"https://api.github.com/repos/gdbelvin/trillian/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gdbelvin/trillian/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gdbelvin/trillian/git/refs{/sha}","trees_url":"https://api.github.com/repos/gdbelvin/trillian/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gdbelvin/trillian/statuses/{sha}","languages_url":"https://api.github.com/repos/gdbelvin/trillian/languages","stargazers_url":"https://api.github.com/repos/gdbelvin/trillian/stargazers","contributors_url":"https://api.github.com/repos/gdbelvin/trillian/contributors","subscribers_url":"https://api.github.com/repos/gdbelvin/trillian/subscribers","subscription_url":"https://api.github.com/repos/gdbelvin/trillian/subscription","commits_url":"https://api.github.com/repos/gdbelvin/trillian/commits{/sha}","git_commits_url":"https://api.github.com/repos/gdbelvin/trillian/git/commits{/sha}","comments_url":"https://api.github.com/repos/gdbelvin/trillian/comments{/number}","issue_comment_url":"https://api.github.com/repos/gdbelvin/trillian/issues/comments{/number}","contents_url":"https://api.github.com/repos/gdbelvin/trillian/contents/{+path}","compare_url":"https://api.github.com/repos/gdbelvin/trillian/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gdbelvin/trillian/merges","archive_url":"https://api.github.com/repos/gdbelvin/trillian/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gdbelvin/trillian/downloads","issues_url":"https://api.github.com/repos/gdbelvin/trillian/issues{/number}","pulls_url":"https://api.github.com/repos/gdbelvin/trillian/pulls{/number}","milestones_url":"https://api.github.com/repos/gdbelvin/trillian/milestones{/number}","notifications_url":"https://api.github.com/repos/gdbelvin/trillian/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gdbelvin/trillian/labels{/name}","releases_url":"https://api.github.com/repos/gdbelvin/trillian/releases{/id}","deployments_url":"https://api.github.com/repos/gdbelvin/trillian/deployments","created_at":"2017-01-17T11:27:31Z","updated_at":"2017-01-17T11:27:34Z","pushed_at":"2017-05-23T14:12:27Z","git_url":"git://github.com/gdbelvin/trillian.git","ssh_url":"git@github.com:gdbelvin/trillian.git","clone_url":"https://github.com/gdbelvin/trillian.git","svn_url":"https://github.com/gdbelvin/trillian","homepage":null,"size":6626,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"5196eff7c56101bcd7ea04010db521cf1e8dfc88","user":{"login":"google","id":1342004,"avatar_url":"https://avatars2.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":58654489,"name":"trillian","full_name":"google/trillian","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars2.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/trillian","description":"Trillian implements a Merkle tree whose contents are served from a data storage layer, to allow scalability to extremely large trees.","fork":false,"url":"https://api.github.com/repos/google/trillian","forks_url":"https://api.github.com/repos/google/trillian/forks","keys_url":"https://api.github.com/repos/google/trillian/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/trillian/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/trillian/teams","hooks_url":"https://api.github.com/repos/google/trillian/hooks","issue_events_url":"https://api.github.com/repos/google/trillian/issues/events{/number}","events_url":"https://api.github.com/repos/google/trillian/events","assignees_url":"https://api.github.com/repos/google/trillian/assignees{/user}","branches_url":"https://api.github.com/repos/google/trillian/branches{/branch}","tags_url":"https://api.github.com/repos/google/trillian/tags","blobs_url":"https://api.github.com/repos/google/trillian/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/trillian/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/trillian/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/trillian/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/trillian/statuses/{sha}","languages_url":"https://api.github.com/repos/google/trillian/languages","stargazers_url":"https://api.github.com/repos/google/trillian/stargazers","contributors_url":"https://api.github.com/repos/google/trillian/contributors","subscribers_url":"https://api.github.com/repos/google/trillian/subscribers","subscription_url":"https://api.github.com/repos/google/trillian/subscription","commits_url":"https://api.github.com/repos/google/trillian/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/trillian/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/trillian/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/trillian/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/trillian/contents/{+path}","compare_url":"https://api.github.com/repos/google/trillian/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/trillian/merges","archive_url":"https://api.github.com/repos/google/trillian/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/trillian/downloads","issues_url":"https://api.github.com/repos/google/trillian/issues{/number}","pulls_url":"https://api.github.com/repos/google/trillian/pulls{/number}","milestones_url":"https://api.github.com/repos/google/trillian/milestones{/number}","notifications_url":"https://api.github.com/repos/google/trillian/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/trillian/labels{/name}","releases_url":"https://api.github.com/repos/google/trillian/releases{/id}","deployments_url":"https://api.github.com/repos/google/trillian/deployments","created_at":"2016-05-12T15:37:35Z","updated_at":"2017-05-23T12:10:09Z","pushed_at":"2017-05-23T14:12:28Z","git_url":"git://github.com/google/trillian.git","ssh_url":"git@github.com:google/trillian.git","clone_url":"https://github.com/google/trillian.git","svn_url":"https://github.com/google/trillian","homepage":"","size":6464,"stargazers_count":368,"watchers_count":368,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":62,"mirror_url":null,"open_issues_count":50,"forks":62,"open_issues":50,"watchers":368,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/trillian/pulls/607"},"html":{"href":"https://github.com/google/trillian/pull/607"},"issue":{"href":"https://api.github.com/repos/google/trillian/issues/607"},"comments":{"href":"https://api.github.com/repos/google/trillian/issues/607/comments"},"review_comments":{"href":"https://api.github.com/repos/google/trillian/pulls/607/comments"},"review_comment":{"href":"https://api.github.com/repos/google/trillian/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/trillian/pulls/607/commits"},"statuses":{"href":"https://api.github.com/repos/google/trillian/statuses/aeac74365ec58b8eb74e4b244047623a3a57e4ac"}}}}
{"actor":{"display_login":"RJPercival"}}