{"action":"created","issue":{"url":"https://api.github.com/repos/highfidelity/hifi/issues/12046","repository_url":"https://api.github.com/repos/highfidelity/hifi","labels_url":"https://api.github.com/repos/highfidelity/hifi/issues/12046/labels{/name}","comments_url":"https://api.github.com/repos/highfidelity/hifi/issues/12046/comments","events_url":"https://api.github.com/repos/highfidelity/hifi/issues/12046/events","html_url":"https://github.com/highfidelity/hifi/pull/12046","id":284030903,"number":12046,"title":"Commerce: Fix some rezzing errors; Fix ECDSA errors","user":{"login":"zfox23","id":3409031,"avatar_url":"https://avatars1.githubusercontent.com/u/3409031?v=4","gravatar_id":"","url":"https://api.github.com/users/zfox23","html_url":"https://github.com/zfox23","followers_url":"https://api.github.com/users/zfox23/followers","following_url":"https://api.github.com/users/zfox23/following{/other_user}","gists_url":"https://api.github.com/users/zfox23/gists{/gist_id}","starred_url":"https://api.github.com/users/zfox23/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zfox23/subscriptions","organizations_url":"https://api.github.com/users/zfox23/orgs","repos_url":"https://api.github.com/users/zfox23/repos","events_url":"https://api.github.com/users/zfox23/events{/privacy}","received_events_url":"https://api.github.com/users/zfox23/received_events","type":"User","site_admin":false},"labels":[{"id":11332862,"url":"https://api.github.com/repos/highfidelity/hifi/labels/bug","name":"bug","color":"fc2929","default":true},{"id":412774488,"url":"https://api.github.com/repos/highfidelity/hifi/labels/Critical%20Fix","name":"Critical Fix","color":"fbca04","default":false},{"id":735931517,"url":"https://api.github.com/repos/highfidelity/hifi/labels/disco-free","name":"disco-free","color":"66cc00","default":false},{"id":313595519,"url":"https://api.github.com/repos/highfidelity/hifi/labels/QA%20Ready","name":"QA Ready","color":"bfd4f2","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-12-21T23:14:53Z","updated_at":"2017-12-21T23:42:15Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/12046","html_url":"https://github.com/highfidelity/hifi/pull/12046","diff_url":"https://github.com/highfidelity/hifi/pull/12046.diff","patch_url":"https://github.com/highfidelity/hifi/pull/12046.patch"},"body":"This is marked as a Critical Fix because it fixes a bug that sometimes prevents certified entities from rezzing. It also fixes Ownership Challenges entirely (which are, as of the released product, useless due to a bug).\r\n\r\nThis PR fixes certified rezzing errors caused by a memory corruption error due to an incorrect implementation of C++ code (specifically, see `EntityItemProperties.cpp:2533`) 😄. The corruption error occurred randomly, and appears to have presented itself more readily on Unix machines. The would manifest itself by way of known-good entities failing to pass static certificate verification.\r\n\r\nThis PR _also_ fixes all errors related to Ownership Challenges, **which were previously useless.** Prior to this PR, all Ownership Challenges were erroneously succeeding due to `-1` being equivalent to the boolean `true`. This error wasn't noticed when we switched our cryptography scheme from RSA to ECDSA.\r\n\r\n**Test Plan:**\r\nRun through the following three TestRail tests:\r\nhttps://highfidelity.testrail.net/index.php?/cases/view/3507\r\nhttps://highfidelity.testrail.net/index.php?/cases/view/2183\r\nhttps://highfidelity.testrail.net/index.php?/cases/view/2193\r\n\r\nPlease let me know via Slack if you have any questions."},"comment":{"url":"https://api.github.com/repos/highfidelity/hifi/issues/comments/353485509","html_url":"https://github.com/highfidelity/hifi/pull/12046#issuecomment-353485509","issue_url":"https://api.github.com/repos/highfidelity/hifi/issues/12046","id":353485509,"user":{"login":"hifi-gustavo","id":4554450,"avatar_url":"https://avatars0.githubusercontent.com/u/4554450?v=4","gravatar_id":"","url":"https://api.github.com/users/hifi-gustavo","html_url":"https://github.com/hifi-gustavo","followers_url":"https://api.github.com/users/hifi-gustavo/followers","following_url":"https://api.github.com/users/hifi-gustavo/following{/other_user}","gists_url":"https://api.github.com/users/hifi-gustavo/gists{/gist_id}","starred_url":"https://api.github.com/users/hifi-gustavo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hifi-gustavo/subscriptions","organizations_url":"https://api.github.com/users/hifi-gustavo/orgs","repos_url":"https://api.github.com/users/hifi-gustavo/repos","events_url":"https://api.github.com/users/hifi-gustavo/events{/privacy}","received_events_url":"https://api.github.com/users/hifi-gustavo/received_events","type":"User","site_admin":false},"created_at":"2017-12-21T23:42:15Z","updated_at":"2017-12-21T23:42:15Z","author_association":"NONE","body":"Windows build is available at: https://deployment.highfidelity.com/jobs/pr-build/label%3Dwindows/5796/HighFidelity-Beta-PR12046-73eb258e794062255f31a26e8ac1118c116c8020.exe"}}
{"actor":{"display_login":"hifi-gustavo"}}