{"action":"created","issue":{"url":"https://api.github.com/repos/F5Networks/f5-common-python/issues/1141","repository_url":"https://api.github.com/repos/F5Networks/f5-common-python","labels_url":"https://api.github.com/repos/F5Networks/f5-common-python/issues/1141/labels{/name}","comments_url":"https://api.github.com/repos/F5Networks/f5-common-python/issues/1141/comments","events_url":"https://api.github.com/repos/F5Networks/f5-common-python/issues/1141/events","html_url":"https://github.com/F5Networks/f5-common-python/pull/1141","id":231641046,"number":1141,"title":"Members modify() broken when setting session attribute","user":{"login":"zancas","id":640955,"avatar_url":"https://avatars3.githubusercontent.com/u/640955?v=3","gravatar_id":"","url":"https://api.github.com/users/zancas","html_url":"https://github.com/zancas","followers_url":"https://api.github.com/users/zancas/followers","following_url":"https://api.github.com/users/zancas/following{/other_user}","gists_url":"https://api.github.com/users/zancas/gists{/gist_id}","starred_url":"https://api.github.com/users/zancas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zancas/subscriptions","organizations_url":"https://api.github.com/users/zancas/orgs","repos_url":"https://api.github.com/users/zancas/repos","events_url":"https://api.github.com/users/zancas/events{/privacy}","received_events_url":"https://api.github.com/users/zancas/received_events","type":"User","site_admin":false},"labels":[{"id":343843535,"url":"https://api.github.com/repos/F5Networks/f5-common-python/labels/bugfix","name":"bugfix","color":"207de5","default":false}],"state":"open","locked":false,"assignee":{"login":"pjbreaux","id":14225800,"avatar_url":"https://avatars2.githubusercontent.com/u/14225800?v=3","gravatar_id":"","url":"https://api.github.com/users/pjbreaux","html_url":"https://github.com/pjbreaux","followers_url":"https://api.github.com/users/pjbreaux/followers","following_url":"https://api.github.com/users/pjbreaux/following{/other_user}","gists_url":"https://api.github.com/users/pjbreaux/gists{/gist_id}","starred_url":"https://api.github.com/users/pjbreaux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pjbreaux/subscriptions","organizations_url":"https://api.github.com/users/pjbreaux/orgs","repos_url":"https://api.github.com/users/pjbreaux/repos","events_url":"https://api.github.com/users/pjbreaux/events{/privacy}","received_events_url":"https://api.github.com/users/pjbreaux/received_events","type":"User","site_admin":false},"assignees":[{"login":"pjbreaux","id":14225800,"avatar_url":"https://avatars2.githubusercontent.com/u/14225800?v=3","gravatar_id":"","url":"https://api.github.com/users/pjbreaux","html_url":"https://github.com/pjbreaux","followers_url":"https://api.github.com/users/pjbreaux/followers","following_url":"https://api.github.com/users/pjbreaux/following{/other_user}","gists_url":"https://api.github.com/users/pjbreaux/gists{/gist_id}","starred_url":"https://api.github.com/users/pjbreaux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pjbreaux/subscriptions","organizations_url":"https://api.github.com/users/pjbreaux/orgs","repos_url":"https://api.github.com/users/pjbreaux/repos","events_url":"https://api.github.com/users/pjbreaux/events{/privacy}","received_events_url":"https://api.github.com/users/pjbreaux/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2017-05-26T14:22:17Z","updated_at":"2017-05-26T14:52:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/F5Networks/f5-common-python/pulls/1141","html_url":"https://github.com/F5Networks/f5-common-python/pull/1141","diff_url":"https://github.com/F5Networks/f5-common-python/pull/1141.diff","patch_url":"https://github.com/F5Networks/f5-common-python/pull/1141.patch"},"body":"Issues:\r\nFixes #1137\r\n\r\nProblem: Member modify incorrectly checks value of 'state' attribute\r\nwhen user passes 'session' attribute to modify.\r\n\r\nAnalysis: patch['state'] is not correct. should be patch['session']\r\n\r\nTests: Added new test, test_session_modify(), to match existing test\r\ntest_state_modify()."},"comment":{"url":"https://api.github.com/repos/F5Networks/f5-common-python/issues/comments/304303696","html_url":"https://github.com/F5Networks/f5-common-python/pull/1141#issuecomment-304303696","issue_url":"https://api.github.com/repos/F5Networks/f5-common-python/issues/1141","id":304303696,"user":{"login":"pjbreaux","id":14225800,"avatar_url":"https://avatars2.githubusercontent.com/u/14225800?v=3","gravatar_id":"","url":"https://api.github.com/users/pjbreaux","html_url":"https://github.com/pjbreaux","followers_url":"https://api.github.com/users/pjbreaux/followers","following_url":"https://api.github.com/users/pjbreaux/following{/other_user}","gists_url":"https://api.github.com/users/pjbreaux/gists{/gist_id}","starred_url":"https://api.github.com/users/pjbreaux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pjbreaux/subscriptions","organizations_url":"https://api.github.com/users/pjbreaux/orgs","repos_url":"https://api.github.com/users/pjbreaux/repos","events_url":"https://api.github.com/users/pjbreaux/events{/privacy}","received_events_url":"https://api.github.com/users/pjbreaux/received_events","type":"User","site_admin":false},"created_at":"2017-05-26T14:52:32Z","updated_at":"2017-05-26T14:52:32Z","body":"The tests related to this code change passes. We are making a bugfix release based on this. The other failing tests in jenkins is related to #1132.\r\n\r\n```\r\nf5/bigip/tm/ltm/test/functional/test_pool.py::TestPoolMembersCollection::test_get_collection PASSED\r\nf5/bigip/tm/ltm/test/functional/test_pool.py::TestPoolMembersCollection::test_refresh_member PASSED\r\nf5/bigip/tm/ltm/test/functional/test_pool.py::TestPoolMembersCollection::test_load_member PASSED\r\nf5/bigip/tm/ltm/test/functional/test_pool.py::TestPoolMembersCollection::test_members_exists PASSED\r\nf5/bigip/tm/ltm/test/functional/test_pool.py::TestPoolMembersCollection::test_state_update PASSED\r\nf5/bigip/tm/ltm/test/functional/test_pool.py::TestPoolMembersCollection::test_state_update_with_kwargs PASSED\r\nf5/bigip/tm/ltm/test/functional/test_pool.py::TestPoolMembersCollection::test_state_update_invalid_value_with_kwargs PASSED\r\nf5/bigip/tm/ltm/test/functional/test_pool.py::TestPoolMembersCollection::test_state_update_invalid_value PASSED\r\nf5/bigip/tm/ltm/test/functional/test_pool.py::TestPoolMembersCollection::test_session_update_with_kwargs PASSED\r\nf5/bigip/tm/ltm/test/functional/test_pool.py::TestPoolMembersCollection::test_session_update_invalid_value_with_kwargs PASSED\r\nf5/bigip/tm/ltm/test/functional/test_pool.py::TestPoolMembersCollection::test_session_update_invalid_value PASSED\r\nf5/bigip/tm/ltm/test/functional/test_pool.py::TestPoolMembersCollection::test_update_session_state PASSED\r\nf5/bigip/tm/ltm/test/functional/test_pool.py::TestPoolMembersCollection::test_update_session_state_kwargs PASSED\r\nf5/bigip/tm/ltm/test/functional/test_pool.py::TestPoolMembersCollection::test_session_modify PASSED\r\nf5/bigip/tm/ltm/test/functional/test_pool.py::TestPoolMembersCollection::test_state_modify PASSED\r\nf5/bigip/tm/ltm/test/functional/test_pool.py::TestPoolMembersCollection::test_state_modify_error PASSED\r\nf5/bigip/tm/ltm/test/functional/test_pool.py::TestPoolMembersCollection::test_session_modify_error PASSED\r\nf5/bigip/tm/ltm/test/functional/test_pool.py::TestPool::test_create_no_args PASSED\r\nf5/bigip/tm/ltm/test/functional/test_pool.py::TestPool::test_create PASSED\r\nf5/bigip/tm/ltm/test/functional/test_pool.py::TestPool::test_refresh PASSED\r\nf5/bigip/tm/ltm/test/functional/test_pool.py::TestPool::test_update PASSED\r\nf5/bigip/tm/ltm/test/functional/test_pool.py::TestPool::test_create_monitor_parameter PASSED\r\nf5/bigip/tm/ltm/test/functional/test_pool.py::TestPool::test_update_monitor_parameter PASSED\r\nf5/bigip/tm/ltm/test/functional/test_pool.py::TestPool::test_modify_monitor_parameter PASSED\r\n\r\n========================== 24 passed in 6.98 seconds ===========================\r\n```"}}
{"actor":{"display_login":"pjbreaux"}}