{"action":"created","comment":{"url":"https://api.github.com/repos/theforeman/puppet-foreman/pulls/comments/110623472","pull_request_review_id":31807511,"id":110623472,"diff_hunk":"@@ -37,16 +37,19 @@\n \n   if $reports {   # foreman reporter\n \n-    exec { 'Create Puppet Reports dir':\n-      command => \"/bin/mkdir -p ${puppet_basedir}/reports\",\n-      creates => \"${puppet_basedir}/reports\",\n-    }\n-    file {\"${puppet_basedir}/reports/foreman.rb\":\n-      mode    => '0644',\n-      owner   => 'root',\n-      group   => '0',\n-      source  => \"puppet:///modules/${module_name}/foreman-report_${report_api}.rb\",\n-      require => Exec['Create Puppet Reports dir'],\n+    if ( $::foreman::params::aio_package == false ) {","path":"manifests/puppetmaster.pp","position":14,"original_position":14,"commit_id":"f82496c8fcb16b48e9ca5fee55fef50b06382ea2","original_commit_id":"6328d7df8714c87d169cd38fc568d041670d51ba","user":{"login":"ekohl","id":155810,"avatar_url":"https://avatars3.githubusercontent.com/u/155810?v=3","gravatar_id":"","url":"https://api.github.com/users/ekohl","html_url":"https://github.com/ekohl","followers_url":"https://api.github.com/users/ekohl/followers","following_url":"https://api.github.com/users/ekohl/following{/other_user}","gists_url":"https://api.github.com/users/ekohl/gists{/gist_id}","starred_url":"https://api.github.com/users/ekohl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekohl/subscriptions","organizations_url":"https://api.github.com/users/ekohl/orgs","repos_url":"https://api.github.com/users/ekohl/repos","events_url":"https://api.github.com/users/ekohl/events{/privacy}","received_events_url":"https://api.github.com/users/ekohl/received_events","type":"User","site_admin":false},"body":"I'd prefer users of this call it with the correct parameters. The most logical one would be to set ```$reports``` to false.","created_at":"2017-04-10T10:38:05Z","updated_at":"2017-04-10T10:38:05Z","html_url":"https://github.com/theforeman/puppet-foreman/pull/539#discussion_r110623472","pull_request_url":"https://api.github.com/repos/theforeman/puppet-foreman/pulls/539","_links":{"self":{"href":"https://api.github.com/repos/theforeman/puppet-foreman/pulls/comments/110623472"},"html":{"href":"https://github.com/theforeman/puppet-foreman/pull/539#discussion_r110623472"},"pull_request":{"href":"https://api.github.com/repos/theforeman/puppet-foreman/pulls/539"}}},"pull_request":{"url":"https://api.github.com/repos/theforeman/puppet-foreman/pulls/539","id":112447295,"html_url":"https://github.com/theforeman/puppet-foreman/pull/539","diff_url":"https://github.com/theforeman/puppet-foreman/pull/539.diff","patch_url":"https://github.com/theforeman/puppet-foreman/pull/539.patch","issue_url":"https://api.github.com/repos/theforeman/puppet-foreman/issues/539","number":539,"state":"open","locked":false,"title":"[WIP] Fix running under puppet 4","user":{"login":"rendhalver","id":1026337,"avatar_url":"https://avatars2.githubusercontent.com/u/1026337?v=3","gravatar_id":"","url":"https://api.github.com/users/rendhalver","html_url":"https://github.com/rendhalver","followers_url":"https://api.github.com/users/rendhalver/followers","following_url":"https://api.github.com/users/rendhalver/following{/other_user}","gists_url":"https://api.github.com/users/rendhalver/gists{/gist_id}","starred_url":"https://api.github.com/users/rendhalver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rendhalver/subscriptions","organizations_url":"https://api.github.com/users/rendhalver/orgs","repos_url":"https://api.github.com/users/rendhalver/repos","events_url":"https://api.github.com/users/rendhalver/events{/privacy}","received_events_url":"https://api.github.com/users/rendhalver/received_events","type":"User","site_admin":false},"body":"Add support for puppet 4\r\nThis also moves the report into the plugins so it is synced to the right place.","created_at":"2017-03-24T12:37:23Z","updated_at":"2017-04-10T10:38:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"826a91ff8dc85d2883ff0eca56c71fec7f2e4b1e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/theforeman/puppet-foreman/pulls/539/commits","review_comments_url":"https://api.github.com/repos/theforeman/puppet-foreman/pulls/539/comments","review_comment_url":"https://api.github.com/repos/theforeman/puppet-foreman/pulls/comments{/number}","comments_url":"https://api.github.com/repos/theforeman/puppet-foreman/issues/539/comments","statuses_url":"https://api.github.com/repos/theforeman/puppet-foreman/statuses/f82496c8fcb16b48e9ca5fee55fef50b06382ea2","head":{"label":"powerhome:feature/puppet_4_fixes","ref":"feature/puppet_4_fixes","sha":"f82496c8fcb16b48e9ca5fee55fef50b06382ea2","user":{"login":"powerhome","id":10852243,"avatar_url":"https://avatars1.githubusercontent.com/u/10852243?v=3","gravatar_id":"","url":"https://api.github.com/users/powerhome","html_url":"https://github.com/powerhome","followers_url":"https://api.github.com/users/powerhome/followers","following_url":"https://api.github.com/users/powerhome/following{/other_user}","gists_url":"https://api.github.com/users/powerhome/gists{/gist_id}","starred_url":"https://api.github.com/users/powerhome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/powerhome/subscriptions","organizations_url":"https://api.github.com/users/powerhome/orgs","repos_url":"https://api.github.com/users/powerhome/repos","events_url":"https://api.github.com/users/powerhome/events{/privacy}","received_events_url":"https://api.github.com/users/powerhome/received_events","type":"Organization","site_admin":false},"repo":{"id":85858634,"name":"puppet-foreman","full_name":"powerhome/puppet-foreman","owner":{"login":"powerhome","id":10852243,"avatar_url":"https://avatars1.githubusercontent.com/u/10852243?v=3","gravatar_id":"","url":"https://api.github.com/users/powerhome","html_url":"https://github.com/powerhome","followers_url":"https://api.github.com/users/powerhome/followers","following_url":"https://api.github.com/users/powerhome/following{/other_user}","gists_url":"https://api.github.com/users/powerhome/gists{/gist_id}","starred_url":"https://api.github.com/users/powerhome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/powerhome/subscriptions","organizations_url":"https://api.github.com/users/powerhome/orgs","repos_url":"https://api.github.com/users/powerhome/repos","events_url":"https://api.github.com/users/powerhome/events{/privacy}","received_events_url":"https://api.github.com/users/powerhome/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/powerhome/puppet-foreman","description":"Puppet module for Foreman","fork":true,"url":"https://api.github.com/repos/powerhome/puppet-foreman","forks_url":"https://api.github.com/repos/powerhome/puppet-foreman/forks","keys_url":"https://api.github.com/repos/powerhome/puppet-foreman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/powerhome/puppet-foreman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/powerhome/puppet-foreman/teams","hooks_url":"https://api.github.com/repos/powerhome/puppet-foreman/hooks","issue_events_url":"https://api.github.com/repos/powerhome/puppet-foreman/issues/events{/number}","events_url":"https://api.github.com/repos/powerhome/puppet-foreman/events","assignees_url":"https://api.github.com/repos/powerhome/puppet-foreman/assignees{/user}","branches_url":"https://api.github.com/repos/powerhome/puppet-foreman/branches{/branch}","tags_url":"https://api.github.com/repos/powerhome/puppet-foreman/tags","blobs_url":"https://api.github.com/repos/powerhome/puppet-foreman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/powerhome/puppet-foreman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/powerhome/puppet-foreman/git/refs{/sha}","trees_url":"https://api.github.com/repos/powerhome/puppet-foreman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/powerhome/puppet-foreman/statuses/{sha}","languages_url":"https://api.github.com/repos/powerhome/puppet-foreman/languages","stargazers_url":"https://api.github.com/repos/powerhome/puppet-foreman/stargazers","contributors_url":"https://api.github.com/repos/powerhome/puppet-foreman/contributors","subscribers_url":"https://api.github.com/repos/powerhome/puppet-foreman/subscribers","subscription_url":"https://api.github.com/repos/powerhome/puppet-foreman/subscription","commits_url":"https://api.github.com/repos/powerhome/puppet-foreman/commits{/sha}","git_commits_url":"https://api.github.com/repos/powerhome/puppet-foreman/git/commits{/sha}","comments_url":"https://api.github.com/repos/powerhome/puppet-foreman/comments{/number}","issue_comment_url":"https://api.github.com/repos/powerhome/puppet-foreman/issues/comments{/number}","contents_url":"https://api.github.com/repos/powerhome/puppet-foreman/contents/{+path}","compare_url":"https://api.github.com/repos/powerhome/puppet-foreman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/powerhome/puppet-foreman/merges","archive_url":"https://api.github.com/repos/powerhome/puppet-foreman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/powerhome/puppet-foreman/downloads","issues_url":"https://api.github.com/repos/powerhome/puppet-foreman/issues{/number}","pulls_url":"https://api.github.com/repos/powerhome/puppet-foreman/pulls{/number}","milestones_url":"https://api.github.com/repos/powerhome/puppet-foreman/milestones{/number}","notifications_url":"https://api.github.com/repos/powerhome/puppet-foreman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/powerhome/puppet-foreman/labels{/name}","releases_url":"https://api.github.com/repos/powerhome/puppet-foreman/releases{/id}","deployments_url":"https://api.github.com/repos/powerhome/puppet-foreman/deployments","created_at":"2017-03-22T17:46:03Z","updated_at":"2017-03-22T17:46:05Z","pushed_at":"2017-03-30T12:18:27Z","git_url":"git://github.com/powerhome/puppet-foreman.git","ssh_url":"git@github.com:powerhome/puppet-foreman.git","clone_url":"https://github.com/powerhome/puppet-foreman.git","svn_url":"https://github.com/powerhome/puppet-foreman","homepage":"","size":886,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"theforeman:master","ref":"master","sha":"58f191122b07a4684f4200eea6a9ea7bd6af8f79","user":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars1.githubusercontent.com/u/1439844?v=3","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"repo":{"id":3449583,"name":"puppet-foreman","full_name":"theforeman/puppet-foreman","owner":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars1.githubusercontent.com/u/1439844?v=3","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/theforeman/puppet-foreman","description":"Puppet module for Foreman","fork":false,"url":"https://api.github.com/repos/theforeman/puppet-foreman","forks_url":"https://api.github.com/repos/theforeman/puppet-foreman/forks","keys_url":"https://api.github.com/repos/theforeman/puppet-foreman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theforeman/puppet-foreman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theforeman/puppet-foreman/teams","hooks_url":"https://api.github.com/repos/theforeman/puppet-foreman/hooks","issue_events_url":"https://api.github.com/repos/theforeman/puppet-foreman/issues/events{/number}","events_url":"https://api.github.com/repos/theforeman/puppet-foreman/events","assignees_url":"https://api.github.com/repos/theforeman/puppet-foreman/assignees{/user}","branches_url":"https://api.github.com/repos/theforeman/puppet-foreman/branches{/branch}","tags_url":"https://api.github.com/repos/theforeman/puppet-foreman/tags","blobs_url":"https://api.github.com/repos/theforeman/puppet-foreman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theforeman/puppet-foreman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theforeman/puppet-foreman/git/refs{/sha}","trees_url":"https://api.github.com/repos/theforeman/puppet-foreman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theforeman/puppet-foreman/statuses/{sha}","languages_url":"https://api.github.com/repos/theforeman/puppet-foreman/languages","stargazers_url":"https://api.github.com/repos/theforeman/puppet-foreman/stargazers","contributors_url":"https://api.github.com/repos/theforeman/puppet-foreman/contributors","subscribers_url":"https://api.github.com/repos/theforeman/puppet-foreman/subscribers","subscription_url":"https://api.github.com/repos/theforeman/puppet-foreman/subscription","commits_url":"https://api.github.com/repos/theforeman/puppet-foreman/commits{/sha}","git_commits_url":"https://api.github.com/repos/theforeman/puppet-foreman/git/commits{/sha}","comments_url":"https://api.github.com/repos/theforeman/puppet-foreman/comments{/number}","issue_comment_url":"https://api.github.com/repos/theforeman/puppet-foreman/issues/comments{/number}","contents_url":"https://api.github.com/repos/theforeman/puppet-foreman/contents/{+path}","compare_url":"https://api.github.com/repos/theforeman/puppet-foreman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theforeman/puppet-foreman/merges","archive_url":"https://api.github.com/repos/theforeman/puppet-foreman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theforeman/puppet-foreman/downloads","issues_url":"https://api.github.com/repos/theforeman/puppet-foreman/issues{/number}","pulls_url":"https://api.github.com/repos/theforeman/puppet-foreman/pulls{/number}","milestones_url":"https://api.github.com/repos/theforeman/puppet-foreman/milestones{/number}","notifications_url":"https://api.github.com/repos/theforeman/puppet-foreman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theforeman/puppet-foreman/labels{/name}","releases_url":"https://api.github.com/repos/theforeman/puppet-foreman/releases{/id}","deployments_url":"https://api.github.com/repos/theforeman/puppet-foreman/deployments","created_at":"2012-02-15T13:19:01Z","updated_at":"2017-02-04T13:20:24Z","pushed_at":"2017-04-09T11:50:57Z","git_url":"git://github.com/theforeman/puppet-foreman.git","ssh_url":"git@github.com:theforeman/puppet-foreman.git","clone_url":"https://github.com/theforeman/puppet-foreman.git","svn_url":"https://github.com/theforeman/puppet-foreman","homepage":"","size":901,"stargazers_count":77,"watchers_count":77,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":199,"mirror_url":null,"open_issues_count":16,"forks":199,"open_issues":16,"watchers":77,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/theforeman/puppet-foreman/pulls/539"},"html":{"href":"https://github.com/theforeman/puppet-foreman/pull/539"},"issue":{"href":"https://api.github.com/repos/theforeman/puppet-foreman/issues/539"},"comments":{"href":"https://api.github.com/repos/theforeman/puppet-foreman/issues/539/comments"},"review_comments":{"href":"https://api.github.com/repos/theforeman/puppet-foreman/pulls/539/comments"},"review_comment":{"href":"https://api.github.com/repos/theforeman/puppet-foreman/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/theforeman/puppet-foreman/pulls/539/commits"},"statuses":{"href":"https://api.github.com/repos/theforeman/puppet-foreman/statuses/f82496c8fcb16b48e9ca5fee55fef50b06382ea2"}}}}
{"actor":{"display_login":"ekohl"}}