{"action":"closed","number":134,"pull_request":{"url":"https://api.github.com/repos/ConnectBox/connectbox-pi/pulls/134","id":128735722,"html_url":"https://github.com/ConnectBox/connectbox-pi/pull/134","diff_url":"https://github.com/ConnectBox/connectbox-pi/pull/134.diff","patch_url":"https://github.com/ConnectBox/connectbox-pi/pull/134.patch","issue_url":"https://api.github.com/repos/ConnectBox/connectbox-pi/issues/134","number":134,"state":"closed","locked":false,"title":"Set the locale in the admin api","user":{"login":"edwinsteele","id":1515215,"avatar_url":"https://avatars3.githubusercontent.com/u/1515215?v=3","gravatar_id":"","url":"https://api.github.com/users/edwinsteele","html_url":"https://github.com/edwinsteele","followers_url":"https://api.github.com/users/edwinsteele/followers","following_url":"https://api.github.com/users/edwinsteele/following{/other_user}","gists_url":"https://api.github.com/users/edwinsteele/gists{/gist_id}","starred_url":"https://api.github.com/users/edwinsteele/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edwinsteele/subscriptions","organizations_url":"https://api.github.com/users/edwinsteele/orgs","repos_url":"https://api.github.com/users/edwinsteele/repos","events_url":"https://api.github.com/users/edwinsteele/events{/privacy}","received_events_url":"https://api.github.com/users/edwinsteele/received_events","type":"User","site_admin":false},"body":"Armbian and Raspbian set the locale appropriately, but the official\r\nUbuntu AMI that we'll use in #131 does not, which means that\r\nescapeshellcmd strips out unicode characters, which is problematic\r\ngiven we explicitly test setting SSIDs containing unicode strings (specifically, test32CharacterUnicodeSSIDSet is failing on the Ubuntu AMI without this change)\r\n\r\nI don't think it's a problem to set this in the script, given we\r\ncontrol the connectbox environment and are shipping the device\r\nwith LC_CTYPE=\"en_US.UTF-8\"  (it'd be LC_CTYPE=\"en_GB.UTF-8\" if we\r\nshipped a raspbian device), and both of those locales would allow\r\nunicode characters through.\r\n\r\nI don’t really know what I’m doing with PHP, so please correct me if this is inappropriate.","created_at":"2017-07-04T06:51:56Z","updated_at":"2017-07-04T18:57:35Z","closed_at":"2017-07-04T18:57:35Z","merged_at":"2017-07-04T18:57:35Z","merge_commit_sha":"b85d201ea6ba659a0136b8553d5aba7df8e714bf","assignee":null,"assignees":[],"requested_reviewers":[{"login":"matheweis","id":1214227,"avatar_url":"https://avatars2.githubusercontent.com/u/1214227?v=3","gravatar_id":"","url":"https://api.github.com/users/matheweis","html_url":"https://github.com/matheweis","followers_url":"https://api.github.com/users/matheweis/followers","following_url":"https://api.github.com/users/matheweis/following{/other_user}","gists_url":"https://api.github.com/users/matheweis/gists{/gist_id}","starred_url":"https://api.github.com/users/matheweis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matheweis/subscriptions","organizations_url":"https://api.github.com/users/matheweis/orgs","repos_url":"https://api.github.com/users/matheweis/repos","events_url":"https://api.github.com/users/matheweis/events{/privacy}","received_events_url":"https://api.github.com/users/matheweis/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ConnectBox/connectbox-pi/pulls/134/commits","review_comments_url":"https://api.github.com/repos/ConnectBox/connectbox-pi/pulls/134/comments","review_comment_url":"https://api.github.com/repos/ConnectBox/connectbox-pi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ConnectBox/connectbox-pi/issues/134/comments","statuses_url":"https://api.github.com/repos/ConnectBox/connectbox-pi/statuses/2502aed73233bf86a756220a69e3c99d996b192f","head":{"label":"ConnectBox:handle-empty-language-environment","ref":"handle-empty-language-environment","sha":"2502aed73233bf86a756220a69e3c99d996b192f","user":{"login":"ConnectBox","id":24737567,"avatar_url":"https://avatars1.githubusercontent.com/u/24737567?v=3","gravatar_id":"","url":"https://api.github.com/users/ConnectBox","html_url":"https://github.com/ConnectBox","followers_url":"https://api.github.com/users/ConnectBox/followers","following_url":"https://api.github.com/users/ConnectBox/following{/other_user}","gists_url":"https://api.github.com/users/ConnectBox/gists{/gist_id}","starred_url":"https://api.github.com/users/ConnectBox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ConnectBox/subscriptions","organizations_url":"https://api.github.com/users/ConnectBox/orgs","repos_url":"https://api.github.com/users/ConnectBox/repos","events_url":"https://api.github.com/users/ConnectBox/events{/privacy}","received_events_url":"https://api.github.com/users/ConnectBox/received_events","type":"Organization","site_admin":false},"repo":{"id":72788699,"name":"connectbox-pi","full_name":"ConnectBox/connectbox-pi","owner":{"login":"ConnectBox","id":24737567,"avatar_url":"https://avatars1.githubusercontent.com/u/24737567?v=3","gravatar_id":"","url":"https://api.github.com/users/ConnectBox","html_url":"https://github.com/ConnectBox","followers_url":"https://api.github.com/users/ConnectBox/followers","following_url":"https://api.github.com/users/ConnectBox/following{/other_user}","gists_url":"https://api.github.com/users/ConnectBox/gists{/gist_id}","starred_url":"https://api.github.com/users/ConnectBox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ConnectBox/subscriptions","organizations_url":"https://api.github.com/users/ConnectBox/orgs","repos_url":"https://api.github.com/users/ConnectBox/repos","events_url":"https://api.github.com/users/ConnectBox/events{/privacy}","received_events_url":"https://api.github.com/users/ConnectBox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ConnectBox/connectbox-pi","description":"ConnectBox is a media sharing device based on small form factor computers like the Raspberry Pi","fork":false,"url":"https://api.github.com/repos/ConnectBox/connectbox-pi","forks_url":"https://api.github.com/repos/ConnectBox/connectbox-pi/forks","keys_url":"https://api.github.com/repos/ConnectBox/connectbox-pi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ConnectBox/connectbox-pi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ConnectBox/connectbox-pi/teams","hooks_url":"https://api.github.com/repos/ConnectBox/connectbox-pi/hooks","issue_events_url":"https://api.github.com/repos/ConnectBox/connectbox-pi/issues/events{/number}","events_url":"https://api.github.com/repos/ConnectBox/connectbox-pi/events","assignees_url":"https://api.github.com/repos/ConnectBox/connectbox-pi/assignees{/user}","branches_url":"https://api.github.com/repos/ConnectBox/connectbox-pi/branches{/branch}","tags_url":"https://api.github.com/repos/ConnectBox/connectbox-pi/tags","blobs_url":"https://api.github.com/repos/ConnectBox/connectbox-pi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ConnectBox/connectbox-pi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ConnectBox/connectbox-pi/git/refs{/sha}","trees_url":"https://api.github.com/repos/ConnectBox/connectbox-pi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ConnectBox/connectbox-pi/statuses/{sha}","languages_url":"https://api.github.com/repos/ConnectBox/connectbox-pi/languages","stargazers_url":"https://api.github.com/repos/ConnectBox/connectbox-pi/stargazers","contributors_url":"https://api.github.com/repos/ConnectBox/connectbox-pi/contributors","subscribers_url":"https://api.github.com/repos/ConnectBox/connectbox-pi/subscribers","subscription_url":"https://api.github.com/repos/ConnectBox/connectbox-pi/subscription","commits_url":"https://api.github.com/repos/ConnectBox/connectbox-pi/commits{/sha}","git_commits_url":"https://api.github.com/repos/ConnectBox/connectbox-pi/git/commits{/sha}","comments_url":"https://api.github.com/repos/ConnectBox/connectbox-pi/comments{/number}","issue_comment_url":"https://api.github.com/repos/ConnectBox/connectbox-pi/issues/comments{/number}","contents_url":"https://api.github.com/repos/ConnectBox/connectbox-pi/contents/{+path}","compare_url":"https://api.github.com/repos/ConnectBox/connectbox-pi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ConnectBox/connectbox-pi/merges","archive_url":"https://api.github.com/repos/ConnectBox/connectbox-pi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ConnectBox/connectbox-pi/downloads","issues_url":"https://api.github.com/repos/ConnectBox/connectbox-pi/issues{/number}","pulls_url":"https://api.github.com/repos/ConnectBox/connectbox-pi/pulls{/number}","milestones_url":"https://api.github.com/repos/ConnectBox/connectbox-pi/milestones{/number}","notifications_url":"https://api.github.com/repos/ConnectBox/connectbox-pi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ConnectBox/connectbox-pi/labels{/name}","releases_url":"https://api.github.com/repos/ConnectBox/connectbox-pi/releases{/id}","deployments_url":"https://api.github.com/repos/ConnectBox/connectbox-pi/deployments","created_at":"2016-11-03T21:31:23Z","updated_at":"2017-06-17T10:57:44Z","pushed_at":"2017-07-04T18:57:35Z","git_url":"git://github.com/ConnectBox/connectbox-pi.git","ssh_url":"git@github.com:ConnectBox/connectbox-pi.git","clone_url":"https://github.com/ConnectBox/connectbox-pi.git","svn_url":"https://github.com/ConnectBox/connectbox-pi","homepage":"","size":1194,"stargazers_count":5,"watchers_count":5,"language":"HTML","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":25,"forks":9,"open_issues":25,"watchers":5,"default_branch":"master"}},"base":{"label":"ConnectBox:master","ref":"master","sha":"08cb877a64b942e1cab0096e45dc2a2e47fd8022","user":{"login":"ConnectBox","id":24737567,"avatar_url":"https://avatars1.githubusercontent.com/u/24737567?v=3","gravatar_id":"","url":"https://api.github.com/users/ConnectBox","html_url":"https://github.com/ConnectBox","followers_url":"https://api.github.com/users/ConnectBox/followers","following_url":"https://api.github.com/users/ConnectBox/following{/other_user}","gists_url":"https://api.github.com/users/ConnectBox/gists{/gist_id}","starred_url":"https://api.github.com/users/ConnectBox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ConnectBox/subscriptions","organizations_url":"https://api.github.com/users/ConnectBox/orgs","repos_url":"https://api.github.com/users/ConnectBox/repos","events_url":"https://api.github.com/users/ConnectBox/events{/privacy}","received_events_url":"https://api.github.com/users/ConnectBox/received_events","type":"Organization","site_admin":false},"repo":{"id":72788699,"name":"connectbox-pi","full_name":"ConnectBox/connectbox-pi","owner":{"login":"ConnectBox","id":24737567,"avatar_url":"https://avatars1.githubusercontent.com/u/24737567?v=3","gravatar_id":"","url":"https://api.github.com/users/ConnectBox","html_url":"https://github.com/ConnectBox","followers_url":"https://api.github.com/users/ConnectBox/followers","following_url":"https://api.github.com/users/ConnectBox/following{/other_user}","gists_url":"https://api.github.com/users/ConnectBox/gists{/gist_id}","starred_url":"https://api.github.com/users/ConnectBox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ConnectBox/subscriptions","organizations_url":"https://api.github.com/users/ConnectBox/orgs","repos_url":"https://api.github.com/users/ConnectBox/repos","events_url":"https://api.github.com/users/ConnectBox/events{/privacy}","received_events_url":"https://api.github.com/users/ConnectBox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ConnectBox/connectbox-pi","description":"ConnectBox is a media sharing device based on small form factor computers like the Raspberry Pi","fork":false,"url":"https://api.github.com/repos/ConnectBox/connectbox-pi","forks_url":"https://api.github.com/repos/ConnectBox/connectbox-pi/forks","keys_url":"https://api.github.com/repos/ConnectBox/connectbox-pi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ConnectBox/connectbox-pi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ConnectBox/connectbox-pi/teams","hooks_url":"https://api.github.com/repos/ConnectBox/connectbox-pi/hooks","issue_events_url":"https://api.github.com/repos/ConnectBox/connectbox-pi/issues/events{/number}","events_url":"https://api.github.com/repos/ConnectBox/connectbox-pi/events","assignees_url":"https://api.github.com/repos/ConnectBox/connectbox-pi/assignees{/user}","branches_url":"https://api.github.com/repos/ConnectBox/connectbox-pi/branches{/branch}","tags_url":"https://api.github.com/repos/ConnectBox/connectbox-pi/tags","blobs_url":"https://api.github.com/repos/ConnectBox/connectbox-pi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ConnectBox/connectbox-pi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ConnectBox/connectbox-pi/git/refs{/sha}","trees_url":"https://api.github.com/repos/ConnectBox/connectbox-pi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ConnectBox/connectbox-pi/statuses/{sha}","languages_url":"https://api.github.com/repos/ConnectBox/connectbox-pi/languages","stargazers_url":"https://api.github.com/repos/ConnectBox/connectbox-pi/stargazers","contributors_url":"https://api.github.com/repos/ConnectBox/connectbox-pi/contributors","subscribers_url":"https://api.github.com/repos/ConnectBox/connectbox-pi/subscribers","subscription_url":"https://api.github.com/repos/ConnectBox/connectbox-pi/subscription","commits_url":"https://api.github.com/repos/ConnectBox/connectbox-pi/commits{/sha}","git_commits_url":"https://api.github.com/repos/ConnectBox/connectbox-pi/git/commits{/sha}","comments_url":"https://api.github.com/repos/ConnectBox/connectbox-pi/comments{/number}","issue_comment_url":"https://api.github.com/repos/ConnectBox/connectbox-pi/issues/comments{/number}","contents_url":"https://api.github.com/repos/ConnectBox/connectbox-pi/contents/{+path}","compare_url":"https://api.github.com/repos/ConnectBox/connectbox-pi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ConnectBox/connectbox-pi/merges","archive_url":"https://api.github.com/repos/ConnectBox/connectbox-pi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ConnectBox/connectbox-pi/downloads","issues_url":"https://api.github.com/repos/ConnectBox/connectbox-pi/issues{/number}","pulls_url":"https://api.github.com/repos/ConnectBox/connectbox-pi/pulls{/number}","milestones_url":"https://api.github.com/repos/ConnectBox/connectbox-pi/milestones{/number}","notifications_url":"https://api.github.com/repos/ConnectBox/connectbox-pi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ConnectBox/connectbox-pi/labels{/name}","releases_url":"https://api.github.com/repos/ConnectBox/connectbox-pi/releases{/id}","deployments_url":"https://api.github.com/repos/ConnectBox/connectbox-pi/deployments","created_at":"2016-11-03T21:31:23Z","updated_at":"2017-06-17T10:57:44Z","pushed_at":"2017-07-04T18:57:35Z","git_url":"git://github.com/ConnectBox/connectbox-pi.git","ssh_url":"git@github.com:ConnectBox/connectbox-pi.git","clone_url":"https://github.com/ConnectBox/connectbox-pi.git","svn_url":"https://github.com/ConnectBox/connectbox-pi","homepage":"","size":1194,"stargazers_count":5,"watchers_count":5,"language":"HTML","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":25,"forks":9,"open_issues":25,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ConnectBox/connectbox-pi/pulls/134"},"html":{"href":"https://github.com/ConnectBox/connectbox-pi/pull/134"},"issue":{"href":"https://api.github.com/repos/ConnectBox/connectbox-pi/issues/134"},"comments":{"href":"https://api.github.com/repos/ConnectBox/connectbox-pi/issues/134/comments"},"review_comments":{"href":"https://api.github.com/repos/ConnectBox/connectbox-pi/pulls/134/comments"},"review_comment":{"href":"https://api.github.com/repos/ConnectBox/connectbox-pi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ConnectBox/connectbox-pi/pulls/134/commits"},"statuses":{"href":"https://api.github.com/repos/ConnectBox/connectbox-pi/statuses/2502aed73233bf86a756220a69e3c99d996b192f"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"edwinsteele","id":1515215,"avatar_url":"https://avatars3.githubusercontent.com/u/1515215?v=3","gravatar_id":"","url":"https://api.github.com/users/edwinsteele","html_url":"https://github.com/edwinsteele","followers_url":"https://api.github.com/users/edwinsteele/followers","following_url":"https://api.github.com/users/edwinsteele/following{/other_user}","gists_url":"https://api.github.com/users/edwinsteele/gists{/gist_id}","starred_url":"https://api.github.com/users/edwinsteele/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edwinsteele/subscriptions","organizations_url":"https://api.github.com/users/edwinsteele/orgs","repos_url":"https://api.github.com/users/edwinsteele/repos","events_url":"https://api.github.com/users/edwinsteele/events{/privacy}","received_events_url":"https://api.github.com/users/edwinsteele/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"edwinsteele"}}