{"action":"created","comment":{"url":"https://api.github.com/repos/realm/realm-java/pulls/comments/108249310","pull_request_review_id":29268827,"id":108249310,"diff_hunk":"@@ -0,0 +1,112 @@\n+/*\n+ * Copyright 2015 Realm Inc.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+package io.realm;\n+\n+import java.util.Map;\n+import java.util.Set;\n+\n+import io.realm.internal.ColumnIndices;\n+import io.realm.internal.ColumnInfo;\n+import io.realm.internal.RealmProxyMediator;\n+import io.realm.internal.Table;\n+\n+\n+/**\n+ * Class for interacting with the Realm schema using a dynamic API. This makes it possible\n+ * to add, delete and change the classes in the Realm.\n+ * <p>\n+ * All changes must happen inside a write transaction for the particular Realm.\n+ *\n+ * @see RealmMigration\n+ */\n+public abstract class RealmBaseSchema {","path":"realm/realm-library/src/main/java/io/realm/RealmBaseSchema.java","position":36,"original_position":36,"commit_id":"7e032b640736a453937a2b890731156f20e29fa7","original_commit_id":"7e032b640736a453937a2b890731156f20e29fa7","user":{"login":"bmeike","id":277848,"avatar_url":"https://avatars1.githubusercontent.com/u/277848?v=3","gravatar_id":"","url":"https://api.github.com/users/bmeike","html_url":"https://github.com/bmeike","followers_url":"https://api.github.com/users/bmeike/followers","following_url":"https://api.github.com/users/bmeike/following{/other_user}","gists_url":"https://api.github.com/users/bmeike/gists{/gist_id}","starred_url":"https://api.github.com/users/bmeike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmeike/subscriptions","organizations_url":"https://api.github.com/users/bmeike/orgs","repos_url":"https://api.github.com/users/bmeike/repos","events_url":"https://api.github.com/users/bmeike/events{/privacy}","received_events_url":"https://api.github.com/users/bmeike/received_events","type":"User","site_admin":false},"body":"Yes!!  That's a huge improvement!  Excellent call.","created_at":"2017-03-27T18:47:39Z","updated_at":"2017-03-27T18:47:39Z","html_url":"https://github.com/realm/realm-java/pull/4382#discussion_r108249310","pull_request_url":"https://api.github.com/repos/realm/realm-java/pulls/4382","_links":{"self":{"href":"https://api.github.com/repos/realm/realm-java/pulls/comments/108249310"},"html":{"href":"https://github.com/realm/realm-java/pull/4382#discussion_r108249310"},"pull_request":{"href":"https://api.github.com/repos/realm/realm-java/pulls/4382"}}},"pull_request":{"url":"https://api.github.com/repos/realm/realm-java/pulls/4382","id":112567947,"html_url":"https://github.com/realm/realm-java/pull/4382","diff_url":"https://github.com/realm/realm-java/pull/4382.diff","patch_url":"https://github.com/realm/realm-java/pull/4382.patch","issue_url":"https://api.github.com/repos/realm/realm-java/issues/4382","number":4382,"state":"open","locked":false,"title":"Refactor Schemas into separate native and realm-based implementations","user":{"login":"bmeike","id":277848,"avatar_url":"https://avatars1.githubusercontent.com/u/277848?v=3","gravatar_id":"","url":"https://api.github.com/users/bmeike","html_url":"https://github.com/bmeike","followers_url":"https://api.github.com/users/bmeike/followers","following_url":"https://api.github.com/users/bmeike/following{/other_user}","gists_url":"https://api.github.com/users/bmeike/gists{/gist_id}","starred_url":"https://api.github.com/users/bmeike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmeike/subscriptions","organizations_url":"https://api.github.com/users/bmeike/orgs","repos_url":"https://api.github.com/users/bmeike/repos","events_url":"https://api.github.com/users/bmeike/events{/privacy}","received_events_url":"https://api.github.com/users/bmeike/received_events","type":"User","site_admin":false},"body":"I would like your opinion on this refactor.  I think it is mostly right, but, at this point I have done no test beyond making sure it compiles.  It illustrates my intention, though, without taking all the time to fix details.\r\n\r\nI think this is a significant improvement and I think it would make it much easier to migrate the code, slowly, to using ObjectStore.\r\n\r\nHave a look, if you would, and see if you agree.  Note that I am not particularly interested in bugs smaller than design-level problems.  I'm only trying to find out, at this point, if the basic idea is sound.","created_at":"2017-03-25T01:29:05Z","updated_at":"2017-03-27T18:47:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0353b1abe730865e2ae1c87ab855a09624f1f73b","assignee":{"login":"bmeike","id":277848,"avatar_url":"https://avatars1.githubusercontent.com/u/277848?v=3","gravatar_id":"","url":"https://api.github.com/users/bmeike","html_url":"https://github.com/bmeike","followers_url":"https://api.github.com/users/bmeike/followers","following_url":"https://api.github.com/users/bmeike/following{/other_user}","gists_url":"https://api.github.com/users/bmeike/gists{/gist_id}","starred_url":"https://api.github.com/users/bmeike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmeike/subscriptions","organizations_url":"https://api.github.com/users/bmeike/orgs","repos_url":"https://api.github.com/users/bmeike/repos","events_url":"https://api.github.com/users/bmeike/events{/privacy}","received_events_url":"https://api.github.com/users/bmeike/received_events","type":"User","site_admin":false},"assignees":[{"login":"bmeike","id":277848,"avatar_url":"https://avatars1.githubusercontent.com/u/277848?v=3","gravatar_id":"","url":"https://api.github.com/users/bmeike","html_url":"https://github.com/bmeike","followers_url":"https://api.github.com/users/bmeike/followers","following_url":"https://api.github.com/users/bmeike/following{/other_user}","gists_url":"https://api.github.com/users/bmeike/gists{/gist_id}","starred_url":"https://api.github.com/users/bmeike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmeike/subscriptions","organizations_url":"https://api.github.com/users/bmeike/orgs","repos_url":"https://api.github.com/users/bmeike/repos","events_url":"https://api.github.com/users/bmeike/events{/privacy}","received_events_url":"https://api.github.com/users/bmeike/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/realm/realm-java/pulls/4382/commits","review_comments_url":"https://api.github.com/repos/realm/realm-java/pulls/4382/comments","review_comment_url":"https://api.github.com/repos/realm/realm-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/realm/realm-java/issues/4382/comments","statuses_url":"https://api.github.com/repos/realm/realm-java/statuses/7e032b640736a453937a2b890731156f20e29fa7","head":{"label":"realm:balloon/schema","ref":"balloon/schema","sha":"7e032b640736a453937a2b890731156f20e29fa7","user":{"login":"realm","id":7575099,"avatar_url":"https://avatars3.githubusercontent.com/u/7575099?v=3","gravatar_id":"","url":"https://api.github.com/users/realm","html_url":"https://github.com/realm","followers_url":"https://api.github.com/users/realm/followers","following_url":"https://api.github.com/users/realm/following{/other_user}","gists_url":"https://api.github.com/users/realm/gists{/gist_id}","starred_url":"https://api.github.com/users/realm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/realm/subscriptions","organizations_url":"https://api.github.com/users/realm/orgs","repos_url":"https://api.github.com/users/realm/repos","events_url":"https://api.github.com/users/realm/events{/privacy}","received_events_url":"https://api.github.com/users/realm/received_events","type":"Organization","site_admin":false},"repo":{"id":4084908,"name":"realm-java","full_name":"realm/realm-java","owner":{"login":"realm","id":7575099,"avatar_url":"https://avatars3.githubusercontent.com/u/7575099?v=3","gravatar_id":"","url":"https://api.github.com/users/realm","html_url":"https://github.com/realm","followers_url":"https://api.github.com/users/realm/followers","following_url":"https://api.github.com/users/realm/following{/other_user}","gists_url":"https://api.github.com/users/realm/gists{/gist_id}","starred_url":"https://api.github.com/users/realm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/realm/subscriptions","organizations_url":"https://api.github.com/users/realm/orgs","repos_url":"https://api.github.com/users/realm/repos","events_url":"https://api.github.com/users/realm/events{/privacy}","received_events_url":"https://api.github.com/users/realm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/realm/realm-java","description":"Realm is a mobile database: a replacement for SQLite & ORMs","fork":false,"url":"https://api.github.com/repos/realm/realm-java","forks_url":"https://api.github.com/repos/realm/realm-java/forks","keys_url":"https://api.github.com/repos/realm/realm-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/realm/realm-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/realm/realm-java/teams","hooks_url":"https://api.github.com/repos/realm/realm-java/hooks","issue_events_url":"https://api.github.com/repos/realm/realm-java/issues/events{/number}","events_url":"https://api.github.com/repos/realm/realm-java/events","assignees_url":"https://api.github.com/repos/realm/realm-java/assignees{/user}","branches_url":"https://api.github.com/repos/realm/realm-java/branches{/branch}","tags_url":"https://api.github.com/repos/realm/realm-java/tags","blobs_url":"https://api.github.com/repos/realm/realm-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/realm/realm-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/realm/realm-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/realm/realm-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/realm/realm-java/statuses/{sha}","languages_url":"https://api.github.com/repos/realm/realm-java/languages","stargazers_url":"https://api.github.com/repos/realm/realm-java/stargazers","contributors_url":"https://api.github.com/repos/realm/realm-java/contributors","subscribers_url":"https://api.github.com/repos/realm/realm-java/subscribers","subscription_url":"https://api.github.com/repos/realm/realm-java/subscription","commits_url":"https://api.github.com/repos/realm/realm-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/realm/realm-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/realm/realm-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/realm/realm-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/realm/realm-java/contents/{+path}","compare_url":"https://api.github.com/repos/realm/realm-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/realm/realm-java/merges","archive_url":"https://api.github.com/repos/realm/realm-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/realm/realm-java/downloads","issues_url":"https://api.github.com/repos/realm/realm-java/issues{/number}","pulls_url":"https://api.github.com/repos/realm/realm-java/pulls{/number}","milestones_url":"https://api.github.com/repos/realm/realm-java/milestones{/number}","notifications_url":"https://api.github.com/repos/realm/realm-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/realm/realm-java/labels{/name}","releases_url":"https://api.github.com/repos/realm/realm-java/releases{/id}","deployments_url":"https://api.github.com/repos/realm/realm-java/deployments","created_at":"2012-04-20T09:18:42Z","updated_at":"2017-03-27T10:57:31Z","pushed_at":"2017-03-27T18:43:26Z","git_url":"git://github.com/realm/realm-java.git","ssh_url":"git@github.com:realm/realm-java.git","clone_url":"https://github.com/realm/realm-java.git","svn_url":"https://github.com/realm/realm-java","homepage":"http://realm.io","size":51283,"stargazers_count":7344,"watchers_count":7344,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1155,"mirror_url":null,"open_issues_count":324,"forks":1155,"open_issues":324,"watchers":7344,"default_branch":"master"}},"base":{"label":"realm:master","ref":"master","sha":"4ed4cd0382bf70b4907fbc7ca6ccd2a142211521","user":{"login":"realm","id":7575099,"avatar_url":"https://avatars3.githubusercontent.com/u/7575099?v=3","gravatar_id":"","url":"https://api.github.com/users/realm","html_url":"https://github.com/realm","followers_url":"https://api.github.com/users/realm/followers","following_url":"https://api.github.com/users/realm/following{/other_user}","gists_url":"https://api.github.com/users/realm/gists{/gist_id}","starred_url":"https://api.github.com/users/realm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/realm/subscriptions","organizations_url":"https://api.github.com/users/realm/orgs","repos_url":"https://api.github.com/users/realm/repos","events_url":"https://api.github.com/users/realm/events{/privacy}","received_events_url":"https://api.github.com/users/realm/received_events","type":"Organization","site_admin":false},"repo":{"id":4084908,"name":"realm-java","full_name":"realm/realm-java","owner":{"login":"realm","id":7575099,"avatar_url":"https://avatars3.githubusercontent.com/u/7575099?v=3","gravatar_id":"","url":"https://api.github.com/users/realm","html_url":"https://github.com/realm","followers_url":"https://api.github.com/users/realm/followers","following_url":"https://api.github.com/users/realm/following{/other_user}","gists_url":"https://api.github.com/users/realm/gists{/gist_id}","starred_url":"https://api.github.com/users/realm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/realm/subscriptions","organizations_url":"https://api.github.com/users/realm/orgs","repos_url":"https://api.github.com/users/realm/repos","events_url":"https://api.github.com/users/realm/events{/privacy}","received_events_url":"https://api.github.com/users/realm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/realm/realm-java","description":"Realm is a mobile database: a replacement for SQLite & ORMs","fork":false,"url":"https://api.github.com/repos/realm/realm-java","forks_url":"https://api.github.com/repos/realm/realm-java/forks","keys_url":"https://api.github.com/repos/realm/realm-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/realm/realm-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/realm/realm-java/teams","hooks_url":"https://api.github.com/repos/realm/realm-java/hooks","issue_events_url":"https://api.github.com/repos/realm/realm-java/issues/events{/number}","events_url":"https://api.github.com/repos/realm/realm-java/events","assignees_url":"https://api.github.com/repos/realm/realm-java/assignees{/user}","branches_url":"https://api.github.com/repos/realm/realm-java/branches{/branch}","tags_url":"https://api.github.com/repos/realm/realm-java/tags","blobs_url":"https://api.github.com/repos/realm/realm-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/realm/realm-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/realm/realm-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/realm/realm-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/realm/realm-java/statuses/{sha}","languages_url":"https://api.github.com/repos/realm/realm-java/languages","stargazers_url":"https://api.github.com/repos/realm/realm-java/stargazers","contributors_url":"https://api.github.com/repos/realm/realm-java/contributors","subscribers_url":"https://api.github.com/repos/realm/realm-java/subscribers","subscription_url":"https://api.github.com/repos/realm/realm-java/subscription","commits_url":"https://api.github.com/repos/realm/realm-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/realm/realm-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/realm/realm-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/realm/realm-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/realm/realm-java/contents/{+path}","compare_url":"https://api.github.com/repos/realm/realm-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/realm/realm-java/merges","archive_url":"https://api.github.com/repos/realm/realm-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/realm/realm-java/downloads","issues_url":"https://api.github.com/repos/realm/realm-java/issues{/number}","pulls_url":"https://api.github.com/repos/realm/realm-java/pulls{/number}","milestones_url":"https://api.github.com/repos/realm/realm-java/milestones{/number}","notifications_url":"https://api.github.com/repos/realm/realm-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/realm/realm-java/labels{/name}","releases_url":"https://api.github.com/repos/realm/realm-java/releases{/id}","deployments_url":"https://api.github.com/repos/realm/realm-java/deployments","created_at":"2012-04-20T09:18:42Z","updated_at":"2017-03-27T10:57:31Z","pushed_at":"2017-03-27T18:43:26Z","git_url":"git://github.com/realm/realm-java.git","ssh_url":"git@github.com:realm/realm-java.git","clone_url":"https://github.com/realm/realm-java.git","svn_url":"https://github.com/realm/realm-java","homepage":"http://realm.io","size":51283,"stargazers_count":7344,"watchers_count":7344,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1155,"mirror_url":null,"open_issues_count":324,"forks":1155,"open_issues":324,"watchers":7344,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/realm/realm-java/pulls/4382"},"html":{"href":"https://github.com/realm/realm-java/pull/4382"},"issue":{"href":"https://api.github.com/repos/realm/realm-java/issues/4382"},"comments":{"href":"https://api.github.com/repos/realm/realm-java/issues/4382/comments"},"review_comments":{"href":"https://api.github.com/repos/realm/realm-java/pulls/4382/comments"},"review_comment":{"href":"https://api.github.com/repos/realm/realm-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/realm/realm-java/pulls/4382/commits"},"statuses":{"href":"https://api.github.com/repos/realm/realm-java/statuses/7e032b640736a453937a2b890731156f20e29fa7"}}}}
{"actor":{"display_login":"bmeike"}}