{"action":"created","comment":{"url":"https://api.github.com/repos/samsung-cnct/k2/pulls/comments/130358499","pull_request_review_id":53224099,"id":130358499,"diff_hunk":"@@ -51,6 +51,15 @@\n       \"minItems\": 1,\n       \"type\": \"array\"\n     },\n+    \"bastionConfigs\": {\n+      \"title\": \"Bastion configurations\",\n+      \"description\": \"A list of bastion configurations within the configuration file.\",\n+      \"items\": {\n+        \"$ref\": \"bastionConfig.json\"\n+      },\n+      \"minItems\": 0,","path":"schemas/config/v1/definitions.json","position":10,"original_position":10,"commit_id":"c89914027500eb2276c39adf3c30c8d120ce13db","original_commit_id":"c89914027500eb2276c39adf3c30c8d120ce13db","user":{"login":"alejandroEsc","id":20777618,"avatar_url":"https://avatars0.githubusercontent.com/u/20777618?v=4","gravatar_id":"","url":"https://api.github.com/users/alejandroEsc","html_url":"https://github.com/alejandroEsc","followers_url":"https://api.github.com/users/alejandroEsc/followers","following_url":"https://api.github.com/users/alejandroEsc/following{/other_user}","gists_url":"https://api.github.com/users/alejandroEsc/gists{/gist_id}","starred_url":"https://api.github.com/users/alejandroEsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alejandroEsc/subscriptions","organizations_url":"https://api.github.com/users/alejandroEsc/orgs","repos_url":"https://api.github.com/users/alejandroEsc/repos","events_url":"https://api.github.com/users/alejandroEsc/events{/privacy}","received_events_url":"https://api.github.com/users/alejandroEsc/received_events","type":"User","site_admin":false},"body":"would we expect the schema check error if I do not list an item in that case?","created_at":"2017-07-31T13:55:29Z","updated_at":"2017-07-31T13:55:30Z","html_url":"https://github.com/samsung-cnct/k2/pull/682#discussion_r130358499","pull_request_url":"https://api.github.com/repos/samsung-cnct/k2/pulls/682","_links":{"self":{"href":"https://api.github.com/repos/samsung-cnct/k2/pulls/comments/130358499"},"html":{"href":"https://github.com/samsung-cnct/k2/pull/682#discussion_r130358499"},"pull_request":{"href":"https://api.github.com/repos/samsung-cnct/k2/pulls/682"}}},"pull_request":{"url":"https://api.github.com/repos/samsung-cnct/k2/pulls/682","id":132976964,"html_url":"https://github.com/samsung-cnct/k2/pull/682","diff_url":"https://github.com/samsung-cnct/k2/pull/682.diff","patch_url":"https://github.com/samsung-cnct/k2/pull/682.patch","issue_url":"https://api.github.com/repos/samsung-cnct/k2/issues/682","number":682,"state":"open","locked":false,"title":"Add Bastion Nodepool object","user":{"login":"alejandroEsc","id":20777618,"avatar_url":"https://avatars0.githubusercontent.com/u/20777618?v=4","gravatar_id":"","url":"https://api.github.com/users/alejandroEsc","html_url":"https://github.com/alejandroEsc","followers_url":"https://api.github.com/users/alejandroEsc/followers","following_url":"https://api.github.com/users/alejandroEsc/following{/other_user}","gists_url":"https://api.github.com/users/alejandroEsc/gists{/gist_id}","starred_url":"https://api.github.com/users/alejandroEsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alejandroEsc/subscriptions","organizations_url":"https://api.github.com/users/alejandroEsc/orgs","repos_url":"https://api.github.com/users/alejandroEsc/repos","events_url":"https://api.github.com/users/alejandroEsc/events{/privacy}","received_events_url":"https://api.github.com/users/alejandroEsc/received_events","type":"User","site_admin":false},"body":"First pass PR for adding nodepool object: Bastion\r\n\r\n- DO NOT MERGE\r\n\r\n- [x] Clean up\r\n- [ ] Confirm with @coffeepac that nodepool task and changes are ok.\r\n- [x] Add working config example of private network with Bastion used. (BYO VPC only atm)\r\n\r\nfixes: https://github.com/samsung-cnct/k2/issues/659","created_at":"2017-07-28T14:09:05Z","updated_at":"2017-07-31T13:55:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e94dfc9bd3e35681f8fbd70311d0b81e80b4e22f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"sostheim","id":1169999,"avatar_url":"https://avatars2.githubusercontent.com/u/1169999?v=4","gravatar_id":"","url":"https://api.github.com/users/sostheim","html_url":"https://github.com/sostheim","followers_url":"https://api.github.com/users/sostheim/followers","following_url":"https://api.github.com/users/sostheim/following{/other_user}","gists_url":"https://api.github.com/users/sostheim/gists{/gist_id}","starred_url":"https://api.github.com/users/sostheim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sostheim/subscriptions","organizations_url":"https://api.github.com/users/sostheim/orgs","repos_url":"https://api.github.com/users/sostheim/repos","events_url":"https://api.github.com/users/sostheim/events{/privacy}","received_events_url":"https://api.github.com/users/sostheim/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/samsung-cnct/k2/pulls/682/commits","review_comments_url":"https://api.github.com/repos/samsung-cnct/k2/pulls/682/comments","review_comment_url":"https://api.github.com/repos/samsung-cnct/k2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/samsung-cnct/k2/issues/682/comments","statuses_url":"https://api.github.com/repos/samsung-cnct/k2/statuses/c89914027500eb2276c39adf3c30c8d120ce13db","head":{"label":"alejandroEsc:ae/issue/659","ref":"ae/issue/659","sha":"c89914027500eb2276c39adf3c30c8d120ce13db","user":{"login":"alejandroEsc","id":20777618,"avatar_url":"https://avatars0.githubusercontent.com/u/20777618?v=4","gravatar_id":"","url":"https://api.github.com/users/alejandroEsc","html_url":"https://github.com/alejandroEsc","followers_url":"https://api.github.com/users/alejandroEsc/followers","following_url":"https://api.github.com/users/alejandroEsc/following{/other_user}","gists_url":"https://api.github.com/users/alejandroEsc/gists{/gist_id}","starred_url":"https://api.github.com/users/alejandroEsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alejandroEsc/subscriptions","organizations_url":"https://api.github.com/users/alejandroEsc/orgs","repos_url":"https://api.github.com/users/alejandroEsc/repos","events_url":"https://api.github.com/users/alejandroEsc/events{/privacy}","received_events_url":"https://api.github.com/users/alejandroEsc/received_events","type":"User","site_admin":false},"repo":{"id":69294024,"name":"k2","full_name":"alejandroEsc/k2","owner":{"login":"alejandroEsc","id":20777618,"avatar_url":"https://avatars0.githubusercontent.com/u/20777618?v=4","gravatar_id":"","url":"https://api.github.com/users/alejandroEsc","html_url":"https://github.com/alejandroEsc","followers_url":"https://api.github.com/users/alejandroEsc/followers","following_url":"https://api.github.com/users/alejandroEsc/following{/other_user}","gists_url":"https://api.github.com/users/alejandroEsc/gists{/gist_id}","starred_url":"https://api.github.com/users/alejandroEsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alejandroEsc/subscriptions","organizations_url":"https://api.github.com/users/alejandroEsc/orgs","repos_url":"https://api.github.com/users/alejandroEsc/repos","events_url":"https://api.github.com/users/alejandroEsc/events{/privacy}","received_events_url":"https://api.github.com/users/alejandroEsc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alejandroEsc/k2","description":"K2 (Kraken 2)","fork":true,"url":"https://api.github.com/repos/alejandroEsc/k2","forks_url":"https://api.github.com/repos/alejandroEsc/k2/forks","keys_url":"https://api.github.com/repos/alejandroEsc/k2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alejandroEsc/k2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alejandroEsc/k2/teams","hooks_url":"https://api.github.com/repos/alejandroEsc/k2/hooks","issue_events_url":"https://api.github.com/repos/alejandroEsc/k2/issues/events{/number}","events_url":"https://api.github.com/repos/alejandroEsc/k2/events","assignees_url":"https://api.github.com/repos/alejandroEsc/k2/assignees{/user}","branches_url":"https://api.github.com/repos/alejandroEsc/k2/branches{/branch}","tags_url":"https://api.github.com/repos/alejandroEsc/k2/tags","blobs_url":"https://api.github.com/repos/alejandroEsc/k2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alejandroEsc/k2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alejandroEsc/k2/git/refs{/sha}","trees_url":"https://api.github.com/repos/alejandroEsc/k2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alejandroEsc/k2/statuses/{sha}","languages_url":"https://api.github.com/repos/alejandroEsc/k2/languages","stargazers_url":"https://api.github.com/repos/alejandroEsc/k2/stargazers","contributors_url":"https://api.github.com/repos/alejandroEsc/k2/contributors","subscribers_url":"https://api.github.com/repos/alejandroEsc/k2/subscribers","subscription_url":"https://api.github.com/repos/alejandroEsc/k2/subscription","commits_url":"https://api.github.com/repos/alejandroEsc/k2/commits{/sha}","git_commits_url":"https://api.github.com/repos/alejandroEsc/k2/git/commits{/sha}","comments_url":"https://api.github.com/repos/alejandroEsc/k2/comments{/number}","issue_comment_url":"https://api.github.com/repos/alejandroEsc/k2/issues/comments{/number}","contents_url":"https://api.github.com/repos/alejandroEsc/k2/contents/{+path}","compare_url":"https://api.github.com/repos/alejandroEsc/k2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alejandroEsc/k2/merges","archive_url":"https://api.github.com/repos/alejandroEsc/k2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alejandroEsc/k2/downloads","issues_url":"https://api.github.com/repos/alejandroEsc/k2/issues{/number}","pulls_url":"https://api.github.com/repos/alejandroEsc/k2/pulls{/number}","milestones_url":"https://api.github.com/repos/alejandroEsc/k2/milestones{/number}","notifications_url":"https://api.github.com/repos/alejandroEsc/k2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alejandroEsc/k2/labels{/name}","releases_url":"https://api.github.com/repos/alejandroEsc/k2/releases{/id}","deployments_url":"https://api.github.com/repos/alejandroEsc/k2/deployments","created_at":"2016-09-26T21:22:58Z","updated_at":"2017-01-10T04:29:45Z","pushed_at":"2017-07-28T16:51:14Z","git_url":"git://github.com/alejandroEsc/k2.git","ssh_url":"git@github.com:alejandroEsc/k2.git","clone_url":"https://github.com/alejandroEsc/k2.git","svn_url":"https://github.com/alejandroEsc/k2","homepage":null,"size":2745,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"samsung-cnct:master","ref":"master","sha":"097c32ff308b34bda036e91a38c838641bbbd26b","user":{"login":"samsung-cnct","id":11511065,"avatar_url":"https://avatars3.githubusercontent.com/u/11511065?v=4","gravatar_id":"","url":"https://api.github.com/users/samsung-cnct","html_url":"https://github.com/samsung-cnct","followers_url":"https://api.github.com/users/samsung-cnct/followers","following_url":"https://api.github.com/users/samsung-cnct/following{/other_user}","gists_url":"https://api.github.com/users/samsung-cnct/gists{/gist_id}","starred_url":"https://api.github.com/users/samsung-cnct/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samsung-cnct/subscriptions","organizations_url":"https://api.github.com/users/samsung-cnct/orgs","repos_url":"https://api.github.com/users/samsung-cnct/repos","events_url":"https://api.github.com/users/samsung-cnct/events{/privacy}","received_events_url":"https://api.github.com/users/samsung-cnct/received_events","type":"Organization","site_admin":false},"repo":{"id":68646823,"name":"k2","full_name":"samsung-cnct/k2","owner":{"login":"samsung-cnct","id":11511065,"avatar_url":"https://avatars3.githubusercontent.com/u/11511065?v=4","gravatar_id":"","url":"https://api.github.com/users/samsung-cnct","html_url":"https://github.com/samsung-cnct","followers_url":"https://api.github.com/users/samsung-cnct/followers","following_url":"https://api.github.com/users/samsung-cnct/following{/other_user}","gists_url":"https://api.github.com/users/samsung-cnct/gists{/gist_id}","starred_url":"https://api.github.com/users/samsung-cnct/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samsung-cnct/subscriptions","organizations_url":"https://api.github.com/users/samsung-cnct/orgs","repos_url":"https://api.github.com/users/samsung-cnct/repos","events_url":"https://api.github.com/users/samsung-cnct/events{/privacy}","received_events_url":"https://api.github.com/users/samsung-cnct/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/samsung-cnct/k2","description":"K2 (Kraken 2)","fork":false,"url":"https://api.github.com/repos/samsung-cnct/k2","forks_url":"https://api.github.com/repos/samsung-cnct/k2/forks","keys_url":"https://api.github.com/repos/samsung-cnct/k2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/samsung-cnct/k2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/samsung-cnct/k2/teams","hooks_url":"https://api.github.com/repos/samsung-cnct/k2/hooks","issue_events_url":"https://api.github.com/repos/samsung-cnct/k2/issues/events{/number}","events_url":"https://api.github.com/repos/samsung-cnct/k2/events","assignees_url":"https://api.github.com/repos/samsung-cnct/k2/assignees{/user}","branches_url":"https://api.github.com/repos/samsung-cnct/k2/branches{/branch}","tags_url":"https://api.github.com/repos/samsung-cnct/k2/tags","blobs_url":"https://api.github.com/repos/samsung-cnct/k2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/samsung-cnct/k2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/samsung-cnct/k2/git/refs{/sha}","trees_url":"https://api.github.com/repos/samsung-cnct/k2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/samsung-cnct/k2/statuses/{sha}","languages_url":"https://api.github.com/repos/samsung-cnct/k2/languages","stargazers_url":"https://api.github.com/repos/samsung-cnct/k2/stargazers","contributors_url":"https://api.github.com/repos/samsung-cnct/k2/contributors","subscribers_url":"https://api.github.com/repos/samsung-cnct/k2/subscribers","subscription_url":"https://api.github.com/repos/samsung-cnct/k2/subscription","commits_url":"https://api.github.com/repos/samsung-cnct/k2/commits{/sha}","git_commits_url":"https://api.github.com/repos/samsung-cnct/k2/git/commits{/sha}","comments_url":"https://api.github.com/repos/samsung-cnct/k2/comments{/number}","issue_comment_url":"https://api.github.com/repos/samsung-cnct/k2/issues/comments{/number}","contents_url":"https://api.github.com/repos/samsung-cnct/k2/contents/{+path}","compare_url":"https://api.github.com/repos/samsung-cnct/k2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/samsung-cnct/k2/merges","archive_url":"https://api.github.com/repos/samsung-cnct/k2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/samsung-cnct/k2/downloads","issues_url":"https://api.github.com/repos/samsung-cnct/k2/issues{/number}","pulls_url":"https://api.github.com/repos/samsung-cnct/k2/pulls{/number}","milestones_url":"https://api.github.com/repos/samsung-cnct/k2/milestones{/number}","notifications_url":"https://api.github.com/repos/samsung-cnct/k2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/samsung-cnct/k2/labels{/name}","releases_url":"https://api.github.com/repos/samsung-cnct/k2/releases{/id}","deployments_url":"https://api.github.com/repos/samsung-cnct/k2/deployments","created_at":"2016-09-19T21:07:47Z","updated_at":"2017-07-27T08:35:17Z","pushed_at":"2017-07-31T00:08:26Z","git_url":"git://github.com/samsung-cnct/k2.git","ssh_url":"git@github.com:samsung-cnct/k2.git","clone_url":"https://github.com/samsung-cnct/k2.git","svn_url":"https://github.com/samsung-cnct/k2","homepage":null,"size":2740,"stargazers_count":71,"watchers_count":71,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":31,"mirror_url":null,"open_issues_count":139,"forks":31,"open_issues":139,"watchers":71,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/samsung-cnct/k2/pulls/682"},"html":{"href":"https://github.com/samsung-cnct/k2/pull/682"},"issue":{"href":"https://api.github.com/repos/samsung-cnct/k2/issues/682"},"comments":{"href":"https://api.github.com/repos/samsung-cnct/k2/issues/682/comments"},"review_comments":{"href":"https://api.github.com/repos/samsung-cnct/k2/pulls/682/comments"},"review_comment":{"href":"https://api.github.com/repos/samsung-cnct/k2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/samsung-cnct/k2/pulls/682/commits"},"statuses":{"href":"https://api.github.com/repos/samsung-cnct/k2/statuses/c89914027500eb2276c39adf3c30c8d120ce13db"}}}}
{"actor":{"display_login":"alejandroEsc"}}