{"action":"created","comment":{"url":"https://api.github.com/repos/chef/chef/pulls/comments/133670900","pull_request_review_id":56874989,"id":133670900,"diff_hunk":"@@ -214,6 +217,35 @@ def task_need_update?\n         false\n       end\n \n+      def compare_day\n+        current_day = convert_system_dateformat_into_ruby_date(@current_resource.start_day).strftime(\"%m/%d/%Y\")\n+        new_day = convert_system_dateformat_into_ruby_date(new_resource.start_day).strftime(\"%m/%d/%Y\")\n+        current_day != new_day\n+      end\n+\n+      def compare_time\n+        time = convert_system_dateformat_into_ruby_date(@current_resource.start_time).strftime(\"%H:%M\")\n+        time != new_resource.start_time\n+      end\n+\n+      def convert_system_dateformat_into_ruby_date(date_in_string)\n+        Chef::Log.debug \"Looking system date format\"\n+        task_script = <<-EOH\n+          [Console]::OutputEncoding = [Text.UTF8Encoding]::UTF8\n+          ([datetime]'#{date_in_string}').ToString('yyyy-MM-dd HH:mm')\n+        EOH","path":"lib/chef/provider/windows_task.rb","position":63,"original_position":63,"commit_id":"f78c86ff8d49abe56348f7a091a8ad1a8ffa0382","original_commit_id":"f78c86ff8d49abe56348f7a091a8ad1a8ffa0382","user":{"login":"NimishaS","id":1298875,"avatar_url":"https://avatars3.githubusercontent.com/u/1298875?v=4","gravatar_id":"","url":"https://api.github.com/users/NimishaS","html_url":"https://github.com/NimishaS","followers_url":"https://api.github.com/users/NimishaS/followers","following_url":"https://api.github.com/users/NimishaS/following{/other_user}","gists_url":"https://api.github.com/users/NimishaS/gists{/gist_id}","starred_url":"https://api.github.com/users/NimishaS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NimishaS/subscriptions","organizations_url":"https://api.github.com/users/NimishaS/orgs","repos_url":"https://api.github.com/users/NimishaS/repos","events_url":"https://api.github.com/users/NimishaS/events{/privacy}","received_events_url":"https://api.github.com/users/NimishaS/received_events","type":"User","site_admin":false},"body":"Please add some comments to explain this code. Comments can be added here or at the place where this method is being called.","created_at":"2017-08-17T09:57:51Z","updated_at":"2017-08-17T09:58:36Z","html_url":"https://github.com/chef/chef/pull/6312#discussion_r133670900","pull_request_url":"https://api.github.com/repos/chef/chef/pulls/6312","_links":{"self":{"href":"https://api.github.com/repos/chef/chef/pulls/comments/133670900"},"html":{"href":"https://github.com/chef/chef/pull/6312#discussion_r133670900"},"pull_request":{"href":"https://api.github.com/repos/chef/chef/pulls/6312"}}},"pull_request":{"url":"https://api.github.com/repos/chef/chef/pulls/6312","id":134889519,"html_url":"https://github.com/chef/chef/pull/6312","diff_url":"https://github.com/chef/chef/pull/6312.diff","patch_url":"https://github.com/chef/chef/pull/6312.patch","issue_url":"https://api.github.com/repos/chef/chef/issues/6312","number":6312,"state":"open","locked":false,"title":"[MSYS-594] windows_task resource is not idempotent when specifying start_time and start_day","user":{"login":"harikesh-kolekar","id":16129332,"avatar_url":"https://avatars0.githubusercontent.com/u/16129332?v=4","gravatar_id":"","url":"https://api.github.com/users/harikesh-kolekar","html_url":"https://github.com/harikesh-kolekar","followers_url":"https://api.github.com/users/harikesh-kolekar/followers","following_url":"https://api.github.com/users/harikesh-kolekar/following{/other_user}","gists_url":"https://api.github.com/users/harikesh-kolekar/gists{/gist_id}","starred_url":"https://api.github.com/users/harikesh-kolekar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harikesh-kolekar/subscriptions","organizations_url":"https://api.github.com/users/harikesh-kolekar/orgs","repos_url":"https://api.github.com/users/harikesh-kolekar/repos","events_url":"https://api.github.com/users/harikesh-kolekar/events{/privacy}","received_events_url":"https://api.github.com/users/harikesh-kolekar/received_events","type":"User","site_admin":false},"body":"\r\n### Description\r\nwindows_task resource is not idempotent when specifying start_time\r\nfixes #6093\r\n### Check List\r\n\r\n- [ ] New functionality includes tests\r\n- [ ] All tests pass\r\n- [ ] RELEASE\\_NOTES.md, has been updated if required (not required for bugfixes, required for API changes)\r\n- [x] All commits have been signed-off for the Developer Certificate of Origin. See <https://github.com/chef/chef/blob/master/CONTRIBUTING.md#developer-certification-of-origin-dco>\r\n","created_at":"2017-08-09T13:13:25Z","updated_at":"2017-08-17T09:58:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8b3bb839da4c3e9f7b61f3dc8eca3cfc7a4a35bd","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/chef/chef/pulls/6312/commits","review_comments_url":"https://api.github.com/repos/chef/chef/pulls/6312/comments","review_comment_url":"https://api.github.com/repos/chef/chef/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chef/chef/issues/6312/comments","statuses_url":"https://api.github.com/repos/chef/chef/statuses/f78c86ff8d49abe56348f7a091a8ad1a8ffa0382","head":{"label":"MsysTechnologiesllc:windows_task_resource_is_not_idempotent","ref":"windows_task_resource_is_not_idempotent","sha":"f78c86ff8d49abe56348f7a091a8ad1a8ffa0382","user":{"login":"MsysTechnologiesllc","id":2493241,"avatar_url":"https://avatars3.githubusercontent.com/u/2493241?v=4","gravatar_id":"","url":"https://api.github.com/users/MsysTechnologiesllc","html_url":"https://github.com/MsysTechnologiesllc","followers_url":"https://api.github.com/users/MsysTechnologiesllc/followers","following_url":"https://api.github.com/users/MsysTechnologiesllc/following{/other_user}","gists_url":"https://api.github.com/users/MsysTechnologiesllc/gists{/gist_id}","starred_url":"https://api.github.com/users/MsysTechnologiesllc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MsysTechnologiesllc/subscriptions","organizations_url":"https://api.github.com/users/MsysTechnologiesllc/orgs","repos_url":"https://api.github.com/users/MsysTechnologiesllc/repos","events_url":"https://api.github.com/users/MsysTechnologiesllc/events{/privacy}","received_events_url":"https://api.github.com/users/MsysTechnologiesllc/received_events","type":"Organization","site_admin":false},"repo":{"id":8683912,"name":"chef","full_name":"MsysTechnologiesllc/chef","owner":{"login":"MsysTechnologiesllc","id":2493241,"avatar_url":"https://avatars3.githubusercontent.com/u/2493241?v=4","gravatar_id":"","url":"https://api.github.com/users/MsysTechnologiesllc","html_url":"https://github.com/MsysTechnologiesllc","followers_url":"https://api.github.com/users/MsysTechnologiesllc/followers","following_url":"https://api.github.com/users/MsysTechnologiesllc/following{/other_user}","gists_url":"https://api.github.com/users/MsysTechnologiesllc/gists{/gist_id}","starred_url":"https://api.github.com/users/MsysTechnologiesllc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MsysTechnologiesllc/subscriptions","organizations_url":"https://api.github.com/users/MsysTechnologiesllc/orgs","repos_url":"https://api.github.com/users/MsysTechnologiesllc/repos","events_url":"https://api.github.com/users/MsysTechnologiesllc/events{/privacy}","received_events_url":"https://api.github.com/users/MsysTechnologiesllc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MsysTechnologiesllc/chef","description":"A systems integration framework, built to bring the benefits of configuration management to your entire infrastructure.","fork":true,"url":"https://api.github.com/repos/MsysTechnologiesllc/chef","forks_url":"https://api.github.com/repos/MsysTechnologiesllc/chef/forks","keys_url":"https://api.github.com/repos/MsysTechnologiesllc/chef/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MsysTechnologiesllc/chef/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MsysTechnologiesllc/chef/teams","hooks_url":"https://api.github.com/repos/MsysTechnologiesllc/chef/hooks","issue_events_url":"https://api.github.com/repos/MsysTechnologiesllc/chef/issues/events{/number}","events_url":"https://api.github.com/repos/MsysTechnologiesllc/chef/events","assignees_url":"https://api.github.com/repos/MsysTechnologiesllc/chef/assignees{/user}","branches_url":"https://api.github.com/repos/MsysTechnologiesllc/chef/branches{/branch}","tags_url":"https://api.github.com/repos/MsysTechnologiesllc/chef/tags","blobs_url":"https://api.github.com/repos/MsysTechnologiesllc/chef/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MsysTechnologiesllc/chef/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MsysTechnologiesllc/chef/git/refs{/sha}","trees_url":"https://api.github.com/repos/MsysTechnologiesllc/chef/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MsysTechnologiesllc/chef/statuses/{sha}","languages_url":"https://api.github.com/repos/MsysTechnologiesllc/chef/languages","stargazers_url":"https://api.github.com/repos/MsysTechnologiesllc/chef/stargazers","contributors_url":"https://api.github.com/repos/MsysTechnologiesllc/chef/contributors","subscribers_url":"https://api.github.com/repos/MsysTechnologiesllc/chef/subscribers","subscription_url":"https://api.github.com/repos/MsysTechnologiesllc/chef/subscription","commits_url":"https://api.github.com/repos/MsysTechnologiesllc/chef/commits{/sha}","git_commits_url":"https://api.github.com/repos/MsysTechnologiesllc/chef/git/commits{/sha}","comments_url":"https://api.github.com/repos/MsysTechnologiesllc/chef/comments{/number}","issue_comment_url":"https://api.github.com/repos/MsysTechnologiesllc/chef/issues/comments{/number}","contents_url":"https://api.github.com/repos/MsysTechnologiesllc/chef/contents/{+path}","compare_url":"https://api.github.com/repos/MsysTechnologiesllc/chef/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MsysTechnologiesllc/chef/merges","archive_url":"https://api.github.com/repos/MsysTechnologiesllc/chef/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MsysTechnologiesllc/chef/downloads","issues_url":"https://api.github.com/repos/MsysTechnologiesllc/chef/issues{/number}","pulls_url":"https://api.github.com/repos/MsysTechnologiesllc/chef/pulls{/number}","milestones_url":"https://api.github.com/repos/MsysTechnologiesllc/chef/milestones{/number}","notifications_url":"https://api.github.com/repos/MsysTechnologiesllc/chef/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MsysTechnologiesllc/chef/labels{/name}","releases_url":"https://api.github.com/repos/MsysTechnologiesllc/chef/releases{/id}","deployments_url":"https://api.github.com/repos/MsysTechnologiesllc/chef/deployments","created_at":"2013-03-10T10:56:49Z","updated_at":"2015-04-17T14:02:45Z","pushed_at":"2017-08-17T06:53:49Z","git_url":"git://github.com/MsysTechnologiesllc/chef.git","ssh_url":"git@github.com:MsysTechnologiesllc/chef.git","clone_url":"https://github.com/MsysTechnologiesllc/chef.git","svn_url":"https://github.com/MsysTechnologiesllc/chef","homepage":"http://www.opscode.com/chef/","size":96606,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"chef:master","ref":"master","sha":"d09aa4556a539db269ff5a6f46c830e302877bbb","user":{"login":"chef","id":29740,"avatar_url":"https://avatars3.githubusercontent.com/u/29740?v=4","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"repo":{"id":108278,"name":"chef","full_name":"chef/chef","owner":{"login":"chef","id":29740,"avatar_url":"https://avatars3.githubusercontent.com/u/29740?v=4","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chef/chef","description":"A systems integration framework, built to bring the benefits of configuration management to your entire infrastructure.","fork":false,"url":"https://api.github.com/repos/chef/chef","forks_url":"https://api.github.com/repos/chef/chef/forks","keys_url":"https://api.github.com/repos/chef/chef/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chef/chef/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chef/chef/teams","hooks_url":"https://api.github.com/repos/chef/chef/hooks","issue_events_url":"https://api.github.com/repos/chef/chef/issues/events{/number}","events_url":"https://api.github.com/repos/chef/chef/events","assignees_url":"https://api.github.com/repos/chef/chef/assignees{/user}","branches_url":"https://api.github.com/repos/chef/chef/branches{/branch}","tags_url":"https://api.github.com/repos/chef/chef/tags","blobs_url":"https://api.github.com/repos/chef/chef/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chef/chef/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chef/chef/git/refs{/sha}","trees_url":"https://api.github.com/repos/chef/chef/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chef/chef/statuses/{sha}","languages_url":"https://api.github.com/repos/chef/chef/languages","stargazers_url":"https://api.github.com/repos/chef/chef/stargazers","contributors_url":"https://api.github.com/repos/chef/chef/contributors","subscribers_url":"https://api.github.com/repos/chef/chef/subscribers","subscription_url":"https://api.github.com/repos/chef/chef/subscription","commits_url":"https://api.github.com/repos/chef/chef/commits{/sha}","git_commits_url":"https://api.github.com/repos/chef/chef/git/commits{/sha}","comments_url":"https://api.github.com/repos/chef/chef/comments{/number}","issue_comment_url":"https://api.github.com/repos/chef/chef/issues/comments{/number}","contents_url":"https://api.github.com/repos/chef/chef/contents/{+path}","compare_url":"https://api.github.com/repos/chef/chef/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chef/chef/merges","archive_url":"https://api.github.com/repos/chef/chef/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chef/chef/downloads","issues_url":"https://api.github.com/repos/chef/chef/issues{/number}","pulls_url":"https://api.github.com/repos/chef/chef/pulls{/number}","milestones_url":"https://api.github.com/repos/chef/chef/milestones{/number}","notifications_url":"https://api.github.com/repos/chef/chef/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chef/chef/labels{/name}","releases_url":"https://api.github.com/repos/chef/chef/releases{/id}","deployments_url":"https://api.github.com/repos/chef/chef/deployments","created_at":"2009-01-15T20:40:48Z","updated_at":"2017-08-17T03:01:52Z","pushed_at":"2017-08-17T06:53:52Z","git_url":"git://github.com/chef/chef.git","ssh_url":"git@github.com:chef/chef.git","clone_url":"https://github.com/chef/chef.git","svn_url":"https://github.com/chef/chef","homepage":"http://www.chef.io/chef/","size":98924,"stargazers_count":4949,"watchers_count":4949,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2063,"mirror_url":null,"open_issues_count":557,"forks":2063,"open_issues":557,"watchers":4949,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chef/chef/pulls/6312"},"html":{"href":"https://github.com/chef/chef/pull/6312"},"issue":{"href":"https://api.github.com/repos/chef/chef/issues/6312"},"comments":{"href":"https://api.github.com/repos/chef/chef/issues/6312/comments"},"review_comments":{"href":"https://api.github.com/repos/chef/chef/pulls/6312/comments"},"review_comment":{"href":"https://api.github.com/repos/chef/chef/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chef/chef/pulls/6312/commits"},"statuses":{"href":"https://api.github.com/repos/chef/chef/statuses/f78c86ff8d49abe56348f7a091a8ad1a8ffa0382"}}}}
{"actor":{"display_login":"NimishaS"}}