{"action":"created","issue":{"url":"https://api.github.com/repos/youtube/vitess/issues/3056","repository_url":"https://api.github.com/repos/youtube/vitess","labels_url":"https://api.github.com/repos/youtube/vitess/issues/3056/labels{/name}","comments_url":"https://api.github.com/repos/youtube/vitess/issues/3056/comments","events_url":"https://api.github.com/repos/youtube/vitess/issues/3056/events","html_url":"https://github.com/youtube/vitess/pull/3056","id":249853225,"number":3056,"title":"Adds support for common SET commands from sql clients","user":{"login":"bbeaudreault","id":116591,"avatar_url":"https://avatars2.githubusercontent.com/u/116591?v=4","gravatar_id":"","url":"https://api.github.com/users/bbeaudreault","html_url":"https://github.com/bbeaudreault","followers_url":"https://api.github.com/users/bbeaudreault/followers","following_url":"https://api.github.com/users/bbeaudreault/following{/other_user}","gists_url":"https://api.github.com/users/bbeaudreault/gists{/gist_id}","starred_url":"https://api.github.com/users/bbeaudreault/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbeaudreault/subscriptions","organizations_url":"https://api.github.com/users/bbeaudreault/orgs","repos_url":"https://api.github.com/users/bbeaudreault/repos","events_url":"https://api.github.com/users/bbeaudreault/events{/privacy}","received_events_url":"https://api.github.com/users/bbeaudreault/received_events","type":"User","site_admin":false},"labels":[{"id":318803109,"url":"https://api.github.com/repos/youtube/vitess/labels/cla:%20yes","name":"cla: yes","color":"009800","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2017-08-13T05:19:22Z","updated_at":"2017-08-18T20:30:12Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/youtube/vitess/pulls/3056","html_url":"https://github.com/youtube/vitess/pull/3056","diff_url":"https://github.com/youtube/vitess/pull/3056.diff","patch_url":"https://github.com/youtube/vitess/pull/3056.patch"},"body":"Improvements from testing DataGrip, a popular SQL client from JetBrains/Intellij, against the mysql protocol plugin. It uses mysql-connector-j but also sends these commands at startup and as part of queries.\r\n\r\nAllows more than just nil for character_set_results.\r\nAllows net_write_timeout and `set names`/`set charset`/`set character set` as passthrough/no-op.\r\nWarns on ignored SET commands, and increments Warnings counter.\r\n\r\nIncludes a new feature: Allow `SET sql_select_limit = [N | DEFAULT]` where N is an int64. This utilizes the existing `#maxLimit` code to set an implicit limit to all select queries if the requested limit is less than the max row counts."},"comment":{"url":"https://api.github.com/repos/youtube/vitess/issues/comments/323453659","html_url":"https://github.com/youtube/vitess/pull/3056#issuecomment-323453659","issue_url":"https://api.github.com/repos/youtube/vitess/issues/3056","id":323453659,"user":{"login":"sougou","id":589370,"avatar_url":"https://avatars1.githubusercontent.com/u/589370?v=4","gravatar_id":"","url":"https://api.github.com/users/sougou","html_url":"https://github.com/sougou","followers_url":"https://api.github.com/users/sougou/followers","following_url":"https://api.github.com/users/sougou/following{/other_user}","gists_url":"https://api.github.com/users/sougou/gists{/gist_id}","starred_url":"https://api.github.com/users/sougou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sougou/subscriptions","organizations_url":"https://api.github.com/users/sougou/orgs","repos_url":"https://api.github.com/users/sougou/repos","events_url":"https://api.github.com/users/sougou/events{/privacy}","received_events_url":"https://api.github.com/users/sougou/received_events","type":"User","site_admin":false},"created_at":"2017-08-18T20:30:12Z","updated_at":"2017-08-18T20:30:12Z","body":"Ok. I've found the problem. VTCombo is crashing because on `NewCounters(\"Warning\"...` because vttablet also creates that variable.\r\nI was able to reproduce it with docker, but I don't know why it passes as a non-docker test. It should have crashed...\r\n\r\nIn any case, this is a real issue to be addressed. This may sound ugly, but we may need to rename that to `VTGateWarnings`."}}
{"actor":{"display_login":"sougou"}}