{"action":"created","issue":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/19363","repository_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped","labels_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/19363/labels{/name}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/19363/comments","events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/19363/events","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/19363","id":253111838,"number":19363,"title":"[react] [react-dom] Add support for rendering an array of elements","user":{"login":"cynecx","id":5961244,"avatar_url":"https://avatars0.githubusercontent.com/u/5961244?v=4","gravatar_id":"","url":"https://api.github.com/users/cynecx","html_url":"https://github.com/cynecx","followers_url":"https://api.github.com/users/cynecx/followers","following_url":"https://api.github.com/users/cynecx/following{/other_user}","gists_url":"https://api.github.com/users/cynecx/gists{/gist_id}","starred_url":"https://api.github.com/users/cynecx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cynecx/subscriptions","organizations_url":"https://api.github.com/users/cynecx/orgs","repos_url":"https://api.github.com/users/cynecx/repos","events_url":"https://api.github.com/users/cynecx/events{/privacy}","received_events_url":"https://api.github.com/users/cynecx/received_events","type":"User","site_admin":false},"labels":[{"id":684321576,"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels/Popular%20package","name":"Popular package","color":"fbca04","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":33,"created_at":"2017-08-26T17:47:26Z","updated_at":"2017-10-09T08:09:28Z","closed_at":"2017-10-06T18:08:30Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/19363","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/19363","diff_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/19363.diff","patch_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/19363.patch"},"body":"- [X] Use a meaningful title for the pull request. Include the name of the package modified.\r\n- [X] Test the change in your own code. (Compile and run.)\r\n- [X] Follow the advice from the [readme](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#make-a-pull-request).\r\n- [X] Avoid [common mistakes](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#common-mistakes).\r\n- [X] Run `npm run lint package-name` (or `tsc` if no `tslint.json` is present).\r\n- [X] Provide a URL to documentation or source code which provides context for the suggested changes:\r\n    -  Callbacks don't have any parameters (See commitCallbacks): https://github.com/facebook/react/blob/master/src/renderers/shared/fiber/ReactFiberUpdateQueue.js\r\n- [X] Increase the version number in the header if appropriate.\r\n- [X] If you are making substantial changes, consider adding a `tslint.json` containing `{ \"extends\": \"dtslint/dt.json\" }`.\r\n\r\nChanges:\r\n\r\n- Added more overloads to `ReactDOM::render` to support rendering an array of elements\r\n    - Since typescript doesn't support variadic types, the array overloads use `any` instead of a deduced type\r\n- The callback function signature has been changed because react v16 doesn't actually pass any parameters anymore\r\n- Bumped the supported react-dom to v16\r\n\r\nI am not quite sure if these changes are correct, so please be gentle on reviewing these changes ;)"},"comment":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/comments/335089941","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/19363#issuecomment-335089941","issue_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/19363","id":335089941,"user":{"login":"tkrotoff","id":643434,"avatar_url":"https://avatars2.githubusercontent.com/u/643434?v=4","gravatar_id":"","url":"https://api.github.com/users/tkrotoff","html_url":"https://github.com/tkrotoff","followers_url":"https://api.github.com/users/tkrotoff/followers","following_url":"https://api.github.com/users/tkrotoff/following{/other_user}","gists_url":"https://api.github.com/users/tkrotoff/gists{/gist_id}","starred_url":"https://api.github.com/users/tkrotoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkrotoff/subscriptions","organizations_url":"https://api.github.com/users/tkrotoff/orgs","repos_url":"https://api.github.com/users/tkrotoff/repos","events_url":"https://api.github.com/users/tkrotoff/events{/privacy}","received_events_url":"https://api.github.com/users/tkrotoff/received_events","type":"User","site_admin":false},"created_at":"2017-10-09T08:09:28Z","updated_at":"2017-10-09T08:09:28Z","author_association":"CONTRIBUTOR","body":"@MartynasZilinskas You're right, see https://codepen.io/tkrotoff/pen/yzKKdB\r\n\r\nStill there is a problem:\r\n```TypeScript\r\n  render() {\r\n    const { children } = this.props;\r\n    return children !== undefined ? children : null;\r\n  }\r\n```\r\n\r\n```\r\nTypes of property 'render' are incompatible.\r\n  Type '() => string | number | boolean | {} | ReactElement<any> | (string | number | boolean | any[] | R...' is not assignable to type '() => string | number | false | Element | Element[] | null'.\r\n    Type 'string | number | boolean | {} | ReactElement<any> | (string | number | boolean | any[] | ReactEl...' is not assignable to type 'string | number | false | Element | Element[] | null'.\r\n      Type 'true' is not assignable to type 'string | number | false | Element | Element[] | null'.\r\n```\r\n"}}
{"actor":{"display_login":"tkrotoff"}}