{"action":"created","issue":{"url":"https://api.github.com/repos/hashicorp/vault/issues/3511","repository_url":"https://api.github.com/repos/hashicorp/vault","labels_url":"https://api.github.com/repos/hashicorp/vault/issues/3511/labels{/name}","comments_url":"https://api.github.com/repos/hashicorp/vault/issues/3511/comments","events_url":"https://api.github.com/repos/hashicorp/vault/issues/3511/events","html_url":"https://github.com/hashicorp/vault/pull/3511","id":270088377,"number":3511,"title":"vault: recover from standby losing etcd lease (#3031)","user":{"login":"bhiggins","id":1166061,"avatar_url":"https://avatars1.githubusercontent.com/u/1166061?v=4","gravatar_id":"","url":"https://api.github.com/users/bhiggins","html_url":"https://github.com/bhiggins","followers_url":"https://api.github.com/users/bhiggins/followers","following_url":"https://api.github.com/users/bhiggins/following{/other_user}","gists_url":"https://api.github.com/users/bhiggins/gists{/gist_id}","starred_url":"https://api.github.com/users/bhiggins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bhiggins/subscriptions","organizations_url":"https://api.github.com/users/bhiggins/orgs","repos_url":"https://api.github.com/users/bhiggins/repos","events_url":"https://api.github.com/users/bhiggins/events{/privacy}","received_events_url":"https://api.github.com/users/bhiggins/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/hashicorp/vault/milestones/25","html_url":"https://github.com/hashicorp/vault/milestone/25","labels_url":"https://api.github.com/repos/hashicorp/vault/milestones/25/labels","id":2790524,"number":25,"title":"0.8.4","description":"","creator":{"login":"jefferai","id":28627,"avatar_url":"https://avatars0.githubusercontent.com/u/28627?v=4","gravatar_id":"","url":"https://api.github.com/users/jefferai","html_url":"https://github.com/jefferai","followers_url":"https://api.github.com/users/jefferai/followers","following_url":"https://api.github.com/users/jefferai/following{/other_user}","gists_url":"https://api.github.com/users/jefferai/gists{/gist_id}","starred_url":"https://api.github.com/users/jefferai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jefferai/subscriptions","organizations_url":"https://api.github.com/users/jefferai/orgs","repos_url":"https://api.github.com/users/jefferai/repos","events_url":"https://api.github.com/users/jefferai/events{/privacy}","received_events_url":"https://api.github.com/users/jefferai/received_events","type":"User","site_admin":false},"open_issues":32,"closed_issues":30,"state":"open","created_at":"2017-09-25T18:40:50Z","updated_at":"2017-10-31T20:58:41Z","due_on":null,"closed_at":null},"comments":3,"created_at":"2017-10-31T19:22:14Z","updated_at":"2017-10-31T21:46:55Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/hashicorp/vault/pulls/3511","html_url":"https://github.com/hashicorp/vault/pull/3511","diff_url":"https://github.com/hashicorp/vault/pull/3511.diff","patch_url":"https://github.com/hashicorp/vault/pull/3511.patch"},"body":"This change makes these errors transient instead of permanent:\r\n\r\n[ERROR] core: failed to acquire lock: error=etcdserver: requested lease not found\r\n\r\nAfter this change, there can still be one of these errors when a\r\nstandby vault that lost its lease tries to become leader, but on the\r\nnext lock acquisition attempt a new session will be created. With this\r\nnew session, the standby will be able to become the leader."},"comment":{"url":"https://api.github.com/repos/hashicorp/vault/issues/comments/340917452","html_url":"https://github.com/hashicorp/vault/pull/3511#issuecomment-340917452","issue_url":"https://api.github.com/repos/hashicorp/vault/issues/3511","id":340917452,"user":{"login":"bhiggins","id":1166061,"avatar_url":"https://avatars1.githubusercontent.com/u/1166061?v=4","gravatar_id":"","url":"https://api.github.com/users/bhiggins","html_url":"https://github.com/bhiggins","followers_url":"https://api.github.com/users/bhiggins/followers","following_url":"https://api.github.com/users/bhiggins/following{/other_user}","gists_url":"https://api.github.com/users/bhiggins/gists{/gist_id}","starred_url":"https://api.github.com/users/bhiggins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bhiggins/subscriptions","organizations_url":"https://api.github.com/users/bhiggins/orgs","repos_url":"https://api.github.com/users/bhiggins/repos","events_url":"https://api.github.com/users/bhiggins/events{/privacy}","received_events_url":"https://api.github.com/users/bhiggins/received_events","type":"User","site_admin":false},"created_at":"2017-10-31T21:46:55Z","updated_at":"2017-10-31T21:46:55Z","author_association":"NONE","body":"Simplified code as requested.\r\n\r\nYes, I tested this patch against 0.7.3 by having three vaults running in HA config. I manually deleted the standby's leases out of etcd, and then killed the leader. After that, as described in the commit message, the \"lease not found\" error occurs once but then on the next lock attempt a new session is created and the standby becomes the leader.\r\n"}}
{"actor":{"display_login":"bhiggins"}}