{"action":"created","comment":{"url":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments/114056352","pull_request_review_id":35499342,"id":114056352,"diff_hunk":"@@ -602,66 +601,66 @@ def test_constructor_maskedarray_nonfloat(self):\n         # 2-D input\n         frame = DataFrame(mat, columns=['A', 'B', 'C'], index=[1, 2])\n \n-        self.assertEqual(len(frame.index), 2)\n-        self.assertEqual(len(frame.columns), 3)\n+        assert len(frame.index) == 2\n+        assert len(frame.columns) == 3\n         assert np.all(~np.asarray(frame == frame))\n \n         # cast type\n         frame = DataFrame(mat, columns=['A', 'B', 'C'],\n                           index=[1, 2], dtype=np.float64)\n-        self.assertEqual(frame.values.dtype, np.float64)\n+        assert frame.values.dtype == np.float64\n \n         # Check non-masked values\n         mat2 = ma.copy(mat)\n         mat2[0, 0] = 1\n         mat2[1, 2] = 2\n         frame = DataFrame(mat2, columns=['A', 'B', 'C'], index=[1, 2])\n-        self.assertEqual(1, frame['A'][1])\n-        self.assertEqual(2, frame['C'][2])\n+        assert 1 == frame['A'][1]\n+        assert 2 == frame['C'][2]\n \n         # masked np.datetime64 stays (use lib.NaT as null)\n         mat = ma.masked_all((2, 3), dtype='M8[ns]')\n         # 2-D input\n         frame = DataFrame(mat, columns=['A', 'B', 'C'], index=[1, 2])\n \n-        self.assertEqual(len(frame.index), 2)\n-        self.assertEqual(len(frame.columns), 3)\n+        assert len(frame.index) == 2\n+        assert len(frame.columns) == 3\n         assert isnull(frame).values.all()\n \n         # cast type\n         frame = DataFrame(mat, columns=['A', 'B', 'C'],\n                           index=[1, 2], dtype=np.int64)\n-        self.assertEqual(frame.values.dtype, np.int64)\n+        assert frame.values.dtype == np.int64\n \n         # Check non-masked values\n         mat2 = ma.copy(mat)\n         mat2[0, 0] = 1\n         mat2[1, 2] = 2\n         frame = DataFrame(mat2, columns=['A', 'B', 'C'], index=[1, 2])\n-        self.assertEqual(1, frame['A'].view('i8')[1])\n-        self.assertEqual(2, frame['C'].view('i8')[2])\n+        assert 1 == frame['A'].view('i8')[1]\n+        assert 2 == frame['C'].view('i8')[2]\n \n         # masked bool promoted to object\n         mat = ma.masked_all((2, 3), dtype=bool)\n         # 2-D input\n         frame = DataFrame(mat, columns=['A', 'B', 'C'], index=[1, 2])\n \n-        self.assertEqual(len(frame.index), 2)\n-        self.assertEqual(len(frame.columns), 3)\n+        assert len(frame.index) == 2\n+        assert len(frame.columns) == 3\n         assert np.all(~np.asarray(frame == frame))\n \n         # cast type\n         frame = DataFrame(mat, columns=['A', 'B', 'C'],\n                           index=[1, 2], dtype=object)\n-        self.assertEqual(frame.values.dtype, object)\n+        assert frame.values.dtype == object\n \n         # Check non-masked values\n         mat2 = ma.copy(mat)\n         mat2[0, 0] = True\n         mat2[1, 2] = False\n         frame = DataFrame(mat2, columns=['A', 'B', 'C'], index=[1, 2])\n-        self.assertEqual(True, frame['A'][1])\n-        self.assertEqual(False, frame['C'][2])\n+        assert frame['A'][1]","path":"pandas/tests/frame/test_constructors.py","position":null,"original_position":295,"commit_id":"bfc963ce4955f0d14557ee1302f277384932b476","original_commit_id":"7b5fd166dc8fa102dddc103d823c2d9f5cf75b6c","user":{"login":"gfyoung","id":9273653,"avatar_url":"https://avatars3.githubusercontent.com/u/9273653?v=3","gravatar_id":"","url":"https://api.github.com/users/gfyoung","html_url":"https://github.com/gfyoung","followers_url":"https://api.github.com/users/gfyoung/followers","following_url":"https://api.github.com/users/gfyoung/following{/other_user}","gists_url":"https://api.github.com/users/gfyoung/gists{/gist_id}","starred_url":"https://api.github.com/users/gfyoung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gfyoung/subscriptions","organizations_url":"https://api.github.com/users/gfyoung/orgs","repos_url":"https://api.github.com/users/gfyoung/repos","events_url":"https://api.github.com/users/gfyoung/events{/privacy}","received_events_url":"https://api.github.com/users/gfyoung/received_events","type":"User","site_admin":false},"body":"Done.","created_at":"2017-04-29T16:09:31Z","updated_at":"2017-04-29T16:09:31Z","html_url":"https://github.com/pandas-dev/pandas/pull/16169#discussion_r114056352","pull_request_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/16169","_links":{"self":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments/114056352"},"html":{"href":"https://github.com/pandas-dev/pandas/pull/16169#discussion_r114056352"},"pull_request":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/16169"}}},"pull_request":{"url":"https://api.github.com/repos/pandas-dev/pandas/pulls/16169","id":118268329,"html_url":"https://github.com/pandas-dev/pandas/pull/16169","diff_url":"https://github.com/pandas-dev/pandas/pull/16169.diff","patch_url":"https://github.com/pandas-dev/pandas/pull/16169.patch","issue_url":"https://api.github.com/repos/pandas-dev/pandas/issues/16169","number":16169,"state":"open","locked":false,"title":"MAINT: Remove self.assertEqual from testing","user":{"login":"gfyoung","id":9273653,"avatar_url":"https://avatars3.githubusercontent.com/u/9273653?v=3","gravatar_id":"","url":"https://api.github.com/users/gfyoung","html_url":"https://github.com/gfyoung","followers_url":"https://api.github.com/users/gfyoung/followers","following_url":"https://api.github.com/users/gfyoung/following{/other_user}","gists_url":"https://api.github.com/users/gfyoung/gists{/gist_id}","starred_url":"https://api.github.com/users/gfyoung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gfyoung/subscriptions","organizations_url":"https://api.github.com/users/gfyoung/orgs","repos_url":"https://api.github.com/users/gfyoung/repos","events_url":"https://api.github.com/users/gfyoung/events{/privacy}","received_events_url":"https://api.github.com/users/gfyoung/received_events","type":"User","site_admin":false},"body":"Title is self-explanatory.  Massive, massive PR.\r\n\r\nPartially addresses #15990.","created_at":"2017-04-29T09:07:17Z","updated_at":"2017-04-29T16:09:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a44dca07d94b143904df85c332e76b3e46ef0851","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/16169/commits","review_comments_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/16169/comments","review_comment_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pandas-dev/pandas/issues/16169/comments","statuses_url":"https://api.github.com/repos/pandas-dev/pandas/statuses/bfc963ce4955f0d14557ee1302f277384932b476","head":{"label":"gfyoung:assert-equal-remove","ref":"assert-equal-remove","sha":"bfc963ce4955f0d14557ee1302f277384932b476","user":{"login":"gfyoung","id":9273653,"avatar_url":"https://avatars3.githubusercontent.com/u/9273653?v=3","gravatar_id":"","url":"https://api.github.com/users/gfyoung","html_url":"https://github.com/gfyoung","followers_url":"https://api.github.com/users/gfyoung/followers","following_url":"https://api.github.com/users/gfyoung/following{/other_user}","gists_url":"https://api.github.com/users/gfyoung/gists{/gist_id}","starred_url":"https://api.github.com/users/gfyoung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gfyoung/subscriptions","organizations_url":"https://api.github.com/users/gfyoung/orgs","repos_url":"https://api.github.com/users/gfyoung/repos","events_url":"https://api.github.com/users/gfyoung/events{/privacy}","received_events_url":"https://api.github.com/users/gfyoung/received_events","type":"User","site_admin":false},"repo":{"id":51449909,"name":"pandas","full_name":"gfyoung/pandas","owner":{"login":"gfyoung","id":9273653,"avatar_url":"https://avatars3.githubusercontent.com/u/9273653?v=3","gravatar_id":"","url":"https://api.github.com/users/gfyoung","html_url":"https://github.com/gfyoung","followers_url":"https://api.github.com/users/gfyoung/followers","following_url":"https://api.github.com/users/gfyoung/following{/other_user}","gists_url":"https://api.github.com/users/gfyoung/gists{/gist_id}","starred_url":"https://api.github.com/users/gfyoung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gfyoung/subscriptions","organizations_url":"https://api.github.com/users/gfyoung/orgs","repos_url":"https://api.github.com/users/gfyoung/repos","events_url":"https://api.github.com/users/gfyoung/events{/privacy}","received_events_url":"https://api.github.com/users/gfyoung/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gfyoung/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":true,"url":"https://api.github.com/repos/gfyoung/pandas","forks_url":"https://api.github.com/repos/gfyoung/pandas/forks","keys_url":"https://api.github.com/repos/gfyoung/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gfyoung/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gfyoung/pandas/teams","hooks_url":"https://api.github.com/repos/gfyoung/pandas/hooks","issue_events_url":"https://api.github.com/repos/gfyoung/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/gfyoung/pandas/events","assignees_url":"https://api.github.com/repos/gfyoung/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/gfyoung/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/gfyoung/pandas/tags","blobs_url":"https://api.github.com/repos/gfyoung/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gfyoung/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gfyoung/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/gfyoung/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gfyoung/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/gfyoung/pandas/languages","stargazers_url":"https://api.github.com/repos/gfyoung/pandas/stargazers","contributors_url":"https://api.github.com/repos/gfyoung/pandas/contributors","subscribers_url":"https://api.github.com/repos/gfyoung/pandas/subscribers","subscription_url":"https://api.github.com/repos/gfyoung/pandas/subscription","commits_url":"https://api.github.com/repos/gfyoung/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/gfyoung/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/gfyoung/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/gfyoung/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/gfyoung/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/gfyoung/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gfyoung/pandas/merges","archive_url":"https://api.github.com/repos/gfyoung/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gfyoung/pandas/downloads","issues_url":"https://api.github.com/repos/gfyoung/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/gfyoung/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/gfyoung/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/gfyoung/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gfyoung/pandas/labels{/name}","releases_url":"https://api.github.com/repos/gfyoung/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/gfyoung/pandas/deployments","created_at":"2016-02-10T15:31:30Z","updated_at":"2016-02-10T15:31:35Z","pushed_at":"2017-04-29T16:09:17Z","git_url":"git://github.com/gfyoung/pandas.git","ssh_url":"git@github.com:gfyoung/pandas.git","clone_url":"https://github.com/gfyoung/pandas.git","svn_url":"https://github.com/gfyoung/pandas","homepage":"http://pandas.pydata.org","size":96026,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pandas-dev:master","ref":"master","sha":"a7a0574a0bcb8a4c65ed7f5006972e24f90ae3df","user":{"login":"pandas-dev","id":21206976,"avatar_url":"https://avatars1.githubusercontent.com/u/21206976?v=3","gravatar_id":"","url":"https://api.github.com/users/pandas-dev","html_url":"https://github.com/pandas-dev","followers_url":"https://api.github.com/users/pandas-dev/followers","following_url":"https://api.github.com/users/pandas-dev/following{/other_user}","gists_url":"https://api.github.com/users/pandas-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pandas-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandas-dev/subscriptions","organizations_url":"https://api.github.com/users/pandas-dev/orgs","repos_url":"https://api.github.com/users/pandas-dev/repos","events_url":"https://api.github.com/users/pandas-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pandas-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":858127,"name":"pandas","full_name":"pandas-dev/pandas","owner":{"login":"pandas-dev","id":21206976,"avatar_url":"https://avatars1.githubusercontent.com/u/21206976?v=3","gravatar_id":"","url":"https://api.github.com/users/pandas-dev","html_url":"https://github.com/pandas-dev","followers_url":"https://api.github.com/users/pandas-dev/followers","following_url":"https://api.github.com/users/pandas-dev/following{/other_user}","gists_url":"https://api.github.com/users/pandas-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pandas-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandas-dev/subscriptions","organizations_url":"https://api.github.com/users/pandas-dev/orgs","repos_url":"https://api.github.com/users/pandas-dev/repos","events_url":"https://api.github.com/users/pandas-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pandas-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pandas-dev/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":false,"url":"https://api.github.com/repos/pandas-dev/pandas","forks_url":"https://api.github.com/repos/pandas-dev/pandas/forks","keys_url":"https://api.github.com/repos/pandas-dev/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pandas-dev/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pandas-dev/pandas/teams","hooks_url":"https://api.github.com/repos/pandas-dev/pandas/hooks","issue_events_url":"https://api.github.com/repos/pandas-dev/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/pandas-dev/pandas/events","assignees_url":"https://api.github.com/repos/pandas-dev/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/pandas-dev/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/pandas-dev/pandas/tags","blobs_url":"https://api.github.com/repos/pandas-dev/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pandas-dev/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pandas-dev/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/pandas-dev/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pandas-dev/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/pandas-dev/pandas/languages","stargazers_url":"https://api.github.com/repos/pandas-dev/pandas/stargazers","contributors_url":"https://api.github.com/repos/pandas-dev/pandas/contributors","subscribers_url":"https://api.github.com/repos/pandas-dev/pandas/subscribers","subscription_url":"https://api.github.com/repos/pandas-dev/pandas/subscription","commits_url":"https://api.github.com/repos/pandas-dev/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/pandas-dev/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/pandas-dev/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/pandas-dev/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/pandas-dev/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/pandas-dev/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pandas-dev/pandas/merges","archive_url":"https://api.github.com/repos/pandas-dev/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pandas-dev/pandas/downloads","issues_url":"https://api.github.com/repos/pandas-dev/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/pandas-dev/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/pandas-dev/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/pandas-dev/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pandas-dev/pandas/labels{/name}","releases_url":"https://api.github.com/repos/pandas-dev/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/pandas-dev/pandas/deployments","created_at":"2010-08-24T01:37:33Z","updated_at":"2017-04-29T14:45:39Z","pushed_at":"2017-04-29T16:09:20Z","git_url":"git://github.com/pandas-dev/pandas.git","ssh_url":"git@github.com:pandas-dev/pandas.git","clone_url":"https://github.com/pandas-dev/pandas.git","svn_url":"https://github.com/pandas-dev/pandas","homepage":"http://pandas.pydata.org","size":96777,"stargazers_count":9412,"watchers_count":9412,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3719,"mirror_url":null,"open_issues_count":1921,"forks":3719,"open_issues":1921,"watchers":9412,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/16169"},"html":{"href":"https://github.com/pandas-dev/pandas/pull/16169"},"issue":{"href":"https://api.github.com/repos/pandas-dev/pandas/issues/16169"},"comments":{"href":"https://api.github.com/repos/pandas-dev/pandas/issues/16169/comments"},"review_comments":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/16169/comments"},"review_comment":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/16169/commits"},"statuses":{"href":"https://api.github.com/repos/pandas-dev/pandas/statuses/bfc963ce4955f0d14557ee1302f277384932b476"}}}}
{"actor":{"display_login":"gfyoung"}}