{"action":"created","comment":{"url":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/pulls/comments/114743213","pull_request_review_id":36233736,"id":114743213,"diff_hunk":"@@ -87,6 +87,16 @@ def get_species_from_sample(sample_name):\n             return get_species_name(species_string)\n \n \n+def get_genome_version(dataset_name, species):\n+    genome_version = get_sample(dataset_name).udf.get('Genome Version')\n+    if genome_version is None:\n+        genome_version = cfg.query('species', species, 'default')\n+    reference = cfg.query('genomes', genome_version, 'fasta')","path":"egcg_core/clarity.py","position":8,"original_position":8,"commit_id":"093a811daf7167b7c45c00201efcbd34e5c83357","original_commit_id":"093a811daf7167b7c45c00201efcbd34e5c83357","user":{"login":"tcezard","id":650891,"avatar_url":"https://avatars3.githubusercontent.com/u/650891?v=3","gravatar_id":"","url":"https://api.github.com/users/tcezard","html_url":"https://github.com/tcezard","followers_url":"https://api.github.com/users/tcezard/followers","following_url":"https://api.github.com/users/tcezard/following{/other_user}","gists_url":"https://api.github.com/users/tcezard/gists{/gist_id}","starred_url":"https://api.github.com/users/tcezard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tcezard/subscriptions","organizations_url":"https://api.github.com/users/tcezard/orgs","repos_url":"https://api.github.com/users/tcezard/repos","events_url":"https://api.github.com/users/tcezard/events{/privacy}","received_events_url":"https://api.github.com/users/tcezard/received_events","type":"User","site_admin":false},"body":"I would return genome_version here.\r\nNo need to return the fasta file as it is outside the scope of the function","created_at":"2017-05-04T10:34:38Z","updated_at":"2017-05-04T10:38:26Z","html_url":"https://github.com/EdinburghGenomics/EGCG-Core/pull/48#discussion_r114743213","pull_request_url":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/pulls/48","_links":{"self":{"href":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/pulls/comments/114743213"},"html":{"href":"https://github.com/EdinburghGenomics/EGCG-Core/pull/48#discussion_r114743213"},"pull_request":{"href":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/pulls/48"}}},"pull_request":{"url":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/pulls/48","id":118941246,"html_url":"https://github.com/EdinburghGenomics/EGCG-Core/pull/48","diff_url":"https://github.com/EdinburghGenomics/EGCG-Core/pull/48.diff","patch_url":"https://github.com/EdinburghGenomics/EGCG-Core/pull/48.patch","issue_url":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/issues/48","number":48,"state":"open","locked":false,"title":"Moved get_genome function from AnalysisDriver to EGCG Core","user":{"login":"katieemelianova","id":8308682,"avatar_url":"https://avatars0.githubusercontent.com/u/8308682?v=3","gravatar_id":"","url":"https://api.github.com/users/katieemelianova","html_url":"https://github.com/katieemelianova","followers_url":"https://api.github.com/users/katieemelianova/followers","following_url":"https://api.github.com/users/katieemelianova/following{/other_user}","gists_url":"https://api.github.com/users/katieemelianova/gists{/gist_id}","starred_url":"https://api.github.com/users/katieemelianova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/katieemelianova/subscriptions","organizations_url":"https://api.github.com/users/katieemelianova/orgs","repos_url":"https://api.github.com/users/katieemelianova/repos","events_url":"https://api.github.com/users/katieemelianova/events{/privacy}","received_events_url":"https://api.github.com/users/katieemelianova/received_events","type":"User","site_admin":false},"body":"Purpose of this PR is to make get_genome_version accessible to EGCG-Project-Report as well as AnalysisDriver","created_at":"2017-05-04T10:26:22Z","updated_at":"2017-05-04T10:38:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"589ee7a0fee4310ab8161c794485d33de094cbbc","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/pulls/48/commits","review_comments_url":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/pulls/48/comments","review_comment_url":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/issues/48/comments","statuses_url":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/statuses/093a811daf7167b7c45c00201efcbd34e5c83357","head":{"label":"EdinburghGenomics:move_genome_version","ref":"move_genome_version","sha":"093a811daf7167b7c45c00201efcbd34e5c83357","user":{"login":"EdinburghGenomics","id":12951724,"avatar_url":"https://avatars3.githubusercontent.com/u/12951724?v=3","gravatar_id":"","url":"https://api.github.com/users/EdinburghGenomics","html_url":"https://github.com/EdinburghGenomics","followers_url":"https://api.github.com/users/EdinburghGenomics/followers","following_url":"https://api.github.com/users/EdinburghGenomics/following{/other_user}","gists_url":"https://api.github.com/users/EdinburghGenomics/gists{/gist_id}","starred_url":"https://api.github.com/users/EdinburghGenomics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EdinburghGenomics/subscriptions","organizations_url":"https://api.github.com/users/EdinburghGenomics/orgs","repos_url":"https://api.github.com/users/EdinburghGenomics/repos","events_url":"https://api.github.com/users/EdinburghGenomics/events{/privacy}","received_events_url":"https://api.github.com/users/EdinburghGenomics/received_events","type":"Organization","site_admin":false},"repo":{"id":61221690,"name":"EGCG-Core","full_name":"EdinburghGenomics/EGCG-Core","owner":{"login":"EdinburghGenomics","id":12951724,"avatar_url":"https://avatars3.githubusercontent.com/u/12951724?v=3","gravatar_id":"","url":"https://api.github.com/users/EdinburghGenomics","html_url":"https://github.com/EdinburghGenomics","followers_url":"https://api.github.com/users/EdinburghGenomics/followers","following_url":"https://api.github.com/users/EdinburghGenomics/following{/other_user}","gists_url":"https://api.github.com/users/EdinburghGenomics/gists{/gist_id}","starred_url":"https://api.github.com/users/EdinburghGenomics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EdinburghGenomics/subscriptions","organizations_url":"https://api.github.com/users/EdinburghGenomics/orgs","repos_url":"https://api.github.com/users/EdinburghGenomics/repos","events_url":"https://api.github.com/users/EdinburghGenomics/events{/privacy}","received_events_url":"https://api.github.com/users/EdinburghGenomics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/EdinburghGenomics/EGCG-Core","description":"Shared functionality across EGCG projects","fork":false,"url":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core","forks_url":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/forks","keys_url":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/teams","hooks_url":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/hooks","issue_events_url":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/issues/events{/number}","events_url":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/events","assignees_url":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/assignees{/user}","branches_url":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/branches{/branch}","tags_url":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/tags","blobs_url":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/git/refs{/sha}","trees_url":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/statuses/{sha}","languages_url":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/languages","stargazers_url":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/stargazers","contributors_url":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/contributors","subscribers_url":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/subscribers","subscription_url":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/subscription","commits_url":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/commits{/sha}","git_commits_url":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/git/commits{/sha}","comments_url":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/comments{/number}","issue_comment_url":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/issues/comments{/number}","contents_url":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/contents/{+path}","compare_url":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/merges","archive_url":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/downloads","issues_url":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/issues{/number}","pulls_url":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/pulls{/number}","milestones_url":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/milestones{/number}","notifications_url":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/labels{/name}","releases_url":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/releases{/id}","deployments_url":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/deployments","created_at":"2016-06-15T16:06:27Z","updated_at":"2016-06-15T16:09:33Z","pushed_at":"2017-05-04T10:26:22Z","git_url":"git://github.com/EdinburghGenomics/EGCG-Core.git","ssh_url":"git@github.com:EdinburghGenomics/EGCG-Core.git","clone_url":"https://github.com/EdinburghGenomics/EGCG-Core.git","svn_url":"https://github.com/EdinburghGenomics/EGCG-Core","homepage":null,"size":177,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"EdinburghGenomics:master","ref":"master","sha":"6c67afa93bf7908297331a439f43f28537f916a0","user":{"login":"EdinburghGenomics","id":12951724,"avatar_url":"https://avatars3.githubusercontent.com/u/12951724?v=3","gravatar_id":"","url":"https://api.github.com/users/EdinburghGenomics","html_url":"https://github.com/EdinburghGenomics","followers_url":"https://api.github.com/users/EdinburghGenomics/followers","following_url":"https://api.github.com/users/EdinburghGenomics/following{/other_user}","gists_url":"https://api.github.com/users/EdinburghGenomics/gists{/gist_id}","starred_url":"https://api.github.com/users/EdinburghGenomics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EdinburghGenomics/subscriptions","organizations_url":"https://api.github.com/users/EdinburghGenomics/orgs","repos_url":"https://api.github.com/users/EdinburghGenomics/repos","events_url":"https://api.github.com/users/EdinburghGenomics/events{/privacy}","received_events_url":"https://api.github.com/users/EdinburghGenomics/received_events","type":"Organization","site_admin":false},"repo":{"id":61221690,"name":"EGCG-Core","full_name":"EdinburghGenomics/EGCG-Core","owner":{"login":"EdinburghGenomics","id":12951724,"avatar_url":"https://avatars3.githubusercontent.com/u/12951724?v=3","gravatar_id":"","url":"https://api.github.com/users/EdinburghGenomics","html_url":"https://github.com/EdinburghGenomics","followers_url":"https://api.github.com/users/EdinburghGenomics/followers","following_url":"https://api.github.com/users/EdinburghGenomics/following{/other_user}","gists_url":"https://api.github.com/users/EdinburghGenomics/gists{/gist_id}","starred_url":"https://api.github.com/users/EdinburghGenomics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EdinburghGenomics/subscriptions","organizations_url":"https://api.github.com/users/EdinburghGenomics/orgs","repos_url":"https://api.github.com/users/EdinburghGenomics/repos","events_url":"https://api.github.com/users/EdinburghGenomics/events{/privacy}","received_events_url":"https://api.github.com/users/EdinburghGenomics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/EdinburghGenomics/EGCG-Core","description":"Shared functionality across EGCG projects","fork":false,"url":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core","forks_url":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/forks","keys_url":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/teams","hooks_url":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/hooks","issue_events_url":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/issues/events{/number}","events_url":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/events","assignees_url":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/assignees{/user}","branches_url":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/branches{/branch}","tags_url":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/tags","blobs_url":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/git/refs{/sha}","trees_url":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/statuses/{sha}","languages_url":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/languages","stargazers_url":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/stargazers","contributors_url":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/contributors","subscribers_url":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/subscribers","subscription_url":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/subscription","commits_url":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/commits{/sha}","git_commits_url":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/git/commits{/sha}","comments_url":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/comments{/number}","issue_comment_url":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/issues/comments{/number}","contents_url":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/contents/{+path}","compare_url":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/merges","archive_url":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/downloads","issues_url":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/issues{/number}","pulls_url":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/pulls{/number}","milestones_url":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/milestones{/number}","notifications_url":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/labels{/name}","releases_url":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/releases{/id}","deployments_url":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/deployments","created_at":"2016-06-15T16:06:27Z","updated_at":"2016-06-15T16:09:33Z","pushed_at":"2017-05-04T10:26:22Z","git_url":"git://github.com/EdinburghGenomics/EGCG-Core.git","ssh_url":"git@github.com:EdinburghGenomics/EGCG-Core.git","clone_url":"https://github.com/EdinburghGenomics/EGCG-Core.git","svn_url":"https://github.com/EdinburghGenomics/EGCG-Core","homepage":null,"size":177,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/pulls/48"},"html":{"href":"https://github.com/EdinburghGenomics/EGCG-Core/pull/48"},"issue":{"href":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/issues/48"},"comments":{"href":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/issues/48/comments"},"review_comments":{"href":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/pulls/48/comments"},"review_comment":{"href":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/pulls/48/commits"},"statuses":{"href":"https://api.github.com/repos/EdinburghGenomics/EGCG-Core/statuses/093a811daf7167b7c45c00201efcbd34e5c83357"}}}}
{"actor":{"display_login":"tcezard"}}