{"action":"created","issue":{"url":"https://api.github.com/repos/linq2db/linq2db/issues/645","repository_url":"https://api.github.com/repos/linq2db/linq2db","labels_url":"https://api.github.com/repos/linq2db/linq2db/issues/645/labels{/name}","comments_url":"https://api.github.com/repos/linq2db/linq2db/issues/645/comments","events_url":"https://api.github.com/repos/linq2db/linq2db/issues/645/events","html_url":"https://github.com/linq2db/linq2db/pull/645","id":225189439,"number":645,"title":"Fix #256","user":{"login":"MaceWindu","id":1099238,"avatar_url":"https://avatars2.githubusercontent.com/u/1099238?v=3","gravatar_id":"","url":"https://api.github.com/users/MaceWindu","html_url":"https://github.com/MaceWindu","followers_url":"https://api.github.com/users/MaceWindu/followers","following_url":"https://api.github.com/users/MaceWindu/following{/other_user}","gists_url":"https://api.github.com/users/MaceWindu/gists{/gist_id}","starred_url":"https://api.github.com/users/MaceWindu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaceWindu/subscriptions","organizations_url":"https://api.github.com/users/MaceWindu/orgs","repos_url":"https://api.github.com/users/MaceWindu/repos","events_url":"https://api.github.com/users/MaceWindu/events{/privacy}","received_events_url":"https://api.github.com/users/MaceWindu/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2017-04-28T20:49:00Z","updated_at":"2017-05-02T14:07:15Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/linq2db/linq2db/pulls/645","html_url":"https://github.com/linq2db/linq2db/pull/645","diff_url":"https://github.com/linq2db/linq2db/pull/645.diff","patch_url":"https://github.com/linq2db/linq2db/pull/645.patch"},"body":"That was easier than I expected.\r\n\r\nPR summary:\r\n1. Tests for #256 \r\n2. One-liner fix for #256 \r\n3. Fixed test name generation for DataContext test case source to generate unique test names\r\n4. Fixed issue, discovered by tests, with duplicate parameters and WCF provider.\r\n\r\nSeveral tests fail for Oracle with \"ORA-00932: inconsistent datatypes: expected - got CLOB\" because linq2db generates comparison using \"=\" operation, which is not supported with LOB types. We should generate DBMS_LOB.COMPARE calls here, but this is unrelated issue.\r\n\r\nUntested providers: SAP/DB2/Informix/ASE/FB3/Oracle.Native/Azure\r\nOnly desktop framework tested\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/linq2db/linq2db/issues/comments/298645991","html_url":"https://github.com/linq2db/linq2db/pull/645#issuecomment-298645991","issue_url":"https://api.github.com/repos/linq2db/linq2db/issues/645","id":298645991,"user":{"login":"ili","id":787292,"avatar_url":"https://avatars1.githubusercontent.com/u/787292?v=3","gravatar_id":"","url":"https://api.github.com/users/ili","html_url":"https://github.com/ili","followers_url":"https://api.github.com/users/ili/followers","following_url":"https://api.github.com/users/ili/following{/other_user}","gists_url":"https://api.github.com/users/ili/gists{/gist_id}","starred_url":"https://api.github.com/users/ili/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ili/subscriptions","organizations_url":"https://api.github.com/users/ili/orgs","repos_url":"https://api.github.com/users/ili/repos","events_url":"https://api.github.com/users/ili/events{/privacy}","received_events_url":"https://api.github.com/users/ili/received_events","type":"User","site_admin":false},"created_at":"2017-05-02T14:07:15Z","updated_at":"2017-05-02T14:07:15Z","body":"We can make expression transformation, setting all constants to their default values. And store and compare this converted expression trees in query cache but this needs great attention not to make fatal cache hit, for example if we'll suppose to be the same `where a == 1` and `where a == 2` this would be... \r\n"}}
{"actor":{"display_login":"ili"}}