{"action":"created","comment":{"url":"https://api.github.com/repos/Juicy/juicy-html/pulls/comments/157996657","pull_request_review_id":84731252,"id":157996657,"diff_hunk":"@@ -218,8 +218,15 @@\n             if (model === null || !arrayOfElements) {\n                 return;\n             }\n-            for (var childNo = 0; childNo < arrayOfElements.length; childNo++) {\n-                arrayOfElements[childNo].model = model;\n+            for (let childNo = 0; childNo < arrayOfElements.length; childNo++) {\n+                const elem = arrayOfElements[childNo];\n+                elem.model = model;\n+\n+                //mirrored implementation of this fix: https://github.com/Polymer/polymer/pull/4537/files\n+                const firstElemChild = elem.firstElementChild;\n+                if (firstElemChild && firstElemChild.getAttribute(\"is\") === elem.localName) {","path":"juicy-html.html","position":12,"original_position":12,"commit_id":"bbd8217026606f2d00a2a6cd216a25ccb93c5b48","original_commit_id":"bbd8217026606f2d00a2a6cd216a25ccb93c5b48","user":{"login":"warpech","id":566463,"avatar_url":"https://avatars0.githubusercontent.com/u/566463?v=4","gravatar_id":"","url":"https://api.github.com/users/warpech","html_url":"https://github.com/warpech","followers_url":"https://api.github.com/users/warpech/followers","following_url":"https://api.github.com/users/warpech/following{/other_user}","gists_url":"https://api.github.com/users/warpech/gists{/gist_id}","starred_url":"https://api.github.com/users/warpech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/warpech/subscriptions","organizations_url":"https://api.github.com/users/warpech/orgs","repos_url":"https://api.github.com/users/warpech/repos","events_url":"https://api.github.com/users/warpech/events{/privacy}","received_events_url":"https://api.github.com/users/warpech/received_events","type":"User","site_admin":false},"body":"Can you paste a link to a line?","created_at":"2017-12-20T11:13:28Z","updated_at":"2017-12-20T11:13:29Z","html_url":"https://github.com/Juicy/juicy-html/pull/37#discussion_r157996657","pull_request_url":"https://api.github.com/repos/Juicy/juicy-html/pulls/37","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/Juicy/juicy-html/pulls/comments/157996657"},"html":{"href":"https://github.com/Juicy/juicy-html/pull/37#discussion_r157996657"},"pull_request":{"href":"https://api.github.com/repos/Juicy/juicy-html/pulls/37"}},"in_reply_to_id":157805361},"pull_request":{"url":"https://api.github.com/repos/Juicy/juicy-html/pulls/37","id":159203346,"html_url":"https://github.com/Juicy/juicy-html/pull/37","diff_url":"https://github.com/Juicy/juicy-html/pull/37.diff","patch_url":"https://github.com/Juicy/juicy-html/pull/37.patch","issue_url":"https://api.github.com/repos/Juicy/juicy-html/issues/37","number":37,"state":"closed","locked":false,"title":"Compatibility fix for hybrid views for Polymer 1 and 2","user":{"login":"warpech","id":566463,"avatar_url":"https://avatars0.githubusercontent.com/u/566463?v=4","gravatar_id":"","url":"https://api.github.com/users/warpech","html_url":"https://github.com/warpech","followers_url":"https://api.github.com/users/warpech/followers","following_url":"https://api.github.com/users/warpech/following{/other_user}","gists_url":"https://api.github.com/users/warpech/gists{/gist_id}","starred_url":"https://api.github.com/users/warpech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/warpech/subscriptions","organizations_url":"https://api.github.com/users/warpech/orgs","repos_url":"https://api.github.com/users/warpech/repos","events_url":"https://api.github.com/users/warpech/events{/privacy}","received_events_url":"https://api.github.com/users/warpech/received_events","type":"User","site_admin":false},"body":"Problem: `juicy-html` does not assign the model to `<template is=\"dom-bind\">` if it is wrapped in `<dom-bind>`. This makes it impossible to have hybrid views for Polymer 1 and 2\r\n\r\nSolution: apply the mirrored version of the Polymer's own solution for this problem: https://github.com/Polymer/polymer/pull/4537/files\r\n\r\nThis was discussed in https://starcounter.slack.com/archives/C5PEXSXQE/p1513614571000221","created_at":"2017-12-19T15:56:13Z","updated_at":"2017-12-20T11:13:29Z","closed_at":"2017-12-19T22:04:07Z","merged_at":"2017-12-19T22:04:07Z","merge_commit_sha":"b94d1afc0f381208a905d1ccf76627f50dac455b","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Juicy/juicy-html/pulls/37/commits","review_comments_url":"https://api.github.com/repos/Juicy/juicy-html/pulls/37/comments","review_comment_url":"https://api.github.com/repos/Juicy/juicy-html/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Juicy/juicy-html/issues/37/comments","statuses_url":"https://api.github.com/repos/Juicy/juicy-html/statuses/bbd8217026606f2d00a2a6cd216a25ccb93c5b48","head":{"label":"Juicy:fix-hybrid-polymer","ref":"fix-hybrid-polymer","sha":"bbd8217026606f2d00a2a6cd216a25ccb93c5b48","user":{"login":"Juicy","id":7557694,"avatar_url":"https://avatars0.githubusercontent.com/u/7557694?v=4","gravatar_id":"","url":"https://api.github.com/users/Juicy","html_url":"https://github.com/Juicy","followers_url":"https://api.github.com/users/Juicy/followers","following_url":"https://api.github.com/users/Juicy/following{/other_user}","gists_url":"https://api.github.com/users/Juicy/gists{/gist_id}","starred_url":"https://api.github.com/users/Juicy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Juicy/subscriptions","organizations_url":"https://api.github.com/users/Juicy/orgs","repos_url":"https://api.github.com/users/Juicy/repos","events_url":"https://api.github.com/users/Juicy/events{/privacy}","received_events_url":"https://api.github.com/users/Juicy/received_events","type":"Organization","site_admin":false},"repo":{"id":14489520,"name":"juicy-html","full_name":"Juicy/juicy-html","owner":{"login":"Juicy","id":7557694,"avatar_url":"https://avatars0.githubusercontent.com/u/7557694?v=4","gravatar_id":"","url":"https://api.github.com/users/Juicy","html_url":"https://github.com/Juicy","followers_url":"https://api.github.com/users/Juicy/followers","following_url":"https://api.github.com/users/Juicy/following{/other_user}","gists_url":"https://api.github.com/users/Juicy/gists{/gist_id}","starred_url":"https://api.github.com/users/Juicy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Juicy/subscriptions","organizations_url":"https://api.github.com/users/Juicy/orgs","repos_url":"https://api.github.com/users/Juicy/repos","events_url":"https://api.github.com/users/Juicy/events{/privacy}","received_events_url":"https://api.github.com/users/Juicy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Juicy/juicy-html","description":"A custom element that lets you load HTML partials into your Web page. Declarative way for client-side includes.","fork":false,"url":"https://api.github.com/repos/Juicy/juicy-html","forks_url":"https://api.github.com/repos/Juicy/juicy-html/forks","keys_url":"https://api.github.com/repos/Juicy/juicy-html/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Juicy/juicy-html/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Juicy/juicy-html/teams","hooks_url":"https://api.github.com/repos/Juicy/juicy-html/hooks","issue_events_url":"https://api.github.com/repos/Juicy/juicy-html/issues/events{/number}","events_url":"https://api.github.com/repos/Juicy/juicy-html/events","assignees_url":"https://api.github.com/repos/Juicy/juicy-html/assignees{/user}","branches_url":"https://api.github.com/repos/Juicy/juicy-html/branches{/branch}","tags_url":"https://api.github.com/repos/Juicy/juicy-html/tags","blobs_url":"https://api.github.com/repos/Juicy/juicy-html/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Juicy/juicy-html/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Juicy/juicy-html/git/refs{/sha}","trees_url":"https://api.github.com/repos/Juicy/juicy-html/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Juicy/juicy-html/statuses/{sha}","languages_url":"https://api.github.com/repos/Juicy/juicy-html/languages","stargazers_url":"https://api.github.com/repos/Juicy/juicy-html/stargazers","contributors_url":"https://api.github.com/repos/Juicy/juicy-html/contributors","subscribers_url":"https://api.github.com/repos/Juicy/juicy-html/subscribers","subscription_url":"https://api.github.com/repos/Juicy/juicy-html/subscription","commits_url":"https://api.github.com/repos/Juicy/juicy-html/commits{/sha}","git_commits_url":"https://api.github.com/repos/Juicy/juicy-html/git/commits{/sha}","comments_url":"https://api.github.com/repos/Juicy/juicy-html/comments{/number}","issue_comment_url":"https://api.github.com/repos/Juicy/juicy-html/issues/comments{/number}","contents_url":"https://api.github.com/repos/Juicy/juicy-html/contents/{+path}","compare_url":"https://api.github.com/repos/Juicy/juicy-html/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Juicy/juicy-html/merges","archive_url":"https://api.github.com/repos/Juicy/juicy-html/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Juicy/juicy-html/downloads","issues_url":"https://api.github.com/repos/Juicy/juicy-html/issues{/number}","pulls_url":"https://api.github.com/repos/Juicy/juicy-html/pulls{/number}","milestones_url":"https://api.github.com/repos/Juicy/juicy-html/milestones{/number}","notifications_url":"https://api.github.com/repos/Juicy/juicy-html/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Juicy/juicy-html/labels{/name}","releases_url":"https://api.github.com/repos/Juicy/juicy-html/releases{/id}","deployments_url":"https://api.github.com/repos/Juicy/juicy-html/deployments","created_at":"2013-11-18T10:38:52Z","updated_at":"2017-12-12T05:53:15Z","pushed_at":"2017-12-20T09:32:20Z","git_url":"git://github.com/Juicy/juicy-html.git","ssh_url":"git@github.com:Juicy/juicy-html.git","clone_url":"https://github.com/Juicy/juicy-html.git","svn_url":"https://github.com/Juicy/juicy-html","homepage":"http://juicy.github.io/juicy-html/","size":2752,"stargazers_count":48,"watchers_count":48,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":7,"open_issues":5,"watchers":48,"default_branch":"master"}},"base":{"label":"Juicy:2.x","ref":"2.x","sha":"ffff5a758bcd652f01408b9c3fc848f01238f828","user":{"login":"Juicy","id":7557694,"avatar_url":"https://avatars0.githubusercontent.com/u/7557694?v=4","gravatar_id":"","url":"https://api.github.com/users/Juicy","html_url":"https://github.com/Juicy","followers_url":"https://api.github.com/users/Juicy/followers","following_url":"https://api.github.com/users/Juicy/following{/other_user}","gists_url":"https://api.github.com/users/Juicy/gists{/gist_id}","starred_url":"https://api.github.com/users/Juicy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Juicy/subscriptions","organizations_url":"https://api.github.com/users/Juicy/orgs","repos_url":"https://api.github.com/users/Juicy/repos","events_url":"https://api.github.com/users/Juicy/events{/privacy}","received_events_url":"https://api.github.com/users/Juicy/received_events","type":"Organization","site_admin":false},"repo":{"id":14489520,"name":"juicy-html","full_name":"Juicy/juicy-html","owner":{"login":"Juicy","id":7557694,"avatar_url":"https://avatars0.githubusercontent.com/u/7557694?v=4","gravatar_id":"","url":"https://api.github.com/users/Juicy","html_url":"https://github.com/Juicy","followers_url":"https://api.github.com/users/Juicy/followers","following_url":"https://api.github.com/users/Juicy/following{/other_user}","gists_url":"https://api.github.com/users/Juicy/gists{/gist_id}","starred_url":"https://api.github.com/users/Juicy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Juicy/subscriptions","organizations_url":"https://api.github.com/users/Juicy/orgs","repos_url":"https://api.github.com/users/Juicy/repos","events_url":"https://api.github.com/users/Juicy/events{/privacy}","received_events_url":"https://api.github.com/users/Juicy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Juicy/juicy-html","description":"A custom element that lets you load HTML partials into your Web page. Declarative way for client-side includes.","fork":false,"url":"https://api.github.com/repos/Juicy/juicy-html","forks_url":"https://api.github.com/repos/Juicy/juicy-html/forks","keys_url":"https://api.github.com/repos/Juicy/juicy-html/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Juicy/juicy-html/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Juicy/juicy-html/teams","hooks_url":"https://api.github.com/repos/Juicy/juicy-html/hooks","issue_events_url":"https://api.github.com/repos/Juicy/juicy-html/issues/events{/number}","events_url":"https://api.github.com/repos/Juicy/juicy-html/events","assignees_url":"https://api.github.com/repos/Juicy/juicy-html/assignees{/user}","branches_url":"https://api.github.com/repos/Juicy/juicy-html/branches{/branch}","tags_url":"https://api.github.com/repos/Juicy/juicy-html/tags","blobs_url":"https://api.github.com/repos/Juicy/juicy-html/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Juicy/juicy-html/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Juicy/juicy-html/git/refs{/sha}","trees_url":"https://api.github.com/repos/Juicy/juicy-html/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Juicy/juicy-html/statuses/{sha}","languages_url":"https://api.github.com/repos/Juicy/juicy-html/languages","stargazers_url":"https://api.github.com/repos/Juicy/juicy-html/stargazers","contributors_url":"https://api.github.com/repos/Juicy/juicy-html/contributors","subscribers_url":"https://api.github.com/repos/Juicy/juicy-html/subscribers","subscription_url":"https://api.github.com/repos/Juicy/juicy-html/subscription","commits_url":"https://api.github.com/repos/Juicy/juicy-html/commits{/sha}","git_commits_url":"https://api.github.com/repos/Juicy/juicy-html/git/commits{/sha}","comments_url":"https://api.github.com/repos/Juicy/juicy-html/comments{/number}","issue_comment_url":"https://api.github.com/repos/Juicy/juicy-html/issues/comments{/number}","contents_url":"https://api.github.com/repos/Juicy/juicy-html/contents/{+path}","compare_url":"https://api.github.com/repos/Juicy/juicy-html/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Juicy/juicy-html/merges","archive_url":"https://api.github.com/repos/Juicy/juicy-html/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Juicy/juicy-html/downloads","issues_url":"https://api.github.com/repos/Juicy/juicy-html/issues{/number}","pulls_url":"https://api.github.com/repos/Juicy/juicy-html/pulls{/number}","milestones_url":"https://api.github.com/repos/Juicy/juicy-html/milestones{/number}","notifications_url":"https://api.github.com/repos/Juicy/juicy-html/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Juicy/juicy-html/labels{/name}","releases_url":"https://api.github.com/repos/Juicy/juicy-html/releases{/id}","deployments_url":"https://api.github.com/repos/Juicy/juicy-html/deployments","created_at":"2013-11-18T10:38:52Z","updated_at":"2017-12-12T05:53:15Z","pushed_at":"2017-12-20T09:32:20Z","git_url":"git://github.com/Juicy/juicy-html.git","ssh_url":"git@github.com:Juicy/juicy-html.git","clone_url":"https://github.com/Juicy/juicy-html.git","svn_url":"https://github.com/Juicy/juicy-html","homepage":"http://juicy.github.io/juicy-html/","size":2752,"stargazers_count":48,"watchers_count":48,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":7,"open_issues":5,"watchers":48,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Juicy/juicy-html/pulls/37"},"html":{"href":"https://github.com/Juicy/juicy-html/pull/37"},"issue":{"href":"https://api.github.com/repos/Juicy/juicy-html/issues/37"},"comments":{"href":"https://api.github.com/repos/Juicy/juicy-html/issues/37/comments"},"review_comments":{"href":"https://api.github.com/repos/Juicy/juicy-html/pulls/37/comments"},"review_comment":{"href":"https://api.github.com/repos/Juicy/juicy-html/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Juicy/juicy-html/pulls/37/commits"},"statuses":{"href":"https://api.github.com/repos/Juicy/juicy-html/statuses/bbd8217026606f2d00a2a6cd216a25ccb93c5b48"}},"author_association":"OWNER"}}
{"actor":{"display_login":"warpech"}}