{"action":"created","issue":{"url":"https://api.github.com/repos/apache/trafficserver/issues/2352","repository_url":"https://api.github.com/repos/apache/trafficserver","labels_url":"https://api.github.com/repos/apache/trafficserver/issues/2352/labels{/name}","comments_url":"https://api.github.com/repos/apache/trafficserver/issues/2352/comments","events_url":"https://api.github.com/repos/apache/trafficserver/issues/2352/events","html_url":"https://github.com/apache/trafficserver/issues/2352","id":248961061,"number":2352,"title":"build error(fedora26)","user":{"login":"phonehold","id":1635701,"avatar_url":"https://avatars3.githubusercontent.com/u/1635701?v=4","gravatar_id":"","url":"https://api.github.com/users/phonehold","html_url":"https://github.com/phonehold","followers_url":"https://api.github.com/users/phonehold/followers","following_url":"https://api.github.com/users/phonehold/following{/other_user}","gists_url":"https://api.github.com/users/phonehold/gists{/gist_id}","starred_url":"https://api.github.com/users/phonehold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phonehold/subscriptions","organizations_url":"https://api.github.com/users/phonehold/orgs","repos_url":"https://api.github.com/users/phonehold/repos","events_url":"https://api.github.com/users/phonehold/events{/privacy}","received_events_url":"https://api.github.com/users/phonehold/received_events","type":"User","site_admin":false},"labels":[{"id":374862236,"url":"https://api.github.com/repos/apache/trafficserver/labels/Build","name":"Build","color":"b60205","default":false},{"id":616547375,"url":"https://api.github.com/repos/apache/trafficserver/labels/QUIC","name":"QUIC","color":"0052cc","default":false}],"state":"open","locked":false,"assignee":{"login":"maskit","id":153144,"avatar_url":"https://avatars3.githubusercontent.com/u/153144?v=4","gravatar_id":"","url":"https://api.github.com/users/maskit","html_url":"https://github.com/maskit","followers_url":"https://api.github.com/users/maskit/followers","following_url":"https://api.github.com/users/maskit/following{/other_user}","gists_url":"https://api.github.com/users/maskit/gists{/gist_id}","starred_url":"https://api.github.com/users/maskit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maskit/subscriptions","organizations_url":"https://api.github.com/users/maskit/orgs","repos_url":"https://api.github.com/users/maskit/repos","events_url":"https://api.github.com/users/maskit/events{/privacy}","received_events_url":"https://api.github.com/users/maskit/received_events","type":"User","site_admin":false},"assignees":[{"login":"maskit","id":153144,"avatar_url":"https://avatars3.githubusercontent.com/u/153144?v=4","gravatar_id":"","url":"https://api.github.com/users/maskit","html_url":"https://github.com/maskit","followers_url":"https://api.github.com/users/maskit/followers","following_url":"https://api.github.com/users/maskit/following{/other_user}","gists_url":"https://api.github.com/users/maskit/gists{/gist_id}","starred_url":"https://api.github.com/users/maskit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maskit/subscriptions","organizations_url":"https://api.github.com/users/maskit/orgs","repos_url":"https://api.github.com/users/maskit/repos","events_url":"https://api.github.com/users/maskit/events{/privacy}","received_events_url":"https://api.github.com/users/maskit/received_events","type":"User","site_admin":false}],"milestone":null,"comments":6,"created_at":"2017-08-09T08:53:09Z","updated_at":"2017-08-10T01:24:20Z","closed_at":null,"body":"quic-latest branch with openssl 1.1.1-dev\r\n./configure --prefix=/usr/local/ts --with-openssl=/usr/local/openssl/\r\n\r\n```\r\nIn file included from ../../lib/records/I_RecHttp.h:30:0,\r\n                 from QUICNetVConnection.cc:28:\r\n../../lib/ts/Vec.h: In instantiation of ‘void swap(C*, C*) [with C = QUICFrame]’:\r\n/usr/include/c++/7/bits/unique_ptr.h:374:6:   required from ‘void std::unique_ptr<_Tp, _Dp>::reset(std::unique_ptr<_Tp, _Dp>::pointer) [with _Tp = QUICFrame; _Dp = void (*)(QUICFrame*); std::unique_ptr<_Tp, _Dp>::pointer = QUICFrame*]’\r\n/usr/include/c++/7/bits/unique_ptr.h:283:7:   required from ‘std::unique_ptr<_Tp, _Dp>& std::unique_ptr<_Tp, _Dp>::operator=(std::unique_ptr<_Tp, _Dp>&&) [with _Tp = QUICFrame; _Dp = void (*)(QUICFrame*)]’\r\nQUICNetVConnection.cc:174:69:   required from here\r\n../../lib/ts/Vec.h:957:5: error: cannot allocate an object of abstract type ‘QUICFrame’\r\n   C t = *p1;\r\n     ^\r\nIn file included from P_QUICNetVConnection.h:47:0,\r\n                 from P_Net.h:112,\r\n                 from QUICNetVConnection.cc:31:\r\nquic/QUICFrame.h:34:7: note:   because the following virtual functions are pure within ‘QUICFrame’:\r\n class QUICFrame\r\n       ^~~~~~~~~\r\nquic/QUICFrame.h:39:18: note:   virtual size_t QUICFrame::size() const\r\n   virtual size_t size() const = 0;\r\n                  ^~~~\r\nquic/QUICFrame.h:40:16: note:   virtual void QUICFrame::store(uint8_t*, size_t*) const\r\n   virtual void store(uint8_t *buf, size_t *len) const = 0;\r\n                ^~~~~\r\nIn file included from ../../lib/records/I_RecHttp.h:30:0,\r\n                 from QUICNetVConnection.cc:28:\r\n../../lib/ts/Vec.h:957:5: error: cannot declare variable ‘t’ to be of abstract type ‘QUICFrame’\r\n   C t = *p1;\r\n     ^\r\n../../lib/ts/Vec.h: In instantiation of ‘void swap(C*, C*) [with C = QUICPacket]’:\r\n/usr/include/c++/7/bits/unique_ptr.h:374:6:   required from ‘void std::unique_ptr<_Tp, _Dp>::reset(std::unique_ptr<_Tp, _Dp>::pointer) [with _Tp = QUICPacket; _Dp = std::default_delete<QUICPacket>; std::unique_ptr<_Tp, _Dp>::pointer = QUICPacket*]’\r\n/usr/include/c++/7/bits/unique_ptr.h:283:7:   required from ‘std::unique_ptr<_Tp, _Dp>& std::unique_ptr<_Tp, _Dp>::operator=(std::unique_ptr<_Tp, _Dp>&&) [with _Tp = QUICPacket; _Dp = std::default_delete<QUICPacket>]’\r\nQUICNetVConnection.cc:581:130:   required from here\r\n../../lib/ts/Vec.h:957:5: error: use of deleted function ‘QUICPacket::QUICPacket(const QUICPacket&)’\r\nIn file included from quic/QUICPacketTransmitter.h:26:0,\r\n                 from quic/QUICVersionNegotiator.h:27,\r\n                 from P_QUICNetVConnection.h:45,\r\n                 from P_Net.h:112,\r\n                 from QUICNetVConnection.cc:31:\r\nquic/QUICPacket.h:125:7: note: ‘QUICPacket::QUICPacket(const QUICPacket&)’ is implicitly deleted because the default definition would be ill-formed:\r\n class QUICPacket\r\n       ^~~~~~~~~~\r\nquic/QUICPacket.h:125:7: error: use of deleted function ‘std::unique_ptr<_Tp, _Dp>::unique_ptr(const std::unique_ptr<_Tp, _Dp>&) [with _Tp = unsigned char; _Dp = void (*)(void*)]’\r\nIn file included from /usr/include/c++/7/memory:80:0,\r\n                 from quic/QUICPacket.h:26,\r\n                 from quic/QUICPacketTransmitter.h:26,\r\n                 from quic/QUICVersionNegotiator.h:27,\r\n                 from P_QUICNetVConnection.h:45,\r\n                 from P_Net.h:112,\r\n                 from QUICNetVConnection.cc:31:\r\n/usr/include/c++/7/bits/unique_ptr.h:388:7: note: declared here\r\n       unique_ptr(const unique_ptr&) = delete;\r\n       ^~~~~~~~~~\r\nIn file included from ../../lib/records/I_RecHttp.h:30:0,\r\n                 from QUICNetVConnection.cc:28:\r\n../../lib/ts/Vec.h:958:7: error: use of deleted function ‘QUICPacket& QUICPacket::operator=(const QUICPacket&)’\r\n   *p1 = *p2;\r\n   ~~~~^~~~~\r\nIn file included from quic/QUICPacketTransmitter.h:26:0,\r\n                 from quic/QUICVersionNegotiator.h:27,\r\n                 from P_QUICNetVConnection.h:45,\r\n                 from P_Net.h:112,\r\n                 from QUICNetVConnection.cc:31:\r\nquic/QUICPacket.h:125:7: note: ‘QUICPacket& QUICPacket::operator=(const QUICPacket&)’ is implicitly deleted because the default definition would be ill-formed:\r\n class QUICPacket\r\n       ^~~~~~~~~~\r\nquic/QUICPacket.h:125:7: error: use of deleted function ‘std::unique_ptr<_Tp, _Dp>& std::unique_ptr<_Tp, _Dp>::operator=(const std::unique_ptr<_Tp, _Dp>&) [with _Tp = unsigned char; _Dp = void (*)(void*)]’\r\nIn file included from /usr/include/c++/7/memory:80:0,\r\n                 from quic/QUICPacket.h:26,\r\n                 from quic/QUICPacketTransmitter.h:26,\r\n                 from quic/QUICVersionNegotiator.h:27,\r\n                 from P_QUICNetVConnection.h:45,\r\n                 from P_Net.h:112,\r\n                 from QUICNetVConnection.cc:31:\r\n/usr/include/c++/7/bits/unique_ptr.h:389:19: note: declared here\r\n       unique_ptr& operator=(const unique_ptr&) = delete;\r\n                   ^~~~~~~~\r\nIn file included from ../../lib/records/I_RecHttp.h:30:0,\r\n                 from QUICNetVConnection.cc:28:\r\n../../lib/ts/Vec.h:959:7: error: use of deleted function ‘QUICPacket& QUICPacket::operator=(const QUICPacket&)’\r\n   *p2 = t;\r\n   ~~~~^~~\r\nmake[3]: *** [Makefile:1064: QUICNetVConnection.o] Error 1\r\nmake[3]: Leaving directory '/root/trafficserver/iocore/net'\r\nmake[2]: *** [Makefile:1114: all-recursive] Error 1\r\nmake[2]: Leaving directory '/root/trafficserver/iocore/net'\r\n\r\n\r\n```"},"comment":{"url":"https://api.github.com/repos/apache/trafficserver/issues/comments/321424435","html_url":"https://github.com/apache/trafficserver/issues/2352#issuecomment-321424435","issue_url":"https://api.github.com/repos/apache/trafficserver/issues/2352","id":321424435,"user":{"login":"masaori335","id":741391,"avatar_url":"https://avatars1.githubusercontent.com/u/741391?v=4","gravatar_id":"","url":"https://api.github.com/users/masaori335","html_url":"https://github.com/masaori335","followers_url":"https://api.github.com/users/masaori335/followers","following_url":"https://api.github.com/users/masaori335/following{/other_user}","gists_url":"https://api.github.com/users/masaori335/gists{/gist_id}","starred_url":"https://api.github.com/users/masaori335/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/masaori335/subscriptions","organizations_url":"https://api.github.com/users/masaori335/orgs","repos_url":"https://api.github.com/users/masaori335/repos","events_url":"https://api.github.com/users/masaori335/events{/privacy}","received_events_url":"https://api.github.com/users/masaori335/received_events","type":"User","site_admin":false},"created_at":"2017-08-10T01:24:20Z","updated_at":"2017-08-10T01:24:20Z","body":"I think the `swap(C *p1, C *p2)` should be `Vec<C, A, S>::swap(C *p1, C *p2)` in https://github.com/apache/trafficserver/blob/master/lib/ts/Vec.h#L953-L960"}}
{"actor":{"display_login":"masaori335"}}