{"action":"created","comment":{"url":"https://api.github.com/repos/opencast/pyCA/pulls/comments/109694703","pull_request_review_id":30813393,"id":109694703,"diff_hunk":"@@ -47,17 +47,20 @@ def test_help(self):\n         except BaseException as e:\n             assert e.code == 3\n \n-    def test_broken_configuration(self):\n-        fd, fn = tempfile.mkstemp()\n-        with open(fn, 'w') as f:\n-            f.write('[agent]\\nupdate_frequency = \"qwe\"')\n-        sys.argv = ['pyca', '-c', fn, 'fail']\n-        try:\n-            __main__.main()\n-        except BaseException as e:\n-            assert e.code == 4\n-        os.close(fd)\n-        os.remove(fn)\n+    def test_broken_configuration_type(self):\n+        configs = ('[capture]\\nflavors = \"x/source\"\\nfiles = a, b',","path":"tests/test_main.py","position":16,"original_position":16,"commit_id":"1d8fbfc84f46c8818984479e3b8ee46cff5e8a2c","original_commit_id":"1d8fbfc84f46c8818984479e3b8ee46cff5e8a2c","user":{"login":"JanKoppe","id":12087559,"avatar_url":"https://avatars1.githubusercontent.com/u/12087559?v=3","gravatar_id":"","url":"https://api.github.com/users/JanKoppe","html_url":"https://github.com/JanKoppe","followers_url":"https://api.github.com/users/JanKoppe/followers","following_url":"https://api.github.com/users/JanKoppe/following{/other_user}","gists_url":"https://api.github.com/users/JanKoppe/gists{/gist_id}","starred_url":"https://api.github.com/users/JanKoppe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JanKoppe/subscriptions","organizations_url":"https://api.github.com/users/JanKoppe/orgs","repos_url":"https://api.github.com/users/JanKoppe/repos","events_url":"https://api.github.com/users/JanKoppe/events{/privacy}","received_events_url":"https://api.github.com/users/JanKoppe/received_events","type":"User","site_admin":false},"body":"Ah, my bad. You're right.","created_at":"2017-04-04T15:24:28Z","updated_at":"2017-04-04T15:24:28Z","html_url":"https://github.com/opencast/pyCA/pull/105#discussion_r109694703","pull_request_url":"https://api.github.com/repos/opencast/pyCA/pulls/105","_links":{"self":{"href":"https://api.github.com/repos/opencast/pyCA/pulls/comments/109694703"},"html":{"href":"https://github.com/opencast/pyCA/pull/105#discussion_r109694703"},"pull_request":{"href":"https://api.github.com/repos/opencast/pyCA/pulls/105"}}},"pull_request":{"url":"https://api.github.com/repos/opencast/pyCA/pulls/105","id":113290908,"html_url":"https://github.com/opencast/pyCA/pull/105","diff_url":"https://github.com/opencast/pyCA/pull/105.diff","patch_url":"https://github.com/opencast/pyCA/pull/105.patch","issue_url":"https://api.github.com/repos/opencast/pyCA/issues/105","number":105,"state":"open","locked":false,"title":"Expand Configuration Validation","user":{"login":"lkiesow","id":1008395,"avatar_url":"https://avatars0.githubusercontent.com/u/1008395?v=3","gravatar_id":"","url":"https://api.github.com/users/lkiesow","html_url":"https://github.com/lkiesow","followers_url":"https://api.github.com/users/lkiesow/followers","following_url":"https://api.github.com/users/lkiesow/following{/other_user}","gists_url":"https://api.github.com/users/lkiesow/gists{/gist_id}","starred_url":"https://api.github.com/users/lkiesow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lkiesow/subscriptions","organizations_url":"https://api.github.com/users/lkiesow/orgs","repos_url":"https://api.github.com/users/lkiesow/repos","events_url":"https://api.github.com/users/lkiesow/events{/privacy}","received_events_url":"https://api.github.com/users/lkiesow/received_events","type":"User","site_admin":false},"body":"This patch adds more configuration validation which now ensures that the\r\nlists for files and flavors are of equal length since that would cause\r\nerrors later anyway. Best to fail early and let the user know about the\r\nproblem.\r\n\r\nThis is a further improvement of #86","created_at":"2017-03-29T20:46:31Z","updated_at":"2017-04-04T15:24:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c9c283b608d152ce9bcaaffd8b4fe8bfaac1b3e0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/opencast/pyCA/pulls/105/commits","review_comments_url":"https://api.github.com/repos/opencast/pyCA/pulls/105/comments","review_comment_url":"https://api.github.com/repos/opencast/pyCA/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opencast/pyCA/issues/105/comments","statuses_url":"https://api.github.com/repos/opencast/pyCA/statuses/1d8fbfc84f46c8818984479e3b8ee46cff5e8a2c","head":{"label":"lkiesow:config-validation","ref":"config-validation","sha":"1d8fbfc84f46c8818984479e3b8ee46cff5e8a2c","user":{"login":"lkiesow","id":1008395,"avatar_url":"https://avatars0.githubusercontent.com/u/1008395?v=3","gravatar_id":"","url":"https://api.github.com/users/lkiesow","html_url":"https://github.com/lkiesow","followers_url":"https://api.github.com/users/lkiesow/followers","following_url":"https://api.github.com/users/lkiesow/following{/other_user}","gists_url":"https://api.github.com/users/lkiesow/gists{/gist_id}","starred_url":"https://api.github.com/users/lkiesow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lkiesow/subscriptions","organizations_url":"https://api.github.com/users/lkiesow/orgs","repos_url":"https://api.github.com/users/lkiesow/repos","events_url":"https://api.github.com/users/lkiesow/events{/privacy}","received_events_url":"https://api.github.com/users/lkiesow/received_events","type":"User","site_admin":false},"repo":{"id":85341666,"name":"pyCA","full_name":"lkiesow/pyCA","owner":{"login":"lkiesow","id":1008395,"avatar_url":"https://avatars0.githubusercontent.com/u/1008395?v=3","gravatar_id":"","url":"https://api.github.com/users/lkiesow","html_url":"https://github.com/lkiesow","followers_url":"https://api.github.com/users/lkiesow/followers","following_url":"https://api.github.com/users/lkiesow/following{/other_user}","gists_url":"https://api.github.com/users/lkiesow/gists{/gist_id}","starred_url":"https://api.github.com/users/lkiesow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lkiesow/subscriptions","organizations_url":"https://api.github.com/users/lkiesow/orgs","repos_url":"https://api.github.com/users/lkiesow/repos","events_url":"https://api.github.com/users/lkiesow/events{/privacy}","received_events_url":"https://api.github.com/users/lkiesow/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lkiesow/pyCA","description":"Python Capture Agent for Opencast","fork":true,"url":"https://api.github.com/repos/lkiesow/pyCA","forks_url":"https://api.github.com/repos/lkiesow/pyCA/forks","keys_url":"https://api.github.com/repos/lkiesow/pyCA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lkiesow/pyCA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lkiesow/pyCA/teams","hooks_url":"https://api.github.com/repos/lkiesow/pyCA/hooks","issue_events_url":"https://api.github.com/repos/lkiesow/pyCA/issues/events{/number}","events_url":"https://api.github.com/repos/lkiesow/pyCA/events","assignees_url":"https://api.github.com/repos/lkiesow/pyCA/assignees{/user}","branches_url":"https://api.github.com/repos/lkiesow/pyCA/branches{/branch}","tags_url":"https://api.github.com/repos/lkiesow/pyCA/tags","blobs_url":"https://api.github.com/repos/lkiesow/pyCA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lkiesow/pyCA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lkiesow/pyCA/git/refs{/sha}","trees_url":"https://api.github.com/repos/lkiesow/pyCA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lkiesow/pyCA/statuses/{sha}","languages_url":"https://api.github.com/repos/lkiesow/pyCA/languages","stargazers_url":"https://api.github.com/repos/lkiesow/pyCA/stargazers","contributors_url":"https://api.github.com/repos/lkiesow/pyCA/contributors","subscribers_url":"https://api.github.com/repos/lkiesow/pyCA/subscribers","subscription_url":"https://api.github.com/repos/lkiesow/pyCA/subscription","commits_url":"https://api.github.com/repos/lkiesow/pyCA/commits{/sha}","git_commits_url":"https://api.github.com/repos/lkiesow/pyCA/git/commits{/sha}","comments_url":"https://api.github.com/repos/lkiesow/pyCA/comments{/number}","issue_comment_url":"https://api.github.com/repos/lkiesow/pyCA/issues/comments{/number}","contents_url":"https://api.github.com/repos/lkiesow/pyCA/contents/{+path}","compare_url":"https://api.github.com/repos/lkiesow/pyCA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lkiesow/pyCA/merges","archive_url":"https://api.github.com/repos/lkiesow/pyCA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lkiesow/pyCA/downloads","issues_url":"https://api.github.com/repos/lkiesow/pyCA/issues{/number}","pulls_url":"https://api.github.com/repos/lkiesow/pyCA/pulls{/number}","milestones_url":"https://api.github.com/repos/lkiesow/pyCA/milestones{/number}","notifications_url":"https://api.github.com/repos/lkiesow/pyCA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lkiesow/pyCA/labels{/name}","releases_url":"https://api.github.com/repos/lkiesow/pyCA/releases{/id}","deployments_url":"https://api.github.com/repos/lkiesow/pyCA/deployments","created_at":"2017-03-17T18:10:32Z","updated_at":"2017-03-17T18:10:34Z","pushed_at":"2017-03-29T20:59:43Z","git_url":"git://github.com/lkiesow/pyCA.git","ssh_url":"git@github.com:lkiesow/pyCA.git","clone_url":"https://github.com/lkiesow/pyCA.git","svn_url":"https://github.com/lkiesow/pyCA","homepage":"","size":381,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"opencast:master","ref":"master","sha":"477ca21f0258d5f7bbbf1a2ca517f53ce4b831be","user":{"login":"opencast","id":5639632,"avatar_url":"https://avatars3.githubusercontent.com/u/5639632?v=3","gravatar_id":"","url":"https://api.github.com/users/opencast","html_url":"https://github.com/opencast","followers_url":"https://api.github.com/users/opencast/followers","following_url":"https://api.github.com/users/opencast/following{/other_user}","gists_url":"https://api.github.com/users/opencast/gists{/gist_id}","starred_url":"https://api.github.com/users/opencast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencast/subscriptions","organizations_url":"https://api.github.com/users/opencast/orgs","repos_url":"https://api.github.com/users/opencast/repos","events_url":"https://api.github.com/users/opencast/events{/privacy}","received_events_url":"https://api.github.com/users/opencast/received_events","type":"Organization","site_admin":false},"repo":{"id":10574956,"name":"pyCA","full_name":"opencast/pyCA","owner":{"login":"opencast","id":5639632,"avatar_url":"https://avatars3.githubusercontent.com/u/5639632?v=3","gravatar_id":"","url":"https://api.github.com/users/opencast","html_url":"https://github.com/opencast","followers_url":"https://api.github.com/users/opencast/followers","following_url":"https://api.github.com/users/opencast/following{/other_user}","gists_url":"https://api.github.com/users/opencast/gists{/gist_id}","starred_url":"https://api.github.com/users/opencast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencast/subscriptions","organizations_url":"https://api.github.com/users/opencast/orgs","repos_url":"https://api.github.com/users/opencast/repos","events_url":"https://api.github.com/users/opencast/events{/privacy}","received_events_url":"https://api.github.com/users/opencast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opencast/pyCA","description":"Python Capture Agent for Opencast","fork":false,"url":"https://api.github.com/repos/opencast/pyCA","forks_url":"https://api.github.com/repos/opencast/pyCA/forks","keys_url":"https://api.github.com/repos/opencast/pyCA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opencast/pyCA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opencast/pyCA/teams","hooks_url":"https://api.github.com/repos/opencast/pyCA/hooks","issue_events_url":"https://api.github.com/repos/opencast/pyCA/issues/events{/number}","events_url":"https://api.github.com/repos/opencast/pyCA/events","assignees_url":"https://api.github.com/repos/opencast/pyCA/assignees{/user}","branches_url":"https://api.github.com/repos/opencast/pyCA/branches{/branch}","tags_url":"https://api.github.com/repos/opencast/pyCA/tags","blobs_url":"https://api.github.com/repos/opencast/pyCA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opencast/pyCA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opencast/pyCA/git/refs{/sha}","trees_url":"https://api.github.com/repos/opencast/pyCA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opencast/pyCA/statuses/{sha}","languages_url":"https://api.github.com/repos/opencast/pyCA/languages","stargazers_url":"https://api.github.com/repos/opencast/pyCA/stargazers","contributors_url":"https://api.github.com/repos/opencast/pyCA/contributors","subscribers_url":"https://api.github.com/repos/opencast/pyCA/subscribers","subscription_url":"https://api.github.com/repos/opencast/pyCA/subscription","commits_url":"https://api.github.com/repos/opencast/pyCA/commits{/sha}","git_commits_url":"https://api.github.com/repos/opencast/pyCA/git/commits{/sha}","comments_url":"https://api.github.com/repos/opencast/pyCA/comments{/number}","issue_comment_url":"https://api.github.com/repos/opencast/pyCA/issues/comments{/number}","contents_url":"https://api.github.com/repos/opencast/pyCA/contents/{+path}","compare_url":"https://api.github.com/repos/opencast/pyCA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opencast/pyCA/merges","archive_url":"https://api.github.com/repos/opencast/pyCA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opencast/pyCA/downloads","issues_url":"https://api.github.com/repos/opencast/pyCA/issues{/number}","pulls_url":"https://api.github.com/repos/opencast/pyCA/pulls{/number}","milestones_url":"https://api.github.com/repos/opencast/pyCA/milestones{/number}","notifications_url":"https://api.github.com/repos/opencast/pyCA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opencast/pyCA/labels{/name}","releases_url":"https://api.github.com/repos/opencast/pyCA/releases{/id}","deployments_url":"https://api.github.com/repos/opencast/pyCA/deployments","created_at":"2013-06-08T22:14:43Z","updated_at":"2017-02-03T15:34:00Z","pushed_at":"2017-03-29T21:00:27Z","git_url":"git://github.com/opencast/pyCA.git","ssh_url":"git@github.com:opencast/pyCA.git","clone_url":"https://github.com/opencast/pyCA.git","svn_url":"https://github.com/opencast/pyCA","homepage":"","size":411,"stargazers_count":15,"watchers_count":15,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":16,"mirror_url":null,"open_issues_count":20,"forks":16,"open_issues":20,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opencast/pyCA/pulls/105"},"html":{"href":"https://github.com/opencast/pyCA/pull/105"},"issue":{"href":"https://api.github.com/repos/opencast/pyCA/issues/105"},"comments":{"href":"https://api.github.com/repos/opencast/pyCA/issues/105/comments"},"review_comments":{"href":"https://api.github.com/repos/opencast/pyCA/pulls/105/comments"},"review_comment":{"href":"https://api.github.com/repos/opencast/pyCA/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opencast/pyCA/pulls/105/commits"},"statuses":{"href":"https://api.github.com/repos/opencast/pyCA/statuses/1d8fbfc84f46c8818984479e3b8ee46cff5e8a2c"}}}}
{"actor":{"display_login":"JanKoppe"}}