{"action":"created","issue":{"url":"https://api.github.com/repos/wagtail/wagtail/issues/3488","repository_url":"https://api.github.com/repos/wagtail/wagtail","labels_url":"https://api.github.com/repos/wagtail/wagtail/issues/3488/labels{/name}","comments_url":"https://api.github.com/repos/wagtail/wagtail/issues/3488/comments","events_url":"https://api.github.com/repos/wagtail/wagtail/issues/3488/events","html_url":"https://github.com/wagtail/wagtail/pull/3488","id":216368350,"number":3488,"title":"Allow spaces in tags field, disable with setting","user":{"login":"khink","id":179642,"avatar_url":"https://avatars0.githubusercontent.com/u/179642?v=3","gravatar_id":"","url":"https://api.github.com/users/khink","html_url":"https://github.com/khink","followers_url":"https://api.github.com/users/khink/followers","following_url":"https://api.github.com/users/khink/following{/other_user}","gists_url":"https://api.github.com/users/khink/gists{/gist_id}","starred_url":"https://api.github.com/users/khink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khink/subscriptions","organizations_url":"https://api.github.com/users/khink/orgs","repos_url":"https://api.github.com/users/khink/repos","events_url":"https://api.github.com/users/khink/events{/privacy}","received_events_url":"https://api.github.com/users/khink/received_events","type":"User","site_admin":false},"labels":[{"id":566662341,"url":"https://api.github.com/repos/wagtail/wagtail/labels/sprint:Arnhem2017","name":"sprint:Arnhem2017","color":"5319e7","default":false},{"id":181311678,"url":"https://api.github.com/repos/wagtail/wagtail/labels/status:Needs%20review","name":"status:Needs review","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-03-23T09:52:56Z","updated_at":"2017-03-23T11:01:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/wagtail/wagtail/pulls/3488","html_url":"https://github.com/wagtail/wagtail/pull/3488","diff_url":"https://github.com/wagtail/wagtail/pull/3488.diff","patch_url":"https://github.com/wagtail/wagtail/pull/3488.patch"},"body":"This continues the work in https://github.com/wagtail/wagtail/pull/2207, which is superceded by this PR and can be closed.\r\n\r\nThis PR makes the taggit `allowSpaces` setting dependent on the Django setting TAGGIT_SPACES_ALLOWED. If that is not set, we set `allowSpaces = true`. \r\n\r\nNote: This depends on a new context processor `wagtail.wagtailadmin.context_processors.taggit_spaces_allowed`, which should be added to settings files in order for the TAGGIT_SPACES_ALLOWED to be defined in `admin_base.html`. If undefined in the template (ie. context precessor not available), we get `allowSpaces = false`.\r\n\r\nI feel the Python changes are standard Django functionality and don't need testing. If anyone feels differently, please let me know. \r\n\r\n[V] Do the tests still pass? (http://docs.wagtail.io/en/latest/contributing/developing.html#testing)\r\n[V] Does the code comply with the style guide? (Run `make lint` from the Wagtail root)\r\n[-] For Python changes: Have you added tests to cover the new/fixed behaviour?\r\n[V] For new features: Has the documentation been updated accordingly?\r\n"},"comment":{"url":"https://api.github.com/repos/wagtail/wagtail/issues/comments/288684792","html_url":"https://github.com/wagtail/wagtail/pull/3488#issuecomment-288684792","issue_url":"https://api.github.com/repos/wagtail/wagtail/issues/3488","id":288684792,"user":{"login":"gasman","id":85097,"avatar_url":"https://avatars1.githubusercontent.com/u/85097?v=3","gravatar_id":"","url":"https://api.github.com/users/gasman","html_url":"https://github.com/gasman","followers_url":"https://api.github.com/users/gasman/followers","following_url":"https://api.github.com/users/gasman/following{/other_user}","gists_url":"https://api.github.com/users/gasman/gists{/gist_id}","starred_url":"https://api.github.com/users/gasman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gasman/subscriptions","organizations_url":"https://api.github.com/users/gasman/orgs","repos_url":"https://api.github.com/users/gasman/repos","events_url":"https://api.github.com/users/gasman/events{/privacy}","received_events_url":"https://api.github.com/users/gasman/received_events","type":"User","site_admin":false},"created_at":"2017-03-23T11:01:23Z","updated_at":"2017-03-23T11:01:23Z","body":"Thanks @khink!\r\n\r\nI think we really want to avoid introducing a new context processor for this, since it requires every Wagtail developer to make that change to their project settings in order for the setting to work. Of course, that means we need to find a different way to pass the setting into the template. A custom tag in wagtailadmin/templatetags/wagtailadmin_tags.py would work (see e.g. `usage_count_enabled` which is doing exactly this for the `WAGTAIL_USAGE_COUNT_ENABLED` setting). However, I think there might be a neater way to do this as part of the tag field rendering itself... I'll take a look now."}}
{"actor":{"display_login":"gasman"}}