{"action":"created","comment":{"url":"https://api.github.com/repos/feedhenry/fh-mbaas-api/pulls/comments/96818473","pull_request_review_id":17411056,"id":96818473,"diff_hunk":"@@ -297,33 +297,47 @@ function processPending(dataset_id, dataset, params, cb) {\n           syncUtil.doLog(dataset_id, 'verbose', ' READ for UPDATE Success', params);\n           syncUtil.doLog(dataset_id, 'silly', 'READ for UPDATE Data : \\n' + util.inspect(data), params);\n \n-          var preHash = syncUtil.generateHash(pre);\n-          var dataHash = syncUtil.generateHash(data);\n-\n-          syncUtil.doLog(dataset_id, 'verbose', 'UPDATE Hash Check ' + uid + ' (client :: dataStore) = ' + preHash + ' :: ' + dataHash, params);\n-\n-          if (preHash === dataHash) {\n-            DataSetModel.doUpdateHandler(dataset_id, uid, post, function (err) {\n-              if (err) {\n-                syncUtil.doLog(dataset_id, 'warn', 'UPDATE Failed - uid=' + uid + ' : err = ' + err, params);\n-                return addUpdate(\"failed\", \"update\", hash, uid, err, itemCallback);\n+          //var preHash = syncUtil.generateHash(pre);","path":"lib/sync-srv.js","position":14,"original_position":14,"commit_id":"b0d3fb8c3c7d940e3c5cf2e04ec7b69f664ef8dc","original_commit_id":"b0d3fb8c3c7d940e3c5cf2e04ec7b69f664ef8dc","user":{"login":"fh-qube","id":16801364,"avatar_url":"https://avatars.githubusercontent.com/u/16801364?v=3","gravatar_id":"","url":"https://api.github.com/users/fh-qube","html_url":"https://github.com/fh-qube","followers_url":"https://api.github.com/users/fh-qube/followers","following_url":"https://api.github.com/users/fh-qube/following{/other_user}","gists_url":"https://api.github.com/users/fh-qube/gists{/gist_id}","starred_url":"https://api.github.com/users/fh-qube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fh-qube/subscriptions","organizations_url":"https://api.github.com/users/fh-qube/orgs","repos_url":"https://api.github.com/users/fh-qube/repos","events_url":"https://api.github.com/users/fh-qube/events{/privacy}","received_events_url":"https://api.github.com/users/fh-qube/received_events","type":"User","site_admin":false},"body":"![MAJOR](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/severity-major.png) Remove this commented out code. [![rule](https://raw.githubusercontent.com/SonarCommunity/sonar-github/master/images/rule.png)](https://metrics.skunkhenry.com/coding_rules#rule_key=javascript%3ACommentedCode)\n","created_at":"2017-01-19T09:20:33Z","updated_at":"2017-01-19T09:20:33Z","html_url":"https://github.com/feedhenry/fh-mbaas-api/pull/39#discussion_r96818473","pull_request_url":"https://api.github.com/repos/feedhenry/fh-mbaas-api/pulls/39","_links":{"self":{"href":"https://api.github.com/repos/feedhenry/fh-mbaas-api/pulls/comments/96818473"},"html":{"href":"https://github.com/feedhenry/fh-mbaas-api/pull/39#discussion_r96818473"},"pull_request":{"href":"https://api.github.com/repos/feedhenry/fh-mbaas-api/pulls/39"}}},"pull_request":{"url":"https://api.github.com/repos/feedhenry/fh-mbaas-api/pulls/39","id":102227931,"html_url":"https://github.com/feedhenry/fh-mbaas-api/pull/39","diff_url":"https://github.com/feedhenry/fh-mbaas-api/pull/39.diff","patch_url":"https://github.com/feedhenry/fh-mbaas-api/pull/39.patch","issue_url":"https://api.github.com/repos/feedhenry/fh-mbaas-api/issues/39","number":39,"state":"open","locked":false,"title":"[WIP] FH-3023 Add asyncGenerateHash function","user":{"login":"aidenkeating","id":8698527,"avatar_url":"https://avatars.githubusercontent.com/u/8698527?v=3","gravatar_id":"","url":"https://api.github.com/users/aidenkeating","html_url":"https://github.com/aidenkeating","followers_url":"https://api.github.com/users/aidenkeating/followers","following_url":"https://api.github.com/users/aidenkeating/following{/other_user}","gists_url":"https://api.github.com/users/aidenkeating/gists{/gist_id}","starred_url":"https://api.github.com/users/aidenkeating/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aidenkeating/subscriptions","organizations_url":"https://api.github.com/users/aidenkeating/orgs","repos_url":"https://api.github.com/users/aidenkeating/repos","events_url":"https://api.github.com/users/aidenkeating/events{/privacy}","received_events_url":"https://api.github.com/users/aidenkeating/received_events","type":"User","site_admin":false},"body":"Currently a large majority of the `JSON.stringify` commands are\nmade from `generateHash`. In performance analysis of the sync\nframework this was found to be an issue.\n\nThis adds an `asyncGenerateHash` function and an `asyncGetClientHash`\nfunction to the MBaaS API to allow for these calls to be made\nasynchronously.\n\nThis also implements these calls internally in the API.","created_at":"2017-01-19T09:20:00Z","updated_at":"2017-01-19T09:20:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b579b90c9a641679fb4a37035b67a441b2e63c33","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/feedhenry/fh-mbaas-api/pulls/39/commits","review_comments_url":"https://api.github.com/repos/feedhenry/fh-mbaas-api/pulls/39/comments","review_comment_url":"https://api.github.com/repos/feedhenry/fh-mbaas-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/feedhenry/fh-mbaas-api/issues/39/comments","statuses_url":"https://api.github.com/repos/feedhenry/fh-mbaas-api/statuses/b0d3fb8c3c7d940e3c5cf2e04ec7b69f664ef8dc","head":{"label":"aidenkeating:FH-3023_async-stringify","ref":"FH-3023_async-stringify","sha":"b0d3fb8c3c7d940e3c5cf2e04ec7b69f664ef8dc","user":{"login":"aidenkeating","id":8698527,"avatar_url":"https://avatars.githubusercontent.com/u/8698527?v=3","gravatar_id":"","url":"https://api.github.com/users/aidenkeating","html_url":"https://github.com/aidenkeating","followers_url":"https://api.github.com/users/aidenkeating/followers","following_url":"https://api.github.com/users/aidenkeating/following{/other_user}","gists_url":"https://api.github.com/users/aidenkeating/gists{/gist_id}","starred_url":"https://api.github.com/users/aidenkeating/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aidenkeating/subscriptions","organizations_url":"https://api.github.com/users/aidenkeating/orgs","repos_url":"https://api.github.com/users/aidenkeating/repos","events_url":"https://api.github.com/users/aidenkeating/events{/privacy}","received_events_url":"https://api.github.com/users/aidenkeating/received_events","type":"User","site_admin":false},"repo":{"id":79214908,"name":"fh-mbaas-api","full_name":"aidenkeating/fh-mbaas-api","owner":{"login":"aidenkeating","id":8698527,"avatar_url":"https://avatars.githubusercontent.com/u/8698527?v=3","gravatar_id":"","url":"https://api.github.com/users/aidenkeating","html_url":"https://github.com/aidenkeating","followers_url":"https://api.github.com/users/aidenkeating/followers","following_url":"https://api.github.com/users/aidenkeating/following{/other_user}","gists_url":"https://api.github.com/users/aidenkeating/gists{/gist_id}","starred_url":"https://api.github.com/users/aidenkeating/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aidenkeating/subscriptions","organizations_url":"https://api.github.com/users/aidenkeating/orgs","repos_url":"https://api.github.com/users/aidenkeating/repos","events_url":"https://api.github.com/users/aidenkeating/events{/privacy}","received_events_url":"https://api.github.com/users/aidenkeating/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aidenkeating/fh-mbaas-api","description":null,"fork":true,"url":"https://api.github.com/repos/aidenkeating/fh-mbaas-api","forks_url":"https://api.github.com/repos/aidenkeating/fh-mbaas-api/forks","keys_url":"https://api.github.com/repos/aidenkeating/fh-mbaas-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aidenkeating/fh-mbaas-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aidenkeating/fh-mbaas-api/teams","hooks_url":"https://api.github.com/repos/aidenkeating/fh-mbaas-api/hooks","issue_events_url":"https://api.github.com/repos/aidenkeating/fh-mbaas-api/issues/events{/number}","events_url":"https://api.github.com/repos/aidenkeating/fh-mbaas-api/events","assignees_url":"https://api.github.com/repos/aidenkeating/fh-mbaas-api/assignees{/user}","branches_url":"https://api.github.com/repos/aidenkeating/fh-mbaas-api/branches{/branch}","tags_url":"https://api.github.com/repos/aidenkeating/fh-mbaas-api/tags","blobs_url":"https://api.github.com/repos/aidenkeating/fh-mbaas-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aidenkeating/fh-mbaas-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aidenkeating/fh-mbaas-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/aidenkeating/fh-mbaas-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aidenkeating/fh-mbaas-api/statuses/{sha}","languages_url":"https://api.github.com/repos/aidenkeating/fh-mbaas-api/languages","stargazers_url":"https://api.github.com/repos/aidenkeating/fh-mbaas-api/stargazers","contributors_url":"https://api.github.com/repos/aidenkeating/fh-mbaas-api/contributors","subscribers_url":"https://api.github.com/repos/aidenkeating/fh-mbaas-api/subscribers","subscription_url":"https://api.github.com/repos/aidenkeating/fh-mbaas-api/subscription","commits_url":"https://api.github.com/repos/aidenkeating/fh-mbaas-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/aidenkeating/fh-mbaas-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/aidenkeating/fh-mbaas-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/aidenkeating/fh-mbaas-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/aidenkeating/fh-mbaas-api/contents/{+path}","compare_url":"https://api.github.com/repos/aidenkeating/fh-mbaas-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aidenkeating/fh-mbaas-api/merges","archive_url":"https://api.github.com/repos/aidenkeating/fh-mbaas-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aidenkeating/fh-mbaas-api/downloads","issues_url":"https://api.github.com/repos/aidenkeating/fh-mbaas-api/issues{/number}","pulls_url":"https://api.github.com/repos/aidenkeating/fh-mbaas-api/pulls{/number}","milestones_url":"https://api.github.com/repos/aidenkeating/fh-mbaas-api/milestones{/number}","notifications_url":"https://api.github.com/repos/aidenkeating/fh-mbaas-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aidenkeating/fh-mbaas-api/labels{/name}","releases_url":"https://api.github.com/repos/aidenkeating/fh-mbaas-api/releases{/id}","deployments_url":"https://api.github.com/repos/aidenkeating/fh-mbaas-api/deployments","created_at":"2017-01-17T10:11:21Z","updated_at":"2017-01-17T10:11:24Z","pushed_at":"2017-01-19T09:19:27Z","git_url":"git://github.com/aidenkeating/fh-mbaas-api.git","ssh_url":"git@github.com:aidenkeating/fh-mbaas-api.git","clone_url":"https://github.com/aidenkeating/fh-mbaas-api.git","svn_url":"https://github.com/aidenkeating/fh-mbaas-api","homepage":null,"size":766,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"feedhenry:master","ref":"master","sha":"2b4cc40965524810a966ff3f24cdc095ff84f3ea","user":{"login":"feedhenry","id":772226,"avatar_url":"https://avatars.githubusercontent.com/u/772226?v=3","gravatar_id":"","url":"https://api.github.com/users/feedhenry","html_url":"https://github.com/feedhenry","followers_url":"https://api.github.com/users/feedhenry/followers","following_url":"https://api.github.com/users/feedhenry/following{/other_user}","gists_url":"https://api.github.com/users/feedhenry/gists{/gist_id}","starred_url":"https://api.github.com/users/feedhenry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feedhenry/subscriptions","organizations_url":"https://api.github.com/users/feedhenry/orgs","repos_url":"https://api.github.com/users/feedhenry/repos","events_url":"https://api.github.com/users/feedhenry/events{/privacy}","received_events_url":"https://api.github.com/users/feedhenry/received_events","type":"Organization","site_admin":false},"repo":{"id":62570841,"name":"fh-mbaas-api","full_name":"feedhenry/fh-mbaas-api","owner":{"login":"feedhenry","id":772226,"avatar_url":"https://avatars.githubusercontent.com/u/772226?v=3","gravatar_id":"","url":"https://api.github.com/users/feedhenry","html_url":"https://github.com/feedhenry","followers_url":"https://api.github.com/users/feedhenry/followers","following_url":"https://api.github.com/users/feedhenry/following{/other_user}","gists_url":"https://api.github.com/users/feedhenry/gists{/gist_id}","starred_url":"https://api.github.com/users/feedhenry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feedhenry/subscriptions","organizations_url":"https://api.github.com/users/feedhenry/orgs","repos_url":"https://api.github.com/users/feedhenry/repos","events_url":"https://api.github.com/users/feedhenry/events{/privacy}","received_events_url":"https://api.github.com/users/feedhenry/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/feedhenry/fh-mbaas-api","description":null,"fork":false,"url":"https://api.github.com/repos/feedhenry/fh-mbaas-api","forks_url":"https://api.github.com/repos/feedhenry/fh-mbaas-api/forks","keys_url":"https://api.github.com/repos/feedhenry/fh-mbaas-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/feedhenry/fh-mbaas-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/feedhenry/fh-mbaas-api/teams","hooks_url":"https://api.github.com/repos/feedhenry/fh-mbaas-api/hooks","issue_events_url":"https://api.github.com/repos/feedhenry/fh-mbaas-api/issues/events{/number}","events_url":"https://api.github.com/repos/feedhenry/fh-mbaas-api/events","assignees_url":"https://api.github.com/repos/feedhenry/fh-mbaas-api/assignees{/user}","branches_url":"https://api.github.com/repos/feedhenry/fh-mbaas-api/branches{/branch}","tags_url":"https://api.github.com/repos/feedhenry/fh-mbaas-api/tags","blobs_url":"https://api.github.com/repos/feedhenry/fh-mbaas-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/feedhenry/fh-mbaas-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/feedhenry/fh-mbaas-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/feedhenry/fh-mbaas-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/feedhenry/fh-mbaas-api/statuses/{sha}","languages_url":"https://api.github.com/repos/feedhenry/fh-mbaas-api/languages","stargazers_url":"https://api.github.com/repos/feedhenry/fh-mbaas-api/stargazers","contributors_url":"https://api.github.com/repos/feedhenry/fh-mbaas-api/contributors","subscribers_url":"https://api.github.com/repos/feedhenry/fh-mbaas-api/subscribers","subscription_url":"https://api.github.com/repos/feedhenry/fh-mbaas-api/subscription","commits_url":"https://api.github.com/repos/feedhenry/fh-mbaas-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/feedhenry/fh-mbaas-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/feedhenry/fh-mbaas-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/feedhenry/fh-mbaas-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/feedhenry/fh-mbaas-api/contents/{+path}","compare_url":"https://api.github.com/repos/feedhenry/fh-mbaas-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/feedhenry/fh-mbaas-api/merges","archive_url":"https://api.github.com/repos/feedhenry/fh-mbaas-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/feedhenry/fh-mbaas-api/downloads","issues_url":"https://api.github.com/repos/feedhenry/fh-mbaas-api/issues{/number}","pulls_url":"https://api.github.com/repos/feedhenry/fh-mbaas-api/pulls{/number}","milestones_url":"https://api.github.com/repos/feedhenry/fh-mbaas-api/milestones{/number}","notifications_url":"https://api.github.com/repos/feedhenry/fh-mbaas-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/feedhenry/fh-mbaas-api/labels{/name}","releases_url":"https://api.github.com/repos/feedhenry/fh-mbaas-api/releases{/id}","deployments_url":"https://api.github.com/repos/feedhenry/fh-mbaas-api/deployments","created_at":"2016-07-04T15:09:45Z","updated_at":"2016-11-07T23:00:04Z","pushed_at":"2017-01-19T09:20:26Z","git_url":"git://github.com/feedhenry/fh-mbaas-api.git","ssh_url":"git@github.com:feedhenry/fh-mbaas-api.git","clone_url":"https://github.com/feedhenry/fh-mbaas-api.git","svn_url":"https://github.com/feedhenry/fh-mbaas-api","homepage":null,"size":767,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":6,"forks":17,"open_issues":6,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/feedhenry/fh-mbaas-api/pulls/39"},"html":{"href":"https://github.com/feedhenry/fh-mbaas-api/pull/39"},"issue":{"href":"https://api.github.com/repos/feedhenry/fh-mbaas-api/issues/39"},"comments":{"href":"https://api.github.com/repos/feedhenry/fh-mbaas-api/issues/39/comments"},"review_comments":{"href":"https://api.github.com/repos/feedhenry/fh-mbaas-api/pulls/39/comments"},"review_comment":{"href":"https://api.github.com/repos/feedhenry/fh-mbaas-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/feedhenry/fh-mbaas-api/pulls/39/commits"},"statuses":{"href":"https://api.github.com/repos/feedhenry/fh-mbaas-api/statuses/b0d3fb8c3c7d940e3c5cf2e04ec7b69f664ef8dc"}}}}
{"actor":{"display_login":"fh-qube"}}