{"action":"created","comment":{"url":"https://api.github.com/repos/martinjw/dbschemareader/pulls/comments/145372623","pull_request_review_id":70159808,"id":145372623,"diff_hunk":"@@ -414,7 +429,23 @@ public virtual string DropColumn(DatabaseTable databaseTable, DatabaseColumn dat\n                         Escape(uniqueKey.Name)));\n                 }\n             }\n-            sb.AppendLine(\"ALTER TABLE \" + TableName(databaseTable) + \" DROP COLUMN \" + Escape(databaseColumn.Name) + LineEnding());\n+            if (!SupportsDropColumn)\n+            {\n+                sb.AppendLine(string.Format(\"--TO DROP COLUMN {0}, WE CREATE BACKUP, MOVE CONTENT AND RENAME TABLE \" + LineEnding(), Escape(databaseColumn.Name)));","path":"DatabaseSchemaReader/SqlGen/MigrationGenerator.cs","position":86,"original_position":86,"commit_id":"7be273043ac6db32a500cfd4726fd0e454bc9f87","original_commit_id":"7be273043ac6db32a500cfd4726fd0e454bc9f87","user":{"login":"martinjw","id":2040281,"avatar_url":"https://avatars2.githubusercontent.com/u/2040281?v=4","gravatar_id":"","url":"https://api.github.com/users/martinjw","html_url":"https://github.com/martinjw","followers_url":"https://api.github.com/users/martinjw/followers","following_url":"https://api.github.com/users/martinjw/following{/other_user}","gists_url":"https://api.github.com/users/martinjw/gists{/gist_id}","starred_url":"https://api.github.com/users/martinjw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinjw/subscriptions","organizations_url":"https://api.github.com/users/martinjw/orgs","repos_url":"https://api.github.com/users/martinjw/repos","events_url":"https://api.github.com/users/martinjw/events{/privacy}","received_events_url":"https://api.github.com/users/martinjw/received_events","type":"User","site_admin":false},"body":"Also in SqLiteMigrationGenerator","created_at":"2017-10-18T10:20:24Z","updated_at":"2017-10-18T11:00:37Z","html_url":"https://github.com/martinjw/dbschemareader/pull/52#discussion_r145372623","pull_request_url":"https://api.github.com/repos/martinjw/dbschemareader/pulls/52","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/martinjw/dbschemareader/pulls/comments/145372623"},"html":{"href":"https://github.com/martinjw/dbschemareader/pull/52#discussion_r145372623"},"pull_request":{"href":"https://api.github.com/repos/martinjw/dbschemareader/pulls/52"}}},"pull_request":{"url":"https://api.github.com/repos/martinjw/dbschemareader/pulls/52","id":146216296,"html_url":"https://github.com/martinjw/dbschemareader/pull/52","diff_url":"https://github.com/martinjw/dbschemareader/pull/52.diff","patch_url":"https://github.com/martinjw/dbschemareader/pull/52.patch","issue_url":"https://api.github.com/repos/martinjw/dbschemareader/issues/52","number":52,"state":"open","locked":false,"title":"Implement ALTER table/drop column migrations for SQLITE","user":{"login":"xwiz","id":3619843,"avatar_url":"https://avatars0.githubusercontent.com/u/3619843?v=4","gravatar_id":"","url":"https://api.github.com/users/xwiz","html_url":"https://github.com/xwiz","followers_url":"https://api.github.com/users/xwiz/followers","following_url":"https://api.github.com/users/xwiz/following{/other_user}","gists_url":"https://api.github.com/users/xwiz/gists{/gist_id}","starred_url":"https://api.github.com/users/xwiz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xwiz/subscriptions","organizations_url":"https://api.github.com/users/xwiz/orgs","repos_url":"https://api.github.com/users/xwiz/repos","events_url":"https://api.github.com/users/xwiz/events{/privacy}","received_events_url":"https://api.github.com/users/xwiz/received_events","type":"User","site_admin":false},"body":"Use backup table strategy to copy existing data, recreate, recopy and rename table where needed.","created_at":"2017-10-12T13:57:40Z","updated_at":"2017-10-18T11:00:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"27151d4d95c04958ea3147b5aa9dc9b8da8382ed","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/martinjw/dbschemareader/pulls/52/commits","review_comments_url":"https://api.github.com/repos/martinjw/dbschemareader/pulls/52/comments","review_comment_url":"https://api.github.com/repos/martinjw/dbschemareader/pulls/comments{/number}","comments_url":"https://api.github.com/repos/martinjw/dbschemareader/issues/52/comments","statuses_url":"https://api.github.com/repos/martinjw/dbschemareader/statuses/7be273043ac6db32a500cfd4726fd0e454bc9f87","head":{"label":"xwiz:master","ref":"master","sha":"7be273043ac6db32a500cfd4726fd0e454bc9f87","user":{"login":"xwiz","id":3619843,"avatar_url":"https://avatars0.githubusercontent.com/u/3619843?v=4","gravatar_id":"","url":"https://api.github.com/users/xwiz","html_url":"https://github.com/xwiz","followers_url":"https://api.github.com/users/xwiz/followers","following_url":"https://api.github.com/users/xwiz/following{/other_user}","gists_url":"https://api.github.com/users/xwiz/gists{/gist_id}","starred_url":"https://api.github.com/users/xwiz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xwiz/subscriptions","organizations_url":"https://api.github.com/users/xwiz/orgs","repos_url":"https://api.github.com/users/xwiz/repos","events_url":"https://api.github.com/users/xwiz/events{/privacy}","received_events_url":"https://api.github.com/users/xwiz/received_events","type":"User","site_admin":false},"repo":{"id":105709734,"name":"dbschemareader","full_name":"xwiz/dbschemareader","owner":{"login":"xwiz","id":3619843,"avatar_url":"https://avatars0.githubusercontent.com/u/3619843?v=4","gravatar_id":"","url":"https://api.github.com/users/xwiz","html_url":"https://github.com/xwiz","followers_url":"https://api.github.com/users/xwiz/followers","following_url":"https://api.github.com/users/xwiz/following{/other_user}","gists_url":"https://api.github.com/users/xwiz/gists{/gist_id}","starred_url":"https://api.github.com/users/xwiz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xwiz/subscriptions","organizations_url":"https://api.github.com/users/xwiz/orgs","repos_url":"https://api.github.com/users/xwiz/repos","events_url":"https://api.github.com/users/xwiz/events{/privacy}","received_events_url":"https://api.github.com/users/xwiz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xwiz/dbschemareader","description":"Read database metadata (from SqlServer/Oracle/MySql/SQLite/PostgreSql/DB2 etc) into one simple model","fork":true,"url":"https://api.github.com/repos/xwiz/dbschemareader","forks_url":"https://api.github.com/repos/xwiz/dbschemareader/forks","keys_url":"https://api.github.com/repos/xwiz/dbschemareader/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xwiz/dbschemareader/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xwiz/dbschemareader/teams","hooks_url":"https://api.github.com/repos/xwiz/dbschemareader/hooks","issue_events_url":"https://api.github.com/repos/xwiz/dbschemareader/issues/events{/number}","events_url":"https://api.github.com/repos/xwiz/dbschemareader/events","assignees_url":"https://api.github.com/repos/xwiz/dbschemareader/assignees{/user}","branches_url":"https://api.github.com/repos/xwiz/dbschemareader/branches{/branch}","tags_url":"https://api.github.com/repos/xwiz/dbschemareader/tags","blobs_url":"https://api.github.com/repos/xwiz/dbschemareader/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xwiz/dbschemareader/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xwiz/dbschemareader/git/refs{/sha}","trees_url":"https://api.github.com/repos/xwiz/dbschemareader/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xwiz/dbschemareader/statuses/{sha}","languages_url":"https://api.github.com/repos/xwiz/dbschemareader/languages","stargazers_url":"https://api.github.com/repos/xwiz/dbschemareader/stargazers","contributors_url":"https://api.github.com/repos/xwiz/dbschemareader/contributors","subscribers_url":"https://api.github.com/repos/xwiz/dbschemareader/subscribers","subscription_url":"https://api.github.com/repos/xwiz/dbschemareader/subscription","commits_url":"https://api.github.com/repos/xwiz/dbschemareader/commits{/sha}","git_commits_url":"https://api.github.com/repos/xwiz/dbschemareader/git/commits{/sha}","comments_url":"https://api.github.com/repos/xwiz/dbschemareader/comments{/number}","issue_comment_url":"https://api.github.com/repos/xwiz/dbschemareader/issues/comments{/number}","contents_url":"https://api.github.com/repos/xwiz/dbschemareader/contents/{+path}","compare_url":"https://api.github.com/repos/xwiz/dbschemareader/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xwiz/dbschemareader/merges","archive_url":"https://api.github.com/repos/xwiz/dbschemareader/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xwiz/dbschemareader/downloads","issues_url":"https://api.github.com/repos/xwiz/dbschemareader/issues{/number}","pulls_url":"https://api.github.com/repos/xwiz/dbschemareader/pulls{/number}","milestones_url":"https://api.github.com/repos/xwiz/dbschemareader/milestones{/number}","notifications_url":"https://api.github.com/repos/xwiz/dbschemareader/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xwiz/dbschemareader/labels{/name}","releases_url":"https://api.github.com/repos/xwiz/dbschemareader/releases{/id}","deployments_url":"https://api.github.com/repos/xwiz/dbschemareader/deployments","created_at":"2017-10-03T22:22:37Z","updated_at":"2017-10-03T22:22:40Z","pushed_at":"2017-10-12T13:53:13Z","git_url":"git://github.com/xwiz/dbschemareader.git","ssh_url":"git@github.com:xwiz/dbschemareader.git","clone_url":"https://github.com/xwiz/dbschemareader.git","svn_url":"https://github.com/xwiz/dbschemareader","homepage":"","size":22475,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"martinjw:master","ref":"master","sha":"0924006bcdddb06d9b3ad60e4bc3ba1dd96141ef","user":{"login":"martinjw","id":2040281,"avatar_url":"https://avatars2.githubusercontent.com/u/2040281?v=4","gravatar_id":"","url":"https://api.github.com/users/martinjw","html_url":"https://github.com/martinjw","followers_url":"https://api.github.com/users/martinjw/followers","following_url":"https://api.github.com/users/martinjw/following{/other_user}","gists_url":"https://api.github.com/users/martinjw/gists{/gist_id}","starred_url":"https://api.github.com/users/martinjw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinjw/subscriptions","organizations_url":"https://api.github.com/users/martinjw/orgs","repos_url":"https://api.github.com/users/martinjw/repos","events_url":"https://api.github.com/users/martinjw/events{/privacy}","received_events_url":"https://api.github.com/users/martinjw/received_events","type":"User","site_admin":false},"repo":{"id":32627990,"name":"dbschemareader","full_name":"martinjw/dbschemareader","owner":{"login":"martinjw","id":2040281,"avatar_url":"https://avatars2.githubusercontent.com/u/2040281?v=4","gravatar_id":"","url":"https://api.github.com/users/martinjw","html_url":"https://github.com/martinjw","followers_url":"https://api.github.com/users/martinjw/followers","following_url":"https://api.github.com/users/martinjw/following{/other_user}","gists_url":"https://api.github.com/users/martinjw/gists{/gist_id}","starred_url":"https://api.github.com/users/martinjw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinjw/subscriptions","organizations_url":"https://api.github.com/users/martinjw/orgs","repos_url":"https://api.github.com/users/martinjw/repos","events_url":"https://api.github.com/users/martinjw/events{/privacy}","received_events_url":"https://api.github.com/users/martinjw/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/martinjw/dbschemareader","description":"Read database metadata (from SqlServer/Oracle/MySql/SQLite/PostgreSql/DB2 etc) into one simple model","fork":false,"url":"https://api.github.com/repos/martinjw/dbschemareader","forks_url":"https://api.github.com/repos/martinjw/dbschemareader/forks","keys_url":"https://api.github.com/repos/martinjw/dbschemareader/keys{/key_id}","collaborators_url":"https://api.github.com/repos/martinjw/dbschemareader/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/martinjw/dbschemareader/teams","hooks_url":"https://api.github.com/repos/martinjw/dbschemareader/hooks","issue_events_url":"https://api.github.com/repos/martinjw/dbschemareader/issues/events{/number}","events_url":"https://api.github.com/repos/martinjw/dbschemareader/events","assignees_url":"https://api.github.com/repos/martinjw/dbschemareader/assignees{/user}","branches_url":"https://api.github.com/repos/martinjw/dbschemareader/branches{/branch}","tags_url":"https://api.github.com/repos/martinjw/dbschemareader/tags","blobs_url":"https://api.github.com/repos/martinjw/dbschemareader/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/martinjw/dbschemareader/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/martinjw/dbschemareader/git/refs{/sha}","trees_url":"https://api.github.com/repos/martinjw/dbschemareader/git/trees{/sha}","statuses_url":"https://api.github.com/repos/martinjw/dbschemareader/statuses/{sha}","languages_url":"https://api.github.com/repos/martinjw/dbschemareader/languages","stargazers_url":"https://api.github.com/repos/martinjw/dbschemareader/stargazers","contributors_url":"https://api.github.com/repos/martinjw/dbschemareader/contributors","subscribers_url":"https://api.github.com/repos/martinjw/dbschemareader/subscribers","subscription_url":"https://api.github.com/repos/martinjw/dbschemareader/subscription","commits_url":"https://api.github.com/repos/martinjw/dbschemareader/commits{/sha}","git_commits_url":"https://api.github.com/repos/martinjw/dbschemareader/git/commits{/sha}","comments_url":"https://api.github.com/repos/martinjw/dbschemareader/comments{/number}","issue_comment_url":"https://api.github.com/repos/martinjw/dbschemareader/issues/comments{/number}","contents_url":"https://api.github.com/repos/martinjw/dbschemareader/contents/{+path}","compare_url":"https://api.github.com/repos/martinjw/dbschemareader/compare/{base}...{head}","merges_url":"https://api.github.com/repos/martinjw/dbschemareader/merges","archive_url":"https://api.github.com/repos/martinjw/dbschemareader/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/martinjw/dbschemareader/downloads","issues_url":"https://api.github.com/repos/martinjw/dbschemareader/issues{/number}","pulls_url":"https://api.github.com/repos/martinjw/dbschemareader/pulls{/number}","milestones_url":"https://api.github.com/repos/martinjw/dbschemareader/milestones{/number}","notifications_url":"https://api.github.com/repos/martinjw/dbschemareader/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/martinjw/dbschemareader/labels{/name}","releases_url":"https://api.github.com/repos/martinjw/dbschemareader/releases{/id}","deployments_url":"https://api.github.com/repos/martinjw/dbschemareader/deployments","created_at":"2015-03-21T10:17:44Z","updated_at":"2017-10-12T10:56:55Z","pushed_at":"2017-10-12T13:57:41Z","git_url":"git://github.com/martinjw/dbschemareader.git","ssh_url":"git@github.com:martinjw/dbschemareader.git","clone_url":"https://github.com/martinjw/dbschemareader.git","svn_url":"https://github.com/martinjw/dbschemareader","homepage":"","size":22481,"stargazers_count":88,"watchers_count":88,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":45,"mirror_url":null,"open_issues_count":7,"forks":45,"open_issues":7,"watchers":88,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/martinjw/dbschemareader/pulls/52"},"html":{"href":"https://github.com/martinjw/dbschemareader/pull/52"},"issue":{"href":"https://api.github.com/repos/martinjw/dbschemareader/issues/52"},"comments":{"href":"https://api.github.com/repos/martinjw/dbschemareader/issues/52/comments"},"review_comments":{"href":"https://api.github.com/repos/martinjw/dbschemareader/pulls/52/comments"},"review_comment":{"href":"https://api.github.com/repos/martinjw/dbschemareader/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/martinjw/dbschemareader/pulls/52/commits"},"statuses":{"href":"https://api.github.com/repos/martinjw/dbschemareader/statuses/7be273043ac6db32a500cfd4726fd0e454bc9f87"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"martinjw"}}