{"action":"created","comment":{"url":"https://api.github.com/repos/linkedin/Burrow/pulls/comments/94627216","pull_request_review_id":15158080,"id":94627216,"diff_hunk":"@@ -176,7 +181,7 @@ func (nc *NotifyCenter) startConsumerGroupEvaluator(group string, cluster string\n \t\tnc.groupLock.RUnlock()\n \n \t\t// Send requests for group status - responses are handled by the main loop (for now)\n-\t\tstorageRequest := &RequestConsumerStatus{Result: nc.resultsChannel, Cluster: cluster, Group: group}\n+\t\tstorageRequest := &RequestConsumerStatus{Result: nc.resultsChannel, Cluster: cluster, Group: group, Showall: true}","path":"notify_center.go","position":null,"original_position":17,"commit_id":"20a2a95cf8cfc79ecf2bdff9e776b2f9519f59a7","original_commit_id":"a659c36d5e33cd0cdc18c585dd095717da537c0e","user":{"login":"druminski","id":4473056,"avatar_url":"https://avatars.githubusercontent.com/u/4473056?v=3","gravatar_id":"","url":"https://api.github.com/users/druminski","html_url":"https://github.com/druminski","followers_url":"https://api.github.com/users/druminski/followers","following_url":"https://api.github.com/users/druminski/following{/other_user}","gists_url":"https://api.github.com/users/druminski/gists{/gist_id}","starred_url":"https://api.github.com/users/druminski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/druminski/subscriptions","organizations_url":"https://api.github.com/users/druminski/orgs","repos_url":"https://api.github.com/users/druminski/repos","events_url":"https://api.github.com/users/druminski/events{/privacy}","received_events_url":"https://api.github.com/users/druminski/received_events","type":"User","site_admin":false},"body":"Actually all notifiers already have `threshold` parameter which determines whether message/notification should be ignored. This `showAll` flag is used on a different level - consumer group evaluation which informs notifiers when it is necessary.\r\n\r\nI do agree with you that it should not be enabled when it is not required. Therefore, I added a commit which enables `showAll` flag only when `graphiteNotifier` is enabled.","created_at":"2017-01-04T17:33:36Z","updated_at":"2017-01-04T17:33:36Z","html_url":"https://github.com/linkedin/Burrow/pull/136#discussion_r94627216","pull_request_url":"https://api.github.com/repos/linkedin/Burrow/pulls/136","_links":{"self":{"href":"https://api.github.com/repos/linkedin/Burrow/pulls/comments/94627216"},"html":{"href":"https://github.com/linkedin/Burrow/pull/136#discussion_r94627216"},"pull_request":{"href":"https://api.github.com/repos/linkedin/Burrow/pulls/136"}}},"pull_request":{"url":"https://api.github.com/repos/linkedin/Burrow/pulls/136","id":84180220,"html_url":"https://github.com/linkedin/Burrow/pull/136","diff_url":"https://github.com/linkedin/Burrow/pull/136.diff","patch_url":"https://github.com/linkedin/Burrow/pull/136.patch","issue_url":"https://api.github.com/repos/linkedin/Burrow/issues/136","number":136,"state":"open","locked":false,"title":"Adding graphite notifier","user":{"login":"druminski","id":4473056,"avatar_url":"https://avatars.githubusercontent.com/u/4473056?v=3","gravatar_id":"","url":"https://api.github.com/users/druminski","html_url":"https://github.com/druminski","followers_url":"https://api.github.com/users/druminski/followers","following_url":"https://api.github.com/users/druminski/following{/other_user}","gists_url":"https://api.github.com/users/druminski/gists{/gist_id}","starred_url":"https://api.github.com/users/druminski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/druminski/subscriptions","organizations_url":"https://api.github.com/users/druminski/orgs","repos_url":"https://api.github.com/users/druminski/repos","events_url":"https://api.github.com/users/druminski/events{/privacy}","received_events_url":"https://api.github.com/users/druminski/received_events","type":"User","site_admin":false},"body":"Introducing notifier which allows sending lag metrics to a graphite server. Lag metrics are send in the following naming convention:\n\n`$prefix.$cluster.$topic.$consumersGroup.$partitionIndex.lag`\n\nWe are using this notifier for a few months on a production environment.\n","created_at":"2016-09-06T19:20:00Z","updated_at":"2017-01-04T17:33:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7608d5e9c265eaced16ed6f69454c17907a8b995","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/linkedin/Burrow/pulls/136/commits","review_comments_url":"https://api.github.com/repos/linkedin/Burrow/pulls/136/comments","review_comment_url":"https://api.github.com/repos/linkedin/Burrow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/linkedin/Burrow/issues/136/comments","statuses_url":"https://api.github.com/repos/linkedin/Burrow/statuses/20a2a95cf8cfc79ecf2bdff9e776b2f9519f59a7","head":{"label":"druminski:feature/graphite-notifier","ref":"feature/graphite-notifier","sha":"20a2a95cf8cfc79ecf2bdff9e776b2f9519f59a7","user":{"login":"druminski","id":4473056,"avatar_url":"https://avatars.githubusercontent.com/u/4473056?v=3","gravatar_id":"","url":"https://api.github.com/users/druminski","html_url":"https://github.com/druminski","followers_url":"https://api.github.com/users/druminski/followers","following_url":"https://api.github.com/users/druminski/following{/other_user}","gists_url":"https://api.github.com/users/druminski/gists{/gist_id}","starred_url":"https://api.github.com/users/druminski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/druminski/subscriptions","organizations_url":"https://api.github.com/users/druminski/orgs","repos_url":"https://api.github.com/users/druminski/repos","events_url":"https://api.github.com/users/druminski/events{/privacy}","received_events_url":"https://api.github.com/users/druminski/received_events","type":"User","site_admin":false},"repo":{"id":59652020,"name":"Burrow","full_name":"druminski/Burrow","owner":{"login":"druminski","id":4473056,"avatar_url":"https://avatars.githubusercontent.com/u/4473056?v=3","gravatar_id":"","url":"https://api.github.com/users/druminski","html_url":"https://github.com/druminski","followers_url":"https://api.github.com/users/druminski/followers","following_url":"https://api.github.com/users/druminski/following{/other_user}","gists_url":"https://api.github.com/users/druminski/gists{/gist_id}","starred_url":"https://api.github.com/users/druminski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/druminski/subscriptions","organizations_url":"https://api.github.com/users/druminski/orgs","repos_url":"https://api.github.com/users/druminski/repos","events_url":"https://api.github.com/users/druminski/events{/privacy}","received_events_url":"https://api.github.com/users/druminski/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/druminski/Burrow","description":"Kafka Consumer Lag Checking","fork":true,"url":"https://api.github.com/repos/druminski/Burrow","forks_url":"https://api.github.com/repos/druminski/Burrow/forks","keys_url":"https://api.github.com/repos/druminski/Burrow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/druminski/Burrow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/druminski/Burrow/teams","hooks_url":"https://api.github.com/repos/druminski/Burrow/hooks","issue_events_url":"https://api.github.com/repos/druminski/Burrow/issues/events{/number}","events_url":"https://api.github.com/repos/druminski/Burrow/events","assignees_url":"https://api.github.com/repos/druminski/Burrow/assignees{/user}","branches_url":"https://api.github.com/repos/druminski/Burrow/branches{/branch}","tags_url":"https://api.github.com/repos/druminski/Burrow/tags","blobs_url":"https://api.github.com/repos/druminski/Burrow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/druminski/Burrow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/druminski/Burrow/git/refs{/sha}","trees_url":"https://api.github.com/repos/druminski/Burrow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/druminski/Burrow/statuses/{sha}","languages_url":"https://api.github.com/repos/druminski/Burrow/languages","stargazers_url":"https://api.github.com/repos/druminski/Burrow/stargazers","contributors_url":"https://api.github.com/repos/druminski/Burrow/contributors","subscribers_url":"https://api.github.com/repos/druminski/Burrow/subscribers","subscription_url":"https://api.github.com/repos/druminski/Burrow/subscription","commits_url":"https://api.github.com/repos/druminski/Burrow/commits{/sha}","git_commits_url":"https://api.github.com/repos/druminski/Burrow/git/commits{/sha}","comments_url":"https://api.github.com/repos/druminski/Burrow/comments{/number}","issue_comment_url":"https://api.github.com/repos/druminski/Burrow/issues/comments{/number}","contents_url":"https://api.github.com/repos/druminski/Burrow/contents/{+path}","compare_url":"https://api.github.com/repos/druminski/Burrow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/druminski/Burrow/merges","archive_url":"https://api.github.com/repos/druminski/Burrow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/druminski/Burrow/downloads","issues_url":"https://api.github.com/repos/druminski/Burrow/issues{/number}","pulls_url":"https://api.github.com/repos/druminski/Burrow/pulls{/number}","milestones_url":"https://api.github.com/repos/druminski/Burrow/milestones{/number}","notifications_url":"https://api.github.com/repos/druminski/Burrow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/druminski/Burrow/labels{/name}","releases_url":"https://api.github.com/repos/druminski/Burrow/releases{/id}","deployments_url":"https://api.github.com/repos/druminski/Burrow/deployments","created_at":"2016-05-25T09:55:30Z","updated_at":"2016-05-25T09:55:31Z","pushed_at":"2017-01-04T17:12:44Z","git_url":"git://github.com/druminski/Burrow.git","ssh_url":"git@github.com:druminski/Burrow.git","clone_url":"https://github.com/druminski/Burrow.git","svn_url":"https://github.com/druminski/Burrow","homepage":"","size":187,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"linkedin:master","ref":"master","sha":"1e4b0d844c9fd4b2864f1874e945f02178aa7898","user":{"login":"linkedin","id":357098,"avatar_url":"https://avatars.githubusercontent.com/u/357098?v=3","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"repo":{"id":36699285,"name":"Burrow","full_name":"linkedin/Burrow","owner":{"login":"linkedin","id":357098,"avatar_url":"https://avatars.githubusercontent.com/u/357098?v=3","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/linkedin/Burrow","description":"Kafka Consumer Lag Checking","fork":false,"url":"https://api.github.com/repos/linkedin/Burrow","forks_url":"https://api.github.com/repos/linkedin/Burrow/forks","keys_url":"https://api.github.com/repos/linkedin/Burrow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linkedin/Burrow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linkedin/Burrow/teams","hooks_url":"https://api.github.com/repos/linkedin/Burrow/hooks","issue_events_url":"https://api.github.com/repos/linkedin/Burrow/issues/events{/number}","events_url":"https://api.github.com/repos/linkedin/Burrow/events","assignees_url":"https://api.github.com/repos/linkedin/Burrow/assignees{/user}","branches_url":"https://api.github.com/repos/linkedin/Burrow/branches{/branch}","tags_url":"https://api.github.com/repos/linkedin/Burrow/tags","blobs_url":"https://api.github.com/repos/linkedin/Burrow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linkedin/Burrow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linkedin/Burrow/git/refs{/sha}","trees_url":"https://api.github.com/repos/linkedin/Burrow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linkedin/Burrow/statuses/{sha}","languages_url":"https://api.github.com/repos/linkedin/Burrow/languages","stargazers_url":"https://api.github.com/repos/linkedin/Burrow/stargazers","contributors_url":"https://api.github.com/repos/linkedin/Burrow/contributors","subscribers_url":"https://api.github.com/repos/linkedin/Burrow/subscribers","subscription_url":"https://api.github.com/repos/linkedin/Burrow/subscription","commits_url":"https://api.github.com/repos/linkedin/Burrow/commits{/sha}","git_commits_url":"https://api.github.com/repos/linkedin/Burrow/git/commits{/sha}","comments_url":"https://api.github.com/repos/linkedin/Burrow/comments{/number}","issue_comment_url":"https://api.github.com/repos/linkedin/Burrow/issues/comments{/number}","contents_url":"https://api.github.com/repos/linkedin/Burrow/contents/{+path}","compare_url":"https://api.github.com/repos/linkedin/Burrow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linkedin/Burrow/merges","archive_url":"https://api.github.com/repos/linkedin/Burrow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linkedin/Burrow/downloads","issues_url":"https://api.github.com/repos/linkedin/Burrow/issues{/number}","pulls_url":"https://api.github.com/repos/linkedin/Burrow/pulls{/number}","milestones_url":"https://api.github.com/repos/linkedin/Burrow/milestones{/number}","notifications_url":"https://api.github.com/repos/linkedin/Burrow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linkedin/Burrow/labels{/name}","releases_url":"https://api.github.com/repos/linkedin/Burrow/releases{/id}","deployments_url":"https://api.github.com/repos/linkedin/Burrow/deployments","created_at":"2015-06-02T01:15:25Z","updated_at":"2017-01-04T08:57:32Z","pushed_at":"2017-01-04T17:12:37Z","git_url":"git://github.com/linkedin/Burrow.git","ssh_url":"git@github.com:linkedin/Burrow.git","clone_url":"https://github.com/linkedin/Burrow.git","svn_url":"https://github.com/linkedin/Burrow","homepage":"","size":270,"stargazers_count":596,"watchers_count":596,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":165,"mirror_url":null,"open_issues_count":41,"forks":165,"open_issues":41,"watchers":596,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/linkedin/Burrow/pulls/136"},"html":{"href":"https://github.com/linkedin/Burrow/pull/136"},"issue":{"href":"https://api.github.com/repos/linkedin/Burrow/issues/136"},"comments":{"href":"https://api.github.com/repos/linkedin/Burrow/issues/136/comments"},"review_comments":{"href":"https://api.github.com/repos/linkedin/Burrow/pulls/136/comments"},"review_comment":{"href":"https://api.github.com/repos/linkedin/Burrow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/linkedin/Burrow/pulls/136/commits"},"statuses":{"href":"https://api.github.com/repos/linkedin/Burrow/statuses/20a2a95cf8cfc79ecf2bdff9e776b2f9519f59a7"}}}}
{"actor":{"display_login":"druminski"}}