{"action":"created","issue":{"url":"https://api.github.com/repos/grommet/grommet/issues/1595","repository_url":"https://api.github.com/repos/grommet/grommet","labels_url":"https://api.github.com/repos/grommet/grommet/issues/1595/labels{/name}","comments_url":"https://api.github.com/repos/grommet/grommet/issues/1595/comments","events_url":"https://api.github.com/repos/grommet/grommet/issues/1595/events","html_url":"https://github.com/grommet/grommet/issues/1595","id":255207973,"number":1595,"title":"Proposal: Add disabled prop for button for Grommet 2","user":{"login":"linde12","id":3235069,"avatar_url":"https://avatars2.githubusercontent.com/u/3235069?v=4","gravatar_id":"","url":"https://api.github.com/users/linde12","html_url":"https://github.com/linde12","followers_url":"https://api.github.com/users/linde12/followers","following_url":"https://api.github.com/users/linde12/following{/other_user}","gists_url":"https://api.github.com/users/linde12/gists{/gist_id}","starred_url":"https://api.github.com/users/linde12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linde12/subscriptions","organizations_url":"https://api.github.com/users/linde12/orgs","repos_url":"https://api.github.com/users/linde12/repos","events_url":"https://api.github.com/users/linde12/events{/privacy}","received_events_url":"https://api.github.com/users/linde12/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-09-05T09:04:46Z","updated_at":"2017-09-06T15:43:01Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"I'm proposing to add a separate prop for enabling/disabling a button. \r\n\r\nIt just seems more intuitive to have `<Button label='Submit' disabled={isSubmitting} />` rather than `<Button label='Submit' onClick={isSubmitting ? null : this.handleClick} />`\r\n\r\nThere is also the use case where a HOC always injects a `onClick` value but we still want the button to be disabled.\r\n\r\nE.g. a form library which always injects a function to the submit button of the form. I might want to disable the submit button until some requirements are met."},"comment":{"url":"https://api.github.com/repos/grommet/grommet/issues/comments/327525540","html_url":"https://github.com/grommet/grommet/issues/1595#issuecomment-327525540","issue_url":"https://api.github.com/repos/grommet/grommet/issues/1595","id":327525540,"user":{"login":"karatechops","id":5983843,"avatar_url":"https://avatars1.githubusercontent.com/u/5983843?v=4","gravatar_id":"","url":"https://api.github.com/users/karatechops","html_url":"https://github.com/karatechops","followers_url":"https://api.github.com/users/karatechops/followers","following_url":"https://api.github.com/users/karatechops/following{/other_user}","gists_url":"https://api.github.com/users/karatechops/gists{/gist_id}","starred_url":"https://api.github.com/users/karatechops/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karatechops/subscriptions","organizations_url":"https://api.github.com/users/karatechops/orgs","repos_url":"https://api.github.com/users/karatechops/repos","events_url":"https://api.github.com/users/karatechops/events{/privacy}","received_events_url":"https://api.github.com/users/karatechops/received_events","type":"User","site_admin":false},"created_at":"2017-09-06T15:43:01Z","updated_at":"2017-09-06T15:43:01Z","author_association":"CONTRIBUTOR","body":"This makes sense, the disabled property should propagate to the DOM as an HTML button would."}}
{"actor":{"display_login":"karatechops"}}