{"action":"opened","number":3426,"pull_request":{"url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/3426","id":153412355,"html_url":"https://github.com/OfficeDev/office-ui-fabric-react/pull/3426","diff_url":"https://github.com/OfficeDev/office-ui-fabric-react/pull/3426.diff","patch_url":"https://github.com/OfficeDev/office-ui-fabric-react/pull/3426.patch","issue_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/3426","number":3426,"state":"open","locked":false,"title":"Contextual menu up/down arrow key behavior - preventing defaults","user":{"login":"whykushal93","id":2162858,"avatar_url":"https://avatars2.githubusercontent.com/u/2162858?v=4","gravatar_id":"","url":"https://api.github.com/users/whykushal93","html_url":"https://github.com/whykushal93","followers_url":"https://api.github.com/users/whykushal93/followers","following_url":"https://api.github.com/users/whykushal93/following{/other_user}","gists_url":"https://api.github.com/users/whykushal93/gists{/gist_id}","starred_url":"https://api.github.com/users/whykushal93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whykushal93/subscriptions","organizations_url":"https://api.github.com/users/whykushal93/orgs","repos_url":"https://api.github.com/users/whykushal93/repos","events_url":"https://api.github.com/users/whykushal93/events{/privacy}","received_events_url":"https://api.github.com/users/whykushal93/received_events","type":"User","site_admin":false},"body":"#### Pull request checklist\r\n\r\n- [ ] Addresses an existing issue: Fixes #0000\r\n- [x] Include a change request file using `$ npm run change`\r\n\r\n#### Description of changes\r\nContextual menus were allowing for browser default behavior to happen on up/down arrow keys after \r\nfocusing on the last/first element. This did not really affect normal contextual menus, but resulted in content jumps for contextual menus with a scroll bar.\r\n\r\nThe change fixes this by preventing browser default behavior when we have a element that we want to shift focus to.\r\n\r\n#### Behavior before (Only user input after opening the contextual menu = Down Arrow):\r\nNotice that even though the focus is set correctly, the scroll does not look correct\r\n![contextualmenubefore](https://user-images.githubusercontent.com/2162858/32972336-c0ba093e-cba6-11e7-87e8-bc01d78070f8.gif)\r\n\r\n#### Behavior after (Only user input after opening the contextual menu = Down Arrow):\r\n![contextualmenuafter](https://user-images.githubusercontent.com/2162858/32972342-c957aa10-cba6-11e7-89b8-1e07852026ed.gif)\r\n\r\n\r\n#### Focus areas to test\r\nI tested to see that components which currently use the contextual menu do not exhibit weird behavior as a result of this change. \r\n","created_at":"2017-11-17T22:55:47Z","updated_at":"2017-11-17T22:55:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/3426/commits","review_comments_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/3426/comments","review_comment_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/3426/comments","statuses_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/statuses/5397c94683a3f96796e990b77192597880a3a745","head":{"label":"whykushal93:contextualMenuKeyBoarding","ref":"contextualMenuKeyBoarding","sha":"5397c94683a3f96796e990b77192597880a3a745","user":{"login":"whykushal93","id":2162858,"avatar_url":"https://avatars2.githubusercontent.com/u/2162858?v=4","gravatar_id":"","url":"https://api.github.com/users/whykushal93","html_url":"https://github.com/whykushal93","followers_url":"https://api.github.com/users/whykushal93/followers","following_url":"https://api.github.com/users/whykushal93/following{/other_user}","gists_url":"https://api.github.com/users/whykushal93/gists{/gist_id}","starred_url":"https://api.github.com/users/whykushal93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whykushal93/subscriptions","organizations_url":"https://api.github.com/users/whykushal93/orgs","repos_url":"https://api.github.com/users/whykushal93/repos","events_url":"https://api.github.com/users/whykushal93/events{/privacy}","received_events_url":"https://api.github.com/users/whykushal93/received_events","type":"User","site_admin":false},"repo":{"id":96364149,"name":"office-ui-fabric-react","full_name":"whykushal93/office-ui-fabric-react","owner":{"login":"whykushal93","id":2162858,"avatar_url":"https://avatars2.githubusercontent.com/u/2162858?v=4","gravatar_id":"","url":"https://api.github.com/users/whykushal93","html_url":"https://github.com/whykushal93","followers_url":"https://api.github.com/users/whykushal93/followers","following_url":"https://api.github.com/users/whykushal93/following{/other_user}","gists_url":"https://api.github.com/users/whykushal93/gists{/gist_id}","starred_url":"https://api.github.com/users/whykushal93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whykushal93/subscriptions","organizations_url":"https://api.github.com/users/whykushal93/orgs","repos_url":"https://api.github.com/users/whykushal93/repos","events_url":"https://api.github.com/users/whykushal93/events{/privacy}","received_events_url":"https://api.github.com/users/whykushal93/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/whykushal93/office-ui-fabric-react","description":"React components for building experiences for Office and Office 365.","fork":true,"url":"https://api.github.com/repos/whykushal93/office-ui-fabric-react","forks_url":"https://api.github.com/repos/whykushal93/office-ui-fabric-react/forks","keys_url":"https://api.github.com/repos/whykushal93/office-ui-fabric-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/whykushal93/office-ui-fabric-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/whykushal93/office-ui-fabric-react/teams","hooks_url":"https://api.github.com/repos/whykushal93/office-ui-fabric-react/hooks","issue_events_url":"https://api.github.com/repos/whykushal93/office-ui-fabric-react/issues/events{/number}","events_url":"https://api.github.com/repos/whykushal93/office-ui-fabric-react/events","assignees_url":"https://api.github.com/repos/whykushal93/office-ui-fabric-react/assignees{/user}","branches_url":"https://api.github.com/repos/whykushal93/office-ui-fabric-react/branches{/branch}","tags_url":"https://api.github.com/repos/whykushal93/office-ui-fabric-react/tags","blobs_url":"https://api.github.com/repos/whykushal93/office-ui-fabric-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/whykushal93/office-ui-fabric-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/whykushal93/office-ui-fabric-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/whykushal93/office-ui-fabric-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/whykushal93/office-ui-fabric-react/statuses/{sha}","languages_url":"https://api.github.com/repos/whykushal93/office-ui-fabric-react/languages","stargazers_url":"https://api.github.com/repos/whykushal93/office-ui-fabric-react/stargazers","contributors_url":"https://api.github.com/repos/whykushal93/office-ui-fabric-react/contributors","subscribers_url":"https://api.github.com/repos/whykushal93/office-ui-fabric-react/subscribers","subscription_url":"https://api.github.com/repos/whykushal93/office-ui-fabric-react/subscription","commits_url":"https://api.github.com/repos/whykushal93/office-ui-fabric-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/whykushal93/office-ui-fabric-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/whykushal93/office-ui-fabric-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/whykushal93/office-ui-fabric-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/whykushal93/office-ui-fabric-react/contents/{+path}","compare_url":"https://api.github.com/repos/whykushal93/office-ui-fabric-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/whykushal93/office-ui-fabric-react/merges","archive_url":"https://api.github.com/repos/whykushal93/office-ui-fabric-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/whykushal93/office-ui-fabric-react/downloads","issues_url":"https://api.github.com/repos/whykushal93/office-ui-fabric-react/issues{/number}","pulls_url":"https://api.github.com/repos/whykushal93/office-ui-fabric-react/pulls{/number}","milestones_url":"https://api.github.com/repos/whykushal93/office-ui-fabric-react/milestones{/number}","notifications_url":"https://api.github.com/repos/whykushal93/office-ui-fabric-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/whykushal93/office-ui-fabric-react/labels{/name}","releases_url":"https://api.github.com/repos/whykushal93/office-ui-fabric-react/releases{/id}","deployments_url":"https://api.github.com/repos/whykushal93/office-ui-fabric-react/deployments","created_at":"2017-07-05T21:52:02Z","updated_at":"2017-07-05T21:52:06Z","pushed_at":"2017-11-17T22:47:36Z","git_url":"git://github.com/whykushal93/office-ui-fabric-react.git","ssh_url":"git@github.com:whykushal93/office-ui-fabric-react.git","clone_url":"https://github.com/whykushal93/office-ui-fabric-react.git","svn_url":"https://github.com/whykushal93/office-ui-fabric-react","homepage":"http://dev.office.com/fabric#/components","size":17585,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OfficeDev:master","ref":"master","sha":"1ea8504482adb1570bc6e6e96d1a33d90fbb8509","user":{"login":"OfficeDev","id":6789362,"avatar_url":"https://avatars2.githubusercontent.com/u/6789362?v=4","gravatar_id":"","url":"https://api.github.com/users/OfficeDev","html_url":"https://github.com/OfficeDev","followers_url":"https://api.github.com/users/OfficeDev/followers","following_url":"https://api.github.com/users/OfficeDev/following{/other_user}","gists_url":"https://api.github.com/users/OfficeDev/gists{/gist_id}","starred_url":"https://api.github.com/users/OfficeDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OfficeDev/subscriptions","organizations_url":"https://api.github.com/users/OfficeDev/orgs","repos_url":"https://api.github.com/users/OfficeDev/repos","events_url":"https://api.github.com/users/OfficeDev/events{/privacy}","received_events_url":"https://api.github.com/users/OfficeDev/received_events","type":"Organization","site_admin":false},"repo":{"id":60537144,"name":"office-ui-fabric-react","full_name":"OfficeDev/office-ui-fabric-react","owner":{"login":"OfficeDev","id":6789362,"avatar_url":"https://avatars2.githubusercontent.com/u/6789362?v=4","gravatar_id":"","url":"https://api.github.com/users/OfficeDev","html_url":"https://github.com/OfficeDev","followers_url":"https://api.github.com/users/OfficeDev/followers","following_url":"https://api.github.com/users/OfficeDev/following{/other_user}","gists_url":"https://api.github.com/users/OfficeDev/gists{/gist_id}","starred_url":"https://api.github.com/users/OfficeDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OfficeDev/subscriptions","organizations_url":"https://api.github.com/users/OfficeDev/orgs","repos_url":"https://api.github.com/users/OfficeDev/repos","events_url":"https://api.github.com/users/OfficeDev/events{/privacy}","received_events_url":"https://api.github.com/users/OfficeDev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OfficeDev/office-ui-fabric-react","description":"React components for building experiences for Office and Office 365.","fork":false,"url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react","forks_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/forks","keys_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/teams","hooks_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/hooks","issue_events_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/events{/number}","events_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/events","assignees_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/assignees{/user}","branches_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/branches{/branch}","tags_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/tags","blobs_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/statuses/{sha}","languages_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/languages","stargazers_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/stargazers","contributors_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/contributors","subscribers_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/subscribers","subscription_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/subscription","commits_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/contents/{+path}","compare_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/merges","archive_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/downloads","issues_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues{/number}","pulls_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls{/number}","milestones_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/milestones{/number}","notifications_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/labels{/name}","releases_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/releases{/id}","deployments_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/deployments","created_at":"2016-06-06T15:03:44Z","updated_at":"2017-11-17T21:48:23Z","pushed_at":"2017-11-17T22:21:33Z","git_url":"git://github.com/OfficeDev/office-ui-fabric-react.git","ssh_url":"git@github.com:OfficeDev/office-ui-fabric-react.git","clone_url":"https://github.com/OfficeDev/office-ui-fabric-react.git","svn_url":"https://github.com/OfficeDev/office-ui-fabric-react","homepage":"https://developer.microsoft.com/en-us/fabric#/components","size":20397,"stargazers_count":1828,"watchers_count":1828,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":387,"mirror_url":null,"archived":false,"open_issues_count":402,"forks":387,"open_issues":402,"watchers":1828,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/3426"},"html":{"href":"https://github.com/OfficeDev/office-ui-fabric-react/pull/3426"},"issue":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/3426"},"comments":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/3426/comments"},"review_comments":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/3426/comments"},"review_comment":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/3426/commits"},"statuses":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/statuses/5397c94683a3f96796e990b77192597880a3a745"}},"author_association":"COLLABORATOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":3,"additions":80,"deletions":1,"changed_files":4}}
{"actor":{"display_login":"whykushal93"}}