{"action":"created","comment":{"url":"https://api.github.com/repos/apache/camel/pulls/comments/122404799","pull_request_review_id":44517555,"id":122404799,"diff_hunk":"@@ -41,19 +42,18 @@ public HazelcastTopicProducer(HazelcastInstance hazelcastInstance, HazelcastDefa\n     }\n \n     public void process(Exchange exchange) throws Exception {\n-        final int operation = lookupOperationNumber(exchange);\n+        final HazelcastOperation operation = lookupOperation(exchange);\n \n-        switch (operation) {\n-        case -1:\n-            // default operation to publish\n-        case HazelcastConstants.PUBLISH_OPERATION:\n+        switch ((operation != null) ? operation : HazelcastOperation.PUBLISH) {","path":"components/camel-hazelcast/src/main/java/org/apache/camel/component/hazelcast/topic/HazelcastTopicProducer.java","position":19,"original_position":19,"commit_id":"09aa0bd6ffc42c394f7bf4fa34f304a7665a0cd2","original_commit_id":"09aa0bd6ffc42c394f7bf4fa34f304a7665a0cd2","user":{"login":"lburgazzoli","id":1868933,"avatar_url":"https://avatars2.githubusercontent.com/u/1868933?v=3","gravatar_id":"","url":"https://api.github.com/users/lburgazzoli","html_url":"https://github.com/lburgazzoli","followers_url":"https://api.github.com/users/lburgazzoli/followers","following_url":"https://api.github.com/users/lburgazzoli/following{/other_user}","gists_url":"https://api.github.com/users/lburgazzoli/gists{/gist_id}","starred_url":"https://api.github.com/users/lburgazzoli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lburgazzoli/subscriptions","organizations_url":"https://api.github.com/users/lburgazzoli/orgs","repos_url":"https://api.github.com/users/lburgazzoli/repos","events_url":"https://api.github.com/users/lburgazzoli/events{/privacy}","received_events_url":"https://api.github.com/users/lburgazzoli/received_events","type":"User","site_admin":false},"body":"It would be nice if the default operation is set on the endpoint so it can be configured and lookupOperation would always return a non null value","created_at":"2017-06-16T09:40:50Z","updated_at":"2017-06-16T09:40:50Z","html_url":"https://github.com/apache/camel/pull/1770#discussion_r122404799","pull_request_url":"https://api.github.com/repos/apache/camel/pulls/1770","_links":{"self":{"href":"https://api.github.com/repos/apache/camel/pulls/comments/122404799"},"html":{"href":"https://github.com/apache/camel/pull/1770#discussion_r122404799"},"pull_request":{"href":"https://api.github.com/repos/apache/camel/pulls/1770"}}},"pull_request":{"url":"https://api.github.com/repos/apache/camel/pulls/1770","id":125993767,"html_url":"https://github.com/apache/camel/pull/1770","diff_url":"https://github.com/apache/camel/pull/1770.diff","patch_url":"https://github.com/apache/camel/pull/1770.patch","issue_url":"https://api.github.com/repos/apache/camel/issues/1770","number":1770,"state":"open","locked":false,"title":"CAMEL-11244: camel-hazelcast: use string/enum instead of numeric operation type","user":{"login":"tlehoux","id":2562582,"avatar_url":"https://avatars0.githubusercontent.com/u/2562582?v=3","gravatar_id":"","url":"https://api.github.com/users/tlehoux","html_url":"https://github.com/tlehoux","followers_url":"https://api.github.com/users/tlehoux/followers","following_url":"https://api.github.com/users/tlehoux/following{/other_user}","gists_url":"https://api.github.com/users/tlehoux/gists{/gist_id}","starred_url":"https://api.github.com/users/tlehoux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tlehoux/subscriptions","organizations_url":"https://api.github.com/users/tlehoux/orgs","repos_url":"https://api.github.com/users/tlehoux/repos","events_url":"https://api.github.com/users/tlehoux/events{/privacy}","received_events_url":"https://api.github.com/users/tlehoux/received_events","type":"User","site_admin":false},"body":"I've kept operations current names in order to have backward compatibility especially with Spring/XML DSL. However, entries in HazelcastConstants have been declared as deprecated.\r\n\r\n","created_at":"2017-06-16T09:27:33Z","updated_at":"2017-06-16T09:40:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e4efd9d44d33bd616a8e695a721b30c939484f60","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/camel/pulls/1770/commits","review_comments_url":"https://api.github.com/repos/apache/camel/pulls/1770/comments","review_comment_url":"https://api.github.com/repos/apache/camel/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/camel/issues/1770/comments","statuses_url":"https://api.github.com/repos/apache/camel/statuses/09aa0bd6ffc42c394f7bf4fa34f304a7665a0cd2","head":{"label":"tlehoux:master","ref":"master","sha":"09aa0bd6ffc42c394f7bf4fa34f304a7665a0cd2","user":{"login":"tlehoux","id":2562582,"avatar_url":"https://avatars0.githubusercontent.com/u/2562582?v=3","gravatar_id":"","url":"https://api.github.com/users/tlehoux","html_url":"https://github.com/tlehoux","followers_url":"https://api.github.com/users/tlehoux/followers","following_url":"https://api.github.com/users/tlehoux/following{/other_user}","gists_url":"https://api.github.com/users/tlehoux/gists{/gist_id}","starred_url":"https://api.github.com/users/tlehoux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tlehoux/subscriptions","organizations_url":"https://api.github.com/users/tlehoux/orgs","repos_url":"https://api.github.com/users/tlehoux/repos","events_url":"https://api.github.com/users/tlehoux/events{/privacy}","received_events_url":"https://api.github.com/users/tlehoux/received_events","type":"User","site_admin":false},"repo":{"id":85087058,"name":"camel","full_name":"tlehoux/camel","owner":{"login":"tlehoux","id":2562582,"avatar_url":"https://avatars0.githubusercontent.com/u/2562582?v=3","gravatar_id":"","url":"https://api.github.com/users/tlehoux","html_url":"https://github.com/tlehoux","followers_url":"https://api.github.com/users/tlehoux/followers","following_url":"https://api.github.com/users/tlehoux/following{/other_user}","gists_url":"https://api.github.com/users/tlehoux/gists{/gist_id}","starred_url":"https://api.github.com/users/tlehoux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tlehoux/subscriptions","organizations_url":"https://api.github.com/users/tlehoux/orgs","repos_url":"https://api.github.com/users/tlehoux/repos","events_url":"https://api.github.com/users/tlehoux/events{/privacy}","received_events_url":"https://api.github.com/users/tlehoux/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tlehoux/camel","description":"Mirror of Apache Camel","fork":true,"url":"https://api.github.com/repos/tlehoux/camel","forks_url":"https://api.github.com/repos/tlehoux/camel/forks","keys_url":"https://api.github.com/repos/tlehoux/camel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tlehoux/camel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tlehoux/camel/teams","hooks_url":"https://api.github.com/repos/tlehoux/camel/hooks","issue_events_url":"https://api.github.com/repos/tlehoux/camel/issues/events{/number}","events_url":"https://api.github.com/repos/tlehoux/camel/events","assignees_url":"https://api.github.com/repos/tlehoux/camel/assignees{/user}","branches_url":"https://api.github.com/repos/tlehoux/camel/branches{/branch}","tags_url":"https://api.github.com/repos/tlehoux/camel/tags","blobs_url":"https://api.github.com/repos/tlehoux/camel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tlehoux/camel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tlehoux/camel/git/refs{/sha}","trees_url":"https://api.github.com/repos/tlehoux/camel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tlehoux/camel/statuses/{sha}","languages_url":"https://api.github.com/repos/tlehoux/camel/languages","stargazers_url":"https://api.github.com/repos/tlehoux/camel/stargazers","contributors_url":"https://api.github.com/repos/tlehoux/camel/contributors","subscribers_url":"https://api.github.com/repos/tlehoux/camel/subscribers","subscription_url":"https://api.github.com/repos/tlehoux/camel/subscription","commits_url":"https://api.github.com/repos/tlehoux/camel/commits{/sha}","git_commits_url":"https://api.github.com/repos/tlehoux/camel/git/commits{/sha}","comments_url":"https://api.github.com/repos/tlehoux/camel/comments{/number}","issue_comment_url":"https://api.github.com/repos/tlehoux/camel/issues/comments{/number}","contents_url":"https://api.github.com/repos/tlehoux/camel/contents/{+path}","compare_url":"https://api.github.com/repos/tlehoux/camel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tlehoux/camel/merges","archive_url":"https://api.github.com/repos/tlehoux/camel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tlehoux/camel/downloads","issues_url":"https://api.github.com/repos/tlehoux/camel/issues{/number}","pulls_url":"https://api.github.com/repos/tlehoux/camel/pulls{/number}","milestones_url":"https://api.github.com/repos/tlehoux/camel/milestones{/number}","notifications_url":"https://api.github.com/repos/tlehoux/camel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tlehoux/camel/labels{/name}","releases_url":"https://api.github.com/repos/tlehoux/camel/releases{/id}","deployments_url":"https://api.github.com/repos/tlehoux/camel/deployments","created_at":"2017-03-15T15:10:09Z","updated_at":"2017-03-15T15:11:03Z","pushed_at":"2017-06-16T09:18:05Z","git_url":"git://github.com/tlehoux/camel.git","ssh_url":"git@github.com:tlehoux/camel.git","clone_url":"https://github.com/tlehoux/camel.git","svn_url":"https://github.com/tlehoux/camel","homepage":null,"size":173906,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"a9b9f3104d424537e87bef33cad7dbf6951bb2cb","user":{"login":"apache","id":47359,"avatar_url":"https://avatars3.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":206317,"name":"camel","full_name":"apache/camel","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars3.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/camel","description":"Mirror of Apache Camel","fork":false,"url":"https://api.github.com/repos/apache/camel","forks_url":"https://api.github.com/repos/apache/camel/forks","keys_url":"https://api.github.com/repos/apache/camel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/camel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/camel/teams","hooks_url":"https://api.github.com/repos/apache/camel/hooks","issue_events_url":"https://api.github.com/repos/apache/camel/issues/events{/number}","events_url":"https://api.github.com/repos/apache/camel/events","assignees_url":"https://api.github.com/repos/apache/camel/assignees{/user}","branches_url":"https://api.github.com/repos/apache/camel/branches{/branch}","tags_url":"https://api.github.com/repos/apache/camel/tags","blobs_url":"https://api.github.com/repos/apache/camel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/camel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/camel/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/camel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/camel/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/camel/languages","stargazers_url":"https://api.github.com/repos/apache/camel/stargazers","contributors_url":"https://api.github.com/repos/apache/camel/contributors","subscribers_url":"https://api.github.com/repos/apache/camel/subscribers","subscription_url":"https://api.github.com/repos/apache/camel/subscription","commits_url":"https://api.github.com/repos/apache/camel/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/camel/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/camel/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/camel/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/camel/contents/{+path}","compare_url":"https://api.github.com/repos/apache/camel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/camel/merges","archive_url":"https://api.github.com/repos/apache/camel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/camel/downloads","issues_url":"https://api.github.com/repos/apache/camel/issues{/number}","pulls_url":"https://api.github.com/repos/apache/camel/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/camel/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/camel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/camel/labels{/name}","releases_url":"https://api.github.com/repos/apache/camel/releases{/id}","deployments_url":"https://api.github.com/repos/apache/camel/deployments","created_at":"2009-05-21T00:25:36Z","updated_at":"2017-06-16T06:22:11Z","pushed_at":"2017-06-16T09:27:33Z","git_url":"git://github.com/apache/camel.git","ssh_url":"git@github.com:apache/camel.git","clone_url":"https://github.com/apache/camel.git","svn_url":"https://github.com/apache/camel","homepage":null,"size":177464,"stargazers_count":1330,"watchers_count":1330,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1923,"mirror_url":"git://git.apache.org/camel.git","open_issues_count":18,"forks":1923,"open_issues":18,"watchers":1330,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/camel/pulls/1770"},"html":{"href":"https://github.com/apache/camel/pull/1770"},"issue":{"href":"https://api.github.com/repos/apache/camel/issues/1770"},"comments":{"href":"https://api.github.com/repos/apache/camel/issues/1770/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/camel/pulls/1770/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/camel/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/camel/pulls/1770/commits"},"statuses":{"href":"https://api.github.com/repos/apache/camel/statuses/09aa0bd6ffc42c394f7bf4fa34f304a7665a0cd2"}}}}
{"actor":{"display_login":"lburgazzoli"}}