{"action":"created","comment":{"url":"https://api.github.com/repos/apache/nifi/pulls/comments/140365671","pull_request_review_id":64430132,"id":140365671,"diff_hunk":"@@ -94,6 +97,29 @@\n             .addValidator(StandardValidators.NON_EMPTY_VALIDATOR)\n             .build();\n \n+    protected static final PropertyDescriptor FLUSH_MODE = new PropertyDescriptor.Builder()\n+            .name(\"Flush Mode\")\n+            .description(\"Set the new flush mode for a kudu session\\n\" +\n+                    \"AUTO_FLUSH_SYNC: the call returns when the operation is persisted, else it throws an exception.\\n\" +\n+                    \"AUTO_FLUSH_BACKGROUND: the call returns when the operation has been added to the buffer. This call should normally perform only fast in-memory\" +\n+                    \" operations but it may have to wait when the buffer is full and there's another buffer being flushed.\\n\" +\n+                    \"MANUAL_FLUSH: the call returns when the operation has been added to the buffer, else it throws a KuduException if the buffer is full.\")\n+            .allowableValues(SessionConfiguration.FlushMode.values())\n+            .defaultValue(SessionConfiguration.FlushMode.AUTO_FLUSH_BACKGROUND.toString())\n+            .required(true)\n+            .build();\n+\n+    protected static final PropertyDescriptor BATCH_SIZE = new PropertyDescriptor.Builder()\n+            .name(\"Batch Size\")\n+            .description(\"Set the number of operations that can be buffered, between 2 - 100000. \" +\n+                    \"Depend on your memory size, and data size per row set an appropriate batch size. \" +\n+                    \"Gradually increase this number to find out your best one for best performance\")\n+            .defaultValue(\"100\")","path":"nifi-nar-bundles/nifi-kudu-bundle/nifi-kudu-processors/src/main/java/org/apache/nifi/processors/kudu/AbstractKudu.java","position":45,"original_position":45,"commit_id":"bb7fb332e50d21c58fa85d6c9dc1248a18693df5","original_commit_id":"bb7fb332e50d21c58fa85d6c9dc1248a18693df5","user":{"login":"cammachusa","id":28015823,"avatar_url":"https://avatars1.githubusercontent.com/u/28015823?v=4","gravatar_id":"","url":"https://api.github.com/users/cammachusa","html_url":"https://github.com/cammachusa","followers_url":"https://api.github.com/users/cammachusa/followers","following_url":"https://api.github.com/users/cammachusa/following{/other_user}","gists_url":"https://api.github.com/users/cammachusa/gists{/gist_id}","starred_url":"https://api.github.com/users/cammachusa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cammachusa/subscriptions","organizations_url":"https://api.github.com/users/cammachusa/orgs","repos_url":"https://api.github.com/users/cammachusa/repos","events_url":"https://api.github.com/users/cammachusa/events{/privacy}","received_events_url":"https://api.github.com/users/cammachusa/received_events","type":"User","site_admin":false},"body":"Like, I made in note in the description. It's depend on their memory size, and data row being inserted, and also their cluster size. Setting the buffer size too big won't help, and too small won't help either. And at noted, developer got to find out this number from his environment. A lot of people hit performance peak at 50 with single machine Kudu's cluster. My colleague hit performance peak at 3500 with 6 nodes cluster (10 CPU, 64 GB Memory each). I randomly pick 100 as I saw it from other Put-xxx processor, but I don't want to put 1000 since most developers test it with single machine, and would leave this default value.","created_at":"2017-09-21T21:36:29Z","updated_at":"2017-09-21T21:36:29Z","html_url":"https://github.com/apache/nifi/pull/2160#discussion_r140365671","pull_request_url":"https://api.github.com/repos/apache/nifi/pulls/2160","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/nifi/pulls/comments/140365671"},"html":{"href":"https://github.com/apache/nifi/pull/2160#discussion_r140365671"},"pull_request":{"href":"https://api.github.com/repos/apache/nifi/pulls/2160"}},"in_reply_to_id":140353856},"pull_request":{"url":"https://api.github.com/repos/apache/nifi/pulls/2160","id":141663734,"html_url":"https://github.com/apache/nifi/pull/2160","diff_url":"https://github.com/apache/nifi/pull/2160.diff","patch_url":"https://github.com/apache/nifi/pull/2160.patch","issue_url":"https://api.github.com/repos/apache/nifi/issues/2160","number":2160,"state":"open","locked":false,"title":"[NiFi-4384] - Enhance PutKudu processor to support batch insert","user":{"login":"cammachusa","id":28015823,"avatar_url":"https://avatars1.githubusercontent.com/u/28015823?v=4","gravatar_id":"","url":"https://api.github.com/users/cammachusa","html_url":"https://github.com/cammachusa","followers_url":"https://api.github.com/users/cammachusa/followers","following_url":"https://api.github.com/users/cammachusa/following{/other_user}","gists_url":"https://api.github.com/users/cammachusa/gists{/gist_id}","starred_url":"https://api.github.com/users/cammachusa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cammachusa/subscriptions","organizations_url":"https://api.github.com/users/cammachusa/orgs","repos_url":"https://api.github.com/users/cammachusa/repos","events_url":"https://api.github.com/users/cammachusa/events{/privacy}","received_events_url":"https://api.github.com/users/cammachusa/received_events","type":"User","site_admin":false},"body":"Thank you for submitting a contribution to Apache NiFi.\r\n\r\nIn order to streamline the review of the contribution we ask you\r\nto ensure the following steps have been taken:\r\n\r\n### For all changes:\r\n- [ ] Is there a JIRA ticket associated with this PR? Is it referenced \r\n     in the commit message?\r\n\r\n- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen \"-\" character.\r\n\r\n- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?\r\n\r\n- [ ] Is your initial contribution a single, squashed commit?\r\n\r\n### For code changes:\r\n- [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?\r\n- [ ] Have you written or updated unit tests to verify your changes?\r\n- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? \r\n- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?\r\n- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?\r\n- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?\r\n\r\n### For documentation related changes:\r\n- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?\r\n\r\n### Note:\r\nPlease ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.\r\n","created_at":"2017-09-18T17:47:57Z","updated_at":"2017-09-21T21:36:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f20921952238a83d5d9db7df5bf3c952a430cabb","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/nifi/pulls/2160/commits","review_comments_url":"https://api.github.com/repos/apache/nifi/pulls/2160/comments","review_comment_url":"https://api.github.com/repos/apache/nifi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/nifi/issues/2160/comments","statuses_url":"https://api.github.com/repos/apache/nifi/statuses/bb7fb332e50d21c58fa85d6c9dc1248a18693df5","head":{"label":"InspurUSA:NiFi-4384","ref":"NiFi-4384","sha":"bb7fb332e50d21c58fa85d6c9dc1248a18693df5","user":{"login":"InspurUSA","id":27983447,"avatar_url":"https://avatars0.githubusercontent.com/u/27983447?v=4","gravatar_id":"","url":"https://api.github.com/users/InspurUSA","html_url":"https://github.com/InspurUSA","followers_url":"https://api.github.com/users/InspurUSA/followers","following_url":"https://api.github.com/users/InspurUSA/following{/other_user}","gists_url":"https://api.github.com/users/InspurUSA/gists{/gist_id}","starred_url":"https://api.github.com/users/InspurUSA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/InspurUSA/subscriptions","organizations_url":"https://api.github.com/users/InspurUSA/orgs","repos_url":"https://api.github.com/users/InspurUSA/repos","events_url":"https://api.github.com/users/InspurUSA/events{/privacy}","received_events_url":"https://api.github.com/users/InspurUSA/received_events","type":"Organization","site_admin":false},"repo":{"id":92338457,"name":"nifi","full_name":"InspurUSA/nifi","owner":{"login":"InspurUSA","id":27983447,"avatar_url":"https://avatars0.githubusercontent.com/u/27983447?v=4","gravatar_id":"","url":"https://api.github.com/users/InspurUSA","html_url":"https://github.com/InspurUSA","followers_url":"https://api.github.com/users/InspurUSA/followers","following_url":"https://api.github.com/users/InspurUSA/following{/other_user}","gists_url":"https://api.github.com/users/InspurUSA/gists{/gist_id}","starred_url":"https://api.github.com/users/InspurUSA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/InspurUSA/subscriptions","organizations_url":"https://api.github.com/users/InspurUSA/orgs","repos_url":"https://api.github.com/users/InspurUSA/repos","events_url":"https://api.github.com/users/InspurUSA/events{/privacy}","received_events_url":"https://api.github.com/users/InspurUSA/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/InspurUSA/nifi","description":"Mirror of Apache NiFi","fork":true,"url":"https://api.github.com/repos/InspurUSA/nifi","forks_url":"https://api.github.com/repos/InspurUSA/nifi/forks","keys_url":"https://api.github.com/repos/InspurUSA/nifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/InspurUSA/nifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/InspurUSA/nifi/teams","hooks_url":"https://api.github.com/repos/InspurUSA/nifi/hooks","issue_events_url":"https://api.github.com/repos/InspurUSA/nifi/issues/events{/number}","events_url":"https://api.github.com/repos/InspurUSA/nifi/events","assignees_url":"https://api.github.com/repos/InspurUSA/nifi/assignees{/user}","branches_url":"https://api.github.com/repos/InspurUSA/nifi/branches{/branch}","tags_url":"https://api.github.com/repos/InspurUSA/nifi/tags","blobs_url":"https://api.github.com/repos/InspurUSA/nifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/InspurUSA/nifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/InspurUSA/nifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/InspurUSA/nifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/InspurUSA/nifi/statuses/{sha}","languages_url":"https://api.github.com/repos/InspurUSA/nifi/languages","stargazers_url":"https://api.github.com/repos/InspurUSA/nifi/stargazers","contributors_url":"https://api.github.com/repos/InspurUSA/nifi/contributors","subscribers_url":"https://api.github.com/repos/InspurUSA/nifi/subscribers","subscription_url":"https://api.github.com/repos/InspurUSA/nifi/subscription","commits_url":"https://api.github.com/repos/InspurUSA/nifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/InspurUSA/nifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/InspurUSA/nifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/InspurUSA/nifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/InspurUSA/nifi/contents/{+path}","compare_url":"https://api.github.com/repos/InspurUSA/nifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/InspurUSA/nifi/merges","archive_url":"https://api.github.com/repos/InspurUSA/nifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/InspurUSA/nifi/downloads","issues_url":"https://api.github.com/repos/InspurUSA/nifi/issues{/number}","pulls_url":"https://api.github.com/repos/InspurUSA/nifi/pulls{/number}","milestones_url":"https://api.github.com/repos/InspurUSA/nifi/milestones{/number}","notifications_url":"https://api.github.com/repos/InspurUSA/nifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/InspurUSA/nifi/labels{/name}","releases_url":"https://api.github.com/repos/InspurUSA/nifi/releases{/id}","deployments_url":"https://api.github.com/repos/InspurUSA/nifi/deployments","created_at":"2017-05-24T21:31:33Z","updated_at":"2017-08-16T19:02:53Z","pushed_at":"2017-09-21T19:42:42Z","git_url":"git://github.com/InspurUSA/nifi.git","ssh_url":"git@github.com:InspurUSA/nifi.git","clone_url":"https://github.com/InspurUSA/nifi.git","svn_url":"https://github.com/InspurUSA/nifi","homepage":"","size":103174,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"66479464be67917c308ccc344cfff58da325748c","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":27911088,"name":"nifi","full_name":"apache/nifi","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/nifi","description":"Mirror of Apache NiFi","fork":false,"url":"https://api.github.com/repos/apache/nifi","forks_url":"https://api.github.com/repos/apache/nifi/forks","keys_url":"https://api.github.com/repos/apache/nifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/nifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/nifi/teams","hooks_url":"https://api.github.com/repos/apache/nifi/hooks","issue_events_url":"https://api.github.com/repos/apache/nifi/issues/events{/number}","events_url":"https://api.github.com/repos/apache/nifi/events","assignees_url":"https://api.github.com/repos/apache/nifi/assignees{/user}","branches_url":"https://api.github.com/repos/apache/nifi/branches{/branch}","tags_url":"https://api.github.com/repos/apache/nifi/tags","blobs_url":"https://api.github.com/repos/apache/nifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/nifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/nifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/nifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/nifi/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/nifi/languages","stargazers_url":"https://api.github.com/repos/apache/nifi/stargazers","contributors_url":"https://api.github.com/repos/apache/nifi/contributors","subscribers_url":"https://api.github.com/repos/apache/nifi/subscribers","subscription_url":"https://api.github.com/repos/apache/nifi/subscription","commits_url":"https://api.github.com/repos/apache/nifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/nifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/nifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/nifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/nifi/contents/{+path}","compare_url":"https://api.github.com/repos/apache/nifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/nifi/merges","archive_url":"https://api.github.com/repos/apache/nifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/nifi/downloads","issues_url":"https://api.github.com/repos/apache/nifi/issues{/number}","pulls_url":"https://api.github.com/repos/apache/nifi/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/nifi/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/nifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/nifi/labels{/name}","releases_url":"https://api.github.com/repos/apache/nifi/releases{/id}","deployments_url":"https://api.github.com/repos/apache/nifi/deployments","created_at":"2014-12-12T08:00:05Z","updated_at":"2017-09-20T01:01:39Z","pushed_at":"2017-09-21T19:49:13Z","git_url":"git://github.com/apache/nifi.git","ssh_url":"git@github.com:apache/nifi.git","clone_url":"https://github.com/apache/nifi.git","svn_url":"https://github.com/apache/nifi","homepage":"","size":103230,"stargazers_count":657,"watchers_count":657,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":635,"mirror_url":"git://git.apache.org/nifi.git","open_issues_count":107,"forks":635,"open_issues":107,"watchers":657,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/nifi/pulls/2160"},"html":{"href":"https://github.com/apache/nifi/pull/2160"},"issue":{"href":"https://api.github.com/repos/apache/nifi/issues/2160"},"comments":{"href":"https://api.github.com/repos/apache/nifi/issues/2160/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/nifi/pulls/2160/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/nifi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/nifi/pulls/2160/commits"},"statuses":{"href":"https://api.github.com/repos/apache/nifi/statuses/bb7fb332e50d21c58fa85d6c9dc1248a18693df5"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"cammachusa"}}