{"action":"opened","number":4,"pull_request":{"url":"https://api.github.com/repos/trufflesuite/truffle-hdwallet-provider/pulls/4","id":134939276,"html_url":"https://github.com/trufflesuite/truffle-hdwallet-provider/pull/4","diff_url":"https://github.com/trufflesuite/truffle-hdwallet-provider/pull/4.diff","patch_url":"https://github.com/trufflesuite/truffle-hdwallet-provider/pull/4.patch","issue_url":"https://api.github.com/repos/trufflesuite/truffle-hdwallet-provider/issues/4","number":4,"state":"open","locked":false,"title":"check valid mnemonic is provided","user":{"login":"zmitton","id":6954889,"avatar_url":"https://avatars0.githubusercontent.com/u/6954889?v=4","gravatar_id":"","url":"https://api.github.com/users/zmitton","html_url":"https://github.com/zmitton","followers_url":"https://api.github.com/users/zmitton/followers","following_url":"https://api.github.com/users/zmitton/following{/other_user}","gists_url":"https://api.github.com/users/zmitton/gists{/gist_id}","starred_url":"https://api.github.com/users/zmitton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zmitton/subscriptions","organizations_url":"https://api.github.com/users/zmitton/orgs","repos_url":"https://api.github.com/users/zmitton/repos","events_url":"https://api.github.com/users/zmitton/events{/privacy}","received_events_url":"https://api.github.com/users/zmitton/received_events","type":"User","site_admin":false},"body":"Without this check its easy to create a wallet with an undefined seed producing an insecure address. Many people have already done this on ropsten: \r\n\r\nhttps://ropsten.etherscan.io/address/0x959fd7ef9089b7142b6b908dc3a8af7aa8ff0fa1\r\n\r\nOn mainnet it could result in easy theft\r\n\r\nTested locally","created_at":"2017-08-09T16:45:27Z","updated_at":"2017-08-09T16:45:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/trufflesuite/truffle-hdwallet-provider/pulls/4/commits","review_comments_url":"https://api.github.com/repos/trufflesuite/truffle-hdwallet-provider/pulls/4/comments","review_comment_url":"https://api.github.com/repos/trufflesuite/truffle-hdwallet-provider/pulls/comments{/number}","comments_url":"https://api.github.com/repos/trufflesuite/truffle-hdwallet-provider/issues/4/comments","statuses_url":"https://api.github.com/repos/trufflesuite/truffle-hdwallet-provider/statuses/04e10db51e2761d009369731065cb71369c3a180","head":{"label":"zmitton:master","ref":"master","sha":"04e10db51e2761d009369731065cb71369c3a180","user":{"login":"zmitton","id":6954889,"avatar_url":"https://avatars0.githubusercontent.com/u/6954889?v=4","gravatar_id":"","url":"https://api.github.com/users/zmitton","html_url":"https://github.com/zmitton","followers_url":"https://api.github.com/users/zmitton/followers","following_url":"https://api.github.com/users/zmitton/following{/other_user}","gists_url":"https://api.github.com/users/zmitton/gists{/gist_id}","starred_url":"https://api.github.com/users/zmitton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zmitton/subscriptions","organizations_url":"https://api.github.com/users/zmitton/orgs","repos_url":"https://api.github.com/users/zmitton/repos","events_url":"https://api.github.com/users/zmitton/events{/privacy}","received_events_url":"https://api.github.com/users/zmitton/received_events","type":"User","site_admin":false},"repo":{"id":99830830,"name":"truffle-hdwallet-provider","full_name":"zmitton/truffle-hdwallet-provider","owner":{"login":"zmitton","id":6954889,"avatar_url":"https://avatars0.githubusercontent.com/u/6954889?v=4","gravatar_id":"","url":"https://api.github.com/users/zmitton","html_url":"https://github.com/zmitton","followers_url":"https://api.github.com/users/zmitton/followers","following_url":"https://api.github.com/users/zmitton/following{/other_user}","gists_url":"https://api.github.com/users/zmitton/gists{/gist_id}","starred_url":"https://api.github.com/users/zmitton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zmitton/subscriptions","organizations_url":"https://api.github.com/users/zmitton/orgs","repos_url":"https://api.github.com/users/zmitton/repos","events_url":"https://api.github.com/users/zmitton/events{/privacy}","received_events_url":"https://api.github.com/users/zmitton/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zmitton/truffle-hdwallet-provider","description":"HD Wallet-enabled Web3 provider","fork":true,"url":"https://api.github.com/repos/zmitton/truffle-hdwallet-provider","forks_url":"https://api.github.com/repos/zmitton/truffle-hdwallet-provider/forks","keys_url":"https://api.github.com/repos/zmitton/truffle-hdwallet-provider/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zmitton/truffle-hdwallet-provider/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zmitton/truffle-hdwallet-provider/teams","hooks_url":"https://api.github.com/repos/zmitton/truffle-hdwallet-provider/hooks","issue_events_url":"https://api.github.com/repos/zmitton/truffle-hdwallet-provider/issues/events{/number}","events_url":"https://api.github.com/repos/zmitton/truffle-hdwallet-provider/events","assignees_url":"https://api.github.com/repos/zmitton/truffle-hdwallet-provider/assignees{/user}","branches_url":"https://api.github.com/repos/zmitton/truffle-hdwallet-provider/branches{/branch}","tags_url":"https://api.github.com/repos/zmitton/truffle-hdwallet-provider/tags","blobs_url":"https://api.github.com/repos/zmitton/truffle-hdwallet-provider/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zmitton/truffle-hdwallet-provider/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zmitton/truffle-hdwallet-provider/git/refs{/sha}","trees_url":"https://api.github.com/repos/zmitton/truffle-hdwallet-provider/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zmitton/truffle-hdwallet-provider/statuses/{sha}","languages_url":"https://api.github.com/repos/zmitton/truffle-hdwallet-provider/languages","stargazers_url":"https://api.github.com/repos/zmitton/truffle-hdwallet-provider/stargazers","contributors_url":"https://api.github.com/repos/zmitton/truffle-hdwallet-provider/contributors","subscribers_url":"https://api.github.com/repos/zmitton/truffle-hdwallet-provider/subscribers","subscription_url":"https://api.github.com/repos/zmitton/truffle-hdwallet-provider/subscription","commits_url":"https://api.github.com/repos/zmitton/truffle-hdwallet-provider/commits{/sha}","git_commits_url":"https://api.github.com/repos/zmitton/truffle-hdwallet-provider/git/commits{/sha}","comments_url":"https://api.github.com/repos/zmitton/truffle-hdwallet-provider/comments{/number}","issue_comment_url":"https://api.github.com/repos/zmitton/truffle-hdwallet-provider/issues/comments{/number}","contents_url":"https://api.github.com/repos/zmitton/truffle-hdwallet-provider/contents/{+path}","compare_url":"https://api.github.com/repos/zmitton/truffle-hdwallet-provider/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zmitton/truffle-hdwallet-provider/merges","archive_url":"https://api.github.com/repos/zmitton/truffle-hdwallet-provider/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zmitton/truffle-hdwallet-provider/downloads","issues_url":"https://api.github.com/repos/zmitton/truffle-hdwallet-provider/issues{/number}","pulls_url":"https://api.github.com/repos/zmitton/truffle-hdwallet-provider/pulls{/number}","milestones_url":"https://api.github.com/repos/zmitton/truffle-hdwallet-provider/milestones{/number}","notifications_url":"https://api.github.com/repos/zmitton/truffle-hdwallet-provider/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zmitton/truffle-hdwallet-provider/labels{/name}","releases_url":"https://api.github.com/repos/zmitton/truffle-hdwallet-provider/releases{/id}","deployments_url":"https://api.github.com/repos/zmitton/truffle-hdwallet-provider/deployments","created_at":"2017-08-09T16:39:01Z","updated_at":"2017-08-09T16:39:02Z","pushed_at":"2017-08-09T16:40:32Z","git_url":"git://github.com/zmitton/truffle-hdwallet-provider.git","ssh_url":"git@github.com:zmitton/truffle-hdwallet-provider.git","clone_url":"https://github.com/zmitton/truffle-hdwallet-provider.git","svn_url":"https://github.com/zmitton/truffle-hdwallet-provider","homepage":null,"size":3,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"trufflesuite:master","ref":"master","sha":"6f7f90b8aaedfd285653736f47349dc106d3816b","user":{"login":"trufflesuite","id":22205159,"avatar_url":"https://avatars1.githubusercontent.com/u/22205159?v=4","gravatar_id":"","url":"https://api.github.com/users/trufflesuite","html_url":"https://github.com/trufflesuite","followers_url":"https://api.github.com/users/trufflesuite/followers","following_url":"https://api.github.com/users/trufflesuite/following{/other_user}","gists_url":"https://api.github.com/users/trufflesuite/gists{/gist_id}","starred_url":"https://api.github.com/users/trufflesuite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trufflesuite/subscriptions","organizations_url":"https://api.github.com/users/trufflesuite/orgs","repos_url":"https://api.github.com/users/trufflesuite/repos","events_url":"https://api.github.com/users/trufflesuite/events{/privacy}","received_events_url":"https://api.github.com/users/trufflesuite/received_events","type":"Organization","site_admin":false},"repo":{"id":80132414,"name":"truffle-hdwallet-provider","full_name":"trufflesuite/truffle-hdwallet-provider","owner":{"login":"trufflesuite","id":22205159,"avatar_url":"https://avatars1.githubusercontent.com/u/22205159?v=4","gravatar_id":"","url":"https://api.github.com/users/trufflesuite","html_url":"https://github.com/trufflesuite","followers_url":"https://api.github.com/users/trufflesuite/followers","following_url":"https://api.github.com/users/trufflesuite/following{/other_user}","gists_url":"https://api.github.com/users/trufflesuite/gists{/gist_id}","starred_url":"https://api.github.com/users/trufflesuite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trufflesuite/subscriptions","organizations_url":"https://api.github.com/users/trufflesuite/orgs","repos_url":"https://api.github.com/users/trufflesuite/repos","events_url":"https://api.github.com/users/trufflesuite/events{/privacy}","received_events_url":"https://api.github.com/users/trufflesuite/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/trufflesuite/truffle-hdwallet-provider","description":"HD Wallet-enabled Web3 provider","fork":false,"url":"https://api.github.com/repos/trufflesuite/truffle-hdwallet-provider","forks_url":"https://api.github.com/repos/trufflesuite/truffle-hdwallet-provider/forks","keys_url":"https://api.github.com/repos/trufflesuite/truffle-hdwallet-provider/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trufflesuite/truffle-hdwallet-provider/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trufflesuite/truffle-hdwallet-provider/teams","hooks_url":"https://api.github.com/repos/trufflesuite/truffle-hdwallet-provider/hooks","issue_events_url":"https://api.github.com/repos/trufflesuite/truffle-hdwallet-provider/issues/events{/number}","events_url":"https://api.github.com/repos/trufflesuite/truffle-hdwallet-provider/events","assignees_url":"https://api.github.com/repos/trufflesuite/truffle-hdwallet-provider/assignees{/user}","branches_url":"https://api.github.com/repos/trufflesuite/truffle-hdwallet-provider/branches{/branch}","tags_url":"https://api.github.com/repos/trufflesuite/truffle-hdwallet-provider/tags","blobs_url":"https://api.github.com/repos/trufflesuite/truffle-hdwallet-provider/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trufflesuite/truffle-hdwallet-provider/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trufflesuite/truffle-hdwallet-provider/git/refs{/sha}","trees_url":"https://api.github.com/repos/trufflesuite/truffle-hdwallet-provider/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trufflesuite/truffle-hdwallet-provider/statuses/{sha}","languages_url":"https://api.github.com/repos/trufflesuite/truffle-hdwallet-provider/languages","stargazers_url":"https://api.github.com/repos/trufflesuite/truffle-hdwallet-provider/stargazers","contributors_url":"https://api.github.com/repos/trufflesuite/truffle-hdwallet-provider/contributors","subscribers_url":"https://api.github.com/repos/trufflesuite/truffle-hdwallet-provider/subscribers","subscription_url":"https://api.github.com/repos/trufflesuite/truffle-hdwallet-provider/subscription","commits_url":"https://api.github.com/repos/trufflesuite/truffle-hdwallet-provider/commits{/sha}","git_commits_url":"https://api.github.com/repos/trufflesuite/truffle-hdwallet-provider/git/commits{/sha}","comments_url":"https://api.github.com/repos/trufflesuite/truffle-hdwallet-provider/comments{/number}","issue_comment_url":"https://api.github.com/repos/trufflesuite/truffle-hdwallet-provider/issues/comments{/number}","contents_url":"https://api.github.com/repos/trufflesuite/truffle-hdwallet-provider/contents/{+path}","compare_url":"https://api.github.com/repos/trufflesuite/truffle-hdwallet-provider/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trufflesuite/truffle-hdwallet-provider/merges","archive_url":"https://api.github.com/repos/trufflesuite/truffle-hdwallet-provider/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trufflesuite/truffle-hdwallet-provider/downloads","issues_url":"https://api.github.com/repos/trufflesuite/truffle-hdwallet-provider/issues{/number}","pulls_url":"https://api.github.com/repos/trufflesuite/truffle-hdwallet-provider/pulls{/number}","milestones_url":"https://api.github.com/repos/trufflesuite/truffle-hdwallet-provider/milestones{/number}","notifications_url":"https://api.github.com/repos/trufflesuite/truffle-hdwallet-provider/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trufflesuite/truffle-hdwallet-provider/labels{/name}","releases_url":"https://api.github.com/repos/trufflesuite/truffle-hdwallet-provider/releases{/id}","deployments_url":"https://api.github.com/repos/trufflesuite/truffle-hdwallet-provider/deployments","created_at":"2017-01-26T16:31:59Z","updated_at":"2017-08-03T02:09:28Z","pushed_at":"2017-07-27T21:20:00Z","git_url":"git://github.com/trufflesuite/truffle-hdwallet-provider.git","ssh_url":"git@github.com:trufflesuite/truffle-hdwallet-provider.git","clone_url":"https://github.com/trufflesuite/truffle-hdwallet-provider.git","svn_url":"https://github.com/trufflesuite/truffle-hdwallet-provider","homepage":null,"size":3,"stargazers_count":15,"watchers_count":15,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":4,"forks":6,"open_issues":4,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/trufflesuite/truffle-hdwallet-provider/pulls/4"},"html":{"href":"https://github.com/trufflesuite/truffle-hdwallet-provider/pull/4"},"issue":{"href":"https://api.github.com/repos/trufflesuite/truffle-hdwallet-provider/issues/4"},"comments":{"href":"https://api.github.com/repos/trufflesuite/truffle-hdwallet-provider/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/trufflesuite/truffle-hdwallet-provider/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/trufflesuite/truffle-hdwallet-provider/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/trufflesuite/truffle-hdwallet-provider/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/trufflesuite/truffle-hdwallet-provider/statuses/04e10db51e2761d009369731065cb71369c3a180"}},"merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":4,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"zmitton"}}