{"action":"created","issue":{"url":"https://api.github.com/repos/pandas-dev/pandas/issues/17715","repository_url":"https://api.github.com/repos/pandas-dev/pandas","labels_url":"https://api.github.com/repos/pandas-dev/pandas/issues/17715/labels{/name}","comments_url":"https://api.github.com/repos/pandas-dev/pandas/issues/17715/comments","events_url":"https://api.github.com/repos/pandas-dev/pandas/issues/17715/events","html_url":"https://github.com/pandas-dev/pandas/pull/17715","id":261517036,"number":17715,"title":"Separate out _convert_datetime_to_tsobject","user":{"login":"jbrockmendel","id":8078968,"avatar_url":"https://avatars1.githubusercontent.com/u/8078968?v=4","gravatar_id":"","url":"https://api.github.com/users/jbrockmendel","html_url":"https://github.com/jbrockmendel","followers_url":"https://api.github.com/users/jbrockmendel/followers","following_url":"https://api.github.com/users/jbrockmendel/following{/other_user}","gists_url":"https://api.github.com/users/jbrockmendel/gists{/gist_id}","starred_url":"https://api.github.com/users/jbrockmendel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbrockmendel/subscriptions","organizations_url":"https://api.github.com/users/jbrockmendel/orgs","repos_url":"https://api.github.com/users/jbrockmendel/repos","events_url":"https://api.github.com/users/jbrockmendel/events{/privacy}","received_events_url":"https://api.github.com/users/jbrockmendel/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-09-29T02:49:22Z","updated_at":"2017-09-29T05:19:57Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/pandas-dev/pandas/pulls/17715","html_url":"https://github.com/pandas-dev/pandas/pull/17715","diff_url":"https://github.com/pandas-dev/pandas/pull/17715.diff","patch_url":"https://github.com/pandas-dev/pandas/pull/17715.patch"},"body":"A bunch of calls to `convert_to_tsobject` are made in cases where we already know that the input is a `datetime` object.  This PR separates out the `datetime` case into a new function `_convert_datetime_to_tsobject`.\r\n\r\nSecond, to make the dependency between `_TSObject` and `Timestamp` one-way, this removes the three references to `Timestamp` that are made in `convert_str_to_tsobject`.  Verifying the last of these changes may be non-trivial.\r\n\r\nThis is a prelude to separating `_TSobject` logic out into `tslibs.conversion`.\r\n\r\n- [ ] closes #xxxx\r\n- [ ] tests added / passed\r\n- [ ] passes `git diff upstream/master -u -- \"*.py\" | flake8 --diff`\r\n- [ ] whatsnew entry\r\n"},"comment":{"url":"https://api.github.com/repos/pandas-dev/pandas/issues/comments/333033412","html_url":"https://github.com/pandas-dev/pandas/pull/17715#issuecomment-333033412","issue_url":"https://api.github.com/repos/pandas-dev/pandas/issues/17715","id":333033412,"user":{"login":"codecov[bot]","id":22429695,"avatar_url":"https://avatars2.githubusercontent.com/in/254?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov%5Bbot%5D","html_url":"https://github.com/apps/codecov","followers_url":"https://api.github.com/users/codecov%5Bbot%5D/followers","following_url":"https://api.github.com/users/codecov%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/codecov%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/codecov%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/codecov%5Bbot%5D/repos","events_url":"https://api.github.com/users/codecov%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/codecov%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2017-09-29T05:19:57Z","updated_at":"2017-09-29T05:19:57Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/17715?src=pr&el=h1) Report\n> Merging [#17715](https://codecov.io/gh/pandas-dev/pandas/pull/17715?src=pr&el=desc) into [master](https://codecov.io/gh/pandas-dev/pandas/commit/bbf0ddaf6461a9586c5e459d9c00fe863adc43f8?src=pr&el=desc) will **decrease** coverage by `0.02%`.\n> The diff coverage is `n/a`.\n\n[![Impacted file tree graph](https://codecov.io/gh/pandas-dev/pandas/pull/17715/graphs/tree.svg?width=650&height=150&src=pr&token=eZ4WkYLtcO)](https://codecov.io/gh/pandas-dev/pandas/pull/17715?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff             @@\n##           master   #17715      +/-   ##\n==========================================\n- Coverage   91.27%   91.25%   -0.03%     \n==========================================\n  Files         163      163              \n  Lines       49783    49783              \n==========================================\n- Hits        45439    45429      -10     \n- Misses       4344     4354      +10\n```\n\n| Flag | Coverage Δ | |\n|---|---|---|\n| #multiple | `89.05% <ø> (-0.01%)` | :arrow_down: |\n| #single | `40.34% <ø> (-0.07%)` | :arrow_down: |\n\n| [Impacted Files](https://codecov.io/gh/pandas-dev/pandas/pull/17715?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [pandas/io/gbq.py](https://codecov.io/gh/pandas-dev/pandas/pull/17715?src=pr&el=tree#diff-cGFuZGFzL2lvL2dicS5weQ==) | `25% <0%> (-58.34%)` | :arrow_down: |\n| [pandas/core/frame.py](https://codecov.io/gh/pandas-dev/pandas/pull/17715?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvZnJhbWUucHk=) | `97.73% <0%> (-0.1%)` | :arrow_down: |\n| [pandas/core/indexes/datetimes.py](https://codecov.io/gh/pandas-dev/pandas/pull/17715?src=pr&el=tree#diff-cGFuZGFzL2NvcmUvaW5kZXhlcy9kYXRldGltZXMucHk=) | `95.44% <0%> (-0.1%)` | :arrow_down: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/17715?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/pandas-dev/pandas/pull/17715?src=pr&el=footer). Last update [bbf0dda...6ced748](https://codecov.io/gh/pandas-dev/pandas/pull/17715?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov"}}