{"action":"created","issue":{"url":"https://api.github.com/repos/liferay/liferay-portal/issues/660","repository_url":"https://api.github.com/repos/liferay/liferay-portal","labels_url":"https://api.github.com/repos/liferay/liferay-portal/issues/660/labels{/name}","comments_url":"https://api.github.com/repos/liferay/liferay-portal/issues/660/comments","events_url":"https://api.github.com/repos/liferay/liferay-portal/issues/660/events","html_url":"https://github.com/liferay/liferay-portal/pull/660","id":53276466,"number":660,"title":"LPS-52186 Defined a basic confirmation dialog for sitemap submission","user":{"login":"javeedchida","id":9936595,"avatar_url":"https://avatars2.githubusercontent.com/u/9936595?v=3","gravatar_id":"","url":"https://api.github.com/users/javeedchida","html_url":"https://github.com/javeedchida","followers_url":"https://api.github.com/users/javeedchida/followers","following_url":"https://api.github.com/users/javeedchida/following{/other_user}","gists_url":"https://api.github.com/users/javeedchida/gists{/gist_id}","starred_url":"https://api.github.com/users/javeedchida/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javeedchida/subscriptions","organizations_url":"https://api.github.com/users/javeedchida/orgs","repos_url":"https://api.github.com/users/javeedchida/repos","events_url":"https://api.github.com/users/javeedchida/events{/privacy}","received_events_url":"https://api.github.com/users/javeedchida/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2015-01-02T20:39:55Z","updated_at":"2017-06-06T11:16:41Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/liferay/liferay-portal/pulls/660","html_url":"https://github.com/liferay/liferay-portal/pull/660","diff_url":"https://github.com/liferay/liferay-portal/pull/660.diff","patch_url":"https://github.com/liferay/liferay-portal/pull/660.patch"},"body":"My changes in sitemap.jsp started out as a modification of the existing aui:a tag whereby I set its href to a javascript invocation. A quick revealed Firefox doesn't play well with that, so I went with the more proper approach of pinning down the href attribute to \"#\" and adding an onclick event to the aui:a tag. But then I ran into a problem with aui:a not respecting my javascript's \"return false\" to prevent the default behavior of the link. So I used a straight html anchor tag and augmented it to do what aui:a was doing for me, namely: added a span to address the \"opens in a new window\" icon and a title attribute for accessibility.\n\nIf there is a way to still use aui:a, please share, and I'll be glad to improve this solution.\n"},"comment":{"url":"https://api.github.com/repos/liferay/liferay-portal/issues/comments/306455806","html_url":"https://github.com/liferay/liferay-portal/pull/660#issuecomment-306455806","issue_url":"https://api.github.com/repos/liferay/liferay-portal/issues/660","id":306455806,"user":{"login":"inacionery","id":14062516,"avatar_url":"https://avatars3.githubusercontent.com/u/14062516?v=3","gravatar_id":"","url":"https://api.github.com/users/inacionery","html_url":"https://github.com/inacionery","followers_url":"https://api.github.com/users/inacionery/followers","following_url":"https://api.github.com/users/inacionery/following{/other_user}","gists_url":"https://api.github.com/users/inacionery/gists{/gist_id}","starred_url":"https://api.github.com/users/inacionery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inacionery/subscriptions","organizations_url":"https://api.github.com/users/inacionery/orgs","repos_url":"https://api.github.com/users/inacionery/repos","events_url":"https://api.github.com/users/inacionery/events{/privacy}","received_events_url":"https://api.github.com/users/inacionery/received_events","type":"User","site_admin":false},"created_at":"2017-06-06T11:16:41Z","updated_at":"2017-06-06T11:16:41Z","body":"Can one of the admins verify this patch?"}}
{"actor":{"display_login":"inacionery"}}