{"action":"created","comment":{"url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/comments/112330754","pull_request_review_id":33637897,"id":112330754,"diff_hunk":"@@ -0,0 +1,237 @@\n+<!--\n+\n+/*\n+** Copyright (c) 2017 The Khronos Group Inc.\n+**\n+** Permission is hereby granted, free of charge, to any person obtaining a\n+** copy of this software and/or associated documentation files (the\n+** \"Materials\"), to deal in the Materials without restriction, including\n+** without limitation the rights to use, copy, modify, merge, publish,\n+** distribute, sublicense, and/or sell copies of the Materials, and to\n+** permit persons to whom the Materials are furnished to do so, subject to\n+** the following conditions:\n+**\n+** The above copyright notice and this permission notice shall be included\n+** in all copies or substantial portions of the Materials.\n+**\n+** THE MATERIALS ARE PROVIDED \"AS IS\", WITHOUT WARRANTY OF ANY KIND,\n+** EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF\n+** MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.\n+** IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY\n+** CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT,\n+** TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE\n+** MATERIALS OR THE USE OR OTHER DEALINGS IN THE MATERIALS.\n+*/\n+\n+-->\n+\n+<!DOCTYPE html>\n+<html>\n+<head>\n+<meta charset=\"utf-8\">\n+<title>WebGL BlitFramebuffer Resolve to Back Buffer</title>\n+<link rel=\"stylesheet\" href=\"../../resources/js-test-style.css\"/>\n+<script src=\"../../js/js-test-pre.js\"></script>\n+<script src=\"../../js/webgl-test-utils.js\"></script>\n+<script src=\"../../js/glsl-conformance-test.js\"></script>\n+</head>\n+<body>\n+<div id=\"description\"></div>\n+<div id=\"canvasHeader\"></div>\n+<div id=\"console\"></div>\n+\n+<script>\n+\"use strict\";\n+\n+var wtu = WebGLTestUtils;\n+description(\"This test verifies the behavior of blitFramebuffer when resolving directly to the back buffer.\");\n+\n+debug(\"Regression test for <a href='http://crbug.com/699566'>http://crbug.com/699566</a>\");\n+\n+function runTest(testParams) {\n+    // Assume a square framebuffer. Doesn't need to match the size of the canvas, necessarily.\n+    let sz = 64;\n+\n+    debug('');\n+    debug('Testing with alpha = ' + testParams.attribs.alpha +\n+          ', antialias = ' + testParams.attribs.antialias +\n+          ', internalformat = ' + testParams.internalformat);\n+\n+    var canvas = document.createElement('canvas');\n+    canvas.width = sz;\n+    canvas.height = sz;\n+    document.getElementById('canvasHeader').appendChild(canvas);\n+    var gl = wtu.create3DContext(canvas, testParams.attribs, 2);\n+\n+    // Find the supported samples for a multisampled renderbuffer of the appropriate internal format.\n+    let samples = gl.getInternalformatParameter(gl.RENDERBUFFER, gl[testParams.internalformat], gl.SAMPLES);\n+    if (!samples) {","path":"sdk/tests/conformance2/rendering/blitframebuffer-resolve-to-back-buffer.html","position":68,"original_position":68,"commit_id":"7a3fbb4264eb8e5e6de266f627010cecd67759a3","original_commit_id":"7a3fbb4264eb8e5e6de266f627010cecd67759a3","user":{"login":"zhenyao","id":2073521,"avatar_url":"https://avatars3.githubusercontent.com/u/2073521?v=3","gravatar_id":"","url":"https://api.github.com/users/zhenyao","html_url":"https://github.com/zhenyao","followers_url":"https://api.github.com/users/zhenyao/followers","following_url":"https://api.github.com/users/zhenyao/following{/other_user}","gists_url":"https://api.github.com/users/zhenyao/gists{/gist_id}","starred_url":"https://api.github.com/users/zhenyao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhenyao/subscriptions","organizations_url":"https://api.github.com/users/zhenyao/orgs","repos_url":"https://api.github.com/users/zhenyao/repos","events_url":"https://api.github.com/users/zhenyao/events{/privacy}","received_events_url":"https://api.github.com/users/zhenyao/received_events","type":"User","site_admin":false},"body":"Just curious: are we returning an empty set or None when failing? If empty set, does !empty_set work?","created_at":"2017-04-19T22:41:50Z","updated_at":"2017-04-19T22:44:02Z","html_url":"https://github.com/KhronosGroup/WebGL/pull/2377#discussion_r112330754","pull_request_url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/2377","_links":{"self":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/comments/112330754"},"html":{"href":"https://github.com/KhronosGroup/WebGL/pull/2377#discussion_r112330754"},"pull_request":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/2377"}}},"pull_request":{"url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/2377","id":116653009,"html_url":"https://github.com/KhronosGroup/WebGL/pull/2377","diff_url":"https://github.com/KhronosGroup/WebGL/pull/2377.diff","patch_url":"https://github.com/KhronosGroup/WebGL/pull/2377.patch","issue_url":"https://api.github.com/repos/KhronosGroup/WebGL/issues/2377","number":2377,"state":"open","locked":false,"title":"Specify, and add tests for, resolving multisampled renderbuffers to t…","user":{"login":"kenrussell","id":1149904,"avatar_url":"https://avatars2.githubusercontent.com/u/1149904?v=3","gravatar_id":"","url":"https://api.github.com/users/kenrussell","html_url":"https://github.com/kenrussell","followers_url":"https://api.github.com/users/kenrussell/followers","following_url":"https://api.github.com/users/kenrussell/following{/other_user}","gists_url":"https://api.github.com/users/kenrussell/gists{/gist_id}","starred_url":"https://api.github.com/users/kenrussell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kenrussell/subscriptions","organizations_url":"https://api.github.com/users/kenrussell/orgs","repos_url":"https://api.github.com/users/kenrussell/repos","events_url":"https://api.github.com/users/kenrussell/events{/privacy}","received_events_url":"https://api.github.com/users/kenrussell/received_events","type":"User","site_admin":false},"body":"…he back buffer.\r\n\r\nThis behavior was implicitly defined earlier and is now clearly\r\nspecified and tested. This acts as a regression test for\r\nhttp://crbug.com/699566 , a failure to correcly render Epic's Zen\r\nGarden demo on macOS. The new test already passes in Firefox.","created_at":"2017-04-19T22:12:08Z","updated_at":"2017-04-19T22:44:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"db251fb9b3f53165359f84bf5b5529b1c41c9da9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/2377/commits","review_comments_url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/2377/comments","review_comment_url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KhronosGroup/WebGL/issues/2377/comments","statuses_url":"https://api.github.com/repos/KhronosGroup/WebGL/statuses/7a3fbb4264eb8e5e6de266f627010cecd67759a3","head":{"label":"kenrussell:blitframebuffer-to-back-buffer","ref":"blitframebuffer-to-back-buffer","sha":"7a3fbb4264eb8e5e6de266f627010cecd67759a3","user":{"login":"kenrussell","id":1149904,"avatar_url":"https://avatars2.githubusercontent.com/u/1149904?v=3","gravatar_id":"","url":"https://api.github.com/users/kenrussell","html_url":"https://github.com/kenrussell","followers_url":"https://api.github.com/users/kenrussell/followers","following_url":"https://api.github.com/users/kenrussell/following{/other_user}","gists_url":"https://api.github.com/users/kenrussell/gists{/gist_id}","starred_url":"https://api.github.com/users/kenrussell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kenrussell/subscriptions","organizations_url":"https://api.github.com/users/kenrussell/orgs","repos_url":"https://api.github.com/users/kenrussell/repos","events_url":"https://api.github.com/users/kenrussell/events{/privacy}","received_events_url":"https://api.github.com/users/kenrussell/received_events","type":"User","site_admin":false},"repo":{"id":5265706,"name":"WebGL","full_name":"kenrussell/WebGL","owner":{"login":"kenrussell","id":1149904,"avatar_url":"https://avatars2.githubusercontent.com/u/1149904?v=3","gravatar_id":"","url":"https://api.github.com/users/kenrussell","html_url":"https://github.com/kenrussell","followers_url":"https://api.github.com/users/kenrussell/followers","following_url":"https://api.github.com/users/kenrussell/following{/other_user}","gists_url":"https://api.github.com/users/kenrussell/gists{/gist_id}","starred_url":"https://api.github.com/users/kenrussell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kenrussell/subscriptions","organizations_url":"https://api.github.com/users/kenrussell/orgs","repos_url":"https://api.github.com/users/kenrussell/repos","events_url":"https://api.github.com/users/kenrussell/events{/privacy}","received_events_url":"https://api.github.com/users/kenrussell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kenrussell/WebGL","description":"The Official Khronos WebGL Repository","fork":true,"url":"https://api.github.com/repos/kenrussell/WebGL","forks_url":"https://api.github.com/repos/kenrussell/WebGL/forks","keys_url":"https://api.github.com/repos/kenrussell/WebGL/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kenrussell/WebGL/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kenrussell/WebGL/teams","hooks_url":"https://api.github.com/repos/kenrussell/WebGL/hooks","issue_events_url":"https://api.github.com/repos/kenrussell/WebGL/issues/events{/number}","events_url":"https://api.github.com/repos/kenrussell/WebGL/events","assignees_url":"https://api.github.com/repos/kenrussell/WebGL/assignees{/user}","branches_url":"https://api.github.com/repos/kenrussell/WebGL/branches{/branch}","tags_url":"https://api.github.com/repos/kenrussell/WebGL/tags","blobs_url":"https://api.github.com/repos/kenrussell/WebGL/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kenrussell/WebGL/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kenrussell/WebGL/git/refs{/sha}","trees_url":"https://api.github.com/repos/kenrussell/WebGL/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kenrussell/WebGL/statuses/{sha}","languages_url":"https://api.github.com/repos/kenrussell/WebGL/languages","stargazers_url":"https://api.github.com/repos/kenrussell/WebGL/stargazers","contributors_url":"https://api.github.com/repos/kenrussell/WebGL/contributors","subscribers_url":"https://api.github.com/repos/kenrussell/WebGL/subscribers","subscription_url":"https://api.github.com/repos/kenrussell/WebGL/subscription","commits_url":"https://api.github.com/repos/kenrussell/WebGL/commits{/sha}","git_commits_url":"https://api.github.com/repos/kenrussell/WebGL/git/commits{/sha}","comments_url":"https://api.github.com/repos/kenrussell/WebGL/comments{/number}","issue_comment_url":"https://api.github.com/repos/kenrussell/WebGL/issues/comments{/number}","contents_url":"https://api.github.com/repos/kenrussell/WebGL/contents/{+path}","compare_url":"https://api.github.com/repos/kenrussell/WebGL/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kenrussell/WebGL/merges","archive_url":"https://api.github.com/repos/kenrussell/WebGL/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kenrussell/WebGL/downloads","issues_url":"https://api.github.com/repos/kenrussell/WebGL/issues{/number}","pulls_url":"https://api.github.com/repos/kenrussell/WebGL/pulls{/number}","milestones_url":"https://api.github.com/repos/kenrussell/WebGL/milestones{/number}","notifications_url":"https://api.github.com/repos/kenrussell/WebGL/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kenrussell/WebGL/labels{/name}","releases_url":"https://api.github.com/repos/kenrussell/WebGL/releases{/id}","deployments_url":"https://api.github.com/repos/kenrussell/WebGL/deployments","created_at":"2012-08-01T22:34:06Z","updated_at":"2016-10-22T04:17:42Z","pushed_at":"2017-04-19T22:13:16Z","git_url":"git://github.com/kenrussell/WebGL.git","ssh_url":"git@github.com:kenrussell/WebGL.git","clone_url":"https://github.com/kenrussell/WebGL.git","svn_url":"https://github.com/kenrussell/WebGL","homepage":null,"size":29499,"stargazers_count":4,"watchers_count":4,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":4,"default_branch":"master"}},"base":{"label":"KhronosGroup:master","ref":"master","sha":"73fd432435e8a8563f2117737c7639331761bddd","user":{"login":"KhronosGroup","id":1608701,"avatar_url":"https://avatars0.githubusercontent.com/u/1608701?v=3","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"repo":{"id":5207280,"name":"WebGL","full_name":"KhronosGroup/WebGL","owner":{"login":"KhronosGroup","id":1608701,"avatar_url":"https://avatars0.githubusercontent.com/u/1608701?v=3","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KhronosGroup/WebGL","description":"The Official Khronos WebGL Repository","fork":false,"url":"https://api.github.com/repos/KhronosGroup/WebGL","forks_url":"https://api.github.com/repos/KhronosGroup/WebGL/forks","keys_url":"https://api.github.com/repos/KhronosGroup/WebGL/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KhronosGroup/WebGL/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KhronosGroup/WebGL/teams","hooks_url":"https://api.github.com/repos/KhronosGroup/WebGL/hooks","issue_events_url":"https://api.github.com/repos/KhronosGroup/WebGL/issues/events{/number}","events_url":"https://api.github.com/repos/KhronosGroup/WebGL/events","assignees_url":"https://api.github.com/repos/KhronosGroup/WebGL/assignees{/user}","branches_url":"https://api.github.com/repos/KhronosGroup/WebGL/branches{/branch}","tags_url":"https://api.github.com/repos/KhronosGroup/WebGL/tags","blobs_url":"https://api.github.com/repos/KhronosGroup/WebGL/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KhronosGroup/WebGL/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KhronosGroup/WebGL/git/refs{/sha}","trees_url":"https://api.github.com/repos/KhronosGroup/WebGL/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KhronosGroup/WebGL/statuses/{sha}","languages_url":"https://api.github.com/repos/KhronosGroup/WebGL/languages","stargazers_url":"https://api.github.com/repos/KhronosGroup/WebGL/stargazers","contributors_url":"https://api.github.com/repos/KhronosGroup/WebGL/contributors","subscribers_url":"https://api.github.com/repos/KhronosGroup/WebGL/subscribers","subscription_url":"https://api.github.com/repos/KhronosGroup/WebGL/subscription","commits_url":"https://api.github.com/repos/KhronosGroup/WebGL/commits{/sha}","git_commits_url":"https://api.github.com/repos/KhronosGroup/WebGL/git/commits{/sha}","comments_url":"https://api.github.com/repos/KhronosGroup/WebGL/comments{/number}","issue_comment_url":"https://api.github.com/repos/KhronosGroup/WebGL/issues/comments{/number}","contents_url":"https://api.github.com/repos/KhronosGroup/WebGL/contents/{+path}","compare_url":"https://api.github.com/repos/KhronosGroup/WebGL/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KhronosGroup/WebGL/merges","archive_url":"https://api.github.com/repos/KhronosGroup/WebGL/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KhronosGroup/WebGL/downloads","issues_url":"https://api.github.com/repos/KhronosGroup/WebGL/issues{/number}","pulls_url":"https://api.github.com/repos/KhronosGroup/WebGL/pulls{/number}","milestones_url":"https://api.github.com/repos/KhronosGroup/WebGL/milestones{/number}","notifications_url":"https://api.github.com/repos/KhronosGroup/WebGL/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KhronosGroup/WebGL/labels{/name}","releases_url":"https://api.github.com/repos/KhronosGroup/WebGL/releases{/id}","deployments_url":"https://api.github.com/repos/KhronosGroup/WebGL/deployments","created_at":"2012-07-27T17:21:51Z","updated_at":"2017-04-18T19:07:11Z","pushed_at":"2017-04-19T22:12:08Z","git_url":"git://github.com/KhronosGroup/WebGL.git","ssh_url":"git@github.com:KhronosGroup/WebGL.git","clone_url":"https://github.com/KhronosGroup/WebGL.git","svn_url":"https://github.com/KhronosGroup/WebGL","homepage":null,"size":29469,"stargazers_count":810,"watchers_count":810,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":360,"mirror_url":null,"open_issues_count":110,"forks":360,"open_issues":110,"watchers":810,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/2377"},"html":{"href":"https://github.com/KhronosGroup/WebGL/pull/2377"},"issue":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/issues/2377"},"comments":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/issues/2377/comments"},"review_comments":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/2377/comments"},"review_comment":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/pulls/2377/commits"},"statuses":{"href":"https://api.github.com/repos/KhronosGroup/WebGL/statuses/7a3fbb4264eb8e5e6de266f627010cecd67759a3"}}}}
{"actor":{"display_login":"zhenyao"}}