{"action":"closed","number":1,"pull_request":{"url":"https://api.github.com/repos/woshichenxi2003/travis-project/pulls/1","id":146195939,"html_url":"https://github.com/woshichenxi2003/travis-project/pull/1","diff_url":"https://github.com/woshichenxi2003/travis-project/pull/1.diff","patch_url":"https://github.com/woshichenxi2003/travis-project/pull/1.patch","issue_url":"https://api.github.com/repos/woshichenxi2003/travis-project/issues/1","number":1,"state":"closed","locked":false,"title":"Removing private SSH key","user":{"login":"oudeismetis","id":444070,"avatar_url":"https://avatars3.githubusercontent.com/u/444070?v=4","gravatar_id":"","url":"https://api.github.com/users/oudeismetis","html_url":"https://github.com/oudeismetis","followers_url":"https://api.github.com/users/oudeismetis/followers","following_url":"https://api.github.com/users/oudeismetis/following{/other_user}","gists_url":"https://api.github.com/users/oudeismetis/gists{/gist_id}","starred_url":"https://api.github.com/users/oudeismetis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oudeismetis/subscriptions","organizations_url":"https://api.github.com/users/oudeismetis/orgs","repos_url":"https://api.github.com/users/oudeismetis/repos","events_url":"https://api.github.com/users/oudeismetis/events{/privacy}","received_events_url":"https://api.github.com/users/oudeismetis/received_events","type":"User","site_admin":false},"body":"I noticed you had commited a private ssh key to your repo. \n\n**\"I know. It was intentional.\"** \nSorry to bother you then. Feel free to ignore this PR. \nYou know you can also [secure private data while keeping it under source control](https://keybase.io/blog/encrypted-git-for-everyone).\n\n**\"I didn't notice. What is this file? Is it a problem?\"**\n[This can be a very bad thing](http://www.securityweek.com/github-search-makes-easy-discovery-encryption-keys-passwords-source-code)\n\n**\"I keep accidentally typing `git add .`, any way I can prevent that from being an issue?\"**\nThere are a couple of steps you should take immediately:\n1. Avoid commands like `git add .` and `git add *`. It's better to be more explicit when you can.\n1. Assume your key is compromised. Unassociate it from any accounts you are using it for and [generate a new key](https://help.github.com/articles/reviewing-your-ssh-keys/).\n1. Store your keys in a location outside of your project.\n1. Use a [.gitignore file](https://git-scm.com/docs/gitignore) to prevent accidental commits of certain files.\n\nGithub also has a page about how to [remove sensitive data from a repo](https://help.github.com/articles/removing-sensitive-data-from-a-repository/).\n\nHope this PR finds you well","created_at":"2017-10-12T12:30:46Z","updated_at":"2017-10-21T15:19:30Z","closed_at":"2017-10-21T15:19:30Z","merged_at":null,"merge_commit_sha":"8054ade5c3ca94691e40902d30d67cee20bbadac","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/woshichenxi2003/travis-project/pulls/1/commits","review_comments_url":"https://api.github.com/repos/woshichenxi2003/travis-project/pulls/1/comments","review_comment_url":"https://api.github.com/repos/woshichenxi2003/travis-project/pulls/comments{/number}","comments_url":"https://api.github.com/repos/woshichenxi2003/travis-project/issues/1/comments","statuses_url":"https://api.github.com/repos/woshichenxi2003/travis-project/statuses/983f12aec284f193d5cf5a405f568ca08913dd22","head":{"label":"oudeismetis:master","ref":"master","sha":"983f12aec284f193d5cf5a405f568ca08913dd22","user":{"login":"oudeismetis","id":444070,"avatar_url":"https://avatars3.githubusercontent.com/u/444070?v=4","gravatar_id":"","url":"https://api.github.com/users/oudeismetis","html_url":"https://github.com/oudeismetis","followers_url":"https://api.github.com/users/oudeismetis/followers","following_url":"https://api.github.com/users/oudeismetis/following{/other_user}","gists_url":"https://api.github.com/users/oudeismetis/gists{/gist_id}","starred_url":"https://api.github.com/users/oudeismetis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oudeismetis/subscriptions","organizations_url":"https://api.github.com/users/oudeismetis/orgs","repos_url":"https://api.github.com/users/oudeismetis/repos","events_url":"https://api.github.com/users/oudeismetis/events{/privacy}","received_events_url":"https://api.github.com/users/oudeismetis/received_events","type":"User","site_admin":false},"repo":null},"base":{"label":"woshichenxi2003:master","ref":"master","sha":"82f1845b09408eeb56e69557f0655b83cda4c226","user":{"login":"woshichenxi2003","id":24429936,"avatar_url":"https://avatars3.githubusercontent.com/u/24429936?v=4","gravatar_id":"","url":"https://api.github.com/users/woshichenxi2003","html_url":"https://github.com/woshichenxi2003","followers_url":"https://api.github.com/users/woshichenxi2003/followers","following_url":"https://api.github.com/users/woshichenxi2003/following{/other_user}","gists_url":"https://api.github.com/users/woshichenxi2003/gists{/gist_id}","starred_url":"https://api.github.com/users/woshichenxi2003/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/woshichenxi2003/subscriptions","organizations_url":"https://api.github.com/users/woshichenxi2003/orgs","repos_url":"https://api.github.com/users/woshichenxi2003/repos","events_url":"https://api.github.com/users/woshichenxi2003/events{/privacy}","received_events_url":"https://api.github.com/users/woshichenxi2003/received_events","type":"User","site_admin":false},"repo":{"id":93996929,"name":"travis-project","full_name":"woshichenxi2003/travis-project","owner":{"login":"woshichenxi2003","id":24429936,"avatar_url":"https://avatars3.githubusercontent.com/u/24429936?v=4","gravatar_id":"","url":"https://api.github.com/users/woshichenxi2003","html_url":"https://github.com/woshichenxi2003","followers_url":"https://api.github.com/users/woshichenxi2003/followers","following_url":"https://api.github.com/users/woshichenxi2003/following{/other_user}","gists_url":"https://api.github.com/users/woshichenxi2003/gists{/gist_id}","starred_url":"https://api.github.com/users/woshichenxi2003/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/woshichenxi2003/subscriptions","organizations_url":"https://api.github.com/users/woshichenxi2003/orgs","repos_url":"https://api.github.com/users/woshichenxi2003/repos","events_url":"https://api.github.com/users/woshichenxi2003/events{/privacy}","received_events_url":"https://api.github.com/users/woshichenxi2003/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/woshichenxi2003/travis-project","description":null,"fork":false,"url":"https://api.github.com/repos/woshichenxi2003/travis-project","forks_url":"https://api.github.com/repos/woshichenxi2003/travis-project/forks","keys_url":"https://api.github.com/repos/woshichenxi2003/travis-project/keys{/key_id}","collaborators_url":"https://api.github.com/repos/woshichenxi2003/travis-project/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/woshichenxi2003/travis-project/teams","hooks_url":"https://api.github.com/repos/woshichenxi2003/travis-project/hooks","issue_events_url":"https://api.github.com/repos/woshichenxi2003/travis-project/issues/events{/number}","events_url":"https://api.github.com/repos/woshichenxi2003/travis-project/events","assignees_url":"https://api.github.com/repos/woshichenxi2003/travis-project/assignees{/user}","branches_url":"https://api.github.com/repos/woshichenxi2003/travis-project/branches{/branch}","tags_url":"https://api.github.com/repos/woshichenxi2003/travis-project/tags","blobs_url":"https://api.github.com/repos/woshichenxi2003/travis-project/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/woshichenxi2003/travis-project/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/woshichenxi2003/travis-project/git/refs{/sha}","trees_url":"https://api.github.com/repos/woshichenxi2003/travis-project/git/trees{/sha}","statuses_url":"https://api.github.com/repos/woshichenxi2003/travis-project/statuses/{sha}","languages_url":"https://api.github.com/repos/woshichenxi2003/travis-project/languages","stargazers_url":"https://api.github.com/repos/woshichenxi2003/travis-project/stargazers","contributors_url":"https://api.github.com/repos/woshichenxi2003/travis-project/contributors","subscribers_url":"https://api.github.com/repos/woshichenxi2003/travis-project/subscribers","subscription_url":"https://api.github.com/repos/woshichenxi2003/travis-project/subscription","commits_url":"https://api.github.com/repos/woshichenxi2003/travis-project/commits{/sha}","git_commits_url":"https://api.github.com/repos/woshichenxi2003/travis-project/git/commits{/sha}","comments_url":"https://api.github.com/repos/woshichenxi2003/travis-project/comments{/number}","issue_comment_url":"https://api.github.com/repos/woshichenxi2003/travis-project/issues/comments{/number}","contents_url":"https://api.github.com/repos/woshichenxi2003/travis-project/contents/{+path}","compare_url":"https://api.github.com/repos/woshichenxi2003/travis-project/compare/{base}...{head}","merges_url":"https://api.github.com/repos/woshichenxi2003/travis-project/merges","archive_url":"https://api.github.com/repos/woshichenxi2003/travis-project/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/woshichenxi2003/travis-project/downloads","issues_url":"https://api.github.com/repos/woshichenxi2003/travis-project/issues{/number}","pulls_url":"https://api.github.com/repos/woshichenxi2003/travis-project/pulls{/number}","milestones_url":"https://api.github.com/repos/woshichenxi2003/travis-project/milestones{/number}","notifications_url":"https://api.github.com/repos/woshichenxi2003/travis-project/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/woshichenxi2003/travis-project/labels{/name}","releases_url":"https://api.github.com/repos/woshichenxi2003/travis-project/releases{/id}","deployments_url":"https://api.github.com/repos/woshichenxi2003/travis-project/deployments","created_at":"2017-06-11T10:22:03Z","updated_at":"2017-08-14T15:17:18Z","pushed_at":"2017-10-21T15:03:50Z","git_url":"git://github.com/woshichenxi2003/travis-project.git","ssh_url":"git@github.com:woshichenxi2003/travis-project.git","clone_url":"https://github.com/woshichenxi2003/travis-project.git","svn_url":"https://github.com/woshichenxi2003/travis-project","homepage":null,"size":308,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/woshichenxi2003/travis-project/pulls/1"},"html":{"href":"https://github.com/woshichenxi2003/travis-project/pull/1"},"issue":{"href":"https://api.github.com/repos/woshichenxi2003/travis-project/issues/1"},"comments":{"href":"https://api.github.com/repos/woshichenxi2003/travis-project/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/woshichenxi2003/travis-project/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/woshichenxi2003/travis-project/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/woshichenxi2003/travis-project/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/woshichenxi2003/travis-project/statuses/983f12aec284f193d5cf5a405f568ca08913dd22"}},"author_association":"NONE","merged":false,"mergeable":false,"rebaseable":false,"mergeable_state":"dirty","merged_by":null,"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":0,"additions":0,"deletions":0,"changed_files":0}}
{"actor":{"display_login":"woshichenxi2003"}}