{"action":"created","comment":{"url":"https://api.github.com/repos/lyft/envoy/pulls/comments/107025099","pull_request_review_id":27975041,"id":107025099,"diff_hunk":"@@ -37,6 +37,43 @@ class DetectorImplFactory {\n                                       EventLoggerPtr event_logger);\n };\n \n+struct SRAccumulatorBucket {\n+  std::atomic<uint64_t> success_rq_counter_;\n+  std::atomic<uint64_t> total_rq_counter_;\n+};\n+\n+/**\n+ * The S(uccess)R(ate)AccumulatorImpl uses the SRAccumulatorBucket to get per host Success Rate\n+ * stats.","path":"source/common/upstream/outlier_detection_impl.h","position":11,"original_position":11,"commit_id":"77b407b074418ff9dffdf6336e67c25c1ba6a7d3","original_commit_id":"77b407b074418ff9dffdf6336e67c25c1ba6a7d3","user":{"login":"ccaraman","id":19931185,"avatar_url":"https://avatars1.githubusercontent.com/u/19931185?v=3","gravatar_id":"","url":"https://api.github.com/users/ccaraman","html_url":"https://github.com/ccaraman","followers_url":"https://api.github.com/users/ccaraman/followers","following_url":"https://api.github.com/users/ccaraman/following{/other_user}","gists_url":"https://api.github.com/users/ccaraman/gists{/gist_id}","starred_url":"https://api.github.com/users/ccaraman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ccaraman/subscriptions","organizations_url":"https://api.github.com/users/ccaraman/orgs","repos_url":"https://api.github.com/users/ccaraman/repos","events_url":"https://api.github.com/users/ccaraman/events{/privacy}","received_events_url":"https://api.github.com/users/ccaraman/received_events","type":"User","site_admin":false},"body":"Fix comments","created_at":"2017-03-20T21:46:38Z","updated_at":"2017-03-20T21:46:39Z","html_url":"https://github.com/lyft/envoy/pull/546#discussion_r107025099","pull_request_url":"https://api.github.com/repos/lyft/envoy/pulls/546","_links":{"self":{"href":"https://api.github.com/repos/lyft/envoy/pulls/comments/107025099"},"html":{"href":"https://github.com/lyft/envoy/pull/546#discussion_r107025099"},"pull_request":{"href":"https://api.github.com/repos/lyft/envoy/pulls/546"}}},"pull_request":{"url":"https://api.github.com/repos/lyft/envoy/pulls/546","id":109715176,"html_url":"https://github.com/lyft/envoy/pull/546","diff_url":"https://github.com/lyft/envoy/pull/546.diff","patch_url":"https://github.com/lyft/envoy/pull/546.patch","issue_url":"https://api.github.com/repos/lyft/envoy/issues/546","number":546,"state":"open","locked":false,"title":"outlier: success rate detection","user":{"login":"junr03","id":6007532,"avatar_url":"https://avatars3.githubusercontent.com/u/6007532?v=3","gravatar_id":"","url":"https://api.github.com/users/junr03","html_url":"https://github.com/junr03","followers_url":"https://api.github.com/users/junr03/followers","following_url":"https://api.github.com/users/junr03/following{/other_user}","gists_url":"https://api.github.com/users/junr03/gists{/gist_id}","starred_url":"https://api.github.com/users/junr03/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junr03/subscriptions","organizations_url":"https://api.github.com/users/junr03/orgs","repos_url":"https://api.github.com/users/junr03/repos","events_url":"https://api.github.com/users/junr03/events{/privacy}","received_events_url":"https://api.github.com/users/junr03/received_events","type":"User","site_admin":false},"body":"WIP\r\n\r\nTo-do:\r\n- [x] tests\r\n- [x] stats\r\n- [x] after https://github.com/lyft/envoy/pull/543 merges add sr values to config\r\n- [x] docs\r\n- [x] add per type enforcing","created_at":"2017-03-08T15:14:02Z","updated_at":"2017-03-20T21:46:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e52d3df9d898a77f67eb95998dedfdb1385b75a6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/lyft/envoy/pulls/546/commits","review_comments_url":"https://api.github.com/repos/lyft/envoy/pulls/546/comments","review_comment_url":"https://api.github.com/repos/lyft/envoy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lyft/envoy/issues/546/comments","statuses_url":"https://api.github.com/repos/lyft/envoy/statuses/77b407b074418ff9dffdf6336e67c25c1ba6a7d3","head":{"label":"lyft:sr-outlier-detection","ref":"sr-outlier-detection","sha":"77b407b074418ff9dffdf6336e67c25c1ba6a7d3","user":{"login":"lyft","id":4269340,"avatar_url":"https://avatars1.githubusercontent.com/u/4269340?v=3","gravatar_id":"","url":"https://api.github.com/users/lyft","html_url":"https://github.com/lyft","followers_url":"https://api.github.com/users/lyft/followers","following_url":"https://api.github.com/users/lyft/following{/other_user}","gists_url":"https://api.github.com/users/lyft/gists{/gist_id}","starred_url":"https://api.github.com/users/lyft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyft/subscriptions","organizations_url":"https://api.github.com/users/lyft/orgs","repos_url":"https://api.github.com/users/lyft/repos","events_url":"https://api.github.com/users/lyft/events{/privacy}","received_events_url":"https://api.github.com/users/lyft/received_events","type":"Organization","site_admin":false},"repo":{"id":65214191,"name":"envoy","full_name":"lyft/envoy","owner":{"login":"lyft","id":4269340,"avatar_url":"https://avatars1.githubusercontent.com/u/4269340?v=3","gravatar_id":"","url":"https://api.github.com/users/lyft","html_url":"https://github.com/lyft","followers_url":"https://api.github.com/users/lyft/followers","following_url":"https://api.github.com/users/lyft/following{/other_user}","gists_url":"https://api.github.com/users/lyft/gists{/gist_id}","starred_url":"https://api.github.com/users/lyft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyft/subscriptions","organizations_url":"https://api.github.com/users/lyft/orgs","repos_url":"https://api.github.com/users/lyft/repos","events_url":"https://api.github.com/users/lyft/events{/privacy}","received_events_url":"https://api.github.com/users/lyft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lyft/envoy","description":"C++ front/service proxy","fork":false,"url":"https://api.github.com/repos/lyft/envoy","forks_url":"https://api.github.com/repos/lyft/envoy/forks","keys_url":"https://api.github.com/repos/lyft/envoy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lyft/envoy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lyft/envoy/teams","hooks_url":"https://api.github.com/repos/lyft/envoy/hooks","issue_events_url":"https://api.github.com/repos/lyft/envoy/issues/events{/number}","events_url":"https://api.github.com/repos/lyft/envoy/events","assignees_url":"https://api.github.com/repos/lyft/envoy/assignees{/user}","branches_url":"https://api.github.com/repos/lyft/envoy/branches{/branch}","tags_url":"https://api.github.com/repos/lyft/envoy/tags","blobs_url":"https://api.github.com/repos/lyft/envoy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lyft/envoy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lyft/envoy/git/refs{/sha}","trees_url":"https://api.github.com/repos/lyft/envoy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lyft/envoy/statuses/{sha}","languages_url":"https://api.github.com/repos/lyft/envoy/languages","stargazers_url":"https://api.github.com/repos/lyft/envoy/stargazers","contributors_url":"https://api.github.com/repos/lyft/envoy/contributors","subscribers_url":"https://api.github.com/repos/lyft/envoy/subscribers","subscription_url":"https://api.github.com/repos/lyft/envoy/subscription","commits_url":"https://api.github.com/repos/lyft/envoy/commits{/sha}","git_commits_url":"https://api.github.com/repos/lyft/envoy/git/commits{/sha}","comments_url":"https://api.github.com/repos/lyft/envoy/comments{/number}","issue_comment_url":"https://api.github.com/repos/lyft/envoy/issues/comments{/number}","contents_url":"https://api.github.com/repos/lyft/envoy/contents/{+path}","compare_url":"https://api.github.com/repos/lyft/envoy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lyft/envoy/merges","archive_url":"https://api.github.com/repos/lyft/envoy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lyft/envoy/downloads","issues_url":"https://api.github.com/repos/lyft/envoy/issues{/number}","pulls_url":"https://api.github.com/repos/lyft/envoy/pulls{/number}","milestones_url":"https://api.github.com/repos/lyft/envoy/milestones{/number}","notifications_url":"https://api.github.com/repos/lyft/envoy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lyft/envoy/labels{/name}","releases_url":"https://api.github.com/repos/lyft/envoy/releases{/id}","deployments_url":"https://api.github.com/repos/lyft/envoy/deployments","created_at":"2016-08-08T15:07:24Z","updated_at":"2017-03-20T12:12:24Z","pushed_at":"2017-03-20T21:43:13Z","git_url":"git://github.com/lyft/envoy.git","ssh_url":"git@github.com:lyft/envoy.git","clone_url":"https://github.com/lyft/envoy.git","svn_url":"https://github.com/lyft/envoy","homepage":"https://lyft.github.io/envoy","size":10622,"stargazers_count":958,"watchers_count":958,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":97,"mirror_url":null,"open_issues_count":78,"forks":97,"open_issues":78,"watchers":958,"default_branch":"master"}},"base":{"label":"lyft:master","ref":"master","sha":"fca5cd56f9e4d70f5b3b6af8eeef5b8eebd1661f","user":{"login":"lyft","id":4269340,"avatar_url":"https://avatars1.githubusercontent.com/u/4269340?v=3","gravatar_id":"","url":"https://api.github.com/users/lyft","html_url":"https://github.com/lyft","followers_url":"https://api.github.com/users/lyft/followers","following_url":"https://api.github.com/users/lyft/following{/other_user}","gists_url":"https://api.github.com/users/lyft/gists{/gist_id}","starred_url":"https://api.github.com/users/lyft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyft/subscriptions","organizations_url":"https://api.github.com/users/lyft/orgs","repos_url":"https://api.github.com/users/lyft/repos","events_url":"https://api.github.com/users/lyft/events{/privacy}","received_events_url":"https://api.github.com/users/lyft/received_events","type":"Organization","site_admin":false},"repo":{"id":65214191,"name":"envoy","full_name":"lyft/envoy","owner":{"login":"lyft","id":4269340,"avatar_url":"https://avatars1.githubusercontent.com/u/4269340?v=3","gravatar_id":"","url":"https://api.github.com/users/lyft","html_url":"https://github.com/lyft","followers_url":"https://api.github.com/users/lyft/followers","following_url":"https://api.github.com/users/lyft/following{/other_user}","gists_url":"https://api.github.com/users/lyft/gists{/gist_id}","starred_url":"https://api.github.com/users/lyft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyft/subscriptions","organizations_url":"https://api.github.com/users/lyft/orgs","repos_url":"https://api.github.com/users/lyft/repos","events_url":"https://api.github.com/users/lyft/events{/privacy}","received_events_url":"https://api.github.com/users/lyft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lyft/envoy","description":"C++ front/service proxy","fork":false,"url":"https://api.github.com/repos/lyft/envoy","forks_url":"https://api.github.com/repos/lyft/envoy/forks","keys_url":"https://api.github.com/repos/lyft/envoy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lyft/envoy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lyft/envoy/teams","hooks_url":"https://api.github.com/repos/lyft/envoy/hooks","issue_events_url":"https://api.github.com/repos/lyft/envoy/issues/events{/number}","events_url":"https://api.github.com/repos/lyft/envoy/events","assignees_url":"https://api.github.com/repos/lyft/envoy/assignees{/user}","branches_url":"https://api.github.com/repos/lyft/envoy/branches{/branch}","tags_url":"https://api.github.com/repos/lyft/envoy/tags","blobs_url":"https://api.github.com/repos/lyft/envoy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lyft/envoy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lyft/envoy/git/refs{/sha}","trees_url":"https://api.github.com/repos/lyft/envoy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lyft/envoy/statuses/{sha}","languages_url":"https://api.github.com/repos/lyft/envoy/languages","stargazers_url":"https://api.github.com/repos/lyft/envoy/stargazers","contributors_url":"https://api.github.com/repos/lyft/envoy/contributors","subscribers_url":"https://api.github.com/repos/lyft/envoy/subscribers","subscription_url":"https://api.github.com/repos/lyft/envoy/subscription","commits_url":"https://api.github.com/repos/lyft/envoy/commits{/sha}","git_commits_url":"https://api.github.com/repos/lyft/envoy/git/commits{/sha}","comments_url":"https://api.github.com/repos/lyft/envoy/comments{/number}","issue_comment_url":"https://api.github.com/repos/lyft/envoy/issues/comments{/number}","contents_url":"https://api.github.com/repos/lyft/envoy/contents/{+path}","compare_url":"https://api.github.com/repos/lyft/envoy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lyft/envoy/merges","archive_url":"https://api.github.com/repos/lyft/envoy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lyft/envoy/downloads","issues_url":"https://api.github.com/repos/lyft/envoy/issues{/number}","pulls_url":"https://api.github.com/repos/lyft/envoy/pulls{/number}","milestones_url":"https://api.github.com/repos/lyft/envoy/milestones{/number}","notifications_url":"https://api.github.com/repos/lyft/envoy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lyft/envoy/labels{/name}","releases_url":"https://api.github.com/repos/lyft/envoy/releases{/id}","deployments_url":"https://api.github.com/repos/lyft/envoy/deployments","created_at":"2016-08-08T15:07:24Z","updated_at":"2017-03-20T12:12:24Z","pushed_at":"2017-03-20T21:43:13Z","git_url":"git://github.com/lyft/envoy.git","ssh_url":"git@github.com:lyft/envoy.git","clone_url":"https://github.com/lyft/envoy.git","svn_url":"https://github.com/lyft/envoy","homepage":"https://lyft.github.io/envoy","size":10622,"stargazers_count":958,"watchers_count":958,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":97,"mirror_url":null,"open_issues_count":78,"forks":97,"open_issues":78,"watchers":958,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lyft/envoy/pulls/546"},"html":{"href":"https://github.com/lyft/envoy/pull/546"},"issue":{"href":"https://api.github.com/repos/lyft/envoy/issues/546"},"comments":{"href":"https://api.github.com/repos/lyft/envoy/issues/546/comments"},"review_comments":{"href":"https://api.github.com/repos/lyft/envoy/pulls/546/comments"},"review_comment":{"href":"https://api.github.com/repos/lyft/envoy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lyft/envoy/pulls/546/commits"},"statuses":{"href":"https://api.github.com/repos/lyft/envoy/statuses/77b407b074418ff9dffdf6336e67c25c1ba6a7d3"}}}}
{"actor":{"display_login":"ccaraman"}}