{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleChrome/puppeteer/pulls/comments/157340476","pull_request_review_id":83973182,"id":157340476,"diff_hunk":"@@ -593,6 +594,12 @@ If URLs are specified, only cookies for those URLs are returned.\n   - `secure` <[boolean]>\n - returns: <[Promise]>\n \n+#### page.disableCache(disabled)","path":"docs/api.md","position":null,"original_position":12,"commit_id":"8aa14a95473ba6b74976a7a2a596e51c47ef61a3","original_commit_id":"c4c512a7ae1b92a13dc0895c66882ba7bc449811","user":{"login":"andrewwwcollins","id":20781479,"avatar_url":"https://avatars2.githubusercontent.com/u/20781479?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewwwcollins","html_url":"https://github.com/andrewwwcollins","followers_url":"https://api.github.com/users/andrewwwcollins/followers","following_url":"https://api.github.com/users/andrewwwcollins/following{/other_user}","gists_url":"https://api.github.com/users/andrewwwcollins/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewwwcollins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewwwcollins/subscriptions","organizations_url":"https://api.github.com/users/andrewwwcollins/orgs","repos_url":"https://api.github.com/users/andrewwwcollins/repos","events_url":"https://api.github.com/users/andrewwwcollins/events{/privacy}","received_events_url":"https://api.github.com/users/andrewwwcollins/received_events","type":"User","site_admin":false},"body":"I have made these changes 👍 ","created_at":"2017-12-16T11:48:48Z","updated_at":"2017-12-16T11:48:48Z","html_url":"https://github.com/GoogleChrome/puppeteer/pull/1609#discussion_r157340476","pull_request_url":"https://api.github.com/repos/GoogleChrome/puppeteer/pulls/1609","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/GoogleChrome/puppeteer/pulls/comments/157340476"},"html":{"href":"https://github.com/GoogleChrome/puppeteer/pull/1609#discussion_r157340476"},"pull_request":{"href":"https://api.github.com/repos/GoogleChrome/puppeteer/pulls/1609"}},"in_reply_to_id":157312071},"pull_request":{"url":"https://api.github.com/repos/GoogleChrome/puppeteer/pulls/1609","id":158597045,"html_url":"https://github.com/GoogleChrome/puppeteer/pull/1609","diff_url":"https://github.com/GoogleChrome/puppeteer/pull/1609.diff","patch_url":"https://github.com/GoogleChrome/puppeteer/pull/1609.patch","issue_url":"https://api.github.com/repos/GoogleChrome/puppeteer/issues/1609","number":1609,"state":"open","locked":false,"title":"feat(Page): add `setCacheEnabled(enabled)` to Page object","user":{"login":"andrewwwcollins","id":20781479,"avatar_url":"https://avatars2.githubusercontent.com/u/20781479?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewwwcollins","html_url":"https://github.com/andrewwwcollins","followers_url":"https://api.github.com/users/andrewwwcollins/followers","following_url":"https://api.github.com/users/andrewwwcollins/following{/other_user}","gists_url":"https://api.github.com/users/andrewwwcollins/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewwwcollins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewwwcollins/subscriptions","organizations_url":"https://api.github.com/users/andrewwwcollins/orgs","repos_url":"https://api.github.com/users/andrewwwcollins/repos","events_url":"https://api.github.com/users/andrewwwcollins/events{/privacy}","received_events_url":"https://api.github.com/users/andrewwwcollins/received_events","type":"User","site_admin":false},"body":"Fixes: #1556 \r\n\r\nImplements `Page.disableCache(disabled)` method. Dependent/blocked on https://github.com/GoogleChrome/puppeteer/pull/1601 as it uses `fromDiskCache` to test page.","created_at":"2017-12-15T12:55:16Z","updated_at":"2017-12-16T11:48:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b88af4560c3f05628ce0e3278ab3f9213a9e8881","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleChrome/puppeteer/pulls/1609/commits","review_comments_url":"https://api.github.com/repos/GoogleChrome/puppeteer/pulls/1609/comments","review_comment_url":"https://api.github.com/repos/GoogleChrome/puppeteer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleChrome/puppeteer/issues/1609/comments","statuses_url":"https://api.github.com/repos/GoogleChrome/puppeteer/statuses/8aa14a95473ba6b74976a7a2a596e51c47ef61a3","head":{"label":"andrewwwcollins:1556","ref":"1556","sha":"8aa14a95473ba6b74976a7a2a596e51c47ef61a3","user":{"login":"andrewwwcollins","id":20781479,"avatar_url":"https://avatars2.githubusercontent.com/u/20781479?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewwwcollins","html_url":"https://github.com/andrewwwcollins","followers_url":"https://api.github.com/users/andrewwwcollins/followers","following_url":"https://api.github.com/users/andrewwwcollins/following{/other_user}","gists_url":"https://api.github.com/users/andrewwwcollins/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewwwcollins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewwwcollins/subscriptions","organizations_url":"https://api.github.com/users/andrewwwcollins/orgs","repos_url":"https://api.github.com/users/andrewwwcollins/repos","events_url":"https://api.github.com/users/andrewwwcollins/events{/privacy}","received_events_url":"https://api.github.com/users/andrewwwcollins/received_events","type":"User","site_admin":false},"repo":{"id":114282757,"name":"puppeteer","full_name":"andrewwwcollins/puppeteer","owner":{"login":"andrewwwcollins","id":20781479,"avatar_url":"https://avatars2.githubusercontent.com/u/20781479?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewwwcollins","html_url":"https://github.com/andrewwwcollins","followers_url":"https://api.github.com/users/andrewwwcollins/followers","following_url":"https://api.github.com/users/andrewwwcollins/following{/other_user}","gists_url":"https://api.github.com/users/andrewwwcollins/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewwwcollins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewwwcollins/subscriptions","organizations_url":"https://api.github.com/users/andrewwwcollins/orgs","repos_url":"https://api.github.com/users/andrewwwcollins/repos","events_url":"https://api.github.com/users/andrewwwcollins/events{/privacy}","received_events_url":"https://api.github.com/users/andrewwwcollins/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andrewwwcollins/puppeteer","description":"Headless Chrome Node API","fork":true,"url":"https://api.github.com/repos/andrewwwcollins/puppeteer","forks_url":"https://api.github.com/repos/andrewwwcollins/puppeteer/forks","keys_url":"https://api.github.com/repos/andrewwwcollins/puppeteer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andrewwwcollins/puppeteer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andrewwwcollins/puppeteer/teams","hooks_url":"https://api.github.com/repos/andrewwwcollins/puppeteer/hooks","issue_events_url":"https://api.github.com/repos/andrewwwcollins/puppeteer/issues/events{/number}","events_url":"https://api.github.com/repos/andrewwwcollins/puppeteer/events","assignees_url":"https://api.github.com/repos/andrewwwcollins/puppeteer/assignees{/user}","branches_url":"https://api.github.com/repos/andrewwwcollins/puppeteer/branches{/branch}","tags_url":"https://api.github.com/repos/andrewwwcollins/puppeteer/tags","blobs_url":"https://api.github.com/repos/andrewwwcollins/puppeteer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andrewwwcollins/puppeteer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andrewwwcollins/puppeteer/git/refs{/sha}","trees_url":"https://api.github.com/repos/andrewwwcollins/puppeteer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andrewwwcollins/puppeteer/statuses/{sha}","languages_url":"https://api.github.com/repos/andrewwwcollins/puppeteer/languages","stargazers_url":"https://api.github.com/repos/andrewwwcollins/puppeteer/stargazers","contributors_url":"https://api.github.com/repos/andrewwwcollins/puppeteer/contributors","subscribers_url":"https://api.github.com/repos/andrewwwcollins/puppeteer/subscribers","subscription_url":"https://api.github.com/repos/andrewwwcollins/puppeteer/subscription","commits_url":"https://api.github.com/repos/andrewwwcollins/puppeteer/commits{/sha}","git_commits_url":"https://api.github.com/repos/andrewwwcollins/puppeteer/git/commits{/sha}","comments_url":"https://api.github.com/repos/andrewwwcollins/puppeteer/comments{/number}","issue_comment_url":"https://api.github.com/repos/andrewwwcollins/puppeteer/issues/comments{/number}","contents_url":"https://api.github.com/repos/andrewwwcollins/puppeteer/contents/{+path}","compare_url":"https://api.github.com/repos/andrewwwcollins/puppeteer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andrewwwcollins/puppeteer/merges","archive_url":"https://api.github.com/repos/andrewwwcollins/puppeteer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andrewwwcollins/puppeteer/downloads","issues_url":"https://api.github.com/repos/andrewwwcollins/puppeteer/issues{/number}","pulls_url":"https://api.github.com/repos/andrewwwcollins/puppeteer/pulls{/number}","milestones_url":"https://api.github.com/repos/andrewwwcollins/puppeteer/milestones{/number}","notifications_url":"https://api.github.com/repos/andrewwwcollins/puppeteer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andrewwwcollins/puppeteer/labels{/name}","releases_url":"https://api.github.com/repos/andrewwwcollins/puppeteer/releases{/id}","deployments_url":"https://api.github.com/repos/andrewwwcollins/puppeteer/deployments","created_at":"2017-12-14T18:22:28Z","updated_at":"2017-12-14T18:22:30Z","pushed_at":"2017-12-16T11:43:57Z","git_url":"git://github.com/andrewwwcollins/puppeteer.git","ssh_url":"git@github.com:andrewwwcollins/puppeteer.git","clone_url":"https://github.com/andrewwwcollins/puppeteer.git","svn_url":"https://github.com/andrewwwcollins/puppeteer","homepage":"","size":2833,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleChrome:master","ref":"master","sha":"18d5cfa2693040fd7ee7996d60bbb6694339599a","user":{"login":"GoogleChrome","id":1778935,"avatar_url":"https://avatars3.githubusercontent.com/u/1778935?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleChrome","html_url":"https://github.com/GoogleChrome","followers_url":"https://api.github.com/users/GoogleChrome/followers","following_url":"https://api.github.com/users/GoogleChrome/following{/other_user}","gists_url":"https://api.github.com/users/GoogleChrome/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleChrome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleChrome/subscriptions","organizations_url":"https://api.github.com/users/GoogleChrome/orgs","repos_url":"https://api.github.com/users/GoogleChrome/repos","events_url":"https://api.github.com/users/GoogleChrome/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleChrome/received_events","type":"Organization","site_admin":false},"repo":{"id":90796663,"name":"puppeteer","full_name":"GoogleChrome/puppeteer","owner":{"login":"GoogleChrome","id":1778935,"avatar_url":"https://avatars3.githubusercontent.com/u/1778935?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleChrome","html_url":"https://github.com/GoogleChrome","followers_url":"https://api.github.com/users/GoogleChrome/followers","following_url":"https://api.github.com/users/GoogleChrome/following{/other_user}","gists_url":"https://api.github.com/users/GoogleChrome/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleChrome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleChrome/subscriptions","organizations_url":"https://api.github.com/users/GoogleChrome/orgs","repos_url":"https://api.github.com/users/GoogleChrome/repos","events_url":"https://api.github.com/users/GoogleChrome/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleChrome/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleChrome/puppeteer","description":"Headless Chrome Node API","fork":false,"url":"https://api.github.com/repos/GoogleChrome/puppeteer","forks_url":"https://api.github.com/repos/GoogleChrome/puppeteer/forks","keys_url":"https://api.github.com/repos/GoogleChrome/puppeteer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleChrome/puppeteer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleChrome/puppeteer/teams","hooks_url":"https://api.github.com/repos/GoogleChrome/puppeteer/hooks","issue_events_url":"https://api.github.com/repos/GoogleChrome/puppeteer/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleChrome/puppeteer/events","assignees_url":"https://api.github.com/repos/GoogleChrome/puppeteer/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleChrome/puppeteer/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleChrome/puppeteer/tags","blobs_url":"https://api.github.com/repos/GoogleChrome/puppeteer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleChrome/puppeteer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleChrome/puppeteer/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleChrome/puppeteer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleChrome/puppeteer/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleChrome/puppeteer/languages","stargazers_url":"https://api.github.com/repos/GoogleChrome/puppeteer/stargazers","contributors_url":"https://api.github.com/repos/GoogleChrome/puppeteer/contributors","subscribers_url":"https://api.github.com/repos/GoogleChrome/puppeteer/subscribers","subscription_url":"https://api.github.com/repos/GoogleChrome/puppeteer/subscription","commits_url":"https://api.github.com/repos/GoogleChrome/puppeteer/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleChrome/puppeteer/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleChrome/puppeteer/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleChrome/puppeteer/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleChrome/puppeteer/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleChrome/puppeteer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleChrome/puppeteer/merges","archive_url":"https://api.github.com/repos/GoogleChrome/puppeteer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleChrome/puppeteer/downloads","issues_url":"https://api.github.com/repos/GoogleChrome/puppeteer/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleChrome/puppeteer/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleChrome/puppeteer/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleChrome/puppeteer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleChrome/puppeteer/labels{/name}","releases_url":"https://api.github.com/repos/GoogleChrome/puppeteer/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleChrome/puppeteer/deployments","created_at":"2017-05-09T22:16:13Z","updated_at":"2017-12-16T11:45:54Z","pushed_at":"2017-12-16T11:43:58Z","git_url":"git://github.com/GoogleChrome/puppeteer.git","ssh_url":"git@github.com:GoogleChrome/puppeteer.git","clone_url":"https://github.com/GoogleChrome/puppeteer.git","svn_url":"https://github.com/GoogleChrome/puppeteer","homepage":"","size":2828,"stargazers_count":20937,"watchers_count":20937,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1150,"mirror_url":null,"archived":false,"open_issues_count":252,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1150,"open_issues":252,"watchers":20937,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleChrome/puppeteer/pulls/1609"},"html":{"href":"https://github.com/GoogleChrome/puppeteer/pull/1609"},"issue":{"href":"https://api.github.com/repos/GoogleChrome/puppeteer/issues/1609"},"comments":{"href":"https://api.github.com/repos/GoogleChrome/puppeteer/issues/1609/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleChrome/puppeteer/pulls/1609/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleChrome/puppeteer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleChrome/puppeteer/pulls/1609/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleChrome/puppeteer/statuses/8aa14a95473ba6b74976a7a2a596e51c47ef61a3"}},"author_association":"NONE"}}
{"actor":{"display_login":"andrewwwcollins"}}