{"action":"created","issue":{"url":"https://api.github.com/repos/schismtracker/schismtracker/issues/87","repository_url":"https://api.github.com/repos/schismtracker/schismtracker","labels_url":"https://api.github.com/repos/schismtracker/schismtracker/issues/87/labels{/name}","comments_url":"https://api.github.com/repos/schismtracker/schismtracker/issues/87/comments","events_url":"https://api.github.com/repos/schismtracker/schismtracker/issues/87/events","html_url":"https://github.com/schismtracker/schismtracker/pull/87","id":236403136,"number":87,"title":"schism/page_loadinst: stop swallowing KEY_PRESS","user":{"login":"vcaputo","id":1452963,"avatar_url":"https://avatars2.githubusercontent.com/u/1452963?v=3","gravatar_id":"","url":"https://api.github.com/users/vcaputo","html_url":"https://github.com/vcaputo","followers_url":"https://api.github.com/users/vcaputo/followers","following_url":"https://api.github.com/users/vcaputo/following{/other_user}","gists_url":"https://api.github.com/users/vcaputo/gists{/gist_id}","starred_url":"https://api.github.com/users/vcaputo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vcaputo/subscriptions","organizations_url":"https://api.github.com/users/vcaputo/orgs","repos_url":"https://api.github.com/users/vcaputo/repos","events_url":"https://api.github.com/users/vcaputo/events{/privacy}","received_events_url":"https://api.github.com/users/vcaputo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-06-16T07:32:29Z","updated_at":"2017-06-16T13:38:41Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/schismtracker/schismtracker/pulls/87","html_url":"https://github.com/schismtracker/schismtracker/pull/87","diff_url":"https://github.com/schismtracker/schismtracker/pull/87.diff","patch_url":"https://github.com/schismtracker/schismtracker/pull/87.patch"},"body":"For some reason the code was short-circuiting on k->state == KEY_PRESS\r\nin a k->mouse state default/fall-through case.  This prevented regular\r\nkey press/repeat handling from functioning on the loadinst page.\r\n\r\nFixes https://github.com/schismtracker/schismtracker/issues/86"},"comment":{"url":"https://api.github.com/repos/schismtracker/schismtracker/issues/comments/309028451","html_url":"https://github.com/schismtracker/schismtracker/pull/87#issuecomment-309028451","issue_url":"https://api.github.com/repos/schismtracker/schismtracker/issues/87","id":309028451,"user":{"login":"jangler","id":1653421,"avatar_url":"https://avatars3.githubusercontent.com/u/1653421?v=3","gravatar_id":"","url":"https://api.github.com/users/jangler","html_url":"https://github.com/jangler","followers_url":"https://api.github.com/users/jangler/followers","following_url":"https://api.github.com/users/jangler/following{/other_user}","gists_url":"https://api.github.com/users/jangler/gists{/gist_id}","starred_url":"https://api.github.com/users/jangler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jangler/subscriptions","organizations_url":"https://api.github.com/users/jangler/orgs","repos_url":"https://api.github.com/users/jangler/repos","events_url":"https://api.github.com/users/jangler/events{/privacy}","received_events_url":"https://api.github.com/users/jangler/received_events","type":"User","site_admin":false},"created_at":"2017-06-16T13:38:41Z","updated_at":"2017-06-16T13:38:41Z","body":"I hate that the logic for load file screens is duplicated in the first place… there are a few other minor inconsistencies in the code, including superfluous conditionals and statements.\r\n\r\nI think that the lines of code in question are actually supposed to check against `KEY_RELEASE`, [like they do in `schism/page_loadsample.c`](https://github.com/schismtracker/schismtracker/blob/master/schism/page_loadsample.c#L734-L736). Haven't looked at the full implications of this, though. Might be redundant?"}}
{"actor":{"display_login":"jangler"}}