{"action":"created","comment":{"url":"https://api.github.com/repos/patternfly/angular-patternfly/pulls/comments/104626512","pull_request_review_id":25469831,"id":104626512,"diff_hunk":"@@ -136,6 +138,13 @@ angular.module('patternfly.table').component('pfTableView', {\n         selectRowsByChecked();\n         //});\n       }\n+      if (!angular.equals(ctrl.colvis, prevColvis)) {\n+        if (ctrl.debug) {\n+          $log.debug(\"  colvis !== prevColvis\");\n+        }","path":"src/table/tableview/table-view.component.js","position":32,"original_position":32,"commit_id":"c5476be6c4f427a4fd8a89b95998af08a591ac31","original_commit_id":"c5476be6c4f427a4fd8a89b95998af08a591ac31","user":{"login":"dabeng","id":5689075,"avatar_url":"https://avatars2.githubusercontent.com/u/5689075?v=3","gravatar_id":"","url":"https://api.github.com/users/dabeng","html_url":"https://github.com/dabeng","followers_url":"https://api.github.com/users/dabeng/followers","following_url":"https://api.github.com/users/dabeng/following{/other_user}","gists_url":"https://api.github.com/users/dabeng/gists{/gist_id}","starred_url":"https://api.github.com/users/dabeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dabeng/subscriptions","organizations_url":"https://api.github.com/users/dabeng/orgs","repos_url":"https://api.github.com/users/dabeng/repos","events_url":"https://api.github.com/users/dabeng/events{/privacy}","received_events_url":"https://api.github.com/users/dabeng/received_events","type":"User","site_admin":false},"body":"got it","created_at":"2017-03-07T09:47:38Z","updated_at":"2017-03-07T09:47:38Z","html_url":"https://github.com/patternfly/angular-patternfly/pull/427#discussion_r104626512","pull_request_url":"https://api.github.com/repos/patternfly/angular-patternfly/pulls/427","_links":{"self":{"href":"https://api.github.com/repos/patternfly/angular-patternfly/pulls/comments/104626512"},"html":{"href":"https://github.com/patternfly/angular-patternfly/pull/427#discussion_r104626512"},"pull_request":{"href":"https://api.github.com/repos/patternfly/angular-patternfly/pulls/427"}}},"pull_request":{"url":"https://api.github.com/repos/patternfly/angular-patternfly/pulls/427","id":109199652,"html_url":"https://github.com/patternfly/angular-patternfly/pull/427","diff_url":"https://github.com/patternfly/angular-patternfly/pull/427.diff","patch_url":"https://github.com/patternfly/angular-patternfly/pull/427.patch","issue_url":"https://api.github.com/repos/patternfly/angular-patternfly/issues/427","number":427,"state":"open","locked":false,"title":"Table View: Hide/Show Columns - AngularJS","user":{"login":"dabeng","id":5689075,"avatar_url":"https://avatars2.githubusercontent.com/u/5689075?v=3","gravatar_id":"","url":"https://api.github.com/users/dabeng","html_url":"https://github.com/dabeng","followers_url":"https://api.github.com/users/dabeng/followers","following_url":"https://api.github.com/users/dabeng/following{/other_user}","gists_url":"https://api.github.com/users/dabeng/gists{/gist_id}","starred_url":"https://api.github.com/users/dabeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dabeng/subscriptions","organizations_url":"https://api.github.com/users/dabeng/orgs","repos_url":"https://api.github.com/users/dabeng/repos","events_url":"https://api.github.com/users/dabeng/events{/privacy}","received_events_url":"https://api.github.com/users/dabeng/received_events","type":"User","site_admin":false},"body":"This is Hide/Show Columns feature of angular-datatables which behaves like the recommended PatternFly pattern.\r\n\r\nThis PR will add colvis dropdown menu to pfToolbar and pfTableView - with Toolbar.\r\n\r\n@bleathem @jeff-phillips-18 , would you like to review it?","created_at":"2017-03-06T06:55:05Z","updated_at":"2017-03-07T09:47:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2e517c6eee641e832ed67fb50001c31ab942c5b1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/patternfly/angular-patternfly/pulls/427/commits","review_comments_url":"https://api.github.com/repos/patternfly/angular-patternfly/pulls/427/comments","review_comment_url":"https://api.github.com/repos/patternfly/angular-patternfly/pulls/comments{/number}","comments_url":"https://api.github.com/repos/patternfly/angular-patternfly/issues/427/comments","statuses_url":"https://api.github.com/repos/patternfly/angular-patternfly/statuses/c5476be6c4f427a4fd8a89b95998af08a591ac31","head":{"label":"dabeng:tv-colvis","ref":"tv-colvis","sha":"c5476be6c4f427a4fd8a89b95998af08a591ac31","user":{"login":"dabeng","id":5689075,"avatar_url":"https://avatars2.githubusercontent.com/u/5689075?v=3","gravatar_id":"","url":"https://api.github.com/users/dabeng","html_url":"https://github.com/dabeng","followers_url":"https://api.github.com/users/dabeng/followers","following_url":"https://api.github.com/users/dabeng/following{/other_user}","gists_url":"https://api.github.com/users/dabeng/gists{/gist_id}","starred_url":"https://api.github.com/users/dabeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dabeng/subscriptions","organizations_url":"https://api.github.com/users/dabeng/orgs","repos_url":"https://api.github.com/users/dabeng/repos","events_url":"https://api.github.com/users/dabeng/events{/privacy}","received_events_url":"https://api.github.com/users/dabeng/received_events","type":"User","site_admin":false},"repo":{"id":81313430,"name":"angular-patternfly","full_name":"dabeng/angular-patternfly","owner":{"login":"dabeng","id":5689075,"avatar_url":"https://avatars2.githubusercontent.com/u/5689075?v=3","gravatar_id":"","url":"https://api.github.com/users/dabeng","html_url":"https://github.com/dabeng","followers_url":"https://api.github.com/users/dabeng/followers","following_url":"https://api.github.com/users/dabeng/following{/other_user}","gists_url":"https://api.github.com/users/dabeng/gists{/gist_id}","starred_url":"https://api.github.com/users/dabeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dabeng/subscriptions","organizations_url":"https://api.github.com/users/dabeng/orgs","repos_url":"https://api.github.com/users/dabeng/repos","events_url":"https://api.github.com/users/dabeng/events{/privacy}","received_events_url":"https://api.github.com/users/dabeng/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dabeng/angular-patternfly","description":"A set of common AngularJS directives for use with the PatternFly reference implementation.","fork":true,"url":"https://api.github.com/repos/dabeng/angular-patternfly","forks_url":"https://api.github.com/repos/dabeng/angular-patternfly/forks","keys_url":"https://api.github.com/repos/dabeng/angular-patternfly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dabeng/angular-patternfly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dabeng/angular-patternfly/teams","hooks_url":"https://api.github.com/repos/dabeng/angular-patternfly/hooks","issue_events_url":"https://api.github.com/repos/dabeng/angular-patternfly/issues/events{/number}","events_url":"https://api.github.com/repos/dabeng/angular-patternfly/events","assignees_url":"https://api.github.com/repos/dabeng/angular-patternfly/assignees{/user}","branches_url":"https://api.github.com/repos/dabeng/angular-patternfly/branches{/branch}","tags_url":"https://api.github.com/repos/dabeng/angular-patternfly/tags","blobs_url":"https://api.github.com/repos/dabeng/angular-patternfly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dabeng/angular-patternfly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dabeng/angular-patternfly/git/refs{/sha}","trees_url":"https://api.github.com/repos/dabeng/angular-patternfly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dabeng/angular-patternfly/statuses/{sha}","languages_url":"https://api.github.com/repos/dabeng/angular-patternfly/languages","stargazers_url":"https://api.github.com/repos/dabeng/angular-patternfly/stargazers","contributors_url":"https://api.github.com/repos/dabeng/angular-patternfly/contributors","subscribers_url":"https://api.github.com/repos/dabeng/angular-patternfly/subscribers","subscription_url":"https://api.github.com/repos/dabeng/angular-patternfly/subscription","commits_url":"https://api.github.com/repos/dabeng/angular-patternfly/commits{/sha}","git_commits_url":"https://api.github.com/repos/dabeng/angular-patternfly/git/commits{/sha}","comments_url":"https://api.github.com/repos/dabeng/angular-patternfly/comments{/number}","issue_comment_url":"https://api.github.com/repos/dabeng/angular-patternfly/issues/comments{/number}","contents_url":"https://api.github.com/repos/dabeng/angular-patternfly/contents/{+path}","compare_url":"https://api.github.com/repos/dabeng/angular-patternfly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dabeng/angular-patternfly/merges","archive_url":"https://api.github.com/repos/dabeng/angular-patternfly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dabeng/angular-patternfly/downloads","issues_url":"https://api.github.com/repos/dabeng/angular-patternfly/issues{/number}","pulls_url":"https://api.github.com/repos/dabeng/angular-patternfly/pulls{/number}","milestones_url":"https://api.github.com/repos/dabeng/angular-patternfly/milestones{/number}","notifications_url":"https://api.github.com/repos/dabeng/angular-patternfly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dabeng/angular-patternfly/labels{/name}","releases_url":"https://api.github.com/repos/dabeng/angular-patternfly/releases{/id}","deployments_url":"https://api.github.com/repos/dabeng/angular-patternfly/deployments","created_at":"2017-02-08T09:43:58Z","updated_at":"2017-02-08T09:44:00Z","pushed_at":"2017-03-06T06:32:09Z","git_url":"git://github.com/dabeng/angular-patternfly.git","ssh_url":"git@github.com:dabeng/angular-patternfly.git","clone_url":"https://github.com/dabeng/angular-patternfly.git","svn_url":"https://github.com/dabeng/angular-patternfly","homepage":"http://www.patternfly.org/angular-patternfly/","size":8621,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"patternfly:branch-4.0-dev","ref":"branch-4.0-dev","sha":"dec3c1e1bb4f96443fce5546a2b5410f680d8ae1","user":{"login":"patternfly","id":6391110,"avatar_url":"https://avatars0.githubusercontent.com/u/6391110?v=3","gravatar_id":"","url":"https://api.github.com/users/patternfly","html_url":"https://github.com/patternfly","followers_url":"https://api.github.com/users/patternfly/followers","following_url":"https://api.github.com/users/patternfly/following{/other_user}","gists_url":"https://api.github.com/users/patternfly/gists{/gist_id}","starred_url":"https://api.github.com/users/patternfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patternfly/subscriptions","organizations_url":"https://api.github.com/users/patternfly/orgs","repos_url":"https://api.github.com/users/patternfly/repos","events_url":"https://api.github.com/users/patternfly/events{/privacy}","received_events_url":"https://api.github.com/users/patternfly/received_events","type":"Organization","site_admin":false},"repo":{"id":17672427,"name":"angular-patternfly","full_name":"patternfly/angular-patternfly","owner":{"login":"patternfly","id":6391110,"avatar_url":"https://avatars0.githubusercontent.com/u/6391110?v=3","gravatar_id":"","url":"https://api.github.com/users/patternfly","html_url":"https://github.com/patternfly","followers_url":"https://api.github.com/users/patternfly/followers","following_url":"https://api.github.com/users/patternfly/following{/other_user}","gists_url":"https://api.github.com/users/patternfly/gists{/gist_id}","starred_url":"https://api.github.com/users/patternfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patternfly/subscriptions","organizations_url":"https://api.github.com/users/patternfly/orgs","repos_url":"https://api.github.com/users/patternfly/repos","events_url":"https://api.github.com/users/patternfly/events{/privacy}","received_events_url":"https://api.github.com/users/patternfly/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/patternfly/angular-patternfly","description":"A set of common AngularJS directives for use with the PatternFly reference implementation.","fork":false,"url":"https://api.github.com/repos/patternfly/angular-patternfly","forks_url":"https://api.github.com/repos/patternfly/angular-patternfly/forks","keys_url":"https://api.github.com/repos/patternfly/angular-patternfly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/patternfly/angular-patternfly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/patternfly/angular-patternfly/teams","hooks_url":"https://api.github.com/repos/patternfly/angular-patternfly/hooks","issue_events_url":"https://api.github.com/repos/patternfly/angular-patternfly/issues/events{/number}","events_url":"https://api.github.com/repos/patternfly/angular-patternfly/events","assignees_url":"https://api.github.com/repos/patternfly/angular-patternfly/assignees{/user}","branches_url":"https://api.github.com/repos/patternfly/angular-patternfly/branches{/branch}","tags_url":"https://api.github.com/repos/patternfly/angular-patternfly/tags","blobs_url":"https://api.github.com/repos/patternfly/angular-patternfly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/patternfly/angular-patternfly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/patternfly/angular-patternfly/git/refs{/sha}","trees_url":"https://api.github.com/repos/patternfly/angular-patternfly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/patternfly/angular-patternfly/statuses/{sha}","languages_url":"https://api.github.com/repos/patternfly/angular-patternfly/languages","stargazers_url":"https://api.github.com/repos/patternfly/angular-patternfly/stargazers","contributors_url":"https://api.github.com/repos/patternfly/angular-patternfly/contributors","subscribers_url":"https://api.github.com/repos/patternfly/angular-patternfly/subscribers","subscription_url":"https://api.github.com/repos/patternfly/angular-patternfly/subscription","commits_url":"https://api.github.com/repos/patternfly/angular-patternfly/commits{/sha}","git_commits_url":"https://api.github.com/repos/patternfly/angular-patternfly/git/commits{/sha}","comments_url":"https://api.github.com/repos/patternfly/angular-patternfly/comments{/number}","issue_comment_url":"https://api.github.com/repos/patternfly/angular-patternfly/issues/comments{/number}","contents_url":"https://api.github.com/repos/patternfly/angular-patternfly/contents/{+path}","compare_url":"https://api.github.com/repos/patternfly/angular-patternfly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/patternfly/angular-patternfly/merges","archive_url":"https://api.github.com/repos/patternfly/angular-patternfly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/patternfly/angular-patternfly/downloads","issues_url":"https://api.github.com/repos/patternfly/angular-patternfly/issues{/number}","pulls_url":"https://api.github.com/repos/patternfly/angular-patternfly/pulls{/number}","milestones_url":"https://api.github.com/repos/patternfly/angular-patternfly/milestones{/number}","notifications_url":"https://api.github.com/repos/patternfly/angular-patternfly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/patternfly/angular-patternfly/labels{/name}","releases_url":"https://api.github.com/repos/patternfly/angular-patternfly/releases{/id}","deployments_url":"https://api.github.com/repos/patternfly/angular-patternfly/deployments","created_at":"2014-03-12T15:43:51Z","updated_at":"2017-03-01T19:49:52Z","pushed_at":"2017-03-06T06:55:06Z","git_url":"git://github.com/patternfly/angular-patternfly.git","ssh_url":"git@github.com:patternfly/angular-patternfly.git","clone_url":"https://github.com/patternfly/angular-patternfly.git","svn_url":"https://github.com/patternfly/angular-patternfly","homepage":"http://www.patternfly.org/angular-patternfly/","size":12168,"stargazers_count":79,"watchers_count":79,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":65,"mirror_url":null,"open_issues_count":46,"forks":65,"open_issues":46,"watchers":79,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/patternfly/angular-patternfly/pulls/427"},"html":{"href":"https://github.com/patternfly/angular-patternfly/pull/427"},"issue":{"href":"https://api.github.com/repos/patternfly/angular-patternfly/issues/427"},"comments":{"href":"https://api.github.com/repos/patternfly/angular-patternfly/issues/427/comments"},"review_comments":{"href":"https://api.github.com/repos/patternfly/angular-patternfly/pulls/427/comments"},"review_comment":{"href":"https://api.github.com/repos/patternfly/angular-patternfly/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/patternfly/angular-patternfly/pulls/427/commits"},"statuses":{"href":"https://api.github.com/repos/patternfly/angular-patternfly/statuses/c5476be6c4f427a4fd8a89b95998af08a591ac31"}}}}
{"actor":{"display_login":"dabeng"}}