{"action":"created","comment":{"url":"https://api.github.com/repos/tensorflow/tensorboard/pulls/comments/136784778","pull_request_review_id":60370514,"id":136784778,"diff_hunk":"@@ -235,17 +235,26 @@ export class RenderGraphInfo {\n         .domain(memoryExtent)\n         .range(PARAMS.minMaxColors);\n \n-    // Find also the minimum and maximum compute time.\n-    let computeTimeExtent = d3.extent(topLevelGraph.nodes(),\n-        (nodeName, index) => {\n-      let node = topLevelGraph.node(nodeName);\n+    // Find the maximum and minimum compute time in the whole graph.","path":"tensorboard/plugins/graph/tf_graph_common/render.ts","position":8,"original_position":8,"commit_id":"a5d8f1679fa39be2bb890d276c71029ccc1d47b0","original_commit_id":"a5d8f1679fa39be2bb890d276c71029ccc1d47b0","user":{"login":"ioeric","id":1298701,"avatar_url":"https://avatars2.githubusercontent.com/u/1298701?v=4","gravatar_id":"","url":"https://api.github.com/users/ioeric","html_url":"https://github.com/ioeric","followers_url":"https://api.github.com/users/ioeric/followers","following_url":"https://api.github.com/users/ioeric/following{/other_user}","gists_url":"https://api.github.com/users/ioeric/gists{/gist_id}","starred_url":"https://api.github.com/users/ioeric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ioeric/subscriptions","organizations_url":"https://api.github.com/users/ioeric/orgs","repos_url":"https://api.github.com/users/ioeric/repos","events_url":"https://api.github.com/users/ioeric/events{/privacy}","received_events_url":"https://api.github.com/users/ioeric/received_events","type":"User","site_admin":false},"body":"I don't really have strong opinion as long as it works. I'll change the code to scale from 0.","created_at":"2017-09-04T09:49:53Z","updated_at":"2017-09-04T09:49:54Z","html_url":"https://github.com/tensorflow/tensorboard/pull/437#discussion_r136784778","pull_request_url":"https://api.github.com/repos/tensorflow/tensorboard/pulls/437","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/tensorflow/tensorboard/pulls/comments/136784778"},"html":{"href":"https://github.com/tensorflow/tensorboard/pull/437#discussion_r136784778"},"pull_request":{"href":"https://api.github.com/repos/tensorflow/tensorboard/pulls/437"}},"in_reply_to_id":136144970},"pull_request":{"url":"https://api.github.com/repos/tensorflow/tensorboard/pulls/437","id":137977162,"html_url":"https://github.com/tensorflow/tensorboard/pull/437","diff_url":"https://github.com/tensorflow/tensorboard/pull/437.diff","patch_url":"https://github.com/tensorflow/tensorboard/pull/437.patch","issue_url":"https://api.github.com/repos/tensorflow/tensorboard/issues/437","number":437,"state":"open","locked":false,"title":"[graph] Trying to fix node stats rendering issue.","user":{"login":"ioeric","id":1298701,"avatar_url":"https://avatars2.githubusercontent.com/u/1298701?v=4","gravatar_id":"","url":"https://api.github.com/users/ioeric","html_url":"https://github.com/ioeric","followers_url":"https://api.github.com/users/ioeric/followers","following_url":"https://api.github.com/users/ioeric/following{/other_user}","gists_url":"https://api.github.com/users/ioeric/gists{/gist_id}","starred_url":"https://api.github.com/users/ioeric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ioeric/subscriptions","organizations_url":"https://api.github.com/users/ioeric/orgs","repos_url":"https://api.github.com/users/ioeric/repos","events_url":"https://api.github.com/users/ioeric/events{/privacy}","received_events_url":"https://api.github.com/users/ioeric/received_events","type":"User","site_admin":false},"body":"When calculating the color scale for the compute time, consider all nodes in the graph instead of just the nodes in the top-level graph. \r\n\r\nI have a graph with one single sub-graph, which consumes all the compute time (say X ms), in the top-level graph, so the color scale becomes \"X ms -> X ms\". \r\n\r\nNot sure about the original intention of the top-level graph; let me know if this is the right fix.\r\n\r\n(I don't really know typescript. Please let me know if there is more efficient way to get  the extent of a map :)","created_at":"2017-08-28T15:46:14Z","updated_at":"2017-09-04T09:49:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"47ad9a947b53dd1e17a0d2bd1c38125fc8cf14b7","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/tensorflow/tensorboard/pulls/437/commits","review_comments_url":"https://api.github.com/repos/tensorflow/tensorboard/pulls/437/comments","review_comment_url":"https://api.github.com/repos/tensorflow/tensorboard/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tensorflow/tensorboard/issues/437/comments","statuses_url":"https://api.github.com/repos/tensorflow/tensorboard/statuses/a5d8f1679fa39be2bb890d276c71029ccc1d47b0","head":{"label":"ioeric:graph","ref":"graph","sha":"a5d8f1679fa39be2bb890d276c71029ccc1d47b0","user":{"login":"ioeric","id":1298701,"avatar_url":"https://avatars2.githubusercontent.com/u/1298701?v=4","gravatar_id":"","url":"https://api.github.com/users/ioeric","html_url":"https://github.com/ioeric","followers_url":"https://api.github.com/users/ioeric/followers","following_url":"https://api.github.com/users/ioeric/following{/other_user}","gists_url":"https://api.github.com/users/ioeric/gists{/gist_id}","starred_url":"https://api.github.com/users/ioeric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ioeric/subscriptions","organizations_url":"https://api.github.com/users/ioeric/orgs","repos_url":"https://api.github.com/users/ioeric/repos","events_url":"https://api.github.com/users/ioeric/events{/privacy}","received_events_url":"https://api.github.com/users/ioeric/received_events","type":"User","site_admin":false},"repo":{"id":95468245,"name":"tensorboard","full_name":"ioeric/tensorboard","owner":{"login":"ioeric","id":1298701,"avatar_url":"https://avatars2.githubusercontent.com/u/1298701?v=4","gravatar_id":"","url":"https://api.github.com/users/ioeric","html_url":"https://github.com/ioeric","followers_url":"https://api.github.com/users/ioeric/followers","following_url":"https://api.github.com/users/ioeric/following{/other_user}","gists_url":"https://api.github.com/users/ioeric/gists{/gist_id}","starred_url":"https://api.github.com/users/ioeric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ioeric/subscriptions","organizations_url":"https://api.github.com/users/ioeric/orgs","repos_url":"https://api.github.com/users/ioeric/repos","events_url":"https://api.github.com/users/ioeric/events{/privacy}","received_events_url":"https://api.github.com/users/ioeric/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ioeric/tensorboard","description":"TensorFlow's Visualization Toolkit","fork":true,"url":"https://api.github.com/repos/ioeric/tensorboard","forks_url":"https://api.github.com/repos/ioeric/tensorboard/forks","keys_url":"https://api.github.com/repos/ioeric/tensorboard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ioeric/tensorboard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ioeric/tensorboard/teams","hooks_url":"https://api.github.com/repos/ioeric/tensorboard/hooks","issue_events_url":"https://api.github.com/repos/ioeric/tensorboard/issues/events{/number}","events_url":"https://api.github.com/repos/ioeric/tensorboard/events","assignees_url":"https://api.github.com/repos/ioeric/tensorboard/assignees{/user}","branches_url":"https://api.github.com/repos/ioeric/tensorboard/branches{/branch}","tags_url":"https://api.github.com/repos/ioeric/tensorboard/tags","blobs_url":"https://api.github.com/repos/ioeric/tensorboard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ioeric/tensorboard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ioeric/tensorboard/git/refs{/sha}","trees_url":"https://api.github.com/repos/ioeric/tensorboard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ioeric/tensorboard/statuses/{sha}","languages_url":"https://api.github.com/repos/ioeric/tensorboard/languages","stargazers_url":"https://api.github.com/repos/ioeric/tensorboard/stargazers","contributors_url":"https://api.github.com/repos/ioeric/tensorboard/contributors","subscribers_url":"https://api.github.com/repos/ioeric/tensorboard/subscribers","subscription_url":"https://api.github.com/repos/ioeric/tensorboard/subscription","commits_url":"https://api.github.com/repos/ioeric/tensorboard/commits{/sha}","git_commits_url":"https://api.github.com/repos/ioeric/tensorboard/git/commits{/sha}","comments_url":"https://api.github.com/repos/ioeric/tensorboard/comments{/number}","issue_comment_url":"https://api.github.com/repos/ioeric/tensorboard/issues/comments{/number}","contents_url":"https://api.github.com/repos/ioeric/tensorboard/contents/{+path}","compare_url":"https://api.github.com/repos/ioeric/tensorboard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ioeric/tensorboard/merges","archive_url":"https://api.github.com/repos/ioeric/tensorboard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ioeric/tensorboard/downloads","issues_url":"https://api.github.com/repos/ioeric/tensorboard/issues{/number}","pulls_url":"https://api.github.com/repos/ioeric/tensorboard/pulls{/number}","milestones_url":"https://api.github.com/repos/ioeric/tensorboard/milestones{/number}","notifications_url":"https://api.github.com/repos/ioeric/tensorboard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ioeric/tensorboard/labels{/name}","releases_url":"https://api.github.com/repos/ioeric/tensorboard/releases{/id}","deployments_url":"https://api.github.com/repos/ioeric/tensorboard/deployments","created_at":"2017-06-26T16:47:26Z","updated_at":"2017-06-26T16:47:28Z","pushed_at":"2017-09-04T09:43:55Z","git_url":"git://github.com/ioeric/tensorboard.git","ssh_url":"git@github.com:ioeric/tensorboard.git","clone_url":"https://github.com/ioeric/tensorboard.git","svn_url":"https://github.com/ioeric/tensorboard","homepage":null,"size":74481,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tensorflow:master","ref":"master","sha":"b1a4d2586a0eae1ce7f3a18b4db188b62c4daaee","user":{"login":"tensorflow","id":15658638,"avatar_url":"https://avatars1.githubusercontent.com/u/15658638?v=4","gravatar_id":"","url":"https://api.github.com/users/tensorflow","html_url":"https://github.com/tensorflow","followers_url":"https://api.github.com/users/tensorflow/followers","following_url":"https://api.github.com/users/tensorflow/following{/other_user}","gists_url":"https://api.github.com/users/tensorflow/gists{/gist_id}","starred_url":"https://api.github.com/users/tensorflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tensorflow/subscriptions","organizations_url":"https://api.github.com/users/tensorflow/orgs","repos_url":"https://api.github.com/users/tensorflow/repos","events_url":"https://api.github.com/users/tensorflow/events{/privacy}","received_events_url":"https://api.github.com/users/tensorflow/received_events","type":"Organization","site_admin":false},"repo":{"id":91379993,"name":"tensorboard","full_name":"tensorflow/tensorboard","owner":{"login":"tensorflow","id":15658638,"avatar_url":"https://avatars1.githubusercontent.com/u/15658638?v=4","gravatar_id":"","url":"https://api.github.com/users/tensorflow","html_url":"https://github.com/tensorflow","followers_url":"https://api.github.com/users/tensorflow/followers","following_url":"https://api.github.com/users/tensorflow/following{/other_user}","gists_url":"https://api.github.com/users/tensorflow/gists{/gist_id}","starred_url":"https://api.github.com/users/tensorflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tensorflow/subscriptions","organizations_url":"https://api.github.com/users/tensorflow/orgs","repos_url":"https://api.github.com/users/tensorflow/repos","events_url":"https://api.github.com/users/tensorflow/events{/privacy}","received_events_url":"https://api.github.com/users/tensorflow/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tensorflow/tensorboard","description":"TensorFlow's Visualization Toolkit","fork":false,"url":"https://api.github.com/repos/tensorflow/tensorboard","forks_url":"https://api.github.com/repos/tensorflow/tensorboard/forks","keys_url":"https://api.github.com/repos/tensorflow/tensorboard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tensorflow/tensorboard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tensorflow/tensorboard/teams","hooks_url":"https://api.github.com/repos/tensorflow/tensorboard/hooks","issue_events_url":"https://api.github.com/repos/tensorflow/tensorboard/issues/events{/number}","events_url":"https://api.github.com/repos/tensorflow/tensorboard/events","assignees_url":"https://api.github.com/repos/tensorflow/tensorboard/assignees{/user}","branches_url":"https://api.github.com/repos/tensorflow/tensorboard/branches{/branch}","tags_url":"https://api.github.com/repos/tensorflow/tensorboard/tags","blobs_url":"https://api.github.com/repos/tensorflow/tensorboard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tensorflow/tensorboard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tensorflow/tensorboard/git/refs{/sha}","trees_url":"https://api.github.com/repos/tensorflow/tensorboard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tensorflow/tensorboard/statuses/{sha}","languages_url":"https://api.github.com/repos/tensorflow/tensorboard/languages","stargazers_url":"https://api.github.com/repos/tensorflow/tensorboard/stargazers","contributors_url":"https://api.github.com/repos/tensorflow/tensorboard/contributors","subscribers_url":"https://api.github.com/repos/tensorflow/tensorboard/subscribers","subscription_url":"https://api.github.com/repos/tensorflow/tensorboard/subscription","commits_url":"https://api.github.com/repos/tensorflow/tensorboard/commits{/sha}","git_commits_url":"https://api.github.com/repos/tensorflow/tensorboard/git/commits{/sha}","comments_url":"https://api.github.com/repos/tensorflow/tensorboard/comments{/number}","issue_comment_url":"https://api.github.com/repos/tensorflow/tensorboard/issues/comments{/number}","contents_url":"https://api.github.com/repos/tensorflow/tensorboard/contents/{+path}","compare_url":"https://api.github.com/repos/tensorflow/tensorboard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tensorflow/tensorboard/merges","archive_url":"https://api.github.com/repos/tensorflow/tensorboard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tensorflow/tensorboard/downloads","issues_url":"https://api.github.com/repos/tensorflow/tensorboard/issues{/number}","pulls_url":"https://api.github.com/repos/tensorflow/tensorboard/pulls{/number}","milestones_url":"https://api.github.com/repos/tensorflow/tensorboard/milestones{/number}","notifications_url":"https://api.github.com/repos/tensorflow/tensorboard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tensorflow/tensorboard/labels{/name}","releases_url":"https://api.github.com/repos/tensorflow/tensorboard/releases{/id}","deployments_url":"https://api.github.com/repos/tensorflow/tensorboard/deployments","created_at":"2017-05-15T20:08:07Z","updated_at":"2017-09-04T09:15:26Z","pushed_at":"2017-09-04T09:46:20Z","git_url":"git://github.com/tensorflow/tensorboard.git","ssh_url":"git@github.com:tensorflow/tensorboard.git","clone_url":"https://github.com/tensorflow/tensorboard.git","svn_url":"https://github.com/tensorflow/tensorboard","homepage":null,"size":6311,"stargazers_count":312,"watchers_count":312,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":101,"mirror_url":null,"open_issues_count":135,"forks":101,"open_issues":135,"watchers":312,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tensorflow/tensorboard/pulls/437"},"html":{"href":"https://github.com/tensorflow/tensorboard/pull/437"},"issue":{"href":"https://api.github.com/repos/tensorflow/tensorboard/issues/437"},"comments":{"href":"https://api.github.com/repos/tensorflow/tensorboard/issues/437/comments"},"review_comments":{"href":"https://api.github.com/repos/tensorflow/tensorboard/pulls/437/comments"},"review_comment":{"href":"https://api.github.com/repos/tensorflow/tensorboard/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tensorflow/tensorboard/pulls/437/commits"},"statuses":{"href":"https://api.github.com/repos/tensorflow/tensorboard/statuses/a5d8f1679fa39be2bb890d276c71029ccc1d47b0"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ioeric"}}