{"action":"created","comment":{"url":"https://api.github.com/repos/wellcometrust/platform-api/pulls/comments/126473220","pull_request_review_id":48960530,"id":126473220,"diff_hunk":"@@ -102,12 +104,19 @@ def send_ecs_status_to_s3(ecs_client, s3_client, bucket_name, object_key):\n \n \n def main(event, _):\n-    pprint.pprint(event)\n+    try:\n+        logger = logging.getLogger()\n+        logger.setLevel(logging.INFO)\n \n-    ecs_client = boto3.client('ecs')\n-    s3_client = boto3.client('s3')\n+        logger.info(event)\n \n-    bucket_name = os.environ[\"BUCKET_NAME\"]\n-    object_key = os.environ[\"OBJECT_KEY\"]\n+        ecs_client = boto3.client('ecs')\n+        s3_client = boto3.client('s3')\n+\n+        bucket_name = os.environ[\"BUCKET_NAME\"]\n+        object_key = os.environ[\"OBJECT_KEY\"]\n+\n+        send_ecs_status_to_s3(ecs_client, s3_client, bucket_name, object_key)\n+    except Exception as e:\n+        logging.error(traceback.format_exc())","path":"lambdas/update_service_list/update_service_list.py","position":34,"original_position":34,"commit_id":"2e086cd1fb0b78cd62c8ccb3750b0414b4f19142","original_commit_id":"2e086cd1fb0b78cd62c8ccb3750b0414b4f19142","user":{"login":"kenoir","id":953792,"avatar_url":"https://avatars0.githubusercontent.com/u/953792?v=3","gravatar_id":"","url":"https://api.github.com/users/kenoir","html_url":"https://github.com/kenoir","followers_url":"https://api.github.com/users/kenoir/followers","following_url":"https://api.github.com/users/kenoir/following{/other_user}","gists_url":"https://api.github.com/users/kenoir/gists{/gist_id}","starred_url":"https://api.github.com/users/kenoir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kenoir/subscriptions","organizations_url":"https://api.github.com/users/kenoir/orgs","repos_url":"https://api.github.com/users/kenoir/repos","events_url":"https://api.github.com/users/kenoir/events{/privacy}","received_events_url":"https://api.github.com/users/kenoir/received_events","type":"User","site_admin":false},"body":"I don't really, I want to eliminate doubt. An error is being thrown somewhere and there is nothing in the logs. ","created_at":"2017-07-10T16:33:21Z","updated_at":"2017-07-10T16:33:21Z","html_url":"https://github.com/wellcometrust/platform-api/pull/610#discussion_r126473220","pull_request_url":"https://api.github.com/repos/wellcometrust/platform-api/pulls/610","_links":{"self":{"href":"https://api.github.com/repos/wellcometrust/platform-api/pulls/comments/126473220"},"html":{"href":"https://github.com/wellcometrust/platform-api/pull/610#discussion_r126473220"},"pull_request":{"href":"https://api.github.com/repos/wellcometrust/platform-api/pulls/610"}}},"pull_request":{"url":"https://api.github.com/repos/wellcometrust/platform-api/pulls/610","id":129707399,"html_url":"https://github.com/wellcometrust/platform-api/pull/610","diff_url":"https://github.com/wellcometrust/platform-api/pull/610.diff","patch_url":"https://github.com/wellcometrust/platform-api/pull/610.patch","issue_url":"https://api.github.com/repos/wellcometrust/platform-api/issues/610","number":610,"state":"open","locked":false,"title":"Adds better logging to update service list","user":{"login":"kenoir","id":953792,"avatar_url":"https://avatars0.githubusercontent.com/u/953792?v=3","gravatar_id":"","url":"https://api.github.com/users/kenoir","html_url":"https://github.com/kenoir","followers_url":"https://api.github.com/users/kenoir/followers","following_url":"https://api.github.com/users/kenoir/following{/other_user}","gists_url":"https://api.github.com/users/kenoir/gists{/gist_id}","starred_url":"https://api.github.com/users/kenoir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kenoir/subscriptions","organizations_url":"https://api.github.com/users/kenoir/orgs","repos_url":"https://api.github.com/users/kenoir/repos","events_url":"https://api.github.com/users/kenoir/events{/privacy}","received_events_url":"https://api.github.com/users/kenoir/received_events","type":"User","site_admin":false},"body":"### What is this PR trying to achieve?\r\n\r\nBetter visibility of logs in the update-service-list lambda as it is throwing errors without logs.\r\n\r\n### Who is this change for?\r\n\r\n💻 \r\n\r\n### Have the following been considered/are they needed?\r\n\r\n- [ ] Run `terraform apply`.\r\n","created_at":"2017-07-10T15:26:49Z","updated_at":"2017-07-10T16:33:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e1ccd739f121ac07da3ab9e6dd1e12624860b656","assignee":{"login":"kenoir","id":953792,"avatar_url":"https://avatars0.githubusercontent.com/u/953792?v=3","gravatar_id":"","url":"https://api.github.com/users/kenoir","html_url":"https://github.com/kenoir","followers_url":"https://api.github.com/users/kenoir/followers","following_url":"https://api.github.com/users/kenoir/following{/other_user}","gists_url":"https://api.github.com/users/kenoir/gists{/gist_id}","starred_url":"https://api.github.com/users/kenoir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kenoir/subscriptions","organizations_url":"https://api.github.com/users/kenoir/orgs","repos_url":"https://api.github.com/users/kenoir/repos","events_url":"https://api.github.com/users/kenoir/events{/privacy}","received_events_url":"https://api.github.com/users/kenoir/received_events","type":"User","site_admin":false},"assignees":[{"login":"kenoir","id":953792,"avatar_url":"https://avatars0.githubusercontent.com/u/953792?v=3","gravatar_id":"","url":"https://api.github.com/users/kenoir","html_url":"https://github.com/kenoir","followers_url":"https://api.github.com/users/kenoir/followers","following_url":"https://api.github.com/users/kenoir/following{/other_user}","gists_url":"https://api.github.com/users/kenoir/gists{/gist_id}","starred_url":"https://api.github.com/users/kenoir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kenoir/subscriptions","organizations_url":"https://api.github.com/users/kenoir/orgs","repos_url":"https://api.github.com/users/kenoir/repos","events_url":"https://api.github.com/users/kenoir/events{/privacy}","received_events_url":"https://api.github.com/users/kenoir/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/wellcometrust/platform-api/pulls/610/commits","review_comments_url":"https://api.github.com/repos/wellcometrust/platform-api/pulls/610/comments","review_comment_url":"https://api.github.com/repos/wellcometrust/platform-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wellcometrust/platform-api/issues/610/comments","statuses_url":"https://api.github.com/repos/wellcometrust/platform-api/statuses/2e086cd1fb0b78cd62c8ccb3750b0414b4f19142","head":{"label":"wellcometrust:better-logging-update-service-list","ref":"better-logging-update-service-list","sha":"2e086cd1fb0b78cd62c8ccb3750b0414b4f19142","user":{"login":"wellcometrust","id":2814213,"avatar_url":"https://avatars0.githubusercontent.com/u/2814213?v=3","gravatar_id":"","url":"https://api.github.com/users/wellcometrust","html_url":"https://github.com/wellcometrust","followers_url":"https://api.github.com/users/wellcometrust/followers","following_url":"https://api.github.com/users/wellcometrust/following{/other_user}","gists_url":"https://api.github.com/users/wellcometrust/gists{/gist_id}","starred_url":"https://api.github.com/users/wellcometrust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wellcometrust/subscriptions","organizations_url":"https://api.github.com/users/wellcometrust/orgs","repos_url":"https://api.github.com/users/wellcometrust/repos","events_url":"https://api.github.com/users/wellcometrust/events{/privacy}","received_events_url":"https://api.github.com/users/wellcometrust/received_events","type":"Organization","site_admin":false},"repo":{"id":80218943,"name":"platform-api","full_name":"wellcometrust/platform-api","owner":{"login":"wellcometrust","id":2814213,"avatar_url":"https://avatars0.githubusercontent.com/u/2814213?v=3","gravatar_id":"","url":"https://api.github.com/users/wellcometrust","html_url":"https://github.com/wellcometrust","followers_url":"https://api.github.com/users/wellcometrust/followers","following_url":"https://api.github.com/users/wellcometrust/following{/other_user}","gists_url":"https://api.github.com/users/wellcometrust/gists{/gist_id}","starred_url":"https://api.github.com/users/wellcometrust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wellcometrust/subscriptions","organizations_url":"https://api.github.com/users/wellcometrust/orgs","repos_url":"https://api.github.com/users/wellcometrust/repos","events_url":"https://api.github.com/users/wellcometrust/events{/privacy}","received_events_url":"https://api.github.com/users/wellcometrust/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wellcometrust/platform-api","description":"The new Wellcome Collection digital platform.","fork":false,"url":"https://api.github.com/repos/wellcometrust/platform-api","forks_url":"https://api.github.com/repos/wellcometrust/platform-api/forks","keys_url":"https://api.github.com/repos/wellcometrust/platform-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wellcometrust/platform-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wellcometrust/platform-api/teams","hooks_url":"https://api.github.com/repos/wellcometrust/platform-api/hooks","issue_events_url":"https://api.github.com/repos/wellcometrust/platform-api/issues/events{/number}","events_url":"https://api.github.com/repos/wellcometrust/platform-api/events","assignees_url":"https://api.github.com/repos/wellcometrust/platform-api/assignees{/user}","branches_url":"https://api.github.com/repos/wellcometrust/platform-api/branches{/branch}","tags_url":"https://api.github.com/repos/wellcometrust/platform-api/tags","blobs_url":"https://api.github.com/repos/wellcometrust/platform-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wellcometrust/platform-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wellcometrust/platform-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/wellcometrust/platform-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wellcometrust/platform-api/statuses/{sha}","languages_url":"https://api.github.com/repos/wellcometrust/platform-api/languages","stargazers_url":"https://api.github.com/repos/wellcometrust/platform-api/stargazers","contributors_url":"https://api.github.com/repos/wellcometrust/platform-api/contributors","subscribers_url":"https://api.github.com/repos/wellcometrust/platform-api/subscribers","subscription_url":"https://api.github.com/repos/wellcometrust/platform-api/subscription","commits_url":"https://api.github.com/repos/wellcometrust/platform-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/wellcometrust/platform-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/wellcometrust/platform-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/wellcometrust/platform-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/wellcometrust/platform-api/contents/{+path}","compare_url":"https://api.github.com/repos/wellcometrust/platform-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wellcometrust/platform-api/merges","archive_url":"https://api.github.com/repos/wellcometrust/platform-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wellcometrust/platform-api/downloads","issues_url":"https://api.github.com/repos/wellcometrust/platform-api/issues{/number}","pulls_url":"https://api.github.com/repos/wellcometrust/platform-api/pulls{/number}","milestones_url":"https://api.github.com/repos/wellcometrust/platform-api/milestones{/number}","notifications_url":"https://api.github.com/repos/wellcometrust/platform-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wellcometrust/platform-api/labels{/name}","releases_url":"https://api.github.com/repos/wellcometrust/platform-api/releases{/id}","deployments_url":"https://api.github.com/repos/wellcometrust/platform-api/deployments","created_at":"2017-01-27T15:27:42Z","updated_at":"2017-07-05T08:16:35Z","pushed_at":"2017-07-10T15:56:03Z","git_url":"git://github.com/wellcometrust/platform-api.git","ssh_url":"git@github.com:wellcometrust/platform-api.git","clone_url":"https://github.com/wellcometrust/platform-api.git","svn_url":"https://github.com/wellcometrust/platform-api","homepage":"https://stacks.wellcomecollection.org","size":2945,"stargazers_count":2,"watchers_count":2,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":133,"forks":0,"open_issues":133,"watchers":2,"default_branch":"master"}},"base":{"label":"wellcometrust:master","ref":"master","sha":"607efed01722f98f74a33b55ddc19f8b3bbac270","user":{"login":"wellcometrust","id":2814213,"avatar_url":"https://avatars0.githubusercontent.com/u/2814213?v=3","gravatar_id":"","url":"https://api.github.com/users/wellcometrust","html_url":"https://github.com/wellcometrust","followers_url":"https://api.github.com/users/wellcometrust/followers","following_url":"https://api.github.com/users/wellcometrust/following{/other_user}","gists_url":"https://api.github.com/users/wellcometrust/gists{/gist_id}","starred_url":"https://api.github.com/users/wellcometrust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wellcometrust/subscriptions","organizations_url":"https://api.github.com/users/wellcometrust/orgs","repos_url":"https://api.github.com/users/wellcometrust/repos","events_url":"https://api.github.com/users/wellcometrust/events{/privacy}","received_events_url":"https://api.github.com/users/wellcometrust/received_events","type":"Organization","site_admin":false},"repo":{"id":80218943,"name":"platform-api","full_name":"wellcometrust/platform-api","owner":{"login":"wellcometrust","id":2814213,"avatar_url":"https://avatars0.githubusercontent.com/u/2814213?v=3","gravatar_id":"","url":"https://api.github.com/users/wellcometrust","html_url":"https://github.com/wellcometrust","followers_url":"https://api.github.com/users/wellcometrust/followers","following_url":"https://api.github.com/users/wellcometrust/following{/other_user}","gists_url":"https://api.github.com/users/wellcometrust/gists{/gist_id}","starred_url":"https://api.github.com/users/wellcometrust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wellcometrust/subscriptions","organizations_url":"https://api.github.com/users/wellcometrust/orgs","repos_url":"https://api.github.com/users/wellcometrust/repos","events_url":"https://api.github.com/users/wellcometrust/events{/privacy}","received_events_url":"https://api.github.com/users/wellcometrust/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wellcometrust/platform-api","description":"The new Wellcome Collection digital platform.","fork":false,"url":"https://api.github.com/repos/wellcometrust/platform-api","forks_url":"https://api.github.com/repos/wellcometrust/platform-api/forks","keys_url":"https://api.github.com/repos/wellcometrust/platform-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wellcometrust/platform-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wellcometrust/platform-api/teams","hooks_url":"https://api.github.com/repos/wellcometrust/platform-api/hooks","issue_events_url":"https://api.github.com/repos/wellcometrust/platform-api/issues/events{/number}","events_url":"https://api.github.com/repos/wellcometrust/platform-api/events","assignees_url":"https://api.github.com/repos/wellcometrust/platform-api/assignees{/user}","branches_url":"https://api.github.com/repos/wellcometrust/platform-api/branches{/branch}","tags_url":"https://api.github.com/repos/wellcometrust/platform-api/tags","blobs_url":"https://api.github.com/repos/wellcometrust/platform-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wellcometrust/platform-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wellcometrust/platform-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/wellcometrust/platform-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wellcometrust/platform-api/statuses/{sha}","languages_url":"https://api.github.com/repos/wellcometrust/platform-api/languages","stargazers_url":"https://api.github.com/repos/wellcometrust/platform-api/stargazers","contributors_url":"https://api.github.com/repos/wellcometrust/platform-api/contributors","subscribers_url":"https://api.github.com/repos/wellcometrust/platform-api/subscribers","subscription_url":"https://api.github.com/repos/wellcometrust/platform-api/subscription","commits_url":"https://api.github.com/repos/wellcometrust/platform-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/wellcometrust/platform-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/wellcometrust/platform-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/wellcometrust/platform-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/wellcometrust/platform-api/contents/{+path}","compare_url":"https://api.github.com/repos/wellcometrust/platform-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wellcometrust/platform-api/merges","archive_url":"https://api.github.com/repos/wellcometrust/platform-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wellcometrust/platform-api/downloads","issues_url":"https://api.github.com/repos/wellcometrust/platform-api/issues{/number}","pulls_url":"https://api.github.com/repos/wellcometrust/platform-api/pulls{/number}","milestones_url":"https://api.github.com/repos/wellcometrust/platform-api/milestones{/number}","notifications_url":"https://api.github.com/repos/wellcometrust/platform-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wellcometrust/platform-api/labels{/name}","releases_url":"https://api.github.com/repos/wellcometrust/platform-api/releases{/id}","deployments_url":"https://api.github.com/repos/wellcometrust/platform-api/deployments","created_at":"2017-01-27T15:27:42Z","updated_at":"2017-07-05T08:16:35Z","pushed_at":"2017-07-10T15:56:03Z","git_url":"git://github.com/wellcometrust/platform-api.git","ssh_url":"git@github.com:wellcometrust/platform-api.git","clone_url":"https://github.com/wellcometrust/platform-api.git","svn_url":"https://github.com/wellcometrust/platform-api","homepage":"https://stacks.wellcomecollection.org","size":2945,"stargazers_count":2,"watchers_count":2,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":133,"forks":0,"open_issues":133,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wellcometrust/platform-api/pulls/610"},"html":{"href":"https://github.com/wellcometrust/platform-api/pull/610"},"issue":{"href":"https://api.github.com/repos/wellcometrust/platform-api/issues/610"},"comments":{"href":"https://api.github.com/repos/wellcometrust/platform-api/issues/610/comments"},"review_comments":{"href":"https://api.github.com/repos/wellcometrust/platform-api/pulls/610/comments"},"review_comment":{"href":"https://api.github.com/repos/wellcometrust/platform-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wellcometrust/platform-api/pulls/610/commits"},"statuses":{"href":"https://api.github.com/repos/wellcometrust/platform-api/statuses/2e086cd1fb0b78cd62c8ccb3750b0414b4f19142"}}}}
{"actor":{"display_login":"kenoir"}}