{"action":"created","issue":{"url":"https://api.github.com/repos/Jermolene/TiddlyWiki5/issues/2828","repository_url":"https://api.github.com/repos/Jermolene/TiddlyWiki5","labels_url":"https://api.github.com/repos/Jermolene/TiddlyWiki5/issues/2828/labels{/name}","comments_url":"https://api.github.com/repos/Jermolene/TiddlyWiki5/issues/2828/comments","events_url":"https://api.github.com/repos/Jermolene/TiddlyWiki5/issues/2828/events","html_url":"https://github.com/Jermolene/TiddlyWiki5/pull/2828","id":221937077,"number":2828,"title":"Fix two files to permit local saving of filenames containing spaces","user":{"login":"DelphiCoder","id":11362009,"avatar_url":"https://avatars1.githubusercontent.com/u/11362009?v=3","gravatar_id":"","url":"https://api.github.com/users/DelphiCoder","html_url":"https://github.com/DelphiCoder","followers_url":"https://api.github.com/users/DelphiCoder/followers","following_url":"https://api.github.com/users/DelphiCoder/following{/other_user}","gists_url":"https://api.github.com/users/DelphiCoder/gists{/gist_id}","starred_url":"https://api.github.com/users/DelphiCoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DelphiCoder/subscriptions","organizations_url":"https://api.github.com/users/DelphiCoder/orgs","repos_url":"https://api.github.com/users/DelphiCoder/repos","events_url":"https://api.github.com/users/DelphiCoder/events{/privacy}","received_events_url":"https://api.github.com/users/DelphiCoder/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-04-15T09:05:46Z","updated_at":"2017-06-29T17:18:53Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Jermolene/TiddlyWiki5/pulls/2828","html_url":"https://github.com/Jermolene/TiddlyWiki5/pull/2828","diff_url":"https://github.com/Jermolene/TiddlyWiki5/pull/2828.diff","patch_url":"https://github.com/Jermolene/TiddlyWiki5/pull/2828.patch"},"body":"Updated download.js and msdownload.js to permit local saving of files with space characters in them. Previously spaces were always replaced with %20 which over time becomes %25252525252525252525252525252520 as the newly inserted % symbol begins getting repeated replaced upon later saves too. See issue #2819 \r\n\r\nI've tested saving under Chrome, Safari, and IE with no issues. I realize the user can constantly edit the filename on every save and manually reinsert the space characters, but that is a real hassle.\r\n\r\n-Douglas Counts"},"comment":{"url":"https://api.github.com/repos/Jermolene/TiddlyWiki5/issues/comments/312033866","html_url":"https://github.com/Jermolene/TiddlyWiki5/pull/2828#issuecomment-312033866","issue_url":"https://api.github.com/repos/Jermolene/TiddlyWiki5/issues/2828","id":312033866,"user":{"login":"Jermolene","id":174761,"avatar_url":"https://avatars2.githubusercontent.com/u/174761?v=3","gravatar_id":"","url":"https://api.github.com/users/Jermolene","html_url":"https://github.com/Jermolene","followers_url":"https://api.github.com/users/Jermolene/followers","following_url":"https://api.github.com/users/Jermolene/following{/other_user}","gists_url":"https://api.github.com/users/Jermolene/gists{/gist_id}","starred_url":"https://api.github.com/users/Jermolene/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jermolene/subscriptions","organizations_url":"https://api.github.com/users/Jermolene/orgs","repos_url":"https://api.github.com/users/Jermolene/repos","events_url":"https://api.github.com/users/Jermolene/events{/privacy}","received_events_url":"https://api.github.com/users/Jermolene/received_events","type":"User","site_admin":false},"created_at":"2017-06-29T17:18:53Z","updated_at":"2017-06-29T17:18:53Z","body":"Hi @DelphiCoder sorry for the delayed response. As I mentioned over at #2819, I am concerned that this issue affects other non-URL-safe characters such as accents, so a good fix would fix those situations too.\r\n\r\nI've experimented with using `filename = decodeURIComponent(filename);` instead of the `replace()` call. It seems to resolve the original problem but needs further evaluation - on Chrome I noticed that it ended up producing filenames such as `My Test Wiki (1) (1) (1) (1) (1).html`. Does that also happen with your fix?"}}
{"actor":{"display_login":"Jermolene"}}