{"action":"created","comment":{"url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/pulls/comments/106965056","pull_request_review_id":27905510,"id":106965056,"diff_hunk":"@@ -358,23 +414,79 @@ with BigBlueButton; if not, see <http://www.gnu.org/licenses/>.\n \r\n \t<dspub:TabIndexer startIndex=\"{dsOptions.baseTabIndex + 1}\"\r\n \t\t\t\t\t  tabIndices=\"{[minimizeBtn, maximizeRestoreBtn, closeBtn, btnClosePublish]}\"/>\r\n-\t<dspub:states>\r\n-\t\t<mx:State name=\"dispFullRegionControlBar\">\r\n-\t\t\t<mx:AddChild>\r\n-\t\t\t  <mx:ControlBar id=\"fullRegionBottomBar\">\r\n-\t\t\t\t<mx:VBox width=\"100%\" height=\"100%\" horizontalAlign=\"center\">\r\n-\t\t\t\t  <mx:HBox horizontalAlign=\"center\">\r\n-\t\t\t\t\t<mx:Button id=\"btnClosePublish\"\r\n-\t\t\t\t\t\t\t   toolTip=\"{ResourceUtil.getInstance().getString('bbb.desktopPublish.stop.tooltip')}\"\r\n-\t\t\t\t\t\t\t   label=\"{ResourceUtil.getInstance().getString('bbb.desktopPublish.stop.label')}\"\r\n-\t\t\t\t\t\t\t   visible=\"true\"\r\n-\t\t\t\t\t\t\t   enabled=\"false\"\r\n-\t\t\t\t\t\t\t   click=\"stopSharing()\" />\r\n-\t\t\t\t  </mx:HBox>\r\n-\t\t\t\t</mx:VBox>\r\n-\t\t\t  </mx:ControlBar>\r\n-\t\t\t</mx:AddChild>\r\n-\t\t</mx:State>\r\n-\t</dspub:states>\r\n-\r\n-</dspub:CustomMdiWindow>\r\n+\r\n+<dspub:states>\r\n+  <mx:State name=\"dispFullRegionControlBar\">\r\n+  <mx:AddChild relativeTo=\"mainElement\" position=\"after\">\r\n+    <mx:ControlBar id=\"fullRegionBottomBar\">\r\n+      <mx:VBox width=\"100%\" height=\"100%\" horizontalAlign=\"center\">\r\n+        <mx:HBox horizontalAlign=\"center\">\r\n+          <mx:Button id=\"btnClosePublish\"\r\n+                     toolTip=\"{ResourceUtil.getInstance().getString('bbb.screensharePublish.stopButton.toolTip')}\"\r\n+                     label=\"{ResourceUtil.getInstance().getString('bbb.screensharePublish.stopButton.label')}\"\r\n+                     visible=\"true\"\r\n+                     enabled=\"false\"\r\n+                     click=\"stopSharing()\" />\r\n+        </mx:HBox>\r\n+      </mx:VBox>\r\n+    </mx:ControlBar>\r\n+  </mx:AddChild>\r\n+  </mx:State>\r\n+\r\n+\t<mx:State name=\"displayInstall\">\r\n+    <mx:AddChild relativeTo=\"mainElement\" position=\"after\">\r\n+      <mx:VBox width=\"100%\" height=\"100%\" horizontalAlign=\"center\">\r\n+        <mx:HBox width=\"100%\" horizontalAlign=\"center\">\r\n+          <mx:Text width=\"100%\" textAlign=\"center\" styleName=\"\" text=\"{ResourceUtil.getInstance().getString('bbb.screensharePublish.WebRTCChromeExtensionMissing.label')}\"/>\r\n+        </mx:HBox>\r\n+        <mx:HBox width=\"100%\" horizontalAlign=\"center\">\r\n+          <mx:LinkButton id=\"btnInstallExtension\" \r\n+            label=\"Click here to install\" \r\n+            visible=\"true\" \r\n+            enabled=\"true\" \r\n+            styleName=\"quickWindowLinkStyle\"\r\n+            click=\"onInstallButtonClicked()\" />\r\n+        </mx:HBox>\r\n+      </mx:VBox>\r\n+    </mx:AddChild>\r\n+  </mx:State>\r\n+\r\n+  <mx:State name=\"displayRetry\">\r\n+    <mx:AddChild relativeTo=\"mainElement\" position=\"after\">\r\n+      <mx:VBox width=\"100%\" height=\"100%\" horizontalAlign=\"center\">\r\n+        <mx:LinkButton id=\"btnInstallExtension2\" \r\n+          label=\"Click here to install\" \r","path":"bigbluebutton-client/src/org/bigbluebutton/modules/screenshare/view/components/WebRTCDesktopPublishWindow.mxml","position":219,"original_position":219,"commit_id":"dd6f869059a96823252536875778c8b783c49e77","original_commit_id":"dd6f869059a96823252536875778c8b783c49e77","user":{"login":"capilkey","id":1395090,"avatar_url":"https://avatars0.githubusercontent.com/u/1395090?v=3","gravatar_id":"","url":"https://api.github.com/users/capilkey","html_url":"https://github.com/capilkey","followers_url":"https://api.github.com/users/capilkey/followers","following_url":"https://api.github.com/users/capilkey/following{/other_user}","gists_url":"https://api.github.com/users/capilkey/gists{/gist_id}","starred_url":"https://api.github.com/users/capilkey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/capilkey/subscriptions","organizations_url":"https://api.github.com/users/capilkey/orgs","repos_url":"https://api.github.com/users/capilkey/repos","events_url":"https://api.github.com/users/capilkey/events{/privacy}","received_events_url":"https://api.github.com/users/capilkey/received_events","type":"User","site_admin":false},"body":"This string needs to be moved to locales.","created_at":"2017-03-20T17:31:06Z","updated_at":"2017-03-20T17:33:39Z","html_url":"https://github.com/bigbluebutton/bigbluebutton/pull/3712#discussion_r106965056","pull_request_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/pulls/3712","_links":{"self":{"href":"https://api.github.com/repos/bigbluebutton/bigbluebutton/pulls/comments/106965056"},"html":{"href":"https://github.com/bigbluebutton/bigbluebutton/pull/3712#discussion_r106965056"},"pull_request":{"href":"https://api.github.com/repos/bigbluebutton/bigbluebutton/pulls/3712"}}},"pull_request":{"url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/pulls/3712","id":109346125,"html_url":"https://github.com/bigbluebutton/bigbluebutton/pull/3712","diff_url":"https://github.com/bigbluebutton/bigbluebutton/pull/3712.diff","patch_url":"https://github.com/bigbluebutton/bigbluebutton/pull/3712.patch","issue_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/issues/3712","number":3712,"state":"open","locked":false,"title":"[HTML5] Adds Verto Screenshare Support","user":{"login":"perroned","id":6475374,"avatar_url":"https://avatars1.githubusercontent.com/u/6475374?v=3","gravatar_id":"","url":"https://api.github.com/users/perroned","html_url":"https://github.com/perroned","followers_url":"https://api.github.com/users/perroned/followers","following_url":"https://api.github.com/users/perroned/following{/other_user}","gists_url":"https://api.github.com/users/perroned/gists{/gist_id}","starred_url":"https://api.github.com/users/perroned/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/perroned/subscriptions","organizations_url":"https://api.github.com/users/perroned/orgs","repos_url":"https://api.github.com/users/perroned/repos","events_url":"https://api.github.com/users/perroned/events{/privacy}","received_events_url":"https://api.github.com/users/perroned/received_events","type":"User","site_admin":false},"body":"[HTML5] Adds verto screenshare support\r\n\r\n- removes getScreenId and Screen-Capturing libraries\r\n- adds verto live array to verto_extension\r\n- updated extension detection (verto_extension.js)\r\n- handles stream stop properly\r\n- Flash client now has walkthrough screens of extension (Chrome) detection, extension installation, and fallback\r\n- resolves Flash screenshare window issues (duplication, closing)\r\n- completes HTML5 client viewing\r\n- fixes HTML5 video restart\r\n- updated HTML5 client code to match current structure\r\n","created_at":"2017-03-06T20:52:08Z","updated_at":"2017-03-20T17:33:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0fbda64089257a20c41ddf6b806baded15ecbb18","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/pulls/3712/commits","review_comments_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/pulls/3712/comments","review_comment_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/issues/3712/comments","statuses_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/statuses/dd6f869059a96823252536875778c8b783c49e77","head":{"label":"perroned:merge-webrtc-screenshare-2","ref":"merge-webrtc-screenshare-2","sha":"dd6f869059a96823252536875778c8b783c49e77","user":{"login":"perroned","id":6475374,"avatar_url":"https://avatars1.githubusercontent.com/u/6475374?v=3","gravatar_id":"","url":"https://api.github.com/users/perroned","html_url":"https://github.com/perroned","followers_url":"https://api.github.com/users/perroned/followers","following_url":"https://api.github.com/users/perroned/following{/other_user}","gists_url":"https://api.github.com/users/perroned/gists{/gist_id}","starred_url":"https://api.github.com/users/perroned/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/perroned/subscriptions","organizations_url":"https://api.github.com/users/perroned/orgs","repos_url":"https://api.github.com/users/perroned/repos","events_url":"https://api.github.com/users/perroned/events{/privacy}","received_events_url":"https://api.github.com/users/perroned/received_events","type":"User","site_admin":false},"repo":{"id":19982839,"name":"bigbluebutton","full_name":"perroned/bigbluebutton","owner":{"login":"perroned","id":6475374,"avatar_url":"https://avatars1.githubusercontent.com/u/6475374?v=3","gravatar_id":"","url":"https://api.github.com/users/perroned","html_url":"https://github.com/perroned","followers_url":"https://api.github.com/users/perroned/followers","following_url":"https://api.github.com/users/perroned/following{/other_user}","gists_url":"https://api.github.com/users/perroned/gists{/gist_id}","starred_url":"https://api.github.com/users/perroned/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/perroned/subscriptions","organizations_url":"https://api.github.com/users/perroned/orgs","repos_url":"https://api.github.com/users/perroned/repos","events_url":"https://api.github.com/users/perroned/events{/privacy}","received_events_url":"https://api.github.com/users/perroned/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/perroned/bigbluebutton","description":"BigBlueButton is an open source web conferencing system for on-line learning.","fork":true,"url":"https://api.github.com/repos/perroned/bigbluebutton","forks_url":"https://api.github.com/repos/perroned/bigbluebutton/forks","keys_url":"https://api.github.com/repos/perroned/bigbluebutton/keys{/key_id}","collaborators_url":"https://api.github.com/repos/perroned/bigbluebutton/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/perroned/bigbluebutton/teams","hooks_url":"https://api.github.com/repos/perroned/bigbluebutton/hooks","issue_events_url":"https://api.github.com/repos/perroned/bigbluebutton/issues/events{/number}","events_url":"https://api.github.com/repos/perroned/bigbluebutton/events","assignees_url":"https://api.github.com/repos/perroned/bigbluebutton/assignees{/user}","branches_url":"https://api.github.com/repos/perroned/bigbluebutton/branches{/branch}","tags_url":"https://api.github.com/repos/perroned/bigbluebutton/tags","blobs_url":"https://api.github.com/repos/perroned/bigbluebutton/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/perroned/bigbluebutton/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/perroned/bigbluebutton/git/refs{/sha}","trees_url":"https://api.github.com/repos/perroned/bigbluebutton/git/trees{/sha}","statuses_url":"https://api.github.com/repos/perroned/bigbluebutton/statuses/{sha}","languages_url":"https://api.github.com/repos/perroned/bigbluebutton/languages","stargazers_url":"https://api.github.com/repos/perroned/bigbluebutton/stargazers","contributors_url":"https://api.github.com/repos/perroned/bigbluebutton/contributors","subscribers_url":"https://api.github.com/repos/perroned/bigbluebutton/subscribers","subscription_url":"https://api.github.com/repos/perroned/bigbluebutton/subscription","commits_url":"https://api.github.com/repos/perroned/bigbluebutton/commits{/sha}","git_commits_url":"https://api.github.com/repos/perroned/bigbluebutton/git/commits{/sha}","comments_url":"https://api.github.com/repos/perroned/bigbluebutton/comments{/number}","issue_comment_url":"https://api.github.com/repos/perroned/bigbluebutton/issues/comments{/number}","contents_url":"https://api.github.com/repos/perroned/bigbluebutton/contents/{+path}","compare_url":"https://api.github.com/repos/perroned/bigbluebutton/compare/{base}...{head}","merges_url":"https://api.github.com/repos/perroned/bigbluebutton/merges","archive_url":"https://api.github.com/repos/perroned/bigbluebutton/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/perroned/bigbluebutton/downloads","issues_url":"https://api.github.com/repos/perroned/bigbluebutton/issues{/number}","pulls_url":"https://api.github.com/repos/perroned/bigbluebutton/pulls{/number}","milestones_url":"https://api.github.com/repos/perroned/bigbluebutton/milestones{/number}","notifications_url":"https://api.github.com/repos/perroned/bigbluebutton/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/perroned/bigbluebutton/labels{/name}","releases_url":"https://api.github.com/repos/perroned/bigbluebutton/releases{/id}","deployments_url":"https://api.github.com/repos/perroned/bigbluebutton/deployments","created_at":"2014-05-20T13:54:33Z","updated_at":"2014-06-24T18:40:01Z","pushed_at":"2017-03-13T21:21:33Z","git_url":"git://github.com/perroned/bigbluebutton.git","ssh_url":"git@github.com:perroned/bigbluebutton.git","clone_url":"https://github.com/perroned/bigbluebutton.git","svn_url":"https://github.com/perroned/bigbluebutton","homepage":"www.bigbluebutton.org","size":553226,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bigbluebutton:master","ref":"master","sha":"55525672f2b95d2f734876cb6047e16c6ce9d5c1","user":{"login":"bigbluebutton","id":230228,"avatar_url":"https://avatars3.githubusercontent.com/u/230228?v=3","gravatar_id":"","url":"https://api.github.com/users/bigbluebutton","html_url":"https://github.com/bigbluebutton","followers_url":"https://api.github.com/users/bigbluebutton/followers","following_url":"https://api.github.com/users/bigbluebutton/following{/other_user}","gists_url":"https://api.github.com/users/bigbluebutton/gists{/gist_id}","starred_url":"https://api.github.com/users/bigbluebutton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigbluebutton/subscriptions","organizations_url":"https://api.github.com/users/bigbluebutton/orgs","repos_url":"https://api.github.com/users/bigbluebutton/repos","events_url":"https://api.github.com/users/bigbluebutton/events{/privacy}","received_events_url":"https://api.github.com/users/bigbluebutton/received_events","type":"Organization","site_admin":false},"repo":{"id":684382,"name":"bigbluebutton","full_name":"bigbluebutton/bigbluebutton","owner":{"login":"bigbluebutton","id":230228,"avatar_url":"https://avatars3.githubusercontent.com/u/230228?v=3","gravatar_id":"","url":"https://api.github.com/users/bigbluebutton","html_url":"https://github.com/bigbluebutton","followers_url":"https://api.github.com/users/bigbluebutton/followers","following_url":"https://api.github.com/users/bigbluebutton/following{/other_user}","gists_url":"https://api.github.com/users/bigbluebutton/gists{/gist_id}","starred_url":"https://api.github.com/users/bigbluebutton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigbluebutton/subscriptions","organizations_url":"https://api.github.com/users/bigbluebutton/orgs","repos_url":"https://api.github.com/users/bigbluebutton/repos","events_url":"https://api.github.com/users/bigbluebutton/events{/privacy}","received_events_url":"https://api.github.com/users/bigbluebutton/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bigbluebutton/bigbluebutton","description":"Complete open source web conferencing system.","fork":false,"url":"https://api.github.com/repos/bigbluebutton/bigbluebutton","forks_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/forks","keys_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/teams","hooks_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/hooks","issue_events_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/issues/events{/number}","events_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/events","assignees_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/assignees{/user}","branches_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/branches{/branch}","tags_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/tags","blobs_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/git/refs{/sha}","trees_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/statuses/{sha}","languages_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/languages","stargazers_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/stargazers","contributors_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/contributors","subscribers_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/subscribers","subscription_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/subscription","commits_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/commits{/sha}","git_commits_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/git/commits{/sha}","comments_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/comments{/number}","issue_comment_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/issues/comments{/number}","contents_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/contents/{+path}","compare_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/merges","archive_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/downloads","issues_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/issues{/number}","pulls_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/pulls{/number}","milestones_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/milestones{/number}","notifications_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/labels{/name}","releases_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/releases{/id}","deployments_url":"https://api.github.com/repos/bigbluebutton/bigbluebutton/deployments","created_at":"2010-05-25T01:42:41Z","updated_at":"2017-03-20T07:20:00Z","pushed_at":"2017-03-20T17:17:06Z","git_url":"git://github.com/bigbluebutton/bigbluebutton.git","ssh_url":"git@github.com:bigbluebutton/bigbluebutton.git","clone_url":"https://github.com/bigbluebutton/bigbluebutton.git","svn_url":"https://github.com/bigbluebutton/bigbluebutton","homepage":"http://www.bigbluebutton.org","size":550850,"stargazers_count":1750,"watchers_count":1750,"language":"Java","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":3283,"mirror_url":null,"open_issues_count":357,"forks":3283,"open_issues":357,"watchers":1750,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bigbluebutton/bigbluebutton/pulls/3712"},"html":{"href":"https://github.com/bigbluebutton/bigbluebutton/pull/3712"},"issue":{"href":"https://api.github.com/repos/bigbluebutton/bigbluebutton/issues/3712"},"comments":{"href":"https://api.github.com/repos/bigbluebutton/bigbluebutton/issues/3712/comments"},"review_comments":{"href":"https://api.github.com/repos/bigbluebutton/bigbluebutton/pulls/3712/comments"},"review_comment":{"href":"https://api.github.com/repos/bigbluebutton/bigbluebutton/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bigbluebutton/bigbluebutton/pulls/3712/commits"},"statuses":{"href":"https://api.github.com/repos/bigbluebutton/bigbluebutton/statuses/dd6f869059a96823252536875778c8b783c49e77"}}}}
{"actor":{"display_login":"capilkey"}}