{"action":"created","issue":{"url":"https://api.github.com/repos/frappe/frappe/issues/4288","repository_url":"https://api.github.com/repos/frappe/frappe","labels_url":"https://api.github.com/repos/frappe/frappe/issues/4288/labels{/name}","comments_url":"https://api.github.com/repos/frappe/frappe/issues/4288/comments","events_url":"https://api.github.com/repos/frappe/frappe/issues/4288/events","html_url":"https://github.com/frappe/frappe/pull/4288","id":264093748,"number":4288,"title":"Multilingual","user":{"login":"MaxMorais","id":1288676,"avatar_url":"https://avatars1.githubusercontent.com/u/1288676?v=4","gravatar_id":"","url":"https://api.github.com/users/MaxMorais","html_url":"https://github.com/MaxMorais","followers_url":"https://api.github.com/users/MaxMorais/followers","following_url":"https://api.github.com/users/MaxMorais/following{/other_user}","gists_url":"https://api.github.com/users/MaxMorais/gists{/gist_id}","starred_url":"https://api.github.com/users/MaxMorais/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaxMorais/subscriptions","organizations_url":"https://api.github.com/users/MaxMorais/orgs","repos_url":"https://api.github.com/users/MaxMorais/repos","events_url":"https://api.github.com/users/MaxMorais/events{/privacy}","received_events_url":"https://api.github.com/users/MaxMorais/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":22,"created_at":"2017-10-10T04:11:26Z","updated_at":"2017-10-24T08:16:37Z","closed_at":"2017-10-17T04:55:49Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/frappe/frappe/pulls/4288","html_url":"https://github.com/frappe/frappe/pull/4288","diff_url":"https://github.com/frappe/frappe/pull/4288.diff","patch_url":"https://github.com/frappe/frappe/pull/4288.patch"},"body":"@rmehta, this is the changes that we have made in Frappe, to enable the multi-lingual system in frappe.\r\n\r\nThat changes are so small, but powerfull, we are able to ensure that the most important places where the languages are needed are touched by the translation.\r\n\r\nLike\r\n\r\nDocument Prints\r\nCommunications\r\nWeb-Site pages\r\n\r\nAnything else that is rendered by jinja, can be affected by the translation in a good way.\r\n\r\nThis, are the primary changes for the frappe core.\r\nWe have one visual improvement, to include in frappe, to better manage the translations\r\n\r\nRight now, it's in an separated app, due I have some doubts, that I need to be guided!\r\n\r\nOne of the doubts, are about the code itself, you think has something wrong with that.\r\nAnother thing is about, that I need some guide with the tests.\r\n\r\nThe app to manage visually the translation can be found here\r\nhttps://github.com/Aptitudetech/translate\r\n\r\nIn that app, I have some global hooks to onload methods, I need to know where I can put it in the frappe.model.document, to ensure that it will be used by the user interface."},"comment":{"url":"https://api.github.com/repos/frappe/frappe/issues/comments/338911343","html_url":"https://github.com/frappe/frappe/pull/4288#issuecomment-338911343","issue_url":"https://api.github.com/repos/frappe/frappe/issues/4288","id":338911343,"user":{"login":"petri","id":64672,"avatar_url":"https://avatars0.githubusercontent.com/u/64672?v=4","gravatar_id":"","url":"https://api.github.com/users/petri","html_url":"https://github.com/petri","followers_url":"https://api.github.com/users/petri/followers","following_url":"https://api.github.com/users/petri/following{/other_user}","gists_url":"https://api.github.com/users/petri/gists{/gist_id}","starred_url":"https://api.github.com/users/petri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petri/subscriptions","organizations_url":"https://api.github.com/users/petri/orgs","repos_url":"https://api.github.com/users/petri/repos","events_url":"https://api.github.com/users/petri/events{/privacy}","received_events_url":"https://api.github.com/users/petri/received_events","type":"User","site_admin":false},"created_at":"2017-10-24T08:16:37Z","updated_at":"2017-10-24T08:16:37Z","author_association":"NONE","body":"Also, if you find, after considering alternative, perhaps better ways to show your work and seek input, that it is necessary for you to submit PRs without intending them to be merged, at least make your intention very clear when submitting the PR. \r\n\r\nOtherwise people will expect that you want it to be merged and you will not get the response you're seeking."}}
{"actor":{"display_login":"petri"}}