{"action":"created","issue":{"url":"https://api.github.com/repos/googleapis/toolkit/issues/986","repository_url":"https://api.github.com/repos/googleapis/toolkit","labels_url":"https://api.github.com/repos/googleapis/toolkit/issues/986/labels{/name}","comments_url":"https://api.github.com/repos/googleapis/toolkit/issues/986/comments","events_url":"https://api.github.com/repos/googleapis/toolkit/issues/986/events","html_url":"https://github.com/googleapis/toolkit/pull/986","id":205261933,"number":986,"title":"Fix abnormal page token cases in Ruby sample gen","user":{"login":"tcoffee-google","id":16905211,"avatar_url":"https://avatars.githubusercontent.com/u/16905211?v=3","gravatar_id":"","url":"https://api.github.com/users/tcoffee-google","html_url":"https://github.com/tcoffee-google","followers_url":"https://api.github.com/users/tcoffee-google/followers","following_url":"https://api.github.com/users/tcoffee-google/following{/other_user}","gists_url":"https://api.github.com/users/tcoffee-google/gists{/gist_id}","starred_url":"https://api.github.com/users/tcoffee-google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tcoffee-google/subscriptions","organizations_url":"https://api.github.com/users/tcoffee-google/orgs","repos_url":"https://api.github.com/users/tcoffee-google/repos","events_url":"https://api.github.com/users/tcoffee-google/events{/privacy}","received_events_url":"https://api.github.com/users/tcoffee-google/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"saicheems","id":2468087,"avatar_url":"https://avatars.githubusercontent.com/u/2468087?v=3","gravatar_id":"","url":"https://api.github.com/users/saicheems","html_url":"https://github.com/saicheems","followers_url":"https://api.github.com/users/saicheems/followers","following_url":"https://api.github.com/users/saicheems/following{/other_user}","gists_url":"https://api.github.com/users/saicheems/gists{/gist_id}","starred_url":"https://api.github.com/users/saicheems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saicheems/subscriptions","organizations_url":"https://api.github.com/users/saicheems/orgs","repos_url":"https://api.github.com/users/saicheems/repos","events_url":"https://api.github.com/users/saicheems/events{/privacy}","received_events_url":"https://api.github.com/users/saicheems/received_events","type":"User","site_admin":false},"assignees":[{"login":"saicheems","id":2468087,"avatar_url":"https://avatars.githubusercontent.com/u/2468087?v=3","gravatar_id":"","url":"https://api.github.com/users/saicheems","html_url":"https://github.com/saicheems","followers_url":"https://api.github.com/users/saicheems/followers","following_url":"https://api.github.com/users/saicheems/following{/other_user}","gists_url":"https://api.github.com/users/saicheems/gists{/gist_id}","starred_url":"https://api.github.com/users/saicheems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saicheems/subscriptions","organizations_url":"https://api.github.com/users/saicheems/orgs","repos_url":"https://api.github.com/users/saicheems/repos","events_url":"https://api.github.com/users/saicheems/events{/privacy}","received_events_url":"https://api.github.com/users/saicheems/received_events","type":"User","site_admin":false},{"login":"vchudnov-g","id":5422149,"avatar_url":"https://avatars.githubusercontent.com/u/5422149?v=3","gravatar_id":"","url":"https://api.github.com/users/vchudnov-g","html_url":"https://github.com/vchudnov-g","followers_url":"https://api.github.com/users/vchudnov-g/followers","following_url":"https://api.github.com/users/vchudnov-g/following{/other_user}","gists_url":"https://api.github.com/users/vchudnov-g/gists{/gist_id}","starred_url":"https://api.github.com/users/vchudnov-g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vchudnov-g/subscriptions","organizations_url":"https://api.github.com/users/vchudnov-g/orgs","repos_url":"https://api.github.com/users/vchudnov-g/repos","events_url":"https://api.github.com/users/vchudnov-g/events{/privacy}","received_events_url":"https://api.github.com/users/vchudnov-g/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2017-02-03T20:30:00Z","updated_at":"2017-02-03T21:27:21Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/googleapis/toolkit/pulls/986","html_url":"https://github.com/googleapis/toolkit/pull/986","diff_url":"https://github.com/googleapis/toolkit/pull/986.diff","patch_url":"https://github.com/googleapis/toolkit/pull/986.patch"},"body":"Addresses https://github.com/googleapis/toolkit/issues/692."},"comment":{"url":"https://api.github.com/repos/googleapis/toolkit/issues/comments/277366669","html_url":"https://github.com/googleapis/toolkit/pull/986#issuecomment-277366669","issue_url":"https://api.github.com/repos/googleapis/toolkit/issues/986","id":277366669,"user":{"login":"codecov-io","id":8655789,"avatar_url":"https://avatars.githubusercontent.com/u/8655789?v=3","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2017-02-03T21:27:21Z","updated_at":"2017-02-03T21:27:21Z","body":"# [Codecov](https://codecov.io/gh/googleapis/toolkit/pull/986?src=pr&el=h1) Report\n> Merging [#986](https://codecov.io/gh/googleapis/toolkit/pull/986?src=pr&el=desc) into [master](https://codecov.io/gh/googleapis/toolkit/commit/c9450a46a19d17970bc76c7c3b36580627042aa8?src=pr&el=desc) will **increase** coverage by `-1.17%`.\n\n\n```diff\n@@             Coverage Diff              @@\n##             master     #986      +/-   ##\n============================================\n- Coverage     85.18%   84.02%   -1.17%     \n+ Complexity     3341     3303      -38     \n============================================\n  Files           340      340              \n  Lines         13340    10060    -3280     \n  Branches       1513     1424      -89     \n============================================\n- Hits          11364     8453    -2911     \n+ Misses         1543     1177     -366     \n+ Partials        433      430       -3\n```\n\n\n| [Impacted Files](https://codecov.io/gh/googleapis/toolkit/pull/986?src=pr&el=tree) | Coverage Δ | Complexity Δ | |\n|---|---|---|---|\n| [...former/ruby/RubySampleMethodToViewTransformer.java](https://codecov.io/gh/googleapis/toolkit/compare/c9450a46a19d17970bc76c7c3b36580627042aa8...92e8e8baea74720ea68eee58cf4b668fd3895881?src=pr&el=tree#diff-c3JjL21haW4vamF2YS9jb20vZ29vZ2xlL2FwaS9jb2RlZ2VuL2Rpc2NvdmVyeS90cmFuc2Zvcm1lci9ydWJ5L1J1YnlTYW1wbGVNZXRob2RUb1ZpZXdUcmFuc2Zvcm1lci5qYXZh) | `97.29% <100%> (-0.94%)` | `20 <ø> (+2)` | |\n| [.../transformer/py/PythonSampleTypeNameConverter.java](https://codecov.io/gh/googleapis/toolkit/compare/c9450a46a19d17970bc76c7c3b36580627042aa8...92e8e8baea74720ea68eee58cf4b668fd3895881?src=pr&el=tree#diff-c3JjL21haW4vamF2YS9jb20vZ29vZ2xlL2FwaS9jb2RlZ2VuL2Rpc2NvdmVyeS90cmFuc2Zvcm1lci9weS9QeXRob25TYW1wbGVUeXBlTmFtZUNvbnZlcnRlci5qYXZh) | `42.85% <ø> (-36.64%)` | `4% <ø> (-1%)` | |\n| [...very/transformer/js/JSSampleTypeNameConverter.java](https://codecov.io/gh/googleapis/toolkit/compare/c9450a46a19d17970bc76c7c3b36580627042aa8...92e8e8baea74720ea68eee58cf4b668fd3895881?src=pr&el=tree#diff-c3JjL21haW4vamF2YS9jb20vZ29vZ2xlL2FwaS9jb2RlZ2VuL2Rpc2NvdmVyeS90cmFuc2Zvcm1lci9qcy9KU1NhbXBsZVR5cGVOYW1lQ29udmVydGVyLmphdmE=) | `38.46% <ø> (-28.21%)` | `7% <ø> (-1%)` | |\n| [...ry/transformer/php/PhpSampleTypeNameConverter.java](https://codecov.io/gh/googleapis/toolkit/compare/c9450a46a19d17970bc76c7c3b36580627042aa8...92e8e8baea74720ea68eee58cf4b668fd3895881?src=pr&el=tree#diff-c3JjL21haW4vamF2YS9jb20vZ29vZ2xlL2FwaS9jb2RlZ2VuL2Rpc2NvdmVyeS90cmFuc2Zvcm1lci9waHAvUGhwU2FtcGxlVHlwZU5hbWVDb252ZXJ0ZXIuamF2YQ==) | `50% <ø> (-27.28%)` | `6% <ø> (-1%)` | |\n| [.../transformer/ruby/RubySampleTypeNameConverter.java](https://codecov.io/gh/googleapis/toolkit/compare/c9450a46a19d17970bc76c7c3b36580627042aa8...92e8e8baea74720ea68eee58cf4b668fd3895881?src=pr&el=tree#diff-c3JjL21haW4vamF2YS9jb20vZ29vZ2xlL2FwaS9jb2RlZ2VuL2Rpc2NvdmVyeS90cmFuc2Zvcm1lci9ydWJ5L1J1YnlTYW1wbGVUeXBlTmFtZUNvbnZlcnRlci5qYXZh) | `46.66% <ø> (-23.71%)` | `6% <ø> (ø)` | |\n| [...very/transformer/go/GoSampleTypeNameConverter.java](https://codecov.io/gh/googleapis/toolkit/compare/c9450a46a19d17970bc76c7c3b36580627042aa8...92e8e8baea74720ea68eee58cf4b668fd3895881?src=pr&el=tree#diff-c3JjL21haW4vamF2YS9jb20vZ29vZ2xlL2FwaS9jb2RlZ2VuL2Rpc2NvdmVyeS90cmFuc2Zvcm1lci9nby9Hb1NhbXBsZVR5cGVOYW1lQ29udmVydGVyLmphdmE=) | `50% <ø> (-22.42%)` | `8% <ø> (-1%)` | |\n| [.../java/com/google/api/codegen/SnippetSetRunner.java](https://codecov.io/gh/googleapis/toolkit/compare/c9450a46a19d17970bc76c7c3b36580627042aa8...92e8e8baea74720ea68eee58cf4b668fd3895881?src=pr&el=tree#diff-c3JjL21haW4vamF2YS9jb20vZ29vZ2xlL2FwaS9jb2RlZ2VuL1NuaXBwZXRTZXRSdW5uZXIuamF2YQ==) | `33.33% <ø> (-16.67%)` | `1% <ø> (ø)` | |\n| [...n/transformer/ruby/RubyModelTypeNameConverter.java](https://codecov.io/gh/googleapis/toolkit/compare/c9450a46a19d17970bc76c7c3b36580627042aa8...92e8e8baea74720ea68eee58cf4b668fd3895881?src=pr&el=tree#diff-c3JjL21haW4vamF2YS9jb20vZ29vZ2xlL2FwaS9jb2RlZ2VuL3RyYW5zZm9ybWVyL3J1YnkvUnVieU1vZGVsVHlwZU5hbWVDb252ZXJ0ZXIuamF2YQ==) | `65% <ø> (-16.34%)` | `15% <ø> (-1%)` | |\n| [...odegen/discovery/MainDiscoveryProviderFactory.java](https://codecov.io/gh/googleapis/toolkit/compare/c9450a46a19d17970bc76c7c3b36580627042aa8...92e8e8baea74720ea68eee58cf4b668fd3895881?src=pr&el=tree#diff-c3JjL21haW4vamF2YS9jb20vZ29vZ2xlL2FwaS9jb2RlZ2VuL2Rpc2NvdmVyeS9NYWluRGlzY292ZXJ5UHJvdmlkZXJGYWN0b3J5LmphdmE=) | `72.72% <ø> (-15.96%)` | `5% <ø> (-1%)` | |\n| [...ansformer/nodejs/NodeJSModelTypeNameConverter.java](https://codecov.io/gh/googleapis/toolkit/compare/c9450a46a19d17970bc76c7c3b36580627042aa8...92e8e8baea74720ea68eee58cf4b668fd3895881?src=pr&el=tree#diff-c3JjL21haW4vamF2YS9jb20vZ29vZ2xlL2FwaS9jb2RlZ2VuL3RyYW5zZm9ybWVyL25vZGVqcy9Ob2RlSlNNb2RlbFR5cGVOYW1lQ29udmVydGVyLmphdmE=) | `68.29% <ø> (-14.38%)` | `16% <ø> (-1%)` | |\n| ... and [151 more](https://codecov.io/gh/googleapis/toolkit/pull/986/changes?src=pr&el=tree-more) | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/googleapis/toolkit/pull/986?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/googleapis/toolkit/pull/986?src=pr&el=footer). Last update [c9450a4...2c7cb50](https://codecov.io/gh/googleapis/toolkit/compare/c9450a46a19d17970bc76c7c3b36580627042aa8...2c7cb50343983e95dca48fc72ff421f8d0965297?src=pr&el=footer&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments)."}}
{"actor":{"display_login":"codecov-io"}}