{"action":"created","issue":{"url":"https://api.github.com/repos/consul/consul/issues/1877","repository_url":"https://api.github.com/repos/consul/consul","labels_url":"https://api.github.com/repos/consul/consul/issues/1877/labels{/name}","comments_url":"https://api.github.com/repos/consul/consul/issues/1877/comments","events_url":"https://api.github.com/repos/consul/consul/issues/1877/events","html_url":"https://github.com/consul/consul/pull/1877","id":258063008,"number":1877,"title":"Improve A11y when using tab key","user":{"login":"aitbw","id":9470839,"avatar_url":"https://avatars1.githubusercontent.com/u/9470839?v=4","gravatar_id":"","url":"https://api.github.com/users/aitbw","html_url":"https://github.com/aitbw","followers_url":"https://api.github.com/users/aitbw/followers","following_url":"https://api.github.com/users/aitbw/following{/other_user}","gists_url":"https://api.github.com/users/aitbw/gists{/gist_id}","starred_url":"https://api.github.com/users/aitbw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aitbw/subscriptions","organizations_url":"https://api.github.com/users/aitbw/orgs","repos_url":"https://api.github.com/users/aitbw/repos","events_url":"https://api.github.com/users/aitbw/events{/privacy}","received_events_url":"https://api.github.com/users/aitbw/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-09-15T14:38:37Z","updated_at":"2017-09-15T15:49:53Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/consul/consul/pulls/1877","html_url":"https://github.com/consul/consul/pull/1877","diff_url":"https://github.com/consul/consul/pull/1877.diff","patch_url":"https://github.com/consul/consul/pull/1877.patch"},"body":"Where\r\n=====\r\nFixes #1850\r\n\r\nWhat\r\n====\r\nBefore this change, when using the `tab` key on either Proposals or Debates pages **and** the user wasn't logged in, the \"You need to sign up or log in to continue\" message box wouldn't disappear unless the user hovered over said message box with the mouse, affecting the UX. This commit makes the aforementioned box to hide when focus is lost, whether the mouse or the `tab` key is used.\r\n\r\nHow\r\n===\r\nAdded the missing `blur`[1] event on the `app/assets/javascripts/votes.js.coffee` file.\r\n\r\nTest\r\n====\r\nSince this is a UX-related fix, manual testing is needed in order to see the changes.\r\n\r\nNotes\r\n====\r\n[1] [blur (event)](https://developer.mozilla.org/en-US/docs/Web/Events/blur) on MDN\r\n"},"comment":{"url":"https://api.github.com/repos/consul/consul/issues/comments/329822063","html_url":"https://github.com/consul/consul/pull/1877#issuecomment-329822063","issue_url":"https://api.github.com/repos/consul/consul/issues/1877","id":329822063,"user":{"login":"decabeza","id":631897,"avatar_url":"https://avatars0.githubusercontent.com/u/631897?v=4","gravatar_id":"","url":"https://api.github.com/users/decabeza","html_url":"https://github.com/decabeza","followers_url":"https://api.github.com/users/decabeza/followers","following_url":"https://api.github.com/users/decabeza/following{/other_user}","gists_url":"https://api.github.com/users/decabeza/gists{/gist_id}","starred_url":"https://api.github.com/users/decabeza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/decabeza/subscriptions","organizations_url":"https://api.github.com/users/decabeza/orgs","repos_url":"https://api.github.com/users/decabeza/repos","events_url":"https://api.github.com/users/decabeza/events{/privacy}","received_events_url":"https://api.github.com/users/decabeza/received_events","type":"User","site_admin":false},"created_at":"2017-09-15T15:49:53Z","updated_at":"2017-09-15T15:49:53Z","author_association":"CONTRIBUTOR","body":"Hi @aitbw! thanks for the PR! \r\n\r\nThe message disappear 👍  but the user can't tab over \"sign in/sign up\" links 😞\r\n\r\nWith this changes the behaviour is:\r\n\r\n![tabs_now](https://user-images.githubusercontent.com/631897/30491484-b4cf4c00-9a3d-11e7-8e6b-2f71c50a5461.jpg)\r\n\r\nBut the desired behaviour is: 😌 \r\n(The user should be navigate over the links with the keyboard and after tab over a proposal and tab over next one keep seeing the number supports info)\r\n\r\n![tabs_desired](https://user-images.githubusercontent.com/631897/30491493-c2a592d0-9a3d-11e7-92f2-78efbe61cdf0.jpg)\r\n"}}
{"actor":{"display_login":"decabeza"}}