{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/13090","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/13090/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/13090/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/13090/events","html_url":"https://github.com/nodejs/node/pull/13090","id":229542532,"number":13090,"title":"dns: synchronize resolve() docs and code","user":{"login":"Trott","id":718899,"avatar_url":"https://avatars1.githubusercontent.com/u/718899?v=3","gravatar_id":"","url":"https://api.github.com/users/Trott","html_url":"https://github.com/Trott","followers_url":"https://api.github.com/users/Trott/followers","following_url":"https://api.github.com/users/Trott/following{/other_user}","gists_url":"https://api.github.com/users/Trott/gists{/gist_id}","starred_url":"https://api.github.com/users/Trott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Trott/subscriptions","organizations_url":"https://api.github.com/users/Trott/orgs","repos_url":"https://api.github.com/users/Trott/repos","events_url":"https://api.github.com/users/Trott/events{/privacy}","received_events_url":"https://api.github.com/users/Trott/received_events","type":"User","site_admin":false},"labels":[{"id":460561340,"url":"https://api.github.com/repos/nodejs/node/labels/ctc-review","name":"ctc-review","color":"f9d0c4","default":false},{"id":155435740,"url":"https://api.github.com/repos/nodejs/node/labels/dns","name":"dns","color":"fbca04","default":false},{"id":311670452,"url":"https://api.github.com/repos/nodejs/node/labels/dont-land-on-v4.x","name":"dont-land-on-v4.x","color":"fad8c7","default":false},{"id":364533783,"url":"https://api.github.com/repos/nodejs/node/labels/dont-land-on-v6.x","name":"dont-land-on-v6.x","color":"bfdadc","default":false},{"id":444372954,"url":"https://api.github.com/repos/nodejs/node/labels/dont-land-on-v7.x","name":"dont-land-on-v7.x","color":"fbca04","default":false},{"id":169485514,"url":"https://api.github.com/repos/nodejs/node/labels/semver-major","name":"semver-major","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2017-05-18T03:07:56Z","updated_at":"2017-05-28T15:06:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/13090","html_url":"https://github.com/nodejs/node/pull/13090","diff_url":"https://github.com/nodejs/node/pull/13090.diff","patch_url":"https://github.com/nodejs/node/pull/13090.patch"},"body":"Synchronize the argument list for `dns.resolve()` with what's in the\r\ndocumentation.\r\n\r\nImprove the error for a bad `rrtype` to be a `TypeError` rather than an\r\n`Error`.\r\n\r\n<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines)\r\n\r\n##### Affected core subsystem(s)\r\n<!-- Provide affected core subsystem(s) (like doc, cluster, crypto, etc). -->\r\ndns"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/304520719","html_url":"https://github.com/nodejs/node/pull/13090#issuecomment-304520719","issue_url":"https://api.github.com/repos/nodejs/node/issues/13090","id":304520719,"user":{"login":"silverwind","id":115237,"avatar_url":"https://avatars2.githubusercontent.com/u/115237?v=3","gravatar_id":"","url":"https://api.github.com/users/silverwind","html_url":"https://github.com/silverwind","followers_url":"https://api.github.com/users/silverwind/followers","following_url":"https://api.github.com/users/silverwind/following{/other_user}","gists_url":"https://api.github.com/users/silverwind/gists{/gist_id}","starred_url":"https://api.github.com/users/silverwind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silverwind/subscriptions","organizations_url":"https://api.github.com/users/silverwind/orgs","repos_url":"https://api.github.com/users/silverwind/repos","events_url":"https://api.github.com/users/silverwind/events{/privacy}","received_events_url":"https://api.github.com/users/silverwind/received_events","type":"User","site_admin":false},"created_at":"2017-05-28T15:06:44Z","updated_at":"2017-05-28T15:06:44Z","body":"`dns: Return TypeError on invalid input`"}}
{"actor":{"display_login":"silverwind"}}