{"action":"created","issue":{"url":"https://api.github.com/repos/CraftAcademy/library-challenge/issues/35","repository_url":"https://api.github.com/repos/CraftAcademy/library-challenge","labels_url":"https://api.github.com/repos/CraftAcademy/library-challenge/issues/35/labels{/name}","comments_url":"https://api.github.com/repos/CraftAcademy/library-challenge/issues/35/comments","events_url":"https://api.github.com/repos/CraftAcademy/library-challenge/issues/35/events","html_url":"https://github.com/CraftAcademy/library-challenge/pull/35","id":252623199,"number":35,"title":"WIP Library - Amanda","user":{"login":"Sajaas","id":29342045,"avatar_url":"https://avatars2.githubusercontent.com/u/29342045?v=4","gravatar_id":"","url":"https://api.github.com/users/Sajaas","html_url":"https://github.com/Sajaas","followers_url":"https://api.github.com/users/Sajaas/followers","following_url":"https://api.github.com/users/Sajaas/following{/other_user}","gists_url":"https://api.github.com/users/Sajaas/gists{/gist_id}","starred_url":"https://api.github.com/users/Sajaas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sajaas/subscriptions","organizations_url":"https://api.github.com/users/Sajaas/orgs","repos_url":"https://api.github.com/users/Sajaas/repos","events_url":"https://api.github.com/users/Sajaas/events{/privacy}","received_events_url":"https://api.github.com/users/Sajaas/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":25,"created_at":"2017-08-24T14:37:55Z","updated_at":"2017-08-27T12:25:14Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/CraftAcademy/library-challenge/pulls/35","html_url":"https://github.com/CraftAcademy/library-challenge/pull/35","diff_url":"https://github.com/CraftAcademy/library-challenge/pull/35.diff","patch_url":"https://github.com/CraftAcademy/library-challenge/pull/35.patch"},"body":"Stuff I've found out so far: \r\n\r\n*Write tests with Rspec from the start, and make specs more clean\r\n*Write simpler methods\r\n*Write a skeleton class with methods, but don't add code, so I can visualise the specs better\r\n*Don't add user input, or menus, or other more complicated things in the beginning - have a structure that works first\r\n*Make use of more classes for cleaner look (per example have a Library class, but make an UI Library class to add the user interface stuff)\r\n*I can look at Coverall file to see what parts are not covered by the tests\r\n*I don't know how to make simple tests for the parts with user input by gets.chomp. Mine are pretty messy.\r\n\r\nI started out good with doing tests first, but I got too enthusiastic when creating a menu, and did that before I made specs to test it. I will remember this when I start other projects,.\r\n\r\nI guess it sticks better if I understand WHY it's good to add tests first. It's hard to make the tests match the messy code afterwards, and organise the code to be able to write tests. So I will try to make the tests first even though I had problems visualising the code."},"comment":{"url":"https://api.github.com/repos/CraftAcademy/library-challenge/issues/comments/325195181","html_url":"https://github.com/CraftAcademy/library-challenge/pull/35#issuecomment-325195181","issue_url":"https://api.github.com/repos/CraftAcademy/library-challenge/issues/35","id":325195181,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars1.githubusercontent.com/u/2354108?v=4","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2017-08-27T12:25:14Z","updated_at":"2017-08-27T12:25:14Z","body":"\n[![Coverage Status](https://coveralls.io/builds/13006673/badge)](https://coveralls.io/builds/13006673)\n\nCoverage remained the same at 98.294% when pulling **3bb48567712146ef6b0acca1debf103e19b96d7b on Sajaas:library** into **45ed2517f945e4bd90b7c0a2dae91a296c87cc55 on CraftAcademy:master**.\n"}}
{"actor":{"display_login":"coveralls"}}