{"push_id":1713273811,"size":29,"distinct_size":29,"ref":"refs/heads/master","head":"85e2d2f91d9b63b10bc327f0fee5f47b3b67dc6a","before":"7010a7a76b8880c4bcf2f04f1da47e74487e2d85","commits":[{"sha":"d8c5869b7cab3fa38ef700748e118b564b4dbc25","author":{"name":"David Maicher","email":"3b8e10480754ba93523db5dc4626a5f001e54bb7@dmaicher.de"},"message":"[EventDispatcher] fix: unwrap listeners for correct info","distinct":true,"url":"https://api.github.com/repos/Playform/symfony/commits/d8c5869b7cab3fa38ef700748e118b564b4dbc25"},{"sha":"e9e4c7989450b5746e619a658277d0d0baa84944","author":{"name":"Fabien Potencier","email":"6094910757de3667a08340f5b21f6399d2ffcc52@gmail.com"},"message":"bug #22541 [EventDispatcher] fix: unwrap listeners for correct info (dmaicher)\n\nThis PR was merged into the 2.8 branch.\n\nDiscussion\n----------\n\n[EventDispatcher] fix: unwrap listeners for correct info\n\n| Q             | A\n| ------------- | ---\n| Branch?       | 2.8\n| Bug fix?      | yes\n| New feature?  | no\n| BC breaks?    | no\n| Deprecations? | no\n| Tests pass?   | yes\n| Fixed tickets | related to https://github.com/symfony/symfony/issues/22520\n| License       | MIT\n| Doc PR        | -\n\nFixes problem where listeners were displayed as `Symfony\\Component\\EventDispatcher\\Debug\\WrappedListener::__invoke() ` in the profiler. It now shows the correct callable.\n\nCommits\n-------\n\nd8c5869b7c [EventDispatcher] fix: unwrap listeners for correct info","distinct":true,"url":"https://api.github.com/repos/Playform/symfony/commits/e9e4c7989450b5746e619a658277d0d0baa84944"},{"sha":"b2b4faa3c03220a0dc5a6e23782402fe1dccd612","author":{"name":"insekticid","email":"114cdbcbadac3df2aa6a281aac01a94b539a3e9f@exploit.cz"},"message":"Allow Upper Case property names in ObjectNormalizer\n\n| Q                | A\n| ---------------- | -----\n| Bug report?      | yes\n| Feature request? | no\n| BC Break report? | yes\n| RFC?             | no\n| Symfony version  | 2.8.19\n\nSame problem that has been fixed here https://github.com/symfony/symfony/pull/22265\nand here https://github.com/api-platform/core/pull/1037\n\nObjectNormalizer returns $id instead of $Id. It is bad naming convention, but is possible\n\n```php\nclass Entity {\n    protected $Id;\n\n    public function getId()\n    {\n        return $this->Id;\n    }\n}\n```","distinct":true,"url":"https://api.github.com/repos/Playform/symfony/commits/b2b4faa3c03220a0dc5a6e23782402fe1dccd612"},{"sha":"8ea38b56e060e916489897999708cb77d84b599d","author":{"name":"Maxime Steinhausser","email":"c15649615d8ee0a20c0866ecc845c31cb9f5b608@users.noreply.github.com"},"message":"Fix minor typo in the main README.md","distinct":true,"url":"https://api.github.com/repos/Playform/symfony/commits/8ea38b56e060e916489897999708cb77d84b599d"},{"sha":"e0ff6e06c91f25f6fec18b0bae0e4cb5d8fc076f","author":{"name":"Nicolas Grekas","email":"ec5ccb19bcd9237073a700927cff7f3ddf333fd9@gmail.com"},"message":"minor #22559 Fix minor typo in the main README.md (ogizanagi)\n\nThis PR was merged into the 2.7 branch.\n\nDiscussion\n----------\n\nFix minor typo in the main README.md\n\n| Q             | A\n| ------------- | ---\n| Branch?       | 2.7\n| Bug fix?      | no\n| New feature?  | no\n| BC breaks?    | no\n| Deprecations? | no\n| Tests pass?   | yes\n| Fixed tickets | N/A\n| License       | MIT\n| Doc PR        | N/A\n\nCommits\n-------\n\n8ea38b5 Fix minor typo in the main README.md","distinct":true,"url":"https://api.github.com/repos/Playform/symfony/commits/e0ff6e06c91f25f6fec18b0bae0e4cb5d8fc076f"},{"sha":"13f17079ef2e79b75dffbc8c4f6f75e8025366f5","author":{"name":"Julien Falque","email":"7adf1cf7716996e165ee5fc2923a87f0f29772c9@gmail.com"},"message":"Add iconv extension to suggested dependencies","distinct":true,"url":"https://api.github.com/repos/Playform/symfony/commits/13f17079ef2e79b75dffbc8c4f6f75e8025366f5"},{"sha":"79b71c069dc2ecbafdce190b78f5a9f989ada033","author":{"name":"David Maicher","email":"3b8e10480754ba93523db5dc4626a5f001e54bb7@dmaicher.de"},"message":"[EventDispatcher] fix getting priorities of listeners during dispatch","distinct":true,"url":"https://api.github.com/repos/Playform/symfony/commits/79b71c069dc2ecbafdce190b78f5a9f989ada033"},{"sha":"c590e85c1b125a0d6098841a1e49a1fd327815a4","author":{"name":"Nicolas Grekas","email":"ec5ccb19bcd9237073a700927cff7f3ddf333fd9@gmail.com"},"message":"bug #22568 [EventDispatcher] fix getting priorities of listeners during dispatch (dmaicher)\n\nThis PR was merged into the 3.2 branch.\n\nDiscussion\n----------\n\n[EventDispatcher] fix getting priorities of listeners during dispatch\n\n| Q             | A\n| ------------- | ---\n| Branch?       | 3.2\n| Bug fix?      | yes\n| New feature?  | no\n| BC breaks?    | no\n| Deprecations? | no\n| Tests pass?   | yes\n| Fixed tickets | #22520\n| License       | MIT\n| Doc PR        | -\n\nThe WebProfiler collects listener info during dispatching the `kernel.terminate` event which caused issues while retrieving priorities as the wrappers are registered instead of the real listeners.\n\nCommits\n-------\n\n79b71c0 [EventDispatcher] fix getting priorities of listeners during dispatch","distinct":true,"url":"https://api.github.com/repos/Playform/symfony/commits/c590e85c1b125a0d6098841a1e49a1fd327815a4"},{"sha":"e843924c0399101f0894c637f118c6d249224c36","author":{"name":"Roland Franssen","email":"c3628ab9d4306339fe3068766bf9b4238b274356@gmail.com"},"message":"[Security] Fix phpdoc logout listener","distinct":true,"url":"https://api.github.com/repos/Playform/symfony/commits/e843924c0399101f0894c637f118c6d249224c36"},{"sha":"af15ead255ad4a282324cb8142e51c8a8f6f703c","author":{"name":"Fabien Potencier","email":"6094910757de3667a08340f5b21f6399d2ffcc52@gmail.com"},"message":"minor #22574 [Security] Fix phpdoc logout listener (ro0NL)\n\nThis PR was squashed before being merged into the 2.7 branch (closes #22574).\n\nDiscussion\n----------\n\n[Security] Fix phpdoc logout listener\n\n| Q             | A\n| ------------- | ---\n| Branch?       | 2.7\n| Bug fix?      | yes\n| New feature?  | no\n| BC breaks?    | no\n| Deprecations? | no\n| Tests pass?   | yes\n| Fixed tickets | #... <!-- #-prefixed issue number(s), if any -->\n| License       | MIT\n| Doc PR        | symfony/symfony-docs#... <!--highly recommended for new features-->\n\nSeparated from #22572\n\nCommits\n-------\n\ne843924c03 [Security] Fix phpdoc logout listener","distinct":true,"url":"https://api.github.com/repos/Playform/symfony/commits/af15ead255ad4a282324cb8142e51c8a8f6f703c"},{"sha":"3cc096b540be13f258283aa8aa7b4a6a130cee5e","author":{"name":"Ryan Weaver","email":"8f18e670ec432ee5e15365d38d203f741b57c02e@thatsquality.com"},"message":"[Asset] Starting slash should indicate no basePath wanted","distinct":true,"url":"https://api.github.com/repos/Playform/symfony/commits/3cc096b540be13f258283aa8aa7b4a6a130cee5e"},{"sha":"c669b88403479254921d8d962fc2919b88f9b9fe","author":{"name":"Fabien Potencier","email":"6094910757de3667a08340f5b21f6399d2ffcc52@gmail.com"},"message":"bug #22528 [Asset] Starting slash should indicate no basePath wanted (weaverryan)\n\nThis PR was squashed before being merged into the 2.7 branch (closes #22528).\n\nDiscussion\n----------\n\n[Asset] Starting slash should indicate no basePath wanted\n\n| Q             | A\n| ------------- | ---\n| Branch?       | 2.7\n| Bug fix?      | yes-ish... and no-ish\n| New feature?  | no\n| BC breaks?    | yes\n| Deprecations? | no\n| Tests pass?   | yes\n| Fixed tickets | n/a\n| License       | MIT\n| Doc PR        | n/a\n\n**Important** View the second commit for an accurate diff. The first commit just renames some strings in a test for clarity.\n\nWhen we moved `PathPackage` from `Templating` to `Asset`, we actually changed its behavior. Assume that we're deployed under a `/subdir` subdirectory:\n\n**Before** `{{ asset('/main.css') }}` would *not* have the base path prefixed -> `/main.css`\n\n**After** `{{ asset('/main.css') }}` *does* have the base path prefixed -> `/subdir/main.css`\n\nhttps://github.com/symfony/symfony/blob/3adff11d729ccdfc4eb4b189417ec04491c6eaad/src/Symfony/Component/Templating/Asset/PathPackage.php#L61-L63\n\nThis PR simply reverses that, to the *previous* behavior. This *is* a BC break... and also arguably a bug fix :). Interestingly, when we changed the behavior the first time (i.e. broke BC), I don't think that anyone noticed. It should only affect users deployed under a subdirectory.\n\nWhy do I care? I'm using the new `JsonManifestVersionStrategy` with a library that is outputting paths that *already* include my subdirectory:\n\n```json\n{\n    \"build/main.css\": \"/subdir/build/main.abc123.css\"\n}\n```\n\nSo, I do not want Symfony to detect the `/subdir` and apply it a second time.\n\nCommits\n-------\n\n3cc096b540 [Asset] Starting slash should indicate no basePath wanted","distinct":true,"url":"https://api.github.com/repos/Playform/symfony/commits/c669b88403479254921d8d962fc2919b88f9b9fe"},{"sha":"04e48bd1201c3cacae6cd5749c301ea72345c6c8","author":{"name":"Fabien Potencier","email":"6094910757de3667a08340f5b21f6399d2ffcc52@gmail.com"},"message":"minor #22557 [VarDumper] Add iconv dependency (julienfalque)\n\nThis PR was merged into the 2.8 branch.\n\nDiscussion\n----------\n\n[VarDumper] Add iconv dependency\n\n| Q             | A\n| ------------- | ---\n| Branch?       | 2.8\n| Bug fix?      | no\n| New feature?  | no\n| BC breaks?    | no\n| Deprecations? | no\n| Tests pass?   | yes\n| Fixed tickets | -\n| License       | MIT\n| Doc PR        | -\n\nAlternative to #20927.\n\nI still think adding `@requires extension iconv` to the related tests would be nice though: on some PHP setups the iconv extension is not available by default, those tests will fail and result in red errors when running the test suite, even when working on something unrelated. The test would still run on CI so it's fine IMO.\n\nShould I add `ext-iconv` and/or `symfony/polyfill` to `require-dev`?\n\n/cc @nicolas-grekas\n\nCommits\n-------\n\n13f17079ef Add iconv extension to suggested dependencies","distinct":true,"url":"https://api.github.com/repos/Playform/symfony/commits/04e48bd1201c3cacae6cd5749c301ea72345c6c8"},{"sha":"07fc0602e1f577aad38deaa986aa6113a7774c08","author":{"name":"Fabien Potencier","email":"6094910757de3667a08340f5b21f6399d2ffcc52@gmail.com"},"message":"bug #22550 Allow Upper Case property names in ObjectNormalizer (insekticid)\n\nThis PR was merged into the 2.8 branch.\n\nDiscussion\n----------\n\nAllow Upper Case property names in ObjectNormalizer\n\n| Q             | A\n| ------------- | ---\n| Branch?       | 2.8\n| Bug fix?      | yes\n| New feature?  | no\n| BC breaks?    | yes\n| Deprecations? | no\n| Tests pass?   | yes\n| Fixed tickets | #22547\n| License       | MIT\n\nSame problem that has been fixed here https://github.com/symfony/symfony/pull/22265\nand here https://github.com/api-platform/core/pull/1037\n\nObjectNormalizer returns $id instead of $Id. It is bad naming convention, but is possible\n\n```php\nclass Entity {\n    protected $Id;\n\n    public function getId()\n    {\n        return $this->Id;\n    }\n}\n```\n\nCommits\n-------\n\nb2b4faa3c0 Allow Upper Case property names in ObjectNormalizer","distinct":true,"url":"https://api.github.com/repos/Playform/symfony/commits/07fc0602e1f577aad38deaa986aa6113a7774c08"},{"sha":"12f1239565f94a4fc9d4593190f7bc59c2dd0743","author":{"name":"Tyson Andre","email":"d6be5114343ce16701945c805156715dce70f929@hotmail.com"},"message":"Fix minor phpdoc mismatches with the code(detected by phan)","distinct":true,"url":"https://api.github.com/repos/Playform/symfony/commits/12f1239565f94a4fc9d4593190f7bc59c2dd0743"},{"sha":"c84ee65b99c72faa9cf4e0ac53ee78b62151082d","author":{"name":"Fabien Potencier","email":"6094910757de3667a08340f5b21f6399d2ffcc52@gmail.com"},"message":"minor #22453 Fix minor phpdoc mismatches with the code(detected by phan) (TysonAndre)\n\nThis PR was squashed before being merged into the 2.7 branch (closes #22453).\n\nDiscussion\n----------\n\nFix minor phpdoc mismatches with the code(detected by phan)\n\n| Q             | A\n| ------------- | ---\n| Branch?       | master\n| Bug fix?      | no\n| New feature?  | no\n| BC breaks?    | no\n| Deprecations? | no\n| Tests pass?   | yes\n| Fixed tickets | none\n| License       | MIT\n| Doc PR        | no\n\nFix minor mismatches between phpdoc and the type of the code itself, detected by etsy/phan (Prevent confusion in the future)\nThe actual return types of a few functions have changed from int to bool where preg_match or `&` was used.\nFix optional param before required param in src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php\n\nThe config used and the rest of the output is at https://gist.github.com/TysonAndre/91bed0e16583301f1e6e5cc2a4807081 (Uses some patches to etsy/phan that weren't merged to master yet)\n\nCommits\n-------\n\n12f1239565 Fix minor phpdoc mismatches with the code(detected by phan)","distinct":true,"url":"https://api.github.com/repos/Playform/symfony/commits/c84ee65b99c72faa9cf4e0ac53ee78b62151082d"},{"sha":"96743e69ad0fd8e8c01cabb825881313217e788f","author":{"name":"Maxime Steinhausser","email":"164598caf4e3289b2c0beab72e6571e044449057@gmail.com"},"message":"[Profiler] DataCollector: Remove unused static property","distinct":true,"url":"https://api.github.com/repos/Playform/symfony/commits/96743e69ad0fd8e8c01cabb825881313217e788f"},{"sha":"037a782b9114ba8b049ef214f6af3f21596785ad","author":{"name":"Ryan Weaver","email":"8f18e670ec432ee5e15365d38d203f741b57c02e@thatsquality.com"},"message":"Making tags under _defaults always apply and removing inherit_tags entirely\n\nNow that inherit_tags has been removed, 3.3 has the same functionality as 3.2: tags\nare *never* cascaded from parent to child (but you tags do inherit from defaults\nto a service and instanceof to a service).","distinct":true,"url":"https://api.github.com/repos/Playform/symfony/commits/037a782b9114ba8b049ef214f6af3f21596785ad"},{"sha":"2d88787b1f5e23910a0a97bfcdee4b542149a32e","author":{"name":"Fabien Potencier","email":"6094910757de3667a08340f5b21f6399d2ffcc52@gmail.com"},"message":"feature #22530 Making tags under _defaults always apply (weaverryan)\n\nThis PR was merged into the 3.3-dev branch.\n\nDiscussion\n----------\n\nMaking tags under _defaults always apply\n\n| Q             | A\n| ------------- | ---\n| Branch?       | master\n| Bug fix?      | no\n| New feature?  | no\n| BC breaks?    | no\n| Deprecations? | no\n| Tests pass?   | yes\n| Fixed tickets | #22497\n| License       | MIT\n| Doc PR        | n/a\n\nObviously, things under `_defaults` are applied to all services in that file. However, tags was an exception: it was *not* applied unless you have `inherit_tags`. The correct behavior is subjective, but after talking about it today, we (mostly) decided that tags *should* always apply. This does exactly that.\n\nOne side-effect (explained in the commit message) is that if you have a parent and child service both in the same file, the tag from `_defaults` is applied twice. I think that makes sense, and at some point, we can't protect the users from their own configuration :). This kind of \"weird\" behavior is likely not a problem, as compiler passes now handle multiple tags well AND it only affects a case where the user has added tags to `_defaults` *and* is using parent-child definitions. That's quite a strange mixture of conditions :).\n\nCheers!\n\nCommits\n-------\n\n037a782b91 Making tags under _defaults always apply and removing inherit_tags entirely","distinct":true,"url":"https://api.github.com/repos/Playform/symfony/commits/2d88787b1f5e23910a0a97bfcdee4b542149a32e"},{"sha":"3c9a7e4dc5241b273c126317ee3db21d0d2b5cdc","author":{"name":"Fabien Potencier","email":"6094910757de3667a08340f5b21f6399d2ffcc52@gmail.com"},"message":"minor #22591 [Profiler] DataCollector: Remove unused static property (ogizanagi)\n\nThis PR was merged into the 3.3-dev branch.\n\nDiscussion\n----------\n\n[Profiler] DataCollector: Remove unused static property\n\n| Q             | A\n| ------------- | ---\n| Branch?       | master\n| Bug fix?      | no\n| New feature?  | no\n| BC breaks?    | no\n| Deprecations? | no\n| Tests pass?   | yes\n| Fixed tickets | N/A\n| License       | MIT\n| Doc PR        | N/A\n\nUnless I missed something, any usage of this property were removed in https://github.com/symfony/symfony/pull/21638.\n\nCommits\n-------\n\n96743e69ad [Profiler] DataCollector: Remove unused static property","distinct":true,"url":"https://api.github.com/repos/Playform/symfony/commits/3c9a7e4dc5241b273c126317ee3db21d0d2b5cdc"}]}
{"actor":{"display_login":"nhristov"}}