{"action":"created","comment":{"url":"https://api.github.com/repos/pravega/pravega/pulls/comments/127501370","pull_request_review_id":50097688,"id":127501370,"diff_hunk":"@@ -127,20 +127,22 @@ private App createPravegaSegmentStoreApp() {\n         //set env\n         String zk = zkUri.getHost() + \":\" + ZKSERVICE_ZKPORT;\n \n-        //System properties to configure SS service.\n-        String hostSystemProperties = setSystemProperty(\"pravegaservice.zkURL\", zk) +\n-                setSystemProperty(\"bookkeeper.zkAddress\", zk) +\n-                setSystemProperty(\"hdfs.hdfsUrl\", \"hdfs.marathon.containerip.dcos.thisdcos.directory:8020\") +\n-                setSystemProperty(\"autoScale.muteInSeconds\", \"120\") +\n+        //Environment variables to configure SS service.\n+        Map<String, String> map = new HashMap<>();\n+        map.put(\"ZK_URL\", zk);\n+        map.put(\"BK_ZK_URL\", zk);\n+        map.put(\"HDFS_URL\", \"hdfs.marathon.containerip.dcos.thisdcos.directory:8020\");\n+        map.put(\"CONTROLLER_URL\", conUri.toString());\n+        map.put(\"TIER2_STORAGE\", \"HDFS\");\n+\n+        //Properties set to override defaults for system tests\n+        String hostSystemProperties = setSystemProperty(\"autoScale.muteInSeconds\", \"120\") +","path":"test/system/src/main/java/io/pravega/test/system/framework/services/PravegaSegmentStoreService.java","position":18,"original_position":18,"commit_id":"29026b457c43077e6bbf18bb38c97dab8c902e28","original_commit_id":"29026b457c43077e6bbf18bb38c97dab8c902e28","user":{"login":"arvindkandhare","id":2305381,"avatar_url":"https://avatars5.githubusercontent.com/u/2305381?v=4","gravatar_id":"","url":"https://api.github.com/users/arvindkandhare","html_url":"https://github.com/arvindkandhare","followers_url":"https://api.github.com/users/arvindkandhare/followers","following_url":"https://api.github.com/users/arvindkandhare/following{/other_user}","gists_url":"https://api.github.com/users/arvindkandhare/gists{/gist_id}","starred_url":"https://api.github.com/users/arvindkandhare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arvindkandhare/subscriptions","organizations_url":"https://api.github.com/users/arvindkandhare/orgs","repos_url":"https://api.github.com/users/arvindkandhare/repos","events_url":"https://api.github.com/users/arvindkandhare/events{/privacy}","received_events_url":"https://api.github.com/users/arvindkandhare/received_events","type":"User","site_admin":false},"body":"In a normal production run these environment variables are set. `entrypoint.sh` picks these up and interpretes these. System tests were taking a different path and setting `PRAVEGA_SEGMENTSTORE_OPTS` env variable. This is unnecessary divergence from production runs. With these changes, we set the variables that are expected by `entrypoint.sh`. System test specific configs are set using `PRAVEGA_SEGMENTSTORE_OPTS`.","created_at":"2017-07-14T16:58:05Z","updated_at":"2017-07-14T16:58:05Z","html_url":"https://github.com/pravega/pravega/pull/1581#discussion_r127501370","pull_request_url":"https://api.github.com/repos/pravega/pravega/pulls/1581","_links":{"self":{"href":"https://api.github.com/repos/pravega/pravega/pulls/comments/127501370"},"html":{"href":"https://github.com/pravega/pravega/pull/1581#discussion_r127501370"},"pull_request":{"href":"https://api.github.com/repos/pravega/pravega/pulls/1581"}}},"pull_request":{"url":"https://api.github.com/repos/pravega/pravega/pulls/1581","id":130472565,"html_url":"https://github.com/pravega/pravega/pull/1581","diff_url":"https://github.com/pravega/pravega/pull/1581.diff","patch_url":"https://github.com/pravega/pravega/pull/1581.patch","issue_url":"https://api.github.com/repos/pravega/pravega/issues/1581","number":1581,"state":"open","locked":false,"title":"Issue 1580:  System tests should follow the same path through entrypoint.sh as production deployment","user":{"login":"arvindkandhare","id":2305381,"avatar_url":"https://avatars5.githubusercontent.com/u/2305381?v=4","gravatar_id":"","url":"https://api.github.com/users/arvindkandhare","html_url":"https://github.com/arvindkandhare","followers_url":"https://api.github.com/users/arvindkandhare/followers","following_url":"https://api.github.com/users/arvindkandhare/following{/other_user}","gists_url":"https://api.github.com/users/arvindkandhare/gists{/gist_id}","starred_url":"https://api.github.com/users/arvindkandhare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arvindkandhare/subscriptions","organizations_url":"https://api.github.com/users/arvindkandhare/orgs","repos_url":"https://api.github.com/users/arvindkandhare/repos","events_url":"https://api.github.com/users/arvindkandhare/events{/privacy}","received_events_url":"https://api.github.com/users/arvindkandhare/received_events","type":"User","site_admin":false},"body":"**Change log description**\r\n- Sets the configuration through environment variables as the script `entrypoint.sh` uses in production deployment.\r\n- Overrides defaults using `PRAVEGA_SEGMENTSTORE_OPTS` as required  specifically for system tests.\r\n\r\n**Purpose of the change**\r\nTo ensure system test runs resembles the production runs.\r\nTo ensure that system tests are able to mount NFS directory when the tested with filesystem as tier2.\r\n\r\n**What the code does**\r\n- Sets the configuration through environment variables as the script `entrypoint.sh` uses in production deployment.\r\n- Overrides defaults using `PRAVEGA_SEGMENTSTORE_OPTS` as required  specifically for system tests.\r\n\r\n**How to verify it**\r\nSegmentstore comes up with the configured values.","created_at":"2017-07-13T21:33:41Z","updated_at":"2017-07-14T16:58:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"77248beae97acd1554324a89201953e687b14ff1","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/pravega/pravega/pulls/1581/commits","review_comments_url":"https://api.github.com/repos/pravega/pravega/pulls/1581/comments","review_comment_url":"https://api.github.com/repos/pravega/pravega/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pravega/pravega/issues/1581/comments","statuses_url":"https://api.github.com/repos/pravega/pravega/statuses/29026b457c43077e6bbf18bb38c97dab8c902e28","head":{"label":"arvindkandhare:issue-1580-systemtestsuseenvvars","ref":"issue-1580-systemtestsuseenvvars","sha":"29026b457c43077e6bbf18bb38c97dab8c902e28","user":{"login":"arvindkandhare","id":2305381,"avatar_url":"https://avatars5.githubusercontent.com/u/2305381?v=4","gravatar_id":"","url":"https://api.github.com/users/arvindkandhare","html_url":"https://github.com/arvindkandhare","followers_url":"https://api.github.com/users/arvindkandhare/followers","following_url":"https://api.github.com/users/arvindkandhare/following{/other_user}","gists_url":"https://api.github.com/users/arvindkandhare/gists{/gist_id}","starred_url":"https://api.github.com/users/arvindkandhare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arvindkandhare/subscriptions","organizations_url":"https://api.github.com/users/arvindkandhare/orgs","repos_url":"https://api.github.com/users/arvindkandhare/repos","events_url":"https://api.github.com/users/arvindkandhare/events{/privacy}","received_events_url":"https://api.github.com/users/arvindkandhare/received_events","type":"User","site_admin":false},"repo":{"id":90913273,"name":"pravega","full_name":"arvindkandhare/pravega","owner":{"login":"arvindkandhare","id":2305381,"avatar_url":"https://avatars5.githubusercontent.com/u/2305381?v=4","gravatar_id":"","url":"https://api.github.com/users/arvindkandhare","html_url":"https://github.com/arvindkandhare","followers_url":"https://api.github.com/users/arvindkandhare/followers","following_url":"https://api.github.com/users/arvindkandhare/following{/other_user}","gists_url":"https://api.github.com/users/arvindkandhare/gists{/gist_id}","starred_url":"https://api.github.com/users/arvindkandhare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arvindkandhare/subscriptions","organizations_url":"https://api.github.com/users/arvindkandhare/orgs","repos_url":"https://api.github.com/users/arvindkandhare/repos","events_url":"https://api.github.com/users/arvindkandhare/events{/privacy}","received_events_url":"https://api.github.com/users/arvindkandhare/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/arvindkandhare/pravega","description":"Pravega - Streaming as a new software defined storage primitive","fork":true,"url":"https://api.github.com/repos/arvindkandhare/pravega","forks_url":"https://api.github.com/repos/arvindkandhare/pravega/forks","keys_url":"https://api.github.com/repos/arvindkandhare/pravega/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arvindkandhare/pravega/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arvindkandhare/pravega/teams","hooks_url":"https://api.github.com/repos/arvindkandhare/pravega/hooks","issue_events_url":"https://api.github.com/repos/arvindkandhare/pravega/issues/events{/number}","events_url":"https://api.github.com/repos/arvindkandhare/pravega/events","assignees_url":"https://api.github.com/repos/arvindkandhare/pravega/assignees{/user}","branches_url":"https://api.github.com/repos/arvindkandhare/pravega/branches{/branch}","tags_url":"https://api.github.com/repos/arvindkandhare/pravega/tags","blobs_url":"https://api.github.com/repos/arvindkandhare/pravega/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arvindkandhare/pravega/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arvindkandhare/pravega/git/refs{/sha}","trees_url":"https://api.github.com/repos/arvindkandhare/pravega/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arvindkandhare/pravega/statuses/{sha}","languages_url":"https://api.github.com/repos/arvindkandhare/pravega/languages","stargazers_url":"https://api.github.com/repos/arvindkandhare/pravega/stargazers","contributors_url":"https://api.github.com/repos/arvindkandhare/pravega/contributors","subscribers_url":"https://api.github.com/repos/arvindkandhare/pravega/subscribers","subscription_url":"https://api.github.com/repos/arvindkandhare/pravega/subscription","commits_url":"https://api.github.com/repos/arvindkandhare/pravega/commits{/sha}","git_commits_url":"https://api.github.com/repos/arvindkandhare/pravega/git/commits{/sha}","comments_url":"https://api.github.com/repos/arvindkandhare/pravega/comments{/number}","issue_comment_url":"https://api.github.com/repos/arvindkandhare/pravega/issues/comments{/number}","contents_url":"https://api.github.com/repos/arvindkandhare/pravega/contents/{+path}","compare_url":"https://api.github.com/repos/arvindkandhare/pravega/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arvindkandhare/pravega/merges","archive_url":"https://api.github.com/repos/arvindkandhare/pravega/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arvindkandhare/pravega/downloads","issues_url":"https://api.github.com/repos/arvindkandhare/pravega/issues{/number}","pulls_url":"https://api.github.com/repos/arvindkandhare/pravega/pulls{/number}","milestones_url":"https://api.github.com/repos/arvindkandhare/pravega/milestones{/number}","notifications_url":"https://api.github.com/repos/arvindkandhare/pravega/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arvindkandhare/pravega/labels{/name}","releases_url":"https://api.github.com/repos/arvindkandhare/pravega/releases{/id}","deployments_url":"https://api.github.com/repos/arvindkandhare/pravega/deployments","created_at":"2017-05-10T22:21:45Z","updated_at":"2017-05-10T22:21:49Z","pushed_at":"2017-07-14T13:59:49Z","git_url":"git://github.com/arvindkandhare/pravega.git","ssh_url":"git@github.com:arvindkandhare/pravega.git","clone_url":"https://github.com/arvindkandhare/pravega.git","svn_url":"https://github.com/arvindkandhare/pravega","homepage":"http://pravega.io","size":19842,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pravega:master","ref":"master","sha":"52745f3189c95ef64468971bc26bccf6fd0483e7","user":{"login":"pravega","id":25698199,"avatar_url":"https://avatars5.githubusercontent.com/u/25698199?v=4","gravatar_id":"","url":"https://api.github.com/users/pravega","html_url":"https://github.com/pravega","followers_url":"https://api.github.com/users/pravega/followers","following_url":"https://api.github.com/users/pravega/following{/other_user}","gists_url":"https://api.github.com/users/pravega/gists{/gist_id}","starred_url":"https://api.github.com/users/pravega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pravega/subscriptions","organizations_url":"https://api.github.com/users/pravega/orgs","repos_url":"https://api.github.com/users/pravega/repos","events_url":"https://api.github.com/users/pravega/events{/privacy}","received_events_url":"https://api.github.com/users/pravega/received_events","type":"Organization","site_admin":false},"repo":{"id":63096822,"name":"pravega","full_name":"pravega/pravega","owner":{"login":"pravega","id":25698199,"avatar_url":"https://avatars5.githubusercontent.com/u/25698199?v=4","gravatar_id":"","url":"https://api.github.com/users/pravega","html_url":"https://github.com/pravega","followers_url":"https://api.github.com/users/pravega/followers","following_url":"https://api.github.com/users/pravega/following{/other_user}","gists_url":"https://api.github.com/users/pravega/gists{/gist_id}","starred_url":"https://api.github.com/users/pravega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pravega/subscriptions","organizations_url":"https://api.github.com/users/pravega/orgs","repos_url":"https://api.github.com/users/pravega/repos","events_url":"https://api.github.com/users/pravega/events{/privacy}","received_events_url":"https://api.github.com/users/pravega/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pravega/pravega","description":"Pravega - Streaming as a new software defined storage primitive","fork":false,"url":"https://api.github.com/repos/pravega/pravega","forks_url":"https://api.github.com/repos/pravega/pravega/forks","keys_url":"https://api.github.com/repos/pravega/pravega/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pravega/pravega/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pravega/pravega/teams","hooks_url":"https://api.github.com/repos/pravega/pravega/hooks","issue_events_url":"https://api.github.com/repos/pravega/pravega/issues/events{/number}","events_url":"https://api.github.com/repos/pravega/pravega/events","assignees_url":"https://api.github.com/repos/pravega/pravega/assignees{/user}","branches_url":"https://api.github.com/repos/pravega/pravega/branches{/branch}","tags_url":"https://api.github.com/repos/pravega/pravega/tags","blobs_url":"https://api.github.com/repos/pravega/pravega/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pravega/pravega/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pravega/pravega/git/refs{/sha}","trees_url":"https://api.github.com/repos/pravega/pravega/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pravega/pravega/statuses/{sha}","languages_url":"https://api.github.com/repos/pravega/pravega/languages","stargazers_url":"https://api.github.com/repos/pravega/pravega/stargazers","contributors_url":"https://api.github.com/repos/pravega/pravega/contributors","subscribers_url":"https://api.github.com/repos/pravega/pravega/subscribers","subscription_url":"https://api.github.com/repos/pravega/pravega/subscription","commits_url":"https://api.github.com/repos/pravega/pravega/commits{/sha}","git_commits_url":"https://api.github.com/repos/pravega/pravega/git/commits{/sha}","comments_url":"https://api.github.com/repos/pravega/pravega/comments{/number}","issue_comment_url":"https://api.github.com/repos/pravega/pravega/issues/comments{/number}","contents_url":"https://api.github.com/repos/pravega/pravega/contents/{+path}","compare_url":"https://api.github.com/repos/pravega/pravega/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pravega/pravega/merges","archive_url":"https://api.github.com/repos/pravega/pravega/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pravega/pravega/downloads","issues_url":"https://api.github.com/repos/pravega/pravega/issues{/number}","pulls_url":"https://api.github.com/repos/pravega/pravega/pulls{/number}","milestones_url":"https://api.github.com/repos/pravega/pravega/milestones{/number}","notifications_url":"https://api.github.com/repos/pravega/pravega/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pravega/pravega/labels{/name}","releases_url":"https://api.github.com/repos/pravega/pravega/releases{/id}","deployments_url":"https://api.github.com/repos/pravega/pravega/deployments","created_at":"2016-07-11T19:41:03Z","updated_at":"2017-07-09T13:14:13Z","pushed_at":"2017-07-14T15:39:11Z","git_url":"git://github.com/pravega/pravega.git","ssh_url":"git@github.com:pravega/pravega.git","clone_url":"https://github.com/pravega/pravega.git","svn_url":"https://github.com/pravega/pravega","homepage":"http://pravega.io","size":19310,"stargazers_count":89,"watchers_count":89,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"open_issues_count":309,"forks":33,"open_issues":309,"watchers":89,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pravega/pravega/pulls/1581"},"html":{"href":"https://github.com/pravega/pravega/pull/1581"},"issue":{"href":"https://api.github.com/repos/pravega/pravega/issues/1581"},"comments":{"href":"https://api.github.com/repos/pravega/pravega/issues/1581/comments"},"review_comments":{"href":"https://api.github.com/repos/pravega/pravega/pulls/1581/comments"},"review_comment":{"href":"https://api.github.com/repos/pravega/pravega/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pravega/pravega/pulls/1581/commits"},"statuses":{"href":"https://api.github.com/repos/pravega/pravega/statuses/29026b457c43077e6bbf18bb38c97dab8c902e28"}}}}
{"actor":{"display_login":"arvindkandhare"}}