{"action":"created","comment":{"url":"https://api.github.com/repos/LBNL-UCB-STI/beam/pulls/comments/139051729","pull_request_review_id":62932435,"id":139051729,"diff_hunk":"@@ -76,7 +76,12 @@ beam.outputs.explodeEventsIntoFiles = false\n # Logging Levels:\n # >0 enables loggin, <=0 suppresses logging.\n # Any event types not explicitly listed take on Default.level\n-beam.outputs.defaultLoggingLevel = 1\n+# if defaultLoggingLevel is blank then it will treat as OFF.\n+beam.outputs.defaultLoggingLevel = \"SHORT\" # valid options:VERBOSE,REGULAR,SHORT,OFF\n+beam.outputs.VERBOSELoggingLevel = [\"time\",\"type\",\"person\",\"mode\",\"vehical\",\"departure_time\",\"link\"]","path":"test/input/beamville/beam.conf","position":7,"original_position":7,"commit_id":"40fe0b3d11c8115aa1bf74ad39989efc24c87b7b","original_commit_id":"40fe0b3d11c8115aa1bf74ad39989efc24c87b7b","user":{"login":"colinsheppard","id":333206,"avatar_url":"https://avatars3.githubusercontent.com/u/333206?v=4","gravatar_id":"","url":"https://api.github.com/users/colinsheppard","html_url":"https://github.com/colinsheppard","followers_url":"https://api.github.com/users/colinsheppard/followers","following_url":"https://api.github.com/users/colinsheppard/following{/other_user}","gists_url":"https://api.github.com/users/colinsheppard/gists{/gist_id}","starred_url":"https://api.github.com/users/colinsheppard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colinsheppard/subscriptions","organizations_url":"https://api.github.com/users/colinsheppard/orgs","repos_url":"https://api.github.com/users/colinsheppard/repos","events_url":"https://api.github.com/users/colinsheppard/events{/privacy}","received_events_url":"https://api.github.com/users/colinsheppard/received_events","type":"User","site_admin":false},"body":"this is better than before, but still needs to be revised. the problem is that the set of fields is different for each type of event and we will have 10-20 event types to specify, so I think it would be too much clutter to do this in the config file. rather we might do this in a class somewhere or from data.","created_at":"2017-09-15T02:24:21Z","updated_at":"2017-09-15T02:31:38Z","html_url":"https://github.com/LBNL-UCB-STI/beam/pull/94#discussion_r139051729","pull_request_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/pulls/94","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/LBNL-UCB-STI/beam/pulls/comments/139051729"},"html":{"href":"https://github.com/LBNL-UCB-STI/beam/pull/94#discussion_r139051729"},"pull_request":{"href":"https://api.github.com/repos/LBNL-UCB-STI/beam/pulls/94"}}},"pull_request":{"url":"https://api.github.com/repos/LBNL-UCB-STI/beam/pulls/94","id":140560310,"html_url":"https://github.com/LBNL-UCB-STI/beam/pull/94","diff_url":"https://github.com/LBNL-UCB-STI/beam/pull/94.diff","patch_url":"https://github.com/LBNL-UCB-STI/beam/pull/94.patch","issue_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/issues/94","number":94,"state":"open","locked":false,"title":"Made changes for event log controller","user":{"login":"avinashchavanfidel","id":31450294,"avatar_url":"https://avatars0.githubusercontent.com/u/31450294?v=4","gravatar_id":"","url":"https://api.github.com/users/avinashchavanfidel","html_url":"https://github.com/avinashchavanfidel","followers_url":"https://api.github.com/users/avinashchavanfidel/followers","following_url":"https://api.github.com/users/avinashchavanfidel/following{/other_user}","gists_url":"https://api.github.com/users/avinashchavanfidel/gists{/gist_id}","starred_url":"https://api.github.com/users/avinashchavanfidel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avinashchavanfidel/subscriptions","organizations_url":"https://api.github.com/users/avinashchavanfidel/orgs","repos_url":"https://api.github.com/users/avinashchavanfidel/repos","events_url":"https://api.github.com/users/avinashchavanfidel/events{/privacy}","received_events_url":"https://api.github.com/users/avinashchavanfidel/received_events","type":"User","site_admin":false},"body":"Hi @colinsheppard ,\r\n\r\nI have made changes in code to make the logger meaningful as well as I have shorter the event logs in xml file according to each level .\r\nI have attached each level event log xml file for your reference. Please review and let me know your thoughts about each level with the attribute which I have covered.\r\n\r\n\r\n[event_logs.zip](https://github.com/LBNL-UCB-STI/beam/files/1295828/event_logs.zip)\r\n","created_at":"2017-09-12T11:59:47Z","updated_at":"2017-09-15T02:31:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"76b979fc02d90c5ffa155b83a52e3fc365b1174d","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/pulls/94/commits","review_comments_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/pulls/94/comments","review_comment_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/issues/94/comments","statuses_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/statuses/40fe0b3d11c8115aa1bf74ad39989efc24c87b7b","head":{"label":"LBNL-UCB-STI:avn_logImprovement","ref":"avn_logImprovement","sha":"40fe0b3d11c8115aa1bf74ad39989efc24c87b7b","user":{"login":"LBNL-UCB-STI","id":26527414,"avatar_url":"https://avatars1.githubusercontent.com/u/26527414?v=4","gravatar_id":"","url":"https://api.github.com/users/LBNL-UCB-STI","html_url":"https://github.com/LBNL-UCB-STI","followers_url":"https://api.github.com/users/LBNL-UCB-STI/followers","following_url":"https://api.github.com/users/LBNL-UCB-STI/following{/other_user}","gists_url":"https://api.github.com/users/LBNL-UCB-STI/gists{/gist_id}","starred_url":"https://api.github.com/users/LBNL-UCB-STI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LBNL-UCB-STI/subscriptions","organizations_url":"https://api.github.com/users/LBNL-UCB-STI/orgs","repos_url":"https://api.github.com/users/LBNL-UCB-STI/repos","events_url":"https://api.github.com/users/LBNL-UCB-STI/events{/privacy}","received_events_url":"https://api.github.com/users/LBNL-UCB-STI/received_events","type":"Organization","site_admin":false},"repo":{"id":73118824,"name":"beam","full_name":"LBNL-UCB-STI/beam","owner":{"login":"LBNL-UCB-STI","id":26527414,"avatar_url":"https://avatars1.githubusercontent.com/u/26527414?v=4","gravatar_id":"","url":"https://api.github.com/users/LBNL-UCB-STI","html_url":"https://github.com/LBNL-UCB-STI","followers_url":"https://api.github.com/users/LBNL-UCB-STI/followers","following_url":"https://api.github.com/users/LBNL-UCB-STI/following{/other_user}","gists_url":"https://api.github.com/users/LBNL-UCB-STI/gists{/gist_id}","starred_url":"https://api.github.com/users/LBNL-UCB-STI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LBNL-UCB-STI/subscriptions","organizations_url":"https://api.github.com/users/LBNL-UCB-STI/orgs","repos_url":"https://api.github.com/users/LBNL-UCB-STI/repos","events_url":"https://api.github.com/users/LBNL-UCB-STI/events{/privacy}","received_events_url":"https://api.github.com/users/LBNL-UCB-STI/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LBNL-UCB-STI/beam","description":"The Framework for Modeling Behavior, Energy, Autonomy, and Mobility in Transportation Systems","fork":false,"url":"https://api.github.com/repos/LBNL-UCB-STI/beam","forks_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/forks","keys_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/teams","hooks_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/hooks","issue_events_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/issues/events{/number}","events_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/events","assignees_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/assignees{/user}","branches_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/branches{/branch}","tags_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/tags","blobs_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/statuses/{sha}","languages_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/languages","stargazers_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/stargazers","contributors_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/contributors","subscribers_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/subscribers","subscription_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/subscription","commits_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/contents/{+path}","compare_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/merges","archive_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/downloads","issues_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/issues{/number}","pulls_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/pulls{/number}","milestones_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/milestones{/number}","notifications_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/labels{/name}","releases_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/releases{/id}","deployments_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/deployments","created_at":"2016-11-07T20:38:29Z","updated_at":"2017-09-06T12:18:01Z","pushed_at":"2017-09-15T01:55:59Z","git_url":"git://github.com/LBNL-UCB-STI/beam.git","ssh_url":"git@github.com:LBNL-UCB-STI/beam.git","clone_url":"https://github.com/LBNL-UCB-STI/beam.git","svn_url":"https://github.com/LBNL-UCB-STI/beam","homepage":null,"size":4800,"stargazers_count":6,"watchers_count":6,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":29,"forks":3,"open_issues":29,"watchers":6,"default_branch":"master"}},"base":{"label":"LBNL-UCB-STI:agentsim","ref":"agentsim","sha":"2ca23de2b66cc6b25f22378a8acf99dd18dc78ef","user":{"login":"LBNL-UCB-STI","id":26527414,"avatar_url":"https://avatars1.githubusercontent.com/u/26527414?v=4","gravatar_id":"","url":"https://api.github.com/users/LBNL-UCB-STI","html_url":"https://github.com/LBNL-UCB-STI","followers_url":"https://api.github.com/users/LBNL-UCB-STI/followers","following_url":"https://api.github.com/users/LBNL-UCB-STI/following{/other_user}","gists_url":"https://api.github.com/users/LBNL-UCB-STI/gists{/gist_id}","starred_url":"https://api.github.com/users/LBNL-UCB-STI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LBNL-UCB-STI/subscriptions","organizations_url":"https://api.github.com/users/LBNL-UCB-STI/orgs","repos_url":"https://api.github.com/users/LBNL-UCB-STI/repos","events_url":"https://api.github.com/users/LBNL-UCB-STI/events{/privacy}","received_events_url":"https://api.github.com/users/LBNL-UCB-STI/received_events","type":"Organization","site_admin":false},"repo":{"id":73118824,"name":"beam","full_name":"LBNL-UCB-STI/beam","owner":{"login":"LBNL-UCB-STI","id":26527414,"avatar_url":"https://avatars1.githubusercontent.com/u/26527414?v=4","gravatar_id":"","url":"https://api.github.com/users/LBNL-UCB-STI","html_url":"https://github.com/LBNL-UCB-STI","followers_url":"https://api.github.com/users/LBNL-UCB-STI/followers","following_url":"https://api.github.com/users/LBNL-UCB-STI/following{/other_user}","gists_url":"https://api.github.com/users/LBNL-UCB-STI/gists{/gist_id}","starred_url":"https://api.github.com/users/LBNL-UCB-STI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LBNL-UCB-STI/subscriptions","organizations_url":"https://api.github.com/users/LBNL-UCB-STI/orgs","repos_url":"https://api.github.com/users/LBNL-UCB-STI/repos","events_url":"https://api.github.com/users/LBNL-UCB-STI/events{/privacy}","received_events_url":"https://api.github.com/users/LBNL-UCB-STI/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LBNL-UCB-STI/beam","description":"The Framework for Modeling Behavior, Energy, Autonomy, and Mobility in Transportation Systems","fork":false,"url":"https://api.github.com/repos/LBNL-UCB-STI/beam","forks_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/forks","keys_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/teams","hooks_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/hooks","issue_events_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/issues/events{/number}","events_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/events","assignees_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/assignees{/user}","branches_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/branches{/branch}","tags_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/tags","blobs_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/statuses/{sha}","languages_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/languages","stargazers_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/stargazers","contributors_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/contributors","subscribers_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/subscribers","subscription_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/subscription","commits_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/contents/{+path}","compare_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/merges","archive_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/downloads","issues_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/issues{/number}","pulls_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/pulls{/number}","milestones_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/milestones{/number}","notifications_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/labels{/name}","releases_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/releases{/id}","deployments_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/deployments","created_at":"2016-11-07T20:38:29Z","updated_at":"2017-09-06T12:18:01Z","pushed_at":"2017-09-15T01:55:59Z","git_url":"git://github.com/LBNL-UCB-STI/beam.git","ssh_url":"git@github.com:LBNL-UCB-STI/beam.git","clone_url":"https://github.com/LBNL-UCB-STI/beam.git","svn_url":"https://github.com/LBNL-UCB-STI/beam","homepage":null,"size":4800,"stargazers_count":6,"watchers_count":6,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":29,"forks":3,"open_issues":29,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/LBNL-UCB-STI/beam/pulls/94"},"html":{"href":"https://github.com/LBNL-UCB-STI/beam/pull/94"},"issue":{"href":"https://api.github.com/repos/LBNL-UCB-STI/beam/issues/94"},"comments":{"href":"https://api.github.com/repos/LBNL-UCB-STI/beam/issues/94/comments"},"review_comments":{"href":"https://api.github.com/repos/LBNL-UCB-STI/beam/pulls/94/comments"},"review_comment":{"href":"https://api.github.com/repos/LBNL-UCB-STI/beam/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LBNL-UCB-STI/beam/pulls/94/commits"},"statuses":{"href":"https://api.github.com/repos/LBNL-UCB-STI/beam/statuses/40fe0b3d11c8115aa1bf74ad39989efc24c87b7b"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"colinsheppard"}}