{"action":"created","issue":{"url":"https://api.github.com/repos/embulk/embulk/issues/735","repository_url":"https://api.github.com/repos/embulk/embulk","labels_url":"https://api.github.com/repos/embulk/embulk/issues/735/labels{/name}","comments_url":"https://api.github.com/repos/embulk/embulk/issues/735/comments","events_url":"https://api.github.com/repos/embulk/embulk/issues/735/events","html_url":"https://github.com/embulk/embulk/issues/735","id":244622996,"number":735,"title":"The LocalFileInputPlugin class should output log message **sorted** file lists. ","user":{"login":"hiroyuki-sato","id":767650,"avatar_url":"https://avatars0.githubusercontent.com/u/767650?v=4","gravatar_id":"","url":"https://api.github.com/users/hiroyuki-sato","html_url":"https://github.com/hiroyuki-sato","followers_url":"https://api.github.com/users/hiroyuki-sato/followers","following_url":"https://api.github.com/users/hiroyuki-sato/following{/other_user}","gists_url":"https://api.github.com/users/hiroyuki-sato/gists{/gist_id}","starred_url":"https://api.github.com/users/hiroyuki-sato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hiroyuki-sato/subscriptions","organizations_url":"https://api.github.com/users/hiroyuki-sato/orgs","repos_url":"https://api.github.com/users/hiroyuki-sato/repos","events_url":"https://api.github.com/users/hiroyuki-sato/events{/privacy}","received_events_url":"https://api.github.com/users/hiroyuki-sato/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-07-21T10:02:55Z","updated_at":"2017-07-22T07:15:14Z","closed_at":null,"body":"Related #733\r\n\r\n### Expect behavior\r\n\r\nThe LocalFileInputPlugin class should output log message **sorted** file lists. \r\n\r\n### Actual behavior\r\n\r\n```java\r\n// list files recursively\r\nList<String> files = listFiles(task);\r\nlog.info(\"Loading files {}\", files);\r\n```\r\n\r\nhttps://github.com/embulk/embulk/blob/1f3d322dd4921013d6cdd91a44c57a7278b19e6d/embulk-standards/src/main/java/org/embulk/standards/LocalFileInputPlugin.java#L70-L71\r\n\r\nThe listFiles() method in LocalFileInputPlugin returns **unsorted** file lists. \r\nSo, the log message outputs **unsorted** file lists too. \r\n\r\n```\r\n2017-07-21 11:10:27.275 +0200 [INFO] (0001:transaction): Loading files [sample/sample_03.txt, sample/sample_05.txt, sample/sample_01.txt, sample/sample_02.txt, sample/sample_04.txt, sample/sample_06.txt]\r\n```\r\n\r\n\r\nThis class called `sort` method after output log message.\r\nSo, users sometimes confuse about the load order. \r\n\r\n```java\r\nCollections.sort(files);\r\n```\r\n\r\nhttps://github.com/embulk/embulk/blob/1f3d322dd4921013d6cdd91a44c57a7278b19e6d/embulk-standards/src/main/java/org/embulk/standards/LocalFileInputPlugin.java#L100\r\n\r\n### Environment \r\n\r\n* Embulk 0.8.27\r\n"},"comment":{"url":"https://api.github.com/repos/embulk/embulk/issues/comments/317162598","html_url":"https://github.com/embulk/embulk/issues/735#issuecomment-317162598","issue_url":"https://api.github.com/repos/embulk/embulk/issues/735","id":317162598,"user":{"login":"dmikurube","id":723722,"avatar_url":"https://avatars2.githubusercontent.com/u/723722?v=4","gravatar_id":"","url":"https://api.github.com/users/dmikurube","html_url":"https://github.com/dmikurube","followers_url":"https://api.github.com/users/dmikurube/followers","following_url":"https://api.github.com/users/dmikurube/following{/other_user}","gists_url":"https://api.github.com/users/dmikurube/gists{/gist_id}","starred_url":"https://api.github.com/users/dmikurube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmikurube/subscriptions","organizations_url":"https://api.github.com/users/dmikurube/orgs","repos_url":"https://api.github.com/users/dmikurube/repos","events_url":"https://api.github.com/users/dmikurube/events{/privacy}","received_events_url":"https://api.github.com/users/dmikurube/received_events","type":"User","site_admin":false},"created_at":"2017-07-22T07:15:13Z","updated_at":"2017-07-22T07:15:13Z","body":"@hiroyuki-sato Sorry, I don't understand your point. Do you mean we need to sort just \"log messages\"?"}}
{"actor":{"display_login":"dmikurube"}}