{"action":"created","issue":{"url":"https://api.github.com/repos/mantidproject/mantid/issues/21083","repository_url":"https://api.github.com/repos/mantidproject/mantid","labels_url":"https://api.github.com/repos/mantidproject/mantid/issues/21083/labels{/name}","comments_url":"https://api.github.com/repos/mantidproject/mantid/issues/21083/comments","events_url":"https://api.github.com/repos/mantidproject/mantid/issues/21083/events","html_url":"https://github.com/mantidproject/mantid/pull/21083","id":269664536,"number":21083,"title":"Trust region code cleanup","user":{"login":"KarlPalmen","id":1133249,"avatar_url":"https://avatars1.githubusercontent.com/u/1133249?v=4","gravatar_id":"","url":"https://api.github.com/users/KarlPalmen","html_url":"https://github.com/KarlPalmen","followers_url":"https://api.github.com/users/KarlPalmen/followers","following_url":"https://api.github.com/users/KarlPalmen/following{/other_user}","gists_url":"https://api.github.com/users/KarlPalmen/gists{/gist_id}","starred_url":"https://api.github.com/users/KarlPalmen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KarlPalmen/subscriptions","organizations_url":"https://api.github.com/users/KarlPalmen/orgs","repos_url":"https://api.github.com/users/KarlPalmen/repos","events_url":"https://api.github.com/users/KarlPalmen/events{/privacy}","received_events_url":"https://api.github.com/users/KarlPalmen/received_events","type":"User","site_admin":false},"labels":[{"id":177556901,"url":"https://api.github.com/repos/mantidproject/mantid/labels/Misc:%20Maintenance","name":"Misc: Maintenance","color":"d4c5f9","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/mantidproject/mantid/milestones/65","html_url":"https://github.com/mantidproject/mantid/milestone/65","labels_url":"https://api.github.com/repos/mantidproject/mantid/milestones/65/labels","id":2590252,"number":65,"title":"Release 3.12","description":"","creator":{"login":"NickDraper","id":1017173,"avatar_url":"https://avatars1.githubusercontent.com/u/1017173?v=4","gravatar_id":"","url":"https://api.github.com/users/NickDraper","html_url":"https://github.com/NickDraper","followers_url":"https://api.github.com/users/NickDraper/followers","following_url":"https://api.github.com/users/NickDraper/following{/other_user}","gists_url":"https://api.github.com/users/NickDraper/gists{/gist_id}","starred_url":"https://api.github.com/users/NickDraper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NickDraper/subscriptions","organizations_url":"https://api.github.com/users/NickDraper/orgs","repos_url":"https://api.github.com/users/NickDraper/repos","events_url":"https://api.github.com/users/NickDraper/events{/privacy}","received_events_url":"https://api.github.com/users/NickDraper/received_events","type":"User","site_admin":false},"open_issues":274,"closed_issues":290,"state":"open","created_at":"2017-06-19T08:22:22Z","updated_at":"2017-11-08T12:08:52Z","due_on":"2018-02-05T08:00:00Z","closed_at":null},"comments":5,"created_at":"2017-10-30T16:25:33Z","updated_at":"2017-11-08T12:30:56Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/mantidproject/mantid/pulls/21083","html_url":"https://github.com/mantidproject/mantid/pull/21083","diff_url":"https://github.com/mantidproject/mantid/pull/21083.diff","patch_url":"https://github.com/mantidproject/mantid/pull/21083.patch"},"body":"Add unit tests for DTRS and MoreSorensen fitting function minimizers and tidy the code as described in the issue being fixed.\r\n\r\n**To test:**\r\n\r\nCode review, ensuring unit tests are adequate. You may also try fitting using these minimizers.\r\n\r\nFixes #16748 . \r\n\r\n**Release Notes** \r\n<!--\r\nMaintenance issue *Does not need to be in the release notes.*\r\n-->\r\n\r\n---\r\n\r\n#### Reviewer ####\r\n\r\nPlease comment on the following ([full description](http://www.mantidproject.org/Individual_Ticket_Testing)):\r\n\r\n##### Code Review #####\r\n\r\n- [ ] Is the code of an acceptable quality?\r\n- [ ] Does the code conform to the [coding standards](http://www.mantidproject.org/Coding_Standards)?\r\n- [ ] Are the unit tests small and test the class in isolation?\r\n- [ ] If there are changes in the release notes then do they describe the changes appropriately?\r\n\r\n##### Functional Tests #####\r\n\r\n- [ ] Do changes function as described? Add comments below that describe the tests performed?\r\n- [ ] Do the changes handle unexpected situations, e.g. bad input?\r\n- [ ] Has the relevant (user and developer) documentation been added/updated?\r\n\r\nDoes everything look good? Mark the review as **Approve**. A member of `@mantidproject/gatekeepers` will take care of it.\r\n"},"comment":{"url":"https://api.github.com/repos/mantidproject/mantid/issues/comments/342803818","html_url":"https://github.com/mantidproject/mantid/pull/21083#issuecomment-342803818","issue_url":"https://api.github.com/repos/mantidproject/mantid/issues/21083","id":342803818,"user":{"login":"Anders-Markvardsen","id":1135476,"avatar_url":"https://avatars3.githubusercontent.com/u/1135476?v=4","gravatar_id":"","url":"https://api.github.com/users/Anders-Markvardsen","html_url":"https://github.com/Anders-Markvardsen","followers_url":"https://api.github.com/users/Anders-Markvardsen/followers","following_url":"https://api.github.com/users/Anders-Markvardsen/following{/other_user}","gists_url":"https://api.github.com/users/Anders-Markvardsen/gists{/gist_id}","starred_url":"https://api.github.com/users/Anders-Markvardsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Anders-Markvardsen/subscriptions","organizations_url":"https://api.github.com/users/Anders-Markvardsen/orgs","repos_url":"https://api.github.com/users/Anders-Markvardsen/repos","events_url":"https://api.github.com/users/Anders-Markvardsen/events{/privacy}","received_events_url":"https://api.github.com/users/Anders-Markvardsen/received_events","type":"User","site_admin":false},"created_at":"2017-11-08T12:30:56Z","updated_at":"2017-11-08T12:30:56Z","author_association":"OWNER","body":"@KarlPalmen has NLLS_workspace been removed?"}}
{"actor":{"display_login":"Anders-Markvardsen"}}