{"action":"closed","number":56,"pull_request":{"url":"https://api.github.com/repos/zendframework/zend-filter/pulls/56","id":120923663,"html_url":"https://github.com/zendframework/zend-filter/pull/56","diff_url":"https://github.com/zendframework/zend-filter/pull/56.diff","patch_url":"https://github.com/zendframework/zend-filter/pull/56.patch","issue_url":"https://api.github.com/repos/zendframework/zend-filter/issues/56","number":56,"state":"closed","locked":false,"title":"Ensure `filters` config is honored in non-zend-mvc contexts","user":{"login":"weierophinney","id":25943,"avatar_url":"https://avatars2.githubusercontent.com/u/25943?v=3","gravatar_id":"","url":"https://api.github.com/users/weierophinney","html_url":"https://github.com/weierophinney","followers_url":"https://api.github.com/users/weierophinney/followers","following_url":"https://api.github.com/users/weierophinney/following{/other_user}","gists_url":"https://api.github.com/users/weierophinney/gists{/gist_id}","starred_url":"https://api.github.com/users/weierophinney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weierophinney/subscriptions","organizations_url":"https://api.github.com/users/weierophinney/orgs","repos_url":"https://api.github.com/users/weierophinney/repos","events_url":"https://api.github.com/users/weierophinney/events{/privacy}","received_events_url":"https://api.github.com/users/weierophinney/received_events","type":"User","site_admin":false},"body":"Per https://discourse.zendframework.com/t/validatormanager-not-calling-custom-validator-factory/109/5?u=matthew the `filters` config key is not honored currently unless the application is within a zend-mvc context. This is due to the fact that `Zend\\Filter\\Module` wires configuration for the `Zend\\ModuleManager\\Listener\\ServiceListener` in order to push merged service configuration into the plugin during bootstrap; no similar logic is available when not in a zend-mvc context, however.\n\nThis patch fixes that situation by modifying the `FilterPluginManagerFactory` to do the following:\n\n- If a `ServiceListener` service exists, it returns the plugin manager immediately (old behavior).\n- Otherwise, it checks for the `config` service, and, if found, a `filters` key with an array value. When found, it feeds that value to a `Zend\\ServiceManager\\Config` instance and uses that to configure the plugin manager before returning it.","created_at":"2017-05-16T20:55:59Z","updated_at":"2017-05-17T18:46:46Z","closed_at":"2017-05-17T18:46:46Z","merged_at":"2017-05-17T18:46:46Z","merge_commit_sha":"7fd57c946ac128fc7ba0272ab0edc279a0314cfe","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/zendframework/zend-filter/milestones/9","html_url":"https://github.com/zendframework/zend-filter/milestone/9","labels_url":"https://api.github.com/repos/zendframework/zend-filter/milestones/9/labels","id":2527598,"number":9,"title":"2.7.2","description":null,"creator":{"login":"weierophinney","id":25943,"avatar_url":"https://avatars2.githubusercontent.com/u/25943?v=3","gravatar_id":"","url":"https://api.github.com/users/weierophinney","html_url":"https://github.com/weierophinney","followers_url":"https://api.github.com/users/weierophinney/followers","following_url":"https://api.github.com/users/weierophinney/following{/other_user}","gists_url":"https://api.github.com/users/weierophinney/gists{/gist_id}","starred_url":"https://api.github.com/users/weierophinney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weierophinney/subscriptions","organizations_url":"https://api.github.com/users/weierophinney/orgs","repos_url":"https://api.github.com/users/weierophinney/repos","events_url":"https://api.github.com/users/weierophinney/events{/privacy}","received_events_url":"https://api.github.com/users/weierophinney/received_events","type":"User","site_admin":false},"open_issues":0,"closed_issues":1,"state":"open","created_at":"2017-05-17T18:46:13Z","updated_at":"2017-05-17T18:46:46Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/zendframework/zend-filter/pulls/56/commits","review_comments_url":"https://api.github.com/repos/zendframework/zend-filter/pulls/56/comments","review_comment_url":"https://api.github.com/repos/zendframework/zend-filter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zendframework/zend-filter/issues/56/comments","statuses_url":"https://api.github.com/repos/zendframework/zend-filter/statuses/7fd57c946ac128fc7ba0272ab0edc279a0314cfe","head":{"label":"weierophinney:hotfix/filters-service-config","ref":"hotfix/filters-service-config","sha":"7fd57c946ac128fc7ba0272ab0edc279a0314cfe","user":{"login":"weierophinney","id":25943,"avatar_url":"https://avatars2.githubusercontent.com/u/25943?v=3","gravatar_id":"","url":"https://api.github.com/users/weierophinney","html_url":"https://github.com/weierophinney","followers_url":"https://api.github.com/users/weierophinney/followers","following_url":"https://api.github.com/users/weierophinney/following{/other_user}","gists_url":"https://api.github.com/users/weierophinney/gists{/gist_id}","starred_url":"https://api.github.com/users/weierophinney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weierophinney/subscriptions","organizations_url":"https://api.github.com/users/weierophinney/orgs","repos_url":"https://api.github.com/users/weierophinney/repos","events_url":"https://api.github.com/users/weierophinney/events{/privacy}","received_events_url":"https://api.github.com/users/weierophinney/received_events","type":"User","site_admin":false},"repo":{"id":48446323,"name":"zend-filter","full_name":"weierophinney/zend-filter","owner":{"login":"weierophinney","id":25943,"avatar_url":"https://avatars2.githubusercontent.com/u/25943?v=3","gravatar_id":"","url":"https://api.github.com/users/weierophinney","html_url":"https://github.com/weierophinney","followers_url":"https://api.github.com/users/weierophinney/followers","following_url":"https://api.github.com/users/weierophinney/following{/other_user}","gists_url":"https://api.github.com/users/weierophinney/gists{/gist_id}","starred_url":"https://api.github.com/users/weierophinney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weierophinney/subscriptions","organizations_url":"https://api.github.com/users/weierophinney/orgs","repos_url":"https://api.github.com/users/weierophinney/repos","events_url":"https://api.github.com/users/weierophinney/events{/privacy}","received_events_url":"https://api.github.com/users/weierophinney/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/weierophinney/zend-filter","description":"Filter component from Zend Framework","fork":true,"url":"https://api.github.com/repos/weierophinney/zend-filter","forks_url":"https://api.github.com/repos/weierophinney/zend-filter/forks","keys_url":"https://api.github.com/repos/weierophinney/zend-filter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/weierophinney/zend-filter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/weierophinney/zend-filter/teams","hooks_url":"https://api.github.com/repos/weierophinney/zend-filter/hooks","issue_events_url":"https://api.github.com/repos/weierophinney/zend-filter/issues/events{/number}","events_url":"https://api.github.com/repos/weierophinney/zend-filter/events","assignees_url":"https://api.github.com/repos/weierophinney/zend-filter/assignees{/user}","branches_url":"https://api.github.com/repos/weierophinney/zend-filter/branches{/branch}","tags_url":"https://api.github.com/repos/weierophinney/zend-filter/tags","blobs_url":"https://api.github.com/repos/weierophinney/zend-filter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/weierophinney/zend-filter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/weierophinney/zend-filter/git/refs{/sha}","trees_url":"https://api.github.com/repos/weierophinney/zend-filter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/weierophinney/zend-filter/statuses/{sha}","languages_url":"https://api.github.com/repos/weierophinney/zend-filter/languages","stargazers_url":"https://api.github.com/repos/weierophinney/zend-filter/stargazers","contributors_url":"https://api.github.com/repos/weierophinney/zend-filter/contributors","subscribers_url":"https://api.github.com/repos/weierophinney/zend-filter/subscribers","subscription_url":"https://api.github.com/repos/weierophinney/zend-filter/subscription","commits_url":"https://api.github.com/repos/weierophinney/zend-filter/commits{/sha}","git_commits_url":"https://api.github.com/repos/weierophinney/zend-filter/git/commits{/sha}","comments_url":"https://api.github.com/repos/weierophinney/zend-filter/comments{/number}","issue_comment_url":"https://api.github.com/repos/weierophinney/zend-filter/issues/comments{/number}","contents_url":"https://api.github.com/repos/weierophinney/zend-filter/contents/{+path}","compare_url":"https://api.github.com/repos/weierophinney/zend-filter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/weierophinney/zend-filter/merges","archive_url":"https://api.github.com/repos/weierophinney/zend-filter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/weierophinney/zend-filter/downloads","issues_url":"https://api.github.com/repos/weierophinney/zend-filter/issues{/number}","pulls_url":"https://api.github.com/repos/weierophinney/zend-filter/pulls{/number}","milestones_url":"https://api.github.com/repos/weierophinney/zend-filter/milestones{/number}","notifications_url":"https://api.github.com/repos/weierophinney/zend-filter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/weierophinney/zend-filter/labels{/name}","releases_url":"https://api.github.com/repos/weierophinney/zend-filter/releases{/id}","deployments_url":"https://api.github.com/repos/weierophinney/zend-filter/deployments","created_at":"2015-12-22T17:56:11Z","updated_at":"2015-12-22T17:56:12Z","pushed_at":"2017-05-16T20:55:48Z","git_url":"git://github.com/weierophinney/zend-filter.git","ssh_url":"git@github.com:weierophinney/zend-filter.git","clone_url":"https://github.com/weierophinney/zend-filter.git","svn_url":"https://github.com/weierophinney/zend-filter","homepage":"https://github.com/zendframework/zf2","size":2872,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zendframework:master","ref":"master","sha":"c4bb5811390228e2ff0fe4fa9def1050f127da4c","user":{"login":"zendframework","id":296074,"avatar_url":"https://avatars1.githubusercontent.com/u/296074?v=3","gravatar_id":"","url":"https://api.github.com/users/zendframework","html_url":"https://github.com/zendframework","followers_url":"https://api.github.com/users/zendframework/followers","following_url":"https://api.github.com/users/zendframework/following{/other_user}","gists_url":"https://api.github.com/users/zendframework/gists{/gist_id}","starred_url":"https://api.github.com/users/zendframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendframework/subscriptions","organizations_url":"https://api.github.com/users/zendframework/orgs","repos_url":"https://api.github.com/users/zendframework/repos","events_url":"https://api.github.com/users/zendframework/events{/privacy}","received_events_url":"https://api.github.com/users/zendframework/received_events","type":"Organization","site_admin":false},"repo":{"id":35280803,"name":"zend-filter","full_name":"zendframework/zend-filter","owner":{"login":"zendframework","id":296074,"avatar_url":"https://avatars1.githubusercontent.com/u/296074?v=3","gravatar_id":"","url":"https://api.github.com/users/zendframework","html_url":"https://github.com/zendframework","followers_url":"https://api.github.com/users/zendframework/followers","following_url":"https://api.github.com/users/zendframework/following{/other_user}","gists_url":"https://api.github.com/users/zendframework/gists{/gist_id}","starred_url":"https://api.github.com/users/zendframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendframework/subscriptions","organizations_url":"https://api.github.com/users/zendframework/orgs","repos_url":"https://api.github.com/users/zendframework/repos","events_url":"https://api.github.com/users/zendframework/events{/privacy}","received_events_url":"https://api.github.com/users/zendframework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zendframework/zend-filter","description":"Filter component from Zend Framework","fork":false,"url":"https://api.github.com/repos/zendframework/zend-filter","forks_url":"https://api.github.com/repos/zendframework/zend-filter/forks","keys_url":"https://api.github.com/repos/zendframework/zend-filter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zendframework/zend-filter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zendframework/zend-filter/teams","hooks_url":"https://api.github.com/repos/zendframework/zend-filter/hooks","issue_events_url":"https://api.github.com/repos/zendframework/zend-filter/issues/events{/number}","events_url":"https://api.github.com/repos/zendframework/zend-filter/events","assignees_url":"https://api.github.com/repos/zendframework/zend-filter/assignees{/user}","branches_url":"https://api.github.com/repos/zendframework/zend-filter/branches{/branch}","tags_url":"https://api.github.com/repos/zendframework/zend-filter/tags","blobs_url":"https://api.github.com/repos/zendframework/zend-filter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zendframework/zend-filter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zendframework/zend-filter/git/refs{/sha}","trees_url":"https://api.github.com/repos/zendframework/zend-filter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zendframework/zend-filter/statuses/{sha}","languages_url":"https://api.github.com/repos/zendframework/zend-filter/languages","stargazers_url":"https://api.github.com/repos/zendframework/zend-filter/stargazers","contributors_url":"https://api.github.com/repos/zendframework/zend-filter/contributors","subscribers_url":"https://api.github.com/repos/zendframework/zend-filter/subscribers","subscription_url":"https://api.github.com/repos/zendframework/zend-filter/subscription","commits_url":"https://api.github.com/repos/zendframework/zend-filter/commits{/sha}","git_commits_url":"https://api.github.com/repos/zendframework/zend-filter/git/commits{/sha}","comments_url":"https://api.github.com/repos/zendframework/zend-filter/comments{/number}","issue_comment_url":"https://api.github.com/repos/zendframework/zend-filter/issues/comments{/number}","contents_url":"https://api.github.com/repos/zendframework/zend-filter/contents/{+path}","compare_url":"https://api.github.com/repos/zendframework/zend-filter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zendframework/zend-filter/merges","archive_url":"https://api.github.com/repos/zendframework/zend-filter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zendframework/zend-filter/downloads","issues_url":"https://api.github.com/repos/zendframework/zend-filter/issues{/number}","pulls_url":"https://api.github.com/repos/zendframework/zend-filter/pulls{/number}","milestones_url":"https://api.github.com/repos/zendframework/zend-filter/milestones{/number}","notifications_url":"https://api.github.com/repos/zendframework/zend-filter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zendframework/zend-filter/labels{/name}","releases_url":"https://api.github.com/repos/zendframework/zend-filter/releases{/id}","deployments_url":"https://api.github.com/repos/zendframework/zend-filter/deployments","created_at":"2015-05-08T13:27:59Z","updated_at":"2017-03-22T10:19:02Z","pushed_at":"2017-05-17T18:46:45Z","git_url":"git://github.com/zendframework/zend-filter.git","ssh_url":"git@github.com:zendframework/zend-filter.git","clone_url":"https://github.com/zendframework/zend-filter.git","svn_url":"https://github.com/zendframework/zend-filter","homepage":"https://github.com/zendframework/zf2","size":3511,"stargazers_count":17,"watchers_count":17,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":30,"mirror_url":null,"open_issues_count":28,"forks":30,"open_issues":28,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zendframework/zend-filter/pulls/56"},"html":{"href":"https://github.com/zendframework/zend-filter/pull/56"},"issue":{"href":"https://api.github.com/repos/zendframework/zend-filter/issues/56"},"comments":{"href":"https://api.github.com/repos/zendframework/zend-filter/issues/56/comments"},"review_comments":{"href":"https://api.github.com/repos/zendframework/zend-filter/pulls/56/comments"},"review_comment":{"href":"https://api.github.com/repos/zendframework/zend-filter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zendframework/zend-filter/pulls/56/commits"},"statuses":{"href":"https://api.github.com/repos/zendframework/zend-filter/statuses/7fd57c946ac128fc7ba0272ab0edc279a0314cfe"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"weierophinney","id":25943,"avatar_url":"https://avatars2.githubusercontent.com/u/25943?v=3","gravatar_id":"","url":"https://api.github.com/users/weierophinney","html_url":"https://github.com/weierophinney","followers_url":"https://api.github.com/users/weierophinney/followers","following_url":"https://api.github.com/users/weierophinney/following{/other_user}","gists_url":"https://api.github.com/users/weierophinney/gists{/gist_id}","starred_url":"https://api.github.com/users/weierophinney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weierophinney/subscriptions","organizations_url":"https://api.github.com/users/weierophinney/orgs","repos_url":"https://api.github.com/users/weierophinney/repos","events_url":"https://api.github.com/users/weierophinney/events{/privacy}","received_events_url":"https://api.github.com/users/weierophinney/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":122,"deletions":1,"changed_files":2}}
{"actor":{"display_login":"weierophinney"}}