{"action":"created","issue":{"url":"https://api.github.com/repos/realvictorprm/visualfsharp/issues/13","repository_url":"https://api.github.com/repos/realvictorprm/visualfsharp","labels_url":"https://api.github.com/repos/realvictorprm/visualfsharp/issues/13/labels{/name}","comments_url":"https://api.github.com/repos/realvictorprm/visualfsharp/issues/13/comments","events_url":"https://api.github.com/repos/realvictorprm/visualfsharp/issues/13/events","html_url":"https://github.com/realvictorprm/visualfsharp/pull/13","id":232111806,"number":13,"title":"Fix VS crash","user":{"login":"tldrlol","id":9697324,"avatar_url":"https://avatars1.githubusercontent.com/u/9697324?v=4","gravatar_id":"","url":"https://api.github.com/users/tldrlol","html_url":"https://github.com/tldrlol","followers_url":"https://api.github.com/users/tldrlol/followers","following_url":"https://api.github.com/users/tldrlol/following{/other_user}","gists_url":"https://api.github.com/users/tldrlol/gists{/gist_id}","starred_url":"https://api.github.com/users/tldrlol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tldrlol/subscriptions","organizations_url":"https://api.github.com/users/tldrlol/orgs","repos_url":"https://api.github.com/users/tldrlol/repos","events_url":"https://api.github.com/users/tldrlol/events{/privacy}","received_events_url":"https://api.github.com/users/tldrlol/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-05-29T23:28:20Z","updated_at":"2017-07-24T20:28:10Z","closed_at":"2017-07-24T20:28:10Z","pull_request":{"url":"https://api.github.com/repos/realvictorprm/visualfsharp/pulls/13","html_url":"https://github.com/realvictorprm/visualfsharp/pull/13","diff_url":"https://github.com/realvictorprm/visualfsharp/pull/13.diff","patch_url":"https://github.com/realvictorprm/visualfsharp/pull/13.patch"},"body":"From my experiments, this seems to fix the Exception -> Crash issue.\r\n\r\nUnlike what is stated here: https://msdn.microsoft.com/en-us/library/dd821035.aspx#Anchor_5, from what I can gather, the public methods are *NOT* async safe.\r\n\r\nThere still seem to be issues with cache invalidation, adornments don't always disappear. I don't know whether they are related to what I have provided here.\r\n\r\nI'm putting this pull request up as an example of a fix. *NOT* as the proper way of addressing this issue.\r\n\r\nIdeally I would remove the use of `SimpleTagger` altogether. Especially since there seems to be overlap between the caching done in this subclass and the capabilities `SimpleTagger` should provide."},"comment":{"url":"https://api.github.com/repos/realvictorprm/visualfsharp/issues/comments/317544443","html_url":"https://github.com/realvictorprm/visualfsharp/pull/13#issuecomment-317544443","issue_url":"https://api.github.com/repos/realvictorprm/visualfsharp/issues/13","id":317544443,"user":{"login":"realvictorprm","id":25414896,"avatar_url":"https://avatars1.githubusercontent.com/u/25414896?v=4","gravatar_id":"","url":"https://api.github.com/users/realvictorprm","html_url":"https://github.com/realvictorprm","followers_url":"https://api.github.com/users/realvictorprm/followers","following_url":"https://api.github.com/users/realvictorprm/following{/other_user}","gists_url":"https://api.github.com/users/realvictorprm/gists{/gist_id}","starred_url":"https://api.github.com/users/realvictorprm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/realvictorprm/subscriptions","organizations_url":"https://api.github.com/users/realvictorprm/orgs","repos_url":"https://api.github.com/users/realvictorprm/repos","events_url":"https://api.github.com/users/realvictorprm/events{/privacy}","received_events_url":"https://api.github.com/users/realvictorprm/received_events","type":"User","site_admin":false},"created_at":"2017-07-24T20:28:10Z","updated_at":"2017-07-24T20:28:10Z","body":"Bug found somewhere else. Thank you all for your effort!"}}
{"actor":{"display_login":"realvictorprm"}}