{"action":"created","issue":{"url":"https://api.github.com/repos/spring-projects/spring-boot/issues/9928","repository_url":"https://api.github.com/repos/spring-projects/spring-boot","labels_url":"https://api.github.com/repos/spring-projects/spring-boot/issues/9928/labels{/name}","comments_url":"https://api.github.com/repos/spring-projects/spring-boot/issues/9928/comments","events_url":"https://api.github.com/repos/spring-projects/spring-boot/issues/9928/events","html_url":"https://github.com/spring-projects/spring-boot/pull/9928","id":247164814,"number":9928,"title":"Regenerate wrapper against latest Takari Maven Plugin version","user":{"login":"rajadilipkolli","id":24761580,"avatar_url":"https://avatars2.githubusercontent.com/u/24761580?v=4","gravatar_id":"","url":"https://api.github.com/users/rajadilipkolli","html_url":"https://github.com/rajadilipkolli","followers_url":"https://api.github.com/users/rajadilipkolli/followers","following_url":"https://api.github.com/users/rajadilipkolli/following{/other_user}","gists_url":"https://api.github.com/users/rajadilipkolli/gists{/gist_id}","starred_url":"https://api.github.com/users/rajadilipkolli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajadilipkolli/subscriptions","organizations_url":"https://api.github.com/users/rajadilipkolli/orgs","repos_url":"https://api.github.com/users/rajadilipkolli/repos","events_url":"https://api.github.com/users/rajadilipkolli/events{/privacy}","received_events_url":"https://api.github.com/users/rajadilipkolli/received_events","type":"User","site_admin":false},"labels":[{"id":514595823,"url":"https://api.github.com/repos/spring-projects/spring-boot/labels/priority:%20normal","name":"priority: normal","color":"c2e0c6","default":false},{"id":69230488,"url":"https://api.github.com/repos/spring-projects/spring-boot/labels/type:%20chore","name":"type: chore","color":"d4c5f9","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/spring-projects/spring-boot/milestones/89","html_url":"https://github.com/spring-projects/spring-boot/milestone/89","labels_url":"https://api.github.com/repos/spring-projects/spring-boot/milestones/89/labels","id":2654511,"number":89,"title":"1.5.7","description":"","creator":{"login":"wilkinsona","id":914682,"avatar_url":"https://avatars3.githubusercontent.com/u/914682?v=4","gravatar_id":"","url":"https://api.github.com/users/wilkinsona","html_url":"https://github.com/wilkinsona","followers_url":"https://api.github.com/users/wilkinsona/followers","following_url":"https://api.github.com/users/wilkinsona/following{/other_user}","gists_url":"https://api.github.com/users/wilkinsona/gists{/gist_id}","starred_url":"https://api.github.com/users/wilkinsona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilkinsona/subscriptions","organizations_url":"https://api.github.com/users/wilkinsona/orgs","repos_url":"https://api.github.com/users/wilkinsona/repos","events_url":"https://api.github.com/users/wilkinsona/events{/privacy}","received_events_url":"https://api.github.com/users/wilkinsona/received_events","type":"User","site_admin":false},"open_issues":9,"closed_issues":10,"state":"open","created_at":"2017-07-21T13:50:38Z","updated_at":"2017-08-03T20:24:43Z","due_on":"2017-09-12T07:00:00Z","closed_at":null},"comments":0,"created_at":"2017-08-01T18:46:57Z","updated_at":"2017-08-03T20:35:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/spring-projects/spring-boot/pulls/9928","html_url":"https://github.com/spring-projects/spring-boot/pull/9928","diff_url":"https://github.com/spring-projects/spring-boot/pull/9928.diff","patch_url":"https://github.com/spring-projects/spring-boot/pull/9928.patch"},"body":"Regenerate maven wrapper against latest Takari Maven Plugin version 0.4.1"},"comment":{"url":"https://api.github.com/repos/spring-projects/spring-boot/issues/comments/320082662","html_url":"https://github.com/spring-projects/spring-boot/pull/9928#issuecomment-320082662","issue_url":"https://api.github.com/repos/spring-projects/spring-boot/issues/9928","id":320082662,"user":{"login":"wilkinsona","id":914682,"avatar_url":"https://avatars3.githubusercontent.com/u/914682?v=4","gravatar_id":"","url":"https://api.github.com/users/wilkinsona","html_url":"https://github.com/wilkinsona","followers_url":"https://api.github.com/users/wilkinsona/followers","following_url":"https://api.github.com/users/wilkinsona/following{/other_user}","gists_url":"https://api.github.com/users/wilkinsona/gists{/gist_id}","starred_url":"https://api.github.com/users/wilkinsona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilkinsona/subscriptions","organizations_url":"https://api.github.com/users/wilkinsona/orgs","repos_url":"https://api.github.com/users/wilkinsona/repos","events_url":"https://api.github.com/users/wilkinsona/events{/privacy}","received_events_url":"https://api.github.com/users/wilkinsona/received_events","type":"User","site_admin":false},"created_at":"2017-08-03T20:35:27Z","updated_at":"2017-08-03T20:35:27Z","body":"Thanks for the PR. When I apply it and then run:\r\n\r\n```\r\nmvn -N io.takari:maven:0.4.1:wrapper -Dmaven=3.5.0\r\n```\r\n\r\nGit shows the following changes:\r\n\r\n```\r\nChanges not staged for commit:\r\n  (use \"git add <file>...\" to update what will be committed)\r\n  (use \"git checkout -- <file>...\" to discard changes in working directory)\r\n\r\n\tmodified:   .mvn/wrapper/maven-wrapper.jar\r\n\tmodified:   .mvn/wrapper/maven-wrapper.properties\r\n\tmodified:   mvnw.cmd\r\n```\r\n\r\nThe `mvnw.cmd` is the file permissions and `maven-wrapper.properties` is just a new line at the end of the file. I have no idea what the difference to the wrapper binary is and that makes me a little nervous. This change should also be made on 1.5.x so, all in all, I think it would be easiest and safest for us to do it ourselves. Thanks anyway."}}
{"actor":{"display_login":"wilkinsona"}}