{"action":"created","issue":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/22091","repository_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA","labels_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/22091/labels{/name}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/22091/comments","events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/22091/events","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/22091","id":263365146,"number":22091,"title":"Fix vehicle cache debugmsgs","user":{"login":"Coolthulhu","id":1878860,"avatar_url":"https://avatars1.githubusercontent.com/u/1878860?v=4","gravatar_id":"","url":"https://api.github.com/users/Coolthulhu","html_url":"https://github.com/Coolthulhu","followers_url":"https://api.github.com/users/Coolthulhu/followers","following_url":"https://api.github.com/users/Coolthulhu/following{/other_user}","gists_url":"https://api.github.com/users/Coolthulhu/gists{/gist_id}","starred_url":"https://api.github.com/users/Coolthulhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Coolthulhu/subscriptions","organizations_url":"https://api.github.com/users/Coolthulhu/orgs","repos_url":"https://api.github.com/users/Coolthulhu/repos","events_url":"https://api.github.com/users/Coolthulhu/events{/privacy}","received_events_url":"https://api.github.com/users/Coolthulhu/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-10-06T08:03:05Z","updated_at":"2017-10-06T12:47:45Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/22091","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/22091","diff_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/22091.diff","patch_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/22091.patch"},"body":"Treating null terrain as passable breaks the assumption that things can't move into a null tile. This is a perfectly fine assumption to make, as moving into a null tile shouldn't happen.\r\n\r\nCreatures on null tiles - outside map - would check vehicles on their tiles. Since those checks happen a lot, they would be made with optimized function that skips bounds check. This function only works faster than the one with bounds checks if everything is in bounds, so it warns if it is used \"wrong\".\r\n\r\nAlternatives would be to drop the optimization and just check bounds (those creature tile checks are costly already, as seen when profiling), special case null tiles wherever skipped bounds checks are involved (ugly!), ensure critters aren't on null tiles before processing them, or optimize it in some different way that doesn't require relatively expensive vehicle checks.\r\nBut I can't really think of a reason for why should null terrain be passable."},"comment":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/comments/334744869","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/22091#issuecomment-334744869","issue_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/22091","id":334744869,"user":{"login":"goron111","id":4800490,"avatar_url":"https://avatars2.githubusercontent.com/u/4800490?v=4","gravatar_id":"","url":"https://api.github.com/users/goron111","html_url":"https://github.com/goron111","followers_url":"https://api.github.com/users/goron111/followers","following_url":"https://api.github.com/users/goron111/following{/other_user}","gists_url":"https://api.github.com/users/goron111/gists{/gist_id}","starred_url":"https://api.github.com/users/goron111/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goron111/subscriptions","organizations_url":"https://api.github.com/users/goron111/orgs","repos_url":"https://api.github.com/users/goron111/repos","events_url":"https://api.github.com/users/goron111/events{/privacy}","received_events_url":"https://api.github.com/users/goron111/received_events","type":"User","site_admin":false},"created_at":"2017-10-06T12:47:45Z","updated_at":"2017-10-06T12:47:45Z","author_association":"CONTRIBUTOR","body":"Do this fix #21966 and #20374? or are there more cases where this debug message is shown?"}}
{"actor":{"display_login":"goron111"}}