{"action":"created","comment":{"url":"https://api.github.com/repos/ooyala/html5-skin/pulls/comments/145866815","pull_request_review_id":70731286,"id":145866815,"diff_hunk":"@@ -1603,12 +1603,18 @@ OO.plugin(\"Html5Skin\", function (OO, _, $, W) {\n \n     setClosedCaptionsLanguage: function(){\n       var availableLanguages = this.state.closedCaptionOptions.availableLanguages;\n-      //if saved language not in available languages, set to first available language\n-      if (availableLanguages && (this.state.closedCaptionOptions.language == null || !_.contains(availableLanguages.languages, this.state.closedCaptionOptions.language))) {\n+\n+      //if saved language not in available languages and saved is not 'none', set to first available language\n+      if (availableLanguages && this.state.closedCaptionOptions.language !== CONSTANTS.CLOSED_CAPTIONS.NONE_LANGUAGE\n+        && (this.state.closedCaptionOptions.language == null || !_.contains(availableLanguages.languages, this.state.closedCaptionOptions.language))) {\n         this.state.closedCaptionOptions.language = availableLanguages.languages[0];\n       }\n-      var language = this.state.closedCaptionOptions.enabled ? this.state.closedCaptionOptions.language : \"\";\n-      var mode = this.state.closedCaptionOptions.enabled ? OO.CONSTANTS.CLOSED_CAPTIONS.HIDDEN : OO.CONSTANTS.CLOSED_CAPTIONS.DISABLED;\n+      var language = \"\";\n+      var mode = OO.CONSTANTS.CLOSED_CAPTIONS.DISABLED;\n+      if(this.state.closedCaptionOptions.enabled && this.state.closedCaptionOptions.language !== CONSTANTS.CLOSED_CAPTIONS.NONE_LANGUAGE){","path":"js/controller.js","position":null,"original_position":16,"commit_id":"40ca78a4c34f0e467422b1a646f24f41c4259139","original_commit_id":"1d3310c2e5752e08b0eab3438f5df7e3a86a8678","user":{"login":"gramcha","id":4689263,"avatar_url":"https://avatars1.githubusercontent.com/u/4689263?v=4","gravatar_id":"","url":"https://api.github.com/users/gramcha","html_url":"https://github.com/gramcha","followers_url":"https://api.github.com/users/gramcha/followers","following_url":"https://api.github.com/users/gramcha/following{/other_user}","gists_url":"https://api.github.com/users/gramcha/gists{/gist_id}","starred_url":"https://api.github.com/users/gramcha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gramcha/subscriptions","organizations_url":"https://api.github.com/users/gramcha/orgs","repos_url":"https://api.github.com/users/gramcha/repos","events_url":"https://api.github.com/users/gramcha/events{/privacy}","received_events_url":"https://api.github.com/users/gramcha/received_events","type":"User","site_admin":false},"body":"Done.","created_at":"2017-10-20T02:30:54Z","updated_at":"2017-10-20T02:30:54Z","html_url":"https://github.com/ooyala/html5-skin/pull/865#discussion_r145866815","pull_request_url":"https://api.github.com/repos/ooyala/html5-skin/pulls/865","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ooyala/html5-skin/pulls/comments/145866815"},"html":{"href":"https://github.com/ooyala/html5-skin/pull/865#discussion_r145866815"},"pull_request":{"href":"https://api.github.com/repos/ooyala/html5-skin/pulls/865"}},"in_reply_to_id":144682633},"pull_request":{"url":"https://api.github.com/repos/ooyala/html5-skin/pulls/865","id":145899042,"html_url":"https://github.com/ooyala/html5-skin/pull/865","diff_url":"https://github.com/ooyala/html5-skin/pull/865.diff","patch_url":"https://github.com/ooyala/html5-skin/pull/865.patch","issue_url":"https://api.github.com/repos/ooyala/html5-skin/issues/865","number":865,"state":"open","locked":false,"title":"Player 711 - Fix for missed usecase(puase and play)","user":{"login":"gramcha","id":4689263,"avatar_url":"https://avatars1.githubusercontent.com/u/4689263?v=4","gravatar_id":"","url":"https://api.github.com/users/gramcha","html_url":"https://github.com/gramcha","followers_url":"https://api.github.com/users/gramcha/followers","following_url":"https://api.github.com/users/gramcha/following{/other_user}","gists_url":"https://api.github.com/users/gramcha/gists{/gist_id}","starred_url":"https://api.github.com/users/gramcha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gramcha/subscriptions","organizations_url":"https://api.github.com/users/gramcha/orgs","repos_url":"https://api.github.com/users/gramcha/repos","events_url":"https://api.github.com/users/gramcha/events{/privacy}","received_events_url":"https://api.github.com/users/gramcha/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-10-11T09:33:32Z","updated_at":"2017-10-20T02:30:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"40c2f967d17d05035713709bd2e93ac09ddcbf7d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"pilievOoyala","id":10237974,"avatar_url":"https://avatars1.githubusercontent.com/u/10237974?v=4","gravatar_id":"","url":"https://api.github.com/users/pilievOoyala","html_url":"https://github.com/pilievOoyala","followers_url":"https://api.github.com/users/pilievOoyala/followers","following_url":"https://api.github.com/users/pilievOoyala/following{/other_user}","gists_url":"https://api.github.com/users/pilievOoyala/gists{/gist_id}","starred_url":"https://api.github.com/users/pilievOoyala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pilievOoyala/subscriptions","organizations_url":"https://api.github.com/users/pilievOoyala/orgs","repos_url":"https://api.github.com/users/pilievOoyala/repos","events_url":"https://api.github.com/users/pilievOoyala/events{/privacy}","received_events_url":"https://api.github.com/users/pilievOoyala/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ooyala/html5-skin/pulls/865/commits","review_comments_url":"https://api.github.com/repos/ooyala/html5-skin/pulls/865/comments","review_comment_url":"https://api.github.com/repos/ooyala/html5-skin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ooyala/html5-skin/issues/865/comments","statuses_url":"https://api.github.com/repos/ooyala/html5-skin/statuses/40ca78a4c34f0e467422b1a646f24f41c4259139","head":{"label":"ooyala:PLAYER-711","ref":"PLAYER-711","sha":"40ca78a4c34f0e467422b1a646f24f41c4259139","user":{"login":"ooyala","id":365274,"avatar_url":"https://avatars3.githubusercontent.com/u/365274?v=4","gravatar_id":"","url":"https://api.github.com/users/ooyala","html_url":"https://github.com/ooyala","followers_url":"https://api.github.com/users/ooyala/followers","following_url":"https://api.github.com/users/ooyala/following{/other_user}","gists_url":"https://api.github.com/users/ooyala/gists{/gist_id}","starred_url":"https://api.github.com/users/ooyala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ooyala/subscriptions","organizations_url":"https://api.github.com/users/ooyala/orgs","repos_url":"https://api.github.com/users/ooyala/repos","events_url":"https://api.github.com/users/ooyala/events{/privacy}","received_events_url":"https://api.github.com/users/ooyala/received_events","type":"Organization","site_admin":false},"repo":{"id":32830770,"name":"html5-skin","full_name":"ooyala/html5-skin","owner":{"login":"ooyala","id":365274,"avatar_url":"https://avatars3.githubusercontent.com/u/365274?v=4","gravatar_id":"","url":"https://api.github.com/users/ooyala","html_url":"https://github.com/ooyala","followers_url":"https://api.github.com/users/ooyala/followers","following_url":"https://api.github.com/users/ooyala/following{/other_user}","gists_url":"https://api.github.com/users/ooyala/gists{/gist_id}","starred_url":"https://api.github.com/users/ooyala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ooyala/subscriptions","organizations_url":"https://api.github.com/users/ooyala/orgs","repos_url":"https://api.github.com/users/ooyala/repos","events_url":"https://api.github.com/users/ooyala/events{/privacy}","received_events_url":"https://api.github.com/users/ooyala/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ooyala/html5-skin","description":null,"fork":false,"url":"https://api.github.com/repos/ooyala/html5-skin","forks_url":"https://api.github.com/repos/ooyala/html5-skin/forks","keys_url":"https://api.github.com/repos/ooyala/html5-skin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ooyala/html5-skin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ooyala/html5-skin/teams","hooks_url":"https://api.github.com/repos/ooyala/html5-skin/hooks","issue_events_url":"https://api.github.com/repos/ooyala/html5-skin/issues/events{/number}","events_url":"https://api.github.com/repos/ooyala/html5-skin/events","assignees_url":"https://api.github.com/repos/ooyala/html5-skin/assignees{/user}","branches_url":"https://api.github.com/repos/ooyala/html5-skin/branches{/branch}","tags_url":"https://api.github.com/repos/ooyala/html5-skin/tags","blobs_url":"https://api.github.com/repos/ooyala/html5-skin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ooyala/html5-skin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ooyala/html5-skin/git/refs{/sha}","trees_url":"https://api.github.com/repos/ooyala/html5-skin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ooyala/html5-skin/statuses/{sha}","languages_url":"https://api.github.com/repos/ooyala/html5-skin/languages","stargazers_url":"https://api.github.com/repos/ooyala/html5-skin/stargazers","contributors_url":"https://api.github.com/repos/ooyala/html5-skin/contributors","subscribers_url":"https://api.github.com/repos/ooyala/html5-skin/subscribers","subscription_url":"https://api.github.com/repos/ooyala/html5-skin/subscription","commits_url":"https://api.github.com/repos/ooyala/html5-skin/commits{/sha}","git_commits_url":"https://api.github.com/repos/ooyala/html5-skin/git/commits{/sha}","comments_url":"https://api.github.com/repos/ooyala/html5-skin/comments{/number}","issue_comment_url":"https://api.github.com/repos/ooyala/html5-skin/issues/comments{/number}","contents_url":"https://api.github.com/repos/ooyala/html5-skin/contents/{+path}","compare_url":"https://api.github.com/repos/ooyala/html5-skin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ooyala/html5-skin/merges","archive_url":"https://api.github.com/repos/ooyala/html5-skin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ooyala/html5-skin/downloads","issues_url":"https://api.github.com/repos/ooyala/html5-skin/issues{/number}","pulls_url":"https://api.github.com/repos/ooyala/html5-skin/pulls{/number}","milestones_url":"https://api.github.com/repos/ooyala/html5-skin/milestones{/number}","notifications_url":"https://api.github.com/repos/ooyala/html5-skin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ooyala/html5-skin/labels{/name}","releases_url":"https://api.github.com/repos/ooyala/html5-skin/releases{/id}","deployments_url":"https://api.github.com/repos/ooyala/html5-skin/deployments","created_at":"2015-03-24T23:20:15Z","updated_at":"2017-07-25T21:34:19Z","pushed_at":"2017-10-20T02:29:28Z","git_url":"git://github.com/ooyala/html5-skin.git","ssh_url":"git@github.com:ooyala/html5-skin.git","clone_url":"https://github.com/ooyala/html5-skin.git","svn_url":"https://github.com/ooyala/html5-skin","homepage":null,"size":3842,"stargazers_count":19,"watchers_count":19,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":42,"mirror_url":null,"open_issues_count":15,"forks":42,"open_issues":15,"watchers":19,"default_branch":"master"}},"base":{"label":"ooyala:master","ref":"master","sha":"cc3c0225034ae75cf8aad6a61286779c9cfbe769","user":{"login":"ooyala","id":365274,"avatar_url":"https://avatars3.githubusercontent.com/u/365274?v=4","gravatar_id":"","url":"https://api.github.com/users/ooyala","html_url":"https://github.com/ooyala","followers_url":"https://api.github.com/users/ooyala/followers","following_url":"https://api.github.com/users/ooyala/following{/other_user}","gists_url":"https://api.github.com/users/ooyala/gists{/gist_id}","starred_url":"https://api.github.com/users/ooyala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ooyala/subscriptions","organizations_url":"https://api.github.com/users/ooyala/orgs","repos_url":"https://api.github.com/users/ooyala/repos","events_url":"https://api.github.com/users/ooyala/events{/privacy}","received_events_url":"https://api.github.com/users/ooyala/received_events","type":"Organization","site_admin":false},"repo":{"id":32830770,"name":"html5-skin","full_name":"ooyala/html5-skin","owner":{"login":"ooyala","id":365274,"avatar_url":"https://avatars3.githubusercontent.com/u/365274?v=4","gravatar_id":"","url":"https://api.github.com/users/ooyala","html_url":"https://github.com/ooyala","followers_url":"https://api.github.com/users/ooyala/followers","following_url":"https://api.github.com/users/ooyala/following{/other_user}","gists_url":"https://api.github.com/users/ooyala/gists{/gist_id}","starred_url":"https://api.github.com/users/ooyala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ooyala/subscriptions","organizations_url":"https://api.github.com/users/ooyala/orgs","repos_url":"https://api.github.com/users/ooyala/repos","events_url":"https://api.github.com/users/ooyala/events{/privacy}","received_events_url":"https://api.github.com/users/ooyala/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ooyala/html5-skin","description":null,"fork":false,"url":"https://api.github.com/repos/ooyala/html5-skin","forks_url":"https://api.github.com/repos/ooyala/html5-skin/forks","keys_url":"https://api.github.com/repos/ooyala/html5-skin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ooyala/html5-skin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ooyala/html5-skin/teams","hooks_url":"https://api.github.com/repos/ooyala/html5-skin/hooks","issue_events_url":"https://api.github.com/repos/ooyala/html5-skin/issues/events{/number}","events_url":"https://api.github.com/repos/ooyala/html5-skin/events","assignees_url":"https://api.github.com/repos/ooyala/html5-skin/assignees{/user}","branches_url":"https://api.github.com/repos/ooyala/html5-skin/branches{/branch}","tags_url":"https://api.github.com/repos/ooyala/html5-skin/tags","blobs_url":"https://api.github.com/repos/ooyala/html5-skin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ooyala/html5-skin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ooyala/html5-skin/git/refs{/sha}","trees_url":"https://api.github.com/repos/ooyala/html5-skin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ooyala/html5-skin/statuses/{sha}","languages_url":"https://api.github.com/repos/ooyala/html5-skin/languages","stargazers_url":"https://api.github.com/repos/ooyala/html5-skin/stargazers","contributors_url":"https://api.github.com/repos/ooyala/html5-skin/contributors","subscribers_url":"https://api.github.com/repos/ooyala/html5-skin/subscribers","subscription_url":"https://api.github.com/repos/ooyala/html5-skin/subscription","commits_url":"https://api.github.com/repos/ooyala/html5-skin/commits{/sha}","git_commits_url":"https://api.github.com/repos/ooyala/html5-skin/git/commits{/sha}","comments_url":"https://api.github.com/repos/ooyala/html5-skin/comments{/number}","issue_comment_url":"https://api.github.com/repos/ooyala/html5-skin/issues/comments{/number}","contents_url":"https://api.github.com/repos/ooyala/html5-skin/contents/{+path}","compare_url":"https://api.github.com/repos/ooyala/html5-skin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ooyala/html5-skin/merges","archive_url":"https://api.github.com/repos/ooyala/html5-skin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ooyala/html5-skin/downloads","issues_url":"https://api.github.com/repos/ooyala/html5-skin/issues{/number}","pulls_url":"https://api.github.com/repos/ooyala/html5-skin/pulls{/number}","milestones_url":"https://api.github.com/repos/ooyala/html5-skin/milestones{/number}","notifications_url":"https://api.github.com/repos/ooyala/html5-skin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ooyala/html5-skin/labels{/name}","releases_url":"https://api.github.com/repos/ooyala/html5-skin/releases{/id}","deployments_url":"https://api.github.com/repos/ooyala/html5-skin/deployments","created_at":"2015-03-24T23:20:15Z","updated_at":"2017-07-25T21:34:19Z","pushed_at":"2017-10-20T02:29:28Z","git_url":"git://github.com/ooyala/html5-skin.git","ssh_url":"git@github.com:ooyala/html5-skin.git","clone_url":"https://github.com/ooyala/html5-skin.git","svn_url":"https://github.com/ooyala/html5-skin","homepage":null,"size":3842,"stargazers_count":19,"watchers_count":19,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":42,"mirror_url":null,"open_issues_count":15,"forks":42,"open_issues":15,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ooyala/html5-skin/pulls/865"},"html":{"href":"https://github.com/ooyala/html5-skin/pull/865"},"issue":{"href":"https://api.github.com/repos/ooyala/html5-skin/issues/865"},"comments":{"href":"https://api.github.com/repos/ooyala/html5-skin/issues/865/comments"},"review_comments":{"href":"https://api.github.com/repos/ooyala/html5-skin/pulls/865/comments"},"review_comment":{"href":"https://api.github.com/repos/ooyala/html5-skin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ooyala/html5-skin/pulls/865/commits"},"statuses":{"href":"https://api.github.com/repos/ooyala/html5-skin/statuses/40ca78a4c34f0e467422b1a646f24f41c4259139"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"gramcha"}}