{"action":"closed","number":4,"pull_request":{"url":"https://api.github.com/repos/msgpack/msgpack-objectivec/pulls/4","id":7501040,"html_url":"https://github.com/msgpack/msgpack-objectivec/pull/4","diff_url":"https://github.com/msgpack/msgpack-objectivec/pull/4.diff","patch_url":"https://github.com/msgpack/msgpack-objectivec/pull/4.patch","issue_url":"https://api.github.com/repos/msgpack/msgpack-objectivec/issues/4","number":4,"state":"closed","locked":false,"title":"FIX (src): Fixed working with unsingned numbers.","user":{"login":"plasmLC","id":2793913,"avatar_url":"https://avatars.githubusercontent.com/u/2793913?v=3","gravatar_id":"","url":"https://api.github.com/users/plasmLC","html_url":"https://github.com/plasmLC","followers_url":"https://api.github.com/users/plasmLC/followers","following_url":"https://api.github.com/users/plasmLC/following{/other_user}","gists_url":"https://api.github.com/users/plasmLC/gists{/gist_id}","starred_url":"https://api.github.com/users/plasmLC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plasmLC/subscriptions","organizations_url":"https://api.github.com/users/plasmLC/orgs","repos_url":"https://api.github.com/users/plasmLC/repos","events_url":"https://api.github.com/users/plasmLC/events{/privacy}","received_events_url":"https://api.github.com/users/plasmLC/received_events","type":"User","site_admin":false},"body":"Hello! \nI was found, that MessagePack don`t correct detects unsigned types of numbers. To check this, try this code:\n\n<pre><code>NSNumber *numberUnsignedLongLong = [NSNumber numberWithUnsignedLongLong:11282603312207742769];\nNSNumber *numberInt = [NSNumber numberWithInt:11282603312207742769];\n    \nNSData *packedUnsigned = [@[numberUnsignedLongLong] messagePack];\nNSData *packedInt = [@[numberInt] messagePack];\n    \nNSLog(@\"unpacked uLongLong: %@\", [[packedUnsigned messagePackParse] description]);\nNSLog(@\"unpacked int: %@\", [[packedInt messagePackParse] description]);\n</code></pre>\n\n\nAs you can see, message pack corrupt this big number, because signed/unsgined checks are fault.\n\nI am fixed this trouble, now unsigned numbers packing works fine :)\n## \n\nBest Regards, Orlov Alexander\n","created_at":"2013-08-09T10:13:34Z","updated_at":"2017-02-26T19:49:06Z","closed_at":"2017-02-26T19:49:06Z","merged_at":null,"merge_commit_sha":"af51330b30f6921b52f5f7afdbbb511885603807","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/msgpack/msgpack-objectivec/pulls/4/commits","review_comments_url":"https://api.github.com/repos/msgpack/msgpack-objectivec/pulls/4/comments","review_comment_url":"https://api.github.com/repos/msgpack/msgpack-objectivec/pulls/comments{/number}","comments_url":"https://api.github.com/repos/msgpack/msgpack-objectivec/issues/4/comments","statuses_url":"https://api.github.com/repos/msgpack/msgpack-objectivec/statuses/77afbbf55a9aa0680bcb8ab814ff7de48836fa9b","head":{"label":"plasmLC:master","ref":"master","sha":"77afbbf55a9aa0680bcb8ab814ff7de48836fa9b","user":{"login":"plasmLC","id":2793913,"avatar_url":"https://avatars.githubusercontent.com/u/2793913?v=3","gravatar_id":"","url":"https://api.github.com/users/plasmLC","html_url":"https://github.com/plasmLC","followers_url":"https://api.github.com/users/plasmLC/followers","following_url":"https://api.github.com/users/plasmLC/following{/other_user}","gists_url":"https://api.github.com/users/plasmLC/gists{/gist_id}","starred_url":"https://api.github.com/users/plasmLC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plasmLC/subscriptions","organizations_url":"https://api.github.com/users/plasmLC/orgs","repos_url":"https://api.github.com/users/plasmLC/repos","events_url":"https://api.github.com/users/plasmLC/events{/privacy}","received_events_url":"https://api.github.com/users/plasmLC/received_events","type":"User","site_admin":false},"repo":null},"base":{"label":"msgpack:master","ref":"master","sha":"03ae6049a627815170bbc42ebc8ba6452be563f9","user":{"login":"msgpack","id":198264,"avatar_url":"https://avatars.githubusercontent.com/u/198264?v=3","gravatar_id":"","url":"https://api.github.com/users/msgpack","html_url":"https://github.com/msgpack","followers_url":"https://api.github.com/users/msgpack/followers","following_url":"https://api.github.com/users/msgpack/following{/other_user}","gists_url":"https://api.github.com/users/msgpack/gists{/gist_id}","starred_url":"https://api.github.com/users/msgpack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msgpack/subscriptions","organizations_url":"https://api.github.com/users/msgpack/orgs","repos_url":"https://api.github.com/users/msgpack/repos","events_url":"https://api.github.com/users/msgpack/events{/privacy}","received_events_url":"https://api.github.com/users/msgpack/received_events","type":"Organization","site_admin":false},"repo":{"id":3033655,"name":"msgpack-objectivec","full_name":"msgpack/msgpack-objectivec","owner":{"login":"msgpack","id":198264,"avatar_url":"https://avatars.githubusercontent.com/u/198264?v=3","gravatar_id":"","url":"https://api.github.com/users/msgpack","html_url":"https://github.com/msgpack","followers_url":"https://api.github.com/users/msgpack/followers","following_url":"https://api.github.com/users/msgpack/following{/other_user}","gists_url":"https://api.github.com/users/msgpack/gists{/gist_id}","starred_url":"https://api.github.com/users/msgpack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msgpack/subscriptions","organizations_url":"https://api.github.com/users/msgpack/orgs","repos_url":"https://api.github.com/users/msgpack/repos","events_url":"https://api.github.com/users/msgpack/events{/privacy}","received_events_url":"https://api.github.com/users/msgpack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/msgpack/msgpack-objectivec","description":"MessagePack serializer implementation for Objective-C / msgpack.org[Objective-C]","fork":false,"url":"https://api.github.com/repos/msgpack/msgpack-objectivec","forks_url":"https://api.github.com/repos/msgpack/msgpack-objectivec/forks","keys_url":"https://api.github.com/repos/msgpack/msgpack-objectivec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/msgpack/msgpack-objectivec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/msgpack/msgpack-objectivec/teams","hooks_url":"https://api.github.com/repos/msgpack/msgpack-objectivec/hooks","issue_events_url":"https://api.github.com/repos/msgpack/msgpack-objectivec/issues/events{/number}","events_url":"https://api.github.com/repos/msgpack/msgpack-objectivec/events","assignees_url":"https://api.github.com/repos/msgpack/msgpack-objectivec/assignees{/user}","branches_url":"https://api.github.com/repos/msgpack/msgpack-objectivec/branches{/branch}","tags_url":"https://api.github.com/repos/msgpack/msgpack-objectivec/tags","blobs_url":"https://api.github.com/repos/msgpack/msgpack-objectivec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/msgpack/msgpack-objectivec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/msgpack/msgpack-objectivec/git/refs{/sha}","trees_url":"https://api.github.com/repos/msgpack/msgpack-objectivec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/msgpack/msgpack-objectivec/statuses/{sha}","languages_url":"https://api.github.com/repos/msgpack/msgpack-objectivec/languages","stargazers_url":"https://api.github.com/repos/msgpack/msgpack-objectivec/stargazers","contributors_url":"https://api.github.com/repos/msgpack/msgpack-objectivec/contributors","subscribers_url":"https://api.github.com/repos/msgpack/msgpack-objectivec/subscribers","subscription_url":"https://api.github.com/repos/msgpack/msgpack-objectivec/subscription","commits_url":"https://api.github.com/repos/msgpack/msgpack-objectivec/commits{/sha}","git_commits_url":"https://api.github.com/repos/msgpack/msgpack-objectivec/git/commits{/sha}","comments_url":"https://api.github.com/repos/msgpack/msgpack-objectivec/comments{/number}","issue_comment_url":"https://api.github.com/repos/msgpack/msgpack-objectivec/issues/comments{/number}","contents_url":"https://api.github.com/repos/msgpack/msgpack-objectivec/contents/{+path}","compare_url":"https://api.github.com/repos/msgpack/msgpack-objectivec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/msgpack/msgpack-objectivec/merges","archive_url":"https://api.github.com/repos/msgpack/msgpack-objectivec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/msgpack/msgpack-objectivec/downloads","issues_url":"https://api.github.com/repos/msgpack/msgpack-objectivec/issues{/number}","pulls_url":"https://api.github.com/repos/msgpack/msgpack-objectivec/pulls{/number}","milestones_url":"https://api.github.com/repos/msgpack/msgpack-objectivec/milestones{/number}","notifications_url":"https://api.github.com/repos/msgpack/msgpack-objectivec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/msgpack/msgpack-objectivec/labels{/name}","releases_url":"https://api.github.com/repos/msgpack/msgpack-objectivec/releases{/id}","deployments_url":"https://api.github.com/repos/msgpack/msgpack-objectivec/deployments","created_at":"2011-12-22T12:20:35Z","updated_at":"2017-02-15T20:09:01Z","pushed_at":"2017-02-17T19:18:20Z","git_url":"git://github.com/msgpack/msgpack-objectivec.git","ssh_url":"git@github.com:msgpack/msgpack-objectivec.git","clone_url":"https://github.com/msgpack/msgpack-objectivec.git","svn_url":"https://github.com/msgpack/msgpack-objectivec","homepage":"http://msgpack.org/","size":396,"stargazers_count":277,"watchers_count":277,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":44,"mirror_url":null,"open_issues_count":7,"forks":44,"open_issues":7,"watchers":277,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/msgpack/msgpack-objectivec/pulls/4"},"html":{"href":"https://github.com/msgpack/msgpack-objectivec/pull/4"},"issue":{"href":"https://api.github.com/repos/msgpack/msgpack-objectivec/issues/4"},"comments":{"href":"https://api.github.com/repos/msgpack/msgpack-objectivec/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/msgpack/msgpack-objectivec/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/msgpack/msgpack-objectivec/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/msgpack/msgpack-objectivec/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/msgpack/msgpack-objectivec/statuses/77afbbf55a9aa0680bcb8ab814ff7de48836fa9b"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":0,"additions":0,"deletions":0,"changed_files":0}}
{"actor":{"display_login":"plasmLC"}}