{"action":"created","comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/119413094","pull_request_review_id":41290857,"id":119413094,"diff_hunk":"@@ -1739,7 +1742,7 @@ static bool ConnectBlock(const CBlock& block, CValidationState& state, CBlockInd\n     }\n \n     int64_t nTime1 = GetTimeMicros(); nTimeCheck += nTime1 - nTimeStart;\n-    LogPrint(BCLog::BENCH, \"    - Sanity checks: %.2fms [%.2fs]\\n\", 0.001 * (nTime1 - nTimeStart), nTimeCheck * 0.000001);\n+    LogPrint(BCLog::BENCH, \"    - Sanity checks: %.2fms [%.2fs (%.2fms/blk)]\\n\", 0.001 * (nTime1 - nTimeStart), nTimeCheck * 0.000001, nTimeCheck * 0.001 / nBlocksTotal);","path":"src/validation.cpp","position":22,"original_position":22,"commit_id":"1d0cdc07c4db1e0d0df7a55696543165506de09f","original_commit_id":"1d0cdc07c4db1e0d0df7a55696543165506de09f","user":{"login":"jtimon","id":1008458,"avatar_url":"https://avatars0.githubusercontent.com/u/1008458?v=3","gravatar_id":"","url":"https://api.github.com/users/jtimon","html_url":"https://github.com/jtimon","followers_url":"https://api.github.com/users/jtimon/followers","following_url":"https://api.github.com/users/jtimon/following{/other_user}","gists_url":"https://api.github.com/users/jtimon/gists{/gist_id}","starred_url":"https://api.github.com/users/jtimon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtimon/subscriptions","organizations_url":"https://api.github.com/users/jtimon/orgs","repos_url":"https://api.github.com/users/jtimon/repos","events_url":"https://api.github.com/users/jtimon/events{/privacy}","received_events_url":"https://api.github.com/users/jtimon/received_events","type":"User","site_admin":false},"body":"Perhaps  ```0.001``` can be a constant? maybe ```0.000001``` too ?","created_at":"2017-05-31T16:54:59Z","updated_at":"2017-05-31T16:54:59Z","html_url":"https://github.com/bitcoin/bitcoin/pull/10303#discussion_r119413094","pull_request_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/10303","_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/119413094"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/10303#discussion_r119413094"},"pull_request":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/10303"}}},"pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/10303","id":118345582,"html_url":"https://github.com/bitcoin/bitcoin/pull/10303","diff_url":"https://github.com/bitcoin/bitcoin/pull/10303.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/10303.patch","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/10303","number":10303,"state":"open","locked":false,"title":"[bench] Include ms/blk stats in Connect* benchmarks.","user":{"login":"kallewoof","id":250224,"avatar_url":"https://avatars0.githubusercontent.com/u/250224?v=3","gravatar_id":"","url":"https://api.github.com/users/kallewoof","html_url":"https://github.com/kallewoof","followers_url":"https://api.github.com/users/kallewoof/followers","following_url":"https://api.github.com/users/kallewoof/following{/other_user}","gists_url":"https://api.github.com/users/kallewoof/gists{/gist_id}","starred_url":"https://api.github.com/users/kallewoof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kallewoof/subscriptions","organizations_url":"https://api.github.com/users/kallewoof/orgs","repos_url":"https://api.github.com/users/kallewoof/repos","events_url":"https://api.github.com/users/kallewoof/events{/privacy}","received_events_url":"https://api.github.com/users/kallewoof/received_events","type":"User","site_admin":false},"body":"Display the average per block runtime for the various benchmarked times in the block connect functions to give an overview of long(er) term time distribution statistics.","created_at":"2017-05-01T04:57:09Z","updated_at":"2017-05-31T16:54:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d6b3174f4285c331c8a134f0404d93fb408e3927","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/10303/commits","review_comments_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/10303/comments","review_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/10303/comments","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/1d0cdc07c4db1e0d0df7a55696543165506de09f","head":{"label":"kallewoof:bench-add-per-block-stats","ref":"bench-add-per-block-stats","sha":"1d0cdc07c4db1e0d0df7a55696543165506de09f","user":{"login":"kallewoof","id":250224,"avatar_url":"https://avatars0.githubusercontent.com/u/250224?v=3","gravatar_id":"","url":"https://api.github.com/users/kallewoof","html_url":"https://github.com/kallewoof","followers_url":"https://api.github.com/users/kallewoof/followers","following_url":"https://api.github.com/users/kallewoof/following{/other_user}","gists_url":"https://api.github.com/users/kallewoof/gists{/gist_id}","starred_url":"https://api.github.com/users/kallewoof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kallewoof/subscriptions","organizations_url":"https://api.github.com/users/kallewoof/orgs","repos_url":"https://api.github.com/users/kallewoof/repos","events_url":"https://api.github.com/users/kallewoof/events{/privacy}","received_events_url":"https://api.github.com/users/kallewoof/received_events","type":"User","site_admin":false},"repo":{"id":74733553,"name":"bitcoin","full_name":"kallewoof/bitcoin","owner":{"login":"kallewoof","id":250224,"avatar_url":"https://avatars0.githubusercontent.com/u/250224?v=3","gravatar_id":"","url":"https://api.github.com/users/kallewoof","html_url":"https://github.com/kallewoof","followers_url":"https://api.github.com/users/kallewoof/followers","following_url":"https://api.github.com/users/kallewoof/following{/other_user}","gists_url":"https://api.github.com/users/kallewoof/gists{/gist_id}","starred_url":"https://api.github.com/users/kallewoof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kallewoof/subscriptions","organizations_url":"https://api.github.com/users/kallewoof/orgs","repos_url":"https://api.github.com/users/kallewoof/repos","events_url":"https://api.github.com/users/kallewoof/events{/privacy}","received_events_url":"https://api.github.com/users/kallewoof/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kallewoof/bitcoin","description":"Bitcoin Core integration/staging tree","fork":true,"url":"https://api.github.com/repos/kallewoof/bitcoin","forks_url":"https://api.github.com/repos/kallewoof/bitcoin/forks","keys_url":"https://api.github.com/repos/kallewoof/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kallewoof/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kallewoof/bitcoin/teams","hooks_url":"https://api.github.com/repos/kallewoof/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/kallewoof/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/kallewoof/bitcoin/events","assignees_url":"https://api.github.com/repos/kallewoof/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/kallewoof/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/kallewoof/bitcoin/tags","blobs_url":"https://api.github.com/repos/kallewoof/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kallewoof/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kallewoof/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/kallewoof/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kallewoof/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/kallewoof/bitcoin/languages","stargazers_url":"https://api.github.com/repos/kallewoof/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/kallewoof/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/kallewoof/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/kallewoof/bitcoin/subscription","commits_url":"https://api.github.com/repos/kallewoof/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/kallewoof/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/kallewoof/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/kallewoof/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/kallewoof/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/kallewoof/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kallewoof/bitcoin/merges","archive_url":"https://api.github.com/repos/kallewoof/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kallewoof/bitcoin/downloads","issues_url":"https://api.github.com/repos/kallewoof/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/kallewoof/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/kallewoof/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/kallewoof/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kallewoof/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/kallewoof/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/kallewoof/bitcoin/deployments","created_at":"2016-11-25T06:59:31Z","updated_at":"2016-11-25T06:59:44Z","pushed_at":"2017-05-22T09:13:56Z","git_url":"git://github.com/kallewoof/bitcoin.git","ssh_url":"git@github.com:kallewoof/bitcoin.git","clone_url":"https://github.com/kallewoof/bitcoin.git","svn_url":"https://github.com/kallewoof/bitcoin","homepage":"https://bitcoin.org/en/download","size":82355,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"bitcoin:master","ref":"master","sha":"80c3a734298e824f9321c4efdd446086a3baad89","user":{"login":"bitcoin","id":528860,"avatar_url":"https://avatars1.githubusercontent.com/u/528860?v=3","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"repo":{"id":1181927,"name":"bitcoin","full_name":"bitcoin/bitcoin","owner":{"login":"bitcoin","id":528860,"avatar_url":"https://avatars1.githubusercontent.com/u/528860?v=3","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bitcoin/bitcoin","description":"Bitcoin Core integration/staging tree","fork":false,"url":"https://api.github.com/repos/bitcoin/bitcoin","forks_url":"https://api.github.com/repos/bitcoin/bitcoin/forks","keys_url":"https://api.github.com/repos/bitcoin/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin/bitcoin/teams","hooks_url":"https://api.github.com/repos/bitcoin/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin/bitcoin/events","assignees_url":"https://api.github.com/repos/bitcoin/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin/bitcoin/tags","blobs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin/bitcoin/languages","stargazers_url":"https://api.github.com/repos/bitcoin/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/bitcoin/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/bitcoin/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/bitcoin/bitcoin/subscription","commits_url":"https://api.github.com/repos/bitcoin/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoin/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin/bitcoin/merges","archive_url":"https://api.github.com/repos/bitcoin/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin/bitcoin/downloads","issues_url":"https://api.github.com/repos/bitcoin/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/bitcoin/bitcoin/deployments","created_at":"2010-12-19T15:16:43Z","updated_at":"2017-05-31T15:36:02Z","pushed_at":"2017-05-31T16:49:52Z","git_url":"git://github.com/bitcoin/bitcoin.git","ssh_url":"git@github.com:bitcoin/bitcoin.git","clone_url":"https://github.com/bitcoin/bitcoin.git","svn_url":"https://github.com/bitcoin/bitcoin","homepage":"https://bitcoin.org/en/download","size":83332,"stargazers_count":12972,"watchers_count":12972,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":8348,"mirror_url":null,"open_issues_count":679,"forks":8348,"open_issues":679,"watchers":12972,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/10303"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/10303"},"issue":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/10303"},"comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/10303/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/10303/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/10303/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin/bitcoin/statuses/1d0cdc07c4db1e0d0df7a55696543165506de09f"}}}}
{"actor":{"display_login":"jtimon"}}