{"action":"created","issue":{"url":"https://api.github.com/repos/GoogleChrome/workbox/issues/812","repository_url":"https://api.github.com/repos/GoogleChrome/workbox","labels_url":"https://api.github.com/repos/GoogleChrome/workbox/issues/812/labels{/name}","comments_url":"https://api.github.com/repos/GoogleChrome/workbox/issues/812/comments","events_url":"https://api.github.com/repos/GoogleChrome/workbox/issues/812/events","html_url":"https://github.com/GoogleChrome/workbox/issues/812","id":259322601,"number":812,"title":"Using `async`, `await` makes workbox without further transpilation break on Samsung Internet","user":{"login":"HenrikJoreteg","id":67925,"avatar_url":"https://avatars1.githubusercontent.com/u/67925?v=4","gravatar_id":"","url":"https://api.github.com/users/HenrikJoreteg","html_url":"https://github.com/HenrikJoreteg","followers_url":"https://api.github.com/users/HenrikJoreteg/followers","following_url":"https://api.github.com/users/HenrikJoreteg/following{/other_user}","gists_url":"https://api.github.com/users/HenrikJoreteg/gists{/gist_id}","starred_url":"https://api.github.com/users/HenrikJoreteg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HenrikJoreteg/subscriptions","organizations_url":"https://api.github.com/users/HenrikJoreteg/orgs","repos_url":"https://api.github.com/users/HenrikJoreteg/repos","events_url":"https://api.github.com/users/HenrikJoreteg/events{/privacy}","received_events_url":"https://api.github.com/users/HenrikJoreteg/received_events","type":"User","site_admin":false},"labels":[{"id":611500514,"url":"https://api.github.com/repos/GoogleChrome/workbox/labels/discuss","name":"discuss","color":"fbca04","default":false},{"id":571606198,"url":"https://api.github.com/repos/GoogleChrome/workbox/labels/P1","name":"P1","color":"0052cc","default":false}],"state":"open","locked":false,"assignee":{"login":"gauntface","id":139760,"avatar_url":"https://avatars0.githubusercontent.com/u/139760?v=4","gravatar_id":"","url":"https://api.github.com/users/gauntface","html_url":"https://github.com/gauntface","followers_url":"https://api.github.com/users/gauntface/followers","following_url":"https://api.github.com/users/gauntface/following{/other_user}","gists_url":"https://api.github.com/users/gauntface/gists{/gist_id}","starred_url":"https://api.github.com/users/gauntface/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gauntface/subscriptions","organizations_url":"https://api.github.com/users/gauntface/orgs","repos_url":"https://api.github.com/users/gauntface/repos","events_url":"https://api.github.com/users/gauntface/events{/privacy}","received_events_url":"https://api.github.com/users/gauntface/received_events","type":"User","site_admin":false},"assignees":[{"login":"gauntface","id":139760,"avatar_url":"https://avatars0.githubusercontent.com/u/139760?v=4","gravatar_id":"","url":"https://api.github.com/users/gauntface","html_url":"https://github.com/gauntface","followers_url":"https://api.github.com/users/gauntface/followers","following_url":"https://api.github.com/users/gauntface/following{/other_user}","gists_url":"https://api.github.com/users/gauntface/gists{/gist_id}","starred_url":"https://api.github.com/users/gauntface/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gauntface/subscriptions","organizations_url":"https://api.github.com/users/gauntface/orgs","repos_url":"https://api.github.com/users/gauntface/repos","events_url":"https://api.github.com/users/gauntface/events{/privacy}","received_events_url":"https://api.github.com/users/gauntface/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2017-09-20T22:35:38Z","updated_at":"2017-09-22T00:28:54Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"See twitter discussion here: https://twitter.com/addyosmani/status/910631449753141253\r\n\r\n@poshaughnessy noticed the starbucks PWA's SW isn't installing properly on Samsung Internet.\r\n\r\nTurns out this is because of usage of `async` and `await`. \r\n\r\n**Library Affected**:\r\nall\r\n\r\n**Browser & Platform**:\r\nSamsung Internet\r\n\r\n**Issue or Feature Request Description**:\r\nProbably best to not use it in distributed versions if you expect people to be able to use it as is in Samsung Internet.\r\n\r\nTo repro, open https://preview.starbucks.com in inspect devices on samsung internet. It fails on line 80 of our SW which is the included Workbox code: https://preview.starbucks.com/serviceworker.js\r\n\r\nWHich is the first usage of async/await."},"comment":{"url":"https://api.github.com/repos/GoogleChrome/workbox/issues/comments/331317622","html_url":"https://github.com/GoogleChrome/workbox/issues/812#issuecomment-331317622","issue_url":"https://api.github.com/repos/GoogleChrome/workbox/issues/812","id":331317622,"user":{"login":"jeffposnick","id":1749548,"avatar_url":"https://avatars1.githubusercontent.com/u/1749548?v=4","gravatar_id":"","url":"https://api.github.com/users/jeffposnick","html_url":"https://github.com/jeffposnick","followers_url":"https://api.github.com/users/jeffposnick/followers","following_url":"https://api.github.com/users/jeffposnick/following{/other_user}","gists_url":"https://api.github.com/users/jeffposnick/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffposnick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffposnick/subscriptions","organizations_url":"https://api.github.com/users/jeffposnick/orgs","repos_url":"https://api.github.com/users/jeffposnick/repos","events_url":"https://api.github.com/users/jeffposnick/events{/privacy}","received_events_url":"https://api.github.com/users/jeffposnick/received_events","type":"User","site_admin":false},"created_at":"2017-09-22T00:28:54Z","updated_at":"2017-09-22T00:28:54Z","author_association":"COLLABORATOR","body":"While it's still open for discussion, I wanted to take a look at the impact of changing our [current Babel usage](https://github.com/GoogleChrome/workbox/blob/master/utils/build.js#L159) to include `babel-preset-env`  with the following configuration:\r\n\r\n```js\r\nconst babelPlugin = babel({\r\n  presets: [['env', {\r\n    targets: {\r\n      browsers: ['chrome >= 51'],\r\n    },\r\n    modules: false,\r\n  }], ['babili', {\r\n    comments: false,\r\n  }]],\r\n  plugins: ['external-helpers'],\r\n});\r\n```\r\n\r\nIt brings the final size of `workbox-sw.prod.v2.0.1.js` up by 1.8kb, to a total of 48879 bytes."}}
{"actor":{"display_login":"jeffposnick"}}