{"action":"created","issue":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/14235","repository_url":"https://api.github.com/repos/joomla/joomla-cms","labels_url":"https://api.github.com/repos/joomla/joomla-cms/issues/14235/labels{/name}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/14235/comments","events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/14235/events","html_url":"https://github.com/joomla/joomla-cms/pull/14235","id":210107246,"number":14235,"title":"Improve checks for important menu items in custom admin menu","user":{"login":"izharaazmi","id":6706189,"avatar_url":"https://avatars.githubusercontent.com/u/6706189?v=3","gravatar_id":"","url":"https://api.github.com/users/izharaazmi","html_url":"https://github.com/izharaazmi","followers_url":"https://api.github.com/users/izharaazmi/followers","following_url":"https://api.github.com/users/izharaazmi/following{/other_user}","gists_url":"https://api.github.com/users/izharaazmi/gists{/gist_id}","starred_url":"https://api.github.com/users/izharaazmi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/izharaazmi/subscriptions","organizations_url":"https://api.github.com/users/izharaazmi/orgs","repos_url":"https://api.github.com/users/izharaazmi/repos","events_url":"https://api.github.com/users/izharaazmi/events{/privacy}","received_events_url":"https://api.github.com/users/izharaazmi/received_events","type":"User","site_admin":false},"labels":[{"id":198658453,"url":"https://api.github.com/repos/joomla/joomla-cms/labels/Language%20Change","name":"Language Change","color":"eb6420","default":false},{"id":60721348,"url":"https://api.github.com/repos/joomla/joomla-cms/labels/PR-staging","name":"PR-staging","color":"c7def8","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-02-24T17:19:55Z","updated_at":"2017-02-25T11:03:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/14235","html_url":"https://github.com/joomla/joomla-cms/pull/14235","diff_url":"https://github.com/joomla/joomla-cms/pull/14235.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/14235.patch"},"body":"Improve checks for presence of important menu items in custom admin menu.\r\n\r\n### Summary of Changes\r\n* Improve recovery link to bring user back to same page when switching recovery mode on/off, currently it takes the user to admin home page.\r\n* One liner message for all the 3 important menu item for simplicity.\r\n* Stop annoying info alert on every page when user is in menu recovery mode and show “exit recovery” as a menu item inside recovery menu parent itself.\r\n\r\n### Testing Instructions\r\n* Create a custom admin menu and set it as your active menu in menu module settings.\r\n* A message stating that the important menu items Module Manager, Menu Manger and Component Container are missing should be shown including a link to enable the recovery mode.\r\n* Creating any of these items in the custom admin menu should remove that item from the list of missing items in the warning.\r\n* Exit recovery mode should be shown in the recovery menu when you turn on recovery mode.\r\n\r\n### Documentation Changes Required\r\nNone"},"comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments/282476888","html_url":"https://github.com/joomla/joomla-cms/pull/14235#issuecomment-282476888","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/14235","id":282476888,"user":{"login":"infograf768","id":869724,"avatar_url":"https://avatars.githubusercontent.com/u/869724?v=3","gravatar_id":"","url":"https://api.github.com/users/infograf768","html_url":"https://github.com/infograf768","followers_url":"https://api.github.com/users/infograf768/followers","following_url":"https://api.github.com/users/infograf768/following{/other_user}","gists_url":"https://api.github.com/users/infograf768/gists{/gist_id}","starred_url":"https://api.github.com/users/infograf768/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infograf768/subscriptions","organizations_url":"https://api.github.com/users/infograf768/orgs","repos_url":"https://api.github.com/users/infograf768/repos","events_url":"https://api.github.com/users/infograf768/events{/privacy}","received_events_url":"https://api.github.com/users/infograf768/received_events","type":"User","site_admin":false},"created_at":"2017-02-25T11:03:49Z","updated_at":"2017-02-25T11:03:49Z","body":"> IMO, only one can be active at a time. Did you create two modules?\r\n\r\nYep. This the nice feature about it. One may create multiple custom admin languages (needs multiple admin menutypes and their modules). Then it is \"just\" a matter of creating the correct access levels. \r\nThat last part can be tricky as core defines \"Special\" as common access level for quite a few user groups. Tricky but not impossible."}}
{"actor":{"display_login":"infograf768"}}