{"action":"created","issue":{"url":"https://api.github.com/repos/SpongePowered/SpongeCommon/issues/1625","repository_url":"https://api.github.com/repos/SpongePowered/SpongeCommon","labels_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/issues/1625/labels{/name}","comments_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/issues/1625/comments","events_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/issues/1625/events","html_url":"https://github.com/SpongePowered/SpongeCommon/pull/1625","id":277575775,"number":1625,"title":"Update SpongeCommon Color Usage","user":{"login":"SimonFlash","id":25996030,"avatar_url":"https://avatars1.githubusercontent.com/u/25996030?v=4","gravatar_id":"","url":"https://api.github.com/users/SimonFlash","html_url":"https://github.com/SimonFlash","followers_url":"https://api.github.com/users/SimonFlash/followers","following_url":"https://api.github.com/users/SimonFlash/following{/other_user}","gists_url":"https://api.github.com/users/SimonFlash/gists{/gist_id}","starred_url":"https://api.github.com/users/SimonFlash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimonFlash/subscriptions","organizations_url":"https://api.github.com/users/SimonFlash/orgs","repos_url":"https://api.github.com/users/SimonFlash/repos","events_url":"https://api.github.com/users/SimonFlash/events{/privacy}","received_events_url":"https://api.github.com/users/SimonFlash/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-11-28T23:29:20Z","updated_at":"2017-12-01T03:39:27Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/SpongePowered/SpongeCommon/pulls/1625","html_url":"https://github.com/SpongePowered/SpongeCommon/pull/1625","diff_url":"https://github.com/SpongePowered/SpongeCommon/pull/1625.diff","patch_url":"https://github.com/SpongePowered/SpongeCommon/pull/1625.patch"},"body":"[SpongeAPI](https://github.com/SpongePowered/SpongeAPI/pull/1699) | [SpongeCommon](https://github.com/SpongePowered/SpongeCommon/pull/1625)\r\n\r\nThis PR updates SpongeCommon for the changes made in SpongeAPI, notably the deprecation of `Color#ofRbg(int)` and the addition of `TextColor#getBackgroundColor()`. Additionally, this also removes the `ColorUtil` class and migrates any methods still used to `ColoredDataProcessor` or `NBTDataUtil`.\r\n\r\nEdit: I have no idea what I did the first time around, but thanks to Faithcaio and phit things are no longer a mess. In the meantime, I have been tasked with reading a git book - adiou!"},"comment":{"url":"https://api.github.com/repos/SpongePowered/SpongeCommon/issues/comments/348393083","html_url":"https://github.com/SpongePowered/SpongeCommon/pull/1625#issuecomment-348393083","issue_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/issues/1625","id":348393083,"user":{"login":"SimonFlash","id":25996030,"avatar_url":"https://avatars1.githubusercontent.com/u/25996030?v=4","gravatar_id":"","url":"https://api.github.com/users/SimonFlash","html_url":"https://github.com/SimonFlash","followers_url":"https://api.github.com/users/SimonFlash/followers","following_url":"https://api.github.com/users/SimonFlash/following{/other_user}","gists_url":"https://api.github.com/users/SimonFlash/gists{/gist_id}","starred_url":"https://api.github.com/users/SimonFlash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimonFlash/subscriptions","organizations_url":"https://api.github.com/users/SimonFlash/orgs","repos_url":"https://api.github.com/users/SimonFlash/repos","events_url":"https://api.github.com/users/SimonFlash/events{/privacy}","received_events_url":"https://api.github.com/users/SimonFlash/received_events","type":"User","site_admin":false},"created_at":"2017-12-01T03:39:27Z","updated_at":"2017-12-01T03:39:27Z","author_association":"NONE","body":"The trend throughout most of Common is to have a separate `...Builder` class, but this seems to apply to classes such as `ItemStack` that aren't implemented in Sponge. If we would prefer have a `SpongeColor` and `SpongeColorBuilder` it's an easy change to make.\r\n\r\nAlso, I'm not sure how to setup the `ColorTest` to work in Common because the registry would need to be initialized to get the color builder. If anyone could provide direction on this that'd be great."}}
{"actor":{"display_login":"SimonFlash"}}