{"action":"created","issue":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/15695","repository_url":"https://api.github.com/repos/joomla/joomla-cms","labels_url":"https://api.github.com/repos/joomla/joomla-cms/issues/15695/labels{/name}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/15695/comments","events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/15695/events","html_url":"https://github.com/joomla/joomla-cms/pull/15695","id":225316877,"number":15695,"title":"fix for reserved menutype  \"main\"","user":{"login":"alikon","id":181681,"avatar_url":"https://avatars3.githubusercontent.com/u/181681?v=3","gravatar_id":"","url":"https://api.github.com/users/alikon","html_url":"https://github.com/alikon","followers_url":"https://api.github.com/users/alikon/followers","following_url":"https://api.github.com/users/alikon/following{/other_user}","gists_url":"https://api.github.com/users/alikon/gists{/gist_id}","starred_url":"https://api.github.com/users/alikon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alikon/subscriptions","organizations_url":"https://api.github.com/users/alikon/orgs","repos_url":"https://api.github.com/users/alikon/repos","events_url":"https://api.github.com/users/alikon/events{/privacy}","received_events_url":"https://api.github.com/users/alikon/received_events","type":"User","site_admin":false},"labels":[{"id":60721348,"url":"https://api.github.com/repos/joomla/joomla-cms/labels/PR-staging","name":"PR-staging","color":"c7def8","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":12,"created_at":"2017-04-30T09:49:10Z","updated_at":"2017-05-02T18:12:58Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/15695","html_url":"https://github.com/joomla/joomla-cms/pull/15695","diff_url":"https://github.com/joomla/joomla-cms/pull/15695.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/15695.patch"},"body":"Pull Request for Issue #15671  .\r\n\r\n### Summary of Changes\r\nstarting from ~~3.6.5~~ 2.5 the menu type `\"menu\"` and `\"main\"` are reserved in 3.7.0 only `\"main\"`\r\nso if you are upgranding from a prevoius version  and you have a menutype named  `\"main\"` (was alloweed)\r\n\r\nthis update in administrator/components/com_admin/sql/updates/mysql/3.7.0-2017-01-17.sql\r\n\r\n```sql\r\nUPDATE `#__menu` SET `menutype` = 'main', `client_id` = 1  WHERE `menutype` = 'main' OR `menutype` = 'menu';\r\n```\r\nis not correct  for no pseudo FK ect, changed to : \r\n\r\n```sql\r\nUPDATE `#__menu`\r\nSET `#__menu`.`menutype` = 'menutype_main_is_reserved'\r\n    ,`client_id` = 1\r\nWHERE `#__menu`.`menutype` = 'main' ;\r\n\r\nUPDATE `#__menu_types` \r\nSET `#__menu_types`.`menutype` = 'menutype_main_is_reserved'\r\n    ,`client_id` = 1\r\nWHERE  `#__menu_types`.`menutype` = 'main';\r\n```\r\n\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments/298716234","html_url":"https://github.com/joomla/joomla-cms/pull/15695#issuecomment-298716234","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/15695","id":298716234,"user":{"login":"PhilETaylor","id":400092,"avatar_url":"https://avatars2.githubusercontent.com/u/400092?v=3","gravatar_id":"","url":"https://api.github.com/users/PhilETaylor","html_url":"https://github.com/PhilETaylor","followers_url":"https://api.github.com/users/PhilETaylor/followers","following_url":"https://api.github.com/users/PhilETaylor/following{/other_user}","gists_url":"https://api.github.com/users/PhilETaylor/gists{/gist_id}","starred_url":"https://api.github.com/users/PhilETaylor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PhilETaylor/subscriptions","organizations_url":"https://api.github.com/users/PhilETaylor/orgs","repos_url":"https://api.github.com/users/PhilETaylor/repos","events_url":"https://api.github.com/users/PhilETaylor/events{/privacy}","received_events_url":"https://api.github.com/users/PhilETaylor/received_events","type":"User","site_admin":false},"created_at":"2017-05-02T18:12:58Z","updated_at":"2017-05-02T18:12:58Z","body":"> The problem is that when some menus already are messed by 3.7.0-2017-01-17.sql with the Joomla 3.7.0 update, there is no SQL statement to change them back because they can't be distinguished from other menus for which the oroginal SQL statement from 3.7.0-2017-01-17.sql was applied by intention\r\n\r\nwhich is what I mean by `closing the door after the horse has bolted.` (possibly lost in translation) "}}
{"actor":{"display_login":"PhilETaylor"}}