{"action":"created","comment":{"url":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments/142034299","pull_request_review_id":66341136,"id":142034299,"diff_hunk":"@@ -63,7 +63,7 @@ class TestPDApi(Base):\n     # top-level functions\n     funcs = ['bdate_range', 'concat', 'crosstab', 'cut',\n              'date_range', 'interval_range', 'eval',\n-             'factorize', 'get_dummies', 'cdate_range',\n+             'factorize', 'get_dummies',","path":"pandas/tests/api/test_api.py","position":5,"original_position":5,"commit_id":"7306a7339053091cefbb42433684ccd95e727bf1","original_commit_id":"7306a7339053091cefbb42433684ccd95e727bf1","user":{"login":"jreback","id":953992,"avatar_url":"https://avatars2.githubusercontent.com/u/953992?v=4","gravatar_id":"","url":"https://api.github.com/users/jreback","html_url":"https://github.com/jreback","followers_url":"https://api.github.com/users/jreback/followers","following_url":"https://api.github.com/users/jreback/following{/other_user}","gists_url":"https://api.github.com/users/jreback/gists{/gist_id}","starred_url":"https://api.github.com/users/jreback/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jreback/subscriptions","organizations_url":"https://api.github.com/users/jreback/orgs","repos_url":"https://api.github.com/users/jreback/repos","events_url":"https://api.github.com/users/jreback/events{/privacy}","received_events_url":"https://api.github.com/users/jreback/received_events","type":"User","site_admin":false},"body":"move to the deprecated functions section, and add a test (in same module), model after the top-level deprecations.","created_at":"2017-10-01T16:41:03Z","updated_at":"2017-10-01T16:42:48Z","html_url":"https://github.com/pandas-dev/pandas/pull/17691#discussion_r142034299","pull_request_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/17691","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments/142034299"},"html":{"href":"https://github.com/pandas-dev/pandas/pull/17691#discussion_r142034299"},"pull_request":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/17691"}}},"pull_request":{"url":"https://api.github.com/repos/pandas-dev/pandas/pulls/17691","id":143303498,"html_url":"https://github.com/pandas-dev/pandas/pull/17691","diff_url":"https://github.com/pandas-dev/pandas/pull/17691.diff","patch_url":"https://github.com/pandas-dev/pandas/pull/17691.patch","issue_url":"https://api.github.com/repos/pandas-dev/pandas/issues/17691","number":17691,"state":"open","locked":false,"title":"DEPR: Deprecate cdate_range and merge into bdate_range","user":{"login":"jschendel","id":5332445,"avatar_url":"https://avatars3.githubusercontent.com/u/5332445?v=4","gravatar_id":"","url":"https://api.github.com/users/jschendel","html_url":"https://github.com/jschendel","followers_url":"https://api.github.com/users/jschendel/followers","following_url":"https://api.github.com/users/jschendel/following{/other_user}","gists_url":"https://api.github.com/users/jschendel/gists{/gist_id}","starred_url":"https://api.github.com/users/jschendel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jschendel/subscriptions","organizations_url":"https://api.github.com/users/jschendel/orgs","repos_url":"https://api.github.com/users/jschendel/repos","events_url":"https://api.github.com/users/jschendel/events{/privacy}","received_events_url":"https://api.github.com/users/jschendel/received_events","type":"User","site_admin":false},"body":"- [X] closes #17596\r\n- [X] tests added / passed\r\n- [X] passes `git diff upstream/master -u -- \"*.py\" | flake8 --diff`\r\n- [X] whatsnew entry\r\n\r\nA bit going on here, so see summary below.\r\n\r\nDeprecated `cdate_range`:\r\n- Removed from api (was added to api after 0.20.3 release)\r\n- Added a `FutureWarning` to `cdate_range` indicating deprecation\r\n    - Added a test for this too\r\n- Converted other tests using `cdate_range` to use `bdate_range` instead\r\n    - Cleaned up the entire test script to make it more consistent with others (i.e. `with` context)\r\n- Removed a reference to `cdate_range` from the current whatsnew (previous commit I wrote)\r\n\r\nExpanded functionality of `bdate_range`:\r\n- Added the additional `cdate_range` params (`weekmask`, `holidays`) for custom frequency ranges\r\n- Expanded that functionality beyond what was previously present in `cdate_range`\r\n    - `cdate_range` only supported cday with the `weekmask` and `holidays` params, now all custom freqs are supported.\r\n    - Did this by checking if the passed freq starts with 'C'.\r\n    - Added a test that should catch if a new non-custom freq is added that starts with 'C'.\r\n    - Didn't add this to `cdate_range`; left that as-is.\r\n- Added a `UserWarning` if non-default `weekmask` or `holidays` are passed without a custom freq.\r\n    - Added a test for this too.\r\n\r\nEdits to `timeseries.rst`:\r\n- Added a custom freq `bdate_range` example to the \"Generating Ranges of Timestamps\" section\r\n- Reordered some of the examples in the \"Generating Ranges of Timestamps\" section\r\n    - Tried to order examples by simplicity\r\n- Otherwise, mostly small rewording changes and other such small fixes (ticks, capitalization, etc.).\r\n","created_at":"2017-09-27T05:48:25Z","updated_at":"2017-10-01T16:42:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d0fc10c68be0a63afdf18d4d3572966507b16aff","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/pandas-dev/pandas/milestones/46","html_url":"https://github.com/pandas-dev/pandas/milestone/46","labels_url":"https://api.github.com/repos/pandas-dev/pandas/milestones/46/labels","id":2406656,"number":46,"title":"0.21.0","description":"","creator":{"login":"jreback","id":953992,"avatar_url":"https://avatars2.githubusercontent.com/u/953992?v=4","gravatar_id":"","url":"https://api.github.com/users/jreback","html_url":"https://github.com/jreback","followers_url":"https://api.github.com/users/jreback/followers","following_url":"https://api.github.com/users/jreback/following{/other_user}","gists_url":"https://api.github.com/users/jreback/gists{/gist_id}","starred_url":"https://api.github.com/users/jreback/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jreback/subscriptions","organizations_url":"https://api.github.com/users/jreback/orgs","repos_url":"https://api.github.com/users/jreback/repos","events_url":"https://api.github.com/users/jreback/events{/privacy}","received_events_url":"https://api.github.com/users/jreback/received_events","type":"User","site_admin":false},"open_issues":43,"closed_issues":601,"state":"open","created_at":"2017-03-23T13:26:25Z","updated_at":"2017-10-01T14:55:33Z","due_on":"2017-10-10T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/17691/commits","review_comments_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/17691/comments","review_comment_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pandas-dev/pandas/issues/17691/comments","statuses_url":"https://api.github.com/repos/pandas-dev/pandas/statuses/7306a7339053091cefbb42433684ccd95e727bf1","head":{"label":"jschendel:depr-cdate_range","ref":"depr-cdate_range","sha":"7306a7339053091cefbb42433684ccd95e727bf1","user":{"login":"jschendel","id":5332445,"avatar_url":"https://avatars3.githubusercontent.com/u/5332445?v=4","gravatar_id":"","url":"https://api.github.com/users/jschendel","html_url":"https://github.com/jschendel","followers_url":"https://api.github.com/users/jschendel/followers","following_url":"https://api.github.com/users/jschendel/following{/other_user}","gists_url":"https://api.github.com/users/jschendel/gists{/gist_id}","starred_url":"https://api.github.com/users/jschendel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jschendel/subscriptions","organizations_url":"https://api.github.com/users/jschendel/orgs","repos_url":"https://api.github.com/users/jschendel/repos","events_url":"https://api.github.com/users/jschendel/events{/privacy}","received_events_url":"https://api.github.com/users/jschendel/received_events","type":"User","site_admin":false},"repo":{"id":97878042,"name":"pandas","full_name":"jschendel/pandas","owner":{"login":"jschendel","id":5332445,"avatar_url":"https://avatars3.githubusercontent.com/u/5332445?v=4","gravatar_id":"","url":"https://api.github.com/users/jschendel","html_url":"https://github.com/jschendel","followers_url":"https://api.github.com/users/jschendel/followers","following_url":"https://api.github.com/users/jschendel/following{/other_user}","gists_url":"https://api.github.com/users/jschendel/gists{/gist_id}","starred_url":"https://api.github.com/users/jschendel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jschendel/subscriptions","organizations_url":"https://api.github.com/users/jschendel/orgs","repos_url":"https://api.github.com/users/jschendel/repos","events_url":"https://api.github.com/users/jschendel/events{/privacy}","received_events_url":"https://api.github.com/users/jschendel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jschendel/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":true,"url":"https://api.github.com/repos/jschendel/pandas","forks_url":"https://api.github.com/repos/jschendel/pandas/forks","keys_url":"https://api.github.com/repos/jschendel/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jschendel/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jschendel/pandas/teams","hooks_url":"https://api.github.com/repos/jschendel/pandas/hooks","issue_events_url":"https://api.github.com/repos/jschendel/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/jschendel/pandas/events","assignees_url":"https://api.github.com/repos/jschendel/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/jschendel/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/jschendel/pandas/tags","blobs_url":"https://api.github.com/repos/jschendel/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jschendel/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jschendel/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/jschendel/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jschendel/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/jschendel/pandas/languages","stargazers_url":"https://api.github.com/repos/jschendel/pandas/stargazers","contributors_url":"https://api.github.com/repos/jschendel/pandas/contributors","subscribers_url":"https://api.github.com/repos/jschendel/pandas/subscribers","subscription_url":"https://api.github.com/repos/jschendel/pandas/subscription","commits_url":"https://api.github.com/repos/jschendel/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/jschendel/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/jschendel/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/jschendel/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/jschendel/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/jschendel/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jschendel/pandas/merges","archive_url":"https://api.github.com/repos/jschendel/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jschendel/pandas/downloads","issues_url":"https://api.github.com/repos/jschendel/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/jschendel/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/jschendel/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/jschendel/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jschendel/pandas/labels{/name}","releases_url":"https://api.github.com/repos/jschendel/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/jschendel/pandas/deployments","created_at":"2017-07-20T21:02:09Z","updated_at":"2017-07-20T21:02:17Z","pushed_at":"2017-09-30T18:38:53Z","git_url":"git://github.com/jschendel/pandas.git","ssh_url":"git@github.com:jschendel/pandas.git","clone_url":"https://github.com/jschendel/pandas.git","svn_url":"https://github.com/jschendel/pandas","homepage":"http://pandas.pydata.org","size":105195,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pandas-dev:master","ref":"master","sha":"bbf0ddaf6461a9586c5e459d9c00fe863adc43f8","user":{"login":"pandas-dev","id":21206976,"avatar_url":"https://avatars2.githubusercontent.com/u/21206976?v=4","gravatar_id":"","url":"https://api.github.com/users/pandas-dev","html_url":"https://github.com/pandas-dev","followers_url":"https://api.github.com/users/pandas-dev/followers","following_url":"https://api.github.com/users/pandas-dev/following{/other_user}","gists_url":"https://api.github.com/users/pandas-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pandas-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandas-dev/subscriptions","organizations_url":"https://api.github.com/users/pandas-dev/orgs","repos_url":"https://api.github.com/users/pandas-dev/repos","events_url":"https://api.github.com/users/pandas-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pandas-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":858127,"name":"pandas","full_name":"pandas-dev/pandas","owner":{"login":"pandas-dev","id":21206976,"avatar_url":"https://avatars2.githubusercontent.com/u/21206976?v=4","gravatar_id":"","url":"https://api.github.com/users/pandas-dev","html_url":"https://github.com/pandas-dev","followers_url":"https://api.github.com/users/pandas-dev/followers","following_url":"https://api.github.com/users/pandas-dev/following{/other_user}","gists_url":"https://api.github.com/users/pandas-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pandas-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandas-dev/subscriptions","organizations_url":"https://api.github.com/users/pandas-dev/orgs","repos_url":"https://api.github.com/users/pandas-dev/repos","events_url":"https://api.github.com/users/pandas-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pandas-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pandas-dev/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":false,"url":"https://api.github.com/repos/pandas-dev/pandas","forks_url":"https://api.github.com/repos/pandas-dev/pandas/forks","keys_url":"https://api.github.com/repos/pandas-dev/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pandas-dev/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pandas-dev/pandas/teams","hooks_url":"https://api.github.com/repos/pandas-dev/pandas/hooks","issue_events_url":"https://api.github.com/repos/pandas-dev/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/pandas-dev/pandas/events","assignees_url":"https://api.github.com/repos/pandas-dev/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/pandas-dev/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/pandas-dev/pandas/tags","blobs_url":"https://api.github.com/repos/pandas-dev/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pandas-dev/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pandas-dev/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/pandas-dev/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pandas-dev/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/pandas-dev/pandas/languages","stargazers_url":"https://api.github.com/repos/pandas-dev/pandas/stargazers","contributors_url":"https://api.github.com/repos/pandas-dev/pandas/contributors","subscribers_url":"https://api.github.com/repos/pandas-dev/pandas/subscribers","subscription_url":"https://api.github.com/repos/pandas-dev/pandas/subscription","commits_url":"https://api.github.com/repos/pandas-dev/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/pandas-dev/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/pandas-dev/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/pandas-dev/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/pandas-dev/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/pandas-dev/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pandas-dev/pandas/merges","archive_url":"https://api.github.com/repos/pandas-dev/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pandas-dev/pandas/downloads","issues_url":"https://api.github.com/repos/pandas-dev/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/pandas-dev/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/pandas-dev/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/pandas-dev/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pandas-dev/pandas/labels{/name}","releases_url":"https://api.github.com/repos/pandas-dev/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/pandas-dev/pandas/deployments","created_at":"2010-08-24T01:37:33Z","updated_at":"2017-10-01T16:25:06Z","pushed_at":"2017-10-01T16:33:59Z","git_url":"git://github.com/pandas-dev/pandas.git","ssh_url":"git@github.com:pandas-dev/pandas.git","clone_url":"https://github.com/pandas-dev/pandas.git","svn_url":"https://github.com/pandas-dev/pandas","homepage":"http://pandas.pydata.org","size":105348,"stargazers_count":11021,"watchers_count":11021,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4368,"mirror_url":null,"open_issues_count":2131,"forks":4368,"open_issues":2131,"watchers":11021,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/17691"},"html":{"href":"https://github.com/pandas-dev/pandas/pull/17691"},"issue":{"href":"https://api.github.com/repos/pandas-dev/pandas/issues/17691"},"comments":{"href":"https://api.github.com/repos/pandas-dev/pandas/issues/17691/comments"},"review_comments":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/17691/comments"},"review_comment":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/17691/commits"},"statuses":{"href":"https://api.github.com/repos/pandas-dev/pandas/statuses/7306a7339053091cefbb42433684ccd95e727bf1"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jreback"}}