{"action":"created","comment":{"url":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/pulls/comments/114565975","pull_request_review_id":36043180,"id":114565975,"diff_hunk":"@@ -2,23 +2,99 @@ let debug       = require('debug')('deployer-projects');\n let Q           = require('q');\r\n let _           = require('underscore');\r\n let jobrunner   = require('../jobrunner');\r\n+let validationrunner   = require('../validationrunner');\r\n let cheerio     = require('cheerio');\r\n let jobservice  = require('../services/job-service');\r\n \r\n+\r\n exports.list = (req, res) => {\r\n   let jobs = jobrunner.getJobs();\r\n   debug('jobs - ' + jobs.length);\r\n   res.send(jobs);\r\n };\r\n \r\n+exports.listValidations = (req, res) => {\r\n+  let validations = validationrunner.getValidations();\r\n+  debug('validations - ' + validations.length);\r\n+  res.send([]);\r\n+};\r\n+\r\n+exports.getValidations = (req, res) => {\r\n+  let jobId = req.param('validationId');\r\n+  debug('getValidations ' + jobId);\r\n+  validationrunner.getValidation(jobId, (err, data) => {\r\n+    let runLogs = [];\r\n+\r\n+    // data.tasks structure looks like this:\r\n+    //    data: { tasks: [{ subtask: {name: '', runLog: ['message']}]}\r\n+    // we're trying to flatten it here like this:\r\n+    //    runLogs: [message: 'message', machine: subtask.name] }\r\n+\r\n+    _.each(data.tasks, function(task) {\r","path":"src/server/controllers/jobs.js","position":32,"original_position":32,"commit_id":"2960807bf4f5ec04717974b0f126f70628d9adce","original_commit_id":"2960807bf4f5ec04717974b0f126f70628d9adce","user":{"login":"adampaulberg","id":4030607,"avatar_url":"https://avatars1.githubusercontent.com/u/4030607?v=3","gravatar_id":"","url":"https://api.github.com/users/adampaulberg","html_url":"https://github.com/adampaulberg","followers_url":"https://api.github.com/users/adampaulberg/followers","following_url":"https://api.github.com/users/adampaulberg/following{/other_user}","gists_url":"https://api.github.com/users/adampaulberg/gists{/gist_id}","starred_url":"https://api.github.com/users/adampaulberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adampaulberg/subscriptions","organizations_url":"https://api.github.com/users/adampaulberg/orgs","repos_url":"https://api.github.com/users/adampaulberg/repos","events_url":"https://api.github.com/users/adampaulberg/events{/privacy}","received_events_url":"https://api.github.com/users/adampaulberg/received_events","type":"User","site_admin":false},"body":"alternatively you can do this without underscore\r\n\r\n```\r\nfor(let task of data.tasks)\r\n```","created_at":"2017-05-03T14:54:11Z","updated_at":"2017-05-03T14:54:11Z","html_url":"https://github.com/fti-technology/ringtail-deploy-web/pull/128#discussion_r114565975","pull_request_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/pulls/128","_links":{"self":{"href":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/pulls/comments/114565975"},"html":{"href":"https://github.com/fti-technology/ringtail-deploy-web/pull/128#discussion_r114565975"},"pull_request":{"href":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/pulls/128"}}},"pull_request":{"url":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/pulls/128","id":118633453,"html_url":"https://github.com/fti-technology/ringtail-deploy-web/pull/128","diff_url":"https://github.com/fti-technology/ringtail-deploy-web/pull/128.diff","patch_url":"https://github.com/fti-technology/ringtail-deploy-web/pull/128.patch","issue_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/issues/128","number":128,"state":"open","locked":false,"title":"T validationworkflow","user":{"login":"jakebrown58","id":382808,"avatar_url":"https://avatars0.githubusercontent.com/u/382808?v=3","gravatar_id":"","url":"https://api.github.com/users/jakebrown58","html_url":"https://github.com/jakebrown58","followers_url":"https://api.github.com/users/jakebrown58/followers","following_url":"https://api.github.com/users/jakebrown58/following{/other_user}","gists_url":"https://api.github.com/users/jakebrown58/gists{/gist_id}","starred_url":"https://api.github.com/users/jakebrown58/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakebrown58/subscriptions","organizations_url":"https://api.github.com/users/jakebrown58/orgs","repos_url":"https://api.github.com/users/jakebrown58/repos","events_url":"https://api.github.com/users/jakebrown58/events{/privacy}","received_events_url":"https://api.github.com/users/jakebrown58/received_events","type":"User","site_admin":false},"body":"Changes the UI for the deployment job submission page to make it into a 2-page wizard with validations.\r\n\r\n","created_at":"2017-05-02T19:56:53Z","updated_at":"2017-05-03T14:54:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ae18dcc13e355274dd2b9507e6bf265b8ba1ed28","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/pulls/128/commits","review_comments_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/pulls/128/comments","review_comment_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/issues/128/comments","statuses_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/statuses/2960807bf4f5ec04717974b0f126f70628d9adce","head":{"label":"fti-technology:t-ValidationWorkflow","ref":"t-ValidationWorkflow","sha":"2960807bf4f5ec04717974b0f126f70628d9adce","user":{"login":"fti-technology","id":10236764,"avatar_url":"https://avatars0.githubusercontent.com/u/10236764?v=3","gravatar_id":"","url":"https://api.github.com/users/fti-technology","html_url":"https://github.com/fti-technology","followers_url":"https://api.github.com/users/fti-technology/followers","following_url":"https://api.github.com/users/fti-technology/following{/other_user}","gists_url":"https://api.github.com/users/fti-technology/gists{/gist_id}","starred_url":"https://api.github.com/users/fti-technology/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fti-technology/subscriptions","organizations_url":"https://api.github.com/users/fti-technology/orgs","repos_url":"https://api.github.com/users/fti-technology/repos","events_url":"https://api.github.com/users/fti-technology/events{/privacy}","received_events_url":"https://api.github.com/users/fti-technology/received_events","type":"Organization","site_admin":false},"repo":{"id":26142605,"name":"ringtail-deploy-web","full_name":"fti-technology/ringtail-deploy-web","owner":{"login":"fti-technology","id":10236764,"avatar_url":"https://avatars0.githubusercontent.com/u/10236764?v=3","gravatar_id":"","url":"https://api.github.com/users/fti-technology","html_url":"https://github.com/fti-technology","followers_url":"https://api.github.com/users/fti-technology/followers","following_url":"https://api.github.com/users/fti-technology/following{/other_user}","gists_url":"https://api.github.com/users/fti-technology/gists{/gist_id}","starred_url":"https://api.github.com/users/fti-technology/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fti-technology/subscriptions","organizations_url":"https://api.github.com/users/fti-technology/orgs","repos_url":"https://api.github.com/users/fti-technology/repos","events_url":"https://api.github.com/users/fti-technology/events{/privacy}","received_events_url":"https://api.github.com/users/fti-technology/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fti-technology/ringtail-deploy-web","description":"Web driven Ringtail deployment utility ","fork":false,"url":"https://api.github.com/repos/fti-technology/ringtail-deploy-web","forks_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/forks","keys_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/teams","hooks_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/hooks","issue_events_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/issues/events{/number}","events_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/events","assignees_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/assignees{/user}","branches_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/branches{/branch}","tags_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/tags","blobs_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/statuses/{sha}","languages_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/languages","stargazers_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/stargazers","contributors_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/contributors","subscribers_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/subscribers","subscription_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/subscription","commits_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/contents/{+path}","compare_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/merges","archive_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/downloads","issues_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/issues{/number}","pulls_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/pulls{/number}","milestones_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/milestones{/number}","notifications_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/labels{/name}","releases_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/releases{/id}","deployments_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/deployments","created_at":"2014-11-03T22:50:06Z","updated_at":"2017-02-09T06:02:01Z","pushed_at":"2017-05-03T13:59:54Z","git_url":"git://github.com/fti-technology/ringtail-deploy-web.git","ssh_url":"git@github.com:fti-technology/ringtail-deploy-web.git","clone_url":"https://github.com/fti-technology/ringtail-deploy-web.git","svn_url":"https://github.com/fti-technology/ringtail-deploy-web","homepage":"","size":2513,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":16,"forks":2,"open_issues":16,"watchers":3,"default_branch":"master"}},"base":{"label":"fti-technology:master","ref":"master","sha":"d4bea19bb0ef9cd8ee1cbdbecd73c9cb93171e3a","user":{"login":"fti-technology","id":10236764,"avatar_url":"https://avatars0.githubusercontent.com/u/10236764?v=3","gravatar_id":"","url":"https://api.github.com/users/fti-technology","html_url":"https://github.com/fti-technology","followers_url":"https://api.github.com/users/fti-technology/followers","following_url":"https://api.github.com/users/fti-technology/following{/other_user}","gists_url":"https://api.github.com/users/fti-technology/gists{/gist_id}","starred_url":"https://api.github.com/users/fti-technology/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fti-technology/subscriptions","organizations_url":"https://api.github.com/users/fti-technology/orgs","repos_url":"https://api.github.com/users/fti-technology/repos","events_url":"https://api.github.com/users/fti-technology/events{/privacy}","received_events_url":"https://api.github.com/users/fti-technology/received_events","type":"Organization","site_admin":false},"repo":{"id":26142605,"name":"ringtail-deploy-web","full_name":"fti-technology/ringtail-deploy-web","owner":{"login":"fti-technology","id":10236764,"avatar_url":"https://avatars0.githubusercontent.com/u/10236764?v=3","gravatar_id":"","url":"https://api.github.com/users/fti-technology","html_url":"https://github.com/fti-technology","followers_url":"https://api.github.com/users/fti-technology/followers","following_url":"https://api.github.com/users/fti-technology/following{/other_user}","gists_url":"https://api.github.com/users/fti-technology/gists{/gist_id}","starred_url":"https://api.github.com/users/fti-technology/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fti-technology/subscriptions","organizations_url":"https://api.github.com/users/fti-technology/orgs","repos_url":"https://api.github.com/users/fti-technology/repos","events_url":"https://api.github.com/users/fti-technology/events{/privacy}","received_events_url":"https://api.github.com/users/fti-technology/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fti-technology/ringtail-deploy-web","description":"Web driven Ringtail deployment utility ","fork":false,"url":"https://api.github.com/repos/fti-technology/ringtail-deploy-web","forks_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/forks","keys_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/teams","hooks_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/hooks","issue_events_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/issues/events{/number}","events_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/events","assignees_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/assignees{/user}","branches_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/branches{/branch}","tags_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/tags","blobs_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/statuses/{sha}","languages_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/languages","stargazers_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/stargazers","contributors_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/contributors","subscribers_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/subscribers","subscription_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/subscription","commits_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/contents/{+path}","compare_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/merges","archive_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/downloads","issues_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/issues{/number}","pulls_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/pulls{/number}","milestones_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/milestones{/number}","notifications_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/labels{/name}","releases_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/releases{/id}","deployments_url":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/deployments","created_at":"2014-11-03T22:50:06Z","updated_at":"2017-02-09T06:02:01Z","pushed_at":"2017-05-03T13:59:54Z","git_url":"git://github.com/fti-technology/ringtail-deploy-web.git","ssh_url":"git@github.com:fti-technology/ringtail-deploy-web.git","clone_url":"https://github.com/fti-technology/ringtail-deploy-web.git","svn_url":"https://github.com/fti-technology/ringtail-deploy-web","homepage":"","size":2513,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":16,"forks":2,"open_issues":16,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/pulls/128"},"html":{"href":"https://github.com/fti-technology/ringtail-deploy-web/pull/128"},"issue":{"href":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/issues/128"},"comments":{"href":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/issues/128/comments"},"review_comments":{"href":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/pulls/128/comments"},"review_comment":{"href":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/pulls/128/commits"},"statuses":{"href":"https://api.github.com/repos/fti-technology/ringtail-deploy-web/statuses/2960807bf4f5ec04717974b0f126f70628d9adce"}}}}
{"actor":{"display_login":"adampaulberg"}}