{"action":"created","issue":{"url":"https://api.github.com/repos/dgraph-io/dgraph/issues/875","repository_url":"https://api.github.com/repos/dgraph-io/dgraph","labels_url":"https://api.github.com/repos/dgraph-io/dgraph/issues/875/labels{/name}","comments_url":"https://api.github.com/repos/dgraph-io/dgraph/issues/875/comments","events_url":"https://api.github.com/repos/dgraph-io/dgraph/issues/875/events","html_url":"https://github.com/dgraph-io/dgraph/pull/875","id":223769440,"number":875,"title":"fix #826","user":{"login":"janardhan1993","id":815780,"avatar_url":"https://avatars0.githubusercontent.com/u/815780?v=3","gravatar_id":"","url":"https://api.github.com/users/janardhan1993","html_url":"https://github.com/janardhan1993","followers_url":"https://api.github.com/users/janardhan1993/followers","following_url":"https://api.github.com/users/janardhan1993/following{/other_user}","gists_url":"https://api.github.com/users/janardhan1993/gists{/gist_id}","starred_url":"https://api.github.com/users/janardhan1993/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janardhan1993/subscriptions","organizations_url":"https://api.github.com/users/janardhan1993/orgs","repos_url":"https://api.github.com/users/janardhan1993/repos","events_url":"https://api.github.com/users/janardhan1993/events{/privacy}","received_events_url":"https://api.github.com/users/janardhan1993/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"manishrjain","id":1782324,"avatar_url":"https://avatars2.githubusercontent.com/u/1782324?v=3","gravatar_id":"","url":"https://api.github.com/users/manishrjain","html_url":"https://github.com/manishrjain","followers_url":"https://api.github.com/users/manishrjain/followers","following_url":"https://api.github.com/users/manishrjain/following{/other_user}","gists_url":"https://api.github.com/users/manishrjain/gists{/gist_id}","starred_url":"https://api.github.com/users/manishrjain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manishrjain/subscriptions","organizations_url":"https://api.github.com/users/manishrjain/orgs","repos_url":"https://api.github.com/users/manishrjain/repos","events_url":"https://api.github.com/users/manishrjain/events{/privacy}","received_events_url":"https://api.github.com/users/manishrjain/received_events","type":"User","site_admin":false},"assignees":[{"login":"manishrjain","id":1782324,"avatar_url":"https://avatars2.githubusercontent.com/u/1782324?v=3","gravatar_id":"","url":"https://api.github.com/users/manishrjain","html_url":"https://github.com/manishrjain","followers_url":"https://api.github.com/users/manishrjain/followers","following_url":"https://api.github.com/users/manishrjain/following{/other_user}","gists_url":"https://api.github.com/users/manishrjain/gists{/gist_id}","starred_url":"https://api.github.com/users/manishrjain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manishrjain/subscriptions","organizations_url":"https://api.github.com/users/manishrjain/orgs","repos_url":"https://api.github.com/users/manishrjain/repos","events_url":"https://api.github.com/users/manishrjain/events{/privacy}","received_events_url":"https://api.github.com/users/manishrjain/received_events","type":"User","site_admin":false},{"login":"ashwin95r","id":5701997,"avatar_url":"https://avatars2.githubusercontent.com/u/5701997?v=3","gravatar_id":"","url":"https://api.github.com/users/ashwin95r","html_url":"https://github.com/ashwin95r","followers_url":"https://api.github.com/users/ashwin95r/followers","following_url":"https://api.github.com/users/ashwin95r/following{/other_user}","gists_url":"https://api.github.com/users/ashwin95r/gists{/gist_id}","starred_url":"https://api.github.com/users/ashwin95r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashwin95r/subscriptions","organizations_url":"https://api.github.com/users/ashwin95r/orgs","repos_url":"https://api.github.com/users/ashwin95r/repos","events_url":"https://api.github.com/users/ashwin95r/events{/privacy}","received_events_url":"https://api.github.com/users/ashwin95r/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2017-04-24T10:13:48Z","updated_at":"2017-04-27T05:29:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dgraph-io/dgraph/pulls/875","html_url":"https://github.com/dgraph-io/dgraph/pull/875","diff_url":"https://github.com/dgraph-io/dgraph/pull/875.diff","patch_url":"https://github.com/dgraph-io/dgraph/pull/875.patch"},"body":"Facet is converted to appropriate type based on stored facet(since we don't have schema for facets and function arguments are string in gql query).\r\n\r\n@facet(tag,\"34\") - used to match only int 34 earlier. Now it will match both int 34 and String 34(based on stored facet).\r\n\r\n<!-- Reviewable:start -->\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/dgraph-io/dgraph/875)\r\n<!-- Reviewable:end -->\r\n"},"comment":{"url":"https://api.github.com/repos/dgraph-io/dgraph/issues/comments/297615699","html_url":"https://github.com/dgraph-io/dgraph/pull/875#issuecomment-297615699","issue_url":"https://api.github.com/repos/dgraph-io/dgraph/issues/875","id":297615699,"user":{"login":"janardhan1993","id":815780,"avatar_url":"https://avatars0.githubusercontent.com/u/815780?v=3","gravatar_id":"","url":"https://api.github.com/users/janardhan1993","html_url":"https://github.com/janardhan1993","followers_url":"https://api.github.com/users/janardhan1993/followers","following_url":"https://api.github.com/users/janardhan1993/following{/other_user}","gists_url":"https://api.github.com/users/janardhan1993/gists{/gist_id}","starred_url":"https://api.github.com/users/janardhan1993/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janardhan1993/subscriptions","organizations_url":"https://api.github.com/users/janardhan1993/orgs","repos_url":"https://api.github.com/users/janardhan1993/repos","events_url":"https://api.github.com/users/janardhan1993/events{/privacy}","received_events_url":"https://api.github.com/users/janardhan1993/received_events","type":"User","site_admin":false},"created_at":"2017-04-27T05:29:11Z","updated_at":"2017-04-27T05:29:11Z","body":"\n\n\n\nReview status: all files reviewed at latest revision, 2 unresolved discussions.\n\n---\n\n*[rdf/parse_test.go, line 663 at r1](https://reviewable.io:443/reviews/dgraph-io/dgraph/875#-KihbfOimv24lLG1_iLd:-KihsWf8Y7NBQHAUbTaB:b-j5j6b4) ([raw file](https://github.com/dgraph-io/dgraph/blob/07480709a68faf5272383cbfdcdbfc7288b3d049/rdf/parse_test.go#L663)):*\n<details><summary><i>Previously, manishrjain (Manish R Jain) wrote…</i></summary><blockquote>\n\nEven the predicate data types would only have one type for dates, i.e. DateTime.\n\n\"2006-11\" == \"2006-11-24T02:09:03\".\n</blockquote></details>\n\nWill Do in separate PR\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/dgraph-io/dgraph/875)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"janardhan1993"}}