{"action":"created","comment":{"url":"https://api.github.com/repos/google/ExoPlayer/pulls/comments/126142499","pull_request_review_id":48600916,"id":126142499,"diff_hunk":"@@ -201,13 +203,13 @@ AVCodec *getCodecByName(JNIEnv* env, jstring codecName) {\n }\n \n AVCodecContext *createContext(JNIEnv *env, AVCodec *codec,\n-                              jbyteArray extraData) {\n+                              jbyteArray extraData, jboolean use32BitFloatOutput) {\n   AVCodecContext *context = avcodec_alloc_context3(codec);\n   if (!context) {\n     LOGE(\"Failed to allocate context.\");\n     return NULL;\n   }\n-  context->request_sample_fmt = OUTPUT_FORMAT;\n+  context->request_sample_fmt = use32BitFloatOutput ? OUTPUT_FORMAT_32FLOAT : OUTPUT_FORMAT;","path":"extensions/ffmpeg/src/main/jni/ffmpeg_jni.cc","position":86,"original_position":86,"commit_id":"dd45c414ff753cc4ab5f88a266b03d7aa63dc551","original_commit_id":"dd45c414ff753cc4ab5f88a266b03d7aa63dc551","user":{"login":"drhill","id":878790,"avatar_url":"https://avatars2.githubusercontent.com/u/878790?v=3","gravatar_id":"","url":"https://api.github.com/users/drhill","html_url":"https://github.com/drhill","followers_url":"https://api.github.com/users/drhill/followers","following_url":"https://api.github.com/users/drhill/following{/other_user}","gists_url":"https://api.github.com/users/drhill/gists{/gist_id}","starred_url":"https://api.github.com/users/drhill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drhill/subscriptions","organizations_url":"https://api.github.com/users/drhill/orgs","repos_url":"https://api.github.com/users/drhill/repos","events_url":"https://api.github.com/users/drhill/events{/privacy}","received_events_url":"https://api.github.com/users/drhill/received_events","type":"User","site_admin":false},"body":"Will look into it.","created_at":"2017-07-07T13:11:06Z","updated_at":"2017-07-07T13:11:07Z","html_url":"https://github.com/google/ExoPlayer/pull/2517#discussion_r126142499","pull_request_url":"https://api.github.com/repos/google/ExoPlayer/pulls/2517","_links":{"self":{"href":"https://api.github.com/repos/google/ExoPlayer/pulls/comments/126142499"},"html":{"href":"https://github.com/google/ExoPlayer/pull/2517#discussion_r126142499"},"pull_request":{"href":"https://api.github.com/repos/google/ExoPlayer/pulls/2517"}}},"pull_request":{"url":"https://api.github.com/repos/google/ExoPlayer/pulls/2517","id":108434356,"html_url":"https://github.com/google/ExoPlayer/pull/2517","diff_url":"https://github.com/google/ExoPlayer/pull/2517.diff","patch_url":"https://github.com/google/ExoPlayer/pull/2517.patch","issue_url":"https://api.github.com/repos/google/ExoPlayer/issues/2517","number":2517,"state":"open","locked":false,"title":"Dev v2 pcm float","user":{"login":"drhill","id":878790,"avatar_url":"https://avatars2.githubusercontent.com/u/878790?v=3","gravatar_id":"","url":"https://api.github.com/users/drhill","html_url":"https://github.com/drhill","followers_url":"https://api.github.com/users/drhill/followers","following_url":"https://api.github.com/users/drhill/following{/other_user}","gists_url":"https://api.github.com/users/drhill/gists{/gist_id}","starred_url":"https://api.github.com/users/drhill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drhill/subscriptions","organizations_url":"https://api.github.com/users/drhill/orgs","repos_url":"https://api.github.com/users/drhill/repos","events_url":"https://api.github.com/users/drhill/events{/privacy}","received_events_url":"https://api.github.com/users/drhill/received_events","type":"User","site_admin":false},"body":"As of the latest release of the Shield TV now supports outputting PCM 32 bit float for multi channel audio (prior versions only supported 2 channels no matter how many channels were passed).  The Resampling buffer was updated to convert 24bit audio to 32bit float.  Also, the ffmpeg extension was updated to output 32bit float when supported as well.  Might as well convert any >16bit audio streams to 32 bit instead of dithering.","created_at":"2017-02-28T23:20:55Z","updated_at":"2017-07-07T13:11:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"28829f0a2f82c338b78c4c7b51be1dfbfd0259ba","assignee":{"login":"andrewlewis","id":107897,"avatar_url":"https://avatars0.githubusercontent.com/u/107897?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewlewis","html_url":"https://github.com/andrewlewis","followers_url":"https://api.github.com/users/andrewlewis/followers","following_url":"https://api.github.com/users/andrewlewis/following{/other_user}","gists_url":"https://api.github.com/users/andrewlewis/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewlewis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewlewis/subscriptions","organizations_url":"https://api.github.com/users/andrewlewis/orgs","repos_url":"https://api.github.com/users/andrewlewis/repos","events_url":"https://api.github.com/users/andrewlewis/events{/privacy}","received_events_url":"https://api.github.com/users/andrewlewis/received_events","type":"User","site_admin":false},"assignees":[{"login":"andrewlewis","id":107897,"avatar_url":"https://avatars0.githubusercontent.com/u/107897?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewlewis","html_url":"https://github.com/andrewlewis","followers_url":"https://api.github.com/users/andrewlewis/followers","following_url":"https://api.github.com/users/andrewlewis/following{/other_user}","gists_url":"https://api.github.com/users/andrewlewis/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewlewis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewlewis/subscriptions","organizations_url":"https://api.github.com/users/andrewlewis/orgs","repos_url":"https://api.github.com/users/andrewlewis/repos","events_url":"https://api.github.com/users/andrewlewis/events{/privacy}","received_events_url":"https://api.github.com/users/andrewlewis/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/google/ExoPlayer/pulls/2517/commits","review_comments_url":"https://api.github.com/repos/google/ExoPlayer/pulls/2517/comments","review_comment_url":"https://api.github.com/repos/google/ExoPlayer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/ExoPlayer/issues/2517/comments","statuses_url":"https://api.github.com/repos/google/ExoPlayer/statuses/dd45c414ff753cc4ab5f88a266b03d7aa63dc551","head":{"label":"drhill:dev-v2_pcm_float","ref":"dev-v2_pcm_float","sha":"dd45c414ff753cc4ab5f88a266b03d7aa63dc551","user":{"login":"drhill","id":878790,"avatar_url":"https://avatars2.githubusercontent.com/u/878790?v=3","gravatar_id":"","url":"https://api.github.com/users/drhill","html_url":"https://github.com/drhill","followers_url":"https://api.github.com/users/drhill/followers","following_url":"https://api.github.com/users/drhill/following{/other_user}","gists_url":"https://api.github.com/users/drhill/gists{/gist_id}","starred_url":"https://api.github.com/users/drhill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drhill/subscriptions","organizations_url":"https://api.github.com/users/drhill/orgs","repos_url":"https://api.github.com/users/drhill/repos","events_url":"https://api.github.com/users/drhill/events{/privacy}","received_events_url":"https://api.github.com/users/drhill/received_events","type":"User","site_admin":false},"repo":{"id":56719378,"name":"ExoPlayer","full_name":"drhill/ExoPlayer","owner":{"login":"drhill","id":878790,"avatar_url":"https://avatars2.githubusercontent.com/u/878790?v=3","gravatar_id":"","url":"https://api.github.com/users/drhill","html_url":"https://github.com/drhill","followers_url":"https://api.github.com/users/drhill/followers","following_url":"https://api.github.com/users/drhill/following{/other_user}","gists_url":"https://api.github.com/users/drhill/gists{/gist_id}","starred_url":"https://api.github.com/users/drhill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drhill/subscriptions","organizations_url":"https://api.github.com/users/drhill/orgs","repos_url":"https://api.github.com/users/drhill/repos","events_url":"https://api.github.com/users/drhill/events{/privacy}","received_events_url":"https://api.github.com/users/drhill/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/drhill/ExoPlayer","description":"An extensible media player for Android","fork":true,"url":"https://api.github.com/repos/drhill/ExoPlayer","forks_url":"https://api.github.com/repos/drhill/ExoPlayer/forks","keys_url":"https://api.github.com/repos/drhill/ExoPlayer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/drhill/ExoPlayer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/drhill/ExoPlayer/teams","hooks_url":"https://api.github.com/repos/drhill/ExoPlayer/hooks","issue_events_url":"https://api.github.com/repos/drhill/ExoPlayer/issues/events{/number}","events_url":"https://api.github.com/repos/drhill/ExoPlayer/events","assignees_url":"https://api.github.com/repos/drhill/ExoPlayer/assignees{/user}","branches_url":"https://api.github.com/repos/drhill/ExoPlayer/branches{/branch}","tags_url":"https://api.github.com/repos/drhill/ExoPlayer/tags","blobs_url":"https://api.github.com/repos/drhill/ExoPlayer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/drhill/ExoPlayer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/drhill/ExoPlayer/git/refs{/sha}","trees_url":"https://api.github.com/repos/drhill/ExoPlayer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/drhill/ExoPlayer/statuses/{sha}","languages_url":"https://api.github.com/repos/drhill/ExoPlayer/languages","stargazers_url":"https://api.github.com/repos/drhill/ExoPlayer/stargazers","contributors_url":"https://api.github.com/repos/drhill/ExoPlayer/contributors","subscribers_url":"https://api.github.com/repos/drhill/ExoPlayer/subscribers","subscription_url":"https://api.github.com/repos/drhill/ExoPlayer/subscription","commits_url":"https://api.github.com/repos/drhill/ExoPlayer/commits{/sha}","git_commits_url":"https://api.github.com/repos/drhill/ExoPlayer/git/commits{/sha}","comments_url":"https://api.github.com/repos/drhill/ExoPlayer/comments{/number}","issue_comment_url":"https://api.github.com/repos/drhill/ExoPlayer/issues/comments{/number}","contents_url":"https://api.github.com/repos/drhill/ExoPlayer/contents/{+path}","compare_url":"https://api.github.com/repos/drhill/ExoPlayer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/drhill/ExoPlayer/merges","archive_url":"https://api.github.com/repos/drhill/ExoPlayer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/drhill/ExoPlayer/downloads","issues_url":"https://api.github.com/repos/drhill/ExoPlayer/issues{/number}","pulls_url":"https://api.github.com/repos/drhill/ExoPlayer/pulls{/number}","milestones_url":"https://api.github.com/repos/drhill/ExoPlayer/milestones{/number}","notifications_url":"https://api.github.com/repos/drhill/ExoPlayer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/drhill/ExoPlayer/labels{/name}","releases_url":"https://api.github.com/repos/drhill/ExoPlayer/releases{/id}","deployments_url":"https://api.github.com/repos/drhill/ExoPlayer/deployments","created_at":"2016-04-20T20:39:37Z","updated_at":"2016-04-20T20:39:39Z","pushed_at":"2017-06-22T01:11:41Z","git_url":"git://github.com/drhill/ExoPlayer.git","ssh_url":"git@github.com:drhill/ExoPlayer.git","clone_url":"https://github.com/drhill/ExoPlayer.git","svn_url":"https://github.com/drhill/ExoPlayer","homepage":"","size":23696,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev-v2"}},"base":{"label":"google:dev-v2","ref":"dev-v2","sha":"8af77acb01edbcc7fe7005d44a0146e25c6695eb","user":{"login":"google","id":1342004,"avatar_url":"https://avatars2.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":20818126,"name":"ExoPlayer","full_name":"google/ExoPlayer","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars2.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/ExoPlayer","description":"An extensible media player for Android","fork":false,"url":"https://api.github.com/repos/google/ExoPlayer","forks_url":"https://api.github.com/repos/google/ExoPlayer/forks","keys_url":"https://api.github.com/repos/google/ExoPlayer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/ExoPlayer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/ExoPlayer/teams","hooks_url":"https://api.github.com/repos/google/ExoPlayer/hooks","issue_events_url":"https://api.github.com/repos/google/ExoPlayer/issues/events{/number}","events_url":"https://api.github.com/repos/google/ExoPlayer/events","assignees_url":"https://api.github.com/repos/google/ExoPlayer/assignees{/user}","branches_url":"https://api.github.com/repos/google/ExoPlayer/branches{/branch}","tags_url":"https://api.github.com/repos/google/ExoPlayer/tags","blobs_url":"https://api.github.com/repos/google/ExoPlayer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/ExoPlayer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/ExoPlayer/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/ExoPlayer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/ExoPlayer/statuses/{sha}","languages_url":"https://api.github.com/repos/google/ExoPlayer/languages","stargazers_url":"https://api.github.com/repos/google/ExoPlayer/stargazers","contributors_url":"https://api.github.com/repos/google/ExoPlayer/contributors","subscribers_url":"https://api.github.com/repos/google/ExoPlayer/subscribers","subscription_url":"https://api.github.com/repos/google/ExoPlayer/subscription","commits_url":"https://api.github.com/repos/google/ExoPlayer/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/ExoPlayer/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/ExoPlayer/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/ExoPlayer/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/ExoPlayer/contents/{+path}","compare_url":"https://api.github.com/repos/google/ExoPlayer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/ExoPlayer/merges","archive_url":"https://api.github.com/repos/google/ExoPlayer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/ExoPlayer/downloads","issues_url":"https://api.github.com/repos/google/ExoPlayer/issues{/number}","pulls_url":"https://api.github.com/repos/google/ExoPlayer/pulls{/number}","milestones_url":"https://api.github.com/repos/google/ExoPlayer/milestones{/number}","notifications_url":"https://api.github.com/repos/google/ExoPlayer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/ExoPlayer/labels{/name}","releases_url":"https://api.github.com/repos/google/ExoPlayer/releases{/id}","deployments_url":"https://api.github.com/repos/google/ExoPlayer/deployments","created_at":"2014-06-13T21:19:18Z","updated_at":"2017-07-07T11:19:17Z","pushed_at":"2017-07-07T05:10:33Z","git_url":"git://github.com/google/ExoPlayer.git","ssh_url":"git@github.com:google/ExoPlayer.git","clone_url":"https://github.com/google/ExoPlayer.git","svn_url":"https://github.com/google/ExoPlayer","homepage":"","size":47023,"stargazers_count":7196,"watchers_count":7196,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":2428,"mirror_url":null,"open_issues_count":202,"forks":2428,"open_issues":202,"watchers":7196,"default_branch":"release-v2"}},"_links":{"self":{"href":"https://api.github.com/repos/google/ExoPlayer/pulls/2517"},"html":{"href":"https://github.com/google/ExoPlayer/pull/2517"},"issue":{"href":"https://api.github.com/repos/google/ExoPlayer/issues/2517"},"comments":{"href":"https://api.github.com/repos/google/ExoPlayer/issues/2517/comments"},"review_comments":{"href":"https://api.github.com/repos/google/ExoPlayer/pulls/2517/comments"},"review_comment":{"href":"https://api.github.com/repos/google/ExoPlayer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/ExoPlayer/pulls/2517/commits"},"statuses":{"href":"https://api.github.com/repos/google/ExoPlayer/statuses/dd45c414ff753cc4ab5f88a266b03d7aa63dc551"}}}}
{"actor":{"display_login":"drhill"}}