{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues/763","repository_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog","labels_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues/763/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues/763/comments","events_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues/763/events","html_url":"https://github.com/kubernetes-incubator/service-catalog/issues/763","id":224846026,"number":763,"title":"Testing: helper methods shouldn't fail tests directly","user":{"login":"krancour","id":1821014,"avatar_url":"https://avatars1.githubusercontent.com/u/1821014?v=3","gravatar_id":"","url":"https://api.github.com/users/krancour","html_url":"https://github.com/krancour","followers_url":"https://api.github.com/users/krancour/followers","following_url":"https://api.github.com/users/krancour/following{/other_user}","gists_url":"https://api.github.com/users/krancour/gists{/gist_id}","starred_url":"https://api.github.com/users/krancour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krancour/subscriptions","organizations_url":"https://api.github.com/users/krancour/orgs","repos_url":"https://api.github.com/users/krancour/repos","events_url":"https://api.github.com/users/krancour/events{/privacy}","received_events_url":"https://api.github.com/users/krancour/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-04-27T16:44:37Z","updated_at":"2017-07-10T00:48:52Z","closed_at":null,"body":"There are numerous places where we use test \"helper\" functions that directly fail tests (e.g. `t.Fatalf(...)` when an assertion fails. This produces error reports where the source of such failures appears to be the helper function-- which is not the _real_ source of the failure. This necessitates careful reading of the resulting stack trace where it could, possibly, be avoided otherwise.\r\n\r\nTo whatever extent is possible, we should seek to identify and remediate any places in test code where this is occurring."},"comment":{"url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues/comments/313977007","html_url":"https://github.com/kubernetes-incubator/service-catalog/issues/763#issuecomment-313977007","issue_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues/763","id":313977007,"user":{"login":"duglin","id":1944671,"avatar_url":"https://avatars2.githubusercontent.com/u/1944671?v=3","gravatar_id":"","url":"https://api.github.com/users/duglin","html_url":"https://github.com/duglin","followers_url":"https://api.github.com/users/duglin/followers","following_url":"https://api.github.com/users/duglin/following{/other_user}","gists_url":"https://api.github.com/users/duglin/gists{/gist_id}","starred_url":"https://api.github.com/users/duglin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duglin/subscriptions","organizations_url":"https://api.github.com/users/duglin/orgs","repos_url":"https://api.github.com/users/duglin/repos","events_url":"https://api.github.com/users/duglin/events{/privacy}","received_events_url":"https://api.github.com/users/duglin/received_events","type":"User","site_admin":false},"created_at":"2017-07-10T00:48:52Z","updated_at":"2017-07-10T00:48:52Z","body":"if we have control over the helper functions then it seems like we should be able to have that code walk back up the stack a few steps and print the non-helper-func's src/line-num. "}}
{"actor":{"display_login":"duglin"}}