{"action":"created","issue":{"url":"https://api.github.com/repos/junit-team/junit5/issues/945","repository_url":"https://api.github.com/repos/junit-team/junit5","labels_url":"https://api.github.com/repos/junit-team/junit5/issues/945/labels{/name}","comments_url":"https://api.github.com/repos/junit-team/junit5/issues/945/comments","events_url":"https://api.github.com/repos/junit-team/junit5/issues/945/events","html_url":"https://github.com/junit-team/junit5/pull/945","id":242920505,"number":945,"title":"Make UniqueId segment list immutable","user":{"login":"sormuras","id":2319838,"avatar_url":"https://avatars5.githubusercontent.com/u/2319838?v=4","gravatar_id":"","url":"https://api.github.com/users/sormuras","html_url":"https://github.com/sormuras","followers_url":"https://api.github.com/users/sormuras/followers","following_url":"https://api.github.com/users/sormuras/following{/other_user}","gists_url":"https://api.github.com/users/sormuras/gists{/gist_id}","starred_url":"https://api.github.com/users/sormuras/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sormuras/subscriptions","organizations_url":"https://api.github.com/users/sormuras/orgs","repos_url":"https://api.github.com/users/sormuras/repos","events_url":"https://api.github.com/users/sormuras/events{/privacy}","received_events_url":"https://api.github.com/users/sormuras/received_events","type":"User","site_admin":false},"labels":[{"id":294412858,"url":"https://api.github.com/repos/junit-team/junit5/labels/status:%20in%20progress","name":"status: in progress","color":"ffbb00","default":false}],"state":"open","locked":false,"assignee":{"login":"sormuras","id":2319838,"avatar_url":"https://avatars5.githubusercontent.com/u/2319838?v=4","gravatar_id":"","url":"https://api.github.com/users/sormuras","html_url":"https://github.com/sormuras","followers_url":"https://api.github.com/users/sormuras/followers","following_url":"https://api.github.com/users/sormuras/following{/other_user}","gists_url":"https://api.github.com/users/sormuras/gists{/gist_id}","starred_url":"https://api.github.com/users/sormuras/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sormuras/subscriptions","organizations_url":"https://api.github.com/users/sormuras/orgs","repos_url":"https://api.github.com/users/sormuras/repos","events_url":"https://api.github.com/users/sormuras/events{/privacy}","received_events_url":"https://api.github.com/users/sormuras/received_events","type":"User","site_admin":false},"assignees":[{"login":"sormuras","id":2319838,"avatar_url":"https://avatars5.githubusercontent.com/u/2319838?v=4","gravatar_id":"","url":"https://api.github.com/users/sormuras","html_url":"https://github.com/sormuras","followers_url":"https://api.github.com/users/sormuras/followers","following_url":"https://api.github.com/users/sormuras/following{/other_user}","gists_url":"https://api.github.com/users/sormuras/gists{/gist_id}","starred_url":"https://api.github.com/users/sormuras/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sormuras/subscriptions","organizations_url":"https://api.github.com/users/sormuras/orgs","repos_url":"https://api.github.com/users/sormuras/repos","events_url":"https://api.github.com/users/sormuras/events{/privacy}","received_events_url":"https://api.github.com/users/sormuras/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/junit-team/junit5/milestones/11","html_url":"https://github.com/junit-team/junit5/milestone/11","labels_url":"https://api.github.com/repos/junit-team/junit5/milestones/11/labels","id":2502118,"number":11,"title":"5.0 M6","description":"Themes: Java 9 compatibility, additional extension APIs for JUnit Jupiter","creator":{"login":"marcphilipp","id":214207,"avatar_url":"https://avatars2.githubusercontent.com/u/214207?v=4","gravatar_id":"","url":"https://api.github.com/users/marcphilipp","html_url":"https://github.com/marcphilipp","followers_url":"https://api.github.com/users/marcphilipp/followers","following_url":"https://api.github.com/users/marcphilipp/following{/other_user}","gists_url":"https://api.github.com/users/marcphilipp/gists{/gist_id}","starred_url":"https://api.github.com/users/marcphilipp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcphilipp/subscriptions","organizations_url":"https://api.github.com/users/marcphilipp/orgs","repos_url":"https://api.github.com/users/marcphilipp/repos","events_url":"https://api.github.com/users/marcphilipp/events{/privacy}","received_events_url":"https://api.github.com/users/marcphilipp/received_events","type":"User","site_admin":false},"open_issues":30,"closed_issues":21,"state":"open","created_at":"2017-05-05T10:52:42Z","updated_at":"2017-07-14T09:50:16Z","due_on":"2017-07-16T07:00:00Z","closed_at":null},"comments":0,"created_at":"2017-07-14T07:35:22Z","updated_at":"2017-07-14T10:04:21Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/junit-team/junit5/pulls/945","html_url":"https://github.com/junit-team/junit5/pull/945","diff_url":"https://github.com/junit-team/junit5/pull/945.diff","patch_url":"https://github.com/junit-team/junit5/pull/945.patch"},"body":"## Overview\r\n\r\nMake UniqueId segment list immutable and turn `getSegments()` into a simple getter, i.e. it does no longer create a copy of the internal list on each invocation. The single place where a modifiable list was expected was in `JavaElementsResolver`. There a copy is created explicitly.\r\n\r\nThis commit also removes the defensive copy creation of the segment list from the package-private constructor. All two internal callers do not modify the underlying list, they actually drop their list reference.\r\n\r\n---\r\n\r\nI hereby agree to the terms of the JUnit Contributor License Agreement.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/junit-team/junit5/issues/comments/315322706","html_url":"https://github.com/junit-team/junit5/pull/945#issuecomment-315322706","issue_url":"https://api.github.com/repos/junit-team/junit5/issues/945","id":315322706,"user":{"login":"sbrannen","id":104798,"avatar_url":"https://avatars0.githubusercontent.com/u/104798?v=4","gravatar_id":"","url":"https://api.github.com/users/sbrannen","html_url":"https://github.com/sbrannen","followers_url":"https://api.github.com/users/sbrannen/followers","following_url":"https://api.github.com/users/sbrannen/following{/other_user}","gists_url":"https://api.github.com/users/sbrannen/gists{/gist_id}","starred_url":"https://api.github.com/users/sbrannen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbrannen/subscriptions","organizations_url":"https://api.github.com/users/sbrannen/orgs","repos_url":"https://api.github.com/users/sbrannen/repos","events_url":"https://api.github.com/users/sbrannen/events{/privacy}","received_events_url":"https://api.github.com/users/sbrannen/received_events","type":"User","site_admin":false},"created_at":"2017-07-14T10:04:21Z","updated_at":"2017-07-14T10:04:21Z","body":"I made some recommendations for two minor changes in wording, but it otherwise LGTM."}}
{"actor":{"display_login":"sbrannen"}}