{"action":"closed","number":4507,"pull_request":{"url":"https://api.github.com/repos/aspnet/Docs/pulls/4507","id":145055802,"html_url":"https://github.com/aspnet/Docs/pull/4507","diff_url":"https://github.com/aspnet/Docs/pull/4507.diff","patch_url":"https://github.com/aspnet/Docs/pull/4507.patch","issue_url":"https://api.github.com/repos/aspnet/Docs/issues/4507","number":4507,"state":"closed","locked":false,"title":"Add BuildBundlerMinifier to drop the Target","user":{"login":"guardrex","id":1622880,"avatar_url":"https://avatars1.githubusercontent.com/u/1622880?v=4","gravatar_id":"","url":"https://api.github.com/users/guardrex","html_url":"https://github.com/guardrex","followers_url":"https://api.github.com/users/guardrex/followers","following_url":"https://api.github.com/users/guardrex/following{/other_user}","gists_url":"https://api.github.com/users/guardrex/gists{/gist_id}","starred_url":"https://api.github.com/users/guardrex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardrex/subscriptions","organizations_url":"https://api.github.com/users/guardrex/orgs","repos_url":"https://api.github.com/users/guardrex/repos","events_url":"https://api.github.com/users/guardrex/events{/privacy}","received_events_url":"https://api.github.com/users/guardrex/received_events","type":"User","site_admin":false},"body":"Due to being an old skool Gulp dude, I wasn't aware that the light-up feature for `BundlerMinifier.Core` with `dotnet build` is to include the `BuildBundlerMinifier` package. This composes the project file better.\r\n\r\n@Rick-Anderson @scottaddie In my spare time (i.e., not working on contract items), I'd like to run thru existing 2.0 samps and make sure that the ones with Bower and BundlerMinifier configuration (*bower.json*, *bundleconfig.json*) have the right bits to work properly x-tooling if that's ok with you. I'd propose to look at it this weekend, since some of the samples are broken for these features when not using VS, especially if you consider that the *.gitignore* locks out *lib* folders from samples.\r\n\r\n[EDIT] ... and I'm a bit concerned that topics/samples don't call out the prereqs for the Bower install command to work. This PR includes a line that should cover it.","created_at":"2017-10-06T01:27:51Z","updated_at":"2017-10-06T14:59:14Z","closed_at":"2017-10-06T14:59:14Z","merged_at":"2017-10-06T14:59:14Z","merge_commit_sha":"aa09a515668ac6512eb228432e1a972c0180591d","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/Docs/pulls/4507/commits","review_comments_url":"https://api.github.com/repos/aspnet/Docs/pulls/4507/comments","review_comment_url":"https://api.github.com/repos/aspnet/Docs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aspnet/Docs/issues/4507/comments","statuses_url":"https://api.github.com/repos/aspnet/Docs/statuses/9eb4e4f89b71704135a35a9b958dafbc992977f2","head":{"label":"guardrex:patch-1","ref":"patch-1","sha":"9eb4e4f89b71704135a35a9b958dafbc992977f2","user":{"login":"guardrex","id":1622880,"avatar_url":"https://avatars1.githubusercontent.com/u/1622880?v=4","gravatar_id":"","url":"https://api.github.com/users/guardrex","html_url":"https://github.com/guardrex","followers_url":"https://api.github.com/users/guardrex/followers","following_url":"https://api.github.com/users/guardrex/following{/other_user}","gists_url":"https://api.github.com/users/guardrex/gists{/gist_id}","starred_url":"https://api.github.com/users/guardrex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardrex/subscriptions","organizations_url":"https://api.github.com/users/guardrex/orgs","repos_url":"https://api.github.com/users/guardrex/repos","events_url":"https://api.github.com/users/guardrex/events{/privacy}","received_events_url":"https://api.github.com/users/guardrex/received_events","type":"User","site_admin":false},"repo":{"id":75414093,"name":"Docs","full_name":"guardrex/Docs","owner":{"login":"guardrex","id":1622880,"avatar_url":"https://avatars1.githubusercontent.com/u/1622880?v=4","gravatar_id":"","url":"https://api.github.com/users/guardrex","html_url":"https://github.com/guardrex","followers_url":"https://api.github.com/users/guardrex/followers","following_url":"https://api.github.com/users/guardrex/following{/other_user}","gists_url":"https://api.github.com/users/guardrex/gists{/gist_id}","starred_url":"https://api.github.com/users/guardrex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardrex/subscriptions","organizations_url":"https://api.github.com/users/guardrex/orgs","repos_url":"https://api.github.com/users/guardrex/repos","events_url":"https://api.github.com/users/guardrex/events{/privacy}","received_events_url":"https://api.github.com/users/guardrex/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/guardrex/Docs","description":"Documentation for ASP.NET Core","fork":true,"url":"https://api.github.com/repos/guardrex/Docs","forks_url":"https://api.github.com/repos/guardrex/Docs/forks","keys_url":"https://api.github.com/repos/guardrex/Docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardrex/Docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardrex/Docs/teams","hooks_url":"https://api.github.com/repos/guardrex/Docs/hooks","issue_events_url":"https://api.github.com/repos/guardrex/Docs/issues/events{/number}","events_url":"https://api.github.com/repos/guardrex/Docs/events","assignees_url":"https://api.github.com/repos/guardrex/Docs/assignees{/user}","branches_url":"https://api.github.com/repos/guardrex/Docs/branches{/branch}","tags_url":"https://api.github.com/repos/guardrex/Docs/tags","blobs_url":"https://api.github.com/repos/guardrex/Docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardrex/Docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardrex/Docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardrex/Docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardrex/Docs/statuses/{sha}","languages_url":"https://api.github.com/repos/guardrex/Docs/languages","stargazers_url":"https://api.github.com/repos/guardrex/Docs/stargazers","contributors_url":"https://api.github.com/repos/guardrex/Docs/contributors","subscribers_url":"https://api.github.com/repos/guardrex/Docs/subscribers","subscription_url":"https://api.github.com/repos/guardrex/Docs/subscription","commits_url":"https://api.github.com/repos/guardrex/Docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardrex/Docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardrex/Docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardrex/Docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardrex/Docs/contents/{+path}","compare_url":"https://api.github.com/repos/guardrex/Docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardrex/Docs/merges","archive_url":"https://api.github.com/repos/guardrex/Docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardrex/Docs/downloads","issues_url":"https://api.github.com/repos/guardrex/Docs/issues{/number}","pulls_url":"https://api.github.com/repos/guardrex/Docs/pulls{/number}","milestones_url":"https://api.github.com/repos/guardrex/Docs/milestones{/number}","notifications_url":"https://api.github.com/repos/guardrex/Docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardrex/Docs/labels{/name}","releases_url":"https://api.github.com/repos/guardrex/Docs/releases{/id}","deployments_url":"https://api.github.com/repos/guardrex/Docs/deployments","created_at":"2016-12-02T16:53:23Z","updated_at":"2016-12-02T16:53:28Z","pushed_at":"2017-10-06T01:40:06Z","git_url":"git://github.com/guardrex/Docs.git","ssh_url":"git@github.com:guardrex/Docs.git","clone_url":"https://github.com/guardrex/Docs.git","svn_url":"https://github.com/guardrex/Docs","homepage":"https://docs.microsoft.com/aspnet","size":578391,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"aspnet:master","ref":"master","sha":"b27f084e6e4c30a4184718aef4a082d92ec7b505","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":28239455,"name":"Docs","full_name":"aspnet/Docs","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/Docs","description":"Documentation for ASP.NET and ASP.NET Core","fork":false,"url":"https://api.github.com/repos/aspnet/Docs","forks_url":"https://api.github.com/repos/aspnet/Docs/forks","keys_url":"https://api.github.com/repos/aspnet/Docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Docs/teams","hooks_url":"https://api.github.com/repos/aspnet/Docs/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Docs/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Docs/events","assignees_url":"https://api.github.com/repos/aspnet/Docs/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Docs/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Docs/tags","blobs_url":"https://api.github.com/repos/aspnet/Docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Docs/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Docs/languages","stargazers_url":"https://api.github.com/repos/aspnet/Docs/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Docs/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Docs/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Docs/subscription","commits_url":"https://api.github.com/repos/aspnet/Docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/Docs/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Docs/merges","archive_url":"https://api.github.com/repos/aspnet/Docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Docs/downloads","issues_url":"https://api.github.com/repos/aspnet/Docs/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Docs/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Docs/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Docs/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Docs/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/Docs/deployments","created_at":"2014-12-19T17:38:02Z","updated_at":"2017-10-06T12:53:31Z","pushed_at":"2017-10-06T14:59:14Z","git_url":"git://github.com/aspnet/Docs.git","ssh_url":"git@github.com:aspnet/Docs.git","clone_url":"https://github.com/aspnet/Docs.git","svn_url":"https://github.com/aspnet/Docs","homepage":"https://docs.microsoft.com/aspnet","size":583814,"stargazers_count":1703,"watchers_count":1703,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4162,"mirror_url":null,"open_issues_count":207,"forks":4162,"open_issues":207,"watchers":1703,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/Docs/pulls/4507"},"html":{"href":"https://github.com/aspnet/Docs/pull/4507"},"issue":{"href":"https://api.github.com/repos/aspnet/Docs/issues/4507"},"comments":{"href":"https://api.github.com/repos/aspnet/Docs/issues/4507/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/Docs/pulls/4507/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/Docs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aspnet/Docs/pulls/4507/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/Docs/statuses/9eb4e4f89b71704135a35a9b958dafbc992977f2"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"scottaddie","id":10702007,"avatar_url":"https://avatars3.githubusercontent.com/u/10702007?v=4","gravatar_id":"","url":"https://api.github.com/users/scottaddie","html_url":"https://github.com/scottaddie","followers_url":"https://api.github.com/users/scottaddie/followers","following_url":"https://api.github.com/users/scottaddie/following{/other_user}","gists_url":"https://api.github.com/users/scottaddie/gists{/gist_id}","starred_url":"https://api.github.com/users/scottaddie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scottaddie/subscriptions","organizations_url":"https://api.github.com/users/scottaddie/orgs","repos_url":"https://api.github.com/users/scottaddie/repos","events_url":"https://api.github.com/users/scottaddie/events{/privacy}","received_events_url":"https://api.github.com/users/scottaddie/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":2,"deletions":4,"changed_files":1}}
{"actor":{"display_login":"scottaddie"}}