{"action":"closed","number":572,"pull_request":{"url":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS/pulls/572","id":111435742,"html_url":"https://github.com/NYPL-Simplified/Simplified-iOS/pull/572","diff_url":"https://github.com/NYPL-Simplified/Simplified-iOS/pull/572.diff","patch_url":"https://github.com/NYPL-Simplified/Simplified-iOS/pull/572.patch","issue_url":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS/issues/572","number":572,"state":"closed","locked":false,"title":"Make CocoaPods not warn about .xcconfig files","user":{"login":"winniequinn","id":10768108,"avatar_url":"https://avatars3.githubusercontent.com/u/10768108?v=3","gravatar_id":"","url":"https://api.github.com/users/winniequinn","html_url":"https://github.com/winniequinn","followers_url":"https://api.github.com/users/winniequinn/followers","following_url":"https://api.github.com/users/winniequinn/following{/other_user}","gists_url":"https://api.github.com/users/winniequinn/gists{/gist_id}","starred_url":"https://api.github.com/users/winniequinn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/winniequinn/subscriptions","organizations_url":"https://api.github.com/users/winniequinn/orgs","repos_url":"https://api.github.com/users/winniequinn/repos","events_url":"https://api.github.com/users/winniequinn/events{/privacy}","received_events_url":"https://api.github.com/users/winniequinn/received_events","type":"User","site_admin":false},"body":"Prior to this commit, we had four `*.xcconfig` files:\r\n\r\n* `Simplified.debug.xcconfig`, which just included `Simplified.xcconfig` and `Simplified+RMSDK.xcconfig`;\r\n\r\n* `Simplified.release.xcconfig`, which was identical to `Simplified.debug.xcconfig`;\r\n\r\n* `Simplified.xcconfig`, which contained the bulk of the project configuration;\r\n\r\n* `Simplified+RMSDK.xcconfig`, which included headers for DRM-related libraries and set `FEATURE_DRM_CONNECTOR=1`.\r\n\r\nThe project was set to use the `Simplified.debug.xcconfig` and `Simplified.release.xcconfig` configurations for debug and release respectfully. The SimplyE target _within_ debug and release was set to use `Simplified+RMSDK.xcconfig`, however.\r\n\r\nIt was the later portion that caused CocoaPods to issue the following warnings:\r\n\r\n    [!] CocoaPods did not set the base configuration of your project\r\n    because your project already has a custom config set. In order for\r\n    CocoaPods integration to work at all, please either set the base\r\n    configurations of the target `SimplyE` to `Pods/Target Support\r\n    Files/Pods-SimplyE/Pods-SimplyE.debug.xcconfig` or include the\r\n    `Pods/Target Support Files/Pods-SimplyE/Pods-SimplyE.debug.xcconfig`\r\n    in your build configuration (`Simplified+RMSDK.xcconfig`).\r\n\r\n    [!] CocoaPods did not set the base configuration of your project\r\n    because your project already has a custom config set. In order for\r\n    CocoaPods integration to work at all, please either set the base\r\n    configurations of the target `SimplyE` to `Pods/Target Support\r\n    Files/Pods-SimplyE/Pods-SimplyE.release.xcconfig` or include the\r\n    `Pods/Target Support\r\n    Files/Pods-SimplyE/Pods-SimplyE.release.xcconfig` in your build\r\n    configuration (`Simplified+RMSDK.xcconfig`).\r\n\r\nI fixed the issue as follows:\r\n\r\n* I moved all configuration into `Simplified.xcconfig` except for the setting of `FEATURE_DRM_CONNECTOR=1`.\r\n\r\n* I set the project to use `Simplified.xcconfig` for both debug and release.\r\n\r\n* I removed the superfluous `Simplified.debug.xcconfig` and `Simplified.release.xcconfig`.\r\n\r\n* In project settings, I removed the configuration setting for the target _within_ debug and release. This allowed CocoaPods to set it itself which resolved the warnings above.","created_at":"2017-03-19T03:43:10Z","updated_at":"2017-03-19T20:39:03Z","closed_at":"2017-03-19T20:39:03Z","merged_at":"2017-03-19T20:39:03Z","merge_commit_sha":"3301a793011c69f21671c27681f7bc07584d8896","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS/pulls/572/commits","review_comments_url":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS/pulls/572/comments","review_comment_url":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS/issues/572/comments","statuses_url":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS/statuses/3c8d0b11939963e15b8e4614dcf5cc2ce930dec0","head":{"label":"NYPL-Simplified:xcconfig-refactor","ref":"xcconfig-refactor","sha":"3c8d0b11939963e15b8e4614dcf5cc2ce930dec0","user":{"login":"NYPL-Simplified","id":16416905,"avatar_url":"https://avatars2.githubusercontent.com/u/16416905?v=3","gravatar_id":"","url":"https://api.github.com/users/NYPL-Simplified","html_url":"https://github.com/NYPL-Simplified","followers_url":"https://api.github.com/users/NYPL-Simplified/followers","following_url":"https://api.github.com/users/NYPL-Simplified/following{/other_user}","gists_url":"https://api.github.com/users/NYPL-Simplified/gists{/gist_id}","starred_url":"https://api.github.com/users/NYPL-Simplified/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NYPL-Simplified/subscriptions","organizations_url":"https://api.github.com/users/NYPL-Simplified/orgs","repos_url":"https://api.github.com/users/NYPL-Simplified/repos","events_url":"https://api.github.com/users/NYPL-Simplified/events{/privacy}","received_events_url":"https://api.github.com/users/NYPL-Simplified/received_events","type":"Organization","site_admin":false},"repo":{"id":19988103,"name":"Simplified-iOS","full_name":"NYPL-Simplified/Simplified-iOS","owner":{"login":"NYPL-Simplified","id":16416905,"avatar_url":"https://avatars2.githubusercontent.com/u/16416905?v=3","gravatar_id":"","url":"https://api.github.com/users/NYPL-Simplified","html_url":"https://github.com/NYPL-Simplified","followers_url":"https://api.github.com/users/NYPL-Simplified/followers","following_url":"https://api.github.com/users/NYPL-Simplified/following{/other_user}","gists_url":"https://api.github.com/users/NYPL-Simplified/gists{/gist_id}","starred_url":"https://api.github.com/users/NYPL-Simplified/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NYPL-Simplified/subscriptions","organizations_url":"https://api.github.com/users/NYPL-Simplified/orgs","repos_url":"https://api.github.com/users/NYPL-Simplified/repos","events_url":"https://api.github.com/users/NYPL-Simplified/events{/privacy}","received_events_url":"https://api.github.com/users/NYPL-Simplified/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NYPL-Simplified/Simplified-iOS","description":"The iOS client for Library Simplified","fork":false,"url":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS","forks_url":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS/forks","keys_url":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS/teams","hooks_url":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS/hooks","issue_events_url":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS/issues/events{/number}","events_url":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS/events","assignees_url":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS/assignees{/user}","branches_url":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS/branches{/branch}","tags_url":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS/tags","blobs_url":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS/git/refs{/sha}","trees_url":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS/statuses/{sha}","languages_url":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS/languages","stargazers_url":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS/stargazers","contributors_url":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS/contributors","subscribers_url":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS/subscribers","subscription_url":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS/subscription","commits_url":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS/commits{/sha}","git_commits_url":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS/git/commits{/sha}","comments_url":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS/comments{/number}","issue_comment_url":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS/issues/comments{/number}","contents_url":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS/contents/{+path}","compare_url":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS/merges","archive_url":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS/downloads","issues_url":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS/issues{/number}","pulls_url":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS/pulls{/number}","milestones_url":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS/milestones{/number}","notifications_url":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS/labels{/name}","releases_url":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS/releases{/id}","deployments_url":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS/deployments","created_at":"2014-05-20T16:17:54Z","updated_at":"2017-03-10T01:38:38Z","pushed_at":"2017-03-19T20:39:03Z","git_url":"git://github.com/NYPL-Simplified/Simplified-iOS.git","ssh_url":"git@github.com:NYPL-Simplified/Simplified-iOS.git","clone_url":"https://github.com/NYPL-Simplified/Simplified-iOS.git","svn_url":"https://github.com/NYPL-Simplified/Simplified-iOS","homepage":"","size":127967,"stargazers_count":3,"watchers_count":3,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":126,"forks":10,"open_issues":126,"watchers":3,"default_branch":"master"}},"base":{"label":"NYPL-Simplified:master","ref":"master","sha":"d78174db9f7f35cd88b213c67e4819f6e4c3e444","user":{"login":"NYPL-Simplified","id":16416905,"avatar_url":"https://avatars2.githubusercontent.com/u/16416905?v=3","gravatar_id":"","url":"https://api.github.com/users/NYPL-Simplified","html_url":"https://github.com/NYPL-Simplified","followers_url":"https://api.github.com/users/NYPL-Simplified/followers","following_url":"https://api.github.com/users/NYPL-Simplified/following{/other_user}","gists_url":"https://api.github.com/users/NYPL-Simplified/gists{/gist_id}","starred_url":"https://api.github.com/users/NYPL-Simplified/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NYPL-Simplified/subscriptions","organizations_url":"https://api.github.com/users/NYPL-Simplified/orgs","repos_url":"https://api.github.com/users/NYPL-Simplified/repos","events_url":"https://api.github.com/users/NYPL-Simplified/events{/privacy}","received_events_url":"https://api.github.com/users/NYPL-Simplified/received_events","type":"Organization","site_admin":false},"repo":{"id":19988103,"name":"Simplified-iOS","full_name":"NYPL-Simplified/Simplified-iOS","owner":{"login":"NYPL-Simplified","id":16416905,"avatar_url":"https://avatars2.githubusercontent.com/u/16416905?v=3","gravatar_id":"","url":"https://api.github.com/users/NYPL-Simplified","html_url":"https://github.com/NYPL-Simplified","followers_url":"https://api.github.com/users/NYPL-Simplified/followers","following_url":"https://api.github.com/users/NYPL-Simplified/following{/other_user}","gists_url":"https://api.github.com/users/NYPL-Simplified/gists{/gist_id}","starred_url":"https://api.github.com/users/NYPL-Simplified/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NYPL-Simplified/subscriptions","organizations_url":"https://api.github.com/users/NYPL-Simplified/orgs","repos_url":"https://api.github.com/users/NYPL-Simplified/repos","events_url":"https://api.github.com/users/NYPL-Simplified/events{/privacy}","received_events_url":"https://api.github.com/users/NYPL-Simplified/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NYPL-Simplified/Simplified-iOS","description":"The iOS client for Library Simplified","fork":false,"url":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS","forks_url":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS/forks","keys_url":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS/teams","hooks_url":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS/hooks","issue_events_url":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS/issues/events{/number}","events_url":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS/events","assignees_url":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS/assignees{/user}","branches_url":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS/branches{/branch}","tags_url":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS/tags","blobs_url":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS/git/refs{/sha}","trees_url":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS/statuses/{sha}","languages_url":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS/languages","stargazers_url":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS/stargazers","contributors_url":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS/contributors","subscribers_url":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS/subscribers","subscription_url":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS/subscription","commits_url":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS/commits{/sha}","git_commits_url":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS/git/commits{/sha}","comments_url":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS/comments{/number}","issue_comment_url":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS/issues/comments{/number}","contents_url":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS/contents/{+path}","compare_url":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS/merges","archive_url":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS/downloads","issues_url":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS/issues{/number}","pulls_url":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS/pulls{/number}","milestones_url":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS/milestones{/number}","notifications_url":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS/labels{/name}","releases_url":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS/releases{/id}","deployments_url":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS/deployments","created_at":"2014-05-20T16:17:54Z","updated_at":"2017-03-10T01:38:38Z","pushed_at":"2017-03-19T20:39:03Z","git_url":"git://github.com/NYPL-Simplified/Simplified-iOS.git","ssh_url":"git@github.com:NYPL-Simplified/Simplified-iOS.git","clone_url":"https://github.com/NYPL-Simplified/Simplified-iOS.git","svn_url":"https://github.com/NYPL-Simplified/Simplified-iOS","homepage":"","size":127967,"stargazers_count":3,"watchers_count":3,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":126,"forks":10,"open_issues":126,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS/pulls/572"},"html":{"href":"https://github.com/NYPL-Simplified/Simplified-iOS/pull/572"},"issue":{"href":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS/issues/572"},"comments":{"href":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS/issues/572/comments"},"review_comments":{"href":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS/pulls/572/comments"},"review_comment":{"href":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS/pulls/572/commits"},"statuses":{"href":"https://api.github.com/repos/NYPL-Simplified/Simplified-iOS/statuses/3c8d0b11939963e15b8e4614dcf5cc2ce930dec0"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"winniequinn","id":10768108,"avatar_url":"https://avatars3.githubusercontent.com/u/10768108?v=3","gravatar_id":"","url":"https://api.github.com/users/winniequinn","html_url":"https://github.com/winniequinn","followers_url":"https://api.github.com/users/winniequinn/followers","following_url":"https://api.github.com/users/winniequinn/following{/other_user}","gists_url":"https://api.github.com/users/winniequinn/gists{/gist_id}","starred_url":"https://api.github.com/users/winniequinn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/winniequinn/subscriptions","organizations_url":"https://api.github.com/users/winniequinn/orgs","repos_url":"https://api.github.com/users/winniequinn/repos","events_url":"https://api.github.com/users/winniequinn/events{/privacy}","received_events_url":"https://api.github.com/users/winniequinn/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":15,"deletions":21,"changed_files":5}}
{"actor":{"display_login":"winniequinn"}}