{"action":"created","issue":{"url":"https://api.github.com/repos/ocaml/ocaml/issues/1357","repository_url":"https://api.github.com/repos/ocaml/ocaml","labels_url":"https://api.github.com/repos/ocaml/ocaml/issues/1357/labels{/name}","comments_url":"https://api.github.com/repos/ocaml/ocaml/issues/1357/comments","events_url":"https://api.github.com/repos/ocaml/ocaml/issues/1357/events","html_url":"https://github.com/ocaml/ocaml/pull/1357","id":258844293,"number":1357,"title":"Fix ocamltest / Windows / Unicode issues","user":{"login":"nojb","id":113560,"avatar_url":"https://avatars3.githubusercontent.com/u/113560?v=4","gravatar_id":"","url":"https://api.github.com/users/nojb","html_url":"https://github.com/nojb","followers_url":"https://api.github.com/users/nojb/followers","following_url":"https://api.github.com/users/nojb/following{/other_user}","gists_url":"https://api.github.com/users/nojb/gists{/gist_id}","starred_url":"https://api.github.com/users/nojb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nojb/subscriptions","organizations_url":"https://api.github.com/users/nojb/orgs","repos_url":"https://api.github.com/users/nojb/repos","events_url":"https://api.github.com/users/nojb/events{/privacy}","received_events_url":"https://api.github.com/users/nojb/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":31,"created_at":"2017-09-19T14:34:43Z","updated_at":"2017-09-23T16:47:17Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ocaml/ocaml/pulls/1357","html_url":"https://github.com/ocaml/ocaml/pull/1357","diff_url":"https://github.com/ocaml/ocaml/pull/1357.diff","patch_url":"https://github.com/ocaml/ocaml/pull/1357.patch"},"body":"This is a first PR to fix some of the CI errors under Windows following the merge of #1200 and #681. ~~It is not yet ready for merging.~~\r\n\r\n- The first commit makes `ocamltest` a Unicode Windows application.\r\n- The second commit fixes a bug in #1200. (I think due to a bad rebase; ~~there is an outstanding `FIXME` that I am working on right now.~~)\r\n\r\nAlso, some \"new\" tests are still failing in the `compare-native-programs` step.  I am investigating.\r\n\r\n/cc @shindere @dra27 "},"comment":{"url":"https://api.github.com/repos/ocaml/ocaml/issues/comments/331649221","html_url":"https://github.com/ocaml/ocaml/pull/1357#issuecomment-331649221","issue_url":"https://api.github.com/repos/ocaml/ocaml/issues/1357","id":331649221,"user":{"login":"xavierleroy","id":3845810,"avatar_url":"https://avatars0.githubusercontent.com/u/3845810?v=4","gravatar_id":"","url":"https://api.github.com/users/xavierleroy","html_url":"https://github.com/xavierleroy","followers_url":"https://api.github.com/users/xavierleroy/followers","following_url":"https://api.github.com/users/xavierleroy/following{/other_user}","gists_url":"https://api.github.com/users/xavierleroy/gists{/gist_id}","starred_url":"https://api.github.com/users/xavierleroy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xavierleroy/subscriptions","organizations_url":"https://api.github.com/users/xavierleroy/orgs","repos_url":"https://api.github.com/users/xavierleroy/repos","events_url":"https://api.github.com/users/xavierleroy/events{/privacy}","received_events_url":"https://api.github.com/users/xavierleroy/received_events","type":"User","site_admin":false},"created_at":"2017-09-23T16:47:17Z","updated_at":"2017-09-23T16:47:17Z","author_association":"CONTRIBUTOR","body":"Speaking of ocamltest on Windows, the CI at Inria is failing on the MSVC and Mingw \"native Windows\" ports with errors in several (many?) of the tests that have been converted to use ocamltest:\r\n```\r\nList of failed tests:\r\n    tests/basic-modules/'main.ml' with 1 (native) \r\n    tests/basic-io-2/'io.ml' with 1 (native) \r\n    tests/basic-multdef/'usemultdef.ml' with 2 (bytecode) \r\n    tests/basic-io/'wc.ml' with 2 (bytecode) \r\n    tests/basic-io/'wc.ml' with 1 (native) \r\n    tests/basic-modules/'main.ml' with 2 (bytecode) \r\n    tests/array-functions/'test.ml' with 2 (bytecode) \r\n    tests/basic-io-2/'io.ml' with 2 (bytecode) \r\n    tests/array-functions/'test.ml' with 1 (native) \r\n    tests/basic-multdef/'usemultdef.ml' with 1 (native) \r\n    tests/basic-private/'tlength.ml' with 1 (native) \r\n    tests/basic-private/'tlength.ml' with 2 (bytecode) \r\n```\r\nI compiled a couple of those tests by hand and their output was correct modulo CR-LF/LF equivalence.\r\n\r\nDoes anyone else observes this problem?  How do we get ocamltest to explain the failure in more details?\r\n  "}}
{"actor":{"display_login":"xavierleroy"}}