{"action":"created","comment":{"url":"https://api.github.com/repos/osmandapp/OsmAnd-resources/pulls/comments/118326074","pull_request_review_id":40107226,"id":118326074,"diff_hunk":"@@ -614,12 +630,22 @@\n \t\t\t<select value=\"1.3\" t=\"highway\" v=\"steps\"/>\n \t\t\t<select value=\"3\" t=\"route\"   v=\"ferry\"/>\n \t\t\t<select value=\"5\" t=\"bicycle\" v=\"dismount\"/>\n-\t\t\t<select value=\"22\" t=\"bicycle\" v=\"designated\"/>\n-\t\t\t<if param=\"avoid_unpaved\">\n-\t\t\t\t<select value=\"4\" t=\"highway\" v=\"track\"/>\n-\t\t\t\t<select value=\"4\" t=\"highway\" v=\"footway\"/>\n-\t\t\t\t<select value=\"3\" t=\"highway\" v=\"path\"/>\n-\t\t\t</if>\n+\t\t\t<!-- <select value=\"22\" t=\"bicycle\" v=\"designated\"/>-->\n+\t\t\t<!-- Line above: Does the \"bicycle designated\" work here?\n+\t\t\tSo far, we have assigned a kmh value to tracks, paths etc - \n+\t\t\tcan a kmh value also be assigned to a tag like \"bicycle designated\"?\n+\t\t\tIf so: Would all tracks, paths etc tagged with \"bicycle designated\"\n+\t\t\tbe multiplied later on (so that, if they are tagged with \"paved\" or\n+\t\t\t\"asphalt\", the 23 kmh would be multiplied with the \"paved\" factor)?\n+\t\t\tCould someone please help me understand this?\n+\t\t\tIf it works as described, it adds some great possibilities.-->\n+\n+\t\t\t<!-- <select value=\"4\" t=\"highway\" v=\"track\"/> <select value=\"4\" t=\"highway\" v=\"footway\"/> <select value=\"3\" t=\"highway\" v=\"path\"/>-->\n+\t\t\t<!-- Line above: This line contained downgrades for the\n+\t\t\t\"avoid unpaved\" mode and has been moved further down.\n+\t\t\tOsmand first has to check if a path or track is paved,\n+\t\t\tasphalt, etc. Only if no tag like \"asphalt\" has been\n+\t\t\tfound, then paths / tracks etc should be downgraded.-->","path":"routing/routing.xml","position":98,"original_position":98,"commit_id":"09419267254a3f395fac0910e2f0fc5bdc0417f5","original_commit_id":"09419267254a3f395fac0910e2f0fc5bdc0417f5","user":{"login":"Posteinwurf","id":17393264,"avatar_url":"https://avatars0.githubusercontent.com/u/17393264?v=3","gravatar_id":"","url":"https://api.github.com/users/Posteinwurf","html_url":"https://github.com/Posteinwurf","followers_url":"https://api.github.com/users/Posteinwurf/followers","following_url":"https://api.github.com/users/Posteinwurf/following{/other_user}","gists_url":"https://api.github.com/users/Posteinwurf/gists{/gist_id}","starred_url":"https://api.github.com/users/Posteinwurf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Posteinwurf/subscriptions","organizations_url":"https://api.github.com/users/Posteinwurf/orgs","repos_url":"https://api.github.com/users/Posteinwurf/repos","events_url":"https://api.github.com/users/Posteinwurf/events{/privacy}","received_events_url":"https://api.github.com/users/Posteinwurf/received_events","type":"User","site_admin":false},"body":"I did want to suggest to delete it - just suggested to move it further down. \r\n\r\nOnce we have checked that there is no asphalt etc, the paths, tracks, footways will be heavily downgraded in \"unpaved\" mode (please look further down - I think it makes sense there). ","created_at":"2017-05-24T18:10:11Z","updated_at":"2017-05-24T18:10:11Z","html_url":"https://github.com/osmandapp/OsmAnd-resources/pull/434#discussion_r118326074","pull_request_url":"https://api.github.com/repos/osmandapp/OsmAnd-resources/pulls/434","_links":{"self":{"href":"https://api.github.com/repos/osmandapp/OsmAnd-resources/pulls/comments/118326074"},"html":{"href":"https://github.com/osmandapp/OsmAnd-resources/pull/434#discussion_r118326074"},"pull_request":{"href":"https://api.github.com/repos/osmandapp/OsmAnd-resources/pulls/434"}}},"pull_request":{"url":"https://api.github.com/repos/osmandapp/OsmAnd-resources/pulls/434","id":122228270,"html_url":"https://github.com/osmandapp/OsmAnd-resources/pull/434","diff_url":"https://github.com/osmandapp/OsmAnd-resources/pull/434.diff","patch_url":"https://github.com/osmandapp/OsmAnd-resources/pull/434.patch","issue_url":"https://api.github.com/repos/osmandapp/OsmAnd-resources/issues/434","number":434,"state":"open","locked":false,"title":"Fixes and further improvements for bike routing","user":{"login":"Posteinwurf","id":17393264,"avatar_url":"https://avatars0.githubusercontent.com/u/17393264?v=3","gravatar_id":"","url":"https://api.github.com/users/Posteinwurf","html_url":"https://github.com/Posteinwurf","followers_url":"https://api.github.com/users/Posteinwurf/followers","following_url":"https://api.github.com/users/Posteinwurf/following{/other_user}","gists_url":"https://api.github.com/users/Posteinwurf/gists{/gist_id}","starred_url":"https://api.github.com/users/Posteinwurf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Posteinwurf/subscriptions","organizations_url":"https://api.github.com/users/Posteinwurf/orgs","repos_url":"https://api.github.com/users/Posteinwurf/repos","events_url":"https://api.github.com/users/Posteinwurf/events{/privacy}","received_events_url":"https://api.github.com/users/Posteinwurf/received_events","type":"User","site_admin":false},"body":"Hello to everyone,\r\n\r\nthanks for the much improved bike routing (including the great and well done inclusion of height data). \r\n\r\nI have done much testing of the latest version (in Vienna, in a hilly countryside, in Berlin, in Salzburg, in Munich). Here are some further improvements for the routing.xml that will minimize errors in bike routing .\r\n\r\nSome problems that still exist cannot be fixed within the routing.xml alone. These are:\r\n\r\n1.) Osmand still routes through elevators, for example in Berlin (highway=elevator has to be recognised by the routing engine, so that the -1 command can work). \r\n\r\n2.) The routing engine does not recognise footway=sidewalk. It is important that Osmand does include this, so that footway=sidewalk can be heavily downgraded (ca. 0.5) . Without downgrading, this leads to many routing errors (for example in Vienna and Berlin).\r\n\r\n3.) At many bigger junctions, there is a triple counting of traffic lights (I have explained the details in my former post).\r\n\r\n4.) The height data worked great in Austria, but in Berlin (maybe in other cities also?), the height dataset seems to be incorrect. When you calculate a route that has some hills in the middle, the height profile just shows a flat line in the middle. At the same time, you get a random elevation of some meters at the end (where actually there is no elevation).\r\n\r\nThanks to all,\r\n\r\nMalte\r\n\r\nP.S. Is there any text explaining how the new osmand_highway_integrity_brouting is calculated? Or could someone give me a brief explanation?","created_at":"2017-05-24T13:28:40Z","updated_at":"2017-05-24T18:10:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"76a78fc00988b44dbd9758122eec66dcf8b6e084","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/osmandapp/OsmAnd-resources/pulls/434/commits","review_comments_url":"https://api.github.com/repos/osmandapp/OsmAnd-resources/pulls/434/comments","review_comment_url":"https://api.github.com/repos/osmandapp/OsmAnd-resources/pulls/comments{/number}","comments_url":"https://api.github.com/repos/osmandapp/OsmAnd-resources/issues/434/comments","statuses_url":"https://api.github.com/repos/osmandapp/OsmAnd-resources/statuses/09419267254a3f395fac0910e2f0fc5bdc0417f5","head":{"label":"Posteinwurf:patch-3","ref":"patch-3","sha":"09419267254a3f395fac0910e2f0fc5bdc0417f5","user":{"login":"Posteinwurf","id":17393264,"avatar_url":"https://avatars0.githubusercontent.com/u/17393264?v=3","gravatar_id":"","url":"https://api.github.com/users/Posteinwurf","html_url":"https://github.com/Posteinwurf","followers_url":"https://api.github.com/users/Posteinwurf/followers","following_url":"https://api.github.com/users/Posteinwurf/following{/other_user}","gists_url":"https://api.github.com/users/Posteinwurf/gists{/gist_id}","starred_url":"https://api.github.com/users/Posteinwurf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Posteinwurf/subscriptions","organizations_url":"https://api.github.com/users/Posteinwurf/orgs","repos_url":"https://api.github.com/users/Posteinwurf/repos","events_url":"https://api.github.com/users/Posteinwurf/events{/privacy}","received_events_url":"https://api.github.com/users/Posteinwurf/received_events","type":"User","site_admin":false},"repo":{"id":54431255,"name":"OsmAnd-resources","full_name":"Posteinwurf/OsmAnd-resources","owner":{"login":"Posteinwurf","id":17393264,"avatar_url":"https://avatars0.githubusercontent.com/u/17393264?v=3","gravatar_id":"","url":"https://api.github.com/users/Posteinwurf","html_url":"https://github.com/Posteinwurf","followers_url":"https://api.github.com/users/Posteinwurf/followers","following_url":"https://api.github.com/users/Posteinwurf/following{/other_user}","gists_url":"https://api.github.com/users/Posteinwurf/gists{/gist_id}","starred_url":"https://api.github.com/users/Posteinwurf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Posteinwurf/subscriptions","organizations_url":"https://api.github.com/users/Posteinwurf/orgs","repos_url":"https://api.github.com/users/Posteinwurf/repos","events_url":"https://api.github.com/users/Posteinwurf/events{/privacy}","received_events_url":"https://api.github.com/users/Posteinwurf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Posteinwurf/OsmAnd-resources","description":"Custom defined resources of OsmAnd project","fork":true,"url":"https://api.github.com/repos/Posteinwurf/OsmAnd-resources","forks_url":"https://api.github.com/repos/Posteinwurf/OsmAnd-resources/forks","keys_url":"https://api.github.com/repos/Posteinwurf/OsmAnd-resources/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Posteinwurf/OsmAnd-resources/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Posteinwurf/OsmAnd-resources/teams","hooks_url":"https://api.github.com/repos/Posteinwurf/OsmAnd-resources/hooks","issue_events_url":"https://api.github.com/repos/Posteinwurf/OsmAnd-resources/issues/events{/number}","events_url":"https://api.github.com/repos/Posteinwurf/OsmAnd-resources/events","assignees_url":"https://api.github.com/repos/Posteinwurf/OsmAnd-resources/assignees{/user}","branches_url":"https://api.github.com/repos/Posteinwurf/OsmAnd-resources/branches{/branch}","tags_url":"https://api.github.com/repos/Posteinwurf/OsmAnd-resources/tags","blobs_url":"https://api.github.com/repos/Posteinwurf/OsmAnd-resources/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Posteinwurf/OsmAnd-resources/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Posteinwurf/OsmAnd-resources/git/refs{/sha}","trees_url":"https://api.github.com/repos/Posteinwurf/OsmAnd-resources/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Posteinwurf/OsmAnd-resources/statuses/{sha}","languages_url":"https://api.github.com/repos/Posteinwurf/OsmAnd-resources/languages","stargazers_url":"https://api.github.com/repos/Posteinwurf/OsmAnd-resources/stargazers","contributors_url":"https://api.github.com/repos/Posteinwurf/OsmAnd-resources/contributors","subscribers_url":"https://api.github.com/repos/Posteinwurf/OsmAnd-resources/subscribers","subscription_url":"https://api.github.com/repos/Posteinwurf/OsmAnd-resources/subscription","commits_url":"https://api.github.com/repos/Posteinwurf/OsmAnd-resources/commits{/sha}","git_commits_url":"https://api.github.com/repos/Posteinwurf/OsmAnd-resources/git/commits{/sha}","comments_url":"https://api.github.com/repos/Posteinwurf/OsmAnd-resources/comments{/number}","issue_comment_url":"https://api.github.com/repos/Posteinwurf/OsmAnd-resources/issues/comments{/number}","contents_url":"https://api.github.com/repos/Posteinwurf/OsmAnd-resources/contents/{+path}","compare_url":"https://api.github.com/repos/Posteinwurf/OsmAnd-resources/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Posteinwurf/OsmAnd-resources/merges","archive_url":"https://api.github.com/repos/Posteinwurf/OsmAnd-resources/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Posteinwurf/OsmAnd-resources/downloads","issues_url":"https://api.github.com/repos/Posteinwurf/OsmAnd-resources/issues{/number}","pulls_url":"https://api.github.com/repos/Posteinwurf/OsmAnd-resources/pulls{/number}","milestones_url":"https://api.github.com/repos/Posteinwurf/OsmAnd-resources/milestones{/number}","notifications_url":"https://api.github.com/repos/Posteinwurf/OsmAnd-resources/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Posteinwurf/OsmAnd-resources/labels{/name}","releases_url":"https://api.github.com/repos/Posteinwurf/OsmAnd-resources/releases{/id}","deployments_url":"https://api.github.com/repos/Posteinwurf/OsmAnd-resources/deployments","created_at":"2016-03-21T23:52:11Z","updated_at":"2016-03-22T20:29:19Z","pushed_at":"2017-05-24T13:27:23Z","git_url":"git://github.com/Posteinwurf/OsmAnd-resources.git","ssh_url":"git@github.com:Posteinwurf/OsmAnd-resources.git","clone_url":"https://github.com/Posteinwurf/OsmAnd-resources.git","svn_url":"https://github.com/Posteinwurf/OsmAnd-resources","homepage":null,"size":311053,"stargazers_count":0,"watchers_count":0,"language":"OpenEdge ABL","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"osmandapp:master","ref":"master","sha":"598a1607a81ccedc5395738aa0ddce7cde8cfa82","user":{"login":"osmandapp","id":566635,"avatar_url":"https://avatars1.githubusercontent.com/u/566635?v=3","gravatar_id":"","url":"https://api.github.com/users/osmandapp","html_url":"https://github.com/osmandapp","followers_url":"https://api.github.com/users/osmandapp/followers","following_url":"https://api.github.com/users/osmandapp/following{/other_user}","gists_url":"https://api.github.com/users/osmandapp/gists{/gist_id}","starred_url":"https://api.github.com/users/osmandapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osmandapp/subscriptions","organizations_url":"https://api.github.com/users/osmandapp/orgs","repos_url":"https://api.github.com/users/osmandapp/repos","events_url":"https://api.github.com/users/osmandapp/events{/privacy}","received_events_url":"https://api.github.com/users/osmandapp/received_events","type":"Organization","site_admin":false},"repo":{"id":10725942,"name":"OsmAnd-resources","full_name":"osmandapp/OsmAnd-resources","owner":{"login":"osmandapp","id":566635,"avatar_url":"https://avatars1.githubusercontent.com/u/566635?v=3","gravatar_id":"","url":"https://api.github.com/users/osmandapp","html_url":"https://github.com/osmandapp","followers_url":"https://api.github.com/users/osmandapp/followers","following_url":"https://api.github.com/users/osmandapp/following{/other_user}","gists_url":"https://api.github.com/users/osmandapp/gists{/gist_id}","starred_url":"https://api.github.com/users/osmandapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osmandapp/subscriptions","organizations_url":"https://api.github.com/users/osmandapp/orgs","repos_url":"https://api.github.com/users/osmandapp/repos","events_url":"https://api.github.com/users/osmandapp/events{/privacy}","received_events_url":"https://api.github.com/users/osmandapp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/osmandapp/OsmAnd-resources","description":"Custom defined resources of OsmAnd project","fork":false,"url":"https://api.github.com/repos/osmandapp/OsmAnd-resources","forks_url":"https://api.github.com/repos/osmandapp/OsmAnd-resources/forks","keys_url":"https://api.github.com/repos/osmandapp/OsmAnd-resources/keys{/key_id}","collaborators_url":"https://api.github.com/repos/osmandapp/OsmAnd-resources/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/osmandapp/OsmAnd-resources/teams","hooks_url":"https://api.github.com/repos/osmandapp/OsmAnd-resources/hooks","issue_events_url":"https://api.github.com/repos/osmandapp/OsmAnd-resources/issues/events{/number}","events_url":"https://api.github.com/repos/osmandapp/OsmAnd-resources/events","assignees_url":"https://api.github.com/repos/osmandapp/OsmAnd-resources/assignees{/user}","branches_url":"https://api.github.com/repos/osmandapp/OsmAnd-resources/branches{/branch}","tags_url":"https://api.github.com/repos/osmandapp/OsmAnd-resources/tags","blobs_url":"https://api.github.com/repos/osmandapp/OsmAnd-resources/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/osmandapp/OsmAnd-resources/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/osmandapp/OsmAnd-resources/git/refs{/sha}","trees_url":"https://api.github.com/repos/osmandapp/OsmAnd-resources/git/trees{/sha}","statuses_url":"https://api.github.com/repos/osmandapp/OsmAnd-resources/statuses/{sha}","languages_url":"https://api.github.com/repos/osmandapp/OsmAnd-resources/languages","stargazers_url":"https://api.github.com/repos/osmandapp/OsmAnd-resources/stargazers","contributors_url":"https://api.github.com/repos/osmandapp/OsmAnd-resources/contributors","subscribers_url":"https://api.github.com/repos/osmandapp/OsmAnd-resources/subscribers","subscription_url":"https://api.github.com/repos/osmandapp/OsmAnd-resources/subscription","commits_url":"https://api.github.com/repos/osmandapp/OsmAnd-resources/commits{/sha}","git_commits_url":"https://api.github.com/repos/osmandapp/OsmAnd-resources/git/commits{/sha}","comments_url":"https://api.github.com/repos/osmandapp/OsmAnd-resources/comments{/number}","issue_comment_url":"https://api.github.com/repos/osmandapp/OsmAnd-resources/issues/comments{/number}","contents_url":"https://api.github.com/repos/osmandapp/OsmAnd-resources/contents/{+path}","compare_url":"https://api.github.com/repos/osmandapp/OsmAnd-resources/compare/{base}...{head}","merges_url":"https://api.github.com/repos/osmandapp/OsmAnd-resources/merges","archive_url":"https://api.github.com/repos/osmandapp/OsmAnd-resources/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/osmandapp/OsmAnd-resources/downloads","issues_url":"https://api.github.com/repos/osmandapp/OsmAnd-resources/issues{/number}","pulls_url":"https://api.github.com/repos/osmandapp/OsmAnd-resources/pulls{/number}","milestones_url":"https://api.github.com/repos/osmandapp/OsmAnd-resources/milestones{/number}","notifications_url":"https://api.github.com/repos/osmandapp/OsmAnd-resources/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/osmandapp/OsmAnd-resources/labels{/name}","releases_url":"https://api.github.com/repos/osmandapp/OsmAnd-resources/releases{/id}","deployments_url":"https://api.github.com/repos/osmandapp/OsmAnd-resources/deployments","created_at":"2013-06-16T21:24:45Z","updated_at":"2017-03-02T15:12:48Z","pushed_at":"2017-05-24T13:28:41Z","git_url":"git://github.com/osmandapp/OsmAnd-resources.git","ssh_url":"git@github.com:osmandapp/OsmAnd-resources.git","clone_url":"https://github.com/osmandapp/OsmAnd-resources.git","svn_url":"https://github.com/osmandapp/OsmAnd-resources","homepage":null,"size":311244,"stargazers_count":36,"watchers_count":36,"language":"OpenEdge ABL","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":187,"mirror_url":null,"open_issues_count":6,"forks":187,"open_issues":6,"watchers":36,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/osmandapp/OsmAnd-resources/pulls/434"},"html":{"href":"https://github.com/osmandapp/OsmAnd-resources/pull/434"},"issue":{"href":"https://api.github.com/repos/osmandapp/OsmAnd-resources/issues/434"},"comments":{"href":"https://api.github.com/repos/osmandapp/OsmAnd-resources/issues/434/comments"},"review_comments":{"href":"https://api.github.com/repos/osmandapp/OsmAnd-resources/pulls/434/comments"},"review_comment":{"href":"https://api.github.com/repos/osmandapp/OsmAnd-resources/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/osmandapp/OsmAnd-resources/pulls/434/commits"},"statuses":{"href":"https://api.github.com/repos/osmandapp/OsmAnd-resources/statuses/09419267254a3f395fac0910e2f0fc5bdc0417f5"}}}}
{"actor":{"display_login":"Posteinwurf"}}