{"action":"created","comment":{"url":"https://api.github.com/repos/artsy/hokusai/pulls/comments/110394182","pull_request_review_id":31565510,"id":110394182,"diff_hunk":"@@ -69,10 +64,8 @@ Required options:\n \n ### Working with Images\n \n-* `hokusai build` - Build the latest docker image for the project.\n-* `hokusai pull` - Pull images for your project from your AWS ECR repo.\n-* `hokusai push` - Push a locally built image to your AWS ECR repo.\n-* `hokusai images` - List all project images in your local docker registry.\n+* `hokusai push` - Build and push and image to the AWS ECR project repo.","path":"README.md","position":67,"original_position":61,"commit_id":"70fd0e6f4cca01c21465edf11d66a70563bce084","original_commit_id":"6fd62eba42b2ec5fd1dccc3b3aaccffbae1c162d","user":{"login":"izakp","id":997613,"avatar_url":"https://avatars3.githubusercontent.com/u/997613?v=3","gravatar_id":"","url":"https://api.github.com/users/izakp","html_url":"https://github.com/izakp","followers_url":"https://api.github.com/users/izakp/followers","following_url":"https://api.github.com/users/izakp/following{/other_user}","gists_url":"https://api.github.com/users/izakp/gists{/gist_id}","starred_url":"https://api.github.com/users/izakp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/izakp/subscriptions","organizations_url":"https://api.github.com/users/izakp/orgs","repos_url":"https://api.github.com/users/izakp/repos","events_url":"https://api.github.com/users/izakp/events{/privacy}","received_events_url":"https://api.github.com/users/izakp/received_events","type":"User","site_admin":false},"body":"Good catch","created_at":"2017-04-07T13:51:48Z","updated_at":"2017-04-07T13:51:48Z","html_url":"https://github.com/artsy/hokusai/pull/16#discussion_r110394182","pull_request_url":"https://api.github.com/repos/artsy/hokusai/pulls/16","_links":{"self":{"href":"https://api.github.com/repos/artsy/hokusai/pulls/comments/110394182"},"html":{"href":"https://github.com/artsy/hokusai/pull/16#discussion_r110394182"},"pull_request":{"href":"https://api.github.com/repos/artsy/hokusai/pulls/16"}}},"pull_request":{"url":"https://api.github.com/repos/artsy/hokusai/pulls/16","id":114417162,"html_url":"https://github.com/artsy/hokusai/pull/16","diff_url":"https://github.com/artsy/hokusai/pull/16.diff","patch_url":"https://github.com/artsy/hokusai/pull/16.patch","issue_url":"https://api.github.com/repos/artsy/hokusai/issues/16","number":16,"state":"open","locked":false,"title":"V1 refactor","user":{"login":"izakp","id":997613,"avatar_url":"https://avatars3.githubusercontent.com/u/997613?v=3","gravatar_id":"","url":"https://api.github.com/users/izakp","html_url":"https://github.com/izakp","followers_url":"https://api.github.com/users/izakp/followers","following_url":"https://api.github.com/users/izakp/following{/other_user}","gists_url":"https://api.github.com/users/izakp/gists{/gist_id}","starred_url":"https://api.github.com/users/izakp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/izakp/subscriptions","organizations_url":"https://api.github.com/users/izakp/orgs","repos_url":"https://api.github.com/users/izakp/repos","events_url":"https://api.github.com/users/izakp/events{/privacy}","received_events_url":"https://api.github.com/users/izakp/received_events","type":"User","site_admin":false},"body":"Refactor for a v1-beta release:\r\n- Remove dependency on `aws` cli - use boto3 python library\r\n- Change `AWS_REGION` env var to `AWS_DEFAULT_REGION` as it is what boto3 expects\r\n- Remove `config` command and drop references to config maps - all env should be managed through the `secrets` subcommand\r\n- Change `init` command to `setup`\r\n- Add example `secretKeyRef` fields to service dependencies (i.e. `REDIS_URL`) in `setup`\r\n- Refactor exception handling & exit codes to be handled top-level by `hokusai.command` decorator\r\n- Remove `console` command - add a `--tty` option to `run` command instead\r\n- Remove `pull` command so as not to pollute local registry\r\n- Change `images` command to `tags` command, which lists remote image tags via ECR API\r\n- `push` command always builds project (if the `test` command previously built the container, docker will use the same image cache)\r\n- Remove `build` command - builds are implicit in `test` and `push`\r\n- Add `--skip-build` option to `dev` command\r\n- Add `logs` command\r\n- Refactor internal APIs - add Kubectl, Deployment, Service classes\r\n- Change `stack` subcommands to `create` / `update` / `delete` / `status`\r\n- Support for multiple deployments via `deployments` array in config.yml\r\n- Update `setup` command to create ECR repo if it does not exist\r\n- Update `check` command to check ECR repository existence and kubectl contexts 'staging' and 'production'\r\n- Add basic unittests\r\n\r\nBreaking changes:\r\n- Existing projects should move all environment vars to secretKeyRefs, rather than configMapKeyRefs before updating.","created_at":"2017-04-05T16:20:43Z","updated_at":"2017-04-07T13:51:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3016f6cb3ea99b58b6884f483935607506594761","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/artsy/hokusai/pulls/16/commits","review_comments_url":"https://api.github.com/repos/artsy/hokusai/pulls/16/comments","review_comment_url":"https://api.github.com/repos/artsy/hokusai/pulls/comments{/number}","comments_url":"https://api.github.com/repos/artsy/hokusai/issues/16/comments","statuses_url":"https://api.github.com/repos/artsy/hokusai/statuses/70fd0e6f4cca01c21465edf11d66a70563bce084","head":{"label":"izakp:v1-refactor","ref":"v1-refactor","sha":"70fd0e6f4cca01c21465edf11d66a70563bce084","user":{"login":"izakp","id":997613,"avatar_url":"https://avatars3.githubusercontent.com/u/997613?v=3","gravatar_id":"","url":"https://api.github.com/users/izakp","html_url":"https://github.com/izakp","followers_url":"https://api.github.com/users/izakp/followers","following_url":"https://api.github.com/users/izakp/following{/other_user}","gists_url":"https://api.github.com/users/izakp/gists{/gist_id}","starred_url":"https://api.github.com/users/izakp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/izakp/subscriptions","organizations_url":"https://api.github.com/users/izakp/orgs","repos_url":"https://api.github.com/users/izakp/repos","events_url":"https://api.github.com/users/izakp/events{/privacy}","received_events_url":"https://api.github.com/users/izakp/received_events","type":"User","site_admin":false},"repo":{"id":80113096,"name":"hokusai","full_name":"izakp/hokusai","owner":{"login":"izakp","id":997613,"avatar_url":"https://avatars3.githubusercontent.com/u/997613?v=3","gravatar_id":"","url":"https://api.github.com/users/izakp","html_url":"https://github.com/izakp","followers_url":"https://api.github.com/users/izakp/followers","following_url":"https://api.github.com/users/izakp/following{/other_user}","gists_url":"https://api.github.com/users/izakp/gists{/gist_id}","starred_url":"https://api.github.com/users/izakp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/izakp/subscriptions","organizations_url":"https://api.github.com/users/izakp/orgs","repos_url":"https://api.github.com/users/izakp/repos","events_url":"https://api.github.com/users/izakp/events{/privacy}","received_events_url":"https://api.github.com/users/izakp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/izakp/hokusai","description":"Artsy Docker Development Toolkit","fork":true,"url":"https://api.github.com/repos/izakp/hokusai","forks_url":"https://api.github.com/repos/izakp/hokusai/forks","keys_url":"https://api.github.com/repos/izakp/hokusai/keys{/key_id}","collaborators_url":"https://api.github.com/repos/izakp/hokusai/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/izakp/hokusai/teams","hooks_url":"https://api.github.com/repos/izakp/hokusai/hooks","issue_events_url":"https://api.github.com/repos/izakp/hokusai/issues/events{/number}","events_url":"https://api.github.com/repos/izakp/hokusai/events","assignees_url":"https://api.github.com/repos/izakp/hokusai/assignees{/user}","branches_url":"https://api.github.com/repos/izakp/hokusai/branches{/branch}","tags_url":"https://api.github.com/repos/izakp/hokusai/tags","blobs_url":"https://api.github.com/repos/izakp/hokusai/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/izakp/hokusai/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/izakp/hokusai/git/refs{/sha}","trees_url":"https://api.github.com/repos/izakp/hokusai/git/trees{/sha}","statuses_url":"https://api.github.com/repos/izakp/hokusai/statuses/{sha}","languages_url":"https://api.github.com/repos/izakp/hokusai/languages","stargazers_url":"https://api.github.com/repos/izakp/hokusai/stargazers","contributors_url":"https://api.github.com/repos/izakp/hokusai/contributors","subscribers_url":"https://api.github.com/repos/izakp/hokusai/subscribers","subscription_url":"https://api.github.com/repos/izakp/hokusai/subscription","commits_url":"https://api.github.com/repos/izakp/hokusai/commits{/sha}","git_commits_url":"https://api.github.com/repos/izakp/hokusai/git/commits{/sha}","comments_url":"https://api.github.com/repos/izakp/hokusai/comments{/number}","issue_comment_url":"https://api.github.com/repos/izakp/hokusai/issues/comments{/number}","contents_url":"https://api.github.com/repos/izakp/hokusai/contents/{+path}","compare_url":"https://api.github.com/repos/izakp/hokusai/compare/{base}...{head}","merges_url":"https://api.github.com/repos/izakp/hokusai/merges","archive_url":"https://api.github.com/repos/izakp/hokusai/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/izakp/hokusai/downloads","issues_url":"https://api.github.com/repos/izakp/hokusai/issues{/number}","pulls_url":"https://api.github.com/repos/izakp/hokusai/pulls{/number}","milestones_url":"https://api.github.com/repos/izakp/hokusai/milestones{/number}","notifications_url":"https://api.github.com/repos/izakp/hokusai/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/izakp/hokusai/labels{/name}","releases_url":"https://api.github.com/repos/izakp/hokusai/releases{/id}","deployments_url":"https://api.github.com/repos/izakp/hokusai/deployments","created_at":"2017-01-26T12:35:06Z","updated_at":"2017-01-26T12:35:08Z","pushed_at":"2017-04-07T02:20:35Z","git_url":"git://github.com/izakp/hokusai.git","ssh_url":"git@github.com:izakp/hokusai.git","clone_url":"https://github.com/izakp/hokusai.git","svn_url":"https://github.com/izakp/hokusai","homepage":null,"size":338,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"artsy:master","ref":"master","sha":"8693ed20f2a7870a60d280b34db714bb8112b8ba","user":{"login":"artsy","id":546231,"avatar_url":"https://avatars0.githubusercontent.com/u/546231?v=3","gravatar_id":"","url":"https://api.github.com/users/artsy","html_url":"https://github.com/artsy","followers_url":"https://api.github.com/users/artsy/followers","following_url":"https://api.github.com/users/artsy/following{/other_user}","gists_url":"https://api.github.com/users/artsy/gists{/gist_id}","starred_url":"https://api.github.com/users/artsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artsy/subscriptions","organizations_url":"https://api.github.com/users/artsy/orgs","repos_url":"https://api.github.com/users/artsy/repos","events_url":"https://api.github.com/users/artsy/events{/privacy}","received_events_url":"https://api.github.com/users/artsy/received_events","type":"Organization","site_admin":false},"repo":{"id":75091616,"name":"hokusai","full_name":"artsy/hokusai","owner":{"login":"artsy","id":546231,"avatar_url":"https://avatars0.githubusercontent.com/u/546231?v=3","gravatar_id":"","url":"https://api.github.com/users/artsy","html_url":"https://github.com/artsy","followers_url":"https://api.github.com/users/artsy/followers","following_url":"https://api.github.com/users/artsy/following{/other_user}","gists_url":"https://api.github.com/users/artsy/gists{/gist_id}","starred_url":"https://api.github.com/users/artsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artsy/subscriptions","organizations_url":"https://api.github.com/users/artsy/orgs","repos_url":"https://api.github.com/users/artsy/repos","events_url":"https://api.github.com/users/artsy/events{/privacy}","received_events_url":"https://api.github.com/users/artsy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/artsy/hokusai","description":"Artsy Docker Development Toolkit","fork":false,"url":"https://api.github.com/repos/artsy/hokusai","forks_url":"https://api.github.com/repos/artsy/hokusai/forks","keys_url":"https://api.github.com/repos/artsy/hokusai/keys{/key_id}","collaborators_url":"https://api.github.com/repos/artsy/hokusai/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/artsy/hokusai/teams","hooks_url":"https://api.github.com/repos/artsy/hokusai/hooks","issue_events_url":"https://api.github.com/repos/artsy/hokusai/issues/events{/number}","events_url":"https://api.github.com/repos/artsy/hokusai/events","assignees_url":"https://api.github.com/repos/artsy/hokusai/assignees{/user}","branches_url":"https://api.github.com/repos/artsy/hokusai/branches{/branch}","tags_url":"https://api.github.com/repos/artsy/hokusai/tags","blobs_url":"https://api.github.com/repos/artsy/hokusai/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/artsy/hokusai/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/artsy/hokusai/git/refs{/sha}","trees_url":"https://api.github.com/repos/artsy/hokusai/git/trees{/sha}","statuses_url":"https://api.github.com/repos/artsy/hokusai/statuses/{sha}","languages_url":"https://api.github.com/repos/artsy/hokusai/languages","stargazers_url":"https://api.github.com/repos/artsy/hokusai/stargazers","contributors_url":"https://api.github.com/repos/artsy/hokusai/contributors","subscribers_url":"https://api.github.com/repos/artsy/hokusai/subscribers","subscription_url":"https://api.github.com/repos/artsy/hokusai/subscription","commits_url":"https://api.github.com/repos/artsy/hokusai/commits{/sha}","git_commits_url":"https://api.github.com/repos/artsy/hokusai/git/commits{/sha}","comments_url":"https://api.github.com/repos/artsy/hokusai/comments{/number}","issue_comment_url":"https://api.github.com/repos/artsy/hokusai/issues/comments{/number}","contents_url":"https://api.github.com/repos/artsy/hokusai/contents/{+path}","compare_url":"https://api.github.com/repos/artsy/hokusai/compare/{base}...{head}","merges_url":"https://api.github.com/repos/artsy/hokusai/merges","archive_url":"https://api.github.com/repos/artsy/hokusai/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/artsy/hokusai/downloads","issues_url":"https://api.github.com/repos/artsy/hokusai/issues{/number}","pulls_url":"https://api.github.com/repos/artsy/hokusai/pulls{/number}","milestones_url":"https://api.github.com/repos/artsy/hokusai/milestones{/number}","notifications_url":"https://api.github.com/repos/artsy/hokusai/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/artsy/hokusai/labels{/name}","releases_url":"https://api.github.com/repos/artsy/hokusai/releases{/id}","deployments_url":"https://api.github.com/repos/artsy/hokusai/deployments","created_at":"2016-11-29T14:56:22Z","updated_at":"2017-04-06T16:26:38Z","pushed_at":"2017-04-07T02:20:37Z","git_url":"git://github.com/artsy/hokusai.git","ssh_url":"git@github.com:artsy/hokusai.git","clone_url":"https://github.com/artsy/hokusai.git","svn_url":"https://github.com/artsy/hokusai","homepage":null,"size":274,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":1,"forks":5,"open_issues":1,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/artsy/hokusai/pulls/16"},"html":{"href":"https://github.com/artsy/hokusai/pull/16"},"issue":{"href":"https://api.github.com/repos/artsy/hokusai/issues/16"},"comments":{"href":"https://api.github.com/repos/artsy/hokusai/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/artsy/hokusai/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/artsy/hokusai/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/artsy/hokusai/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/artsy/hokusai/statuses/70fd0e6f4cca01c21465edf11d66a70563bce084"}}}}
{"actor":{"display_login":"izakp"}}