{"action":"created","issue":{"url":"https://api.github.com/repos/vaadin/vaadin-text-field/issues/56","repository_url":"https://api.github.com/repos/vaadin/vaadin-text-field","labels_url":"https://api.github.com/repos/vaadin/vaadin-text-field/issues/56/labels{/name}","comments_url":"https://api.github.com/repos/vaadin/vaadin-text-field/issues/56/comments","events_url":"https://api.github.com/repos/vaadin/vaadin-text-field/issues/56/events","html_url":"https://github.com/vaadin/vaadin-text-field/pull/56","id":219865994,"number":56,"title":"Adding errorMessage","user":{"login":"manolo","id":161853,"avatar_url":"https://avatars2.githubusercontent.com/u/161853?v=3","gravatar_id":"","url":"https://api.github.com/users/manolo","html_url":"https://github.com/manolo","followers_url":"https://api.github.com/users/manolo/followers","following_url":"https://api.github.com/users/manolo/following{/other_user}","gists_url":"https://api.github.com/users/manolo/gists{/gist_id}","starred_url":"https://api.github.com/users/manolo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manolo/subscriptions","organizations_url":"https://api.github.com/users/manolo/orgs","repos_url":"https://api.github.com/users/manolo/repos","events_url":"https://api.github.com/users/manolo/events{/privacy}","received_events_url":"https://api.github.com/users/manolo/received_events","type":"User","site_admin":false},"labels":[{"id":527046136,"url":"https://api.github.com/repos/vaadin/vaadin-text-field/labels/in%20review","name":"in review","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":29,"created_at":"2017-04-06T11:21:06Z","updated_at":"2017-04-10T09:51:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/vaadin/vaadin-text-field/pulls/56","html_url":"https://github.com/vaadin/vaadin-text-field/pull/56","diff_url":"https://github.com/vaadin/vaadin-text-field/pull/56.diff","patch_url":"https://github.com/vaadin/vaadin-text-field/pull/56.patch"},"body":"Fixes #26\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/vaadin/vaadin-text-field/56)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/vaadin/vaadin-text-field/issues/comments/292902541","html_url":"https://github.com/vaadin/vaadin-text-field/pull/56#issuecomment-292902541","issue_url":"https://api.github.com/repos/vaadin/vaadin-text-field/issues/56","id":292902541,"user":{"login":"platosha","id":247998,"avatar_url":"https://avatars2.githubusercontent.com/u/247998?v=3","gravatar_id":"","url":"https://api.github.com/users/platosha","html_url":"https://github.com/platosha","followers_url":"https://api.github.com/users/platosha/followers","following_url":"https://api.github.com/users/platosha/following{/other_user}","gists_url":"https://api.github.com/users/platosha/gists{/gist_id}","starred_url":"https://api.github.com/users/platosha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/platosha/subscriptions","organizations_url":"https://api.github.com/users/platosha/orgs","repos_url":"https://api.github.com/users/platosha/repos","events_url":"https://api.github.com/users/platosha/events{/privacy}","received_events_url":"https://api.github.com/users/platosha/received_events","type":"User","site_admin":false},"created_at":"2017-04-10T09:51:48Z","updated_at":"2017-04-10T09:51:48Z","body":"\n\n\n\nReview status: all files reviewed at latest revision, 4 unresolved discussions, some commit checks failed.\n\n---\n\n*[vaadin-text-field.html, line 77 at r4](https://reviewable.io:443/reviews/vaadin/vaadin-text-field/56#-Kh5gxC5DFHL-79o-2yD:-KhMGHwj5M8dy2jWkaJu:b9lm03d) ([raw file](https://github.com/vaadin/vaadin-text-field/blob/9ec4effa947d633ce63d2d7c76febf9722d3ea36/vaadin-text-field.html#L77)):*\n<details><summary><i>Previously, tomivirkki (Tomi Virkki) wrote…</i></summary><blockquote>\n\nIf the error message shouldn't be absolute, how would you align the `<vaadin-text-field>`s in the following example: https://jsfiddle.net/w3omtang/\n\nFor reference I added `<paper-input>`s below. They use absolute with the error message and the component aligns well.\n\nIf the answer is \"you're not supposed to use the raw version but always include a theme that takes care of the styling\", then we should probably remove the whole style block from the raw version, right?\n</blockquote></details>\n\nBTW @tomi `align-items: baseline;` makes it look much better. https://jsfiddle.net/1kosqzor/\n\nWith `align-items: baseline;` and assuming that labels are either present or absent in all of the inputs, they are aligned well.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/vaadin/vaadin-text-field/56)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"platosha"}}