{"action":"created","comment":{"url":"https://api.github.com/repos/owncloud/core/pulls/comments/138021918","pull_request_review_id":61762793,"id":138021918,"diff_hunk":"@@ -189,6 +189,11 @@ public function getMetaData($path) {\n \t\tif(!self::isPartialFile($path)) {\n \t\t\t$parentMetaData = $this->getWrapperStorage()->getMetaData($path);\n \t\t}\n+\n+\t\tif (!$parentMetaData) {","path":"lib/private/Files/Storage/Wrapper/Checksum.php","position":5,"original_position":5,"commit_id":"71e485dc593a24b161921693aab8340d40d6351e","original_commit_id":"71e485dc593a24b161921693aab8340d40d6351e","user":{"login":"IljaN","id":246983,"avatar_url":"https://avatars3.githubusercontent.com/u/246983?v=4","gravatar_id":"","url":"https://api.github.com/users/IljaN","html_url":"https://github.com/IljaN","followers_url":"https://api.github.com/users/IljaN/followers","following_url":"https://api.github.com/users/IljaN/following{/other_user}","gists_url":"https://api.github.com/users/IljaN/gists{/gist_id}","starred_url":"https://api.github.com/users/IljaN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IljaN/subscriptions","organizations_url":"https://api.github.com/users/IljaN/orgs","repos_url":"https://api.github.com/users/IljaN/repos","events_url":"https://api.github.com/users/IljaN/events{/privacy}","received_events_url":"https://api.github.com/users/IljaN/received_events","type":"User","site_admin":false},"body":"getMetaData is called here by the scanner: https://github.com/owncloud/core/blob/f7874bfd672f6061e68be5333625747bd01801e8/lib/private/Files/Cache/Scanner.php#L112-L122\r\n\r\nI think the problem is that the Scanner (and maybe the whole system) expects getMetaData  (which is chained trough all storage wrappers) to return null if a file can not be accessed. \r\n\r\nHowever the checksum wrapper behaves differently in this regard and returns an empty array. I can`t rembember why it is like this, but some call-site of getMetaData in the checksum or filecache codepath requires an array result.","created_at":"2017-09-11T09:31:31Z","updated_at":"2017-09-11T09:31:31Z","html_url":"https://github.com/owncloud/core/pull/28960#discussion_r138021918","pull_request_url":"https://api.github.com/repos/owncloud/core/pulls/28960","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/owncloud/core/pulls/comments/138021918"},"html":{"href":"https://github.com/owncloud/core/pull/28960#discussion_r138021918"},"pull_request":{"href":"https://api.github.com/repos/owncloud/core/pulls/28960"}},"in_reply_to_id":137921703},"pull_request":{"url":"https://api.github.com/repos/owncloud/core/pulls/28960","id":140051650,"html_url":"https://github.com/owncloud/core/pull/28960","diff_url":"https://github.com/owncloud/core/pull/28960.diff","patch_url":"https://github.com/owncloud/core/pull/28960.patch","issue_url":"https://api.github.com/repos/owncloud/core/issues/28960","number":28960,"state":"open","locked":false,"title":"Gracefully ignore files with wrong permissions during filescan","user":{"login":"IljaN","id":246983,"avatar_url":"https://avatars3.githubusercontent.com/u/246983?v=4","gravatar_id":"","url":"https://api.github.com/users/IljaN","html_url":"https://github.com/IljaN","followers_url":"https://api.github.com/users/IljaN/followers","following_url":"https://api.github.com/users/IljaN/following{/other_user}","gists_url":"https://api.github.com/users/IljaN/gists{/gist_id}","starred_url":"https://api.github.com/users/IljaN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IljaN/subscriptions","organizations_url":"https://api.github.com/users/IljaN/orgs","repos_url":"https://api.github.com/users/IljaN/repos","events_url":"https://api.github.com/users/IljaN/events{/privacy}","received_events_url":"https://api.github.com/users/IljaN/received_events","type":"User","site_admin":false},"body":"```\r\nException during scan: Undefined index: size\r\n#0 /home/ilja/code/core2/lib/private/Files/Cache/Scanner.php(421): OCA\\Files\\Command\\Scan->exceptionErrorHandler(8, 'Undefined index...', '/home/ilja/code...', 421, Array)\r\n#1 /home/ilja/code/core2/lib/private/Files/Cache/Scanner.php(382): OC\\Files\\Cache\\Scanner->handleChildren('files', true, 3, '3', true, 163)\r\n#2 /home/ilja/code/core2/lib/private/Files/Cache/Scanner.php(385): OC\\Files\\Cache\\Scanner->scanChildren('files', true, 3, '3', true)\r\n#3 /home/ilja/code/core2/lib/private/Files/Cache/Scanner.php(316): OC\\Files\\Cache\\Scanner->scanChildren('', true, 3, '1', true)\r\n#4 /home/ilja/code/core2/lib/private/Files/Utils/Scanner.php(235): OC\\Files\\Cache\\Scanner->scan('', true, 3)\r\n#5 /home/ilja/code/core2/apps/files/lib/Command/Scan.php(159): OC\\Files\\Utils\\Scanner->scan('/admin')\r\n#6 /home/ilja/code/core2/apps/files/lib/Command/Scan.php(228): OCA\\Files\\Command\\Scan->scanFiles('admin', '/admin', true, Object(Symfony\\Component\\Console\\Output\\ConsoleOutput), false)\r\n#7 /home/ilja/code/core2/lib/composer/symfony/console/Command/Command.php(262): OCA\\Files\\Command\\Scan->execute(Object(Symfony\\Component\\Console\\Input\\ArgvInput), Object(Symfony\\Component\\Console\\Output\\ConsoleOutput))\r\n#8 /home/ilja/code/core2/core/Command/Base.php(159): Symfony\\Component\\Console\\Command\\Command->run(Object(Symfony\\Component\\Console\\Input\\ArgvInput), Object(Symfony\\Component\\Console\\Output\\ConsoleOutput))\r\n#9 /home/ilja/code/core2/lib/composer/symfony/console/Application.php(826): OC\\Core\\Command\\Base->run(Object(Symfony\\Component\\Console\\Input\\ArgvInput), Object(Symfony\\Component\\Console\\Output\\ConsoleOutput))\r\n#10 /home/ilja/code/core2/lib/composer/symfony/console/Application.php(189): Symfony\\Component\\Console\\Application->doRunCommand(Object(OCA\\Files\\Command\\Scan), Object(Symfony\\Component\\Console\\Input\\ArgvInput), Object(Symfony\\Component\\Console\\Output\\ConsoleOutput))\r\n#11 /home/ilja/code/core2/lib/composer/symfony/console/Application.php(120): Symfony\\Component\\Console\\Application->doRun(Object(Symfony\\Component\\Console\\Input\\ArgvInput), Object(Symfony\\Component\\Console\\Output\\ConsoleOutput))\r\n#12 /home/ilja/code/core2/lib/private/Console/Application.php(160): Symfony\\Component\\Console\\Application->run(Object(Symfony\\Component\\Console\\Input\\ArgvInput), Object(Symfony\\Component\\Console\\Output\\ConsoleOutput))\r\n#13 /home/ilja/code/core2/console.php(106): OC\\Console\\Application->run()\r\n#14 /home/ilja/code/core2/occ(11): require_once('/home/ilja/code...')\r\n#15 {main}\r\n```\r\nhttps://github.com/owncloud/enterprise/issues/2235\r\n","created_at":"2017-09-08T14:32:19Z","updated_at":"2017-09-11T09:31:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"365036897e6922cd2ac3a13a51494bde5c067936","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/owncloud/core/milestones/117","html_url":"https://github.com/owncloud/core/milestone/117","labels_url":"https://api.github.com/repos/owncloud/core/milestones/117/labels","id":2619154,"number":117,"title":"planned","description":null,"creator":{"login":"PVince81","id":277525,"avatar_url":"https://avatars2.githubusercontent.com/u/277525?v=4","gravatar_id":"","url":"https://api.github.com/users/PVince81","html_url":"https://github.com/PVince81","followers_url":"https://api.github.com/users/PVince81/followers","following_url":"https://api.github.com/users/PVince81/following{/other_user}","gists_url":"https://api.github.com/users/PVince81/gists{/gist_id}","starred_url":"https://api.github.com/users/PVince81/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PVince81/subscriptions","organizations_url":"https://api.github.com/users/PVince81/orgs","repos_url":"https://api.github.com/users/PVince81/repos","events_url":"https://api.github.com/users/PVince81/events{/privacy}","received_events_url":"https://api.github.com/users/PVince81/received_events","type":"User","site_admin":false},"open_issues":52,"closed_issues":5,"state":"open","created_at":"2017-07-03T15:30:42Z","updated_at":"2017-09-11T09:23:17Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/owncloud/core/pulls/28960/commits","review_comments_url":"https://api.github.com/repos/owncloud/core/pulls/28960/comments","review_comment_url":"https://api.github.com/repos/owncloud/core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/owncloud/core/issues/28960/comments","statuses_url":"https://api.github.com/repos/owncloud/core/statuses/71e485dc593a24b161921693aab8340d40d6351e","head":{"label":"owncloud:filescan_crash_wrong_permission","ref":"filescan_crash_wrong_permission","sha":"71e485dc593a24b161921693aab8340d40d6351e","user":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars3.githubusercontent.com/u/1645051?v=4","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"repo":{"id":5550552,"name":"core","full_name":"owncloud/core","owner":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars3.githubusercontent.com/u/1645051?v=4","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/owncloud/core","description":":cloud: ownCloud web server core (Files, DAV, etc.)","fork":false,"url":"https://api.github.com/repos/owncloud/core","forks_url":"https://api.github.com/repos/owncloud/core/forks","keys_url":"https://api.github.com/repos/owncloud/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/owncloud/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/owncloud/core/teams","hooks_url":"https://api.github.com/repos/owncloud/core/hooks","issue_events_url":"https://api.github.com/repos/owncloud/core/issues/events{/number}","events_url":"https://api.github.com/repos/owncloud/core/events","assignees_url":"https://api.github.com/repos/owncloud/core/assignees{/user}","branches_url":"https://api.github.com/repos/owncloud/core/branches{/branch}","tags_url":"https://api.github.com/repos/owncloud/core/tags","blobs_url":"https://api.github.com/repos/owncloud/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/owncloud/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/owncloud/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/owncloud/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/owncloud/core/statuses/{sha}","languages_url":"https://api.github.com/repos/owncloud/core/languages","stargazers_url":"https://api.github.com/repos/owncloud/core/stargazers","contributors_url":"https://api.github.com/repos/owncloud/core/contributors","subscribers_url":"https://api.github.com/repos/owncloud/core/subscribers","subscription_url":"https://api.github.com/repos/owncloud/core/subscription","commits_url":"https://api.github.com/repos/owncloud/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/owncloud/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/owncloud/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/owncloud/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/owncloud/core/contents/{+path}","compare_url":"https://api.github.com/repos/owncloud/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/owncloud/core/merges","archive_url":"https://api.github.com/repos/owncloud/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/owncloud/core/downloads","issues_url":"https://api.github.com/repos/owncloud/core/issues{/number}","pulls_url":"https://api.github.com/repos/owncloud/core/pulls{/number}","milestones_url":"https://api.github.com/repos/owncloud/core/milestones{/number}","notifications_url":"https://api.github.com/repos/owncloud/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/owncloud/core/labels{/name}","releases_url":"https://api.github.com/repos/owncloud/core/releases{/id}","deployments_url":"https://api.github.com/repos/owncloud/core/deployments","created_at":"2012-08-25T10:32:48Z","updated_at":"2017-09-11T05:40:31Z","pushed_at":"2017-09-11T09:00:53Z","git_url":"git://github.com/owncloud/core.git","ssh_url":"git@github.com:owncloud/core.git","clone_url":"https://github.com/owncloud/core.git","svn_url":"https://github.com/owncloud/core","homepage":"https://owncloud.org/","size":225936,"stargazers_count":5495,"watchers_count":5495,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1727,"mirror_url":null,"open_issues_count":1661,"forks":1727,"open_issues":1661,"watchers":5495,"default_branch":"master"}},"base":{"label":"owncloud:stable10","ref":"stable10","sha":"195616258cdcddeec388d3e23b9179af86d4f256","user":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars3.githubusercontent.com/u/1645051?v=4","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"repo":{"id":5550552,"name":"core","full_name":"owncloud/core","owner":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars3.githubusercontent.com/u/1645051?v=4","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/owncloud/core","description":":cloud: ownCloud web server core (Files, DAV, etc.)","fork":false,"url":"https://api.github.com/repos/owncloud/core","forks_url":"https://api.github.com/repos/owncloud/core/forks","keys_url":"https://api.github.com/repos/owncloud/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/owncloud/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/owncloud/core/teams","hooks_url":"https://api.github.com/repos/owncloud/core/hooks","issue_events_url":"https://api.github.com/repos/owncloud/core/issues/events{/number}","events_url":"https://api.github.com/repos/owncloud/core/events","assignees_url":"https://api.github.com/repos/owncloud/core/assignees{/user}","branches_url":"https://api.github.com/repos/owncloud/core/branches{/branch}","tags_url":"https://api.github.com/repos/owncloud/core/tags","blobs_url":"https://api.github.com/repos/owncloud/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/owncloud/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/owncloud/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/owncloud/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/owncloud/core/statuses/{sha}","languages_url":"https://api.github.com/repos/owncloud/core/languages","stargazers_url":"https://api.github.com/repos/owncloud/core/stargazers","contributors_url":"https://api.github.com/repos/owncloud/core/contributors","subscribers_url":"https://api.github.com/repos/owncloud/core/subscribers","subscription_url":"https://api.github.com/repos/owncloud/core/subscription","commits_url":"https://api.github.com/repos/owncloud/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/owncloud/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/owncloud/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/owncloud/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/owncloud/core/contents/{+path}","compare_url":"https://api.github.com/repos/owncloud/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/owncloud/core/merges","archive_url":"https://api.github.com/repos/owncloud/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/owncloud/core/downloads","issues_url":"https://api.github.com/repos/owncloud/core/issues{/number}","pulls_url":"https://api.github.com/repos/owncloud/core/pulls{/number}","milestones_url":"https://api.github.com/repos/owncloud/core/milestones{/number}","notifications_url":"https://api.github.com/repos/owncloud/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/owncloud/core/labels{/name}","releases_url":"https://api.github.com/repos/owncloud/core/releases{/id}","deployments_url":"https://api.github.com/repos/owncloud/core/deployments","created_at":"2012-08-25T10:32:48Z","updated_at":"2017-09-11T05:40:31Z","pushed_at":"2017-09-11T09:00:53Z","git_url":"git://github.com/owncloud/core.git","ssh_url":"git@github.com:owncloud/core.git","clone_url":"https://github.com/owncloud/core.git","svn_url":"https://github.com/owncloud/core","homepage":"https://owncloud.org/","size":225936,"stargazers_count":5495,"watchers_count":5495,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1727,"mirror_url":null,"open_issues_count":1661,"forks":1727,"open_issues":1661,"watchers":5495,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/owncloud/core/pulls/28960"},"html":{"href":"https://github.com/owncloud/core/pull/28960"},"issue":{"href":"https://api.github.com/repos/owncloud/core/issues/28960"},"comments":{"href":"https://api.github.com/repos/owncloud/core/issues/28960/comments"},"review_comments":{"href":"https://api.github.com/repos/owncloud/core/pulls/28960/comments"},"review_comment":{"href":"https://api.github.com/repos/owncloud/core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/owncloud/core/pulls/28960/commits"},"statuses":{"href":"https://api.github.com/repos/owncloud/core/statuses/71e485dc593a24b161921693aab8340d40d6351e"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"IljaN"}}