{"action":"created","issue":{"url":"https://api.github.com/repos/kode54/dumb/issues/48","repository_url":"https://api.github.com/repos/kode54/dumb","labels_url":"https://api.github.com/repos/kode54/dumb/issues/48/labels{/name}","comments_url":"https://api.github.com/repos/kode54/dumb/issues/48/comments","events_url":"https://api.github.com/repos/kode54/dumb/issues/48/events","html_url":"https://github.com/kode54/dumb/issues/48","id":258286362,"number":48,"title":"Release 1.0.1 because tag 1.0 reports 0.9.3 in dumb.h","user":{"login":"SimonN","id":674969,"avatar_url":"https://avatars0.githubusercontent.com/u/674969?v=4","gravatar_id":"","url":"https://api.github.com/users/SimonN","html_url":"https://github.com/SimonN","followers_url":"https://api.github.com/users/SimonN/followers","following_url":"https://api.github.com/users/SimonN/following{/other_user}","gists_url":"https://api.github.com/users/SimonN/gists{/gist_id}","starred_url":"https://api.github.com/users/SimonN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimonN/subscriptions","organizations_url":"https://api.github.com/users/SimonN/orgs","repos_url":"https://api.github.com/users/SimonN/repos","events_url":"https://api.github.com/users/SimonN/events{/privacy}","received_events_url":"https://api.github.com/users/SimonN/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2017-09-17T07:42:43Z","updated_at":"2017-09-19T00:10:36Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"Hi, I have [support for DUMB 1.0 in Allegro 5](https://github.com/liballeg/allegro5/pull/823) while keeping its DUMB 0.9.3 support. To differentiate between 1.0 and 0.9.3, I use `#if ((DUMB_MAJOR_VERSION) >= 1)`. This looks like the best way to handle the API breakage.\r\n\r\nThe [Arch Linux DUMB package](https://www.archlinux.org/packages/community/x86_64/dumb/) points to the commit tagged 1.0, it's good style to package only from tagged versions. Unfortunately, `dumb.h` in that commit still defines its version as 0.9.3.\r\n\r\nPlease increase 1.0.0 to 1.0.1 in the header, then tag that new commit as 1.0.1. If you prefer 1.1 or any other 1.y.z, that's perfectly fine, too.\r\n\r\n@SiegeLord, Allegro 5 maintainer, agrees that such a new tag would be the best solution. I'll email the Arch DUMB and Allegro 5 package maganager afterwards and coordinate."},"comment":{"url":"https://api.github.com/repos/kode54/dumb/issues/comments/330390798","html_url":"https://github.com/kode54/dumb/issues/48#issuecomment-330390798","issue_url":"https://api.github.com/repos/kode54/dumb/issues/48","id":330390798,"user":{"login":"kode54","id":796316,"avatar_url":"https://avatars2.githubusercontent.com/u/796316?v=4","gravatar_id":"","url":"https://api.github.com/users/kode54","html_url":"https://github.com/kode54","followers_url":"https://api.github.com/users/kode54/followers","following_url":"https://api.github.com/users/kode54/following{/other_user}","gists_url":"https://api.github.com/users/kode54/gists{/gist_id}","starred_url":"https://api.github.com/users/kode54/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kode54/subscriptions","organizations_url":"https://api.github.com/users/kode54/orgs","repos_url":"https://api.github.com/users/kode54/repos","events_url":"https://api.github.com/users/kode54/events{/privacy}","received_events_url":"https://api.github.com/users/kode54/received_events","type":"User","site_admin":false},"created_at":"2017-09-19T00:10:36Z","updated_at":"2017-09-19T00:10:36Z","author_association":"OWNER","body":"I had only planned to fix bugs, not break any API. Tagging as 2.0 should be fine, so long as I've cleared away all the bugs. I had someone fuzzing the library for me, not sure what his current status is now that I've fixed all of the crashers he sent me."}}
{"actor":{"display_login":"kode54"}}