{"action":"created","comment":{"url":"https://api.github.com/repos/BlueBrain/Rockets/pulls/comments/155255661","pull_request_review_id":81543930,"id":155255661,"diff_hunk":"@@ -51,9 +51,19 @@ bool Channel::canWrite() const\n     return !lws_send_pipe_choked(wsi);\n }\n \n+bool Channel::currentMessageHasMore() const\n+{\n+    return !lws_is_final_fragment(wsi);\n+}\n+\n+size_t Channel::getCurrentMessageRemainingSize() const\n+{\n+    return lws_remaining_packet_payload(wsi);\n+}\n+\n void Channel::write(std::string&& message, const Format format)\n {\n-    const auto size = message.size();\n+    auto size = message.size();","path":"rockets/ws/channel.cpp","position":17,"original_position":17,"commit_id":"261e653bbe302b7c660d8dad7731e017aa81625e","original_commit_id":"261e653bbe302b7c660d8dad7731e017aa81625e","user":{"login":"rdumusc","id":5166658,"avatar_url":"https://avatars2.githubusercontent.com/u/5166658?v=4","gravatar_id":"","url":"https://api.github.com/users/rdumusc","html_url":"https://github.com/rdumusc","followers_url":"https://api.github.com/users/rdumusc/followers","following_url":"https://api.github.com/users/rdumusc/following{/other_user}","gists_url":"https://api.github.com/users/rdumusc/gists{/gist_id}","starred_url":"https://api.github.com/users/rdumusc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdumusc/subscriptions","organizations_url":"https://api.github.com/users/rdumusc/orgs","repos_url":"https://api.github.com/users/rdumusc/repos","events_url":"https://api.github.com/users/rdumusc/events{/privacy}","received_events_url":"https://api.github.com/users/rdumusc/received_events","type":"User","site_admin":false},"body":"why not const anymore?","created_at":"2017-12-06T14:47:00Z","updated_at":"2017-12-06T14:50:54Z","html_url":"https://github.com/BlueBrain/Rockets/pull/2#discussion_r155255661","pull_request_url":"https://api.github.com/repos/BlueBrain/Rockets/pulls/2","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/BlueBrain/Rockets/pulls/comments/155255661"},"html":{"href":"https://github.com/BlueBrain/Rockets/pull/2#discussion_r155255661"},"pull_request":{"href":"https://api.github.com/repos/BlueBrain/Rockets/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/BlueBrain/Rockets/pulls/2","id":156464626,"html_url":"https://github.com/BlueBrain/Rockets/pull/2","diff_url":"https://github.com/BlueBrain/Rockets/pull/2.diff","patch_url":"https://github.com/BlueBrain/Rockets/pull/2.patch","issue_url":"https://api.github.com/repos/BlueBrain/Rockets/issues/2","number":2,"state":"open","locked":false,"title":"Add support for fragmented websocket messages","user":{"login":"tribal-tec","id":701401,"avatar_url":"https://avatars3.githubusercontent.com/u/701401?v=4","gravatar_id":"","url":"https://api.github.com/users/tribal-tec","html_url":"https://github.com/tribal-tec","followers_url":"https://api.github.com/users/tribal-tec/followers","following_url":"https://api.github.com/users/tribal-tec/following{/other_user}","gists_url":"https://api.github.com/users/tribal-tec/gists{/gist_id}","starred_url":"https://api.github.com/users/tribal-tec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tribal-tec/subscriptions","organizations_url":"https://api.github.com/users/tribal-tec/orgs","repos_url":"https://api.github.com/users/tribal-tec/repos","events_url":"https://api.github.com/users/tribal-tec/events{/privacy}","received_events_url":"https://api.github.com/users/tribal-tec/received_events","type":"User","site_admin":false},"body":null,"created_at":"2017-12-05T13:38:12Z","updated_at":"2017-12-06T14:50:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ba779ee966161a42847bb9c1cc3b593612fec9c8","assignee":{"login":"rdumusc","id":5166658,"avatar_url":"https://avatars2.githubusercontent.com/u/5166658?v=4","gravatar_id":"","url":"https://api.github.com/users/rdumusc","html_url":"https://github.com/rdumusc","followers_url":"https://api.github.com/users/rdumusc/followers","following_url":"https://api.github.com/users/rdumusc/following{/other_user}","gists_url":"https://api.github.com/users/rdumusc/gists{/gist_id}","starred_url":"https://api.github.com/users/rdumusc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdumusc/subscriptions","organizations_url":"https://api.github.com/users/rdumusc/orgs","repos_url":"https://api.github.com/users/rdumusc/repos","events_url":"https://api.github.com/users/rdumusc/events{/privacy}","received_events_url":"https://api.github.com/users/rdumusc/received_events","type":"User","site_admin":false},"assignees":[{"login":"rdumusc","id":5166658,"avatar_url":"https://avatars2.githubusercontent.com/u/5166658?v=4","gravatar_id":"","url":"https://api.github.com/users/rdumusc","html_url":"https://github.com/rdumusc","followers_url":"https://api.github.com/users/rdumusc/followers","following_url":"https://api.github.com/users/rdumusc/following{/other_user}","gists_url":"https://api.github.com/users/rdumusc/gists{/gist_id}","starred_url":"https://api.github.com/users/rdumusc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdumusc/subscriptions","organizations_url":"https://api.github.com/users/rdumusc/orgs","repos_url":"https://api.github.com/users/rdumusc/repos","events_url":"https://api.github.com/users/rdumusc/events{/privacy}","received_events_url":"https://api.github.com/users/rdumusc/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/BlueBrain/Rockets/pulls/2/commits","review_comments_url":"https://api.github.com/repos/BlueBrain/Rockets/pulls/2/comments","review_comment_url":"https://api.github.com/repos/BlueBrain/Rockets/pulls/comments{/number}","comments_url":"https://api.github.com/repos/BlueBrain/Rockets/issues/2/comments","statuses_url":"https://api.github.com/repos/BlueBrain/Rockets/statuses/261e653bbe302b7c660d8dad7731e017aa81625e","head":{"label":"tribal-tec:master","ref":"master","sha":"261e653bbe302b7c660d8dad7731e017aa81625e","user":{"login":"tribal-tec","id":701401,"avatar_url":"https://avatars3.githubusercontent.com/u/701401?v=4","gravatar_id":"","url":"https://api.github.com/users/tribal-tec","html_url":"https://github.com/tribal-tec","followers_url":"https://api.github.com/users/tribal-tec/followers","following_url":"https://api.github.com/users/tribal-tec/following{/other_user}","gists_url":"https://api.github.com/users/tribal-tec/gists{/gist_id}","starred_url":"https://api.github.com/users/tribal-tec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tribal-tec/subscriptions","organizations_url":"https://api.github.com/users/tribal-tec/orgs","repos_url":"https://api.github.com/users/tribal-tec/repos","events_url":"https://api.github.com/users/tribal-tec/events{/privacy}","received_events_url":"https://api.github.com/users/tribal-tec/received_events","type":"User","site_admin":false},"repo":{"id":113186641,"name":"Rockets","full_name":"tribal-tec/Rockets","owner":{"login":"tribal-tec","id":701401,"avatar_url":"https://avatars3.githubusercontent.com/u/701401?v=4","gravatar_id":"","url":"https://api.github.com/users/tribal-tec","html_url":"https://github.com/tribal-tec","followers_url":"https://api.github.com/users/tribal-tec/followers","following_url":"https://api.github.com/users/tribal-tec/following{/other_user}","gists_url":"https://api.github.com/users/tribal-tec/gists{/gist_id}","starred_url":"https://api.github.com/users/tribal-tec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tribal-tec/subscriptions","organizations_url":"https://api.github.com/users/tribal-tec/orgs","repos_url":"https://api.github.com/users/tribal-tec/repos","events_url":"https://api.github.com/users/tribal-tec/events{/privacy}","received_events_url":"https://api.github.com/users/tribal-tec/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tribal-tec/Rockets","description":"REST and websockets C++ library","fork":true,"url":"https://api.github.com/repos/tribal-tec/Rockets","forks_url":"https://api.github.com/repos/tribal-tec/Rockets/forks","keys_url":"https://api.github.com/repos/tribal-tec/Rockets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tribal-tec/Rockets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tribal-tec/Rockets/teams","hooks_url":"https://api.github.com/repos/tribal-tec/Rockets/hooks","issue_events_url":"https://api.github.com/repos/tribal-tec/Rockets/issues/events{/number}","events_url":"https://api.github.com/repos/tribal-tec/Rockets/events","assignees_url":"https://api.github.com/repos/tribal-tec/Rockets/assignees{/user}","branches_url":"https://api.github.com/repos/tribal-tec/Rockets/branches{/branch}","tags_url":"https://api.github.com/repos/tribal-tec/Rockets/tags","blobs_url":"https://api.github.com/repos/tribal-tec/Rockets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tribal-tec/Rockets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tribal-tec/Rockets/git/refs{/sha}","trees_url":"https://api.github.com/repos/tribal-tec/Rockets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tribal-tec/Rockets/statuses/{sha}","languages_url":"https://api.github.com/repos/tribal-tec/Rockets/languages","stargazers_url":"https://api.github.com/repos/tribal-tec/Rockets/stargazers","contributors_url":"https://api.github.com/repos/tribal-tec/Rockets/contributors","subscribers_url":"https://api.github.com/repos/tribal-tec/Rockets/subscribers","subscription_url":"https://api.github.com/repos/tribal-tec/Rockets/subscription","commits_url":"https://api.github.com/repos/tribal-tec/Rockets/commits{/sha}","git_commits_url":"https://api.github.com/repos/tribal-tec/Rockets/git/commits{/sha}","comments_url":"https://api.github.com/repos/tribal-tec/Rockets/comments{/number}","issue_comment_url":"https://api.github.com/repos/tribal-tec/Rockets/issues/comments{/number}","contents_url":"https://api.github.com/repos/tribal-tec/Rockets/contents/{+path}","compare_url":"https://api.github.com/repos/tribal-tec/Rockets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tribal-tec/Rockets/merges","archive_url":"https://api.github.com/repos/tribal-tec/Rockets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tribal-tec/Rockets/downloads","issues_url":"https://api.github.com/repos/tribal-tec/Rockets/issues{/number}","pulls_url":"https://api.github.com/repos/tribal-tec/Rockets/pulls{/number}","milestones_url":"https://api.github.com/repos/tribal-tec/Rockets/milestones{/number}","notifications_url":"https://api.github.com/repos/tribal-tec/Rockets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tribal-tec/Rockets/labels{/name}","releases_url":"https://api.github.com/repos/tribal-tec/Rockets/releases{/id}","deployments_url":"https://api.github.com/repos/tribal-tec/Rockets/deployments","created_at":"2017-12-05T13:37:11Z","updated_at":"2017-12-05T13:37:13Z","pushed_at":"2017-12-05T13:38:07Z","git_url":"git://github.com/tribal-tec/Rockets.git","ssh_url":"git@github.com:tribal-tec/Rockets.git","clone_url":"https://github.com/tribal-tec/Rockets.git","svn_url":"https://github.com/tribal-tec/Rockets","homepage":"","size":122,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"BlueBrain:master","ref":"master","sha":"e93e1e4023aaaa34dfdfeb3b4bbec8b1b5e04015","user":{"login":"BlueBrain","id":1479142,"avatar_url":"https://avatars1.githubusercontent.com/u/1479142?v=4","gravatar_id":"","url":"https://api.github.com/users/BlueBrain","html_url":"https://github.com/BlueBrain","followers_url":"https://api.github.com/users/BlueBrain/followers","following_url":"https://api.github.com/users/BlueBrain/following{/other_user}","gists_url":"https://api.github.com/users/BlueBrain/gists{/gist_id}","starred_url":"https://api.github.com/users/BlueBrain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BlueBrain/subscriptions","organizations_url":"https://api.github.com/users/BlueBrain/orgs","repos_url":"https://api.github.com/users/BlueBrain/repos","events_url":"https://api.github.com/users/BlueBrain/events{/privacy}","received_events_url":"https://api.github.com/users/BlueBrain/received_events","type":"Organization","site_admin":false},"repo":{"id":113028966,"name":"Rockets","full_name":"BlueBrain/Rockets","owner":{"login":"BlueBrain","id":1479142,"avatar_url":"https://avatars1.githubusercontent.com/u/1479142?v=4","gravatar_id":"","url":"https://api.github.com/users/BlueBrain","html_url":"https://github.com/BlueBrain","followers_url":"https://api.github.com/users/BlueBrain/followers","following_url":"https://api.github.com/users/BlueBrain/following{/other_user}","gists_url":"https://api.github.com/users/BlueBrain/gists{/gist_id}","starred_url":"https://api.github.com/users/BlueBrain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BlueBrain/subscriptions","organizations_url":"https://api.github.com/users/BlueBrain/orgs","repos_url":"https://api.github.com/users/BlueBrain/repos","events_url":"https://api.github.com/users/BlueBrain/events{/privacy}","received_events_url":"https://api.github.com/users/BlueBrain/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/BlueBrain/Rockets","description":"REST and websockets C++ library","fork":false,"url":"https://api.github.com/repos/BlueBrain/Rockets","forks_url":"https://api.github.com/repos/BlueBrain/Rockets/forks","keys_url":"https://api.github.com/repos/BlueBrain/Rockets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BlueBrain/Rockets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BlueBrain/Rockets/teams","hooks_url":"https://api.github.com/repos/BlueBrain/Rockets/hooks","issue_events_url":"https://api.github.com/repos/BlueBrain/Rockets/issues/events{/number}","events_url":"https://api.github.com/repos/BlueBrain/Rockets/events","assignees_url":"https://api.github.com/repos/BlueBrain/Rockets/assignees{/user}","branches_url":"https://api.github.com/repos/BlueBrain/Rockets/branches{/branch}","tags_url":"https://api.github.com/repos/BlueBrain/Rockets/tags","blobs_url":"https://api.github.com/repos/BlueBrain/Rockets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BlueBrain/Rockets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BlueBrain/Rockets/git/refs{/sha}","trees_url":"https://api.github.com/repos/BlueBrain/Rockets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BlueBrain/Rockets/statuses/{sha}","languages_url":"https://api.github.com/repos/BlueBrain/Rockets/languages","stargazers_url":"https://api.github.com/repos/BlueBrain/Rockets/stargazers","contributors_url":"https://api.github.com/repos/BlueBrain/Rockets/contributors","subscribers_url":"https://api.github.com/repos/BlueBrain/Rockets/subscribers","subscription_url":"https://api.github.com/repos/BlueBrain/Rockets/subscription","commits_url":"https://api.github.com/repos/BlueBrain/Rockets/commits{/sha}","git_commits_url":"https://api.github.com/repos/BlueBrain/Rockets/git/commits{/sha}","comments_url":"https://api.github.com/repos/BlueBrain/Rockets/comments{/number}","issue_comment_url":"https://api.github.com/repos/BlueBrain/Rockets/issues/comments{/number}","contents_url":"https://api.github.com/repos/BlueBrain/Rockets/contents/{+path}","compare_url":"https://api.github.com/repos/BlueBrain/Rockets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BlueBrain/Rockets/merges","archive_url":"https://api.github.com/repos/BlueBrain/Rockets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BlueBrain/Rockets/downloads","issues_url":"https://api.github.com/repos/BlueBrain/Rockets/issues{/number}","pulls_url":"https://api.github.com/repos/BlueBrain/Rockets/pulls{/number}","milestones_url":"https://api.github.com/repos/BlueBrain/Rockets/milestones{/number}","notifications_url":"https://api.github.com/repos/BlueBrain/Rockets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BlueBrain/Rockets/labels{/name}","releases_url":"https://api.github.com/repos/BlueBrain/Rockets/releases{/id}","deployments_url":"https://api.github.com/repos/BlueBrain/Rockets/deployments","created_at":"2017-12-04T10:30:30Z","updated_at":"2017-12-04T13:11:28Z","pushed_at":"2017-12-05T13:38:13Z","git_url":"git://github.com/BlueBrain/Rockets.git","ssh_url":"git@github.com:BlueBrain/Rockets.git","clone_url":"https://github.com/BlueBrain/Rockets.git","svn_url":"https://github.com/BlueBrain/Rockets","homepage":"","size":120,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":2,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/BlueBrain/Rockets/pulls/2"},"html":{"href":"https://github.com/BlueBrain/Rockets/pull/2"},"issue":{"href":"https://api.github.com/repos/BlueBrain/Rockets/issues/2"},"comments":{"href":"https://api.github.com/repos/BlueBrain/Rockets/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/BlueBrain/Rockets/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/BlueBrain/Rockets/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/BlueBrain/Rockets/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/BlueBrain/Rockets/statuses/261e653bbe302b7c660d8dad7731e017aa81625e"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"rdumusc"}}