{"action":"created","comment":{"url":"https://api.github.com/repos/betaflight/betaflight/pulls/comments/116198140","pull_request_review_id":37803509,"id":116198140,"diff_hunk":"@@ -41,6 +41,7 @@\n #ifdef STM32F3\n #define MINIMAL_CLI\n #define USE_DSHOT\n+#define USE_GYRO_DATA_ANALYSE","path":"src/main/target/common_fc_pre.h","position":4,"original_position":4,"commit_id":"75089ea24c6d5aa104e1f90dc2bca51c7f469a2d","original_commit_id":"75089ea24c6d5aa104e1f90dc2bca51c7f469a2d","user":{"login":"mikeller","id":4742747,"avatar_url":"https://avatars2.githubusercontent.com/u/4742747?v=3","gravatar_id":"","url":"https://api.github.com/users/mikeller","html_url":"https://github.com/mikeller","followers_url":"https://api.github.com/users/mikeller/followers","following_url":"https://api.github.com/users/mikeller/following{/other_user}","gists_url":"https://api.github.com/users/mikeller/gists{/gist_id}","starred_url":"https://api.github.com/users/mikeller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikeller/subscriptions","organizations_url":"https://api.github.com/users/mikeller/orgs","repos_url":"https://api.github.com/users/mikeller/repos","events_url":"https://api.github.com/users/mikeller/events{/privacy}","received_events_url":"https://api.github.com/users/mikeller/received_events","type":"User","site_admin":false},"body":"Any reason this is not added to F4 / F7?\r\n\r\nAlso, this can not be enabled for all F3s, since it blows out flash space (at least) for OMNIBUS.","created_at":"2017-05-12T10:25:05Z","updated_at":"2017-05-12T10:25:10Z","html_url":"https://github.com/betaflight/betaflight/pull/3074#discussion_r116198140","pull_request_url":"https://api.github.com/repos/betaflight/betaflight/pulls/3074","_links":{"self":{"href":"https://api.github.com/repos/betaflight/betaflight/pulls/comments/116198140"},"html":{"href":"https://github.com/betaflight/betaflight/pull/3074#discussion_r116198140"},"pull_request":{"href":"https://api.github.com/repos/betaflight/betaflight/pulls/3074"}}},"pull_request":{"url":"https://api.github.com/repos/betaflight/betaflight/pulls/3074","id":120224396,"html_url":"https://github.com/betaflight/betaflight/pull/3074","diff_url":"https://github.com/betaflight/betaflight/pull/3074.diff","patch_url":"https://github.com/betaflight/betaflight/pull/3074.patch","issue_url":"https://api.github.com/repos/betaflight/betaflight/issues/3074","number":3074,"state":"open","locked":false,"title":"Dynamic notch","user":{"login":"rav-rav","id":17462561,"avatar_url":"https://avatars0.githubusercontent.com/u/17462561?v=3","gravatar_id":"","url":"https://api.github.com/users/rav-rav","html_url":"https://github.com/rav-rav","followers_url":"https://api.github.com/users/rav-rav/followers","following_url":"https://api.github.com/users/rav-rav/following{/other_user}","gists_url":"https://api.github.com/users/rav-rav/gists{/gist_id}","starred_url":"https://api.github.com/users/rav-rav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rav-rav/subscriptions","organizations_url":"https://api.github.com/users/rav-rav/orgs","repos_url":"https://api.github.com/users/rav-rav/repos","events_url":"https://api.github.com/users/rav-rav/events{/privacy}","received_events_url":"https://api.github.com/users/rav-rav/received_events","type":"User","site_admin":false},"body":"So, this works very well for my copter, but still needs fine tuning and lots of testing.\r\nPlease set debug_mode to FFT and share logs!\r\nYou can put it on a switch as a mode (instead of the long gone GTUNE) or enable it as a feature: DYNAMIC_FILTER\r\n\r\nLots of changes to different files were needed to get this working but I tried to keep it as clean as possible.\r\n\r\nThis runs at 4kHz on a SPRACING F3 board and has been heavily tuned for performance. It needs ~20us per gyro cycle.\r\nEach axis has its own notch filter that gets adjusted at 333Hz to the current motor frequencies.\r\n\r\nThe dynamic notch is applied before anything else and I had to shift the LPF behind all notches to get better results.\r\nCurrent filter pipeline looks like this: rawGyro -> dynamicNotch -> notch1 -> notch2 -> lpf\r\nIn my tests I could completely disable the static notches 1/2 and dTerm notch when using the dynamic notch.","created_at":"2017-05-11T23:50:02Z","updated_at":"2017-05-12T10:25:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4ac212e1b4a629affa1a1d3325adf2721f2539d8","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/betaflight/betaflight/pulls/3074/commits","review_comments_url":"https://api.github.com/repos/betaflight/betaflight/pulls/3074/comments","review_comment_url":"https://api.github.com/repos/betaflight/betaflight/pulls/comments{/number}","comments_url":"https://api.github.com/repos/betaflight/betaflight/issues/3074/comments","statuses_url":"https://api.github.com/repos/betaflight/betaflight/statuses/75089ea24c6d5aa104e1f90dc2bca51c7f469a2d","head":{"label":"rav-rav:dynamic_notch_pr","ref":"dynamic_notch_pr","sha":"75089ea24c6d5aa104e1f90dc2bca51c7f469a2d","user":{"login":"rav-rav","id":17462561,"avatar_url":"https://avatars0.githubusercontent.com/u/17462561?v=3","gravatar_id":"","url":"https://api.github.com/users/rav-rav","html_url":"https://github.com/rav-rav","followers_url":"https://api.github.com/users/rav-rav/followers","following_url":"https://api.github.com/users/rav-rav/following{/other_user}","gists_url":"https://api.github.com/users/rav-rav/gists{/gist_id}","starred_url":"https://api.github.com/users/rav-rav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rav-rav/subscriptions","organizations_url":"https://api.github.com/users/rav-rav/orgs","repos_url":"https://api.github.com/users/rav-rav/repos","events_url":"https://api.github.com/users/rav-rav/events{/privacy}","received_events_url":"https://api.github.com/users/rav-rav/received_events","type":"User","site_admin":false},"repo":{"id":52725488,"name":"betaflight","full_name":"rav-rav/betaflight","owner":{"login":"rav-rav","id":17462561,"avatar_url":"https://avatars0.githubusercontent.com/u/17462561?v=3","gravatar_id":"","url":"https://api.github.com/users/rav-rav","html_url":"https://github.com/rav-rav","followers_url":"https://api.github.com/users/rav-rav/followers","following_url":"https://api.github.com/users/rav-rav/following{/other_user}","gists_url":"https://api.github.com/users/rav-rav/gists{/gist_id}","starred_url":"https://api.github.com/users/rav-rav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rav-rav/subscriptions","organizations_url":"https://api.github.com/users/rav-rav/orgs","repos_url":"https://api.github.com/users/rav-rav/repos","events_url":"https://api.github.com/users/rav-rav/events{/privacy}","received_events_url":"https://api.github.com/users/rav-rav/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rav-rav/betaflight","description":"Beta-code version of the cleanflight flight controller firmware","fork":true,"url":"https://api.github.com/repos/rav-rav/betaflight","forks_url":"https://api.github.com/repos/rav-rav/betaflight/forks","keys_url":"https://api.github.com/repos/rav-rav/betaflight/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rav-rav/betaflight/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rav-rav/betaflight/teams","hooks_url":"https://api.github.com/repos/rav-rav/betaflight/hooks","issue_events_url":"https://api.github.com/repos/rav-rav/betaflight/issues/events{/number}","events_url":"https://api.github.com/repos/rav-rav/betaflight/events","assignees_url":"https://api.github.com/repos/rav-rav/betaflight/assignees{/user}","branches_url":"https://api.github.com/repos/rav-rav/betaflight/branches{/branch}","tags_url":"https://api.github.com/repos/rav-rav/betaflight/tags","blobs_url":"https://api.github.com/repos/rav-rav/betaflight/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rav-rav/betaflight/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rav-rav/betaflight/git/refs{/sha}","trees_url":"https://api.github.com/repos/rav-rav/betaflight/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rav-rav/betaflight/statuses/{sha}","languages_url":"https://api.github.com/repos/rav-rav/betaflight/languages","stargazers_url":"https://api.github.com/repos/rav-rav/betaflight/stargazers","contributors_url":"https://api.github.com/repos/rav-rav/betaflight/contributors","subscribers_url":"https://api.github.com/repos/rav-rav/betaflight/subscribers","subscription_url":"https://api.github.com/repos/rav-rav/betaflight/subscription","commits_url":"https://api.github.com/repos/rav-rav/betaflight/commits{/sha}","git_commits_url":"https://api.github.com/repos/rav-rav/betaflight/git/commits{/sha}","comments_url":"https://api.github.com/repos/rav-rav/betaflight/comments{/number}","issue_comment_url":"https://api.github.com/repos/rav-rav/betaflight/issues/comments{/number}","contents_url":"https://api.github.com/repos/rav-rav/betaflight/contents/{+path}","compare_url":"https://api.github.com/repos/rav-rav/betaflight/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rav-rav/betaflight/merges","archive_url":"https://api.github.com/repos/rav-rav/betaflight/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rav-rav/betaflight/downloads","issues_url":"https://api.github.com/repos/rav-rav/betaflight/issues{/number}","pulls_url":"https://api.github.com/repos/rav-rav/betaflight/pulls{/number}","milestones_url":"https://api.github.com/repos/rav-rav/betaflight/milestones{/number}","notifications_url":"https://api.github.com/repos/rav-rav/betaflight/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rav-rav/betaflight/labels{/name}","releases_url":"https://api.github.com/repos/rav-rav/betaflight/releases{/id}","deployments_url":"https://api.github.com/repos/rav-rav/betaflight/deployments","created_at":"2016-02-28T14:37:06Z","updated_at":"2016-02-28T14:37:10Z","pushed_at":"2017-05-11T21:10:19Z","git_url":"git://github.com/rav-rav/betaflight.git","ssh_url":"git@github.com:rav-rav/betaflight.git","clone_url":"https://github.com/rav-rav/betaflight.git","svn_url":"https://github.com/rav-rav/betaflight","homepage":"http://cleanflight.com","size":132879,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"betaflight"}},"base":{"label":"betaflight:master","ref":"master","sha":"76a9a9f3fbe771df2dbde7ac784275618111572f","user":{"login":"betaflight","id":19597933,"avatar_url":"https://avatars2.githubusercontent.com/u/19597933?v=3","gravatar_id":"","url":"https://api.github.com/users/betaflight","html_url":"https://github.com/betaflight","followers_url":"https://api.github.com/users/betaflight/followers","following_url":"https://api.github.com/users/betaflight/following{/other_user}","gists_url":"https://api.github.com/users/betaflight/gists{/gist_id}","starred_url":"https://api.github.com/users/betaflight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/betaflight/subscriptions","organizations_url":"https://api.github.com/users/betaflight/orgs","repos_url":"https://api.github.com/users/betaflight/repos","events_url":"https://api.github.com/users/betaflight/events{/privacy}","received_events_url":"https://api.github.com/users/betaflight/received_events","type":"Organization","site_admin":false},"repo":{"id":37060852,"name":"betaflight","full_name":"betaflight/betaflight","owner":{"login":"betaflight","id":19597933,"avatar_url":"https://avatars2.githubusercontent.com/u/19597933?v=3","gravatar_id":"","url":"https://api.github.com/users/betaflight","html_url":"https://github.com/betaflight","followers_url":"https://api.github.com/users/betaflight/followers","following_url":"https://api.github.com/users/betaflight/following{/other_user}","gists_url":"https://api.github.com/users/betaflight/gists{/gist_id}","starred_url":"https://api.github.com/users/betaflight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/betaflight/subscriptions","organizations_url":"https://api.github.com/users/betaflight/orgs","repos_url":"https://api.github.com/users/betaflight/repos","events_url":"https://api.github.com/users/betaflight/events{/privacy}","received_events_url":"https://api.github.com/users/betaflight/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/betaflight/betaflight","description":null,"fork":true,"url":"https://api.github.com/repos/betaflight/betaflight","forks_url":"https://api.github.com/repos/betaflight/betaflight/forks","keys_url":"https://api.github.com/repos/betaflight/betaflight/keys{/key_id}","collaborators_url":"https://api.github.com/repos/betaflight/betaflight/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/betaflight/betaflight/teams","hooks_url":"https://api.github.com/repos/betaflight/betaflight/hooks","issue_events_url":"https://api.github.com/repos/betaflight/betaflight/issues/events{/number}","events_url":"https://api.github.com/repos/betaflight/betaflight/events","assignees_url":"https://api.github.com/repos/betaflight/betaflight/assignees{/user}","branches_url":"https://api.github.com/repos/betaflight/betaflight/branches{/branch}","tags_url":"https://api.github.com/repos/betaflight/betaflight/tags","blobs_url":"https://api.github.com/repos/betaflight/betaflight/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/betaflight/betaflight/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/betaflight/betaflight/git/refs{/sha}","trees_url":"https://api.github.com/repos/betaflight/betaflight/git/trees{/sha}","statuses_url":"https://api.github.com/repos/betaflight/betaflight/statuses/{sha}","languages_url":"https://api.github.com/repos/betaflight/betaflight/languages","stargazers_url":"https://api.github.com/repos/betaflight/betaflight/stargazers","contributors_url":"https://api.github.com/repos/betaflight/betaflight/contributors","subscribers_url":"https://api.github.com/repos/betaflight/betaflight/subscribers","subscription_url":"https://api.github.com/repos/betaflight/betaflight/subscription","commits_url":"https://api.github.com/repos/betaflight/betaflight/commits{/sha}","git_commits_url":"https://api.github.com/repos/betaflight/betaflight/git/commits{/sha}","comments_url":"https://api.github.com/repos/betaflight/betaflight/comments{/number}","issue_comment_url":"https://api.github.com/repos/betaflight/betaflight/issues/comments{/number}","contents_url":"https://api.github.com/repos/betaflight/betaflight/contents/{+path}","compare_url":"https://api.github.com/repos/betaflight/betaflight/compare/{base}...{head}","merges_url":"https://api.github.com/repos/betaflight/betaflight/merges","archive_url":"https://api.github.com/repos/betaflight/betaflight/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/betaflight/betaflight/downloads","issues_url":"https://api.github.com/repos/betaflight/betaflight/issues{/number}","pulls_url":"https://api.github.com/repos/betaflight/betaflight/pulls{/number}","milestones_url":"https://api.github.com/repos/betaflight/betaflight/milestones{/number}","notifications_url":"https://api.github.com/repos/betaflight/betaflight/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/betaflight/betaflight/labels{/name}","releases_url":"https://api.github.com/repos/betaflight/betaflight/releases{/id}","deployments_url":"https://api.github.com/repos/betaflight/betaflight/deployments","created_at":"2015-06-08T10:37:44Z","updated_at":"2017-05-11T14:07:59Z","pushed_at":"2017-05-12T10:18:48Z","git_url":"git://github.com/betaflight/betaflight.git","ssh_url":"git@github.com:betaflight/betaflight.git","clone_url":"https://github.com/betaflight/betaflight.git","svn_url":"https://github.com/betaflight/betaflight","homepage":"","size":131482,"stargazers_count":977,"watchers_count":977,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":428,"mirror_url":null,"open_issues_count":263,"forks":428,"open_issues":263,"watchers":977,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/betaflight/betaflight/pulls/3074"},"html":{"href":"https://github.com/betaflight/betaflight/pull/3074"},"issue":{"href":"https://api.github.com/repos/betaflight/betaflight/issues/3074"},"comments":{"href":"https://api.github.com/repos/betaflight/betaflight/issues/3074/comments"},"review_comments":{"href":"https://api.github.com/repos/betaflight/betaflight/pulls/3074/comments"},"review_comment":{"href":"https://api.github.com/repos/betaflight/betaflight/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/betaflight/betaflight/pulls/3074/commits"},"statuses":{"href":"https://api.github.com/repos/betaflight/betaflight/statuses/75089ea24c6d5aa104e1f90dc2bca51c7f469a2d"}}}}
{"actor":{"display_login":"mikeller"}}