{"action":"created","comment":{"url":"https://api.github.com/repos/magfest/sideboard/pulls/comments/115607466","pull_request_review_id":37160769,"id":115607466,"diff_hunk":"@@ -13,20 +13,26 @@\n requires = [r.strip() for r in req_data.split() if r.strip() != '']\n requires = list(reversed(requires))\n \n+# testing dependencies\n+req_data = open(os.path.join(__here__, 'test_requirements.txt')).read()\n+tests_require = [r.strip() for r in req_data.split() if r.strip() != '']\n+tests_require = list(reversed(tests_require))\n+\n # temporary workaround for a Python 2 CherryPy bug, for which we opened a pull request:\n # https://bitbucket.org/cherrypy/cherrypy/pull-request/85/1285-python-2-now-accepts-both-bytestrings/\n if sys.version_info[0] == 2:\n     requires = ['CherryPy==3.2.2' if 'cherrypy' in r.lower() else r for r in requires]\n \n if __name__ == '__main__':\n+    setup_requires = {'setup_requires': ['distribute']} if sys.version_info[0] == 2 else {}","path":"setup.py","position":15,"original_position":15,"commit_id":"d9d3e6e7832fb3c7c7c6c8aebd49187a54899fde","original_commit_id":"d9d3e6e7832fb3c7c7c6c8aebd49187a54899fde","user":{"login":"EliAndrewC","id":651592,"avatar_url":"https://avatars1.githubusercontent.com/u/651592?v=3","gravatar_id":"","url":"https://api.github.com/users/EliAndrewC","html_url":"https://github.com/EliAndrewC","followers_url":"https://api.github.com/users/EliAndrewC/followers","following_url":"https://api.github.com/users/EliAndrewC/following{/other_user}","gists_url":"https://api.github.com/users/EliAndrewC/gists{/gist_id}","starred_url":"https://api.github.com/users/EliAndrewC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EliAndrewC/subscriptions","organizations_url":"https://api.github.com/users/EliAndrewC/orgs","repos_url":"https://api.github.com/users/EliAndrewC/repos","events_url":"https://api.github.com/users/EliAndrewC/events{/privacy}","received_events_url":"https://api.github.com/users/EliAndrewC/received_events","type":"User","site_admin":false},"body":"Fact: packaging is the worst thing about Python.\r\n\r\nsetuptools was obsoleted by distribute which got merged back into setuptools, which means that ``setuptools`` both obsoletes and is obsoleted by ``distribute``.\r\n\r\nThose of us using Python 3 such as MAGFest and new projects where I work can just ignore distribute, but older Python 2.7 projects still need distribute, so I changed this to only rely on distribute if you're on Python 2.7.\r\n\r\nI don't think this should cause any problems for MAGFest, but it'll be something to keep an eye on.","created_at":"2017-05-09T21:29:50Z","updated_at":"2017-05-09T21:29:50Z","html_url":"https://github.com/magfest/sideboard/pull/82#discussion_r115607466","pull_request_url":"https://api.github.com/repos/magfest/sideboard/pulls/82","_links":{"self":{"href":"https://api.github.com/repos/magfest/sideboard/pulls/comments/115607466"},"html":{"href":"https://github.com/magfest/sideboard/pull/82#discussion_r115607466"},"pull_request":{"href":"https://api.github.com/repos/magfest/sideboard/pulls/82"}}},"pull_request":{"url":"https://api.github.com/repos/magfest/sideboard/pulls/82","id":119752663,"html_url":"https://github.com/magfest/sideboard/pull/82","diff_url":"https://github.com/magfest/sideboard/pull/82.diff","patch_url":"https://github.com/magfest/sideboard/pull/82.patch","issue_url":"https://api.github.com/repos/magfest/sideboard/issues/82","number":82,"state":"open","locked":false,"title":"Resyncing with public","user":{"login":"EliAndrewC","id":651592,"avatar_url":"https://avatars1.githubusercontent.com/u/651592?v=3","gravatar_id":"","url":"https://api.github.com/users/EliAndrewC","html_url":"https://github.com/EliAndrewC","followers_url":"https://api.github.com/users/EliAndrewC/followers","following_url":"https://api.github.com/users/EliAndrewC/following{/other_user}","gists_url":"https://api.github.com/users/EliAndrewC/gists{/gist_id}","starred_url":"https://api.github.com/users/EliAndrewC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EliAndrewC/subscriptions","organizations_url":"https://api.github.com/users/EliAndrewC/orgs","repos_url":"https://api.github.com/users/EliAndrewC/repos","events_url":"https://api.github.com/users/EliAndrewC/events{/privacy}","received_events_url":"https://api.github.com/users/EliAndrewC/received_events","type":"User","site_admin":false},"body":"I'm pushing back what we've done on Sideboard at my day job over the past few months, which mostly has to do with websockets and our services API.\r\n\r\nIt looks like this won't merge cleanly, so I'll merge into this branch and resolve any conflicts and use this opportunity to pull back down the things Rob has been working on.\r\n\r\nI'll go through and leave inline comments explaining all of the changes.","created_at":"2017-05-09T21:00:24Z","updated_at":"2017-05-09T21:29:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c6de72ce264e4b5fa29f1234949d30078721d855","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/magfest/sideboard/pulls/82/commits","review_comments_url":"https://api.github.com/repos/magfest/sideboard/pulls/82/comments","review_comment_url":"https://api.github.com/repos/magfest/sideboard/pulls/comments{/number}","comments_url":"https://api.github.com/repos/magfest/sideboard/issues/82/comments","statuses_url":"https://api.github.com/repos/magfest/sideboard/statuses/d9d3e6e7832fb3c7c7c6c8aebd49187a54899fde","head":{"label":"magfest:public-resync-2017-05-09","ref":"public-resync-2017-05-09","sha":"d9d3e6e7832fb3c7c7c6c8aebd49187a54899fde","user":{"login":"magfest","id":7840140,"avatar_url":"https://avatars1.githubusercontent.com/u/7840140?v=3","gravatar_id":"","url":"https://api.github.com/users/magfest","html_url":"https://github.com/magfest","followers_url":"https://api.github.com/users/magfest/followers","following_url":"https://api.github.com/users/magfest/following{/other_user}","gists_url":"https://api.github.com/users/magfest/gists{/gist_id}","starred_url":"https://api.github.com/users/magfest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magfest/subscriptions","organizations_url":"https://api.github.com/users/magfest/orgs","repos_url":"https://api.github.com/users/magfest/repos","events_url":"https://api.github.com/users/magfest/events{/privacy}","received_events_url":"https://api.github.com/users/magfest/received_events","type":"Organization","site_admin":false},"repo":{"id":24132807,"name":"sideboard","full_name":"magfest/sideboard","owner":{"login":"magfest","id":7840140,"avatar_url":"https://avatars1.githubusercontent.com/u/7840140?v=3","gravatar_id":"","url":"https://api.github.com/users/magfest","html_url":"https://github.com/magfest","followers_url":"https://api.github.com/users/magfest/followers","following_url":"https://api.github.com/users/magfest/following{/other_user}","gists_url":"https://api.github.com/users/magfest/gists{/gist_id}","starred_url":"https://api.github.com/users/magfest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magfest/subscriptions","organizations_url":"https://api.github.com/users/magfest/orgs","repos_url":"https://api.github.com/users/magfest/repos","events_url":"https://api.github.com/users/magfest/events{/privacy}","received_events_url":"https://api.github.com/users/magfest/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/magfest/sideboard","description":null,"fork":false,"url":"https://api.github.com/repos/magfest/sideboard","forks_url":"https://api.github.com/repos/magfest/sideboard/forks","keys_url":"https://api.github.com/repos/magfest/sideboard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/magfest/sideboard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/magfest/sideboard/teams","hooks_url":"https://api.github.com/repos/magfest/sideboard/hooks","issue_events_url":"https://api.github.com/repos/magfest/sideboard/issues/events{/number}","events_url":"https://api.github.com/repos/magfest/sideboard/events","assignees_url":"https://api.github.com/repos/magfest/sideboard/assignees{/user}","branches_url":"https://api.github.com/repos/magfest/sideboard/branches{/branch}","tags_url":"https://api.github.com/repos/magfest/sideboard/tags","blobs_url":"https://api.github.com/repos/magfest/sideboard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/magfest/sideboard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/magfest/sideboard/git/refs{/sha}","trees_url":"https://api.github.com/repos/magfest/sideboard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/magfest/sideboard/statuses/{sha}","languages_url":"https://api.github.com/repos/magfest/sideboard/languages","stargazers_url":"https://api.github.com/repos/magfest/sideboard/stargazers","contributors_url":"https://api.github.com/repos/magfest/sideboard/contributors","subscribers_url":"https://api.github.com/repos/magfest/sideboard/subscribers","subscription_url":"https://api.github.com/repos/magfest/sideboard/subscription","commits_url":"https://api.github.com/repos/magfest/sideboard/commits{/sha}","git_commits_url":"https://api.github.com/repos/magfest/sideboard/git/commits{/sha}","comments_url":"https://api.github.com/repos/magfest/sideboard/comments{/number}","issue_comment_url":"https://api.github.com/repos/magfest/sideboard/issues/comments{/number}","contents_url":"https://api.github.com/repos/magfest/sideboard/contents/{+path}","compare_url":"https://api.github.com/repos/magfest/sideboard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/magfest/sideboard/merges","archive_url":"https://api.github.com/repos/magfest/sideboard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/magfest/sideboard/downloads","issues_url":"https://api.github.com/repos/magfest/sideboard/issues{/number}","pulls_url":"https://api.github.com/repos/magfest/sideboard/pulls{/number}","milestones_url":"https://api.github.com/repos/magfest/sideboard/milestones{/number}","notifications_url":"https://api.github.com/repos/magfest/sideboard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/magfest/sideboard/labels{/name}","releases_url":"https://api.github.com/repos/magfest/sideboard/releases{/id}","deployments_url":"https://api.github.com/repos/magfest/sideboard/deployments","created_at":"2014-09-17T06:27:40Z","updated_at":"2017-03-08T01:05:49Z","pushed_at":"2017-05-09T21:16:02Z","git_url":"git://github.com/magfest/sideboard.git","ssh_url":"git@github.com:magfest/sideboard.git","clone_url":"https://github.com/magfest/sideboard.git","svn_url":"https://github.com/magfest/sideboard","homepage":null,"size":3066,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":32,"forks":8,"open_issues":32,"watchers":5,"default_branch":"master"}},"base":{"label":"magfest:master","ref":"master","sha":"051dd29691fd68e47b05efe015091d4a0fb1df3b","user":{"login":"magfest","id":7840140,"avatar_url":"https://avatars1.githubusercontent.com/u/7840140?v=3","gravatar_id":"","url":"https://api.github.com/users/magfest","html_url":"https://github.com/magfest","followers_url":"https://api.github.com/users/magfest/followers","following_url":"https://api.github.com/users/magfest/following{/other_user}","gists_url":"https://api.github.com/users/magfest/gists{/gist_id}","starred_url":"https://api.github.com/users/magfest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magfest/subscriptions","organizations_url":"https://api.github.com/users/magfest/orgs","repos_url":"https://api.github.com/users/magfest/repos","events_url":"https://api.github.com/users/magfest/events{/privacy}","received_events_url":"https://api.github.com/users/magfest/received_events","type":"Organization","site_admin":false},"repo":{"id":24132807,"name":"sideboard","full_name":"magfest/sideboard","owner":{"login":"magfest","id":7840140,"avatar_url":"https://avatars1.githubusercontent.com/u/7840140?v=3","gravatar_id":"","url":"https://api.github.com/users/magfest","html_url":"https://github.com/magfest","followers_url":"https://api.github.com/users/magfest/followers","following_url":"https://api.github.com/users/magfest/following{/other_user}","gists_url":"https://api.github.com/users/magfest/gists{/gist_id}","starred_url":"https://api.github.com/users/magfest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magfest/subscriptions","organizations_url":"https://api.github.com/users/magfest/orgs","repos_url":"https://api.github.com/users/magfest/repos","events_url":"https://api.github.com/users/magfest/events{/privacy}","received_events_url":"https://api.github.com/users/magfest/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/magfest/sideboard","description":null,"fork":false,"url":"https://api.github.com/repos/magfest/sideboard","forks_url":"https://api.github.com/repos/magfest/sideboard/forks","keys_url":"https://api.github.com/repos/magfest/sideboard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/magfest/sideboard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/magfest/sideboard/teams","hooks_url":"https://api.github.com/repos/magfest/sideboard/hooks","issue_events_url":"https://api.github.com/repos/magfest/sideboard/issues/events{/number}","events_url":"https://api.github.com/repos/magfest/sideboard/events","assignees_url":"https://api.github.com/repos/magfest/sideboard/assignees{/user}","branches_url":"https://api.github.com/repos/magfest/sideboard/branches{/branch}","tags_url":"https://api.github.com/repos/magfest/sideboard/tags","blobs_url":"https://api.github.com/repos/magfest/sideboard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/magfest/sideboard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/magfest/sideboard/git/refs{/sha}","trees_url":"https://api.github.com/repos/magfest/sideboard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/magfest/sideboard/statuses/{sha}","languages_url":"https://api.github.com/repos/magfest/sideboard/languages","stargazers_url":"https://api.github.com/repos/magfest/sideboard/stargazers","contributors_url":"https://api.github.com/repos/magfest/sideboard/contributors","subscribers_url":"https://api.github.com/repos/magfest/sideboard/subscribers","subscription_url":"https://api.github.com/repos/magfest/sideboard/subscription","commits_url":"https://api.github.com/repos/magfest/sideboard/commits{/sha}","git_commits_url":"https://api.github.com/repos/magfest/sideboard/git/commits{/sha}","comments_url":"https://api.github.com/repos/magfest/sideboard/comments{/number}","issue_comment_url":"https://api.github.com/repos/magfest/sideboard/issues/comments{/number}","contents_url":"https://api.github.com/repos/magfest/sideboard/contents/{+path}","compare_url":"https://api.github.com/repos/magfest/sideboard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/magfest/sideboard/merges","archive_url":"https://api.github.com/repos/magfest/sideboard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/magfest/sideboard/downloads","issues_url":"https://api.github.com/repos/magfest/sideboard/issues{/number}","pulls_url":"https://api.github.com/repos/magfest/sideboard/pulls{/number}","milestones_url":"https://api.github.com/repos/magfest/sideboard/milestones{/number}","notifications_url":"https://api.github.com/repos/magfest/sideboard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/magfest/sideboard/labels{/name}","releases_url":"https://api.github.com/repos/magfest/sideboard/releases{/id}","deployments_url":"https://api.github.com/repos/magfest/sideboard/deployments","created_at":"2014-09-17T06:27:40Z","updated_at":"2017-03-08T01:05:49Z","pushed_at":"2017-05-09T21:16:02Z","git_url":"git://github.com/magfest/sideboard.git","ssh_url":"git@github.com:magfest/sideboard.git","clone_url":"https://github.com/magfest/sideboard.git","svn_url":"https://github.com/magfest/sideboard","homepage":null,"size":3066,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":32,"forks":8,"open_issues":32,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/magfest/sideboard/pulls/82"},"html":{"href":"https://github.com/magfest/sideboard/pull/82"},"issue":{"href":"https://api.github.com/repos/magfest/sideboard/issues/82"},"comments":{"href":"https://api.github.com/repos/magfest/sideboard/issues/82/comments"},"review_comments":{"href":"https://api.github.com/repos/magfest/sideboard/pulls/82/comments"},"review_comment":{"href":"https://api.github.com/repos/magfest/sideboard/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/magfest/sideboard/pulls/82/commits"},"statuses":{"href":"https://api.github.com/repos/magfest/sideboard/statuses/d9d3e6e7832fb3c7c7c6c8aebd49187a54899fde"}}}}
{"actor":{"display_login":"EliAndrewC"}}