{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/react-native/issues/14370","repository_url":"https://api.github.com/repos/facebook/react-native","labels_url":"https://api.github.com/repos/facebook/react-native/issues/14370/labels{/name}","comments_url":"https://api.github.com/repos/facebook/react-native/issues/14370/comments","events_url":"https://api.github.com/repos/facebook/react-native/issues/14370/events","html_url":"https://github.com/facebook/react-native/pull/14370","id":234274252,"number":14370,"title":"Refactor PropTypes to use `prop-types` package","user":{"login":"JonnyBurger","id":1629785,"avatar_url":"https://avatars1.githubusercontent.com/u/1629785?v=3","gravatar_id":"","url":"https://api.github.com/users/JonnyBurger","html_url":"https://github.com/JonnyBurger","followers_url":"https://api.github.com/users/JonnyBurger/followers","following_url":"https://api.github.com/users/JonnyBurger/following{/other_user}","gists_url":"https://api.github.com/users/JonnyBurger/gists{/gist_id}","starred_url":"https://api.github.com/users/JonnyBurger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JonnyBurger/subscriptions","organizations_url":"https://api.github.com/users/JonnyBurger/orgs","repos_url":"https://api.github.com/users/JonnyBurger/repos","events_url":"https://api.github.com/users/JonnyBurger/events{/privacy}","received_events_url":"https://api.github.com/users/JonnyBurger/received_events","type":"User","site_admin":false},"labels":[{"id":196858975,"url":"https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed","name":"CLA Signed","color":"e7e7e7","default":false},{"id":172167414,"url":"https://api.github.com/repos/facebook/react-native/labels/GH%20Review:%20accepted","name":"GH Review: accepted","color":"009800","default":false},{"id":302755315,"url":"https://api.github.com/repos/facebook/react-native/labels/Import%20Failed","name":"Import Failed","color":"e11d21","default":false},{"id":358768107,"url":"https://api.github.com/repos/facebook/react-native/labels/Import%20Started","name":"Import Started","color":"eeeeee","default":false},{"id":257498156,"url":"https://api.github.com/repos/facebook/react-native/labels/JS","name":"JS","color":"fef2c0","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2017-06-07T16:49:13Z","updated_at":"2017-06-13T09:08:36Z","closed_at":"2017-06-13T09:08:36Z","pull_request":{"url":"https://api.github.com/repos/facebook/react-native/pulls/14370","html_url":"https://github.com/facebook/react-native/pull/14370","diff_url":"https://github.com/facebook/react-native/pull/14370.diff","patch_url":"https://github.com/facebook/react-native/pull/14370.patch"},"body":"This PR switches out all occurences of `React.PropTypes` with `PropTypes` of `prop-types`.\r\n\r\n- [x] Explain the **motivation** for making this change.\r\n- [x] Provide a **test plan** demonstrating that the code is solid.\r\n- [x] Match the **code formatting** of the rest of the codebase.\r\n- [x] Target the `master` branch, NOT a \"stable\" branch.\r\n\r\n## Motivation (required)\r\n\r\nTo remove the warnings caused by React 16.\r\n`React.PropTypes` is deprecated and should be migrated to the `prop-types` package.\r\n\r\n## Test Plan (required)\r\n\r\nNo more tests are failing than on the master branch.\r\nThe prop types package should have an equal API with `React.PropTypes`, with only two exceptions:\r\n- Validator functions cannot be called, which there seem to be none.\r\n- `React.checkPropTypes`  is now `PropTypes.checkPropTypes`. Two occurences were updated."},"comment":{"url":"https://api.github.com/repos/facebook/react-native/issues/comments/308055010","html_url":"https://github.com/facebook/react-native/pull/14370#issuecomment-308055010","issue_url":"https://api.github.com/repos/facebook/react-native/issues/14370","id":308055010,"user":{"login":"javache","id":5676,"avatar_url":"https://avatars0.githubusercontent.com/u/5676?v=3","gravatar_id":"","url":"https://api.github.com/users/javache","html_url":"https://github.com/javache","followers_url":"https://api.github.com/users/javache/followers","following_url":"https://api.github.com/users/javache/following{/other_user}","gists_url":"https://api.github.com/users/javache/gists{/gist_id}","starred_url":"https://api.github.com/users/javache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javache/subscriptions","organizations_url":"https://api.github.com/users/javache/orgs","repos_url":"https://api.github.com/users/javache/repos","events_url":"https://api.github.com/users/javache/events{/privacy}","received_events_url":"https://api.github.com/users/javache/received_events","type":"User","site_admin":false},"created_at":"2017-06-13T09:08:35Z","updated_at":"2017-06-13T09:08:35Z","body":"I think all of the remaining callsites have been fixed in https://github.com/facebook/react-native/commit/50b11aa09b479e5ce8b06de98e02ba1dd6a8cca3"}}
{"actor":{"display_login":"javache"}}