{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/pulls/comments/152453267","pull_request_review_id":78317772,"id":152453267,"diff_hunk":"@@ -1722,7 +1722,7 @@ def api_client\n       else\n         unless @client.authorization.expired?\n           begin\n-            @client.authorization.fetch_access_token!\n+            @client.authorization.fetch_access_token!(:use_configured_scope => true)","path":"lib/fluent/plugin/out_google_cloud.rb","position":null,"original_position":5,"commit_id":"82912858e49ecc262361405db628129d77034f3d","original_commit_id":"d036d8c7303284a984d29fdc0cba02099c0598af","user":{"login":"pkern","id":42176,"avatar_url":"https://avatars3.githubusercontent.com/u/42176?v=4","gravatar_id":"","url":"https://api.github.com/users/pkern","html_url":"https://github.com/pkern","followers_url":"https://api.github.com/users/pkern/followers","following_url":"https://api.github.com/users/pkern/following{/other_user}","gists_url":"https://api.github.com/users/pkern/gists{/gist_id}","starred_url":"https://api.github.com/users/pkern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkern/subscriptions","organizations_url":"https://api.github.com/users/pkern/orgs","repos_url":"https://api.github.com/users/pkern/repos","events_url":"https://api.github.com/users/pkern/events{/privacy}","received_events_url":"https://api.github.com/users/pkern/received_events","type":"User","site_admin":false},"body":"Where would I need to put the use_grpc = true to test with it? (Assuming a regular google-fluentd package.)","created_at":"2017-11-22T02:11:22Z","updated_at":"2017-11-22T02:11:22Z","html_url":"https://github.com/GoogleCloudPlatform/fluent-plugin-google-cloud/pull/179#discussion_r152453267","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/pulls/179","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/pulls/comments/152453267"},"html":{"href":"https://github.com/GoogleCloudPlatform/fluent-plugin-google-cloud/pull/179#discussion_r152453267"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/pulls/179"}},"in_reply_to_id":152276122},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/pulls/179","id":153889975,"html_url":"https://github.com/GoogleCloudPlatform/fluent-plugin-google-cloud/pull/179","diff_url":"https://github.com/GoogleCloudPlatform/fluent-plugin-google-cloud/pull/179.diff","patch_url":"https://github.com/GoogleCloudPlatform/fluent-plugin-google-cloud/pull/179.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/issues/179","number":179,"state":"open","locked":false,"title":"Request the logging scope from signet when fetching an access token.","user":{"login":"pkern","id":42176,"avatar_url":"https://avatars3.githubusercontent.com/u/42176?v=4","gravatar_id":"","url":"https://api.github.com/users/pkern","html_url":"https://github.com/pkern","followers_url":"https://api.github.com/users/pkern/followers","following_url":"https://api.github.com/users/pkern/following{/other_user}","gists_url":"https://api.github.com/users/pkern/gists{/gist_id}","starred_url":"https://api.github.com/users/pkern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkern/subscriptions","organizations_url":"https://api.github.com/users/pkern/orgs","repos_url":"https://api.github.com/users/pkern/repos","events_url":"https://api.github.com/users/pkern/events{/privacy}","received_events_url":"https://api.github.com/users/pkern/received_events","type":"User","site_admin":false},"body":"The plugin already sets the logging scope to be requested for newly\r\nacquired access token. However signet ignores this unless it obtains the\r\nrefresh token itself. google-fluentd usually uses a service account to\r\ndo so. If someone passes in an already created refresh token using the\r\nGOOGLE_REFRESH_TOKEN environment variable, the access token request will\r\nnot request the logging scope. This fixes the latter.\r\n\r\nMore context about the change in signet (0.8+) can be found in\r\nhttps://github.com/google/signet/pull/89","created_at":"2017-11-21T13:28:06Z","updated_at":"2017-11-22T02:11:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"95d752156922b22cd008e2b89c1bd1c7737c3aaf","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/pulls/179/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/pulls/179/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/issues/179/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/statuses/82912858e49ecc262361405db628129d77034f3d","head":{"label":"pkern:master","ref":"master","sha":"82912858e49ecc262361405db628129d77034f3d","user":{"login":"pkern","id":42176,"avatar_url":"https://avatars3.githubusercontent.com/u/42176?v=4","gravatar_id":"","url":"https://api.github.com/users/pkern","html_url":"https://github.com/pkern","followers_url":"https://api.github.com/users/pkern/followers","following_url":"https://api.github.com/users/pkern/following{/other_user}","gists_url":"https://api.github.com/users/pkern/gists{/gist_id}","starred_url":"https://api.github.com/users/pkern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkern/subscriptions","organizations_url":"https://api.github.com/users/pkern/orgs","repos_url":"https://api.github.com/users/pkern/repos","events_url":"https://api.github.com/users/pkern/events{/privacy}","received_events_url":"https://api.github.com/users/pkern/received_events","type":"User","site_admin":false},"repo":{"id":111551677,"name":"fluent-plugin-google-cloud","full_name":"pkern/fluent-plugin-google-cloud","owner":{"login":"pkern","id":42176,"avatar_url":"https://avatars3.githubusercontent.com/u/42176?v=4","gravatar_id":"","url":"https://api.github.com/users/pkern","html_url":"https://github.com/pkern","followers_url":"https://api.github.com/users/pkern/followers","following_url":"https://api.github.com/users/pkern/following{/other_user}","gists_url":"https://api.github.com/users/pkern/gists{/gist_id}","starred_url":"https://api.github.com/users/pkern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkern/subscriptions","organizations_url":"https://api.github.com/users/pkern/orgs","repos_url":"https://api.github.com/users/pkern/repos","events_url":"https://api.github.com/users/pkern/events{/privacy}","received_events_url":"https://api.github.com/users/pkern/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pkern/fluent-plugin-google-cloud","description":"Plugin for Fluentd that sends logs to the Google Cloud Platform's log ingestion API.","fork":true,"url":"https://api.github.com/repos/pkern/fluent-plugin-google-cloud","forks_url":"https://api.github.com/repos/pkern/fluent-plugin-google-cloud/forks","keys_url":"https://api.github.com/repos/pkern/fluent-plugin-google-cloud/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pkern/fluent-plugin-google-cloud/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pkern/fluent-plugin-google-cloud/teams","hooks_url":"https://api.github.com/repos/pkern/fluent-plugin-google-cloud/hooks","issue_events_url":"https://api.github.com/repos/pkern/fluent-plugin-google-cloud/issues/events{/number}","events_url":"https://api.github.com/repos/pkern/fluent-plugin-google-cloud/events","assignees_url":"https://api.github.com/repos/pkern/fluent-plugin-google-cloud/assignees{/user}","branches_url":"https://api.github.com/repos/pkern/fluent-plugin-google-cloud/branches{/branch}","tags_url":"https://api.github.com/repos/pkern/fluent-plugin-google-cloud/tags","blobs_url":"https://api.github.com/repos/pkern/fluent-plugin-google-cloud/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pkern/fluent-plugin-google-cloud/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pkern/fluent-plugin-google-cloud/git/refs{/sha}","trees_url":"https://api.github.com/repos/pkern/fluent-plugin-google-cloud/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pkern/fluent-plugin-google-cloud/statuses/{sha}","languages_url":"https://api.github.com/repos/pkern/fluent-plugin-google-cloud/languages","stargazers_url":"https://api.github.com/repos/pkern/fluent-plugin-google-cloud/stargazers","contributors_url":"https://api.github.com/repos/pkern/fluent-plugin-google-cloud/contributors","subscribers_url":"https://api.github.com/repos/pkern/fluent-plugin-google-cloud/subscribers","subscription_url":"https://api.github.com/repos/pkern/fluent-plugin-google-cloud/subscription","commits_url":"https://api.github.com/repos/pkern/fluent-plugin-google-cloud/commits{/sha}","git_commits_url":"https://api.github.com/repos/pkern/fluent-plugin-google-cloud/git/commits{/sha}","comments_url":"https://api.github.com/repos/pkern/fluent-plugin-google-cloud/comments{/number}","issue_comment_url":"https://api.github.com/repos/pkern/fluent-plugin-google-cloud/issues/comments{/number}","contents_url":"https://api.github.com/repos/pkern/fluent-plugin-google-cloud/contents/{+path}","compare_url":"https://api.github.com/repos/pkern/fluent-plugin-google-cloud/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pkern/fluent-plugin-google-cloud/merges","archive_url":"https://api.github.com/repos/pkern/fluent-plugin-google-cloud/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pkern/fluent-plugin-google-cloud/downloads","issues_url":"https://api.github.com/repos/pkern/fluent-plugin-google-cloud/issues{/number}","pulls_url":"https://api.github.com/repos/pkern/fluent-plugin-google-cloud/pulls{/number}","milestones_url":"https://api.github.com/repos/pkern/fluent-plugin-google-cloud/milestones{/number}","notifications_url":"https://api.github.com/repos/pkern/fluent-plugin-google-cloud/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pkern/fluent-plugin-google-cloud/labels{/name}","releases_url":"https://api.github.com/repos/pkern/fluent-plugin-google-cloud/releases{/id}","deployments_url":"https://api.github.com/repos/pkern/fluent-plugin-google-cloud/deployments","created_at":"2017-11-21T13:21:04Z","updated_at":"2017-11-21T13:21:06Z","pushed_at":"2017-11-22T02:08:35Z","git_url":"git://github.com/pkern/fluent-plugin-google-cloud.git","ssh_url":"git@github.com:pkern/fluent-plugin-google-cloud.git","clone_url":"https://github.com/pkern/fluent-plugin-google-cloud.git","svn_url":"https://github.com/pkern/fluent-plugin-google-cloud","homepage":null,"size":670,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"e13c89a1b6e0c33bac35435fe8e41d566ce52687","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":19799990,"name":"fluent-plugin-google-cloud","full_name":"GoogleCloudPlatform/fluent-plugin-google-cloud","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/fluent-plugin-google-cloud","description":"Plugin for Fluentd that sends logs to the Google Cloud Platform's log ingestion API.","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/deployments","created_at":"2014-05-14T23:46:51Z","updated_at":"2017-11-13T22:55:25Z","pushed_at":"2017-11-22T02:08:36Z","git_url":"git://github.com/GoogleCloudPlatform/fluent-plugin-google-cloud.git","ssh_url":"git@github.com:GoogleCloudPlatform/fluent-plugin-google-cloud.git","clone_url":"https://github.com/GoogleCloudPlatform/fluent-plugin-google-cloud.git","svn_url":"https://github.com/GoogleCloudPlatform/fluent-plugin-google-cloud","homepage":null,"size":668,"stargazers_count":88,"watchers_count":88,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":47,"mirror_url":null,"archived":false,"open_issues_count":31,"forks":47,"open_issues":31,"watchers":88,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/pulls/179"},"html":{"href":"https://github.com/GoogleCloudPlatform/fluent-plugin-google-cloud/pull/179"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/issues/179"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/issues/179/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/pulls/179/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/pulls/179/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/fluent-plugin-google-cloud/statuses/82912858e49ecc262361405db628129d77034f3d"}},"author_association":"NONE"}}
{"actor":{"display_login":"pkern"}}