{"action":"closed","issue":{"url":"https://api.github.com/repos/wix/react-native-navigation/issues/1511","repository_url":"https://api.github.com/repos/wix/react-native-navigation","labels_url":"https://api.github.com/repos/wix/react-native-navigation/issues/1511/labels{/name}","comments_url":"https://api.github.com/repos/wix/react-native-navigation/issues/1511/comments","events_url":"https://api.github.com/repos/wix/react-native-navigation/issues/1511/events","html_url":"https://github.com/wix/react-native-navigation/issues/1511","id":243231075,"number":1511,"title":"Dismiss Modal animationType 'fade' not supported/doesn't work","user":{"login":"EricYuen","id":4271026,"avatar_url":"https://avatars0.githubusercontent.com/u/4271026?v=4","gravatar_id":"","url":"https://api.github.com/users/EricYuen","html_url":"https://github.com/EricYuen","followers_url":"https://api.github.com/users/EricYuen/followers","following_url":"https://api.github.com/users/EricYuen/following{/other_user}","gists_url":"https://api.github.com/users/EricYuen/gists{/gist_id}","starred_url":"https://api.github.com/users/EricYuen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EricYuen/subscriptions","organizations_url":"https://api.github.com/users/EricYuen/orgs","repos_url":"https://api.github.com/users/EricYuen/repos","events_url":"https://api.github.com/users/EricYuen/events{/privacy}","received_events_url":"https://api.github.com/users/EricYuen/received_events","type":"User","site_admin":false},"labels":[{"id":417618844,"url":"https://api.github.com/repos/wix/react-native-navigation/labels/Bug%20-%20Android","name":"Bug - Android","color":"b60205","default":false},{"id":432287790,"url":"https://api.github.com/repos/wix/react-native-navigation/labels/Help%20wanted","name":"Help wanted","color":"fbca04","default":false}],"state":"closed","locked":false,"assignee":{"login":"guyca","id":12352397,"avatar_url":"https://avatars2.githubusercontent.com/u/12352397?v=4","gravatar_id":"","url":"https://api.github.com/users/guyca","html_url":"https://github.com/guyca","followers_url":"https://api.github.com/users/guyca/followers","following_url":"https://api.github.com/users/guyca/following{/other_user}","gists_url":"https://api.github.com/users/guyca/gists{/gist_id}","starred_url":"https://api.github.com/users/guyca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guyca/subscriptions","organizations_url":"https://api.github.com/users/guyca/orgs","repos_url":"https://api.github.com/users/guyca/repos","events_url":"https://api.github.com/users/guyca/events{/privacy}","received_events_url":"https://api.github.com/users/guyca/received_events","type":"User","site_admin":false},"assignees":[{"login":"guyca","id":12352397,"avatar_url":"https://avatars2.githubusercontent.com/u/12352397?v=4","gravatar_id":"","url":"https://api.github.com/users/guyca","html_url":"https://github.com/guyca","followers_url":"https://api.github.com/users/guyca/followers","following_url":"https://api.github.com/users/guyca/following{/other_user}","gists_url":"https://api.github.com/users/guyca/gists{/gist_id}","starred_url":"https://api.github.com/users/guyca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guyca/subscriptions","organizations_url":"https://api.github.com/users/guyca/orgs","repos_url":"https://api.github.com/users/guyca/repos","events_url":"https://api.github.com/users/guyca/events{/privacy}","received_events_url":"https://api.github.com/users/guyca/received_events","type":"User","site_admin":false}],"milestone":null,"comments":10,"created_at":"2017-07-16T10:30:21Z","updated_at":"2017-09-29T05:38:45Z","closed_at":"2017-09-29T05:38:45Z","author_association":"NONE","body":"### Dismiss Modal animationType 'fade' not supported/doesn't work\r\n\r\nI use `showModal()` with a fade animation to display a message and so it should correspondingly fade out when `dismissModal()`\r\n\r\nAlthough I don't see 'fade' being in specifically documented as supported for `showModal()`, this works properly.\r\n\r\n### Steps to Reproduce / Code Snippets / Screenshots\r\nI show a modal using the following in one screen.\r\n```\r\nthis.props.navigator.showModal({\r\n    screen: Screens.SCREEN_PAYWALL,\r\n    animationType: 'fade'\r\n});\r\n```\r\nThen in that screen I have a close button that calls the following\r\n```\r\nthis.props.navigator.dismissModal({\r\n    animationType: `fade`\r\n});\r\n```\r\nHowever, no matter what I do, it always dismisses using a slide-down animation. It uses the same slide-down animation if I use the back key on Android.\r\n\r\n**Update**: If I use `push` and `pop` instead, the fade in/out animations work.\r\n\r\n---\r\n### Environment\r\n* React Native Navigation version: 1.1.126\r\n* React Native version: 0.45.1\r\n* Platform(s) (iOS, Android, or both?): Android\r\n* Device info (Simulator/Device? OS version? Debug/Release?): Simulator Galaxy Nexus 5.1.1 API 22\r\n"}}
{"actor":{"display_login":"EricYuen"}}