{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/53363","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/53363/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/53363/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/53363/events","html_url":"https://github.com/kubernetes/kubernetes/pull/53363","id":262307327,"number":53363,"title":"cmd: genutils: remove entry from .golint_failures","user":{"login":"tcharding","id":12626037,"avatar_url":"https://avatars2.githubusercontent.com/u/12626037?v=4","gravatar_id":"","url":"https://api.github.com/users/tcharding","html_url":"https://github.com/tcharding","followers_url":"https://api.github.com/users/tcharding/followers","following_url":"https://api.github.com/users/tcharding/following{/other_user}","gists_url":"https://api.github.com/users/tcharding/gists{/gist_id}","starred_url":"https://api.github.com/users/tcharding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tcharding/subscriptions","organizations_url":"https://api.github.com/users/tcharding/orgs","repos_url":"https://api.github.com/users/tcharding/repos","events_url":"https://api.github.com/users/tcharding/events{/privacy}","received_events_url":"https://api.github.com/users/tcharding/received_events","type":"User","site_admin":false},"labels":[{"id":477397086,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":122775691,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/cleanup","name":"kind/cleanup","color":"c7def8","default":false},{"id":349530249,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":253450793,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/XS","name":"size/XS","color":"009900","default":false}],"state":"open","locked":false,"assignee":{"login":"gmarek","id":1703842,"avatar_url":"https://avatars0.githubusercontent.com/u/1703842?v=4","gravatar_id":"","url":"https://api.github.com/users/gmarek","html_url":"https://github.com/gmarek","followers_url":"https://api.github.com/users/gmarek/followers","following_url":"https://api.github.com/users/gmarek/following{/other_user}","gists_url":"https://api.github.com/users/gmarek/gists{/gist_id}","starred_url":"https://api.github.com/users/gmarek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmarek/subscriptions","organizations_url":"https://api.github.com/users/gmarek/orgs","repos_url":"https://api.github.com/users/gmarek/repos","events_url":"https://api.github.com/users/gmarek/events{/privacy}","received_events_url":"https://api.github.com/users/gmarek/received_events","type":"User","site_admin":false},"assignees":[{"login":"fejta","id":940341,"avatar_url":"https://avatars2.githubusercontent.com/u/940341?v=4","gravatar_id":"","url":"https://api.github.com/users/fejta","html_url":"https://github.com/fejta","followers_url":"https://api.github.com/users/fejta/followers","following_url":"https://api.github.com/users/fejta/following{/other_user}","gists_url":"https://api.github.com/users/fejta/gists{/gist_id}","starred_url":"https://api.github.com/users/fejta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fejta/subscriptions","organizations_url":"https://api.github.com/users/fejta/orgs","repos_url":"https://api.github.com/users/fejta/repos","events_url":"https://api.github.com/users/fejta/events{/privacy}","received_events_url":"https://api.github.com/users/fejta/received_events","type":"User","site_admin":false},{"login":"gmarek","id":1703842,"avatar_url":"https://avatars0.githubusercontent.com/u/1703842?v=4","gravatar_id":"","url":"https://api.github.com/users/gmarek","html_url":"https://github.com/gmarek","followers_url":"https://api.github.com/users/gmarek/followers","following_url":"https://api.github.com/users/gmarek/following{/other_user}","gists_url":"https://api.github.com/users/gmarek/gists{/gist_id}","starred_url":"https://api.github.com/users/gmarek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmarek/subscriptions","organizations_url":"https://api.github.com/users/gmarek/orgs","repos_url":"https://api.github.com/users/gmarek/repos","events_url":"https://api.github.com/users/gmarek/events{/privacy}","received_events_url":"https://api.github.com/users/gmarek/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2017-10-03T05:19:20Z","updated_at":"2017-10-05T03:14:02Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/53363","html_url":"https://github.com/kubernetes/kubernetes/pull/53363","diff_url":"https://github.com/kubernetes/kubernetes/pull/53363.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/53363.patch"},"body":"\r\n**What this PR does / why we need it**:\r\n\r\n`golint` emits warnings\r\n\r\n```\r\nexported function OutDir should have comment or be unexported\r\nstrings should not be capitalized or end with punctuation or a newline\r\n```\r\n\r\n- Add documentation comment to exported function OutDir.\r\n- Remove newline from error string.\r\n- Remove `hack\\.golint_failures` entry for `cmd/genutils`\r\n\r\n**Special notes for your reviewer**:\r\n   \r\nDon't know which sig to use?\r\n\r\n**Release note**:\r\n<!--  Steps to write your release note:\r\n1. Use the release-note-* labels to set the release note state (if you have access)\r\n2. Enter your extended release note in the below block; leaving it blank means using the PR title as the release note. If no release note is required, just write `NONE`.\r\n-->\r\n```release-note\r\nNONE\r\n```\r\n\r\n/kind cleanup"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/334347184","html_url":"https://github.com/kubernetes/kubernetes/pull/53363#issuecomment-334347184","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/53363","id":334347184,"user":{"login":"tcharding","id":12626037,"avatar_url":"https://avatars2.githubusercontent.com/u/12626037?v=4","gravatar_id":"","url":"https://api.github.com/users/tcharding","html_url":"https://github.com/tcharding","followers_url":"https://api.github.com/users/tcharding/followers","following_url":"https://api.github.com/users/tcharding/following{/other_user}","gists_url":"https://api.github.com/users/tcharding/gists{/gist_id}","starred_url":"https://api.github.com/users/tcharding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tcharding/subscriptions","organizations_url":"https://api.github.com/users/tcharding/orgs","repos_url":"https://api.github.com/users/tcharding/repos","events_url":"https://api.github.com/users/tcharding/events{/privacy}","received_events_url":"https://api.github.com/users/tcharding/received_events","type":"User","site_admin":false},"created_at":"2017-10-05T03:14:02Z","updated_at":"2017-10-05T03:14:02Z","author_association":"CONTRIBUTOR","body":"Running `golint` locally is not showing warnings for malformed error strings? Only caught this via the k8s CI."}}
{"actor":{"display_login":"tcharding"}}