{"action":"created","issue":{"url":"https://api.github.com/repos/RobotLocomotion/drake/issues/7538","repository_url":"https://api.github.com/repos/RobotLocomotion/drake","labels_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/7538/labels{/name}","comments_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/7538/comments","events_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/7538/events","html_url":"https://github.com/RobotLocomotion/drake/pull/7538","id":277974739,"number":7538,"title":"Adding a sine wave primitive system.","user":{"login":"rcory","id":6761349,"avatar_url":"https://avatars3.githubusercontent.com/u/6761349?v=4","gravatar_id":"","url":"https://api.github.com/users/rcory","html_url":"https://github.com/rcory","followers_url":"https://api.github.com/users/rcory/followers","following_url":"https://api.github.com/users/rcory/following{/other_user}","gists_url":"https://api.github.com/users/rcory/gists{/gist_id}","starred_url":"https://api.github.com/users/rcory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rcory/subscriptions","organizations_url":"https://api.github.com/users/rcory/orgs","repos_url":"https://api.github.com/users/rcory/repos","events_url":"https://api.github.com/users/rcory/events{/privacy}","received_events_url":"https://api.github.com/users/rcory/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"edrumwri","id":2224335,"avatar_url":"https://avatars0.githubusercontent.com/u/2224335?v=4","gravatar_id":"","url":"https://api.github.com/users/edrumwri","html_url":"https://github.com/edrumwri","followers_url":"https://api.github.com/users/edrumwri/followers","following_url":"https://api.github.com/users/edrumwri/following{/other_user}","gists_url":"https://api.github.com/users/edrumwri/gists{/gist_id}","starred_url":"https://api.github.com/users/edrumwri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edrumwri/subscriptions","organizations_url":"https://api.github.com/users/edrumwri/orgs","repos_url":"https://api.github.com/users/edrumwri/repos","events_url":"https://api.github.com/users/edrumwri/events{/privacy}","received_events_url":"https://api.github.com/users/edrumwri/received_events","type":"User","site_admin":false},"assignees":[{"login":"edrumwri","id":2224335,"avatar_url":"https://avatars0.githubusercontent.com/u/2224335?v=4","gravatar_id":"","url":"https://api.github.com/users/edrumwri","html_url":"https://github.com/edrumwri","followers_url":"https://api.github.com/users/edrumwri/followers","following_url":"https://api.github.com/users/edrumwri/following{/other_user}","gists_url":"https://api.github.com/users/edrumwri/gists{/gist_id}","starred_url":"https://api.github.com/users/edrumwri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edrumwri/subscriptions","organizations_url":"https://api.github.com/users/edrumwri/orgs","repos_url":"https://api.github.com/users/edrumwri/repos","events_url":"https://api.github.com/users/edrumwri/events{/privacy}","received_events_url":"https://api.github.com/users/edrumwri/received_events","type":"User","site_admin":false},{"login":"sherm1","id":4088016,"avatar_url":"https://avatars1.githubusercontent.com/u/4088016?v=4","gravatar_id":"","url":"https://api.github.com/users/sherm1","html_url":"https://github.com/sherm1","followers_url":"https://api.github.com/users/sherm1/followers","following_url":"https://api.github.com/users/sherm1/following{/other_user}","gists_url":"https://api.github.com/users/sherm1/gists{/gist_id}","starred_url":"https://api.github.com/users/sherm1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sherm1/subscriptions","organizations_url":"https://api.github.com/users/sherm1/orgs","repos_url":"https://api.github.com/users/sherm1/repos","events_url":"https://api.github.com/users/sherm1/events{/privacy}","received_events_url":"https://api.github.com/users/sherm1/received_events","type":"User","site_admin":false}],"milestone":null,"comments":7,"created_at":"2017-11-30T02:15:07Z","updated_at":"2017-12-09T00:46:29Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/RobotLocomotion/drake/pulls/7538","html_url":"https://github.com/RobotLocomotion/drake/pull/7538","diff_url":"https://github.com/RobotLocomotion/drake/pull/7538.diff","patch_url":"https://github.com/RobotLocomotion/drake/pull/7538.patch"},"body":"\n\n<!-- Reviewable:start -->\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/robotlocomotion/drake/7538)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/RobotLocomotion/drake/issues/comments/350408404","html_url":"https://github.com/RobotLocomotion/drake/pull/7538#issuecomment-350408404","issue_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/7538","id":350408404,"user":{"login":"rcory","id":6761349,"avatar_url":"https://avatars3.githubusercontent.com/u/6761349?v=4","gravatar_id":"","url":"https://api.github.com/users/rcory","html_url":"https://github.com/rcory","followers_url":"https://api.github.com/users/rcory/followers","following_url":"https://api.github.com/users/rcory/following{/other_user}","gists_url":"https://api.github.com/users/rcory/gists{/gist_id}","starred_url":"https://api.github.com/users/rcory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rcory/subscriptions","organizations_url":"https://api.github.com/users/rcory/orgs","repos_url":"https://api.github.com/users/rcory/repos","events_url":"https://api.github.com/users/rcory/events{/privacy}","received_events_url":"https://api.github.com/users/rcory/received_events","type":"User","site_admin":false},"created_at":"2017-12-09T00:46:29Z","updated_at":"2017-12-09T00:46:29Z","author_association":"CONTRIBUTOR","body":"+@sherm1 for platform review please.\n\n---\n\nReview status: 3 of 5 files reviewed at latest revision, 2 unresolved discussions.\n\n---\n\n*[systems/primitives/test/sine_test.cc, line 65 at r4](https://reviewable.io:443/reviews/robotlocomotion/drake/7538#-L-sKFDRQsOAURnHsfWb:-L-simISMaXqOrEOC3cz:bg3ksrj) ([raw file](https://github.com/robotlocomotion/drake/blob/7340abea20153ac72a4db216f9d080b0996b39d3/systems/primitives/test/sine_test.cc#L65)):*\n<details><summary><i>Previously, edrumwri (Evan Drumwright) wrote…</i></summary><blockquote>\n\nBTW Please replace the 1e-3's here and below with a named tolerance value. Also, please explain why the tolerance is so loose (you're providing answers with four digits of precision).\n</blockquote></details>\n\nGlad you pointed this out. I'll update these to be more clear.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/robotlocomotion/drake/7538#-:-L-sj2xyQQbOdwAAy553:b6vi582)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"rcory"}}