{"action":"created","issue":{"url":"https://api.github.com/repos/shazow/urllib3/issues/1016","repository_url":"https://api.github.com/repos/shazow/urllib3","labels_url":"https://api.github.com/repos/shazow/urllib3/issues/1016/labels{/name}","comments_url":"https://api.github.com/repos/shazow/urllib3/issues/1016/comments","events_url":"https://api.github.com/repos/shazow/urllib3/issues/1016/events","html_url":"https://github.com/shazow/urllib3/pull/1016","id":186143553,"number":1016,"title":"The ``connection_from_*`` methods now accept pool_kwargs","user":{"login":"jeremycline","id":1977525,"avatar_url":"https://avatars2.githubusercontent.com/u/1977525?v=3","gravatar_id":"","url":"https://api.github.com/users/jeremycline","html_url":"https://github.com/jeremycline","followers_url":"https://api.github.com/users/jeremycline/followers","following_url":"https://api.github.com/users/jeremycline/following{/other_user}","gists_url":"https://api.github.com/users/jeremycline/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremycline/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremycline/subscriptions","organizations_url":"https://api.github.com/users/jeremycline/orgs","repos_url":"https://api.github.com/users/jeremycline/repos","events_url":"https://api.github.com/users/jeremycline/events{/privacy}","received_events_url":"https://api.github.com/users/jeremycline/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":13,"created_at":"2016-10-30T15:42:25Z","updated_at":"2017-03-23T17:25:34Z","closed_at":"2017-03-23T17:13:44Z","pull_request":{"url":"https://api.github.com/repos/shazow/urllib3/pulls/1016","html_url":"https://github.com/shazow/urllib3/pull/1016","diff_url":"https://github.com/shazow/urllib3/pull/1016.diff","patch_url":"https://github.com/shazow/urllib3/pull/1016.patch"},"body":"This adds the ability to override the connection pool keyword arguments\nused when constructing new pools in the `connection_from_*` methods. A\nnew keyword argument, `pool_kwargs`, is accepted by methods in\n`PoolManager`. This is nice because without it, users that want to\nchange these arguments (when, say, adjusting SSL configurations) need to\nmake sure they update the keyword arguments and get a new pool in a\nthread-safe manner.\n\nThis is a somewhat more invasive version of the patch on https://github.com/kennethreitz/requests/issues/3633 since people (reasonably) were surprised to see the instance's `connection_pool_kw` modified. I'm still not completely pleased with this change for a few reasons:\n- If I provide some override `pool_kwargs` and a new pool doesn't need to be created (the `pool_kwargs` aren't fields in the pool key), they will be ignored. That seems like it will surprise users.\n- A huge number of methods grew a new kwarg that gets passed down the chain of function calls, which is a little sad.\n"},"comment":{"url":"https://api.github.com/repos/shazow/urllib3/issues/comments/288796699","html_url":"https://github.com/shazow/urllib3/pull/1016#issuecomment-288796699","issue_url":"https://api.github.com/repos/shazow/urllib3/issues/1016","id":288796699,"user":{"login":"jeremycline","id":1977525,"avatar_url":"https://avatars2.githubusercontent.com/u/1977525?v=3","gravatar_id":"","url":"https://api.github.com/users/jeremycline","html_url":"https://github.com/jeremycline","followers_url":"https://api.github.com/users/jeremycline/followers","following_url":"https://api.github.com/users/jeremycline/following{/other_user}","gists_url":"https://api.github.com/users/jeremycline/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremycline/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremycline/subscriptions","organizations_url":"https://api.github.com/users/jeremycline/orgs","repos_url":"https://api.github.com/users/jeremycline/repos","events_url":"https://api.github.com/users/jeremycline/events{/privacy}","received_events_url":"https://api.github.com/users/jeremycline/received_events","type":"User","site_admin":false},"created_at":"2017-03-23T17:25:34Z","updated_at":"2017-03-23T17:25:34Z","body":"Thanks! I couldn't have done it without all the reviews and feedback, so many thanks to everyone for those."}}
{"actor":{"display_login":"jeremycline"}}