{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla-services/autopush/issues/988","repository_url":"https://api.github.com/repos/mozilla-services/autopush","labels_url":"https://api.github.com/repos/mozilla-services/autopush/issues/988/labels{/name}","comments_url":"https://api.github.com/repos/mozilla-services/autopush/issues/988/comments","events_url":"https://api.github.com/repos/mozilla-services/autopush/issues/988/events","html_url":"https://github.com/mozilla-services/autopush/pull/988","id":246887883,"number":988,"title":"settings -> config (or conf)","user":{"login":"pjenvey","id":14639,"avatar_url":"https://avatars2.githubusercontent.com/u/14639?v=4","gravatar_id":"","url":"https://api.github.com/users/pjenvey","html_url":"https://github.com/pjenvey","followers_url":"https://api.github.com/users/pjenvey/followers","following_url":"https://api.github.com/users/pjenvey/following{/other_user}","gists_url":"https://api.github.com/users/pjenvey/gists{/gist_id}","starred_url":"https://api.github.com/users/pjenvey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pjenvey/subscriptions","organizations_url":"https://api.github.com/users/pjenvey/orgs","repos_url":"https://api.github.com/users/pjenvey/repos","events_url":"https://api.github.com/users/pjenvey/events{/privacy}","received_events_url":"https://api.github.com/users/pjenvey/received_events","type":"User","site_admin":false},"labels":[{"id":273116523,"url":"https://api.github.com/repos/mozilla-services/autopush/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-07-31T21:19:47Z","updated_at":"2017-07-31T21:26:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mozilla-services/autopush/pulls/988","html_url":"https://github.com/mozilla-services/autopush/pull/988","diff_url":"https://github.com/mozilla-services/autopush/pull/988.diff","patch_url":"https://github.com/mozilla-services/autopush/pull/988.patch"},"body":"everything's .conf for shorthand, otherwise\r\nand Settings -> Config\r\n\r\nrouters previously used '.conf' naming for their router_confs, they are now .router_conf to not conflict (for now)\r\n\r\nreviewing each individual commit will probably be easier\r\n\r\n(don't squash these commits either, to encourage git to save commit history in config.py)"},"comment":{"url":"https://api.github.com/repos/mozilla-services/autopush/issues/comments/319201419","html_url":"https://github.com/mozilla-services/autopush/pull/988#issuecomment-319201419","issue_url":"https://api.github.com/repos/mozilla-services/autopush/issues/988","id":319201419,"user":{"login":"codecov-io","id":8655789,"avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2017-07-31T21:26:44Z","updated_at":"2017-07-31T21:26:44Z","body":"# [Codecov](https://codecov.io/gh/mozilla-services/autopush/pull/988?src=pr&el=h1) Report\n> Merging [#988](https://codecov.io/gh/mozilla-services/autopush/pull/988?src=pr&el=desc) into [master](https://codecov.io/gh/mozilla-services/autopush/commit/ce11f84a96dce5635fd5ac5165acd9fdef07b5d6?src=pr&el=desc) will **not change** coverage.\n> The diff coverage is `100%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/mozilla-services/autopush/pull/988/graphs/tree.svg?width=650&height=150&token=nlzCesPszw&src=pr)](https://codecov.io/gh/mozilla-services/autopush/pull/988?src=pr&el=tree)\n\n```diff\n@@          Coverage Diff          @@\n##           master   #988   +/-   ##\n=====================================\n  Coverage     100%   100%           \n=====================================\n  Files          57     57           \n  Lines        9598   9597    -1     \n=====================================\n- Hits         9598   9597    -1\n```\n\n\n| [Impacted Files](https://codecov.io/gh/mozilla-services/autopush/pull/988?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [autopush/web/base.py](https://codecov.io/gh/mozilla-services/autopush/pull/988?src=pr&el=tree#diff-YXV0b3B1c2gvd2ViL2Jhc2UucHk=) | `100% <ø> (ø)` | :arrow_up: |\n| [autopush/web/message.py](https://codecov.io/gh/mozilla-services/autopush/pull/988?src=pr&el=tree#diff-YXV0b3B1c2gvd2ViL21lc3NhZ2UucHk=) | `100% <ø> (ø)` | :arrow_up: |\n| [autopush/exceptions.py](https://codecov.io/gh/mozilla-services/autopush/pull/988?src=pr&el=tree#diff-YXV0b3B1c2gvZXhjZXB0aW9ucy5weQ==) | `100% <100%> (ø)` | :arrow_up: |\n| [autopush/main.py](https://codecov.io/gh/mozilla-services/autopush/pull/988?src=pr&el=tree#diff-YXV0b3B1c2gvbWFpbi5weQ==) | `100% <100%> (ø)` | :arrow_up: |\n| [autopush/tests/test\\_router.py](https://codecov.io/gh/mozilla-services/autopush/pull/988?src=pr&el=tree#diff-YXV0b3B1c2gvdGVzdHMvdGVzdF9yb3V0ZXIucHk=) | `100% <100%> (ø)` | :arrow_up: |\n| [autopush/tests/test\\_health.py](https://codecov.io/gh/mozilla-services/autopush/pull/988?src=pr&el=tree#diff-YXV0b3B1c2gvdGVzdHMvdGVzdF9oZWFsdGgucHk=) | `100% <100%> (ø)` | :arrow_up: |\n| [autopush/web/simplepush.py](https://codecov.io/gh/mozilla-services/autopush/pull/988?src=pr&el=tree#diff-YXV0b3B1c2gvd2ViL3NpbXBsZXB1c2gucHk=) | `100% <100%> (ø)` | :arrow_up: |\n| [autopush/config.py](https://codecov.io/gh/mozilla-services/autopush/pull/988?src=pr&el=tree#diff-YXV0b3B1c2gvY29uZmlnLnB5) | `100% <100%> (ø)` | |\n| [autopush/router/interface.py](https://codecov.io/gh/mozilla-services/autopush/pull/988?src=pr&el=tree#diff-YXV0b3B1c2gvcm91dGVyL2ludGVyZmFjZS5weQ==) | `100% <100%> (ø)` | :arrow_up: |\n| [autopush/router/fcm.py](https://codecov.io/gh/mozilla-services/autopush/pull/988?src=pr&el=tree#diff-YXV0b3B1c2gvcm91dGVyL2ZjbS5weQ==) | `100% <100%> (ø)` | :arrow_up: |\n| ... and [22 more](https://codecov.io/gh/mozilla-services/autopush/pull/988?src=pr&el=tree-more) | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/mozilla-services/autopush/pull/988?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/mozilla-services/autopush/pull/988?src=pr&el=footer). Last update [ce11f84...24c0ec8](https://codecov.io/gh/mozilla-services/autopush/pull/988?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov-io"}}