{"action":"created","issue":{"url":"https://api.github.com/repos/davidgatti/How-to-Stream-Movies-using-NodeJS/issues/3","repository_url":"https://api.github.com/repos/davidgatti/How-to-Stream-Movies-using-NodeJS","labels_url":"https://api.github.com/repos/davidgatti/How-to-Stream-Movies-using-NodeJS/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/davidgatti/How-to-Stream-Movies-using-NodeJS/issues/3/comments","events_url":"https://api.github.com/repos/davidgatti/How-to-Stream-Movies-using-NodeJS/issues/3/events","html_url":"https://github.com/davidgatti/How-to-Stream-Movies-using-NodeJS/pull/3","id":215708981,"number":3,"title":"Done some style and syntax changes..","user":{"login":"shivarajnaidu","id":12374494,"avatar_url":"https://avatars2.githubusercontent.com/u/12374494?v=3","gravatar_id":"","url":"https://api.github.com/users/shivarajnaidu","html_url":"https://github.com/shivarajnaidu","followers_url":"https://api.github.com/users/shivarajnaidu/followers","following_url":"https://api.github.com/users/shivarajnaidu/following{/other_user}","gists_url":"https://api.github.com/users/shivarajnaidu/gists{/gist_id}","starred_url":"https://api.github.com/users/shivarajnaidu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shivarajnaidu/subscriptions","organizations_url":"https://api.github.com/users/shivarajnaidu/orgs","repos_url":"https://api.github.com/users/shivarajnaidu/repos","events_url":"https://api.github.com/users/shivarajnaidu/events{/privacy}","received_events_url":"https://api.github.com/users/shivarajnaidu/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-03-21T11:37:39Z","updated_at":"2017-03-21T17:40:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/davidgatti/How-to-Stream-Movies-using-NodeJS/pulls/3","html_url":"https://github.com/davidgatti/How-to-Stream-Movies-using-NodeJS/pull/3","diff_url":"https://github.com/davidgatti/How-to-Stream-Movies-using-NodeJS/pull/3.diff","patch_url":"https://github.com/davidgatti/How-to-Stream-Movies-using-NodeJS/pull/3.patch"},"body":"1. Added `use strict` statement...\r\n1. corrected inconsistent usage of quotes(all with single quotes)\r\n1. replaced old function definitions with arrow functions ..\r\n1. replaced let in import statements with const\r\n1. used === instead of == for equality checking..."},"comment":{"url":"https://api.github.com/repos/davidgatti/How-to-Stream-Movies-using-NodeJS/issues/comments/288159715","html_url":"https://github.com/davidgatti/How-to-Stream-Movies-using-NodeJS/pull/3#issuecomment-288159715","issue_url":"https://api.github.com/repos/davidgatti/How-to-Stream-Movies-using-NodeJS/issues/3","id":288159715,"user":{"login":"davidgatti","id":411114,"avatar_url":"https://avatars2.githubusercontent.com/u/411114?v=3","gravatar_id":"","url":"https://api.github.com/users/davidgatti","html_url":"https://github.com/davidgatti","followers_url":"https://api.github.com/users/davidgatti/followers","following_url":"https://api.github.com/users/davidgatti/following{/other_user}","gists_url":"https://api.github.com/users/davidgatti/gists{/gist_id}","starred_url":"https://api.github.com/users/davidgatti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidgatti/subscriptions","organizations_url":"https://api.github.com/users/davidgatti/orgs","repos_url":"https://api.github.com/users/davidgatti/repos","events_url":"https://api.github.com/users/davidgatti/events{/privacy}","received_events_url":"https://api.github.com/users/davidgatti/received_events","type":"User","site_admin":false},"created_at":"2017-03-21T17:40:32Z","updated_at":"2017-03-21T17:40:32Z","body":"Hello @shivarajnaidu nice to see that you are a passionate developer, and that you care enough to spend the time on my article. \r\n\r\nYour pull request is much appreciate, but only part of it. Let me explain: this is not a a project but rather an article target at any level of experience, meaning I want to make my article to be understood by beginners. That is why I can't accept part of your PR. \r\n\r\n# What I can't accept\r\n\r\n## Strict mode\r\n\r\nUnnecessary with the latest version of NodeJS. I be surprised if on your system you still have some old version of NodeJS :) \r\n\r\n## Arrow functions\r\n\r\nThose things are the 😈 😂. They make the code look so unclear and confusing that it is not even funny, sure they might look cool, but when it comes to code, to me being able to reason and understand whats in front of my eyes is paramount. I'll keep using the well know syntax until NodeJS will force me to use Arrows 🤣.\r\n\r\n## Let vs. Const\r\n\r\nThis is something that is a complete over kill in this case and 99% of developers won't know what that is and how to use it correctly anyway. Since this an article made to teach I want to keep confusion out of the way.\r\n\r\n## Equality check\r\n\r\nThis again fails in to the, lets not confuse people to much. This is an article and not a project that will be used in production\r\n\r\n# What I can accept \r\n\r\n## Quotation\r\n\r\nSure, that is a good idea for consistency\r\n\r\n# If are still with me \r\n\r\nThere is a big chance that you just throw your computer out the window, and shouted some bad words towards me ;) but this is life. I hope my reasoning is clear and make sense. Simplicity of code to me is the most important thing, especially when it comes to articles. \r\n\r\nIf you would still contribute to the article, please make a PR for the quotations, and I'll gladly accept it. "}}
{"actor":{"display_login":"davidgatti"}}