{"action":"created","comment":{"url":"https://api.github.com/repos/cilium/cilium/pulls/comments/147539571","pull_request_review_id":72038564,"id":147539571,"diff_hunk":"@@ -293,10 +309,28 @@ type PortProtocol struct {\n \tProtocol L4Proto `json:\"protocol,omitempty\"`\n }\n \n+// IngressVisibilityRule ensures the ingress traffic to a set of L4 ports is\n+// forwarded at L7 for the purpose of logging requests and responses into the\n+// access log.\n+// Only the traffic to the ports that is allowed by policy at L3 and L4 is\n+// visible.\n+type IngressVisibilityRule struct {\n+\t// ToPorts is a list of L4 port/protocol.\n+\t//\n+\t// +optional\n+\tToPorts []PortProtocol `json:\"toPorts,omitempty\"`\n+\n+\t// L7Protocol identifies the L7 protocol of the ingress traffic to the\n+\t// ports. Case insensitive. Accepted values: \"http\", \"kafka\".\n+\t//\n+\t// +optional","path":"pkg/policy/api/rule.go","position":66,"original_position":57,"commit_id":"6b38f1282ab63b701c288e04aeadcc6464f2da31","original_commit_id":"536c1e2c06a133e8b3b3997ef801c8d23b19b332","user":{"login":"tgraf","id":1417913,"avatar_url":"https://avatars1.githubusercontent.com/u/1417913?v=4","gravatar_id":"","url":"https://api.github.com/users/tgraf","html_url":"https://github.com/tgraf","followers_url":"https://api.github.com/users/tgraf/followers","following_url":"https://api.github.com/users/tgraf/following{/other_user}","gists_url":"https://api.github.com/users/tgraf/gists{/gist_id}","starred_url":"https://api.github.com/users/tgraf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgraf/subscriptions","organizations_url":"https://api.github.com/users/tgraf/orgs","repos_url":"https://api.github.com/users/tgraf/repos","events_url":"https://api.github.com/users/tgraf/events{/privacy}","received_events_url":"https://api.github.com/users/tgraf/received_events","type":"User","site_admin":false},"body":"Is this really optional? Sanitize seems to enforce that this value is either http or kafka.","created_at":"2017-10-28T00:17:54Z","updated_at":"2017-10-28T00:28:57Z","html_url":"https://github.com/cilium/cilium/pull/1540#discussion_r147539571","pull_request_url":"https://api.github.com/repos/cilium/cilium/pulls/1540","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/cilium/cilium/pulls/comments/147539571"},"html":{"href":"https://github.com/cilium/cilium/pull/1540#discussion_r147539571"},"pull_request":{"href":"https://api.github.com/repos/cilium/cilium/pulls/1540"}}},"pull_request":{"url":"https://api.github.com/repos/cilium/cilium/pulls/1540","id":141743609,"html_url":"https://github.com/cilium/cilium/pull/1540","diff_url":"https://github.com/cilium/cilium/pull/1540.diff","patch_url":"https://github.com/cilium/cilium/pull/1540.patch","issue_url":"https://api.github.com/repos/cilium/cilium/issues/1540","number":1540,"state":"open","locked":false,"title":"Define new \"ingressVisibility\" rule type","user":{"login":"rlenglet","id":126329,"avatar_url":"https://avatars3.githubusercontent.com/u/126329?v=4","gravatar_id":"","url":"https://api.github.com/users/rlenglet","html_url":"https://github.com/rlenglet","followers_url":"https://api.github.com/users/rlenglet/followers","following_url":"https://api.github.com/users/rlenglet/following{/other_user}","gists_url":"https://api.github.com/users/rlenglet/gists{/gist_id}","starred_url":"https://api.github.com/users/rlenglet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rlenglet/subscriptions","organizations_url":"https://api.github.com/users/rlenglet/orgs","repos_url":"https://api.github.com/users/rlenglet/repos","events_url":"https://api.github.com/users/rlenglet/events{/privacy}","received_events_url":"https://api.github.com/users/rlenglet/received_events","type":"User","site_admin":false},"body":"Define a new \"ingressVisibility\" rule type to forward ingress traffic to\r\nL4 ports through the L7 proxy for access logging.\r\n    \r\nCompute the list of all active ingress visibility rules for each\r\nL4 port, and report them in the endpoint policy API.\r\n\r\nSigned-off-by: Romain Lenglet <romain@covalent.io>","created_at":"2017-09-19T02:19:02Z","updated_at":"2017-10-28T00:28:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"53c62ad3a17801a97c3501e7ae08bfdf86ad2503","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/cilium/cilium/pulls/1540/commits","review_comments_url":"https://api.github.com/repos/cilium/cilium/pulls/1540/comments","review_comment_url":"https://api.github.com/repos/cilium/cilium/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cilium/cilium/issues/1540/comments","statuses_url":"https://api.github.com/repos/cilium/cilium/statuses/6b38f1282ab63b701c288e04aeadcc6464f2da31","head":{"label":"cilium:l7-visibility-rules","ref":"l7-visibility-rules","sha":"6b38f1282ab63b701c288e04aeadcc6464f2da31","user":{"login":"cilium","id":21054566,"avatar_url":"https://avatars0.githubusercontent.com/u/21054566?v=4","gravatar_id":"","url":"https://api.github.com/users/cilium","html_url":"https://github.com/cilium","followers_url":"https://api.github.com/users/cilium/followers","following_url":"https://api.github.com/users/cilium/following{/other_user}","gists_url":"https://api.github.com/users/cilium/gists{/gist_id}","starred_url":"https://api.github.com/users/cilium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cilium/subscriptions","organizations_url":"https://api.github.com/users/cilium/orgs","repos_url":"https://api.github.com/users/cilium/repos","events_url":"https://api.github.com/users/cilium/events{/privacy}","received_events_url":"https://api.github.com/users/cilium/received_events","type":"Organization","site_admin":false},"repo":{"id":48109239,"name":"cilium","full_name":"cilium/cilium","owner":{"login":"cilium","id":21054566,"avatar_url":"https://avatars0.githubusercontent.com/u/21054566?v=4","gravatar_id":"","url":"https://api.github.com/users/cilium","html_url":"https://github.com/cilium","followers_url":"https://api.github.com/users/cilium/followers","following_url":"https://api.github.com/users/cilium/following{/other_user}","gists_url":"https://api.github.com/users/cilium/gists{/gist_id}","starred_url":"https://api.github.com/users/cilium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cilium/subscriptions","organizations_url":"https://api.github.com/users/cilium/orgs","repos_url":"https://api.github.com/users/cilium/repos","events_url":"https://api.github.com/users/cilium/events{/privacy}","received_events_url":"https://api.github.com/users/cilium/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cilium/cilium","description":"Linux Native, HTTP Aware Networking and Security for Containers","fork":false,"url":"https://api.github.com/repos/cilium/cilium","forks_url":"https://api.github.com/repos/cilium/cilium/forks","keys_url":"https://api.github.com/repos/cilium/cilium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cilium/cilium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cilium/cilium/teams","hooks_url":"https://api.github.com/repos/cilium/cilium/hooks","issue_events_url":"https://api.github.com/repos/cilium/cilium/issues/events{/number}","events_url":"https://api.github.com/repos/cilium/cilium/events","assignees_url":"https://api.github.com/repos/cilium/cilium/assignees{/user}","branches_url":"https://api.github.com/repos/cilium/cilium/branches{/branch}","tags_url":"https://api.github.com/repos/cilium/cilium/tags","blobs_url":"https://api.github.com/repos/cilium/cilium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cilium/cilium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cilium/cilium/git/refs{/sha}","trees_url":"https://api.github.com/repos/cilium/cilium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cilium/cilium/statuses/{sha}","languages_url":"https://api.github.com/repos/cilium/cilium/languages","stargazers_url":"https://api.github.com/repos/cilium/cilium/stargazers","contributors_url":"https://api.github.com/repos/cilium/cilium/contributors","subscribers_url":"https://api.github.com/repos/cilium/cilium/subscribers","subscription_url":"https://api.github.com/repos/cilium/cilium/subscription","commits_url":"https://api.github.com/repos/cilium/cilium/commits{/sha}","git_commits_url":"https://api.github.com/repos/cilium/cilium/git/commits{/sha}","comments_url":"https://api.github.com/repos/cilium/cilium/comments{/number}","issue_comment_url":"https://api.github.com/repos/cilium/cilium/issues/comments{/number}","contents_url":"https://api.github.com/repos/cilium/cilium/contents/{+path}","compare_url":"https://api.github.com/repos/cilium/cilium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cilium/cilium/merges","archive_url":"https://api.github.com/repos/cilium/cilium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cilium/cilium/downloads","issues_url":"https://api.github.com/repos/cilium/cilium/issues{/number}","pulls_url":"https://api.github.com/repos/cilium/cilium/pulls{/number}","milestones_url":"https://api.github.com/repos/cilium/cilium/milestones{/number}","notifications_url":"https://api.github.com/repos/cilium/cilium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cilium/cilium/labels{/name}","releases_url":"https://api.github.com/repos/cilium/cilium/releases{/id}","deployments_url":"https://api.github.com/repos/cilium/cilium/deployments","created_at":"2015-12-16T12:33:31Z","updated_at":"2017-10-27T13:34:54Z","pushed_at":"2017-10-27T23:35:32Z","git_url":"git://github.com/cilium/cilium.git","ssh_url":"git@github.com:cilium/cilium.git","clone_url":"https://github.com/cilium/cilium.git","svn_url":"https://github.com/cilium/cilium","homepage":"","size":88778,"stargazers_count":1111,"watchers_count":1111,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":115,"mirror_url":null,"archived":false,"open_issues_count":291,"forks":115,"open_issues":291,"watchers":1111,"default_branch":"master"}},"base":{"label":"cilium:master","ref":"master","sha":"a992a4445748920cb69c644262fd2bb8fa31b7d8","user":{"login":"cilium","id":21054566,"avatar_url":"https://avatars0.githubusercontent.com/u/21054566?v=4","gravatar_id":"","url":"https://api.github.com/users/cilium","html_url":"https://github.com/cilium","followers_url":"https://api.github.com/users/cilium/followers","following_url":"https://api.github.com/users/cilium/following{/other_user}","gists_url":"https://api.github.com/users/cilium/gists{/gist_id}","starred_url":"https://api.github.com/users/cilium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cilium/subscriptions","organizations_url":"https://api.github.com/users/cilium/orgs","repos_url":"https://api.github.com/users/cilium/repos","events_url":"https://api.github.com/users/cilium/events{/privacy}","received_events_url":"https://api.github.com/users/cilium/received_events","type":"Organization","site_admin":false},"repo":{"id":48109239,"name":"cilium","full_name":"cilium/cilium","owner":{"login":"cilium","id":21054566,"avatar_url":"https://avatars0.githubusercontent.com/u/21054566?v=4","gravatar_id":"","url":"https://api.github.com/users/cilium","html_url":"https://github.com/cilium","followers_url":"https://api.github.com/users/cilium/followers","following_url":"https://api.github.com/users/cilium/following{/other_user}","gists_url":"https://api.github.com/users/cilium/gists{/gist_id}","starred_url":"https://api.github.com/users/cilium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cilium/subscriptions","organizations_url":"https://api.github.com/users/cilium/orgs","repos_url":"https://api.github.com/users/cilium/repos","events_url":"https://api.github.com/users/cilium/events{/privacy}","received_events_url":"https://api.github.com/users/cilium/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cilium/cilium","description":"Linux Native, HTTP Aware Networking and Security for Containers","fork":false,"url":"https://api.github.com/repos/cilium/cilium","forks_url":"https://api.github.com/repos/cilium/cilium/forks","keys_url":"https://api.github.com/repos/cilium/cilium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cilium/cilium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cilium/cilium/teams","hooks_url":"https://api.github.com/repos/cilium/cilium/hooks","issue_events_url":"https://api.github.com/repos/cilium/cilium/issues/events{/number}","events_url":"https://api.github.com/repos/cilium/cilium/events","assignees_url":"https://api.github.com/repos/cilium/cilium/assignees{/user}","branches_url":"https://api.github.com/repos/cilium/cilium/branches{/branch}","tags_url":"https://api.github.com/repos/cilium/cilium/tags","blobs_url":"https://api.github.com/repos/cilium/cilium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cilium/cilium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cilium/cilium/git/refs{/sha}","trees_url":"https://api.github.com/repos/cilium/cilium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cilium/cilium/statuses/{sha}","languages_url":"https://api.github.com/repos/cilium/cilium/languages","stargazers_url":"https://api.github.com/repos/cilium/cilium/stargazers","contributors_url":"https://api.github.com/repos/cilium/cilium/contributors","subscribers_url":"https://api.github.com/repos/cilium/cilium/subscribers","subscription_url":"https://api.github.com/repos/cilium/cilium/subscription","commits_url":"https://api.github.com/repos/cilium/cilium/commits{/sha}","git_commits_url":"https://api.github.com/repos/cilium/cilium/git/commits{/sha}","comments_url":"https://api.github.com/repos/cilium/cilium/comments{/number}","issue_comment_url":"https://api.github.com/repos/cilium/cilium/issues/comments{/number}","contents_url":"https://api.github.com/repos/cilium/cilium/contents/{+path}","compare_url":"https://api.github.com/repos/cilium/cilium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cilium/cilium/merges","archive_url":"https://api.github.com/repos/cilium/cilium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cilium/cilium/downloads","issues_url":"https://api.github.com/repos/cilium/cilium/issues{/number}","pulls_url":"https://api.github.com/repos/cilium/cilium/pulls{/number}","milestones_url":"https://api.github.com/repos/cilium/cilium/milestones{/number}","notifications_url":"https://api.github.com/repos/cilium/cilium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cilium/cilium/labels{/name}","releases_url":"https://api.github.com/repos/cilium/cilium/releases{/id}","deployments_url":"https://api.github.com/repos/cilium/cilium/deployments","created_at":"2015-12-16T12:33:31Z","updated_at":"2017-10-27T13:34:54Z","pushed_at":"2017-10-27T23:35:32Z","git_url":"git://github.com/cilium/cilium.git","ssh_url":"git@github.com:cilium/cilium.git","clone_url":"https://github.com/cilium/cilium.git","svn_url":"https://github.com/cilium/cilium","homepage":"","size":88778,"stargazers_count":1111,"watchers_count":1111,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":115,"mirror_url":null,"archived":false,"open_issues_count":291,"forks":115,"open_issues":291,"watchers":1111,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cilium/cilium/pulls/1540"},"html":{"href":"https://github.com/cilium/cilium/pull/1540"},"issue":{"href":"https://api.github.com/repos/cilium/cilium/issues/1540"},"comments":{"href":"https://api.github.com/repos/cilium/cilium/issues/1540/comments"},"review_comments":{"href":"https://api.github.com/repos/cilium/cilium/pulls/1540/comments"},"review_comment":{"href":"https://api.github.com/repos/cilium/cilium/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cilium/cilium/pulls/1540/commits"},"statuses":{"href":"https://api.github.com/repos/cilium/cilium/statuses/6b38f1282ab63b701c288e04aeadcc6464f2da31"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"tgraf"}}