{"action":"created","comment":{"url":"https://api.github.com/repos/rpgtkoolmv/corescript/pulls/comments/101584154","pull_request_review_id":22318200,"id":101584154,"diff_hunk":"@@ -221,11 +225,15 @@ Sprite.prototype.setColorTone = function(tone) {\n  * @method _onBitmapLoad\n  * @private\n  */\n-Sprite.prototype._onBitmapLoad = function() {\n-    if (this._frame.width === 0 && this._frame.height === 0) {\n-        this._frame.width = this._bitmap.width;\n-        this._frame.height = this._bitmap.height;\n+Sprite.prototype._onBitmapLoad = function(bitmapLoaded) {\n+    if(bitmapLoaded === this._bitmap){\n+        if (this._refreshFrame && this._bitmap) {","path":"js/rpg_core/Sprite.js","position":33,"original_position":33,"commit_id":"42421a1ddfda18ad4a5a41115962c4955425e2cb","original_commit_id":"42421a1ddfda18ad4a5a41115962c4955425e2cb","user":{"login":"krmbn0576","id":20380362,"avatar_url":"https://avatars.githubusercontent.com/u/20380362?v=3","gravatar_id":"","url":"https://api.github.com/users/krmbn0576","html_url":"https://github.com/krmbn0576","followers_url":"https://api.github.com/users/krmbn0576/followers","following_url":"https://api.github.com/users/krmbn0576/following{/other_user}","gists_url":"https://api.github.com/users/krmbn0576/gists{/gist_id}","starred_url":"https://api.github.com/users/krmbn0576/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krmbn0576/subscriptions","organizations_url":"https://api.github.com/users/krmbn0576/orgs","repos_url":"https://api.github.com/users/krmbn0576/repos","events_url":"https://api.github.com/users/krmbn0576/events{/privacy}","received_events_url":"https://api.github.com/users/krmbn0576/received_events","type":"User","site_admin":false},"body":"I think `this._bitmap` is always non-null because it equals `bitmapLoaded`.","created_at":"2017-02-16T17:53:43Z","updated_at":"2017-02-16T17:53:43Z","html_url":"https://github.com/rpgtkoolmv/corescript/pull/20#discussion_r101584154","pull_request_url":"https://api.github.com/repos/rpgtkoolmv/corescript/pulls/20","_links":{"self":{"href":"https://api.github.com/repos/rpgtkoolmv/corescript/pulls/comments/101584154"},"html":{"href":"https://github.com/rpgtkoolmv/corescript/pull/20#discussion_r101584154"},"pull_request":{"href":"https://api.github.com/repos/rpgtkoolmv/corescript/pulls/20"}}},"pull_request":{"url":"https://api.github.com/repos/rpgtkoolmv/corescript/pulls/20","id":105745529,"html_url":"https://github.com/rpgtkoolmv/corescript/pull/20","diff_url":"https://github.com/rpgtkoolmv/corescript/pull/20.diff","patch_url":"https://github.com/rpgtkoolmv/corescript/pull/20.patch","issue_url":"https://api.github.com/repos/rpgtkoolmv/corescript/issues/20","number":20,"state":"open","locked":false,"title":"fix null reference and shows entire frame bug.","user":{"login":"liply","id":15798376,"avatar_url":"https://avatars.githubusercontent.com/u/15798376?v=3","gravatar_id":"","url":"https://api.github.com/users/liply","html_url":"https://github.com/liply","followers_url":"https://api.github.com/users/liply/followers","following_url":"https://api.github.com/users/liply/following{/other_user}","gists_url":"https://api.github.com/users/liply/gists{/gist_id}","starred_url":"https://api.github.com/users/liply/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liply/subscriptions","organizations_url":"https://api.github.com/users/liply/orgs","repos_url":"https://api.github.com/users/liply/repos","events_url":"https://api.github.com/users/liply/events{/privacy}","received_events_url":"https://api.github.com/users/liply/received_events","type":"User","site_admin":false},"body":"This fix bug wrote in Title.","created_at":"2017-02-11T07:30:55Z","updated_at":"2017-02-16T17:53:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f815b5e41e44eeebb1357bd12ceaa97fb98f8298","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/rpgtkoolmv/corescript/milestones/1","html_url":"https://github.com/rpgtkoolmv/corescript/milestone/1","labels_url":"https://api.github.com/repos/rpgtkoolmv/corescript/milestones/1/labels","id":2315703,"number":1,"title":"1.1","description":"* Fix memory related problems\r\n* Preceding reading of image material\r\n* Responding to sound problems of google Chrome\r\n* Fixed bugs already known","creator":{"login":"liply","id":15798376,"avatar_url":"https://avatars.githubusercontent.com/u/15798376?v=3","gravatar_id":"","url":"https://api.github.com/users/liply","html_url":"https://github.com/liply","followers_url":"https://api.github.com/users/liply/followers","following_url":"https://api.github.com/users/liply/following{/other_user}","gists_url":"https://api.github.com/users/liply/gists{/gist_id}","starred_url":"https://api.github.com/users/liply/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liply/subscriptions","organizations_url":"https://api.github.com/users/liply/orgs","repos_url":"https://api.github.com/users/liply/repos","events_url":"https://api.github.com/users/liply/events{/privacy}","received_events_url":"https://api.github.com/users/liply/received_events","type":"User","site_admin":false},"open_issues":14,"closed_issues":6,"state":"open","created_at":"2017-02-11T12:55:45Z","updated_at":"2017-02-15T07:08:38Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/rpgtkoolmv/corescript/pulls/20/commits","review_comments_url":"https://api.github.com/repos/rpgtkoolmv/corescript/pulls/20/comments","review_comment_url":"https://api.github.com/repos/rpgtkoolmv/corescript/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rpgtkoolmv/corescript/issues/20/comments","statuses_url":"https://api.github.com/repos/rpgtkoolmv/corescript/statuses/42421a1ddfda18ad4a5a41115962c4955425e2cb","head":{"label":"rpgtkoolmv:fix-sprite","ref":"fix-sprite","sha":"42421a1ddfda18ad4a5a41115962c4955425e2cb","user":{"login":"rpgtkoolmv","id":16203157,"avatar_url":"https://avatars.githubusercontent.com/u/16203157?v=3","gravatar_id":"","url":"https://api.github.com/users/rpgtkoolmv","html_url":"https://github.com/rpgtkoolmv","followers_url":"https://api.github.com/users/rpgtkoolmv/followers","following_url":"https://api.github.com/users/rpgtkoolmv/following{/other_user}","gists_url":"https://api.github.com/users/rpgtkoolmv/gists{/gist_id}","starred_url":"https://api.github.com/users/rpgtkoolmv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpgtkoolmv/subscriptions","organizations_url":"https://api.github.com/users/rpgtkoolmv/orgs","repos_url":"https://api.github.com/users/rpgtkoolmv/repos","events_url":"https://api.github.com/users/rpgtkoolmv/events{/privacy}","received_events_url":"https://api.github.com/users/rpgtkoolmv/received_events","type":"Organization","site_admin":false},"repo":{"id":79029140,"name":"corescript","full_name":"rpgtkoolmv/corescript","owner":{"login":"rpgtkoolmv","id":16203157,"avatar_url":"https://avatars.githubusercontent.com/u/16203157?v=3","gravatar_id":"","url":"https://api.github.com/users/rpgtkoolmv","html_url":"https://github.com/rpgtkoolmv","followers_url":"https://api.github.com/users/rpgtkoolmv/followers","following_url":"https://api.github.com/users/rpgtkoolmv/following{/other_user}","gists_url":"https://api.github.com/users/rpgtkoolmv/gists{/gist_id}","starred_url":"https://api.github.com/users/rpgtkoolmv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpgtkoolmv/subscriptions","organizations_url":"https://api.github.com/users/rpgtkoolmv/orgs","repos_url":"https://api.github.com/users/rpgtkoolmv/repos","events_url":"https://api.github.com/users/rpgtkoolmv/events{/privacy}","received_events_url":"https://api.github.com/users/rpgtkoolmv/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rpgtkoolmv/corescript","description":null,"fork":false,"url":"https://api.github.com/repos/rpgtkoolmv/corescript","forks_url":"https://api.github.com/repos/rpgtkoolmv/corescript/forks","keys_url":"https://api.github.com/repos/rpgtkoolmv/corescript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rpgtkoolmv/corescript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rpgtkoolmv/corescript/teams","hooks_url":"https://api.github.com/repos/rpgtkoolmv/corescript/hooks","issue_events_url":"https://api.github.com/repos/rpgtkoolmv/corescript/issues/events{/number}","events_url":"https://api.github.com/repos/rpgtkoolmv/corescript/events","assignees_url":"https://api.github.com/repos/rpgtkoolmv/corescript/assignees{/user}","branches_url":"https://api.github.com/repos/rpgtkoolmv/corescript/branches{/branch}","tags_url":"https://api.github.com/repos/rpgtkoolmv/corescript/tags","blobs_url":"https://api.github.com/repos/rpgtkoolmv/corescript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rpgtkoolmv/corescript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rpgtkoolmv/corescript/git/refs{/sha}","trees_url":"https://api.github.com/repos/rpgtkoolmv/corescript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rpgtkoolmv/corescript/statuses/{sha}","languages_url":"https://api.github.com/repos/rpgtkoolmv/corescript/languages","stargazers_url":"https://api.github.com/repos/rpgtkoolmv/corescript/stargazers","contributors_url":"https://api.github.com/repos/rpgtkoolmv/corescript/contributors","subscribers_url":"https://api.github.com/repos/rpgtkoolmv/corescript/subscribers","subscription_url":"https://api.github.com/repos/rpgtkoolmv/corescript/subscription","commits_url":"https://api.github.com/repos/rpgtkoolmv/corescript/commits{/sha}","git_commits_url":"https://api.github.com/repos/rpgtkoolmv/corescript/git/commits{/sha}","comments_url":"https://api.github.com/repos/rpgtkoolmv/corescript/comments{/number}","issue_comment_url":"https://api.github.com/repos/rpgtkoolmv/corescript/issues/comments{/number}","contents_url":"https://api.github.com/repos/rpgtkoolmv/corescript/contents/{+path}","compare_url":"https://api.github.com/repos/rpgtkoolmv/corescript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rpgtkoolmv/corescript/merges","archive_url":"https://api.github.com/repos/rpgtkoolmv/corescript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rpgtkoolmv/corescript/downloads","issues_url":"https://api.github.com/repos/rpgtkoolmv/corescript/issues{/number}","pulls_url":"https://api.github.com/repos/rpgtkoolmv/corescript/pulls{/number}","milestones_url":"https://api.github.com/repos/rpgtkoolmv/corescript/milestones{/number}","notifications_url":"https://api.github.com/repos/rpgtkoolmv/corescript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rpgtkoolmv/corescript/labels{/name}","releases_url":"https://api.github.com/repos/rpgtkoolmv/corescript/releases{/id}","deployments_url":"https://api.github.com/repos/rpgtkoolmv/corescript/deployments","created_at":"2017-01-15T11:43:41Z","updated_at":"2017-02-16T13:36:17Z","pushed_at":"2017-02-16T14:18:16Z","git_url":"git://github.com/rpgtkoolmv/corescript.git","ssh_url":"git@github.com:rpgtkoolmv/corescript.git","clone_url":"https://github.com/rpgtkoolmv/corescript.git","svn_url":"https://github.com/rpgtkoolmv/corescript","homepage":"http://www.rpgmakerweb.com/products/programs/rpg-maker-mv","size":683,"stargazers_count":99,"watchers_count":99,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":19,"forks":9,"open_issues":19,"watchers":99,"default_branch":"master"}},"base":{"label":"rpgtkoolmv:master","ref":"master","sha":"8129c364f208263d5086367e4f21f00081179715","user":{"login":"rpgtkoolmv","id":16203157,"avatar_url":"https://avatars.githubusercontent.com/u/16203157?v=3","gravatar_id":"","url":"https://api.github.com/users/rpgtkoolmv","html_url":"https://github.com/rpgtkoolmv","followers_url":"https://api.github.com/users/rpgtkoolmv/followers","following_url":"https://api.github.com/users/rpgtkoolmv/following{/other_user}","gists_url":"https://api.github.com/users/rpgtkoolmv/gists{/gist_id}","starred_url":"https://api.github.com/users/rpgtkoolmv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpgtkoolmv/subscriptions","organizations_url":"https://api.github.com/users/rpgtkoolmv/orgs","repos_url":"https://api.github.com/users/rpgtkoolmv/repos","events_url":"https://api.github.com/users/rpgtkoolmv/events{/privacy}","received_events_url":"https://api.github.com/users/rpgtkoolmv/received_events","type":"Organization","site_admin":false},"repo":{"id":79029140,"name":"corescript","full_name":"rpgtkoolmv/corescript","owner":{"login":"rpgtkoolmv","id":16203157,"avatar_url":"https://avatars.githubusercontent.com/u/16203157?v=3","gravatar_id":"","url":"https://api.github.com/users/rpgtkoolmv","html_url":"https://github.com/rpgtkoolmv","followers_url":"https://api.github.com/users/rpgtkoolmv/followers","following_url":"https://api.github.com/users/rpgtkoolmv/following{/other_user}","gists_url":"https://api.github.com/users/rpgtkoolmv/gists{/gist_id}","starred_url":"https://api.github.com/users/rpgtkoolmv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpgtkoolmv/subscriptions","organizations_url":"https://api.github.com/users/rpgtkoolmv/orgs","repos_url":"https://api.github.com/users/rpgtkoolmv/repos","events_url":"https://api.github.com/users/rpgtkoolmv/events{/privacy}","received_events_url":"https://api.github.com/users/rpgtkoolmv/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rpgtkoolmv/corescript","description":null,"fork":false,"url":"https://api.github.com/repos/rpgtkoolmv/corescript","forks_url":"https://api.github.com/repos/rpgtkoolmv/corescript/forks","keys_url":"https://api.github.com/repos/rpgtkoolmv/corescript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rpgtkoolmv/corescript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rpgtkoolmv/corescript/teams","hooks_url":"https://api.github.com/repos/rpgtkoolmv/corescript/hooks","issue_events_url":"https://api.github.com/repos/rpgtkoolmv/corescript/issues/events{/number}","events_url":"https://api.github.com/repos/rpgtkoolmv/corescript/events","assignees_url":"https://api.github.com/repos/rpgtkoolmv/corescript/assignees{/user}","branches_url":"https://api.github.com/repos/rpgtkoolmv/corescript/branches{/branch}","tags_url":"https://api.github.com/repos/rpgtkoolmv/corescript/tags","blobs_url":"https://api.github.com/repos/rpgtkoolmv/corescript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rpgtkoolmv/corescript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rpgtkoolmv/corescript/git/refs{/sha}","trees_url":"https://api.github.com/repos/rpgtkoolmv/corescript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rpgtkoolmv/corescript/statuses/{sha}","languages_url":"https://api.github.com/repos/rpgtkoolmv/corescript/languages","stargazers_url":"https://api.github.com/repos/rpgtkoolmv/corescript/stargazers","contributors_url":"https://api.github.com/repos/rpgtkoolmv/corescript/contributors","subscribers_url":"https://api.github.com/repos/rpgtkoolmv/corescript/subscribers","subscription_url":"https://api.github.com/repos/rpgtkoolmv/corescript/subscription","commits_url":"https://api.github.com/repos/rpgtkoolmv/corescript/commits{/sha}","git_commits_url":"https://api.github.com/repos/rpgtkoolmv/corescript/git/commits{/sha}","comments_url":"https://api.github.com/repos/rpgtkoolmv/corescript/comments{/number}","issue_comment_url":"https://api.github.com/repos/rpgtkoolmv/corescript/issues/comments{/number}","contents_url":"https://api.github.com/repos/rpgtkoolmv/corescript/contents/{+path}","compare_url":"https://api.github.com/repos/rpgtkoolmv/corescript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rpgtkoolmv/corescript/merges","archive_url":"https://api.github.com/repos/rpgtkoolmv/corescript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rpgtkoolmv/corescript/downloads","issues_url":"https://api.github.com/repos/rpgtkoolmv/corescript/issues{/number}","pulls_url":"https://api.github.com/repos/rpgtkoolmv/corescript/pulls{/number}","milestones_url":"https://api.github.com/repos/rpgtkoolmv/corescript/milestones{/number}","notifications_url":"https://api.github.com/repos/rpgtkoolmv/corescript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rpgtkoolmv/corescript/labels{/name}","releases_url":"https://api.github.com/repos/rpgtkoolmv/corescript/releases{/id}","deployments_url":"https://api.github.com/repos/rpgtkoolmv/corescript/deployments","created_at":"2017-01-15T11:43:41Z","updated_at":"2017-02-16T13:36:17Z","pushed_at":"2017-02-16T14:18:16Z","git_url":"git://github.com/rpgtkoolmv/corescript.git","ssh_url":"git@github.com:rpgtkoolmv/corescript.git","clone_url":"https://github.com/rpgtkoolmv/corescript.git","svn_url":"https://github.com/rpgtkoolmv/corescript","homepage":"http://www.rpgmakerweb.com/products/programs/rpg-maker-mv","size":683,"stargazers_count":99,"watchers_count":99,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":19,"forks":9,"open_issues":19,"watchers":99,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rpgtkoolmv/corescript/pulls/20"},"html":{"href":"https://github.com/rpgtkoolmv/corescript/pull/20"},"issue":{"href":"https://api.github.com/repos/rpgtkoolmv/corescript/issues/20"},"comments":{"href":"https://api.github.com/repos/rpgtkoolmv/corescript/issues/20/comments"},"review_comments":{"href":"https://api.github.com/repos/rpgtkoolmv/corescript/pulls/20/comments"},"review_comment":{"href":"https://api.github.com/repos/rpgtkoolmv/corescript/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rpgtkoolmv/corescript/pulls/20/commits"},"statuses":{"href":"https://api.github.com/repos/rpgtkoolmv/corescript/statuses/42421a1ddfda18ad4a5a41115962c4955425e2cb"}}}}
{"actor":{"display_login":"krmbn0576"}}