{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corert/pulls/comments/119974455","pull_request_review_id":41908536,"id":119974455,"diff_hunk":"@@ -210,6 +210,7 @@ protected sealed override void EmitCode(NodeFactory factory, ref X64Emitter enco\n                 case ReadyToRunHelperId.VirtualCall:\n                 case ReadyToRunHelperId.ResolveVirtualFunction:\n                 case ReadyToRunHelperId.MethodEntry:\n+                case ReadyToRunHelperId.InterfaceDispatchCell:","path":"src/ILCompiler.Compiler/src/Compiler/DependencyAnalysis/Target_X64/X64ReadyToRunGenericHelperNode.cs","position":4,"original_position":4,"commit_id":"1a9fcfade4720d1c3bd04578282db36a3dc926ea","original_commit_id":"1a9fcfade4720d1c3bd04578282db36a3dc926ea","user":{"login":"jkotas","id":6668460,"avatar_url":"https://avatars1.githubusercontent.com/u/6668460?v=3","gravatar_id":"","url":"https://api.github.com/users/jkotas","html_url":"https://github.com/jkotas","followers_url":"https://api.github.com/users/jkotas/followers","following_url":"https://api.github.com/users/jkotas/following{/other_user}","gists_url":"https://api.github.com/users/jkotas/gists{/gist_id}","starred_url":"https://api.github.com/users/jkotas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkotas/subscriptions","organizations_url":"https://api.github.com/users/jkotas/orgs","repos_url":"https://api.github.com/users/jkotas/repos","events_url":"https://api.github.com/users/jkotas/events{/privacy}","received_events_url":"https://api.github.com/users/jkotas/received_events","type":"User","site_admin":false},"body":"What's the difference between ResolveVirtualFunction and InterfaceDispatchCell? Shouldn't we have just one, and maybe name it `VirtualDispatchCell`? (There is nothing fundamental preventing the cell from being used to dispatch virtual methods. We are just not taking advantage of it today.)","created_at":"2017-06-03T00:52:17Z","updated_at":"2017-06-03T00:52:18Z","html_url":"https://github.com/dotnet/corert/pull/3773#discussion_r119974455","pull_request_url":"https://api.github.com/repos/dotnet/corert/pulls/3773","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corert/pulls/comments/119974455"},"html":{"href":"https://github.com/dotnet/corert/pull/3773#discussion_r119974455"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corert/pulls/3773"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corert/pulls/3773","id":123627264,"html_url":"https://github.com/dotnet/corert/pull/3773","diff_url":"https://github.com/dotnet/corert/pull/3773.diff","patch_url":"https://github.com/dotnet/corert/pull/3773.patch","issue_url":"https://api.github.com/repos/dotnet/corert/issues/3773","number":3773,"state":"open","locked":false,"title":"Enable inlining of virtual method calls","user":{"login":"MichalStrehovsky","id":13110571,"avatar_url":"https://avatars3.githubusercontent.com/u/13110571?v=3","gravatar_id":"","url":"https://api.github.com/users/MichalStrehovsky","html_url":"https://github.com/MichalStrehovsky","followers_url":"https://api.github.com/users/MichalStrehovsky/followers","following_url":"https://api.github.com/users/MichalStrehovsky/following{/other_user}","gists_url":"https://api.github.com/users/MichalStrehovsky/gists{/gist_id}","starred_url":"https://api.github.com/users/MichalStrehovsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MichalStrehovsky/subscriptions","organizations_url":"https://api.github.com/users/MichalStrehovsky/orgs","repos_url":"https://api.github.com/users/MichalStrehovsky/repos","events_url":"https://api.github.com/users/MichalStrehovsky/events{/privacy}","received_events_url":"https://api.github.com/users/MichalStrehovsky/received_events","type":"User","site_admin":false},"body":"* Add a switch to `CompilationBuilder` to control ready to run code\r\ngeneration\r\n* If R2R compilation is turned off, ask RyuJIT to inline plain virtual\r\nmethod calls and interface method calls.","created_at":"2017-06-02T01:51:35Z","updated_at":"2017-06-03T00:52:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dfb51696c24dcece8503130cf934b4dfa98bd6e8","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corert/pulls/3773/commits","review_comments_url":"https://api.github.com/repos/dotnet/corert/pulls/3773/comments","review_comment_url":"https://api.github.com/repos/dotnet/corert/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corert/issues/3773/comments","statuses_url":"https://api.github.com/repos/dotnet/corert/statuses/1a9fcfade4720d1c3bd04578282db36a3dc926ea","head":{"label":"MichalStrehovsky:inlinedVirtualCalls","ref":"inlinedVirtualCalls","sha":"1a9fcfade4720d1c3bd04578282db36a3dc926ea","user":{"login":"MichalStrehovsky","id":13110571,"avatar_url":"https://avatars3.githubusercontent.com/u/13110571?v=3","gravatar_id":"","url":"https://api.github.com/users/MichalStrehovsky","html_url":"https://github.com/MichalStrehovsky","followers_url":"https://api.github.com/users/MichalStrehovsky/followers","following_url":"https://api.github.com/users/MichalStrehovsky/following{/other_user}","gists_url":"https://api.github.com/users/MichalStrehovsky/gists{/gist_id}","starred_url":"https://api.github.com/users/MichalStrehovsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MichalStrehovsky/subscriptions","organizations_url":"https://api.github.com/users/MichalStrehovsky/orgs","repos_url":"https://api.github.com/users/MichalStrehovsky/repos","events_url":"https://api.github.com/users/MichalStrehovsky/events{/privacy}","received_events_url":"https://api.github.com/users/MichalStrehovsky/received_events","type":"User","site_admin":false},"repo":{"id":46432791,"name":"corert","full_name":"MichalStrehovsky/corert","owner":{"login":"MichalStrehovsky","id":13110571,"avatar_url":"https://avatars3.githubusercontent.com/u/13110571?v=3","gravatar_id":"","url":"https://api.github.com/users/MichalStrehovsky","html_url":"https://github.com/MichalStrehovsky","followers_url":"https://api.github.com/users/MichalStrehovsky/followers","following_url":"https://api.github.com/users/MichalStrehovsky/following{/other_user}","gists_url":"https://api.github.com/users/MichalStrehovsky/gists{/gist_id}","starred_url":"https://api.github.com/users/MichalStrehovsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MichalStrehovsky/subscriptions","organizations_url":"https://api.github.com/users/MichalStrehovsky/orgs","repos_url":"https://api.github.com/users/MichalStrehovsky/repos","events_url":"https://api.github.com/users/MichalStrehovsky/events{/privacy}","received_events_url":"https://api.github.com/users/MichalStrehovsky/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MichalStrehovsky/corert","description":"This repo contains CoreRT, a .NET Core runtime optimized for AOT (ahead of time compilation) scenarios, with the accompanying .NET Native compiler toolchain.","fork":true,"url":"https://api.github.com/repos/MichalStrehovsky/corert","forks_url":"https://api.github.com/repos/MichalStrehovsky/corert/forks","keys_url":"https://api.github.com/repos/MichalStrehovsky/corert/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MichalStrehovsky/corert/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MichalStrehovsky/corert/teams","hooks_url":"https://api.github.com/repos/MichalStrehovsky/corert/hooks","issue_events_url":"https://api.github.com/repos/MichalStrehovsky/corert/issues/events{/number}","events_url":"https://api.github.com/repos/MichalStrehovsky/corert/events","assignees_url":"https://api.github.com/repos/MichalStrehovsky/corert/assignees{/user}","branches_url":"https://api.github.com/repos/MichalStrehovsky/corert/branches{/branch}","tags_url":"https://api.github.com/repos/MichalStrehovsky/corert/tags","blobs_url":"https://api.github.com/repos/MichalStrehovsky/corert/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MichalStrehovsky/corert/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MichalStrehovsky/corert/git/refs{/sha}","trees_url":"https://api.github.com/repos/MichalStrehovsky/corert/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MichalStrehovsky/corert/statuses/{sha}","languages_url":"https://api.github.com/repos/MichalStrehovsky/corert/languages","stargazers_url":"https://api.github.com/repos/MichalStrehovsky/corert/stargazers","contributors_url":"https://api.github.com/repos/MichalStrehovsky/corert/contributors","subscribers_url":"https://api.github.com/repos/MichalStrehovsky/corert/subscribers","subscription_url":"https://api.github.com/repos/MichalStrehovsky/corert/subscription","commits_url":"https://api.github.com/repos/MichalStrehovsky/corert/commits{/sha}","git_commits_url":"https://api.github.com/repos/MichalStrehovsky/corert/git/commits{/sha}","comments_url":"https://api.github.com/repos/MichalStrehovsky/corert/comments{/number}","issue_comment_url":"https://api.github.com/repos/MichalStrehovsky/corert/issues/comments{/number}","contents_url":"https://api.github.com/repos/MichalStrehovsky/corert/contents/{+path}","compare_url":"https://api.github.com/repos/MichalStrehovsky/corert/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MichalStrehovsky/corert/merges","archive_url":"https://api.github.com/repos/MichalStrehovsky/corert/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MichalStrehovsky/corert/downloads","issues_url":"https://api.github.com/repos/MichalStrehovsky/corert/issues{/number}","pulls_url":"https://api.github.com/repos/MichalStrehovsky/corert/pulls{/number}","milestones_url":"https://api.github.com/repos/MichalStrehovsky/corert/milestones{/number}","notifications_url":"https://api.github.com/repos/MichalStrehovsky/corert/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MichalStrehovsky/corert/labels{/name}","releases_url":"https://api.github.com/repos/MichalStrehovsky/corert/releases{/id}","deployments_url":"https://api.github.com/repos/MichalStrehovsky/corert/deployments","created_at":"2015-11-18T16:45:32Z","updated_at":"2016-01-14T03:31:37Z","pushed_at":"2017-06-02T21:51:29Z","git_url":"git://github.com/MichalStrehovsky/corert.git","ssh_url":"git@github.com:MichalStrehovsky/corert.git","clone_url":"https://github.com/MichalStrehovsky/corert.git","svn_url":"https://github.com/MichalStrehovsky/corert","homepage":"http://dotnet.github.io/","size":18465,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"dd378c55c01c00b5cb37a8675613f6d21f7bfc8c","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars3.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":42552143,"name":"corert","full_name":"dotnet/corert","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars3.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corert","description":"This repo contains CoreRT, a .NET Core runtime optimized for AOT (ahead of time compilation) scenarios, with the accompanying .NET Native compiler toolchain.","fork":false,"url":"https://api.github.com/repos/dotnet/corert","forks_url":"https://api.github.com/repos/dotnet/corert/forks","keys_url":"https://api.github.com/repos/dotnet/corert/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corert/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corert/teams","hooks_url":"https://api.github.com/repos/dotnet/corert/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corert/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corert/events","assignees_url":"https://api.github.com/repos/dotnet/corert/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corert/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corert/tags","blobs_url":"https://api.github.com/repos/dotnet/corert/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corert/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corert/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corert/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corert/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corert/languages","stargazers_url":"https://api.github.com/repos/dotnet/corert/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corert/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corert/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corert/subscription","commits_url":"https://api.github.com/repos/dotnet/corert/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corert/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corert/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corert/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corert/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corert/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corert/merges","archive_url":"https://api.github.com/repos/dotnet/corert/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corert/downloads","issues_url":"https://api.github.com/repos/dotnet/corert/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corert/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corert/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corert/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corert/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corert/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corert/deployments","created_at":"2015-09-15T23:10:53Z","updated_at":"2017-05-30T10:05:17Z","pushed_at":"2017-06-02T23:41:33Z","git_url":"git://github.com/dotnet/corert.git","ssh_url":"git@github.com:dotnet/corert.git","clone_url":"https://github.com/dotnet/corert.git","svn_url":"https://github.com/dotnet/corert","homepage":"http://dot.net","size":18388,"stargazers_count":617,"watchers_count":617,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":214,"mirror_url":null,"open_issues_count":225,"forks":214,"open_issues":225,"watchers":617,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corert/pulls/3773"},"html":{"href":"https://github.com/dotnet/corert/pull/3773"},"issue":{"href":"https://api.github.com/repos/dotnet/corert/issues/3773"},"comments":{"href":"https://api.github.com/repos/dotnet/corert/issues/3773/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corert/pulls/3773/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corert/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corert/pulls/3773/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corert/statuses/1a9fcfade4720d1c3bd04578282db36a3dc926ea"}}}}
{"actor":{"display_login":"jkotas"}}