{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/20709","repository_url":"https://api.github.com/repos/cms-sw/cmssw","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/20709/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/20709/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/20709/events","html_url":"https://github.com/cms-sw/cmssw/pull/20709","id":261952883,"number":20709,"title":"Better splitting and Tcrit definition for 4D vertexing","user":{"login":"lgray","id":1068089,"avatar_url":"https://avatars0.githubusercontent.com/u/1068089?v=4","gravatar_id":"","url":"https://api.github.com/users/lgray","html_url":"https://github.com/lgray","followers_url":"https://api.github.com/users/lgray/followers","following_url":"https://api.github.com/users/lgray/following{/other_user}","gists_url":"https://api.github.com/users/lgray/gists{/gist_id}","starred_url":"https://api.github.com/users/lgray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lgray/subscriptions","organizations_url":"https://api.github.com/users/lgray/orgs","repos_url":"https://api.github.com/users/lgray/repos","events_url":"https://api.github.com/users/lgray/events{/privacy}","received_events_url":"https://api.github.com/users/lgray/received_events","type":"User","site_admin":false},"labels":[{"id":673935047,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/code-checks-approved","name":"code-checks-approved","color":"009800","default":false},{"id":88653795,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-pending","name":"comparison-pending","color":"fbca04","default":false},{"id":56953091,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04","default":false},{"id":53167770,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"eb6420","default":false},{"id":52820010,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/reconstruction-pending","name":"reconstruction-pending","color":"fbca04","default":false},{"id":170521617,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-started","name":"tests-started","color":"eb6420","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/71","html_url":"https://github.com/cms-sw/cmssw/milestone/71","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/71/labels","id":2747412,"number":71,"title":"CMSSW_9_4_X","description":"","creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars3.githubusercontent.com/u/4115138?v=4","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":80,"closed_issues":200,"state":"open","created_at":"2017-09-06T08:22:14Z","updated_at":"2017-10-02T13:37:17Z","due_on":null,"closed_at":null},"comments":24,"created_at":"2017-10-01T22:46:26Z","updated_at":"2017-10-02T15:20:15Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/20709","html_url":"https://github.com/cms-sw/cmssw/pull/20709","diff_url":"https://github.com/cms-sw/cmssw/pull/20709.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/20709.patch"},"body":"This PR implements an improved splitting strategy and better Tcrit definition for track clusters in time-aware vertexing. Improvements are from @werdmann.\r\n\r\nThis significantly speeds up vertexing to the point that the minimum pT cut that has been in place before may be removed."},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/333567239","html_url":"https://github.com/cms-sw/cmssw/pull/20709#issuecomment-333567239","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/20709","id":333567239,"user":{"login":"slava77","id":4676718,"avatar_url":"https://avatars2.githubusercontent.com/u/4676718?v=4","gravatar_id":"","url":"https://api.github.com/users/slava77","html_url":"https://github.com/slava77","followers_url":"https://api.github.com/users/slava77/followers","following_url":"https://api.github.com/users/slava77/following{/other_user}","gists_url":"https://api.github.com/users/slava77/gists{/gist_id}","starred_url":"https://api.github.com/users/slava77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slava77/subscriptions","organizations_url":"https://api.github.com/users/slava77/orgs","repos_url":"https://api.github.com/users/slava77/repos","events_url":"https://api.github.com/users/slava77/events{/privacy}","received_events_url":"https://api.github.com/users/slava77/received_events","type":"User","site_admin":false},"created_at":"2017-10-02T15:20:13Z","updated_at":"2017-10-02T15:20:13Z","author_association":"CONTRIBUTOR","body":"On 10/2/17 6:13 AM, Lindsey Gray wrote:\n> Visually, things look ~OK.\n> vertex_reco_display_200PU_hgg_evt0.pdf\n> <https://github.com/cms-sw/cmssw/files/1348980/vertex_reco_display_200PU_hgg_evt0.pdf>\n> \n> Time pull looks fine:\n> time_pull_200PU_hgg.pdf\n> <https://github.com/cms-sw/cmssw/files/1348982/time_pull_200PU_hgg.pdf>\n> \n> dt and dz distributions look as expected:\n> dt_to_sim_200PU_hgg.pdf\n> <https://github.com/cms-sw/cmssw/files/1348987/dt_to_sim_200PU_hgg.pdf>\n> dz_to_sim_200PU_hgg.pdf\n> <https://github.com/cms-sw/cmssw/files/1348988/dz_to_sim_200PU_hgg.pdf>\n\n\nIt would be nice to see plots before and after.\n\n\n> \n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/cms-sw/cmssw/pull/20709#issuecomment-333530312>, or\n> mute the thread\n> <https://github.com/notifications/unsubscribe-auth/AEdcbu1RIIq8pDF0dAeRuphVmpe0ilS7ks5soOF_gaJpZM4PqD9J>.\n> \n\n"}}
{"actor":{"display_login":"slava77"}}