{"action":"created","issue":{"url":"https://api.github.com/repos/florinpatrascu/bolt_sips/issues/14","repository_url":"https://api.github.com/repos/florinpatrascu/bolt_sips","labels_url":"https://api.github.com/repos/florinpatrascu/bolt_sips/issues/14/labels{/name}","comments_url":"https://api.github.com/repos/florinpatrascu/bolt_sips/issues/14/comments","events_url":"https://api.github.com/repos/florinpatrascu/bolt_sips/issues/14/events","html_url":"https://github.com/florinpatrascu/bolt_sips/pull/14","id":206615439,"number":14,"title":"Bolt struct handler for pack encoder","user":{"login":"wli0503","id":13424185,"avatar_url":"https://avatars.githubusercontent.com/u/13424185?v=3","gravatar_id":"","url":"https://api.github.com/users/wli0503","html_url":"https://github.com/wli0503","followers_url":"https://api.github.com/users/wli0503/followers","following_url":"https://api.github.com/users/wli0503/following{/other_user}","gists_url":"https://api.github.com/users/wli0503/gists{/gist_id}","starred_url":"https://api.github.com/users/wli0503/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wli0503/subscriptions","organizations_url":"https://api.github.com/users/wli0503/orgs","repos_url":"https://api.github.com/users/wli0503/repos","events_url":"https://api.github.com/users/wli0503/events{/privacy}","received_events_url":"https://api.github.com/users/wli0503/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2017-02-09T20:05:32Z","updated_at":"2017-02-11T19:41:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/florinpatrascu/bolt_sips/pulls/14","html_url":"https://github.com/florinpatrascu/bolt_sips/pull/14","diff_url":"https://github.com/florinpatrascu/bolt_sips/pull/14.diff","patch_url":"https://github.com/florinpatrascu/bolt_sips/pull/14.patch"},"body":"    BOLT: Struct Handler for PackEncoder\r\n\r\n    - Add a `@fallback_to_any` directive for `Boltex.PackStream.Encoder`\r\n      for falling back to `Any` implementation\r\n    - Add a new implementation for `Any`\r\n      * Specifically, when the passed structure is a struct, it will\r\n        fall into the category since `is_map/1` guard clause will work\r\n      * It transform the `struct` to `map` and then calling\r\n        `Boltex.PackStream.Encoder.encode/1`, which will invoke the\r\n        implementation for the `Map` encoder\r\n    - Add two test cases in `query_test.exs` to test the code handles\r\n      `Map` and `Struct` correctly"},"comment":{"url":"https://api.github.com/repos/florinpatrascu/bolt_sips/issues/comments/279170526","html_url":"https://github.com/florinpatrascu/bolt_sips/pull/14#issuecomment-279170526","issue_url":"https://api.github.com/repos/florinpatrascu/bolt_sips/issues/14","id":279170526,"user":{"login":"florinpatrascu","id":76138,"avatar_url":"https://avatars.githubusercontent.com/u/76138?v=3","gravatar_id":"","url":"https://api.github.com/users/florinpatrascu","html_url":"https://github.com/florinpatrascu","followers_url":"https://api.github.com/users/florinpatrascu/followers","following_url":"https://api.github.com/users/florinpatrascu/following{/other_user}","gists_url":"https://api.github.com/users/florinpatrascu/gists{/gist_id}","starred_url":"https://api.github.com/users/florinpatrascu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/florinpatrascu/subscriptions","organizations_url":"https://api.github.com/users/florinpatrascu/orgs","repos_url":"https://api.github.com/users/florinpatrascu/repos","events_url":"https://api.github.com/users/florinpatrascu/events{/privacy}","received_events_url":"https://api.github.com/users/florinpatrascu/received_events","type":"User","site_admin":false},"created_at":"2017-02-11T19:41:39Z","updated_at":"2017-02-11T19:41:39Z","body":"You're right! And I just realized I merged your PR on top of a version where I had Vic's code as well, hence my confusion. I apologize for that and for the lengthy and most probably unnecessary comment I made. I'll merge the PR in an hour or two, and push a new version to hex.pm. Thank you, for patience and for contributing to Bolt.Sips!"}}
{"actor":{"display_login":"florinpatrascu"}}