{"action":"created","issue":{"url":"https://api.github.com/repos/Subsurface-divelog/subsurface/issues/793","repository_url":"https://api.github.com/repos/Subsurface-divelog/subsurface","labels_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/issues/793/labels{/name}","comments_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/issues/793/comments","events_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/issues/793/events","html_url":"https://github.com/Subsurface-divelog/subsurface/pull/793","id":272653397,"number":793,"title":"map-widget: marker edit improvements","user":{"login":"neolit123","id":331852,"avatar_url":"https://avatars3.githubusercontent.com/u/331852?v=4","gravatar_id":"","url":"https://api.github.com/users/neolit123","html_url":"https://github.com/neolit123","followers_url":"https://api.github.com/users/neolit123/followers","following_url":"https://api.github.com/users/neolit123/following{/other_user}","gists_url":"https://api.github.com/users/neolit123/gists{/gist_id}","starred_url":"https://api.github.com/users/neolit123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neolit123/subscriptions","organizations_url":"https://api.github.com/users/neolit123/orgs","repos_url":"https://api.github.com/users/neolit123/repos","events_url":"https://api.github.com/users/neolit123/events{/privacy}","received_events_url":"https://api.github.com/users/neolit123/received_events","type":"User","site_admin":false},"labels":[{"id":700999244,"url":"https://api.github.com/repos/Subsurface-divelog/subsurface/labels/dive-site","name":"dive-site","color":"1d76db","default":false},{"id":515043298,"url":"https://api.github.com/repos/Subsurface-divelog/subsurface/labels/enhancements-we-intend-to-add","name":"enhancements-we-intend-to-add","color":"0e8a16","default":false},{"id":700901859,"url":"https://api.github.com/repos/Subsurface-divelog/subsurface/labels/needs-developer-feedback","name":"needs-developer-feedback","color":"fbca04","default":false},{"id":720656669,"url":"https://api.github.com/repos/Subsurface-divelog/subsurface/labels/needs-testing","name":"needs-testing","color":"fbca04","default":false},{"id":700901761,"url":"https://api.github.com/repos/Subsurface-divelog/subsurface/labels/needs-user-feedback","name":"needs-user-feedback","color":"fef2c0","default":false},{"id":700898901,"url":"https://api.github.com/repos/Subsurface-divelog/subsurface/labels/ui-desktop","name":"ui-desktop","color":"006b75","default":false},{"id":700899116,"url":"https://api.github.com/repos/Subsurface-divelog/subsurface/labels/widget-map","name":"widget-map","color":"c5def5","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-11-09T17:30:10Z","updated_at":"2017-11-09T17:34:14Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/793","html_url":"https://github.com/Subsurface-divelog/subsurface/pull/793","diff_url":"https://github.com/Subsurface-divelog/subsurface/pull/793.diff","patch_url":"https://github.com/Subsurface-divelog/subsurface/pull/793.patch"},"body":"<!-- Lines like this one are comments and will not be shown in the final output. -->\r\n<!-- Make sure that you have read the \"Contributing\" section of the README and also the notes in CodingStyle. -->\r\n<!-- If you are a collaborator, please add labels and assign other collaborators for a review. -->\r\n\r\n### Describe the pull request:\r\n<!-- Replace [ ] with [x] to select options. -->\r\n- [ ] Bug fix\r\n- [x] Functional change\r\n- [ ] New feature\r\n- [ ] Documentation change\r\n- [ ] Language translation\r\n\r\n### Pull request long description:\r\n<!-- Describe your pull request in detail. -->\r\n\r\n**PATCH1:**\r\n\r\nWhen starting to edit a new dive location, create\r\na marker at the current map center instead of zooming\r\nout and centering on the 0,0 coordinate.\r\n\r\nThis will help (and speed up) a lot the edition,\r\nif the user needs to add numerous dive markers\r\nat a specific location close to each other.\r\n\r\n**PATCH2:**\r\n\r\nThis patch allows updating the location of map markers\r\nwhile editing a dive site and updating the text in the\r\nLocationInformationWidget in real-time.\r\n\r\nCurrently it is only possible to see the marker changes by\r\nclicking 'Apply'.\r\n\r\nThe modification required the following changes:\r\n- add the MapWidget::updateCurrentDiveSiteCoordinatesToMap() slot\r\nand call it each time the GPS text updates\r\n- separate the updateCurrentDiveSiteCoordinates(FromMap/ToMap) logic\r\nby having the FromMap/ToMap suffix to method names\r\n- make MapWidgetHelper::updateCurrentDiveSiteCoordinatesToMap()\r\ncall a new MapLocationModel::updateMapLocationCoordinates()\r\nmethod, which updates selected location coordinates and the model\r\n- add MapLocation::setCoordinateNoEmit() that does not emit\r\na signal when updating a coordinate\r\n\r\n### Changes made:\r\n<!-- Enumerate the changes with 1), 2), 3) etc. -->\r\n<!-- Ensure the test cases are updated if needed. -->\r\nsee list above\r\n\r\n### Related issues:\r\n<!-- Reference issues with #<issue-num>. -->\r\n<!-- Write \"Fixes #<issue-num\" to notify Github that this PR fixes an issue. -->\r\nFixes #754\r\n\r\n### Additional information:\r\n<!-- Include sample dive log or other relevant information to allow testing the change where feasible. -->\r\nnone\r\n\r\n### Mentions:\r\n<!-- Mention users that you want to review your pull request with @<user-name>. Leave empty if not sure. -->\r\n@dirkhh @janmulder @sfuchs79 "},"comment":{"url":"https://api.github.com/repos/Subsurface-divelog/subsurface/issues/comments/343231170","html_url":"https://github.com/Subsurface-divelog/subsurface/pull/793#issuecomment-343231170","issue_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/issues/793","id":343231170,"user":{"login":"dirkhh","id":237471,"avatar_url":"https://avatars1.githubusercontent.com/u/237471?v=4","gravatar_id":"","url":"https://api.github.com/users/dirkhh","html_url":"https://github.com/dirkhh","followers_url":"https://api.github.com/users/dirkhh/followers","following_url":"https://api.github.com/users/dirkhh/following{/other_user}","gists_url":"https://api.github.com/users/dirkhh/gists{/gist_id}","starred_url":"https://api.github.com/users/dirkhh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dirkhh/subscriptions","organizations_url":"https://api.github.com/users/dirkhh/orgs","repos_url":"https://api.github.com/users/dirkhh/repos","events_url":"https://api.github.com/users/dirkhh/events{/privacy}","received_events_url":"https://api.github.com/users/dirkhh/received_events","type":"User","site_admin":false},"created_at":"2017-11-09T17:34:14Z","updated_at":"2017-11-09T17:34:14Z","author_association":"COLLABORATOR","body":"Can I ask you to add a patch # 3 that edits the ReleaseNotes? :-)"}}
{"actor":{"display_login":"dirkhh"}}