{"action":"created","issue":{"url":"https://api.github.com/repos/GoogleChrome/howto-components/issues/99","repository_url":"https://api.github.com/repos/GoogleChrome/howto-components","labels_url":"https://api.github.com/repos/GoogleChrome/howto-components/issues/99/labels{/name}","comments_url":"https://api.github.com/repos/GoogleChrome/howto-components/issues/99/comments","events_url":"https://api.github.com/repos/GoogleChrome/howto-components/issues/99/events","html_url":"https://github.com/GoogleChrome/howto-components/pull/99","id":248131552,"number":99,"title":"Add checkbox to shadow dom","user":{"login":"robdodson","id":1066253,"avatar_url":"https://avatars0.githubusercontent.com/u/1066253?v=4","gravatar_id":"","url":"https://api.github.com/users/robdodson","html_url":"https://github.com/robdodson","followers_url":"https://api.github.com/users/robdodson/followers","following_url":"https://api.github.com/users/robdodson/following{/other_user}","gists_url":"https://api.github.com/users/robdodson/gists{/gist_id}","starred_url":"https://api.github.com/users/robdodson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robdodson/subscriptions","organizations_url":"https://api.github.com/users/robdodson/orgs","repos_url":"https://api.github.com/users/robdodson/repos","events_url":"https://api.github.com/users/robdodson/events{/privacy}","received_events_url":"https://api.github.com/users/robdodson/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-08-04T22:28:21Z","updated_at":"2017-08-07T14:27:23Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/GoogleChrome/howto-components/pulls/99","html_url":"https://github.com/GoogleChrome/howto-components/pull/99","diff_url":"https://github.com/GoogleChrome/howto-components/pull/99.diff","patch_url":"https://github.com/GoogleChrome/howto-components/pull/99.patch"},"body":"@surma I wanted to put this on your radar. Per the best practices doc I shared previously, I'm planning to move the checkbox styles into the shadow dom. I've come around to thinking that an element that attempts to style itself or its children will need a shadow root. Otherwise if someone tries to use that element inside of _another_ element that has a shadow root. it'll break.\r\n\r\nMoving the styles into the element creates weirdness for the docs directory though. I had to remove all the image path variables. I'm not sure what the best way to work around that is?"},"comment":{"url":"https://api.github.com/repos/GoogleChrome/howto-components/issues/comments/320678835","html_url":"https://github.com/GoogleChrome/howto-components/pull/99#issuecomment-320678835","issue_url":"https://api.github.com/repos/GoogleChrome/howto-components/issues/99","id":320678835,"user":{"login":"surma","id":234957,"avatar_url":"https://avatars1.githubusercontent.com/u/234957?v=4","gravatar_id":"","url":"https://api.github.com/users/surma","html_url":"https://github.com/surma","followers_url":"https://api.github.com/users/surma/followers","following_url":"https://api.github.com/users/surma/following{/other_user}","gists_url":"https://api.github.com/users/surma/gists{/gist_id}","starred_url":"https://api.github.com/users/surma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/surma/subscriptions","organizations_url":"https://api.github.com/users/surma/orgs","repos_url":"https://api.github.com/users/surma/repos","events_url":"https://api.github.com/users/surma/events{/privacy}","received_events_url":"https://api.github.com/users/surma/received_events","type":"User","site_admin":false},"created_at":"2017-08-07T14:27:23Z","updated_at":"2017-08-07T14:27:23Z","body":"LGTM. Merge at will"}}
{"actor":{"display_login":"surma"}}