{"action":"created","comment":{"url":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/comments/123627038","pull_request_review_id":45851172,"id":123627038,"diff_hunk":"@@ -8,7 +8,7 @@\n  */\n public class BlockHutBuilder extends AbstractBlockHut\n {\n-    protected BlockHutBuilder()\n+    public BlockHutBuilder()","path":"src/main/java/com/minecolonies/coremod/blocks/BlockHutBuilder.java","position":5,"original_position":5,"commit_id":"99908acea5e6c498b527d5f47384d4911047255c","original_commit_id":"99908acea5e6c498b527d5f47384d4911047255c","user":{"login":"codacy-bot","id":19940114,"avatar_url":"https://avatars2.githubusercontent.com/u/19940114?v=3","gravatar_id":"","url":"https://api.github.com/users/codacy-bot","html_url":"https://github.com/codacy-bot","followers_url":"https://api.github.com/users/codacy-bot/followers","following_url":"https://api.github.com/users/codacy-bot/following{/other_user}","gists_url":"https://api.github.com/users/codacy-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/codacy-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codacy-bot/subscriptions","organizations_url":"https://api.github.com/users/codacy-bot/orgs","repos_url":"https://api.github.com/users/codacy-bot/repos","events_url":"https://api.github.com/users/codacy-bot/events{/privacy}","received_events_url":"https://api.github.com/users/codacy-bot/received_events","type":"User","site_admin":false},"body":"![Codacy](https://www.codacy.com/assets/images/favicon.png) Issue found: [Avoid unnecessary constructors - the compiler will generate these for you](https://www.codacy.com/app/Minecolonies/minecolonies/pullRequest?prid=662390)","created_at":"2017-06-22T21:29:21Z","updated_at":"2017-06-22T21:29:21Z","html_url":"https://github.com/Minecolonies/minecolonies/pull/1001#discussion_r123627038","pull_request_url":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/1001","_links":{"self":{"href":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/comments/123627038"},"html":{"href":"https://github.com/Minecolonies/minecolonies/pull/1001#discussion_r123627038"},"pull_request":{"href":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/1001"}}},"pull_request":{"url":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/1001","id":120673453,"html_url":"https://github.com/Minecolonies/minecolonies/pull/1001","diff_url":"https://github.com/Minecolonies/minecolonies/pull/1001.diff","patch_url":"https://github.com/Minecolonies/minecolonies/pull/1001.patch","issue_url":"https://api.github.com/repos/Minecolonies/minecolonies/issues/1001","number":1001,"state":"open","locked":false,"title":"The request System. Or as it is commonly known the DMan 2.0","user":{"login":"OrionDevelopment","id":5585406,"avatar_url":"https://avatars1.githubusercontent.com/u/5585406?v=3","gravatar_id":"","url":"https://api.github.com/users/OrionDevelopment","html_url":"https://github.com/OrionDevelopment","followers_url":"https://api.github.com/users/OrionDevelopment/followers","following_url":"https://api.github.com/users/OrionDevelopment/following{/other_user}","gists_url":"https://api.github.com/users/OrionDevelopment/gists{/gist_id}","starred_url":"https://api.github.com/users/OrionDevelopment/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OrionDevelopment/subscriptions","organizations_url":"https://api.github.com/users/OrionDevelopment/orgs","repos_url":"https://api.github.com/users/OrionDevelopment/repos","events_url":"https://api.github.com/users/OrionDevelopment/events{/privacy}","received_events_url":"https://api.github.com/users/OrionDevelopment/received_events","type":"User","site_admin":false},"body":"This is a discussion PR.\r\n\r\nIst main goal is to get Input on the design of the new System.\r\nAs you all can see it is heavily Interface and factory based.\r\n\r\nThe principle follows an Inversion of Control pattern that makes the IRequestManager the heart of the System. Outside of him no IRequests are known, just Tokens and These Tokens are passed around.\r\n\r\nIf you request a IRequest from the Manager you will get a defensive copy to make sure that you cannot tamper with its state directly.\r\n\r\nRequestResolvers are the workers in this System. A resolver basicly tells the Handler what to do. And how to proceed.\r\n\r\nPlease feel free to ask me anything regarding the new System.\r\n","created_at":"2017-05-15T19:14:51Z","updated_at":"2017-06-22T21:29:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"OrionDevelopment","id":5585406,"avatar_url":"https://avatars1.githubusercontent.com/u/5585406?v=3","gravatar_id":"","url":"https://api.github.com/users/OrionDevelopment","html_url":"https://github.com/OrionDevelopment","followers_url":"https://api.github.com/users/OrionDevelopment/followers","following_url":"https://api.github.com/users/OrionDevelopment/following{/other_user}","gists_url":"https://api.github.com/users/OrionDevelopment/gists{/gist_id}","starred_url":"https://api.github.com/users/OrionDevelopment/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OrionDevelopment/subscriptions","organizations_url":"https://api.github.com/users/OrionDevelopment/orgs","repos_url":"https://api.github.com/users/OrionDevelopment/repos","events_url":"https://api.github.com/users/OrionDevelopment/events{/privacy}","received_events_url":"https://api.github.com/users/OrionDevelopment/received_events","type":"User","site_admin":false},"assignees":[{"login":"OrionDevelopment","id":5585406,"avatar_url":"https://avatars1.githubusercontent.com/u/5585406?v=3","gravatar_id":"","url":"https://api.github.com/users/OrionDevelopment","html_url":"https://github.com/OrionDevelopment","followers_url":"https://api.github.com/users/OrionDevelopment/followers","following_url":"https://api.github.com/users/OrionDevelopment/following{/other_user}","gists_url":"https://api.github.com/users/OrionDevelopment/gists{/gist_id}","starred_url":"https://api.github.com/users/OrionDevelopment/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OrionDevelopment/subscriptions","organizations_url":"https://api.github.com/users/OrionDevelopment/orgs","repos_url":"https://api.github.com/users/OrionDevelopment/repos","events_url":"https://api.github.com/users/OrionDevelopment/events{/privacy}","received_events_url":"https://api.github.com/users/OrionDevelopment/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/1001/commits","review_comments_url":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/1001/comments","review_comment_url":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Minecolonies/minecolonies/issues/1001/comments","statuses_url":"https://api.github.com/repos/Minecolonies/minecolonies/statuses/99908acea5e6c498b527d5f47384d4911047255c","head":{"label":"Minecolonies:Feature/api-rework","ref":"Feature/api-rework","sha":"99908acea5e6c498b527d5f47384d4911047255c","user":{"login":"Minecolonies","id":5167336,"avatar_url":"https://avatars0.githubusercontent.com/u/5167336?v=3","gravatar_id":"","url":"https://api.github.com/users/Minecolonies","html_url":"https://github.com/Minecolonies","followers_url":"https://api.github.com/users/Minecolonies/followers","following_url":"https://api.github.com/users/Minecolonies/following{/other_user}","gists_url":"https://api.github.com/users/Minecolonies/gists{/gist_id}","starred_url":"https://api.github.com/users/Minecolonies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Minecolonies/subscriptions","organizations_url":"https://api.github.com/users/Minecolonies/orgs","repos_url":"https://api.github.com/users/Minecolonies/repos","events_url":"https://api.github.com/users/Minecolonies/events{/privacy}","received_events_url":"https://api.github.com/users/Minecolonies/received_events","type":"Organization","site_admin":false},"repo":{"id":65616760,"name":"minecolonies","full_name":"Minecolonies/minecolonies","owner":{"login":"Minecolonies","id":5167336,"avatar_url":"https://avatars0.githubusercontent.com/u/5167336?v=3","gravatar_id":"","url":"https://api.github.com/users/Minecolonies","html_url":"https://github.com/Minecolonies","followers_url":"https://api.github.com/users/Minecolonies/followers","following_url":"https://api.github.com/users/Minecolonies/following{/other_user}","gists_url":"https://api.github.com/users/Minecolonies/gists{/gist_id}","starred_url":"https://api.github.com/users/Minecolonies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Minecolonies/subscriptions","organizations_url":"https://api.github.com/users/Minecolonies/orgs","repos_url":"https://api.github.com/users/Minecolonies/repos","events_url":"https://api.github.com/users/Minecolonies/events{/privacy}","received_events_url":"https://api.github.com/users/Minecolonies/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Minecolonies/minecolonies","description":"Minecolonies minecraft mod","fork":false,"url":"https://api.github.com/repos/Minecolonies/minecolonies","forks_url":"https://api.github.com/repos/Minecolonies/minecolonies/forks","keys_url":"https://api.github.com/repos/Minecolonies/minecolonies/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Minecolonies/minecolonies/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Minecolonies/minecolonies/teams","hooks_url":"https://api.github.com/repos/Minecolonies/minecolonies/hooks","issue_events_url":"https://api.github.com/repos/Minecolonies/minecolonies/issues/events{/number}","events_url":"https://api.github.com/repos/Minecolonies/minecolonies/events","assignees_url":"https://api.github.com/repos/Minecolonies/minecolonies/assignees{/user}","branches_url":"https://api.github.com/repos/Minecolonies/minecolonies/branches{/branch}","tags_url":"https://api.github.com/repos/Minecolonies/minecolonies/tags","blobs_url":"https://api.github.com/repos/Minecolonies/minecolonies/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Minecolonies/minecolonies/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Minecolonies/minecolonies/git/refs{/sha}","trees_url":"https://api.github.com/repos/Minecolonies/minecolonies/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Minecolonies/minecolonies/statuses/{sha}","languages_url":"https://api.github.com/repos/Minecolonies/minecolonies/languages","stargazers_url":"https://api.github.com/repos/Minecolonies/minecolonies/stargazers","contributors_url":"https://api.github.com/repos/Minecolonies/minecolonies/contributors","subscribers_url":"https://api.github.com/repos/Minecolonies/minecolonies/subscribers","subscription_url":"https://api.github.com/repos/Minecolonies/minecolonies/subscription","commits_url":"https://api.github.com/repos/Minecolonies/minecolonies/commits{/sha}","git_commits_url":"https://api.github.com/repos/Minecolonies/minecolonies/git/commits{/sha}","comments_url":"https://api.github.com/repos/Minecolonies/minecolonies/comments{/number}","issue_comment_url":"https://api.github.com/repos/Minecolonies/minecolonies/issues/comments{/number}","contents_url":"https://api.github.com/repos/Minecolonies/minecolonies/contents/{+path}","compare_url":"https://api.github.com/repos/Minecolonies/minecolonies/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Minecolonies/minecolonies/merges","archive_url":"https://api.github.com/repos/Minecolonies/minecolonies/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Minecolonies/minecolonies/downloads","issues_url":"https://api.github.com/repos/Minecolonies/minecolonies/issues{/number}","pulls_url":"https://api.github.com/repos/Minecolonies/minecolonies/pulls{/number}","milestones_url":"https://api.github.com/repos/Minecolonies/minecolonies/milestones{/number}","notifications_url":"https://api.github.com/repos/Minecolonies/minecolonies/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Minecolonies/minecolonies/labels{/name}","releases_url":"https://api.github.com/repos/Minecolonies/minecolonies/releases{/id}","deployments_url":"https://api.github.com/repos/Minecolonies/minecolonies/deployments","created_at":"2016-08-13T12:45:38Z","updated_at":"2017-06-21T04:59:07Z","pushed_at":"2017-06-22T20:39:58Z","git_url":"git://github.com/Minecolonies/minecolonies.git","ssh_url":"git@github.com:Minecolonies/minecolonies.git","clone_url":"https://github.com/Minecolonies/minecolonies.git","svn_url":"https://github.com/Minecolonies/minecolonies","homepage":"http://minecolonies.com/","size":22278,"stargazers_count":44,"watchers_count":44,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":35,"mirror_url":null,"open_issues_count":123,"forks":35,"open_issues":123,"watchers":44,"default_branch":"version/1.11"}},"base":{"label":"Minecolonies:version/1.11","ref":"version/1.11","sha":"8a91aeee92898377859166a91ed0e5b3bf090aa9","user":{"login":"Minecolonies","id":5167336,"avatar_url":"https://avatars0.githubusercontent.com/u/5167336?v=3","gravatar_id":"","url":"https://api.github.com/users/Minecolonies","html_url":"https://github.com/Minecolonies","followers_url":"https://api.github.com/users/Minecolonies/followers","following_url":"https://api.github.com/users/Minecolonies/following{/other_user}","gists_url":"https://api.github.com/users/Minecolonies/gists{/gist_id}","starred_url":"https://api.github.com/users/Minecolonies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Minecolonies/subscriptions","organizations_url":"https://api.github.com/users/Minecolonies/orgs","repos_url":"https://api.github.com/users/Minecolonies/repos","events_url":"https://api.github.com/users/Minecolonies/events{/privacy}","received_events_url":"https://api.github.com/users/Minecolonies/received_events","type":"Organization","site_admin":false},"repo":{"id":65616760,"name":"minecolonies","full_name":"Minecolonies/minecolonies","owner":{"login":"Minecolonies","id":5167336,"avatar_url":"https://avatars0.githubusercontent.com/u/5167336?v=3","gravatar_id":"","url":"https://api.github.com/users/Minecolonies","html_url":"https://github.com/Minecolonies","followers_url":"https://api.github.com/users/Minecolonies/followers","following_url":"https://api.github.com/users/Minecolonies/following{/other_user}","gists_url":"https://api.github.com/users/Minecolonies/gists{/gist_id}","starred_url":"https://api.github.com/users/Minecolonies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Minecolonies/subscriptions","organizations_url":"https://api.github.com/users/Minecolonies/orgs","repos_url":"https://api.github.com/users/Minecolonies/repos","events_url":"https://api.github.com/users/Minecolonies/events{/privacy}","received_events_url":"https://api.github.com/users/Minecolonies/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Minecolonies/minecolonies","description":"Minecolonies minecraft mod","fork":false,"url":"https://api.github.com/repos/Minecolonies/minecolonies","forks_url":"https://api.github.com/repos/Minecolonies/minecolonies/forks","keys_url":"https://api.github.com/repos/Minecolonies/minecolonies/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Minecolonies/minecolonies/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Minecolonies/minecolonies/teams","hooks_url":"https://api.github.com/repos/Minecolonies/minecolonies/hooks","issue_events_url":"https://api.github.com/repos/Minecolonies/minecolonies/issues/events{/number}","events_url":"https://api.github.com/repos/Minecolonies/minecolonies/events","assignees_url":"https://api.github.com/repos/Minecolonies/minecolonies/assignees{/user}","branches_url":"https://api.github.com/repos/Minecolonies/minecolonies/branches{/branch}","tags_url":"https://api.github.com/repos/Minecolonies/minecolonies/tags","blobs_url":"https://api.github.com/repos/Minecolonies/minecolonies/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Minecolonies/minecolonies/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Minecolonies/minecolonies/git/refs{/sha}","trees_url":"https://api.github.com/repos/Minecolonies/minecolonies/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Minecolonies/minecolonies/statuses/{sha}","languages_url":"https://api.github.com/repos/Minecolonies/minecolonies/languages","stargazers_url":"https://api.github.com/repos/Minecolonies/minecolonies/stargazers","contributors_url":"https://api.github.com/repos/Minecolonies/minecolonies/contributors","subscribers_url":"https://api.github.com/repos/Minecolonies/minecolonies/subscribers","subscription_url":"https://api.github.com/repos/Minecolonies/minecolonies/subscription","commits_url":"https://api.github.com/repos/Minecolonies/minecolonies/commits{/sha}","git_commits_url":"https://api.github.com/repos/Minecolonies/minecolonies/git/commits{/sha}","comments_url":"https://api.github.com/repos/Minecolonies/minecolonies/comments{/number}","issue_comment_url":"https://api.github.com/repos/Minecolonies/minecolonies/issues/comments{/number}","contents_url":"https://api.github.com/repos/Minecolonies/minecolonies/contents/{+path}","compare_url":"https://api.github.com/repos/Minecolonies/minecolonies/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Minecolonies/minecolonies/merges","archive_url":"https://api.github.com/repos/Minecolonies/minecolonies/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Minecolonies/minecolonies/downloads","issues_url":"https://api.github.com/repos/Minecolonies/minecolonies/issues{/number}","pulls_url":"https://api.github.com/repos/Minecolonies/minecolonies/pulls{/number}","milestones_url":"https://api.github.com/repos/Minecolonies/minecolonies/milestones{/number}","notifications_url":"https://api.github.com/repos/Minecolonies/minecolonies/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Minecolonies/minecolonies/labels{/name}","releases_url":"https://api.github.com/repos/Minecolonies/minecolonies/releases{/id}","deployments_url":"https://api.github.com/repos/Minecolonies/minecolonies/deployments","created_at":"2016-08-13T12:45:38Z","updated_at":"2017-06-21T04:59:07Z","pushed_at":"2017-06-22T20:39:58Z","git_url":"git://github.com/Minecolonies/minecolonies.git","ssh_url":"git@github.com:Minecolonies/minecolonies.git","clone_url":"https://github.com/Minecolonies/minecolonies.git","svn_url":"https://github.com/Minecolonies/minecolonies","homepage":"http://minecolonies.com/","size":22278,"stargazers_count":44,"watchers_count":44,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":35,"mirror_url":null,"open_issues_count":123,"forks":35,"open_issues":123,"watchers":44,"default_branch":"version/1.11"}},"_links":{"self":{"href":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/1001"},"html":{"href":"https://github.com/Minecolonies/minecolonies/pull/1001"},"issue":{"href":"https://api.github.com/repos/Minecolonies/minecolonies/issues/1001"},"comments":{"href":"https://api.github.com/repos/Minecolonies/minecolonies/issues/1001/comments"},"review_comments":{"href":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/1001/comments"},"review_comment":{"href":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/1001/commits"},"statuses":{"href":"https://api.github.com/repos/Minecolonies/minecolonies/statuses/99908acea5e6c498b527d5f47384d4911047255c"}}}}
{"actor":{"display_login":"codacy-bot"}}