{"action":"created","comment":{"url":"https://api.github.com/repos/Homebrew/homebrew-science/pulls/comments/135115244","pull_request_review_id":58490095,"id":135115244,"diff_hunk":"@@ -0,0 +1,42 @@\n+class Critic2 < Formula\n+  desc \"Analysis of quantum chemical interactions in molecules and solids.\"\n+  homepage \"https://github.com/aoterodelaroza/critic2\"\n+  url \"https://github.com/aoterodelaroza/critic2/archive/stable.tar.gz\"\n+  version \"stable\"\n+  sha256 \"5c0803d47fbbb061b9f0b44e56eeebd7aa3298b275b9253fecdae7847a1ff903\"\n+\n+  option \"with-libxc\", \"Compile with libxc support to calculate exchange and correlation densities\"\n+\n+  depends_on \"gcc\" => :build\n+  depends_on \"autoconf\" => :build\n+  depends_on \"automake\" => :build\n+  depends_on \"libxc\" => :optional\n+\n+  def install\n+    system \"autoreconf\", \"-i\"\n+\n+    if build.with? \"libxc\"\n+      system \"./configure\", \"--with-libxc-prefix=#{HOMEBREW_PREFIX}/lib\",\n+                            \"--with-libxc-include=#{HOMEBREW_PREFIX}/include\",","path":"critic2.rb","position":20,"original_position":20,"commit_id":"f3e0dd9c151033b88768719d6de921d858ecbf8b","original_commit_id":"f3e0dd9c151033b88768719d6de921d858ecbf8b","user":{"login":"jonchang","id":213484,"avatar_url":"https://avatars0.githubusercontent.com/u/213484?v=4","gravatar_id":"","url":"https://api.github.com/users/jonchang","html_url":"https://github.com/jonchang","followers_url":"https://api.github.com/users/jonchang/followers","following_url":"https://api.github.com/users/jonchang/following{/other_user}","gists_url":"https://api.github.com/users/jonchang/gists{/gist_id}","starred_url":"https://api.github.com/users/jonchang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonchang/subscriptions","organizations_url":"https://api.github.com/users/jonchang/orgs","repos_url":"https://api.github.com/users/jonchang/repos","events_url":"https://api.github.com/users/jonchang/events{/privacy}","received_events_url":"https://api.github.com/users/jonchang/received_events","type":"User","site_admin":false},"body":"Do something like `--with-libxc-include=#{Formula[\"libxc\"].opt_lib}\"`","created_at":"2017-08-24T19:59:21Z","updated_at":"2017-08-24T20:01:02Z","html_url":"https://github.com/Homebrew/homebrew-science/pull/6144#discussion_r135115244","pull_request_url":"https://api.github.com/repos/Homebrew/homebrew-science/pulls/6144","_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew-science/pulls/comments/135115244"},"html":{"href":"https://github.com/Homebrew/homebrew-science/pull/6144#discussion_r135115244"},"pull_request":{"href":"https://api.github.com/repos/Homebrew/homebrew-science/pulls/6144"}}},"pull_request":{"url":"https://api.github.com/repos/Homebrew/homebrew-science/pulls/6144","id":136364469,"html_url":"https://github.com/Homebrew/homebrew-science/pull/6144","diff_url":"https://github.com/Homebrew/homebrew-science/pull/6144.diff","patch_url":"https://github.com/Homebrew/homebrew-science/pull/6144.patch","issue_url":"https://api.github.com/repos/Homebrew/homebrew-science/issues/6144","number":6144,"state":"open","locked":false,"title":"Help wanted, critic2 stable (new formula)","user":{"login":"mkhorton","id":2976580,"avatar_url":"https://avatars0.githubusercontent.com/u/2976580?v=4","gravatar_id":"","url":"https://api.github.com/users/mkhorton","html_url":"https://github.com/mkhorton","followers_url":"https://api.github.com/users/mkhorton/followers","following_url":"https://api.github.com/users/mkhorton/following{/other_user}","gists_url":"https://api.github.com/users/mkhorton/gists{/gist_id}","starred_url":"https://api.github.com/users/mkhorton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkhorton/subscriptions","organizations_url":"https://api.github.com/users/mkhorton/orgs","repos_url":"https://api.github.com/users/mkhorton/repos","events_url":"https://api.github.com/users/mkhorton/events{/privacy}","received_events_url":"https://api.github.com/users/mkhorton/received_events","type":"User","site_admin":false},"body":"Analysis of quantum chemical interactions in molecules and solids.\r\n\r\n### Help wanted:\r\n\r\nFormula is almost complete, I can get it to install, but I have to manually run `make` a second time ... the first time `make` is run, it gives a `BuildError: Failed executing: make` with:\r\n\r\n` USE Precision_Model, ONLY: stnd\r\n    1\r\nFatal Error: Can't open module file 'precision_model.mod' for reading at (1): No such file or directory\r\ncompilation terminated.`\r\n\r\nFor some reason, accessing the shell in interactive mode and running `make` a second time then works fine and the formula installs correctly and seems fully functional. I'm a bit confused as to what this issue is caused by.\r\n\r\n### Have you:\r\n\r\n- [x] Followed the guidelines in our [Contributing](https://github.com/Homebrew/homebrew-science/blob/master/.github/CONTRIBUTING.md) document?\r\n    - Note that author doesn't provide a version number, but this is a tagged release on github and marked as stable.\r\n- [x] Checked to ensure there aren't other open [Pull Requests](https://github.com/Homebrew/homebrew-science/pulls) for the same update/change?\r\n- [x] Run `brew audit --strict --online <formula>` (where `<formula>` is the name of the formula you're submitting) and corrected all errors?\r\n- [ ] Built your formula locally prior to submission with `brew install <formula>`?\r\n      - Help wanted here! See above.\r\n\r\n### New formula: have you\r\n\r\n- [x] Written a sensible test? (The best test is to compile and run a sample program.)\r\n    - Test files are very large and not included in the source distribution, so test simply runs the program with an empty script to make sure it runs","created_at":"2017-08-17T22:09:07Z","updated_at":"2017-08-24T20:01:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"60001af516519ee505ab8fbdb30f11e1c731b457","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Homebrew/homebrew-science/pulls/6144/commits","review_comments_url":"https://api.github.com/repos/Homebrew/homebrew-science/pulls/6144/comments","review_comment_url":"https://api.github.com/repos/Homebrew/homebrew-science/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Homebrew/homebrew-science/issues/6144/comments","statuses_url":"https://api.github.com/repos/Homebrew/homebrew-science/statuses/f3e0dd9c151033b88768719d6de921d858ecbf8b","head":{"label":"mkhorton:patch-2","ref":"patch-2","sha":"f3e0dd9c151033b88768719d6de921d858ecbf8b","user":{"login":"mkhorton","id":2976580,"avatar_url":"https://avatars0.githubusercontent.com/u/2976580?v=4","gravatar_id":"","url":"https://api.github.com/users/mkhorton","html_url":"https://github.com/mkhorton","followers_url":"https://api.github.com/users/mkhorton/followers","following_url":"https://api.github.com/users/mkhorton/following{/other_user}","gists_url":"https://api.github.com/users/mkhorton/gists{/gist_id}","starred_url":"https://api.github.com/users/mkhorton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkhorton/subscriptions","organizations_url":"https://api.github.com/users/mkhorton/orgs","repos_url":"https://api.github.com/users/mkhorton/repos","events_url":"https://api.github.com/users/mkhorton/events{/privacy}","received_events_url":"https://api.github.com/users/mkhorton/received_events","type":"User","site_admin":false},"repo":{"id":14020187,"name":"homebrew-science","full_name":"mkhorton/homebrew-science","owner":{"login":"mkhorton","id":2976580,"avatar_url":"https://avatars0.githubusercontent.com/u/2976580?v=4","gravatar_id":"","url":"https://api.github.com/users/mkhorton","html_url":"https://github.com/mkhorton","followers_url":"https://api.github.com/users/mkhorton/followers","following_url":"https://api.github.com/users/mkhorton/following{/other_user}","gists_url":"https://api.github.com/users/mkhorton/gists{/gist_id}","starred_url":"https://api.github.com/users/mkhorton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkhorton/subscriptions","organizations_url":"https://api.github.com/users/mkhorton/orgs","repos_url":"https://api.github.com/users/mkhorton/repos","events_url":"https://api.github.com/users/mkhorton/events{/privacy}","received_events_url":"https://api.github.com/users/mkhorton/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mkhorton/homebrew-science","description":"Scientific formulae for the Homebrew package manager","fork":true,"url":"https://api.github.com/repos/mkhorton/homebrew-science","forks_url":"https://api.github.com/repos/mkhorton/homebrew-science/forks","keys_url":"https://api.github.com/repos/mkhorton/homebrew-science/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mkhorton/homebrew-science/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mkhorton/homebrew-science/teams","hooks_url":"https://api.github.com/repos/mkhorton/homebrew-science/hooks","issue_events_url":"https://api.github.com/repos/mkhorton/homebrew-science/issues/events{/number}","events_url":"https://api.github.com/repos/mkhorton/homebrew-science/events","assignees_url":"https://api.github.com/repos/mkhorton/homebrew-science/assignees{/user}","branches_url":"https://api.github.com/repos/mkhorton/homebrew-science/branches{/branch}","tags_url":"https://api.github.com/repos/mkhorton/homebrew-science/tags","blobs_url":"https://api.github.com/repos/mkhorton/homebrew-science/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mkhorton/homebrew-science/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mkhorton/homebrew-science/git/refs{/sha}","trees_url":"https://api.github.com/repos/mkhorton/homebrew-science/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mkhorton/homebrew-science/statuses/{sha}","languages_url":"https://api.github.com/repos/mkhorton/homebrew-science/languages","stargazers_url":"https://api.github.com/repos/mkhorton/homebrew-science/stargazers","contributors_url":"https://api.github.com/repos/mkhorton/homebrew-science/contributors","subscribers_url":"https://api.github.com/repos/mkhorton/homebrew-science/subscribers","subscription_url":"https://api.github.com/repos/mkhorton/homebrew-science/subscription","commits_url":"https://api.github.com/repos/mkhorton/homebrew-science/commits{/sha}","git_commits_url":"https://api.github.com/repos/mkhorton/homebrew-science/git/commits{/sha}","comments_url":"https://api.github.com/repos/mkhorton/homebrew-science/comments{/number}","issue_comment_url":"https://api.github.com/repos/mkhorton/homebrew-science/issues/comments{/number}","contents_url":"https://api.github.com/repos/mkhorton/homebrew-science/contents/{+path}","compare_url":"https://api.github.com/repos/mkhorton/homebrew-science/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mkhorton/homebrew-science/merges","archive_url":"https://api.github.com/repos/mkhorton/homebrew-science/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mkhorton/homebrew-science/downloads","issues_url":"https://api.github.com/repos/mkhorton/homebrew-science/issues{/number}","pulls_url":"https://api.github.com/repos/mkhorton/homebrew-science/pulls{/number}","milestones_url":"https://api.github.com/repos/mkhorton/homebrew-science/milestones{/number}","notifications_url":"https://api.github.com/repos/mkhorton/homebrew-science/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mkhorton/homebrew-science/labels{/name}","releases_url":"https://api.github.com/repos/mkhorton/homebrew-science/releases{/id}","deployments_url":"https://api.github.com/repos/mkhorton/homebrew-science/deployments","created_at":"2013-10-31T15:07:11Z","updated_at":"2013-11-19T00:13:45Z","pushed_at":"2017-08-17T22:16:02Z","git_url":"git://github.com/mkhorton/homebrew-science.git","ssh_url":"git@github.com:mkhorton/homebrew-science.git","clone_url":"https://github.com/mkhorton/homebrew-science.git","svn_url":"https://github.com/mkhorton/homebrew-science","homepage":"brew.sh","size":9468,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Homebrew:master","ref":"master","sha":"5b2732a7cb235a216b6a705acd71dab8a2490442","user":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars2.githubusercontent.com/u/1503512?v=4","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"repo":{"id":4106792,"name":"homebrew-science","full_name":"Homebrew/homebrew-science","owner":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars2.githubusercontent.com/u/1503512?v=4","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Homebrew/homebrew-science","description":":beer::microscope: Scientific formulae for the Homebrew package manager","fork":false,"url":"https://api.github.com/repos/Homebrew/homebrew-science","forks_url":"https://api.github.com/repos/Homebrew/homebrew-science/forks","keys_url":"https://api.github.com/repos/Homebrew/homebrew-science/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Homebrew/homebrew-science/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Homebrew/homebrew-science/teams","hooks_url":"https://api.github.com/repos/Homebrew/homebrew-science/hooks","issue_events_url":"https://api.github.com/repos/Homebrew/homebrew-science/issues/events{/number}","events_url":"https://api.github.com/repos/Homebrew/homebrew-science/events","assignees_url":"https://api.github.com/repos/Homebrew/homebrew-science/assignees{/user}","branches_url":"https://api.github.com/repos/Homebrew/homebrew-science/branches{/branch}","tags_url":"https://api.github.com/repos/Homebrew/homebrew-science/tags","blobs_url":"https://api.github.com/repos/Homebrew/homebrew-science/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Homebrew/homebrew-science/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Homebrew/homebrew-science/git/refs{/sha}","trees_url":"https://api.github.com/repos/Homebrew/homebrew-science/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Homebrew/homebrew-science/statuses/{sha}","languages_url":"https://api.github.com/repos/Homebrew/homebrew-science/languages","stargazers_url":"https://api.github.com/repos/Homebrew/homebrew-science/stargazers","contributors_url":"https://api.github.com/repos/Homebrew/homebrew-science/contributors","subscribers_url":"https://api.github.com/repos/Homebrew/homebrew-science/subscribers","subscription_url":"https://api.github.com/repos/Homebrew/homebrew-science/subscription","commits_url":"https://api.github.com/repos/Homebrew/homebrew-science/commits{/sha}","git_commits_url":"https://api.github.com/repos/Homebrew/homebrew-science/git/commits{/sha}","comments_url":"https://api.github.com/repos/Homebrew/homebrew-science/comments{/number}","issue_comment_url":"https://api.github.com/repos/Homebrew/homebrew-science/issues/comments{/number}","contents_url":"https://api.github.com/repos/Homebrew/homebrew-science/contents/{+path}","compare_url":"https://api.github.com/repos/Homebrew/homebrew-science/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Homebrew/homebrew-science/merges","archive_url":"https://api.github.com/repos/Homebrew/homebrew-science/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Homebrew/homebrew-science/downloads","issues_url":"https://api.github.com/repos/Homebrew/homebrew-science/issues{/number}","pulls_url":"https://api.github.com/repos/Homebrew/homebrew-science/pulls{/number}","milestones_url":"https://api.github.com/repos/Homebrew/homebrew-science/milestones{/number}","notifications_url":"https://api.github.com/repos/Homebrew/homebrew-science/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Homebrew/homebrew-science/labels{/name}","releases_url":"https://api.github.com/repos/Homebrew/homebrew-science/releases{/id}","deployments_url":"https://api.github.com/repos/Homebrew/homebrew-science/deployments","created_at":"2012-04-22T20:16:34Z","updated_at":"2017-08-21T01:09:17Z","pushed_at":"2017-08-24T08:32:07Z","git_url":"git://github.com/Homebrew/homebrew-science.git","ssh_url":"git@github.com:Homebrew/homebrew-science.git","clone_url":"https://github.com/Homebrew/homebrew-science.git","svn_url":"https://github.com/Homebrew/homebrew-science","homepage":"http://braumeister.org/repos/Homebrew/homebrew-science/browse/a","size":9599,"stargazers_count":956,"watchers_count":956,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":926,"mirror_url":null,"open_issues_count":162,"forks":926,"open_issues":162,"watchers":956,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew-science/pulls/6144"},"html":{"href":"https://github.com/Homebrew/homebrew-science/pull/6144"},"issue":{"href":"https://api.github.com/repos/Homebrew/homebrew-science/issues/6144"},"comments":{"href":"https://api.github.com/repos/Homebrew/homebrew-science/issues/6144/comments"},"review_comments":{"href":"https://api.github.com/repos/Homebrew/homebrew-science/pulls/6144/comments"},"review_comment":{"href":"https://api.github.com/repos/Homebrew/homebrew-science/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Homebrew/homebrew-science/pulls/6144/commits"},"statuses":{"href":"https://api.github.com/repos/Homebrew/homebrew-science/statuses/f3e0dd9c151033b88768719d6de921d858ecbf8b"}}}}
{"actor":{"display_login":"jonchang"}}