{"action":"closed","number":3089,"pull_request":{"url":"https://api.github.com/repos/aframevr/aframe/pulls/3089","id":143611312,"html_url":"https://github.com/aframevr/aframe/pull/3089","diff_url":"https://github.com/aframevr/aframe/pull/3089.diff","patch_url":"https://github.com/aframevr/aframe/pull/3089.patch","issue_url":"https://api.github.com/repos/aframevr/aframe/issues/3089","number":3089,"state":"closed","locked":false,"title":"Improved image check in src-loader by sending a head request and chec…","user":{"login":"timstrehlow","id":2580926,"avatar_url":"https://avatars2.githubusercontent.com/u/2580926?v=4","gravatar_id":"","url":"https://api.github.com/users/timstrehlow","html_url":"https://github.com/timstrehlow","followers_url":"https://api.github.com/users/timstrehlow/followers","following_url":"https://api.github.com/users/timstrehlow/following{/other_user}","gists_url":"https://api.github.com/users/timstrehlow/gists{/gist_id}","starred_url":"https://api.github.com/users/timstrehlow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timstrehlow/subscriptions","organizations_url":"https://api.github.com/users/timstrehlow/orgs","repos_url":"https://api.github.com/users/timstrehlow/repos","events_url":"https://api.github.com/users/timstrehlow/events{/privacy}","received_events_url":"https://api.github.com/users/timstrehlow/received_events","type":"User","site_admin":false},"body":"…king content-type - using old method as a fallback if head is not supported\r\n\r\nIn Safari I had the problem that the event listeners on the image-object in the checkIsImage()-function would not be called until the source file was fully loaded. In my case it was a 70 MB video file, and a-frame was not rendering the video until the onResult(false) callback was called.\r\nTherefore I replaced the check with a HEAD XHR request checking for the content-type. The old method is still included as a fallback.","created_at":"2017-09-28T10:29:11Z","updated_at":"2017-10-02T02:05:54Z","closed_at":"2017-10-02T02:05:54Z","merged_at":"2017-10-02T02:05:54Z","merge_commit_sha":"64cf5b45e49454889e1e50d09cccadfd1b498cd3","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/aframevr/aframe/pulls/3089/commits","review_comments_url":"https://api.github.com/repos/aframevr/aframe/pulls/3089/comments","review_comment_url":"https://api.github.com/repos/aframevr/aframe/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aframevr/aframe/issues/3089/comments","statuses_url":"https://api.github.com/repos/aframevr/aframe/statuses/4f8b68dadca82190edf79b0bbb1f2cac9d14f1f1","head":{"label":"timstrehlow:image-check","ref":"image-check","sha":"4f8b68dadca82190edf79b0bbb1f2cac9d14f1f1","user":{"login":"timstrehlow","id":2580926,"avatar_url":"https://avatars2.githubusercontent.com/u/2580926?v=4","gravatar_id":"","url":"https://api.github.com/users/timstrehlow","html_url":"https://github.com/timstrehlow","followers_url":"https://api.github.com/users/timstrehlow/followers","following_url":"https://api.github.com/users/timstrehlow/following{/other_user}","gists_url":"https://api.github.com/users/timstrehlow/gists{/gist_id}","starred_url":"https://api.github.com/users/timstrehlow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timstrehlow/subscriptions","organizations_url":"https://api.github.com/users/timstrehlow/orgs","repos_url":"https://api.github.com/users/timstrehlow/repos","events_url":"https://api.github.com/users/timstrehlow/events{/privacy}","received_events_url":"https://api.github.com/users/timstrehlow/received_events","type":"User","site_admin":false},"repo":{"id":105133654,"name":"aframe","full_name":"timstrehlow/aframe","owner":{"login":"timstrehlow","id":2580926,"avatar_url":"https://avatars2.githubusercontent.com/u/2580926?v=4","gravatar_id":"","url":"https://api.github.com/users/timstrehlow","html_url":"https://github.com/timstrehlow","followers_url":"https://api.github.com/users/timstrehlow/followers","following_url":"https://api.github.com/users/timstrehlow/following{/other_user}","gists_url":"https://api.github.com/users/timstrehlow/gists{/gist_id}","starred_url":"https://api.github.com/users/timstrehlow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timstrehlow/subscriptions","organizations_url":"https://api.github.com/users/timstrehlow/orgs","repos_url":"https://api.github.com/users/timstrehlow/repos","events_url":"https://api.github.com/users/timstrehlow/events{/privacy}","received_events_url":"https://api.github.com/users/timstrehlow/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/timstrehlow/aframe","description":":a: web framework for building virtual reality experiences.","fork":true,"url":"https://api.github.com/repos/timstrehlow/aframe","forks_url":"https://api.github.com/repos/timstrehlow/aframe/forks","keys_url":"https://api.github.com/repos/timstrehlow/aframe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/timstrehlow/aframe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/timstrehlow/aframe/teams","hooks_url":"https://api.github.com/repos/timstrehlow/aframe/hooks","issue_events_url":"https://api.github.com/repos/timstrehlow/aframe/issues/events{/number}","events_url":"https://api.github.com/repos/timstrehlow/aframe/events","assignees_url":"https://api.github.com/repos/timstrehlow/aframe/assignees{/user}","branches_url":"https://api.github.com/repos/timstrehlow/aframe/branches{/branch}","tags_url":"https://api.github.com/repos/timstrehlow/aframe/tags","blobs_url":"https://api.github.com/repos/timstrehlow/aframe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/timstrehlow/aframe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/timstrehlow/aframe/git/refs{/sha}","trees_url":"https://api.github.com/repos/timstrehlow/aframe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/timstrehlow/aframe/statuses/{sha}","languages_url":"https://api.github.com/repos/timstrehlow/aframe/languages","stargazers_url":"https://api.github.com/repos/timstrehlow/aframe/stargazers","contributors_url":"https://api.github.com/repos/timstrehlow/aframe/contributors","subscribers_url":"https://api.github.com/repos/timstrehlow/aframe/subscribers","subscription_url":"https://api.github.com/repos/timstrehlow/aframe/subscription","commits_url":"https://api.github.com/repos/timstrehlow/aframe/commits{/sha}","git_commits_url":"https://api.github.com/repos/timstrehlow/aframe/git/commits{/sha}","comments_url":"https://api.github.com/repos/timstrehlow/aframe/comments{/number}","issue_comment_url":"https://api.github.com/repos/timstrehlow/aframe/issues/comments{/number}","contents_url":"https://api.github.com/repos/timstrehlow/aframe/contents/{+path}","compare_url":"https://api.github.com/repos/timstrehlow/aframe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/timstrehlow/aframe/merges","archive_url":"https://api.github.com/repos/timstrehlow/aframe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/timstrehlow/aframe/downloads","issues_url":"https://api.github.com/repos/timstrehlow/aframe/issues{/number}","pulls_url":"https://api.github.com/repos/timstrehlow/aframe/pulls{/number}","milestones_url":"https://api.github.com/repos/timstrehlow/aframe/milestones{/number}","notifications_url":"https://api.github.com/repos/timstrehlow/aframe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/timstrehlow/aframe/labels{/name}","releases_url":"https://api.github.com/repos/timstrehlow/aframe/releases{/id}","deployments_url":"https://api.github.com/repos/timstrehlow/aframe/deployments","created_at":"2017-09-28T10:11:00Z","updated_at":"2017-09-28T10:11:03Z","pushed_at":"2017-10-02T02:02:17Z","git_url":"git://github.com/timstrehlow/aframe.git","ssh_url":"git@github.com:timstrehlow/aframe.git","clone_url":"https://github.com/timstrehlow/aframe.git","svn_url":"https://github.com/timstrehlow/aframe","homepage":"https://aframe.io/","size":174277,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"aframevr:master","ref":"master","sha":"8307f2cce8518d8fae258f75f59a39f85679c4ba","user":{"login":"aframevr","id":16024092,"avatar_url":"https://avatars0.githubusercontent.com/u/16024092?v=4","gravatar_id":"","url":"https://api.github.com/users/aframevr","html_url":"https://github.com/aframevr","followers_url":"https://api.github.com/users/aframevr/followers","following_url":"https://api.github.com/users/aframevr/following{/other_user}","gists_url":"https://api.github.com/users/aframevr/gists{/gist_id}","starred_url":"https://api.github.com/users/aframevr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aframevr/subscriptions","organizations_url":"https://api.github.com/users/aframevr/orgs","repos_url":"https://api.github.com/users/aframevr/repos","events_url":"https://api.github.com/users/aframevr/events{/privacy}","received_events_url":"https://api.github.com/users/aframevr/received_events","type":"Organization","site_admin":false},"repo":{"id":42488903,"name":"aframe","full_name":"aframevr/aframe","owner":{"login":"aframevr","id":16024092,"avatar_url":"https://avatars0.githubusercontent.com/u/16024092?v=4","gravatar_id":"","url":"https://api.github.com/users/aframevr","html_url":"https://github.com/aframevr","followers_url":"https://api.github.com/users/aframevr/followers","following_url":"https://api.github.com/users/aframevr/following{/other_user}","gists_url":"https://api.github.com/users/aframevr/gists{/gist_id}","starred_url":"https://api.github.com/users/aframevr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aframevr/subscriptions","organizations_url":"https://api.github.com/users/aframevr/orgs","repos_url":"https://api.github.com/users/aframevr/repos","events_url":"https://api.github.com/users/aframevr/events{/privacy}","received_events_url":"https://api.github.com/users/aframevr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aframevr/aframe","description":":a: web framework for building virtual reality experiences.","fork":false,"url":"https://api.github.com/repos/aframevr/aframe","forks_url":"https://api.github.com/repos/aframevr/aframe/forks","keys_url":"https://api.github.com/repos/aframevr/aframe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aframevr/aframe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aframevr/aframe/teams","hooks_url":"https://api.github.com/repos/aframevr/aframe/hooks","issue_events_url":"https://api.github.com/repos/aframevr/aframe/issues/events{/number}","events_url":"https://api.github.com/repos/aframevr/aframe/events","assignees_url":"https://api.github.com/repos/aframevr/aframe/assignees{/user}","branches_url":"https://api.github.com/repos/aframevr/aframe/branches{/branch}","tags_url":"https://api.github.com/repos/aframevr/aframe/tags","blobs_url":"https://api.github.com/repos/aframevr/aframe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aframevr/aframe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aframevr/aframe/git/refs{/sha}","trees_url":"https://api.github.com/repos/aframevr/aframe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aframevr/aframe/statuses/{sha}","languages_url":"https://api.github.com/repos/aframevr/aframe/languages","stargazers_url":"https://api.github.com/repos/aframevr/aframe/stargazers","contributors_url":"https://api.github.com/repos/aframevr/aframe/contributors","subscribers_url":"https://api.github.com/repos/aframevr/aframe/subscribers","subscription_url":"https://api.github.com/repos/aframevr/aframe/subscription","commits_url":"https://api.github.com/repos/aframevr/aframe/commits{/sha}","git_commits_url":"https://api.github.com/repos/aframevr/aframe/git/commits{/sha}","comments_url":"https://api.github.com/repos/aframevr/aframe/comments{/number}","issue_comment_url":"https://api.github.com/repos/aframevr/aframe/issues/comments{/number}","contents_url":"https://api.github.com/repos/aframevr/aframe/contents/{+path}","compare_url":"https://api.github.com/repos/aframevr/aframe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aframevr/aframe/merges","archive_url":"https://api.github.com/repos/aframevr/aframe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aframevr/aframe/downloads","issues_url":"https://api.github.com/repos/aframevr/aframe/issues{/number}","pulls_url":"https://api.github.com/repos/aframevr/aframe/pulls{/number}","milestones_url":"https://api.github.com/repos/aframevr/aframe/milestones{/number}","notifications_url":"https://api.github.com/repos/aframevr/aframe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aframevr/aframe/labels{/name}","releases_url":"https://api.github.com/repos/aframevr/aframe/releases{/id}","deployments_url":"https://api.github.com/repos/aframevr/aframe/deployments","created_at":"2015-09-15T02:04:40Z","updated_at":"2017-10-01T23:40:23Z","pushed_at":"2017-10-02T02:05:54Z","git_url":"git://github.com/aframevr/aframe.git","ssh_url":"git@github.com:aframevr/aframe.git","clone_url":"https://github.com/aframevr/aframe.git","svn_url":"https://github.com/aframevr/aframe","homepage":"https://aframe.io/","size":175195,"stargazers_count":6607,"watchers_count":6607,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1449,"mirror_url":null,"open_issues_count":214,"forks":1449,"open_issues":214,"watchers":6607,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aframevr/aframe/pulls/3089"},"html":{"href":"https://github.com/aframevr/aframe/pull/3089"},"issue":{"href":"https://api.github.com/repos/aframevr/aframe/issues/3089"},"comments":{"href":"https://api.github.com/repos/aframevr/aframe/issues/3089/comments"},"review_comments":{"href":"https://api.github.com/repos/aframevr/aframe/pulls/3089/comments"},"review_comment":{"href":"https://api.github.com/repos/aframevr/aframe/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aframevr/aframe/pulls/3089/commits"},"statuses":{"href":"https://api.github.com/repos/aframevr/aframe/statuses/4f8b68dadca82190edf79b0bbb1f2cac9d14f1f1"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"ngokevin","id":674727,"avatar_url":"https://avatars2.githubusercontent.com/u/674727?v=4","gravatar_id":"","url":"https://api.github.com/users/ngokevin","html_url":"https://github.com/ngokevin","followers_url":"https://api.github.com/users/ngokevin/followers","following_url":"https://api.github.com/users/ngokevin/following{/other_user}","gists_url":"https://api.github.com/users/ngokevin/gists{/gist_id}","starred_url":"https://api.github.com/users/ngokevin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngokevin/subscriptions","organizations_url":"https://api.github.com/users/ngokevin/orgs","repos_url":"https://api.github.com/users/ngokevin/repos","events_url":"https://api.github.com/users/ngokevin/events{/privacy}","received_events_url":"https://api.github.com/users/ngokevin/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":28,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"ngokevin"}}