{"action":"created","comment":{"url":"https://api.github.com/repos/rackerlabs/design-system/pulls/comments/146721473","pull_request_review_id":71705428,"id":146721473,"diff_hunk":"@@ -10,9 +10,158 @@ resource: true\n last-modified: 2017-08-17","path":"_component_design/tables-basic.md","position":8,"original_position":8,"commit_id":"58f99b9b5c4dc256e7a0cc6d02dc4686af332c72","original_commit_id":"58f99b9b5c4dc256e7a0cc6d02dc4686af332c72","user":{"login":"technabors","id":586682,"avatar_url":"https://avatars3.githubusercontent.com/u/586682?v=4","gravatar_id":"","url":"https://api.github.com/users/technabors","html_url":"https://github.com/technabors","followers_url":"https://api.github.com/users/technabors/followers","following_url":"https://api.github.com/users/technabors/following{/other_user}","gists_url":"https://api.github.com/users/technabors/gists{/gist_id}","starred_url":"https://api.github.com/users/technabors/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/technabors/subscriptions","organizations_url":"https://api.github.com/users/technabors/orgs","repos_url":"https://api.github.com/users/technabors/repos","events_url":"https://api.github.com/users/technabors/events{/privacy}","received_events_url":"https://api.github.com/users/technabors/received_events","type":"User","site_admin":false},"body":"```\r\nstatus: Stable\r\nresource: true\r\nlast-modified: 2017-10-24\r\n```\r\nAdded across all three docs 😛","created_at":"2017-10-24T23:34:52Z","updated_at":"2017-10-24T23:34:53Z","html_url":"https://github.com/rackerlabs/design-system/pull/302#discussion_r146721473","pull_request_url":"https://api.github.com/repos/rackerlabs/design-system/pulls/302","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/rackerlabs/design-system/pulls/comments/146721473"},"html":{"href":"https://github.com/rackerlabs/design-system/pull/302#discussion_r146721473"},"pull_request":{"href":"https://api.github.com/repos/rackerlabs/design-system/pulls/302"}},"in_reply_to_id":146614461},"pull_request":{"url":"https://api.github.com/repos/rackerlabs/design-system/pulls/302","id":148030422,"html_url":"https://github.com/rackerlabs/design-system/pull/302","diff_url":"https://github.com/rackerlabs/design-system/pull/302.diff","patch_url":"https://github.com/rackerlabs/design-system/pull/302.patch","issue_url":"https://api.github.com/repos/rackerlabs/design-system/issues/302","number":302,"state":"open","locked":false,"title":"docs(tables): convert tables docs","user":{"login":"technabors","id":586682,"avatar_url":"https://avatars3.githubusercontent.com/u/586682?v=4","gravatar_id":"","url":"https://api.github.com/users/technabors","html_url":"https://github.com/technabors","followers_url":"https://api.github.com/users/technabors/followers","following_url":"https://api.github.com/users/technabors/following{/other_user}","gists_url":"https://api.github.com/users/technabors/gists{/gist_id}","starred_url":"https://api.github.com/users/technabors/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/technabors/subscriptions","organizations_url":"https://api.github.com/users/technabors/orgs","repos_url":"https://api.github.com/users/technabors/repos","events_url":"https://api.github.com/users/technabors/events{/privacy}","received_events_url":"https://api.github.com/users/technabors/received_events","type":"User","site_admin":false},"body":"This PR converts the tables doc into a multiple md files. Notes below\r\n\r\n- ` tables-old.md` file renamed to tables-basic\r\n- Original content from this page was left in tables-basic commented out. This is only to ensure if we missed something on the review we can easily pull it back it. These commented out lines will be removed in another commit prior to merge.\r\n- `tables-nested.md` file added with content that applies to this scope of the tables documentation\r\n- `tables-controls.md` file added with content that applies to this scope of the tables documentation\r\n- New usage details were written and placed in the YAML of the previous two docs.\r\n- New thumbnail SVGs were built. These were placed back into the source doc in GDrive as symbols on the sketch file. Files were also uploaded to CDN and added to YAML of the respective file.\r\n- Tons of SVGs added in new directory `/assets/images/components/tables/$page/`\r\n- All SVGs converted to outline mode.\r\n\r\nNote: I have yet to read through these pages and look at them in conjunction with each other and understand where to cross link. I also can't speak to the content strategy as this was just the initial  conversion from sketch. This review will be the longest of the bunch and I expect require quite a bit of edits. Also, lets try to put our thinking caps on when reading this one and look at the content across all sections.","created_at":"2017-10-23T02:50:45Z","updated_at":"2017-10-24T23:34:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e2c4bdab1c4a2eb612283e1d581a0e16ad8f9607","assignee":null,"assignees":[],"requested_reviewers":[{"login":"asettle","id":1987994,"avatar_url":"https://avatars3.githubusercontent.com/u/1987994?v=4","gravatar_id":"","url":"https://api.github.com/users/asettle","html_url":"https://github.com/asettle","followers_url":"https://api.github.com/users/asettle/followers","following_url":"https://api.github.com/users/asettle/following{/other_user}","gists_url":"https://api.github.com/users/asettle/gists{/gist_id}","starred_url":"https://api.github.com/users/asettle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asettle/subscriptions","organizations_url":"https://api.github.com/users/asettle/orgs","repos_url":"https://api.github.com/users/asettle/repos","events_url":"https://api.github.com/users/asettle/events{/privacy}","received_events_url":"https://api.github.com/users/asettle/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/rackerlabs/design-system/pulls/302/commits","review_comments_url":"https://api.github.com/repos/rackerlabs/design-system/pulls/302/comments","review_comment_url":"https://api.github.com/repos/rackerlabs/design-system/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rackerlabs/design-system/issues/302/comments","statuses_url":"https://api.github.com/repos/rackerlabs/design-system/statuses/58f99b9b5c4dc256e7a0cc6d02dc4686af332c72","head":{"label":"rackerlabs:tables-docs/evan","ref":"tables-docs/evan","sha":"58f99b9b5c4dc256e7a0cc6d02dc4686af332c72","user":{"login":"rackerlabs","id":84293,"avatar_url":"https://avatars1.githubusercontent.com/u/84293?v=4","gravatar_id":"","url":"https://api.github.com/users/rackerlabs","html_url":"https://github.com/rackerlabs","followers_url":"https://api.github.com/users/rackerlabs/followers","following_url":"https://api.github.com/users/rackerlabs/following{/other_user}","gists_url":"https://api.github.com/users/rackerlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rackerlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackerlabs/subscriptions","organizations_url":"https://api.github.com/users/rackerlabs/orgs","repos_url":"https://api.github.com/users/rackerlabs/repos","events_url":"https://api.github.com/users/rackerlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rackerlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":63092460,"name":"design-system","full_name":"rackerlabs/design-system","owner":{"login":"rackerlabs","id":84293,"avatar_url":"https://avatars1.githubusercontent.com/u/84293?v=4","gravatar_id":"","url":"https://api.github.com/users/rackerlabs","html_url":"https://github.com/rackerlabs","followers_url":"https://api.github.com/users/rackerlabs/followers","following_url":"https://api.github.com/users/rackerlabs/following{/other_user}","gists_url":"https://api.github.com/users/rackerlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rackerlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackerlabs/subscriptions","organizations_url":"https://api.github.com/users/rackerlabs/orgs","repos_url":"https://api.github.com/users/rackerlabs/repos","events_url":"https://api.github.com/users/rackerlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rackerlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rackerlabs/design-system","description":"A prototype of the Design System created by Rackspace Experience Design","fork":false,"url":"https://api.github.com/repos/rackerlabs/design-system","forks_url":"https://api.github.com/repos/rackerlabs/design-system/forks","keys_url":"https://api.github.com/repos/rackerlabs/design-system/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rackerlabs/design-system/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rackerlabs/design-system/teams","hooks_url":"https://api.github.com/repos/rackerlabs/design-system/hooks","issue_events_url":"https://api.github.com/repos/rackerlabs/design-system/issues/events{/number}","events_url":"https://api.github.com/repos/rackerlabs/design-system/events","assignees_url":"https://api.github.com/repos/rackerlabs/design-system/assignees{/user}","branches_url":"https://api.github.com/repos/rackerlabs/design-system/branches{/branch}","tags_url":"https://api.github.com/repos/rackerlabs/design-system/tags","blobs_url":"https://api.github.com/repos/rackerlabs/design-system/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rackerlabs/design-system/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rackerlabs/design-system/git/refs{/sha}","trees_url":"https://api.github.com/repos/rackerlabs/design-system/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rackerlabs/design-system/statuses/{sha}","languages_url":"https://api.github.com/repos/rackerlabs/design-system/languages","stargazers_url":"https://api.github.com/repos/rackerlabs/design-system/stargazers","contributors_url":"https://api.github.com/repos/rackerlabs/design-system/contributors","subscribers_url":"https://api.github.com/repos/rackerlabs/design-system/subscribers","subscription_url":"https://api.github.com/repos/rackerlabs/design-system/subscription","commits_url":"https://api.github.com/repos/rackerlabs/design-system/commits{/sha}","git_commits_url":"https://api.github.com/repos/rackerlabs/design-system/git/commits{/sha}","comments_url":"https://api.github.com/repos/rackerlabs/design-system/comments{/number}","issue_comment_url":"https://api.github.com/repos/rackerlabs/design-system/issues/comments{/number}","contents_url":"https://api.github.com/repos/rackerlabs/design-system/contents/{+path}","compare_url":"https://api.github.com/repos/rackerlabs/design-system/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rackerlabs/design-system/merges","archive_url":"https://api.github.com/repos/rackerlabs/design-system/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rackerlabs/design-system/downloads","issues_url":"https://api.github.com/repos/rackerlabs/design-system/issues{/number}","pulls_url":"https://api.github.com/repos/rackerlabs/design-system/pulls{/number}","milestones_url":"https://api.github.com/repos/rackerlabs/design-system/milestones{/number}","notifications_url":"https://api.github.com/repos/rackerlabs/design-system/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rackerlabs/design-system/labels{/name}","releases_url":"https://api.github.com/repos/rackerlabs/design-system/releases{/id}","deployments_url":"https://api.github.com/repos/rackerlabs/design-system/deployments","created_at":"2016-07-11T18:33:13Z","updated_at":"2017-08-03T13:06:19Z","pushed_at":"2017-10-24T23:22:29Z","git_url":"git://github.com/rackerlabs/design-system.git","ssh_url":"git@github.com:rackerlabs/design-system.git","clone_url":"https://github.com/rackerlabs/design-system.git","svn_url":"https://github.com/rackerlabs/design-system","homepage":"","size":238098,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":11,"forks":7,"open_issues":11,"watchers":5,"default_branch":"master"}},"base":{"label":"rackerlabs:staging","ref":"staging","sha":"bf081429b8c79eec7eb7bddd6dcc6ff170ec6295","user":{"login":"rackerlabs","id":84293,"avatar_url":"https://avatars1.githubusercontent.com/u/84293?v=4","gravatar_id":"","url":"https://api.github.com/users/rackerlabs","html_url":"https://github.com/rackerlabs","followers_url":"https://api.github.com/users/rackerlabs/followers","following_url":"https://api.github.com/users/rackerlabs/following{/other_user}","gists_url":"https://api.github.com/users/rackerlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rackerlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackerlabs/subscriptions","organizations_url":"https://api.github.com/users/rackerlabs/orgs","repos_url":"https://api.github.com/users/rackerlabs/repos","events_url":"https://api.github.com/users/rackerlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rackerlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":63092460,"name":"design-system","full_name":"rackerlabs/design-system","owner":{"login":"rackerlabs","id":84293,"avatar_url":"https://avatars1.githubusercontent.com/u/84293?v=4","gravatar_id":"","url":"https://api.github.com/users/rackerlabs","html_url":"https://github.com/rackerlabs","followers_url":"https://api.github.com/users/rackerlabs/followers","following_url":"https://api.github.com/users/rackerlabs/following{/other_user}","gists_url":"https://api.github.com/users/rackerlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rackerlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackerlabs/subscriptions","organizations_url":"https://api.github.com/users/rackerlabs/orgs","repos_url":"https://api.github.com/users/rackerlabs/repos","events_url":"https://api.github.com/users/rackerlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rackerlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rackerlabs/design-system","description":"A prototype of the Design System created by Rackspace Experience Design","fork":false,"url":"https://api.github.com/repos/rackerlabs/design-system","forks_url":"https://api.github.com/repos/rackerlabs/design-system/forks","keys_url":"https://api.github.com/repos/rackerlabs/design-system/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rackerlabs/design-system/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rackerlabs/design-system/teams","hooks_url":"https://api.github.com/repos/rackerlabs/design-system/hooks","issue_events_url":"https://api.github.com/repos/rackerlabs/design-system/issues/events{/number}","events_url":"https://api.github.com/repos/rackerlabs/design-system/events","assignees_url":"https://api.github.com/repos/rackerlabs/design-system/assignees{/user}","branches_url":"https://api.github.com/repos/rackerlabs/design-system/branches{/branch}","tags_url":"https://api.github.com/repos/rackerlabs/design-system/tags","blobs_url":"https://api.github.com/repos/rackerlabs/design-system/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rackerlabs/design-system/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rackerlabs/design-system/git/refs{/sha}","trees_url":"https://api.github.com/repos/rackerlabs/design-system/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rackerlabs/design-system/statuses/{sha}","languages_url":"https://api.github.com/repos/rackerlabs/design-system/languages","stargazers_url":"https://api.github.com/repos/rackerlabs/design-system/stargazers","contributors_url":"https://api.github.com/repos/rackerlabs/design-system/contributors","subscribers_url":"https://api.github.com/repos/rackerlabs/design-system/subscribers","subscription_url":"https://api.github.com/repos/rackerlabs/design-system/subscription","commits_url":"https://api.github.com/repos/rackerlabs/design-system/commits{/sha}","git_commits_url":"https://api.github.com/repos/rackerlabs/design-system/git/commits{/sha}","comments_url":"https://api.github.com/repos/rackerlabs/design-system/comments{/number}","issue_comment_url":"https://api.github.com/repos/rackerlabs/design-system/issues/comments{/number}","contents_url":"https://api.github.com/repos/rackerlabs/design-system/contents/{+path}","compare_url":"https://api.github.com/repos/rackerlabs/design-system/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rackerlabs/design-system/merges","archive_url":"https://api.github.com/repos/rackerlabs/design-system/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rackerlabs/design-system/downloads","issues_url":"https://api.github.com/repos/rackerlabs/design-system/issues{/number}","pulls_url":"https://api.github.com/repos/rackerlabs/design-system/pulls{/number}","milestones_url":"https://api.github.com/repos/rackerlabs/design-system/milestones{/number}","notifications_url":"https://api.github.com/repos/rackerlabs/design-system/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rackerlabs/design-system/labels{/name}","releases_url":"https://api.github.com/repos/rackerlabs/design-system/releases{/id}","deployments_url":"https://api.github.com/repos/rackerlabs/design-system/deployments","created_at":"2016-07-11T18:33:13Z","updated_at":"2017-08-03T13:06:19Z","pushed_at":"2017-10-24T23:22:29Z","git_url":"git://github.com/rackerlabs/design-system.git","ssh_url":"git@github.com:rackerlabs/design-system.git","clone_url":"https://github.com/rackerlabs/design-system.git","svn_url":"https://github.com/rackerlabs/design-system","homepage":"","size":238098,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":11,"forks":7,"open_issues":11,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rackerlabs/design-system/pulls/302"},"html":{"href":"https://github.com/rackerlabs/design-system/pull/302"},"issue":{"href":"https://api.github.com/repos/rackerlabs/design-system/issues/302"},"comments":{"href":"https://api.github.com/repos/rackerlabs/design-system/issues/302/comments"},"review_comments":{"href":"https://api.github.com/repos/rackerlabs/design-system/pulls/302/comments"},"review_comment":{"href":"https://api.github.com/repos/rackerlabs/design-system/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rackerlabs/design-system/pulls/302/commits"},"statuses":{"href":"https://api.github.com/repos/rackerlabs/design-system/statuses/58f99b9b5c4dc256e7a0cc6d02dc4686af332c72"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"technabors"}}