{"action":"created","comment":{"url":"https://api.github.com/repos/jenkinsci/google-storage-plugin/pulls/comments/144537160","pull_request_review_id":69207579,"id":144537160,"diff_hunk":"@@ -0,0 +1,94 @@\n+/*\n+ * Copyright 2017 Google Inc. All Rights Reserved.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ *     http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+package com.google.jenkins.plugins.storage.util;\n+\n+import com.google.common.base.Joiner;\n+import com.google.common.base.Strings;\n+import com.google.jenkins.plugins.storage.Messages;\n+import com.google.jenkins.plugins.storage.UploadException;\n+import hudson.FilePath;\n+import hudson.Util;\n+import hudson.model.AbstractBuild;\n+import hudson.model.Run;\n+import hudson.model.TaskListener;\n+import java.io.IOException;\n+import java.util.LinkedList;\n+\n+/**\n+ * A class to contain common utility operations\n+ */\n+public class StorageUtil {\n+  /**\n+   * Prefix the given log message with our module.\n+   */\n+  public static String prefix(String moduleName, String x) {","path":"src/main/java/com/google/jenkins/plugins/storage/util/StorageUtil.java","position":37,"original_position":37,"commit_id":"6a762096a0b53de5be1b6ce56321060ef99f78df","original_commit_id":"6a762096a0b53de5be1b6ce56321060ef99f78df","user":{"login":"bwkimmel","id":534844,"avatar_url":"https://avatars1.githubusercontent.com/u/534844?v=4","gravatar_id":"","url":"https://api.github.com/users/bwkimmel","html_url":"https://github.com/bwkimmel","followers_url":"https://api.github.com/users/bwkimmel/followers","following_url":"https://api.github.com/users/bwkimmel/following{/other_user}","gists_url":"https://api.github.com/users/bwkimmel/gists{/gist_id}","starred_url":"https://api.github.com/users/bwkimmel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bwkimmel/subscriptions","organizations_url":"https://api.github.com/users/bwkimmel/orgs","repos_url":"https://api.github.com/users/bwkimmel/repos","events_url":"https://api.github.com/users/bwkimmel/events{/privacy}","received_events_url":"https://api.github.com/users/bwkimmel/received_events","type":"User","site_admin":false},"body":"Can this be removed then (and the name of the PrefixFormat message reverted if it is only referenced from UploadModule)?","created_at":"2017-10-13T12:15:57Z","updated_at":"2017-10-13T12:15:57Z","html_url":"https://github.com/jenkinsci/google-storage-plugin/pull/30#discussion_r144537160","pull_request_url":"https://api.github.com/repos/jenkinsci/google-storage-plugin/pulls/30","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/google-storage-plugin/pulls/comments/144537160"},"html":{"href":"https://github.com/jenkinsci/google-storage-plugin/pull/30#discussion_r144537160"},"pull_request":{"href":"https://api.github.com/repos/jenkinsci/google-storage-plugin/pulls/30"}}},"pull_request":{"url":"https://api.github.com/repos/jenkinsci/google-storage-plugin/pulls/30","id":146105309,"html_url":"https://github.com/jenkinsci/google-storage-plugin/pull/30","diff_url":"https://github.com/jenkinsci/google-storage-plugin/pull/30.diff","patch_url":"https://github.com/jenkinsci/google-storage-plugin/pull/30.patch","issue_url":"https://api.github.com/repos/jenkinsci/google-storage-plugin/issues/30","number":30,"state":"open","locked":false,"title":"Introduced a new utility class.","user":{"login":"agoulti","id":26492059,"avatar_url":"https://avatars2.githubusercontent.com/u/26492059?v=4","gravatar_id":"","url":"https://api.github.com/users/agoulti","html_url":"https://github.com/agoulti","followers_url":"https://api.github.com/users/agoulti/followers","following_url":"https://api.github.com/users/agoulti/following{/other_user}","gists_url":"https://api.github.com/users/agoulti/gists{/gist_id}","starred_url":"https://api.github.com/users/agoulti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agoulti/subscriptions","organizations_url":"https://api.github.com/users/agoulti/orgs","repos_url":"https://api.github.com/users/agoulti/repos","events_url":"https://api.github.com/users/agoulti/events{/privacy}","received_events_url":"https://api.github.com/users/agoulti/received_events","type":"User","site_admin":false},"body":"StorageUtil will hold functionality that is to be common between the\r\nupload and download steps.\r\n\r\nFactored out the handling of paths and expansions.","created_at":"2017-10-12T02:42:00Z","updated_at":"2017-10-13T12:15:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"211ece1ea8dc386276b10a6a7b9b1ab0c0a86671","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/jenkinsci/google-storage-plugin/pulls/30/commits","review_comments_url":"https://api.github.com/repos/jenkinsci/google-storage-plugin/pulls/30/comments","review_comment_url":"https://api.github.com/repos/jenkinsci/google-storage-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jenkinsci/google-storage-plugin/issues/30/comments","statuses_url":"https://api.github.com/repos/jenkinsci/google-storage-plugin/statuses/6a762096a0b53de5be1b6ce56321060ef99f78df","head":{"label":"agoulti:incremental","ref":"incremental","sha":"6a762096a0b53de5be1b6ce56321060ef99f78df","user":{"login":"agoulti","id":26492059,"avatar_url":"https://avatars2.githubusercontent.com/u/26492059?v=4","gravatar_id":"","url":"https://api.github.com/users/agoulti","html_url":"https://github.com/agoulti","followers_url":"https://api.github.com/users/agoulti/followers","following_url":"https://api.github.com/users/agoulti/following{/other_user}","gists_url":"https://api.github.com/users/agoulti/gists{/gist_id}","starred_url":"https://api.github.com/users/agoulti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agoulti/subscriptions","organizations_url":"https://api.github.com/users/agoulti/orgs","repos_url":"https://api.github.com/users/agoulti/repos","events_url":"https://api.github.com/users/agoulti/events{/privacy}","received_events_url":"https://api.github.com/users/agoulti/received_events","type":"User","site_admin":false},"repo":{"id":101654275,"name":"google-storage-plugin","full_name":"agoulti/google-storage-plugin","owner":{"login":"agoulti","id":26492059,"avatar_url":"https://avatars2.githubusercontent.com/u/26492059?v=4","gravatar_id":"","url":"https://api.github.com/users/agoulti","html_url":"https://github.com/agoulti","followers_url":"https://api.github.com/users/agoulti/followers","following_url":"https://api.github.com/users/agoulti/following{/other_user}","gists_url":"https://api.github.com/users/agoulti/gists{/gist_id}","starred_url":"https://api.github.com/users/agoulti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agoulti/subscriptions","organizations_url":"https://api.github.com/users/agoulti/orgs","repos_url":"https://api.github.com/users/agoulti/repos","events_url":"https://api.github.com/users/agoulti/events{/privacy}","received_events_url":"https://api.github.com/users/agoulti/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/agoulti/google-storage-plugin","description":"This plugin provides the “Google Cloud Storage Uploader” post-build step for publishing build artifacts to Google Cloud Storage.","fork":true,"url":"https://api.github.com/repos/agoulti/google-storage-plugin","forks_url":"https://api.github.com/repos/agoulti/google-storage-plugin/forks","keys_url":"https://api.github.com/repos/agoulti/google-storage-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/agoulti/google-storage-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/agoulti/google-storage-plugin/teams","hooks_url":"https://api.github.com/repos/agoulti/google-storage-plugin/hooks","issue_events_url":"https://api.github.com/repos/agoulti/google-storage-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/agoulti/google-storage-plugin/events","assignees_url":"https://api.github.com/repos/agoulti/google-storage-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/agoulti/google-storage-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/agoulti/google-storage-plugin/tags","blobs_url":"https://api.github.com/repos/agoulti/google-storage-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/agoulti/google-storage-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/agoulti/google-storage-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/agoulti/google-storage-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/agoulti/google-storage-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/agoulti/google-storage-plugin/languages","stargazers_url":"https://api.github.com/repos/agoulti/google-storage-plugin/stargazers","contributors_url":"https://api.github.com/repos/agoulti/google-storage-plugin/contributors","subscribers_url":"https://api.github.com/repos/agoulti/google-storage-plugin/subscribers","subscription_url":"https://api.github.com/repos/agoulti/google-storage-plugin/subscription","commits_url":"https://api.github.com/repos/agoulti/google-storage-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/agoulti/google-storage-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/agoulti/google-storage-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/agoulti/google-storage-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/agoulti/google-storage-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/agoulti/google-storage-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/agoulti/google-storage-plugin/merges","archive_url":"https://api.github.com/repos/agoulti/google-storage-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/agoulti/google-storage-plugin/downloads","issues_url":"https://api.github.com/repos/agoulti/google-storage-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/agoulti/google-storage-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/agoulti/google-storage-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/agoulti/google-storage-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/agoulti/google-storage-plugin/labels{/name}","releases_url":"https://api.github.com/repos/agoulti/google-storage-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/agoulti/google-storage-plugin/deployments","created_at":"2017-08-28T14:54:43Z","updated_at":"2017-08-28T14:54:44Z","pushed_at":"2017-10-12T21:27:36Z","git_url":"git://github.com/agoulti/google-storage-plugin.git","ssh_url":"git@github.com:agoulti/google-storage-plugin.git","clone_url":"https://github.com/agoulti/google-storage-plugin.git","svn_url":"https://github.com/agoulti/google-storage-plugin","homepage":null,"size":316,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jenkinsci:master","ref":"master","sha":"96e85769d5cd702fe74789beac3c8bb836cde548","user":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars0.githubusercontent.com/u/107424?v=4","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":17877087,"name":"google-storage-plugin","full_name":"jenkinsci/google-storage-plugin","owner":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars0.githubusercontent.com/u/107424?v=4","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jenkinsci/google-storage-plugin","description":"This plugin provides the “Google Cloud Storage Uploader” post-build step for publishing build artifacts to Google Cloud Storage.","fork":false,"url":"https://api.github.com/repos/jenkinsci/google-storage-plugin","forks_url":"https://api.github.com/repos/jenkinsci/google-storage-plugin/forks","keys_url":"https://api.github.com/repos/jenkinsci/google-storage-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/google-storage-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/google-storage-plugin/teams","hooks_url":"https://api.github.com/repos/jenkinsci/google-storage-plugin/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/google-storage-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/google-storage-plugin/events","assignees_url":"https://api.github.com/repos/jenkinsci/google-storage-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/google-storage-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/google-storage-plugin/tags","blobs_url":"https://api.github.com/repos/jenkinsci/google-storage-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/google-storage-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/google-storage-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/google-storage-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/google-storage-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/google-storage-plugin/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/google-storage-plugin/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/google-storage-plugin/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/google-storage-plugin/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/google-storage-plugin/subscription","commits_url":"https://api.github.com/repos/jenkinsci/google-storage-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/google-storage-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/google-storage-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/google-storage-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenkinsci/google-storage-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/google-storage-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/google-storage-plugin/merges","archive_url":"https://api.github.com/repos/jenkinsci/google-storage-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/google-storage-plugin/downloads","issues_url":"https://api.github.com/repos/jenkinsci/google-storage-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/google-storage-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/google-storage-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/google-storage-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/google-storage-plugin/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/google-storage-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/jenkinsci/google-storage-plugin/deployments","created_at":"2014-03-18T18:26:15Z","updated_at":"2017-09-15T22:19:25Z","pushed_at":"2017-10-12T20:44:23Z","git_url":"git://github.com/jenkinsci/google-storage-plugin.git","ssh_url":"git@github.com:jenkinsci/google-storage-plugin.git","clone_url":"https://github.com/jenkinsci/google-storage-plugin.git","svn_url":"https://github.com/jenkinsci/google-storage-plugin","homepage":null,"size":181,"stargazers_count":8,"watchers_count":8,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":6,"forks":16,"open_issues":6,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/google-storage-plugin/pulls/30"},"html":{"href":"https://github.com/jenkinsci/google-storage-plugin/pull/30"},"issue":{"href":"https://api.github.com/repos/jenkinsci/google-storage-plugin/issues/30"},"comments":{"href":"https://api.github.com/repos/jenkinsci/google-storage-plugin/issues/30/comments"},"review_comments":{"href":"https://api.github.com/repos/jenkinsci/google-storage-plugin/pulls/30/comments"},"review_comment":{"href":"https://api.github.com/repos/jenkinsci/google-storage-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jenkinsci/google-storage-plugin/pulls/30/commits"},"statuses":{"href":"https://api.github.com/repos/jenkinsci/google-storage-plugin/statuses/6a762096a0b53de5be1b6ce56321060ef99f78df"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"bwkimmel"}}