{"action":"created","comment":{"url":"https://api.github.com/repos/varvet/varvet/pulls/comments/113161326","pull_request_review_id":34526350,"id":113161326,"diff_hunk":"@@ -1,17 +1,362 @@\n+# See https://github.com/bbatsov/rubocop/blob/master/config/default.yml\n Rails:\n   Enabled: true\n \n Documentation:\n   Enabled: false\n \n-Metrics/LineLength:\n-  Max: 120\n-\n Metrics/ClassLength:\n   Max: 300\n \n+Metrics/ModuleLength:\n+  Max: 300\n+\n Metrics/MethodLength:\n   Max: 25\n \n Style/StringLiterals:\n   EnforcedStyle: double_quotes\n+\n+Style/AccessModifierIndentation:\n+  EnforcedStyle: indent\n+\n+Style/Alias:\n+  EnforcedStyle: prefer_alias_method\n+\n+Style/AlignHash:\n+  EnforcedHashRocketStyle: key\n+  EnforcedColonStyle: key\n+  EnforcedLastArgumentHashStyle: always_inspect\n+\n+Style/AlignParameters:\n+  EnforcedStyle: with_fixed_indentation\n+\n+Style/AndOr:\n+  EnforcedStyle: conditionals\n+\n+Style/BlockDelimiters:\n+  EnforcedStyle: line_count_based\n+\n+Style/BracesAroundHashParameters:\n+  EnforcedStyle: no_braces\n+\n+Style/CaseIndentation:\n+  EnforcedStyle: end\n+\n+Style/ClassAndModuleChildren:\n+  EnforcedStyle: nested\n+\n+Style/ClassCheck:\n+  EnforcedStyle: is_a?\n+\n+Style/CollectionMethods:\n+  PreferredMethods:\n+    collect: \"map\"\n+    collect!: \"map!\"\n+    inject: \"reduce\"\n+    detect: \"find\"\n+    find_all: \"select\"\n+\n+Style/CommandLiteral:\n+  EnforcedStyle: percent_x\n+  AllowInnerBackticks: false\n+\n+Style/CommentAnnotation:\n+  Keywords:\n+    - TODO\n+    - FIXME\n+    - OPTIMIZE\n+    - HACK\n+    - REVIEW\n+\n+Style/DotPosition:\n+  EnforcedStyle: leading\n+\n+Style/EmptyElse:\n+  EnforcedStyle: both\n+\n+Style/EmptyLinesAroundBlockBody:\n+  EnforcedStyle: no_empty_lines\n+\n+Style/EmptyLinesAroundClassBody:\n+  EnforcedStyle: no_empty_lines\n+\n+Style/EmptyLinesAroundModuleBody:\n+  EnforcedStyle: no_empty_lines\n+\n+Style/EmptyMethod:\n+  EnforcedStyle: expanded\n+\n+Style/Encoding:\n+  EnforcedStyle: never\n+\n+Style/ExtraSpacing:\n+  AllowForAlignment: true\n+\n+Style/For:\n+  EnforcedStyle: each\n+\n+Style/FormatString:\n+  EnforcedStyle: format\n+\n+Style/GlobalVars:\n+  AllowedVariables:\n+    - autogen_filepath\n+    - autogen_buffer\n+\n+Style/HashSyntax:\n+  EnforcedStyle: ruby19_no_mixed_keys\n+\n+Style/IndentationConsistency:\n+  EnforcedStyle: normal\n+\n+Style/IndentationWidth:\n+  Width: 2\n+\n+Style/Lambda:\n+  EnforcedStyle: line_count_dependent\n+\n+Style/SpaceInLambdaLiteral:\n+  EnforcedStyle: require_space\n+\n+Style/LambdaCall:\n+  EnforcedStyle: braces\n+\n+Style/MethodDefParentheses:\n+  EnforcedStyle: require_parentheses\n+\n+Style/MethodName:\n+  EnforcedStyle: snake_case\n+\n+Style/ModuleFunction:\n+  EnforcedStyle: module_function\n+\n+Style/MultilineArrayBraceLayout:\n+  EnforcedStyle: new_line\n+\n+Style/MultilineHashBraceLayout:\n+  EnforcedStyle: new_line\n+\n+Style/MultilineMethodCallBraceLayout:\n+  EnforcedStyle: symmetrical\n+\n+Style/MultilineMethodDefinitionBraceLayout:\n+  EnforcedStyle: new_line\n+\n+Style/NonNilCheck:\n+  IncludeSemanticChanges: true\n+\n+Style/ParenthesesAroundCondition:\n+  AllowSafeAssignment: true\n+\n+Style/PercentLiteralDelimiters:\n+  PreferredDelimiters:\n+    default: ()\n+    \"%i\": \"[]\"\n+    \"%I\": \"[]\"\n+    \"%r\": \"{}\"\n+    \"%w\": \"[]\"\n+    \"%W\": \"[]\"\n+    \"%Q\": \"{}\"\n+\n+Style/PercentQLiterals:\n+  EnforcedStyle: upper_case_q\n+\n+Style/RaiseArgs:\n+  EnforcedStyle: exploded\n+\n+Style/RedundantReturn:\n+  AllowMultipleReturnValues: false\n+\n+Style/RegexpLiteral:\n+  EnforcedStyle: slashes\n+  AllowInnerSlashes: false\n+\n+Style/Semicolon:\n+  AllowAsExpressionSeparator: false\n+\n+Style/SingleLineBlockParams:\n+  Methods:\n+    - reduce:\n+        - acc\n+        - elem\n+    - inject:\n+        - acc\n+        - elem\n+\n+Style/FrozenStringLiteralComment:\n+  EnforcedStyle: never # We're not ready for this yet, se https://wyeworks.com/blog/2015/12/1/immutable-strings-in-ruby-2-dot-3\n+\n+Style/SingleLineMethods:\n+  AllowIfMethodIsEmpty: false\n+\n+Style/SpaceAroundBlockParameters:\n+  EnforcedStyleInsidePipes: no_space\n+\n+Style/SpaceAroundEqualsInParameterDefault:\n+  EnforcedStyle: space\n+\n+Style/SpaceBeforeBlockBraces:\n+  EnforcedStyle: space\n+\n+Style/SpaceInsideBlockBraces:\n+  EnforcedStyle: space\n+\n+Style/SpaceInsideHashLiteralBraces:\n+  EnforcedStyle: space\n+  EnforcedStyleForEmptyBraces: no_space\n+\n+Style/SpaceInsideStringInterpolation:\n+  EnforcedStyle: no_space\n+\n+Style/SpecialGlobalVars:\n+  EnforcedStyle: use_english_names\n+\n+Style/StabbyLambdaParentheses:\n+  EnforcedStyle: require_parentheses\n+\n+Style/StringLiterals:\n+  EnforcedStyle: double_quotes\n+\n+Style/StringLiteralsInInterpolation:\n+  EnforcedStyle: double_quotes\n+\n+Style/StringMethods:\n+  PreferredMethods:\n+    intern: to_sym\n+\n+Style/BarePercentLiterals:\n+  EnforcedStyle: percent_q\n+\n+Style/SymbolArray:\n+  EnforcedStyle: percent\n+\n+Style/TernaryParentheses:\n+  EnforcedStyle: require_no_parentheses\n+\n+Style/TrailingBlankLines:\n+  EnforcedStyle: final_newline\n+\n+Style/TrailingCommaInArguments:\n+  EnforcedStyleForMultiline: no_comma","path":"files/.rubocop.yml","position":244,"original_position":244,"commit_id":"5bf37c7962d04dd8c1eba061c06cccb4f7f1592c","original_commit_id":"5bf37c7962d04dd8c1eba061c06cccb4f7f1592c","user":{"login":"Linuus","id":379823,"avatar_url":"https://avatars1.githubusercontent.com/u/379823?v=3","gravatar_id":"","url":"https://api.github.com/users/Linuus","html_url":"https://github.com/Linuus","followers_url":"https://api.github.com/users/Linuus/followers","following_url":"https://api.github.com/users/Linuus/following{/other_user}","gists_url":"https://api.github.com/users/Linuus/gists{/gist_id}","starred_url":"https://api.github.com/users/Linuus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Linuus/subscriptions","organizations_url":"https://api.github.com/users/Linuus/orgs","repos_url":"https://api.github.com/users/Linuus/repos","events_url":"https://api.github.com/users/Linuus/events{/privacy}","received_events_url":"https://api.github.com/users/Linuus/received_events","type":"User","site_admin":false},"body":"I do think trailing commas are ugly and it looks broken :) I do not see either the diff-stat or it being a convention in other languages as good reasons though.\r\n\r\nI guess I'll get over it in time so if someone feels strongly about having trailing commas, sure. There are some benefits to it and my only argument is that it's ugly so :D","created_at":"2017-04-25T10:40:39Z","updated_at":"2017-04-25T10:40:39Z","html_url":"https://github.com/varvet/varvet/pull/13#discussion_r113161326","pull_request_url":"https://api.github.com/repos/varvet/varvet/pulls/13","_links":{"self":{"href":"https://api.github.com/repos/varvet/varvet/pulls/comments/113161326"},"html":{"href":"https://github.com/varvet/varvet/pull/13#discussion_r113161326"},"pull_request":{"href":"https://api.github.com/repos/varvet/varvet/pulls/13"}}},"pull_request":{"url":"https://api.github.com/repos/varvet/varvet/pulls/13","id":117209207,"html_url":"https://github.com/varvet/varvet/pull/13","diff_url":"https://github.com/varvet/varvet/pull/13.diff","patch_url":"https://github.com/varvet/varvet/pull/13.patch","issue_url":"https://api.github.com/repos/varvet/varvet/issues/13","number":13,"state":"open","locked":false,"title":"Update rubocop rulez 👮 ","user":{"login":"juliaramstedt","id":2337941,"avatar_url":"https://avatars3.githubusercontent.com/u/2337941?v=3","gravatar_id":"","url":"https://api.github.com/users/juliaramstedt","html_url":"https://github.com/juliaramstedt","followers_url":"https://api.github.com/users/juliaramstedt/followers","following_url":"https://api.github.com/users/juliaramstedt/following{/other_user}","gists_url":"https://api.github.com/users/juliaramstedt/gists{/gist_id}","starred_url":"https://api.github.com/users/juliaramstedt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juliaramstedt/subscriptions","organizations_url":"https://api.github.com/users/juliaramstedt/orgs","repos_url":"https://api.github.com/users/juliaramstedt/repos","events_url":"https://api.github.com/users/juliaramstedt/events{/privacy}","received_events_url":"https://api.github.com/users/juliaramstedt/received_events","type":"User","site_admin":false},"body":"In lack of an optimal place to put this file, it's here for the time being.\r\n\r\nThought maybe we could discuss what rules we want to use across all of our rails projects.\r\n\r\nGo nuts!","created_at":"2017-04-24T08:12:04Z","updated_at":"2017-04-25T10:40:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"26987d67e74acf26c2f986cf9e27128ec5fa85f5","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/varvet/varvet/pulls/13/commits","review_comments_url":"https://api.github.com/repos/varvet/varvet/pulls/13/comments","review_comment_url":"https://api.github.com/repos/varvet/varvet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/varvet/varvet/issues/13/comments","statuses_url":"https://api.github.com/repos/varvet/varvet/statuses/5bf37c7962d04dd8c1eba061c06cccb4f7f1592c","head":{"label":"varvet:update-rubocop-rulez","ref":"update-rubocop-rulez","sha":"5bf37c7962d04dd8c1eba061c06cccb4f7f1592c","user":{"login":"varvet","id":3612746,"avatar_url":"https://avatars0.githubusercontent.com/u/3612746?v=3","gravatar_id":"","url":"https://api.github.com/users/varvet","html_url":"https://github.com/varvet","followers_url":"https://api.github.com/users/varvet/followers","following_url":"https://api.github.com/users/varvet/following{/other_user}","gists_url":"https://api.github.com/users/varvet/gists{/gist_id}","starred_url":"https://api.github.com/users/varvet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/varvet/subscriptions","organizations_url":"https://api.github.com/users/varvet/orgs","repos_url":"https://api.github.com/users/varvet/repos","events_url":"https://api.github.com/users/varvet/events{/privacy}","received_events_url":"https://api.github.com/users/varvet/received_events","type":"Organization","site_admin":false},"repo":{"id":26529087,"name":"varvet","full_name":"varvet/varvet","owner":{"login":"varvet","id":3612746,"avatar_url":"https://avatars0.githubusercontent.com/u/3612746?v=3","gravatar_id":"","url":"https://api.github.com/users/varvet","html_url":"https://github.com/varvet","followers_url":"https://api.github.com/users/varvet/followers","following_url":"https://api.github.com/users/varvet/following{/other_user}","gists_url":"https://api.github.com/users/varvet/gists{/gist_id}","starred_url":"https://api.github.com/users/varvet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/varvet/subscriptions","organizations_url":"https://api.github.com/users/varvet/orgs","repos_url":"https://api.github.com/users/varvet/repos","events_url":"https://api.github.com/users/varvet/events{/privacy}","received_events_url":"https://api.github.com/users/varvet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/varvet/varvet","description":null,"fork":false,"url":"https://api.github.com/repos/varvet/varvet","forks_url":"https://api.github.com/repos/varvet/varvet/forks","keys_url":"https://api.github.com/repos/varvet/varvet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/varvet/varvet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/varvet/varvet/teams","hooks_url":"https://api.github.com/repos/varvet/varvet/hooks","issue_events_url":"https://api.github.com/repos/varvet/varvet/issues/events{/number}","events_url":"https://api.github.com/repos/varvet/varvet/events","assignees_url":"https://api.github.com/repos/varvet/varvet/assignees{/user}","branches_url":"https://api.github.com/repos/varvet/varvet/branches{/branch}","tags_url":"https://api.github.com/repos/varvet/varvet/tags","blobs_url":"https://api.github.com/repos/varvet/varvet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/varvet/varvet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/varvet/varvet/git/refs{/sha}","trees_url":"https://api.github.com/repos/varvet/varvet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/varvet/varvet/statuses/{sha}","languages_url":"https://api.github.com/repos/varvet/varvet/languages","stargazers_url":"https://api.github.com/repos/varvet/varvet/stargazers","contributors_url":"https://api.github.com/repos/varvet/varvet/contributors","subscribers_url":"https://api.github.com/repos/varvet/varvet/subscribers","subscription_url":"https://api.github.com/repos/varvet/varvet/subscription","commits_url":"https://api.github.com/repos/varvet/varvet/commits{/sha}","git_commits_url":"https://api.github.com/repos/varvet/varvet/git/commits{/sha}","comments_url":"https://api.github.com/repos/varvet/varvet/comments{/number}","issue_comment_url":"https://api.github.com/repos/varvet/varvet/issues/comments{/number}","contents_url":"https://api.github.com/repos/varvet/varvet/contents/{+path}","compare_url":"https://api.github.com/repos/varvet/varvet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/varvet/varvet/merges","archive_url":"https://api.github.com/repos/varvet/varvet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/varvet/varvet/downloads","issues_url":"https://api.github.com/repos/varvet/varvet/issues{/number}","pulls_url":"https://api.github.com/repos/varvet/varvet/pulls{/number}","milestones_url":"https://api.github.com/repos/varvet/varvet/milestones{/number}","notifications_url":"https://api.github.com/repos/varvet/varvet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/varvet/varvet/labels{/name}","releases_url":"https://api.github.com/repos/varvet/varvet/releases{/id}","deployments_url":"https://api.github.com/repos/varvet/varvet/deployments","created_at":"2014-11-12T09:43:45Z","updated_at":"2016-11-30T09:29:09Z","pushed_at":"2017-04-24T08:12:04Z","git_url":"git://github.com/varvet/varvet.git","ssh_url":"git@github.com:varvet/varvet.git","clone_url":"https://github.com/varvet/varvet.git","svn_url":"https://github.com/varvet/varvet","homepage":null,"size":45,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":1,"default_branch":"master"}},"base":{"label":"varvet:master","ref":"master","sha":"55b579243a92800216a3a7e525549e757e68f2b5","user":{"login":"varvet","id":3612746,"avatar_url":"https://avatars0.githubusercontent.com/u/3612746?v=3","gravatar_id":"","url":"https://api.github.com/users/varvet","html_url":"https://github.com/varvet","followers_url":"https://api.github.com/users/varvet/followers","following_url":"https://api.github.com/users/varvet/following{/other_user}","gists_url":"https://api.github.com/users/varvet/gists{/gist_id}","starred_url":"https://api.github.com/users/varvet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/varvet/subscriptions","organizations_url":"https://api.github.com/users/varvet/orgs","repos_url":"https://api.github.com/users/varvet/repos","events_url":"https://api.github.com/users/varvet/events{/privacy}","received_events_url":"https://api.github.com/users/varvet/received_events","type":"Organization","site_admin":false},"repo":{"id":26529087,"name":"varvet","full_name":"varvet/varvet","owner":{"login":"varvet","id":3612746,"avatar_url":"https://avatars0.githubusercontent.com/u/3612746?v=3","gravatar_id":"","url":"https://api.github.com/users/varvet","html_url":"https://github.com/varvet","followers_url":"https://api.github.com/users/varvet/followers","following_url":"https://api.github.com/users/varvet/following{/other_user}","gists_url":"https://api.github.com/users/varvet/gists{/gist_id}","starred_url":"https://api.github.com/users/varvet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/varvet/subscriptions","organizations_url":"https://api.github.com/users/varvet/orgs","repos_url":"https://api.github.com/users/varvet/repos","events_url":"https://api.github.com/users/varvet/events{/privacy}","received_events_url":"https://api.github.com/users/varvet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/varvet/varvet","description":null,"fork":false,"url":"https://api.github.com/repos/varvet/varvet","forks_url":"https://api.github.com/repos/varvet/varvet/forks","keys_url":"https://api.github.com/repos/varvet/varvet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/varvet/varvet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/varvet/varvet/teams","hooks_url":"https://api.github.com/repos/varvet/varvet/hooks","issue_events_url":"https://api.github.com/repos/varvet/varvet/issues/events{/number}","events_url":"https://api.github.com/repos/varvet/varvet/events","assignees_url":"https://api.github.com/repos/varvet/varvet/assignees{/user}","branches_url":"https://api.github.com/repos/varvet/varvet/branches{/branch}","tags_url":"https://api.github.com/repos/varvet/varvet/tags","blobs_url":"https://api.github.com/repos/varvet/varvet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/varvet/varvet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/varvet/varvet/git/refs{/sha}","trees_url":"https://api.github.com/repos/varvet/varvet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/varvet/varvet/statuses/{sha}","languages_url":"https://api.github.com/repos/varvet/varvet/languages","stargazers_url":"https://api.github.com/repos/varvet/varvet/stargazers","contributors_url":"https://api.github.com/repos/varvet/varvet/contributors","subscribers_url":"https://api.github.com/repos/varvet/varvet/subscribers","subscription_url":"https://api.github.com/repos/varvet/varvet/subscription","commits_url":"https://api.github.com/repos/varvet/varvet/commits{/sha}","git_commits_url":"https://api.github.com/repos/varvet/varvet/git/commits{/sha}","comments_url":"https://api.github.com/repos/varvet/varvet/comments{/number}","issue_comment_url":"https://api.github.com/repos/varvet/varvet/issues/comments{/number}","contents_url":"https://api.github.com/repos/varvet/varvet/contents/{+path}","compare_url":"https://api.github.com/repos/varvet/varvet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/varvet/varvet/merges","archive_url":"https://api.github.com/repos/varvet/varvet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/varvet/varvet/downloads","issues_url":"https://api.github.com/repos/varvet/varvet/issues{/number}","pulls_url":"https://api.github.com/repos/varvet/varvet/pulls{/number}","milestones_url":"https://api.github.com/repos/varvet/varvet/milestones{/number}","notifications_url":"https://api.github.com/repos/varvet/varvet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/varvet/varvet/labels{/name}","releases_url":"https://api.github.com/repos/varvet/varvet/releases{/id}","deployments_url":"https://api.github.com/repos/varvet/varvet/deployments","created_at":"2014-11-12T09:43:45Z","updated_at":"2016-11-30T09:29:09Z","pushed_at":"2017-04-24T08:12:04Z","git_url":"git://github.com/varvet/varvet.git","ssh_url":"git@github.com:varvet/varvet.git","clone_url":"https://github.com/varvet/varvet.git","svn_url":"https://github.com/varvet/varvet","homepage":null,"size":45,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/varvet/varvet/pulls/13"},"html":{"href":"https://github.com/varvet/varvet/pull/13"},"issue":{"href":"https://api.github.com/repos/varvet/varvet/issues/13"},"comments":{"href":"https://api.github.com/repos/varvet/varvet/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/varvet/varvet/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/varvet/varvet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/varvet/varvet/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/varvet/varvet/statuses/5bf37c7962d04dd8c1eba061c06cccb4f7f1592c"}}}}
{"actor":{"display_login":"Linuus"}}