{"action":"created","comment":{"url":"https://api.github.com/repos/alphagov/pay-connector/pulls/comments/142133623","pull_request_review_id":66449861,"id":142133623,"diff_hunk":"@@ -176,6 +176,11 @@\n             <artifactId>commons-collections</artifactId>\n             <version>3.2.2</version>\n         </dependency>\n+        <dependency>\n+            <groupId>org.jooq</groupId>","path":"pom.xml","position":5,"original_position":5,"commit_id":"c7eb98cdf1a1915d3bb2e7a0c67a2b69a0d4ff9d","original_commit_id":"c7eb98cdf1a1915d3bb2e7a0c67a2b69a0d4ff9d","user":{"login":"kakumara","id":6473228,"avatar_url":"https://avatars3.githubusercontent.com/u/6473228?v=4","gravatar_id":"","url":"https://api.github.com/users/kakumara","html_url":"https://github.com/kakumara","followers_url":"https://api.github.com/users/kakumara/followers","following_url":"https://api.github.com/users/kakumara/following{/other_user}","gists_url":"https://api.github.com/users/kakumara/gists{/gist_id}","starred_url":"https://api.github.com/users/kakumara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kakumara/subscriptions","organizations_url":"https://api.github.com/users/kakumara/orgs","repos_url":"https://api.github.com/users/kakumara/repos","events_url":"https://api.github.com/users/kakumara/events{/privacy}","received_events_url":"https://api.github.com/users/kakumara/received_events","type":"User","site_admin":false},"body":"I don't really see the benefits of using this. SQL is perfectly readable/manageble to me. 😐 ","created_at":"2017-10-02T13:09:41Z","updated_at":"2017-10-02T13:23:17Z","html_url":"https://github.com/alphagov/pay-connector/pull/462#discussion_r142133623","pull_request_url":"https://api.github.com/repos/alphagov/pay-connector/pulls/462","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/alphagov/pay-connector/pulls/comments/142133623"},"html":{"href":"https://github.com/alphagov/pay-connector/pull/462#discussion_r142133623"},"pull_request":{"href":"https://api.github.com/repos/alphagov/pay-connector/pulls/462"}}},"pull_request":{"url":"https://api.github.com/repos/alphagov/pay-connector/pulls/462","id":144147992,"html_url":"https://github.com/alphagov/pay-connector/pull/462","diff_url":"https://github.com/alphagov/pay-connector/pull/462.diff","patch_url":"https://github.com/alphagov/pay-connector/pull/462.patch","issue_url":"https://api.github.com/repos/alphagov/pay-connector/issues/462","number":462,"state":"open","locked":false,"title":"PP-2696 Reinstate get transactions with refunds","user":{"login":"rauligs","id":17246560,"avatar_url":"https://avatars0.githubusercontent.com/u/17246560?v=4","gravatar_id":"","url":"https://api.github.com/users/rauligs","html_url":"https://github.com/rauligs","followers_url":"https://api.github.com/users/rauligs/followers","following_url":"https://api.github.com/users/rauligs/following{/other_user}","gists_url":"https://api.github.com/users/rauligs/gists{/gist_id}","starred_url":"https://api.github.com/users/rauligs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rauligs/subscriptions","organizations_url":"https://api.github.com/users/rauligs/orgs","repos_url":"https://api.github.com/users/rauligs/repos","events_url":"https://api.github.com/users/rauligs/events{/privacy}","received_events_url":"https://api.github.com/users/rauligs/received_events","type":"User","site_admin":false},"body":"## WHAT\r\n- Reinstate get transactions with refunds adding the fix to prevent https://github.com/google/guice/issues/730 by annotating `TransactionDao` with _@Transactional_ annotation.\r\n\r\n- Reinstate story: https://payments-platform.atlassian.net/browse/PP-2515 \r\n\r\n- Original PR: https://github.com/alphagov/pay-connector/pull/439\r\n\r\n    - Introduced mechanism to switch between fetching transactions:\r\n        - `TransactionSearchStrategy` fetches both charges and refunds\r\n        - `ChargeSearchStrategy` fetches charges only, using the original implementation\r\n        - The strategy is selected according to the `REFUNDS_IN_TX_LIST` feature flag.\r\n\r\n        - The strategy and switching via feature flag are temporary. We intend to replace the `TransactionSearchStrategy` implementation after refactoring the data model to store charges and refunds in the same database table.\r\n\r\n    - The implementation of `TransactionDao` is meant to be used a as drop-in replacement for `ChargeDao` when we want to take refunds into consideration while searching.\r\n\r\n    - A transaction can be of two types `charge` or `refund`. Depending on whether we want to search for only charges or refunds, an optional payment type can be specified in the filtering criteria. The absence of a payment type in the search criteria implies all types are considered during the search.\r\n\r\n    - The filtering criteria has been augmented to allow searching by refund status or charge status or any combination of both.\r\n\r\n\r\n","created_at":"2017-10-02T10:00:44Z","updated_at":"2017-10-02T13:23:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cb15257f3fe5347e023e59f6704a2caa4cfc93e0","assignee":{"login":"kakumara","id":6473228,"avatar_url":"https://avatars3.githubusercontent.com/u/6473228?v=4","gravatar_id":"","url":"https://api.github.com/users/kakumara","html_url":"https://github.com/kakumara","followers_url":"https://api.github.com/users/kakumara/followers","following_url":"https://api.github.com/users/kakumara/following{/other_user}","gists_url":"https://api.github.com/users/kakumara/gists{/gist_id}","starred_url":"https://api.github.com/users/kakumara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kakumara/subscriptions","organizations_url":"https://api.github.com/users/kakumara/orgs","repos_url":"https://api.github.com/users/kakumara/repos","events_url":"https://api.github.com/users/kakumara/events{/privacy}","received_events_url":"https://api.github.com/users/kakumara/received_events","type":"User","site_admin":false},"assignees":[{"login":"kakumara","id":6473228,"avatar_url":"https://avatars3.githubusercontent.com/u/6473228?v=4","gravatar_id":"","url":"https://api.github.com/users/kakumara","html_url":"https://github.com/kakumara","followers_url":"https://api.github.com/users/kakumara/followers","following_url":"https://api.github.com/users/kakumara/following{/other_user}","gists_url":"https://api.github.com/users/kakumara/gists{/gist_id}","starred_url":"https://api.github.com/users/kakumara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kakumara/subscriptions","organizations_url":"https://api.github.com/users/kakumara/orgs","repos_url":"https://api.github.com/users/kakumara/repos","events_url":"https://api.github.com/users/kakumara/events{/privacy}","received_events_url":"https://api.github.com/users/kakumara/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/pay-connector/pulls/462/commits","review_comments_url":"https://api.github.com/repos/alphagov/pay-connector/pulls/462/comments","review_comment_url":"https://api.github.com/repos/alphagov/pay-connector/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alphagov/pay-connector/issues/462/comments","statuses_url":"https://api.github.com/repos/alphagov/pay-connector/statuses/c7eb98cdf1a1915d3bb2e7a0c67a2b69a0d4ff9d","head":{"label":"alphagov:PP-2696-Reinstate-Get-Transactions-With-Refunds","ref":"PP-2696-Reinstate-Get-Transactions-With-Refunds","sha":"c7eb98cdf1a1915d3bb2e7a0c67a2b69a0d4ff9d","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":39890257,"name":"pay-connector","full_name":"alphagov/pay-connector","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/pay-connector","description":"The Payments Connector in Java (Dropwizard)","fork":false,"url":"https://api.github.com/repos/alphagov/pay-connector","forks_url":"https://api.github.com/repos/alphagov/pay-connector/forks","keys_url":"https://api.github.com/repos/alphagov/pay-connector/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/pay-connector/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/pay-connector/teams","hooks_url":"https://api.github.com/repos/alphagov/pay-connector/hooks","issue_events_url":"https://api.github.com/repos/alphagov/pay-connector/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/pay-connector/events","assignees_url":"https://api.github.com/repos/alphagov/pay-connector/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/pay-connector/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/pay-connector/tags","blobs_url":"https://api.github.com/repos/alphagov/pay-connector/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/pay-connector/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/pay-connector/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/pay-connector/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/pay-connector/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/pay-connector/languages","stargazers_url":"https://api.github.com/repos/alphagov/pay-connector/stargazers","contributors_url":"https://api.github.com/repos/alphagov/pay-connector/contributors","subscribers_url":"https://api.github.com/repos/alphagov/pay-connector/subscribers","subscription_url":"https://api.github.com/repos/alphagov/pay-connector/subscription","commits_url":"https://api.github.com/repos/alphagov/pay-connector/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/pay-connector/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/pay-connector/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/pay-connector/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/pay-connector/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/pay-connector/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/pay-connector/merges","archive_url":"https://api.github.com/repos/alphagov/pay-connector/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/pay-connector/downloads","issues_url":"https://api.github.com/repos/alphagov/pay-connector/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/pay-connector/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/pay-connector/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/pay-connector/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/pay-connector/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/pay-connector/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/pay-connector/deployments","created_at":"2015-07-29T11:38:35Z","updated_at":"2017-07-11T18:01:09Z","pushed_at":"2017-10-02T10:28:45Z","git_url":"git://github.com/alphagov/pay-connector.git","ssh_url":"git@github.com:alphagov/pay-connector.git","clone_url":"https://github.com/alphagov/pay-connector.git","svn_url":"https://github.com/alphagov/pay-connector","homepage":null,"size":14236,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"a24aef552693df5b2b3fcb20b3d561db59dec904","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":39890257,"name":"pay-connector","full_name":"alphagov/pay-connector","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/pay-connector","description":"The Payments Connector in Java (Dropwizard)","fork":false,"url":"https://api.github.com/repos/alphagov/pay-connector","forks_url":"https://api.github.com/repos/alphagov/pay-connector/forks","keys_url":"https://api.github.com/repos/alphagov/pay-connector/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/pay-connector/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/pay-connector/teams","hooks_url":"https://api.github.com/repos/alphagov/pay-connector/hooks","issue_events_url":"https://api.github.com/repos/alphagov/pay-connector/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/pay-connector/events","assignees_url":"https://api.github.com/repos/alphagov/pay-connector/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/pay-connector/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/pay-connector/tags","blobs_url":"https://api.github.com/repos/alphagov/pay-connector/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/pay-connector/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/pay-connector/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/pay-connector/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/pay-connector/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/pay-connector/languages","stargazers_url":"https://api.github.com/repos/alphagov/pay-connector/stargazers","contributors_url":"https://api.github.com/repos/alphagov/pay-connector/contributors","subscribers_url":"https://api.github.com/repos/alphagov/pay-connector/subscribers","subscription_url":"https://api.github.com/repos/alphagov/pay-connector/subscription","commits_url":"https://api.github.com/repos/alphagov/pay-connector/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/pay-connector/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/pay-connector/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/pay-connector/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/pay-connector/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/pay-connector/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/pay-connector/merges","archive_url":"https://api.github.com/repos/alphagov/pay-connector/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/pay-connector/downloads","issues_url":"https://api.github.com/repos/alphagov/pay-connector/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/pay-connector/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/pay-connector/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/pay-connector/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/pay-connector/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/pay-connector/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/pay-connector/deployments","created_at":"2015-07-29T11:38:35Z","updated_at":"2017-07-11T18:01:09Z","pushed_at":"2017-10-02T10:28:45Z","git_url":"git://github.com/alphagov/pay-connector.git","ssh_url":"git@github.com:alphagov/pay-connector.git","clone_url":"https://github.com/alphagov/pay-connector.git","svn_url":"https://github.com/alphagov/pay-connector","homepage":null,"size":14236,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/pay-connector/pulls/462"},"html":{"href":"https://github.com/alphagov/pay-connector/pull/462"},"issue":{"href":"https://api.github.com/repos/alphagov/pay-connector/issues/462"},"comments":{"href":"https://api.github.com/repos/alphagov/pay-connector/issues/462/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/pay-connector/pulls/462/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/pay-connector/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alphagov/pay-connector/pulls/462/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/pay-connector/statuses/c7eb98cdf1a1915d3bb2e7a0c67a2b69a0d4ff9d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kakumara"}}