{"action":"created","issue":{"url":"https://api.github.com/repos/spring-projects/spring-boot/issues/11120","repository_url":"https://api.github.com/repos/spring-projects/spring-boot","labels_url":"https://api.github.com/repos/spring-projects/spring-boot/issues/11120/labels{/name}","comments_url":"https://api.github.com/repos/spring-projects/spring-boot/issues/11120/comments","events_url":"https://api.github.com/repos/spring-projects/spring-boot/issues/11120/events","html_url":"https://github.com/spring-projects/spring-boot/pull/11120","id":276256877,"number":11120,"title":"Neo4jHealthIndicator allows customizable cypher validation statement","user":{"login":"espiegelberg","id":2649592,"avatar_url":"https://avatars1.githubusercontent.com/u/2649592?v=4","gravatar_id":"","url":"https://api.github.com/users/espiegelberg","html_url":"https://github.com/espiegelberg","followers_url":"https://api.github.com/users/espiegelberg/followers","following_url":"https://api.github.com/users/espiegelberg/following{/other_user}","gists_url":"https://api.github.com/users/espiegelberg/gists{/gist_id}","starred_url":"https://api.github.com/users/espiegelberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/espiegelberg/subscriptions","organizations_url":"https://api.github.com/users/espiegelberg/orgs","repos_url":"https://api.github.com/users/espiegelberg/repos","events_url":"https://api.github.com/users/espiegelberg/events{/privacy}","received_events_url":"https://api.github.com/users/espiegelberg/received_events","type":"User","site_admin":false},"labels":[{"id":97741072,"url":"https://api.github.com/repos/spring-projects/spring-boot/labels/status:%20waiting-for-feedback","name":"status: waiting-for-feedback","color":"fef2c0","default":false},{"id":293438798,"url":"https://api.github.com/repos/spring-projects/spring-boot/labels/status:%20waiting-for-triage","name":"status: waiting-for-triage","color":"fef2c0","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-11-23T03:15:55Z","updated_at":"2017-12-10T19:09:36Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/spring-projects/spring-boot/pulls/11120","html_url":"https://github.com/spring-projects/spring-boot/pull/11120","diff_url":"https://github.com/spring-projects/spring-boot/pull/11120.diff","patch_url":"https://github.com/spring-projects/spring-boot/pull/11120.patch"},"body":"<!--\r\nThanks for contributing to Spring Boot. Please provide a brief description of your pull-request and reference any related issue numbers (prefix references with #).\r\n-->\r\nI've gotten some feedback from colleagues that they would like to customize the Cypher validation query within the Neo4jHealthIndicator. I agree that this would be useful. This PR makes such customization possible through configuration. \r\n\r\nNeo4jHealthIndicator.java on line 44 could use a second set of eyes; please let me know how you prefer this to be coded. It previously was static and **final** but is now no longer final, to allow it to be changed. The way it is currently coded may not match your preferred style."},"comment":{"url":"https://api.github.com/repos/spring-projects/spring-boot/issues/comments/350571981","html_url":"https://github.com/spring-projects/spring-boot/pull/11120#issuecomment-350571981","issue_url":"https://api.github.com/repos/spring-projects/spring-boot/issues/11120","id":350571981,"user":{"login":"snicoll","id":490484,"avatar_url":"https://avatars0.githubusercontent.com/u/490484?v=4","gravatar_id":"","url":"https://api.github.com/users/snicoll","html_url":"https://github.com/snicoll","followers_url":"https://api.github.com/users/snicoll/followers","following_url":"https://api.github.com/users/snicoll/following{/other_user}","gists_url":"https://api.github.com/users/snicoll/gists{/gist_id}","starred_url":"https://api.github.com/users/snicoll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snicoll/subscriptions","organizations_url":"https://api.github.com/users/snicoll/orgs","repos_url":"https://api.github.com/users/snicoll/repos","events_url":"https://api.github.com/users/snicoll/events{/privacy}","received_events_url":"https://api.github.com/users/snicoll/received_events","type":"User","site_admin":false},"created_at":"2017-12-10T19:09:36Z","updated_at":"2017-12-10T19:09:36Z","author_association":"MEMBER","body":">  in my view what is put into the details is constrained\r\n\r\nThat's one to look at it. The way I look at it is that we'd offer a configuration option that has a major impact on the output format of the health indicator. We try to avoid that (for instance, that's why we don't have spEL support in `application.properties`).\r\n\r\nTo be honest, I don't get why this is so important so perhaps someone who actually knows neo4j could chime in and share his opinion?\r\n\r\nping @mp911de, @christophstrobl @olivergierke "}}
{"actor":{"display_login":"snicoll"}}