{"action":"created","comment":{"url":"https://api.github.com/repos/skynetsolutions/puppet-winlogbeat/pulls/comments/122272483","pull_request_review_id":44374831,"id":122272483,"diff_hunk":"@@ -12,41 +12,84 @@\n #   },\n # }\n #\n-# @param conf_template [String] The configuration template to use to generate the main winlogbeat.yml config file\n-# @param download_url [String] The URL of the zip file that should be downloaded to install winlogbeat\n-# @param install_dir [String] Where winlogbeat should be installed\n-# @param outputs [Hash] Will be converted to YAML for the required outputs section of the winlogbeat config\n-# @param package_verion [String] The version parameter for the winlogbeat package\n-# @param registry_file [String] The registry file used to store positions, absolute or relative to working directory (default .winlogbeat.yml)\n-# @param service_enable [String] The enable parameter on the winlogbeat service (default: true)\n+# @param package_ensure [String] The version parameter for the winlogbeat package\n # @param service_ensure [String] The ensure parameter on the winlogbeat service (default: running)\n+# @param service_enable [String] The enable parameter on the winlogbeat service (default: true)\n+# @param registry_file [String] The registry file used to store positions, absolute or relative to working directory (default .winlogbeat.yml)\n+# @param outputs [Hash] Will be converted to YAML for the required outputs section of the winlogbeat config\n # @param shipper [Hash] Will be converted to YAML to create the optional shipper section of the winlogbeat config\n # @param logging [Hash] Will be converted to YAML to create the optional logging section of the winlogbeat config\n+# @param conf_template [String] The configuration template to use to generate the main winlogbeat.yml config file\n+# @param download_url [String] The URL of the zip file that should be downloaded to install winlogbeat\n+# @param install_dir [String] Where winlogbeat should be installed\n # @param tmp_dir [String] Where winlogbeat should be temporarily downloaded to so it can be installed\n # @param event_logs [Hash] Event_logs that will be forwarded.\n # @param event_logs_merge [Boolean] Whether $event_logs should merge all hiera sources, or use simple automatic parameter lookup\n \n class winlogbeat (\n-  $conf_template    = $winlogbeat::params::conf_template,\n-  $config_file      = $winlogbeat::params::config_file,\n-  $download_url     = $winlogbeat::params::download_url,\n-  $install_dir      = $winlogbeat::params::install_dir,\n-  $outputs          = $winlogbeat::params::outputs,\n-  $package_ensure   = $winlogbeat::params::package_ensure,\n-  $registry_file    = $winlogbeat::params::registry_file,\n-  $service_enable   = $winlogbeat::params::service_enable,\n-  $service_ensure   = $winlogbeat::params::service_ensure,\n-  $shipper          = $winlogbeat::params::shipper,\n-  $logging          = $winlogbeat::params::logging,\n-  $tmp_dir          = $winlogbeat::params::tmp_dir,\n-  $event_logs       = {},\n-  $event_logs_merge = false,\n+  $major_version        = undef,\n+  $package_ensure       = $winlogbeat::params::package_ensure,\n+  $service_ensure       = $winlogbeat::params::service_ensure,\n+  $service_enable       = $winlogbeat::params::service_enable,\n+  $service_provider     = $winlogbeat::params::service_provider,\n+  $registry_file        = $winlogbeat::params::registry_file,\n+  $config_file          = $winlogbeat::params::config_file,\n+  $outputs              = $winlogbeat::params::outputs,\n+  $shipper              = $winlogbeat::params::shipper,\n+  $logging              = $winlogbeat::params::logging,\n+  $run_options          = $winlogbeat::params::run_options,\n+  $conf_template        = undef,\n+  $download_url         = undef,\n+  $install_dir          = $winlogbeat::params::install_dir,\n+  $tmp_dir              = $winlogbeat::params::tmp_dir,\n+  #### v5 only ####\n+  $use_generic_template = $winlogbeat::params::use_generic_template,\n+  $beat_name            = $winlogbeat::params::beat_name,\n+  $tags                 = $winlogbeat::params::tags,\n+  $queue_size           = $winlogbeat::params::queue_size,\n+  $max_procs            = $winlogbeat::params::max_procs,\n+  $fields               = $winlogbeat::params::fields,\n+  $fields_under_root    = $winlogbeat::params::fields_under_root,\n+  $metrics              = undef,\n+  #### End v5 onlly ####","path":"manifests/init.pp","position":null,"original_position":64,"commit_id":"cfb9f1683d02538e63b39e8288f8bdba12177cd6","original_commit_id":"6f601b4a3d79b9e725bd789f939abdcef77ab93e","user":{"login":"edestecd","id":107281,"avatar_url":"https://avatars3.githubusercontent.com/u/107281?v=3","gravatar_id":"","url":"https://api.github.com/users/edestecd","html_url":"https://github.com/edestecd","followers_url":"https://api.github.com/users/edestecd/followers","following_url":"https://api.github.com/users/edestecd/following{/other_user}","gists_url":"https://api.github.com/users/edestecd/gists{/gist_id}","starred_url":"https://api.github.com/users/edestecd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edestecd/subscriptions","organizations_url":"https://api.github.com/users/edestecd/orgs","repos_url":"https://api.github.com/users/edestecd/repos","events_url":"https://api.github.com/users/edestecd/events{/privacy}","received_events_url":"https://api.github.com/users/edestecd/received_events","type":"User","site_admin":false},"body":"fixed","created_at":"2017-06-15T18:07:58Z","updated_at":"2017-06-15T18:07:58Z","html_url":"https://github.com/skynetsolutions/puppet-winlogbeat/pull/6#discussion_r122272483","pull_request_url":"https://api.github.com/repos/skynetsolutions/puppet-winlogbeat/pulls/6","_links":{"self":{"href":"https://api.github.com/repos/skynetsolutions/puppet-winlogbeat/pulls/comments/122272483"},"html":{"href":"https://github.com/skynetsolutions/puppet-winlogbeat/pull/6#discussion_r122272483"},"pull_request":{"href":"https://api.github.com/repos/skynetsolutions/puppet-winlogbeat/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/skynetsolutions/puppet-winlogbeat/pulls/6","id":125404601,"html_url":"https://github.com/skynetsolutions/puppet-winlogbeat/pull/6","diff_url":"https://github.com/skynetsolutions/puppet-winlogbeat/pull/6.diff","patch_url":"https://github.com/skynetsolutions/puppet-winlogbeat/pull/6.patch","issue_url":"https://api.github.com/repos/skynetsolutions/puppet-winlogbeat/issues/6","number":6,"state":"open","locked":false,"title":"Add all version 5 options and support updating","user":{"login":"edestecd","id":107281,"avatar_url":"https://avatars3.githubusercontent.com/u/107281?v=3","gravatar_id":"","url":"https://api.github.com/users/edestecd","html_url":"https://github.com/edestecd","followers_url":"https://api.github.com/users/edestecd/followers","following_url":"https://api.github.com/users/edestecd/following{/other_user}","gists_url":"https://api.github.com/users/edestecd/gists{/gist_id}","starred_url":"https://api.github.com/users/edestecd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edestecd/subscriptions","organizations_url":"https://api.github.com/users/edestecd/orgs","repos_url":"https://api.github.com/users/edestecd/repos","events_url":"https://api.github.com/users/edestecd/events{/privacy}","received_events_url":"https://api.github.com/users/edestecd/received_events","type":"User","site_admin":false},"body":"See this for the same changes made to filebeat:\r\nhttps://github.com/pcfens/puppet-filebeat/pull/113","created_at":"2017-06-13T16:15:47Z","updated_at":"2017-06-15T18:07:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5af4ddfcbe01545a95eae8f2056506fc985653e1","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/skynetsolutions/puppet-winlogbeat/pulls/6/commits","review_comments_url":"https://api.github.com/repos/skynetsolutions/puppet-winlogbeat/pulls/6/comments","review_comment_url":"https://api.github.com/repos/skynetsolutions/puppet-winlogbeat/pulls/comments{/number}","comments_url":"https://api.github.com/repos/skynetsolutions/puppet-winlogbeat/issues/6/comments","statuses_url":"https://api.github.com/repos/skynetsolutions/puppet-winlogbeat/statuses/cfb9f1683d02538e63b39e8288f8bdba12177cd6","head":{"label":"MiamiOH:master","ref":"master","sha":"cfb9f1683d02538e63b39e8288f8bdba12177cd6","user":{"login":"MiamiOH","id":12460283,"avatar_url":"https://avatars1.githubusercontent.com/u/12460283?v=3","gravatar_id":"","url":"https://api.github.com/users/MiamiOH","html_url":"https://github.com/MiamiOH","followers_url":"https://api.github.com/users/MiamiOH/followers","following_url":"https://api.github.com/users/MiamiOH/following{/other_user}","gists_url":"https://api.github.com/users/MiamiOH/gists{/gist_id}","starred_url":"https://api.github.com/users/MiamiOH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MiamiOH/subscriptions","organizations_url":"https://api.github.com/users/MiamiOH/orgs","repos_url":"https://api.github.com/users/MiamiOH/repos","events_url":"https://api.github.com/users/MiamiOH/events{/privacy}","received_events_url":"https://api.github.com/users/MiamiOH/received_events","type":"Organization","site_admin":false},"repo":{"id":93665223,"name":"puppet-winlogbeat","full_name":"MiamiOH/puppet-winlogbeat","owner":{"login":"MiamiOH","id":12460283,"avatar_url":"https://avatars1.githubusercontent.com/u/12460283?v=3","gravatar_id":"","url":"https://api.github.com/users/MiamiOH","html_url":"https://github.com/MiamiOH","followers_url":"https://api.github.com/users/MiamiOH/followers","following_url":"https://api.github.com/users/MiamiOH/following{/other_user}","gists_url":"https://api.github.com/users/MiamiOH/gists{/gist_id}","starred_url":"https://api.github.com/users/MiamiOH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MiamiOH/subscriptions","organizations_url":"https://api.github.com/users/MiamiOH/orgs","repos_url":"https://api.github.com/users/MiamiOH/repos","events_url":"https://api.github.com/users/MiamiOH/events{/privacy}","received_events_url":"https://api.github.com/users/MiamiOH/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MiamiOH/puppet-winlogbeat","description":"A module to install and manage the winlogbeat log shipper","fork":true,"url":"https://api.github.com/repos/MiamiOH/puppet-winlogbeat","forks_url":"https://api.github.com/repos/MiamiOH/puppet-winlogbeat/forks","keys_url":"https://api.github.com/repos/MiamiOH/puppet-winlogbeat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MiamiOH/puppet-winlogbeat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MiamiOH/puppet-winlogbeat/teams","hooks_url":"https://api.github.com/repos/MiamiOH/puppet-winlogbeat/hooks","issue_events_url":"https://api.github.com/repos/MiamiOH/puppet-winlogbeat/issues/events{/number}","events_url":"https://api.github.com/repos/MiamiOH/puppet-winlogbeat/events","assignees_url":"https://api.github.com/repos/MiamiOH/puppet-winlogbeat/assignees{/user}","branches_url":"https://api.github.com/repos/MiamiOH/puppet-winlogbeat/branches{/branch}","tags_url":"https://api.github.com/repos/MiamiOH/puppet-winlogbeat/tags","blobs_url":"https://api.github.com/repos/MiamiOH/puppet-winlogbeat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MiamiOH/puppet-winlogbeat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MiamiOH/puppet-winlogbeat/git/refs{/sha}","trees_url":"https://api.github.com/repos/MiamiOH/puppet-winlogbeat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MiamiOH/puppet-winlogbeat/statuses/{sha}","languages_url":"https://api.github.com/repos/MiamiOH/puppet-winlogbeat/languages","stargazers_url":"https://api.github.com/repos/MiamiOH/puppet-winlogbeat/stargazers","contributors_url":"https://api.github.com/repos/MiamiOH/puppet-winlogbeat/contributors","subscribers_url":"https://api.github.com/repos/MiamiOH/puppet-winlogbeat/subscribers","subscription_url":"https://api.github.com/repos/MiamiOH/puppet-winlogbeat/subscription","commits_url":"https://api.github.com/repos/MiamiOH/puppet-winlogbeat/commits{/sha}","git_commits_url":"https://api.github.com/repos/MiamiOH/puppet-winlogbeat/git/commits{/sha}","comments_url":"https://api.github.com/repos/MiamiOH/puppet-winlogbeat/comments{/number}","issue_comment_url":"https://api.github.com/repos/MiamiOH/puppet-winlogbeat/issues/comments{/number}","contents_url":"https://api.github.com/repos/MiamiOH/puppet-winlogbeat/contents/{+path}","compare_url":"https://api.github.com/repos/MiamiOH/puppet-winlogbeat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MiamiOH/puppet-winlogbeat/merges","archive_url":"https://api.github.com/repos/MiamiOH/puppet-winlogbeat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MiamiOH/puppet-winlogbeat/downloads","issues_url":"https://api.github.com/repos/MiamiOH/puppet-winlogbeat/issues{/number}","pulls_url":"https://api.github.com/repos/MiamiOH/puppet-winlogbeat/pulls{/number}","milestones_url":"https://api.github.com/repos/MiamiOH/puppet-winlogbeat/milestones{/number}","notifications_url":"https://api.github.com/repos/MiamiOH/puppet-winlogbeat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MiamiOH/puppet-winlogbeat/labels{/name}","releases_url":"https://api.github.com/repos/MiamiOH/puppet-winlogbeat/releases{/id}","deployments_url":"https://api.github.com/repos/MiamiOH/puppet-winlogbeat/deployments","created_at":"2017-06-07T18:10:38Z","updated_at":"2017-06-13T12:35:17Z","pushed_at":"2017-06-15T18:07:02Z","git_url":"git://github.com/MiamiOH/puppet-winlogbeat.git","ssh_url":"git@github.com:MiamiOH/puppet-winlogbeat.git","clone_url":"https://github.com/MiamiOH/puppet-winlogbeat.git","svn_url":"https://github.com/MiamiOH/puppet-winlogbeat","homepage":"","size":56,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"skynetsolutions:master","ref":"master","sha":"7ce4c418ab4e0ced43cbda2a972270c45c5b361d","user":{"login":"skynetsolutions","id":10386755,"avatar_url":"https://avatars1.githubusercontent.com/u/10386755?v=3","gravatar_id":"","url":"https://api.github.com/users/skynetsolutions","html_url":"https://github.com/skynetsolutions","followers_url":"https://api.github.com/users/skynetsolutions/followers","following_url":"https://api.github.com/users/skynetsolutions/following{/other_user}","gists_url":"https://api.github.com/users/skynetsolutions/gists{/gist_id}","starred_url":"https://api.github.com/users/skynetsolutions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skynetsolutions/subscriptions","organizations_url":"https://api.github.com/users/skynetsolutions/orgs","repos_url":"https://api.github.com/users/skynetsolutions/repos","events_url":"https://api.github.com/users/skynetsolutions/events{/privacy}","received_events_url":"https://api.github.com/users/skynetsolutions/received_events","type":"Organization","site_admin":false},"repo":{"id":64724454,"name":"puppet-winlogbeat","full_name":"skynetsolutions/puppet-winlogbeat","owner":{"login":"skynetsolutions","id":10386755,"avatar_url":"https://avatars1.githubusercontent.com/u/10386755?v=3","gravatar_id":"","url":"https://api.github.com/users/skynetsolutions","html_url":"https://github.com/skynetsolutions","followers_url":"https://api.github.com/users/skynetsolutions/followers","following_url":"https://api.github.com/users/skynetsolutions/following{/other_user}","gists_url":"https://api.github.com/users/skynetsolutions/gists{/gist_id}","starred_url":"https://api.github.com/users/skynetsolutions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skynetsolutions/subscriptions","organizations_url":"https://api.github.com/users/skynetsolutions/orgs","repos_url":"https://api.github.com/users/skynetsolutions/repos","events_url":"https://api.github.com/users/skynetsolutions/events{/privacy}","received_events_url":"https://api.github.com/users/skynetsolutions/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/skynetsolutions/puppet-winlogbeat","description":null,"fork":false,"url":"https://api.github.com/repos/skynetsolutions/puppet-winlogbeat","forks_url":"https://api.github.com/repos/skynetsolutions/puppet-winlogbeat/forks","keys_url":"https://api.github.com/repos/skynetsolutions/puppet-winlogbeat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/skynetsolutions/puppet-winlogbeat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/skynetsolutions/puppet-winlogbeat/teams","hooks_url":"https://api.github.com/repos/skynetsolutions/puppet-winlogbeat/hooks","issue_events_url":"https://api.github.com/repos/skynetsolutions/puppet-winlogbeat/issues/events{/number}","events_url":"https://api.github.com/repos/skynetsolutions/puppet-winlogbeat/events","assignees_url":"https://api.github.com/repos/skynetsolutions/puppet-winlogbeat/assignees{/user}","branches_url":"https://api.github.com/repos/skynetsolutions/puppet-winlogbeat/branches{/branch}","tags_url":"https://api.github.com/repos/skynetsolutions/puppet-winlogbeat/tags","blobs_url":"https://api.github.com/repos/skynetsolutions/puppet-winlogbeat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/skynetsolutions/puppet-winlogbeat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/skynetsolutions/puppet-winlogbeat/git/refs{/sha}","trees_url":"https://api.github.com/repos/skynetsolutions/puppet-winlogbeat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/skynetsolutions/puppet-winlogbeat/statuses/{sha}","languages_url":"https://api.github.com/repos/skynetsolutions/puppet-winlogbeat/languages","stargazers_url":"https://api.github.com/repos/skynetsolutions/puppet-winlogbeat/stargazers","contributors_url":"https://api.github.com/repos/skynetsolutions/puppet-winlogbeat/contributors","subscribers_url":"https://api.github.com/repos/skynetsolutions/puppet-winlogbeat/subscribers","subscription_url":"https://api.github.com/repos/skynetsolutions/puppet-winlogbeat/subscription","commits_url":"https://api.github.com/repos/skynetsolutions/puppet-winlogbeat/commits{/sha}","git_commits_url":"https://api.github.com/repos/skynetsolutions/puppet-winlogbeat/git/commits{/sha}","comments_url":"https://api.github.com/repos/skynetsolutions/puppet-winlogbeat/comments{/number}","issue_comment_url":"https://api.github.com/repos/skynetsolutions/puppet-winlogbeat/issues/comments{/number}","contents_url":"https://api.github.com/repos/skynetsolutions/puppet-winlogbeat/contents/{+path}","compare_url":"https://api.github.com/repos/skynetsolutions/puppet-winlogbeat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/skynetsolutions/puppet-winlogbeat/merges","archive_url":"https://api.github.com/repos/skynetsolutions/puppet-winlogbeat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/skynetsolutions/puppet-winlogbeat/downloads","issues_url":"https://api.github.com/repos/skynetsolutions/puppet-winlogbeat/issues{/number}","pulls_url":"https://api.github.com/repos/skynetsolutions/puppet-winlogbeat/pulls{/number}","milestones_url":"https://api.github.com/repos/skynetsolutions/puppet-winlogbeat/milestones{/number}","notifications_url":"https://api.github.com/repos/skynetsolutions/puppet-winlogbeat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/skynetsolutions/puppet-winlogbeat/labels{/name}","releases_url":"https://api.github.com/repos/skynetsolutions/puppet-winlogbeat/releases{/id}","deployments_url":"https://api.github.com/repos/skynetsolutions/puppet-winlogbeat/deployments","created_at":"2016-08-02T04:36:00Z","updated_at":"2016-08-03T05:07:21Z","pushed_at":"2017-06-15T18:07:04Z","git_url":"git://github.com/skynetsolutions/puppet-winlogbeat.git","ssh_url":"git@github.com:skynetsolutions/puppet-winlogbeat.git","clone_url":"https://github.com/skynetsolutions/puppet-winlogbeat.git","svn_url":"https://github.com/skynetsolutions/puppet-winlogbeat","homepage":null,"size":17,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":6,"forks":6,"open_issues":6,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/skynetsolutions/puppet-winlogbeat/pulls/6"},"html":{"href":"https://github.com/skynetsolutions/puppet-winlogbeat/pull/6"},"issue":{"href":"https://api.github.com/repos/skynetsolutions/puppet-winlogbeat/issues/6"},"comments":{"href":"https://api.github.com/repos/skynetsolutions/puppet-winlogbeat/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/skynetsolutions/puppet-winlogbeat/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/skynetsolutions/puppet-winlogbeat/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/skynetsolutions/puppet-winlogbeat/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/skynetsolutions/puppet-winlogbeat/statuses/cfb9f1683d02538e63b39e8288f8bdba12177cd6"}}}}
{"actor":{"display_login":"edestecd"}}