{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-mxnet/pulls/comments/155898721","pull_request_review_id":82300273,"id":155898721,"diff_hunk":"@@ -0,0 +1,25 @@\n+# Licensed to the Apache Software Foundation (ASF) under one\n+# or more contributor license agreements.  See the NOTICE file\n+# distributed with this work for additional information\n+# regarding copyright ownership.  The ASF licenses this file\n+# to you under the Apache License, Version 2.0 (the\n+# \"License\"); you may not use this file except in compliance\n+# with the License.  You may obtain a copy of the License at\n+#\n+#   http://www.apache.org/licenses/LICENSE-2.0\n+#\n+# Unless required by applicable law or agreed to in writing,\n+# software distributed under the License is distributed on an\n+# \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY\n+# KIND, either express or implied.  See the License for the\n+# specific language governing permissions and limitations\n+# under the License.\n+\n+# coding: utf-8\n+# pylint: disable=wildcard-import\n+\"\"\"Text utilities.\"\"\"\n+\n+from . import utils\n+from .utils import *\n+from . import glossary\n+from .glossary import *","path":"python/mxnet/text/__init__.py","position":25,"original_position":25,"commit_id":"215c39caf248df2a815b4157954c1593f2d9fe4e","original_commit_id":"dba9944136ceded579ad6930176cde0e283fb5ce","user":{"login":"szha","id":2626883,"avatar_url":"https://avatars2.githubusercontent.com/u/2626883?v=4","gravatar_id":"","url":"https://api.github.com/users/szha","html_url":"https://github.com/szha","followers_url":"https://api.github.com/users/szha/followers","following_url":"https://api.github.com/users/szha/following{/other_user}","gists_url":"https://api.github.com/users/szha/gists{/gist_id}","starred_url":"https://api.github.com/users/szha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szha/subscriptions","organizations_url":"https://api.github.com/users/szha/orgs","repos_url":"https://api.github.com/users/szha/repos","events_url":"https://api.github.com/users/szha/events{/privacy}","received_events_url":"https://api.github.com/users/szha/received_events","type":"User","site_admin":false},"body":"If so, then I think the utils and glossary namespaces are unnecessary. There’s no point in keeping both.","created_at":"2017-12-08T23:27:54Z","updated_at":"2017-12-08T23:27:55Z","html_url":"https://github.com/apache/incubator-mxnet/pull/8763#discussion_r155898721","pull_request_url":"https://api.github.com/repos/apache/incubator-mxnet/pulls/8763","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-mxnet/pulls/comments/155898721"},"html":{"href":"https://github.com/apache/incubator-mxnet/pull/8763#discussion_r155898721"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-mxnet/pulls/8763"}},"in_reply_to_id":155858164},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-mxnet/pulls/8763","id":154046806,"html_url":"https://github.com/apache/incubator-mxnet/pull/8763","diff_url":"https://github.com/apache/incubator-mxnet/pull/8763.diff","patch_url":"https://github.com/apache/incubator-mxnet/pull/8763.patch","issue_url":"https://api.github.com/repos/apache/incubator-mxnet/issues/8763","number":8763,"state":"open","locked":false,"title":"[WIP] Add text apis","user":{"login":"astonzhang","id":22279212,"avatar_url":"https://avatars1.githubusercontent.com/u/22279212?v=4","gravatar_id":"","url":"https://api.github.com/users/astonzhang","html_url":"https://github.com/astonzhang","followers_url":"https://api.github.com/users/astonzhang/followers","following_url":"https://api.github.com/users/astonzhang/following{/other_user}","gists_url":"https://api.github.com/users/astonzhang/gists{/gist_id}","starred_url":"https://api.github.com/users/astonzhang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astonzhang/subscriptions","organizations_url":"https://api.github.com/users/astonzhang/orgs","repos_url":"https://api.github.com/users/astonzhang/repos","events_url":"https://api.github.com/users/astonzhang/events{/privacy}","received_events_url":"https://api.github.com/users/astonzhang/received_events","type":"User","site_admin":false},"body":"## Description ##\r\nAdd text APIs, such as text utils, glossary class, and pre-trained embeddings.\r\n\r\n## Checklist ##\r\n### Essentials ###\r\n- [ ] Passed code style checking (`make lint`)\r\n- [ ] Changes are complete (i.e. I finished coding on this PR)\r\n- [ ] All changes have test coverage\r\n- [ ] For user-facing API changes, API doc string has been updated. For new C++ functions in header files, their functionalities and arguments are well-documented. \r\n- [ ] To my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change\r\n\r\n### Changes ###\r\n- [ ] Text utils, tests, (and when applicable, API doc)\r\n- [ ] Glossary, tests, (and when applicable, API doc)\r\n\r\n## Comments ##\r\n- WIP\r\n","created_at":"2017-11-22T02:07:12Z","updated_at":"2017-12-08T23:27:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c0f419458643af7836822a42a1ecace78698d238","assignee":{"login":"szha","id":2626883,"avatar_url":"https://avatars2.githubusercontent.com/u/2626883?v=4","gravatar_id":"","url":"https://api.github.com/users/szha","html_url":"https://github.com/szha","followers_url":"https://api.github.com/users/szha/followers","following_url":"https://api.github.com/users/szha/following{/other_user}","gists_url":"https://api.github.com/users/szha/gists{/gist_id}","starred_url":"https://api.github.com/users/szha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szha/subscriptions","organizations_url":"https://api.github.com/users/szha/orgs","repos_url":"https://api.github.com/users/szha/repos","events_url":"https://api.github.com/users/szha/events{/privacy}","received_events_url":"https://api.github.com/users/szha/received_events","type":"User","site_admin":false},"assignees":[{"login":"szha","id":2626883,"avatar_url":"https://avatars2.githubusercontent.com/u/2626883?v=4","gravatar_id":"","url":"https://api.github.com/users/szha","html_url":"https://github.com/szha","followers_url":"https://api.github.com/users/szha/followers","following_url":"https://api.github.com/users/szha/following{/other_user}","gists_url":"https://api.github.com/users/szha/gists{/gist_id}","starred_url":"https://api.github.com/users/szha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szha/subscriptions","organizations_url":"https://api.github.com/users/szha/orgs","repos_url":"https://api.github.com/users/szha/repos","events_url":"https://api.github.com/users/szha/events{/privacy}","received_events_url":"https://api.github.com/users/szha/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-mxnet/pulls/8763/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-mxnet/pulls/8763/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-mxnet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-mxnet/issues/8763/comments","statuses_url":"https://api.github.com/repos/apache/incubator-mxnet/statuses/215c39caf248df2a815b4157954c1593f2d9fe4e","head":{"label":"astonzhang:text","ref":"text","sha":"215c39caf248df2a815b4157954c1593f2d9fe4e","user":{"login":"astonzhang","id":22279212,"avatar_url":"https://avatars1.githubusercontent.com/u/22279212?v=4","gravatar_id":"","url":"https://api.github.com/users/astonzhang","html_url":"https://github.com/astonzhang","followers_url":"https://api.github.com/users/astonzhang/followers","following_url":"https://api.github.com/users/astonzhang/following{/other_user}","gists_url":"https://api.github.com/users/astonzhang/gists{/gist_id}","starred_url":"https://api.github.com/users/astonzhang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astonzhang/subscriptions","organizations_url":"https://api.github.com/users/astonzhang/orgs","repos_url":"https://api.github.com/users/astonzhang/repos","events_url":"https://api.github.com/users/astonzhang/events{/privacy}","received_events_url":"https://api.github.com/users/astonzhang/received_events","type":"User","site_admin":false},"repo":{"id":85788487,"name":"mxnet","full_name":"astonzhang/mxnet","owner":{"login":"astonzhang","id":22279212,"avatar_url":"https://avatars1.githubusercontent.com/u/22279212?v=4","gravatar_id":"","url":"https://api.github.com/users/astonzhang","html_url":"https://github.com/astonzhang","followers_url":"https://api.github.com/users/astonzhang/followers","following_url":"https://api.github.com/users/astonzhang/following{/other_user}","gists_url":"https://api.github.com/users/astonzhang/gists{/gist_id}","starred_url":"https://api.github.com/users/astonzhang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astonzhang/subscriptions","organizations_url":"https://api.github.com/users/astonzhang/orgs","repos_url":"https://api.github.com/users/astonzhang/repos","events_url":"https://api.github.com/users/astonzhang/events{/privacy}","received_events_url":"https://api.github.com/users/astonzhang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/astonzhang/mxnet","description":"Lightweight, Portable, Flexible Distributed/Mobile Deep Learning with Dynamic, Mutation-aware Dataflow Dep Scheduler; for Python, R, Julia, Scala, Go, Javascript and more","fork":true,"url":"https://api.github.com/repos/astonzhang/mxnet","forks_url":"https://api.github.com/repos/astonzhang/mxnet/forks","keys_url":"https://api.github.com/repos/astonzhang/mxnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/astonzhang/mxnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/astonzhang/mxnet/teams","hooks_url":"https://api.github.com/repos/astonzhang/mxnet/hooks","issue_events_url":"https://api.github.com/repos/astonzhang/mxnet/issues/events{/number}","events_url":"https://api.github.com/repos/astonzhang/mxnet/events","assignees_url":"https://api.github.com/repos/astonzhang/mxnet/assignees{/user}","branches_url":"https://api.github.com/repos/astonzhang/mxnet/branches{/branch}","tags_url":"https://api.github.com/repos/astonzhang/mxnet/tags","blobs_url":"https://api.github.com/repos/astonzhang/mxnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/astonzhang/mxnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/astonzhang/mxnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/astonzhang/mxnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/astonzhang/mxnet/statuses/{sha}","languages_url":"https://api.github.com/repos/astonzhang/mxnet/languages","stargazers_url":"https://api.github.com/repos/astonzhang/mxnet/stargazers","contributors_url":"https://api.github.com/repos/astonzhang/mxnet/contributors","subscribers_url":"https://api.github.com/repos/astonzhang/mxnet/subscribers","subscription_url":"https://api.github.com/repos/astonzhang/mxnet/subscription","commits_url":"https://api.github.com/repos/astonzhang/mxnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/astonzhang/mxnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/astonzhang/mxnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/astonzhang/mxnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/astonzhang/mxnet/contents/{+path}","compare_url":"https://api.github.com/repos/astonzhang/mxnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/astonzhang/mxnet/merges","archive_url":"https://api.github.com/repos/astonzhang/mxnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/astonzhang/mxnet/downloads","issues_url":"https://api.github.com/repos/astonzhang/mxnet/issues{/number}","pulls_url":"https://api.github.com/repos/astonzhang/mxnet/pulls{/number}","milestones_url":"https://api.github.com/repos/astonzhang/mxnet/milestones{/number}","notifications_url":"https://api.github.com/repos/astonzhang/mxnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/astonzhang/mxnet/labels{/name}","releases_url":"https://api.github.com/repos/astonzhang/mxnet/releases{/id}","deployments_url":"https://api.github.com/repos/astonzhang/mxnet/deployments","created_at":"2017-03-22T05:27:30Z","updated_at":"2017-09-19T21:28:35Z","pushed_at":"2017-12-08T23:09:32Z","git_url":"git://github.com/astonzhang/mxnet.git","ssh_url":"git@github.com:astonzhang/mxnet.git","clone_url":"https://github.com/astonzhang/mxnet.git","svn_url":"https://github.com/astonzhang/mxnet","homepage":"http://mxnet.io","size":30337,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"075ef680ece77014cc3314594a4b3de6dd9cc74c","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":34864402,"name":"incubator-mxnet","full_name":"apache/incubator-mxnet","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-mxnet","description":"Lightweight, Portable, Flexible Distributed/Mobile Deep Learning with Dynamic, Mutation-aware Dataflow Dep Scheduler; for Python, R, Julia, Scala, Go, Javascript and more","fork":false,"url":"https://api.github.com/repos/apache/incubator-mxnet","forks_url":"https://api.github.com/repos/apache/incubator-mxnet/forks","keys_url":"https://api.github.com/repos/apache/incubator-mxnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-mxnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-mxnet/teams","hooks_url":"https://api.github.com/repos/apache/incubator-mxnet/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-mxnet/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-mxnet/events","assignees_url":"https://api.github.com/repos/apache/incubator-mxnet/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-mxnet/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-mxnet/tags","blobs_url":"https://api.github.com/repos/apache/incubator-mxnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-mxnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-mxnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-mxnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-mxnet/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-mxnet/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-mxnet/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-mxnet/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-mxnet/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-mxnet/subscription","commits_url":"https://api.github.com/repos/apache/incubator-mxnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-mxnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-mxnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-mxnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-mxnet/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-mxnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-mxnet/merges","archive_url":"https://api.github.com/repos/apache/incubator-mxnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-mxnet/downloads","issues_url":"https://api.github.com/repos/apache/incubator-mxnet/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-mxnet/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-mxnet/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-mxnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-mxnet/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-mxnet/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-mxnet/deployments","created_at":"2015-04-30T16:21:15Z","updated_at":"2017-12-08T18:21:16Z","pushed_at":"2017-12-08T23:09:35Z","git_url":"git://github.com/apache/incubator-mxnet.git","ssh_url":"git@github.com:apache/incubator-mxnet.git","clone_url":"https://github.com/apache/incubator-mxnet.git","svn_url":"https://github.com/apache/incubator-mxnet","homepage":"http://mxnet.io","size":30563,"stargazers_count":12333,"watchers_count":12333,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4540,"mirror_url":null,"archived":false,"open_issues_count":653,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":4540,"open_issues":653,"watchers":12333,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-mxnet/pulls/8763"},"html":{"href":"https://github.com/apache/incubator-mxnet/pull/8763"},"issue":{"href":"https://api.github.com/repos/apache/incubator-mxnet/issues/8763"},"comments":{"href":"https://api.github.com/repos/apache/incubator-mxnet/issues/8763/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-mxnet/pulls/8763/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-mxnet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-mxnet/pulls/8763/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-mxnet/statuses/215c39caf248df2a815b4157954c1593f2d9fe4e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"szha"}}