{"action":"created","comment":{"url":"https://api.github.com/repos/shopware/SwagConnect/pulls/comments/152598306","pull_request_review_id":78484345,"id":152598306,"diff_hunk":"@@ -46,9 +45,7 @@\n     /**\n      * @var array\n      */\n-//    private $commonTestFixtures = [\n-//        __DIR__ . '/../../common_user_test_fixtures.sql',\n-//    ];\n+    private $commonTestFixtures = [];","path":"Tests/KernelTestCaseTrait.php","position":null,"original_position":15,"commit_id":"e0c646753afafed73e190ce7f30a72983814988d","original_commit_id":"e0c646753afafed73e190ce7f30a72983814988d","user":{"login":"keulinho","id":15930605,"avatar_url":"https://avatars0.githubusercontent.com/u/15930605?v=4","gravatar_id":"","url":"https://api.github.com/users/keulinho","html_url":"https://github.com/keulinho","followers_url":"https://api.github.com/users/keulinho/followers","following_url":"https://api.github.com/users/keulinho/following{/other_user}","gists_url":"https://api.github.com/users/keulinho/gists{/gist_id}","starred_url":"https://api.github.com/users/keulinho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keulinho/subscriptions","organizations_url":"https://api.github.com/users/keulinho/orgs","repos_url":"https://api.github.com/users/keulinho/repos","events_url":"https://api.github.com/users/keulinho/events{/privacy}","received_events_url":"https://api.github.com/users/keulinho/received_events","type":"User","site_admin":false},"body":"is it really needed or can we simply delete it","created_at":"2017-11-22T15:32:14Z","updated_at":"2017-11-22T15:32:14Z","html_url":"https://github.com/shopware/SwagConnect/pull/414#discussion_r152598306","pull_request_url":"https://api.github.com/repos/shopware/SwagConnect/pulls/414","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/shopware/SwagConnect/pulls/comments/152598306"},"html":{"href":"https://github.com/shopware/SwagConnect/pull/414#discussion_r152598306"},"pull_request":{"href":"https://api.github.com/repos/shopware/SwagConnect/pulls/414"}}},"pull_request":{"url":"https://api.github.com/repos/shopware/SwagConnect/pulls/414","id":153035293,"html_url":"https://github.com/shopware/SwagConnect/pull/414","diff_url":"https://github.com/shopware/SwagConnect/pull/414.diff","patch_url":"https://github.com/shopware/SwagConnect/pull/414.patch","issue_url":"https://api.github.com/repos/shopware/SwagConnect/issues/414","number":414,"state":"open","locked":false,"title":"CON-4928: Added a Functional test for the main Connect Controller ","user":{"login":"Christian-Rades","id":28293825,"avatar_url":"https://avatars3.githubusercontent.com/u/28293825?v=4","gravatar_id":"","url":"https://api.github.com/users/Christian-Rades","html_url":"https://github.com/Christian-Rades","followers_url":"https://api.github.com/users/Christian-Rades/followers","following_url":"https://api.github.com/users/Christian-Rades/following{/other_user}","gists_url":"https://api.github.com/users/Christian-Rades/gists{/gist_id}","starred_url":"https://api.github.com/users/Christian-Rades/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Christian-Rades/subscriptions","organizations_url":"https://api.github.com/users/Christian-Rades/orgs","repos_url":"https://api.github.com/users/Christian-Rades/repos","events_url":"https://api.github.com/users/Christian-Rades/events{/privacy}","received_events_url":"https://api.github.com/users/Christian-Rades/received_events","type":"User","site_admin":false},"body":"Added the WebTestCaseTrait from the B2B suite and its infrastructure.\r\nImplemented a ConnectControllerTest to check the most used actions.\r\nRefactored all functional tests to use the WebTestCaseTrait","created_at":"2017-11-16T13:03:56Z","updated_at":"2017-11-22T15:32:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4e1c2863f82079c7b9896d39a255ea60acfec498","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/shopware/SwagConnect/pulls/414/commits","review_comments_url":"https://api.github.com/repos/shopware/SwagConnect/pulls/414/comments","review_comment_url":"https://api.github.com/repos/shopware/SwagConnect/pulls/comments{/number}","comments_url":"https://api.github.com/repos/shopware/SwagConnect/issues/414/comments","statuses_url":"https://api.github.com/repos/shopware/SwagConnect/statuses/e0c646753afafed73e190ce7f30a72983814988d","head":{"label":"shopware:CON-4928","ref":"CON-4928","sha":"e0c646753afafed73e190ce7f30a72983814988d","user":{"login":"shopware","id":612628,"avatar_url":"https://avatars2.githubusercontent.com/u/612628?v=4","gravatar_id":"","url":"https://api.github.com/users/shopware","html_url":"https://github.com/shopware","followers_url":"https://api.github.com/users/shopware/followers","following_url":"https://api.github.com/users/shopware/following{/other_user}","gists_url":"https://api.github.com/users/shopware/gists{/gist_id}","starred_url":"https://api.github.com/users/shopware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shopware/subscriptions","organizations_url":"https://api.github.com/users/shopware/orgs","repos_url":"https://api.github.com/users/shopware/repos","events_url":"https://api.github.com/users/shopware/events{/privacy}","received_events_url":"https://api.github.com/users/shopware/received_events","type":"Organization","site_admin":false},"repo":{"id":26867190,"name":"SwagConnect","full_name":"shopware/SwagConnect","owner":{"login":"shopware","id":612628,"avatar_url":"https://avatars2.githubusercontent.com/u/612628?v=4","gravatar_id":"","url":"https://api.github.com/users/shopware","html_url":"https://github.com/shopware","followers_url":"https://api.github.com/users/shopware/followers","following_url":"https://api.github.com/users/shopware/following{/other_user}","gists_url":"https://api.github.com/users/shopware/gists{/gist_id}","starred_url":"https://api.github.com/users/shopware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shopware/subscriptions","organizations_url":"https://api.github.com/users/shopware/orgs","repos_url":"https://api.github.com/users/shopware/repos","events_url":"https://api.github.com/users/shopware/events{/privacy}","received_events_url":"https://api.github.com/users/shopware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/shopware/SwagConnect","description":null,"fork":false,"url":"https://api.github.com/repos/shopware/SwagConnect","forks_url":"https://api.github.com/repos/shopware/SwagConnect/forks","keys_url":"https://api.github.com/repos/shopware/SwagConnect/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shopware/SwagConnect/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shopware/SwagConnect/teams","hooks_url":"https://api.github.com/repos/shopware/SwagConnect/hooks","issue_events_url":"https://api.github.com/repos/shopware/SwagConnect/issues/events{/number}","events_url":"https://api.github.com/repos/shopware/SwagConnect/events","assignees_url":"https://api.github.com/repos/shopware/SwagConnect/assignees{/user}","branches_url":"https://api.github.com/repos/shopware/SwagConnect/branches{/branch}","tags_url":"https://api.github.com/repos/shopware/SwagConnect/tags","blobs_url":"https://api.github.com/repos/shopware/SwagConnect/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shopware/SwagConnect/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shopware/SwagConnect/git/refs{/sha}","trees_url":"https://api.github.com/repos/shopware/SwagConnect/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shopware/SwagConnect/statuses/{sha}","languages_url":"https://api.github.com/repos/shopware/SwagConnect/languages","stargazers_url":"https://api.github.com/repos/shopware/SwagConnect/stargazers","contributors_url":"https://api.github.com/repos/shopware/SwagConnect/contributors","subscribers_url":"https://api.github.com/repos/shopware/SwagConnect/subscribers","subscription_url":"https://api.github.com/repos/shopware/SwagConnect/subscription","commits_url":"https://api.github.com/repos/shopware/SwagConnect/commits{/sha}","git_commits_url":"https://api.github.com/repos/shopware/SwagConnect/git/commits{/sha}","comments_url":"https://api.github.com/repos/shopware/SwagConnect/comments{/number}","issue_comment_url":"https://api.github.com/repos/shopware/SwagConnect/issues/comments{/number}","contents_url":"https://api.github.com/repos/shopware/SwagConnect/contents/{+path}","compare_url":"https://api.github.com/repos/shopware/SwagConnect/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shopware/SwagConnect/merges","archive_url":"https://api.github.com/repos/shopware/SwagConnect/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shopware/SwagConnect/downloads","issues_url":"https://api.github.com/repos/shopware/SwagConnect/issues{/number}","pulls_url":"https://api.github.com/repos/shopware/SwagConnect/pulls{/number}","milestones_url":"https://api.github.com/repos/shopware/SwagConnect/milestones{/number}","notifications_url":"https://api.github.com/repos/shopware/SwagConnect/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shopware/SwagConnect/labels{/name}","releases_url":"https://api.github.com/repos/shopware/SwagConnect/releases{/id}","deployments_url":"https://api.github.com/repos/shopware/SwagConnect/deployments","created_at":"2014-11-19T15:19:16Z","updated_at":"2017-06-12T08:52:34Z","pushed_at":"2017-11-22T14:44:13Z","git_url":"git://github.com/shopware/SwagConnect.git","ssh_url":"git@github.com:shopware/SwagConnect.git","clone_url":"https://github.com/shopware/SwagConnect.git","svn_url":"https://github.com/shopware/SwagConnect","homepage":"","size":6955,"stargazers_count":6,"watchers_count":6,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":9,"forks":3,"open_issues":9,"watchers":6,"default_branch":"master"}},"base":{"label":"shopware:master","ref":"master","sha":"b510aab4097635638067d6e0e1a7dbe43b82c9fb","user":{"login":"shopware","id":612628,"avatar_url":"https://avatars2.githubusercontent.com/u/612628?v=4","gravatar_id":"","url":"https://api.github.com/users/shopware","html_url":"https://github.com/shopware","followers_url":"https://api.github.com/users/shopware/followers","following_url":"https://api.github.com/users/shopware/following{/other_user}","gists_url":"https://api.github.com/users/shopware/gists{/gist_id}","starred_url":"https://api.github.com/users/shopware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shopware/subscriptions","organizations_url":"https://api.github.com/users/shopware/orgs","repos_url":"https://api.github.com/users/shopware/repos","events_url":"https://api.github.com/users/shopware/events{/privacy}","received_events_url":"https://api.github.com/users/shopware/received_events","type":"Organization","site_admin":false},"repo":{"id":26867190,"name":"SwagConnect","full_name":"shopware/SwagConnect","owner":{"login":"shopware","id":612628,"avatar_url":"https://avatars2.githubusercontent.com/u/612628?v=4","gravatar_id":"","url":"https://api.github.com/users/shopware","html_url":"https://github.com/shopware","followers_url":"https://api.github.com/users/shopware/followers","following_url":"https://api.github.com/users/shopware/following{/other_user}","gists_url":"https://api.github.com/users/shopware/gists{/gist_id}","starred_url":"https://api.github.com/users/shopware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shopware/subscriptions","organizations_url":"https://api.github.com/users/shopware/orgs","repos_url":"https://api.github.com/users/shopware/repos","events_url":"https://api.github.com/users/shopware/events{/privacy}","received_events_url":"https://api.github.com/users/shopware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/shopware/SwagConnect","description":null,"fork":false,"url":"https://api.github.com/repos/shopware/SwagConnect","forks_url":"https://api.github.com/repos/shopware/SwagConnect/forks","keys_url":"https://api.github.com/repos/shopware/SwagConnect/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shopware/SwagConnect/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shopware/SwagConnect/teams","hooks_url":"https://api.github.com/repos/shopware/SwagConnect/hooks","issue_events_url":"https://api.github.com/repos/shopware/SwagConnect/issues/events{/number}","events_url":"https://api.github.com/repos/shopware/SwagConnect/events","assignees_url":"https://api.github.com/repos/shopware/SwagConnect/assignees{/user}","branches_url":"https://api.github.com/repos/shopware/SwagConnect/branches{/branch}","tags_url":"https://api.github.com/repos/shopware/SwagConnect/tags","blobs_url":"https://api.github.com/repos/shopware/SwagConnect/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shopware/SwagConnect/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shopware/SwagConnect/git/refs{/sha}","trees_url":"https://api.github.com/repos/shopware/SwagConnect/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shopware/SwagConnect/statuses/{sha}","languages_url":"https://api.github.com/repos/shopware/SwagConnect/languages","stargazers_url":"https://api.github.com/repos/shopware/SwagConnect/stargazers","contributors_url":"https://api.github.com/repos/shopware/SwagConnect/contributors","subscribers_url":"https://api.github.com/repos/shopware/SwagConnect/subscribers","subscription_url":"https://api.github.com/repos/shopware/SwagConnect/subscription","commits_url":"https://api.github.com/repos/shopware/SwagConnect/commits{/sha}","git_commits_url":"https://api.github.com/repos/shopware/SwagConnect/git/commits{/sha}","comments_url":"https://api.github.com/repos/shopware/SwagConnect/comments{/number}","issue_comment_url":"https://api.github.com/repos/shopware/SwagConnect/issues/comments{/number}","contents_url":"https://api.github.com/repos/shopware/SwagConnect/contents/{+path}","compare_url":"https://api.github.com/repos/shopware/SwagConnect/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shopware/SwagConnect/merges","archive_url":"https://api.github.com/repos/shopware/SwagConnect/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shopware/SwagConnect/downloads","issues_url":"https://api.github.com/repos/shopware/SwagConnect/issues{/number}","pulls_url":"https://api.github.com/repos/shopware/SwagConnect/pulls{/number}","milestones_url":"https://api.github.com/repos/shopware/SwagConnect/milestones{/number}","notifications_url":"https://api.github.com/repos/shopware/SwagConnect/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shopware/SwagConnect/labels{/name}","releases_url":"https://api.github.com/repos/shopware/SwagConnect/releases{/id}","deployments_url":"https://api.github.com/repos/shopware/SwagConnect/deployments","created_at":"2014-11-19T15:19:16Z","updated_at":"2017-06-12T08:52:34Z","pushed_at":"2017-11-22T14:44:13Z","git_url":"git://github.com/shopware/SwagConnect.git","ssh_url":"git@github.com:shopware/SwagConnect.git","clone_url":"https://github.com/shopware/SwagConnect.git","svn_url":"https://github.com/shopware/SwagConnect","homepage":"","size":6955,"stargazers_count":6,"watchers_count":6,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":9,"forks":3,"open_issues":9,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/shopware/SwagConnect/pulls/414"},"html":{"href":"https://github.com/shopware/SwagConnect/pull/414"},"issue":{"href":"https://api.github.com/repos/shopware/SwagConnect/issues/414"},"comments":{"href":"https://api.github.com/repos/shopware/SwagConnect/issues/414/comments"},"review_comments":{"href":"https://api.github.com/repos/shopware/SwagConnect/pulls/414/comments"},"review_comment":{"href":"https://api.github.com/repos/shopware/SwagConnect/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/shopware/SwagConnect/pulls/414/commits"},"statuses":{"href":"https://api.github.com/repos/shopware/SwagConnect/statuses/e0c646753afafed73e190ce7f30a72983814988d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"keulinho"}}