{"action":"closed","number":115,"pull_request":{"url":"https://api.github.com/repos/SSSD/sssd/pulls/115","id":99166007,"html_url":"https://github.com/SSSD/sssd/pull/115","diff_url":"https://github.com/SSSD/sssd/pull/115.diff","patch_url":"https://github.com/SSSD/sssd/pull/115.patch","issue_url":"https://api.github.com/repos/SSSD/sssd/issues/115","number":115,"state":"closed","locked":false,"title":"libwbclient-sssd: wbcLookupSid() allow NULL arguments","user":{"login":"sumit-bose","id":15247317,"avatar_url":"https://avatars.githubusercontent.com/u/15247317?v=3","gravatar_id":"","url":"https://api.github.com/users/sumit-bose","html_url":"https://github.com/sumit-bose","followers_url":"https://api.github.com/users/sumit-bose/followers","following_url":"https://api.github.com/users/sumit-bose/following{/other_user}","gists_url":"https://api.github.com/users/sumit-bose/gists{/gist_id}","starred_url":"https://api.github.com/users/sumit-bose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sumit-bose/subscriptions","organizations_url":"https://api.github.com/users/sumit-bose/orgs","repos_url":"https://api.github.com/users/sumit-bose/repos","events_url":"https://api.github.com/users/sumit-bose/events{/privacy}","received_events_url":"https://api.github.com/users/sumit-bose/received_events","type":"User","site_admin":false},"body":"Some caller might not be interested in some of the values wbcLookupSid()\nreturns and just pass NULL. Currently 'net ads user info' does this\nbecause it is not interested in the domain. wbcLookupSid() should handle\nthis gracefully.\n\nResolves https://fedorahosted.org/sssd/ticket/3273\n\nA unit-test for wbcLookupSid() is added as well. I had to wrap\nsss_nss_getnamebysid() because the test shouldn't connect to SSSD but just\nreturn some result. Interestingly the wrapping didn't work when I just added\nlibwbclient.la to _LDADD but I had to explicitly add the needed sources. Does\nanyone know why?","created_at":"2016-12-22T20:35:11Z","updated_at":"2017-01-21T19:23:32Z","closed_at":"2017-01-21T19:23:32Z","merged_at":null,"merge_commit_sha":"153cae5635be6015253022fd3b7a69ee0527054e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/SSSD/sssd/pulls/115/commits","review_comments_url":"https://api.github.com/repos/SSSD/sssd/pulls/115/comments","review_comment_url":"https://api.github.com/repos/SSSD/sssd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SSSD/sssd/issues/115/comments","statuses_url":"https://api.github.com/repos/SSSD/sssd/statuses/135d9a073f5621abc904e7a3e326e7096dc42f96","head":{"label":"sumit-bose:wbcLookupSid-with-NULL-arguments","ref":"wbcLookupSid-with-NULL-arguments","sha":"135d9a073f5621abc904e7a3e326e7096dc42f96","user":{"login":"sumit-bose","id":15247317,"avatar_url":"https://avatars.githubusercontent.com/u/15247317?v=3","gravatar_id":"","url":"https://api.github.com/users/sumit-bose","html_url":"https://github.com/sumit-bose","followers_url":"https://api.github.com/users/sumit-bose/followers","following_url":"https://api.github.com/users/sumit-bose/following{/other_user}","gists_url":"https://api.github.com/users/sumit-bose/gists{/gist_id}","starred_url":"https://api.github.com/users/sumit-bose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sumit-bose/subscriptions","organizations_url":"https://api.github.com/users/sumit-bose/orgs","repos_url":"https://api.github.com/users/sumit-bose/repos","events_url":"https://api.github.com/users/sumit-bose/events{/privacy}","received_events_url":"https://api.github.com/users/sumit-bose/received_events","type":"User","site_admin":false},"repo":{"id":66956847,"name":"sssd","full_name":"sumit-bose/sssd","owner":{"login":"sumit-bose","id":15247317,"avatar_url":"https://avatars.githubusercontent.com/u/15247317?v=3","gravatar_id":"","url":"https://api.github.com/users/sumit-bose","html_url":"https://github.com/sumit-bose","followers_url":"https://api.github.com/users/sumit-bose/followers","following_url":"https://api.github.com/users/sumit-bose/following{/other_user}","gists_url":"https://api.github.com/users/sumit-bose/gists{/gist_id}","starred_url":"https://api.github.com/users/sumit-bose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sumit-bose/subscriptions","organizations_url":"https://api.github.com/users/sumit-bose/orgs","repos_url":"https://api.github.com/users/sumit-bose/repos","events_url":"https://api.github.com/users/sumit-bose/events{/privacy}","received_events_url":"https://api.github.com/users/sumit-bose/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sumit-bose/sssd","description":"A daemon to manage identity, authentication and authorization for centrally-managed systems.","fork":true,"url":"https://api.github.com/repos/sumit-bose/sssd","forks_url":"https://api.github.com/repos/sumit-bose/sssd/forks","keys_url":"https://api.github.com/repos/sumit-bose/sssd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sumit-bose/sssd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sumit-bose/sssd/teams","hooks_url":"https://api.github.com/repos/sumit-bose/sssd/hooks","issue_events_url":"https://api.github.com/repos/sumit-bose/sssd/issues/events{/number}","events_url":"https://api.github.com/repos/sumit-bose/sssd/events","assignees_url":"https://api.github.com/repos/sumit-bose/sssd/assignees{/user}","branches_url":"https://api.github.com/repos/sumit-bose/sssd/branches{/branch}","tags_url":"https://api.github.com/repos/sumit-bose/sssd/tags","blobs_url":"https://api.github.com/repos/sumit-bose/sssd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sumit-bose/sssd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sumit-bose/sssd/git/refs{/sha}","trees_url":"https://api.github.com/repos/sumit-bose/sssd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sumit-bose/sssd/statuses/{sha}","languages_url":"https://api.github.com/repos/sumit-bose/sssd/languages","stargazers_url":"https://api.github.com/repos/sumit-bose/sssd/stargazers","contributors_url":"https://api.github.com/repos/sumit-bose/sssd/contributors","subscribers_url":"https://api.github.com/repos/sumit-bose/sssd/subscribers","subscription_url":"https://api.github.com/repos/sumit-bose/sssd/subscription","commits_url":"https://api.github.com/repos/sumit-bose/sssd/commits{/sha}","git_commits_url":"https://api.github.com/repos/sumit-bose/sssd/git/commits{/sha}","comments_url":"https://api.github.com/repos/sumit-bose/sssd/comments{/number}","issue_comment_url":"https://api.github.com/repos/sumit-bose/sssd/issues/comments{/number}","contents_url":"https://api.github.com/repos/sumit-bose/sssd/contents/{+path}","compare_url":"https://api.github.com/repos/sumit-bose/sssd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sumit-bose/sssd/merges","archive_url":"https://api.github.com/repos/sumit-bose/sssd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sumit-bose/sssd/downloads","issues_url":"https://api.github.com/repos/sumit-bose/sssd/issues{/number}","pulls_url":"https://api.github.com/repos/sumit-bose/sssd/pulls{/number}","milestones_url":"https://api.github.com/repos/sumit-bose/sssd/milestones{/number}","notifications_url":"https://api.github.com/repos/sumit-bose/sssd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sumit-bose/sssd/labels{/name}","releases_url":"https://api.github.com/repos/sumit-bose/sssd/releases{/id}","deployments_url":"https://api.github.com/repos/sumit-bose/sssd/deployments","created_at":"2016-08-30T16:08:36Z","updated_at":"2016-08-30T16:08:41Z","pushed_at":"2016-12-22T20:29:28Z","git_url":"git://github.com/sumit-bose/sssd.git","ssh_url":"git@github.com:sumit-bose/sssd.git","clone_url":"https://github.com/sumit-bose/sssd.git","svn_url":"https://github.com/sumit-bose/sssd","homepage":"https://fedorahosted.org/sssd","size":32828,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SSSD:master","ref":"master","sha":"50a6d01182aba430313746ba71c55e364bf9c6d6","user":{"login":"SSSD","id":12898906,"avatar_url":"https://avatars.githubusercontent.com/u/12898906?v=3","gravatar_id":"","url":"https://api.github.com/users/SSSD","html_url":"https://github.com/SSSD","followers_url":"https://api.github.com/users/SSSD/followers","following_url":"https://api.github.com/users/SSSD/following{/other_user}","gists_url":"https://api.github.com/users/SSSD/gists{/gist_id}","starred_url":"https://api.github.com/users/SSSD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SSSD/subscriptions","organizations_url":"https://api.github.com/users/SSSD/orgs","repos_url":"https://api.github.com/users/SSSD/repos","events_url":"https://api.github.com/users/SSSD/events{/privacy}","received_events_url":"https://api.github.com/users/SSSD/received_events","type":"Organization","site_admin":false},"repo":{"id":37479167,"name":"sssd","full_name":"SSSD/sssd","owner":{"login":"SSSD","id":12898906,"avatar_url":"https://avatars.githubusercontent.com/u/12898906?v=3","gravatar_id":"","url":"https://api.github.com/users/SSSD","html_url":"https://github.com/SSSD","followers_url":"https://api.github.com/users/SSSD/followers","following_url":"https://api.github.com/users/SSSD/following{/other_user}","gists_url":"https://api.github.com/users/SSSD/gists{/gist_id}","starred_url":"https://api.github.com/users/SSSD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SSSD/subscriptions","organizations_url":"https://api.github.com/users/SSSD/orgs","repos_url":"https://api.github.com/users/SSSD/repos","events_url":"https://api.github.com/users/SSSD/events{/privacy}","received_events_url":"https://api.github.com/users/SSSD/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SSSD/sssd","description":"A daemon to manage identity, authentication and authorization for centrally-managed systems.","fork":false,"url":"https://api.github.com/repos/SSSD/sssd","forks_url":"https://api.github.com/repos/SSSD/sssd/forks","keys_url":"https://api.github.com/repos/SSSD/sssd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SSSD/sssd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SSSD/sssd/teams","hooks_url":"https://api.github.com/repos/SSSD/sssd/hooks","issue_events_url":"https://api.github.com/repos/SSSD/sssd/issues/events{/number}","events_url":"https://api.github.com/repos/SSSD/sssd/events","assignees_url":"https://api.github.com/repos/SSSD/sssd/assignees{/user}","branches_url":"https://api.github.com/repos/SSSD/sssd/branches{/branch}","tags_url":"https://api.github.com/repos/SSSD/sssd/tags","blobs_url":"https://api.github.com/repos/SSSD/sssd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SSSD/sssd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SSSD/sssd/git/refs{/sha}","trees_url":"https://api.github.com/repos/SSSD/sssd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SSSD/sssd/statuses/{sha}","languages_url":"https://api.github.com/repos/SSSD/sssd/languages","stargazers_url":"https://api.github.com/repos/SSSD/sssd/stargazers","contributors_url":"https://api.github.com/repos/SSSD/sssd/contributors","subscribers_url":"https://api.github.com/repos/SSSD/sssd/subscribers","subscription_url":"https://api.github.com/repos/SSSD/sssd/subscription","commits_url":"https://api.github.com/repos/SSSD/sssd/commits{/sha}","git_commits_url":"https://api.github.com/repos/SSSD/sssd/git/commits{/sha}","comments_url":"https://api.github.com/repos/SSSD/sssd/comments{/number}","issue_comment_url":"https://api.github.com/repos/SSSD/sssd/issues/comments{/number}","contents_url":"https://api.github.com/repos/SSSD/sssd/contents/{+path}","compare_url":"https://api.github.com/repos/SSSD/sssd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SSSD/sssd/merges","archive_url":"https://api.github.com/repos/SSSD/sssd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SSSD/sssd/downloads","issues_url":"https://api.github.com/repos/SSSD/sssd/issues{/number}","pulls_url":"https://api.github.com/repos/SSSD/sssd/pulls{/number}","milestones_url":"https://api.github.com/repos/SSSD/sssd/milestones{/number}","notifications_url":"https://api.github.com/repos/SSSD/sssd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SSSD/sssd/labels{/name}","releases_url":"https://api.github.com/repos/SSSD/sssd/releases{/id}","deployments_url":"https://api.github.com/repos/SSSD/sssd/deployments","created_at":"2015-06-15T17:09:48Z","updated_at":"2017-01-21T15:45:02Z","pushed_at":"2017-01-21T19:21:27Z","git_url":"git://github.com/SSSD/sssd.git","ssh_url":"git@github.com:SSSD/sssd.git","clone_url":"https://github.com/SSSD/sssd.git","svn_url":"https://github.com/SSSD/sssd","homepage":"https://fedorahosted.org/sssd","size":32936,"stargazers_count":16,"watchers_count":16,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"open_issues_count":15,"forks":28,"open_issues":15,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SSSD/sssd/pulls/115"},"html":{"href":"https://github.com/SSSD/sssd/pull/115"},"issue":{"href":"https://api.github.com/repos/SSSD/sssd/issues/115"},"comments":{"href":"https://api.github.com/repos/SSSD/sssd/issues/115/comments"},"review_comments":{"href":"https://api.github.com/repos/SSSD/sssd/pulls/115/comments"},"review_comment":{"href":"https://api.github.com/repos/SSSD/sssd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SSSD/sssd/pulls/115/commits"},"statuses":{"href":"https://api.github.com/repos/SSSD/sssd/statuses/135d9a073f5621abc904e7a3e326e7096dc42f96"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":167,"deletions":16,"changed_files":3}}
{"actor":{"display_login":"lslebodn"}}