{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes-incubator/cri-containerd/pulls/comments/147298620","pull_request_review_id":72376013,"id":147298620,"diff_hunk":"@@ -89,6 +89,7 @@ func (c *criContainerdService) CreateContainer(ctx context.Context, r *runtime.C\n \t// the same container.\n \tid := util.GenerateID()\n \tname := makeContainerName(config.GetMetadata(), sandboxConfig.GetMetadata())\n+\tglog.V(4).Infof(\"Generate id %q for container %q\", id, name)","path":"pkg/server/container_create.go","position":null,"original_position":4,"commit_id":"5e74cba0f0f858b1c0eb32b1a0c6e93437cc9b1f","original_commit_id":"3f868e6f20b0db8cf8bbd38a9862250ffa22165b","user":{"login":"Random-Liu","id":5821883,"avatar_url":"https://avatars3.githubusercontent.com/u/5821883?v=4","gravatar_id":"","url":"https://api.github.com/users/Random-Liu","html_url":"https://github.com/Random-Liu","followers_url":"https://api.github.com/users/Random-Liu/followers","following_url":"https://api.github.com/users/Random-Liu/following{/other_user}","gists_url":"https://api.github.com/users/Random-Liu/gists{/gist_id}","starred_url":"https://api.github.com/users/Random-Liu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Random-Liu/subscriptions","organizations_url":"https://api.github.com/users/Random-Liu/orgs","repos_url":"https://api.github.com/users/Random-Liu/repos","events_url":"https://api.github.com/users/Random-Liu/events{/privacy}","received_events_url":"https://api.github.com/users/Random-Liu/received_events","type":"User","site_admin":false},"body":"Done.","created_at":"2017-10-27T00:11:33Z","updated_at":"2017-10-27T00:11:33Z","html_url":"https://github.com/kubernetes-incubator/cri-containerd/pull/362#discussion_r147298620","pull_request_url":"https://api.github.com/repos/kubernetes-incubator/cri-containerd/pulls/362","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kubernetes-incubator/cri-containerd/pulls/comments/147298620"},"html":{"href":"https://github.com/kubernetes-incubator/cri-containerd/pull/362#discussion_r147298620"},"pull_request":{"href":"https://api.github.com/repos/kubernetes-incubator/cri-containerd/pulls/362"}},"in_reply_to_id":147295320},"pull_request":{"url":"https://api.github.com/repos/kubernetes-incubator/cri-containerd/pulls/362","id":149070590,"html_url":"https://github.com/kubernetes-incubator/cri-containerd/pull/362","diff_url":"https://github.com/kubernetes-incubator/cri-containerd/pull/362.diff","patch_url":"https://github.com/kubernetes-incubator/cri-containerd/pull/362.patch","issue_url":"https://api.github.com/repos/kubernetes-incubator/cri-containerd/issues/362","number":362,"state":"open","locked":false,"title":"Add log of generated id for debugging.","user":{"login":"Random-Liu","id":5821883,"avatar_url":"https://avatars3.githubusercontent.com/u/5821883?v=4","gravatar_id":"","url":"https://api.github.com/users/Random-Liu","html_url":"https://github.com/Random-Liu","followers_url":"https://api.github.com/users/Random-Liu/followers","following_url":"https://api.github.com/users/Random-Liu/following{/other_user}","gists_url":"https://api.github.com/users/Random-Liu/gists{/gist_id}","starred_url":"https://api.github.com/users/Random-Liu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Random-Liu/subscriptions","organizations_url":"https://api.github.com/users/Random-Liu/orgs","repos_url":"https://api.github.com/users/Random-Liu/repos","events_url":"https://api.github.com/users/Random-Liu/events{/privacy}","received_events_url":"https://api.github.com/users/Random-Liu/received_events","type":"User","site_admin":false},"body":"Add log for generated id. We need these IDs to map container in containerd.log.\r\n\r\nSigned-off-by: Lantao Liu <lantaol@google.com>","created_at":"2017-10-26T23:38:31Z","updated_at":"2017-10-27T00:11:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"36f8609713d84ead55511a7baa3b4345e9952024","assignee":{"login":"mikebrow","id":12767641,"avatar_url":"https://avatars0.githubusercontent.com/u/12767641?v=4","gravatar_id":"","url":"https://api.github.com/users/mikebrow","html_url":"https://github.com/mikebrow","followers_url":"https://api.github.com/users/mikebrow/followers","following_url":"https://api.github.com/users/mikebrow/following{/other_user}","gists_url":"https://api.github.com/users/mikebrow/gists{/gist_id}","starred_url":"https://api.github.com/users/mikebrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikebrow/subscriptions","organizations_url":"https://api.github.com/users/mikebrow/orgs","repos_url":"https://api.github.com/users/mikebrow/repos","events_url":"https://api.github.com/users/mikebrow/events{/privacy}","received_events_url":"https://api.github.com/users/mikebrow/received_events","type":"User","site_admin":false},"assignees":[{"login":"mikebrow","id":12767641,"avatar_url":"https://avatars0.githubusercontent.com/u/12767641?v=4","gravatar_id":"","url":"https://api.github.com/users/mikebrow","html_url":"https://github.com/mikebrow","followers_url":"https://api.github.com/users/mikebrow/followers","following_url":"https://api.github.com/users/mikebrow/following{/other_user}","gists_url":"https://api.github.com/users/mikebrow/gists{/gist_id}","starred_url":"https://api.github.com/users/mikebrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikebrow/subscriptions","organizations_url":"https://api.github.com/users/mikebrow/orgs","repos_url":"https://api.github.com/users/mikebrow/repos","events_url":"https://api.github.com/users/mikebrow/events{/privacy}","received_events_url":"https://api.github.com/users/mikebrow/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes-incubator/cri-containerd/pulls/362/commits","review_comments_url":"https://api.github.com/repos/kubernetes-incubator/cri-containerd/pulls/362/comments","review_comment_url":"https://api.github.com/repos/kubernetes-incubator/cri-containerd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes-incubator/cri-containerd/issues/362/comments","statuses_url":"https://api.github.com/repos/kubernetes-incubator/cri-containerd/statuses/5e74cba0f0f858b1c0eb32b1a0c6e93437cc9b1f","head":{"label":"Random-Liu:add-log","ref":"add-log","sha":"5e74cba0f0f858b1c0eb32b1a0c6e93437cc9b1f","user":{"login":"Random-Liu","id":5821883,"avatar_url":"https://avatars3.githubusercontent.com/u/5821883?v=4","gravatar_id":"","url":"https://api.github.com/users/Random-Liu","html_url":"https://github.com/Random-Liu","followers_url":"https://api.github.com/users/Random-Liu/followers","following_url":"https://api.github.com/users/Random-Liu/following{/other_user}","gists_url":"https://api.github.com/users/Random-Liu/gists{/gist_id}","starred_url":"https://api.github.com/users/Random-Liu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Random-Liu/subscriptions","organizations_url":"https://api.github.com/users/Random-Liu/orgs","repos_url":"https://api.github.com/users/Random-Liu/repos","events_url":"https://api.github.com/users/Random-Liu/events{/privacy}","received_events_url":"https://api.github.com/users/Random-Liu/received_events","type":"User","site_admin":false},"repo":{"id":88243482,"name":"cri-containerd","full_name":"Random-Liu/cri-containerd","owner":{"login":"Random-Liu","id":5821883,"avatar_url":"https://avatars3.githubusercontent.com/u/5821883?v=4","gravatar_id":"","url":"https://api.github.com/users/Random-Liu","html_url":"https://github.com/Random-Liu","followers_url":"https://api.github.com/users/Random-Liu/followers","following_url":"https://api.github.com/users/Random-Liu/following{/other_user}","gists_url":"https://api.github.com/users/Random-Liu/gists{/gist_id}","starred_url":"https://api.github.com/users/Random-Liu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Random-Liu/subscriptions","organizations_url":"https://api.github.com/users/Random-Liu/orgs","repos_url":"https://api.github.com/users/Random-Liu/repos","events_url":"https://api.github.com/users/Random-Liu/events{/privacy}","received_events_url":"https://api.github.com/users/Random-Liu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Random-Liu/cri-containerd","description":"Containerd-based implementation of Kubernetes Container Runtime Interface","fork":true,"url":"https://api.github.com/repos/Random-Liu/cri-containerd","forks_url":"https://api.github.com/repos/Random-Liu/cri-containerd/forks","keys_url":"https://api.github.com/repos/Random-Liu/cri-containerd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Random-Liu/cri-containerd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Random-Liu/cri-containerd/teams","hooks_url":"https://api.github.com/repos/Random-Liu/cri-containerd/hooks","issue_events_url":"https://api.github.com/repos/Random-Liu/cri-containerd/issues/events{/number}","events_url":"https://api.github.com/repos/Random-Liu/cri-containerd/events","assignees_url":"https://api.github.com/repos/Random-Liu/cri-containerd/assignees{/user}","branches_url":"https://api.github.com/repos/Random-Liu/cri-containerd/branches{/branch}","tags_url":"https://api.github.com/repos/Random-Liu/cri-containerd/tags","blobs_url":"https://api.github.com/repos/Random-Liu/cri-containerd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Random-Liu/cri-containerd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Random-Liu/cri-containerd/git/refs{/sha}","trees_url":"https://api.github.com/repos/Random-Liu/cri-containerd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Random-Liu/cri-containerd/statuses/{sha}","languages_url":"https://api.github.com/repos/Random-Liu/cri-containerd/languages","stargazers_url":"https://api.github.com/repos/Random-Liu/cri-containerd/stargazers","contributors_url":"https://api.github.com/repos/Random-Liu/cri-containerd/contributors","subscribers_url":"https://api.github.com/repos/Random-Liu/cri-containerd/subscribers","subscription_url":"https://api.github.com/repos/Random-Liu/cri-containerd/subscription","commits_url":"https://api.github.com/repos/Random-Liu/cri-containerd/commits{/sha}","git_commits_url":"https://api.github.com/repos/Random-Liu/cri-containerd/git/commits{/sha}","comments_url":"https://api.github.com/repos/Random-Liu/cri-containerd/comments{/number}","issue_comment_url":"https://api.github.com/repos/Random-Liu/cri-containerd/issues/comments{/number}","contents_url":"https://api.github.com/repos/Random-Liu/cri-containerd/contents/{+path}","compare_url":"https://api.github.com/repos/Random-Liu/cri-containerd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Random-Liu/cri-containerd/merges","archive_url":"https://api.github.com/repos/Random-Liu/cri-containerd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Random-Liu/cri-containerd/downloads","issues_url":"https://api.github.com/repos/Random-Liu/cri-containerd/issues{/number}","pulls_url":"https://api.github.com/repos/Random-Liu/cri-containerd/pulls{/number}","milestones_url":"https://api.github.com/repos/Random-Liu/cri-containerd/milestones{/number}","notifications_url":"https://api.github.com/repos/Random-Liu/cri-containerd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Random-Liu/cri-containerd/labels{/name}","releases_url":"https://api.github.com/repos/Random-Liu/cri-containerd/releases{/id}","deployments_url":"https://api.github.com/repos/Random-Liu/cri-containerd/deployments","created_at":"2017-04-14T07:18:02Z","updated_at":"2017-08-21T22:30:18Z","pushed_at":"2017-10-27T00:11:22Z","git_url":"git://github.com/Random-Liu/cri-containerd.git","ssh_url":"git@github.com:Random-Liu/cri-containerd.git","clone_url":"https://github.com/Random-Liu/cri-containerd.git","svn_url":"https://github.com/Random-Liu/cri-containerd","homepage":"","size":6116,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes-incubator:master","ref":"master","sha":"6c6b337e876e01a4b2b2743f45090838369ba940","user":{"login":"kubernetes-incubator","id":20862812,"avatar_url":"https://avatars2.githubusercontent.com/u/20862812?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes-incubator","html_url":"https://github.com/kubernetes-incubator","followers_url":"https://api.github.com/users/kubernetes-incubator/followers","following_url":"https://api.github.com/users/kubernetes-incubator/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-incubator/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-incubator/orgs","repos_url":"https://api.github.com/users/kubernetes-incubator/repos","events_url":"https://api.github.com/users/kubernetes-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-incubator/received_events","type":"Organization","site_admin":false},"repo":{"id":88211060,"name":"cri-containerd","full_name":"kubernetes-incubator/cri-containerd","owner":{"login":"kubernetes-incubator","id":20862812,"avatar_url":"https://avatars2.githubusercontent.com/u/20862812?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes-incubator","html_url":"https://github.com/kubernetes-incubator","followers_url":"https://api.github.com/users/kubernetes-incubator/followers","following_url":"https://api.github.com/users/kubernetes-incubator/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-incubator/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-incubator/orgs","repos_url":"https://api.github.com/users/kubernetes-incubator/repos","events_url":"https://api.github.com/users/kubernetes-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-incubator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes-incubator/cri-containerd","description":"Containerd-based implementation of Kubernetes Container Runtime Interface","fork":false,"url":"https://api.github.com/repos/kubernetes-incubator/cri-containerd","forks_url":"https://api.github.com/repos/kubernetes-incubator/cri-containerd/forks","keys_url":"https://api.github.com/repos/kubernetes-incubator/cri-containerd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes-incubator/cri-containerd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes-incubator/cri-containerd/teams","hooks_url":"https://api.github.com/repos/kubernetes-incubator/cri-containerd/hooks","issue_events_url":"https://api.github.com/repos/kubernetes-incubator/cri-containerd/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes-incubator/cri-containerd/events","assignees_url":"https://api.github.com/repos/kubernetes-incubator/cri-containerd/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes-incubator/cri-containerd/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes-incubator/cri-containerd/tags","blobs_url":"https://api.github.com/repos/kubernetes-incubator/cri-containerd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes-incubator/cri-containerd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes-incubator/cri-containerd/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes-incubator/cri-containerd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes-incubator/cri-containerd/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes-incubator/cri-containerd/languages","stargazers_url":"https://api.github.com/repos/kubernetes-incubator/cri-containerd/stargazers","contributors_url":"https://api.github.com/repos/kubernetes-incubator/cri-containerd/contributors","subscribers_url":"https://api.github.com/repos/kubernetes-incubator/cri-containerd/subscribers","subscription_url":"https://api.github.com/repos/kubernetes-incubator/cri-containerd/subscription","commits_url":"https://api.github.com/repos/kubernetes-incubator/cri-containerd/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes-incubator/cri-containerd/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes-incubator/cri-containerd/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes-incubator/cri-containerd/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes-incubator/cri-containerd/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes-incubator/cri-containerd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes-incubator/cri-containerd/merges","archive_url":"https://api.github.com/repos/kubernetes-incubator/cri-containerd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes-incubator/cri-containerd/downloads","issues_url":"https://api.github.com/repos/kubernetes-incubator/cri-containerd/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes-incubator/cri-containerd/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes-incubator/cri-containerd/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes-incubator/cri-containerd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes-incubator/cri-containerd/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes-incubator/cri-containerd/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes-incubator/cri-containerd/deployments","created_at":"2017-04-13T22:20:24Z","updated_at":"2017-10-26T05:20:22Z","pushed_at":"2017-10-27T00:11:23Z","git_url":"git://github.com/kubernetes-incubator/cri-containerd.git","ssh_url":"git@github.com:kubernetes-incubator/cri-containerd.git","clone_url":"https://github.com/kubernetes-incubator/cri-containerd.git","svn_url":"https://github.com/kubernetes-incubator/cri-containerd","homepage":"","size":6054,"stargazers_count":93,"watchers_count":93,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":35,"mirror_url":null,"archived":false,"open_issues_count":44,"forks":35,"open_issues":44,"watchers":93,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes-incubator/cri-containerd/pulls/362"},"html":{"href":"https://github.com/kubernetes-incubator/cri-containerd/pull/362"},"issue":{"href":"https://api.github.com/repos/kubernetes-incubator/cri-containerd/issues/362"},"comments":{"href":"https://api.github.com/repos/kubernetes-incubator/cri-containerd/issues/362/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes-incubator/cri-containerd/pulls/362/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes-incubator/cri-containerd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes-incubator/cri-containerd/pulls/362/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes-incubator/cri-containerd/statuses/5e74cba0f0f858b1c0eb32b1a0c6e93437cc9b1f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Random-Liu"}}