{"action":"created","comment":{"url":"https://api.github.com/repos/iocage/iocage/pulls/comments/128921325","pull_request_review_id":51645449,"id":128921325,"diff_hunk":"@@ -86,6 +86,106 @@ def create_jail(self):\n             iocage.lib.ioc_destroy.IOCDestroy().destroy_jail(location)\n             sys.exit(1)\n \n+    def _get_template_config_fn(self, jail_uuid, path):\n+        config_fn = iocage.lib.ioc_json.IOCJson(path).json_get_value\n+        try:\n+            config_fn(\"cloned_release\")\n+        except (IOError, OSError, FileNotFoundError, UnboundLocalError):\n+            # Unintuitevly a missing template will throw a\n+            # UnboundLocalError as the missing file will kick the\n+            # migration routine for zfs props. We don't need that :)","path":"iocage/lib/ioc_create.py","position":11,"original_position":11,"commit_id":"c64bb647649cf79051a7f8ba931ef2c293f8b193","original_commit_id":"c64bb647649cf79051a7f8ba931ef2c293f8b193","user":{"login":"igalic","id":497249,"avatar_url":"https://avatars1.githubusercontent.com/u/497249?v=4","gravatar_id":"","url":"https://api.github.com/users/igalic","html_url":"https://github.com/igalic","followers_url":"https://api.github.com/users/igalic/followers","following_url":"https://api.github.com/users/igalic/following{/other_user}","gists_url":"https://api.github.com/users/igalic/gists{/gist_id}","starred_url":"https://api.github.com/users/igalic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igalic/subscriptions","organizations_url":"https://api.github.com/users/igalic/orgs","repos_url":"https://api.github.com/users/igalic/repos","events_url":"https://api.github.com/users/igalic/events{/privacy}","received_events_url":"https://api.github.com/users/igalic/received_events","type":"User","site_admin":false},"body":"in general, i would ***not*** expect a function called `json_get_value()` to start a zfs migration\r\nthis should probably be fixed at the source, rather than having to wrap it like this.","created_at":"2017-07-23T14:38:51Z","updated_at":"2017-07-23T14:42:58Z","html_url":"https://github.com/iocage/iocage/pull/293#discussion_r128921325","pull_request_url":"https://api.github.com/repos/iocage/iocage/pulls/293","_links":{"self":{"href":"https://api.github.com/repos/iocage/iocage/pulls/comments/128921325"},"html":{"href":"https://github.com/iocage/iocage/pull/293#discussion_r128921325"},"pull_request":{"href":"https://api.github.com/repos/iocage/iocage/pulls/293"}}},"pull_request":{"url":"https://api.github.com/repos/iocage/iocage/pulls/293","id":131246286,"html_url":"https://github.com/iocage/iocage/pull/293","diff_url":"https://github.com/iocage/iocage/pull/293.diff","patch_url":"https://github.com/iocage/iocage/pull/293.patch","issue_url":"https://api.github.com/repos/iocage/iocage/issues/293","number":293,"state":"open","locked":false,"title":"use fast returns for less indentation and easier readability","user":{"login":"igalic","id":497249,"avatar_url":"https://avatars1.githubusercontent.com/u/497249?v=4","gravatar_id":"","url":"https://api.github.com/users/igalic","html_url":"https://github.com/igalic","followers_url":"https://api.github.com/users/igalic/followers","following_url":"https://api.github.com/users/igalic/following{/other_user}","gists_url":"https://api.github.com/users/igalic/gists{/gist_id}","starred_url":"https://api.github.com/users/igalic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igalic/subscriptions","organizations_url":"https://api.github.com/users/igalic/orgs","repos_url":"https://api.github.com/users/igalic/repos","events_url":"https://api.github.com/users/igalic/events{/privacy}","received_events_url":"https://api.github.com/users/igalic/received_events","type":"User","site_admin":false},"body":"I've started cleaning up the code for readability by using the pattern\nof fast-return, to jump out of the code (often on error), so we don't\nhave to indent the main logic into the else branch.","created_at":"2017-07-19T06:32:53Z","updated_at":"2017-07-23T14:42:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"65b4ef607d2c50a4194443328d25ed03191c087b","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/iocage/iocage/pulls/293/commits","review_comments_url":"https://api.github.com/repos/iocage/iocage/pulls/293/comments","review_comment_url":"https://api.github.com/repos/iocage/iocage/pulls/comments{/number}","comments_url":"https://api.github.com/repos/iocage/iocage/issues/293/comments","statuses_url":"https://api.github.com/repos/iocage/iocage/statuses/c64bb647649cf79051a7f8ba931ef2c293f8b193","head":{"label":"igalic:fast-return","ref":"fast-return","sha":"c64bb647649cf79051a7f8ba931ef2c293f8b193","user":{"login":"igalic","id":497249,"avatar_url":"https://avatars1.githubusercontent.com/u/497249?v=4","gravatar_id":"","url":"https://api.github.com/users/igalic","html_url":"https://github.com/igalic","followers_url":"https://api.github.com/users/igalic/followers","following_url":"https://api.github.com/users/igalic/following{/other_user}","gists_url":"https://api.github.com/users/igalic/gists{/gist_id}","starred_url":"https://api.github.com/users/igalic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igalic/subscriptions","organizations_url":"https://api.github.com/users/igalic/orgs","repos_url":"https://api.github.com/users/igalic/repos","events_url":"https://api.github.com/users/igalic/events{/privacy}","received_events_url":"https://api.github.com/users/igalic/received_events","type":"User","site_admin":false},"repo":{"id":95223032,"name":"iocage","full_name":"igalic/iocage","owner":{"login":"igalic","id":497249,"avatar_url":"https://avatars1.githubusercontent.com/u/497249?v=4","gravatar_id":"","url":"https://api.github.com/users/igalic","html_url":"https://github.com/igalic","followers_url":"https://api.github.com/users/igalic/followers","following_url":"https://api.github.com/users/igalic/following{/other_user}","gists_url":"https://api.github.com/users/igalic/gists{/gist_id}","starred_url":"https://api.github.com/users/igalic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igalic/subscriptions","organizations_url":"https://api.github.com/users/igalic/orgs","repos_url":"https://api.github.com/users/igalic/repos","events_url":"https://api.github.com/users/igalic/events{/privacy}","received_events_url":"https://api.github.com/users/igalic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/igalic/iocage","description":"A FreeBSD jail manager written in Python 3","fork":true,"url":"https://api.github.com/repos/igalic/iocage","forks_url":"https://api.github.com/repos/igalic/iocage/forks","keys_url":"https://api.github.com/repos/igalic/iocage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/igalic/iocage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/igalic/iocage/teams","hooks_url":"https://api.github.com/repos/igalic/iocage/hooks","issue_events_url":"https://api.github.com/repos/igalic/iocage/issues/events{/number}","events_url":"https://api.github.com/repos/igalic/iocage/events","assignees_url":"https://api.github.com/repos/igalic/iocage/assignees{/user}","branches_url":"https://api.github.com/repos/igalic/iocage/branches{/branch}","tags_url":"https://api.github.com/repos/igalic/iocage/tags","blobs_url":"https://api.github.com/repos/igalic/iocage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/igalic/iocage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/igalic/iocage/git/refs{/sha}","trees_url":"https://api.github.com/repos/igalic/iocage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/igalic/iocage/statuses/{sha}","languages_url":"https://api.github.com/repos/igalic/iocage/languages","stargazers_url":"https://api.github.com/repos/igalic/iocage/stargazers","contributors_url":"https://api.github.com/repos/igalic/iocage/contributors","subscribers_url":"https://api.github.com/repos/igalic/iocage/subscribers","subscription_url":"https://api.github.com/repos/igalic/iocage/subscription","commits_url":"https://api.github.com/repos/igalic/iocage/commits{/sha}","git_commits_url":"https://api.github.com/repos/igalic/iocage/git/commits{/sha}","comments_url":"https://api.github.com/repos/igalic/iocage/comments{/number}","issue_comment_url":"https://api.github.com/repos/igalic/iocage/issues/comments{/number}","contents_url":"https://api.github.com/repos/igalic/iocage/contents/{+path}","compare_url":"https://api.github.com/repos/igalic/iocage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/igalic/iocage/merges","archive_url":"https://api.github.com/repos/igalic/iocage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/igalic/iocage/downloads","issues_url":"https://api.github.com/repos/igalic/iocage/issues{/number}","pulls_url":"https://api.github.com/repos/igalic/iocage/pulls{/number}","milestones_url":"https://api.github.com/repos/igalic/iocage/milestones{/number}","notifications_url":"https://api.github.com/repos/igalic/iocage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/igalic/iocage/labels{/name}","releases_url":"https://api.github.com/repos/igalic/iocage/releases{/id}","deployments_url":"https://api.github.com/repos/igalic/iocage/deployments","created_at":"2017-06-23T13:33:08Z","updated_at":"2017-06-23T13:33:10Z","pushed_at":"2017-07-23T14:32:57Z","git_url":"git://github.com/igalic/iocage.git","ssh_url":"git@github.com:igalic/iocage.git","clone_url":"https://github.com/igalic/iocage.git","svn_url":"https://github.com/igalic/iocage","homepage":"","size":1388,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"iocage:master","ref":"master","sha":"3d1ce8e7ad57cd5f48d417d3397d80a277617b38","user":{"login":"iocage","id":11825280,"avatar_url":"https://avatars1.githubusercontent.com/u/11825280?v=4","gravatar_id":"","url":"https://api.github.com/users/iocage","html_url":"https://github.com/iocage","followers_url":"https://api.github.com/users/iocage/followers","following_url":"https://api.github.com/users/iocage/following{/other_user}","gists_url":"https://api.github.com/users/iocage/gists{/gist_id}","starred_url":"https://api.github.com/users/iocage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iocage/subscriptions","organizations_url":"https://api.github.com/users/iocage/orgs","repos_url":"https://api.github.com/users/iocage/repos","events_url":"https://api.github.com/users/iocage/events{/privacy}","received_events_url":"https://api.github.com/users/iocage/received_events","type":"Organization","site_admin":false},"repo":{"id":78889373,"name":"iocage","full_name":"iocage/iocage","owner":{"login":"iocage","id":11825280,"avatar_url":"https://avatars1.githubusercontent.com/u/11825280?v=4","gravatar_id":"","url":"https://api.github.com/users/iocage","html_url":"https://github.com/iocage","followers_url":"https://api.github.com/users/iocage/followers","following_url":"https://api.github.com/users/iocage/following{/other_user}","gists_url":"https://api.github.com/users/iocage/gists{/gist_id}","starred_url":"https://api.github.com/users/iocage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iocage/subscriptions","organizations_url":"https://api.github.com/users/iocage/orgs","repos_url":"https://api.github.com/users/iocage/repos","events_url":"https://api.github.com/users/iocage/events{/privacy}","received_events_url":"https://api.github.com/users/iocage/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/iocage/iocage","description":"A FreeBSD jail manager written in Python 3","fork":false,"url":"https://api.github.com/repos/iocage/iocage","forks_url":"https://api.github.com/repos/iocage/iocage/forks","keys_url":"https://api.github.com/repos/iocage/iocage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iocage/iocage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iocage/iocage/teams","hooks_url":"https://api.github.com/repos/iocage/iocage/hooks","issue_events_url":"https://api.github.com/repos/iocage/iocage/issues/events{/number}","events_url":"https://api.github.com/repos/iocage/iocage/events","assignees_url":"https://api.github.com/repos/iocage/iocage/assignees{/user}","branches_url":"https://api.github.com/repos/iocage/iocage/branches{/branch}","tags_url":"https://api.github.com/repos/iocage/iocage/tags","blobs_url":"https://api.github.com/repos/iocage/iocage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iocage/iocage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iocage/iocage/git/refs{/sha}","trees_url":"https://api.github.com/repos/iocage/iocage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iocage/iocage/statuses/{sha}","languages_url":"https://api.github.com/repos/iocage/iocage/languages","stargazers_url":"https://api.github.com/repos/iocage/iocage/stargazers","contributors_url":"https://api.github.com/repos/iocage/iocage/contributors","subscribers_url":"https://api.github.com/repos/iocage/iocage/subscribers","subscription_url":"https://api.github.com/repos/iocage/iocage/subscription","commits_url":"https://api.github.com/repos/iocage/iocage/commits{/sha}","git_commits_url":"https://api.github.com/repos/iocage/iocage/git/commits{/sha}","comments_url":"https://api.github.com/repos/iocage/iocage/comments{/number}","issue_comment_url":"https://api.github.com/repos/iocage/iocage/issues/comments{/number}","contents_url":"https://api.github.com/repos/iocage/iocage/contents/{+path}","compare_url":"https://api.github.com/repos/iocage/iocage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iocage/iocage/merges","archive_url":"https://api.github.com/repos/iocage/iocage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iocage/iocage/downloads","issues_url":"https://api.github.com/repos/iocage/iocage/issues{/number}","pulls_url":"https://api.github.com/repos/iocage/iocage/pulls{/number}","milestones_url":"https://api.github.com/repos/iocage/iocage/milestones{/number}","notifications_url":"https://api.github.com/repos/iocage/iocage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iocage/iocage/labels{/name}","releases_url":"https://api.github.com/repos/iocage/iocage/releases{/id}","deployments_url":"https://api.github.com/repos/iocage/iocage/deployments","created_at":"2017-01-13T21:47:59Z","updated_at":"2017-07-20T07:17:56Z","pushed_at":"2017-07-23T14:32:59Z","git_url":"git://github.com/iocage/iocage.git","ssh_url":"git@github.com:iocage/iocage.git","clone_url":"https://github.com/iocage/iocage.git","svn_url":"https://github.com/iocage/iocage","homepage":"","size":1382,"stargazers_count":114,"watchers_count":114,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":27,"mirror_url":null,"open_issues_count":20,"forks":27,"open_issues":20,"watchers":114,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/iocage/iocage/pulls/293"},"html":{"href":"https://github.com/iocage/iocage/pull/293"},"issue":{"href":"https://api.github.com/repos/iocage/iocage/issues/293"},"comments":{"href":"https://api.github.com/repos/iocage/iocage/issues/293/comments"},"review_comments":{"href":"https://api.github.com/repos/iocage/iocage/pulls/293/comments"},"review_comment":{"href":"https://api.github.com/repos/iocage/iocage/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/iocage/iocage/pulls/293/commits"},"statuses":{"href":"https://api.github.com/repos/iocage/iocage/statuses/c64bb647649cf79051a7f8ba931ef2c293f8b193"}}}}
{"actor":{"display_login":"igalic"}}