{"action":"created","issue":{"url":"https://api.github.com/repos/travisgoodspeed/md380tools/issues/708","repository_url":"https://api.github.com/repos/travisgoodspeed/md380tools","labels_url":"https://api.github.com/repos/travisgoodspeed/md380tools/issues/708/labels{/name}","comments_url":"https://api.github.com/repos/travisgoodspeed/md380tools/issues/708/comments","events_url":"https://api.github.com/repos/travisgoodspeed/md380tools/issues/708/events","html_url":"https://github.com/travisgoodspeed/md380tools/pull/708","id":209959511,"number":708,"title":"added menu option to set the talkgroup","user":{"login":"bradramsey","id":17032958,"avatar_url":"https://avatars2.githubusercontent.com/u/17032958?v=3","gravatar_id":"","url":"https://api.github.com/users/bradramsey","html_url":"https://github.com/bradramsey","followers_url":"https://api.github.com/users/bradramsey/followers","following_url":"https://api.github.com/users/bradramsey/following{/other_user}","gists_url":"https://api.github.com/users/bradramsey/gists{/gist_id}","starred_url":"https://api.github.com/users/bradramsey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradramsey/subscriptions","organizations_url":"https://api.github.com/users/bradramsey/orgs","repos_url":"https://api.github.com/users/bradramsey/repos","events_url":"https://api.github.com/users/bradramsey/events{/privacy}","received_events_url":"https://api.github.com/users/bradramsey/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"travisgoodspeed","id":770671,"avatar_url":"https://avatars2.githubusercontent.com/u/770671?v=3","gravatar_id":"","url":"https://api.github.com/users/travisgoodspeed","html_url":"https://github.com/travisgoodspeed","followers_url":"https://api.github.com/users/travisgoodspeed/followers","following_url":"https://api.github.com/users/travisgoodspeed/following{/other_user}","gists_url":"https://api.github.com/users/travisgoodspeed/gists{/gist_id}","starred_url":"https://api.github.com/users/travisgoodspeed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/travisgoodspeed/subscriptions","organizations_url":"https://api.github.com/users/travisgoodspeed/orgs","repos_url":"https://api.github.com/users/travisgoodspeed/repos","events_url":"https://api.github.com/users/travisgoodspeed/events{/privacy}","received_events_url":"https://api.github.com/users/travisgoodspeed/received_events","type":"User","site_admin":false},"assignees":[{"login":"travisgoodspeed","id":770671,"avatar_url":"https://avatars2.githubusercontent.com/u/770671?v=3","gravatar_id":"","url":"https://api.github.com/users/travisgoodspeed","html_url":"https://github.com/travisgoodspeed","followers_url":"https://api.github.com/users/travisgoodspeed/followers","following_url":"https://api.github.com/users/travisgoodspeed/following{/other_user}","gists_url":"https://api.github.com/users/travisgoodspeed/gists{/gist_id}","starred_url":"https://api.github.com/users/travisgoodspeed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/travisgoodspeed/subscriptions","organizations_url":"https://api.github.com/users/travisgoodspeed/orgs","repos_url":"https://api.github.com/users/travisgoodspeed/repos","events_url":"https://api.github.com/users/travisgoodspeed/events{/privacy}","received_events_url":"https://api.github.com/users/travisgoodspeed/received_events","type":"User","site_admin":false}],"milestone":null,"comments":12,"created_at":"2017-02-24T04:50:05Z","updated_at":"2017-04-23T07:37:04Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/travisgoodspeed/md380tools/pulls/708","html_url":"https://github.com/travisgoodspeed/md380tools/pull/708","diff_url":"https://github.com/travisgoodspeed/md380tools/pull/708.diff","patch_url":"https://github.com/travisgoodspeed/md380tools/pull/708.patch"},"body":"Intent of the changes:\r\n    Allow the operator to enter an arbitrary talkgroup number, and replace the talkgroup for the current channel with the entry.  This allows arbitrary talkgroups to be joined on Brandmeister and similar repeaters.  In contrast, using the \"manual dial\" functionality in the baseline firmware's menu allows only private calls.  To join a talkgroup, the destination id must be a group id.  This modification accomplishes that.\r\n\r\nImplementation:\r\nTwo new functions in menu.c:\r\n    void create_menu_entry_set_tg_screen_store(void)\r\n    void create_menu_entry_set_tg_screen(void)\r\n\r\nThese functions add a new menu item to set the talkgroup of the current channel using numeric entry.  The code is mostly copied from the edit_dmr_id functions, but the entry is placed into the appropriate nibbles of the extern contact structure.  Writing to the appropriate tg address is accomplished using a copy of the code from the copy_dst_to_contact() function in keyb.c.\r\n\r\nThe current talkgroup is loaded into the edit buffer.  A change must be confirmed then the new talkgroup is loaded for use.\r\n\r\nI am happy to accept any comments regarding the form or function of this code.\r\n\r\nThanks for the opportunity to contribute to this project.\r\n\r\n73,\r\n\r\nK0BJR"},"comment":{"url":"https://api.github.com/repos/travisgoodspeed/md380tools/issues/comments/296425529","html_url":"https://github.com/travisgoodspeed/md380tools/pull/708#issuecomment-296425529","issue_url":"https://api.github.com/repos/travisgoodspeed/md380tools/issues/708","id":296425529,"user":{"login":"Wolf-DL4YHF","id":24916093,"avatar_url":"https://avatars0.githubusercontent.com/u/24916093?v=3","gravatar_id":"","url":"https://api.github.com/users/Wolf-DL4YHF","html_url":"https://github.com/Wolf-DL4YHF","followers_url":"https://api.github.com/users/Wolf-DL4YHF/followers","following_url":"https://api.github.com/users/Wolf-DL4YHF/following{/other_user}","gists_url":"https://api.github.com/users/Wolf-DL4YHF/gists{/gist_id}","starred_url":"https://api.github.com/users/Wolf-DL4YHF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wolf-DL4YHF/subscriptions","organizations_url":"https://api.github.com/users/Wolf-DL4YHF/orgs","repos_url":"https://api.github.com/users/Wolf-DL4YHF/repos","events_url":"https://api.github.com/users/Wolf-DL4YHF/events{/privacy}","received_events_url":"https://api.github.com/users/Wolf-DL4YHF/received_events","type":"User","site_admin":false},"created_at":"2017-04-23T07:37:03Z","updated_at":"2017-04-23T07:37:03Z","body":"Hello Brad,\n\nMaybe your TG extension is a good candidate for the new 'app menu', \nwhich is completely under our control because it uses none of the \noriginal firmware's menu- and graphics functions.\nIn other words, we can invoke that menu anytime we want, and inside it, \ncan do anything we want (navigate through lists, show menu items and \ntheir current values, edit them 'in line', or draw complete custom \nscreens). It is opened from the main screen with the red \"back\" button \n(which has no function on the original main screen). The \"Set TG\" \nfeature would be one of the first items in the new menu opened that way.\nIt still lacks support for drawing bitmaps in Tytera's format, but imho \nit's better suited (and faster) than fiddling around with Tytera's \norigninal menu.\nSince (at the moment) I am the only one familiar with this \"new\" menu \nsystem, let me first finish the method for direct alphanumeric input \n(when a menu item is in \"edit\" mode). The Set TG feature will be easy to \nuse, and faster to invoke than when buried deeply in the original menu.\n\nI will pull a merge request for it soon, even though I am still working \non the new modules (app_menu.c for the menu framework, lcd_driver.c for \nthe own, much faster LCD driver). At the moment, this is only in my own \nfork (dl4yhf/md380tools) on Github.\n\nCheers,\n   Wolf .\n\nAm 22.04.2017 um 19:12 schrieb bradramsey:\n>\n> Hello All,\n>\n> I trust that everyone is having a nice weekend. I verified that this \n> pull request, #708 \n> <https://github.com/travisgoodspeed/md380tools/pull/708> , merges fine \n> with the latest talker alias mods merged from #697 \n> <https://github.com/travisgoodspeed/md380tools/pull/697> . I'm happy \n> to address any concerns that are pending prior to merging.\n>\n> I'm still occasionally working on allowing extended menu items to be \n> called from the sidebuttons. It's a thorny issue. If anyone has \n> information on the call sequence for the built-in sidebutton menu \n> items, I'd like to learn about them. @Wolf-DL4YHF \n> <https://github.com/Wolf-DL4YHF>: I'm working on learning the \n> disassembly that you pointed me toward.\n>\n> Thanks,\n>\n> Brad\n>\n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly, view it on GitHub \n> <https://github.com/travisgoodspeed/md380tools/pull/708#issuecomment-296387769>, \n> or mute the thread \n> <https://github.com/notifications/unsubscribe-auth/AXwwfY2eqVWTMp2w0Y0NI2WMloPG8BZgks5ryjULgaJpZM4MK0yP>.\n>\n\n"}}
{"actor":{"display_login":"Wolf-DL4YHF"}}