{"action":"created","comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/132489736","pull_request_review_id":55572976,"id":132489736,"diff_hunk":"@@ -98,26 +107,44 @@ void FWFileEntry::openFile(bool checkVersion)\n       }\n    }\n \n-   // load event\n-   m_event = new fwlite::Event(m_file);\n-\n-   if (m_event->size() == 0)\n-         throw std::runtime_error(\"fwlite::Event size == 0\");\n-\n-\n    m_eventTree = dynamic_cast<TTree*>(m_file->Get(\"Events\"));\n \n    if (m_eventTree == 0)\n    { \n       throw std::runtime_error(\"Cannot find TTree 'Events' in the data file\");\n    }\n \n-   // This now set in DataHelper\n-   //TTreeCache::SetLearnEntries(2);\n-   //m_eventTree->SetCacheSize(10*1024*1024);\n-   //TTreeCache *tc = (TTreeCache*) m_file->GetCacheRead();\n-   //tc->AddBranch(m_event->auxBranch_,kTRUE);\n-   //tc->StartLearningPhase();\n+   // Initialize caching if we are accessing a remote file\n+   //if (strcmp(m_file->ClassName(), \"TNetXNGFile\") == 0)\n+   {\n+     if (FWTTreeCache::IsLogging())\n+       printf(\"FWFileEntry::openFile enabling FWTTreeCache for file class '%s'.\", m_file->ClassName());\n+\n+     auto tc = new FWTTreeCache(m_eventTree, 50*1024*1024);","path":"Fireworks/Core/src/FWFileEntry.cc","position":75,"original_position":75,"commit_id":"460e8fd230eecba8bbc677915001c689d9de1fb3","original_commit_id":"460e8fd230eecba8bbc677915001c689d9de1fb3","user":{"login":"Dr15Jones","id":3757616,"avatar_url":"https://avatars2.githubusercontent.com/u/3757616?v=4","gravatar_id":"","url":"https://api.github.com/users/Dr15Jones","html_url":"https://github.com/Dr15Jones","followers_url":"https://api.github.com/users/Dr15Jones/followers","following_url":"https://api.github.com/users/Dr15Jones/following{/other_user}","gists_url":"https://api.github.com/users/Dr15Jones/gists{/gist_id}","starred_url":"https://api.github.com/users/Dr15Jones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dr15Jones/subscriptions","organizations_url":"https://api.github.com/users/Dr15Jones/orgs","repos_url":"https://api.github.com/users/Dr15Jones/repos","events_url":"https://api.github.com/users/Dr15Jones/events{/privacy}","received_events_url":"https://api.github.com/users/Dr15Jones/received_events","type":"User","site_admin":false},"body":"Who owns the TTreeCache? Looks like it is just leaked.","created_at":"2017-08-10T15:37:25Z","updated_at":"2017-08-10T15:38:37Z","html_url":"https://github.com/cms-sw/cmssw/pull/20118#discussion_r132489736","pull_request_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/20118","_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/132489736"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/20118#discussion_r132489736"},"pull_request":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/20118"}}},"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/20118","id":135150936,"html_url":"https://github.com/cms-sw/cmssw/pull/20118","diff_url":"https://github.com/cms-sw/cmssw/pull/20118.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/20118.patch","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/20118","number":20118,"state":"open","locked":false,"title":"Enable usage of TTreeCache in Fireworks","user":{"login":"osschar","id":2625383,"avatar_url":"https://avatars3.githubusercontent.com/u/2625383?v=4","gravatar_id":"","url":"https://api.github.com/users/osschar","html_url":"https://github.com/osschar","followers_url":"https://api.github.com/users/osschar/followers","following_url":"https://api.github.com/users/osschar/following{/other_user}","gists_url":"https://api.github.com/users/osschar/gists{/gist_id}","starred_url":"https://api.github.com/users/osschar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osschar/subscriptions","organizations_url":"https://api.github.com/users/osschar/orgs","repos_url":"https://api.github.com/users/osschar/repos","events_url":"https://api.github.com/users/osschar/events{/privacy}","received_events_url":"https://api.github.com/users/osschar/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-08-10T15:14:20Z","updated_at":"2017-08-10T15:38:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"be3f7f190c95611ba441ee2e89ceca11a39ad6d4","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/66","html_url":"https://github.com/cms-sw/cmssw/milestone/66","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/66/labels","id":2497352,"number":66,"title":"CMSSW_9_2_X","description":"","creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars3.githubusercontent.com/u/4115138?v=4","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":46,"closed_issues":771,"state":"open","created_at":"2017-05-03T13:18:43Z","updated_at":"2017-08-10T15:14:35Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/20118/commits","review_comments_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/20118/comments","review_comment_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/20118/comments","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/460e8fd230eecba8bbc677915001c689d9de1fb3","head":{"label":"osschar:927-fworks-xrd","ref":"927-fworks-xrd","sha":"460e8fd230eecba8bbc677915001c689d9de1fb3","user":{"login":"osschar","id":2625383,"avatar_url":"https://avatars3.githubusercontent.com/u/2625383?v=4","gravatar_id":"","url":"https://api.github.com/users/osschar","html_url":"https://github.com/osschar","followers_url":"https://api.github.com/users/osschar/followers","following_url":"https://api.github.com/users/osschar/following{/other_user}","gists_url":"https://api.github.com/users/osschar/gists{/gist_id}","starred_url":"https://api.github.com/users/osschar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osschar/subscriptions","organizations_url":"https://api.github.com/users/osschar/orgs","repos_url":"https://api.github.com/users/osschar/repos","events_url":"https://api.github.com/users/osschar/events{/privacy}","received_events_url":"https://api.github.com/users/osschar/received_events","type":"User","site_admin":false},"repo":{"id":11344697,"name":"cmssw","full_name":"osschar/cmssw","owner":{"login":"osschar","id":2625383,"avatar_url":"https://avatars3.githubusercontent.com/u/2625383?v=4","gravatar_id":"","url":"https://api.github.com/users/osschar","html_url":"https://github.com/osschar","followers_url":"https://api.github.com/users/osschar/followers","following_url":"https://api.github.com/users/osschar/following{/other_user}","gists_url":"https://api.github.com/users/osschar/gists{/gist_id}","starred_url":"https://api.github.com/users/osschar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osschar/subscriptions","organizations_url":"https://api.github.com/users/osschar/orgs","repos_url":"https://api.github.com/users/osschar/repos","events_url":"https://api.github.com/users/osschar/events{/privacy}","received_events_url":"https://api.github.com/users/osschar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/osschar/cmssw","description":"CMS Offline Software","fork":true,"url":"https://api.github.com/repos/osschar/cmssw","forks_url":"https://api.github.com/repos/osschar/cmssw/forks","keys_url":"https://api.github.com/repos/osschar/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/osschar/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/osschar/cmssw/teams","hooks_url":"https://api.github.com/repos/osschar/cmssw/hooks","issue_events_url":"https://api.github.com/repos/osschar/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/osschar/cmssw/events","assignees_url":"https://api.github.com/repos/osschar/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/osschar/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/osschar/cmssw/tags","blobs_url":"https://api.github.com/repos/osschar/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/osschar/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/osschar/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/osschar/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/osschar/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/osschar/cmssw/languages","stargazers_url":"https://api.github.com/repos/osschar/cmssw/stargazers","contributors_url":"https://api.github.com/repos/osschar/cmssw/contributors","subscribers_url":"https://api.github.com/repos/osschar/cmssw/subscribers","subscription_url":"https://api.github.com/repos/osschar/cmssw/subscription","commits_url":"https://api.github.com/repos/osschar/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/osschar/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/osschar/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/osschar/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/osschar/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/osschar/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/osschar/cmssw/merges","archive_url":"https://api.github.com/repos/osschar/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/osschar/cmssw/downloads","issues_url":"https://api.github.com/repos/osschar/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/osschar/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/osschar/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/osschar/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/osschar/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/osschar/cmssw/releases{/id}","deployments_url":"https://api.github.com/repos/osschar/cmssw/deployments","created_at":"2013-07-11T14:54:27Z","updated_at":"2013-11-13T21:59:10Z","pushed_at":"2017-08-04T22:35:46Z","git_url":"git://github.com/osschar/cmssw.git","ssh_url":"git@github.com:osschar/cmssw.git","clone_url":"https://github.com/osschar/cmssw.git","svn_url":"https://github.com/osschar/cmssw","homepage":"cms-sw.github.io/cmssw","size":825982,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"CMSSW_7_0_X"}},"base":{"label":"cms-sw:CMSSW_9_2_X","ref":"CMSSW_9_2_X","sha":"1d79e9887de7f179ed5dfcc4e714f5da3d6e12e3","user":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars0.githubusercontent.com/u/3863500?v=4","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"repo":{"id":10969551,"name":"cmssw","full_name":"cms-sw/cmssw","owner":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars0.githubusercontent.com/u/3863500?v=4","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cms-sw/cmssw","description":"CMS Offline Software","fork":false,"url":"https://api.github.com/repos/cms-sw/cmssw","forks_url":"https://api.github.com/repos/cms-sw/cmssw/forks","keys_url":"https://api.github.com/repos/cms-sw/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cms-sw/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cms-sw/cmssw/teams","hooks_url":"https://api.github.com/repos/cms-sw/cmssw/hooks","issue_events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/cms-sw/cmssw/events","assignees_url":"https://api.github.com/repos/cms-sw/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/cms-sw/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/cms-sw/cmssw/tags","blobs_url":"https://api.github.com/repos/cms-sw/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cms-sw/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cms-sw/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/cms-sw/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/cms-sw/cmssw/languages","stargazers_url":"https://api.github.com/repos/cms-sw/cmssw/stargazers","contributors_url":"https://api.github.com/repos/cms-sw/cmssw/contributors","subscribers_url":"https://api.github.com/repos/cms-sw/cmssw/subscribers","subscription_url":"https://api.github.com/repos/cms-sw/cmssw/subscription","commits_url":"https://api.github.com/repos/cms-sw/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/cms-sw/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/cms-sw/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/cms-sw/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cms-sw/cmssw/merges","archive_url":"https://api.github.com/repos/cms-sw/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cms-sw/cmssw/downloads","issues_url":"https://api.github.com/repos/cms-sw/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/cms-sw/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/cms-sw/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/cms-sw/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cms-sw/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/cms-sw/cmssw/releases{/id}","deployments_url":"https://api.github.com/repos/cms-sw/cmssw/deployments","created_at":"2013-06-26T14:09:07Z","updated_at":"2017-08-09T01:23:52Z","pushed_at":"2017-08-10T15:15:20Z","git_url":"git://github.com/cms-sw/cmssw.git","ssh_url":"git@github.com:cms-sw/cmssw.git","clone_url":"https://github.com/cms-sw/cmssw.git","svn_url":"https://github.com/cms-sw/cmssw","homepage":"http://cms-sw.github.io/","size":964195,"stargazers_count":431,"watchers_count":431,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2289,"mirror_url":null,"open_issues_count":401,"forks":2289,"open_issues":401,"watchers":431,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/20118"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/20118"},"issue":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/20118"},"comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/20118/comments"},"review_comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/20118/comments"},"review_comment":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/20118/commits"},"statuses":{"href":"https://api.github.com/repos/cms-sw/cmssw/statuses/460e8fd230eecba8bbc677915001c689d9de1fb3"}}}}
{"actor":{"display_login":"Dr15Jones"}}