{"action":"created","issue":{"url":"https://api.github.com/repos/kwhitley/apicache/issues/108","repository_url":"https://api.github.com/repos/kwhitley/apicache","labels_url":"https://api.github.com/repos/kwhitley/apicache/issues/108/labels{/name}","comments_url":"https://api.github.com/repos/kwhitley/apicache/issues/108/comments","events_url":"https://api.github.com/repos/kwhitley/apicache/issues/108/events","html_url":"https://github.com/kwhitley/apicache/pull/108","id":252419386,"number":108,"title":"Prevent browser caching on requests that are configured to not get cached.","user":{"login":"andredigenova","id":2948899,"avatar_url":"https://avatars3.githubusercontent.com/u/2948899?v=4","gravatar_id":"","url":"https://api.github.com/users/andredigenova","html_url":"https://github.com/andredigenova","followers_url":"https://api.github.com/users/andredigenova/followers","following_url":"https://api.github.com/users/andredigenova/following{/other_user}","gists_url":"https://api.github.com/users/andredigenova/gists{/gist_id}","starred_url":"https://api.github.com/users/andredigenova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andredigenova/subscriptions","organizations_url":"https://api.github.com/users/andredigenova/orgs","repos_url":"https://api.github.com/users/andredigenova/repos","events_url":"https://api.github.com/users/andredigenova/events{/privacy}","received_events_url":"https://api.github.com/users/andredigenova/received_events","type":"User","site_admin":false},"labels":[{"id":55179215,"url":"https://api.github.com/repos/kwhitley/apicache/labels/discussion","name":"discussion","color":"cc317c","default":false},{"id":669349208,"url":"https://api.github.com/repos/kwhitley/apicache/labels/requires%20fix/resolution","name":"requires fix/resolution","color":"f9d0c4","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2017-08-23T21:17:12Z","updated_at":"2017-09-07T15:01:12Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kwhitley/apicache/pulls/108","html_url":"https://github.com/kwhitley/apicache/pull/108","diff_url":"https://github.com/kwhitley/apicache/pull/108.diff","patch_url":"https://github.com/kwhitley/apicache/pull/108.patch"},"body":"I am having an issue with the browser caching error responses even though I have configured apicache to only cache on HTTP 200.\r\n\r\nRight now a cache-control header to instruct the browser to cache the response is being sent even if apicache is configured to not cache the response.\r\n"},"comment":{"url":"https://api.github.com/repos/kwhitley/apicache/issues/comments/327826942","html_url":"https://github.com/kwhitley/apicache/pull/108#issuecomment-327826942","issue_url":"https://api.github.com/repos/kwhitley/apicache/issues/108","id":327826942,"user":{"login":"andredigenova","id":2948899,"avatar_url":"https://avatars3.githubusercontent.com/u/2948899?v=4","gravatar_id":"","url":"https://api.github.com/users/andredigenova","html_url":"https://github.com/andredigenova","followers_url":"https://api.github.com/users/andredigenova/followers","following_url":"https://api.github.com/users/andredigenova/following{/other_user}","gists_url":"https://api.github.com/users/andredigenova/gists{/gist_id}","starred_url":"https://api.github.com/users/andredigenova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andredigenova/subscriptions","organizations_url":"https://api.github.com/users/andredigenova/orgs","repos_url":"https://api.github.com/users/andredigenova/repos","events_url":"https://api.github.com/users/andredigenova/events{/privacy}","received_events_url":"https://api.github.com/users/andredigenova/received_events","type":"User","site_admin":false},"created_at":"2017-09-07T15:01:12Z","updated_at":"2017-09-07T15:01:12Z","author_association":"CONTRIBUTOR","body":"It turns out write+end does not use send to be implemented which makes sense since write+end is a lower level of abstraction. I added a test for the cache-control headers on the write-end tests and they did fail.\r\n\r\nI have moved the monkey patch from res.send to res.writeHead which appears to achieve the desire result."}}
{"actor":{"display_login":"andredigenova"}}