{"action":"created","comment":{"url":"https://api.github.com/repos/aimacode/aima-java/pulls/comments/109150960","pull_request_review_id":30235373,"id":109150960,"diff_hunk":"@@ -28,80 +29,120 @@\n  * @author manthan\n  */\n public class BidirectionalSearch<A, S> implements SearchForActionsBidirectionallyFunction<A, S> {\n-    private BidirectionalActions<A> bidirectionalActions;\n-    private List<A> fromInitialStatePartList = new ArrayList<>();\n-    private List<A> fromGoalStatePartList = new ArrayList<>();\n-    private Node<A, S> previousMeetingOfTwoFrontiers;\n-    private Node<A, S> meetingOfTwoFrontiers;\n-    private Node<A, S> nextNodeToBeEvaluated;","path":"core/src/main/java/aima/core/search/basic/uninformed/BidirectionalSearch.java","position":34,"original_position":34,"commit_id":"d81672453847ec6798ae70d9f170540aef465126","original_commit_id":"d81672453847ec6798ae70d9f170540aef465126","user":{"login":"globalworming","id":2108984,"avatar_url":"https://avatars0.githubusercontent.com/u/2108984?v=3","gravatar_id":"","url":"https://api.github.com/users/globalworming","html_url":"https://github.com/globalworming","followers_url":"https://api.github.com/users/globalworming/followers","following_url":"https://api.github.com/users/globalworming/following{/other_user}","gists_url":"https://api.github.com/users/globalworming/gists{/gist_id}","starred_url":"https://api.github.com/users/globalworming/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/globalworming/subscriptions","organizations_url":"https://api.github.com/users/globalworming/orgs","repos_url":"https://api.github.com/users/globalworming/repos","events_url":"https://api.github.com/users/globalworming/events{/privacy}","received_events_url":"https://api.github.com/users/globalworming/received_events","type":"User","site_admin":false},"body":"this was wrong on many levels. why are there Queues created when the next node is always stored in an instance variable?","created_at":"2017-03-31T12:42:23Z","updated_at":"2017-03-31T12:46:55Z","html_url":"https://github.com/aimacode/aima-java/pull/297#discussion_r109150960","pull_request_url":"https://api.github.com/repos/aimacode/aima-java/pulls/297","_links":{"self":{"href":"https://api.github.com/repos/aimacode/aima-java/pulls/comments/109150960"},"html":{"href":"https://github.com/aimacode/aima-java/pull/297#discussion_r109150960"},"pull_request":{"href":"https://api.github.com/repos/aimacode/aima-java/pulls/297"}}},"pull_request":{"url":"https://api.github.com/repos/aimacode/aima-java/pulls/297","id":113639128,"html_url":"https://github.com/aimacode/aima-java/pull/297","diff_url":"https://github.com/aimacode/aima-java/pull/297.diff","patch_url":"https://github.com/aimacode/aima-java/pull/297.patch","issue_url":"https://api.github.com/repos/aimacode/aima-java/issues/297","number":297,"state":"open","locked":false,"title":"Fix bidirectional search","user":{"login":"globalworming","id":2108984,"avatar_url":"https://avatars0.githubusercontent.com/u/2108984?v=3","gravatar_id":"","url":"https://api.github.com/users/globalworming","html_url":"https://github.com/globalworming","followers_url":"https://api.github.com/users/globalworming/followers","following_url":"https://api.github.com/users/globalworming/following{/other_user}","gists_url":"https://api.github.com/users/globalworming/gists{/gist_id}","starred_url":"https://api.github.com/users/globalworming/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/globalworming/subscriptions","organizations_url":"https://api.github.com/users/globalworming/orgs","repos_url":"https://api.github.com/users/globalworming/repos","events_url":"https://api.github.com/users/globalworming/events{/privacy}","received_events_url":"https://api.github.com/users/globalworming/received_events","type":"User","site_admin":false},"body":"smaller interface\r\nmore unittests\r\nunittests even work in corner cases @Manthan-R-Sheth \r\n","created_at":"2017-03-31T12:29:48Z","updated_at":"2017-03-31T12:46:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"887c11f821e205a20922e2d5ca39a16db83ecf7f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/aimacode/aima-java/pulls/297/commits","review_comments_url":"https://api.github.com/repos/aimacode/aima-java/pulls/297/comments","review_comment_url":"https://api.github.com/repos/aimacode/aima-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aimacode/aima-java/issues/297/comments","statuses_url":"https://api.github.com/repos/aimacode/aima-java/statuses/d81672453847ec6798ae70d9f170540aef465126","head":{"label":"globalworming:fix-bidirectional-search","ref":"fix-bidirectional-search","sha":"d81672453847ec6798ae70d9f170540aef465126","user":{"login":"globalworming","id":2108984,"avatar_url":"https://avatars0.githubusercontent.com/u/2108984?v=3","gravatar_id":"","url":"https://api.github.com/users/globalworming","html_url":"https://github.com/globalworming","followers_url":"https://api.github.com/users/globalworming/followers","following_url":"https://api.github.com/users/globalworming/following{/other_user}","gists_url":"https://api.github.com/users/globalworming/gists{/gist_id}","starred_url":"https://api.github.com/users/globalworming/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/globalworming/subscriptions","organizations_url":"https://api.github.com/users/globalworming/orgs","repos_url":"https://api.github.com/users/globalworming/repos","events_url":"https://api.github.com/users/globalworming/events{/privacy}","received_events_url":"https://api.github.com/users/globalworming/received_events","type":"User","site_admin":false},"repo":{"id":69215048,"name":"aima-java","full_name":"globalworming/aima-java","owner":{"login":"globalworming","id":2108984,"avatar_url":"https://avatars0.githubusercontent.com/u/2108984?v=3","gravatar_id":"","url":"https://api.github.com/users/globalworming","html_url":"https://github.com/globalworming","followers_url":"https://api.github.com/users/globalworming/followers","following_url":"https://api.github.com/users/globalworming/following{/other_user}","gists_url":"https://api.github.com/users/globalworming/gists{/gist_id}","starred_url":"https://api.github.com/users/globalworming/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/globalworming/subscriptions","organizations_url":"https://api.github.com/users/globalworming/orgs","repos_url":"https://api.github.com/users/globalworming/repos","events_url":"https://api.github.com/users/globalworming/events{/privacy}","received_events_url":"https://api.github.com/users/globalworming/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/globalworming/aima-java","description":"Java implementation of algorithms from Russell And Norvig's \"Artificial Intelligence - A Modern Approach\"","fork":true,"url":"https://api.github.com/repos/globalworming/aima-java","forks_url":"https://api.github.com/repos/globalworming/aima-java/forks","keys_url":"https://api.github.com/repos/globalworming/aima-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/globalworming/aima-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/globalworming/aima-java/teams","hooks_url":"https://api.github.com/repos/globalworming/aima-java/hooks","issue_events_url":"https://api.github.com/repos/globalworming/aima-java/issues/events{/number}","events_url":"https://api.github.com/repos/globalworming/aima-java/events","assignees_url":"https://api.github.com/repos/globalworming/aima-java/assignees{/user}","branches_url":"https://api.github.com/repos/globalworming/aima-java/branches{/branch}","tags_url":"https://api.github.com/repos/globalworming/aima-java/tags","blobs_url":"https://api.github.com/repos/globalworming/aima-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/globalworming/aima-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/globalworming/aima-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/globalworming/aima-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/globalworming/aima-java/statuses/{sha}","languages_url":"https://api.github.com/repos/globalworming/aima-java/languages","stargazers_url":"https://api.github.com/repos/globalworming/aima-java/stargazers","contributors_url":"https://api.github.com/repos/globalworming/aima-java/contributors","subscribers_url":"https://api.github.com/repos/globalworming/aima-java/subscribers","subscription_url":"https://api.github.com/repos/globalworming/aima-java/subscription","commits_url":"https://api.github.com/repos/globalworming/aima-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/globalworming/aima-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/globalworming/aima-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/globalworming/aima-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/globalworming/aima-java/contents/{+path}","compare_url":"https://api.github.com/repos/globalworming/aima-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/globalworming/aima-java/merges","archive_url":"https://api.github.com/repos/globalworming/aima-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/globalworming/aima-java/downloads","issues_url":"https://api.github.com/repos/globalworming/aima-java/issues{/number}","pulls_url":"https://api.github.com/repos/globalworming/aima-java/pulls{/number}","milestones_url":"https://api.github.com/repos/globalworming/aima-java/milestones{/number}","notifications_url":"https://api.github.com/repos/globalworming/aima-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/globalworming/aima-java/labels{/name}","releases_url":"https://api.github.com/repos/globalworming/aima-java/releases{/id}","deployments_url":"https://api.github.com/repos/globalworming/aima-java/deployments","created_at":"2016-09-26T05:13:37Z","updated_at":"2016-09-26T05:13:43Z","pushed_at":"2017-03-31T12:26:47Z","git_url":"git://github.com/globalworming/aima-java.git","ssh_url":"git@github.com:globalworming/aima-java.git","clone_url":"https://github.com/globalworming/aima-java.git","svn_url":"https://github.com/globalworming/aima-java","homepage":"","size":137144,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"AIMA3e"}},"base":{"label":"aimacode:AIMA4e","ref":"AIMA4e","sha":"ca900c6fbc885fe0057ba816737c7fea06b2117c","user":{"login":"aimacode","id":17015933,"avatar_url":"https://avatars1.githubusercontent.com/u/17015933?v=3","gravatar_id":"","url":"https://api.github.com/users/aimacode","html_url":"https://github.com/aimacode","followers_url":"https://api.github.com/users/aimacode/followers","following_url":"https://api.github.com/users/aimacode/following{/other_user}","gists_url":"https://api.github.com/users/aimacode/gists{/gist_id}","starred_url":"https://api.github.com/users/aimacode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aimacode/subscriptions","organizations_url":"https://api.github.com/users/aimacode/orgs","repos_url":"https://api.github.com/users/aimacode/repos","events_url":"https://api.github.com/users/aimacode/events{/privacy}","received_events_url":"https://api.github.com/users/aimacode/received_events","type":"Organization","site_admin":false},"repo":{"id":32103526,"name":"aima-java","full_name":"aimacode/aima-java","owner":{"login":"aimacode","id":17015933,"avatar_url":"https://avatars1.githubusercontent.com/u/17015933?v=3","gravatar_id":"","url":"https://api.github.com/users/aimacode","html_url":"https://github.com/aimacode","followers_url":"https://api.github.com/users/aimacode/followers","following_url":"https://api.github.com/users/aimacode/following{/other_user}","gists_url":"https://api.github.com/users/aimacode/gists{/gist_id}","starred_url":"https://api.github.com/users/aimacode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aimacode/subscriptions","organizations_url":"https://api.github.com/users/aimacode/orgs","repos_url":"https://api.github.com/users/aimacode/repos","events_url":"https://api.github.com/users/aimacode/events{/privacy}","received_events_url":"https://api.github.com/users/aimacode/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aimacode/aima-java","description":"Java implementation of algorithms from Russell And Norvig's \"Artificial Intelligence - A Modern Approach\"","fork":false,"url":"https://api.github.com/repos/aimacode/aima-java","forks_url":"https://api.github.com/repos/aimacode/aima-java/forks","keys_url":"https://api.github.com/repos/aimacode/aima-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aimacode/aima-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aimacode/aima-java/teams","hooks_url":"https://api.github.com/repos/aimacode/aima-java/hooks","issue_events_url":"https://api.github.com/repos/aimacode/aima-java/issues/events{/number}","events_url":"https://api.github.com/repos/aimacode/aima-java/events","assignees_url":"https://api.github.com/repos/aimacode/aima-java/assignees{/user}","branches_url":"https://api.github.com/repos/aimacode/aima-java/branches{/branch}","tags_url":"https://api.github.com/repos/aimacode/aima-java/tags","blobs_url":"https://api.github.com/repos/aimacode/aima-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aimacode/aima-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aimacode/aima-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/aimacode/aima-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aimacode/aima-java/statuses/{sha}","languages_url":"https://api.github.com/repos/aimacode/aima-java/languages","stargazers_url":"https://api.github.com/repos/aimacode/aima-java/stargazers","contributors_url":"https://api.github.com/repos/aimacode/aima-java/contributors","subscribers_url":"https://api.github.com/repos/aimacode/aima-java/subscribers","subscription_url":"https://api.github.com/repos/aimacode/aima-java/subscription","commits_url":"https://api.github.com/repos/aimacode/aima-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/aimacode/aima-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/aimacode/aima-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/aimacode/aima-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/aimacode/aima-java/contents/{+path}","compare_url":"https://api.github.com/repos/aimacode/aima-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aimacode/aima-java/merges","archive_url":"https://api.github.com/repos/aimacode/aima-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aimacode/aima-java/downloads","issues_url":"https://api.github.com/repos/aimacode/aima-java/issues{/number}","pulls_url":"https://api.github.com/repos/aimacode/aima-java/pulls{/number}","milestones_url":"https://api.github.com/repos/aimacode/aima-java/milestones{/number}","notifications_url":"https://api.github.com/repos/aimacode/aima-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aimacode/aima-java/labels{/name}","releases_url":"https://api.github.com/repos/aimacode/aima-java/releases{/id}","deployments_url":"https://api.github.com/repos/aimacode/aima-java/deployments","created_at":"2015-03-12T21:25:57Z","updated_at":"2017-03-31T08:10:25Z","pushed_at":"2017-03-31T12:29:48Z","git_url":"git://github.com/aimacode/aima-java.git","ssh_url":"git@github.com:aimacode/aima-java.git","clone_url":"https://github.com/aimacode/aima-java.git","svn_url":"https://github.com/aimacode/aima-java","homepage":"","size":144369,"stargazers_count":648,"watchers_count":648,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":367,"mirror_url":null,"open_issues_count":84,"forks":367,"open_issues":84,"watchers":648,"default_branch":"AIMA3e"}},"_links":{"self":{"href":"https://api.github.com/repos/aimacode/aima-java/pulls/297"},"html":{"href":"https://github.com/aimacode/aima-java/pull/297"},"issue":{"href":"https://api.github.com/repos/aimacode/aima-java/issues/297"},"comments":{"href":"https://api.github.com/repos/aimacode/aima-java/issues/297/comments"},"review_comments":{"href":"https://api.github.com/repos/aimacode/aima-java/pulls/297/comments"},"review_comment":{"href":"https://api.github.com/repos/aimacode/aima-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aimacode/aima-java/pulls/297/commits"},"statuses":{"href":"https://api.github.com/repos/aimacode/aima-java/statuses/d81672453847ec6798ae70d9f170540aef465126"}}}}
{"actor":{"display_login":"globalworming"}}