{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/vscode/issues/37610","repository_url":"https://api.github.com/repos/Microsoft/vscode","labels_url":"https://api.github.com/repos/Microsoft/vscode/issues/37610/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/vscode/issues/37610/comments","events_url":"https://api.github.com/repos/Microsoft/vscode/issues/37610/events","html_url":"https://github.com/Microsoft/vscode/issues/37610","id":271008975,"number":37610,"title":"Layer breaker in common/windows","user":{"login":"jrieken","id":1794099,"avatar_url":"https://avatars2.githubusercontent.com/u/1794099?v=4","gravatar_id":"","url":"https://api.github.com/users/jrieken","html_url":"https://github.com/jrieken","followers_url":"https://api.github.com/users/jrieken/followers","following_url":"https://api.github.com/users/jrieken/following{/other_user}","gists_url":"https://api.github.com/users/jrieken/gists{/gist_id}","starred_url":"https://api.github.com/users/jrieken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrieken/subscriptions","organizations_url":"https://api.github.com/users/jrieken/orgs","repos_url":"https://api.github.com/users/jrieken/repos","events_url":"https://api.github.com/users/jrieken/events{/privacy}","received_events_url":"https://api.github.com/users/jrieken/received_events","type":"User","site_admin":false},"labels":[{"id":296418715,"url":"https://api.github.com/repos/Microsoft/vscode/labels/debt","name":"debt","color":"708090","default":false},{"id":297952453,"url":"https://api.github.com/repos/Microsoft/vscode/labels/workbench","name":"workbench","color":"1d76db","default":false}],"state":"open","locked":false,"assignee":{"login":"joaomoreno","id":22350,"avatar_url":"https://avatars3.githubusercontent.com/u/22350?v=4","gravatar_id":"","url":"https://api.github.com/users/joaomoreno","html_url":"https://github.com/joaomoreno","followers_url":"https://api.github.com/users/joaomoreno/followers","following_url":"https://api.github.com/users/joaomoreno/following{/other_user}","gists_url":"https://api.github.com/users/joaomoreno/gists{/gist_id}","starred_url":"https://api.github.com/users/joaomoreno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joaomoreno/subscriptions","organizations_url":"https://api.github.com/users/joaomoreno/orgs","repos_url":"https://api.github.com/users/joaomoreno/repos","events_url":"https://api.github.com/users/joaomoreno/events{/privacy}","received_events_url":"https://api.github.com/users/joaomoreno/received_events","type":"User","site_admin":false},"assignees":[{"login":"joaomoreno","id":22350,"avatar_url":"https://avatars3.githubusercontent.com/u/22350?v=4","gravatar_id":"","url":"https://api.github.com/users/joaomoreno","html_url":"https://github.com/joaomoreno","followers_url":"https://api.github.com/users/joaomoreno/followers","following_url":"https://api.github.com/users/joaomoreno/following{/other_user}","gists_url":"https://api.github.com/users/joaomoreno/gists{/gist_id}","starred_url":"https://api.github.com/users/joaomoreno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joaomoreno/subscriptions","organizations_url":"https://api.github.com/users/joaomoreno/orgs","repos_url":"https://api.github.com/users/joaomoreno/repos","events_url":"https://api.github.com/users/joaomoreno/events{/privacy}","received_events_url":"https://api.github.com/users/joaomoreno/received_events","type":"User","site_admin":false},{"login":"bpasero","id":900690,"avatar_url":"https://avatars3.githubusercontent.com/u/900690?v=4","gravatar_id":"","url":"https://api.github.com/users/bpasero","html_url":"https://github.com/bpasero","followers_url":"https://api.github.com/users/bpasero/followers","following_url":"https://api.github.com/users/bpasero/following{/other_user}","gists_url":"https://api.github.com/users/bpasero/gists{/gist_id}","starred_url":"https://api.github.com/users/bpasero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bpasero/subscriptions","organizations_url":"https://api.github.com/users/bpasero/orgs","repos_url":"https://api.github.com/users/bpasero/repos","events_url":"https://api.github.com/users/bpasero/events{/privacy}","received_events_url":"https://api.github.com/users/bpasero/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2017-11-03T15:02:49Z","updated_at":"2017-11-03T15:06:25Z","closed_at":null,"author_association":"MEMBER","body":"There a few usages of `Electron` in https://github.com/Microsoft/vscode/blob/master/src/vs/platform/windows/common/windows.ts#L138 which is against our layering rules. I'd suggest to move the whole file into an `electron-browser` folder "},"comment":{"url":"https://api.github.com/repos/Microsoft/vscode/issues/comments/341730003","html_url":"https://github.com/Microsoft/vscode/issues/37610#issuecomment-341730003","issue_url":"https://api.github.com/repos/Microsoft/vscode/issues/37610","id":341730003,"user":{"login":"bpasero","id":900690,"avatar_url":"https://avatars3.githubusercontent.com/u/900690?v=4","gravatar_id":"","url":"https://api.github.com/users/bpasero","html_url":"https://github.com/bpasero","followers_url":"https://api.github.com/users/bpasero/followers","following_url":"https://api.github.com/users/bpasero/following{/other_user}","gists_url":"https://api.github.com/users/bpasero/gists{/gist_id}","starred_url":"https://api.github.com/users/bpasero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bpasero/subscriptions","organizations_url":"https://api.github.com/users/bpasero/orgs","repos_url":"https://api.github.com/users/bpasero/repos","events_url":"https://api.github.com/users/bpasero/events{/privacy}","received_events_url":"https://api.github.com/users/bpasero/received_events","type":"User","site_admin":false},"created_at":"2017-11-03T15:06:25Z","updated_at":"2017-11-03T15:06:25Z","author_association":"MEMBER","body":"Unfortunately this might not be so simple given 62 references of which some would also need to be lifted up... An alternative would be to define similar interfaces that contain the properties we actually need instead of depending on Electron."}}
{"actor":{"display_login":"bpasero"}}