{"action":"opened","issue":{"url":"https://api.github.com/repos/jaegertracing/jaeger-ui/issues/127","repository_url":"https://api.github.com/repos/jaegertracing/jaeger-ui","labels_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/issues/127/labels{/name}","comments_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/issues/127/comments","events_url":"https://api.github.com/repos/jaegertracing/jaeger-ui/issues/127/events","html_url":"https://github.com/jaegertracing/jaeger-ui/issues/127","id":276902585,"number":127,"title":"Show better error messages for failed HTTP requests","user":{"login":"tiffon","id":2304337,"avatar_url":"https://avatars0.githubusercontent.com/u/2304337?v=4","gravatar_id":"","url":"https://api.github.com/users/tiffon","html_url":"https://github.com/tiffon","followers_url":"https://api.github.com/users/tiffon/followers","following_url":"https://api.github.com/users/tiffon/following{/other_user}","gists_url":"https://api.github.com/users/tiffon/gists{/gist_id}","starred_url":"https://api.github.com/users/tiffon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiffon/subscriptions","organizations_url":"https://api.github.com/users/tiffon/orgs","repos_url":"https://api.github.com/users/tiffon/repos","events_url":"https://api.github.com/users/tiffon/events{/privacy}","received_events_url":"https://api.github.com/users/tiffon/received_events","type":"User","site_admin":false},"labels":[{"id":546183576,"url":"https://api.github.com/repos/jaegertracing/jaeger-ui/labels/bug","name":"bug","color":"ee0701","default":true}],"state":"open","locked":false,"assignee":{"login":"tiffon","id":2304337,"avatar_url":"https://avatars0.githubusercontent.com/u/2304337?v=4","gravatar_id":"","url":"https://api.github.com/users/tiffon","html_url":"https://github.com/tiffon","followers_url":"https://api.github.com/users/tiffon/followers","following_url":"https://api.github.com/users/tiffon/following{/other_user}","gists_url":"https://api.github.com/users/tiffon/gists{/gist_id}","starred_url":"https://api.github.com/users/tiffon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiffon/subscriptions","organizations_url":"https://api.github.com/users/tiffon/orgs","repos_url":"https://api.github.com/users/tiffon/repos","events_url":"https://api.github.com/users/tiffon/events{/privacy}","received_events_url":"https://api.github.com/users/tiffon/received_events","type":"User","site_admin":false},"assignees":[{"login":"tiffon","id":2304337,"avatar_url":"https://avatars0.githubusercontent.com/u/2304337?v=4","gravatar_id":"","url":"https://api.github.com/users/tiffon","html_url":"https://github.com/tiffon","followers_url":"https://api.github.com/users/tiffon/followers","following_url":"https://api.github.com/users/tiffon/following{/other_user}","gists_url":"https://api.github.com/users/tiffon/gists{/gist_id}","starred_url":"https://api.github.com/users/tiffon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiffon/subscriptions","organizations_url":"https://api.github.com/users/tiffon/orgs","repos_url":"https://api.github.com/users/tiffon/repos","events_url":"https://api.github.com/users/tiffon/events{/privacy}","received_events_url":"https://api.github.com/users/tiffon/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2017-11-27T05:08:02Z","updated_at":"2017-11-27T05:08:02Z","closed_at":null,"author_association":"COLLABORATOR","body":"\r\n\r\n## Description\r\n\r\nCurrently, failed HTTP requests trigger error messages that are ok in the case of `404`s but are useless, otherwise.\r\n\r\n## Steps to reproduce the issue:\r\n\r\n1. Try to view a trace that does not exist\r\n2. Execute a search with the tag parameter as \"a\"\r\n3. Run the UI (via checking out this repo) without a query-service running on the proxy port\r\n\r\n## Describe the results you received:\r\n\r\nStep 1 yields a `404` HTTP response and the message \"Resource not found in the Jaeger Query Service.\"\r\n\r\nStep 2 yields a `400` HTTP response and the message \"Bad JSON returned from the Jaeger Query Service.\"\r\n\r\nStep 3 yields a `500` HTTP response and the message \"Bad JSON returned from the Jaeger Query Service.\"\r\n\r\n## Describe the results you expected:\r\n\r\nThe `404` message is fine but should probably be handled in a more generic fashion.\r\n\r\nThe other responses take two forms: with JSON data describing the error and without JSON data.\r\n\r\nSeems like all error messaging should work as follows:\r\n\r\n- If there is JSON data, show the response status code and the message from the JSON data\r\n- Otherwise, show the status code and the response text\r\n- If there is no response text, show the status code and the message `An unknown error was encountered`\r\n\r\nThe only exception being the scenario described in #51, which will be addressed by that ticket.\r\n\r\n## Additional information you deem important (e.g. issue happens only occasionally):\r\n\r\nRelated issues:\r\n\r\n- jaegertracing/jaeger#418\r\n- jaegertracing/jaeger#412\r\n- jaegertracing/jaeger#401\r\n\r\n"}}
{"actor":{"display_login":"tiffon"}}