{"action":"created","comment":{"url":"https://api.github.com/repos/github/elastomer-client/pulls/comments/154090617","pull_request_review_id":80200330,"id":154090617,"diff_hunk":"@@ -224,9 +224,12 @@\n         :type            => \"completion\",\n         :analyzer        => \"simple\",\n         :search_analyzer => \"simple\",\n-        :payloads        => false\n       }\n \n+      # COMPATIBILITY\n+      # ES 5.x drops support for index-time payloads\n+      suggest[:payloads] = false if es_version_2_x?\n+","path":"test/client/index_test.rb","position":10,"original_position":10,"commit_id":"40e6a82fd616ec4efae18025d9ce2734f2b57853","original_commit_id":"40e6a82fd616ec4efae18025d9ce2734f2b57853","user":{"login":"TwP","id":6323,"avatar_url":"https://avatars0.githubusercontent.com/u/6323?v=4","gravatar_id":"","url":"https://api.github.com/users/TwP","html_url":"https://github.com/TwP","followers_url":"https://api.github.com/users/TwP/followers","following_url":"https://api.github.com/users/TwP/following{/other_user}","gists_url":"https://api.github.com/users/TwP/gists{/gist_id}","starred_url":"https://api.github.com/users/TwP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TwP/subscriptions","organizations_url":"https://api.github.com/users/TwP/orgs","repos_url":"https://api.github.com/users/TwP/repos","events_url":"https://api.github.com/users/TwP/events{/privacy}","received_events_url":"https://api.github.com/users/TwP/received_events","type":"User","site_admin":true},"body":"I very much like the `COMPATIBILITY` tag here. Making a note for myself to write up the tags we are using to annotate the codebase along with what those tags should be used for.","created_at":"2017-11-30T14:34:31Z","updated_at":"2017-11-30T14:35:07Z","html_url":"https://github.com/github/elastomer-client/pull/155#discussion_r154090617","pull_request_url":"https://api.github.com/repos/github/elastomer-client/pulls/155","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/github/elastomer-client/pulls/comments/154090617"},"html":{"href":"https://github.com/github/elastomer-client/pull/155#discussion_r154090617"},"pull_request":{"href":"https://api.github.com/repos/github/elastomer-client/pulls/155"}}},"pull_request":{"url":"https://api.github.com/repos/github/elastomer-client/pulls/155","id":155568179,"html_url":"https://github.com/github/elastomer-client/pull/155","diff_url":"https://github.com/github/elastomer-client/pull/155.diff","patch_url":"https://github.com/github/elastomer-client/pull/155.patch","issue_url":"https://api.github.com/repos/github/elastomer-client/issues/155","number":155,"state":"open","locked":false,"title":"Use `payloads` conditionally for 5.x compatibility","user":{"login":"juruen","id":11424,"avatar_url":"https://avatars3.githubusercontent.com/u/11424?v=4","gravatar_id":"","url":"https://api.github.com/users/juruen","html_url":"https://github.com/juruen","followers_url":"https://api.github.com/users/juruen/followers","following_url":"https://api.github.com/users/juruen/following{/other_user}","gists_url":"https://api.github.com/users/juruen/gists{/gist_id}","starred_url":"https://api.github.com/users/juruen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juruen/subscriptions","organizations_url":"https://api.github.com/users/juruen/orgs","repos_url":"https://api.github.com/users/juruen/repos","events_url":"https://api.github.com/users/juruen/events{/privacy}","received_events_url":"https://api.github.com/users/juruen/received_events","type":"User","site_admin":true},"body":"Use `payloads` conditionally as 5.x drops support for index-time payloads.\r\n\r\nI did it this way to keep the old behavior but maybe we could just remove `payloads` altogether for both versions?","created_at":"2017-11-30T10:20:50Z","updated_at":"2017-11-30T14:35:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"185817ae4049c149b939f08cdb9f368533462ac2","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/github/elastomer-client/pulls/155/commits","review_comments_url":"https://api.github.com/repos/github/elastomer-client/pulls/155/comments","review_comment_url":"https://api.github.com/repos/github/elastomer-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/github/elastomer-client/issues/155/comments","statuses_url":"https://api.github.com/repos/github/elastomer-client/statuses/40e6a82fd616ec4efae18025d9ce2734f2b57853","head":{"label":"github:juruen/fix-payloads","ref":"juruen/fix-payloads","sha":"40e6a82fd616ec4efae18025d9ce2734f2b57853","user":{"login":"github","id":9919,"avatar_url":"https://avatars1.githubusercontent.com/u/9919?v=4","gravatar_id":"","url":"https://api.github.com/users/github","html_url":"https://github.com/github","followers_url":"https://api.github.com/users/github/followers","following_url":"https://api.github.com/users/github/following{/other_user}","gists_url":"https://api.github.com/users/github/gists{/gist_id}","starred_url":"https://api.github.com/users/github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/github/subscriptions","organizations_url":"https://api.github.com/users/github/orgs","repos_url":"https://api.github.com/users/github/repos","events_url":"https://api.github.com/users/github/events{/privacy}","received_events_url":"https://api.github.com/users/github/received_events","type":"Organization","site_admin":false},"repo":{"id":6180360,"name":"elastomer-client","full_name":"github/elastomer-client","owner":{"login":"github","id":9919,"avatar_url":"https://avatars1.githubusercontent.com/u/9919?v=4","gravatar_id":"","url":"https://api.github.com/users/github","html_url":"https://github.com/github","followers_url":"https://api.github.com/users/github/followers","following_url":"https://api.github.com/users/github/following{/other_user}","gists_url":"https://api.github.com/users/github/gists{/gist_id}","starred_url":"https://api.github.com/users/github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/github/subscriptions","organizations_url":"https://api.github.com/users/github/orgs","repos_url":"https://api.github.com/users/github/repos","events_url":"https://api.github.com/users/github/events{/privacy}","received_events_url":"https://api.github.com/users/github/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/github/elastomer-client","description":"A library for interacting with Elasticsearch","fork":false,"url":"https://api.github.com/repos/github/elastomer-client","forks_url":"https://api.github.com/repos/github/elastomer-client/forks","keys_url":"https://api.github.com/repos/github/elastomer-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/github/elastomer-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/github/elastomer-client/teams","hooks_url":"https://api.github.com/repos/github/elastomer-client/hooks","issue_events_url":"https://api.github.com/repos/github/elastomer-client/issues/events{/number}","events_url":"https://api.github.com/repos/github/elastomer-client/events","assignees_url":"https://api.github.com/repos/github/elastomer-client/assignees{/user}","branches_url":"https://api.github.com/repos/github/elastomer-client/branches{/branch}","tags_url":"https://api.github.com/repos/github/elastomer-client/tags","blobs_url":"https://api.github.com/repos/github/elastomer-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/github/elastomer-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/github/elastomer-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/github/elastomer-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/github/elastomer-client/statuses/{sha}","languages_url":"https://api.github.com/repos/github/elastomer-client/languages","stargazers_url":"https://api.github.com/repos/github/elastomer-client/stargazers","contributors_url":"https://api.github.com/repos/github/elastomer-client/contributors","subscribers_url":"https://api.github.com/repos/github/elastomer-client/subscribers","subscription_url":"https://api.github.com/repos/github/elastomer-client/subscription","commits_url":"https://api.github.com/repos/github/elastomer-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/github/elastomer-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/github/elastomer-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/github/elastomer-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/github/elastomer-client/contents/{+path}","compare_url":"https://api.github.com/repos/github/elastomer-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/github/elastomer-client/merges","archive_url":"https://api.github.com/repos/github/elastomer-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/github/elastomer-client/downloads","issues_url":"https://api.github.com/repos/github/elastomer-client/issues{/number}","pulls_url":"https://api.github.com/repos/github/elastomer-client/pulls{/number}","milestones_url":"https://api.github.com/repos/github/elastomer-client/milestones{/number}","notifications_url":"https://api.github.com/repos/github/elastomer-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/github/elastomer-client/labels{/name}","releases_url":"https://api.github.com/repos/github/elastomer-client/releases{/id}","deployments_url":"https://api.github.com/repos/github/elastomer-client/deployments","created_at":"2012-10-11T20:33:17Z","updated_at":"2017-11-28T12:17:45Z","pushed_at":"2017-11-30T13:56:14Z","git_url":"git://github.com/github/elastomer-client.git","ssh_url":"git@github.com:github/elastomer-client.git","clone_url":"https://github.com/github/elastomer-client.git","svn_url":"https://github.com/github/elastomer-client","homepage":"","size":658,"stargazers_count":97,"watchers_count":97,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":14,"open_issues":11,"watchers":97,"default_branch":"master"}},"base":{"label":"github:master","ref":"master","sha":"3a790e3e099fac5e63f21647e0a34986bd9b58ef","user":{"login":"github","id":9919,"avatar_url":"https://avatars1.githubusercontent.com/u/9919?v=4","gravatar_id":"","url":"https://api.github.com/users/github","html_url":"https://github.com/github","followers_url":"https://api.github.com/users/github/followers","following_url":"https://api.github.com/users/github/following{/other_user}","gists_url":"https://api.github.com/users/github/gists{/gist_id}","starred_url":"https://api.github.com/users/github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/github/subscriptions","organizations_url":"https://api.github.com/users/github/orgs","repos_url":"https://api.github.com/users/github/repos","events_url":"https://api.github.com/users/github/events{/privacy}","received_events_url":"https://api.github.com/users/github/received_events","type":"Organization","site_admin":false},"repo":{"id":6180360,"name":"elastomer-client","full_name":"github/elastomer-client","owner":{"login":"github","id":9919,"avatar_url":"https://avatars1.githubusercontent.com/u/9919?v=4","gravatar_id":"","url":"https://api.github.com/users/github","html_url":"https://github.com/github","followers_url":"https://api.github.com/users/github/followers","following_url":"https://api.github.com/users/github/following{/other_user}","gists_url":"https://api.github.com/users/github/gists{/gist_id}","starred_url":"https://api.github.com/users/github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/github/subscriptions","organizations_url":"https://api.github.com/users/github/orgs","repos_url":"https://api.github.com/users/github/repos","events_url":"https://api.github.com/users/github/events{/privacy}","received_events_url":"https://api.github.com/users/github/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/github/elastomer-client","description":"A library for interacting with Elasticsearch","fork":false,"url":"https://api.github.com/repos/github/elastomer-client","forks_url":"https://api.github.com/repos/github/elastomer-client/forks","keys_url":"https://api.github.com/repos/github/elastomer-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/github/elastomer-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/github/elastomer-client/teams","hooks_url":"https://api.github.com/repos/github/elastomer-client/hooks","issue_events_url":"https://api.github.com/repos/github/elastomer-client/issues/events{/number}","events_url":"https://api.github.com/repos/github/elastomer-client/events","assignees_url":"https://api.github.com/repos/github/elastomer-client/assignees{/user}","branches_url":"https://api.github.com/repos/github/elastomer-client/branches{/branch}","tags_url":"https://api.github.com/repos/github/elastomer-client/tags","blobs_url":"https://api.github.com/repos/github/elastomer-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/github/elastomer-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/github/elastomer-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/github/elastomer-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/github/elastomer-client/statuses/{sha}","languages_url":"https://api.github.com/repos/github/elastomer-client/languages","stargazers_url":"https://api.github.com/repos/github/elastomer-client/stargazers","contributors_url":"https://api.github.com/repos/github/elastomer-client/contributors","subscribers_url":"https://api.github.com/repos/github/elastomer-client/subscribers","subscription_url":"https://api.github.com/repos/github/elastomer-client/subscription","commits_url":"https://api.github.com/repos/github/elastomer-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/github/elastomer-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/github/elastomer-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/github/elastomer-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/github/elastomer-client/contents/{+path}","compare_url":"https://api.github.com/repos/github/elastomer-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/github/elastomer-client/merges","archive_url":"https://api.github.com/repos/github/elastomer-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/github/elastomer-client/downloads","issues_url":"https://api.github.com/repos/github/elastomer-client/issues{/number}","pulls_url":"https://api.github.com/repos/github/elastomer-client/pulls{/number}","milestones_url":"https://api.github.com/repos/github/elastomer-client/milestones{/number}","notifications_url":"https://api.github.com/repos/github/elastomer-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/github/elastomer-client/labels{/name}","releases_url":"https://api.github.com/repos/github/elastomer-client/releases{/id}","deployments_url":"https://api.github.com/repos/github/elastomer-client/deployments","created_at":"2012-10-11T20:33:17Z","updated_at":"2017-11-28T12:17:45Z","pushed_at":"2017-11-30T13:56:14Z","git_url":"git://github.com/github/elastomer-client.git","ssh_url":"git@github.com:github/elastomer-client.git","clone_url":"https://github.com/github/elastomer-client.git","svn_url":"https://github.com/github/elastomer-client","homepage":"","size":658,"stargazers_count":97,"watchers_count":97,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":14,"open_issues":11,"watchers":97,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/github/elastomer-client/pulls/155"},"html":{"href":"https://github.com/github/elastomer-client/pull/155"},"issue":{"href":"https://api.github.com/repos/github/elastomer-client/issues/155"},"comments":{"href":"https://api.github.com/repos/github/elastomer-client/issues/155/comments"},"review_comments":{"href":"https://api.github.com/repos/github/elastomer-client/pulls/155/comments"},"review_comment":{"href":"https://api.github.com/repos/github/elastomer-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/github/elastomer-client/pulls/155/commits"},"statuses":{"href":"https://api.github.com/repos/github/elastomer-client/statuses/40e6a82fd616ec4efae18025d9ce2734f2b57853"}},"author_association":"NONE"}}
{"actor":{"display_login":"TwP"}}