{"action":"created","issue":{"url":"https://api.github.com/repos/geomoose/gm3/issues/225","repository_url":"https://api.github.com/repos/geomoose/gm3","labels_url":"https://api.github.com/repos/geomoose/gm3/issues/225/labels{/name}","comments_url":"https://api.github.com/repos/geomoose/gm3/issues/225/comments","events_url":"https://api.github.com/repos/geomoose/gm3/issues/225/events","html_url":"https://github.com/geomoose/gm3/issues/225","id":262266640,"number":225,"title":"GetLegendGraphic URL assembling can result in double ??","user":{"login":"tchaddad","id":1042618,"avatar_url":"https://avatars0.githubusercontent.com/u/1042618?v=4","gravatar_id":"","url":"https://api.github.com/users/tchaddad","html_url":"https://github.com/tchaddad","followers_url":"https://api.github.com/users/tchaddad/followers","following_url":"https://api.github.com/users/tchaddad/following{/other_user}","gists_url":"https://api.github.com/users/tchaddad/gists{/gist_id}","starred_url":"https://api.github.com/users/tchaddad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tchaddad/subscriptions","organizations_url":"https://api.github.com/users/tchaddad/orgs","repos_url":"https://api.github.com/users/tchaddad/repos","events_url":"https://api.github.com/users/tchaddad/events{/privacy}","received_events_url":"https://api.github.com/users/tchaddad/received_events","type":"User","site_admin":false},"labels":[{"id":357017607,"url":"https://api.github.com/repos/geomoose/gm3/labels/bug","name":"bug","color":"ee0701","default":true},{"id":619992710,"url":"https://api.github.com/repos/geomoose/gm3/labels/review-me","name":"review-me","color":"fbca04","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-10-03T00:09:27Z","updated_at":"2017-11-09T14:27:55Z","closed_at":"2017-11-09T14:27:55Z","author_association":"CONTRIBUTOR","body":"\r\nI think this line adds a '?' to the base url without checking if there is already a '?' as part of the base:\r\n\r\nhttps://github.com/geomoose/gm3/blob/e2324cd33e165036881c2d44234d1d8d14785fbc/src/gm3/components/layers/wms.js#L114\r\n\r\nThis can lead to a improperly formed URL which some servers will dislike:\r\n\r\nhttp://oregongeology.org/arcgis/services/Public/SLIDO_3_2/MapServer/WMSServer??REQUEST=GetLegendGraphic&SERVICE=WMS&VERSION=1.1.1&WIDTH=250&LAYER=0&FORMAT=image%2Fpng\r\n\r\nSame server without the double ??:\r\n\r\nhttp://oregongeology.org/arcgis/services/Public/SLIDO_3_2/MapServer/WMSServer?REQUEST=GetLegendGraphic&SERVICE=WMS&VERSION=1.1.1&WIDTH=250&LAYER=0&FORMAT=image%2Fpng\r\n"},"comment":{"url":"https://api.github.com/repos/geomoose/gm3/issues/comments/343170562","html_url":"https://github.com/geomoose/gm3/issues/225#issuecomment-343170562","issue_url":"https://api.github.com/repos/geomoose/gm3/issues/225","id":343170562,"user":{"login":"theduckylittle","id":1282291,"avatar_url":"https://avatars2.githubusercontent.com/u/1282291?v=4","gravatar_id":"","url":"https://api.github.com/users/theduckylittle","html_url":"https://github.com/theduckylittle","followers_url":"https://api.github.com/users/theduckylittle/followers","following_url":"https://api.github.com/users/theduckylittle/following{/other_user}","gists_url":"https://api.github.com/users/theduckylittle/gists{/gist_id}","starred_url":"https://api.github.com/users/theduckylittle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theduckylittle/subscriptions","organizations_url":"https://api.github.com/users/theduckylittle/orgs","repos_url":"https://api.github.com/users/theduckylittle/repos","events_url":"https://api.github.com/users/theduckylittle/events{/privacy}","received_events_url":"https://api.github.com/users/theduckylittle/received_events","type":"User","site_admin":false},"created_at":"2017-11-09T14:27:55Z","updated_at":"2017-11-09T14:27:55Z","author_association":"OWNER","body":"Just to document it here, unless someone comes up with some more stuff. GeoMoose does a lot of URL manipulation internally. And while it is technically 'legal' to specify a URL with query parameters, GeoMoose expects those query parameters to be set in `<param>` tags in the `<map-source>`. This will normalize the parsing of a `?` in the URL but will give less predictable results if folks try to do stuff like `.../wms?QUERY=CUSTOM&KEY=012345`."}}
{"actor":{"display_login":"theduckylittle"}}