{"action":"created","comment":{"url":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls/comments/112893148","pull_request_review_id":34240150,"id":112893148,"diff_hunk":"@@ -58,6 +58,23 @@ typedef struct\n   ecma_collection_header_t *reject_reactions; /**< list of PromiseRejectReactions */\n } ecma_promise_object_t;\n \n+/**\n+ * Use symbolic constant to represent the internal property name of\n+ * promise related structures.\n+ */\n+typedef enum\n+{\n+  ECMA_PROMISE_PROPERTY_PROMISE, /**< [[Promise]] property */\n+  ECMA_PROMISE_PROPERTY_RESOLVE, /**< [[Resolve]] property */\n+  ECMA_PROMISE_PROPERTY_REJECT, /**< [[Reject]] property */\n+  ECMA_PROMISE_PROPERTY_CAPABILITY, /**< [[Capability]] property */\n+  ECMA_PROMISE_PROPERTY_HANDLER, /**< [[Handler]] property */\n+  ECMA_PROMISE_PROPERTY_ALREADY_CALLED, /**< [[AlreadyCalled]] property */\n+  ECMA_PROMISE_PROPERTY_INDEX, /**< [[Index]] property */\n+  ECMA_PROMISE_PROPERTY_VALUE, /**< [[Values]] property */\n+  ECMA_PROMISE_PROPERTY_REMAINING_ELEMENT /**< [[RemainingElement]] property */","path":"jerry-core/ecma/operations/ecma-promise-object.h","position":18,"original_position":18,"commit_id":"bab33e7776147c51ce3d587c5545765744ac0e4a","original_commit_id":"6b4eb65d4c1685151a439b66221fdd0b899f33d3","user":{"login":"zherczeg","id":2270193,"avatar_url":"https://avatars1.githubusercontent.com/u/2270193?v=3","gravatar_id":"","url":"https://api.github.com/users/zherczeg","html_url":"https://github.com/zherczeg","followers_url":"https://api.github.com/users/zherczeg/followers","following_url":"https://api.github.com/users/zherczeg/following{/other_user}","gists_url":"https://api.github.com/users/zherczeg/gists{/gist_id}","starred_url":"https://api.github.com/users/zherczeg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zherczeg/subscriptions","organizations_url":"https://api.github.com/users/zherczeg/orgs","repos_url":"https://api.github.com/users/zherczeg/repos","events_url":"https://api.github.com/users/zherczeg/events{/privacy}","received_events_url":"https://api.github.com/users/zherczeg/received_events","type":"User","site_admin":false},"body":"My code. The problem with this 0,1,2,3 is that it can be changed anytime, and very hard to track all of them in the code unless there are symbolic constants and asserts in each places. They cost nothing at runtime but heavily improves maintenance.","created_at":"2017-04-24T08:47:29Z","updated_at":"2017-04-24T08:47:29Z","html_url":"https://github.com/jerryscript-project/jerryscript/pull/1729#discussion_r112893148","pull_request_url":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls/1729","_links":{"self":{"href":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls/comments/112893148"},"html":{"href":"https://github.com/jerryscript-project/jerryscript/pull/1729#discussion_r112893148"},"pull_request":{"href":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls/1729"}}},"pull_request":{"url":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls/1729","id":115562924,"html_url":"https://github.com/jerryscript-project/jerryscript/pull/1729","diff_url":"https://github.com/jerryscript-project/jerryscript/pull/1729.diff","patch_url":"https://github.com/jerryscript-project/jerryscript/pull/1729.patch","issue_url":"https://api.github.com/repos/jerryscript-project/jerryscript/issues/1729","number":1729,"state":"open","locked":false,"title":"Implement other routines of Promise","user":{"login":"jiangzidong","id":15059452,"avatar_url":"https://avatars2.githubusercontent.com/u/15059452?v=3","gravatar_id":"","url":"https://api.github.com/users/jiangzidong","html_url":"https://github.com/jiangzidong","followers_url":"https://api.github.com/users/jiangzidong/followers","following_url":"https://api.github.com/users/jiangzidong/following{/other_user}","gists_url":"https://api.github.com/users/jiangzidong/gists{/gist_id}","starred_url":"https://api.github.com/users/jiangzidong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jiangzidong/subscriptions","organizations_url":"https://api.github.com/users/jiangzidong/orgs","repos_url":"https://api.github.com/users/jiangzidong/repos","events_url":"https://api.github.com/users/jiangzidong/events{/privacy}","received_events_url":"https://api.github.com/users/jiangzidong/received_events","type":"User","site_admin":false},"body":"add Promise.resolve, Promise.reject, Promise.race, Promise.all and Promise.prototype.catch\r\n\r\nJerryScript-DCO-1.0-Signed-off-by: Zidong Jiang zidong.jiang@intel.com","created_at":"2017-04-12T14:58:19Z","updated_at":"2017-04-24T08:47:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1680f4bf68d6cb8f70b24c10505d97ad255da319","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls/1729/commits","review_comments_url":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls/1729/comments","review_comment_url":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jerryscript-project/jerryscript/issues/1729/comments","statuses_url":"https://api.github.com/repos/jerryscript-project/jerryscript/statuses/bab33e7776147c51ce3d587c5545765744ac0e4a","head":{"label":"jiangzidong:promise0412","ref":"promise0412","sha":"bab33e7776147c51ce3d587c5545765744ac0e4a","user":{"login":"jiangzidong","id":15059452,"avatar_url":"https://avatars2.githubusercontent.com/u/15059452?v=3","gravatar_id":"","url":"https://api.github.com/users/jiangzidong","html_url":"https://github.com/jiangzidong","followers_url":"https://api.github.com/users/jiangzidong/followers","following_url":"https://api.github.com/users/jiangzidong/following{/other_user}","gists_url":"https://api.github.com/users/jiangzidong/gists{/gist_id}","starred_url":"https://api.github.com/users/jiangzidong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jiangzidong/subscriptions","organizations_url":"https://api.github.com/users/jiangzidong/orgs","repos_url":"https://api.github.com/users/jiangzidong/repos","events_url":"https://api.github.com/users/jiangzidong/events{/privacy}","received_events_url":"https://api.github.com/users/jiangzidong/received_events","type":"User","site_admin":false},"repo":{"id":43999422,"name":"jerryscript","full_name":"jiangzidong/jerryscript","owner":{"login":"jiangzidong","id":15059452,"avatar_url":"https://avatars2.githubusercontent.com/u/15059452?v=3","gravatar_id":"","url":"https://api.github.com/users/jiangzidong","html_url":"https://github.com/jiangzidong","followers_url":"https://api.github.com/users/jiangzidong/followers","following_url":"https://api.github.com/users/jiangzidong/following{/other_user}","gists_url":"https://api.github.com/users/jiangzidong/gists{/gist_id}","starred_url":"https://api.github.com/users/jiangzidong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jiangzidong/subscriptions","organizations_url":"https://api.github.com/users/jiangzidong/orgs","repos_url":"https://api.github.com/users/jiangzidong/repos","events_url":"https://api.github.com/users/jiangzidong/events{/privacy}","received_events_url":"https://api.github.com/users/jiangzidong/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jiangzidong/jerryscript","description":"Ultra-lightweight JavaScript engine for Internet of Things. http://www.jerryscript.net","fork":true,"url":"https://api.github.com/repos/jiangzidong/jerryscript","forks_url":"https://api.github.com/repos/jiangzidong/jerryscript/forks","keys_url":"https://api.github.com/repos/jiangzidong/jerryscript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jiangzidong/jerryscript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jiangzidong/jerryscript/teams","hooks_url":"https://api.github.com/repos/jiangzidong/jerryscript/hooks","issue_events_url":"https://api.github.com/repos/jiangzidong/jerryscript/issues/events{/number}","events_url":"https://api.github.com/repos/jiangzidong/jerryscript/events","assignees_url":"https://api.github.com/repos/jiangzidong/jerryscript/assignees{/user}","branches_url":"https://api.github.com/repos/jiangzidong/jerryscript/branches{/branch}","tags_url":"https://api.github.com/repos/jiangzidong/jerryscript/tags","blobs_url":"https://api.github.com/repos/jiangzidong/jerryscript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jiangzidong/jerryscript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jiangzidong/jerryscript/git/refs{/sha}","trees_url":"https://api.github.com/repos/jiangzidong/jerryscript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jiangzidong/jerryscript/statuses/{sha}","languages_url":"https://api.github.com/repos/jiangzidong/jerryscript/languages","stargazers_url":"https://api.github.com/repos/jiangzidong/jerryscript/stargazers","contributors_url":"https://api.github.com/repos/jiangzidong/jerryscript/contributors","subscribers_url":"https://api.github.com/repos/jiangzidong/jerryscript/subscribers","subscription_url":"https://api.github.com/repos/jiangzidong/jerryscript/subscription","commits_url":"https://api.github.com/repos/jiangzidong/jerryscript/commits{/sha}","git_commits_url":"https://api.github.com/repos/jiangzidong/jerryscript/git/commits{/sha}","comments_url":"https://api.github.com/repos/jiangzidong/jerryscript/comments{/number}","issue_comment_url":"https://api.github.com/repos/jiangzidong/jerryscript/issues/comments{/number}","contents_url":"https://api.github.com/repos/jiangzidong/jerryscript/contents/{+path}","compare_url":"https://api.github.com/repos/jiangzidong/jerryscript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jiangzidong/jerryscript/merges","archive_url":"https://api.github.com/repos/jiangzidong/jerryscript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jiangzidong/jerryscript/downloads","issues_url":"https://api.github.com/repos/jiangzidong/jerryscript/issues{/number}","pulls_url":"https://api.github.com/repos/jiangzidong/jerryscript/pulls{/number}","milestones_url":"https://api.github.com/repos/jiangzidong/jerryscript/milestones{/number}","notifications_url":"https://api.github.com/repos/jiangzidong/jerryscript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jiangzidong/jerryscript/labels{/name}","releases_url":"https://api.github.com/repos/jiangzidong/jerryscript/releases{/id}","deployments_url":"https://api.github.com/repos/jiangzidong/jerryscript/deployments","created_at":"2015-10-10T07:17:28Z","updated_at":"2016-11-25T06:26:19Z","pushed_at":"2017-04-24T02:58:15Z","git_url":"git://github.com/jiangzidong/jerryscript.git","ssh_url":"git@github.com:jiangzidong/jerryscript.git","clone_url":"https://github.com/jiangzidong/jerryscript.git","svn_url":"https://github.com/jiangzidong/jerryscript","homepage":"","size":13048,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jerryscript-project:master","ref":"master","sha":"67c641e567dc48cc40f431cb12b45cb2205ad71e","user":{"login":"jerryscript-project","id":23194380,"avatar_url":"https://avatars2.githubusercontent.com/u/23194380?v=3","gravatar_id":"","url":"https://api.github.com/users/jerryscript-project","html_url":"https://github.com/jerryscript-project","followers_url":"https://api.github.com/users/jerryscript-project/followers","following_url":"https://api.github.com/users/jerryscript-project/following{/other_user}","gists_url":"https://api.github.com/users/jerryscript-project/gists{/gist_id}","starred_url":"https://api.github.com/users/jerryscript-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerryscript-project/subscriptions","organizations_url":"https://api.github.com/users/jerryscript-project/orgs","repos_url":"https://api.github.com/users/jerryscript-project/repos","events_url":"https://api.github.com/users/jerryscript-project/events{/privacy}","received_events_url":"https://api.github.com/users/jerryscript-project/received_events","type":"Organization","site_admin":false},"repo":{"id":33339660,"name":"jerryscript","full_name":"jerryscript-project/jerryscript","owner":{"login":"jerryscript-project","id":23194380,"avatar_url":"https://avatars2.githubusercontent.com/u/23194380?v=3","gravatar_id":"","url":"https://api.github.com/users/jerryscript-project","html_url":"https://github.com/jerryscript-project","followers_url":"https://api.github.com/users/jerryscript-project/followers","following_url":"https://api.github.com/users/jerryscript-project/following{/other_user}","gists_url":"https://api.github.com/users/jerryscript-project/gists{/gist_id}","starred_url":"https://api.github.com/users/jerryscript-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerryscript-project/subscriptions","organizations_url":"https://api.github.com/users/jerryscript-project/orgs","repos_url":"https://api.github.com/users/jerryscript-project/repos","events_url":"https://api.github.com/users/jerryscript-project/events{/privacy}","received_events_url":"https://api.github.com/users/jerryscript-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jerryscript-project/jerryscript","description":"Ultra-lightweight JavaScript engine for the Internet of Things.","fork":false,"url":"https://api.github.com/repos/jerryscript-project/jerryscript","forks_url":"https://api.github.com/repos/jerryscript-project/jerryscript/forks","keys_url":"https://api.github.com/repos/jerryscript-project/jerryscript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jerryscript-project/jerryscript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jerryscript-project/jerryscript/teams","hooks_url":"https://api.github.com/repos/jerryscript-project/jerryscript/hooks","issue_events_url":"https://api.github.com/repos/jerryscript-project/jerryscript/issues/events{/number}","events_url":"https://api.github.com/repos/jerryscript-project/jerryscript/events","assignees_url":"https://api.github.com/repos/jerryscript-project/jerryscript/assignees{/user}","branches_url":"https://api.github.com/repos/jerryscript-project/jerryscript/branches{/branch}","tags_url":"https://api.github.com/repos/jerryscript-project/jerryscript/tags","blobs_url":"https://api.github.com/repos/jerryscript-project/jerryscript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jerryscript-project/jerryscript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jerryscript-project/jerryscript/git/refs{/sha}","trees_url":"https://api.github.com/repos/jerryscript-project/jerryscript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jerryscript-project/jerryscript/statuses/{sha}","languages_url":"https://api.github.com/repos/jerryscript-project/jerryscript/languages","stargazers_url":"https://api.github.com/repos/jerryscript-project/jerryscript/stargazers","contributors_url":"https://api.github.com/repos/jerryscript-project/jerryscript/contributors","subscribers_url":"https://api.github.com/repos/jerryscript-project/jerryscript/subscribers","subscription_url":"https://api.github.com/repos/jerryscript-project/jerryscript/subscription","commits_url":"https://api.github.com/repos/jerryscript-project/jerryscript/commits{/sha}","git_commits_url":"https://api.github.com/repos/jerryscript-project/jerryscript/git/commits{/sha}","comments_url":"https://api.github.com/repos/jerryscript-project/jerryscript/comments{/number}","issue_comment_url":"https://api.github.com/repos/jerryscript-project/jerryscript/issues/comments{/number}","contents_url":"https://api.github.com/repos/jerryscript-project/jerryscript/contents/{+path}","compare_url":"https://api.github.com/repos/jerryscript-project/jerryscript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jerryscript-project/jerryscript/merges","archive_url":"https://api.github.com/repos/jerryscript-project/jerryscript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jerryscript-project/jerryscript/downloads","issues_url":"https://api.github.com/repos/jerryscript-project/jerryscript/issues{/number}","pulls_url":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls{/number}","milestones_url":"https://api.github.com/repos/jerryscript-project/jerryscript/milestones{/number}","notifications_url":"https://api.github.com/repos/jerryscript-project/jerryscript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jerryscript-project/jerryscript/labels{/name}","releases_url":"https://api.github.com/repos/jerryscript-project/jerryscript/releases{/id}","deployments_url":"https://api.github.com/repos/jerryscript-project/jerryscript/deployments","created_at":"2015-04-03T01:10:31Z","updated_at":"2017-04-21T14:50:33Z","pushed_at":"2017-04-24T08:40:25Z","git_url":"git://github.com/jerryscript-project/jerryscript.git","ssh_url":"git@github.com:jerryscript-project/jerryscript.git","clone_url":"https://github.com/jerryscript-project/jerryscript.git","svn_url":"https://github.com/jerryscript-project/jerryscript","homepage":"http://jerryscript.net","size":28595,"stargazers_count":2245,"watchers_count":2245,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":257,"mirror_url":null,"open_issues_count":37,"forks":257,"open_issues":37,"watchers":2245,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls/1729"},"html":{"href":"https://github.com/jerryscript-project/jerryscript/pull/1729"},"issue":{"href":"https://api.github.com/repos/jerryscript-project/jerryscript/issues/1729"},"comments":{"href":"https://api.github.com/repos/jerryscript-project/jerryscript/issues/1729/comments"},"review_comments":{"href":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls/1729/comments"},"review_comment":{"href":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jerryscript-project/jerryscript/pulls/1729/commits"},"statuses":{"href":"https://api.github.com/repos/jerryscript-project/jerryscript/statuses/bab33e7776147c51ce3d587c5545765744ac0e4a"}}}}
{"actor":{"display_login":"zherczeg"}}