{"action":"opened","number":723,"pull_request":{"url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/pulls/723","id":147953605,"html_url":"https://github.com/ProtocolSupport/ProtocolSupport/pull/723","diff_url":"https://github.com/ProtocolSupport/ProtocolSupport/pull/723.diff","patch_url":"https://github.com/ProtocolSupport/ProtocolSupport/pull/723.patch","issue_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/issues/723","number":723,"state":"open","locked":false,"title":"Fix UnsupportedOperationException under Paper","user":{"login":"MrPowerGamerBR","id":9496359,"avatar_url":"https://avatars3.githubusercontent.com/u/9496359?v=4","gravatar_id":"","url":"https://api.github.com/users/MrPowerGamerBR","html_url":"https://github.com/MrPowerGamerBR","followers_url":"https://api.github.com/users/MrPowerGamerBR/followers","following_url":"https://api.github.com/users/MrPowerGamerBR/following{/other_user}","gists_url":"https://api.github.com/users/MrPowerGamerBR/gists{/gist_id}","starred_url":"https://api.github.com/users/MrPowerGamerBR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrPowerGamerBR/subscriptions","organizations_url":"https://api.github.com/users/MrPowerGamerBR/orgs","repos_url":"https://api.github.com/users/MrPowerGamerBR/repos","events_url":"https://api.github.com/users/MrPowerGamerBR/events{/privacy}","received_events_url":"https://api.github.com/users/MrPowerGamerBR/received_events","type":"User","site_admin":false},"body":"🗞\r\n![https://cdn.discordapp.com/attachments/286106780189065216/371345324641484831/Screenshot_20171021-151313.png](https://cdn.discordapp.com/attachments/286106780189065216/371345324641484831/Screenshot_20171021-151313.png)\r\n\r\nSomething I did just to see if it was possible, so *maybe* the code sucks... a lot.\r\n\r\nThe reason ProtocolSupportPE's throws UnsupportedOperationException under Paper is because `trackedPlayers` is actually `trackedPlayerMap`'s keySet(), so, instead of editing `trackedPlayers` we need to edit the `trackedPlayerMap`.\r\n\r\nWe also need to set the `tracker` in the NMS Entity.\r\n\r\nTo avoid code duplication, `PaperEntityTrackerEntry` extends `SpigotEntityTrackerEntry`, that's why some of the fields/methods are now public.\r\n\r\nWhile I didn't do extensive tests, it seems there isn't any issues when spawning entities/players.\r\n\r\nOne of the reasons I don't want this to be merged yet is because now ProtocolSupportPE would be compiled against Paper, and I guess we shouldn't do that. (but I think there isn't any other alternatives)","created_at":"2017-10-21T17:21:18Z","updated_at":"2017-10-21T17:21:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/pulls/723/commits","review_comments_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/pulls/723/comments","review_comment_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/issues/723/comments","statuses_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/statuses/101963d739097e97acd260ba8ce0d87b0b49c417","head":{"label":"ProtocolSupport:mcpe/paper","ref":"mcpe/paper","sha":"101963d739097e97acd260ba8ce0d87b0b49c417","user":{"login":"ProtocolSupport","id":15771858,"avatar_url":"https://avatars2.githubusercontent.com/u/15771858?v=4","gravatar_id":"","url":"https://api.github.com/users/ProtocolSupport","html_url":"https://github.com/ProtocolSupport","followers_url":"https://api.github.com/users/ProtocolSupport/followers","following_url":"https://api.github.com/users/ProtocolSupport/following{/other_user}","gists_url":"https://api.github.com/users/ProtocolSupport/gists{/gist_id}","starred_url":"https://api.github.com/users/ProtocolSupport/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ProtocolSupport/subscriptions","organizations_url":"https://api.github.com/users/ProtocolSupport/orgs","repos_url":"https://api.github.com/users/ProtocolSupport/repos","events_url":"https://api.github.com/users/ProtocolSupport/events{/privacy}","received_events_url":"https://api.github.com/users/ProtocolSupport/received_events","type":"Organization","site_admin":false},"repo":{"id":27644576,"name":"ProtocolSupport","full_name":"ProtocolSupport/ProtocolSupport","owner":{"login":"ProtocolSupport","id":15771858,"avatar_url":"https://avatars2.githubusercontent.com/u/15771858?v=4","gravatar_id":"","url":"https://api.github.com/users/ProtocolSupport","html_url":"https://github.com/ProtocolSupport","followers_url":"https://api.github.com/users/ProtocolSupport/followers","following_url":"https://api.github.com/users/ProtocolSupport/following{/other_user}","gists_url":"https://api.github.com/users/ProtocolSupport/gists{/gist_id}","starred_url":"https://api.github.com/users/ProtocolSupport/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ProtocolSupport/subscriptions","organizations_url":"https://api.github.com/users/ProtocolSupport/orgs","repos_url":"https://api.github.com/users/ProtocolSupport/repos","events_url":"https://api.github.com/users/ProtocolSupport/events{/privacy}","received_events_url":"https://api.github.com/users/ProtocolSupport/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ProtocolSupport/ProtocolSupport","description":"Support 1.12, 1.11, 1.10.*, 1.9.*, 1.8.*, 1.7.*, 1.6.*, 1.5.*, 1.4.7 on spigot 1.12.2 and GlowStone","fork":false,"url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport","forks_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/forks","keys_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/teams","hooks_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/hooks","issue_events_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/issues/events{/number}","events_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/events","assignees_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/assignees{/user}","branches_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/branches{/branch}","tags_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/tags","blobs_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/git/refs{/sha}","trees_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/statuses/{sha}","languages_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/languages","stargazers_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/stargazers","contributors_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/contributors","subscribers_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/subscribers","subscription_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/subscription","commits_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/commits{/sha}","git_commits_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/git/commits{/sha}","comments_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/comments{/number}","issue_comment_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/issues/comments{/number}","contents_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/contents/{+path}","compare_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/merges","archive_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/downloads","issues_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/issues{/number}","pulls_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/pulls{/number}","milestones_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/milestones{/number}","notifications_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/labels{/name}","releases_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/releases{/id}","deployments_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/deployments","created_at":"2014-12-06T18:35:33Z","updated_at":"2017-10-18T04:14:50Z","pushed_at":"2017-10-21T17:15:55Z","git_url":"git://github.com/ProtocolSupport/ProtocolSupport.git","ssh_url":"git@github.com:ProtocolSupport/ProtocolSupport.git","clone_url":"https://github.com/ProtocolSupport/ProtocolSupport.git","svn_url":"https://github.com/ProtocolSupport/ProtocolSupport","homepage":"","size":8991,"stargazers_count":129,"watchers_count":129,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":93,"mirror_url":null,"archived":false,"open_issues_count":16,"forks":93,"open_issues":16,"watchers":129,"default_branch":"master"}},"base":{"label":"ProtocolSupport:mcpenew","ref":"mcpenew","sha":"3ea36623062ae6418c8b8bf2e39c4939f4e70933","user":{"login":"ProtocolSupport","id":15771858,"avatar_url":"https://avatars2.githubusercontent.com/u/15771858?v=4","gravatar_id":"","url":"https://api.github.com/users/ProtocolSupport","html_url":"https://github.com/ProtocolSupport","followers_url":"https://api.github.com/users/ProtocolSupport/followers","following_url":"https://api.github.com/users/ProtocolSupport/following{/other_user}","gists_url":"https://api.github.com/users/ProtocolSupport/gists{/gist_id}","starred_url":"https://api.github.com/users/ProtocolSupport/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ProtocolSupport/subscriptions","organizations_url":"https://api.github.com/users/ProtocolSupport/orgs","repos_url":"https://api.github.com/users/ProtocolSupport/repos","events_url":"https://api.github.com/users/ProtocolSupport/events{/privacy}","received_events_url":"https://api.github.com/users/ProtocolSupport/received_events","type":"Organization","site_admin":false},"repo":{"id":27644576,"name":"ProtocolSupport","full_name":"ProtocolSupport/ProtocolSupport","owner":{"login":"ProtocolSupport","id":15771858,"avatar_url":"https://avatars2.githubusercontent.com/u/15771858?v=4","gravatar_id":"","url":"https://api.github.com/users/ProtocolSupport","html_url":"https://github.com/ProtocolSupport","followers_url":"https://api.github.com/users/ProtocolSupport/followers","following_url":"https://api.github.com/users/ProtocolSupport/following{/other_user}","gists_url":"https://api.github.com/users/ProtocolSupport/gists{/gist_id}","starred_url":"https://api.github.com/users/ProtocolSupport/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ProtocolSupport/subscriptions","organizations_url":"https://api.github.com/users/ProtocolSupport/orgs","repos_url":"https://api.github.com/users/ProtocolSupport/repos","events_url":"https://api.github.com/users/ProtocolSupport/events{/privacy}","received_events_url":"https://api.github.com/users/ProtocolSupport/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ProtocolSupport/ProtocolSupport","description":"Support 1.12, 1.11, 1.10.*, 1.9.*, 1.8.*, 1.7.*, 1.6.*, 1.5.*, 1.4.7 on spigot 1.12.2 and GlowStone","fork":false,"url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport","forks_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/forks","keys_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/teams","hooks_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/hooks","issue_events_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/issues/events{/number}","events_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/events","assignees_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/assignees{/user}","branches_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/branches{/branch}","tags_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/tags","blobs_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/git/refs{/sha}","trees_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/statuses/{sha}","languages_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/languages","stargazers_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/stargazers","contributors_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/contributors","subscribers_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/subscribers","subscription_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/subscription","commits_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/commits{/sha}","git_commits_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/git/commits{/sha}","comments_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/comments{/number}","issue_comment_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/issues/comments{/number}","contents_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/contents/{+path}","compare_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/merges","archive_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/downloads","issues_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/issues{/number}","pulls_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/pulls{/number}","milestones_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/milestones{/number}","notifications_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/labels{/name}","releases_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/releases{/id}","deployments_url":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/deployments","created_at":"2014-12-06T18:35:33Z","updated_at":"2017-10-18T04:14:50Z","pushed_at":"2017-10-21T17:15:55Z","git_url":"git://github.com/ProtocolSupport/ProtocolSupport.git","ssh_url":"git@github.com:ProtocolSupport/ProtocolSupport.git","clone_url":"https://github.com/ProtocolSupport/ProtocolSupport.git","svn_url":"https://github.com/ProtocolSupport/ProtocolSupport","homepage":"","size":8991,"stargazers_count":129,"watchers_count":129,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":93,"mirror_url":null,"archived":false,"open_issues_count":16,"forks":93,"open_issues":16,"watchers":129,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/pulls/723"},"html":{"href":"https://github.com/ProtocolSupport/ProtocolSupport/pull/723"},"issue":{"href":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/issues/723"},"comments":{"href":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/issues/723/comments"},"review_comments":{"href":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/pulls/723/comments"},"review_comment":{"href":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/pulls/723/commits"},"statuses":{"href":"https://api.github.com/repos/ProtocolSupport/ProtocolSupport/statuses/101963d739097e97acd260ba8ce0d87b0b49c417"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":192,"deletions":7,"changed_files":8}}
{"actor":{"display_login":"MrPowerGamerBR"}}