{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/12761","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/12761/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/12761/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/12761/events","html_url":"https://github.com/nodejs/node/pull/12761","id":225330933,"number":12761,"title":"test: increase readline coverage","user":{"login":"addaleax","id":899444,"avatar_url":"https://avatars1.githubusercontent.com/u/899444?v=3","gravatar_id":"","url":"https://api.github.com/users/addaleax","html_url":"https://github.com/addaleax","followers_url":"https://api.github.com/users/addaleax/followers","following_url":"https://api.github.com/users/addaleax/following{/other_user}","gists_url":"https://api.github.com/users/addaleax/gists{/gist_id}","starred_url":"https://api.github.com/users/addaleax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/addaleax/subscriptions","organizations_url":"https://api.github.com/users/addaleax/orgs","repos_url":"https://api.github.com/users/addaleax/repos","events_url":"https://api.github.com/users/addaleax/events{/privacy}","received_events_url":"https://api.github.com/users/addaleax/received_events","type":"User","site_admin":false},"labels":[{"id":155435874,"url":"https://api.github.com/repos/nodejs/node/labels/readline","name":"readline","color":"d4c5f9","default":false},{"id":176240519,"url":"https://api.github.com/repos/nodejs/node/labels/test","name":"test","color":"990099","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-04-30T14:35:12Z","updated_at":"2017-04-30T23:07:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/12761","html_url":"https://github.com/nodejs/node/pull/12761","diff_url":"https://github.com/nodejs/node/pull/12761.diff","patch_url":"https://github.com/nodejs/node/pull/12761.patch"},"body":"<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-guidelines)\r\n\r\n##### Affected core subsystem(s)\r\n\r\ntest, readine"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/298263402","html_url":"https://github.com/nodejs/node/pull/12761#issuecomment-298263402","issue_url":"https://api.github.com/repos/nodejs/node/issues/12761","id":298263402,"user":{"login":"addaleax","id":899444,"avatar_url":"https://avatars1.githubusercontent.com/u/899444?v=3","gravatar_id":"","url":"https://api.github.com/users/addaleax","html_url":"https://github.com/addaleax","followers_url":"https://api.github.com/users/addaleax/followers","following_url":"https://api.github.com/users/addaleax/following{/other_user}","gists_url":"https://api.github.com/users/addaleax/gists{/gist_id}","starred_url":"https://api.github.com/users/addaleax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/addaleax/subscriptions","organizations_url":"https://api.github.com/users/addaleax/orgs","repos_url":"https://api.github.com/users/addaleax/repos","events_url":"https://api.github.com/users/addaleax/events{/privacy}","received_events_url":"https://api.github.com/users/addaleax/received_events","type":"User","site_admin":false},"created_at":"2017-04-30T23:07:20Z","updated_at":"2017-04-30T23:07:20Z","body":"@ChALkeR In theory, I could run `make coverage` locally before/after this change, and for readline there’s a good chance it would give results comparable to the ones generated by CI.\r\n\r\nRunning `make coverage` is still a bit of a hustle, though, and also I had these changes lying around for a few days so I don’t actually remember which uncovered lines these cover… Originally I wanted to add more test cases here, but since that didn’t happen, I thought I might as well just open a PR now."}}
{"actor":{"display_login":"addaleax"}}