{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/pulls/comments/105073667","pull_request_review_id":25935480,"id":105073667,"diff_hunk":"@@ -124,7 +124,7 @@ public Task SaveAndCloseAsync(FunctionInstanceLogEntry item, CancellationToken c\n                     {                        \n                         // 0123456789\n                         // abcdefghij\n-                        str = \"...\" + str.Substring(str.Length - (FunctionInstanceLogEntry.MaxLogOutputLength - 3));\n+                        str = str.Substring(0, FunctionInstanceLogEntry.MaxLogOutputLength - 1) + \"…\";","path":"src/Microsoft.Azure.WebJobs.Host/Loggers/FastTableLoggerProvider.cs","position":5,"original_position":5,"commit_id":"259923e19f530572d5a4075aae717e7b4f9f44b5","original_commit_id":"259923e19f530572d5a4075aae717e7b4f9f44b5","user":{"login":"fabiocav","id":2507935,"avatar_url":"https://avatars1.githubusercontent.com/u/2507935?v=3","gravatar_id":"","url":"https://api.github.com/users/fabiocav","html_url":"https://github.com/fabiocav","followers_url":"https://api.github.com/users/fabiocav/followers","following_url":"https://api.github.com/users/fabiocav/following{/other_user}","gists_url":"https://api.github.com/users/fabiocav/gists{/gist_id}","starred_url":"https://api.github.com/users/fabiocav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabiocav/subscriptions","organizations_url":"https://api.github.com/users/fabiocav/orgs","repos_url":"https://api.github.com/users/fabiocav/repos","events_url":"https://api.github.com/users/fabiocav/events{/privacy}","received_events_url":"https://api.github.com/users/fabiocav/received_events","type":"User","site_admin":false},"body":"Minor change, but moved from using `...` to using `…`","created_at":"2017-03-09T02:15:16Z","updated_at":"2017-03-09T02:15:16Z","html_url":"https://github.com/Azure/azure-webjobs-sdk/pull/1051#discussion_r105073667","pull_request_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/pulls/1051","_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-webjobs-sdk/pulls/comments/105073667"},"html":{"href":"https://github.com/Azure/azure-webjobs-sdk/pull/1051#discussion_r105073667"},"pull_request":{"href":"https://api.github.com/repos/Azure/azure-webjobs-sdk/pulls/1051"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/pulls/1051","id":109826668,"html_url":"https://github.com/Azure/azure-webjobs-sdk/pull/1051","diff_url":"https://github.com/Azure/azure-webjobs-sdk/pull/1051.diff","patch_url":"https://github.com/Azure/azure-webjobs-sdk/pull/1051.patch","issue_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/issues/1051","number":1051,"state":"open","locked":false,"title":"Sanitizing stack traces to improve readability","user":{"login":"fabiocav","id":2507935,"avatar_url":"https://avatars1.githubusercontent.com/u/2507935?v=3","gravatar_id":"","url":"https://api.github.com/users/fabiocav","html_url":"https://github.com/fabiocav","followers_url":"https://api.github.com/users/fabiocav/followers","following_url":"https://api.github.com/users/fabiocav/following{/other_user}","gists_url":"https://api.github.com/users/fabiocav/gists{/gist_id}","starred_url":"https://api.github.com/users/fabiocav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabiocav/subscriptions","organizations_url":"https://api.github.com/users/fabiocav/orgs","repos_url":"https://api.github.com/users/fabiocav/repos","events_url":"https://api.github.com/users/fabiocav/events{/privacy}","received_events_url":"https://api.github.com/users/fabiocav/received_events","type":"User","site_admin":false},"body":"There are two goals with this PR:\r\n\r\n### Improve readability of exception messages/stack traces \r\nThis is particularly problematic for Azure Functions users. With this changes, we are sanitizing the exception stack trace prior to logging to:\r\n\r\n1. Remove async state machine frames (this causes a significant amount of noise)\r\n2. Convert the compiler generated state machine code to the appropriate async method name and marking it with `async`\r\n3. Show async method arguments when possible\r\n4. Properly formatting `AggregateExceptions` and the associated inner exceptions\r\n\r\n### Avoid losing important stack information in logs\r\n\r\nChanged the log truncation strategy to preserve the top of the stack as, in most customer cases, the top frames contain the relevant information and exception details. This issue is also mitigated by the change to sanitize messages as much less information is lost due to truncation.\r\n","created_at":"2017-03-09T02:12:11Z","updated_at":"2017-03-09T02:15:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"65268c0df008ff5a4195ce54fb9dd59a65a1b1f9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/pulls/1051/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/pulls/1051/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/issues/1051/comments","statuses_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/statuses/259923e19f530572d5a4075aae717e7b4f9f44b5","head":{"label":"fabiocav:excformat","ref":"excformat","sha":"259923e19f530572d5a4075aae717e7b4f9f44b5","user":{"login":"fabiocav","id":2507935,"avatar_url":"https://avatars1.githubusercontent.com/u/2507935?v=3","gravatar_id":"","url":"https://api.github.com/users/fabiocav","html_url":"https://github.com/fabiocav","followers_url":"https://api.github.com/users/fabiocav/followers","following_url":"https://api.github.com/users/fabiocav/following{/other_user}","gists_url":"https://api.github.com/users/fabiocav/gists{/gist_id}","starred_url":"https://api.github.com/users/fabiocav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabiocav/subscriptions","organizations_url":"https://api.github.com/users/fabiocav/orgs","repos_url":"https://api.github.com/users/fabiocav/repos","events_url":"https://api.github.com/users/fabiocav/events{/privacy}","received_events_url":"https://api.github.com/users/fabiocav/received_events","type":"User","site_admin":false},"repo":{"id":48339473,"name":"azure-webjobs-sdk","full_name":"fabiocav/azure-webjobs-sdk","owner":{"login":"fabiocav","id":2507935,"avatar_url":"https://avatars1.githubusercontent.com/u/2507935?v=3","gravatar_id":"","url":"https://api.github.com/users/fabiocav","html_url":"https://github.com/fabiocav","followers_url":"https://api.github.com/users/fabiocav/followers","following_url":"https://api.github.com/users/fabiocav/following{/other_user}","gists_url":"https://api.github.com/users/fabiocav/gists{/gist_id}","starred_url":"https://api.github.com/users/fabiocav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabiocav/subscriptions","organizations_url":"https://api.github.com/users/fabiocav/orgs","repos_url":"https://api.github.com/users/fabiocav/repos","events_url":"https://api.github.com/users/fabiocav/events{/privacy}","received_events_url":"https://api.github.com/users/fabiocav/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fabiocav/azure-webjobs-sdk","description":"Azure WebJobs SDK","fork":true,"url":"https://api.github.com/repos/fabiocav/azure-webjobs-sdk","forks_url":"https://api.github.com/repos/fabiocav/azure-webjobs-sdk/forks","keys_url":"https://api.github.com/repos/fabiocav/azure-webjobs-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fabiocav/azure-webjobs-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fabiocav/azure-webjobs-sdk/teams","hooks_url":"https://api.github.com/repos/fabiocav/azure-webjobs-sdk/hooks","issue_events_url":"https://api.github.com/repos/fabiocav/azure-webjobs-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/fabiocav/azure-webjobs-sdk/events","assignees_url":"https://api.github.com/repos/fabiocav/azure-webjobs-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/fabiocav/azure-webjobs-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/fabiocav/azure-webjobs-sdk/tags","blobs_url":"https://api.github.com/repos/fabiocav/azure-webjobs-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fabiocav/azure-webjobs-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fabiocav/azure-webjobs-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/fabiocav/azure-webjobs-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fabiocav/azure-webjobs-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/fabiocav/azure-webjobs-sdk/languages","stargazers_url":"https://api.github.com/repos/fabiocav/azure-webjobs-sdk/stargazers","contributors_url":"https://api.github.com/repos/fabiocav/azure-webjobs-sdk/contributors","subscribers_url":"https://api.github.com/repos/fabiocav/azure-webjobs-sdk/subscribers","subscription_url":"https://api.github.com/repos/fabiocav/azure-webjobs-sdk/subscription","commits_url":"https://api.github.com/repos/fabiocav/azure-webjobs-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/fabiocav/azure-webjobs-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/fabiocav/azure-webjobs-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/fabiocav/azure-webjobs-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/fabiocav/azure-webjobs-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/fabiocav/azure-webjobs-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fabiocav/azure-webjobs-sdk/merges","archive_url":"https://api.github.com/repos/fabiocav/azure-webjobs-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fabiocav/azure-webjobs-sdk/downloads","issues_url":"https://api.github.com/repos/fabiocav/azure-webjobs-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/fabiocav/azure-webjobs-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/fabiocav/azure-webjobs-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/fabiocav/azure-webjobs-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fabiocav/azure-webjobs-sdk/labels{/name}","releases_url":"https://api.github.com/repos/fabiocav/azure-webjobs-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/fabiocav/azure-webjobs-sdk/deployments","created_at":"2015-12-20T22:27:16Z","updated_at":"2016-07-26T18:29:47Z","pushed_at":"2017-03-09T02:01:08Z","git_url":"git://github.com/fabiocav/azure-webjobs-sdk.git","ssh_url":"git@github.com:fabiocav/azure-webjobs-sdk.git","clone_url":"https://github.com/fabiocav/azure-webjobs-sdk.git","svn_url":"https://github.com/fabiocav/azure-webjobs-sdk","homepage":"","size":12496,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:dev","ref":"dev","sha":"ddcd030fc908a479f6fb0195b4a4bb49ef750ed5","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars3.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":21712185,"name":"azure-webjobs-sdk","full_name":"Azure/azure-webjobs-sdk","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars3.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/azure-webjobs-sdk","description":"Azure WebJobs SDK","fork":false,"url":"https://api.github.com/repos/Azure/azure-webjobs-sdk","forks_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/forks","keys_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/teams","hooks_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/events","assignees_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/tags","blobs_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/subscription","commits_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/merges","archive_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/downloads","issues_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-webjobs-sdk/deployments","created_at":"2014-07-10T22:15:31Z","updated_at":"2017-03-06T01:30:37Z","pushed_at":"2017-03-09T02:12:11Z","git_url":"git://github.com/Azure/azure-webjobs-sdk.git","ssh_url":"git@github.com:Azure/azure-webjobs-sdk.git","clone_url":"https://github.com/Azure/azure-webjobs-sdk.git","svn_url":"https://github.com/Azure/azure-webjobs-sdk","homepage":"","size":12672,"stargazers_count":181,"watchers_count":181,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":86,"mirror_url":null,"open_issues_count":236,"forks":86,"open_issues":236,"watchers":181,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-webjobs-sdk/pulls/1051"},"html":{"href":"https://github.com/Azure/azure-webjobs-sdk/pull/1051"},"issue":{"href":"https://api.github.com/repos/Azure/azure-webjobs-sdk/issues/1051"},"comments":{"href":"https://api.github.com/repos/Azure/azure-webjobs-sdk/issues/1051/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-webjobs-sdk/pulls/1051/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-webjobs-sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-webjobs-sdk/pulls/1051/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-webjobs-sdk/statuses/259923e19f530572d5a4075aae717e7b4f9f44b5"}}}}
{"actor":{"display_login":"fabiocav"}}