{"action":"created","comment":{"url":"https://api.github.com/repos/Linaro/odp/pulls/comments/148085959","pull_request_review_id":73272521,"id":148085959,"diff_hunk":"@@ -1,157 +0,0 @@\n-/* Copyright (c) 2013, Linaro Limited\n- * All rights reserved.\n- *\n- * SPDX-License-Identifier:     BSD-3-Clause\n- */\n-\n-/**\n- * @file\n- *\n- * ODP packet IO - implementation internal\n- */\n-\n-#ifndef ODP_PACKET_IO_INTERNAL_H_\n-#define ODP_PACKET_IO_INTERNAL_H_\n-\n-#ifdef __cplusplus\n-extern \"C\" {\n-#endif\n-\n-#include <odp/api/spinlock.h>\n-#include <odp/api/ticketlock.h>\n-#include <odp_classification_datamodel.h>\n-#include <odp_align_internal.h>\n-#include <odp_debug_internal.h>\n-#include <odp_queue_if.h>\n-\n-#include <odp_config_internal.h>\n-#include <odp/api/hints.h>\n-\n-#define PKTIO_MAX_QUEUES 64\n-#include <linux/if_ether.h>\n-\n-/* Forward declaration */\n-typedef union pktio_entry_u pktio_entry_t;\n-#include <odp_pktio_ops_subsystem.h>\n-\n-#define PKTIO_NAME_LEN 256\n-\n-#define PKTIN_INVALID  ((odp_pktin_queue_t) {ODP_PKTIO_INVALID, 0})\n-#define PKTOUT_INVALID ((odp_pktout_queue_t) {ODP_PKTIO_INVALID, 0})\n-\n-struct pktio_entry {\n-\tconst pktio_ops_module_t *ops;\t/**< Implementation specific methods */\n-\tuint8_t ops_data[ODP_PKTIO_ODPS_DATA_MAX_SIZE]; /**< IO operation\n-\t\t\t\t\t\t\tspecific data */\n-\t/* These two locks together lock the whole pktio device */\n-\todp_ticketlock_t rxl;\t\t/**< RX ticketlock */\n-\todp_ticketlock_t txl;\t\t/**< TX ticketlock */\n-\tint cls_enabled;\t\t/**< is classifier enabled */\n-\todp_pktio_t handle;\t\t/**< pktio handle */\n-\tenum {\n-\t\t/* Not allocated */\n-\t\tPKTIO_STATE_FREE = 0,\n-\t\t/* Close pending on scheduler response. Next state after this\n-\t\t * is PKTIO_STATE_FREE. */\n-\t\tPKTIO_STATE_CLOSE_PENDING,\n-\t\t/* Open in progress.\n-\t\t   Marker for all active states following under. */\n-\t\tPKTIO_STATE_ACTIVE,\n-\t\t/* Open completed */\n-\t\tPKTIO_STATE_OPENED,\n-\t\t/* Start completed */\n-\t\tPKTIO_STATE_STARTED,\n-\t\t/* Stop pending on scheduler response */\n-\t\tPKTIO_STATE_STOP_PENDING,\n-\t\t/* Stop completed */\n-\t\tPKTIO_STATE_STOPPED\n-\t} state;\n-\todp_pktio_config_t config;\t/**< Device configuration */\n-\tclassifier_t cls;\t\t/**< classifier linked with this pktio*/\n-\todp_pktio_stats_t stats;\t/**< statistic counters for pktio */\n-\tchar name[PKTIO_NAME_LEN];\t/**< name of pktio provided to\n-\t\t\t\t\t   pktio_open() */\n-\todp_pool_t pool;\n-\todp_pktio_param_t param;\n-\n-\t/* Storage for queue handles\n-\t * Multi-queue support is pktio driver specific */\n-\tunsigned num_in_queue;\n-\tunsigned num_out_queue;\n-\n-\tstruct {\n-\t\todp_queue_t        queue;\n-\t\tqueue_t            queue_int;\n-\t\todp_pktin_queue_t  pktin;\n-\t} in_queue[PKTIO_MAX_QUEUES];\n-\n-\tstruct {\n-\t\todp_queue_t        queue;\n-\t\todp_pktout_queue_t pktout;\n-\t} out_queue[PKTIO_MAX_QUEUES];\n-};\n-\n-union pktio_entry_u {\n-\tstruct pktio_entry s;\n-\tuint8_t pad[ROUNDUP_CACHE_LINE(sizeof(struct pktio_entry))];\n-};\n-\n-typedef struct {\n-\todp_spinlock_t lock;\n-\tpktio_entry_t entries[ODP_CONFIG_PKTIO_ENTRIES];\n-} pktio_table_t;\n-\n-extern void *pktio_entry_ptr[];\n-\n-static inline int pktio_to_id(odp_pktio_t pktio)\n-{\n-\treturn _odp_typeval(pktio) - 1;\n-}\n-\n-static inline pktio_entry_t *get_pktio_entry(odp_pktio_t pktio)\n-{\n-\tif (odp_unlikely(pktio == ODP_PKTIO_INVALID))\n-\t\treturn NULL;\n-\n-\tif (odp_unlikely(_odp_typeval(pktio) > ODP_CONFIG_PKTIO_ENTRIES)) {\n-\t\tODP_DBG(\"pktio limit %d/%d exceed\\n\",\n-\t\t\t_odp_typeval(pktio), ODP_CONFIG_PKTIO_ENTRIES);\n-\t\treturn NULL;\n-\t}\n-\n-\treturn pktio_entry_ptr[pktio_to_id(pktio)];\n-}\n-\n-static inline int pktio_cls_enabled(pktio_entry_t *entry)\n-{\n-\treturn entry->s.cls_enabled;\n-}\n-\n-static inline void pktio_cls_enabled_set(pktio_entry_t *entry, int ena)\n-{\n-\tentry->s.cls_enabled = ena;\n-}\n-\n-/*\n- * Dummy single queue implementations of multi-queue API\n- */\n-int single_input_queues_config(pktio_entry_t *entry,\n-\t\t\t       const odp_pktin_queue_param_t *param);\n-int single_output_queues_config(pktio_entry_t *entry,\n-\t\t\t\tconst odp_pktout_queue_param_t *param);\n-int single_recv_queue(pktio_entry_t *entry, int index, odp_packet_t packets[],\n-\t\t      int num);\n-int single_send_queue(pktio_entry_t *entry, int index,\n-\t\t      const odp_packet_t packets[], int num);\n-\n-int pktin_poll_one(int pktio_index,\n-\t\t   int rx_queue,\n-\t\t   odp_event_t evt_tbl[]);\n-int pktin_poll(int pktio_index, int num_queue, int index[]);\n-void pktio_stop_finalize(int pktio_index);\n-\n-#ifdef __cplusplus\n-}\n-#endif\n-\n-#endif","path":"platform/linux-dpdk/include/odp_packet_io_internal.h","position":157,"original_position":157,"commit_id":"187cf1f28f8f5f28b36fdb429b0770f4febc3ac3","original_commit_id":"187cf1f28f8f5f28b36fdb429b0770f4febc3ac3","user":{"login":"nagarahalli","id":28901321,"avatar_url":"https://avatars0.githubusercontent.com/u/28901321?v=4","gravatar_id":"","url":"https://api.github.com/users/nagarahalli","html_url":"https://github.com/nagarahalli","followers_url":"https://api.github.com/users/nagarahalli/followers","following_url":"https://api.github.com/users/nagarahalli/following{/other_user}","gists_url":"https://api.github.com/users/nagarahalli/gists{/gist_id}","starred_url":"https://api.github.com/users/nagarahalli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nagarahalli/subscriptions","organizations_url":"https://api.github.com/users/nagarahalli/orgs","repos_url":"https://api.github.com/users/nagarahalli/repos","events_url":"https://api.github.com/users/nagarahalli/events{/privacy}","received_events_url":"https://api.github.com/users/nagarahalli/received_events","type":"User","site_admin":false},"body":"Agree. I understand the change. But it will help everyone if we have explanation in the commit log.","created_at":"2017-10-31T18:25:16Z","updated_at":"2017-10-31T18:26:34Z","html_url":"https://github.com/Linaro/odp/pull/267#discussion_r148085959","pull_request_url":"https://api.github.com/repos/Linaro/odp/pulls/267","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Linaro/odp/pulls/comments/148085959"},"html":{"href":"https://github.com/Linaro/odp/pull/267#discussion_r148085959"},"pull_request":{"href":"https://api.github.com/repos/Linaro/odp/pulls/267"}},"in_reply_to_id":148047977},"pull_request":{"url":"https://api.github.com/repos/Linaro/odp/pulls/267","id":149751493,"html_url":"https://github.com/Linaro/odp/pull/267","diff_url":"https://github.com/Linaro/odp/pull/267.diff","patch_url":"https://github.com/Linaro/odp/pull/267.patch","issue_url":"https://api.github.com/repos/Linaro/odp/issues/267","number":267,"state":"open","locked":false,"title":"[PATCH 2.0 v1] Remove duplicate odp_packet_io_internal.h","user":{"login":"bogdanPricope","id":10117294,"avatar_url":"https://avatars2.githubusercontent.com/u/10117294?v=4","gravatar_id":"","url":"https://api.github.com/users/bogdanPricope","html_url":"https://github.com/bogdanPricope","followers_url":"https://api.github.com/users/bogdanPricope/followers","following_url":"https://api.github.com/users/bogdanPricope/following{/other_user}","gists_url":"https://api.github.com/users/bogdanPricope/gists{/gist_id}","starred_url":"https://api.github.com/users/bogdanPricope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bogdanPricope/subscriptions","organizations_url":"https://api.github.com/users/bogdanPricope/orgs","repos_url":"https://api.github.com/users/bogdanPricope/repos","events_url":"https://api.github.com/users/bogdanPricope/events{/privacy}","received_events_url":"https://api.github.com/users/bogdanPricope/received_events","type":"User","site_admin":false},"body":"Remove duplicate odp_packet_io_internal.h","created_at":"2017-10-31T10:49:50Z","updated_at":"2017-10-31T18:26:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a69a4d7670d99912c517574391cb72bae3308c3f","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Linaro/odp/pulls/267/commits","review_comments_url":"https://api.github.com/repos/Linaro/odp/pulls/267/comments","review_comment_url":"https://api.github.com/repos/Linaro/odp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Linaro/odp/issues/267/comments","statuses_url":"https://api.github.com/repos/Linaro/odp/statuses/187cf1f28f8f5f28b36fdb429b0770f4febc3ac3","head":{"label":"bogdanPricope:2_0_pktio_internal_pr","ref":"2_0_pktio_internal_pr","sha":"187cf1f28f8f5f28b36fdb429b0770f4febc3ac3","user":{"login":"bogdanPricope","id":10117294,"avatar_url":"https://avatars2.githubusercontent.com/u/10117294?v=4","gravatar_id":"","url":"https://api.github.com/users/bogdanPricope","html_url":"https://github.com/bogdanPricope","followers_url":"https://api.github.com/users/bogdanPricope/followers","following_url":"https://api.github.com/users/bogdanPricope/following{/other_user}","gists_url":"https://api.github.com/users/bogdanPricope/gists{/gist_id}","starred_url":"https://api.github.com/users/bogdanPricope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bogdanPricope/subscriptions","organizations_url":"https://api.github.com/users/bogdanPricope/orgs","repos_url":"https://api.github.com/users/bogdanPricope/repos","events_url":"https://api.github.com/users/bogdanPricope/events{/privacy}","received_events_url":"https://api.github.com/users/bogdanPricope/received_events","type":"User","site_admin":false},"repo":{"id":94429694,"name":"odp","full_name":"bogdanPricope/odp","owner":{"login":"bogdanPricope","id":10117294,"avatar_url":"https://avatars2.githubusercontent.com/u/10117294?v=4","gravatar_id":"","url":"https://api.github.com/users/bogdanPricope","html_url":"https://github.com/bogdanPricope","followers_url":"https://api.github.com/users/bogdanPricope/followers","following_url":"https://api.github.com/users/bogdanPricope/following{/other_user}","gists_url":"https://api.github.com/users/bogdanPricope/gists{/gist_id}","starred_url":"https://api.github.com/users/bogdanPricope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bogdanPricope/subscriptions","organizations_url":"https://api.github.com/users/bogdanPricope/orgs","repos_url":"https://api.github.com/users/bogdanPricope/repos","events_url":"https://api.github.com/users/bogdanPricope/events{/privacy}","received_events_url":"https://api.github.com/users/bogdanPricope/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bogdanPricope/odp","description":"The ODP project is an open-source, cross-platform set of application programming interfaces (APIs) for the networking data plane","fork":true,"url":"https://api.github.com/repos/bogdanPricope/odp","forks_url":"https://api.github.com/repos/bogdanPricope/odp/forks","keys_url":"https://api.github.com/repos/bogdanPricope/odp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bogdanPricope/odp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bogdanPricope/odp/teams","hooks_url":"https://api.github.com/repos/bogdanPricope/odp/hooks","issue_events_url":"https://api.github.com/repos/bogdanPricope/odp/issues/events{/number}","events_url":"https://api.github.com/repos/bogdanPricope/odp/events","assignees_url":"https://api.github.com/repos/bogdanPricope/odp/assignees{/user}","branches_url":"https://api.github.com/repos/bogdanPricope/odp/branches{/branch}","tags_url":"https://api.github.com/repos/bogdanPricope/odp/tags","blobs_url":"https://api.github.com/repos/bogdanPricope/odp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bogdanPricope/odp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bogdanPricope/odp/git/refs{/sha}","trees_url":"https://api.github.com/repos/bogdanPricope/odp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bogdanPricope/odp/statuses/{sha}","languages_url":"https://api.github.com/repos/bogdanPricope/odp/languages","stargazers_url":"https://api.github.com/repos/bogdanPricope/odp/stargazers","contributors_url":"https://api.github.com/repos/bogdanPricope/odp/contributors","subscribers_url":"https://api.github.com/repos/bogdanPricope/odp/subscribers","subscription_url":"https://api.github.com/repos/bogdanPricope/odp/subscription","commits_url":"https://api.github.com/repos/bogdanPricope/odp/commits{/sha}","git_commits_url":"https://api.github.com/repos/bogdanPricope/odp/git/commits{/sha}","comments_url":"https://api.github.com/repos/bogdanPricope/odp/comments{/number}","issue_comment_url":"https://api.github.com/repos/bogdanPricope/odp/issues/comments{/number}","contents_url":"https://api.github.com/repos/bogdanPricope/odp/contents/{+path}","compare_url":"https://api.github.com/repos/bogdanPricope/odp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bogdanPricope/odp/merges","archive_url":"https://api.github.com/repos/bogdanPricope/odp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bogdanPricope/odp/downloads","issues_url":"https://api.github.com/repos/bogdanPricope/odp/issues{/number}","pulls_url":"https://api.github.com/repos/bogdanPricope/odp/pulls{/number}","milestones_url":"https://api.github.com/repos/bogdanPricope/odp/milestones{/number}","notifications_url":"https://api.github.com/repos/bogdanPricope/odp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bogdanPricope/odp/labels{/name}","releases_url":"https://api.github.com/repos/bogdanPricope/odp/releases{/id}","deployments_url":"https://api.github.com/repos/bogdanPricope/odp/deployments","created_at":"2017-06-15T10:42:06Z","updated_at":"2017-06-15T10:42:09Z","pushed_at":"2017-10-31T09:36:27Z","git_url":"git://github.com/bogdanPricope/odp.git","ssh_url":"git@github.com:bogdanPricope/odp.git","clone_url":"https://github.com/bogdanPricope/odp.git","svn_url":"https://github.com/bogdanPricope/odp","homepage":"http://www.opendataplane.org/","size":8377,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Linaro:2.0","ref":"2.0","sha":"1236f1ad2bba56b5e49ff62df247e52143b48985","user":{"login":"Linaro","id":1180626,"avatar_url":"https://avatars0.githubusercontent.com/u/1180626?v=4","gravatar_id":"","url":"https://api.github.com/users/Linaro","html_url":"https://github.com/Linaro","followers_url":"https://api.github.com/users/Linaro/followers","following_url":"https://api.github.com/users/Linaro/following{/other_user}","gists_url":"https://api.github.com/users/Linaro/gists{/gist_id}","starred_url":"https://api.github.com/users/Linaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Linaro/subscriptions","organizations_url":"https://api.github.com/users/Linaro/orgs","repos_url":"https://api.github.com/users/Linaro/repos","events_url":"https://api.github.com/users/Linaro/events{/privacy}","received_events_url":"https://api.github.com/users/Linaro/received_events","type":"Organization","site_admin":false},"repo":{"id":79130215,"name":"odp","full_name":"Linaro/odp","owner":{"login":"Linaro","id":1180626,"avatar_url":"https://avatars0.githubusercontent.com/u/1180626?v=4","gravatar_id":"","url":"https://api.github.com/users/Linaro","html_url":"https://github.com/Linaro","followers_url":"https://api.github.com/users/Linaro/followers","following_url":"https://api.github.com/users/Linaro/following{/other_user}","gists_url":"https://api.github.com/users/Linaro/gists{/gist_id}","starred_url":"https://api.github.com/users/Linaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Linaro/subscriptions","organizations_url":"https://api.github.com/users/Linaro/orgs","repos_url":"https://api.github.com/users/Linaro/repos","events_url":"https://api.github.com/users/Linaro/events{/privacy}","received_events_url":"https://api.github.com/users/Linaro/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Linaro/odp","description":"The ODP project is an open-source, cross-platform set of application programming interfaces (APIs) for the networking data plane","fork":false,"url":"https://api.github.com/repos/Linaro/odp","forks_url":"https://api.github.com/repos/Linaro/odp/forks","keys_url":"https://api.github.com/repos/Linaro/odp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Linaro/odp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Linaro/odp/teams","hooks_url":"https://api.github.com/repos/Linaro/odp/hooks","issue_events_url":"https://api.github.com/repos/Linaro/odp/issues/events{/number}","events_url":"https://api.github.com/repos/Linaro/odp/events","assignees_url":"https://api.github.com/repos/Linaro/odp/assignees{/user}","branches_url":"https://api.github.com/repos/Linaro/odp/branches{/branch}","tags_url":"https://api.github.com/repos/Linaro/odp/tags","blobs_url":"https://api.github.com/repos/Linaro/odp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Linaro/odp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Linaro/odp/git/refs{/sha}","trees_url":"https://api.github.com/repos/Linaro/odp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Linaro/odp/statuses/{sha}","languages_url":"https://api.github.com/repos/Linaro/odp/languages","stargazers_url":"https://api.github.com/repos/Linaro/odp/stargazers","contributors_url":"https://api.github.com/repos/Linaro/odp/contributors","subscribers_url":"https://api.github.com/repos/Linaro/odp/subscribers","subscription_url":"https://api.github.com/repos/Linaro/odp/subscription","commits_url":"https://api.github.com/repos/Linaro/odp/commits{/sha}","git_commits_url":"https://api.github.com/repos/Linaro/odp/git/commits{/sha}","comments_url":"https://api.github.com/repos/Linaro/odp/comments{/number}","issue_comment_url":"https://api.github.com/repos/Linaro/odp/issues/comments{/number}","contents_url":"https://api.github.com/repos/Linaro/odp/contents/{+path}","compare_url":"https://api.github.com/repos/Linaro/odp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Linaro/odp/merges","archive_url":"https://api.github.com/repos/Linaro/odp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Linaro/odp/downloads","issues_url":"https://api.github.com/repos/Linaro/odp/issues{/number}","pulls_url":"https://api.github.com/repos/Linaro/odp/pulls{/number}","milestones_url":"https://api.github.com/repos/Linaro/odp/milestones{/number}","notifications_url":"https://api.github.com/repos/Linaro/odp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Linaro/odp/labels{/name}","releases_url":"https://api.github.com/repos/Linaro/odp/releases{/id}","deployments_url":"https://api.github.com/repos/Linaro/odp/deployments","created_at":"2017-01-16T15:11:12Z","updated_at":"2017-10-19T10:59:06Z","pushed_at":"2017-10-31T15:27:55Z","git_url":"git://github.com/Linaro/odp.git","ssh_url":"git@github.com:Linaro/odp.git","clone_url":"https://github.com/Linaro/odp.git","svn_url":"https://github.com/Linaro/odp","homepage":"http://www.opendataplane.org/","size":9290,"stargazers_count":27,"watchers_count":27,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":38,"mirror_url":null,"archived":false,"open_issues_count":22,"forks":38,"open_issues":22,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Linaro/odp/pulls/267"},"html":{"href":"https://github.com/Linaro/odp/pull/267"},"issue":{"href":"https://api.github.com/repos/Linaro/odp/issues/267"},"comments":{"href":"https://api.github.com/repos/Linaro/odp/issues/267/comments"},"review_comments":{"href":"https://api.github.com/repos/Linaro/odp/pulls/267/comments"},"review_comment":{"href":"https://api.github.com/repos/Linaro/odp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Linaro/odp/pulls/267/commits"},"statuses":{"href":"https://api.github.com/repos/Linaro/odp/statuses/187cf1f28f8f5f28b36fdb429b0770f4febc3ac3"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"nagarahalli"}}