{"action":"created","issue":{"url":"https://api.github.com/repos/eclipse/omr/issues/1712","repository_url":"https://api.github.com/repos/eclipse/omr","labels_url":"https://api.github.com/repos/eclipse/omr/issues/1712/labels{/name}","comments_url":"https://api.github.com/repos/eclipse/omr/issues/1712/comments","events_url":"https://api.github.com/repos/eclipse/omr/issues/1712/events","html_url":"https://github.com/eclipse/omr/pull/1712","id":259637772,"number":1712,"title":"Correct allocator types","user":{"login":"mgaudet","id":2906003,"avatar_url":"https://avatars3.githubusercontent.com/u/2906003?v=4","gravatar_id":"","url":"https://api.github.com/users/mgaudet","html_url":"https://github.com/mgaudet","followers_url":"https://api.github.com/users/mgaudet/followers","following_url":"https://api.github.com/users/mgaudet/following{/other_user}","gists_url":"https://api.github.com/users/mgaudet/gists{/gist_id}","starred_url":"https://api.github.com/users/mgaudet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgaudet/subscriptions","organizations_url":"https://api.github.com/users/mgaudet/orgs","repos_url":"https://api.github.com/users/mgaudet/repos","events_url":"https://api.github.com/users/mgaudet/events{/privacy}","received_events_url":"https://api.github.com/users/mgaudet/received_events","type":"User","site_admin":false},"labels":[{"id":463261830,"url":"https://api.github.com/repos/eclipse/omr/labels/compiler","name":"compiler","color":"00d73d","default":false}],"state":"open","locked":false,"assignee":{"login":"0xdaryl","id":17713611,"avatar_url":"https://avatars2.githubusercontent.com/u/17713611?v=4","gravatar_id":"","url":"https://api.github.com/users/0xdaryl","html_url":"https://github.com/0xdaryl","followers_url":"https://api.github.com/users/0xdaryl/followers","following_url":"https://api.github.com/users/0xdaryl/following{/other_user}","gists_url":"https://api.github.com/users/0xdaryl/gists{/gist_id}","starred_url":"https://api.github.com/users/0xdaryl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0xdaryl/subscriptions","organizations_url":"https://api.github.com/users/0xdaryl/orgs","repos_url":"https://api.github.com/users/0xdaryl/repos","events_url":"https://api.github.com/users/0xdaryl/events{/privacy}","received_events_url":"https://api.github.com/users/0xdaryl/received_events","type":"User","site_admin":false},"assignees":[{"login":"0xdaryl","id":17713611,"avatar_url":"https://avatars2.githubusercontent.com/u/17713611?v=4","gravatar_id":"","url":"https://api.github.com/users/0xdaryl","html_url":"https://github.com/0xdaryl","followers_url":"https://api.github.com/users/0xdaryl/followers","following_url":"https://api.github.com/users/0xdaryl/following{/other_user}","gists_url":"https://api.github.com/users/0xdaryl/gists{/gist_id}","starred_url":"https://api.github.com/users/0xdaryl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0xdaryl/subscriptions","organizations_url":"https://api.github.com/users/0xdaryl/orgs","repos_url":"https://api.github.com/users/0xdaryl/repos","events_url":"https://api.github.com/users/0xdaryl/events{/privacy}","received_events_url":"https://api.github.com/users/0xdaryl/received_events","type":"User","site_admin":false}],"milestone":null,"comments":10,"created_at":"2017-09-21T21:26:48Z","updated_at":"2017-09-29T20:38:25Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/eclipse/omr/pulls/1712","html_url":"https://github.com/eclipse/omr/pull/1712","diff_url":"https://github.com/eclipse/omr/pull/1712.diff","patch_url":"https://github.com/eclipse/omr/pull/1712.patch"},"body":"The allocator types were missing consts, however, only recently did\r\ncompilers start checking this (see #1707 for details).\r\n\r\nSigned-off-by: Matthew Gaudet <magaudet@ca.ibm.com>"},"comment":{"url":"https://api.github.com/repos/eclipse/omr/issues/comments/333233173","html_url":"https://github.com/eclipse/omr/pull/1712#issuecomment-333233173","issue_url":"https://api.github.com/repos/eclipse/omr/issues/1712","id":333233173,"user":{"login":"0xdaryl","id":17713611,"avatar_url":"https://avatars2.githubusercontent.com/u/17713611?v=4","gravatar_id":"","url":"https://api.github.com/users/0xdaryl","html_url":"https://github.com/0xdaryl","followers_url":"https://api.github.com/users/0xdaryl/followers","following_url":"https://api.github.com/users/0xdaryl/following{/other_user}","gists_url":"https://api.github.com/users/0xdaryl/gists{/gist_id}","starred_url":"https://api.github.com/users/0xdaryl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0xdaryl/subscriptions","organizations_url":"https://api.github.com/users/0xdaryl/orgs","repos_url":"https://api.github.com/users/0xdaryl/repos","events_url":"https://api.github.com/users/0xdaryl/events{/privacy}","received_events_url":"https://api.github.com/users/0xdaryl/received_events","type":"User","site_admin":false},"created_at":"2017-09-29T20:38:25Z","updated_at":"2017-09-29T20:38:25Z","author_association":"CONTRIBUTOR","body":"I would rather the OMR linter focus on checking for things that are unique to the design patterns and code structures within the Eclipse OMR compiler (like the rules around extensible classes), as opposed to things that could be caught by running an actual compiler or general static analyzer like Clang.  I understand the concern, but I'm not convinced (yet) the impact is great enough to warrant changing the original motivation for the OMR linter."}}
{"actor":{"display_login":"0xdaryl"}}