{"action":"closed","number":2842,"pull_request":{"url":"https://api.github.com/repos/PhilJay/MPAndroidChart/pulls/2842","id":107451088,"html_url":"https://github.com/PhilJay/MPAndroidChart/pull/2842","diff_url":"https://github.com/PhilJay/MPAndroidChart/pull/2842.diff","patch_url":"https://github.com/PhilJay/MPAndroidChart/pull/2842.patch","issue_url":"https://api.github.com/repos/PhilJay/MPAndroidChart/issues/2842","number":2842,"state":"closed","locked":false,"title":"Implementation of equals() and hashcode() for class Entry","user":{"login":"PaddySmalls","id":12052783,"avatar_url":"https://avatars0.githubusercontent.com/u/12052783?v=3","gravatar_id":"","url":"https://api.github.com/users/PaddySmalls","html_url":"https://github.com/PaddySmalls","followers_url":"https://api.github.com/users/PaddySmalls/followers","following_url":"https://api.github.com/users/PaddySmalls/following{/other_user}","gists_url":"https://api.github.com/users/PaddySmalls/gists{/gist_id}","starred_url":"https://api.github.com/users/PaddySmalls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PaddySmalls/subscriptions","organizations_url":"https://api.github.com/users/PaddySmalls/orgs","repos_url":"https://api.github.com/users/PaddySmalls/repos","events_url":"https://api.github.com/users/PaddySmalls/events{/privacy}","received_events_url":"https://api.github.com/users/PaddySmalls/received_events","type":"User","site_admin":false},"body":"Hi,\r\nI recently ran into into an issue when I implemented some unit tests for our university project [\"Zeitfresser\"](https://github.com/slipke/Zeitfresser). I had to LinkedLists containing two Entry instances with the exact same property values. However, comparing these two Lists always have me _false_ as a return value, since every call to _equals()_ on class _Entry_ is delegated to _Object_.\r\nI thought that implementing these methods for _Entry_ and its base class _BaseEntry_ might be valuable not just for my own use case. Having and comparing Lists of Entries seems like a common scenario from my perspective. \r\nFor the implementation of both methods, I followed common standards and best practices.\r\nIn oder to verify _equals()_ as well as _hashcode()_ work properly, I also added a test class _EntryTest_.  \r\nThis class covers the most basic cases for Entry comparison. Of course I also made sure that my changes don't break any other running tests.  \r\n\r\nCheers, Patrick","created_at":"2017-02-22T16:55:23Z","updated_at":"2017-06-01T08:56:32Z","closed_at":"2017-06-01T08:56:32Z","merged_at":null,"merge_commit_sha":"a783457ab01b5bd33497e1ac6cd2d1c1348d657d","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/PhilJay/MPAndroidChart/pulls/2842/commits","review_comments_url":"https://api.github.com/repos/PhilJay/MPAndroidChart/pulls/2842/comments","review_comment_url":"https://api.github.com/repos/PhilJay/MPAndroidChart/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PhilJay/MPAndroidChart/issues/2842/comments","statuses_url":"https://api.github.com/repos/PhilJay/MPAndroidChart/statuses/da4c66dcc19d53f96672a4b725b2c17f96b94bef","head":{"label":"PaddySmalls:entry-equals","ref":"entry-equals","sha":"da4c66dcc19d53f96672a4b725b2c17f96b94bef","user":{"login":"PaddySmalls","id":12052783,"avatar_url":"https://avatars0.githubusercontent.com/u/12052783?v=3","gravatar_id":"","url":"https://api.github.com/users/PaddySmalls","html_url":"https://github.com/PaddySmalls","followers_url":"https://api.github.com/users/PaddySmalls/followers","following_url":"https://api.github.com/users/PaddySmalls/following{/other_user}","gists_url":"https://api.github.com/users/PaddySmalls/gists{/gist_id}","starred_url":"https://api.github.com/users/PaddySmalls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PaddySmalls/subscriptions","organizations_url":"https://api.github.com/users/PaddySmalls/orgs","repos_url":"https://api.github.com/users/PaddySmalls/repos","events_url":"https://api.github.com/users/PaddySmalls/events{/privacy}","received_events_url":"https://api.github.com/users/PaddySmalls/received_events","type":"User","site_admin":false},"repo":{"id":82819557,"name":"MPAndroidChart","full_name":"PaddySmalls/MPAndroidChart","owner":{"login":"PaddySmalls","id":12052783,"avatar_url":"https://avatars0.githubusercontent.com/u/12052783?v=3","gravatar_id":"","url":"https://api.github.com/users/PaddySmalls","html_url":"https://github.com/PaddySmalls","followers_url":"https://api.github.com/users/PaddySmalls/followers","following_url":"https://api.github.com/users/PaddySmalls/following{/other_user}","gists_url":"https://api.github.com/users/PaddySmalls/gists{/gist_id}","starred_url":"https://api.github.com/users/PaddySmalls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PaddySmalls/subscriptions","organizations_url":"https://api.github.com/users/PaddySmalls/orgs","repos_url":"https://api.github.com/users/PaddySmalls/repos","events_url":"https://api.github.com/users/PaddySmalls/events{/privacy}","received_events_url":"https://api.github.com/users/PaddySmalls/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/PaddySmalls/MPAndroidChart","description":"A powerful Android chart view / graph view library, supporting line- bar- pie- radar- bubble- and candlestick charts as well as scaling, dragging and animations.","fork":true,"url":"https://api.github.com/repos/PaddySmalls/MPAndroidChart","forks_url":"https://api.github.com/repos/PaddySmalls/MPAndroidChart/forks","keys_url":"https://api.github.com/repos/PaddySmalls/MPAndroidChart/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PaddySmalls/MPAndroidChart/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PaddySmalls/MPAndroidChart/teams","hooks_url":"https://api.github.com/repos/PaddySmalls/MPAndroidChart/hooks","issue_events_url":"https://api.github.com/repos/PaddySmalls/MPAndroidChart/issues/events{/number}","events_url":"https://api.github.com/repos/PaddySmalls/MPAndroidChart/events","assignees_url":"https://api.github.com/repos/PaddySmalls/MPAndroidChart/assignees{/user}","branches_url":"https://api.github.com/repos/PaddySmalls/MPAndroidChart/branches{/branch}","tags_url":"https://api.github.com/repos/PaddySmalls/MPAndroidChart/tags","blobs_url":"https://api.github.com/repos/PaddySmalls/MPAndroidChart/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PaddySmalls/MPAndroidChart/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PaddySmalls/MPAndroidChart/git/refs{/sha}","trees_url":"https://api.github.com/repos/PaddySmalls/MPAndroidChart/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PaddySmalls/MPAndroidChart/statuses/{sha}","languages_url":"https://api.github.com/repos/PaddySmalls/MPAndroidChart/languages","stargazers_url":"https://api.github.com/repos/PaddySmalls/MPAndroidChart/stargazers","contributors_url":"https://api.github.com/repos/PaddySmalls/MPAndroidChart/contributors","subscribers_url":"https://api.github.com/repos/PaddySmalls/MPAndroidChart/subscribers","subscription_url":"https://api.github.com/repos/PaddySmalls/MPAndroidChart/subscription","commits_url":"https://api.github.com/repos/PaddySmalls/MPAndroidChart/commits{/sha}","git_commits_url":"https://api.github.com/repos/PaddySmalls/MPAndroidChart/git/commits{/sha}","comments_url":"https://api.github.com/repos/PaddySmalls/MPAndroidChart/comments{/number}","issue_comment_url":"https://api.github.com/repos/PaddySmalls/MPAndroidChart/issues/comments{/number}","contents_url":"https://api.github.com/repos/PaddySmalls/MPAndroidChart/contents/{+path}","compare_url":"https://api.github.com/repos/PaddySmalls/MPAndroidChart/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PaddySmalls/MPAndroidChart/merges","archive_url":"https://api.github.com/repos/PaddySmalls/MPAndroidChart/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PaddySmalls/MPAndroidChart/downloads","issues_url":"https://api.github.com/repos/PaddySmalls/MPAndroidChart/issues{/number}","pulls_url":"https://api.github.com/repos/PaddySmalls/MPAndroidChart/pulls{/number}","milestones_url":"https://api.github.com/repos/PaddySmalls/MPAndroidChart/milestones{/number}","notifications_url":"https://api.github.com/repos/PaddySmalls/MPAndroidChart/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PaddySmalls/MPAndroidChart/labels{/name}","releases_url":"https://api.github.com/repos/PaddySmalls/MPAndroidChart/releases{/id}","deployments_url":"https://api.github.com/repos/PaddySmalls/MPAndroidChart/deployments","created_at":"2017-02-22T15:21:22Z","updated_at":"2017-02-22T15:21:26Z","pushed_at":"2017-02-24T12:28:17Z","git_url":"git://github.com/PaddySmalls/MPAndroidChart.git","ssh_url":"git@github.com:PaddySmalls/MPAndroidChart.git","clone_url":"https://github.com/PaddySmalls/MPAndroidChart.git","svn_url":"https://github.com/PaddySmalls/MPAndroidChart","homepage":"","size":20519,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PhilJay:master","ref":"master","sha":"0c919ab02d5919ac3ac76c9f0fb0642a19153f20","user":{"login":"PhilJay","id":6759734,"avatar_url":"https://avatars2.githubusercontent.com/u/6759734?v=3","gravatar_id":"","url":"https://api.github.com/users/PhilJay","html_url":"https://github.com/PhilJay","followers_url":"https://api.github.com/users/PhilJay/followers","following_url":"https://api.github.com/users/PhilJay/following{/other_user}","gists_url":"https://api.github.com/users/PhilJay/gists{/gist_id}","starred_url":"https://api.github.com/users/PhilJay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PhilJay/subscriptions","organizations_url":"https://api.github.com/users/PhilJay/orgs","repos_url":"https://api.github.com/users/PhilJay/repos","events_url":"https://api.github.com/users/PhilJay/events{/privacy}","received_events_url":"https://api.github.com/users/PhilJay/received_events","type":"User","site_admin":false},"repo":{"id":19148949,"name":"MPAndroidChart","full_name":"PhilJay/MPAndroidChart","owner":{"login":"PhilJay","id":6759734,"avatar_url":"https://avatars2.githubusercontent.com/u/6759734?v=3","gravatar_id":"","url":"https://api.github.com/users/PhilJay","html_url":"https://github.com/PhilJay","followers_url":"https://api.github.com/users/PhilJay/followers","following_url":"https://api.github.com/users/PhilJay/following{/other_user}","gists_url":"https://api.github.com/users/PhilJay/gists{/gist_id}","starred_url":"https://api.github.com/users/PhilJay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PhilJay/subscriptions","organizations_url":"https://api.github.com/users/PhilJay/orgs","repos_url":"https://api.github.com/users/PhilJay/repos","events_url":"https://api.github.com/users/PhilJay/events{/privacy}","received_events_url":"https://api.github.com/users/PhilJay/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/PhilJay/MPAndroidChart","description":"A powerful Android chart view / graph view library, supporting line- bar- pie- radar- bubble- and candlestick charts as well as scaling, dragging and animations.","fork":false,"url":"https://api.github.com/repos/PhilJay/MPAndroidChart","forks_url":"https://api.github.com/repos/PhilJay/MPAndroidChart/forks","keys_url":"https://api.github.com/repos/PhilJay/MPAndroidChart/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PhilJay/MPAndroidChart/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PhilJay/MPAndroidChart/teams","hooks_url":"https://api.github.com/repos/PhilJay/MPAndroidChart/hooks","issue_events_url":"https://api.github.com/repos/PhilJay/MPAndroidChart/issues/events{/number}","events_url":"https://api.github.com/repos/PhilJay/MPAndroidChart/events","assignees_url":"https://api.github.com/repos/PhilJay/MPAndroidChart/assignees{/user}","branches_url":"https://api.github.com/repos/PhilJay/MPAndroidChart/branches{/branch}","tags_url":"https://api.github.com/repos/PhilJay/MPAndroidChart/tags","blobs_url":"https://api.github.com/repos/PhilJay/MPAndroidChart/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PhilJay/MPAndroidChart/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PhilJay/MPAndroidChart/git/refs{/sha}","trees_url":"https://api.github.com/repos/PhilJay/MPAndroidChart/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PhilJay/MPAndroidChart/statuses/{sha}","languages_url":"https://api.github.com/repos/PhilJay/MPAndroidChart/languages","stargazers_url":"https://api.github.com/repos/PhilJay/MPAndroidChart/stargazers","contributors_url":"https://api.github.com/repos/PhilJay/MPAndroidChart/contributors","subscribers_url":"https://api.github.com/repos/PhilJay/MPAndroidChart/subscribers","subscription_url":"https://api.github.com/repos/PhilJay/MPAndroidChart/subscription","commits_url":"https://api.github.com/repos/PhilJay/MPAndroidChart/commits{/sha}","git_commits_url":"https://api.github.com/repos/PhilJay/MPAndroidChart/git/commits{/sha}","comments_url":"https://api.github.com/repos/PhilJay/MPAndroidChart/comments{/number}","issue_comment_url":"https://api.github.com/repos/PhilJay/MPAndroidChart/issues/comments{/number}","contents_url":"https://api.github.com/repos/PhilJay/MPAndroidChart/contents/{+path}","compare_url":"https://api.github.com/repos/PhilJay/MPAndroidChart/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PhilJay/MPAndroidChart/merges","archive_url":"https://api.github.com/repos/PhilJay/MPAndroidChart/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PhilJay/MPAndroidChart/downloads","issues_url":"https://api.github.com/repos/PhilJay/MPAndroidChart/issues{/number}","pulls_url":"https://api.github.com/repos/PhilJay/MPAndroidChart/pulls{/number}","milestones_url":"https://api.github.com/repos/PhilJay/MPAndroidChart/milestones{/number}","notifications_url":"https://api.github.com/repos/PhilJay/MPAndroidChart/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PhilJay/MPAndroidChart/labels{/name}","releases_url":"https://api.github.com/repos/PhilJay/MPAndroidChart/releases{/id}","deployments_url":"https://api.github.com/repos/PhilJay/MPAndroidChart/deployments","created_at":"2014-04-25T14:29:47Z","updated_at":"2017-06-01T08:44:46Z","pushed_at":"2017-05-26T10:33:38Z","git_url":"git://github.com/PhilJay/MPAndroidChart.git","ssh_url":"git@github.com:PhilJay/MPAndroidChart.git","clone_url":"https://github.com/PhilJay/MPAndroidChart.git","svn_url":"https://github.com/PhilJay/MPAndroidChart","homepage":"","size":20543,"stargazers_count":15875,"watchers_count":15875,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4746,"mirror_url":null,"open_issues_count":817,"forks":4746,"open_issues":817,"watchers":15875,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PhilJay/MPAndroidChart/pulls/2842"},"html":{"href":"https://github.com/PhilJay/MPAndroidChart/pull/2842"},"issue":{"href":"https://api.github.com/repos/PhilJay/MPAndroidChart/issues/2842"},"comments":{"href":"https://api.github.com/repos/PhilJay/MPAndroidChart/issues/2842/comments"},"review_comments":{"href":"https://api.github.com/repos/PhilJay/MPAndroidChart/pulls/2842/comments"},"review_comment":{"href":"https://api.github.com/repos/PhilJay/MPAndroidChart/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PhilJay/MPAndroidChart/pulls/2842/commits"},"statuses":{"href":"https://api.github.com/repos/PhilJay/MPAndroidChart/statuses/da4c66dcc19d53f96672a4b725b2c17f96b94bef"}},"merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":214,"deletions":0,"changed_files":3}}
{"actor":{"display_login":"PaddySmalls"}}