{"action":"created","comment":{"url":"https://api.github.com/repos/angular/angular/pulls/comments/123838053","pull_request_review_id":46079890,"id":123838053,"diff_hunk":"@@ -0,0 +1,36 @@\n+/** @experimental */\n+export declare class NgPushRegistration {\n+    readonly url: string;\n+    constructor(ps: any);\n+    auth(): string;\n+    key(method?: string): string;\n+    toJSON(): Object;\n+    unsubscribe(): Observable<boolean>;","path":"tools/public_api_guard/service-worker/service-worker.d.ts","position":8,"original_position":8,"commit_id":"8763b6d6a4ded29febc1569ec67339ea82562824","original_commit_id":"8763b6d6a4ded29febc1569ec67339ea82562824","user":{"login":"IgorMinar","id":216296,"avatar_url":"https://avatars0.githubusercontent.com/u/216296?v=3","gravatar_id":"","url":"https://api.github.com/users/IgorMinar","html_url":"https://github.com/IgorMinar","followers_url":"https://api.github.com/users/IgorMinar/followers","following_url":"https://api.github.com/users/IgorMinar/following{/other_user}","gists_url":"https://api.github.com/users/IgorMinar/gists{/gist_id}","starred_url":"https://api.github.com/users/IgorMinar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IgorMinar/subscriptions","organizations_url":"https://api.github.com/users/IgorMinar/orgs","repos_url":"https://api.github.com/users/IgorMinar/repos","events_url":"https://api.github.com/users/IgorMinar/events{/privacy}","received_events_url":"https://api.github.com/users/IgorMinar/received_events","type":"User","site_admin":false},"body":"this looks odd.\r\n\r\nwhy do we have two streams and a special unsubscribe API?\r\n\r\nwhy isn't the api just:\r\n\r\n```\r\nexport declare class NgServiceWorker {\r\n  pushNotifications(options: {applicationServerKey?: string}): Observable<ConnectionInfo|Notification>;\r\n  updateNotifications(): Observable<UpdateEvent>;\r\n  checkForUpdate(): void;\r\n  activateUpdate(): void;\r\n}\r\n```\r\n\r\nThis would simplify the registration and  funnel all appropriate events through the two notification streams.","created_at":"2017-06-23T20:29:47Z","updated_at":"2017-06-23T20:38:54Z","html_url":"https://github.com/angular/angular/pull/17276#discussion_r123838053","pull_request_url":"https://api.github.com/repos/angular/angular/pulls/17276","_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/comments/123838053"},"html":{"href":"https://github.com/angular/angular/pull/17276#discussion_r123838053"},"pull_request":{"href":"https://api.github.com/repos/angular/angular/pulls/17276"}}},"pull_request":{"url":"https://api.github.com/repos/angular/angular/pulls/17276","id":124283595,"html_url":"https://github.com/angular/angular/pull/17276","diff_url":"https://github.com/angular/angular/pull/17276.diff","patch_url":"https://github.com/angular/angular/pull/17276.patch","issue_url":"https://api.github.com/repos/angular/angular/issues/17276","number":17276,"state":"open","locked":false,"title":"feat: import of @angular/service-worker","user":{"login":"alxhub","id":4175141,"avatar_url":"https://avatars3.githubusercontent.com/u/4175141?v=3","gravatar_id":"","url":"https://api.github.com/users/alxhub","html_url":"https://github.com/alxhub","followers_url":"https://api.github.com/users/alxhub/followers","following_url":"https://api.github.com/users/alxhub/following{/other_user}","gists_url":"https://api.github.com/users/alxhub/gists{/gist_id}","starred_url":"https://api.github.com/users/alxhub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alxhub/subscriptions","organizations_url":"https://api.github.com/users/alxhub/orgs","repos_url":"https://api.github.com/users/alxhub/repos","events_url":"https://api.github.com/users/alxhub/events{/privacy}","received_events_url":"https://api.github.com/users/alxhub/received_events","type":"User","site_admin":false},"body":"Imports the existing repository (without history) from\r\nhttps://github.com/angular/mobile-toolkit. Sets up the\r\npackage to build using build.sh and to run unit tests\r\nas part of test.sh. An integration test is also added,\r\nwrapping the SW e2e test so that `npm run test` works.","created_at":"2017-06-06T20:42:41Z","updated_at":"2017-06-23T20:38:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c364bcf2619d8b5d6a3fa4ea35390cba15e8cdba","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/angular/angular/pulls/17276/commits","review_comments_url":"https://api.github.com/repos/angular/angular/pulls/17276/comments","review_comment_url":"https://api.github.com/repos/angular/angular/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/angular/issues/17276/comments","statuses_url":"https://api.github.com/repos/angular/angular/statuses/8763b6d6a4ded29febc1569ec67339ea82562824","head":{"label":"alxhub:service-worker","ref":"service-worker","sha":"8763b6d6a4ded29febc1569ec67339ea82562824","user":{"login":"alxhub","id":4175141,"avatar_url":"https://avatars3.githubusercontent.com/u/4175141?v=3","gravatar_id":"","url":"https://api.github.com/users/alxhub","html_url":"https://github.com/alxhub","followers_url":"https://api.github.com/users/alxhub/followers","following_url":"https://api.github.com/users/alxhub/following{/other_user}","gists_url":"https://api.github.com/users/alxhub/gists{/gist_id}","starred_url":"https://api.github.com/users/alxhub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alxhub/subscriptions","organizations_url":"https://api.github.com/users/alxhub/orgs","repos_url":"https://api.github.com/users/alxhub/repos","events_url":"https://api.github.com/users/alxhub/events{/privacy}","received_events_url":"https://api.github.com/users/alxhub/received_events","type":"User","site_admin":false},"repo":{"id":35444156,"name":"angular","full_name":"alxhub/angular","owner":{"login":"alxhub","id":4175141,"avatar_url":"https://avatars3.githubusercontent.com/u/4175141?v=3","gravatar_id":"","url":"https://api.github.com/users/alxhub","html_url":"https://github.com/alxhub","followers_url":"https://api.github.com/users/alxhub/followers","following_url":"https://api.github.com/users/alxhub/following{/other_user}","gists_url":"https://api.github.com/users/alxhub/gists{/gist_id}","starred_url":"https://api.github.com/users/alxhub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alxhub/subscriptions","organizations_url":"https://api.github.com/users/alxhub/orgs","repos_url":"https://api.github.com/users/alxhub/repos","events_url":"https://api.github.com/users/alxhub/events{/privacy}","received_events_url":"https://api.github.com/users/alxhub/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alxhub/angular","description":null,"fork":true,"url":"https://api.github.com/repos/alxhub/angular","forks_url":"https://api.github.com/repos/alxhub/angular/forks","keys_url":"https://api.github.com/repos/alxhub/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alxhub/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alxhub/angular/teams","hooks_url":"https://api.github.com/repos/alxhub/angular/hooks","issue_events_url":"https://api.github.com/repos/alxhub/angular/issues/events{/number}","events_url":"https://api.github.com/repos/alxhub/angular/events","assignees_url":"https://api.github.com/repos/alxhub/angular/assignees{/user}","branches_url":"https://api.github.com/repos/alxhub/angular/branches{/branch}","tags_url":"https://api.github.com/repos/alxhub/angular/tags","blobs_url":"https://api.github.com/repos/alxhub/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alxhub/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alxhub/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/alxhub/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alxhub/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/alxhub/angular/languages","stargazers_url":"https://api.github.com/repos/alxhub/angular/stargazers","contributors_url":"https://api.github.com/repos/alxhub/angular/contributors","subscribers_url":"https://api.github.com/repos/alxhub/angular/subscribers","subscription_url":"https://api.github.com/repos/alxhub/angular/subscription","commits_url":"https://api.github.com/repos/alxhub/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/alxhub/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/alxhub/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/alxhub/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/alxhub/angular/contents/{+path}","compare_url":"https://api.github.com/repos/alxhub/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alxhub/angular/merges","archive_url":"https://api.github.com/repos/alxhub/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alxhub/angular/downloads","issues_url":"https://api.github.com/repos/alxhub/angular/issues{/number}","pulls_url":"https://api.github.com/repos/alxhub/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/alxhub/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/alxhub/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alxhub/angular/labels{/name}","releases_url":"https://api.github.com/repos/alxhub/angular/releases{/id}","deployments_url":"https://api.github.com/repos/alxhub/angular/deployments","created_at":"2015-05-11T19:08:26Z","updated_at":"2016-01-25T22:09:11Z","pushed_at":"2017-06-22T18:35:11Z","git_url":"git://github.com/alxhub/angular.git","ssh_url":"git@github.com:alxhub/angular.git","clone_url":"https://github.com/alxhub/angular.git","svn_url":"https://github.com/alxhub/angular","homepage":null,"size":59100,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"1fc0d055651f94cf60419ab102b96801ca9bec9e","user":{"login":"angular","id":139426,"avatar_url":"https://avatars0.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":24195339,"name":"angular","full_name":"angular/angular","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars0.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/angular","description":"One framework. Mobile & desktop.","fork":false,"url":"https://api.github.com/repos/angular/angular","forks_url":"https://api.github.com/repos/angular/angular/forks","keys_url":"https://api.github.com/repos/angular/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/angular/teams","hooks_url":"https://api.github.com/repos/angular/angular/hooks","issue_events_url":"https://api.github.com/repos/angular/angular/issues/events{/number}","events_url":"https://api.github.com/repos/angular/angular/events","assignees_url":"https://api.github.com/repos/angular/angular/assignees{/user}","branches_url":"https://api.github.com/repos/angular/angular/branches{/branch}","tags_url":"https://api.github.com/repos/angular/angular/tags","blobs_url":"https://api.github.com/repos/angular/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/angular/languages","stargazers_url":"https://api.github.com/repos/angular/angular/stargazers","contributors_url":"https://api.github.com/repos/angular/angular/contributors","subscribers_url":"https://api.github.com/repos/angular/angular/subscribers","subscription_url":"https://api.github.com/repos/angular/angular/subscription","commits_url":"https://api.github.com/repos/angular/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/angular/contents/{+path}","compare_url":"https://api.github.com/repos/angular/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/angular/merges","archive_url":"https://api.github.com/repos/angular/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/angular/downloads","issues_url":"https://api.github.com/repos/angular/angular/issues{/number}","pulls_url":"https://api.github.com/repos/angular/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/angular/labels{/name}","releases_url":"https://api.github.com/repos/angular/angular/releases{/id}","deployments_url":"https://api.github.com/repos/angular/angular/deployments","created_at":"2014-09-18T16:12:01Z","updated_at":"2017-06-23T20:22:16Z","pushed_at":"2017-06-23T20:09:26Z","git_url":"git://github.com/angular/angular.git","ssh_url":"git@github.com:angular/angular.git","clone_url":"https://github.com/angular/angular.git","svn_url":"https://github.com/angular/angular","homepage":"https://angular.io","size":535423,"stargazers_count":25231,"watchers_count":25231,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6436,"mirror_url":null,"open_issues_count":1719,"forks":6436,"open_issues":1719,"watchers":25231,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/17276"},"html":{"href":"https://github.com/angular/angular/pull/17276"},"issue":{"href":"https://api.github.com/repos/angular/angular/issues/17276"},"comments":{"href":"https://api.github.com/repos/angular/angular/issues/17276/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/angular/pulls/17276/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/angular/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/angular/pulls/17276/commits"},"statuses":{"href":"https://api.github.com/repos/angular/angular/statuses/8763b6d6a4ded29febc1569ec67339ea82562824"}}}}
{"actor":{"display_login":"IgorMinar"}}