{"action":"closed","number":136,"pull_request":{"url":"https://api.github.com/repos/EgorBo/Toasts.Forms.Plugin/pulls/136","id":147821051,"html_url":"https://github.com/EgorBo/Toasts.Forms.Plugin/pull/136","diff_url":"https://github.com/EgorBo/Toasts.Forms.Plugin/pull/136.diff","patch_url":"https://github.com/EgorBo/Toasts.Forms.Plugin/pull/136.patch","issue_url":"https://api.github.com/repos/EgorBo/Toasts.Forms.Plugin/issues/136","number":136,"state":"closed","locked":false,"title":"Android bugfixes and general improvements, as well as updates for Android 8 (Oreo).","user":{"login":"knxrb","id":837635,"avatar_url":"https://avatars3.githubusercontent.com/u/837635?v=4","gravatar_id":"","url":"https://api.github.com/users/knxrb","html_url":"https://github.com/knxrb","followers_url":"https://api.github.com/users/knxrb/followers","following_url":"https://api.github.com/users/knxrb/following{/other_user}","gists_url":"https://api.github.com/users/knxrb/gists{/gist_id}","starred_url":"https://api.github.com/users/knxrb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knxrb/subscriptions","organizations_url":"https://api.github.com/users/knxrb/orgs","repos_url":"https://api.github.com/users/knxrb/repos","events_url":"https://api.github.com/users/knxrb/events{/privacy}","received_events_url":"https://api.github.com/users/knxrb/received_events","type":"User","site_admin":false},"body":"**Description:**\r\nPull request for improvements and bugfixes I've come across while using this plugin in our app. Also adds support for Android 8 (Oreo), with the channels and badges, as well as specifying the colour for the notification in Android.\r\n\r\n**Fixes:**\r\n- #137\r\n- #134 \r\n- #127 \r\n- Also fixes a bug in Android where tapping a local notification does nothing if Android has currently, or previously, grouped them together in the notifications tray area.\r\n\r\n**My Changes (Android & Sample projects):**\r\n- Added support for setting the notification channels in Android Oreo and above, with a default fallback channel, and support for enabling vibration, and showing the badge dot above the app icon.\r\n- Added support for setting the colour for the Android notifications.\r\n- Added a new option to the Android local notifications to make it attempt to bring focus back to the app when tapped. (Note: This gives best results when the MainLauncher Activity has a LaunchMode of SingleTop.)\r\n- Added click Intent to Android scheduled local notifications to allow them to re-focus/open the app on tap as well.\r\n- ~~Added two helpful debug options for Android; one for showing the internal notification id at the beginning of the notification title, and another to display a toast with the internal notification id and result (when a notification is tapped).~~\r\n- Made the Android NotificationBuilder code more stable.\r\n- Changed the notification result to return the Id as well as the Action.\r\n- Updated the Target Framework Version to 8.0.\r\n- Updated the Xamarin Forms version from 2.3.0.46-pre3 to 2.3.4.270.\r\n- Updated the Sample app so it runs with newer versions of Visual Studio for Mac & VS 2017, and shows an example of setting the Android notification colour, etc.\r\n\r\n_No changes have been made to iOS or UWP, other than the UWP csproj formats (so it loads in VS 2017)._\r\n\r\nHopefully this is useful, and if you have any suggestions, queries, or changes, please let me know.","created_at":"2017-10-20T14:57:01Z","updated_at":"2017-11-25T06:33:49Z","closed_at":"2017-11-25T06:33:49Z","merged_at":"2017-11-25T06:33:49Z","merge_commit_sha":"f236e02c307966020997d469b4d11058a2132ec1","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/EgorBo/Toasts.Forms.Plugin/pulls/136/commits","review_comments_url":"https://api.github.com/repos/EgorBo/Toasts.Forms.Plugin/pulls/136/comments","review_comment_url":"https://api.github.com/repos/EgorBo/Toasts.Forms.Plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/EgorBo/Toasts.Forms.Plugin/issues/136/comments","statuses_url":"https://api.github.com/repos/EgorBo/Toasts.Forms.Plugin/statuses/f236e02c307966020997d469b4d11058a2132ec1","head":{"label":"knxrb:master","ref":"master","sha":"f236e02c307966020997d469b4d11058a2132ec1","user":{"login":"knxrb","id":837635,"avatar_url":"https://avatars3.githubusercontent.com/u/837635?v=4","gravatar_id":"","url":"https://api.github.com/users/knxrb","html_url":"https://github.com/knxrb","followers_url":"https://api.github.com/users/knxrb/followers","following_url":"https://api.github.com/users/knxrb/following{/other_user}","gists_url":"https://api.github.com/users/knxrb/gists{/gist_id}","starred_url":"https://api.github.com/users/knxrb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knxrb/subscriptions","organizations_url":"https://api.github.com/users/knxrb/orgs","repos_url":"https://api.github.com/users/knxrb/repos","events_url":"https://api.github.com/users/knxrb/events{/privacy}","received_events_url":"https://api.github.com/users/knxrb/received_events","type":"User","site_admin":false},"repo":{"id":107520285,"name":"Toasts.Forms.Plugin","full_name":"knxrb/Toasts.Forms.Plugin","owner":{"login":"knxrb","id":837635,"avatar_url":"https://avatars3.githubusercontent.com/u/837635?v=4","gravatar_id":"","url":"https://api.github.com/users/knxrb","html_url":"https://github.com/knxrb","followers_url":"https://api.github.com/users/knxrb/followers","following_url":"https://api.github.com/users/knxrb/following{/other_user}","gists_url":"https://api.github.com/users/knxrb/gists{/gist_id}","starred_url":"https://api.github.com/users/knxrb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knxrb/subscriptions","organizations_url":"https://api.github.com/users/knxrb/orgs","repos_url":"https://api.github.com/users/knxrb/repos","events_url":"https://api.github.com/users/knxrb/events{/privacy}","received_events_url":"https://api.github.com/users/knxrb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/knxrb/Toasts.Forms.Plugin","description":"A plugin for Xamarin and Windows - it unites Crouton (Android), TWMessageBarManager (iOS) and my toast notificator for WP8. ","fork":true,"url":"https://api.github.com/repos/knxrb/Toasts.Forms.Plugin","forks_url":"https://api.github.com/repos/knxrb/Toasts.Forms.Plugin/forks","keys_url":"https://api.github.com/repos/knxrb/Toasts.Forms.Plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/knxrb/Toasts.Forms.Plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/knxrb/Toasts.Forms.Plugin/teams","hooks_url":"https://api.github.com/repos/knxrb/Toasts.Forms.Plugin/hooks","issue_events_url":"https://api.github.com/repos/knxrb/Toasts.Forms.Plugin/issues/events{/number}","events_url":"https://api.github.com/repos/knxrb/Toasts.Forms.Plugin/events","assignees_url":"https://api.github.com/repos/knxrb/Toasts.Forms.Plugin/assignees{/user}","branches_url":"https://api.github.com/repos/knxrb/Toasts.Forms.Plugin/branches{/branch}","tags_url":"https://api.github.com/repos/knxrb/Toasts.Forms.Plugin/tags","blobs_url":"https://api.github.com/repos/knxrb/Toasts.Forms.Plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/knxrb/Toasts.Forms.Plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/knxrb/Toasts.Forms.Plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/knxrb/Toasts.Forms.Plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/knxrb/Toasts.Forms.Plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/knxrb/Toasts.Forms.Plugin/languages","stargazers_url":"https://api.github.com/repos/knxrb/Toasts.Forms.Plugin/stargazers","contributors_url":"https://api.github.com/repos/knxrb/Toasts.Forms.Plugin/contributors","subscribers_url":"https://api.github.com/repos/knxrb/Toasts.Forms.Plugin/subscribers","subscription_url":"https://api.github.com/repos/knxrb/Toasts.Forms.Plugin/subscription","commits_url":"https://api.github.com/repos/knxrb/Toasts.Forms.Plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/knxrb/Toasts.Forms.Plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/knxrb/Toasts.Forms.Plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/knxrb/Toasts.Forms.Plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/knxrb/Toasts.Forms.Plugin/contents/{+path}","compare_url":"https://api.github.com/repos/knxrb/Toasts.Forms.Plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/knxrb/Toasts.Forms.Plugin/merges","archive_url":"https://api.github.com/repos/knxrb/Toasts.Forms.Plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/knxrb/Toasts.Forms.Plugin/downloads","issues_url":"https://api.github.com/repos/knxrb/Toasts.Forms.Plugin/issues{/number}","pulls_url":"https://api.github.com/repos/knxrb/Toasts.Forms.Plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/knxrb/Toasts.Forms.Plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/knxrb/Toasts.Forms.Plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/knxrb/Toasts.Forms.Plugin/labels{/name}","releases_url":"https://api.github.com/repos/knxrb/Toasts.Forms.Plugin/releases{/id}","deployments_url":"https://api.github.com/repos/knxrb/Toasts.Forms.Plugin/deployments","created_at":"2017-10-19T08:38:46Z","updated_at":"2017-10-19T08:38:48Z","pushed_at":"2017-10-23T08:45:10Z","git_url":"git://github.com/knxrb/Toasts.Forms.Plugin.git","ssh_url":"git@github.com:knxrb/Toasts.Forms.Plugin.git","clone_url":"https://github.com/knxrb/Toasts.Forms.Plugin.git","svn_url":"https://github.com/knxrb/Toasts.Forms.Plugin","homepage":"","size":5835,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"EgorBo:master","ref":"master","sha":"b56211d61c638a944ac24928f2fe9d560a273dbe","user":{"login":"EgorBo","id":523221,"avatar_url":"https://avatars0.githubusercontent.com/u/523221?v=4","gravatar_id":"","url":"https://api.github.com/users/EgorBo","html_url":"https://github.com/EgorBo","followers_url":"https://api.github.com/users/EgorBo/followers","following_url":"https://api.github.com/users/EgorBo/following{/other_user}","gists_url":"https://api.github.com/users/EgorBo/gists{/gist_id}","starred_url":"https://api.github.com/users/EgorBo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EgorBo/subscriptions","organizations_url":"https://api.github.com/users/EgorBo/orgs","repos_url":"https://api.github.com/users/EgorBo/repos","events_url":"https://api.github.com/users/EgorBo/events{/privacy}","received_events_url":"https://api.github.com/users/EgorBo/received_events","type":"User","site_admin":false},"repo":{"id":28774229,"name":"Toasts.Forms.Plugin","full_name":"EgorBo/Toasts.Forms.Plugin","owner":{"login":"EgorBo","id":523221,"avatar_url":"https://avatars0.githubusercontent.com/u/523221?v=4","gravatar_id":"","url":"https://api.github.com/users/EgorBo","html_url":"https://github.com/EgorBo","followers_url":"https://api.github.com/users/EgorBo/followers","following_url":"https://api.github.com/users/EgorBo/following{/other_user}","gists_url":"https://api.github.com/users/EgorBo/gists{/gist_id}","starred_url":"https://api.github.com/users/EgorBo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EgorBo/subscriptions","organizations_url":"https://api.github.com/users/EgorBo/orgs","repos_url":"https://api.github.com/users/EgorBo/repos","events_url":"https://api.github.com/users/EgorBo/events{/privacy}","received_events_url":"https://api.github.com/users/EgorBo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/EgorBo/Toasts.Forms.Plugin","description":"A plugin for Xamarin and Windows - it unites Crouton (Android), TWMessageBarManager (iOS) and my toast notificator for WP8. ","fork":false,"url":"https://api.github.com/repos/EgorBo/Toasts.Forms.Plugin","forks_url":"https://api.github.com/repos/EgorBo/Toasts.Forms.Plugin/forks","keys_url":"https://api.github.com/repos/EgorBo/Toasts.Forms.Plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EgorBo/Toasts.Forms.Plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EgorBo/Toasts.Forms.Plugin/teams","hooks_url":"https://api.github.com/repos/EgorBo/Toasts.Forms.Plugin/hooks","issue_events_url":"https://api.github.com/repos/EgorBo/Toasts.Forms.Plugin/issues/events{/number}","events_url":"https://api.github.com/repos/EgorBo/Toasts.Forms.Plugin/events","assignees_url":"https://api.github.com/repos/EgorBo/Toasts.Forms.Plugin/assignees{/user}","branches_url":"https://api.github.com/repos/EgorBo/Toasts.Forms.Plugin/branches{/branch}","tags_url":"https://api.github.com/repos/EgorBo/Toasts.Forms.Plugin/tags","blobs_url":"https://api.github.com/repos/EgorBo/Toasts.Forms.Plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EgorBo/Toasts.Forms.Plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EgorBo/Toasts.Forms.Plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/EgorBo/Toasts.Forms.Plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EgorBo/Toasts.Forms.Plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/EgorBo/Toasts.Forms.Plugin/languages","stargazers_url":"https://api.github.com/repos/EgorBo/Toasts.Forms.Plugin/stargazers","contributors_url":"https://api.github.com/repos/EgorBo/Toasts.Forms.Plugin/contributors","subscribers_url":"https://api.github.com/repos/EgorBo/Toasts.Forms.Plugin/subscribers","subscription_url":"https://api.github.com/repos/EgorBo/Toasts.Forms.Plugin/subscription","commits_url":"https://api.github.com/repos/EgorBo/Toasts.Forms.Plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/EgorBo/Toasts.Forms.Plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/EgorBo/Toasts.Forms.Plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/EgorBo/Toasts.Forms.Plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/EgorBo/Toasts.Forms.Plugin/contents/{+path}","compare_url":"https://api.github.com/repos/EgorBo/Toasts.Forms.Plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EgorBo/Toasts.Forms.Plugin/merges","archive_url":"https://api.github.com/repos/EgorBo/Toasts.Forms.Plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EgorBo/Toasts.Forms.Plugin/downloads","issues_url":"https://api.github.com/repos/EgorBo/Toasts.Forms.Plugin/issues{/number}","pulls_url":"https://api.github.com/repos/EgorBo/Toasts.Forms.Plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/EgorBo/Toasts.Forms.Plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/EgorBo/Toasts.Forms.Plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EgorBo/Toasts.Forms.Plugin/labels{/name}","releases_url":"https://api.github.com/repos/EgorBo/Toasts.Forms.Plugin/releases{/id}","deployments_url":"https://api.github.com/repos/EgorBo/Toasts.Forms.Plugin/deployments","created_at":"2015-01-04T12:57:55Z","updated_at":"2017-11-23T01:21:31Z","pushed_at":"2017-11-25T06:33:49Z","git_url":"git://github.com/EgorBo/Toasts.Forms.Plugin.git","ssh_url":"git@github.com:EgorBo/Toasts.Forms.Plugin.git","clone_url":"https://github.com/EgorBo/Toasts.Forms.Plugin.git","svn_url":"https://github.com/EgorBo/Toasts.Forms.Plugin","homepage":"","size":5846,"stargazers_count":176,"watchers_count":176,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":55,"mirror_url":null,"archived":false,"open_issues_count":13,"forks":55,"open_issues":13,"watchers":176,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/EgorBo/Toasts.Forms.Plugin/pulls/136"},"html":{"href":"https://github.com/EgorBo/Toasts.Forms.Plugin/pull/136"},"issue":{"href":"https://api.github.com/repos/EgorBo/Toasts.Forms.Plugin/issues/136"},"comments":{"href":"https://api.github.com/repos/EgorBo/Toasts.Forms.Plugin/issues/136/comments"},"review_comments":{"href":"https://api.github.com/repos/EgorBo/Toasts.Forms.Plugin/pulls/136/comments"},"review_comment":{"href":"https://api.github.com/repos/EgorBo/Toasts.Forms.Plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/EgorBo/Toasts.Forms.Plugin/pulls/136/commits"},"statuses":{"href":"https://api.github.com/repos/EgorBo/Toasts.Forms.Plugin/statuses/f236e02c307966020997d469b4d11058a2132ec1"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"adamped","id":13672662,"avatar_url":"https://avatars2.githubusercontent.com/u/13672662?v=4","gravatar_id":"","url":"https://api.github.com/users/adamped","html_url":"https://github.com/adamped","followers_url":"https://api.github.com/users/adamped/followers","following_url":"https://api.github.com/users/adamped/following{/other_user}","gists_url":"https://api.github.com/users/adamped/gists{/gist_id}","starred_url":"https://api.github.com/users/adamped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamped/subscriptions","organizations_url":"https://api.github.com/users/adamped/orgs","repos_url":"https://api.github.com/users/adamped/repos","events_url":"https://api.github.com/users/adamped/events{/privacy}","received_events_url":"https://api.github.com/users/adamped/received_events","type":"User","site_admin":false},"comments":1,"review_comments":7,"maintainer_can_modify":false,"commits":4,"additions":5641,"deletions":34455,"changed_files":29}}
{"actor":{"display_login":"adamped"}}