{"action":"created","comment":{"url":"https://api.github.com/repos/paritytech/parity/pulls/comments/106385202","pull_request_review_id":27302815,"id":106385202,"diff_hunk":"@@ -261,17 +261,23 @@ impl<'a, B: 'a + StateBackend> Executive<'a, B> {\n \t\t}\n \t\ttrace!(\"Executive::call(params={:?}) self.env_info={:?}\", params, self.info);\n \n-\t\tif self.engine.is_builtin(&params.code_address) {\n-\t\t\t// if destination is builtin, try to execute it\n+\t\t// if destination is builtin, try to execute it\n+\t\tif let Some(builtin) = self.engine.builtin(&params.code_address, self.info.number) {\n+\t\t\t// Engines aren't supposed to return builtins until activation, but\n+\t\t\t// prefer to fail rather than silently break consensus.\n+\t\t\tif !builtin.is_active(self.info.number) {\n+\t\t\t\tlet msg = format!(\"Engine returned unactivated built-in at {}\", params.code_address);\n+\t\t\t\treturn Err(evm::Error::Internal(msg));","path":"ethcore/src/executive.rs","position":12,"original_position":12,"commit_id":"aed1b2088683d5ebe98b644de03a3952e413ce6d","original_commit_id":"aed1b2088683d5ebe98b644de03a3952e413ce6d","user":{"login":"rphmeier","id":10121380,"avatar_url":"https://avatars2.githubusercontent.com/u/10121380?v=3","gravatar_id":"","url":"https://api.github.com/users/rphmeier","html_url":"https://github.com/rphmeier","followers_url":"https://api.github.com/users/rphmeier/followers","following_url":"https://api.github.com/users/rphmeier/following{/other_user}","gists_url":"https://api.github.com/users/rphmeier/gists{/gist_id}","starred_url":"https://api.github.com/users/rphmeier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rphmeier/subscriptions","organizations_url":"https://api.github.com/users/rphmeier/orgs","repos_url":"https://api.github.com/users/rphmeier/repos","events_url":"https://api.github.com/users/rphmeier/events{/privacy}","received_events_url":"https://api.github.com/users/rphmeier/received_events","type":"User","site_admin":false},"body":"Nice catch. It should be done with a `Drop` guard to prevent mistakes like that.","created_at":"2017-03-16T10:39:27Z","updated_at":"2017-03-16T10:39:27Z","html_url":"https://github.com/paritytech/parity/pull/4926#discussion_r106385202","pull_request_url":"https://api.github.com/repos/paritytech/parity/pulls/4926","_links":{"self":{"href":"https://api.github.com/repos/paritytech/parity/pulls/comments/106385202"},"html":{"href":"https://github.com/paritytech/parity/pull/4926#discussion_r106385202"},"pull_request":{"href":"https://api.github.com/repos/paritytech/parity/pulls/4926"}}},"pull_request":{"url":"https://api.github.com/repos/paritytech/parity/pulls/4926","id":110917203,"html_url":"https://github.com/paritytech/parity/pull/4926","diff_url":"https://github.com/paritytech/parity/pull/4926.diff","patch_url":"https://github.com/paritytech/parity/pull/4926.patch","issue_url":"https://api.github.com/repos/paritytech/parity/issues/4926","number":4926,"state":"open","locked":false,"title":"EIP198 and built-in activation","user":{"login":"rphmeier","id":10121380,"avatar_url":"https://avatars2.githubusercontent.com/u/10121380?v=3","gravatar_id":"","url":"https://api.github.com/users/rphmeier","html_url":"https://github.com/rphmeier","followers_url":"https://api.github.com/users/rphmeier/followers","following_url":"https://api.github.com/users/rphmeier/following{/other_user}","gists_url":"https://api.github.com/users/rphmeier/gists{/gist_id}","starred_url":"https://api.github.com/users/rphmeier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rphmeier/subscriptions","organizations_url":"https://api.github.com/users/rphmeier/orgs","repos_url":"https://api.github.com/users/rphmeier/repos","events_url":"https://api.github.com/users/rphmeier/events{/privacy}","received_events_url":"https://api.github.com/users/rphmeier/received_events","type":"User","site_admin":false},"body":"Implements [EIP198](https://github.com/ethereum/EIPs/pull/198) with exponentiation by squaring.\r\n\r\nChanges to built-in declaration: optional `activate_at` field, defaults to 0. Built-ins won't be available  from the `Engine` until activated. Replaces the `builtin_cost`, `execute_builtin`, and `is_builtin` of engine with a single `builtin(&Address, block_number) -> Option<&Builtin>`, reducing the amount of lookups done.\r\n\r\nCould use a few more test cases, although I expect the consensus tests will cover this in detail.\r\n\r\n`num::BigUint` is known to be much slower than GMP. `ramp` is a faster pure-Rust alternative, but requires nightly. If this calculation starts to become a bottleneck, we can move to GMP.","created_at":"2017-03-15T18:52:31Z","updated_at":"2017-03-16T10:39:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"26e92b36aa9adce81b454b9cb2401c40fe4ab32f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/paritytech/parity/pulls/4926/commits","review_comments_url":"https://api.github.com/repos/paritytech/parity/pulls/4926/comments","review_comment_url":"https://api.github.com/repos/paritytech/parity/pulls/comments{/number}","comments_url":"https://api.github.com/repos/paritytech/parity/issues/4926/comments","statuses_url":"https://api.github.com/repos/paritytech/parity/statuses/aed1b2088683d5ebe98b644de03a3952e413ce6d","head":{"label":"paritytech:eip198","ref":"eip198","sha":"aed1b2088683d5ebe98b644de03a3952e413ce6d","user":{"login":"paritytech","id":14176906,"avatar_url":"https://avatars1.githubusercontent.com/u/14176906?v=3","gravatar_id":"","url":"https://api.github.com/users/paritytech","html_url":"https://github.com/paritytech","followers_url":"https://api.github.com/users/paritytech/followers","following_url":"https://api.github.com/users/paritytech/following{/other_user}","gists_url":"https://api.github.com/users/paritytech/gists{/gist_id}","starred_url":"https://api.github.com/users/paritytech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paritytech/subscriptions","organizations_url":"https://api.github.com/users/paritytech/orgs","repos_url":"https://api.github.com/users/paritytech/repos","events_url":"https://api.github.com/users/paritytech/events{/privacy}","received_events_url":"https://api.github.com/users/paritytech/received_events","type":"Organization","site_admin":false},"repo":{"id":46714939,"name":"parity","full_name":"paritytech/parity","owner":{"login":"paritytech","id":14176906,"avatar_url":"https://avatars1.githubusercontent.com/u/14176906?v=3","gravatar_id":"","url":"https://api.github.com/users/paritytech","html_url":"https://github.com/paritytech","followers_url":"https://api.github.com/users/paritytech/followers","following_url":"https://api.github.com/users/paritytech/following{/other_user}","gists_url":"https://api.github.com/users/paritytech/gists{/gist_id}","starred_url":"https://api.github.com/users/paritytech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paritytech/subscriptions","organizations_url":"https://api.github.com/users/paritytech/orgs","repos_url":"https://api.github.com/users/paritytech/repos","events_url":"https://api.github.com/users/paritytech/events{/privacy}","received_events_url":"https://api.github.com/users/paritytech/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/paritytech/parity","description":"Fast, light, robust Ethereum implementation","fork":false,"url":"https://api.github.com/repos/paritytech/parity","forks_url":"https://api.github.com/repos/paritytech/parity/forks","keys_url":"https://api.github.com/repos/paritytech/parity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paritytech/parity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paritytech/parity/teams","hooks_url":"https://api.github.com/repos/paritytech/parity/hooks","issue_events_url":"https://api.github.com/repos/paritytech/parity/issues/events{/number}","events_url":"https://api.github.com/repos/paritytech/parity/events","assignees_url":"https://api.github.com/repos/paritytech/parity/assignees{/user}","branches_url":"https://api.github.com/repos/paritytech/parity/branches{/branch}","tags_url":"https://api.github.com/repos/paritytech/parity/tags","blobs_url":"https://api.github.com/repos/paritytech/parity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paritytech/parity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paritytech/parity/git/refs{/sha}","trees_url":"https://api.github.com/repos/paritytech/parity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paritytech/parity/statuses/{sha}","languages_url":"https://api.github.com/repos/paritytech/parity/languages","stargazers_url":"https://api.github.com/repos/paritytech/parity/stargazers","contributors_url":"https://api.github.com/repos/paritytech/parity/contributors","subscribers_url":"https://api.github.com/repos/paritytech/parity/subscribers","subscription_url":"https://api.github.com/repos/paritytech/parity/subscription","commits_url":"https://api.github.com/repos/paritytech/parity/commits{/sha}","git_commits_url":"https://api.github.com/repos/paritytech/parity/git/commits{/sha}","comments_url":"https://api.github.com/repos/paritytech/parity/comments{/number}","issue_comment_url":"https://api.github.com/repos/paritytech/parity/issues/comments{/number}","contents_url":"https://api.github.com/repos/paritytech/parity/contents/{+path}","compare_url":"https://api.github.com/repos/paritytech/parity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paritytech/parity/merges","archive_url":"https://api.github.com/repos/paritytech/parity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paritytech/parity/downloads","issues_url":"https://api.github.com/repos/paritytech/parity/issues{/number}","pulls_url":"https://api.github.com/repos/paritytech/parity/pulls{/number}","milestones_url":"https://api.github.com/repos/paritytech/parity/milestones{/number}","notifications_url":"https://api.github.com/repos/paritytech/parity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paritytech/parity/labels{/name}","releases_url":"https://api.github.com/repos/paritytech/parity/releases{/id}","deployments_url":"https://api.github.com/repos/paritytech/parity/deployments","created_at":"2015-11-23T11:07:32Z","updated_at":"2017-03-16T10:17:36Z","pushed_at":"2017-03-16T09:34:15Z","git_url":"git://github.com/paritytech/parity.git","ssh_url":"git@github.com:paritytech/parity.git","clone_url":"https://github.com/paritytech/parity.git","svn_url":"https://github.com/paritytech/parity","homepage":"","size":84297,"stargazers_count":862,"watchers_count":862,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":185,"mirror_url":null,"open_issues_count":345,"forks":185,"open_issues":345,"watchers":862,"default_branch":"master"}},"base":{"label":"paritytech:master","ref":"master","sha":"790bd87bc343d2d5318d3b169a5d822e5350f6c1","user":{"login":"paritytech","id":14176906,"avatar_url":"https://avatars1.githubusercontent.com/u/14176906?v=3","gravatar_id":"","url":"https://api.github.com/users/paritytech","html_url":"https://github.com/paritytech","followers_url":"https://api.github.com/users/paritytech/followers","following_url":"https://api.github.com/users/paritytech/following{/other_user}","gists_url":"https://api.github.com/users/paritytech/gists{/gist_id}","starred_url":"https://api.github.com/users/paritytech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paritytech/subscriptions","organizations_url":"https://api.github.com/users/paritytech/orgs","repos_url":"https://api.github.com/users/paritytech/repos","events_url":"https://api.github.com/users/paritytech/events{/privacy}","received_events_url":"https://api.github.com/users/paritytech/received_events","type":"Organization","site_admin":false},"repo":{"id":46714939,"name":"parity","full_name":"paritytech/parity","owner":{"login":"paritytech","id":14176906,"avatar_url":"https://avatars1.githubusercontent.com/u/14176906?v=3","gravatar_id":"","url":"https://api.github.com/users/paritytech","html_url":"https://github.com/paritytech","followers_url":"https://api.github.com/users/paritytech/followers","following_url":"https://api.github.com/users/paritytech/following{/other_user}","gists_url":"https://api.github.com/users/paritytech/gists{/gist_id}","starred_url":"https://api.github.com/users/paritytech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paritytech/subscriptions","organizations_url":"https://api.github.com/users/paritytech/orgs","repos_url":"https://api.github.com/users/paritytech/repos","events_url":"https://api.github.com/users/paritytech/events{/privacy}","received_events_url":"https://api.github.com/users/paritytech/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/paritytech/parity","description":"Fast, light, robust Ethereum implementation","fork":false,"url":"https://api.github.com/repos/paritytech/parity","forks_url":"https://api.github.com/repos/paritytech/parity/forks","keys_url":"https://api.github.com/repos/paritytech/parity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paritytech/parity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paritytech/parity/teams","hooks_url":"https://api.github.com/repos/paritytech/parity/hooks","issue_events_url":"https://api.github.com/repos/paritytech/parity/issues/events{/number}","events_url":"https://api.github.com/repos/paritytech/parity/events","assignees_url":"https://api.github.com/repos/paritytech/parity/assignees{/user}","branches_url":"https://api.github.com/repos/paritytech/parity/branches{/branch}","tags_url":"https://api.github.com/repos/paritytech/parity/tags","blobs_url":"https://api.github.com/repos/paritytech/parity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paritytech/parity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paritytech/parity/git/refs{/sha}","trees_url":"https://api.github.com/repos/paritytech/parity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paritytech/parity/statuses/{sha}","languages_url":"https://api.github.com/repos/paritytech/parity/languages","stargazers_url":"https://api.github.com/repos/paritytech/parity/stargazers","contributors_url":"https://api.github.com/repos/paritytech/parity/contributors","subscribers_url":"https://api.github.com/repos/paritytech/parity/subscribers","subscription_url":"https://api.github.com/repos/paritytech/parity/subscription","commits_url":"https://api.github.com/repos/paritytech/parity/commits{/sha}","git_commits_url":"https://api.github.com/repos/paritytech/parity/git/commits{/sha}","comments_url":"https://api.github.com/repos/paritytech/parity/comments{/number}","issue_comment_url":"https://api.github.com/repos/paritytech/parity/issues/comments{/number}","contents_url":"https://api.github.com/repos/paritytech/parity/contents/{+path}","compare_url":"https://api.github.com/repos/paritytech/parity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paritytech/parity/merges","archive_url":"https://api.github.com/repos/paritytech/parity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paritytech/parity/downloads","issues_url":"https://api.github.com/repos/paritytech/parity/issues{/number}","pulls_url":"https://api.github.com/repos/paritytech/parity/pulls{/number}","milestones_url":"https://api.github.com/repos/paritytech/parity/milestones{/number}","notifications_url":"https://api.github.com/repos/paritytech/parity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paritytech/parity/labels{/name}","releases_url":"https://api.github.com/repos/paritytech/parity/releases{/id}","deployments_url":"https://api.github.com/repos/paritytech/parity/deployments","created_at":"2015-11-23T11:07:32Z","updated_at":"2017-03-16T10:17:36Z","pushed_at":"2017-03-16T09:34:15Z","git_url":"git://github.com/paritytech/parity.git","ssh_url":"git@github.com:paritytech/parity.git","clone_url":"https://github.com/paritytech/parity.git","svn_url":"https://github.com/paritytech/parity","homepage":"","size":84297,"stargazers_count":862,"watchers_count":862,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":185,"mirror_url":null,"open_issues_count":345,"forks":185,"open_issues":345,"watchers":862,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/paritytech/parity/pulls/4926"},"html":{"href":"https://github.com/paritytech/parity/pull/4926"},"issue":{"href":"https://api.github.com/repos/paritytech/parity/issues/4926"},"comments":{"href":"https://api.github.com/repos/paritytech/parity/issues/4926/comments"},"review_comments":{"href":"https://api.github.com/repos/paritytech/parity/pulls/4926/comments"},"review_comment":{"href":"https://api.github.com/repos/paritytech/parity/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/paritytech/parity/pulls/4926/commits"},"statuses":{"href":"https://api.github.com/repos/paritytech/parity/statuses/aed1b2088683d5ebe98b644de03a3952e413ce6d"}}}}
{"actor":{"display_login":"rphmeier"}}