{"action":"opened","number":348,"pull_request":{"url":"https://api.github.com/repos/rrrene/credo/pulls/348","id":112310696,"html_url":"https://github.com/rrrene/credo/pull/348","diff_url":"https://github.com/rrrene/credo/pull/348.diff","patch_url":"https://github.com/rrrene/credo/pull/348.patch","issue_url":"https://api.github.com/repos/rrrene/credo/issues/348","number":348,"state":"open","locked":false,"title":"Ensure set_lint_attributes warning only shows when necessary","user":{"login":"mcelaney","id":607860,"avatar_url":"https://avatars0.githubusercontent.com/u/607860?v=3","gravatar_id":"","url":"https://api.github.com/users/mcelaney","html_url":"https://github.com/mcelaney","followers_url":"https://api.github.com/users/mcelaney/followers","following_url":"https://api.github.com/users/mcelaney/following{/other_user}","gists_url":"https://api.github.com/users/mcelaney/gists{/gist_id}","starred_url":"https://api.github.com/users/mcelaney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcelaney/subscriptions","organizations_url":"https://api.github.com/users/mcelaney/orgs","repos_url":"https://api.github.com/users/mcelaney/repos","events_url":"https://api.github.com/users/mcelaney/events{/privacy}","received_events_url":"https://api.github.com/users/mcelaney/received_events","type":"User","site_admin":false},"body":"## Background\r\n\r\n### Environment\r\n\r\n* Credo 0.7.1\r\n* Erlang/OTP 19 [erts-8.1] [source] [64-bit] [smp:8:8] [async-threads:10] [hipe] [kernel-poll:false]\r\n* Elixir 1.3.4\r\n* OS/X 10.12.3\r\n\r\n### What were you trying to do?\r\nRun credo in CI - warnings prevent my project from passing.\r\n\r\n### Expected outcome\r\n\r\nIf a project uses @lint we now expect to get a warning:\r\n\r\n```\r\n@lint attributes will be deprecated in the Credo v0.8 because they trigger\r\ncompiler warnings on Elixir v1.4.\r\n\r\nPlease consider reporting the cases where you needed @lint attributes\r\nto help us devise a new solution: https://github.com/rrrene/credo/issues/new\r\n```\r\n\r\nOur project has no @lint attributes - so I expected to get get the warning.\r\n\r\n### Actual outcome\r\n\r\nI get the warning no matter what.\r\n\r\n## Discussion\r\n\r\nThe conditional to display this warning looks for a count on lint_attribute_map - however this map will have keys for every file checked... what we really want here are the number of values to determine whether any files actually use the @link tag.\r\n\r\n## What changed\r\n\r\nFilter the keys to get those with values that are empty lists and show the warning if the resulting list is not empty.\r\n\r\n## QA\r\nThere are no tests for this to update - spin up a project. Add credo. Assert the warning does not appear.  Add a module with a `@lint false` tag (or whatever).  Assert the warning does appear.","created_at":"2017-03-23T18:40:43Z","updated_at":"2017-03-23T18:40:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/rrrene/credo/pulls/348/commits","review_comments_url":"https://api.github.com/repos/rrrene/credo/pulls/348/comments","review_comment_url":"https://api.github.com/repos/rrrene/credo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rrrene/credo/issues/348/comments","statuses_url":"https://api.github.com/repos/rrrene/credo/statuses/7a1f1226b13d031f890d2526cb1007a05f08c8db","head":{"label":"mcelaney:runner-always-warns","ref":"runner-always-warns","sha":"7a1f1226b13d031f890d2526cb1007a05f08c8db","user":{"login":"mcelaney","id":607860,"avatar_url":"https://avatars0.githubusercontent.com/u/607860?v=3","gravatar_id":"","url":"https://api.github.com/users/mcelaney","html_url":"https://github.com/mcelaney","followers_url":"https://api.github.com/users/mcelaney/followers","following_url":"https://api.github.com/users/mcelaney/following{/other_user}","gists_url":"https://api.github.com/users/mcelaney/gists{/gist_id}","starred_url":"https://api.github.com/users/mcelaney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcelaney/subscriptions","organizations_url":"https://api.github.com/users/mcelaney/orgs","repos_url":"https://api.github.com/users/mcelaney/repos","events_url":"https://api.github.com/users/mcelaney/events{/privacy}","received_events_url":"https://api.github.com/users/mcelaney/received_events","type":"User","site_admin":false},"repo":{"id":85199822,"name":"credo","full_name":"mcelaney/credo","owner":{"login":"mcelaney","id":607860,"avatar_url":"https://avatars0.githubusercontent.com/u/607860?v=3","gravatar_id":"","url":"https://api.github.com/users/mcelaney","html_url":"https://github.com/mcelaney","followers_url":"https://api.github.com/users/mcelaney/followers","following_url":"https://api.github.com/users/mcelaney/following{/other_user}","gists_url":"https://api.github.com/users/mcelaney/gists{/gist_id}","starred_url":"https://api.github.com/users/mcelaney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcelaney/subscriptions","organizations_url":"https://api.github.com/users/mcelaney/orgs","repos_url":"https://api.github.com/users/mcelaney/repos","events_url":"https://api.github.com/users/mcelaney/events{/privacy}","received_events_url":"https://api.github.com/users/mcelaney/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mcelaney/credo","description":"A static code analysis tool for the Elixir language with a focus on code consistency and teaching.","fork":true,"url":"https://api.github.com/repos/mcelaney/credo","forks_url":"https://api.github.com/repos/mcelaney/credo/forks","keys_url":"https://api.github.com/repos/mcelaney/credo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mcelaney/credo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mcelaney/credo/teams","hooks_url":"https://api.github.com/repos/mcelaney/credo/hooks","issue_events_url":"https://api.github.com/repos/mcelaney/credo/issues/events{/number}","events_url":"https://api.github.com/repos/mcelaney/credo/events","assignees_url":"https://api.github.com/repos/mcelaney/credo/assignees{/user}","branches_url":"https://api.github.com/repos/mcelaney/credo/branches{/branch}","tags_url":"https://api.github.com/repos/mcelaney/credo/tags","blobs_url":"https://api.github.com/repos/mcelaney/credo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mcelaney/credo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mcelaney/credo/git/refs{/sha}","trees_url":"https://api.github.com/repos/mcelaney/credo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mcelaney/credo/statuses/{sha}","languages_url":"https://api.github.com/repos/mcelaney/credo/languages","stargazers_url":"https://api.github.com/repos/mcelaney/credo/stargazers","contributors_url":"https://api.github.com/repos/mcelaney/credo/contributors","subscribers_url":"https://api.github.com/repos/mcelaney/credo/subscribers","subscription_url":"https://api.github.com/repos/mcelaney/credo/subscription","commits_url":"https://api.github.com/repos/mcelaney/credo/commits{/sha}","git_commits_url":"https://api.github.com/repos/mcelaney/credo/git/commits{/sha}","comments_url":"https://api.github.com/repos/mcelaney/credo/comments{/number}","issue_comment_url":"https://api.github.com/repos/mcelaney/credo/issues/comments{/number}","contents_url":"https://api.github.com/repos/mcelaney/credo/contents/{+path}","compare_url":"https://api.github.com/repos/mcelaney/credo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mcelaney/credo/merges","archive_url":"https://api.github.com/repos/mcelaney/credo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mcelaney/credo/downloads","issues_url":"https://api.github.com/repos/mcelaney/credo/issues{/number}","pulls_url":"https://api.github.com/repos/mcelaney/credo/pulls{/number}","milestones_url":"https://api.github.com/repos/mcelaney/credo/milestones{/number}","notifications_url":"https://api.github.com/repos/mcelaney/credo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mcelaney/credo/labels{/name}","releases_url":"https://api.github.com/repos/mcelaney/credo/releases{/id}","deployments_url":"https://api.github.com/repos/mcelaney/credo/deployments","created_at":"2017-03-16T13:36:24Z","updated_at":"2017-03-16T13:36:26Z","pushed_at":"2017-03-23T18:30:58Z","git_url":"git://github.com/mcelaney/credo.git","ssh_url":"git@github.com:mcelaney/credo.git","clone_url":"https://github.com/mcelaney/credo.git","svn_url":"https://github.com/mcelaney/credo","homepage":"http://credo-ci.org/","size":1395,"stargazers_count":0,"watchers_count":0,"language":"Elixir","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rrrene:master","ref":"master","sha":"84ffff49f164676367f9cde436a78585dbe6dcaa","user":{"login":"rrrene","id":311914,"avatar_url":"https://avatars0.githubusercontent.com/u/311914?v=3","gravatar_id":"","url":"https://api.github.com/users/rrrene","html_url":"https://github.com/rrrene","followers_url":"https://api.github.com/users/rrrene/followers","following_url":"https://api.github.com/users/rrrene/following{/other_user}","gists_url":"https://api.github.com/users/rrrene/gists{/gist_id}","starred_url":"https://api.github.com/users/rrrene/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rrrene/subscriptions","organizations_url":"https://api.github.com/users/rrrene/orgs","repos_url":"https://api.github.com/users/rrrene/repos","events_url":"https://api.github.com/users/rrrene/events{/privacy}","received_events_url":"https://api.github.com/users/rrrene/received_events","type":"User","site_admin":false},"repo":{"id":43247111,"name":"credo","full_name":"rrrene/credo","owner":{"login":"rrrene","id":311914,"avatar_url":"https://avatars0.githubusercontent.com/u/311914?v=3","gravatar_id":"","url":"https://api.github.com/users/rrrene","html_url":"https://github.com/rrrene","followers_url":"https://api.github.com/users/rrrene/followers","following_url":"https://api.github.com/users/rrrene/following{/other_user}","gists_url":"https://api.github.com/users/rrrene/gists{/gist_id}","starred_url":"https://api.github.com/users/rrrene/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rrrene/subscriptions","organizations_url":"https://api.github.com/users/rrrene/orgs","repos_url":"https://api.github.com/users/rrrene/repos","events_url":"https://api.github.com/users/rrrene/events{/privacy}","received_events_url":"https://api.github.com/users/rrrene/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rrrene/credo","description":"A static code analysis tool for the Elixir language with a focus on code consistency and teaching.","fork":false,"url":"https://api.github.com/repos/rrrene/credo","forks_url":"https://api.github.com/repos/rrrene/credo/forks","keys_url":"https://api.github.com/repos/rrrene/credo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rrrene/credo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rrrene/credo/teams","hooks_url":"https://api.github.com/repos/rrrene/credo/hooks","issue_events_url":"https://api.github.com/repos/rrrene/credo/issues/events{/number}","events_url":"https://api.github.com/repos/rrrene/credo/events","assignees_url":"https://api.github.com/repos/rrrene/credo/assignees{/user}","branches_url":"https://api.github.com/repos/rrrene/credo/branches{/branch}","tags_url":"https://api.github.com/repos/rrrene/credo/tags","blobs_url":"https://api.github.com/repos/rrrene/credo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rrrene/credo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rrrene/credo/git/refs{/sha}","trees_url":"https://api.github.com/repos/rrrene/credo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rrrene/credo/statuses/{sha}","languages_url":"https://api.github.com/repos/rrrene/credo/languages","stargazers_url":"https://api.github.com/repos/rrrene/credo/stargazers","contributors_url":"https://api.github.com/repos/rrrene/credo/contributors","subscribers_url":"https://api.github.com/repos/rrrene/credo/subscribers","subscription_url":"https://api.github.com/repos/rrrene/credo/subscription","commits_url":"https://api.github.com/repos/rrrene/credo/commits{/sha}","git_commits_url":"https://api.github.com/repos/rrrene/credo/git/commits{/sha}","comments_url":"https://api.github.com/repos/rrrene/credo/comments{/number}","issue_comment_url":"https://api.github.com/repos/rrrene/credo/issues/comments{/number}","contents_url":"https://api.github.com/repos/rrrene/credo/contents/{+path}","compare_url":"https://api.github.com/repos/rrrene/credo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rrrene/credo/merges","archive_url":"https://api.github.com/repos/rrrene/credo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rrrene/credo/downloads","issues_url":"https://api.github.com/repos/rrrene/credo/issues{/number}","pulls_url":"https://api.github.com/repos/rrrene/credo/pulls{/number}","milestones_url":"https://api.github.com/repos/rrrene/credo/milestones{/number}","notifications_url":"https://api.github.com/repos/rrrene/credo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rrrene/credo/labels{/name}","releases_url":"https://api.github.com/repos/rrrene/credo/releases{/id}","deployments_url":"https://api.github.com/repos/rrrene/credo/deployments","created_at":"2015-09-27T13:16:15Z","updated_at":"2017-03-23T11:43:34Z","pushed_at":"2017-03-22T08:17:24Z","git_url":"git://github.com/rrrene/credo.git","ssh_url":"git@github.com:rrrene/credo.git","clone_url":"https://github.com/rrrene/credo.git","svn_url":"https://github.com/rrrene/credo","homepage":"http://credo-ci.org/","size":1411,"stargazers_count":1729,"watchers_count":1729,"language":"Elixir","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":104,"mirror_url":null,"open_issues_count":40,"forks":104,"open_issues":40,"watchers":1729,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rrrene/credo/pulls/348"},"html":{"href":"https://github.com/rrrene/credo/pull/348"},"issue":{"href":"https://api.github.com/repos/rrrene/credo/issues/348"},"comments":{"href":"https://api.github.com/repos/rrrene/credo/issues/348/comments"},"review_comments":{"href":"https://api.github.com/repos/rrrene/credo/pulls/348/comments"},"review_comment":{"href":"https://api.github.com/repos/rrrene/credo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rrrene/credo/pulls/348/commits"},"statuses":{"href":"https://api.github.com/repos/rrrene/credo/statuses/7a1f1226b13d031f890d2526cb1007a05f08c8db"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"mcelaney"}}