{"action":"created","issue":{"url":"https://api.github.com/repos/moby/moby/issues/22563","repository_url":"https://api.github.com/repos/moby/moby","labels_url":"https://api.github.com/repos/moby/moby/issues/22563/labels{/name}","comments_url":"https://api.github.com/repos/moby/moby/issues/22563/comments","events_url":"https://api.github.com/repos/moby/moby/issues/22563/events","html_url":"https://github.com/moby/moby/pull/22563","id":153552725,"number":22563,"title":"Allow adding rules to cgroup devices.allow on container create/run","user":{"login":"mlaventure","id":16065150,"avatar_url":"https://avatars1.githubusercontent.com/u/16065150?v=4","gravatar_id":"","url":"https://api.github.com/users/mlaventure","html_url":"https://github.com/mlaventure","followers_url":"https://api.github.com/users/mlaventure/followers","following_url":"https://api.github.com/users/mlaventure/following{/other_user}","gists_url":"https://api.github.com/users/mlaventure/gists{/gist_id}","starred_url":"https://api.github.com/users/mlaventure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlaventure/subscriptions","organizations_url":"https://api.github.com/users/mlaventure/orgs","repos_url":"https://api.github.com/users/mlaventure/repos","events_url":"https://api.github.com/users/mlaventure/events{/privacy}","received_events_url":"https://api.github.com/users/mlaventure/received_events","type":"User","site_admin":false},"labels":[{"id":237472255,"url":"https://api.github.com/repos/moby/moby/labels/impact/api","name":"impact/api","color":"bfe5bf","default":false},{"id":237472270,"url":"https://api.github.com/repos/moby/moby/labels/impact/changelog","name":"impact/changelog","color":"bfe5bf","default":false},{"id":237472313,"url":"https://api.github.com/repos/moby/moby/labels/impact/cli","name":"impact/cli","color":"bfe5bf","default":false},{"id":175375520,"url":"https://api.github.com/repos/moby/moby/labels/status/3-docs-review","name":"status/3-docs-review","color":"c7def8","default":false}],"state":"closed","locked":false,"assignee":{"login":"thaJeztah","id":1804568,"avatar_url":"https://avatars2.githubusercontent.com/u/1804568?v=4","gravatar_id":"","url":"https://api.github.com/users/thaJeztah","html_url":"https://github.com/thaJeztah","followers_url":"https://api.github.com/users/thaJeztah/followers","following_url":"https://api.github.com/users/thaJeztah/following{/other_user}","gists_url":"https://api.github.com/users/thaJeztah/gists{/gist_id}","starred_url":"https://api.github.com/users/thaJeztah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thaJeztah/subscriptions","organizations_url":"https://api.github.com/users/thaJeztah/orgs","repos_url":"https://api.github.com/users/thaJeztah/repos","events_url":"https://api.github.com/users/thaJeztah/events{/privacy}","received_events_url":"https://api.github.com/users/thaJeztah/received_events","type":"User","site_admin":false},"assignees":[{"login":"thaJeztah","id":1804568,"avatar_url":"https://avatars2.githubusercontent.com/u/1804568?v=4","gravatar_id":"","url":"https://api.github.com/users/thaJeztah","html_url":"https://github.com/thaJeztah","followers_url":"https://api.github.com/users/thaJeztah/followers","following_url":"https://api.github.com/users/thaJeztah/following{/other_user}","gists_url":"https://api.github.com/users/thaJeztah/gists{/gist_id}","starred_url":"https://api.github.com/users/thaJeztah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thaJeztah/subscriptions","organizations_url":"https://api.github.com/users/thaJeztah/orgs","repos_url":"https://api.github.com/users/thaJeztah/repos","events_url":"https://api.github.com/users/thaJeztah/events{/privacy}","received_events_url":"https://api.github.com/users/thaJeztah/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/moby/moby/milestones/60","html_url":"https://github.com/moby/moby/milestone/60","labels_url":"https://api.github.com/repos/moby/moby/milestones/60/labels","id":2126145,"number":60,"title":"17.04.0","description":"https://github.com/docker/docker/releases/tag/v17.04.0-ce","creator":{"login":"vieux","id":1032519,"avatar_url":"https://avatars0.githubusercontent.com/u/1032519?v=4","gravatar_id":"","url":"https://api.github.com/users/vieux","html_url":"https://github.com/vieux","followers_url":"https://api.github.com/users/vieux/followers","following_url":"https://api.github.com/users/vieux/following{/other_user}","gists_url":"https://api.github.com/users/vieux/gists{/gist_id}","starred_url":"https://api.github.com/users/vieux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vieux/subscriptions","organizations_url":"https://api.github.com/users/vieux/orgs","repos_url":"https://api.github.com/users/vieux/repos","events_url":"https://api.github.com/users/vieux/events{/privacy}","received_events_url":"https://api.github.com/users/vieux/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":713,"state":"closed","created_at":"2016-11-10T02:23:44Z","updated_at":"2017-06-14T16:57:37Z","due_on":"2017-04-05T07:00:00Z","closed_at":"2017-04-10T16:19:52Z"},"comments":28,"created_at":"2016-05-06T22:42:03Z","updated_at":"2017-08-01T07:21:08Z","closed_at":"2017-02-01T15:29:34Z","pull_request":{"url":"https://api.github.com/repos/moby/moby/pulls/22563","html_url":"https://github.com/moby/moby/pull/22563","diff_url":"https://github.com/moby/moby/pull/22563.diff","patch_url":"https://github.com/moby/moby/pull/22563.patch"},"body":"**\\- What I Did**\n\nThis introduce a new `--device-cgroup-rule` flag that allow a user to add\none or more entry to the container cgroup device `devices.allow`\n\nThis should hopefully give a solution to issue like the one referred in the #22206 proposal:\n- add a rule to the container cgroup (e.g. 'c 13:\\* rwm')\n- via udev, execute a script anytime such a device is added. \n- the script should check whether the device should or should not be added to a given container\n- if the device is to be added, the script can run a docker exec to mknod the device into the container\n\n**\\- Note**\n\nI will make the required vendoring/engin-api PR once this has been accepted.\n\n**\\- Description for the changelog**\n- Add the ability to specify extra rules for a container device cgroup devices.allow mechanism\n\n**\\- A picture of a cute animal (not mandatory but encouraged)**\n\n![](https://s-media-cache-ak0.pinimg.com/736x/89/23/0d/89230d860e49dad02e47d14e91151aa7.jpg)\nSigned-off-by: Kenfe-Mickael Laventure mickael.laventure@gmail.com\n"},"comment":{"url":"https://api.github.com/repos/moby/moby/issues/comments/319289629","html_url":"https://github.com/moby/moby/pull/22563#issuecomment-319289629","issue_url":"https://api.github.com/repos/moby/moby/issues/22563","id":319289629,"user":{"login":"hqhq","id":6415670,"avatar_url":"https://avatars3.githubusercontent.com/u/6415670?v=4","gravatar_id":"","url":"https://api.github.com/users/hqhq","html_url":"https://github.com/hqhq","followers_url":"https://api.github.com/users/hqhq/followers","following_url":"https://api.github.com/users/hqhq/following{/other_user}","gists_url":"https://api.github.com/users/hqhq/gists{/gist_id}","starred_url":"https://api.github.com/users/hqhq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hqhq/subscriptions","organizations_url":"https://api.github.com/users/hqhq/orgs","repos_url":"https://api.github.com/users/hqhq/repos","events_url":"https://api.github.com/users/hqhq/events{/privacy}","received_events_url":"https://api.github.com/users/hqhq/received_events","type":"User","site_admin":false},"created_at":"2017-08-01T07:21:08Z","updated_at":"2017-08-01T07:21:08Z","body":"Why not improving `--device` to support something like `--device /dev/sdb*:rx` than to introduce this option?"}}
{"actor":{"display_login":"hqhq"}}