{"action":"created","comment":{"url":"https://api.github.com/repos/fsprojects/Paket/pulls/comments/111598275","pull_request_review_id":32856151,"id":111598275,"diff_hunk":"@@ -59,38 +169,31 @@ type FrameworkVersion =\n         | FrameworkVersion.V4_6_1 -> \"461\"\n         | FrameworkVersion.V4_6_2 -> \"462\"\n         | FrameworkVersion.V4_6_3 -> \"463\"\n+        | FrameworkVersion.V4_7 -> \"47\"\n         | FrameworkVersion.V5_0 -> \"50\"\n \n-[<RequireQualifiedAccess>]\n-/// The .NET Standard version.\n-// Each time a new version is added NuGetPackageCache.CurrentCacheVersion should be bumped.\n-type DotNetStandardVersion = \n-    | V1_0\n-    | V1_1\n-    | V1_2\n-    | V1_3\n-    | V1_4\n-    | V1_5\n-    | V1_6\n-    override this.ToString() =\n+    member this.NetStandardCompatible =\n         match this with\n-        | V1_0 -> \"v1.0\"\n-        | V1_1 -> \"v1.1\"\n-        | V1_2 -> \"v1.2\"\n-        | V1_3 -> \"v1.3\"\n-        | V1_4 -> \"v1.4\"\n-        | V1_5 -> \"v1.5\"\n-        | V1_6 -> \"v1.6\"\n+        | FrameworkVersion.V1         \n+        | FrameworkVersion.V1_1       \n+        | FrameworkVersion.V2         \n+        | FrameworkVersion.V3         \n+        | FrameworkVersion.V3_5       \n+        | FrameworkVersion.V4_Client  \n+        | FrameworkVersion.V4        -> []\n+        | FrameworkVersion.V4_5      -> [ DotNetStandardVersion.V1_1 ]\n+        | FrameworkVersion.V4_5_1    -> DotNetStandardVersion.V1_1 <-> DotNetStandardVersion.V1_2 \n+        | FrameworkVersion.V4_5_2    -> DotNetStandardVersion.V1_1 <-> DotNetStandardVersion.V1_2 \n+        | FrameworkVersion.V4_5_3    -> DotNetStandardVersion.V1_1 <-> DotNetStandardVersion.V1_2 \n+        | FrameworkVersion.V4_6      -> DotNetStandardVersion.V1_1 <-> DotNetStandardVersion.V1_3\n+        | FrameworkVersion.V4_6_1    -> (DotNetStandardVersion.V1_1 <-> DotNetStandardVersion.V1_4) @ [DotNetStandardVersion.V2_0]\n+        | FrameworkVersion.V4_6_2    -> (DotNetStandardVersion.V1_1 <-> DotNetStandardVersion.V1_5) @ [DotNetStandardVersion.V2_0]\n+        | FrameworkVersion.V4_6_3    -> DotNetStandardVersion.V1_1 <-> DotNetStandardVersion.V2_0\n+        | FrameworkVersion.V4_7      -> DotNetStandardVersion.V1_1 <-> DotNetStandardVersion.V2_0\n+        | FrameworkVersion.V5_0      -> DotNetStandardVersion.V1_1 <-> DotNetStandardVersion.V1_3","path":"src/Paket.Core/FrameworkHandling.fs","position":202,"original_position":202,"commit_id":"c8f8e2b7f7f28722b8a0dd91e41dcd7e250ffd12","original_commit_id":"c8f8e2b7f7f28722b8a0dd91e41dcd7e250ffd12","user":{"login":"matthid","id":1866463,"avatar_url":"https://avatars3.githubusercontent.com/u/1866463?v=3","gravatar_id":"","url":"https://api.github.com/users/matthid","html_url":"https://github.com/matthid","followers_url":"https://api.github.com/users/matthid/followers","following_url":"https://api.github.com/users/matthid/following{/other_user}","gists_url":"https://api.github.com/users/matthid/gists{/gist_id}","starred_url":"https://api.github.com/users/matthid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthid/subscriptions","organizations_url":"https://api.github.com/users/matthid/orgs","repos_url":"https://api.github.com/users/matthid/repos","events_url":"https://api.github.com/users/matthid/events{/privacy}","received_events_url":"https://api.github.com/users/matthid/received_events","type":"User","site_admin":false},"body":"With \"above\" I mean this...","created_at":"2017-04-14T16:33:11Z","updated_at":"2017-04-14T16:35:26Z","html_url":"https://github.com/fsprojects/Paket/pull/2250#discussion_r111598275","pull_request_url":"https://api.github.com/repos/fsprojects/Paket/pulls/2250","_links":{"self":{"href":"https://api.github.com/repos/fsprojects/Paket/pulls/comments/111598275"},"html":{"href":"https://github.com/fsprojects/Paket/pull/2250#discussion_r111598275"},"pull_request":{"href":"https://api.github.com/repos/fsprojects/Paket/pulls/2250"}}},"pull_request":{"url":"https://api.github.com/repos/fsprojects/Paket/pulls/2250","id":115906483,"html_url":"https://github.com/fsprojects/Paket/pull/2250","diff_url":"https://github.com/fsprojects/Paket/pull/2250.diff","patch_url":"https://github.com/fsprojects/Paket/pull/2250.patch","issue_url":"https://api.github.com/repos/fsprojects/Paket/issues/2250","number":2250,"state":"open","locked":false,"title":"Framework fixes","user":{"login":"cloudRoutine","id":680051,"avatar_url":"https://avatars0.githubusercontent.com/u/680051?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudRoutine","html_url":"https://github.com/cloudRoutine","followers_url":"https://api.github.com/users/cloudRoutine/followers","following_url":"https://api.github.com/users/cloudRoutine/following{/other_user}","gists_url":"https://api.github.com/users/cloudRoutine/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudRoutine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudRoutine/subscriptions","organizations_url":"https://api.github.com/users/cloudRoutine/orgs","repos_url":"https://api.github.com/users/cloudRoutine/repos","events_url":"https://api.github.com/users/cloudRoutine/events{/privacy}","received_events_url":"https://api.github.com/users/cloudRoutine/received_events","type":"User","site_admin":false},"body":"- adds netframework 4.7\r\n- adds netstandard 2.0\r\n- adds netcore 2.0","created_at":"2017-04-14T09:20:55Z","updated_at":"2017-04-14T16:35:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d6d1c06c5071b9f85daa36af3c56f35223ac3774","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/fsprojects/Paket/pulls/2250/commits","review_comments_url":"https://api.github.com/repos/fsprojects/Paket/pulls/2250/comments","review_comment_url":"https://api.github.com/repos/fsprojects/Paket/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fsprojects/Paket/issues/2250/comments","statuses_url":"https://api.github.com/repos/fsprojects/Paket/statuses/c8f8e2b7f7f28722b8a0dd91e41dcd7e250ffd12","head":{"label":"cloudRoutine:framework-fix","ref":"framework-fix","sha":"c8f8e2b7f7f28722b8a0dd91e41dcd7e250ffd12","user":{"login":"cloudRoutine","id":680051,"avatar_url":"https://avatars0.githubusercontent.com/u/680051?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudRoutine","html_url":"https://github.com/cloudRoutine","followers_url":"https://api.github.com/users/cloudRoutine/followers","following_url":"https://api.github.com/users/cloudRoutine/following{/other_user}","gists_url":"https://api.github.com/users/cloudRoutine/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudRoutine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudRoutine/subscriptions","organizations_url":"https://api.github.com/users/cloudRoutine/orgs","repos_url":"https://api.github.com/users/cloudRoutine/repos","events_url":"https://api.github.com/users/cloudRoutine/events{/privacy}","received_events_url":"https://api.github.com/users/cloudRoutine/received_events","type":"User","site_admin":false},"repo":{"id":42973052,"name":"Paket","full_name":"cloudRoutine/Paket","owner":{"login":"cloudRoutine","id":680051,"avatar_url":"https://avatars0.githubusercontent.com/u/680051?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudRoutine","html_url":"https://github.com/cloudRoutine","followers_url":"https://api.github.com/users/cloudRoutine/followers","following_url":"https://api.github.com/users/cloudRoutine/following{/other_user}","gists_url":"https://api.github.com/users/cloudRoutine/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudRoutine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudRoutine/subscriptions","organizations_url":"https://api.github.com/users/cloudRoutine/orgs","repos_url":"https://api.github.com/users/cloudRoutine/repos","events_url":"https://api.github.com/users/cloudRoutine/events{/privacy}","received_events_url":"https://api.github.com/users/cloudRoutine/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cloudRoutine/Paket","description":"A package dependency manager for .NET with support for NuGet packages and GitHub repositories.","fork":true,"url":"https://api.github.com/repos/cloudRoutine/Paket","forks_url":"https://api.github.com/repos/cloudRoutine/Paket/forks","keys_url":"https://api.github.com/repos/cloudRoutine/Paket/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudRoutine/Paket/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudRoutine/Paket/teams","hooks_url":"https://api.github.com/repos/cloudRoutine/Paket/hooks","issue_events_url":"https://api.github.com/repos/cloudRoutine/Paket/issues/events{/number}","events_url":"https://api.github.com/repos/cloudRoutine/Paket/events","assignees_url":"https://api.github.com/repos/cloudRoutine/Paket/assignees{/user}","branches_url":"https://api.github.com/repos/cloudRoutine/Paket/branches{/branch}","tags_url":"https://api.github.com/repos/cloudRoutine/Paket/tags","blobs_url":"https://api.github.com/repos/cloudRoutine/Paket/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudRoutine/Paket/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudRoutine/Paket/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudRoutine/Paket/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudRoutine/Paket/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudRoutine/Paket/languages","stargazers_url":"https://api.github.com/repos/cloudRoutine/Paket/stargazers","contributors_url":"https://api.github.com/repos/cloudRoutine/Paket/contributors","subscribers_url":"https://api.github.com/repos/cloudRoutine/Paket/subscribers","subscription_url":"https://api.github.com/repos/cloudRoutine/Paket/subscription","commits_url":"https://api.github.com/repos/cloudRoutine/Paket/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudRoutine/Paket/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudRoutine/Paket/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudRoutine/Paket/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloudRoutine/Paket/contents/{+path}","compare_url":"https://api.github.com/repos/cloudRoutine/Paket/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudRoutine/Paket/merges","archive_url":"https://api.github.com/repos/cloudRoutine/Paket/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudRoutine/Paket/downloads","issues_url":"https://api.github.com/repos/cloudRoutine/Paket/issues{/number}","pulls_url":"https://api.github.com/repos/cloudRoutine/Paket/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudRoutine/Paket/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudRoutine/Paket/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudRoutine/Paket/labels{/name}","releases_url":"https://api.github.com/repos/cloudRoutine/Paket/releases{/id}","deployments_url":"https://api.github.com/repos/cloudRoutine/Paket/deployments","created_at":"2015-09-23T02:18:37Z","updated_at":"2016-01-12T04:10:59Z","pushed_at":"2017-04-14T16:00:20Z","git_url":"git://github.com/cloudRoutine/Paket.git","ssh_url":"git@github.com:cloudRoutine/Paket.git","clone_url":"https://github.com/cloudRoutine/Paket.git","svn_url":"https://github.com/cloudRoutine/Paket","homepage":"http://fsprojects.github.io/Paket/","size":220116,"stargazers_count":0,"watchers_count":0,"language":"F#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fsprojects:master","ref":"master","sha":"e3cdfaa47a374c768a501b43cc99f57e96975b1a","user":{"login":"fsprojects","id":6001315,"avatar_url":"https://avatars1.githubusercontent.com/u/6001315?v=3","gravatar_id":"","url":"https://api.github.com/users/fsprojects","html_url":"https://github.com/fsprojects","followers_url":"https://api.github.com/users/fsprojects/followers","following_url":"https://api.github.com/users/fsprojects/following{/other_user}","gists_url":"https://api.github.com/users/fsprojects/gists{/gist_id}","starred_url":"https://api.github.com/users/fsprojects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fsprojects/subscriptions","organizations_url":"https://api.github.com/users/fsprojects/orgs","repos_url":"https://api.github.com/users/fsprojects/repos","events_url":"https://api.github.com/users/fsprojects/events{/privacy}","received_events_url":"https://api.github.com/users/fsprojects/received_events","type":"Organization","site_admin":false},"repo":{"id":22755810,"name":"Paket","full_name":"fsprojects/Paket","owner":{"login":"fsprojects","id":6001315,"avatar_url":"https://avatars1.githubusercontent.com/u/6001315?v=3","gravatar_id":"","url":"https://api.github.com/users/fsprojects","html_url":"https://github.com/fsprojects","followers_url":"https://api.github.com/users/fsprojects/followers","following_url":"https://api.github.com/users/fsprojects/following{/other_user}","gists_url":"https://api.github.com/users/fsprojects/gists{/gist_id}","starred_url":"https://api.github.com/users/fsprojects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fsprojects/subscriptions","organizations_url":"https://api.github.com/users/fsprojects/orgs","repos_url":"https://api.github.com/users/fsprojects/repos","events_url":"https://api.github.com/users/fsprojects/events{/privacy}","received_events_url":"https://api.github.com/users/fsprojects/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fsprojects/Paket","description":"A dependency manager for .NET with support for NuGet packages and Git repositories.","fork":false,"url":"https://api.github.com/repos/fsprojects/Paket","forks_url":"https://api.github.com/repos/fsprojects/Paket/forks","keys_url":"https://api.github.com/repos/fsprojects/Paket/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fsprojects/Paket/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fsprojects/Paket/teams","hooks_url":"https://api.github.com/repos/fsprojects/Paket/hooks","issue_events_url":"https://api.github.com/repos/fsprojects/Paket/issues/events{/number}","events_url":"https://api.github.com/repos/fsprojects/Paket/events","assignees_url":"https://api.github.com/repos/fsprojects/Paket/assignees{/user}","branches_url":"https://api.github.com/repos/fsprojects/Paket/branches{/branch}","tags_url":"https://api.github.com/repos/fsprojects/Paket/tags","blobs_url":"https://api.github.com/repos/fsprojects/Paket/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fsprojects/Paket/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fsprojects/Paket/git/refs{/sha}","trees_url":"https://api.github.com/repos/fsprojects/Paket/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fsprojects/Paket/statuses/{sha}","languages_url":"https://api.github.com/repos/fsprojects/Paket/languages","stargazers_url":"https://api.github.com/repos/fsprojects/Paket/stargazers","contributors_url":"https://api.github.com/repos/fsprojects/Paket/contributors","subscribers_url":"https://api.github.com/repos/fsprojects/Paket/subscribers","subscription_url":"https://api.github.com/repos/fsprojects/Paket/subscription","commits_url":"https://api.github.com/repos/fsprojects/Paket/commits{/sha}","git_commits_url":"https://api.github.com/repos/fsprojects/Paket/git/commits{/sha}","comments_url":"https://api.github.com/repos/fsprojects/Paket/comments{/number}","issue_comment_url":"https://api.github.com/repos/fsprojects/Paket/issues/comments{/number}","contents_url":"https://api.github.com/repos/fsprojects/Paket/contents/{+path}","compare_url":"https://api.github.com/repos/fsprojects/Paket/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fsprojects/Paket/merges","archive_url":"https://api.github.com/repos/fsprojects/Paket/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fsprojects/Paket/downloads","issues_url":"https://api.github.com/repos/fsprojects/Paket/issues{/number}","pulls_url":"https://api.github.com/repos/fsprojects/Paket/pulls{/number}","milestones_url":"https://api.github.com/repos/fsprojects/Paket/milestones{/number}","notifications_url":"https://api.github.com/repos/fsprojects/Paket/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fsprojects/Paket/labels{/name}","releases_url":"https://api.github.com/repos/fsprojects/Paket/releases{/id}","deployments_url":"https://api.github.com/repos/fsprojects/Paket/deployments","created_at":"2014-08-08T11:36:13Z","updated_at":"2017-04-13T12:55:46Z","pushed_at":"2017-04-14T16:00:22Z","git_url":"git://github.com/fsprojects/Paket.git","ssh_url":"git@github.com:fsprojects/Paket.git","clone_url":"https://github.com/fsprojects/Paket.git","svn_url":"https://github.com/fsprojects/Paket","homepage":"https://fsprojects.github.io/Paket/","size":211860,"stargazers_count":899,"watchers_count":899,"language":"F#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":294,"mirror_url":null,"open_issues_count":259,"forks":294,"open_issues":259,"watchers":899,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fsprojects/Paket/pulls/2250"},"html":{"href":"https://github.com/fsprojects/Paket/pull/2250"},"issue":{"href":"https://api.github.com/repos/fsprojects/Paket/issues/2250"},"comments":{"href":"https://api.github.com/repos/fsprojects/Paket/issues/2250/comments"},"review_comments":{"href":"https://api.github.com/repos/fsprojects/Paket/pulls/2250/comments"},"review_comment":{"href":"https://api.github.com/repos/fsprojects/Paket/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fsprojects/Paket/pulls/2250/commits"},"statuses":{"href":"https://api.github.com/repos/fsprojects/Paket/statuses/c8f8e2b7f7f28722b8a0dd91e41dcd7e250ffd12"}}}}
{"actor":{"display_login":"matthid"}}