{"action":"opened","number":3,"pull_request":{"url":"https://api.github.com/repos/guzmonne/meraki_api/pulls/3","id":146007518,"html_url":"https://github.com/guzmonne/meraki_api/pull/3","diff_url":"https://github.com/guzmonne/meraki_api/pull/3.diff","patch_url":"https://github.com/guzmonne/meraki_api/pull/3.patch","issue_url":"https://api.github.com/repos/guzmonne/meraki_api/issues/3","number":3,"state":"open","locked":false,"title":"Support for Python 2.7","user":{"login":"grutz","id":171865,"avatar_url":"https://avatars0.githubusercontent.com/u/171865?v=4","gravatar_id":"","url":"https://api.github.com/users/grutz","html_url":"https://github.com/grutz","followers_url":"https://api.github.com/users/grutz/followers","following_url":"https://api.github.com/users/grutz/following{/other_user}","gists_url":"https://api.github.com/users/grutz/gists{/gist_id}","starred_url":"https://api.github.com/users/grutz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grutz/subscriptions","organizations_url":"https://api.github.com/users/grutz/orgs","repos_url":"https://api.github.com/users/grutz/repos","events_url":"https://api.github.com/users/grutz/events{/privacy}","received_events_url":"https://api.github.com/users/grutz/received_events","type":"User","site_admin":false},"body":"Excellent work on the library! A few minor changes are required to make it fully backwards-compatible with Python 2.7 without impacting future development:\r\n\r\n- Added the mock library and import exception handler since mock not built-in for py2 unittest\r\n- Added a test section for running unittests via `setup.py`\r\n- Use `requests.get(url, headers, params={})` instead of url-encoding parameters since `requests` takes care of this for us.\r\n- For minimal changes to other library calls added specific handlers in `lazy_requests.py` for `requests.get()` so `self.data` is not JSON encoded and the correct `params` field is used.\r\n- Modified `tests/test_organizations_networks.py` to handle change to get requests.\r\n- Made sure all unittests pass for py2 and py3","created_at":"2017-10-11T17:02:27Z","updated_at":"2017-10-11T17:02:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/guzmonne/meraki_api/pulls/3/commits","review_comments_url":"https://api.github.com/repos/guzmonne/meraki_api/pulls/3/comments","review_comment_url":"https://api.github.com/repos/guzmonne/meraki_api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/guzmonne/meraki_api/issues/3/comments","statuses_url":"https://api.github.com/repos/guzmonne/meraki_api/statuses/bc2efb76ccb45db774e2b58f77a6304b41c84a18","head":{"label":"grutz:py2","ref":"py2","sha":"bc2efb76ccb45db774e2b58f77a6304b41c84a18","user":{"login":"grutz","id":171865,"avatar_url":"https://avatars0.githubusercontent.com/u/171865?v=4","gravatar_id":"","url":"https://api.github.com/users/grutz","html_url":"https://github.com/grutz","followers_url":"https://api.github.com/users/grutz/followers","following_url":"https://api.github.com/users/grutz/following{/other_user}","gists_url":"https://api.github.com/users/grutz/gists{/gist_id}","starred_url":"https://api.github.com/users/grutz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grutz/subscriptions","organizations_url":"https://api.github.com/users/grutz/orgs","repos_url":"https://api.github.com/users/grutz/repos","events_url":"https://api.github.com/users/grutz/events{/privacy}","received_events_url":"https://api.github.com/users/grutz/received_events","type":"User","site_admin":false},"repo":{"id":106504363,"name":"meraki_api","full_name":"grutz/meraki_api","owner":{"login":"grutz","id":171865,"avatar_url":"https://avatars0.githubusercontent.com/u/171865?v=4","gravatar_id":"","url":"https://api.github.com/users/grutz","html_url":"https://github.com/grutz","followers_url":"https://api.github.com/users/grutz/followers","following_url":"https://api.github.com/users/grutz/following{/other_user}","gists_url":"https://api.github.com/users/grutz/gists{/gist_id}","starred_url":"https://api.github.com/users/grutz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grutz/subscriptions","organizations_url":"https://api.github.com/users/grutz/orgs","repos_url":"https://api.github.com/users/grutz/repos","events_url":"https://api.github.com/users/grutz/events{/privacy}","received_events_url":"https://api.github.com/users/grutz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/grutz/meraki_api","description":"Meraki API wrapper","fork":true,"url":"https://api.github.com/repos/grutz/meraki_api","forks_url":"https://api.github.com/repos/grutz/meraki_api/forks","keys_url":"https://api.github.com/repos/grutz/meraki_api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grutz/meraki_api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grutz/meraki_api/teams","hooks_url":"https://api.github.com/repos/grutz/meraki_api/hooks","issue_events_url":"https://api.github.com/repos/grutz/meraki_api/issues/events{/number}","events_url":"https://api.github.com/repos/grutz/meraki_api/events","assignees_url":"https://api.github.com/repos/grutz/meraki_api/assignees{/user}","branches_url":"https://api.github.com/repos/grutz/meraki_api/branches{/branch}","tags_url":"https://api.github.com/repos/grutz/meraki_api/tags","blobs_url":"https://api.github.com/repos/grutz/meraki_api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grutz/meraki_api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grutz/meraki_api/git/refs{/sha}","trees_url":"https://api.github.com/repos/grutz/meraki_api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grutz/meraki_api/statuses/{sha}","languages_url":"https://api.github.com/repos/grutz/meraki_api/languages","stargazers_url":"https://api.github.com/repos/grutz/meraki_api/stargazers","contributors_url":"https://api.github.com/repos/grutz/meraki_api/contributors","subscribers_url":"https://api.github.com/repos/grutz/meraki_api/subscribers","subscription_url":"https://api.github.com/repos/grutz/meraki_api/subscription","commits_url":"https://api.github.com/repos/grutz/meraki_api/commits{/sha}","git_commits_url":"https://api.github.com/repos/grutz/meraki_api/git/commits{/sha}","comments_url":"https://api.github.com/repos/grutz/meraki_api/comments{/number}","issue_comment_url":"https://api.github.com/repos/grutz/meraki_api/issues/comments{/number}","contents_url":"https://api.github.com/repos/grutz/meraki_api/contents/{+path}","compare_url":"https://api.github.com/repos/grutz/meraki_api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grutz/meraki_api/merges","archive_url":"https://api.github.com/repos/grutz/meraki_api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grutz/meraki_api/downloads","issues_url":"https://api.github.com/repos/grutz/meraki_api/issues{/number}","pulls_url":"https://api.github.com/repos/grutz/meraki_api/pulls{/number}","milestones_url":"https://api.github.com/repos/grutz/meraki_api/milestones{/number}","notifications_url":"https://api.github.com/repos/grutz/meraki_api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grutz/meraki_api/labels{/name}","releases_url":"https://api.github.com/repos/grutz/meraki_api/releases{/id}","deployments_url":"https://api.github.com/repos/grutz/meraki_api/deployments","created_at":"2017-10-11T04:09:04Z","updated_at":"2017-10-11T04:09:06Z","pushed_at":"2017-10-11T16:53:10Z","git_url":"git://github.com/grutz/meraki_api.git","ssh_url":"git@github.com:grutz/meraki_api.git","clone_url":"https://github.com/grutz/meraki_api.git","svn_url":"https://github.com/grutz/meraki_api","homepage":"https://guzmonne.github.io/meraki_api/","size":232,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"guzmonne:master","ref":"master","sha":"0d0a4af583e20a7c27cb32482435f1afd2d7b602","user":{"login":"guzmonne","id":1446448,"avatar_url":"https://avatars2.githubusercontent.com/u/1446448?v=4","gravatar_id":"","url":"https://api.github.com/users/guzmonne","html_url":"https://github.com/guzmonne","followers_url":"https://api.github.com/users/guzmonne/followers","following_url":"https://api.github.com/users/guzmonne/following{/other_user}","gists_url":"https://api.github.com/users/guzmonne/gists{/gist_id}","starred_url":"https://api.github.com/users/guzmonne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guzmonne/subscriptions","organizations_url":"https://api.github.com/users/guzmonne/orgs","repos_url":"https://api.github.com/users/guzmonne/repos","events_url":"https://api.github.com/users/guzmonne/events{/privacy}","received_events_url":"https://api.github.com/users/guzmonne/received_events","type":"User","site_admin":false},"repo":{"id":96050452,"name":"meraki_api","full_name":"guzmonne/meraki_api","owner":{"login":"guzmonne","id":1446448,"avatar_url":"https://avatars2.githubusercontent.com/u/1446448?v=4","gravatar_id":"","url":"https://api.github.com/users/guzmonne","html_url":"https://github.com/guzmonne","followers_url":"https://api.github.com/users/guzmonne/followers","following_url":"https://api.github.com/users/guzmonne/following{/other_user}","gists_url":"https://api.github.com/users/guzmonne/gists{/gist_id}","starred_url":"https://api.github.com/users/guzmonne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guzmonne/subscriptions","organizations_url":"https://api.github.com/users/guzmonne/orgs","repos_url":"https://api.github.com/users/guzmonne/repos","events_url":"https://api.github.com/users/guzmonne/events{/privacy}","received_events_url":"https://api.github.com/users/guzmonne/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/guzmonne/meraki_api","description":"Meraki API wrapper","fork":false,"url":"https://api.github.com/repos/guzmonne/meraki_api","forks_url":"https://api.github.com/repos/guzmonne/meraki_api/forks","keys_url":"https://api.github.com/repos/guzmonne/meraki_api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guzmonne/meraki_api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guzmonne/meraki_api/teams","hooks_url":"https://api.github.com/repos/guzmonne/meraki_api/hooks","issue_events_url":"https://api.github.com/repos/guzmonne/meraki_api/issues/events{/number}","events_url":"https://api.github.com/repos/guzmonne/meraki_api/events","assignees_url":"https://api.github.com/repos/guzmonne/meraki_api/assignees{/user}","branches_url":"https://api.github.com/repos/guzmonne/meraki_api/branches{/branch}","tags_url":"https://api.github.com/repos/guzmonne/meraki_api/tags","blobs_url":"https://api.github.com/repos/guzmonne/meraki_api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guzmonne/meraki_api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guzmonne/meraki_api/git/refs{/sha}","trees_url":"https://api.github.com/repos/guzmonne/meraki_api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guzmonne/meraki_api/statuses/{sha}","languages_url":"https://api.github.com/repos/guzmonne/meraki_api/languages","stargazers_url":"https://api.github.com/repos/guzmonne/meraki_api/stargazers","contributors_url":"https://api.github.com/repos/guzmonne/meraki_api/contributors","subscribers_url":"https://api.github.com/repos/guzmonne/meraki_api/subscribers","subscription_url":"https://api.github.com/repos/guzmonne/meraki_api/subscription","commits_url":"https://api.github.com/repos/guzmonne/meraki_api/commits{/sha}","git_commits_url":"https://api.github.com/repos/guzmonne/meraki_api/git/commits{/sha}","comments_url":"https://api.github.com/repos/guzmonne/meraki_api/comments{/number}","issue_comment_url":"https://api.github.com/repos/guzmonne/meraki_api/issues/comments{/number}","contents_url":"https://api.github.com/repos/guzmonne/meraki_api/contents/{+path}","compare_url":"https://api.github.com/repos/guzmonne/meraki_api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guzmonne/meraki_api/merges","archive_url":"https://api.github.com/repos/guzmonne/meraki_api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guzmonne/meraki_api/downloads","issues_url":"https://api.github.com/repos/guzmonne/meraki_api/issues{/number}","pulls_url":"https://api.github.com/repos/guzmonne/meraki_api/pulls{/number}","milestones_url":"https://api.github.com/repos/guzmonne/meraki_api/milestones{/number}","notifications_url":"https://api.github.com/repos/guzmonne/meraki_api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guzmonne/meraki_api/labels{/name}","releases_url":"https://api.github.com/repos/guzmonne/meraki_api/releases{/id}","deployments_url":"https://api.github.com/repos/guzmonne/meraki_api/deployments","created_at":"2017-07-02T21:40:35Z","updated_at":"2017-07-03T14:33:27Z","pushed_at":"2017-07-23T13:51:09Z","git_url":"git://github.com/guzmonne/meraki_api.git","ssh_url":"git@github.com:guzmonne/meraki_api.git","clone_url":"https://github.com/guzmonne/meraki_api.git","svn_url":"https://github.com/guzmonne/meraki_api","homepage":"https://guzmonne.github.io/meraki_api/","size":232,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/guzmonne/meraki_api/pulls/3"},"html":{"href":"https://github.com/guzmonne/meraki_api/pull/3"},"issue":{"href":"https://api.github.com/repos/guzmonne/meraki_api/issues/3"},"comments":{"href":"https://api.github.com/repos/guzmonne/meraki_api/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/guzmonne/meraki_api/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/guzmonne/meraki_api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/guzmonne/meraki_api/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/guzmonne/meraki_api/statuses/bc2efb76ccb45db774e2b58f77a6304b41c84a18"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":56,"deletions":33,"changed_files":9}}
{"actor":{"display_login":"grutz"}}