{"action":"closed","number":225,"pull_request":{"url":"https://api.github.com/repos/guardian/identity-frontend/pulls/225","id":140343134,"html_url":"https://github.com/guardian/identity-frontend/pull/225","diff_url":"https://github.com/guardian/identity-frontend/pull/225.diff","patch_url":"https://github.com/guardian/identity-frontend/pull/225.patch","issue_url":"https://api.github.com/repos/guardian/identity-frontend/issues/225","number":225,"state":"closed","locked":false,"title":"Add Recurring Contributor Cookie","user":{"login":"Ap0c","id":5131341,"avatar_url":"https://avatars3.githubusercontent.com/u/5131341?v=4","gravatar_id":"","url":"https://api.github.com/users/Ap0c","html_url":"https://github.com/Ap0c","followers_url":"https://api.github.com/users/Ap0c/followers","following_url":"https://api.github.com/users/Ap0c/following{/other_user}","gists_url":"https://api.github.com/users/Ap0c/gists{/gist_id}","starred_url":"https://api.github.com/users/Ap0c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ap0c/subscriptions","organizations_url":"https://api.github.com/users/Ap0c/orgs","repos_url":"https://api.github.com/users/Ap0c/repos","events_url":"https://api.github.com/users/Ap0c/events{/privacy}","received_events_url":"https://api.github.com/users/Ap0c/received_events","type":"User","site_admin":false},"body":"## Why?\r\n\r\nTo include support for a new cookie being introduced on dotcom: `gu_recurring_contributor`. This is being used to mark someone as a recurring contributor, and to therefore hide supporter messaging for them. This cookie needs to be deleted on sign-out along with the other user cookies.\r\n\r\nThe corresponding branch (soon to become a PR in frontend) is [here](https://github.com/guardian/frontend/compare/stop-showing-messaging-for-recurring-contributors). Another corresponding PR in the members-data-api was merged today, and is [here](https://github.com/guardian/members-data-api/pull/230).\r\n\r\ncc: @JustinPinner\r\n\r\n## Changes\r\n\r\n- Added `gu_recurring_contributor` to the list of known cookies.\r\n- Updated tests to include this new cookie.\r\n","created_at":"2017-09-11T14:04:27Z","updated_at":"2017-09-18T14:01:36Z","closed_at":"2017-09-18T14:01:36Z","merged_at":"2017-09-18T14:01:36Z","merge_commit_sha":"65ec1edbf8907202f9584e06763dfa66249eaf24","assignee":null,"assignees":[],"requested_reviewers":[{"login":"markjamesbutler","id":406099,"avatar_url":"https://avatars3.githubusercontent.com/u/406099?v=4","gravatar_id":"","url":"https://api.github.com/users/markjamesbutler","html_url":"https://github.com/markjamesbutler","followers_url":"https://api.github.com/users/markjamesbutler/followers","following_url":"https://api.github.com/users/markjamesbutler/following{/other_user}","gists_url":"https://api.github.com/users/markjamesbutler/gists{/gist_id}","starred_url":"https://api.github.com/users/markjamesbutler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markjamesbutler/subscriptions","organizations_url":"https://api.github.com/users/markjamesbutler/orgs","repos_url":"https://api.github.com/users/markjamesbutler/repos","events_url":"https://api.github.com/users/markjamesbutler/events{/privacy}","received_events_url":"https://api.github.com/users/markjamesbutler/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/guardian/identity-frontend/pulls/225/commits","review_comments_url":"https://api.github.com/repos/guardian/identity-frontend/pulls/225/comments","review_comment_url":"https://api.github.com/repos/guardian/identity-frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/guardian/identity-frontend/issues/225/comments","statuses_url":"https://api.github.com/repos/guardian/identity-frontend/statuses/1e2a5458bc0916254bbc78e3cbe53c78438479eb","head":{"label":"guardian:add-recurring-contributor-cookie","ref":"add-recurring-contributor-cookie","sha":"1e2a5458bc0916254bbc78e3cbe53c78438479eb","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars0.githubusercontent.com/u/164318?v=4","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":45927868,"name":"identity-frontend","full_name":"guardian/identity-frontend","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars0.githubusercontent.com/u/164318?v=4","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/identity-frontend","description":"Frontend for sign-in and registration at theguardian.com","fork":false,"url":"https://api.github.com/repos/guardian/identity-frontend","forks_url":"https://api.github.com/repos/guardian/identity-frontend/forks","keys_url":"https://api.github.com/repos/guardian/identity-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/identity-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/identity-frontend/teams","hooks_url":"https://api.github.com/repos/guardian/identity-frontend/hooks","issue_events_url":"https://api.github.com/repos/guardian/identity-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/identity-frontend/events","assignees_url":"https://api.github.com/repos/guardian/identity-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/identity-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/identity-frontend/tags","blobs_url":"https://api.github.com/repos/guardian/identity-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/identity-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/identity-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/identity-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/identity-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/identity-frontend/languages","stargazers_url":"https://api.github.com/repos/guardian/identity-frontend/stargazers","contributors_url":"https://api.github.com/repos/guardian/identity-frontend/contributors","subscribers_url":"https://api.github.com/repos/guardian/identity-frontend/subscribers","subscription_url":"https://api.github.com/repos/guardian/identity-frontend/subscription","commits_url":"https://api.github.com/repos/guardian/identity-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/identity-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/identity-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/identity-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/identity-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/identity-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/identity-frontend/merges","archive_url":"https://api.github.com/repos/guardian/identity-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/identity-frontend/downloads","issues_url":"https://api.github.com/repos/guardian/identity-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/identity-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/identity-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/identity-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/identity-frontend/labels{/name}","releases_url":"https://api.github.com/repos/guardian/identity-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/guardian/identity-frontend/deployments","created_at":"2015-11-10T17:19:02Z","updated_at":"2017-03-18T12:11:18Z","pushed_at":"2017-09-18T14:01:36Z","git_url":"git://github.com/guardian/identity-frontend.git","ssh_url":"git@github.com:guardian/identity-frontend.git","clone_url":"https://github.com/guardian/identity-frontend.git","svn_url":"https://github.com/guardian/identity-frontend","homepage":"https://profile.theguardian.com/signin","size":4109,"stargazers_count":17,"watchers_count":17,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":0,"forks":3,"open_issues":0,"watchers":17,"default_branch":"master"}},"base":{"label":"guardian:master","ref":"master","sha":"5b118a7f1c75421c8b97e38daaf6759d2b397bf0","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars0.githubusercontent.com/u/164318?v=4","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":45927868,"name":"identity-frontend","full_name":"guardian/identity-frontend","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars0.githubusercontent.com/u/164318?v=4","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/identity-frontend","description":"Frontend for sign-in and registration at theguardian.com","fork":false,"url":"https://api.github.com/repos/guardian/identity-frontend","forks_url":"https://api.github.com/repos/guardian/identity-frontend/forks","keys_url":"https://api.github.com/repos/guardian/identity-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/identity-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/identity-frontend/teams","hooks_url":"https://api.github.com/repos/guardian/identity-frontend/hooks","issue_events_url":"https://api.github.com/repos/guardian/identity-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/identity-frontend/events","assignees_url":"https://api.github.com/repos/guardian/identity-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/identity-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/identity-frontend/tags","blobs_url":"https://api.github.com/repos/guardian/identity-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/identity-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/identity-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/identity-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/identity-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/identity-frontend/languages","stargazers_url":"https://api.github.com/repos/guardian/identity-frontend/stargazers","contributors_url":"https://api.github.com/repos/guardian/identity-frontend/contributors","subscribers_url":"https://api.github.com/repos/guardian/identity-frontend/subscribers","subscription_url":"https://api.github.com/repos/guardian/identity-frontend/subscription","commits_url":"https://api.github.com/repos/guardian/identity-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/identity-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/identity-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/identity-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/identity-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/identity-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/identity-frontend/merges","archive_url":"https://api.github.com/repos/guardian/identity-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/identity-frontend/downloads","issues_url":"https://api.github.com/repos/guardian/identity-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/identity-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/identity-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/identity-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/identity-frontend/labels{/name}","releases_url":"https://api.github.com/repos/guardian/identity-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/guardian/identity-frontend/deployments","created_at":"2015-11-10T17:19:02Z","updated_at":"2017-03-18T12:11:18Z","pushed_at":"2017-09-18T14:01:36Z","git_url":"git://github.com/guardian/identity-frontend.git","ssh_url":"git@github.com:guardian/identity-frontend.git","clone_url":"https://github.com/guardian/identity-frontend.git","svn_url":"https://github.com/guardian/identity-frontend","homepage":"https://profile.theguardian.com/signin","size":4109,"stargazers_count":17,"watchers_count":17,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":0,"forks":3,"open_issues":0,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/guardian/identity-frontend/pulls/225"},"html":{"href":"https://github.com/guardian/identity-frontend/pull/225"},"issue":{"href":"https://api.github.com/repos/guardian/identity-frontend/issues/225"},"comments":{"href":"https://api.github.com/repos/guardian/identity-frontend/issues/225/comments"},"review_comments":{"href":"https://api.github.com/repos/guardian/identity-frontend/pulls/225/comments"},"review_comment":{"href":"https://api.github.com/repos/guardian/identity-frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/guardian/identity-frontend/pulls/225/commits"},"statuses":{"href":"https://api.github.com/repos/guardian/identity-frontend/statuses/1e2a5458bc0916254bbc78e3cbe53c78438479eb"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"JustinPinner","id":690395,"avatar_url":"https://avatars2.githubusercontent.com/u/690395?v=4","gravatar_id":"","url":"https://api.github.com/users/JustinPinner","html_url":"https://github.com/JustinPinner","followers_url":"https://api.github.com/users/JustinPinner/followers","following_url":"https://api.github.com/users/JustinPinner/following{/other_user}","gists_url":"https://api.github.com/users/JustinPinner/gists{/gist_id}","starred_url":"https://api.github.com/users/JustinPinner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JustinPinner/subscriptions","organizations_url":"https://api.github.com/users/JustinPinner/orgs","repos_url":"https://api.github.com/users/JustinPinner/repos","events_url":"https://api.github.com/users/JustinPinner/events{/privacy}","received_events_url":"https://api.github.com/users/JustinPinner/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":9,"deletions":6,"changed_files":4}}
{"actor":{"display_login":"JustinPinner"}}