{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/16092","repository_url":"https://api.github.com/repos/ManageIQ/manageiq","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/16092/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/16092/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/16092/events","html_url":"https://github.com/ManageIQ/manageiq/issues/16092","id":262290901,"number":16092,"title":"Remove useless assignments to variables","user":{"login":"chrisarcand","id":2430490,"avatar_url":"https://avatars2.githubusercontent.com/u/2430490?v=4","gravatar_id":"","url":"https://api.github.com/users/chrisarcand","html_url":"https://github.com/chrisarcand","followers_url":"https://api.github.com/users/chrisarcand/followers","following_url":"https://api.github.com/users/chrisarcand/following{/other_user}","gists_url":"https://api.github.com/users/chrisarcand/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisarcand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisarcand/subscriptions","organizations_url":"https://api.github.com/users/chrisarcand/orgs","repos_url":"https://api.github.com/users/chrisarcand/repos","events_url":"https://api.github.com/users/chrisarcand/events{/privacy}","received_events_url":"https://api.github.com/users/chrisarcand/received_events","type":"User","site_admin":false},"labels":[{"id":129029872,"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/cleanup","name":"cleanup","color":"fef2c0","default":false},{"id":455040320,"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/hacktoberfest","name":"hacktoberfest","color":"FF7619","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-10-03T03:11:00Z","updated_at":"2017-10-18T16:01:24Z","closed_at":null,"author_association":"MEMBER","body":"We needlessly assignment variables in places where they aren't used. These assignments can be removed.\r\n\r\n```\r\n== app/models/cloud_tenant.rb (3 issues) ==\r\n45: Useless assignment to variable - `created_cloud_tenant`. [rubocop]\r\n== app/models/cloud_volume.rb (4 issues) ==\r\n54: Useless assignment to variable - `tenant`. [rubocop]\r\n56: Useless assignment to variable - `created_volume`. [rubocop]\r\n== app/models/ems_refresh/save_inventory_infra.rb (6 issues) ==\r\n87: Useless assignment to variable - `target`. [rubocop]\r\n== app/models/ldap_user.rb (3 issues) ==\r\n127: Useless assignment to variable - `rec`. [rubocop]\r\n== app/models/manageiq/providers/storage_manager/cinder_manager/refresh_parser.rb (4 issues) ==\r\n108: Useless assignment to variable - `log_header`. [rubocop]\r\n== app/models/metric/ci_mixin.rb (6 issues) ==\r\n77: Useless assignment to variable - `klass`. Use `_` or `_klass` as a variable name to indicate that it won't be used. [rubocop]\r\n151: Useless assignment to variable - `yint`. Use `_` or `_yint` as a variable name to indicate that it won't be used. [rubocop]\r\n== app/models/metric/ci_mixin/processing.rb (4 issues) ==\r\n19: Useless assignment to variable - `dummy`. Use `_` or `_dummy` as a variable name to indicate that it won't be used. [rubocop]\r\n== app/models/metric/ci_mixin/rollup.rb (5 issues) ==\r\n77: Useless assignment to variable - `klass`. Use `_` or `_klass` as a variable name to indicate that it won't be used. [rubocop]\r\n82: Useless assignment to variable - `dummy`. Use `_` or `_dummy` as a variable name to indicate that it won't be used. [rubocop]\r\n== app/models/metric/processing.rb (10 issues) ==\r\n57: Useless assignment to variable - `dummy`. Use `_` or `_dummy` as a variable name to indicate that it won't be used. [rubocop]\r\n== app/models/miq_report/formatting.rb (4 issues) ==\r\n175: Useless assignment to variable - `col`. Use `_` or `_col` as a variable name to indicate that it won't be used. [rubocop]\r\n== app/models/miq_report/generator.rb (18 issues) ==\r\n598: Useless assignment to variable - `data`. [rubocop]\r\n== app/models/miq_report/generator/html.rb (7 issues) ==\r\n3: Useless assignment to variable - `tz`. [rubocop]\r\n== app/models/miq_report/generator/trend.rb (4 issues) ==\r\n70: Useless assignment to variable - `err`. [rubocop]\r\n== app/models/miq_schedule_worker/runner.rb (6 issues) ==\r\n403: Useless assignment to variable - `interval`. [rubocop]\r\n== app/models/miq_server/server_smart_proxy.rb (8 issues) ==\r\n173: Useless assignment to variable - `err`. [rubocop]\r\n== app/models/miq_vim_broker_worker.rb (8 issues) ==\r\n61: Useless assignment to variable - `scheme`. Use `_` or `_scheme` as a variable name to indicate that it won't be used. [rubocop]\r\n61: Useless assignment to variable - `userinfo`. Use `_` or `_userinfo` as a variable name to indicate that it won't be used. [rubocop]\r\n61: Useless assignment to variable - `host`. Use `_` or `_host` as a variable name to indicate that it won't be used. [rubocop]\r\n61: Useless assignment to variable - `registry`. Use `_` or `_registry` as a variable name to indicate that it won't be used. [rubocop]\r\n61: Useless assignment to variable - `path`. Use `_` or `_path` as a variable name to indicate that it won't be used. [rubocop]\r\n61: Useless assignment to variable - `opaque`. Use `_` or `_opaque` as a variable name to indicate that it won't be used. [rubocop]\r\n61: Useless assignment to variable - `query`. Use `_` or `_query` as a variable name to indicate that it won't be used. [rubocop]\r\n61: Useless assignment to variable - `fragment`. Use `_` or `_fragment` as a variable name to indicate that it won't be used. [rubocop]\r\n== app/models/mixins/file_depot_mixin.rb (8 issues) ==\r\n40: Useless assignment to variable - `userinfo`. Use `_` or `_userinfo` as a variable name to indicate that it won't be used. [rubocop]\r\n40: Useless assignment to variable - `host`. Use `_` or `_host` as a variable name to indicate that it won't be used. [rubocop]\r\n40: Useless assignment to variable - `port`. Use `_` or `_port` as a variable name to indicate that it won't be used. [rubocop]\r\n40: Useless assignment to variable - `registry`. Use `_` or `_registry` as a variable name to indicate that it won't be used. [rubocop]\r\n40: Useless assignment to variable - `path`. Use `_` or `_path` as a variable name to indicate that it won't be used. [rubocop]\r\n40: Useless assignment to variable - `opaque`. Use `_` or `_opaque` as a variable name to indicate that it won't be used. [rubocop]\r\n40: Useless assignment to variable - `query`. Use `_` or `_query` as a variable name to indicate that it won't be used. [rubocop]\r\n40: Useless assignment to variable - `fragment`. Use `_` or `_fragment` as a variable name to indicate that it won't be used. [rubocop]\r\n== app/models/mixins/miq_policy_mixin.rb (1 issue) ==\r\n157: Useless assignment to variable - `tid`. [rubocop]\r\n== app/models/mixins/relationship_mixin.rb (5 issues) ==\r\n507: Useless assignment to variable - `rels`. [rubocop]\r\n== app/models/resource_action.rb (1 issue) ==\r\n45: Useless assignment to variable - `attr_name`. Use `_` or `_attr_name` as a variable name to indicate that it won't be used. [rubocop]\r\n== app/models/rss_feed.rb (9 issues) ==\r\n51: Useless assignment to variable - `limit`. [rubocop]\r\n119: Useless assignment to variable - `items`. Did you mean `item_class`? [rubocop]\r\n== app/models/storage.rb (14 issues) ==\r\n700: Useless assignment to variable - `klass`. Use `_` or `_klass` as a variable name to indicate that it won't be used. [rubocop]\r\n702: Useless assignment to variable - `dummy`. Use `_` or `_dummy` as a variable name to indicate that it won't be used. [rubocop]\r\n== app/models/vim_performance_analysis.rb (13 issues) ==\r\n219: Useless assignment to variable - `k`. Use `_` or `_k` as a variable name to indicate that it won't be used. [rubocop]\r\n220: Useless assignment to variable - `t`. Use just operator `+`. [rubocop]\r\n542: Useless assignment to variable - `ts`. Use `_` or `_ts` as a variable name to indicate that it won't be used. [rubocop]\r\n== app/models/vim_performance_planning.rb (3 issues) ==\r\n72: Useless assignment to variable - `method`. [rubocop]\r\n== app/models/vim_performance_trend.rb (9 issues) ==\r\n41: Useless assignment to variable - `limit_col`. [rubocop]\r\n248: Useless assignment to variable - `limit_pct_cols`. [rubocop]\r\n== app/models/vm_or_template.rb (22 issues) ==\r\n605: Useless assignment to variable - `vmobj`. [rubocop]\r\n== app/models/vm_or_template/right_sizing.rb (3 issues) ==\r\n214: Useless assignment to variable - `result`. [rubocop]\r\n== app/models/vm_scan.rb (13 issues) ==\r\n479: Useless assignment to variable - `status`. Use `_` or `_status` as a variable name to indicate that it won't be used. [rubocop]\r\n== app/models/vmdb_index/seeding.rb (1 issue) ==\r\n8: Useless assignment to variable - `index`. [rubocop]\r\n== db/fixtures/miq_provision_naming.rb (1 issue) ==\r\n6: Useless assignment to variable - `tags`. [rubocop]\r\n== lib/extensions/ar_adapter/ar_dba.rb (8 issues) ==\r\n23: Useless assignment to variable - `data`. [rubocop]\r\n== lib/extensions/ar_taggable.rb (1 issue) ==\r\n159: Useless assignment to variable - `err`. [rubocop]\r\n== lib/extensions/ar_to_model_hash.rb (3 issues) ==\r\n115: Useless assignment to variable - `result`. Use just operator `+`. [rubocop]\r\n== lib/miq_expression/relative_datetime.rb (1 issue) ==\r\n30: Useless assignment to variable - `ago`. Use `_` or `_ago` as a variable name to indicate that it won't be used. [rubocop]\r\n== lib/miq_expression/where_extraction_visitor.rb (1 issue) ==\r\n4: Useless assignment to variable - `collector`. [rubocop]\r\n== lib/miq_ldap.rb (17 issues) ==\r\n70: Useless assignment to variable - `canonical`. Use `_` or `_canonical` as a variable name to indicate that it won't be used. [rubocop]\r\n70: Useless assignment to variable - `aliases`. Use `_` or `_aliases` as a variable name to indicate that it won't be used. [rubocop]\r\n70: Useless assignment to variable - `type`. Use `_` or `_type` as a variable name to indicate that it won't be used. [rubocop]\r\n190: Useless assignment to variable - `userinfo`. Use `_` or `_userinfo` as a variable name to indicate that it won't be used. [rubocop]\r\n190: Useless assignment to variable - `registry`. Use `_` or `_registry` as a variable name to indicate that it won't be used. [rubocop]\r\n190: Useless assignment to variable - `opaque`. Use `_` or `_opaque` as a variable name to indicate that it won't be used. [rubocop]\r\n190: Useless assignment to variable - `query`. Use `_` or `_query` as a variable name to indicate that it won't be used. [rubocop]\r\n190: Useless assignment to variable - `fragment`. Use `_` or `_fragment` as a variable name to indicate that it won't be used. [rubocop]\r\n== lib/resource_feeder/lib/resource_feeder/atom.rb (4 issues) ==\r\n57: Useless assignment to variable - `author`. [rubocop]\r\n== lib/vmdb/config/validator.rb (6 issues) ==\r\n122: Useless assignment to variable - `key`. Use `_` or `_key` as a variable name to indicate that it won't be used. [rubocop]\r\n122: Useless assignment to variable - `message`. Use `_` or `_message` as a variable name to indicate that it won't be used. [rubocop]\r\n== product/script/export_policy_profiles.rb (3 issues) ==\r\n6: Useless assignment to variable - `p1`. [rubocop]\r\n25: Useless assignment to variable - `err`. [rubocop]\r\n== product/script/import_policy_profile.rb (2 issues) ==\r\n6: Useless assignment to variable - `p1`. [rubocop]\r\n== tools/dba.rb (6 issues) ==\r\n13: Useless assignment to variable - `all_connections`. [rubocop]\r\n33: Useless assignment to variable - `db_array`. [rubocop]\r\n171: Useless assignment to variable - `tbl_array`. [rubocop]\r\n247: Useless assignment to variable - `idx_array`. [rubocop]\r\n334: Useless assignment to variable - `tbl_stats_array`. [rubocop]\r\n357: Useless assignment to variable - `tbl_size_array`. [rubocop]\r\n== tools/env_probe_event_catcher.rb (4 issues) ==\r\n26: Useless assignment to variable - `tid`. [rubocop]\r\n43: Useless assignment to variable - `sub_event_type`. [rubocop]\r\n== tools/env_probe_vc_inv.rb (4 issues) ==\r\n63: Useless assignment to variable - `con`. [rubocop]\r\n64: Useless assignment to variable - `inv`. [rubocop]\r\n== tools/fix_disk_sizes.rb (1 issue) ==\r\n39: Useless assignment to variable - `vim`. [rubocop]\r\n== tools/ldap_ping.rb (4 issues) ==\r\n41: Useless assignment to variable - `canonical`. Use `_` or `_canonical` as a variable name to indicate that it won't be used. [rubocop]\r\n41: Useless assignment to variable - `aliases`. Use `_` or `_aliases` as a variable name to indicate that it won't be used. [rubocop]\r\n41: Useless assignment to variable - `type`. Use `_` or `_type` as a variable name to indicate that it won't be used. [rubocop]\r\n```"},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments/337640823","html_url":"https://github.com/ManageIQ/manageiq/issues/16092#issuecomment-337640823","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/16092","id":337640823,"user":{"login":"chessbyte","id":82161,"avatar_url":"https://avatars2.githubusercontent.com/u/82161?v=4","gravatar_id":"","url":"https://api.github.com/users/chessbyte","html_url":"https://github.com/chessbyte","followers_url":"https://api.github.com/users/chessbyte/followers","following_url":"https://api.github.com/users/chessbyte/following{/other_user}","gists_url":"https://api.github.com/users/chessbyte/gists{/gist_id}","starred_url":"https://api.github.com/users/chessbyte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chessbyte/subscriptions","organizations_url":"https://api.github.com/users/chessbyte/orgs","repos_url":"https://api.github.com/users/chessbyte/repos","events_url":"https://api.github.com/users/chessbyte/events{/privacy}","received_events_url":"https://api.github.com/users/chessbyte/received_events","type":"User","site_admin":false},"created_at":"2017-10-18T16:01:24Z","updated_at":"2017-10-18T16:01:24Z","author_association":"OWNER","body":"@chrisarcand please review the referenced PRs"}}
{"actor":{"display_login":"chessbyte"}}