{"action":"created","comment":{"url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/comments/106406017","pull_request_review_id":27324888,"id":106406017,"diff_hunk":"@@ -366,6 +366,23 @@ def ha_config_errors(check)\n             help: I18n.t(\"api.upgrade.prechecks.ha_configured.help.default\")\n           }\n         end\n+        if check[:roles_not_ha]\n+          ret[:roles_not_ha] = {\n+            data: I18n.t(\"api.upgrade.prechecks.roles_not_ha.error\",\n+              roles: check[:roles_not_ha].join(\", \")),\n+            help: I18n.t(\"api.upgrade.prechecks.roles_not_ha.help\")\n+          }\n+        end\n+        if check[:role_conflicts]\n+          nodes = check[:role_conflicts].map do |node,roles|","path":"crowbar_framework/app/models/api/upgrade.rb","position":12,"original_position":12,"commit_id":"aa09fe8ff3a9d7c0689018d785296cead6412c9a","original_commit_id":"aa09fe8ff3a9d7c0689018d785296cead6412c9a","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars3.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Style/SpaceAfterComma: Space missing after comma. (https://github.com/bbatsov/ruby-style-guide#spaces-operators)","created_at":"2017-03-16T12:38:08Z","updated_at":"2017-03-16T12:38:08Z","html_url":"https://github.com/crowbar/crowbar-core/pull/1170#discussion_r106406017","pull_request_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/1170","_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/comments/106406017"},"html":{"href":"https://github.com/crowbar/crowbar-core/pull/1170#discussion_r106406017"},"pull_request":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/1170"}}},"pull_request":{"url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/1170","id":111033749,"html_url":"https://github.com/crowbar/crowbar-core/pull/1170","diff_url":"https://github.com/crowbar/crowbar-core/pull/1170.diff","patch_url":"https://github.com/crowbar/crowbar-core/pull/1170.patch","issue_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/1170","number":1170,"state":"open","locked":false,"title":"upgrade: Extend the deployment prechecks","user":{"login":"jsuchome","id":910000,"avatar_url":"https://avatars1.githubusercontent.com/u/910000?v=3","gravatar_id":"","url":"https://api.github.com/users/jsuchome","html_url":"https://github.com/jsuchome","followers_url":"https://api.github.com/users/jsuchome/followers","following_url":"https://api.github.com/users/jsuchome/following{/other_user}","gists_url":"https://api.github.com/users/jsuchome/gists{/gist_id}","starred_url":"https://api.github.com/users/jsuchome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsuchome/subscriptions","organizations_url":"https://api.github.com/users/jsuchome/orgs","repos_url":"https://api.github.com/users/jsuchome/repos","events_url":"https://api.github.com/users/jsuchome/events{/privacy}","received_events_url":"https://api.github.com/users/jsuchome/received_events","type":"User","site_admin":false},"body":"Make really sure controller nodes are HA\r\n\r\nThis is not yet 'mixed-setup check', but it is related.","created_at":"2017-03-16T10:19:03Z","updated_at":"2017-03-16T12:38:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"82d1a0da3cb772a6dd3ca97151b35cea091072c5","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/1170/commits","review_comments_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/1170/comments","review_comment_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/1170/comments","statuses_url":"https://api.github.com/repos/crowbar/crowbar-core/statuses/aa09fe8ff3a9d7c0689018d785296cead6412c9a","head":{"label":"jsuchome:better-ha-check","ref":"better-ha-check","sha":"aa09fe8ff3a9d7c0689018d785296cead6412c9a","user":{"login":"jsuchome","id":910000,"avatar_url":"https://avatars1.githubusercontent.com/u/910000?v=3","gravatar_id":"","url":"https://api.github.com/users/jsuchome","html_url":"https://github.com/jsuchome","followers_url":"https://api.github.com/users/jsuchome/followers","following_url":"https://api.github.com/users/jsuchome/following{/other_user}","gists_url":"https://api.github.com/users/jsuchome/gists{/gist_id}","starred_url":"https://api.github.com/users/jsuchome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsuchome/subscriptions","organizations_url":"https://api.github.com/users/jsuchome/orgs","repos_url":"https://api.github.com/users/jsuchome/repos","events_url":"https://api.github.com/users/jsuchome/events{/privacy}","received_events_url":"https://api.github.com/users/jsuchome/received_events","type":"User","site_admin":false},"repo":{"id":44730679,"name":"crowbar-core","full_name":"jsuchome/crowbar-core","owner":{"login":"jsuchome","id":910000,"avatar_url":"https://avatars1.githubusercontent.com/u/910000?v=3","gravatar_id":"","url":"https://api.github.com/users/jsuchome","html_url":"https://github.com/jsuchome","followers_url":"https://api.github.com/users/jsuchome/followers","following_url":"https://api.github.com/users/jsuchome/following{/other_user}","gists_url":"https://api.github.com/users/jsuchome/gists{/gist_id}","starred_url":"https://api.github.com/users/jsuchome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsuchome/subscriptions","organizations_url":"https://api.github.com/users/jsuchome/orgs","repos_url":"https://api.github.com/users/jsuchome/repos","events_url":"https://api.github.com/users/jsuchome/events{/privacy}","received_events_url":"https://api.github.com/users/jsuchome/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jsuchome/crowbar-core","description":"Core deployment for Crowbar","fork":true,"url":"https://api.github.com/repos/jsuchome/crowbar-core","forks_url":"https://api.github.com/repos/jsuchome/crowbar-core/forks","keys_url":"https://api.github.com/repos/jsuchome/crowbar-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jsuchome/crowbar-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jsuchome/crowbar-core/teams","hooks_url":"https://api.github.com/repos/jsuchome/crowbar-core/hooks","issue_events_url":"https://api.github.com/repos/jsuchome/crowbar-core/issues/events{/number}","events_url":"https://api.github.com/repos/jsuchome/crowbar-core/events","assignees_url":"https://api.github.com/repos/jsuchome/crowbar-core/assignees{/user}","branches_url":"https://api.github.com/repos/jsuchome/crowbar-core/branches{/branch}","tags_url":"https://api.github.com/repos/jsuchome/crowbar-core/tags","blobs_url":"https://api.github.com/repos/jsuchome/crowbar-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jsuchome/crowbar-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jsuchome/crowbar-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/jsuchome/crowbar-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jsuchome/crowbar-core/statuses/{sha}","languages_url":"https://api.github.com/repos/jsuchome/crowbar-core/languages","stargazers_url":"https://api.github.com/repos/jsuchome/crowbar-core/stargazers","contributors_url":"https://api.github.com/repos/jsuchome/crowbar-core/contributors","subscribers_url":"https://api.github.com/repos/jsuchome/crowbar-core/subscribers","subscription_url":"https://api.github.com/repos/jsuchome/crowbar-core/subscription","commits_url":"https://api.github.com/repos/jsuchome/crowbar-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/jsuchome/crowbar-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/jsuchome/crowbar-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/jsuchome/crowbar-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/jsuchome/crowbar-core/contents/{+path}","compare_url":"https://api.github.com/repos/jsuchome/crowbar-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jsuchome/crowbar-core/merges","archive_url":"https://api.github.com/repos/jsuchome/crowbar-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jsuchome/crowbar-core/downloads","issues_url":"https://api.github.com/repos/jsuchome/crowbar-core/issues{/number}","pulls_url":"https://api.github.com/repos/jsuchome/crowbar-core/pulls{/number}","milestones_url":"https://api.github.com/repos/jsuchome/crowbar-core/milestones{/number}","notifications_url":"https://api.github.com/repos/jsuchome/crowbar-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jsuchome/crowbar-core/labels{/name}","releases_url":"https://api.github.com/repos/jsuchome/crowbar-core/releases{/id}","deployments_url":"https://api.github.com/repos/jsuchome/crowbar-core/deployments","created_at":"2015-10-22T07:59:41Z","updated_at":"2017-02-07T07:32:28Z","pushed_at":"2017-03-16T12:37:52Z","git_url":"git://github.com/jsuchome/crowbar-core.git","ssh_url":"git@github.com:jsuchome/crowbar-core.git","clone_url":"https://github.com/jsuchome/crowbar-core.git","svn_url":"https://github.com/jsuchome/crowbar-core","homepage":null,"size":107947,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crowbar:stable/3.0","ref":"stable/3.0","sha":"2800aee6549b7ce383e61f89bf8b92154cefb7be","user":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars1.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"repo":{"id":39003227,"name":"crowbar-core","full_name":"crowbar/crowbar-core","owner":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars1.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crowbar/crowbar-core","description":"Core deployment for Crowbar","fork":false,"url":"https://api.github.com/repos/crowbar/crowbar-core","forks_url":"https://api.github.com/repos/crowbar/crowbar-core/forks","keys_url":"https://api.github.com/repos/crowbar/crowbar-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crowbar/crowbar-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crowbar/crowbar-core/teams","hooks_url":"https://api.github.com/repos/crowbar/crowbar-core/hooks","issue_events_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/events{/number}","events_url":"https://api.github.com/repos/crowbar/crowbar-core/events","assignees_url":"https://api.github.com/repos/crowbar/crowbar-core/assignees{/user}","branches_url":"https://api.github.com/repos/crowbar/crowbar-core/branches{/branch}","tags_url":"https://api.github.com/repos/crowbar/crowbar-core/tags","blobs_url":"https://api.github.com/repos/crowbar/crowbar-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crowbar/crowbar-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crowbar/crowbar-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/crowbar/crowbar-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crowbar/crowbar-core/statuses/{sha}","languages_url":"https://api.github.com/repos/crowbar/crowbar-core/languages","stargazers_url":"https://api.github.com/repos/crowbar/crowbar-core/stargazers","contributors_url":"https://api.github.com/repos/crowbar/crowbar-core/contributors","subscribers_url":"https://api.github.com/repos/crowbar/crowbar-core/subscribers","subscription_url":"https://api.github.com/repos/crowbar/crowbar-core/subscription","commits_url":"https://api.github.com/repos/crowbar/crowbar-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/crowbar/crowbar-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/crowbar/crowbar-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/crowbar/crowbar-core/contents/{+path}","compare_url":"https://api.github.com/repos/crowbar/crowbar-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crowbar/crowbar-core/merges","archive_url":"https://api.github.com/repos/crowbar/crowbar-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crowbar/crowbar-core/downloads","issues_url":"https://api.github.com/repos/crowbar/crowbar-core/issues{/number}","pulls_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls{/number}","milestones_url":"https://api.github.com/repos/crowbar/crowbar-core/milestones{/number}","notifications_url":"https://api.github.com/repos/crowbar/crowbar-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crowbar/crowbar-core/labels{/name}","releases_url":"https://api.github.com/repos/crowbar/crowbar-core/releases{/id}","deployments_url":"https://api.github.com/repos/crowbar/crowbar-core/deployments","created_at":"2015-07-13T09:31:28Z","updated_at":"2016-11-11T19:16:44Z","pushed_at":"2017-03-16T12:37:53Z","git_url":"git://github.com/crowbar/crowbar-core.git","ssh_url":"git@github.com:crowbar/crowbar-core.git","clone_url":"https://github.com/crowbar/crowbar-core.git","svn_url":"https://github.com/crowbar/crowbar-core","homepage":null,"size":107971,"stargazers_count":9,"watchers_count":9,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":42,"mirror_url":null,"open_issues_count":50,"forks":42,"open_issues":50,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/1170"},"html":{"href":"https://github.com/crowbar/crowbar-core/pull/1170"},"issue":{"href":"https://api.github.com/repos/crowbar/crowbar-core/issues/1170"},"comments":{"href":"https://api.github.com/repos/crowbar/crowbar-core/issues/1170/comments"},"review_comments":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/1170/comments"},"review_comment":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/1170/commits"},"statuses":{"href":"https://api.github.com/repos/crowbar/crowbar-core/statuses/aa09fe8ff3a9d7c0689018d785296cead6412c9a"}}}}
{"actor":{"display_login":"houndci-bot"}}