{"action":"created","comment":{"url":"https://api.github.com/repos/simplybusiness/jimmy/pulls/comments/130041916","pull_request_review_id":52876087,"id":130041916,"diff_hunk":"@@ -1,7 +1,7 @@\n module Jimmy\n   class Entry < Hash\n     def <<(hash)\n-      self.merge!(hash)\n+      self.merge!(hash.try(:to_unsafe_h) || hash)","path":"lib/jimmy/log_entry.rb","position":5,"original_position":5,"commit_id":"9ba972cea4c5b0e4bde21ddca356f69bb00551aa","original_commit_id":"9ba972cea4c5b0e4bde21ddca356f69bb00551aa","user":{"login":"dragosmiron","id":353922,"avatar_url":"https://avatars0.githubusercontent.com/u/353922?v=4","gravatar_id":"","url":"https://api.github.com/users/dragosmiron","html_url":"https://github.com/dragosmiron","followers_url":"https://api.github.com/users/dragosmiron/followers","following_url":"https://api.github.com/users/dragosmiron/following{/other_user}","gists_url":"https://api.github.com/users/dragosmiron/gists{/gist_id}","starred_url":"https://api.github.com/users/dragosmiron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dragosmiron/subscriptions","organizations_url":"https://api.github.com/users/dragosmiron/orgs","repos_url":"https://api.github.com/users/dragosmiron/repos","events_url":"https://api.github.com/users/dragosmiron/events{/privacy}","received_events_url":"https://api.github.com/users/dragosmiron/received_events","type":"User","site_admin":false},"body":"i see so that hash is not really a hash. can't we just convert to hash before sending here?","created_at":"2017-07-28T08:49:27Z","updated_at":"2017-07-28T08:49:27Z","html_url":"https://github.com/simplybusiness/jimmy/pull/4#discussion_r130041916","pull_request_url":"https://api.github.com/repos/simplybusiness/jimmy/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/simplybusiness/jimmy/pulls/comments/130041916"},"html":{"href":"https://github.com/simplybusiness/jimmy/pull/4#discussion_r130041916"},"pull_request":{"href":"https://api.github.com/repos/simplybusiness/jimmy/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/simplybusiness/jimmy/pulls/4","id":132749090,"html_url":"https://github.com/simplybusiness/jimmy/pull/4","diff_url":"https://github.com/simplybusiness/jimmy/pull/4.diff","patch_url":"https://github.com/simplybusiness/jimmy/pull/4.patch","issue_url":"https://api.github.com/repos/simplybusiness/jimmy/issues/4","number":4,"state":"open","locked":false,"title":"Remove to hash deprecation","user":{"login":"dncrht","id":1925289,"avatar_url":"https://avatars2.githubusercontent.com/u/1925289?v=4","gravatar_id":"","url":"https://api.github.com/users/dncrht","html_url":"https://github.com/dncrht","followers_url":"https://api.github.com/users/dncrht/followers","following_url":"https://api.github.com/users/dncrht/following{/other_user}","gists_url":"https://api.github.com/users/dncrht/gists{/gist_id}","starred_url":"https://api.github.com/users/dncrht/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dncrht/subscriptions","organizations_url":"https://api.github.com/users/dncrht/orgs","repos_url":"https://api.github.com/users/dncrht/repos","events_url":"https://api.github.com/users/dncrht/events{/privacy}","received_events_url":"https://api.github.com/users/dncrht/received_events","type":"User","site_admin":false},"body":"Treat ActionController::Parameters as plan hashes, and keep using plain hashes as such.\r\n\r\n@andrewgristwood @dragosmiron @mineshdattani @sivanpatel","created_at":"2017-07-27T13:30:55Z","updated_at":"2017-07-28T08:49:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"af24bec3f921ec7d38c20dcbbb4b66c7e430457e","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/simplybusiness/jimmy/pulls/4/commits","review_comments_url":"https://api.github.com/repos/simplybusiness/jimmy/pulls/4/comments","review_comment_url":"https://api.github.com/repos/simplybusiness/jimmy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/simplybusiness/jimmy/issues/4/comments","statuses_url":"https://api.github.com/repos/simplybusiness/jimmy/statuses/9ba972cea4c5b0e4bde21ddca356f69bb00551aa","head":{"label":"simplybusiness:remove-to_hash-deprecation","ref":"remove-to_hash-deprecation","sha":"9ba972cea4c5b0e4bde21ddca356f69bb00551aa","user":{"login":"simplybusiness","id":465825,"avatar_url":"https://avatars3.githubusercontent.com/u/465825?v=4","gravatar_id":"","url":"https://api.github.com/users/simplybusiness","html_url":"https://github.com/simplybusiness","followers_url":"https://api.github.com/users/simplybusiness/followers","following_url":"https://api.github.com/users/simplybusiness/following{/other_user}","gists_url":"https://api.github.com/users/simplybusiness/gists{/gist_id}","starred_url":"https://api.github.com/users/simplybusiness/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simplybusiness/subscriptions","organizations_url":"https://api.github.com/users/simplybusiness/orgs","repos_url":"https://api.github.com/users/simplybusiness/repos","events_url":"https://api.github.com/users/simplybusiness/events{/privacy}","received_events_url":"https://api.github.com/users/simplybusiness/received_events","type":"Organization","site_admin":false},"repo":{"id":57395436,"name":"jimmy","full_name":"simplybusiness/jimmy","owner":{"login":"simplybusiness","id":465825,"avatar_url":"https://avatars3.githubusercontent.com/u/465825?v=4","gravatar_id":"","url":"https://api.github.com/users/simplybusiness","html_url":"https://github.com/simplybusiness","followers_url":"https://api.github.com/users/simplybusiness/followers","following_url":"https://api.github.com/users/simplybusiness/following{/other_user}","gists_url":"https://api.github.com/users/simplybusiness/gists{/gist_id}","starred_url":"https://api.github.com/users/simplybusiness/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simplybusiness/subscriptions","organizations_url":"https://api.github.com/users/simplybusiness/orgs","repos_url":"https://api.github.com/users/simplybusiness/repos","events_url":"https://api.github.com/users/simplybusiness/events{/privacy}","received_events_url":"https://api.github.com/users/simplybusiness/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/simplybusiness/jimmy","description":"Jimmy is a middleware to store the Rails logs as one entry per request in JSON format","fork":false,"url":"https://api.github.com/repos/simplybusiness/jimmy","forks_url":"https://api.github.com/repos/simplybusiness/jimmy/forks","keys_url":"https://api.github.com/repos/simplybusiness/jimmy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/simplybusiness/jimmy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/simplybusiness/jimmy/teams","hooks_url":"https://api.github.com/repos/simplybusiness/jimmy/hooks","issue_events_url":"https://api.github.com/repos/simplybusiness/jimmy/issues/events{/number}","events_url":"https://api.github.com/repos/simplybusiness/jimmy/events","assignees_url":"https://api.github.com/repos/simplybusiness/jimmy/assignees{/user}","branches_url":"https://api.github.com/repos/simplybusiness/jimmy/branches{/branch}","tags_url":"https://api.github.com/repos/simplybusiness/jimmy/tags","blobs_url":"https://api.github.com/repos/simplybusiness/jimmy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/simplybusiness/jimmy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/simplybusiness/jimmy/git/refs{/sha}","trees_url":"https://api.github.com/repos/simplybusiness/jimmy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/simplybusiness/jimmy/statuses/{sha}","languages_url":"https://api.github.com/repos/simplybusiness/jimmy/languages","stargazers_url":"https://api.github.com/repos/simplybusiness/jimmy/stargazers","contributors_url":"https://api.github.com/repos/simplybusiness/jimmy/contributors","subscribers_url":"https://api.github.com/repos/simplybusiness/jimmy/subscribers","subscription_url":"https://api.github.com/repos/simplybusiness/jimmy/subscription","commits_url":"https://api.github.com/repos/simplybusiness/jimmy/commits{/sha}","git_commits_url":"https://api.github.com/repos/simplybusiness/jimmy/git/commits{/sha}","comments_url":"https://api.github.com/repos/simplybusiness/jimmy/comments{/number}","issue_comment_url":"https://api.github.com/repos/simplybusiness/jimmy/issues/comments{/number}","contents_url":"https://api.github.com/repos/simplybusiness/jimmy/contents/{+path}","compare_url":"https://api.github.com/repos/simplybusiness/jimmy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/simplybusiness/jimmy/merges","archive_url":"https://api.github.com/repos/simplybusiness/jimmy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/simplybusiness/jimmy/downloads","issues_url":"https://api.github.com/repos/simplybusiness/jimmy/issues{/number}","pulls_url":"https://api.github.com/repos/simplybusiness/jimmy/pulls{/number}","milestones_url":"https://api.github.com/repos/simplybusiness/jimmy/milestones{/number}","notifications_url":"https://api.github.com/repos/simplybusiness/jimmy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/simplybusiness/jimmy/labels{/name}","releases_url":"https://api.github.com/repos/simplybusiness/jimmy/releases{/id}","deployments_url":"https://api.github.com/repos/simplybusiness/jimmy/deployments","created_at":"2016-04-29T15:42:15Z","updated_at":"2016-11-24T16:44:08Z","pushed_at":"2017-07-27T13:30:55Z","git_url":"git://github.com/simplybusiness/jimmy.git","ssh_url":"git@github.com:simplybusiness/jimmy.git","clone_url":"https://github.com/simplybusiness/jimmy.git","svn_url":"https://github.com/simplybusiness/jimmy","homepage":"","size":27,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"simplybusiness:master","ref":"master","sha":"b322785f7168bb24ae6819c658a74ca941d7ed4a","user":{"login":"simplybusiness","id":465825,"avatar_url":"https://avatars3.githubusercontent.com/u/465825?v=4","gravatar_id":"","url":"https://api.github.com/users/simplybusiness","html_url":"https://github.com/simplybusiness","followers_url":"https://api.github.com/users/simplybusiness/followers","following_url":"https://api.github.com/users/simplybusiness/following{/other_user}","gists_url":"https://api.github.com/users/simplybusiness/gists{/gist_id}","starred_url":"https://api.github.com/users/simplybusiness/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simplybusiness/subscriptions","organizations_url":"https://api.github.com/users/simplybusiness/orgs","repos_url":"https://api.github.com/users/simplybusiness/repos","events_url":"https://api.github.com/users/simplybusiness/events{/privacy}","received_events_url":"https://api.github.com/users/simplybusiness/received_events","type":"Organization","site_admin":false},"repo":{"id":57395436,"name":"jimmy","full_name":"simplybusiness/jimmy","owner":{"login":"simplybusiness","id":465825,"avatar_url":"https://avatars3.githubusercontent.com/u/465825?v=4","gravatar_id":"","url":"https://api.github.com/users/simplybusiness","html_url":"https://github.com/simplybusiness","followers_url":"https://api.github.com/users/simplybusiness/followers","following_url":"https://api.github.com/users/simplybusiness/following{/other_user}","gists_url":"https://api.github.com/users/simplybusiness/gists{/gist_id}","starred_url":"https://api.github.com/users/simplybusiness/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simplybusiness/subscriptions","organizations_url":"https://api.github.com/users/simplybusiness/orgs","repos_url":"https://api.github.com/users/simplybusiness/repos","events_url":"https://api.github.com/users/simplybusiness/events{/privacy}","received_events_url":"https://api.github.com/users/simplybusiness/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/simplybusiness/jimmy","description":"Jimmy is a middleware to store the Rails logs as one entry per request in JSON format","fork":false,"url":"https://api.github.com/repos/simplybusiness/jimmy","forks_url":"https://api.github.com/repos/simplybusiness/jimmy/forks","keys_url":"https://api.github.com/repos/simplybusiness/jimmy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/simplybusiness/jimmy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/simplybusiness/jimmy/teams","hooks_url":"https://api.github.com/repos/simplybusiness/jimmy/hooks","issue_events_url":"https://api.github.com/repos/simplybusiness/jimmy/issues/events{/number}","events_url":"https://api.github.com/repos/simplybusiness/jimmy/events","assignees_url":"https://api.github.com/repos/simplybusiness/jimmy/assignees{/user}","branches_url":"https://api.github.com/repos/simplybusiness/jimmy/branches{/branch}","tags_url":"https://api.github.com/repos/simplybusiness/jimmy/tags","blobs_url":"https://api.github.com/repos/simplybusiness/jimmy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/simplybusiness/jimmy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/simplybusiness/jimmy/git/refs{/sha}","trees_url":"https://api.github.com/repos/simplybusiness/jimmy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/simplybusiness/jimmy/statuses/{sha}","languages_url":"https://api.github.com/repos/simplybusiness/jimmy/languages","stargazers_url":"https://api.github.com/repos/simplybusiness/jimmy/stargazers","contributors_url":"https://api.github.com/repos/simplybusiness/jimmy/contributors","subscribers_url":"https://api.github.com/repos/simplybusiness/jimmy/subscribers","subscription_url":"https://api.github.com/repos/simplybusiness/jimmy/subscription","commits_url":"https://api.github.com/repos/simplybusiness/jimmy/commits{/sha}","git_commits_url":"https://api.github.com/repos/simplybusiness/jimmy/git/commits{/sha}","comments_url":"https://api.github.com/repos/simplybusiness/jimmy/comments{/number}","issue_comment_url":"https://api.github.com/repos/simplybusiness/jimmy/issues/comments{/number}","contents_url":"https://api.github.com/repos/simplybusiness/jimmy/contents/{+path}","compare_url":"https://api.github.com/repos/simplybusiness/jimmy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/simplybusiness/jimmy/merges","archive_url":"https://api.github.com/repos/simplybusiness/jimmy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/simplybusiness/jimmy/downloads","issues_url":"https://api.github.com/repos/simplybusiness/jimmy/issues{/number}","pulls_url":"https://api.github.com/repos/simplybusiness/jimmy/pulls{/number}","milestones_url":"https://api.github.com/repos/simplybusiness/jimmy/milestones{/number}","notifications_url":"https://api.github.com/repos/simplybusiness/jimmy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/simplybusiness/jimmy/labels{/name}","releases_url":"https://api.github.com/repos/simplybusiness/jimmy/releases{/id}","deployments_url":"https://api.github.com/repos/simplybusiness/jimmy/deployments","created_at":"2016-04-29T15:42:15Z","updated_at":"2016-11-24T16:44:08Z","pushed_at":"2017-07-27T13:30:55Z","git_url":"git://github.com/simplybusiness/jimmy.git","ssh_url":"git@github.com:simplybusiness/jimmy.git","clone_url":"https://github.com/simplybusiness/jimmy.git","svn_url":"https://github.com/simplybusiness/jimmy","homepage":"","size":27,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/simplybusiness/jimmy/pulls/4"},"html":{"href":"https://github.com/simplybusiness/jimmy/pull/4"},"issue":{"href":"https://api.github.com/repos/simplybusiness/jimmy/issues/4"},"comments":{"href":"https://api.github.com/repos/simplybusiness/jimmy/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/simplybusiness/jimmy/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/simplybusiness/jimmy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/simplybusiness/jimmy/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/simplybusiness/jimmy/statuses/9ba972cea4c5b0e4bde21ddca356f69bb00551aa"}}}}
{"actor":{"display_login":"dragosmiron"}}