{"action":"created","issue":{"url":"https://api.github.com/repos/google/googletest/issues/1136","repository_url":"https://api.github.com/repos/google/googletest","labels_url":"https://api.github.com/repos/google/googletest/issues/1136/labels{/name}","comments_url":"https://api.github.com/repos/google/googletest/issues/1136/comments","events_url":"https://api.github.com/repos/google/googletest/issues/1136/events","html_url":"https://github.com/google/googletest/pull/1136","id":239947496,"number":1136,"title":"Prevent implicit down cast. This may give compiler warnings.","user":{"login":"jokri","id":29763376,"avatar_url":"https://avatars3.githubusercontent.com/u/29763376?v=4","gravatar_id":"","url":"https://api.github.com/users/jokri","html_url":"https://github.com/jokri","followers_url":"https://api.github.com/users/jokri/followers","following_url":"https://api.github.com/users/jokri/following{/other_user}","gists_url":"https://api.github.com/users/jokri/gists{/gist_id}","starred_url":"https://api.github.com/users/jokri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jokri/subscriptions","organizations_url":"https://api.github.com/users/jokri/orgs","repos_url":"https://api.github.com/users/jokri/repos","events_url":"https://api.github.com/users/jokri/events{/privacy}","received_events_url":"https://api.github.com/users/jokri/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2017-07-01T12:49:20Z","updated_at":"2017-08-15T21:15:19Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/google/googletest/pulls/1136","html_url":"https://github.com/google/googletest/pull/1136","diff_url":"https://github.com/google/googletest/pull/1136.diff","patch_url":"https://github.com/google/googletest/pull/1136.patch"},"body":"This is a fix for issue #1133."},"comment":{"url":"https://api.github.com/repos/google/googletest/issues/comments/322591594","html_url":"https://github.com/google/googletest/pull/1136#issuecomment-322591594","issue_url":"https://api.github.com/repos/google/googletest/issues/1136","id":322591594,"user":{"login":"jokri","id":29763376,"avatar_url":"https://avatars3.githubusercontent.com/u/29763376?v=4","gravatar_id":"","url":"https://api.github.com/users/jokri","html_url":"https://github.com/jokri","followers_url":"https://api.github.com/users/jokri/followers","following_url":"https://api.github.com/users/jokri/following{/other_user}","gists_url":"https://api.github.com/users/jokri/gists{/gist_id}","starred_url":"https://api.github.com/users/jokri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jokri/subscriptions","organizations_url":"https://api.github.com/users/jokri/orgs","repos_url":"https://api.github.com/users/jokri/repos","events_url":"https://api.github.com/users/jokri/events{/privacy}","received_events_url":"https://api.github.com/users/jokri/received_events","type":"User","site_admin":false},"created_at":"2017-08-15T21:15:19Z","updated_at":"2017-08-15T21:15:19Z","body":"Is this the test evidence you are looking/asking for?\r\n\r\n`...\r\n<Project DefaultTargets=\"Build\" ToolsVersion=\"15.0\" xmlns=\"http://schemas.microsoft.com/developer/msbuild/2003\">\r\n...\r\n    <PlatformToolset>v141</PlatformToolset>\r\n...\r\n      <WarningLevel>Level4</WarningLevel>\r\n      <TreatWarningAsError>true</TreatWarningAsError>\r\n...\r\n\r\n\r\nbefore:\r\n1>------ Rebuild All started: Project: gmock, Configuration: Debug Win32 ------\r\n1>gmock-all.cc\r\n1>gtest-all.cc\r\n1>gmock.vcxproj -> H:\\contribute\\googletest-jokri\\googlemock\\msvc\\2017\\Debug\\gmock.lib\r\n2>------ Rebuild All started: Project: gmock_main, Configuration: Debug Win32 ------\r\n2>gmock_main.cc\r\n2>gmock_main.vcxproj -> H:\\contribute\\googletest-jokri\\googlemock\\msvc\\2017\\Debug\\gmock_main.lib\r\n3>------ Rebuild All started: Project: gmock_test, Configuration: Debug Win32 ------\r\n3>gmock_all_test.cc\r\n3>C:\\Program Files (x86)\\Microsoft Visual Studio\\2017\\Community\\VC\\Tools\\MSVC\\14.10.25017\\include\\tuple(165): error C2220: warning treated as error - no 'object' file generated\r\n3>C:\\Program Files (x86)\\Microsoft Visual Studio\\2017\\Community\\VC\\Tools\\MSVC\\14.10.25017\\include\\tuple(292): note: see reference to function template instantiation 'std::_Tuple_val<_This>::_Tuple_val<_Ty>(_Other &&)' being compiled\r\n3>        with\r\n3>        [\r\n3>            _This=short,\r\n3>            _Ty=int,\r\n3>            _Other=int\r\n3>        ]\r\n3>C:\\Program Files (x86)\\Microsoft Visual Studio\\2017\\Community\\VC\\Tools\\MSVC\\14.10.25017\\include\\tuple(291): note: see reference to function template instantiation 'std::_Tuple_val<_This>::_Tuple_val<_Ty>(_Other &&)' being compiled\r\n3>        with\r\n3>        [\r\n3>            _This=short,\r\n3>            _Ty=int,\r\n3>            _Other=int\r\n3>        ]\r\n3>C:\\Program Files (x86)\\Microsoft Visual Studio\\2017\\Community\\VC\\Tools\\MSVC\\14.10.25017\\include\\tuple(422): note: see reference to function template instantiation 'std::tuple<short,int,long>::tuple<std::_Exact_args_t,_Ty,_Ty,long,0>(_Tag,_This2 &&,_Ty &&,long &&)' being compiled\r\n3>        with\r\n3>        [\r\n3>            _Ty=int,\r\n3>            _Tag=std::_Exact_args_t,\r\n3>            _This2=int\r\n3>        ]\r\n3>C:\\Program Files (x86)\\Microsoft Visual Studio\\2017\\Community\\VC\\Tools\\MSVC\\14.10.25017\\include\\tuple(421): note: see reference to function template instantiation 'std::tuple<short,int,long>::tuple<std::_Exact_args_t,_Ty,_Ty,long,0>(_Tag,_This2 &&,_Ty &&,long &&)' being compiled\r\n3>        with\r\n3>        [\r\n3>            _Ty=int,\r\n3>            _Tag=std::_Exact_args_t,\r\n3>            _This2=int\r\n3>        ]\r\n3>H:\\contribute\\googletest-jokri\\googlemock\\test/gmock-generated-matchers_test.cc(123): note: see reference to function template instantiation 'std::tuple<short,int,long>::tuple<int,int,long,0>(_This2 &&,int &&,long &&)' being compiled\r\n3>        with\r\n3>        [\r\n3>            _This2=int\r\n3>        ]\r\n3>H:\\contribute\\googletest-jokri\\googlemock\\test/gmock-generated-matchers_test.cc(123): note: see reference to function template instantiation 'std::tuple<short,int,long>::tuple<int,int,long,0>(_This2 &&,int &&,long &&)' being compiled\r\n3>        with\r\n3>        [\r\n3>            _This2=int\r\n3>        ]\r\n3>C:\\Program Files (x86)\\Microsoft Visual Studio\\2017\\Community\\VC\\Tools\\MSVC\\14.10.25017\\include\\tuple(165): warning C4244: 'initializing': conversion from 'int' to 'short', possible loss of data\r\n3>Done building project \"gmock_test.vcxproj\" -- FAILED.\r\n========== Rebuild All: 2 succeeded, 1 failed, 0 skipped ==========\r\n\r\n\r\nafter:\r\n\r\n1>------ Rebuild All started: Project: gmock, Configuration: Debug Win32 ------\r\n1>gmock-all.cc\r\n1>gtest-all.cc\r\n1>gmock.vcxproj -> H:\\contribute\\googletest-jokri\\googlemock\\msvc\\2017\\Debug\\gmock.lib\r\n2>------ Rebuild All started: Project: gmock_main, Configuration: Debug Win32 ------\r\n2>gmock_main.cc\r\n2>gmock_main.vcxproj -> H:\\contribute\\googletest-jokri\\googlemock\\msvc\\2017\\Debug\\gmock_main.lib\r\n3>------ Rebuild All started: Project: gmock_test, Configuration: Debug Win32 ------\r\n3>gmock_all_test.cc\r\n3>gmock_test.vcxproj -> H:\\contribute\\googletest-jokri\\googlemock\\msvc\\2017\\Debug\\gmock_test.exe\r\n3>gmock_test.vcxproj -> H:\\contribute\\googletest-jokri\\googlemock\\msvc\\2017\\Debug\\gmock_test.pdb (Full PDB)\r\n========== Rebuild All: 3 succeeded, 0 failed, 0 skipped ==========\r\n`"}}
{"actor":{"display_login":"jokri"}}