{"action":"created","comment":{"url":"https://api.github.com/repos/NaluCFD/Nalu/pulls/comments/159028347","pull_request_review_id":85915530,"id":159028347,"diff_hunk":"@@ -815,3 +815,82 @@ slight degradation in order-of-accuracy is noted for the thexahedral topology.\n    :align: center\n \n    :math:`L_o` norms for the full set of hybrid Laplace MMS study.\n+\n+\n+Open Boundary Condition With Outflow Thermal Stratification\n+----------------------------------------------------------------\n+In situations with significant thermal stratification at the outflow of the domain, the standard open boundary\n+condition alone is not adequate because it requires the specification of motion pressure at the boundary, and\n+this is not known *a priori*.  Two solutions to this problem are: 1) to use the global mass flow rate correction\n+option, or 2) to use the standard open boundary condition in which the buoyancy term uses a local time-averaged\n+reference value, rather than a single reference value.\n+\n+We test these open boundary condition options on a simplified stratfied flow through a channel with slip walls.  The\n+flow entering the domain is non-turbulent and uniformly 8 m/s.  The temperature linearly varies from 300 K to 310 K from \n+the bottom to top of the channel with compatible, opposite-sign heat flux on the two walls to maintain this profile.\n+The Boussinesq buoyancy option is used, and the density is set constant to 1.17804 kg/m :math:`^3`. This density is \n+compatible with the reference pressure of 101325 Pa and a reference temperature of 300 K.  The viscosity is set to \n+1.0e-5 Pa-s.  *The flow should keep its inflow velocity and temperature profiles throughout the length of the domain*.\n+\n+The domain is 3000 m long, 1000 m tall, and 20 m wide with 300 x 100 x 2 elements.  The upper and lower boundaries \n+are symmetry with the specified normal gradient of temperature option used such that the gradient matches the initial\n+temperature profile with its gradient of 0.01 K/m. Flow enters from the left and exits on the right.  The remaining \n+boundaries are periodic. \n+\n+We test the problem on three configurations: 1) using the standard open boundary condition, \n+2) using the global-mass-flow-rate-correction option, and 3) using the standard open boundary condition with a local\n+moving-time-averaged reference temperature in the Boussinesq buoyancy term.\n+\n+Figure :numref:`stratified_outflow_ux1` shows the across-channel profile of outflow streamwise velocity.  It is clear\n+that in configuration 1, the velocity is significantly distorted from the correct solution.  Configurations 2 and 3 \n+remedy the problem.  However, if we reduce the range of the x-axis, as shown in Figure :numref:`stratified_outflow_ux2`, \n+we see that configuration 3, the use of the standard open boundary condition with a local moving-time-averaged\n+Boussinesq reference temperature, provides a superior solution in this case.  In Figure, :numref:`stratified_outflow_T1`,\n+we also see that configuration 1 significantly distorts the temperature from the correct solution.\n+\n+.. _stratified_outflow_ux1:\n+\n+.. figure:: figures/Ux_123.png\n+   :width: 500px\n+   :align: center\n+\n+   Outflow velocity profiles for the thermally stratified slip-channel flow.\n+\n+\n+.. _stratified_outflow_ux2:\n+\n+.. figure:: figures/Ux_23.png\n+   :width: 500px\n+   :align: center\n+\n+   Outflow velocity profiles for the thermally stratified slip-channel flow considering only the case with the\n+   global mass-flow-rate correction and the standard open boundary with the local moving-time-averaged Boussinesq\n+   reference value.\n+\n+\n+.. _stratified_outflow_T1:\n+\n+.. figure:: figures/T_123.png\n+   :width: 500px\n+   :align: center\n+\n+   Outflow temperature profiles for the thermally stratified slip-channel flow.\n+\n+\n+We also verify that the global mass-flow-rate correction of configuration 2 is correcting the outflow mass flow rate \n+properly.  The output from Nalu showing the correction is as follows:\n+\n+\n+.. code-block:: c++\n+ \n+   Mass Balance Review:\n+   Density accumulation: 0\n+   Integrated inflow:    -188486\n+   Integrated open:      188486\n+   Total mass closure:   -9.82374e-06\n+   A mass correction of: -1.22797e-08 occurred on: 800 boundary integration points:\n+   Post-corrected integrated open: 188486\n+\n+The product of the point-wise mass correction of -1.22797e-06 over all 800 boundary integration points is -9.82374e-06,\n+which agrees with the reported pre-correction mass-flow-rate error.","path":"docs/source/verification/verification.rst","position":null,"original_position":81,"commit_id":"3722867f7e1be5083025fda06a5d29c63f578187","original_commit_id":"de88471ed1379b57b71e483e5a1c3940bf7efb31","user":{"login":"mchurchf","id":7536901,"avatar_url":"https://avatars1.githubusercontent.com/u/7536901?v=4","gravatar_id":"","url":"https://api.github.com/users/mchurchf","html_url":"https://github.com/mchurchf","followers_url":"https://api.github.com/users/mchurchf/followers","following_url":"https://api.github.com/users/mchurchf/following{/other_user}","gists_url":"https://api.github.com/users/mchurchf/gists{/gist_id}","starred_url":"https://api.github.com/users/mchurchf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mchurchf/subscriptions","organizations_url":"https://api.github.com/users/mchurchf/orgs","repos_url":"https://api.github.com/users/mchurchf/repos","events_url":"https://api.github.com/users/mchurchf/events{/privacy}","received_events_url":"https://api.github.com/users/mchurchf/received_events","type":"User","site_admin":false},"body":"Okay, I added precison","created_at":"2017-12-29T06:11:41Z","updated_at":"2017-12-29T06:11:41Z","html_url":"https://github.com/NaluCFD/Nalu/pull/289#discussion_r159028347","pull_request_url":"https://api.github.com/repos/NaluCFD/Nalu/pulls/289","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/NaluCFD/Nalu/pulls/comments/159028347"},"html":{"href":"https://github.com/NaluCFD/Nalu/pull/289#discussion_r159028347"},"pull_request":{"href":"https://api.github.com/repos/NaluCFD/Nalu/pulls/289"}},"in_reply_to_id":158857044},"pull_request":{"url":"https://api.github.com/repos/NaluCFD/Nalu/pulls/289","id":160164797,"html_url":"https://github.com/NaluCFD/Nalu/pull/289","diff_url":"https://github.com/NaluCFD/Nalu/pull/289.diff","patch_url":"https://github.com/NaluCFD/Nalu/pull/289.patch","issue_url":"https://api.github.com/repos/NaluCFD/Nalu/issues/289","number":289,"state":"open","locked":false,"title":"D/mdot correction","user":{"login":"mchurchf","id":7536901,"avatar_url":"https://avatars1.githubusercontent.com/u/7536901?v=4","gravatar_id":"","url":"https://api.github.com/users/mchurchf","html_url":"https://github.com/mchurchf","followers_url":"https://api.github.com/users/mchurchf/followers","following_url":"https://api.github.com/users/mchurchf/following{/other_user}","gists_url":"https://api.github.com/users/mchurchf/gists{/gist_id}","starred_url":"https://api.github.com/users/mchurchf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mchurchf/subscriptions","organizations_url":"https://api.github.com/users/mchurchf/orgs","repos_url":"https://api.github.com/users/mchurchf/repos","events_url":"https://api.github.com/users/mchurchf/events{/privacy}","received_events_url":"https://api.github.com/users/mchurchf/received_events","type":"User","site_admin":false},"body":"Documentation in the verification manual for the global mass-flow-rate correction for outflow BCs and for Robert's local moving-time-average Boussinesq reference temperature option with standard open BC for thermally stratified flow.  The test case is a simple slip channel with uniform 8 m/s inflow and a stratified temperature profile.  The flow should maintain this profile as it moves through the domain and exits.  The standard open BC with no other special options clearly distorts the flow.  The global mass-flow-rate correction option maintains the profiles and properly corrects mass flow rate imbalances.  The option for Boussinesq with the local moving-time-average reference temperatur9e also maintains the profiles.","created_at":"2017-12-26T20:27:10Z","updated_at":"2017-12-29T06:11:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2a1215576cd673a54f53ae15b104ffad1e3a6a5b","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mbarone81","id":6090175,"avatar_url":"https://avatars3.githubusercontent.com/u/6090175?v=4","gravatar_id":"","url":"https://api.github.com/users/mbarone81","html_url":"https://github.com/mbarone81","followers_url":"https://api.github.com/users/mbarone81/followers","following_url":"https://api.github.com/users/mbarone81/following{/other_user}","gists_url":"https://api.github.com/users/mbarone81/gists{/gist_id}","starred_url":"https://api.github.com/users/mbarone81/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbarone81/subscriptions","organizations_url":"https://api.github.com/users/mbarone81/orgs","repos_url":"https://api.github.com/users/mbarone81/repos","events_url":"https://api.github.com/users/mbarone81/events{/privacy}","received_events_url":"https://api.github.com/users/mbarone81/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/NaluCFD/Nalu/pulls/289/commits","review_comments_url":"https://api.github.com/repos/NaluCFD/Nalu/pulls/289/comments","review_comment_url":"https://api.github.com/repos/NaluCFD/Nalu/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NaluCFD/Nalu/issues/289/comments","statuses_url":"https://api.github.com/repos/NaluCFD/Nalu/statuses/3722867f7e1be5083025fda06a5d29c63f578187","head":{"label":"mchurchf:d/mdotCorrection","ref":"d/mdotCorrection","sha":"3722867f7e1be5083025fda06a5d29c63f578187","user":{"login":"mchurchf","id":7536901,"avatar_url":"https://avatars1.githubusercontent.com/u/7536901?v=4","gravatar_id":"","url":"https://api.github.com/users/mchurchf","html_url":"https://github.com/mchurchf","followers_url":"https://api.github.com/users/mchurchf/followers","following_url":"https://api.github.com/users/mchurchf/following{/other_user}","gists_url":"https://api.github.com/users/mchurchf/gists{/gist_id}","starred_url":"https://api.github.com/users/mchurchf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mchurchf/subscriptions","organizations_url":"https://api.github.com/users/mchurchf/orgs","repos_url":"https://api.github.com/users/mchurchf/repos","events_url":"https://api.github.com/users/mchurchf/events{/privacy}","received_events_url":"https://api.github.com/users/mchurchf/received_events","type":"User","site_admin":false},"repo":{"id":70848359,"name":"Nalu","full_name":"mchurchf/Nalu","owner":{"login":"mchurchf","id":7536901,"avatar_url":"https://avatars1.githubusercontent.com/u/7536901?v=4","gravatar_id":"","url":"https://api.github.com/users/mchurchf","html_url":"https://github.com/mchurchf","followers_url":"https://api.github.com/users/mchurchf/followers","following_url":"https://api.github.com/users/mchurchf/following{/other_user}","gists_url":"https://api.github.com/users/mchurchf/gists{/gist_id}","starred_url":"https://api.github.com/users/mchurchf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mchurchf/subscriptions","organizations_url":"https://api.github.com/users/mchurchf/orgs","repos_url":"https://api.github.com/users/mchurchf/repos","events_url":"https://api.github.com/users/mchurchf/events{/privacy}","received_events_url":"https://api.github.com/users/mchurchf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mchurchf/Nalu","description":"Nalu: a generalized unstructured massively parallel low Mach flow code designed to support a variety of energy applications of interest (most notably Wind ECP) built on the Sierra Toolkit and Trilinos solver Tpetra/Epetra stack. The open source BSD, clause 3 license model has been chosen for the code base. See LICENSE for more information. ","fork":true,"url":"https://api.github.com/repos/mchurchf/Nalu","forks_url":"https://api.github.com/repos/mchurchf/Nalu/forks","keys_url":"https://api.github.com/repos/mchurchf/Nalu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mchurchf/Nalu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mchurchf/Nalu/teams","hooks_url":"https://api.github.com/repos/mchurchf/Nalu/hooks","issue_events_url":"https://api.github.com/repos/mchurchf/Nalu/issues/events{/number}","events_url":"https://api.github.com/repos/mchurchf/Nalu/events","assignees_url":"https://api.github.com/repos/mchurchf/Nalu/assignees{/user}","branches_url":"https://api.github.com/repos/mchurchf/Nalu/branches{/branch}","tags_url":"https://api.github.com/repos/mchurchf/Nalu/tags","blobs_url":"https://api.github.com/repos/mchurchf/Nalu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mchurchf/Nalu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mchurchf/Nalu/git/refs{/sha}","trees_url":"https://api.github.com/repos/mchurchf/Nalu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mchurchf/Nalu/statuses/{sha}","languages_url":"https://api.github.com/repos/mchurchf/Nalu/languages","stargazers_url":"https://api.github.com/repos/mchurchf/Nalu/stargazers","contributors_url":"https://api.github.com/repos/mchurchf/Nalu/contributors","subscribers_url":"https://api.github.com/repos/mchurchf/Nalu/subscribers","subscription_url":"https://api.github.com/repos/mchurchf/Nalu/subscription","commits_url":"https://api.github.com/repos/mchurchf/Nalu/commits{/sha}","git_commits_url":"https://api.github.com/repos/mchurchf/Nalu/git/commits{/sha}","comments_url":"https://api.github.com/repos/mchurchf/Nalu/comments{/number}","issue_comment_url":"https://api.github.com/repos/mchurchf/Nalu/issues/comments{/number}","contents_url":"https://api.github.com/repos/mchurchf/Nalu/contents/{+path}","compare_url":"https://api.github.com/repos/mchurchf/Nalu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mchurchf/Nalu/merges","archive_url":"https://api.github.com/repos/mchurchf/Nalu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mchurchf/Nalu/downloads","issues_url":"https://api.github.com/repos/mchurchf/Nalu/issues{/number}","pulls_url":"https://api.github.com/repos/mchurchf/Nalu/pulls{/number}","milestones_url":"https://api.github.com/repos/mchurchf/Nalu/milestones{/number}","notifications_url":"https://api.github.com/repos/mchurchf/Nalu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mchurchf/Nalu/labels{/name}","releases_url":"https://api.github.com/repos/mchurchf/Nalu/releases{/id}","deployments_url":"https://api.github.com/repos/mchurchf/Nalu/deployments","created_at":"2016-10-13T21:09:08Z","updated_at":"2016-10-13T21:09:10Z","pushed_at":"2017-12-29T06:11:19Z","git_url":"git://github.com/mchurchf/Nalu.git","ssh_url":"git@github.com:mchurchf/Nalu.git","clone_url":"https://github.com/mchurchf/Nalu.git","svn_url":"https://github.com/mchurchf/Nalu","homepage":"","size":10174,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NaluCFD:master","ref":"master","sha":"2d7e0c2345370be099f7f6e5088bcbc7e68c35f3","user":{"login":"NaluCFD","id":22531105,"avatar_url":"https://avatars1.githubusercontent.com/u/22531105?v=4","gravatar_id":"","url":"https://api.github.com/users/NaluCFD","html_url":"https://github.com/NaluCFD","followers_url":"https://api.github.com/users/NaluCFD/followers","following_url":"https://api.github.com/users/NaluCFD/following{/other_user}","gists_url":"https://api.github.com/users/NaluCFD/gists{/gist_id}","starred_url":"https://api.github.com/users/NaluCFD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NaluCFD/subscriptions","organizations_url":"https://api.github.com/users/NaluCFD/orgs","repos_url":"https://api.github.com/users/NaluCFD/repos","events_url":"https://api.github.com/users/NaluCFD/events{/privacy}","received_events_url":"https://api.github.com/users/NaluCFD/received_events","type":"Organization","site_admin":false},"repo":{"id":69712764,"name":"Nalu","full_name":"NaluCFD/Nalu","owner":{"login":"NaluCFD","id":22531105,"avatar_url":"https://avatars1.githubusercontent.com/u/22531105?v=4","gravatar_id":"","url":"https://api.github.com/users/NaluCFD","html_url":"https://github.com/NaluCFD","followers_url":"https://api.github.com/users/NaluCFD/followers","following_url":"https://api.github.com/users/NaluCFD/following{/other_user}","gists_url":"https://api.github.com/users/NaluCFD/gists{/gist_id}","starred_url":"https://api.github.com/users/NaluCFD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NaluCFD/subscriptions","organizations_url":"https://api.github.com/users/NaluCFD/orgs","repos_url":"https://api.github.com/users/NaluCFD/repos","events_url":"https://api.github.com/users/NaluCFD/events{/privacy}","received_events_url":"https://api.github.com/users/NaluCFD/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NaluCFD/Nalu","description":"Nalu: a generalized unstructured massively parallel low Mach flow code designed to support a variety of energy applications of interest (most notably Wind ECP) built on the Sierra Toolkit and Trilinos solver Tpetra/Epetra stack. The open source BSD, clause 3 license model has been chosen for the code base. See LICENSE for more information. ","fork":false,"url":"https://api.github.com/repos/NaluCFD/Nalu","forks_url":"https://api.github.com/repos/NaluCFD/Nalu/forks","keys_url":"https://api.github.com/repos/NaluCFD/Nalu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NaluCFD/Nalu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NaluCFD/Nalu/teams","hooks_url":"https://api.github.com/repos/NaluCFD/Nalu/hooks","issue_events_url":"https://api.github.com/repos/NaluCFD/Nalu/issues/events{/number}","events_url":"https://api.github.com/repos/NaluCFD/Nalu/events","assignees_url":"https://api.github.com/repos/NaluCFD/Nalu/assignees{/user}","branches_url":"https://api.github.com/repos/NaluCFD/Nalu/branches{/branch}","tags_url":"https://api.github.com/repos/NaluCFD/Nalu/tags","blobs_url":"https://api.github.com/repos/NaluCFD/Nalu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NaluCFD/Nalu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NaluCFD/Nalu/git/refs{/sha}","trees_url":"https://api.github.com/repos/NaluCFD/Nalu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NaluCFD/Nalu/statuses/{sha}","languages_url":"https://api.github.com/repos/NaluCFD/Nalu/languages","stargazers_url":"https://api.github.com/repos/NaluCFD/Nalu/stargazers","contributors_url":"https://api.github.com/repos/NaluCFD/Nalu/contributors","subscribers_url":"https://api.github.com/repos/NaluCFD/Nalu/subscribers","subscription_url":"https://api.github.com/repos/NaluCFD/Nalu/subscription","commits_url":"https://api.github.com/repos/NaluCFD/Nalu/commits{/sha}","git_commits_url":"https://api.github.com/repos/NaluCFD/Nalu/git/commits{/sha}","comments_url":"https://api.github.com/repos/NaluCFD/Nalu/comments{/number}","issue_comment_url":"https://api.github.com/repos/NaluCFD/Nalu/issues/comments{/number}","contents_url":"https://api.github.com/repos/NaluCFD/Nalu/contents/{+path}","compare_url":"https://api.github.com/repos/NaluCFD/Nalu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NaluCFD/Nalu/merges","archive_url":"https://api.github.com/repos/NaluCFD/Nalu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NaluCFD/Nalu/downloads","issues_url":"https://api.github.com/repos/NaluCFD/Nalu/issues{/number}","pulls_url":"https://api.github.com/repos/NaluCFD/Nalu/pulls{/number}","milestones_url":"https://api.github.com/repos/NaluCFD/Nalu/milestones{/number}","notifications_url":"https://api.github.com/repos/NaluCFD/Nalu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NaluCFD/Nalu/labels{/name}","releases_url":"https://api.github.com/repos/NaluCFD/Nalu/releases{/id}","deployments_url":"https://api.github.com/repos/NaluCFD/Nalu/deployments","created_at":"2016-10-01T01:25:20Z","updated_at":"2017-12-24T07:26:38Z","pushed_at":"2017-12-29T06:11:20Z","git_url":"git://github.com/NaluCFD/Nalu.git","ssh_url":"git@github.com:NaluCFD/Nalu.git","clone_url":"https://github.com/NaluCFD/Nalu.git","svn_url":"https://github.com/NaluCFD/Nalu","homepage":"NaluCFD.org","size":10535,"stargazers_count":27,"watchers_count":27,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":26,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":26,"open_issues":13,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NaluCFD/Nalu/pulls/289"},"html":{"href":"https://github.com/NaluCFD/Nalu/pull/289"},"issue":{"href":"https://api.github.com/repos/NaluCFD/Nalu/issues/289"},"comments":{"href":"https://api.github.com/repos/NaluCFD/Nalu/issues/289/comments"},"review_comments":{"href":"https://api.github.com/repos/NaluCFD/Nalu/pulls/289/comments"},"review_comment":{"href":"https://api.github.com/repos/NaluCFD/Nalu/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NaluCFD/Nalu/pulls/289/commits"},"statuses":{"href":"https://api.github.com/repos/NaluCFD/Nalu/statuses/3722867f7e1be5083025fda06a5d29c63f578187"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mchurchf"}}