{"action":"closed","number":39274,"pull_request":{"url":"https://api.github.com/repos/saltstack/salt/pulls/39274","id":105415419,"html_url":"https://github.com/saltstack/salt/pull/39274","diff_url":"https://github.com/saltstack/salt/pull/39274.diff","patch_url":"https://github.com/saltstack/salt/pull/39274.patch","issue_url":"https://api.github.com/repos/saltstack/salt/issues/39274","number":39274,"state":"closed","locked":false,"title":"Optionally format version conforming to Windows msi numbering scheme.","user":{"login":"markuskramerIgitt","id":8489107,"avatar_url":"https://avatars.githubusercontent.com/u/8489107?v=3","gravatar_id":"","url":"https://api.github.com/users/markuskramerIgitt","html_url":"https://github.com/markuskramerIgitt","followers_url":"https://api.github.com/users/markuskramerIgitt/followers","following_url":"https://api.github.com/users/markuskramerIgitt/following{/other_user}","gists_url":"https://api.github.com/users/markuskramerIgitt/gists{/gist_id}","starred_url":"https://api.github.com/users/markuskramerIgitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markuskramerIgitt/subscriptions","organizations_url":"https://api.github.com/users/markuskramerIgitt/orgs","repos_url":"https://api.github.com/users/markuskramerIgitt/repos","events_url":"https://api.github.com/users/markuskramerIgitt/events{/privacy}","received_events_url":"https://api.github.com/users/markuskramerIgitt/received_events","type":"User","site_admin":false},"body":"### What does this PR do?\r\nEnables `salt/salt/version.py` to optionally report a version conforming to the Windows msi-installer internal numbering scheme (version must be smaller than 256).\r\nTherefore, the year must be represented as 'short year'.\r\n\r\nPlease make the PR available in both develop and the 2016.11 branch, thank you.\r\nI would like to build an installer from the 2016.11 branch.\r\n\r\n### What issues does this PR fix or reference?\r\nIt enables the Windows msi-installer to have a version equivalent to `salt --version`.\r\n\r\nSee issue https://github.com/markuskramerIgitt/salt-windows-msi/issues/49\r\n\r\n### Previous Behavior\r\n`python salt/salt/version.py msi ` reports \r\n\r\n```\r\ndevelop               2016.11.0-742-g5ca4d20   \r\nbranch 20166.11       2016.11.2-72-g7611698    \r\ntag v20166.11.2        2016.11.2             \r\n```\r\nNote that the commit count for tags is 0 (zero) and ommited.\r\n\r\n### New Behavior\r\n\r\n`python salt/salt/version.py msi ` reports \r\n\r\n```\r\ndevelop              16.11.0,742\r\nbranch 20166.11       16.11.2,72\r\ntag v20166.11.2        16.11.2.0        \r\n```\r\n(`python salt/salt/version.py` as previously)\r\n\r\n### Tests written?\r\nYes\r\n\r\n","created_at":"2017-02-09T12:15:00Z","updated_at":"2017-02-13T21:48:17Z","closed_at":"2017-02-13T21:48:17Z","merged_at":"2017-02-13T21:48:17Z","merge_commit_sha":"d037045653a3d0cb9d7eda709d09bc0770710143","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/saltstack/salt/pulls/39274/commits","review_comments_url":"https://api.github.com/repos/saltstack/salt/pulls/39274/comments","review_comment_url":"https://api.github.com/repos/saltstack/salt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/39274/comments","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/b65f5fef49e7133919621d424bfe153aa590060c","head":{"label":"markuskramerIgitt:develop","ref":"develop","sha":"b65f5fef49e7133919621d424bfe153aa590060c","user":{"login":"markuskramerIgitt","id":8489107,"avatar_url":"https://avatars.githubusercontent.com/u/8489107?v=3","gravatar_id":"","url":"https://api.github.com/users/markuskramerIgitt","html_url":"https://github.com/markuskramerIgitt","followers_url":"https://api.github.com/users/markuskramerIgitt/followers","following_url":"https://api.github.com/users/markuskramerIgitt/following{/other_user}","gists_url":"https://api.github.com/users/markuskramerIgitt/gists{/gist_id}","starred_url":"https://api.github.com/users/markuskramerIgitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markuskramerIgitt/subscriptions","organizations_url":"https://api.github.com/users/markuskramerIgitt/orgs","repos_url":"https://api.github.com/users/markuskramerIgitt/repos","events_url":"https://api.github.com/users/markuskramerIgitt/events{/privacy}","received_events_url":"https://api.github.com/users/markuskramerIgitt/received_events","type":"User","site_admin":false},"repo":{"id":61723743,"name":"salt","full_name":"markuskramerIgitt/salt","owner":{"login":"markuskramerIgitt","id":8489107,"avatar_url":"https://avatars.githubusercontent.com/u/8489107?v=3","gravatar_id":"","url":"https://api.github.com/users/markuskramerIgitt","html_url":"https://github.com/markuskramerIgitt","followers_url":"https://api.github.com/users/markuskramerIgitt/followers","following_url":"https://api.github.com/users/markuskramerIgitt/following{/other_user}","gists_url":"https://api.github.com/users/markuskramerIgitt/gists{/gist_id}","starred_url":"https://api.github.com/users/markuskramerIgitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markuskramerIgitt/subscriptions","organizations_url":"https://api.github.com/users/markuskramerIgitt/orgs","repos_url":"https://api.github.com/users/markuskramerIgitt/repos","events_url":"https://api.github.com/users/markuskramerIgitt/events{/privacy}","received_events_url":"https://api.github.com/users/markuskramerIgitt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/markuskramerIgitt/salt","description":"Software to automate the management and configuration of any infrastructure or application at scale. Get access to the Salt Open software package repository here: ","fork":true,"url":"https://api.github.com/repos/markuskramerIgitt/salt","forks_url":"https://api.github.com/repos/markuskramerIgitt/salt/forks","keys_url":"https://api.github.com/repos/markuskramerIgitt/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/markuskramerIgitt/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/markuskramerIgitt/salt/teams","hooks_url":"https://api.github.com/repos/markuskramerIgitt/salt/hooks","issue_events_url":"https://api.github.com/repos/markuskramerIgitt/salt/issues/events{/number}","events_url":"https://api.github.com/repos/markuskramerIgitt/salt/events","assignees_url":"https://api.github.com/repos/markuskramerIgitt/salt/assignees{/user}","branches_url":"https://api.github.com/repos/markuskramerIgitt/salt/branches{/branch}","tags_url":"https://api.github.com/repos/markuskramerIgitt/salt/tags","blobs_url":"https://api.github.com/repos/markuskramerIgitt/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/markuskramerIgitt/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/markuskramerIgitt/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/markuskramerIgitt/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/markuskramerIgitt/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/markuskramerIgitt/salt/languages","stargazers_url":"https://api.github.com/repos/markuskramerIgitt/salt/stargazers","contributors_url":"https://api.github.com/repos/markuskramerIgitt/salt/contributors","subscribers_url":"https://api.github.com/repos/markuskramerIgitt/salt/subscribers","subscription_url":"https://api.github.com/repos/markuskramerIgitt/salt/subscription","commits_url":"https://api.github.com/repos/markuskramerIgitt/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/markuskramerIgitt/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/markuskramerIgitt/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/markuskramerIgitt/salt/issues/comments{/number}","contents_url":"https://api.github.com/repos/markuskramerIgitt/salt/contents/{+path}","compare_url":"https://api.github.com/repos/markuskramerIgitt/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/markuskramerIgitt/salt/merges","archive_url":"https://api.github.com/repos/markuskramerIgitt/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/markuskramerIgitt/salt/downloads","issues_url":"https://api.github.com/repos/markuskramerIgitt/salt/issues{/number}","pulls_url":"https://api.github.com/repos/markuskramerIgitt/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/markuskramerIgitt/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/markuskramerIgitt/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/markuskramerIgitt/salt/labels{/name}","releases_url":"https://api.github.com/repos/markuskramerIgitt/salt/releases{/id}","deployments_url":"https://api.github.com/repos/markuskramerIgitt/salt/deployments","created_at":"2016-06-22T14:03:43Z","updated_at":"2016-06-22T14:03:57Z","pushed_at":"2017-02-12T15:20:58Z","git_url":"git://github.com/markuskramerIgitt/salt.git","ssh_url":"git@github.com:markuskramerIgitt/salt.git","clone_url":"https://github.com/markuskramerIgitt/salt.git","svn_url":"https://github.com/markuskramerIgitt/salt","homepage":"https://repo.saltstack.com/","size":149227,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"saltstack:develop","ref":"develop","sha":"17521fb23c92122c0ac045b092bb46e1ff958080","user":{"login":"saltstack","id":1147473,"avatar_url":"https://avatars.githubusercontent.com/u/1147473?v=3","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"repo":{"id":1390248,"name":"salt","full_name":"saltstack/salt","owner":{"login":"saltstack","id":1147473,"avatar_url":"https://avatars.githubusercontent.com/u/1147473?v=3","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/saltstack/salt","description":"Software to automate the management and configuration of any infrastructure or application at scale. Get access to the Salt software package repository here: ","fork":false,"url":"https://api.github.com/repos/saltstack/salt","forks_url":"https://api.github.com/repos/saltstack/salt/forks","keys_url":"https://api.github.com/repos/saltstack/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saltstack/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saltstack/salt/teams","hooks_url":"https://api.github.com/repos/saltstack/salt/hooks","issue_events_url":"https://api.github.com/repos/saltstack/salt/issues/events{/number}","events_url":"https://api.github.com/repos/saltstack/salt/events","assignees_url":"https://api.github.com/repos/saltstack/salt/assignees{/user}","branches_url":"https://api.github.com/repos/saltstack/salt/branches{/branch}","tags_url":"https://api.github.com/repos/saltstack/salt/tags","blobs_url":"https://api.github.com/repos/saltstack/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saltstack/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saltstack/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/saltstack/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/saltstack/salt/languages","stargazers_url":"https://api.github.com/repos/saltstack/salt/stargazers","contributors_url":"https://api.github.com/repos/saltstack/salt/contributors","subscribers_url":"https://api.github.com/repos/saltstack/salt/subscribers","subscription_url":"https://api.github.com/repos/saltstack/salt/subscription","commits_url":"https://api.github.com/repos/saltstack/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/saltstack/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/saltstack/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/saltstack/salt/issues/comments{/number}","contents_url":"https://api.github.com/repos/saltstack/salt/contents/{+path}","compare_url":"https://api.github.com/repos/saltstack/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saltstack/salt/merges","archive_url":"https://api.github.com/repos/saltstack/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saltstack/salt/downloads","issues_url":"https://api.github.com/repos/saltstack/salt/issues{/number}","pulls_url":"https://api.github.com/repos/saltstack/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/saltstack/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/saltstack/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saltstack/salt/labels{/name}","releases_url":"https://api.github.com/repos/saltstack/salt/releases{/id}","deployments_url":"https://api.github.com/repos/saltstack/salt/deployments","created_at":"2011-02-20T20:16:56Z","updated_at":"2017-02-13T14:58:49Z","pushed_at":"2017-02-13T21:48:17Z","git_url":"git://github.com/saltstack/salt.git","ssh_url":"git@github.com:saltstack/salt.git","clone_url":"https://github.com/saltstack/salt.git","svn_url":"https://github.com/saltstack/salt","homepage":"https://repo.saltstack.com/","size":151948,"stargazers_count":7346,"watchers_count":7346,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3383,"mirror_url":null,"open_issues_count":4256,"forks":3383,"open_issues":4256,"watchers":7346,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/saltstack/salt/pulls/39274"},"html":{"href":"https://github.com/saltstack/salt/pull/39274"},"issue":{"href":"https://api.github.com/repos/saltstack/salt/issues/39274"},"comments":{"href":"https://api.github.com/repos/saltstack/salt/issues/39274/comments"},"review_comments":{"href":"https://api.github.com/repos/saltstack/salt/pulls/39274/comments"},"review_comment":{"href":"https://api.github.com/repos/saltstack/salt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/saltstack/salt/pulls/39274/commits"},"statuses":{"href":"https://api.github.com/repos/saltstack/salt/statuses/b65f5fef49e7133919621d424bfe153aa590060c"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"cachedout","id":111616,"avatar_url":"https://avatars.githubusercontent.com/u/111616?v=3","gravatar_id":"","url":"https://api.github.com/users/cachedout","html_url":"https://github.com/cachedout","followers_url":"https://api.github.com/users/cachedout/followers","following_url":"https://api.github.com/users/cachedout/following{/other_user}","gists_url":"https://api.github.com/users/cachedout/gists{/gist_id}","starred_url":"https://api.github.com/users/cachedout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cachedout/subscriptions","organizations_url":"https://api.github.com/users/cachedout/orgs","repos_url":"https://api.github.com/users/cachedout/repos","events_url":"https://api.github.com/users/cachedout/events{/privacy}","received_events_url":"https://api.github.com/users/cachedout/received_events","type":"User","site_admin":false},"comments":11,"review_comments":14,"maintainer_can_modify":false,"commits":12,"additions":22,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"cachedout"}}