{"action":"created","comment":{"url":"https://api.github.com/repos/mesosphere/universe/pulls/comments/128826767","pull_request_review_id":51546915,"id":128826767,"diff_hunk":"@@ -45,9 +45,9 @@ def main():\n     parser.add_argument(\n         '--include',\n         default='',\n-        help='Command separated list of packages to include. If this option '\n-        'is not specified then all packages are downloaded. E.g. '\n-        '--include=\"marathon,chronos\"')\n+        help='Command (,) separated list of packages to include. For each '\n+        'package specify both the name and version by separating them with a '\n+        'colon (:). E.g. --include=\"marathon:1.4.2,chronos:2.5.0\"')","path":"scripts/local-universe.py","position":9,"original_position":9,"commit_id":"634218e8ba67ee47baf51a8f1d3d6d475955f332","original_commit_id":"634218e8ba67ee47baf51a8f1d3d6d475955f332","user":{"login":"cruhland","id":1936682,"avatar_url":"https://avatars0.githubusercontent.com/u/1936682?v=4","gravatar_id":"","url":"https://api.github.com/users/cruhland","html_url":"https://github.com/cruhland","followers_url":"https://api.github.com/users/cruhland/followers","following_url":"https://api.github.com/users/cruhland/following{/other_user}","gists_url":"https://api.github.com/users/cruhland/gists{/gist_id}","starred_url":"https://api.github.com/users/cruhland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cruhland/subscriptions","organizations_url":"https://api.github.com/users/cruhland/orgs","repos_url":"https://api.github.com/users/cruhland/repos","events_url":"https://api.github.com/users/cruhland/events{/privacy}","received_events_url":"https://api.github.com/users/cruhland/received_events","type":"User","site_admin":false},"body":"@justinrlee it's generally a good idea to use explicit versions, because it makes the build deterministic. It might seem like a benefit for a customer to get package updates automatically when they rebuild their local universe image, but I'd bet they'd prefer to know when the version is changing and what they need to do to handle upgrades safely.","created_at":"2017-07-21T18:12:43Z","updated_at":"2017-07-21T18:12:43Z","html_url":"https://github.com/mesosphere/universe/pull/1277#discussion_r128826767","pull_request_url":"https://api.github.com/repos/mesosphere/universe/pulls/1277","_links":{"self":{"href":"https://api.github.com/repos/mesosphere/universe/pulls/comments/128826767"},"html":{"href":"https://github.com/mesosphere/universe/pull/1277#discussion_r128826767"},"pull_request":{"href":"https://api.github.com/repos/mesosphere/universe/pulls/1277"}}},"pull_request":{"url":"https://api.github.com/repos/mesosphere/universe/pulls/1277","id":130984693,"html_url":"https://github.com/mesosphere/universe/pull/1277","diff_url":"https://github.com/mesosphere/universe/pull/1277.diff","patch_url":"https://github.com/mesosphere/universe/pull/1277.patch","issue_url":"https://api.github.com/repos/mesosphere/universe/issues/1277","number":1277,"state":"open","locked":false,"title":"Local package versions","user":{"login":"jsancio","id":794394,"avatar_url":"https://avatars2.githubusercontent.com/u/794394?v=4","gravatar_id":"","url":"https://api.github.com/users/jsancio","html_url":"https://github.com/jsancio","followers_url":"https://api.github.com/users/jsancio/followers","following_url":"https://api.github.com/users/jsancio/following{/other_user}","gists_url":"https://api.github.com/users/jsancio/gists{/gist_id}","starred_url":"https://api.github.com/users/jsancio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsancio/subscriptions","organizations_url":"https://api.github.com/users/jsancio/orgs","repos_url":"https://api.github.com/users/jsancio/repos","events_url":"https://api.github.com/users/jsancio/events{/privacy}","received_events_url":"https://api.github.com/users/jsancio/received_events","type":"User","site_admin":false},"body":"Tested this manually by running the following commands:\r\n\r\n```bash\r\nsudo make DCOS_VERSION=1.10 local-universe\r\n```\r\n\r\n```bash\r\nsudo make DCOS_VERSION=1.10 DCOS_PACKAGE_INCLUDE=\"cassandra:1.0.25-3.0.10,cassandra:1.0.24-3.0.10,marathon:1.4.2\" local-universe \r\n```","created_at":"2017-07-18T01:23:47Z","updated_at":"2017-07-21T18:12:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f887cf9034f90f3c97ad22a0cebce19dcb566a9c","assignee":{"login":"jsancio","id":794394,"avatar_url":"https://avatars2.githubusercontent.com/u/794394?v=4","gravatar_id":"","url":"https://api.github.com/users/jsancio","html_url":"https://github.com/jsancio","followers_url":"https://api.github.com/users/jsancio/followers","following_url":"https://api.github.com/users/jsancio/following{/other_user}","gists_url":"https://api.github.com/users/jsancio/gists{/gist_id}","starred_url":"https://api.github.com/users/jsancio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsancio/subscriptions","organizations_url":"https://api.github.com/users/jsancio/orgs","repos_url":"https://api.github.com/users/jsancio/repos","events_url":"https://api.github.com/users/jsancio/events{/privacy}","received_events_url":"https://api.github.com/users/jsancio/received_events","type":"User","site_admin":false},"assignees":[{"login":"jsancio","id":794394,"avatar_url":"https://avatars2.githubusercontent.com/u/794394?v=4","gravatar_id":"","url":"https://api.github.com/users/jsancio","html_url":"https://github.com/jsancio","followers_url":"https://api.github.com/users/jsancio/followers","following_url":"https://api.github.com/users/jsancio/following{/other_user}","gists_url":"https://api.github.com/users/jsancio/gists{/gist_id}","starred_url":"https://api.github.com/users/jsancio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsancio/subscriptions","organizations_url":"https://api.github.com/users/jsancio/orgs","repos_url":"https://api.github.com/users/jsancio/repos","events_url":"https://api.github.com/users/jsancio/events{/privacy}","received_events_url":"https://api.github.com/users/jsancio/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"takirala","id":2296947,"avatar_url":"https://avatars2.githubusercontent.com/u/2296947?v=4","gravatar_id":"","url":"https://api.github.com/users/takirala","html_url":"https://github.com/takirala","followers_url":"https://api.github.com/users/takirala/followers","following_url":"https://api.github.com/users/takirala/following{/other_user}","gists_url":"https://api.github.com/users/takirala/gists{/gist_id}","starred_url":"https://api.github.com/users/takirala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/takirala/subscriptions","organizations_url":"https://api.github.com/users/takirala/orgs","repos_url":"https://api.github.com/users/takirala/repos","events_url":"https://api.github.com/users/takirala/events{/privacy}","received_events_url":"https://api.github.com/users/takirala/received_events","type":"User","site_admin":false},{"login":"justinrlee","id":4943268,"avatar_url":"https://avatars1.githubusercontent.com/u/4943268?v=4","gravatar_id":"","url":"https://api.github.com/users/justinrlee","html_url":"https://github.com/justinrlee","followers_url":"https://api.github.com/users/justinrlee/followers","following_url":"https://api.github.com/users/justinrlee/following{/other_user}","gists_url":"https://api.github.com/users/justinrlee/gists{/gist_id}","starred_url":"https://api.github.com/users/justinrlee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinrlee/subscriptions","organizations_url":"https://api.github.com/users/justinrlee/orgs","repos_url":"https://api.github.com/users/justinrlee/repos","events_url":"https://api.github.com/users/justinrlee/events{/privacy}","received_events_url":"https://api.github.com/users/justinrlee/received_events","type":"User","site_admin":false},{"login":"larioj","id":9968087,"avatar_url":"https://avatars2.githubusercontent.com/u/9968087?v=4","gravatar_id":"","url":"https://api.github.com/users/larioj","html_url":"https://github.com/larioj","followers_url":"https://api.github.com/users/larioj/followers","following_url":"https://api.github.com/users/larioj/following{/other_user}","gists_url":"https://api.github.com/users/larioj/gists{/gist_id}","starred_url":"https://api.github.com/users/larioj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/larioj/subscriptions","organizations_url":"https://api.github.com/users/larioj/orgs","repos_url":"https://api.github.com/users/larioj/repos","events_url":"https://api.github.com/users/larioj/events{/privacy}","received_events_url":"https://api.github.com/users/larioj/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/mesosphere/universe/pulls/1277/commits","review_comments_url":"https://api.github.com/repos/mesosphere/universe/pulls/1277/comments","review_comment_url":"https://api.github.com/repos/mesosphere/universe/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mesosphere/universe/issues/1277/comments","statuses_url":"https://api.github.com/repos/mesosphere/universe/statuses/634218e8ba67ee47baf51a8f1d3d6d475955f332","head":{"label":"mesosphere:local-package-versions","ref":"local-package-versions","sha":"634218e8ba67ee47baf51a8f1d3d6d475955f332","user":{"login":"mesosphere","id":3458585,"avatar_url":"https://avatars0.githubusercontent.com/u/3458585?v=4","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"repo":{"id":26291234,"name":"universe","full_name":"mesosphere/universe","owner":{"login":"mesosphere","id":3458585,"avatar_url":"https://avatars0.githubusercontent.com/u/3458585?v=4","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mesosphere/universe","description":"The Mesosphere Universe package repository.","fork":false,"url":"https://api.github.com/repos/mesosphere/universe","forks_url":"https://api.github.com/repos/mesosphere/universe/forks","keys_url":"https://api.github.com/repos/mesosphere/universe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mesosphere/universe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mesosphere/universe/teams","hooks_url":"https://api.github.com/repos/mesosphere/universe/hooks","issue_events_url":"https://api.github.com/repos/mesosphere/universe/issues/events{/number}","events_url":"https://api.github.com/repos/mesosphere/universe/events","assignees_url":"https://api.github.com/repos/mesosphere/universe/assignees{/user}","branches_url":"https://api.github.com/repos/mesosphere/universe/branches{/branch}","tags_url":"https://api.github.com/repos/mesosphere/universe/tags","blobs_url":"https://api.github.com/repos/mesosphere/universe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mesosphere/universe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mesosphere/universe/git/refs{/sha}","trees_url":"https://api.github.com/repos/mesosphere/universe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mesosphere/universe/statuses/{sha}","languages_url":"https://api.github.com/repos/mesosphere/universe/languages","stargazers_url":"https://api.github.com/repos/mesosphere/universe/stargazers","contributors_url":"https://api.github.com/repos/mesosphere/universe/contributors","subscribers_url":"https://api.github.com/repos/mesosphere/universe/subscribers","subscription_url":"https://api.github.com/repos/mesosphere/universe/subscription","commits_url":"https://api.github.com/repos/mesosphere/universe/commits{/sha}","git_commits_url":"https://api.github.com/repos/mesosphere/universe/git/commits{/sha}","comments_url":"https://api.github.com/repos/mesosphere/universe/comments{/number}","issue_comment_url":"https://api.github.com/repos/mesosphere/universe/issues/comments{/number}","contents_url":"https://api.github.com/repos/mesosphere/universe/contents/{+path}","compare_url":"https://api.github.com/repos/mesosphere/universe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mesosphere/universe/merges","archive_url":"https://api.github.com/repos/mesosphere/universe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mesosphere/universe/downloads","issues_url":"https://api.github.com/repos/mesosphere/universe/issues{/number}","pulls_url":"https://api.github.com/repos/mesosphere/universe/pulls{/number}","milestones_url":"https://api.github.com/repos/mesosphere/universe/milestones{/number}","notifications_url":"https://api.github.com/repos/mesosphere/universe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mesosphere/universe/labels{/name}","releases_url":"https://api.github.com/repos/mesosphere/universe/releases{/id}","deployments_url":"https://api.github.com/repos/mesosphere/universe/deployments","created_at":"2014-11-06T21:37:31Z","updated_at":"2017-07-10T14:11:00Z","pushed_at":"2017-07-21T18:10:07Z","git_url":"git://github.com/mesosphere/universe.git","ssh_url":"git@github.com:mesosphere/universe.git","clone_url":"https://github.com/mesosphere/universe.git","svn_url":"https://github.com/mesosphere/universe","homepage":"http://mesosphere.github.io/universe","size":2921,"stargazers_count":237,"watchers_count":237,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":340,"mirror_url":null,"open_issues_count":83,"forks":340,"open_issues":83,"watchers":237,"default_branch":"version-3.x"}},"base":{"label":"mesosphere:version-3.x","ref":"version-3.x","sha":"2e6f677f4b5e15eb9892b0164a73708b62bf1767","user":{"login":"mesosphere","id":3458585,"avatar_url":"https://avatars0.githubusercontent.com/u/3458585?v=4","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"repo":{"id":26291234,"name":"universe","full_name":"mesosphere/universe","owner":{"login":"mesosphere","id":3458585,"avatar_url":"https://avatars0.githubusercontent.com/u/3458585?v=4","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mesosphere/universe","description":"The Mesosphere Universe package repository.","fork":false,"url":"https://api.github.com/repos/mesosphere/universe","forks_url":"https://api.github.com/repos/mesosphere/universe/forks","keys_url":"https://api.github.com/repos/mesosphere/universe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mesosphere/universe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mesosphere/universe/teams","hooks_url":"https://api.github.com/repos/mesosphere/universe/hooks","issue_events_url":"https://api.github.com/repos/mesosphere/universe/issues/events{/number}","events_url":"https://api.github.com/repos/mesosphere/universe/events","assignees_url":"https://api.github.com/repos/mesosphere/universe/assignees{/user}","branches_url":"https://api.github.com/repos/mesosphere/universe/branches{/branch}","tags_url":"https://api.github.com/repos/mesosphere/universe/tags","blobs_url":"https://api.github.com/repos/mesosphere/universe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mesosphere/universe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mesosphere/universe/git/refs{/sha}","trees_url":"https://api.github.com/repos/mesosphere/universe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mesosphere/universe/statuses/{sha}","languages_url":"https://api.github.com/repos/mesosphere/universe/languages","stargazers_url":"https://api.github.com/repos/mesosphere/universe/stargazers","contributors_url":"https://api.github.com/repos/mesosphere/universe/contributors","subscribers_url":"https://api.github.com/repos/mesosphere/universe/subscribers","subscription_url":"https://api.github.com/repos/mesosphere/universe/subscription","commits_url":"https://api.github.com/repos/mesosphere/universe/commits{/sha}","git_commits_url":"https://api.github.com/repos/mesosphere/universe/git/commits{/sha}","comments_url":"https://api.github.com/repos/mesosphere/universe/comments{/number}","issue_comment_url":"https://api.github.com/repos/mesosphere/universe/issues/comments{/number}","contents_url":"https://api.github.com/repos/mesosphere/universe/contents/{+path}","compare_url":"https://api.github.com/repos/mesosphere/universe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mesosphere/universe/merges","archive_url":"https://api.github.com/repos/mesosphere/universe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mesosphere/universe/downloads","issues_url":"https://api.github.com/repos/mesosphere/universe/issues{/number}","pulls_url":"https://api.github.com/repos/mesosphere/universe/pulls{/number}","milestones_url":"https://api.github.com/repos/mesosphere/universe/milestones{/number}","notifications_url":"https://api.github.com/repos/mesosphere/universe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mesosphere/universe/labels{/name}","releases_url":"https://api.github.com/repos/mesosphere/universe/releases{/id}","deployments_url":"https://api.github.com/repos/mesosphere/universe/deployments","created_at":"2014-11-06T21:37:31Z","updated_at":"2017-07-10T14:11:00Z","pushed_at":"2017-07-21T18:10:07Z","git_url":"git://github.com/mesosphere/universe.git","ssh_url":"git@github.com:mesosphere/universe.git","clone_url":"https://github.com/mesosphere/universe.git","svn_url":"https://github.com/mesosphere/universe","homepage":"http://mesosphere.github.io/universe","size":2921,"stargazers_count":237,"watchers_count":237,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":340,"mirror_url":null,"open_issues_count":83,"forks":340,"open_issues":83,"watchers":237,"default_branch":"version-3.x"}},"_links":{"self":{"href":"https://api.github.com/repos/mesosphere/universe/pulls/1277"},"html":{"href":"https://github.com/mesosphere/universe/pull/1277"},"issue":{"href":"https://api.github.com/repos/mesosphere/universe/issues/1277"},"comments":{"href":"https://api.github.com/repos/mesosphere/universe/issues/1277/comments"},"review_comments":{"href":"https://api.github.com/repos/mesosphere/universe/pulls/1277/comments"},"review_comment":{"href":"https://api.github.com/repos/mesosphere/universe/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mesosphere/universe/pulls/1277/commits"},"statuses":{"href":"https://api.github.com/repos/mesosphere/universe/statuses/634218e8ba67ee47baf51a8f1d3d6d475955f332"}}}}
{"actor":{"display_login":"cruhland"}}