{"action":"created","issue":{"url":"https://api.github.com/repos/saltstack/salt/issues/41798","repository_url":"https://api.github.com/repos/saltstack/salt","labels_url":"https://api.github.com/repos/saltstack/salt/issues/41798/labels{/name}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/41798/comments","events_url":"https://api.github.com/repos/saltstack/salt/issues/41798/events","html_url":"https://github.com/saltstack/salt/pull/41798","id":236497720,"number":41798,"title":"Fixed lvm.lvcreate hanging","user":{"login":"farcaller","id":693,"avatar_url":"https://avatars1.githubusercontent.com/u/693?v=3","gravatar_id":"","url":"https://api.github.com/users/farcaller","html_url":"https://github.com/farcaller","followers_url":"https://api.github.com/users/farcaller/followers","following_url":"https://api.github.com/users/farcaller/following{/other_user}","gists_url":"https://api.github.com/users/farcaller/gists{/gist_id}","starred_url":"https://api.github.com/users/farcaller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/farcaller/subscriptions","organizations_url":"https://api.github.com/users/farcaller/orgs","repos_url":"https://api.github.com/users/farcaller/repos","events_url":"https://api.github.com/users/farcaller/events{/privacy}","received_events_url":"https://api.github.com/users/farcaller/received_events","type":"User","site_admin":false},"labels":[{"id":77737132,"url":"https://api.github.com/repos/saltstack/salt/labels/Pending%20Discussion","name":"Pending Discussion","color":"c7def8","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2017-06-16T14:22:32Z","updated_at":"2017-06-21T00:15:56Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/saltstack/salt/pulls/41798","html_url":"https://github.com/saltstack/salt/pull/41798","diff_url":"https://github.com/saltstack/salt/pull/41798.diff","patch_url":"https://github.com/saltstack/salt/pull/41798.patch"},"body":"### What does this PR do?\r\n\r\nlvcreate might call out for an user prompt in case if the beginning of the\r\nvolume has some recogniseable partition data, triggered by the lvm defaults of\r\n'--wipesignatures y' and '--zero y'. The default allows to proceed in the\r\nexpected manner automatically.\r\n\r\nTo allow the alternative behavior, wipesignatures is accepted as a valid\r\noptional flag, thus its behavior can be disabled.\r\n\r\n### What issues does this PR fix or reference?\r\n\r\nhttps://github.com/saltstack/salt/issues/41742\r\n\r\n### Previous Behavior\r\n\r\n`lvm.lvcreate` might hang indefinitely if the newly created volume happens to have a partition header.\r\n\r\n### New Behavior\r\n\r\n`lvm.lvcreate` will wipe the header automatically.\r\n\r\n### Tests written?\r\n\r\nNo\r\n\r\nPlease review [Salt's Contributing Guide](https://docs.saltstack.com/en/latest/topics/development/contributing.html) for best practices.\r\n"},"comment":{"url":"https://api.github.com/repos/saltstack/salt/issues/comments/309926917","html_url":"https://github.com/saltstack/salt/pull/41798#issuecomment-309926917","issue_url":"https://api.github.com/repos/saltstack/salt/issues/41798","id":309926917,"user":{"login":"garethgreenaway","id":718525,"avatar_url":"https://avatars3.githubusercontent.com/u/718525?v=3","gravatar_id":"","url":"https://api.github.com/users/garethgreenaway","html_url":"https://github.com/garethgreenaway","followers_url":"https://api.github.com/users/garethgreenaway/followers","following_url":"https://api.github.com/users/garethgreenaway/following{/other_user}","gists_url":"https://api.github.com/users/garethgreenaway/gists{/gist_id}","starred_url":"https://api.github.com/users/garethgreenaway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garethgreenaway/subscriptions","organizations_url":"https://api.github.com/users/garethgreenaway/orgs","repos_url":"https://api.github.com/users/garethgreenaway/repos","events_url":"https://api.github.com/users/garethgreenaway/events{/privacy}","received_events_url":"https://api.github.com/users/garethgreenaway/received_events","type":"User","site_admin":false},"created_at":"2017-06-21T00:15:56Z","updated_at":"2017-06-21T00:15:56Z","body":"@farcaller Regarding changing the defaults of the module/state modules, setting a default of \"-y\" without the knowledge or input from the user is a dangerous approach since that is blinding accepting anything that the lvm tools are going to prompt for.  I agree that it should not hang, perhaps a better approach would be to somehow detect when lvcreate or others would hang, then return a message indicate that the command could not run and the reasons why, also including suggestions on by passing the issues."}}
{"actor":{"display_login":"garethgreenaway"}}