{"action":"created","issue":{"url":"https://api.github.com/repos/david-sabata/web-scrobbler/issues/1221","repository_url":"https://api.github.com/repos/david-sabata/web-scrobbler","labels_url":"https://api.github.com/repos/david-sabata/web-scrobbler/issues/1221/labels{/name}","comments_url":"https://api.github.com/repos/david-sabata/web-scrobbler/issues/1221/comments","events_url":"https://api.github.com/repos/david-sabata/web-scrobbler/issues/1221/events","html_url":"https://github.com/david-sabata/web-scrobbler/issues/1221","id":199566916,"number":1221,"title":"Use YouTube video thumbnail as track art","user":{"login":"ali-essam","id":5252681,"avatar_url":"https://avatars2.githubusercontent.com/u/5252681?v=3","gravatar_id":"","url":"https://api.github.com/users/ali-essam","html_url":"https://github.com/ali-essam","followers_url":"https://api.github.com/users/ali-essam/followers","following_url":"https://api.github.com/users/ali-essam/following{/other_user}","gists_url":"https://api.github.com/users/ali-essam/gists{/gist_id}","starred_url":"https://api.github.com/users/ali-essam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ali-essam/subscriptions","organizations_url":"https://api.github.com/users/ali-essam/orgs","repos_url":"https://api.github.com/users/ali-essam/repos","events_url":"https://api.github.com/users/ali-essam/events{/privacy}","received_events_url":"https://api.github.com/users/ali-essam/received_events","type":"User","site_admin":false},"labels":[{"id":54209360,"url":"https://api.github.com/repos/david-sabata/web-scrobbler/labels/1:%20DISCUSSION","name":"1: DISCUSSION","color":"bfe5bf","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2017-01-09T14:37:11Z","updated_at":"2017-03-04T09:47:15Z","closed_at":null,"body":"I noticed YouTube connector doesn't try to parse track art in anyway and leaves it to song metadata (which is not available sometimes). I was thinking it might be a nice idea to use YouTube thumbnail as a fallback strategy, but the logic of `song.getTrackArt` seems to do the opposite (which is fine in most cases).\r\n\r\nSo the 2 points I want to discuss are:\r\n- Is using YouTube thumbnail a good idea?\r\n- If so, should it be fallback? and how should it be implemented to allow such strategy?\r\n\r\n```\r\nConnector.getTrackArt = function () {\r\n\tvar id = $('meta[itemprop=\"videoId\"]').attr('content');\r\n\treturn 'https://img.youtube.com/vi/' + id + '/mqdefault.jpg'\r\n}\r\n```\r\n\r\n![youtube thumb art](https://cloud.githubusercontent.com/assets/5252681/21769492/ab38342e-d687-11e6-846c-d2cc0ee7464d.png)\r\n"},"comment":{"url":"https://api.github.com/repos/david-sabata/web-scrobbler/issues/comments/284140773","html_url":"https://github.com/david-sabata/web-scrobbler/issues/1221#issuecomment-284140773","issue_url":"https://api.github.com/repos/david-sabata/web-scrobbler/issues/1221","id":284140773,"user":{"login":"alexesprit","id":1119267,"avatar_url":"https://avatars2.githubusercontent.com/u/1119267?v=3","gravatar_id":"","url":"https://api.github.com/users/alexesprit","html_url":"https://github.com/alexesprit","followers_url":"https://api.github.com/users/alexesprit/followers","following_url":"https://api.github.com/users/alexesprit/following{/other_user}","gists_url":"https://api.github.com/users/alexesprit/gists{/gist_id}","starred_url":"https://api.github.com/users/alexesprit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexesprit/subscriptions","organizations_url":"https://api.github.com/users/alexesprit/orgs","repos_url":"https://api.github.com/users/alexesprit/repos","events_url":"https://api.github.com/users/alexesprit/events{/privacy}","received_events_url":"https://api.github.com/users/alexesprit/received_events","type":"User","site_admin":false},"created_at":"2017-03-04T09:47:15Z","updated_at":"2017-03-04T09:47:15Z","body":"@inverse it's a property that allows to force the use of trackarts from external sources (Last.fm, coverart archive etc) even if a parsed trackart is defined. In current implementaion parsed trackarts are always preferrable."}}
{"actor":{"display_login":"alexesprit"}}