{"action":"created","issue":{"url":"https://api.github.com/repos/minetest/minetest/issues/6539","repository_url":"https://api.github.com/repos/minetest/minetest","labels_url":"https://api.github.com/repos/minetest/minetest/issues/6539/labels{/name}","comments_url":"https://api.github.com/repos/minetest/minetest/issues/6539/comments","events_url":"https://api.github.com/repos/minetest/minetest/issues/6539/events","html_url":"https://github.com/minetest/minetest/pull/6539","id":265998033,"number":6539,"title":"[WIP] Allow zoom to actually show more data.","user":{"login":"lhofhansl","id":446130,"avatar_url":"https://avatars0.githubusercontent.com/u/446130?v=4","gravatar_id":"","url":"https://api.github.com/users/lhofhansl","html_url":"https://github.com/lhofhansl","followers_url":"https://api.github.com/users/lhofhansl/followers","following_url":"https://api.github.com/users/lhofhansl/following{/other_user}","gists_url":"https://api.github.com/users/lhofhansl/gists{/gist_id}","starred_url":"https://api.github.com/users/lhofhansl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lhofhansl/subscriptions","organizations_url":"https://api.github.com/users/lhofhansl/orgs","repos_url":"https://api.github.com/users/lhofhansl/repos","events_url":"https://api.github.com/users/lhofhansl/events{/privacy}","received_events_url":"https://api.github.com/users/lhofhansl/received_events","type":"User","site_admin":false},"labels":[{"id":471238548,"url":"https://api.github.com/repos/minetest/minetest/labels/Feature","name":"Feature","color":"f9d0c4","default":false},{"id":141943726,"url":"https://api.github.com/repos/minetest/minetest/labels/Testing%20needed","name":"Testing needed","color":"006b75","default":false},{"id":110411003,"url":"https://api.github.com/repos/minetest/minetest/labels/WIP","name":"WIP","color":"aa3000","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":48,"created_at":"2017-10-17T05:32:43Z","updated_at":"2017-11-13T03:32:01Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/minetest/minetest/pulls/6539","html_url":"https://github.com/minetest/minetest/pull/6539","diff_url":"https://github.com/minetest/minetest/pull/6539.diff","patch_url":"https://github.com/minetest/minetest/pull/6539.patch"},"body":"This might eventually address #6529 .\r\n\r\nSome stuff hardcoded, no boundary testing, no code-style, just so that folks can see roughly what the effect would be.\r\nThings to notice:\r\n- The real zoom needs to all increase the client view range, so it seems we have a fog-piercing zoom.\r\n- The zoom distance itself is interesting. How much more data should one retrieve?\r\n- Currently assumes about 14/10 aspect ratio. Interestingly the server does not currently know the aspect ratio, so it's impossible to calculate the base fov (it's 72, but the actual value depends on the aspect ratio). As long as client and server agree it should be OK.\r\n\r\nAgain, just have a look. Don't argue about code-style and hardcoded stuff, yet.\r\n\r\n@paramat "},"comment":{"url":"https://api.github.com/repos/minetest/minetest/issues/comments/343800900","html_url":"https://github.com/minetest/minetest/pull/6539#issuecomment-343800900","issue_url":"https://api.github.com/repos/minetest/minetest/issues/6539","id":343800900,"user":{"login":"paramat","id":3686677,"avatar_url":"https://avatars0.githubusercontent.com/u/3686677?v=4","gravatar_id":"","url":"https://api.github.com/users/paramat","html_url":"https://github.com/paramat","followers_url":"https://api.github.com/users/paramat/followers","following_url":"https://api.github.com/users/paramat/following{/other_user}","gists_url":"https://api.github.com/users/paramat/gists{/gist_id}","starred_url":"https://api.github.com/users/paramat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paramat/subscriptions","organizations_url":"https://api.github.com/users/paramat/orgs","repos_url":"https://api.github.com/users/paramat/repos","events_url":"https://api.github.com/users/paramat/events{/privacy}","received_events_url":"https://api.github.com/users/paramat/received_events","type":"User","site_admin":false},"created_at":"2017-11-13T03:32:00Z","updated_at":"2017-11-13T03:32:00Z","author_association":"MEMBER","body":">  If - as in the case you cite - the generate distance is set to 0, one would not have any zoom at all\r\n\r\nYes, if done it would have to be both set to `adjustDist(m_max_send_distance, camera_fov)` but that may also have issues.\r\nSo for now i'm fairly happy with this, will test within a day."}}
{"actor":{"display_login":"paramat"}}