{"action":"created","comment":{"url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/pulls/comments/145750046","pull_request_review_id":70596965,"id":145750046,"diff_hunk":"@@ -21,6 +21,7 @@\n /* End PBXAggregateTarget section */\n \n /* Begin PBXBuildFile section */\n+\t\tB71F8B531F98FA1D00D7B2E6 /* Default-568h@2x.png in Resources */ = {isa = PBXBuildFile; fileRef = B71F8B521F98FA1D00D7B2E6 /* Default-568h@2x.png */; };","path":"libs/SalesforceAnalytics/SalesforceAnalytics.xcodeproj/project.pbxproj","position":4,"original_position":4,"commit_id":"a1494d13eaa5d5d0bc76eae1073a3ec8df28adc9","original_commit_id":"a1494d13eaa5d5d0bc76eae1073a3ec8df28adc9","user":{"login":"bhariharan","id":1820287,"avatar_url":"https://avatars1.githubusercontent.com/u/1820287?v=4","gravatar_id":"","url":"https://api.github.com/users/bhariharan","html_url":"https://github.com/bhariharan","followers_url":"https://api.github.com/users/bhariharan/followers","following_url":"https://api.github.com/users/bhariharan/following{/other_user}","gists_url":"https://api.github.com/users/bhariharan/gists{/gist_id}","starred_url":"https://api.github.com/users/bhariharan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bhariharan/subscriptions","organizations_url":"https://api.github.com/users/bhariharan/orgs","repos_url":"https://api.github.com/users/bhariharan/repos","events_url":"https://api.github.com/users/bhariharan/events{/privacy}","received_events_url":"https://api.github.com/users/bhariharan/received_events","type":"User","site_admin":false},"body":"Move the physical location of this file under `Resources` as well.","created_at":"2017-10-19T16:16:06Z","updated_at":"2017-10-19T16:18:18Z","html_url":"https://github.com/forcedotcom/SalesforceMobileSDK-iOS/pull/2241#discussion_r145750046","pull_request_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/pulls/2241","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/pulls/comments/145750046"},"html":{"href":"https://github.com/forcedotcom/SalesforceMobileSDK-iOS/pull/2241#discussion_r145750046"},"pull_request":{"href":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/pulls/2241"}}},"pull_request":{"url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/pulls/2241","id":147591013,"html_url":"https://github.com/forcedotcom/SalesforceMobileSDK-iOS/pull/2241","diff_url":"https://github.com/forcedotcom/SalesforceMobileSDK-iOS/pull/2241.diff","patch_url":"https://github.com/forcedotcom/SalesforceMobileSDK-iOS/pull/2241.patch","issue_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/issues/2241","number":2241,"state":"open","locked":false,"title":"Code fixes to handle warnings in all projects","user":{"login":"trooper2013","id":4625334,"avatar_url":"https://avatars3.githubusercontent.com/u/4625334?v=4","gravatar_id":"","url":"https://api.github.com/users/trooper2013","html_url":"https://github.com/trooper2013","followers_url":"https://api.github.com/users/trooper2013/followers","following_url":"https://api.github.com/users/trooper2013/following{/other_user}","gists_url":"https://api.github.com/users/trooper2013/gists{/gist_id}","starred_url":"https://api.github.com/users/trooper2013/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trooper2013/subscriptions","organizations_url":"https://api.github.com/users/trooper2013/orgs","repos_url":"https://api.github.com/users/trooper2013/repos","events_url":"https://api.github.com/users/trooper2013/events{/privacy}","received_events_url":"https://api.github.com/users/trooper2013/received_events","type":"User","site_admin":false},"body":"Reduced warnings to half. \r\n\r\n1. ARC warnings for out parameters.\r\n2. declaration of void in block definitions.\r\n3. Turned of annoying Asset Compiler warnings for sample projects.\r\n4. Doc related warnings.\r\n\r\n Most of the warnings left are either related to Cordova or react.","created_at":"2017-10-19T15:35:02Z","updated_at":"2017-10-19T16:18:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d7f033e5ed28eb27b7a2aa6f8cb29a08af3d6e04","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/pulls/2241/commits","review_comments_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/pulls/2241/comments","review_comment_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/issues/2241/comments","statuses_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/statuses/a1494d13eaa5d5d0bc76eae1073a3ec8df28adc9","head":{"label":"trooper2013:dev","ref":"dev","sha":"a1494d13eaa5d5d0bc76eae1073a3ec8df28adc9","user":{"login":"trooper2013","id":4625334,"avatar_url":"https://avatars3.githubusercontent.com/u/4625334?v=4","gravatar_id":"","url":"https://api.github.com/users/trooper2013","html_url":"https://github.com/trooper2013","followers_url":"https://api.github.com/users/trooper2013/followers","following_url":"https://api.github.com/users/trooper2013/following{/other_user}","gists_url":"https://api.github.com/users/trooper2013/gists{/gist_id}","starred_url":"https://api.github.com/users/trooper2013/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trooper2013/subscriptions","organizations_url":"https://api.github.com/users/trooper2013/orgs","repos_url":"https://api.github.com/users/trooper2013/repos","events_url":"https://api.github.com/users/trooper2013/events{/privacy}","received_events_url":"https://api.github.com/users/trooper2013/received_events","type":"User","site_admin":false},"repo":{"id":62419453,"name":"SalesforceMobileSDK-iOS","full_name":"trooper2013/SalesforceMobileSDK-iOS","owner":{"login":"trooper2013","id":4625334,"avatar_url":"https://avatars3.githubusercontent.com/u/4625334?v=4","gravatar_id":"","url":"https://api.github.com/users/trooper2013","html_url":"https://github.com/trooper2013","followers_url":"https://api.github.com/users/trooper2013/followers","following_url":"https://api.github.com/users/trooper2013/following{/other_user}","gists_url":"https://api.github.com/users/trooper2013/gists{/gist_id}","starred_url":"https://api.github.com/users/trooper2013/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trooper2013/subscriptions","organizations_url":"https://api.github.com/users/trooper2013/orgs","repos_url":"https://api.github.com/users/trooper2013/repos","events_url":"https://api.github.com/users/trooper2013/events{/privacy}","received_events_url":"https://api.github.com/users/trooper2013/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/trooper2013/SalesforceMobileSDK-iOS","description":"Force.com mobile SDK for iOS applications","fork":true,"url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS","forks_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/forks","keys_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/teams","hooks_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/hooks","issue_events_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/issues/events{/number}","events_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/events","assignees_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/assignees{/user}","branches_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/branches{/branch}","tags_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/tags","blobs_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/git/refs{/sha}","trees_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/statuses/{sha}","languages_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/languages","stargazers_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/stargazers","contributors_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/contributors","subscribers_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/subscribers","subscription_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/subscription","commits_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/commits{/sha}","git_commits_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/git/commits{/sha}","comments_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/comments{/number}","issue_comment_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/issues/comments{/number}","contents_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/contents/{+path}","compare_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/merges","archive_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/downloads","issues_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/issues{/number}","pulls_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/pulls{/number}","milestones_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/milestones{/number}","notifications_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/labels{/name}","releases_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/releases{/id}","deployments_url":"https://api.github.com/repos/trooper2013/SalesforceMobileSDK-iOS/deployments","created_at":"2016-07-01T21:01:11Z","updated_at":"2016-07-01T21:01:15Z","pushed_at":"2017-10-19T15:32:06Z","git_url":"git://github.com/trooper2013/SalesforceMobileSDK-iOS.git","ssh_url":"git@github.com:trooper2013/SalesforceMobileSDK-iOS.git","clone_url":"https://github.com/trooper2013/SalesforceMobileSDK-iOS.git","svn_url":"https://github.com/trooper2013/SalesforceMobileSDK-iOS","homepage":"https://github.com/forcedotcom/SalesforceMobileSDK-iOS","size":367178,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"forcedotcom:dev","ref":"dev","sha":"c1567309d38691faaff15e70da04ce66b34c80da","user":{"login":"forcedotcom","id":464563,"avatar_url":"https://avatars3.githubusercontent.com/u/464563?v=4","gravatar_id":"","url":"https://api.github.com/users/forcedotcom","html_url":"https://github.com/forcedotcom","followers_url":"https://api.github.com/users/forcedotcom/followers","following_url":"https://api.github.com/users/forcedotcom/following{/other_user}","gists_url":"https://api.github.com/users/forcedotcom/gists{/gist_id}","starred_url":"https://api.github.com/users/forcedotcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forcedotcom/subscriptions","organizations_url":"https://api.github.com/users/forcedotcom/orgs","repos_url":"https://api.github.com/users/forcedotcom/repos","events_url":"https://api.github.com/users/forcedotcom/events{/privacy}","received_events_url":"https://api.github.com/users/forcedotcom/received_events","type":"Organization","site_admin":false},"repo":{"id":2338086,"name":"SalesforceMobileSDK-iOS","full_name":"forcedotcom/SalesforceMobileSDK-iOS","owner":{"login":"forcedotcom","id":464563,"avatar_url":"https://avatars3.githubusercontent.com/u/464563?v=4","gravatar_id":"","url":"https://api.github.com/users/forcedotcom","html_url":"https://github.com/forcedotcom","followers_url":"https://api.github.com/users/forcedotcom/followers","following_url":"https://api.github.com/users/forcedotcom/following{/other_user}","gists_url":"https://api.github.com/users/forcedotcom/gists{/gist_id}","starred_url":"https://api.github.com/users/forcedotcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forcedotcom/subscriptions","organizations_url":"https://api.github.com/users/forcedotcom/orgs","repos_url":"https://api.github.com/users/forcedotcom/repos","events_url":"https://api.github.com/users/forcedotcom/events{/privacy}","received_events_url":"https://api.github.com/users/forcedotcom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/forcedotcom/SalesforceMobileSDK-iOS","description":"Force.com mobile SDK for iOS applications","fork":false,"url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS","forks_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/forks","keys_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/teams","hooks_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/hooks","issue_events_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/issues/events{/number}","events_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/events","assignees_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/assignees{/user}","branches_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/branches{/branch}","tags_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/tags","blobs_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/git/refs{/sha}","trees_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/statuses/{sha}","languages_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/languages","stargazers_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/stargazers","contributors_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/contributors","subscribers_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/subscribers","subscription_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/subscription","commits_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/commits{/sha}","git_commits_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/git/commits{/sha}","comments_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/comments{/number}","issue_comment_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/issues/comments{/number}","contents_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/contents/{+path}","compare_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/merges","archive_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/downloads","issues_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/issues{/number}","pulls_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/pulls{/number}","milestones_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/milestones{/number}","notifications_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/labels{/name}","releases_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/releases{/id}","deployments_url":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/deployments","created_at":"2011-09-06T23:13:57Z","updated_at":"2017-09-29T09:52:49Z","pushed_at":"2017-10-19T15:35:02Z","git_url":"git://github.com/forcedotcom/SalesforceMobileSDK-iOS.git","ssh_url":"git@github.com:forcedotcom/SalesforceMobileSDK-iOS.git","clone_url":"https://github.com/forcedotcom/SalesforceMobileSDK-iOS.git","svn_url":"https://github.com/forcedotcom/SalesforceMobileSDK-iOS","homepage":"https://github.com/forcedotcom/SalesforceMobileSDK-iOS","size":377528,"stargazers_count":371,"watchers_count":371,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":296,"mirror_url":null,"open_issues_count":9,"forks":296,"open_issues":9,"watchers":371,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/pulls/2241"},"html":{"href":"https://github.com/forcedotcom/SalesforceMobileSDK-iOS/pull/2241"},"issue":{"href":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/issues/2241"},"comments":{"href":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/issues/2241/comments"},"review_comments":{"href":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/pulls/2241/comments"},"review_comment":{"href":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/pulls/2241/commits"},"statuses":{"href":"https://api.github.com/repos/forcedotcom/SalesforceMobileSDK-iOS/statuses/a1494d13eaa5d5d0bc76eae1073a3ec8df28adc9"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"bhariharan"}}