{"action":"created","issue":{"url":"https://api.github.com/repos/Ecodev/newsletter/issues/146","repository_url":"https://api.github.com/repos/Ecodev/newsletter","labels_url":"https://api.github.com/repos/Ecodev/newsletter/issues/146/labels{/name}","comments_url":"https://api.github.com/repos/Ecodev/newsletter/issues/146/comments","events_url":"https://api.github.com/repos/Ecodev/newsletter/issues/146/events","html_url":"https://github.com/Ecodev/newsletter/issues/146","id":279376760,"number":146,"title":"long sending time when big recipientlist","user":{"login":"mangopulp","id":7901069,"avatar_url":"https://avatars0.githubusercontent.com/u/7901069?v=4","gravatar_id":"","url":"https://api.github.com/users/mangopulp","html_url":"https://github.com/mangopulp","followers_url":"https://api.github.com/users/mangopulp/followers","following_url":"https://api.github.com/users/mangopulp/following{/other_user}","gists_url":"https://api.github.com/users/mangopulp/gists{/gist_id}","starred_url":"https://api.github.com/users/mangopulp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mangopulp/subscriptions","organizations_url":"https://api.github.com/users/mangopulp/orgs","repos_url":"https://api.github.com/users/mangopulp/repos","events_url":"https://api.github.com/users/mangopulp/events{/privacy}","received_events_url":"https://api.github.com/users/mangopulp/received_events","type":"User","site_admin":false},"labels":[{"id":128942947,"url":"https://api.github.com/repos/Ecodev/newsletter/labels/need%20feedback","name":"need feedback","color":"f7c6c7","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-12-05T13:35:02Z","updated_at":"2017-12-07T13:11:24Z","closed_at":null,"author_association":"NONE","body":"First of all - very big thanks for this very nice extension! All thumbs up! The Issue I have with this extension is at a very special level and is for optimization proposal from my side.\r\n\r\nI used a recipientlist with around 1700 recipients. When I startet sending, it took around 7h until each mail was send. Analysing the code, shows that the method `injectLinksSpy()` in class `Ecodev\\Newsletter\\Mailer` needs around 15 sec. to modify all links in the newsletter and this method is called for each recipient. Although the method `injectOpenSpy()` in the same Class consumes a little time which only is noticeable when it comes to bigger recipient lists. I think it would be a more powerful approach when this two methods are called before sending and the modified Newsletter gets cached, so the methods don't need to be called again while sending the newsletter to each recipient. Then at this point it would only ne necessary to replace the markers with the personal data. This approach should speed up sending a lot."},"comment":{"url":"https://api.github.com/repos/Ecodev/newsletter/issues/comments/349962606","html_url":"https://github.com/Ecodev/newsletter/issues/146#issuecomment-349962606","issue_url":"https://api.github.com/repos/Ecodev/newsletter/issues/146","id":349962606,"user":{"login":"mangopulp","id":7901069,"avatar_url":"https://avatars0.githubusercontent.com/u/7901069?v=4","gravatar_id":"","url":"https://api.github.com/users/mangopulp","html_url":"https://github.com/mangopulp","followers_url":"https://api.github.com/users/mangopulp/followers","following_url":"https://api.github.com/users/mangopulp/following{/other_user}","gists_url":"https://api.github.com/users/mangopulp/gists{/gist_id}","starred_url":"https://api.github.com/users/mangopulp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mangopulp/subscriptions","organizations_url":"https://api.github.com/users/mangopulp/orgs","repos_url":"https://api.github.com/users/mangopulp/repos","events_url":"https://api.github.com/users/mangopulp/events{/privacy}","received_events_url":"https://api.github.com/users/mangopulp/received_events","type":"User","site_admin":false},"created_at":"2017-12-07T13:11:24Z","updated_at":"2017-12-07T13:11:24Z","author_association":"NONE","body":"I will take a closer look to get more information what's the reason for the long delay. Will be back soon."}}
{"actor":{"display_login":"mangopulp"}}