{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/137913174","pull_request_review_id":61649389,"id":137913174,"diff_hunk":"@@ -201,7 +201,7 @@ var _ = framework.KubeDescribe(\"Kubectl alpha client\", func() {\n \t\t})\n \n \t\tAfterEach(func() {\n-\t\t\tframework.RunKubectlOrDie(\"delete\", \"cronjobs\", cjName, nsFlag)\n+\t\t\tframework.RunKubectlOrDie(\"delete\", \"cronjob.v2alpha1.batch\", cjName, nsFlag)","path":"test/e2e/kubectl.go","position":5,"original_position":5,"commit_id":"fe2382f60afa46c6a524273cf63629b1c18b61ca","original_commit_id":"fe2382f60afa46c6a524273cf63629b1c18b61ca","user":{"login":"liggitt","id":980082,"avatar_url":"https://avatars0.githubusercontent.com/u/980082?v=4","gravatar_id":"","url":"https://api.github.com/users/liggitt","html_url":"https://github.com/liggitt","followers_url":"https://api.github.com/users/liggitt/followers","following_url":"https://api.github.com/users/liggitt/following{/other_user}","gists_url":"https://api.github.com/users/liggitt/gists{/gist_id}","starred_url":"https://api.github.com/users/liggitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liggitt/subscriptions","organizations_url":"https://api.github.com/users/liggitt/orgs","repos_url":"https://api.github.com/users/liggitt/repos","events_url":"https://api.github.com/users/liggitt/events{/privacy}","received_events_url":"https://api.github.com/users/liggitt/received_events","type":"User","site_admin":false},"body":"Asked about it in https://github.com/kubernetes/kubernetes/commit/6962427b35861eace9796214be85e0188e241ce6#commitcomment-24183968 as well","created_at":"2017-09-09T00:31:44Z","updated_at":"2017-09-09T00:31:44Z","html_url":"https://github.com/kubernetes/kubernetes/pull/52199#discussion_r137913174","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/52199","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/137913174"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/52199#discussion_r137913174"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/52199"}},"in_reply_to_id":137911849},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/52199","id":140123722,"html_url":"https://github.com/kubernetes/kubernetes/pull/52199","diff_url":"https://github.com/kubernetes/kubernetes/pull/52199.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/52199.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/52199","number":52199,"state":"open","locked":false,"title":"fix cleanup step in kubectl cronjob test","user":{"login":"mengqiy","id":2589105,"avatar_url":"https://avatars1.githubusercontent.com/u/2589105?v=4","gravatar_id":"","url":"https://api.github.com/users/mengqiy","html_url":"https://github.com/mengqiy","followers_url":"https://api.github.com/users/mengqiy/followers","following_url":"https://api.github.com/users/mengqiy/following{/other_user}","gists_url":"https://api.github.com/users/mengqiy/gists{/gist_id}","starred_url":"https://api.github.com/users/mengqiy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mengqiy/subscriptions","organizations_url":"https://api.github.com/users/mengqiy/orgs","repos_url":"https://api.github.com/users/mengqiy/repos","events_url":"https://api.github.com/users/mengqiy/events{/privacy}","received_events_url":"https://api.github.com/users/mengqiy/received_events","type":"User","site_admin":false},"body":"Skew test is failing because there are multiple version of cronjob.\r\nExplicitly specify group version kind when cleanup.\r\n```\r\n{  cronjobs} matches multiple kinds [batch/v1beta1, Kind=CronJob batch/v2alpha1, Kind=CronJob\r\n```\r\nFixes: #52219\r\n\r\n```release-note\r\nNONE\r\n```\r\n/assign @pwittrock ","created_at":"2017-09-08T20:54:47Z","updated_at":"2017-09-09T00:31:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ec3369ab007c5f8f04f47225eacddbd44625e930","assignee":{"login":"pwittrock","id":7882754,"avatar_url":"https://avatars0.githubusercontent.com/u/7882754?v=4","gravatar_id":"","url":"https://api.github.com/users/pwittrock","html_url":"https://github.com/pwittrock","followers_url":"https://api.github.com/users/pwittrock/followers","following_url":"https://api.github.com/users/pwittrock/following{/other_user}","gists_url":"https://api.github.com/users/pwittrock/gists{/gist_id}","starred_url":"https://api.github.com/users/pwittrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pwittrock/subscriptions","organizations_url":"https://api.github.com/users/pwittrock/orgs","repos_url":"https://api.github.com/users/pwittrock/repos","events_url":"https://api.github.com/users/pwittrock/events{/privacy}","received_events_url":"https://api.github.com/users/pwittrock/received_events","type":"User","site_admin":false},"assignees":[{"login":"pwittrock","id":7882754,"avatar_url":"https://avatars0.githubusercontent.com/u/7882754?v=4","gravatar_id":"","url":"https://api.github.com/users/pwittrock","html_url":"https://github.com/pwittrock","followers_url":"https://api.github.com/users/pwittrock/followers","following_url":"https://api.github.com/users/pwittrock/following{/other_user}","gists_url":"https://api.github.com/users/pwittrock/gists{/gist_id}","starred_url":"https://api.github.com/users/pwittrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pwittrock/subscriptions","organizations_url":"https://api.github.com/users/pwittrock/orgs","repos_url":"https://api.github.com/users/pwittrock/repos","events_url":"https://api.github.com/users/pwittrock/events{/privacy}","received_events_url":"https://api.github.com/users/pwittrock/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/32","html_url":"https://github.com/kubernetes/kubernetes/milestone/32","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/32/labels","id":2264750,"number":32,"title":"v1.7","description":"","creator":{"login":"pwittrock","id":7882754,"avatar_url":"https://avatars0.githubusercontent.com/u/7882754?v=4","gravatar_id":"","url":"https://api.github.com/users/pwittrock","html_url":"https://github.com/pwittrock","followers_url":"https://api.github.com/users/pwittrock/followers","following_url":"https://api.github.com/users/pwittrock/following{/other_user}","gists_url":"https://api.github.com/users/pwittrock/gists{/gist_id}","starred_url":"https://api.github.com/users/pwittrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pwittrock/subscriptions","organizations_url":"https://api.github.com/users/pwittrock/orgs","repos_url":"https://api.github.com/users/pwittrock/repos","events_url":"https://api.github.com/users/pwittrock/events{/privacy}","received_events_url":"https://api.github.com/users/pwittrock/received_events","type":"User","site_admin":false},"open_issues":17,"closed_issues":1298,"state":"open","created_at":"2017-01-19T17:41:27Z","updated_at":"2017-09-08T21:43:05Z","due_on":"2017-06-28T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/52199/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/52199/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/52199/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/fe2382f60afa46c6a524273cf63629b1c18b61ca","head":{"label":"mengqiy:fix_cron_test","ref":"fix_cron_test","sha":"fe2382f60afa46c6a524273cf63629b1c18b61ca","user":{"login":"mengqiy","id":2589105,"avatar_url":"https://avatars1.githubusercontent.com/u/2589105?v=4","gravatar_id":"","url":"https://api.github.com/users/mengqiy","html_url":"https://github.com/mengqiy","followers_url":"https://api.github.com/users/mengqiy/followers","following_url":"https://api.github.com/users/mengqiy/following{/other_user}","gists_url":"https://api.github.com/users/mengqiy/gists{/gist_id}","starred_url":"https://api.github.com/users/mengqiy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mengqiy/subscriptions","organizations_url":"https://api.github.com/users/mengqiy/orgs","repos_url":"https://api.github.com/users/mengqiy/repos","events_url":"https://api.github.com/users/mengqiy/events{/privacy}","received_events_url":"https://api.github.com/users/mengqiy/received_events","type":"User","site_admin":false},"repo":{"id":65329041,"name":"kubernetes","full_name":"mengqiy/kubernetes","owner":{"login":"mengqiy","id":2589105,"avatar_url":"https://avatars1.githubusercontent.com/u/2589105?v=4","gravatar_id":"","url":"https://api.github.com/users/mengqiy","html_url":"https://github.com/mengqiy","followers_url":"https://api.github.com/users/mengqiy/followers","following_url":"https://api.github.com/users/mengqiy/following{/other_user}","gists_url":"https://api.github.com/users/mengqiy/gists{/gist_id}","starred_url":"https://api.github.com/users/mengqiy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mengqiy/subscriptions","organizations_url":"https://api.github.com/users/mengqiy/orgs","repos_url":"https://api.github.com/users/mengqiy/repos","events_url":"https://api.github.com/users/mengqiy/events{/privacy}","received_events_url":"https://api.github.com/users/mengqiy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mengqiy/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/mengqiy/kubernetes","forks_url":"https://api.github.com/repos/mengqiy/kubernetes/forks","keys_url":"https://api.github.com/repos/mengqiy/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mengqiy/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mengqiy/kubernetes/teams","hooks_url":"https://api.github.com/repos/mengqiy/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/mengqiy/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/mengqiy/kubernetes/events","assignees_url":"https://api.github.com/repos/mengqiy/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/mengqiy/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/mengqiy/kubernetes/tags","blobs_url":"https://api.github.com/repos/mengqiy/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mengqiy/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mengqiy/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/mengqiy/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mengqiy/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/mengqiy/kubernetes/languages","stargazers_url":"https://api.github.com/repos/mengqiy/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/mengqiy/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/mengqiy/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/mengqiy/kubernetes/subscription","commits_url":"https://api.github.com/repos/mengqiy/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/mengqiy/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/mengqiy/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/mengqiy/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/mengqiy/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/mengqiy/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mengqiy/kubernetes/merges","archive_url":"https://api.github.com/repos/mengqiy/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mengqiy/kubernetes/downloads","issues_url":"https://api.github.com/repos/mengqiy/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/mengqiy/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/mengqiy/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/mengqiy/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mengqiy/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/mengqiy/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/mengqiy/kubernetes/deployments","created_at":"2016-08-09T21:18:55Z","updated_at":"2016-08-09T21:19:27Z","pushed_at":"2017-09-08T20:52:37Z","git_url":"git://github.com/mengqiy/kubernetes.git","ssh_url":"git@github.com:mengqiy/kubernetes.git","clone_url":"https://github.com/mengqiy/kubernetes.git","svn_url":"https://github.com/mengqiy/kubernetes","homepage":"http://kubernetes.io","size":470043,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:release-1.7","ref":"release-1.7","sha":"2dcf54ed6478f896cd98ef64520f9618fecd7edc","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2017-09-08T20:19:09Z","pushed_at":"2017-09-09T00:26:08Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":693073,"stargazers_count":26678,"watchers_count":26678,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9523,"mirror_url":null,"open_issues_count":5353,"forks":9523,"open_issues":5353,"watchers":26678,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/52199"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/52199"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/52199"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/52199/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/52199/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/52199/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/fe2382f60afa46c6a524273cf63629b1c18b61ca"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"liggitt"}}