{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-quickstep/pulls/comments/143825045","pull_request_review_id":68394476,"id":143825045,"diff_hunk":"@@ -104,7 +104,7 @@ class InsertDestinationInterface {\n    *        insertion from ValueAccessor even when partially full.\n    **/\n   virtual void bulkInsertTuples(ValueAccessor *accessor,\n-                                bool always_mark_full = false) = 0;\n+                                const bool always_mark_full = false) = 0;","path":"storage/InsertDestinationInterface.hpp","position":5,"original_position":5,"commit_id":"f820c45ee56a9e74671fb1c22c5e6b7e13471b5d","original_commit_id":"8e2cc08f7b047da765879bcc5e00413ad2168f3d","user":{"login":"zuyu","id":2245572,"avatar_url":"https://avatars0.githubusercontent.com/u/2245572?v=4","gravatar_id":"","url":"https://api.github.com/users/zuyu","html_url":"https://github.com/zuyu","followers_url":"https://api.github.com/users/zuyu/followers","following_url":"https://api.github.com/users/zuyu/following{/other_user}","gists_url":"https://api.github.com/users/zuyu/gists{/gist_id}","starred_url":"https://api.github.com/users/zuyu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zuyu/subscriptions","organizations_url":"https://api.github.com/users/zuyu/orgs","repos_url":"https://api.github.com/users/zuyu/repos","events_url":"https://api.github.com/users/zuyu/events{/privacy}","received_events_url":"https://api.github.com/users/zuyu/received_events","type":"User","site_admin":false},"body":"It is required by the first pass of the multi-pass sort.","created_at":"2017-10-10T19:12:15Z","updated_at":"2017-10-10T19:14:42Z","html_url":"https://github.com/apache/incubator-quickstep/pull/308#discussion_r143825045","pull_request_url":"https://api.github.com/repos/apache/incubator-quickstep/pulls/308","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-quickstep/pulls/comments/143825045"},"html":{"href":"https://github.com/apache/incubator-quickstep/pull/308#discussion_r143825045"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-quickstep/pulls/308"}},"in_reply_to_id":143823339},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-quickstep/pulls/308","id":145035065,"html_url":"https://github.com/apache/incubator-quickstep/pull/308","diff_url":"https://github.com/apache/incubator-quickstep/pull/308.diff","patch_url":"https://github.com/apache/incubator-quickstep/pull/308.patch","issue_url":"https://api.github.com/repos/apache/incubator-quickstep/issues/308","number":308,"state":"closed","locked":false,"title":"Removed unused argument always_mark_full.","user":{"login":"zuyu","id":2245572,"avatar_url":"https://avatars0.githubusercontent.com/u/2245572?v=4","gravatar_id":"","url":"https://api.github.com/users/zuyu","html_url":"https://github.com/zuyu","followers_url":"https://api.github.com/users/zuyu/followers","following_url":"https://api.github.com/users/zuyu/following{/other_user}","gists_url":"https://api.github.com/users/zuyu/gists{/gist_id}","starred_url":"https://api.github.com/users/zuyu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zuyu/subscriptions","organizations_url":"https://api.github.com/users/zuyu/orgs","repos_url":"https://api.github.com/users/zuyu/repos","events_url":"https://api.github.com/users/zuyu/events{/privacy}","received_events_url":"https://api.github.com/users/zuyu/received_events","type":"User","site_admin":false},"body":"This PR cleans up the unused argument `always_mark_full`, and avoids branching overhead.","created_at":"2017-10-05T22:21:47Z","updated_at":"2017-10-10T19:15:26Z","closed_at":"2017-10-10T19:15:16Z","merged_at":"2017-10-10T19:15:16Z","merge_commit_sha":"f820c45ee56a9e74671fb1c22c5e6b7e13471b5d","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-quickstep/pulls/308/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-quickstep/pulls/308/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-quickstep/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-quickstep/issues/308/comments","statuses_url":"https://api.github.com/repos/apache/incubator-quickstep/statuses/f820c45ee56a9e74671fb1c22c5e6b7e13471b5d","head":{"label":"zuyu:always-mark-full-arg","ref":"always-mark-full-arg","sha":"f820c45ee56a9e74671fb1c22c5e6b7e13471b5d","user":{"login":"zuyu","id":2245572,"avatar_url":"https://avatars0.githubusercontent.com/u/2245572?v=4","gravatar_id":"","url":"https://api.github.com/users/zuyu","html_url":"https://github.com/zuyu","followers_url":"https://api.github.com/users/zuyu/followers","following_url":"https://api.github.com/users/zuyu/following{/other_user}","gists_url":"https://api.github.com/users/zuyu/gists{/gist_id}","starred_url":"https://api.github.com/users/zuyu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zuyu/subscriptions","organizations_url":"https://api.github.com/users/zuyu/orgs","repos_url":"https://api.github.com/users/zuyu/repos","events_url":"https://api.github.com/users/zuyu/events{/privacy}","received_events_url":"https://api.github.com/users/zuyu/received_events","type":"User","site_admin":false},"repo":{"id":84873745,"name":"incubator-quickstep","full_name":"zuyu/incubator-quickstep","owner":{"login":"zuyu","id":2245572,"avatar_url":"https://avatars0.githubusercontent.com/u/2245572?v=4","gravatar_id":"","url":"https://api.github.com/users/zuyu","html_url":"https://github.com/zuyu","followers_url":"https://api.github.com/users/zuyu/followers","following_url":"https://api.github.com/users/zuyu/following{/other_user}","gists_url":"https://api.github.com/users/zuyu/gists{/gist_id}","starred_url":"https://api.github.com/users/zuyu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zuyu/subscriptions","organizations_url":"https://api.github.com/users/zuyu/orgs","repos_url":"https://api.github.com/users/zuyu/repos","events_url":"https://api.github.com/users/zuyu/events{/privacy}","received_events_url":"https://api.github.com/users/zuyu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zuyu/incubator-quickstep","description":"Mirror of Apache Quickstep Incubator","fork":true,"url":"https://api.github.com/repos/zuyu/incubator-quickstep","forks_url":"https://api.github.com/repos/zuyu/incubator-quickstep/forks","keys_url":"https://api.github.com/repos/zuyu/incubator-quickstep/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zuyu/incubator-quickstep/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zuyu/incubator-quickstep/teams","hooks_url":"https://api.github.com/repos/zuyu/incubator-quickstep/hooks","issue_events_url":"https://api.github.com/repos/zuyu/incubator-quickstep/issues/events{/number}","events_url":"https://api.github.com/repos/zuyu/incubator-quickstep/events","assignees_url":"https://api.github.com/repos/zuyu/incubator-quickstep/assignees{/user}","branches_url":"https://api.github.com/repos/zuyu/incubator-quickstep/branches{/branch}","tags_url":"https://api.github.com/repos/zuyu/incubator-quickstep/tags","blobs_url":"https://api.github.com/repos/zuyu/incubator-quickstep/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zuyu/incubator-quickstep/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zuyu/incubator-quickstep/git/refs{/sha}","trees_url":"https://api.github.com/repos/zuyu/incubator-quickstep/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zuyu/incubator-quickstep/statuses/{sha}","languages_url":"https://api.github.com/repos/zuyu/incubator-quickstep/languages","stargazers_url":"https://api.github.com/repos/zuyu/incubator-quickstep/stargazers","contributors_url":"https://api.github.com/repos/zuyu/incubator-quickstep/contributors","subscribers_url":"https://api.github.com/repos/zuyu/incubator-quickstep/subscribers","subscription_url":"https://api.github.com/repos/zuyu/incubator-quickstep/subscription","commits_url":"https://api.github.com/repos/zuyu/incubator-quickstep/commits{/sha}","git_commits_url":"https://api.github.com/repos/zuyu/incubator-quickstep/git/commits{/sha}","comments_url":"https://api.github.com/repos/zuyu/incubator-quickstep/comments{/number}","issue_comment_url":"https://api.github.com/repos/zuyu/incubator-quickstep/issues/comments{/number}","contents_url":"https://api.github.com/repos/zuyu/incubator-quickstep/contents/{+path}","compare_url":"https://api.github.com/repos/zuyu/incubator-quickstep/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zuyu/incubator-quickstep/merges","archive_url":"https://api.github.com/repos/zuyu/incubator-quickstep/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zuyu/incubator-quickstep/downloads","issues_url":"https://api.github.com/repos/zuyu/incubator-quickstep/issues{/number}","pulls_url":"https://api.github.com/repos/zuyu/incubator-quickstep/pulls{/number}","milestones_url":"https://api.github.com/repos/zuyu/incubator-quickstep/milestones{/number}","notifications_url":"https://api.github.com/repos/zuyu/incubator-quickstep/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zuyu/incubator-quickstep/labels{/name}","releases_url":"https://api.github.com/repos/zuyu/incubator-quickstep/releases{/id}","deployments_url":"https://api.github.com/repos/zuyu/incubator-quickstep/deployments","created_at":"2017-03-13T20:55:25Z","updated_at":"2017-03-13T20:55:30Z","pushed_at":"2017-10-10T19:16:24Z","git_url":"git://github.com/zuyu/incubator-quickstep.git","ssh_url":"git@github.com:zuyu/incubator-quickstep.git","clone_url":"https://github.com/zuyu/incubator-quickstep.git","svn_url":"https://github.com/zuyu/incubator-quickstep","homepage":null,"size":11234,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"ffb8e055a890a9002235a8516e5f2dece2d6228a","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":56214719,"name":"incubator-quickstep","full_name":"apache/incubator-quickstep","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-quickstep","description":"Mirror of Apache Quickstep Incubator","fork":false,"url":"https://api.github.com/repos/apache/incubator-quickstep","forks_url":"https://api.github.com/repos/apache/incubator-quickstep/forks","keys_url":"https://api.github.com/repos/apache/incubator-quickstep/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-quickstep/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-quickstep/teams","hooks_url":"https://api.github.com/repos/apache/incubator-quickstep/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-quickstep/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-quickstep/events","assignees_url":"https://api.github.com/repos/apache/incubator-quickstep/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-quickstep/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-quickstep/tags","blobs_url":"https://api.github.com/repos/apache/incubator-quickstep/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-quickstep/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-quickstep/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-quickstep/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-quickstep/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-quickstep/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-quickstep/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-quickstep/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-quickstep/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-quickstep/subscription","commits_url":"https://api.github.com/repos/apache/incubator-quickstep/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-quickstep/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-quickstep/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-quickstep/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-quickstep/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-quickstep/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-quickstep/merges","archive_url":"https://api.github.com/repos/apache/incubator-quickstep/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-quickstep/downloads","issues_url":"https://api.github.com/repos/apache/incubator-quickstep/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-quickstep/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-quickstep/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-quickstep/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-quickstep/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-quickstep/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-quickstep/deployments","created_at":"2016-04-14T07:00:07Z","updated_at":"2017-10-04T17:34:19Z","pushed_at":"2017-10-10T19:16:25Z","git_url":"git://github.com/apache/incubator-quickstep.git","ssh_url":"git@github.com:apache/incubator-quickstep.git","clone_url":"https://github.com/apache/incubator-quickstep.git","svn_url":"https://github.com/apache/incubator-quickstep","homepage":null,"size":11275,"stargazers_count":46,"watchers_count":46,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":32,"mirror_url":"git://git.apache.org/incubator-quickstep.git","open_issues_count":3,"forks":32,"open_issues":3,"watchers":46,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-quickstep/pulls/308"},"html":{"href":"https://github.com/apache/incubator-quickstep/pull/308"},"issue":{"href":"https://api.github.com/repos/apache/incubator-quickstep/issues/308"},"comments":{"href":"https://api.github.com/repos/apache/incubator-quickstep/issues/308/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-quickstep/pulls/308/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-quickstep/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-quickstep/pulls/308/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-quickstep/statuses/f820c45ee56a9e74671fb1c22c5e6b7e13471b5d"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"zuyu"}}