{"action":"created","comment":{"url":"https://api.github.com/repos/gravitational/provisioner/pulls/comments/148595417","pull_request_review_id":73863188,"id":148595417,"diff_hunk":"@@ -38,11 +37,10 @@ resource \"aws_subnet\" \"private\" {\n   cidr_block        = \"${element(var.subnets, count.index)}\"\n   availability_zone = \"${element(var.azs, count.index)}\"\n \n-  tags {\n-    KubernetesCluster = \"${var.cluster_name}\"\n-    Name              = \"${var.cluster_name}\"\n-    \"kubernetes.io/role/internal-elb\" = \"1\"\n-  }\n+  tags = \"${merge(local.common_tags, map(\n+    \"Name\", \"\"${var.cluster_name}\"-private\",","path":"scripts/terraform/templates/cluster.tf.template","position":24,"original_position":24,"commit_id":"16e78f2a051f918a5e5045bfabcac2f538fa2f5f","original_commit_id":"16e78f2a051f918a5e5045bfabcac2f538fa2f5f","user":{"login":"klizhentas","id":13717,"avatar_url":"https://avatars1.githubusercontent.com/u/13717?v=4","gravatar_id":"","url":"https://api.github.com/users/klizhentas","html_url":"https://github.com/klizhentas","followers_url":"https://api.github.com/users/klizhentas/followers","following_url":"https://api.github.com/users/klizhentas/following{/other_user}","gists_url":"https://api.github.com/users/klizhentas/gists{/gist_id}","starred_url":"https://api.github.com/users/klizhentas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klizhentas/subscriptions","organizations_url":"https://api.github.com/users/klizhentas/orgs","repos_url":"https://api.github.com/users/klizhentas/repos","events_url":"https://api.github.com/users/klizhentas/events{/privacy}","received_events_url":"https://api.github.com/users/klizhentas/received_events","type":"User","site_admin":false},"body":"same here","created_at":"2017-11-02T16:57:19Z","updated_at":"2017-11-02T16:57:48Z","html_url":"https://github.com/gravitational/provisioner/pull/9#discussion_r148595417","pull_request_url":"https://api.github.com/repos/gravitational/provisioner/pulls/9","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/gravitational/provisioner/pulls/comments/148595417"},"html":{"href":"https://github.com/gravitational/provisioner/pull/9#discussion_r148595417"},"pull_request":{"href":"https://api.github.com/repos/gravitational/provisioner/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/gravitational/provisioner/pulls/9","id":150332019,"html_url":"https://github.com/gravitational/provisioner/pull/9","diff_url":"https://github.com/gravitational/provisioner/pull/9.diff","patch_url":"https://github.com/gravitational/provisioner/pull/9.patch","issue_url":"https://api.github.com/repos/gravitational/provisioner/issues/9","number":9,"state":"open","locked":false,"title":"Move to using common_tags (using locals) and suffixing private/public on subnet/RTs","user":{"login":"helgi","id":70530,"avatar_url":"https://avatars2.githubusercontent.com/u/70530?v=4","gravatar_id":"","url":"https://api.github.com/users/helgi","html_url":"https://github.com/helgi","followers_url":"https://api.github.com/users/helgi/followers","following_url":"https://api.github.com/users/helgi/following{/other_user}","gists_url":"https://api.github.com/users/helgi/gists{/gist_id}","starred_url":"https://api.github.com/users/helgi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helgi/subscriptions","organizations_url":"https://api.github.com/users/helgi/orgs","repos_url":"https://api.github.com/users/helgi/repos","events_url":"https://api.github.com/users/helgi/events{/privacy}","received_events_url":"https://api.github.com/users/helgi/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-11-02T15:57:29Z","updated_at":"2017-11-02T16:57:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1557413fd7183017a4110b7f20750ef5e45cda4f","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/gravitational/provisioner/pulls/9/commits","review_comments_url":"https://api.github.com/repos/gravitational/provisioner/pulls/9/comments","review_comment_url":"https://api.github.com/repos/gravitational/provisioner/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gravitational/provisioner/issues/9/comments","statuses_url":"https://api.github.com/repos/gravitational/provisioner/statuses/16e78f2a051f918a5e5045bfabcac2f538fa2f5f","head":{"label":"helgi:feature/tags-and-suffix-subnet-rt","ref":"feature/tags-and-suffix-subnet-rt","sha":"16e78f2a051f918a5e5045bfabcac2f538fa2f5f","user":{"login":"helgi","id":70530,"avatar_url":"https://avatars2.githubusercontent.com/u/70530?v=4","gravatar_id":"","url":"https://api.github.com/users/helgi","html_url":"https://github.com/helgi","followers_url":"https://api.github.com/users/helgi/followers","following_url":"https://api.github.com/users/helgi/following{/other_user}","gists_url":"https://api.github.com/users/helgi/gists{/gist_id}","starred_url":"https://api.github.com/users/helgi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helgi/subscriptions","organizations_url":"https://api.github.com/users/helgi/orgs","repos_url":"https://api.github.com/users/helgi/repos","events_url":"https://api.github.com/users/helgi/events{/privacy}","received_events_url":"https://api.github.com/users/helgi/received_events","type":"User","site_admin":false},"repo":{"id":107628584,"name":"provisioner","full_name":"helgi/provisioner","owner":{"login":"helgi","id":70530,"avatar_url":"https://avatars2.githubusercontent.com/u/70530?v=4","gravatar_id":"","url":"https://api.github.com/users/helgi","html_url":"https://github.com/helgi","followers_url":"https://api.github.com/users/helgi/followers","following_url":"https://api.github.com/users/helgi/following{/other_user}","gists_url":"https://api.github.com/users/helgi/gists{/gist_id}","starred_url":"https://api.github.com/users/helgi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helgi/subscriptions","organizations_url":"https://api.github.com/users/helgi/orgs","repos_url":"https://api.github.com/users/helgi/repos","events_url":"https://api.github.com/users/helgi/events{/privacy}","received_events_url":"https://api.github.com/users/helgi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/helgi/provisioner","description":"Terraform based provisioners for ops center","fork":true,"url":"https://api.github.com/repos/helgi/provisioner","forks_url":"https://api.github.com/repos/helgi/provisioner/forks","keys_url":"https://api.github.com/repos/helgi/provisioner/keys{/key_id}","collaborators_url":"https://api.github.com/repos/helgi/provisioner/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/helgi/provisioner/teams","hooks_url":"https://api.github.com/repos/helgi/provisioner/hooks","issue_events_url":"https://api.github.com/repos/helgi/provisioner/issues/events{/number}","events_url":"https://api.github.com/repos/helgi/provisioner/events","assignees_url":"https://api.github.com/repos/helgi/provisioner/assignees{/user}","branches_url":"https://api.github.com/repos/helgi/provisioner/branches{/branch}","tags_url":"https://api.github.com/repos/helgi/provisioner/tags","blobs_url":"https://api.github.com/repos/helgi/provisioner/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/helgi/provisioner/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/helgi/provisioner/git/refs{/sha}","trees_url":"https://api.github.com/repos/helgi/provisioner/git/trees{/sha}","statuses_url":"https://api.github.com/repos/helgi/provisioner/statuses/{sha}","languages_url":"https://api.github.com/repos/helgi/provisioner/languages","stargazers_url":"https://api.github.com/repos/helgi/provisioner/stargazers","contributors_url":"https://api.github.com/repos/helgi/provisioner/contributors","subscribers_url":"https://api.github.com/repos/helgi/provisioner/subscribers","subscription_url":"https://api.github.com/repos/helgi/provisioner/subscription","commits_url":"https://api.github.com/repos/helgi/provisioner/commits{/sha}","git_commits_url":"https://api.github.com/repos/helgi/provisioner/git/commits{/sha}","comments_url":"https://api.github.com/repos/helgi/provisioner/comments{/number}","issue_comment_url":"https://api.github.com/repos/helgi/provisioner/issues/comments{/number}","contents_url":"https://api.github.com/repos/helgi/provisioner/contents/{+path}","compare_url":"https://api.github.com/repos/helgi/provisioner/compare/{base}...{head}","merges_url":"https://api.github.com/repos/helgi/provisioner/merges","archive_url":"https://api.github.com/repos/helgi/provisioner/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/helgi/provisioner/downloads","issues_url":"https://api.github.com/repos/helgi/provisioner/issues{/number}","pulls_url":"https://api.github.com/repos/helgi/provisioner/pulls{/number}","milestones_url":"https://api.github.com/repos/helgi/provisioner/milestones{/number}","notifications_url":"https://api.github.com/repos/helgi/provisioner/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/helgi/provisioner/labels{/name}","releases_url":"https://api.github.com/repos/helgi/provisioner/releases{/id}","deployments_url":"https://api.github.com/repos/helgi/provisioner/deployments","created_at":"2017-10-20T03:36:51Z","updated_at":"2017-10-20T03:36:52Z","pushed_at":"2017-11-02T16:54:55Z","git_url":"git://github.com/helgi/provisioner.git","ssh_url":"git@github.com:helgi/provisioner.git","clone_url":"https://github.com/helgi/provisioner.git","svn_url":"https://github.com/helgi/provisioner","homepage":null,"size":52,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gravitational:master","ref":"master","sha":"e56d6f854fbf9b294a2685ba2890a8c0869292d8","user":{"login":"gravitational","id":10781132,"avatar_url":"https://avatars2.githubusercontent.com/u/10781132?v=4","gravatar_id":"","url":"https://api.github.com/users/gravitational","html_url":"https://github.com/gravitational","followers_url":"https://api.github.com/users/gravitational/followers","following_url":"https://api.github.com/users/gravitational/following{/other_user}","gists_url":"https://api.github.com/users/gravitational/gists{/gist_id}","starred_url":"https://api.github.com/users/gravitational/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gravitational/subscriptions","organizations_url":"https://api.github.com/users/gravitational/orgs","repos_url":"https://api.github.com/users/gravitational/repos","events_url":"https://api.github.com/users/gravitational/events{/privacy}","received_events_url":"https://api.github.com/users/gravitational/received_events","type":"Organization","site_admin":false},"repo":{"id":103361578,"name":"provisioner","full_name":"gravitational/provisioner","owner":{"login":"gravitational","id":10781132,"avatar_url":"https://avatars2.githubusercontent.com/u/10781132?v=4","gravatar_id":"","url":"https://api.github.com/users/gravitational","html_url":"https://github.com/gravitational","followers_url":"https://api.github.com/users/gravitational/followers","following_url":"https://api.github.com/users/gravitational/following{/other_user}","gists_url":"https://api.github.com/users/gravitational/gists{/gist_id}","starred_url":"https://api.github.com/users/gravitational/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gravitational/subscriptions","organizations_url":"https://api.github.com/users/gravitational/orgs","repos_url":"https://api.github.com/users/gravitational/repos","events_url":"https://api.github.com/users/gravitational/events{/privacy}","received_events_url":"https://api.github.com/users/gravitational/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gravitational/provisioner","description":"Terraform based provisioners for ops center","fork":false,"url":"https://api.github.com/repos/gravitational/provisioner","forks_url":"https://api.github.com/repos/gravitational/provisioner/forks","keys_url":"https://api.github.com/repos/gravitational/provisioner/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gravitational/provisioner/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gravitational/provisioner/teams","hooks_url":"https://api.github.com/repos/gravitational/provisioner/hooks","issue_events_url":"https://api.github.com/repos/gravitational/provisioner/issues/events{/number}","events_url":"https://api.github.com/repos/gravitational/provisioner/events","assignees_url":"https://api.github.com/repos/gravitational/provisioner/assignees{/user}","branches_url":"https://api.github.com/repos/gravitational/provisioner/branches{/branch}","tags_url":"https://api.github.com/repos/gravitational/provisioner/tags","blobs_url":"https://api.github.com/repos/gravitational/provisioner/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gravitational/provisioner/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gravitational/provisioner/git/refs{/sha}","trees_url":"https://api.github.com/repos/gravitational/provisioner/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gravitational/provisioner/statuses/{sha}","languages_url":"https://api.github.com/repos/gravitational/provisioner/languages","stargazers_url":"https://api.github.com/repos/gravitational/provisioner/stargazers","contributors_url":"https://api.github.com/repos/gravitational/provisioner/contributors","subscribers_url":"https://api.github.com/repos/gravitational/provisioner/subscribers","subscription_url":"https://api.github.com/repos/gravitational/provisioner/subscription","commits_url":"https://api.github.com/repos/gravitational/provisioner/commits{/sha}","git_commits_url":"https://api.github.com/repos/gravitational/provisioner/git/commits{/sha}","comments_url":"https://api.github.com/repos/gravitational/provisioner/comments{/number}","issue_comment_url":"https://api.github.com/repos/gravitational/provisioner/issues/comments{/number}","contents_url":"https://api.github.com/repos/gravitational/provisioner/contents/{+path}","compare_url":"https://api.github.com/repos/gravitational/provisioner/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gravitational/provisioner/merges","archive_url":"https://api.github.com/repos/gravitational/provisioner/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gravitational/provisioner/downloads","issues_url":"https://api.github.com/repos/gravitational/provisioner/issues{/number}","pulls_url":"https://api.github.com/repos/gravitational/provisioner/pulls{/number}","milestones_url":"https://api.github.com/repos/gravitational/provisioner/milestones{/number}","notifications_url":"https://api.github.com/repos/gravitational/provisioner/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gravitational/provisioner/labels{/name}","releases_url":"https://api.github.com/repos/gravitational/provisioner/releases{/id}","deployments_url":"https://api.github.com/repos/gravitational/provisioner/deployments","created_at":"2017-09-13T06:22:23Z","updated_at":"2017-09-28T17:41:55Z","pushed_at":"2017-11-02T16:54:57Z","git_url":"git://github.com/gravitational/provisioner.git","ssh_url":"git@github.com:gravitational/provisioner.git","clone_url":"https://github.com/gravitational/provisioner.git","svn_url":"https://github.com/gravitational/provisioner","homepage":null,"size":43,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gravitational/provisioner/pulls/9"},"html":{"href":"https://github.com/gravitational/provisioner/pull/9"},"issue":{"href":"https://api.github.com/repos/gravitational/provisioner/issues/9"},"comments":{"href":"https://api.github.com/repos/gravitational/provisioner/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/gravitational/provisioner/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/gravitational/provisioner/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gravitational/provisioner/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/gravitational/provisioner/statuses/16e78f2a051f918a5e5045bfabcac2f538fa2f5f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"klizhentas"}}