{"action":"created","issue":{"url":"https://api.github.com/repos/heptio/ark/issues/15","repository_url":"https://api.github.com/repos/heptio/ark","labels_url":"https://api.github.com/repos/heptio/ark/issues/15/labels{/name}","comments_url":"https://api.github.com/repos/heptio/ark/issues/15/comments","events_url":"https://api.github.com/repos/heptio/ark/issues/15/events","html_url":"https://github.com/heptio/ark/issues/15","id":248882014,"number":15,"title":"Improved backup resource selection","user":{"login":"kstewart","id":666,"avatar_url":"https://avatars3.githubusercontent.com/u/666?v=4","gravatar_id":"","url":"https://api.github.com/users/kstewart","html_url":"https://github.com/kstewart","followers_url":"https://api.github.com/users/kstewart/followers","following_url":"https://api.github.com/users/kstewart/following{/other_user}","gists_url":"https://api.github.com/users/kstewart/gists{/gist_id}","starred_url":"https://api.github.com/users/kstewart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kstewart/subscriptions","organizations_url":"https://api.github.com/users/kstewart/orgs","repos_url":"https://api.github.com/users/kstewart/repos","events_url":"https://api.github.com/users/kstewart/events{/privacy}","received_events_url":"https://api.github.com/users/kstewart/received_events","type":"User","site_admin":false},"labels":[{"id":665348751,"url":"https://api.github.com/repos/heptio/ark/labels/p1%20-%20Important","name":"p1 - Important","color":"d93f0b","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-08-09T00:11:17Z","updated_at":"2017-08-10T20:09:05Z","closed_at":null,"body":"If you do `ark backup create foo --include-namespaces andy`, that will back up everything in the 'andy' namespace AND all cluster-scoped resources (the following list is from my local v1.7.3, supporting create + list):\r\n* apiservices\r\n* certificatesigningrequests\r\n* clusterrolebindings\r\n* clusterroles\r\n* customresourcedefinitions\r\n* namespaces\r\n* nodes\r\n* persistentvolumes\r\n* podsecuritypolicies\r\n* storageclasses\r\n* thirdpartyresources\r\n\r\nIf you want to back up a subset of resources, you have to specify some combination of --include-resources, --exclude-resources, and/or --selector.\r\n\r\nIf we decide that one of Ark's core use cases is to allow one or more namespaces to be backed up, we should find a way to limit the resources backed up to just those used by the namespace(s) in question."},"comment":{"url":"https://api.github.com/repos/heptio/ark/issues/comments/321659723","html_url":"https://github.com/heptio/ark/issues/15#issuecomment-321659723","issue_url":"https://api.github.com/repos/heptio/ark/issues/15","id":321659723,"user":{"login":"ncdc","id":354,"avatar_url":"https://avatars2.githubusercontent.com/u/354?v=4","gravatar_id":"","url":"https://api.github.com/users/ncdc","html_url":"https://github.com/ncdc","followers_url":"https://api.github.com/users/ncdc/followers","following_url":"https://api.github.com/users/ncdc/following{/other_user}","gists_url":"https://api.github.com/users/ncdc/gists{/gist_id}","starred_url":"https://api.github.com/users/ncdc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncdc/subscriptions","organizations_url":"https://api.github.com/users/ncdc/orgs","repos_url":"https://api.github.com/users/ncdc/repos","events_url":"https://api.github.com/users/ncdc/events{/privacy}","received_events_url":"https://api.github.com/users/ncdc/received_events","type":"User","site_admin":false},"created_at":"2017-08-10T20:09:05Z","updated_at":"2017-08-10T20:09:05Z","body":"Did some brainstorming with @skriss:\r\n\r\nIf you're trying to back up a specific namespace, you probably don't want to include all cluster-scoped resources. A better approach would probably be to specify the namespace _**and**_ use a label selector. This ensures that the cluster-scoped resources match the selector.\r\n\r\nWhere this doesn't work is with dynamically-provisioned PVs, because they don't assume the labels from the associated PVC. To get around this, I think we should modify the Action() signature to return an optional slice of additional items to back up. In the case of a pod-like resource that references a PVC, we would return that we want to back up the associated PV. We'd need to keep track of a universal list of all resource/name/name items backed up to ensure we don't back up the same PV multiple times."}}
{"actor":{"display_login":"ncdc"}}