{"action":"created","issue":{"url":"https://api.github.com/repos/docker/swarmkit/issues/2095","repository_url":"https://api.github.com/repos/docker/swarmkit","labels_url":"https://api.github.com/repos/docker/swarmkit/issues/2095/labels{/name}","comments_url":"https://api.github.com/repos/docker/swarmkit/issues/2095/comments","events_url":"https://api.github.com/repos/docker/swarmkit/issues/2095/events","html_url":"https://github.com/docker/swarmkit/pull/2095","id":219734289,"number":2095,"title":"Add details field to log message proto","user":{"login":"dperny","id":2367858,"avatar_url":"https://avatars0.githubusercontent.com/u/2367858?v=3","gravatar_id":"","url":"https://api.github.com/users/dperny","html_url":"https://github.com/dperny","followers_url":"https://api.github.com/users/dperny/followers","following_url":"https://api.github.com/users/dperny/following{/other_user}","gists_url":"https://api.github.com/users/dperny/gists{/gist_id}","starred_url":"https://api.github.com/users/dperny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dperny/subscriptions","organizations_url":"https://api.github.com/users/dperny/orgs","repos_url":"https://api.github.com/users/dperny/repos","events_url":"https://api.github.com/users/dperny/events{/privacy}","received_events_url":"https://api.github.com/users/dperny/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2017-04-05T22:29:58Z","updated_at":"2017-05-02T21:21:58Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/docker/swarmkit/pulls/2095","html_url":"https://github.com/docker/swarmkit/pull/2095","diff_url":"https://github.com/docker/swarmkit/pull/2095.diff","patch_url":"https://github.com/docker/swarmkit/pull/2095.patch"},"body":"Adds a field to proto messages for addition log details, such as those returned by the `--details` flag on docker container logs.\r\n\r\nRight now, none of the swarmkit code actually uses this field. This is deliberate. Basically, details are REALLY hard (read: basically computationally impossible) to parse out of the docker REST API log stream, and I need to make changes to container logs on `docker/docker` before it can reliably be done. HOWEVER, with this field, the container adapter in `docker/docker` can reliably, safely, and with minimal arm-twisting, add the log details to the log message, and then `ServiceLogs` will be able to use them.\r\n\r\nAfter a PR changing the way details are sent over the wire is merged in `docker/docker`, I will submit a follow-up PR to this one supporting details in `swarmd`. If I were to include those changes in this PR, it would create a mutual dependency between the this and the corresponding `docker/docker` PR. By doing this in 3 parts, I avoid that case.\r\n\r\nSigned-off-by: Drew Erny <drew.erny@docker.com>"},"comment":{"url":"https://api.github.com/repos/docker/swarmkit/issues/comments/298765189","html_url":"https://github.com/docker/swarmkit/pull/2095#issuecomment-298765189","issue_url":"https://api.github.com/repos/docker/swarmkit/issues/2095","id":298765189,"user":{"login":"dperny","id":2367858,"avatar_url":"https://avatars0.githubusercontent.com/u/2367858?v=3","gravatar_id":"","url":"https://api.github.com/users/dperny","html_url":"https://github.com/dperny","followers_url":"https://api.github.com/users/dperny/followers","following_url":"https://api.github.com/users/dperny/following{/other_user}","gists_url":"https://api.github.com/users/dperny/gists{/gist_id}","starred_url":"https://api.github.com/users/dperny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dperny/subscriptions","organizations_url":"https://api.github.com/users/dperny/orgs","repos_url":"https://api.github.com/users/dperny/repos","events_url":"https://api.github.com/users/dperny/events{/privacy}","received_events_url":"https://api.github.com/users/dperny/received_events","type":"User","site_admin":false},"created_at":"2017-05-02T21:21:58Z","updated_at":"2017-05-02T21:21:58Z","body":"At the CLI level and in the documentation, it's called `details`. I'm open\nto renaming to `Attrs` if you want me to. Just give me the affirmative to\ngo ahead if you think I'd be better.\n\nOn May 2, 2017 2:19 PM, \"Dongluo Chen\" <notifications@github.com> wrote:\n\n> It might have been discussed elsewhere. But why do you name it Details?\n> It looks like attributes.\n>\n> —\n> You are receiving this because you authored the thread.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/docker/swarmkit/pull/2095#issuecomment-298764540>, or mute\n> the thread\n> <https://github.com/notifications/unsubscribe-auth/ACQhctd0mh7efAqDZE2lIrdCkgQh-IW1ks5r153UgaJpZM4M05Me>\n> .\n>\n"}}
{"actor":{"display_login":"dperny"}}