{"action":"created","comment":{"url":"https://api.github.com/repos/publica-project/vast/pulls/comments/130211338","pull_request_review_id":53066829,"id":130211338,"diff_hunk":"@@ -345,15 +349,15 @@ type NonLinear struct {\n \t// The apiFramework defines the method to use for communication with the nonlinear element.\n \tAPIFramework string `xml:\"apiFramework,attr,omitempty\"`\n \t// URLs to ping when user clicks on the the non-linear ad.\n-\tNonLinearClickTracking []string `xml:\",omitempty\"`\n+\tNonLinearClickTracking []CDATA `xml:\",omitempty\"`","path":"vast.go","position":98,"original_position":98,"commit_id":"0d27724a14fad5b547def8d269a51cfebde4aed8","original_commit_id":"0d27724a14fad5b547def8d269a51cfebde4aed8","user":{"login":"kalbasit","id":87115,"avatar_url":"https://avatars2.githubusercontent.com/u/87115?v=4","gravatar_id":"","url":"https://api.github.com/users/kalbasit","html_url":"https://github.com/kalbasit","followers_url":"https://api.github.com/users/kalbasit/followers","following_url":"https://api.github.com/users/kalbasit/following{/other_user}","gists_url":"https://api.github.com/users/kalbasit/gists{/gist_id}","starred_url":"https://api.github.com/users/kalbasit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalbasit/subscriptions","organizations_url":"https://api.github.com/users/kalbasit/orgs","repos_url":"https://api.github.com/users/kalbasit/repos","events_url":"https://api.github.com/users/kalbasit/events{/privacy}","received_events_url":"https://api.github.com/users/kalbasit/received_events","type":"User","site_admin":false},"body":"did you try `NonLinearClickTracking []string `xml:\",cdata,omitempty`? Try adding a test with it withCDATA and without. If it works, please change all of them and remove the `CDATA` struct","created_at":"2017-07-29T02:06:52Z","updated_at":"2017-07-29T02:09:53Z","html_url":"https://github.com/publica-project/vast/pull/3#discussion_r130211338","pull_request_url":"https://api.github.com/repos/publica-project/vast/pulls/3","_links":{"self":{"href":"https://api.github.com/repos/publica-project/vast/pulls/comments/130211338"},"html":{"href":"https://github.com/publica-project/vast/pull/3#discussion_r130211338"},"pull_request":{"href":"https://api.github.com/repos/publica-project/vast/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/publica-project/vast/pulls/3","id":133075415,"html_url":"https://github.com/publica-project/vast/pull/3","diff_url":"https://github.com/publica-project/vast/pull/3.diff","patch_url":"https://github.com/publica-project/vast/pull/3.patch","issue_url":"https://api.github.com/repos/publica-project/vast/issues/3","number":3,"state":"open","locked":false,"title":"all URIs must be of type CDATA (cdata-fix)","user":{"login":"nabhanelrahman","id":18206402,"avatar_url":"https://avatars3.githubusercontent.com/u/18206402?v=4","gravatar_id":"","url":"https://api.github.com/users/nabhanelrahman","html_url":"https://github.com/nabhanelrahman","followers_url":"https://api.github.com/users/nabhanelrahman/followers","following_url":"https://api.github.com/users/nabhanelrahman/following{/other_user}","gists_url":"https://api.github.com/users/nabhanelrahman/gists{/gist_id}","starred_url":"https://api.github.com/users/nabhanelrahman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nabhanelrahman/subscriptions","organizations_url":"https://api.github.com/users/nabhanelrahman/orgs","repos_url":"https://api.github.com/users/nabhanelrahman/repos","events_url":"https://api.github.com/users/nabhanelrahman/events{/privacy}","received_events_url":"https://api.github.com/users/nabhanelrahman/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-07-29T01:36:53Z","updated_at":"2017-07-29T02:09:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"52f8231053f479c8379316f0536232f3975dcd08","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/publica-project/vast/pulls/3/commits","review_comments_url":"https://api.github.com/repos/publica-project/vast/pulls/3/comments","review_comment_url":"https://api.github.com/repos/publica-project/vast/pulls/comments{/number}","comments_url":"https://api.github.com/repos/publica-project/vast/issues/3/comments","statuses_url":"https://api.github.com/repos/publica-project/vast/statuses/0d27724a14fad5b547def8d269a51cfebde4aed8","head":{"label":"publica-project:cdata-fix","ref":"cdata-fix","sha":"0d27724a14fad5b547def8d269a51cfebde4aed8","user":{"login":"publica-project","id":18206504,"avatar_url":"https://avatars3.githubusercontent.com/u/18206504?v=4","gravatar_id":"","url":"https://api.github.com/users/publica-project","html_url":"https://github.com/publica-project","followers_url":"https://api.github.com/users/publica-project/followers","following_url":"https://api.github.com/users/publica-project/following{/other_user}","gists_url":"https://api.github.com/users/publica-project/gists{/gist_id}","starred_url":"https://api.github.com/users/publica-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/publica-project/subscriptions","organizations_url":"https://api.github.com/users/publica-project/orgs","repos_url":"https://api.github.com/users/publica-project/repos","events_url":"https://api.github.com/users/publica-project/events{/privacy}","received_events_url":"https://api.github.com/users/publica-project/received_events","type":"Organization","site_admin":false},"repo":{"id":81507477,"name":"vast","full_name":"publica-project/vast","owner":{"login":"publica-project","id":18206504,"avatar_url":"https://avatars3.githubusercontent.com/u/18206504?v=4","gravatar_id":"","url":"https://api.github.com/users/publica-project","html_url":"https://github.com/publica-project","followers_url":"https://api.github.com/users/publica-project/followers","following_url":"https://api.github.com/users/publica-project/following{/other_user}","gists_url":"https://api.github.com/users/publica-project/gists{/gist_id}","starred_url":"https://api.github.com/users/publica-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/publica-project/subscriptions","organizations_url":"https://api.github.com/users/publica-project/orgs","repos_url":"https://api.github.com/users/publica-project/repos","events_url":"https://api.github.com/users/publica-project/events{/privacy}","received_events_url":"https://api.github.com/users/publica-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/publica-project/vast","description":"Golang VAST 3.0 library","fork":true,"url":"https://api.github.com/repos/publica-project/vast","forks_url":"https://api.github.com/repos/publica-project/vast/forks","keys_url":"https://api.github.com/repos/publica-project/vast/keys{/key_id}","collaborators_url":"https://api.github.com/repos/publica-project/vast/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/publica-project/vast/teams","hooks_url":"https://api.github.com/repos/publica-project/vast/hooks","issue_events_url":"https://api.github.com/repos/publica-project/vast/issues/events{/number}","events_url":"https://api.github.com/repos/publica-project/vast/events","assignees_url":"https://api.github.com/repos/publica-project/vast/assignees{/user}","branches_url":"https://api.github.com/repos/publica-project/vast/branches{/branch}","tags_url":"https://api.github.com/repos/publica-project/vast/tags","blobs_url":"https://api.github.com/repos/publica-project/vast/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/publica-project/vast/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/publica-project/vast/git/refs{/sha}","trees_url":"https://api.github.com/repos/publica-project/vast/git/trees{/sha}","statuses_url":"https://api.github.com/repos/publica-project/vast/statuses/{sha}","languages_url":"https://api.github.com/repos/publica-project/vast/languages","stargazers_url":"https://api.github.com/repos/publica-project/vast/stargazers","contributors_url":"https://api.github.com/repos/publica-project/vast/contributors","subscribers_url":"https://api.github.com/repos/publica-project/vast/subscribers","subscription_url":"https://api.github.com/repos/publica-project/vast/subscription","commits_url":"https://api.github.com/repos/publica-project/vast/commits{/sha}","git_commits_url":"https://api.github.com/repos/publica-project/vast/git/commits{/sha}","comments_url":"https://api.github.com/repos/publica-project/vast/comments{/number}","issue_comment_url":"https://api.github.com/repos/publica-project/vast/issues/comments{/number}","contents_url":"https://api.github.com/repos/publica-project/vast/contents/{+path}","compare_url":"https://api.github.com/repos/publica-project/vast/compare/{base}...{head}","merges_url":"https://api.github.com/repos/publica-project/vast/merges","archive_url":"https://api.github.com/repos/publica-project/vast/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/publica-project/vast/downloads","issues_url":"https://api.github.com/repos/publica-project/vast/issues{/number}","pulls_url":"https://api.github.com/repos/publica-project/vast/pulls{/number}","milestones_url":"https://api.github.com/repos/publica-project/vast/milestones{/number}","notifications_url":"https://api.github.com/repos/publica-project/vast/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/publica-project/vast/labels{/name}","releases_url":"https://api.github.com/repos/publica-project/vast/releases{/id}","deployments_url":"https://api.github.com/repos/publica-project/vast/deployments","created_at":"2017-02-10T00:04:30Z","updated_at":"2017-02-10T00:04:32Z","pushed_at":"2017-07-29T01:58:09Z","git_url":"git://github.com/publica-project/vast.git","ssh_url":"git@github.com:publica-project/vast.git","clone_url":"https://github.com/publica-project/vast.git","svn_url":"https://github.com/publica-project/vast","homepage":null,"size":41,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"publica-project:master","ref":"master","sha":"fe3761be36a850d8bbe52ae44182db28a15c3590","user":{"login":"publica-project","id":18206504,"avatar_url":"https://avatars3.githubusercontent.com/u/18206504?v=4","gravatar_id":"","url":"https://api.github.com/users/publica-project","html_url":"https://github.com/publica-project","followers_url":"https://api.github.com/users/publica-project/followers","following_url":"https://api.github.com/users/publica-project/following{/other_user}","gists_url":"https://api.github.com/users/publica-project/gists{/gist_id}","starred_url":"https://api.github.com/users/publica-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/publica-project/subscriptions","organizations_url":"https://api.github.com/users/publica-project/orgs","repos_url":"https://api.github.com/users/publica-project/repos","events_url":"https://api.github.com/users/publica-project/events{/privacy}","received_events_url":"https://api.github.com/users/publica-project/received_events","type":"Organization","site_admin":false},"repo":{"id":81507477,"name":"vast","full_name":"publica-project/vast","owner":{"login":"publica-project","id":18206504,"avatar_url":"https://avatars3.githubusercontent.com/u/18206504?v=4","gravatar_id":"","url":"https://api.github.com/users/publica-project","html_url":"https://github.com/publica-project","followers_url":"https://api.github.com/users/publica-project/followers","following_url":"https://api.github.com/users/publica-project/following{/other_user}","gists_url":"https://api.github.com/users/publica-project/gists{/gist_id}","starred_url":"https://api.github.com/users/publica-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/publica-project/subscriptions","organizations_url":"https://api.github.com/users/publica-project/orgs","repos_url":"https://api.github.com/users/publica-project/repos","events_url":"https://api.github.com/users/publica-project/events{/privacy}","received_events_url":"https://api.github.com/users/publica-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/publica-project/vast","description":"Golang VAST 3.0 library","fork":true,"url":"https://api.github.com/repos/publica-project/vast","forks_url":"https://api.github.com/repos/publica-project/vast/forks","keys_url":"https://api.github.com/repos/publica-project/vast/keys{/key_id}","collaborators_url":"https://api.github.com/repos/publica-project/vast/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/publica-project/vast/teams","hooks_url":"https://api.github.com/repos/publica-project/vast/hooks","issue_events_url":"https://api.github.com/repos/publica-project/vast/issues/events{/number}","events_url":"https://api.github.com/repos/publica-project/vast/events","assignees_url":"https://api.github.com/repos/publica-project/vast/assignees{/user}","branches_url":"https://api.github.com/repos/publica-project/vast/branches{/branch}","tags_url":"https://api.github.com/repos/publica-project/vast/tags","blobs_url":"https://api.github.com/repos/publica-project/vast/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/publica-project/vast/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/publica-project/vast/git/refs{/sha}","trees_url":"https://api.github.com/repos/publica-project/vast/git/trees{/sha}","statuses_url":"https://api.github.com/repos/publica-project/vast/statuses/{sha}","languages_url":"https://api.github.com/repos/publica-project/vast/languages","stargazers_url":"https://api.github.com/repos/publica-project/vast/stargazers","contributors_url":"https://api.github.com/repos/publica-project/vast/contributors","subscribers_url":"https://api.github.com/repos/publica-project/vast/subscribers","subscription_url":"https://api.github.com/repos/publica-project/vast/subscription","commits_url":"https://api.github.com/repos/publica-project/vast/commits{/sha}","git_commits_url":"https://api.github.com/repos/publica-project/vast/git/commits{/sha}","comments_url":"https://api.github.com/repos/publica-project/vast/comments{/number}","issue_comment_url":"https://api.github.com/repos/publica-project/vast/issues/comments{/number}","contents_url":"https://api.github.com/repos/publica-project/vast/contents/{+path}","compare_url":"https://api.github.com/repos/publica-project/vast/compare/{base}...{head}","merges_url":"https://api.github.com/repos/publica-project/vast/merges","archive_url":"https://api.github.com/repos/publica-project/vast/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/publica-project/vast/downloads","issues_url":"https://api.github.com/repos/publica-project/vast/issues{/number}","pulls_url":"https://api.github.com/repos/publica-project/vast/pulls{/number}","milestones_url":"https://api.github.com/repos/publica-project/vast/milestones{/number}","notifications_url":"https://api.github.com/repos/publica-project/vast/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/publica-project/vast/labels{/name}","releases_url":"https://api.github.com/repos/publica-project/vast/releases{/id}","deployments_url":"https://api.github.com/repos/publica-project/vast/deployments","created_at":"2017-02-10T00:04:30Z","updated_at":"2017-02-10T00:04:32Z","pushed_at":"2017-07-29T01:58:09Z","git_url":"git://github.com/publica-project/vast.git","ssh_url":"git@github.com:publica-project/vast.git","clone_url":"https://github.com/publica-project/vast.git","svn_url":"https://github.com/publica-project/vast","homepage":null,"size":41,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/publica-project/vast/pulls/3"},"html":{"href":"https://github.com/publica-project/vast/pull/3"},"issue":{"href":"https://api.github.com/repos/publica-project/vast/issues/3"},"comments":{"href":"https://api.github.com/repos/publica-project/vast/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/publica-project/vast/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/publica-project/vast/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/publica-project/vast/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/publica-project/vast/statuses/0d27724a14fad5b547def8d269a51cfebde4aed8"}}}}
{"actor":{"display_login":"kalbasit"}}