{"action":"created","issue":{"url":"https://api.github.com/repos/kaldi-asr/kaldi/issues/1879","repository_url":"https://api.github.com/repos/kaldi-asr/kaldi","labels_url":"https://api.github.com/repos/kaldi-asr/kaldi/issues/1879/labels{/name}","comments_url":"https://api.github.com/repos/kaldi-asr/kaldi/issues/1879/comments","events_url":"https://api.github.com/repos/kaldi-asr/kaldi/issues/1879/events","html_url":"https://github.com/kaldi-asr/kaldi/pull/1879","id":256705125,"number":1879,"title":"utilizing smart pointers in the decoder-weappers","user":{"login":"lordadamson","id":6195060,"avatar_url":"https://avatars0.githubusercontent.com/u/6195060?v=4","gravatar_id":"","url":"https://api.github.com/users/lordadamson","html_url":"https://github.com/lordadamson","followers_url":"https://api.github.com/users/lordadamson/followers","following_url":"https://api.github.com/users/lordadamson/following{/other_user}","gists_url":"https://api.github.com/users/lordadamson/gists{/gist_id}","starred_url":"https://api.github.com/users/lordadamson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lordadamson/subscriptions","organizations_url":"https://api.github.com/users/lordadamson/orgs","repos_url":"https://api.github.com/users/lordadamson/repos","events_url":"https://api.github.com/users/lordadamson/events{/privacy}","received_events_url":"https://api.github.com/users/lordadamson/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-09-11T13:36:42Z","updated_at":"2017-09-11T13:43:48Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kaldi-asr/kaldi/pulls/1879","html_url":"https://github.com/kaldi-asr/kaldi/pull/1879","diff_url":"https://github.com/kaldi-asr/kaldi/pull/1879.diff","patch_url":"https://github.com/kaldi-asr/kaldi/pull/1879.patch"},"body":"We've been discussing the ability to utilize smart pointers in the forums. Here's my attempt to a high level convenience class without breaking compatibility.\r\n"},"comment":{"url":"https://api.github.com/repos/kaldi-asr/kaldi/issues/comments/328533138","html_url":"https://github.com/kaldi-asr/kaldi/pull/1879#issuecomment-328533138","issue_url":"https://api.github.com/repos/kaldi-asr/kaldi/issues/1879","id":328533138,"user":{"login":"jtrmal","id":11054175,"avatar_url":"https://avatars2.githubusercontent.com/u/11054175?v=4","gravatar_id":"","url":"https://api.github.com/users/jtrmal","html_url":"https://github.com/jtrmal","followers_url":"https://api.github.com/users/jtrmal/followers","following_url":"https://api.github.com/users/jtrmal/following{/other_user}","gists_url":"https://api.github.com/users/jtrmal/gists{/gist_id}","starred_url":"https://api.github.com/users/jtrmal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtrmal/subscriptions","organizations_url":"https://api.github.com/users/jtrmal/orgs","repos_url":"https://api.github.com/users/jtrmal/repos","events_url":"https://api.github.com/users/jtrmal/events{/privacy}","received_events_url":"https://api.github.com/users/jtrmal/received_events","type":"User","site_admin":false},"created_at":"2017-09-11T13:43:47Z","updated_at":"2017-09-11T13:43:47Z","author_association":"CONTRIBUTOR","body":"Please note you've broken the formatting of the file and I believe \"using\nnamespace something\" is generally discouraged - it should be either\nexplicit import (using sts::unique_ptr) or just add explicitly the std::\nprefix whenever you need the given class.\nNo need to fix that now, as I assume it's on KY a proof of concept.\nY.\n\nOn Sep 11, 2017 09:36, \"Adam Zahran\" <notifications@github.com> wrote:\n\n> We've been discussing the ability to utilize smart pointers in the forums.\n> Here's my attempt to a high level convenience class without breaking\n> compatibility.\n> ------------------------------\n> You can view, comment on, or merge this pull request online at:\n>\n>   https://github.com/kaldi-asr/kaldi/pull/1879\n> Commit Summary\n>\n>    - utilizing smart pointers in the decoder-weappers\n>\n> File Changes\n>\n>    - *M* src/decoder/decoder-wrappers.cc\n>    <https://github.com/kaldi-asr/kaldi/pull/1879/files#diff-0> (38)\n>    - *M* src/decoder/decoder-wrappers.h\n>    <https://github.com/kaldi-asr/kaldi/pull/1879/files#diff-1> (16)\n>\n> Patch Links:\n>\n>    - https://github.com/kaldi-asr/kaldi/pull/1879.patch\n>    - https://github.com/kaldi-asr/kaldi/pull/1879.diff\n>\n> —\n> You are receiving this because you are subscribed to this thread.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/kaldi-asr/kaldi/pull/1879>, or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/AKisX6BhYPFdo5eN5tQ43BfxmgUw1R0lks5shTd4gaJpZM4PTK8C>\n> .\n>\n"}}
{"actor":{"display_login":"jtrmal"}}