{"action":"created","issue":{"url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/issues/239","repository_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware","labels_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/issues/239/labels{/name}","comments_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/issues/239/comments","events_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/issues/239/events","html_url":"https://github.com/sPHENIX-Collaboration/coresoftware/pull/239","id":201316133,"number":239,"title":"GenFit KalmanFitter: dca3d, laddered MAPS and INTT and bug fixes","user":{"login":"HaiwangYu","id":10383186,"avatar_url":"https://avatars.githubusercontent.com/u/10383186?v=3","gravatar_id":"","url":"https://api.github.com/users/HaiwangYu","html_url":"https://github.com/HaiwangYu","followers_url":"https://api.github.com/users/HaiwangYu/followers","following_url":"https://api.github.com/users/HaiwangYu/following{/other_user}","gists_url":"https://api.github.com/users/HaiwangYu/gists{/gist_id}","starred_url":"https://api.github.com/users/HaiwangYu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HaiwangYu/subscriptions","organizations_url":"https://api.github.com/users/HaiwangYu/orgs","repos_url":"https://api.github.com/users/HaiwangYu/repos","events_url":"https://api.github.com/users/HaiwangYu/events{/privacy}","received_events_url":"https://api.github.com/users/HaiwangYu/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-01-17T15:20:01Z","updated_at":"2017-01-18T06:34:07Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/pulls/239","html_url":"https://github.com/sPHENIX-Collaboration/coresoftware/pull/239","diff_url":"https://github.com/sPHENIX-Collaboration/coresoftware/pull/239.diff","patch_url":"https://github.com/sPHENIX-Collaboration/coresoftware/pull/239.patch"},"body":"- dca3d development: In addition to the dca3d/error calculations in the PHG4TrackKalmanFitter, also modified SvtxTrack_v1 to store the dca3d information. related talk: https://indico.bnl.gov/getFile.py/access?contribId=2&resId=0&materialId=slides&confId=1940\r\n\r\n- Laddered MAPS and INTT handling\r\n\r\n  -  Now, by default, the PHG4TrackKalmanFitter runs in cylindrical mode. To switch to laddered MAPS and INTT mode, do `PHG4TrackKalmanFitter::set_detector_type(PHG4TrackKalmanFitter::LADDER_MAPS_LADDER_IT_TPC) `\r\n  - Some event display showing the norm vector:\r\n \r\n![image](https://cloud.githubusercontent.com/assets/10383186/22025946/4fd0d020-dc9d-11e6-88e7-8a86aba39456.png)\r\n![image](https://cloud.githubusercontent.com/assets/10383186/22025975/61b8a1aa-dc9d-11e6-8ad7-d9ae4bf16db7.png)\r\n\r\n\r\n- Fixed memory leaks in PHG4TrackKalmanFitter and PHGenFit: haven't fixed all, will continue to work on it.\r\n\r\n- Bugs fixed\r\n    - Track refitting efficiency, reported by Sanghoon.\r\n    - Track vertex association bug, reported by Sasha.\r\n- Updated default parameters for PHG4TrackKalmanFitter constructer, now it runs out of box simply as (default in cylindrical mode for now):\r\n`PHG4TrackKalmanFitter *kalman = new PHG4TrackKalmanFitter();`\r\n` se->registerSubsystem(kalman);`\r\n\r\n- Example macro to run PHG4TrackKalmanFitter:\r\n  - https://github.com/HaiwangYu/macros/blob/b_jet_tagging_hijing/macros/g4simulations/RunGenFit.C"},"comment":{"url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/issues/comments/273395889","html_url":"https://github.com/sPHENIX-Collaboration/coresoftware/pull/239#issuecomment-273395889","issue_url":"https://api.github.com/repos/sPHENIX-Collaboration/coresoftware/issues/239","id":273395889,"user":{"login":"HaiwangYu","id":10383186,"avatar_url":"https://avatars.githubusercontent.com/u/10383186?v=3","gravatar_id":"","url":"https://api.github.com/users/HaiwangYu","html_url":"https://github.com/HaiwangYu","followers_url":"https://api.github.com/users/HaiwangYu/followers","following_url":"https://api.github.com/users/HaiwangYu/following{/other_user}","gists_url":"https://api.github.com/users/HaiwangYu/gists{/gist_id}","starred_url":"https://api.github.com/users/HaiwangYu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HaiwangYu/subscriptions","organizations_url":"https://api.github.com/users/HaiwangYu/orgs","repos_url":"https://api.github.com/users/HaiwangYu/repos","events_url":"https://api.github.com/users/HaiwangYu/events{/privacy}","received_events_url":"https://api.github.com/users/HaiwangYu/received_events","type":"User","site_admin":false},"created_at":"2017-01-18T06:34:07Z","updated_at":"2017-01-18T06:34:07Z","body":"Many thanks Jin for the implementation!\r\nI modified the PR branch and did some tests to prove this works.\r\n\r\nOriginal:\r\n![image](https://cloud.githubusercontent.com/assets/10383186/22053305/c6390a04-dd1d-11e6-8274-d237c2a703df.png)\r\n\r\nWith this approximae drift time fixing:\r\n![image](https://cloud.githubusercontent.com/assets/10383186/22053119/ace3e89a-dd1c-11e6-9bf8-ffc26540b790.png)\r\n"}}
{"actor":{"display_login":"HaiwangYu"}}