{"action":"created","comment":{"url":"https://api.github.com/repos/urbanairship/ios-gimbal-adapter/pulls/comments/118303722","pull_request_review_id":40082903,"id":118303722,"diff_hunk":"@@ -120,10 +122,10 @@ - (void)placeManager:(GMBLPlaceManager *)manager didBeginVisit:(GMBLVisit *)visi\n \n - (void)placeManager:(GMBLPlaceManager *)manager didEndVisit:(GMBLVisit *)visit {\n     UA_LDEBUG(@\"Exited a Gimbal Place: %@ Entrance date:%@ Exit Date:%@\", visit.place.name, visit.arrivalDate, visit.departureDate);\n-\n     UARegionEvent *regionEvent = [UARegionEvent regionEventWithRegionID:visit.place.identifier\n                                                                  source:GimbalSource\n                                                           boundaryEvent:UABoundaryEventExit];\n+    [[UAirship shared].analytics addEvent:regionEvent];","path":"UAGimbalAdapter.m","position":158,"original_position":158,"commit_id":"f3d3ce96dffd6f39d31d2b4238e48bfefe218fc2","original_commit_id":"f3d3ce96dffd6f39d31d2b4238e48bfefe218fc2","user":{"login":"rlepinski","id":3967591,"avatar_url":"https://avatars3.githubusercontent.com/u/3967591?v=3","gravatar_id":"","url":"https://api.github.com/users/rlepinski","html_url":"https://github.com/rlepinski","followers_url":"https://api.github.com/users/rlepinski/followers","following_url":"https://api.github.com/users/rlepinski/following{/other_user}","gists_url":"https://api.github.com/users/rlepinski/gists{/gist_id}","starred_url":"https://api.github.com/users/rlepinski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rlepinski/subscriptions","organizations_url":"https://api.github.com/users/rlepinski/orgs","repos_url":"https://api.github.com/users/rlepinski/repos","events_url":"https://api.github.com/users/rlepinski/events{/privacy}","received_events_url":"https://api.github.com/users/rlepinski/received_events","type":"User","site_admin":false},"body":"Ooops","created_at":"2017-05-24T16:40:51Z","updated_at":"2017-05-24T16:40:51Z","html_url":"https://github.com/urbanairship/ios-gimbal-adapter/pull/2#discussion_r118303722","pull_request_url":"https://api.github.com/repos/urbanairship/ios-gimbal-adapter/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/urbanairship/ios-gimbal-adapter/pulls/comments/118303722"},"html":{"href":"https://github.com/urbanairship/ios-gimbal-adapter/pull/2#discussion_r118303722"},"pull_request":{"href":"https://api.github.com/repos/urbanairship/ios-gimbal-adapter/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/urbanairship/ios-gimbal-adapter/pulls/2","id":121341139,"html_url":"https://github.com/urbanairship/ios-gimbal-adapter/pull/2","diff_url":"https://github.com/urbanairship/ios-gimbal-adapter/pull/2.diff","patch_url":"https://github.com/urbanairship/ios-gimbal-adapter/pull/2.patch","issue_url":"https://api.github.com/repos/urbanairship/ios-gimbal-adapter/issues/2","number":2,"state":"open","locked":false,"title":"Adding UA Identifiers to Gimbal Device Attributes","user":{"login":"garydamm","id":4275777,"avatar_url":"https://avatars0.githubusercontent.com/u/4275777?v=3","gravatar_id":"","url":"https://api.github.com/users/garydamm","html_url":"https://github.com/garydamm","followers_url":"https://api.github.com/users/garydamm/followers","following_url":"https://api.github.com/users/garydamm/following{/other_user}","gists_url":"https://api.github.com/users/garydamm/gists{/gist_id}","starred_url":"https://api.github.com/users/garydamm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garydamm/subscriptions","organizations_url":"https://api.github.com/users/garydamm/orgs","repos_url":"https://api.github.com/users/garydamm/repos","events_url":"https://api.github.com/users/garydamm/events{/privacy}","received_events_url":"https://api.github.com/users/garydamm/received_events","type":"User","site_admin":false},"body":"Gimbal is adding the Urban Airship channel ID and named user ID to the\r\nGimbal Device Attributes.\r\n\r\nThe reason for this is to allow customers to link their UA Push\r\nMessaging data to Gimbal Place Events in Gimbal Manager based on these\r\nidentifiers being related to the Gimbal Application Instance ID.\r\n\r\nWe also made some implementation changes to attempt to make the code\r\nmore readable and efficient. We did not make any public interface\r\nchanges.","created_at":"2017-05-18T17:50:08Z","updated_at":"2017-05-24T16:40:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bb4e0b7b4445a5701dc4ffc4200351dc17a9143c","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/urbanairship/ios-gimbal-adapter/pulls/2/commits","review_comments_url":"https://api.github.com/repos/urbanairship/ios-gimbal-adapter/pulls/2/comments","review_comment_url":"https://api.github.com/repos/urbanairship/ios-gimbal-adapter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/urbanairship/ios-gimbal-adapter/issues/2/comments","statuses_url":"https://api.github.com/repos/urbanairship/ios-gimbal-adapter/statuses/f3d3ce96dffd6f39d31d2b4238e48bfefe218fc2","head":{"label":"garydamm:add_ua_identifiers_to_gimbal_device_attributes","ref":"add_ua_identifiers_to_gimbal_device_attributes","sha":"f3d3ce96dffd6f39d31d2b4238e48bfefe218fc2","user":{"login":"garydamm","id":4275777,"avatar_url":"https://avatars0.githubusercontent.com/u/4275777?v=3","gravatar_id":"","url":"https://api.github.com/users/garydamm","html_url":"https://github.com/garydamm","followers_url":"https://api.github.com/users/garydamm/followers","following_url":"https://api.github.com/users/garydamm/following{/other_user}","gists_url":"https://api.github.com/users/garydamm/gists{/gist_id}","starred_url":"https://api.github.com/users/garydamm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garydamm/subscriptions","organizations_url":"https://api.github.com/users/garydamm/orgs","repos_url":"https://api.github.com/users/garydamm/repos","events_url":"https://api.github.com/users/garydamm/events{/privacy}","received_events_url":"https://api.github.com/users/garydamm/received_events","type":"User","site_admin":false},"repo":{"id":91721738,"name":"ios-gimbal-adapter","full_name":"garydamm/ios-gimbal-adapter","owner":{"login":"garydamm","id":4275777,"avatar_url":"https://avatars0.githubusercontent.com/u/4275777?v=3","gravatar_id":"","url":"https://api.github.com/users/garydamm","html_url":"https://github.com/garydamm","followers_url":"https://api.github.com/users/garydamm/followers","following_url":"https://api.github.com/users/garydamm/following{/other_user}","gists_url":"https://api.github.com/users/garydamm/gists{/gist_id}","starred_url":"https://api.github.com/users/garydamm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garydamm/subscriptions","organizations_url":"https://api.github.com/users/garydamm/orgs","repos_url":"https://api.github.com/users/garydamm/repos","events_url":"https://api.github.com/users/garydamm/events{/privacy}","received_events_url":"https://api.github.com/users/garydamm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/garydamm/ios-gimbal-adapter","description":"The iOS Gimbal adapter for Urban Airship","fork":true,"url":"https://api.github.com/repos/garydamm/ios-gimbal-adapter","forks_url":"https://api.github.com/repos/garydamm/ios-gimbal-adapter/forks","keys_url":"https://api.github.com/repos/garydamm/ios-gimbal-adapter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/garydamm/ios-gimbal-adapter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/garydamm/ios-gimbal-adapter/teams","hooks_url":"https://api.github.com/repos/garydamm/ios-gimbal-adapter/hooks","issue_events_url":"https://api.github.com/repos/garydamm/ios-gimbal-adapter/issues/events{/number}","events_url":"https://api.github.com/repos/garydamm/ios-gimbal-adapter/events","assignees_url":"https://api.github.com/repos/garydamm/ios-gimbal-adapter/assignees{/user}","branches_url":"https://api.github.com/repos/garydamm/ios-gimbal-adapter/branches{/branch}","tags_url":"https://api.github.com/repos/garydamm/ios-gimbal-adapter/tags","blobs_url":"https://api.github.com/repos/garydamm/ios-gimbal-adapter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/garydamm/ios-gimbal-adapter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/garydamm/ios-gimbal-adapter/git/refs{/sha}","trees_url":"https://api.github.com/repos/garydamm/ios-gimbal-adapter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/garydamm/ios-gimbal-adapter/statuses/{sha}","languages_url":"https://api.github.com/repos/garydamm/ios-gimbal-adapter/languages","stargazers_url":"https://api.github.com/repos/garydamm/ios-gimbal-adapter/stargazers","contributors_url":"https://api.github.com/repos/garydamm/ios-gimbal-adapter/contributors","subscribers_url":"https://api.github.com/repos/garydamm/ios-gimbal-adapter/subscribers","subscription_url":"https://api.github.com/repos/garydamm/ios-gimbal-adapter/subscription","commits_url":"https://api.github.com/repos/garydamm/ios-gimbal-adapter/commits{/sha}","git_commits_url":"https://api.github.com/repos/garydamm/ios-gimbal-adapter/git/commits{/sha}","comments_url":"https://api.github.com/repos/garydamm/ios-gimbal-adapter/comments{/number}","issue_comment_url":"https://api.github.com/repos/garydamm/ios-gimbal-adapter/issues/comments{/number}","contents_url":"https://api.github.com/repos/garydamm/ios-gimbal-adapter/contents/{+path}","compare_url":"https://api.github.com/repos/garydamm/ios-gimbal-adapter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/garydamm/ios-gimbal-adapter/merges","archive_url":"https://api.github.com/repos/garydamm/ios-gimbal-adapter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/garydamm/ios-gimbal-adapter/downloads","issues_url":"https://api.github.com/repos/garydamm/ios-gimbal-adapter/issues{/number}","pulls_url":"https://api.github.com/repos/garydamm/ios-gimbal-adapter/pulls{/number}","milestones_url":"https://api.github.com/repos/garydamm/ios-gimbal-adapter/milestones{/number}","notifications_url":"https://api.github.com/repos/garydamm/ios-gimbal-adapter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/garydamm/ios-gimbal-adapter/labels{/name}","releases_url":"https://api.github.com/repos/garydamm/ios-gimbal-adapter/releases{/id}","deployments_url":"https://api.github.com/repos/garydamm/ios-gimbal-adapter/deployments","created_at":"2017-05-18T17:42:59Z","updated_at":"2017-05-18T17:43:01Z","pushed_at":"2017-05-18T17:49:28Z","git_url":"git://github.com/garydamm/ios-gimbal-adapter.git","ssh_url":"git@github.com:garydamm/ios-gimbal-adapter.git","clone_url":"https://github.com/garydamm/ios-gimbal-adapter.git","svn_url":"https://github.com/garydamm/ios-gimbal-adapter","homepage":null,"size":13,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"urbanairship:master","ref":"master","sha":"1c7db86946b05d93539ea0c9ea15824601e3d8ef","user":{"login":"urbanairship","id":360059,"avatar_url":"https://avatars3.githubusercontent.com/u/360059?v=3","gravatar_id":"","url":"https://api.github.com/users/urbanairship","html_url":"https://github.com/urbanairship","followers_url":"https://api.github.com/users/urbanairship/followers","following_url":"https://api.github.com/users/urbanairship/following{/other_user}","gists_url":"https://api.github.com/users/urbanairship/gists{/gist_id}","starred_url":"https://api.github.com/users/urbanairship/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/urbanairship/subscriptions","organizations_url":"https://api.github.com/users/urbanairship/orgs","repos_url":"https://api.github.com/users/urbanairship/repos","events_url":"https://api.github.com/users/urbanairship/events{/privacy}","received_events_url":"https://api.github.com/users/urbanairship/received_events","type":"Organization","site_admin":false},"repo":{"id":73975441,"name":"ios-gimbal-adapter","full_name":"urbanairship/ios-gimbal-adapter","owner":{"login":"urbanairship","id":360059,"avatar_url":"https://avatars3.githubusercontent.com/u/360059?v=3","gravatar_id":"","url":"https://api.github.com/users/urbanairship","html_url":"https://github.com/urbanairship","followers_url":"https://api.github.com/users/urbanairship/followers","following_url":"https://api.github.com/users/urbanairship/following{/other_user}","gists_url":"https://api.github.com/users/urbanairship/gists{/gist_id}","starred_url":"https://api.github.com/users/urbanairship/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/urbanairship/subscriptions","organizations_url":"https://api.github.com/users/urbanairship/orgs","repos_url":"https://api.github.com/users/urbanairship/repos","events_url":"https://api.github.com/users/urbanairship/events{/privacy}","received_events_url":"https://api.github.com/users/urbanairship/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/urbanairship/ios-gimbal-adapter","description":"The iOS Gimbal adapter for Urban Airship","fork":false,"url":"https://api.github.com/repos/urbanairship/ios-gimbal-adapter","forks_url":"https://api.github.com/repos/urbanairship/ios-gimbal-adapter/forks","keys_url":"https://api.github.com/repos/urbanairship/ios-gimbal-adapter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/urbanairship/ios-gimbal-adapter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/urbanairship/ios-gimbal-adapter/teams","hooks_url":"https://api.github.com/repos/urbanairship/ios-gimbal-adapter/hooks","issue_events_url":"https://api.github.com/repos/urbanairship/ios-gimbal-adapter/issues/events{/number}","events_url":"https://api.github.com/repos/urbanairship/ios-gimbal-adapter/events","assignees_url":"https://api.github.com/repos/urbanairship/ios-gimbal-adapter/assignees{/user}","branches_url":"https://api.github.com/repos/urbanairship/ios-gimbal-adapter/branches{/branch}","tags_url":"https://api.github.com/repos/urbanairship/ios-gimbal-adapter/tags","blobs_url":"https://api.github.com/repos/urbanairship/ios-gimbal-adapter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/urbanairship/ios-gimbal-adapter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/urbanairship/ios-gimbal-adapter/git/refs{/sha}","trees_url":"https://api.github.com/repos/urbanairship/ios-gimbal-adapter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/urbanairship/ios-gimbal-adapter/statuses/{sha}","languages_url":"https://api.github.com/repos/urbanairship/ios-gimbal-adapter/languages","stargazers_url":"https://api.github.com/repos/urbanairship/ios-gimbal-adapter/stargazers","contributors_url":"https://api.github.com/repos/urbanairship/ios-gimbal-adapter/contributors","subscribers_url":"https://api.github.com/repos/urbanairship/ios-gimbal-adapter/subscribers","subscription_url":"https://api.github.com/repos/urbanairship/ios-gimbal-adapter/subscription","commits_url":"https://api.github.com/repos/urbanairship/ios-gimbal-adapter/commits{/sha}","git_commits_url":"https://api.github.com/repos/urbanairship/ios-gimbal-adapter/git/commits{/sha}","comments_url":"https://api.github.com/repos/urbanairship/ios-gimbal-adapter/comments{/number}","issue_comment_url":"https://api.github.com/repos/urbanairship/ios-gimbal-adapter/issues/comments{/number}","contents_url":"https://api.github.com/repos/urbanairship/ios-gimbal-adapter/contents/{+path}","compare_url":"https://api.github.com/repos/urbanairship/ios-gimbal-adapter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/urbanairship/ios-gimbal-adapter/merges","archive_url":"https://api.github.com/repos/urbanairship/ios-gimbal-adapter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/urbanairship/ios-gimbal-adapter/downloads","issues_url":"https://api.github.com/repos/urbanairship/ios-gimbal-adapter/issues{/number}","pulls_url":"https://api.github.com/repos/urbanairship/ios-gimbal-adapter/pulls{/number}","milestones_url":"https://api.github.com/repos/urbanairship/ios-gimbal-adapter/milestones{/number}","notifications_url":"https://api.github.com/repos/urbanairship/ios-gimbal-adapter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/urbanairship/ios-gimbal-adapter/labels{/name}","releases_url":"https://api.github.com/repos/urbanairship/ios-gimbal-adapter/releases{/id}","deployments_url":"https://api.github.com/repos/urbanairship/ios-gimbal-adapter/deployments","created_at":"2016-11-17T00:53:40Z","updated_at":"2017-02-21T18:58:28Z","pushed_at":"2017-05-18T17:50:09Z","git_url":"git://github.com/urbanairship/ios-gimbal-adapter.git","ssh_url":"git@github.com:urbanairship/ios-gimbal-adapter.git","clone_url":"https://github.com/urbanairship/ios-gimbal-adapter.git","svn_url":"https://github.com/urbanairship/ios-gimbal-adapter","homepage":null,"size":11,"stargazers_count":1,"watchers_count":1,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/urbanairship/ios-gimbal-adapter/pulls/2"},"html":{"href":"https://github.com/urbanairship/ios-gimbal-adapter/pull/2"},"issue":{"href":"https://api.github.com/repos/urbanairship/ios-gimbal-adapter/issues/2"},"comments":{"href":"https://api.github.com/repos/urbanairship/ios-gimbal-adapter/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/urbanairship/ios-gimbal-adapter/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/urbanairship/ios-gimbal-adapter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/urbanairship/ios-gimbal-adapter/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/urbanairship/ios-gimbal-adapter/statuses/f3d3ce96dffd6f39d31d2b4238e48bfefe218fc2"}}}}
{"actor":{"display_login":"rlepinski"}}