{"action":"created","comment":{"url":"https://api.github.com/repos/z3t0/Arduino-IRremote/pulls/comments/109278039","pull_request_review_id":30375052,"id":109278039,"diff_hunk":"@@ -120,7 +123,11 @@ int  MATCH_SPACE (int measured_ticks,  int desired_us)\n // As soon as first MARK arrives:\n //   Gap width is recorded; Ready is cleared; New logging starts\n //\n+#ifdef IR_TIMER_USE_ESP32","path":"IRremote.cpp","position":24,"original_position":24,"commit_id":"ffdb6081ae3e91d9afb413e8412633f552a0df6a","original_commit_id":"ffdb6081ae3e91d9afb413e8412633f552a0df6a","user":{"login":"z3t0","id":9000061,"avatar_url":"https://avatars0.githubusercontent.com/u/9000061?v=3","gravatar_id":"","url":"https://api.github.com/users/z3t0","html_url":"https://github.com/z3t0","followers_url":"https://api.github.com/users/z3t0/followers","following_url":"https://api.github.com/users/z3t0/following{/other_user}","gists_url":"https://api.github.com/users/z3t0/gists{/gist_id}","starred_url":"https://api.github.com/users/z3t0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/z3t0/subscriptions","organizations_url":"https://api.github.com/users/z3t0/orgs","repos_url":"https://api.github.com/users/z3t0/repos","events_url":"https://api.github.com/users/z3t0/events{/privacy}","received_events_url":"https://api.github.com/users/z3t0/received_events","type":"User","site_admin":false},"body":"I'm not too keen on having a separate function just for the ESP32 and would again prefer macros dealing with this its much cleaner by ensuring that the only file that deals with the hardware differences is boarddefs.h \r\n\r\nThough I am open to doing it this way as well, @bengtmartensson thoughts?","created_at":"2017-04-01T05:18:43Z","updated_at":"2017-04-01T05:22:12Z","html_url":"https://github.com/z3t0/Arduino-IRremote/pull/425#discussion_r109278039","pull_request_url":"https://api.github.com/repos/z3t0/Arduino-IRremote/pulls/425","_links":{"self":{"href":"https://api.github.com/repos/z3t0/Arduino-IRremote/pulls/comments/109278039"},"html":{"href":"https://github.com/z3t0/Arduino-IRremote/pull/425#discussion_r109278039"},"pull_request":{"href":"https://api.github.com/repos/z3t0/Arduino-IRremote/pulls/425"}}},"pull_request":{"url":"https://api.github.com/repos/z3t0/Arduino-IRremote/pulls/425","id":111485052,"html_url":"https://github.com/z3t0/Arduino-IRremote/pull/425","diff_url":"https://github.com/z3t0/Arduino-IRremote/pull/425.diff","patch_url":"https://github.com/z3t0/Arduino-IRremote/pull/425.patch","issue_url":"https://api.github.com/repos/z3t0/Arduino-IRremote/issues/425","number":425,"state":"open","locked":false,"title":"Added ESP32 IR receive support (IRsend not implemented yet).","user":{"login":"marcmerlin","id":1369412,"avatar_url":"https://avatars0.githubusercontent.com/u/1369412?v=3","gravatar_id":"","url":"https://api.github.com/users/marcmerlin","html_url":"https://github.com/marcmerlin","followers_url":"https://api.github.com/users/marcmerlin/followers","following_url":"https://api.github.com/users/marcmerlin/following{/other_user}","gists_url":"https://api.github.com/users/marcmerlin/gists{/gist_id}","starred_url":"https://api.github.com/users/marcmerlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcmerlin/subscriptions","organizations_url":"https://api.github.com/users/marcmerlin/orgs","repos_url":"https://api.github.com/users/marcmerlin/repos","events_url":"https://api.github.com/users/marcmerlin/events{/privacy}","received_events_url":"https://api.github.com/users/marcmerlin/received_events","type":"User","site_admin":false},"body":"- disable a lot of defines not relevant to ESP32, set them to 1 (no-op)\r\n- change default IR pin to 35 from 11\r\n- changed serial speed to 115200 (9600 is too slow to keep up with IR input)\r\n- irSend disables code that will not compile on ESP32. It won't work,\r\n  but it won't break compilation either.","created_at":"2017-03-20T03:32:50Z","updated_at":"2017-04-01T05:22:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"097cb7fd9183b7da33480b3dd45c66aed9aeaa91","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/z3t0/Arduino-IRremote/pulls/425/commits","review_comments_url":"https://api.github.com/repos/z3t0/Arduino-IRremote/pulls/425/comments","review_comment_url":"https://api.github.com/repos/z3t0/Arduino-IRremote/pulls/comments{/number}","comments_url":"https://api.github.com/repos/z3t0/Arduino-IRremote/issues/425/comments","statuses_url":"https://api.github.com/repos/z3t0/Arduino-IRremote/statuses/ffdb6081ae3e91d9afb413e8412633f552a0df6a","head":{"label":"marcmerlin:master","ref":"master","sha":"ffdb6081ae3e91d9afb413e8412633f552a0df6a","user":{"login":"marcmerlin","id":1369412,"avatar_url":"https://avatars0.githubusercontent.com/u/1369412?v=3","gravatar_id":"","url":"https://api.github.com/users/marcmerlin","html_url":"https://github.com/marcmerlin","followers_url":"https://api.github.com/users/marcmerlin/followers","following_url":"https://api.github.com/users/marcmerlin/following{/other_user}","gists_url":"https://api.github.com/users/marcmerlin/gists{/gist_id}","starred_url":"https://api.github.com/users/marcmerlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcmerlin/subscriptions","organizations_url":"https://api.github.com/users/marcmerlin/orgs","repos_url":"https://api.github.com/users/marcmerlin/repos","events_url":"https://api.github.com/users/marcmerlin/events{/privacy}","received_events_url":"https://api.github.com/users/marcmerlin/received_events","type":"User","site_admin":false},"repo":{"id":85530630,"name":"Arduino-IRremote","full_name":"marcmerlin/Arduino-IRremote","owner":{"login":"marcmerlin","id":1369412,"avatar_url":"https://avatars0.githubusercontent.com/u/1369412?v=3","gravatar_id":"","url":"https://api.github.com/users/marcmerlin","html_url":"https://github.com/marcmerlin","followers_url":"https://api.github.com/users/marcmerlin/followers","following_url":"https://api.github.com/users/marcmerlin/following{/other_user}","gists_url":"https://api.github.com/users/marcmerlin/gists{/gist_id}","starred_url":"https://api.github.com/users/marcmerlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcmerlin/subscriptions","organizations_url":"https://api.github.com/users/marcmerlin/orgs","repos_url":"https://api.github.com/users/marcmerlin/repos","events_url":"https://api.github.com/users/marcmerlin/events{/privacy}","received_events_url":"https://api.github.com/users/marcmerlin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/marcmerlin/Arduino-IRremote","description":"Infrared remote library for Arduino: send and receive infrared signals with multiple protocols","fork":true,"url":"https://api.github.com/repos/marcmerlin/Arduino-IRremote","forks_url":"https://api.github.com/repos/marcmerlin/Arduino-IRremote/forks","keys_url":"https://api.github.com/repos/marcmerlin/Arduino-IRremote/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marcmerlin/Arduino-IRremote/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marcmerlin/Arduino-IRremote/teams","hooks_url":"https://api.github.com/repos/marcmerlin/Arduino-IRremote/hooks","issue_events_url":"https://api.github.com/repos/marcmerlin/Arduino-IRremote/issues/events{/number}","events_url":"https://api.github.com/repos/marcmerlin/Arduino-IRremote/events","assignees_url":"https://api.github.com/repos/marcmerlin/Arduino-IRremote/assignees{/user}","branches_url":"https://api.github.com/repos/marcmerlin/Arduino-IRremote/branches{/branch}","tags_url":"https://api.github.com/repos/marcmerlin/Arduino-IRremote/tags","blobs_url":"https://api.github.com/repos/marcmerlin/Arduino-IRremote/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marcmerlin/Arduino-IRremote/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marcmerlin/Arduino-IRremote/git/refs{/sha}","trees_url":"https://api.github.com/repos/marcmerlin/Arduino-IRremote/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marcmerlin/Arduino-IRremote/statuses/{sha}","languages_url":"https://api.github.com/repos/marcmerlin/Arduino-IRremote/languages","stargazers_url":"https://api.github.com/repos/marcmerlin/Arduino-IRremote/stargazers","contributors_url":"https://api.github.com/repos/marcmerlin/Arduino-IRremote/contributors","subscribers_url":"https://api.github.com/repos/marcmerlin/Arduino-IRremote/subscribers","subscription_url":"https://api.github.com/repos/marcmerlin/Arduino-IRremote/subscription","commits_url":"https://api.github.com/repos/marcmerlin/Arduino-IRremote/commits{/sha}","git_commits_url":"https://api.github.com/repos/marcmerlin/Arduino-IRremote/git/commits{/sha}","comments_url":"https://api.github.com/repos/marcmerlin/Arduino-IRremote/comments{/number}","issue_comment_url":"https://api.github.com/repos/marcmerlin/Arduino-IRremote/issues/comments{/number}","contents_url":"https://api.github.com/repos/marcmerlin/Arduino-IRremote/contents/{+path}","compare_url":"https://api.github.com/repos/marcmerlin/Arduino-IRremote/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marcmerlin/Arduino-IRremote/merges","archive_url":"https://api.github.com/repos/marcmerlin/Arduino-IRremote/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marcmerlin/Arduino-IRremote/downloads","issues_url":"https://api.github.com/repos/marcmerlin/Arduino-IRremote/issues{/number}","pulls_url":"https://api.github.com/repos/marcmerlin/Arduino-IRremote/pulls{/number}","milestones_url":"https://api.github.com/repos/marcmerlin/Arduino-IRremote/milestones{/number}","notifications_url":"https://api.github.com/repos/marcmerlin/Arduino-IRremote/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marcmerlin/Arduino-IRremote/labels{/name}","releases_url":"https://api.github.com/repos/marcmerlin/Arduino-IRremote/releases{/id}","deployments_url":"https://api.github.com/repos/marcmerlin/Arduino-IRremote/deployments","created_at":"2017-03-20T03:14:46Z","updated_at":"2017-03-20T03:14:48Z","pushed_at":"2017-04-01T05:04:36Z","git_url":"git://github.com/marcmerlin/Arduino-IRremote.git","ssh_url":"git@github.com:marcmerlin/Arduino-IRremote.git","clone_url":"https://github.com/marcmerlin/Arduino-IRremote.git","svn_url":"https://github.com/marcmerlin/Arduino-IRremote","homepage":"http://z3t0.github.io/Arduino-IRremote/","size":849,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"z3t0:master","ref":"master","sha":"513e1045157357adb5eb0e7bcc65795365b72898","user":{"login":"z3t0","id":9000061,"avatar_url":"https://avatars0.githubusercontent.com/u/9000061?v=3","gravatar_id":"","url":"https://api.github.com/users/z3t0","html_url":"https://github.com/z3t0","followers_url":"https://api.github.com/users/z3t0/followers","following_url":"https://api.github.com/users/z3t0/following{/other_user}","gists_url":"https://api.github.com/users/z3t0/gists{/gist_id}","starred_url":"https://api.github.com/users/z3t0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/z3t0/subscriptions","organizations_url":"https://api.github.com/users/z3t0/orgs","repos_url":"https://api.github.com/users/z3t0/repos","events_url":"https://api.github.com/users/z3t0/events{/privacy}","received_events_url":"https://api.github.com/users/z3t0/received_events","type":"User","site_admin":false},"repo":{"id":484788,"name":"Arduino-IRremote","full_name":"z3t0/Arduino-IRremote","owner":{"login":"z3t0","id":9000061,"avatar_url":"https://avatars0.githubusercontent.com/u/9000061?v=3","gravatar_id":"","url":"https://api.github.com/users/z3t0","html_url":"https://github.com/z3t0","followers_url":"https://api.github.com/users/z3t0/followers","following_url":"https://api.github.com/users/z3t0/following{/other_user}","gists_url":"https://api.github.com/users/z3t0/gists{/gist_id}","starred_url":"https://api.github.com/users/z3t0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/z3t0/subscriptions","organizations_url":"https://api.github.com/users/z3t0/orgs","repos_url":"https://api.github.com/users/z3t0/repos","events_url":"https://api.github.com/users/z3t0/events{/privacy}","received_events_url":"https://api.github.com/users/z3t0/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/z3t0/Arduino-IRremote","description":"Infrared remote library for Arduino: send and receive infrared signals with multiple protocols","fork":false,"url":"https://api.github.com/repos/z3t0/Arduino-IRremote","forks_url":"https://api.github.com/repos/z3t0/Arduino-IRremote/forks","keys_url":"https://api.github.com/repos/z3t0/Arduino-IRremote/keys{/key_id}","collaborators_url":"https://api.github.com/repos/z3t0/Arduino-IRremote/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/z3t0/Arduino-IRremote/teams","hooks_url":"https://api.github.com/repos/z3t0/Arduino-IRremote/hooks","issue_events_url":"https://api.github.com/repos/z3t0/Arduino-IRremote/issues/events{/number}","events_url":"https://api.github.com/repos/z3t0/Arduino-IRremote/events","assignees_url":"https://api.github.com/repos/z3t0/Arduino-IRremote/assignees{/user}","branches_url":"https://api.github.com/repos/z3t0/Arduino-IRremote/branches{/branch}","tags_url":"https://api.github.com/repos/z3t0/Arduino-IRremote/tags","blobs_url":"https://api.github.com/repos/z3t0/Arduino-IRremote/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/z3t0/Arduino-IRremote/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/z3t0/Arduino-IRremote/git/refs{/sha}","trees_url":"https://api.github.com/repos/z3t0/Arduino-IRremote/git/trees{/sha}","statuses_url":"https://api.github.com/repos/z3t0/Arduino-IRremote/statuses/{sha}","languages_url":"https://api.github.com/repos/z3t0/Arduino-IRremote/languages","stargazers_url":"https://api.github.com/repos/z3t0/Arduino-IRremote/stargazers","contributors_url":"https://api.github.com/repos/z3t0/Arduino-IRremote/contributors","subscribers_url":"https://api.github.com/repos/z3t0/Arduino-IRremote/subscribers","subscription_url":"https://api.github.com/repos/z3t0/Arduino-IRremote/subscription","commits_url":"https://api.github.com/repos/z3t0/Arduino-IRremote/commits{/sha}","git_commits_url":"https://api.github.com/repos/z3t0/Arduino-IRremote/git/commits{/sha}","comments_url":"https://api.github.com/repos/z3t0/Arduino-IRremote/comments{/number}","issue_comment_url":"https://api.github.com/repos/z3t0/Arduino-IRremote/issues/comments{/number}","contents_url":"https://api.github.com/repos/z3t0/Arduino-IRremote/contents/{+path}","compare_url":"https://api.github.com/repos/z3t0/Arduino-IRremote/compare/{base}...{head}","merges_url":"https://api.github.com/repos/z3t0/Arduino-IRremote/merges","archive_url":"https://api.github.com/repos/z3t0/Arduino-IRremote/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/z3t0/Arduino-IRremote/downloads","issues_url":"https://api.github.com/repos/z3t0/Arduino-IRremote/issues{/number}","pulls_url":"https://api.github.com/repos/z3t0/Arduino-IRremote/pulls{/number}","milestones_url":"https://api.github.com/repos/z3t0/Arduino-IRremote/milestones{/number}","notifications_url":"https://api.github.com/repos/z3t0/Arduino-IRremote/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/z3t0/Arduino-IRremote/labels{/name}","releases_url":"https://api.github.com/repos/z3t0/Arduino-IRremote/releases{/id}","deployments_url":"https://api.github.com/repos/z3t0/Arduino-IRremote/deployments","created_at":"2010-01-23T04:37:22Z","updated_at":"2017-04-01T04:30:29Z","pushed_at":"2017-04-01T05:04:37Z","git_url":"git://github.com/z3t0/Arduino-IRremote.git","ssh_url":"git@github.com:z3t0/Arduino-IRremote.git","clone_url":"https://github.com/z3t0/Arduino-IRremote.git","svn_url":"https://github.com/z3t0/Arduino-IRremote","homepage":"http://z3t0.github.io/Arduino-IRremote/","size":851,"stargazers_count":1705,"watchers_count":1705,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":903,"mirror_url":null,"open_issues_count":143,"forks":903,"open_issues":143,"watchers":1705,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/z3t0/Arduino-IRremote/pulls/425"},"html":{"href":"https://github.com/z3t0/Arduino-IRremote/pull/425"},"issue":{"href":"https://api.github.com/repos/z3t0/Arduino-IRremote/issues/425"},"comments":{"href":"https://api.github.com/repos/z3t0/Arduino-IRremote/issues/425/comments"},"review_comments":{"href":"https://api.github.com/repos/z3t0/Arduino-IRremote/pulls/425/comments"},"review_comment":{"href":"https://api.github.com/repos/z3t0/Arduino-IRremote/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/z3t0/Arduino-IRremote/pulls/425/commits"},"statuses":{"href":"https://api.github.com/repos/z3t0/Arduino-IRremote/statuses/ffdb6081ae3e91d9afb413e8412633f552a0df6a"}}}}
{"actor":{"display_login":"z3t0"}}