{"action":"created","issue":{"url":"https://api.github.com/repos/apple/swift/issues/12005","repository_url":"https://api.github.com/repos/apple/swift","labels_url":"https://api.github.com/repos/apple/swift/issues/12005/labels{/name}","comments_url":"https://api.github.com/repos/apple/swift/issues/12005/comments","events_url":"https://api.github.com/repos/apple/swift/issues/12005/events","html_url":"https://github.com/apple/swift/pull/12005","id":258943193,"number":12005,"title":"Fix flipped argument state","user":{"login":"Rostepher","id":862492,"avatar_url":"https://avatars3.githubusercontent.com/u/862492?v=4","gravatar_id":"","url":"https://api.github.com/users/Rostepher","html_url":"https://github.com/Rostepher","followers_url":"https://api.github.com/users/Rostepher/followers","following_url":"https://api.github.com/users/Rostepher/following{/other_user}","gists_url":"https://api.github.com/users/Rostepher/gists{/gist_id}","starred_url":"https://api.github.com/users/Rostepher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rostepher/subscriptions","organizations_url":"https://api.github.com/users/Rostepher/orgs","repos_url":"https://api.github.com/users/Rostepher/repos","events_url":"https://api.github.com/users/Rostepher/events{/privacy}","received_events_url":"https://api.github.com/users/Rostepher/received_events","type":"User","site_admin":false},"labels":[{"id":277147936,"url":"https://api.github.com/repos/apple/swift/labels/bug","name":"bug","color":"fc2929","default":true},{"id":277147938,"url":"https://api.github.com/repos/apple/swift/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2017-09-19T19:51:48Z","updated_at":"2017-09-19T21:35:32Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/12005","html_url":"https://github.com/apple/swift/pull/12005","diff_url":"https://github.com/apple/swift/pull/12005.diff","patch_url":"https://github.com/apple/swift/pull/12005.patch"},"body":"# Purpose\r\n\r\nThis PR resolves issue [SR-5911](https://bugs.swift.org/browse/SR-5911). My previous PR #11952 changed the internal 'destinations' for all the `--skip-build-*` and `--skip-test-*` flags from the form `skip_build_*` and `skip_test_*` to the affirmative `build_*` and `test_*`. When swapping those states I failed to account for the more advanced optional boolean behavior on each of these skip flags. It is possible for many flags to accept an optional boolean state to toggle them on or off manually, with skip flags it can be rather confusing since `--skip-build-benchmarks True` means that we should not build benchmarks. Before this fix the optional boolean was being directly set on these new inverted destinations, thus `--skip-build-benchmarks True` was setting the destination `build_benchmarks` to `True` rather than the expected `False`.\r\n\r\nIn addition to fixing the erroneous behavior I've also taken the liberty to revamp the testing suite again making a more clear distinction between flags that accept optional booleans, those that only toggle the state `True` or `False` and those that store constant values. The test suite now covers all these cases and has more strict testing for their edge cases.\r\n\r\nA small note for reviewers, there's a lot of noise in the testing suite dealing with parsing arguments. To accurately test that each flag accepts the expected argument values and acts accordingly it was necessary to be able to parse flags without applying the defaults. Thus there's now the methods `parse_args` and `parse_default_args` on the main test case class.\r\n\r\nrdar://34526897"},"comment":{"url":"https://api.github.com/repos/apple/swift/issues/comments/330680631","html_url":"https://github.com/apple/swift/pull/12005#issuecomment-330680631","issue_url":"https://api.github.com/repos/apple/swift/issues/12005","id":330680631,"user":{"login":"gottesmm","id":499423,"avatar_url":"https://avatars1.githubusercontent.com/u/499423?v=4","gravatar_id":"","url":"https://api.github.com/users/gottesmm","html_url":"https://github.com/gottesmm","followers_url":"https://api.github.com/users/gottesmm/followers","following_url":"https://api.github.com/users/gottesmm/following{/other_user}","gists_url":"https://api.github.com/users/gottesmm/gists{/gist_id}","starred_url":"https://api.github.com/users/gottesmm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gottesmm/subscriptions","organizations_url":"https://api.github.com/users/gottesmm/orgs","repos_url":"https://api.github.com/users/gottesmm/repos","events_url":"https://api.github.com/users/gottesmm/events{/privacy}","received_events_url":"https://api.github.com/users/gottesmm/received_events","type":"User","site_admin":false},"created_at":"2017-09-19T21:35:32Z","updated_at":"2017-09-19T21:35:32Z","author_association":"MEMBER","body":"@Rostepher give me a little bit. I am in some meetings today = (."}}
{"actor":{"display_login":"gottesmm"}}