{"action":"created","comment":{"url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/pulls/comments/138184876","pull_request_review_id":61948551,"id":138184876,"diff_hunk":"@@ -249,49 +249,61 @@\n             modalClasses() {\n                 return [\n                     'modal',\n-                    this.noFade ? '' : 'fade',\n-                    this.is_show ? 'show' : '',\n-                    this.is_block ? 'd-block' : ''\n+                    {\n+                        fade: !this.noFade,\n+                        show: this.is_show,\n+                        'd-block': this.is_block\n+                    }\n                 ];\n             },\n             dialogClasses() {\n                 return [\n                     'modal-dialog',\n-                    Boolean(this.size) ? `modal-${this.size}` : ''\n+                    {\n+                        [`modal-${this.size}`]: this.size\n+                    }\n                 ];\n             },\n             backdropClasses() {\n                 return [\n                     'modal-backdrop',\n-                    this.noFade ? '' : 'fade',\n-                    this.is_show ? 'show' : ''\n+                    {\n+                        fade: !this.noFade,\n+                        show: this.is_show,\n+                    }\n                 ];\n             },\n             headerClasses() {\n                 return [\n                     'modal-header',\n                     // Rounding is needed to fix a bug in bootstrap V4.beta.1 CSS\n-                    Boolean(this.headerBgVariant) ? 'rounded-top' : '',\n-                    Boolean(this.headerBgVariant) ? `bg-${this.headerBgVariant}` : '',\n-                    Boolean(this.headerTextVariant) ? `text-${this.headerTextVariant}` : '',\n-                    Boolean(this.headerBorderVariant) ? `border-${this.headerBorderVariant}` : ''\n+                    {\n+                        'rounded-top': this.headerBgVariant,\n+                        [`bg-${this.headerBgVariant}`]: this.headerBgVariant,\n+                        [`text-${this.headerTextVariant}`]: this.headerTextVariant,\n+                        [`border-${this.headerBorderVariant}`]: this.headerBorderVariant,","path":"lib/components/modal.vue","position":319,"original_position":46,"commit_id":"e86c21c319fb47d3cd6f67bd43a31d172f435970","original_commit_id":"e86c21c319fb47d3cd6f67bd43a31d172f435970","user":{"login":"tmorehouse","id":2781561,"avatar_url":"https://avatars3.githubusercontent.com/u/2781561?v=4","gravatar_id":"","url":"https://api.github.com/users/tmorehouse","html_url":"https://github.com/tmorehouse","followers_url":"https://api.github.com/users/tmorehouse/followers","following_url":"https://api.github.com/users/tmorehouse/following{/other_user}","gists_url":"https://api.github.com/users/tmorehouse/gists{/gist_id}","starred_url":"https://api.github.com/users/tmorehouse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmorehouse/subscriptions","organizations_url":"https://api.github.com/users/tmorehouse/orgs","repos_url":"https://api.github.com/users/tmorehouse/repos","events_url":"https://api.github.com/users/tmorehouse/events{/privacy}","received_events_url":"https://api.github.com/users/tmorehouse/received_events","type":"User","site_admin":false},"body":"And similar for the other classes sections as well...","created_at":"2017-09-11T20:40:05Z","updated_at":"2017-09-11T20:40:05Z","html_url":"https://github.com/bootstrap-vue/bootstrap-vue/pull/1024#discussion_r138184876","pull_request_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/pulls/1024","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/pulls/comments/138184876"},"html":{"href":"https://github.com/bootstrap-vue/bootstrap-vue/pull/1024#discussion_r138184876"},"pull_request":{"href":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/pulls/1024"}},"in_reply_to_id":138183375},"pull_request":{"url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/pulls/1024","id":140191975,"html_url":"https://github.com/bootstrap-vue/bootstrap-vue/pull/1024","diff_url":"https://github.com/bootstrap-vue/bootstrap-vue/pull/1024.diff","patch_url":"https://github.com/bootstrap-vue/bootstrap-vue/pull/1024.patch","issue_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/issues/1024","number":1024,"state":"open","locked":false,"title":"feat(modal): Improve modal transitions, padding adjustments, and aditional features","user":{"login":"tmorehouse","id":2781561,"avatar_url":"https://avatars3.githubusercontent.com/u/2781561?v=4","gravatar_id":"","url":"https://api.github.com/users/tmorehouse","html_url":"https://github.com/tmorehouse","followers_url":"https://api.github.com/users/tmorehouse/followers","following_url":"https://api.github.com/users/tmorehouse/following{/other_user}","gists_url":"https://api.github.com/users/tmorehouse/gists{/gist_id}","starred_url":"https://api.github.com/users/tmorehouse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmorehouse/subscriptions","organizations_url":"https://api.github.com/users/tmorehouse/orgs","repos_url":"https://api.github.com/users/tmorehouse/repos","events_url":"https://api.github.com/users/tmorehouse/events{/privacy}","received_events_url":"https://api.github.com/users/tmorehouse/received_events","type":"User","site_admin":false},"body":"Various modal improvements:\r\n\r\n- [x] Improve modal transitions.\r\n- [x] Remove need for scoped CSS.\r\n- [x] Incorporate `BvEvent` object in modal events (`hide`, `hidden`, `show`, `shown`).\r\n- [x] Incorporate scrollbar adjustments.\r\n- [x] Add listeners for resize/orientationchange to adjust modal padding if necessary\r\n- [x] Use observeDom util to adjust modal when content size changes.\r\n- [x] Option to not show backdrop (although still supports close on backdrop click, when backdrop not shown).\r\n- [x] Emit on `$root` new namespaced events.\r\n- [x] Listen on `$root` new namedspaced events (**Minor breaking change**).\r\n- [x] Update `v-b-modal` directive to use new namespaced `$root` event.\r\n- [x] Add optional bg, border, and text variants (header, footer, body).\r\n_Note: current Bootstrap V4.beta.1 CSS causes header and footer to loose rounded corners when a background variant is applied. This PR includes a fix for that using the `rounded-*` classes_\r\n- [x] New functional component `<b-button-close>` for header close button (also added to `<b-alert>`).\r\n- [x] New slot for header-close button content\r\n- [x] More dom utils for better minification (used by modal and tooltips/popovers).\r\n- [x] Auto append tooltip/popovers to `.modal` `<div>` (instead of `<body>`) for proper z-indexing, if container not specified on tooltip/popover (check is done within tooltip.js class)\r\n- [x] Update docs & examples.\r\n","created_at":"2017-09-10T02:10:19Z","updated_at":"2017-09-11T20:40:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bb065ce6e58051d11e4059a6d0c117fff8b46b7a","assignee":null,"assignees":[],"requested_reviewers":[{"login":"pi0","id":5158436,"avatar_url":"https://avatars0.githubusercontent.com/u/5158436?v=4","gravatar_id":"","url":"https://api.github.com/users/pi0","html_url":"https://github.com/pi0","followers_url":"https://api.github.com/users/pi0/followers","following_url":"https://api.github.com/users/pi0/following{/other_user}","gists_url":"https://api.github.com/users/pi0/gists{/gist_id}","starred_url":"https://api.github.com/users/pi0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pi0/subscriptions","organizations_url":"https://api.github.com/users/pi0/orgs","repos_url":"https://api.github.com/users/pi0/repos","events_url":"https://api.github.com/users/pi0/events{/privacy}","received_events_url":"https://api.github.com/users/pi0/received_events","type":"User","site_admin":false},{"login":"mosinve","id":20986566,"avatar_url":"https://avatars0.githubusercontent.com/u/20986566?v=4","gravatar_id":"","url":"https://api.github.com/users/mosinve","html_url":"https://github.com/mosinve","followers_url":"https://api.github.com/users/mosinve/followers","following_url":"https://api.github.com/users/mosinve/following{/other_user}","gists_url":"https://api.github.com/users/mosinve/gists{/gist_id}","starred_url":"https://api.github.com/users/mosinve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mosinve/subscriptions","organizations_url":"https://api.github.com/users/mosinve/orgs","repos_url":"https://api.github.com/users/mosinve/repos","events_url":"https://api.github.com/users/mosinve/events{/privacy}","received_events_url":"https://api.github.com/users/mosinve/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/pulls/1024/commits","review_comments_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/pulls/1024/comments","review_comment_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/issues/1024/comments","statuses_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/statuses/e86c21c319fb47d3cd6f67bd43a31d172f435970","head":{"label":"bootstrap-vue:remodalling/1.x","ref":"remodalling/1.x","sha":"e86c21c319fb47d3cd6f67bd43a31d172f435970","user":{"login":"bootstrap-vue","id":22965283,"avatar_url":"https://avatars2.githubusercontent.com/u/22965283?v=4","gravatar_id":"","url":"https://api.github.com/users/bootstrap-vue","html_url":"https://github.com/bootstrap-vue","followers_url":"https://api.github.com/users/bootstrap-vue/followers","following_url":"https://api.github.com/users/bootstrap-vue/following{/other_user}","gists_url":"https://api.github.com/users/bootstrap-vue/gists{/gist_id}","starred_url":"https://api.github.com/users/bootstrap-vue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bootstrap-vue/subscriptions","organizations_url":"https://api.github.com/users/bootstrap-vue/orgs","repos_url":"https://api.github.com/users/bootstrap-vue/repos","events_url":"https://api.github.com/users/bootstrap-vue/events{/privacy}","received_events_url":"https://api.github.com/users/bootstrap-vue/received_events","type":"Organization","site_admin":false},"repo":{"id":70342215,"name":"bootstrap-vue","full_name":"bootstrap-vue/bootstrap-vue","owner":{"login":"bootstrap-vue","id":22965283,"avatar_url":"https://avatars2.githubusercontent.com/u/22965283?v=4","gravatar_id":"","url":"https://api.github.com/users/bootstrap-vue","html_url":"https://github.com/bootstrap-vue","followers_url":"https://api.github.com/users/bootstrap-vue/followers","following_url":"https://api.github.com/users/bootstrap-vue/following{/other_user}","gists_url":"https://api.github.com/users/bootstrap-vue/gists{/gist_id}","starred_url":"https://api.github.com/users/bootstrap-vue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bootstrap-vue/subscriptions","organizations_url":"https://api.github.com/users/bootstrap-vue/orgs","repos_url":"https://api.github.com/users/bootstrap-vue/repos","events_url":"https://api.github.com/users/bootstrap-vue/events{/privacy}","received_events_url":"https://api.github.com/users/bootstrap-vue/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bootstrap-vue/bootstrap-vue","description":"Quickly integrate Bootstrap 4 Components with Vue.js.","fork":false,"url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue","forks_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/forks","keys_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/teams","hooks_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/hooks","issue_events_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/issues/events{/number}","events_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/events","assignees_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/assignees{/user}","branches_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/branches{/branch}","tags_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/tags","blobs_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/git/refs{/sha}","trees_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/statuses/{sha}","languages_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/languages","stargazers_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/stargazers","contributors_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/contributors","subscribers_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/subscribers","subscription_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/subscription","commits_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/commits{/sha}","git_commits_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/git/commits{/sha}","comments_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/comments{/number}","issue_comment_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/issues/comments{/number}","contents_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/contents/{+path}","compare_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/merges","archive_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/downloads","issues_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/issues{/number}","pulls_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/pulls{/number}","milestones_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/milestones{/number}","notifications_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/labels{/name}","releases_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/releases{/id}","deployments_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/deployments","created_at":"2016-10-08T15:59:35Z","updated_at":"2017-09-11T19:43:51Z","pushed_at":"2017-09-11T20:25:28Z","git_url":"git://github.com/bootstrap-vue/bootstrap-vue.git","ssh_url":"git@github.com:bootstrap-vue/bootstrap-vue.git","clone_url":"https://github.com/bootstrap-vue/bootstrap-vue.git","svn_url":"https://github.com/bootstrap-vue/bootstrap-vue","homepage":"https://bootstrap-vue.js.org","size":3313,"stargazers_count":2037,"watchers_count":2037,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":384,"mirror_url":null,"open_issues_count":45,"forks":384,"open_issues":45,"watchers":2037,"default_branch":"dev"}},"base":{"label":"bootstrap-vue:dev","ref":"dev","sha":"89519a35c83c18882f6213828b3017b1665155d6","user":{"login":"bootstrap-vue","id":22965283,"avatar_url":"https://avatars2.githubusercontent.com/u/22965283?v=4","gravatar_id":"","url":"https://api.github.com/users/bootstrap-vue","html_url":"https://github.com/bootstrap-vue","followers_url":"https://api.github.com/users/bootstrap-vue/followers","following_url":"https://api.github.com/users/bootstrap-vue/following{/other_user}","gists_url":"https://api.github.com/users/bootstrap-vue/gists{/gist_id}","starred_url":"https://api.github.com/users/bootstrap-vue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bootstrap-vue/subscriptions","organizations_url":"https://api.github.com/users/bootstrap-vue/orgs","repos_url":"https://api.github.com/users/bootstrap-vue/repos","events_url":"https://api.github.com/users/bootstrap-vue/events{/privacy}","received_events_url":"https://api.github.com/users/bootstrap-vue/received_events","type":"Organization","site_admin":false},"repo":{"id":70342215,"name":"bootstrap-vue","full_name":"bootstrap-vue/bootstrap-vue","owner":{"login":"bootstrap-vue","id":22965283,"avatar_url":"https://avatars2.githubusercontent.com/u/22965283?v=4","gravatar_id":"","url":"https://api.github.com/users/bootstrap-vue","html_url":"https://github.com/bootstrap-vue","followers_url":"https://api.github.com/users/bootstrap-vue/followers","following_url":"https://api.github.com/users/bootstrap-vue/following{/other_user}","gists_url":"https://api.github.com/users/bootstrap-vue/gists{/gist_id}","starred_url":"https://api.github.com/users/bootstrap-vue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bootstrap-vue/subscriptions","organizations_url":"https://api.github.com/users/bootstrap-vue/orgs","repos_url":"https://api.github.com/users/bootstrap-vue/repos","events_url":"https://api.github.com/users/bootstrap-vue/events{/privacy}","received_events_url":"https://api.github.com/users/bootstrap-vue/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bootstrap-vue/bootstrap-vue","description":"Quickly integrate Bootstrap 4 Components with Vue.js.","fork":false,"url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue","forks_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/forks","keys_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/teams","hooks_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/hooks","issue_events_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/issues/events{/number}","events_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/events","assignees_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/assignees{/user}","branches_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/branches{/branch}","tags_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/tags","blobs_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/git/refs{/sha}","trees_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/statuses/{sha}","languages_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/languages","stargazers_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/stargazers","contributors_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/contributors","subscribers_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/subscribers","subscription_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/subscription","commits_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/commits{/sha}","git_commits_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/git/commits{/sha}","comments_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/comments{/number}","issue_comment_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/issues/comments{/number}","contents_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/contents/{+path}","compare_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/merges","archive_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/downloads","issues_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/issues{/number}","pulls_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/pulls{/number}","milestones_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/milestones{/number}","notifications_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/labels{/name}","releases_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/releases{/id}","deployments_url":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/deployments","created_at":"2016-10-08T15:59:35Z","updated_at":"2017-09-11T19:43:51Z","pushed_at":"2017-09-11T20:25:28Z","git_url":"git://github.com/bootstrap-vue/bootstrap-vue.git","ssh_url":"git@github.com:bootstrap-vue/bootstrap-vue.git","clone_url":"https://github.com/bootstrap-vue/bootstrap-vue.git","svn_url":"https://github.com/bootstrap-vue/bootstrap-vue","homepage":"https://bootstrap-vue.js.org","size":3313,"stargazers_count":2037,"watchers_count":2037,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":384,"mirror_url":null,"open_issues_count":45,"forks":384,"open_issues":45,"watchers":2037,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/pulls/1024"},"html":{"href":"https://github.com/bootstrap-vue/bootstrap-vue/pull/1024"},"issue":{"href":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/issues/1024"},"comments":{"href":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/issues/1024/comments"},"review_comments":{"href":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/pulls/1024/comments"},"review_comment":{"href":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/pulls/1024/commits"},"statuses":{"href":"https://api.github.com/repos/bootstrap-vue/bootstrap-vue/statuses/e86c21c319fb47d3cd6f67bd43a31d172f435970"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"tmorehouse"}}