{"action":"created","comment":{"url":"https://api.github.com/repos/MagicStack/asyncpg/pulls/comments/139145751","pull_request_review_id":63039135,"id":139145751,"diff_hunk":"@@ -579,6 +615,17 @@ cdef class BaseProtocol(CoreProtocol):\n             raise apg_exc.InterfaceError(\n                 'cannot perform operation: another operation is in progress')\n \n+    cdef _coreproto_error(self):\n+        try:\n+            if self.waiter is not None:\n+                if not self.waiter.done():\n+                    raise apg_exc.InterfaceError(","path":"asyncpg/protocol/protocol.pyx","position":214,"original_position":214,"commit_id":"eab331c2bdd30cab03cd038ace978f7d29a477b7","original_commit_id":"eab331c2bdd30cab03cd038ace978f7d29a477b7","user":{"login":"elprans","id":347119,"avatar_url":"https://avatars1.githubusercontent.com/u/347119?v=4","gravatar_id":"","url":"https://api.github.com/users/elprans","html_url":"https://github.com/elprans","followers_url":"https://api.github.com/users/elprans/followers","following_url":"https://api.github.com/users/elprans/following{/other_user}","gists_url":"https://api.github.com/users/elprans/gists{/gist_id}","starred_url":"https://api.github.com/users/elprans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elprans/subscriptions","organizations_url":"https://api.github.com/users/elprans/orgs","repos_url":"https://api.github.com/users/elprans/repos","events_url":"https://api.github.com/users/elprans/events{/privacy}","received_events_url":"https://api.github.com/users/elprans/received_events","type":"User","site_admin":false},"body":"Why is this an `InterfaceError`?","created_at":"2017-09-15T13:17:25Z","updated_at":"2017-09-15T13:17:25Z","html_url":"https://github.com/MagicStack/asyncpg/pull/195#discussion_r139145751","pull_request_url":"https://api.github.com/repos/MagicStack/asyncpg/pulls/195","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/MagicStack/asyncpg/pulls/comments/139145751"},"html":{"href":"https://github.com/MagicStack/asyncpg/pull/195#discussion_r139145751"},"pull_request":{"href":"https://api.github.com/repos/MagicStack/asyncpg/pulls/195"}}},"pull_request":{"url":"https://api.github.com/repos/MagicStack/asyncpg/pulls/195","id":141203291,"html_url":"https://github.com/MagicStack/asyncpg/pull/195","diff_url":"https://github.com/MagicStack/asyncpg/pull/195.diff","patch_url":"https://github.com/MagicStack/asyncpg/pull/195.patch","issue_url":"https://api.github.com/repos/MagicStack/asyncpg/issues/195","number":195,"state":"open","locked":false,"title":"protocol: Use try-finally explicitly every time we create a waiter","user":{"login":"1st1","id":239003,"avatar_url":"https://avatars0.githubusercontent.com/u/239003?v=4","gravatar_id":"","url":"https://api.github.com/users/1st1","html_url":"https://github.com/1st1","followers_url":"https://api.github.com/users/1st1/followers","following_url":"https://api.github.com/users/1st1/following{/other_user}","gists_url":"https://api.github.com/users/1st1/gists{/gist_id}","starred_url":"https://api.github.com/users/1st1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/1st1/subscriptions","organizations_url":"https://api.github.com/users/1st1/orgs","repos_url":"https://api.github.com/users/1st1/repos","events_url":"https://api.github.com/users/1st1/events{/privacy}","received_events_url":"https://api.github.com/users/1st1/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-09-15T00:06:15Z","updated_at":"2017-09-15T13:17:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e59b4be736e846d890d9f6204b9b43657c5d3fa5","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/MagicStack/asyncpg/pulls/195/commits","review_comments_url":"https://api.github.com/repos/MagicStack/asyncpg/pulls/195/comments","review_comment_url":"https://api.github.com/repos/MagicStack/asyncpg/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MagicStack/asyncpg/issues/195/comments","statuses_url":"https://api.github.com/repos/MagicStack/asyncpg/statuses/eab331c2bdd30cab03cd038ace978f7d29a477b7","head":{"label":"MagicStack:proto","ref":"proto","sha":"eab331c2bdd30cab03cd038ace978f7d29a477b7","user":{"login":"MagicStack","id":14324950,"avatar_url":"https://avatars2.githubusercontent.com/u/14324950?v=4","gravatar_id":"","url":"https://api.github.com/users/MagicStack","html_url":"https://github.com/MagicStack","followers_url":"https://api.github.com/users/MagicStack/followers","following_url":"https://api.github.com/users/MagicStack/following{/other_user}","gists_url":"https://api.github.com/users/MagicStack/gists{/gist_id}","starred_url":"https://api.github.com/users/MagicStack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MagicStack/subscriptions","organizations_url":"https://api.github.com/users/MagicStack/orgs","repos_url":"https://api.github.com/users/MagicStack/repos","events_url":"https://api.github.com/users/MagicStack/events{/privacy}","received_events_url":"https://api.github.com/users/MagicStack/received_events","type":"Organization","site_admin":false},"repo":{"id":63652864,"name":"asyncpg","full_name":"MagicStack/asyncpg","owner":{"login":"MagicStack","id":14324950,"avatar_url":"https://avatars2.githubusercontent.com/u/14324950?v=4","gravatar_id":"","url":"https://api.github.com/users/MagicStack","html_url":"https://github.com/MagicStack","followers_url":"https://api.github.com/users/MagicStack/followers","following_url":"https://api.github.com/users/MagicStack/following{/other_user}","gists_url":"https://api.github.com/users/MagicStack/gists{/gist_id}","starred_url":"https://api.github.com/users/MagicStack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MagicStack/subscriptions","organizations_url":"https://api.github.com/users/MagicStack/orgs","repos_url":"https://api.github.com/users/MagicStack/repos","events_url":"https://api.github.com/users/MagicStack/events{/privacy}","received_events_url":"https://api.github.com/users/MagicStack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MagicStack/asyncpg","description":"A fast PostgreSQL Database Client Library for Python/asyncio.","fork":false,"url":"https://api.github.com/repos/MagicStack/asyncpg","forks_url":"https://api.github.com/repos/MagicStack/asyncpg/forks","keys_url":"https://api.github.com/repos/MagicStack/asyncpg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MagicStack/asyncpg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MagicStack/asyncpg/teams","hooks_url":"https://api.github.com/repos/MagicStack/asyncpg/hooks","issue_events_url":"https://api.github.com/repos/MagicStack/asyncpg/issues/events{/number}","events_url":"https://api.github.com/repos/MagicStack/asyncpg/events","assignees_url":"https://api.github.com/repos/MagicStack/asyncpg/assignees{/user}","branches_url":"https://api.github.com/repos/MagicStack/asyncpg/branches{/branch}","tags_url":"https://api.github.com/repos/MagicStack/asyncpg/tags","blobs_url":"https://api.github.com/repos/MagicStack/asyncpg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MagicStack/asyncpg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MagicStack/asyncpg/git/refs{/sha}","trees_url":"https://api.github.com/repos/MagicStack/asyncpg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MagicStack/asyncpg/statuses/{sha}","languages_url":"https://api.github.com/repos/MagicStack/asyncpg/languages","stargazers_url":"https://api.github.com/repos/MagicStack/asyncpg/stargazers","contributors_url":"https://api.github.com/repos/MagicStack/asyncpg/contributors","subscribers_url":"https://api.github.com/repos/MagicStack/asyncpg/subscribers","subscription_url":"https://api.github.com/repos/MagicStack/asyncpg/subscription","commits_url":"https://api.github.com/repos/MagicStack/asyncpg/commits{/sha}","git_commits_url":"https://api.github.com/repos/MagicStack/asyncpg/git/commits{/sha}","comments_url":"https://api.github.com/repos/MagicStack/asyncpg/comments{/number}","issue_comment_url":"https://api.github.com/repos/MagicStack/asyncpg/issues/comments{/number}","contents_url":"https://api.github.com/repos/MagicStack/asyncpg/contents/{+path}","compare_url":"https://api.github.com/repos/MagicStack/asyncpg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MagicStack/asyncpg/merges","archive_url":"https://api.github.com/repos/MagicStack/asyncpg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MagicStack/asyncpg/downloads","issues_url":"https://api.github.com/repos/MagicStack/asyncpg/issues{/number}","pulls_url":"https://api.github.com/repos/MagicStack/asyncpg/pulls{/number}","milestones_url":"https://api.github.com/repos/MagicStack/asyncpg/milestones{/number}","notifications_url":"https://api.github.com/repos/MagicStack/asyncpg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MagicStack/asyncpg/labels{/name}","releases_url":"https://api.github.com/repos/MagicStack/asyncpg/releases{/id}","deployments_url":"https://api.github.com/repos/MagicStack/asyncpg/deployments","created_at":"2016-07-19T02:25:20Z","updated_at":"2017-09-14T17:58:55Z","pushed_at":"2017-09-15T00:17:42Z","git_url":"git://github.com/MagicStack/asyncpg.git","ssh_url":"git@github.com:MagicStack/asyncpg.git","clone_url":"https://github.com/MagicStack/asyncpg.git","svn_url":"https://github.com/MagicStack/asyncpg","homepage":"","size":2943,"stargazers_count":2007,"watchers_count":2007,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":70,"mirror_url":null,"open_issues_count":16,"forks":70,"open_issues":16,"watchers":2007,"default_branch":"master"}},"base":{"label":"MagicStack:master","ref":"master","sha":"f29de232cd8434ca0f83d87ec5194750dbf2f0bf","user":{"login":"MagicStack","id":14324950,"avatar_url":"https://avatars2.githubusercontent.com/u/14324950?v=4","gravatar_id":"","url":"https://api.github.com/users/MagicStack","html_url":"https://github.com/MagicStack","followers_url":"https://api.github.com/users/MagicStack/followers","following_url":"https://api.github.com/users/MagicStack/following{/other_user}","gists_url":"https://api.github.com/users/MagicStack/gists{/gist_id}","starred_url":"https://api.github.com/users/MagicStack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MagicStack/subscriptions","organizations_url":"https://api.github.com/users/MagicStack/orgs","repos_url":"https://api.github.com/users/MagicStack/repos","events_url":"https://api.github.com/users/MagicStack/events{/privacy}","received_events_url":"https://api.github.com/users/MagicStack/received_events","type":"Organization","site_admin":false},"repo":{"id":63652864,"name":"asyncpg","full_name":"MagicStack/asyncpg","owner":{"login":"MagicStack","id":14324950,"avatar_url":"https://avatars2.githubusercontent.com/u/14324950?v=4","gravatar_id":"","url":"https://api.github.com/users/MagicStack","html_url":"https://github.com/MagicStack","followers_url":"https://api.github.com/users/MagicStack/followers","following_url":"https://api.github.com/users/MagicStack/following{/other_user}","gists_url":"https://api.github.com/users/MagicStack/gists{/gist_id}","starred_url":"https://api.github.com/users/MagicStack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MagicStack/subscriptions","organizations_url":"https://api.github.com/users/MagicStack/orgs","repos_url":"https://api.github.com/users/MagicStack/repos","events_url":"https://api.github.com/users/MagicStack/events{/privacy}","received_events_url":"https://api.github.com/users/MagicStack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MagicStack/asyncpg","description":"A fast PostgreSQL Database Client Library for Python/asyncio.","fork":false,"url":"https://api.github.com/repos/MagicStack/asyncpg","forks_url":"https://api.github.com/repos/MagicStack/asyncpg/forks","keys_url":"https://api.github.com/repos/MagicStack/asyncpg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MagicStack/asyncpg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MagicStack/asyncpg/teams","hooks_url":"https://api.github.com/repos/MagicStack/asyncpg/hooks","issue_events_url":"https://api.github.com/repos/MagicStack/asyncpg/issues/events{/number}","events_url":"https://api.github.com/repos/MagicStack/asyncpg/events","assignees_url":"https://api.github.com/repos/MagicStack/asyncpg/assignees{/user}","branches_url":"https://api.github.com/repos/MagicStack/asyncpg/branches{/branch}","tags_url":"https://api.github.com/repos/MagicStack/asyncpg/tags","blobs_url":"https://api.github.com/repos/MagicStack/asyncpg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MagicStack/asyncpg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MagicStack/asyncpg/git/refs{/sha}","trees_url":"https://api.github.com/repos/MagicStack/asyncpg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MagicStack/asyncpg/statuses/{sha}","languages_url":"https://api.github.com/repos/MagicStack/asyncpg/languages","stargazers_url":"https://api.github.com/repos/MagicStack/asyncpg/stargazers","contributors_url":"https://api.github.com/repos/MagicStack/asyncpg/contributors","subscribers_url":"https://api.github.com/repos/MagicStack/asyncpg/subscribers","subscription_url":"https://api.github.com/repos/MagicStack/asyncpg/subscription","commits_url":"https://api.github.com/repos/MagicStack/asyncpg/commits{/sha}","git_commits_url":"https://api.github.com/repos/MagicStack/asyncpg/git/commits{/sha}","comments_url":"https://api.github.com/repos/MagicStack/asyncpg/comments{/number}","issue_comment_url":"https://api.github.com/repos/MagicStack/asyncpg/issues/comments{/number}","contents_url":"https://api.github.com/repos/MagicStack/asyncpg/contents/{+path}","compare_url":"https://api.github.com/repos/MagicStack/asyncpg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MagicStack/asyncpg/merges","archive_url":"https://api.github.com/repos/MagicStack/asyncpg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MagicStack/asyncpg/downloads","issues_url":"https://api.github.com/repos/MagicStack/asyncpg/issues{/number}","pulls_url":"https://api.github.com/repos/MagicStack/asyncpg/pulls{/number}","milestones_url":"https://api.github.com/repos/MagicStack/asyncpg/milestones{/number}","notifications_url":"https://api.github.com/repos/MagicStack/asyncpg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MagicStack/asyncpg/labels{/name}","releases_url":"https://api.github.com/repos/MagicStack/asyncpg/releases{/id}","deployments_url":"https://api.github.com/repos/MagicStack/asyncpg/deployments","created_at":"2016-07-19T02:25:20Z","updated_at":"2017-09-14T17:58:55Z","pushed_at":"2017-09-15T00:17:42Z","git_url":"git://github.com/MagicStack/asyncpg.git","ssh_url":"git@github.com:MagicStack/asyncpg.git","clone_url":"https://github.com/MagicStack/asyncpg.git","svn_url":"https://github.com/MagicStack/asyncpg","homepage":"","size":2943,"stargazers_count":2007,"watchers_count":2007,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":70,"mirror_url":null,"open_issues_count":16,"forks":70,"open_issues":16,"watchers":2007,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MagicStack/asyncpg/pulls/195"},"html":{"href":"https://github.com/MagicStack/asyncpg/pull/195"},"issue":{"href":"https://api.github.com/repos/MagicStack/asyncpg/issues/195"},"comments":{"href":"https://api.github.com/repos/MagicStack/asyncpg/issues/195/comments"},"review_comments":{"href":"https://api.github.com/repos/MagicStack/asyncpg/pulls/195/comments"},"review_comment":{"href":"https://api.github.com/repos/MagicStack/asyncpg/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MagicStack/asyncpg/pulls/195/commits"},"statuses":{"href":"https://api.github.com/repos/MagicStack/asyncpg/statuses/eab331c2bdd30cab03cd038ace978f7d29a477b7"}},"author_association":"OWNER"}}
{"actor":{"display_login":"elprans"}}