{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/43194","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/43194/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/43194/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/43194/events","html_url":"https://github.com/kubernetes/kubernetes/pull/43194","id":214602040,"number":43194,"title":"[Federation] Add type-agnostic e2e crud test","user":{"login":"marun","id":451477,"avatar_url":"https://avatars0.githubusercontent.com/u/451477?v=3","gravatar_id":"","url":"https://api.github.com/users/marun","html_url":"https://github.com/marun","followers_url":"https://api.github.com/users/marun/followers","following_url":"https://api.github.com/users/marun/following{/other_user}","gists_url":"https://api.github.com/users/marun/gists{/gist_id}","starred_url":"https://api.github.com/users/marun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marun/subscriptions","organizations_url":"https://api.github.com/users/marun/orgs","repos_url":"https://api.github.com/users/marun/repos","events_url":"https://api.github.com/users/marun/events{/privacy}","received_events_url":"https://api.github.com/users/marun/received_events","type":"User","site_admin":false},"labels":[{"id":414883982,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":477397086,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":148225179,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/lgtm","name":"lgtm","color":"15dd18","default":false},{"id":349530249,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":258410135,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/federation","name":"sig/federation","color":"d2b48c","default":false},{"id":253450978,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/L","name":"size/L","color":"ee9900","default":false}],"state":"closed","locked":false,"assignee":{"login":"nikhiljindal","id":10199099,"avatar_url":"https://avatars3.githubusercontent.com/u/10199099?v=3","gravatar_id":"","url":"https://api.github.com/users/nikhiljindal","html_url":"https://github.com/nikhiljindal","followers_url":"https://api.github.com/users/nikhiljindal/followers","following_url":"https://api.github.com/users/nikhiljindal/following{/other_user}","gists_url":"https://api.github.com/users/nikhiljindal/gists{/gist_id}","starred_url":"https://api.github.com/users/nikhiljindal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikhiljindal/subscriptions","organizations_url":"https://api.github.com/users/nikhiljindal/orgs","repos_url":"https://api.github.com/users/nikhiljindal/repos","events_url":"https://api.github.com/users/nikhiljindal/events{/privacy}","received_events_url":"https://api.github.com/users/nikhiljindal/received_events","type":"User","site_admin":false},"assignees":[{"login":"nikhiljindal","id":10199099,"avatar_url":"https://avatars3.githubusercontent.com/u/10199099?v=3","gravatar_id":"","url":"https://api.github.com/users/nikhiljindal","html_url":"https://github.com/nikhiljindal","followers_url":"https://api.github.com/users/nikhiljindal/followers","following_url":"https://api.github.com/users/nikhiljindal/following{/other_user}","gists_url":"https://api.github.com/users/nikhiljindal/gists{/gist_id}","starred_url":"https://api.github.com/users/nikhiljindal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikhiljindal/subscriptions","organizations_url":"https://api.github.com/users/nikhiljindal/orgs","repos_url":"https://api.github.com/users/nikhiljindal/repos","events_url":"https://api.github.com/users/nikhiljindal/events{/privacy}","received_events_url":"https://api.github.com/users/nikhiljindal/received_events","type":"User","site_admin":false},{"login":"csbell","id":23373339,"avatar_url":"https://avatars2.githubusercontent.com/u/23373339?v=3","gravatar_id":"","url":"https://api.github.com/users/csbell","html_url":"https://github.com/csbell","followers_url":"https://api.github.com/users/csbell/followers","following_url":"https://api.github.com/users/csbell/following{/other_user}","gists_url":"https://api.github.com/users/csbell/gists{/gist_id}","starred_url":"https://api.github.com/users/csbell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csbell/subscriptions","organizations_url":"https://api.github.com/users/csbell/orgs","repos_url":"https://api.github.com/users/csbell/repos","events_url":"https://api.github.com/users/csbell/events{/privacy}","received_events_url":"https://api.github.com/users/csbell/received_events","type":"User","site_admin":false}],"milestone":null,"comments":16,"created_at":"2017-03-16T05:23:50Z","updated_at":"2017-04-17T20:20:55Z","closed_at":"2017-04-17T19:39:04Z","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/43194","html_url":"https://github.com/kubernetes/kubernetes/pull/43194","diff_url":"https://github.com/kubernetes/kubernetes/pull/43194.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/43194.patch"},"body":"This PR proposes an e2e test that reuses the type-agnostic crudtester already used for integration testing to validate crud against a deployed cluster. It is intended to to eventually replace the existing e2e tests for simple types like secrets, but for now will run in addition to the existing testing to gain confidence in the coverage it provides.\r\n\r\nThe deletion corner cases - when orphanDependents is nil or true - do not involve operations in the member clusters and are already well-tested in integration testing and so are not reimplemented here.\r\n\r\nWhere it can be applied, this approach of abstracting a test from its execution environment - making the test 'retargetable' - can reduce the cost of test development since the bulk of the work can be iterated on as an integration test.  It can also serve as a check on assumptions made in the integration test about how a deployed environment will behave.\r\n\r\ncc: @kubernetes/sig-federation-pr-reviews @kubernetes/sig-testing-misc @smarterclayton @derekwaynecarr "},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/294580333","html_url":"https://github.com/kubernetes/kubernetes/pull/43194#issuecomment-294580333","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/43194","id":294580333,"user":{"login":"k8s-ci-robot","id":20407524,"avatar_url":"https://avatars3.githubusercontent.com/u/20407524?v=3","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2017-04-17T20:20:55Z","updated_at":"2017-04-17T20:20:55Z","body":"@marun: The following test(s) **failed**:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\nJenkins GCE e2e | d979210e614b425c010e9e165b8240d46e002cf0 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/43194/pull-kubernetes-e2e-gce/26747/) | `@k8s-bot cvm gce e2e test this`\n\n[Full PR test history](https://k8s-gubernator.appspot.com/pr/43194). [Your PR dashboard](https://k8s-gubernator.appspot.com/pr/marun). Please help us cut down on flakes by linking to an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://github.com/kubernetes/community/blob/master/contributors/devel/pull-request-commands.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://github.com/kubernetes/test-infra/blob/master/prow/commands.md).\n</details>\n<!-- test report -->"}}
{"actor":{"display_login":"k8s-ci-robot"}}