{"action":"created","comment":{"url":"https://api.github.com/repos/hyperoslo/BarcodeScanner/pulls/comments/140337954","pull_request_review_id":64397270,"id":140337954,"diff_hunk":"@@ -228,7 +234,7 @@\n \t\t\t\tGCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;\n \t\t\t\tGCC_WARN_UNUSED_FUNCTION = YES;\n \t\t\t\tGCC_WARN_UNUSED_VARIABLE = YES;\n-\t\t\t\tIPHONEOS_DEPLOYMENT_TARGET = 9.2;\n+\t\t\t\tIPHONEOS_DEPLOYMENT_TARGET = 9.3;","path":"BarcodeScanner.xcodeproj/project.pbxproj","position":53,"original_position":53,"commit_id":"f2e4fa3fd32bb9bdfc9259c10ccc7e722e4babc5","original_commit_id":"f2e4fa3fd32bb9bdfc9259c10ccc7e722e4babc5","user":{"login":"chadcummings","id":26779175,"avatar_url":"https://avatars3.githubusercontent.com/u/26779175?v=4","gravatar_id":"","url":"https://api.github.com/users/chadcummings","html_url":"https://github.com/chadcummings","followers_url":"https://api.github.com/users/chadcummings/followers","following_url":"https://api.github.com/users/chadcummings/following{/other_user}","gists_url":"https://api.github.com/users/chadcummings/gists{/gist_id}","starred_url":"https://api.github.com/users/chadcummings/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chadcummings/subscriptions","organizations_url":"https://api.github.com/users/chadcummings/orgs","repos_url":"https://api.github.com/users/chadcummings/repos","events_url":"https://api.github.com/users/chadcummings/events{/privacy}","received_events_url":"https://api.github.com/users/chadcummings/received_events","type":"User","site_admin":false},"body":"After reviewing which devices can run iOS 9.0, I discovered that all of the target devices can also run iOS 9.3. This led me to the conclusion that is was pointless to support iOS 9.0 when all devices that run iOS 9.0 will run iOS 9.3. Supporting iOS 9.0 has no benefit, as no additional devices are gained. That's my only reasoning, really.\r\n\r\nUltimately, this code is your's. I am happy to use whichever version you would like, but I would prefer trimming extra baggage as much as possible.","created_at":"2017-09-21T19:30:48Z","updated_at":"2017-09-21T19:30:48Z","html_url":"https://github.com/hyperoslo/BarcodeScanner/pull/64#discussion_r140337954","pull_request_url":"https://api.github.com/repos/hyperoslo/BarcodeScanner/pulls/64","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/hyperoslo/BarcodeScanner/pulls/comments/140337954"},"html":{"href":"https://github.com/hyperoslo/BarcodeScanner/pull/64#discussion_r140337954"},"pull_request":{"href":"https://api.github.com/repos/hyperoslo/BarcodeScanner/pulls/64"}},"in_reply_to_id":140324289},"pull_request":{"url":"https://api.github.com/repos/hyperoslo/BarcodeScanner/pulls/64","id":142374088,"html_url":"https://github.com/hyperoslo/BarcodeScanner/pull/64","diff_url":"https://github.com/hyperoslo/BarcodeScanner/pull/64.diff","patch_url":"https://github.com/hyperoslo/BarcodeScanner/pull/64.patch","issue_url":"https://api.github.com/repos/hyperoslo/BarcodeScanner/issues/64","number":64,"state":"open","locked":false,"title":"Swift 4","user":{"login":"chadcummings","id":26779175,"avatar_url":"https://avatars3.githubusercontent.com/u/26779175?v=4","gravatar_id":"","url":"https://api.github.com/users/chadcummings","html_url":"https://github.com/chadcummings","followers_url":"https://api.github.com/users/chadcummings/followers","following_url":"https://api.github.com/users/chadcummings/following{/other_user}","gists_url":"https://api.github.com/users/chadcummings/gists{/gist_id}","starred_url":"https://api.github.com/users/chadcummings/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chadcummings/subscriptions","organizations_url":"https://api.github.com/users/chadcummings/orgs","repos_url":"https://api.github.com/users/chadcummings/repos","events_url":"https://api.github.com/users/chadcummings/events{/privacy}","received_events_url":"https://api.github.com/users/chadcummings/received_events","type":"User","site_admin":false},"body":"Swift 4 Upgrades! Let me know if I missed anything.\r\n\r\n- Upgrades to project and code to allow for Swift 4, SDK iOS11.\r\n- Target iOS 9.3.\r\n- Add support for UPC-A.\r\n- Add all new barcode types to the metadata array.","created_at":"2017-09-21T15:26:09Z","updated_at":"2017-09-21T19:30:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7527339fbba7733af9225b30d5d6964a1d2aa383","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/hyperoslo/BarcodeScanner/pulls/64/commits","review_comments_url":"https://api.github.com/repos/hyperoslo/BarcodeScanner/pulls/64/comments","review_comment_url":"https://api.github.com/repos/hyperoslo/BarcodeScanner/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hyperoslo/BarcodeScanner/issues/64/comments","statuses_url":"https://api.github.com/repos/hyperoslo/BarcodeScanner/statuses/f2e4fa3fd32bb9bdfc9259c10ccc7e722e4babc5","head":{"label":"chadcummings:swift4","ref":"swift4","sha":"f2e4fa3fd32bb9bdfc9259c10ccc7e722e4babc5","user":{"login":"chadcummings","id":26779175,"avatar_url":"https://avatars3.githubusercontent.com/u/26779175?v=4","gravatar_id":"","url":"https://api.github.com/users/chadcummings","html_url":"https://github.com/chadcummings","followers_url":"https://api.github.com/users/chadcummings/followers","following_url":"https://api.github.com/users/chadcummings/following{/other_user}","gists_url":"https://api.github.com/users/chadcummings/gists{/gist_id}","starred_url":"https://api.github.com/users/chadcummings/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chadcummings/subscriptions","organizations_url":"https://api.github.com/users/chadcummings/orgs","repos_url":"https://api.github.com/users/chadcummings/repos","events_url":"https://api.github.com/users/chadcummings/events{/privacy}","received_events_url":"https://api.github.com/users/chadcummings/received_events","type":"User","site_admin":false},"repo":{"id":104364931,"name":"BarcodeScanner","full_name":"chadcummings/BarcodeScanner","owner":{"login":"chadcummings","id":26779175,"avatar_url":"https://avatars3.githubusercontent.com/u/26779175?v=4","gravatar_id":"","url":"https://api.github.com/users/chadcummings","html_url":"https://github.com/chadcummings","followers_url":"https://api.github.com/users/chadcummings/followers","following_url":"https://api.github.com/users/chadcummings/following{/other_user}","gists_url":"https://api.github.com/users/chadcummings/gists{/gist_id}","starred_url":"https://api.github.com/users/chadcummings/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chadcummings/subscriptions","organizations_url":"https://api.github.com/users/chadcummings/orgs","repos_url":"https://api.github.com/users/chadcummings/repos","events_url":"https://api.github.com/users/chadcummings/events{/privacy}","received_events_url":"https://api.github.com/users/chadcummings/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chadcummings/BarcodeScanner","description":":mag_right: A simple and beautiful barcode scanner.","fork":true,"url":"https://api.github.com/repos/chadcummings/BarcodeScanner","forks_url":"https://api.github.com/repos/chadcummings/BarcodeScanner/forks","keys_url":"https://api.github.com/repos/chadcummings/BarcodeScanner/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chadcummings/BarcodeScanner/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chadcummings/BarcodeScanner/teams","hooks_url":"https://api.github.com/repos/chadcummings/BarcodeScanner/hooks","issue_events_url":"https://api.github.com/repos/chadcummings/BarcodeScanner/issues/events{/number}","events_url":"https://api.github.com/repos/chadcummings/BarcodeScanner/events","assignees_url":"https://api.github.com/repos/chadcummings/BarcodeScanner/assignees{/user}","branches_url":"https://api.github.com/repos/chadcummings/BarcodeScanner/branches{/branch}","tags_url":"https://api.github.com/repos/chadcummings/BarcodeScanner/tags","blobs_url":"https://api.github.com/repos/chadcummings/BarcodeScanner/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chadcummings/BarcodeScanner/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chadcummings/BarcodeScanner/git/refs{/sha}","trees_url":"https://api.github.com/repos/chadcummings/BarcodeScanner/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chadcummings/BarcodeScanner/statuses/{sha}","languages_url":"https://api.github.com/repos/chadcummings/BarcodeScanner/languages","stargazers_url":"https://api.github.com/repos/chadcummings/BarcodeScanner/stargazers","contributors_url":"https://api.github.com/repos/chadcummings/BarcodeScanner/contributors","subscribers_url":"https://api.github.com/repos/chadcummings/BarcodeScanner/subscribers","subscription_url":"https://api.github.com/repos/chadcummings/BarcodeScanner/subscription","commits_url":"https://api.github.com/repos/chadcummings/BarcodeScanner/commits{/sha}","git_commits_url":"https://api.github.com/repos/chadcummings/BarcodeScanner/git/commits{/sha}","comments_url":"https://api.github.com/repos/chadcummings/BarcodeScanner/comments{/number}","issue_comment_url":"https://api.github.com/repos/chadcummings/BarcodeScanner/issues/comments{/number}","contents_url":"https://api.github.com/repos/chadcummings/BarcodeScanner/contents/{+path}","compare_url":"https://api.github.com/repos/chadcummings/BarcodeScanner/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chadcummings/BarcodeScanner/merges","archive_url":"https://api.github.com/repos/chadcummings/BarcodeScanner/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chadcummings/BarcodeScanner/downloads","issues_url":"https://api.github.com/repos/chadcummings/BarcodeScanner/issues{/number}","pulls_url":"https://api.github.com/repos/chadcummings/BarcodeScanner/pulls{/number}","milestones_url":"https://api.github.com/repos/chadcummings/BarcodeScanner/milestones{/number}","notifications_url":"https://api.github.com/repos/chadcummings/BarcodeScanner/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chadcummings/BarcodeScanner/labels{/name}","releases_url":"https://api.github.com/repos/chadcummings/BarcodeScanner/releases{/id}","deployments_url":"https://api.github.com/repos/chadcummings/BarcodeScanner/deployments","created_at":"2017-09-21T15:21:27Z","updated_at":"2017-09-21T15:21:28Z","pushed_at":"2017-09-21T15:23:02Z","git_url":"git://github.com/chadcummings/BarcodeScanner.git","ssh_url":"git@github.com:chadcummings/BarcodeScanner.git","clone_url":"https://github.com/chadcummings/BarcodeScanner.git","svn_url":"https://github.com/chadcummings/BarcodeScanner","homepage":"http://hyper.no","size":1865,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hyperoslo:master","ref":"master","sha":"b2558801a9a44ef0b4c0299292acefa284e7e6d4","user":{"login":"hyperoslo","id":1340892,"avatar_url":"https://avatars3.githubusercontent.com/u/1340892?v=4","gravatar_id":"","url":"https://api.github.com/users/hyperoslo","html_url":"https://github.com/hyperoslo","followers_url":"https://api.github.com/users/hyperoslo/followers","following_url":"https://api.github.com/users/hyperoslo/following{/other_user}","gists_url":"https://api.github.com/users/hyperoslo/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperoslo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperoslo/subscriptions","organizations_url":"https://api.github.com/users/hyperoslo/orgs","repos_url":"https://api.github.com/users/hyperoslo/repos","events_url":"https://api.github.com/users/hyperoslo/events{/privacy}","received_events_url":"https://api.github.com/users/hyperoslo/received_events","type":"Organization","site_admin":false},"repo":{"id":54202860,"name":"BarcodeScanner","full_name":"hyperoslo/BarcodeScanner","owner":{"login":"hyperoslo","id":1340892,"avatar_url":"https://avatars3.githubusercontent.com/u/1340892?v=4","gravatar_id":"","url":"https://api.github.com/users/hyperoslo","html_url":"https://github.com/hyperoslo","followers_url":"https://api.github.com/users/hyperoslo/followers","following_url":"https://api.github.com/users/hyperoslo/following{/other_user}","gists_url":"https://api.github.com/users/hyperoslo/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperoslo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperoslo/subscriptions","organizations_url":"https://api.github.com/users/hyperoslo/orgs","repos_url":"https://api.github.com/users/hyperoslo/repos","events_url":"https://api.github.com/users/hyperoslo/events{/privacy}","received_events_url":"https://api.github.com/users/hyperoslo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hyperoslo/BarcodeScanner","description":":mag_right: A simple and beautiful barcode scanner.","fork":false,"url":"https://api.github.com/repos/hyperoslo/BarcodeScanner","forks_url":"https://api.github.com/repos/hyperoslo/BarcodeScanner/forks","keys_url":"https://api.github.com/repos/hyperoslo/BarcodeScanner/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyperoslo/BarcodeScanner/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyperoslo/BarcodeScanner/teams","hooks_url":"https://api.github.com/repos/hyperoslo/BarcodeScanner/hooks","issue_events_url":"https://api.github.com/repos/hyperoslo/BarcodeScanner/issues/events{/number}","events_url":"https://api.github.com/repos/hyperoslo/BarcodeScanner/events","assignees_url":"https://api.github.com/repos/hyperoslo/BarcodeScanner/assignees{/user}","branches_url":"https://api.github.com/repos/hyperoslo/BarcodeScanner/branches{/branch}","tags_url":"https://api.github.com/repos/hyperoslo/BarcodeScanner/tags","blobs_url":"https://api.github.com/repos/hyperoslo/BarcodeScanner/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyperoslo/BarcodeScanner/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyperoslo/BarcodeScanner/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyperoslo/BarcodeScanner/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyperoslo/BarcodeScanner/statuses/{sha}","languages_url":"https://api.github.com/repos/hyperoslo/BarcodeScanner/languages","stargazers_url":"https://api.github.com/repos/hyperoslo/BarcodeScanner/stargazers","contributors_url":"https://api.github.com/repos/hyperoslo/BarcodeScanner/contributors","subscribers_url":"https://api.github.com/repos/hyperoslo/BarcodeScanner/subscribers","subscription_url":"https://api.github.com/repos/hyperoslo/BarcodeScanner/subscription","commits_url":"https://api.github.com/repos/hyperoslo/BarcodeScanner/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyperoslo/BarcodeScanner/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyperoslo/BarcodeScanner/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyperoslo/BarcodeScanner/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyperoslo/BarcodeScanner/contents/{+path}","compare_url":"https://api.github.com/repos/hyperoslo/BarcodeScanner/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyperoslo/BarcodeScanner/merges","archive_url":"https://api.github.com/repos/hyperoslo/BarcodeScanner/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyperoslo/BarcodeScanner/downloads","issues_url":"https://api.github.com/repos/hyperoslo/BarcodeScanner/issues{/number}","pulls_url":"https://api.github.com/repos/hyperoslo/BarcodeScanner/pulls{/number}","milestones_url":"https://api.github.com/repos/hyperoslo/BarcodeScanner/milestones{/number}","notifications_url":"https://api.github.com/repos/hyperoslo/BarcodeScanner/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyperoslo/BarcodeScanner/labels{/name}","releases_url":"https://api.github.com/repos/hyperoslo/BarcodeScanner/releases{/id}","deployments_url":"https://api.github.com/repos/hyperoslo/BarcodeScanner/deployments","created_at":"2016-03-18T13:25:19Z","updated_at":"2017-09-20T15:51:05Z","pushed_at":"2017-09-21T15:26:10Z","git_url":"git://github.com/hyperoslo/BarcodeScanner.git","ssh_url":"git@github.com:hyperoslo/BarcodeScanner.git","clone_url":"https://github.com/hyperoslo/BarcodeScanner.git","svn_url":"https://github.com/hyperoslo/BarcodeScanner","homepage":"http://hyper.no","size":1853,"stargazers_count":718,"watchers_count":718,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":91,"mirror_url":null,"open_issues_count":16,"forks":91,"open_issues":16,"watchers":718,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hyperoslo/BarcodeScanner/pulls/64"},"html":{"href":"https://github.com/hyperoslo/BarcodeScanner/pull/64"},"issue":{"href":"https://api.github.com/repos/hyperoslo/BarcodeScanner/issues/64"},"comments":{"href":"https://api.github.com/repos/hyperoslo/BarcodeScanner/issues/64/comments"},"review_comments":{"href":"https://api.github.com/repos/hyperoslo/BarcodeScanner/pulls/64/comments"},"review_comment":{"href":"https://api.github.com/repos/hyperoslo/BarcodeScanner/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hyperoslo/BarcodeScanner/pulls/64/commits"},"statuses":{"href":"https://api.github.com/repos/hyperoslo/BarcodeScanner/statuses/f2e4fa3fd32bb9bdfc9259c10ccc7e722e4babc5"}},"author_association":"NONE"}}
{"actor":{"display_login":"chadcummings"}}