{"action":"created","comment":{"url":"https://api.github.com/repos/fuzzylite/fuzzylite/pulls/comments/149615348","pull_request_review_id":75034472,"id":149615348,"diff_hunk":"@@ -177,27 +184,41 @@ else()\n endif()\n \n if(FL_BUILD_SHARED)\n+    target_include_directories(fl-shared\n+    PUBLIC\n+        $<BUILD_INTERFACE:${PROJECT_SOURCE_DIR}>\n+        $<INSTALL_INTERFACE:include>)\n     set_target_properties(fl-shared PROPERTIES OUTPUT_NAME fuzzylite)\n     set_target_properties(fl-shared PROPERTIES DEBUG_POSTFIX -debug)\n     target_compile_definitions(fl-shared PRIVATE FL_EXPORT_LIBRARY)\n-    set_target_properties(fl-shared PROPERTIES VERSION 6.0)\n+    set_target_properties(fl-shared PROPERTIES VERSION ${FL_VERISON})","path":"fuzzylite/CMakeLists.txt","position":59,"original_position":59,"commit_id":"2024598350ba09932d1f3363a0ddf3b93e836423","original_commit_id":"2024598350ba09932d1f3363a0ddf3b93e836423","user":{"login":"jcrada","id":303131,"avatar_url":"https://avatars1.githubusercontent.com/u/303131?v=4","gravatar_id":"","url":"https://api.github.com/users/jcrada","html_url":"https://github.com/jcrada","followers_url":"https://api.github.com/users/jcrada/followers","following_url":"https://api.github.com/users/jcrada/following{/other_user}","gists_url":"https://api.github.com/users/jcrada/gists{/gist_id}","starred_url":"https://api.github.com/users/jcrada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcrada/subscriptions","organizations_url":"https://api.github.com/users/jcrada/orgs","repos_url":"https://api.github.com/users/jcrada/repos","events_url":"https://api.github.com/users/jcrada/events{/privacy}","received_events_url":"https://api.github.com/users/jcrada/received_events","type":"User","site_admin":false},"body":"Spelling mistake: FL_VERSION\r\n","created_at":"2017-11-08T09:32:13Z","updated_at":"2017-11-08T09:40:09Z","html_url":"https://github.com/fuzzylite/fuzzylite/pull/83#discussion_r149615348","pull_request_url":"https://api.github.com/repos/fuzzylite/fuzzylite/pulls/83","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/fuzzylite/fuzzylite/pulls/comments/149615348"},"html":{"href":"https://github.com/fuzzylite/fuzzylite/pull/83#discussion_r149615348"},"pull_request":{"href":"https://api.github.com/repos/fuzzylite/fuzzylite/pulls/83"}}},"pull_request":{"url":"https://api.github.com/repos/fuzzylite/fuzzylite/pulls/83","id":151246423,"html_url":"https://github.com/fuzzylite/fuzzylite/pull/83","diff_url":"https://github.com/fuzzylite/fuzzylite/pull/83.diff","patch_url":"https://github.com/fuzzylite/fuzzylite/pull/83.patch","issue_url":"https://api.github.com/repos/fuzzylite/fuzzylite/issues/83","number":83,"state":"open","locked":false,"title":"Build system fixes","user":{"login":"CJxD","id":1629692,"avatar_url":"https://avatars3.githubusercontent.com/u/1629692?v=4","gravatar_id":"","url":"https://api.github.com/users/CJxD","html_url":"https://github.com/CJxD","followers_url":"https://api.github.com/users/CJxD/followers","following_url":"https://api.github.com/users/CJxD/following{/other_user}","gists_url":"https://api.github.com/users/CJxD/gists{/gist_id}","starred_url":"https://api.github.com/users/CJxD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CJxD/subscriptions","organizations_url":"https://api.github.com/users/CJxD/orgs","repos_url":"https://api.github.com/users/CJxD/repos","events_url":"https://api.github.com/users/CJxD/events{/privacy}","received_events_url":"https://api.github.com/users/CJxD/received_events","type":"User","site_admin":false},"body":"The CMake configuration has been updated to allow for newer versions of CMake.\r\n\r\nThis update fixes compilation errors when including fuzzylite in other CMake projects. For example, you can now link against `fl-shared` thus:\r\n\r\n    project(Foo)\r\n    add_subdirectory(fuzzylite/fuzzylite)\r\n\r\n    add_executable(foo \"foo.cpp\")\r\n    target_link_libraries(foo fl-shared)\r\n    \r\nIt also exports `fuzzylite-config.cmake` during installation so it is detectable to CMake's `find_library()`.","created_at":"2017-11-07T22:34:49Z","updated_at":"2017-11-08T09:40:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f8c3934152c87228f823ddb64e118465418f9ed0","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/fuzzylite/fuzzylite/pulls/83/commits","review_comments_url":"https://api.github.com/repos/fuzzylite/fuzzylite/pulls/83/comments","review_comment_url":"https://api.github.com/repos/fuzzylite/fuzzylite/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fuzzylite/fuzzylite/issues/83/comments","statuses_url":"https://api.github.com/repos/fuzzylite/fuzzylite/statuses/2024598350ba09932d1f3363a0ddf3b93e836423","head":{"label":"CJxD:master","ref":"master","sha":"2024598350ba09932d1f3363a0ddf3b93e836423","user":{"login":"CJxD","id":1629692,"avatar_url":"https://avatars3.githubusercontent.com/u/1629692?v=4","gravatar_id":"","url":"https://api.github.com/users/CJxD","html_url":"https://github.com/CJxD","followers_url":"https://api.github.com/users/CJxD/followers","following_url":"https://api.github.com/users/CJxD/following{/other_user}","gists_url":"https://api.github.com/users/CJxD/gists{/gist_id}","starred_url":"https://api.github.com/users/CJxD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CJxD/subscriptions","organizations_url":"https://api.github.com/users/CJxD/orgs","repos_url":"https://api.github.com/users/CJxD/repos","events_url":"https://api.github.com/users/CJxD/events{/privacy}","received_events_url":"https://api.github.com/users/CJxD/received_events","type":"User","site_admin":false},"repo":{"id":109896633,"name":"fuzzylite","full_name":"CJxD/fuzzylite","owner":{"login":"CJxD","id":1629692,"avatar_url":"https://avatars3.githubusercontent.com/u/1629692?v=4","gravatar_id":"","url":"https://api.github.com/users/CJxD","html_url":"https://github.com/CJxD","followers_url":"https://api.github.com/users/CJxD/followers","following_url":"https://api.github.com/users/CJxD/following{/other_user}","gists_url":"https://api.github.com/users/CJxD/gists{/gist_id}","starred_url":"https://api.github.com/users/CJxD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CJxD/subscriptions","organizations_url":"https://api.github.com/users/CJxD/orgs","repos_url":"https://api.github.com/users/CJxD/repos","events_url":"https://api.github.com/users/CJxD/events{/privacy}","received_events_url":"https://api.github.com/users/CJxD/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/CJxD/fuzzylite","description":"fuzzylite: a fuzzy logic control library in C++","fork":true,"url":"https://api.github.com/repos/CJxD/fuzzylite","forks_url":"https://api.github.com/repos/CJxD/fuzzylite/forks","keys_url":"https://api.github.com/repos/CJxD/fuzzylite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CJxD/fuzzylite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CJxD/fuzzylite/teams","hooks_url":"https://api.github.com/repos/CJxD/fuzzylite/hooks","issue_events_url":"https://api.github.com/repos/CJxD/fuzzylite/issues/events{/number}","events_url":"https://api.github.com/repos/CJxD/fuzzylite/events","assignees_url":"https://api.github.com/repos/CJxD/fuzzylite/assignees{/user}","branches_url":"https://api.github.com/repos/CJxD/fuzzylite/branches{/branch}","tags_url":"https://api.github.com/repos/CJxD/fuzzylite/tags","blobs_url":"https://api.github.com/repos/CJxD/fuzzylite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CJxD/fuzzylite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CJxD/fuzzylite/git/refs{/sha}","trees_url":"https://api.github.com/repos/CJxD/fuzzylite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CJxD/fuzzylite/statuses/{sha}","languages_url":"https://api.github.com/repos/CJxD/fuzzylite/languages","stargazers_url":"https://api.github.com/repos/CJxD/fuzzylite/stargazers","contributors_url":"https://api.github.com/repos/CJxD/fuzzylite/contributors","subscribers_url":"https://api.github.com/repos/CJxD/fuzzylite/subscribers","subscription_url":"https://api.github.com/repos/CJxD/fuzzylite/subscription","commits_url":"https://api.github.com/repos/CJxD/fuzzylite/commits{/sha}","git_commits_url":"https://api.github.com/repos/CJxD/fuzzylite/git/commits{/sha}","comments_url":"https://api.github.com/repos/CJxD/fuzzylite/comments{/number}","issue_comment_url":"https://api.github.com/repos/CJxD/fuzzylite/issues/comments{/number}","contents_url":"https://api.github.com/repos/CJxD/fuzzylite/contents/{+path}","compare_url":"https://api.github.com/repos/CJxD/fuzzylite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CJxD/fuzzylite/merges","archive_url":"https://api.github.com/repos/CJxD/fuzzylite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CJxD/fuzzylite/downloads","issues_url":"https://api.github.com/repos/CJxD/fuzzylite/issues{/number}","pulls_url":"https://api.github.com/repos/CJxD/fuzzylite/pulls{/number}","milestones_url":"https://api.github.com/repos/CJxD/fuzzylite/milestones{/number}","notifications_url":"https://api.github.com/repos/CJxD/fuzzylite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CJxD/fuzzylite/labels{/name}","releases_url":"https://api.github.com/repos/CJxD/fuzzylite/releases{/id}","deployments_url":"https://api.github.com/repos/CJxD/fuzzylite/deployments","created_at":"2017-11-07T22:07:19Z","updated_at":"2017-11-07T22:07:21Z","pushed_at":"2017-11-07T22:21:51Z","git_url":"git://github.com/CJxD/fuzzylite.git","ssh_url":"git@github.com:CJxD/fuzzylite.git","clone_url":"https://github.com/CJxD/fuzzylite.git","svn_url":"https://github.com/CJxD/fuzzylite","homepage":"https://fuzzylite.com/","size":24342,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"release"}},"base":{"label":"fuzzylite:master","ref":"master","sha":"ba748c896748e00f1cfd9b9b8ec21b8625d9d267","user":{"login":"fuzzylite","id":7898712,"avatar_url":"https://avatars1.githubusercontent.com/u/7898712?v=4","gravatar_id":"","url":"https://api.github.com/users/fuzzylite","html_url":"https://github.com/fuzzylite","followers_url":"https://api.github.com/users/fuzzylite/followers","following_url":"https://api.github.com/users/fuzzylite/following{/other_user}","gists_url":"https://api.github.com/users/fuzzylite/gists{/gist_id}","starred_url":"https://api.github.com/users/fuzzylite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fuzzylite/subscriptions","organizations_url":"https://api.github.com/users/fuzzylite/orgs","repos_url":"https://api.github.com/users/fuzzylite/repos","events_url":"https://api.github.com/users/fuzzylite/events{/privacy}","received_events_url":"https://api.github.com/users/fuzzylite/received_events","type":"Organization","site_admin":false},"repo":{"id":20873570,"name":"fuzzylite","full_name":"fuzzylite/fuzzylite","owner":{"login":"fuzzylite","id":7898712,"avatar_url":"https://avatars1.githubusercontent.com/u/7898712?v=4","gravatar_id":"","url":"https://api.github.com/users/fuzzylite","html_url":"https://github.com/fuzzylite","followers_url":"https://api.github.com/users/fuzzylite/followers","following_url":"https://api.github.com/users/fuzzylite/following{/other_user}","gists_url":"https://api.github.com/users/fuzzylite/gists{/gist_id}","starred_url":"https://api.github.com/users/fuzzylite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fuzzylite/subscriptions","organizations_url":"https://api.github.com/users/fuzzylite/orgs","repos_url":"https://api.github.com/users/fuzzylite/repos","events_url":"https://api.github.com/users/fuzzylite/events{/privacy}","received_events_url":"https://api.github.com/users/fuzzylite/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fuzzylite/fuzzylite","description":"fuzzylite: a fuzzy logic control library in C++","fork":false,"url":"https://api.github.com/repos/fuzzylite/fuzzylite","forks_url":"https://api.github.com/repos/fuzzylite/fuzzylite/forks","keys_url":"https://api.github.com/repos/fuzzylite/fuzzylite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fuzzylite/fuzzylite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fuzzylite/fuzzylite/teams","hooks_url":"https://api.github.com/repos/fuzzylite/fuzzylite/hooks","issue_events_url":"https://api.github.com/repos/fuzzylite/fuzzylite/issues/events{/number}","events_url":"https://api.github.com/repos/fuzzylite/fuzzylite/events","assignees_url":"https://api.github.com/repos/fuzzylite/fuzzylite/assignees{/user}","branches_url":"https://api.github.com/repos/fuzzylite/fuzzylite/branches{/branch}","tags_url":"https://api.github.com/repos/fuzzylite/fuzzylite/tags","blobs_url":"https://api.github.com/repos/fuzzylite/fuzzylite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fuzzylite/fuzzylite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fuzzylite/fuzzylite/git/refs{/sha}","trees_url":"https://api.github.com/repos/fuzzylite/fuzzylite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fuzzylite/fuzzylite/statuses/{sha}","languages_url":"https://api.github.com/repos/fuzzylite/fuzzylite/languages","stargazers_url":"https://api.github.com/repos/fuzzylite/fuzzylite/stargazers","contributors_url":"https://api.github.com/repos/fuzzylite/fuzzylite/contributors","subscribers_url":"https://api.github.com/repos/fuzzylite/fuzzylite/subscribers","subscription_url":"https://api.github.com/repos/fuzzylite/fuzzylite/subscription","commits_url":"https://api.github.com/repos/fuzzylite/fuzzylite/commits{/sha}","git_commits_url":"https://api.github.com/repos/fuzzylite/fuzzylite/git/commits{/sha}","comments_url":"https://api.github.com/repos/fuzzylite/fuzzylite/comments{/number}","issue_comment_url":"https://api.github.com/repos/fuzzylite/fuzzylite/issues/comments{/number}","contents_url":"https://api.github.com/repos/fuzzylite/fuzzylite/contents/{+path}","compare_url":"https://api.github.com/repos/fuzzylite/fuzzylite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fuzzylite/fuzzylite/merges","archive_url":"https://api.github.com/repos/fuzzylite/fuzzylite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fuzzylite/fuzzylite/downloads","issues_url":"https://api.github.com/repos/fuzzylite/fuzzylite/issues{/number}","pulls_url":"https://api.github.com/repos/fuzzylite/fuzzylite/pulls{/number}","milestones_url":"https://api.github.com/repos/fuzzylite/fuzzylite/milestones{/number}","notifications_url":"https://api.github.com/repos/fuzzylite/fuzzylite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fuzzylite/fuzzylite/labels{/name}","releases_url":"https://api.github.com/repos/fuzzylite/fuzzylite/releases{/id}","deployments_url":"https://api.github.com/repos/fuzzylite/fuzzylite/deployments","created_at":"2014-06-16T05:17:44Z","updated_at":"2017-10-31T12:33:36Z","pushed_at":"2017-11-07T22:34:50Z","git_url":"git://github.com/fuzzylite/fuzzylite.git","ssh_url":"git@github.com:fuzzylite/fuzzylite.git","clone_url":"https://github.com/fuzzylite/fuzzylite.git","svn_url":"https://github.com/fuzzylite/fuzzylite","homepage":"https://fuzzylite.com/","size":24341,"stargazers_count":101,"watchers_count":101,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":35,"mirror_url":null,"archived":false,"open_issues_count":6,"forks":35,"open_issues":6,"watchers":101,"default_branch":"release"}},"_links":{"self":{"href":"https://api.github.com/repos/fuzzylite/fuzzylite/pulls/83"},"html":{"href":"https://github.com/fuzzylite/fuzzylite/pull/83"},"issue":{"href":"https://api.github.com/repos/fuzzylite/fuzzylite/issues/83"},"comments":{"href":"https://api.github.com/repos/fuzzylite/fuzzylite/issues/83/comments"},"review_comments":{"href":"https://api.github.com/repos/fuzzylite/fuzzylite/pulls/83/comments"},"review_comment":{"href":"https://api.github.com/repos/fuzzylite/fuzzylite/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fuzzylite/fuzzylite/pulls/83/commits"},"statuses":{"href":"https://api.github.com/repos/fuzzylite/fuzzylite/statuses/2024598350ba09932d1f3363a0ddf3b93e836423"}},"author_association":"NONE"}}
{"actor":{"display_login":"jcrada"}}