{"action":"opened","number":974,"pull_request":{"url":"https://api.github.com/repos/Radarr/Radarr/pulls/974","id":108682626,"html_url":"https://github.com/Radarr/Radarr/pull/974","diff_url":"https://github.com/Radarr/Radarr/pull/974.diff","patch_url":"https://github.com/Radarr/Radarr/pull/974.patch","issue_url":"https://api.github.com/repos/Radarr/Radarr/issues/974","number":974,"state":"open","locked":false,"title":"revert some changes -- use FullCollection (maybe just for now)","user":{"login":"geogolem","id":23205277,"avatar_url":"https://avatars1.githubusercontent.com/u/23205277?v=3","gravatar_id":"","url":"https://api.github.com/users/geogolem","html_url":"https://github.com/geogolem","followers_url":"https://api.github.com/users/geogolem/followers","following_url":"https://api.github.com/users/geogolem/following{/other_user}","gists_url":"https://api.github.com/users/geogolem/gists{/gist_id}","starred_url":"https://api.github.com/users/geogolem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geogolem/subscriptions","organizations_url":"https://api.github.com/users/geogolem/orgs","repos_url":"https://api.github.com/users/geogolem/repos","events_url":"https://api.github.com/users/geogolem/events{/privacy}","received_events_url":"https://api.github.com/users/geogolem/received_events","type":"User","site_admin":false},"body":"#### Database Migration\r\n NO\r\n\r\n#### Description\r\nthis reverts some changes from previous merge.... fixes the filters in the movieEditor Index... \r\n\r\n\"So two issues with this now!\r\n\r\nin the movieEditor... saving across pages: no problem.... save across filters... well, the save will work... everything selected will be saved... but, only entries corresponding to movies in the currently visible filter will be reflected in the table.... of course on a refresh.. they will be visible....\r\n\r\nThere are two solutions to this problem. The obvious one --> when we save, fetch the collection.. but since this is in client mode it has to fetch the entire collection.. so, this could mean that old values will be visible in the table for quite some time until they are fetched...... (this is only for items that were selected, but at the time of saving, were not on the visible filter)... paging is fine.. even if items are selected on other pages.. the changes will be reflected in the table immediaetly......\r\n\r\ni suppose the other solution, would be to switch to filtermode ALL... just prior to saving.... then switch back to the desired filter.... if the filtering is done client side, this would be really fast... i think...\r\n\r\nanyway/// i think i worked out alot of buugs.. and i reverted some previous changes that werent necessary.. at least at this time...\r\n\r\nPlease let me know what you think and if you encounter any problems...\"\r\n\r\n#### Todos\r\n- [ ] Tests\r\n\r\n#### Issues Fixed or Closed by this PR\r\nhttps://cloud.githubusercontent.com/assets/23205277/23457045/0de26fac-fe44-11e6-84b6-c32ba84ae9b0.png\r\n* #\r\n","created_at":"2017-03-02T04:04:36Z","updated_at":"2017-03-02T04:04:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Radarr/Radarr/pulls/974/commits","review_comments_url":"https://api.github.com/repos/Radarr/Radarr/pulls/974/comments","review_comment_url":"https://api.github.com/repos/Radarr/Radarr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Radarr/Radarr/issues/974/comments","statuses_url":"https://api.github.com/repos/Radarr/Radarr/statuses/897d76c4a2aa974a6d3f9783d3ea021bff2d2184","head":{"label":"geogolem:MovieEditorFixes","ref":"MovieEditorFixes","sha":"897d76c4a2aa974a6d3f9783d3ea021bff2d2184","user":{"login":"geogolem","id":23205277,"avatar_url":"https://avatars1.githubusercontent.com/u/23205277?v=3","gravatar_id":"","url":"https://api.github.com/users/geogolem","html_url":"https://github.com/geogolem","followers_url":"https://api.github.com/users/geogolem/followers","following_url":"https://api.github.com/users/geogolem/following{/other_user}","gists_url":"https://api.github.com/users/geogolem/gists{/gist_id}","starred_url":"https://api.github.com/users/geogolem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geogolem/subscriptions","organizations_url":"https://api.github.com/users/geogolem/orgs","repos_url":"https://api.github.com/users/geogolem/repos","events_url":"https://api.github.com/users/geogolem/events{/privacy}","received_events_url":"https://api.github.com/users/geogolem/received_events","type":"User","site_admin":false},"repo":{"id":80756138,"name":"Radarr","full_name":"geogolem/Radarr","owner":{"login":"geogolem","id":23205277,"avatar_url":"https://avatars1.githubusercontent.com/u/23205277?v=3","gravatar_id":"","url":"https://api.github.com/users/geogolem","html_url":"https://github.com/geogolem","followers_url":"https://api.github.com/users/geogolem/followers","following_url":"https://api.github.com/users/geogolem/following{/other_user}","gists_url":"https://api.github.com/users/geogolem/gists{/gist_id}","starred_url":"https://api.github.com/users/geogolem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geogolem/subscriptions","organizations_url":"https://api.github.com/users/geogolem/orgs","repos_url":"https://api.github.com/users/geogolem/repos","events_url":"https://api.github.com/users/geogolem/events{/privacy}","received_events_url":"https://api.github.com/users/geogolem/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/geogolem/Radarr","description":"A fork of Sonarr to work with movies à la Couchpotato.","fork":true,"url":"https://api.github.com/repos/geogolem/Radarr","forks_url":"https://api.github.com/repos/geogolem/Radarr/forks","keys_url":"https://api.github.com/repos/geogolem/Radarr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/geogolem/Radarr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/geogolem/Radarr/teams","hooks_url":"https://api.github.com/repos/geogolem/Radarr/hooks","issue_events_url":"https://api.github.com/repos/geogolem/Radarr/issues/events{/number}","events_url":"https://api.github.com/repos/geogolem/Radarr/events","assignees_url":"https://api.github.com/repos/geogolem/Radarr/assignees{/user}","branches_url":"https://api.github.com/repos/geogolem/Radarr/branches{/branch}","tags_url":"https://api.github.com/repos/geogolem/Radarr/tags","blobs_url":"https://api.github.com/repos/geogolem/Radarr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/geogolem/Radarr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/geogolem/Radarr/git/refs{/sha}","trees_url":"https://api.github.com/repos/geogolem/Radarr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/geogolem/Radarr/statuses/{sha}","languages_url":"https://api.github.com/repos/geogolem/Radarr/languages","stargazers_url":"https://api.github.com/repos/geogolem/Radarr/stargazers","contributors_url":"https://api.github.com/repos/geogolem/Radarr/contributors","subscribers_url":"https://api.github.com/repos/geogolem/Radarr/subscribers","subscription_url":"https://api.github.com/repos/geogolem/Radarr/subscription","commits_url":"https://api.github.com/repos/geogolem/Radarr/commits{/sha}","git_commits_url":"https://api.github.com/repos/geogolem/Radarr/git/commits{/sha}","comments_url":"https://api.github.com/repos/geogolem/Radarr/comments{/number}","issue_comment_url":"https://api.github.com/repos/geogolem/Radarr/issues/comments{/number}","contents_url":"https://api.github.com/repos/geogolem/Radarr/contents/{+path}","compare_url":"https://api.github.com/repos/geogolem/Radarr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/geogolem/Radarr/merges","archive_url":"https://api.github.com/repos/geogolem/Radarr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/geogolem/Radarr/downloads","issues_url":"https://api.github.com/repos/geogolem/Radarr/issues{/number}","pulls_url":"https://api.github.com/repos/geogolem/Radarr/pulls{/number}","milestones_url":"https://api.github.com/repos/geogolem/Radarr/milestones{/number}","notifications_url":"https://api.github.com/repos/geogolem/Radarr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/geogolem/Radarr/labels{/name}","releases_url":"https://api.github.com/repos/geogolem/Radarr/releases{/id}","deployments_url":"https://api.github.com/repos/geogolem/Radarr/deployments","created_at":"2017-02-02T18:36:53Z","updated_at":"2017-02-02T18:37:06Z","pushed_at":"2017-03-02T03:59:42Z","git_url":"git://github.com/geogolem/Radarr.git","ssh_url":"git@github.com:geogolem/Radarr.git","clone_url":"https://github.com/geogolem/Radarr.git","svn_url":"https://github.com/geogolem/Radarr","homepage":"https://radarr.video","size":232389,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"Radarr:develop","ref":"develop","sha":"349dd12161b3f583a072321a88851561797806e8","user":{"login":"Radarr","id":25025331,"avatar_url":"https://avatars3.githubusercontent.com/u/25025331?v=3","gravatar_id":"","url":"https://api.github.com/users/Radarr","html_url":"https://github.com/Radarr","followers_url":"https://api.github.com/users/Radarr/followers","following_url":"https://api.github.com/users/Radarr/following{/other_user}","gists_url":"https://api.github.com/users/Radarr/gists{/gist_id}","starred_url":"https://api.github.com/users/Radarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Radarr/subscriptions","organizations_url":"https://api.github.com/users/Radarr/orgs","repos_url":"https://api.github.com/users/Radarr/repos","events_url":"https://api.github.com/users/Radarr/events{/privacy}","received_events_url":"https://api.github.com/users/Radarr/received_events","type":"Organization","site_admin":false},"repo":{"id":77323220,"name":"Radarr","full_name":"Radarr/Radarr","owner":{"login":"Radarr","id":25025331,"avatar_url":"https://avatars3.githubusercontent.com/u/25025331?v=3","gravatar_id":"","url":"https://api.github.com/users/Radarr","html_url":"https://github.com/Radarr","followers_url":"https://api.github.com/users/Radarr/followers","following_url":"https://api.github.com/users/Radarr/following{/other_user}","gists_url":"https://api.github.com/users/Radarr/gists{/gist_id}","starred_url":"https://api.github.com/users/Radarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Radarr/subscriptions","organizations_url":"https://api.github.com/users/Radarr/orgs","repos_url":"https://api.github.com/users/Radarr/repos","events_url":"https://api.github.com/users/Radarr/events{/privacy}","received_events_url":"https://api.github.com/users/Radarr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Radarr/Radarr","description":"A fork of Sonarr to work with movies à la Couchpotato.","fork":false,"url":"https://api.github.com/repos/Radarr/Radarr","forks_url":"https://api.github.com/repos/Radarr/Radarr/forks","keys_url":"https://api.github.com/repos/Radarr/Radarr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Radarr/Radarr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Radarr/Radarr/teams","hooks_url":"https://api.github.com/repos/Radarr/Radarr/hooks","issue_events_url":"https://api.github.com/repos/Radarr/Radarr/issues/events{/number}","events_url":"https://api.github.com/repos/Radarr/Radarr/events","assignees_url":"https://api.github.com/repos/Radarr/Radarr/assignees{/user}","branches_url":"https://api.github.com/repos/Radarr/Radarr/branches{/branch}","tags_url":"https://api.github.com/repos/Radarr/Radarr/tags","blobs_url":"https://api.github.com/repos/Radarr/Radarr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Radarr/Radarr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Radarr/Radarr/git/refs{/sha}","trees_url":"https://api.github.com/repos/Radarr/Radarr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Radarr/Radarr/statuses/{sha}","languages_url":"https://api.github.com/repos/Radarr/Radarr/languages","stargazers_url":"https://api.github.com/repos/Radarr/Radarr/stargazers","contributors_url":"https://api.github.com/repos/Radarr/Radarr/contributors","subscribers_url":"https://api.github.com/repos/Radarr/Radarr/subscribers","subscription_url":"https://api.github.com/repos/Radarr/Radarr/subscription","commits_url":"https://api.github.com/repos/Radarr/Radarr/commits{/sha}","git_commits_url":"https://api.github.com/repos/Radarr/Radarr/git/commits{/sha}","comments_url":"https://api.github.com/repos/Radarr/Radarr/comments{/number}","issue_comment_url":"https://api.github.com/repos/Radarr/Radarr/issues/comments{/number}","contents_url":"https://api.github.com/repos/Radarr/Radarr/contents/{+path}","compare_url":"https://api.github.com/repos/Radarr/Radarr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Radarr/Radarr/merges","archive_url":"https://api.github.com/repos/Radarr/Radarr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Radarr/Radarr/downloads","issues_url":"https://api.github.com/repos/Radarr/Radarr/issues{/number}","pulls_url":"https://api.github.com/repos/Radarr/Radarr/pulls{/number}","milestones_url":"https://api.github.com/repos/Radarr/Radarr/milestones{/number}","notifications_url":"https://api.github.com/repos/Radarr/Radarr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Radarr/Radarr/labels{/name}","releases_url":"https://api.github.com/repos/Radarr/Radarr/releases{/id}","deployments_url":"https://api.github.com/repos/Radarr/Radarr/deployments","created_at":"2016-12-25T11:38:26Z","updated_at":"2017-03-02T01:49:10Z","pushed_at":"2017-03-02T02:22:40Z","git_url":"git://github.com/Radarr/Radarr.git","ssh_url":"git@github.com:Radarr/Radarr.git","clone_url":"https://github.com/Radarr/Radarr.git","svn_url":"https://github.com/Radarr/Radarr","homepage":"https://radarr.video","size":231912,"stargazers_count":643,"watchers_count":643,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":60,"mirror_url":null,"open_issues_count":168,"forks":60,"open_issues":168,"watchers":643,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Radarr/Radarr/pulls/974"},"html":{"href":"https://github.com/Radarr/Radarr/pull/974"},"issue":{"href":"https://api.github.com/repos/Radarr/Radarr/issues/974"},"comments":{"href":"https://api.github.com/repos/Radarr/Radarr/issues/974/comments"},"review_comments":{"href":"https://api.github.com/repos/Radarr/Radarr/pulls/974/comments"},"review_comment":{"href":"https://api.github.com/repos/Radarr/Radarr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Radarr/Radarr/pulls/974/commits"},"statuses":{"href":"https://api.github.com/repos/Radarr/Radarr/statuses/897d76c4a2aa974a6d3f9783d3ea021bff2d2184"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":102,"deletions":84,"changed_files":10}}
{"actor":{"display_login":"geogolem"}}