{"action":"created","issue":{"url":"https://api.github.com/repos/linuxkit/linuxkit/issues/1715","repository_url":"https://api.github.com/repos/linuxkit/linuxkit","labels_url":"https://api.github.com/repos/linuxkit/linuxkit/issues/1715/labels{/name}","comments_url":"https://api.github.com/repos/linuxkit/linuxkit/issues/1715/comments","events_url":"https://api.github.com/repos/linuxkit/linuxkit/issues/1715/events","html_url":"https://github.com/linuxkit/linuxkit/pull/1715","id":224361316,"number":1715,"title":"First cut of swap image and example","user":{"login":"deitch","id":282526,"avatar_url":"https://avatars0.githubusercontent.com/u/282526?v=3","gravatar_id":"","url":"https://api.github.com/users/deitch","html_url":"https://github.com/deitch","followers_url":"https://api.github.com/users/deitch/followers","following_url":"https://api.github.com/users/deitch/following{/other_user}","gists_url":"https://api.github.com/users/deitch/gists{/gist_id}","starred_url":"https://api.github.com/users/deitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deitch/subscriptions","organizations_url":"https://api.github.com/users/deitch/orgs","repos_url":"https://api.github.com/users/deitch/repos","events_url":"https://api.github.com/users/deitch/events{/privacy}","received_events_url":"https://api.github.com/users/deitch/received_events","type":"User","site_admin":false},"labels":[{"id":572728714,"url":"https://api.github.com/repos/linuxkit/linuxkit/labels/status/0-triage","name":"status/0-triage","color":"eeeeee","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":15,"created_at":"2017-04-26T06:49:37Z","updated_at":"2017-04-28T05:38:37Z","closed_at":"2017-04-26T20:47:54Z","pull_request":{"url":"https://api.github.com/repos/linuxkit/linuxkit/pulls/1715","html_url":"https://github.com/linuxkit/linuxkit/pull/1715","diff_url":"https://github.com/linuxkit/linuxkit/pull/1715.diff","patch_url":"https://github.com/linuxkit/linuxkit/pull/1715.patch"},"body":"<!--\r\nPlease make sure you've read and understood our contributing guidelines;\r\nhttps://github.com/linuxkit/linuxkit/blob/master/CONTRIBUTING.md\r\n\r\n** Make sure all your commits include a signature generated with `git commit -s` **\r\n\r\nFor additional information on our contributing process, read our contributing\r\nguide https://docs.docker.com/opensource/code/\r\n\r\nIf this is a bug fix, make sure your description includes \"fixes #xxxx\", or\r\n\"closes #xxxx\"\r\n\r\nPlease provide the following information:\r\n-->\r\n\r\n**- What I did**\r\n\r\nAdd support for creating swap files in linuxkit image\r\n\r\n**- How I did it**\r\n\r\nadd onboot image `linuxkit/swap`, which contains script to read params and set up swapfile\r\n\r\n**- How to verify it**\r\n\r\nRun with various options:\r\n\r\n* no `--path` provided\r\n* invalid swapfile\r\n* no mounted disk (cannot use in `/var` because it is tmpfs\r\n* disk too small\r\n* check conditions\r\n\r\n**- Description for the changelog**\r\nAdd image with support for swapfiles to be used in onboot\r\n\r\n**- A picture of a cute animal (not mandatory but encouraged)**\r\n![eclectus](https://upload.wikimedia.org/wikipedia/commons/thumb/1/11/Eclectus_roratus_-Bali_Zoo%2C_Indonesia_-male-8a.jpg/800px-Eclectus_roratus_-Bali_Zoo%2C_Indonesia_-male-8a.jpg)\r\n\r\n\r\n** Notes **\r\n1. I used the Makefile from [pkg/mount](https://github.com/linuxkit/linuxkit/tree/master/pkg/mount) as a template. I was unsure the level of adherence to the shahash versioning scheme, but figured something that already is in and is similar is a good start.\r\n2. Needs encryption support, which will come when devmapper works. See https://github.com/linuxkit/linuxkit/issues/1689\r\n3. Closes https://github.com/linuxkit/linuxkit/issues/1694 per @justincormack \r\n"},"comment":{"url":"https://api.github.com/repos/linuxkit/linuxkit/issues/comments/297911694","html_url":"https://github.com/linuxkit/linuxkit/pull/1715#issuecomment-297911694","issue_url":"https://api.github.com/repos/linuxkit/linuxkit/issues/1715","id":297911694,"user":{"login":"thaJeztah","id":1804568,"avatar_url":"https://avatars1.githubusercontent.com/u/1804568?v=3","gravatar_id":"","url":"https://api.github.com/users/thaJeztah","html_url":"https://github.com/thaJeztah","followers_url":"https://api.github.com/users/thaJeztah/followers","following_url":"https://api.github.com/users/thaJeztah/following{/other_user}","gists_url":"https://api.github.com/users/thaJeztah/gists{/gist_id}","starred_url":"https://api.github.com/users/thaJeztah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thaJeztah/subscriptions","organizations_url":"https://api.github.com/users/thaJeztah/orgs","repos_url":"https://api.github.com/users/thaJeztah/repos","events_url":"https://api.github.com/users/thaJeztah/events{/privacy}","received_events_url":"https://api.github.com/users/thaJeztah/received_events","type":"User","site_admin":false},"created_at":"2017-04-28T05:38:37Z","updated_at":"2017-04-28T05:38:37Z","body":"The \"cute animal\" picture was a tradition started by @calavera. Decided to continue the tradition here as it makes pull requests a lot more fun to review; you can view them all on Twitter here; https://twitter.com/DockerCuties"}}
{"actor":{"display_login":"thaJeztah"}}