{"action":"created","issue":{"url":"https://api.github.com/repos/eddelbuettel/nanotime/issues/11","repository_url":"https://api.github.com/repos/eddelbuettel/nanotime","labels_url":"https://api.github.com/repos/eddelbuettel/nanotime/issues/11/labels{/name}","comments_url":"https://api.github.com/repos/eddelbuettel/nanotime/issues/11/comments","events_url":"https://api.github.com/repos/eddelbuettel/nanotime/issues/11/events","html_url":"https://github.com/eddelbuettel/nanotime/issues/11","id":204159480,"number":11,"title":"format.nanotime: attribute 'tzone' and parameters 'format' and 'tz'","user":{"login":"lsilvest","id":25395372,"avatar_url":"https://avatars3.githubusercontent.com/u/25395372?v=3","gravatar_id":"","url":"https://api.github.com/users/lsilvest","html_url":"https://github.com/lsilvest","followers_url":"https://api.github.com/users/lsilvest/followers","following_url":"https://api.github.com/users/lsilvest/following{/other_user}","gists_url":"https://api.github.com/users/lsilvest/gists{/gist_id}","starred_url":"https://api.github.com/users/lsilvest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsilvest/subscriptions","organizations_url":"https://api.github.com/users/lsilvest/orgs","repos_url":"https://api.github.com/users/lsilvest/repos","events_url":"https://api.github.com/users/lsilvest/events{/privacy}","received_events_url":"https://api.github.com/users/lsilvest/received_events","type":"User","site_admin":false},"labels":[{"id":498068266,"url":"https://api.github.com/repos/eddelbuettel/nanotime/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":498068267,"url":"https://api.github.com/repos/eddelbuettel/nanotime/labels/help%20wanted","name":"help wanted","color":"128A0C","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":19,"created_at":"2017-01-30T23:17:36Z","updated_at":"2017-05-02T15:04:43Z","closed_at":null,"body":"Having format.nanotime behave like format.POSIXct would make it easier to replace POSIXct by nanotime. One specific example is for the 'xts' package."},"comment":{"url":"https://api.github.com/repos/eddelbuettel/nanotime/issues/comments/298662988","html_url":"https://github.com/eddelbuettel/nanotime/issues/11#issuecomment-298662988","issue_url":"https://api.github.com/repos/eddelbuettel/nanotime/issues/11","id":298662988,"user":{"login":"lsilvest","id":25395372,"avatar_url":"https://avatars3.githubusercontent.com/u/25395372?v=3","gravatar_id":"","url":"https://api.github.com/users/lsilvest","html_url":"https://github.com/lsilvest","followers_url":"https://api.github.com/users/lsilvest/followers","following_url":"https://api.github.com/users/lsilvest/following{/other_user}","gists_url":"https://api.github.com/users/lsilvest/gists{/gist_id}","starred_url":"https://api.github.com/users/lsilvest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsilvest/subscriptions","organizations_url":"https://api.github.com/users/lsilvest/orgs","repos_url":"https://api.github.com/users/lsilvest/repos","events_url":"https://api.github.com/users/lsilvest/events{/privacy}","received_events_url":"https://api.github.com/users/lsilvest/received_events","type":"User","site_admin":false},"created_at":"2017-05-02T15:04:43Z","updated_at":"2017-05-02T15:04:43Z","body":"I think it's correct that `tz` and `format` should be parameters in the constructors where appropriate.\r\n\r\nAutomatic comparison to strings is in my opinion always going to be too difficult, precisely because of formatting. As you pointed out, that's the same issue with `POSIXct` (and additionally `POSIXct` will silently drop a time zone specification in a `character`). I think there's a trade-off between the flexibility/comfort of working and the reliability/portability. \r\n\r\n@vspinu is saying that if you call `format.nanotime` explicitly setting `tz=\"\"`, the time zone is not set by `format.nanotime`. I suppose a user would expect explicitly setting `tz=\"\"` to behave as if he hadn't set it at all, so I think it's a valid point. "}}
{"actor":{"display_login":"lsilvest"}}