{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/pulls/comments/128377683","pull_request_review_id":51052506,"id":128377683,"diff_hunk":"@@ -1,58 +1,92 @@\n ﻿// Copyright (c) Microsoft Corporation. All rights reserved.\n // Licensed under the MIT License. See LICENSE in the project root for license information.\n \n-using System;\n+using GLTF;\n+using System.Collections;\n using System.Collections.Generic;\n using UnityEngine;\n-using UnityEngine.VR.WSA.Input;\n+#if !UNITY_EDITOR && UNITY_WSA\n+using Windows.Foundation;\n+using Windows.Storage.Streams;\n+using Windows.UI.Input.Spatial;\n+#endif\n \n namespace HoloToolkit.Unity.InputModule\n {\n     /// <summary>\n     /// This script spawns a specific GameObject when a controller is detected\n-    /// and animates the controller position and rotation.\n+    /// and animates the controller position, rotation, button presses, and\n+    /// thumbstick/touchpad interactions, where applicable.\n     /// </summary>\n     [RequireComponent(typeof(SetGlobalListener))]\n-    public class ControllerVisualizer : MonoBehaviour, ISourceStateHandler, ISourceRotationHandler, ISourcePositionHandler\n+    public class ControllerVisualizer : MonoBehaviour, ISourcePositionHandler, ISourceRotationHandler\n     {\n         [Tooltip(\"Use a model with the tip in the positive Z direction and the front face in the positive Y direction.\")]\n         [SerializeField]\n-        private GameObject controllerModel;\n+        protected GameObject leftControllerOverride;\n+        [Tooltip(\"Use a model with the tip in the positive Z direction and the front face in the positive Y direction.\")]","path":"Assets/HoloToolkit/Input/Scripts/ControllerVisualizer.cs","position":32,"original_position":32,"commit_id":"7cebc00ae93c58fa69b1b2e00fc25e4fafdf7f0c","original_commit_id":"ac9fb91113b370ed631599f17dbe707527919472","user":{"login":"keveleigh","id":3580640,"avatar_url":"https://avatars2.githubusercontent.com/u/3580640?v=4","gravatar_id":"","url":"https://api.github.com/users/keveleigh","html_url":"https://github.com/keveleigh","followers_url":"https://api.github.com/users/keveleigh/followers","following_url":"https://api.github.com/users/keveleigh/following{/other_user}","gists_url":"https://api.github.com/users/keveleigh/gists{/gist_id}","starred_url":"https://api.github.com/users/keveleigh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keveleigh/subscriptions","organizations_url":"https://api.github.com/users/keveleigh/orgs","repos_url":"https://api.github.com/users/keveleigh/repos","events_url":"https://api.github.com/users/keveleigh/events{/privacy}","received_events_url":"https://api.github.com/users/keveleigh/received_events","type":"User","site_admin":false},"body":"Yep, that's correct. I can clarify left/right, but I figured the GameObject names were sufficient. ","created_at":"2017-07-19T21:52:57Z","updated_at":"2017-07-19T21:52:58Z","html_url":"https://github.com/Microsoft/HoloToolkit-Unity/pull/793#discussion_r128377683","pull_request_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/pulls/793","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/pulls/comments/128377683"},"html":{"href":"https://github.com/Microsoft/HoloToolkit-Unity/pull/793#discussion_r128377683"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/pulls/793"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/pulls/793","id":131215137,"html_url":"https://github.com/Microsoft/HoloToolkit-Unity/pull/793","diff_url":"https://github.com/Microsoft/HoloToolkit-Unity/pull/793.diff","patch_url":"https://github.com/Microsoft/HoloToolkit-Unity/pull/793.patch","issue_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/issues/793","number":793,"state":"open","locked":false,"title":"[RS3] Adding support to load the native glTF model for controllers","user":{"login":"keveleigh","id":3580640,"avatar_url":"https://avatars2.githubusercontent.com/u/3580640?v=4","gravatar_id":"","url":"https://api.github.com/users/keveleigh","html_url":"https://github.com/keveleigh","followers_url":"https://api.github.com/users/keveleigh/followers","following_url":"https://api.github.com/users/keveleigh/following{/other_user}","gists_url":"https://api.github.com/users/keveleigh/gists{/gist_id}","starred_url":"https://api.github.com/users/keveleigh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keveleigh/subscriptions","organizations_url":"https://api.github.com/users/keveleigh/orgs","repos_url":"https://api.github.com/users/keveleigh/repos","events_url":"https://api.github.com/users/keveleigh/events{/privacy}","received_events_url":"https://api.github.com/users/keveleigh/received_events","type":"User","site_admin":false},"body":"This PR adds code to load a motion controller's renderable [GLTF](https://www.khronos.org/gltf) model, if applicable. It also provides a way to override that model with a specified GameObject.\r\n\r\nThe MotionControllerTest scene has been provided to show debug information about the connected motion controllers, as well as to show use of the visualizer script.\r\n\r\nThis PR also adds the GLTF parser and loader from https://github.com/AltspaceVR/UnityGLTF, in order to render the data stream provided by the API.\r\n\r\nNOTE: These APIs require the use of the [Windows Insider Preview SDK](https://www.microsoft.com/en-us/software-download/windowsinsiderpreviewSDK), build 16232 or newer.","created_at":"2017-07-19T00:33:29Z","updated_at":"2017-07-19T21:52:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6cd302056b37a7b7eb2efa2a8e104c6dfe376910","assignee":{"login":"keveleigh","id":3580640,"avatar_url":"https://avatars2.githubusercontent.com/u/3580640?v=4","gravatar_id":"","url":"https://api.github.com/users/keveleigh","html_url":"https://github.com/keveleigh","followers_url":"https://api.github.com/users/keveleigh/followers","following_url":"https://api.github.com/users/keveleigh/following{/other_user}","gists_url":"https://api.github.com/users/keveleigh/gists{/gist_id}","starred_url":"https://api.github.com/users/keveleigh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keveleigh/subscriptions","organizations_url":"https://api.github.com/users/keveleigh/orgs","repos_url":"https://api.github.com/users/keveleigh/repos","events_url":"https://api.github.com/users/keveleigh/events{/privacy}","received_events_url":"https://api.github.com/users/keveleigh/received_events","type":"User","site_admin":false},"assignees":[{"login":"keveleigh","id":3580640,"avatar_url":"https://avatars2.githubusercontent.com/u/3580640?v=4","gravatar_id":"","url":"https://api.github.com/users/keveleigh","html_url":"https://github.com/keveleigh","followers_url":"https://api.github.com/users/keveleigh/followers","following_url":"https://api.github.com/users/keveleigh/following{/other_user}","gists_url":"https://api.github.com/users/keveleigh/gists{/gist_id}","starred_url":"https://api.github.com/users/keveleigh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keveleigh/subscriptions","organizations_url":"https://api.github.com/users/keveleigh/orgs","repos_url":"https://api.github.com/users/keveleigh/repos","events_url":"https://api.github.com/users/keveleigh/events{/privacy}","received_events_url":"https://api.github.com/users/keveleigh/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/pulls/793/commits","review_comments_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/pulls/793/comments","review_comment_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/issues/793/comments","statuses_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/statuses/7cebc00ae93c58fa69b1b2e00fc25e4fafdf7f0c","head":{"label":"keveleigh:ControllerModelRS3","ref":"ControllerModelRS3","sha":"7cebc00ae93c58fa69b1b2e00fc25e4fafdf7f0c","user":{"login":"keveleigh","id":3580640,"avatar_url":"https://avatars2.githubusercontent.com/u/3580640?v=4","gravatar_id":"","url":"https://api.github.com/users/keveleigh","html_url":"https://github.com/keveleigh","followers_url":"https://api.github.com/users/keveleigh/followers","following_url":"https://api.github.com/users/keveleigh/following{/other_user}","gists_url":"https://api.github.com/users/keveleigh/gists{/gist_id}","starred_url":"https://api.github.com/users/keveleigh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keveleigh/subscriptions","organizations_url":"https://api.github.com/users/keveleigh/orgs","repos_url":"https://api.github.com/users/keveleigh/repos","events_url":"https://api.github.com/users/keveleigh/events{/privacy}","received_events_url":"https://api.github.com/users/keveleigh/received_events","type":"User","site_admin":false},"repo":{"id":93100892,"name":"HoloToolkit-Unity","full_name":"keveleigh/HoloToolkit-Unity","owner":{"login":"keveleigh","id":3580640,"avatar_url":"https://avatars2.githubusercontent.com/u/3580640?v=4","gravatar_id":"","url":"https://api.github.com/users/keveleigh","html_url":"https://github.com/keveleigh","followers_url":"https://api.github.com/users/keveleigh/followers","following_url":"https://api.github.com/users/keveleigh/following{/other_user}","gists_url":"https://api.github.com/users/keveleigh/gists{/gist_id}","starred_url":"https://api.github.com/users/keveleigh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keveleigh/subscriptions","organizations_url":"https://api.github.com/users/keveleigh/orgs","repos_url":"https://api.github.com/users/keveleigh/repos","events_url":"https://api.github.com/users/keveleigh/events{/privacy}","received_events_url":"https://api.github.com/users/keveleigh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/keveleigh/HoloToolkit-Unity","description":"This is effectively part of the existing HoloToolkit, but is the repo that will contain all Unity specific components.","fork":true,"url":"https://api.github.com/repos/keveleigh/HoloToolkit-Unity","forks_url":"https://api.github.com/repos/keveleigh/HoloToolkit-Unity/forks","keys_url":"https://api.github.com/repos/keveleigh/HoloToolkit-Unity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keveleigh/HoloToolkit-Unity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keveleigh/HoloToolkit-Unity/teams","hooks_url":"https://api.github.com/repos/keveleigh/HoloToolkit-Unity/hooks","issue_events_url":"https://api.github.com/repos/keveleigh/HoloToolkit-Unity/issues/events{/number}","events_url":"https://api.github.com/repos/keveleigh/HoloToolkit-Unity/events","assignees_url":"https://api.github.com/repos/keveleigh/HoloToolkit-Unity/assignees{/user}","branches_url":"https://api.github.com/repos/keveleigh/HoloToolkit-Unity/branches{/branch}","tags_url":"https://api.github.com/repos/keveleigh/HoloToolkit-Unity/tags","blobs_url":"https://api.github.com/repos/keveleigh/HoloToolkit-Unity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keveleigh/HoloToolkit-Unity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keveleigh/HoloToolkit-Unity/git/refs{/sha}","trees_url":"https://api.github.com/repos/keveleigh/HoloToolkit-Unity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keveleigh/HoloToolkit-Unity/statuses/{sha}","languages_url":"https://api.github.com/repos/keveleigh/HoloToolkit-Unity/languages","stargazers_url":"https://api.github.com/repos/keveleigh/HoloToolkit-Unity/stargazers","contributors_url":"https://api.github.com/repos/keveleigh/HoloToolkit-Unity/contributors","subscribers_url":"https://api.github.com/repos/keveleigh/HoloToolkit-Unity/subscribers","subscription_url":"https://api.github.com/repos/keveleigh/HoloToolkit-Unity/subscription","commits_url":"https://api.github.com/repos/keveleigh/HoloToolkit-Unity/commits{/sha}","git_commits_url":"https://api.github.com/repos/keveleigh/HoloToolkit-Unity/git/commits{/sha}","comments_url":"https://api.github.com/repos/keveleigh/HoloToolkit-Unity/comments{/number}","issue_comment_url":"https://api.github.com/repos/keveleigh/HoloToolkit-Unity/issues/comments{/number}","contents_url":"https://api.github.com/repos/keveleigh/HoloToolkit-Unity/contents/{+path}","compare_url":"https://api.github.com/repos/keveleigh/HoloToolkit-Unity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keveleigh/HoloToolkit-Unity/merges","archive_url":"https://api.github.com/repos/keveleigh/HoloToolkit-Unity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keveleigh/HoloToolkit-Unity/downloads","issues_url":"https://api.github.com/repos/keveleigh/HoloToolkit-Unity/issues{/number}","pulls_url":"https://api.github.com/repos/keveleigh/HoloToolkit-Unity/pulls{/number}","milestones_url":"https://api.github.com/repos/keveleigh/HoloToolkit-Unity/milestones{/number}","notifications_url":"https://api.github.com/repos/keveleigh/HoloToolkit-Unity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keveleigh/HoloToolkit-Unity/labels{/name}","releases_url":"https://api.github.com/repos/keveleigh/HoloToolkit-Unity/releases{/id}","deployments_url":"https://api.github.com/repos/keveleigh/HoloToolkit-Unity/deployments","created_at":"2017-06-01T21:27:04Z","updated_at":"2017-06-01T21:27:09Z","pushed_at":"2017-07-19T18:57:43Z","git_url":"git://github.com/keveleigh/HoloToolkit-Unity.git","ssh_url":"git@github.com:keveleigh/HoloToolkit-Unity.git","clone_url":"https://github.com/keveleigh/HoloToolkit-Unity.git","svn_url":"https://github.com/keveleigh/HoloToolkit-Unity","homepage":"","size":149601,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:RS2_WindowsMixedReality","ref":"RS2_WindowsMixedReality","sha":"47ed9c1d4470a2c9d668d3917652be461f935354","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":50605426,"name":"HoloToolkit-Unity","full_name":"Microsoft/HoloToolkit-Unity","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/HoloToolkit-Unity","description":"This is effectively part of the existing HoloToolkit, but is the repo that will contain all Unity specific components.","fork":false,"url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity","forks_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/forks","keys_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/teams","hooks_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/events","assignees_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/tags","blobs_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/languages","stargazers_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/subscription","commits_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/merges","archive_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/downloads","issues_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/deployments","created_at":"2016-01-28T18:54:58Z","updated_at":"2017-07-19T18:53:39Z","pushed_at":"2017-07-19T21:12:19Z","git_url":"git://github.com/Microsoft/HoloToolkit-Unity.git","ssh_url":"git@github.com:Microsoft/HoloToolkit-Unity.git","clone_url":"https://github.com/Microsoft/HoloToolkit-Unity.git","svn_url":"https://github.com/Microsoft/HoloToolkit-Unity","homepage":"","size":183854,"stargazers_count":912,"watchers_count":912,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":495,"mirror_url":null,"open_issues_count":137,"forks":495,"open_issues":137,"watchers":912,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/pulls/793"},"html":{"href":"https://github.com/Microsoft/HoloToolkit-Unity/pull/793"},"issue":{"href":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/issues/793"},"comments":{"href":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/issues/793/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/pulls/793/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/pulls/793/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/HoloToolkit-Unity/statuses/7cebc00ae93c58fa69b1b2e00fc25e4fafdf7f0c"}}}}
{"actor":{"display_login":"keveleigh"}}