{"action":"created","issue":{"url":"https://api.github.com/repos/google/error-prone/issues/716","repository_url":"https://api.github.com/repos/google/error-prone","labels_url":"https://api.github.com/repos/google/error-prone/issues/716/labels{/name}","comments_url":"https://api.github.com/repos/google/error-prone/issues/716/comments","events_url":"https://api.github.com/repos/google/error-prone/issues/716/events","html_url":"https://github.com/google/error-prone/issues/716","id":252350100,"number":716,"title":"error-prone doesn't follow relocated dependencies","user":{"login":"madrob","id":1592330,"avatar_url":"https://avatars2.githubusercontent.com/u/1592330?v=4","gravatar_id":"","url":"https://api.github.com/users/madrob","html_url":"https://github.com/madrob","followers_url":"https://api.github.com/users/madrob/followers","following_url":"https://api.github.com/users/madrob/following{/other_user}","gists_url":"https://api.github.com/users/madrob/gists{/gist_id}","starred_url":"https://api.github.com/users/madrob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madrob/subscriptions","organizations_url":"https://api.github.com/users/madrob/orgs","repos_url":"https://api.github.com/users/madrob/repos","events_url":"https://api.github.com/users/madrob/events{/privacy}","received_events_url":"https://api.github.com/users/madrob/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-08-23T16:55:39Z","updated_at":"2017-08-23T17:41:25Z","closed_at":null,"body":"I'm working on integrating error-prone into the compile for Apache HBase, and we're running into a strange false positive, I think.\r\n\r\nSteps to reproduce:\r\n```\r\ngit clone https://github.com/apache/hbase\r\ncd hbase\r\nmvn clean package -PerrorProne\r\n```\r\n\r\nOutput error:\r\n```\r\n[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.6.1:compile (default-compile) on project hbase-common: Compilation failure\r\n[ERROR] /Users/mdrob/IdeaProjects/hbase/hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/Context.java:[89,31] [CheckReturnValue] Ignored return value of method that is annotated with @CheckReturnValue\r\n[ERROR]     (see http://errorprone.info/bugpattern/CheckReturnValue)\r\n[ERROR]   Did you mean to remove this line?\r\n```\r\n\r\nThat line is a call to a relocated Guava 22 `Preconditions.checkNotNull` which is annotated `@CanIgnoreReturnValue` - this can be verified in the [artifact](https://repo1.maven.org/maven2/org/apache/hbase/thirdparty/hbase-shaded-miscellaneous/1.0.0/hbase-shaded-miscellaneous-1.0.0.jar) (No source release available yet, unfortunately!)\r\n\r\nThere may be older versions of guava on the dependency classpath, but this class specifically uses `import org.apache.hadoop.hbase.shaded.com.google.common.base.Preconditions;`\r\n\r\nI don't yet have a smaller reproducible case. Before I start down that path, do we think the problem is most likely in error-prone, the plexus compiler, our configuration of the plugins, a combination of these, or something else entirely?"},"comment":{"url":"https://api.github.com/repos/google/error-prone/issues/comments/324409526","html_url":"https://github.com/google/error-prone/issues/716#issuecomment-324409526","issue_url":"https://api.github.com/repos/google/error-prone/issues/716","id":324409526,"user":{"login":"madrob","id":1592330,"avatar_url":"https://avatars2.githubusercontent.com/u/1592330?v=4","gravatar_id":"","url":"https://api.github.com/users/madrob","html_url":"https://github.com/madrob","followers_url":"https://api.github.com/users/madrob/followers","following_url":"https://api.github.com/users/madrob/following{/other_user}","gists_url":"https://api.github.com/users/madrob/gists{/gist_id}","starred_url":"https://api.github.com/users/madrob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madrob/subscriptions","organizations_url":"https://api.github.com/users/madrob/orgs","repos_url":"https://api.github.com/users/madrob/repos","events_url":"https://api.github.com/users/madrob/events{/privacy}","received_events_url":"https://api.github.com/users/madrob/received_events","type":"User","site_admin":false},"created_at":"2017-08-23T17:41:25Z","updated_at":"2017-08-23T17:41:25Z","body":"Is it palatable to update the check based on simple name instead of fully qualified name? Not sure if this would cause other problems though.\r\n\r\nI'll look at excluding the annotation from relocation as well."}}
{"actor":{"display_login":"madrob"}}