{"action":"created","comment":{"url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/comments/126910560","pull_request_review_id":49439935,"id":126910560,"diff_hunk":"@@ -0,0 +1,54 @@\n+/*\n+ * Copyright (c) 2017, Linaro Ltd and Contributors. All rights reserved.\n+ *\n+ * Redistribution and use in source and binary forms, with or without\n+ * modification, are permitted provided that the following conditions are met:\n+ *\n+ * Redistributions of source code must retain the above copyright notice, this\n+ * list of conditions and the following disclaimer.\n+ *\n+ * Redistributions in binary form must reproduce the above copyright notice,\n+ * this list of conditions and the following disclaimer in the documentation\n+ * and/or other materials provided with the distribution.\n+ *\n+ * Neither the name of ARM nor the names of its contributors may be used\n+ * to endorse or promote products derived from this software without specific\n+ * prior written permission.\n+ *\n+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS \"AS IS\"\n+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE\n+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE\n+ * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE\n+ * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR\n+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF\n+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS\n+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN\n+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)\n+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE\n+ * POSSIBILITY OF SUCH DAMAGE.\n+ */\n+\n+#include <arch.h>\n+#include <asm_macros.S>\n+#include <bl_common.h>\n+#include <cortex_a53.h>\n+#include <cpu_macros.S>\n+#include <hi3798cv200.h>\n+#include <platform_def.h>\n+\n+\t.globl\tplat_is_my_cpu_primary\n+\t.globl\tplat_get_my_entrypoint\n+\n+func plat_get_my_entrypoint\n+\t/* TODO support warm boot */\n+\tmov     x0, #0\n+\tret\n+endfunc plat_get_my_entrypoint\n+\n+func plat_is_my_cpu_primary","path":"plat/hisilicon/poplar/aarch64/plat_helpers.S","position":48,"original_position":48,"commit_id":"420eabe76eb0a23314b21044f4387464df79d38f","original_commit_id":"420eabe76eb0a23314b21044f4387464df79d38f","user":{"login":"Leo-Yan","id":11212690,"avatar_url":"https://avatars1.githubusercontent.com/u/11212690?v=3","gravatar_id":"","url":"https://api.github.com/users/Leo-Yan","html_url":"https://github.com/Leo-Yan","followers_url":"https://api.github.com/users/Leo-Yan/followers","following_url":"https://api.github.com/users/Leo-Yan/following{/other_user}","gists_url":"https://api.github.com/users/Leo-Yan/gists{/gist_id}","starred_url":"https://api.github.com/users/Leo-Yan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Leo-Yan/subscriptions","organizations_url":"https://api.github.com/users/Leo-Yan/orgs","repos_url":"https://api.github.com/users/Leo-Yan/repos","events_url":"https://api.github.com/users/Leo-Yan/events{/privacy}","received_events_url":"https://api.github.com/users/Leo-Yan/received_events","type":"User","site_admin":false},"body":"Thanks for the suggestions, Dan. If so, I think we are using correct method in this patch :).","created_at":"2017-07-12T09:48:05Z","updated_at":"2017-07-12T09:48:05Z","html_url":"https://github.com/ARM-software/arm-trusted-firmware/pull/1005#discussion_r126910560","pull_request_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/1005","_links":{"self":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/comments/126910560"},"html":{"href":"https://github.com/ARM-software/arm-trusted-firmware/pull/1005#discussion_r126910560"},"pull_request":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/1005"}}},"pull_request":{"url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/1005","id":127880099,"html_url":"https://github.com/ARM-software/arm-trusted-firmware/pull/1005","diff_url":"https://github.com/ARM-software/arm-trusted-firmware/pull/1005.diff","patch_url":"https://github.com/ARM-software/arm-trusted-firmware/pull/1005.patch","issue_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/issues/1005","number":1005,"state":"open","locked":false,"title":"Poplar: Initial commit for Poplar E-96Boards","user":{"login":"ldts","id":10456021,"avatar_url":"https://avatars1.githubusercontent.com/u/10456021?v=3","gravatar_id":"","url":"https://api.github.com/users/ldts","html_url":"https://github.com/ldts","followers_url":"https://api.github.com/users/ldts/followers","following_url":"https://api.github.com/users/ldts/following{/other_user}","gists_url":"https://api.github.com/users/ldts/gists{/gist_id}","starred_url":"https://api.github.com/users/ldts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldts/subscriptions","organizations_url":"https://api.github.com/users/ldts/orgs","repos_url":"https://api.github.com/users/ldts/repos","events_url":"https://api.github.com/users/ldts/events{/privacy}","received_events_url":"https://api.github.com/users/ldts/received_events","type":"User","site_admin":false},"body":"The board features the Hi3798C V200 with an integrated quad-core\r\n64-bit ARM Cortex A53 processor and high performance Mali T720 GPU,\r\nmaking it capable of running any commercial set-top solution based on\r\nLinux or Android. Its high performance specification also supports a\r\npremium user experience with up to H.265 HEVC decoding of 4K video at\r\n60 frames per second.\r\n\r\nSOC  Hisilicon Hi3798CV200\r\nCPU  Quad-core ARM Cortex-A53 64 bit\r\nDRAM DDR3/3L/4 SDRAM interface, maximum 32-bit data width 2 GB\r\nUSB  Two USB 2.0 ports One USB 3.0 ports\r\nCONSOLE  USB-micro port for console support\r\nETHERNET  1 GBe Ethernet\r\nPCIE  One PCIe 2.0 interfaces\r\nJTAG  8-Pin JTAG\r\nEXPANSION INTERFACE  Linaro 96Boards Low Speed Expansion slot\r\nDIMENSION Standard 160×120 mm 96Boards Enterprice Edition form factor\r\nWIFI  802.11AC 2*2 with Bluetooth\r\nCONNECTORS  One connector for Smart Card One connector for TSI\r\n\r\nThe platform boot sequence is as follows:\r\n    l-loader --> arm_trusted_firmware --> u-boot\r\n\r\nRepositories:\r\n - https://github.com/Linaro/poplar-l-loader.git\r\n - https://github.com/Linaro/poplar-u-boot.git\r\n\r\nU-Boot is under review in the mailing list (v6 posted).\r\n\r\nMake sure you are using the correct branch on each one of these\r\nrepositories. The definition of \"correct\" might change over time (at\r\nthis moment in time this would be the \"latest\" branch).\r\n\r\nBuild Line:\r\nmake CROSS_COMPILE=aarch64-linux-gnu-  all fip SPD=none DEBUG=1\r\nPLAT=poplar BL33=/path/to/u-boot.bin\r\n\r\nSigned-off-by: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>\r\nSigned-off-by: Leo Yan <leo.yan@linaro.org>\r\nSigned-off-by: Alex Elder <elder@linaro.org>\r\nTested-by: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>\r\nTested-by: Leo Yan <leo.yan@linaro.org>\r\nTested-by: Alex Elder <elder@linaro.org>","created_at":"2017-06-28T09:33:59Z","updated_at":"2017-07-12T09:48:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"14d9a2c955f31af4608962204cbd4e17b53ec180","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/1005/commits","review_comments_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/1005/comments","review_comment_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/issues/1005/comments","statuses_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/statuses/420eabe76eb0a23314b21044f4387464df79d38f","head":{"label":"ldts:v1","ref":"v1","sha":"420eabe76eb0a23314b21044f4387464df79d38f","user":{"login":"ldts","id":10456021,"avatar_url":"https://avatars1.githubusercontent.com/u/10456021?v=3","gravatar_id":"","url":"https://api.github.com/users/ldts","html_url":"https://github.com/ldts","followers_url":"https://api.github.com/users/ldts/followers","following_url":"https://api.github.com/users/ldts/following{/other_user}","gists_url":"https://api.github.com/users/ldts/gists{/gist_id}","starred_url":"https://api.github.com/users/ldts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldts/subscriptions","organizations_url":"https://api.github.com/users/ldts/orgs","repos_url":"https://api.github.com/users/ldts/repos","events_url":"https://api.github.com/users/ldts/events{/privacy}","received_events_url":"https://api.github.com/users/ldts/received_events","type":"User","site_admin":false},"repo":{"id":95651790,"name":"arm-trusted-firmware","full_name":"ldts/arm-trusted-firmware","owner":{"login":"ldts","id":10456021,"avatar_url":"https://avatars1.githubusercontent.com/u/10456021?v=3","gravatar_id":"","url":"https://api.github.com/users/ldts","html_url":"https://github.com/ldts","followers_url":"https://api.github.com/users/ldts/followers","following_url":"https://api.github.com/users/ldts/following{/other_user}","gists_url":"https://api.github.com/users/ldts/gists{/gist_id}","starred_url":"https://api.github.com/users/ldts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldts/subscriptions","organizations_url":"https://api.github.com/users/ldts/orgs","repos_url":"https://api.github.com/users/ldts/repos","events_url":"https://api.github.com/users/ldts/events{/privacy}","received_events_url":"https://api.github.com/users/ldts/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ldts/arm-trusted-firmware","description":"ARM Trusted Firmware","fork":true,"url":"https://api.github.com/repos/ldts/arm-trusted-firmware","forks_url":"https://api.github.com/repos/ldts/arm-trusted-firmware/forks","keys_url":"https://api.github.com/repos/ldts/arm-trusted-firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ldts/arm-trusted-firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ldts/arm-trusted-firmware/teams","hooks_url":"https://api.github.com/repos/ldts/arm-trusted-firmware/hooks","issue_events_url":"https://api.github.com/repos/ldts/arm-trusted-firmware/issues/events{/number}","events_url":"https://api.github.com/repos/ldts/arm-trusted-firmware/events","assignees_url":"https://api.github.com/repos/ldts/arm-trusted-firmware/assignees{/user}","branches_url":"https://api.github.com/repos/ldts/arm-trusted-firmware/branches{/branch}","tags_url":"https://api.github.com/repos/ldts/arm-trusted-firmware/tags","blobs_url":"https://api.github.com/repos/ldts/arm-trusted-firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ldts/arm-trusted-firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ldts/arm-trusted-firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/ldts/arm-trusted-firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ldts/arm-trusted-firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/ldts/arm-trusted-firmware/languages","stargazers_url":"https://api.github.com/repos/ldts/arm-trusted-firmware/stargazers","contributors_url":"https://api.github.com/repos/ldts/arm-trusted-firmware/contributors","subscribers_url":"https://api.github.com/repos/ldts/arm-trusted-firmware/subscribers","subscription_url":"https://api.github.com/repos/ldts/arm-trusted-firmware/subscription","commits_url":"https://api.github.com/repos/ldts/arm-trusted-firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/ldts/arm-trusted-firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/ldts/arm-trusted-firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/ldts/arm-trusted-firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/ldts/arm-trusted-firmware/contents/{+path}","compare_url":"https://api.github.com/repos/ldts/arm-trusted-firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ldts/arm-trusted-firmware/merges","archive_url":"https://api.github.com/repos/ldts/arm-trusted-firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ldts/arm-trusted-firmware/downloads","issues_url":"https://api.github.com/repos/ldts/arm-trusted-firmware/issues{/number}","pulls_url":"https://api.github.com/repos/ldts/arm-trusted-firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/ldts/arm-trusted-firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/ldts/arm-trusted-firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ldts/arm-trusted-firmware/labels{/name}","releases_url":"https://api.github.com/repos/ldts/arm-trusted-firmware/releases{/id}","deployments_url":"https://api.github.com/repos/ldts/arm-trusted-firmware/deployments","created_at":"2017-06-28T09:20:59Z","updated_at":"2017-06-28T09:21:03Z","pushed_at":"2017-06-28T09:32:47Z","git_url":"git://github.com/ldts/arm-trusted-firmware.git","ssh_url":"git@github.com:ldts/arm-trusted-firmware.git","clone_url":"https://github.com/ldts/arm-trusted-firmware.git","svn_url":"https://github.com/ldts/arm-trusted-firmware","homepage":null,"size":10265,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ARM-software:integration","ref":"integration","sha":"fa8e8068aa11a6c17b031c3df7dd0e428376a729","user":{"login":"ARM-software","id":5690313,"avatar_url":"https://avatars2.githubusercontent.com/u/5690313?v=3","gravatar_id":"","url":"https://api.github.com/users/ARM-software","html_url":"https://github.com/ARM-software","followers_url":"https://api.github.com/users/ARM-software/followers","following_url":"https://api.github.com/users/ARM-software/following{/other_user}","gists_url":"https://api.github.com/users/ARM-software/gists{/gist_id}","starred_url":"https://api.github.com/users/ARM-software/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARM-software/subscriptions","organizations_url":"https://api.github.com/users/ARM-software/orgs","repos_url":"https://api.github.com/users/ARM-software/repos","events_url":"https://api.github.com/users/ARM-software/events{/privacy}","received_events_url":"https://api.github.com/users/ARM-software/received_events","type":"Organization","site_admin":false},"repo":{"id":13740589,"name":"arm-trusted-firmware","full_name":"ARM-software/arm-trusted-firmware","owner":{"login":"ARM-software","id":5690313,"avatar_url":"https://avatars2.githubusercontent.com/u/5690313?v=3","gravatar_id":"","url":"https://api.github.com/users/ARM-software","html_url":"https://github.com/ARM-software","followers_url":"https://api.github.com/users/ARM-software/followers","following_url":"https://api.github.com/users/ARM-software/following{/other_user}","gists_url":"https://api.github.com/users/ARM-software/gists{/gist_id}","starred_url":"https://api.github.com/users/ARM-software/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARM-software/subscriptions","organizations_url":"https://api.github.com/users/ARM-software/orgs","repos_url":"https://api.github.com/users/ARM-software/repos","events_url":"https://api.github.com/users/ARM-software/events{/privacy}","received_events_url":"https://api.github.com/users/ARM-software/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ARM-software/arm-trusted-firmware","description":"ARM Trusted Firmware","fork":false,"url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware","forks_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/forks","keys_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/teams","hooks_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/hooks","issue_events_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/issues/events{/number}","events_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/events","assignees_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/assignees{/user}","branches_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/branches{/branch}","tags_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/tags","blobs_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/languages","stargazers_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/stargazers","contributors_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/contributors","subscribers_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/subscribers","subscription_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/subscription","commits_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/contents/{+path}","compare_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/merges","archive_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/downloads","issues_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/issues{/number}","pulls_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/labels{/name}","releases_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/releases{/id}","deployments_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/deployments","created_at":"2013-10-21T11:39:00Z","updated_at":"2017-07-09T16:31:37Z","pushed_at":"2017-07-12T09:12:26Z","git_url":"git://github.com/ARM-software/arm-trusted-firmware.git","ssh_url":"git@github.com:ARM-software/arm-trusted-firmware.git","clone_url":"https://github.com/ARM-software/arm-trusted-firmware.git","svn_url":"https://github.com/ARM-software/arm-trusted-firmware","homepage":null,"size":10512,"stargazers_count":357,"watchers_count":357,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":311,"mirror_url":null,"open_issues_count":14,"forks":311,"open_issues":14,"watchers":357,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/1005"},"html":{"href":"https://github.com/ARM-software/arm-trusted-firmware/pull/1005"},"issue":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/issues/1005"},"comments":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/issues/1005/comments"},"review_comments":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/1005/comments"},"review_comment":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/1005/commits"},"statuses":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/statuses/420eabe76eb0a23314b21044f4387464df79d38f"}}}}
{"actor":{"display_login":"Leo-Yan"}}