{"action":"closed","number":35,"pull_request":{"url":"https://api.github.com/repos/Makuna/Rtc/pulls/35","id":119283478,"html_url":"https://github.com/Makuna/Rtc/pull/35","diff_url":"https://github.com/Makuna/Rtc/pull/35.diff","patch_url":"https://github.com/Makuna/Rtc/pull/35.patch","issue_url":"https://api.github.com/repos/Makuna/Rtc/issues/35","number":35,"state":"closed","locked":false,"title":"DS1307 (8PDIP) , ESP8266 and One Wire","user":{"login":"jorgegarciadev","id":2560863,"avatar_url":"https://avatars1.githubusercontent.com/u/2560863?v=3","gravatar_id":"","url":"https://api.github.com/users/jorgegarciadev","html_url":"https://github.com/jorgegarciadev","followers_url":"https://api.github.com/users/jorgegarciadev/followers","following_url":"https://api.github.com/users/jorgegarciadev/following{/other_user}","gists_url":"https://api.github.com/users/jorgegarciadev/gists{/gist_id}","starred_url":"https://api.github.com/users/jorgegarciadev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jorgegarciadev/subscriptions","organizations_url":"https://api.github.com/users/jorgegarciadev/orgs","repos_url":"https://api.github.com/users/jorgegarciadev/repos","events_url":"https://api.github.com/users/jorgegarciadev/events{/privacy}","received_events_url":"https://api.github.com/users/jorgegarciadev/received_events","type":"User","site_admin":false},"body":"I have making some test since I opened the Issue #5. Using the DS1307 (8PDIP) with the ESP8266, the Wire.begin() must be called before the Rtc.begin() otherwise the DS1307 won't be started and won't increase the time.","created_at":"2017-05-06T02:12:35Z","updated_at":"2017-05-07T22:51:08Z","closed_at":"2017-05-07T22:51:08Z","merged_at":null,"merge_commit_sha":"4574d4428cdc5b1e4b2a1b04e4fc9c9f9f7290ee","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Makuna/Rtc/pulls/35/commits","review_comments_url":"https://api.github.com/repos/Makuna/Rtc/pulls/35/comments","review_comment_url":"https://api.github.com/repos/Makuna/Rtc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Makuna/Rtc/issues/35/comments","statuses_url":"https://api.github.com/repos/Makuna/Rtc/statuses/27a75a33e8b666f5f1eb52e3ddfd5d4dbf5fed12","head":{"label":"jorgegarciadev:patch-1","ref":"patch-1","sha":"27a75a33e8b666f5f1eb52e3ddfd5d4dbf5fed12","user":{"login":"jorgegarciadev","id":2560863,"avatar_url":"https://avatars1.githubusercontent.com/u/2560863?v=3","gravatar_id":"","url":"https://api.github.com/users/jorgegarciadev","html_url":"https://github.com/jorgegarciadev","followers_url":"https://api.github.com/users/jorgegarciadev/followers","following_url":"https://api.github.com/users/jorgegarciadev/following{/other_user}","gists_url":"https://api.github.com/users/jorgegarciadev/gists{/gist_id}","starred_url":"https://api.github.com/users/jorgegarciadev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jorgegarciadev/subscriptions","organizations_url":"https://api.github.com/users/jorgegarciadev/orgs","repos_url":"https://api.github.com/users/jorgegarciadev/repos","events_url":"https://api.github.com/users/jorgegarciadev/events{/privacy}","received_events_url":"https://api.github.com/users/jorgegarciadev/received_events","type":"User","site_admin":false},"repo":null},"base":{"label":"Makuna:master","ref":"master","sha":"d1814c4070cbbb924979356da3c6184b63205fd3","user":{"login":"Makuna","id":7972357,"avatar_url":"https://avatars3.githubusercontent.com/u/7972357?v=3","gravatar_id":"","url":"https://api.github.com/users/Makuna","html_url":"https://github.com/Makuna","followers_url":"https://api.github.com/users/Makuna/followers","following_url":"https://api.github.com/users/Makuna/following{/other_user}","gists_url":"https://api.github.com/users/Makuna/gists{/gist_id}","starred_url":"https://api.github.com/users/Makuna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Makuna/subscriptions","organizations_url":"https://api.github.com/users/Makuna/orgs","repos_url":"https://api.github.com/users/Makuna/repos","events_url":"https://api.github.com/users/Makuna/events{/privacy}","received_events_url":"https://api.github.com/users/Makuna/received_events","type":"User","site_admin":false},"repo":{"id":28702692,"name":"Rtc","full_name":"Makuna/Rtc","owner":{"login":"Makuna","id":7972357,"avatar_url":"https://avatars3.githubusercontent.com/u/7972357?v=3","gravatar_id":"","url":"https://api.github.com/users/Makuna","html_url":"https://github.com/Makuna","followers_url":"https://api.github.com/users/Makuna/followers","following_url":"https://api.github.com/users/Makuna/following{/other_user}","gists_url":"https://api.github.com/users/Makuna/gists{/gist_id}","starred_url":"https://api.github.com/users/Makuna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Makuna/subscriptions","organizations_url":"https://api.github.com/users/Makuna/orgs","repos_url":"https://api.github.com/users/Makuna/repos","events_url":"https://api.github.com/users/Makuna/events{/privacy}","received_events_url":"https://api.github.com/users/Makuna/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Makuna/Rtc","description":"Arduino Library for RTC, Ds1307 & Ds3231 with deep support.","fork":false,"url":"https://api.github.com/repos/Makuna/Rtc","forks_url":"https://api.github.com/repos/Makuna/Rtc/forks","keys_url":"https://api.github.com/repos/Makuna/Rtc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Makuna/Rtc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Makuna/Rtc/teams","hooks_url":"https://api.github.com/repos/Makuna/Rtc/hooks","issue_events_url":"https://api.github.com/repos/Makuna/Rtc/issues/events{/number}","events_url":"https://api.github.com/repos/Makuna/Rtc/events","assignees_url":"https://api.github.com/repos/Makuna/Rtc/assignees{/user}","branches_url":"https://api.github.com/repos/Makuna/Rtc/branches{/branch}","tags_url":"https://api.github.com/repos/Makuna/Rtc/tags","blobs_url":"https://api.github.com/repos/Makuna/Rtc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Makuna/Rtc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Makuna/Rtc/git/refs{/sha}","trees_url":"https://api.github.com/repos/Makuna/Rtc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Makuna/Rtc/statuses/{sha}","languages_url":"https://api.github.com/repos/Makuna/Rtc/languages","stargazers_url":"https://api.github.com/repos/Makuna/Rtc/stargazers","contributors_url":"https://api.github.com/repos/Makuna/Rtc/contributors","subscribers_url":"https://api.github.com/repos/Makuna/Rtc/subscribers","subscription_url":"https://api.github.com/repos/Makuna/Rtc/subscription","commits_url":"https://api.github.com/repos/Makuna/Rtc/commits{/sha}","git_commits_url":"https://api.github.com/repos/Makuna/Rtc/git/commits{/sha}","comments_url":"https://api.github.com/repos/Makuna/Rtc/comments{/number}","issue_comment_url":"https://api.github.com/repos/Makuna/Rtc/issues/comments{/number}","contents_url":"https://api.github.com/repos/Makuna/Rtc/contents/{+path}","compare_url":"https://api.github.com/repos/Makuna/Rtc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Makuna/Rtc/merges","archive_url":"https://api.github.com/repos/Makuna/Rtc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Makuna/Rtc/downloads","issues_url":"https://api.github.com/repos/Makuna/Rtc/issues{/number}","pulls_url":"https://api.github.com/repos/Makuna/Rtc/pulls{/number}","milestones_url":"https://api.github.com/repos/Makuna/Rtc/milestones{/number}","notifications_url":"https://api.github.com/repos/Makuna/Rtc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Makuna/Rtc/labels{/name}","releases_url":"https://api.github.com/repos/Makuna/Rtc/releases{/id}","deployments_url":"https://api.github.com/repos/Makuna/Rtc/deployments","created_at":"2015-01-02T03:43:13Z","updated_at":"2017-05-01T16:05:47Z","pushed_at":"2017-05-06T02:12:36Z","git_url":"git://github.com/Makuna/Rtc.git","ssh_url":"git@github.com:Makuna/Rtc.git","clone_url":"https://github.com/Makuna/Rtc.git","svn_url":"https://github.com/Makuna/Rtc","homepage":null,"size":45,"stargazers_count":73,"watchers_count":73,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"open_issues_count":1,"forks":33,"open_issues":1,"watchers":73,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Makuna/Rtc/pulls/35"},"html":{"href":"https://github.com/Makuna/Rtc/pull/35"},"issue":{"href":"https://api.github.com/repos/Makuna/Rtc/issues/35"},"comments":{"href":"https://api.github.com/repos/Makuna/Rtc/issues/35/comments"},"review_comments":{"href":"https://api.github.com/repos/Makuna/Rtc/pulls/35/comments"},"review_comment":{"href":"https://api.github.com/repos/Makuna/Rtc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Makuna/Rtc/pulls/35/commits"},"statuses":{"href":"https://api.github.com/repos/Makuna/Rtc/statuses/27a75a33e8b666f5f1eb52e3ddfd5d4dbf5fed12"}},"merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":2,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"jorgegarciadev"}}