{"action":"created","comment":{"url":"https://api.github.com/repos/rwengine/openrw/pulls/comments/141537783","pull_request_review_id":65764977,"id":141537783,"diff_hunk":"@@ -73,7 +73,7 @@ void ObjectRenderer::renderGeometry(Geometry* geom,\n                 dp.colour = mat.colour;\n \n                 if (object && object->type() == GameObject::Vehicle) {\n-                    auto vehicle = static_cast<VehicleObject*>(object);\n+                    auto vehicle = dynamic_cast<VehicleObject*>(object);","path":"rwengine/src/render/ObjectRenderer.cpp","position":23,"original_position":23,"commit_id":"acc4a56079fb0e23c55238784dcc383dfc636ec7","original_commit_id":"acc4a56079fb0e23c55238784dcc383dfc636ec7","user":{"login":"paulsapps","id":7420121,"avatar_url":"https://avatars3.githubusercontent.com/u/7420121?v=4","gravatar_id":"","url":"https://api.github.com/users/paulsapps","html_url":"https://github.com/paulsapps","followers_url":"https://api.github.com/users/paulsapps/followers","following_url":"https://api.github.com/users/paulsapps/following{/other_user}","gists_url":"https://api.github.com/users/paulsapps/gists{/gist_id}","starred_url":"https://api.github.com/users/paulsapps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulsapps/subscriptions","organizations_url":"https://api.github.com/users/paulsapps/orgs","repos_url":"https://api.github.com/users/paulsapps/repos","events_url":"https://api.github.com/users/paulsapps/events{/privacy}","received_events_url":"https://api.github.com/users/paulsapps/received_events","type":"User","site_admin":false},"body":"This has run time cost, and it can fail so result should be asserted.","created_at":"2017-09-28T06:49:13Z","updated_at":"2017-09-28T06:49:13Z","html_url":"https://github.com/rwengine/openrw/pull/320#discussion_r141537783","pull_request_url":"https://api.github.com/repos/rwengine/openrw/pulls/320","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/rwengine/openrw/pulls/comments/141537783"},"html":{"href":"https://github.com/rwengine/openrw/pull/320#discussion_r141537783"},"pull_request":{"href":"https://api.github.com/repos/rwengine/openrw/pulls/320"}}},"pull_request":{"url":"https://api.github.com/repos/rwengine/openrw/pulls/320","id":142536168,"html_url":"https://github.com/rwengine/openrw/pull/320","diff_url":"https://github.com/rwengine/openrw/pull/320.diff","patch_url":"https://github.com/rwengine/openrw/pull/320.patch","issue_url":"https://api.github.com/repos/rwengine/openrw/issues/320","number":320,"state":"closed","locked":false,"title":"Replace static_cast and NULLs in renderer with their safer equivalents","user":{"login":"TechnoCrunch","id":12127735,"avatar_url":"https://avatars3.githubusercontent.com/u/12127735?v=4","gravatar_id":"","url":"https://api.github.com/users/TechnoCrunch","html_url":"https://github.com/TechnoCrunch","followers_url":"https://api.github.com/users/TechnoCrunch/followers","following_url":"https://api.github.com/users/TechnoCrunch/following{/other_user}","gists_url":"https://api.github.com/users/TechnoCrunch/gists{/gist_id}","starred_url":"https://api.github.com/users/TechnoCrunch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TechnoCrunch/subscriptions","organizations_url":"https://api.github.com/users/TechnoCrunch/orgs","repos_url":"https://api.github.com/users/TechnoCrunch/repos","events_url":"https://api.github.com/users/TechnoCrunch/events{/privacy}","received_events_url":"https://api.github.com/users/TechnoCrunch/received_events","type":"User","site_admin":false},"body":"Redundant c_str() were also removed and had no affect on the game during a test.","created_at":"2017-09-22T09:34:51Z","updated_at":"2017-09-28T06:49:13Z","closed_at":"2017-09-28T05:38:15Z","merged_at":null,"merge_commit_sha":"e3daab63b108a8a7a1dd2af92b61ed76115d3391","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/rwengine/openrw/pulls/320/commits","review_comments_url":"https://api.github.com/repos/rwengine/openrw/pulls/320/comments","review_comment_url":"https://api.github.com/repos/rwengine/openrw/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rwengine/openrw/issues/320/comments","statuses_url":"https://api.github.com/repos/rwengine/openrw/statuses/acc4a56079fb0e23c55238784dcc383dfc636ec7","head":{"label":"TechnoCrunch:master","ref":"master","sha":"acc4a56079fb0e23c55238784dcc383dfc636ec7","user":{"login":"TechnoCrunch","id":12127735,"avatar_url":"https://avatars3.githubusercontent.com/u/12127735?v=4","gravatar_id":"","url":"https://api.github.com/users/TechnoCrunch","html_url":"https://github.com/TechnoCrunch","followers_url":"https://api.github.com/users/TechnoCrunch/followers","following_url":"https://api.github.com/users/TechnoCrunch/following{/other_user}","gists_url":"https://api.github.com/users/TechnoCrunch/gists{/gist_id}","starred_url":"https://api.github.com/users/TechnoCrunch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TechnoCrunch/subscriptions","organizations_url":"https://api.github.com/users/TechnoCrunch/orgs","repos_url":"https://api.github.com/users/TechnoCrunch/repos","events_url":"https://api.github.com/users/TechnoCrunch/events{/privacy}","received_events_url":"https://api.github.com/users/TechnoCrunch/received_events","type":"User","site_admin":false},"repo":{"id":104134860,"name":"openrw","full_name":"TechnoCrunch/openrw","owner":{"login":"TechnoCrunch","id":12127735,"avatar_url":"https://avatars3.githubusercontent.com/u/12127735?v=4","gravatar_id":"","url":"https://api.github.com/users/TechnoCrunch","html_url":"https://github.com/TechnoCrunch","followers_url":"https://api.github.com/users/TechnoCrunch/followers","following_url":"https://api.github.com/users/TechnoCrunch/following{/other_user}","gists_url":"https://api.github.com/users/TechnoCrunch/gists{/gist_id}","starred_url":"https://api.github.com/users/TechnoCrunch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TechnoCrunch/subscriptions","organizations_url":"https://api.github.com/users/TechnoCrunch/orgs","repos_url":"https://api.github.com/users/TechnoCrunch/repos","events_url":"https://api.github.com/users/TechnoCrunch/events{/privacy}","received_events_url":"https://api.github.com/users/TechnoCrunch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TechnoCrunch/openrw","description":"OpenRW \"Open ReWrite\" is an un-official open source recreation of the classic Grand Theft Auto III game executable","fork":true,"url":"https://api.github.com/repos/TechnoCrunch/openrw","forks_url":"https://api.github.com/repos/TechnoCrunch/openrw/forks","keys_url":"https://api.github.com/repos/TechnoCrunch/openrw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TechnoCrunch/openrw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TechnoCrunch/openrw/teams","hooks_url":"https://api.github.com/repos/TechnoCrunch/openrw/hooks","issue_events_url":"https://api.github.com/repos/TechnoCrunch/openrw/issues/events{/number}","events_url":"https://api.github.com/repos/TechnoCrunch/openrw/events","assignees_url":"https://api.github.com/repos/TechnoCrunch/openrw/assignees{/user}","branches_url":"https://api.github.com/repos/TechnoCrunch/openrw/branches{/branch}","tags_url":"https://api.github.com/repos/TechnoCrunch/openrw/tags","blobs_url":"https://api.github.com/repos/TechnoCrunch/openrw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TechnoCrunch/openrw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TechnoCrunch/openrw/git/refs{/sha}","trees_url":"https://api.github.com/repos/TechnoCrunch/openrw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TechnoCrunch/openrw/statuses/{sha}","languages_url":"https://api.github.com/repos/TechnoCrunch/openrw/languages","stargazers_url":"https://api.github.com/repos/TechnoCrunch/openrw/stargazers","contributors_url":"https://api.github.com/repos/TechnoCrunch/openrw/contributors","subscribers_url":"https://api.github.com/repos/TechnoCrunch/openrw/subscribers","subscription_url":"https://api.github.com/repos/TechnoCrunch/openrw/subscription","commits_url":"https://api.github.com/repos/TechnoCrunch/openrw/commits{/sha}","git_commits_url":"https://api.github.com/repos/TechnoCrunch/openrw/git/commits{/sha}","comments_url":"https://api.github.com/repos/TechnoCrunch/openrw/comments{/number}","issue_comment_url":"https://api.github.com/repos/TechnoCrunch/openrw/issues/comments{/number}","contents_url":"https://api.github.com/repos/TechnoCrunch/openrw/contents/{+path}","compare_url":"https://api.github.com/repos/TechnoCrunch/openrw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TechnoCrunch/openrw/merges","archive_url":"https://api.github.com/repos/TechnoCrunch/openrw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TechnoCrunch/openrw/downloads","issues_url":"https://api.github.com/repos/TechnoCrunch/openrw/issues{/number}","pulls_url":"https://api.github.com/repos/TechnoCrunch/openrw/pulls{/number}","milestones_url":"https://api.github.com/repos/TechnoCrunch/openrw/milestones{/number}","notifications_url":"https://api.github.com/repos/TechnoCrunch/openrw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TechnoCrunch/openrw/labels{/name}","releases_url":"https://api.github.com/repos/TechnoCrunch/openrw/releases{/id}","deployments_url":"https://api.github.com/repos/TechnoCrunch/openrw/deployments","created_at":"2017-09-19T22:16:20Z","updated_at":"2017-09-19T22:16:23Z","pushed_at":"2017-09-22T08:27:47Z","git_url":"git://github.com/TechnoCrunch/openrw.git","ssh_url":"git@github.com:TechnoCrunch/openrw.git","clone_url":"https://github.com/TechnoCrunch/openrw.git","svn_url":"https://github.com/TechnoCrunch/openrw","homepage":"http://openrw.org","size":2671,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rwengine:master","ref":"master","sha":"11e90c61e56b60240251cd080f175ddff7d7a101","user":{"login":"rwengine","id":19520421,"avatar_url":"https://avatars0.githubusercontent.com/u/19520421?v=4","gravatar_id":"","url":"https://api.github.com/users/rwengine","html_url":"https://github.com/rwengine","followers_url":"https://api.github.com/users/rwengine/followers","following_url":"https://api.github.com/users/rwengine/following{/other_user}","gists_url":"https://api.github.com/users/rwengine/gists{/gist_id}","starred_url":"https://api.github.com/users/rwengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwengine/subscriptions","organizations_url":"https://api.github.com/users/rwengine/orgs","repos_url":"https://api.github.com/users/rwengine/repos","events_url":"https://api.github.com/users/rwengine/events{/privacy}","received_events_url":"https://api.github.com/users/rwengine/received_events","type":"Organization","site_admin":false},"repo":{"id":34529275,"name":"openrw","full_name":"rwengine/openrw","owner":{"login":"rwengine","id":19520421,"avatar_url":"https://avatars0.githubusercontent.com/u/19520421?v=4","gravatar_id":"","url":"https://api.github.com/users/rwengine","html_url":"https://github.com/rwengine","followers_url":"https://api.github.com/users/rwengine/followers","following_url":"https://api.github.com/users/rwengine/following{/other_user}","gists_url":"https://api.github.com/users/rwengine/gists{/gist_id}","starred_url":"https://api.github.com/users/rwengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwengine/subscriptions","organizations_url":"https://api.github.com/users/rwengine/orgs","repos_url":"https://api.github.com/users/rwengine/repos","events_url":"https://api.github.com/users/rwengine/events{/privacy}","received_events_url":"https://api.github.com/users/rwengine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rwengine/openrw","description":"OpenRW \"Open ReWrite\" is an un-official open source recreation of the classic Grand Theft Auto III game executable","fork":false,"url":"https://api.github.com/repos/rwengine/openrw","forks_url":"https://api.github.com/repos/rwengine/openrw/forks","keys_url":"https://api.github.com/repos/rwengine/openrw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rwengine/openrw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rwengine/openrw/teams","hooks_url":"https://api.github.com/repos/rwengine/openrw/hooks","issue_events_url":"https://api.github.com/repos/rwengine/openrw/issues/events{/number}","events_url":"https://api.github.com/repos/rwengine/openrw/events","assignees_url":"https://api.github.com/repos/rwengine/openrw/assignees{/user}","branches_url":"https://api.github.com/repos/rwengine/openrw/branches{/branch}","tags_url":"https://api.github.com/repos/rwengine/openrw/tags","blobs_url":"https://api.github.com/repos/rwengine/openrw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rwengine/openrw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rwengine/openrw/git/refs{/sha}","trees_url":"https://api.github.com/repos/rwengine/openrw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rwengine/openrw/statuses/{sha}","languages_url":"https://api.github.com/repos/rwengine/openrw/languages","stargazers_url":"https://api.github.com/repos/rwengine/openrw/stargazers","contributors_url":"https://api.github.com/repos/rwengine/openrw/contributors","subscribers_url":"https://api.github.com/repos/rwengine/openrw/subscribers","subscription_url":"https://api.github.com/repos/rwengine/openrw/subscription","commits_url":"https://api.github.com/repos/rwengine/openrw/commits{/sha}","git_commits_url":"https://api.github.com/repos/rwengine/openrw/git/commits{/sha}","comments_url":"https://api.github.com/repos/rwengine/openrw/comments{/number}","issue_comment_url":"https://api.github.com/repos/rwengine/openrw/issues/comments{/number}","contents_url":"https://api.github.com/repos/rwengine/openrw/contents/{+path}","compare_url":"https://api.github.com/repos/rwengine/openrw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rwengine/openrw/merges","archive_url":"https://api.github.com/repos/rwengine/openrw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rwengine/openrw/downloads","issues_url":"https://api.github.com/repos/rwengine/openrw/issues{/number}","pulls_url":"https://api.github.com/repos/rwengine/openrw/pulls{/number}","milestones_url":"https://api.github.com/repos/rwengine/openrw/milestones{/number}","notifications_url":"https://api.github.com/repos/rwengine/openrw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rwengine/openrw/labels{/name}","releases_url":"https://api.github.com/repos/rwengine/openrw/releases{/id}","deployments_url":"https://api.github.com/repos/rwengine/openrw/deployments","created_at":"2015-04-24T16:26:12Z","updated_at":"2017-09-25T12:22:57Z","pushed_at":"2017-09-27T17:46:48Z","git_url":"git://github.com/rwengine/openrw.git","ssh_url":"git@github.com:rwengine/openrw.git","clone_url":"https://github.com/rwengine/openrw.git","svn_url":"https://github.com/rwengine/openrw","homepage":"http://openrw.org","size":2670,"stargazers_count":489,"watchers_count":489,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":65,"mirror_url":null,"open_issues_count":69,"forks":65,"open_issues":69,"watchers":489,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rwengine/openrw/pulls/320"},"html":{"href":"https://github.com/rwengine/openrw/pull/320"},"issue":{"href":"https://api.github.com/repos/rwengine/openrw/issues/320"},"comments":{"href":"https://api.github.com/repos/rwengine/openrw/issues/320/comments"},"review_comments":{"href":"https://api.github.com/repos/rwengine/openrw/pulls/320/comments"},"review_comment":{"href":"https://api.github.com/repos/rwengine/openrw/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rwengine/openrw/pulls/320/commits"},"statuses":{"href":"https://api.github.com/repos/rwengine/openrw/statuses/acc4a56079fb0e23c55238784dcc383dfc636ec7"}},"author_association":"NONE"}}
{"actor":{"display_login":"paulsapps"}}