{"action":"created","comment":{"url":"https://api.github.com/repos/odoo/odoo/pulls/comments/96635614","pull_request_review_id":17222118,"id":96635614,"diff_hunk":"@@ -361,7 +361,7 @@ def _get_counterpart(self):\n             counterpart = list(counterpart)[0:2] + [\"...\"]\n         self.counterpart = \",\".join(counterpart)\n \n-    name = fields.Char(required=True, string=\"Label\")\n+    name = fields.Char(string=\"Label\")","path":"addons/account/models/account_move.py","position":5,"original_position":5,"commit_id":"7fed1c5ef91b6e34ff4beb27cbf3707455499153","original_commit_id":"7fed1c5ef91b6e34ff4beb27cbf3707455499153","user":{"login":"nhomar","id":338634,"avatar_url":"https://avatars.githubusercontent.com/u/338634?v=3","gravatar_id":"","url":"https://api.github.com/users/nhomar","html_url":"https://github.com/nhomar","followers_url":"https://api.github.com/users/nhomar/followers","following_url":"https://api.github.com/users/nhomar/following{/other_user}","gists_url":"https://api.github.com/users/nhomar/gists{/gist_id}","starred_url":"https://api.github.com/users/nhomar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nhomar/subscriptions","organizations_url":"https://api.github.com/users/nhomar/orgs","repos_url":"https://api.github.com/users/nhomar/repos","events_url":"https://api.github.com/users/nhomar/events{/privacy}","received_events_url":"https://api.github.com/users/nhomar/received_events","type":"User","site_admin":false},"body":"Ok, I got the point, but I continue thinking either the ref and/or the name must be mandatory, it does not make much sense have them both not mandatory and then start to have hundreds of lines without any explanation.\r\n\r\nI mean, The name or the ref must be mandatory, if the user copy and paste the text it is his problem, our responsibility is until say \"Hey! you must say why are you putting this number here\".\r\n\r\nI hope it explain better my point.","created_at":"2017-01-18T13:40:42Z","updated_at":"2017-01-18T13:40:42Z","html_url":"https://github.com/odoo/odoo/pull/15103#discussion_r96635614","pull_request_url":"https://api.github.com/repos/odoo/odoo/pulls/15103","_links":{"self":{"href":"https://api.github.com/repos/odoo/odoo/pulls/comments/96635614"},"html":{"href":"https://github.com/odoo/odoo/pull/15103#discussion_r96635614"},"pull_request":{"href":"https://api.github.com/repos/odoo/odoo/pulls/15103"}}},"pull_request":{"url":"https://api.github.com/repos/odoo/odoo/pulls/15103","id":101881264,"html_url":"https://github.com/odoo/odoo/pull/15103","diff_url":"https://github.com/odoo/odoo/pull/15103.diff","patch_url":"https://github.com/odoo/odoo/pull/15103.patch","issue_url":"https://api.github.com/repos/odoo/odoo/issues/15103","number":15103,"state":"open","locked":false,"title":"accounting usability","user":{"login":"smetl","id":21679159,"avatar_url":"https://avatars.githubusercontent.com/u/21679159?v=3","gravatar_id":"","url":"https://api.github.com/users/smetl","html_url":"https://github.com/smetl","followers_url":"https://api.github.com/users/smetl/followers","following_url":"https://api.github.com/users/smetl/following{/other_user}","gists_url":"https://api.github.com/users/smetl/gists{/gist_id}","starred_url":"https://api.github.com/users/smetl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smetl/subscriptions","organizations_url":"https://api.github.com/users/smetl/orgs","repos_url":"https://api.github.com/users/smetl/repos","events_url":"https://api.github.com/users/smetl/events{/privacy}","received_events_url":"https://api.github.com/users/smetl/received_events","type":"User","site_admin":false},"body":"Description of the issue/feature this PR addresses:\r\n\r\nrelated to task: https://www.odoo.com/web#id=30786&view_type=form&model=project.task&action=333&active_id=248&menu_id=4720\r\n\r\nCurrent behavior before PR:\r\n\r\nDesired behavior after PR is merged:\r\n\r\n-add wizard to change the lock date\r\n-default computation debit/credit when creating manually a journal entry\r\n\r\n\r\n--\r\nI confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr\r\n","created_at":"2017-01-17T15:06:47Z","updated_at":"2017-01-18T13:40:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"585934bba2bcf2972f026ed0b24a289a7621470c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/odoo/odoo/pulls/15103/commits","review_comments_url":"https://api.github.com/repos/odoo/odoo/pulls/15103/comments","review_comment_url":"https://api.github.com/repos/odoo/odoo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/odoo/odoo/issues/15103/comments","statuses_url":"https://api.github.com/repos/odoo/odoo/statuses/7fed1c5ef91b6e34ff4beb27cbf3707455499153","head":{"label":"odoo-dev:master-misc-pvy","ref":"master-misc-pvy","sha":"7fed1c5ef91b6e34ff4beb27cbf3707455499153","user":{"login":"odoo-dev","id":7466976,"avatar_url":"https://avatars.githubusercontent.com/u/7466976?v=3","gravatar_id":"","url":"https://api.github.com/users/odoo-dev","html_url":"https://github.com/odoo-dev","followers_url":"https://api.github.com/users/odoo-dev/followers","following_url":"https://api.github.com/users/odoo-dev/following{/other_user}","gists_url":"https://api.github.com/users/odoo-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo-dev/subscriptions","organizations_url":"https://api.github.com/users/odoo-dev/orgs","repos_url":"https://api.github.com/users/odoo-dev/repos","events_url":"https://api.github.com/users/odoo-dev/events{/privacy}","received_events_url":"https://api.github.com/users/odoo-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":19853934,"name":"odoo","full_name":"odoo-dev/odoo","owner":{"login":"odoo-dev","id":7466976,"avatar_url":"https://avatars.githubusercontent.com/u/7466976?v=3","gravatar_id":"","url":"https://api.github.com/users/odoo-dev","html_url":"https://github.com/odoo-dev","followers_url":"https://api.github.com/users/odoo-dev/followers","following_url":"https://api.github.com/users/odoo-dev/following{/other_user}","gists_url":"https://api.github.com/users/odoo-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo-dev/subscriptions","organizations_url":"https://api.github.com/users/odoo-dev/orgs","repos_url":"https://api.github.com/users/odoo-dev/repos","events_url":"https://api.github.com/users/odoo-dev/events{/privacy}","received_events_url":"https://api.github.com/users/odoo-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/odoo-dev/odoo","description":"RD Dev Repository","fork":true,"url":"https://api.github.com/repos/odoo-dev/odoo","forks_url":"https://api.github.com/repos/odoo-dev/odoo/forks","keys_url":"https://api.github.com/repos/odoo-dev/odoo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/odoo-dev/odoo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/odoo-dev/odoo/teams","hooks_url":"https://api.github.com/repos/odoo-dev/odoo/hooks","issue_events_url":"https://api.github.com/repos/odoo-dev/odoo/issues/events{/number}","events_url":"https://api.github.com/repos/odoo-dev/odoo/events","assignees_url":"https://api.github.com/repos/odoo-dev/odoo/assignees{/user}","branches_url":"https://api.github.com/repos/odoo-dev/odoo/branches{/branch}","tags_url":"https://api.github.com/repos/odoo-dev/odoo/tags","blobs_url":"https://api.github.com/repos/odoo-dev/odoo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/odoo-dev/odoo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/odoo-dev/odoo/git/refs{/sha}","trees_url":"https://api.github.com/repos/odoo-dev/odoo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/odoo-dev/odoo/statuses/{sha}","languages_url":"https://api.github.com/repos/odoo-dev/odoo/languages","stargazers_url":"https://api.github.com/repos/odoo-dev/odoo/stargazers","contributors_url":"https://api.github.com/repos/odoo-dev/odoo/contributors","subscribers_url":"https://api.github.com/repos/odoo-dev/odoo/subscribers","subscription_url":"https://api.github.com/repos/odoo-dev/odoo/subscription","commits_url":"https://api.github.com/repos/odoo-dev/odoo/commits{/sha}","git_commits_url":"https://api.github.com/repos/odoo-dev/odoo/git/commits{/sha}","comments_url":"https://api.github.com/repos/odoo-dev/odoo/comments{/number}","issue_comment_url":"https://api.github.com/repos/odoo-dev/odoo/issues/comments{/number}","contents_url":"https://api.github.com/repos/odoo-dev/odoo/contents/{+path}","compare_url":"https://api.github.com/repos/odoo-dev/odoo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/odoo-dev/odoo/merges","archive_url":"https://api.github.com/repos/odoo-dev/odoo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/odoo-dev/odoo/downloads","issues_url":"https://api.github.com/repos/odoo-dev/odoo/issues{/number}","pulls_url":"https://api.github.com/repos/odoo-dev/odoo/pulls{/number}","milestones_url":"https://api.github.com/repos/odoo-dev/odoo/milestones{/number}","notifications_url":"https://api.github.com/repos/odoo-dev/odoo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/odoo-dev/odoo/labels{/name}","releases_url":"https://api.github.com/repos/odoo-dev/odoo/releases{/id}","deployments_url":"https://api.github.com/repos/odoo-dev/odoo/deployments","created_at":"2014-05-16T11:16:19Z","updated_at":"2016-10-31T14:56:45Z","pushed_at":"2017-01-18T13:37:50Z","git_url":"git://github.com/odoo-dev/odoo.git","ssh_url":"git@github.com:odoo-dev/odoo.git","clone_url":"https://github.com/odoo-dev/odoo.git","svn_url":"https://github.com/odoo-dev/odoo","homepage":"https://www.odoo.com","size":1767845,"stargazers_count":71,"watchers_count":71,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"open_issues_count":1,"forks":28,"open_issues":1,"watchers":71,"default_branch":"master"}},"base":{"label":"odoo:master","ref":"master","sha":"dfd5cf95633d92da44cce014c6e175da90e1fafa","user":{"login":"odoo","id":6368483,"avatar_url":"https://avatars.githubusercontent.com/u/6368483?v=3","gravatar_id":"","url":"https://api.github.com/users/odoo","html_url":"https://github.com/odoo","followers_url":"https://api.github.com/users/odoo/followers","following_url":"https://api.github.com/users/odoo/following{/other_user}","gists_url":"https://api.github.com/users/odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo/subscriptions","organizations_url":"https://api.github.com/users/odoo/orgs","repos_url":"https://api.github.com/users/odoo/repos","events_url":"https://api.github.com/users/odoo/events{/privacy}","received_events_url":"https://api.github.com/users/odoo/received_events","type":"Organization","site_admin":false},"repo":{"id":19745004,"name":"odoo","full_name":"odoo/odoo","owner":{"login":"odoo","id":6368483,"avatar_url":"https://avatars.githubusercontent.com/u/6368483?v=3","gravatar_id":"","url":"https://api.github.com/users/odoo","html_url":"https://github.com/odoo","followers_url":"https://api.github.com/users/odoo/followers","following_url":"https://api.github.com/users/odoo/following{/other_user}","gists_url":"https://api.github.com/users/odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo/subscriptions","organizations_url":"https://api.github.com/users/odoo/orgs","repos_url":"https://api.github.com/users/odoo/repos","events_url":"https://api.github.com/users/odoo/events{/privacy}","received_events_url":"https://api.github.com/users/odoo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/odoo/odoo","description":"Odoo (formerly OpenERP). Open Source Apps To Grow Your Business.","fork":false,"url":"https://api.github.com/repos/odoo/odoo","forks_url":"https://api.github.com/repos/odoo/odoo/forks","keys_url":"https://api.github.com/repos/odoo/odoo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/odoo/odoo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/odoo/odoo/teams","hooks_url":"https://api.github.com/repos/odoo/odoo/hooks","issue_events_url":"https://api.github.com/repos/odoo/odoo/issues/events{/number}","events_url":"https://api.github.com/repos/odoo/odoo/events","assignees_url":"https://api.github.com/repos/odoo/odoo/assignees{/user}","branches_url":"https://api.github.com/repos/odoo/odoo/branches{/branch}","tags_url":"https://api.github.com/repos/odoo/odoo/tags","blobs_url":"https://api.github.com/repos/odoo/odoo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/odoo/odoo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/odoo/odoo/git/refs{/sha}","trees_url":"https://api.github.com/repos/odoo/odoo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/odoo/odoo/statuses/{sha}","languages_url":"https://api.github.com/repos/odoo/odoo/languages","stargazers_url":"https://api.github.com/repos/odoo/odoo/stargazers","contributors_url":"https://api.github.com/repos/odoo/odoo/contributors","subscribers_url":"https://api.github.com/repos/odoo/odoo/subscribers","subscription_url":"https://api.github.com/repos/odoo/odoo/subscription","commits_url":"https://api.github.com/repos/odoo/odoo/commits{/sha}","git_commits_url":"https://api.github.com/repos/odoo/odoo/git/commits{/sha}","comments_url":"https://api.github.com/repos/odoo/odoo/comments{/number}","issue_comment_url":"https://api.github.com/repos/odoo/odoo/issues/comments{/number}","contents_url":"https://api.github.com/repos/odoo/odoo/contents/{+path}","compare_url":"https://api.github.com/repos/odoo/odoo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/odoo/odoo/merges","archive_url":"https://api.github.com/repos/odoo/odoo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/odoo/odoo/downloads","issues_url":"https://api.github.com/repos/odoo/odoo/issues{/number}","pulls_url":"https://api.github.com/repos/odoo/odoo/pulls{/number}","milestones_url":"https://api.github.com/repos/odoo/odoo/milestones{/number}","notifications_url":"https://api.github.com/repos/odoo/odoo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/odoo/odoo/labels{/name}","releases_url":"https://api.github.com/repos/odoo/odoo/releases{/id}","deployments_url":"https://api.github.com/repos/odoo/odoo/deployments","created_at":"2014-05-13T15:38:58Z","updated_at":"2017-01-18T12:50:19Z","pushed_at":"2017-01-18T13:38:51Z","git_url":"git://github.com/odoo/odoo.git","ssh_url":"git@github.com:odoo/odoo.git","clone_url":"https://github.com/odoo/odoo.git","svn_url":"https://github.com/odoo/odoo","homepage":"https://www.odoo.com","size":1762082,"stargazers_count":5786,"watchers_count":5786,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5489,"mirror_url":null,"open_issues_count":3213,"forks":5489,"open_issues":3213,"watchers":5786,"default_branch":"10.0"}},"_links":{"self":{"href":"https://api.github.com/repos/odoo/odoo/pulls/15103"},"html":{"href":"https://github.com/odoo/odoo/pull/15103"},"issue":{"href":"https://api.github.com/repos/odoo/odoo/issues/15103"},"comments":{"href":"https://api.github.com/repos/odoo/odoo/issues/15103/comments"},"review_comments":{"href":"https://api.github.com/repos/odoo/odoo/pulls/15103/comments"},"review_comment":{"href":"https://api.github.com/repos/odoo/odoo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/odoo/odoo/pulls/15103/commits"},"statuses":{"href":"https://api.github.com/repos/odoo/odoo/statuses/7fed1c5ef91b6e34ff4beb27cbf3707455499153"}}}}
{"actor":{"display_login":"nhomar"}}