{"action":"closed","number":1173,"pull_request":{"url":"https://api.github.com/repos/istio/mixer/pulls/1173","id":138533598,"html_url":"https://github.com/istio/mixer/pull/1173","diff_url":"https://github.com/istio/mixer/pull/1173.diff","patch_url":"https://github.com/istio/mixer/pull/1173.patch","issue_url":"https://api.github.com/repos/istio/mixer/issues/1173","number":1173,"state":"closed","locked":false,"title":"Update prometheus adapter for reload","user":{"login":"mandarjog","id":800375,"avatar_url":"https://avatars2.githubusercontent.com/u/800375?v=4","gravatar_id":"","url":"https://api.github.com/users/mandarjog","html_url":"https://github.com/mandarjog","followers_url":"https://api.github.com/users/mandarjog/followers","following_url":"https://api.github.com/users/mandarjog/following{/other_user}","gists_url":"https://api.github.com/users/mandarjog/gists{/gist_id}","starred_url":"https://api.github.com/users/mandarjog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mandarjog/subscriptions","organizations_url":"https://api.github.com/users/mandarjog/orgs","repos_url":"https://api.github.com/users/mandarjog/repos","events_url":"https://api.github.com/users/mandarjog/events{/privacy}","received_events_url":"https://api.github.com/users/mandarjog/received_events","type":"User","site_admin":false},"body":"1. Use a singleton builder to ensure port is used correctly.\r\n2. Do smart reloads, counter state is trashed only when a metric\r\n   is redefined.\r\n3. Ensure that builder.Build() does not panic on metric redefinition.\r\n\r\n**Release note**:\r\n<!--  Steps to write your release note:\r\n1. Use the release-note-* labels to set the release note state (if you have access)\r\n2. Enter your extended release note in the below block; leaving it blank means using the PR title as the release note. If no release note is required, just write `NONE`.\r\n-->\r\n```release-note\r\nNONE\r\n```\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/istio/mixer/1173)\n<!-- Reviewable:end -->\n","created_at":"2017-08-30T21:33:01Z","updated_at":"2017-08-31T18:52:04Z","closed_at":"2017-08-31T18:52:04Z","merged_at":"2017-08-31T18:52:04Z","merge_commit_sha":"ab30a130b9cd0dd95a459f110e8a6b8f4cd3e065","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ZackButcher","id":1923135,"avatar_url":"https://avatars2.githubusercontent.com/u/1923135?v=4","gravatar_id":"","url":"https://api.github.com/users/ZackButcher","html_url":"https://github.com/ZackButcher","followers_url":"https://api.github.com/users/ZackButcher/followers","following_url":"https://api.github.com/users/ZackButcher/following{/other_user}","gists_url":"https://api.github.com/users/ZackButcher/gists{/gist_id}","starred_url":"https://api.github.com/users/ZackButcher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZackButcher/subscriptions","organizations_url":"https://api.github.com/users/ZackButcher/orgs","repos_url":"https://api.github.com/users/ZackButcher/repos","events_url":"https://api.github.com/users/ZackButcher/events{/privacy}","received_events_url":"https://api.github.com/users/ZackButcher/received_events","type":"User","site_admin":false},{"login":"guptasu","id":11448595,"avatar_url":"https://avatars3.githubusercontent.com/u/11448595?v=4","gravatar_id":"","url":"https://api.github.com/users/guptasu","html_url":"https://github.com/guptasu","followers_url":"https://api.github.com/users/guptasu/followers","following_url":"https://api.github.com/users/guptasu/following{/other_user}","gists_url":"https://api.github.com/users/guptasu/gists{/gist_id}","starred_url":"https://api.github.com/users/guptasu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guptasu/subscriptions","organizations_url":"https://api.github.com/users/guptasu/orgs","repos_url":"https://api.github.com/users/guptasu/repos","events_url":"https://api.github.com/users/guptasu/events{/privacy}","received_events_url":"https://api.github.com/users/guptasu/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/istio/mixer/pulls/1173/commits","review_comments_url":"https://api.github.com/repos/istio/mixer/pulls/1173/comments","review_comment_url":"https://api.github.com/repos/istio/mixer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/istio/mixer/issues/1173/comments","statuses_url":"https://api.github.com/repos/istio/mixer/statuses/d869fbde932923bba72e650d2cc5a6562389c435","head":{"label":"mandarjog:prometheus2","ref":"prometheus2","sha":"d869fbde932923bba72e650d2cc5a6562389c435","user":{"login":"mandarjog","id":800375,"avatar_url":"https://avatars2.githubusercontent.com/u/800375?v=4","gravatar_id":"","url":"https://api.github.com/users/mandarjog","html_url":"https://github.com/mandarjog","followers_url":"https://api.github.com/users/mandarjog/followers","following_url":"https://api.github.com/users/mandarjog/following{/other_user}","gists_url":"https://api.github.com/users/mandarjog/gists{/gist_id}","starred_url":"https://api.github.com/users/mandarjog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mandarjog/subscriptions","organizations_url":"https://api.github.com/users/mandarjog/orgs","repos_url":"https://api.github.com/users/mandarjog/repos","events_url":"https://api.github.com/users/mandarjog/events{/privacy}","received_events_url":"https://api.github.com/users/mandarjog/received_events","type":"User","site_admin":false},"repo":{"id":75396439,"name":"mixer","full_name":"mandarjog/mixer","owner":{"login":"mandarjog","id":800375,"avatar_url":"https://avatars2.githubusercontent.com/u/800375?v=4","gravatar_id":"","url":"https://api.github.com/users/mandarjog","html_url":"https://github.com/mandarjog","followers_url":"https://api.github.com/users/mandarjog/followers","following_url":"https://api.github.com/users/mandarjog/following{/other_user}","gists_url":"https://api.github.com/users/mandarjog/gists{/gist_id}","starred_url":"https://api.github.com/users/mandarjog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mandarjog/subscriptions","organizations_url":"https://api.github.com/users/mandarjog/orgs","repos_url":"https://api.github.com/users/mandarjog/repos","events_url":"https://api.github.com/users/mandarjog/events{/privacy}","received_events_url":"https://api.github.com/users/mandarjog/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mandarjog/mixer","description":"The Istio mixer and its adapters.","fork":true,"url":"https://api.github.com/repos/mandarjog/mixer","forks_url":"https://api.github.com/repos/mandarjog/mixer/forks","keys_url":"https://api.github.com/repos/mandarjog/mixer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mandarjog/mixer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mandarjog/mixer/teams","hooks_url":"https://api.github.com/repos/mandarjog/mixer/hooks","issue_events_url":"https://api.github.com/repos/mandarjog/mixer/issues/events{/number}","events_url":"https://api.github.com/repos/mandarjog/mixer/events","assignees_url":"https://api.github.com/repos/mandarjog/mixer/assignees{/user}","branches_url":"https://api.github.com/repos/mandarjog/mixer/branches{/branch}","tags_url":"https://api.github.com/repos/mandarjog/mixer/tags","blobs_url":"https://api.github.com/repos/mandarjog/mixer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mandarjog/mixer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mandarjog/mixer/git/refs{/sha}","trees_url":"https://api.github.com/repos/mandarjog/mixer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mandarjog/mixer/statuses/{sha}","languages_url":"https://api.github.com/repos/mandarjog/mixer/languages","stargazers_url":"https://api.github.com/repos/mandarjog/mixer/stargazers","contributors_url":"https://api.github.com/repos/mandarjog/mixer/contributors","subscribers_url":"https://api.github.com/repos/mandarjog/mixer/subscribers","subscription_url":"https://api.github.com/repos/mandarjog/mixer/subscription","commits_url":"https://api.github.com/repos/mandarjog/mixer/commits{/sha}","git_commits_url":"https://api.github.com/repos/mandarjog/mixer/git/commits{/sha}","comments_url":"https://api.github.com/repos/mandarjog/mixer/comments{/number}","issue_comment_url":"https://api.github.com/repos/mandarjog/mixer/issues/comments{/number}","contents_url":"https://api.github.com/repos/mandarjog/mixer/contents/{+path}","compare_url":"https://api.github.com/repos/mandarjog/mixer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mandarjog/mixer/merges","archive_url":"https://api.github.com/repos/mandarjog/mixer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mandarjog/mixer/downloads","issues_url":"https://api.github.com/repos/mandarjog/mixer/issues{/number}","pulls_url":"https://api.github.com/repos/mandarjog/mixer/pulls{/number}","milestones_url":"https://api.github.com/repos/mandarjog/mixer/milestones{/number}","notifications_url":"https://api.github.com/repos/mandarjog/mixer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mandarjog/mixer/labels{/name}","releases_url":"https://api.github.com/repos/mandarjog/mixer/releases{/id}","deployments_url":"https://api.github.com/repos/mandarjog/mixer/deployments","created_at":"2016-12-02T13:06:30Z","updated_at":"2016-12-02T13:06:32Z","pushed_at":"2017-08-31T14:44:30Z","git_url":"git://github.com/mandarjog/mixer.git","ssh_url":"git@github.com:mandarjog/mixer.git","clone_url":"https://github.com/mandarjog/mixer.git","svn_url":"https://github.com/mandarjog/mixer","homepage":null,"size":14848,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"istio:master","ref":"master","sha":"7a2197f83e20c716a0e71990de4e68c682d1a436","user":{"login":"istio","id":23534644,"avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"repo":{"id":74177509,"name":"mixer","full_name":"istio/mixer","owner":{"login":"istio","id":23534644,"avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/istio/mixer","description":"Istio's Mixer and its adapters","fork":false,"url":"https://api.github.com/repos/istio/mixer","forks_url":"https://api.github.com/repos/istio/mixer/forks","keys_url":"https://api.github.com/repos/istio/mixer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/istio/mixer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/istio/mixer/teams","hooks_url":"https://api.github.com/repos/istio/mixer/hooks","issue_events_url":"https://api.github.com/repos/istio/mixer/issues/events{/number}","events_url":"https://api.github.com/repos/istio/mixer/events","assignees_url":"https://api.github.com/repos/istio/mixer/assignees{/user}","branches_url":"https://api.github.com/repos/istio/mixer/branches{/branch}","tags_url":"https://api.github.com/repos/istio/mixer/tags","blobs_url":"https://api.github.com/repos/istio/mixer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/istio/mixer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/istio/mixer/git/refs{/sha}","trees_url":"https://api.github.com/repos/istio/mixer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/istio/mixer/statuses/{sha}","languages_url":"https://api.github.com/repos/istio/mixer/languages","stargazers_url":"https://api.github.com/repos/istio/mixer/stargazers","contributors_url":"https://api.github.com/repos/istio/mixer/contributors","subscribers_url":"https://api.github.com/repos/istio/mixer/subscribers","subscription_url":"https://api.github.com/repos/istio/mixer/subscription","commits_url":"https://api.github.com/repos/istio/mixer/commits{/sha}","git_commits_url":"https://api.github.com/repos/istio/mixer/git/commits{/sha}","comments_url":"https://api.github.com/repos/istio/mixer/comments{/number}","issue_comment_url":"https://api.github.com/repos/istio/mixer/issues/comments{/number}","contents_url":"https://api.github.com/repos/istio/mixer/contents/{+path}","compare_url":"https://api.github.com/repos/istio/mixer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/istio/mixer/merges","archive_url":"https://api.github.com/repos/istio/mixer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/istio/mixer/downloads","issues_url":"https://api.github.com/repos/istio/mixer/issues{/number}","pulls_url":"https://api.github.com/repos/istio/mixer/pulls{/number}","milestones_url":"https://api.github.com/repos/istio/mixer/milestones{/number}","notifications_url":"https://api.github.com/repos/istio/mixer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/istio/mixer/labels{/name}","releases_url":"https://api.github.com/repos/istio/mixer/releases{/id}","deployments_url":"https://api.github.com/repos/istio/mixer/deployments","created_at":"2016-11-19T00:40:17Z","updated_at":"2017-08-25T17:32:43Z","pushed_at":"2017-08-31T18:52:04Z","git_url":"git://github.com/istio/mixer.git","ssh_url":"git@github.com:istio/mixer.git","clone_url":"https://github.com/istio/mixer.git","svn_url":"https://github.com/istio/mixer","homepage":"","size":16472,"stargazers_count":58,"watchers_count":58,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":80,"mirror_url":null,"open_issues_count":137,"forks":80,"open_issues":137,"watchers":58,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/istio/mixer/pulls/1173"},"html":{"href":"https://github.com/istio/mixer/pull/1173"},"issue":{"href":"https://api.github.com/repos/istio/mixer/issues/1173"},"comments":{"href":"https://api.github.com/repos/istio/mixer/issues/1173/comments"},"review_comments":{"href":"https://api.github.com/repos/istio/mixer/pulls/1173/comments"},"review_comment":{"href":"https://api.github.com/repos/istio/mixer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/istio/mixer/pulls/1173/commits"},"statuses":{"href":"https://api.github.com/repos/istio/mixer/statuses/d869fbde932923bba72e650d2cc5a6562389c435"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"mandarjog","id":800375,"avatar_url":"https://avatars2.githubusercontent.com/u/800375?v=4","gravatar_id":"","url":"https://api.github.com/users/mandarjog","html_url":"https://github.com/mandarjog","followers_url":"https://api.github.com/users/mandarjog/followers","following_url":"https://api.github.com/users/mandarjog/following{/other_user}","gists_url":"https://api.github.com/users/mandarjog/gists{/gist_id}","starred_url":"https://api.github.com/users/mandarjog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mandarjog/subscriptions","organizations_url":"https://api.github.com/users/mandarjog/orgs","repos_url":"https://api.github.com/users/mandarjog/repos","events_url":"https://api.github.com/users/mandarjog/events{/privacy}","received_events_url":"https://api.github.com/users/mandarjog/received_events","type":"User","site_admin":false},"comments":4,"review_comments":10,"maintainer_can_modify":false,"commits":4,"additions":207,"deletions":52,"changed_files":4}}
{"actor":{"display_login":"mandarjog"}}