{"action":"created","comment":{"url":"https://api.github.com/repos/mnubo/iptables-liveupdate/pulls/comments/131401490","pull_request_review_id":54380080,"id":131401490,"diff_hunk":"@@ -706,75 +804,87 @@ def analyze_in_kernel_chain_rules(iptables_data, p_table_name,\n         if line_idx == 2:\n \n             if len(cur_tokens) < 2:\n-                logger.error('{0}Expected header line with more tokens'.format(line_error_str))\n+                log.error(\"{0}Expected header line {1}\".format(\n+                    line_error_str, \"with more tokens\"))\n                 in_error_case = 1\n                 continue\n \n             if ((cur_tokens[0].lower() != \"pkts\") or","path":"iptables-liveupdate.py","position":958,"original_position":958,"commit_id":"60e128090371ade11911a98bc0bff5ca33ebf6a0","original_commit_id":"60e128090371ade11911a98bc0bff5ca33ebf6a0","user":{"login":"sebastienc","id":1553651,"avatar_url":"https://avatars2.githubusercontent.com/u/1553651?v=4","gravatar_id":"","url":"https://api.github.com/users/sebastienc","html_url":"https://github.com/sebastienc","followers_url":"https://api.github.com/users/sebastienc/followers","following_url":"https://api.github.com/users/sebastienc/following{/other_user}","gists_url":"https://api.github.com/users/sebastienc/gists{/gist_id}","starred_url":"https://api.github.com/users/sebastienc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebastienc/subscriptions","organizations_url":"https://api.github.com/users/sebastienc/orgs","repos_url":"https://api.github.com/users/sebastienc/repos","events_url":"https://api.github.com/users/sebastienc/events{/privacy}","received_events_url":"https://api.github.com/users/sebastienc/received_events","type":"User","site_admin":false},"body":"Est-ce que tu pourrais enlever les paranthèses ici aussi?","created_at":"2017-08-04T14:25:23Z","updated_at":"2017-08-04T14:30:10Z","html_url":"https://github.com/mnubo/iptables-liveupdate/pull/4#discussion_r131401490","pull_request_url":"https://api.github.com/repos/mnubo/iptables-liveupdate/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/mnubo/iptables-liveupdate/pulls/comments/131401490"},"html":{"href":"https://github.com/mnubo/iptables-liveupdate/pull/4#discussion_r131401490"},"pull_request":{"href":"https://api.github.com/repos/mnubo/iptables-liveupdate/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/mnubo/iptables-liveupdate/pulls/4","id":134090085,"html_url":"https://github.com/mnubo/iptables-liveupdate/pull/4","diff_url":"https://github.com/mnubo/iptables-liveupdate/pull/4.diff","patch_url":"https://github.com/mnubo/iptables-liveupdate/pull/4.patch","issue_url":"https://api.github.com/repos/mnubo/iptables-liveupdate/issues/4","number":4,"state":"open","locked":false,"title":"Major additions to iptables-liveupdate","user":{"login":"mchatel","id":10774069,"avatar_url":"https://avatars1.githubusercontent.com/u/10774069?v=4","gravatar_id":"","url":"https://api.github.com/users/mchatel","html_url":"https://github.com/mchatel","followers_url":"https://api.github.com/users/mchatel/followers","following_url":"https://api.github.com/users/mchatel/following{/other_user}","gists_url":"https://api.github.com/users/mchatel/gists{/gist_id}","starred_url":"https://api.github.com/users/mchatel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mchatel/subscriptions","organizations_url":"https://api.github.com/users/mchatel/orgs","repos_url":"https://api.github.com/users/mchatel/repos","events_url":"https://api.github.com/users/mchatel/events{/privacy}","received_events_url":"https://api.github.com/users/mchatel/received_events","type":"User","site_admin":false},"body":"- Re-structure iptables-liveupdate.py to conform to the same standards as the other scripts\r\n- Migrate all usage of {} to use dict() instead, eliminates some PyCharm warnings\r\n- Add IPv6 support to iptables-liveupdate.py\r\n- Add a manual, stored in 3 different formats (odt, pdt, txt)\r\n- Remove --log option which could not be implemented consistently for all scripts\r\n- Improve iptables-backup.py utility","created_at":"2017-08-04T04:46:37Z","updated_at":"2017-08-04T14:30:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"76281ce7c753e418052d90be57e0ecd242473934","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/mnubo/iptables-liveupdate/pulls/4/commits","review_comments_url":"https://api.github.com/repos/mnubo/iptables-liveupdate/pulls/4/comments","review_comment_url":"https://api.github.com/repos/mnubo/iptables-liveupdate/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mnubo/iptables-liveupdate/issues/4/comments","statuses_url":"https://api.github.com/repos/mnubo/iptables-liveupdate/statuses/60e128090371ade11911a98bc0bff5ca33ebf6a0","head":{"label":"mchatel:master","ref":"master","sha":"60e128090371ade11911a98bc0bff5ca33ebf6a0","user":{"login":"mchatel","id":10774069,"avatar_url":"https://avatars1.githubusercontent.com/u/10774069?v=4","gravatar_id":"","url":"https://api.github.com/users/mchatel","html_url":"https://github.com/mchatel","followers_url":"https://api.github.com/users/mchatel/followers","following_url":"https://api.github.com/users/mchatel/following{/other_user}","gists_url":"https://api.github.com/users/mchatel/gists{/gist_id}","starred_url":"https://api.github.com/users/mchatel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mchatel/subscriptions","organizations_url":"https://api.github.com/users/mchatel/orgs","repos_url":"https://api.github.com/users/mchatel/repos","events_url":"https://api.github.com/users/mchatel/events{/privacy}","received_events_url":"https://api.github.com/users/mchatel/received_events","type":"User","site_admin":false},"repo":{"id":98212327,"name":"iptables-liveupdate","full_name":"mchatel/iptables-liveupdate","owner":{"login":"mchatel","id":10774069,"avatar_url":"https://avatars1.githubusercontent.com/u/10774069?v=4","gravatar_id":"","url":"https://api.github.com/users/mchatel","html_url":"https://github.com/mchatel","followers_url":"https://api.github.com/users/mchatel/followers","following_url":"https://api.github.com/users/mchatel/following{/other_user}","gists_url":"https://api.github.com/users/mchatel/gists{/gist_id}","starred_url":"https://api.github.com/users/mchatel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mchatel/subscriptions","organizations_url":"https://api.github.com/users/mchatel/orgs","repos_url":"https://api.github.com/users/mchatel/repos","events_url":"https://api.github.com/users/mchatel/events{/privacy}","received_events_url":"https://api.github.com/users/mchatel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mchatel/iptables-liveupdate","description":"Set of tools to manage iptables rules on a set of systems live.","fork":true,"url":"https://api.github.com/repos/mchatel/iptables-liveupdate","forks_url":"https://api.github.com/repos/mchatel/iptables-liveupdate/forks","keys_url":"https://api.github.com/repos/mchatel/iptables-liveupdate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mchatel/iptables-liveupdate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mchatel/iptables-liveupdate/teams","hooks_url":"https://api.github.com/repos/mchatel/iptables-liveupdate/hooks","issue_events_url":"https://api.github.com/repos/mchatel/iptables-liveupdate/issues/events{/number}","events_url":"https://api.github.com/repos/mchatel/iptables-liveupdate/events","assignees_url":"https://api.github.com/repos/mchatel/iptables-liveupdate/assignees{/user}","branches_url":"https://api.github.com/repos/mchatel/iptables-liveupdate/branches{/branch}","tags_url":"https://api.github.com/repos/mchatel/iptables-liveupdate/tags","blobs_url":"https://api.github.com/repos/mchatel/iptables-liveupdate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mchatel/iptables-liveupdate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mchatel/iptables-liveupdate/git/refs{/sha}","trees_url":"https://api.github.com/repos/mchatel/iptables-liveupdate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mchatel/iptables-liveupdate/statuses/{sha}","languages_url":"https://api.github.com/repos/mchatel/iptables-liveupdate/languages","stargazers_url":"https://api.github.com/repos/mchatel/iptables-liveupdate/stargazers","contributors_url":"https://api.github.com/repos/mchatel/iptables-liveupdate/contributors","subscribers_url":"https://api.github.com/repos/mchatel/iptables-liveupdate/subscribers","subscription_url":"https://api.github.com/repos/mchatel/iptables-liveupdate/subscription","commits_url":"https://api.github.com/repos/mchatel/iptables-liveupdate/commits{/sha}","git_commits_url":"https://api.github.com/repos/mchatel/iptables-liveupdate/git/commits{/sha}","comments_url":"https://api.github.com/repos/mchatel/iptables-liveupdate/comments{/number}","issue_comment_url":"https://api.github.com/repos/mchatel/iptables-liveupdate/issues/comments{/number}","contents_url":"https://api.github.com/repos/mchatel/iptables-liveupdate/contents/{+path}","compare_url":"https://api.github.com/repos/mchatel/iptables-liveupdate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mchatel/iptables-liveupdate/merges","archive_url":"https://api.github.com/repos/mchatel/iptables-liveupdate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mchatel/iptables-liveupdate/downloads","issues_url":"https://api.github.com/repos/mchatel/iptables-liveupdate/issues{/number}","pulls_url":"https://api.github.com/repos/mchatel/iptables-liveupdate/pulls{/number}","milestones_url":"https://api.github.com/repos/mchatel/iptables-liveupdate/milestones{/number}","notifications_url":"https://api.github.com/repos/mchatel/iptables-liveupdate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mchatel/iptables-liveupdate/labels{/name}","releases_url":"https://api.github.com/repos/mchatel/iptables-liveupdate/releases{/id}","deployments_url":"https://api.github.com/repos/mchatel/iptables-liveupdate/deployments","created_at":"2017-07-24T16:37:54Z","updated_at":"2017-07-24T16:37:55Z","pushed_at":"2017-08-04T04:43:59Z","git_url":"git://github.com/mchatel/iptables-liveupdate.git","ssh_url":"git@github.com:mchatel/iptables-liveupdate.git","clone_url":"https://github.com/mchatel/iptables-liveupdate.git","svn_url":"https://github.com/mchatel/iptables-liveupdate","homepage":"","size":553,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mnubo:master","ref":"master","sha":"613fb374d283230b083f9b6049098288343a2a9b","user":{"login":"mnubo","id":7773027,"avatar_url":"https://avatars0.githubusercontent.com/u/7773027?v=4","gravatar_id":"","url":"https://api.github.com/users/mnubo","html_url":"https://github.com/mnubo","followers_url":"https://api.github.com/users/mnubo/followers","following_url":"https://api.github.com/users/mnubo/following{/other_user}","gists_url":"https://api.github.com/users/mnubo/gists{/gist_id}","starred_url":"https://api.github.com/users/mnubo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mnubo/subscriptions","organizations_url":"https://api.github.com/users/mnubo/orgs","repos_url":"https://api.github.com/users/mnubo/repos","events_url":"https://api.github.com/users/mnubo/events{/privacy}","received_events_url":"https://api.github.com/users/mnubo/received_events","type":"Organization","site_admin":false},"repo":{"id":97846326,"name":"iptables-liveupdate","full_name":"mnubo/iptables-liveupdate","owner":{"login":"mnubo","id":7773027,"avatar_url":"https://avatars0.githubusercontent.com/u/7773027?v=4","gravatar_id":"","url":"https://api.github.com/users/mnubo","html_url":"https://github.com/mnubo","followers_url":"https://api.github.com/users/mnubo/followers","following_url":"https://api.github.com/users/mnubo/following{/other_user}","gists_url":"https://api.github.com/users/mnubo/gists{/gist_id}","starred_url":"https://api.github.com/users/mnubo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mnubo/subscriptions","organizations_url":"https://api.github.com/users/mnubo/orgs","repos_url":"https://api.github.com/users/mnubo/repos","events_url":"https://api.github.com/users/mnubo/events{/privacy}","received_events_url":"https://api.github.com/users/mnubo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mnubo/iptables-liveupdate","description":"Set of tools to manage iptables rules on a set of systems live.","fork":false,"url":"https://api.github.com/repos/mnubo/iptables-liveupdate","forks_url":"https://api.github.com/repos/mnubo/iptables-liveupdate/forks","keys_url":"https://api.github.com/repos/mnubo/iptables-liveupdate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mnubo/iptables-liveupdate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mnubo/iptables-liveupdate/teams","hooks_url":"https://api.github.com/repos/mnubo/iptables-liveupdate/hooks","issue_events_url":"https://api.github.com/repos/mnubo/iptables-liveupdate/issues/events{/number}","events_url":"https://api.github.com/repos/mnubo/iptables-liveupdate/events","assignees_url":"https://api.github.com/repos/mnubo/iptables-liveupdate/assignees{/user}","branches_url":"https://api.github.com/repos/mnubo/iptables-liveupdate/branches{/branch}","tags_url":"https://api.github.com/repos/mnubo/iptables-liveupdate/tags","blobs_url":"https://api.github.com/repos/mnubo/iptables-liveupdate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mnubo/iptables-liveupdate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mnubo/iptables-liveupdate/git/refs{/sha}","trees_url":"https://api.github.com/repos/mnubo/iptables-liveupdate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mnubo/iptables-liveupdate/statuses/{sha}","languages_url":"https://api.github.com/repos/mnubo/iptables-liveupdate/languages","stargazers_url":"https://api.github.com/repos/mnubo/iptables-liveupdate/stargazers","contributors_url":"https://api.github.com/repos/mnubo/iptables-liveupdate/contributors","subscribers_url":"https://api.github.com/repos/mnubo/iptables-liveupdate/subscribers","subscription_url":"https://api.github.com/repos/mnubo/iptables-liveupdate/subscription","commits_url":"https://api.github.com/repos/mnubo/iptables-liveupdate/commits{/sha}","git_commits_url":"https://api.github.com/repos/mnubo/iptables-liveupdate/git/commits{/sha}","comments_url":"https://api.github.com/repos/mnubo/iptables-liveupdate/comments{/number}","issue_comment_url":"https://api.github.com/repos/mnubo/iptables-liveupdate/issues/comments{/number}","contents_url":"https://api.github.com/repos/mnubo/iptables-liveupdate/contents/{+path}","compare_url":"https://api.github.com/repos/mnubo/iptables-liveupdate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mnubo/iptables-liveupdate/merges","archive_url":"https://api.github.com/repos/mnubo/iptables-liveupdate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mnubo/iptables-liveupdate/downloads","issues_url":"https://api.github.com/repos/mnubo/iptables-liveupdate/issues{/number}","pulls_url":"https://api.github.com/repos/mnubo/iptables-liveupdate/pulls{/number}","milestones_url":"https://api.github.com/repos/mnubo/iptables-liveupdate/milestones{/number}","notifications_url":"https://api.github.com/repos/mnubo/iptables-liveupdate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mnubo/iptables-liveupdate/labels{/name}","releases_url":"https://api.github.com/repos/mnubo/iptables-liveupdate/releases{/id}","deployments_url":"https://api.github.com/repos/mnubo/iptables-liveupdate/deployments","created_at":"2017-07-20T14:40:30Z","updated_at":"2017-07-20T20:41:47Z","pushed_at":"2017-08-04T04:46:37Z","git_url":"git://github.com/mnubo/iptables-liveupdate.git","ssh_url":"git@github.com:mnubo/iptables-liveupdate.git","clone_url":"https://github.com/mnubo/iptables-liveupdate.git","svn_url":"https://github.com/mnubo/iptables-liveupdate","homepage":"","size":47,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mnubo/iptables-liveupdate/pulls/4"},"html":{"href":"https://github.com/mnubo/iptables-liveupdate/pull/4"},"issue":{"href":"https://api.github.com/repos/mnubo/iptables-liveupdate/issues/4"},"comments":{"href":"https://api.github.com/repos/mnubo/iptables-liveupdate/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/mnubo/iptables-liveupdate/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/mnubo/iptables-liveupdate/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mnubo/iptables-liveupdate/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/mnubo/iptables-liveupdate/statuses/60e128090371ade11911a98bc0bff5ca33ebf6a0"}}}}
{"actor":{"display_login":"sebastienc"}}