{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes-incubator/cri-o/pulls/comments/130643553","pull_request_review_id":53542085,"id":130643553,"diff_hunk":"@@ -187,16 +186,16 @@ func getBlankSpec() specs.Spec {\n }\n \n // get an oci.Container instance for a given container ID\n-func getOCIContainer(store storage.Store, container string) (*oci.Container, error) {\n-\tctr, err := FindContainer(store, container)\n+func (c *ContainerServer) getOCIContainer(container string) (*oci.Container, error) {","path":"libkpod/container_data.go","position":102,"original_position":102,"commit_id":"bd2d460c48a1cbc601da9c6e66735c03691d0f2b","original_commit_id":"bd2d460c48a1cbc601da9c6e66735c03691d0f2b","user":{"login":"mheon","id":7735048,"avatar_url":"https://avatars3.githubusercontent.com/u/7735048?v=4","gravatar_id":"","url":"https://api.github.com/users/mheon","html_url":"https://github.com/mheon","followers_url":"https://api.github.com/users/mheon/followers","following_url":"https://api.github.com/users/mheon/following{/other_user}","gists_url":"https://api.github.com/users/mheon/gists{/gist_id}","starred_url":"https://api.github.com/users/mheon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mheon/subscriptions","organizations_url":"https://api.github.com/users/mheon/orgs","repos_url":"https://api.github.com/users/mheon/repos","events_url":"https://api.github.com/users/mheon/events{/privacy}","received_events_url":"https://api.github.com/users/mheon/received_events","type":"User","site_admin":false},"body":"Can we replace this entirely with LookupContainer or ContainerFromRequest? We have access to the state already, we should just retrieve the container from it.","created_at":"2017-08-01T15:37:22Z","updated_at":"2017-08-01T15:37:22Z","html_url":"https://github.com/kubernetes-incubator/cri-o/pull/720#discussion_r130643553","pull_request_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/pulls/720","_links":{"self":{"href":"https://api.github.com/repos/kubernetes-incubator/cri-o/pulls/comments/130643553"},"html":{"href":"https://github.com/kubernetes-incubator/cri-o/pull/720#discussion_r130643553"},"pull_request":{"href":"https://api.github.com/repos/kubernetes-incubator/cri-o/pulls/720"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes-incubator/cri-o/pulls/720","id":133503385,"html_url":"https://github.com/kubernetes-incubator/cri-o/pull/720","diff_url":"https://github.com/kubernetes-incubator/cri-o/pull/720.diff","patch_url":"https://github.com/kubernetes-incubator/cri-o/pull/720.patch","issue_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/issues/720","number":720,"state":"open","locked":false,"title":"Move functions in libkpod to ContainerServer","user":{"login":"14rcole","id":10855607,"avatar_url":"https://avatars2.githubusercontent.com/u/10855607?v=4","gravatar_id":"","url":"https://api.github.com/users/14rcole","html_url":"https://github.com/14rcole","followers_url":"https://api.github.com/users/14rcole/followers","following_url":"https://api.github.com/users/14rcole/following{/other_user}","gists_url":"https://api.github.com/users/14rcole/gists{/gist_id}","starred_url":"https://api.github.com/users/14rcole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/14rcole/subscriptions","organizations_url":"https://api.github.com/users/14rcole/orgs","repos_url":"https://api.github.com/users/14rcole/repos","events_url":"https://api.github.com/users/14rcole/events{/privacy}","received_events_url":"https://api.github.com/users/14rcole/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-08-01T15:30:52Z","updated_at":"2017-08-01T15:37:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"363217e061b89c61f23785f20c3ac3d4469102be","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/pulls/720/commits","review_comments_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/pulls/720/comments","review_comment_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/issues/720/comments","statuses_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/statuses/bd2d460c48a1cbc601da9c6e66735c03691d0f2b","head":{"label":"14rcole:containerserver-integration","ref":"containerserver-integration","sha":"bd2d460c48a1cbc601da9c6e66735c03691d0f2b","user":{"login":"14rcole","id":10855607,"avatar_url":"https://avatars2.githubusercontent.com/u/10855607?v=4","gravatar_id":"","url":"https://api.github.com/users/14rcole","html_url":"https://github.com/14rcole","followers_url":"https://api.github.com/users/14rcole/followers","following_url":"https://api.github.com/users/14rcole/following{/other_user}","gists_url":"https://api.github.com/users/14rcole/gists{/gist_id}","starred_url":"https://api.github.com/users/14rcole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/14rcole/subscriptions","organizations_url":"https://api.github.com/users/14rcole/orgs","repos_url":"https://api.github.com/users/14rcole/repos","events_url":"https://api.github.com/users/14rcole/events{/privacy}","received_events_url":"https://api.github.com/users/14rcole/received_events","type":"User","site_admin":false},"repo":{"id":70831246,"name":"cri-o","full_name":"14rcole/cri-o","owner":{"login":"14rcole","id":10855607,"avatar_url":"https://avatars2.githubusercontent.com/u/10855607?v=4","gravatar_id":"","url":"https://api.github.com/users/14rcole","html_url":"https://github.com/14rcole","followers_url":"https://api.github.com/users/14rcole/followers","following_url":"https://api.github.com/users/14rcole/following{/other_user}","gists_url":"https://api.github.com/users/14rcole/gists{/gist_id}","starred_url":"https://api.github.com/users/14rcole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/14rcole/subscriptions","organizations_url":"https://api.github.com/users/14rcole/orgs","repos_url":"https://api.github.com/users/14rcole/repos","events_url":"https://api.github.com/users/14rcole/events{/privacy}","received_events_url":"https://api.github.com/users/14rcole/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/14rcole/cri-o","description":"Open Container Initiative-based implementation of Kubernetes Container Runtime Interface","fork":true,"url":"https://api.github.com/repos/14rcole/cri-o","forks_url":"https://api.github.com/repos/14rcole/cri-o/forks","keys_url":"https://api.github.com/repos/14rcole/cri-o/keys{/key_id}","collaborators_url":"https://api.github.com/repos/14rcole/cri-o/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/14rcole/cri-o/teams","hooks_url":"https://api.github.com/repos/14rcole/cri-o/hooks","issue_events_url":"https://api.github.com/repos/14rcole/cri-o/issues/events{/number}","events_url":"https://api.github.com/repos/14rcole/cri-o/events","assignees_url":"https://api.github.com/repos/14rcole/cri-o/assignees{/user}","branches_url":"https://api.github.com/repos/14rcole/cri-o/branches{/branch}","tags_url":"https://api.github.com/repos/14rcole/cri-o/tags","blobs_url":"https://api.github.com/repos/14rcole/cri-o/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/14rcole/cri-o/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/14rcole/cri-o/git/refs{/sha}","trees_url":"https://api.github.com/repos/14rcole/cri-o/git/trees{/sha}","statuses_url":"https://api.github.com/repos/14rcole/cri-o/statuses/{sha}","languages_url":"https://api.github.com/repos/14rcole/cri-o/languages","stargazers_url":"https://api.github.com/repos/14rcole/cri-o/stargazers","contributors_url":"https://api.github.com/repos/14rcole/cri-o/contributors","subscribers_url":"https://api.github.com/repos/14rcole/cri-o/subscribers","subscription_url":"https://api.github.com/repos/14rcole/cri-o/subscription","commits_url":"https://api.github.com/repos/14rcole/cri-o/commits{/sha}","git_commits_url":"https://api.github.com/repos/14rcole/cri-o/git/commits{/sha}","comments_url":"https://api.github.com/repos/14rcole/cri-o/comments{/number}","issue_comment_url":"https://api.github.com/repos/14rcole/cri-o/issues/comments{/number}","contents_url":"https://api.github.com/repos/14rcole/cri-o/contents/{+path}","compare_url":"https://api.github.com/repos/14rcole/cri-o/compare/{base}...{head}","merges_url":"https://api.github.com/repos/14rcole/cri-o/merges","archive_url":"https://api.github.com/repos/14rcole/cri-o/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/14rcole/cri-o/downloads","issues_url":"https://api.github.com/repos/14rcole/cri-o/issues{/number}","pulls_url":"https://api.github.com/repos/14rcole/cri-o/pulls{/number}","milestones_url":"https://api.github.com/repos/14rcole/cri-o/milestones{/number}","notifications_url":"https://api.github.com/repos/14rcole/cri-o/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/14rcole/cri-o/labels{/name}","releases_url":"https://api.github.com/repos/14rcole/cri-o/releases{/id}","deployments_url":"https://api.github.com/repos/14rcole/cri-o/deployments","created_at":"2016-10-13T17:29:46Z","updated_at":"2016-10-13T17:29:47Z","pushed_at":"2017-08-01T15:29:10Z","git_url":"git://github.com/14rcole/cri-o.git","ssh_url":"git@github.com:14rcole/cri-o.git","clone_url":"https://github.com/14rcole/cri-o.git","svn_url":"https://github.com/14rcole/cri-o","homepage":"","size":35666,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes-incubator:master","ref":"master","sha":"d574177c2a68736d5c0965c0e7231400c8cee557","user":{"login":"kubernetes-incubator","id":20862812,"avatar_url":"https://avatars2.githubusercontent.com/u/20862812?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes-incubator","html_url":"https://github.com/kubernetes-incubator","followers_url":"https://api.github.com/users/kubernetes-incubator/followers","following_url":"https://api.github.com/users/kubernetes-incubator/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-incubator/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-incubator/orgs","repos_url":"https://api.github.com/users/kubernetes-incubator/repos","events_url":"https://api.github.com/users/kubernetes-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-incubator/received_events","type":"Organization","site_admin":false},"repo":{"id":67828134,"name":"cri-o","full_name":"kubernetes-incubator/cri-o","owner":{"login":"kubernetes-incubator","id":20862812,"avatar_url":"https://avatars2.githubusercontent.com/u/20862812?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes-incubator","html_url":"https://github.com/kubernetes-incubator","followers_url":"https://api.github.com/users/kubernetes-incubator/followers","following_url":"https://api.github.com/users/kubernetes-incubator/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-incubator/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-incubator/orgs","repos_url":"https://api.github.com/users/kubernetes-incubator/repos","events_url":"https://api.github.com/users/kubernetes-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-incubator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes-incubator/cri-o","description":"Open Container Initiative-based implementation of Kubernetes Container Runtime Interface","fork":false,"url":"https://api.github.com/repos/kubernetes-incubator/cri-o","forks_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/forks","keys_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/teams","hooks_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/hooks","issue_events_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/events","assignees_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/tags","blobs_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/languages","stargazers_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/stargazers","contributors_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/contributors","subscribers_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/subscribers","subscription_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/subscription","commits_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/merges","archive_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/downloads","issues_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes-incubator/cri-o/deployments","created_at":"2016-09-09T19:56:31Z","updated_at":"2017-08-01T01:33:04Z","pushed_at":"2017-08-01T15:30:52Z","git_url":"git://github.com/kubernetes-incubator/cri-o.git","ssh_url":"git@github.com:kubernetes-incubator/cri-o.git","clone_url":"https://github.com/kubernetes-incubator/cri-o.git","svn_url":"https://github.com/kubernetes-incubator/cri-o","homepage":"","size":35521,"stargazers_count":516,"watchers_count":516,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":103,"mirror_url":null,"open_issues_count":70,"forks":103,"open_issues":70,"watchers":516,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes-incubator/cri-o/pulls/720"},"html":{"href":"https://github.com/kubernetes-incubator/cri-o/pull/720"},"issue":{"href":"https://api.github.com/repos/kubernetes-incubator/cri-o/issues/720"},"comments":{"href":"https://api.github.com/repos/kubernetes-incubator/cri-o/issues/720/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes-incubator/cri-o/pulls/720/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes-incubator/cri-o/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes-incubator/cri-o/pulls/720/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes-incubator/cri-o/statuses/bd2d460c48a1cbc601da9c6e66735c03691d0f2b"}}}}
{"actor":{"display_login":"mheon"}}