{"action":"created","comment":{"url":"https://api.github.com/repos/Metaswitch/sprout/pulls/comments/145638896","pull_request_review_id":67652337,"id":145638896,"diff_hunk":"@@ -763,9 +768,12 @@ void SubscriberDataManager::NotifySender::send_notifys_for_expired_subscriptions\n     NotifyUtils::RegistrationState::ACTIVE :\n     NotifyUtils::RegistrationState::TERMINATED;\n \n-  // expired_binding_uris lists bindings which have expired - we no longer have a valid connection to\n-  // these endpoints, so shouldn't send a NOTIFY to them (even to say that their subscription is\n-  // terminated).\n+  // Deleted_binding_uris lists bindings which no longer exists in AoR. \n+  // They may be deleted by administrative deregistration from Sprout/HSS, and ","path":"src/subscriber_data_manager.cpp","position":87,"original_position":87,"commit_id":"3fbdc0f0dd1399534996bf2e06f69b383e709530","original_commit_id":"3fbdc0f0dd1399534996bf2e06f69b383e709530","user":{"login":"eleanor-merry","id":5425325,"avatar_url":"https://avatars3.githubusercontent.com/u/5425325?v=4","gravatar_id":"","url":"https://api.github.com/users/eleanor-merry","html_url":"https://github.com/eleanor-merry","followers_url":"https://api.github.com/users/eleanor-merry/followers","following_url":"https://api.github.com/users/eleanor-merry/following{/other_user}","gists_url":"https://api.github.com/users/eleanor-merry/gists{/gist_id}","starred_url":"https://api.github.com/users/eleanor-merry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eleanor-merry/subscriptions","organizations_url":"https://api.github.com/users/eleanor-merry/orgs","repos_url":"https://api.github.com/users/eleanor-merry/repos","events_url":"https://api.github.com/users/eleanor-merry/events{/privacy}","received_events_url":"https://api.github.com/users/eleanor-merry/received_events","type":"User","site_admin":false},"body":"*have been. Also, I don't think you need the 'from Sprout/HSS' either. Also, removed rather than deleted?","created_at":"2017-10-19T09:03:14Z","updated_at":"2017-10-19T09:43:05Z","html_url":"https://github.com/Metaswitch/sprout/pull/1944#discussion_r145638896","pull_request_url":"https://api.github.com/repos/Metaswitch/sprout/pulls/1944","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Metaswitch/sprout/pulls/comments/145638896"},"html":{"href":"https://github.com/Metaswitch/sprout/pull/1944#discussion_r145638896"},"pull_request":{"href":"https://api.github.com/repos/Metaswitch/sprout/pulls/1944"}}},"pull_request":{"url":"https://api.github.com/repos/Metaswitch/sprout/pulls/1944","id":143367736,"html_url":"https://github.com/Metaswitch/sprout/pull/1944","diff_url":"https://github.com/Metaswitch/sprout/pull/1944.diff","patch_url":"https://github.com/Metaswitch/sprout/pull/1944.patch","issue_url":"https://api.github.com/repos/Metaswitch/sprout/issues/1944","number":1944,"state":"open","locked":false,"title":"Notify on deregister","user":{"login":"Ying-metaswitch","id":25749179,"avatar_url":"https://avatars2.githubusercontent.com/u/25749179?v=4","gravatar_id":"","url":"https://api.github.com/users/Ying-metaswitch","html_url":"https://github.com/Ying-metaswitch","followers_url":"https://api.github.com/users/Ying-metaswitch/followers","following_url":"https://api.github.com/users/Ying-metaswitch/following{/other_user}","gists_url":"https://api.github.com/users/Ying-metaswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Ying-metaswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ying-metaswitch/subscriptions","organizations_url":"https://api.github.com/users/Ying-metaswitch/orgs","repos_url":"https://api.github.com/users/Ying-metaswitch/repos","events_url":"https://api.github.com/users/Ying-metaswitch/events{/privacy}","received_events_url":"https://api.github.com/users/Ying-metaswitch/received_events","type":"User","site_admin":false},"body":"Code and UT complete. Live testing not done yet.","created_at":"2017-09-27T11:33:09Z","updated_at":"2017-10-19T09:43:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"00e651f9c871683e83e724d887151cf9035e2624","assignee":{"login":"eleanor-merry","id":5425325,"avatar_url":"https://avatars3.githubusercontent.com/u/5425325?v=4","gravatar_id":"","url":"https://api.github.com/users/eleanor-merry","html_url":"https://github.com/eleanor-merry","followers_url":"https://api.github.com/users/eleanor-merry/followers","following_url":"https://api.github.com/users/eleanor-merry/following{/other_user}","gists_url":"https://api.github.com/users/eleanor-merry/gists{/gist_id}","starred_url":"https://api.github.com/users/eleanor-merry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eleanor-merry/subscriptions","organizations_url":"https://api.github.com/users/eleanor-merry/orgs","repos_url":"https://api.github.com/users/eleanor-merry/repos","events_url":"https://api.github.com/users/eleanor-merry/events{/privacy}","received_events_url":"https://api.github.com/users/eleanor-merry/received_events","type":"User","site_admin":false},"assignees":[{"login":"eleanor-merry","id":5425325,"avatar_url":"https://avatars3.githubusercontent.com/u/5425325?v=4","gravatar_id":"","url":"https://api.github.com/users/eleanor-merry","html_url":"https://github.com/eleanor-merry","followers_url":"https://api.github.com/users/eleanor-merry/followers","following_url":"https://api.github.com/users/eleanor-merry/following{/other_user}","gists_url":"https://api.github.com/users/eleanor-merry/gists{/gist_id}","starred_url":"https://api.github.com/users/eleanor-merry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eleanor-merry/subscriptions","organizations_url":"https://api.github.com/users/eleanor-merry/orgs","repos_url":"https://api.github.com/users/eleanor-merry/repos","events_url":"https://api.github.com/users/eleanor-merry/events{/privacy}","received_events_url":"https://api.github.com/users/eleanor-merry/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Metaswitch/sprout/pulls/1944/commits","review_comments_url":"https://api.github.com/repos/Metaswitch/sprout/pulls/1944/comments","review_comment_url":"https://api.github.com/repos/Metaswitch/sprout/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Metaswitch/sprout/issues/1944/comments","statuses_url":"https://api.github.com/repos/Metaswitch/sprout/statuses/3fbdc0f0dd1399534996bf2e06f69b383e709530","head":{"label":"Metaswitch:notify_on_deregister","ref":"notify_on_deregister","sha":"3fbdc0f0dd1399534996bf2e06f69b383e709530","user":{"login":"Metaswitch","id":453759,"avatar_url":"https://avatars1.githubusercontent.com/u/453759?v=4","gravatar_id":"","url":"https://api.github.com/users/Metaswitch","html_url":"https://github.com/Metaswitch","followers_url":"https://api.github.com/users/Metaswitch/followers","following_url":"https://api.github.com/users/Metaswitch/following{/other_user}","gists_url":"https://api.github.com/users/Metaswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Metaswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Metaswitch/subscriptions","organizations_url":"https://api.github.com/users/Metaswitch/orgs","repos_url":"https://api.github.com/users/Metaswitch/repos","events_url":"https://api.github.com/users/Metaswitch/events{/privacy}","received_events_url":"https://api.github.com/users/Metaswitch/received_events","type":"Organization","site_admin":false},"repo":{"id":9887542,"name":"sprout","full_name":"Metaswitch/sprout","owner":{"login":"Metaswitch","id":453759,"avatar_url":"https://avatars1.githubusercontent.com/u/453759?v=4","gravatar_id":"","url":"https://api.github.com/users/Metaswitch","html_url":"https://github.com/Metaswitch","followers_url":"https://api.github.com/users/Metaswitch/followers","following_url":"https://api.github.com/users/Metaswitch/following{/other_user}","gists_url":"https://api.github.com/users/Metaswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Metaswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Metaswitch/subscriptions","organizations_url":"https://api.github.com/users/Metaswitch/orgs","repos_url":"https://api.github.com/users/Metaswitch/repos","events_url":"https://api.github.com/users/Metaswitch/events{/privacy}","received_events_url":"https://api.github.com/users/Metaswitch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Metaswitch/sprout","description":"sprout and bono, the Clearwater SIP router and edge proxy","fork":false,"url":"https://api.github.com/repos/Metaswitch/sprout","forks_url":"https://api.github.com/repos/Metaswitch/sprout/forks","keys_url":"https://api.github.com/repos/Metaswitch/sprout/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Metaswitch/sprout/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Metaswitch/sprout/teams","hooks_url":"https://api.github.com/repos/Metaswitch/sprout/hooks","issue_events_url":"https://api.github.com/repos/Metaswitch/sprout/issues/events{/number}","events_url":"https://api.github.com/repos/Metaswitch/sprout/events","assignees_url":"https://api.github.com/repos/Metaswitch/sprout/assignees{/user}","branches_url":"https://api.github.com/repos/Metaswitch/sprout/branches{/branch}","tags_url":"https://api.github.com/repos/Metaswitch/sprout/tags","blobs_url":"https://api.github.com/repos/Metaswitch/sprout/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Metaswitch/sprout/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Metaswitch/sprout/git/refs{/sha}","trees_url":"https://api.github.com/repos/Metaswitch/sprout/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Metaswitch/sprout/statuses/{sha}","languages_url":"https://api.github.com/repos/Metaswitch/sprout/languages","stargazers_url":"https://api.github.com/repos/Metaswitch/sprout/stargazers","contributors_url":"https://api.github.com/repos/Metaswitch/sprout/contributors","subscribers_url":"https://api.github.com/repos/Metaswitch/sprout/subscribers","subscription_url":"https://api.github.com/repos/Metaswitch/sprout/subscription","commits_url":"https://api.github.com/repos/Metaswitch/sprout/commits{/sha}","git_commits_url":"https://api.github.com/repos/Metaswitch/sprout/git/commits{/sha}","comments_url":"https://api.github.com/repos/Metaswitch/sprout/comments{/number}","issue_comment_url":"https://api.github.com/repos/Metaswitch/sprout/issues/comments{/number}","contents_url":"https://api.github.com/repos/Metaswitch/sprout/contents/{+path}","compare_url":"https://api.github.com/repos/Metaswitch/sprout/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Metaswitch/sprout/merges","archive_url":"https://api.github.com/repos/Metaswitch/sprout/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Metaswitch/sprout/downloads","issues_url":"https://api.github.com/repos/Metaswitch/sprout/issues{/number}","pulls_url":"https://api.github.com/repos/Metaswitch/sprout/pulls{/number}","milestones_url":"https://api.github.com/repos/Metaswitch/sprout/milestones{/number}","notifications_url":"https://api.github.com/repos/Metaswitch/sprout/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Metaswitch/sprout/labels{/name}","releases_url":"https://api.github.com/repos/Metaswitch/sprout/releases{/id}","deployments_url":"https://api.github.com/repos/Metaswitch/sprout/deployments","created_at":"2013-05-06T13:37:07Z","updated_at":"2017-10-11T15:26:48Z","pushed_at":"2017-10-19T09:36:25Z","git_url":"git://github.com/Metaswitch/sprout.git","ssh_url":"git@github.com:Metaswitch/sprout.git","clone_url":"https://github.com/Metaswitch/sprout.git","svn_url":"https://github.com/Metaswitch/sprout","homepage":null,"size":31397,"stargazers_count":22,"watchers_count":22,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":31,"mirror_url":null,"open_issues_count":172,"forks":31,"open_issues":172,"watchers":22,"default_branch":"dev"}},"base":{"label":"Metaswitch:dev","ref":"dev","sha":"f91b0e29435f504a9839b7e283e1fdec0be03e37","user":{"login":"Metaswitch","id":453759,"avatar_url":"https://avatars1.githubusercontent.com/u/453759?v=4","gravatar_id":"","url":"https://api.github.com/users/Metaswitch","html_url":"https://github.com/Metaswitch","followers_url":"https://api.github.com/users/Metaswitch/followers","following_url":"https://api.github.com/users/Metaswitch/following{/other_user}","gists_url":"https://api.github.com/users/Metaswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Metaswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Metaswitch/subscriptions","organizations_url":"https://api.github.com/users/Metaswitch/orgs","repos_url":"https://api.github.com/users/Metaswitch/repos","events_url":"https://api.github.com/users/Metaswitch/events{/privacy}","received_events_url":"https://api.github.com/users/Metaswitch/received_events","type":"Organization","site_admin":false},"repo":{"id":9887542,"name":"sprout","full_name":"Metaswitch/sprout","owner":{"login":"Metaswitch","id":453759,"avatar_url":"https://avatars1.githubusercontent.com/u/453759?v=4","gravatar_id":"","url":"https://api.github.com/users/Metaswitch","html_url":"https://github.com/Metaswitch","followers_url":"https://api.github.com/users/Metaswitch/followers","following_url":"https://api.github.com/users/Metaswitch/following{/other_user}","gists_url":"https://api.github.com/users/Metaswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Metaswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Metaswitch/subscriptions","organizations_url":"https://api.github.com/users/Metaswitch/orgs","repos_url":"https://api.github.com/users/Metaswitch/repos","events_url":"https://api.github.com/users/Metaswitch/events{/privacy}","received_events_url":"https://api.github.com/users/Metaswitch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Metaswitch/sprout","description":"sprout and bono, the Clearwater SIP router and edge proxy","fork":false,"url":"https://api.github.com/repos/Metaswitch/sprout","forks_url":"https://api.github.com/repos/Metaswitch/sprout/forks","keys_url":"https://api.github.com/repos/Metaswitch/sprout/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Metaswitch/sprout/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Metaswitch/sprout/teams","hooks_url":"https://api.github.com/repos/Metaswitch/sprout/hooks","issue_events_url":"https://api.github.com/repos/Metaswitch/sprout/issues/events{/number}","events_url":"https://api.github.com/repos/Metaswitch/sprout/events","assignees_url":"https://api.github.com/repos/Metaswitch/sprout/assignees{/user}","branches_url":"https://api.github.com/repos/Metaswitch/sprout/branches{/branch}","tags_url":"https://api.github.com/repos/Metaswitch/sprout/tags","blobs_url":"https://api.github.com/repos/Metaswitch/sprout/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Metaswitch/sprout/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Metaswitch/sprout/git/refs{/sha}","trees_url":"https://api.github.com/repos/Metaswitch/sprout/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Metaswitch/sprout/statuses/{sha}","languages_url":"https://api.github.com/repos/Metaswitch/sprout/languages","stargazers_url":"https://api.github.com/repos/Metaswitch/sprout/stargazers","contributors_url":"https://api.github.com/repos/Metaswitch/sprout/contributors","subscribers_url":"https://api.github.com/repos/Metaswitch/sprout/subscribers","subscription_url":"https://api.github.com/repos/Metaswitch/sprout/subscription","commits_url":"https://api.github.com/repos/Metaswitch/sprout/commits{/sha}","git_commits_url":"https://api.github.com/repos/Metaswitch/sprout/git/commits{/sha}","comments_url":"https://api.github.com/repos/Metaswitch/sprout/comments{/number}","issue_comment_url":"https://api.github.com/repos/Metaswitch/sprout/issues/comments{/number}","contents_url":"https://api.github.com/repos/Metaswitch/sprout/contents/{+path}","compare_url":"https://api.github.com/repos/Metaswitch/sprout/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Metaswitch/sprout/merges","archive_url":"https://api.github.com/repos/Metaswitch/sprout/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Metaswitch/sprout/downloads","issues_url":"https://api.github.com/repos/Metaswitch/sprout/issues{/number}","pulls_url":"https://api.github.com/repos/Metaswitch/sprout/pulls{/number}","milestones_url":"https://api.github.com/repos/Metaswitch/sprout/milestones{/number}","notifications_url":"https://api.github.com/repos/Metaswitch/sprout/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Metaswitch/sprout/labels{/name}","releases_url":"https://api.github.com/repos/Metaswitch/sprout/releases{/id}","deployments_url":"https://api.github.com/repos/Metaswitch/sprout/deployments","created_at":"2013-05-06T13:37:07Z","updated_at":"2017-10-11T15:26:48Z","pushed_at":"2017-10-19T09:36:25Z","git_url":"git://github.com/Metaswitch/sprout.git","ssh_url":"git@github.com:Metaswitch/sprout.git","clone_url":"https://github.com/Metaswitch/sprout.git","svn_url":"https://github.com/Metaswitch/sprout","homepage":null,"size":31397,"stargazers_count":22,"watchers_count":22,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":31,"mirror_url":null,"open_issues_count":172,"forks":31,"open_issues":172,"watchers":22,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Metaswitch/sprout/pulls/1944"},"html":{"href":"https://github.com/Metaswitch/sprout/pull/1944"},"issue":{"href":"https://api.github.com/repos/Metaswitch/sprout/issues/1944"},"comments":{"href":"https://api.github.com/repos/Metaswitch/sprout/issues/1944/comments"},"review_comments":{"href":"https://api.github.com/repos/Metaswitch/sprout/pulls/1944/comments"},"review_comment":{"href":"https://api.github.com/repos/Metaswitch/sprout/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Metaswitch/sprout/pulls/1944/commits"},"statuses":{"href":"https://api.github.com/repos/Metaswitch/sprout/statuses/3fbdc0f0dd1399534996bf2e06f69b383e709530"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"eleanor-merry"}}