{"action":"created","comment":{"url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/comments/102064341","pull_request_review_id":22809495,"id":102064341,"diff_hunk":"@@ -8,76 +8,84 @@\n \tthrow_speed = 4\n \tthrow_range = 10\n \tflags = CONDUCT\n-\n-var/list/storedwarrant = list() //All the warrants currently stored\n-var/activename = null\n-var/activecharges = null\n-var/activeauth = null //Currently active warrant\n-var/activetype = null //Is this a search or arrest warrtant?\n+\tvar/datum/data/record/warrant/active\n \n //look at it\n /obj/item/device/holowarrant/examine(mob/user)\n \t. = ..()\n-\tif(activename)\n-\t\tto_chat(user, \"It's a holographic warrant for '[activename]'.\")\n+\tif(active)\n+\t\tto_chat(user, \"It's a holographic warrant for '[active.fields[\"namewarrant\"]]'.\")\n \tif(in_range(user, src) || isghost(user))\n \t\tshow_content(user)\n \telse\n \t\tto_chat(user, \"<span class='notice'>You have to go closer if you want to read it.</span>\")\n \n //hit yourself with it\n /obj/item/device/holowarrant/attack_self(mob/living/user as mob)\n-\tif(!storedwarrant.len)\n-\t\tto_chat(user, \"There seem to be no warrants stored in the device. Please sync with the station's database.\")\n+\tactive = null\n+\tvar/list/warrants = list()\n+\tif(!isnull(data_core.general))\n+\t\tfor(var/datum/data/record/warrant/W in data_core.warrants)\n+\t\t\twarrants += W.fields[\"namewarrant\"]\n+\tif(warrants.len == 0)\n+\t\tto_chat(user,\"<span class='notice'>There are no warrants available</span>\")\n \t\treturn\n \tvar/temp\n-\ttemp = input(user, \"Which warrant would you like to load?\") as null|anything in storedwarrant\n+\ttemp = input(user, \"Which warrant would you like to load?\") as null|anything in warrants\n \tfor(var/datum/data/record/warrant/W in data_core.warrants)\n \t\tif(W.fields[\"namewarrant\"] == temp)\n-\t\t\tactivename = W.fields[\"namewarrant\"]\n-\t\t\tactivecharges = W.fields[\"charges\"]\n-\t\t\tactiveauth = W.fields [\"auth\"]\n-\t\t\tactivetype = W.fields[\"arrestsearch\"]\n+\t\t\tactive = W\n+\tupdate_icon()\n+\n+/obj/item/device/holowarrant/attackby(obj/item/weapon/W, mob/user)\n+\tif(active)","path":"code/game/objects/items/devices/holowarrant.dm","position":49,"original_position":49,"commit_id":"5afdbce4cd760882c2c26671dab6ef5abbc19a1c","original_commit_id":"5afdbce4cd760882c2c26671dab6ef5abbc19a1c","user":{"login":"atlantiscze","id":5147960,"avatar_url":"https://avatars.githubusercontent.com/u/5147960?v=3","gravatar_id":"","url":"https://api.github.com/users/atlantiscze","html_url":"https://github.com/atlantiscze","followers_url":"https://api.github.com/users/atlantiscze/followers","following_url":"https://api.github.com/users/atlantiscze/following{/other_user}","gists_url":"https://api.github.com/users/atlantiscze/gists{/gist_id}","starred_url":"https://api.github.com/users/atlantiscze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atlantiscze/subscriptions","organizations_url":"https://api.github.com/users/atlantiscze/orgs","repos_url":"https://api.github.com/users/atlantiscze/repos","events_url":"https://api.github.com/users/atlantiscze/events{/privacy}","received_events_url":"https://api.github.com/users/atlantiscze/received_events","type":"User","site_admin":false},"body":"IIRC most heads of staff have access_security. If not the access requirement should be amended accordingly, as it was like that on the Exodus.\r\n\r\nStill :-1: to allowing authorising without having access though. It's suposed to be a read-only device that you can show to the arrested person. All edits should go through the program which already handles access checks.","created_at":"2017-02-20T17:28:06Z","updated_at":"2017-02-20T17:28:06Z","html_url":"https://github.com/Baystation12/Baystation12/pull/16285#discussion_r102064341","pull_request_url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/16285","_links":{"self":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/comments/102064341"},"html":{"href":"https://github.com/Baystation12/Baystation12/pull/16285#discussion_r102064341"},"pull_request":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/16285"}}},"pull_request":{"url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/16285","id":106961134,"html_url":"https://github.com/Baystation12/Baystation12/pull/16285","diff_url":"https://github.com/Baystation12/Baystation12/pull/16285.diff","patch_url":"https://github.com/Baystation12/Baystation12/pull/16285.patch","issue_url":"https://api.github.com/repos/Baystation12/Baystation12/issues/16285","number":16285,"state":"open","locked":false,"title":"Holowarrant changes","user":{"login":"comma","id":1300258,"avatar_url":"https://avatars.githubusercontent.com/u/1300258?v=3","gravatar_id":"","url":"https://api.github.com/users/comma","html_url":"https://github.com/comma","followers_url":"https://api.github.com/users/comma/followers","following_url":"https://api.github.com/users/comma/following{/other_user}","gists_url":"https://api.github.com/users/comma/gists{/gist_id}","starred_url":"https://api.github.com/users/comma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/comma/subscriptions","organizations_url":"https://api.github.com/users/comma/orgs","repos_url":"https://api.github.com/users/comma/repos","events_url":"https://api.github.com/users/comma/events{/privacy}","received_events_url":"https://api.github.com/users/comma/received_events","type":"User","site_admin":false},"body":"Makes holowarrants sync when clicked inhand.\r\nRefactored holowarrants because god why. Global vars, duplicating every field of warrant instead of using fields, storing warrants locally not having any meaning since sync is not affected by power etc.\r\nAlso fixed all warrants being issued on authority of NAS Crescent in Nyx. As a side effect, added system name to map datum, Torch has its set randomly to unreadable star catalogue name because I hate people and want them to suffer.\r\nYou can also swipe ID at the device to authorize the active warrant.","created_at":"2017-02-20T08:45:50Z","updated_at":"2017-02-20T17:28:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"146110eb0f17cc0e1314f32125b929b2470a8687","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/16285/commits","review_comments_url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/16285/comments","review_comment_url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Baystation12/Baystation12/issues/16285/comments","statuses_url":"https://api.github.com/repos/Baystation12/Baystation12/statuses/5afdbce4cd760882c2c26671dab6ef5abbc19a1c","head":{"label":"comma:warrant","ref":"warrant","sha":"5afdbce4cd760882c2c26671dab6ef5abbc19a1c","user":{"login":"comma","id":1300258,"avatar_url":"https://avatars.githubusercontent.com/u/1300258?v=3","gravatar_id":"","url":"https://api.github.com/users/comma","html_url":"https://github.com/comma","followers_url":"https://api.github.com/users/comma/followers","following_url":"https://api.github.com/users/comma/following{/other_user}","gists_url":"https://api.github.com/users/comma/gists{/gist_id}","starred_url":"https://api.github.com/users/comma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/comma/subscriptions","organizations_url":"https://api.github.com/users/comma/orgs","repos_url":"https://api.github.com/users/comma/repos","events_url":"https://api.github.com/users/comma/events{/privacy}","received_events_url":"https://api.github.com/users/comma/received_events","type":"User","site_admin":false},"repo":{"id":3584505,"name":"Baystation12","full_name":"comma/Baystation12","owner":{"login":"comma","id":1300258,"avatar_url":"https://avatars.githubusercontent.com/u/1300258?v=3","gravatar_id":"","url":"https://api.github.com/users/comma","html_url":"https://github.com/comma","followers_url":"https://api.github.com/users/comma/followers","following_url":"https://api.github.com/users/comma/following{/other_user}","gists_url":"https://api.github.com/users/comma/gists{/gist_id}","starred_url":"https://api.github.com/users/comma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/comma/subscriptions","organizations_url":"https://api.github.com/users/comma/orgs","repos_url":"https://api.github.com/users/comma/repos","events_url":"https://api.github.com/users/comma/events{/privacy}","received_events_url":"https://api.github.com/users/comma/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/comma/Baystation12","description":"The code for Baystation12's branch of SS13.","fork":true,"url":"https://api.github.com/repos/comma/Baystation12","forks_url":"https://api.github.com/repos/comma/Baystation12/forks","keys_url":"https://api.github.com/repos/comma/Baystation12/keys{/key_id}","collaborators_url":"https://api.github.com/repos/comma/Baystation12/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/comma/Baystation12/teams","hooks_url":"https://api.github.com/repos/comma/Baystation12/hooks","issue_events_url":"https://api.github.com/repos/comma/Baystation12/issues/events{/number}","events_url":"https://api.github.com/repos/comma/Baystation12/events","assignees_url":"https://api.github.com/repos/comma/Baystation12/assignees{/user}","branches_url":"https://api.github.com/repos/comma/Baystation12/branches{/branch}","tags_url":"https://api.github.com/repos/comma/Baystation12/tags","blobs_url":"https://api.github.com/repos/comma/Baystation12/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/comma/Baystation12/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/comma/Baystation12/git/refs{/sha}","trees_url":"https://api.github.com/repos/comma/Baystation12/git/trees{/sha}","statuses_url":"https://api.github.com/repos/comma/Baystation12/statuses/{sha}","languages_url":"https://api.github.com/repos/comma/Baystation12/languages","stargazers_url":"https://api.github.com/repos/comma/Baystation12/stargazers","contributors_url":"https://api.github.com/repos/comma/Baystation12/contributors","subscribers_url":"https://api.github.com/repos/comma/Baystation12/subscribers","subscription_url":"https://api.github.com/repos/comma/Baystation12/subscription","commits_url":"https://api.github.com/repos/comma/Baystation12/commits{/sha}","git_commits_url":"https://api.github.com/repos/comma/Baystation12/git/commits{/sha}","comments_url":"https://api.github.com/repos/comma/Baystation12/comments{/number}","issue_comment_url":"https://api.github.com/repos/comma/Baystation12/issues/comments{/number}","contents_url":"https://api.github.com/repos/comma/Baystation12/contents/{+path}","compare_url":"https://api.github.com/repos/comma/Baystation12/compare/{base}...{head}","merges_url":"https://api.github.com/repos/comma/Baystation12/merges","archive_url":"https://api.github.com/repos/comma/Baystation12/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/comma/Baystation12/downloads","issues_url":"https://api.github.com/repos/comma/Baystation12/issues{/number}","pulls_url":"https://api.github.com/repos/comma/Baystation12/pulls{/number}","milestones_url":"https://api.github.com/repos/comma/Baystation12/milestones{/number}","notifications_url":"https://api.github.com/repos/comma/Baystation12/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/comma/Baystation12/labels{/name}","releases_url":"https://api.github.com/repos/comma/Baystation12/releases{/id}","deployments_url":"https://api.github.com/repos/comma/Baystation12/deployments","created_at":"2012-02-29T18:32:37Z","updated_at":"2016-11-20T02:30:51Z","pushed_at":"2017-02-20T15:44:28Z","git_url":"git://github.com/comma/Baystation12.git","ssh_url":"git@github.com:comma/Baystation12.git","clone_url":"https://github.com/comma/Baystation12.git","svn_url":"https://github.com/comma/Baystation12","homepage":"http://baystation12.net/","size":645836,"stargazers_count":3,"watchers_count":3,"language":"DM","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":9,"forks":0,"open_issues":9,"watchers":3,"default_branch":"dev"}},"base":{"label":"Baystation12:dev","ref":"dev","sha":"8f8420ec608848c916b71ce2b89b40017daf4c96","user":{"login":"Baystation12","id":1174322,"avatar_url":"https://avatars.githubusercontent.com/u/1174322?v=3","gravatar_id":"","url":"https://api.github.com/users/Baystation12","html_url":"https://github.com/Baystation12","followers_url":"https://api.github.com/users/Baystation12/followers","following_url":"https://api.github.com/users/Baystation12/following{/other_user}","gists_url":"https://api.github.com/users/Baystation12/gists{/gist_id}","starred_url":"https://api.github.com/users/Baystation12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Baystation12/subscriptions","organizations_url":"https://api.github.com/users/Baystation12/orgs","repos_url":"https://api.github.com/users/Baystation12/repos","events_url":"https://api.github.com/users/Baystation12/events{/privacy}","received_events_url":"https://api.github.com/users/Baystation12/received_events","type":"Organization","site_admin":false},"repo":{"id":2715933,"name":"Baystation12","full_name":"Baystation12/Baystation12","owner":{"login":"Baystation12","id":1174322,"avatar_url":"https://avatars.githubusercontent.com/u/1174322?v=3","gravatar_id":"","url":"https://api.github.com/users/Baystation12","html_url":"https://github.com/Baystation12","followers_url":"https://api.github.com/users/Baystation12/followers","following_url":"https://api.github.com/users/Baystation12/following{/other_user}","gists_url":"https://api.github.com/users/Baystation12/gists{/gist_id}","starred_url":"https://api.github.com/users/Baystation12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Baystation12/subscriptions","organizations_url":"https://api.github.com/users/Baystation12/orgs","repos_url":"https://api.github.com/users/Baystation12/repos","events_url":"https://api.github.com/users/Baystation12/events{/privacy}","received_events_url":"https://api.github.com/users/Baystation12/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Baystation12/Baystation12","description":"The code for Baystation12's branch of SS13","fork":false,"url":"https://api.github.com/repos/Baystation12/Baystation12","forks_url":"https://api.github.com/repos/Baystation12/Baystation12/forks","keys_url":"https://api.github.com/repos/Baystation12/Baystation12/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Baystation12/Baystation12/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Baystation12/Baystation12/teams","hooks_url":"https://api.github.com/repos/Baystation12/Baystation12/hooks","issue_events_url":"https://api.github.com/repos/Baystation12/Baystation12/issues/events{/number}","events_url":"https://api.github.com/repos/Baystation12/Baystation12/events","assignees_url":"https://api.github.com/repos/Baystation12/Baystation12/assignees{/user}","branches_url":"https://api.github.com/repos/Baystation12/Baystation12/branches{/branch}","tags_url":"https://api.github.com/repos/Baystation12/Baystation12/tags","blobs_url":"https://api.github.com/repos/Baystation12/Baystation12/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Baystation12/Baystation12/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Baystation12/Baystation12/git/refs{/sha}","trees_url":"https://api.github.com/repos/Baystation12/Baystation12/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Baystation12/Baystation12/statuses/{sha}","languages_url":"https://api.github.com/repos/Baystation12/Baystation12/languages","stargazers_url":"https://api.github.com/repos/Baystation12/Baystation12/stargazers","contributors_url":"https://api.github.com/repos/Baystation12/Baystation12/contributors","subscribers_url":"https://api.github.com/repos/Baystation12/Baystation12/subscribers","subscription_url":"https://api.github.com/repos/Baystation12/Baystation12/subscription","commits_url":"https://api.github.com/repos/Baystation12/Baystation12/commits{/sha}","git_commits_url":"https://api.github.com/repos/Baystation12/Baystation12/git/commits{/sha}","comments_url":"https://api.github.com/repos/Baystation12/Baystation12/comments{/number}","issue_comment_url":"https://api.github.com/repos/Baystation12/Baystation12/issues/comments{/number}","contents_url":"https://api.github.com/repos/Baystation12/Baystation12/contents/{+path}","compare_url":"https://api.github.com/repos/Baystation12/Baystation12/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Baystation12/Baystation12/merges","archive_url":"https://api.github.com/repos/Baystation12/Baystation12/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Baystation12/Baystation12/downloads","issues_url":"https://api.github.com/repos/Baystation12/Baystation12/issues{/number}","pulls_url":"https://api.github.com/repos/Baystation12/Baystation12/pulls{/number}","milestones_url":"https://api.github.com/repos/Baystation12/Baystation12/milestones{/number}","notifications_url":"https://api.github.com/repos/Baystation12/Baystation12/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Baystation12/Baystation12/labels{/name}","releases_url":"https://api.github.com/repos/Baystation12/Baystation12/releases{/id}","deployments_url":"https://api.github.com/repos/Baystation12/Baystation12/deployments","created_at":"2011-11-05T16:12:41Z","updated_at":"2017-02-18T20:54:03Z","pushed_at":"2017-02-20T17:15:23Z","git_url":"git://github.com/Baystation12/Baystation12.git","ssh_url":"git@github.com:Baystation12/Baystation12.git","clone_url":"https://github.com/Baystation12/Baystation12.git","svn_url":"https://github.com/Baystation12/Baystation12","homepage":"http://baystation12.net/","size":645926,"stargazers_count":241,"watchers_count":241,"language":"DM","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":808,"mirror_url":null,"open_issues_count":991,"forks":808,"open_issues":991,"watchers":241,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/16285"},"html":{"href":"https://github.com/Baystation12/Baystation12/pull/16285"},"issue":{"href":"https://api.github.com/repos/Baystation12/Baystation12/issues/16285"},"comments":{"href":"https://api.github.com/repos/Baystation12/Baystation12/issues/16285/comments"},"review_comments":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/16285/comments"},"review_comment":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/16285/commits"},"statuses":{"href":"https://api.github.com/repos/Baystation12/Baystation12/statuses/5afdbce4cd760882c2c26671dab6ef5abbc19a1c"}}}}
{"actor":{"display_login":"atlantiscze"}}