{"action":"created","comment":{"url":"https://api.github.com/repos/react-community/react-navigation/pulls/comments/99175902","pull_request_review_id":19844379,"id":99175902,"diff_hunk":"@@ -157,7 +157,10 @@ class TabView extends PureComponent<void, Props, void> {\n     let renderHeader;\n     let renderFooter;\n \n-    if (typeof tabBarComponent !== 'undefined') {\n+    const { state } = this.props.navigation;\n+    const tabBar = this.props.router.getScreenConfig(this.props.childNavigationProps[state.routes[state.index].key], 'tabBar');\n+\n+    if ((typeof tabBarComponent !== 'undefined') && (tabBar.visible !== false)) {","path":"src/views/TabView/TabView.js","position":8,"original_position":8,"commit_id":"67f554c10f80a3a7bd6e93738a9c49c5f468f4f9","original_commit_id":"67f554c10f80a3a7bd6e93738a9c49c5f468f4f9","user":{"login":"ericvicenti","id":1483597,"avatar_url":"https://avatars.githubusercontent.com/u/1483597?v=3","gravatar_id":"","url":"https://api.github.com/users/ericvicenti","html_url":"https://github.com/ericvicenti","followers_url":"https://api.github.com/users/ericvicenti/followers","following_url":"https://api.github.com/users/ericvicenti/following{/other_user}","gists_url":"https://api.github.com/users/ericvicenti/gists{/gist_id}","starred_url":"https://api.github.com/users/ericvicenti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericvicenti/subscriptions","organizations_url":"https://api.github.com/users/ericvicenti/orgs","repos_url":"https://api.github.com/users/ericvicenti/repos","events_url":"https://api.github.com/users/ericvicenti/events{/privacy}","received_events_url":"https://api.github.com/users/ericvicenti/received_events","type":"User","site_admin":false},"body":"You can just do `tabBarComponent !== undefined`","created_at":"2017-02-02T17:35:07Z","updated_at":"2017-02-02T17:35:35Z","html_url":"https://github.com/react-community/react-navigation/pull/152#discussion_r99175902","pull_request_url":"https://api.github.com/repos/react-community/react-navigation/pulls/152","_links":{"self":{"href":"https://api.github.com/repos/react-community/react-navigation/pulls/comments/99175902"},"html":{"href":"https://github.com/react-community/react-navigation/pull/152#discussion_r99175902"},"pull_request":{"href":"https://api.github.com/repos/react-community/react-navigation/pulls/152"}}},"pull_request":{"url":"https://api.github.com/repos/react-community/react-navigation/pulls/152","id":104318504,"html_url":"https://github.com/react-community/react-navigation/pull/152","diff_url":"https://github.com/react-community/react-navigation/pull/152.diff","patch_url":"https://github.com/react-community/react-navigation/pull/152.patch","issue_url":"https://api.github.com/repos/react-community/react-navigation/issues/152","number":152,"state":"open","locked":false,"title":"Add visible param to TabBar","user":{"login":"microwavesafe","id":1586235,"avatar_url":"https://avatars.githubusercontent.com/u/1586235?v=3","gravatar_id":"","url":"https://api.github.com/users/microwavesafe","html_url":"https://github.com/microwavesafe","followers_url":"https://api.github.com/users/microwavesafe/followers","following_url":"https://api.github.com/users/microwavesafe/following{/other_user}","gists_url":"https://api.github.com/users/microwavesafe/gists{/gist_id}","starred_url":"https://api.github.com/users/microwavesafe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microwavesafe/subscriptions","organizations_url":"https://api.github.com/users/microwavesafe/orgs","repos_url":"https://api.github.com/users/microwavesafe/repos","events_url":"https://api.github.com/users/microwavesafe/events{/privacy}","received_events_url":"https://api.github.com/users/microwavesafe/received_events","type":"User","site_admin":false},"body":"This implements the ability to hide the tabBar by setting visible = false\r\n\r\nIt can be turned on in the navigationOptions\r\n```\r\n    static navigationOptions = {\r\n        tabBar: ({ state }) => ({\r\n            label: 'Messaging',\r\n            visible: false,\r\n        }),\r\n    };\r\n```\r\nor accessed through SetParams (when #132 or similar functionality is implemented). See #136 for discussion.\r\n","created_at":"2017-02-02T11:21:58Z","updated_at":"2017-02-02T17:35:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"36cae7de75ad391cf16b83812231429d3ded7081","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/react-community/react-navigation/pulls/152/commits","review_comments_url":"https://api.github.com/repos/react-community/react-navigation/pulls/152/comments","review_comment_url":"https://api.github.com/repos/react-community/react-navigation/pulls/comments{/number}","comments_url":"https://api.github.com/repos/react-community/react-navigation/issues/152/comments","statuses_url":"https://api.github.com/repos/react-community/react-navigation/statuses/67f554c10f80a3a7bd6e93738a9c49c5f468f4f9","head":{"label":"microwavesafe:HideTabBar","ref":"HideTabBar","sha":"67f554c10f80a3a7bd6e93738a9c49c5f468f4f9","user":{"login":"microwavesafe","id":1586235,"avatar_url":"https://avatars.githubusercontent.com/u/1586235?v=3","gravatar_id":"","url":"https://api.github.com/users/microwavesafe","html_url":"https://github.com/microwavesafe","followers_url":"https://api.github.com/users/microwavesafe/followers","following_url":"https://api.github.com/users/microwavesafe/following{/other_user}","gists_url":"https://api.github.com/users/microwavesafe/gists{/gist_id}","starred_url":"https://api.github.com/users/microwavesafe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microwavesafe/subscriptions","organizations_url":"https://api.github.com/users/microwavesafe/orgs","repos_url":"https://api.github.com/users/microwavesafe/repos","events_url":"https://api.github.com/users/microwavesafe/events{/privacy}","received_events_url":"https://api.github.com/users/microwavesafe/received_events","type":"User","site_admin":false},"repo":{"id":80612151,"name":"react-navigation","full_name":"microwavesafe/react-navigation","owner":{"login":"microwavesafe","id":1586235,"avatar_url":"https://avatars.githubusercontent.com/u/1586235?v=3","gravatar_id":"","url":"https://api.github.com/users/microwavesafe","html_url":"https://github.com/microwavesafe","followers_url":"https://api.github.com/users/microwavesafe/followers","following_url":"https://api.github.com/users/microwavesafe/following{/other_user}","gists_url":"https://api.github.com/users/microwavesafe/gists{/gist_id}","starred_url":"https://api.github.com/users/microwavesafe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microwavesafe/subscriptions","organizations_url":"https://api.github.com/users/microwavesafe/orgs","repos_url":"https://api.github.com/users/microwavesafe/repos","events_url":"https://api.github.com/users/microwavesafe/events{/privacy}","received_events_url":"https://api.github.com/users/microwavesafe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/microwavesafe/react-navigation","description":"Learn once, navigate anywhere","fork":true,"url":"https://api.github.com/repos/microwavesafe/react-navigation","forks_url":"https://api.github.com/repos/microwavesafe/react-navigation/forks","keys_url":"https://api.github.com/repos/microwavesafe/react-navigation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/microwavesafe/react-navigation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/microwavesafe/react-navigation/teams","hooks_url":"https://api.github.com/repos/microwavesafe/react-navigation/hooks","issue_events_url":"https://api.github.com/repos/microwavesafe/react-navigation/issues/events{/number}","events_url":"https://api.github.com/repos/microwavesafe/react-navigation/events","assignees_url":"https://api.github.com/repos/microwavesafe/react-navigation/assignees{/user}","branches_url":"https://api.github.com/repos/microwavesafe/react-navigation/branches{/branch}","tags_url":"https://api.github.com/repos/microwavesafe/react-navigation/tags","blobs_url":"https://api.github.com/repos/microwavesafe/react-navigation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/microwavesafe/react-navigation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/microwavesafe/react-navigation/git/refs{/sha}","trees_url":"https://api.github.com/repos/microwavesafe/react-navigation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/microwavesafe/react-navigation/statuses/{sha}","languages_url":"https://api.github.com/repos/microwavesafe/react-navigation/languages","stargazers_url":"https://api.github.com/repos/microwavesafe/react-navigation/stargazers","contributors_url":"https://api.github.com/repos/microwavesafe/react-navigation/contributors","subscribers_url":"https://api.github.com/repos/microwavesafe/react-navigation/subscribers","subscription_url":"https://api.github.com/repos/microwavesafe/react-navigation/subscription","commits_url":"https://api.github.com/repos/microwavesafe/react-navigation/commits{/sha}","git_commits_url":"https://api.github.com/repos/microwavesafe/react-navigation/git/commits{/sha}","comments_url":"https://api.github.com/repos/microwavesafe/react-navigation/comments{/number}","issue_comment_url":"https://api.github.com/repos/microwavesafe/react-navigation/issues/comments{/number}","contents_url":"https://api.github.com/repos/microwavesafe/react-navigation/contents/{+path}","compare_url":"https://api.github.com/repos/microwavesafe/react-navigation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/microwavesafe/react-navigation/merges","archive_url":"https://api.github.com/repos/microwavesafe/react-navigation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/microwavesafe/react-navigation/downloads","issues_url":"https://api.github.com/repos/microwavesafe/react-navigation/issues{/number}","pulls_url":"https://api.github.com/repos/microwavesafe/react-navigation/pulls{/number}","milestones_url":"https://api.github.com/repos/microwavesafe/react-navigation/milestones{/number}","notifications_url":"https://api.github.com/repos/microwavesafe/react-navigation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/microwavesafe/react-navigation/labels{/name}","releases_url":"https://api.github.com/repos/microwavesafe/react-navigation/releases{/id}","deployments_url":"https://api.github.com/repos/microwavesafe/react-navigation/deployments","created_at":"2017-02-01T11:02:45Z","updated_at":"2017-02-01T11:02:46Z","pushed_at":"2017-02-02T11:30:55Z","git_url":"git://github.com/microwavesafe/react-navigation.git","ssh_url":"git@github.com:microwavesafe/react-navigation.git","clone_url":"https://github.com/microwavesafe/react-navigation.git","svn_url":"https://github.com/microwavesafe/react-navigation","homepage":"https://reactnavigation.org","size":6218,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"react-community:master","ref":"master","sha":"a64eb46c9ced9c84c11a53e1d25cd1da08a36804","user":{"login":"react-community","id":24483500,"avatar_url":"https://avatars.githubusercontent.com/u/24483500?v=3","gravatar_id":"","url":"https://api.github.com/users/react-community","html_url":"https://github.com/react-community","followers_url":"https://api.github.com/users/react-community/followers","following_url":"https://api.github.com/users/react-community/following{/other_user}","gists_url":"https://api.github.com/users/react-community/gists{/gist_id}","starred_url":"https://api.github.com/users/react-community/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/react-community/subscriptions","organizations_url":"https://api.github.com/users/react-community/orgs","repos_url":"https://api.github.com/users/react-community/repos","events_url":"https://api.github.com/users/react-community/events{/privacy}","received_events_url":"https://api.github.com/users/react-community/received_events","type":"Organization","site_admin":false},"repo":{"id":80149262,"name":"react-navigation","full_name":"react-community/react-navigation","owner":{"login":"react-community","id":24483500,"avatar_url":"https://avatars.githubusercontent.com/u/24483500?v=3","gravatar_id":"","url":"https://api.github.com/users/react-community","html_url":"https://github.com/react-community","followers_url":"https://api.github.com/users/react-community/followers","following_url":"https://api.github.com/users/react-community/following{/other_user}","gists_url":"https://api.github.com/users/react-community/gists{/gist_id}","starred_url":"https://api.github.com/users/react-community/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/react-community/subscriptions","organizations_url":"https://api.github.com/users/react-community/orgs","repos_url":"https://api.github.com/users/react-community/repos","events_url":"https://api.github.com/users/react-community/events{/privacy}","received_events_url":"https://api.github.com/users/react-community/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/react-community/react-navigation","description":"Learn once, navigate anywhere","fork":false,"url":"https://api.github.com/repos/react-community/react-navigation","forks_url":"https://api.github.com/repos/react-community/react-navigation/forks","keys_url":"https://api.github.com/repos/react-community/react-navigation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/react-community/react-navigation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/react-community/react-navigation/teams","hooks_url":"https://api.github.com/repos/react-community/react-navigation/hooks","issue_events_url":"https://api.github.com/repos/react-community/react-navigation/issues/events{/number}","events_url":"https://api.github.com/repos/react-community/react-navigation/events","assignees_url":"https://api.github.com/repos/react-community/react-navigation/assignees{/user}","branches_url":"https://api.github.com/repos/react-community/react-navigation/branches{/branch}","tags_url":"https://api.github.com/repos/react-community/react-navigation/tags","blobs_url":"https://api.github.com/repos/react-community/react-navigation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/react-community/react-navigation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/react-community/react-navigation/git/refs{/sha}","trees_url":"https://api.github.com/repos/react-community/react-navigation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/react-community/react-navigation/statuses/{sha}","languages_url":"https://api.github.com/repos/react-community/react-navigation/languages","stargazers_url":"https://api.github.com/repos/react-community/react-navigation/stargazers","contributors_url":"https://api.github.com/repos/react-community/react-navigation/contributors","subscribers_url":"https://api.github.com/repos/react-community/react-navigation/subscribers","subscription_url":"https://api.github.com/repos/react-community/react-navigation/subscription","commits_url":"https://api.github.com/repos/react-community/react-navigation/commits{/sha}","git_commits_url":"https://api.github.com/repos/react-community/react-navigation/git/commits{/sha}","comments_url":"https://api.github.com/repos/react-community/react-navigation/comments{/number}","issue_comment_url":"https://api.github.com/repos/react-community/react-navigation/issues/comments{/number}","contents_url":"https://api.github.com/repos/react-community/react-navigation/contents/{+path}","compare_url":"https://api.github.com/repos/react-community/react-navigation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/react-community/react-navigation/merges","archive_url":"https://api.github.com/repos/react-community/react-navigation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/react-community/react-navigation/downloads","issues_url":"https://api.github.com/repos/react-community/react-navigation/issues{/number}","pulls_url":"https://api.github.com/repos/react-community/react-navigation/pulls{/number}","milestones_url":"https://api.github.com/repos/react-community/react-navigation/milestones{/number}","notifications_url":"https://api.github.com/repos/react-community/react-navigation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/react-community/react-navigation/labels{/name}","releases_url":"https://api.github.com/repos/react-community/react-navigation/releases{/id}","deployments_url":"https://api.github.com/repos/react-community/react-navigation/deployments","created_at":"2017-01-26T19:51:40Z","updated_at":"2017-02-02T17:33:32Z","pushed_at":"2017-02-02T17:15:51Z","git_url":"git://github.com/react-community/react-navigation.git","ssh_url":"git@github.com:react-community/react-navigation.git","clone_url":"https://github.com/react-community/react-navigation.git","svn_url":"https://github.com/react-community/react-navigation","homepage":"https://reactnavigation.org","size":6224,"stargazers_count":1767,"watchers_count":1767,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":68,"mirror_url":null,"open_issues_count":66,"forks":68,"open_issues":66,"watchers":1767,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/react-community/react-navigation/pulls/152"},"html":{"href":"https://github.com/react-community/react-navigation/pull/152"},"issue":{"href":"https://api.github.com/repos/react-community/react-navigation/issues/152"},"comments":{"href":"https://api.github.com/repos/react-community/react-navigation/issues/152/comments"},"review_comments":{"href":"https://api.github.com/repos/react-community/react-navigation/pulls/152/comments"},"review_comment":{"href":"https://api.github.com/repos/react-community/react-navigation/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/react-community/react-navigation/pulls/152/commits"},"statuses":{"href":"https://api.github.com/repos/react-community/react-navigation/statuses/67f554c10f80a3a7bd6e93738a9c49c5f468f4f9"}}}}
{"actor":{"display_login":"ericvicenti"}}