{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/45676","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/45676/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/45676/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/45676/events","html_url":"https://github.com/kubernetes/kubernetes/pull/45676","id":228082277,"number":45676,"title":"Fix flag formatting errors in the node tests","user":{"login":"mtaufen","id":903617,"avatar_url":"https://avatars2.githubusercontent.com/u/903617?v=3","gravatar_id":"","url":"https://api.github.com/users/mtaufen","html_url":"https://github.com/mtaufen","followers_url":"https://api.github.com/users/mtaufen/followers","following_url":"https://api.github.com/users/mtaufen/following{/other_user}","gists_url":"https://api.github.com/users/mtaufen/gists{/gist_id}","starred_url":"https://api.github.com/users/mtaufen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtaufen/subscriptions","organizations_url":"https://api.github.com/users/mtaufen/orgs","repos_url":"https://api.github.com/users/mtaufen/repos","events_url":"https://api.github.com/users/mtaufen/events{/privacy}","received_events_url":"https://api.github.com/users/mtaufen/received_events","type":"User","site_admin":false},"labels":[{"id":414883982,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":477397086,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":148225179,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/lgtm","name":"lgtm","color":"15dd18","default":false},{"id":349530249,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":253450793,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/XS","name":"size/XS","color":"009900","default":false}],"state":"open","locked":false,"assignee":{"login":"Random-Liu","id":5821883,"avatar_url":"https://avatars0.githubusercontent.com/u/5821883?v=3","gravatar_id":"","url":"https://api.github.com/users/Random-Liu","html_url":"https://github.com/Random-Liu","followers_url":"https://api.github.com/users/Random-Liu/followers","following_url":"https://api.github.com/users/Random-Liu/following{/other_user}","gists_url":"https://api.github.com/users/Random-Liu/gists{/gist_id}","starred_url":"https://api.github.com/users/Random-Liu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Random-Liu/subscriptions","organizations_url":"https://api.github.com/users/Random-Liu/orgs","repos_url":"https://api.github.com/users/Random-Liu/repos","events_url":"https://api.github.com/users/Random-Liu/events{/privacy}","received_events_url":"https://api.github.com/users/Random-Liu/received_events","type":"User","site_admin":false},"assignees":[{"login":"Random-Liu","id":5821883,"avatar_url":"https://avatars0.githubusercontent.com/u/5821883?v=3","gravatar_id":"","url":"https://api.github.com/users/Random-Liu","html_url":"https://github.com/Random-Liu","followers_url":"https://api.github.com/users/Random-Liu/followers","following_url":"https://api.github.com/users/Random-Liu/following{/other_user}","gists_url":"https://api.github.com/users/Random-Liu/gists{/gist_id}","starred_url":"https://api.github.com/users/Random-Liu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Random-Liu/subscriptions","organizations_url":"https://api.github.com/users/Random-Liu/orgs","repos_url":"https://api.github.com/users/Random-Liu/repos","events_url":"https://api.github.com/users/Random-Liu/events{/privacy}","received_events_url":"https://api.github.com/users/Random-Liu/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2017-05-11T18:33:05Z","updated_at":"2017-05-12T05:51:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/45676","html_url":"https://github.com/kubernetes/kubernetes/pull/45676","diff_url":"https://github.com/kubernetes/kubernetes/pull/45676.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/45676.patch"},"body":"There were three problems:\r\n- Lack of a trailing space after prepending flags.\r\n- Passing multiple flags in a string to --kubelet-flags seems to confuse\r\nthe flag parser; it stops parsing ALL flags as soon as it sees the\r\nsecond kubelet flag. Fortunately, all instances of --kubelet-flags are\r\ncombined together, so we can just pass two of those.\r\n- --feature-gates should be passed to the test framework, which then\r\nforwards it to the kubelet, instead of using --kubelet-flags.\r\n\r\nThis hopefully fixes the dynamic config test failures on COS, which\r\nstarted after #45602. (See: https://k8s-testgrid.appspot.com/google-node#kubelet-serial-gce-e2e)\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/300989979","html_url":"https://github.com/kubernetes/kubernetes/pull/45676#issuecomment-300989979","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/45676","id":300989979,"user":{"login":"k8s-merge-robot","id":13653959,"avatar_url":"https://avatars3.githubusercontent.com/u/13653959?v=3","gravatar_id":"","url":"https://api.github.com/users/k8s-merge-robot","html_url":"https://github.com/k8s-merge-robot","followers_url":"https://api.github.com/users/k8s-merge-robot/followers","following_url":"https://api.github.com/users/k8s-merge-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-merge-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-merge-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-merge-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-merge-robot/orgs","repos_url":"https://api.github.com/users/k8s-merge-robot/repos","events_url":"https://api.github.com/users/k8s-merge-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-merge-robot/received_events","type":"User","site_admin":false},"created_at":"2017-05-12T05:51:45Z","updated_at":"2017-05-12T05:51:45Z","body":"@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]"}}
{"actor":{"display_login":"k8s-merge-robot"}}