{"action":"closed","number":4672,"pull_request":{"url":"https://api.github.com/repos/shuyangzhou/liferay-portal/pulls/4672","id":134994783,"html_url":"https://github.com/shuyangzhou/liferay-portal/pull/4672","diff_url":"https://github.com/shuyangzhou/liferay-portal/pull/4672.diff","patch_url":"https://github.com/shuyangzhou/liferay-portal/pull/4672.patch","issue_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/issues/4672","number":4672,"state":"closed","locked":false,"title":"LPS-73667 SF: run format-source","user":{"login":"mdelapenya","id":951580,"avatar_url":"https://avatars2.githubusercontent.com/u/951580?v=4","gravatar_id":"","url":"https://api.github.com/users/mdelapenya","html_url":"https://github.com/mdelapenya","followers_url":"https://api.github.com/users/mdelapenya/followers","following_url":"https://api.github.com/users/mdelapenya/following{/other_user}","gists_url":"https://api.github.com/users/mdelapenya/gists{/gist_id}","starred_url":"https://api.github.com/users/mdelapenya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdelapenya/subscriptions","organizations_url":"https://api.github.com/users/mdelapenya/orgs","repos_url":"https://api.github.com/users/mdelapenya/repos","events_url":"https://api.github.com/users/mdelapenya/events{/privacy}","received_events_url":"https://api.github.com/users/mdelapenya/received_events","type":"User","site_admin":false},"body":"Hey @shuyangzhou I've used the function as I mentioned in previous pull last comment (https://github.com/shuyangzhou/liferay-portal/pull/4655#issuecomment-321176304). I see benefits of using lambdas such as reutilisation, and even more, setting up the infra for OSGi bundles implementing retry logic. Please consider this approach. Besides, we use Java8, let's use it. Thanks","created_at":"2017-08-09T21:29:40Z","updated_at":"2017-08-10T00:05:52Z","closed_at":"2017-08-10T00:05:52Z","merged_at":null,"merge_commit_sha":"66902749281591456bb1454c6251926f7aa7bfcb","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/pulls/4672/commits","review_comments_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/pulls/4672/comments","review_comment_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/issues/4672/comments","statuses_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/statuses/e995d73ba0a53592322433f9c120e604e27cf087","head":{"label":"mdelapenya:LPS-73667-retry-jdbc-logic","ref":"LPS-73667-retry-jdbc-logic","sha":"e995d73ba0a53592322433f9c120e604e27cf087","user":{"login":"mdelapenya","id":951580,"avatar_url":"https://avatars2.githubusercontent.com/u/951580?v=4","gravatar_id":"","url":"https://api.github.com/users/mdelapenya","html_url":"https://github.com/mdelapenya","followers_url":"https://api.github.com/users/mdelapenya/followers","following_url":"https://api.github.com/users/mdelapenya/following{/other_user}","gists_url":"https://api.github.com/users/mdelapenya/gists{/gist_id}","starred_url":"https://api.github.com/users/mdelapenya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdelapenya/subscriptions","organizations_url":"https://api.github.com/users/mdelapenya/orgs","repos_url":"https://api.github.com/users/mdelapenya/repos","events_url":"https://api.github.com/users/mdelapenya/events{/privacy}","received_events_url":"https://api.github.com/users/mdelapenya/received_events","type":"User","site_admin":false},"repo":{"id":2147556,"name":"liferay-portal","full_name":"mdelapenya/liferay-portal","owner":{"login":"mdelapenya","id":951580,"avatar_url":"https://avatars2.githubusercontent.com/u/951580?v=4","gravatar_id":"","url":"https://api.github.com/users/mdelapenya","html_url":"https://github.com/mdelapenya","followers_url":"https://api.github.com/users/mdelapenya/followers","following_url":"https://api.github.com/users/mdelapenya/following{/other_user}","gists_url":"https://api.github.com/users/mdelapenya/gists{/gist_id}","starred_url":"https://api.github.com/users/mdelapenya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdelapenya/subscriptions","organizations_url":"https://api.github.com/users/mdelapenya/orgs","repos_url":"https://api.github.com/users/mdelapenya/repos","events_url":"https://api.github.com/users/mdelapenya/events{/privacy}","received_events_url":"https://api.github.com/users/mdelapenya/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mdelapenya/liferay-portal","description":null,"fork":true,"url":"https://api.github.com/repos/mdelapenya/liferay-portal","forks_url":"https://api.github.com/repos/mdelapenya/liferay-portal/forks","keys_url":"https://api.github.com/repos/mdelapenya/liferay-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mdelapenya/liferay-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mdelapenya/liferay-portal/teams","hooks_url":"https://api.github.com/repos/mdelapenya/liferay-portal/hooks","issue_events_url":"https://api.github.com/repos/mdelapenya/liferay-portal/issues/events{/number}","events_url":"https://api.github.com/repos/mdelapenya/liferay-portal/events","assignees_url":"https://api.github.com/repos/mdelapenya/liferay-portal/assignees{/user}","branches_url":"https://api.github.com/repos/mdelapenya/liferay-portal/branches{/branch}","tags_url":"https://api.github.com/repos/mdelapenya/liferay-portal/tags","blobs_url":"https://api.github.com/repos/mdelapenya/liferay-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mdelapenya/liferay-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mdelapenya/liferay-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/mdelapenya/liferay-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mdelapenya/liferay-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/mdelapenya/liferay-portal/languages","stargazers_url":"https://api.github.com/repos/mdelapenya/liferay-portal/stargazers","contributors_url":"https://api.github.com/repos/mdelapenya/liferay-portal/contributors","subscribers_url":"https://api.github.com/repos/mdelapenya/liferay-portal/subscribers","subscription_url":"https://api.github.com/repos/mdelapenya/liferay-portal/subscription","commits_url":"https://api.github.com/repos/mdelapenya/liferay-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/mdelapenya/liferay-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/mdelapenya/liferay-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/mdelapenya/liferay-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/mdelapenya/liferay-portal/contents/{+path}","compare_url":"https://api.github.com/repos/mdelapenya/liferay-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mdelapenya/liferay-portal/merges","archive_url":"https://api.github.com/repos/mdelapenya/liferay-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mdelapenya/liferay-portal/downloads","issues_url":"https://api.github.com/repos/mdelapenya/liferay-portal/issues{/number}","pulls_url":"https://api.github.com/repos/mdelapenya/liferay-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/mdelapenya/liferay-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/mdelapenya/liferay-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mdelapenya/liferay-portal/labels{/name}","releases_url":"https://api.github.com/repos/mdelapenya/liferay-portal/releases{/id}","deployments_url":"https://api.github.com/repos/mdelapenya/liferay-portal/deployments","created_at":"2011-08-03T08:55:47Z","updated_at":"2017-05-30T10:30:42Z","pushed_at":"2017-08-09T21:29:39Z","git_url":"git://github.com/mdelapenya/liferay-portal.git","ssh_url":"git@github.com:mdelapenya/liferay-portal.git","clone_url":"https://github.com/mdelapenya/liferay-portal.git","svn_url":"https://github.com/mdelapenya/liferay-portal","homepage":"http://www.liferay.com","size":12192048,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":0,"default_branch":"master"}},"base":{"label":"shuyangzhou:master","ref":"master","sha":"8b0e2a946721d90de5716713fc7dd3f3d94b40a1","user":{"login":"shuyangzhou","id":173369,"avatar_url":"https://avatars2.githubusercontent.com/u/173369?v=4","gravatar_id":"","url":"https://api.github.com/users/shuyangzhou","html_url":"https://github.com/shuyangzhou","followers_url":"https://api.github.com/users/shuyangzhou/followers","following_url":"https://api.github.com/users/shuyangzhou/following{/other_user}","gists_url":"https://api.github.com/users/shuyangzhou/gists{/gist_id}","starred_url":"https://api.github.com/users/shuyangzhou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shuyangzhou/subscriptions","organizations_url":"https://api.github.com/users/shuyangzhou/orgs","repos_url":"https://api.github.com/users/shuyangzhou/repos","events_url":"https://api.github.com/users/shuyangzhou/events{/privacy}","received_events_url":"https://api.github.com/users/shuyangzhou/received_events","type":"User","site_admin":false},"repo":{"id":1921247,"name":"liferay-portal","full_name":"shuyangzhou/liferay-portal","owner":{"login":"shuyangzhou","id":173369,"avatar_url":"https://avatars2.githubusercontent.com/u/173369?v=4","gravatar_id":"","url":"https://api.github.com/users/shuyangzhou","html_url":"https://github.com/shuyangzhou","followers_url":"https://api.github.com/users/shuyangzhou/followers","following_url":"https://api.github.com/users/shuyangzhou/following{/other_user}","gists_url":"https://api.github.com/users/shuyangzhou/gists{/gist_id}","starred_url":"https://api.github.com/users/shuyangzhou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shuyangzhou/subscriptions","organizations_url":"https://api.github.com/users/shuyangzhou/orgs","repos_url":"https://api.github.com/users/shuyangzhou/repos","events_url":"https://api.github.com/users/shuyangzhou/events{/privacy}","received_events_url":"https://api.github.com/users/shuyangzhou/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shuyangzhou/liferay-portal","description":null,"fork":true,"url":"https://api.github.com/repos/shuyangzhou/liferay-portal","forks_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/forks","keys_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/teams","hooks_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/hooks","issue_events_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/issues/events{/number}","events_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/events","assignees_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/assignees{/user}","branches_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/branches{/branch}","tags_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/tags","blobs_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/languages","stargazers_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/stargazers","contributors_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/contributors","subscribers_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/subscribers","subscription_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/subscription","commits_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/contents/{+path}","compare_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/merges","archive_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/downloads","issues_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/issues{/number}","pulls_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/labels{/name}","releases_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/releases{/id}","deployments_url":"https://api.github.com/repos/shuyangzhou/liferay-portal/deployments","created_at":"2011-06-20T00:16:27Z","updated_at":"2016-08-21T23:18:33Z","pushed_at":"2017-08-09T23:05:16Z","git_url":"git://github.com/shuyangzhou/liferay-portal.git","ssh_url":"git@github.com:shuyangzhou/liferay-portal.git","clone_url":"https://github.com/shuyangzhou/liferay-portal.git","svn_url":"https://github.com/shuyangzhou/liferay-portal","homepage":"http://liferay.com","size":12504778,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":44,"forks":1,"open_issues":44,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/shuyangzhou/liferay-portal/pulls/4672"},"html":{"href":"https://github.com/shuyangzhou/liferay-portal/pull/4672"},"issue":{"href":"https://api.github.com/repos/shuyangzhou/liferay-portal/issues/4672"},"comments":{"href":"https://api.github.com/repos/shuyangzhou/liferay-portal/issues/4672/comments"},"review_comments":{"href":"https://api.github.com/repos/shuyangzhou/liferay-portal/pulls/4672/comments"},"review_comment":{"href":"https://api.github.com/repos/shuyangzhou/liferay-portal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/shuyangzhou/liferay-portal/pulls/4672/commits"},"statuses":{"href":"https://api.github.com/repos/shuyangzhou/liferay-portal/statuses/e995d73ba0a53592322433f9c120e604e27cf087"}},"merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":3,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":144,"deletions":1,"changed_files":5}}
{"actor":{"display_login":"shuyangzhou"}}