{"action":"created","comment":{"url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/comments/139219982","pull_request_review_id":63126564,"id":139219982,"diff_hunk":"@@ -965,3 +1009,145 @@ void checkBlocks(TestBlock const& _blockFromFields, TestBlock const& _blockFromR\n //namespaces\n }\n }\n+\n+class bcTestFixture {\n+\tpublic:\n+\tbcTestFixture()\n+\t{\n+\t\ttest::BlockchainTestSuite suite;\n+\t\tstring casename = boost::unit_test::framework::current_test_case().p_name;","path":"test/tools/jsontests/BlockChainTests.cpp","position":321,"original_position":321,"commit_id":"b2ed3bafc46be7d1b0a80b5d14c2ea24f3da1ccf","original_commit_id":"b2ed3bafc46be7d1b0a80b5d14c2ea24f3da1ccf","user":{"login":"pirapira","id":44281,"avatar_url":"https://avatars0.githubusercontent.com/u/44281?v=4","gravatar_id":"","url":"https://api.github.com/users/pirapira","html_url":"https://github.com/pirapira","followers_url":"https://api.github.com/users/pirapira/followers","following_url":"https://api.github.com/users/pirapira/following{/other_user}","gists_url":"https://api.github.com/users/pirapira/gists{/gist_id}","starred_url":"https://api.github.com/users/pirapira/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pirapira/subscriptions","organizations_url":"https://api.github.com/users/pirapira/orgs","repos_url":"https://api.github.com/users/pirapira/repos","events_url":"https://api.github.com/users/pirapira/events{/privacy}","received_events_url":"https://api.github.com/users/pirapira/received_events","type":"User","site_admin":false},"body":"This can be `string const`.","created_at":"2017-09-15T18:30:42Z","updated_at":"2017-09-15T18:30:42Z","html_url":"https://github.com/ethereum/cpp-ethereum/pull/4499#discussion_r139219982","pull_request_url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/4499","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/comments/139219982"},"html":{"href":"https://github.com/ethereum/cpp-ethereum/pull/4499#discussion_r139219982"},"pull_request":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/4499"}}},"pull_request":{"url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/4499","id":141123303,"html_url":"https://github.com/ethereum/cpp-ethereum/pull/4499","diff_url":"https://github.com/ethereum/cpp-ethereum/pull/4499.diff","patch_url":"https://github.com/ethereum/cpp-ethereum/pull/4499.patch","issue_url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/4499","number":4499,"state":"open","locked":false,"title":"blockchain tests through TestSuite class","user":{"login":"winsvega","id":4492341,"avatar_url":"https://avatars2.githubusercontent.com/u/4492341?v=4","gravatar_id":"","url":"https://api.github.com/users/winsvega","html_url":"https://github.com/winsvega","followers_url":"https://api.github.com/users/winsvega/followers","following_url":"https://api.github.com/users/winsvega/following{/other_user}","gists_url":"https://api.github.com/users/winsvega/gists{/gist_id}","starred_url":"https://api.github.com/users/winsvega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/winsvega/subscriptions","organizations_url":"https://api.github.com/users/winsvega/orgs","repos_url":"https://api.github.com/users/winsvega/repos","events_url":"https://api.github.com/users/winsvega/events{/privacy}","received_events_url":"https://api.github.com/users/winsvega/received_events","type":"User","site_admin":false},"body":"run all blockchain tests through TestSuite run tests function.\r\n","created_at":"2017-09-14T16:39:34Z","updated_at":"2017-09-15T18:30:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a92390f9ea548553fe68a96265141f9ea819d3cf","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/4499/commits","review_comments_url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/4499/comments","review_comment_url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/4499/comments","statuses_url":"https://api.github.com/repos/ethereum/cpp-ethereum/statuses/b2ed3bafc46be7d1b0a80b5d14c2ea24f3da1ccf","head":{"label":"winsvega:develop","ref":"develop","sha":"b2ed3bafc46be7d1b0a80b5d14c2ea24f3da1ccf","user":{"login":"winsvega","id":4492341,"avatar_url":"https://avatars2.githubusercontent.com/u/4492341?v=4","gravatar_id":"","url":"https://api.github.com/users/winsvega","html_url":"https://github.com/winsvega","followers_url":"https://api.github.com/users/winsvega/followers","following_url":"https://api.github.com/users/winsvega/following{/other_user}","gists_url":"https://api.github.com/users/winsvega/gists{/gist_id}","starred_url":"https://api.github.com/users/winsvega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/winsvega/subscriptions","organizations_url":"https://api.github.com/users/winsvega/orgs","repos_url":"https://api.github.com/users/winsvega/repos","events_url":"https://api.github.com/users/winsvega/events{/privacy}","received_events_url":"https://api.github.com/users/winsvega/received_events","type":"User","site_admin":false},"repo":{"id":65844491,"name":"cpp-ethereum","full_name":"winsvega/cpp-ethereum","owner":{"login":"winsvega","id":4492341,"avatar_url":"https://avatars2.githubusercontent.com/u/4492341?v=4","gravatar_id":"","url":"https://api.github.com/users/winsvega","html_url":"https://github.com/winsvega","followers_url":"https://api.github.com/users/winsvega/followers","following_url":"https://api.github.com/users/winsvega/following{/other_user}","gists_url":"https://api.github.com/users/winsvega/gists{/gist_id}","starred_url":"https://api.github.com/users/winsvega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/winsvega/subscriptions","organizations_url":"https://api.github.com/users/winsvega/orgs","repos_url":"https://api.github.com/users/winsvega/repos","events_url":"https://api.github.com/users/winsvega/events{/privacy}","received_events_url":"https://api.github.com/users/winsvega/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/winsvega/cpp-ethereum","description":"Ethereum C++ client","fork":true,"url":"https://api.github.com/repos/winsvega/cpp-ethereum","forks_url":"https://api.github.com/repos/winsvega/cpp-ethereum/forks","keys_url":"https://api.github.com/repos/winsvega/cpp-ethereum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/winsvega/cpp-ethereum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/winsvega/cpp-ethereum/teams","hooks_url":"https://api.github.com/repos/winsvega/cpp-ethereum/hooks","issue_events_url":"https://api.github.com/repos/winsvega/cpp-ethereum/issues/events{/number}","events_url":"https://api.github.com/repos/winsvega/cpp-ethereum/events","assignees_url":"https://api.github.com/repos/winsvega/cpp-ethereum/assignees{/user}","branches_url":"https://api.github.com/repos/winsvega/cpp-ethereum/branches{/branch}","tags_url":"https://api.github.com/repos/winsvega/cpp-ethereum/tags","blobs_url":"https://api.github.com/repos/winsvega/cpp-ethereum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/winsvega/cpp-ethereum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/winsvega/cpp-ethereum/git/refs{/sha}","trees_url":"https://api.github.com/repos/winsvega/cpp-ethereum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/winsvega/cpp-ethereum/statuses/{sha}","languages_url":"https://api.github.com/repos/winsvega/cpp-ethereum/languages","stargazers_url":"https://api.github.com/repos/winsvega/cpp-ethereum/stargazers","contributors_url":"https://api.github.com/repos/winsvega/cpp-ethereum/contributors","subscribers_url":"https://api.github.com/repos/winsvega/cpp-ethereum/subscribers","subscription_url":"https://api.github.com/repos/winsvega/cpp-ethereum/subscription","commits_url":"https://api.github.com/repos/winsvega/cpp-ethereum/commits{/sha}","git_commits_url":"https://api.github.com/repos/winsvega/cpp-ethereum/git/commits{/sha}","comments_url":"https://api.github.com/repos/winsvega/cpp-ethereum/comments{/number}","issue_comment_url":"https://api.github.com/repos/winsvega/cpp-ethereum/issues/comments{/number}","contents_url":"https://api.github.com/repos/winsvega/cpp-ethereum/contents/{+path}","compare_url":"https://api.github.com/repos/winsvega/cpp-ethereum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/winsvega/cpp-ethereum/merges","archive_url":"https://api.github.com/repos/winsvega/cpp-ethereum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/winsvega/cpp-ethereum/downloads","issues_url":"https://api.github.com/repos/winsvega/cpp-ethereum/issues{/number}","pulls_url":"https://api.github.com/repos/winsvega/cpp-ethereum/pulls{/number}","milestones_url":"https://api.github.com/repos/winsvega/cpp-ethereum/milestones{/number}","notifications_url":"https://api.github.com/repos/winsvega/cpp-ethereum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/winsvega/cpp-ethereum/labels{/name}","releases_url":"https://api.github.com/repos/winsvega/cpp-ethereum/releases{/id}","deployments_url":"https://api.github.com/repos/winsvega/cpp-ethereum/deployments","created_at":"2016-08-16T18:35:08Z","updated_at":"2016-09-09T13:48:44Z","pushed_at":"2017-09-15T12:29:15Z","git_url":"git://github.com/winsvega/cpp-ethereum.git","ssh_url":"git@github.com:winsvega/cpp-ethereum.git","clone_url":"https://github.com/winsvega/cpp-ethereum.git","svn_url":"https://github.com/winsvega/cpp-ethereum","homepage":"http://www.ethdocs.org/en/latest/ethereum-clients/cpp-ethereum/","size":48505,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"ethereum:develop","ref":"develop","sha":"089653b47e911e100fd2e215de0432fc9069036a","user":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":15460666,"name":"cpp-ethereum","full_name":"ethereum/cpp-ethereum","owner":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethereum/cpp-ethereum","description":"Ethereum C++ client","fork":false,"url":"https://api.github.com/repos/ethereum/cpp-ethereum","forks_url":"https://api.github.com/repos/ethereum/cpp-ethereum/forks","keys_url":"https://api.github.com/repos/ethereum/cpp-ethereum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/cpp-ethereum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/cpp-ethereum/teams","hooks_url":"https://api.github.com/repos/ethereum/cpp-ethereum/hooks","issue_events_url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/cpp-ethereum/events","assignees_url":"https://api.github.com/repos/ethereum/cpp-ethereum/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/cpp-ethereum/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/cpp-ethereum/tags","blobs_url":"https://api.github.com/repos/ethereum/cpp-ethereum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/cpp-ethereum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/cpp-ethereum/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/cpp-ethereum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/cpp-ethereum/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/cpp-ethereum/languages","stargazers_url":"https://api.github.com/repos/ethereum/cpp-ethereum/stargazers","contributors_url":"https://api.github.com/repos/ethereum/cpp-ethereum/contributors","subscribers_url":"https://api.github.com/repos/ethereum/cpp-ethereum/subscribers","subscription_url":"https://api.github.com/repos/ethereum/cpp-ethereum/subscription","commits_url":"https://api.github.com/repos/ethereum/cpp-ethereum/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/cpp-ethereum/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/cpp-ethereum/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/cpp-ethereum/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/cpp-ethereum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/cpp-ethereum/merges","archive_url":"https://api.github.com/repos/ethereum/cpp-ethereum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/cpp-ethereum/downloads","issues_url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/cpp-ethereum/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/cpp-ethereum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/cpp-ethereum/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/cpp-ethereum/releases{/id}","deployments_url":"https://api.github.com/repos/ethereum/cpp-ethereum/deployments","created_at":"2013-12-26T21:26:06Z","updated_at":"2017-09-15T16:46:25Z","pushed_at":"2017-09-15T14:08:59Z","git_url":"git://github.com/ethereum/cpp-ethereum.git","ssh_url":"git@github.com:ethereum/cpp-ethereum.git","clone_url":"https://github.com/ethereum/cpp-ethereum.git","svn_url":"https://github.com/ethereum/cpp-ethereum","homepage":"http://cpp-ethereum.org","size":52607,"stargazers_count":1645,"watchers_count":1645,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1132,"mirror_url":null,"open_issues_count":317,"forks":1132,"open_issues":317,"watchers":1645,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/4499"},"html":{"href":"https://github.com/ethereum/cpp-ethereum/pull/4499"},"issue":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/4499"},"comments":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/4499/comments"},"review_comments":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/4499/comments"},"review_comment":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/4499/commits"},"statuses":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/statuses/b2ed3bafc46be7d1b0a80b5d14c2ea24f3da1ccf"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"pirapira"}}