{"action":"created","issue":{"url":"https://api.github.com/repos/ros2/ament_cmake_ros/issues/2","repository_url":"https://api.github.com/repos/ros2/ament_cmake_ros","labels_url":"https://api.github.com/repos/ros2/ament_cmake_ros/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/ros2/ament_cmake_ros/issues/2/comments","events_url":"https://api.github.com/repos/ros2/ament_cmake_ros/issues/2/events","html_url":"https://github.com/ros2/ament_cmake_ros/pull/2","id":267808087,"number":2,"title":"Add definition of ROS_PACKAGE_NAME","user":{"login":"dhood","id":5618076,"avatar_url":"https://avatars0.githubusercontent.com/u/5618076?v=4","gravatar_id":"","url":"https://api.github.com/users/dhood","html_url":"https://github.com/dhood","followers_url":"https://api.github.com/users/dhood/followers","following_url":"https://api.github.com/users/dhood/following{/other_user}","gists_url":"https://api.github.com/users/dhood/gists{/gist_id}","starred_url":"https://api.github.com/users/dhood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhood/subscriptions","organizations_url":"https://api.github.com/users/dhood/orgs","repos_url":"https://api.github.com/users/dhood/repos","events_url":"https://api.github.com/users/dhood/events{/privacy}","received_events_url":"https://api.github.com/users/dhood/received_events","type":"User","site_admin":false},"labels":[{"id":666362698,"url":"https://api.github.com/repos/ros2/ament_cmake_ros/labels/in%20review","name":"in review","color":"388be2","default":false}],"state":"open","locked":false,"assignee":{"login":"dhood","id":5618076,"avatar_url":"https://avatars0.githubusercontent.com/u/5618076?v=4","gravatar_id":"","url":"https://api.github.com/users/dhood","html_url":"https://github.com/dhood","followers_url":"https://api.github.com/users/dhood/followers","following_url":"https://api.github.com/users/dhood/following{/other_user}","gists_url":"https://api.github.com/users/dhood/gists{/gist_id}","starred_url":"https://api.github.com/users/dhood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhood/subscriptions","organizations_url":"https://api.github.com/users/dhood/orgs","repos_url":"https://api.github.com/users/dhood/repos","events_url":"https://api.github.com/users/dhood/events{/privacy}","received_events_url":"https://api.github.com/users/dhood/received_events","type":"User","site_admin":false},"assignees":[{"login":"dhood","id":5618076,"avatar_url":"https://avatars0.githubusercontent.com/u/5618076?v=4","gravatar_id":"","url":"https://api.github.com/users/dhood","html_url":"https://github.com/dhood","followers_url":"https://api.github.com/users/dhood/followers","following_url":"https://api.github.com/users/dhood/following{/other_user}","gists_url":"https://api.github.com/users/dhood/gists{/gist_id}","starred_url":"https://api.github.com/users/dhood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhood/subscriptions","organizations_url":"https://api.github.com/users/dhood/orgs","repos_url":"https://api.github.com/users/dhood/repos","events_url":"https://api.github.com/users/dhood/events{/privacy}","received_events_url":"https://api.github.com/users/dhood/received_events","type":"User","site_admin":false}],"milestone":null,"comments":7,"created_at":"2017-10-23T20:34:09Z","updated_at":"2017-11-14T17:14:42Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/ros2/ament_cmake_ros/pulls/2","html_url":"https://github.com/ros2/ament_cmake_ros/pull/2","diff_url":"https://github.com/ros2/ament_cmake_ros/pull/2.diff","patch_url":"https://github.com/ros2/ament_cmake_ros/pull/2.patch"},"body":"connects to ros2/rclcpp#389\r\n\r\nThis is needed for using a package's name as the default logger/logger prefix for ROS_INFO etc.\r\n\r\nPutting it in this package as opposed to rclcpp (where the logging macros would make use the package name) means that packages below rclcpp e.g. rmw can also use this in their logging calls to rcutils directly.\r\n\r\nHowever, it will require all packages e.g. demos to use ament_cmake_ros where they currently use ament_cmake, but I understand that we should be encouraging that anyway, correct?"},"comment":{"url":"https://api.github.com/repos/ros2/ament_cmake_ros/issues/comments/344330276","html_url":"https://github.com/ros2/ament_cmake_ros/pull/2#issuecomment-344330276","issue_url":"https://api.github.com/repos/ros2/ament_cmake_ros/issues/2","id":344330276,"user":{"login":"dhood","id":5618076,"avatar_url":"https://avatars0.githubusercontent.com/u/5618076?v=4","gravatar_id":"","url":"https://api.github.com/users/dhood","html_url":"https://github.com/dhood","followers_url":"https://api.github.com/users/dhood/followers","following_url":"https://api.github.com/users/dhood/following{/other_user}","gists_url":"https://api.github.com/users/dhood/gists{/gist_id}","starred_url":"https://api.github.com/users/dhood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhood/subscriptions","organizations_url":"https://api.github.com/users/dhood/orgs","repos_url":"https://api.github.com/users/dhood/repos","events_url":"https://api.github.com/users/dhood/events{/privacy}","received_events_url":"https://api.github.com/users/dhood/received_events","type":"User","site_admin":false},"created_at":"2017-11-14T17:14:42Z","updated_at":"2017-11-14T17:14:42Z","author_association":"OWNER","body":"this isn't required for https://github.com/ros2/rclcpp/pull/389 anymore: do we think it's better to merge it so users can have access to `ROS_PACKAGE_NAME`, or close this out so we don't have to maintain it?"}}
{"actor":{"display_login":"dhood"}}