{"action":"created","comment":{"url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/pulls/comments/115539182","pull_request_review_id":37085774,"id":115539182,"diff_hunk":"@@ -379,14 +364,27 @@ export class Pdf extends React.Component {\n     const pageClassNames = classNames({\n       'cf-pdf-pdfjs-container': true,\n       page: true,\n-      'cf-pdf-placing-comment': (this.props.commentFlowState ===\n-        Constants.PLACING_COMMENT_STATE)\n+      'cf-pdf-placing-comment': this.props.isPlacingAnnotation\n     });\n \n     this.pageContainers = [];\n \n-\n     for (let pageNumber = 1; pageNumber <= this.state.numPages; pageNumber++) {\n+      const onPageClick = (event) => {","path":"client/app/components/Pdf.jsx","position":97,"original_position":93,"commit_id":"17d952caa38e3225a031bc5e5411ff3cb61e4856","original_commit_id":"1985a10f776300c5bf76c5d50621414a5c5f993d","user":{"login":"NickHeiner","id":829827,"avatar_url":"https://avatars1.githubusercontent.com/u/829827?v=3","gravatar_id":"","url":"https://api.github.com/users/NickHeiner","html_url":"https://github.com/NickHeiner","followers_url":"https://api.github.com/users/NickHeiner/followers","following_url":"https://api.github.com/users/NickHeiner/following{/other_user}","gists_url":"https://api.github.com/users/NickHeiner/gists{/gist_id}","starred_url":"https://api.github.com/users/NickHeiner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NickHeiner/subscriptions","organizations_url":"https://api.github.com/users/NickHeiner/orgs","repos_url":"https://api.github.com/users/NickHeiner/repos","events_url":"https://api.github.com/users/NickHeiner/events{/privacy}","received_events_url":"https://api.github.com/users/NickHeiner/received_events","type":"User","site_admin":false},"body":"The reason to create it in the loop is that we're binding specific values from each iteration, like `pageNumber`. \r\n\r\nI can get around this by extracting the body of this loop into its own element. I'm fine doing that, but it will also continue to scope creep this PR. Which would you prefer?","created_at":"2017-05-09T16:41:13Z","updated_at":"2017-05-09T16:41:13Z","html_url":"https://github.com/department-of-veterans-affairs/caseflow/pull/1887#discussion_r115539182","pull_request_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/pulls/1887","_links":{"self":{"href":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/pulls/comments/115539182"},"html":{"href":"https://github.com/department-of-veterans-affairs/caseflow/pull/1887#discussion_r115539182"},"pull_request":{"href":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/pulls/1887"}}},"pull_request":{"url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/pulls/1887","id":119225414,"html_url":"https://github.com/department-of-veterans-affairs/caseflow/pull/1887","diff_url":"https://github.com/department-of-veterans-affairs/caseflow/pull/1887.diff","patch_url":"https://github.com/department-of-veterans-affairs/caseflow/pull/1887.patch","issue_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/issues/1887","number":1887,"state":"open","locked":false,"title":"[Reader] Annotations in redux","user":{"login":"NickHeiner","id":829827,"avatar_url":"https://avatars1.githubusercontent.com/u/829827?v=3","gravatar_id":"","url":"https://api.github.com/users/NickHeiner","html_url":"https://github.com/NickHeiner","followers_url":"https://api.github.com/users/NickHeiner/followers","following_url":"https://api.github.com/users/NickHeiner/following{/other_user}","gists_url":"https://api.github.com/users/NickHeiner/gists{/gist_id}","starred_url":"https://api.github.com/users/NickHeiner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NickHeiner/subscriptions","organizations_url":"https://api.github.com/users/NickHeiner/orgs","repos_url":"https://api.github.com/users/NickHeiner/repos","events_url":"https://api.github.com/users/NickHeiner/events{/privacy}","received_events_url":"https://api.github.com/users/NickHeiner/received_events","type":"User","site_admin":false},"body":"Connect #1854. This does not actually implement #1854, but once this is in, we can do #1854 quickly.\r\n\r\nSorry this is huge. @mdbenjam and I agreed for an earlier PR (#1760) that these PRs are best done by ripping off the bandaid instead of staying in a half-redux / half-setState world.\r\n\r\nIt will be good to get this in as quickly as possible; basically any other change to annotation handling will cause merge conflicts.\r\n\r\n## TODO\r\n* Use `_.keyBy`\r\n\r\n## To Test\r\nVerify:\r\n1. All existing annotation functionality still works\r\n1. You can edit multiple annotations at once (by clicking \"edit\")\r\n1. All annotation functionality is done via redux\r\n1. No dead code remains","created_at":"2017-05-05T17:48:47Z","updated_at":"2017-05-09T16:41:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ebd8d0894acdf7a0122cad721c3d40836e6f7389","assignee":{"login":"joofsh","id":2256237,"avatar_url":"https://avatars3.githubusercontent.com/u/2256237?v=3","gravatar_id":"","url":"https://api.github.com/users/joofsh","html_url":"https://github.com/joofsh","followers_url":"https://api.github.com/users/joofsh/followers","following_url":"https://api.github.com/users/joofsh/following{/other_user}","gists_url":"https://api.github.com/users/joofsh/gists{/gist_id}","starred_url":"https://api.github.com/users/joofsh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joofsh/subscriptions","organizations_url":"https://api.github.com/users/joofsh/orgs","repos_url":"https://api.github.com/users/joofsh/repos","events_url":"https://api.github.com/users/joofsh/events{/privacy}","received_events_url":"https://api.github.com/users/joofsh/received_events","type":"User","site_admin":false},"assignees":[{"login":"joofsh","id":2256237,"avatar_url":"https://avatars3.githubusercontent.com/u/2256237?v=3","gravatar_id":"","url":"https://api.github.com/users/joofsh","html_url":"https://github.com/joofsh","followers_url":"https://api.github.com/users/joofsh/followers","following_url":"https://api.github.com/users/joofsh/following{/other_user}","gists_url":"https://api.github.com/users/joofsh/gists{/gist_id}","starred_url":"https://api.github.com/users/joofsh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joofsh/subscriptions","organizations_url":"https://api.github.com/users/joofsh/orgs","repos_url":"https://api.github.com/users/joofsh/repos","events_url":"https://api.github.com/users/joofsh/events{/privacy}","received_events_url":"https://api.github.com/users/joofsh/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/pulls/1887/commits","review_comments_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/pulls/1887/comments","review_comment_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/issues/1887/comments","statuses_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/statuses/17d952caa38e3225a031bc5e5411ff3cb61e4856","head":{"label":"NickHeiner:1854-comments-in-redux","ref":"1854-comments-in-redux","sha":"17d952caa38e3225a031bc5e5411ff3cb61e4856","user":{"login":"NickHeiner","id":829827,"avatar_url":"https://avatars1.githubusercontent.com/u/829827?v=3","gravatar_id":"","url":"https://api.github.com/users/NickHeiner","html_url":"https://github.com/NickHeiner","followers_url":"https://api.github.com/users/NickHeiner/followers","following_url":"https://api.github.com/users/NickHeiner/following{/other_user}","gists_url":"https://api.github.com/users/NickHeiner/gists{/gist_id}","starred_url":"https://api.github.com/users/NickHeiner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NickHeiner/subscriptions","organizations_url":"https://api.github.com/users/NickHeiner/orgs","repos_url":"https://api.github.com/users/NickHeiner/repos","events_url":"https://api.github.com/users/NickHeiner/events{/privacy}","received_events_url":"https://api.github.com/users/NickHeiner/received_events","type":"User","site_admin":false},"repo":{"id":87469843,"name":"caseflow","full_name":"NickHeiner/caseflow","owner":{"login":"NickHeiner","id":829827,"avatar_url":"https://avatars1.githubusercontent.com/u/829827?v=3","gravatar_id":"","url":"https://api.github.com/users/NickHeiner","html_url":"https://github.com/NickHeiner","followers_url":"https://api.github.com/users/NickHeiner/followers","following_url":"https://api.github.com/users/NickHeiner/following{/other_user}","gists_url":"https://api.github.com/users/NickHeiner/gists{/gist_id}","starred_url":"https://api.github.com/users/NickHeiner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NickHeiner/subscriptions","organizations_url":"https://api.github.com/users/NickHeiner/orgs","repos_url":"https://api.github.com/users/NickHeiner/repos","events_url":"https://api.github.com/users/NickHeiner/events{/privacy}","received_events_url":"https://api.github.com/users/NickHeiner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/NickHeiner/caseflow","description":"Caseflow is a web application that enables the tracking and processing of appealed claims at the Board of Veterans' Appeals.","fork":true,"url":"https://api.github.com/repos/NickHeiner/caseflow","forks_url":"https://api.github.com/repos/NickHeiner/caseflow/forks","keys_url":"https://api.github.com/repos/NickHeiner/caseflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NickHeiner/caseflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NickHeiner/caseflow/teams","hooks_url":"https://api.github.com/repos/NickHeiner/caseflow/hooks","issue_events_url":"https://api.github.com/repos/NickHeiner/caseflow/issues/events{/number}","events_url":"https://api.github.com/repos/NickHeiner/caseflow/events","assignees_url":"https://api.github.com/repos/NickHeiner/caseflow/assignees{/user}","branches_url":"https://api.github.com/repos/NickHeiner/caseflow/branches{/branch}","tags_url":"https://api.github.com/repos/NickHeiner/caseflow/tags","blobs_url":"https://api.github.com/repos/NickHeiner/caseflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NickHeiner/caseflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NickHeiner/caseflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/NickHeiner/caseflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NickHeiner/caseflow/statuses/{sha}","languages_url":"https://api.github.com/repos/NickHeiner/caseflow/languages","stargazers_url":"https://api.github.com/repos/NickHeiner/caseflow/stargazers","contributors_url":"https://api.github.com/repos/NickHeiner/caseflow/contributors","subscribers_url":"https://api.github.com/repos/NickHeiner/caseflow/subscribers","subscription_url":"https://api.github.com/repos/NickHeiner/caseflow/subscription","commits_url":"https://api.github.com/repos/NickHeiner/caseflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/NickHeiner/caseflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/NickHeiner/caseflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/NickHeiner/caseflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/NickHeiner/caseflow/contents/{+path}","compare_url":"https://api.github.com/repos/NickHeiner/caseflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NickHeiner/caseflow/merges","archive_url":"https://api.github.com/repos/NickHeiner/caseflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NickHeiner/caseflow/downloads","issues_url":"https://api.github.com/repos/NickHeiner/caseflow/issues{/number}","pulls_url":"https://api.github.com/repos/NickHeiner/caseflow/pulls{/number}","milestones_url":"https://api.github.com/repos/NickHeiner/caseflow/milestones{/number}","notifications_url":"https://api.github.com/repos/NickHeiner/caseflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NickHeiner/caseflow/labels{/name}","releases_url":"https://api.github.com/repos/NickHeiner/caseflow/releases{/id}","deployments_url":"https://api.github.com/repos/NickHeiner/caseflow/deployments","created_at":"2017-04-06T20:02:17Z","updated_at":"2017-04-06T20:02:20Z","pushed_at":"2017-05-09T16:38:05Z","git_url":"git://github.com/NickHeiner/caseflow.git","ssh_url":"git@github.com:NickHeiner/caseflow.git","clone_url":"https://github.com/NickHeiner/caseflow.git","svn_url":"https://github.com/NickHeiner/caseflow","homepage":"","size":14248,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"department-of-veterans-affairs:master","ref":"master","sha":"7b990fe5cfc0754a4b8658a2fb792238d4dc117d","user":{"login":"department-of-veterans-affairs","id":5421563,"avatar_url":"https://avatars2.githubusercontent.com/u/5421563?v=3","gravatar_id":"","url":"https://api.github.com/users/department-of-veterans-affairs","html_url":"https://github.com/department-of-veterans-affairs","followers_url":"https://api.github.com/users/department-of-veterans-affairs/followers","following_url":"https://api.github.com/users/department-of-veterans-affairs/following{/other_user}","gists_url":"https://api.github.com/users/department-of-veterans-affairs/gists{/gist_id}","starred_url":"https://api.github.com/users/department-of-veterans-affairs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/department-of-veterans-affairs/subscriptions","organizations_url":"https://api.github.com/users/department-of-veterans-affairs/orgs","repos_url":"https://api.github.com/users/department-of-veterans-affairs/repos","events_url":"https://api.github.com/users/department-of-veterans-affairs/events{/privacy}","received_events_url":"https://api.github.com/users/department-of-veterans-affairs/received_events","type":"Organization","site_admin":false},"repo":{"id":51449239,"name":"caseflow","full_name":"department-of-veterans-affairs/caseflow","owner":{"login":"department-of-veterans-affairs","id":5421563,"avatar_url":"https://avatars2.githubusercontent.com/u/5421563?v=3","gravatar_id":"","url":"https://api.github.com/users/department-of-veterans-affairs","html_url":"https://github.com/department-of-veterans-affairs","followers_url":"https://api.github.com/users/department-of-veterans-affairs/followers","following_url":"https://api.github.com/users/department-of-veterans-affairs/following{/other_user}","gists_url":"https://api.github.com/users/department-of-veterans-affairs/gists{/gist_id}","starred_url":"https://api.github.com/users/department-of-veterans-affairs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/department-of-veterans-affairs/subscriptions","organizations_url":"https://api.github.com/users/department-of-veterans-affairs/orgs","repos_url":"https://api.github.com/users/department-of-veterans-affairs/repos","events_url":"https://api.github.com/users/department-of-veterans-affairs/events{/privacy}","received_events_url":"https://api.github.com/users/department-of-veterans-affairs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/department-of-veterans-affairs/caseflow","description":"Caseflow is a web application that enables the tracking and processing of appealed claims at the Board of Veterans' Appeals.","fork":false,"url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow","forks_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/forks","keys_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/teams","hooks_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/hooks","issue_events_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/issues/events{/number}","events_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/events","assignees_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/assignees{/user}","branches_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/branches{/branch}","tags_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/tags","blobs_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/statuses/{sha}","languages_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/languages","stargazers_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/stargazers","contributors_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/contributors","subscribers_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/subscribers","subscription_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/subscription","commits_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/contents/{+path}","compare_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/merges","archive_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/downloads","issues_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/issues{/number}","pulls_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/pulls{/number}","milestones_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/milestones{/number}","notifications_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/labels{/name}","releases_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/releases{/id}","deployments_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/deployments","created_at":"2016-02-10T15:20:50Z","updated_at":"2017-04-28T03:49:37Z","pushed_at":"2017-05-09T16:38:07Z","git_url":"git://github.com/department-of-veterans-affairs/caseflow.git","ssh_url":"git@github.com:department-of-veterans-affairs/caseflow.git","clone_url":"https://github.com/department-of-veterans-affairs/caseflow.git","svn_url":"https://github.com/department-of-veterans-affairs/caseflow","homepage":"","size":14911,"stargazers_count":10,"watchers_count":10,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":303,"forks":12,"open_issues":303,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/pulls/1887"},"html":{"href":"https://github.com/department-of-veterans-affairs/caseflow/pull/1887"},"issue":{"href":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/issues/1887"},"comments":{"href":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/issues/1887/comments"},"review_comments":{"href":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/pulls/1887/comments"},"review_comment":{"href":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/pulls/1887/commits"},"statuses":{"href":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/statuses/17d952caa38e3225a031bc5e5411ff3cb61e4856"}}}}
{"actor":{"display_login":"NickHeiner"}}