{"action":"created","issue":{"url":"https://api.github.com/repos/rentalutions/elements/issues/1","repository_url":"https://api.github.com/repos/rentalutions/elements","labels_url":"https://api.github.com/repos/rentalutions/elements/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/rentalutions/elements/issues/1/comments","events_url":"https://api.github.com/repos/rentalutions/elements/issues/1/events","html_url":"https://github.com/rentalutions/elements/issues/1","id":261342574,"number":1,"title":"FullPageModal lets body scroll when open","user":{"login":"pkrawc","id":7158581,"avatar_url":"https://avatars2.githubusercontent.com/u/7158581?v=4","gravatar_id":"","url":"https://api.github.com/users/pkrawc","html_url":"https://github.com/pkrawc","followers_url":"https://api.github.com/users/pkrawc/followers","following_url":"https://api.github.com/users/pkrawc/following{/other_user}","gists_url":"https://api.github.com/users/pkrawc/gists{/gist_id}","starred_url":"https://api.github.com/users/pkrawc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkrawc/subscriptions","organizations_url":"https://api.github.com/users/pkrawc/orgs","repos_url":"https://api.github.com/users/pkrawc/repos","events_url":"https://api.github.com/users/pkrawc/events{/privacy}","received_events_url":"https://api.github.com/users/pkrawc/received_events","type":"User","site_admin":false},"labels":[{"id":656468893,"url":"https://api.github.com/repos/rentalutions/elements/labels/bug","name":"bug","color":"ee0701","default":true},{"id":656468896,"url":"https://api.github.com/repos/rentalutions/elements/labels/help%20wanted","name":"help wanted","color":"128A0C","default":true}],"state":"closed","locked":false,"assignee":{"login":"kyleramirez","id":2177010,"avatar_url":"https://avatars1.githubusercontent.com/u/2177010?v=4","gravatar_id":"","url":"https://api.github.com/users/kyleramirez","html_url":"https://github.com/kyleramirez","followers_url":"https://api.github.com/users/kyleramirez/followers","following_url":"https://api.github.com/users/kyleramirez/following{/other_user}","gists_url":"https://api.github.com/users/kyleramirez/gists{/gist_id}","starred_url":"https://api.github.com/users/kyleramirez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyleramirez/subscriptions","organizations_url":"https://api.github.com/users/kyleramirez/orgs","repos_url":"https://api.github.com/users/kyleramirez/repos","events_url":"https://api.github.com/users/kyleramirez/events{/privacy}","received_events_url":"https://api.github.com/users/kyleramirez/received_events","type":"User","site_admin":false},"assignees":[{"login":"kyleramirez","id":2177010,"avatar_url":"https://avatars1.githubusercontent.com/u/2177010?v=4","gravatar_id":"","url":"https://api.github.com/users/kyleramirez","html_url":"https://github.com/kyleramirez","followers_url":"https://api.github.com/users/kyleramirez/followers","following_url":"https://api.github.com/users/kyleramirez/following{/other_user}","gists_url":"https://api.github.com/users/kyleramirez/gists{/gist_id}","starred_url":"https://api.github.com/users/kyleramirez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyleramirez/subscriptions","organizations_url":"https://api.github.com/users/kyleramirez/orgs","repos_url":"https://api.github.com/users/kyleramirez/repos","events_url":"https://api.github.com/users/kyleramirez/events{/privacy}","received_events_url":"https://api.github.com/users/kyleramirez/received_events","type":"User","site_admin":false},{"login":"pkrawc","id":7158581,"avatar_url":"https://avatars2.githubusercontent.com/u/7158581?v=4","gravatar_id":"","url":"https://api.github.com/users/pkrawc","html_url":"https://github.com/pkrawc","followers_url":"https://api.github.com/users/pkrawc/followers","following_url":"https://api.github.com/users/pkrawc/following{/other_user}","gists_url":"https://api.github.com/users/pkrawc/gists{/gist_id}","starred_url":"https://api.github.com/users/pkrawc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkrawc/subscriptions","organizations_url":"https://api.github.com/users/pkrawc/orgs","repos_url":"https://api.github.com/users/pkrawc/repos","events_url":"https://api.github.com/users/pkrawc/events{/privacy}","received_events_url":"https://api.github.com/users/pkrawc/received_events","type":"User","site_admin":false},{"login":"PrakashKoneru","id":15623407,"avatar_url":"https://avatars0.githubusercontent.com/u/15623407?v=4","gravatar_id":"","url":"https://api.github.com/users/PrakashKoneru","html_url":"https://github.com/PrakashKoneru","followers_url":"https://api.github.com/users/PrakashKoneru/followers","following_url":"https://api.github.com/users/PrakashKoneru/following{/other_user}","gists_url":"https://api.github.com/users/PrakashKoneru/gists{/gist_id}","starred_url":"https://api.github.com/users/PrakashKoneru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PrakashKoneru/subscriptions","organizations_url":"https://api.github.com/users/PrakashKoneru/orgs","repos_url":"https://api.github.com/users/PrakashKoneru/repos","events_url":"https://api.github.com/users/PrakashKoneru/events{/privacy}","received_events_url":"https://api.github.com/users/PrakashKoneru/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2017-09-28T14:38:15Z","updated_at":"2017-09-28T16:01:57Z","closed_at":"2017-09-28T16:01:57Z","author_association":"COLLABORATOR","body":"Hey,\n\nSo Prakash brought this up and I am tackling it real quick.The problem is that the FullPageModal let's the body scroll when open, causing somewhat of a disjointed effect for users. I propose (and @PrakashKoneru seems to agree) that the modal should attach a \"modal-open\" class to the body that is then used to set `overflow-y: hidden` on that body.\n\nThe easiest way to do this in my mind is to make the modal component a stateful component that can read it own 'open-ness'. This being the case I also believe that it'll be cleaner and produce less footprint later for the modal to be a FAC component and pass a toggle prop (or two functions, one open and one close) down. The modal body would need again to be moved to a render prop.\n\nI believe this is the best way to do it but before I commit anything I'd like to get a discussion going. "},"comment":{"url":"https://api.github.com/repos/rentalutions/elements/issues/comments/332883558","html_url":"https://github.com/rentalutions/elements/issues/1#issuecomment-332883558","issue_url":"https://api.github.com/repos/rentalutions/elements/issues/1","id":332883558,"user":{"login":"pkrawc","id":7158581,"avatar_url":"https://avatars2.githubusercontent.com/u/7158581?v=4","gravatar_id":"","url":"https://api.github.com/users/pkrawc","html_url":"https://github.com/pkrawc","followers_url":"https://api.github.com/users/pkrawc/followers","following_url":"https://api.github.com/users/pkrawc/following{/other_user}","gists_url":"https://api.github.com/users/pkrawc/gists{/gist_id}","starred_url":"https://api.github.com/users/pkrawc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkrawc/subscriptions","organizations_url":"https://api.github.com/users/pkrawc/orgs","repos_url":"https://api.github.com/users/pkrawc/repos","events_url":"https://api.github.com/users/pkrawc/events{/privacy}","received_events_url":"https://api.github.com/users/pkrawc/received_events","type":"User","site_admin":false},"created_at":"2017-09-28T16:01:57Z","updated_at":"2017-09-28T16:01:57Z","author_association":"COLLABORATOR","body":"It looks like we're going the second route and letting the parent component handle it still. I'm going to close this issue for now then. Thanks for the discussion!"}}
{"actor":{"display_login":"pkrawc"}}