{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-pulsar/pulls/comments/158764240","pull_request_review_id":85617519,"id":158764240,"diff_hunk":"@@ -230,6 +230,9 @@ message CommandProducer {\n \t/// If a producer name is specified, the name will be used,\n \t/// otherwise the broker will generate a unique name\n \toptional string producer_name = 4;\n+\n+\t/// Add optional metadata key=value to this producer\n+\trepeated KeyValue metadata    = 5;","path":"pulsar-common/src/main/proto/PulsarApi.proto","position":6,"original_position":6,"commit_id":"af9ba37708f9b3b57ad816d33eb17e9d43e8922e","original_commit_id":"af9ba37708f9b3b57ad816d33eb17e9d43e8922e","user":{"login":"yush1ga","id":22343413,"avatar_url":"https://avatars0.githubusercontent.com/u/22343413?v=4","gravatar_id":"","url":"https://api.github.com/users/yush1ga","html_url":"https://github.com/yush1ga","followers_url":"https://api.github.com/users/yush1ga/followers","following_url":"https://api.github.com/users/yush1ga/following{/other_user}","gists_url":"https://api.github.com/users/yush1ga/gists{/gist_id}","starred_url":"https://api.github.com/users/yush1ga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yush1ga/subscriptions","organizations_url":"https://api.github.com/users/yush1ga/orgs","repos_url":"https://api.github.com/users/yush1ga/repos","events_url":"https://api.github.com/users/yush1ga/events{/privacy}","received_events_url":"https://api.github.com/users/yush1ga/received_events","type":"User","site_admin":false},"body":"I think `optional` should be added for compatibility of other version.","created_at":"2017-12-27T05:30:47Z","updated_at":"2017-12-27T05:30:47Z","html_url":"https://github.com/apache/incubator-pulsar/pull/1009#discussion_r158764240","pull_request_url":"https://api.github.com/repos/apache/incubator-pulsar/pulls/1009","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-pulsar/pulls/comments/158764240"},"html":{"href":"https://github.com/apache/incubator-pulsar/pull/1009#discussion_r158764240"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-pulsar/pulls/1009"}},"in_reply_to_id":158588315},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-pulsar/pulls/1009","id":159944244,"html_url":"https://github.com/apache/incubator-pulsar/pull/1009","diff_url":"https://github.com/apache/incubator-pulsar/pull/1009.diff","patch_url":"https://github.com/apache/incubator-pulsar/pull/1009.patch","issue_url":"https://api.github.com/repos/apache/incubator-pulsar/issues/1009","number":1009,"state":"open","locked":false,"title":"Add optional key/value metadata to producers.","user":{"login":"cckellogg","id":240473,"avatar_url":"https://avatars1.githubusercontent.com/u/240473?v=4","gravatar_id":"","url":"https://api.github.com/users/cckellogg","html_url":"https://github.com/cckellogg","followers_url":"https://api.github.com/users/cckellogg/followers","following_url":"https://api.github.com/users/cckellogg/following{/other_user}","gists_url":"https://api.github.com/users/cckellogg/gists{/gist_id}","starred_url":"https://api.github.com/users/cckellogg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cckellogg/subscriptions","organizations_url":"https://api.github.com/users/cckellogg/orgs","repos_url":"https://api.github.com/users/cckellogg/repos","events_url":"https://api.github.com/users/cckellogg/events{/privacy}","received_events_url":"https://api.github.com/users/cckellogg/received_events","type":"User","site_admin":false},"body":"https://github.com/apache/incubator-pulsar/issues/980\r\n\r\n### Motivation\r\nAdd the ability to attach metadata (key/value strings) to a producer. This provides more context about a producer and is useful for debugging, ui interaction, and/or metrics aggregation.\r\n\r\n### Modifications\r\n- protobuf changes\r\n- metadata key/value strings to the producer\r\n\r\n","created_at":"2017-12-22T23:03:47Z","updated_at":"2017-12-27T05:30:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cce8d2368cf3fe18f19b9bacedd4fb797fbd2327","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-pulsar/pulls/1009/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-pulsar/pulls/1009/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-pulsar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-pulsar/issues/1009/comments","statuses_url":"https://api.github.com/repos/apache/incubator-pulsar/statuses/af9ba37708f9b3b57ad816d33eb17e9d43e8922e","head":{"label":"cckellogg:producer-metadata","ref":"producer-metadata","sha":"af9ba37708f9b3b57ad816d33eb17e9d43e8922e","user":{"login":"cckellogg","id":240473,"avatar_url":"https://avatars1.githubusercontent.com/u/240473?v=4","gravatar_id":"","url":"https://api.github.com/users/cckellogg","html_url":"https://github.com/cckellogg","followers_url":"https://api.github.com/users/cckellogg/followers","following_url":"https://api.github.com/users/cckellogg/following{/other_user}","gists_url":"https://api.github.com/users/cckellogg/gists{/gist_id}","starred_url":"https://api.github.com/users/cckellogg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cckellogg/subscriptions","organizations_url":"https://api.github.com/users/cckellogg/orgs","repos_url":"https://api.github.com/users/cckellogg/repos","events_url":"https://api.github.com/users/cckellogg/events{/privacy}","received_events_url":"https://api.github.com/users/cckellogg/received_events","type":"User","site_admin":false},"repo":{"id":96055270,"name":"incubator-pulsar","full_name":"cckellogg/incubator-pulsar","owner":{"login":"cckellogg","id":240473,"avatar_url":"https://avatars1.githubusercontent.com/u/240473?v=4","gravatar_id":"","url":"https://api.github.com/users/cckellogg","html_url":"https://github.com/cckellogg","followers_url":"https://api.github.com/users/cckellogg/followers","following_url":"https://api.github.com/users/cckellogg/following{/other_user}","gists_url":"https://api.github.com/users/cckellogg/gists{/gist_id}","starred_url":"https://api.github.com/users/cckellogg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cckellogg/subscriptions","organizations_url":"https://api.github.com/users/cckellogg/orgs","repos_url":"https://api.github.com/users/cckellogg/repos","events_url":"https://api.github.com/users/cckellogg/events{/privacy}","received_events_url":"https://api.github.com/users/cckellogg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cckellogg/incubator-pulsar","description":"Pulsar - distributed pub-sub messaging system","fork":true,"url":"https://api.github.com/repos/cckellogg/incubator-pulsar","forks_url":"https://api.github.com/repos/cckellogg/incubator-pulsar/forks","keys_url":"https://api.github.com/repos/cckellogg/incubator-pulsar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cckellogg/incubator-pulsar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cckellogg/incubator-pulsar/teams","hooks_url":"https://api.github.com/repos/cckellogg/incubator-pulsar/hooks","issue_events_url":"https://api.github.com/repos/cckellogg/incubator-pulsar/issues/events{/number}","events_url":"https://api.github.com/repos/cckellogg/incubator-pulsar/events","assignees_url":"https://api.github.com/repos/cckellogg/incubator-pulsar/assignees{/user}","branches_url":"https://api.github.com/repos/cckellogg/incubator-pulsar/branches{/branch}","tags_url":"https://api.github.com/repos/cckellogg/incubator-pulsar/tags","blobs_url":"https://api.github.com/repos/cckellogg/incubator-pulsar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cckellogg/incubator-pulsar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cckellogg/incubator-pulsar/git/refs{/sha}","trees_url":"https://api.github.com/repos/cckellogg/incubator-pulsar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cckellogg/incubator-pulsar/statuses/{sha}","languages_url":"https://api.github.com/repos/cckellogg/incubator-pulsar/languages","stargazers_url":"https://api.github.com/repos/cckellogg/incubator-pulsar/stargazers","contributors_url":"https://api.github.com/repos/cckellogg/incubator-pulsar/contributors","subscribers_url":"https://api.github.com/repos/cckellogg/incubator-pulsar/subscribers","subscription_url":"https://api.github.com/repos/cckellogg/incubator-pulsar/subscription","commits_url":"https://api.github.com/repos/cckellogg/incubator-pulsar/commits{/sha}","git_commits_url":"https://api.github.com/repos/cckellogg/incubator-pulsar/git/commits{/sha}","comments_url":"https://api.github.com/repos/cckellogg/incubator-pulsar/comments{/number}","issue_comment_url":"https://api.github.com/repos/cckellogg/incubator-pulsar/issues/comments{/number}","contents_url":"https://api.github.com/repos/cckellogg/incubator-pulsar/contents/{+path}","compare_url":"https://api.github.com/repos/cckellogg/incubator-pulsar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cckellogg/incubator-pulsar/merges","archive_url":"https://api.github.com/repos/cckellogg/incubator-pulsar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cckellogg/incubator-pulsar/downloads","issues_url":"https://api.github.com/repos/cckellogg/incubator-pulsar/issues{/number}","pulls_url":"https://api.github.com/repos/cckellogg/incubator-pulsar/pulls{/number}","milestones_url":"https://api.github.com/repos/cckellogg/incubator-pulsar/milestones{/number}","notifications_url":"https://api.github.com/repos/cckellogg/incubator-pulsar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cckellogg/incubator-pulsar/labels{/name}","releases_url":"https://api.github.com/repos/cckellogg/incubator-pulsar/releases{/id}","deployments_url":"https://api.github.com/repos/cckellogg/incubator-pulsar/deployments","created_at":"2017-07-02T23:57:09Z","updated_at":"2017-07-02T23:57:13Z","pushed_at":"2017-12-23T19:57:49Z","git_url":"git://github.com/cckellogg/incubator-pulsar.git","ssh_url":"git@github.com:cckellogg/incubator-pulsar.git","clone_url":"https://github.com/cckellogg/incubator-pulsar.git","svn_url":"https://github.com/cckellogg/incubator-pulsar","homepage":"https://pulsar.incubator.apache.org","size":14213,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"3e7cd2c57db9b7f9264738e53ea9a2783024545b","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":62117812,"name":"incubator-pulsar","full_name":"apache/incubator-pulsar","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-pulsar","description":"Pulsar - distributed pub-sub messaging system","fork":false,"url":"https://api.github.com/repos/apache/incubator-pulsar","forks_url":"https://api.github.com/repos/apache/incubator-pulsar/forks","keys_url":"https://api.github.com/repos/apache/incubator-pulsar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-pulsar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-pulsar/teams","hooks_url":"https://api.github.com/repos/apache/incubator-pulsar/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-pulsar/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-pulsar/events","assignees_url":"https://api.github.com/repos/apache/incubator-pulsar/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-pulsar/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-pulsar/tags","blobs_url":"https://api.github.com/repos/apache/incubator-pulsar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-pulsar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-pulsar/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-pulsar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-pulsar/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-pulsar/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-pulsar/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-pulsar/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-pulsar/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-pulsar/subscription","commits_url":"https://api.github.com/repos/apache/incubator-pulsar/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-pulsar/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-pulsar/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-pulsar/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-pulsar/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-pulsar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-pulsar/merges","archive_url":"https://api.github.com/repos/apache/incubator-pulsar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-pulsar/downloads","issues_url":"https://api.github.com/repos/apache/incubator-pulsar/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-pulsar/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-pulsar/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-pulsar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-pulsar/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-pulsar/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-pulsar/deployments","created_at":"2016-06-28T07:00:03Z","updated_at":"2017-12-26T14:38:09Z","pushed_at":"2017-12-26T20:41:47Z","git_url":"git://github.com/apache/incubator-pulsar.git","ssh_url":"git@github.com:apache/incubator-pulsar.git","clone_url":"https://github.com/apache/incubator-pulsar.git","svn_url":"https://github.com/apache/incubator-pulsar","homepage":"https://pulsar.incubator.apache.org","size":17407,"stargazers_count":1482,"watchers_count":1482,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":310,"mirror_url":null,"archived":false,"open_issues_count":134,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":310,"open_issues":134,"watchers":1482,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-pulsar/pulls/1009"},"html":{"href":"https://github.com/apache/incubator-pulsar/pull/1009"},"issue":{"href":"https://api.github.com/repos/apache/incubator-pulsar/issues/1009"},"comments":{"href":"https://api.github.com/repos/apache/incubator-pulsar/issues/1009/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-pulsar/pulls/1009/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-pulsar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-pulsar/pulls/1009/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-pulsar/statuses/af9ba37708f9b3b57ad816d33eb17e9d43e8922e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"yush1ga"}}