{"action":"created","issue":{"url":"https://api.github.com/repos/behnam/rust-unic/issues/61","repository_url":"https://api.github.com/repos/behnam/rust-unic","labels_url":"https://api.github.com/repos/behnam/rust-unic/issues/61/labels{/name}","comments_url":"https://api.github.com/repos/behnam/rust-unic/issues/61/comments","events_url":"https://api.github.com/repos/behnam/rust-unic/issues/61/events","html_url":"https://github.com/behnam/rust-unic/pull/61","id":246178014,"number":61,"title":"[ucd/category] add more cross component tests","user":{"login":"calum","id":22115035,"avatar_url":"https://avatars1.githubusercontent.com/u/22115035?v=4","gravatar_id":"","url":"https://api.github.com/users/calum","html_url":"https://github.com/calum","followers_url":"https://api.github.com/users/calum/followers","following_url":"https://api.github.com/users/calum/following{/other_user}","gists_url":"https://api.github.com/users/calum/gists{/gist_id}","starred_url":"https://api.github.com/users/calum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calum/subscriptions","organizations_url":"https://api.github.com/users/calum/orgs","repos_url":"https://api.github.com/users/calum/repos","events_url":"https://api.github.com/users/calum/events{/privacy}","received_events_url":"https://api.github.com/users/calum/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-07-27T21:42:44Z","updated_at":"2017-07-31T00:49:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/behnam/rust-unic/pulls/61","html_url":"https://github.com/behnam/rust-unic/pull/61","diff_url":"https://github.com/behnam/rust-unic/pull/61.diff","patch_url":"https://github.com/behnam/rust-unic/pull/61.patch"},"body":"This PR is my first attempt at closing #43. I have added 10 tests to the `category_tests.rs` test file.\r\n\r\nI also corrected a typo in `category.rs` which was causing one of my tests to fail. \r\n\r\nAny feedback would be appreciated and I am happy to make changes.\r\n\r\nUPDATE:\r\nI removed my test for Bidi types OtherNeutral since from the [table of Bidi character types](http://www.unicode.org/reports/tr9/#Table_Bidirectional_Character_Types) this includes the General_Category types:\r\n\r\n> All other characters, including OBJECT REPLACEMENT CHARACTER\r\n\r\nWhich is too general for a test - do you agree?"},"comment":{"url":"https://api.github.com/repos/behnam/rust-unic/issues/comments/318942301","html_url":"https://github.com/behnam/rust-unic/pull/61#issuecomment-318942301","issue_url":"https://api.github.com/repos/behnam/rust-unic/issues/61","id":318942301,"user":{"login":"behnam","id":37169,"avatar_url":"https://avatars2.githubusercontent.com/u/37169?v=4","gravatar_id":"","url":"https://api.github.com/users/behnam","html_url":"https://github.com/behnam","followers_url":"https://api.github.com/users/behnam/followers","following_url":"https://api.github.com/users/behnam/following{/other_user}","gists_url":"https://api.github.com/users/behnam/gists{/gist_id}","starred_url":"https://api.github.com/users/behnam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/behnam/subscriptions","organizations_url":"https://api.github.com/users/behnam/orgs","repos_url":"https://api.github.com/users/behnam/repos","events_url":"https://api.github.com/users/behnam/events{/privacy}","received_events_url":"https://api.github.com/users/behnam/received_events","type":"User","site_admin":false},"created_at":"2017-07-31T00:49:47Z","updated_at":"2017-07-31T00:49:47Z","body":"We use the in the code link this: https://github.com/behnam/rust-unic/blob/master/unic/bidi/src/implicit.rs#L238\r\n```\r\nfn is_NI(class: BidiClass) -> bool {\r\n    matches!(class, B | S | WS | ON | FSI | LRI | RLI | PDI)\r\n}\r\n```\r\n\r\nFirst, you need to add it to the manifest (`Cargo.toml`) like this: <https://github.com/behnam/rust-unic/blob/master/unic/bidi/Cargo.toml#L26>. In this case, since it's only used in the tests, it goes under `dev-dependencies`, like this:\r\n```\r\n[dev-dependencies]\r\nmatches = \"0.1\"\r\n```\r\n\r\nAlso, on top of the crate (the test file, in this case), you need to tell rustc to use the external resource, like this: <https://github.com/behnam/rust-unic/blob/master/unic/bidi/src/lib.rs#L72>.  Note that you need to explicitly enable macro usage:\r\n```\r\n#[macro_use]\r\nextern crate matches;\r\n```\r\n\r\n(PS. The reason for explicit macro usage is lack of namespace system for macros. There's some discussion online about this already.)\r\n\r\nLet me know if that resolves the issue. If not, I'll be glad to help if you provide more info."}}
{"actor":{"display_login":"behnam"}}