{"action":"created","issue":{"url":"https://api.github.com/repos/magento/magento2/issues/11152","repository_url":"https://api.github.com/repos/magento/magento2","labels_url":"https://api.github.com/repos/magento/magento2/issues/11152/labels{/name}","comments_url":"https://api.github.com/repos/magento/magento2/issues/11152/comments","events_url":"https://api.github.com/repos/magento/magento2/issues/11152/events","html_url":"https://github.com/magento/magento2/pull/11152","id":261793416,"number":11152,"title":"Fix bug reset message must create an instance of \"MessageInterface\"","user":{"login":"jalogut","id":6410900,"avatar_url":"https://avatars2.githubusercontent.com/u/6410900?v=4","gravatar_id":"","url":"https://api.github.com/users/jalogut","html_url":"https://github.com/jalogut","followers_url":"https://api.github.com/users/jalogut/followers","following_url":"https://api.github.com/users/jalogut/following{/other_user}","gists_url":"https://api.github.com/users/jalogut/gists{/gist_id}","starred_url":"https://api.github.com/users/jalogut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jalogut/subscriptions","organizations_url":"https://api.github.com/users/jalogut/orgs","repos_url":"https://api.github.com/users/jalogut/repos","events_url":"https://api.github.com/users/jalogut/events{/privacy}","received_events_url":"https://api.github.com/users/jalogut/received_events","type":"User","site_admin":false},"labels":[{"id":161563561,"url":"https://api.github.com/repos/magento/magento2/labels/needs%20update","name":"needs update","color":"b60205","default":false}],"state":"open","locked":false,"assignee":{"login":"dmanners","id":1572836,"avatar_url":"https://avatars2.githubusercontent.com/u/1572836?v=4","gravatar_id":"","url":"https://api.github.com/users/dmanners","html_url":"https://github.com/dmanners","followers_url":"https://api.github.com/users/dmanners/followers","following_url":"https://api.github.com/users/dmanners/following{/other_user}","gists_url":"https://api.github.com/users/dmanners/gists{/gist_id}","starred_url":"https://api.github.com/users/dmanners/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmanners/subscriptions","organizations_url":"https://api.github.com/users/dmanners/orgs","repos_url":"https://api.github.com/users/dmanners/repos","events_url":"https://api.github.com/users/dmanners/events{/privacy}","received_events_url":"https://api.github.com/users/dmanners/received_events","type":"User","site_admin":false},"assignees":[{"login":"dmanners","id":1572836,"avatar_url":"https://avatars2.githubusercontent.com/u/1572836?v=4","gravatar_id":"","url":"https://api.github.com/users/dmanners","html_url":"https://github.com/dmanners","followers_url":"https://api.github.com/users/dmanners/followers","following_url":"https://api.github.com/users/dmanners/following{/other_user}","gists_url":"https://api.github.com/users/dmanners/gists{/gist_id}","starred_url":"https://api.github.com/users/dmanners/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmanners/subscriptions","organizations_url":"https://api.github.com/users/dmanners/orgs","repos_url":"https://api.github.com/users/dmanners/repos","events_url":"https://api.github.com/users/dmanners/events{/privacy}","received_events_url":"https://api.github.com/users/dmanners/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2017-09-29T23:04:45Z","updated_at":"2017-10-03T08:14:30Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/magento/magento2/pulls/11152","html_url":"https://github.com/magento/magento2/pull/11152","diff_url":"https://github.com/magento/magento2/pull/11152.diff","patch_url":"https://github.com/magento/magento2/pull/11152.patch"},"body":"On line 245 the object manager should return an instance of `\\Magento\\Framework\\Mail\\MessageInterface` same type as original message created on constructor (line 100)\r\nHowever the objectManager does not use the `MessageInterface`. That causes unexpected results when the message is reseted because `$this->message` does no longer have the type set in the preferences `di.xml` for `\\Magento\\Framework\\Mail\\MessageInterface`\r\n\r\nAlso remove use of `objectManager` as it is no longer a good practise"},"comment":{"url":"https://api.github.com/repos/magento/magento2/issues/comments/333771815","html_url":"https://github.com/magento/magento2/pull/11152#issuecomment-333771815","issue_url":"https://api.github.com/repos/magento/magento2/issues/11152","id":333771815,"user":{"login":"jalogut","id":6410900,"avatar_url":"https://avatars2.githubusercontent.com/u/6410900?v=4","gravatar_id":"","url":"https://api.github.com/users/jalogut","html_url":"https://github.com/jalogut","followers_url":"https://api.github.com/users/jalogut/followers","following_url":"https://api.github.com/users/jalogut/following{/other_user}","gists_url":"https://api.github.com/users/jalogut/gists{/gist_id}","starred_url":"https://api.github.com/users/jalogut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jalogut/subscriptions","organizations_url":"https://api.github.com/users/jalogut/orgs","repos_url":"https://api.github.com/users/jalogut/repos","events_url":"https://api.github.com/users/jalogut/events{/privacy}","received_events_url":"https://api.github.com/users/jalogut/received_events","type":"User","site_admin":false},"created_at":"2017-10-03T08:14:30Z","updated_at":"2017-10-03T08:14:30Z","author_association":"CONTRIBUTOR","body":"Ok, let's make it a bit simpler, in order to keep backwards compatibility then."}}
{"actor":{"display_login":"jalogut"}}