{"action":"created","issue":{"url":"https://api.github.com/repos/sourcelair/xterm.js/issues/644","repository_url":"https://api.github.com/repos/sourcelair/xterm.js","labels_url":"https://api.github.com/repos/sourcelair/xterm.js/issues/644/labels{/name}","comments_url":"https://api.github.com/repos/sourcelair/xterm.js/issues/644/comments","events_url":"https://api.github.com/repos/sourcelair/xterm.js/issues/644/events","html_url":"https://github.com/sourcelair/xterm.js/pull/644","id":223798610,"number":644,"title":"Add logic for reflowing lines","user":{"login":"LucianBuzzo","id":15064535,"avatar_url":"https://avatars0.githubusercontent.com/u/15064535?v=4","gravatar_id":"","url":"https://api.github.com/users/LucianBuzzo","html_url":"https://github.com/LucianBuzzo","followers_url":"https://api.github.com/users/LucianBuzzo/followers","following_url":"https://api.github.com/users/LucianBuzzo/following{/other_user}","gists_url":"https://api.github.com/users/LucianBuzzo/gists{/gist_id}","starred_url":"https://api.github.com/users/LucianBuzzo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LucianBuzzo/subscriptions","organizations_url":"https://api.github.com/users/LucianBuzzo/orgs","repos_url":"https://api.github.com/users/LucianBuzzo/repos","events_url":"https://api.github.com/users/LucianBuzzo/events{/privacy}","received_events_url":"https://api.github.com/users/LucianBuzzo/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":24,"created_at":"2017-04-24T12:11:47Z","updated_at":"2017-08-03T16:31:16Z","closed_at":"2017-08-03T16:31:16Z","pull_request":{"url":"https://api.github.com/repos/sourcelair/xterm.js/pulls/644","html_url":"https://github.com/sourcelair/xterm.js/pull/644","diff_url":"https://github.com/sourcelair/xterm.js/pull/644.diff","patch_url":"https://github.com/sourcelair/xterm.js/pull/644.patch"},"body":"Connects to #622 \r\n\r\nI believe this approach will be more stable and easier to manage than the one previously proposed in  https://github.com/sourcelair/xterm.js/pull/609\r\nOne thing I realised after working on the previous reflow PR was that you have a lot of instances where input intentionally writes over EOL and then expects to overwrite the wrapped characters using a carriage return or `CSI Ps ; Ps H`. \r\nUsing the dynamic reflow I had proposed previously, it's very difficult to compensate for this behaviour without a lot of trickery.\r\n\r\nAs it stands this PR appears to work very well, though I'm sure that it needs more testing.\r\nI'd greatly appreciate people trying to break the implementation and then posting their feedback here.\r\n"},"comment":{"url":"https://api.github.com/repos/sourcelair/xterm.js/issues/comments/320021873","html_url":"https://github.com/sourcelair/xterm.js/pull/644#issuecomment-320021873","issue_url":"https://api.github.com/repos/sourcelair/xterm.js/issues/644","id":320021873,"user":{"login":"Tyriar","id":2193314,"avatar_url":"https://avatars0.githubusercontent.com/u/2193314?v=4","gravatar_id":"","url":"https://api.github.com/users/Tyriar","html_url":"https://github.com/Tyriar","followers_url":"https://api.github.com/users/Tyriar/followers","following_url":"https://api.github.com/users/Tyriar/following{/other_user}","gists_url":"https://api.github.com/users/Tyriar/gists{/gist_id}","starred_url":"https://api.github.com/users/Tyriar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tyriar/subscriptions","organizations_url":"https://api.github.com/users/Tyriar/orgs","repos_url":"https://api.github.com/users/Tyriar/repos","events_url":"https://api.github.com/users/Tyriar/events{/privacy}","received_events_url":"https://api.github.com/users/Tyriar/received_events","type":"User","site_admin":false},"created_at":"2017-08-03T16:31:16Z","updated_at":"2017-08-03T16:31:16Z","body":"Closing this as it's not going to get merged for performance/design reasons and it's really out of sync now. It is very useful as a reference though so I've pulled some of the key findings out into https://github.com/sourcelair/xterm.js/issues/622"}}
{"actor":{"display_login":"Tyriar"}}