{"action":"closed","number":15745,"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/15745","id":118610170,"html_url":"https://github.com/joomla/joomla-cms/pull/15745","diff_url":"https://github.com/joomla/joomla-cms/pull/15745.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/15745.patch","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/15745","number":15745,"state":"closed","locked":false,"title":"Fixing wrong default value for calendar showtime attribute","user":{"login":"Bakual","id":1018684,"avatar_url":"https://avatars1.githubusercontent.com/u/1018684?v=3","gravatar_id":"","url":"https://api.github.com/users/Bakual","html_url":"https://github.com/Bakual","followers_url":"https://api.github.com/users/Bakual/followers","following_url":"https://api.github.com/users/Bakual/following{/other_user}","gists_url":"https://api.github.com/users/Bakual/gists{/gist_id}","starred_url":"https://api.github.com/users/Bakual/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bakual/subscriptions","organizations_url":"https://api.github.com/users/Bakual/orgs","repos_url":"https://api.github.com/users/Bakual/repos","events_url":"https://api.github.com/users/Bakual/events{/privacy}","received_events_url":"https://api.github.com/users/Bakual/received_events","type":"User","site_admin":false},"body":"The new calendar can now show a time field which the old calendar couldn't. Unfortunately this new feature is enabled by default which means the calendar now shows a time field for all extensions using it regardless if the field expects a time part or not. This is a wrong behavior due to (at least) two points:\r\n* The attribute is named `showtime` which implies that if not present it would not show a time. But actually to show the time you can omit it completely and to hide it you need to add `showtime=\"false\"`\r\n* The default format attribute for the calendar field is `%Y-%m-%d`, which means it expects only the date.\r\n\r\n### Summary of Changes\r\nThis PR changes the default value for that attribute to `false` instead of `true`.\r\n\r\n\r\n### Testing Instructions\r\n* Change for example the article.xml file and adjust the `publish_up` field (https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_content/models/forms/article.xml#L102-L109). Remove the `showtime` attribute.\r\n\r\n\r\n### Expected result\r\nThe calendar shows no time field\r\n\r\n\r\n### Actual result\r\nThe calendar shows a time field\r\n\r\n#### Further Testing\r\n* Make sure saving works and doesn't give you a warning, especially when testing with another language where the date format is different to english (eg german).\r\n* Test with various combinations of the `translateformat`, `showtime` and `format` attributes. For example removing them all should result in the date only.\r\n\r\n### Documentation Changes Required\r\nNone\r\nObviously, this is not fully backward compatible with 3.7.0 as it changes the default behavior. Imho it isn't a big deal as it only affects the display of the calendar popup.","created_at":"2017-05-02T17:53:56Z","updated_at":"2017-05-03T08:35:09Z","closed_at":"2017-05-03T08:35:09Z","merged_at":"2017-05-03T08:35:09Z","merge_commit_sha":"cd805e6c231fa6ce7a29662539f1c8dc3a796029","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/joomla/joomla-cms/milestones/21","html_url":"https://github.com/joomla/joomla-cms/milestone/21","labels_url":"https://api.github.com/repos/joomla/joomla-cms/milestones/21/labels","id":2443852,"number":21,"title":"Joomla 3.7.1","description":"","creator":{"login":"rdeutz","id":467356,"avatar_url":"https://avatars3.githubusercontent.com/u/467356?v=3","gravatar_id":"","url":"https://api.github.com/users/rdeutz","html_url":"https://github.com/rdeutz","followers_url":"https://api.github.com/users/rdeutz/followers","following_url":"https://api.github.com/users/rdeutz/following{/other_user}","gists_url":"https://api.github.com/users/rdeutz/gists{/gist_id}","starred_url":"https://api.github.com/users/rdeutz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdeutz/subscriptions","organizations_url":"https://api.github.com/users/rdeutz/orgs","repos_url":"https://api.github.com/users/rdeutz/repos","events_url":"https://api.github.com/users/rdeutz/events{/privacy}","received_events_url":"https://api.github.com/users/rdeutz/received_events","type":"User","site_admin":false},"open_issues":11,"closed_issues":25,"state":"open","created_at":"2017-04-07T18:06:15Z","updated_at":"2017-05-03T08:35:09Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/15745/commits","review_comments_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/15745/comments","review_comment_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/15745/comments","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/20fb0a95349dabcf82bf0e31d52f069377793cd3","head":{"label":"Bakual:WrongDefaultForShowtime","ref":"WrongDefaultForShowtime","sha":"20fb0a95349dabcf82bf0e31d52f069377793cd3","user":{"login":"Bakual","id":1018684,"avatar_url":"https://avatars1.githubusercontent.com/u/1018684?v=3","gravatar_id":"","url":"https://api.github.com/users/Bakual","html_url":"https://github.com/Bakual","followers_url":"https://api.github.com/users/Bakual/followers","following_url":"https://api.github.com/users/Bakual/following{/other_user}","gists_url":"https://api.github.com/users/Bakual/gists{/gist_id}","starred_url":"https://api.github.com/users/Bakual/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bakual/subscriptions","organizations_url":"https://api.github.com/users/Bakual/orgs","repos_url":"https://api.github.com/users/Bakual/repos","events_url":"https://api.github.com/users/Bakual/events{/privacy}","received_events_url":"https://api.github.com/users/Bakual/received_events","type":"User","site_admin":false},"repo":{"id":5132763,"name":"joomla-cms","full_name":"Bakual/joomla-cms","owner":{"login":"Bakual","id":1018684,"avatar_url":"https://avatars1.githubusercontent.com/u/1018684?v=3","gravatar_id":"","url":"https://api.github.com/users/Bakual","html_url":"https://github.com/Bakual","followers_url":"https://api.github.com/users/Bakual/followers","following_url":"https://api.github.com/users/Bakual/following{/other_user}","gists_url":"https://api.github.com/users/Bakual/gists{/gist_id}","starred_url":"https://api.github.com/users/Bakual/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bakual/subscriptions","organizations_url":"https://api.github.com/users/Bakual/orgs","repos_url":"https://api.github.com/users/Bakual/repos","events_url":"https://api.github.com/users/Bakual/events{/privacy}","received_events_url":"https://api.github.com/users/Bakual/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Bakual/joomla-cms","description":"Home of the Joomla! Content Management System","fork":true,"url":"https://api.github.com/repos/Bakual/joomla-cms","forks_url":"https://api.github.com/repos/Bakual/joomla-cms/forks","keys_url":"https://api.github.com/repos/Bakual/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Bakual/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Bakual/joomla-cms/teams","hooks_url":"https://api.github.com/repos/Bakual/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/Bakual/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/Bakual/joomla-cms/events","assignees_url":"https://api.github.com/repos/Bakual/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/Bakual/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/Bakual/joomla-cms/tags","blobs_url":"https://api.github.com/repos/Bakual/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Bakual/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Bakual/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/Bakual/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Bakual/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/Bakual/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/Bakual/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/Bakual/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/Bakual/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/Bakual/joomla-cms/subscription","commits_url":"https://api.github.com/repos/Bakual/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/Bakual/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/Bakual/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/Bakual/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/Bakual/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/Bakual/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Bakual/joomla-cms/merges","archive_url":"https://api.github.com/repos/Bakual/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Bakual/joomla-cms/downloads","issues_url":"https://api.github.com/repos/Bakual/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/Bakual/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/Bakual/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/Bakual/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Bakual/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/Bakual/joomla-cms/releases{/id}","deployments_url":"https://api.github.com/repos/Bakual/joomla-cms/deployments","created_at":"2012-07-21T10:15:11Z","updated_at":"2016-10-24T18:26:51Z","pushed_at":"2017-05-02T17:43:44Z","git_url":"git://github.com/Bakual/joomla-cms.git","ssh_url":"git@github.com:Bakual/joomla-cms.git","clone_url":"https://github.com/Bakual/joomla-cms.git","svn_url":"https://github.com/Bakual/joomla-cms","homepage":"http://joomla.org","size":189804,"stargazers_count":3,"watchers_count":3,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":3,"default_branch":"staging"}},"base":{"label":"joomla:staging","ref":"staging","sha":"bfa560acd8dc0dd91ac7e5469b53b8fd43511b47","user":{"login":"joomla","id":751633,"avatar_url":"https://avatars0.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"repo":{"id":2464908,"name":"joomla-cms","full_name":"joomla/joomla-cms","owner":{"login":"joomla","id":751633,"avatar_url":"https://avatars0.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/joomla/joomla-cms","description":"Home of the Joomla! Content Management System","fork":false,"url":"https://api.github.com/repos/joomla/joomla-cms","forks_url":"https://api.github.com/repos/joomla/joomla-cms/forks","keys_url":"https://api.github.com/repos/joomla/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joomla/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joomla/joomla-cms/teams","hooks_url":"https://api.github.com/repos/joomla/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/joomla/joomla-cms/events","assignees_url":"https://api.github.com/repos/joomla/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/joomla/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/joomla/joomla-cms/tags","blobs_url":"https://api.github.com/repos/joomla/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joomla/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joomla/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/joomla/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/joomla/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/joomla/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/joomla/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/joomla/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/joomla/joomla-cms/subscription","commits_url":"https://api.github.com/repos/joomla/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/joomla/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/joomla/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/joomla/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joomla/joomla-cms/merges","archive_url":"https://api.github.com/repos/joomla/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joomla/joomla-cms/downloads","issues_url":"https://api.github.com/repos/joomla/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/joomla/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/joomla/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/joomla/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joomla/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/joomla/joomla-cms/releases{/id}","deployments_url":"https://api.github.com/repos/joomla/joomla-cms/deployments","created_at":"2011-09-27T02:07:38Z","updated_at":"2017-05-02T17:39:59Z","pushed_at":"2017-05-03T08:35:09Z","git_url":"git://github.com/joomla/joomla-cms.git","ssh_url":"git@github.com:joomla/joomla-cms.git","clone_url":"https://github.com/joomla/joomla-cms.git","svn_url":"https://github.com/joomla/joomla-cms","homepage":"https://www.joomla.org","size":189361,"stargazers_count":2347,"watchers_count":2347,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2473,"mirror_url":null,"open_issues_count":885,"forks":2473,"open_issues":885,"watchers":2347,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/15745"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/15745"},"issue":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/15745"},"comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/15745/comments"},"review_comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/15745/comments"},"review_comment":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/15745/commits"},"statuses":{"href":"https://api.github.com/repos/joomla/joomla-cms/statuses/20fb0a95349dabcf82bf0e31d52f069377793cd3"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"rdeutz","id":467356,"avatar_url":"https://avatars3.githubusercontent.com/u/467356?v=3","gravatar_id":"","url":"https://api.github.com/users/rdeutz","html_url":"https://github.com/rdeutz","followers_url":"https://api.github.com/users/rdeutz/followers","following_url":"https://api.github.com/users/rdeutz/following{/other_user}","gists_url":"https://api.github.com/users/rdeutz/gists{/gist_id}","starred_url":"https://api.github.com/users/rdeutz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdeutz/subscriptions","organizations_url":"https://api.github.com/users/rdeutz/orgs","repos_url":"https://api.github.com/users/rdeutz/repos","events_url":"https://api.github.com/users/rdeutz/events{/privacy}","received_events_url":"https://api.github.com/users/rdeutz/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":2,"deletions":2,"changed_files":2}}
{"actor":{"display_login":"rdeutz"}}