{"action":"created","issue":{"url":"https://api.github.com/repos/waf-project/waf/issues/1945","repository_url":"https://api.github.com/repos/waf-project/waf","labels_url":"https://api.github.com/repos/waf-project/waf/issues/1945/labels{/name}","comments_url":"https://api.github.com/repos/waf-project/waf/issues/1945/comments","events_url":"https://api.github.com/repos/waf-project/waf/issues/1945/events","html_url":"https://github.com/waf-project/waf/pull/1945","id":221051044,"number":1945,"title":"Detect MSVS 15.0 Installation path (via vswhere)","user":{"login":"refack","id":96947,"avatar_url":"https://avatars0.githubusercontent.com/u/96947?v=3","gravatar_id":"","url":"https://api.github.com/users/refack","html_url":"https://github.com/refack","followers_url":"https://api.github.com/users/refack/followers","following_url":"https://api.github.com/users/refack/following{/other_user}","gists_url":"https://api.github.com/users/refack/gists{/gist_id}","starred_url":"https://api.github.com/users/refack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/refack/subscriptions","organizations_url":"https://api.github.com/users/refack/orgs","repos_url":"https://api.github.com/users/refack/repos","events_url":"https://api.github.com/users/refack/events{/privacy}","received_events_url":"https://api.github.com/users/refack/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":14,"created_at":"2017-04-11T19:10:03Z","updated_at":"2017-04-22T00:22:01Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/waf-project/waf/pulls/1945","html_url":"https://github.com/waf-project/waf/pull/1945","diff_url":"https://github.com/waf-project/waf/pull/1945.diff","patch_url":"https://github.com/waf-project/waf/pull/1945.patch"},"body":"Fixes: #1924"},"comment":{"url":"https://api.github.com/repos/waf-project/waf/issues/comments/296332950","html_url":"https://github.com/waf-project/waf/pull/1945#issuecomment-296332950","issue_url":"https://api.github.com/repos/waf-project/waf/issues/1945","id":296332950,"user":{"login":"ita1024","id":508304,"avatar_url":"https://avatars0.githubusercontent.com/u/508304?v=3","gravatar_id":"","url":"https://api.github.com/users/ita1024","html_url":"https://github.com/ita1024","followers_url":"https://api.github.com/users/ita1024/followers","following_url":"https://api.github.com/users/ita1024/following{/other_user}","gists_url":"https://api.github.com/users/ita1024/gists{/gist_id}","starred_url":"https://api.github.com/users/ita1024/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ita1024/subscriptions","organizations_url":"https://api.github.com/users/ita1024/orgs","repos_url":"https://api.github.com/users/ita1024/repos","events_url":"https://api.github.com/users/ita1024/events{/privacy}","received_events_url":"https://api.github.com/users/ita1024/received_events","type":"User","site_admin":false},"created_at":"2017-04-22T00:22:01Z","updated_at":"2017-04-22T00:22:01Z","body":"Almost there! Please answer the questions below:\r\n1. Are versions returned by vswhere sorted? FYI, the last entry is meant to be the default compiler detected. In `gather_msvc_detected_versions` results are sorted for this reason.\r\n1. Since `vswhere.exe` is the future of visual studio detection, is `self.gather_vswhere_versions(dct)` not supposed to go **after** in order to detect the latest version(s) and fallback to the classic method?\r\n1. Why is `gather_msvc_versions` still modified?\r\n\r\nFYI, one could use a logger instead of `print` at the end of the large `Exception` block, but I can take care of that later.\r\n"}}
{"actor":{"display_login":"ita1024"}}