{"action":"closed","number":12015,"pull_request":{"url":"https://api.github.com/repos/godotengine/godot/pulls/12015","id":145858289,"html_url":"https://github.com/godotengine/godot/pull/12015","diff_url":"https://github.com/godotengine/godot/pull/12015.diff","patch_url":"https://github.com/godotengine/godot/pull/12015.patch","issue_url":"https://api.github.com/repos/godotengine/godot/issues/12015","number":12015,"state":"closed","locked":false,"title":"Implement DictionaryPropertyEdit .","user":{"login":"jagt","id":241128,"avatar_url":"https://avatars2.githubusercontent.com/u/241128?v=4","gravatar_id":"","url":"https://api.github.com/users/jagt","html_url":"https://github.com/jagt","followers_url":"https://api.github.com/users/jagt/followers","following_url":"https://api.github.com/users/jagt/following{/other_user}","gists_url":"https://api.github.com/users/jagt/gists{/gist_id}","starred_url":"https://api.github.com/users/jagt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jagt/subscriptions","organizations_url":"https://api.github.com/users/jagt/orgs","repos_url":"https://api.github.com/users/jagt/repos","events_url":"https://api.github.com/users/jagt/events{/privacy}","received_events_url":"https://api.github.com/users/jagt/received_events","type":"User","site_admin":false},"body":"This PR implements `DictionaryPropertyEdit` for editting exported dictionary properties (#10018).  \r\nHere's a screenshot:\r\n\r\n![image](https://user-images.githubusercontent.com/241128/31423044-ad8446b6-ae84-11e7-88ac-5120f207f8fa.png)\r\n\r\nHowever there're some usability issues which I really need some help from you guys:\r\n\r\n1. Changing the `size` field won't work atm as I don't see a way for this to work for a dictionary. So currently there's no way to add/remove new items through the inspector. I think the most common way to handle this is to add a button/widget to add new items, but I don't find a way to add button in inspector/.\r\n2. Can't handle duplicated keys. If one change a key to be equal to a existing key, the dictionary will actually shrink the dictionary by one. I don't really know how to handle this through the UI. Should duplicate key changes be ignored or report a error? Or I should simply make keys readonly.\r\n3. Changing keys will change item order. Maybe this can be fixed by adding data to track item orders.\r\n\r\nMost of the problems are related to key editing. Your input on this will be really helpful.","created_at":"2017-10-11T05:18:28Z","updated_at":"2017-10-15T04:50:39Z","closed_at":"2017-10-15T04:50:38Z","merged_at":null,"merge_commit_sha":"a2edc6c08eeb38595b9aa692ac2dbec6235b80fd","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/godotengine/godot/milestones/4","html_url":"https://github.com/godotengine/godot/milestone/4","labels_url":"https://api.github.com/repos/godotengine/godot/milestones/4/labels","id":1449702,"number":4,"title":"3.0","description":"","creator":{"login":"akien-mga","id":4701338,"avatar_url":"https://avatars0.githubusercontent.com/u/4701338?v=4","gravatar_id":"","url":"https://api.github.com/users/akien-mga","html_url":"https://github.com/akien-mga","followers_url":"https://api.github.com/users/akien-mga/followers","following_url":"https://api.github.com/users/akien-mga/following{/other_user}","gists_url":"https://api.github.com/users/akien-mga/gists{/gist_id}","starred_url":"https://api.github.com/users/akien-mga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akien-mga/subscriptions","organizations_url":"https://api.github.com/users/akien-mga/orgs","repos_url":"https://api.github.com/users/akien-mga/repos","events_url":"https://api.github.com/users/akien-mga/events{/privacy}","received_events_url":"https://api.github.com/users/akien-mga/received_events","type":"User","site_admin":false},"open_issues":336,"closed_issues":3013,"state":"open","created_at":"2015-12-08T11:42:08Z","updated_at":"2017-10-15T04:50:39Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/godotengine/godot/pulls/12015/commits","review_comments_url":"https://api.github.com/repos/godotengine/godot/pulls/12015/comments","review_comment_url":"https://api.github.com/repos/godotengine/godot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/godotengine/godot/issues/12015/comments","statuses_url":"https://api.github.com/repos/godotengine/godot/statuses/c657e3d33fd1db55a8d8ab8a3272cf40f3ad49e3","head":{"label":"jagt:dictionary_property_edit","ref":"dictionary_property_edit","sha":"c657e3d33fd1db55a8d8ab8a3272cf40f3ad49e3","user":{"login":"jagt","id":241128,"avatar_url":"https://avatars2.githubusercontent.com/u/241128?v=4","gravatar_id":"","url":"https://api.github.com/users/jagt","html_url":"https://github.com/jagt","followers_url":"https://api.github.com/users/jagt/followers","following_url":"https://api.github.com/users/jagt/following{/other_user}","gists_url":"https://api.github.com/users/jagt/gists{/gist_id}","starred_url":"https://api.github.com/users/jagt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jagt/subscriptions","organizations_url":"https://api.github.com/users/jagt/orgs","repos_url":"https://api.github.com/users/jagt/repos","events_url":"https://api.github.com/users/jagt/events{/privacy}","received_events_url":"https://api.github.com/users/jagt/received_events","type":"User","site_admin":false},"repo":{"id":104757964,"name":"godot","full_name":"jagt/godot","owner":{"login":"jagt","id":241128,"avatar_url":"https://avatars2.githubusercontent.com/u/241128?v=4","gravatar_id":"","url":"https://api.github.com/users/jagt","html_url":"https://github.com/jagt","followers_url":"https://api.github.com/users/jagt/followers","following_url":"https://api.github.com/users/jagt/following{/other_user}","gists_url":"https://api.github.com/users/jagt/gists{/gist_id}","starred_url":"https://api.github.com/users/jagt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jagt/subscriptions","organizations_url":"https://api.github.com/users/jagt/orgs","repos_url":"https://api.github.com/users/jagt/repos","events_url":"https://api.github.com/users/jagt/events{/privacy}","received_events_url":"https://api.github.com/users/jagt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jagt/godot","description":"Godot Engine – Multi-platform 2D and 3D game engine","fork":true,"url":"https://api.github.com/repos/jagt/godot","forks_url":"https://api.github.com/repos/jagt/godot/forks","keys_url":"https://api.github.com/repos/jagt/godot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jagt/godot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jagt/godot/teams","hooks_url":"https://api.github.com/repos/jagt/godot/hooks","issue_events_url":"https://api.github.com/repos/jagt/godot/issues/events{/number}","events_url":"https://api.github.com/repos/jagt/godot/events","assignees_url":"https://api.github.com/repos/jagt/godot/assignees{/user}","branches_url":"https://api.github.com/repos/jagt/godot/branches{/branch}","tags_url":"https://api.github.com/repos/jagt/godot/tags","blobs_url":"https://api.github.com/repos/jagt/godot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jagt/godot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jagt/godot/git/refs{/sha}","trees_url":"https://api.github.com/repos/jagt/godot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jagt/godot/statuses/{sha}","languages_url":"https://api.github.com/repos/jagt/godot/languages","stargazers_url":"https://api.github.com/repos/jagt/godot/stargazers","contributors_url":"https://api.github.com/repos/jagt/godot/contributors","subscribers_url":"https://api.github.com/repos/jagt/godot/subscribers","subscription_url":"https://api.github.com/repos/jagt/godot/subscription","commits_url":"https://api.github.com/repos/jagt/godot/commits{/sha}","git_commits_url":"https://api.github.com/repos/jagt/godot/git/commits{/sha}","comments_url":"https://api.github.com/repos/jagt/godot/comments{/number}","issue_comment_url":"https://api.github.com/repos/jagt/godot/issues/comments{/number}","contents_url":"https://api.github.com/repos/jagt/godot/contents/{+path}","compare_url":"https://api.github.com/repos/jagt/godot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jagt/godot/merges","archive_url":"https://api.github.com/repos/jagt/godot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jagt/godot/downloads","issues_url":"https://api.github.com/repos/jagt/godot/issues{/number}","pulls_url":"https://api.github.com/repos/jagt/godot/pulls{/number}","milestones_url":"https://api.github.com/repos/jagt/godot/milestones{/number}","notifications_url":"https://api.github.com/repos/jagt/godot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jagt/godot/labels{/name}","releases_url":"https://api.github.com/repos/jagt/godot/releases{/id}","deployments_url":"https://api.github.com/repos/jagt/godot/deployments","created_at":"2017-09-25T14:06:47Z","updated_at":"2017-09-25T14:06:54Z","pushed_at":"2017-10-15T03:04:17Z","git_url":"git://github.com/jagt/godot.git","ssh_url":"git@github.com:jagt/godot.git","clone_url":"https://github.com/jagt/godot.git","svn_url":"https://github.com/jagt/godot","homepage":"https://godotengine.org","size":194837,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"godotengine:master","ref":"master","sha":"da47f58b24daf7920b55dff19cbc484202f1ec37","user":{"login":"godotengine","id":6318500,"avatar_url":"https://avatars2.githubusercontent.com/u/6318500?v=4","gravatar_id":"","url":"https://api.github.com/users/godotengine","html_url":"https://github.com/godotengine","followers_url":"https://api.github.com/users/godotengine/followers","following_url":"https://api.github.com/users/godotengine/following{/other_user}","gists_url":"https://api.github.com/users/godotengine/gists{/gist_id}","starred_url":"https://api.github.com/users/godotengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/godotengine/subscriptions","organizations_url":"https://api.github.com/users/godotengine/orgs","repos_url":"https://api.github.com/users/godotengine/repos","events_url":"https://api.github.com/users/godotengine/events{/privacy}","received_events_url":"https://api.github.com/users/godotengine/received_events","type":"Organization","site_admin":false},"repo":{"id":15634981,"name":"godot","full_name":"godotengine/godot","owner":{"login":"godotengine","id":6318500,"avatar_url":"https://avatars2.githubusercontent.com/u/6318500?v=4","gravatar_id":"","url":"https://api.github.com/users/godotengine","html_url":"https://github.com/godotengine","followers_url":"https://api.github.com/users/godotengine/followers","following_url":"https://api.github.com/users/godotengine/following{/other_user}","gists_url":"https://api.github.com/users/godotengine/gists{/gist_id}","starred_url":"https://api.github.com/users/godotengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/godotengine/subscriptions","organizations_url":"https://api.github.com/users/godotengine/orgs","repos_url":"https://api.github.com/users/godotengine/repos","events_url":"https://api.github.com/users/godotengine/events{/privacy}","received_events_url":"https://api.github.com/users/godotengine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/godotengine/godot","description":"Godot Engine – Multi-platform 2D and 3D game engine","fork":false,"url":"https://api.github.com/repos/godotengine/godot","forks_url":"https://api.github.com/repos/godotengine/godot/forks","keys_url":"https://api.github.com/repos/godotengine/godot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/godotengine/godot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/godotengine/godot/teams","hooks_url":"https://api.github.com/repos/godotengine/godot/hooks","issue_events_url":"https://api.github.com/repos/godotengine/godot/issues/events{/number}","events_url":"https://api.github.com/repos/godotengine/godot/events","assignees_url":"https://api.github.com/repos/godotengine/godot/assignees{/user}","branches_url":"https://api.github.com/repos/godotengine/godot/branches{/branch}","tags_url":"https://api.github.com/repos/godotengine/godot/tags","blobs_url":"https://api.github.com/repos/godotengine/godot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/godotengine/godot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/godotengine/godot/git/refs{/sha}","trees_url":"https://api.github.com/repos/godotengine/godot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/godotengine/godot/statuses/{sha}","languages_url":"https://api.github.com/repos/godotengine/godot/languages","stargazers_url":"https://api.github.com/repos/godotengine/godot/stargazers","contributors_url":"https://api.github.com/repos/godotengine/godot/contributors","subscribers_url":"https://api.github.com/repos/godotengine/godot/subscribers","subscription_url":"https://api.github.com/repos/godotengine/godot/subscription","commits_url":"https://api.github.com/repos/godotengine/godot/commits{/sha}","git_commits_url":"https://api.github.com/repos/godotengine/godot/git/commits{/sha}","comments_url":"https://api.github.com/repos/godotengine/godot/comments{/number}","issue_comment_url":"https://api.github.com/repos/godotengine/godot/issues/comments{/number}","contents_url":"https://api.github.com/repos/godotengine/godot/contents/{+path}","compare_url":"https://api.github.com/repos/godotengine/godot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/godotengine/godot/merges","archive_url":"https://api.github.com/repos/godotengine/godot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/godotengine/godot/downloads","issues_url":"https://api.github.com/repos/godotengine/godot/issues{/number}","pulls_url":"https://api.github.com/repos/godotengine/godot/pulls{/number}","milestones_url":"https://api.github.com/repos/godotengine/godot/milestones{/number}","notifications_url":"https://api.github.com/repos/godotengine/godot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/godotengine/godot/labels{/name}","releases_url":"https://api.github.com/repos/godotengine/godot/releases{/id}","deployments_url":"https://api.github.com/repos/godotengine/godot/deployments","created_at":"2014-01-04T16:05:36Z","updated_at":"2017-10-15T04:49:42Z","pushed_at":"2017-10-15T03:18:53Z","git_url":"git://github.com/godotengine/godot.git","ssh_url":"git@github.com:godotengine/godot.git","clone_url":"https://github.com/godotengine/godot.git","svn_url":"https://github.com/godotengine/godot","homepage":"https://godotengine.org","size":195059,"stargazers_count":10580,"watchers_count":10580,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2416,"mirror_url":null,"open_issues_count":2316,"forks":2416,"open_issues":2316,"watchers":10580,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/godotengine/godot/pulls/12015"},"html":{"href":"https://github.com/godotengine/godot/pull/12015"},"issue":{"href":"https://api.github.com/repos/godotengine/godot/issues/12015"},"comments":{"href":"https://api.github.com/repos/godotengine/godot/issues/12015/comments"},"review_comments":{"href":"https://api.github.com/repos/godotengine/godot/pulls/12015/comments"},"review_comment":{"href":"https://api.github.com/repos/godotengine/godot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/godotengine/godot/pulls/12015/commits"},"statuses":{"href":"https://api.github.com/repos/godotengine/godot/statuses/c657e3d33fd1db55a8d8ab8a3272cf40f3ad49e3"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"unstable","merged_by":null,"comments":6,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":405,"deletions":1,"changed_files":3}}
{"actor":{"display_login":"jagt"}}