{"action":"created","issue":{"url":"https://api.github.com/repos/KhronosGroup/glTF/issues/726","repository_url":"https://api.github.com/repos/KhronosGroup/glTF","labels_url":"https://api.github.com/repos/KhronosGroup/glTF/issues/726/labels{/name}","comments_url":"https://api.github.com/repos/KhronosGroup/glTF/issues/726/comments","events_url":"https://api.github.com/repos/KhronosGroup/glTF/issues/726/events","html_url":"https://github.com/KhronosGroup/glTF/issues/726","id":178636891,"number":726,"title":"Losing `diffuse` settings when using textures","user":{"login":"richtr","id":497699,"avatar_url":"https://avatars0.githubusercontent.com/u/497699?v=4","gravatar_id":"","url":"https://api.github.com/users/richtr","html_url":"https://github.com/richtr","followers_url":"https://api.github.com/users/richtr/followers","following_url":"https://api.github.com/users/richtr/following{/other_user}","gists_url":"https://api.github.com/users/richtr/gists{/gist_id}","starred_url":"https://api.github.com/users/richtr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richtr/subscriptions","organizations_url":"https://api.github.com/users/richtr/orgs","repos_url":"https://api.github.com/users/richtr/repos","events_url":"https://api.github.com/users/richtr/events{/privacy}","received_events_url":"https://api.github.com/users/richtr/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2016-09-22T15:09:12Z","updated_at":"2017-10-11T15:24:33Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"The example in the [spec](https://github.com/KhronosGroup/glTF/tree/master/specification#textures) for adding textures is as follows:\n\n``` json\n\"materials\": {\n    \"material-1\": {\n        \"technique\": \"technique1\",\n        \"values\": {\n            \"diffuse\": \"texture_file2\",\n        },\n        \"name\": \"material_1\"\n    }\n},\n\n// ...\n\n\"textures\": {\n    \"texture_file2\": {\n        \"format\": 6408,\n        \"internalFormat\": 6408,\n        \"sampler\": \"sampler_0\",\n        \"source\": \"file2\",\n        \"target\": 3553,\n        \"type\": 5121\n    }\n}\n```\n\nA number of formats allow adding of both a texture map _and_ separate `diffuse` vec4 values.\n\nIs the only way to set textures in glTF to override one of the material attributes (e.g. `diffuse`)? How should we compensate for the loss of `diffuse` values from the input here?\n\nOriginal model example:\n\n[Epona-obj.zip](https://github.com/KhronosGroup/glTF/files/487621/Epona-obj.zip)\n\n<img width=\"295\" alt=\"screen shot 2016-09-22 at 5 06 10 pm\" src=\"https://cloud.githubusercontent.com/assets/497699/18753856/f3bcf5aa-80e6-11e6-89cf-f3b3e8dcc073.png\">\n\nSame model converted to glTF (adding a texture overwrites the `diffuse` settings in the output):\n\n[Epona-gltf.zip](https://github.com/KhronosGroup/glTF/files/487622/Epona-gltf.zip)\n\n<img width=\"290\" alt=\"screen shot 2016-09-22 at 5 06 30 pm\" src=\"https://cloud.githubusercontent.com/assets/497699/18753883/0a12cda2-80e7-11e6-94e8-24cda5ffddbb.png\">\n"},"comment":{"url":"https://api.github.com/repos/KhronosGroup/glTF/issues/comments/335848360","html_url":"https://github.com/KhronosGroup/glTF/issues/726#issuecomment-335848360","issue_url":"https://api.github.com/repos/KhronosGroup/glTF/issues/726","id":335848360,"user":{"login":"donmccurdy","id":1848368,"avatar_url":"https://avatars3.githubusercontent.com/u/1848368?v=4","gravatar_id":"","url":"https://api.github.com/users/donmccurdy","html_url":"https://github.com/donmccurdy","followers_url":"https://api.github.com/users/donmccurdy/followers","following_url":"https://api.github.com/users/donmccurdy/following{/other_user}","gists_url":"https://api.github.com/users/donmccurdy/gists{/gist_id}","starred_url":"https://api.github.com/users/donmccurdy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/donmccurdy/subscriptions","organizations_url":"https://api.github.com/users/donmccurdy/orgs","repos_url":"https://api.github.com/users/donmccurdy/repos","events_url":"https://api.github.com/users/donmccurdy/events{/privacy}","received_events_url":"https://api.github.com/users/donmccurdy/received_events","type":"User","site_admin":false},"created_at":"2017-10-11T15:24:33Z","updated_at":"2017-10-11T15:24:33Z","author_association":"MEMBER","body":"I think this can be closed? glTF2.0 has distinct `baseColorFactor` and `baseColorTexture` properties."}}
{"actor":{"display_login":"donmccurdy"}}