{"action":"closed","number":2993,"pull_request":{"url":"https://api.github.com/repos/micropython/micropython/pulls/2993","id":113909242,"html_url":"https://github.com/micropython/micropython/pull/2993","diff_url":"https://github.com/micropython/micropython/pull/2993.diff","patch_url":"https://github.com/micropython/micropython/pull/2993.patch","issue_url":"https://api.github.com/repos/micropython/micropython/issues/2993","number":2993,"state":"closed","locked":false,"title":"msvc: Rebuild all qstrs when mpconfig headers are modified","user":{"login":"stinos","id":1902997,"avatar_url":"https://avatars0.githubusercontent.com/u/1902997?v=3","gravatar_id":"","url":"https://api.github.com/users/stinos","html_url":"https://github.com/stinos","followers_url":"https://api.github.com/users/stinos/followers","following_url":"https://api.github.com/users/stinos/following{/other_user}","gists_url":"https://api.github.com/users/stinos/gists{/gist_id}","starred_url":"https://api.github.com/users/stinos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stinos/subscriptions","organizations_url":"https://api.github.com/users/stinos/orgs","repos_url":"https://api.github.com/users/stinos/repos","events_url":"https://api.github.com/users/stinos/events{/privacy}","received_events_url":"https://api.github.com/users/stinos/received_events","type":"User","site_admin":false},"body":"Make qstr generation depend on modifications in mpconfigport.h, mpconfig.h\r\nand makeqstrdata.py and if any of those change scan all source files for\r\nqstrs again since they might have changed (for example typcially when\r\nenabling new features in mpconfig.h).\r\nThis fixes #2982 for msvc builds.","created_at":"2017-04-03T11:28:13Z","updated_at":"2017-04-30T11:31:35Z","closed_at":"2017-04-30T11:31:35Z","merged_at":null,"merge_commit_sha":"88cbdd8341309a64d16d918267178bcc701189b8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/micropython/micropython/pulls/2993/commits","review_comments_url":"https://api.github.com/repos/micropython/micropython/pulls/2993/comments","review_comment_url":"https://api.github.com/repos/micropython/micropython/pulls/comments{/number}","comments_url":"https://api.github.com/repos/micropython/micropython/issues/2993/comments","statuses_url":"https://api.github.com/repos/micropython/micropython/statuses/963690e6181201cea337e53352a1493539e6b384","head":{"label":"stinos:msvc-qstrrebuild","ref":"msvc-qstrrebuild","sha":"963690e6181201cea337e53352a1493539e6b384","user":{"login":"stinos","id":1902997,"avatar_url":"https://avatars0.githubusercontent.com/u/1902997?v=3","gravatar_id":"","url":"https://api.github.com/users/stinos","html_url":"https://github.com/stinos","followers_url":"https://api.github.com/users/stinos/followers","following_url":"https://api.github.com/users/stinos/following{/other_user}","gists_url":"https://api.github.com/users/stinos/gists{/gist_id}","starred_url":"https://api.github.com/users/stinos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stinos/subscriptions","organizations_url":"https://api.github.com/users/stinos/orgs","repos_url":"https://api.github.com/users/stinos/repos","events_url":"https://api.github.com/users/stinos/events{/privacy}","received_events_url":"https://api.github.com/users/stinos/received_events","type":"User","site_admin":false},"repo":{"id":19268673,"name":"micropython","full_name":"stinos/micropython","owner":{"login":"stinos","id":1902997,"avatar_url":"https://avatars0.githubusercontent.com/u/1902997?v=3","gravatar_id":"","url":"https://api.github.com/users/stinos","html_url":"https://github.com/stinos","followers_url":"https://api.github.com/users/stinos/followers","following_url":"https://api.github.com/users/stinos/following{/other_user}","gists_url":"https://api.github.com/users/stinos/gists{/gist_id}","starred_url":"https://api.github.com/users/stinos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stinos/subscriptions","organizations_url":"https://api.github.com/users/stinos/orgs","repos_url":"https://api.github.com/users/stinos/repos","events_url":"https://api.github.com/users/stinos/events{/privacy}","received_events_url":"https://api.github.com/users/stinos/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stinos/micropython","description":"The Micro Python project","fork":true,"url":"https://api.github.com/repos/stinos/micropython","forks_url":"https://api.github.com/repos/stinos/micropython/forks","keys_url":"https://api.github.com/repos/stinos/micropython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stinos/micropython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stinos/micropython/teams","hooks_url":"https://api.github.com/repos/stinos/micropython/hooks","issue_events_url":"https://api.github.com/repos/stinos/micropython/issues/events{/number}","events_url":"https://api.github.com/repos/stinos/micropython/events","assignees_url":"https://api.github.com/repos/stinos/micropython/assignees{/user}","branches_url":"https://api.github.com/repos/stinos/micropython/branches{/branch}","tags_url":"https://api.github.com/repos/stinos/micropython/tags","blobs_url":"https://api.github.com/repos/stinos/micropython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stinos/micropython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stinos/micropython/git/refs{/sha}","trees_url":"https://api.github.com/repos/stinos/micropython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stinos/micropython/statuses/{sha}","languages_url":"https://api.github.com/repos/stinos/micropython/languages","stargazers_url":"https://api.github.com/repos/stinos/micropython/stargazers","contributors_url":"https://api.github.com/repos/stinos/micropython/contributors","subscribers_url":"https://api.github.com/repos/stinos/micropython/subscribers","subscription_url":"https://api.github.com/repos/stinos/micropython/subscription","commits_url":"https://api.github.com/repos/stinos/micropython/commits{/sha}","git_commits_url":"https://api.github.com/repos/stinos/micropython/git/commits{/sha}","comments_url":"https://api.github.com/repos/stinos/micropython/comments{/number}","issue_comment_url":"https://api.github.com/repos/stinos/micropython/issues/comments{/number}","contents_url":"https://api.github.com/repos/stinos/micropython/contents/{+path}","compare_url":"https://api.github.com/repos/stinos/micropython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stinos/micropython/merges","archive_url":"https://api.github.com/repos/stinos/micropython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stinos/micropython/downloads","issues_url":"https://api.github.com/repos/stinos/micropython/issues{/number}","pulls_url":"https://api.github.com/repos/stinos/micropython/pulls{/number}","milestones_url":"https://api.github.com/repos/stinos/micropython/milestones{/number}","notifications_url":"https://api.github.com/repos/stinos/micropython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stinos/micropython/labels{/name}","releases_url":"https://api.github.com/repos/stinos/micropython/releases{/id}","deployments_url":"https://api.github.com/repos/stinos/micropython/deployments","created_at":"2014-04-29T08:04:48Z","updated_at":"2016-10-28T07:30:19Z","pushed_at":"2017-04-29T09:45:11Z","git_url":"git://github.com/stinos/micropython.git","ssh_url":"git@github.com:stinos/micropython.git","clone_url":"https://github.com/stinos/micropython.git","svn_url":"https://github.com/stinos/micropython","homepage":null,"size":30762,"stargazers_count":2,"watchers_count":2,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"micropython:master","ref":"master","sha":"4c392243ae947545553904d6436e7db462207446","user":{"login":"micropython","id":6298560,"avatar_url":"https://avatars2.githubusercontent.com/u/6298560?v=3","gravatar_id":"","url":"https://api.github.com/users/micropython","html_url":"https://github.com/micropython","followers_url":"https://api.github.com/users/micropython/followers","following_url":"https://api.github.com/users/micropython/following{/other_user}","gists_url":"https://api.github.com/users/micropython/gists{/gist_id}","starred_url":"https://api.github.com/users/micropython/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micropython/subscriptions","organizations_url":"https://api.github.com/users/micropython/orgs","repos_url":"https://api.github.com/users/micropython/repos","events_url":"https://api.github.com/users/micropython/events{/privacy}","received_events_url":"https://api.github.com/users/micropython/received_events","type":"Organization","site_admin":false},"repo":{"id":15337142,"name":"micropython","full_name":"micropython/micropython","owner":{"login":"micropython","id":6298560,"avatar_url":"https://avatars2.githubusercontent.com/u/6298560?v=3","gravatar_id":"","url":"https://api.github.com/users/micropython","html_url":"https://github.com/micropython","followers_url":"https://api.github.com/users/micropython/followers","following_url":"https://api.github.com/users/micropython/following{/other_user}","gists_url":"https://api.github.com/users/micropython/gists{/gist_id}","starred_url":"https://api.github.com/users/micropython/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micropython/subscriptions","organizations_url":"https://api.github.com/users/micropython/orgs","repos_url":"https://api.github.com/users/micropython/repos","events_url":"https://api.github.com/users/micropython/events{/privacy}","received_events_url":"https://api.github.com/users/micropython/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/micropython/micropython","description":"MicroPython - a lean and efficient Python implementation for microcontrollers and constrained systems","fork":false,"url":"https://api.github.com/repos/micropython/micropython","forks_url":"https://api.github.com/repos/micropython/micropython/forks","keys_url":"https://api.github.com/repos/micropython/micropython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/micropython/micropython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/micropython/micropython/teams","hooks_url":"https://api.github.com/repos/micropython/micropython/hooks","issue_events_url":"https://api.github.com/repos/micropython/micropython/issues/events{/number}","events_url":"https://api.github.com/repos/micropython/micropython/events","assignees_url":"https://api.github.com/repos/micropython/micropython/assignees{/user}","branches_url":"https://api.github.com/repos/micropython/micropython/branches{/branch}","tags_url":"https://api.github.com/repos/micropython/micropython/tags","blobs_url":"https://api.github.com/repos/micropython/micropython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/micropython/micropython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/micropython/micropython/git/refs{/sha}","trees_url":"https://api.github.com/repos/micropython/micropython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/micropython/micropython/statuses/{sha}","languages_url":"https://api.github.com/repos/micropython/micropython/languages","stargazers_url":"https://api.github.com/repos/micropython/micropython/stargazers","contributors_url":"https://api.github.com/repos/micropython/micropython/contributors","subscribers_url":"https://api.github.com/repos/micropython/micropython/subscribers","subscription_url":"https://api.github.com/repos/micropython/micropython/subscription","commits_url":"https://api.github.com/repos/micropython/micropython/commits{/sha}","git_commits_url":"https://api.github.com/repos/micropython/micropython/git/commits{/sha}","comments_url":"https://api.github.com/repos/micropython/micropython/comments{/number}","issue_comment_url":"https://api.github.com/repos/micropython/micropython/issues/comments{/number}","contents_url":"https://api.github.com/repos/micropython/micropython/contents/{+path}","compare_url":"https://api.github.com/repos/micropython/micropython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/micropython/micropython/merges","archive_url":"https://api.github.com/repos/micropython/micropython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/micropython/micropython/downloads","issues_url":"https://api.github.com/repos/micropython/micropython/issues{/number}","pulls_url":"https://api.github.com/repos/micropython/micropython/pulls{/number}","milestones_url":"https://api.github.com/repos/micropython/micropython/milestones{/number}","notifications_url":"https://api.github.com/repos/micropython/micropython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/micropython/micropython/labels{/name}","releases_url":"https://api.github.com/repos/micropython/micropython/releases{/id}","deployments_url":"https://api.github.com/repos/micropython/micropython/deployments","created_at":"2013-12-20T11:47:07Z","updated_at":"2017-04-29T15:03:54Z","pushed_at":"2017-04-30T11:30:51Z","git_url":"git://github.com/micropython/micropython.git","ssh_url":"git@github.com:micropython/micropython.git","clone_url":"https://github.com/micropython/micropython.git","svn_url":"https://github.com/micropython/micropython","homepage":"https://micropython.org","size":31070,"stargazers_count":4572,"watchers_count":4572,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1078,"mirror_url":null,"open_issues_count":444,"forks":1078,"open_issues":444,"watchers":4572,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/micropython/micropython/pulls/2993"},"html":{"href":"https://github.com/micropython/micropython/pull/2993"},"issue":{"href":"https://api.github.com/repos/micropython/micropython/issues/2993"},"comments":{"href":"https://api.github.com/repos/micropython/micropython/issues/2993/comments"},"review_comments":{"href":"https://api.github.com/repos/micropython/micropython/pulls/2993/comments"},"review_comment":{"href":"https://api.github.com/repos/micropython/micropython/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/micropython/micropython/pulls/2993/commits"},"statuses":{"href":"https://api.github.com/repos/micropython/micropython/statuses/963690e6181201cea337e53352a1493539e6b384"}},"merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":3,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":15,"deletions":4,"changed_files":1}}
{"actor":{"display_login":"pfalcon"}}