{"action":"opened","issue":{"url":"https://api.github.com/repos/MonoGame/MonoGame/issues/5618","repository_url":"https://api.github.com/repos/MonoGame/MonoGame","labels_url":"https://api.github.com/repos/MonoGame/MonoGame/issues/5618/labels{/name}","comments_url":"https://api.github.com/repos/MonoGame/MonoGame/issues/5618/comments","events_url":"https://api.github.com/repos/MonoGame/MonoGame/issues/5618/events","html_url":"https://github.com/MonoGame/MonoGame/issues/5618","id":216781673,"number":5618,"title":"Maximize Windows","user":{"login":"robert-wallis","id":145938,"avatar_url":"https://avatars2.githubusercontent.com/u/145938?v=3","gravatar_id":"","url":"https://api.github.com/users/robert-wallis","html_url":"https://github.com/robert-wallis","followers_url":"https://api.github.com/users/robert-wallis/followers","following_url":"https://api.github.com/users/robert-wallis/following{/other_user}","gists_url":"https://api.github.com/users/robert-wallis/gists{/gist_id}","starred_url":"https://api.github.com/users/robert-wallis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robert-wallis/subscriptions","organizations_url":"https://api.github.com/users/robert-wallis/orgs","repos_url":"https://api.github.com/users/robert-wallis/repos","events_url":"https://api.github.com/users/robert-wallis/events{/privacy}","received_events_url":"https://api.github.com/users/robert-wallis/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-03-24T13:13:58Z","updated_at":"2017-03-24T13:13:58Z","closed_at":null,"body":"In my 'game' I want to have a maximized window, that is not full-screen.  SDL supports this with `SDL_MaximizeWindow` however the `Sdl` class is `internal` so my Game doesn't have access to it.\r\n\r\nSo I threaded the function call through GameWindow like this:\r\nhttps://github.com/robert-wallis/MonoGame/commit/b8e4e06ee34f344bc18c3ec1437f11522ff24dae#diff-c36ddd5c033ea9ae2a05b30e38dfc0a6R159\r\nBy adding a new public Maximize(), Minimize() and Restore() function to GameWindow, SDLGameWindow, and the appropriate function pointers inside Sdl.Window.\r\n\r\n* Is this something for which I should create a PR? (but finish it up by adding the functionality to the other desktop platforms) \r\n* Or would it be better to mark `Sdl` as `public` so my Game code can call it directly.\r\n\r\nI also have another issue with Windows where a stylus doesn't register as down for a half second.  Which is infuriating. But can be turned off if you have the HWND through some special Win32 API magic.  \r\n* So I had to add the `SDL_GetWindowWMInfo` function pointer, and then add a new HWND property since GameWindow.Handle and SDLGameWindow._handle point to the SDL_Window and not the HWND.  https://github.com/MonoGame/MonoGame/compare/develop...robert-wallis:HWND?expand=0\r\n* Or if I made `Sdl` `public` then I wouldn't have to create the new property.\r\n\r\nWhat kind of PR would you rather see?  I'm new to MonoGame so I'm not sure if it's better to abstract everything and thread functionality through the main classes, or provide a set of public APIs that you can optionally access if you want."}}
{"actor":{"display_login":"robert-wallis"}}