{"action":"created","comment":{"url":"https://api.github.com/repos/xcat2/xcat-core/pulls/comments/154670211","pull_request_review_id":80864648,"id":154670211,"diff_hunk":"@@ -3271,6 +3271,10 @@ sub rflash_upload {\n             process_debug_info($node, $debugmsg);\n         }\n         my $curl_upload_result = `$curl_upload_cmd`;\n+        if (!$curl_upload_result) {\n+            xCAT::SvrUtils::sendmsg(\"Error: Did not receive response from OpenBMC when run command '$curl_upload_cmd'\", $callback, $node);","path":"xCAT-server/lib/xcat/plugins/openbmc.pm","position":5,"original_position":5,"commit_id":"9818da87ee031c933ce788fca9b7e64007c1daca","original_commit_id":"9818da87ee031c933ce788fca9b7e64007c1daca","user":{"login":"gurevichmark","id":16106630,"avatar_url":"https://avatars1.githubusercontent.com/u/16106630?v=4","gravatar_id":"","url":"https://api.github.com/users/gurevichmark","html_url":"https://github.com/gurevichmark","followers_url":"https://api.github.com/users/gurevichmark/followers","following_url":"https://api.github.com/users/gurevichmark/following{/other_user}","gists_url":"https://api.github.com/users/gurevichmark/gists{/gist_id}","starred_url":"https://api.github.com/users/gurevichmark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gurevichmark/subscriptions","organizations_url":"https://api.github.com/users/gurevichmark/orgs","repos_url":"https://api.github.com/users/gurevichmark/repos","events_url":"https://api.github.com/users/gurevichmark/events{/privacy}","received_events_url":"https://api.github.com/users/gurevichmark/received_events","type":"User","site_admin":false},"body":"1. Suggest changing \"when run\" to \"after running\" in the message.\r\n2. Would it be better to make this an error message instead of adding \"Error:\" to the message text. Something similar to `xCAT::SvrUtils::sendmsg([1, \"Did not receive....\"]....` ","created_at":"2017-12-04T14:55:11Z","updated_at":"2017-12-04T14:55:49Z","html_url":"https://github.com/xcat2/xcat-core/pull/4396#discussion_r154670211","pull_request_url":"https://api.github.com/repos/xcat2/xcat-core/pulls/4396","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/xcat2/xcat-core/pulls/comments/154670211"},"html":{"href":"https://github.com/xcat2/xcat-core/pull/4396#discussion_r154670211"},"pull_request":{"href":"https://api.github.com/repos/xcat2/xcat-core/pulls/4396"}}},"pull_request":{"url":"https://api.github.com/repos/xcat2/xcat-core/pulls/4396","id":155526202,"html_url":"https://github.com/xcat2/xcat-core/pull/4396","diff_url":"https://github.com/xcat2/xcat-core/pull/4396.diff","patch_url":"https://github.com/xcat2/xcat-core/pull/4396.patch","issue_url":"https://api.github.com/repos/xcat2/xcat-core/issues/4396","number":4396,"state":"open","locked":false,"title":"Print out error message if receive nothing when uploading firmware file","user":{"login":"xuweibj","id":15208204,"avatar_url":"https://avatars0.githubusercontent.com/u/15208204?v=4","gravatar_id":"","url":"https://api.github.com/users/xuweibj","html_url":"https://github.com/xuweibj","followers_url":"https://api.github.com/users/xuweibj/followers","following_url":"https://api.github.com/users/xuweibj/following{/other_user}","gists_url":"https://api.github.com/users/xuweibj/gists{/gist_id}","starred_url":"https://api.github.com/users/xuweibj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xuweibj/subscriptions","organizations_url":"https://api.github.com/users/xuweibj/orgs","repos_url":"https://api.github.com/users/xuweibj/repos","events_url":"https://api.github.com/users/xuweibj/events{/privacy}","received_events_url":"https://api.github.com/users/xuweibj/received_events","type":"User","site_admin":false},"body":"#4394 (currently, not sure whether this is the root cause)\r\n\r\nIf do not receive response when uploading file, will print out the error msg:\r\n\r\n``Error: openbmc plugin bug, pid 25027, process description: 'xcatd SSL: rflash to mid05tor12cn05 for root@localhost: openbmc instance' with error 'malformed JSON string, neither array, object, number, string or atom, at character offset 0 (before \"(end of string)\") at /opt/xcat/lib/perl/xCAT_plugin/openbmc.pm line 3208.\r\n' while trying to fulfill request for the following nodes: mid05tor12cn05``\r\n\r\nAfter modified:\r\n```\r\n# rflash mid05tor12cn05 obmc-phosphor-image-witherspoon.ubi.mtd.tar -u\r\nAttempting to upload obmc-phosphor-image-witherspoon.ubi.mtd.tar, please wait...\r\n mid05tor12cn02: Error: Did not receive response from OpenBMC when run command 'curl -b /tmp/_xcat_cjar.mid05tor12cn02 -k -H 'Content-Type: application/octet-stream' -X PUT -T /mnt/xcat/iso/openbmc/910.1746.20171128a_1742Ef/witherspoon.pnor.squashfs.tar https://172.11.139.2/upload/image/'\r\n```","created_at":"2017-11-30T06:08:25Z","updated_at":"2017-12-04T14:55:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"58ff5ac8f476c6f990131cdfacaefa22cd4bad41","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/xcat2/xcat-core/milestones/33","html_url":"https://github.com/xcat2/xcat-core/milestone/33","labels_url":"https://api.github.com/repos/xcat2/xcat-core/milestones/33/labels","id":2631878,"number":33,"title":"2.13.9","description":"","creator":{"login":"whowutwut","id":10049070,"avatar_url":"https://avatars0.githubusercontent.com/u/10049070?v=4","gravatar_id":"","url":"https://api.github.com/users/whowutwut","html_url":"https://github.com/whowutwut","followers_url":"https://api.github.com/users/whowutwut/followers","following_url":"https://api.github.com/users/whowutwut/following{/other_user}","gists_url":"https://api.github.com/users/whowutwut/gists{/gist_id}","starred_url":"https://api.github.com/users/whowutwut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whowutwut/subscriptions","organizations_url":"https://api.github.com/users/whowutwut/orgs","repos_url":"https://api.github.com/users/whowutwut/repos","events_url":"https://api.github.com/users/whowutwut/events{/privacy}","received_events_url":"https://api.github.com/users/whowutwut/received_events","type":"User","site_admin":false},"open_issues":92,"closed_issues":129,"state":"open","created_at":"2017-07-10T14:31:35Z","updated_at":"2017-12-04T06:26:44Z","due_on":"2017-12-15T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/xcat2/xcat-core/pulls/4396/commits","review_comments_url":"https://api.github.com/repos/xcat2/xcat-core/pulls/4396/comments","review_comment_url":"https://api.github.com/repos/xcat2/xcat-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xcat2/xcat-core/issues/4396/comments","statuses_url":"https://api.github.com/repos/xcat2/xcat-core/statuses/9818da87ee031c933ce788fca9b7e64007c1daca","head":{"label":"xuweibj:I4394","ref":"I4394","sha":"9818da87ee031c933ce788fca9b7e64007c1daca","user":{"login":"xuweibj","id":15208204,"avatar_url":"https://avatars0.githubusercontent.com/u/15208204?v=4","gravatar_id":"","url":"https://api.github.com/users/xuweibj","html_url":"https://github.com/xuweibj","followers_url":"https://api.github.com/users/xuweibj/followers","following_url":"https://api.github.com/users/xuweibj/following{/other_user}","gists_url":"https://api.github.com/users/xuweibj/gists{/gist_id}","starred_url":"https://api.github.com/users/xuweibj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xuweibj/subscriptions","organizations_url":"https://api.github.com/users/xuweibj/orgs","repos_url":"https://api.github.com/users/xuweibj/repos","events_url":"https://api.github.com/users/xuweibj/events{/privacy}","received_events_url":"https://api.github.com/users/xuweibj/received_events","type":"User","site_admin":false},"repo":{"id":45444036,"name":"xcat-core","full_name":"xuweibj/xcat-core","owner":{"login":"xuweibj","id":15208204,"avatar_url":"https://avatars0.githubusercontent.com/u/15208204?v=4","gravatar_id":"","url":"https://api.github.com/users/xuweibj","html_url":"https://github.com/xuweibj","followers_url":"https://api.github.com/users/xuweibj/followers","following_url":"https://api.github.com/users/xuweibj/following{/other_user}","gists_url":"https://api.github.com/users/xuweibj/gists{/gist_id}","starred_url":"https://api.github.com/users/xuweibj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xuweibj/subscriptions","organizations_url":"https://api.github.com/users/xuweibj/orgs","repos_url":"https://api.github.com/users/xuweibj/repos","events_url":"https://api.github.com/users/xuweibj/events{/privacy}","received_events_url":"https://api.github.com/users/xuweibj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xuweibj/xcat-core","description":"Code repo for xCAT core packages","fork":true,"url":"https://api.github.com/repos/xuweibj/xcat-core","forks_url":"https://api.github.com/repos/xuweibj/xcat-core/forks","keys_url":"https://api.github.com/repos/xuweibj/xcat-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xuweibj/xcat-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xuweibj/xcat-core/teams","hooks_url":"https://api.github.com/repos/xuweibj/xcat-core/hooks","issue_events_url":"https://api.github.com/repos/xuweibj/xcat-core/issues/events{/number}","events_url":"https://api.github.com/repos/xuweibj/xcat-core/events","assignees_url":"https://api.github.com/repos/xuweibj/xcat-core/assignees{/user}","branches_url":"https://api.github.com/repos/xuweibj/xcat-core/branches{/branch}","tags_url":"https://api.github.com/repos/xuweibj/xcat-core/tags","blobs_url":"https://api.github.com/repos/xuweibj/xcat-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xuweibj/xcat-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xuweibj/xcat-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/xuweibj/xcat-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xuweibj/xcat-core/statuses/{sha}","languages_url":"https://api.github.com/repos/xuweibj/xcat-core/languages","stargazers_url":"https://api.github.com/repos/xuweibj/xcat-core/stargazers","contributors_url":"https://api.github.com/repos/xuweibj/xcat-core/contributors","subscribers_url":"https://api.github.com/repos/xuweibj/xcat-core/subscribers","subscription_url":"https://api.github.com/repos/xuweibj/xcat-core/subscription","commits_url":"https://api.github.com/repos/xuweibj/xcat-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/xuweibj/xcat-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/xuweibj/xcat-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/xuweibj/xcat-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/xuweibj/xcat-core/contents/{+path}","compare_url":"https://api.github.com/repos/xuweibj/xcat-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xuweibj/xcat-core/merges","archive_url":"https://api.github.com/repos/xuweibj/xcat-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xuweibj/xcat-core/downloads","issues_url":"https://api.github.com/repos/xuweibj/xcat-core/issues{/number}","pulls_url":"https://api.github.com/repos/xuweibj/xcat-core/pulls{/number}","milestones_url":"https://api.github.com/repos/xuweibj/xcat-core/milestones{/number}","notifications_url":"https://api.github.com/repos/xuweibj/xcat-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xuweibj/xcat-core/labels{/name}","releases_url":"https://api.github.com/repos/xuweibj/xcat-core/releases{/id}","deployments_url":"https://api.github.com/repos/xuweibj/xcat-core/deployments","created_at":"2015-11-03T05:30:52Z","updated_at":"2016-01-21T01:11:56Z","pushed_at":"2017-12-04T05:43:50Z","git_url":"git://github.com/xuweibj/xcat-core.git","ssh_url":"git@github.com:xuweibj/xcat-core.git","clone_url":"https://github.com/xuweibj/xcat-core.git","svn_url":"https://github.com/xuweibj/xcat-core","homepage":null,"size":193595,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xcat2:master","ref":"master","sha":"84246eb3d7cab3e7bb60053436c14d2389014a39","user":{"login":"xcat2","id":10124414,"avatar_url":"https://avatars3.githubusercontent.com/u/10124414?v=4","gravatar_id":"","url":"https://api.github.com/users/xcat2","html_url":"https://github.com/xcat2","followers_url":"https://api.github.com/users/xcat2/followers","following_url":"https://api.github.com/users/xcat2/following{/other_user}","gists_url":"https://api.github.com/users/xcat2/gists{/gist_id}","starred_url":"https://api.github.com/users/xcat2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xcat2/subscriptions","organizations_url":"https://api.github.com/users/xcat2/orgs","repos_url":"https://api.github.com/users/xcat2/repos","events_url":"https://api.github.com/users/xcat2/events{/privacy}","received_events_url":"https://api.github.com/users/xcat2/received_events","type":"Organization","site_admin":false},"repo":{"id":27747508,"name":"xcat-core","full_name":"xcat2/xcat-core","owner":{"login":"xcat2","id":10124414,"avatar_url":"https://avatars3.githubusercontent.com/u/10124414?v=4","gravatar_id":"","url":"https://api.github.com/users/xcat2","html_url":"https://github.com/xcat2","followers_url":"https://api.github.com/users/xcat2/followers","following_url":"https://api.github.com/users/xcat2/following{/other_user}","gists_url":"https://api.github.com/users/xcat2/gists{/gist_id}","starred_url":"https://api.github.com/users/xcat2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xcat2/subscriptions","organizations_url":"https://api.github.com/users/xcat2/orgs","repos_url":"https://api.github.com/users/xcat2/repos","events_url":"https://api.github.com/users/xcat2/events{/privacy}","received_events_url":"https://api.github.com/users/xcat2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xcat2/xcat-core","description":"Code repo for xCAT core packages","fork":false,"url":"https://api.github.com/repos/xcat2/xcat-core","forks_url":"https://api.github.com/repos/xcat2/xcat-core/forks","keys_url":"https://api.github.com/repos/xcat2/xcat-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xcat2/xcat-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xcat2/xcat-core/teams","hooks_url":"https://api.github.com/repos/xcat2/xcat-core/hooks","issue_events_url":"https://api.github.com/repos/xcat2/xcat-core/issues/events{/number}","events_url":"https://api.github.com/repos/xcat2/xcat-core/events","assignees_url":"https://api.github.com/repos/xcat2/xcat-core/assignees{/user}","branches_url":"https://api.github.com/repos/xcat2/xcat-core/branches{/branch}","tags_url":"https://api.github.com/repos/xcat2/xcat-core/tags","blobs_url":"https://api.github.com/repos/xcat2/xcat-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xcat2/xcat-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xcat2/xcat-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/xcat2/xcat-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xcat2/xcat-core/statuses/{sha}","languages_url":"https://api.github.com/repos/xcat2/xcat-core/languages","stargazers_url":"https://api.github.com/repos/xcat2/xcat-core/stargazers","contributors_url":"https://api.github.com/repos/xcat2/xcat-core/contributors","subscribers_url":"https://api.github.com/repos/xcat2/xcat-core/subscribers","subscription_url":"https://api.github.com/repos/xcat2/xcat-core/subscription","commits_url":"https://api.github.com/repos/xcat2/xcat-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/xcat2/xcat-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/xcat2/xcat-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/xcat2/xcat-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/xcat2/xcat-core/contents/{+path}","compare_url":"https://api.github.com/repos/xcat2/xcat-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xcat2/xcat-core/merges","archive_url":"https://api.github.com/repos/xcat2/xcat-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xcat2/xcat-core/downloads","issues_url":"https://api.github.com/repos/xcat2/xcat-core/issues{/number}","pulls_url":"https://api.github.com/repos/xcat2/xcat-core/pulls{/number}","milestones_url":"https://api.github.com/repos/xcat2/xcat-core/milestones{/number}","notifications_url":"https://api.github.com/repos/xcat2/xcat-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xcat2/xcat-core/labels{/name}","releases_url":"https://api.github.com/repos/xcat2/xcat-core/releases{/id}","deployments_url":"https://api.github.com/repos/xcat2/xcat-core/deployments","created_at":"2014-12-09T03:21:50Z","updated_at":"2017-12-01T01:40:59Z","pushed_at":"2017-12-04T09:55:45Z","git_url":"git://github.com/xcat2/xcat-core.git","ssh_url":"git@github.com:xcat2/xcat-core.git","clone_url":"https://github.com/xcat2/xcat-core.git","svn_url":"https://github.com/xcat2/xcat-core","homepage":null,"size":194187,"stargazers_count":112,"watchers_count":112,"language":"Perl","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":98,"mirror_url":null,"archived":false,"open_issues_count":320,"license":null,"forks":98,"open_issues":320,"watchers":112,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xcat2/xcat-core/pulls/4396"},"html":{"href":"https://github.com/xcat2/xcat-core/pull/4396"},"issue":{"href":"https://api.github.com/repos/xcat2/xcat-core/issues/4396"},"comments":{"href":"https://api.github.com/repos/xcat2/xcat-core/issues/4396/comments"},"review_comments":{"href":"https://api.github.com/repos/xcat2/xcat-core/pulls/4396/comments"},"review_comment":{"href":"https://api.github.com/repos/xcat2/xcat-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xcat2/xcat-core/pulls/4396/commits"},"statuses":{"href":"https://api.github.com/repos/xcat2/xcat-core/statuses/9818da87ee031c933ce788fca9b7e64007c1daca"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"gurevichmark"}}