{"action":"created","comment":{"url":"https://api.github.com/repos/Originate/exosphere/pulls/comments/132344217","pull_request_review_id":55414057,"id":132344217,"diff_hunk":"@@ -38,9 +38,12 @@ func NewTester(appConfig types.AppConfig, logger *Logger, appDir, homeDir string\n }\n \n // RunAppTests runs the tests for the entire application\n-func (a *Tester) RunAppTests() error {\n+func (a *Tester) RunAppTests(serviceName string) error {\n \ta.logChannel <- fmt.Sprintf(\"Testing application %s\", a.AppConfig.Name)\n \tnumFailed := 0\n+\tif serviceName != \"\" {\n+\t\ta.InternalServiceConfigs = map[string]types.ServiceConfig{serviceName: a.InternalServiceConfigs[serviceName]}\n+\t}","path":"exo-go/src/application/tester.go","position":10,"original_position":10,"commit_id":"5ac5373dc3006b658dfdaa799b046820325c2c0c","original_commit_id":"5ac5373dc3006b658dfdaa799b046820325c2c0c","user":{"login":"charlierudolph","id":1676758,"avatar_url":"https://avatars2.githubusercontent.com/u/1676758?v=4","gravatar_id":"","url":"https://api.github.com/users/charlierudolph","html_url":"https://github.com/charlierudolph","followers_url":"https://api.github.com/users/charlierudolph/followers","following_url":"https://api.github.com/users/charlierudolph/following{/other_user}","gists_url":"https://api.github.com/users/charlierudolph/gists{/gist_id}","starred_url":"https://api.github.com/users/charlierudolph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charlierudolph/subscriptions","organizations_url":"https://api.github.com/users/charlierudolph/orgs","repos_url":"https://api.github.com/users/charlierudolph/repos","events_url":"https://api.github.com/users/charlierudolph/events{/privacy}","received_events_url":"https://api.github.com/users/charlierudolph/received_events","type":"User","site_admin":false},"body":"I don't like overwriting `a.InternalServiceConfigs`. I think we should create another public function `RunServiceTests(serviceName string)`. We could have a helper which takes something of the same type of `a.InternalServiceConfigs` which we call either with `a.InternalServiceConfigs` or the custom object you build here when running a single service\r\n","created_at":"2017-08-10T01:09:59Z","updated_at":"2017-08-10T01:20:59Z","html_url":"https://github.com/Originate/exosphere/pull/435#discussion_r132344217","pull_request_url":"https://api.github.com/repos/Originate/exosphere/pulls/435","_links":{"self":{"href":"https://api.github.com/repos/Originate/exosphere/pulls/comments/132344217"},"html":{"href":"https://github.com/Originate/exosphere/pull/435#discussion_r132344217"},"pull_request":{"href":"https://api.github.com/repos/Originate/exosphere/pulls/435"}}},"pull_request":{"url":"https://api.github.com/repos/Originate/exosphere/pulls/435","id":135020995,"html_url":"https://github.com/Originate/exosphere/pull/435","diff_url":"https://github.com/Originate/exosphere/pull/435.diff","patch_url":"https://github.com/Originate/exosphere/pull/435.patch","issue_url":"https://api.github.com/repos/Originate/exosphere/issues/435","number":435,"state":"open","locked":false,"title":"Exo test runs in individual services","user":{"login":"mcharawi","id":5560805,"avatar_url":"https://avatars0.githubusercontent.com/u/5560805?v=4","gravatar_id":"","url":"https://api.github.com/users/mcharawi","html_url":"https://github.com/mcharawi","followers_url":"https://api.github.com/users/mcharawi/followers","following_url":"https://api.github.com/users/mcharawi/following{/other_user}","gists_url":"https://api.github.com/users/mcharawi/gists{/gist_id}","starred_url":"https://api.github.com/users/mcharawi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcharawi/subscriptions","organizations_url":"https://api.github.com/users/mcharawi/orgs","repos_url":"https://api.github.com/users/mcharawi/repos","events_url":"https://api.github.com/users/mcharawi/events{/privacy}","received_events_url":"https://api.github.com/users/mcharawi/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-08-10T00:55:03Z","updated_at":"2017-08-10T01:21:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cf094bc6dbb9416dd4a978ad1c53633b3778f193","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Originate/exosphere/pulls/435/commits","review_comments_url":"https://api.github.com/repos/Originate/exosphere/pulls/435/comments","review_comment_url":"https://api.github.com/repos/Originate/exosphere/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Originate/exosphere/issues/435/comments","statuses_url":"https://api.github.com/repos/Originate/exosphere/statuses/5ac5373dc3006b658dfdaa799b046820325c2c0c","head":{"label":"Originate:mc-ServiceTest","ref":"mc-ServiceTest","sha":"5ac5373dc3006b658dfdaa799b046820325c2c0c","user":{"login":"Originate","id":1627168,"avatar_url":"https://avatars3.githubusercontent.com/u/1627168?v=4","gravatar_id":"","url":"https://api.github.com/users/Originate","html_url":"https://github.com/Originate","followers_url":"https://api.github.com/users/Originate/followers","following_url":"https://api.github.com/users/Originate/following{/other_user}","gists_url":"https://api.github.com/users/Originate/gists{/gist_id}","starred_url":"https://api.github.com/users/Originate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Originate/subscriptions","organizations_url":"https://api.github.com/users/Originate/orgs","repos_url":"https://api.github.com/users/Originate/repos","events_url":"https://api.github.com/users/Originate/events{/privacy}","received_events_url":"https://api.github.com/users/Originate/received_events","type":"Organization","site_admin":false},"repo":{"id":75137299,"name":"exosphere","full_name":"Originate/exosphere","owner":{"login":"Originate","id":1627168,"avatar_url":"https://avatars3.githubusercontent.com/u/1627168?v=4","gravatar_id":"","url":"https://api.github.com/users/Originate","html_url":"https://github.com/Originate","followers_url":"https://api.github.com/users/Originate/followers","following_url":"https://api.github.com/users/Originate/following{/other_user}","gists_url":"https://api.github.com/users/Originate/gists{/gist_id}","starred_url":"https://api.github.com/users/Originate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Originate/subscriptions","organizations_url":"https://api.github.com/users/Originate/orgs","repos_url":"https://api.github.com/users/Originate/repos","events_url":"https://api.github.com/users/Originate/events{/privacy}","received_events_url":"https://api.github.com/users/Originate/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Originate/exosphere","description":"A modern cloud-based micro-service framework","fork":false,"url":"https://api.github.com/repos/Originate/exosphere","forks_url":"https://api.github.com/repos/Originate/exosphere/forks","keys_url":"https://api.github.com/repos/Originate/exosphere/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Originate/exosphere/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Originate/exosphere/teams","hooks_url":"https://api.github.com/repos/Originate/exosphere/hooks","issue_events_url":"https://api.github.com/repos/Originate/exosphere/issues/events{/number}","events_url":"https://api.github.com/repos/Originate/exosphere/events","assignees_url":"https://api.github.com/repos/Originate/exosphere/assignees{/user}","branches_url":"https://api.github.com/repos/Originate/exosphere/branches{/branch}","tags_url":"https://api.github.com/repos/Originate/exosphere/tags","blobs_url":"https://api.github.com/repos/Originate/exosphere/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Originate/exosphere/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Originate/exosphere/git/refs{/sha}","trees_url":"https://api.github.com/repos/Originate/exosphere/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Originate/exosphere/statuses/{sha}","languages_url":"https://api.github.com/repos/Originate/exosphere/languages","stargazers_url":"https://api.github.com/repos/Originate/exosphere/stargazers","contributors_url":"https://api.github.com/repos/Originate/exosphere/contributors","subscribers_url":"https://api.github.com/repos/Originate/exosphere/subscribers","subscription_url":"https://api.github.com/repos/Originate/exosphere/subscription","commits_url":"https://api.github.com/repos/Originate/exosphere/commits{/sha}","git_commits_url":"https://api.github.com/repos/Originate/exosphere/git/commits{/sha}","comments_url":"https://api.github.com/repos/Originate/exosphere/comments{/number}","issue_comment_url":"https://api.github.com/repos/Originate/exosphere/issues/comments{/number}","contents_url":"https://api.github.com/repos/Originate/exosphere/contents/{+path}","compare_url":"https://api.github.com/repos/Originate/exosphere/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Originate/exosphere/merges","archive_url":"https://api.github.com/repos/Originate/exosphere/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Originate/exosphere/downloads","issues_url":"https://api.github.com/repos/Originate/exosphere/issues{/number}","pulls_url":"https://api.github.com/repos/Originate/exosphere/pulls{/number}","milestones_url":"https://api.github.com/repos/Originate/exosphere/milestones{/number}","notifications_url":"https://api.github.com/repos/Originate/exosphere/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Originate/exosphere/labels{/name}","releases_url":"https://api.github.com/repos/Originate/exosphere/releases{/id}","deployments_url":"https://api.github.com/repos/Originate/exosphere/deployments","created_at":"2016-11-30T01:09:58Z","updated_at":"2017-07-20T19:23:47Z","pushed_at":"2017-08-10T00:56:56Z","git_url":"git://github.com/Originate/exosphere.git","ssh_url":"git@github.com:Originate/exosphere.git","clone_url":"https://github.com/Originate/exosphere.git","svn_url":"https://github.com/Originate/exosphere","homepage":null,"size":34385,"stargazers_count":5,"watchers_count":5,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":31,"forks":3,"open_issues":31,"watchers":5,"default_branch":"master"}},"base":{"label":"Originate:master","ref":"master","sha":"f7a1c5b00864e14597462737c34ed04ff2da17c4","user":{"login":"Originate","id":1627168,"avatar_url":"https://avatars3.githubusercontent.com/u/1627168?v=4","gravatar_id":"","url":"https://api.github.com/users/Originate","html_url":"https://github.com/Originate","followers_url":"https://api.github.com/users/Originate/followers","following_url":"https://api.github.com/users/Originate/following{/other_user}","gists_url":"https://api.github.com/users/Originate/gists{/gist_id}","starred_url":"https://api.github.com/users/Originate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Originate/subscriptions","organizations_url":"https://api.github.com/users/Originate/orgs","repos_url":"https://api.github.com/users/Originate/repos","events_url":"https://api.github.com/users/Originate/events{/privacy}","received_events_url":"https://api.github.com/users/Originate/received_events","type":"Organization","site_admin":false},"repo":{"id":75137299,"name":"exosphere","full_name":"Originate/exosphere","owner":{"login":"Originate","id":1627168,"avatar_url":"https://avatars3.githubusercontent.com/u/1627168?v=4","gravatar_id":"","url":"https://api.github.com/users/Originate","html_url":"https://github.com/Originate","followers_url":"https://api.github.com/users/Originate/followers","following_url":"https://api.github.com/users/Originate/following{/other_user}","gists_url":"https://api.github.com/users/Originate/gists{/gist_id}","starred_url":"https://api.github.com/users/Originate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Originate/subscriptions","organizations_url":"https://api.github.com/users/Originate/orgs","repos_url":"https://api.github.com/users/Originate/repos","events_url":"https://api.github.com/users/Originate/events{/privacy}","received_events_url":"https://api.github.com/users/Originate/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Originate/exosphere","description":"A modern cloud-based micro-service framework","fork":false,"url":"https://api.github.com/repos/Originate/exosphere","forks_url":"https://api.github.com/repos/Originate/exosphere/forks","keys_url":"https://api.github.com/repos/Originate/exosphere/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Originate/exosphere/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Originate/exosphere/teams","hooks_url":"https://api.github.com/repos/Originate/exosphere/hooks","issue_events_url":"https://api.github.com/repos/Originate/exosphere/issues/events{/number}","events_url":"https://api.github.com/repos/Originate/exosphere/events","assignees_url":"https://api.github.com/repos/Originate/exosphere/assignees{/user}","branches_url":"https://api.github.com/repos/Originate/exosphere/branches{/branch}","tags_url":"https://api.github.com/repos/Originate/exosphere/tags","blobs_url":"https://api.github.com/repos/Originate/exosphere/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Originate/exosphere/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Originate/exosphere/git/refs{/sha}","trees_url":"https://api.github.com/repos/Originate/exosphere/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Originate/exosphere/statuses/{sha}","languages_url":"https://api.github.com/repos/Originate/exosphere/languages","stargazers_url":"https://api.github.com/repos/Originate/exosphere/stargazers","contributors_url":"https://api.github.com/repos/Originate/exosphere/contributors","subscribers_url":"https://api.github.com/repos/Originate/exosphere/subscribers","subscription_url":"https://api.github.com/repos/Originate/exosphere/subscription","commits_url":"https://api.github.com/repos/Originate/exosphere/commits{/sha}","git_commits_url":"https://api.github.com/repos/Originate/exosphere/git/commits{/sha}","comments_url":"https://api.github.com/repos/Originate/exosphere/comments{/number}","issue_comment_url":"https://api.github.com/repos/Originate/exosphere/issues/comments{/number}","contents_url":"https://api.github.com/repos/Originate/exosphere/contents/{+path}","compare_url":"https://api.github.com/repos/Originate/exosphere/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Originate/exosphere/merges","archive_url":"https://api.github.com/repos/Originate/exosphere/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Originate/exosphere/downloads","issues_url":"https://api.github.com/repos/Originate/exosphere/issues{/number}","pulls_url":"https://api.github.com/repos/Originate/exosphere/pulls{/number}","milestones_url":"https://api.github.com/repos/Originate/exosphere/milestones{/number}","notifications_url":"https://api.github.com/repos/Originate/exosphere/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Originate/exosphere/labels{/name}","releases_url":"https://api.github.com/repos/Originate/exosphere/releases{/id}","deployments_url":"https://api.github.com/repos/Originate/exosphere/deployments","created_at":"2016-11-30T01:09:58Z","updated_at":"2017-07-20T19:23:47Z","pushed_at":"2017-08-10T00:56:56Z","git_url":"git://github.com/Originate/exosphere.git","ssh_url":"git@github.com:Originate/exosphere.git","clone_url":"https://github.com/Originate/exosphere.git","svn_url":"https://github.com/Originate/exosphere","homepage":null,"size":34385,"stargazers_count":5,"watchers_count":5,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":31,"forks":3,"open_issues":31,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Originate/exosphere/pulls/435"},"html":{"href":"https://github.com/Originate/exosphere/pull/435"},"issue":{"href":"https://api.github.com/repos/Originate/exosphere/issues/435"},"comments":{"href":"https://api.github.com/repos/Originate/exosphere/issues/435/comments"},"review_comments":{"href":"https://api.github.com/repos/Originate/exosphere/pulls/435/comments"},"review_comment":{"href":"https://api.github.com/repos/Originate/exosphere/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Originate/exosphere/pulls/435/commits"},"statuses":{"href":"https://api.github.com/repos/Originate/exosphere/statuses/5ac5373dc3006b658dfdaa799b046820325c2c0c"}}}}
{"actor":{"display_login":"charlierudolph"}}