{"action":"created","comment":{"url":"https://api.github.com/repos/LABSN/mnefun/pulls/comments/141149732","pull_request_review_id":65322434,"id":141149732,"diff_hunk":"@@ -1380,7 +1386,22 @@ def save_epochs(p, subjects, in_names, in_numbers, analyses, out_names,\n                 warnings.warn('resulting new sampling frequency %s not equal '\n                               'to previous values %s' % (new_sfreq, sfreqs))\n             sfreqs.add(new_sfreq)\n-        use_reject, use_flat = _restrict_reject_flat(p.reject, p.flat, raw)\n+        if p.autoreject_thresholds:\n+            from autoreject import get_rejection_threshold\n+            print('     Using autreject to compute rejection thresholds')\n+            temp_epochs = Epochs(raw, events, event_id=None, tmin=p.tmin,\n+                                 tmax=p.tmax, baseline=_get_baseline(p),\n+                                 proj=False, reject=None, flat=None,\n+                                 preload=True)\n+            new_dict = get_rejection_threshold(temp_epochs, decim=2)","path":"mnefun/_mnefun.py","position":39,"original_position":39,"commit_id":"2afa48314805d69a8c6fbae74dc55c4764aa4e39","original_commit_id":"2afa48314805d69a8c6fbae74dc55c4764aa4e39","user":{"login":"larsoner","id":2365790,"avatar_url":"https://avatars1.githubusercontent.com/u/2365790?v=4","gravatar_id":"","url":"https://api.github.com/users/larsoner","html_url":"https://github.com/larsoner","followers_url":"https://api.github.com/users/larsoner/followers","following_url":"https://api.github.com/users/larsoner/following{/other_user}","gists_url":"https://api.github.com/users/larsoner/gists{/gist_id}","starred_url":"https://api.github.com/users/larsoner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/larsoner/subscriptions","organizations_url":"https://api.github.com/users/larsoner/orgs","repos_url":"https://api.github.com/users/larsoner/repos","events_url":"https://api.github.com/users/larsoner/events{/privacy}","received_events_url":"https://api.github.com/users/larsoner/received_events","type":"User","site_admin":false},"body":"don't use `decim=2` here, use `decim[si]` in the `Epochs` constructor","created_at":"2017-09-26T18:50:14Z","updated_at":"2017-09-26T18:51:08Z","html_url":"https://github.com/LABSN/mnefun/pull/184#discussion_r141149732","pull_request_url":"https://api.github.com/repos/LABSN/mnefun/pulls/184","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/LABSN/mnefun/pulls/comments/141149732"},"html":{"href":"https://github.com/LABSN/mnefun/pull/184#discussion_r141149732"},"pull_request":{"href":"https://api.github.com/repos/LABSN/mnefun/pulls/184"}}},"pull_request":{"url":"https://api.github.com/repos/LABSN/mnefun/pulls/184","id":142217636,"html_url":"https://github.com/LABSN/mnefun/pull/184","diff_url":"https://github.com/LABSN/mnefun/pull/184.diff","patch_url":"https://github.com/LABSN/mnefun/pull/184.patch","issue_url":"https://api.github.com/repos/LABSN/mnefun/issues/184","number":184,"state":"open","locked":false,"title":"ENH:add autoreject channel thresholds to epoching","user":{"login":"kambysese","id":4381290,"avatar_url":"https://avatars1.githubusercontent.com/u/4381290?v=4","gravatar_id":"","url":"https://api.github.com/users/kambysese","html_url":"https://github.com/kambysese","followers_url":"https://api.github.com/users/kambysese/followers","following_url":"https://api.github.com/users/kambysese/following{/other_user}","gists_url":"https://api.github.com/users/kambysese/gists{/gist_id}","starred_url":"https://api.github.com/users/kambysese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kambysese/subscriptions","organizations_url":"https://api.github.com/users/kambysese/orgs","repos_url":"https://api.github.com/users/kambysese/repos","events_url":"https://api.github.com/users/kambysese/events{/privacy}","received_events_url":"https://api.github.com/users/kambysese/received_events","type":"User","site_admin":false},"body":"@larsoner please review. And do you think you could test on funloc sample data once we agree on implementation?","created_at":"2017-09-20T22:29:16Z","updated_at":"2017-09-26T18:51:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c6cd91c75f0344135170f6c36cc53efddc0864e0","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/LABSN/mnefun/pulls/184/commits","review_comments_url":"https://api.github.com/repos/LABSN/mnefun/pulls/184/comments","review_comment_url":"https://api.github.com/repos/LABSN/mnefun/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LABSN/mnefun/issues/184/comments","statuses_url":"https://api.github.com/repos/LABSN/mnefun/statuses/2afa48314805d69a8c6fbae74dc55c4764aa4e39","head":{"label":"kambysese:autoreject-threshold","ref":"autoreject-threshold","sha":"2afa48314805d69a8c6fbae74dc55c4764aa4e39","user":{"login":"kambysese","id":4381290,"avatar_url":"https://avatars1.githubusercontent.com/u/4381290?v=4","gravatar_id":"","url":"https://api.github.com/users/kambysese","html_url":"https://github.com/kambysese","followers_url":"https://api.github.com/users/kambysese/followers","following_url":"https://api.github.com/users/kambysese/following{/other_user}","gists_url":"https://api.github.com/users/kambysese/gists{/gist_id}","starred_url":"https://api.github.com/users/kambysese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kambysese/subscriptions","organizations_url":"https://api.github.com/users/kambysese/orgs","repos_url":"https://api.github.com/users/kambysese/repos","events_url":"https://api.github.com/users/kambysese/events{/privacy}","received_events_url":"https://api.github.com/users/kambysese/received_events","type":"User","site_admin":false},"repo":{"id":39974088,"name":"mnefun","full_name":"kambysese/mnefun","owner":{"login":"kambysese","id":4381290,"avatar_url":"https://avatars1.githubusercontent.com/u/4381290?v=4","gravatar_id":"","url":"https://api.github.com/users/kambysese","html_url":"https://github.com/kambysese","followers_url":"https://api.github.com/users/kambysese/followers","following_url":"https://api.github.com/users/kambysese/following{/other_user}","gists_url":"https://api.github.com/users/kambysese/gists{/gist_id}","starred_url":"https://api.github.com/users/kambysese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kambysese/subscriptions","organizations_url":"https://api.github.com/users/kambysese/orgs","repos_url":"https://api.github.com/users/kambysese/repos","events_url":"https://api.github.com/users/kambysese/events{/privacy}","received_events_url":"https://api.github.com/users/kambysese/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kambysese/mnefun","description":"Facilitating lab integration with mne-python","fork":true,"url":"https://api.github.com/repos/kambysese/mnefun","forks_url":"https://api.github.com/repos/kambysese/mnefun/forks","keys_url":"https://api.github.com/repos/kambysese/mnefun/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kambysese/mnefun/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kambysese/mnefun/teams","hooks_url":"https://api.github.com/repos/kambysese/mnefun/hooks","issue_events_url":"https://api.github.com/repos/kambysese/mnefun/issues/events{/number}","events_url":"https://api.github.com/repos/kambysese/mnefun/events","assignees_url":"https://api.github.com/repos/kambysese/mnefun/assignees{/user}","branches_url":"https://api.github.com/repos/kambysese/mnefun/branches{/branch}","tags_url":"https://api.github.com/repos/kambysese/mnefun/tags","blobs_url":"https://api.github.com/repos/kambysese/mnefun/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kambysese/mnefun/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kambysese/mnefun/git/refs{/sha}","trees_url":"https://api.github.com/repos/kambysese/mnefun/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kambysese/mnefun/statuses/{sha}","languages_url":"https://api.github.com/repos/kambysese/mnefun/languages","stargazers_url":"https://api.github.com/repos/kambysese/mnefun/stargazers","contributors_url":"https://api.github.com/repos/kambysese/mnefun/contributors","subscribers_url":"https://api.github.com/repos/kambysese/mnefun/subscribers","subscription_url":"https://api.github.com/repos/kambysese/mnefun/subscription","commits_url":"https://api.github.com/repos/kambysese/mnefun/commits{/sha}","git_commits_url":"https://api.github.com/repos/kambysese/mnefun/git/commits{/sha}","comments_url":"https://api.github.com/repos/kambysese/mnefun/comments{/number}","issue_comment_url":"https://api.github.com/repos/kambysese/mnefun/issues/comments{/number}","contents_url":"https://api.github.com/repos/kambysese/mnefun/contents/{+path}","compare_url":"https://api.github.com/repos/kambysese/mnefun/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kambysese/mnefun/merges","archive_url":"https://api.github.com/repos/kambysese/mnefun/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kambysese/mnefun/downloads","issues_url":"https://api.github.com/repos/kambysese/mnefun/issues{/number}","pulls_url":"https://api.github.com/repos/kambysese/mnefun/pulls{/number}","milestones_url":"https://api.github.com/repos/kambysese/mnefun/milestones{/number}","notifications_url":"https://api.github.com/repos/kambysese/mnefun/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kambysese/mnefun/labels{/name}","releases_url":"https://api.github.com/repos/kambysese/mnefun/releases{/id}","deployments_url":"https://api.github.com/repos/kambysese/mnefun/deployments","created_at":"2015-07-30T21:52:55Z","updated_at":"2016-11-09T16:44:16Z","pushed_at":"2017-09-26T18:36:18Z","git_url":"git://github.com/kambysese/mnefun.git","ssh_url":"git@github.com:kambysese/mnefun.git","clone_url":"https://github.com/kambysese/mnefun.git","svn_url":"https://github.com/kambysese/mnefun","homepage":null,"size":89329,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"LABSN:master","ref":"master","sha":"97aa4804f144f69601ea4da963a27790d3a7ec31","user":{"login":"LABSN","id":3766097,"avatar_url":"https://avatars2.githubusercontent.com/u/3766097?v=4","gravatar_id":"","url":"https://api.github.com/users/LABSN","html_url":"https://github.com/LABSN","followers_url":"https://api.github.com/users/LABSN/followers","following_url":"https://api.github.com/users/LABSN/following{/other_user}","gists_url":"https://api.github.com/users/LABSN/gists{/gist_id}","starred_url":"https://api.github.com/users/LABSN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LABSN/subscriptions","organizations_url":"https://api.github.com/users/LABSN/orgs","repos_url":"https://api.github.com/users/LABSN/repos","events_url":"https://api.github.com/users/LABSN/events{/privacy}","received_events_url":"https://api.github.com/users/LABSN/received_events","type":"Organization","site_admin":false},"repo":{"id":17719360,"name":"mnefun","full_name":"LABSN/mnefun","owner":{"login":"LABSN","id":3766097,"avatar_url":"https://avatars2.githubusercontent.com/u/3766097?v=4","gravatar_id":"","url":"https://api.github.com/users/LABSN","html_url":"https://github.com/LABSN","followers_url":"https://api.github.com/users/LABSN/followers","following_url":"https://api.github.com/users/LABSN/following{/other_user}","gists_url":"https://api.github.com/users/LABSN/gists{/gist_id}","starred_url":"https://api.github.com/users/LABSN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LABSN/subscriptions","organizations_url":"https://api.github.com/users/LABSN/orgs","repos_url":"https://api.github.com/users/LABSN/repos","events_url":"https://api.github.com/users/LABSN/events{/privacy}","received_events_url":"https://api.github.com/users/LABSN/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LABSN/mnefun","description":"Facilitating lab integration with mne-python","fork":false,"url":"https://api.github.com/repos/LABSN/mnefun","forks_url":"https://api.github.com/repos/LABSN/mnefun/forks","keys_url":"https://api.github.com/repos/LABSN/mnefun/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LABSN/mnefun/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LABSN/mnefun/teams","hooks_url":"https://api.github.com/repos/LABSN/mnefun/hooks","issue_events_url":"https://api.github.com/repos/LABSN/mnefun/issues/events{/number}","events_url":"https://api.github.com/repos/LABSN/mnefun/events","assignees_url":"https://api.github.com/repos/LABSN/mnefun/assignees{/user}","branches_url":"https://api.github.com/repos/LABSN/mnefun/branches{/branch}","tags_url":"https://api.github.com/repos/LABSN/mnefun/tags","blobs_url":"https://api.github.com/repos/LABSN/mnefun/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LABSN/mnefun/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LABSN/mnefun/git/refs{/sha}","trees_url":"https://api.github.com/repos/LABSN/mnefun/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LABSN/mnefun/statuses/{sha}","languages_url":"https://api.github.com/repos/LABSN/mnefun/languages","stargazers_url":"https://api.github.com/repos/LABSN/mnefun/stargazers","contributors_url":"https://api.github.com/repos/LABSN/mnefun/contributors","subscribers_url":"https://api.github.com/repos/LABSN/mnefun/subscribers","subscription_url":"https://api.github.com/repos/LABSN/mnefun/subscription","commits_url":"https://api.github.com/repos/LABSN/mnefun/commits{/sha}","git_commits_url":"https://api.github.com/repos/LABSN/mnefun/git/commits{/sha}","comments_url":"https://api.github.com/repos/LABSN/mnefun/comments{/number}","issue_comment_url":"https://api.github.com/repos/LABSN/mnefun/issues/comments{/number}","contents_url":"https://api.github.com/repos/LABSN/mnefun/contents/{+path}","compare_url":"https://api.github.com/repos/LABSN/mnefun/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LABSN/mnefun/merges","archive_url":"https://api.github.com/repos/LABSN/mnefun/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LABSN/mnefun/downloads","issues_url":"https://api.github.com/repos/LABSN/mnefun/issues{/number}","pulls_url":"https://api.github.com/repos/LABSN/mnefun/pulls{/number}","milestones_url":"https://api.github.com/repos/LABSN/mnefun/milestones{/number}","notifications_url":"https://api.github.com/repos/LABSN/mnefun/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LABSN/mnefun/labels{/name}","releases_url":"https://api.github.com/repos/LABSN/mnefun/releases{/id}","deployments_url":"https://api.github.com/repos/LABSN/mnefun/deployments","created_at":"2014-03-13T17:20:05Z","updated_at":"2016-12-13T21:57:45Z","pushed_at":"2017-09-26T18:36:20Z","git_url":"git://github.com/LABSN/mnefun.git","ssh_url":"git@github.com:LABSN/mnefun.git","clone_url":"https://github.com/LABSN/mnefun.git","svn_url":"https://github.com/LABSN/mnefun","homepage":null,"size":1239,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":7,"forks":9,"open_issues":7,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/LABSN/mnefun/pulls/184"},"html":{"href":"https://github.com/LABSN/mnefun/pull/184"},"issue":{"href":"https://api.github.com/repos/LABSN/mnefun/issues/184"},"comments":{"href":"https://api.github.com/repos/LABSN/mnefun/issues/184/comments"},"review_comments":{"href":"https://api.github.com/repos/LABSN/mnefun/pulls/184/comments"},"review_comment":{"href":"https://api.github.com/repos/LABSN/mnefun/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LABSN/mnefun/pulls/184/commits"},"statuses":{"href":"https://api.github.com/repos/LABSN/mnefun/statuses/2afa48314805d69a8c6fbae74dc55c4764aa4e39"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"larsoner"}}