{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/126460950","pull_request_review_id":48946752,"id":126460950,"diff_hunk":"@@ -4815,8 +4815,8 @@ void Compiler::compCompile(void** methodCodePtr, ULONG* methodCodeSize, JitFlags\n     m_pLinearScan = getLinearScanAllocator(this);\n \n     /* Lower */\n-    Lowering lower(this, m_pLinearScan); // PHASE_LOWERING\n-    lower.Run();\n+    m_pLowering = new (this, CMK_LSRA) Lowering(this, m_pLinearScan); // PHASE_LOWERING","path":"src/jit/compiler.cpp","position":6,"original_position":6,"commit_id":"45e5809182731645706098b03582dd09025ca145","original_commit_id":"45e5809182731645706098b03582dd09025ca145","user":{"login":"mikedn","id":9973420,"avatar_url":"https://avatars1.githubusercontent.com/u/9973420?v=3","gravatar_id":"","url":"https://api.github.com/users/mikedn","html_url":"https://github.com/mikedn","followers_url":"https://api.github.com/users/mikedn/followers","following_url":"https://api.github.com/users/mikedn/following{/other_user}","gists_url":"https://api.github.com/users/mikedn/gists{/gist_id}","starred_url":"https://api.github.com/users/mikedn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikedn/subscriptions","organizations_url":"https://api.github.com/users/mikedn/orgs","repos_url":"https://api.github.com/users/mikedn/repos","events_url":"https://api.github.com/users/mikedn/events{/privacy}","received_events_url":"https://api.github.com/users/mikedn/received_events","type":"User","site_admin":false},"body":"It would be nice if we could run liveness before lowering but I suppose it's problematic to ensure that lowering preserves liveness. As is now we end up passing some dead code through lowering, it only gets removed during liveness.","created_at":"2017-07-10T15:46:14Z","updated_at":"2017-07-10T15:46:14Z","html_url":"https://github.com/dotnet/coreclr/pull/12674#discussion_r126460950","pull_request_url":"https://api.github.com/repos/dotnet/coreclr/pulls/12674","_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/126460950"},"html":{"href":"https://github.com/dotnet/coreclr/pull/12674#discussion_r126460950"},"pull_request":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/12674"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/12674","id":129432090,"html_url":"https://github.com/dotnet/coreclr/pull/12674","diff_url":"https://github.com/dotnet/coreclr/pull/12674.diff","patch_url":"https://github.com/dotnet/coreclr/pull/12674.patch","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/12674","number":12674,"state":"open","locked":false,"title":"Move StoreLoc type widening to Lowering","user":{"login":"CarolEidt","id":2973870,"avatar_url":"https://avatars2.githubusercontent.com/u/2973870?v=3","gravatar_id":"","url":"https://api.github.com/users/CarolEidt","html_url":"https://github.com/CarolEidt","followers_url":"https://api.github.com/users/CarolEidt/followers","following_url":"https://api.github.com/users/CarolEidt/following{/other_user}","gists_url":"https://api.github.com/users/CarolEidt/gists{/gist_id}","starred_url":"https://api.github.com/users/CarolEidt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CarolEidt/subscriptions","organizations_url":"https://api.github.com/users/CarolEidt/orgs","repos_url":"https://api.github.com/users/CarolEidt/repos","events_url":"https://api.github.com/users/CarolEidt/events{/privacy}","received_events_url":"https://api.github.com/users/CarolEidt/received_events","type":"User","site_admin":false},"body":"This has been a \"TODO\" item in the source code for some time. Doing the widening earlier results in more cases where we use an xor to clear a register intead of storing zero, which is smaller. This also helps with the refactoring of containment analysis in preparation for moving it to `Lowering`.\r\nThere are 395 bytes of improvement over all of tests & frameworks for x64, with no regressions. On x86 the net improvement is 6102 bytes, with 7 methods regressing due to issues with preferencing the target of the xor.","created_at":"2017-07-07T15:38:53Z","updated_at":"2017-07-10T15:46:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f927f8e4db5c648294bb8894c4efaebbf5ba6468","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/coreclr/pulls/12674/commits","review_comments_url":"https://api.github.com/repos/dotnet/coreclr/pulls/12674/comments","review_comment_url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/12674/comments","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/45e5809182731645706098b03582dd09025ca145","head":{"label":"CarolEidt:LowerStoreLoc","ref":"LowerStoreLoc","sha":"45e5809182731645706098b03582dd09025ca145","user":{"login":"CarolEidt","id":2973870,"avatar_url":"https://avatars2.githubusercontent.com/u/2973870?v=3","gravatar_id":"","url":"https://api.github.com/users/CarolEidt","html_url":"https://github.com/CarolEidt","followers_url":"https://api.github.com/users/CarolEidt/followers","following_url":"https://api.github.com/users/CarolEidt/following{/other_user}","gists_url":"https://api.github.com/users/CarolEidt/gists{/gist_id}","starred_url":"https://api.github.com/users/CarolEidt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CarolEidt/subscriptions","organizations_url":"https://api.github.com/users/CarolEidt/orgs","repos_url":"https://api.github.com/users/CarolEidt/repos","events_url":"https://api.github.com/users/CarolEidt/events{/privacy}","received_events_url":"https://api.github.com/users/CarolEidt/received_events","type":"User","site_admin":false},"repo":{"id":31747006,"name":"coreclr","full_name":"CarolEidt/coreclr","owner":{"login":"CarolEidt","id":2973870,"avatar_url":"https://avatars2.githubusercontent.com/u/2973870?v=3","gravatar_id":"","url":"https://api.github.com/users/CarolEidt","html_url":"https://github.com/CarolEidt","followers_url":"https://api.github.com/users/CarolEidt/followers","following_url":"https://api.github.com/users/CarolEidt/following{/other_user}","gists_url":"https://api.github.com/users/CarolEidt/gists{/gist_id}","starred_url":"https://api.github.com/users/CarolEidt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CarolEidt/subscriptions","organizations_url":"https://api.github.com/users/CarolEidt/orgs","repos_url":"https://api.github.com/users/CarolEidt/repos","events_url":"https://api.github.com/users/CarolEidt/events{/privacy}","received_events_url":"https://api.github.com/users/CarolEidt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/CarolEidt/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called mscorlib. It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes.","fork":true,"url":"https://api.github.com/repos/CarolEidt/coreclr","forks_url":"https://api.github.com/repos/CarolEidt/coreclr/forks","keys_url":"https://api.github.com/repos/CarolEidt/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CarolEidt/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CarolEidt/coreclr/teams","hooks_url":"https://api.github.com/repos/CarolEidt/coreclr/hooks","issue_events_url":"https://api.github.com/repos/CarolEidt/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/CarolEidt/coreclr/events","assignees_url":"https://api.github.com/repos/CarolEidt/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/CarolEidt/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/CarolEidt/coreclr/tags","blobs_url":"https://api.github.com/repos/CarolEidt/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CarolEidt/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CarolEidt/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/CarolEidt/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CarolEidt/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/CarolEidt/coreclr/languages","stargazers_url":"https://api.github.com/repos/CarolEidt/coreclr/stargazers","contributors_url":"https://api.github.com/repos/CarolEidt/coreclr/contributors","subscribers_url":"https://api.github.com/repos/CarolEidt/coreclr/subscribers","subscription_url":"https://api.github.com/repos/CarolEidt/coreclr/subscription","commits_url":"https://api.github.com/repos/CarolEidt/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/CarolEidt/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/CarolEidt/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/CarolEidt/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/CarolEidt/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/CarolEidt/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CarolEidt/coreclr/merges","archive_url":"https://api.github.com/repos/CarolEidt/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CarolEidt/coreclr/downloads","issues_url":"https://api.github.com/repos/CarolEidt/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/CarolEidt/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/CarolEidt/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/CarolEidt/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CarolEidt/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/CarolEidt/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/CarolEidt/coreclr/deployments","created_at":"2015-03-06T01:49:09Z","updated_at":"2017-07-06T07:44:50Z","pushed_at":"2017-07-10T05:54:00Z","git_url":"git://github.com/CarolEidt/coreclr.git","ssh_url":"git@github.com:CarolEidt/coreclr.git","clone_url":"https://github.com/CarolEidt/coreclr.git","svn_url":"https://github.com/CarolEidt/coreclr","homepage":"","size":164189,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"e6727e656094143730c16a8288e0e6c4412a59aa","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars3.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":30092893,"name":"coreclr","full_name":"dotnet/coreclr","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars3.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called mscorlib. It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes. We welcome contributions.","fork":false,"url":"https://api.github.com/repos/dotnet/coreclr","forks_url":"https://api.github.com/repos/dotnet/coreclr/forks","keys_url":"https://api.github.com/repos/dotnet/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/coreclr/teams","hooks_url":"https://api.github.com/repos/dotnet/coreclr/hooks","issue_events_url":"https://api.github.com/repos/dotnet/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/coreclr/events","assignees_url":"https://api.github.com/repos/dotnet/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/coreclr/tags","blobs_url":"https://api.github.com/repos/dotnet/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/coreclr/languages","stargazers_url":"https://api.github.com/repos/dotnet/coreclr/stargazers","contributors_url":"https://api.github.com/repos/dotnet/coreclr/contributors","subscribers_url":"https://api.github.com/repos/dotnet/coreclr/subscribers","subscription_url":"https://api.github.com/repos/dotnet/coreclr/subscription","commits_url":"https://api.github.com/repos/dotnet/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/coreclr/merges","archive_url":"https://api.github.com/repos/dotnet/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/coreclr/downloads","issues_url":"https://api.github.com/repos/dotnet/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/coreclr/deployments","created_at":"2015-01-30T22:10:02Z","updated_at":"2017-07-10T14:09:39Z","pushed_at":"2017-07-10T15:45:57Z","git_url":"git://github.com/dotnet/coreclr.git","ssh_url":"git@github.com:dotnet/coreclr.git","clone_url":"https://github.com/dotnet/coreclr.git","svn_url":"https://github.com/dotnet/coreclr","homepage":"https://github.com/dotnet/core","size":165614,"stargazers_count":7896,"watchers_count":7896,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1984,"mirror_url":null,"open_issues_count":1324,"forks":1984,"open_issues":1324,"watchers":7896,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/12674"},"html":{"href":"https://github.com/dotnet/coreclr/pull/12674"},"issue":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/12674"},"comments":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/12674/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/12674/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/12674/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/coreclr/statuses/45e5809182731645706098b03582dd09025ca145"}}}}
{"actor":{"display_login":"mikedn"}}