{"action":"created","comment":{"url":"https://api.github.com/repos/almende/vis/pulls/comments/114497705","pull_request_review_id":35966783,"id":114497705,"diff_hunk":"@@ -145,16 +145,26 @@ Item.prototype.repositionY = function() {\n  */\n Item.prototype._repaintDragCenter = function () {\n   if (this.selected && this.options.editable.updateTime && !this.dom.dragCenter) {\n-    var me = this;\n-\n+    var me = this\n     // create and show drag area\n     var dragCenter = document.createElement('div');\n     dragCenter.className = 'vis-drag-center';\n     dragCenter.dragCenterItem = this;\n+    this.hammer = new Hammer(dragCenter)\n \n-    new Hammer(dragCenter).on('doubletap', function (event) {\n+    this.hammer.on('tap', function (event) {\n+      me.parent.itemSet.body.emitter.emit('click',  {\n+        event: event,\n+        item: me.id\n+      });\n+    });\n+    this.hammer.on('doubletap', function (event) {","path":"lib/timeline/component/item/Item.js","position":20,"original_position":20,"commit_id":"2bf3f4374d8e23b81d2b83e8950e0afbe4040a03","original_commit_id":"2d99aca1bf6dddef31a42e9cbb32582a8ade891e","user":{"login":"yotamberk","id":4319928,"avatar_url":"https://avatars0.githubusercontent.com/u/4319928?v=3","gravatar_id":"","url":"https://api.github.com/users/yotamberk","html_url":"https://github.com/yotamberk","followers_url":"https://api.github.com/users/yotamberk/followers","following_url":"https://api.github.com/users/yotamberk/following{/other_user}","gists_url":"https://api.github.com/users/yotamberk/gists{/gist_id}","starred_url":"https://api.github.com/users/yotamberk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yotamberk/subscriptions","organizations_url":"https://api.github.com/users/yotamberk/orgs","repos_url":"https://api.github.com/users/yotamberk/repos","events_url":"https://api.github.com/users/yotamberk/events{/privacy}","received_events_url":"https://api.github.com/users/yotamberk/received_events","type":"User","site_admin":false},"body":"They don't fire consecutively. It's one or the other. There is no need for `requireFailure()` here because it hasn't been used anywhere else. I can add it in another PR.","created_at":"2017-05-03T08:53:34Z","updated_at":"2017-05-03T08:53:34Z","html_url":"https://github.com/almende/vis/pull/2988#discussion_r114497705","pull_request_url":"https://api.github.com/repos/almende/vis/pulls/2988","_links":{"self":{"href":"https://api.github.com/repos/almende/vis/pulls/comments/114497705"},"html":{"href":"https://github.com/almende/vis/pull/2988#discussion_r114497705"},"pull_request":{"href":"https://api.github.com/repos/almende/vis/pulls/2988"}}},"pull_request":{"url":"https://api.github.com/repos/almende/vis/pulls/2988","id":116063465,"html_url":"https://github.com/almende/vis/pull/2988","diff_url":"https://github.com/almende/vis/pull/2988.diff","patch_url":"https://github.com/almende/vis/pull/2988.patch","issue_url":"https://api.github.com/repos/almende/vis/issues/2988","number":2988,"state":"open","locked":false,"title":"Fix click and doubleclick events on items","user":{"login":"yotamberk","id":4319928,"avatar_url":"https://avatars0.githubusercontent.com/u/4319928?v=3","gravatar_id":"","url":"https://api.github.com/users/yotamberk","html_url":"https://github.com/yotamberk","followers_url":"https://api.github.com/users/yotamberk/followers","following_url":"https://api.github.com/users/yotamberk/following{/other_user}","gists_url":"https://api.github.com/users/yotamberk/gists{/gist_id}","starred_url":"https://api.github.com/users/yotamberk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yotamberk/subscriptions","organizations_url":"https://api.github.com/users/yotamberk/orgs","repos_url":"https://api.github.com/users/yotamberk/repos","events_url":"https://api.github.com/users/yotamberk/events{/privacy}","received_events_url":"https://api.github.com/users/yotamberk/received_events","type":"User","site_admin":false},"body":"There was a major bug I encountered trying to catch click and doubleclick events on selected items. \r\nThis PR solves this bug. (continues #2473 to fully solve: #2421, )\r\ncheckout the vis/examples/timeline/interaction/eventListeners.html example in this PR to see the click\\doubleclick event getting fired when an item is already selected.","created_at":"2017-04-16T16:26:20Z","updated_at":"2017-05-03T08:53:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"999c4ed7d014fa45d5740523d2f0f6f9f0f7f4aa","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/almende/vis/pulls/2988/commits","review_comments_url":"https://api.github.com/repos/almende/vis/pulls/2988/comments","review_comment_url":"https://api.github.com/repos/almende/vis/pulls/comments{/number}","comments_url":"https://api.github.com/repos/almende/vis/issues/2988/comments","statuses_url":"https://api.github.com/repos/almende/vis/statuses/2bf3f4374d8e23b81d2b83e8950e0afbe4040a03","head":{"label":"yotamberk:fix-click-item","ref":"fix-click-item","sha":"2bf3f4374d8e23b81d2b83e8950e0afbe4040a03","user":{"login":"yotamberk","id":4319928,"avatar_url":"https://avatars0.githubusercontent.com/u/4319928?v=3","gravatar_id":"","url":"https://api.github.com/users/yotamberk","html_url":"https://github.com/yotamberk","followers_url":"https://api.github.com/users/yotamberk/followers","following_url":"https://api.github.com/users/yotamberk/following{/other_user}","gists_url":"https://api.github.com/users/yotamberk/gists{/gist_id}","starred_url":"https://api.github.com/users/yotamberk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yotamberk/subscriptions","organizations_url":"https://api.github.com/users/yotamberk/orgs","repos_url":"https://api.github.com/users/yotamberk/repos","events_url":"https://api.github.com/users/yotamberk/events{/privacy}","received_events_url":"https://api.github.com/users/yotamberk/received_events","type":"User","site_admin":false},"repo":{"id":53567798,"name":"vis","full_name":"yotamberk/vis","owner":{"login":"yotamberk","id":4319928,"avatar_url":"https://avatars0.githubusercontent.com/u/4319928?v=3","gravatar_id":"","url":"https://api.github.com/users/yotamberk","html_url":"https://github.com/yotamberk","followers_url":"https://api.github.com/users/yotamberk/followers","following_url":"https://api.github.com/users/yotamberk/following{/other_user}","gists_url":"https://api.github.com/users/yotamberk/gists{/gist_id}","starred_url":"https://api.github.com/users/yotamberk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yotamberk/subscriptions","organizations_url":"https://api.github.com/users/yotamberk/orgs","repos_url":"https://api.github.com/users/yotamberk/repos","events_url":"https://api.github.com/users/yotamberk/events{/privacy}","received_events_url":"https://api.github.com/users/yotamberk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yotamberk/vis","description":"Dynamic, browser-based visualization library","fork":true,"url":"https://api.github.com/repos/yotamberk/vis","forks_url":"https://api.github.com/repos/yotamberk/vis/forks","keys_url":"https://api.github.com/repos/yotamberk/vis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yotamberk/vis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yotamberk/vis/teams","hooks_url":"https://api.github.com/repos/yotamberk/vis/hooks","issue_events_url":"https://api.github.com/repos/yotamberk/vis/issues/events{/number}","events_url":"https://api.github.com/repos/yotamberk/vis/events","assignees_url":"https://api.github.com/repos/yotamberk/vis/assignees{/user}","branches_url":"https://api.github.com/repos/yotamberk/vis/branches{/branch}","tags_url":"https://api.github.com/repos/yotamberk/vis/tags","blobs_url":"https://api.github.com/repos/yotamberk/vis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yotamberk/vis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yotamberk/vis/git/refs{/sha}","trees_url":"https://api.github.com/repos/yotamberk/vis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yotamberk/vis/statuses/{sha}","languages_url":"https://api.github.com/repos/yotamberk/vis/languages","stargazers_url":"https://api.github.com/repos/yotamberk/vis/stargazers","contributors_url":"https://api.github.com/repos/yotamberk/vis/contributors","subscribers_url":"https://api.github.com/repos/yotamberk/vis/subscribers","subscription_url":"https://api.github.com/repos/yotamberk/vis/subscription","commits_url":"https://api.github.com/repos/yotamberk/vis/commits{/sha}","git_commits_url":"https://api.github.com/repos/yotamberk/vis/git/commits{/sha}","comments_url":"https://api.github.com/repos/yotamberk/vis/comments{/number}","issue_comment_url":"https://api.github.com/repos/yotamberk/vis/issues/comments{/number}","contents_url":"https://api.github.com/repos/yotamberk/vis/contents/{+path}","compare_url":"https://api.github.com/repos/yotamberk/vis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yotamberk/vis/merges","archive_url":"https://api.github.com/repos/yotamberk/vis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yotamberk/vis/downloads","issues_url":"https://api.github.com/repos/yotamberk/vis/issues{/number}","pulls_url":"https://api.github.com/repos/yotamberk/vis/pulls{/number}","milestones_url":"https://api.github.com/repos/yotamberk/vis/milestones{/number}","notifications_url":"https://api.github.com/repos/yotamberk/vis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yotamberk/vis/labels{/name}","releases_url":"https://api.github.com/repos/yotamberk/vis/releases{/id}","deployments_url":"https://api.github.com/repos/yotamberk/vis/deployments","created_at":"2016-03-10T08:25:03Z","updated_at":"2016-03-10T08:25:05Z","pushed_at":"2017-05-01T10:56:12Z","git_url":"git://github.com/yotamberk/vis.git","ssh_url":"git@github.com:yotamberk/vis.git","clone_url":"https://github.com/yotamberk/vis.git","svn_url":"https://github.com/yotamberk/vis","homepage":"http://visjs.org","size":133081,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"almende:develop","ref":"develop","sha":"77699b4fd9f321e1923d30766ca220d6414b6028","user":{"login":"almende","id":1436571,"avatar_url":"https://avatars3.githubusercontent.com/u/1436571?v=3","gravatar_id":"","url":"https://api.github.com/users/almende","html_url":"https://github.com/almende","followers_url":"https://api.github.com/users/almende/followers","following_url":"https://api.github.com/users/almende/following{/other_user}","gists_url":"https://api.github.com/users/almende/gists{/gist_id}","starred_url":"https://api.github.com/users/almende/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/almende/subscriptions","organizations_url":"https://api.github.com/users/almende/orgs","repos_url":"https://api.github.com/users/almende/repos","events_url":"https://api.github.com/users/almende/events{/privacy}","received_events_url":"https://api.github.com/users/almende/received_events","type":"Organization","site_admin":false},"repo":{"id":9467421,"name":"vis","full_name":"almende/vis","owner":{"login":"almende","id":1436571,"avatar_url":"https://avatars3.githubusercontent.com/u/1436571?v=3","gravatar_id":"","url":"https://api.github.com/users/almende","html_url":"https://github.com/almende","followers_url":"https://api.github.com/users/almende/followers","following_url":"https://api.github.com/users/almende/following{/other_user}","gists_url":"https://api.github.com/users/almende/gists{/gist_id}","starred_url":"https://api.github.com/users/almende/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/almende/subscriptions","organizations_url":"https://api.github.com/users/almende/orgs","repos_url":"https://api.github.com/users/almende/repos","events_url":"https://api.github.com/users/almende/events{/privacy}","received_events_url":"https://api.github.com/users/almende/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/almende/vis","description":"Dynamic, browser-based visualization library","fork":false,"url":"https://api.github.com/repos/almende/vis","forks_url":"https://api.github.com/repos/almende/vis/forks","keys_url":"https://api.github.com/repos/almende/vis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/almende/vis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/almende/vis/teams","hooks_url":"https://api.github.com/repos/almende/vis/hooks","issue_events_url":"https://api.github.com/repos/almende/vis/issues/events{/number}","events_url":"https://api.github.com/repos/almende/vis/events","assignees_url":"https://api.github.com/repos/almende/vis/assignees{/user}","branches_url":"https://api.github.com/repos/almende/vis/branches{/branch}","tags_url":"https://api.github.com/repos/almende/vis/tags","blobs_url":"https://api.github.com/repos/almende/vis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/almende/vis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/almende/vis/git/refs{/sha}","trees_url":"https://api.github.com/repos/almende/vis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/almende/vis/statuses/{sha}","languages_url":"https://api.github.com/repos/almende/vis/languages","stargazers_url":"https://api.github.com/repos/almende/vis/stargazers","contributors_url":"https://api.github.com/repos/almende/vis/contributors","subscribers_url":"https://api.github.com/repos/almende/vis/subscribers","subscription_url":"https://api.github.com/repos/almende/vis/subscription","commits_url":"https://api.github.com/repos/almende/vis/commits{/sha}","git_commits_url":"https://api.github.com/repos/almende/vis/git/commits{/sha}","comments_url":"https://api.github.com/repos/almende/vis/comments{/number}","issue_comment_url":"https://api.github.com/repos/almende/vis/issues/comments{/number}","contents_url":"https://api.github.com/repos/almende/vis/contents/{+path}","compare_url":"https://api.github.com/repos/almende/vis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/almende/vis/merges","archive_url":"https://api.github.com/repos/almende/vis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/almende/vis/downloads","issues_url":"https://api.github.com/repos/almende/vis/issues{/number}","pulls_url":"https://api.github.com/repos/almende/vis/pulls{/number}","milestones_url":"https://api.github.com/repos/almende/vis/milestones{/number}","notifications_url":"https://api.github.com/repos/almende/vis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/almende/vis/labels{/name}","releases_url":"https://api.github.com/repos/almende/vis/releases{/id}","deployments_url":"https://api.github.com/repos/almende/vis/deployments","created_at":"2013-04-16T08:01:02Z","updated_at":"2017-05-03T07:33:10Z","pushed_at":"2017-05-03T07:40:53Z","git_url":"git://github.com/almende/vis.git","ssh_url":"git@github.com:almende/vis.git","clone_url":"https://github.com/almende/vis.git","svn_url":"https://github.com/almende/vis","homepage":"http://visjs.org","size":133339,"stargazers_count":5105,"watchers_count":5105,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":894,"mirror_url":null,"open_issues_count":359,"forks":894,"open_issues":359,"watchers":5105,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/almende/vis/pulls/2988"},"html":{"href":"https://github.com/almende/vis/pull/2988"},"issue":{"href":"https://api.github.com/repos/almende/vis/issues/2988"},"comments":{"href":"https://api.github.com/repos/almende/vis/issues/2988/comments"},"review_comments":{"href":"https://api.github.com/repos/almende/vis/pulls/2988/comments"},"review_comment":{"href":"https://api.github.com/repos/almende/vis/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/almende/vis/pulls/2988/commits"},"statuses":{"href":"https://api.github.com/repos/almende/vis/statuses/2bf3f4374d8e23b81d2b83e8950e0afbe4040a03"}}}}
{"actor":{"display_login":"yotamberk"}}