{"action":"closed","number":124,"pull_request":{"url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/pulls/124","id":101773593,"html_url":"https://github.com/zendframework/zend-expressive-skeleton/pull/124","diff_url":"https://github.com/zendframework/zend-expressive-skeleton/pull/124.diff","patch_url":"https://github.com/zendframework/zend-expressive-skeleton/pull/124.patch","issue_url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/issues/124","number":124,"state":"closed","locked":false,"title":"Allow choosing minimal, flat, or modular structure during installation","user":{"login":"weierophinney","id":25943,"avatar_url":"https://avatars.githubusercontent.com/u/25943?v=3","gravatar_id":"","url":"https://api.github.com/users/weierophinney","html_url":"https://github.com/weierophinney","followers_url":"https://api.github.com/users/weierophinney/followers","following_url":"https://api.github.com/users/weierophinney/following{/other_user}","gists_url":"https://api.github.com/users/weierophinney/gists{/gist_id}","starred_url":"https://api.github.com/users/weierophinney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weierophinney/subscriptions","organizations_url":"https://api.github.com/users/weierophinney/orgs","repos_url":"https://api.github.com/users/weierophinney/repos","events_url":"https://api.github.com/users/weierophinney/events{/privacy}","received_events_url":"https://api.github.com/users/weierophinney/received_events","type":"User","site_admin":false},"body":"Per [commentary on #54](https://github.com/zendframework/zend-expressive-skeleton/pull/54#issuecomment-267369918), this patch updates the installer to allow for either of:\n\n- Minimal installation (no default middleware, templates, or assets)\n- Flat structure (what was shipped in 1.0; remains the default)\n- Modular structure (makes the `App` namespace into a \"modular\" structure; recommended)\n\nThis required rewriting a fair number of tests, as the location of the `App\\ConfigProvider` will now vary based on the selection, as will templates, and we needed a way to ensure that PHPUnit does not cache the locations between tests.\n\nAs such, a number of the tests now do the following:\n\n- Run in a separate process. (This was necessary to prevent caching issues.)\n- Re-create the project source files (`config/`, `public/`, `src/`, `test/`) under a new directory under the system temporary directory.\n- Notify the installer of the new project root, and change working directories to that location.\n- Clean up after verification.\n\nI've also edited all distribution configuration files to ensure they follow the same guidelines and structure (importing classes used, etc.) and to ensure dependencies that are no longer needed are not present.","created_at":"2017-01-16T23:29:34Z","updated_at":"2017-01-17T20:27:31Z","closed_at":"2017-01-17T20:27:31Z","merged_at":"2017-01-17T20:27:31Z","merge_commit_sha":"1cb26ddff964a974b786e398dc0945c01a3f3281","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/milestones/8","html_url":"https://github.com/zendframework/zend-expressive-skeleton/milestone/8","labels_url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/milestones/8/labels","id":1490134,"number":8,"title":"1.1.0","description":null,"creator":{"login":"xtreamwayz","id":9497586,"avatar_url":"https://avatars.githubusercontent.com/u/9497586?v=3","gravatar_id":"","url":"https://api.github.com/users/xtreamwayz","html_url":"https://github.com/xtreamwayz","followers_url":"https://api.github.com/users/xtreamwayz/followers","following_url":"https://api.github.com/users/xtreamwayz/following{/other_user}","gists_url":"https://api.github.com/users/xtreamwayz/gists{/gist_id}","starred_url":"https://api.github.com/users/xtreamwayz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xtreamwayz/subscriptions","organizations_url":"https://api.github.com/users/xtreamwayz/orgs","repos_url":"https://api.github.com/users/xtreamwayz/repos","events_url":"https://api.github.com/users/xtreamwayz/events{/privacy}","received_events_url":"https://api.github.com/users/xtreamwayz/received_events","type":"User","site_admin":false},"open_issues":0,"closed_issues":7,"state":"open","created_at":"2016-01-07T18:43:03Z","updated_at":"2017-01-17T20:27:31Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/pulls/124/commits","review_comments_url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/pulls/124/comments","review_comment_url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/issues/124/comments","statuses_url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/statuses/1cb26ddff964a974b786e398dc0945c01a3f3281","head":{"label":"weierophinney:feature/minimal-modular-flat","ref":"feature/minimal-modular-flat","sha":"1cb26ddff964a974b786e398dc0945c01a3f3281","user":{"login":"weierophinney","id":25943,"avatar_url":"https://avatars.githubusercontent.com/u/25943?v=3","gravatar_id":"","url":"https://api.github.com/users/weierophinney","html_url":"https://github.com/weierophinney","followers_url":"https://api.github.com/users/weierophinney/followers","following_url":"https://api.github.com/users/weierophinney/following{/other_user}","gists_url":"https://api.github.com/users/weierophinney/gists{/gist_id}","starred_url":"https://api.github.com/users/weierophinney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weierophinney/subscriptions","organizations_url":"https://api.github.com/users/weierophinney/orgs","repos_url":"https://api.github.com/users/weierophinney/repos","events_url":"https://api.github.com/users/weierophinney/events{/privacy}","received_events_url":"https://api.github.com/users/weierophinney/received_events","type":"User","site_admin":false},"repo":{"id":44029832,"name":"zend-expressive-skeleton","full_name":"weierophinney/zend-expressive-skeleton","owner":{"login":"weierophinney","id":25943,"avatar_url":"https://avatars.githubusercontent.com/u/25943?v=3","gravatar_id":"","url":"https://api.github.com/users/weierophinney","html_url":"https://github.com/weierophinney","followers_url":"https://api.github.com/users/weierophinney/followers","following_url":"https://api.github.com/users/weierophinney/following{/other_user}","gists_url":"https://api.github.com/users/weierophinney/gists{/gist_id}","starred_url":"https://api.github.com/users/weierophinney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weierophinney/subscriptions","organizations_url":"https://api.github.com/users/weierophinney/orgs","repos_url":"https://api.github.com/users/weierophinney/repos","events_url":"https://api.github.com/users/weierophinney/events{/privacy}","received_events_url":"https://api.github.com/users/weierophinney/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/weierophinney/zend-expressive-skeleton","description":"Begin developing PSR-7 middleware applications in seconds!","fork":true,"url":"https://api.github.com/repos/weierophinney/zend-expressive-skeleton","forks_url":"https://api.github.com/repos/weierophinney/zend-expressive-skeleton/forks","keys_url":"https://api.github.com/repos/weierophinney/zend-expressive-skeleton/keys{/key_id}","collaborators_url":"https://api.github.com/repos/weierophinney/zend-expressive-skeleton/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/weierophinney/zend-expressive-skeleton/teams","hooks_url":"https://api.github.com/repos/weierophinney/zend-expressive-skeleton/hooks","issue_events_url":"https://api.github.com/repos/weierophinney/zend-expressive-skeleton/issues/events{/number}","events_url":"https://api.github.com/repos/weierophinney/zend-expressive-skeleton/events","assignees_url":"https://api.github.com/repos/weierophinney/zend-expressive-skeleton/assignees{/user}","branches_url":"https://api.github.com/repos/weierophinney/zend-expressive-skeleton/branches{/branch}","tags_url":"https://api.github.com/repos/weierophinney/zend-expressive-skeleton/tags","blobs_url":"https://api.github.com/repos/weierophinney/zend-expressive-skeleton/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/weierophinney/zend-expressive-skeleton/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/weierophinney/zend-expressive-skeleton/git/refs{/sha}","trees_url":"https://api.github.com/repos/weierophinney/zend-expressive-skeleton/git/trees{/sha}","statuses_url":"https://api.github.com/repos/weierophinney/zend-expressive-skeleton/statuses/{sha}","languages_url":"https://api.github.com/repos/weierophinney/zend-expressive-skeleton/languages","stargazers_url":"https://api.github.com/repos/weierophinney/zend-expressive-skeleton/stargazers","contributors_url":"https://api.github.com/repos/weierophinney/zend-expressive-skeleton/contributors","subscribers_url":"https://api.github.com/repos/weierophinney/zend-expressive-skeleton/subscribers","subscription_url":"https://api.github.com/repos/weierophinney/zend-expressive-skeleton/subscription","commits_url":"https://api.github.com/repos/weierophinney/zend-expressive-skeleton/commits{/sha}","git_commits_url":"https://api.github.com/repos/weierophinney/zend-expressive-skeleton/git/commits{/sha}","comments_url":"https://api.github.com/repos/weierophinney/zend-expressive-skeleton/comments{/number}","issue_comment_url":"https://api.github.com/repos/weierophinney/zend-expressive-skeleton/issues/comments{/number}","contents_url":"https://api.github.com/repos/weierophinney/zend-expressive-skeleton/contents/{+path}","compare_url":"https://api.github.com/repos/weierophinney/zend-expressive-skeleton/compare/{base}...{head}","merges_url":"https://api.github.com/repos/weierophinney/zend-expressive-skeleton/merges","archive_url":"https://api.github.com/repos/weierophinney/zend-expressive-skeleton/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/weierophinney/zend-expressive-skeleton/downloads","issues_url":"https://api.github.com/repos/weierophinney/zend-expressive-skeleton/issues{/number}","pulls_url":"https://api.github.com/repos/weierophinney/zend-expressive-skeleton/pulls{/number}","milestones_url":"https://api.github.com/repos/weierophinney/zend-expressive-skeleton/milestones{/number}","notifications_url":"https://api.github.com/repos/weierophinney/zend-expressive-skeleton/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/weierophinney/zend-expressive-skeleton/labels{/name}","releases_url":"https://api.github.com/repos/weierophinney/zend-expressive-skeleton/releases{/id}","deployments_url":"https://api.github.com/repos/weierophinney/zend-expressive-skeleton/deployments","created_at":"2015-10-10T21:54:46Z","updated_at":"2015-10-10T21:54:46Z","pushed_at":"2017-01-17T20:19:27Z","git_url":"git://github.com/weierophinney/zend-expressive-skeleton.git","ssh_url":"git@github.com:weierophinney/zend-expressive-skeleton.git","clone_url":"https://github.com/weierophinney/zend-expressive-skeleton.git","svn_url":"https://github.com/weierophinney/zend-expressive-skeleton","homepage":"","size":528,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zendframework:develop","ref":"develop","sha":"57be9276bec5f5c53b865939fdffb9b7c090a6de","user":{"login":"zendframework","id":296074,"avatar_url":"https://avatars.githubusercontent.com/u/296074?v=3","gravatar_id":"","url":"https://api.github.com/users/zendframework","html_url":"https://github.com/zendframework","followers_url":"https://api.github.com/users/zendframework/followers","following_url":"https://api.github.com/users/zendframework/following{/other_user}","gists_url":"https://api.github.com/users/zendframework/gists{/gist_id}","starred_url":"https://api.github.com/users/zendframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendframework/subscriptions","organizations_url":"https://api.github.com/users/zendframework/orgs","repos_url":"https://api.github.com/users/zendframework/repos","events_url":"https://api.github.com/users/zendframework/events{/privacy}","received_events_url":"https://api.github.com/users/zendframework/received_events","type":"Organization","site_admin":false},"repo":{"id":43980294,"name":"zend-expressive-skeleton","full_name":"zendframework/zend-expressive-skeleton","owner":{"login":"zendframework","id":296074,"avatar_url":"https://avatars.githubusercontent.com/u/296074?v=3","gravatar_id":"","url":"https://api.github.com/users/zendframework","html_url":"https://github.com/zendframework","followers_url":"https://api.github.com/users/zendframework/followers","following_url":"https://api.github.com/users/zendframework/following{/other_user}","gists_url":"https://api.github.com/users/zendframework/gists{/gist_id}","starred_url":"https://api.github.com/users/zendframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendframework/subscriptions","organizations_url":"https://api.github.com/users/zendframework/orgs","repos_url":"https://api.github.com/users/zendframework/repos","events_url":"https://api.github.com/users/zendframework/events{/privacy}","received_events_url":"https://api.github.com/users/zendframework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zendframework/zend-expressive-skeleton","description":"Begin developing PSR-7 middleware applications in seconds!","fork":true,"url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton","forks_url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/forks","keys_url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/teams","hooks_url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/hooks","issue_events_url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/issues/events{/number}","events_url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/events","assignees_url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/assignees{/user}","branches_url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/branches{/branch}","tags_url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/tags","blobs_url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/git/refs{/sha}","trees_url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/statuses/{sha}","languages_url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/languages","stargazers_url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/stargazers","contributors_url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/contributors","subscribers_url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/subscribers","subscription_url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/subscription","commits_url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/commits{/sha}","git_commits_url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/git/commits{/sha}","comments_url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/comments{/number}","issue_comment_url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/issues/comments{/number}","contents_url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/contents/{+path}","compare_url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/merges","archive_url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/downloads","issues_url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/issues{/number}","pulls_url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/pulls{/number}","milestones_url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/milestones{/number}","notifications_url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/labels{/name}","releases_url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/releases{/id}","deployments_url":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/deployments","created_at":"2015-10-09T21:10:08Z","updated_at":"2017-01-17T18:14:36Z","pushed_at":"2017-01-17T20:27:30Z","git_url":"git://github.com/zendframework/zend-expressive-skeleton.git","ssh_url":"git@github.com:zendframework/zend-expressive-skeleton.git","clone_url":"https://github.com/zendframework/zend-expressive-skeleton.git","svn_url":"https://github.com/zendframework/zend-expressive-skeleton","homepage":"","size":514,"stargazers_count":70,"watchers_count":70,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":56,"mirror_url":null,"open_issues_count":1,"forks":56,"open_issues":1,"watchers":70,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/pulls/124"},"html":{"href":"https://github.com/zendframework/zend-expressive-skeleton/pull/124"},"issue":{"href":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/issues/124"},"comments":{"href":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/issues/124/comments"},"review_comments":{"href":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/pulls/124/comments"},"review_comment":{"href":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/pulls/124/commits"},"statuses":{"href":"https://api.github.com/repos/zendframework/zend-expressive-skeleton/statuses/1cb26ddff964a974b786e398dc0945c01a3f3281"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"weierophinney","id":25943,"avatar_url":"https://avatars.githubusercontent.com/u/25943?v=3","gravatar_id":"","url":"https://api.github.com/users/weierophinney","html_url":"https://github.com/weierophinney","followers_url":"https://api.github.com/users/weierophinney/followers","following_url":"https://api.github.com/users/weierophinney/following{/other_user}","gists_url":"https://api.github.com/users/weierophinney/gists{/gist_id}","starred_url":"https://api.github.com/users/weierophinney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weierophinney/subscriptions","organizations_url":"https://api.github.com/users/weierophinney/orgs","repos_url":"https://api.github.com/users/weierophinney/repos","events_url":"https://api.github.com/users/weierophinney/events{/privacy}","received_events_url":"https://api.github.com/users/weierophinney/received_events","type":"User","site_admin":false},"comments":4,"review_comments":13,"maintainer_can_modify":false,"commits":8,"additions":686,"deletions":210,"changed_files":22}}
{"actor":{"display_login":"weierophinney"}}