{"action":"created","issue":{"url":"https://api.github.com/repos/zooniverse/Panoptes-Front-End/issues/3976","repository_url":"https://api.github.com/repos/zooniverse/Panoptes-Front-End","labels_url":"https://api.github.com/repos/zooniverse/Panoptes-Front-End/issues/3976/labels{/name}","comments_url":"https://api.github.com/repos/zooniverse/Panoptes-Front-End/issues/3976/comments","events_url":"https://api.github.com/repos/zooniverse/Panoptes-Front-End/issues/3976/events","html_url":"https://github.com/zooniverse/Panoptes-Front-End/pull/3976","id":247692817,"number":3976,"title":"Allow to unsubscribe for older browser users","user":{"login":"simoneduca","id":8989606,"avatar_url":"https://avatars1.githubusercontent.com/u/8989606?v=4","gravatar_id":"","url":"https://api.github.com/users/simoneduca","html_url":"https://github.com/simoneduca","followers_url":"https://api.github.com/users/simoneduca/followers","following_url":"https://api.github.com/users/simoneduca/following{/other_user}","gists_url":"https://api.github.com/users/simoneduca/gists{/gist_id}","starred_url":"https://api.github.com/users/simoneduca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simoneduca/subscriptions","organizations_url":"https://api.github.com/users/simoneduca/orgs","repos_url":"https://api.github.com/users/simoneduca/repos","events_url":"https://api.github.com/users/simoneduca/events{/privacy}","received_events_url":"https://api.github.com/users/simoneduca/received_events","type":"User","site_admin":false},"labels":[{"id":643936186,"url":"https://api.github.com/repos/zooniverse/Panoptes-Front-End/labels/Work%20In%20Progress","name":"Work In Progress","color":"760205","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2017-08-03T12:39:20Z","updated_at":"2017-08-03T15:48:36Z","closed_at":"2017-08-03T15:47:05Z","pull_request":{"url":"https://api.github.com/repos/zooniverse/Panoptes-Front-End/pulls/3976","html_url":"https://github.com/zooniverse/Panoptes-Front-End/pull/3976","diff_url":"https://github.com/zooniverse/Panoptes-Front-End/pull/3976.diff","patch_url":"https://github.com/zooniverse/Panoptes-Front-End/pull/3976.patch"},"body":"Fixes #3969.\r\n\r\nhttps://fix-unsubscribe.pfe-preview.zooniverse.org/unsubscribe\r\n\r\nDescribe your changes.\r\n- Rewrite component in JS\r\n- Default `checkValidity()` to true when `undefined` to support older browsers.\r\n\r\n**Note**: I've tried to reproduce the original functionality as close as possible.\r\nHowever, does anyone know if url `/unsubscribe?email=something` is ever returned by the server? If not, I can get rid of more code.\r\n\r\n\r\n# Review Checklist\r\n- [x] Does it work in all major browsers: Firefox, Chrome, Edge, Safari?\r\n- [ ] Does it work on mobile?\r\n- [x] Can you `rm -rf node_modules/ && npm install` and app works as expected?\r\n- [x] Did you deploy a staging branch?\r\n- [ ] Did you get any type checking errors from [Babel Typecheck](https://github.com/codemix/babel-plugin-typecheck)\r\n\r\n\r\n## Optional\r\n- [x] If it's a new component, is it in ES6? Is it clear of warnings from ESLint?\r\n- [ ] Have you replaced any `ChangeListener` or `PromiseRenderer` components with code that updates component state?\r\n- [ ] If changes are made to the classifier, does the dev classifier still work?\r\n- [ ] Have you added in [flow type annotations](https://flowtype.org/docs/type-annotations.html)?\r\n- [ ] Have you followed the [Springer guidelines for commit messages](https://github.com/springernature/frontend-playbook/blob/master/git/git.md#commit-messages)?"},"comment":{"url":"https://api.github.com/repos/zooniverse/Panoptes-Front-End/issues/comments/320009759","html_url":"https://github.com/zooniverse/Panoptes-Front-End/pull/3976#issuecomment-320009759","issue_url":"https://api.github.com/repos/zooniverse/Panoptes-Front-End/issues/3976","id":320009759,"user":{"login":"simoneduca","id":8989606,"avatar_url":"https://avatars1.githubusercontent.com/u/8989606?v=4","gravatar_id":"","url":"https://api.github.com/users/simoneduca","html_url":"https://github.com/simoneduca","followers_url":"https://api.github.com/users/simoneduca/followers","following_url":"https://api.github.com/users/simoneduca/following{/other_user}","gists_url":"https://api.github.com/users/simoneduca/gists{/gist_id}","starred_url":"https://api.github.com/users/simoneduca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simoneduca/subscriptions","organizations_url":"https://api.github.com/users/simoneduca/orgs","repos_url":"https://api.github.com/users/simoneduca/repos","events_url":"https://api.github.com/users/simoneduca/events{/privacy}","received_events_url":"https://api.github.com/users/simoneduca/received_events","type":"User","site_admin":false},"created_at":"2017-08-03T15:48:36Z","updated_at":"2017-08-03T15:48:36Z","body":"I would have liked to write a test for the page, before merging but I can do that in separate PR."}}
{"actor":{"display_login":"simoneduca"}}