{"action":"created","issue":{"url":"https://api.github.com/repos/chaijs/chai/issues/900","repository_url":"https://api.github.com/repos/chaijs/chai","labels_url":"https://api.github.com/repos/chaijs/chai/issues/900/labels{/name}","comments_url":"https://api.github.com/repos/chaijs/chai/issues/900/comments","events_url":"https://api.github.com/repos/chaijs/chai/issues/900/events","html_url":"https://github.com/chaijs/chai/pull/900","id":200229866,"number":900,"title":"Refactor `utils.addChainableMethod` helper","user":{"login":"shvaikalesh","id":5098878,"avatar_url":"https://avatars.githubusercontent.com/u/5098878?v=3","gravatar_id":"","url":"https://api.github.com/users/shvaikalesh","html_url":"https://github.com/shvaikalesh","followers_url":"https://api.github.com/users/shvaikalesh/followers","following_url":"https://api.github.com/users/shvaikalesh/following{/other_user}","gists_url":"https://api.github.com/users/shvaikalesh/gists{/gist_id}","starred_url":"https://api.github.com/users/shvaikalesh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shvaikalesh/subscriptions","organizations_url":"https://api.github.com/users/shvaikalesh/orgs","repos_url":"https://api.github.com/users/shvaikalesh/repos","events_url":"https://api.github.com/users/shvaikalesh/events{/privacy}","received_events_url":"https://api.github.com/users/shvaikalesh/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-01-11T22:44:38Z","updated_at":"2017-01-11T22:52:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/chaijs/chai/pulls/900","html_url":"https://github.com/chaijs/chai/pull/900","diff_url":"https://github.com/chaijs/chai/pull/900.diff","patch_url":"https://github.com/chaijs/chai/pull/900.patch"},"body":"### Use `Object.setPrototypeOf` instead of `__proto__`\r\n\r\n* `Object.setPrototypeOf` is more strict than `__proto__`: it throws on failure instead of being silent.\r\n* `__proto__` is in Annex B of the spec; using it is kinda discouraged.\r\n\r\n> This annex describes various legacy features and other characteristics of web browser based ECMAScript implementations. All of the language features and behaviours specified in this annex have one or more undesirable characteristics and in the absence of legacy usage would be removed from this specification. \r\n\r\n* I would avoid relying on early implementations of `__proto__` (before it was defined on `Object.prototype`) .\r\n* `Object.setPrototypeOf` reads better :smile:.\r\n* Every browser we support, has either both `__proto__` and `Object.setPrototypeOf` or neither of them.\r\n\r\nWhen we drop IE < 11, we would simplify `addChainableMethod` even more.\r\n\r\n### Remove hardcoded non-configurable function keys\r\n\r\nThey used to cause troubles in ancient IEs, but work fine in IE."},"comment":{"url":"https://api.github.com/repos/chaijs/chai/issues/comments/272021591","html_url":"https://github.com/chaijs/chai/pull/900#issuecomment-272021591","issue_url":"https://api.github.com/repos/chaijs/chai/issues/900","id":272021591,"user":{"login":"meeber","id":17260989,"avatar_url":"https://avatars.githubusercontent.com/u/17260989?v=3","gravatar_id":"","url":"https://api.github.com/users/meeber","html_url":"https://github.com/meeber","followers_url":"https://api.github.com/users/meeber/followers","following_url":"https://api.github.com/users/meeber/following{/other_user}","gists_url":"https://api.github.com/users/meeber/gists{/gist_id}","starred_url":"https://api.github.com/users/meeber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meeber/subscriptions","organizations_url":"https://api.github.com/users/meeber/orgs","repos_url":"https://api.github.com/users/meeber/repos","events_url":"https://api.github.com/users/meeber/events{/privacy}","received_events_url":"https://api.github.com/users/meeber/received_events","type":"User","site_admin":false},"created_at":"2017-01-11T22:52:45Z","updated_at":"2017-01-11T22:52:45Z","body":"LGTM"}}
{"actor":{"display_login":"meeber"}}