{"action":"created","comment":{"url":"https://api.github.com/repos/pyca/cryptography/pulls/comments/97390914","pull_request_review_id":17998749,"id":97390914,"diff_hunk":"@@ -48,8 +41,7 @@ def _key_identifier_from_public_key(public_key):\n             serialization.PublicFormat.SubjectPublicKeyInfo\n         )\n \n-        spki = _SubjectPublicKeyInfo.load(serialized)\n-        data = spki[\"subjectPublicKey\"].cast(OctetBitString).native\n+        data = six.binary_type(PublicKeyInfo.load(serialized)['public_key'])","path":"src/cryptography/x509/extensions.py","position":null,"original_position":29,"commit_id":"0c2254b8c6277dc85dbf78bcd653917a07a1ce36","original_commit_id":"0c2254b8c6277dc85dbf78bcd653917a07a1ce36","user":{"login":"ofek","id":9677399,"avatar_url":"https://avatars.githubusercontent.com/u/9677399?v=3","gravatar_id":"","url":"https://api.github.com/users/ofek","html_url":"https://github.com/ofek","followers_url":"https://api.github.com/users/ofek/followers","following_url":"https://api.github.com/users/ofek/following{/other_user}","gists_url":"https://api.github.com/users/ofek/gists{/gist_id}","starred_url":"https://api.github.com/users/ofek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofek/subscriptions","organizations_url":"https://api.github.com/users/ofek/orgs","repos_url":"https://api.github.com/users/ofek/repos","events_url":"https://api.github.com/users/ofek/events{/privacy}","received_events_url":"https://api.github.com/users/ofek/received_events","type":"User","site_admin":false},"body":"it's part of a branch. 3 returns looks ugly imo","created_at":"2017-01-23T19:03:41Z","updated_at":"2017-01-23T19:03:41Z","html_url":"https://github.com/pyca/cryptography/pull/3361#discussion_r97390914","pull_request_url":"https://api.github.com/repos/pyca/cryptography/pulls/3361","_links":{"self":{"href":"https://api.github.com/repos/pyca/cryptography/pulls/comments/97390914"},"html":{"href":"https://github.com/pyca/cryptography/pull/3361#discussion_r97390914"},"pull_request":{"href":"https://api.github.com/repos/pyca/cryptography/pulls/3361"}}},"pull_request":{"url":"https://api.github.com/repos/pyca/cryptography/pulls/3361","id":102603282,"html_url":"https://github.com/pyca/cryptography/pull/3361","diff_url":"https://github.com/pyca/cryptography/pull/3361.diff","patch_url":"https://github.com/pyca/cryptography/pull/3361.patch","issue_url":"https://api.github.com/repos/pyca/cryptography/issues/3361","number":3361,"state":"open","locked":false,"title":"ASN.1 update","user":{"login":"ofek","id":9677399,"avatar_url":"https://avatars.githubusercontent.com/u/9677399?v=3","gravatar_id":"","url":"https://api.github.com/users/ofek","html_url":"https://github.com/ofek","followers_url":"https://api.github.com/users/ofek/followers","following_url":"https://api.github.com/users/ofek/following{/other_user}","gists_url":"https://api.github.com/users/ofek/gists{/gist_id}","starred_url":"https://api.github.com/users/ofek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofek/subscriptions","organizations_url":"https://api.github.com/users/ofek/orgs","repos_url":"https://api.github.com/users/ofek/repos","events_url":"https://api.github.com/users/ofek/events{/privacy}","received_events_url":"https://api.github.com/users/ofek/received_events","type":"User","site_admin":false},"body":"I have replaced pyasn1 with @wbond's excellent  [asn1crypto](https://github.com/wbond/asn1crypto). This results in a non-trivial performance increase (4x based on decoding tests), better extensibility in future, and the removal of our pyasn1_modules test dependency.\r\n\r\nAlso, trailing bytes are now accepted because they cause no ill side-effects and are used by a number of protocols:\r\n\r\n[X.509 version numbers](https://golang.org/src/encoding/asn1/asn1.go#L861)\r\n[Bitcoin signature hash-type](https://github.com/bitcoin/bips/blob/master/bip-0062.mediawiki#DER_encoding)","created_at":"2017-01-22T01:35:04Z","updated_at":"2017-01-23T19:03:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"46f7e78468e39bf5507dc466f842bdd18005c743","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/pyca/cryptography/pulls/3361/commits","review_comments_url":"https://api.github.com/repos/pyca/cryptography/pulls/3361/comments","review_comment_url":"https://api.github.com/repos/pyca/cryptography/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pyca/cryptography/issues/3361/comments","statuses_url":"https://api.github.com/repos/pyca/cryptography/statuses/0c2254b8c6277dc85dbf78bcd653917a07a1ce36","head":{"label":"ofek:replace-pyasn1","ref":"replace-pyasn1","sha":"0c2254b8c6277dc85dbf78bcd653917a07a1ce36","user":{"login":"ofek","id":9677399,"avatar_url":"https://avatars.githubusercontent.com/u/9677399?v=3","gravatar_id":"","url":"https://api.github.com/users/ofek","html_url":"https://github.com/ofek","followers_url":"https://api.github.com/users/ofek/followers","following_url":"https://api.github.com/users/ofek/following{/other_user}","gists_url":"https://api.github.com/users/ofek/gists{/gist_id}","starred_url":"https://api.github.com/users/ofek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofek/subscriptions","organizations_url":"https://api.github.com/users/ofek/orgs","repos_url":"https://api.github.com/users/ofek/repos","events_url":"https://api.github.com/users/ofek/events{/privacy}","received_events_url":"https://api.github.com/users/ofek/received_events","type":"User","site_admin":false},"repo":{"id":79623529,"name":"cryptography","full_name":"ofek/cryptography","owner":{"login":"ofek","id":9677399,"avatar_url":"https://avatars.githubusercontent.com/u/9677399?v=3","gravatar_id":"","url":"https://api.github.com/users/ofek","html_url":"https://github.com/ofek","followers_url":"https://api.github.com/users/ofek/followers","following_url":"https://api.github.com/users/ofek/following{/other_user}","gists_url":"https://api.github.com/users/ofek/gists{/gist_id}","starred_url":"https://api.github.com/users/ofek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofek/subscriptions","organizations_url":"https://api.github.com/users/ofek/orgs","repos_url":"https://api.github.com/users/ofek/repos","events_url":"https://api.github.com/users/ofek/events{/privacy}","received_events_url":"https://api.github.com/users/ofek/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ofek/cryptography","description":"cryptography is a package designed to expose cryptographic primitives and recipes to Python developers.","fork":true,"url":"https://api.github.com/repos/ofek/cryptography","forks_url":"https://api.github.com/repos/ofek/cryptography/forks","keys_url":"https://api.github.com/repos/ofek/cryptography/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ofek/cryptography/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ofek/cryptography/teams","hooks_url":"https://api.github.com/repos/ofek/cryptography/hooks","issue_events_url":"https://api.github.com/repos/ofek/cryptography/issues/events{/number}","events_url":"https://api.github.com/repos/ofek/cryptography/events","assignees_url":"https://api.github.com/repos/ofek/cryptography/assignees{/user}","branches_url":"https://api.github.com/repos/ofek/cryptography/branches{/branch}","tags_url":"https://api.github.com/repos/ofek/cryptography/tags","blobs_url":"https://api.github.com/repos/ofek/cryptography/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ofek/cryptography/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ofek/cryptography/git/refs{/sha}","trees_url":"https://api.github.com/repos/ofek/cryptography/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ofek/cryptography/statuses/{sha}","languages_url":"https://api.github.com/repos/ofek/cryptography/languages","stargazers_url":"https://api.github.com/repos/ofek/cryptography/stargazers","contributors_url":"https://api.github.com/repos/ofek/cryptography/contributors","subscribers_url":"https://api.github.com/repos/ofek/cryptography/subscribers","subscription_url":"https://api.github.com/repos/ofek/cryptography/subscription","commits_url":"https://api.github.com/repos/ofek/cryptography/commits{/sha}","git_commits_url":"https://api.github.com/repos/ofek/cryptography/git/commits{/sha}","comments_url":"https://api.github.com/repos/ofek/cryptography/comments{/number}","issue_comment_url":"https://api.github.com/repos/ofek/cryptography/issues/comments{/number}","contents_url":"https://api.github.com/repos/ofek/cryptography/contents/{+path}","compare_url":"https://api.github.com/repos/ofek/cryptography/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ofek/cryptography/merges","archive_url":"https://api.github.com/repos/ofek/cryptography/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ofek/cryptography/downloads","issues_url":"https://api.github.com/repos/ofek/cryptography/issues{/number}","pulls_url":"https://api.github.com/repos/ofek/cryptography/pulls{/number}","milestones_url":"https://api.github.com/repos/ofek/cryptography/milestones{/number}","notifications_url":"https://api.github.com/repos/ofek/cryptography/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ofek/cryptography/labels{/name}","releases_url":"https://api.github.com/repos/ofek/cryptography/releases{/id}","deployments_url":"https://api.github.com/repos/ofek/cryptography/deployments","created_at":"2017-01-21T04:28:16Z","updated_at":"2017-01-21T04:28:25Z","pushed_at":"2017-01-23T18:53:24Z","git_url":"git://github.com/ofek/cryptography.git","ssh_url":"git@github.com:ofek/cryptography.git","clone_url":"https://github.com/ofek/cryptography.git","svn_url":"https://github.com/ofek/cryptography","homepage":"https://cryptography.io/","size":34570,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pyca:master","ref":"master","sha":"d0c69837d2ede877ca5a2e3b74f5b4c09073b503","user":{"login":"pyca","id":5615737,"avatar_url":"https://avatars.githubusercontent.com/u/5615737?v=3","gravatar_id":"","url":"https://api.github.com/users/pyca","html_url":"https://github.com/pyca","followers_url":"https://api.github.com/users/pyca/followers","following_url":"https://api.github.com/users/pyca/following{/other_user}","gists_url":"https://api.github.com/users/pyca/gists{/gist_id}","starred_url":"https://api.github.com/users/pyca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pyca/subscriptions","organizations_url":"https://api.github.com/users/pyca/orgs","repos_url":"https://api.github.com/users/pyca/repos","events_url":"https://api.github.com/users/pyca/events{/privacy}","received_events_url":"https://api.github.com/users/pyca/received_events","type":"Organization","site_admin":false},"repo":{"id":11939484,"name":"cryptography","full_name":"pyca/cryptography","owner":{"login":"pyca","id":5615737,"avatar_url":"https://avatars.githubusercontent.com/u/5615737?v=3","gravatar_id":"","url":"https://api.github.com/users/pyca","html_url":"https://github.com/pyca","followers_url":"https://api.github.com/users/pyca/followers","following_url":"https://api.github.com/users/pyca/following{/other_user}","gists_url":"https://api.github.com/users/pyca/gists{/gist_id}","starred_url":"https://api.github.com/users/pyca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pyca/subscriptions","organizations_url":"https://api.github.com/users/pyca/orgs","repos_url":"https://api.github.com/users/pyca/repos","events_url":"https://api.github.com/users/pyca/events{/privacy}","received_events_url":"https://api.github.com/users/pyca/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pyca/cryptography","description":"cryptography is a package designed to expose cryptographic primitives and recipes to Python developers.","fork":false,"url":"https://api.github.com/repos/pyca/cryptography","forks_url":"https://api.github.com/repos/pyca/cryptography/forks","keys_url":"https://api.github.com/repos/pyca/cryptography/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pyca/cryptography/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pyca/cryptography/teams","hooks_url":"https://api.github.com/repos/pyca/cryptography/hooks","issue_events_url":"https://api.github.com/repos/pyca/cryptography/issues/events{/number}","events_url":"https://api.github.com/repos/pyca/cryptography/events","assignees_url":"https://api.github.com/repos/pyca/cryptography/assignees{/user}","branches_url":"https://api.github.com/repos/pyca/cryptography/branches{/branch}","tags_url":"https://api.github.com/repos/pyca/cryptography/tags","blobs_url":"https://api.github.com/repos/pyca/cryptography/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pyca/cryptography/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pyca/cryptography/git/refs{/sha}","trees_url":"https://api.github.com/repos/pyca/cryptography/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pyca/cryptography/statuses/{sha}","languages_url":"https://api.github.com/repos/pyca/cryptography/languages","stargazers_url":"https://api.github.com/repos/pyca/cryptography/stargazers","contributors_url":"https://api.github.com/repos/pyca/cryptography/contributors","subscribers_url":"https://api.github.com/repos/pyca/cryptography/subscribers","subscription_url":"https://api.github.com/repos/pyca/cryptography/subscription","commits_url":"https://api.github.com/repos/pyca/cryptography/commits{/sha}","git_commits_url":"https://api.github.com/repos/pyca/cryptography/git/commits{/sha}","comments_url":"https://api.github.com/repos/pyca/cryptography/comments{/number}","issue_comment_url":"https://api.github.com/repos/pyca/cryptography/issues/comments{/number}","contents_url":"https://api.github.com/repos/pyca/cryptography/contents/{+path}","compare_url":"https://api.github.com/repos/pyca/cryptography/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pyca/cryptography/merges","archive_url":"https://api.github.com/repos/pyca/cryptography/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pyca/cryptography/downloads","issues_url":"https://api.github.com/repos/pyca/cryptography/issues{/number}","pulls_url":"https://api.github.com/repos/pyca/cryptography/pulls{/number}","milestones_url":"https://api.github.com/repos/pyca/cryptography/milestones{/number}","notifications_url":"https://api.github.com/repos/pyca/cryptography/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pyca/cryptography/labels{/name}","releases_url":"https://api.github.com/repos/pyca/cryptography/releases{/id}","deployments_url":"https://api.github.com/repos/pyca/cryptography/deployments","created_at":"2013-08-07T02:23:38Z","updated_at":"2017-01-23T04:45:04Z","pushed_at":"2017-01-23T18:53:26Z","git_url":"git://github.com/pyca/cryptography.git","ssh_url":"git@github.com:pyca/cryptography.git","clone_url":"https://github.com/pyca/cryptography.git","svn_url":"https://github.com/pyca/cryptography","homepage":"https://cryptography.io/","size":34628,"stargazers_count":1318,"watchers_count":1318,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":332,"mirror_url":null,"open_issues_count":78,"forks":332,"open_issues":78,"watchers":1318,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pyca/cryptography/pulls/3361"},"html":{"href":"https://github.com/pyca/cryptography/pull/3361"},"issue":{"href":"https://api.github.com/repos/pyca/cryptography/issues/3361"},"comments":{"href":"https://api.github.com/repos/pyca/cryptography/issues/3361/comments"},"review_comments":{"href":"https://api.github.com/repos/pyca/cryptography/pulls/3361/comments"},"review_comment":{"href":"https://api.github.com/repos/pyca/cryptography/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pyca/cryptography/pulls/3361/commits"},"statuses":{"href":"https://api.github.com/repos/pyca/cryptography/statuses/0c2254b8c6277dc85dbf78bcd653917a07a1ce36"}}}}
{"actor":{"display_login":"ofek"}}