{"action":"opened","number":1788,"pull_request":{"url":"https://api.github.com/repos/d-ronin/dRonin/pulls/1788","id":122659922,"html_url":"https://github.com/d-ronin/dRonin/pull/1788","diff_url":"https://github.com/d-ronin/dRonin/pull/1788.diff","patch_url":"https://github.com/d-ronin/dRonin/pull/1788.patch","issue_url":"https://api.github.com/repos/d-ronin/dRonin/issues/1788","number":1788,"state":"open","locked":false,"title":"Stop the ADC from inducing jitters.","user":{"login":"glowtape","id":4010813,"avatar_url":"https://avatars3.githubusercontent.com/u/4010813?v=3","gravatar_id":"","url":"https://api.github.com/users/glowtape","html_url":"https://github.com/glowtape","followers_url":"https://api.github.com/users/glowtape/followers","following_url":"https://api.github.com/users/glowtape/following{/other_user}","gists_url":"https://api.github.com/users/glowtape/gists{/gist_id}","starred_url":"https://api.github.com/users/glowtape/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glowtape/subscriptions","organizations_url":"https://api.github.com/users/glowtape/orgs","repos_url":"https://api.github.com/users/glowtape/repos","events_url":"https://api.github.com/users/glowtape/events{/privacy}","received_events_url":"https://api.github.com/users/glowtape/received_events","type":"User","site_admin":false},"body":"Essentially this was an issue I, and probably everyone else running at least the Seppuku, had likely since the beginning:\r\n\r\n![sds1202x-e13](https://cloud.githubusercontent.com/assets/4010813/26499651/b2c0a7e0-4233-11e7-855b-1101d82d9e95.png)\r\n\r\nEvery 200-300ms the servo output signal jitters like this. Turns out it was the ADC IRQ handler doing this and making the system have a ball. Sticking the (missing?) ChibiOS IRQ pro- and epilogue stuff (which also does some thread rescheduling from what I've seen) into the IRQ handler of the ADC mitigates the issue.\r\n\r\nSo as a precaution, I've also stuck it in the PIOS DMA IRQ handlers on F3.","created_at":"2017-05-26T14:56:16Z","updated_at":"2017-05-26T14:56:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/d-ronin/dRonin/pulls/1788/commits","review_comments_url":"https://api.github.com/repos/d-ronin/dRonin/pulls/1788/comments","review_comment_url":"https://api.github.com/repos/d-ronin/dRonin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/d-ronin/dRonin/issues/1788/comments","statuses_url":"https://api.github.com/repos/d-ronin/dRonin/statuses/ebc6416cb35b02b750ea5f2cee93905e2107d56f","head":{"label":"glowtape:glowtape-zejitters","ref":"glowtape-zejitters","sha":"ebc6416cb35b02b750ea5f2cee93905e2107d56f","user":{"login":"glowtape","id":4010813,"avatar_url":"https://avatars3.githubusercontent.com/u/4010813?v=3","gravatar_id":"","url":"https://api.github.com/users/glowtape","html_url":"https://github.com/glowtape","followers_url":"https://api.github.com/users/glowtape/followers","following_url":"https://api.github.com/users/glowtape/following{/other_user}","gists_url":"https://api.github.com/users/glowtape/gists{/gist_id}","starred_url":"https://api.github.com/users/glowtape/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glowtape/subscriptions","organizations_url":"https://api.github.com/users/glowtape/orgs","repos_url":"https://api.github.com/users/glowtape/repos","events_url":"https://api.github.com/users/glowtape/events{/privacy}","received_events_url":"https://api.github.com/users/glowtape/received_events","type":"User","site_admin":false},"repo":{"id":64550362,"name":"dRonin","full_name":"glowtape/dRonin","owner":{"login":"glowtape","id":4010813,"avatar_url":"https://avatars3.githubusercontent.com/u/4010813?v=3","gravatar_id":"","url":"https://api.github.com/users/glowtape","html_url":"https://github.com/glowtape","followers_url":"https://api.github.com/users/glowtape/followers","following_url":"https://api.github.com/users/glowtape/following{/other_user}","gists_url":"https://api.github.com/users/glowtape/gists{/gist_id}","starred_url":"https://api.github.com/users/glowtape/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glowtape/subscriptions","organizations_url":"https://api.github.com/users/glowtape/orgs","repos_url":"https://api.github.com/users/glowtape/repos","events_url":"https://api.github.com/users/glowtape/events{/privacy}","received_events_url":"https://api.github.com/users/glowtape/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/glowtape/dRonin","description":"The dRonin flight controller software.","fork":true,"url":"https://api.github.com/repos/glowtape/dRonin","forks_url":"https://api.github.com/repos/glowtape/dRonin/forks","keys_url":"https://api.github.com/repos/glowtape/dRonin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/glowtape/dRonin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/glowtape/dRonin/teams","hooks_url":"https://api.github.com/repos/glowtape/dRonin/hooks","issue_events_url":"https://api.github.com/repos/glowtape/dRonin/issues/events{/number}","events_url":"https://api.github.com/repos/glowtape/dRonin/events","assignees_url":"https://api.github.com/repos/glowtape/dRonin/assignees{/user}","branches_url":"https://api.github.com/repos/glowtape/dRonin/branches{/branch}","tags_url":"https://api.github.com/repos/glowtape/dRonin/tags","blobs_url":"https://api.github.com/repos/glowtape/dRonin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/glowtape/dRonin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/glowtape/dRonin/git/refs{/sha}","trees_url":"https://api.github.com/repos/glowtape/dRonin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/glowtape/dRonin/statuses/{sha}","languages_url":"https://api.github.com/repos/glowtape/dRonin/languages","stargazers_url":"https://api.github.com/repos/glowtape/dRonin/stargazers","contributors_url":"https://api.github.com/repos/glowtape/dRonin/contributors","subscribers_url":"https://api.github.com/repos/glowtape/dRonin/subscribers","subscription_url":"https://api.github.com/repos/glowtape/dRonin/subscription","commits_url":"https://api.github.com/repos/glowtape/dRonin/commits{/sha}","git_commits_url":"https://api.github.com/repos/glowtape/dRonin/git/commits{/sha}","comments_url":"https://api.github.com/repos/glowtape/dRonin/comments{/number}","issue_comment_url":"https://api.github.com/repos/glowtape/dRonin/issues/comments{/number}","contents_url":"https://api.github.com/repos/glowtape/dRonin/contents/{+path}","compare_url":"https://api.github.com/repos/glowtape/dRonin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/glowtape/dRonin/merges","archive_url":"https://api.github.com/repos/glowtape/dRonin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/glowtape/dRonin/downloads","issues_url":"https://api.github.com/repos/glowtape/dRonin/issues{/number}","pulls_url":"https://api.github.com/repos/glowtape/dRonin/pulls{/number}","milestones_url":"https://api.github.com/repos/glowtape/dRonin/milestones{/number}","notifications_url":"https://api.github.com/repos/glowtape/dRonin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/glowtape/dRonin/labels{/name}","releases_url":"https://api.github.com/repos/glowtape/dRonin/releases{/id}","deployments_url":"https://api.github.com/repos/glowtape/dRonin/deployments","created_at":"2016-07-30T15:22:56Z","updated_at":"2016-07-30T15:23:21Z","pushed_at":"2017-05-26T14:51:17Z","git_url":"git://github.com/glowtape/dRonin.git","ssh_url":"git@github.com:glowtape/dRonin.git","clone_url":"https://github.com/glowtape/dRonin.git","svn_url":"https://github.com/glowtape/dRonin","homepage":"http://dronin.org","size":252563,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"next"}},"base":{"label":"d-ronin:next","ref":"next","sha":"da352cc9b8d21549d43c764da7ebdcc88b869dc8","user":{"login":"d-ronin","id":14959302,"avatar_url":"https://avatars1.githubusercontent.com/u/14959302?v=3","gravatar_id":"","url":"https://api.github.com/users/d-ronin","html_url":"https://github.com/d-ronin","followers_url":"https://api.github.com/users/d-ronin/followers","following_url":"https://api.github.com/users/d-ronin/following{/other_user}","gists_url":"https://api.github.com/users/d-ronin/gists{/gist_id}","starred_url":"https://api.github.com/users/d-ronin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d-ronin/subscriptions","organizations_url":"https://api.github.com/users/d-ronin/orgs","repos_url":"https://api.github.com/users/d-ronin/repos","events_url":"https://api.github.com/users/d-ronin/events{/privacy}","received_events_url":"https://api.github.com/users/d-ronin/received_events","type":"Organization","site_admin":false},"repo":{"id":43620723,"name":"dRonin","full_name":"d-ronin/dRonin","owner":{"login":"d-ronin","id":14959302,"avatar_url":"https://avatars1.githubusercontent.com/u/14959302?v=3","gravatar_id":"","url":"https://api.github.com/users/d-ronin","html_url":"https://github.com/d-ronin","followers_url":"https://api.github.com/users/d-ronin/followers","following_url":"https://api.github.com/users/d-ronin/following{/other_user}","gists_url":"https://api.github.com/users/d-ronin/gists{/gist_id}","starred_url":"https://api.github.com/users/d-ronin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d-ronin/subscriptions","organizations_url":"https://api.github.com/users/d-ronin/orgs","repos_url":"https://api.github.com/users/d-ronin/repos","events_url":"https://api.github.com/users/d-ronin/events{/privacy}","received_events_url":"https://api.github.com/users/d-ronin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/d-ronin/dRonin","description":"The dRonin flight controller software.","fork":false,"url":"https://api.github.com/repos/d-ronin/dRonin","forks_url":"https://api.github.com/repos/d-ronin/dRonin/forks","keys_url":"https://api.github.com/repos/d-ronin/dRonin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/d-ronin/dRonin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/d-ronin/dRonin/teams","hooks_url":"https://api.github.com/repos/d-ronin/dRonin/hooks","issue_events_url":"https://api.github.com/repos/d-ronin/dRonin/issues/events{/number}","events_url":"https://api.github.com/repos/d-ronin/dRonin/events","assignees_url":"https://api.github.com/repos/d-ronin/dRonin/assignees{/user}","branches_url":"https://api.github.com/repos/d-ronin/dRonin/branches{/branch}","tags_url":"https://api.github.com/repos/d-ronin/dRonin/tags","blobs_url":"https://api.github.com/repos/d-ronin/dRonin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/d-ronin/dRonin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/d-ronin/dRonin/git/refs{/sha}","trees_url":"https://api.github.com/repos/d-ronin/dRonin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/d-ronin/dRonin/statuses/{sha}","languages_url":"https://api.github.com/repos/d-ronin/dRonin/languages","stargazers_url":"https://api.github.com/repos/d-ronin/dRonin/stargazers","contributors_url":"https://api.github.com/repos/d-ronin/dRonin/contributors","subscribers_url":"https://api.github.com/repos/d-ronin/dRonin/subscribers","subscription_url":"https://api.github.com/repos/d-ronin/dRonin/subscription","commits_url":"https://api.github.com/repos/d-ronin/dRonin/commits{/sha}","git_commits_url":"https://api.github.com/repos/d-ronin/dRonin/git/commits{/sha}","comments_url":"https://api.github.com/repos/d-ronin/dRonin/comments{/number}","issue_comment_url":"https://api.github.com/repos/d-ronin/dRonin/issues/comments{/number}","contents_url":"https://api.github.com/repos/d-ronin/dRonin/contents/{+path}","compare_url":"https://api.github.com/repos/d-ronin/dRonin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/d-ronin/dRonin/merges","archive_url":"https://api.github.com/repos/d-ronin/dRonin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/d-ronin/dRonin/downloads","issues_url":"https://api.github.com/repos/d-ronin/dRonin/issues{/number}","pulls_url":"https://api.github.com/repos/d-ronin/dRonin/pulls{/number}","milestones_url":"https://api.github.com/repos/d-ronin/dRonin/milestones{/number}","notifications_url":"https://api.github.com/repos/d-ronin/dRonin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/d-ronin/dRonin/labels{/name}","releases_url":"https://api.github.com/repos/d-ronin/dRonin/releases{/id}","deployments_url":"https://api.github.com/repos/d-ronin/dRonin/deployments","created_at":"2015-10-04T01:13:04Z","updated_at":"2017-05-17T14:59:29Z","pushed_at":"2017-05-26T14:26:58Z","git_url":"git://github.com/d-ronin/dRonin.git","ssh_url":"git@github.com:d-ronin/dRonin.git","clone_url":"https://github.com/d-ronin/dRonin.git","svn_url":"https://github.com/d-ronin/dRonin","homepage":"http://dronin.org","size":254347,"stargazers_count":137,"watchers_count":137,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":97,"mirror_url":null,"open_issues_count":153,"forks":97,"open_issues":153,"watchers":137,"default_branch":"next"}},"_links":{"self":{"href":"https://api.github.com/repos/d-ronin/dRonin/pulls/1788"},"html":{"href":"https://github.com/d-ronin/dRonin/pull/1788"},"issue":{"href":"https://api.github.com/repos/d-ronin/dRonin/issues/1788"},"comments":{"href":"https://api.github.com/repos/d-ronin/dRonin/issues/1788/comments"},"review_comments":{"href":"https://api.github.com/repos/d-ronin/dRonin/pulls/1788/comments"},"review_comment":{"href":"https://api.github.com/repos/d-ronin/dRonin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/d-ronin/dRonin/pulls/1788/commits"},"statuses":{"href":"https://api.github.com/repos/d-ronin/dRonin/statuses/ebc6416cb35b02b750ea5f2cee93905e2107d56f"}},"merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":2,"additions":93,"deletions":1,"changed_files":2}}
{"actor":{"display_login":"glowtape"}}