{"action":"reopened","number":2422,"pull_request":{"url":"https://api.github.com/repos/endless-sky/endless-sky/pulls/2422","id":116149940,"html_url":"https://github.com/endless-sky/endless-sky/pull/2422","diff_url":"https://github.com/endless-sky/endless-sky/pull/2422.diff","patch_url":"https://github.com/endless-sky/endless-sky/pull/2422.patch","issue_url":"https://api.github.com/repos/endless-sky/endless-sky/issues/2422","number":2422,"state":"open","locked":false,"title":"Deselect ship on click in shop interface","user":{"login":"xiamaz","id":3340720,"avatar_url":"https://avatars3.githubusercontent.com/u/3340720?v=3","gravatar_id":"","url":"https://api.github.com/users/xiamaz","html_url":"https://github.com/xiamaz","followers_url":"https://api.github.com/users/xiamaz/followers","following_url":"https://api.github.com/users/xiamaz/following{/other_user}","gists_url":"https://api.github.com/users/xiamaz/gists{/gist_id}","starred_url":"https://api.github.com/users/xiamaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiamaz/subscriptions","organizations_url":"https://api.github.com/users/xiamaz/orgs","repos_url":"https://api.github.com/users/xiamaz/repos","events_url":"https://api.github.com/users/xiamaz/events{/privacy}","received_events_url":"https://api.github.com/users/xiamaz/received_events","type":"User","site_admin":false},"body":"This simple patch lets the user deselect a ship with normal clicks, which makes buying outfits into cargo a lot more discoverable as proposed in #2182.\r\n\r\nCurrently the two commits represent different deselection methods.\r\n1. Deselect on simple click. Drag and drop doesn't work as expected, as dragging a ship would deselect it.\r\n2. Deselect on double click. Drag and drop is not altered. -- Current version.\r\n\r\nI have directly added the clicks variable into the SideSelect function, if this is considered bad style, I would be glad for corrections.","created_at":"2017-04-17T15:27:59Z","updated_at":"2017-05-04T22:37:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f36a54721e5775587b07b81eebb5d4dd12eeba36","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/endless-sky/endless-sky/pulls/2422/commits","review_comments_url":"https://api.github.com/repos/endless-sky/endless-sky/pulls/2422/comments","review_comment_url":"https://api.github.com/repos/endless-sky/endless-sky/pulls/comments{/number}","comments_url":"https://api.github.com/repos/endless-sky/endless-sky/issues/2422/comments","statuses_url":"https://api.github.com/repos/endless-sky/endless-sky/statuses/09ed34b56e4bea6f73e4ea98e89278207a67a663","head":{"label":"xiamaz:master","ref":"master","sha":"09ed34b56e4bea6f73e4ea98e89278207a67a663","user":{"login":"xiamaz","id":3340720,"avatar_url":"https://avatars3.githubusercontent.com/u/3340720?v=3","gravatar_id":"","url":"https://api.github.com/users/xiamaz","html_url":"https://github.com/xiamaz","followers_url":"https://api.github.com/users/xiamaz/followers","following_url":"https://api.github.com/users/xiamaz/following{/other_user}","gists_url":"https://api.github.com/users/xiamaz/gists{/gist_id}","starred_url":"https://api.github.com/users/xiamaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiamaz/subscriptions","organizations_url":"https://api.github.com/users/xiamaz/orgs","repos_url":"https://api.github.com/users/xiamaz/repos","events_url":"https://api.github.com/users/xiamaz/events{/privacy}","received_events_url":"https://api.github.com/users/xiamaz/received_events","type":"User","site_admin":false},"repo":{"id":88508834,"name":"endless-sky","full_name":"xiamaz/endless-sky","owner":{"login":"xiamaz","id":3340720,"avatar_url":"https://avatars3.githubusercontent.com/u/3340720?v=3","gravatar_id":"","url":"https://api.github.com/users/xiamaz","html_url":"https://github.com/xiamaz","followers_url":"https://api.github.com/users/xiamaz/followers","following_url":"https://api.github.com/users/xiamaz/following{/other_user}","gists_url":"https://api.github.com/users/xiamaz/gists{/gist_id}","starred_url":"https://api.github.com/users/xiamaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiamaz/subscriptions","organizations_url":"https://api.github.com/users/xiamaz/orgs","repos_url":"https://api.github.com/users/xiamaz/repos","events_url":"https://api.github.com/users/xiamaz/events{/privacy}","received_events_url":"https://api.github.com/users/xiamaz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xiamaz/endless-sky","description":"Space exploration, trading, and combat game.","fork":true,"url":"https://api.github.com/repos/xiamaz/endless-sky","forks_url":"https://api.github.com/repos/xiamaz/endless-sky/forks","keys_url":"https://api.github.com/repos/xiamaz/endless-sky/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xiamaz/endless-sky/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xiamaz/endless-sky/teams","hooks_url":"https://api.github.com/repos/xiamaz/endless-sky/hooks","issue_events_url":"https://api.github.com/repos/xiamaz/endless-sky/issues/events{/number}","events_url":"https://api.github.com/repos/xiamaz/endless-sky/events","assignees_url":"https://api.github.com/repos/xiamaz/endless-sky/assignees{/user}","branches_url":"https://api.github.com/repos/xiamaz/endless-sky/branches{/branch}","tags_url":"https://api.github.com/repos/xiamaz/endless-sky/tags","blobs_url":"https://api.github.com/repos/xiamaz/endless-sky/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xiamaz/endless-sky/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xiamaz/endless-sky/git/refs{/sha}","trees_url":"https://api.github.com/repos/xiamaz/endless-sky/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xiamaz/endless-sky/statuses/{sha}","languages_url":"https://api.github.com/repos/xiamaz/endless-sky/languages","stargazers_url":"https://api.github.com/repos/xiamaz/endless-sky/stargazers","contributors_url":"https://api.github.com/repos/xiamaz/endless-sky/contributors","subscribers_url":"https://api.github.com/repos/xiamaz/endless-sky/subscribers","subscription_url":"https://api.github.com/repos/xiamaz/endless-sky/subscription","commits_url":"https://api.github.com/repos/xiamaz/endless-sky/commits{/sha}","git_commits_url":"https://api.github.com/repos/xiamaz/endless-sky/git/commits{/sha}","comments_url":"https://api.github.com/repos/xiamaz/endless-sky/comments{/number}","issue_comment_url":"https://api.github.com/repos/xiamaz/endless-sky/issues/comments{/number}","contents_url":"https://api.github.com/repos/xiamaz/endless-sky/contents/{+path}","compare_url":"https://api.github.com/repos/xiamaz/endless-sky/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xiamaz/endless-sky/merges","archive_url":"https://api.github.com/repos/xiamaz/endless-sky/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xiamaz/endless-sky/downloads","issues_url":"https://api.github.com/repos/xiamaz/endless-sky/issues{/number}","pulls_url":"https://api.github.com/repos/xiamaz/endless-sky/pulls{/number}","milestones_url":"https://api.github.com/repos/xiamaz/endless-sky/milestones{/number}","notifications_url":"https://api.github.com/repos/xiamaz/endless-sky/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xiamaz/endless-sky/labels{/name}","releases_url":"https://api.github.com/repos/xiamaz/endless-sky/releases{/id}","deployments_url":"https://api.github.com/repos/xiamaz/endless-sky/deployments","created_at":"2017-04-17T13:05:43Z","updated_at":"2017-04-17T13:05:48Z","pushed_at":"2017-05-04T22:35:05Z","git_url":"git://github.com/xiamaz/endless-sky.git","ssh_url":"git@github.com:xiamaz/endless-sky.git","clone_url":"https://github.com/xiamaz/endless-sky.git","svn_url":"https://github.com/xiamaz/endless-sky","homepage":"http://endless-sky.github.io/","size":115991,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"endless-sky:master","ref":"master","sha":"3f67e430ff7768170714e488310064bc7a8e6013","user":{"login":"endless-sky","id":11450262,"avatar_url":"https://avatars1.githubusercontent.com/u/11450262?v=3","gravatar_id":"","url":"https://api.github.com/users/endless-sky","html_url":"https://github.com/endless-sky","followers_url":"https://api.github.com/users/endless-sky/followers","following_url":"https://api.github.com/users/endless-sky/following{/other_user}","gists_url":"https://api.github.com/users/endless-sky/gists{/gist_id}","starred_url":"https://api.github.com/users/endless-sky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endless-sky/subscriptions","organizations_url":"https://api.github.com/users/endless-sky/orgs","repos_url":"https://api.github.com/users/endless-sky/repos","events_url":"https://api.github.com/users/endless-sky/events{/privacy}","received_events_url":"https://api.github.com/users/endless-sky/received_events","type":"User","site_admin":false},"repo":{"id":32231207,"name":"endless-sky","full_name":"endless-sky/endless-sky","owner":{"login":"endless-sky","id":11450262,"avatar_url":"https://avatars1.githubusercontent.com/u/11450262?v=3","gravatar_id":"","url":"https://api.github.com/users/endless-sky","html_url":"https://github.com/endless-sky","followers_url":"https://api.github.com/users/endless-sky/followers","following_url":"https://api.github.com/users/endless-sky/following{/other_user}","gists_url":"https://api.github.com/users/endless-sky/gists{/gist_id}","starred_url":"https://api.github.com/users/endless-sky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endless-sky/subscriptions","organizations_url":"https://api.github.com/users/endless-sky/orgs","repos_url":"https://api.github.com/users/endless-sky/repos","events_url":"https://api.github.com/users/endless-sky/events{/privacy}","received_events_url":"https://api.github.com/users/endless-sky/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/endless-sky/endless-sky","description":"Space exploration, trading, and combat game.","fork":false,"url":"https://api.github.com/repos/endless-sky/endless-sky","forks_url":"https://api.github.com/repos/endless-sky/endless-sky/forks","keys_url":"https://api.github.com/repos/endless-sky/endless-sky/keys{/key_id}","collaborators_url":"https://api.github.com/repos/endless-sky/endless-sky/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/endless-sky/endless-sky/teams","hooks_url":"https://api.github.com/repos/endless-sky/endless-sky/hooks","issue_events_url":"https://api.github.com/repos/endless-sky/endless-sky/issues/events{/number}","events_url":"https://api.github.com/repos/endless-sky/endless-sky/events","assignees_url":"https://api.github.com/repos/endless-sky/endless-sky/assignees{/user}","branches_url":"https://api.github.com/repos/endless-sky/endless-sky/branches{/branch}","tags_url":"https://api.github.com/repos/endless-sky/endless-sky/tags","blobs_url":"https://api.github.com/repos/endless-sky/endless-sky/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/endless-sky/endless-sky/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/endless-sky/endless-sky/git/refs{/sha}","trees_url":"https://api.github.com/repos/endless-sky/endless-sky/git/trees{/sha}","statuses_url":"https://api.github.com/repos/endless-sky/endless-sky/statuses/{sha}","languages_url":"https://api.github.com/repos/endless-sky/endless-sky/languages","stargazers_url":"https://api.github.com/repos/endless-sky/endless-sky/stargazers","contributors_url":"https://api.github.com/repos/endless-sky/endless-sky/contributors","subscribers_url":"https://api.github.com/repos/endless-sky/endless-sky/subscribers","subscription_url":"https://api.github.com/repos/endless-sky/endless-sky/subscription","commits_url":"https://api.github.com/repos/endless-sky/endless-sky/commits{/sha}","git_commits_url":"https://api.github.com/repos/endless-sky/endless-sky/git/commits{/sha}","comments_url":"https://api.github.com/repos/endless-sky/endless-sky/comments{/number}","issue_comment_url":"https://api.github.com/repos/endless-sky/endless-sky/issues/comments{/number}","contents_url":"https://api.github.com/repos/endless-sky/endless-sky/contents/{+path}","compare_url":"https://api.github.com/repos/endless-sky/endless-sky/compare/{base}...{head}","merges_url":"https://api.github.com/repos/endless-sky/endless-sky/merges","archive_url":"https://api.github.com/repos/endless-sky/endless-sky/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/endless-sky/endless-sky/downloads","issues_url":"https://api.github.com/repos/endless-sky/endless-sky/issues{/number}","pulls_url":"https://api.github.com/repos/endless-sky/endless-sky/pulls{/number}","milestones_url":"https://api.github.com/repos/endless-sky/endless-sky/milestones{/number}","notifications_url":"https://api.github.com/repos/endless-sky/endless-sky/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/endless-sky/endless-sky/labels{/name}","releases_url":"https://api.github.com/repos/endless-sky/endless-sky/releases{/id}","deployments_url":"https://api.github.com/repos/endless-sky/endless-sky/deployments","created_at":"2015-03-14T20:44:39Z","updated_at":"2017-05-04T16:22:05Z","pushed_at":"2017-05-04T20:47:45Z","git_url":"git://github.com/endless-sky/endless-sky.git","ssh_url":"git@github.com:endless-sky/endless-sky.git","clone_url":"https://github.com/endless-sky/endless-sky.git","svn_url":"https://github.com/endless-sky/endless-sky","homepage":"http://endless-sky.github.io/","size":117242,"stargazers_count":951,"watchers_count":951,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":265,"mirror_url":null,"open_issues_count":459,"forks":265,"open_issues":459,"watchers":951,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/endless-sky/endless-sky/pulls/2422"},"html":{"href":"https://github.com/endless-sky/endless-sky/pull/2422"},"issue":{"href":"https://api.github.com/repos/endless-sky/endless-sky/issues/2422"},"comments":{"href":"https://api.github.com/repos/endless-sky/endless-sky/issues/2422/comments"},"review_comments":{"href":"https://api.github.com/repos/endless-sky/endless-sky/pulls/2422/comments"},"review_comment":{"href":"https://api.github.com/repos/endless-sky/endless-sky/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/endless-sky/endless-sky/pulls/2422/commits"},"statuses":{"href":"https://api.github.com/repos/endless-sky/endless-sky/statuses/09ed34b56e4bea6f73e4ea98e89278207a67a663"}},"merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":1,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":15,"deletions":1,"changed_files":2}}
{"actor":{"display_login":"xiamaz"}}