{"action":"closed","number":93,"pull_request":{"url":"https://api.github.com/repos/kaltura/playkit-ios/pulls/93","id":107610180,"html_url":"https://github.com/kaltura/playkit-ios/pull/93","diff_url":"https://github.com/kaltura/playkit-ios/pull/93.diff","patch_url":"https://github.com/kaltura/playkit-ios/pull/93.patch","issue_url":"https://api.github.com/repos/kaltura/playkit-ios/issues/93","number":93,"state":"closed","locked":false,"title":"Made SessionProviders and MediaEntryProviders objective-c compatible","user":{"login":"noamtamim","id":10047237,"avatar_url":"https://avatars.githubusercontent.com/u/10047237?v=3","gravatar_id":"","url":"https://api.github.com/users/noamtamim","html_url":"https://github.com/noamtamim","followers_url":"https://api.github.com/users/noamtamim/followers","following_url":"https://api.github.com/users/noamtamim/following{/other_user}","gists_url":"https://api.github.com/users/noamtamim/gists{/gist_id}","starred_url":"https://api.github.com/users/noamtamim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noamtamim/subscriptions","organizations_url":"https://api.github.com/users/noamtamim/orgs","repos_url":"https://api.github.com/users/noamtamim/repos","events_url":"https://api.github.com/users/noamtamim/events{/privacy}","received_events_url":"https://api.github.com/users/noamtamim/received_events","type":"User","site_admin":false},"body":"Swift generics are incompatible with Objective-C, so the protocol methods:\r\n```swift\r\n    func loadKS(completion: @escaping (_ result :Result<String>) -> Void)\r\n    func loadMedia(callback: @escaping (Result<MediaEntry>) -> Void)\r\n```\r\nCould not be translated to objc, which causes the entire protocol to be incompatible.\r\n\r\nThe fix is changing above methods to:\r\n```swift\r\n    func loadKS(completion: @escaping (String?, Error?) -> Void)\r\n    func loadMedia(callback: @escaping (MediaEntry?, Error?) -> Void)\r\n```","created_at":"2017-02-23T11:58:15Z","updated_at":"2017-02-23T13:50:55Z","closed_at":"2017-02-23T13:50:55Z","merged_at":"2017-02-23T13:50:55Z","merge_commit_sha":"0a185e181c4a3b57f9a478f5230fb3b50952bc77","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/kaltura/playkit-ios/pulls/93/commits","review_comments_url":"https://api.github.com/repos/kaltura/playkit-ios/pulls/93/comments","review_comment_url":"https://api.github.com/repos/kaltura/playkit-ios/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kaltura/playkit-ios/issues/93/comments","statuses_url":"https://api.github.com/repos/kaltura/playkit-ios/statuses/89b68321c054738be1586eb400c6753a5d9f82be","head":{"label":"kaltura:FEM-1143-providers-objc-compat","ref":"FEM-1143-providers-objc-compat","sha":"89b68321c054738be1586eb400c6753a5d9f82be","user":{"login":"kaltura","id":319096,"avatar_url":"https://avatars.githubusercontent.com/u/319096?v=3","gravatar_id":"","url":"https://api.github.com/users/kaltura","html_url":"https://github.com/kaltura","followers_url":"https://api.github.com/users/kaltura/followers","following_url":"https://api.github.com/users/kaltura/following{/other_user}","gists_url":"https://api.github.com/users/kaltura/gists{/gist_id}","starred_url":"https://api.github.com/users/kaltura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaltura/subscriptions","organizations_url":"https://api.github.com/users/kaltura/orgs","repos_url":"https://api.github.com/users/kaltura/repos","events_url":"https://api.github.com/users/kaltura/events{/privacy}","received_events_url":"https://api.github.com/users/kaltura/received_events","type":"Organization","site_admin":false},"repo":{"id":70145368,"name":"playkit-ios","full_name":"kaltura/playkit-ios","owner":{"login":"kaltura","id":319096,"avatar_url":"https://avatars.githubusercontent.com/u/319096?v=3","gravatar_id":"","url":"https://api.github.com/users/kaltura","html_url":"https://github.com/kaltura","followers_url":"https://api.github.com/users/kaltura/followers","following_url":"https://api.github.com/users/kaltura/following{/other_user}","gists_url":"https://api.github.com/users/kaltura/gists{/gist_id}","starred_url":"https://api.github.com/users/kaltura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaltura/subscriptions","organizations_url":"https://api.github.com/users/kaltura/orgs","repos_url":"https://api.github.com/users/kaltura/repos","events_url":"https://api.github.com/users/kaltura/events{/privacy}","received_events_url":"https://api.github.com/users/kaltura/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kaltura/playkit-ios","description":"PlayKit: Kaltura Player SDK for iOS","fork":false,"url":"https://api.github.com/repos/kaltura/playkit-ios","forks_url":"https://api.github.com/repos/kaltura/playkit-ios/forks","keys_url":"https://api.github.com/repos/kaltura/playkit-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kaltura/playkit-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kaltura/playkit-ios/teams","hooks_url":"https://api.github.com/repos/kaltura/playkit-ios/hooks","issue_events_url":"https://api.github.com/repos/kaltura/playkit-ios/issues/events{/number}","events_url":"https://api.github.com/repos/kaltura/playkit-ios/events","assignees_url":"https://api.github.com/repos/kaltura/playkit-ios/assignees{/user}","branches_url":"https://api.github.com/repos/kaltura/playkit-ios/branches{/branch}","tags_url":"https://api.github.com/repos/kaltura/playkit-ios/tags","blobs_url":"https://api.github.com/repos/kaltura/playkit-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kaltura/playkit-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kaltura/playkit-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/kaltura/playkit-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kaltura/playkit-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/kaltura/playkit-ios/languages","stargazers_url":"https://api.github.com/repos/kaltura/playkit-ios/stargazers","contributors_url":"https://api.github.com/repos/kaltura/playkit-ios/contributors","subscribers_url":"https://api.github.com/repos/kaltura/playkit-ios/subscribers","subscription_url":"https://api.github.com/repos/kaltura/playkit-ios/subscription","commits_url":"https://api.github.com/repos/kaltura/playkit-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/kaltura/playkit-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/kaltura/playkit-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/kaltura/playkit-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/kaltura/playkit-ios/contents/{+path}","compare_url":"https://api.github.com/repos/kaltura/playkit-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kaltura/playkit-ios/merges","archive_url":"https://api.github.com/repos/kaltura/playkit-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kaltura/playkit-ios/downloads","issues_url":"https://api.github.com/repos/kaltura/playkit-ios/issues{/number}","pulls_url":"https://api.github.com/repos/kaltura/playkit-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/kaltura/playkit-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/kaltura/playkit-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kaltura/playkit-ios/labels{/name}","releases_url":"https://api.github.com/repos/kaltura/playkit-ios/releases{/id}","deployments_url":"https://api.github.com/repos/kaltura/playkit-ios/deployments","created_at":"2016-10-06T10:50:52Z","updated_at":"2017-02-15T12:25:20Z","pushed_at":"2017-02-23T13:50:55Z","git_url":"git://github.com/kaltura/playkit-ios.git","ssh_url":"git@github.com:kaltura/playkit-ios.git","clone_url":"https://github.com/kaltura/playkit-ios.git","svn_url":"https://github.com/kaltura/playkit-ios","homepage":"https://vpaas.kaltura.com/documentation/Mobile-Video-Player-SDKs/v3_iOS_GetStarted.html","size":2030,"stargazers_count":9,"watchers_count":9,"language":"Swift","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":3,"forks":5,"open_issues":3,"watchers":9,"default_branch":"develop"}},"base":{"label":"kaltura:develop","ref":"develop","sha":"aced1c02ebcbe3aa85a86fdf02f859d12a8996af","user":{"login":"kaltura","id":319096,"avatar_url":"https://avatars.githubusercontent.com/u/319096?v=3","gravatar_id":"","url":"https://api.github.com/users/kaltura","html_url":"https://github.com/kaltura","followers_url":"https://api.github.com/users/kaltura/followers","following_url":"https://api.github.com/users/kaltura/following{/other_user}","gists_url":"https://api.github.com/users/kaltura/gists{/gist_id}","starred_url":"https://api.github.com/users/kaltura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaltura/subscriptions","organizations_url":"https://api.github.com/users/kaltura/orgs","repos_url":"https://api.github.com/users/kaltura/repos","events_url":"https://api.github.com/users/kaltura/events{/privacy}","received_events_url":"https://api.github.com/users/kaltura/received_events","type":"Organization","site_admin":false},"repo":{"id":70145368,"name":"playkit-ios","full_name":"kaltura/playkit-ios","owner":{"login":"kaltura","id":319096,"avatar_url":"https://avatars.githubusercontent.com/u/319096?v=3","gravatar_id":"","url":"https://api.github.com/users/kaltura","html_url":"https://github.com/kaltura","followers_url":"https://api.github.com/users/kaltura/followers","following_url":"https://api.github.com/users/kaltura/following{/other_user}","gists_url":"https://api.github.com/users/kaltura/gists{/gist_id}","starred_url":"https://api.github.com/users/kaltura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaltura/subscriptions","organizations_url":"https://api.github.com/users/kaltura/orgs","repos_url":"https://api.github.com/users/kaltura/repos","events_url":"https://api.github.com/users/kaltura/events{/privacy}","received_events_url":"https://api.github.com/users/kaltura/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kaltura/playkit-ios","description":"PlayKit: Kaltura Player SDK for iOS","fork":false,"url":"https://api.github.com/repos/kaltura/playkit-ios","forks_url":"https://api.github.com/repos/kaltura/playkit-ios/forks","keys_url":"https://api.github.com/repos/kaltura/playkit-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kaltura/playkit-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kaltura/playkit-ios/teams","hooks_url":"https://api.github.com/repos/kaltura/playkit-ios/hooks","issue_events_url":"https://api.github.com/repos/kaltura/playkit-ios/issues/events{/number}","events_url":"https://api.github.com/repos/kaltura/playkit-ios/events","assignees_url":"https://api.github.com/repos/kaltura/playkit-ios/assignees{/user}","branches_url":"https://api.github.com/repos/kaltura/playkit-ios/branches{/branch}","tags_url":"https://api.github.com/repos/kaltura/playkit-ios/tags","blobs_url":"https://api.github.com/repos/kaltura/playkit-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kaltura/playkit-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kaltura/playkit-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/kaltura/playkit-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kaltura/playkit-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/kaltura/playkit-ios/languages","stargazers_url":"https://api.github.com/repos/kaltura/playkit-ios/stargazers","contributors_url":"https://api.github.com/repos/kaltura/playkit-ios/contributors","subscribers_url":"https://api.github.com/repos/kaltura/playkit-ios/subscribers","subscription_url":"https://api.github.com/repos/kaltura/playkit-ios/subscription","commits_url":"https://api.github.com/repos/kaltura/playkit-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/kaltura/playkit-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/kaltura/playkit-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/kaltura/playkit-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/kaltura/playkit-ios/contents/{+path}","compare_url":"https://api.github.com/repos/kaltura/playkit-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kaltura/playkit-ios/merges","archive_url":"https://api.github.com/repos/kaltura/playkit-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kaltura/playkit-ios/downloads","issues_url":"https://api.github.com/repos/kaltura/playkit-ios/issues{/number}","pulls_url":"https://api.github.com/repos/kaltura/playkit-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/kaltura/playkit-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/kaltura/playkit-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kaltura/playkit-ios/labels{/name}","releases_url":"https://api.github.com/repos/kaltura/playkit-ios/releases{/id}","deployments_url":"https://api.github.com/repos/kaltura/playkit-ios/deployments","created_at":"2016-10-06T10:50:52Z","updated_at":"2017-02-15T12:25:20Z","pushed_at":"2017-02-23T13:50:55Z","git_url":"git://github.com/kaltura/playkit-ios.git","ssh_url":"git@github.com:kaltura/playkit-ios.git","clone_url":"https://github.com/kaltura/playkit-ios.git","svn_url":"https://github.com/kaltura/playkit-ios","homepage":"https://vpaas.kaltura.com/documentation/Mobile-Video-Player-SDKs/v3_iOS_GetStarted.html","size":2030,"stargazers_count":9,"watchers_count":9,"language":"Swift","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":3,"forks":5,"open_issues":3,"watchers":9,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/kaltura/playkit-ios/pulls/93"},"html":{"href":"https://github.com/kaltura/playkit-ios/pull/93"},"issue":{"href":"https://api.github.com/repos/kaltura/playkit-ios/issues/93"},"comments":{"href":"https://api.github.com/repos/kaltura/playkit-ios/issues/93/comments"},"review_comments":{"href":"https://api.github.com/repos/kaltura/playkit-ios/pulls/93/comments"},"review_comment":{"href":"https://api.github.com/repos/kaltura/playkit-ios/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kaltura/playkit-ios/pulls/93/commits"},"statuses":{"href":"https://api.github.com/repos/kaltura/playkit-ios/statuses/89b68321c054738be1586eb400c6753a5d9f82be"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"noamtamim","id":10047237,"avatar_url":"https://avatars.githubusercontent.com/u/10047237?v=3","gravatar_id":"","url":"https://api.github.com/users/noamtamim","html_url":"https://github.com/noamtamim","followers_url":"https://api.github.com/users/noamtamim/followers","following_url":"https://api.github.com/users/noamtamim/following{/other_user}","gists_url":"https://api.github.com/users/noamtamim/gists{/gist_id}","starred_url":"https://api.github.com/users/noamtamim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noamtamim/subscriptions","organizations_url":"https://api.github.com/users/noamtamim/orgs","repos_url":"https://api.github.com/users/noamtamim/repos","events_url":"https://api.github.com/users/noamtamim/events{/privacy}","received_events_url":"https://api.github.com/users/noamtamim/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":64,"deletions":66,"changed_files":8}}
{"actor":{"display_login":"noamtamim"}}