{"action":"created","issue":{"url":"https://api.github.com/repos/nextcloud/server/issues/4588","repository_url":"https://api.github.com/repos/nextcloud/server","labels_url":"https://api.github.com/repos/nextcloud/server/issues/4588/labels{/name}","comments_url":"https://api.github.com/repos/nextcloud/server/issues/4588/comments","events_url":"https://api.github.com/repos/nextcloud/server/issues/4588/events","html_url":"https://github.com/nextcloud/server/pull/4588","id":225198919,"number":4588,"title":"Update login flow redirection","user":{"login":"mario","id":5810,"avatar_url":"https://avatars0.githubusercontent.com/u/5810?v=3","gravatar_id":"","url":"https://api.github.com/users/mario","html_url":"https://github.com/mario","followers_url":"https://api.github.com/users/mario/followers","following_url":"https://api.github.com/users/mario/following{/other_user}","gists_url":"https://api.github.com/users/mario/gists{/gist_id}","starred_url":"https://api.github.com/users/mario/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mario/subscriptions","organizations_url":"https://api.github.com/users/mario/orgs","repos_url":"https://api.github.com/users/mario/repos","events_url":"https://api.github.com/users/mario/events{/privacy}","received_events_url":"https://api.github.com/users/mario/received_events","type":"User","site_admin":false},"labels":[{"id":389003733,"url":"https://api.github.com/repos/nextcloud/server/labels/3.%20to%20review","name":"3. to review","color":"0052cc","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-04-28T21:35:45Z","updated_at":"2017-05-03T21:06:53Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nextcloud/server/pulls/4588","html_url":"https://github.com/nextcloud/server/pull/4588","diff_url":"https://github.com/nextcloud/server/pull/4588.diff","patch_url":"https://github.com/nextcloud/server/pull/4588.patch"},"body":"This updates the login flow to work the way we did it in another project on both Android and iOS, and I assume the Desktop :)\r\n\r\nAnd yay for my first PR to the server!"},"comment":{"url":"https://api.github.com/repos/nextcloud/server/issues/comments/299035615","html_url":"https://github.com/nextcloud/server/pull/4588#issuecomment-299035615","issue_url":"https://api.github.com/repos/nextcloud/server/issues/4588","id":299035615,"user":{"login":"codecov[bot]","id":22429695,"avatar_url":"https://avatars1.githubusercontent.com/in/254?v=3","gravatar_id":"","url":"https://api.github.com/users/codecov%5Bbot%5D","html_url":"https://github.com/integration/codecov","followers_url":"https://api.github.com/users/codecov%5Bbot%5D/followers","following_url":"https://api.github.com/users/codecov%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/codecov%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/codecov%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/codecov%5Bbot%5D/repos","events_url":"https://api.github.com/users/codecov%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/codecov%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2017-05-03T21:06:53Z","updated_at":"2017-05-03T21:06:53Z","body":"# [Codecov](https://codecov.io/gh/nextcloud/server/pull/4588?src=pr&el=h1) Report\n> Merging [#4588](https://codecov.io/gh/nextcloud/server/pull/4588?src=pr&el=desc) into [master](https://codecov.io/gh/nextcloud/server/commit/3dbf30c2204cde1d493d7837857519d65cfd5049?src=pr&el=desc) will **increase** coverage by `22.93%`.\n> The diff coverage is `100%`.\n\n\n```diff\n@@              Coverage Diff              @@\n##             master    #4588       +/-   ##\n=============================================\n+ Coverage     31.35%   54.29%   +22.93%     \n+ Complexity    22097    21902      -195     \n=============================================\n  Files          1361     1349       -12     \n  Lines         84106    84002      -104     \n  Branches       1324     1335       +11     \n=============================================\n+ Hits          26374    45605    +19231     \n+ Misses        57732    38397    -19335\n```\n\n\n\n| [Impacted Files](https://codecov.io/gh/nextcloud/server/pull/4588?src=pr&el=tree) | Coverage Δ | Complexity Δ | |\n|---|---|---|---|\n| [core/Controller/ClientFlowLoginController.php](https://codecov.io/gh/nextcloud/server/pull/4588?src=pr&el=tree#diff-Y29yZS9Db250cm9sbGVyL0NsaWVudEZsb3dMb2dpbkNvbnRyb2xsZXIucGhw) | `81.44% <100%> (ø)` | `16 <0> (ø)` | :arrow_down: |\n| [core/js/share.js](https://codecov.io/gh/nextcloud/server/pull/4588?src=pr&el=tree#diff-Y29yZS9qcy9zaGFyZS5qcw==) | `34.24% <0%> (-6.74%)` | `0% <0%> (ø)` | |\n| [apps/files\\_external/lib/Lib/Storage/SMB.php](https://codecov.io/gh/nextcloud/server/pull/4588?src=pr&el=tree#diff-YXBwcy9maWxlc19leHRlcm5hbC9saWIvTGliL1N0b3JhZ2UvU01CLnBocA==) | `47.22% <0%> (-4.1%)` | `112% <0%> (-4%)` | |\n| [lib/private/Security/Bruteforce/Throttler.php](https://codecov.io/gh/nextcloud/server/pull/4588?src=pr&el=tree#diff-bGliL3ByaXZhdGUvU2VjdXJpdHkvQnJ1dGVmb3JjZS9UaHJvdHRsZXIucGhw) | `42.15% <0%> (-1.12%)` | `24% <0%> (-1%)` | |\n| [apps/dav/lib/CardDAV/ImageExportPlugin.php](https://codecov.io/gh/nextcloud/server/pull/4588?src=pr&el=tree#diff-YXBwcy9kYXYvbGliL0NhcmREQVYvSW1hZ2VFeHBvcnRQbHVnaW4ucGhw) | `85.93% <0%> (-0.63%)` | `20% <0%> (ø)` | |\n| [core/js/sharedialoglinkshareview.js](https://codecov.io/gh/nextcloud/server/pull/4588?src=pr&el=tree#diff-Y29yZS9qcy9zaGFyZWRpYWxvZ2xpbmtzaGFyZXZpZXcuanM=) | `55.55% <0%> (-0.6%)` | `0% <0%> (ø)` | |\n| [core/js/js.js](https://codecov.io/gh/nextcloud/server/pull/4588?src=pr&el=tree#diff-Y29yZS9qcy9qcy5qcw==) | `61.21% <0%> (-0.57%)` | `0% <0%> (ø)` | |\n| [apps/theming/lib/ThemingDefaults.php](https://codecov.io/gh/nextcloud/server/pull/4588?src=pr&el=tree#diff-YXBwcy90aGVtaW5nL2xpYi9UaGVtaW5nRGVmYXVsdHMucGhw) | `87.25% <0%> (-0.13%)` | `33% <0%> (ø)` | |\n| [apps/dav/lib/CalDAV/CalendarHome.php](https://codecov.io/gh/nextcloud/server/pull/4588?src=pr&el=tree#diff-YXBwcy9kYXYvbGliL0NhbERBVi9DYWxlbmRhckhvbWUucGhw) | `0% <0%> (ø)` | `20% <0%> (-1%)` | :arrow_down: |\n| [settings/personal.php](https://codecov.io/gh/nextcloud/server/pull/4588?src=pr&el=tree#diff-c2V0dGluZ3MvcGVyc29uYWwucGhw) | `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |\n| ... and [400 more](https://codecov.io/gh/nextcloud/server/pull/4588?src=pr&el=tree-more) | |\n"}}
{"actor":{"display_login":"codecov"}}