{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/13697","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/13697/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/13697/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/13697/events","html_url":"https://github.com/nodejs/node/pull/13697","id":236167032,"number":13697,"title":"test: check zlib version for createDeflateRaw","user":{"login":"danbev","id":432351,"avatar_url":"https://avatars3.githubusercontent.com/u/432351?v=4","gravatar_id":"","url":"https://api.github.com/users/danbev","html_url":"https://github.com/danbev","followers_url":"https://api.github.com/users/danbev/followers","following_url":"https://api.github.com/users/danbev/following{/other_user}","gists_url":"https://api.github.com/users/danbev/gists{/gist_id}","starred_url":"https://api.github.com/users/danbev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danbev/subscriptions","organizations_url":"https://api.github.com/users/danbev/orgs","repos_url":"https://api.github.com/users/danbev/repos","events_url":"https://api.github.com/users/danbev/events{/privacy}","received_events_url":"https://api.github.com/users/danbev/received_events","type":"User","site_admin":false},"labels":[{"id":364533783,"url":"https://api.github.com/repos/nodejs/node/labels/dont-land-on-v6.x","name":"dont-land-on-v6.x","color":"bfdadc","default":false},{"id":176240519,"url":"https://api.github.com/repos/nodejs/node/labels/test","name":"test","color":"990099","default":false},{"id":155436008,"url":"https://api.github.com/repos/nodejs/node/labels/zlib","name":"zlib","color":"009800","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2017-06-15T12:00:05Z","updated_at":"2017-09-13T21:26:25Z","closed_at":"2017-06-18T10:37:32Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/13697","html_url":"https://github.com/nodejs/node/pull/13697","diff_url":"https://github.com/nodejs/node/pull/13697.diff","patch_url":"https://github.com/nodejs/node/pull/13697.patch"},"body":"We are currenly builing Node with `--shared-zlib` which happens to be\r\nversion `1.2.8`. The test for zlib.createDeflateRaw is expected to fail\r\nbut does not when using version `1.2.8`.\r\n\r\nAs far as I can tell the fix referred to in the comments was\r\nintroduced in version `1.2.9`:\r\n```\r\n- Reject a window size of 256 bytes if not using the zlib wrapper\r\n```\r\n\r\nThis commit suggests adding a check for the version and skipping this\r\nassert if the version is less than `1.2.9`.\r\n\r\nRefs: http://zlib.net/ChangeLog.txt\r\n\r\n<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines)\r\n\r\n##### Affected core subsystem(s)\r\n<!-- Provide affected core subsystem(s) (like doc, cluster, crypto, etc). -->\r\ntest"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/329301827","html_url":"https://github.com/nodejs/node/pull/13697#issuecomment-329301827","issue_url":"https://api.github.com/repos/nodejs/node/issues/13697","id":329301827,"user":{"login":"drewfish","id":447478,"avatar_url":"https://avatars2.githubusercontent.com/u/447478?v=4","gravatar_id":"","url":"https://api.github.com/users/drewfish","html_url":"https://github.com/drewfish","followers_url":"https://api.github.com/users/drewfish/followers","following_url":"https://api.github.com/users/drewfish/following{/other_user}","gists_url":"https://api.github.com/users/drewfish/gists{/gist_id}","starred_url":"https://api.github.com/users/drewfish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drewfish/subscriptions","organizations_url":"https://api.github.com/users/drewfish/orgs","repos_url":"https://api.github.com/users/drewfish/repos","events_url":"https://api.github.com/users/drewfish/events{/privacy}","received_events_url":"https://api.github.com/users/drewfish/received_events","type":"User","site_admin":false},"created_at":"2017-09-13T21:26:25Z","updated_at":"2017-09-13T21:26:25Z","author_association":"CONTRIBUTOR","body":"BTW here at Yahoo we just backported this to our internal v6.x branch, since we `./configure --shared-zlib` with an older version of zlib."}}
{"actor":{"display_login":"drewfish"}}