{"action":"created","issue":{"url":"https://api.github.com/repos/quasarframework/quasar/issues/1318","repository_url":"https://api.github.com/repos/quasarframework/quasar","labels_url":"https://api.github.com/repos/quasarframework/quasar/issues/1318/labels{/name}","comments_url":"https://api.github.com/repos/quasarframework/quasar/issues/1318/comments","events_url":"https://api.github.com/repos/quasarframework/quasar/issues/1318/events","html_url":"https://github.com/quasarframework/quasar/issues/1318","id":282595432,"number":1318,"title":"[Suggestion] Allow the user to set non-flat buttons for Dialog component","user":{"login":"Frondor","id":5123709,"avatar_url":"https://avatars1.githubusercontent.com/u/5123709?v=4","gravatar_id":"","url":"https://api.github.com/users/Frondor","html_url":"https://github.com/Frondor","followers_url":"https://api.github.com/users/Frondor/followers","following_url":"https://api.github.com/users/Frondor/following{/other_user}","gists_url":"https://api.github.com/users/Frondor/gists{/gist_id}","starred_url":"https://api.github.com/users/Frondor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Frondor/subscriptions","organizations_url":"https://api.github.com/users/Frondor/orgs","repos_url":"https://api.github.com/users/Frondor/repos","events_url":"https://api.github.com/users/Frondor/events{/privacy}","received_events_url":"https://api.github.com/users/Frondor/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-12-16T03:06:19Z","updated_at":"2017-12-16T13:39:36Z","closed_at":"2017-12-16T12:32:39Z","author_association":"CONTRIBUTOR","body":"v0.14.7\r\n\r\nAs seen in these 2 lines: https://github.com/quasarframework/quasar/blob/d4125b907d50fccefa4732e03cbd8965daa7e899/src/components/dialog/QDialog.js#L197\r\n\r\nbuttons are gonna be always flat (even button stacks), so if I want to use non-flat buttons for Dialogs, I suggest this instead\r\n```js\r\n  props: {\r\n    color: this.color,\r\n    flat: this.flat === false ? false : true,\r\n    label: this.cancelLabel,\r\n    waitForRipple: true\r\n  }\r\n```\r\n\r\nNow we can set buttons with `{label: 'Ok', flat: false, color: 'primary'}`.\r\n\r\nCan provide a PR if suggestion's accepted.\r\n\r\nEDIT: I'm not really sure that's the logic behind Dialog's btns rendering. But if someone can point me into the right file..."},"comment":{"url":"https://api.github.com/repos/quasarframework/quasar/issues/comments/352184197","html_url":"https://github.com/quasarframework/quasar/issues/1318#issuecomment-352184197","issue_url":"https://api.github.com/repos/quasarframework/quasar/issues/1318","id":352184197,"user":{"login":"rstoenescu","id":4665641,"avatar_url":"https://avatars0.githubusercontent.com/u/4665641?v=4","gravatar_id":"","url":"https://api.github.com/users/rstoenescu","html_url":"https://github.com/rstoenescu","followers_url":"https://api.github.com/users/rstoenescu/followers","following_url":"https://api.github.com/users/rstoenescu/following{/other_user}","gists_url":"https://api.github.com/users/rstoenescu/gists{/gist_id}","starred_url":"https://api.github.com/users/rstoenescu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rstoenescu/subscriptions","organizations_url":"https://api.github.com/users/rstoenescu/orgs","repos_url":"https://api.github.com/users/rstoenescu/repos","events_url":"https://api.github.com/users/rstoenescu/events{/privacy}","received_events_url":"https://api.github.com/users/rstoenescu/received_events","type":"User","site_admin":false},"created_at":"2017-12-16T13:39:35Z","updated_at":"2017-12-16T13:39:35Z","author_association":"OWNER","body":"@Frondor just set one of the other types of buttons to \"true\". The button needs to be set with a type. Let me know if you have any problems with it. Also check [the demo](http://quasar-framework.org/quasar-play/android/index.html#/showcase/popups/dialog) with [its source](https://github.com/quasarframework/quasar-play/blob/master/src/components/showcase/popups/dialog.vue)."}}
{"actor":{"display_login":"rstoenescu"}}