{"action":"created","comment":{"url":"https://api.github.com/repos/scrapinghub/exporters/pulls/comments/101138422","pull_request_review_id":21855744,"id":101138422,"diff_hunk":"@@ -118,7 +118,8 @@ class GroupingBufferFilesTracker(object):\n     that is cleaned up when calling close().\n     \"\"\"\n \n-    def __init__(self, formatter, compression_format):\n+    def __init__(self, formatter=None, compression_format=None, *args, **kwargs):","path":"exporters/write_buffers/base_buffer.py","position":5,"original_position":5,"commit_id":"5bcdc5e3eb0d2d95cd994d3f3beef99dcb534c34","original_commit_id":"5bcdc5e3eb0d2d95cd994d3f3beef99dcb534c34","user":{"login":"kalessin","id":342426,"avatar_url":"https://avatars.githubusercontent.com/u/342426?v=3","gravatar_id":"","url":"https://api.github.com/users/kalessin","html_url":"https://github.com/kalessin","followers_url":"https://api.github.com/users/kalessin/followers","following_url":"https://api.github.com/users/kalessin/following{/other_user}","gists_url":"https://api.github.com/users/kalessin/gists{/gist_id}","starred_url":"https://api.github.com/users/kalessin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalessin/subscriptions","organizations_url":"https://api.github.com/users/kalessin/orgs","repos_url":"https://api.github.com/users/kalessin/repos","events_url":"https://api.github.com/users/kalessin/events{/privacy}","received_events_url":"https://api.github.com/users/kalessin/received_events","type":"User","site_admin":false},"body":"which is the point of having *args after two parameters with default values? In order args to actually have some value, you must always pass some value to formatter and to compression_format. So, either formatter and compression_format shouldn't have default values, or *args shouldn't be there.","created_at":"2017-02-14T20:43:50Z","updated_at":"2017-02-14T20:56:35Z","html_url":"https://github.com/scrapinghub/exporters/pull/342#discussion_r101138422","pull_request_url":"https://api.github.com/repos/scrapinghub/exporters/pulls/342","_links":{"self":{"href":"https://api.github.com/repos/scrapinghub/exporters/pulls/comments/101138422"},"html":{"href":"https://github.com/scrapinghub/exporters/pull/342#discussion_r101138422"},"pull_request":{"href":"https://api.github.com/repos/scrapinghub/exporters/pulls/342"}}},"pull_request":{"url":"https://api.github.com/repos/scrapinghub/exporters/pulls/342","id":101258727,"html_url":"https://github.com/scrapinghub/exporters/pull/342","diff_url":"https://github.com/scrapinghub/exporters/pull/342.diff","patch_url":"https://github.com/scrapinghub/exporters/pull/342.patch","issue_url":"https://api.github.com/repos/scrapinghub/exporters/issues/342","number":342,"state":"open","locked":false,"title":"Add reservoir sampling option to writers","user":{"login":"lpawluczuk","id":1087321,"avatar_url":"https://avatars.githubusercontent.com/u/1087321?v=3","gravatar_id":"","url":"https://api.github.com/users/lpawluczuk","html_url":"https://github.com/lpawluczuk","followers_url":"https://api.github.com/users/lpawluczuk/followers","following_url":"https://api.github.com/users/lpawluczuk/following{/other_user}","gists_url":"https://api.github.com/users/lpawluczuk/gists{/gist_id}","starred_url":"https://api.github.com/users/lpawluczuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lpawluczuk/subscriptions","organizations_url":"https://api.github.com/users/lpawluczuk/orgs","repos_url":"https://api.github.com/users/lpawluczuk/repos","events_url":"https://api.github.com/users/lpawluczuk/events{/privacy}","received_events_url":"https://api.github.com/users/lpawluczuk/received_events","type":"User","site_admin":false},"body":"This is implementation of reservoir sampling for stream of items on writers level. \r\n\r\nIt addresses this issue: https://github.com/scrapinghub/exporters/issues/317\r\n\r\n\r\n","created_at":"2017-01-12T13:28:23Z","updated_at":"2017-02-14T20:56:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"662761498d21ac42d13ac9d505b50a751ef734d0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/scrapinghub/exporters/pulls/342/commits","review_comments_url":"https://api.github.com/repos/scrapinghub/exporters/pulls/342/comments","review_comment_url":"https://api.github.com/repos/scrapinghub/exporters/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scrapinghub/exporters/issues/342/comments","statuses_url":"https://api.github.com/repos/scrapinghub/exporters/statuses/5bcdc5e3eb0d2d95cd994d3f3beef99dcb534c34","head":{"label":"scrapinghub:reservoir-sampling-buffer","ref":"reservoir-sampling-buffer","sha":"5bcdc5e3eb0d2d95cd994d3f3beef99dcb534c34","user":{"login":"scrapinghub","id":699596,"avatar_url":"https://avatars.githubusercontent.com/u/699596?v=3","gravatar_id":"","url":"https://api.github.com/users/scrapinghub","html_url":"https://github.com/scrapinghub","followers_url":"https://api.github.com/users/scrapinghub/followers","following_url":"https://api.github.com/users/scrapinghub/following{/other_user}","gists_url":"https://api.github.com/users/scrapinghub/gists{/gist_id}","starred_url":"https://api.github.com/users/scrapinghub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scrapinghub/subscriptions","organizations_url":"https://api.github.com/users/scrapinghub/orgs","repos_url":"https://api.github.com/users/scrapinghub/repos","events_url":"https://api.github.com/users/scrapinghub/events{/privacy}","received_events_url":"https://api.github.com/users/scrapinghub/received_events","type":"Organization","site_admin":false},"repo":{"id":42141299,"name":"exporters","full_name":"scrapinghub/exporters","owner":{"login":"scrapinghub","id":699596,"avatar_url":"https://avatars.githubusercontent.com/u/699596?v=3","gravatar_id":"","url":"https://api.github.com/users/scrapinghub","html_url":"https://github.com/scrapinghub","followers_url":"https://api.github.com/users/scrapinghub/followers","following_url":"https://api.github.com/users/scrapinghub/following{/other_user}","gists_url":"https://api.github.com/users/scrapinghub/gists{/gist_id}","starred_url":"https://api.github.com/users/scrapinghub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scrapinghub/subscriptions","organizations_url":"https://api.github.com/users/scrapinghub/orgs","repos_url":"https://api.github.com/users/scrapinghub/repos","events_url":"https://api.github.com/users/scrapinghub/events{/privacy}","received_events_url":"https://api.github.com/users/scrapinghub/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scrapinghub/exporters","description":"Exporters is an extensible export pipeline library that supports filter, transform and several sources and destinations","fork":false,"url":"https://api.github.com/repos/scrapinghub/exporters","forks_url":"https://api.github.com/repos/scrapinghub/exporters/forks","keys_url":"https://api.github.com/repos/scrapinghub/exporters/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scrapinghub/exporters/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scrapinghub/exporters/teams","hooks_url":"https://api.github.com/repos/scrapinghub/exporters/hooks","issue_events_url":"https://api.github.com/repos/scrapinghub/exporters/issues/events{/number}","events_url":"https://api.github.com/repos/scrapinghub/exporters/events","assignees_url":"https://api.github.com/repos/scrapinghub/exporters/assignees{/user}","branches_url":"https://api.github.com/repos/scrapinghub/exporters/branches{/branch}","tags_url":"https://api.github.com/repos/scrapinghub/exporters/tags","blobs_url":"https://api.github.com/repos/scrapinghub/exporters/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scrapinghub/exporters/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scrapinghub/exporters/git/refs{/sha}","trees_url":"https://api.github.com/repos/scrapinghub/exporters/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scrapinghub/exporters/statuses/{sha}","languages_url":"https://api.github.com/repos/scrapinghub/exporters/languages","stargazers_url":"https://api.github.com/repos/scrapinghub/exporters/stargazers","contributors_url":"https://api.github.com/repos/scrapinghub/exporters/contributors","subscribers_url":"https://api.github.com/repos/scrapinghub/exporters/subscribers","subscription_url":"https://api.github.com/repos/scrapinghub/exporters/subscription","commits_url":"https://api.github.com/repos/scrapinghub/exporters/commits{/sha}","git_commits_url":"https://api.github.com/repos/scrapinghub/exporters/git/commits{/sha}","comments_url":"https://api.github.com/repos/scrapinghub/exporters/comments{/number}","issue_comment_url":"https://api.github.com/repos/scrapinghub/exporters/issues/comments{/number}","contents_url":"https://api.github.com/repos/scrapinghub/exporters/contents/{+path}","compare_url":"https://api.github.com/repos/scrapinghub/exporters/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scrapinghub/exporters/merges","archive_url":"https://api.github.com/repos/scrapinghub/exporters/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scrapinghub/exporters/downloads","issues_url":"https://api.github.com/repos/scrapinghub/exporters/issues{/number}","pulls_url":"https://api.github.com/repos/scrapinghub/exporters/pulls{/number}","milestones_url":"https://api.github.com/repos/scrapinghub/exporters/milestones{/number}","notifications_url":"https://api.github.com/repos/scrapinghub/exporters/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scrapinghub/exporters/labels{/name}","releases_url":"https://api.github.com/repos/scrapinghub/exporters/releases{/id}","deployments_url":"https://api.github.com/repos/scrapinghub/exporters/deployments","created_at":"2015-09-08T21:59:12Z","updated_at":"2017-02-07T17:08:20Z","pushed_at":"2017-02-14T20:29:46Z","git_url":"git://github.com/scrapinghub/exporters.git","ssh_url":"git@github.com:scrapinghub/exporters.git","clone_url":"https://github.com/scrapinghub/exporters.git","svn_url":"https://github.com/scrapinghub/exporters","homepage":null,"size":1390,"stargazers_count":13,"watchers_count":13,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":10,"forks":4,"open_issues":10,"watchers":13,"default_branch":"master"}},"base":{"label":"scrapinghub:master","ref":"master","sha":"886347fe83b0a6ae8d2b3760b54da05a5284bbbf","user":{"login":"scrapinghub","id":699596,"avatar_url":"https://avatars.githubusercontent.com/u/699596?v=3","gravatar_id":"","url":"https://api.github.com/users/scrapinghub","html_url":"https://github.com/scrapinghub","followers_url":"https://api.github.com/users/scrapinghub/followers","following_url":"https://api.github.com/users/scrapinghub/following{/other_user}","gists_url":"https://api.github.com/users/scrapinghub/gists{/gist_id}","starred_url":"https://api.github.com/users/scrapinghub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scrapinghub/subscriptions","organizations_url":"https://api.github.com/users/scrapinghub/orgs","repos_url":"https://api.github.com/users/scrapinghub/repos","events_url":"https://api.github.com/users/scrapinghub/events{/privacy}","received_events_url":"https://api.github.com/users/scrapinghub/received_events","type":"Organization","site_admin":false},"repo":{"id":42141299,"name":"exporters","full_name":"scrapinghub/exporters","owner":{"login":"scrapinghub","id":699596,"avatar_url":"https://avatars.githubusercontent.com/u/699596?v=3","gravatar_id":"","url":"https://api.github.com/users/scrapinghub","html_url":"https://github.com/scrapinghub","followers_url":"https://api.github.com/users/scrapinghub/followers","following_url":"https://api.github.com/users/scrapinghub/following{/other_user}","gists_url":"https://api.github.com/users/scrapinghub/gists{/gist_id}","starred_url":"https://api.github.com/users/scrapinghub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scrapinghub/subscriptions","organizations_url":"https://api.github.com/users/scrapinghub/orgs","repos_url":"https://api.github.com/users/scrapinghub/repos","events_url":"https://api.github.com/users/scrapinghub/events{/privacy}","received_events_url":"https://api.github.com/users/scrapinghub/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scrapinghub/exporters","description":"Exporters is an extensible export pipeline library that supports filter, transform and several sources and destinations","fork":false,"url":"https://api.github.com/repos/scrapinghub/exporters","forks_url":"https://api.github.com/repos/scrapinghub/exporters/forks","keys_url":"https://api.github.com/repos/scrapinghub/exporters/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scrapinghub/exporters/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scrapinghub/exporters/teams","hooks_url":"https://api.github.com/repos/scrapinghub/exporters/hooks","issue_events_url":"https://api.github.com/repos/scrapinghub/exporters/issues/events{/number}","events_url":"https://api.github.com/repos/scrapinghub/exporters/events","assignees_url":"https://api.github.com/repos/scrapinghub/exporters/assignees{/user}","branches_url":"https://api.github.com/repos/scrapinghub/exporters/branches{/branch}","tags_url":"https://api.github.com/repos/scrapinghub/exporters/tags","blobs_url":"https://api.github.com/repos/scrapinghub/exporters/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scrapinghub/exporters/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scrapinghub/exporters/git/refs{/sha}","trees_url":"https://api.github.com/repos/scrapinghub/exporters/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scrapinghub/exporters/statuses/{sha}","languages_url":"https://api.github.com/repos/scrapinghub/exporters/languages","stargazers_url":"https://api.github.com/repos/scrapinghub/exporters/stargazers","contributors_url":"https://api.github.com/repos/scrapinghub/exporters/contributors","subscribers_url":"https://api.github.com/repos/scrapinghub/exporters/subscribers","subscription_url":"https://api.github.com/repos/scrapinghub/exporters/subscription","commits_url":"https://api.github.com/repos/scrapinghub/exporters/commits{/sha}","git_commits_url":"https://api.github.com/repos/scrapinghub/exporters/git/commits{/sha}","comments_url":"https://api.github.com/repos/scrapinghub/exporters/comments{/number}","issue_comment_url":"https://api.github.com/repos/scrapinghub/exporters/issues/comments{/number}","contents_url":"https://api.github.com/repos/scrapinghub/exporters/contents/{+path}","compare_url":"https://api.github.com/repos/scrapinghub/exporters/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scrapinghub/exporters/merges","archive_url":"https://api.github.com/repos/scrapinghub/exporters/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scrapinghub/exporters/downloads","issues_url":"https://api.github.com/repos/scrapinghub/exporters/issues{/number}","pulls_url":"https://api.github.com/repos/scrapinghub/exporters/pulls{/number}","milestones_url":"https://api.github.com/repos/scrapinghub/exporters/milestones{/number}","notifications_url":"https://api.github.com/repos/scrapinghub/exporters/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scrapinghub/exporters/labels{/name}","releases_url":"https://api.github.com/repos/scrapinghub/exporters/releases{/id}","deployments_url":"https://api.github.com/repos/scrapinghub/exporters/deployments","created_at":"2015-09-08T21:59:12Z","updated_at":"2017-02-07T17:08:20Z","pushed_at":"2017-02-14T20:29:46Z","git_url":"git://github.com/scrapinghub/exporters.git","ssh_url":"git@github.com:scrapinghub/exporters.git","clone_url":"https://github.com/scrapinghub/exporters.git","svn_url":"https://github.com/scrapinghub/exporters","homepage":null,"size":1390,"stargazers_count":13,"watchers_count":13,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":10,"forks":4,"open_issues":10,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scrapinghub/exporters/pulls/342"},"html":{"href":"https://github.com/scrapinghub/exporters/pull/342"},"issue":{"href":"https://api.github.com/repos/scrapinghub/exporters/issues/342"},"comments":{"href":"https://api.github.com/repos/scrapinghub/exporters/issues/342/comments"},"review_comments":{"href":"https://api.github.com/repos/scrapinghub/exporters/pulls/342/comments"},"review_comment":{"href":"https://api.github.com/repos/scrapinghub/exporters/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scrapinghub/exporters/pulls/342/commits"},"statuses":{"href":"https://api.github.com/repos/scrapinghub/exporters/statuses/5bcdc5e3eb0d2d95cd994d3f3beef99dcb534c34"}}}}
{"actor":{"display_login":"kalessin"}}