{"action":"created","issue":{"url":"https://api.github.com/repos/creditkudos/kudomon/issues/10","repository_url":"https://api.github.com/repos/creditkudos/kudomon","labels_url":"https://api.github.com/repos/creditkudos/kudomon/issues/10/labels{/name}","comments_url":"https://api.github.com/repos/creditkudos/kudomon/issues/10/comments","events_url":"https://api.github.com/repos/creditkudos/kudomon/issues/10/events","html_url":"https://github.com/creditkudos/kudomon/pull/10","id":200905541,"number":10,"title":"My Rails Solution","user":{"login":"jamesstonehill","id":19637233,"avatar_url":"https://avatars.githubusercontent.com/u/19637233?v=3","gravatar_id":"","url":"https://api.github.com/users/jamesstonehill","html_url":"https://github.com/jamesstonehill","followers_url":"https://api.github.com/users/jamesstonehill/followers","following_url":"https://api.github.com/users/jamesstonehill/following{/other_user}","gists_url":"https://api.github.com/users/jamesstonehill/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesstonehill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesstonehill/subscriptions","organizations_url":"https://api.github.com/users/jamesstonehill/orgs","repos_url":"https://api.github.com/users/jamesstonehill/repos","events_url":"https://api.github.com/users/jamesstonehill/events{/privacy}","received_events_url":"https://api.github.com/users/jamesstonehill/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2017-01-15T23:23:03Z","updated_at":"2017-01-20T18:56:57Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/creditkudos/kudomon/pulls/10","html_url":"https://github.com/creditkudos/kudomon/pull/10","diff_url":"https://github.com/creditkudos/kudomon/pull/10.diff","patch_url":"https://github.com/creditkudos/kudomon/pull/10.patch"},"body":"Just in case you're wondering, the reason why I included a local version of the Geokit gem is because I ran into an issue with the gem and I was trying to fix it:\r\nhttps://github.com/geokit/geokit-rails/issues/113"},"comment":{"url":"https://api.github.com/repos/creditkudos/kudomon/issues/comments/274150809","html_url":"https://github.com/creditkudos/kudomon/pull/10#issuecomment-274150809","issue_url":"https://api.github.com/repos/creditkudos/kudomon/issues/10","id":274150809,"user":{"login":"mattschofield","id":1247112,"avatar_url":"https://avatars.githubusercontent.com/u/1247112?v=3","gravatar_id":"","url":"https://api.github.com/users/mattschofield","html_url":"https://github.com/mattschofield","followers_url":"https://api.github.com/users/mattschofield/followers","following_url":"https://api.github.com/users/mattschofield/following{/other_user}","gists_url":"https://api.github.com/users/mattschofield/gists{/gist_id}","starred_url":"https://api.github.com/users/mattschofield/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattschofield/subscriptions","organizations_url":"https://api.github.com/users/mattschofield/orgs","repos_url":"https://api.github.com/users/mattschofield/repos","events_url":"https://api.github.com/users/mattschofield/events{/privacy}","received_events_url":"https://api.github.com/users/mattschofield/received_events","type":"User","site_admin":false},"created_at":"2017-01-20T18:56:57Z","updated_at":"2017-01-20T18:56:57Z","body":"James, thanks for submitting this PR - apologies it's taken me a while to review. Some feedback for you (I'll be feeding back to Makers separately):\r\n\r\n1) Nice simple Rails app, minimal fuss - enough for a challenge of this scale 👍 \r\n2) RE: testing, I would've liked to see some as it aids the thought process, but I think (given you're using Rails and not just vanilla Ruby) this would've been more applicable at later stages of the challenge if you'd got round to them.\r\n3) Stylistically, the code is a little sloppy - I'd recommend adopting a [style guide](https://github.com/airbnb/ruby). If you want to know *why* I'd recommend it, check the first comment on [this](https://github.com/airbnb/javascript/issues/102) thread.\r\n4) For future reference, I'd recommend you look into [squashing your commits](http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html). This helps you avoid tiny, meaningless commits that bloat your PRs 😉 \r\n\r\nAs a point of reference, I've added you as a collaborator on my [\"solution\"](https://github.com/mattschofield/kudomon-solution) to the challenge. You're welcome to ask any questions on it if it's of interest!\r\n\r\nAll the best,\r\nM"}}
{"actor":{"display_login":"mattschofield"}}