{"action":"created","comment":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/154229444","pull_request_review_id":80359633,"id":154229444,"diff_hunk":"@@ -63,8 +80,14 @@ describes.realWin('amp-lightbox-viewer', {\n   });\n \n   function runTests(autoLightbox) {","path":"extensions/amp-lightbox-viewer/0.1/test/test-amp-lightbox-viewer.js","position":27,"original_position":27,"commit_id":"80e2a402d72f0974b68b8f95bf8c997fd44ea2e4","original_commit_id":"da0fd7015dceb7bf301aceb8e182a10c196b2375","user":{"login":"cathyxz","id":1528181,"avatar_url":"https://avatars1.githubusercontent.com/u/1528181?v=4","gravatar_id":"","url":"https://api.github.com/users/cathyxz","html_url":"https://github.com/cathyxz","followers_url":"https://api.github.com/users/cathyxz/followers","following_url":"https://api.github.com/users/cathyxz/following{/other_user}","gists_url":"https://api.github.com/users/cathyxz/gists{/gist_id}","starred_url":"https://api.github.com/users/cathyxz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cathyxz/subscriptions","organizations_url":"https://api.github.com/users/cathyxz/orgs","repos_url":"https://api.github.com/users/cathyxz/repos","events_url":"https://api.github.com/users/cathyxz/events{/privacy}","received_events_url":"https://api.github.com/users/cathyxz/received_events","type":"User","site_admin":false},"body":"This test is functionally changed because now lightbox builds on `open` and not on the build callback. ","created_at":"2017-11-30T23:15:39Z","updated_at":"2017-11-30T23:16:19Z","html_url":"https://github.com/ampproject/amphtml/pull/12256#discussion_r154229444","pull_request_url":"https://api.github.com/repos/ampproject/amphtml/pulls/12256","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/154229444"},"html":{"href":"https://github.com/ampproject/amphtml/pull/12256#discussion_r154229444"},"pull_request":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/12256"}}},"pull_request":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/12256","id":155490438,"html_url":"https://github.com/ampproject/amphtml/pull/12256","diff_url":"https://github.com/ampproject/amphtml/pull/12256.diff","patch_url":"https://github.com/ampproject/amphtml/pull/12256.patch","issue_url":"https://api.github.com/repos/ampproject/amphtml/issues/12256","number":12256,"state":"open","locked":false,"title":"[WIP] Lightbox carousel demo","user":{"login":"cathyxz","id":1528181,"avatar_url":"https://avatars1.githubusercontent.com/u/1528181?v=4","gravatar_id":"","url":"https://api.github.com/users/cathyxz","html_url":"https://github.com/cathyxz","followers_url":"https://api.github.com/users/cathyxz/followers","following_url":"https://api.github.com/users/cathyxz/following{/other_user}","gists_url":"https://api.github.com/users/cathyxz/gists{/gist_id}","starred_url":"https://api.github.com/users/cathyxz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cathyxz/subscriptions","organizations_url":"https://api.github.com/users/cathyxz/orgs","repos_url":"https://api.github.com/users/cathyxz/repos","events_url":"https://api.github.com/users/cathyxz/events{/privacy}","received_events_url":"https://api.github.com/users/cathyxz/received_events","type":"User","site_admin":false},"body":"This PR adds a lightbox carousel demo, and makes relevant lazy initialization changes necessary to enable it. Refactors the lightbox initialization to happen in `open_` and makes the necessary changes to lightbox-viewer tests. \r\n\r\nI'm prioritizing this demo to get a user experience sample for @spacedino to UX review and help us prioritize outstanding features / bugfixes from a UX perspective. ","created_at":"2017-11-30T00:36:35Z","updated_at":"2017-11-30T23:16:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"00579484bdd204f505469c5d11e81b040206fa78","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ampproject/amphtml/pulls/12256/commits","review_comments_url":"https://api.github.com/repos/ampproject/amphtml/pulls/12256/comments","review_comment_url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ampproject/amphtml/issues/12256/comments","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/80e2a402d72f0974b68b8f95bf8c997fd44ea2e4","head":{"label":"cathyxz:feature/lightbox-carousel-demo","ref":"feature/lightbox-carousel-demo","sha":"80e2a402d72f0974b68b8f95bf8c997fd44ea2e4","user":{"login":"cathyxz","id":1528181,"avatar_url":"https://avatars1.githubusercontent.com/u/1528181?v=4","gravatar_id":"","url":"https://api.github.com/users/cathyxz","html_url":"https://github.com/cathyxz","followers_url":"https://api.github.com/users/cathyxz/followers","following_url":"https://api.github.com/users/cathyxz/following{/other_user}","gists_url":"https://api.github.com/users/cathyxz/gists{/gist_id}","starred_url":"https://api.github.com/users/cathyxz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cathyxz/subscriptions","organizations_url":"https://api.github.com/users/cathyxz/orgs","repos_url":"https://api.github.com/users/cathyxz/repos","events_url":"https://api.github.com/users/cathyxz/events{/privacy}","received_events_url":"https://api.github.com/users/cathyxz/received_events","type":"User","site_admin":false},"repo":{"id":108910422,"name":"amphtml","full_name":"cathyxz/amphtml","owner":{"login":"cathyxz","id":1528181,"avatar_url":"https://avatars1.githubusercontent.com/u/1528181?v=4","gravatar_id":"","url":"https://api.github.com/users/cathyxz","html_url":"https://github.com/cathyxz","followers_url":"https://api.github.com/users/cathyxz/followers","following_url":"https://api.github.com/users/cathyxz/following{/other_user}","gists_url":"https://api.github.com/users/cathyxz/gists{/gist_id}","starred_url":"https://api.github.com/users/cathyxz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cathyxz/subscriptions","organizations_url":"https://api.github.com/users/cathyxz/orgs","repos_url":"https://api.github.com/users/cathyxz/repos","events_url":"https://api.github.com/users/cathyxz/events{/privacy}","received_events_url":"https://api.github.com/users/cathyxz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cathyxz/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":true,"url":"https://api.github.com/repos/cathyxz/amphtml","forks_url":"https://api.github.com/repos/cathyxz/amphtml/forks","keys_url":"https://api.github.com/repos/cathyxz/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cathyxz/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cathyxz/amphtml/teams","hooks_url":"https://api.github.com/repos/cathyxz/amphtml/hooks","issue_events_url":"https://api.github.com/repos/cathyxz/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/cathyxz/amphtml/events","assignees_url":"https://api.github.com/repos/cathyxz/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/cathyxz/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/cathyxz/amphtml/tags","blobs_url":"https://api.github.com/repos/cathyxz/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cathyxz/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cathyxz/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/cathyxz/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cathyxz/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/cathyxz/amphtml/languages","stargazers_url":"https://api.github.com/repos/cathyxz/amphtml/stargazers","contributors_url":"https://api.github.com/repos/cathyxz/amphtml/contributors","subscribers_url":"https://api.github.com/repos/cathyxz/amphtml/subscribers","subscription_url":"https://api.github.com/repos/cathyxz/amphtml/subscription","commits_url":"https://api.github.com/repos/cathyxz/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/cathyxz/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/cathyxz/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/cathyxz/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/cathyxz/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/cathyxz/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cathyxz/amphtml/merges","archive_url":"https://api.github.com/repos/cathyxz/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cathyxz/amphtml/downloads","issues_url":"https://api.github.com/repos/cathyxz/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/cathyxz/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/cathyxz/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/cathyxz/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cathyxz/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/cathyxz/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/cathyxz/amphtml/deployments","created_at":"2017-10-30T21:27:41Z","updated_at":"2017-10-30T21:27:51Z","pushed_at":"2017-11-30T23:16:07Z","git_url":"git://github.com/cathyxz/amphtml.git","ssh_url":"git@github.com:cathyxz/amphtml.git","clone_url":"https://github.com/cathyxz/amphtml.git","svn_url":"https://github.com/cathyxz/amphtml","homepage":"https://www.ampproject.org","size":291398,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ampproject:master","ref":"master","sha":"fc0997c1002d49fe419dc23e20a70666e9015926","user":{"login":"ampproject","id":14114390,"avatar_url":"https://avatars3.githubusercontent.com/u/14114390?v=4","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"repo":{"id":41766002,"name":"amphtml","full_name":"ampproject/amphtml","owner":{"login":"ampproject","id":14114390,"avatar_url":"https://avatars3.githubusercontent.com/u/14114390?v=4","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ampproject/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":false,"url":"https://api.github.com/repos/ampproject/amphtml","forks_url":"https://api.github.com/repos/ampproject/amphtml/forks","keys_url":"https://api.github.com/repos/ampproject/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ampproject/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ampproject/amphtml/teams","hooks_url":"https://api.github.com/repos/ampproject/amphtml/hooks","issue_events_url":"https://api.github.com/repos/ampproject/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/ampproject/amphtml/events","assignees_url":"https://api.github.com/repos/ampproject/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/ampproject/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/ampproject/amphtml/tags","blobs_url":"https://api.github.com/repos/ampproject/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ampproject/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ampproject/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/ampproject/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/ampproject/amphtml/languages","stargazers_url":"https://api.github.com/repos/ampproject/amphtml/stargazers","contributors_url":"https://api.github.com/repos/ampproject/amphtml/contributors","subscribers_url":"https://api.github.com/repos/ampproject/amphtml/subscribers","subscription_url":"https://api.github.com/repos/ampproject/amphtml/subscription","commits_url":"https://api.github.com/repos/ampproject/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/ampproject/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/ampproject/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/ampproject/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/ampproject/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/ampproject/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ampproject/amphtml/merges","archive_url":"https://api.github.com/repos/ampproject/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ampproject/amphtml/downloads","issues_url":"https://api.github.com/repos/ampproject/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/ampproject/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/ampproject/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/ampproject/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ampproject/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/ampproject/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/ampproject/amphtml/deployments","created_at":"2015-09-01T22:10:53Z","updated_at":"2017-11-30T20:48:29Z","pushed_at":"2017-11-30T23:16:09Z","git_url":"git://github.com/ampproject/amphtml.git","ssh_url":"git@github.com:ampproject/amphtml.git","clone_url":"https://github.com/ampproject/amphtml.git","svn_url":"https://github.com/ampproject/amphtml","homepage":"https://www.ampproject.org","size":291442,"stargazers_count":10759,"watchers_count":10759,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":2072,"mirror_url":null,"archived":false,"open_issues_count":1143,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":2072,"open_issues":1143,"watchers":10759,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/12256"},"html":{"href":"https://github.com/ampproject/amphtml/pull/12256"},"issue":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/12256"},"comments":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/12256/comments"},"review_comments":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/12256/comments"},"review_comment":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/12256/commits"},"statuses":{"href":"https://api.github.com/repos/ampproject/amphtml/statuses/80e2a402d72f0974b68b8f95bf8c997fd44ea2e4"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"cathyxz"}}