{"action":"created","issue":{"url":"https://api.github.com/repos/angr/angr/issues/703","repository_url":"https://api.github.com/repos/angr/angr","labels_url":"https://api.github.com/repos/angr/angr/issues/703/labels{/name}","comments_url":"https://api.github.com/repos/angr/angr/issues/703/comments","events_url":"https://api.github.com/repos/angr/angr/issues/703/events","html_url":"https://github.com/angr/angr/pull/703","id":264438764,"number":703,"title":"fix issue 702","user":{"login":"XiaoyuHe","id":13704697,"avatar_url":"https://avatars3.githubusercontent.com/u/13704697?v=4","gravatar_id":"","url":"https://api.github.com/users/XiaoyuHe","html_url":"https://github.com/XiaoyuHe","followers_url":"https://api.github.com/users/XiaoyuHe/followers","following_url":"https://api.github.com/users/XiaoyuHe/following{/other_user}","gists_url":"https://api.github.com/users/XiaoyuHe/gists{/gist_id}","starred_url":"https://api.github.com/users/XiaoyuHe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/XiaoyuHe/subscriptions","organizations_url":"https://api.github.com/users/XiaoyuHe/orgs","repos_url":"https://api.github.com/users/XiaoyuHe/repos","events_url":"https://api.github.com/users/XiaoyuHe/events{/privacy}","received_events_url":"https://api.github.com/users/XiaoyuHe/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-10-11T02:39:17Z","updated_at":"2017-10-11T02:58:47Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/angr/angr/pulls/703","html_url":"https://github.com/angr/angr/pull/703","diff_url":"https://github.com/angr/angr/pull/703.diff","patch_url":"https://github.com/angr/angr/pull/703.patch"},"body":"Angr merge path's content to SimState so that it can't support LoopLimiter. This change fix it."},"comment":{"url":"https://api.github.com/repos/angr/angr/issues/comments/335667625","html_url":"https://github.com/angr/angr/pull/703#issuecomment-335667625","issue_url":"https://api.github.com/repos/angr/angr/issues/703","id":335667625,"user":{"login":"rhelmot","id":2498805,"avatar_url":"https://avatars1.githubusercontent.com/u/2498805?v=4","gravatar_id":"","url":"https://api.github.com/users/rhelmot","html_url":"https://github.com/rhelmot","followers_url":"https://api.github.com/users/rhelmot/followers","following_url":"https://api.github.com/users/rhelmot/following{/other_user}","gists_url":"https://api.github.com/users/rhelmot/gists{/gist_id}","starred_url":"https://api.github.com/users/rhelmot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhelmot/subscriptions","organizations_url":"https://api.github.com/users/rhelmot/orgs","repos_url":"https://api.github.com/users/rhelmot/repos","events_url":"https://api.github.com/users/rhelmot/events{/privacy}","received_events_url":"https://api.github.com/users/rhelmot/received_events","type":"User","site_admin":false},"created_at":"2017-10-11T02:58:47Z","updated_at":"2017-10-11T02:58:47Z","author_association":"OWNER","body":"...can you explain how it works, then?\r\n\r\n```\r\n~/angr/angr/angr% grep -r block_counter\r\npath.py:        mc = self.callstack.top.block_counter.most_common()\r\npath.py:            self.callstack.top.block_counter[state.scratch.bbl_addr] += 1\r\nstate_plugins/callstack.py:        self.block_counter = collections.Counter()\r\nstate_plugins/callstack.py:        n.block_counter = collections.Counter(self.block_counter)\r\n```\r\n\r\n`path.py` is still in the angr tree to be referenced every once in a while, but it is unused. We can see the block counter on the callstack being created and copied, but nowhere is there any code equivalent to the second line from path.py where it actually counts the blocks. How can the new system actually be working if it doesn't count blocks ever?"}}
{"actor":{"display_login":"rhelmot"}}