{"action":"created","comment":{"url":"https://api.github.com/repos/SpineEventEngine/gae-java/pulls/comments/110639484","pull_request_review_id":31824728,"id":110639484,"diff_hunk":"@@ -0,0 +1,81 @@\n+/*\n+ * Copyright 2017, TeamDev Ltd. All rights reserved.\n+ *\n+ * Redistribution and use in source and/or binary forms, with or without\n+ * modification, must retain the above copyright notice and the following\n+ * disclaimer.\n+ *\n+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS\n+ * \"AS IS\" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT\n+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR\n+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT\n+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,\n+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT\n+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,\n+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY\n+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT\n+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE\n+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.\n+ */\n+\n+package org.spine3.server.storage.datastore.dsnative;\n+\n+import com.google.common.annotations.VisibleForTesting;\n+import org.spine3.server.storage.datastore.DatastoreStorageFactory;\n+\n+import static com.google.common.base.Preconditions.checkNotNull;\n+\n+/**\n+ * A factory for the {@linkplain Namespace namespaces}, based on the current multitenancy configuration and\n+ * {@linkplain org.spine3.users.TenantId tenant ID}.\n+ *\n+ * @author Dmytro Dashenkov\n+ */\n+public abstract class NamespaceSupplier {","path":"gcd/src/main/java/org/spine3/server/storage/datastore/dsnative/NamespaceSupplier.java","position":34,"original_position":34,"commit_id":"939b0d9cd6bb8fe5c3859c3931cd43d9bc810a4a","original_commit_id":"939b0d9cd6bb8fe5c3859c3931cd43d9bc810a4a","user":{"login":"armiol","id":82468,"avatar_url":"https://avatars3.githubusercontent.com/u/82468?v=3","gravatar_id":"","url":"https://api.github.com/users/armiol","html_url":"https://github.com/armiol","followers_url":"https://api.github.com/users/armiol/followers","following_url":"https://api.github.com/users/armiol/following{/other_user}","gists_url":"https://api.github.com/users/armiol/gists{/gist_id}","starred_url":"https://api.github.com/users/armiol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/armiol/subscriptions","organizations_url":"https://api.github.com/users/armiol/orgs","repos_url":"https://api.github.com/users/armiol/repos","events_url":"https://api.github.com/users/armiol/events{/privacy}","received_events_url":"https://api.github.com/users/armiol/received_events","type":"User","site_admin":false},"body":"First of all, if it is a `Supplier`, then you should use a `Supplier` interface. \r\n\r\nSecond of all, the Javadoc should say `A supplier for the ....`.\r\n\r\nAlso, I don't really understand, why this is a `public` class. Do we expect someone like `@SPI`-user to extend it? Let's discuss.","created_at":"2017-04-10T12:18:13Z","updated_at":"2017-04-10T12:20:01Z","html_url":"https://github.com/SpineEventEngine/gae-java/pull/31#discussion_r110639484","pull_request_url":"https://api.github.com/repos/SpineEventEngine/gae-java/pulls/31","_links":{"self":{"href":"https://api.github.com/repos/SpineEventEngine/gae-java/pulls/comments/110639484"},"html":{"href":"https://github.com/SpineEventEngine/gae-java/pull/31#discussion_r110639484"},"pull_request":{"href":"https://api.github.com/repos/SpineEventEngine/gae-java/pulls/31"}}},"pull_request":{"url":"https://api.github.com/repos/SpineEventEngine/gae-java/pulls/31","id":115073961,"html_url":"https://github.com/SpineEventEngine/gae-java/pull/31","diff_url":"https://github.com/SpineEventEngine/gae-java/pull/31.diff","patch_url":"https://github.com/SpineEventEngine/gae-java/pull/31.patch","issue_url":"https://api.github.com/repos/SpineEventEngine/gae-java/issues/31","number":31,"state":"open","locked":false,"title":"Multitenancy support","user":{"login":"dmdashenkov","id":18305364,"avatar_url":"https://avatars2.githubusercontent.com/u/18305364?v=3","gravatar_id":"","url":"https://api.github.com/users/dmdashenkov","html_url":"https://github.com/dmdashenkov","followers_url":"https://api.github.com/users/dmdashenkov/followers","following_url":"https://api.github.com/users/dmdashenkov/following{/other_user}","gists_url":"https://api.github.com/users/dmdashenkov/gists{/gist_id}","starred_url":"https://api.github.com/users/dmdashenkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmdashenkov/subscriptions","organizations_url":"https://api.github.com/users/dmdashenkov/orgs","repos_url":"https://api.github.com/users/dmdashenkov/repos","events_url":"https://api.github.com/users/dmdashenkov/events{/privacy}","received_events_url":"https://api.github.com/users/dmdashenkov/received_events","type":"User","site_admin":false},"body":"Added support for _multitenant_ storage structure.\r\nThe feature is implemented on the base of the Datastore-native mechanism of _namespaces_.\r\nFor more info about the namespaces see [the official doc](https://cloud.google.com/datastore/docs/concepts/multitenancy).\r\n\r\n","created_at":"2017-04-10T10:52:59Z","updated_at":"2017-04-10T12:20:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b330b1b82aa0defb7a8a53834ebb3e036456323e","assignee":{"login":"dmdashenkov","id":18305364,"avatar_url":"https://avatars2.githubusercontent.com/u/18305364?v=3","gravatar_id":"","url":"https://api.github.com/users/dmdashenkov","html_url":"https://github.com/dmdashenkov","followers_url":"https://api.github.com/users/dmdashenkov/followers","following_url":"https://api.github.com/users/dmdashenkov/following{/other_user}","gists_url":"https://api.github.com/users/dmdashenkov/gists{/gist_id}","starred_url":"https://api.github.com/users/dmdashenkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmdashenkov/subscriptions","organizations_url":"https://api.github.com/users/dmdashenkov/orgs","repos_url":"https://api.github.com/users/dmdashenkov/repos","events_url":"https://api.github.com/users/dmdashenkov/events{/privacy}","received_events_url":"https://api.github.com/users/dmdashenkov/received_events","type":"User","site_admin":false},"assignees":[{"login":"dmdashenkov","id":18305364,"avatar_url":"https://avatars2.githubusercontent.com/u/18305364?v=3","gravatar_id":"","url":"https://api.github.com/users/dmdashenkov","html_url":"https://github.com/dmdashenkov","followers_url":"https://api.github.com/users/dmdashenkov/followers","following_url":"https://api.github.com/users/dmdashenkov/following{/other_user}","gists_url":"https://api.github.com/users/dmdashenkov/gists{/gist_id}","starred_url":"https://api.github.com/users/dmdashenkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmdashenkov/subscriptions","organizations_url":"https://api.github.com/users/dmdashenkov/orgs","repos_url":"https://api.github.com/users/dmdashenkov/repos","events_url":"https://api.github.com/users/dmdashenkov/events{/privacy}","received_events_url":"https://api.github.com/users/dmdashenkov/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/SpineEventEngine/gae-java/pulls/31/commits","review_comments_url":"https://api.github.com/repos/SpineEventEngine/gae-java/pulls/31/comments","review_comment_url":"https://api.github.com/repos/SpineEventEngine/gae-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SpineEventEngine/gae-java/issues/31/comments","statuses_url":"https://api.github.com/repos/SpineEventEngine/gae-java/statuses/939b0d9cd6bb8fe5c3859c3931cd43d9bc810a4a","head":{"label":"SpineEventEngine:native-multitenancy","ref":"native-multitenancy","sha":"939b0d9cd6bb8fe5c3859c3931cd43d9bc810a4a","user":{"login":"SpineEventEngine","id":12821626,"avatar_url":"https://avatars0.githubusercontent.com/u/12821626?v=3","gravatar_id":"","url":"https://api.github.com/users/SpineEventEngine","html_url":"https://github.com/SpineEventEngine","followers_url":"https://api.github.com/users/SpineEventEngine/followers","following_url":"https://api.github.com/users/SpineEventEngine/following{/other_user}","gists_url":"https://api.github.com/users/SpineEventEngine/gists{/gist_id}","starred_url":"https://api.github.com/users/SpineEventEngine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpineEventEngine/subscriptions","organizations_url":"https://api.github.com/users/SpineEventEngine/orgs","repos_url":"https://api.github.com/users/SpineEventEngine/repos","events_url":"https://api.github.com/users/SpineEventEngine/events{/privacy}","received_events_url":"https://api.github.com/users/SpineEventEngine/received_events","type":"Organization","site_admin":false},"repo":{"id":46358716,"name":"gae-java","full_name":"SpineEventEngine/gae-java","owner":{"login":"SpineEventEngine","id":12821626,"avatar_url":"https://avatars0.githubusercontent.com/u/12821626?v=3","gravatar_id":"","url":"https://api.github.com/users/SpineEventEngine","html_url":"https://github.com/SpineEventEngine","followers_url":"https://api.github.com/users/SpineEventEngine/followers","following_url":"https://api.github.com/users/SpineEventEngine/following{/other_user}","gists_url":"https://api.github.com/users/SpineEventEngine/gists{/gist_id}","starred_url":"https://api.github.com/users/SpineEventEngine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpineEventEngine/subscriptions","organizations_url":"https://api.github.com/users/SpineEventEngine/orgs","repos_url":"https://api.github.com/users/SpineEventEngine/repos","events_url":"https://api.github.com/users/SpineEventEngine/events{/privacy}","received_events_url":"https://api.github.com/users/SpineEventEngine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SpineEventEngine/gae-java","description":"Support for Spine-based Java apps running under Google App Engine","fork":false,"url":"https://api.github.com/repos/SpineEventEngine/gae-java","forks_url":"https://api.github.com/repos/SpineEventEngine/gae-java/forks","keys_url":"https://api.github.com/repos/SpineEventEngine/gae-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SpineEventEngine/gae-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SpineEventEngine/gae-java/teams","hooks_url":"https://api.github.com/repos/SpineEventEngine/gae-java/hooks","issue_events_url":"https://api.github.com/repos/SpineEventEngine/gae-java/issues/events{/number}","events_url":"https://api.github.com/repos/SpineEventEngine/gae-java/events","assignees_url":"https://api.github.com/repos/SpineEventEngine/gae-java/assignees{/user}","branches_url":"https://api.github.com/repos/SpineEventEngine/gae-java/branches{/branch}","tags_url":"https://api.github.com/repos/SpineEventEngine/gae-java/tags","blobs_url":"https://api.github.com/repos/SpineEventEngine/gae-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SpineEventEngine/gae-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SpineEventEngine/gae-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/SpineEventEngine/gae-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SpineEventEngine/gae-java/statuses/{sha}","languages_url":"https://api.github.com/repos/SpineEventEngine/gae-java/languages","stargazers_url":"https://api.github.com/repos/SpineEventEngine/gae-java/stargazers","contributors_url":"https://api.github.com/repos/SpineEventEngine/gae-java/contributors","subscribers_url":"https://api.github.com/repos/SpineEventEngine/gae-java/subscribers","subscription_url":"https://api.github.com/repos/SpineEventEngine/gae-java/subscription","commits_url":"https://api.github.com/repos/SpineEventEngine/gae-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/SpineEventEngine/gae-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/SpineEventEngine/gae-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/SpineEventEngine/gae-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/SpineEventEngine/gae-java/contents/{+path}","compare_url":"https://api.github.com/repos/SpineEventEngine/gae-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SpineEventEngine/gae-java/merges","archive_url":"https://api.github.com/repos/SpineEventEngine/gae-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SpineEventEngine/gae-java/downloads","issues_url":"https://api.github.com/repos/SpineEventEngine/gae-java/issues{/number}","pulls_url":"https://api.github.com/repos/SpineEventEngine/gae-java/pulls{/number}","milestones_url":"https://api.github.com/repos/SpineEventEngine/gae-java/milestones{/number}","notifications_url":"https://api.github.com/repos/SpineEventEngine/gae-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SpineEventEngine/gae-java/labels{/name}","releases_url":"https://api.github.com/repos/SpineEventEngine/gae-java/releases{/id}","deployments_url":"https://api.github.com/repos/SpineEventEngine/gae-java/deployments","created_at":"2015-11-17T16:08:56Z","updated_at":"2016-04-26T16:15:52Z","pushed_at":"2017-04-10T12:09:29Z","git_url":"git://github.com/SpineEventEngine/gae-java.git","ssh_url":"git@github.com:SpineEventEngine/gae-java.git","clone_url":"https://github.com/SpineEventEngine/gae-java.git","svn_url":"https://github.com/SpineEventEngine/gae-java","homepage":null,"size":832,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":6,"forks":1,"open_issues":6,"watchers":0,"default_branch":"master"}},"base":{"label":"SpineEventEngine:entity-storage-fields","ref":"entity-storage-fields","sha":"688021f5004204809812a8ce815251489067e37a","user":{"login":"SpineEventEngine","id":12821626,"avatar_url":"https://avatars0.githubusercontent.com/u/12821626?v=3","gravatar_id":"","url":"https://api.github.com/users/SpineEventEngine","html_url":"https://github.com/SpineEventEngine","followers_url":"https://api.github.com/users/SpineEventEngine/followers","following_url":"https://api.github.com/users/SpineEventEngine/following{/other_user}","gists_url":"https://api.github.com/users/SpineEventEngine/gists{/gist_id}","starred_url":"https://api.github.com/users/SpineEventEngine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpineEventEngine/subscriptions","organizations_url":"https://api.github.com/users/SpineEventEngine/orgs","repos_url":"https://api.github.com/users/SpineEventEngine/repos","events_url":"https://api.github.com/users/SpineEventEngine/events{/privacy}","received_events_url":"https://api.github.com/users/SpineEventEngine/received_events","type":"Organization","site_admin":false},"repo":{"id":46358716,"name":"gae-java","full_name":"SpineEventEngine/gae-java","owner":{"login":"SpineEventEngine","id":12821626,"avatar_url":"https://avatars0.githubusercontent.com/u/12821626?v=3","gravatar_id":"","url":"https://api.github.com/users/SpineEventEngine","html_url":"https://github.com/SpineEventEngine","followers_url":"https://api.github.com/users/SpineEventEngine/followers","following_url":"https://api.github.com/users/SpineEventEngine/following{/other_user}","gists_url":"https://api.github.com/users/SpineEventEngine/gists{/gist_id}","starred_url":"https://api.github.com/users/SpineEventEngine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpineEventEngine/subscriptions","organizations_url":"https://api.github.com/users/SpineEventEngine/orgs","repos_url":"https://api.github.com/users/SpineEventEngine/repos","events_url":"https://api.github.com/users/SpineEventEngine/events{/privacy}","received_events_url":"https://api.github.com/users/SpineEventEngine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SpineEventEngine/gae-java","description":"Support for Spine-based Java apps running under Google App Engine","fork":false,"url":"https://api.github.com/repos/SpineEventEngine/gae-java","forks_url":"https://api.github.com/repos/SpineEventEngine/gae-java/forks","keys_url":"https://api.github.com/repos/SpineEventEngine/gae-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SpineEventEngine/gae-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SpineEventEngine/gae-java/teams","hooks_url":"https://api.github.com/repos/SpineEventEngine/gae-java/hooks","issue_events_url":"https://api.github.com/repos/SpineEventEngine/gae-java/issues/events{/number}","events_url":"https://api.github.com/repos/SpineEventEngine/gae-java/events","assignees_url":"https://api.github.com/repos/SpineEventEngine/gae-java/assignees{/user}","branches_url":"https://api.github.com/repos/SpineEventEngine/gae-java/branches{/branch}","tags_url":"https://api.github.com/repos/SpineEventEngine/gae-java/tags","blobs_url":"https://api.github.com/repos/SpineEventEngine/gae-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SpineEventEngine/gae-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SpineEventEngine/gae-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/SpineEventEngine/gae-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SpineEventEngine/gae-java/statuses/{sha}","languages_url":"https://api.github.com/repos/SpineEventEngine/gae-java/languages","stargazers_url":"https://api.github.com/repos/SpineEventEngine/gae-java/stargazers","contributors_url":"https://api.github.com/repos/SpineEventEngine/gae-java/contributors","subscribers_url":"https://api.github.com/repos/SpineEventEngine/gae-java/subscribers","subscription_url":"https://api.github.com/repos/SpineEventEngine/gae-java/subscription","commits_url":"https://api.github.com/repos/SpineEventEngine/gae-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/SpineEventEngine/gae-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/SpineEventEngine/gae-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/SpineEventEngine/gae-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/SpineEventEngine/gae-java/contents/{+path}","compare_url":"https://api.github.com/repos/SpineEventEngine/gae-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SpineEventEngine/gae-java/merges","archive_url":"https://api.github.com/repos/SpineEventEngine/gae-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SpineEventEngine/gae-java/downloads","issues_url":"https://api.github.com/repos/SpineEventEngine/gae-java/issues{/number}","pulls_url":"https://api.github.com/repos/SpineEventEngine/gae-java/pulls{/number}","milestones_url":"https://api.github.com/repos/SpineEventEngine/gae-java/milestones{/number}","notifications_url":"https://api.github.com/repos/SpineEventEngine/gae-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SpineEventEngine/gae-java/labels{/name}","releases_url":"https://api.github.com/repos/SpineEventEngine/gae-java/releases{/id}","deployments_url":"https://api.github.com/repos/SpineEventEngine/gae-java/deployments","created_at":"2015-11-17T16:08:56Z","updated_at":"2016-04-26T16:15:52Z","pushed_at":"2017-04-10T12:09:29Z","git_url":"git://github.com/SpineEventEngine/gae-java.git","ssh_url":"git@github.com:SpineEventEngine/gae-java.git","clone_url":"https://github.com/SpineEventEngine/gae-java.git","svn_url":"https://github.com/SpineEventEngine/gae-java","homepage":null,"size":832,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":6,"forks":1,"open_issues":6,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SpineEventEngine/gae-java/pulls/31"},"html":{"href":"https://github.com/SpineEventEngine/gae-java/pull/31"},"issue":{"href":"https://api.github.com/repos/SpineEventEngine/gae-java/issues/31"},"comments":{"href":"https://api.github.com/repos/SpineEventEngine/gae-java/issues/31/comments"},"review_comments":{"href":"https://api.github.com/repos/SpineEventEngine/gae-java/pulls/31/comments"},"review_comment":{"href":"https://api.github.com/repos/SpineEventEngine/gae-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SpineEventEngine/gae-java/pulls/31/commits"},"statuses":{"href":"https://api.github.com/repos/SpineEventEngine/gae-java/statuses/939b0d9cd6bb8fe5c3859c3931cd43d9bc810a4a"}}}}
{"actor":{"display_login":"armiol"}}