{"action":"created","comment":{"url":"https://api.github.com/repos/ceph/ceph/pulls/comments/137725146","pull_request_review_id":61429770,"id":137725146,"diff_hunk":"@@ -520,7 +520,7 @@ void KernelDevice::aio_submit(IOContext *ioc)\n   void *priv = static_cast<void*>(ioc);\n   int r, retries = 0;\n   r = aio_queue.submit_batch(ioc->running_aios.begin(), e, \n-\t\t\t     ioc->num_running.load(), priv, &retries);\n+\t\t\t     pending, priv, &retries);","path":"src/os/bluestore/KernelDevice.cc","position":5,"original_position":5,"commit_id":"a3762f5c05ebfbc3eee33095e46cd7ec21eb741c","original_commit_id":"a3762f5c05ebfbc3eee33095e46cd7ec21eb741c","user":{"login":"liupan1111","id":17977187,"avatar_url":"https://avatars3.githubusercontent.com/u/17977187?v=4","gravatar_id":"","url":"https://api.github.com/users/liupan1111","html_url":"https://github.com/liupan1111","followers_url":"https://api.github.com/users/liupan1111/followers","following_url":"https://api.github.com/users/liupan1111/following{/other_user}","gists_url":"https://api.github.com/users/liupan1111/gists{/gist_id}","starred_url":"https://api.github.com/users/liupan1111/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liupan1111/subscriptions","organizations_url":"https://api.github.com/users/liupan1111/orgs","repos_url":"https://api.github.com/users/liupan1111/repos","events_url":"https://api.github.com/users/liupan1111/events{/privacy}","received_events_url":"https://api.github.com/users/liupan1111/received_events","type":"User","site_admin":false},"body":"do you really meet this case during test?","created_at":"2017-09-08T07:28:01Z","updated_at":"2017-09-08T07:28:01Z","html_url":"https://github.com/ceph/ceph/pull/17588#discussion_r137725146","pull_request_url":"https://api.github.com/repos/ceph/ceph/pulls/17588","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments/137725146"},"html":{"href":"https://github.com/ceph/ceph/pull/17588#discussion_r137725146"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph/pulls/17588"}},"in_reply_to_id":137712507},"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/17588","id":139952535,"html_url":"https://github.com/ceph/ceph/pull/17588","diff_url":"https://github.com/ceph/ceph/pull/17588.diff","patch_url":"https://github.com/ceph/ceph/pull/17588.patch","issue_url":"https://api.github.com/repos/ceph/ceph/issues/17588","number":17588,"state":"open","locked":false,"title":"os/bluestore: shrink aio submit size to pending value","user":{"login":"kungf","id":24663329,"avatar_url":"https://avatars0.githubusercontent.com/u/24663329?v=4","gravatar_id":"","url":"https://api.github.com/users/kungf","html_url":"https://github.com/kungf","followers_url":"https://api.github.com/users/kungf/followers","following_url":"https://api.github.com/users/kungf/following{/other_user}","gists_url":"https://api.github.com/users/kungf/gists{/gist_id}","starred_url":"https://api.github.com/users/kungf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kungf/subscriptions","organizations_url":"https://api.github.com/users/kungf/orgs","repos_url":"https://api.github.com/users/kungf/repos","events_url":"https://api.github.com/users/kungf/events{/privacy}","received_events_url":"https://api.github.com/users/kungf/received_events","type":"User","site_admin":false},"body":"running_aios size may be very large in high work load, because we only submit pending aios, so we better apply pending aios size array in aio_queue_t::submit_batch.\r\n@yangdongsheng \r\n\r\n@liewegas need a review,please","created_at":"2017-09-08T04:19:15Z","updated_at":"2017-09-08T07:28:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fc219ed47d5622bb400bf924d841ff19ef938407","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph/pulls/17588/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph/pulls/17588/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/17588/comments","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/a3762f5c05ebfbc3eee33095e46cd7ec21eb741c","head":{"label":"kungf:aio_submit_size_change","ref":"aio_submit_size_change","sha":"a3762f5c05ebfbc3eee33095e46cd7ec21eb741c","user":{"login":"kungf","id":24663329,"avatar_url":"https://avatars0.githubusercontent.com/u/24663329?v=4","gravatar_id":"","url":"https://api.github.com/users/kungf","html_url":"https://github.com/kungf","followers_url":"https://api.github.com/users/kungf/followers","following_url":"https://api.github.com/users/kungf/following{/other_user}","gists_url":"https://api.github.com/users/kungf/gists{/gist_id}","starred_url":"https://api.github.com/users/kungf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kungf/subscriptions","organizations_url":"https://api.github.com/users/kungf/orgs","repos_url":"https://api.github.com/users/kungf/repos","events_url":"https://api.github.com/users/kungf/events{/privacy}","received_events_url":"https://api.github.com/users/kungf/received_events","type":"User","site_admin":false},"repo":{"id":92258802,"name":"ceph","full_name":"kungf/ceph","owner":{"login":"kungf","id":24663329,"avatar_url":"https://avatars0.githubusercontent.com/u/24663329?v=4","gravatar_id":"","url":"https://api.github.com/users/kungf","html_url":"https://github.com/kungf","followers_url":"https://api.github.com/users/kungf/followers","following_url":"https://api.github.com/users/kungf/following{/other_user}","gists_url":"https://api.github.com/users/kungf/gists{/gist_id}","starred_url":"https://api.github.com/users/kungf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kungf/subscriptions","organizations_url":"https://api.github.com/users/kungf/orgs","repos_url":"https://api.github.com/users/kungf/repos","events_url":"https://api.github.com/users/kungf/events{/privacy}","received_events_url":"https://api.github.com/users/kungf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kungf/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":true,"url":"https://api.github.com/repos/kungf/ceph","forks_url":"https://api.github.com/repos/kungf/ceph/forks","keys_url":"https://api.github.com/repos/kungf/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kungf/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kungf/ceph/teams","hooks_url":"https://api.github.com/repos/kungf/ceph/hooks","issue_events_url":"https://api.github.com/repos/kungf/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/kungf/ceph/events","assignees_url":"https://api.github.com/repos/kungf/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/kungf/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/kungf/ceph/tags","blobs_url":"https://api.github.com/repos/kungf/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kungf/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kungf/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/kungf/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kungf/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/kungf/ceph/languages","stargazers_url":"https://api.github.com/repos/kungf/ceph/stargazers","contributors_url":"https://api.github.com/repos/kungf/ceph/contributors","subscribers_url":"https://api.github.com/repos/kungf/ceph/subscribers","subscription_url":"https://api.github.com/repos/kungf/ceph/subscription","commits_url":"https://api.github.com/repos/kungf/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/kungf/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/kungf/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/kungf/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/kungf/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/kungf/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kungf/ceph/merges","archive_url":"https://api.github.com/repos/kungf/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kungf/ceph/downloads","issues_url":"https://api.github.com/repos/kungf/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/kungf/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/kungf/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/kungf/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kungf/ceph/labels{/name}","releases_url":"https://api.github.com/repos/kungf/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/kungf/ceph/deployments","created_at":"2017-05-24T06:39:08Z","updated_at":"2017-05-24T06:39:35Z","pushed_at":"2017-09-08T04:12:53Z","git_url":"git://github.com/kungf/ceph.git","ssh_url":"git@github.com:kungf/ceph.git","clone_url":"https://github.com/kungf/ceph.git","svn_url":"https://github.com/kungf/ceph","homepage":"http://ceph.com","size":236631,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"594b736228040aae5e9f5c8d7988194b929285b7","user":{"login":"ceph","id":1015767,"avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":2310495,"name":"ceph","full_name":"ceph/ceph","owner":{"login":"ceph","id":1015767,"avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":false,"url":"https://api.github.com/repos/ceph/ceph","forks_url":"https://api.github.com/repos/ceph/ceph/forks","keys_url":"https://api.github.com/repos/ceph/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph/teams","hooks_url":"https://api.github.com/repos/ceph/ceph/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph/events","assignees_url":"https://api.github.com/repos/ceph/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph/tags","blobs_url":"https://api.github.com/repos/ceph/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph/subscription","commits_url":"https://api.github.com/repos/ceph/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph/merges","archive_url":"https://api.github.com/repos/ceph/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph/downloads","issues_url":"https://api.github.com/repos/ceph/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph/deployments","created_at":"2011-09-01T21:41:26Z","updated_at":"2017-09-08T06:32:25Z","pushed_at":"2017-09-08T07:17:39Z","git_url":"git://github.com/ceph/ceph.git","ssh_url":"git@github.com:ceph/ceph.git","clone_url":"https://github.com/ceph/ceph.git","svn_url":"https://github.com/ceph/ceph","homepage":"http://ceph.com","size":240467,"stargazers_count":3596,"watchers_count":3596,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2077,"mirror_url":null,"open_issues_count":515,"forks":2077,"open_issues":515,"watchers":3596,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/17588"},"html":{"href":"https://github.com/ceph/ceph/pull/17588"},"issue":{"href":"https://api.github.com/repos/ceph/ceph/issues/17588"},"comments":{"href":"https://api.github.com/repos/ceph/ceph/issues/17588/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph/pulls/17588/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph/pulls/17588/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph/statuses/a3762f5c05ebfbc3eee33095e46cd7ec21eb741c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"liupan1111"}}