{"action":"created","issue":{"url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/issues/840","repository_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn","labels_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/issues/840/labels{/name}","comments_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/issues/840/comments","events_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/issues/840/events","html_url":"https://github.com/OmniSharp/omnisharp-roslyn/pull/840","id":225323543,"number":840,"title":"Use CompletionService in IntellisenseService","user":{"login":"filipw","id":1710369,"avatar_url":"https://avatars3.githubusercontent.com/u/1710369?v=3","gravatar_id":"","url":"https://api.github.com/users/filipw","html_url":"https://github.com/filipw","followers_url":"https://api.github.com/users/filipw/followers","following_url":"https://api.github.com/users/filipw/following{/other_user}","gists_url":"https://api.github.com/users/filipw/gists{/gist_id}","starred_url":"https://api.github.com/users/filipw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/filipw/subscriptions","organizations_url":"https://api.github.com/users/filipw/orgs","repos_url":"https://api.github.com/users/filipw/repos","events_url":"https://api.github.com/users/filipw/events{/privacy}","received_events_url":"https://api.github.com/users/filipw/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-04-30T12:18:34Z","updated_at":"2017-05-03T16:29:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/pulls/840","html_url":"https://github.com/OmniSharp/omnisharp-roslyn/pull/840","diff_url":"https://github.com/OmniSharp/omnisharp-roslyn/pull/840.diff","patch_url":"https://github.com/OmniSharp/omnisharp-roslyn/pull/840.patch"},"body":"At the moment, the `CompletionService` is only used for keywords, everything else is coming from `Recommender`.\r\n\r\nThis PR introduces relying on `CompletionService` for all completions. \r\nThe symbols are still processed the same way as before, so none of the existing features are broken, but extra features available via  `CompletionService` also show up in intellisense now (as we process all of its providers). \r\nThis will close a lot of open bugs via a relatively risk-free change.\r\n\r\nI will push some tests into this soon but here are some of the examples of new features that are introduced via this PR:\r\n\r\n### Attribute completion without `Attribute`\r\n\r\n![](http://g.recordit.co/vLcYpfBvaQ.gif)\r\n\r\n### Cref completion\r\n\r\n![](http://g.recordit.co/2p4SBA2o0w.gif)\r\n\r\n### Object initializer members completion\r\n\r\n![](http://g.recordit.co/ICVvMsNAQL.gif)\r\n\r\n### Named parameters completion\r\n\r\n![](http://g.recordit.co/lUGF9eVGwb.gif)\r\n\r\n### Override support\r\n\r\nNote: because of [this Regex](https://github.com/OmniSharp/omnisharp-vscode/blob/634261f9911c29148347325f2e528bfcfc62999a/src/features/completionItemProvider.ts#L43) in omnisharp-vscode, where brackets are removed, it appears a little broken. This change would need to be done in omnisharp-vscode.\r\n\r\n![](http://g.recordit.co/ooTFJrMXfi.gif)"},"comment":{"url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/issues/comments/298963934","html_url":"https://github.com/OmniSharp/omnisharp-roslyn/pull/840#issuecomment-298963934","issue_url":"https://api.github.com/repos/OmniSharp/omnisharp-roslyn/issues/840","id":298963934,"user":{"login":"DustinCampbell","id":116161,"avatar_url":"https://avatars3.githubusercontent.com/u/116161?v=3","gravatar_id":"","url":"https://api.github.com/users/DustinCampbell","html_url":"https://github.com/DustinCampbell","followers_url":"https://api.github.com/users/DustinCampbell/followers","following_url":"https://api.github.com/users/DustinCampbell/following{/other_user}","gists_url":"https://api.github.com/users/DustinCampbell/gists{/gist_id}","starred_url":"https://api.github.com/users/DustinCampbell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DustinCampbell/subscriptions","organizations_url":"https://api.github.com/users/DustinCampbell/orgs","repos_url":"https://api.github.com/users/DustinCampbell/repos","events_url":"https://api.github.com/users/DustinCampbell/events{/privacy}","received_events_url":"https://api.github.com/users/DustinCampbell/received_events","type":"User","site_admin":false},"created_at":"2017-05-03T16:29:44Z","updated_at":"2017-05-03T16:29:44Z","body":"> Note: because of this Regex in omnisharp-vscode, where brackets are removed, it appears a little broken. This change would need to be done in omnisharp-vscode.\r\n\r\nFWIW, I've never noticed that regex. It existed before I was on the project, so it's presence is a mystery."}}
{"actor":{"display_login":"DustinCampbell"}}