{"action":"closed","number":1743,"pull_request":{"url":"https://api.github.com/repos/appcelerator/amp/pulls/1743","id":149657564,"html_url":"https://github.com/appcelerator/amp/pull/1743","diff_url":"https://github.com/appcelerator/amp/pull/1743.diff","patch_url":"https://github.com/appcelerator/amp/pull/1743.patch","issue_url":"https://api.github.com/repos/appcelerator/amp/issues/1743","number":1743,"state":"closed","locked":false,"title":"amp cluster rm doesn't error on successful removal","user":{"login":"ndegory","id":11839374,"avatar_url":"https://avatars0.githubusercontent.com/u/11839374?v=4","gravatar_id":"","url":"https://api.github.com/users/ndegory","html_url":"https://github.com/ndegory","followers_url":"https://api.github.com/users/ndegory/followers","following_url":"https://api.github.com/users/ndegory/following{/other_user}","gists_url":"https://api.github.com/users/ndegory/gists{/gist_id}","starred_url":"https://api.github.com/users/ndegory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndegory/subscriptions","organizations_url":"https://api.github.com/users/ndegory/orgs","repos_url":"https://api.github.com/users/ndegory/repos","events_url":"https://api.github.com/users/ndegory/events{/privacy}","received_events_url":"https://api.github.com/users/ndegory/received_events","type":"User","site_admin":false},"body":"Fix #1740 \r\n\r\n## Verification\r\n```\r\n$ amp cluster create --provider aws --aws-region us-west-2 --aws-stackname STACK_NAME --aws-parameter KeyName=KEY_NAME --aws-parameter UserWorkerSize=1 --aws-parameter CoreWorkerSize=1 --aws-parameter ManagerSize=1  --aws-sync\r\n[...]\r\n$ amp cluster destroy --provider aws --aws-region us-west-2 --aws-stackname STACK_NAME --aws-sync\r\n[user xxx @ localhost:50101]\r\nMon Oct 30 22:45:49 UTC 2017    STACK_NAME           CREATE_IN_PROGRESS (User Initiated)\r\nMon Oct 30 22:45:55 UTC 2017    STACK_NAME           DELETE_IN_PROGRESS (User Initiated)\r\nMon Oct 30 22:45:56 UTC 2017    Vpc                  CREATE_FAILED (Resource creation cancelled)\r\nMon Oct 30 22:46:15 UTC 2017    Vpc                  DELETE_IN_PROGRESS\r\nMon Oct 30 22:46:52 UTC 2017    STACK_NAME           DELETE_COMPLETE\r\n$ echo $?\r\n0\r\n```","created_at":"2017-10-30T22:52:51Z","updated_at":"2017-11-01T12:47:30Z","closed_at":"2017-11-01T12:47:30Z","merged_at":"2017-11-01T12:47:29Z","merge_commit_sha":"65ecdbdda7afe0c6d49e002c4049359e06ba1861","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/appcelerator/amp/pulls/1743/commits","review_comments_url":"https://api.github.com/repos/appcelerator/amp/pulls/1743/comments","review_comment_url":"https://api.github.com/repos/appcelerator/amp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/appcelerator/amp/issues/1743/comments","statuses_url":"https://api.github.com/repos/appcelerator/amp/statuses/31994f75a9ff13e91d69b991be2d8af9f7cd2283","head":{"label":"ndegory:1740-aws-destroy","ref":"1740-aws-destroy","sha":"31994f75a9ff13e91d69b991be2d8af9f7cd2283","user":{"login":"ndegory","id":11839374,"avatar_url":"https://avatars0.githubusercontent.com/u/11839374?v=4","gravatar_id":"","url":"https://api.github.com/users/ndegory","html_url":"https://github.com/ndegory","followers_url":"https://api.github.com/users/ndegory/followers","following_url":"https://api.github.com/users/ndegory/following{/other_user}","gists_url":"https://api.github.com/users/ndegory/gists{/gist_id}","starred_url":"https://api.github.com/users/ndegory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndegory/subscriptions","organizations_url":"https://api.github.com/users/ndegory/orgs","repos_url":"https://api.github.com/users/ndegory/repos","events_url":"https://api.github.com/users/ndegory/events{/privacy}","received_events_url":"https://api.github.com/users/ndegory/received_events","type":"User","site_admin":false},"repo":{"id":99716556,"name":"amp","full_name":"ndegory/amp","owner":{"login":"ndegory","id":11839374,"avatar_url":"https://avatars0.githubusercontent.com/u/11839374?v=4","gravatar_id":"","url":"https://api.github.com/users/ndegory","html_url":"https://github.com/ndegory","followers_url":"https://api.github.com/users/ndegory/followers","following_url":"https://api.github.com/users/ndegory/following{/other_user}","gists_url":"https://api.github.com/users/ndegory/gists{/gist_id}","starred_url":"https://api.github.com/users/ndegory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndegory/subscriptions","organizations_url":"https://api.github.com/users/ndegory/orgs","repos_url":"https://api.github.com/users/ndegory/repos","events_url":"https://api.github.com/users/ndegory/events{/privacy}","received_events_url":"https://api.github.com/users/ndegory/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ndegory/amp","description":"An open source CaaS for Docker, batteries included.","fork":true,"url":"https://api.github.com/repos/ndegory/amp","forks_url":"https://api.github.com/repos/ndegory/amp/forks","keys_url":"https://api.github.com/repos/ndegory/amp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ndegory/amp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ndegory/amp/teams","hooks_url":"https://api.github.com/repos/ndegory/amp/hooks","issue_events_url":"https://api.github.com/repos/ndegory/amp/issues/events{/number}","events_url":"https://api.github.com/repos/ndegory/amp/events","assignees_url":"https://api.github.com/repos/ndegory/amp/assignees{/user}","branches_url":"https://api.github.com/repos/ndegory/amp/branches{/branch}","tags_url":"https://api.github.com/repos/ndegory/amp/tags","blobs_url":"https://api.github.com/repos/ndegory/amp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ndegory/amp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ndegory/amp/git/refs{/sha}","trees_url":"https://api.github.com/repos/ndegory/amp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ndegory/amp/statuses/{sha}","languages_url":"https://api.github.com/repos/ndegory/amp/languages","stargazers_url":"https://api.github.com/repos/ndegory/amp/stargazers","contributors_url":"https://api.github.com/repos/ndegory/amp/contributors","subscribers_url":"https://api.github.com/repos/ndegory/amp/subscribers","subscription_url":"https://api.github.com/repos/ndegory/amp/subscription","commits_url":"https://api.github.com/repos/ndegory/amp/commits{/sha}","git_commits_url":"https://api.github.com/repos/ndegory/amp/git/commits{/sha}","comments_url":"https://api.github.com/repos/ndegory/amp/comments{/number}","issue_comment_url":"https://api.github.com/repos/ndegory/amp/issues/comments{/number}","contents_url":"https://api.github.com/repos/ndegory/amp/contents/{+path}","compare_url":"https://api.github.com/repos/ndegory/amp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ndegory/amp/merges","archive_url":"https://api.github.com/repos/ndegory/amp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ndegory/amp/downloads","issues_url":"https://api.github.com/repos/ndegory/amp/issues{/number}","pulls_url":"https://api.github.com/repos/ndegory/amp/pulls{/number}","milestones_url":"https://api.github.com/repos/ndegory/amp/milestones{/number}","notifications_url":"https://api.github.com/repos/ndegory/amp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ndegory/amp/labels{/name}","releases_url":"https://api.github.com/repos/ndegory/amp/releases{/id}","deployments_url":"https://api.github.com/repos/ndegory/amp/deployments","created_at":"2017-08-08T17:01:02Z","updated_at":"2017-08-08T17:01:07Z","pushed_at":"2017-10-30T22:48:19Z","git_url":"git://github.com/ndegory/amp.git","ssh_url":"git@github.com:ndegory/amp.git","clone_url":"https://github.com/ndegory/amp.git","svn_url":"https://github.com/ndegory/amp","homepage":"http://appcelerator.io","size":206133,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"appcelerator:master","ref":"master","sha":"e2dc950ec49428544a19277186cb1503500fdb85","user":{"login":"appcelerator","id":82188,"avatar_url":"https://avatars3.githubusercontent.com/u/82188?v=4","gravatar_id":"","url":"https://api.github.com/users/appcelerator","html_url":"https://github.com/appcelerator","followers_url":"https://api.github.com/users/appcelerator/followers","following_url":"https://api.github.com/users/appcelerator/following{/other_user}","gists_url":"https://api.github.com/users/appcelerator/gists{/gist_id}","starred_url":"https://api.github.com/users/appcelerator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appcelerator/subscriptions","organizations_url":"https://api.github.com/users/appcelerator/orgs","repos_url":"https://api.github.com/users/appcelerator/repos","events_url":"https://api.github.com/users/appcelerator/events{/privacy}","received_events_url":"https://api.github.com/users/appcelerator/received_events","type":"Organization","site_admin":false},"repo":{"id":61302197,"name":"amp","full_name":"appcelerator/amp","owner":{"login":"appcelerator","id":82188,"avatar_url":"https://avatars3.githubusercontent.com/u/82188?v=4","gravatar_id":"","url":"https://api.github.com/users/appcelerator","html_url":"https://github.com/appcelerator","followers_url":"https://api.github.com/users/appcelerator/followers","following_url":"https://api.github.com/users/appcelerator/following{/other_user}","gists_url":"https://api.github.com/users/appcelerator/gists{/gist_id}","starred_url":"https://api.github.com/users/appcelerator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appcelerator/subscriptions","organizations_url":"https://api.github.com/users/appcelerator/orgs","repos_url":"https://api.github.com/users/appcelerator/repos","events_url":"https://api.github.com/users/appcelerator/events{/privacy}","received_events_url":"https://api.github.com/users/appcelerator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/appcelerator/amp","description":"An open source CaaS for Docker, batteries included.","fork":false,"url":"https://api.github.com/repos/appcelerator/amp","forks_url":"https://api.github.com/repos/appcelerator/amp/forks","keys_url":"https://api.github.com/repos/appcelerator/amp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/appcelerator/amp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/appcelerator/amp/teams","hooks_url":"https://api.github.com/repos/appcelerator/amp/hooks","issue_events_url":"https://api.github.com/repos/appcelerator/amp/issues/events{/number}","events_url":"https://api.github.com/repos/appcelerator/amp/events","assignees_url":"https://api.github.com/repos/appcelerator/amp/assignees{/user}","branches_url":"https://api.github.com/repos/appcelerator/amp/branches{/branch}","tags_url":"https://api.github.com/repos/appcelerator/amp/tags","blobs_url":"https://api.github.com/repos/appcelerator/amp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/appcelerator/amp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/appcelerator/amp/git/refs{/sha}","trees_url":"https://api.github.com/repos/appcelerator/amp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/appcelerator/amp/statuses/{sha}","languages_url":"https://api.github.com/repos/appcelerator/amp/languages","stargazers_url":"https://api.github.com/repos/appcelerator/amp/stargazers","contributors_url":"https://api.github.com/repos/appcelerator/amp/contributors","subscribers_url":"https://api.github.com/repos/appcelerator/amp/subscribers","subscription_url":"https://api.github.com/repos/appcelerator/amp/subscription","commits_url":"https://api.github.com/repos/appcelerator/amp/commits{/sha}","git_commits_url":"https://api.github.com/repos/appcelerator/amp/git/commits{/sha}","comments_url":"https://api.github.com/repos/appcelerator/amp/comments{/number}","issue_comment_url":"https://api.github.com/repos/appcelerator/amp/issues/comments{/number}","contents_url":"https://api.github.com/repos/appcelerator/amp/contents/{+path}","compare_url":"https://api.github.com/repos/appcelerator/amp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/appcelerator/amp/merges","archive_url":"https://api.github.com/repos/appcelerator/amp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/appcelerator/amp/downloads","issues_url":"https://api.github.com/repos/appcelerator/amp/issues{/number}","pulls_url":"https://api.github.com/repos/appcelerator/amp/pulls{/number}","milestones_url":"https://api.github.com/repos/appcelerator/amp/milestones{/number}","notifications_url":"https://api.github.com/repos/appcelerator/amp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/appcelerator/amp/labels{/name}","releases_url":"https://api.github.com/repos/appcelerator/amp/releases{/id}","deployments_url":"https://api.github.com/repos/appcelerator/amp/deployments","created_at":"2016-06-16T14:49:30Z","updated_at":"2017-10-29T18:16:14Z","pushed_at":"2017-11-01T12:47:29Z","git_url":"git://github.com/appcelerator/amp.git","ssh_url":"git@github.com:appcelerator/amp.git","clone_url":"https://github.com/appcelerator/amp.git","svn_url":"https://github.com/appcelerator/amp","homepage":"http://appcelerator.io","size":200005,"stargazers_count":63,"watchers_count":63,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"archived":false,"open_issues_count":16,"forks":23,"open_issues":16,"watchers":63,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/appcelerator/amp/pulls/1743"},"html":{"href":"https://github.com/appcelerator/amp/pull/1743"},"issue":{"href":"https://api.github.com/repos/appcelerator/amp/issues/1743"},"comments":{"href":"https://api.github.com/repos/appcelerator/amp/issues/1743/comments"},"review_comments":{"href":"https://api.github.com/repos/appcelerator/amp/pulls/1743/comments"},"review_comment":{"href":"https://api.github.com/repos/appcelerator/amp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/appcelerator/amp/pulls/1743/commits"},"statuses":{"href":"https://api.github.com/repos/appcelerator/amp/statuses/31994f75a9ff13e91d69b991be2d8af9f7cd2283"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"bquenin","id":11057786,"avatar_url":"https://avatars2.githubusercontent.com/u/11057786?v=4","gravatar_id":"","url":"https://api.github.com/users/bquenin","html_url":"https://github.com/bquenin","followers_url":"https://api.github.com/users/bquenin/followers","following_url":"https://api.github.com/users/bquenin/following{/other_user}","gists_url":"https://api.github.com/users/bquenin/gists{/gist_id}","starred_url":"https://api.github.com/users/bquenin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bquenin/subscriptions","organizations_url":"https://api.github.com/users/bquenin/orgs","repos_url":"https://api.github.com/users/bquenin/repos","events_url":"https://api.github.com/users/bquenin/events{/privacy}","received_events_url":"https://api.github.com/users/bquenin/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":24,"deletions":5,"changed_files":2}}
{"actor":{"display_login":"bquenin"}}