{"action":"created","comment":{"url":"https://api.github.com/repos/discourse/mini_mime/pulls/comments/111450924","pull_request_review_id":32699766,"id":111450924,"diff_hunk":"@@ -3,4 +3,9 @@ source 'https://rubygems.org'\n # Specify your gem's dependencies in mini_mime.gemspec\n gemspec\n \n-gem \"mime-types\", \"~> 3\" if RUBY_VERSION > '2'\n+gem 'mime-types', '~> 3' if RUBY_VERSION > '2'\n+gem 'memory_profiler' if RUBY_VERSION >= '2.1.0'\n+gem 'benchmark-ips'\n+if RUBY_PLATFORM != 'java' && RUBY_VERSION > '1.9'\n+  gem 'micro_mime', :git => 'https://github.com/stereobooster/micro_mime.git'","path":"Gemfile","position":9,"original_position":9,"commit_id":"d81bbe5150442c15c906cb59d3b1b638e3194fad","original_commit_id":"d81bbe5150442c15c906cb59d3b1b638e3194fad","user":{"login":"stereobooster","id":179534,"avatar_url":"https://avatars1.githubusercontent.com/u/179534?v=3","gravatar_id":"","url":"https://api.github.com/users/stereobooster","html_url":"https://github.com/stereobooster","followers_url":"https://api.github.com/users/stereobooster/followers","following_url":"https://api.github.com/users/stereobooster/following{/other_user}","gists_url":"https://api.github.com/users/stereobooster/gists{/gist_id}","starred_url":"https://api.github.com/users/stereobooster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stereobooster/subscriptions","organizations_url":"https://api.github.com/users/stereobooster/orgs","repos_url":"https://api.github.com/users/stereobooster/repos","events_url":"https://api.github.com/users/stereobooster/events{/privacy}","received_events_url":"https://api.github.com/users/stereobooster/received_events","type":"User","site_admin":false},"body":"The git source `git://github.com/stereobooster/micro_mime.git` uses the `git` protocol, which transmits data without encryption. Disable this warning with `bundle config git.allow_insecure true`, or switch to the `https` protocol to keep your data secure.","created_at":"2017-04-13T18:04:58Z","updated_at":"2017-04-13T18:04:58Z","html_url":"https://github.com/discourse/mini_mime/pull/5#discussion_r111450924","pull_request_url":"https://api.github.com/repos/discourse/mini_mime/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/discourse/mini_mime/pulls/comments/111450924"},"html":{"href":"https://github.com/discourse/mini_mime/pull/5#discussion_r111450924"},"pull_request":{"href":"https://api.github.com/repos/discourse/mini_mime/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/discourse/mini_mime/pulls/5","id":115655375,"html_url":"https://github.com/discourse/mini_mime/pull/5","diff_url":"https://github.com/discourse/mini_mime/pull/5.diff","patch_url":"https://github.com/discourse/mini_mime/pull/5.patch","issue_url":"https://api.github.com/repos/discourse/mini_mime/issues/5","number":5,"state":"open","locked":false,"title":"C extension","user":{"login":"stereobooster","id":179534,"avatar_url":"https://avatars1.githubusercontent.com/u/179534?v=3","gravatar_id":"","url":"https://api.github.com/users/stereobooster","html_url":"https://github.com/stereobooster","followers_url":"https://api.github.com/users/stereobooster/followers","following_url":"https://api.github.com/users/stereobooster/following{/other_user}","gists_url":"https://api.github.com/users/stereobooster/gists{/gist_id}","starred_url":"https://api.github.com/users/stereobooster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stereobooster/subscriptions","organizations_url":"https://api.github.com/users/stereobooster/orgs","repos_url":"https://api.github.com/users/stereobooster/repos","events_url":"https://api.github.com/users/stereobooster/events{/privacy}","received_events_url":"https://api.github.com/users/stereobooster/received_events","type":"User","site_admin":false},"body":"before\r\n\r\n```\r\nMemory stats for requiring mime/types/columnar\r\nTotal allocated: 10706175 bytes (114132 objects)\r\nTotal retained:  3472241 bytes (31905 objects)\r\n\r\nMemory stats for requiring mini_mime\r\nno micro_mime\r\nTotal allocated: 29572343 bytes (344531 objects)\r\nTotal retained:  3943884 bytes (60957 objects)\r\nWarming up --------------------------------------\r\ncached content_type lookup MiniMime\r\n                        33.573k i/100ms\r\ncontent_type lookup Mime::Types\r\n                        22.444k i/100ms\r\nCalculating -------------------------------------\r\ncached content_type lookup MiniMime\r\n                        411.406k (± 5.1%) i/s -      2.082M in   5.072606s\r\ncontent_type lookup Mime::Types\r\n                        260.357k (± 4.6%) i/s -      1.302M in   5.010742s\r\nWarming up --------------------------------------\r\nuncached content_type lookup MiniMime\r\n                         1.818k i/100ms\r\ncontent_type lookup Mime::Types\r\n                        23.239k i/100ms\r\nCalculating -------------------------------------\r\nuncached content_type lookup MiniMime\r\n                         17.224k (±13.3%) i/s -     85.446k in   5.079496s\r\ncontent_type lookup Mime::Types\r\n                        252.985k (± 5.1%) i/s -      1.278M in   5.067150s\r\n```\r\n\r\nafter\r\n\r\n```\r\nMemory stats for requiring mime/types/columnar\r\nTotal allocated: 9686150 bytes (104029 objects)\r\nTotal retained:  3341587 bytes (30943 objects)\r\n\r\nMemory stats for requiring mini_mime\r\nTotal allocated: 107068 bytes (648 objects)\r\nTotal retained:  35458 bytes (84 objects)\r\nWarming up --------------------------------------\r\ncached content_type lookup MiniMime\r\n                        36.319k i/100ms\r\ncontent_type lookup Mime::Types\r\n                        20.906k i/100ms\r\nCalculating -------------------------------------\r\ncached content_type lookup MiniMime\r\n                        449.882k (± 3.2%) i/s -      2.252M in   5.010620s\r\ncontent_type lookup Mime::Types\r\n                        237.783k (± 4.5%) i/s -      1.192M in   5.022733s\r\nWarming up --------------------------------------\r\nuncached content_type lookup MiniMime\r\n                        37.974k i/100ms\r\ncontent_type lookup Mime::Types\r\n                        21.801k i/100ms\r\nCalculating -------------------------------------\r\nuncached content_type lookup MiniMime\r\n                        447.517k (± 4.7%) i/s -      2.240M in   5.017812s\r\ncontent_type lookup Mime::Types\r\n                        239.405k (± 4.2%) i/s -      1.199M in   5.017784s\r\n```\r\n\r\ncc @ioquatix","created_at":"2017-04-12T23:18:50Z","updated_at":"2017-04-13T18:04:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ca6f6e1e4310c92d4c6a3c6afe2791d9c70e8f98","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/discourse/mini_mime/pulls/5/commits","review_comments_url":"https://api.github.com/repos/discourse/mini_mime/pulls/5/comments","review_comment_url":"https://api.github.com/repos/discourse/mini_mime/pulls/comments{/number}","comments_url":"https://api.github.com/repos/discourse/mini_mime/issues/5/comments","statuses_url":"https://api.github.com/repos/discourse/mini_mime/statuses/d81bbe5150442c15c906cb59d3b1b638e3194fad","head":{"label":"stereobooster:c-extension","ref":"c-extension","sha":"d81bbe5150442c15c906cb59d3b1b638e3194fad","user":{"login":"stereobooster","id":179534,"avatar_url":"https://avatars1.githubusercontent.com/u/179534?v=3","gravatar_id":"","url":"https://api.github.com/users/stereobooster","html_url":"https://github.com/stereobooster","followers_url":"https://api.github.com/users/stereobooster/followers","following_url":"https://api.github.com/users/stereobooster/following{/other_user}","gists_url":"https://api.github.com/users/stereobooster/gists{/gist_id}","starred_url":"https://api.github.com/users/stereobooster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stereobooster/subscriptions","organizations_url":"https://api.github.com/users/stereobooster/orgs","repos_url":"https://api.github.com/users/stereobooster/repos","events_url":"https://api.github.com/users/stereobooster/events{/privacy}","received_events_url":"https://api.github.com/users/stereobooster/received_events","type":"User","site_admin":false},"repo":{"id":88076626,"name":"micro_mime","full_name":"stereobooster/micro_mime","owner":{"login":"stereobooster","id":179534,"avatar_url":"https://avatars1.githubusercontent.com/u/179534?v=3","gravatar_id":"","url":"https://api.github.com/users/stereobooster","html_url":"https://github.com/stereobooster","followers_url":"https://api.github.com/users/stereobooster/followers","following_url":"https://api.github.com/users/stereobooster/following{/other_user}","gists_url":"https://api.github.com/users/stereobooster/gists{/gist_id}","starred_url":"https://api.github.com/users/stereobooster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stereobooster/subscriptions","organizations_url":"https://api.github.com/users/stereobooster/orgs","repos_url":"https://api.github.com/users/stereobooster/repos","events_url":"https://api.github.com/users/stereobooster/events{/privacy}","received_events_url":"https://api.github.com/users/stereobooster/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stereobooster/micro_mime","description":"minimal mime type library","fork":true,"url":"https://api.github.com/repos/stereobooster/micro_mime","forks_url":"https://api.github.com/repos/stereobooster/micro_mime/forks","keys_url":"https://api.github.com/repos/stereobooster/micro_mime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stereobooster/micro_mime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stereobooster/micro_mime/teams","hooks_url":"https://api.github.com/repos/stereobooster/micro_mime/hooks","issue_events_url":"https://api.github.com/repos/stereobooster/micro_mime/issues/events{/number}","events_url":"https://api.github.com/repos/stereobooster/micro_mime/events","assignees_url":"https://api.github.com/repos/stereobooster/micro_mime/assignees{/user}","branches_url":"https://api.github.com/repos/stereobooster/micro_mime/branches{/branch}","tags_url":"https://api.github.com/repos/stereobooster/micro_mime/tags","blobs_url":"https://api.github.com/repos/stereobooster/micro_mime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stereobooster/micro_mime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stereobooster/micro_mime/git/refs{/sha}","trees_url":"https://api.github.com/repos/stereobooster/micro_mime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stereobooster/micro_mime/statuses/{sha}","languages_url":"https://api.github.com/repos/stereobooster/micro_mime/languages","stargazers_url":"https://api.github.com/repos/stereobooster/micro_mime/stargazers","contributors_url":"https://api.github.com/repos/stereobooster/micro_mime/contributors","subscribers_url":"https://api.github.com/repos/stereobooster/micro_mime/subscribers","subscription_url":"https://api.github.com/repos/stereobooster/micro_mime/subscription","commits_url":"https://api.github.com/repos/stereobooster/micro_mime/commits{/sha}","git_commits_url":"https://api.github.com/repos/stereobooster/micro_mime/git/commits{/sha}","comments_url":"https://api.github.com/repos/stereobooster/micro_mime/comments{/number}","issue_comment_url":"https://api.github.com/repos/stereobooster/micro_mime/issues/comments{/number}","contents_url":"https://api.github.com/repos/stereobooster/micro_mime/contents/{+path}","compare_url":"https://api.github.com/repos/stereobooster/micro_mime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stereobooster/micro_mime/merges","archive_url":"https://api.github.com/repos/stereobooster/micro_mime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stereobooster/micro_mime/downloads","issues_url":"https://api.github.com/repos/stereobooster/micro_mime/issues{/number}","pulls_url":"https://api.github.com/repos/stereobooster/micro_mime/pulls{/number}","milestones_url":"https://api.github.com/repos/stereobooster/micro_mime/milestones{/number}","notifications_url":"https://api.github.com/repos/stereobooster/micro_mime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stereobooster/micro_mime/labels{/name}","releases_url":"https://api.github.com/repos/stereobooster/micro_mime/releases{/id}","deployments_url":"https://api.github.com/repos/stereobooster/micro_mime/deployments","created_at":"2017-04-12T17:04:43Z","updated_at":"2017-04-13T11:34:08Z","pushed_at":"2017-04-13T15:35:09Z","git_url":"git://github.com/stereobooster/micro_mime.git","ssh_url":"git@github.com:stereobooster/micro_mime.git","clone_url":"https://github.com/stereobooster/micro_mime.git","svn_url":"https://github.com/stereobooster/micro_mime","homepage":null,"size":240,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"discourse:master","ref":"master","sha":"356b01907d11e30a39ab16f4bace2aa9bd80d699","user":{"login":"discourse","id":3220138,"avatar_url":"https://avatars1.githubusercontent.com/u/3220138?v=3","gravatar_id":"","url":"https://api.github.com/users/discourse","html_url":"https://github.com/discourse","followers_url":"https://api.github.com/users/discourse/followers","following_url":"https://api.github.com/users/discourse/following{/other_user}","gists_url":"https://api.github.com/users/discourse/gists{/gist_id}","starred_url":"https://api.github.com/users/discourse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/discourse/subscriptions","organizations_url":"https://api.github.com/users/discourse/orgs","repos_url":"https://api.github.com/users/discourse/repos","events_url":"https://api.github.com/users/discourse/events{/privacy}","received_events_url":"https://api.github.com/users/discourse/received_events","type":"Organization","site_admin":false},"repo":{"id":76334905,"name":"mini_mime","full_name":"discourse/mini_mime","owner":{"login":"discourse","id":3220138,"avatar_url":"https://avatars1.githubusercontent.com/u/3220138?v=3","gravatar_id":"","url":"https://api.github.com/users/discourse","html_url":"https://github.com/discourse","followers_url":"https://api.github.com/users/discourse/followers","following_url":"https://api.github.com/users/discourse/following{/other_user}","gists_url":"https://api.github.com/users/discourse/gists{/gist_id}","starred_url":"https://api.github.com/users/discourse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/discourse/subscriptions","organizations_url":"https://api.github.com/users/discourse/orgs","repos_url":"https://api.github.com/users/discourse/repos","events_url":"https://api.github.com/users/discourse/events{/privacy}","received_events_url":"https://api.github.com/users/discourse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/discourse/mini_mime","description":"minimal mime type library","fork":false,"url":"https://api.github.com/repos/discourse/mini_mime","forks_url":"https://api.github.com/repos/discourse/mini_mime/forks","keys_url":"https://api.github.com/repos/discourse/mini_mime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/discourse/mini_mime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/discourse/mini_mime/teams","hooks_url":"https://api.github.com/repos/discourse/mini_mime/hooks","issue_events_url":"https://api.github.com/repos/discourse/mini_mime/issues/events{/number}","events_url":"https://api.github.com/repos/discourse/mini_mime/events","assignees_url":"https://api.github.com/repos/discourse/mini_mime/assignees{/user}","branches_url":"https://api.github.com/repos/discourse/mini_mime/branches{/branch}","tags_url":"https://api.github.com/repos/discourse/mini_mime/tags","blobs_url":"https://api.github.com/repos/discourse/mini_mime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/discourse/mini_mime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/discourse/mini_mime/git/refs{/sha}","trees_url":"https://api.github.com/repos/discourse/mini_mime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/discourse/mini_mime/statuses/{sha}","languages_url":"https://api.github.com/repos/discourse/mini_mime/languages","stargazers_url":"https://api.github.com/repos/discourse/mini_mime/stargazers","contributors_url":"https://api.github.com/repos/discourse/mini_mime/contributors","subscribers_url":"https://api.github.com/repos/discourse/mini_mime/subscribers","subscription_url":"https://api.github.com/repos/discourse/mini_mime/subscription","commits_url":"https://api.github.com/repos/discourse/mini_mime/commits{/sha}","git_commits_url":"https://api.github.com/repos/discourse/mini_mime/git/commits{/sha}","comments_url":"https://api.github.com/repos/discourse/mini_mime/comments{/number}","issue_comment_url":"https://api.github.com/repos/discourse/mini_mime/issues/comments{/number}","contents_url":"https://api.github.com/repos/discourse/mini_mime/contents/{+path}","compare_url":"https://api.github.com/repos/discourse/mini_mime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/discourse/mini_mime/merges","archive_url":"https://api.github.com/repos/discourse/mini_mime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/discourse/mini_mime/downloads","issues_url":"https://api.github.com/repos/discourse/mini_mime/issues{/number}","pulls_url":"https://api.github.com/repos/discourse/mini_mime/pulls{/number}","milestones_url":"https://api.github.com/repos/discourse/mini_mime/milestones{/number}","notifications_url":"https://api.github.com/repos/discourse/mini_mime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/discourse/mini_mime/labels{/name}","releases_url":"https://api.github.com/repos/discourse/mini_mime/releases{/id}","deployments_url":"https://api.github.com/repos/discourse/mini_mime/deployments","created_at":"2016-12-13T07:40:02Z","updated_at":"2017-03-16T17:31:08Z","pushed_at":"2017-04-13T12:19:49Z","git_url":"git://github.com/discourse/mini_mime.git","ssh_url":"git@github.com:discourse/mini_mime.git","clone_url":"https://github.com/discourse/mini_mime.git","svn_url":"https://github.com/discourse/mini_mime","homepage":null,"size":36,"stargazers_count":13,"watchers_count":13,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":1,"forks":6,"open_issues":1,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/discourse/mini_mime/pulls/5"},"html":{"href":"https://github.com/discourse/mini_mime/pull/5"},"issue":{"href":"https://api.github.com/repos/discourse/mini_mime/issues/5"},"comments":{"href":"https://api.github.com/repos/discourse/mini_mime/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/discourse/mini_mime/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/discourse/mini_mime/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/discourse/mini_mime/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/discourse/mini_mime/statuses/d81bbe5150442c15c906cb59d3b1b638e3194fad"}}}}
{"actor":{"display_login":"stereobooster"}}