{"action":"created","comment":{"url":"https://api.github.com/repos/ripple/rippled/pulls/comments/145484240","pull_request_review_id":70291807,"id":145484240,"diff_hunk":"@@ -2148,20 +2148,23 @@ Json::Value NetworkOPsImp::getServerInfo (bool human, bool admin)\n     info[jss::validation_quorum] = static_cast<Json::UInt>(\n         app_.validators ().quorum ());\n \n-    if (auto when = app_.validators().expires())\n-    {\n-        if(human)\n-            info[jss::validator_list_expires] = to_string(*when);\n-        else\n-            info[jss::validator_list_expires] =\n-                static_cast<Json::UInt>(when->time_since_epoch().count());\n-    }\n-    else\n+    if (admin)\n     {\n-        if(human)\n-            info[jss::validator_list_expires] = \"unknown\";\n+        if (auto when = app_.validators().expires())\n+        {\n+            if (human)\n+                info[jss::validator_list_expires] = to_string(*when);","path":"src/ripple/app/misc/NetworkOPs.cpp","position":null,"original_position":20,"commit_id":"d2081cb5263966fadc79874961fe7fc2c4aef34b","original_commit_id":"d2081cb5263966fadc79874961fe7fc2c4aef34b","user":{"login":"wilsonianb","id":5885521,"avatar_url":"https://avatars1.githubusercontent.com/u/5885521?v=4","gravatar_id":"","url":"https://api.github.com/users/wilsonianb","html_url":"https://github.com/wilsonianb","followers_url":"https://api.github.com/users/wilsonianb/followers","following_url":"https://api.github.com/users/wilsonianb/following{/other_user}","gists_url":"https://api.github.com/users/wilsonianb/gists{/gist_id}","starred_url":"https://api.github.com/users/wilsonianb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilsonianb/subscriptions","organizations_url":"https://api.github.com/users/wilsonianb/orgs","repos_url":"https://api.github.com/users/wilsonianb/repos","events_url":"https://api.github.com/users/wilsonianb/events{/privacy}","received_events_url":"https://api.github.com/users/wilsonianb/received_events","type":"User","site_admin":false},"body":"What do you think about displaying something like `\"never\"` or `\"no expiration\"` if `when` equals  `TimeKeeper::time_point::max()`? Same would apply to the `validator_lists` response","created_at":"2017-10-18T17:24:49Z","updated_at":"2017-10-18T17:42:31Z","html_url":"https://github.com/ripple/rippled/pull/2242#discussion_r145484240","pull_request_url":"https://api.github.com/repos/ripple/rippled/pulls/2242","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ripple/rippled/pulls/comments/145484240"},"html":{"href":"https://github.com/ripple/rippled/pull/2242#discussion_r145484240"},"pull_request":{"href":"https://api.github.com/repos/ripple/rippled/pulls/2242"}}},"pull_request":{"url":"https://api.github.com/repos/ripple/rippled/pulls/2242","id":145521982,"html_url":"https://github.com/ripple/rippled/pull/2242","diff_url":"https://github.com/ripple/rippled/pull/2242.diff","patch_url":"https://github.com/ripple/rippled/pull/2242.patch","issue_url":"https://api.github.com/repos/ripple/rippled/issues/2242","number":2242,"state":"open","locked":false,"title":"Add validator list RPC calls (RIPD-1541)","user":{"login":"bachase","id":14430,"avatar_url":"https://avatars2.githubusercontent.com/u/14430?v=4","gravatar_id":"","url":"https://api.github.com/users/bachase","html_url":"https://github.com/bachase","followers_url":"https://api.github.com/users/bachase/followers","following_url":"https://api.github.com/users/bachase/following{/other_user}","gists_url":"https://api.github.com/users/bachase/gists{/gist_id}","starred_url":"https://api.github.com/users/bachase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bachase/subscriptions","organizations_url":"https://api.github.com/users/bachase/orgs","repos_url":"https://api.github.com/users/bachase/repos","events_url":"https://api.github.com/users/bachase/events{/privacy}","received_events_url":"https://api.github.com/users/bachase/received_events","type":"User","site_admin":false},"body":"In support of dynamic validator list, this changeset\r\n\r\n1. Adds a new `validator_list_expires` field to `server_info` that indicates when the current validator list will become stale.\r\n2. Adds a new admin only `validator_lists` RPC that returns the current list of known validators and the most recent published validator lists.\r\n3. Adds a new admin only `validator_sites` RPC that returns the list of configured validator publisher sites and when they were most recently queried.\r\n\r\nThis builds on PR #2240, which is the first two commits in this changeset.  ","created_at":"2017-10-09T18:46:48Z","updated_at":"2017-10-18T17:42:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"49c07ee5cac2519b0b81a312d02a9b90656ef825","assignee":{"login":"mellery451","id":463430,"avatar_url":"https://avatars1.githubusercontent.com/u/463430?v=4","gravatar_id":"","url":"https://api.github.com/users/mellery451","html_url":"https://github.com/mellery451","followers_url":"https://api.github.com/users/mellery451/followers","following_url":"https://api.github.com/users/mellery451/following{/other_user}","gists_url":"https://api.github.com/users/mellery451/gists{/gist_id}","starred_url":"https://api.github.com/users/mellery451/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mellery451/subscriptions","organizations_url":"https://api.github.com/users/mellery451/orgs","repos_url":"https://api.github.com/users/mellery451/repos","events_url":"https://api.github.com/users/mellery451/events{/privacy}","received_events_url":"https://api.github.com/users/mellery451/received_events","type":"User","site_admin":false},"assignees":[{"login":"mellery451","id":463430,"avatar_url":"https://avatars1.githubusercontent.com/u/463430?v=4","gravatar_id":"","url":"https://api.github.com/users/mellery451","html_url":"https://github.com/mellery451","followers_url":"https://api.github.com/users/mellery451/followers","following_url":"https://api.github.com/users/mellery451/following{/other_user}","gists_url":"https://api.github.com/users/mellery451/gists{/gist_id}","starred_url":"https://api.github.com/users/mellery451/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mellery451/subscriptions","organizations_url":"https://api.github.com/users/mellery451/orgs","repos_url":"https://api.github.com/users/mellery451/repos","events_url":"https://api.github.com/users/mellery451/events{/privacy}","received_events_url":"https://api.github.com/users/mellery451/received_events","type":"User","site_admin":false},{"login":"wilsonianb","id":5885521,"avatar_url":"https://avatars1.githubusercontent.com/u/5885521?v=4","gravatar_id":"","url":"https://api.github.com/users/wilsonianb","html_url":"https://github.com/wilsonianb","followers_url":"https://api.github.com/users/wilsonianb/followers","following_url":"https://api.github.com/users/wilsonianb/following{/other_user}","gists_url":"https://api.github.com/users/wilsonianb/gists{/gist_id}","starred_url":"https://api.github.com/users/wilsonianb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilsonianb/subscriptions","organizations_url":"https://api.github.com/users/wilsonianb/orgs","repos_url":"https://api.github.com/users/wilsonianb/repos","events_url":"https://api.github.com/users/wilsonianb/events{/privacy}","received_events_url":"https://api.github.com/users/wilsonianb/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ripple/rippled/pulls/2242/commits","review_comments_url":"https://api.github.com/repos/ripple/rippled/pulls/2242/comments","review_comment_url":"https://api.github.com/repos/ripple/rippled/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ripple/rippled/issues/2242/comments","statuses_url":"https://api.github.com/repos/ripple/rippled/statuses/d2081cb5263966fadc79874961fe7fc2c4aef34b","head":{"label":"bachase:bc-val-list","ref":"bc-val-list","sha":"d2081cb5263966fadc79874961fe7fc2c4aef34b","user":{"login":"bachase","id":14430,"avatar_url":"https://avatars2.githubusercontent.com/u/14430?v=4","gravatar_id":"","url":"https://api.github.com/users/bachase","html_url":"https://github.com/bachase","followers_url":"https://api.github.com/users/bachase/followers","following_url":"https://api.github.com/users/bachase/following{/other_user}","gists_url":"https://api.github.com/users/bachase/gists{/gist_id}","starred_url":"https://api.github.com/users/bachase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bachase/subscriptions","organizations_url":"https://api.github.com/users/bachase/orgs","repos_url":"https://api.github.com/users/bachase/repos","events_url":"https://api.github.com/users/bachase/events{/privacy}","received_events_url":"https://api.github.com/users/bachase/received_events","type":"User","site_admin":false},"repo":{"id":65106511,"name":"rippled","full_name":"bachase/rippled","owner":{"login":"bachase","id":14430,"avatar_url":"https://avatars2.githubusercontent.com/u/14430?v=4","gravatar_id":"","url":"https://api.github.com/users/bachase","html_url":"https://github.com/bachase","followers_url":"https://api.github.com/users/bachase/followers","following_url":"https://api.github.com/users/bachase/following{/other_user}","gists_url":"https://api.github.com/users/bachase/gists{/gist_id}","starred_url":"https://api.github.com/users/bachase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bachase/subscriptions","organizations_url":"https://api.github.com/users/bachase/orgs","repos_url":"https://api.github.com/users/bachase/repos","events_url":"https://api.github.com/users/bachase/events{/privacy}","received_events_url":"https://api.github.com/users/bachase/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bachase/rippled","description":"Ripple peer-to-peer network daemon","fork":true,"url":"https://api.github.com/repos/bachase/rippled","forks_url":"https://api.github.com/repos/bachase/rippled/forks","keys_url":"https://api.github.com/repos/bachase/rippled/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bachase/rippled/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bachase/rippled/teams","hooks_url":"https://api.github.com/repos/bachase/rippled/hooks","issue_events_url":"https://api.github.com/repos/bachase/rippled/issues/events{/number}","events_url":"https://api.github.com/repos/bachase/rippled/events","assignees_url":"https://api.github.com/repos/bachase/rippled/assignees{/user}","branches_url":"https://api.github.com/repos/bachase/rippled/branches{/branch}","tags_url":"https://api.github.com/repos/bachase/rippled/tags","blobs_url":"https://api.github.com/repos/bachase/rippled/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bachase/rippled/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bachase/rippled/git/refs{/sha}","trees_url":"https://api.github.com/repos/bachase/rippled/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bachase/rippled/statuses/{sha}","languages_url":"https://api.github.com/repos/bachase/rippled/languages","stargazers_url":"https://api.github.com/repos/bachase/rippled/stargazers","contributors_url":"https://api.github.com/repos/bachase/rippled/contributors","subscribers_url":"https://api.github.com/repos/bachase/rippled/subscribers","subscription_url":"https://api.github.com/repos/bachase/rippled/subscription","commits_url":"https://api.github.com/repos/bachase/rippled/commits{/sha}","git_commits_url":"https://api.github.com/repos/bachase/rippled/git/commits{/sha}","comments_url":"https://api.github.com/repos/bachase/rippled/comments{/number}","issue_comment_url":"https://api.github.com/repos/bachase/rippled/issues/comments{/number}","contents_url":"https://api.github.com/repos/bachase/rippled/contents/{+path}","compare_url":"https://api.github.com/repos/bachase/rippled/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bachase/rippled/merges","archive_url":"https://api.github.com/repos/bachase/rippled/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bachase/rippled/downloads","issues_url":"https://api.github.com/repos/bachase/rippled/issues{/number}","pulls_url":"https://api.github.com/repos/bachase/rippled/pulls{/number}","milestones_url":"https://api.github.com/repos/bachase/rippled/milestones{/number}","notifications_url":"https://api.github.com/repos/bachase/rippled/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bachase/rippled/labels{/name}","releases_url":"https://api.github.com/repos/bachase/rippled/releases{/id}","deployments_url":"https://api.github.com/repos/bachase/rippled/deployments","created_at":"2016-08-06T23:34:35Z","updated_at":"2017-06-28T18:49:58Z","pushed_at":"2017-10-13T21:15:54Z","git_url":"git://github.com/bachase/rippled.git","ssh_url":"git@github.com:bachase/rippled.git","clone_url":"https://github.com/bachase/rippled.git","svn_url":"https://github.com/bachase/rippled","homepage":"https://ripple.com","size":91562,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":1,"default_branch":"develop"}},"base":{"label":"ripple:develop","ref":"develop","sha":"3e5490ef6db9cbc3abdff04655d80952b288d097","user":{"login":"ripple","id":3165523,"avatar_url":"https://avatars2.githubusercontent.com/u/3165523?v=4","gravatar_id":"","url":"https://api.github.com/users/ripple","html_url":"https://github.com/ripple","followers_url":"https://api.github.com/users/ripple/followers","following_url":"https://api.github.com/users/ripple/following{/other_user}","gists_url":"https://api.github.com/users/ripple/gists{/gist_id}","starred_url":"https://api.github.com/users/ripple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ripple/subscriptions","organizations_url":"https://api.github.com/users/ripple/orgs","repos_url":"https://api.github.com/users/ripple/repos","events_url":"https://api.github.com/users/ripple/events{/privacy}","received_events_url":"https://api.github.com/users/ripple/received_events","type":"Organization","site_admin":false},"repo":{"id":2724167,"name":"rippled","full_name":"ripple/rippled","owner":{"login":"ripple","id":3165523,"avatar_url":"https://avatars2.githubusercontent.com/u/3165523?v=4","gravatar_id":"","url":"https://api.github.com/users/ripple","html_url":"https://github.com/ripple","followers_url":"https://api.github.com/users/ripple/followers","following_url":"https://api.github.com/users/ripple/following{/other_user}","gists_url":"https://api.github.com/users/ripple/gists{/gist_id}","starred_url":"https://api.github.com/users/ripple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ripple/subscriptions","organizations_url":"https://api.github.com/users/ripple/orgs","repos_url":"https://api.github.com/users/ripple/repos","events_url":"https://api.github.com/users/ripple/events{/privacy}","received_events_url":"https://api.github.com/users/ripple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ripple/rippled","description":"Decentralized cryptocurrency blockchain daemon implementing the XRP Ledger in C++","fork":false,"url":"https://api.github.com/repos/ripple/rippled","forks_url":"https://api.github.com/repos/ripple/rippled/forks","keys_url":"https://api.github.com/repos/ripple/rippled/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ripple/rippled/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ripple/rippled/teams","hooks_url":"https://api.github.com/repos/ripple/rippled/hooks","issue_events_url":"https://api.github.com/repos/ripple/rippled/issues/events{/number}","events_url":"https://api.github.com/repos/ripple/rippled/events","assignees_url":"https://api.github.com/repos/ripple/rippled/assignees{/user}","branches_url":"https://api.github.com/repos/ripple/rippled/branches{/branch}","tags_url":"https://api.github.com/repos/ripple/rippled/tags","blobs_url":"https://api.github.com/repos/ripple/rippled/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ripple/rippled/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ripple/rippled/git/refs{/sha}","trees_url":"https://api.github.com/repos/ripple/rippled/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ripple/rippled/statuses/{sha}","languages_url":"https://api.github.com/repos/ripple/rippled/languages","stargazers_url":"https://api.github.com/repos/ripple/rippled/stargazers","contributors_url":"https://api.github.com/repos/ripple/rippled/contributors","subscribers_url":"https://api.github.com/repos/ripple/rippled/subscribers","subscription_url":"https://api.github.com/repos/ripple/rippled/subscription","commits_url":"https://api.github.com/repos/ripple/rippled/commits{/sha}","git_commits_url":"https://api.github.com/repos/ripple/rippled/git/commits{/sha}","comments_url":"https://api.github.com/repos/ripple/rippled/comments{/number}","issue_comment_url":"https://api.github.com/repos/ripple/rippled/issues/comments{/number}","contents_url":"https://api.github.com/repos/ripple/rippled/contents/{+path}","compare_url":"https://api.github.com/repos/ripple/rippled/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ripple/rippled/merges","archive_url":"https://api.github.com/repos/ripple/rippled/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ripple/rippled/downloads","issues_url":"https://api.github.com/repos/ripple/rippled/issues{/number}","pulls_url":"https://api.github.com/repos/ripple/rippled/pulls{/number}","milestones_url":"https://api.github.com/repos/ripple/rippled/milestones{/number}","notifications_url":"https://api.github.com/repos/ripple/rippled/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ripple/rippled/labels{/name}","releases_url":"https://api.github.com/repos/ripple/rippled/releases{/id}","deployments_url":"https://api.github.com/repos/ripple/rippled/deployments","created_at":"2011-11-07T04:40:15Z","updated_at":"2017-10-17T15:12:57Z","pushed_at":"2017-10-18T15:53:57Z","git_url":"git://github.com/ripple/rippled.git","ssh_url":"git@github.com:ripple/rippled.git","clone_url":"https://github.com/ripple/rippled.git","svn_url":"https://github.com/ripple/rippled","homepage":"https://ripple.com/xrp","size":86258,"stargazers_count":1622,"watchers_count":1622,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":482,"mirror_url":null,"open_issues_count":93,"forks":482,"open_issues":93,"watchers":1622,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ripple/rippled/pulls/2242"},"html":{"href":"https://github.com/ripple/rippled/pull/2242"},"issue":{"href":"https://api.github.com/repos/ripple/rippled/issues/2242"},"comments":{"href":"https://api.github.com/repos/ripple/rippled/issues/2242/comments"},"review_comments":{"href":"https://api.github.com/repos/ripple/rippled/pulls/2242/comments"},"review_comment":{"href":"https://api.github.com/repos/ripple/rippled/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ripple/rippled/pulls/2242/commits"},"statuses":{"href":"https://api.github.com/repos/ripple/rippled/statuses/d2081cb5263966fadc79874961fe7fc2c4aef34b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"wilsonianb"}}