{"action":"created","comment":{"url":"https://api.github.com/repos/pobonte/school_area_api/pulls/comments/110836888","pull_request_review_id":32035668,"id":110836888,"diff_hunk":"@@ -0,0 +1,50 @@\n+module V1\n+  class OurDaysController < ApplicationController\n+    before_action :find_groups, only: [:index, :create]\n+    before_action :join_our_day, only: [:show, :update, :destroy]\n+\n+    def index\n+      @our_days = @group.our_days\n+    end\n+\n+    def create\n+      @our_day = @group.our_days.build(our_day_params)\n+      if @our_day.save\n+        render :show\n+      else\n+        head :bad_request\n+      end","path":"app/controllers/v1/our_days_controller.rb","position":16,"original_position":16,"commit_id":"2b09e2f3d7706e229c48fa973dedeff1d01c3e30","original_commit_id":"2b09e2f3d7706e229c48fa973dedeff1d01c3e30","user":{"login":"andriyarterchuk","id":23266936,"avatar_url":"https://avatars0.githubusercontent.com/u/23266936?v=3","gravatar_id":"","url":"https://api.github.com/users/andriyarterchuk","html_url":"https://github.com/andriyarterchuk","followers_url":"https://api.github.com/users/andriyarterchuk/followers","following_url":"https://api.github.com/users/andriyarterchuk/following{/other_user}","gists_url":"https://api.github.com/users/andriyarterchuk/gists{/gist_id}","starred_url":"https://api.github.com/users/andriyarterchuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andriyarterchuk/subscriptions","organizations_url":"https://api.github.com/users/andriyarterchuk/orgs","repos_url":"https://api.github.com/users/andriyarterchuk/repos","events_url":"https://api.github.com/users/andriyarterchuk/events{/privacy}","received_events_url":"https://api.github.com/users/andriyarterchuk/received_events","type":"User","site_admin":false},"body":"you repeated this block in create and update action.\r\nyou should create a private method","created_at":"2017-04-11T08:02:38Z","updated_at":"2017-04-11T08:02:42Z","html_url":"https://github.com/pobonte/school_area_api/pull/19#discussion_r110836888","pull_request_url":"https://api.github.com/repos/pobonte/school_area_api/pulls/19","_links":{"self":{"href":"https://api.github.com/repos/pobonte/school_area_api/pulls/comments/110836888"},"html":{"href":"https://github.com/pobonte/school_area_api/pull/19#discussion_r110836888"},"pull_request":{"href":"https://api.github.com/repos/pobonte/school_area_api/pulls/19"}}},"pull_request":{"url":"https://api.github.com/repos/pobonte/school_area_api/pulls/19","id":114691632,"html_url":"https://github.com/pobonte/school_area_api/pull/19","diff_url":"https://github.com/pobonte/school_area_api/pull/19.diff","patch_url":"https://github.com/pobonte/school_area_api/pull/19.patch","issue_url":"https://api.github.com/repos/pobonte/school_area_api/issues/19","number":19,"state":"open","locked":false,"title":"Lvrubym 223: Add our day report model, rspec for model, routes, conroller.","user":{"login":"yaremakleputs","id":26766826,"avatar_url":"https://avatars3.githubusercontent.com/u/26766826?v=3","gravatar_id":"","url":"https://api.github.com/users/yaremakleputs","html_url":"https://github.com/yaremakleputs","followers_url":"https://api.github.com/users/yaremakleputs/followers","following_url":"https://api.github.com/users/yaremakleputs/following{/other_user}","gists_url":"https://api.github.com/users/yaremakleputs/gists{/gist_id}","starred_url":"https://api.github.com/users/yaremakleputs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yaremakleputs/subscriptions","organizations_url":"https://api.github.com/users/yaremakleputs/orgs","repos_url":"https://api.github.com/users/yaremakleputs/repos","events_url":"https://api.github.com/users/yaremakleputs/events{/privacy}","received_events_url":"https://api.github.com/users/yaremakleputs/received_events","type":"User","site_admin":false},"body":"## JIRA\r\n\r\n* [Main JIRA ticket](http://ssu-jira.softserveinc.com/browse/LVRUBYM-223)\r\n* [JIRA subtask](http://ssu-jira.softserveinc.com/browse/LVRUBYM-223)\r\n\r\n## Code reviewers\r\n\r\n- [ ] @skrypnyk88 \r\n- [ ] @andriyarterchuk \r\n- [ ] @vikabelous \r\n\r\n### Second Level Review\r\n\r\n- [ ] @omaik\r\n\r\n## Summary of issue\r\n\r\nNeed to ad back-end of our day report\r\n\r\n## Summary of change\r\n\r\n- added back-end without controller spec to our day report\r\n\r\n## Testing approach\r\n\r\nWe do not need any tests here\r\n\r\n## CHECK LIST\r\n- [ ]  СI passed\r\n- [ ]  Сode coverage >=90%\r\n- [ ]  PR is reviewed manually again (to make sure you have 100% ready code)\r\n- [ ]  All reviewers agreed to merge the PR\r\n- [ ]  I've checked new feature as logged in and logged out user if needed\r\n- [ ]  PR meets all conventions\r\n","created_at":"2017-04-06T20:47:30Z","updated_at":"2017-04-11T08:02:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6b0d3b3c0556cfdbf7c9fdb77d435997b64a648c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/pobonte/school_area_api/pulls/19/commits","review_comments_url":"https://api.github.com/repos/pobonte/school_area_api/pulls/19/comments","review_comment_url":"https://api.github.com/repos/pobonte/school_area_api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pobonte/school_area_api/issues/19/comments","statuses_url":"https://api.github.com/repos/pobonte/school_area_api/statuses/2b09e2f3d7706e229c48fa973dedeff1d01c3e30","head":{"label":"pobonte:LVRUBYM-223","ref":"LVRUBYM-223","sha":"2b09e2f3d7706e229c48fa973dedeff1d01c3e30","user":{"login":"pobonte","id":9717563,"avatar_url":"https://avatars0.githubusercontent.com/u/9717563?v=3","gravatar_id":"","url":"https://api.github.com/users/pobonte","html_url":"https://github.com/pobonte","followers_url":"https://api.github.com/users/pobonte/followers","following_url":"https://api.github.com/users/pobonte/following{/other_user}","gists_url":"https://api.github.com/users/pobonte/gists{/gist_id}","starred_url":"https://api.github.com/users/pobonte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pobonte/subscriptions","organizations_url":"https://api.github.com/users/pobonte/orgs","repos_url":"https://api.github.com/users/pobonte/repos","events_url":"https://api.github.com/users/pobonte/events{/privacy}","received_events_url":"https://api.github.com/users/pobonte/received_events","type":"User","site_admin":false},"repo":{"id":86578744,"name":"school_area_api","full_name":"pobonte/school_area_api","owner":{"login":"pobonte","id":9717563,"avatar_url":"https://avatars0.githubusercontent.com/u/9717563?v=3","gravatar_id":"","url":"https://api.github.com/users/pobonte","html_url":"https://github.com/pobonte","followers_url":"https://api.github.com/users/pobonte/followers","following_url":"https://api.github.com/users/pobonte/following{/other_user}","gists_url":"https://api.github.com/users/pobonte/gists{/gist_id}","starred_url":"https://api.github.com/users/pobonte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pobonte/subscriptions","organizations_url":"https://api.github.com/users/pobonte/orgs","repos_url":"https://api.github.com/users/pobonte/repos","events_url":"https://api.github.com/users/pobonte/events{/privacy}","received_events_url":"https://api.github.com/users/pobonte/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pobonte/school_area_api","description":null,"fork":false,"url":"https://api.github.com/repos/pobonte/school_area_api","forks_url":"https://api.github.com/repos/pobonte/school_area_api/forks","keys_url":"https://api.github.com/repos/pobonte/school_area_api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pobonte/school_area_api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pobonte/school_area_api/teams","hooks_url":"https://api.github.com/repos/pobonte/school_area_api/hooks","issue_events_url":"https://api.github.com/repos/pobonte/school_area_api/issues/events{/number}","events_url":"https://api.github.com/repos/pobonte/school_area_api/events","assignees_url":"https://api.github.com/repos/pobonte/school_area_api/assignees{/user}","branches_url":"https://api.github.com/repos/pobonte/school_area_api/branches{/branch}","tags_url":"https://api.github.com/repos/pobonte/school_area_api/tags","blobs_url":"https://api.github.com/repos/pobonte/school_area_api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pobonte/school_area_api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pobonte/school_area_api/git/refs{/sha}","trees_url":"https://api.github.com/repos/pobonte/school_area_api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pobonte/school_area_api/statuses/{sha}","languages_url":"https://api.github.com/repos/pobonte/school_area_api/languages","stargazers_url":"https://api.github.com/repos/pobonte/school_area_api/stargazers","contributors_url":"https://api.github.com/repos/pobonte/school_area_api/contributors","subscribers_url":"https://api.github.com/repos/pobonte/school_area_api/subscribers","subscription_url":"https://api.github.com/repos/pobonte/school_area_api/subscription","commits_url":"https://api.github.com/repos/pobonte/school_area_api/commits{/sha}","git_commits_url":"https://api.github.com/repos/pobonte/school_area_api/git/commits{/sha}","comments_url":"https://api.github.com/repos/pobonte/school_area_api/comments{/number}","issue_comment_url":"https://api.github.com/repos/pobonte/school_area_api/issues/comments{/number}","contents_url":"https://api.github.com/repos/pobonte/school_area_api/contents/{+path}","compare_url":"https://api.github.com/repos/pobonte/school_area_api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pobonte/school_area_api/merges","archive_url":"https://api.github.com/repos/pobonte/school_area_api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pobonte/school_area_api/downloads","issues_url":"https://api.github.com/repos/pobonte/school_area_api/issues{/number}","pulls_url":"https://api.github.com/repos/pobonte/school_area_api/pulls{/number}","milestones_url":"https://api.github.com/repos/pobonte/school_area_api/milestones{/number}","notifications_url":"https://api.github.com/repos/pobonte/school_area_api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pobonte/school_area_api/labels{/name}","releases_url":"https://api.github.com/repos/pobonte/school_area_api/releases{/id}","deployments_url":"https://api.github.com/repos/pobonte/school_area_api/deployments","created_at":"2017-03-29T12:20:50Z","updated_at":"2017-04-06T11:38:22Z","pushed_at":"2017-04-11T07:39:55Z","git_url":"git://github.com/pobonte/school_area_api.git","ssh_url":"git@github.com:pobonte/school_area_api.git","clone_url":"https://github.com/pobonte/school_area_api.git","svn_url":"https://github.com/pobonte/school_area_api","homepage":null,"size":171,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":6,"forks":0,"open_issues":6,"watchers":0,"default_branch":"master"}},"base":{"label":"pobonte:master","ref":"master","sha":"ca9a53f2c400ee57fcb9d96e52f8972b1987156f","user":{"login":"pobonte","id":9717563,"avatar_url":"https://avatars0.githubusercontent.com/u/9717563?v=3","gravatar_id":"","url":"https://api.github.com/users/pobonte","html_url":"https://github.com/pobonte","followers_url":"https://api.github.com/users/pobonte/followers","following_url":"https://api.github.com/users/pobonte/following{/other_user}","gists_url":"https://api.github.com/users/pobonte/gists{/gist_id}","starred_url":"https://api.github.com/users/pobonte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pobonte/subscriptions","organizations_url":"https://api.github.com/users/pobonte/orgs","repos_url":"https://api.github.com/users/pobonte/repos","events_url":"https://api.github.com/users/pobonte/events{/privacy}","received_events_url":"https://api.github.com/users/pobonte/received_events","type":"User","site_admin":false},"repo":{"id":86578744,"name":"school_area_api","full_name":"pobonte/school_area_api","owner":{"login":"pobonte","id":9717563,"avatar_url":"https://avatars0.githubusercontent.com/u/9717563?v=3","gravatar_id":"","url":"https://api.github.com/users/pobonte","html_url":"https://github.com/pobonte","followers_url":"https://api.github.com/users/pobonte/followers","following_url":"https://api.github.com/users/pobonte/following{/other_user}","gists_url":"https://api.github.com/users/pobonte/gists{/gist_id}","starred_url":"https://api.github.com/users/pobonte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pobonte/subscriptions","organizations_url":"https://api.github.com/users/pobonte/orgs","repos_url":"https://api.github.com/users/pobonte/repos","events_url":"https://api.github.com/users/pobonte/events{/privacy}","received_events_url":"https://api.github.com/users/pobonte/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pobonte/school_area_api","description":null,"fork":false,"url":"https://api.github.com/repos/pobonte/school_area_api","forks_url":"https://api.github.com/repos/pobonte/school_area_api/forks","keys_url":"https://api.github.com/repos/pobonte/school_area_api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pobonte/school_area_api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pobonte/school_area_api/teams","hooks_url":"https://api.github.com/repos/pobonte/school_area_api/hooks","issue_events_url":"https://api.github.com/repos/pobonte/school_area_api/issues/events{/number}","events_url":"https://api.github.com/repos/pobonte/school_area_api/events","assignees_url":"https://api.github.com/repos/pobonte/school_area_api/assignees{/user}","branches_url":"https://api.github.com/repos/pobonte/school_area_api/branches{/branch}","tags_url":"https://api.github.com/repos/pobonte/school_area_api/tags","blobs_url":"https://api.github.com/repos/pobonte/school_area_api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pobonte/school_area_api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pobonte/school_area_api/git/refs{/sha}","trees_url":"https://api.github.com/repos/pobonte/school_area_api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pobonte/school_area_api/statuses/{sha}","languages_url":"https://api.github.com/repos/pobonte/school_area_api/languages","stargazers_url":"https://api.github.com/repos/pobonte/school_area_api/stargazers","contributors_url":"https://api.github.com/repos/pobonte/school_area_api/contributors","subscribers_url":"https://api.github.com/repos/pobonte/school_area_api/subscribers","subscription_url":"https://api.github.com/repos/pobonte/school_area_api/subscription","commits_url":"https://api.github.com/repos/pobonte/school_area_api/commits{/sha}","git_commits_url":"https://api.github.com/repos/pobonte/school_area_api/git/commits{/sha}","comments_url":"https://api.github.com/repos/pobonte/school_area_api/comments{/number}","issue_comment_url":"https://api.github.com/repos/pobonte/school_area_api/issues/comments{/number}","contents_url":"https://api.github.com/repos/pobonte/school_area_api/contents/{+path}","compare_url":"https://api.github.com/repos/pobonte/school_area_api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pobonte/school_area_api/merges","archive_url":"https://api.github.com/repos/pobonte/school_area_api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pobonte/school_area_api/downloads","issues_url":"https://api.github.com/repos/pobonte/school_area_api/issues{/number}","pulls_url":"https://api.github.com/repos/pobonte/school_area_api/pulls{/number}","milestones_url":"https://api.github.com/repos/pobonte/school_area_api/milestones{/number}","notifications_url":"https://api.github.com/repos/pobonte/school_area_api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pobonte/school_area_api/labels{/name}","releases_url":"https://api.github.com/repos/pobonte/school_area_api/releases{/id}","deployments_url":"https://api.github.com/repos/pobonte/school_area_api/deployments","created_at":"2017-03-29T12:20:50Z","updated_at":"2017-04-06T11:38:22Z","pushed_at":"2017-04-11T07:39:55Z","git_url":"git://github.com/pobonte/school_area_api.git","ssh_url":"git@github.com:pobonte/school_area_api.git","clone_url":"https://github.com/pobonte/school_area_api.git","svn_url":"https://github.com/pobonte/school_area_api","homepage":null,"size":171,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":6,"forks":0,"open_issues":6,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pobonte/school_area_api/pulls/19"},"html":{"href":"https://github.com/pobonte/school_area_api/pull/19"},"issue":{"href":"https://api.github.com/repos/pobonte/school_area_api/issues/19"},"comments":{"href":"https://api.github.com/repos/pobonte/school_area_api/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/pobonte/school_area_api/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/pobonte/school_area_api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pobonte/school_area_api/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/pobonte/school_area_api/statuses/2b09e2f3d7706e229c48fa973dedeff1d01c3e30"}}}}
{"actor":{"display_login":"andriyarterchuk"}}