{"action":"created","comment":{"url":"https://api.github.com/repos/Shopify/tslint-config-shopify/pulls/comments/120388486","pull_request_review_id":42346516,"id":120388486,"diff_hunk":"@@ -4,11 +4,15 @@ import * as Lint from 'tslint';\n class TrailingCommaInterfaceWalker extends Lint.RuleWalker {\n    private static FAILURE_STRING = 'Trailing comma is required in interfaces properties.';\n    public visitInterfaceDeclaration(node: ts.InterfaceDeclaration) {\n+    const potentialDelimiters = [';'];\n     node.members.map((propertySignature) => {\n-        if (propertySignature.getText().slice(-1) !== ',') {\n-            this.addFailure(this.createFailure(propertySignature.getStart(),\n-                                               propertySignature.getWidth(),\n-                                               TrailingCommaInterfaceWalker.FAILURE_STRING));\n+        const lastChar = propertySignature.getText().slice(-1);\n+        if (lastChar !== ',') {","path":"src/customRules/trailingCommaInterfaceRule.ts","position":null,"original_position":11,"commit_id":"8907d66c8a83fad38cd13bd7191844aba42179d6","original_commit_id":"978c06cb175e10a8ac0dc5f3ad210f4751c338a8","user":{"login":"ismail-syed","id":6130700,"avatar_url":"https://avatars2.githubusercontent.com/u/6130700?v=3","gravatar_id":"","url":"https://api.github.com/users/ismail-syed","html_url":"https://github.com/ismail-syed","followers_url":"https://api.github.com/users/ismail-syed/followers","following_url":"https://api.github.com/users/ismail-syed/following{/other_user}","gists_url":"https://api.github.com/users/ismail-syed/gists{/gist_id}","starred_url":"https://api.github.com/users/ismail-syed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ismail-syed/subscriptions","organizations_url":"https://api.github.com/users/ismail-syed/orgs","repos_url":"https://api.github.com/users/ismail-syed/repos","events_url":"https://api.github.com/users/ismail-syed/events{/privacy}","received_events_url":"https://api.github.com/users/ismail-syed/received_events","type":"User","site_admin":false},"body":"😍 \r\n","created_at":"2017-06-06T15:08:51Z","updated_at":"2017-06-06T15:08:51Z","html_url":"https://github.com/Shopify/tslint-config-shopify/pull/62#discussion_r120388486","pull_request_url":"https://api.github.com/repos/Shopify/tslint-config-shopify/pulls/62","_links":{"self":{"href":"https://api.github.com/repos/Shopify/tslint-config-shopify/pulls/comments/120388486"},"html":{"href":"https://github.com/Shopify/tslint-config-shopify/pull/62#discussion_r120388486"},"pull_request":{"href":"https://api.github.com/repos/Shopify/tslint-config-shopify/pulls/62"}}},"pull_request":{"url":"https://api.github.com/repos/Shopify/tslint-config-shopify/pulls/62","id":123865587,"html_url":"https://github.com/Shopify/tslint-config-shopify/pull/62","diff_url":"https://github.com/Shopify/tslint-config-shopify/pull/62.diff","patch_url":"https://github.com/Shopify/tslint-config-shopify/pull/62.patch","issue_url":"https://api.github.com/repos/Shopify/tslint-config-shopify/issues/62","number":62,"state":"open","locked":false,"title":"Add fixer for trailing-comma-interface rule","user":{"login":"ismail-syed","id":6130700,"avatar_url":"https://avatars2.githubusercontent.com/u/6130700?v=3","gravatar_id":"","url":"https://api.github.com/users/ismail-syed","html_url":"https://github.com/ismail-syed","followers_url":"https://api.github.com/users/ismail-syed/followers","following_url":"https://api.github.com/users/ismail-syed/following{/other_user}","gists_url":"https://api.github.com/users/ismail-syed/gists{/gist_id}","starred_url":"https://api.github.com/users/ismail-syed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ismail-syed/subscriptions","organizations_url":"https://api.github.com/users/ismail-syed/orgs","repos_url":"https://api.github.com/users/ismail-syed/repos","events_url":"https://api.github.com/users/ismail-syed/events{/privacy}","received_events_url":"https://api.github.com/users/ismail-syed/received_events","type":"User","site_admin":false},"body":"This fixer will help with integrating prettier into our formatting/linting, if we decide to go with it. \r\n\r\nRelated to https://github.com/Shopify/tslint-config-shopify/issues/51","created_at":"2017-06-04T05:07:49Z","updated_at":"2017-06-06T15:08:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"579f87187ec8d992fa887788a4ca6603b88102d3","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Shopify/tslint-config-shopify/pulls/62/commits","review_comments_url":"https://api.github.com/repos/Shopify/tslint-config-shopify/pulls/62/comments","review_comment_url":"https://api.github.com/repos/Shopify/tslint-config-shopify/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Shopify/tslint-config-shopify/issues/62/comments","statuses_url":"https://api.github.com/repos/Shopify/tslint-config-shopify/statuses/8907d66c8a83fad38cd13bd7191844aba42179d6","head":{"label":"Shopify:trailing-comma-interface-fixer","ref":"trailing-comma-interface-fixer","sha":"8907d66c8a83fad38cd13bd7191844aba42179d6","user":{"login":"Shopify","id":8085,"avatar_url":"https://avatars2.githubusercontent.com/u/8085?v=3","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"repo":{"id":79374823,"name":"tslint-config-shopify","full_name":"Shopify/tslint-config-shopify","owner":{"login":"Shopify","id":8085,"avatar_url":"https://avatars2.githubusercontent.com/u/8085?v=3","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Shopify/tslint-config-shopify","description":"Shopify’s Typescript rules and configs.","fork":false,"url":"https://api.github.com/repos/Shopify/tslint-config-shopify","forks_url":"https://api.github.com/repos/Shopify/tslint-config-shopify/forks","keys_url":"https://api.github.com/repos/Shopify/tslint-config-shopify/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shopify/tslint-config-shopify/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shopify/tslint-config-shopify/teams","hooks_url":"https://api.github.com/repos/Shopify/tslint-config-shopify/hooks","issue_events_url":"https://api.github.com/repos/Shopify/tslint-config-shopify/issues/events{/number}","events_url":"https://api.github.com/repos/Shopify/tslint-config-shopify/events","assignees_url":"https://api.github.com/repos/Shopify/tslint-config-shopify/assignees{/user}","branches_url":"https://api.github.com/repos/Shopify/tslint-config-shopify/branches{/branch}","tags_url":"https://api.github.com/repos/Shopify/tslint-config-shopify/tags","blobs_url":"https://api.github.com/repos/Shopify/tslint-config-shopify/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shopify/tslint-config-shopify/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shopify/tslint-config-shopify/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shopify/tslint-config-shopify/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shopify/tslint-config-shopify/statuses/{sha}","languages_url":"https://api.github.com/repos/Shopify/tslint-config-shopify/languages","stargazers_url":"https://api.github.com/repos/Shopify/tslint-config-shopify/stargazers","contributors_url":"https://api.github.com/repos/Shopify/tslint-config-shopify/contributors","subscribers_url":"https://api.github.com/repos/Shopify/tslint-config-shopify/subscribers","subscription_url":"https://api.github.com/repos/Shopify/tslint-config-shopify/subscription","commits_url":"https://api.github.com/repos/Shopify/tslint-config-shopify/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shopify/tslint-config-shopify/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shopify/tslint-config-shopify/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shopify/tslint-config-shopify/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shopify/tslint-config-shopify/contents/{+path}","compare_url":"https://api.github.com/repos/Shopify/tslint-config-shopify/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shopify/tslint-config-shopify/merges","archive_url":"https://api.github.com/repos/Shopify/tslint-config-shopify/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shopify/tslint-config-shopify/downloads","issues_url":"https://api.github.com/repos/Shopify/tslint-config-shopify/issues{/number}","pulls_url":"https://api.github.com/repos/Shopify/tslint-config-shopify/pulls{/number}","milestones_url":"https://api.github.com/repos/Shopify/tslint-config-shopify/milestones{/number}","notifications_url":"https://api.github.com/repos/Shopify/tslint-config-shopify/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shopify/tslint-config-shopify/labels{/name}","releases_url":"https://api.github.com/repos/Shopify/tslint-config-shopify/releases{/id}","deployments_url":"https://api.github.com/repos/Shopify/tslint-config-shopify/deployments","created_at":"2017-01-18T19:16:23Z","updated_at":"2017-06-05T05:14:53Z","pushed_at":"2017-06-06T15:01:17Z","git_url":"git://github.com/Shopify/tslint-config-shopify.git","ssh_url":"git@github.com:Shopify/tslint-config-shopify.git","clone_url":"https://github.com/Shopify/tslint-config-shopify.git","svn_url":"https://github.com/Shopify/tslint-config-shopify","homepage":"https://www.npmjs.com/package/tslint-config-shopify","size":127,"stargazers_count":7,"watchers_count":7,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":17,"forks":2,"open_issues":17,"watchers":7,"default_branch":"master"}},"base":{"label":"Shopify:master","ref":"master","sha":"c355ad4d5ad2a71df06ae67403ae36c678be3991","user":{"login":"Shopify","id":8085,"avatar_url":"https://avatars2.githubusercontent.com/u/8085?v=3","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"repo":{"id":79374823,"name":"tslint-config-shopify","full_name":"Shopify/tslint-config-shopify","owner":{"login":"Shopify","id":8085,"avatar_url":"https://avatars2.githubusercontent.com/u/8085?v=3","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Shopify/tslint-config-shopify","description":"Shopify’s Typescript rules and configs.","fork":false,"url":"https://api.github.com/repos/Shopify/tslint-config-shopify","forks_url":"https://api.github.com/repos/Shopify/tslint-config-shopify/forks","keys_url":"https://api.github.com/repos/Shopify/tslint-config-shopify/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shopify/tslint-config-shopify/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shopify/tslint-config-shopify/teams","hooks_url":"https://api.github.com/repos/Shopify/tslint-config-shopify/hooks","issue_events_url":"https://api.github.com/repos/Shopify/tslint-config-shopify/issues/events{/number}","events_url":"https://api.github.com/repos/Shopify/tslint-config-shopify/events","assignees_url":"https://api.github.com/repos/Shopify/tslint-config-shopify/assignees{/user}","branches_url":"https://api.github.com/repos/Shopify/tslint-config-shopify/branches{/branch}","tags_url":"https://api.github.com/repos/Shopify/tslint-config-shopify/tags","blobs_url":"https://api.github.com/repos/Shopify/tslint-config-shopify/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shopify/tslint-config-shopify/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shopify/tslint-config-shopify/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shopify/tslint-config-shopify/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shopify/tslint-config-shopify/statuses/{sha}","languages_url":"https://api.github.com/repos/Shopify/tslint-config-shopify/languages","stargazers_url":"https://api.github.com/repos/Shopify/tslint-config-shopify/stargazers","contributors_url":"https://api.github.com/repos/Shopify/tslint-config-shopify/contributors","subscribers_url":"https://api.github.com/repos/Shopify/tslint-config-shopify/subscribers","subscription_url":"https://api.github.com/repos/Shopify/tslint-config-shopify/subscription","commits_url":"https://api.github.com/repos/Shopify/tslint-config-shopify/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shopify/tslint-config-shopify/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shopify/tslint-config-shopify/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shopify/tslint-config-shopify/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shopify/tslint-config-shopify/contents/{+path}","compare_url":"https://api.github.com/repos/Shopify/tslint-config-shopify/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shopify/tslint-config-shopify/merges","archive_url":"https://api.github.com/repos/Shopify/tslint-config-shopify/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shopify/tslint-config-shopify/downloads","issues_url":"https://api.github.com/repos/Shopify/tslint-config-shopify/issues{/number}","pulls_url":"https://api.github.com/repos/Shopify/tslint-config-shopify/pulls{/number}","milestones_url":"https://api.github.com/repos/Shopify/tslint-config-shopify/milestones{/number}","notifications_url":"https://api.github.com/repos/Shopify/tslint-config-shopify/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shopify/tslint-config-shopify/labels{/name}","releases_url":"https://api.github.com/repos/Shopify/tslint-config-shopify/releases{/id}","deployments_url":"https://api.github.com/repos/Shopify/tslint-config-shopify/deployments","created_at":"2017-01-18T19:16:23Z","updated_at":"2017-06-05T05:14:53Z","pushed_at":"2017-06-06T15:01:17Z","git_url":"git://github.com/Shopify/tslint-config-shopify.git","ssh_url":"git@github.com:Shopify/tslint-config-shopify.git","clone_url":"https://github.com/Shopify/tslint-config-shopify.git","svn_url":"https://github.com/Shopify/tslint-config-shopify","homepage":"https://www.npmjs.com/package/tslint-config-shopify","size":127,"stargazers_count":7,"watchers_count":7,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":17,"forks":2,"open_issues":17,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Shopify/tslint-config-shopify/pulls/62"},"html":{"href":"https://github.com/Shopify/tslint-config-shopify/pull/62"},"issue":{"href":"https://api.github.com/repos/Shopify/tslint-config-shopify/issues/62"},"comments":{"href":"https://api.github.com/repos/Shopify/tslint-config-shopify/issues/62/comments"},"review_comments":{"href":"https://api.github.com/repos/Shopify/tslint-config-shopify/pulls/62/comments"},"review_comment":{"href":"https://api.github.com/repos/Shopify/tslint-config-shopify/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Shopify/tslint-config-shopify/pulls/62/commits"},"statuses":{"href":"https://api.github.com/repos/Shopify/tslint-config-shopify/statuses/8907d66c8a83fad38cd13bd7191844aba42179d6"}}}}
{"actor":{"display_login":"ismail-syed"}}