{"action":"created","comment":{"url":"https://api.github.com/repos/Originate/exosphere/pulls/comments/155060712","pull_request_review_id":81317318,"id":155060712,"diff_hunk":"@@ -1,12 +1,14 @@\n-Feature: Service endpoint enviornment variable\n+Feature: Service endpoint enviornment variables\n \n   As an Exosphere developer\n-  I want the services to know where each other are available from the outside world\n-  So clients can talk directly to other services\n+  I want the services to know where each other are available\n+  So that communication between services are possible\n \n   Rules:\n   - \"<NAME>_EXTERNAL_ORIGIN\" is passed as an environment variable to\n     each service for any public service\n+  - \"<NAME>_ORIGIN\" is passed as an environment variable to","path":"features/run/service_endpoint_environment_variables.feature","position":13,"original_position":13,"commit_id":"d596628a7ffdecf151d6d67bec4817f183de8286","original_commit_id":"d596628a7ffdecf151d6d67bec4817f183de8286","user":{"login":"charlierudolph","id":1676758,"avatar_url":"https://avatars2.githubusercontent.com/u/1676758?v=4","gravatar_id":"","url":"https://api.github.com/users/charlierudolph","html_url":"https://github.com/charlierudolph","followers_url":"https://api.github.com/users/charlierudolph/followers","following_url":"https://api.github.com/users/charlierudolph/following{/other_user}","gists_url":"https://api.github.com/users/charlierudolph/gists{/gist_id}","starred_url":"https://api.github.com/users/charlierudolph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charlierudolph/subscriptions","organizations_url":"https://api.github.com/users/charlierudolph/orgs","repos_url":"https://api.github.com/users/charlierudolph/repos","events_url":"https://api.github.com/users/charlierudolph/events{/privacy}","received_events_url":"https://api.github.com/users/charlierudolph/received_events","type":"User","site_admin":false},"body":"thoughts on making this env var `<NAME>_INTERNAL_ORIGIN`. I think that is more clear.","created_at":"2017-12-05T20:02:59Z","updated_at":"2017-12-05T20:04:05Z","html_url":"https://github.com/Originate/exosphere/pull/839#discussion_r155060712","pull_request_url":"https://api.github.com/repos/Originate/exosphere/pulls/839","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Originate/exosphere/pulls/comments/155060712"},"html":{"href":"https://github.com/Originate/exosphere/pull/839#discussion_r155060712"},"pull_request":{"href":"https://api.github.com/repos/Originate/exosphere/pulls/839"}}},"pull_request":{"url":"https://api.github.com/repos/Originate/exosphere/pulls/839","id":156343114,"html_url":"https://github.com/Originate/exosphere/pull/839","diff_url":"https://github.com/Originate/exosphere/pull/839.diff","patch_url":"https://github.com/Originate/exosphere/pull/839.patch","issue_url":"https://api.github.com/repos/Originate/exosphere/issues/839","number":839,"state":"open","locked":false,"title":"Inject internal origin env vars","user":{"login":"hugobho","id":7258240,"avatar_url":"https://avatars0.githubusercontent.com/u/7258240?v=4","gravatar_id":"","url":"https://api.github.com/users/hugobho","html_url":"https://github.com/hugobho","followers_url":"https://api.github.com/users/hugobho/followers","following_url":"https://api.github.com/users/hugobho/following{/other_user}","gists_url":"https://api.github.com/users/hugobho/gists{/gist_id}","starred_url":"https://api.github.com/users/hugobho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hugobho/subscriptions","organizations_url":"https://api.github.com/users/hugobho/orgs","repos_url":"https://api.github.com/users/hugobho/repos","events_url":"https://api.github.com/users/hugobho/events{/privacy}","received_events_url":"https://api.github.com/users/hugobho/received_events","type":"User","site_admin":false},"body":"<!-- mention the issue this PR addresses -->\r\nresolves https://github.com/Originate/exosphere/issues/836\r\n\r\n<!-- a short description of the change in addition to what is already mentioned in the issue above -->\r\n\r\n<!-- tag a few reviewers -->\r\n","created_at":"2017-12-05T00:31:55Z","updated_at":"2017-12-05T20:04:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"73714aec845d80de8388c88dde74a0a0d1447bb0","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Originate/exosphere/pulls/839/commits","review_comments_url":"https://api.github.com/repos/Originate/exosphere/pulls/839/comments","review_comment_url":"https://api.github.com/repos/Originate/exosphere/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Originate/exosphere/issues/839/comments","statuses_url":"https://api.github.com/repos/Originate/exosphere/statuses/d596628a7ffdecf151d6d67bec4817f183de8286","head":{"label":"Originate:hh-internal-origin","ref":"hh-internal-origin","sha":"d596628a7ffdecf151d6d67bec4817f183de8286","user":{"login":"Originate","id":1627168,"avatar_url":"https://avatars3.githubusercontent.com/u/1627168?v=4","gravatar_id":"","url":"https://api.github.com/users/Originate","html_url":"https://github.com/Originate","followers_url":"https://api.github.com/users/Originate/followers","following_url":"https://api.github.com/users/Originate/following{/other_user}","gists_url":"https://api.github.com/users/Originate/gists{/gist_id}","starred_url":"https://api.github.com/users/Originate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Originate/subscriptions","organizations_url":"https://api.github.com/users/Originate/orgs","repos_url":"https://api.github.com/users/Originate/repos","events_url":"https://api.github.com/users/Originate/events{/privacy}","received_events_url":"https://api.github.com/users/Originate/received_events","type":"Organization","site_admin":false},"repo":{"id":75137299,"name":"exosphere","full_name":"Originate/exosphere","owner":{"login":"Originate","id":1627168,"avatar_url":"https://avatars3.githubusercontent.com/u/1627168?v=4","gravatar_id":"","url":"https://api.github.com/users/Originate","html_url":"https://github.com/Originate","followers_url":"https://api.github.com/users/Originate/followers","following_url":"https://api.github.com/users/Originate/following{/other_user}","gists_url":"https://api.github.com/users/Originate/gists{/gist_id}","starred_url":"https://api.github.com/users/Originate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Originate/subscriptions","organizations_url":"https://api.github.com/users/Originate/orgs","repos_url":"https://api.github.com/users/Originate/repos","events_url":"https://api.github.com/users/Originate/events{/privacy}","received_events_url":"https://api.github.com/users/Originate/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Originate/exosphere","description":"A modern cloud-based micro-service framework","fork":false,"url":"https://api.github.com/repos/Originate/exosphere","forks_url":"https://api.github.com/repos/Originate/exosphere/forks","keys_url":"https://api.github.com/repos/Originate/exosphere/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Originate/exosphere/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Originate/exosphere/teams","hooks_url":"https://api.github.com/repos/Originate/exosphere/hooks","issue_events_url":"https://api.github.com/repos/Originate/exosphere/issues/events{/number}","events_url":"https://api.github.com/repos/Originate/exosphere/events","assignees_url":"https://api.github.com/repos/Originate/exosphere/assignees{/user}","branches_url":"https://api.github.com/repos/Originate/exosphere/branches{/branch}","tags_url":"https://api.github.com/repos/Originate/exosphere/tags","blobs_url":"https://api.github.com/repos/Originate/exosphere/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Originate/exosphere/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Originate/exosphere/git/refs{/sha}","trees_url":"https://api.github.com/repos/Originate/exosphere/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Originate/exosphere/statuses/{sha}","languages_url":"https://api.github.com/repos/Originate/exosphere/languages","stargazers_url":"https://api.github.com/repos/Originate/exosphere/stargazers","contributors_url":"https://api.github.com/repos/Originate/exosphere/contributors","subscribers_url":"https://api.github.com/repos/Originate/exosphere/subscribers","subscription_url":"https://api.github.com/repos/Originate/exosphere/subscription","commits_url":"https://api.github.com/repos/Originate/exosphere/commits{/sha}","git_commits_url":"https://api.github.com/repos/Originate/exosphere/git/commits{/sha}","comments_url":"https://api.github.com/repos/Originate/exosphere/comments{/number}","issue_comment_url":"https://api.github.com/repos/Originate/exosphere/issues/comments{/number}","contents_url":"https://api.github.com/repos/Originate/exosphere/contents/{+path}","compare_url":"https://api.github.com/repos/Originate/exosphere/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Originate/exosphere/merges","archive_url":"https://api.github.com/repos/Originate/exosphere/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Originate/exosphere/downloads","issues_url":"https://api.github.com/repos/Originate/exosphere/issues{/number}","pulls_url":"https://api.github.com/repos/Originate/exosphere/pulls{/number}","milestones_url":"https://api.github.com/repos/Originate/exosphere/milestones{/number}","notifications_url":"https://api.github.com/repos/Originate/exosphere/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Originate/exosphere/labels{/name}","releases_url":"https://api.github.com/repos/Originate/exosphere/releases{/id}","deployments_url":"https://api.github.com/repos/Originate/exosphere/deployments","created_at":"2016-11-30T01:09:58Z","updated_at":"2017-12-04T18:33:04Z","pushed_at":"2017-12-05T20:01:27Z","git_url":"git://github.com/Originate/exosphere.git","ssh_url":"git@github.com:Originate/exosphere.git","clone_url":"https://github.com/Originate/exosphere.git","svn_url":"https://github.com/Originate/exosphere","homepage":null,"size":27235,"stargazers_count":13,"watchers_count":13,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":29,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":6,"open_issues":29,"watchers":13,"default_branch":"master"}},"base":{"label":"Originate:hh-endpoint-refactor","ref":"hh-endpoint-refactor","sha":"32bdbcb4aff6de0059be6506d1110292892ec77f","user":{"login":"Originate","id":1627168,"avatar_url":"https://avatars3.githubusercontent.com/u/1627168?v=4","gravatar_id":"","url":"https://api.github.com/users/Originate","html_url":"https://github.com/Originate","followers_url":"https://api.github.com/users/Originate/followers","following_url":"https://api.github.com/users/Originate/following{/other_user}","gists_url":"https://api.github.com/users/Originate/gists{/gist_id}","starred_url":"https://api.github.com/users/Originate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Originate/subscriptions","organizations_url":"https://api.github.com/users/Originate/orgs","repos_url":"https://api.github.com/users/Originate/repos","events_url":"https://api.github.com/users/Originate/events{/privacy}","received_events_url":"https://api.github.com/users/Originate/received_events","type":"Organization","site_admin":false},"repo":{"id":75137299,"name":"exosphere","full_name":"Originate/exosphere","owner":{"login":"Originate","id":1627168,"avatar_url":"https://avatars3.githubusercontent.com/u/1627168?v=4","gravatar_id":"","url":"https://api.github.com/users/Originate","html_url":"https://github.com/Originate","followers_url":"https://api.github.com/users/Originate/followers","following_url":"https://api.github.com/users/Originate/following{/other_user}","gists_url":"https://api.github.com/users/Originate/gists{/gist_id}","starred_url":"https://api.github.com/users/Originate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Originate/subscriptions","organizations_url":"https://api.github.com/users/Originate/orgs","repos_url":"https://api.github.com/users/Originate/repos","events_url":"https://api.github.com/users/Originate/events{/privacy}","received_events_url":"https://api.github.com/users/Originate/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Originate/exosphere","description":"A modern cloud-based micro-service framework","fork":false,"url":"https://api.github.com/repos/Originate/exosphere","forks_url":"https://api.github.com/repos/Originate/exosphere/forks","keys_url":"https://api.github.com/repos/Originate/exosphere/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Originate/exosphere/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Originate/exosphere/teams","hooks_url":"https://api.github.com/repos/Originate/exosphere/hooks","issue_events_url":"https://api.github.com/repos/Originate/exosphere/issues/events{/number}","events_url":"https://api.github.com/repos/Originate/exosphere/events","assignees_url":"https://api.github.com/repos/Originate/exosphere/assignees{/user}","branches_url":"https://api.github.com/repos/Originate/exosphere/branches{/branch}","tags_url":"https://api.github.com/repos/Originate/exosphere/tags","blobs_url":"https://api.github.com/repos/Originate/exosphere/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Originate/exosphere/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Originate/exosphere/git/refs{/sha}","trees_url":"https://api.github.com/repos/Originate/exosphere/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Originate/exosphere/statuses/{sha}","languages_url":"https://api.github.com/repos/Originate/exosphere/languages","stargazers_url":"https://api.github.com/repos/Originate/exosphere/stargazers","contributors_url":"https://api.github.com/repos/Originate/exosphere/contributors","subscribers_url":"https://api.github.com/repos/Originate/exosphere/subscribers","subscription_url":"https://api.github.com/repos/Originate/exosphere/subscription","commits_url":"https://api.github.com/repos/Originate/exosphere/commits{/sha}","git_commits_url":"https://api.github.com/repos/Originate/exosphere/git/commits{/sha}","comments_url":"https://api.github.com/repos/Originate/exosphere/comments{/number}","issue_comment_url":"https://api.github.com/repos/Originate/exosphere/issues/comments{/number}","contents_url":"https://api.github.com/repos/Originate/exosphere/contents/{+path}","compare_url":"https://api.github.com/repos/Originate/exosphere/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Originate/exosphere/merges","archive_url":"https://api.github.com/repos/Originate/exosphere/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Originate/exosphere/downloads","issues_url":"https://api.github.com/repos/Originate/exosphere/issues{/number}","pulls_url":"https://api.github.com/repos/Originate/exosphere/pulls{/number}","milestones_url":"https://api.github.com/repos/Originate/exosphere/milestones{/number}","notifications_url":"https://api.github.com/repos/Originate/exosphere/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Originate/exosphere/labels{/name}","releases_url":"https://api.github.com/repos/Originate/exosphere/releases{/id}","deployments_url":"https://api.github.com/repos/Originate/exosphere/deployments","created_at":"2016-11-30T01:09:58Z","updated_at":"2017-12-04T18:33:04Z","pushed_at":"2017-12-05T20:01:27Z","git_url":"git://github.com/Originate/exosphere.git","ssh_url":"git@github.com:Originate/exosphere.git","clone_url":"https://github.com/Originate/exosphere.git","svn_url":"https://github.com/Originate/exosphere","homepage":null,"size":27235,"stargazers_count":13,"watchers_count":13,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":29,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":6,"open_issues":29,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Originate/exosphere/pulls/839"},"html":{"href":"https://github.com/Originate/exosphere/pull/839"},"issue":{"href":"https://api.github.com/repos/Originate/exosphere/issues/839"},"comments":{"href":"https://api.github.com/repos/Originate/exosphere/issues/839/comments"},"review_comments":{"href":"https://api.github.com/repos/Originate/exosphere/pulls/839/comments"},"review_comment":{"href":"https://api.github.com/repos/Originate/exosphere/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Originate/exosphere/pulls/839/commits"},"statuses":{"href":"https://api.github.com/repos/Originate/exosphere/statuses/d596628a7ffdecf151d6d67bec4817f183de8286"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"charlierudolph"}}