{"action":"created","comment":{"url":"https://api.github.com/repos/sdminonne/workflow-controller/pulls/comments/148802476","pull_request_review_id":74103351,"id":148802476,"diff_hunk":"@@ -36,13 +36,12 @@ func deleteAllJobs(kubeClient clientset.Interface, workflow *wapi.Workflow) {\n \t\treturn\n \t}\n \tfor i := range jobs.Items {\n-\t\tkubeClient.Batch().Jobs(workflow.Namespace).Delete(jobs.Items[i].Name, cascadeDeleteOptions(0))\n+\t\tkubeClient.Batch().Jobs(workflow.Namespace).Delete(jobs.Items[i].Name /*cascadeDeleteOptions(0)*/, nil)","path":"test/e2e/workflows.go","position":5,"original_position":5,"commit_id":"4285ba43e38723e0a1a5f1f0137e2fb815649251","original_commit_id":"4285ba43e38723e0a1a5f1f0137e2fb815649251","user":{"login":"clamoriniere1A","id":12412113,"avatar_url":"https://avatars3.githubusercontent.com/u/12412113?v=4","gravatar_id":"","url":"https://api.github.com/users/clamoriniere1A","html_url":"https://github.com/clamoriniere1A","followers_url":"https://api.github.com/users/clamoriniere1A/followers","following_url":"https://api.github.com/users/clamoriniere1A/following{/other_user}","gists_url":"https://api.github.com/users/clamoriniere1A/gists{/gist_id}","starred_url":"https://api.github.com/users/clamoriniere1A/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clamoriniere1A/subscriptions","organizations_url":"https://api.github.com/users/clamoriniere1A/orgs","repos_url":"https://api.github.com/users/clamoriniere1A/repos","events_url":"https://api.github.com/users/clamoriniere1A/events{/privacy}","received_events_url":"https://api.github.com/users/clamoriniere1A/received_events","type":"User","site_admin":false},"body":"this dead code can be removed","created_at":"2017-11-03T14:47:53Z","updated_at":"2017-11-03T14:48:27Z","html_url":"https://github.com/sdminonne/workflow-controller/pull/28#discussion_r148802476","pull_request_url":"https://api.github.com/repos/sdminonne/workflow-controller/pulls/28","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/sdminonne/workflow-controller/pulls/comments/148802476"},"html":{"href":"https://github.com/sdminonne/workflow-controller/pull/28#discussion_r148802476"},"pull_request":{"href":"https://api.github.com/repos/sdminonne/workflow-controller/pulls/28"}}},"pull_request":{"url":"https://api.github.com/repos/sdminonne/workflow-controller/pulls/28","id":148520952,"html_url":"https://github.com/sdminonne/workflow-controller/pull/28","diff_url":"https://github.com/sdminonne/workflow-controller/pull/28.diff","patch_url":"https://github.com/sdminonne/workflow-controller/pull/28.patch","issue_url":"https://api.github.com/repos/sdminonne/workflow-controller/issues/28","number":28,"state":"open","locked":false,"title":"To add a Garbage collection","user":{"login":"sdminonne","id":9527409,"avatar_url":"https://avatars3.githubusercontent.com/u/9527409?v=4","gravatar_id":"","url":"https://api.github.com/users/sdminonne","html_url":"https://github.com/sdminonne","followers_url":"https://api.github.com/users/sdminonne/followers","following_url":"https://api.github.com/users/sdminonne/following{/other_user}","gists_url":"https://api.github.com/users/sdminonne/gists{/gist_id}","starred_url":"https://api.github.com/users/sdminonne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdminonne/subscriptions","organizations_url":"https://api.github.com/users/sdminonne/orgs","repos_url":"https://api.github.com/users/sdminonne/repos","events_url":"https://api.github.com/users/sdminonne/events{/privacy}","received_events_url":"https://api.github.com/users/sdminonne/received_events","type":"User","site_admin":false},"body":"@clamoriniere1A @EricMountain-1A a mind validate the approach?","created_at":"2017-10-24T21:44:00Z","updated_at":"2017-11-03T14:48:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"03ce786ad6ab83770519544e16297d26b5201965","assignee":null,"assignees":[],"requested_reviewers":[{"login":"EricMountain-1A","id":8555225,"avatar_url":"https://avatars3.githubusercontent.com/u/8555225?v=4","gravatar_id":"","url":"https://api.github.com/users/EricMountain-1A","html_url":"https://github.com/EricMountain-1A","followers_url":"https://api.github.com/users/EricMountain-1A/followers","following_url":"https://api.github.com/users/EricMountain-1A/following{/other_user}","gists_url":"https://api.github.com/users/EricMountain-1A/gists{/gist_id}","starred_url":"https://api.github.com/users/EricMountain-1A/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EricMountain-1A/subscriptions","organizations_url":"https://api.github.com/users/EricMountain-1A/orgs","repos_url":"https://api.github.com/users/EricMountain-1A/repos","events_url":"https://api.github.com/users/EricMountain-1A/events{/privacy}","received_events_url":"https://api.github.com/users/EricMountain-1A/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/sdminonne/workflow-controller/pulls/28/commits","review_comments_url":"https://api.github.com/repos/sdminonne/workflow-controller/pulls/28/comments","review_comment_url":"https://api.github.com/repos/sdminonne/workflow-controller/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sdminonne/workflow-controller/issues/28/comments","statuses_url":"https://api.github.com/repos/sdminonne/workflow-controller/statuses/4285ba43e38723e0a1a5f1f0137e2fb815649251","head":{"label":"sdminonne:GarbageCollection","ref":"GarbageCollection","sha":"4285ba43e38723e0a1a5f1f0137e2fb815649251","user":{"login":"sdminonne","id":9527409,"avatar_url":"https://avatars3.githubusercontent.com/u/9527409?v=4","gravatar_id":"","url":"https://api.github.com/users/sdminonne","html_url":"https://github.com/sdminonne","followers_url":"https://api.github.com/users/sdminonne/followers","following_url":"https://api.github.com/users/sdminonne/following{/other_user}","gists_url":"https://api.github.com/users/sdminonne/gists{/gist_id}","starred_url":"https://api.github.com/users/sdminonne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdminonne/subscriptions","organizations_url":"https://api.github.com/users/sdminonne/orgs","repos_url":"https://api.github.com/users/sdminonne/repos","events_url":"https://api.github.com/users/sdminonne/events{/privacy}","received_events_url":"https://api.github.com/users/sdminonne/received_events","type":"User","site_admin":false},"repo":{"id":70502563,"name":"workflow-controller","full_name":"sdminonne/workflow-controller","owner":{"login":"sdminonne","id":9527409,"avatar_url":"https://avatars3.githubusercontent.com/u/9527409?v=4","gravatar_id":"","url":"https://api.github.com/users/sdminonne","html_url":"https://github.com/sdminonne","followers_url":"https://api.github.com/users/sdminonne/followers","following_url":"https://api.github.com/users/sdminonne/following{/other_user}","gists_url":"https://api.github.com/users/sdminonne/gists{/gist_id}","starred_url":"https://api.github.com/users/sdminonne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdminonne/subscriptions","organizations_url":"https://api.github.com/users/sdminonne/orgs","repos_url":"https://api.github.com/users/sdminonne/repos","events_url":"https://api.github.com/users/sdminonne/events{/privacy}","received_events_url":"https://api.github.com/users/sdminonne/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sdminonne/workflow-controller","description":"Kubernetes workflow controller","fork":false,"url":"https://api.github.com/repos/sdminonne/workflow-controller","forks_url":"https://api.github.com/repos/sdminonne/workflow-controller/forks","keys_url":"https://api.github.com/repos/sdminonne/workflow-controller/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sdminonne/workflow-controller/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sdminonne/workflow-controller/teams","hooks_url":"https://api.github.com/repos/sdminonne/workflow-controller/hooks","issue_events_url":"https://api.github.com/repos/sdminonne/workflow-controller/issues/events{/number}","events_url":"https://api.github.com/repos/sdminonne/workflow-controller/events","assignees_url":"https://api.github.com/repos/sdminonne/workflow-controller/assignees{/user}","branches_url":"https://api.github.com/repos/sdminonne/workflow-controller/branches{/branch}","tags_url":"https://api.github.com/repos/sdminonne/workflow-controller/tags","blobs_url":"https://api.github.com/repos/sdminonne/workflow-controller/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sdminonne/workflow-controller/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sdminonne/workflow-controller/git/refs{/sha}","trees_url":"https://api.github.com/repos/sdminonne/workflow-controller/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sdminonne/workflow-controller/statuses/{sha}","languages_url":"https://api.github.com/repos/sdminonne/workflow-controller/languages","stargazers_url":"https://api.github.com/repos/sdminonne/workflow-controller/stargazers","contributors_url":"https://api.github.com/repos/sdminonne/workflow-controller/contributors","subscribers_url":"https://api.github.com/repos/sdminonne/workflow-controller/subscribers","subscription_url":"https://api.github.com/repos/sdminonne/workflow-controller/subscription","commits_url":"https://api.github.com/repos/sdminonne/workflow-controller/commits{/sha}","git_commits_url":"https://api.github.com/repos/sdminonne/workflow-controller/git/commits{/sha}","comments_url":"https://api.github.com/repos/sdminonne/workflow-controller/comments{/number}","issue_comment_url":"https://api.github.com/repos/sdminonne/workflow-controller/issues/comments{/number}","contents_url":"https://api.github.com/repos/sdminonne/workflow-controller/contents/{+path}","compare_url":"https://api.github.com/repos/sdminonne/workflow-controller/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sdminonne/workflow-controller/merges","archive_url":"https://api.github.com/repos/sdminonne/workflow-controller/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sdminonne/workflow-controller/downloads","issues_url":"https://api.github.com/repos/sdminonne/workflow-controller/issues{/number}","pulls_url":"https://api.github.com/repos/sdminonne/workflow-controller/pulls{/number}","milestones_url":"https://api.github.com/repos/sdminonne/workflow-controller/milestones{/number}","notifications_url":"https://api.github.com/repos/sdminonne/workflow-controller/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sdminonne/workflow-controller/labels{/name}","releases_url":"https://api.github.com/repos/sdminonne/workflow-controller/releases{/id}","deployments_url":"https://api.github.com/repos/sdminonne/workflow-controller/deployments","created_at":"2016-10-10T15:39:35Z","updated_at":"2017-10-19T20:34:28Z","pushed_at":"2017-11-03T14:09:20Z","git_url":"git://github.com/sdminonne/workflow-controller.git","ssh_url":"git@github.com:sdminonne/workflow-controller.git","clone_url":"https://github.com/sdminonne/workflow-controller.git","svn_url":"https://github.com/sdminonne/workflow-controller","homepage":null,"size":33751,"stargazers_count":12,"watchers_count":12,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":11,"forks":7,"open_issues":11,"watchers":12,"default_branch":"master"}},"base":{"label":"sdminonne:master","ref":"master","sha":"d107a8c330b5c8e00b4194b46eb636a35f6c57be","user":{"login":"sdminonne","id":9527409,"avatar_url":"https://avatars3.githubusercontent.com/u/9527409?v=4","gravatar_id":"","url":"https://api.github.com/users/sdminonne","html_url":"https://github.com/sdminonne","followers_url":"https://api.github.com/users/sdminonne/followers","following_url":"https://api.github.com/users/sdminonne/following{/other_user}","gists_url":"https://api.github.com/users/sdminonne/gists{/gist_id}","starred_url":"https://api.github.com/users/sdminonne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdminonne/subscriptions","organizations_url":"https://api.github.com/users/sdminonne/orgs","repos_url":"https://api.github.com/users/sdminonne/repos","events_url":"https://api.github.com/users/sdminonne/events{/privacy}","received_events_url":"https://api.github.com/users/sdminonne/received_events","type":"User","site_admin":false},"repo":{"id":70502563,"name":"workflow-controller","full_name":"sdminonne/workflow-controller","owner":{"login":"sdminonne","id":9527409,"avatar_url":"https://avatars3.githubusercontent.com/u/9527409?v=4","gravatar_id":"","url":"https://api.github.com/users/sdminonne","html_url":"https://github.com/sdminonne","followers_url":"https://api.github.com/users/sdminonne/followers","following_url":"https://api.github.com/users/sdminonne/following{/other_user}","gists_url":"https://api.github.com/users/sdminonne/gists{/gist_id}","starred_url":"https://api.github.com/users/sdminonne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdminonne/subscriptions","organizations_url":"https://api.github.com/users/sdminonne/orgs","repos_url":"https://api.github.com/users/sdminonne/repos","events_url":"https://api.github.com/users/sdminonne/events{/privacy}","received_events_url":"https://api.github.com/users/sdminonne/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sdminonne/workflow-controller","description":"Kubernetes workflow controller","fork":false,"url":"https://api.github.com/repos/sdminonne/workflow-controller","forks_url":"https://api.github.com/repos/sdminonne/workflow-controller/forks","keys_url":"https://api.github.com/repos/sdminonne/workflow-controller/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sdminonne/workflow-controller/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sdminonne/workflow-controller/teams","hooks_url":"https://api.github.com/repos/sdminonne/workflow-controller/hooks","issue_events_url":"https://api.github.com/repos/sdminonne/workflow-controller/issues/events{/number}","events_url":"https://api.github.com/repos/sdminonne/workflow-controller/events","assignees_url":"https://api.github.com/repos/sdminonne/workflow-controller/assignees{/user}","branches_url":"https://api.github.com/repos/sdminonne/workflow-controller/branches{/branch}","tags_url":"https://api.github.com/repos/sdminonne/workflow-controller/tags","blobs_url":"https://api.github.com/repos/sdminonne/workflow-controller/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sdminonne/workflow-controller/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sdminonne/workflow-controller/git/refs{/sha}","trees_url":"https://api.github.com/repos/sdminonne/workflow-controller/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sdminonne/workflow-controller/statuses/{sha}","languages_url":"https://api.github.com/repos/sdminonne/workflow-controller/languages","stargazers_url":"https://api.github.com/repos/sdminonne/workflow-controller/stargazers","contributors_url":"https://api.github.com/repos/sdminonne/workflow-controller/contributors","subscribers_url":"https://api.github.com/repos/sdminonne/workflow-controller/subscribers","subscription_url":"https://api.github.com/repos/sdminonne/workflow-controller/subscription","commits_url":"https://api.github.com/repos/sdminonne/workflow-controller/commits{/sha}","git_commits_url":"https://api.github.com/repos/sdminonne/workflow-controller/git/commits{/sha}","comments_url":"https://api.github.com/repos/sdminonne/workflow-controller/comments{/number}","issue_comment_url":"https://api.github.com/repos/sdminonne/workflow-controller/issues/comments{/number}","contents_url":"https://api.github.com/repos/sdminonne/workflow-controller/contents/{+path}","compare_url":"https://api.github.com/repos/sdminonne/workflow-controller/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sdminonne/workflow-controller/merges","archive_url":"https://api.github.com/repos/sdminonne/workflow-controller/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sdminonne/workflow-controller/downloads","issues_url":"https://api.github.com/repos/sdminonne/workflow-controller/issues{/number}","pulls_url":"https://api.github.com/repos/sdminonne/workflow-controller/pulls{/number}","milestones_url":"https://api.github.com/repos/sdminonne/workflow-controller/milestones{/number}","notifications_url":"https://api.github.com/repos/sdminonne/workflow-controller/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sdminonne/workflow-controller/labels{/name}","releases_url":"https://api.github.com/repos/sdminonne/workflow-controller/releases{/id}","deployments_url":"https://api.github.com/repos/sdminonne/workflow-controller/deployments","created_at":"2016-10-10T15:39:35Z","updated_at":"2017-10-19T20:34:28Z","pushed_at":"2017-11-03T14:09:20Z","git_url":"git://github.com/sdminonne/workflow-controller.git","ssh_url":"git@github.com:sdminonne/workflow-controller.git","clone_url":"https://github.com/sdminonne/workflow-controller.git","svn_url":"https://github.com/sdminonne/workflow-controller","homepage":null,"size":33751,"stargazers_count":12,"watchers_count":12,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":11,"forks":7,"open_issues":11,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sdminonne/workflow-controller/pulls/28"},"html":{"href":"https://github.com/sdminonne/workflow-controller/pull/28"},"issue":{"href":"https://api.github.com/repos/sdminonne/workflow-controller/issues/28"},"comments":{"href":"https://api.github.com/repos/sdminonne/workflow-controller/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/sdminonne/workflow-controller/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/sdminonne/workflow-controller/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sdminonne/workflow-controller/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/sdminonne/workflow-controller/statuses/4285ba43e38723e0a1a5f1f0137e2fb815649251"}},"author_association":"OWNER"}}
{"actor":{"display_login":"clamoriniere1A"}}