{"action":"opened","number":46,"pull_request":{"url":"https://api.github.com/repos/schibsted/strongbox/pulls/46","id":156186569,"html_url":"https://github.com/schibsted/strongbox/pull/46","diff_url":"https://github.com/schibsted/strongbox/pull/46.diff","patch_url":"https://github.com/schibsted/strongbox/pull/46.patch","issue_url":"https://api.github.com/repos/schibsted/strongbox/issues/46","number":46,"state":"open","locked":false,"title":"Handle missing secret in InMemoryPlaintextSecret.","user":{"login":"zamzterz","id":1183700,"avatar_url":"https://avatars0.githubusercontent.com/u/1183700?v=4","gravatar_id":"","url":"https://api.github.com/users/zamzterz","html_url":"https://github.com/zamzterz","followers_url":"https://api.github.com/users/zamzterz/followers","following_url":"https://api.github.com/users/zamzterz/following{/other_user}","gists_url":"https://api.github.com/users/zamzterz/gists{/gist_id}","starred_url":"https://api.github.com/users/zamzterz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zamzterz/subscriptions","organizations_url":"https://api.github.com/users/zamzterz/orgs","repos_url":"https://api.github.com/users/zamzterz/repos","events_url":"https://api.github.com/users/zamzterz/events{/privacy}","received_events_url":"https://api.github.com/users/zamzterz/received_events","type":"User","site_admin":false},"body":"Simplify the implementation by using existing functionality from\r\nStringDerivedProperty to decrypt the secret each time it changes.\r\n\r\n*Previous implementation resulted in a `NullPointerException` being thrown for the test `testMissingSecretResultsInNull`.*","created_at":"2017-12-04T12:39:44Z","updated_at":"2017-12-04T12:39:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/schibsted/strongbox/pulls/46/commits","review_comments_url":"https://api.github.com/repos/schibsted/strongbox/pulls/46/comments","review_comment_url":"https://api.github.com/repos/schibsted/strongbox/pulls/comments{/number}","comments_url":"https://api.github.com/repos/schibsted/strongbox/issues/46/comments","statuses_url":"https://api.github.com/repos/schibsted/strongbox/statuses/30dd6fb8564eeeca165860e2b2197d597f516c5f","head":{"label":"zamzterz:refactor-inmemoryplaintextsecret","ref":"refactor-inmemoryplaintextsecret","sha":"30dd6fb8564eeeca165860e2b2197d597f516c5f","user":{"login":"zamzterz","id":1183700,"avatar_url":"https://avatars0.githubusercontent.com/u/1183700?v=4","gravatar_id":"","url":"https://api.github.com/users/zamzterz","html_url":"https://github.com/zamzterz","followers_url":"https://api.github.com/users/zamzterz/followers","following_url":"https://api.github.com/users/zamzterz/following{/other_user}","gists_url":"https://api.github.com/users/zamzterz/gists{/gist_id}","starred_url":"https://api.github.com/users/zamzterz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zamzterz/subscriptions","organizations_url":"https://api.github.com/users/zamzterz/orgs","repos_url":"https://api.github.com/users/zamzterz/repos","events_url":"https://api.github.com/users/zamzterz/events{/privacy}","received_events_url":"https://api.github.com/users/zamzterz/received_events","type":"User","site_admin":false},"repo":{"id":112729667,"name":"strongbox","full_name":"zamzterz/strongbox","owner":{"login":"zamzterz","id":1183700,"avatar_url":"https://avatars0.githubusercontent.com/u/1183700?v=4","gravatar_id":"","url":"https://api.github.com/users/zamzterz","html_url":"https://github.com/zamzterz","followers_url":"https://api.github.com/users/zamzterz/followers","following_url":"https://api.github.com/users/zamzterz/following{/other_user}","gists_url":"https://api.github.com/users/zamzterz/gists{/gist_id}","starred_url":"https://api.github.com/users/zamzterz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zamzterz/subscriptions","organizations_url":"https://api.github.com/users/zamzterz/orgs","repos_url":"https://api.github.com/users/zamzterz/repos","events_url":"https://api.github.com/users/zamzterz/events{/privacy}","received_events_url":"https://api.github.com/users/zamzterz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zamzterz/strongbox","description":"A secret manager for AWS","fork":true,"url":"https://api.github.com/repos/zamzterz/strongbox","forks_url":"https://api.github.com/repos/zamzterz/strongbox/forks","keys_url":"https://api.github.com/repos/zamzterz/strongbox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zamzterz/strongbox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zamzterz/strongbox/teams","hooks_url":"https://api.github.com/repos/zamzterz/strongbox/hooks","issue_events_url":"https://api.github.com/repos/zamzterz/strongbox/issues/events{/number}","events_url":"https://api.github.com/repos/zamzterz/strongbox/events","assignees_url":"https://api.github.com/repos/zamzterz/strongbox/assignees{/user}","branches_url":"https://api.github.com/repos/zamzterz/strongbox/branches{/branch}","tags_url":"https://api.github.com/repos/zamzterz/strongbox/tags","blobs_url":"https://api.github.com/repos/zamzterz/strongbox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zamzterz/strongbox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zamzterz/strongbox/git/refs{/sha}","trees_url":"https://api.github.com/repos/zamzterz/strongbox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zamzterz/strongbox/statuses/{sha}","languages_url":"https://api.github.com/repos/zamzterz/strongbox/languages","stargazers_url":"https://api.github.com/repos/zamzterz/strongbox/stargazers","contributors_url":"https://api.github.com/repos/zamzterz/strongbox/contributors","subscribers_url":"https://api.github.com/repos/zamzterz/strongbox/subscribers","subscription_url":"https://api.github.com/repos/zamzterz/strongbox/subscription","commits_url":"https://api.github.com/repos/zamzterz/strongbox/commits{/sha}","git_commits_url":"https://api.github.com/repos/zamzterz/strongbox/git/commits{/sha}","comments_url":"https://api.github.com/repos/zamzterz/strongbox/comments{/number}","issue_comment_url":"https://api.github.com/repos/zamzterz/strongbox/issues/comments{/number}","contents_url":"https://api.github.com/repos/zamzterz/strongbox/contents/{+path}","compare_url":"https://api.github.com/repos/zamzterz/strongbox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zamzterz/strongbox/merges","archive_url":"https://api.github.com/repos/zamzterz/strongbox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zamzterz/strongbox/downloads","issues_url":"https://api.github.com/repos/zamzterz/strongbox/issues{/number}","pulls_url":"https://api.github.com/repos/zamzterz/strongbox/pulls{/number}","milestones_url":"https://api.github.com/repos/zamzterz/strongbox/milestones{/number}","notifications_url":"https://api.github.com/repos/zamzterz/strongbox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zamzterz/strongbox/labels{/name}","releases_url":"https://api.github.com/repos/zamzterz/strongbox/releases{/id}","deployments_url":"https://api.github.com/repos/zamzterz/strongbox/deployments","created_at":"2017-12-01T10:53:44Z","updated_at":"2017-12-01T10:53:46Z","pushed_at":"2017-12-04T12:37:38Z","git_url":"git://github.com/zamzterz/strongbox.git","ssh_url":"git@github.com:zamzterz/strongbox.git","clone_url":"https://github.com/zamzterz/strongbox.git","svn_url":"https://github.com/zamzterz/strongbox","homepage":"https://schibsted.github.io/strongbox/","size":1330,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"schibsted:master","ref":"master","sha":"a7e489fa27789ac7b39f033768ed1ee373e98abc","user":{"login":"schibsted","id":2492354,"avatar_url":"https://avatars0.githubusercontent.com/u/2492354?v=4","gravatar_id":"","url":"https://api.github.com/users/schibsted","html_url":"https://github.com/schibsted","followers_url":"https://api.github.com/users/schibsted/followers","following_url":"https://api.github.com/users/schibsted/following{/other_user}","gists_url":"https://api.github.com/users/schibsted/gists{/gist_id}","starred_url":"https://api.github.com/users/schibsted/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schibsted/subscriptions","organizations_url":"https://api.github.com/users/schibsted/orgs","repos_url":"https://api.github.com/users/schibsted/repos","events_url":"https://api.github.com/users/schibsted/events{/privacy}","received_events_url":"https://api.github.com/users/schibsted/received_events","type":"Organization","site_admin":false},"repo":{"id":97106222,"name":"strongbox","full_name":"schibsted/strongbox","owner":{"login":"schibsted","id":2492354,"avatar_url":"https://avatars0.githubusercontent.com/u/2492354?v=4","gravatar_id":"","url":"https://api.github.com/users/schibsted","html_url":"https://github.com/schibsted","followers_url":"https://api.github.com/users/schibsted/followers","following_url":"https://api.github.com/users/schibsted/following{/other_user}","gists_url":"https://api.github.com/users/schibsted/gists{/gist_id}","starred_url":"https://api.github.com/users/schibsted/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schibsted/subscriptions","organizations_url":"https://api.github.com/users/schibsted/orgs","repos_url":"https://api.github.com/users/schibsted/repos","events_url":"https://api.github.com/users/schibsted/events{/privacy}","received_events_url":"https://api.github.com/users/schibsted/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/schibsted/strongbox","description":"A secret manager for AWS","fork":false,"url":"https://api.github.com/repos/schibsted/strongbox","forks_url":"https://api.github.com/repos/schibsted/strongbox/forks","keys_url":"https://api.github.com/repos/schibsted/strongbox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/schibsted/strongbox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/schibsted/strongbox/teams","hooks_url":"https://api.github.com/repos/schibsted/strongbox/hooks","issue_events_url":"https://api.github.com/repos/schibsted/strongbox/issues/events{/number}","events_url":"https://api.github.com/repos/schibsted/strongbox/events","assignees_url":"https://api.github.com/repos/schibsted/strongbox/assignees{/user}","branches_url":"https://api.github.com/repos/schibsted/strongbox/branches{/branch}","tags_url":"https://api.github.com/repos/schibsted/strongbox/tags","blobs_url":"https://api.github.com/repos/schibsted/strongbox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/schibsted/strongbox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/schibsted/strongbox/git/refs{/sha}","trees_url":"https://api.github.com/repos/schibsted/strongbox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/schibsted/strongbox/statuses/{sha}","languages_url":"https://api.github.com/repos/schibsted/strongbox/languages","stargazers_url":"https://api.github.com/repos/schibsted/strongbox/stargazers","contributors_url":"https://api.github.com/repos/schibsted/strongbox/contributors","subscribers_url":"https://api.github.com/repos/schibsted/strongbox/subscribers","subscription_url":"https://api.github.com/repos/schibsted/strongbox/subscription","commits_url":"https://api.github.com/repos/schibsted/strongbox/commits{/sha}","git_commits_url":"https://api.github.com/repos/schibsted/strongbox/git/commits{/sha}","comments_url":"https://api.github.com/repos/schibsted/strongbox/comments{/number}","issue_comment_url":"https://api.github.com/repos/schibsted/strongbox/issues/comments{/number}","contents_url":"https://api.github.com/repos/schibsted/strongbox/contents/{+path}","compare_url":"https://api.github.com/repos/schibsted/strongbox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/schibsted/strongbox/merges","archive_url":"https://api.github.com/repos/schibsted/strongbox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/schibsted/strongbox/downloads","issues_url":"https://api.github.com/repos/schibsted/strongbox/issues{/number}","pulls_url":"https://api.github.com/repos/schibsted/strongbox/pulls{/number}","milestones_url":"https://api.github.com/repos/schibsted/strongbox/milestones{/number}","notifications_url":"https://api.github.com/repos/schibsted/strongbox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/schibsted/strongbox/labels{/name}","releases_url":"https://api.github.com/repos/schibsted/strongbox/releases{/id}","deployments_url":"https://api.github.com/repos/schibsted/strongbox/deployments","created_at":"2017-07-13T09:39:40Z","updated_at":"2017-12-04T12:02:19Z","pushed_at":"2017-12-04T12:28:43Z","git_url":"git://github.com/schibsted/strongbox.git","ssh_url":"git@github.com:schibsted/strongbox.git","clone_url":"https://github.com/schibsted/strongbox.git","svn_url":"https://github.com/schibsted/strongbox","homepage":"https://schibsted.github.io/strongbox/","size":1328,"stargazers_count":188,"watchers_count":188,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":10,"open_issues":8,"watchers":188,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/schibsted/strongbox/pulls/46"},"html":{"href":"https://github.com/schibsted/strongbox/pull/46"},"issue":{"href":"https://api.github.com/repos/schibsted/strongbox/issues/46"},"comments":{"href":"https://api.github.com/repos/schibsted/strongbox/issues/46/comments"},"review_comments":{"href":"https://api.github.com/repos/schibsted/strongbox/pulls/46/comments"},"review_comment":{"href":"https://api.github.com/repos/schibsted/strongbox/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/schibsted/strongbox/pulls/46/commits"},"statuses":{"href":"https://api.github.com/repos/schibsted/strongbox/statuses/30dd6fb8564eeeca165860e2b2197d597f516c5f"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":85,"deletions":47,"changed_files":5}}
{"actor":{"display_login":"zamzterz"}}