{"action":"created","comment":{"url":"https://api.github.com/repos/zulip/zulip/pulls/comments/140600390","pull_request_review_id":64701630,"id":140600390,"diff_hunk":"@@ -358,5 +342,27 @@ def dump_emojis(cache_path):\n     codepoint_to_name_file.write(ujson.dumps(codepoint_to_name))\n     codepoint_to_name_file.close()\n \n+def dump_emojis(cache_path):\n+    # type: (str) -> None\n+    with open('emoji_map.json') as emoji_map_file:\n+        emoji_map = ujson.load(emoji_map_file)\n+\n+    EMOJI_DATA_FILE_PATH = os.path.join(EMOJI_DATA_PATH, 'emoji.json')\n+    with open(EMOJI_DATA_FILE_PATH) as emoji_data_file:\n+        emoji_data = ujson.load(emoji_data_file)\n+    emoji_catalog = generate_emoji_catalog(emoji_data)\n+\n+    UNIFIED_REACTIONS_PATH = os.path.join(ZULIP_PATH, 'zerver', 'management', 'data', 'unified_reactions.json')\n+    with open(UNIFIED_REACTIONS_PATH) as unified_reactions_file:\n+        unified_reactions_data = ujson.load(unified_reactions_file)\n+\n+    # Setup emoji farms.\n+    run(['rm', '-rf', cache_path])\n+    setup_emoji_farm(cache_path, emoji_map, emoji_data)\n+    setup_old_emoji_farm(cache_path, emoji_map)\n+\n+    # Generate various map files.\n+    generate_map_files(cache_path, emoji_map, emoji_data, emoji_catalog, unified_reactions_data)","path":"tools/setup/emoji/build_emoji","position":327,"original_position":53,"commit_id":"82bfdbc966e76e996217b5160fe4d23ed759349d","original_commit_id":"4f63efe0a74d07dae4574b66ebc89cdbfcea161b","user":{"login":"timabbott","id":2746074,"avatar_url":"https://avatars0.githubusercontent.com/u/2746074?v=4","gravatar_id":"","url":"https://api.github.com/users/timabbott","html_url":"https://github.com/timabbott","followers_url":"https://api.github.com/users/timabbott/followers","following_url":"https://api.github.com/users/timabbott/following{/other_user}","gists_url":"https://api.github.com/users/timabbott/gists{/gist_id}","starred_url":"https://api.github.com/users/timabbott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timabbott/subscriptions","organizations_url":"https://api.github.com/users/timabbott/orgs","repos_url":"https://api.github.com/users/timabbott/repos","events_url":"https://api.github.com/users/timabbott/events{/privacy}","received_events_url":"https://api.github.com/users/timabbott/received_events","type":"User","site_admin":false},"body":"If easy, can you move this function down in a separate commit, so that the diffs are easier to read?","created_at":"2017-09-22T21:26:58Z","updated_at":"2017-09-22T21:29:27Z","html_url":"https://github.com/zulip/zulip/pull/6603#discussion_r140600390","pull_request_url":"https://api.github.com/repos/zulip/zulip/pulls/6603","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/zulip/zulip/pulls/comments/140600390"},"html":{"href":"https://github.com/zulip/zulip/pull/6603#discussion_r140600390"},"pull_request":{"href":"https://api.github.com/repos/zulip/zulip/pulls/6603"}}},"pull_request":{"url":"https://api.github.com/repos/zulip/zulip/pulls/6603","id":142116071,"html_url":"https://github.com/zulip/zulip/pull/6603","diff_url":"https://github.com/zulip/zulip/pull/6603.diff","patch_url":"https://github.com/zulip/zulip/pull/6603.patch","issue_url":"https://api.github.com/repos/zulip/zulip/issues/6603","number":6603,"state":"open","locked":false,"title":"emoji: `build_emoji` script rewrite.","user":{"login":"HarshitOnGitHub","id":16687990,"avatar_url":"https://avatars1.githubusercontent.com/u/16687990?v=4","gravatar_id":"","url":"https://api.github.com/users/HarshitOnGitHub","html_url":"https://github.com/HarshitOnGitHub","followers_url":"https://api.github.com/users/HarshitOnGitHub/followers","following_url":"https://api.github.com/users/HarshitOnGitHub/following{/other_user}","gists_url":"https://api.github.com/users/HarshitOnGitHub/gists{/gist_id}","starred_url":"https://api.github.com/users/HarshitOnGitHub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HarshitOnGitHub/subscriptions","organizations_url":"https://api.github.com/users/HarshitOnGitHub/orgs","repos_url":"https://api.github.com/users/HarshitOnGitHub/repos","events_url":"https://api.github.com/users/HarshitOnGitHub/events{/privacy}","received_events_url":"https://api.github.com/users/HarshitOnGitHub/received_events","type":"User","site_admin":false},"body":"#This PR removes the last blocker in the way of emoji web PR. This PR adds `emoji-datasource-google` npm package as a dependency and uses the image files in it for email notifications. The `emoji-datasource-google` package contains only 64px sized images(total size of the images is 6.0 MB) and since we are planning to support four emoji sets so in total doing this would add 24.0 MB to the release tarball. I wrote a script to resize the images to 32px but still the size was not reduced much(approx 4.7 MB). So I have used the 64px images in the PR without resizing them because resizing them would add extra time to the build_emoji script without any significant reduction in the size.\r\n","created_at":"2017-09-20T14:33:20Z","updated_at":"2017-09-22T21:29:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1c067d932e59b1d414d48cfe1f65fd4a447f2092","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/zulip/zulip/pulls/6603/commits","review_comments_url":"https://api.github.com/repos/zulip/zulip/pulls/6603/comments","review_comment_url":"https://api.github.com/repos/zulip/zulip/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zulip/zulip/issues/6603/comments","statuses_url":"https://api.github.com/repos/zulip/zulip/statuses/82bfdbc966e76e996217b5160fe4d23ed759349d","head":{"label":"HarshitOnGitHub:Issue_6586","ref":"Issue_6586","sha":"82bfdbc966e76e996217b5160fe4d23ed759349d","user":{"login":"HarshitOnGitHub","id":16687990,"avatar_url":"https://avatars1.githubusercontent.com/u/16687990?v=4","gravatar_id":"","url":"https://api.github.com/users/HarshitOnGitHub","html_url":"https://github.com/HarshitOnGitHub","followers_url":"https://api.github.com/users/HarshitOnGitHub/followers","following_url":"https://api.github.com/users/HarshitOnGitHub/following{/other_user}","gists_url":"https://api.github.com/users/HarshitOnGitHub/gists{/gist_id}","starred_url":"https://api.github.com/users/HarshitOnGitHub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HarshitOnGitHub/subscriptions","organizations_url":"https://api.github.com/users/HarshitOnGitHub/orgs","repos_url":"https://api.github.com/users/HarshitOnGitHub/repos","events_url":"https://api.github.com/users/HarshitOnGitHub/events{/privacy}","received_events_url":"https://api.github.com/users/HarshitOnGitHub/received_events","type":"User","site_admin":false},"repo":{"id":76200418,"name":"zulip","full_name":"HarshitOnGitHub/zulip","owner":{"login":"HarshitOnGitHub","id":16687990,"avatar_url":"https://avatars1.githubusercontent.com/u/16687990?v=4","gravatar_id":"","url":"https://api.github.com/users/HarshitOnGitHub","html_url":"https://github.com/HarshitOnGitHub","followers_url":"https://api.github.com/users/HarshitOnGitHub/followers","following_url":"https://api.github.com/users/HarshitOnGitHub/following{/other_user}","gists_url":"https://api.github.com/users/HarshitOnGitHub/gists{/gist_id}","starred_url":"https://api.github.com/users/HarshitOnGitHub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HarshitOnGitHub/subscriptions","organizations_url":"https://api.github.com/users/HarshitOnGitHub/orgs","repos_url":"https://api.github.com/users/HarshitOnGitHub/repos","events_url":"https://api.github.com/users/HarshitOnGitHub/events{/privacy}","received_events_url":"https://api.github.com/users/HarshitOnGitHub/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/HarshitOnGitHub/zulip","description":"Zulip server - powerful open source group chat","fork":true,"url":"https://api.github.com/repos/HarshitOnGitHub/zulip","forks_url":"https://api.github.com/repos/HarshitOnGitHub/zulip/forks","keys_url":"https://api.github.com/repos/HarshitOnGitHub/zulip/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HarshitOnGitHub/zulip/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HarshitOnGitHub/zulip/teams","hooks_url":"https://api.github.com/repos/HarshitOnGitHub/zulip/hooks","issue_events_url":"https://api.github.com/repos/HarshitOnGitHub/zulip/issues/events{/number}","events_url":"https://api.github.com/repos/HarshitOnGitHub/zulip/events","assignees_url":"https://api.github.com/repos/HarshitOnGitHub/zulip/assignees{/user}","branches_url":"https://api.github.com/repos/HarshitOnGitHub/zulip/branches{/branch}","tags_url":"https://api.github.com/repos/HarshitOnGitHub/zulip/tags","blobs_url":"https://api.github.com/repos/HarshitOnGitHub/zulip/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HarshitOnGitHub/zulip/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HarshitOnGitHub/zulip/git/refs{/sha}","trees_url":"https://api.github.com/repos/HarshitOnGitHub/zulip/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HarshitOnGitHub/zulip/statuses/{sha}","languages_url":"https://api.github.com/repos/HarshitOnGitHub/zulip/languages","stargazers_url":"https://api.github.com/repos/HarshitOnGitHub/zulip/stargazers","contributors_url":"https://api.github.com/repos/HarshitOnGitHub/zulip/contributors","subscribers_url":"https://api.github.com/repos/HarshitOnGitHub/zulip/subscribers","subscription_url":"https://api.github.com/repos/HarshitOnGitHub/zulip/subscription","commits_url":"https://api.github.com/repos/HarshitOnGitHub/zulip/commits{/sha}","git_commits_url":"https://api.github.com/repos/HarshitOnGitHub/zulip/git/commits{/sha}","comments_url":"https://api.github.com/repos/HarshitOnGitHub/zulip/comments{/number}","issue_comment_url":"https://api.github.com/repos/HarshitOnGitHub/zulip/issues/comments{/number}","contents_url":"https://api.github.com/repos/HarshitOnGitHub/zulip/contents/{+path}","compare_url":"https://api.github.com/repos/HarshitOnGitHub/zulip/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HarshitOnGitHub/zulip/merges","archive_url":"https://api.github.com/repos/HarshitOnGitHub/zulip/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HarshitOnGitHub/zulip/downloads","issues_url":"https://api.github.com/repos/HarshitOnGitHub/zulip/issues{/number}","pulls_url":"https://api.github.com/repos/HarshitOnGitHub/zulip/pulls{/number}","milestones_url":"https://api.github.com/repos/HarshitOnGitHub/zulip/milestones{/number}","notifications_url":"https://api.github.com/repos/HarshitOnGitHub/zulip/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HarshitOnGitHub/zulip/labels{/name}","releases_url":"https://api.github.com/repos/HarshitOnGitHub/zulip/releases{/id}","deployments_url":"https://api.github.com/repos/HarshitOnGitHub/zulip/deployments","created_at":"2016-12-11T21:14:10Z","updated_at":"2016-12-11T21:14:18Z","pushed_at":"2017-09-22T20:16:24Z","git_url":"git://github.com/HarshitOnGitHub/zulip.git","ssh_url":"git@github.com:HarshitOnGitHub/zulip.git","clone_url":"https://github.com/HarshitOnGitHub/zulip.git","svn_url":"https://github.com/HarshitOnGitHub/zulip","homepage":"","size":178417,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zulip:master","ref":"master","sha":"3708f5708a5d84ee0c0516626f3a988dc37ffae9","user":{"login":"zulip","id":4921959,"avatar_url":"https://avatars2.githubusercontent.com/u/4921959?v=4","gravatar_id":"","url":"https://api.github.com/users/zulip","html_url":"https://github.com/zulip","followers_url":"https://api.github.com/users/zulip/followers","following_url":"https://api.github.com/users/zulip/following{/other_user}","gists_url":"https://api.github.com/users/zulip/gists{/gist_id}","starred_url":"https://api.github.com/users/zulip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zulip/subscriptions","organizations_url":"https://api.github.com/users/zulip/orgs","repos_url":"https://api.github.com/users/zulip/repos","events_url":"https://api.github.com/users/zulip/events{/privacy}","received_events_url":"https://api.github.com/users/zulip/received_events","type":"Organization","site_admin":false},"repo":{"id":43160685,"name":"zulip","full_name":"zulip/zulip","owner":{"login":"zulip","id":4921959,"avatar_url":"https://avatars2.githubusercontent.com/u/4921959?v=4","gravatar_id":"","url":"https://api.github.com/users/zulip","html_url":"https://github.com/zulip","followers_url":"https://api.github.com/users/zulip/followers","following_url":"https://api.github.com/users/zulip/following{/other_user}","gists_url":"https://api.github.com/users/zulip/gists{/gist_id}","starred_url":"https://api.github.com/users/zulip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zulip/subscriptions","organizations_url":"https://api.github.com/users/zulip/orgs","repos_url":"https://api.github.com/users/zulip/repos","events_url":"https://api.github.com/users/zulip/events{/privacy}","received_events_url":"https://api.github.com/users/zulip/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zulip/zulip","description":"Zulip server - powerful open source group chat","fork":false,"url":"https://api.github.com/repos/zulip/zulip","forks_url":"https://api.github.com/repos/zulip/zulip/forks","keys_url":"https://api.github.com/repos/zulip/zulip/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zulip/zulip/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zulip/zulip/teams","hooks_url":"https://api.github.com/repos/zulip/zulip/hooks","issue_events_url":"https://api.github.com/repos/zulip/zulip/issues/events{/number}","events_url":"https://api.github.com/repos/zulip/zulip/events","assignees_url":"https://api.github.com/repos/zulip/zulip/assignees{/user}","branches_url":"https://api.github.com/repos/zulip/zulip/branches{/branch}","tags_url":"https://api.github.com/repos/zulip/zulip/tags","blobs_url":"https://api.github.com/repos/zulip/zulip/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zulip/zulip/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zulip/zulip/git/refs{/sha}","trees_url":"https://api.github.com/repos/zulip/zulip/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zulip/zulip/statuses/{sha}","languages_url":"https://api.github.com/repos/zulip/zulip/languages","stargazers_url":"https://api.github.com/repos/zulip/zulip/stargazers","contributors_url":"https://api.github.com/repos/zulip/zulip/contributors","subscribers_url":"https://api.github.com/repos/zulip/zulip/subscribers","subscription_url":"https://api.github.com/repos/zulip/zulip/subscription","commits_url":"https://api.github.com/repos/zulip/zulip/commits{/sha}","git_commits_url":"https://api.github.com/repos/zulip/zulip/git/commits{/sha}","comments_url":"https://api.github.com/repos/zulip/zulip/comments{/number}","issue_comment_url":"https://api.github.com/repos/zulip/zulip/issues/comments{/number}","contents_url":"https://api.github.com/repos/zulip/zulip/contents/{+path}","compare_url":"https://api.github.com/repos/zulip/zulip/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zulip/zulip/merges","archive_url":"https://api.github.com/repos/zulip/zulip/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zulip/zulip/downloads","issues_url":"https://api.github.com/repos/zulip/zulip/issues{/number}","pulls_url":"https://api.github.com/repos/zulip/zulip/pulls{/number}","milestones_url":"https://api.github.com/repos/zulip/zulip/milestones{/number}","notifications_url":"https://api.github.com/repos/zulip/zulip/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zulip/zulip/labels{/name}","releases_url":"https://api.github.com/repos/zulip/zulip/releases{/id}","deployments_url":"https://api.github.com/repos/zulip/zulip/deployments","created_at":"2015-09-25T16:37:25Z","updated_at":"2017-09-22T17:50:07Z","pushed_at":"2017-09-22T21:11:10Z","git_url":"git://github.com/zulip/zulip.git","ssh_url":"git@github.com:zulip/zulip.git","clone_url":"https://github.com/zulip/zulip.git","svn_url":"https://github.com/zulip/zulip","homepage":"","size":178221,"stargazers_count":5235,"watchers_count":5235,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1551,"mirror_url":null,"open_issues_count":899,"forks":1551,"open_issues":899,"watchers":5235,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zulip/zulip/pulls/6603"},"html":{"href":"https://github.com/zulip/zulip/pull/6603"},"issue":{"href":"https://api.github.com/repos/zulip/zulip/issues/6603"},"comments":{"href":"https://api.github.com/repos/zulip/zulip/issues/6603/comments"},"review_comments":{"href":"https://api.github.com/repos/zulip/zulip/pulls/6603/comments"},"review_comment":{"href":"https://api.github.com/repos/zulip/zulip/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zulip/zulip/pulls/6603/commits"},"statuses":{"href":"https://api.github.com/repos/zulip/zulip/statuses/82bfdbc966e76e996217b5160fe4d23ed759349d"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"timabbott"}}