{"action":"created","comment":{"url":"https://api.github.com/repos/cherrypy/cherrypy/pulls/comments/144712181","pull_request_review_id":69410774,"id":144712181,"diff_hunk":"@@ -75,11 +75,17 @@ class VirtualHost(object):\n     \"\"\"\n \n     def __init__(self, default, domains=None, use_x_forwarded_host=True):\n+        \"\"\" Override the Object __init__ function to define custom attributes\n+        and parameters.\n+        \"\"\"\n         self.default = default\n         self.domains = domains or {}\n         self.use_x_forwarded_host = use_x_forwarded_host\n \n     def __call__(self, environ, start_response):\n+        \"\"\" Override the default __call__ function to define custom attributes","path":"cherrypy/_cpwsgi.py","position":12,"original_position":12,"commit_id":"8d04b8ddef116fe027c05a9c8d8e7a52e66fde88","original_commit_id":"8d04b8ddef116fe027c05a9c8d8e7a52e66fde88","user":{"login":"webknjaz","id":578543,"avatar_url":"https://avatars2.githubusercontent.com/u/578543?v=4","gravatar_id":"","url":"https://api.github.com/users/webknjaz","html_url":"https://github.com/webknjaz","followers_url":"https://api.github.com/users/webknjaz/followers","following_url":"https://api.github.com/users/webknjaz/following{/other_user}","gists_url":"https://api.github.com/users/webknjaz/gists{/gist_id}","starred_url":"https://api.github.com/users/webknjaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webknjaz/subscriptions","organizations_url":"https://api.github.com/users/webknjaz/orgs","repos_url":"https://api.github.com/users/webknjaz/repos","events_url":"https://api.github.com/users/webknjaz/events{/privacy}","received_events_url":"https://api.github.com/users/webknjaz/received_events","type":"User","site_admin":false},"body":"This is the WSGI callable. Good docstring should give a good prompt to stranger explaining the function's high-level purpose. It should say what behavior/result it would give when called. Optionally, explain the expected argument.\r\nIt must also be PEP257-complaint.","created_at":"2017-10-15T07:46:32Z","updated_at":"2017-10-15T07:51:43Z","html_url":"https://github.com/cherrypy/cherrypy/pull/1643#discussion_r144712181","pull_request_url":"https://api.github.com/repos/cherrypy/cherrypy/pulls/1643","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/cherrypy/cherrypy/pulls/comments/144712181"},"html":{"href":"https://github.com/cherrypy/cherrypy/pull/1643#discussion_r144712181"},"pull_request":{"href":"https://api.github.com/repos/cherrypy/cherrypy/pulls/1643"}}},"pull_request":{"url":"https://api.github.com/repos/cherrypy/cherrypy/pulls/1643","id":146622591,"html_url":"https://github.com/cherrypy/cherrypy/pull/1643","diff_url":"https://github.com/cherrypy/cherrypy/pull/1643.diff","patch_url":"https://github.com/cherrypy/cherrypy/pull/1643.patch","issue_url":"https://api.github.com/repos/cherrypy/cherrypy/issues/1643","number":1643,"state":"open","locked":false,"title":"Added basic comments to cherrypy._cpwsgi.VirtualHost, the majority of…","user":{"login":"babetoduarte","id":2272956,"avatar_url":"https://avatars3.githubusercontent.com/u/2272956?v=4","gravatar_id":"","url":"https://api.github.com/users/babetoduarte","html_url":"https://github.com/babetoduarte","followers_url":"https://api.github.com/users/babetoduarte/followers","following_url":"https://api.github.com/users/babetoduarte/following{/other_user}","gists_url":"https://api.github.com/users/babetoduarte/gists{/gist_id}","starred_url":"https://api.github.com/users/babetoduarte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/babetoduarte/subscriptions","organizations_url":"https://api.github.com/users/babetoduarte/orgs","repos_url":"https://api.github.com/users/babetoduarte/repos","events_url":"https://api.github.com/users/babetoduarte/events{/privacy}","received_events_url":"https://api.github.com/users/babetoduarte/received_events","type":"User","site_admin":false},"body":"… it was already documented.\r\n\r\n* **What kind of change does this PR introduce?** (Bug fix, feature, docs update, ...)\r\ndocs update\r\n\r\n\r\n* **What is the related issue number (starting with `#`)**\r\n#992\r\n\r\n\r\n* **What is the current behavior?** (You can also link to an open issue here)\r\n#992\r\n\r\n\r\n* **What is the new behavior (if this is a feature change)?**\r\n\r\n\r\n\r\n* **Other information**:","created_at":"2017-10-14T21:37:55Z","updated_at":"2017-10-15T07:51:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5116b67c5cd444a906ffd3589688db5d8bbbfad5","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/cherrypy/cherrypy/pulls/1643/commits","review_comments_url":"https://api.github.com/repos/cherrypy/cherrypy/pulls/1643/comments","review_comment_url":"https://api.github.com/repos/cherrypy/cherrypy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cherrypy/cherrypy/issues/1643/comments","statuses_url":"https://api.github.com/repos/cherrypy/cherrypy/statuses/8d04b8ddef116fe027c05a9c8d8e7a52e66fde88","head":{"label":"babetoduarte:master","ref":"master","sha":"8d04b8ddef116fe027c05a9c8d8e7a52e66fde88","user":{"login":"babetoduarte","id":2272956,"avatar_url":"https://avatars3.githubusercontent.com/u/2272956?v=4","gravatar_id":"","url":"https://api.github.com/users/babetoduarte","html_url":"https://github.com/babetoduarte","followers_url":"https://api.github.com/users/babetoduarte/followers","following_url":"https://api.github.com/users/babetoduarte/following{/other_user}","gists_url":"https://api.github.com/users/babetoduarte/gists{/gist_id}","starred_url":"https://api.github.com/users/babetoduarte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/babetoduarte/subscriptions","organizations_url":"https://api.github.com/users/babetoduarte/orgs","repos_url":"https://api.github.com/users/babetoduarte/repos","events_url":"https://api.github.com/users/babetoduarte/events{/privacy}","received_events_url":"https://api.github.com/users/babetoduarte/received_events","type":"User","site_admin":false},"repo":{"id":106964359,"name":"cherrypy","full_name":"babetoduarte/cherrypy","owner":{"login":"babetoduarte","id":2272956,"avatar_url":"https://avatars3.githubusercontent.com/u/2272956?v=4","gravatar_id":"","url":"https://api.github.com/users/babetoduarte","html_url":"https://github.com/babetoduarte","followers_url":"https://api.github.com/users/babetoduarte/followers","following_url":"https://api.github.com/users/babetoduarte/following{/other_user}","gists_url":"https://api.github.com/users/babetoduarte/gists{/gist_id}","starred_url":"https://api.github.com/users/babetoduarte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/babetoduarte/subscriptions","organizations_url":"https://api.github.com/users/babetoduarte/orgs","repos_url":"https://api.github.com/users/babetoduarte/repos","events_url":"https://api.github.com/users/babetoduarte/events{/privacy}","received_events_url":"https://api.github.com/users/babetoduarte/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/babetoduarte/cherrypy","description":"CherryPy is a pythonic, object-oriented HTTP framework.","fork":true,"url":"https://api.github.com/repos/babetoduarte/cherrypy","forks_url":"https://api.github.com/repos/babetoduarte/cherrypy/forks","keys_url":"https://api.github.com/repos/babetoduarte/cherrypy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/babetoduarte/cherrypy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/babetoduarte/cherrypy/teams","hooks_url":"https://api.github.com/repos/babetoduarte/cherrypy/hooks","issue_events_url":"https://api.github.com/repos/babetoduarte/cherrypy/issues/events{/number}","events_url":"https://api.github.com/repos/babetoduarte/cherrypy/events","assignees_url":"https://api.github.com/repos/babetoduarte/cherrypy/assignees{/user}","branches_url":"https://api.github.com/repos/babetoduarte/cherrypy/branches{/branch}","tags_url":"https://api.github.com/repos/babetoduarte/cherrypy/tags","blobs_url":"https://api.github.com/repos/babetoduarte/cherrypy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/babetoduarte/cherrypy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/babetoduarte/cherrypy/git/refs{/sha}","trees_url":"https://api.github.com/repos/babetoduarte/cherrypy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/babetoduarte/cherrypy/statuses/{sha}","languages_url":"https://api.github.com/repos/babetoduarte/cherrypy/languages","stargazers_url":"https://api.github.com/repos/babetoduarte/cherrypy/stargazers","contributors_url":"https://api.github.com/repos/babetoduarte/cherrypy/contributors","subscribers_url":"https://api.github.com/repos/babetoduarte/cherrypy/subscribers","subscription_url":"https://api.github.com/repos/babetoduarte/cherrypy/subscription","commits_url":"https://api.github.com/repos/babetoduarte/cherrypy/commits{/sha}","git_commits_url":"https://api.github.com/repos/babetoduarte/cherrypy/git/commits{/sha}","comments_url":"https://api.github.com/repos/babetoduarte/cherrypy/comments{/number}","issue_comment_url":"https://api.github.com/repos/babetoduarte/cherrypy/issues/comments{/number}","contents_url":"https://api.github.com/repos/babetoduarte/cherrypy/contents/{+path}","compare_url":"https://api.github.com/repos/babetoduarte/cherrypy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/babetoduarte/cherrypy/merges","archive_url":"https://api.github.com/repos/babetoduarte/cherrypy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/babetoduarte/cherrypy/downloads","issues_url":"https://api.github.com/repos/babetoduarte/cherrypy/issues{/number}","pulls_url":"https://api.github.com/repos/babetoduarte/cherrypy/pulls{/number}","milestones_url":"https://api.github.com/repos/babetoduarte/cherrypy/milestones{/number}","notifications_url":"https://api.github.com/repos/babetoduarte/cherrypy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/babetoduarte/cherrypy/labels{/name}","releases_url":"https://api.github.com/repos/babetoduarte/cherrypy/releases{/id}","deployments_url":"https://api.github.com/repos/babetoduarte/cherrypy/deployments","created_at":"2017-10-14T21:31:43Z","updated_at":"2017-10-14T21:31:46Z","pushed_at":"2017-10-14T21:36:42Z","git_url":"git://github.com/babetoduarte/cherrypy.git","ssh_url":"git@github.com:babetoduarte/cherrypy.git","clone_url":"https://github.com/babetoduarte/cherrypy.git","svn_url":"https://github.com/babetoduarte/cherrypy","homepage":"http://www.cherrypy.org/","size":26903,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cherrypy:master","ref":"master","sha":"8173c5f19ff7482c1da830de6d6d203be06a2ee5","user":{"login":"cherrypy","id":6617466,"avatar_url":"https://avatars3.githubusercontent.com/u/6617466?v=4","gravatar_id":"","url":"https://api.github.com/users/cherrypy","html_url":"https://github.com/cherrypy","followers_url":"https://api.github.com/users/cherrypy/followers","following_url":"https://api.github.com/users/cherrypy/following{/other_user}","gists_url":"https://api.github.com/users/cherrypy/gists{/gist_id}","starred_url":"https://api.github.com/users/cherrypy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cherrypy/subscriptions","organizations_url":"https://api.github.com/users/cherrypy/orgs","repos_url":"https://api.github.com/users/cherrypy/repos","events_url":"https://api.github.com/users/cherrypy/events{/privacy}","received_events_url":"https://api.github.com/users/cherrypy/received_events","type":"Organization","site_admin":false},"repo":{"id":57436777,"name":"cherrypy","full_name":"cherrypy/cherrypy","owner":{"login":"cherrypy","id":6617466,"avatar_url":"https://avatars3.githubusercontent.com/u/6617466?v=4","gravatar_id":"","url":"https://api.github.com/users/cherrypy","html_url":"https://github.com/cherrypy","followers_url":"https://api.github.com/users/cherrypy/followers","following_url":"https://api.github.com/users/cherrypy/following{/other_user}","gists_url":"https://api.github.com/users/cherrypy/gists{/gist_id}","starred_url":"https://api.github.com/users/cherrypy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cherrypy/subscriptions","organizations_url":"https://api.github.com/users/cherrypy/orgs","repos_url":"https://api.github.com/users/cherrypy/repos","events_url":"https://api.github.com/users/cherrypy/events{/privacy}","received_events_url":"https://api.github.com/users/cherrypy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cherrypy/cherrypy","description":"CherryPy is a pythonic, object-oriented HTTP framework.","fork":false,"url":"https://api.github.com/repos/cherrypy/cherrypy","forks_url":"https://api.github.com/repos/cherrypy/cherrypy/forks","keys_url":"https://api.github.com/repos/cherrypy/cherrypy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cherrypy/cherrypy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cherrypy/cherrypy/teams","hooks_url":"https://api.github.com/repos/cherrypy/cherrypy/hooks","issue_events_url":"https://api.github.com/repos/cherrypy/cherrypy/issues/events{/number}","events_url":"https://api.github.com/repos/cherrypy/cherrypy/events","assignees_url":"https://api.github.com/repos/cherrypy/cherrypy/assignees{/user}","branches_url":"https://api.github.com/repos/cherrypy/cherrypy/branches{/branch}","tags_url":"https://api.github.com/repos/cherrypy/cherrypy/tags","blobs_url":"https://api.github.com/repos/cherrypy/cherrypy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cherrypy/cherrypy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cherrypy/cherrypy/git/refs{/sha}","trees_url":"https://api.github.com/repos/cherrypy/cherrypy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cherrypy/cherrypy/statuses/{sha}","languages_url":"https://api.github.com/repos/cherrypy/cherrypy/languages","stargazers_url":"https://api.github.com/repos/cherrypy/cherrypy/stargazers","contributors_url":"https://api.github.com/repos/cherrypy/cherrypy/contributors","subscribers_url":"https://api.github.com/repos/cherrypy/cherrypy/subscribers","subscription_url":"https://api.github.com/repos/cherrypy/cherrypy/subscription","commits_url":"https://api.github.com/repos/cherrypy/cherrypy/commits{/sha}","git_commits_url":"https://api.github.com/repos/cherrypy/cherrypy/git/commits{/sha}","comments_url":"https://api.github.com/repos/cherrypy/cherrypy/comments{/number}","issue_comment_url":"https://api.github.com/repos/cherrypy/cherrypy/issues/comments{/number}","contents_url":"https://api.github.com/repos/cherrypy/cherrypy/contents/{+path}","compare_url":"https://api.github.com/repos/cherrypy/cherrypy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cherrypy/cherrypy/merges","archive_url":"https://api.github.com/repos/cherrypy/cherrypy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cherrypy/cherrypy/downloads","issues_url":"https://api.github.com/repos/cherrypy/cherrypy/issues{/number}","pulls_url":"https://api.github.com/repos/cherrypy/cherrypy/pulls{/number}","milestones_url":"https://api.github.com/repos/cherrypy/cherrypy/milestones{/number}","notifications_url":"https://api.github.com/repos/cherrypy/cherrypy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cherrypy/cherrypy/labels{/name}","releases_url":"https://api.github.com/repos/cherrypy/cherrypy/releases{/id}","deployments_url":"https://api.github.com/repos/cherrypy/cherrypy/deployments","created_at":"2016-04-30T10:09:26Z","updated_at":"2017-10-13T12:39:46Z","pushed_at":"2017-10-15T06:37:36Z","git_url":"git://github.com/cherrypy/cherrypy.git","ssh_url":"git@github.com:cherrypy/cherrypy.git","clone_url":"https://github.com/cherrypy/cherrypy.git","svn_url":"https://github.com/cherrypy/cherrypy","homepage":"http://www.cherrypy.org/","size":26904,"stargazers_count":505,"watchers_count":505,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":137,"mirror_url":null,"open_issues_count":184,"forks":137,"open_issues":184,"watchers":505,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cherrypy/cherrypy/pulls/1643"},"html":{"href":"https://github.com/cherrypy/cherrypy/pull/1643"},"issue":{"href":"https://api.github.com/repos/cherrypy/cherrypy/issues/1643"},"comments":{"href":"https://api.github.com/repos/cherrypy/cherrypy/issues/1643/comments"},"review_comments":{"href":"https://api.github.com/repos/cherrypy/cherrypy/pulls/1643/comments"},"review_comment":{"href":"https://api.github.com/repos/cherrypy/cherrypy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cherrypy/cherrypy/pulls/1643/commits"},"statuses":{"href":"https://api.github.com/repos/cherrypy/cherrypy/statuses/8d04b8ddef116fe027c05a9c8d8e7a52e66fde88"}},"author_association":"NONE"}}
{"actor":{"display_login":"webknjaz"}}