{"action":"created","comment":{"url":"https://api.github.com/repos/mockito/mockito/pulls/comments/114064131","pull_request_review_id":35506826,"id":114064131,"diff_hunk":"@@ -65,6 +65,6 @@ private static boolean isMatchesMethod(Method method) {\n         if (method.isBridge()) {\n             return false;\n         }\n-        return method.getName().equals(\"matches\");\n+        return \"matches\".equals(method.getName());","path":"src/main/java/org/mockito/internal/invocation/TypeSafeMatching.java","position":5,"original_position":5,"commit_id":"d6beabf08b869152e06423bd2b0ab0638fd84f2c","original_commit_id":"d6beabf08b869152e06423bd2b0ab0638fd84f2c","user":{"login":"szczepiq","id":24743,"avatar_url":"https://avatars1.githubusercontent.com/u/24743?v=3","gravatar_id":"","url":"https://api.github.com/users/szczepiq","html_url":"https://github.com/szczepiq","followers_url":"https://api.github.com/users/szczepiq/followers","following_url":"https://api.github.com/users/szczepiq/following{/other_user}","gists_url":"https://api.github.com/users/szczepiq/gists{/gist_id}","starred_url":"https://api.github.com/users/szczepiq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szczepiq/subscriptions","organizations_url":"https://api.github.com/users/szczepiq/orgs","repos_url":"https://api.github.com/users/szczepiq/repos","events_url":"https://api.github.com/users/szczepiq/events{/privacy}","received_events_url":"https://api.github.com/users/szczepiq/received_events","type":"User","site_admin":false},"body":"Interesting feedback!\r\n\r\nPersonally, flip or no-flip has no difference to me for readability. String literal on LHS is in general safer so the change is good IMHO.","created_at":"2017-04-30T00:18:33Z","updated_at":"2017-04-30T00:19:17Z","html_url":"https://github.com/mockito/mockito/pull/1027#discussion_r114064131","pull_request_url":"https://api.github.com/repos/mockito/mockito/pulls/1027","_links":{"self":{"href":"https://api.github.com/repos/mockito/mockito/pulls/comments/114064131"},"html":{"href":"https://github.com/mockito/mockito/pull/1027#discussion_r114064131"},"pull_request":{"href":"https://api.github.com/repos/mockito/mockito/pulls/1027"}}},"pull_request":{"url":"https://api.github.com/repos/mockito/mockito/pulls/1027","id":115315462,"html_url":"https://github.com/mockito/mockito/pull/1027","diff_url":"https://github.com/mockito/mockito/pull/1027.diff","patch_url":"https://github.com/mockito/mockito/pull/1027.patch","issue_url":"https://api.github.com/repos/mockito/mockito/issues/1027","number":1027,"state":"open","locked":false,"title":"Fix some issues reported by SonarQube","user":{"login":"TimvdLippe","id":5948271,"avatar_url":"https://avatars0.githubusercontent.com/u/5948271?v=3","gravatar_id":"","url":"https://api.github.com/users/TimvdLippe","html_url":"https://github.com/TimvdLippe","followers_url":"https://api.github.com/users/TimvdLippe/followers","following_url":"https://api.github.com/users/TimvdLippe/following{/other_user}","gists_url":"https://api.github.com/users/TimvdLippe/gists{/gist_id}","starred_url":"https://api.github.com/users/TimvdLippe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TimvdLippe/subscriptions","organizations_url":"https://api.github.com/users/TimvdLippe/orgs","repos_url":"https://api.github.com/users/TimvdLippe/repos","events_url":"https://api.github.com/users/TimvdLippe/events{/privacy}","received_events_url":"https://api.github.com/users/TimvdLippe/received_events","type":"User","site_admin":false},"body":"Colleague students ran SonarQube on Mockito. These were some easy fixes I was able to do, no extreme value. I will open an issue regarding a different and potentially more serious issue.","created_at":"2017-04-11T13:05:25Z","updated_at":"2017-04-30T00:19:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"73601809702de5990b3e9bb9361bbd5685fd956b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mockito/mockito/pulls/1027/commits","review_comments_url":"https://api.github.com/repos/mockito/mockito/pulls/1027/comments","review_comment_url":"https://api.github.com/repos/mockito/mockito/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mockito/mockito/issues/1027/comments","statuses_url":"https://api.github.com/repos/mockito/mockito/statuses/d6beabf08b869152e06423bd2b0ab0638fd84f2c","head":{"label":"mockito:sonar-fixes","ref":"sonar-fixes","sha":"d6beabf08b869152e06423bd2b0ab0638fd84f2c","user":{"login":"mockito","id":2054056,"avatar_url":"https://avatars3.githubusercontent.com/u/2054056?v=3","gravatar_id":"","url":"https://api.github.com/users/mockito","html_url":"https://github.com/mockito","followers_url":"https://api.github.com/users/mockito/followers","following_url":"https://api.github.com/users/mockito/following{/other_user}","gists_url":"https://api.github.com/users/mockito/gists{/gist_id}","starred_url":"https://api.github.com/users/mockito/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mockito/subscriptions","organizations_url":"https://api.github.com/users/mockito/orgs","repos_url":"https://api.github.com/users/mockito/repos","events_url":"https://api.github.com/users/mockito/events{/privacy}","received_events_url":"https://api.github.com/users/mockito/received_events","type":"Organization","site_admin":false},"repo":{"id":6207167,"name":"mockito","full_name":"mockito/mockito","owner":{"login":"mockito","id":2054056,"avatar_url":"https://avatars3.githubusercontent.com/u/2054056?v=3","gravatar_id":"","url":"https://api.github.com/users/mockito","html_url":"https://github.com/mockito","followers_url":"https://api.github.com/users/mockito/followers","following_url":"https://api.github.com/users/mockito/following{/other_user}","gists_url":"https://api.github.com/users/mockito/gists{/gist_id}","starred_url":"https://api.github.com/users/mockito/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mockito/subscriptions","organizations_url":"https://api.github.com/users/mockito/orgs","repos_url":"https://api.github.com/users/mockito/repos","events_url":"https://api.github.com/users/mockito/events{/privacy}","received_events_url":"https://api.github.com/users/mockito/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mockito/mockito","description":"Most popular Mocking framework for unit tests written in Java","fork":false,"url":"https://api.github.com/repos/mockito/mockito","forks_url":"https://api.github.com/repos/mockito/mockito/forks","keys_url":"https://api.github.com/repos/mockito/mockito/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mockito/mockito/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mockito/mockito/teams","hooks_url":"https://api.github.com/repos/mockito/mockito/hooks","issue_events_url":"https://api.github.com/repos/mockito/mockito/issues/events{/number}","events_url":"https://api.github.com/repos/mockito/mockito/events","assignees_url":"https://api.github.com/repos/mockito/mockito/assignees{/user}","branches_url":"https://api.github.com/repos/mockito/mockito/branches{/branch}","tags_url":"https://api.github.com/repos/mockito/mockito/tags","blobs_url":"https://api.github.com/repos/mockito/mockito/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mockito/mockito/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mockito/mockito/git/refs{/sha}","trees_url":"https://api.github.com/repos/mockito/mockito/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mockito/mockito/statuses/{sha}","languages_url":"https://api.github.com/repos/mockito/mockito/languages","stargazers_url":"https://api.github.com/repos/mockito/mockito/stargazers","contributors_url":"https://api.github.com/repos/mockito/mockito/contributors","subscribers_url":"https://api.github.com/repos/mockito/mockito/subscribers","subscription_url":"https://api.github.com/repos/mockito/mockito/subscription","commits_url":"https://api.github.com/repos/mockito/mockito/commits{/sha}","git_commits_url":"https://api.github.com/repos/mockito/mockito/git/commits{/sha}","comments_url":"https://api.github.com/repos/mockito/mockito/comments{/number}","issue_comment_url":"https://api.github.com/repos/mockito/mockito/issues/comments{/number}","contents_url":"https://api.github.com/repos/mockito/mockito/contents/{+path}","compare_url":"https://api.github.com/repos/mockito/mockito/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mockito/mockito/merges","archive_url":"https://api.github.com/repos/mockito/mockito/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mockito/mockito/downloads","issues_url":"https://api.github.com/repos/mockito/mockito/issues{/number}","pulls_url":"https://api.github.com/repos/mockito/mockito/pulls{/number}","milestones_url":"https://api.github.com/repos/mockito/mockito/milestones{/number}","notifications_url":"https://api.github.com/repos/mockito/mockito/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mockito/mockito/labels{/name}","releases_url":"https://api.github.com/repos/mockito/mockito/releases{/id}","deployments_url":"https://api.github.com/repos/mockito/mockito/deployments","created_at":"2012-10-13T20:27:12Z","updated_at":"2017-04-29T10:16:00Z","pushed_at":"2017-04-29T06:15:50Z","git_url":"git://github.com/mockito/mockito.git","ssh_url":"git@github.com:mockito/mockito.git","clone_url":"https://github.com/mockito/mockito.git","svn_url":"https://github.com/mockito/mockito","homepage":"http://mockito.org","size":43192,"stargazers_count":4524,"watchers_count":4524,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":865,"mirror_url":null,"open_issues_count":132,"forks":865,"open_issues":132,"watchers":4524,"default_branch":"release/2.x"}},"base":{"label":"mockito:release/2.x","ref":"release/2.x","sha":"6438ed18e7a618060414b3a31e6fc73c8d374088","user":{"login":"mockito","id":2054056,"avatar_url":"https://avatars3.githubusercontent.com/u/2054056?v=3","gravatar_id":"","url":"https://api.github.com/users/mockito","html_url":"https://github.com/mockito","followers_url":"https://api.github.com/users/mockito/followers","following_url":"https://api.github.com/users/mockito/following{/other_user}","gists_url":"https://api.github.com/users/mockito/gists{/gist_id}","starred_url":"https://api.github.com/users/mockito/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mockito/subscriptions","organizations_url":"https://api.github.com/users/mockito/orgs","repos_url":"https://api.github.com/users/mockito/repos","events_url":"https://api.github.com/users/mockito/events{/privacy}","received_events_url":"https://api.github.com/users/mockito/received_events","type":"Organization","site_admin":false},"repo":{"id":6207167,"name":"mockito","full_name":"mockito/mockito","owner":{"login":"mockito","id":2054056,"avatar_url":"https://avatars3.githubusercontent.com/u/2054056?v=3","gravatar_id":"","url":"https://api.github.com/users/mockito","html_url":"https://github.com/mockito","followers_url":"https://api.github.com/users/mockito/followers","following_url":"https://api.github.com/users/mockito/following{/other_user}","gists_url":"https://api.github.com/users/mockito/gists{/gist_id}","starred_url":"https://api.github.com/users/mockito/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mockito/subscriptions","organizations_url":"https://api.github.com/users/mockito/orgs","repos_url":"https://api.github.com/users/mockito/repos","events_url":"https://api.github.com/users/mockito/events{/privacy}","received_events_url":"https://api.github.com/users/mockito/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mockito/mockito","description":"Most popular Mocking framework for unit tests written in Java","fork":false,"url":"https://api.github.com/repos/mockito/mockito","forks_url":"https://api.github.com/repos/mockito/mockito/forks","keys_url":"https://api.github.com/repos/mockito/mockito/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mockito/mockito/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mockito/mockito/teams","hooks_url":"https://api.github.com/repos/mockito/mockito/hooks","issue_events_url":"https://api.github.com/repos/mockito/mockito/issues/events{/number}","events_url":"https://api.github.com/repos/mockito/mockito/events","assignees_url":"https://api.github.com/repos/mockito/mockito/assignees{/user}","branches_url":"https://api.github.com/repos/mockito/mockito/branches{/branch}","tags_url":"https://api.github.com/repos/mockito/mockito/tags","blobs_url":"https://api.github.com/repos/mockito/mockito/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mockito/mockito/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mockito/mockito/git/refs{/sha}","trees_url":"https://api.github.com/repos/mockito/mockito/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mockito/mockito/statuses/{sha}","languages_url":"https://api.github.com/repos/mockito/mockito/languages","stargazers_url":"https://api.github.com/repos/mockito/mockito/stargazers","contributors_url":"https://api.github.com/repos/mockito/mockito/contributors","subscribers_url":"https://api.github.com/repos/mockito/mockito/subscribers","subscription_url":"https://api.github.com/repos/mockito/mockito/subscription","commits_url":"https://api.github.com/repos/mockito/mockito/commits{/sha}","git_commits_url":"https://api.github.com/repos/mockito/mockito/git/commits{/sha}","comments_url":"https://api.github.com/repos/mockito/mockito/comments{/number}","issue_comment_url":"https://api.github.com/repos/mockito/mockito/issues/comments{/number}","contents_url":"https://api.github.com/repos/mockito/mockito/contents/{+path}","compare_url":"https://api.github.com/repos/mockito/mockito/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mockito/mockito/merges","archive_url":"https://api.github.com/repos/mockito/mockito/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mockito/mockito/downloads","issues_url":"https://api.github.com/repos/mockito/mockito/issues{/number}","pulls_url":"https://api.github.com/repos/mockito/mockito/pulls{/number}","milestones_url":"https://api.github.com/repos/mockito/mockito/milestones{/number}","notifications_url":"https://api.github.com/repos/mockito/mockito/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mockito/mockito/labels{/name}","releases_url":"https://api.github.com/repos/mockito/mockito/releases{/id}","deployments_url":"https://api.github.com/repos/mockito/mockito/deployments","created_at":"2012-10-13T20:27:12Z","updated_at":"2017-04-29T10:16:00Z","pushed_at":"2017-04-29T06:15:50Z","git_url":"git://github.com/mockito/mockito.git","ssh_url":"git@github.com:mockito/mockito.git","clone_url":"https://github.com/mockito/mockito.git","svn_url":"https://github.com/mockito/mockito","homepage":"http://mockito.org","size":43192,"stargazers_count":4524,"watchers_count":4524,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":865,"mirror_url":null,"open_issues_count":132,"forks":865,"open_issues":132,"watchers":4524,"default_branch":"release/2.x"}},"_links":{"self":{"href":"https://api.github.com/repos/mockito/mockito/pulls/1027"},"html":{"href":"https://github.com/mockito/mockito/pull/1027"},"issue":{"href":"https://api.github.com/repos/mockito/mockito/issues/1027"},"comments":{"href":"https://api.github.com/repos/mockito/mockito/issues/1027/comments"},"review_comments":{"href":"https://api.github.com/repos/mockito/mockito/pulls/1027/comments"},"review_comment":{"href":"https://api.github.com/repos/mockito/mockito/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mockito/mockito/pulls/1027/commits"},"statuses":{"href":"https://api.github.com/repos/mockito/mockito/statuses/d6beabf08b869152e06423bd2b0ab0638fd84f2c"}}}}
{"actor":{"display_login":"szczepiq"}}