{"action":"created","comment":{"url":"https://api.github.com/repos/kripken/emscripten/pulls/comments/103052517","pull_request_review_id":23832616,"id":103052517,"diff_hunk":"@@ -7769,6 +7769,8 @@ function eliminateDeadGlobals(ast) {\n // it goes away.\n function JSDCE(ast) {\n   var scopes = [{}]; // begin with empty toplevel scope\n+  var isVarNameOrObjectKey;","path":"tools/js-optimizer.js","position":4,"original_position":4,"commit_id":"0950739f568be3823cd3267df0bf439f87b557c0","original_commit_id":"0950739f568be3823cd3267df0bf439f87b557c0","user":{"login":"kripken","id":173661,"avatar_url":"https://avatars.githubusercontent.com/u/173661?v=3","gravatar_id":"","url":"https://api.github.com/users/kripken","html_url":"https://github.com/kripken","followers_url":"https://api.github.com/users/kripken/followers","following_url":"https://api.github.com/users/kripken/following{/other_user}","gists_url":"https://api.github.com/users/kripken/gists{/gist_id}","starred_url":"https://api.github.com/users/kripken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kripken/subscriptions","organizations_url":"https://api.github.com/users/kripken/orgs","repos_url":"https://api.github.com/users/kripken/repos","events_url":"https://api.github.com/users/kripken/events{/privacy}","received_events_url":"https://api.github.com/users/kripken/received_events","type":"User","site_admin":false},"body":"Actually, the first could be moved into the functions, no need to declare it this high?  the second needs to stay here, and could benefit from a comment","created_at":"2017-02-24T23:08:59Z","updated_at":"2017-02-24T23:09:00Z","html_url":"https://github.com/kripken/emscripten/pull/4695#discussion_r103052517","pull_request_url":"https://api.github.com/repos/kripken/emscripten/pulls/4695","_links":{"self":{"href":"https://api.github.com/repos/kripken/emscripten/pulls/comments/103052517"},"html":{"href":"https://github.com/kripken/emscripten/pull/4695#discussion_r103052517"},"pull_request":{"href":"https://api.github.com/repos/kripken/emscripten/pulls/4695"}}},"pull_request":{"url":"https://api.github.com/repos/kripken/emscripten/pulls/4695","id":92442110,"html_url":"https://github.com/kripken/emscripten/pull/4695","diff_url":"https://github.com/kripken/emscripten/pull/4695.diff","patch_url":"https://github.com/kripken/emscripten/pull/4695.patch","issue_url":"https://api.github.com/repos/kripken/emscripten/issues/4695","number":4695,"state":"open","locked":false,"title":"Fix handling node types on JSDCE() in js-optimizer.js","user":{"login":"gunyarakun","id":45072,"avatar_url":"https://avatars.githubusercontent.com/u/45072?v=3","gravatar_id":"","url":"https://api.github.com/users/gunyarakun","html_url":"https://github.com/gunyarakun","followers_url":"https://api.github.com/users/gunyarakun/followers","following_url":"https://api.github.com/users/gunyarakun/following{/other_user}","gists_url":"https://api.github.com/users/gunyarakun/gists{/gist_id}","starred_url":"https://api.github.com/users/gunyarakun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gunyarakun/subscriptions","organizations_url":"https://api.github.com/users/gunyarakun/orgs","repos_url":"https://api.github.com/users/gunyarakun/repos","events_url":"https://api.github.com/users/gunyarakun/events{/privacy}","received_events_url":"https://api.github.com/users/gunyarakun/received_events","type":"User","site_admin":false},"body":"This pull request fixes the problem reported in #4694, \"Build fails on JSDCE() in js-optimizer.js with some special object keys.\"","created_at":"2016-11-05T04:34:34Z","updated_at":"2017-02-24T23:09:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"97cf871ce1aa9838532b836b5eace35991557103","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/kripken/emscripten/pulls/4695/commits","review_comments_url":"https://api.github.com/repos/kripken/emscripten/pulls/4695/comments","review_comment_url":"https://api.github.com/repos/kripken/emscripten/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kripken/emscripten/issues/4695/comments","statuses_url":"https://api.github.com/repos/kripken/emscripten/statuses/0950739f568be3823cd3267df0bf439f87b557c0","head":{"label":"gunyarakun:incoming","ref":"incoming","sha":"0950739f568be3823cd3267df0bf439f87b557c0","user":{"login":"gunyarakun","id":45072,"avatar_url":"https://avatars.githubusercontent.com/u/45072?v=3","gravatar_id":"","url":"https://api.github.com/users/gunyarakun","html_url":"https://github.com/gunyarakun","followers_url":"https://api.github.com/users/gunyarakun/followers","following_url":"https://api.github.com/users/gunyarakun/following{/other_user}","gists_url":"https://api.github.com/users/gunyarakun/gists{/gist_id}","starred_url":"https://api.github.com/users/gunyarakun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gunyarakun/subscriptions","organizations_url":"https://api.github.com/users/gunyarakun/orgs","repos_url":"https://api.github.com/users/gunyarakun/repos","events_url":"https://api.github.com/users/gunyarakun/events{/privacy}","received_events_url":"https://api.github.com/users/gunyarakun/received_events","type":"User","site_admin":false},"repo":{"id":72902910,"name":"emscripten","full_name":"gunyarakun/emscripten","owner":{"login":"gunyarakun","id":45072,"avatar_url":"https://avatars.githubusercontent.com/u/45072?v=3","gravatar_id":"","url":"https://api.github.com/users/gunyarakun","html_url":"https://github.com/gunyarakun","followers_url":"https://api.github.com/users/gunyarakun/followers","following_url":"https://api.github.com/users/gunyarakun/following{/other_user}","gists_url":"https://api.github.com/users/gunyarakun/gists{/gist_id}","starred_url":"https://api.github.com/users/gunyarakun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gunyarakun/subscriptions","organizations_url":"https://api.github.com/users/gunyarakun/orgs","repos_url":"https://api.github.com/users/gunyarakun/repos","events_url":"https://api.github.com/users/gunyarakun/events{/privacy}","received_events_url":"https://api.github.com/users/gunyarakun/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gunyarakun/emscripten","description":"Emscripten: An LLVM-to-JavaScript Compiler","fork":true,"url":"https://api.github.com/repos/gunyarakun/emscripten","forks_url":"https://api.github.com/repos/gunyarakun/emscripten/forks","keys_url":"https://api.github.com/repos/gunyarakun/emscripten/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gunyarakun/emscripten/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gunyarakun/emscripten/teams","hooks_url":"https://api.github.com/repos/gunyarakun/emscripten/hooks","issue_events_url":"https://api.github.com/repos/gunyarakun/emscripten/issues/events{/number}","events_url":"https://api.github.com/repos/gunyarakun/emscripten/events","assignees_url":"https://api.github.com/repos/gunyarakun/emscripten/assignees{/user}","branches_url":"https://api.github.com/repos/gunyarakun/emscripten/branches{/branch}","tags_url":"https://api.github.com/repos/gunyarakun/emscripten/tags","blobs_url":"https://api.github.com/repos/gunyarakun/emscripten/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gunyarakun/emscripten/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gunyarakun/emscripten/git/refs{/sha}","trees_url":"https://api.github.com/repos/gunyarakun/emscripten/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gunyarakun/emscripten/statuses/{sha}","languages_url":"https://api.github.com/repos/gunyarakun/emscripten/languages","stargazers_url":"https://api.github.com/repos/gunyarakun/emscripten/stargazers","contributors_url":"https://api.github.com/repos/gunyarakun/emscripten/contributors","subscribers_url":"https://api.github.com/repos/gunyarakun/emscripten/subscribers","subscription_url":"https://api.github.com/repos/gunyarakun/emscripten/subscription","commits_url":"https://api.github.com/repos/gunyarakun/emscripten/commits{/sha}","git_commits_url":"https://api.github.com/repos/gunyarakun/emscripten/git/commits{/sha}","comments_url":"https://api.github.com/repos/gunyarakun/emscripten/comments{/number}","issue_comment_url":"https://api.github.com/repos/gunyarakun/emscripten/issues/comments{/number}","contents_url":"https://api.github.com/repos/gunyarakun/emscripten/contents/{+path}","compare_url":"https://api.github.com/repos/gunyarakun/emscripten/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gunyarakun/emscripten/merges","archive_url":"https://api.github.com/repos/gunyarakun/emscripten/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gunyarakun/emscripten/downloads","issues_url":"https://api.github.com/repos/gunyarakun/emscripten/issues{/number}","pulls_url":"https://api.github.com/repos/gunyarakun/emscripten/pulls{/number}","milestones_url":"https://api.github.com/repos/gunyarakun/emscripten/milestones{/number}","notifications_url":"https://api.github.com/repos/gunyarakun/emscripten/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gunyarakun/emscripten/labels{/name}","releases_url":"https://api.github.com/repos/gunyarakun/emscripten/releases{/id}","deployments_url":"https://api.github.com/repos/gunyarakun/emscripten/deployments","created_at":"2016-11-05T03:32:08Z","updated_at":"2016-11-05T03:32:29Z","pushed_at":"2017-02-24T06:55:52Z","git_url":"git://github.com/gunyarakun/emscripten.git","ssh_url":"git@github.com:gunyarakun/emscripten.git","clone_url":"https://github.com/gunyarakun/emscripten.git","svn_url":"https://github.com/gunyarakun/emscripten","homepage":"","size":140076,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kripken:incoming","ref":"incoming","sha":"c4c9d4b68ce8ada83c8caafe2a39ba352409ed98","user":{"login":"kripken","id":173661,"avatar_url":"https://avatars.githubusercontent.com/u/173661?v=3","gravatar_id":"","url":"https://api.github.com/users/kripken","html_url":"https://github.com/kripken","followers_url":"https://api.github.com/users/kripken/followers","following_url":"https://api.github.com/users/kripken/following{/other_user}","gists_url":"https://api.github.com/users/kripken/gists{/gist_id}","starred_url":"https://api.github.com/users/kripken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kripken/subscriptions","organizations_url":"https://api.github.com/users/kripken/orgs","repos_url":"https://api.github.com/users/kripken/repos","events_url":"https://api.github.com/users/kripken/events{/privacy}","received_events_url":"https://api.github.com/users/kripken/received_events","type":"User","site_admin":false},"repo":{"id":1357796,"name":"emscripten","full_name":"kripken/emscripten","owner":{"login":"kripken","id":173661,"avatar_url":"https://avatars.githubusercontent.com/u/173661?v=3","gravatar_id":"","url":"https://api.github.com/users/kripken","html_url":"https://github.com/kripken","followers_url":"https://api.github.com/users/kripken/followers","following_url":"https://api.github.com/users/kripken/following{/other_user}","gists_url":"https://api.github.com/users/kripken/gists{/gist_id}","starred_url":"https://api.github.com/users/kripken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kripken/subscriptions","organizations_url":"https://api.github.com/users/kripken/orgs","repos_url":"https://api.github.com/users/kripken/repos","events_url":"https://api.github.com/users/kripken/events{/privacy}","received_events_url":"https://api.github.com/users/kripken/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kripken/emscripten","description":"Emscripten: An LLVM-to-JavaScript Compiler","fork":false,"url":"https://api.github.com/repos/kripken/emscripten","forks_url":"https://api.github.com/repos/kripken/emscripten/forks","keys_url":"https://api.github.com/repos/kripken/emscripten/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kripken/emscripten/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kripken/emscripten/teams","hooks_url":"https://api.github.com/repos/kripken/emscripten/hooks","issue_events_url":"https://api.github.com/repos/kripken/emscripten/issues/events{/number}","events_url":"https://api.github.com/repos/kripken/emscripten/events","assignees_url":"https://api.github.com/repos/kripken/emscripten/assignees{/user}","branches_url":"https://api.github.com/repos/kripken/emscripten/branches{/branch}","tags_url":"https://api.github.com/repos/kripken/emscripten/tags","blobs_url":"https://api.github.com/repos/kripken/emscripten/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kripken/emscripten/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kripken/emscripten/git/refs{/sha}","trees_url":"https://api.github.com/repos/kripken/emscripten/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kripken/emscripten/statuses/{sha}","languages_url":"https://api.github.com/repos/kripken/emscripten/languages","stargazers_url":"https://api.github.com/repos/kripken/emscripten/stargazers","contributors_url":"https://api.github.com/repos/kripken/emscripten/contributors","subscribers_url":"https://api.github.com/repos/kripken/emscripten/subscribers","subscription_url":"https://api.github.com/repos/kripken/emscripten/subscription","commits_url":"https://api.github.com/repos/kripken/emscripten/commits{/sha}","git_commits_url":"https://api.github.com/repos/kripken/emscripten/git/commits{/sha}","comments_url":"https://api.github.com/repos/kripken/emscripten/comments{/number}","issue_comment_url":"https://api.github.com/repos/kripken/emscripten/issues/comments{/number}","contents_url":"https://api.github.com/repos/kripken/emscripten/contents/{+path}","compare_url":"https://api.github.com/repos/kripken/emscripten/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kripken/emscripten/merges","archive_url":"https://api.github.com/repos/kripken/emscripten/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kripken/emscripten/downloads","issues_url":"https://api.github.com/repos/kripken/emscripten/issues{/number}","pulls_url":"https://api.github.com/repos/kripken/emscripten/pulls{/number}","milestones_url":"https://api.github.com/repos/kripken/emscripten/milestones{/number}","notifications_url":"https://api.github.com/repos/kripken/emscripten/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kripken/emscripten/labels{/name}","releases_url":"https://api.github.com/repos/kripken/emscripten/releases{/id}","deployments_url":"https://api.github.com/repos/kripken/emscripten/deployments","created_at":"2011-02-12T05:23:30Z","updated_at":"2017-02-24T19:40:35Z","pushed_at":"2017-02-24T21:14:54Z","git_url":"git://github.com/kripken/emscripten.git","ssh_url":"git@github.com:kripken/emscripten.git","clone_url":"https://github.com/kripken/emscripten.git","svn_url":"https://github.com/kripken/emscripten","homepage":"","size":140419,"stargazers_count":11594,"watchers_count":11594,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1412,"mirror_url":null,"open_issues_count":970,"forks":1412,"open_issues":970,"watchers":11594,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kripken/emscripten/pulls/4695"},"html":{"href":"https://github.com/kripken/emscripten/pull/4695"},"issue":{"href":"https://api.github.com/repos/kripken/emscripten/issues/4695"},"comments":{"href":"https://api.github.com/repos/kripken/emscripten/issues/4695/comments"},"review_comments":{"href":"https://api.github.com/repos/kripken/emscripten/pulls/4695/comments"},"review_comment":{"href":"https://api.github.com/repos/kripken/emscripten/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kripken/emscripten/pulls/4695/commits"},"statuses":{"href":"https://api.github.com/repos/kripken/emscripten/statuses/0950739f568be3823cd3267df0bf439f87b557c0"}}}}
{"actor":{"display_login":"kripken"}}