{"action":"created","issue":{"url":"https://api.github.com/repos/jordwalke/esy/issues/48","repository_url":"https://api.github.com/repos/jordwalke/esy","labels_url":"https://api.github.com/repos/jordwalke/esy/issues/48/labels{/name}","comments_url":"https://api.github.com/repos/jordwalke/esy/issues/48/comments","events_url":"https://api.github.com/repos/jordwalke/esy/issues/48/events","html_url":"https://github.com/jordwalke/esy/issues/48","id":203780405,"number":48,"title":"When \"make\"ing submodules, errors occur.","user":{"login":"jordwalke","id":977348,"avatar_url":"https://avatars.githubusercontent.com/u/977348?v=3","gravatar_id":"","url":"https://api.github.com/users/jordwalke","html_url":"https://github.com/jordwalke","followers_url":"https://api.github.com/users/jordwalke/followers","following_url":"https://api.github.com/users/jordwalke/following{/other_user}","gists_url":"https://api.github.com/users/jordwalke/gists{/gist_id}","starred_url":"https://api.github.com/users/jordwalke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jordwalke/subscriptions","organizations_url":"https://api.github.com/users/jordwalke/orgs","repos_url":"https://api.github.com/users/jordwalke/repos","events_url":"https://api.github.com/users/jordwalke/events{/privacy}","received_events_url":"https://api.github.com/users/jordwalke/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2017-01-28T01:59:49Z","updated_at":"2017-02-02T11:53:38Z","closed_at":"2017-02-02T11:53:38Z","body":"1. We need to update the docs to have people do `git clone --recursive` if cloning esy (I think).\r\n2. Update the docs to indicate that people need to `cd esy/opam-packages-conversion/`.\r\n3. I'm seeing a bunch of errors when running `make`\r\n\r\nHere's some examples:\r\n```\r\nTraceback (most recent call last):\r\n  File \"./bin/build-package\", line 79, in <module>\r\n    build_package(name, *versions)\r\n  File \"./bin/build-package\", line 62, in build_package\r\n    os.path.join(package_dir, name + '.' + version)\r\n  File \"/Users/me/github/esy/opam-packages-conversion/bin/lib.py\", line 20, in generate_package_json\r\n    package_url = re.search(r\"(archive:\\s*|http:\\s*|src:\\s*)\\\"(.*)\\\"\", content).group(2)\r\nAttributeError: 'NoneType' object has no attribute 'group'\r\n*** building ppx_type_conv\r\n```\r\n\r\nAnd:\r\n\r\n```\r\nTraceback (most recent call last):\r\n  File \"./bin/build-package\", line 79, in <module>\r\n    build_package(name, *versions)\r\n  File \"./bin/build-package\", line 62, in build_package\r\n    os.path.join(package_dir, name + '.' + version)\r\n  File \"/Users/me/github/esy/opam-packages-conversion/bin/lib.py\", line 243, in generate_package_json\r\n    buildFlatList(d[\"substs\"]), breakList(d[\"build\"]) + breakList(d[\"install\"]))\r\n  File \"/Users/me/github/esy/opam-packages-conversion/bin/lib.py\", line 191, in createPostInstallCommand\r\n    return [unescapeBuiltinVariables(cmd) for cmd in build]\r\n  File \"/Users/me/github/esy/opam-packages-conversion/bin/lib.py\", line 158, in unescapeBuiltinVariables\r\n    return re.sub(r\"%\\{(.*?)\\}%\", escape, s)\r\n  File \"/usr/local/Cellar/python/2.7.10_2/Frameworks/Python.framework/Versions/2.7/lib/python2.7/re.py\", line 155, in sub\r\n    return _compile(pattern, flags).sub(repl, string, count)\r\n  File \"/Users/me/github/esy/opam-packages-conversion/bin/lib.py\", line 157, in escape\r\n    raise Exception(\"Cannot expand variable %s\" % var)\r\nException: Cannot expand variable share\r\n```"},"comment":{"url":"https://api.github.com/repos/jordwalke/esy/issues/comments/276937977","html_url":"https://github.com/jordwalke/esy/issues/48#issuecomment-276937977","issue_url":"https://api.github.com/repos/jordwalke/esy/issues/48","id":276937977,"user":{"login":"jordwalke","id":977348,"avatar_url":"https://avatars.githubusercontent.com/u/977348?v=3","gravatar_id":"","url":"https://api.github.com/users/jordwalke","html_url":"https://github.com/jordwalke","followers_url":"https://api.github.com/users/jordwalke/followers","following_url":"https://api.github.com/users/jordwalke/following{/other_user}","gists_url":"https://api.github.com/users/jordwalke/gists{/gist_id}","starred_url":"https://api.github.com/users/jordwalke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jordwalke/subscriptions","organizations_url":"https://api.github.com/users/jordwalke/orgs","repos_url":"https://api.github.com/users/jordwalke/repos","events_url":"https://api.github.com/users/jordwalke/events{/privacy}","received_events_url":"https://api.github.com/users/jordwalke/received_events","type":"User","site_admin":false},"created_at":"2017-02-02T11:53:38Z","updated_at":"2017-02-02T11:53:38Z","body":"Seems to no longer be an issue."}}
{"actor":{"display_login":"jordwalke"}}