{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/acs-engine/pulls/comments/143884469","pull_request_review_id":68461963,"id":143884469,"diff_hunk":"@@ -100,16 +100,21 @@ const (\n //  - OS type of the VMs in the pool\n //  - list of applicable upgrades\n type PoolUpgradeProfile struct {\n-\tKubernetesVersion string    `json:\"kubernetesVersion\"`\n-\tName              string    `json:\"name,omitempty\"`\n-\tOSType            string    `json:\"osType,omitempty\"`\n-\tUpgrades          []*string `json:\"upgrades,omitempty\"`\n+\tKubernetesVersion string   `json:\"kubernetesVersion\"`\n+\tName              string   `json:\"name,omitempty\"`\n+\tOSType            string   `json:\"osType,omitempty\"`\n+\tUpgrades          []string `json:\"upgrades,omitempty\"`\n }\n \n // UpgradeProfile contains controlPlane and agent pools upgrade profiles\n type UpgradeProfile struct {\n-\tControlPlaneProfile *PoolUpgradeProfile   `json:\"controlPlaneProfile\"`\n-\tAgentPoolProfiles   []*PoolUpgradeProfile `json:\"agentPoolProfiles\"`\n+\tID         string `json:\"id,omitempty\"`\n+\tName       string `json:\"name,omitempty\"`\n+\tType       string `json:\"type,omitempty\"`\n+\tProperties struct {","path":"pkg/api/agentPoolOnlyApi/v20170831/types.go","position":21,"original_position":21,"commit_id":"b866f6f01c7a83a0a12438db101542aaaa8d4d33","original_commit_id":"b866f6f01c7a83a0a12438db101542aaaa8d4d33","user":{"login":"weinong","id":4204090,"avatar_url":"https://avatars2.githubusercontent.com/u/4204090?v=4","gravatar_id":"","url":"https://api.github.com/users/weinong","html_url":"https://github.com/weinong","followers_url":"https://api.github.com/users/weinong/followers","following_url":"https://api.github.com/users/weinong/following{/other_user}","gists_url":"https://api.github.com/users/weinong/gists{/gist_id}","starred_url":"https://api.github.com/users/weinong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weinong/subscriptions","organizations_url":"https://api.github.com/users/weinong/orgs","repos_url":"https://api.github.com/users/weinong/repos","events_url":"https://api.github.com/users/weinong/events{/privacy}","received_events_url":"https://api.github.com/users/weinong/received_events","type":"User","site_admin":false},"body":"can we create a struct for this? it will make writing tests easier.","created_at":"2017-10-11T00:06:39Z","updated_at":"2017-10-11T00:06:39Z","html_url":"https://github.com/Azure/acs-engine/pull/1578#discussion_r143884469","pull_request_url":"https://api.github.com/repos/Azure/acs-engine/pulls/1578","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Azure/acs-engine/pulls/comments/143884469"},"html":{"href":"https://github.com/Azure/acs-engine/pull/1578#discussion_r143884469"},"pull_request":{"href":"https://api.github.com/repos/Azure/acs-engine/pulls/1578"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/acs-engine/pulls/1578","id":145828957,"html_url":"https://github.com/Azure/acs-engine/pull/1578","diff_url":"https://github.com/Azure/acs-engine/pull/1578.diff","patch_url":"https://github.com/Azure/acs-engine/pull/1578.patch","issue_url":"https://api.github.com/repos/Azure/acs-engine/issues/1578","number":1578,"state":"open","locked":false,"title":"updated upgrade API","user":{"login":"dmitsh","id":17212177,"avatar_url":"https://avatars3.githubusercontent.com/u/17212177?v=4","gravatar_id":"","url":"https://api.github.com/users/dmitsh","html_url":"https://github.com/dmitsh","followers_url":"https://api.github.com/users/dmitsh/followers","following_url":"https://api.github.com/users/dmitsh/following{/other_user}","gists_url":"https://api.github.com/users/dmitsh/gists{/gist_id}","starred_url":"https://api.github.com/users/dmitsh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmitsh/subscriptions","organizations_url":"https://api.github.com/users/dmitsh/orgs","repos_url":"https://api.github.com/users/dmitsh/repos","events_url":"https://api.github.com/users/dmitsh/events{/privacy}","received_events_url":"https://api.github.com/users/dmitsh/received_events","type":"User","site_admin":false},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If you want *faster* PR reviews, read how: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#best-practices-for-faster-reviews\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\n\r\n**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #\r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Release note**:\r\n<!--  Steps to write your release note:\r\n1. Use the release-note-* labels to set the release note state (if you have access)\r\n2. Enter your extended release note in the below block; leaving it blank means using the PR title as the release note. If no release note is required, just write `NONE`.\r\n-->\r\n```release-note\r\n```\r\n","created_at":"2017-10-11T00:01:45Z","updated_at":"2017-10-11T00:06:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b2aea02550e47498b82ae8666bf0734f1c439f5e","assignee":{"login":"dmitsh","id":17212177,"avatar_url":"https://avatars3.githubusercontent.com/u/17212177?v=4","gravatar_id":"","url":"https://api.github.com/users/dmitsh","html_url":"https://github.com/dmitsh","followers_url":"https://api.github.com/users/dmitsh/followers","following_url":"https://api.github.com/users/dmitsh/following{/other_user}","gists_url":"https://api.github.com/users/dmitsh/gists{/gist_id}","starred_url":"https://api.github.com/users/dmitsh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmitsh/subscriptions","organizations_url":"https://api.github.com/users/dmitsh/orgs","repos_url":"https://api.github.com/users/dmitsh/repos","events_url":"https://api.github.com/users/dmitsh/events{/privacy}","received_events_url":"https://api.github.com/users/dmitsh/received_events","type":"User","site_admin":false},"assignees":[{"login":"dmitsh","id":17212177,"avatar_url":"https://avatars3.githubusercontent.com/u/17212177?v=4","gravatar_id":"","url":"https://api.github.com/users/dmitsh","html_url":"https://github.com/dmitsh","followers_url":"https://api.github.com/users/dmitsh/followers","following_url":"https://api.github.com/users/dmitsh/following{/other_user}","gists_url":"https://api.github.com/users/dmitsh/gists{/gist_id}","starred_url":"https://api.github.com/users/dmitsh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmitsh/subscriptions","organizations_url":"https://api.github.com/users/dmitsh/orgs","repos_url":"https://api.github.com/users/dmitsh/repos","events_url":"https://api.github.com/users/dmitsh/events{/privacy}","received_events_url":"https://api.github.com/users/dmitsh/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/acs-engine/pulls/1578/commits","review_comments_url":"https://api.github.com/repos/Azure/acs-engine/pulls/1578/comments","review_comment_url":"https://api.github.com/repos/Azure/acs-engine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/acs-engine/issues/1578/comments","statuses_url":"https://api.github.com/repos/Azure/acs-engine/statuses/b866f6f01c7a83a0a12438db101542aaaa8d4d33","head":{"label":"dmitsh:ds-up-api","ref":"ds-up-api","sha":"b866f6f01c7a83a0a12438db101542aaaa8d4d33","user":{"login":"dmitsh","id":17212177,"avatar_url":"https://avatars3.githubusercontent.com/u/17212177?v=4","gravatar_id":"","url":"https://api.github.com/users/dmitsh","html_url":"https://github.com/dmitsh","followers_url":"https://api.github.com/users/dmitsh/followers","following_url":"https://api.github.com/users/dmitsh/following{/other_user}","gists_url":"https://api.github.com/users/dmitsh/gists{/gist_id}","starred_url":"https://api.github.com/users/dmitsh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmitsh/subscriptions","organizations_url":"https://api.github.com/users/dmitsh/orgs","repos_url":"https://api.github.com/users/dmitsh/repos","events_url":"https://api.github.com/users/dmitsh/events{/privacy}","received_events_url":"https://api.github.com/users/dmitsh/received_events","type":"User","site_admin":false},"repo":{"id":83465001,"name":"acs-engine","full_name":"dmitsh/acs-engine","owner":{"login":"dmitsh","id":17212177,"avatar_url":"https://avatars3.githubusercontent.com/u/17212177?v=4","gravatar_id":"","url":"https://api.github.com/users/dmitsh","html_url":"https://github.com/dmitsh","followers_url":"https://api.github.com/users/dmitsh/followers","following_url":"https://api.github.com/users/dmitsh/following{/other_user}","gists_url":"https://api.github.com/users/dmitsh/gists{/gist_id}","starred_url":"https://api.github.com/users/dmitsh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmitsh/subscriptions","organizations_url":"https://api.github.com/users/dmitsh/orgs","repos_url":"https://api.github.com/users/dmitsh/repos","events_url":"https://api.github.com/users/dmitsh/events{/privacy}","received_events_url":"https://api.github.com/users/dmitsh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dmitsh/acs-engine","description":"Azure Container Service Engine - a place for community to collaborate and build the best open Docker container infrastructure for Azure.","fork":true,"url":"https://api.github.com/repos/dmitsh/acs-engine","forks_url":"https://api.github.com/repos/dmitsh/acs-engine/forks","keys_url":"https://api.github.com/repos/dmitsh/acs-engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dmitsh/acs-engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dmitsh/acs-engine/teams","hooks_url":"https://api.github.com/repos/dmitsh/acs-engine/hooks","issue_events_url":"https://api.github.com/repos/dmitsh/acs-engine/issues/events{/number}","events_url":"https://api.github.com/repos/dmitsh/acs-engine/events","assignees_url":"https://api.github.com/repos/dmitsh/acs-engine/assignees{/user}","branches_url":"https://api.github.com/repos/dmitsh/acs-engine/branches{/branch}","tags_url":"https://api.github.com/repos/dmitsh/acs-engine/tags","blobs_url":"https://api.github.com/repos/dmitsh/acs-engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dmitsh/acs-engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dmitsh/acs-engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/dmitsh/acs-engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dmitsh/acs-engine/statuses/{sha}","languages_url":"https://api.github.com/repos/dmitsh/acs-engine/languages","stargazers_url":"https://api.github.com/repos/dmitsh/acs-engine/stargazers","contributors_url":"https://api.github.com/repos/dmitsh/acs-engine/contributors","subscribers_url":"https://api.github.com/repos/dmitsh/acs-engine/subscribers","subscription_url":"https://api.github.com/repos/dmitsh/acs-engine/subscription","commits_url":"https://api.github.com/repos/dmitsh/acs-engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/dmitsh/acs-engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/dmitsh/acs-engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/dmitsh/acs-engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/dmitsh/acs-engine/contents/{+path}","compare_url":"https://api.github.com/repos/dmitsh/acs-engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dmitsh/acs-engine/merges","archive_url":"https://api.github.com/repos/dmitsh/acs-engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dmitsh/acs-engine/downloads","issues_url":"https://api.github.com/repos/dmitsh/acs-engine/issues{/number}","pulls_url":"https://api.github.com/repos/dmitsh/acs-engine/pulls{/number}","milestones_url":"https://api.github.com/repos/dmitsh/acs-engine/milestones{/number}","notifications_url":"https://api.github.com/repos/dmitsh/acs-engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dmitsh/acs-engine/labels{/name}","releases_url":"https://api.github.com/repos/dmitsh/acs-engine/releases{/id}","deployments_url":"https://api.github.com/repos/dmitsh/acs-engine/deployments","created_at":"2017-02-28T18:20:24Z","updated_at":"2017-03-31T23:48:08Z","pushed_at":"2017-10-11T00:01:27Z","git_url":"git://github.com/dmitsh/acs-engine.git","ssh_url":"git@github.com:dmitsh/acs-engine.git","clone_url":"https://github.com/dmitsh/acs-engine.git","svn_url":"https://github.com/dmitsh/acs-engine","homepage":"","size":40907,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"57ff0e2132fd27a1121e92a1466e5a1597e10f3e","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":66011370,"name":"acs-engine","full_name":"Azure/acs-engine","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/acs-engine","description":"Azure Container Service Engine - a place for community to collaborate and build the best open Docker container infrastructure for Azure.","fork":false,"url":"https://api.github.com/repos/Azure/acs-engine","forks_url":"https://api.github.com/repos/Azure/acs-engine/forks","keys_url":"https://api.github.com/repos/Azure/acs-engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/acs-engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/acs-engine/teams","hooks_url":"https://api.github.com/repos/Azure/acs-engine/hooks","issue_events_url":"https://api.github.com/repos/Azure/acs-engine/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/acs-engine/events","assignees_url":"https://api.github.com/repos/Azure/acs-engine/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/acs-engine/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/acs-engine/tags","blobs_url":"https://api.github.com/repos/Azure/acs-engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/acs-engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/acs-engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/acs-engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/acs-engine/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/acs-engine/languages","stargazers_url":"https://api.github.com/repos/Azure/acs-engine/stargazers","contributors_url":"https://api.github.com/repos/Azure/acs-engine/contributors","subscribers_url":"https://api.github.com/repos/Azure/acs-engine/subscribers","subscription_url":"https://api.github.com/repos/Azure/acs-engine/subscription","commits_url":"https://api.github.com/repos/Azure/acs-engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/acs-engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/acs-engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/acs-engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/acs-engine/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/acs-engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/acs-engine/merges","archive_url":"https://api.github.com/repos/Azure/acs-engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/acs-engine/downloads","issues_url":"https://api.github.com/repos/Azure/acs-engine/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/acs-engine/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/acs-engine/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/acs-engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/acs-engine/labels{/name}","releases_url":"https://api.github.com/repos/Azure/acs-engine/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/acs-engine/deployments","created_at":"2016-08-18T16:05:16Z","updated_at":"2017-10-10T09:27:47Z","pushed_at":"2017-10-11T00:01:46Z","git_url":"git://github.com/Azure/acs-engine.git","ssh_url":"git@github.com:Azure/acs-engine.git","clone_url":"https://github.com/Azure/acs-engine.git","svn_url":"https://github.com/Azure/acs-engine","homepage":"","size":51607,"stargazers_count":469,"watchers_count":469,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":275,"mirror_url":null,"open_issues_count":265,"forks":275,"open_issues":265,"watchers":469,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/acs-engine/pulls/1578"},"html":{"href":"https://github.com/Azure/acs-engine/pull/1578"},"issue":{"href":"https://api.github.com/repos/Azure/acs-engine/issues/1578"},"comments":{"href":"https://api.github.com/repos/Azure/acs-engine/issues/1578/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/acs-engine/pulls/1578/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/acs-engine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/acs-engine/pulls/1578/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/acs-engine/statuses/b866f6f01c7a83a0a12438db101542aaaa8d4d33"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"weinong"}}