{"action":"created","comment":{"url":"https://api.github.com/repos/guardian/frontend/pulls/comments/143969400","pull_request_review_id":68556855,"id":143969400,"diff_hunk":"@@ -1,24 +1,27 @@\n // @flow\n import type { CtaUrls } from 'common/modules/commercial/contributions-utilities';\n \n-export const epicButtonsTemplate = ({\n-    membershipUrl = '',\n-    contributeUrl = '',\n-}: CtaUrls) =>\n-    `<div class=\"contributions__amount-field\">\n-          <div>\n-            <a class=\"contributions__option-button contributions__contribute contributions__contribute--epic contributions__contribute--epic-member contributions__contribute--epic-member-top\"\n-              href=\"${membershipUrl}\"\n-              target=\"_blank\">\n-              Become a supporter\n-            </a>\n-          </div>\n-        \n-          <div>\n-            <a class=\"contributions__option-button contributions__contribute contributions__contribute--epic contributions__contribute--epic-member\"\n-             href=\"${contributeUrl}\"\n-             target=\"_blank\">\n-             Make a contribution\n-           </a>\n-          </div>\n+export const epicButtonsTemplate = (\n+    { membershipUrl = '', contributeUrl = '' }: CtaUrls,\n+    useSupportDomain: boolean = false\n+) => {\n+    const contribButton = `<div>\n+        <a class=\"contributions__option-button contributions__contribute contributions__contribute--epic contributions__contribute--epic-member\"\n+         href=\"${contributeUrl}\"\n+         target=\"_blank\">\n+         Make a contribution\n+        </a>\n     </div>`;\n+    const supportButton = `<div>","path":"static/src/javascripts/projects/common/modules/commercial/templates/acquisitions-epic-buttons.js","position":35,"original_position":35,"commit_id":"2374c42d036c86a66120b2b1415183a0f743f553","original_commit_id":"2374c42d036c86a66120b2b1415183a0f743f553","user":{"login":"joelochlann","id":5122968,"avatar_url":"https://avatars3.githubusercontent.com/u/5122968?v=4","gravatar_id":"","url":"https://api.github.com/users/joelochlann","html_url":"https://github.com/joelochlann","followers_url":"https://api.github.com/users/joelochlann/followers","following_url":"https://api.github.com/users/joelochlann/following{/other_user}","gists_url":"https://api.github.com/users/joelochlann/gists{/gist_id}","starred_url":"https://api.github.com/users/joelochlann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joelochlann/subscriptions","organizations_url":"https://api.github.com/users/joelochlann/orgs","repos_url":"https://api.github.com/users/joelochlann/repos","events_url":"https://api.github.com/users/joelochlann/events{/privacy}","received_events_url":"https://api.github.com/users/joelochlann/received_events","type":"User","site_admin":false},"body":"just being pedantic but I generally find these inline html blocks more readable with the opening tag on the next line","created_at":"2017-10-11T10:21:26Z","updated_at":"2017-10-11T10:21:26Z","html_url":"https://github.com/guardian/frontend/pull/17986#discussion_r143969400","pull_request_url":"https://api.github.com/repos/guardian/frontend/pulls/17986","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/guardian/frontend/pulls/comments/143969400"},"html":{"href":"https://github.com/guardian/frontend/pull/17986#discussion_r143969400"},"pull_request":{"href":"https://api.github.com/repos/guardian/frontend/pulls/17986"}}},"pull_request":{"url":"https://api.github.com/repos/guardian/frontend/pulls/17986","id":145652195,"html_url":"https://github.com/guardian/frontend/pull/17986","diff_url":"https://github.com/guardian/frontend/pull/17986.diff","patch_url":"https://github.com/guardian/frontend/pull/17986.patch","issue_url":"https://api.github.com/repos/guardian/frontend/issues/17986","number":17986,"state":"open","locked":false,"title":"Add support frontend master switch and use in Epic","user":{"login":"JustinPinner","id":690395,"avatar_url":"https://avatars2.githubusercontent.com/u/690395?v=4","gravatar_id":"","url":"https://api.github.com/users/JustinPinner","html_url":"https://github.com/JustinPinner","followers_url":"https://api.github.com/users/JustinPinner/followers","following_url":"https://api.github.com/users/JustinPinner/following{/other_user}","gists_url":"https://api.github.com/users/JustinPinner/gists{/gist_id}","starred_url":"https://api.github.com/users/JustinPinner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JustinPinner/subscriptions","organizations_url":"https://api.github.com/users/JustinPinner/orgs","repos_url":"https://api.github.com/users/JustinPinner/repos","events_url":"https://api.github.com/users/JustinPinner/events{/privacy}","received_events_url":"https://api.github.com/users/JustinPinner/received_events","type":"User","site_admin":false},"body":"## What does this change?\r\nAdds a new master switch to control whether supporter traffic is sent to support.thegu...  or not, and used it in the epic's default button template.\r\n\r\n## What is the value of this and can you measure success?\r\nWe're getting set up to switch over to the new support domain. This is the first step to being able to do that.\r\n\r\n## Does this affect other platforms - Amp, Apps, etc?\r\nNo, web only\r\n\r\n## Does this affect GLabs Paid Content Pages? Should it have support for Paid Content?\r\nN/A\r\n\r\n## Screenshots\r\n**Switch ON, user in US**\r\n![screen shot 2017-10-10 at 15 04 26 switch on user in us 1](https://user-images.githubusercontent.com/690395/31390753-985c0d22-adcc-11e7-88a3-4ee2b249e874.png)\r\n![screen shot 2017-10-10 at 15 05 00 switch on user in us 2](https://user-images.githubusercontent.com/690395/31390758-9f193702-adcc-11e7-8bd2-d4020ffb96e6.png)\r\n\r\n**Switch ON, user in GB**\r\n![screen shot 2017-10-10 at 14 57 55 switch on user in gb](https://user-images.githubusercontent.com/690395/31390529-0f8bfa0c-adcc-11e7-9928-3038870e6567.png)\r\n\r\n**Switch OFF, user in GB**\r\n![screen shot 2017-10-10 at 14 59 10 switch off user in gb 1](https://user-images.githubusercontent.com/690395/31390551-1e252b88-adcc-11e7-8ca5-9282663096fb.png)\r\n![screen shot 2017-10-10 at 14 59 26 switch off user in gb 2](https://user-images.githubusercontent.com/690395/31390565-2552a1c4-adcc-11e7-9483-331a67e2e5a2.png)\r\n\r\n## Tested in CODE?\r\nYes\r\n![screen shot 2017-10-10 at 15 28 39](https://user-images.githubusercontent.com/690395/31392036-1cf8f830-add0-11e7-9720-80e24435523e.png)\r\n\r\n","created_at":"2017-10-10T10:20:20Z","updated_at":"2017-10-11T10:21:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cd0f5fb2f944a0af9234fb6dc6be9288af142b6a","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/guardian/frontend/pulls/17986/commits","review_comments_url":"https://api.github.com/repos/guardian/frontend/pulls/17986/comments","review_comment_url":"https://api.github.com/repos/guardian/frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/guardian/frontend/issues/17986/comments","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/2374c42d036c86a66120b2b1415183a0f743f553","head":{"label":"guardian:jp-support-frontend-master-switch","ref":"jp-support-frontend-master-switch","sha":"2374c42d036c86a66120b2b1415183a0f743f553","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars0.githubusercontent.com/u/164318?v=4","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":4370755,"name":"frontend","full_name":"guardian/frontend","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars0.githubusercontent.com/u/164318?v=4","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/frontend","description":"Source for theguardian.com","fork":false,"url":"https://api.github.com/repos/guardian/frontend","forks_url":"https://api.github.com/repos/guardian/frontend/forks","keys_url":"https://api.github.com/repos/guardian/frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/frontend/teams","hooks_url":"https://api.github.com/repos/guardian/frontend/hooks","issue_events_url":"https://api.github.com/repos/guardian/frontend/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/frontend/events","assignees_url":"https://api.github.com/repos/guardian/frontend/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/frontend/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/frontend/tags","blobs_url":"https://api.github.com/repos/guardian/frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/frontend/languages","stargazers_url":"https://api.github.com/repos/guardian/frontend/stargazers","contributors_url":"https://api.github.com/repos/guardian/frontend/contributors","subscribers_url":"https://api.github.com/repos/guardian/frontend/subscribers","subscription_url":"https://api.github.com/repos/guardian/frontend/subscription","commits_url":"https://api.github.com/repos/guardian/frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/frontend/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/frontend/merges","archive_url":"https://api.github.com/repos/guardian/frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/frontend/downloads","issues_url":"https://api.github.com/repos/guardian/frontend/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/frontend/labels{/name}","releases_url":"https://api.github.com/repos/guardian/frontend/releases{/id}","deployments_url":"https://api.github.com/repos/guardian/frontend/deployments","created_at":"2012-05-18T15:39:15Z","updated_at":"2017-10-11T10:04:17Z","pushed_at":"2017-10-11T09:58:38Z","git_url":"git://github.com/guardian/frontend.git","ssh_url":"git@github.com:guardian/frontend.git","clone_url":"https://github.com/guardian/frontend.git","svn_url":"https://github.com/guardian/frontend","homepage":"https://www.theguardian.com","size":533017,"stargazers_count":3647,"watchers_count":3647,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":394,"mirror_url":null,"open_issues_count":63,"forks":394,"open_issues":63,"watchers":3647,"default_branch":"master"}},"base":{"label":"guardian:master","ref":"master","sha":"b509e20499223fdc297b32b7d8de18aa4b69e0c4","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars0.githubusercontent.com/u/164318?v=4","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":4370755,"name":"frontend","full_name":"guardian/frontend","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars0.githubusercontent.com/u/164318?v=4","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/frontend","description":"Source for theguardian.com","fork":false,"url":"https://api.github.com/repos/guardian/frontend","forks_url":"https://api.github.com/repos/guardian/frontend/forks","keys_url":"https://api.github.com/repos/guardian/frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/frontend/teams","hooks_url":"https://api.github.com/repos/guardian/frontend/hooks","issue_events_url":"https://api.github.com/repos/guardian/frontend/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/frontend/events","assignees_url":"https://api.github.com/repos/guardian/frontend/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/frontend/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/frontend/tags","blobs_url":"https://api.github.com/repos/guardian/frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/frontend/languages","stargazers_url":"https://api.github.com/repos/guardian/frontend/stargazers","contributors_url":"https://api.github.com/repos/guardian/frontend/contributors","subscribers_url":"https://api.github.com/repos/guardian/frontend/subscribers","subscription_url":"https://api.github.com/repos/guardian/frontend/subscription","commits_url":"https://api.github.com/repos/guardian/frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/frontend/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/frontend/merges","archive_url":"https://api.github.com/repos/guardian/frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/frontend/downloads","issues_url":"https://api.github.com/repos/guardian/frontend/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/frontend/labels{/name}","releases_url":"https://api.github.com/repos/guardian/frontend/releases{/id}","deployments_url":"https://api.github.com/repos/guardian/frontend/deployments","created_at":"2012-05-18T15:39:15Z","updated_at":"2017-10-11T10:04:17Z","pushed_at":"2017-10-11T09:58:38Z","git_url":"git://github.com/guardian/frontend.git","ssh_url":"git@github.com:guardian/frontend.git","clone_url":"https://github.com/guardian/frontend.git","svn_url":"https://github.com/guardian/frontend","homepage":"https://www.theguardian.com","size":533017,"stargazers_count":3647,"watchers_count":3647,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":394,"mirror_url":null,"open_issues_count":63,"forks":394,"open_issues":63,"watchers":3647,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/guardian/frontend/pulls/17986"},"html":{"href":"https://github.com/guardian/frontend/pull/17986"},"issue":{"href":"https://api.github.com/repos/guardian/frontend/issues/17986"},"comments":{"href":"https://api.github.com/repos/guardian/frontend/issues/17986/comments"},"review_comments":{"href":"https://api.github.com/repos/guardian/frontend/pulls/17986/comments"},"review_comment":{"href":"https://api.github.com/repos/guardian/frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/guardian/frontend/pulls/17986/commits"},"statuses":{"href":"https://api.github.com/repos/guardian/frontend/statuses/2374c42d036c86a66120b2b1415183a0f743f553"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"joelochlann"}}