{"action":"created","comment":{"url":"https://api.github.com/repos/endlessm/libingester/pulls/comments/137845286","pull_request_review_id":61570065,"id":137845286,"diff_hunk":"@@ -2,15 +2,50 @@\n \n const fs = require('fs');\n const expect = require('chai').expect;\n+const proxyquire = require('proxyquire');\n \n-const libingester = require('../../lib/index');\n+const libingester = proxyquire('../../lib/index', {\n+    './verify': {\n+        verify_metadata: () => {},\n+        verify_manifest_entry: () => {},\n+    },\n+});\n+\n+class MockAsset extends libingester.BaseAsset {\n+    fails_with_error(err) { this._err = err; }\n+    set_dependent_assets(dependents) { this._dependents = dependents; }\n+    get_dependent_assets() {\n+        if (this._dependents) {\n+            return this._dependents.map(asset => asset.asset_id);\n+        } else {\n+            return [];\n+        }\n+    }\n+    _process() {\n+        if (this._err) {\n+            return Promise.reject(this._err);\n+        } else {","path":"test/lib/index.test.js","position":27,"original_position":27,"commit_id":"46bfdd03a627e22e7ffa2b9534ecabfaedbc0a29","original_commit_id":"46bfdd03a627e22e7ffa2b9534ecabfaedbc0a29","user":{"login":"sgnn7","id":175811,"avatar_url":"https://avatars2.githubusercontent.com/u/175811?v=4","gravatar_id":"","url":"https://api.github.com/users/sgnn7","html_url":"https://github.com/sgnn7","followers_url":"https://api.github.com/users/sgnn7/followers","following_url":"https://api.github.com/users/sgnn7/following{/other_user}","gists_url":"https://api.github.com/users/sgnn7/gists{/gist_id}","starred_url":"https://api.github.com/users/sgnn7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgnn7/subscriptions","organizations_url":"https://api.github.com/users/sgnn7/orgs","repos_url":"https://api.github.com/users/sgnn7/repos","events_url":"https://api.github.com/users/sgnn7/events{/privacy}","received_events_url":"https://api.github.com/users/sgnn7/received_events","type":"User","site_admin":false},"body":"No need for else","created_at":"2017-09-08T17:25:42Z","updated_at":"2017-09-08T17:27:59Z","html_url":"https://github.com/endlessm/libingester/pull/77#discussion_r137845286","pull_request_url":"https://api.github.com/repos/endlessm/libingester/pulls/77","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/endlessm/libingester/pulls/comments/137845286"},"html":{"href":"https://github.com/endlessm/libingester/pull/77#discussion_r137845286"},"pull_request":{"href":"https://api.github.com/repos/endlessm/libingester/pulls/77"}}},"pull_request":{"url":"https://api.github.com/repos/endlessm/libingester/pulls/77","id":139682452,"html_url":"https://github.com/endlessm/libingester/pull/77","diff_url":"https://github.com/endlessm/libingester/pull/77.diff","patch_url":"https://github.com/endlessm/libingester/pull/77.patch","issue_url":"https://api.github.com/repos/endlessm/libingester/issues/77","number":77,"state":"open","locked":false,"title":"T19079","user":{"login":"wgreenberg","id":626277,"avatar_url":"https://avatars0.githubusercontent.com/u/626277?v=4","gravatar_id":"","url":"https://api.github.com/users/wgreenberg","html_url":"https://github.com/wgreenberg","followers_url":"https://api.github.com/users/wgreenberg/followers","following_url":"https://api.github.com/users/wgreenberg/following{/other_user}","gists_url":"https://api.github.com/users/wgreenberg/gists{/gist_id}","starred_url":"https://api.github.com/users/wgreenberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wgreenberg/subscriptions","organizations_url":"https://api.github.com/users/wgreenberg/orgs","repos_url":"https://api.github.com/users/wgreenberg/repos","events_url":"https://api.github.com/users/wgreenberg/events{/privacy}","received_events_url":"https://api.github.com/users/wgreenberg/received_events","type":"User","site_admin":false},"body":"https://phabricator.endlessm.com/T19079","created_at":"2017-09-06T22:53:27Z","updated_at":"2017-09-08T17:27:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"446e2c8d65660997c8cc53d6aa624e20103d3c32","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/endlessm/libingester/pulls/77/commits","review_comments_url":"https://api.github.com/repos/endlessm/libingester/pulls/77/comments","review_comment_url":"https://api.github.com/repos/endlessm/libingester/pulls/comments{/number}","comments_url":"https://api.github.com/repos/endlessm/libingester/issues/77/comments","statuses_url":"https://api.github.com/repos/endlessm/libingester/statuses/46bfdd03a627e22e7ffa2b9534ecabfaedbc0a29","head":{"label":"endlessm:T19079","ref":"T19079","sha":"46bfdd03a627e22e7ffa2b9534ecabfaedbc0a29","user":{"login":"endlessm","id":1930958,"avatar_url":"https://avatars1.githubusercontent.com/u/1930958?v=4","gravatar_id":"","url":"https://api.github.com/users/endlessm","html_url":"https://github.com/endlessm","followers_url":"https://api.github.com/users/endlessm/followers","following_url":"https://api.github.com/users/endlessm/following{/other_user}","gists_url":"https://api.github.com/users/endlessm/gists{/gist_id}","starred_url":"https://api.github.com/users/endlessm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endlessm/subscriptions","organizations_url":"https://api.github.com/users/endlessm/orgs","repos_url":"https://api.github.com/users/endlessm/repos","events_url":"https://api.github.com/users/endlessm/events{/privacy}","received_events_url":"https://api.github.com/users/endlessm/received_events","type":"Organization","site_admin":false},"repo":{"id":84107738,"name":"libingester","full_name":"endlessm/libingester","owner":{"login":"endlessm","id":1930958,"avatar_url":"https://avatars1.githubusercontent.com/u/1930958?v=4","gravatar_id":"","url":"https://api.github.com/users/endlessm","html_url":"https://github.com/endlessm","followers_url":"https://api.github.com/users/endlessm/followers","following_url":"https://api.github.com/users/endlessm/following{/other_user}","gists_url":"https://api.github.com/users/endlessm/gists{/gist_id}","starred_url":"https://api.github.com/users/endlessm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endlessm/subscriptions","organizations_url":"https://api.github.com/users/endlessm/orgs","repos_url":"https://api.github.com/users/endlessm/repos","events_url":"https://api.github.com/users/endlessm/events{/privacy}","received_events_url":"https://api.github.com/users/endlessm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/endlessm/libingester","description":"Library used to create application ingesters","fork":false,"url":"https://api.github.com/repos/endlessm/libingester","forks_url":"https://api.github.com/repos/endlessm/libingester/forks","keys_url":"https://api.github.com/repos/endlessm/libingester/keys{/key_id}","collaborators_url":"https://api.github.com/repos/endlessm/libingester/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/endlessm/libingester/teams","hooks_url":"https://api.github.com/repos/endlessm/libingester/hooks","issue_events_url":"https://api.github.com/repos/endlessm/libingester/issues/events{/number}","events_url":"https://api.github.com/repos/endlessm/libingester/events","assignees_url":"https://api.github.com/repos/endlessm/libingester/assignees{/user}","branches_url":"https://api.github.com/repos/endlessm/libingester/branches{/branch}","tags_url":"https://api.github.com/repos/endlessm/libingester/tags","blobs_url":"https://api.github.com/repos/endlessm/libingester/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/endlessm/libingester/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/endlessm/libingester/git/refs{/sha}","trees_url":"https://api.github.com/repos/endlessm/libingester/git/trees{/sha}","statuses_url":"https://api.github.com/repos/endlessm/libingester/statuses/{sha}","languages_url":"https://api.github.com/repos/endlessm/libingester/languages","stargazers_url":"https://api.github.com/repos/endlessm/libingester/stargazers","contributors_url":"https://api.github.com/repos/endlessm/libingester/contributors","subscribers_url":"https://api.github.com/repos/endlessm/libingester/subscribers","subscription_url":"https://api.github.com/repos/endlessm/libingester/subscription","commits_url":"https://api.github.com/repos/endlessm/libingester/commits{/sha}","git_commits_url":"https://api.github.com/repos/endlessm/libingester/git/commits{/sha}","comments_url":"https://api.github.com/repos/endlessm/libingester/comments{/number}","issue_comment_url":"https://api.github.com/repos/endlessm/libingester/issues/comments{/number}","contents_url":"https://api.github.com/repos/endlessm/libingester/contents/{+path}","compare_url":"https://api.github.com/repos/endlessm/libingester/compare/{base}...{head}","merges_url":"https://api.github.com/repos/endlessm/libingester/merges","archive_url":"https://api.github.com/repos/endlessm/libingester/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/endlessm/libingester/downloads","issues_url":"https://api.github.com/repos/endlessm/libingester/issues{/number}","pulls_url":"https://api.github.com/repos/endlessm/libingester/pulls{/number}","milestones_url":"https://api.github.com/repos/endlessm/libingester/milestones{/number}","notifications_url":"https://api.github.com/repos/endlessm/libingester/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/endlessm/libingester/labels{/name}","releases_url":"https://api.github.com/repos/endlessm/libingester/releases{/id}","deployments_url":"https://api.github.com/repos/endlessm/libingester/deployments","created_at":"2017-03-06T18:39:35Z","updated_at":"2017-03-20T18:20:23Z","pushed_at":"2017-09-07T18:19:48Z","git_url":"git://github.com/endlessm/libingester.git","ssh_url":"git@github.com:endlessm/libingester.git","clone_url":"https://github.com/endlessm/libingester.git","svn_url":"https://github.com/endlessm/libingester","homepage":"https://endlessos.com","size":292,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":3,"forks":3,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"endlessm:master","ref":"master","sha":"f19f81cd488fa2fa6be91b6bb0fd4b8f0078bb89","user":{"login":"endlessm","id":1930958,"avatar_url":"https://avatars1.githubusercontent.com/u/1930958?v=4","gravatar_id":"","url":"https://api.github.com/users/endlessm","html_url":"https://github.com/endlessm","followers_url":"https://api.github.com/users/endlessm/followers","following_url":"https://api.github.com/users/endlessm/following{/other_user}","gists_url":"https://api.github.com/users/endlessm/gists{/gist_id}","starred_url":"https://api.github.com/users/endlessm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endlessm/subscriptions","organizations_url":"https://api.github.com/users/endlessm/orgs","repos_url":"https://api.github.com/users/endlessm/repos","events_url":"https://api.github.com/users/endlessm/events{/privacy}","received_events_url":"https://api.github.com/users/endlessm/received_events","type":"Organization","site_admin":false},"repo":{"id":84107738,"name":"libingester","full_name":"endlessm/libingester","owner":{"login":"endlessm","id":1930958,"avatar_url":"https://avatars1.githubusercontent.com/u/1930958?v=4","gravatar_id":"","url":"https://api.github.com/users/endlessm","html_url":"https://github.com/endlessm","followers_url":"https://api.github.com/users/endlessm/followers","following_url":"https://api.github.com/users/endlessm/following{/other_user}","gists_url":"https://api.github.com/users/endlessm/gists{/gist_id}","starred_url":"https://api.github.com/users/endlessm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endlessm/subscriptions","organizations_url":"https://api.github.com/users/endlessm/orgs","repos_url":"https://api.github.com/users/endlessm/repos","events_url":"https://api.github.com/users/endlessm/events{/privacy}","received_events_url":"https://api.github.com/users/endlessm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/endlessm/libingester","description":"Library used to create application ingesters","fork":false,"url":"https://api.github.com/repos/endlessm/libingester","forks_url":"https://api.github.com/repos/endlessm/libingester/forks","keys_url":"https://api.github.com/repos/endlessm/libingester/keys{/key_id}","collaborators_url":"https://api.github.com/repos/endlessm/libingester/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/endlessm/libingester/teams","hooks_url":"https://api.github.com/repos/endlessm/libingester/hooks","issue_events_url":"https://api.github.com/repos/endlessm/libingester/issues/events{/number}","events_url":"https://api.github.com/repos/endlessm/libingester/events","assignees_url":"https://api.github.com/repos/endlessm/libingester/assignees{/user}","branches_url":"https://api.github.com/repos/endlessm/libingester/branches{/branch}","tags_url":"https://api.github.com/repos/endlessm/libingester/tags","blobs_url":"https://api.github.com/repos/endlessm/libingester/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/endlessm/libingester/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/endlessm/libingester/git/refs{/sha}","trees_url":"https://api.github.com/repos/endlessm/libingester/git/trees{/sha}","statuses_url":"https://api.github.com/repos/endlessm/libingester/statuses/{sha}","languages_url":"https://api.github.com/repos/endlessm/libingester/languages","stargazers_url":"https://api.github.com/repos/endlessm/libingester/stargazers","contributors_url":"https://api.github.com/repos/endlessm/libingester/contributors","subscribers_url":"https://api.github.com/repos/endlessm/libingester/subscribers","subscription_url":"https://api.github.com/repos/endlessm/libingester/subscription","commits_url":"https://api.github.com/repos/endlessm/libingester/commits{/sha}","git_commits_url":"https://api.github.com/repos/endlessm/libingester/git/commits{/sha}","comments_url":"https://api.github.com/repos/endlessm/libingester/comments{/number}","issue_comment_url":"https://api.github.com/repos/endlessm/libingester/issues/comments{/number}","contents_url":"https://api.github.com/repos/endlessm/libingester/contents/{+path}","compare_url":"https://api.github.com/repos/endlessm/libingester/compare/{base}...{head}","merges_url":"https://api.github.com/repos/endlessm/libingester/merges","archive_url":"https://api.github.com/repos/endlessm/libingester/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/endlessm/libingester/downloads","issues_url":"https://api.github.com/repos/endlessm/libingester/issues{/number}","pulls_url":"https://api.github.com/repos/endlessm/libingester/pulls{/number}","milestones_url":"https://api.github.com/repos/endlessm/libingester/milestones{/number}","notifications_url":"https://api.github.com/repos/endlessm/libingester/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/endlessm/libingester/labels{/name}","releases_url":"https://api.github.com/repos/endlessm/libingester/releases{/id}","deployments_url":"https://api.github.com/repos/endlessm/libingester/deployments","created_at":"2017-03-06T18:39:35Z","updated_at":"2017-03-20T18:20:23Z","pushed_at":"2017-09-07T18:19:48Z","git_url":"git://github.com/endlessm/libingester.git","ssh_url":"git@github.com:endlessm/libingester.git","clone_url":"https://github.com/endlessm/libingester.git","svn_url":"https://github.com/endlessm/libingester","homepage":"https://endlessos.com","size":292,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":3,"forks":3,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/endlessm/libingester/pulls/77"},"html":{"href":"https://github.com/endlessm/libingester/pull/77"},"issue":{"href":"https://api.github.com/repos/endlessm/libingester/issues/77"},"comments":{"href":"https://api.github.com/repos/endlessm/libingester/issues/77/comments"},"review_comments":{"href":"https://api.github.com/repos/endlessm/libingester/pulls/77/comments"},"review_comment":{"href":"https://api.github.com/repos/endlessm/libingester/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/endlessm/libingester/pulls/77/commits"},"statuses":{"href":"https://api.github.com/repos/endlessm/libingester/statuses/46bfdd03a627e22e7ffa2b9534ecabfaedbc0a29"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"sgnn7"}}