{"action":"created","issue":{"url":"https://api.github.com/repos/jojojames/evil-collection/issues/37","repository_url":"https://api.github.com/repos/jojojames/evil-collection","labels_url":"https://api.github.com/repos/jojojames/evil-collection/issues/37/labels{/name}","comments_url":"https://api.github.com/repos/jojojames/evil-collection/issues/37/comments","events_url":"https://api.github.com/repos/jojojames/evil-collection/issues/37/events","html_url":"https://github.com/jojojames/evil-collection/issues/37","id":275472723,"number":37,"title":"Clean up byte-compiler's warnings","user":{"login":"Ambrevar","id":1489143,"avatar_url":"https://avatars0.githubusercontent.com/u/1489143?v=4","gravatar_id":"","url":"https://api.github.com/users/Ambrevar","html_url":"https://github.com/Ambrevar","followers_url":"https://api.github.com/users/Ambrevar/followers","following_url":"https://api.github.com/users/Ambrevar/following{/other_user}","gists_url":"https://api.github.com/users/Ambrevar/gists{/gist_id}","starred_url":"https://api.github.com/users/Ambrevar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ambrevar/subscriptions","organizations_url":"https://api.github.com/users/Ambrevar/orgs","repos_url":"https://api.github.com/users/Ambrevar/repos","events_url":"https://api.github.com/users/Ambrevar/events{/privacy}","received_events_url":"https://api.github.com/users/Ambrevar/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2017-11-20T19:36:07Z","updated_at":"2017-11-21T02:11:41Z","closed_at":null,"author_association":"COLLABORATOR","body":"Following up on #22.\r\n\r\nWe want to have clean code and clean byte-compilation, i.e. no warnings.\r\n\r\nAs of now, some `defun`s are wrapped in `with-no-warnings` blocks.  This has several downsides:\r\n\r\n- It silences possible valuable warnings inside the `defun`s.\r\n\r\n- The warnings are spurious: we should not add kludges around correct code.  Code quality is more important than the opinion of an automated linter.\r\n\r\n- It's not pretty and `defun`s are not top-level anymore."},"comment":{"url":"https://api.github.com/repos/jojojames/evil-collection/issues/comments/345893902","html_url":"https://github.com/jojojames/evil-collection/issues/37#issuecomment-345893902","issue_url":"https://api.github.com/repos/jojojames/evil-collection/issues/37","id":345893902,"user":{"login":"jojojames","id":1227856,"avatar_url":"https://avatars1.githubusercontent.com/u/1227856?v=4","gravatar_id":"","url":"https://api.github.com/users/jojojames","html_url":"https://github.com/jojojames","followers_url":"https://api.github.com/users/jojojames/followers","following_url":"https://api.github.com/users/jojojames/following{/other_user}","gists_url":"https://api.github.com/users/jojojames/gists{/gist_id}","starred_url":"https://api.github.com/users/jojojames/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jojojames/subscriptions","organizations_url":"https://api.github.com/users/jojojames/orgs","repos_url":"https://api.github.com/users/jojojames/repos","events_url":"https://api.github.com/users/jojojames/events{/privacy}","received_events_url":"https://api.github.com/users/jojojames/received_events","type":"User","site_admin":false},"created_at":"2017-11-21T02:11:41Z","updated_at":"2017-11-21T02:11:41Z","author_association":"OWNER","body":"I agree, and I think we should strive for no warnings too.\r\n\r\nIs fboundp a good middleground @fbergroth and @Ambrevar?\r\n\r\nBTW, my current stance on it is that I'm fine with the ignore-errors wrapping. I do see @Ambrevar concerns though. At the same time, this package should be simple enough (setting some bindings...) that it doesn't seem to be a huge deal to me."}}
{"actor":{"display_login":"jojojames"}}