{"action":"created","issue":{"url":"https://api.github.com/repos/RocketMap/RocketMap/issues/1852","repository_url":"https://api.github.com/repos/RocketMap/RocketMap","labels_url":"https://api.github.com/repos/RocketMap/RocketMap/issues/1852/labels{/name}","comments_url":"https://api.github.com/repos/RocketMap/RocketMap/issues/1852/comments","events_url":"https://api.github.com/repos/RocketMap/RocketMap/issues/1852/events","html_url":"https://github.com/RocketMap/RocketMap/pull/1852","id":209401507,"number":1852,"title":"Popup Notification for tiny rattata and big magikarp","user":{"login":"dev042","id":25780879,"avatar_url":"https://avatars1.githubusercontent.com/u/25780879?v=3","gravatar_id":"","url":"https://api.github.com/users/dev042","html_url":"https://github.com/dev042","followers_url":"https://api.github.com/users/dev042/followers","following_url":"https://api.github.com/users/dev042/following{/other_user}","gists_url":"https://api.github.com/users/dev042/gists{/gist_id}","starred_url":"https://api.github.com/users/dev042/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dev042/subscriptions","organizations_url":"https://api.github.com/users/dev042/orgs","repos_url":"https://api.github.com/users/dev042/repos","events_url":"https://api.github.com/users/dev042/events{/privacy}","received_events_url":"https://api.github.com/users/dev042/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":12,"created_at":"2017-02-22T09:47:51Z","updated_at":"2017-03-03T12:45:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/RocketMap/RocketMap/pulls/1852","html_url":"https://github.com/RocketMap/RocketMap/pull/1852","diff_url":"https://github.com/RocketMap/RocketMap/pull/1852.diff","patch_url":"https://github.com/RocketMap/RocketMap/pull/1852.patch"},"body":"<!--- Provide a general summary of your changes in the Title above -->\r\n    implement pokemon medal detection\r\n    \r\n    * added ability to detect big/tiny pokemon\r\n    * added popup notification\r\n    * added information to pokemonlabel\r\n\r\n    add gender from PR #1828 \r\n    \r\n    * added gender to Pokemon BaseModel\r\n    * added gender to PokemonLabel\r\n\r\n## Description\r\nThis PR adds some height, weight and gender information to the PokemonLabel.\r\nIn Additional to the PR #1828 i did a popup notification to show Medal Pokemons.\r\n<!--- Describe your changes in detail -->\r\n\r\n## Motivation and Context\r\nI was MITM the encounter routine and saw, that it's provide more information that we actually get from it.\r\nAfter i saw we get the high and weight from the ecounter i though maybe i can do a detection for tiny and big magikarp and now it's happen.\r\n<!--- Why is this change required? What problem does it solve? -->\r\n<!--- If it fixes an open issue, please link to the issue here. -->\r\nThis PR is not required, but it;s a new feature to get faster your Medals.\r\n## How Has This Been Tested?\r\nI run this PR in my map since i code it and works very well.\r\n<!--- Please describe in detail how you tested your changes. -->\r\n<!--- Include details of your testing environment, and the tests you ran to -->\r\n<!--- see how your change affects other areas of the code, etc. -->\r\n\r\n## Screenshots (if appropriate):\r\n![medal_party](https://cloud.githubusercontent.com/assets/25780879/23205999/4f722e4c-f8ec-11e6-9213-9fbcb5d49734.jpg)\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [ x] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n<!--  NOTE: In order to check code style locally and avoid having your build rejected by Travis, -->\r\n<!--  run the following commands before you commit: `flake8 .` and `npm run lint`. Fix any -->\r\n<!--  issues they point out. Note also that flake's NOQA is disabled on Travis. -->\r\n- [ x] My code follows the code style of this project.\r\n- [ ] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\n"},"comment":{"url":"https://api.github.com/repos/RocketMap/RocketMap/issues/comments/283944335","html_url":"https://github.com/RocketMap/RocketMap/pull/1852#issuecomment-283944335","issue_url":"https://api.github.com/repos/RocketMap/RocketMap/issues/1852","id":283944335,"user":{"login":"drallieiv","id":715099,"avatar_url":"https://avatars3.githubusercontent.com/u/715099?v=3","gravatar_id":"","url":"https://api.github.com/users/drallieiv","html_url":"https://github.com/drallieiv","followers_url":"https://api.github.com/users/drallieiv/followers","following_url":"https://api.github.com/users/drallieiv/following{/other_user}","gists_url":"https://api.github.com/users/drallieiv/gists{/gist_id}","starred_url":"https://api.github.com/users/drallieiv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drallieiv/subscriptions","organizations_url":"https://api.github.com/users/drallieiv/orgs","repos_url":"https://api.github.com/users/drallieiv/repos","events_url":"https://api.github.com/users/drallieiv/events{/privacy}","received_events_url":"https://api.github.com/users/drallieiv/received_events","type":"User","site_admin":false},"created_at":"2017-03-03T12:45:45Z","updated_at":"2017-03-03T12:45:45Z","body":"Rattata with no size triggers the notification in the web UI. I think it's one of the comment seb already did. No size should not be < required size"}}
{"actor":{"display_login":"drallieiv"}}