{"action":"opened","number":1,"pull_request":{"url":"https://api.github.com/repos/memobc/memolab-fmri-qa/pulls/1","id":123792388,"html_url":"https://github.com/memobc/memolab-fmri-qa/pull/1","diff_url":"https://github.com/memobc/memolab-fmri-qa/pull/1.diff","patch_url":"https://github.com/memobc/memolab-fmri-qa/pull/1.patch","issue_url":"https://api.github.com/repos/memobc/memolab-fmri-qa/issues/1","number":1,"state":"open","locked":false,"title":"Kyle's proposed code changes to accommodate BIDS formatted datasets","user":{"login":"kakurk","id":20688981,"avatar_url":"https://avatars0.githubusercontent.com/u/20688981?v=3","gravatar_id":"","url":"https://api.github.com/users/kakurk","html_url":"https://github.com/kakurk","followers_url":"https://api.github.com/users/kakurk/followers","following_url":"https://api.github.com/users/kakurk/following{/other_user}","gists_url":"https://api.github.com/users/kakurk/gists{/gist_id}","starred_url":"https://api.github.com/users/kakurk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kakurk/subscriptions","organizations_url":"https://api.github.com/users/kakurk/orgs","repos_url":"https://api.github.com/users/kakurk/repos","events_url":"https://api.github.com/users/kakurk/events{/privacy}","received_events_url":"https://api.github.com/users/kakurk/received_events","type":"User","site_admin":false},"body":"Hey @ritcheym ,\r\n\r\nI just ran the memolab-fmri-qa pipeline on the Haxby dataset (per your suggestion) and I remembered something. One of the reasons why I did NOT run the memolab-fmri-qa pipeline was that this pipeline **does** **not** **accommodate** **BIDS** **formatted** **datasets**.\r\n\r\nI was forced to make the changes below to the code, which I am suggesting here be permeant changes to the memolab-fmri-qa pipeline. I figured that all fMRI datasets we encounter as a lab from here on out should be BIDS formatted. I also wanted to try doing a pull request :).\r\n\r\nA summary of the changes:\r\n\r\n1.) I utilized the recursive functionality of the spm_select function to grab files where appropriate. I made corresponding changes to the regular expression. What is nice about the BIDS format is that all files have **unique**, **informative** **filenames**, making recursive selection of them do-able.\r\n\r\n2.) I was forced to give the output files of the `create_spike_regs` function unique filenames. This is because there are no run specific folders in BIDS format, so we need to be able to differentiate successive runs from one another.\r\n\r\n3.) In the base `memolab_batch_qa` script, I made a suggested change to the defaults. The combinations of the functions `fileparts(mfilename('fullpath'))` should automatically return the path of the `memolab_batch_qa.m` file, which should be the scripts directory. This makes sense as a default in the pipeline.","created_at":"2017-06-02T20:15:15Z","updated_at":"2017-06-02T20:15:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/memobc/memolab-fmri-qa/pulls/1/commits","review_comments_url":"https://api.github.com/repos/memobc/memolab-fmri-qa/pulls/1/comments","review_comment_url":"https://api.github.com/repos/memobc/memolab-fmri-qa/pulls/comments{/number}","comments_url":"https://api.github.com/repos/memobc/memolab-fmri-qa/issues/1/comments","statuses_url":"https://api.github.com/repos/memobc/memolab-fmri-qa/statuses/3421247a0b0f4c674fd0bec49d37f3e40c5bab55","head":{"label":"kakurk:master","ref":"master","sha":"3421247a0b0f4c674fd0bec49d37f3e40c5bab55","user":{"login":"kakurk","id":20688981,"avatar_url":"https://avatars0.githubusercontent.com/u/20688981?v=3","gravatar_id":"","url":"https://api.github.com/users/kakurk","html_url":"https://github.com/kakurk","followers_url":"https://api.github.com/users/kakurk/followers","following_url":"https://api.github.com/users/kakurk/following{/other_user}","gists_url":"https://api.github.com/users/kakurk/gists{/gist_id}","starred_url":"https://api.github.com/users/kakurk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kakurk/subscriptions","organizations_url":"https://api.github.com/users/kakurk/orgs","repos_url":"https://api.github.com/users/kakurk/repos","events_url":"https://api.github.com/users/kakurk/events{/privacy}","received_events_url":"https://api.github.com/users/kakurk/received_events","type":"User","site_admin":false},"repo":{"id":93198860,"name":"memolab-fmri-qa","full_name":"kakurk/memolab-fmri-qa","owner":{"login":"kakurk","id":20688981,"avatar_url":"https://avatars0.githubusercontent.com/u/20688981?v=3","gravatar_id":"","url":"https://api.github.com/users/kakurk","html_url":"https://github.com/kakurk","followers_url":"https://api.github.com/users/kakurk/followers","following_url":"https://api.github.com/users/kakurk/following{/other_user}","gists_url":"https://api.github.com/users/kakurk/gists{/gist_id}","starred_url":"https://api.github.com/users/kakurk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kakurk/subscriptions","organizations_url":"https://api.github.com/users/kakurk/orgs","repos_url":"https://api.github.com/users/kakurk/repos","events_url":"https://api.github.com/users/kakurk/events{/privacy}","received_events_url":"https://api.github.com/users/kakurk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kakurk/memolab-fmri-qa","description":"Scripts for doing general QA on fMRI data, including ArtRepair","fork":true,"url":"https://api.github.com/repos/kakurk/memolab-fmri-qa","forks_url":"https://api.github.com/repos/kakurk/memolab-fmri-qa/forks","keys_url":"https://api.github.com/repos/kakurk/memolab-fmri-qa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kakurk/memolab-fmri-qa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kakurk/memolab-fmri-qa/teams","hooks_url":"https://api.github.com/repos/kakurk/memolab-fmri-qa/hooks","issue_events_url":"https://api.github.com/repos/kakurk/memolab-fmri-qa/issues/events{/number}","events_url":"https://api.github.com/repos/kakurk/memolab-fmri-qa/events","assignees_url":"https://api.github.com/repos/kakurk/memolab-fmri-qa/assignees{/user}","branches_url":"https://api.github.com/repos/kakurk/memolab-fmri-qa/branches{/branch}","tags_url":"https://api.github.com/repos/kakurk/memolab-fmri-qa/tags","blobs_url":"https://api.github.com/repos/kakurk/memolab-fmri-qa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kakurk/memolab-fmri-qa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kakurk/memolab-fmri-qa/git/refs{/sha}","trees_url":"https://api.github.com/repos/kakurk/memolab-fmri-qa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kakurk/memolab-fmri-qa/statuses/{sha}","languages_url":"https://api.github.com/repos/kakurk/memolab-fmri-qa/languages","stargazers_url":"https://api.github.com/repos/kakurk/memolab-fmri-qa/stargazers","contributors_url":"https://api.github.com/repos/kakurk/memolab-fmri-qa/contributors","subscribers_url":"https://api.github.com/repos/kakurk/memolab-fmri-qa/subscribers","subscription_url":"https://api.github.com/repos/kakurk/memolab-fmri-qa/subscription","commits_url":"https://api.github.com/repos/kakurk/memolab-fmri-qa/commits{/sha}","git_commits_url":"https://api.github.com/repos/kakurk/memolab-fmri-qa/git/commits{/sha}","comments_url":"https://api.github.com/repos/kakurk/memolab-fmri-qa/comments{/number}","issue_comment_url":"https://api.github.com/repos/kakurk/memolab-fmri-qa/issues/comments{/number}","contents_url":"https://api.github.com/repos/kakurk/memolab-fmri-qa/contents/{+path}","compare_url":"https://api.github.com/repos/kakurk/memolab-fmri-qa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kakurk/memolab-fmri-qa/merges","archive_url":"https://api.github.com/repos/kakurk/memolab-fmri-qa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kakurk/memolab-fmri-qa/downloads","issues_url":"https://api.github.com/repos/kakurk/memolab-fmri-qa/issues{/number}","pulls_url":"https://api.github.com/repos/kakurk/memolab-fmri-qa/pulls{/number}","milestones_url":"https://api.github.com/repos/kakurk/memolab-fmri-qa/milestones{/number}","notifications_url":"https://api.github.com/repos/kakurk/memolab-fmri-qa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kakurk/memolab-fmri-qa/labels{/name}","releases_url":"https://api.github.com/repos/kakurk/memolab-fmri-qa/releases{/id}","deployments_url":"https://api.github.com/repos/kakurk/memolab-fmri-qa/deployments","created_at":"2017-06-02T19:48:06Z","updated_at":"2017-06-02T19:48:08Z","pushed_at":"2017-06-02T20:02:38Z","git_url":"git://github.com/kakurk/memolab-fmri-qa.git","ssh_url":"git@github.com:kakurk/memolab-fmri-qa.git","clone_url":"https://github.com/kakurk/memolab-fmri-qa.git","svn_url":"https://github.com/kakurk/memolab-fmri-qa","homepage":null,"size":31,"stargazers_count":0,"watchers_count":0,"language":"Matlab","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"memobc:master","ref":"master","sha":"f81b265fd54c5f782e61f96df524991155109e76","user":{"login":"memobc","id":15903870,"avatar_url":"https://avatars0.githubusercontent.com/u/15903870?v=3","gravatar_id":"","url":"https://api.github.com/users/memobc","html_url":"https://github.com/memobc","followers_url":"https://api.github.com/users/memobc/followers","following_url":"https://api.github.com/users/memobc/following{/other_user}","gists_url":"https://api.github.com/users/memobc/gists{/gist_id}","starred_url":"https://api.github.com/users/memobc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/memobc/subscriptions","organizations_url":"https://api.github.com/users/memobc/orgs","repos_url":"https://api.github.com/users/memobc/repos","events_url":"https://api.github.com/users/memobc/events{/privacy}","received_events_url":"https://api.github.com/users/memobc/received_events","type":"Organization","site_admin":false},"repo":{"id":79938597,"name":"memolab-fmri-qa","full_name":"memobc/memolab-fmri-qa","owner":{"login":"memobc","id":15903870,"avatar_url":"https://avatars0.githubusercontent.com/u/15903870?v=3","gravatar_id":"","url":"https://api.github.com/users/memobc","html_url":"https://github.com/memobc","followers_url":"https://api.github.com/users/memobc/followers","following_url":"https://api.github.com/users/memobc/following{/other_user}","gists_url":"https://api.github.com/users/memobc/gists{/gist_id}","starred_url":"https://api.github.com/users/memobc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/memobc/subscriptions","organizations_url":"https://api.github.com/users/memobc/orgs","repos_url":"https://api.github.com/users/memobc/repos","events_url":"https://api.github.com/users/memobc/events{/privacy}","received_events_url":"https://api.github.com/users/memobc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/memobc/memolab-fmri-qa","description":"Scripts for doing general QA on fMRI data, including ArtRepair","fork":false,"url":"https://api.github.com/repos/memobc/memolab-fmri-qa","forks_url":"https://api.github.com/repos/memobc/memolab-fmri-qa/forks","keys_url":"https://api.github.com/repos/memobc/memolab-fmri-qa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/memobc/memolab-fmri-qa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/memobc/memolab-fmri-qa/teams","hooks_url":"https://api.github.com/repos/memobc/memolab-fmri-qa/hooks","issue_events_url":"https://api.github.com/repos/memobc/memolab-fmri-qa/issues/events{/number}","events_url":"https://api.github.com/repos/memobc/memolab-fmri-qa/events","assignees_url":"https://api.github.com/repos/memobc/memolab-fmri-qa/assignees{/user}","branches_url":"https://api.github.com/repos/memobc/memolab-fmri-qa/branches{/branch}","tags_url":"https://api.github.com/repos/memobc/memolab-fmri-qa/tags","blobs_url":"https://api.github.com/repos/memobc/memolab-fmri-qa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/memobc/memolab-fmri-qa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/memobc/memolab-fmri-qa/git/refs{/sha}","trees_url":"https://api.github.com/repos/memobc/memolab-fmri-qa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/memobc/memolab-fmri-qa/statuses/{sha}","languages_url":"https://api.github.com/repos/memobc/memolab-fmri-qa/languages","stargazers_url":"https://api.github.com/repos/memobc/memolab-fmri-qa/stargazers","contributors_url":"https://api.github.com/repos/memobc/memolab-fmri-qa/contributors","subscribers_url":"https://api.github.com/repos/memobc/memolab-fmri-qa/subscribers","subscription_url":"https://api.github.com/repos/memobc/memolab-fmri-qa/subscription","commits_url":"https://api.github.com/repos/memobc/memolab-fmri-qa/commits{/sha}","git_commits_url":"https://api.github.com/repos/memobc/memolab-fmri-qa/git/commits{/sha}","comments_url":"https://api.github.com/repos/memobc/memolab-fmri-qa/comments{/number}","issue_comment_url":"https://api.github.com/repos/memobc/memolab-fmri-qa/issues/comments{/number}","contents_url":"https://api.github.com/repos/memobc/memolab-fmri-qa/contents/{+path}","compare_url":"https://api.github.com/repos/memobc/memolab-fmri-qa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/memobc/memolab-fmri-qa/merges","archive_url":"https://api.github.com/repos/memobc/memolab-fmri-qa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/memobc/memolab-fmri-qa/downloads","issues_url":"https://api.github.com/repos/memobc/memolab-fmri-qa/issues{/number}","pulls_url":"https://api.github.com/repos/memobc/memolab-fmri-qa/pulls{/number}","milestones_url":"https://api.github.com/repos/memobc/memolab-fmri-qa/milestones{/number}","notifications_url":"https://api.github.com/repos/memobc/memolab-fmri-qa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/memobc/memolab-fmri-qa/labels{/name}","releases_url":"https://api.github.com/repos/memobc/memolab-fmri-qa/releases{/id}","deployments_url":"https://api.github.com/repos/memobc/memolab-fmri-qa/deployments","created_at":"2017-01-24T18:04:22Z","updated_at":"2017-01-24T19:40:04Z","pushed_at":"2017-01-24T18:07:43Z","git_url":"git://github.com/memobc/memolab-fmri-qa.git","ssh_url":"git@github.com:memobc/memolab-fmri-qa.git","clone_url":"https://github.com/memobc/memolab-fmri-qa.git","svn_url":"https://github.com/memobc/memolab-fmri-qa","homepage":null,"size":31,"stargazers_count":1,"watchers_count":1,"language":"Matlab","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/memobc/memolab-fmri-qa/pulls/1"},"html":{"href":"https://github.com/memobc/memolab-fmri-qa/pull/1"},"issue":{"href":"https://api.github.com/repos/memobc/memolab-fmri-qa/issues/1"},"comments":{"href":"https://api.github.com/repos/memobc/memolab-fmri-qa/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/memobc/memolab-fmri-qa/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/memobc/memolab-fmri-qa/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/memobc/memolab-fmri-qa/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/memobc/memolab-fmri-qa/statuses/3421247a0b0f4c674fd0bec49d37f3e40c5bab55"}},"merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":13,"deletions":13,"changed_files":5}}
{"actor":{"display_login":"kakurk"}}