{"action":"created","issue":{"url":"https://api.github.com/repos/libtom/libtomcrypt/issues/227","repository_url":"https://api.github.com/repos/libtom/libtomcrypt","labels_url":"https://api.github.com/repos/libtom/libtomcrypt/issues/227/labels{/name}","comments_url":"https://api.github.com/repos/libtom/libtomcrypt/issues/227/comments","events_url":"https://api.github.com/repos/libtom/libtomcrypt/issues/227/events","html_url":"https://github.com/libtom/libtomcrypt/pull/227","id":235358871,"number":227,"title":"DH add dh_make_key_ex & co.","user":{"login":"karel-m","id":1918753,"avatar_url":"https://avatars1.githubusercontent.com/u/1918753?v=3","gravatar_id":"","url":"https://api.github.com/users/karel-m","html_url":"https://github.com/karel-m","followers_url":"https://api.github.com/users/karel-m/followers","following_url":"https://api.github.com/users/karel-m/following{/other_user}","gists_url":"https://api.github.com/users/karel-m/gists{/gist_id}","starred_url":"https://api.github.com/users/karel-m/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karel-m/subscriptions","organizations_url":"https://api.github.com/users/karel-m/orgs","repos_url":"https://api.github.com/users/karel-m/repos","events_url":"https://api.github.com/users/karel-m/events{/privacy}","received_events_url":"https://api.github.com/users/karel-m/received_events","type":"User","site_admin":false},"labels":[{"id":621636778,"url":"https://api.github.com/repos/libtom/libtomcrypt/labels/enhancement","name":"enhancement","color":"c2e0c6","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/libtom/libtomcrypt/milestones/1","html_url":"https://github.com/libtom/libtomcrypt/milestone/1","labels_url":"https://api.github.com/repos/libtom/libtomcrypt/milestones/1/labels","id":370469,"number":1,"title":"v1.18.0","description":"","creator":{"login":"sjaeckel","id":294374,"avatar_url":"https://avatars1.githubusercontent.com/u/294374?v=3","gravatar_id":"","url":"https://api.github.com/users/sjaeckel","html_url":"https://github.com/sjaeckel","followers_url":"https://api.github.com/users/sjaeckel/followers","following_url":"https://api.github.com/users/sjaeckel/following{/other_user}","gists_url":"https://api.github.com/users/sjaeckel/gists{/gist_id}","starred_url":"https://api.github.com/users/sjaeckel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjaeckel/subscriptions","organizations_url":"https://api.github.com/users/sjaeckel/orgs","repos_url":"https://api.github.com/users/sjaeckel/repos","events_url":"https://api.github.com/users/sjaeckel/events{/privacy}","received_events_url":"https://api.github.com/users/sjaeckel/received_events","type":"User","site_admin":false},"open_issues":10,"closed_issues":110,"state":"open","created_at":"2013-07-04T11:54:15Z","updated_at":"2017-06-14T07:38:07Z","due_on":"2017-07-20T07:00:00Z","closed_at":null},"comments":12,"created_at":"2017-06-12T20:41:03Z","updated_at":"2017-06-16T15:21:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/libtom/libtomcrypt/pulls/227","html_url":"https://github.com/libtom/libtomcrypt/pull/227","diff_url":"https://github.com/libtom/libtomcrypt/pull/227.diff","patch_url":"https://github.com/libtom/libtomcrypt/pull/227.patch"},"body":"The idea of `dh_make_key_ex` (which allows using custom DH group params) was suggested and implemented by @lkinley as a contribution to my libtomcrypt perl bindings.\r\n\r\nIt is simply about adding:\r\n```C\r\nint dh_make_key_ex(prng_state *prng, int wprng, char *prime_hex, char *base_hex, dh_key *key)\r\n```\r\n\r\nUnfortunately the implementation turned into a bunch of troubles&workarounds like changes to dh_key structure changes (incompatible) to import/export format etc.\r\n\r\nSome questions:\r\n* How far can we go in breaking DH API? (currently only in develop for some time, not released yet)\r\n* Is the format used for DH key export/import intended to compatible with some specification? (this PR changed it in an incompatible way)\r\n"},"comment":{"url":"https://api.github.com/repos/libtom/libtomcrypt/issues/comments/309055135","html_url":"https://github.com/libtom/libtomcrypt/pull/227#issuecomment-309055135","issue_url":"https://api.github.com/repos/libtom/libtomcrypt/issues/227","id":309055135,"user":{"login":"lkinley","id":2348464,"avatar_url":"https://avatars1.githubusercontent.com/u/2348464?v=3","gravatar_id":"","url":"https://api.github.com/users/lkinley","html_url":"https://github.com/lkinley","followers_url":"https://api.github.com/users/lkinley/followers","following_url":"https://api.github.com/users/lkinley/following{/other_user}","gists_url":"https://api.github.com/users/lkinley/gists{/gist_id}","starred_url":"https://api.github.com/users/lkinley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lkinley/subscriptions","organizations_url":"https://api.github.com/users/lkinley/orgs","repos_url":"https://api.github.com/users/lkinley/repos","events_url":"https://api.github.com/users/lkinley/events{/privacy}","received_events_url":"https://api.github.com/users/lkinley/received_events","type":"User","site_admin":false},"created_at":"2017-06-16T15:21:39Z","updated_at":"2017-06-16T15:21:39Z","body":"Yes, I believe the pub key validity is checked on import."}}
{"actor":{"display_login":"lkinley"}}