{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/beats/pulls/comments/128770297","pull_request_review_id":51484128,"id":128770297,"diff_hunk":"@@ -63,9 +63,9 @@ metricbeat.modules:\n   #maxconn: 10\n \n   # Filters can be used to reduce the number of fields sent.\n-  #filters:\n+  #processors:\n   #  - include_fields:\n-  #      fields: [\"stats\"]\n+  #      fields: [\"beat\", \"metricset\", \"redis.info.stats\"]","path":"metricbeat/docs/modules/redis.asciidoc","position":8,"original_position":8,"commit_id":"f056919b9e6c35013fbce87b486958d27856a2f2","original_commit_id":"f056919b9e6c35013fbce87b486958d27856a2f2","user":{"login":"urso","id":75886,"avatar_url":"https://avatars1.githubusercontent.com/u/75886?v=4","gravatar_id":"","url":"https://api.github.com/users/urso","html_url":"https://github.com/urso","followers_url":"https://api.github.com/users/urso/followers","following_url":"https://api.github.com/users/urso/following{/other_user}","gists_url":"https://api.github.com/users/urso/gists{/gist_id}","starred_url":"https://api.github.com/users/urso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/urso/subscriptions","organizations_url":"https://api.github.com/users/urso/orgs","repos_url":"https://api.github.com/users/urso/repos","events_url":"https://api.github.com/users/urso/events{/privacy}","received_events_url":"https://api.github.com/users/urso/received_events","type":"User","site_admin":false},"body":"Right. This is what I'm saying. That's why I'm considering the changes to metricbeat and processors order in the publisher. Maybe we also want to introduce some whitelisting (fields that can not be removed).","created_at":"2017-07-21T14:08:49Z","updated_at":"2017-07-21T14:08:49Z","html_url":"https://github.com/elastic/beats/pull/4726#discussion_r128770297","pull_request_url":"https://api.github.com/repos/elastic/beats/pulls/4726","_links":{"self":{"href":"https://api.github.com/repos/elastic/beats/pulls/comments/128770297"},"html":{"href":"https://github.com/elastic/beats/pull/4726#discussion_r128770297"},"pull_request":{"href":"https://api.github.com/repos/elastic/beats/pulls/4726"}}},"pull_request":{"url":"https://api.github.com/repos/elastic/beats/pulls/4726","id":131655859,"html_url":"https://github.com/elastic/beats/pull/4726","diff_url":"https://github.com/elastic/beats/pull/4726.diff","patch_url":"https://github.com/elastic/beats/pull/4726.patch","issue_url":"https://api.github.com/repos/elastic/beats/issues/4726","number":4726,"state":"open","locked":false,"title":"Check for removed settings on startup","user":{"login":"urso","id":75886,"avatar_url":"https://avatars1.githubusercontent.com/u/75886?v=4","gravatar_id":"","url":"https://api.github.com/users/urso","html_url":"https://github.com/urso","followers_url":"https://api.github.com/users/urso/followers","following_url":"https://api.github.com/users/urso/following{/other_user}","gists_url":"https://api.github.com/users/urso/gists{/gist_id}","starred_url":"https://api.github.com/users/urso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/urso/subscriptions","organizations_url":"https://api.github.com/users/urso/orgs","repos_url":"https://api.github.com/users/urso/repos","events_url":"https://api.github.com/users/urso/events{/privacy}","received_events_url":"https://api.github.com/users/urso/received_events","type":"User","site_admin":false},"body":"- Introduce cfgwarn package\r\n- move Beta/Deprecated/Experimental to from `logp` to `cfgwarn`\r\n- introduce CheckRemoved5xSettings looking for removed settings in a config object + constructs an error message with completely expanded setting name\r\n- use CheckRemoved5xSettigns in libbeat/filebeat/metricbeat to fail on startup if any settings removed by publisher refactoring is used\r\n- Add system tests for libbeat/filebeat/metricbeat checking removed settings are correctly identified.","created_at":"2017-07-20T21:37:52Z","updated_at":"2017-07-21T14:08:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"91196d7b4b9696f5df747f869e52b96646b64a1b","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/beats/pulls/4726/commits","review_comments_url":"https://api.github.com/repos/elastic/beats/pulls/4726/comments","review_comment_url":"https://api.github.com/repos/elastic/beats/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/beats/issues/4726/comments","statuses_url":"https://api.github.com/repos/elastic/beats/statuses/f056919b9e6c35013fbce87b486958d27856a2f2","head":{"label":"urso:enh/warn-removed-cfg","ref":"enh/warn-removed-cfg","sha":"f056919b9e6c35013fbce87b486958d27856a2f2","user":{"login":"urso","id":75886,"avatar_url":"https://avatars1.githubusercontent.com/u/75886?v=4","gravatar_id":"","url":"https://api.github.com/users/urso","html_url":"https://github.com/urso","followers_url":"https://api.github.com/users/urso/followers","following_url":"https://api.github.com/users/urso/following{/other_user}","gists_url":"https://api.github.com/users/urso/gists{/gist_id}","starred_url":"https://api.github.com/users/urso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/urso/subscriptions","organizations_url":"https://api.github.com/users/urso/orgs","repos_url":"https://api.github.com/users/urso/repos","events_url":"https://api.github.com/users/urso/events{/privacy}","received_events_url":"https://api.github.com/users/urso/received_events","type":"User","site_admin":false},"repo":{"id":40138298,"name":"beats","full_name":"urso/beats","owner":{"login":"urso","id":75886,"avatar_url":"https://avatars1.githubusercontent.com/u/75886?v=4","gravatar_id":"","url":"https://api.github.com/users/urso","html_url":"https://github.com/urso","followers_url":"https://api.github.com/users/urso/followers","following_url":"https://api.github.com/users/urso/following{/other_user}","gists_url":"https://api.github.com/users/urso/gists{/gist_id}","starred_url":"https://api.github.com/users/urso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/urso/subscriptions","organizations_url":"https://api.github.com/users/urso/orgs","repos_url":"https://api.github.com/users/urso/repos","events_url":"https://api.github.com/users/urso/events{/privacy}","received_events_url":"https://api.github.com/users/urso/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/urso/beats","description":"Open Source Real-Time Packet Analyzer","fork":true,"url":"https://api.github.com/repos/urso/beats","forks_url":"https://api.github.com/repos/urso/beats/forks","keys_url":"https://api.github.com/repos/urso/beats/keys{/key_id}","collaborators_url":"https://api.github.com/repos/urso/beats/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/urso/beats/teams","hooks_url":"https://api.github.com/repos/urso/beats/hooks","issue_events_url":"https://api.github.com/repos/urso/beats/issues/events{/number}","events_url":"https://api.github.com/repos/urso/beats/events","assignees_url":"https://api.github.com/repos/urso/beats/assignees{/user}","branches_url":"https://api.github.com/repos/urso/beats/branches{/branch}","tags_url":"https://api.github.com/repos/urso/beats/tags","blobs_url":"https://api.github.com/repos/urso/beats/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/urso/beats/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/urso/beats/git/refs{/sha}","trees_url":"https://api.github.com/repos/urso/beats/git/trees{/sha}","statuses_url":"https://api.github.com/repos/urso/beats/statuses/{sha}","languages_url":"https://api.github.com/repos/urso/beats/languages","stargazers_url":"https://api.github.com/repos/urso/beats/stargazers","contributors_url":"https://api.github.com/repos/urso/beats/contributors","subscribers_url":"https://api.github.com/repos/urso/beats/subscribers","subscription_url":"https://api.github.com/repos/urso/beats/subscription","commits_url":"https://api.github.com/repos/urso/beats/commits{/sha}","git_commits_url":"https://api.github.com/repos/urso/beats/git/commits{/sha}","comments_url":"https://api.github.com/repos/urso/beats/comments{/number}","issue_comment_url":"https://api.github.com/repos/urso/beats/issues/comments{/number}","contents_url":"https://api.github.com/repos/urso/beats/contents/{+path}","compare_url":"https://api.github.com/repos/urso/beats/compare/{base}...{head}","merges_url":"https://api.github.com/repos/urso/beats/merges","archive_url":"https://api.github.com/repos/urso/beats/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/urso/beats/downloads","issues_url":"https://api.github.com/repos/urso/beats/issues{/number}","pulls_url":"https://api.github.com/repos/urso/beats/pulls{/number}","milestones_url":"https://api.github.com/repos/urso/beats/milestones{/number}","notifications_url":"https://api.github.com/repos/urso/beats/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/urso/beats/labels{/name}","releases_url":"https://api.github.com/repos/urso/beats/releases{/id}","deployments_url":"https://api.github.com/repos/urso/beats/deployments","created_at":"2015-08-03T17:25:21Z","updated_at":"2016-10-28T12:16:33Z","pushed_at":"2017-07-21T13:26:28Z","git_url":"git://github.com/urso/beats.git","ssh_url":"git@github.com:urso/beats.git","clone_url":"https://github.com/urso/beats.git","svn_url":"https://github.com/urso/beats","homepage":"https://www.elastic.co/products/beats/packetbeat","size":57234,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"c1bd89b3b7d5d01fb676d37c4d98fe498585caf7","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":16554739,"name":"beats","full_name":"elastic/beats","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/beats","description":":tropical_fish: Beats - Lightweight shippers for Elasticsearch & Logstash ","fork":false,"url":"https://api.github.com/repos/elastic/beats","forks_url":"https://api.github.com/repos/elastic/beats/forks","keys_url":"https://api.github.com/repos/elastic/beats/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/beats/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/beats/teams","hooks_url":"https://api.github.com/repos/elastic/beats/hooks","issue_events_url":"https://api.github.com/repos/elastic/beats/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/beats/events","assignees_url":"https://api.github.com/repos/elastic/beats/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/beats/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/beats/tags","blobs_url":"https://api.github.com/repos/elastic/beats/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/beats/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/beats/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/beats/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/beats/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/beats/languages","stargazers_url":"https://api.github.com/repos/elastic/beats/stargazers","contributors_url":"https://api.github.com/repos/elastic/beats/contributors","subscribers_url":"https://api.github.com/repos/elastic/beats/subscribers","subscription_url":"https://api.github.com/repos/elastic/beats/subscription","commits_url":"https://api.github.com/repos/elastic/beats/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/beats/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/beats/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/beats/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/beats/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/beats/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/beats/merges","archive_url":"https://api.github.com/repos/elastic/beats/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/beats/downloads","issues_url":"https://api.github.com/repos/elastic/beats/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/beats/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/beats/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/beats/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/beats/labels{/name}","releases_url":"https://api.github.com/repos/elastic/beats/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/beats/deployments","created_at":"2014-02-05T19:01:02Z","updated_at":"2017-07-21T09:55:12Z","pushed_at":"2017-07-21T13:26:30Z","git_url":"git://github.com/elastic/beats.git","ssh_url":"git@github.com:elastic/beats.git","clone_url":"https://github.com/elastic/beats.git","svn_url":"https://github.com/elastic/beats","homepage":"https://www.elastic.co/products/beats","size":57949,"stargazers_count":4239,"watchers_count":4239,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1080,"mirror_url":null,"open_issues_count":489,"forks":1080,"open_issues":489,"watchers":4239,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/beats/pulls/4726"},"html":{"href":"https://github.com/elastic/beats/pull/4726"},"issue":{"href":"https://api.github.com/repos/elastic/beats/issues/4726"},"comments":{"href":"https://api.github.com/repos/elastic/beats/issues/4726/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/beats/pulls/4726/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/beats/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/beats/pulls/4726/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/beats/statuses/f056919b9e6c35013fbce87b486958d27856a2f2"}}}}
{"actor":{"display_login":"urso"}}