{"action":"created","comment":{"url":"https://api.github.com/repos/PHP-DI/PHP-DI/pulls/comments/148338807","pull_request_review_id":73565636,"id":148338807,"diff_hunk":"@@ -49,6 +49,13 @@ class Container implements ContainerInterface, InteropContainerInterface, Factor\n     private $definitionResolver;\n \n     /**\n+     * Map of definitions that are already fetched / looked up.\n+     *\n+     * @var array\n+     */\n+    private $fetchedDefinitions = [];","path":"src/DI/Container.php","position":8,"original_position":8,"commit_id":"a27e3409532bdcdd810226792b9ee50d29e749cd","original_commit_id":"a27e3409532bdcdd810226792b9ee50d29e749cd","user":{"login":"holtkamp","id":776405,"avatar_url":"https://avatars3.githubusercontent.com/u/776405?v=4","gravatar_id":"","url":"https://api.github.com/users/holtkamp","html_url":"https://github.com/holtkamp","followers_url":"https://api.github.com/users/holtkamp/followers","following_url":"https://api.github.com/users/holtkamp/following{/other_user}","gists_url":"https://api.github.com/users/holtkamp/gists{/gist_id}","starred_url":"https://api.github.com/users/holtkamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holtkamp/subscriptions","organizations_url":"https://api.github.com/users/holtkamp/orgs","repos_url":"https://api.github.com/users/holtkamp/repos","events_url":"https://api.github.com/users/holtkamp/events{/privacy}","received_events_url":"https://api.github.com/users/holtkamp/received_events","type":"User","site_admin":false},"body":"yeah, I considered `resolvedDefinitions` as well, but the rest of the code kind of uses 'resolving' for 'resolving a value from a definition'. \r\n\r\n`definitionCache` could be candidate... @mnapoli ?","created_at":"2017-11-01T18:07:51Z","updated_at":"2017-11-01T18:07:51Z","html_url":"https://github.com/PHP-DI/PHP-DI/pull/533#discussion_r148338807","pull_request_url":"https://api.github.com/repos/PHP-DI/PHP-DI/pulls/533","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/PHP-DI/PHP-DI/pulls/comments/148338807"},"html":{"href":"https://github.com/PHP-DI/PHP-DI/pull/533#discussion_r148338807"},"pull_request":{"href":"https://api.github.com/repos/PHP-DI/PHP-DI/pulls/533"}},"in_reply_to_id":148321684},"pull_request":{"url":"https://api.github.com/repos/PHP-DI/PHP-DI/pulls/533","id":149603539,"html_url":"https://github.com/PHP-DI/PHP-DI/pull/533","diff_url":"https://github.com/PHP-DI/PHP-DI/pull/533.diff","patch_url":"https://github.com/PHP-DI/PHP-DI/pull/533.patch","issue_url":"https://api.github.com/repos/PHP-DI/PHP-DI/issues/533","number":533,"state":"open","locked":false,"title":"Container::getDefinition() which uses a local cache","user":{"login":"holtkamp","id":776405,"avatar_url":"https://avatars3.githubusercontent.com/u/776405?v=4","gravatar_id":"","url":"https://api.github.com/users/holtkamp","html_url":"https://github.com/holtkamp","followers_url":"https://api.github.com/users/holtkamp/followers","following_url":"https://api.github.com/users/holtkamp/following{/other_user}","gists_url":"https://api.github.com/users/holtkamp/gists{/gist_id}","starred_url":"https://api.github.com/users/holtkamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holtkamp/subscriptions","organizations_url":"https://api.github.com/users/holtkamp/orgs","repos_url":"https://api.github.com/users/holtkamp/repos","events_url":"https://api.github.com/users/holtkamp/events{/privacy}","received_events_url":"https://api.github.com/users/holtkamp/received_events","type":"User","site_admin":false},"body":"As suggested in https://github.com/PHP-DI/PHP-DI/issues/531","created_at":"2017-10-30T18:35:34Z","updated_at":"2017-11-01T18:07:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0a6425a86ee22aee9dca01698d3b2efaa5159e9b","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/PHP-DI/PHP-DI/pulls/533/commits","review_comments_url":"https://api.github.com/repos/PHP-DI/PHP-DI/pulls/533/comments","review_comment_url":"https://api.github.com/repos/PHP-DI/PHP-DI/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PHP-DI/PHP-DI/issues/533/comments","statuses_url":"https://api.github.com/repos/PHP-DI/PHP-DI/statuses/a27e3409532bdcdd810226792b9ee50d29e749cd","head":{"label":"holtkamp:patch-54-optimize-container-definition-lookup","ref":"patch-54-optimize-container-definition-lookup","sha":"a27e3409532bdcdd810226792b9ee50d29e749cd","user":{"login":"holtkamp","id":776405,"avatar_url":"https://avatars3.githubusercontent.com/u/776405?v=4","gravatar_id":"","url":"https://api.github.com/users/holtkamp","html_url":"https://github.com/holtkamp","followers_url":"https://api.github.com/users/holtkamp/followers","following_url":"https://api.github.com/users/holtkamp/following{/other_user}","gists_url":"https://api.github.com/users/holtkamp/gists{/gist_id}","starred_url":"https://api.github.com/users/holtkamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holtkamp/subscriptions","organizations_url":"https://api.github.com/users/holtkamp/orgs","repos_url":"https://api.github.com/users/holtkamp/repos","events_url":"https://api.github.com/users/holtkamp/events{/privacy}","received_events_url":"https://api.github.com/users/holtkamp/received_events","type":"User","site_admin":false},"repo":{"id":59367267,"name":"PHP-DI","full_name":"holtkamp/PHP-DI","owner":{"login":"holtkamp","id":776405,"avatar_url":"https://avatars3.githubusercontent.com/u/776405?v=4","gravatar_id":"","url":"https://api.github.com/users/holtkamp","html_url":"https://github.com/holtkamp","followers_url":"https://api.github.com/users/holtkamp/followers","following_url":"https://api.github.com/users/holtkamp/following{/other_user}","gists_url":"https://api.github.com/users/holtkamp/gists{/gist_id}","starred_url":"https://api.github.com/users/holtkamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holtkamp/subscriptions","organizations_url":"https://api.github.com/users/holtkamp/orgs","repos_url":"https://api.github.com/users/holtkamp/repos","events_url":"https://api.github.com/users/holtkamp/events{/privacy}","received_events_url":"https://api.github.com/users/holtkamp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/holtkamp/PHP-DI","description":"The dependency injection container for humans","fork":true,"url":"https://api.github.com/repos/holtkamp/PHP-DI","forks_url":"https://api.github.com/repos/holtkamp/PHP-DI/forks","keys_url":"https://api.github.com/repos/holtkamp/PHP-DI/keys{/key_id}","collaborators_url":"https://api.github.com/repos/holtkamp/PHP-DI/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/holtkamp/PHP-DI/teams","hooks_url":"https://api.github.com/repos/holtkamp/PHP-DI/hooks","issue_events_url":"https://api.github.com/repos/holtkamp/PHP-DI/issues/events{/number}","events_url":"https://api.github.com/repos/holtkamp/PHP-DI/events","assignees_url":"https://api.github.com/repos/holtkamp/PHP-DI/assignees{/user}","branches_url":"https://api.github.com/repos/holtkamp/PHP-DI/branches{/branch}","tags_url":"https://api.github.com/repos/holtkamp/PHP-DI/tags","blobs_url":"https://api.github.com/repos/holtkamp/PHP-DI/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/holtkamp/PHP-DI/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/holtkamp/PHP-DI/git/refs{/sha}","trees_url":"https://api.github.com/repos/holtkamp/PHP-DI/git/trees{/sha}","statuses_url":"https://api.github.com/repos/holtkamp/PHP-DI/statuses/{sha}","languages_url":"https://api.github.com/repos/holtkamp/PHP-DI/languages","stargazers_url":"https://api.github.com/repos/holtkamp/PHP-DI/stargazers","contributors_url":"https://api.github.com/repos/holtkamp/PHP-DI/contributors","subscribers_url":"https://api.github.com/repos/holtkamp/PHP-DI/subscribers","subscription_url":"https://api.github.com/repos/holtkamp/PHP-DI/subscription","commits_url":"https://api.github.com/repos/holtkamp/PHP-DI/commits{/sha}","git_commits_url":"https://api.github.com/repos/holtkamp/PHP-DI/git/commits{/sha}","comments_url":"https://api.github.com/repos/holtkamp/PHP-DI/comments{/number}","issue_comment_url":"https://api.github.com/repos/holtkamp/PHP-DI/issues/comments{/number}","contents_url":"https://api.github.com/repos/holtkamp/PHP-DI/contents/{+path}","compare_url":"https://api.github.com/repos/holtkamp/PHP-DI/compare/{base}...{head}","merges_url":"https://api.github.com/repos/holtkamp/PHP-DI/merges","archive_url":"https://api.github.com/repos/holtkamp/PHP-DI/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/holtkamp/PHP-DI/downloads","issues_url":"https://api.github.com/repos/holtkamp/PHP-DI/issues{/number}","pulls_url":"https://api.github.com/repos/holtkamp/PHP-DI/pulls{/number}","milestones_url":"https://api.github.com/repos/holtkamp/PHP-DI/milestones{/number}","notifications_url":"https://api.github.com/repos/holtkamp/PHP-DI/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/holtkamp/PHP-DI/labels{/name}","releases_url":"https://api.github.com/repos/holtkamp/PHP-DI/releases{/id}","deployments_url":"https://api.github.com/repos/holtkamp/PHP-DI/deployments","created_at":"2016-05-21T15:29:50Z","updated_at":"2016-05-21T15:29:51Z","pushed_at":"2017-10-31T14:58:23Z","git_url":"git://github.com/holtkamp/PHP-DI.git","ssh_url":"git@github.com:holtkamp/PHP-DI.git","clone_url":"https://github.com/holtkamp/PHP-DI.git","svn_url":"https://github.com/holtkamp/PHP-DI","homepage":"php-di.org","size":40857,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PHP-DI:5.4","ref":"5.4","sha":"8ecded470bb0255c93f2996f78bb3b644c06599a","user":{"login":"PHP-DI","id":7814911,"avatar_url":"https://avatars3.githubusercontent.com/u/7814911?v=4","gravatar_id":"","url":"https://api.github.com/users/PHP-DI","html_url":"https://github.com/PHP-DI","followers_url":"https://api.github.com/users/PHP-DI/followers","following_url":"https://api.github.com/users/PHP-DI/following{/other_user}","gists_url":"https://api.github.com/users/PHP-DI/gists{/gist_id}","starred_url":"https://api.github.com/users/PHP-DI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PHP-DI/subscriptions","organizations_url":"https://api.github.com/users/PHP-DI/orgs","repos_url":"https://api.github.com/users/PHP-DI/repos","events_url":"https://api.github.com/users/PHP-DI/events{/privacy}","received_events_url":"https://api.github.com/users/PHP-DI/received_events","type":"Organization","site_admin":false},"repo":{"id":3751713,"name":"PHP-DI","full_name":"PHP-DI/PHP-DI","owner":{"login":"PHP-DI","id":7814911,"avatar_url":"https://avatars3.githubusercontent.com/u/7814911?v=4","gravatar_id":"","url":"https://api.github.com/users/PHP-DI","html_url":"https://github.com/PHP-DI","followers_url":"https://api.github.com/users/PHP-DI/followers","following_url":"https://api.github.com/users/PHP-DI/following{/other_user}","gists_url":"https://api.github.com/users/PHP-DI/gists{/gist_id}","starred_url":"https://api.github.com/users/PHP-DI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PHP-DI/subscriptions","organizations_url":"https://api.github.com/users/PHP-DI/orgs","repos_url":"https://api.github.com/users/PHP-DI/repos","events_url":"https://api.github.com/users/PHP-DI/events{/privacy}","received_events_url":"https://api.github.com/users/PHP-DI/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PHP-DI/PHP-DI","description":"The dependency injection container for humans","fork":false,"url":"https://api.github.com/repos/PHP-DI/PHP-DI","forks_url":"https://api.github.com/repos/PHP-DI/PHP-DI/forks","keys_url":"https://api.github.com/repos/PHP-DI/PHP-DI/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PHP-DI/PHP-DI/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PHP-DI/PHP-DI/teams","hooks_url":"https://api.github.com/repos/PHP-DI/PHP-DI/hooks","issue_events_url":"https://api.github.com/repos/PHP-DI/PHP-DI/issues/events{/number}","events_url":"https://api.github.com/repos/PHP-DI/PHP-DI/events","assignees_url":"https://api.github.com/repos/PHP-DI/PHP-DI/assignees{/user}","branches_url":"https://api.github.com/repos/PHP-DI/PHP-DI/branches{/branch}","tags_url":"https://api.github.com/repos/PHP-DI/PHP-DI/tags","blobs_url":"https://api.github.com/repos/PHP-DI/PHP-DI/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PHP-DI/PHP-DI/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PHP-DI/PHP-DI/git/refs{/sha}","trees_url":"https://api.github.com/repos/PHP-DI/PHP-DI/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PHP-DI/PHP-DI/statuses/{sha}","languages_url":"https://api.github.com/repos/PHP-DI/PHP-DI/languages","stargazers_url":"https://api.github.com/repos/PHP-DI/PHP-DI/stargazers","contributors_url":"https://api.github.com/repos/PHP-DI/PHP-DI/contributors","subscribers_url":"https://api.github.com/repos/PHP-DI/PHP-DI/subscribers","subscription_url":"https://api.github.com/repos/PHP-DI/PHP-DI/subscription","commits_url":"https://api.github.com/repos/PHP-DI/PHP-DI/commits{/sha}","git_commits_url":"https://api.github.com/repos/PHP-DI/PHP-DI/git/commits{/sha}","comments_url":"https://api.github.com/repos/PHP-DI/PHP-DI/comments{/number}","issue_comment_url":"https://api.github.com/repos/PHP-DI/PHP-DI/issues/comments{/number}","contents_url":"https://api.github.com/repos/PHP-DI/PHP-DI/contents/{+path}","compare_url":"https://api.github.com/repos/PHP-DI/PHP-DI/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PHP-DI/PHP-DI/merges","archive_url":"https://api.github.com/repos/PHP-DI/PHP-DI/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PHP-DI/PHP-DI/downloads","issues_url":"https://api.github.com/repos/PHP-DI/PHP-DI/issues{/number}","pulls_url":"https://api.github.com/repos/PHP-DI/PHP-DI/pulls{/number}","milestones_url":"https://api.github.com/repos/PHP-DI/PHP-DI/milestones{/number}","notifications_url":"https://api.github.com/repos/PHP-DI/PHP-DI/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PHP-DI/PHP-DI/labels{/name}","releases_url":"https://api.github.com/repos/PHP-DI/PHP-DI/releases{/id}","deployments_url":"https://api.github.com/repos/PHP-DI/PHP-DI/deployments","created_at":"2012-03-17T23:59:36Z","updated_at":"2017-11-01T10:01:57Z","pushed_at":"2017-10-31T23:29:48Z","git_url":"git://github.com/PHP-DI/PHP-DI.git","ssh_url":"git@github.com:PHP-DI/PHP-DI.git","clone_url":"https://github.com/PHP-DI/PHP-DI.git","svn_url":"https://github.com/PHP-DI/PHP-DI","homepage":"php-di.org","size":40904,"stargazers_count":1115,"watchers_count":1115,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":166,"mirror_url":null,"archived":false,"open_issues_count":20,"forks":166,"open_issues":20,"watchers":1115,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PHP-DI/PHP-DI/pulls/533"},"html":{"href":"https://github.com/PHP-DI/PHP-DI/pull/533"},"issue":{"href":"https://api.github.com/repos/PHP-DI/PHP-DI/issues/533"},"comments":{"href":"https://api.github.com/repos/PHP-DI/PHP-DI/issues/533/comments"},"review_comments":{"href":"https://api.github.com/repos/PHP-DI/PHP-DI/pulls/533/comments"},"review_comment":{"href":"https://api.github.com/repos/PHP-DI/PHP-DI/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PHP-DI/PHP-DI/pulls/533/commits"},"statuses":{"href":"https://api.github.com/repos/PHP-DI/PHP-DI/statuses/a27e3409532bdcdd810226792b9ee50d29e749cd"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"holtkamp"}}