{"action":"created","comment":{"url":"https://api.github.com/repos/octobercms/october/pulls/comments/105452312","pull_request_review_id":26337711,"id":105452312,"diff_hunk":"@@ -18,4 +18,16 @@ Allows keyboard shortcuts (hotkeys) to be bound to an element's click event.\n         Press \"Shift + R\" on your keyboard\n     </button>\n \n+## Javascript API\n \n+If you use a selector other than a button or a link, you will need to add the `hotkeyVisible` property to the hotkey config.\n+\n+```html","path":"modules/system/assets/ui/docs/input-hotkey.md","position":8,"original_position":8,"commit_id":"1ca0b2526536b3d8ebc181d0ae22b20601ff4f1b","original_commit_id":"1ca0b2526536b3d8ebc181d0ae22b20601ff4f1b","user":{"login":"LukeTowers","id":7253840,"avatar_url":"https://avatars3.githubusercontent.com/u/7253840?v=3","gravatar_id":"","url":"https://api.github.com/users/LukeTowers","html_url":"https://github.com/LukeTowers","followers_url":"https://api.github.com/users/LukeTowers/followers","following_url":"https://api.github.com/users/LukeTowers/following{/other_user}","gists_url":"https://api.github.com/users/LukeTowers/gists{/gist_id}","starred_url":"https://api.github.com/users/LukeTowers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LukeTowers/subscriptions","organizations_url":"https://api.github.com/users/LukeTowers/orgs","repos_url":"https://api.github.com/users/LukeTowers/repos","events_url":"https://api.github.com/users/LukeTowers/events{/privacy}","received_events_url":"https://api.github.com/users/LukeTowers/received_events","type":"User","site_admin":false},"body":"The documentation doesn't utilize language hinting or backticks for code syntax highlighting, indent code examples by four spaces and remove the backticks and then we can merge this. Thanks for your work so far!","created_at":"2017-03-10T17:58:08Z","updated_at":"2017-03-10T17:58:12Z","html_url":"https://github.com/octobercms/october/pull/2721#discussion_r105452312","pull_request_url":"https://api.github.com/repos/octobercms/october/pulls/2721","_links":{"self":{"href":"https://api.github.com/repos/octobercms/october/pulls/comments/105452312"},"html":{"href":"https://github.com/octobercms/october/pull/2721#discussion_r105452312"},"pull_request":{"href":"https://api.github.com/repos/octobercms/october/pulls/2721"}}},"pull_request":{"url":"https://api.github.com/repos/octobercms/october/pulls/2721","id":108307535,"html_url":"https://github.com/octobercms/october/pull/2721","diff_url":"https://github.com/octobercms/october/pull/2721.diff","patch_url":"https://github.com/octobercms/october/pull/2721.patch","issue_url":"https://api.github.com/repos/octobercms/october/issues/2721","number":2721,"state":"open","locked":false,"title":"Hotkey improvements","user":{"login":"SebastiaanKloos","id":6506510,"avatar_url":"https://avatars2.githubusercontent.com/u/6506510?v=3","gravatar_id":"","url":"https://api.github.com/users/SebastiaanKloos","html_url":"https://github.com/SebastiaanKloos","followers_url":"https://api.github.com/users/SebastiaanKloos/followers","following_url":"https://api.github.com/users/SebastiaanKloos/following{/other_user}","gists_url":"https://api.github.com/users/SebastiaanKloos/gists{/gist_id}","starred_url":"https://api.github.com/users/SebastiaanKloos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SebastiaanKloos/subscriptions","organizations_url":"https://api.github.com/users/SebastiaanKloos/orgs","repos_url":"https://api.github.com/users/SebastiaanKloos/repos","events_url":"https://api.github.com/users/SebastiaanKloos/events{/privacy}","received_events_url":"https://api.github.com/users/SebastiaanKloos/received_events","type":"User","site_admin":false},"body":"- Added better documentation inside the input.hotkeys.js file\r\n- Added the Javascript API documentation to the UI documentation","created_at":"2017-02-28T11:08:05Z","updated_at":"2017-03-10T17:58:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"00b34466ad2e65ad261b40171c56ab289c11fb40","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/octobercms/october/pulls/2721/commits","review_comments_url":"https://api.github.com/repos/octobercms/october/pulls/2721/comments","review_comment_url":"https://api.github.com/repos/octobercms/october/pulls/comments{/number}","comments_url":"https://api.github.com/repos/octobercms/october/issues/2721/comments","statuses_url":"https://api.github.com/repos/octobercms/october/statuses/1ca0b2526536b3d8ebc181d0ae22b20601ff4f1b","head":{"label":"SebastiaanKloos:develop","ref":"develop","sha":"1ca0b2526536b3d8ebc181d0ae22b20601ff4f1b","user":{"login":"SebastiaanKloos","id":6506510,"avatar_url":"https://avatars2.githubusercontent.com/u/6506510?v=3","gravatar_id":"","url":"https://api.github.com/users/SebastiaanKloos","html_url":"https://github.com/SebastiaanKloos","followers_url":"https://api.github.com/users/SebastiaanKloos/followers","following_url":"https://api.github.com/users/SebastiaanKloos/following{/other_user}","gists_url":"https://api.github.com/users/SebastiaanKloos/gists{/gist_id}","starred_url":"https://api.github.com/users/SebastiaanKloos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SebastiaanKloos/subscriptions","organizations_url":"https://api.github.com/users/SebastiaanKloos/orgs","repos_url":"https://api.github.com/users/SebastiaanKloos/repos","events_url":"https://api.github.com/users/SebastiaanKloos/events{/privacy}","received_events_url":"https://api.github.com/users/SebastiaanKloos/received_events","type":"User","site_admin":false},"repo":{"id":83340559,"name":"october","full_name":"SebastiaanKloos/october","owner":{"login":"SebastiaanKloos","id":6506510,"avatar_url":"https://avatars2.githubusercontent.com/u/6506510?v=3","gravatar_id":"","url":"https://api.github.com/users/SebastiaanKloos","html_url":"https://github.com/SebastiaanKloos","followers_url":"https://api.github.com/users/SebastiaanKloos/followers","following_url":"https://api.github.com/users/SebastiaanKloos/following{/other_user}","gists_url":"https://api.github.com/users/SebastiaanKloos/gists{/gist_id}","starred_url":"https://api.github.com/users/SebastiaanKloos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SebastiaanKloos/subscriptions","organizations_url":"https://api.github.com/users/SebastiaanKloos/orgs","repos_url":"https://api.github.com/users/SebastiaanKloos/repos","events_url":"https://api.github.com/users/SebastiaanKloos/events{/privacy}","received_events_url":"https://api.github.com/users/SebastiaanKloos/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SebastiaanKloos/october","description":"Free, open-source, self-hosted CMS platform based on the Laravel PHP Framework.","fork":true,"url":"https://api.github.com/repos/SebastiaanKloos/october","forks_url":"https://api.github.com/repos/SebastiaanKloos/october/forks","keys_url":"https://api.github.com/repos/SebastiaanKloos/october/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SebastiaanKloos/october/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SebastiaanKloos/october/teams","hooks_url":"https://api.github.com/repos/SebastiaanKloos/october/hooks","issue_events_url":"https://api.github.com/repos/SebastiaanKloos/october/issues/events{/number}","events_url":"https://api.github.com/repos/SebastiaanKloos/october/events","assignees_url":"https://api.github.com/repos/SebastiaanKloos/october/assignees{/user}","branches_url":"https://api.github.com/repos/SebastiaanKloos/october/branches{/branch}","tags_url":"https://api.github.com/repos/SebastiaanKloos/october/tags","blobs_url":"https://api.github.com/repos/SebastiaanKloos/october/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SebastiaanKloos/october/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SebastiaanKloos/october/git/refs{/sha}","trees_url":"https://api.github.com/repos/SebastiaanKloos/october/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SebastiaanKloos/october/statuses/{sha}","languages_url":"https://api.github.com/repos/SebastiaanKloos/october/languages","stargazers_url":"https://api.github.com/repos/SebastiaanKloos/october/stargazers","contributors_url":"https://api.github.com/repos/SebastiaanKloos/october/contributors","subscribers_url":"https://api.github.com/repos/SebastiaanKloos/october/subscribers","subscription_url":"https://api.github.com/repos/SebastiaanKloos/october/subscription","commits_url":"https://api.github.com/repos/SebastiaanKloos/october/commits{/sha}","git_commits_url":"https://api.github.com/repos/SebastiaanKloos/october/git/commits{/sha}","comments_url":"https://api.github.com/repos/SebastiaanKloos/october/comments{/number}","issue_comment_url":"https://api.github.com/repos/SebastiaanKloos/october/issues/comments{/number}","contents_url":"https://api.github.com/repos/SebastiaanKloos/october/contents/{+path}","compare_url":"https://api.github.com/repos/SebastiaanKloos/october/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SebastiaanKloos/october/merges","archive_url":"https://api.github.com/repos/SebastiaanKloos/october/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SebastiaanKloos/october/downloads","issues_url":"https://api.github.com/repos/SebastiaanKloos/october/issues{/number}","pulls_url":"https://api.github.com/repos/SebastiaanKloos/october/pulls{/number}","milestones_url":"https://api.github.com/repos/SebastiaanKloos/october/milestones{/number}","notifications_url":"https://api.github.com/repos/SebastiaanKloos/october/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SebastiaanKloos/october/labels{/name}","releases_url":"https://api.github.com/repos/SebastiaanKloos/october/releases{/id}","deployments_url":"https://api.github.com/repos/SebastiaanKloos/october/deployments","created_at":"2017-02-27T18:00:53Z","updated_at":"2017-02-27T18:00:59Z","pushed_at":"2017-03-09T09:02:53Z","git_url":"git://github.com/SebastiaanKloos/october.git","ssh_url":"git@github.com:SebastiaanKloos/october.git","clone_url":"https://github.com/SebastiaanKloos/october.git","svn_url":"https://github.com/SebastiaanKloos/october","homepage":"http://octobercms.com/","size":28566,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"octobercms:develop","ref":"develop","sha":"03959fa0874de2aaea83bbb27cc7523df68ad3a1","user":{"login":"octobercms","id":5554805,"avatar_url":"https://avatars0.githubusercontent.com/u/5554805?v=3","gravatar_id":"","url":"https://api.github.com/users/octobercms","html_url":"https://github.com/octobercms","followers_url":"https://api.github.com/users/octobercms/followers","following_url":"https://api.github.com/users/octobercms/following{/other_user}","gists_url":"https://api.github.com/users/octobercms/gists{/gist_id}","starred_url":"https://api.github.com/users/octobercms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/octobercms/subscriptions","organizations_url":"https://api.github.com/users/octobercms/orgs","repos_url":"https://api.github.com/users/octobercms/repos","events_url":"https://api.github.com/users/octobercms/events{/privacy}","received_events_url":"https://api.github.com/users/octobercms/received_events","type":"Organization","site_admin":false},"repo":{"id":14732311,"name":"october","full_name":"octobercms/october","owner":{"login":"octobercms","id":5554805,"avatar_url":"https://avatars0.githubusercontent.com/u/5554805?v=3","gravatar_id":"","url":"https://api.github.com/users/octobercms","html_url":"https://github.com/octobercms","followers_url":"https://api.github.com/users/octobercms/followers","following_url":"https://api.github.com/users/octobercms/following{/other_user}","gists_url":"https://api.github.com/users/octobercms/gists{/gist_id}","starred_url":"https://api.github.com/users/octobercms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/octobercms/subscriptions","organizations_url":"https://api.github.com/users/octobercms/orgs","repos_url":"https://api.github.com/users/octobercms/repos","events_url":"https://api.github.com/users/octobercms/events{/privacy}","received_events_url":"https://api.github.com/users/octobercms/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/octobercms/october","description":"Free, open-source, self-hosted CMS platform based on the Laravel PHP Framework.","fork":false,"url":"https://api.github.com/repos/octobercms/october","forks_url":"https://api.github.com/repos/octobercms/october/forks","keys_url":"https://api.github.com/repos/octobercms/october/keys{/key_id}","collaborators_url":"https://api.github.com/repos/octobercms/october/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/octobercms/october/teams","hooks_url":"https://api.github.com/repos/octobercms/october/hooks","issue_events_url":"https://api.github.com/repos/octobercms/october/issues/events{/number}","events_url":"https://api.github.com/repos/octobercms/october/events","assignees_url":"https://api.github.com/repos/octobercms/october/assignees{/user}","branches_url":"https://api.github.com/repos/octobercms/october/branches{/branch}","tags_url":"https://api.github.com/repos/octobercms/october/tags","blobs_url":"https://api.github.com/repos/octobercms/october/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/octobercms/october/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/octobercms/october/git/refs{/sha}","trees_url":"https://api.github.com/repos/octobercms/october/git/trees{/sha}","statuses_url":"https://api.github.com/repos/octobercms/october/statuses/{sha}","languages_url":"https://api.github.com/repos/octobercms/october/languages","stargazers_url":"https://api.github.com/repos/octobercms/october/stargazers","contributors_url":"https://api.github.com/repos/octobercms/october/contributors","subscribers_url":"https://api.github.com/repos/octobercms/october/subscribers","subscription_url":"https://api.github.com/repos/octobercms/october/subscription","commits_url":"https://api.github.com/repos/octobercms/october/commits{/sha}","git_commits_url":"https://api.github.com/repos/octobercms/october/git/commits{/sha}","comments_url":"https://api.github.com/repos/octobercms/october/comments{/number}","issue_comment_url":"https://api.github.com/repos/octobercms/october/issues/comments{/number}","contents_url":"https://api.github.com/repos/octobercms/october/contents/{+path}","compare_url":"https://api.github.com/repos/octobercms/october/compare/{base}...{head}","merges_url":"https://api.github.com/repos/octobercms/october/merges","archive_url":"https://api.github.com/repos/octobercms/october/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/octobercms/october/downloads","issues_url":"https://api.github.com/repos/octobercms/october/issues{/number}","pulls_url":"https://api.github.com/repos/octobercms/october/pulls{/number}","milestones_url":"https://api.github.com/repos/octobercms/october/milestones{/number}","notifications_url":"https://api.github.com/repos/octobercms/october/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/octobercms/october/labels{/name}","releases_url":"https://api.github.com/repos/octobercms/october/releases{/id}","deployments_url":"https://api.github.com/repos/octobercms/october/deployments","created_at":"2013-11-26T23:30:43Z","updated_at":"2017-03-10T14:27:06Z","pushed_at":"2017-03-10T05:36:07Z","git_url":"git://github.com/octobercms/october.git","ssh_url":"git@github.com:octobercms/october.git","clone_url":"https://github.com/octobercms/october.git","svn_url":"https://github.com/octobercms/october","homepage":"http://octobercms.com/","size":28590,"stargazers_count":5694,"watchers_count":5694,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1412,"mirror_url":null,"open_issues_count":237,"forks":1412,"open_issues":237,"watchers":5694,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/octobercms/october/pulls/2721"},"html":{"href":"https://github.com/octobercms/october/pull/2721"},"issue":{"href":"https://api.github.com/repos/octobercms/october/issues/2721"},"comments":{"href":"https://api.github.com/repos/octobercms/october/issues/2721/comments"},"review_comments":{"href":"https://api.github.com/repos/octobercms/october/pulls/2721/comments"},"review_comment":{"href":"https://api.github.com/repos/octobercms/october/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/octobercms/october/pulls/2721/commits"},"statuses":{"href":"https://api.github.com/repos/octobercms/october/statuses/1ca0b2526536b3d8ebc181d0ae22b20601ff4f1b"}}}}
{"actor":{"display_login":"LukeTowers"}}