{"action":"created","comment":{"url":"https://api.github.com/repos/pydicom/pydicom/pulls/comments/130525684","pull_request_review_id":53407468,"id":130525684,"diff_hunk":"@@ -1504,7 +1574,7 @@ def test_meta_unchanged(self):\n \n         # Conformant\n         meta = Dataset()\n-        meta.FileMetaInformationGroupLength = 62 # Correct length\n+        meta.FileMetaInformationGroupLength = 62  # Correct length\n         meta.FileMetaInformationVersion = b'\\x00\\x01'\n         meta.MediaStorageSOPClassUID = '1.1'\n         meta.MediaStorageSOPInstanceUID = '1.2'","path":"pydicom/tests/test_filewriter.py","position":815,"original_position":815,"commit_id":"f80e49573f983d06176863e3f6067ad226cd6946","original_commit_id":"f80e49573f983d06176863e3f6067ad226cd6946","user":{"login":"mrbean-bremen","id":4623701,"avatar_url":"https://avatars1.githubusercontent.com/u/4623701?v=4","gravatar_id":"","url":"https://api.github.com/users/mrbean-bremen","html_url":"https://github.com/mrbean-bremen","followers_url":"https://api.github.com/users/mrbean-bremen/followers","following_url":"https://api.github.com/users/mrbean-bremen/following{/other_user}","gists_url":"https://api.github.com/users/mrbean-bremen/gists{/gist_id}","starred_url":"https://api.github.com/users/mrbean-bremen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrbean-bremen/subscriptions","organizations_url":"https://api.github.com/users/mrbean-bremen/orgs","repos_url":"https://api.github.com/users/mrbean-bremen/repos","events_url":"https://api.github.com/users/mrbean-bremen/events{/privacy}","received_events_url":"https://api.github.com/users/mrbean-bremen/received_events","type":"User","site_admin":false},"body":"As @scaramallion did an extra PR for this one, I'm afraid you will have to revert this one and redo the changes (provided his PR gets merged first, what makes sense). But that would make this PR much cleaner also.","created_at":"2017-08-01T06:06:40Z","updated_at":"2017-08-01T06:09:29Z","html_url":"https://github.com/pydicom/pydicom/pull/434#discussion_r130525684","pull_request_url":"https://api.github.com/repos/pydicom/pydicom/pulls/434","_links":{"self":{"href":"https://api.github.com/repos/pydicom/pydicom/pulls/comments/130525684"},"html":{"href":"https://github.com/pydicom/pydicom/pull/434#discussion_r130525684"},"pull_request":{"href":"https://api.github.com/repos/pydicom/pydicom/pulls/434"}}},"pull_request":{"url":"https://api.github.com/repos/pydicom/pydicom/pulls/434","id":131951046,"html_url":"https://github.com/pydicom/pydicom/pull/434","diff_url":"https://github.com/pydicom/pydicom/pull/434.diff","patch_url":"https://github.com/pydicom/pydicom/pull/434.patch","issue_url":"https://api.github.com/repos/pydicom/pydicom/issues/434","number":434,"state":"open","locked":false,"title":"[MRG] Add data_files to setup.py","user":{"login":"vsoch","id":814322,"avatar_url":"https://avatars0.githubusercontent.com/u/814322?v=4","gravatar_id":"","url":"https://api.github.com/users/vsoch","html_url":"https://github.com/vsoch","followers_url":"https://api.github.com/users/vsoch/followers","following_url":"https://api.github.com/users/vsoch/following{/other_user}","gists_url":"https://api.github.com/users/vsoch/gists{/gist_id}","starred_url":"https://api.github.com/users/vsoch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vsoch/subscriptions","organizations_url":"https://api.github.com/users/vsoch/orgs","repos_url":"https://api.github.com/users/vsoch/repos","events_url":"https://api.github.com/users/vsoch/events{/privacy}","received_events_url":"https://api.github.com/users/vsoch/received_events","type":"User","site_admin":false},"body":"#### Reference Issue\r\nThis PR will fix #430 by adding a `data_files` specification in the setup.py\r\n\r\n#### What does this implement/fix? Explain your changes.\r\nWe basically needed to define the variable `data_files` as a list of tuples, each with a relative path to a folder, and then a list of files.\r\n\r\n#### Any other comments?\r\nSpecial shout outs to avocados, and stack overflow!\r\n","created_at":"2017-07-23T22:19:51Z","updated_at":"2017-08-01T06:09:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9f83642d7000abc93012dac71d5c41179f7f6e37","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/pydicom/pydicom/pulls/434/commits","review_comments_url":"https://api.github.com/repos/pydicom/pydicom/pulls/434/comments","review_comment_url":"https://api.github.com/repos/pydicom/pydicom/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pydicom/pydicom/issues/434/comments","statuses_url":"https://api.github.com/repos/pydicom/pydicom/statuses/f80e49573f983d06176863e3f6067ad226cd6946","head":{"label":"vsoch:setup/data","ref":"setup/data","sha":"f80e49573f983d06176863e3f6067ad226cd6946","user":{"login":"vsoch","id":814322,"avatar_url":"https://avatars0.githubusercontent.com/u/814322?v=4","gravatar_id":"","url":"https://api.github.com/users/vsoch","html_url":"https://github.com/vsoch","followers_url":"https://api.github.com/users/vsoch/followers","following_url":"https://api.github.com/users/vsoch/following{/other_user}","gists_url":"https://api.github.com/users/vsoch/gists{/gist_id}","starred_url":"https://api.github.com/users/vsoch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vsoch/subscriptions","organizations_url":"https://api.github.com/users/vsoch/orgs","repos_url":"https://api.github.com/users/vsoch/repos","events_url":"https://api.github.com/users/vsoch/events{/privacy}","received_events_url":"https://api.github.com/users/vsoch/received_events","type":"User","site_admin":false},"repo":{"id":96647921,"name":"pydicom","full_name":"vsoch/pydicom","owner":{"login":"vsoch","id":814322,"avatar_url":"https://avatars0.githubusercontent.com/u/814322?v=4","gravatar_id":"","url":"https://api.github.com/users/vsoch","html_url":"https://github.com/vsoch","followers_url":"https://api.github.com/users/vsoch/followers","following_url":"https://api.github.com/users/vsoch/following{/other_user}","gists_url":"https://api.github.com/users/vsoch/gists{/gist_id}","starred_url":"https://api.github.com/users/vsoch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vsoch/subscriptions","organizations_url":"https://api.github.com/users/vsoch/orgs","repos_url":"https://api.github.com/users/vsoch/repos","events_url":"https://api.github.com/users/vsoch/events{/privacy}","received_events_url":"https://api.github.com/users/vsoch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vsoch/pydicom","description":"Read, modify and write DICOM files with python code","fork":true,"url":"https://api.github.com/repos/vsoch/pydicom","forks_url":"https://api.github.com/repos/vsoch/pydicom/forks","keys_url":"https://api.github.com/repos/vsoch/pydicom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vsoch/pydicom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vsoch/pydicom/teams","hooks_url":"https://api.github.com/repos/vsoch/pydicom/hooks","issue_events_url":"https://api.github.com/repos/vsoch/pydicom/issues/events{/number}","events_url":"https://api.github.com/repos/vsoch/pydicom/events","assignees_url":"https://api.github.com/repos/vsoch/pydicom/assignees{/user}","branches_url":"https://api.github.com/repos/vsoch/pydicom/branches{/branch}","tags_url":"https://api.github.com/repos/vsoch/pydicom/tags","blobs_url":"https://api.github.com/repos/vsoch/pydicom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vsoch/pydicom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vsoch/pydicom/git/refs{/sha}","trees_url":"https://api.github.com/repos/vsoch/pydicom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vsoch/pydicom/statuses/{sha}","languages_url":"https://api.github.com/repos/vsoch/pydicom/languages","stargazers_url":"https://api.github.com/repos/vsoch/pydicom/stargazers","contributors_url":"https://api.github.com/repos/vsoch/pydicom/contributors","subscribers_url":"https://api.github.com/repos/vsoch/pydicom/subscribers","subscription_url":"https://api.github.com/repos/vsoch/pydicom/subscription","commits_url":"https://api.github.com/repos/vsoch/pydicom/commits{/sha}","git_commits_url":"https://api.github.com/repos/vsoch/pydicom/git/commits{/sha}","comments_url":"https://api.github.com/repos/vsoch/pydicom/comments{/number}","issue_comment_url":"https://api.github.com/repos/vsoch/pydicom/issues/comments{/number}","contents_url":"https://api.github.com/repos/vsoch/pydicom/contents/{+path}","compare_url":"https://api.github.com/repos/vsoch/pydicom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vsoch/pydicom/merges","archive_url":"https://api.github.com/repos/vsoch/pydicom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vsoch/pydicom/downloads","issues_url":"https://api.github.com/repos/vsoch/pydicom/issues{/number}","pulls_url":"https://api.github.com/repos/vsoch/pydicom/pulls{/number}","milestones_url":"https://api.github.com/repos/vsoch/pydicom/milestones{/number}","notifications_url":"https://api.github.com/repos/vsoch/pydicom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vsoch/pydicom/labels{/name}","releases_url":"https://api.github.com/repos/vsoch/pydicom/releases{/id}","deployments_url":"https://api.github.com/repos/vsoch/pydicom/deployments","created_at":"2017-07-08T22:40:11Z","updated_at":"2017-07-08T22:40:13Z","pushed_at":"2017-07-31T23:10:08Z","git_url":"git://github.com/vsoch/pydicom.git","ssh_url":"git@github.com:vsoch/pydicom.git","clone_url":"https://github.com/vsoch/pydicom.git","svn_url":"https://github.com/vsoch/pydicom","homepage":null,"size":15741,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pydicom:master","ref":"master","sha":"7c23e9b0a07ea746c086414b7f30d2035cbe188f","user":{"login":"pydicom","id":28906941,"avatar_url":"https://avatars2.githubusercontent.com/u/28906941?v=4","gravatar_id":"","url":"https://api.github.com/users/pydicom","html_url":"https://github.com/pydicom","followers_url":"https://api.github.com/users/pydicom/followers","following_url":"https://api.github.com/users/pydicom/following{/other_user}","gists_url":"https://api.github.com/users/pydicom/gists{/gist_id}","starred_url":"https://api.github.com/users/pydicom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pydicom/subscriptions","organizations_url":"https://api.github.com/users/pydicom/orgs","repos_url":"https://api.github.com/users/pydicom/repos","events_url":"https://api.github.com/users/pydicom/events{/privacy}","received_events_url":"https://api.github.com/users/pydicom/received_events","type":"Organization","site_admin":false},"repo":{"id":14006067,"name":"pydicom","full_name":"pydicom/pydicom","owner":{"login":"pydicom","id":28906941,"avatar_url":"https://avatars2.githubusercontent.com/u/28906941?v=4","gravatar_id":"","url":"https://api.github.com/users/pydicom","html_url":"https://github.com/pydicom","followers_url":"https://api.github.com/users/pydicom/followers","following_url":"https://api.github.com/users/pydicom/following{/other_user}","gists_url":"https://api.github.com/users/pydicom/gists{/gist_id}","starred_url":"https://api.github.com/users/pydicom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pydicom/subscriptions","organizations_url":"https://api.github.com/users/pydicom/orgs","repos_url":"https://api.github.com/users/pydicom/repos","events_url":"https://api.github.com/users/pydicom/events{/privacy}","received_events_url":"https://api.github.com/users/pydicom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pydicom/pydicom","description":"Read, modify and write DICOM files with python code","fork":false,"url":"https://api.github.com/repos/pydicom/pydicom","forks_url":"https://api.github.com/repos/pydicom/pydicom/forks","keys_url":"https://api.github.com/repos/pydicom/pydicom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pydicom/pydicom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pydicom/pydicom/teams","hooks_url":"https://api.github.com/repos/pydicom/pydicom/hooks","issue_events_url":"https://api.github.com/repos/pydicom/pydicom/issues/events{/number}","events_url":"https://api.github.com/repos/pydicom/pydicom/events","assignees_url":"https://api.github.com/repos/pydicom/pydicom/assignees{/user}","branches_url":"https://api.github.com/repos/pydicom/pydicom/branches{/branch}","tags_url":"https://api.github.com/repos/pydicom/pydicom/tags","blobs_url":"https://api.github.com/repos/pydicom/pydicom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pydicom/pydicom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pydicom/pydicom/git/refs{/sha}","trees_url":"https://api.github.com/repos/pydicom/pydicom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pydicom/pydicom/statuses/{sha}","languages_url":"https://api.github.com/repos/pydicom/pydicom/languages","stargazers_url":"https://api.github.com/repos/pydicom/pydicom/stargazers","contributors_url":"https://api.github.com/repos/pydicom/pydicom/contributors","subscribers_url":"https://api.github.com/repos/pydicom/pydicom/subscribers","subscription_url":"https://api.github.com/repos/pydicom/pydicom/subscription","commits_url":"https://api.github.com/repos/pydicom/pydicom/commits{/sha}","git_commits_url":"https://api.github.com/repos/pydicom/pydicom/git/commits{/sha}","comments_url":"https://api.github.com/repos/pydicom/pydicom/comments{/number}","issue_comment_url":"https://api.github.com/repos/pydicom/pydicom/issues/comments{/number}","contents_url":"https://api.github.com/repos/pydicom/pydicom/contents/{+path}","compare_url":"https://api.github.com/repos/pydicom/pydicom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pydicom/pydicom/merges","archive_url":"https://api.github.com/repos/pydicom/pydicom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pydicom/pydicom/downloads","issues_url":"https://api.github.com/repos/pydicom/pydicom/issues{/number}","pulls_url":"https://api.github.com/repos/pydicom/pydicom/pulls{/number}","milestones_url":"https://api.github.com/repos/pydicom/pydicom/milestones{/number}","notifications_url":"https://api.github.com/repos/pydicom/pydicom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pydicom/pydicom/labels{/name}","releases_url":"https://api.github.com/repos/pydicom/pydicom/releases{/id}","deployments_url":"https://api.github.com/repos/pydicom/pydicom/deployments","created_at":"2013-10-31T02:58:52Z","updated_at":"2017-07-29T19:57:11Z","pushed_at":"2017-08-01T00:40:41Z","git_url":"git://github.com/pydicom/pydicom.git","ssh_url":"git@github.com:pydicom/pydicom.git","clone_url":"https://github.com/pydicom/pydicom.git","svn_url":"https://github.com/pydicom/pydicom","homepage":null,"size":15800,"stargazers_count":263,"watchers_count":263,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":130,"mirror_url":null,"open_issues_count":72,"forks":130,"open_issues":72,"watchers":263,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pydicom/pydicom/pulls/434"},"html":{"href":"https://github.com/pydicom/pydicom/pull/434"},"issue":{"href":"https://api.github.com/repos/pydicom/pydicom/issues/434"},"comments":{"href":"https://api.github.com/repos/pydicom/pydicom/issues/434/comments"},"review_comments":{"href":"https://api.github.com/repos/pydicom/pydicom/pulls/434/comments"},"review_comment":{"href":"https://api.github.com/repos/pydicom/pydicom/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pydicom/pydicom/pulls/434/commits"},"statuses":{"href":"https://api.github.com/repos/pydicom/pydicom/statuses/f80e49573f983d06176863e3f6067ad226cd6946"}}}}
{"actor":{"display_login":"mrbean-bremen"}}