{"action":"created","issue":{"url":"https://api.github.com/repos/puppetlabs/puppetdb/issues/2224","repository_url":"https://api.github.com/repos/puppetlabs/puppetdb","labels_url":"https://api.github.com/repos/puppetlabs/puppetdb/issues/2224/labels{/name}","comments_url":"https://api.github.com/repos/puppetlabs/puppetdb/issues/2224/comments","events_url":"https://api.github.com/repos/puppetlabs/puppetdb/issues/2224/events","html_url":"https://github.com/puppetlabs/puppetdb/pull/2224","id":219015811,"number":2224,"title":"(PDB-3322) Redact sensitive parameters in terminus","user":{"login":"rbrw","id":10120698,"avatar_url":"https://avatars3.githubusercontent.com/u/10120698?v=3","gravatar_id":"","url":"https://api.github.com/users/rbrw","html_url":"https://github.com/rbrw","followers_url":"https://api.github.com/users/rbrw/followers","following_url":"https://api.github.com/users/rbrw/following{/other_user}","gists_url":"https://api.github.com/users/rbrw/gists{/gist_id}","starred_url":"https://api.github.com/users/rbrw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbrw/subscriptions","organizations_url":"https://api.github.com/users/rbrw/orgs","repos_url":"https://api.github.com/users/rbrw/repos","events_url":"https://api.github.com/users/rbrw/events{/privacy}","received_events_url":"https://api.github.com/users/rbrw/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2017-04-03T18:07:58Z","updated_at":"2017-04-04T01:00:21Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppetdb/pulls/2224","html_url":"https://github.com/puppetlabs/puppetdb/pull/2224","diff_url":"https://github.com/puppetlabs/puppetdb/pull/2224.diff","patch_url":"https://github.com/puppetlabs/puppetdb/pull/2224.patch"},"body":"A resource parameter marked Sensitive()\r\n\r\n  notify {'hi':  message => Sensitive('there')}\r\n\r\nwill show up in the terminus\r\nlike this:\r\n\r\n        input = {...\r\n                 'environment'=>'production',\r\n                 'resources'=>\r\n                 [...\r\n                  {'type'=>'Notify',\r\n                   'title'=>'hi',\r\n                   'tags'=>Puppet::Util::TagSet.new(['notify', 'hi', 'class']),\r\n                   'file'=> 'site.pp',\r\n                   'line'=>1,\r\n                   'exported'=>false,\r\n                   'parameters'=>{:message=>'there'},\r\n                   'sensitive_parameters'=>[:message]}],\r\n                 'edges'=>\r\n                 [{'source'=>'Stage[main]', 'target'=>'Class[Settings]'},\r\n                  {'source'=>'Stage[main]', 'target'=>'Class[main]'},\r\n                  {'source'=>'Class[main]', 'target'=>'Notify[hi]'}],\r\n                 'classes'=>['settings']}\r\n\r\nRemove any sensitive values from 'parameters', and remove\r\n'sensitive_parameters' before sending data to PuppetDB.\r\n\r\nAside from the fact that we don't want senstitive parameters to be\r\nstored in (or even make it to) PuppetDB, the 'sensitive_parameters'\r\nelement can cause command processing to fail, e.g. when an existing\r\nparameter becomes sensitive.  Add an integration test for that."},"comment":{"url":"https://api.github.com/repos/puppetlabs/puppetdb/issues/comments/291354486","html_url":"https://github.com/puppetlabs/puppetdb/pull/2224#issuecomment-291354486","issue_url":"https://api.github.com/repos/puppetlabs/puppetdb/issues/2224","id":291354486,"user":{"login":"puppetcla","id":3835957,"avatar_url":"https://avatars0.githubusercontent.com/u/3835957?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetcla","html_url":"https://github.com/puppetcla","followers_url":"https://api.github.com/users/puppetcla/followers","following_url":"https://api.github.com/users/puppetcla/following{/other_user}","gists_url":"https://api.github.com/users/puppetcla/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetcla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetcla/subscriptions","organizations_url":"https://api.github.com/users/puppetcla/orgs","repos_url":"https://api.github.com/users/puppetcla/repos","events_url":"https://api.github.com/users/puppetcla/events{/privacy}","received_events_url":"https://api.github.com/users/puppetcla/received_events","type":"User","site_admin":false},"created_at":"2017-04-04T01:00:21Z","updated_at":"2017-04-04T01:00:21Z","body":"CLA signed by all contributors."}}
{"actor":{"display_login":"puppetcla"}}