{"action":"closed","number":66,"pull_request":{"url":"https://api.github.com/repos/aakashns/react-native-dialogs/pulls/66","id":133775487,"html_url":"https://github.com/aakashns/react-native-dialogs/pull/66","diff_url":"https://github.com/aakashns/react-native-dialogs/pull/66.diff","patch_url":"https://github.com/aakashns/react-native-dialogs/pull/66.patch","issue_url":"https://api.github.com/repos/aakashns/react-native-dialogs/issues/66","number":66,"state":"closed","locked":false,"title":"Remove createJSModules - RN 0.47 compatibility","user":{"login":"radko93","id":7029942,"avatar_url":"https://avatars0.githubusercontent.com/u/7029942?v=4","gravatar_id":"","url":"https://api.github.com/users/radko93","html_url":"https://github.com/radko93","followers_url":"https://api.github.com/users/radko93/followers","following_url":"https://api.github.com/users/radko93/following{/other_user}","gists_url":"https://api.github.com/users/radko93/gists{/gist_id}","starred_url":"https://api.github.com/users/radko93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radko93/subscriptions","organizations_url":"https://api.github.com/users/radko93/orgs","repos_url":"https://api.github.com/users/radko93/repos","events_url":"https://api.github.com/users/radko93/events{/privacy}","received_events_url":"https://api.github.com/users/radko93/received_events","type":"User","site_admin":false},"body":"[`createJSModules` is now not required on Android](https://github.com/facebook/react-native/commit/ce6fb337a146e6f261f2afb564aa19363774a7a8) from RN 0.47. I actually can't build an app on RN 0.47 without removing this method/@ovveride marker. This change should be backwards compatible according to my tests.","created_at":"2017-08-02T18:20:30Z","updated_at":"2017-09-16T22:35:18Z","closed_at":"2017-09-16T22:35:18Z","merged_at":"2017-09-16T22:35:18Z","merge_commit_sha":"c4801271128d542f294dde08f49f92b2ee1e8144","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/aakashns/react-native-dialogs/pulls/66/commits","review_comments_url":"https://api.github.com/repos/aakashns/react-native-dialogs/pulls/66/comments","review_comment_url":"https://api.github.com/repos/aakashns/react-native-dialogs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aakashns/react-native-dialogs/issues/66/comments","statuses_url":"https://api.github.com/repos/aakashns/react-native-dialogs/statuses/96a1d8e3dbc440f40faa3ebf7ddbec4c9d0b192c","head":{"label":"radko93:patch-1","ref":"patch-1","sha":"96a1d8e3dbc440f40faa3ebf7ddbec4c9d0b192c","user":{"login":"radko93","id":7029942,"avatar_url":"https://avatars0.githubusercontent.com/u/7029942?v=4","gravatar_id":"","url":"https://api.github.com/users/radko93","html_url":"https://github.com/radko93","followers_url":"https://api.github.com/users/radko93/followers","following_url":"https://api.github.com/users/radko93/following{/other_user}","gists_url":"https://api.github.com/users/radko93/gists{/gist_id}","starred_url":"https://api.github.com/users/radko93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radko93/subscriptions","organizations_url":"https://api.github.com/users/radko93/orgs","repos_url":"https://api.github.com/users/radko93/repos","events_url":"https://api.github.com/users/radko93/events{/privacy}","received_events_url":"https://api.github.com/users/radko93/received_events","type":"User","site_admin":false},"repo":{"id":99148099,"name":"react-native-dialogs","full_name":"radko93/react-native-dialogs","owner":{"login":"radko93","id":7029942,"avatar_url":"https://avatars0.githubusercontent.com/u/7029942?v=4","gravatar_id":"","url":"https://api.github.com/users/radko93","html_url":"https://github.com/radko93","followers_url":"https://api.github.com/users/radko93/followers","following_url":"https://api.github.com/users/radko93/following{/other_user}","gists_url":"https://api.github.com/users/radko93/gists{/gist_id}","starred_url":"https://api.github.com/users/radko93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radko93/subscriptions","organizations_url":"https://api.github.com/users/radko93/orgs","repos_url":"https://api.github.com/users/radko93/repos","events_url":"https://api.github.com/users/radko93/events{/privacy}","received_events_url":"https://api.github.com/users/radko93/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/radko93/react-native-dialogs","description":"React Native wrappers for https://github.com/afollestad/material-dialogs","fork":true,"url":"https://api.github.com/repos/radko93/react-native-dialogs","forks_url":"https://api.github.com/repos/radko93/react-native-dialogs/forks","keys_url":"https://api.github.com/repos/radko93/react-native-dialogs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/radko93/react-native-dialogs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/radko93/react-native-dialogs/teams","hooks_url":"https://api.github.com/repos/radko93/react-native-dialogs/hooks","issue_events_url":"https://api.github.com/repos/radko93/react-native-dialogs/issues/events{/number}","events_url":"https://api.github.com/repos/radko93/react-native-dialogs/events","assignees_url":"https://api.github.com/repos/radko93/react-native-dialogs/assignees{/user}","branches_url":"https://api.github.com/repos/radko93/react-native-dialogs/branches{/branch}","tags_url":"https://api.github.com/repos/radko93/react-native-dialogs/tags","blobs_url":"https://api.github.com/repos/radko93/react-native-dialogs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/radko93/react-native-dialogs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/radko93/react-native-dialogs/git/refs{/sha}","trees_url":"https://api.github.com/repos/radko93/react-native-dialogs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/radko93/react-native-dialogs/statuses/{sha}","languages_url":"https://api.github.com/repos/radko93/react-native-dialogs/languages","stargazers_url":"https://api.github.com/repos/radko93/react-native-dialogs/stargazers","contributors_url":"https://api.github.com/repos/radko93/react-native-dialogs/contributors","subscribers_url":"https://api.github.com/repos/radko93/react-native-dialogs/subscribers","subscription_url":"https://api.github.com/repos/radko93/react-native-dialogs/subscription","commits_url":"https://api.github.com/repos/radko93/react-native-dialogs/commits{/sha}","git_commits_url":"https://api.github.com/repos/radko93/react-native-dialogs/git/commits{/sha}","comments_url":"https://api.github.com/repos/radko93/react-native-dialogs/comments{/number}","issue_comment_url":"https://api.github.com/repos/radko93/react-native-dialogs/issues/comments{/number}","contents_url":"https://api.github.com/repos/radko93/react-native-dialogs/contents/{+path}","compare_url":"https://api.github.com/repos/radko93/react-native-dialogs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/radko93/react-native-dialogs/merges","archive_url":"https://api.github.com/repos/radko93/react-native-dialogs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/radko93/react-native-dialogs/downloads","issues_url":"https://api.github.com/repos/radko93/react-native-dialogs/issues{/number}","pulls_url":"https://api.github.com/repos/radko93/react-native-dialogs/pulls{/number}","milestones_url":"https://api.github.com/repos/radko93/react-native-dialogs/milestones{/number}","notifications_url":"https://api.github.com/repos/radko93/react-native-dialogs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/radko93/react-native-dialogs/labels{/name}","releases_url":"https://api.github.com/repos/radko93/react-native-dialogs/releases{/id}","deployments_url":"https://api.github.com/repos/radko93/react-native-dialogs/deployments","created_at":"2017-08-02T18:19:53Z","updated_at":"2017-08-02T18:19:55Z","pushed_at":"2017-08-07T11:56:37Z","git_url":"git://github.com/radko93/react-native-dialogs.git","ssh_url":"git@github.com:radko93/react-native-dialogs.git","clone_url":"https://github.com/radko93/react-native-dialogs.git","svn_url":"https://github.com/radko93/react-native-dialogs","homepage":null,"size":187,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"aakashns:master","ref":"master","sha":"8abaf11da1397c2a4fcb814d3beb17e793079b99","user":{"login":"aakashns","id":1560745,"avatar_url":"https://avatars1.githubusercontent.com/u/1560745?v=4","gravatar_id":"","url":"https://api.github.com/users/aakashns","html_url":"https://github.com/aakashns","followers_url":"https://api.github.com/users/aakashns/followers","following_url":"https://api.github.com/users/aakashns/following{/other_user}","gists_url":"https://api.github.com/users/aakashns/gists{/gist_id}","starred_url":"https://api.github.com/users/aakashns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aakashns/subscriptions","organizations_url":"https://api.github.com/users/aakashns/orgs","repos_url":"https://api.github.com/users/aakashns/repos","events_url":"https://api.github.com/users/aakashns/events{/privacy}","received_events_url":"https://api.github.com/users/aakashns/received_events","type":"User","site_admin":false},"repo":{"id":45305594,"name":"react-native-dialogs","full_name":"aakashns/react-native-dialogs","owner":{"login":"aakashns","id":1560745,"avatar_url":"https://avatars1.githubusercontent.com/u/1560745?v=4","gravatar_id":"","url":"https://api.github.com/users/aakashns","html_url":"https://github.com/aakashns","followers_url":"https://api.github.com/users/aakashns/followers","following_url":"https://api.github.com/users/aakashns/following{/other_user}","gists_url":"https://api.github.com/users/aakashns/gists{/gist_id}","starred_url":"https://api.github.com/users/aakashns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aakashns/subscriptions","organizations_url":"https://api.github.com/users/aakashns/orgs","repos_url":"https://api.github.com/users/aakashns/repos","events_url":"https://api.github.com/users/aakashns/events{/privacy}","received_events_url":"https://api.github.com/users/aakashns/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aakashns/react-native-dialogs","description":"React Native wrappers for https://github.com/afollestad/material-dialogs","fork":false,"url":"https://api.github.com/repos/aakashns/react-native-dialogs","forks_url":"https://api.github.com/repos/aakashns/react-native-dialogs/forks","keys_url":"https://api.github.com/repos/aakashns/react-native-dialogs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aakashns/react-native-dialogs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aakashns/react-native-dialogs/teams","hooks_url":"https://api.github.com/repos/aakashns/react-native-dialogs/hooks","issue_events_url":"https://api.github.com/repos/aakashns/react-native-dialogs/issues/events{/number}","events_url":"https://api.github.com/repos/aakashns/react-native-dialogs/events","assignees_url":"https://api.github.com/repos/aakashns/react-native-dialogs/assignees{/user}","branches_url":"https://api.github.com/repos/aakashns/react-native-dialogs/branches{/branch}","tags_url":"https://api.github.com/repos/aakashns/react-native-dialogs/tags","blobs_url":"https://api.github.com/repos/aakashns/react-native-dialogs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aakashns/react-native-dialogs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aakashns/react-native-dialogs/git/refs{/sha}","trees_url":"https://api.github.com/repos/aakashns/react-native-dialogs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aakashns/react-native-dialogs/statuses/{sha}","languages_url":"https://api.github.com/repos/aakashns/react-native-dialogs/languages","stargazers_url":"https://api.github.com/repos/aakashns/react-native-dialogs/stargazers","contributors_url":"https://api.github.com/repos/aakashns/react-native-dialogs/contributors","subscribers_url":"https://api.github.com/repos/aakashns/react-native-dialogs/subscribers","subscription_url":"https://api.github.com/repos/aakashns/react-native-dialogs/subscription","commits_url":"https://api.github.com/repos/aakashns/react-native-dialogs/commits{/sha}","git_commits_url":"https://api.github.com/repos/aakashns/react-native-dialogs/git/commits{/sha}","comments_url":"https://api.github.com/repos/aakashns/react-native-dialogs/comments{/number}","issue_comment_url":"https://api.github.com/repos/aakashns/react-native-dialogs/issues/comments{/number}","contents_url":"https://api.github.com/repos/aakashns/react-native-dialogs/contents/{+path}","compare_url":"https://api.github.com/repos/aakashns/react-native-dialogs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aakashns/react-native-dialogs/merges","archive_url":"https://api.github.com/repos/aakashns/react-native-dialogs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aakashns/react-native-dialogs/downloads","issues_url":"https://api.github.com/repos/aakashns/react-native-dialogs/issues{/number}","pulls_url":"https://api.github.com/repos/aakashns/react-native-dialogs/pulls{/number}","milestones_url":"https://api.github.com/repos/aakashns/react-native-dialogs/milestones{/number}","notifications_url":"https://api.github.com/repos/aakashns/react-native-dialogs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aakashns/react-native-dialogs/labels{/name}","releases_url":"https://api.github.com/repos/aakashns/react-native-dialogs/releases{/id}","deployments_url":"https://api.github.com/repos/aakashns/react-native-dialogs/deployments","created_at":"2015-10-31T14:53:37Z","updated_at":"2017-09-12T13:53:41Z","pushed_at":"2017-09-16T22:35:18Z","git_url":"git://github.com/aakashns/react-native-dialogs.git","ssh_url":"git@github.com:aakashns/react-native-dialogs.git","clone_url":"https://github.com/aakashns/react-native-dialogs.git","svn_url":"https://github.com/aakashns/react-native-dialogs","homepage":null,"size":185,"stargazers_count":330,"watchers_count":330,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":76,"mirror_url":null,"open_issues_count":37,"forks":76,"open_issues":37,"watchers":330,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aakashns/react-native-dialogs/pulls/66"},"html":{"href":"https://github.com/aakashns/react-native-dialogs/pull/66"},"issue":{"href":"https://api.github.com/repos/aakashns/react-native-dialogs/issues/66"},"comments":{"href":"https://api.github.com/repos/aakashns/react-native-dialogs/issues/66/comments"},"review_comments":{"href":"https://api.github.com/repos/aakashns/react-native-dialogs/pulls/66/comments"},"review_comment":{"href":"https://api.github.com/repos/aakashns/react-native-dialogs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aakashns/react-native-dialogs/pulls/66/commits"},"statuses":{"href":"https://api.github.com/repos/aakashns/react-native-dialogs/statuses/96a1d8e3dbc440f40faa3ebf7ddbec4c9d0b192c"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"vonovak","id":1566403,"avatar_url":"https://avatars1.githubusercontent.com/u/1566403?v=4","gravatar_id":"","url":"https://api.github.com/users/vonovak","html_url":"https://github.com/vonovak","followers_url":"https://api.github.com/users/vonovak/followers","following_url":"https://api.github.com/users/vonovak/following{/other_user}","gists_url":"https://api.github.com/users/vonovak/gists{/gist_id}","starred_url":"https://api.github.com/users/vonovak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vonovak/subscriptions","organizations_url":"https://api.github.com/users/vonovak/orgs","repos_url":"https://api.github.com/users/vonovak/repos","events_url":"https://api.github.com/users/vonovak/events{/privacy}","received_events_url":"https://api.github.com/users/vonovak/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"vonovak"}}