{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla/cipherscan/issues/67","repository_url":"https://api.github.com/repos/mozilla/cipherscan","labels_url":"https://api.github.com/repos/mozilla/cipherscan/issues/67/labels{/name}","comments_url":"https://api.github.com/repos/mozilla/cipherscan/issues/67/comments","events_url":"https://api.github.com/repos/mozilla/cipherscan/issues/67/events","html_url":"https://github.com/mozilla/cipherscan/pull/67","id":98210332,"number":67,"title":"Updated cipherscan to handle environmental error conditions better:","user":{"login":"gowenfawr","id":6210340,"avatar_url":"https://avatars.githubusercontent.com/u/6210340?v=3","gravatar_id":"","url":"https://api.github.com/users/gowenfawr","html_url":"https://github.com/gowenfawr","followers_url":"https://api.github.com/users/gowenfawr/followers","following_url":"https://api.github.com/users/gowenfawr/following{/other_user}","gists_url":"https://api.github.com/users/gowenfawr/gists{/gist_id}","starred_url":"https://api.github.com/users/gowenfawr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gowenfawr/subscriptions","organizations_url":"https://api.github.com/users/gowenfawr/orgs","repos_url":"https://api.github.com/users/gowenfawr/repos","events_url":"https://api.github.com/users/gowenfawr/events{/privacy}","received_events_url":"https://api.github.com/users/gowenfawr/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2015-07-30T16:25:59Z","updated_at":"2017-01-13T21:11:41Z","closed_at":"2017-01-13T21:11:41Z","pull_request":{"url":"https://api.github.com/repos/mozilla/cipherscan/pulls/67","html_url":"https://github.com/mozilla/cipherscan/pull/67","diff_url":"https://github.com/mozilla/cipherscan/pull/67.diff","patch_url":"https://github.com/mozilla/cipherscan/pull/67.patch"},"body":"Running on a RHEL6 box two problems became apparent; this patch fixes them:\n1. If bundled openssl is a bad binary (e.g. wrong glibc), use system openssl\n2. Skip bundled openssl.cnf if it causes failures (e.g. openssl w/o GOST)\n\nSo, for 1:\n\nIf the bundled 'openssl' binary has the executable permission bit set but is not a valid executable\nfile for the system it's on, then currently it will fail.  In my example, the bundled openssl was compiled\nagainst GLIBC 2.14, but RHEL 6 ships with GLIBC 2.12:\n\n```\n$ ./openssl\n./openssl: /lib64/libc.so.6: version `GLIBC_2.14' not found (required by ./openssl)\n$\n```\n\nOther issues, such as running on a 32-bit platform, should cause equivalent errors.  The patch \nruns the bundled openssl with stdin \"quit\" and reverts to the system openssl if it doesn't exit\ncleanly.\n\nBefore this patch, running cipherscan on RHEL6 resulted in an empty cipher report and \n`config not supported, connection failed` for all Fallbacks.\n\nFor 2:\n\nIf cipherscan falls back to the system openssl, and the system openssl does not support GOST,\nthen the use of the bundled openssl.cnf file will cause cipherscan to fail because s_client calls\nerror out:\n\n```\n$ OPENSSL_CONF=./openssl.cnf openssl s_client -help\nError configuring OpenSSL\n140737353987912:error:25066067:DSO support routines:DLFCN_LOAD:could not load the shared library:dso_dlfcn.c:187:filename(/usr/lib64/openssl/engines/libgost.so): /usr/lib64/openssl/engines/libgost.so: cannot open shared object file: No such file or directory\n140737353987912:error:25070067:DSO support routines:DSO_load:could not load the shared library:dso_lib.c:244:\n140737353987912:error:260B6084:engine routines:DYNAMIC_LOAD:dso not found:eng_dyn.c:450:\n140737353987912:error:2606A074:engine routines:ENGINE_by_id:no such engine:eng_list.c:417:id=gost\n140737353987912:error:260BC066:engine routines:INT_ENGINE_CONFIGURE:engine configuration error:eng_cnf.c:204:section=gost_section, name=default_algorithms, value=ALL\n140737353987912:error:0E07606D:configuration file routines:MODULE_RUN:module initialization error:conf_mod.c:235:module=engines, value=engine_section, retcode=-1\n$\n```\n\nTo address this issue, the patch runs openssl using the bundled openssl.cnf and if any \":error:\" is\nfound in the output, it will not use the bundled openssl.cnf.\n"},"comment":{"url":"https://api.github.com/repos/mozilla/cipherscan/issues/comments/272549024","html_url":"https://github.com/mozilla/cipherscan/pull/67#issuecomment-272549024","issue_url":"https://api.github.com/repos/mozilla/cipherscan/issues/67","id":272549024,"user":{"login":"jvehent","id":415617,"avatar_url":"https://avatars.githubusercontent.com/u/415617?v=3","gravatar_id":"","url":"https://api.github.com/users/jvehent","html_url":"https://github.com/jvehent","followers_url":"https://api.github.com/users/jvehent/followers","following_url":"https://api.github.com/users/jvehent/following{/other_user}","gists_url":"https://api.github.com/users/jvehent/gists{/gist_id}","starred_url":"https://api.github.com/users/jvehent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jvehent/subscriptions","organizations_url":"https://api.github.com/users/jvehent/orgs","repos_url":"https://api.github.com/users/jvehent/repos","events_url":"https://api.github.com/users/jvehent/events{/privacy}","received_events_url":"https://api.github.com/users/jvehent/received_events","type":"User","site_admin":false},"created_at":"2017-01-13T21:11:41Z","updated_at":"2017-01-13T21:11:41Z","body":"closing for timeout."}}
{"actor":{"display_login":"jvehent"}}