{"action":"created","issue":{"url":"https://api.github.com/repos/agnat/node_mdns/issues/200","repository_url":"https://api.github.com/repos/agnat/node_mdns","labels_url":"https://api.github.com/repos/agnat/node_mdns/issues/200/labels{/name}","comments_url":"https://api.github.com/repos/agnat/node_mdns/issues/200/comments","events_url":"https://api.github.com/repos/agnat/node_mdns/issues/200/events","html_url":"https://github.com/agnat/node_mdns/pull/200","id":261934500,"number":200,"title":"Update to new cares_wrap.getaddrinfo() interface.","user":{"login":"bnoordhuis","id":275871,"avatar_url":"https://avatars0.githubusercontent.com/u/275871?v=4","gravatar_id":"","url":"https://api.github.com/users/bnoordhuis","html_url":"https://github.com/bnoordhuis","followers_url":"https://api.github.com/users/bnoordhuis/followers","following_url":"https://api.github.com/users/bnoordhuis/following{/other_user}","gists_url":"https://api.github.com/users/bnoordhuis/gists{/gist_id}","starred_url":"https://api.github.com/users/bnoordhuis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bnoordhuis/subscriptions","organizations_url":"https://api.github.com/users/bnoordhuis/orgs","repos_url":"https://api.github.com/users/bnoordhuis/repos","events_url":"https://api.github.com/users/bnoordhuis/events{/privacy}","received_events_url":"https://api.github.com/users/bnoordhuis/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-10-01T18:10:13Z","updated_at":"2017-10-13T18:45:47Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/agnat/node_mdns/pulls/200","html_url":"https://github.com/agnat/node_mdns/pull/200","diff_url":"https://github.com/agnat/node_mdns/pull/200.diff","patch_url":"https://github.com/agnat/node_mdns/pull/200.patch"},"body":"As of node.js v8.6.0, the method takes a fourth argument that is a\r\nboolean.  `false` is as of this time the default value.\r\n\r\nThis is a quick fix.  node_mdns really should not be depending on\r\nnode.js internals like this because it inevitably breaks.\r\n\r\nFixes: https://github.com/agnat/node_mdns/issues/199\r\nRefs: https://github.com/nodejs/node/pull/14731\r\n\r\nI don't know what node.js versions node_mdns ostensibly supports (I saw a node-waf script in there!) but I'd rip out this code altogether and use the public API."},"comment":{"url":"https://api.github.com/repos/agnat/node_mdns/issues/comments/336536377","html_url":"https://github.com/agnat/node_mdns/pull/200#issuecomment-336536377","issue_url":"https://api.github.com/repos/agnat/node_mdns/issues/200","id":336536377,"user":{"login":"superhawk610","id":18172185,"avatar_url":"https://avatars1.githubusercontent.com/u/18172185?v=4","gravatar_id":"","url":"https://api.github.com/users/superhawk610","html_url":"https://github.com/superhawk610","followers_url":"https://api.github.com/users/superhawk610/followers","following_url":"https://api.github.com/users/superhawk610/following{/other_user}","gists_url":"https://api.github.com/users/superhawk610/gists{/gist_id}","starred_url":"https://api.github.com/users/superhawk610/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/superhawk610/subscriptions","organizations_url":"https://api.github.com/users/superhawk610/orgs","repos_url":"https://api.github.com/users/superhawk610/repos","events_url":"https://api.github.com/users/superhawk610/events{/privacy}","received_events_url":"https://api.github.com/users/superhawk610/received_events","type":"User","site_admin":false},"created_at":"2017-10-13T18:45:47Z","updated_at":"2017-10-13T18:45:47Z","author_association":"NONE","body":"@Nastra888 in your project, open `node_modules/mdns/lib/resolver_sequence_tasks.js` and change line 117 to\n\n```\n, err = cares.getaddrinfo(req, host, family, 0, false)\n```\n"}}
{"actor":{"display_login":"superhawk610"}}