{"push_id":2063332728,"size":13,"distinct_size":11,"ref":"refs/heads/fix_anti_pattern","head":"dd9f0e62103ddd31674bbe012e7a403a7975caaf","before":"d922a6aed9a8adf00cbab9b9bd381a5858a3dc9f","commits":[{"sha":"179a3f9c0e47d820cdd6b42800c54309fdbc64fc","author":{"name":"baude","email":"7d2e689c6a9f5a2550144323cdbc41d2d64aa11f@redhat.com"},"message":"server/sandbox_list.go: No error on filtered list find by ID\n\nWe should not error when we try to find a pod ID in a filtered\nlist of sandboxes; instead we should return an empty struct\nand log it.\n\nThis fixes another cri-test failure.\n\nSigned-off-by: baude <bbaude@redhat.com>","distinct":true,"url":"https://api.github.com/repos/cevich/cri-o/commits/179a3f9c0e47d820cdd6b42800c54309fdbc64fc"},{"sha":"761e73c82e449ff4f94e88b1680bbc1dce4c2883","author":{"name":"Mrunal Patel","email":"9747a7dc9b360e345a0bf6f4058aa7bf3e2f0540@gmail.com"},"message":"Move crio default sock to /var/run/crio/crio.sock\n\nSigned-off-by: Mrunal Patel <mrunalp@gmail.com>","distinct":true,"url":"https://api.github.com/repos/cevich/cri-o/commits/761e73c82e449ff4f94e88b1680bbc1dce4c2883"},{"sha":"704ebacab8d8d1846bc4b90301dba2e9d7912209","author":{"name":"Daniel J Walsh","email":"6a27605abc9dbaa0594764ee8d1278451ea19a31@redhat.com"},"message":"Update to latest seccomp filters in moby\n\nSigned-off-by: Daniel J Walsh <dwalsh@redhat.com>","distinct":false,"url":"https://api.github.com/repos/cevich/cri-o/commits/704ebacab8d8d1846bc4b90301dba2e9d7912209"},{"sha":"b3ceb2a4500d49bb07e87665e3890b40495a0cb3","author":{"name":"Daniel J Walsh","email":"6a27605abc9dbaa0594764ee8d1278451ea19a31@redhat.com"},"message":"Merge pull request #1031 from rhatdan/seccomp\n\nUpdate to latest seccomp filters in moby","distinct":false,"url":"https://api.github.com/repos/cevich/cri-o/commits/b3ceb2a4500d49bb07e87665e3890b40495a0cb3"},{"sha":"c2b7f37bd3cca3dc263d2557d8aa488b2349a047","author":{"name":"Daniel J Walsh","email":"6a27605abc9dbaa0594764ee8d1278451ea19a31@redhat.com"},"message":"Merge pull request #1017 from baude/cri_tests_sandbox\n\nserver/sandbox_list.go: No error on filtered list find by ID","distinct":true,"url":"https://api.github.com/repos/cevich/cri-o/commits/c2b7f37bd3cca3dc263d2557d8aa488b2349a047"},{"sha":"12ce3ba3ed46293588c51385440cfaf4879fd2e5","author":{"name":"Antonio Murdaca","email":"d300d9d102629097aeb4a9769819a73ce4b404d4@users.noreply.github.com"},"message":"Merge pull request #1030 from mrunalp/move_crio_sock\n\nMove crio default sock to /var/run/crio/crio.sock","distinct":true,"url":"https://api.github.com/repos/cevich/cri-o/commits/12ce3ba3ed46293588c51385440cfaf4879fd2e5"},{"sha":"d91877dbb2e69657b693f53ef120fb62a1557f95","author":{"name":"Antonio Murdaca","email":"d300d9d102629097aeb4a9769819a73ce4b404d4@redhat.com"},"message":"contrib: test: fix e2e cmdline\n\nSigned-off-by: Antonio Murdaca <runcom@redhat.com>","distinct":true,"url":"https://api.github.com/repos/cevich/cri-o/commits/d91877dbb2e69657b693f53ef120fb62a1557f95"},{"sha":"3be3936d7df0e4d33851a77dfa597b3ebbc74a2b","author":{"name":"Mrunal Patel","email":"3749181c8fc9d2106630e3138faa95426281eb12@me.com"},"message":"Merge pull request #1041 from runcom/fix-e2e\n\ncontrib: test: fix e2e cmdline","distinct":true,"url":"https://api.github.com/repos/cevich/cri-o/commits/3be3936d7df0e4d33851a77dfa597b3ebbc74a2b"},{"sha":"7a684df0d40e107d912567cd36ac53ef56adbed2","author":{"name":"Chris Evich","email":"f4df562e502d11ed41f31ebce94a2b17597121e1@redhat.com"},"message":"Update all packages before installing new ones\n\nEvery now and again, a host will be in an initial state that prevents\ninstalling new packages due to existing packages having some script or\nobsoletes problem.  Avoid this by first updating all packages, then\ninstalling new ones.\n\nSigned-off-by: Chris Evich <cevich@redhat.com>","distinct":true,"url":"https://api.github.com/repos/cevich/cri-o/commits/7a684df0d40e107d912567cd36ac53ef56adbed2"},{"sha":"796bddc6c44e76457e384c655d29c3065d3551ca","author":{"name":"Chris Evich","email":"f4df562e502d11ed41f31ebce94a2b17597121e1@redhat.com"},"message":"Support testing against remote subjects.\n\nIt's a severe anti-pattern for a playbook to assume execution always\non a specific host.  The normal/expected pattern is to execute from a\n\"control host\", against an inventory of (possibly-remote) subjects.\n\nThis doesn't preclude the inventory from only ever containing\n'localhost', it simply means the plays and tasks should not assume\nthe inventory contents.\n\nThis concept is one of the central design-pillars of Ansible's,\nand tantamount to it's usefulness and flexibility.  However, in\npractice (and by ``integration/readme.md``), plays\nspecify ``- hosts: all`` but assume inventory_hostname == 'localhost'\n(always).\n\nFix both the playbooks and ``readme.md`` to remove this anti-pattern,\nwhile also allowing the control-host to be the subject-host as needed.\nThis is accomplished by ensuring low-level Ansible dependencies are\nalways installed, and writing tasks for steps previously performed\nexternally (in the CI/automation machinery).\n\nAlso update ``readme.md`` to recommend execution occurs through\nthe ``venv-ansible-playbook.sh`` wrapper to ensure consistent, stable,\nversion-locked execution dependencies on the control-host.\n\nRemove ``remote_user: root`` from main, since this is better left\nto the inventory and command-line.\n\nSigned-off-by: Chris Evich <cevich@redhat.com>","distinct":true,"url":"https://api.github.com/repos/cevich/cri-o/commits/796bddc6c44e76457e384c655d29c3065d3551ca"},{"sha":"2b283c29444dc3c83d2fac39d831ea8e5222b36e","author":{"name":"Chris Evich","email":"f4df562e502d11ed41f31ebce94a2b17597121e1@redhat.com"},"message":"Avoid relying on subject environment-vars\n\nThere are so many ways/places they can change values on the host from\none moment to the next.  Yet as written, the value of ansible_env.GOPATH\nis really only fixed at \"fact gathering\" time.  In other words, the\nenvironment variable can change (even during a play), but won't be\nnoticed until possibly much later.  This can cause very strange things\nto happen which aren't easy to debug.\n\nFix this by using established facts (variables), and continuously\nestablishing them as environment variables.  This way, if/when a task\nfails, the value of the environment will be present w/in the failure\nmessage instead of obscrured by the shell.\n\nSigned-off-by: Chris Evich <cevich@redhat.com>","distinct":true,"url":"https://api.github.com/repos/cevich/cri-o/commits/2b283c29444dc3c83d2fac39d831ea8e5222b36e"},{"sha":"7a256e94f022e72225c7dc9bbd2c0798d905b7e0","author":{"name":"Chris Evich","email":"f4df562e502d11ed41f31ebce94a2b17597121e1@redhat.com"},"message":"Consolidate plays/tasks/tags\n\nSimplify use of play-level tagging on three separate plays (with one\ntask).  Instead, make them all the same play, and apply the tags at\nthe task level instead.\n\nSigned-off-by: Chris Evich <cevich@redhat.com>","distinct":true,"url":"https://api.github.com/repos/cevich/cri-o/commits/7a256e94f022e72225c7dc9bbd2c0798d905b7e0"},{"sha":"dd9f0e62103ddd31674bbe012e7a403a7975caaf","author":{"name":"Chris Evich","email":"f4df562e502d11ed41f31ebce94a2b17597121e1@redhat.com"},"message":"Improve control-host CPU performance\n\nWhen running from a central host, where multiple other playbooks may\nalso be executing, CPU time quickly becomes the scaleability bottleneck.\n\n* Reduce the vars compression level at the cost of network utilization.\nThis assumes the number of vars being transfered back/forth remains\nreasonably low, where there wouldn't be much advantage from higher\ncompression anyway.\n\nAnother enhancement ``ControlPersist`` (for ssh) is apt to fall\nback to opening new connections (slow) for every request under some\nconditions.  This happens if the socket filename is too large (108\ncharacters, including path) - a kernel limitation.\n\nUnfortunately, in cloud environments, auto-assigned VM hostnames tend to\nbe rather large to avoid clashes.  Worse, in a CI environment, the default\nhome-directory path also tends to be lengthy for the same reason.\n\n* Address this by sticking persistent-connection, background socket files\nin '/tmp/cri-o' (avoid %d).  Also remove the username (%r) designation,\nsince this will almost always be the same user anyway.  The tradeoff\nhere is clashes between jobs against the same host (unlikely) and\nweakened security on the control host (less important for CI jobs).\n\nSigned-off-by: Chris Evich <cevich@redhat.com>","distinct":true,"url":"https://api.github.com/repos/cevich/cri-o/commits/dd9f0e62103ddd31674bbe012e7a403a7975caaf"}]}
{"actor":{"display_login":"cevich"}}