{"action":"created","issue":{"url":"https://api.github.com/repos/SoftwareEvolutionProject/2017Group1/issues/1","repository_url":"https://api.github.com/repos/SoftwareEvolutionProject/2017Group1","labels_url":"https://api.github.com/repos/SoftwareEvolutionProject/2017Group1/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/SoftwareEvolutionProject/2017Group1/issues/1/comments","events_url":"https://api.github.com/repos/SoftwareEvolutionProject/2017Group1/issues/1/events","html_url":"https://github.com/SoftwareEvolutionProject/2017Group1/pull/1","id":263643691,"number":1,"title":"STL viewer on frontend+ DevOps","user":{"login":"chraker","id":1367041,"avatar_url":"https://avatars1.githubusercontent.com/u/1367041?v=4","gravatar_id":"","url":"https://api.github.com/users/chraker","html_url":"https://github.com/chraker","followers_url":"https://api.github.com/users/chraker/followers","following_url":"https://api.github.com/users/chraker/following{/other_user}","gists_url":"https://api.github.com/users/chraker/gists{/gist_id}","starred_url":"https://api.github.com/users/chraker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chraker/subscriptions","organizations_url":"https://api.github.com/users/chraker/orgs","repos_url":"https://api.github.com/users/chraker/repos","events_url":"https://api.github.com/users/chraker/events{/privacy}","received_events_url":"https://api.github.com/users/chraker/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-10-07T14:05:08Z","updated_at":"2017-10-07T14:19:16Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/SoftwareEvolutionProject/2017Group1/pulls/1","html_url":"https://github.com/SoftwareEvolutionProject/2017Group1/pull/1","diff_url":"https://github.com/SoftwareEvolutionProject/2017Group1/pull/1.diff","patch_url":"https://github.com/SoftwareEvolutionProject/2017Group1/pull/1.patch"},"body":"# Docker setup\r\nConfigured based on two files:\r\n- **docker-compose.yml** configures 2 containers, one for the DB and one for the backend and frontend to run in that has access to the DB. \r\n- **Dockerfile** specifies the docker image, and derives from the image maven:3.5.0-jdk-8, so maven and java 8 is installed. It further installs make, node and npm.\r\n\r\nTo help the setup a makefile exists with commands to be run in or out of the container for installing, testing, running and so on. Set up the container by `docker-compose up -d --build`. Skip the build option if not needed to save time. Get into a bash shell in the container by `docker exec -it sverea bash`.\r\n\r\n# DevOps\r\n\r\nTravis builds on each push to the repository. If it is to master or develop it further runs sonarqube and pushes it to sonarcloud. Unfortunately _there is an issue scanning typescript files currently_.  Travis further examines every Pull Request.\r\n\r\n- Travis https://travis-ci.org/SoftwareEvolutionProject/2017Group1 \r\n- SonarCloud https://sonarcloud.io/organizations/dat265/projects\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/SoftwareEvolutionProject/2017Group1/issues/comments/334938265","html_url":"https://github.com/SoftwareEvolutionProject/2017Group1/pull/1#issuecomment-334938265","issue_url":"https://api.github.com/repos/SoftwareEvolutionProject/2017Group1/issues/1","id":334938265,"user":{"login":"chraker","id":1367041,"avatar_url":"https://avatars1.githubusercontent.com/u/1367041?v=4","gravatar_id":"","url":"https://api.github.com/users/chraker","html_url":"https://github.com/chraker","followers_url":"https://api.github.com/users/chraker/followers","following_url":"https://api.github.com/users/chraker/following{/other_user}","gists_url":"https://api.github.com/users/chraker/gists{/gist_id}","starred_url":"https://api.github.com/users/chraker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chraker/subscriptions","organizations_url":"https://api.github.com/users/chraker/orgs","repos_url":"https://api.github.com/users/chraker/repos","events_url":"https://api.github.com/users/chraker/events{/privacy}","received_events_url":"https://api.github.com/users/chraker/received_events","type":"User","site_admin":false},"created_at":"2017-10-07T14:19:16Z","updated_at":"2017-10-07T14:19:16Z","author_association":"COLLABORATOR","body":"SonarQube analysis reported 152 issues\n* ![BLOCKER][BLOCKER] 4 blocker\n* ![MAJOR][MAJOR] 130 major\n* ![MINOR][MINOR] 17 minor\n* ![INFO][INFO] 1 info\n\nWatch the comments in this conversation to review them.\n\n#### Top 10 extra issues\n\nNote: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:\n\n1. ![BLOCKER][BLOCKER] [jsc3d.js#L3799](https://github.com/SoftwareEvolutionProject/2017Group1/blob/425e6565807489b1646f67ef1bce5428ebd45482/frontend/web/src/assets/lib/jsc3d/jsc3d.js#L3799): Add the \"let\", \"const\" or \"var\" keyword to this declaration of \"minY\" to make it explicit. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonarcloud.io/coding_rules#rule_key=javascript%3AS2703)\n1. ![BLOCKER][BLOCKER] [jsc3d.js#L3799](https://github.com/SoftwareEvolutionProject/2017Group1/blob/425e6565807489b1646f67ef1bce5428ebd45482/frontend/web/src/assets/lib/jsc3d/jsc3d.js#L3799): Add the \"let\", \"const\" or \"var\" keyword to this declaration of \"minZ\" to make it explicit. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonarcloud.io/coding_rules#rule_key=javascript%3AS2703)\n1. ![BLOCKER][BLOCKER] [jsc3d.js#L3800](https://github.com/SoftwareEvolutionProject/2017Group1/blob/425e6565807489b1646f67ef1bce5428ebd45482/frontend/web/src/assets/lib/jsc3d/jsc3d.js#L3800): Add the \"let\", \"const\" or \"var\" keyword to this declaration of \"maxZ\" to make it explicit. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonarcloud.io/coding_rules#rule_key=javascript%3AS2703)\n1. ![BLOCKER][BLOCKER] [jsc3d.js#L3800](https://github.com/SoftwareEvolutionProject/2017Group1/blob/425e6565807489b1646f67ef1bce5428ebd45482/frontend/web/src/assets/lib/jsc3d/jsc3d.js#L3800): Add the \"let\", \"const\" or \"var\" keyword to this declaration of \"maxY\" to make it explicit. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonarcloud.io/coding_rules#rule_key=javascript%3AS2703)\n1. ![MAJOR][MAJOR] [jsc3d.js#L691](https://github.com/SoftwareEvolutionProject/2017Group1/blob/425e6565807489b1646f67ef1bce5428ebd45482/frontend/web/src/assets/lib/jsc3d/jsc3d.js#L691): TypeError can be thrown as \"info\" might be null or undefined here. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonarcloud.io/coding_rules#rule_key=javascript%3AS2259)\n1. ![MAJOR][MAJOR] [jsc3d.js#L821](https://github.com/SoftwareEvolutionProject/2017Group1/blob/425e6565807489b1646f67ef1bce5428ebd45482/frontend/web/src/assets/lib/jsc3d/jsc3d.js#L821): TypeError can be thrown as \"info\" might be null or undefined here. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonarcloud.io/coding_rules#rule_key=javascript%3AS2259)\n1. ![MAJOR][MAJOR] [jsc3d.js#L1429](https://github.com/SoftwareEvolutionProject/2017Group1/blob/425e6565807489b1646f67ef1bce5428ebd45482/frontend/web/src/assets/lib/jsc3d/jsc3d.js#L1429): Rename \"dest\" as this name is already used in declaration at line 1414. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonarcloud.io/coding_rules#rule_key=javascript%3AS2814)\n1. ![MAJOR][MAJOR] [jsc3d.js#L1429](https://github.com/SoftwareEvolutionProject/2017Group1/blob/425e6565807489b1646f67ef1bce5428ebd45482/frontend/web/src/assets/lib/jsc3d/jsc3d.js#L1429): Rename \"src\" as this name is already used in declaration at line 1414. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonarcloud.io/coding_rules#rule_key=javascript%3AS2814)\n1. ![MAJOR][MAJOR] [jsc3d.js#L1430](https://github.com/SoftwareEvolutionProject/2017Group1/blob/425e6565807489b1646f67ef1bce5428ebd45482/frontend/web/src/assets/lib/jsc3d/jsc3d.js#L1430): Rename \"i\" as this name is already used in declaration at line 1415. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonarcloud.io/coding_rules#rule_key=javascript%3AS2814)\n1. ![MAJOR][MAJOR] [jsc3d.js#L1431](https://github.com/SoftwareEvolutionProject/2017Group1/blob/425e6565807489b1646f67ef1bce5428ebd45482/frontend/web/src/assets/lib/jsc3d/jsc3d.js#L1431): Rename \"j\" as this name is already used in declaration at line 1416. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonarcloud.io/coding_rules#rule_key=javascript%3AS2814)\n\n[BLOCKER]: https://sonarsource.github.io/sonar-github/severity-blocker.png 'Severity: BLOCKER'\n[INFO]: https://sonarsource.github.io/sonar-github/severity-info.png 'Severity: INFO'\n[MAJOR]: https://sonarsource.github.io/sonar-github/severity-major.png 'Severity: MAJOR'\n[MINOR]: https://sonarsource.github.io/sonar-github/severity-minor.png 'Severity: MINOR'"}}
{"actor":{"display_login":"chraker"}}