{"action":"created","issue":{"url":"https://api.github.com/repos/apache/samza/issues/108","repository_url":"https://api.github.com/repos/apache/samza","labels_url":"https://api.github.com/repos/apache/samza/issues/108/labels{/name}","comments_url":"https://api.github.com/repos/apache/samza/issues/108/comments","events_url":"https://api.github.com/repos/apache/samza/issues/108/events","html_url":"https://github.com/apache/samza/pull/108","id":219069899,"number":108,"title":"SAMZA-1183: Fix flaky tests in TestAsyncRunLoop","user":{"login":"shanthoosh","id":483745,"avatar_url":"https://avatars1.githubusercontent.com/u/483745?v=3","gravatar_id":"","url":"https://api.github.com/users/shanthoosh","html_url":"https://github.com/shanthoosh","followers_url":"https://api.github.com/users/shanthoosh/followers","following_url":"https://api.github.com/users/shanthoosh/following{/other_user}","gists_url":"https://api.github.com/users/shanthoosh/gists{/gist_id}","starred_url":"https://api.github.com/users/shanthoosh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shanthoosh/subscriptions","organizations_url":"https://api.github.com/users/shanthoosh/orgs","repos_url":"https://api.github.com/users/shanthoosh/repos","events_url":"https://api.github.com/users/shanthoosh/events{/privacy}","received_events_url":"https://api.github.com/users/shanthoosh/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2017-04-03T21:40:07Z","updated_at":"2017-04-07T00:03:35Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/samza/pulls/108","html_url":"https://github.com/apache/samza/pull/108","diff_url":"https://github.com/apache/samza/pull/108.diff","patch_url":"https://github.com/apache/samza/pull/108.patch"},"body":"Changes:\r\n\r\n* Moved all states locally within the test methods(no global state, since tests can be run parallely).\r\n* Increased the timeout waiting for all task threads to finish.\r\n* Changed message chooser mock to return null at the end(When EOS message is used a final msg, during some runs task.process gets invoked more than once for it. This is due to test setup, other tests within this test class also do the same.)\r\n\r\nHow was it verified: \r\n\r\nRan the test class repeatedly to check for failures(there were none) using following script.\r\n\r\n`\r\nwhile [ $i -lt 30 ] do     sleep 3;     i=`expr $i + 1`;     ./gradlew :samza-core:clean :samza-core:test -Dtest.single=TestAsyncRunLoop  done\r\n`\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/apache/samza/issues/comments/292368850","html_url":"https://github.com/apache/samza/pull/108#issuecomment-292368850","issue_url":"https://api.github.com/repos/apache/samza/issues/108","id":292368850,"user":{"login":"shanthoosh","id":483745,"avatar_url":"https://avatars1.githubusercontent.com/u/483745?v=3","gravatar_id":"","url":"https://api.github.com/users/shanthoosh","html_url":"https://github.com/shanthoosh","followers_url":"https://api.github.com/users/shanthoosh/followers","following_url":"https://api.github.com/users/shanthoosh/following{/other_user}","gists_url":"https://api.github.com/users/shanthoosh/gists{/gist_id}","starred_url":"https://api.github.com/users/shanthoosh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shanthoosh/subscriptions","organizations_url":"https://api.github.com/users/shanthoosh/orgs","repos_url":"https://api.github.com/users/shanthoosh/repos","events_url":"https://api.github.com/users/shanthoosh/events{/privacy}","received_events_url":"https://api.github.com/users/shanthoosh/received_events","type":"User","site_admin":false},"created_at":"2017-04-07T00:03:35Z","updated_at":"2017-04-07T00:03:35Z","body":"@xinyuiscool  Removed physical wait(Thread.sleep) from TestAsyncRunLoop. Build is red due to  TestJmxReporter failures(unrelated to this change)"}}
{"actor":{"display_login":"shanthoosh"}}