{"action":"created","issue":{"url":"https://api.github.com/repos/nfantone/mu-koan/issues/31","repository_url":"https://api.github.com/repos/nfantone/mu-koan","labels_url":"https://api.github.com/repos/nfantone/mu-koan/issues/31/labels{/name}","comments_url":"https://api.github.com/repos/nfantone/mu-koan/issues/31/comments","events_url":"https://api.github.com/repos/nfantone/mu-koan/issues/31/events","html_url":"https://github.com/nfantone/mu-koan/pull/31","id":253344702,"number":31,"title":"Update should to the latest version 🚀","user":{"login":"greenkeeper[bot]","id":23040076,"avatar_url":"https://avatars2.githubusercontent.com/u/13812225?v=4","gravatar_id":"","url":"https://api.github.com/users/greenkeeper%5Bbot%5D","html_url":"https://github.com/apps/greenkeeper","followers_url":"https://api.github.com/users/greenkeeper%5Bbot%5D/followers","following_url":"https://api.github.com/users/greenkeeper%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/greenkeeper%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/greenkeeper%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenkeeper%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/greenkeeper%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/greenkeeper%5Bbot%5D/repos","events_url":"https://api.github.com/users/greenkeeper%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/greenkeeper%5Bbot%5D/received_events","type":"Bot","site_admin":false},"labels":[{"id":384801657,"url":"https://api.github.com/repos/nfantone/mu-koan/labels/greenkeeper","name":"greenkeeper","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-08-28T14:22:16Z","updated_at":"2017-09-20T14:27:05Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/nfantone/mu-koan/pulls/31","html_url":"https://github.com/nfantone/mu-koan/pull/31","diff_url":"https://github.com/nfantone/mu-koan/pull/31.diff","patch_url":"https://github.com/nfantone/mu-koan/pull/31.patch"},"body":"\n## Version **12.0.0** of [should](https://github.com/shouldjs/should.js) just got published.\n\n<table>\n  <tr>\n    <th align=left>\n      Dependency\n    </td>\n    <td>\n      should\n    </td>\n  </tr>\n  <tr>\n    <th align=left>\n      Current Version\n    </td>\n    <td>\n      11.2.1\n    </td>\n  </tr>\n  <tr>\n    <th align=left>\n      Type\n    </td>\n    <td>\n      devDependency\n    </td>\n  </tr>\n</table>\n\nThe version **12.0.0** is **not covered** by your **current version range**.\n\nWithout accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.\n\nI recommend you look into these changes and try to get onto the latest version of should.\nGiven that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.\n\n\n---\n\n\n<details>\n<summary>Release Notes</summary>\n<strong>Better Map Set equality</strong>\n\n<h1>Map/Set/WeakMap/WeakSet equality checks</h1>\n<p>User <a href=\"https://urls.greenkeeper.io/bridgear\" class=\"user-mention\">@BridgeAR</a> pointed to a number of bugs and inconcistency in Map/Set/WeakMap/WeakSet checks. To fix all this things, i switched map and set equality checks to do key checks defined in standard instead of value checks.<br>\nTypical example that was working before this release:</p>\n<div class=\"highlight highlight-source-js\"><pre><span class=\"pl-k\">const</span> <span class=\"pl-c1\">m1</span> <span class=\"pl-k\">=</span> <span class=\"pl-k\">new</span> <span class=\"pl-en\">Map</span>([[{ a<span class=\"pl-k\">:</span> <span class=\"pl-c1\">1</span> }, <span class=\"pl-c1\">11</span>]]);\n<span class=\"pl-k\">const</span> <span class=\"pl-c1\">m2</span> <span class=\"pl-k\">=</span> <span class=\"pl-k\">new</span> <span class=\"pl-en\">Map</span>([[{ a<span class=\"pl-k\">:</span> <span class=\"pl-c1\">1</span> }, <span class=\"pl-c1\">11</span>]]);\n\n<span class=\"pl-smi\">m1</span>.<span class=\"pl-smi\">should</span>.<span class=\"pl-smi\">be</span>.<span class=\"pl-en\">eql</span>(m2)</pre></div>\n<p>And not this example is breaking. At first view it is a bit unclear why it should not be so. Consider another example:</p>\n<div class=\"highlight highlight-source-js\"><pre><span class=\"pl-k\">const</span> <span class=\"pl-c1\">m1</span> <span class=\"pl-k\">=</span> <span class=\"pl-k\">new</span> <span class=\"pl-en\">Map</span>([[{}, <span class=\"pl-c1\">11</span>], [{}, <span class=\"pl-c1\">12</span>]]);\n<span class=\"pl-k\">const</span> <span class=\"pl-c1\">m2</span> <span class=\"pl-k\">=</span> <span class=\"pl-k\">new</span> <span class=\"pl-en\">Map</span>([[{}, <span class=\"pl-c1\">11</span>], [{}, <span class=\"pl-c1\">12</span>]]);\n\n<span class=\"pl-smi\">m1</span>.<span class=\"pl-smi\">should</span>.<span class=\"pl-smi\">be</span>.<span class=\"pl-en\">eql</span>(m2)</pre></div>\n<p>This example is not that clear if it should assert or not, right? (it should).</p>\n<p>As Map and Set (as their weak equavalents) allows to use any type value/ref as key, perfectly equal by value (what should.js do) {} and {} is not equal by reference. In should.js i am always trying to limit users to do not shoot themselfs in their foots and just do right thing if possible and when possible. <strong>That is why both examples will throw assertions starting 12.0.0.</strong></p>\n<h1>Consistency in bundles</h1>\n<p>For the long time (probably several years now) browser bundle and node bundle has little differences in globals.<br>\nTo make them sync i am doing such changes to bundles:</p>\n<ol>\n<li>Browser bundle will not contain <code>window.Should</code> any more (with capital <strong>S</strong>). It was deprecated for the long time. Just use <code>window.should</code> as is.</li>\n<li>Node bundle change <code>global.should</code> to be should function instead of getter attached to <code>Object.prototype</code>.</li>\n</ol>\n</details>\n\n<details>\n<summary>Commits</summary>\n<p>The new version differs by 12 commits.</p>\n<ul>\n<li><a href=\"https://urls.greenkeeper.io/shouldjs/should.js/commit/52dc12106892a83f8ab10f5733449fd51703537b\"><code>52dc121</code></a> <code>Release 12.0.0</code></li>\n<li><a href=\"https://urls.greenkeeper.io/shouldjs/should.js/commit/6c1e6bdcf502af4ac8748b84764f08fbb9b49f62\"><code>6c1e6bd</code></a> <code>Prettier all</code></li>\n<li><a href=\"https://urls.greenkeeper.io/shouldjs/should.js/commit/6114e7695d9cdff8d39c09a65ce8d5f86a6a6285\"><code>6114e76</code></a> <code>Update years</code></li>\n<li><a href=\"https://urls.greenkeeper.io/shouldjs/should.js/commit/670df309ff44d6206a08c418002fdd063deda7d6\"><code>670df30</code></a> <code>Merge branch 'master' of github.com:shouldjs/should.js</code></li>\n<li><a href=\"https://urls.greenkeeper.io/shouldjs/should.js/commit/ecf80336b360649ff85a14b3cfdc181880233f27\"><code>ecf8033</code></a> <code>Update tools</code></li>\n<li><a href=\"https://urls.greenkeeper.io/shouldjs/should.js/commit/e4d0acc280bda611b6450738cf3138c3792bb4c8\"><code>e4d0acc</code></a> <code>Normalize entry points</code></li>\n<li><a href=\"https://urls.greenkeeper.io/shouldjs/should.js/commit/f4adabbac4e437d3c1605f63f6ab82f9f2668958\"><code>f4adabb</code></a> <code>Set zuul to use 2 last versions of browsers</code></li>\n<li><a href=\"https://urls.greenkeeper.io/shouldjs/should.js/commit/8114b5d2fa5ea0684603400136a1e2076a7de946\"><code>8114b5d</code></a> <code>Merge pull request #143 from isayme/issue/aboveOrEqual-belowOrEqual</code></li>\n<li><a href=\"https://urls.greenkeeper.io/shouldjs/should.js/commit/02ec6a0c571fb3a6035f456160f1fe30eb92f251\"><code>02ec6a0</code></a> <code>fix error message for aboveOrEqual &amp; belowOrEqual</code></li>\n<li><a href=\"https://urls.greenkeeper.io/shouldjs/should.js/commit/031888e0aeab6ad0f58b6964efe0803e17e7794f\"><code>031888e</code></a> <code>Merge pull request #140 from carldunham/feature/cd/add-equals-eqls</code></li>\n<li><a href=\"https://urls.greenkeeper.io/shouldjs/should.js/commit/1e4909bfdb2b13dc2548d349b5c33e1ce7f8e906\"><code>1e4909b</code></a> <code>Add for readability: equals, eqls</code></li>\n<li><a href=\"https://urls.greenkeeper.io/shouldjs/should.js/commit/4a53d947b84c39dc516f27e0ad4d7d944e69fe1e\"><code>4a53d94</code></a> <code>Release 11.2.1</code></li>\n</ul>\n<p>See the <a href=\"https://urls.greenkeeper.io/shouldjs/should.js/compare/52b984f2c9212278091f9570cf2fe4d6bb79396f...52dc12106892a83f8ab10f5733449fd51703537b\">full diff</a></p>\n</details>\n\n<details>\n  <summary>Not sure how things should work exactly?</summary>\n\n  There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html) and of course you may always [ask my humans](https://github.com/greenkeeperio/greenkeeper/issues/new).\n</details>\n\n\n---\n\n\nYour [Greenkeeper](https://greenkeeper.io) Bot :palm_tree:\n\n"},"comment":{"url":"https://api.github.com/repos/nfantone/mu-koan/issues/comments/330868780","html_url":"https://github.com/nfantone/mu-koan/pull/31#issuecomment-330868780","issue_url":"https://api.github.com/repos/nfantone/mu-koan/issues/31","id":330868780,"user":{"login":"greenkeeper[bot]","id":23040076,"avatar_url":"https://avatars2.githubusercontent.com/u/13812225?v=4","gravatar_id":"","url":"https://api.github.com/users/greenkeeper%5Bbot%5D","html_url":"https://github.com/apps/greenkeeper","followers_url":"https://api.github.com/users/greenkeeper%5Bbot%5D/followers","following_url":"https://api.github.com/users/greenkeeper%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/greenkeeper%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/greenkeeper%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenkeeper%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/greenkeeper%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/greenkeeper%5Bbot%5D/repos","events_url":"https://api.github.com/users/greenkeeper%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/greenkeeper%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2017-09-20T14:27:05Z","updated_at":"2017-09-20T14:27:05Z","author_association":"NONE","body":"## Version **13.1.0** just got published. \n[Update to this version instead 🚀](https://github.com/nfantone/mu-koan/compare/greenkeeper%2Fshould-13.1.0?expand=1) \n\n<details>\n<summary>Release Notes</summary>\n<strong>13.1.0</strong>\n\n<h1>New</h1>\n<ol>\n<li>Now all zero argument assertions throw <code>TypeError</code> in case any argument passed to them.</li>\n<li>Aliased <code>.fulfill</code>/<code>.fulfilledWith</code> to <code>.resolve</code>/.resolvedWith`</li>\n</ol>\n<h1>Fixes</h1>\n<ol>\n<li>TS definition fixed to allow such imports:</li>\n</ol>\n<div class=\"highlight highlight-source-ts\"><pre><span class=\"pl-k\">import</span> <span class=\"pl-smi\">should</span> <span class=\"pl-k\">from</span> <span class=\"pl-s\"><span class=\"pl-pds\">'</span>should<span class=\"pl-pds\">'</span></span>;</pre></div>\n</details>\n\n<details>\n<summary>Commits</summary>\n<p>The new version differs by 6 commits.</p>\n<ul>\n<li><a href=\"https://urls.greenkeeper.io/shouldjs/should.js/commit/c807e9df2e281f063c88f7af8c4f015cbc062612\"><code>c807e9d</code></a> <code>Release 13.1.0</code></li>\n<li><a href=\"https://urls.greenkeeper.io/shouldjs/should.js/commit/8acfba1f8b7355cb944e1c71b1b577255afa5312\"><code>8acfba1</code></a> <code>Merge pull request #154 from citizensas/master</code></li>\n<li><a href=\"https://urls.greenkeeper.io/shouldjs/should.js/commit/c12afd0e64ee47fe69690320c56a1fb7e8076e2f\"><code>c12afd0</code></a> <code>chore: should has no default export</code></li>\n<li><a href=\"https://urls.greenkeeper.io/shouldjs/should.js/commit/4a846b1886e0677199b8aa5c789a1fcb22e8b75b\"><code>4a846b1</code></a> <code>Fill history</code></li>\n<li><a href=\"https://urls.greenkeeper.io/shouldjs/should.js/commit/f5c9cc3c44635a03185bf4ea77720a7cb441b365\"><code>f5c9cc3</code></a> <code>Added check for zero argument assertions.</code></li>\n<li><a href=\"https://urls.greenkeeper.io/shouldjs/should.js/commit/fe6b1360b01a6b030ceec3cea1c425e2f6868367\"><code>fe6b136</code></a> <code>Added .resolved, .resolvedWith as aliases to .fulfilled, .fulfilledWith</code></li>\n</ul>\n<p>See the <a href=\"https://urls.greenkeeper.io/shouldjs/should.js/compare/e90c2cfb3c551986e5157f6ccc70f451722ef52d...c807e9df2e281f063c88f7af8c4f015cbc062612\">full diff</a></p>\n</details>"}}
{"actor":{"display_login":"greenkeeper"}}