{"action":"created","comment":{"url":"https://api.github.com/repos/yiisoft/yii2/pulls/comments/159124573","pull_request_review_id":86032477,"id":159124573,"diff_hunk":"@@ -92,7 +92,7 @@ public function validateAttribute($model, $attribute)\n     {\n         $targetAttribute = $this->targetAttribute === null ? $attribute : $this->targetAttribute;\n         $params = $this->prepareConditions($targetAttribute, $model, $attribute);\n-        $conditions[] = $this->targetAttributeJunction == 'or' ? 'or' : 'and';\n+        $conditions = [ $this->targetAttributeJunction == 'or' ? 'or' : 'and' ];","path":"framework/validators/ExistValidator.php","position":5,"original_position":5,"commit_id":"bdf8676ef402ee623e7c60e4a5d82396070eb1ec","original_commit_id":"bdf8676ef402ee623e7c60e4a5d82396070eb1ec","user":{"login":"vkhramtsov","id":5517373,"avatar_url":"https://avatars2.githubusercontent.com/u/5517373?v=4","gravatar_id":"","url":"https://api.github.com/users/vkhramtsov","html_url":"https://github.com/vkhramtsov","followers_url":"https://api.github.com/users/vkhramtsov/followers","following_url":"https://api.github.com/users/vkhramtsov/following{/other_user}","gists_url":"https://api.github.com/users/vkhramtsov/gists{/gist_id}","starred_url":"https://api.github.com/users/vkhramtsov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vkhramtsov/subscriptions","organizations_url":"https://api.github.com/users/vkhramtsov/orgs","repos_url":"https://api.github.com/users/vkhramtsov/repos","events_url":"https://api.github.com/users/vkhramtsov/events{/privacy}","received_events_url":"https://api.github.com/users/vkhramtsov/received_events","type":"User","site_admin":false},"body":"Just want to fix [scrunitizer issue](https://scrutinizer-ci.com/g/yiisoft/yii2/issues/master/files/framework/validators/ExistValidator.php?selectedLabels%5B0%5D=3&selectedLabels%5B1%5D=10&orderField=path&order=asc&honorSelectedPaths=0)","created_at":"2017-12-30T16:01:21Z","updated_at":"2017-12-30T16:01:21Z","html_url":"https://github.com/yiisoft/yii2/pull/15435#discussion_r159124573","pull_request_url":"https://api.github.com/repos/yiisoft/yii2/pulls/15435","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/yiisoft/yii2/pulls/comments/159124573"},"html":{"href":"https://github.com/yiisoft/yii2/pull/15435#discussion_r159124573"},"pull_request":{"href":"https://api.github.com/repos/yiisoft/yii2/pulls/15435"}},"in_reply_to_id":159121053},"pull_request":{"url":"https://api.github.com/repos/yiisoft/yii2/pulls/15435","id":160584697,"html_url":"https://github.com/yiisoft/yii2/pull/15435","diff_url":"https://github.com/yiisoft/yii2/pull/15435.diff","patch_url":"https://github.com/yiisoft/yii2/pull/15435.patch","issue_url":"https://api.github.com/repos/yiisoft/yii2/issues/15435","number":15435,"state":"open","locked":false,"title":"Fix code issues","user":{"login":"vkhramtsov","id":5517373,"avatar_url":"https://avatars2.githubusercontent.com/u/5517373?v=4","gravatar_id":"","url":"https://api.github.com/users/vkhramtsov","html_url":"https://github.com/vkhramtsov","followers_url":"https://api.github.com/users/vkhramtsov/followers","following_url":"https://api.github.com/users/vkhramtsov/following{/other_user}","gists_url":"https://api.github.com/users/vkhramtsov/gists{/gist_id}","starred_url":"https://api.github.com/users/vkhramtsov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vkhramtsov/subscriptions","organizations_url":"https://api.github.com/users/vkhramtsov/orgs","repos_url":"https://api.github.com/users/vkhramtsov/repos","events_url":"https://api.github.com/users/vkhramtsov/events{/privacy}","received_events_url":"https://api.github.com/users/vkhramtsov/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Is bugfix?    | possible\r\n| New feature?  | no\r\n| Breaks BC?    | no\r\n| Tests pass?   | yes\r\n| Fixed issues  | fix some  scrutinizer warnings, remove obsolete require\r\n","created_at":"2017-12-30T09:45:07Z","updated_at":"2017-12-30T16:01:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"482ff38df5e84b572215aa70c695e7434eda1a85","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/yiisoft/yii2/pulls/15435/commits","review_comments_url":"https://api.github.com/repos/yiisoft/yii2/pulls/15435/comments","review_comment_url":"https://api.github.com/repos/yiisoft/yii2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yiisoft/yii2/issues/15435/comments","statuses_url":"https://api.github.com/repos/yiisoft/yii2/statuses/bdf8676ef402ee623e7c60e4a5d82396070eb1ec","head":{"label":"vkhramtsov:fix-code-issues","ref":"fix-code-issues","sha":"bdf8676ef402ee623e7c60e4a5d82396070eb1ec","user":{"login":"vkhramtsov","id":5517373,"avatar_url":"https://avatars2.githubusercontent.com/u/5517373?v=4","gravatar_id":"","url":"https://api.github.com/users/vkhramtsov","html_url":"https://github.com/vkhramtsov","followers_url":"https://api.github.com/users/vkhramtsov/followers","following_url":"https://api.github.com/users/vkhramtsov/following{/other_user}","gists_url":"https://api.github.com/users/vkhramtsov/gists{/gist_id}","starred_url":"https://api.github.com/users/vkhramtsov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vkhramtsov/subscriptions","organizations_url":"https://api.github.com/users/vkhramtsov/orgs","repos_url":"https://api.github.com/users/vkhramtsov/repos","events_url":"https://api.github.com/users/vkhramtsov/events{/privacy}","received_events_url":"https://api.github.com/users/vkhramtsov/received_events","type":"User","site_admin":false},"repo":{"id":115644336,"name":"yii2","full_name":"vkhramtsov/yii2","owner":{"login":"vkhramtsov","id":5517373,"avatar_url":"https://avatars2.githubusercontent.com/u/5517373?v=4","gravatar_id":"","url":"https://api.github.com/users/vkhramtsov","html_url":"https://github.com/vkhramtsov","followers_url":"https://api.github.com/users/vkhramtsov/followers","following_url":"https://api.github.com/users/vkhramtsov/following{/other_user}","gists_url":"https://api.github.com/users/vkhramtsov/gists{/gist_id}","starred_url":"https://api.github.com/users/vkhramtsov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vkhramtsov/subscriptions","organizations_url":"https://api.github.com/users/vkhramtsov/orgs","repos_url":"https://api.github.com/users/vkhramtsov/repos","events_url":"https://api.github.com/users/vkhramtsov/events{/privacy}","received_events_url":"https://api.github.com/users/vkhramtsov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vkhramtsov/yii2","description":"Yii 2: The Fast, Secure and Professional PHP Framework","fork":true,"url":"https://api.github.com/repos/vkhramtsov/yii2","forks_url":"https://api.github.com/repos/vkhramtsov/yii2/forks","keys_url":"https://api.github.com/repos/vkhramtsov/yii2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vkhramtsov/yii2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vkhramtsov/yii2/teams","hooks_url":"https://api.github.com/repos/vkhramtsov/yii2/hooks","issue_events_url":"https://api.github.com/repos/vkhramtsov/yii2/issues/events{/number}","events_url":"https://api.github.com/repos/vkhramtsov/yii2/events","assignees_url":"https://api.github.com/repos/vkhramtsov/yii2/assignees{/user}","branches_url":"https://api.github.com/repos/vkhramtsov/yii2/branches{/branch}","tags_url":"https://api.github.com/repos/vkhramtsov/yii2/tags","blobs_url":"https://api.github.com/repos/vkhramtsov/yii2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vkhramtsov/yii2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vkhramtsov/yii2/git/refs{/sha}","trees_url":"https://api.github.com/repos/vkhramtsov/yii2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vkhramtsov/yii2/statuses/{sha}","languages_url":"https://api.github.com/repos/vkhramtsov/yii2/languages","stargazers_url":"https://api.github.com/repos/vkhramtsov/yii2/stargazers","contributors_url":"https://api.github.com/repos/vkhramtsov/yii2/contributors","subscribers_url":"https://api.github.com/repos/vkhramtsov/yii2/subscribers","subscription_url":"https://api.github.com/repos/vkhramtsov/yii2/subscription","commits_url":"https://api.github.com/repos/vkhramtsov/yii2/commits{/sha}","git_commits_url":"https://api.github.com/repos/vkhramtsov/yii2/git/commits{/sha}","comments_url":"https://api.github.com/repos/vkhramtsov/yii2/comments{/number}","issue_comment_url":"https://api.github.com/repos/vkhramtsov/yii2/issues/comments{/number}","contents_url":"https://api.github.com/repos/vkhramtsov/yii2/contents/{+path}","compare_url":"https://api.github.com/repos/vkhramtsov/yii2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vkhramtsov/yii2/merges","archive_url":"https://api.github.com/repos/vkhramtsov/yii2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vkhramtsov/yii2/downloads","issues_url":"https://api.github.com/repos/vkhramtsov/yii2/issues{/number}","pulls_url":"https://api.github.com/repos/vkhramtsov/yii2/pulls{/number}","milestones_url":"https://api.github.com/repos/vkhramtsov/yii2/milestones{/number}","notifications_url":"https://api.github.com/repos/vkhramtsov/yii2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vkhramtsov/yii2/labels{/name}","releases_url":"https://api.github.com/repos/vkhramtsov/yii2/releases{/id}","deployments_url":"https://api.github.com/repos/vkhramtsov/yii2/deployments","created_at":"2017-12-28T17:14:32Z","updated_at":"2017-12-28T17:14:38Z","pushed_at":"2017-12-30T10:10:00Z","git_url":"git://github.com/vkhramtsov/yii2.git","ssh_url":"git@github.com:vkhramtsov/yii2.git","clone_url":"https://github.com/vkhramtsov/yii2.git","svn_url":"https://github.com/vkhramtsov/yii2","homepage":"http://www.yiiframework.com","size":74683,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yiisoft:master","ref":"master","sha":"c501e3fde8ec7a92ac9bcbde21a92cd89fbf05d2","user":{"login":"yiisoft","id":993323,"avatar_url":"https://avatars3.githubusercontent.com/u/993323?v=4","gravatar_id":"","url":"https://api.github.com/users/yiisoft","html_url":"https://github.com/yiisoft","followers_url":"https://api.github.com/users/yiisoft/followers","following_url":"https://api.github.com/users/yiisoft/following{/other_user}","gists_url":"https://api.github.com/users/yiisoft/gists{/gist_id}","starred_url":"https://api.github.com/users/yiisoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yiisoft/subscriptions","organizations_url":"https://api.github.com/users/yiisoft/orgs","repos_url":"https://api.github.com/users/yiisoft/repos","events_url":"https://api.github.com/users/yiisoft/events{/privacy}","received_events_url":"https://api.github.com/users/yiisoft/received_events","type":"Organization","site_admin":false},"repo":{"id":3431193,"name":"yii2","full_name":"yiisoft/yii2","owner":{"login":"yiisoft","id":993323,"avatar_url":"https://avatars3.githubusercontent.com/u/993323?v=4","gravatar_id":"","url":"https://api.github.com/users/yiisoft","html_url":"https://github.com/yiisoft","followers_url":"https://api.github.com/users/yiisoft/followers","following_url":"https://api.github.com/users/yiisoft/following{/other_user}","gists_url":"https://api.github.com/users/yiisoft/gists{/gist_id}","starred_url":"https://api.github.com/users/yiisoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yiisoft/subscriptions","organizations_url":"https://api.github.com/users/yiisoft/orgs","repos_url":"https://api.github.com/users/yiisoft/repos","events_url":"https://api.github.com/users/yiisoft/events{/privacy}","received_events_url":"https://api.github.com/users/yiisoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yiisoft/yii2","description":"Yii 2: The Fast, Secure and Professional PHP Framework","fork":false,"url":"https://api.github.com/repos/yiisoft/yii2","forks_url":"https://api.github.com/repos/yiisoft/yii2/forks","keys_url":"https://api.github.com/repos/yiisoft/yii2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yiisoft/yii2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yiisoft/yii2/teams","hooks_url":"https://api.github.com/repos/yiisoft/yii2/hooks","issue_events_url":"https://api.github.com/repos/yiisoft/yii2/issues/events{/number}","events_url":"https://api.github.com/repos/yiisoft/yii2/events","assignees_url":"https://api.github.com/repos/yiisoft/yii2/assignees{/user}","branches_url":"https://api.github.com/repos/yiisoft/yii2/branches{/branch}","tags_url":"https://api.github.com/repos/yiisoft/yii2/tags","blobs_url":"https://api.github.com/repos/yiisoft/yii2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yiisoft/yii2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yiisoft/yii2/git/refs{/sha}","trees_url":"https://api.github.com/repos/yiisoft/yii2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yiisoft/yii2/statuses/{sha}","languages_url":"https://api.github.com/repos/yiisoft/yii2/languages","stargazers_url":"https://api.github.com/repos/yiisoft/yii2/stargazers","contributors_url":"https://api.github.com/repos/yiisoft/yii2/contributors","subscribers_url":"https://api.github.com/repos/yiisoft/yii2/subscribers","subscription_url":"https://api.github.com/repos/yiisoft/yii2/subscription","commits_url":"https://api.github.com/repos/yiisoft/yii2/commits{/sha}","git_commits_url":"https://api.github.com/repos/yiisoft/yii2/git/commits{/sha}","comments_url":"https://api.github.com/repos/yiisoft/yii2/comments{/number}","issue_comment_url":"https://api.github.com/repos/yiisoft/yii2/issues/comments{/number}","contents_url":"https://api.github.com/repos/yiisoft/yii2/contents/{+path}","compare_url":"https://api.github.com/repos/yiisoft/yii2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yiisoft/yii2/merges","archive_url":"https://api.github.com/repos/yiisoft/yii2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yiisoft/yii2/downloads","issues_url":"https://api.github.com/repos/yiisoft/yii2/issues{/number}","pulls_url":"https://api.github.com/repos/yiisoft/yii2/pulls{/number}","milestones_url":"https://api.github.com/repos/yiisoft/yii2/milestones{/number}","notifications_url":"https://api.github.com/repos/yiisoft/yii2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yiisoft/yii2/labels{/name}","releases_url":"https://api.github.com/repos/yiisoft/yii2/releases{/id}","deployments_url":"https://api.github.com/repos/yiisoft/yii2/deployments","created_at":"2012-02-13T15:32:36Z","updated_at":"2017-12-30T13:16:26Z","pushed_at":"2017-12-30T15:57:30Z","git_url":"git://github.com/yiisoft/yii2.git","ssh_url":"git@github.com:yiisoft/yii2.git","clone_url":"https://github.com/yiisoft/yii2.git","svn_url":"https://github.com/yiisoft/yii2","homepage":"http://www.yiiframework.com","size":74752,"stargazers_count":11323,"watchers_count":11323,"language":"PHP","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6180,"mirror_url":null,"archived":false,"open_issues_count":970,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":6180,"open_issues":970,"watchers":11323,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yiisoft/yii2/pulls/15435"},"html":{"href":"https://github.com/yiisoft/yii2/pull/15435"},"issue":{"href":"https://api.github.com/repos/yiisoft/yii2/issues/15435"},"comments":{"href":"https://api.github.com/repos/yiisoft/yii2/issues/15435/comments"},"review_comments":{"href":"https://api.github.com/repos/yiisoft/yii2/pulls/15435/comments"},"review_comment":{"href":"https://api.github.com/repos/yiisoft/yii2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yiisoft/yii2/pulls/15435/commits"},"statuses":{"href":"https://api.github.com/repos/yiisoft/yii2/statuses/bdf8676ef402ee623e7c60e4a5d82396070eb1ec"}},"author_association":"NONE"}}
{"actor":{"display_login":"vkhramtsov"}}