{"action":"created","issue":{"url":"https://api.github.com/repos/interledgerjs/ilp-kit/issues/460","repository_url":"https://api.github.com/repos/interledgerjs/ilp-kit","labels_url":"https://api.github.com/repos/interledgerjs/ilp-kit/issues/460/labels{/name}","comments_url":"https://api.github.com/repos/interledgerjs/ilp-kit/issues/460/comments","events_url":"https://api.github.com/repos/interledgerjs/ilp-kit/issues/460/events","html_url":"https://github.com/interledgerjs/ilp-kit/issues/460","id":247919824,"number":460,"title":"api docs incorrect?","user":{"login":"michielbdejong","id":408412,"avatar_url":"https://avatars2.githubusercontent.com/u/408412?v=4","gravatar_id":"","url":"https://api.github.com/users/michielbdejong","html_url":"https://github.com/michielbdejong","followers_url":"https://api.github.com/users/michielbdejong/followers","following_url":"https://api.github.com/users/michielbdejong/following{/other_user}","gists_url":"https://api.github.com/users/michielbdejong/gists{/gist_id}","starred_url":"https://api.github.com/users/michielbdejong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michielbdejong/subscriptions","organizations_url":"https://api.github.com/users/michielbdejong/orgs","repos_url":"https://api.github.com/users/michielbdejong/repos","events_url":"https://api.github.com/users/michielbdejong/events{/privacy}","received_events_url":"https://api.github.com/users/michielbdejong/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-08-04T07:00:56Z","updated_at":"2017-08-04T09:51:16Z","closed_at":null,"body":"It seems https://interledgerjs.github.io/ilp-kit/apidoc/#api-User-GetUser is incorrect, looking into that. At least, the URL should be /api/users instead of /users, but it only seems to work for the currently logged in user, according to the docs, the admin should be able to get any user's details with that API call. Example:\r\n\r\n```sh\r\nnode\r\n> Buffer.from('admin:iequae9hadoo7ohz4Teequ2uod5Ifei3Oiz4iev2', 'ascii').toString('base64')\r\n'YWRtaW46aWVxdWFlOWhhZG9vN29oejRUZWVxdTJ1b2Q1SWZlaTNPaXo0aWV2Mg=='\r\n> Buffer.from('alice:alice', 'ascii').toString('base64')\r\n'YWxpY2U6YWxpY2U='\r\n>\r\n(To exit, press ^C again or type .exit)\r\n>\r\n[michiel@mbp ~]$ curl -X GET -H \"Authorization: Basic YWRtaW46aWVxdWFlOWhhZG9vN29oejRUZWVxdTJ1b2Q1SWZlaTNPaXo0aWV2Mg==\" https://ilp-kit-master.herokuapp.com/api/users/alice\r\nNot Found[michiel@mbp ~]$\r\n[michiel@mbp ~]$ curl -X GET -H \"Authorization: Basic YWxpY2U6YWxpY2U=\" https://ilp-kit-master.herokuapp.com/api/users/alice\r\n{\"id\":3,\"username\":\"alice\",\"email\":\"alice@yes.com\",\"email_verified\":null,\"github_id\":null,\"destination\":\"940248\",\"profile_picture\":null,\"name\":null,\"phone\":null,\"address1\":null,\"address2\":null,\"city\":null,\"region\":null,\"country\":null,\"zip_code\":null,\"invite_code\":\"10fc3320-55b5-43ea-88c9-e0b4fc903f13\",\"identifier\":\"alice@ilp-kit-master.herokuapp.com\",\"balance\":10,\"minimum_allowed_balance\":\"0\"}[michiel@mbp ~]$\r\n[michiel@mbp ~]$"},"comment":{"url":"https://api.github.com/repos/interledgerjs/ilp-kit/issues/comments/320208086","html_url":"https://github.com/interledgerjs/ilp-kit/issues/460#issuecomment-320208086","issue_url":"https://api.github.com/repos/interledgerjs/ilp-kit/issues/460","id":320208086,"user":{"login":"dappelt","id":23212287,"avatar_url":"https://avatars1.githubusercontent.com/u/23212287?v=4","gravatar_id":"","url":"https://api.github.com/users/dappelt","html_url":"https://github.com/dappelt","followers_url":"https://api.github.com/users/dappelt/followers","following_url":"https://api.github.com/users/dappelt/following{/other_user}","gists_url":"https://api.github.com/users/dappelt/gists{/gist_id}","starred_url":"https://api.github.com/users/dappelt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dappelt/subscriptions","organizations_url":"https://api.github.com/users/dappelt/orgs","repos_url":"https://api.github.com/users/dappelt/repos","events_url":"https://api.github.com/users/dappelt/events{/privacy}","received_events_url":"https://api.github.com/users/dappelt/received_events","type":"User","site_admin":false},"created_at":"2017-08-04T09:51:16Z","updated_at":"2017-08-04T09:51:16Z","body":"> according to the docs, the admin should be able to get any user's details with that API call.\r\n\r\nIf requested by the admin, `/api/users` returns a list of all users. So I think the docs are correct."}}
{"actor":{"display_login":"dappelt"}}