{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments/100520637","pull_request_review_id":21231208,"id":100520637,"diff_hunk":"@@ -46,12 +46,16 @@\n \n   # Replace dc/docker-registry certificate secret contents if set.\n   - block:\n+    - name: Load lib_openshift modules\n+      include_role:\n+      name: lib_openshift\n+\n     - name: Retrieve registry service IP\n-      command: >\n-        {{ openshift.common.client_binary }} get service docker-registry\n-        -o jsonpath='{.spec.clusterIP}'\n-        --config={{ mktemp.stdout }}/admin.kubeconfig\n-        -n default\n+      oc_service:\n+        namespace: default\n+        name: docker-registry\n+        state: list\n+        kubeconfig: \"{{ mktemp.stdout }}/admin.kubeconfig\"","path":"playbooks/common/openshift-cluster/redeploy-certificates/registry.yml","position":18,"original_position":18,"commit_id":"77d59c11f09fa875cb295b4d11c474ecd6809494","original_commit_id":"e0368b2ba70b035ffb3ebfc25e075f06fcd838cf","user":{"login":"ingvagabund","id":8055242,"avatar_url":"https://avatars.githubusercontent.com/u/8055242?v=3","gravatar_id":"","url":"https://api.github.com/users/ingvagabund","html_url":"https://github.com/ingvagabund","followers_url":"https://api.github.com/users/ingvagabund/followers","following_url":"https://api.github.com/users/ingvagabund/following{/other_user}","gists_url":"https://api.github.com/users/ingvagabund/gists{/gist_id}","starred_url":"https://api.github.com/users/ingvagabund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ingvagabund/subscriptions","organizations_url":"https://api.github.com/users/ingvagabund/orgs","repos_url":"https://api.github.com/users/ingvagabund/repos","events_url":"https://api.github.com/users/ingvagabund/events{/privacy}","received_events_url":"https://api.github.com/users/ingvagabund/received_events","type":"User","site_admin":false},"body":"The default value for the ``kubeconfig`` if ``/etc/origin/master/admin.kubeconfig``. Given that, we should add additional check at the beginning of the all play making sure ``{{ openshift.common.config_base }}`` equals ``/etc/origin``. Otherwise the module will most likely fail. Unless a master node has both ``/etc/origin/master/admin.kubeconfig`` and ``/SOMEPATH/origin/master/admin.kubeconfig`` and we want the latter case. In which case it will be very hard to debug.","created_at":"2017-02-10T11:53:33Z","updated_at":"2017-02-10T11:53:33Z","html_url":"https://github.com/openshift/openshift-ansible/pull/3306#discussion_r100520637","pull_request_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/3306","_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments/100520637"},"html":{"href":"https://github.com/openshift/openshift-ansible/pull/3306#discussion_r100520637"},"pull_request":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/3306"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/3306","id":105408794,"html_url":"https://github.com/openshift/openshift-ansible/pull/3306","diff_url":"https://github.com/openshift/openshift-ansible/pull/3306.diff","patch_url":"https://github.com/openshift/openshift-ansible/pull/3306.patch","issue_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/3306","number":3306,"state":"open","locked":false,"title":"replace 'oc service' command with its lib_openshift equivalent","user":{"login":"ingvagabund","id":8055242,"avatar_url":"https://avatars.githubusercontent.com/u/8055242?v=3","gravatar_id":"","url":"https://api.github.com/users/ingvagabund","html_url":"https://github.com/ingvagabund","followers_url":"https://api.github.com/users/ingvagabund/followers","following_url":"https://api.github.com/users/ingvagabund/following{/other_user}","gists_url":"https://api.github.com/users/ingvagabund/gists{/gist_id}","starred_url":"https://api.github.com/users/ingvagabund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ingvagabund/subscriptions","organizations_url":"https://api.github.com/users/ingvagabund/orgs","repos_url":"https://api.github.com/users/ingvagabund/repos","events_url":"https://api.github.com/users/ingvagabund/events{/privacy}","received_events_url":"https://api.github.com/users/ingvagabund/received_events","type":"User","site_admin":false},"body":"SSIA","created_at":"2017-02-09T11:30:10Z","updated_at":"2017-02-10T11:53:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"98ae9dd8519abd49a875adaea8209e5bf2405f7c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/3306/commits","review_comments_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/3306/comments","review_comment_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/3306/comments","statuses_url":"https://api.github.com/repos/openshift/openshift-ansible/statuses/77d59c11f09fa875cb295b4d11c474ecd6809494","head":{"label":"ingvagabund:oc_service","ref":"oc_service","sha":"77d59c11f09fa875cb295b4d11c474ecd6809494","user":{"login":"ingvagabund","id":8055242,"avatar_url":"https://avatars.githubusercontent.com/u/8055242?v=3","gravatar_id":"","url":"https://api.github.com/users/ingvagabund","html_url":"https://github.com/ingvagabund","followers_url":"https://api.github.com/users/ingvagabund/followers","following_url":"https://api.github.com/users/ingvagabund/following{/other_user}","gists_url":"https://api.github.com/users/ingvagabund/gists{/gist_id}","starred_url":"https://api.github.com/users/ingvagabund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ingvagabund/subscriptions","organizations_url":"https://api.github.com/users/ingvagabund/orgs","repos_url":"https://api.github.com/users/ingvagabund/repos","events_url":"https://api.github.com/users/ingvagabund/events{/privacy}","received_events_url":"https://api.github.com/users/ingvagabund/received_events","type":"User","site_admin":false},"repo":{"id":55982696,"name":"openshift-ansible","full_name":"ingvagabund/openshift-ansible","owner":{"login":"ingvagabund","id":8055242,"avatar_url":"https://avatars.githubusercontent.com/u/8055242?v=3","gravatar_id":"","url":"https://api.github.com/users/ingvagabund","html_url":"https://github.com/ingvagabund","followers_url":"https://api.github.com/users/ingvagabund/followers","following_url":"https://api.github.com/users/ingvagabund/following{/other_user}","gists_url":"https://api.github.com/users/ingvagabund/gists{/gist_id}","starred_url":"https://api.github.com/users/ingvagabund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ingvagabund/subscriptions","organizations_url":"https://api.github.com/users/ingvagabund/orgs","repos_url":"https://api.github.com/users/ingvagabund/repos","events_url":"https://api.github.com/users/ingvagabund/events{/privacy}","received_events_url":"https://api.github.com/users/ingvagabund/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ingvagabund/openshift-ansible","description":"OpenShift Ansible Code","fork":true,"url":"https://api.github.com/repos/ingvagabund/openshift-ansible","forks_url":"https://api.github.com/repos/ingvagabund/openshift-ansible/forks","keys_url":"https://api.github.com/repos/ingvagabund/openshift-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ingvagabund/openshift-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ingvagabund/openshift-ansible/teams","hooks_url":"https://api.github.com/repos/ingvagabund/openshift-ansible/hooks","issue_events_url":"https://api.github.com/repos/ingvagabund/openshift-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/ingvagabund/openshift-ansible/events","assignees_url":"https://api.github.com/repos/ingvagabund/openshift-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/ingvagabund/openshift-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/ingvagabund/openshift-ansible/tags","blobs_url":"https://api.github.com/repos/ingvagabund/openshift-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ingvagabund/openshift-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ingvagabund/openshift-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/ingvagabund/openshift-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ingvagabund/openshift-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/ingvagabund/openshift-ansible/languages","stargazers_url":"https://api.github.com/repos/ingvagabund/openshift-ansible/stargazers","contributors_url":"https://api.github.com/repos/ingvagabund/openshift-ansible/contributors","subscribers_url":"https://api.github.com/repos/ingvagabund/openshift-ansible/subscribers","subscription_url":"https://api.github.com/repos/ingvagabund/openshift-ansible/subscription","commits_url":"https://api.github.com/repos/ingvagabund/openshift-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/ingvagabund/openshift-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/ingvagabund/openshift-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/ingvagabund/openshift-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/ingvagabund/openshift-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/ingvagabund/openshift-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ingvagabund/openshift-ansible/merges","archive_url":"https://api.github.com/repos/ingvagabund/openshift-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ingvagabund/openshift-ansible/downloads","issues_url":"https://api.github.com/repos/ingvagabund/openshift-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/ingvagabund/openshift-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/ingvagabund/openshift-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/ingvagabund/openshift-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ingvagabund/openshift-ansible/labels{/name}","releases_url":"https://api.github.com/repos/ingvagabund/openshift-ansible/releases{/id}","deployments_url":"https://api.github.com/repos/ingvagabund/openshift-ansible/deployments","created_at":"2016-04-11T15:09:18Z","updated_at":"2017-01-12T13:29:06Z","pushed_at":"2017-02-10T11:16:54Z","git_url":"git://github.com/ingvagabund/openshift-ansible.git","ssh_url":"git@github.com:ingvagabund/openshift-ansible.git","clone_url":"https://github.com/ingvagabund/openshift-ansible.git","svn_url":"https://github.com/ingvagabund/openshift-ansible","homepage":"install.openshift.com","size":8402,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"fc96d8d22f6c277b599e6e2fa4e9cc06814a9460","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":24109199,"name":"openshift-ansible","full_name":"openshift/openshift-ansible","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/openshift-ansible","description":"OpenShift Installation and Configuration Management","fork":false,"url":"https://api.github.com/repos/openshift/openshift-ansible","forks_url":"https://api.github.com/repos/openshift/openshift-ansible/forks","keys_url":"https://api.github.com/repos/openshift/openshift-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/openshift-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/openshift-ansible/teams","hooks_url":"https://api.github.com/repos/openshift/openshift-ansible/hooks","issue_events_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/openshift-ansible/events","assignees_url":"https://api.github.com/repos/openshift/openshift-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/openshift-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/openshift-ansible/tags","blobs_url":"https://api.github.com/repos/openshift/openshift-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/openshift-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/openshift-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/openshift-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/openshift-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/openshift-ansible/languages","stargazers_url":"https://api.github.com/repos/openshift/openshift-ansible/stargazers","contributors_url":"https://api.github.com/repos/openshift/openshift-ansible/contributors","subscribers_url":"https://api.github.com/repos/openshift/openshift-ansible/subscribers","subscription_url":"https://api.github.com/repos/openshift/openshift-ansible/subscription","commits_url":"https://api.github.com/repos/openshift/openshift-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/openshift-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/openshift-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/openshift-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/openshift-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/openshift-ansible/merges","archive_url":"https://api.github.com/repos/openshift/openshift-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/openshift-ansible/downloads","issues_url":"https://api.github.com/repos/openshift/openshift-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/openshift-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/openshift-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/openshift-ansible/labels{/name}","releases_url":"https://api.github.com/repos/openshift/openshift-ansible/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/openshift-ansible/deployments","created_at":"2014-09-16T17:07:51Z","updated_at":"2017-02-09T12:18:21Z","pushed_at":"2017-02-10T11:16:56Z","git_url":"git://github.com/openshift/openshift-ansible.git","ssh_url":"git@github.com:openshift/openshift-ansible.git","clone_url":"https://github.com/openshift/openshift-ansible.git","svn_url":"https://github.com/openshift/openshift-ansible","homepage":"https://install.openshift.com","size":9245,"stargazers_count":333,"watchers_count":333,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":541,"mirror_url":null,"open_issues_count":296,"forks":541,"open_issues":296,"watchers":333,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/3306"},"html":{"href":"https://github.com/openshift/openshift-ansible/pull/3306"},"issue":{"href":"https://api.github.com/repos/openshift/openshift-ansible/issues/3306"},"comments":{"href":"https://api.github.com/repos/openshift/openshift-ansible/issues/3306/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/3306/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/3306/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/openshift-ansible/statuses/77d59c11f09fa875cb295b4d11c474ecd6809494"}}}}
{"actor":{"display_login":"ingvagabund"}}