{"action":"created","comment":{"url":"https://api.github.com/repos/JoyOI/Monitor/pulls/comments/159138321","pull_request_review_id":86045257,"id":159138321,"diff_hunk":"@@ -0,0 +1,103 @@\n+﻿using System;\n+using System.Collections.Generic;\n+using System.Linq;\n+using System.Threading.Tasks;\n+using Microsoft.AspNetCore.Mvc;\n+using Microsoft.AspNetCore.Http;\n+using MySql.Data.MySqlClient;\n+\n+using JoyOI.Monitor.Models;\n+using JoyOI.Monitor.Lib;\n+using System.Drawing;\n+\n+namespace JoyOI.Monitor.Controllers\n+{\n+    public class ChartController : BaseController\n+    {\n+\n+        [NonAction]\n+        public async Task<Chart> GetChartData(\n+            string datasource,\n+            string sql,\n+            ChartScaling scale,\n+            Func<List<Dictionary<string, object>>, Chart> proc_rows","path":"src/JoyOI.Monitor/Controllers/ChartController.cs","position":23,"original_position":23,"commit_id":"038d2e837435dfbe78daa52e0183d781e22ba8a3","original_commit_id":"038d2e837435dfbe78daa52e0183d781e22ba8a3","user":{"login":"yukozh","id":2216750,"avatar_url":"https://avatars2.githubusercontent.com/u/2216750?v=4","gravatar_id":"","url":"https://api.github.com/users/yukozh","html_url":"https://github.com/yukozh","followers_url":"https://api.github.com/users/yukozh/followers","following_url":"https://api.github.com/users/yukozh/following{/other_user}","gists_url":"https://api.github.com/users/yukozh/gists{/gist_id}","starred_url":"https://api.github.com/users/yukozh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yukozh/subscriptions","organizations_url":"https://api.github.com/users/yukozh/orgs","repos_url":"https://api.github.com/users/yukozh/repos","events_url":"https://api.github.com/users/yukozh/events{/privacy}","received_events_url":"https://api.github.com/users/yukozh/received_events","type":"User","site_admin":false},"body":"Please don't use implementation type as argument type. You should use Func<IEnumerable<IDictionary<string, object>>, Chart> instead of the current one.","created_at":"2017-12-31T11:27:19Z","updated_at":"2017-12-31T11:35:29Z","html_url":"https://github.com/JoyOI/Monitor/pull/1#discussion_r159138321","pull_request_url":"https://api.github.com/repos/JoyOI/Monitor/pulls/1","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/JoyOI/Monitor/pulls/comments/159138321"},"html":{"href":"https://github.com/JoyOI/Monitor/pull/1#discussion_r159138321"},"pull_request":{"href":"https://api.github.com/repos/JoyOI/Monitor/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/JoyOI/Monitor/pulls/1","id":160617069,"html_url":"https://github.com/JoyOI/Monitor/pull/1","diff_url":"https://github.com/JoyOI/Monitor/pull/1.diff","patch_url":"https://github.com/JoyOI/Monitor/pull/1.patch","issue_url":"https://api.github.com/repos/JoyOI/Monitor/issues/1","number":1,"state":"open","locked":false,"title":"Charts and framework and state machine charts","user":{"login":"shisoft","id":3405885,"avatar_url":"https://avatars2.githubusercontent.com/u/3405885?v=4","gravatar_id":"","url":"https://api.github.com/users/shisoft","html_url":"https://github.com/shisoft","followers_url":"https://api.github.com/users/shisoft/followers","following_url":"https://api.github.com/users/shisoft/following{/other_user}","gists_url":"https://api.github.com/users/shisoft/gists{/gist_id}","starred_url":"https://api.github.com/users/shisoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shisoft/subscriptions","organizations_url":"https://api.github.com/users/shisoft/orgs","repos_url":"https://api.github.com/users/shisoft/repos","events_url":"https://api.github.com/users/shisoft/events{/privacy}","received_events_url":"https://api.github.com/users/shisoft/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-12-31T11:17:09Z","updated_at":"2017-12-31T11:35:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0889c657bf3e02fd7f7321f39721f8ce6ce47bfe","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/JoyOI/Monitor/pulls/1/commits","review_comments_url":"https://api.github.com/repos/JoyOI/Monitor/pulls/1/comments","review_comment_url":"https://api.github.com/repos/JoyOI/Monitor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JoyOI/Monitor/issues/1/comments","statuses_url":"https://api.github.com/repos/JoyOI/Monitor/statuses/038d2e837435dfbe78daa52e0183d781e22ba8a3","head":{"label":"shisoft:master","ref":"master","sha":"038d2e837435dfbe78daa52e0183d781e22ba8a3","user":{"login":"shisoft","id":3405885,"avatar_url":"https://avatars2.githubusercontent.com/u/3405885?v=4","gravatar_id":"","url":"https://api.github.com/users/shisoft","html_url":"https://github.com/shisoft","followers_url":"https://api.github.com/users/shisoft/followers","following_url":"https://api.github.com/users/shisoft/following{/other_user}","gists_url":"https://api.github.com/users/shisoft/gists{/gist_id}","starred_url":"https://api.github.com/users/shisoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shisoft/subscriptions","organizations_url":"https://api.github.com/users/shisoft/orgs","repos_url":"https://api.github.com/users/shisoft/repos","events_url":"https://api.github.com/users/shisoft/events{/privacy}","received_events_url":"https://api.github.com/users/shisoft/received_events","type":"User","site_admin":false},"repo":{"id":115718301,"name":"Monitor","full_name":"shisoft/Monitor","owner":{"login":"shisoft","id":3405885,"avatar_url":"https://avatars2.githubusercontent.com/u/3405885?v=4","gravatar_id":"","url":"https://api.github.com/users/shisoft","html_url":"https://github.com/shisoft","followers_url":"https://api.github.com/users/shisoft/followers","following_url":"https://api.github.com/users/shisoft/following{/other_user}","gists_url":"https://api.github.com/users/shisoft/gists{/gist_id}","starred_url":"https://api.github.com/users/shisoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shisoft/subscriptions","organizations_url":"https://api.github.com/users/shisoft/orgs","repos_url":"https://api.github.com/users/shisoft/repos","events_url":"https://api.github.com/users/shisoft/events{/privacy}","received_events_url":"https://api.github.com/users/shisoft/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shisoft/Monitor","description":"Joy OI Monitor","fork":true,"url":"https://api.github.com/repos/shisoft/Monitor","forks_url":"https://api.github.com/repos/shisoft/Monitor/forks","keys_url":"https://api.github.com/repos/shisoft/Monitor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shisoft/Monitor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shisoft/Monitor/teams","hooks_url":"https://api.github.com/repos/shisoft/Monitor/hooks","issue_events_url":"https://api.github.com/repos/shisoft/Monitor/issues/events{/number}","events_url":"https://api.github.com/repos/shisoft/Monitor/events","assignees_url":"https://api.github.com/repos/shisoft/Monitor/assignees{/user}","branches_url":"https://api.github.com/repos/shisoft/Monitor/branches{/branch}","tags_url":"https://api.github.com/repos/shisoft/Monitor/tags","blobs_url":"https://api.github.com/repos/shisoft/Monitor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shisoft/Monitor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shisoft/Monitor/git/refs{/sha}","trees_url":"https://api.github.com/repos/shisoft/Monitor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shisoft/Monitor/statuses/{sha}","languages_url":"https://api.github.com/repos/shisoft/Monitor/languages","stargazers_url":"https://api.github.com/repos/shisoft/Monitor/stargazers","contributors_url":"https://api.github.com/repos/shisoft/Monitor/contributors","subscribers_url":"https://api.github.com/repos/shisoft/Monitor/subscribers","subscription_url":"https://api.github.com/repos/shisoft/Monitor/subscription","commits_url":"https://api.github.com/repos/shisoft/Monitor/commits{/sha}","git_commits_url":"https://api.github.com/repos/shisoft/Monitor/git/commits{/sha}","comments_url":"https://api.github.com/repos/shisoft/Monitor/comments{/number}","issue_comment_url":"https://api.github.com/repos/shisoft/Monitor/issues/comments{/number}","contents_url":"https://api.github.com/repos/shisoft/Monitor/contents/{+path}","compare_url":"https://api.github.com/repos/shisoft/Monitor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shisoft/Monitor/merges","archive_url":"https://api.github.com/repos/shisoft/Monitor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shisoft/Monitor/downloads","issues_url":"https://api.github.com/repos/shisoft/Monitor/issues{/number}","pulls_url":"https://api.github.com/repos/shisoft/Monitor/pulls{/number}","milestones_url":"https://api.github.com/repos/shisoft/Monitor/milestones{/number}","notifications_url":"https://api.github.com/repos/shisoft/Monitor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shisoft/Monitor/labels{/name}","releases_url":"https://api.github.com/repos/shisoft/Monitor/releases{/id}","deployments_url":"https://api.github.com/repos/shisoft/Monitor/deployments","created_at":"2017-12-29T11:49:13Z","updated_at":"2017-12-29T11:49:14Z","pushed_at":"2017-12-31T11:21:40Z","git_url":"git://github.com/shisoft/Monitor.git","ssh_url":"git@github.com:shisoft/Monitor.git","clone_url":"https://github.com/shisoft/Monitor.git","svn_url":"https://github.com/shisoft/Monitor","homepage":null,"size":2519,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JoyOI:master","ref":"master","sha":"3aed2dea5300ee5928f9759df4d594760a850303","user":{"login":"JoyOI","id":28256913,"avatar_url":"https://avatars1.githubusercontent.com/u/28256913?v=4","gravatar_id":"","url":"https://api.github.com/users/JoyOI","html_url":"https://github.com/JoyOI","followers_url":"https://api.github.com/users/JoyOI/followers","following_url":"https://api.github.com/users/JoyOI/following{/other_user}","gists_url":"https://api.github.com/users/JoyOI/gists{/gist_id}","starred_url":"https://api.github.com/users/JoyOI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoyOI/subscriptions","organizations_url":"https://api.github.com/users/JoyOI/orgs","repos_url":"https://api.github.com/users/JoyOI/repos","events_url":"https://api.github.com/users/JoyOI/events{/privacy}","received_events_url":"https://api.github.com/users/JoyOI/received_events","type":"Organization","site_admin":false},"repo":{"id":113997915,"name":"Monitor","full_name":"JoyOI/Monitor","owner":{"login":"JoyOI","id":28256913,"avatar_url":"https://avatars1.githubusercontent.com/u/28256913?v=4","gravatar_id":"","url":"https://api.github.com/users/JoyOI","html_url":"https://github.com/JoyOI","followers_url":"https://api.github.com/users/JoyOI/followers","following_url":"https://api.github.com/users/JoyOI/following{/other_user}","gists_url":"https://api.github.com/users/JoyOI/gists{/gist_id}","starred_url":"https://api.github.com/users/JoyOI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoyOI/subscriptions","organizations_url":"https://api.github.com/users/JoyOI/orgs","repos_url":"https://api.github.com/users/JoyOI/repos","events_url":"https://api.github.com/users/JoyOI/events{/privacy}","received_events_url":"https://api.github.com/users/JoyOI/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JoyOI/Monitor","description":"Joy OI Monitor","fork":false,"url":"https://api.github.com/repos/JoyOI/Monitor","forks_url":"https://api.github.com/repos/JoyOI/Monitor/forks","keys_url":"https://api.github.com/repos/JoyOI/Monitor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JoyOI/Monitor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JoyOI/Monitor/teams","hooks_url":"https://api.github.com/repos/JoyOI/Monitor/hooks","issue_events_url":"https://api.github.com/repos/JoyOI/Monitor/issues/events{/number}","events_url":"https://api.github.com/repos/JoyOI/Monitor/events","assignees_url":"https://api.github.com/repos/JoyOI/Monitor/assignees{/user}","branches_url":"https://api.github.com/repos/JoyOI/Monitor/branches{/branch}","tags_url":"https://api.github.com/repos/JoyOI/Monitor/tags","blobs_url":"https://api.github.com/repos/JoyOI/Monitor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JoyOI/Monitor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JoyOI/Monitor/git/refs{/sha}","trees_url":"https://api.github.com/repos/JoyOI/Monitor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JoyOI/Monitor/statuses/{sha}","languages_url":"https://api.github.com/repos/JoyOI/Monitor/languages","stargazers_url":"https://api.github.com/repos/JoyOI/Monitor/stargazers","contributors_url":"https://api.github.com/repos/JoyOI/Monitor/contributors","subscribers_url":"https://api.github.com/repos/JoyOI/Monitor/subscribers","subscription_url":"https://api.github.com/repos/JoyOI/Monitor/subscription","commits_url":"https://api.github.com/repos/JoyOI/Monitor/commits{/sha}","git_commits_url":"https://api.github.com/repos/JoyOI/Monitor/git/commits{/sha}","comments_url":"https://api.github.com/repos/JoyOI/Monitor/comments{/number}","issue_comment_url":"https://api.github.com/repos/JoyOI/Monitor/issues/comments{/number}","contents_url":"https://api.github.com/repos/JoyOI/Monitor/contents/{+path}","compare_url":"https://api.github.com/repos/JoyOI/Monitor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JoyOI/Monitor/merges","archive_url":"https://api.github.com/repos/JoyOI/Monitor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JoyOI/Monitor/downloads","issues_url":"https://api.github.com/repos/JoyOI/Monitor/issues{/number}","pulls_url":"https://api.github.com/repos/JoyOI/Monitor/pulls{/number}","milestones_url":"https://api.github.com/repos/JoyOI/Monitor/milestones{/number}","notifications_url":"https://api.github.com/repos/JoyOI/Monitor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JoyOI/Monitor/labels{/name}","releases_url":"https://api.github.com/repos/JoyOI/Monitor/releases{/id}","deployments_url":"https://api.github.com/repos/JoyOI/Monitor/deployments","created_at":"2017-12-12T14:07:27Z","updated_at":"2017-12-19T13:23:14Z","pushed_at":"2017-12-31T11:21:41Z","git_url":"git://github.com/JoyOI/Monitor.git","ssh_url":"git@github.com:JoyOI/Monitor.git","clone_url":"https://github.com/JoyOI/Monitor.git","svn_url":"https://github.com/JoyOI/Monitor","homepage":null,"size":2402,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":2,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JoyOI/Monitor/pulls/1"},"html":{"href":"https://github.com/JoyOI/Monitor/pull/1"},"issue":{"href":"https://api.github.com/repos/JoyOI/Monitor/issues/1"},"comments":{"href":"https://api.github.com/repos/JoyOI/Monitor/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/JoyOI/Monitor/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/JoyOI/Monitor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JoyOI/Monitor/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/JoyOI/Monitor/statuses/038d2e837435dfbe78daa52e0183d781e22ba8a3"}},"author_association":"NONE"}}
{"actor":{"display_login":"yukozh"}}