{"action":"created","issue":{"url":"https://api.github.com/repos/vfarcic/docker-jenkins-slave-dind/issues/8","repository_url":"https://api.github.com/repos/vfarcic/docker-jenkins-slave-dind","labels_url":"https://api.github.com/repos/vfarcic/docker-jenkins-slave-dind/issues/8/labels{/name}","comments_url":"https://api.github.com/repos/vfarcic/docker-jenkins-slave-dind/issues/8/comments","events_url":"https://api.github.com/repos/vfarcic/docker-jenkins-slave-dind/issues/8/events","html_url":"https://github.com/vfarcic/docker-jenkins-slave-dind/pull/8","id":280996000,"number":8,"title":"Security improvements","user":{"login":"paddy-hack","id":6804372,"avatar_url":"https://avatars3.githubusercontent.com/u/6804372?v=4","gravatar_id":"","url":"https://api.github.com/users/paddy-hack","html_url":"https://github.com/paddy-hack","followers_url":"https://api.github.com/users/paddy-hack/followers","following_url":"https://api.github.com/users/paddy-hack/following{/other_user}","gists_url":"https://api.github.com/users/paddy-hack/gists{/gist_id}","starred_url":"https://api.github.com/users/paddy-hack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paddy-hack/subscriptions","organizations_url":"https://api.github.com/users/paddy-hack/orgs","repos_url":"https://api.github.com/users/paddy-hack/repos","events_url":"https://api.github.com/users/paddy-hack/events{/privacy}","received_events_url":"https://api.github.com/users/paddy-hack/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-12-11T12:16:19Z","updated_at":"2017-12-17T10:00:32Z","closed_at":"2017-12-16T13:42:07Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/vfarcic/docker-jenkins-slave-dind/pulls/8","html_url":"https://github.com/vfarcic/docker-jenkins-slave-dind/pull/8","diff_url":"https://github.com/vfarcic/docker-jenkins-slave-dind/pull/8.diff","patch_url":"https://github.com/vfarcic/docker-jenkins-slave-dind/pull/8.patch"},"body":"This addresses part of [Password disclosure with Jenkins Swarm plugin](https://github.com/vfarcic/docker-flow-stacks/issues/15).  It moves the password into an environment variable and run the swarm plugin CLI as a non-root user (that has access to the Docker socket).\r\n\r\nWorkspace ownership and group will have to be modified to match the `jenkins` user in the swarm-agent container (numeric ID `1000`)."},"comment":{"url":"https://api.github.com/repos/vfarcic/docker-jenkins-slave-dind/issues/comments/352244354","html_url":"https://github.com/vfarcic/docker-jenkins-slave-dind/pull/8#issuecomment-352244354","issue_url":"https://api.github.com/repos/vfarcic/docker-jenkins-slave-dind/issues/8","id":352244354,"user":{"login":"paddy-hack","id":6804372,"avatar_url":"https://avatars3.githubusercontent.com/u/6804372?v=4","gravatar_id":"","url":"https://api.github.com/users/paddy-hack","html_url":"https://github.com/paddy-hack","followers_url":"https://api.github.com/users/paddy-hack/followers","following_url":"https://api.github.com/users/paddy-hack/following{/other_user}","gists_url":"https://api.github.com/users/paddy-hack/gists{/gist_id}","starred_url":"https://api.github.com/users/paddy-hack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paddy-hack/subscriptions","organizations_url":"https://api.github.com/users/paddy-hack/orgs","repos_url":"https://api.github.com/users/paddy-hack/repos","events_url":"https://api.github.com/users/paddy-hack/events{/privacy}","received_events_url":"https://api.github.com/users/paddy-hack/received_events","type":"User","site_admin":false},"created_at":"2017-12-17T10:00:32Z","updated_at":"2017-12-17T10:00:32Z","author_association":"NONE","body":"I see you also reverted running the swarm-client as the `jenkins` user in 82f86062.  That effectively makes [the other PR](https://github.com/vfarcic/docker-flow-stacks/pull/16) pointless and any Jenkins job that contains `cat /run/secrets/jenkins-pass` will have access to the password 😒, even if the plugin gets fixed to remove it from the job's environment.\r\n\r\n"}}
{"actor":{"display_login":"paddy-hack"}}