{"action":"created","comment":{"url":"https://api.github.com/repos/mirage/ocaml-conduit/pulls/comments/130371282","pull_request_review_id":53238307,"id":130371282,"diff_hunk":"@@ -28,14 +28,23 @@ let () =\n   with Not_found -> ()\n \n type tls_lib = | OpenSSL | Native | No_tls [@@deriving sexp]\n-let tls_library = ref No_tls\n-let () =\n-    tls_library := try\n-        match Sys.getenv \"CONDUIT_TLS\" with\n-        | \"native\" | \"Native\" | \"NATIVE\" -> Native\n-        | _ -> OpenSSL\n-      with Not_found -> OpenSSL\n-    (* TODO build time selection *)\n+let default_tls_library =\n+  try\n+    match String.lowercase_ascii (Sys.getenv \"CONDUIT_TLS\") with\n+    | \"native\" -> Native\n+    | \"openssl\" | \"libressl\" -> OpenSSL\n+    | \"none\" | \"notls\" -> No_tls\n+    | _ -> OpenSSL","path":"lwt-unix/conduit_lwt_unix.ml","position":18,"original_position":18,"commit_id":"cad63f96d8b12d7958d1ec165bdac7a0040b3b39","original_commit_id":"cad63f96d8b12d7958d1ec165bdac7a0040b3b39","user":{"login":"hcarty","id":199147,"avatar_url":"https://avatars3.githubusercontent.com/u/199147?v=4","gravatar_id":"","url":"https://api.github.com/users/hcarty","html_url":"https://github.com/hcarty","followers_url":"https://api.github.com/users/hcarty/followers","following_url":"https://api.github.com/users/hcarty/following{/other_user}","gists_url":"https://api.github.com/users/hcarty/gists{/gist_id}","starred_url":"https://api.github.com/users/hcarty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hcarty/subscriptions","organizations_url":"https://api.github.com/users/hcarty/orgs","repos_url":"https://api.github.com/users/hcarty/repos","events_url":"https://api.github.com/users/hcarty/events{/privacy}","received_events_url":"https://api.github.com/users/hcarty/received_events","type":"User","site_admin":false},"body":"Agreed!  I was trying to keep the changes relatively non-invasive.  I can make that syntactic change here if you'd like though.","created_at":"2017-07-31T14:39:13Z","updated_at":"2017-07-31T14:39:13Z","html_url":"https://github.com/mirage/ocaml-conduit/pull/234#discussion_r130371282","pull_request_url":"https://api.github.com/repos/mirage/ocaml-conduit/pulls/234","_links":{"self":{"href":"https://api.github.com/repos/mirage/ocaml-conduit/pulls/comments/130371282"},"html":{"href":"https://github.com/mirage/ocaml-conduit/pull/234#discussion_r130371282"},"pull_request":{"href":"https://api.github.com/repos/mirage/ocaml-conduit/pulls/234"}}},"pull_request":{"url":"https://api.github.com/repos/mirage/ocaml-conduit/pulls/234","id":133006673,"html_url":"https://github.com/mirage/ocaml-conduit/pull/234","diff_url":"https://github.com/mirage/ocaml-conduit/pull/234.diff","patch_url":"https://github.com/mirage/ocaml-conduit/pull/234.patch","issue_url":"https://api.github.com/repos/mirage/ocaml-conduit/issues/234","number":234,"state":"open","locked":false,"title":"Detect Lwt SSL/TLS version actively at runtime","user":{"login":"hcarty","id":199147,"avatar_url":"https://avatars3.githubusercontent.com/u/199147?v=4","gravatar_id":"","url":"https://api.github.com/users/hcarty","html_url":"https://github.com/hcarty","followers_url":"https://api.github.com/users/hcarty/followers","following_url":"https://api.github.com/users/hcarty/following{/other_user}","gists_url":"https://api.github.com/users/hcarty/gists{/gist_id}","starred_url":"https://api.github.com/users/hcarty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hcarty/subscriptions","organizations_url":"https://api.github.com/users/hcarty/orgs","repos_url":"https://api.github.com/users/hcarty/repos","events_url":"https://api.github.com/users/hcarty/events{/privacy}","received_events_url":"https://api.github.com/users/hcarty/received_events","type":"User","site_admin":false},"body":"This adds a flag to the `dummy`/`real` modules to indicate their real-ness then at run time uses that flag information when the `CONDUIT_TLS` environment variable is not specified to select `OpenSSL`/`Native`/`No_tls` in `Conduit_lwt_unix`.\r\n\r\nThis should fix #233 ","created_at":"2017-07-28T16:33:32Z","updated_at":"2017-07-31T14:39:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"93c7dec768f32a6f99234a6fbaeda5d4d6c3ad84","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/mirage/ocaml-conduit/pulls/234/commits","review_comments_url":"https://api.github.com/repos/mirage/ocaml-conduit/pulls/234/comments","review_comment_url":"https://api.github.com/repos/mirage/ocaml-conduit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mirage/ocaml-conduit/issues/234/comments","statuses_url":"https://api.github.com/repos/mirage/ocaml-conduit/statuses/cad63f96d8b12d7958d1ec165bdac7a0040b3b39","head":{"label":"hcarty:ssl-tls-detection","ref":"ssl-tls-detection","sha":"cad63f96d8b12d7958d1ec165bdac7a0040b3b39","user":{"login":"hcarty","id":199147,"avatar_url":"https://avatars3.githubusercontent.com/u/199147?v=4","gravatar_id":"","url":"https://api.github.com/users/hcarty","html_url":"https://github.com/hcarty","followers_url":"https://api.github.com/users/hcarty/followers","following_url":"https://api.github.com/users/hcarty/following{/other_user}","gists_url":"https://api.github.com/users/hcarty/gists{/gist_id}","starred_url":"https://api.github.com/users/hcarty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hcarty/subscriptions","organizations_url":"https://api.github.com/users/hcarty/orgs","repos_url":"https://api.github.com/users/hcarty/repos","events_url":"https://api.github.com/users/hcarty/events{/privacy}","received_events_url":"https://api.github.com/users/hcarty/received_events","type":"User","site_admin":false},"repo":{"id":98667866,"name":"ocaml-conduit","full_name":"hcarty/ocaml-conduit","owner":{"login":"hcarty","id":199147,"avatar_url":"https://avatars3.githubusercontent.com/u/199147?v=4","gravatar_id":"","url":"https://api.github.com/users/hcarty","html_url":"https://github.com/hcarty","followers_url":"https://api.github.com/users/hcarty/followers","following_url":"https://api.github.com/users/hcarty/following{/other_user}","gists_url":"https://api.github.com/users/hcarty/gists{/gist_id}","starred_url":"https://api.github.com/users/hcarty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hcarty/subscriptions","organizations_url":"https://api.github.com/users/hcarty/orgs","repos_url":"https://api.github.com/users/hcarty/repos","events_url":"https://api.github.com/users/hcarty/events{/privacy}","received_events_url":"https://api.github.com/users/hcarty/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hcarty/ocaml-conduit","description":"Dereference URIs into communication channels for Async or Lwt","fork":true,"url":"https://api.github.com/repos/hcarty/ocaml-conduit","forks_url":"https://api.github.com/repos/hcarty/ocaml-conduit/forks","keys_url":"https://api.github.com/repos/hcarty/ocaml-conduit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hcarty/ocaml-conduit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hcarty/ocaml-conduit/teams","hooks_url":"https://api.github.com/repos/hcarty/ocaml-conduit/hooks","issue_events_url":"https://api.github.com/repos/hcarty/ocaml-conduit/issues/events{/number}","events_url":"https://api.github.com/repos/hcarty/ocaml-conduit/events","assignees_url":"https://api.github.com/repos/hcarty/ocaml-conduit/assignees{/user}","branches_url":"https://api.github.com/repos/hcarty/ocaml-conduit/branches{/branch}","tags_url":"https://api.github.com/repos/hcarty/ocaml-conduit/tags","blobs_url":"https://api.github.com/repos/hcarty/ocaml-conduit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hcarty/ocaml-conduit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hcarty/ocaml-conduit/git/refs{/sha}","trees_url":"https://api.github.com/repos/hcarty/ocaml-conduit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hcarty/ocaml-conduit/statuses/{sha}","languages_url":"https://api.github.com/repos/hcarty/ocaml-conduit/languages","stargazers_url":"https://api.github.com/repos/hcarty/ocaml-conduit/stargazers","contributors_url":"https://api.github.com/repos/hcarty/ocaml-conduit/contributors","subscribers_url":"https://api.github.com/repos/hcarty/ocaml-conduit/subscribers","subscription_url":"https://api.github.com/repos/hcarty/ocaml-conduit/subscription","commits_url":"https://api.github.com/repos/hcarty/ocaml-conduit/commits{/sha}","git_commits_url":"https://api.github.com/repos/hcarty/ocaml-conduit/git/commits{/sha}","comments_url":"https://api.github.com/repos/hcarty/ocaml-conduit/comments{/number}","issue_comment_url":"https://api.github.com/repos/hcarty/ocaml-conduit/issues/comments{/number}","contents_url":"https://api.github.com/repos/hcarty/ocaml-conduit/contents/{+path}","compare_url":"https://api.github.com/repos/hcarty/ocaml-conduit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hcarty/ocaml-conduit/merges","archive_url":"https://api.github.com/repos/hcarty/ocaml-conduit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hcarty/ocaml-conduit/downloads","issues_url":"https://api.github.com/repos/hcarty/ocaml-conduit/issues{/number}","pulls_url":"https://api.github.com/repos/hcarty/ocaml-conduit/pulls{/number}","milestones_url":"https://api.github.com/repos/hcarty/ocaml-conduit/milestones{/number}","notifications_url":"https://api.github.com/repos/hcarty/ocaml-conduit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hcarty/ocaml-conduit/labels{/name}","releases_url":"https://api.github.com/repos/hcarty/ocaml-conduit/releases{/id}","deployments_url":"https://api.github.com/repos/hcarty/ocaml-conduit/deployments","created_at":"2017-07-28T16:29:37Z","updated_at":"2017-07-28T16:29:38Z","pushed_at":"2017-07-28T16:30:11Z","git_url":"git://github.com/hcarty/ocaml-conduit.git","ssh_url":"git@github.com:hcarty/ocaml-conduit.git","clone_url":"https://github.com/hcarty/ocaml-conduit.git","svn_url":"https://github.com/hcarty/ocaml-conduit","homepage":"","size":652,"stargazers_count":0,"watchers_count":0,"language":"OCaml","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mirage:master","ref":"master","sha":"a66f808b6cb6126447509331c91fe2cc7634f206","user":{"login":"mirage","id":131943,"avatar_url":"https://avatars3.githubusercontent.com/u/131943?v=4","gravatar_id":"","url":"https://api.github.com/users/mirage","html_url":"https://github.com/mirage","followers_url":"https://api.github.com/users/mirage/followers","following_url":"https://api.github.com/users/mirage/following{/other_user}","gists_url":"https://api.github.com/users/mirage/gists{/gist_id}","starred_url":"https://api.github.com/users/mirage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mirage/subscriptions","organizations_url":"https://api.github.com/users/mirage/orgs","repos_url":"https://api.github.com/users/mirage/repos","events_url":"https://api.github.com/users/mirage/events{/privacy}","received_events_url":"https://api.github.com/users/mirage/received_events","type":"Organization","site_admin":false},"repo":{"id":18571180,"name":"ocaml-conduit","full_name":"mirage/ocaml-conduit","owner":{"login":"mirage","id":131943,"avatar_url":"https://avatars3.githubusercontent.com/u/131943?v=4","gravatar_id":"","url":"https://api.github.com/users/mirage","html_url":"https://github.com/mirage","followers_url":"https://api.github.com/users/mirage/followers","following_url":"https://api.github.com/users/mirage/following{/other_user}","gists_url":"https://api.github.com/users/mirage/gists{/gist_id}","starred_url":"https://api.github.com/users/mirage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mirage/subscriptions","organizations_url":"https://api.github.com/users/mirage/orgs","repos_url":"https://api.github.com/users/mirage/repos","events_url":"https://api.github.com/users/mirage/events{/privacy}","received_events_url":"https://api.github.com/users/mirage/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mirage/ocaml-conduit","description":"Dereference URIs into communication channels for Async or Lwt","fork":false,"url":"https://api.github.com/repos/mirage/ocaml-conduit","forks_url":"https://api.github.com/repos/mirage/ocaml-conduit/forks","keys_url":"https://api.github.com/repos/mirage/ocaml-conduit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mirage/ocaml-conduit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mirage/ocaml-conduit/teams","hooks_url":"https://api.github.com/repos/mirage/ocaml-conduit/hooks","issue_events_url":"https://api.github.com/repos/mirage/ocaml-conduit/issues/events{/number}","events_url":"https://api.github.com/repos/mirage/ocaml-conduit/events","assignees_url":"https://api.github.com/repos/mirage/ocaml-conduit/assignees{/user}","branches_url":"https://api.github.com/repos/mirage/ocaml-conduit/branches{/branch}","tags_url":"https://api.github.com/repos/mirage/ocaml-conduit/tags","blobs_url":"https://api.github.com/repos/mirage/ocaml-conduit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mirage/ocaml-conduit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mirage/ocaml-conduit/git/refs{/sha}","trees_url":"https://api.github.com/repos/mirage/ocaml-conduit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mirage/ocaml-conduit/statuses/{sha}","languages_url":"https://api.github.com/repos/mirage/ocaml-conduit/languages","stargazers_url":"https://api.github.com/repos/mirage/ocaml-conduit/stargazers","contributors_url":"https://api.github.com/repos/mirage/ocaml-conduit/contributors","subscribers_url":"https://api.github.com/repos/mirage/ocaml-conduit/subscribers","subscription_url":"https://api.github.com/repos/mirage/ocaml-conduit/subscription","commits_url":"https://api.github.com/repos/mirage/ocaml-conduit/commits{/sha}","git_commits_url":"https://api.github.com/repos/mirage/ocaml-conduit/git/commits{/sha}","comments_url":"https://api.github.com/repos/mirage/ocaml-conduit/comments{/number}","issue_comment_url":"https://api.github.com/repos/mirage/ocaml-conduit/issues/comments{/number}","contents_url":"https://api.github.com/repos/mirage/ocaml-conduit/contents/{+path}","compare_url":"https://api.github.com/repos/mirage/ocaml-conduit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mirage/ocaml-conduit/merges","archive_url":"https://api.github.com/repos/mirage/ocaml-conduit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mirage/ocaml-conduit/downloads","issues_url":"https://api.github.com/repos/mirage/ocaml-conduit/issues{/number}","pulls_url":"https://api.github.com/repos/mirage/ocaml-conduit/pulls{/number}","milestones_url":"https://api.github.com/repos/mirage/ocaml-conduit/milestones{/number}","notifications_url":"https://api.github.com/repos/mirage/ocaml-conduit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mirage/ocaml-conduit/labels{/name}","releases_url":"https://api.github.com/repos/mirage/ocaml-conduit/releases{/id}","deployments_url":"https://api.github.com/repos/mirage/ocaml-conduit/deployments","created_at":"2014-04-08T19:03:19Z","updated_at":"2017-07-28T18:46:30Z","pushed_at":"2017-07-28T16:33:33Z","git_url":"git://github.com/mirage/ocaml-conduit.git","ssh_url":"git@github.com:mirage/ocaml-conduit.git","clone_url":"https://github.com/mirage/ocaml-conduit.git","svn_url":"https://github.com/mirage/ocaml-conduit","homepage":"","size":649,"stargazers_count":31,"watchers_count":31,"language":"OCaml","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":39,"mirror_url":null,"open_issues_count":38,"forks":39,"open_issues":38,"watchers":31,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mirage/ocaml-conduit/pulls/234"},"html":{"href":"https://github.com/mirage/ocaml-conduit/pull/234"},"issue":{"href":"https://api.github.com/repos/mirage/ocaml-conduit/issues/234"},"comments":{"href":"https://api.github.com/repos/mirage/ocaml-conduit/issues/234/comments"},"review_comments":{"href":"https://api.github.com/repos/mirage/ocaml-conduit/pulls/234/comments"},"review_comment":{"href":"https://api.github.com/repos/mirage/ocaml-conduit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mirage/ocaml-conduit/pulls/234/commits"},"statuses":{"href":"https://api.github.com/repos/mirage/ocaml-conduit/statuses/cad63f96d8b12d7958d1ec165bdac7a0040b3b39"}}}}
{"actor":{"display_login":"hcarty"}}