{"action":"created","comment":{"url":"https://api.github.com/repos/codefordenver/owlet-ui/pulls/comments/126261953","pull_request_review_id":48735990,"id":126261953,"diff_hunk":"@@ -70,24 +69,41 @@\n             :activity-titles activity-titles)\n        :dispatch [route-dispatch route-param]})))\n \n-;TODO: add :show-skill, :show-activity\n+\n+; route dispatches\n \n (rf/reg-event-fx\n   :show-branches\n   (fn [_ _]\n-    {:dispatch [:set-active-view :branches-view]}))\n+    {:dispatch-n (list [:set-active-view :branches-view]\n+                       [:set-active-document-title! \"Branches\"])}))\n+\n+(rf/reg-event-fx\n+  :show-branch\n+  (fn [_ [_ route-param]]\n+    {:dispatch-n (list [:set-active-view :filtered-activities-view \"branch\"]\n+                       [:filter-activities-by-search-term route-param]\n+                       [:set-active-document-title! route-param])}))\n \n (rf/reg-event-fx\n   :show-platform\n-  (fn [_ route-param]\n+  (fn [_ [_ route-param]]\n     {:dispatch-n (list [:set-active-view :filtered-activities-view \"platform\"]\n-                       [:filter-activities-by-search-term (second route-param)])}))\n+                       [:filter-activities-by-search-term route-param]\n+                       [:set-active-document-title! route-param])}))\n \n (rf/reg-event-fx\n-  :show-branch\n-  (fn [_ route-param]\n+  :show-skill\n+  (fn [_ [_ route-param]]\n     {:dispatch-n (list [:set-active-view :filtered-activities-view \"branch\"]\n-                       [:filter-activities-by-search-term (second route-param)])}))\n+                       [:filter-activities-by-search-term route-param]\n+                       [:set-active-document-title! route-param])}))\n+\n+(rf/reg-event-fx\n+  :show-activity\n+  (fn [_ [_ route-param]]\n+    {:dispatch-n (list [:set-active-view :activity-view]\n+                       [:set-activity-in-view route-param])}))","path":"src/cljs/owlet_ui/events/contentful.cljs","position":117,"original_position":53,"commit_id":"361c2affc3952d3ba17be214340a73c28e7de04f","original_commit_id":"361c2affc3952d3ba17be214340a73c28e7de04f","user":{"login":"eemshi","id":10643091,"avatar_url":"https://avatars0.githubusercontent.com/u/10643091?v=3","gravatar_id":"","url":"https://api.github.com/users/eemshi","html_url":"https://github.com/eemshi","followers_url":"https://api.github.com/users/eemshi/followers","following_url":"https://api.github.com/users/eemshi/following{/other_user}","gists_url":"https://api.github.com/users/eemshi/gists{/gist_id}","starred_url":"https://api.github.com/users/eemshi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eemshi/subscriptions","organizations_url":"https://api.github.com/users/eemshi/orgs","repos_url":"https://api.github.com/users/eemshi/repos","events_url":"https://api.github.com/users/eemshi/events{/privacy}","received_events_url":"https://api.github.com/users/eemshi/received_events","type":"User","site_admin":false},"body":"@dviramontes this is now the only place `:set-activity-in-view` is being used. `[:filter-activities-by-search-term route-param]` also works here - do you see any advantage in using `:set-activity-in-view` instead? i was thinking speed maybe","created_at":"2017-07-07T23:02:34Z","updated_at":"2017-07-07T23:02:43Z","html_url":"https://github.com/codefordenver/owlet-ui/pull/162#discussion_r126261953","pull_request_url":"https://api.github.com/repos/codefordenver/owlet-ui/pulls/162","_links":{"self":{"href":"https://api.github.com/repos/codefordenver/owlet-ui/pulls/comments/126261953"},"html":{"href":"https://github.com/codefordenver/owlet-ui/pull/162#discussion_r126261953"},"pull_request":{"href":"https://api.github.com/repos/codefordenver/owlet-ui/pulls/162"}}},"pull_request":{"url":"https://api.github.com/repos/codefordenver/owlet-ui/pulls/162","id":129267224,"html_url":"https://github.com/codefordenver/owlet-ui/pull/162","diff_url":"https://github.com/codefordenver/owlet-ui/pull/162.diff","patch_url":"https://github.com/codefordenver/owlet-ui/pull/162.patch","issue_url":"https://api.github.com/repos/codefordenver/owlet-ui/issues/162","number":162,"state":"open","locked":false,"title":"Refactors handlers to reduce complexity & side-effects","user":{"login":"eemshi","id":10643091,"avatar_url":"https://avatars0.githubusercontent.com/u/10643091?v=3","gravatar_id":"","url":"https://api.github.com/users/eemshi","html_url":"https://github.com/eemshi","followers_url":"https://api.github.com/users/eemshi/followers","following_url":"https://api.github.com/users/eemshi/following{/other_user}","gists_url":"https://api.github.com/users/eemshi/gists{/gist_id}","starred_url":"https://api.github.com/users/eemshi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eemshi/subscriptions","organizations_url":"https://api.github.com/users/eemshi/orgs","repos_url":"https://api.github.com/users/eemshi/repos","events_url":"https://api.github.com/users/eemshi/events{/privacy}","received_events_url":"https://api.github.com/users/eemshi/received_events","type":"User","site_admin":false},"body":"v.2\r\n\r\ncloses https://github.com/codefordenver/owlet/issues/241\r\n\r\nTODO:\r\n- [x] get rid of `:process-activity-metadata` dispatch in `:get-library-content-from-contentful`\r\n- [x] stop storing route-params\r\n- [x] resolve timing of `:get-library-content-from-contentful` and `:filter-activities-by-search-term` (see `routes.cljs`)\r\n- [ ] handle `set-path` in `:filter-activities-by-search-term` as a coeffect?\r\n- [x] handle `:set-active-document-title!` as an effect?\r\n- [x] consolidate `:set-activities-by-branch-in-view` with `:filter-activities-by-search-term`\r\n- [ ] update error message for search not found\r\n- [ ] revisit `:set-active-document-title!`","created_at":"2017-07-06T19:52:30Z","updated_at":"2017-07-07T23:02:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5ec8568f8ed14f3d7c9b1648aaa43a69168538e9","assignee":{"login":"eemshi","id":10643091,"avatar_url":"https://avatars0.githubusercontent.com/u/10643091?v=3","gravatar_id":"","url":"https://api.github.com/users/eemshi","html_url":"https://github.com/eemshi","followers_url":"https://api.github.com/users/eemshi/followers","following_url":"https://api.github.com/users/eemshi/following{/other_user}","gists_url":"https://api.github.com/users/eemshi/gists{/gist_id}","starred_url":"https://api.github.com/users/eemshi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eemshi/subscriptions","organizations_url":"https://api.github.com/users/eemshi/orgs","repos_url":"https://api.github.com/users/eemshi/repos","events_url":"https://api.github.com/users/eemshi/events{/privacy}","received_events_url":"https://api.github.com/users/eemshi/received_events","type":"User","site_admin":false},"assignees":[{"login":"eemshi","id":10643091,"avatar_url":"https://avatars0.githubusercontent.com/u/10643091?v=3","gravatar_id":"","url":"https://api.github.com/users/eemshi","html_url":"https://github.com/eemshi","followers_url":"https://api.github.com/users/eemshi/followers","following_url":"https://api.github.com/users/eemshi/following{/other_user}","gists_url":"https://api.github.com/users/eemshi/gists{/gist_id}","starred_url":"https://api.github.com/users/eemshi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eemshi/subscriptions","organizations_url":"https://api.github.com/users/eemshi/orgs","repos_url":"https://api.github.com/users/eemshi/repos","events_url":"https://api.github.com/users/eemshi/events{/privacy}","received_events_url":"https://api.github.com/users/eemshi/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"dviramontes","id":144226,"avatar_url":"https://avatars2.githubusercontent.com/u/144226?v=3","gravatar_id":"","url":"https://api.github.com/users/dviramontes","html_url":"https://github.com/dviramontes","followers_url":"https://api.github.com/users/dviramontes/followers","following_url":"https://api.github.com/users/dviramontes/following{/other_user}","gists_url":"https://api.github.com/users/dviramontes/gists{/gist_id}","starred_url":"https://api.github.com/users/dviramontes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dviramontes/subscriptions","organizations_url":"https://api.github.com/users/dviramontes/orgs","repos_url":"https://api.github.com/users/dviramontes/repos","events_url":"https://api.github.com/users/dviramontes/events{/privacy}","received_events_url":"https://api.github.com/users/dviramontes/received_events","type":"User","site_admin":false},{"login":"tylerperkins","id":607877,"avatar_url":"https://avatars1.githubusercontent.com/u/607877?v=3","gravatar_id":"","url":"https://api.github.com/users/tylerperkins","html_url":"https://github.com/tylerperkins","followers_url":"https://api.github.com/users/tylerperkins/followers","following_url":"https://api.github.com/users/tylerperkins/following{/other_user}","gists_url":"https://api.github.com/users/tylerperkins/gists{/gist_id}","starred_url":"https://api.github.com/users/tylerperkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tylerperkins/subscriptions","organizations_url":"https://api.github.com/users/tylerperkins/orgs","repos_url":"https://api.github.com/users/tylerperkins/repos","events_url":"https://api.github.com/users/tylerperkins/events{/privacy}","received_events_url":"https://api.github.com/users/tylerperkins/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/codefordenver/owlet-ui/pulls/162/commits","review_comments_url":"https://api.github.com/repos/codefordenver/owlet-ui/pulls/162/comments","review_comment_url":"https://api.github.com/repos/codefordenver/owlet-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/codefordenver/owlet-ui/issues/162/comments","statuses_url":"https://api.github.com/repos/codefordenver/owlet-ui/statuses/361c2affc3952d3ba17be214340a73c28e7de04f","head":{"label":"codefordenver:contentful-refactor","ref":"contentful-refactor","sha":"361c2affc3952d3ba17be214340a73c28e7de04f","user":{"login":"codefordenver","id":7472092,"avatar_url":"https://avatars1.githubusercontent.com/u/7472092?v=3","gravatar_id":"","url":"https://api.github.com/users/codefordenver","html_url":"https://github.com/codefordenver","followers_url":"https://api.github.com/users/codefordenver/followers","following_url":"https://api.github.com/users/codefordenver/following{/other_user}","gists_url":"https://api.github.com/users/codefordenver/gists{/gist_id}","starred_url":"https://api.github.com/users/codefordenver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codefordenver/subscriptions","organizations_url":"https://api.github.com/users/codefordenver/orgs","repos_url":"https://api.github.com/users/codefordenver/repos","events_url":"https://api.github.com/users/codefordenver/events{/privacy}","received_events_url":"https://api.github.com/users/codefordenver/received_events","type":"Organization","site_admin":false},"repo":{"id":54700882,"name":"owlet-ui","full_name":"codefordenver/owlet-ui","owner":{"login":"codefordenver","id":7472092,"avatar_url":"https://avatars1.githubusercontent.com/u/7472092?v=3","gravatar_id":"","url":"https://api.github.com/users/codefordenver","html_url":"https://github.com/codefordenver","followers_url":"https://api.github.com/users/codefordenver/followers","following_url":"https://api.github.com/users/codefordenver/following{/other_user}","gists_url":"https://api.github.com/users/codefordenver/gists{/gist_id}","starred_url":"https://api.github.com/users/codefordenver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codefordenver/subscriptions","organizations_url":"https://api.github.com/users/codefordenver/orgs","repos_url":"https://api.github.com/users/codefordenver/repos","events_url":"https://api.github.com/users/codefordenver/events{/privacy}","received_events_url":"https://api.github.com/users/codefordenver/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/codefordenver/owlet-ui","description":"Front End for Owlet Project","fork":false,"url":"https://api.github.com/repos/codefordenver/owlet-ui","forks_url":"https://api.github.com/repos/codefordenver/owlet-ui/forks","keys_url":"https://api.github.com/repos/codefordenver/owlet-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codefordenver/owlet-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codefordenver/owlet-ui/teams","hooks_url":"https://api.github.com/repos/codefordenver/owlet-ui/hooks","issue_events_url":"https://api.github.com/repos/codefordenver/owlet-ui/issues/events{/number}","events_url":"https://api.github.com/repos/codefordenver/owlet-ui/events","assignees_url":"https://api.github.com/repos/codefordenver/owlet-ui/assignees{/user}","branches_url":"https://api.github.com/repos/codefordenver/owlet-ui/branches{/branch}","tags_url":"https://api.github.com/repos/codefordenver/owlet-ui/tags","blobs_url":"https://api.github.com/repos/codefordenver/owlet-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codefordenver/owlet-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codefordenver/owlet-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/codefordenver/owlet-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codefordenver/owlet-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/codefordenver/owlet-ui/languages","stargazers_url":"https://api.github.com/repos/codefordenver/owlet-ui/stargazers","contributors_url":"https://api.github.com/repos/codefordenver/owlet-ui/contributors","subscribers_url":"https://api.github.com/repos/codefordenver/owlet-ui/subscribers","subscription_url":"https://api.github.com/repos/codefordenver/owlet-ui/subscription","commits_url":"https://api.github.com/repos/codefordenver/owlet-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/codefordenver/owlet-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/codefordenver/owlet-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/codefordenver/owlet-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/codefordenver/owlet-ui/contents/{+path}","compare_url":"https://api.github.com/repos/codefordenver/owlet-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codefordenver/owlet-ui/merges","archive_url":"https://api.github.com/repos/codefordenver/owlet-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codefordenver/owlet-ui/downloads","issues_url":"https://api.github.com/repos/codefordenver/owlet-ui/issues{/number}","pulls_url":"https://api.github.com/repos/codefordenver/owlet-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/codefordenver/owlet-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/codefordenver/owlet-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codefordenver/owlet-ui/labels{/name}","releases_url":"https://api.github.com/repos/codefordenver/owlet-ui/releases{/id}","deployments_url":"https://api.github.com/repos/codefordenver/owlet-ui/deployments","created_at":"2016-03-25T06:55:51Z","updated_at":"2017-05-13T20:11:45Z","pushed_at":"2017-07-07T22:59:56Z","git_url":"git://github.com/codefordenver/owlet-ui.git","ssh_url":"git@github.com:codefordenver/owlet-ui.git","clone_url":"https://github.com/codefordenver/owlet-ui.git","svn_url":"https://github.com/codefordenver/owlet-ui","homepage":"http://owlet.codefordenver.org","size":2914,"stargazers_count":8,"watchers_count":8,"language":"Clojure","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":1,"forks":7,"open_issues":1,"watchers":8,"default_branch":"master"}},"base":{"label":"codefordenver:master","ref":"master","sha":"ed504d9f6ef7482e29265499c8e4093103001414","user":{"login":"codefordenver","id":7472092,"avatar_url":"https://avatars1.githubusercontent.com/u/7472092?v=3","gravatar_id":"","url":"https://api.github.com/users/codefordenver","html_url":"https://github.com/codefordenver","followers_url":"https://api.github.com/users/codefordenver/followers","following_url":"https://api.github.com/users/codefordenver/following{/other_user}","gists_url":"https://api.github.com/users/codefordenver/gists{/gist_id}","starred_url":"https://api.github.com/users/codefordenver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codefordenver/subscriptions","organizations_url":"https://api.github.com/users/codefordenver/orgs","repos_url":"https://api.github.com/users/codefordenver/repos","events_url":"https://api.github.com/users/codefordenver/events{/privacy}","received_events_url":"https://api.github.com/users/codefordenver/received_events","type":"Organization","site_admin":false},"repo":{"id":54700882,"name":"owlet-ui","full_name":"codefordenver/owlet-ui","owner":{"login":"codefordenver","id":7472092,"avatar_url":"https://avatars1.githubusercontent.com/u/7472092?v=3","gravatar_id":"","url":"https://api.github.com/users/codefordenver","html_url":"https://github.com/codefordenver","followers_url":"https://api.github.com/users/codefordenver/followers","following_url":"https://api.github.com/users/codefordenver/following{/other_user}","gists_url":"https://api.github.com/users/codefordenver/gists{/gist_id}","starred_url":"https://api.github.com/users/codefordenver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codefordenver/subscriptions","organizations_url":"https://api.github.com/users/codefordenver/orgs","repos_url":"https://api.github.com/users/codefordenver/repos","events_url":"https://api.github.com/users/codefordenver/events{/privacy}","received_events_url":"https://api.github.com/users/codefordenver/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/codefordenver/owlet-ui","description":"Front End for Owlet Project","fork":false,"url":"https://api.github.com/repos/codefordenver/owlet-ui","forks_url":"https://api.github.com/repos/codefordenver/owlet-ui/forks","keys_url":"https://api.github.com/repos/codefordenver/owlet-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codefordenver/owlet-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codefordenver/owlet-ui/teams","hooks_url":"https://api.github.com/repos/codefordenver/owlet-ui/hooks","issue_events_url":"https://api.github.com/repos/codefordenver/owlet-ui/issues/events{/number}","events_url":"https://api.github.com/repos/codefordenver/owlet-ui/events","assignees_url":"https://api.github.com/repos/codefordenver/owlet-ui/assignees{/user}","branches_url":"https://api.github.com/repos/codefordenver/owlet-ui/branches{/branch}","tags_url":"https://api.github.com/repos/codefordenver/owlet-ui/tags","blobs_url":"https://api.github.com/repos/codefordenver/owlet-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codefordenver/owlet-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codefordenver/owlet-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/codefordenver/owlet-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codefordenver/owlet-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/codefordenver/owlet-ui/languages","stargazers_url":"https://api.github.com/repos/codefordenver/owlet-ui/stargazers","contributors_url":"https://api.github.com/repos/codefordenver/owlet-ui/contributors","subscribers_url":"https://api.github.com/repos/codefordenver/owlet-ui/subscribers","subscription_url":"https://api.github.com/repos/codefordenver/owlet-ui/subscription","commits_url":"https://api.github.com/repos/codefordenver/owlet-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/codefordenver/owlet-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/codefordenver/owlet-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/codefordenver/owlet-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/codefordenver/owlet-ui/contents/{+path}","compare_url":"https://api.github.com/repos/codefordenver/owlet-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codefordenver/owlet-ui/merges","archive_url":"https://api.github.com/repos/codefordenver/owlet-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codefordenver/owlet-ui/downloads","issues_url":"https://api.github.com/repos/codefordenver/owlet-ui/issues{/number}","pulls_url":"https://api.github.com/repos/codefordenver/owlet-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/codefordenver/owlet-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/codefordenver/owlet-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codefordenver/owlet-ui/labels{/name}","releases_url":"https://api.github.com/repos/codefordenver/owlet-ui/releases{/id}","deployments_url":"https://api.github.com/repos/codefordenver/owlet-ui/deployments","created_at":"2016-03-25T06:55:51Z","updated_at":"2017-05-13T20:11:45Z","pushed_at":"2017-07-07T22:59:56Z","git_url":"git://github.com/codefordenver/owlet-ui.git","ssh_url":"git@github.com:codefordenver/owlet-ui.git","clone_url":"https://github.com/codefordenver/owlet-ui.git","svn_url":"https://github.com/codefordenver/owlet-ui","homepage":"http://owlet.codefordenver.org","size":2914,"stargazers_count":8,"watchers_count":8,"language":"Clojure","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":1,"forks":7,"open_issues":1,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/codefordenver/owlet-ui/pulls/162"},"html":{"href":"https://github.com/codefordenver/owlet-ui/pull/162"},"issue":{"href":"https://api.github.com/repos/codefordenver/owlet-ui/issues/162"},"comments":{"href":"https://api.github.com/repos/codefordenver/owlet-ui/issues/162/comments"},"review_comments":{"href":"https://api.github.com/repos/codefordenver/owlet-ui/pulls/162/comments"},"review_comment":{"href":"https://api.github.com/repos/codefordenver/owlet-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/codefordenver/owlet-ui/pulls/162/commits"},"statuses":{"href":"https://api.github.com/repos/codefordenver/owlet-ui/statuses/361c2affc3952d3ba17be214340a73c28e7de04f"}}}}
{"actor":{"display_login":"eemshi"}}