{"action":"created","comment":{"url":"https://api.github.com/repos/yarnpkg/rfcs/pulls/comments/132252005","pull_request_review_id":55312951,"id":132252005,"diff_hunk":"@@ -0,0 +1,84 @@\n+- Start Date: 2017-08-08\n+- RFC PR:\n+- Yarn Issue:\n+\n+# Summary\n+\n+Clarify what is a *hosted* git dependency, which dependency patterns should be considered as *hosted*, and what are the differences with a regular git dependency.\n+\n+# Motivation\n+\n+*Hosted* git dependencies are dependencies hosted on Github, Gitlab or Bitbucket that can download the manifest and dependency content with a HTTPS request instead of using the `git` command.\n+\n+Because they are treated differently, they do not benefit from all the features of a regular git dependency (like yarnpkg/yarn#3553), or introduce some incompatibilities (yarnpkg/yarn#3923).\n+Also these differences are poorly documented and hard to identify from the code.\n+\n+The **main goal** is to ensure that the same result can be expected by installing a *hosted* git dependency or a regular git dependency.\n+\n+Secondly, exhaustively document which patterns are resolved as *hosted* dependencies, what are the implications for private repositories, and how to write a pattern to be explicitly *regular*.\n+Plus it would be nice to synchronise with `npm` (npm/hosted-git-info ?)\n+\n+At last, as much as possible, let the feature be extensible to other git hosts in the future (for example, self-hosted gitlab or bitbucket).\n+\n+# Detailed design\n+\n+As a first step, the existing implementation for *hosted* git dependencies should be removed, and patterns that previously matched a hosted dependency should resolve to a git repository.","path":"accepted/0000-hosted-git-dependencies.md","position":25,"original_position":25,"commit_id":"76c83d3e6723c659869c4701f043e595ce041230","original_commit_id":"76c83d3e6723c659869c4701f043e595ce041230","user":{"login":"bestander","id":2121048,"avatar_url":"https://avatars3.githubusercontent.com/u/2121048?v=4","gravatar_id":"","url":"https://api.github.com/users/bestander","html_url":"https://github.com/bestander","followers_url":"https://api.github.com/users/bestander/followers","following_url":"https://api.github.com/users/bestander/following{/other_user}","gists_url":"https://api.github.com/users/bestander/gists{/gist_id}","starred_url":"https://api.github.com/users/bestander/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bestander/subscriptions","organizations_url":"https://api.github.com/users/bestander/orgs","repos_url":"https://api.github.com/users/bestander/repos","events_url":"https://api.github.com/users/bestander/events{/privacy}","received_events_url":"https://api.github.com/users/bestander/received_events","type":"User","site_admin":false},"body":"Could you justify why the code for hosted git dependencies should be removed?\r\nAre there specific issues caused by the current implementation?\r\nCan it be just modified?","created_at":"2017-08-09T17:31:15Z","updated_at":"2017-08-09T17:38:21Z","html_url":"https://github.com/yarnpkg/rfcs/pull/79#discussion_r132252005","pull_request_url":"https://api.github.com/repos/yarnpkg/rfcs/pulls/79","_links":{"self":{"href":"https://api.github.com/repos/yarnpkg/rfcs/pulls/comments/132252005"},"html":{"href":"https://github.com/yarnpkg/rfcs/pull/79#discussion_r132252005"},"pull_request":{"href":"https://api.github.com/repos/yarnpkg/rfcs/pulls/79"}}},"pull_request":{"url":"https://api.github.com/repos/yarnpkg/rfcs/pulls/79","id":134587214,"html_url":"https://github.com/yarnpkg/rfcs/pull/79","diff_url":"https://github.com/yarnpkg/rfcs/pull/79.diff","patch_url":"https://github.com/yarnpkg/rfcs/pull/79.patch","issue_url":"https://api.github.com/repos/yarnpkg/rfcs/issues/79","number":79,"state":"open","locked":false,"title":"RFC for Hosted Git Dependencies","user":{"login":"Volune","id":767553,"avatar_url":"https://avatars1.githubusercontent.com/u/767553?v=4","gravatar_id":"","url":"https://api.github.com/users/Volune","html_url":"https://github.com/Volune","followers_url":"https://api.github.com/users/Volune/followers","following_url":"https://api.github.com/users/Volune/following{/other_user}","gists_url":"https://api.github.com/users/Volune/gists{/gist_id}","starred_url":"https://api.github.com/users/Volune/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Volune/subscriptions","organizations_url":"https://api.github.com/users/Volune/orgs","repos_url":"https://api.github.com/users/Volune/repos","events_url":"https://api.github.com/users/Volune/events{/privacy}","received_events_url":"https://api.github.com/users/Volune/received_events","type":"User","site_admin":false},"body":"[rendered RFC](https://github.com/Volune/yarn-rfcs/blob/hosted-git-dependencies/accepted/0000-hosted-git-dependencies.md)\r\n\r\nI was previously trying to make a PR related to these changes, but it was becoming too big. There are still several unresolved questions.","created_at":"2017-08-08T06:49:23Z","updated_at":"2017-08-09T17:38:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2fbce9b9afb6e31e15ad8e34354fa59a9d6766b8","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/yarnpkg/rfcs/pulls/79/commits","review_comments_url":"https://api.github.com/repos/yarnpkg/rfcs/pulls/79/comments","review_comment_url":"https://api.github.com/repos/yarnpkg/rfcs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yarnpkg/rfcs/issues/79/comments","statuses_url":"https://api.github.com/repos/yarnpkg/rfcs/statuses/76c83d3e6723c659869c4701f043e595ce041230","head":{"label":"Volune:hosted-git-dependencies","ref":"hosted-git-dependencies","sha":"76c83d3e6723c659869c4701f043e595ce041230","user":{"login":"Volune","id":767553,"avatar_url":"https://avatars1.githubusercontent.com/u/767553?v=4","gravatar_id":"","url":"https://api.github.com/users/Volune","html_url":"https://github.com/Volune","followers_url":"https://api.github.com/users/Volune/followers","following_url":"https://api.github.com/users/Volune/following{/other_user}","gists_url":"https://api.github.com/users/Volune/gists{/gist_id}","starred_url":"https://api.github.com/users/Volune/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Volune/subscriptions","organizations_url":"https://api.github.com/users/Volune/orgs","repos_url":"https://api.github.com/users/Volune/repos","events_url":"https://api.github.com/users/Volune/events{/privacy}","received_events_url":"https://api.github.com/users/Volune/received_events","type":"User","site_admin":false},"repo":{"id":99648620,"name":"yarn-rfcs","full_name":"Volune/yarn-rfcs","owner":{"login":"Volune","id":767553,"avatar_url":"https://avatars1.githubusercontent.com/u/767553?v=4","gravatar_id":"","url":"https://api.github.com/users/Volune","html_url":"https://github.com/Volune","followers_url":"https://api.github.com/users/Volune/followers","following_url":"https://api.github.com/users/Volune/following{/other_user}","gists_url":"https://api.github.com/users/Volune/gists{/gist_id}","starred_url":"https://api.github.com/users/Volune/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Volune/subscriptions","organizations_url":"https://api.github.com/users/Volune/orgs","repos_url":"https://api.github.com/users/Volune/repos","events_url":"https://api.github.com/users/Volune/events{/privacy}","received_events_url":"https://api.github.com/users/Volune/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Volune/yarn-rfcs","description":"RFCs for changes to Yarn","fork":true,"url":"https://api.github.com/repos/Volune/yarn-rfcs","forks_url":"https://api.github.com/repos/Volune/yarn-rfcs/forks","keys_url":"https://api.github.com/repos/Volune/yarn-rfcs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Volune/yarn-rfcs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Volune/yarn-rfcs/teams","hooks_url":"https://api.github.com/repos/Volune/yarn-rfcs/hooks","issue_events_url":"https://api.github.com/repos/Volune/yarn-rfcs/issues/events{/number}","events_url":"https://api.github.com/repos/Volune/yarn-rfcs/events","assignees_url":"https://api.github.com/repos/Volune/yarn-rfcs/assignees{/user}","branches_url":"https://api.github.com/repos/Volune/yarn-rfcs/branches{/branch}","tags_url":"https://api.github.com/repos/Volune/yarn-rfcs/tags","blobs_url":"https://api.github.com/repos/Volune/yarn-rfcs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Volune/yarn-rfcs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Volune/yarn-rfcs/git/refs{/sha}","trees_url":"https://api.github.com/repos/Volune/yarn-rfcs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Volune/yarn-rfcs/statuses/{sha}","languages_url":"https://api.github.com/repos/Volune/yarn-rfcs/languages","stargazers_url":"https://api.github.com/repos/Volune/yarn-rfcs/stargazers","contributors_url":"https://api.github.com/repos/Volune/yarn-rfcs/contributors","subscribers_url":"https://api.github.com/repos/Volune/yarn-rfcs/subscribers","subscription_url":"https://api.github.com/repos/Volune/yarn-rfcs/subscription","commits_url":"https://api.github.com/repos/Volune/yarn-rfcs/commits{/sha}","git_commits_url":"https://api.github.com/repos/Volune/yarn-rfcs/git/commits{/sha}","comments_url":"https://api.github.com/repos/Volune/yarn-rfcs/comments{/number}","issue_comment_url":"https://api.github.com/repos/Volune/yarn-rfcs/issues/comments{/number}","contents_url":"https://api.github.com/repos/Volune/yarn-rfcs/contents/{+path}","compare_url":"https://api.github.com/repos/Volune/yarn-rfcs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Volune/yarn-rfcs/merges","archive_url":"https://api.github.com/repos/Volune/yarn-rfcs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Volune/yarn-rfcs/downloads","issues_url":"https://api.github.com/repos/Volune/yarn-rfcs/issues{/number}","pulls_url":"https://api.github.com/repos/Volune/yarn-rfcs/pulls{/number}","milestones_url":"https://api.github.com/repos/Volune/yarn-rfcs/milestones{/number}","notifications_url":"https://api.github.com/repos/Volune/yarn-rfcs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Volune/yarn-rfcs/labels{/name}","releases_url":"https://api.github.com/repos/Volune/yarn-rfcs/releases{/id}","deployments_url":"https://api.github.com/repos/Volune/yarn-rfcs/deployments","created_at":"2017-08-08T04:03:26Z","updated_at":"2017-08-08T06:47:11Z","pushed_at":"2017-08-08T06:46:48Z","git_url":"git://github.com/Volune/yarn-rfcs.git","ssh_url":"git@github.com:Volune/yarn-rfcs.git","clone_url":"https://github.com/Volune/yarn-rfcs.git","svn_url":"https://github.com/Volune/yarn-rfcs","homepage":"","size":57,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yarnpkg:master","ref":"master","sha":"d8395eacfe68a2eedaf4af506fb32c3432cbbd30","user":{"login":"yarnpkg","id":22247014,"avatar_url":"https://avatars3.githubusercontent.com/u/22247014?v=4","gravatar_id":"","url":"https://api.github.com/users/yarnpkg","html_url":"https://github.com/yarnpkg","followers_url":"https://api.github.com/users/yarnpkg/followers","following_url":"https://api.github.com/users/yarnpkg/following{/other_user}","gists_url":"https://api.github.com/users/yarnpkg/gists{/gist_id}","starred_url":"https://api.github.com/users/yarnpkg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yarnpkg/subscriptions","organizations_url":"https://api.github.com/users/yarnpkg/orgs","repos_url":"https://api.github.com/users/yarnpkg/repos","events_url":"https://api.github.com/users/yarnpkg/events{/privacy}","received_events_url":"https://api.github.com/users/yarnpkg/received_events","type":"Organization","site_admin":false},"repo":{"id":68416532,"name":"rfcs","full_name":"yarnpkg/rfcs","owner":{"login":"yarnpkg","id":22247014,"avatar_url":"https://avatars3.githubusercontent.com/u/22247014?v=4","gravatar_id":"","url":"https://api.github.com/users/yarnpkg","html_url":"https://github.com/yarnpkg","followers_url":"https://api.github.com/users/yarnpkg/followers","following_url":"https://api.github.com/users/yarnpkg/following{/other_user}","gists_url":"https://api.github.com/users/yarnpkg/gists{/gist_id}","starred_url":"https://api.github.com/users/yarnpkg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yarnpkg/subscriptions","organizations_url":"https://api.github.com/users/yarnpkg/orgs","repos_url":"https://api.github.com/users/yarnpkg/repos","events_url":"https://api.github.com/users/yarnpkg/events{/privacy}","received_events_url":"https://api.github.com/users/yarnpkg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yarnpkg/rfcs","description":"RFCs for changes to Yarn","fork":false,"url":"https://api.github.com/repos/yarnpkg/rfcs","forks_url":"https://api.github.com/repos/yarnpkg/rfcs/forks","keys_url":"https://api.github.com/repos/yarnpkg/rfcs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yarnpkg/rfcs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yarnpkg/rfcs/teams","hooks_url":"https://api.github.com/repos/yarnpkg/rfcs/hooks","issue_events_url":"https://api.github.com/repos/yarnpkg/rfcs/issues/events{/number}","events_url":"https://api.github.com/repos/yarnpkg/rfcs/events","assignees_url":"https://api.github.com/repos/yarnpkg/rfcs/assignees{/user}","branches_url":"https://api.github.com/repos/yarnpkg/rfcs/branches{/branch}","tags_url":"https://api.github.com/repos/yarnpkg/rfcs/tags","blobs_url":"https://api.github.com/repos/yarnpkg/rfcs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yarnpkg/rfcs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yarnpkg/rfcs/git/refs{/sha}","trees_url":"https://api.github.com/repos/yarnpkg/rfcs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yarnpkg/rfcs/statuses/{sha}","languages_url":"https://api.github.com/repos/yarnpkg/rfcs/languages","stargazers_url":"https://api.github.com/repos/yarnpkg/rfcs/stargazers","contributors_url":"https://api.github.com/repos/yarnpkg/rfcs/contributors","subscribers_url":"https://api.github.com/repos/yarnpkg/rfcs/subscribers","subscription_url":"https://api.github.com/repos/yarnpkg/rfcs/subscription","commits_url":"https://api.github.com/repos/yarnpkg/rfcs/commits{/sha}","git_commits_url":"https://api.github.com/repos/yarnpkg/rfcs/git/commits{/sha}","comments_url":"https://api.github.com/repos/yarnpkg/rfcs/comments{/number}","issue_comment_url":"https://api.github.com/repos/yarnpkg/rfcs/issues/comments{/number}","contents_url":"https://api.github.com/repos/yarnpkg/rfcs/contents/{+path}","compare_url":"https://api.github.com/repos/yarnpkg/rfcs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yarnpkg/rfcs/merges","archive_url":"https://api.github.com/repos/yarnpkg/rfcs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yarnpkg/rfcs/downloads","issues_url":"https://api.github.com/repos/yarnpkg/rfcs/issues{/number}","pulls_url":"https://api.github.com/repos/yarnpkg/rfcs/pulls{/number}","milestones_url":"https://api.github.com/repos/yarnpkg/rfcs/milestones{/number}","notifications_url":"https://api.github.com/repos/yarnpkg/rfcs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yarnpkg/rfcs/labels{/name}","releases_url":"https://api.github.com/repos/yarnpkg/rfcs/releases{/id}","deployments_url":"https://api.github.com/repos/yarnpkg/rfcs/deployments","created_at":"2016-09-16T21:44:14Z","updated_at":"2017-08-09T08:13:25Z","pushed_at":"2017-08-08T06:49:23Z","git_url":"git://github.com/yarnpkg/rfcs.git","ssh_url":"git@github.com:yarnpkg/rfcs.git","clone_url":"https://github.com/yarnpkg/rfcs.git","svn_url":"https://github.com/yarnpkg/rfcs","homepage":"","size":55,"stargazers_count":94,"watchers_count":94,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":53,"mirror_url":null,"open_issues_count":10,"forks":53,"open_issues":10,"watchers":94,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yarnpkg/rfcs/pulls/79"},"html":{"href":"https://github.com/yarnpkg/rfcs/pull/79"},"issue":{"href":"https://api.github.com/repos/yarnpkg/rfcs/issues/79"},"comments":{"href":"https://api.github.com/repos/yarnpkg/rfcs/issues/79/comments"},"review_comments":{"href":"https://api.github.com/repos/yarnpkg/rfcs/pulls/79/comments"},"review_comment":{"href":"https://api.github.com/repos/yarnpkg/rfcs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yarnpkg/rfcs/pulls/79/commits"},"statuses":{"href":"https://api.github.com/repos/yarnpkg/rfcs/statuses/76c83d3e6723c659869c4701f043e595ce041230"}}}}
{"actor":{"display_login":"bestander"}}