{"action":"created","comment":{"url":"https://api.github.com/repos/spyder-ide/spyder/pulls/comments/146118454","pull_request_review_id":71019951,"id":146118454,"diff_hunk":"@@ -2454,18 +2510,44 @@ def split(self, orientation=Qt.Vertical):\n             current_editor.setFocus()\r\n \r\n     def iter_editorstacks(self):\r\n+        \"\"\"Return the editor stacks for this splitter and every first child.\r\n+\r\n+        Note: If a splitter contains more than one splitter as a direct\r\n+              child, only the first child's editor stack is included.\r\n+\r\n+        Returns:\r\n+            List of tuples containing (EditorStack instance, orientation).\r\n+        \"\"\"\r\n         editorstacks = [(self.widget(0), self.orientation())]\r\n         if self.count() > 1:\r\n             editorsplitter = self.widget(1)\r\n             editorstacks += editorsplitter.iter_editorstacks()\r\n         return editorstacks\r\n \r\n     def get_layout_settings(self):\r\n-        \"\"\"Return layout state\"\"\"\r\n+        \"\"\"Return the layout state for this splitter and its children.\r\n+\r\n+        Record the current state, including file names and current line\r\n+        numbers, of the splitter panels.\r\n+\r\n+        Returns:\r\n+            A dictionary containing keys {hexstate, sizes, splitsettings}.\r\n+                hexstate: String of saveState() for self.\r\n+                sizes: List for size() for self.\r\n+                splitsettings: List of tuples of the form\r\n+                       (orientation, cfname, clines) for each EditorSplitter\r\n+                       and its EditorStack.\r\n+                           orientation: orientation() for the editor\r\n+                                 splitter (which may be a child of self).\r\n+                           cfname: EditorStack current file name.\r\n+                           clines: Current line number for each file in the\r\n+                               EditorStack.\r\n+        \"\"\"\r\n         splitsettings = []\r\n         for editorstack, orientation in self.iter_editorstacks():\r\n             clines = []\r\n             cfname = ''\r\n+            # XXX - this overrides value from the loop to always be False?\r\n             orientation = False\r","path":"spyder/widgets/editor.py","position":175,"original_position":175,"commit_id":"7e6e79649cdea3ce4518db0f4786e825897c19d3","original_commit_id":"7e6e79649cdea3ce4518db0f4786e825897c19d3","user":{"login":"dalthviz","id":16781833,"avatar_url":"https://avatars2.githubusercontent.com/u/16781833?v=4","gravatar_id":"","url":"https://api.github.com/users/dalthviz","html_url":"https://github.com/dalthviz","followers_url":"https://api.github.com/users/dalthviz/followers","following_url":"https://api.github.com/users/dalthviz/following{/other_user}","gists_url":"https://api.github.com/users/dalthviz/gists{/gist_id}","starred_url":"https://api.github.com/users/dalthviz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dalthviz/subscriptions","organizations_url":"https://api.github.com/users/dalthviz/orgs","repos_url":"https://api.github.com/users/dalthviz/repos","events_url":"https://api.github.com/users/dalthviz/events{/privacy}","received_events_url":"https://api.github.com/users/dalthviz/received_events","type":"User","site_admin":false},"body":"I think you are right with the value for `orientation`, but I'm not quite sure. @ccordoba12 do you know the reason to do this? After clarifing this, please @csabella, write the explanation instead of the current comment that you left.","created_at":"2017-10-22T00:06:47Z","updated_at":"2017-10-22T00:30:07Z","html_url":"https://github.com/spyder-ide/spyder/pull/5512#discussion_r146118454","pull_request_url":"https://api.github.com/repos/spyder-ide/spyder/pulls/5512","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/spyder-ide/spyder/pulls/comments/146118454"},"html":{"href":"https://github.com/spyder-ide/spyder/pull/5512#discussion_r146118454"},"pull_request":{"href":"https://api.github.com/repos/spyder-ide/spyder/pulls/5512"}}},"pull_request":{"url":"https://api.github.com/repos/spyder-ide/spyder/pulls/5512","id":147687143,"html_url":"https://github.com/spyder-ide/spyder/pull/5512","diff_url":"https://github.com/spyder-ide/spyder/pull/5512.diff","patch_url":"https://github.com/spyder-ide/spyder/pull/5512.patch","issue_url":"https://api.github.com/repos/spyder-ide/spyder/issues/5512","number":5512,"state":"open","locked":false,"title":"PR: Shortcuts for splitting and closing panels","user":{"login":"csabella","id":25619791,"avatar_url":"https://avatars0.githubusercontent.com/u/25619791?v=4","gravatar_id":"","url":"https://api.github.com/users/csabella","html_url":"https://github.com/csabella","followers_url":"https://api.github.com/users/csabella/followers","following_url":"https://api.github.com/users/csabella/following{/other_user}","gists_url":"https://api.github.com/users/csabella/gists{/gist_id}","starred_url":"https://api.github.com/users/csabella/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csabella/subscriptions","organizations_url":"https://api.github.com/users/csabella/orgs","repos_url":"https://api.github.com/users/csabella/repos","events_url":"https://api.github.com/users/csabella/events{/privacy}","received_events_url":"https://api.github.com/users/csabella/received_events","type":"User","site_admin":false},"body":"Fixes #2419.\r\n\r\n1.  Adds shortcut `Ctrl-{` for vertical split and `Ctrl-_` for horizontal split based on similar shortcuts in the Eclipse editor.  Adds shortcut `Alt-Shift-W` to close the current split panel.  This was an arbitrary choice based on the other `Close` shortcuts.\r\n2.  Added some docstrings to the EditorSplitter class.\r\n3.  Added more tests to test_editor.py for the EditorSplitter class.\r\n","created_at":"2017-10-19T23:12:50Z","updated_at":"2017-10-22T00:30:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"403e1f9a67b0f6221b8b61b0516d927a6996c741","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/spyder-ide/spyder/milestones/23","html_url":"https://github.com/spyder-ide/spyder/milestone/23","labels_url":"https://api.github.com/repos/spyder-ide/spyder/milestones/23/labels","id":1159297,"number":23,"title":"v4.0beta1","description":"","creator":{"login":"goanpeca","id":3627835,"avatar_url":"https://avatars3.githubusercontent.com/u/3627835?v=4","gravatar_id":"","url":"https://api.github.com/users/goanpeca","html_url":"https://github.com/goanpeca","followers_url":"https://api.github.com/users/goanpeca/followers","following_url":"https://api.github.com/users/goanpeca/following{/other_user}","gists_url":"https://api.github.com/users/goanpeca/gists{/gist_id}","starred_url":"https://api.github.com/users/goanpeca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goanpeca/subscriptions","organizations_url":"https://api.github.com/users/goanpeca/orgs","repos_url":"https://api.github.com/users/goanpeca/repos","events_url":"https://api.github.com/users/goanpeca/events{/privacy}","received_events_url":"https://api.github.com/users/goanpeca/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":132,"state":"open","created_at":"2015-06-10T21:26:57Z","updated_at":"2017-10-20T14:23:25Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/spyder-ide/spyder/pulls/5512/commits","review_comments_url":"https://api.github.com/repos/spyder-ide/spyder/pulls/5512/comments","review_comment_url":"https://api.github.com/repos/spyder-ide/spyder/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spyder-ide/spyder/issues/5512/comments","statuses_url":"https://api.github.com/repos/spyder-ide/spyder/statuses/7e6e79649cdea3ce4518db0f4786e825897c19d3","head":{"label":"csabella:split_shortcut","ref":"split_shortcut","sha":"7e6e79649cdea3ce4518db0f4786e825897c19d3","user":{"login":"csabella","id":25619791,"avatar_url":"https://avatars0.githubusercontent.com/u/25619791?v=4","gravatar_id":"","url":"https://api.github.com/users/csabella","html_url":"https://github.com/csabella","followers_url":"https://api.github.com/users/csabella/followers","following_url":"https://api.github.com/users/csabella/following{/other_user}","gists_url":"https://api.github.com/users/csabella/gists{/gist_id}","starred_url":"https://api.github.com/users/csabella/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csabella/subscriptions","organizations_url":"https://api.github.com/users/csabella/orgs","repos_url":"https://api.github.com/users/csabella/repos","events_url":"https://api.github.com/users/csabella/events{/privacy}","received_events_url":"https://api.github.com/users/csabella/received_events","type":"User","site_admin":false},"repo":{"id":106731294,"name":"spyder","full_name":"csabella/spyder","owner":{"login":"csabella","id":25619791,"avatar_url":"https://avatars0.githubusercontent.com/u/25619791?v=4","gravatar_id":"","url":"https://api.github.com/users/csabella","html_url":"https://github.com/csabella","followers_url":"https://api.github.com/users/csabella/followers","following_url":"https://api.github.com/users/csabella/following{/other_user}","gists_url":"https://api.github.com/users/csabella/gists{/gist_id}","starred_url":"https://api.github.com/users/csabella/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csabella/subscriptions","organizations_url":"https://api.github.com/users/csabella/orgs","repos_url":"https://api.github.com/users/csabella/repos","events_url":"https://api.github.com/users/csabella/events{/privacy}","received_events_url":"https://api.github.com/users/csabella/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/csabella/spyder","description":"Official repository for Spyder - The Scientific PYthon Development EnviRonment","fork":true,"url":"https://api.github.com/repos/csabella/spyder","forks_url":"https://api.github.com/repos/csabella/spyder/forks","keys_url":"https://api.github.com/repos/csabella/spyder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/csabella/spyder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/csabella/spyder/teams","hooks_url":"https://api.github.com/repos/csabella/spyder/hooks","issue_events_url":"https://api.github.com/repos/csabella/spyder/issues/events{/number}","events_url":"https://api.github.com/repos/csabella/spyder/events","assignees_url":"https://api.github.com/repos/csabella/spyder/assignees{/user}","branches_url":"https://api.github.com/repos/csabella/spyder/branches{/branch}","tags_url":"https://api.github.com/repos/csabella/spyder/tags","blobs_url":"https://api.github.com/repos/csabella/spyder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/csabella/spyder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/csabella/spyder/git/refs{/sha}","trees_url":"https://api.github.com/repos/csabella/spyder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/csabella/spyder/statuses/{sha}","languages_url":"https://api.github.com/repos/csabella/spyder/languages","stargazers_url":"https://api.github.com/repos/csabella/spyder/stargazers","contributors_url":"https://api.github.com/repos/csabella/spyder/contributors","subscribers_url":"https://api.github.com/repos/csabella/spyder/subscribers","subscription_url":"https://api.github.com/repos/csabella/spyder/subscription","commits_url":"https://api.github.com/repos/csabella/spyder/commits{/sha}","git_commits_url":"https://api.github.com/repos/csabella/spyder/git/commits{/sha}","comments_url":"https://api.github.com/repos/csabella/spyder/comments{/number}","issue_comment_url":"https://api.github.com/repos/csabella/spyder/issues/comments{/number}","contents_url":"https://api.github.com/repos/csabella/spyder/contents/{+path}","compare_url":"https://api.github.com/repos/csabella/spyder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/csabella/spyder/merges","archive_url":"https://api.github.com/repos/csabella/spyder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/csabella/spyder/downloads","issues_url":"https://api.github.com/repos/csabella/spyder/issues{/number}","pulls_url":"https://api.github.com/repos/csabella/spyder/pulls{/number}","milestones_url":"https://api.github.com/repos/csabella/spyder/milestones{/number}","notifications_url":"https://api.github.com/repos/csabella/spyder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/csabella/spyder/labels{/name}","releases_url":"https://api.github.com/repos/csabella/spyder/releases{/id}","deployments_url":"https://api.github.com/repos/csabella/spyder/deployments","created_at":"2017-10-12T18:36:10Z","updated_at":"2017-10-12T18:36:14Z","pushed_at":"2017-10-20T15:35:35Z","git_url":"git://github.com/csabella/spyder.git","ssh_url":"git@github.com:csabella/spyder.git","clone_url":"https://github.com/csabella/spyder.git","svn_url":"https://github.com/csabella/spyder","homepage":"","size":38773,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spyder-ide:master","ref":"master","sha":"42175bae639f36eb9e4f1f40818397d1145ad5c7","user":{"login":"spyder-ide","id":1284937,"avatar_url":"https://avatars1.githubusercontent.com/u/1284937?v=4","gravatar_id":"","url":"https://api.github.com/users/spyder-ide","html_url":"https://github.com/spyder-ide","followers_url":"https://api.github.com/users/spyder-ide/followers","following_url":"https://api.github.com/users/spyder-ide/following{/other_user}","gists_url":"https://api.github.com/users/spyder-ide/gists{/gist_id}","starred_url":"https://api.github.com/users/spyder-ide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spyder-ide/subscriptions","organizations_url":"https://api.github.com/users/spyder-ide/orgs","repos_url":"https://api.github.com/users/spyder-ide/repos","events_url":"https://api.github.com/users/spyder-ide/events{/privacy}","received_events_url":"https://api.github.com/users/spyder-ide/received_events","type":"Organization","site_admin":false},"repo":{"id":30892477,"name":"spyder","full_name":"spyder-ide/spyder","owner":{"login":"spyder-ide","id":1284937,"avatar_url":"https://avatars1.githubusercontent.com/u/1284937?v=4","gravatar_id":"","url":"https://api.github.com/users/spyder-ide","html_url":"https://github.com/spyder-ide","followers_url":"https://api.github.com/users/spyder-ide/followers","following_url":"https://api.github.com/users/spyder-ide/following{/other_user}","gists_url":"https://api.github.com/users/spyder-ide/gists{/gist_id}","starred_url":"https://api.github.com/users/spyder-ide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spyder-ide/subscriptions","organizations_url":"https://api.github.com/users/spyder-ide/orgs","repos_url":"https://api.github.com/users/spyder-ide/repos","events_url":"https://api.github.com/users/spyder-ide/events{/privacy}","received_events_url":"https://api.github.com/users/spyder-ide/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spyder-ide/spyder","description":"Official repository for Spyder - The Scientific PYthon Development EnviRonment","fork":false,"url":"https://api.github.com/repos/spyder-ide/spyder","forks_url":"https://api.github.com/repos/spyder-ide/spyder/forks","keys_url":"https://api.github.com/repos/spyder-ide/spyder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spyder-ide/spyder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spyder-ide/spyder/teams","hooks_url":"https://api.github.com/repos/spyder-ide/spyder/hooks","issue_events_url":"https://api.github.com/repos/spyder-ide/spyder/issues/events{/number}","events_url":"https://api.github.com/repos/spyder-ide/spyder/events","assignees_url":"https://api.github.com/repos/spyder-ide/spyder/assignees{/user}","branches_url":"https://api.github.com/repos/spyder-ide/spyder/branches{/branch}","tags_url":"https://api.github.com/repos/spyder-ide/spyder/tags","blobs_url":"https://api.github.com/repos/spyder-ide/spyder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spyder-ide/spyder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spyder-ide/spyder/git/refs{/sha}","trees_url":"https://api.github.com/repos/spyder-ide/spyder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spyder-ide/spyder/statuses/{sha}","languages_url":"https://api.github.com/repos/spyder-ide/spyder/languages","stargazers_url":"https://api.github.com/repos/spyder-ide/spyder/stargazers","contributors_url":"https://api.github.com/repos/spyder-ide/spyder/contributors","subscribers_url":"https://api.github.com/repos/spyder-ide/spyder/subscribers","subscription_url":"https://api.github.com/repos/spyder-ide/spyder/subscription","commits_url":"https://api.github.com/repos/spyder-ide/spyder/commits{/sha}","git_commits_url":"https://api.github.com/repos/spyder-ide/spyder/git/commits{/sha}","comments_url":"https://api.github.com/repos/spyder-ide/spyder/comments{/number}","issue_comment_url":"https://api.github.com/repos/spyder-ide/spyder/issues/comments{/number}","contents_url":"https://api.github.com/repos/spyder-ide/spyder/contents/{+path}","compare_url":"https://api.github.com/repos/spyder-ide/spyder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spyder-ide/spyder/merges","archive_url":"https://api.github.com/repos/spyder-ide/spyder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spyder-ide/spyder/downloads","issues_url":"https://api.github.com/repos/spyder-ide/spyder/issues{/number}","pulls_url":"https://api.github.com/repos/spyder-ide/spyder/pulls{/number}","milestones_url":"https://api.github.com/repos/spyder-ide/spyder/milestones{/number}","notifications_url":"https://api.github.com/repos/spyder-ide/spyder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spyder-ide/spyder/labels{/name}","releases_url":"https://api.github.com/repos/spyder-ide/spyder/releases{/id}","deployments_url":"https://api.github.com/repos/spyder-ide/spyder/deployments","created_at":"2015-02-16T22:49:48Z","updated_at":"2017-10-21T02:23:43Z","pushed_at":"2017-10-21T18:25:55Z","git_url":"git://github.com/spyder-ide/spyder.git","ssh_url":"git@github.com:spyder-ide/spyder.git","clone_url":"https://github.com/spyder-ide/spyder.git","svn_url":"https://github.com/spyder-ide/spyder","homepage":"","size":38727,"stargazers_count":2462,"watchers_count":2462,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":583,"mirror_url":null,"archived":false,"open_issues_count":632,"forks":583,"open_issues":632,"watchers":2462,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spyder-ide/spyder/pulls/5512"},"html":{"href":"https://github.com/spyder-ide/spyder/pull/5512"},"issue":{"href":"https://api.github.com/repos/spyder-ide/spyder/issues/5512"},"comments":{"href":"https://api.github.com/repos/spyder-ide/spyder/issues/5512/comments"},"review_comments":{"href":"https://api.github.com/repos/spyder-ide/spyder/pulls/5512/comments"},"review_comment":{"href":"https://api.github.com/repos/spyder-ide/spyder/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spyder-ide/spyder/pulls/5512/commits"},"statuses":{"href":"https://api.github.com/repos/spyder-ide/spyder/statuses/7e6e79649cdea3ce4518db0f4786e825897c19d3"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dalthviz"}}