{"action":"created","issue":{"url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/issues/5484","repository_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy","labels_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/issues/5484/labels{/name}","comments_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/issues/5484/comments","events_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/issues/5484/events","html_url":"https://github.com/openmicroscopy/openmicroscopy/pull/5484","id":254608127,"number":5484,"title":"Preview rdef start end ints","user":{"login":"will-moore","id":900055,"avatar_url":"https://avatars2.githubusercontent.com/u/900055?v=4","gravatar_id":"","url":"https://api.github.com/users/will-moore","html_url":"https://github.com/will-moore","followers_url":"https://api.github.com/users/will-moore/followers","following_url":"https://api.github.com/users/will-moore/following{/other_user}","gists_url":"https://api.github.com/users/will-moore/gists{/gist_id}","starred_url":"https://api.github.com/users/will-moore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/will-moore/subscriptions","organizations_url":"https://api.github.com/users/will-moore/orgs","repos_url":"https://api.github.com/users/will-moore/repos","events_url":"https://api.github.com/users/will-moore/events{/privacy}","received_events_url":"https://api.github.com/users/will-moore/received_events","type":"User","site_admin":false},"labels":[{"id":12053304,"url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/labels/develop","name":"develop","color":"02e10c","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2017-09-01T11:03:39Z","updated_at":"2017-09-14T21:15:47Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/pulls/5484","html_url":"https://github.com/openmicroscopy/openmicroscopy/pull/5484","diff_url":"https://github.com/openmicroscopy/openmicroscopy/pull/5484.diff","patch_url":"https://github.com/openmicroscopy/openmicroscopy/pull/5484.patch"},"body":"# What this PR does\r\n\r\nFixes an error loading Preview panel when the rendering setting channel start/end values are floats, not integers. Although we only see this error on web-dev-integration (doesn't fail locally, maybe different Python version).\r\n\r\n```\r\nInternal Server Error: /webclient/metadata_preview/image/5595/\r\nTraceback (most recent call last):\r\n...\r\n File \"/opt/hudson/workspace/WEB-DEV-integration-deploy/OMERO.py/lib/python/omeroweb/webclient/views.py\", line 1585, in load_metadata_preview\r\n   % (act, i+1, c['start'], c['end'], reverse, color))\r\nTypeError: %d format: a number is required, not float\r\n```\r\n\r\nHowever, this also highlighted that we shouldn't be casting start/end to Integer because some float images have very small ranges and it's important to use float start/end values.\r\nFixed another example of casting these to Integer in the JavaScript viewer.\r\n\r\n# Testing this PR\r\n\r\n1. Find/import a floating point image with small dynamic range, e.g. /test_images_good/EM-data/EMD-2225.map \r\n1. Adjust rendering settings, save them.\r\n1. Re-load the Preview panel, adjust settings again then click the thumbnail showing your rendering settings to re-load the saved settings.\r\n1. These actions should all support floating values for start/end.\r\n"},"comment":{"url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/issues/comments/329611224","html_url":"https://github.com/openmicroscopy/openmicroscopy/pull/5484#issuecomment-329611224","issue_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/issues/5484","id":329611224,"user":{"login":"will-moore","id":900055,"avatar_url":"https://avatars2.githubusercontent.com/u/900055?v=4","gravatar_id":"","url":"https://api.github.com/users/will-moore","html_url":"https://github.com/will-moore","followers_url":"https://api.github.com/users/will-moore/followers","following_url":"https://api.github.com/users/will-moore/following{/other_user}","gists_url":"https://api.github.com/users/will-moore/gists{/gist_id}","starred_url":"https://api.github.com/users/will-moore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/will-moore/subscriptions","organizations_url":"https://api.github.com/users/will-moore/orgs","repos_url":"https://api.github.com/users/will-moore/repos","events_url":"https://api.github.com/users/will-moore/events{/privacy}","received_events_url":"https://api.github.com/users/will-moore/received_events","type":"User","site_admin":false},"created_at":"2017-09-14T21:15:47Z","updated_at":"2017-09-14T21:15:47Z","author_association":"MEMBER","body":"Updated robot test to check that rdef settings (floats) are copied, pasted & applied correctly."}}
{"actor":{"display_login":"will-moore"}}