{"action":"created","comment":{"url":"https://api.github.com/repos/sociomantic-tsunami/dmd-transitional/pulls/comments/117030718","pull_request_review_id":38700142,"id":117030718,"diff_hunk":"@@ -0,0 +1,24 @@\n+#!/bin/sh\n+\n+set -e\n+set -v","path":"build.sh","position":4,"original_position":4,"commit_id":"3acb5e5725d2b8102abaf04a34c703fbd3122866","original_commit_id":"3acb5e5725d2b8102abaf04a34c703fbd3122866","user":{"login":"leandro-lucarella-sociomantic","id":2684688,"avatar_url":"https://avatars2.githubusercontent.com/u/2684688?v=3","gravatar_id":"","url":"https://api.github.com/users/leandro-lucarella-sociomantic","html_url":"https://github.com/leandro-lucarella-sociomantic","followers_url":"https://api.github.com/users/leandro-lucarella-sociomantic/followers","following_url":"https://api.github.com/users/leandro-lucarella-sociomantic/following{/other_user}","gists_url":"https://api.github.com/users/leandro-lucarella-sociomantic/gists{/gist_id}","starred_url":"https://api.github.com/users/leandro-lucarella-sociomantic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leandro-lucarella-sociomantic/subscriptions","organizations_url":"https://api.github.com/users/leandro-lucarella-sociomantic/orgs","repos_url":"https://api.github.com/users/leandro-lucarella-sociomantic/repos","events_url":"https://api.github.com/users/leandro-lucarella-sociomantic/events{/privacy}","received_events_url":"https://api.github.com/users/leandro-lucarella-sociomantic/received_events","type":"User","site_admin":false},"body":"I would use `set -xe` just because this is what we usually use (I never saw `-v` before, it seems like the only difference is `-x` prepends also a `+` to each command).","created_at":"2017-05-17T15:15:06Z","updated_at":"2017-05-17T15:16:03Z","html_url":"https://github.com/sociomantic-tsunami/dmd-transitional/pull/1#discussion_r117030718","pull_request_url":"https://api.github.com/repos/sociomantic-tsunami/dmd-transitional/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/sociomantic-tsunami/dmd-transitional/pulls/comments/117030718"},"html":{"href":"https://github.com/sociomantic-tsunami/dmd-transitional/pull/1#discussion_r117030718"},"pull_request":{"href":"https://api.github.com/repos/sociomantic-tsunami/dmd-transitional/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/sociomantic-tsunami/dmd-transitional/pulls/1","id":121076486,"html_url":"https://github.com/sociomantic-tsunami/dmd-transitional/pull/1","diff_url":"https://github.com/sociomantic-tsunami/dmd-transitional/pull/1.diff","patch_url":"https://github.com/sociomantic-tsunami/dmd-transitional/pull/1.patch","issue_url":"https://api.github.com/repos/sociomantic-tsunami/dmd-transitional/issues/1","number":1,"state":"open","locked":false,"title":"Copy internal state of dmd-transitional","user":{"login":"mihails-strasuns-sociomantic","id":4718368,"avatar_url":"https://avatars0.githubusercontent.com/u/4718368?v=3","gravatar_id":"","url":"https://api.github.com/users/mihails-strasuns-sociomantic","html_url":"https://github.com/mihails-strasuns-sociomantic","followers_url":"https://api.github.com/users/mihails-strasuns-sociomantic/followers","following_url":"https://api.github.com/users/mihails-strasuns-sociomantic/following{/other_user}","gists_url":"https://api.github.com/users/mihails-strasuns-sociomantic/gists{/gist_id}","starred_url":"https://api.github.com/users/mihails-strasuns-sociomantic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mihails-strasuns-sociomantic/subscriptions","organizations_url":"https://api.github.com/users/mihails-strasuns-sociomantic/orgs","repos_url":"https://api.github.com/users/mihails-strasuns-sociomantic/repos","events_url":"https://api.github.com/users/mihails-strasuns-sociomantic/events{/privacy}","received_events_url":"https://api.github.com/users/mihails-strasuns-sociomantic/received_events","type":"User","site_admin":false},"body":"I have not included Travis related scripts we may want as my understanding is\nthat you will be addressing it when working on public packaging.","created_at":"2017-05-17T14:46:59Z","updated_at":"2017-05-17T15:16:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"de9ff7f236a800d8cf99d85b9e5a74f744e9bafc","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/sociomantic-tsunami/dmd-transitional/pulls/1/commits","review_comments_url":"https://api.github.com/repos/sociomantic-tsunami/dmd-transitional/pulls/1/comments","review_comment_url":"https://api.github.com/repos/sociomantic-tsunami/dmd-transitional/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sociomantic-tsunami/dmd-transitional/issues/1/comments","statuses_url":"https://api.github.com/repos/sociomantic-tsunami/dmd-transitional/statuses/3acb5e5725d2b8102abaf04a34c703fbd3122866","head":{"label":"mihails-strasuns-sociomantic:initial","ref":"initial","sha":"3acb5e5725d2b8102abaf04a34c703fbd3122866","user":{"login":"mihails-strasuns-sociomantic","id":4718368,"avatar_url":"https://avatars0.githubusercontent.com/u/4718368?v=3","gravatar_id":"","url":"https://api.github.com/users/mihails-strasuns-sociomantic","html_url":"https://github.com/mihails-strasuns-sociomantic","followers_url":"https://api.github.com/users/mihails-strasuns-sociomantic/followers","following_url":"https://api.github.com/users/mihails-strasuns-sociomantic/following{/other_user}","gists_url":"https://api.github.com/users/mihails-strasuns-sociomantic/gists{/gist_id}","starred_url":"https://api.github.com/users/mihails-strasuns-sociomantic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mihails-strasuns-sociomantic/subscriptions","organizations_url":"https://api.github.com/users/mihails-strasuns-sociomantic/orgs","repos_url":"https://api.github.com/users/mihails-strasuns-sociomantic/repos","events_url":"https://api.github.com/users/mihails-strasuns-sociomantic/events{/privacy}","received_events_url":"https://api.github.com/users/mihails-strasuns-sociomantic/received_events","type":"User","site_admin":false},"repo":{"id":91583502,"name":"dmd-transitional","full_name":"mihails-strasuns-sociomantic/dmd-transitional","owner":{"login":"mihails-strasuns-sociomantic","id":4718368,"avatar_url":"https://avatars0.githubusercontent.com/u/4718368?v=3","gravatar_id":"","url":"https://api.github.com/users/mihails-strasuns-sociomantic","html_url":"https://github.com/mihails-strasuns-sociomantic","followers_url":"https://api.github.com/users/mihails-strasuns-sociomantic/followers","following_url":"https://api.github.com/users/mihails-strasuns-sociomantic/following{/other_user}","gists_url":"https://api.github.com/users/mihails-strasuns-sociomantic/gists{/gist_id}","starred_url":"https://api.github.com/users/mihails-strasuns-sociomantic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mihails-strasuns-sociomantic/subscriptions","organizations_url":"https://api.github.com/users/mihails-strasuns-sociomantic/orgs","repos_url":"https://api.github.com/users/mihails-strasuns-sociomantic/repos","events_url":"https://api.github.com/users/mihails-strasuns-sociomantic/events{/privacy}","received_events_url":"https://api.github.com/users/mihails-strasuns-sociomantic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mihails-strasuns-sociomantic/dmd-transitional","description":"Patches needed for the official DMD compiler to transition from D1","fork":true,"url":"https://api.github.com/repos/mihails-strasuns-sociomantic/dmd-transitional","forks_url":"https://api.github.com/repos/mihails-strasuns-sociomantic/dmd-transitional/forks","keys_url":"https://api.github.com/repos/mihails-strasuns-sociomantic/dmd-transitional/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mihails-strasuns-sociomantic/dmd-transitional/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mihails-strasuns-sociomantic/dmd-transitional/teams","hooks_url":"https://api.github.com/repos/mihails-strasuns-sociomantic/dmd-transitional/hooks","issue_events_url":"https://api.github.com/repos/mihails-strasuns-sociomantic/dmd-transitional/issues/events{/number}","events_url":"https://api.github.com/repos/mihails-strasuns-sociomantic/dmd-transitional/events","assignees_url":"https://api.github.com/repos/mihails-strasuns-sociomantic/dmd-transitional/assignees{/user}","branches_url":"https://api.github.com/repos/mihails-strasuns-sociomantic/dmd-transitional/branches{/branch}","tags_url":"https://api.github.com/repos/mihails-strasuns-sociomantic/dmd-transitional/tags","blobs_url":"https://api.github.com/repos/mihails-strasuns-sociomantic/dmd-transitional/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mihails-strasuns-sociomantic/dmd-transitional/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mihails-strasuns-sociomantic/dmd-transitional/git/refs{/sha}","trees_url":"https://api.github.com/repos/mihails-strasuns-sociomantic/dmd-transitional/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mihails-strasuns-sociomantic/dmd-transitional/statuses/{sha}","languages_url":"https://api.github.com/repos/mihails-strasuns-sociomantic/dmd-transitional/languages","stargazers_url":"https://api.github.com/repos/mihails-strasuns-sociomantic/dmd-transitional/stargazers","contributors_url":"https://api.github.com/repos/mihails-strasuns-sociomantic/dmd-transitional/contributors","subscribers_url":"https://api.github.com/repos/mihails-strasuns-sociomantic/dmd-transitional/subscribers","subscription_url":"https://api.github.com/repos/mihails-strasuns-sociomantic/dmd-transitional/subscription","commits_url":"https://api.github.com/repos/mihails-strasuns-sociomantic/dmd-transitional/commits{/sha}","git_commits_url":"https://api.github.com/repos/mihails-strasuns-sociomantic/dmd-transitional/git/commits{/sha}","comments_url":"https://api.github.com/repos/mihails-strasuns-sociomantic/dmd-transitional/comments{/number}","issue_comment_url":"https://api.github.com/repos/mihails-strasuns-sociomantic/dmd-transitional/issues/comments{/number}","contents_url":"https://api.github.com/repos/mihails-strasuns-sociomantic/dmd-transitional/contents/{+path}","compare_url":"https://api.github.com/repos/mihails-strasuns-sociomantic/dmd-transitional/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mihails-strasuns-sociomantic/dmd-transitional/merges","archive_url":"https://api.github.com/repos/mihails-strasuns-sociomantic/dmd-transitional/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mihails-strasuns-sociomantic/dmd-transitional/downloads","issues_url":"https://api.github.com/repos/mihails-strasuns-sociomantic/dmd-transitional/issues{/number}","pulls_url":"https://api.github.com/repos/mihails-strasuns-sociomantic/dmd-transitional/pulls{/number}","milestones_url":"https://api.github.com/repos/mihails-strasuns-sociomantic/dmd-transitional/milestones{/number}","notifications_url":"https://api.github.com/repos/mihails-strasuns-sociomantic/dmd-transitional/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mihails-strasuns-sociomantic/dmd-transitional/labels{/name}","releases_url":"https://api.github.com/repos/mihails-strasuns-sociomantic/dmd-transitional/releases{/id}","deployments_url":"https://api.github.com/repos/mihails-strasuns-sociomantic/dmd-transitional/deployments","created_at":"2017-05-17T14:07:29Z","updated_at":"2017-05-17T13:56:54Z","pushed_at":"2017-05-17T14:46:58Z","git_url":"git://github.com/mihails-strasuns-sociomantic/dmd-transitional.git","ssh_url":"git@github.com:mihails-strasuns-sociomantic/dmd-transitional.git","clone_url":"https://github.com/mihails-strasuns-sociomantic/dmd-transitional.git","svn_url":"https://github.com/mihails-strasuns-sociomantic/dmd-transitional","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sociomantic-tsunami:master","ref":"master","sha":"6c0890812b82ddb2cac602cacaee4e837fa5a428","user":{"login":"sociomantic-tsunami","id":16766217,"avatar_url":"https://avatars3.githubusercontent.com/u/16766217?v=3","gravatar_id":"","url":"https://api.github.com/users/sociomantic-tsunami","html_url":"https://github.com/sociomantic-tsunami","followers_url":"https://api.github.com/users/sociomantic-tsunami/followers","following_url":"https://api.github.com/users/sociomantic-tsunami/following{/other_user}","gists_url":"https://api.github.com/users/sociomantic-tsunami/gists{/gist_id}","starred_url":"https://api.github.com/users/sociomantic-tsunami/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sociomantic-tsunami/subscriptions","organizations_url":"https://api.github.com/users/sociomantic-tsunami/orgs","repos_url":"https://api.github.com/users/sociomantic-tsunami/repos","events_url":"https://api.github.com/users/sociomantic-tsunami/events{/privacy}","received_events_url":"https://api.github.com/users/sociomantic-tsunami/received_events","type":"Organization","site_admin":false},"repo":{"id":91582428,"name":"dmd-transitional","full_name":"sociomantic-tsunami/dmd-transitional","owner":{"login":"sociomantic-tsunami","id":16766217,"avatar_url":"https://avatars3.githubusercontent.com/u/16766217?v=3","gravatar_id":"","url":"https://api.github.com/users/sociomantic-tsunami","html_url":"https://github.com/sociomantic-tsunami","followers_url":"https://api.github.com/users/sociomantic-tsunami/followers","following_url":"https://api.github.com/users/sociomantic-tsunami/following{/other_user}","gists_url":"https://api.github.com/users/sociomantic-tsunami/gists{/gist_id}","starred_url":"https://api.github.com/users/sociomantic-tsunami/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sociomantic-tsunami/subscriptions","organizations_url":"https://api.github.com/users/sociomantic-tsunami/orgs","repos_url":"https://api.github.com/users/sociomantic-tsunami/repos","events_url":"https://api.github.com/users/sociomantic-tsunami/events{/privacy}","received_events_url":"https://api.github.com/users/sociomantic-tsunami/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sociomantic-tsunami/dmd-transitional","description":"Patches needed for the official DMD compiler to transition from D1","fork":false,"url":"https://api.github.com/repos/sociomantic-tsunami/dmd-transitional","forks_url":"https://api.github.com/repos/sociomantic-tsunami/dmd-transitional/forks","keys_url":"https://api.github.com/repos/sociomantic-tsunami/dmd-transitional/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sociomantic-tsunami/dmd-transitional/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sociomantic-tsunami/dmd-transitional/teams","hooks_url":"https://api.github.com/repos/sociomantic-tsunami/dmd-transitional/hooks","issue_events_url":"https://api.github.com/repos/sociomantic-tsunami/dmd-transitional/issues/events{/number}","events_url":"https://api.github.com/repos/sociomantic-tsunami/dmd-transitional/events","assignees_url":"https://api.github.com/repos/sociomantic-tsunami/dmd-transitional/assignees{/user}","branches_url":"https://api.github.com/repos/sociomantic-tsunami/dmd-transitional/branches{/branch}","tags_url":"https://api.github.com/repos/sociomantic-tsunami/dmd-transitional/tags","blobs_url":"https://api.github.com/repos/sociomantic-tsunami/dmd-transitional/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sociomantic-tsunami/dmd-transitional/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sociomantic-tsunami/dmd-transitional/git/refs{/sha}","trees_url":"https://api.github.com/repos/sociomantic-tsunami/dmd-transitional/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sociomantic-tsunami/dmd-transitional/statuses/{sha}","languages_url":"https://api.github.com/repos/sociomantic-tsunami/dmd-transitional/languages","stargazers_url":"https://api.github.com/repos/sociomantic-tsunami/dmd-transitional/stargazers","contributors_url":"https://api.github.com/repos/sociomantic-tsunami/dmd-transitional/contributors","subscribers_url":"https://api.github.com/repos/sociomantic-tsunami/dmd-transitional/subscribers","subscription_url":"https://api.github.com/repos/sociomantic-tsunami/dmd-transitional/subscription","commits_url":"https://api.github.com/repos/sociomantic-tsunami/dmd-transitional/commits{/sha}","git_commits_url":"https://api.github.com/repos/sociomantic-tsunami/dmd-transitional/git/commits{/sha}","comments_url":"https://api.github.com/repos/sociomantic-tsunami/dmd-transitional/comments{/number}","issue_comment_url":"https://api.github.com/repos/sociomantic-tsunami/dmd-transitional/issues/comments{/number}","contents_url":"https://api.github.com/repos/sociomantic-tsunami/dmd-transitional/contents/{+path}","compare_url":"https://api.github.com/repos/sociomantic-tsunami/dmd-transitional/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sociomantic-tsunami/dmd-transitional/merges","archive_url":"https://api.github.com/repos/sociomantic-tsunami/dmd-transitional/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sociomantic-tsunami/dmd-transitional/downloads","issues_url":"https://api.github.com/repos/sociomantic-tsunami/dmd-transitional/issues{/number}","pulls_url":"https://api.github.com/repos/sociomantic-tsunami/dmd-transitional/pulls{/number}","milestones_url":"https://api.github.com/repos/sociomantic-tsunami/dmd-transitional/milestones{/number}","notifications_url":"https://api.github.com/repos/sociomantic-tsunami/dmd-transitional/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sociomantic-tsunami/dmd-transitional/labels{/name}","releases_url":"https://api.github.com/repos/sociomantic-tsunami/dmd-transitional/releases{/id}","deployments_url":"https://api.github.com/repos/sociomantic-tsunami/dmd-transitional/deployments","created_at":"2017-05-17T13:56:54Z","updated_at":"2017-05-17T13:56:54Z","pushed_at":"2017-05-17T14:47:00Z","git_url":"git://github.com/sociomantic-tsunami/dmd-transitional.git","ssh_url":"git@github.com:sociomantic-tsunami/dmd-transitional.git","clone_url":"https://github.com/sociomantic-tsunami/dmd-transitional.git","svn_url":"https://github.com/sociomantic-tsunami/dmd-transitional","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sociomantic-tsunami/dmd-transitional/pulls/1"},"html":{"href":"https://github.com/sociomantic-tsunami/dmd-transitional/pull/1"},"issue":{"href":"https://api.github.com/repos/sociomantic-tsunami/dmd-transitional/issues/1"},"comments":{"href":"https://api.github.com/repos/sociomantic-tsunami/dmd-transitional/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/sociomantic-tsunami/dmd-transitional/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/sociomantic-tsunami/dmd-transitional/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sociomantic-tsunami/dmd-transitional/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/sociomantic-tsunami/dmd-transitional/statuses/3acb5e5725d2b8102abaf04a34c703fbd3122866"}}}}
{"actor":{"display_login":"leandro-lucarella-sociomantic"}}