{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/96950141","pull_request_review_id":17549457,"id":96950141,"diff_hunk":"@@ -11196,9 +11196,21 @@ size_t emitter::emitOutputInstr(insGroup* ig, instrDesc* id, BYTE** dp)\n     assert(sz == emitSizeOfInsDsc(id));\n \n #if !FEATURE_FIXED_OUT_ARGS\n+    bool bUpdateStackLv = true;\n+\n+    if (emitIGisInProlog(ig))\n+        bUpdateStackLv = false;\n+    if (emitIGisInEpilog(ig))\n+        bUpdateStackLv = false;\n+#if FEATURE_EH_FUNCLETS\n+    if (emitIGisInFuncletProlog(ig))\n+        bUpdateStackLv = false;\n+    if (emitIGisInFuncletEpilog(ig))\n+        bUpdateStackLv = false;\n+#endif // FEATURE_EH_FUNCLETS","path":"src/jit/emitxarch.cpp","position":15,"original_position":15,"commit_id":"6f5d9b7ab62c9b519f774c03dcf4eaf82c0ef31b","original_commit_id":"6f5d9b7ab62c9b519f774c03dcf4eaf82c0ef31b","user":{"login":"janvorli","id":10758568,"avatar_url":"https://avatars.githubusercontent.com/u/10758568?v=3","gravatar_id":"","url":"https://api.github.com/users/janvorli","html_url":"https://github.com/janvorli","followers_url":"https://api.github.com/users/janvorli/followers","following_url":"https://api.github.com/users/janvorli/following{/other_user}","gists_url":"https://api.github.com/users/janvorli/gists{/gist_id}","starred_url":"https://api.github.com/users/janvorli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janvorli/subscriptions","organizations_url":"https://api.github.com/users/janvorli/orgs","repos_url":"https://api.github.com/users/janvorli/repos","events_url":"https://api.github.com/users/janvorli/events{/privacy}","received_events_url":"https://api.github.com/users/janvorli/received_events","type":"User","site_admin":false},"body":"@BruceForstall yes, that's what I meant.","created_at":"2017-01-19T20:26:43Z","updated_at":"2017-01-19T20:26:44Z","html_url":"https://github.com/dotnet/coreclr/pull/9001#discussion_r96950141","pull_request_url":"https://api.github.com/repos/dotnet/coreclr/pulls/9001","_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/96950141"},"html":{"href":"https://github.com/dotnet/coreclr/pull/9001#discussion_r96950141"},"pull_request":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/9001"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/9001","id":102201902,"html_url":"https://github.com/dotnet/coreclr/pull/9001","diff_url":"https://github.com/dotnet/coreclr/pull/9001.diff","patch_url":"https://github.com/dotnet/coreclr/pull/9001.patch","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/9001","number":9001,"state":"open","locked":false,"title":"[x86/Linux] Allow push/pop in funclet prolog and epilog","user":{"login":"parjong","id":14926045,"avatar_url":"https://avatars.githubusercontent.com/u/14926045?v=3","gravatar_id":"","url":"https://api.github.com/users/parjong","html_url":"https://github.com/parjong","followers_url":"https://api.github.com/users/parjong/followers","following_url":"https://api.github.com/users/parjong/following{/other_user}","gists_url":"https://api.github.com/users/parjong/gists{/gist_id}","starred_url":"https://api.github.com/users/parjong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parjong/subscriptions","organizations_url":"https://api.github.com/users/parjong/orgs","repos_url":"https://api.github.com/users/parjong/repos","events_url":"https://api.github.com/users/parjong/events{/privacy}","received_events_url":"https://api.github.com/users/parjong/received_events","type":"User","site_admin":false},"body":"The current implementation updates stack level even for funclet prolog and epilog, which results in assert failure.\r\n\r\nThis commit revises emitter not to update stack level while emitting funclet prolog and epilog in order to allow the use of push/pop instruction.","created_at":"2017-01-19T05:02:12Z","updated_at":"2017-01-19T20:26:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ce6022b90c5684fad6e5b09351363ef77881cc58","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/coreclr/pulls/9001/commits","review_comments_url":"https://api.github.com/repos/dotnet/coreclr/pulls/9001/comments","review_comment_url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/9001/comments","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/6f5d9b7ab62c9b519f774c03dcf4eaf82c0ef31b","head":{"label":"parjong:fix/x86_update_stack_in_funclet_prolog_and_epilog","ref":"fix/x86_update_stack_in_funclet_prolog_and_epilog","sha":"6f5d9b7ab62c9b519f774c03dcf4eaf82c0ef31b","user":{"login":"parjong","id":14926045,"avatar_url":"https://avatars.githubusercontent.com/u/14926045?v=3","gravatar_id":"","url":"https://api.github.com/users/parjong","html_url":"https://github.com/parjong","followers_url":"https://api.github.com/users/parjong/followers","following_url":"https://api.github.com/users/parjong/following{/other_user}","gists_url":"https://api.github.com/users/parjong/gists{/gist_id}","starred_url":"https://api.github.com/users/parjong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parjong/subscriptions","organizations_url":"https://api.github.com/users/parjong/orgs","repos_url":"https://api.github.com/users/parjong/repos","events_url":"https://api.github.com/users/parjong/events{/privacy}","received_events_url":"https://api.github.com/users/parjong/received_events","type":"User","site_admin":false},"repo":{"id":55585145,"name":"coreclr","full_name":"parjong/coreclr","owner":{"login":"parjong","id":14926045,"avatar_url":"https://avatars.githubusercontent.com/u/14926045?v=3","gravatar_id":"","url":"https://api.github.com/users/parjong","html_url":"https://github.com/parjong","followers_url":"https://api.github.com/users/parjong/followers","following_url":"https://api.github.com/users/parjong/following{/other_user}","gists_url":"https://api.github.com/users/parjong/gists{/gist_id}","starred_url":"https://api.github.com/users/parjong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parjong/subscriptions","organizations_url":"https://api.github.com/users/parjong/orgs","repos_url":"https://api.github.com/users/parjong/repos","events_url":"https://api.github.com/users/parjong/events{/privacy}","received_events_url":"https://api.github.com/users/parjong/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/parjong/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called mscorlib. It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes.","fork":true,"url":"https://api.github.com/repos/parjong/coreclr","forks_url":"https://api.github.com/repos/parjong/coreclr/forks","keys_url":"https://api.github.com/repos/parjong/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/parjong/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/parjong/coreclr/teams","hooks_url":"https://api.github.com/repos/parjong/coreclr/hooks","issue_events_url":"https://api.github.com/repos/parjong/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/parjong/coreclr/events","assignees_url":"https://api.github.com/repos/parjong/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/parjong/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/parjong/coreclr/tags","blobs_url":"https://api.github.com/repos/parjong/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/parjong/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/parjong/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/parjong/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/parjong/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/parjong/coreclr/languages","stargazers_url":"https://api.github.com/repos/parjong/coreclr/stargazers","contributors_url":"https://api.github.com/repos/parjong/coreclr/contributors","subscribers_url":"https://api.github.com/repos/parjong/coreclr/subscribers","subscription_url":"https://api.github.com/repos/parjong/coreclr/subscription","commits_url":"https://api.github.com/repos/parjong/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/parjong/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/parjong/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/parjong/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/parjong/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/parjong/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/parjong/coreclr/merges","archive_url":"https://api.github.com/repos/parjong/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/parjong/coreclr/downloads","issues_url":"https://api.github.com/repos/parjong/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/parjong/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/parjong/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/parjong/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/parjong/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/parjong/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/parjong/coreclr/deployments","created_at":"2016-04-06T07:32:51Z","updated_at":"2016-10-23T22:20:56Z","pushed_at":"2017-01-19T05:27:08Z","git_url":"git://github.com/parjong/coreclr.git","ssh_url":"git@github.com:parjong/coreclr.git","clone_url":"https://github.com/parjong/coreclr.git","svn_url":"https://github.com/parjong/coreclr","homepage":"http://dotnet.github.io/","size":127185,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"49ead290c1b26bc07d1108cf1eaca16e171694da","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":30092893,"name":"coreclr","full_name":"dotnet/coreclr","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called mscorlib. It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes.","fork":false,"url":"https://api.github.com/repos/dotnet/coreclr","forks_url":"https://api.github.com/repos/dotnet/coreclr/forks","keys_url":"https://api.github.com/repos/dotnet/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/coreclr/teams","hooks_url":"https://api.github.com/repos/dotnet/coreclr/hooks","issue_events_url":"https://api.github.com/repos/dotnet/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/coreclr/events","assignees_url":"https://api.github.com/repos/dotnet/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/coreclr/tags","blobs_url":"https://api.github.com/repos/dotnet/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/coreclr/languages","stargazers_url":"https://api.github.com/repos/dotnet/coreclr/stargazers","contributors_url":"https://api.github.com/repos/dotnet/coreclr/contributors","subscribers_url":"https://api.github.com/repos/dotnet/coreclr/subscribers","subscription_url":"https://api.github.com/repos/dotnet/coreclr/subscription","commits_url":"https://api.github.com/repos/dotnet/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/coreclr/merges","archive_url":"https://api.github.com/repos/dotnet/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/coreclr/downloads","issues_url":"https://api.github.com/repos/dotnet/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/coreclr/deployments","created_at":"2015-01-30T22:10:02Z","updated_at":"2017-01-19T15:03:13Z","pushed_at":"2017-01-19T20:26:37Z","git_url":"git://github.com/dotnet/coreclr.git","ssh_url":"git@github.com:dotnet/coreclr.git","clone_url":"https://github.com/dotnet/coreclr.git","svn_url":"https://github.com/dotnet/coreclr","homepage":"https://docs.microsoft.com/dotnet/","size":127778,"stargazers_count":7264,"watchers_count":7264,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1797,"mirror_url":null,"open_issues_count":1093,"forks":1797,"open_issues":1093,"watchers":7264,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/9001"},"html":{"href":"https://github.com/dotnet/coreclr/pull/9001"},"issue":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/9001"},"comments":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/9001/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/9001/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/9001/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/coreclr/statuses/6f5d9b7ab62c9b519f774c03dcf4eaf82c0ef31b"}}}}
{"actor":{"display_login":"janvorli"}}