{"action":"created","comment":{"url":"https://api.github.com/repos/danvk/typings-checker/pulls/comments/97337319","pull_request_review_id":17942986,"id":97337319,"diff_hunk":"@@ -31,6 +31,11 @@ An `$ExpectType` directive tests the type of the expression on the next line. Th\n     npm install -g typings-checker\n     typings-checker your-test.ts\n \n+## options\n+\n+* `--noLines` (`-l`): hide line numbers in output -- useful if you don't want these clogging diff logs when you add or remove a line.","path":"README.md","position":6,"original_position":6,"commit_id":"a8bedf2c629434f0714128cc23e9aaf00a1048cd","original_commit_id":"22e340e508446881d73085610eb688584db41ba3","user":{"login":"tycho01","id":3059397,"avatar_url":"https://avatars.githubusercontent.com/u/3059397?v=3","gravatar_id":"","url":"https://api.github.com/users/tycho01","html_url":"https://github.com/tycho01","followers_url":"https://api.github.com/users/tycho01/followers","following_url":"https://api.github.com/users/tycho01/following{/other_user}","gists_url":"https://api.github.com/users/tycho01/gists{/gist_id}","starred_url":"https://api.github.com/users/tycho01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tycho01/subscriptions","organizations_url":"https://api.github.com/users/tycho01/orgs","repos_url":"https://api.github.com/users/tycho01/repos","events_url":"https://api.github.com/users/tycho01/events{/privacy}","received_events_url":"https://api.github.com/users/tycho01/received_events","type":"User","site_admin":false},"body":"Filtering out the line numbers that way seems like an interesting alternative to me. It hadn't occurred to me, though I suppose I'd felt the option might help people in a similar situation -- which I hope wouldn't be many. Including the code fragments was just a way to make it useful even without line numbers.\r\n\r\nZero assertion failures sounds wonderful to me. I do want that, but that's not where we are for ramda right now; there are quite some blocking issues preventing me from reaching that point even if I wanted to: [erased generics](https://github.com/Microsoft/TypeScript/issues/9949), lack of support for [heterogeneous `map()`](https://github.com/Microsoft/TypeScript/issues/12393), lack of type-level support for [`reduce()`](https://github.com/Microsoft/TypeScript/issues/12512), quite possibly support for [higher-kinded types](https://github.com/Microsoft/TypeScript/issues/1213), not to mention whatever [other](https://github.com/Microsoft/TypeScript/issues/6606) features this list might depend on, aside from just finding the time to figure out every single step between here and proper type inference.\r\n\r\nI mean, TypeScript has 1,800+ outstanding issues at the moment, so in that sense, I fear it's no surprise to find that not everything is quite perfect yet. FP libraries are probably among the harder ones to type, but I'm probably also being more ambitious than e.g. the lodash typings -- if I map over an object, I'd like for my IDE to know both the (distinct) types and keys of each value. Settling for vague types is an easy way to pass all tests (as you noted), but in a sense feels to me like it beats the point of doing a typings library.\r\n\r\nTo me this was also the reason to commit and diff the output, like you were. Up to now I had no idea if an edit would break inference and turned everything into `any`. With your library, now I do. But I need to be able to answer bigger questions than that; notably: given my current assertion failures (whether `any` or errors), would switching to an [experimental branch](https://github.com/Microsoft/TypeScript/issues/9949) make that overall situation better or worse?\r\n\r\nI also hope I can get to the point of having the luxury to get things fixed. And I'm about to find out more about that -- knowing what's good or bad now, I can finally start seeing more about that.\r\n","created_at":"2017-01-23T15:10:53Z","updated_at":"2017-01-23T15:10:53Z","html_url":"https://github.com/danvk/typings-checker/pull/13#discussion_r97337319","pull_request_url":"https://api.github.com/repos/danvk/typings-checker/pulls/13","_links":{"self":{"href":"https://api.github.com/repos/danvk/typings-checker/pulls/comments/97337319"},"html":{"href":"https://github.com/danvk/typings-checker/pull/13#discussion_r97337319"},"pull_request":{"href":"https://api.github.com/repos/danvk/typings-checker/pulls/13"}}},"pull_request":{"url":"https://api.github.com/repos/danvk/typings-checker/pulls/13","id":102616183,"html_url":"https://github.com/danvk/typings-checker/pull/13","diff_url":"https://github.com/danvk/typings-checker/pull/13.diff","patch_url":"https://github.com/danvk/typings-checker/pull/13.patch","issue_url":"https://api.github.com/repos/danvk/typings-checker/issues/13","number":13,"state":"open","locked":false,"title":"misc edits","user":{"login":"tycho01","id":3059397,"avatar_url":"https://avatars.githubusercontent.com/u/3059397?v=3","gravatar_id":"","url":"https://api.github.com/users/tycho01","html_url":"https://github.com/tycho01","followers_url":"https://api.github.com/users/tycho01/followers","following_url":"https://api.github.com/users/tycho01/following{/other_user}","gists_url":"https://api.github.com/users/tycho01/gists{/gist_id}","starred_url":"https://api.github.com/users/tycho01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tycho01/subscriptions","organizations_url":"https://api.github.com/users/tycho01/orgs","repos_url":"https://api.github.com/users/tycho01/repos","events_url":"https://api.github.com/users/tycho01/events{/privacy}","received_events_url":"https://api.github.com/users/tycho01/received_events","type":"User","site_admin":false},"body":"- prepublish script: tsc\r\n- dry interfaces\r\n- use local tsconfig.json\r\n- add option to hide line numbers\r\n- improve debug message on attach failure\r\n\r\nFeel free to use/ignore, these seemed useful to me. On that last point... yeah, since 1.1 it's failing to attach for me (using old separate-line assertions) on every single line.\r\n","created_at":"2017-01-22T10:34:37Z","updated_at":"2017-01-23T15:10:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"66b41039d78f46aa23449edda353dbf4c8958309","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/danvk/typings-checker/pulls/13/commits","review_comments_url":"https://api.github.com/repos/danvk/typings-checker/pulls/13/comments","review_comment_url":"https://api.github.com/repos/danvk/typings-checker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/danvk/typings-checker/issues/13/comments","statuses_url":"https://api.github.com/repos/danvk/typings-checker/statuses/a8bedf2c629434f0714128cc23e9aaf00a1048cd","head":{"label":"tycho01:master","ref":"master","sha":"a8bedf2c629434f0714128cc23e9aaf00a1048cd","user":{"login":"tycho01","id":3059397,"avatar_url":"https://avatars.githubusercontent.com/u/3059397?v=3","gravatar_id":"","url":"https://api.github.com/users/tycho01","html_url":"https://github.com/tycho01","followers_url":"https://api.github.com/users/tycho01/followers","following_url":"https://api.github.com/users/tycho01/following{/other_user}","gists_url":"https://api.github.com/users/tycho01/gists{/gist_id}","starred_url":"https://api.github.com/users/tycho01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tycho01/subscriptions","organizations_url":"https://api.github.com/users/tycho01/orgs","repos_url":"https://api.github.com/users/tycho01/repos","events_url":"https://api.github.com/users/tycho01/events{/privacy}","received_events_url":"https://api.github.com/users/tycho01/received_events","type":"User","site_admin":false},"repo":{"id":79532598,"name":"typings-checker","full_name":"tycho01/typings-checker","owner":{"login":"tycho01","id":3059397,"avatar_url":"https://avatars.githubusercontent.com/u/3059397?v=3","gravatar_id":"","url":"https://api.github.com/users/tycho01","html_url":"https://github.com/tycho01","followers_url":"https://api.github.com/users/tycho01/followers","following_url":"https://api.github.com/users/tycho01/following{/other_user}","gists_url":"https://api.github.com/users/tycho01/gists{/gist_id}","starred_url":"https://api.github.com/users/tycho01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tycho01/subscriptions","organizations_url":"https://api.github.com/users/tycho01/orgs","repos_url":"https://api.github.com/users/tycho01/repos","events_url":"https://api.github.com/users/tycho01/events{/privacy}","received_events_url":"https://api.github.com/users/tycho01/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tycho01/typings-checker","description":"Assertions about TypeScript types and errors","fork":true,"url":"https://api.github.com/repos/tycho01/typings-checker","forks_url":"https://api.github.com/repos/tycho01/typings-checker/forks","keys_url":"https://api.github.com/repos/tycho01/typings-checker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tycho01/typings-checker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tycho01/typings-checker/teams","hooks_url":"https://api.github.com/repos/tycho01/typings-checker/hooks","issue_events_url":"https://api.github.com/repos/tycho01/typings-checker/issues/events{/number}","events_url":"https://api.github.com/repos/tycho01/typings-checker/events","assignees_url":"https://api.github.com/repos/tycho01/typings-checker/assignees{/user}","branches_url":"https://api.github.com/repos/tycho01/typings-checker/branches{/branch}","tags_url":"https://api.github.com/repos/tycho01/typings-checker/tags","blobs_url":"https://api.github.com/repos/tycho01/typings-checker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tycho01/typings-checker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tycho01/typings-checker/git/refs{/sha}","trees_url":"https://api.github.com/repos/tycho01/typings-checker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tycho01/typings-checker/statuses/{sha}","languages_url":"https://api.github.com/repos/tycho01/typings-checker/languages","stargazers_url":"https://api.github.com/repos/tycho01/typings-checker/stargazers","contributors_url":"https://api.github.com/repos/tycho01/typings-checker/contributors","subscribers_url":"https://api.github.com/repos/tycho01/typings-checker/subscribers","subscription_url":"https://api.github.com/repos/tycho01/typings-checker/subscription","commits_url":"https://api.github.com/repos/tycho01/typings-checker/commits{/sha}","git_commits_url":"https://api.github.com/repos/tycho01/typings-checker/git/commits{/sha}","comments_url":"https://api.github.com/repos/tycho01/typings-checker/comments{/number}","issue_comment_url":"https://api.github.com/repos/tycho01/typings-checker/issues/comments{/number}","contents_url":"https://api.github.com/repos/tycho01/typings-checker/contents/{+path}","compare_url":"https://api.github.com/repos/tycho01/typings-checker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tycho01/typings-checker/merges","archive_url":"https://api.github.com/repos/tycho01/typings-checker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tycho01/typings-checker/downloads","issues_url":"https://api.github.com/repos/tycho01/typings-checker/issues{/number}","pulls_url":"https://api.github.com/repos/tycho01/typings-checker/pulls{/number}","milestones_url":"https://api.github.com/repos/tycho01/typings-checker/milestones{/number}","notifications_url":"https://api.github.com/repos/tycho01/typings-checker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tycho01/typings-checker/labels{/name}","releases_url":"https://api.github.com/repos/tycho01/typings-checker/releases{/id}","deployments_url":"https://api.github.com/repos/tycho01/typings-checker/deployments","created_at":"2017-01-20T06:33:42Z","updated_at":"2017-01-20T06:33:43Z","pushed_at":"2017-01-23T13:15:26Z","git_url":"git://github.com/tycho01/typings-checker.git","ssh_url":"git@github.com:tycho01/typings-checker.git","clone_url":"https://github.com/tycho01/typings-checker.git","svn_url":"https://github.com/tycho01/typings-checker","homepage":null,"size":40,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"danvk:master","ref":"master","sha":"f268614feab86db89ff4ef55673b97847d5ee999","user":{"login":"danvk","id":98301,"avatar_url":"https://avatars.githubusercontent.com/u/98301?v=3","gravatar_id":"","url":"https://api.github.com/users/danvk","html_url":"https://github.com/danvk","followers_url":"https://api.github.com/users/danvk/followers","following_url":"https://api.github.com/users/danvk/following{/other_user}","gists_url":"https://api.github.com/users/danvk/gists{/gist_id}","starred_url":"https://api.github.com/users/danvk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danvk/subscriptions","organizations_url":"https://api.github.com/users/danvk/orgs","repos_url":"https://api.github.com/users/danvk/repos","events_url":"https://api.github.com/users/danvk/events{/privacy}","received_events_url":"https://api.github.com/users/danvk/received_events","type":"User","site_admin":false},"repo":{"id":78892318,"name":"typings-checker","full_name":"danvk/typings-checker","owner":{"login":"danvk","id":98301,"avatar_url":"https://avatars.githubusercontent.com/u/98301?v=3","gravatar_id":"","url":"https://api.github.com/users/danvk","html_url":"https://github.com/danvk","followers_url":"https://api.github.com/users/danvk/followers","following_url":"https://api.github.com/users/danvk/following{/other_user}","gists_url":"https://api.github.com/users/danvk/gists{/gist_id}","starred_url":"https://api.github.com/users/danvk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danvk/subscriptions","organizations_url":"https://api.github.com/users/danvk/orgs","repos_url":"https://api.github.com/users/danvk/repos","events_url":"https://api.github.com/users/danvk/events{/privacy}","received_events_url":"https://api.github.com/users/danvk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danvk/typings-checker","description":"Positive and negative assertions about TypeScript types and errors","fork":false,"url":"https://api.github.com/repos/danvk/typings-checker","forks_url":"https://api.github.com/repos/danvk/typings-checker/forks","keys_url":"https://api.github.com/repos/danvk/typings-checker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danvk/typings-checker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danvk/typings-checker/teams","hooks_url":"https://api.github.com/repos/danvk/typings-checker/hooks","issue_events_url":"https://api.github.com/repos/danvk/typings-checker/issues/events{/number}","events_url":"https://api.github.com/repos/danvk/typings-checker/events","assignees_url":"https://api.github.com/repos/danvk/typings-checker/assignees{/user}","branches_url":"https://api.github.com/repos/danvk/typings-checker/branches{/branch}","tags_url":"https://api.github.com/repos/danvk/typings-checker/tags","blobs_url":"https://api.github.com/repos/danvk/typings-checker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danvk/typings-checker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danvk/typings-checker/git/refs{/sha}","trees_url":"https://api.github.com/repos/danvk/typings-checker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danvk/typings-checker/statuses/{sha}","languages_url":"https://api.github.com/repos/danvk/typings-checker/languages","stargazers_url":"https://api.github.com/repos/danvk/typings-checker/stargazers","contributors_url":"https://api.github.com/repos/danvk/typings-checker/contributors","subscribers_url":"https://api.github.com/repos/danvk/typings-checker/subscribers","subscription_url":"https://api.github.com/repos/danvk/typings-checker/subscription","commits_url":"https://api.github.com/repos/danvk/typings-checker/commits{/sha}","git_commits_url":"https://api.github.com/repos/danvk/typings-checker/git/commits{/sha}","comments_url":"https://api.github.com/repos/danvk/typings-checker/comments{/number}","issue_comment_url":"https://api.github.com/repos/danvk/typings-checker/issues/comments{/number}","contents_url":"https://api.github.com/repos/danvk/typings-checker/contents/{+path}","compare_url":"https://api.github.com/repos/danvk/typings-checker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danvk/typings-checker/merges","archive_url":"https://api.github.com/repos/danvk/typings-checker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danvk/typings-checker/downloads","issues_url":"https://api.github.com/repos/danvk/typings-checker/issues{/number}","pulls_url":"https://api.github.com/repos/danvk/typings-checker/pulls{/number}","milestones_url":"https://api.github.com/repos/danvk/typings-checker/milestones{/number}","notifications_url":"https://api.github.com/repos/danvk/typings-checker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danvk/typings-checker/labels{/name}","releases_url":"https://api.github.com/repos/danvk/typings-checker/releases{/id}","deployments_url":"https://api.github.com/repos/danvk/typings-checker/deployments","created_at":"2017-01-13T22:39:17Z","updated_at":"2017-01-20T21:45:01Z","pushed_at":"2017-01-23T15:00:37Z","git_url":"git://github.com/danvk/typings-checker.git","ssh_url":"git@github.com:danvk/typings-checker.git","clone_url":"https://github.com/danvk/typings-checker.git","svn_url":"https://github.com/danvk/typings-checker","homepage":"","size":32,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":6,"forks":1,"open_issues":6,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/danvk/typings-checker/pulls/13"},"html":{"href":"https://github.com/danvk/typings-checker/pull/13"},"issue":{"href":"https://api.github.com/repos/danvk/typings-checker/issues/13"},"comments":{"href":"https://api.github.com/repos/danvk/typings-checker/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/danvk/typings-checker/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/danvk/typings-checker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/danvk/typings-checker/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/danvk/typings-checker/statuses/a8bedf2c629434f0714128cc23e9aaf00a1048cd"}}}}
{"actor":{"display_login":"tycho01"}}