{"action":"created","comment":{"url":"https://api.github.com/repos/palantir/tslint/pulls/comments/107479068","pull_request_review_id":28454486,"id":107479068,"diff_hunk":"@@ -74,6 +76,16 @@ export class Rule extends Lint.Rules.AbstractRule {\n class VariableNameWalker extends Lint.RuleWalker {\n     private shouldBanKeywords: boolean;\n     private shouldCheckFormat: boolean;\n+    private get formatFailure(): string {","path":"src/rules/variableNameRule.ts","position":36,"original_position":36,"commit_id":"f267babaac1b78f490570b95a502164a77e7d5dc","original_commit_id":"f267babaac1b78f490570b95a502164a77e7d5dc","user":{"login":"ajafff","id":11968040,"avatar_url":"https://avatars3.githubusercontent.com/u/11968040?v=3","gravatar_id":"","url":"https://api.github.com/users/ajafff","html_url":"https://github.com/ajafff","followers_url":"https://api.github.com/users/ajafff/followers","following_url":"https://api.github.com/users/ajafff/following{/other_user}","gists_url":"https://api.github.com/users/ajafff/gists{/gist_id}","starred_url":"https://api.github.com/users/ajafff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajafff/subscriptions","organizations_url":"https://api.github.com/users/ajafff/orgs","repos_url":"https://api.github.com/users/ajafff/repos","events_url":"https://api.github.com/users/ajafff/events{/privacy}","received_events_url":"https://api.github.com/users/ajafff/received_events","type":"User","site_admin":false},"body":"you don't need a getter for this, just do it once in the constructor","created_at":"2017-03-22T17:27:46Z","updated_at":"2017-03-22T17:31:05Z","html_url":"https://github.com/palantir/tslint/pull/2383#discussion_r107479068","pull_request_url":"https://api.github.com/repos/palantir/tslint/pulls/2383","_links":{"self":{"href":"https://api.github.com/repos/palantir/tslint/pulls/comments/107479068"},"html":{"href":"https://github.com/palantir/tslint/pull/2383#discussion_r107479068"},"pull_request":{"href":"https://api.github.com/repos/palantir/tslint/pulls/2383"}}},"pull_request":{"url":"https://api.github.com/repos/palantir/tslint/pulls/2383","id":111820986,"html_url":"https://github.com/palantir/tslint/pull/2383","diff_url":"https://github.com/palantir/tslint/pull/2383.diff","patch_url":"https://github.com/palantir/tslint/pull/2383.patch","issue_url":"https://api.github.com/repos/palantir/tslint/issues/2383","number":2383,"state":"open","locked":false,"title":"Add OPTION_ALLOW_SNAKE_CASE to variable name options","user":{"login":"AJamesPhillips","id":526509,"avatar_url":"https://avatars3.githubusercontent.com/u/526509?v=3","gravatar_id":"","url":"https://api.github.com/users/AJamesPhillips","html_url":"https://github.com/AJamesPhillips","followers_url":"https://api.github.com/users/AJamesPhillips/followers","following_url":"https://api.github.com/users/AJamesPhillips/following{/other_user}","gists_url":"https://api.github.com/users/AJamesPhillips/gists{/gist_id}","starred_url":"https://api.github.com/users/AJamesPhillips/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AJamesPhillips/subscriptions","organizations_url":"https://api.github.com/users/AJamesPhillips/orgs","repos_url":"https://api.github.com/users/AJamesPhillips/repos","events_url":"https://api.github.com/users/AJamesPhillips/events{/privacy}","received_events_url":"https://api.github.com/users/AJamesPhillips/received_events","type":"User","site_admin":false},"body":"#### PR checklist\r\n\r\n- [x] Addresses an existing issue: #2190\r\n- [x] Is an enhancement\r\n- [x] Does includes tests\r\n- [x] Documentation is updated (assuming the documentation comes from `metadata` on the Rule itself).\r\n\r\n#### Overview of change:\r\n\r\nAdd OPTION_ALLOW_SNAKE_CASE to variable name options\r\n\r\n#### CHANGELOG.md entry:\r\n\r\n    [new-rule-option] \"allow-snake-case\" option for `variable-name` rule (#2190)\r\n\r\n\r\nPlease let me know if there's anything else you need / would like to change.  Many thanks.","created_at":"2017-03-21T16:25:32Z","updated_at":"2017-03-22T17:31:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"27fad75bdfc42961416e72362446f38a0765e0af","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/palantir/tslint/pulls/2383/commits","review_comments_url":"https://api.github.com/repos/palantir/tslint/pulls/2383/comments","review_comment_url":"https://api.github.com/repos/palantir/tslint/pulls/comments{/number}","comments_url":"https://api.github.com/repos/palantir/tslint/issues/2383/comments","statuses_url":"https://api.github.com/repos/palantir/tslint/statuses/f267babaac1b78f490570b95a502164a77e7d5dc","head":{"label":"AJamesPhillips:allow_snake_case","ref":"allow_snake_case","sha":"f267babaac1b78f490570b95a502164a77e7d5dc","user":{"login":"AJamesPhillips","id":526509,"avatar_url":"https://avatars3.githubusercontent.com/u/526509?v=3","gravatar_id":"","url":"https://api.github.com/users/AJamesPhillips","html_url":"https://github.com/AJamesPhillips","followers_url":"https://api.github.com/users/AJamesPhillips/followers","following_url":"https://api.github.com/users/AJamesPhillips/following{/other_user}","gists_url":"https://api.github.com/users/AJamesPhillips/gists{/gist_id}","starred_url":"https://api.github.com/users/AJamesPhillips/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AJamesPhillips/subscriptions","organizations_url":"https://api.github.com/users/AJamesPhillips/orgs","repos_url":"https://api.github.com/users/AJamesPhillips/repos","events_url":"https://api.github.com/users/AJamesPhillips/events{/privacy}","received_events_url":"https://api.github.com/users/AJamesPhillips/received_events","type":"User","site_admin":false},"repo":{"id":85725087,"name":"tslint","full_name":"AJamesPhillips/tslint","owner":{"login":"AJamesPhillips","id":526509,"avatar_url":"https://avatars3.githubusercontent.com/u/526509?v=3","gravatar_id":"","url":"https://api.github.com/users/AJamesPhillips","html_url":"https://github.com/AJamesPhillips","followers_url":"https://api.github.com/users/AJamesPhillips/followers","following_url":"https://api.github.com/users/AJamesPhillips/following{/other_user}","gists_url":"https://api.github.com/users/AJamesPhillips/gists{/gist_id}","starred_url":"https://api.github.com/users/AJamesPhillips/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AJamesPhillips/subscriptions","organizations_url":"https://api.github.com/users/AJamesPhillips/orgs","repos_url":"https://api.github.com/users/AJamesPhillips/repos","events_url":"https://api.github.com/users/AJamesPhillips/events{/privacy}","received_events_url":"https://api.github.com/users/AJamesPhillips/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AJamesPhillips/tslint","description":":vertical_traffic_light: An extensible linter for the TypeScript language","fork":true,"url":"https://api.github.com/repos/AJamesPhillips/tslint","forks_url":"https://api.github.com/repos/AJamesPhillips/tslint/forks","keys_url":"https://api.github.com/repos/AJamesPhillips/tslint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AJamesPhillips/tslint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AJamesPhillips/tslint/teams","hooks_url":"https://api.github.com/repos/AJamesPhillips/tslint/hooks","issue_events_url":"https://api.github.com/repos/AJamesPhillips/tslint/issues/events{/number}","events_url":"https://api.github.com/repos/AJamesPhillips/tslint/events","assignees_url":"https://api.github.com/repos/AJamesPhillips/tslint/assignees{/user}","branches_url":"https://api.github.com/repos/AJamesPhillips/tslint/branches{/branch}","tags_url":"https://api.github.com/repos/AJamesPhillips/tslint/tags","blobs_url":"https://api.github.com/repos/AJamesPhillips/tslint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AJamesPhillips/tslint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AJamesPhillips/tslint/git/refs{/sha}","trees_url":"https://api.github.com/repos/AJamesPhillips/tslint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AJamesPhillips/tslint/statuses/{sha}","languages_url":"https://api.github.com/repos/AJamesPhillips/tslint/languages","stargazers_url":"https://api.github.com/repos/AJamesPhillips/tslint/stargazers","contributors_url":"https://api.github.com/repos/AJamesPhillips/tslint/contributors","subscribers_url":"https://api.github.com/repos/AJamesPhillips/tslint/subscribers","subscription_url":"https://api.github.com/repos/AJamesPhillips/tslint/subscription","commits_url":"https://api.github.com/repos/AJamesPhillips/tslint/commits{/sha}","git_commits_url":"https://api.github.com/repos/AJamesPhillips/tslint/git/commits{/sha}","comments_url":"https://api.github.com/repos/AJamesPhillips/tslint/comments{/number}","issue_comment_url":"https://api.github.com/repos/AJamesPhillips/tslint/issues/comments{/number}","contents_url":"https://api.github.com/repos/AJamesPhillips/tslint/contents/{+path}","compare_url":"https://api.github.com/repos/AJamesPhillips/tslint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AJamesPhillips/tslint/merges","archive_url":"https://api.github.com/repos/AJamesPhillips/tslint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AJamesPhillips/tslint/downloads","issues_url":"https://api.github.com/repos/AJamesPhillips/tslint/issues{/number}","pulls_url":"https://api.github.com/repos/AJamesPhillips/tslint/pulls{/number}","milestones_url":"https://api.github.com/repos/AJamesPhillips/tslint/milestones{/number}","notifications_url":"https://api.github.com/repos/AJamesPhillips/tslint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AJamesPhillips/tslint/labels{/name}","releases_url":"https://api.github.com/repos/AJamesPhillips/tslint/releases{/id}","deployments_url":"https://api.github.com/repos/AJamesPhillips/tslint/deployments","created_at":"2017-03-21T16:12:26Z","updated_at":"2017-03-21T16:12:29Z","pushed_at":"2017-03-21T16:14:59Z","git_url":"git://github.com/AJamesPhillips/tslint.git","ssh_url":"git@github.com:AJamesPhillips/tslint.git","clone_url":"https://github.com/AJamesPhillips/tslint.git","svn_url":"https://github.com/AJamesPhillips/tslint","homepage":"http://palantir.github.io/tslint/","size":11735,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"palantir:master","ref":"master","sha":"c1a167efdd7348ff95432f9e182b46cdaedae5a3","user":{"login":"palantir","id":303157,"avatar_url":"https://avatars3.githubusercontent.com/u/303157?v=3","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"repo":{"id":11672345,"name":"tslint","full_name":"palantir/tslint","owner":{"login":"palantir","id":303157,"avatar_url":"https://avatars3.githubusercontent.com/u/303157?v=3","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/palantir/tslint","description":":vertical_traffic_light: An extensible linter for the TypeScript language","fork":false,"url":"https://api.github.com/repos/palantir/tslint","forks_url":"https://api.github.com/repos/palantir/tslint/forks","keys_url":"https://api.github.com/repos/palantir/tslint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/palantir/tslint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/palantir/tslint/teams","hooks_url":"https://api.github.com/repos/palantir/tslint/hooks","issue_events_url":"https://api.github.com/repos/palantir/tslint/issues/events{/number}","events_url":"https://api.github.com/repos/palantir/tslint/events","assignees_url":"https://api.github.com/repos/palantir/tslint/assignees{/user}","branches_url":"https://api.github.com/repos/palantir/tslint/branches{/branch}","tags_url":"https://api.github.com/repos/palantir/tslint/tags","blobs_url":"https://api.github.com/repos/palantir/tslint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/palantir/tslint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/palantir/tslint/git/refs{/sha}","trees_url":"https://api.github.com/repos/palantir/tslint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/palantir/tslint/statuses/{sha}","languages_url":"https://api.github.com/repos/palantir/tslint/languages","stargazers_url":"https://api.github.com/repos/palantir/tslint/stargazers","contributors_url":"https://api.github.com/repos/palantir/tslint/contributors","subscribers_url":"https://api.github.com/repos/palantir/tslint/subscribers","subscription_url":"https://api.github.com/repos/palantir/tslint/subscription","commits_url":"https://api.github.com/repos/palantir/tslint/commits{/sha}","git_commits_url":"https://api.github.com/repos/palantir/tslint/git/commits{/sha}","comments_url":"https://api.github.com/repos/palantir/tslint/comments{/number}","issue_comment_url":"https://api.github.com/repos/palantir/tslint/issues/comments{/number}","contents_url":"https://api.github.com/repos/palantir/tslint/contents/{+path}","compare_url":"https://api.github.com/repos/palantir/tslint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/palantir/tslint/merges","archive_url":"https://api.github.com/repos/palantir/tslint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/palantir/tslint/downloads","issues_url":"https://api.github.com/repos/palantir/tslint/issues{/number}","pulls_url":"https://api.github.com/repos/palantir/tslint/pulls{/number}","milestones_url":"https://api.github.com/repos/palantir/tslint/milestones{/number}","notifications_url":"https://api.github.com/repos/palantir/tslint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/palantir/tslint/labels{/name}","releases_url":"https://api.github.com/repos/palantir/tslint/releases{/id}","deployments_url":"https://api.github.com/repos/palantir/tslint/deployments","created_at":"2013-07-25T22:19:18Z","updated_at":"2017-03-22T15:38:30Z","pushed_at":"2017-03-22T17:23:54Z","git_url":"git://github.com/palantir/tslint.git","ssh_url":"git@github.com:palantir/tslint.git","clone_url":"https://github.com/palantir/tslint.git","svn_url":"https://github.com/palantir/tslint","homepage":"http://palantir.github.io/tslint/","size":11746,"stargazers_count":1598,"watchers_count":1598,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":362,"mirror_url":null,"open_issues_count":370,"forks":362,"open_issues":370,"watchers":1598,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/palantir/tslint/pulls/2383"},"html":{"href":"https://github.com/palantir/tslint/pull/2383"},"issue":{"href":"https://api.github.com/repos/palantir/tslint/issues/2383"},"comments":{"href":"https://api.github.com/repos/palantir/tslint/issues/2383/comments"},"review_comments":{"href":"https://api.github.com/repos/palantir/tslint/pulls/2383/comments"},"review_comment":{"href":"https://api.github.com/repos/palantir/tslint/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/palantir/tslint/pulls/2383/commits"},"statuses":{"href":"https://api.github.com/repos/palantir/tslint/statuses/f267babaac1b78f490570b95a502164a77e7d5dc"}}}}
{"actor":{"display_login":"ajafff"}}