{"action":"created","comment":{"url":"https://api.github.com/repos/minio/minio/pulls/comments/128461351","pull_request_review_id":51141460,"id":128461351,"diff_hunk":"@@ -34,12 +34,23 @@ class SettingsModal extends React.Component {\n \n     let accessKeyEnv = ''\n     let secretKeyEnv = ''\n-    // Check environment variables first.\n-    if (serverInfo.info.isEnvCreds) {\n+    // Check environment variables first. They may or may not have been\n+    // loaded already; they load in Browse#componentDidMount.\n+    if (serverInfo.envVars) {\n+      serverInfo.envVars.forEach(envVar => {","path":"browser/app/js/components/SettingsModal.js","position":9,"original_position":9,"commit_id":"14c6f7e54546720c8061bd7003d04a62096dfa87","original_commit_id":"14c6f7e54546720c8061bd7003d04a62096dfa87","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').","created_at":"2017-07-20T09:04:11Z","updated_at":"2017-07-20T09:04:11Z","html_url":"https://github.com/minio/minio/pull/4697#discussion_r128461351","pull_request_url":"https://api.github.com/repos/minio/minio/pulls/4697","_links":{"self":{"href":"https://api.github.com/repos/minio/minio/pulls/comments/128461351"},"html":{"href":"https://github.com/minio/minio/pull/4697#discussion_r128461351"},"pull_request":{"href":"https://api.github.com/repos/minio/minio/pulls/4697"}}},"pull_request":{"url":"https://api.github.com/repos/minio/minio/pulls/4697","id":131392471,"html_url":"https://github.com/minio/minio/pull/4697","diff_url":"https://github.com/minio/minio/pull/4697.diff","patch_url":"https://github.com/minio/minio/pull/4697.patch","issue_url":"https://api.github.com/repos/minio/minio/issues/4697","number":4697,"state":"open","locked":false,"title":"Add missing styles and images to the UI migration process","user":{"login":"rushenn","id":13393018,"avatar_url":"https://avatars1.githubusercontent.com/u/13393018?v=4","gravatar_id":"","url":"https://api.github.com/users/rushenn","html_url":"https://github.com/rushenn","followers_url":"https://api.github.com/users/rushenn/followers","following_url":"https://api.github.com/users/rushenn/following{/other_user}","gists_url":"https://api.github.com/users/rushenn/gists{/gist_id}","starred_url":"https://api.github.com/users/rushenn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rushenn/subscriptions","organizations_url":"https://api.github.com/users/rushenn/orgs","repos_url":"https://api.github.com/users/rushenn/repos","events_url":"https://api.github.com/users/rushenn/events{/privacy}","received_events_url":"https://api.github.com/users/rushenn/received_events","type":"User","site_admin":false},"body":"This PR is to merge the ongoing UI changes to the newux branch of the upstream. There are more works and fixes still required to merge this in to the master.","created_at":"2017-07-19T18:45:48Z","updated_at":"2017-07-20T09:04:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"142ab09cf0b61623531a00eec08c557115f235c3","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/minio/minio/pulls/4697/commits","review_comments_url":"https://api.github.com/repos/minio/minio/pulls/4697/comments","review_comment_url":"https://api.github.com/repos/minio/minio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/minio/minio/issues/4697/comments","statuses_url":"https://api.github.com/repos/minio/minio/statuses/14c6f7e54546720c8061bd7003d04a62096dfa87","head":{"label":"rushenn:newux","ref":"newux","sha":"14c6f7e54546720c8061bd7003d04a62096dfa87","user":{"login":"rushenn","id":13393018,"avatar_url":"https://avatars1.githubusercontent.com/u/13393018?v=4","gravatar_id":"","url":"https://api.github.com/users/rushenn","html_url":"https://github.com/rushenn","followers_url":"https://api.github.com/users/rushenn/followers","following_url":"https://api.github.com/users/rushenn/following{/other_user}","gists_url":"https://api.github.com/users/rushenn/gists{/gist_id}","starred_url":"https://api.github.com/users/rushenn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rushenn/subscriptions","organizations_url":"https://api.github.com/users/rushenn/orgs","repos_url":"https://api.github.com/users/rushenn/repos","events_url":"https://api.github.com/users/rushenn/events{/privacy}","received_events_url":"https://api.github.com/users/rushenn/received_events","type":"User","site_admin":false},"repo":{"id":81476309,"name":"minio","full_name":"rushenn/minio","owner":{"login":"rushenn","id":13393018,"avatar_url":"https://avatars1.githubusercontent.com/u/13393018?v=4","gravatar_id":"","url":"https://api.github.com/users/rushenn","html_url":"https://github.com/rushenn","followers_url":"https://api.github.com/users/rushenn/followers","following_url":"https://api.github.com/users/rushenn/following{/other_user}","gists_url":"https://api.github.com/users/rushenn/gists{/gist_id}","starred_url":"https://api.github.com/users/rushenn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rushenn/subscriptions","organizations_url":"https://api.github.com/users/rushenn/orgs","repos_url":"https://api.github.com/users/rushenn/repos","events_url":"https://api.github.com/users/rushenn/events{/privacy}","received_events_url":"https://api.github.com/users/rushenn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rushenn/minio","description":"Minio is an open source object storage server compatible with Amazon S3 APIs","fork":true,"url":"https://api.github.com/repos/rushenn/minio","forks_url":"https://api.github.com/repos/rushenn/minio/forks","keys_url":"https://api.github.com/repos/rushenn/minio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rushenn/minio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rushenn/minio/teams","hooks_url":"https://api.github.com/repos/rushenn/minio/hooks","issue_events_url":"https://api.github.com/repos/rushenn/minio/issues/events{/number}","events_url":"https://api.github.com/repos/rushenn/minio/events","assignees_url":"https://api.github.com/repos/rushenn/minio/assignees{/user}","branches_url":"https://api.github.com/repos/rushenn/minio/branches{/branch}","tags_url":"https://api.github.com/repos/rushenn/minio/tags","blobs_url":"https://api.github.com/repos/rushenn/minio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rushenn/minio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rushenn/minio/git/refs{/sha}","trees_url":"https://api.github.com/repos/rushenn/minio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rushenn/minio/statuses/{sha}","languages_url":"https://api.github.com/repos/rushenn/minio/languages","stargazers_url":"https://api.github.com/repos/rushenn/minio/stargazers","contributors_url":"https://api.github.com/repos/rushenn/minio/contributors","subscribers_url":"https://api.github.com/repos/rushenn/minio/subscribers","subscription_url":"https://api.github.com/repos/rushenn/minio/subscription","commits_url":"https://api.github.com/repos/rushenn/minio/commits{/sha}","git_commits_url":"https://api.github.com/repos/rushenn/minio/git/commits{/sha}","comments_url":"https://api.github.com/repos/rushenn/minio/comments{/number}","issue_comment_url":"https://api.github.com/repos/rushenn/minio/issues/comments{/number}","contents_url":"https://api.github.com/repos/rushenn/minio/contents/{+path}","compare_url":"https://api.github.com/repos/rushenn/minio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rushenn/minio/merges","archive_url":"https://api.github.com/repos/rushenn/minio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rushenn/minio/downloads","issues_url":"https://api.github.com/repos/rushenn/minio/issues{/number}","pulls_url":"https://api.github.com/repos/rushenn/minio/pulls{/number}","milestones_url":"https://api.github.com/repos/rushenn/minio/milestones{/number}","notifications_url":"https://api.github.com/repos/rushenn/minio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rushenn/minio/labels{/name}","releases_url":"https://api.github.com/repos/rushenn/minio/releases{/id}","deployments_url":"https://api.github.com/repos/rushenn/minio/deployments","created_at":"2017-02-09T17:30:59Z","updated_at":"2017-02-09T17:31:02Z","pushed_at":"2017-07-20T09:03:56Z","git_url":"git://github.com/rushenn/minio.git","ssh_url":"git@github.com:rushenn/minio.git","clone_url":"https://github.com/rushenn/minio.git","svn_url":"https://github.com/rushenn/minio","homepage":"https://minio.io","size":26678,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"minio:newux","ref":"newux","sha":"cf696cfd85514b3632b74b82597449fb72c91feb","user":{"login":"minio","id":695951,"avatar_url":"https://avatars3.githubusercontent.com/u/695951?v=4","gravatar_id":"","url":"https://api.github.com/users/minio","html_url":"https://github.com/minio","followers_url":"https://api.github.com/users/minio/followers","following_url":"https://api.github.com/users/minio/following{/other_user}","gists_url":"https://api.github.com/users/minio/gists{/gist_id}","starred_url":"https://api.github.com/users/minio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minio/subscriptions","organizations_url":"https://api.github.com/users/minio/orgs","repos_url":"https://api.github.com/users/minio/repos","events_url":"https://api.github.com/users/minio/events{/privacy}","received_events_url":"https://api.github.com/users/minio/received_events","type":"Organization","site_admin":false},"repo":{"id":29261473,"name":"minio","full_name":"minio/minio","owner":{"login":"minio","id":695951,"avatar_url":"https://avatars3.githubusercontent.com/u/695951?v=4","gravatar_id":"","url":"https://api.github.com/users/minio","html_url":"https://github.com/minio","followers_url":"https://api.github.com/users/minio/followers","following_url":"https://api.github.com/users/minio/following{/other_user}","gists_url":"https://api.github.com/users/minio/gists{/gist_id}","starred_url":"https://api.github.com/users/minio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minio/subscriptions","organizations_url":"https://api.github.com/users/minio/orgs","repos_url":"https://api.github.com/users/minio/repos","events_url":"https://api.github.com/users/minio/events{/privacy}","received_events_url":"https://api.github.com/users/minio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/minio/minio","description":"Minio is an open source object storage server compatible with Amazon S3 APIs","fork":false,"url":"https://api.github.com/repos/minio/minio","forks_url":"https://api.github.com/repos/minio/minio/forks","keys_url":"https://api.github.com/repos/minio/minio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minio/minio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minio/minio/teams","hooks_url":"https://api.github.com/repos/minio/minio/hooks","issue_events_url":"https://api.github.com/repos/minio/minio/issues/events{/number}","events_url":"https://api.github.com/repos/minio/minio/events","assignees_url":"https://api.github.com/repos/minio/minio/assignees{/user}","branches_url":"https://api.github.com/repos/minio/minio/branches{/branch}","tags_url":"https://api.github.com/repos/minio/minio/tags","blobs_url":"https://api.github.com/repos/minio/minio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minio/minio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minio/minio/git/refs{/sha}","trees_url":"https://api.github.com/repos/minio/minio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minio/minio/statuses/{sha}","languages_url":"https://api.github.com/repos/minio/minio/languages","stargazers_url":"https://api.github.com/repos/minio/minio/stargazers","contributors_url":"https://api.github.com/repos/minio/minio/contributors","subscribers_url":"https://api.github.com/repos/minio/minio/subscribers","subscription_url":"https://api.github.com/repos/minio/minio/subscription","commits_url":"https://api.github.com/repos/minio/minio/commits{/sha}","git_commits_url":"https://api.github.com/repos/minio/minio/git/commits{/sha}","comments_url":"https://api.github.com/repos/minio/minio/comments{/number}","issue_comment_url":"https://api.github.com/repos/minio/minio/issues/comments{/number}","contents_url":"https://api.github.com/repos/minio/minio/contents/{+path}","compare_url":"https://api.github.com/repos/minio/minio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minio/minio/merges","archive_url":"https://api.github.com/repos/minio/minio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minio/minio/downloads","issues_url":"https://api.github.com/repos/minio/minio/issues{/number}","pulls_url":"https://api.github.com/repos/minio/minio/pulls{/number}","milestones_url":"https://api.github.com/repos/minio/minio/milestones{/number}","notifications_url":"https://api.github.com/repos/minio/minio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minio/minio/labels{/name}","releases_url":"https://api.github.com/repos/minio/minio/releases{/id}","deployments_url":"https://api.github.com/repos/minio/minio/deployments","created_at":"2015-01-14T19:23:58Z","updated_at":"2017-07-20T08:30:25Z","pushed_at":"2017-07-20T09:03:58Z","git_url":"git://github.com/minio/minio.git","ssh_url":"git@github.com:minio/minio.git","clone_url":"https://github.com/minio/minio.git","svn_url":"https://github.com/minio/minio","homepage":"https://minio.io","size":26838,"stargazers_count":7498,"watchers_count":7498,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":562,"mirror_url":null,"open_issues_count":153,"forks":562,"open_issues":153,"watchers":7498,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/minio/minio/pulls/4697"},"html":{"href":"https://github.com/minio/minio/pull/4697"},"issue":{"href":"https://api.github.com/repos/minio/minio/issues/4697"},"comments":{"href":"https://api.github.com/repos/minio/minio/issues/4697/comments"},"review_comments":{"href":"https://api.github.com/repos/minio/minio/pulls/4697/comments"},"review_comment":{"href":"https://api.github.com/repos/minio/minio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/minio/minio/pulls/4697/commits"},"statuses":{"href":"https://api.github.com/repos/minio/minio/statuses/14c6f7e54546720c8061bd7003d04a62096dfa87"}}}}
{"actor":{"display_login":"houndci-bot"}}