{"action":"created","comment":{"url":"https://api.github.com/repos/RIPE-NCC/whois/pulls/comments/101524572","pull_request_review_id":22253752,"id":101524572,"diff_hunk":"@@ -255,9 +255,24 @@ public int compareUpperBound(final Ipv6Resource that) {\n \n     @Override\n     public InetAddress beginAsInetAddress() {\n-        final byte[] bytes = new byte[16];\n-        System.arraycopy(Longs.toByteArray(beginMsb), 0, bytes, 8, 8);\n-        System.arraycopy(Longs.toByteArray(beginLsb), 0, bytes, 0, 8);\n+        byte[] bytes = new byte[16];\n+\n+        System.arraycopy(Longs.toByteArray(beginMsb), 0, bytes, 0, 8);\n+        System.arraycopy(Longs.toByteArray(beginLsb), 0, bytes, 8, 8);\n+        try {\n+            return Inet6Address.getByAddress(bytes);\n+        } catch (UnknownHostException e) {\n+            // this will never happen","path":"whois-rpsl/src/main/java/net/ripe/db/whois/common/ip/Ipv6Resource.java","position":23,"original_position":23,"commit_id":"2f42c240f238467988668b5e39d2c381e79f7e30","original_commit_id":"2f42c240f238467988668b5e39d2c381e79f7e30","user":{"login":"dacruz","id":126207,"avatar_url":"https://avatars.githubusercontent.com/u/126207?v=3","gravatar_id":"","url":"https://api.github.com/users/dacruz","html_url":"https://github.com/dacruz","followers_url":"https://api.github.com/users/dacruz/followers","following_url":"https://api.github.com/users/dacruz/following{/other_user}","gists_url":"https://api.github.com/users/dacruz/gists{/gist_id}","starred_url":"https://api.github.com/users/dacruz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dacruz/subscriptions","organizations_url":"https://api.github.com/users/dacruz/orgs","repos_url":"https://api.github.com/users/dacruz/repos","events_url":"https://api.github.com/users/dacruz/events{/privacy}","received_events_url":"https://api.github.com/users/dacruz/received_events","type":"User","site_admin":false},"body":"Should we at least log it? DEBUG? ","created_at":"2017-02-16T14:04:17Z","updated_at":"2017-02-16T14:20:58Z","html_url":"https://github.com/RIPE-NCC/whois/pull/420#discussion_r101524572","pull_request_url":"https://api.github.com/repos/RIPE-NCC/whois/pulls/420","_links":{"self":{"href":"https://api.github.com/repos/RIPE-NCC/whois/pulls/comments/101524572"},"html":{"href":"https://github.com/RIPE-NCC/whois/pull/420#discussion_r101524572"},"pull_request":{"href":"https://api.github.com/repos/RIPE-NCC/whois/pulls/420"}}},"pull_request":{"url":"https://api.github.com/repos/RIPE-NCC/whois/pulls/420","id":106526270,"html_url":"https://github.com/RIPE-NCC/whois/pull/420","diff_url":"https://github.com/RIPE-NCC/whois/pull/420.diff","patch_url":"https://github.com/RIPE-NCC/whois/pull/420.patch","issue_url":"https://api.github.com/repos/RIPE-NCC/whois/issues/420","number":420,"state":"open","locked":false,"title":"Merge beta RDAP feature for production release","user":{"login":"eshryane","id":3716902,"avatar_url":"https://avatars.githubusercontent.com/u/3716902?v=3","gravatar_id":"","url":"https://api.github.com/users/eshryane","html_url":"https://github.com/eshryane","followers_url":"https://api.github.com/users/eshryane/followers","following_url":"https://api.github.com/users/eshryane/following{/other_user}","gists_url":"https://api.github.com/users/eshryane/gists{/gist_id}","starred_url":"https://api.github.com/users/eshryane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eshryane/subscriptions","organizations_url":"https://api.github.com/users/eshryane/orgs","repos_url":"https://api.github.com/users/eshryane/repos","events_url":"https://api.github.com/users/eshryane/events{/privacy}","received_events_url":"https://api.github.com/users/eshryane/received_events","type":"User","site_admin":false},"body":"To get started, have a look at the WhoisRdapService.java (the entry-point service for the REST API) and WhoisRdapServiceTestIntegration.java (lots of integration tests)","created_at":"2017-02-16T13:35:50Z","updated_at":"2017-02-16T14:20:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"81f6e1917f4b1566f2874e9c756eba8e76e8cb48","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/RIPE-NCC/whois/pulls/420/commits","review_comments_url":"https://api.github.com/repos/RIPE-NCC/whois/pulls/420/comments","review_comment_url":"https://api.github.com/repos/RIPE-NCC/whois/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RIPE-NCC/whois/issues/420/comments","statuses_url":"https://api.github.com/repos/RIPE-NCC/whois/statuses/2f42c240f238467988668b5e39d2c381e79f7e30","head":{"label":"RIPE-NCC:rdap","ref":"rdap","sha":"2f42c240f238467988668b5e39d2c381e79f7e30","user":{"login":"RIPE-NCC","id":1096476,"avatar_url":"https://avatars.githubusercontent.com/u/1096476?v=3","gravatar_id":"","url":"https://api.github.com/users/RIPE-NCC","html_url":"https://github.com/RIPE-NCC","followers_url":"https://api.github.com/users/RIPE-NCC/followers","following_url":"https://api.github.com/users/RIPE-NCC/following{/other_user}","gists_url":"https://api.github.com/users/RIPE-NCC/gists{/gist_id}","starred_url":"https://api.github.com/users/RIPE-NCC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RIPE-NCC/subscriptions","organizations_url":"https://api.github.com/users/RIPE-NCC/orgs","repos_url":"https://api.github.com/users/RIPE-NCC/repos","events_url":"https://api.github.com/users/RIPE-NCC/events{/privacy}","received_events_url":"https://api.github.com/users/RIPE-NCC/received_events","type":"Organization","site_admin":false},"repo":{"id":9909566,"name":"whois","full_name":"RIPE-NCC/whois","owner":{"login":"RIPE-NCC","id":1096476,"avatar_url":"https://avatars.githubusercontent.com/u/1096476?v=3","gravatar_id":"","url":"https://api.github.com/users/RIPE-NCC","html_url":"https://github.com/RIPE-NCC","followers_url":"https://api.github.com/users/RIPE-NCC/followers","following_url":"https://api.github.com/users/RIPE-NCC/following{/other_user}","gists_url":"https://api.github.com/users/RIPE-NCC/gists{/gist_id}","starred_url":"https://api.github.com/users/RIPE-NCC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RIPE-NCC/subscriptions","organizations_url":"https://api.github.com/users/RIPE-NCC/orgs","repos_url":"https://api.github.com/users/RIPE-NCC/repos","events_url":"https://api.github.com/users/RIPE-NCC/events{/privacy}","received_events_url":"https://api.github.com/users/RIPE-NCC/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RIPE-NCC/whois","description":"RIPE Database whois code repository","fork":false,"url":"https://api.github.com/repos/RIPE-NCC/whois","forks_url":"https://api.github.com/repos/RIPE-NCC/whois/forks","keys_url":"https://api.github.com/repos/RIPE-NCC/whois/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RIPE-NCC/whois/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RIPE-NCC/whois/teams","hooks_url":"https://api.github.com/repos/RIPE-NCC/whois/hooks","issue_events_url":"https://api.github.com/repos/RIPE-NCC/whois/issues/events{/number}","events_url":"https://api.github.com/repos/RIPE-NCC/whois/events","assignees_url":"https://api.github.com/repos/RIPE-NCC/whois/assignees{/user}","branches_url":"https://api.github.com/repos/RIPE-NCC/whois/branches{/branch}","tags_url":"https://api.github.com/repos/RIPE-NCC/whois/tags","blobs_url":"https://api.github.com/repos/RIPE-NCC/whois/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RIPE-NCC/whois/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RIPE-NCC/whois/git/refs{/sha}","trees_url":"https://api.github.com/repos/RIPE-NCC/whois/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RIPE-NCC/whois/statuses/{sha}","languages_url":"https://api.github.com/repos/RIPE-NCC/whois/languages","stargazers_url":"https://api.github.com/repos/RIPE-NCC/whois/stargazers","contributors_url":"https://api.github.com/repos/RIPE-NCC/whois/contributors","subscribers_url":"https://api.github.com/repos/RIPE-NCC/whois/subscribers","subscription_url":"https://api.github.com/repos/RIPE-NCC/whois/subscription","commits_url":"https://api.github.com/repos/RIPE-NCC/whois/commits{/sha}","git_commits_url":"https://api.github.com/repos/RIPE-NCC/whois/git/commits{/sha}","comments_url":"https://api.github.com/repos/RIPE-NCC/whois/comments{/number}","issue_comment_url":"https://api.github.com/repos/RIPE-NCC/whois/issues/comments{/number}","contents_url":"https://api.github.com/repos/RIPE-NCC/whois/contents/{+path}","compare_url":"https://api.github.com/repos/RIPE-NCC/whois/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RIPE-NCC/whois/merges","archive_url":"https://api.github.com/repos/RIPE-NCC/whois/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RIPE-NCC/whois/downloads","issues_url":"https://api.github.com/repos/RIPE-NCC/whois/issues{/number}","pulls_url":"https://api.github.com/repos/RIPE-NCC/whois/pulls{/number}","milestones_url":"https://api.github.com/repos/RIPE-NCC/whois/milestones{/number}","notifications_url":"https://api.github.com/repos/RIPE-NCC/whois/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RIPE-NCC/whois/labels{/name}","releases_url":"https://api.github.com/repos/RIPE-NCC/whois/releases{/id}","deployments_url":"https://api.github.com/repos/RIPE-NCC/whois/deployments","created_at":"2013-05-07T10:38:10Z","updated_at":"2017-02-15T15:53:29Z","pushed_at":"2017-02-16T13:35:51Z","git_url":"git://github.com/RIPE-NCC/whois.git","ssh_url":"git@github.com:RIPE-NCC/whois.git","clone_url":"https://github.com/RIPE-NCC/whois.git","svn_url":"https://github.com/RIPE-NCC/whois","homepage":null,"size":17453,"stargazers_count":109,"watchers_count":109,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"open_issues_count":9,"forks":33,"open_issues":9,"watchers":109,"default_branch":"master"}},"base":{"label":"RIPE-NCC:master","ref":"master","sha":"a2ab3b982d052bd06ddca2c6f989f8323d1583d7","user":{"login":"RIPE-NCC","id":1096476,"avatar_url":"https://avatars.githubusercontent.com/u/1096476?v=3","gravatar_id":"","url":"https://api.github.com/users/RIPE-NCC","html_url":"https://github.com/RIPE-NCC","followers_url":"https://api.github.com/users/RIPE-NCC/followers","following_url":"https://api.github.com/users/RIPE-NCC/following{/other_user}","gists_url":"https://api.github.com/users/RIPE-NCC/gists{/gist_id}","starred_url":"https://api.github.com/users/RIPE-NCC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RIPE-NCC/subscriptions","organizations_url":"https://api.github.com/users/RIPE-NCC/orgs","repos_url":"https://api.github.com/users/RIPE-NCC/repos","events_url":"https://api.github.com/users/RIPE-NCC/events{/privacy}","received_events_url":"https://api.github.com/users/RIPE-NCC/received_events","type":"Organization","site_admin":false},"repo":{"id":9909566,"name":"whois","full_name":"RIPE-NCC/whois","owner":{"login":"RIPE-NCC","id":1096476,"avatar_url":"https://avatars.githubusercontent.com/u/1096476?v=3","gravatar_id":"","url":"https://api.github.com/users/RIPE-NCC","html_url":"https://github.com/RIPE-NCC","followers_url":"https://api.github.com/users/RIPE-NCC/followers","following_url":"https://api.github.com/users/RIPE-NCC/following{/other_user}","gists_url":"https://api.github.com/users/RIPE-NCC/gists{/gist_id}","starred_url":"https://api.github.com/users/RIPE-NCC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RIPE-NCC/subscriptions","organizations_url":"https://api.github.com/users/RIPE-NCC/orgs","repos_url":"https://api.github.com/users/RIPE-NCC/repos","events_url":"https://api.github.com/users/RIPE-NCC/events{/privacy}","received_events_url":"https://api.github.com/users/RIPE-NCC/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RIPE-NCC/whois","description":"RIPE Database whois code repository","fork":false,"url":"https://api.github.com/repos/RIPE-NCC/whois","forks_url":"https://api.github.com/repos/RIPE-NCC/whois/forks","keys_url":"https://api.github.com/repos/RIPE-NCC/whois/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RIPE-NCC/whois/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RIPE-NCC/whois/teams","hooks_url":"https://api.github.com/repos/RIPE-NCC/whois/hooks","issue_events_url":"https://api.github.com/repos/RIPE-NCC/whois/issues/events{/number}","events_url":"https://api.github.com/repos/RIPE-NCC/whois/events","assignees_url":"https://api.github.com/repos/RIPE-NCC/whois/assignees{/user}","branches_url":"https://api.github.com/repos/RIPE-NCC/whois/branches{/branch}","tags_url":"https://api.github.com/repos/RIPE-NCC/whois/tags","blobs_url":"https://api.github.com/repos/RIPE-NCC/whois/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RIPE-NCC/whois/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RIPE-NCC/whois/git/refs{/sha}","trees_url":"https://api.github.com/repos/RIPE-NCC/whois/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RIPE-NCC/whois/statuses/{sha}","languages_url":"https://api.github.com/repos/RIPE-NCC/whois/languages","stargazers_url":"https://api.github.com/repos/RIPE-NCC/whois/stargazers","contributors_url":"https://api.github.com/repos/RIPE-NCC/whois/contributors","subscribers_url":"https://api.github.com/repos/RIPE-NCC/whois/subscribers","subscription_url":"https://api.github.com/repos/RIPE-NCC/whois/subscription","commits_url":"https://api.github.com/repos/RIPE-NCC/whois/commits{/sha}","git_commits_url":"https://api.github.com/repos/RIPE-NCC/whois/git/commits{/sha}","comments_url":"https://api.github.com/repos/RIPE-NCC/whois/comments{/number}","issue_comment_url":"https://api.github.com/repos/RIPE-NCC/whois/issues/comments{/number}","contents_url":"https://api.github.com/repos/RIPE-NCC/whois/contents/{+path}","compare_url":"https://api.github.com/repos/RIPE-NCC/whois/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RIPE-NCC/whois/merges","archive_url":"https://api.github.com/repos/RIPE-NCC/whois/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RIPE-NCC/whois/downloads","issues_url":"https://api.github.com/repos/RIPE-NCC/whois/issues{/number}","pulls_url":"https://api.github.com/repos/RIPE-NCC/whois/pulls{/number}","milestones_url":"https://api.github.com/repos/RIPE-NCC/whois/milestones{/number}","notifications_url":"https://api.github.com/repos/RIPE-NCC/whois/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RIPE-NCC/whois/labels{/name}","releases_url":"https://api.github.com/repos/RIPE-NCC/whois/releases{/id}","deployments_url":"https://api.github.com/repos/RIPE-NCC/whois/deployments","created_at":"2013-05-07T10:38:10Z","updated_at":"2017-02-15T15:53:29Z","pushed_at":"2017-02-16T13:35:51Z","git_url":"git://github.com/RIPE-NCC/whois.git","ssh_url":"git@github.com:RIPE-NCC/whois.git","clone_url":"https://github.com/RIPE-NCC/whois.git","svn_url":"https://github.com/RIPE-NCC/whois","homepage":null,"size":17453,"stargazers_count":109,"watchers_count":109,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"open_issues_count":9,"forks":33,"open_issues":9,"watchers":109,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RIPE-NCC/whois/pulls/420"},"html":{"href":"https://github.com/RIPE-NCC/whois/pull/420"},"issue":{"href":"https://api.github.com/repos/RIPE-NCC/whois/issues/420"},"comments":{"href":"https://api.github.com/repos/RIPE-NCC/whois/issues/420/comments"},"review_comments":{"href":"https://api.github.com/repos/RIPE-NCC/whois/pulls/420/comments"},"review_comment":{"href":"https://api.github.com/repos/RIPE-NCC/whois/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RIPE-NCC/whois/pulls/420/commits"},"statuses":{"href":"https://api.github.com/repos/RIPE-NCC/whois/statuses/2f42c240f238467988668b5e39d2c381e79f7e30"}}}}
{"actor":{"display_login":"dacruz"}}