{"action":"created","comment":{"url":"https://api.github.com/repos/cloudposse/tf_subnets/pulls/comments/138378845","pull_request_review_id":62158812,"id":138378845,"diff_hunk":"@@ -13,10 +13,17 @@ data \"aws_vpc\" \"default\" {\n \n data \"aws_availability_zones\" \"available\" {}\n \n+resource \"null_resource\" \"depends_on\" {","path":"main.tf","position":4,"original_position":4,"commit_id":"ae672765a08daa9cbad90f72de8662c95f7c8093","original_commit_id":"ae672765a08daa9cbad90f72de8662c95f7c8093","user":{"login":"comeanother","id":11299538,"avatar_url":"https://avatars2.githubusercontent.com/u/11299538?v=4","gravatar_id":"","url":"https://api.github.com/users/comeanother","html_url":"https://github.com/comeanother","followers_url":"https://api.github.com/users/comeanother/followers","following_url":"https://api.github.com/users/comeanother/following{/other_user}","gists_url":"https://api.github.com/users/comeanother/gists{/gist_id}","starred_url":"https://api.github.com/users/comeanother/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/comeanother/subscriptions","organizations_url":"https://api.github.com/users/comeanother/orgs","repos_url":"https://api.github.com/users/comeanother/repos","events_url":"https://api.github.com/users/comeanother/events{/privacy}","received_events_url":"https://api.github.com/users/comeanother/received_events","type":"User","site_admin":false},"body":"If we return `igw_id` (see #11), this resource may be not required.","created_at":"2017-09-12T15:15:21Z","updated_at":"2017-09-12T15:19:18Z","html_url":"https://github.com/cloudposse/tf_subnets/pull/15#discussion_r138378845","pull_request_url":"https://api.github.com/repos/cloudposse/tf_subnets/pulls/15","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/cloudposse/tf_subnets/pulls/comments/138378845"},"html":{"href":"https://github.com/cloudposse/tf_subnets/pull/15#discussion_r138378845"},"pull_request":{"href":"https://api.github.com/repos/cloudposse/tf_subnets/pulls/15"}}},"pull_request":{"url":"https://api.github.com/repos/cloudposse/tf_subnets/pulls/15","id":140389728,"html_url":"https://github.com/cloudposse/tf_subnets/pull/15","diff_url":"https://github.com/cloudposse/tf_subnets/pull/15.diff","patch_url":"https://github.com/cloudposse/tf_subnets/pull/15.patch","issue_url":"https://api.github.com/repos/cloudposse/tf_subnets/issues/15","number":15,"state":"open","locked":false,"title":"Added `depends_on` for data `aws_internet_gateway`","user":{"login":"s2504s","id":1134449,"avatar_url":"https://avatars2.githubusercontent.com/u/1134449?v=4","gravatar_id":"","url":"https://api.github.com/users/s2504s","html_url":"https://github.com/s2504s","followers_url":"https://api.github.com/users/s2504s/followers","following_url":"https://api.github.com/users/s2504s/following{/other_user}","gists_url":"https://api.github.com/users/s2504s/gists{/gist_id}","starred_url":"https://api.github.com/users/s2504s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s2504s/subscriptions","organizations_url":"https://api.github.com/users/s2504s/orgs","repos_url":"https://api.github.com/users/s2504s/repos","events_url":"https://api.github.com/users/s2504s/events{/privacy}","received_events_url":"https://api.github.com/users/s2504s/received_events","type":"User","site_admin":false},"body":"## What \r\n* Added the ability to create `Network ACLs`\r\n* Added option `depends_on` for `data.aws_internet_gateway`\r\n\r\n## Why\r\n* We need this in order to consolidate network security rules to security groups only\r\n* When we create the internet gateway with `tf_subnets` module into the same TF manifest - we get the issue:\r\n``` \r\nmodule.subnets.data.aws_internet_gateway.default: data.aws_internet_gateway.default: Your query returned no results. Please change your search criteria and try again\r\n```\r\n\r\n","created_at":"2017-09-11T17:18:00Z","updated_at":"2017-09-12T15:19:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"25d76b229869e1e7a891c12469433fd3d8ca780d","assignee":{"login":"s2504s","id":1134449,"avatar_url":"https://avatars2.githubusercontent.com/u/1134449?v=4","gravatar_id":"","url":"https://api.github.com/users/s2504s","html_url":"https://github.com/s2504s","followers_url":"https://api.github.com/users/s2504s/followers","following_url":"https://api.github.com/users/s2504s/following{/other_user}","gists_url":"https://api.github.com/users/s2504s/gists{/gist_id}","starred_url":"https://api.github.com/users/s2504s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s2504s/subscriptions","organizations_url":"https://api.github.com/users/s2504s/orgs","repos_url":"https://api.github.com/users/s2504s/repos","events_url":"https://api.github.com/users/s2504s/events{/privacy}","received_events_url":"https://api.github.com/users/s2504s/received_events","type":"User","site_admin":false},"assignees":[{"login":"s2504s","id":1134449,"avatar_url":"https://avatars2.githubusercontent.com/u/1134449?v=4","gravatar_id":"","url":"https://api.github.com/users/s2504s","html_url":"https://github.com/s2504s","followers_url":"https://api.github.com/users/s2504s/followers","following_url":"https://api.github.com/users/s2504s/following{/other_user}","gists_url":"https://api.github.com/users/s2504s/gists{/gist_id}","starred_url":"https://api.github.com/users/s2504s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s2504s/subscriptions","organizations_url":"https://api.github.com/users/s2504s/orgs","repos_url":"https://api.github.com/users/s2504s/repos","events_url":"https://api.github.com/users/s2504s/events{/privacy}","received_events_url":"https://api.github.com/users/s2504s/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/cloudposse/tf_subnets/pulls/15/commits","review_comments_url":"https://api.github.com/repos/cloudposse/tf_subnets/pulls/15/comments","review_comment_url":"https://api.github.com/repos/cloudposse/tf_subnets/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cloudposse/tf_subnets/issues/15/comments","statuses_url":"https://api.github.com/repos/cloudposse/tf_subnets/statuses/ae672765a08daa9cbad90f72de8662c95f7c8093","head":{"label":"cloudposse:add_acl","ref":"add_acl","sha":"ae672765a08daa9cbad90f72de8662c95f7c8093","user":{"login":"cloudposse","id":16398900,"avatar_url":"https://avatars2.githubusercontent.com/u/16398900?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudposse","html_url":"https://github.com/cloudposse","followers_url":"https://api.github.com/users/cloudposse/followers","following_url":"https://api.github.com/users/cloudposse/following{/other_user}","gists_url":"https://api.github.com/users/cloudposse/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudposse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudposse/subscriptions","organizations_url":"https://api.github.com/users/cloudposse/orgs","repos_url":"https://api.github.com/users/cloudposse/repos","events_url":"https://api.github.com/users/cloudposse/events{/privacy}","received_events_url":"https://api.github.com/users/cloudposse/received_events","type":"Organization","site_admin":false},"repo":{"id":99687248,"name":"tf_subnets","full_name":"cloudposse/tf_subnets","owner":{"login":"cloudposse","id":16398900,"avatar_url":"https://avatars2.githubusercontent.com/u/16398900?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudposse","html_url":"https://github.com/cloudposse","followers_url":"https://api.github.com/users/cloudposse/followers","following_url":"https://api.github.com/users/cloudposse/following{/other_user}","gists_url":"https://api.github.com/users/cloudposse/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudposse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudposse/subscriptions","organizations_url":"https://api.github.com/users/cloudposse/orgs","repos_url":"https://api.github.com/users/cloudposse/repos","events_url":"https://api.github.com/users/cloudposse/events{/privacy}","received_events_url":"https://api.github.com/users/cloudposse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cloudposse/tf_subnets","description":"Terraform module for public and private subnets provisioning in existing VPC","fork":false,"url":"https://api.github.com/repos/cloudposse/tf_subnets","forks_url":"https://api.github.com/repos/cloudposse/tf_subnets/forks","keys_url":"https://api.github.com/repos/cloudposse/tf_subnets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudposse/tf_subnets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudposse/tf_subnets/teams","hooks_url":"https://api.github.com/repos/cloudposse/tf_subnets/hooks","issue_events_url":"https://api.github.com/repos/cloudposse/tf_subnets/issues/events{/number}","events_url":"https://api.github.com/repos/cloudposse/tf_subnets/events","assignees_url":"https://api.github.com/repos/cloudposse/tf_subnets/assignees{/user}","branches_url":"https://api.github.com/repos/cloudposse/tf_subnets/branches{/branch}","tags_url":"https://api.github.com/repos/cloudposse/tf_subnets/tags","blobs_url":"https://api.github.com/repos/cloudposse/tf_subnets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudposse/tf_subnets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudposse/tf_subnets/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudposse/tf_subnets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudposse/tf_subnets/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudposse/tf_subnets/languages","stargazers_url":"https://api.github.com/repos/cloudposse/tf_subnets/stargazers","contributors_url":"https://api.github.com/repos/cloudposse/tf_subnets/contributors","subscribers_url":"https://api.github.com/repos/cloudposse/tf_subnets/subscribers","subscription_url":"https://api.github.com/repos/cloudposse/tf_subnets/subscription","commits_url":"https://api.github.com/repos/cloudposse/tf_subnets/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudposse/tf_subnets/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudposse/tf_subnets/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudposse/tf_subnets/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloudposse/tf_subnets/contents/{+path}","compare_url":"https://api.github.com/repos/cloudposse/tf_subnets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudposse/tf_subnets/merges","archive_url":"https://api.github.com/repos/cloudposse/tf_subnets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudposse/tf_subnets/downloads","issues_url":"https://api.github.com/repos/cloudposse/tf_subnets/issues{/number}","pulls_url":"https://api.github.com/repos/cloudposse/tf_subnets/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudposse/tf_subnets/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudposse/tf_subnets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudposse/tf_subnets/labels{/name}","releases_url":"https://api.github.com/repos/cloudposse/tf_subnets/releases{/id}","deployments_url":"https://api.github.com/repos/cloudposse/tf_subnets/deployments","created_at":"2017-08-08T11:53:10Z","updated_at":"2017-08-15T10:14:34Z","pushed_at":"2017-09-12T08:53:52Z","git_url":"git://github.com/cloudposse/tf_subnets.git","ssh_url":"git@github.com:cloudposse/tf_subnets.git","clone_url":"https://github.com/cloudposse/tf_subnets.git","svn_url":"https://github.com/cloudposse/tf_subnets","homepage":"","size":20,"stargazers_count":0,"watchers_count":0,"language":"HCL","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"cloudposse:master","ref":"master","sha":"7e5ab3fd01d3181bea85d2e2c5303aeb65d5d42f","user":{"login":"cloudposse","id":16398900,"avatar_url":"https://avatars2.githubusercontent.com/u/16398900?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudposse","html_url":"https://github.com/cloudposse","followers_url":"https://api.github.com/users/cloudposse/followers","following_url":"https://api.github.com/users/cloudposse/following{/other_user}","gists_url":"https://api.github.com/users/cloudposse/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudposse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudposse/subscriptions","organizations_url":"https://api.github.com/users/cloudposse/orgs","repos_url":"https://api.github.com/users/cloudposse/repos","events_url":"https://api.github.com/users/cloudposse/events{/privacy}","received_events_url":"https://api.github.com/users/cloudposse/received_events","type":"Organization","site_admin":false},"repo":{"id":99687248,"name":"tf_subnets","full_name":"cloudposse/tf_subnets","owner":{"login":"cloudposse","id":16398900,"avatar_url":"https://avatars2.githubusercontent.com/u/16398900?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudposse","html_url":"https://github.com/cloudposse","followers_url":"https://api.github.com/users/cloudposse/followers","following_url":"https://api.github.com/users/cloudposse/following{/other_user}","gists_url":"https://api.github.com/users/cloudposse/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudposse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudposse/subscriptions","organizations_url":"https://api.github.com/users/cloudposse/orgs","repos_url":"https://api.github.com/users/cloudposse/repos","events_url":"https://api.github.com/users/cloudposse/events{/privacy}","received_events_url":"https://api.github.com/users/cloudposse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cloudposse/tf_subnets","description":"Terraform module for public and private subnets provisioning in existing VPC","fork":false,"url":"https://api.github.com/repos/cloudposse/tf_subnets","forks_url":"https://api.github.com/repos/cloudposse/tf_subnets/forks","keys_url":"https://api.github.com/repos/cloudposse/tf_subnets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudposse/tf_subnets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudposse/tf_subnets/teams","hooks_url":"https://api.github.com/repos/cloudposse/tf_subnets/hooks","issue_events_url":"https://api.github.com/repos/cloudposse/tf_subnets/issues/events{/number}","events_url":"https://api.github.com/repos/cloudposse/tf_subnets/events","assignees_url":"https://api.github.com/repos/cloudposse/tf_subnets/assignees{/user}","branches_url":"https://api.github.com/repos/cloudposse/tf_subnets/branches{/branch}","tags_url":"https://api.github.com/repos/cloudposse/tf_subnets/tags","blobs_url":"https://api.github.com/repos/cloudposse/tf_subnets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudposse/tf_subnets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudposse/tf_subnets/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudposse/tf_subnets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudposse/tf_subnets/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudposse/tf_subnets/languages","stargazers_url":"https://api.github.com/repos/cloudposse/tf_subnets/stargazers","contributors_url":"https://api.github.com/repos/cloudposse/tf_subnets/contributors","subscribers_url":"https://api.github.com/repos/cloudposse/tf_subnets/subscribers","subscription_url":"https://api.github.com/repos/cloudposse/tf_subnets/subscription","commits_url":"https://api.github.com/repos/cloudposse/tf_subnets/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudposse/tf_subnets/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudposse/tf_subnets/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudposse/tf_subnets/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloudposse/tf_subnets/contents/{+path}","compare_url":"https://api.github.com/repos/cloudposse/tf_subnets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudposse/tf_subnets/merges","archive_url":"https://api.github.com/repos/cloudposse/tf_subnets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudposse/tf_subnets/downloads","issues_url":"https://api.github.com/repos/cloudposse/tf_subnets/issues{/number}","pulls_url":"https://api.github.com/repos/cloudposse/tf_subnets/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudposse/tf_subnets/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudposse/tf_subnets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudposse/tf_subnets/labels{/name}","releases_url":"https://api.github.com/repos/cloudposse/tf_subnets/releases{/id}","deployments_url":"https://api.github.com/repos/cloudposse/tf_subnets/deployments","created_at":"2017-08-08T11:53:10Z","updated_at":"2017-08-15T10:14:34Z","pushed_at":"2017-09-12T08:53:52Z","git_url":"git://github.com/cloudposse/tf_subnets.git","ssh_url":"git@github.com:cloudposse/tf_subnets.git","clone_url":"https://github.com/cloudposse/tf_subnets.git","svn_url":"https://github.com/cloudposse/tf_subnets","homepage":"","size":20,"stargazers_count":0,"watchers_count":0,"language":"HCL","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cloudposse/tf_subnets/pulls/15"},"html":{"href":"https://github.com/cloudposse/tf_subnets/pull/15"},"issue":{"href":"https://api.github.com/repos/cloudposse/tf_subnets/issues/15"},"comments":{"href":"https://api.github.com/repos/cloudposse/tf_subnets/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/cloudposse/tf_subnets/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/cloudposse/tf_subnets/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cloudposse/tf_subnets/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/cloudposse/tf_subnets/statuses/ae672765a08daa9cbad90f72de8662c95f7c8093"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"comeanother"}}