{"action":"created","issue":{"url":"https://api.github.com/repos/status-im/status-go/issues/445","repository_url":"https://api.github.com/repos/status-im/status-go","labels_url":"https://api.github.com/repos/status-im/status-go/issues/445/labels{/name}","comments_url":"https://api.github.com/repos/status-im/status-go/issues/445/comments","events_url":"https://api.github.com/repos/status-im/status-go/issues/445/events","html_url":"https://github.com/status-im/status-go/pull/445","id":270691702,"number":445,"title":"Feature/cover account package by unit tests#386","user":{"login":"b00ris","id":4943570,"avatar_url":"https://avatars3.githubusercontent.com/u/4943570?v=4","gravatar_id":"","url":"https://api.github.com/users/b00ris","html_url":"https://github.com/b00ris","followers_url":"https://api.github.com/users/b00ris/followers","following_url":"https://api.github.com/users/b00ris/following{/other_user}","gists_url":"https://api.github.com/users/b00ris/gists{/gist_id}","starred_url":"https://api.github.com/users/b00ris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/b00ris/subscriptions","organizations_url":"https://api.github.com/users/b00ris/orgs","repos_url":"https://api.github.com/users/b00ris/repos","events_url":"https://api.github.com/users/b00ris/events{/privacy}","received_events_url":"https://api.github.com/users/b00ris/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2017-11-02T15:15:09Z","updated_at":"2017-11-03T15:55:25Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/status-im/status-go/pulls/445","html_url":"https://github.com/status-im/status-go/pull/445","diff_url":"https://github.com/status-im/status-go/pull/445.diff","patch_url":"https://github.com/status-im/status-go/pull/445.patch"},"body":"Covered geth/account by 70+% using unit tests\r\nAdded integration tests from https://github.com/status-im/status-go/pull/409\r\n\r\nImportant changes:\r\n- Merged https://github.com/status-im/status-go/pull/409\r\n- Moved tests to e2e from https://github.com/status-im/status-go/pull/409\r\n- Covered geth/account by 70+% using unit tests \r\n\r\nSolves #386"},"comment":{"url":"https://api.github.com/repos/status-im/status-go/issues/comments/341745342","html_url":"https://github.com/status-im/status-go/pull/445#issuecomment-341745342","issue_url":"https://api.github.com/repos/status-im/status-go/issues/445","id":341745342,"user":{"login":"JekaMas","id":3192700,"avatar_url":"https://avatars0.githubusercontent.com/u/3192700?v=4","gravatar_id":"","url":"https://api.github.com/users/JekaMas","html_url":"https://github.com/JekaMas","followers_url":"https://api.github.com/users/JekaMas/followers","following_url":"https://api.github.com/users/JekaMas/following{/other_user}","gists_url":"https://api.github.com/users/JekaMas/gists{/gist_id}","starred_url":"https://api.github.com/users/JekaMas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JekaMas/subscriptions","organizations_url":"https://api.github.com/users/JekaMas/orgs","repos_url":"https://api.github.com/users/JekaMas/repos","events_url":"https://api.github.com/users/JekaMas/events{/privacy}","received_events_url":"https://api.github.com/users/JekaMas/received_events","type":"User","site_admin":false},"created_at":"2017-11-03T15:55:25Z","updated_at":"2017-11-03T15:55:25Z","author_association":"CONTRIBUTOR","body":"Once again this task is about unit testing of account package.\r\nWe can and should do integration tests but in separate task.\r\nTest coverage of account.go is more than 80%.\r\nTotal test coverage of package is slightly more than 70%.\r\n\r\nWhy we shouldnt accept this PR?"}}
{"actor":{"display_login":"JekaMas"}}