{"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/145009449","pull_request_review_id":69745620,"id":145009449,"diff_hunk":"@@ -95,6 +95,10 @@ let\n       # Tell systemd about our $DISPLAY. This is needed by the\n       # ssh-agent unit.\n       ${config.systemd.package}/bin/systemctl --user import-environment DISPLAY\n+      ${config.systemd.package}/bin/systemctl --user import-environment XAUTHORITY\n+\n+      # Tell systemd about the dbus session bus address. This is required by user units using the session bus.\n+      ${config.systemd.package}/bin/systemctl --user import-environment DBUS_SESSION_BUS_ADDRESS","path":"nixos/modules/services/x11/display-managers/default.nix","position":7,"original_position":7,"commit_id":"4b7cbb55cc264976ac1c6085ed2e85a81253b4ab","original_commit_id":"4b7cbb55cc264976ac1c6085ed2e85a81253b4ab","user":{"login":"Mic92","id":96200,"avatar_url":"https://avatars3.githubusercontent.com/u/96200?v=4","gravatar_id":"","url":"https://api.github.com/users/Mic92","html_url":"https://github.com/Mic92","followers_url":"https://api.github.com/users/Mic92/followers","following_url":"https://api.github.com/users/Mic92/following{/other_user}","gists_url":"https://api.github.com/users/Mic92/gists{/gist_id}","starred_url":"https://api.github.com/users/Mic92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mic92/subscriptions","organizations_url":"https://api.github.com/users/Mic92/orgs","repos_url":"https://api.github.com/users/Mic92/repos","events_url":"https://api.github.com/users/Mic92/events{/privacy}","received_events_url":"https://api.github.com/users/Mic92/received_events","type":"User","site_admin":false},"body":"The following should be possible according to man page:\r\n\r\n```nix\r\n${config.systemd.package}/bin/systemctl --user import-environment DISPLAY XAUTHORITY DBUS_SESSION_BUS_ADDRESS\r\n```","created_at":"2017-10-17T01:30:59Z","updated_at":"2017-10-17T01:30:59Z","html_url":"https://github.com/NixOS/nixpkgs/pull/30467#discussion_r145009449","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/30467","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/145009449"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/30467#discussion_r145009449"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/30467"}}},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/30467","id":146742418,"html_url":"https://github.com/NixOS/nixpkgs/pull/30467","diff_url":"https://github.com/NixOS/nixpkgs/pull/30467.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/30467.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/30467","number":30467,"state":"open","locked":false,"title":"display-managers: Import DBUS session bus address & Xauthority","user":{"login":"adisbladis","id":63286,"avatar_url":"https://avatars3.githubusercontent.com/u/63286?v=4","gravatar_id":"","url":"https://api.github.com/users/adisbladis","html_url":"https://github.com/adisbladis","followers_url":"https://api.github.com/users/adisbladis/followers","following_url":"https://api.github.com/users/adisbladis/following{/other_user}","gists_url":"https://api.github.com/users/adisbladis/gists{/gist_id}","starred_url":"https://api.github.com/users/adisbladis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adisbladis/subscriptions","organizations_url":"https://api.github.com/users/adisbladis/orgs","repos_url":"https://api.github.com/users/adisbladis/repos","events_url":"https://api.github.com/users/adisbladis/events{/privacy}","received_events_url":"https://api.github.com/users/adisbladis/received_events","type":"User","site_admin":false},"body":"###### Motivation for this change\r\nSystemd user session depending on these variables are broken.\r\nI was making my own unit that uses `notify-send` from `libnotify` that didn't work as expected.\r\n \r\n###### Things done\r\n\r\n<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->\r\n\r\n- [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)\r\n- Built on platform(s)\r\n   - [x] NixOS\r\n   ~~- [ ] macOS~~\r\n   ~~- [ ] other Linux distributions~~\r\n- [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\r\n- [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [x] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n","created_at":"2017-10-16T09:57:57Z","updated_at":"2017-10-17T01:30:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a09d0c75966aeb57fa57dfd5f8b76b3ec6dff6f4","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/30467/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/30467/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/30467/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/4b7cbb55cc264976ac1c6085ed2e85a81253b4ab","head":{"label":"adisbladis:display-managers-session/sessionvars","ref":"display-managers-session/sessionvars","sha":"4b7cbb55cc264976ac1c6085ed2e85a81253b4ab","user":{"login":"adisbladis","id":63286,"avatar_url":"https://avatars3.githubusercontent.com/u/63286?v=4","gravatar_id":"","url":"https://api.github.com/users/adisbladis","html_url":"https://github.com/adisbladis","followers_url":"https://api.github.com/users/adisbladis/followers","following_url":"https://api.github.com/users/adisbladis/following{/other_user}","gists_url":"https://api.github.com/users/adisbladis/gists{/gist_id}","starred_url":"https://api.github.com/users/adisbladis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adisbladis/subscriptions","organizations_url":"https://api.github.com/users/adisbladis/orgs","repos_url":"https://api.github.com/users/adisbladis/repos","events_url":"https://api.github.com/users/adisbladis/events{/privacy}","received_events_url":"https://api.github.com/users/adisbladis/received_events","type":"User","site_admin":false},"repo":{"id":96134801,"name":"nixpkgs","full_name":"adisbladis/nixpkgs","owner":{"login":"adisbladis","id":63286,"avatar_url":"https://avatars3.githubusercontent.com/u/63286?v=4","gravatar_id":"","url":"https://api.github.com/users/adisbladis","html_url":"https://github.com/adisbladis","followers_url":"https://api.github.com/users/adisbladis/followers","following_url":"https://api.github.com/users/adisbladis/following{/other_user}","gists_url":"https://api.github.com/users/adisbladis/gists{/gist_id}","starred_url":"https://api.github.com/users/adisbladis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adisbladis/subscriptions","organizations_url":"https://api.github.com/users/adisbladis/orgs","repos_url":"https://api.github.com/users/adisbladis/repos","events_url":"https://api.github.com/users/adisbladis/events{/privacy}","received_events_url":"https://api.github.com/users/adisbladis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adisbladis/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/adisbladis/nixpkgs","forks_url":"https://api.github.com/repos/adisbladis/nixpkgs/forks","keys_url":"https://api.github.com/repos/adisbladis/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adisbladis/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adisbladis/nixpkgs/teams","hooks_url":"https://api.github.com/repos/adisbladis/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/adisbladis/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/adisbladis/nixpkgs/events","assignees_url":"https://api.github.com/repos/adisbladis/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/adisbladis/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/adisbladis/nixpkgs/tags","blobs_url":"https://api.github.com/repos/adisbladis/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adisbladis/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adisbladis/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/adisbladis/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adisbladis/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/adisbladis/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/adisbladis/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/adisbladis/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/adisbladis/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/adisbladis/nixpkgs/subscription","commits_url":"https://api.github.com/repos/adisbladis/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/adisbladis/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/adisbladis/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/adisbladis/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/adisbladis/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/adisbladis/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adisbladis/nixpkgs/merges","archive_url":"https://api.github.com/repos/adisbladis/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adisbladis/nixpkgs/downloads","issues_url":"https://api.github.com/repos/adisbladis/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/adisbladis/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/adisbladis/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/adisbladis/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adisbladis/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/adisbladis/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/adisbladis/nixpkgs/deployments","created_at":"2017-07-03T17:26:12Z","updated_at":"2017-07-03T17:26:38Z","pushed_at":"2017-10-16T14:52:33Z","git_url":"git://github.com/adisbladis/nixpkgs.git","ssh_url":"git@github.com:adisbladis/nixpkgs.git","clone_url":"https://github.com/adisbladis/nixpkgs.git","svn_url":"https://github.com/adisbladis/nixpkgs","homepage":null,"size":613097,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"be18284ea185902797f67ff626de9ebe414ad694","user":{"login":"NixOS","id":487568,"avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"name":"nixpkgs","full_name":"NixOS/nixpkgs","owner":{"login":"NixOS","id":487568,"avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2017-10-17T00:33:34Z","pushed_at":"2017-10-17T01:28:59Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":617659,"stargazers_count":1933,"watchers_count":1933,"language":"Nix","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2279,"mirror_url":null,"open_issues_count":2416,"forks":2279,"open_issues":2416,"watchers":1933,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/30467"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/30467"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/30467"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/30467/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/30467/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/30467/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/4b7cbb55cc264976ac1c6085ed2e85a81253b4ab"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Mic92"}}