{"action":"created","issue":{"url":"https://api.github.com/repos/PowerShell/PowerShell/issues/3487","repository_url":"https://api.github.com/repos/PowerShell/PowerShell","labels_url":"https://api.github.com/repos/PowerShell/PowerShell/issues/3487/labels{/name}","comments_url":"https://api.github.com/repos/PowerShell/PowerShell/issues/3487/comments","events_url":"https://api.github.com/repos/PowerShell/PowerShell/issues/3487/events","html_url":"https://github.com/PowerShell/PowerShell/pull/3487","id":219557480,"number":3487,"title":"Remove unused and duplicated GetEncodingFromEnum","user":{"login":"iSazonov","id":22290914,"avatar_url":"https://avatars1.githubusercontent.com/u/22290914?v=3","gravatar_id":"","url":"https://api.github.com/users/iSazonov","html_url":"https://github.com/iSazonov","followers_url":"https://api.github.com/users/iSazonov/followers","following_url":"https://api.github.com/users/iSazonov/following{/other_user}","gists_url":"https://api.github.com/users/iSazonov/gists{/gist_id}","starred_url":"https://api.github.com/users/iSazonov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iSazonov/subscriptions","organizations_url":"https://api.github.com/users/iSazonov/orgs","repos_url":"https://api.github.com/users/iSazonov/repos","events_url":"https://api.github.com/users/iSazonov/events{/privacy}","received_events_url":"https://api.github.com/users/iSazonov/received_events","type":"User","site_admin":false},"labels":[{"id":427063085,"url":"https://api.github.com/repos/PowerShell/PowerShell/labels/cla-already-signed","name":"cla-already-signed","color":"009800","default":false},{"id":483158128,"url":"https://api.github.com/repos/PowerShell/PowerShell/labels/Committee-Reviewed","name":"Committee-Reviewed","color":"0e5a16","default":false}],"state":"open","locked":false,"assignee":{"login":"TravisEz13","id":10873629,"avatar_url":"https://avatars2.githubusercontent.com/u/10873629?v=3","gravatar_id":"","url":"https://api.github.com/users/TravisEz13","html_url":"https://github.com/TravisEz13","followers_url":"https://api.github.com/users/TravisEz13/followers","following_url":"https://api.github.com/users/TravisEz13/following{/other_user}","gists_url":"https://api.github.com/users/TravisEz13/gists{/gist_id}","starred_url":"https://api.github.com/users/TravisEz13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TravisEz13/subscriptions","organizations_url":"https://api.github.com/users/TravisEz13/orgs","repos_url":"https://api.github.com/users/TravisEz13/repos","events_url":"https://api.github.com/users/TravisEz13/events{/privacy}","received_events_url":"https://api.github.com/users/TravisEz13/received_events","type":"User","site_admin":false},"assignees":[{"login":"TravisEz13","id":10873629,"avatar_url":"https://avatars2.githubusercontent.com/u/10873629?v=3","gravatar_id":"","url":"https://api.github.com/users/TravisEz13","html_url":"https://github.com/TravisEz13","followers_url":"https://api.github.com/users/TravisEz13/followers","following_url":"https://api.github.com/users/TravisEz13/following{/other_user}","gists_url":"https://api.github.com/users/TravisEz13/gists{/gist_id}","starred_url":"https://api.github.com/users/TravisEz13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TravisEz13/subscriptions","organizations_url":"https://api.github.com/users/TravisEz13/orgs","repos_url":"https://api.github.com/users/TravisEz13/repos","events_url":"https://api.github.com/users/TravisEz13/events{/privacy}","received_events_url":"https://api.github.com/users/TravisEz13/received_events","type":"User","site_admin":false}],"milestone":null,"comments":8,"created_at":"2017-04-05T11:53:48Z","updated_at":"2017-04-17T17:57:53Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/PowerShell/PowerShell/pulls/3487","html_url":"https://github.com/PowerShell/PowerShell/pull/3487","diff_url":"https://github.com/PowerShell/PowerShell/pull/3487.diff","patch_url":"https://github.com/PowerShell/PowerShell/pull/3487.patch"},"body":"GetEncodingFromEnum and TextEncodingType is not used.\r\nGetEncodingFromEnum duplicate a code\r\n- in [FileSystemProvider.cs\r\n](https://github.com/PowerShell/PowerShell/blob/master/src/System.Management.Automation/namespaces/FileSystemProvider.cs#L7528)\r\n- in [Utils.cs](https://github.com/PowerShell/PowerShell/blob/master/src/System.Management.Automation/engine/Utils.cs#L1375)\r\n"},"comment":{"url":"https://api.github.com/repos/PowerShell/PowerShell/issues/comments/294543131","html_url":"https://github.com/PowerShell/PowerShell/pull/3487#issuecomment-294543131","issue_url":"https://api.github.com/repos/PowerShell/PowerShell/issues/3487","id":294543131,"user":{"login":"iSazonov","id":22290914,"avatar_url":"https://avatars1.githubusercontent.com/u/22290914?v=3","gravatar_id":"","url":"https://api.github.com/users/iSazonov","html_url":"https://github.com/iSazonov","followers_url":"https://api.github.com/users/iSazonov/followers","following_url":"https://api.github.com/users/iSazonov/following{/other_user}","gists_url":"https://api.github.com/users/iSazonov/gists{/gist_id}","starred_url":"https://api.github.com/users/iSazonov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iSazonov/subscriptions","organizations_url":"https://api.github.com/users/iSazonov/orgs","repos_url":"https://api.github.com/users/iSazonov/repos","events_url":"https://api.github.com/users/iSazonov/events{/privacy}","received_events_url":"https://api.github.com/users/iSazonov/received_events","type":"User","site_admin":false},"created_at":"2017-04-17T17:57:53Z","updated_at":"2017-04-17T17:57:53Z","body":"@lzybkr Thanks! I'd revert the API.\r\n>•Remove the unnecessary public api from our reference assemblies\r\n\r\nI don't know how?\r\n\r\n>•Mark the api as obsolete\r\n\r\nPlace a comment in code?\r\n\r\n>•Not sure which docs you're referring to - but a public enum is very usable anywhere, so we should fix the docs that say the members cannot be used\r\n\r\nThe docs is ready https://msdn.microsoft.com/en-us/library/microsoft.powershell.commands.textencodingtype%28v=vs.85%29.aspx \r\n"}}
{"actor":{"display_login":"iSazonov"}}