{"action":"created","comment":{"url":"https://api.github.com/repos/D-Programming-GDC/GDC/pulls/comments/123901403","pull_request_review_id":46147856,"id":123901403,"diff_hunk":"@@ -28,24 +28,31 @@ HOOK_VECTOR (TARGETDM_INITIALIZER, gcc_targetdm)\n #undef HOOK_PREFIX\n #define HOOK_PREFIX \"TARGET_\"\n \n-/* Environmental version identifiers relating to the target OS.  */\n+/* Environmental version identifiers relating to the target CPU.  */\n DEFHOOK\n-(d_os_builtins,\n- \"Declare predefined version identifiers\",\n+(d_cpu_versions,\n+ \"Declare all environmental version identifiers relating to the target CPU\\\n+ using the function @code{builtin_version}, which takes a string representing\\\n+ the name of the version.  Version identifiers predefined by this hook apply\\\n+ to all modules and being compiled and imported.\",\n  void, (void),\n  hook_void_void)\n \n-/* Environmental version identifiers relating to the target CPU.  */\n+/* Environmental version identifiers relating to the target OS.  */\n DEFHOOK\n-(d_cpu_builtins,\n- \"Declare predefined version identifiers\",\n+(d_os_versions,\n+ \"Similarly to @code{TARGET_D_CPU_VERSIONS}, but is used for versions relating\\\n+ to the target operating system.\",\n  void, (void),\n  hook_void_void)\n \n-/* The size of OS CRITICAL_SECTION or pthread_mutex_t.  */\n+/* The sizeof CRITICAL_SECTION or pthread_mutex_t.  */\n DEFHOOK\n (d_critsec_size,\n- \"Declare size of critical section\",\n+ \"Returns the size of the data structure used by the targeted operating system\\\n+ for critical sections and monitors.  For example, on Microsoft Windows this\\\n+ would return the @code{sizeof(CRITICAL_SECTION)}, while other platforms that\\\n+ implement pthreads would return @code{sizeof(pthread_mutex_t)}.\",","path":"gcc/d/d-target.def","position":null,"original_position":36,"commit_id":"8523790c07586aa57213f024a98a2e8750e9bacc","original_commit_id":"8523790c07586aa57213f024a98a2e8750e9bacc","user":{"login":"jpf91","id":583238,"avatar_url":"https://avatars1.githubusercontent.com/u/583238?v=3","gravatar_id":"","url":"https://api.github.com/users/jpf91","html_url":"https://github.com/jpf91","followers_url":"https://api.github.com/users/jpf91/followers","following_url":"https://api.github.com/users/jpf91/following{/other_user}","gists_url":"https://api.github.com/users/jpf91/gists{/gist_id}","starred_url":"https://api.github.com/users/jpf91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpf91/subscriptions","organizations_url":"https://api.github.com/users/jpf91/orgs","repos_url":"https://api.github.com/users/jpf91/repos","events_url":"https://api.github.com/users/jpf91/events{/privacy}","received_events_url":"https://api.github.com/users/jpf91/received_events","type":"User","site_admin":false},"body":"OK, I see. This ties the compiler even more to the specific druntime implementation though...\r\n\r\nI always get kinda nervous when we have to manually synchronize duplicated information in druntime and compiler.","created_at":"2017-06-25T15:18:53Z","updated_at":"2017-06-25T15:18:53Z","html_url":"https://github.com/D-Programming-GDC/GDC/pull/500#discussion_r123901403","pull_request_url":"https://api.github.com/repos/D-Programming-GDC/GDC/pulls/500","_links":{"self":{"href":"https://api.github.com/repos/D-Programming-GDC/GDC/pulls/comments/123901403"},"html":{"href":"https://github.com/D-Programming-GDC/GDC/pull/500#discussion_r123901403"},"pull_request":{"href":"https://api.github.com/repos/D-Programming-GDC/GDC/pulls/500"}}},"pull_request":{"url":"https://api.github.com/repos/D-Programming-GDC/GDC/pulls/500","id":126182987,"html_url":"https://github.com/D-Programming-GDC/GDC/pull/500","diff_url":"https://github.com/D-Programming-GDC/GDC/pull/500.diff","patch_url":"https://github.com/D-Programming-GDC/GDC/pull/500.patch","issue_url":"https://api.github.com/repos/D-Programming-GDC/GDC/issues/500","number":500,"state":"open","locked":false,"title":"Implement D language specific target hooks.","user":{"login":"ibuclaw","id":397929,"avatar_url":"https://avatars0.githubusercontent.com/u/397929?v=3","gravatar_id":"","url":"https://api.github.com/users/ibuclaw","html_url":"https://github.com/ibuclaw","followers_url":"https://api.github.com/users/ibuclaw/followers","following_url":"https://api.github.com/users/ibuclaw/following{/other_user}","gists_url":"https://api.github.com/users/ibuclaw/gists{/gist_id}","starred_url":"https://api.github.com/users/ibuclaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibuclaw/subscriptions","organizations_url":"https://api.github.com/users/ibuclaw/orgs","repos_url":"https://api.github.com/users/ibuclaw/repos","events_url":"https://api.github.com/users/ibuclaw/events{/privacy}","received_events_url":"https://api.github.com/users/ibuclaw/received_events","type":"User","site_admin":false},"body":"This is just the baseline commit.  Does nothing useful yet apart from generate and link the object in.\r\n\r\nWill follow-up with per-target implementations, and remove the patch-versym-xxx support and patches.","created_at":"2017-06-18T09:36:36Z","updated_at":"2017-06-25T15:18:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"31601c8e748d34d1b65dccb1d511bca4d9955970","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/D-Programming-GDC/GDC/pulls/500/commits","review_comments_url":"https://api.github.com/repos/D-Programming-GDC/GDC/pulls/500/comments","review_comment_url":"https://api.github.com/repos/D-Programming-GDC/GDC/pulls/comments{/number}","comments_url":"https://api.github.com/repos/D-Programming-GDC/GDC/issues/500/comments","statuses_url":"https://api.github.com/repos/D-Programming-GDC/GDC/statuses/8523790c07586aa57213f024a98a2e8750e9bacc","head":{"label":"ibuclaw:targetconfig","ref":"targetconfig","sha":"8523790c07586aa57213f024a98a2e8750e9bacc","user":{"login":"ibuclaw","id":397929,"avatar_url":"https://avatars0.githubusercontent.com/u/397929?v=3","gravatar_id":"","url":"https://api.github.com/users/ibuclaw","html_url":"https://github.com/ibuclaw","followers_url":"https://api.github.com/users/ibuclaw/followers","following_url":"https://api.github.com/users/ibuclaw/following{/other_user}","gists_url":"https://api.github.com/users/ibuclaw/gists{/gist_id}","starred_url":"https://api.github.com/users/ibuclaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibuclaw/subscriptions","organizations_url":"https://api.github.com/users/ibuclaw/orgs","repos_url":"https://api.github.com/users/ibuclaw/repos","events_url":"https://api.github.com/users/ibuclaw/events{/privacy}","received_events_url":"https://api.github.com/users/ibuclaw/received_events","type":"User","site_admin":false},"repo":{"id":9521414,"name":"GDC","full_name":"ibuclaw/GDC","owner":{"login":"ibuclaw","id":397929,"avatar_url":"https://avatars0.githubusercontent.com/u/397929?v=3","gravatar_id":"","url":"https://api.github.com/users/ibuclaw","html_url":"https://github.com/ibuclaw","followers_url":"https://api.github.com/users/ibuclaw/followers","following_url":"https://api.github.com/users/ibuclaw/following{/other_user}","gists_url":"https://api.github.com/users/ibuclaw/gists{/gist_id}","starred_url":"https://api.github.com/users/ibuclaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibuclaw/subscriptions","organizations_url":"https://api.github.com/users/ibuclaw/orgs","repos_url":"https://api.github.com/users/ibuclaw/repos","events_url":"https://api.github.com/users/ibuclaw/events{/privacy}","received_events_url":"https://api.github.com/users/ibuclaw/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ibuclaw/GDC","description":"GNU D Compiler","fork":true,"url":"https://api.github.com/repos/ibuclaw/GDC","forks_url":"https://api.github.com/repos/ibuclaw/GDC/forks","keys_url":"https://api.github.com/repos/ibuclaw/GDC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ibuclaw/GDC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ibuclaw/GDC/teams","hooks_url":"https://api.github.com/repos/ibuclaw/GDC/hooks","issue_events_url":"https://api.github.com/repos/ibuclaw/GDC/issues/events{/number}","events_url":"https://api.github.com/repos/ibuclaw/GDC/events","assignees_url":"https://api.github.com/repos/ibuclaw/GDC/assignees{/user}","branches_url":"https://api.github.com/repos/ibuclaw/GDC/branches{/branch}","tags_url":"https://api.github.com/repos/ibuclaw/GDC/tags","blobs_url":"https://api.github.com/repos/ibuclaw/GDC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ibuclaw/GDC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ibuclaw/GDC/git/refs{/sha}","trees_url":"https://api.github.com/repos/ibuclaw/GDC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ibuclaw/GDC/statuses/{sha}","languages_url":"https://api.github.com/repos/ibuclaw/GDC/languages","stargazers_url":"https://api.github.com/repos/ibuclaw/GDC/stargazers","contributors_url":"https://api.github.com/repos/ibuclaw/GDC/contributors","subscribers_url":"https://api.github.com/repos/ibuclaw/GDC/subscribers","subscription_url":"https://api.github.com/repos/ibuclaw/GDC/subscription","commits_url":"https://api.github.com/repos/ibuclaw/GDC/commits{/sha}","git_commits_url":"https://api.github.com/repos/ibuclaw/GDC/git/commits{/sha}","comments_url":"https://api.github.com/repos/ibuclaw/GDC/comments{/number}","issue_comment_url":"https://api.github.com/repos/ibuclaw/GDC/issues/comments{/number}","contents_url":"https://api.github.com/repos/ibuclaw/GDC/contents/{+path}","compare_url":"https://api.github.com/repos/ibuclaw/GDC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ibuclaw/GDC/merges","archive_url":"https://api.github.com/repos/ibuclaw/GDC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ibuclaw/GDC/downloads","issues_url":"https://api.github.com/repos/ibuclaw/GDC/issues{/number}","pulls_url":"https://api.github.com/repos/ibuclaw/GDC/pulls{/number}","milestones_url":"https://api.github.com/repos/ibuclaw/GDC/milestones{/number}","notifications_url":"https://api.github.com/repos/ibuclaw/GDC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ibuclaw/GDC/labels{/name}","releases_url":"https://api.github.com/repos/ibuclaw/GDC/releases{/id}","deployments_url":"https://api.github.com/repos/ibuclaw/GDC/deployments","created_at":"2013-04-18T12:45:01Z","updated_at":"2016-10-29T08:19:52Z","pushed_at":"2017-06-25T14:50:16Z","git_url":"git://github.com/ibuclaw/GDC.git","ssh_url":"git@github.com:ibuclaw/GDC.git","clone_url":"https://github.com/ibuclaw/GDC.git","svn_url":"https://github.com/ibuclaw/GDC","homepage":"http://gdcproject.org","size":94694,"stargazers_count":2,"watchers_count":2,"language":"D","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"D-Programming-GDC:master","ref":"master","sha":"5cb43008ad14fd145d3f7cc5378ff24f5ddfd204","user":{"login":"D-Programming-GDC","id":1551040,"avatar_url":"https://avatars3.githubusercontent.com/u/1551040?v=3","gravatar_id":"","url":"https://api.github.com/users/D-Programming-GDC","html_url":"https://github.com/D-Programming-GDC","followers_url":"https://api.github.com/users/D-Programming-GDC/followers","following_url":"https://api.github.com/users/D-Programming-GDC/following{/other_user}","gists_url":"https://api.github.com/users/D-Programming-GDC/gists{/gist_id}","starred_url":"https://api.github.com/users/D-Programming-GDC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/D-Programming-GDC/subscriptions","organizations_url":"https://api.github.com/users/D-Programming-GDC/orgs","repos_url":"https://api.github.com/users/D-Programming-GDC/repos","events_url":"https://api.github.com/users/D-Programming-GDC/events{/privacy}","received_events_url":"https://api.github.com/users/D-Programming-GDC/received_events","type":"Organization","site_admin":false},"repo":{"id":3759178,"name":"GDC","full_name":"D-Programming-GDC/GDC","owner":{"login":"D-Programming-GDC","id":1551040,"avatar_url":"https://avatars3.githubusercontent.com/u/1551040?v=3","gravatar_id":"","url":"https://api.github.com/users/D-Programming-GDC","html_url":"https://github.com/D-Programming-GDC","followers_url":"https://api.github.com/users/D-Programming-GDC/followers","following_url":"https://api.github.com/users/D-Programming-GDC/following{/other_user}","gists_url":"https://api.github.com/users/D-Programming-GDC/gists{/gist_id}","starred_url":"https://api.github.com/users/D-Programming-GDC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/D-Programming-GDC/subscriptions","organizations_url":"https://api.github.com/users/D-Programming-GDC/orgs","repos_url":"https://api.github.com/users/D-Programming-GDC/repos","events_url":"https://api.github.com/users/D-Programming-GDC/events{/privacy}","received_events_url":"https://api.github.com/users/D-Programming-GDC/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/D-Programming-GDC/GDC","description":"GNU D Compiler","fork":false,"url":"https://api.github.com/repos/D-Programming-GDC/GDC","forks_url":"https://api.github.com/repos/D-Programming-GDC/GDC/forks","keys_url":"https://api.github.com/repos/D-Programming-GDC/GDC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/D-Programming-GDC/GDC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/D-Programming-GDC/GDC/teams","hooks_url":"https://api.github.com/repos/D-Programming-GDC/GDC/hooks","issue_events_url":"https://api.github.com/repos/D-Programming-GDC/GDC/issues/events{/number}","events_url":"https://api.github.com/repos/D-Programming-GDC/GDC/events","assignees_url":"https://api.github.com/repos/D-Programming-GDC/GDC/assignees{/user}","branches_url":"https://api.github.com/repos/D-Programming-GDC/GDC/branches{/branch}","tags_url":"https://api.github.com/repos/D-Programming-GDC/GDC/tags","blobs_url":"https://api.github.com/repos/D-Programming-GDC/GDC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/D-Programming-GDC/GDC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/D-Programming-GDC/GDC/git/refs{/sha}","trees_url":"https://api.github.com/repos/D-Programming-GDC/GDC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/D-Programming-GDC/GDC/statuses/{sha}","languages_url":"https://api.github.com/repos/D-Programming-GDC/GDC/languages","stargazers_url":"https://api.github.com/repos/D-Programming-GDC/GDC/stargazers","contributors_url":"https://api.github.com/repos/D-Programming-GDC/GDC/contributors","subscribers_url":"https://api.github.com/repos/D-Programming-GDC/GDC/subscribers","subscription_url":"https://api.github.com/repos/D-Programming-GDC/GDC/subscription","commits_url":"https://api.github.com/repos/D-Programming-GDC/GDC/commits{/sha}","git_commits_url":"https://api.github.com/repos/D-Programming-GDC/GDC/git/commits{/sha}","comments_url":"https://api.github.com/repos/D-Programming-GDC/GDC/comments{/number}","issue_comment_url":"https://api.github.com/repos/D-Programming-GDC/GDC/issues/comments{/number}","contents_url":"https://api.github.com/repos/D-Programming-GDC/GDC/contents/{+path}","compare_url":"https://api.github.com/repos/D-Programming-GDC/GDC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/D-Programming-GDC/GDC/merges","archive_url":"https://api.github.com/repos/D-Programming-GDC/GDC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/D-Programming-GDC/GDC/downloads","issues_url":"https://api.github.com/repos/D-Programming-GDC/GDC/issues{/number}","pulls_url":"https://api.github.com/repos/D-Programming-GDC/GDC/pulls{/number}","milestones_url":"https://api.github.com/repos/D-Programming-GDC/GDC/milestones{/number}","notifications_url":"https://api.github.com/repos/D-Programming-GDC/GDC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/D-Programming-GDC/GDC/labels{/name}","releases_url":"https://api.github.com/repos/D-Programming-GDC/GDC/releases{/id}","deployments_url":"https://api.github.com/repos/D-Programming-GDC/GDC/deployments","created_at":"2012-03-19T00:16:44Z","updated_at":"2017-06-24T03:57:01Z","pushed_at":"2017-06-25T14:56:56Z","git_url":"git://github.com/D-Programming-GDC/GDC.git","ssh_url":"git@github.com:D-Programming-GDC/GDC.git","clone_url":"https://github.com/D-Programming-GDC/GDC.git","svn_url":"https://github.com/D-Programming-GDC/GDC","homepage":"http://gdcproject.org","size":94623,"stargazers_count":312,"watchers_count":312,"language":"D","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":48,"mirror_url":null,"open_issues_count":13,"forks":48,"open_issues":13,"watchers":312,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/D-Programming-GDC/GDC/pulls/500"},"html":{"href":"https://github.com/D-Programming-GDC/GDC/pull/500"},"issue":{"href":"https://api.github.com/repos/D-Programming-GDC/GDC/issues/500"},"comments":{"href":"https://api.github.com/repos/D-Programming-GDC/GDC/issues/500/comments"},"review_comments":{"href":"https://api.github.com/repos/D-Programming-GDC/GDC/pulls/500/comments"},"review_comment":{"href":"https://api.github.com/repos/D-Programming-GDC/GDC/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/D-Programming-GDC/GDC/pulls/500/commits"},"statuses":{"href":"https://api.github.com/repos/D-Programming-GDC/GDC/statuses/8523790c07586aa57213f024a98a2e8750e9bacc"}}}}
{"actor":{"display_login":"jpf91"}}