{"action":"created","comment":{"url":"https://api.github.com/repos/alphagov/notifications-api/pulls/comments/151455891","pull_request_review_id":77166459,"id":151455891,"diff_hunk":"@@ -295,6 +295,34 @@ def test_get_all_notifications_returns_200(client, sample_template):\n     assert not json_response['notifications'][0]['scheduled_for']\n \n \n+def test_get_all_notifications_with_include_jobs_arg_returns_200(","path":"tests/app/v2/notifications/test_get_notifications.py","position":4,"original_position":4,"commit_id":"0e473cace595508fcaa5da04e23e2c18b9f3eff3","original_commit_id":"0e473cace595508fcaa5da04e23e2c18b9f3eff3","user":{"login":"kentsanggds","id":22152807,"avatar_url":"https://avatars1.githubusercontent.com/u/22152807?v=4","gravatar_id":"","url":"https://api.github.com/users/kentsanggds","html_url":"https://github.com/kentsanggds","followers_url":"https://api.github.com/users/kentsanggds/followers","following_url":"https://api.github.com/users/kentsanggds/following{/other_user}","gists_url":"https://api.github.com/users/kentsanggds/gists{/gist_id}","starred_url":"https://api.github.com/users/kentsanggds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kentsanggds/subscriptions","organizations_url":"https://api.github.com/users/kentsanggds/orgs","repos_url":"https://api.github.com/users/kentsanggds/repos","events_url":"https://api.github.com/users/kentsanggds/events{/privacy}","received_events_url":"https://api.github.com/users/kentsanggds/received_events","type":"User","site_admin":false},"body":"ok, I see what you mean, can add it","created_at":"2017-11-16T15:58:12Z","updated_at":"2017-11-16T15:58:12Z","html_url":"https://github.com/alphagov/notifications-api/pull/1400#discussion_r151455891","pull_request_url":"https://api.github.com/repos/alphagov/notifications-api/pulls/1400","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/alphagov/notifications-api/pulls/comments/151455891"},"html":{"href":"https://github.com/alphagov/notifications-api/pull/1400#discussion_r151455891"},"pull_request":{"href":"https://api.github.com/repos/alphagov/notifications-api/pulls/1400"}},"in_reply_to_id":151443048},"pull_request":{"url":"https://api.github.com/repos/alphagov/notifications-api/pulls/1400","id":153063227,"html_url":"https://github.com/alphagov/notifications-api/pull/1400","diff_url":"https://github.com/alphagov/notifications-api/pull/1400.diff","patch_url":"https://github.com/alphagov/notifications-api/pull/1400.patch","issue_url":"https://api.github.com/repos/alphagov/notifications-api/issues/1400","number":1400,"state":"open","locked":false,"title":"Allow include jobs request param on v2 get all notifications","user":{"login":"kentsanggds","id":22152807,"avatar_url":"https://avatars1.githubusercontent.com/u/22152807?v=4","gravatar_id":"","url":"https://api.github.com/users/kentsanggds","html_url":"https://github.com/kentsanggds","followers_url":"https://api.github.com/users/kentsanggds/followers","following_url":"https://api.github.com/users/kentsanggds/following{/other_user}","gists_url":"https://api.github.com/users/kentsanggds/gists{/gist_id}","starred_url":"https://api.github.com/users/kentsanggds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kentsanggds/subscriptions","organizations_url":"https://api.github.com/users/kentsanggds/orgs","repos_url":"https://api.github.com/users/kentsanggds/repos","events_url":"https://api.github.com/users/kentsanggds/events{/privacy}","received_events_url":"https://api.github.com/users/kentsanggds/received_events","type":"User","site_admin":false},"body":"## What\r\n\r\nIn order to get the functional tests to work with the v2 endpoint we need to allow it to handle the `include_jobs` argument to return all notifications including ones created by jobs.\r\n\r\n## Reference \r\n\r\nhttps://www.pivotaltracker.com/story/show/152925357","created_at":"2017-11-16T14:59:51Z","updated_at":"2017-11-16T15:58:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b04a22df5ef94385ba3c83c2c713c5f1197379b9","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/notifications-api/pulls/1400/commits","review_comments_url":"https://api.github.com/repos/alphagov/notifications-api/pulls/1400/comments","review_comment_url":"https://api.github.com/repos/alphagov/notifications-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alphagov/notifications-api/issues/1400/comments","statuses_url":"https://api.github.com/repos/alphagov/notifications-api/statuses/0e473cace595508fcaa5da04e23e2c18b9f3eff3","head":{"label":"alphagov:ken-allow-include_jobs-arg-get_all_notis","ref":"ken-allow-include_jobs-arg-get_all_notis","sha":"0e473cace595508fcaa5da04e23e2c18b9f3eff3","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":46422101,"name":"notifications-api","full_name":"alphagov/notifications-api","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/notifications-api","description":"Notifications api","fork":false,"url":"https://api.github.com/repos/alphagov/notifications-api","forks_url":"https://api.github.com/repos/alphagov/notifications-api/forks","keys_url":"https://api.github.com/repos/alphagov/notifications-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/notifications-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/notifications-api/teams","hooks_url":"https://api.github.com/repos/alphagov/notifications-api/hooks","issue_events_url":"https://api.github.com/repos/alphagov/notifications-api/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/notifications-api/events","assignees_url":"https://api.github.com/repos/alphagov/notifications-api/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/notifications-api/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/notifications-api/tags","blobs_url":"https://api.github.com/repos/alphagov/notifications-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/notifications-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/notifications-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/notifications-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/notifications-api/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/notifications-api/languages","stargazers_url":"https://api.github.com/repos/alphagov/notifications-api/stargazers","contributors_url":"https://api.github.com/repos/alphagov/notifications-api/contributors","subscribers_url":"https://api.github.com/repos/alphagov/notifications-api/subscribers","subscription_url":"https://api.github.com/repos/alphagov/notifications-api/subscription","commits_url":"https://api.github.com/repos/alphagov/notifications-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/notifications-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/notifications-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/notifications-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/notifications-api/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/notifications-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/notifications-api/merges","archive_url":"https://api.github.com/repos/alphagov/notifications-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/notifications-api/downloads","issues_url":"https://api.github.com/repos/alphagov/notifications-api/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/notifications-api/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/notifications-api/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/notifications-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/notifications-api/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/notifications-api/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/notifications-api/deployments","created_at":"2015-11-18T13:57:17Z","updated_at":"2017-05-24T16:00:23Z","pushed_at":"2017-11-16T15:56:07Z","git_url":"git://github.com/alphagov/notifications-api.git","ssh_url":"git@github.com:alphagov/notifications-api.git","clone_url":"https://github.com/alphagov/notifications-api.git","svn_url":"https://github.com/alphagov/notifications-api","homepage":null,"size":14960,"stargazers_count":8,"watchers_count":8,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":8,"forks":4,"open_issues":8,"watchers":8,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"bf5e6db666770aceff89680be5363edf2e053343","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":46422101,"name":"notifications-api","full_name":"alphagov/notifications-api","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/notifications-api","description":"Notifications api","fork":false,"url":"https://api.github.com/repos/alphagov/notifications-api","forks_url":"https://api.github.com/repos/alphagov/notifications-api/forks","keys_url":"https://api.github.com/repos/alphagov/notifications-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/notifications-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/notifications-api/teams","hooks_url":"https://api.github.com/repos/alphagov/notifications-api/hooks","issue_events_url":"https://api.github.com/repos/alphagov/notifications-api/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/notifications-api/events","assignees_url":"https://api.github.com/repos/alphagov/notifications-api/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/notifications-api/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/notifications-api/tags","blobs_url":"https://api.github.com/repos/alphagov/notifications-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/notifications-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/notifications-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/notifications-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/notifications-api/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/notifications-api/languages","stargazers_url":"https://api.github.com/repos/alphagov/notifications-api/stargazers","contributors_url":"https://api.github.com/repos/alphagov/notifications-api/contributors","subscribers_url":"https://api.github.com/repos/alphagov/notifications-api/subscribers","subscription_url":"https://api.github.com/repos/alphagov/notifications-api/subscription","commits_url":"https://api.github.com/repos/alphagov/notifications-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/notifications-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/notifications-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/notifications-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/notifications-api/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/notifications-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/notifications-api/merges","archive_url":"https://api.github.com/repos/alphagov/notifications-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/notifications-api/downloads","issues_url":"https://api.github.com/repos/alphagov/notifications-api/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/notifications-api/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/notifications-api/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/notifications-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/notifications-api/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/notifications-api/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/notifications-api/deployments","created_at":"2015-11-18T13:57:17Z","updated_at":"2017-05-24T16:00:23Z","pushed_at":"2017-11-16T15:56:07Z","git_url":"git://github.com/alphagov/notifications-api.git","ssh_url":"git@github.com:alphagov/notifications-api.git","clone_url":"https://github.com/alphagov/notifications-api.git","svn_url":"https://github.com/alphagov/notifications-api","homepage":null,"size":14960,"stargazers_count":8,"watchers_count":8,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":8,"forks":4,"open_issues":8,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/notifications-api/pulls/1400"},"html":{"href":"https://github.com/alphagov/notifications-api/pull/1400"},"issue":{"href":"https://api.github.com/repos/alphagov/notifications-api/issues/1400"},"comments":{"href":"https://api.github.com/repos/alphagov/notifications-api/issues/1400/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/notifications-api/pulls/1400/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/notifications-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alphagov/notifications-api/pulls/1400/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/notifications-api/statuses/0e473cace595508fcaa5da04e23e2c18b9f3eff3"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kentsanggds"}}