{"action":"opened","number":4853,"pull_request":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/4853","id":105126658,"html_url":"https://github.com/dolphin-emu/dolphin/pull/4853","diff_url":"https://github.com/dolphin-emu/dolphin/pull/4853.diff","patch_url":"https://github.com/dolphin-emu/dolphin/pull/4853.patch","issue_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/4853","number":4853,"state":"open","locked":false,"title":"GCPadEmu: only connected if default device connected","user":{"login":"ligfx","id":594093,"avatar_url":"https://avatars.githubusercontent.com/u/594093?v=3","gravatar_id":"","url":"https://api.github.com/users/ligfx","html_url":"https://github.com/ligfx","followers_url":"https://api.github.com/users/ligfx/followers","following_url":"https://api.github.com/users/ligfx/following{/other_user}","gists_url":"https://api.github.com/users/ligfx/gists{/gist_id}","starred_url":"https://api.github.com/users/ligfx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ligfx/subscriptions","organizations_url":"https://api.github.com/users/ligfx/orgs","repos_url":"https://api.github.com/users/ligfx/repos","events_url":"https://api.github.com/users/ligfx/events{/privacy}","received_events_url":"https://api.github.com/users/ligfx/received_events","type":"User","site_admin":false},"body":"This lets Dolphin know if a configured GameCube Controller should actually be treated as connected or not.\r\n\r\nTalked to @JMC47 a bit about this last night. My use-case is that all of my controllers are the same hardware (Xbox One controllers) so share the same configuration (modulo device number). Treating them all as always connected isn't a problem for most games, but in some (Smash Bros.) it forces me to go find a keyboard/mouse and unconfigure any controllers that I don't actually have connected. Hotplugging devices (works on macOS, at least) + this patch remove my need to ever touch the Controller Config dialog while in a game.\r\n\r\nThis patch makes the following changes:\r\n\r\n- A new `BooleanSetting` in `GCPadEmu` called \"Always Connected\", which defaults to false.\r\n- `ControllerEmu` tracks whether the default device is connected on every call to `UpdateReferences()`.\r\n- `GCPadEmu.GetStatus()` now sets err bit to `PAD_ERR_NO_CONTROLLER` if the default device isn't connected.\r\n- `SIDevice_GCController` handles `PAD_ERR_NO_CONTROLLER` by imitating the behaviour of `SIDevice_Null` (as far as I can tell, this is the only use of the error bit from `GCPadStatus`).\r\n\r\nI wanted to add an OSD message akin to the ones when Wiimotes get connected/disconnected, but I haven't yet found where to put the logic.","created_at":"2017-02-08T00:42:19Z","updated_at":"2017-02-08T00:42:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/4853/commits","review_comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/4853/comments","review_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/4853/comments","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/6ba25f6dba3aff158ccdf071214fd0554f0ea0f9","head":{"label":"ligfx:always_connected","ref":"always_connected","sha":"6ba25f6dba3aff158ccdf071214fd0554f0ea0f9","user":{"login":"ligfx","id":594093,"avatar_url":"https://avatars.githubusercontent.com/u/594093?v=3","gravatar_id":"","url":"https://api.github.com/users/ligfx","html_url":"https://github.com/ligfx","followers_url":"https://api.github.com/users/ligfx/followers","following_url":"https://api.github.com/users/ligfx/following{/other_user}","gists_url":"https://api.github.com/users/ligfx/gists{/gist_id}","starred_url":"https://api.github.com/users/ligfx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ligfx/subscriptions","organizations_url":"https://api.github.com/users/ligfx/orgs","repos_url":"https://api.github.com/users/ligfx/repos","events_url":"https://api.github.com/users/ligfx/events{/privacy}","received_events_url":"https://api.github.com/users/ligfx/received_events","type":"User","site_admin":false},"repo":{"id":65220721,"name":"dolphin","full_name":"ligfx/dolphin","owner":{"login":"ligfx","id":594093,"avatar_url":"https://avatars.githubusercontent.com/u/594093?v=3","gravatar_id":"","url":"https://api.github.com/users/ligfx","html_url":"https://github.com/ligfx","followers_url":"https://api.github.com/users/ligfx/followers","following_url":"https://api.github.com/users/ligfx/following{/other_user}","gists_url":"https://api.github.com/users/ligfx/gists{/gist_id}","starred_url":"https://api.github.com/users/ligfx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ligfx/subscriptions","organizations_url":"https://api.github.com/users/ligfx/orgs","repos_url":"https://api.github.com/users/ligfx/repos","events_url":"https://api.github.com/users/ligfx/events{/privacy}","received_events_url":"https://api.github.com/users/ligfx/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ligfx/dolphin","description":"Dolphin is a GameCube / Wii emulator, allowing you to play games for these two platforms on PC with improvements.","fork":true,"url":"https://api.github.com/repos/ligfx/dolphin","forks_url":"https://api.github.com/repos/ligfx/dolphin/forks","keys_url":"https://api.github.com/repos/ligfx/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ligfx/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ligfx/dolphin/teams","hooks_url":"https://api.github.com/repos/ligfx/dolphin/hooks","issue_events_url":"https://api.github.com/repos/ligfx/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/ligfx/dolphin/events","assignees_url":"https://api.github.com/repos/ligfx/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/ligfx/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/ligfx/dolphin/tags","blobs_url":"https://api.github.com/repos/ligfx/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ligfx/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ligfx/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/ligfx/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ligfx/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/ligfx/dolphin/languages","stargazers_url":"https://api.github.com/repos/ligfx/dolphin/stargazers","contributors_url":"https://api.github.com/repos/ligfx/dolphin/contributors","subscribers_url":"https://api.github.com/repos/ligfx/dolphin/subscribers","subscription_url":"https://api.github.com/repos/ligfx/dolphin/subscription","commits_url":"https://api.github.com/repos/ligfx/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/ligfx/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/ligfx/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/ligfx/dolphin/issues/comments{/number}","contents_url":"https://api.github.com/repos/ligfx/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/ligfx/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ligfx/dolphin/merges","archive_url":"https://api.github.com/repos/ligfx/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ligfx/dolphin/downloads","issues_url":"https://api.github.com/repos/ligfx/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/ligfx/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/ligfx/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/ligfx/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ligfx/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/ligfx/dolphin/releases{/id}","deployments_url":"https://api.github.com/repos/ligfx/dolphin/deployments","created_at":"2016-08-08T16:31:32Z","updated_at":"2016-12-05T03:22:21Z","pushed_at":"2017-02-08T00:41:38Z","git_url":"git://github.com/ligfx/dolphin.git","ssh_url":"git@github.com:ligfx/dolphin.git","clone_url":"https://github.com/ligfx/dolphin.git","svn_url":"https://github.com/ligfx/dolphin","homepage":"https://dolphin-emu.org/","size":283198,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dolphin-emu:master","ref":"master","sha":"a9ed44cd48acac6e8283911441471dc17cfe3364","user":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars.githubusercontent.com/u/5050316?v=3","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"repo":{"id":11577304,"name":"dolphin","full_name":"dolphin-emu/dolphin","owner":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars.githubusercontent.com/u/5050316?v=3","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dolphin-emu/dolphin","description":"Dolphin is a GameCube / Wii emulator, allowing you to play games for these two platforms on PC with improvements.","fork":false,"url":"https://api.github.com/repos/dolphin-emu/dolphin","forks_url":"https://api.github.com/repos/dolphin-emu/dolphin/forks","keys_url":"https://api.github.com/repos/dolphin-emu/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dolphin-emu/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dolphin-emu/dolphin/teams","hooks_url":"https://api.github.com/repos/dolphin-emu/dolphin/hooks","issue_events_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/dolphin-emu/dolphin/events","assignees_url":"https://api.github.com/repos/dolphin-emu/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/dolphin-emu/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/tags","blobs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/dolphin-emu/dolphin/languages","stargazers_url":"https://api.github.com/repos/dolphin-emu/dolphin/stargazers","contributors_url":"https://api.github.com/repos/dolphin-emu/dolphin/contributors","subscribers_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscribers","subscription_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscription","commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/comments{/number}","contents_url":"https://api.github.com/repos/dolphin-emu/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/dolphin-emu/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dolphin-emu/dolphin/merges","archive_url":"https://api.github.com/repos/dolphin-emu/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dolphin-emu/dolphin/downloads","issues_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/dolphin-emu/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/dolphin-emu/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dolphin-emu/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/dolphin-emu/dolphin/releases{/id}","deployments_url":"https://api.github.com/repos/dolphin-emu/dolphin/deployments","created_at":"2013-07-22T09:07:57Z","updated_at":"2017-02-06T20:46:22Z","pushed_at":"2017-02-08T00:27:20Z","git_url":"git://github.com/dolphin-emu/dolphin.git","ssh_url":"git@github.com:dolphin-emu/dolphin.git","clone_url":"https://github.com/dolphin-emu/dolphin.git","svn_url":"https://github.com/dolphin-emu/dolphin","homepage":"https://dolphin-emu.org/","size":320853,"stargazers_count":3029,"watchers_count":3029,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":810,"mirror_url":null,"open_issues_count":135,"forks":810,"open_issues":135,"watchers":3029,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/4853"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/4853"},"issue":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/4853"},"comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/4853/comments"},"review_comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/4853/comments"},"review_comment":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/4853/commits"},"statuses":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/6ba25f6dba3aff158ccdf071214fd0554f0ea0f9"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":26,"deletions":0,"changed_files":5}}
{"actor":{"display_login":"ligfx"}}