{"action":"created","comment":{"url":"https://api.github.com/repos/python/cpython/pulls/comments/128216426","pull_request_review_id":50873242,"id":128216426,"diff_hunk":"@@ -4236,6 +4236,12 @@ def test_empty(self):\n \n         proc.join()\n \n+    def test_close(self):\n+        queue = multiprocessing.SimpleQueue()\n+        queue.close()\n+        # closing a queue twice should not fail\n+        queue.close()","path":"Lib/test/_test_multiprocessing.py","position":8,"original_position":8,"commit_id":"242e4c9b55e24e659d0f84e564de338389634592","original_commit_id":"242e4c9b55e24e659d0f84e564de338389634592","user":{"login":"pitrou","id":1721820,"avatar_url":"https://avatars2.githubusercontent.com/u/1721820?v=4","gravatar_id":"","url":"https://api.github.com/users/pitrou","html_url":"https://github.com/pitrou","followers_url":"https://api.github.com/users/pitrou/followers","following_url":"https://api.github.com/users/pitrou/following{/other_user}","gists_url":"https://api.github.com/users/pitrou/gists{/gist_id}","starred_url":"https://api.github.com/users/pitrou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pitrou/subscriptions","organizations_url":"https://api.github.com/users/pitrou/orgs","repos_url":"https://api.github.com/users/pitrou/repos","events_url":"https://api.github.com/users/pitrou/events{/privacy}","received_events_url":"https://api.github.com/users/pitrou/received_events","type":"User","site_admin":false},"body":"Usually, it would raise a ValueError.","created_at":"2017-07-19T11:07:10Z","updated_at":"2017-07-19T11:07:10Z","html_url":"https://github.com/python/cpython/pull/2760#discussion_r128216426","pull_request_url":"https://api.github.com/repos/python/cpython/pulls/2760","_links":{"self":{"href":"https://api.github.com/repos/python/cpython/pulls/comments/128216426"},"html":{"href":"https://github.com/python/cpython/pull/2760#discussion_r128216426"},"pull_request":{"href":"https://api.github.com/repos/python/cpython/pulls/2760"}}},"pull_request":{"url":"https://api.github.com/repos/python/cpython/pulls/2760","id":131288095,"html_url":"https://github.com/python/cpython/pull/2760","diff_url":"https://github.com/python/cpython/pull/2760.diff","patch_url":"https://github.com/python/cpython/pull/2760.patch","issue_url":"https://api.github.com/repos/python/cpython/issues/2760","number":2760,"state":"open","locked":false,"title":"bpo-30966: Add multiprocessing.SimpleQueue.close()","user":{"login":"haypo","id":194129,"avatar_url":"https://avatars2.githubusercontent.com/u/194129?v=4","gravatar_id":"","url":"https://api.github.com/users/haypo","html_url":"https://github.com/haypo","followers_url":"https://api.github.com/users/haypo/followers","following_url":"https://api.github.com/users/haypo/following{/other_user}","gists_url":"https://api.github.com/users/haypo/gists{/gist_id}","starred_url":"https://api.github.com/users/haypo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haypo/subscriptions","organizations_url":"https://api.github.com/users/haypo/orgs","repos_url":"https://api.github.com/users/haypo/repos","events_url":"https://api.github.com/users/haypo/events{/privacy}","received_events_url":"https://api.github.com/users/haypo/received_events","type":"User","site_admin":false},"body":"Add a new close() method to multiprocessing.SimpleQueue to explicitly\r\ncloses the queue. This is called automatically when the queue is\r\ngarbage collected.","created_at":"2017-07-19T10:31:21Z","updated_at":"2017-07-19T11:07:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"92ca56d8ae1806680952adcfe0f69bafbe7aa2fb","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/python/cpython/pulls/2760/commits","review_comments_url":"https://api.github.com/repos/python/cpython/pulls/2760/comments","review_comment_url":"https://api.github.com/repos/python/cpython/pulls/comments{/number}","comments_url":"https://api.github.com/repos/python/cpython/issues/2760/comments","statuses_url":"https://api.github.com/repos/python/cpython/statuses/242e4c9b55e24e659d0f84e564de338389634592","head":{"label":"haypo:simplequeue","ref":"simplequeue","sha":"242e4c9b55e24e659d0f84e564de338389634592","user":{"login":"haypo","id":194129,"avatar_url":"https://avatars2.githubusercontent.com/u/194129?v=4","gravatar_id":"","url":"https://api.github.com/users/haypo","html_url":"https://github.com/haypo","followers_url":"https://api.github.com/users/haypo/followers","following_url":"https://api.github.com/users/haypo/following{/other_user}","gists_url":"https://api.github.com/users/haypo/gists{/gist_id}","starred_url":"https://api.github.com/users/haypo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haypo/subscriptions","organizations_url":"https://api.github.com/users/haypo/orgs","repos_url":"https://api.github.com/users/haypo/repos","events_url":"https://api.github.com/users/haypo/events{/privacy}","received_events_url":"https://api.github.com/users/haypo/received_events","type":"User","site_admin":false},"repo":{"id":81613525,"name":"cpython","full_name":"haypo/cpython","owner":{"login":"haypo","id":194129,"avatar_url":"https://avatars2.githubusercontent.com/u/194129?v=4","gravatar_id":"","url":"https://api.github.com/users/haypo","html_url":"https://github.com/haypo","followers_url":"https://api.github.com/users/haypo/followers","following_url":"https://api.github.com/users/haypo/following{/other_user}","gists_url":"https://api.github.com/users/haypo/gists{/gist_id}","starred_url":"https://api.github.com/users/haypo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haypo/subscriptions","organizations_url":"https://api.github.com/users/haypo/orgs","repos_url":"https://api.github.com/users/haypo/repos","events_url":"https://api.github.com/users/haypo/events{/privacy}","received_events_url":"https://api.github.com/users/haypo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/haypo/cpython","description":"The Python programming language","fork":true,"url":"https://api.github.com/repos/haypo/cpython","forks_url":"https://api.github.com/repos/haypo/cpython/forks","keys_url":"https://api.github.com/repos/haypo/cpython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/haypo/cpython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/haypo/cpython/teams","hooks_url":"https://api.github.com/repos/haypo/cpython/hooks","issue_events_url":"https://api.github.com/repos/haypo/cpython/issues/events{/number}","events_url":"https://api.github.com/repos/haypo/cpython/events","assignees_url":"https://api.github.com/repos/haypo/cpython/assignees{/user}","branches_url":"https://api.github.com/repos/haypo/cpython/branches{/branch}","tags_url":"https://api.github.com/repos/haypo/cpython/tags","blobs_url":"https://api.github.com/repos/haypo/cpython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/haypo/cpython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/haypo/cpython/git/refs{/sha}","trees_url":"https://api.github.com/repos/haypo/cpython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/haypo/cpython/statuses/{sha}","languages_url":"https://api.github.com/repos/haypo/cpython/languages","stargazers_url":"https://api.github.com/repos/haypo/cpython/stargazers","contributors_url":"https://api.github.com/repos/haypo/cpython/contributors","subscribers_url":"https://api.github.com/repos/haypo/cpython/subscribers","subscription_url":"https://api.github.com/repos/haypo/cpython/subscription","commits_url":"https://api.github.com/repos/haypo/cpython/commits{/sha}","git_commits_url":"https://api.github.com/repos/haypo/cpython/git/commits{/sha}","comments_url":"https://api.github.com/repos/haypo/cpython/comments{/number}","issue_comment_url":"https://api.github.com/repos/haypo/cpython/issues/comments{/number}","contents_url":"https://api.github.com/repos/haypo/cpython/contents/{+path}","compare_url":"https://api.github.com/repos/haypo/cpython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/haypo/cpython/merges","archive_url":"https://api.github.com/repos/haypo/cpython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/haypo/cpython/downloads","issues_url":"https://api.github.com/repos/haypo/cpython/issues{/number}","pulls_url":"https://api.github.com/repos/haypo/cpython/pulls{/number}","milestones_url":"https://api.github.com/repos/haypo/cpython/milestones{/number}","notifications_url":"https://api.github.com/repos/haypo/cpython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/haypo/cpython/labels{/name}","releases_url":"https://api.github.com/repos/haypo/cpython/releases{/id}","deployments_url":"https://api.github.com/repos/haypo/cpython/deployments","created_at":"2017-02-10T22:40:43Z","updated_at":"2017-07-18T19:01:12Z","pushed_at":"2017-07-19T10:31:10Z","git_url":"git://github.com/haypo/cpython.git","ssh_url":"git@github.com:haypo/cpython.git","clone_url":"https://github.com/haypo/cpython.git","svn_url":"https://github.com/haypo/cpython","homepage":"https://www.python.org/","size":208241,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":4,"default_branch":"master"}},"base":{"label":"python:master","ref":"master","sha":"d81bea6520892e0428aec61c73e0631a69db11bb","user":{"login":"python","id":1525981,"avatar_url":"https://avatars3.githubusercontent.com/u/1525981?v=4","gravatar_id":"","url":"https://api.github.com/users/python","html_url":"https://github.com/python","followers_url":"https://api.github.com/users/python/followers","following_url":"https://api.github.com/users/python/following{/other_user}","gists_url":"https://api.github.com/users/python/gists{/gist_id}","starred_url":"https://api.github.com/users/python/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python/subscriptions","organizations_url":"https://api.github.com/users/python/orgs","repos_url":"https://api.github.com/users/python/repos","events_url":"https://api.github.com/users/python/events{/privacy}","received_events_url":"https://api.github.com/users/python/received_events","type":"Organization","site_admin":false},"repo":{"id":81598961,"name":"cpython","full_name":"python/cpython","owner":{"login":"python","id":1525981,"avatar_url":"https://avatars3.githubusercontent.com/u/1525981?v=4","gravatar_id":"","url":"https://api.github.com/users/python","html_url":"https://github.com/python","followers_url":"https://api.github.com/users/python/followers","following_url":"https://api.github.com/users/python/following{/other_user}","gists_url":"https://api.github.com/users/python/gists{/gist_id}","starred_url":"https://api.github.com/users/python/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python/subscriptions","organizations_url":"https://api.github.com/users/python/orgs","repos_url":"https://api.github.com/users/python/repos","events_url":"https://api.github.com/users/python/events{/privacy}","received_events_url":"https://api.github.com/users/python/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/python/cpython","description":"The Python programming language","fork":false,"url":"https://api.github.com/repos/python/cpython","forks_url":"https://api.github.com/repos/python/cpython/forks","keys_url":"https://api.github.com/repos/python/cpython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/python/cpython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/python/cpython/teams","hooks_url":"https://api.github.com/repos/python/cpython/hooks","issue_events_url":"https://api.github.com/repos/python/cpython/issues/events{/number}","events_url":"https://api.github.com/repos/python/cpython/events","assignees_url":"https://api.github.com/repos/python/cpython/assignees{/user}","branches_url":"https://api.github.com/repos/python/cpython/branches{/branch}","tags_url":"https://api.github.com/repos/python/cpython/tags","blobs_url":"https://api.github.com/repos/python/cpython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/python/cpython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/python/cpython/git/refs{/sha}","trees_url":"https://api.github.com/repos/python/cpython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/python/cpython/statuses/{sha}","languages_url":"https://api.github.com/repos/python/cpython/languages","stargazers_url":"https://api.github.com/repos/python/cpython/stargazers","contributors_url":"https://api.github.com/repos/python/cpython/contributors","subscribers_url":"https://api.github.com/repos/python/cpython/subscribers","subscription_url":"https://api.github.com/repos/python/cpython/subscription","commits_url":"https://api.github.com/repos/python/cpython/commits{/sha}","git_commits_url":"https://api.github.com/repos/python/cpython/git/commits{/sha}","comments_url":"https://api.github.com/repos/python/cpython/comments{/number}","issue_comment_url":"https://api.github.com/repos/python/cpython/issues/comments{/number}","contents_url":"https://api.github.com/repos/python/cpython/contents/{+path}","compare_url":"https://api.github.com/repos/python/cpython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/python/cpython/merges","archive_url":"https://api.github.com/repos/python/cpython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/python/cpython/downloads","issues_url":"https://api.github.com/repos/python/cpython/issues{/number}","pulls_url":"https://api.github.com/repos/python/cpython/pulls{/number}","milestones_url":"https://api.github.com/repos/python/cpython/milestones{/number}","notifications_url":"https://api.github.com/repos/python/cpython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/python/cpython/labels{/name}","releases_url":"https://api.github.com/repos/python/cpython/releases{/id}","deployments_url":"https://api.github.com/repos/python/cpython/deployments","created_at":"2017-02-10T19:23:51Z","updated_at":"2017-07-19T10:55:57Z","pushed_at":"2017-07-19T10:31:22Z","git_url":"git://github.com/python/cpython.git","ssh_url":"git@github.com:python/cpython.git","clone_url":"https://github.com/python/cpython.git","svn_url":"https://github.com/python/cpython","homepage":"https://www.python.org/","size":208365,"stargazers_count":11681,"watchers_count":11681,"language":"Python","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1895,"mirror_url":null,"open_issues_count":395,"forks":1895,"open_issues":395,"watchers":11681,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/python/cpython/pulls/2760"},"html":{"href":"https://github.com/python/cpython/pull/2760"},"issue":{"href":"https://api.github.com/repos/python/cpython/issues/2760"},"comments":{"href":"https://api.github.com/repos/python/cpython/issues/2760/comments"},"review_comments":{"href":"https://api.github.com/repos/python/cpython/pulls/2760/comments"},"review_comment":{"href":"https://api.github.com/repos/python/cpython/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/python/cpython/pulls/2760/commits"},"statuses":{"href":"https://api.github.com/repos/python/cpython/statuses/242e4c9b55e24e659d0f84e564de338389634592"}}}}
{"actor":{"display_login":"pitrou"}}