{"action":"created","issue":{"url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/issues/2511","repository_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS","labels_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/issues/2511/labels{/name}","comments_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/issues/2511/comments","events_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/issues/2511/events","html_url":"https://github.com/WhisperSystems/Signal-iOS/pull/2511","id":255455226,"number":2511,"title":"Fix sending images taken on iOS11 camera.","user":{"login":"michaelkirk","id":217057,"avatar_url":"https://avatars3.githubusercontent.com/u/217057?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelkirk","html_url":"https://github.com/michaelkirk","followers_url":"https://api.github.com/users/michaelkirk/followers","following_url":"https://api.github.com/users/michaelkirk/following{/other_user}","gists_url":"https://api.github.com/users/michaelkirk/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelkirk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelkirk/subscriptions","organizations_url":"https://api.github.com/users/michaelkirk/orgs","repos_url":"https://api.github.com/users/michaelkirk/repos","events_url":"https://api.github.com/users/michaelkirk/events{/privacy}","received_events_url":"https://api.github.com/users/michaelkirk/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-09-06T01:38:17Z","updated_at":"2017-09-06T14:03:49Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/pulls/2511","html_url":"https://github.com/WhisperSystems/Signal-iOS/pull/2511","diff_url":"https://github.com/WhisperSystems/Signal-iOS/pull/2511.diff","patch_url":"https://github.com/WhisperSystems/Signal-iOS/pull/2511.patch"},"body":"fixes https://github.com/WhisperSystems/Signal-iOS/issues/2202\r\n\r\nConvert .heic to .jpg upon sending\r\n\r\nI punted on displaying HEIC natively in Signal, not so much for technical reasons, but moreso that I'm not sure what the right move is here. iOS seems to want to treat HEIC as an internal optimization that's invisible to the user.  e.g. sharing out an HEIC image from Photos converts it to JPG. \r\n\r\nSo at this point, you'd have to be trying pretty hard to actually get an HEIC image into Signal. If you do - maybe you intend for it to *stay* an HEIC? But we couldn't do that if a user e.g. copy/pasted an HEIC image to another thread, since we can't assume the other client understand what HEIC's are. FWIW this is inline with what whatsapp does.\r\n\r\nPTAL @charlesmchen \r\n"},"comment":{"url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/issues/comments/327493353","html_url":"https://github.com/WhisperSystems/Signal-iOS/pull/2511#issuecomment-327493353","issue_url":"https://api.github.com/repos/WhisperSystems/Signal-iOS/issues/2511","id":327493353,"user":{"login":"charlesmchen","id":625803,"avatar_url":"https://avatars1.githubusercontent.com/u/625803?v=4","gravatar_id":"","url":"https://api.github.com/users/charlesmchen","html_url":"https://github.com/charlesmchen","followers_url":"https://api.github.com/users/charlesmchen/followers","following_url":"https://api.github.com/users/charlesmchen/following{/other_user}","gists_url":"https://api.github.com/users/charlesmchen/gists{/gist_id}","starred_url":"https://api.github.com/users/charlesmchen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charlesmchen/subscriptions","organizations_url":"https://api.github.com/users/charlesmchen/orgs","repos_url":"https://api.github.com/users/charlesmchen/repos","events_url":"https://api.github.com/users/charlesmchen/events{/privacy}","received_events_url":"https://api.github.com/users/charlesmchen/received_events","type":"User","site_admin":false},"created_at":"2017-09-06T14:03:49Z","updated_at":"2017-09-06T14:03:49Z","author_association":"CONTRIBUTOR","body":"> I punted on displaying HEIC natively in Signal, not so much for technical reasons, but moreso that I'm not sure what the right move is here.\r\n\r\nMakes sense.\r\n\r\n> e.g. sharing out an HEIC image from Photos converts it to JPG.\r\n\r\nThat includes copying and pasting from the camera roll?  And importing from camera roll in Signal?"}}
{"actor":{"display_login":"charlesmchen"}}