{"action":"created","issue":{"url":"https://api.github.com/repos/espressif/esp-idf/issues/925","repository_url":"https://api.github.com/repos/espressif/esp-idf","labels_url":"https://api.github.com/repos/espressif/esp-idf/issues/925/labels{/name}","comments_url":"https://api.github.com/repos/espressif/esp-idf/issues/925/comments","events_url":"https://api.github.com/repos/espressif/esp-idf/issues/925/events","html_url":"https://github.com/espressif/esp-idf/issues/925","id":251763661,"number":925,"title":"btc_dm_load_ble_local_keys used even if SMP disabled","user":{"login":"lucazader","id":13282660,"avatar_url":"https://avatars1.githubusercontent.com/u/13282660?v=4","gravatar_id":"","url":"https://api.github.com/users/lucazader","html_url":"https://github.com/lucazader","followers_url":"https://api.github.com/users/lucazader/followers","following_url":"https://api.github.com/users/lucazader/following{/other_user}","gists_url":"https://api.github.com/users/lucazader/gists{/gist_id}","starred_url":"https://api.github.com/users/lucazader/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucazader/subscriptions","organizations_url":"https://api.github.com/users/lucazader/orgs","repos_url":"https://api.github.com/users/lucazader/repos","events_url":"https://api.github.com/users/lucazader/events{/privacy}","received_events_url":"https://api.github.com/users/lucazader/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-08-21T20:35:04Z","updated_at":"2017-08-22T06:20:12Z","closed_at":null,"body":"Hi all,\r\n\r\nIn the latest master fc85cb6 there is a compilation error if Include BLE security module(SMP) is disabled in the kconfig.\r\n\r\n`In btc_main.c`\r\n```\r\nstatic void btc_init_bluetooth(void)\r\n{\r\n    osi_alarm_create_mux();\r\n    osi_alarm_init();\r\n    bte_main_boot_entry(btc_init_callback);\r\n    btc_config_init();\r\n    //load the ble local key whitch has been store in the flash\r\n    btc_dm_load_ble_local_keys();\r\n}\r\n```\r\n`btc_dm_load_ble_local_keys` is used without an `#if (SMP_INCLUDED == TRUE)` guard. This will cause a compilation error if SMP is disabled in the kconfig, as the function declaration in the file `btc_ble_storage.h` is excluded from the build using `#if (SMP_INCLUDED == TRUE)`"},"comment":{"url":"https://api.github.com/repos/espressif/esp-idf/issues/comments/323930448","html_url":"https://github.com/espressif/esp-idf/issues/925#issuecomment-323930448","issue_url":"https://api.github.com/repos/espressif/esp-idf/issues/925","id":323930448,"user":{"login":"Yulong-espressif","id":28897663,"avatar_url":"https://avatars3.githubusercontent.com/u/28897663?v=4","gravatar_id":"","url":"https://api.github.com/users/Yulong-espressif","html_url":"https://github.com/Yulong-espressif","followers_url":"https://api.github.com/users/Yulong-espressif/followers","following_url":"https://api.github.com/users/Yulong-espressif/following{/other_user}","gists_url":"https://api.github.com/users/Yulong-espressif/gists{/gist_id}","starred_url":"https://api.github.com/users/Yulong-espressif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yulong-espressif/subscriptions","organizations_url":"https://api.github.com/users/Yulong-espressif/orgs","repos_url":"https://api.github.com/users/Yulong-espressif/repos","events_url":"https://api.github.com/users/Yulong-espressif/events{/privacy}","received_events_url":"https://api.github.com/users/Yulong-espressif/received_events","type":"User","site_admin":false},"created_at":"2017-08-22T06:20:12Z","updated_at":"2017-08-22T06:20:12Z","body":"@lucazader Thanks for your suggestions, I have update the code, please update the SDK and try again, if any question, please let me know. Thank you so so much."}}
{"actor":{"display_login":"Yulong-espressif"}}