{"action":"created","comment":{"url":"https://api.github.com/repos/squanchy-dev/squanchy-android/pulls/comments/120619857","pull_request_review_id":42596968,"id":120619857,"diff_hunk":"@@ -45,23 +49,33 @@ public void onCreate() {\n     }\n \n     @Override\n+    public void onStart(@Nullable Intent intent, int startId) {\n+        super.onStart(intent, startId);\n+        subscriptions = new CompositeDisposable();","path":"app/src/main/java/net/squanchy/notification/NotificationsIntentService.java","position":37,"original_position":37,"commit_id":"48e7a54df1a3b023e8544a4c841f49150a8c1cbe","original_commit_id":"48e7a54df1a3b023e8544a4c841f49150a8c1cbe","user":{"login":"rock3r","id":153802,"avatar_url":"https://avatars1.githubusercontent.com/u/153802?v=3","gravatar_id":"","url":"https://api.github.com/users/rock3r","html_url":"https://github.com/rock3r","followers_url":"https://api.github.com/users/rock3r/followers","following_url":"https://api.github.com/users/rock3r/following{/other_user}","gists_url":"https://api.github.com/users/rock3r/gists{/gist_id}","starred_url":"https://api.github.com/users/rock3r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rock3r/subscriptions","organizations_url":"https://api.github.com/users/rock3r/orgs","repos_url":"https://api.github.com/users/rock3r/repos","events_url":"https://api.github.com/users/rock3r/events{/privacy}","received_events_url":"https://api.github.com/users/rock3r/received_events","type":"User","site_admin":false},"body":"I might have forgotten it :P","created_at":"2017-06-07T13:11:23Z","updated_at":"2017-06-07T13:11:23Z","html_url":"https://github.com/squanchy-dev/squanchy-android/pull/294#discussion_r120619857","pull_request_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/pulls/294","_links":{"self":{"href":"https://api.github.com/repos/squanchy-dev/squanchy-android/pulls/comments/120619857"},"html":{"href":"https://github.com/squanchy-dev/squanchy-android/pull/294#discussion_r120619857"},"pull_request":{"href":"https://api.github.com/repos/squanchy-dev/squanchy-android/pulls/294"}}},"pull_request":{"url":"https://api.github.com/repos/squanchy-dev/squanchy-android/pulls/294","id":124182434,"html_url":"https://github.com/squanchy-dev/squanchy-android/pull/294","diff_url":"https://github.com/squanchy-dev/squanchy-android/pull/294.diff","patch_url":"https://github.com/squanchy-dev/squanchy-android/pull/294.patch","issue_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/issues/294","number":294,"state":"open","locked":false,"title":"Add CI static analysis, address all outstanding warnings","user":{"login":"rock3r","id":153802,"avatar_url":"https://avatars1.githubusercontent.com/u/153802?v=3","gravatar_id":"","url":"https://api.github.com/users/rock3r","html_url":"https://github.com/rock3r","followers_url":"https://api.github.com/users/rock3r/followers","following_url":"https://api.github.com/users/rock3r/following{/other_user}","gists_url":"https://api.github.com/users/rock3r/gists{/gist_id}","starred_url":"https://api.github.com/users/rock3r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rock3r/subscriptions","organizations_url":"https://api.github.com/users/rock3r/orgs","repos_url":"https://api.github.com/users/rock3r/repos","events_url":"https://api.github.com/users/rock3r/events{/privacy}","received_events_url":"https://api.github.com/users/rock3r/received_events","type":"User","site_admin":false},"body":"We have now all the static analysis we might ever want!\r\n\r\n * PMD, Checkstyle and Findbugs for Java code\r\n * [Detekt](https://github.com/arturbosch/detekt) for Kotlin\r\n * Lint for Android-specific issues\r\n\r\nAnd to make this all possible... **SURPRISE CI SWAP!**\r\n\r\nWe're now using [CircleCI](https://circleci.com/gh/squanchy-dev/squanchy-android) instead of Travis. Why?\r\n * Travis is _sloooooow_\r\n   It took an average of 10 minutes on Travis to get a plain build, and with the static analysis this would've ballooned up to unbearable levels. CircleCI completes a static-analysis build in 1-3 minutes _less_ per build compared to Travis' \"naked build\" times\r\n * CircleCI looks good\r\n    Look at that [build report](https://circleci.com/gh/squanchy-dev/squanchy-android/29) page! Nothing else to say ✨ \r\n * I was curious to use CircleCI\r\n   I heard great things about it, and I have to say, while not as flexible/configurable as a Jenkins issue, it's free, fast, flexible enough, and hassle-free. I count that as a win.\r\n * You can easily store test reports and build artifacts (including the static analysis report results)\r\n    See an example [of JUnit test results](https://circleci.com/gh/squanchy-dev/squanchy-android/29#tests/containers/0) and of the [other reports](https://circleci.com/gh/squanchy-dev/squanchy-android/29#artifacts/containers/0) in a sample build.\r\n\r\nNot _everything_ is 100% awesome; in particular, CircleCI only understands the JUnit test reports, but not the other tools', so you still have to fish those out manually. No nice report pages the way Jenkins can generate (yet?). But those are mostly minor things and I feel this is still a big step ahead in the right direction.\r\n\r\n------\r\n\r\nNote: this PR is big-ish because it contains a loooot of static analysis fixes, but most of them are very very trivial changes, so it shouldn't be _too_ big. I'm sorry I couldn't keep it smaller, but the build would never be green if I didn't address them all in one go.","created_at":"2017-06-06T12:49:29Z","updated_at":"2017-06-07T13:11:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0f690e306b5d49c74787bcb16a20d9c1a2f08619","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/pulls/294/commits","review_comments_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/pulls/294/comments","review_comment_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/issues/294/comments","statuses_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/statuses/48e7a54df1a3b023e8544a4c841f49150a8c1cbe","head":{"label":"squanchy-dev:Add_static_analysis_to_builds","ref":"Add_static_analysis_to_builds","sha":"48e7a54df1a3b023e8544a4c841f49150a8c1cbe","user":{"login":"squanchy-dev","id":27221069,"avatar_url":"https://avatars2.githubusercontent.com/u/27221069?v=3","gravatar_id":"","url":"https://api.github.com/users/squanchy-dev","html_url":"https://github.com/squanchy-dev","followers_url":"https://api.github.com/users/squanchy-dev/followers","following_url":"https://api.github.com/users/squanchy-dev/following{/other_user}","gists_url":"https://api.github.com/users/squanchy-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/squanchy-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/squanchy-dev/subscriptions","organizations_url":"https://api.github.com/users/squanchy-dev/orgs","repos_url":"https://api.github.com/users/squanchy-dev/repos","events_url":"https://api.github.com/users/squanchy-dev/events{/privacy}","received_events_url":"https://api.github.com/users/squanchy-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":72942055,"name":"squanchy-android","full_name":"squanchy-dev/squanchy-android","owner":{"login":"squanchy-dev","id":27221069,"avatar_url":"https://avatars2.githubusercontent.com/u/27221069?v=3","gravatar_id":"","url":"https://api.github.com/users/squanchy-dev","html_url":"https://github.com/squanchy-dev","followers_url":"https://api.github.com/users/squanchy-dev/followers","following_url":"https://api.github.com/users/squanchy-dev/following{/other_user}","gists_url":"https://api.github.com/users/squanchy-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/squanchy-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/squanchy-dev/subscriptions","organizations_url":"https://api.github.com/users/squanchy-dev/orgs","repos_url":"https://api.github.com/users/squanchy-dev/repos","events_url":"https://api.github.com/users/squanchy-dev/events{/privacy}","received_events_url":"https://api.github.com/users/squanchy-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/squanchy-dev/squanchy-android","description":"Open source app for your conferences","fork":false,"url":"https://api.github.com/repos/squanchy-dev/squanchy-android","forks_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/forks","keys_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/teams","hooks_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/hooks","issue_events_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/issues/events{/number}","events_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/events","assignees_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/assignees{/user}","branches_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/branches{/branch}","tags_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/tags","blobs_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/statuses/{sha}","languages_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/languages","stargazers_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/stargazers","contributors_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/contributors","subscribers_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/subscribers","subscription_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/subscription","commits_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/contents/{+path}","compare_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/merges","archive_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/downloads","issues_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/issues{/number}","pulls_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/pulls{/number}","milestones_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/milestones{/number}","notifications_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/labels{/name}","releases_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/releases{/id}","deployments_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/deployments","created_at":"2016-11-05T17:26:17Z","updated_at":"2017-06-07T09:27:02Z","pushed_at":"2017-06-06T12:49:30Z","git_url":"git://github.com/squanchy-dev/squanchy-android.git","ssh_url":"git@github.com:squanchy-dev/squanchy-android.git","clone_url":"https://github.com/squanchy-dev/squanchy-android.git","svn_url":"https://github.com/squanchy-dev/squanchy-android","homepage":"","size":22239,"stargazers_count":43,"watchers_count":43,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":25,"forks":9,"open_issues":25,"watchers":43,"default_branch":"develop"}},"base":{"label":"squanchy-dev:develop","ref":"develop","sha":"1b040733cce6eaa7135c496782424f42151acdbb","user":{"login":"squanchy-dev","id":27221069,"avatar_url":"https://avatars2.githubusercontent.com/u/27221069?v=3","gravatar_id":"","url":"https://api.github.com/users/squanchy-dev","html_url":"https://github.com/squanchy-dev","followers_url":"https://api.github.com/users/squanchy-dev/followers","following_url":"https://api.github.com/users/squanchy-dev/following{/other_user}","gists_url":"https://api.github.com/users/squanchy-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/squanchy-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/squanchy-dev/subscriptions","organizations_url":"https://api.github.com/users/squanchy-dev/orgs","repos_url":"https://api.github.com/users/squanchy-dev/repos","events_url":"https://api.github.com/users/squanchy-dev/events{/privacy}","received_events_url":"https://api.github.com/users/squanchy-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":72942055,"name":"squanchy-android","full_name":"squanchy-dev/squanchy-android","owner":{"login":"squanchy-dev","id":27221069,"avatar_url":"https://avatars2.githubusercontent.com/u/27221069?v=3","gravatar_id":"","url":"https://api.github.com/users/squanchy-dev","html_url":"https://github.com/squanchy-dev","followers_url":"https://api.github.com/users/squanchy-dev/followers","following_url":"https://api.github.com/users/squanchy-dev/following{/other_user}","gists_url":"https://api.github.com/users/squanchy-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/squanchy-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/squanchy-dev/subscriptions","organizations_url":"https://api.github.com/users/squanchy-dev/orgs","repos_url":"https://api.github.com/users/squanchy-dev/repos","events_url":"https://api.github.com/users/squanchy-dev/events{/privacy}","received_events_url":"https://api.github.com/users/squanchy-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/squanchy-dev/squanchy-android","description":"Open source app for your conferences","fork":false,"url":"https://api.github.com/repos/squanchy-dev/squanchy-android","forks_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/forks","keys_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/teams","hooks_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/hooks","issue_events_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/issues/events{/number}","events_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/events","assignees_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/assignees{/user}","branches_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/branches{/branch}","tags_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/tags","blobs_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/statuses/{sha}","languages_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/languages","stargazers_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/stargazers","contributors_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/contributors","subscribers_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/subscribers","subscription_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/subscription","commits_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/contents/{+path}","compare_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/merges","archive_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/downloads","issues_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/issues{/number}","pulls_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/pulls{/number}","milestones_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/milestones{/number}","notifications_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/labels{/name}","releases_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/releases{/id}","deployments_url":"https://api.github.com/repos/squanchy-dev/squanchy-android/deployments","created_at":"2016-11-05T17:26:17Z","updated_at":"2017-06-07T09:27:02Z","pushed_at":"2017-06-06T12:49:30Z","git_url":"git://github.com/squanchy-dev/squanchy-android.git","ssh_url":"git@github.com:squanchy-dev/squanchy-android.git","clone_url":"https://github.com/squanchy-dev/squanchy-android.git","svn_url":"https://github.com/squanchy-dev/squanchy-android","homepage":"","size":22239,"stargazers_count":43,"watchers_count":43,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":25,"forks":9,"open_issues":25,"watchers":43,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/squanchy-dev/squanchy-android/pulls/294"},"html":{"href":"https://github.com/squanchy-dev/squanchy-android/pull/294"},"issue":{"href":"https://api.github.com/repos/squanchy-dev/squanchy-android/issues/294"},"comments":{"href":"https://api.github.com/repos/squanchy-dev/squanchy-android/issues/294/comments"},"review_comments":{"href":"https://api.github.com/repos/squanchy-dev/squanchy-android/pulls/294/comments"},"review_comment":{"href":"https://api.github.com/repos/squanchy-dev/squanchy-android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/squanchy-dev/squanchy-android/pulls/294/commits"},"statuses":{"href":"https://api.github.com/repos/squanchy-dev/squanchy-android/statuses/48e7a54df1a3b023e8544a4c841f49150a8c1cbe"}}}}
{"actor":{"display_login":"rock3r"}}