{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments/105904848","pull_request_review_id":26803567,"id":105904848,"diff_hunk":"@@ -37,6 +37,15 @@\n     resource_name: hostnetwork\n   with_items: \"{{ openshift_hosted_routers }}\"\n \n+- name: Set additional permissions for router service account\n+  oc_adm_policy_user:\n+    user: \"system:serviceaccount:{{ item.namespace }}:{{ item.serviceaccount }}\"\n+    namespace: \"{{ item.namespace }}\"\n+    resource_kind: cluster-role\n+    resource_name: cluster-reader\n+  when: item.namespace == 'default'","path":"roles/openshift_hosted/tasks/router/router.yml","position":10,"original_position":10,"commit_id":"a3f2626530456e9eae9492758900a30e8d641b8b","original_commit_id":"a3f2626530456e9eae9492758900a30e8d641b8b","user":{"login":"kwoodson","id":1385770,"avatar_url":"https://avatars1.githubusercontent.com/u/1385770?v=3","gravatar_id":"","url":"https://api.github.com/users/kwoodson","html_url":"https://github.com/kwoodson","followers_url":"https://api.github.com/users/kwoodson/followers","following_url":"https://api.github.com/users/kwoodson/following{/other_user}","gists_url":"https://api.github.com/users/kwoodson/gists{/gist_id}","starred_url":"https://api.github.com/users/kwoodson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwoodson/subscriptions","organizations_url":"https://api.github.com/users/kwoodson/orgs","repos_url":"https://api.github.com/users/kwoodson/repos","events_url":"https://api.github.com/users/kwoodson/events{/privacy}","received_events_url":"https://api.github.com/users/kwoodson/received_events","type":"User","site_admin":false},"body":"@mtnbikenc, good question here.  How we run it today is with the same service account and in the same namespace so a single call would probably suffice.","created_at":"2017-03-14T13:23:25Z","updated_at":"2017-03-14T13:23:25Z","html_url":"https://github.com/openshift/openshift-ansible/pull/3650#discussion_r105904848","pull_request_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/3650","_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments/105904848"},"html":{"href":"https://github.com/openshift/openshift-ansible/pull/3650#discussion_r105904848"},"pull_request":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/3650"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/3650","id":110609577,"html_url":"https://github.com/openshift/openshift-ansible/pull/3650","diff_url":"https://github.com/openshift/openshift-ansible/pull/3650.diff","patch_url":"https://github.com/openshift/openshift-ansible/pull/3650.patch","issue_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/3650","number":3650,"state":"open","locked":false,"title":"Add router svcacct cluster-reader role","user":{"login":"mtnbikenc","id":7808636,"avatar_url":"https://avatars2.githubusercontent.com/u/7808636?v=3","gravatar_id":"","url":"https://api.github.com/users/mtnbikenc","html_url":"https://github.com/mtnbikenc","followers_url":"https://api.github.com/users/mtnbikenc/followers","following_url":"https://api.github.com/users/mtnbikenc/following{/other_user}","gists_url":"https://api.github.com/users/mtnbikenc/gists{/gist_id}","starred_url":"https://api.github.com/users/mtnbikenc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtnbikenc/subscriptions","organizations_url":"https://api.github.com/users/mtnbikenc/orgs","repos_url":"https://api.github.com/users/mtnbikenc/repos","events_url":"https://api.github.com/users/mtnbikenc/events{/privacy}","received_events_url":"https://api.github.com/users/mtnbikenc/received_events","type":"User","site_admin":false},"body":"Fixes 1431583","created_at":"2017-03-14T12:27:29Z","updated_at":"2017-03-14T13:23:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f76d464af6df56300be3e4b99fb340415b5893ed","assignee":{"login":"mtnbikenc","id":7808636,"avatar_url":"https://avatars2.githubusercontent.com/u/7808636?v=3","gravatar_id":"","url":"https://api.github.com/users/mtnbikenc","html_url":"https://github.com/mtnbikenc","followers_url":"https://api.github.com/users/mtnbikenc/followers","following_url":"https://api.github.com/users/mtnbikenc/following{/other_user}","gists_url":"https://api.github.com/users/mtnbikenc/gists{/gist_id}","starred_url":"https://api.github.com/users/mtnbikenc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtnbikenc/subscriptions","organizations_url":"https://api.github.com/users/mtnbikenc/orgs","repos_url":"https://api.github.com/users/mtnbikenc/repos","events_url":"https://api.github.com/users/mtnbikenc/events{/privacy}","received_events_url":"https://api.github.com/users/mtnbikenc/received_events","type":"User","site_admin":false},"assignees":[{"login":"mtnbikenc","id":7808636,"avatar_url":"https://avatars2.githubusercontent.com/u/7808636?v=3","gravatar_id":"","url":"https://api.github.com/users/mtnbikenc","html_url":"https://github.com/mtnbikenc","followers_url":"https://api.github.com/users/mtnbikenc/followers","following_url":"https://api.github.com/users/mtnbikenc/following{/other_user}","gists_url":"https://api.github.com/users/mtnbikenc/gists{/gist_id}","starred_url":"https://api.github.com/users/mtnbikenc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtnbikenc/subscriptions","organizations_url":"https://api.github.com/users/mtnbikenc/orgs","repos_url":"https://api.github.com/users/mtnbikenc/repos","events_url":"https://api.github.com/users/mtnbikenc/events{/privacy}","received_events_url":"https://api.github.com/users/mtnbikenc/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/3650/commits","review_comments_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/3650/comments","review_comment_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/3650/comments","statuses_url":"https://api.github.com/repos/openshift/openshift-ansible/statuses/a3f2626530456e9eae9492758900a30e8d641b8b","head":{"label":"mtnbikenc:fix-router","ref":"fix-router","sha":"a3f2626530456e9eae9492758900a30e8d641b8b","user":{"login":"mtnbikenc","id":7808636,"avatar_url":"https://avatars2.githubusercontent.com/u/7808636?v=3","gravatar_id":"","url":"https://api.github.com/users/mtnbikenc","html_url":"https://github.com/mtnbikenc","followers_url":"https://api.github.com/users/mtnbikenc/followers","following_url":"https://api.github.com/users/mtnbikenc/following{/other_user}","gists_url":"https://api.github.com/users/mtnbikenc/gists{/gist_id}","starred_url":"https://api.github.com/users/mtnbikenc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtnbikenc/subscriptions","organizations_url":"https://api.github.com/users/mtnbikenc/orgs","repos_url":"https://api.github.com/users/mtnbikenc/repos","events_url":"https://api.github.com/users/mtnbikenc/events{/privacy}","received_events_url":"https://api.github.com/users/mtnbikenc/received_events","type":"User","site_admin":false},"repo":{"id":71498311,"name":"openshift-ansible","full_name":"mtnbikenc/openshift-ansible","owner":{"login":"mtnbikenc","id":7808636,"avatar_url":"https://avatars2.githubusercontent.com/u/7808636?v=3","gravatar_id":"","url":"https://api.github.com/users/mtnbikenc","html_url":"https://github.com/mtnbikenc","followers_url":"https://api.github.com/users/mtnbikenc/followers","following_url":"https://api.github.com/users/mtnbikenc/following{/other_user}","gists_url":"https://api.github.com/users/mtnbikenc/gists{/gist_id}","starred_url":"https://api.github.com/users/mtnbikenc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtnbikenc/subscriptions","organizations_url":"https://api.github.com/users/mtnbikenc/orgs","repos_url":"https://api.github.com/users/mtnbikenc/repos","events_url":"https://api.github.com/users/mtnbikenc/events{/privacy}","received_events_url":"https://api.github.com/users/mtnbikenc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mtnbikenc/openshift-ansible","description":"OpenShift Ansible Code","fork":true,"url":"https://api.github.com/repos/mtnbikenc/openshift-ansible","forks_url":"https://api.github.com/repos/mtnbikenc/openshift-ansible/forks","keys_url":"https://api.github.com/repos/mtnbikenc/openshift-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mtnbikenc/openshift-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mtnbikenc/openshift-ansible/teams","hooks_url":"https://api.github.com/repos/mtnbikenc/openshift-ansible/hooks","issue_events_url":"https://api.github.com/repos/mtnbikenc/openshift-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/mtnbikenc/openshift-ansible/events","assignees_url":"https://api.github.com/repos/mtnbikenc/openshift-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/mtnbikenc/openshift-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/mtnbikenc/openshift-ansible/tags","blobs_url":"https://api.github.com/repos/mtnbikenc/openshift-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mtnbikenc/openshift-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mtnbikenc/openshift-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/mtnbikenc/openshift-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mtnbikenc/openshift-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/mtnbikenc/openshift-ansible/languages","stargazers_url":"https://api.github.com/repos/mtnbikenc/openshift-ansible/stargazers","contributors_url":"https://api.github.com/repos/mtnbikenc/openshift-ansible/contributors","subscribers_url":"https://api.github.com/repos/mtnbikenc/openshift-ansible/subscribers","subscription_url":"https://api.github.com/repos/mtnbikenc/openshift-ansible/subscription","commits_url":"https://api.github.com/repos/mtnbikenc/openshift-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/mtnbikenc/openshift-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/mtnbikenc/openshift-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/mtnbikenc/openshift-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/mtnbikenc/openshift-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/mtnbikenc/openshift-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mtnbikenc/openshift-ansible/merges","archive_url":"https://api.github.com/repos/mtnbikenc/openshift-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mtnbikenc/openshift-ansible/downloads","issues_url":"https://api.github.com/repos/mtnbikenc/openshift-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/mtnbikenc/openshift-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/mtnbikenc/openshift-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/mtnbikenc/openshift-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mtnbikenc/openshift-ansible/labels{/name}","releases_url":"https://api.github.com/repos/mtnbikenc/openshift-ansible/releases{/id}","deployments_url":"https://api.github.com/repos/mtnbikenc/openshift-ansible/deployments","created_at":"2016-10-20T19:44:20Z","updated_at":"2016-10-20T19:44:27Z","pushed_at":"2017-03-14T12:57:44Z","git_url":"git://github.com/mtnbikenc/openshift-ansible.git","ssh_url":"git@github.com:mtnbikenc/openshift-ansible.git","clone_url":"https://github.com/mtnbikenc/openshift-ansible.git","svn_url":"https://github.com/mtnbikenc/openshift-ansible","homepage":"install.openshift.com","size":11417,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"46d1efcf1e8ab67deaa6c42460bc510650df17b0","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars0.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":24109199,"name":"openshift-ansible","full_name":"openshift/openshift-ansible","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars0.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/openshift-ansible","description":"OpenShift Installation and Configuration Management","fork":false,"url":"https://api.github.com/repos/openshift/openshift-ansible","forks_url":"https://api.github.com/repos/openshift/openshift-ansible/forks","keys_url":"https://api.github.com/repos/openshift/openshift-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/openshift-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/openshift-ansible/teams","hooks_url":"https://api.github.com/repos/openshift/openshift-ansible/hooks","issue_events_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/openshift-ansible/events","assignees_url":"https://api.github.com/repos/openshift/openshift-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/openshift-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/openshift-ansible/tags","blobs_url":"https://api.github.com/repos/openshift/openshift-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/openshift-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/openshift-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/openshift-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/openshift-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/openshift-ansible/languages","stargazers_url":"https://api.github.com/repos/openshift/openshift-ansible/stargazers","contributors_url":"https://api.github.com/repos/openshift/openshift-ansible/contributors","subscribers_url":"https://api.github.com/repos/openshift/openshift-ansible/subscribers","subscription_url":"https://api.github.com/repos/openshift/openshift-ansible/subscription","commits_url":"https://api.github.com/repos/openshift/openshift-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/openshift-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/openshift-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/openshift-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/openshift-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/openshift-ansible/merges","archive_url":"https://api.github.com/repos/openshift/openshift-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/openshift-ansible/downloads","issues_url":"https://api.github.com/repos/openshift/openshift-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/openshift-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/openshift-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/openshift-ansible/labels{/name}","releases_url":"https://api.github.com/repos/openshift/openshift-ansible/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/openshift-ansible/deployments","created_at":"2014-09-16T17:07:51Z","updated_at":"2017-03-12T17:42:59Z","pushed_at":"2017-03-14T12:53:28Z","git_url":"git://github.com/openshift/openshift-ansible.git","ssh_url":"git@github.com:openshift/openshift-ansible.git","clone_url":"https://github.com/openshift/openshift-ansible.git","svn_url":"https://github.com/openshift/openshift-ansible","homepage":"https://install.openshift.com","size":11662,"stargazers_count":366,"watchers_count":366,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":587,"mirror_url":null,"open_issues_count":343,"forks":587,"open_issues":343,"watchers":366,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/3650"},"html":{"href":"https://github.com/openshift/openshift-ansible/pull/3650"},"issue":{"href":"https://api.github.com/repos/openshift/openshift-ansible/issues/3650"},"comments":{"href":"https://api.github.com/repos/openshift/openshift-ansible/issues/3650/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/3650/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/3650/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/openshift-ansible/statuses/a3f2626530456e9eae9492758900a30e8d641b8b"}}}}
{"actor":{"display_login":"kwoodson"}}