{"action":"created","comment":{"url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-oauth/pulls/comments/149620585","pull_request_review_id":75040901,"id":149620585,"diff_hunk":"@@ -137,10 +140,18 @@ public boolean validateGrant(OAuthTokenReqMessageContext tokReqMsgCtx)\n                 return false;\n             }\n \n-            if (log.isDebugEnabled()) {\n-                log.debug(\"Refresh token validation successful for Client id : \" + tokenReqDTO.getClientId() +\n-                          \", Authorized User : \" + validationDataDO.getAuthorizedUser() +\n-                          \", Token Scope : \" + OAuth2Util.buildScopeString(validationDataDO.getScope()));\n+        }\n+        if (!tokenBindingId.isEmpty()) {\n+            String checkTokenValue = (new String(Base64Utils.decode(refreshToken), (Charsets.UTF_8))).split(\":\")[0];\n+            ;\n+            if (OAuth2Util.checkUserNameAssertionEnabled()) {\n+                checkTokenValue = (new String(Base64Utils.decode(checkTokenValue), (Charsets.UTF_8))).split(\":\")[0];","path":"components/org.wso2.carbon.identity.oauth/src/main/java/org/wso2/carbon/identity/oauth2/token/handlers/grant/RefreshGrantHandler.java","position":33,"original_position":33,"commit_id":"7a2f906a170d3cc39a636ea5f7ef1085402b6fd1","original_commit_id":"7a2f906a170d3cc39a636ea5f7ef1085402b6fd1","user":{"login":"inthirakumaaran","id":17597685,"avatar_url":"https://avatars1.githubusercontent.com/u/17597685?v=4","gravatar_id":"","url":"https://api.github.com/users/inthirakumaaran","html_url":"https://github.com/inthirakumaaran","followers_url":"https://api.github.com/users/inthirakumaaran/followers","following_url":"https://api.github.com/users/inthirakumaaran/following{/other_user}","gists_url":"https://api.github.com/users/inthirakumaaran/gists{/gist_id}","starred_url":"https://api.github.com/users/inthirakumaaran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inthirakumaaran/subscriptions","organizations_url":"https://api.github.com/users/inthirakumaaran/orgs","repos_url":"https://api.github.com/users/inthirakumaaran/repos","events_url":"https://api.github.com/users/inthirakumaaran/events{/privacy}","received_events_url":"https://api.github.com/users/inthirakumaaran/received_events","type":"User","site_admin":false},"body":"change name checkTokenvalue ","created_at":"2017-11-08T09:53:46Z","updated_at":"2017-11-08T09:53:46Z","html_url":"https://github.com/wso2-extensions/identity-inbound-auth-oauth/pull/618#discussion_r149620585","pull_request_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-oauth/pulls/618","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-oauth/pulls/comments/149620585"},"html":{"href":"https://github.com/wso2-extensions/identity-inbound-auth-oauth/pull/618#discussion_r149620585"},"pull_request":{"href":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-oauth/pulls/618"}}},"pull_request":{"url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-oauth/pulls/618","id":148598112,"html_url":"https://github.com/wso2-extensions/identity-inbound-auth-oauth/pull/618","diff_url":"https://github.com/wso2-extensions/identity-inbound-auth-oauth/pull/618.diff","patch_url":"https://github.com/wso2-extensions/identity-inbound-auth-oauth/pull/618.patch","issue_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-oauth/issues/618","number":618,"state":"open","locked":false,"title":"Token binding for Oauth2.0","user":{"login":"inthirakumaaran","id":17597685,"avatar_url":"https://avatars1.githubusercontent.com/u/17597685?v=4","gravatar_id":"","url":"https://api.github.com/users/inthirakumaaran","html_url":"https://github.com/inthirakumaaran","followers_url":"https://api.github.com/users/inthirakumaaran/followers","following_url":"https://api.github.com/users/inthirakumaaran/following{/other_user}","gists_url":"https://api.github.com/users/inthirakumaaran/gists{/gist_id}","starred_url":"https://api.github.com/users/inthirakumaaran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inthirakumaaran/subscriptions","organizations_url":"https://api.github.com/users/inthirakumaaran/orgs","repos_url":"https://api.github.com/users/inthirakumaaran/repos","events_url":"https://api.github.com/users/inthirakumaaran/events{/privacy}","received_events_url":"https://api.github.com/users/inthirakumaaran/received_events","type":"User","site_admin":false},"body":"### Proposed changes in this pull request\r\n\r\nImplementation of Token Binding for Oauth2.0\r\n\r\n-\r\n\r\n### When should this PR be merged\r\n\r\n\r\n### Follow up actions\r\n\r\nCode Review\r\n\r\n-\r\n\r\n\r\n### Checklist (for reviewing)\r\n\r\n#### General\r\n\r\n- [ ] **Is this PR explained thoroughly?** All code changes must be accounted for in the PR description.\r\n- [ ] **Is the PR labeled correctly?**\r\n\r\n#### Functionality\r\n\r\n- [ ] **Are all requirements met?** Compare implemented functionality with the requirements specification.\r\n- [ ] **Does the UI work as expected?** There should be no Javascript errors in the console; all resources should load. There should be no unexpected errors. Deliberately try to break the feature to find out if there are corner cases that are not handled.\r\n\r\n#### Code\r\n\r\n- [ ] **Do you fully understand the introduced changes to the code?** If not ask for clarification, it might uncover ways to solve a problem in a more elegant and efficient way.\r\n- [ ] **Does the PR introduce any inefficient database requests?** Use the debug server to check for duplicate requests.\r\n- [ ] **Are all necessary strings marked for translation?** All strings that are exposed to users via the UI must be [marked for translation](https://docs.djangoproject.com/en/1.10/topics/i18n/translation/).\r\n\r\n#### Tests\r\n\r\n- [ ] **Are there sufficient test cases?** Ensure that all components are tested individually; models, forms, and serializers should be tested in isolation even if a test for a view covers these components.\r\n- [ ] **If this is a bug fix, are tests for the issue in place?**  There must be a test case for the bug to ensure the issue won’t regress. Make sure that the tests break without the new code to fix the issue.\r\n- [ ] **If this is a new feature or a significant change to an existing feature?** has the manual testing spreadsheet been updated with instructions for manual testing?\r\n\r\n#### Security\r\n\r\n- [ ] **Confirm this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.**\r\n- [ ] **Are all UI and API inputs run through forms or serializers?**\r\n- [ ] **Are all external inputs validated and sanitized appropriately?**\r\n- [ ] **Does all branching logic have a default case?**\r\n- [ ] **Does this solution handle outliers and edge cases gracefully?**\r\n- [ ] **Are all external communications secured and restricted to SSL?**\r\n\r\n#### Documentation\r\n\r\n- [ ] **Are changes to the UI documented in the platform docs?** If this PR introduces new platform site functionality or changes existing ones, the changes should be documented.\r\n- [ ] **Are changes to the API documented in the API docs?** If this PR introduces new API functionality or changes existing ones, the changes must be documented.\r\n- [ ] **Are reusable components documented?** If this PR introduces components that are relevant to other developers (for instance a mixin for a view or a generic form) they should be documented in the Wiki.\r\n","created_at":"2017-10-25T08:14:33Z","updated_at":"2017-11-08T09:53:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bd51810ce24831c8662127fa4c61654847ac6956","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-oauth/pulls/618/commits","review_comments_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-oauth/pulls/618/comments","review_comment_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-oauth/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-oauth/issues/618/comments","statuses_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-oauth/statuses/7a2f906a170d3cc39a636ea5f7ef1085402b6fd1","head":{"label":"inthirakumaaran:token-binding-rebase-new","ref":"token-binding-rebase-new","sha":"7a2f906a170d3cc39a636ea5f7ef1085402b6fd1","user":{"login":"inthirakumaaran","id":17597685,"avatar_url":"https://avatars1.githubusercontent.com/u/17597685?v=4","gravatar_id":"","url":"https://api.github.com/users/inthirakumaaran","html_url":"https://github.com/inthirakumaaran","followers_url":"https://api.github.com/users/inthirakumaaran/followers","following_url":"https://api.github.com/users/inthirakumaaran/following{/other_user}","gists_url":"https://api.github.com/users/inthirakumaaran/gists{/gist_id}","starred_url":"https://api.github.com/users/inthirakumaaran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inthirakumaaran/subscriptions","organizations_url":"https://api.github.com/users/inthirakumaaran/orgs","repos_url":"https://api.github.com/users/inthirakumaaran/repos","events_url":"https://api.github.com/users/inthirakumaaran/events{/privacy}","received_events_url":"https://api.github.com/users/inthirakumaaran/received_events","type":"User","site_admin":false},"repo":{"id":97468749,"name":"identity-inbound-auth-oauth","full_name":"inthirakumaaran/identity-inbound-auth-oauth","owner":{"login":"inthirakumaaran","id":17597685,"avatar_url":"https://avatars1.githubusercontent.com/u/17597685?v=4","gravatar_id":"","url":"https://api.github.com/users/inthirakumaaran","html_url":"https://github.com/inthirakumaaran","followers_url":"https://api.github.com/users/inthirakumaaran/followers","following_url":"https://api.github.com/users/inthirakumaaran/following{/other_user}","gists_url":"https://api.github.com/users/inthirakumaaran/gists{/gist_id}","starred_url":"https://api.github.com/users/inthirakumaaran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inthirakumaaran/subscriptions","organizations_url":"https://api.github.com/users/inthirakumaaran/orgs","repos_url":"https://api.github.com/users/inthirakumaaran/repos","events_url":"https://api.github.com/users/inthirakumaaran/events{/privacy}","received_events_url":"https://api.github.com/users/inthirakumaaran/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/inthirakumaaran/identity-inbound-auth-oauth","description":null,"fork":true,"url":"https://api.github.com/repos/inthirakumaaran/identity-inbound-auth-oauth","forks_url":"https://api.github.com/repos/inthirakumaaran/identity-inbound-auth-oauth/forks","keys_url":"https://api.github.com/repos/inthirakumaaran/identity-inbound-auth-oauth/keys{/key_id}","collaborators_url":"https://api.github.com/repos/inthirakumaaran/identity-inbound-auth-oauth/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/inthirakumaaran/identity-inbound-auth-oauth/teams","hooks_url":"https://api.github.com/repos/inthirakumaaran/identity-inbound-auth-oauth/hooks","issue_events_url":"https://api.github.com/repos/inthirakumaaran/identity-inbound-auth-oauth/issues/events{/number}","events_url":"https://api.github.com/repos/inthirakumaaran/identity-inbound-auth-oauth/events","assignees_url":"https://api.github.com/repos/inthirakumaaran/identity-inbound-auth-oauth/assignees{/user}","branches_url":"https://api.github.com/repos/inthirakumaaran/identity-inbound-auth-oauth/branches{/branch}","tags_url":"https://api.github.com/repos/inthirakumaaran/identity-inbound-auth-oauth/tags","blobs_url":"https://api.github.com/repos/inthirakumaaran/identity-inbound-auth-oauth/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/inthirakumaaran/identity-inbound-auth-oauth/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/inthirakumaaran/identity-inbound-auth-oauth/git/refs{/sha}","trees_url":"https://api.github.com/repos/inthirakumaaran/identity-inbound-auth-oauth/git/trees{/sha}","statuses_url":"https://api.github.com/repos/inthirakumaaran/identity-inbound-auth-oauth/statuses/{sha}","languages_url":"https://api.github.com/repos/inthirakumaaran/identity-inbound-auth-oauth/languages","stargazers_url":"https://api.github.com/repos/inthirakumaaran/identity-inbound-auth-oauth/stargazers","contributors_url":"https://api.github.com/repos/inthirakumaaran/identity-inbound-auth-oauth/contributors","subscribers_url":"https://api.github.com/repos/inthirakumaaran/identity-inbound-auth-oauth/subscribers","subscription_url":"https://api.github.com/repos/inthirakumaaran/identity-inbound-auth-oauth/subscription","commits_url":"https://api.github.com/repos/inthirakumaaran/identity-inbound-auth-oauth/commits{/sha}","git_commits_url":"https://api.github.com/repos/inthirakumaaran/identity-inbound-auth-oauth/git/commits{/sha}","comments_url":"https://api.github.com/repos/inthirakumaaran/identity-inbound-auth-oauth/comments{/number}","issue_comment_url":"https://api.github.com/repos/inthirakumaaran/identity-inbound-auth-oauth/issues/comments{/number}","contents_url":"https://api.github.com/repos/inthirakumaaran/identity-inbound-auth-oauth/contents/{+path}","compare_url":"https://api.github.com/repos/inthirakumaaran/identity-inbound-auth-oauth/compare/{base}...{head}","merges_url":"https://api.github.com/repos/inthirakumaaran/identity-inbound-auth-oauth/merges","archive_url":"https://api.github.com/repos/inthirakumaaran/identity-inbound-auth-oauth/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/inthirakumaaran/identity-inbound-auth-oauth/downloads","issues_url":"https://api.github.com/repos/inthirakumaaran/identity-inbound-auth-oauth/issues{/number}","pulls_url":"https://api.github.com/repos/inthirakumaaran/identity-inbound-auth-oauth/pulls{/number}","milestones_url":"https://api.github.com/repos/inthirakumaaran/identity-inbound-auth-oauth/milestones{/number}","notifications_url":"https://api.github.com/repos/inthirakumaaran/identity-inbound-auth-oauth/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/inthirakumaaran/identity-inbound-auth-oauth/labels{/name}","releases_url":"https://api.github.com/repos/inthirakumaaran/identity-inbound-auth-oauth/releases{/id}","deployments_url":"https://api.github.com/repos/inthirakumaaran/identity-inbound-auth-oauth/deployments","created_at":"2017-07-17T11:27:43Z","updated_at":"2017-07-17T11:27:46Z","pushed_at":"2017-11-06T14:53:31Z","git_url":"git://github.com/inthirakumaaran/identity-inbound-auth-oauth.git","ssh_url":"git@github.com:inthirakumaaran/identity-inbound-auth-oauth.git","clone_url":"https://github.com/inthirakumaaran/identity-inbound-auth-oauth.git","svn_url":"https://github.com/inthirakumaaran/identity-inbound-auth-oauth","homepage":null,"size":5904,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wso2-extensions:feature-token-binding","ref":"feature-token-binding","sha":"5b15e7a2748f6c8ec53629dbe66708cf1cf6fe0f","user":{"login":"wso2-extensions","id":17171218,"avatar_url":"https://avatars0.githubusercontent.com/u/17171218?v=4","gravatar_id":"","url":"https://api.github.com/users/wso2-extensions","html_url":"https://github.com/wso2-extensions","followers_url":"https://api.github.com/users/wso2-extensions/followers","following_url":"https://api.github.com/users/wso2-extensions/following{/other_user}","gists_url":"https://api.github.com/users/wso2-extensions/gists{/gist_id}","starred_url":"https://api.github.com/users/wso2-extensions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wso2-extensions/subscriptions","organizations_url":"https://api.github.com/users/wso2-extensions/orgs","repos_url":"https://api.github.com/users/wso2-extensions/repos","events_url":"https://api.github.com/users/wso2-extensions/events{/privacy}","received_events_url":"https://api.github.com/users/wso2-extensions/received_events","type":"Organization","site_admin":false},"repo":{"id":52758721,"name":"identity-inbound-auth-oauth","full_name":"wso2-extensions/identity-inbound-auth-oauth","owner":{"login":"wso2-extensions","id":17171218,"avatar_url":"https://avatars0.githubusercontent.com/u/17171218?v=4","gravatar_id":"","url":"https://api.github.com/users/wso2-extensions","html_url":"https://github.com/wso2-extensions","followers_url":"https://api.github.com/users/wso2-extensions/followers","following_url":"https://api.github.com/users/wso2-extensions/following{/other_user}","gists_url":"https://api.github.com/users/wso2-extensions/gists{/gist_id}","starred_url":"https://api.github.com/users/wso2-extensions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wso2-extensions/subscriptions","organizations_url":"https://api.github.com/users/wso2-extensions/orgs","repos_url":"https://api.github.com/users/wso2-extensions/repos","events_url":"https://api.github.com/users/wso2-extensions/events{/privacy}","received_events_url":"https://api.github.com/users/wso2-extensions/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wso2-extensions/identity-inbound-auth-oauth","description":null,"fork":false,"url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-oauth","forks_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-oauth/forks","keys_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-oauth/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-oauth/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-oauth/teams","hooks_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-oauth/hooks","issue_events_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-oauth/issues/events{/number}","events_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-oauth/events","assignees_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-oauth/assignees{/user}","branches_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-oauth/branches{/branch}","tags_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-oauth/tags","blobs_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-oauth/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-oauth/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-oauth/git/refs{/sha}","trees_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-oauth/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-oauth/statuses/{sha}","languages_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-oauth/languages","stargazers_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-oauth/stargazers","contributors_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-oauth/contributors","subscribers_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-oauth/subscribers","subscription_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-oauth/subscription","commits_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-oauth/commits{/sha}","git_commits_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-oauth/git/commits{/sha}","comments_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-oauth/comments{/number}","issue_comment_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-oauth/issues/comments{/number}","contents_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-oauth/contents/{+path}","compare_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-oauth/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-oauth/merges","archive_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-oauth/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-oauth/downloads","issues_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-oauth/issues{/number}","pulls_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-oauth/pulls{/number}","milestones_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-oauth/milestones{/number}","notifications_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-oauth/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-oauth/labels{/name}","releases_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-oauth/releases{/id}","deployments_url":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-oauth/deployments","created_at":"2016-02-29T02:41:06Z","updated_at":"2016-11-22T06:54:23Z","pushed_at":"2017-11-08T08:53:49Z","git_url":"git://github.com/wso2-extensions/identity-inbound-auth-oauth.git","ssh_url":"git@github.com:wso2-extensions/identity-inbound-auth-oauth.git","clone_url":"https://github.com/wso2-extensions/identity-inbound-auth-oauth.git","svn_url":"https://github.com/wso2-extensions/identity-inbound-auth-oauth","homepage":null,"size":6567,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":88,"mirror_url":null,"archived":false,"open_issues_count":34,"forks":88,"open_issues":34,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-oauth/pulls/618"},"html":{"href":"https://github.com/wso2-extensions/identity-inbound-auth-oauth/pull/618"},"issue":{"href":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-oauth/issues/618"},"comments":{"href":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-oauth/issues/618/comments"},"review_comments":{"href":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-oauth/pulls/618/comments"},"review_comment":{"href":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-oauth/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-oauth/pulls/618/commits"},"statuses":{"href":"https://api.github.com/repos/wso2-extensions/identity-inbound-auth-oauth/statuses/7a2f906a170d3cc39a636ea5f7ef1085402b6fd1"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"inthirakumaaran"}}