{"action":"created","comment":{"url":"https://api.github.com/repos/openresty/lua-nginx-module/pulls/comments/96175786","pull_request_review_id":16751610,"id":96175786,"diff_hunk":"@@ -1437,9 +1437,6 @@ ngx_http_lua_run_thread(lua_State *L, ngx_http_request_t *r,\n \n             ctx->cur_co_ctx = next_coctx;\n \n-            ngx_log_error(NGX_LOG_ERR, r->connection->log, 0,\n-                          \"lua coroutine: %s: %s\\n%s\", err, msg, trace);","path":"src/ngx_http_lua_util.c","position":5,"original_position":5,"commit_id":"f4d07dd8657e2539a86aaa920e5beac629f1b945","original_commit_id":"f4d07dd8657e2539a86aaa920e5beac629f1b945","user":{"login":"bungle","id":983257,"avatar_url":"https://avatars.githubusercontent.com/u/983257?v=3","gravatar_id":"","url":"https://api.github.com/users/bungle","html_url":"https://github.com/bungle","followers_url":"https://api.github.com/users/bungle/followers","following_url":"https://api.github.com/users/bungle/following{/other_user}","gists_url":"https://api.github.com/users/bungle/gists{/gist_id}","starred_url":"https://api.github.com/users/bungle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bungle/subscriptions","organizations_url":"https://api.github.com/users/bungle/orgs","repos_url":"https://api.github.com/users/bungle/repos","events_url":"https://api.github.com/users/bungle/events{/privacy}","received_events_url":"https://api.github.com/users/bungle/received_events","type":"User","site_admin":false},"body":"@agentzh, I agree, but that's how the Lua is. Those that use `coroutine.resume` should know that it is effectively a `pcall`. There is some history to this as `pcall` has not been fully compatible with coroutines (http://lua-users.org/wiki/PcallAndCoroutines).","created_at":"2017-01-16T07:44:14Z","updated_at":"2017-01-16T07:44:14Z","html_url":"https://github.com/openresty/lua-nginx-module/pull/952#discussion_r96175786","pull_request_url":"https://api.github.com/repos/openresty/lua-nginx-module/pulls/952","_links":{"self":{"href":"https://api.github.com/repos/openresty/lua-nginx-module/pulls/comments/96175786"},"html":{"href":"https://github.com/openresty/lua-nginx-module/pull/952#discussion_r96175786"},"pull_request":{"href":"https://api.github.com/repos/openresty/lua-nginx-module/pulls/952"}}},"pull_request":{"url":"https://api.github.com/repos/openresty/lua-nginx-module/pulls/952","id":101351124,"html_url":"https://github.com/openresty/lua-nginx-module/pull/952","diff_url":"https://github.com/openresty/lua-nginx-module/pull/952.diff","patch_url":"https://github.com/openresty/lua-nginx-module/pull/952.patch","issue_url":"https://api.github.com/repos/openresty/lua-nginx-module/issues/952","number":952,"state":"open","locked":false,"title":"No error logging on coroutine.resume (pull-request for issue #951)","user":{"login":"bungle","id":983257,"avatar_url":"https://avatars.githubusercontent.com/u/983257?v=3","gravatar_id":"","url":"https://api.github.com/users/bungle","html_url":"https://github.com/bungle","followers_url":"https://api.github.com/users/bungle/followers","following_url":"https://api.github.com/users/bungle/following{/other_user}","gists_url":"https://api.github.com/users/bungle/gists{/gist_id}","starred_url":"https://api.github.com/users/bungle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bungle/subscriptions","organizations_url":"https://api.github.com/users/bungle/orgs","repos_url":"https://api.github.com/users/bungle/repos","events_url":"https://api.github.com/users/bungle/events{/privacy}","received_events_url":"https://api.github.com/users/bungle/received_events","type":"User","site_admin":false},"body":"I hereby granted the copyright of the changes in this pull request to the authors of this lua-nginx-module project.\r\n\r\nSee more details on #951.","created_at":"2017-01-12T22:11:38Z","updated_at":"2017-01-16T07:44:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a10357e37673c79faa1590b60ab8a239cbd8d889","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/openresty/lua-nginx-module/pulls/952/commits","review_comments_url":"https://api.github.com/repos/openresty/lua-nginx-module/pulls/952/comments","review_comment_url":"https://api.github.com/repos/openresty/lua-nginx-module/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openresty/lua-nginx-module/issues/952/comments","statuses_url":"https://api.github.com/repos/openresty/lua-nginx-module/statuses/f4d07dd8657e2539a86aaa920e5beac629f1b945","head":{"label":"bungle:master","ref":"master","sha":"f4d07dd8657e2539a86aaa920e5beac629f1b945","user":{"login":"bungle","id":983257,"avatar_url":"https://avatars.githubusercontent.com/u/983257?v=3","gravatar_id":"","url":"https://api.github.com/users/bungle","html_url":"https://github.com/bungle","followers_url":"https://api.github.com/users/bungle/followers","following_url":"https://api.github.com/users/bungle/following{/other_user}","gists_url":"https://api.github.com/users/bungle/gists{/gist_id}","starred_url":"https://api.github.com/users/bungle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bungle/subscriptions","organizations_url":"https://api.github.com/users/bungle/orgs","repos_url":"https://api.github.com/users/bungle/repos","events_url":"https://api.github.com/users/bungle/events{/privacy}","received_events_url":"https://api.github.com/users/bungle/received_events","type":"User","site_admin":false},"repo":{"id":78786307,"name":"lua-nginx-module","full_name":"bungle/lua-nginx-module","owner":{"login":"bungle","id":983257,"avatar_url":"https://avatars.githubusercontent.com/u/983257?v=3","gravatar_id":"","url":"https://api.github.com/users/bungle","html_url":"https://github.com/bungle","followers_url":"https://api.github.com/users/bungle/followers","following_url":"https://api.github.com/users/bungle/following{/other_user}","gists_url":"https://api.github.com/users/bungle/gists{/gist_id}","starred_url":"https://api.github.com/users/bungle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bungle/subscriptions","organizations_url":"https://api.github.com/users/bungle/orgs","repos_url":"https://api.github.com/users/bungle/repos","events_url":"https://api.github.com/users/bungle/events{/privacy}","received_events_url":"https://api.github.com/users/bungle/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bungle/lua-nginx-module","description":"Embed the Power of Lua into NGINX HTTP servers","fork":true,"url":"https://api.github.com/repos/bungle/lua-nginx-module","forks_url":"https://api.github.com/repos/bungle/lua-nginx-module/forks","keys_url":"https://api.github.com/repos/bungle/lua-nginx-module/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bungle/lua-nginx-module/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bungle/lua-nginx-module/teams","hooks_url":"https://api.github.com/repos/bungle/lua-nginx-module/hooks","issue_events_url":"https://api.github.com/repos/bungle/lua-nginx-module/issues/events{/number}","events_url":"https://api.github.com/repos/bungle/lua-nginx-module/events","assignees_url":"https://api.github.com/repos/bungle/lua-nginx-module/assignees{/user}","branches_url":"https://api.github.com/repos/bungle/lua-nginx-module/branches{/branch}","tags_url":"https://api.github.com/repos/bungle/lua-nginx-module/tags","blobs_url":"https://api.github.com/repos/bungle/lua-nginx-module/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bungle/lua-nginx-module/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bungle/lua-nginx-module/git/refs{/sha}","trees_url":"https://api.github.com/repos/bungle/lua-nginx-module/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bungle/lua-nginx-module/statuses/{sha}","languages_url":"https://api.github.com/repos/bungle/lua-nginx-module/languages","stargazers_url":"https://api.github.com/repos/bungle/lua-nginx-module/stargazers","contributors_url":"https://api.github.com/repos/bungle/lua-nginx-module/contributors","subscribers_url":"https://api.github.com/repos/bungle/lua-nginx-module/subscribers","subscription_url":"https://api.github.com/repos/bungle/lua-nginx-module/subscription","commits_url":"https://api.github.com/repos/bungle/lua-nginx-module/commits{/sha}","git_commits_url":"https://api.github.com/repos/bungle/lua-nginx-module/git/commits{/sha}","comments_url":"https://api.github.com/repos/bungle/lua-nginx-module/comments{/number}","issue_comment_url":"https://api.github.com/repos/bungle/lua-nginx-module/issues/comments{/number}","contents_url":"https://api.github.com/repos/bungle/lua-nginx-module/contents/{+path}","compare_url":"https://api.github.com/repos/bungle/lua-nginx-module/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bungle/lua-nginx-module/merges","archive_url":"https://api.github.com/repos/bungle/lua-nginx-module/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bungle/lua-nginx-module/downloads","issues_url":"https://api.github.com/repos/bungle/lua-nginx-module/issues{/number}","pulls_url":"https://api.github.com/repos/bungle/lua-nginx-module/pulls{/number}","milestones_url":"https://api.github.com/repos/bungle/lua-nginx-module/milestones{/number}","notifications_url":"https://api.github.com/repos/bungle/lua-nginx-module/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bungle/lua-nginx-module/labels{/name}","releases_url":"https://api.github.com/repos/bungle/lua-nginx-module/releases{/id}","deployments_url":"https://api.github.com/repos/bungle/lua-nginx-module/deployments","created_at":"2017-01-12T20:56:17Z","updated_at":"2017-01-12T20:56:21Z","pushed_at":"2017-01-15T10:39:19Z","git_url":"git://github.com/bungle/lua-nginx-module.git","ssh_url":"git@github.com:bungle/lua-nginx-module.git","clone_url":"https://github.com/bungle/lua-nginx-module.git","svn_url":"https://github.com/bungle/lua-nginx-module","homepage":"https://openresty.org/","size":11478,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openresty:master","ref":"master","sha":"1ada6d0e59d28f958227c6eedc6ae1a4867830e1","user":{"login":"openresty","id":7390180,"avatar_url":"https://avatars.githubusercontent.com/u/7390180?v=3","gravatar_id":"","url":"https://api.github.com/users/openresty","html_url":"https://github.com/openresty","followers_url":"https://api.github.com/users/openresty/followers","following_url":"https://api.github.com/users/openresty/following{/other_user}","gists_url":"https://api.github.com/users/openresty/gists{/gist_id}","starred_url":"https://api.github.com/users/openresty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openresty/subscriptions","organizations_url":"https://api.github.com/users/openresty/orgs","repos_url":"https://api.github.com/users/openresty/repos","events_url":"https://api.github.com/users/openresty/events{/privacy}","received_events_url":"https://api.github.com/users/openresty/received_events","type":"Organization","site_admin":false},"repo":{"id":613829,"name":"lua-nginx-module","full_name":"openresty/lua-nginx-module","owner":{"login":"openresty","id":7390180,"avatar_url":"https://avatars.githubusercontent.com/u/7390180?v=3","gravatar_id":"","url":"https://api.github.com/users/openresty","html_url":"https://github.com/openresty","followers_url":"https://api.github.com/users/openresty/followers","following_url":"https://api.github.com/users/openresty/following{/other_user}","gists_url":"https://api.github.com/users/openresty/gists{/gist_id}","starred_url":"https://api.github.com/users/openresty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openresty/subscriptions","organizations_url":"https://api.github.com/users/openresty/orgs","repos_url":"https://api.github.com/users/openresty/repos","events_url":"https://api.github.com/users/openresty/events{/privacy}","received_events_url":"https://api.github.com/users/openresty/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openresty/lua-nginx-module","description":"Embed the Power of Lua into NGINX HTTP servers","fork":false,"url":"https://api.github.com/repos/openresty/lua-nginx-module","forks_url":"https://api.github.com/repos/openresty/lua-nginx-module/forks","keys_url":"https://api.github.com/repos/openresty/lua-nginx-module/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openresty/lua-nginx-module/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openresty/lua-nginx-module/teams","hooks_url":"https://api.github.com/repos/openresty/lua-nginx-module/hooks","issue_events_url":"https://api.github.com/repos/openresty/lua-nginx-module/issues/events{/number}","events_url":"https://api.github.com/repos/openresty/lua-nginx-module/events","assignees_url":"https://api.github.com/repos/openresty/lua-nginx-module/assignees{/user}","branches_url":"https://api.github.com/repos/openresty/lua-nginx-module/branches{/branch}","tags_url":"https://api.github.com/repos/openresty/lua-nginx-module/tags","blobs_url":"https://api.github.com/repos/openresty/lua-nginx-module/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openresty/lua-nginx-module/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openresty/lua-nginx-module/git/refs{/sha}","trees_url":"https://api.github.com/repos/openresty/lua-nginx-module/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openresty/lua-nginx-module/statuses/{sha}","languages_url":"https://api.github.com/repos/openresty/lua-nginx-module/languages","stargazers_url":"https://api.github.com/repos/openresty/lua-nginx-module/stargazers","contributors_url":"https://api.github.com/repos/openresty/lua-nginx-module/contributors","subscribers_url":"https://api.github.com/repos/openresty/lua-nginx-module/subscribers","subscription_url":"https://api.github.com/repos/openresty/lua-nginx-module/subscription","commits_url":"https://api.github.com/repos/openresty/lua-nginx-module/commits{/sha}","git_commits_url":"https://api.github.com/repos/openresty/lua-nginx-module/git/commits{/sha}","comments_url":"https://api.github.com/repos/openresty/lua-nginx-module/comments{/number}","issue_comment_url":"https://api.github.com/repos/openresty/lua-nginx-module/issues/comments{/number}","contents_url":"https://api.github.com/repos/openresty/lua-nginx-module/contents/{+path}","compare_url":"https://api.github.com/repos/openresty/lua-nginx-module/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openresty/lua-nginx-module/merges","archive_url":"https://api.github.com/repos/openresty/lua-nginx-module/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openresty/lua-nginx-module/downloads","issues_url":"https://api.github.com/repos/openresty/lua-nginx-module/issues{/number}","pulls_url":"https://api.github.com/repos/openresty/lua-nginx-module/pulls{/number}","milestones_url":"https://api.github.com/repos/openresty/lua-nginx-module/milestones{/number}","notifications_url":"https://api.github.com/repos/openresty/lua-nginx-module/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openresty/lua-nginx-module/labels{/name}","releases_url":"https://api.github.com/repos/openresty/lua-nginx-module/releases{/id}","deployments_url":"https://api.github.com/repos/openresty/lua-nginx-module/deployments","created_at":"2010-04-16T15:59:01Z","updated_at":"2017-01-16T07:33:29Z","pushed_at":"2017-01-16T07:21:19Z","git_url":"git://github.com/openresty/lua-nginx-module.git","ssh_url":"git@github.com:openresty/lua-nginx-module.git","clone_url":"https://github.com/openresty/lua-nginx-module.git","svn_url":"https://github.com/openresty/lua-nginx-module","homepage":"https://openresty.org/","size":11474,"stargazers_count":3955,"watchers_count":3955,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":921,"mirror_url":null,"open_issues_count":104,"forks":921,"open_issues":104,"watchers":3955,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openresty/lua-nginx-module/pulls/952"},"html":{"href":"https://github.com/openresty/lua-nginx-module/pull/952"},"issue":{"href":"https://api.github.com/repos/openresty/lua-nginx-module/issues/952"},"comments":{"href":"https://api.github.com/repos/openresty/lua-nginx-module/issues/952/comments"},"review_comments":{"href":"https://api.github.com/repos/openresty/lua-nginx-module/pulls/952/comments"},"review_comment":{"href":"https://api.github.com/repos/openresty/lua-nginx-module/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openresty/lua-nginx-module/pulls/952/commits"},"statuses":{"href":"https://api.github.com/repos/openresty/lua-nginx-module/statuses/f4d07dd8657e2539a86aaa920e5beac629f1b945"}}}}
{"actor":{"display_login":"bungle"}}