{"action":"created","issue":{"url":"https://api.github.com/repos/NAUbackup/VmBackup/issues/51","repository_url":"https://api.github.com/repos/NAUbackup/VmBackup","labels_url":"https://api.github.com/repos/NAUbackup/VmBackup/issues/51/labels{/name}","comments_url":"https://api.github.com/repos/NAUbackup/VmBackup/issues/51/comments","events_url":"https://api.github.com/repos/NAUbackup/VmBackup/issues/51/events","html_url":"https://github.com/NAUbackup/VmBackup/pull/51","id":257132092,"number":51,"title":"Fix #45, #43, #36","user":{"login":"lancefogle","id":23724891,"avatar_url":"https://avatars0.githubusercontent.com/u/23724891?v=4","gravatar_id":"","url":"https://api.github.com/users/lancefogle","html_url":"https://github.com/lancefogle","followers_url":"https://api.github.com/users/lancefogle/followers","following_url":"https://api.github.com/users/lancefogle/following{/other_user}","gists_url":"https://api.github.com/users/lancefogle/gists{/gist_id}","starred_url":"https://api.github.com/users/lancefogle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lancefogle/subscriptions","organizations_url":"https://api.github.com/users/lancefogle/orgs","repos_url":"https://api.github.com/users/lancefogle/repos","events_url":"https://api.github.com/users/lancefogle/events{/privacy}","received_events_url":"https://api.github.com/users/lancefogle/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2017-09-12T18:02:14Z","updated_at":"2017-09-12T20:10:56Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/NAUbackup/VmBackup/pulls/51","html_url":"https://github.com/NAUbackup/VmBackup/pull/51","diff_url":"https://github.com/NAUbackup/VmBackup/pull/51.diff","patch_url":"https://github.com/NAUbackup/VmBackup/pull/51.patch"},"body":"Incorporates changes from #39 and #46 but actually implements a complete fix for the exclude when using regexp.\r\n\r\nThe all_vms list was being updated inside the loop that is iterating over that same list. This causes the loop to break which is why even a ```exclude=.*``` will not exclude more than one match. The fix was to move the updating of the all_vms array after the loop and only when ```found_match``` is ```true```.\r\n\r\nThis code also removes the ```all_vms.remove(vm)``` line completely from the ```save_to_config_export``` function which shouldn't be removing anything as it is for **adding** to the array, not removing."},"comment":{"url":"https://api.github.com/repos/NAUbackup/VmBackup/issues/comments/328970348","html_url":"https://github.com/NAUbackup/VmBackup/pull/51#issuecomment-328970348","issue_url":"https://api.github.com/repos/NAUbackup/VmBackup/issues/51","id":328970348,"user":{"login":"lancefogle","id":23724891,"avatar_url":"https://avatars0.githubusercontent.com/u/23724891?v=4","gravatar_id":"","url":"https://api.github.com/users/lancefogle","html_url":"https://github.com/lancefogle","followers_url":"https://api.github.com/users/lancefogle/followers","following_url":"https://api.github.com/users/lancefogle/following{/other_user}","gists_url":"https://api.github.com/users/lancefogle/gists{/gist_id}","starred_url":"https://api.github.com/users/lancefogle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lancefogle/subscriptions","organizations_url":"https://api.github.com/users/lancefogle/orgs","repos_url":"https://api.github.com/users/lancefogle/repos","events_url":"https://api.github.com/users/lancefogle/events{/privacy}","received_events_url":"https://api.github.com/users/lancefogle/received_events","type":"User","site_admin":false},"created_at":"2017-09-12T20:10:55Z","updated_at":"2017-09-12T20:10:55Z","author_association":"NONE","body":"No problem @NAUbackup\r\n\r\nSee my fix for an edge case I just caught for when all VMs match prior to vm-export being applied that caused an erroneous warning. I also made a cosmetic change to effect how the config output appears making it in alphabetical order instead of reverse."}}
{"actor":{"display_login":"lancefogle"}}