{"action":"created","comment":{"url":"https://api.github.com/repos/mattermost/platform/pulls/comments/129292997","pull_request_review_id":52049689,"id":129292997,"diff_hunk":"@@ -3400,6 +3404,38 @@\n     \"translation\": \"Missing require user property: username.\"\n   },\n   {\n+    \"id\": \"app.import.validate_user_import_data.notify_props_desktop_invalid.error\",\n+    \"translation\": \"Invalid Desktop Notify Prop value for user.\"\n+  },\n+  {\n+    \"id\": \"app.import.validate_user_import_data.notify_props_desktop_duration_invalid.error\",\n+    \"translation\": \"Invalid Desktop Duration Notify Prop value for user.\"\n+  },\n+  {\n+    \"id\": \"app.import.validate_user_import_data.notify_props_desktop_sound_invalid.error\",\n+    \"translation\": \"Invalid Desktop Sound Notify Prop value for user.\"\n+  },\n+  {\n+    \"id\": \"app.import.validate_user_import_data.notify_props_email_invalid.error\",\n+    \"translation\": \"Invalid Email Notify Prop value for user.\"\n+  },\n+  {\n+    \"id\": \"app.import.validate_user_import_data.notify_props_mobile_invalid.error\",\n+    \"translation\": \"Invalid Mobile Notify Prop value for user.\"\n+  },\n+  {\n+    \"id\": \"app.import.validate_user_import_data.notify_props_mobile_push_status_invalid.error\",\n+    \"translation\": \"Invalid Mobile Push Status Notify Prop for user.\"\n+  },\n+  {\n+    \"id\": \"app.import.validate_user_import_data.notify_props_channel_trigger_invalid.error\",\n+    \"translation\": \"Invalid Channel Trigger Notify Prop for user.\"\n+  },\n+  {\n+    \"id\": \"app.import.validate_user_import_data.notify_props_comment_trigger_invalid.error\",\n+    \"translation\": \"Invalid Comment Trigger Notify Prop for user.\"\n+  },\n+  {","path":"i18n/en.json","position":46,"original_position":46,"commit_id":"8f6b317e1f790c8cb1f1fe643eaebcebeb1a4cc7","original_commit_id":"8f6b317e1f790c8cb1f1fe643eaebcebeb1a4cc7","user":{"login":"MusikPolice","id":1799952,"avatar_url":"https://avatars2.githubusercontent.com/u/1799952?v=4","gravatar_id":"","url":"https://api.github.com/users/MusikPolice","html_url":"https://github.com/MusikPolice","followers_url":"https://api.github.com/users/MusikPolice/followers","following_url":"https://api.github.com/users/MusikPolice/following{/other_user}","gists_url":"https://api.github.com/users/MusikPolice/gists{/gist_id}","starred_url":"https://api.github.com/users/MusikPolice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MusikPolice/subscriptions","organizations_url":"https://api.github.com/users/MusikPolice/orgs","repos_url":"https://api.github.com/users/MusikPolice/repos","events_url":"https://api.github.com/users/MusikPolice/events{/privacy}","received_events_url":"https://api.github.com/users/MusikPolice/received_events","type":"User","site_admin":false},"body":"Could these error messages be made more actionable? If I'm a user that sees one of these, I may not know what to change to fix the problem. Something like \"Your comment notification properties are invalid. Try x y and z to solve the error\" might be more useful.","created_at":"2017-07-25T12:45:07Z","updated_at":"2017-07-25T12:45:07Z","html_url":"https://github.com/mattermost/platform/pull/7019#discussion_r129292997","pull_request_url":"https://api.github.com/repos/mattermost/platform/pulls/7019","_links":{"self":{"href":"https://api.github.com/repos/mattermost/platform/pulls/comments/129292997"},"html":{"href":"https://github.com/mattermost/platform/pull/7019#discussion_r129292997"},"pull_request":{"href":"https://api.github.com/repos/mattermost/platform/pulls/7019"}}},"pull_request":{"url":"https://api.github.com/repos/mattermost/platform/pulls/7019","id":132249439,"html_url":"https://github.com/mattermost/platform/pull/7019","diff_url":"https://github.com/mattermost/platform/pull/7019.diff","patch_url":"https://github.com/mattermost/platform/pull/7019.patch","issue_url":"https://api.github.com/repos/mattermost/platform/issues/7019","number":7019,"state":"open","locked":false,"title":"PLT-7183: User/Channel NotifyProps Bulk Import.","user":{"login":"grundleborg","id":1198059,"avatar_url":"https://avatars1.githubusercontent.com/u/1198059?v=4","gravatar_id":"","url":"https://api.github.com/users/grundleborg","html_url":"https://github.com/grundleborg","followers_url":"https://api.github.com/users/grundleborg/followers","following_url":"https://api.github.com/users/grundleborg/following{/other_user}","gists_url":"https://api.github.com/users/grundleborg/gists{/gist_id}","starred_url":"https://api.github.com/users/grundleborg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grundleborg/subscriptions","organizations_url":"https://api.github.com/users/grundleborg/orgs","repos_url":"https://api.github.com/users/grundleborg/repos","events_url":"https://api.github.com/users/grundleborg/events{/privacy}","received_events_url":"https://api.github.com/users/grundleborg/received_events","type":"User","site_admin":false},"body":"#### Summary\r\nAdd full support for User and Channel NotifyProps in Bulk Importer.\r\n\r\n#### Ticket Link\r\nhttps://mattermost.atlassian.net/browse/PLT-7183\r\n\r\n#### Checklist\r\n- [x] Added or updated unit tests (required for all new features)\r\n- [x] Includes text changes and localization file updates\r\n","created_at":"2017-07-25T10:36:38Z","updated_at":"2017-07-25T12:45:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ffa66ca17d888ed169dce01ae9f9e8bbe3f810c3","assignee":null,"assignees":[],"requested_reviewers":[{"login":"coreyhulen","id":1431746,"avatar_url":"https://avatars2.githubusercontent.com/u/1431746?v=4","gravatar_id":"","url":"https://api.github.com/users/coreyhulen","html_url":"https://github.com/coreyhulen","followers_url":"https://api.github.com/users/coreyhulen/followers","following_url":"https://api.github.com/users/coreyhulen/following{/other_user}","gists_url":"https://api.github.com/users/coreyhulen/gists{/gist_id}","starred_url":"https://api.github.com/users/coreyhulen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreyhulen/subscriptions","organizations_url":"https://api.github.com/users/coreyhulen/orgs","repos_url":"https://api.github.com/users/coreyhulen/repos","events_url":"https://api.github.com/users/coreyhulen/events{/privacy}","received_events_url":"https://api.github.com/users/coreyhulen/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/mattermost/platform/milestones/25","html_url":"https://github.com/mattermost/platform/milestone/25","labels_url":"https://api.github.com/repos/mattermost/platform/milestones/25/labels","id":2610705,"number":25,"title":"v4.1.0","description":"","creator":{"login":"jasonblais","id":13119842,"avatar_url":"https://avatars1.githubusercontent.com/u/13119842?v=4","gravatar_id":"","url":"https://api.github.com/users/jasonblais","html_url":"https://github.com/jasonblais","followers_url":"https://api.github.com/users/jasonblais/followers","following_url":"https://api.github.com/users/jasonblais/following{/other_user}","gists_url":"https://api.github.com/users/jasonblais/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonblais/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonblais/subscriptions","organizations_url":"https://api.github.com/users/jasonblais/orgs","repos_url":"https://api.github.com/users/jasonblais/repos","events_url":"https://api.github.com/users/jasonblais/events{/privacy}","received_events_url":"https://api.github.com/users/jasonblais/received_events","type":"User","site_admin":false},"open_issues":32,"closed_issues":32,"state":"open","created_at":"2017-06-28T20:02:45Z","updated_at":"2017-07-25T12:25:56Z","due_on":"2017-08-16T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/mattermost/platform/pulls/7019/commits","review_comments_url":"https://api.github.com/repos/mattermost/platform/pulls/7019/comments","review_comment_url":"https://api.github.com/repos/mattermost/platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mattermost/platform/issues/7019/comments","statuses_url":"https://api.github.com/repos/mattermost/platform/statuses/8f6b317e1f790c8cb1f1fe643eaebcebeb1a4cc7","head":{"label":"grundleborg:PLT-7183","ref":"PLT-7183","sha":"8f6b317e1f790c8cb1f1fe643eaebcebeb1a4cc7","user":{"login":"grundleborg","id":1198059,"avatar_url":"https://avatars1.githubusercontent.com/u/1198059?v=4","gravatar_id":"","url":"https://api.github.com/users/grundleborg","html_url":"https://github.com/grundleborg","followers_url":"https://api.github.com/users/grundleborg/followers","following_url":"https://api.github.com/users/grundleborg/following{/other_user}","gists_url":"https://api.github.com/users/grundleborg/gists{/gist_id}","starred_url":"https://api.github.com/users/grundleborg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grundleborg/subscriptions","organizations_url":"https://api.github.com/users/grundleborg/orgs","repos_url":"https://api.github.com/users/grundleborg/repos","events_url":"https://api.github.com/users/grundleborg/events{/privacy}","received_events_url":"https://api.github.com/users/grundleborg/received_events","type":"User","site_admin":false},"repo":{"id":66004466,"name":"platform","full_name":"grundleborg/platform","owner":{"login":"grundleborg","id":1198059,"avatar_url":"https://avatars1.githubusercontent.com/u/1198059?v=4","gravatar_id":"","url":"https://api.github.com/users/grundleborg","html_url":"https://github.com/grundleborg","followers_url":"https://api.github.com/users/grundleborg/followers","following_url":"https://api.github.com/users/grundleborg/following{/other_user}","gists_url":"https://api.github.com/users/grundleborg/gists{/gist_id}","starred_url":"https://api.github.com/users/grundleborg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grundleborg/subscriptions","organizations_url":"https://api.github.com/users/grundleborg/orgs","repos_url":"https://api.github.com/users/grundleborg/repos","events_url":"https://api.github.com/users/grundleborg/events{/privacy}","received_events_url":"https://api.github.com/users/grundleborg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/grundleborg/platform","description":"Open source Slack-alternative in Golang and React - Mattermost","fork":true,"url":"https://api.github.com/repos/grundleborg/platform","forks_url":"https://api.github.com/repos/grundleborg/platform/forks","keys_url":"https://api.github.com/repos/grundleborg/platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grundleborg/platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grundleborg/platform/teams","hooks_url":"https://api.github.com/repos/grundleborg/platform/hooks","issue_events_url":"https://api.github.com/repos/grundleborg/platform/issues/events{/number}","events_url":"https://api.github.com/repos/grundleborg/platform/events","assignees_url":"https://api.github.com/repos/grundleborg/platform/assignees{/user}","branches_url":"https://api.github.com/repos/grundleborg/platform/branches{/branch}","tags_url":"https://api.github.com/repos/grundleborg/platform/tags","blobs_url":"https://api.github.com/repos/grundleborg/platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grundleborg/platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grundleborg/platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/grundleborg/platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grundleborg/platform/statuses/{sha}","languages_url":"https://api.github.com/repos/grundleborg/platform/languages","stargazers_url":"https://api.github.com/repos/grundleborg/platform/stargazers","contributors_url":"https://api.github.com/repos/grundleborg/platform/contributors","subscribers_url":"https://api.github.com/repos/grundleborg/platform/subscribers","subscription_url":"https://api.github.com/repos/grundleborg/platform/subscription","commits_url":"https://api.github.com/repos/grundleborg/platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/grundleborg/platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/grundleborg/platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/grundleborg/platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/grundleborg/platform/contents/{+path}","compare_url":"https://api.github.com/repos/grundleborg/platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grundleborg/platform/merges","archive_url":"https://api.github.com/repos/grundleborg/platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grundleborg/platform/downloads","issues_url":"https://api.github.com/repos/grundleborg/platform/issues{/number}","pulls_url":"https://api.github.com/repos/grundleborg/platform/pulls{/number}","milestones_url":"https://api.github.com/repos/grundleborg/platform/milestones{/number}","notifications_url":"https://api.github.com/repos/grundleborg/platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grundleborg/platform/labels{/name}","releases_url":"https://api.github.com/repos/grundleborg/platform/releases{/id}","deployments_url":"https://api.github.com/repos/grundleborg/platform/deployments","created_at":"2016-08-18T14:35:40Z","updated_at":"2016-08-18T14:35:43Z","pushed_at":"2017-07-25T11:19:51Z","git_url":"git://github.com/grundleborg/platform.git","ssh_url":"git@github.com:grundleborg/platform.git","clone_url":"https://github.com/grundleborg/platform.git","svn_url":"https://github.com/grundleborg/platform","homepage":"http://mattermost.org","size":98879,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mattermost:master","ref":"master","sha":"345dd400bbe2f41c45b08dc06e3199c900361fff","user":{"login":"mattermost","id":9828093,"avatar_url":"https://avatars1.githubusercontent.com/u/9828093?v=4","gravatar_id":"","url":"https://api.github.com/users/mattermost","html_url":"https://github.com/mattermost","followers_url":"https://api.github.com/users/mattermost/followers","following_url":"https://api.github.com/users/mattermost/following{/other_user}","gists_url":"https://api.github.com/users/mattermost/gists{/gist_id}","starred_url":"https://api.github.com/users/mattermost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattermost/subscriptions","organizations_url":"https://api.github.com/users/mattermost/orgs","repos_url":"https://api.github.com/users/mattermost/repos","events_url":"https://api.github.com/users/mattermost/events{/privacy}","received_events_url":"https://api.github.com/users/mattermost/received_events","type":"Organization","site_admin":false},"repo":{"id":37448451,"name":"platform","full_name":"mattermost/platform","owner":{"login":"mattermost","id":9828093,"avatar_url":"https://avatars1.githubusercontent.com/u/9828093?v=4","gravatar_id":"","url":"https://api.github.com/users/mattermost","html_url":"https://github.com/mattermost","followers_url":"https://api.github.com/users/mattermost/followers","following_url":"https://api.github.com/users/mattermost/following{/other_user}","gists_url":"https://api.github.com/users/mattermost/gists{/gist_id}","starred_url":"https://api.github.com/users/mattermost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattermost/subscriptions","organizations_url":"https://api.github.com/users/mattermost/orgs","repos_url":"https://api.github.com/users/mattermost/repos","events_url":"https://api.github.com/users/mattermost/events{/privacy}","received_events_url":"https://api.github.com/users/mattermost/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mattermost/platform","description":"Open source Slack-alternative in Golang and React - Mattermost","fork":false,"url":"https://api.github.com/repos/mattermost/platform","forks_url":"https://api.github.com/repos/mattermost/platform/forks","keys_url":"https://api.github.com/repos/mattermost/platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mattermost/platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mattermost/platform/teams","hooks_url":"https://api.github.com/repos/mattermost/platform/hooks","issue_events_url":"https://api.github.com/repos/mattermost/platform/issues/events{/number}","events_url":"https://api.github.com/repos/mattermost/platform/events","assignees_url":"https://api.github.com/repos/mattermost/platform/assignees{/user}","branches_url":"https://api.github.com/repos/mattermost/platform/branches{/branch}","tags_url":"https://api.github.com/repos/mattermost/platform/tags","blobs_url":"https://api.github.com/repos/mattermost/platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mattermost/platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mattermost/platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/mattermost/platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mattermost/platform/statuses/{sha}","languages_url":"https://api.github.com/repos/mattermost/platform/languages","stargazers_url":"https://api.github.com/repos/mattermost/platform/stargazers","contributors_url":"https://api.github.com/repos/mattermost/platform/contributors","subscribers_url":"https://api.github.com/repos/mattermost/platform/subscribers","subscription_url":"https://api.github.com/repos/mattermost/platform/subscription","commits_url":"https://api.github.com/repos/mattermost/platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/mattermost/platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/mattermost/platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/mattermost/platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/mattermost/platform/contents/{+path}","compare_url":"https://api.github.com/repos/mattermost/platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mattermost/platform/merges","archive_url":"https://api.github.com/repos/mattermost/platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mattermost/platform/downloads","issues_url":"https://api.github.com/repos/mattermost/platform/issues{/number}","pulls_url":"https://api.github.com/repos/mattermost/platform/pulls{/number}","milestones_url":"https://api.github.com/repos/mattermost/platform/milestones{/number}","notifications_url":"https://api.github.com/repos/mattermost/platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mattermost/platform/labels{/name}","releases_url":"https://api.github.com/repos/mattermost/platform/releases{/id}","deployments_url":"https://api.github.com/repos/mattermost/platform/deployments","created_at":"2015-06-15T06:50:02Z","updated_at":"2017-07-25T10:39:44Z","pushed_at":"2017-07-25T12:25:57Z","git_url":"git://github.com/mattermost/platform.git","ssh_url":"git@github.com:mattermost/platform.git","clone_url":"https://github.com/mattermost/platform.git","svn_url":"https://github.com/mattermost/platform","homepage":"https://mattermost.com","size":99713,"stargazers_count":10727,"watchers_count":10727,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1683,"mirror_url":null,"open_issues_count":204,"forks":1683,"open_issues":204,"watchers":10727,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mattermost/platform/pulls/7019"},"html":{"href":"https://github.com/mattermost/platform/pull/7019"},"issue":{"href":"https://api.github.com/repos/mattermost/platform/issues/7019"},"comments":{"href":"https://api.github.com/repos/mattermost/platform/issues/7019/comments"},"review_comments":{"href":"https://api.github.com/repos/mattermost/platform/pulls/7019/comments"},"review_comment":{"href":"https://api.github.com/repos/mattermost/platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mattermost/platform/pulls/7019/commits"},"statuses":{"href":"https://api.github.com/repos/mattermost/platform/statuses/8f6b317e1f790c8cb1f1fe643eaebcebeb1a4cc7"}}}}
{"actor":{"display_login":"MusikPolice"}}