{"action":"created","issue":{"url":"https://api.github.com/repos/trilinos/Trilinos/issues/1666","repository_url":"https://api.github.com/repos/trilinos/Trilinos","labels_url":"https://api.github.com/repos/trilinos/Trilinos/issues/1666/labels{/name}","comments_url":"https://api.github.com/repos/trilinos/Trilinos/issues/1666/comments","events_url":"https://api.github.com/repos/trilinos/Trilinos/issues/1666/events","html_url":"https://github.com/trilinos/Trilinos/pull/1666","id":254406810,"number":1666,"title":"Tpetra: silence warning about shadowed gid var","user":{"login":"ibaned","id":971921,"avatar_url":"https://avatars2.githubusercontent.com/u/971921?v=4","gravatar_id":"","url":"https://api.github.com/users/ibaned","html_url":"https://github.com/ibaned","followers_url":"https://api.github.com/users/ibaned/followers","following_url":"https://api.github.com/users/ibaned/following{/other_user}","gists_url":"https://api.github.com/users/ibaned/gists{/gist_id}","starred_url":"https://api.github.com/users/ibaned/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibaned/subscriptions","organizations_url":"https://api.github.com/users/ibaned/orgs","repos_url":"https://api.github.com/users/ibaned/repos","events_url":"https://api.github.com/users/ibaned/events{/privacy}","received_events_url":"https://api.github.com/users/ibaned/received_events","type":"User","site_admin":false},"labels":[{"id":318642986,"url":"https://api.github.com/repos/trilinos/Trilinos/labels/in%20progress","name":"in progress","color":"ededed","default":false},{"id":289606028,"url":"https://api.github.com/repos/trilinos/Trilinos/labels/Tpetra","name":"Tpetra","color":"5319e7","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-08-31T17:14:00Z","updated_at":"2017-08-31T17:30:22Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/trilinos/Trilinos/pulls/1666","html_url":"https://github.com/trilinos/Trilinos/pull/1666","diff_url":"https://github.com/trilinos/Trilinos/pull/1666.diff","patch_url":"https://github.com/trilinos/Trilinos/pull/1666.patch"},"body":"This fixes a warning about a shadowed variable name.\r\nPersonally, I think the need to pass a value to `packValueCount` is really causing more trouble than its worth. I don't see a scenario in which a value-dependent packing scheme would give any benefit, and I suspect not all users of `packValueCount` correctly call it for such a change."},"comment":{"url":"https://api.github.com/repos/trilinos/Trilinos/issues/comments/326366943","html_url":"https://github.com/trilinos/Trilinos/pull/1666#issuecomment-326366943","issue_url":"https://api.github.com/repos/trilinos/Trilinos/issues/1666","id":326366943,"user":{"login":"ibaned","id":971921,"avatar_url":"https://avatars2.githubusercontent.com/u/971921?v=4","gravatar_id":"","url":"https://api.github.com/users/ibaned","html_url":"https://github.com/ibaned","followers_url":"https://api.github.com/users/ibaned/followers","following_url":"https://api.github.com/users/ibaned/following{/other_user}","gists_url":"https://api.github.com/users/ibaned/gists{/gist_id}","starred_url":"https://api.github.com/users/ibaned/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibaned/subscriptions","organizations_url":"https://api.github.com/users/ibaned/orgs","repos_url":"https://api.github.com/users/ibaned/repos","events_url":"https://api.github.com/users/ibaned/events{/privacy}","received_events_url":"https://api.github.com/users/ibaned/received_events","type":"User","site_admin":false},"created_at":"2017-08-31T17:30:21Z","updated_at":"2017-08-31T17:30:21Z","author_association":"CONTRIBUTOR","body":"@tjfulle, thanks for letting me know, I didn't know that specialization existed. Still, that doesn't affect this PR as I just changed the name of the temporary. In addition, this code explicitly calls the `GO` specialization of `PackTraits`, so it is worth considering whether the \"normal\" `packValueCount` function could be overloaded or use default arguments to work when no value is passed in. The line of code I modified just makes up a value of zero, which is not even future proof to the case when `GO` packing becomes value-dependent, its just minimally satisfying this unnecessary requirement."}}
{"actor":{"display_login":"ibaned"}}