{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/orleans/pulls/comments/98792263","pull_request_review_id":19446133,"id":98792263,"diff_hunk":"@@ -126,6 +126,9 @@ public static bool IsStatelessWorker(MethodInfo methodInfo)\n         \n         public static int ComputeMethodId(MethodInfo methodInfo)\n         {\n+            var attr = methodInfo.GetCustomAttribute<MethodIdAttribute>(true);\n+            if (attr != null) return attr.MethodId;","path":"src/Orleans/CodeGeneration/GrainInterfaceUtils.cs","position":5,"original_position":5,"commit_id":"a2117334e9e66f33c500586e4566c72572c1e363","original_commit_id":"a2117334e9e66f33c500586e4566c72572c1e363","user":{"login":"ReubenBond","id":203839,"avatar_url":"https://avatars.githubusercontent.com/u/203839?v=3","gravatar_id":"","url":"https://api.github.com/users/ReubenBond","html_url":"https://github.com/ReubenBond","followers_url":"https://api.github.com/users/ReubenBond/followers","following_url":"https://api.github.com/users/ReubenBond/following{/other_user}","gists_url":"https://api.github.com/users/ReubenBond/gists{/gist_id}","starred_url":"https://api.github.com/users/ReubenBond/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReubenBond/subscriptions","organizations_url":"https://api.github.com/users/ReubenBond/orgs","repos_url":"https://api.github.com/users/ReubenBond/repos","events_url":"https://api.github.com/users/ReubenBond/events{/privacy}","received_events_url":"https://api.github.com/users/ReubenBond/received_events","type":"User","site_admin":false},"body":"@galvesribeiro it will fail the build at runtime ;)","created_at":"2017-01-31T22:56:39Z","updated_at":"2017-01-31T22:56:39Z","html_url":"https://github.com/dotnet/orleans/pull/2660#discussion_r98792263","pull_request_url":"https://api.github.com/repos/dotnet/orleans/pulls/2660","_links":{"self":{"href":"https://api.github.com/repos/dotnet/orleans/pulls/comments/98792263"},"html":{"href":"https://github.com/dotnet/orleans/pull/2660#discussion_r98792263"},"pull_request":{"href":"https://api.github.com/repos/dotnet/orleans/pulls/2660"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/orleans/pulls/2660","id":103869494,"html_url":"https://github.com/dotnet/orleans/pull/2660","diff_url":"https://github.com/dotnet/orleans/pull/2660.diff","patch_url":"https://github.com/dotnet/orleans/pull/2660.patch","issue_url":"https://api.github.com/repos/dotnet/orleans/issues/2660","number":2660,"state":"closed","locked":false,"title":"Allow overriding MethodId using [MethodId(id)] on interface methods","user":{"login":"ReubenBond","id":203839,"avatar_url":"https://avatars.githubusercontent.com/u/203839?v=3","gravatar_id":"","url":"https://api.github.com/users/ReubenBond","html_url":"https://github.com/ReubenBond","followers_url":"https://api.github.com/users/ReubenBond/followers","following_url":"https://api.github.com/users/ReubenBond/following{/other_user}","gists_url":"https://api.github.com/users/ReubenBond/gists{/gist_id}","starred_url":"https://api.github.com/users/ReubenBond/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReubenBond/subscriptions","organizations_url":"https://api.github.com/users/ReubenBond/orgs","repos_url":"https://api.github.com/users/ReubenBond/repos","events_url":"https://api.github.com/users/ReubenBond/events{/privacy}","received_events_url":"https://api.github.com/users/ReubenBond/received_events","type":"User","site_admin":false},"body":"Implements #2659.\r\n\r\nThis slightly improves the upgrade story by removing the restriction that method names and method parameter type names cannot be changed without breaking existing clients/silos.\r\n\r\nUsers can add the `[MethodId(x)]` attribute to methods to override the default algorithm for generating ids.","created_at":"2017-01-31T04:12:47Z","updated_at":"2017-01-31T22:56:39Z","closed_at":"2017-01-31T22:38:42Z","merged_at":"2017-01-31T22:38:42Z","merge_commit_sha":"6ae6b1e4db978efc7d855888325e63a7fac2d7c7","assignee":{"login":"benjaminpetit","id":20427417,"avatar_url":"https://avatars.githubusercontent.com/u/20427417?v=3","gravatar_id":"","url":"https://api.github.com/users/benjaminpetit","html_url":"https://github.com/benjaminpetit","followers_url":"https://api.github.com/users/benjaminpetit/followers","following_url":"https://api.github.com/users/benjaminpetit/following{/other_user}","gists_url":"https://api.github.com/users/benjaminpetit/gists{/gist_id}","starred_url":"https://api.github.com/users/benjaminpetit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjaminpetit/subscriptions","organizations_url":"https://api.github.com/users/benjaminpetit/orgs","repos_url":"https://api.github.com/users/benjaminpetit/repos","events_url":"https://api.github.com/users/benjaminpetit/events{/privacy}","received_events_url":"https://api.github.com/users/benjaminpetit/received_events","type":"User","site_admin":false},"assignees":[{"login":"benjaminpetit","id":20427417,"avatar_url":"https://avatars.githubusercontent.com/u/20427417?v=3","gravatar_id":"","url":"https://api.github.com/users/benjaminpetit","html_url":"https://github.com/benjaminpetit","followers_url":"https://api.github.com/users/benjaminpetit/followers","following_url":"https://api.github.com/users/benjaminpetit/following{/other_user}","gists_url":"https://api.github.com/users/benjaminpetit/gists{/gist_id}","starred_url":"https://api.github.com/users/benjaminpetit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjaminpetit/subscriptions","organizations_url":"https://api.github.com/users/benjaminpetit/orgs","repos_url":"https://api.github.com/users/benjaminpetit/repos","events_url":"https://api.github.com/users/benjaminpetit/events{/privacy}","received_events_url":"https://api.github.com/users/benjaminpetit/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/dotnet/orleans/milestones/18","html_url":"https://github.com/dotnet/orleans/milestone/18","labels_url":"https://api.github.com/repos/dotnet/orleans/milestones/18/labels","id":2247963,"number":18,"title":"1.5.0","description":"","creator":{"login":"sergeybykov","id":8248806,"avatar_url":"https://avatars.githubusercontent.com/u/8248806?v=3","gravatar_id":"","url":"https://api.github.com/users/sergeybykov","html_url":"https://github.com/sergeybykov","followers_url":"https://api.github.com/users/sergeybykov/followers","following_url":"https://api.github.com/users/sergeybykov/following{/other_user}","gists_url":"https://api.github.com/users/sergeybykov/gists{/gist_id}","starred_url":"https://api.github.com/users/sergeybykov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergeybykov/subscriptions","organizations_url":"https://api.github.com/users/sergeybykov/orgs","repos_url":"https://api.github.com/users/sergeybykov/repos","events_url":"https://api.github.com/users/sergeybykov/events{/privacy}","received_events_url":"https://api.github.com/users/sergeybykov/received_events","type":"User","site_admin":false},"open_issues":24,"closed_issues":8,"state":"open","created_at":"2017-01-12T16:44:03Z","updated_at":"2017-01-31T22:38:42Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/dotnet/orleans/pulls/2660/commits","review_comments_url":"https://api.github.com/repos/dotnet/orleans/pulls/2660/comments","review_comment_url":"https://api.github.com/repos/dotnet/orleans/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/orleans/issues/2660/comments","statuses_url":"https://api.github.com/repos/dotnet/orleans/statuses/a2117334e9e66f33c500586e4566c72572c1e363","head":{"label":"ReubenBond:feature-upgrades","ref":"feature-upgrades","sha":"a2117334e9e66f33c500586e4566c72572c1e363","user":{"login":"ReubenBond","id":203839,"avatar_url":"https://avatars.githubusercontent.com/u/203839?v=3","gravatar_id":"","url":"https://api.github.com/users/ReubenBond","html_url":"https://github.com/ReubenBond","followers_url":"https://api.github.com/users/ReubenBond/followers","following_url":"https://api.github.com/users/ReubenBond/following{/other_user}","gists_url":"https://api.github.com/users/ReubenBond/gists{/gist_id}","starred_url":"https://api.github.com/users/ReubenBond/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReubenBond/subscriptions","organizations_url":"https://api.github.com/users/ReubenBond/orgs","repos_url":"https://api.github.com/users/ReubenBond/repos","events_url":"https://api.github.com/users/ReubenBond/events{/privacy}","received_events_url":"https://api.github.com/users/ReubenBond/received_events","type":"User","site_admin":false},"repo":{"id":30130910,"name":"orleans","full_name":"ReubenBond/orleans","owner":{"login":"ReubenBond","id":203839,"avatar_url":"https://avatars.githubusercontent.com/u/203839?v=3","gravatar_id":"","url":"https://api.github.com/users/ReubenBond","html_url":"https://github.com/ReubenBond","followers_url":"https://api.github.com/users/ReubenBond/followers","following_url":"https://api.github.com/users/ReubenBond/following{/other_user}","gists_url":"https://api.github.com/users/ReubenBond/gists{/gist_id}","starred_url":"https://api.github.com/users/ReubenBond/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReubenBond/subscriptions","organizations_url":"https://api.github.com/users/ReubenBond/orgs","repos_url":"https://api.github.com/users/ReubenBond/repos","events_url":"https://api.github.com/users/ReubenBond/events{/privacy}","received_events_url":"https://api.github.com/users/ReubenBond/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ReubenBond/orleans","description":"Repo for Orleans - Distributed Actor Model","fork":true,"url":"https://api.github.com/repos/ReubenBond/orleans","forks_url":"https://api.github.com/repos/ReubenBond/orleans/forks","keys_url":"https://api.github.com/repos/ReubenBond/orleans/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ReubenBond/orleans/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ReubenBond/orleans/teams","hooks_url":"https://api.github.com/repos/ReubenBond/orleans/hooks","issue_events_url":"https://api.github.com/repos/ReubenBond/orleans/issues/events{/number}","events_url":"https://api.github.com/repos/ReubenBond/orleans/events","assignees_url":"https://api.github.com/repos/ReubenBond/orleans/assignees{/user}","branches_url":"https://api.github.com/repos/ReubenBond/orleans/branches{/branch}","tags_url":"https://api.github.com/repos/ReubenBond/orleans/tags","blobs_url":"https://api.github.com/repos/ReubenBond/orleans/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ReubenBond/orleans/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ReubenBond/orleans/git/refs{/sha}","trees_url":"https://api.github.com/repos/ReubenBond/orleans/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ReubenBond/orleans/statuses/{sha}","languages_url":"https://api.github.com/repos/ReubenBond/orleans/languages","stargazers_url":"https://api.github.com/repos/ReubenBond/orleans/stargazers","contributors_url":"https://api.github.com/repos/ReubenBond/orleans/contributors","subscribers_url":"https://api.github.com/repos/ReubenBond/orleans/subscribers","subscription_url":"https://api.github.com/repos/ReubenBond/orleans/subscription","commits_url":"https://api.github.com/repos/ReubenBond/orleans/commits{/sha}","git_commits_url":"https://api.github.com/repos/ReubenBond/orleans/git/commits{/sha}","comments_url":"https://api.github.com/repos/ReubenBond/orleans/comments{/number}","issue_comment_url":"https://api.github.com/repos/ReubenBond/orleans/issues/comments{/number}","contents_url":"https://api.github.com/repos/ReubenBond/orleans/contents/{+path}","compare_url":"https://api.github.com/repos/ReubenBond/orleans/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ReubenBond/orleans/merges","archive_url":"https://api.github.com/repos/ReubenBond/orleans/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ReubenBond/orleans/downloads","issues_url":"https://api.github.com/repos/ReubenBond/orleans/issues{/number}","pulls_url":"https://api.github.com/repos/ReubenBond/orleans/pulls{/number}","milestones_url":"https://api.github.com/repos/ReubenBond/orleans/milestones{/number}","notifications_url":"https://api.github.com/repos/ReubenBond/orleans/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ReubenBond/orleans/labels{/name}","releases_url":"https://api.github.com/repos/ReubenBond/orleans/releases{/id}","deployments_url":"https://api.github.com/repos/ReubenBond/orleans/deployments","created_at":"2015-02-01T00:06:08Z","updated_at":"2016-10-31T01:45:02Z","pushed_at":"2017-01-31T04:10:38Z","git_url":"git://github.com/ReubenBond/orleans.git","ssh_url":"git@github.com:ReubenBond/orleans.git","clone_url":"https://github.com/ReubenBond/orleans.git","svn_url":"https://github.com/ReubenBond/orleans","homepage":"","size":34546,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"99a94a1d0aac298fe54084b0f8bab3f1158b01c0","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":28232663,"name":"orleans","full_name":"dotnet/orleans","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/orleans","description":"Orleans - Distributed Virtual Actor Model","fork":false,"url":"https://api.github.com/repos/dotnet/orleans","forks_url":"https://api.github.com/repos/dotnet/orleans/forks","keys_url":"https://api.github.com/repos/dotnet/orleans/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/orleans/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/orleans/teams","hooks_url":"https://api.github.com/repos/dotnet/orleans/hooks","issue_events_url":"https://api.github.com/repos/dotnet/orleans/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/orleans/events","assignees_url":"https://api.github.com/repos/dotnet/orleans/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/orleans/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/orleans/tags","blobs_url":"https://api.github.com/repos/dotnet/orleans/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/orleans/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/orleans/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/orleans/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/orleans/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/orleans/languages","stargazers_url":"https://api.github.com/repos/dotnet/orleans/stargazers","contributors_url":"https://api.github.com/repos/dotnet/orleans/contributors","subscribers_url":"https://api.github.com/repos/dotnet/orleans/subscribers","subscription_url":"https://api.github.com/repos/dotnet/orleans/subscription","commits_url":"https://api.github.com/repos/dotnet/orleans/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/orleans/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/orleans/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/orleans/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/orleans/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/orleans/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/orleans/merges","archive_url":"https://api.github.com/repos/dotnet/orleans/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/orleans/downloads","issues_url":"https://api.github.com/repos/dotnet/orleans/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/orleans/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/orleans/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/orleans/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/orleans/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/orleans/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/orleans/deployments","created_at":"2014-12-19T14:32:50Z","updated_at":"2017-01-31T08:49:54Z","pushed_at":"2017-01-31T22:38:42Z","git_url":"git://github.com/dotnet/orleans.git","ssh_url":"git@github.com:dotnet/orleans.git","clone_url":"https://github.com/dotnet/orleans.git","svn_url":"https://github.com/dotnet/orleans","homepage":"http://dotnet.github.io/orleans","size":34332,"stargazers_count":2514,"watchers_count":2514,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":626,"mirror_url":null,"open_issues_count":242,"forks":626,"open_issues":242,"watchers":2514,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/orleans/pulls/2660"},"html":{"href":"https://github.com/dotnet/orleans/pull/2660"},"issue":{"href":"https://api.github.com/repos/dotnet/orleans/issues/2660"},"comments":{"href":"https://api.github.com/repos/dotnet/orleans/issues/2660/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/orleans/pulls/2660/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/orleans/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/orleans/pulls/2660/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/orleans/statuses/a2117334e9e66f33c500586e4566c72572c1e363"}}}}
{"actor":{"display_login":"ReubenBond"}}