{"action":"created","issue":{"url":"https://api.github.com/repos/BriteSnow/snow/issues/53","repository_url":"https://api.github.com/repos/BriteSnow/snow","labels_url":"https://api.github.com/repos/BriteSnow/snow/issues/53/labels{/name}","comments_url":"https://api.github.com/repos/BriteSnow/snow/issues/53/comments","events_url":"https://api.github.com/repos/BriteSnow/snow/issues/53/events","html_url":"https://github.com/BriteSnow/snow/issues/53","id":256604292,"number":53,"title":"Servlet filters support ?","user":{"login":"MorganMaison","id":1718074,"avatar_url":"https://avatars0.githubusercontent.com/u/1718074?v=4","gravatar_id":"","url":"https://api.github.com/users/MorganMaison","html_url":"https://github.com/MorganMaison","followers_url":"https://api.github.com/users/MorganMaison/followers","following_url":"https://api.github.com/users/MorganMaison/following{/other_user}","gists_url":"https://api.github.com/users/MorganMaison/gists{/gist_id}","starred_url":"https://api.github.com/users/MorganMaison/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MorganMaison/subscriptions","organizations_url":"https://api.github.com/users/MorganMaison/orgs","repos_url":"https://api.github.com/users/MorganMaison/repos","events_url":"https://api.github.com/users/MorganMaison/events{/privacy}","received_events_url":"https://api.github.com/users/MorganMaison/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"MorganMaison","id":1718074,"avatar_url":"https://avatars0.githubusercontent.com/u/1718074?v=4","gravatar_id":"","url":"https://api.github.com/users/MorganMaison","html_url":"https://github.com/MorganMaison","followers_url":"https://api.github.com/users/MorganMaison/followers","following_url":"https://api.github.com/users/MorganMaison/following{/other_user}","gists_url":"https://api.github.com/users/MorganMaison/gists{/gist_id}","starred_url":"https://api.github.com/users/MorganMaison/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MorganMaison/subscriptions","organizations_url":"https://api.github.com/users/MorganMaison/orgs","repos_url":"https://api.github.com/users/MorganMaison/repos","events_url":"https://api.github.com/users/MorganMaison/events{/privacy}","received_events_url":"https://api.github.com/users/MorganMaison/received_events","type":"User","site_admin":false},"assignees":[{"login":"MorganMaison","id":1718074,"avatar_url":"https://avatars0.githubusercontent.com/u/1718074?v=4","gravatar_id":"","url":"https://api.github.com/users/MorganMaison","html_url":"https://github.com/MorganMaison","followers_url":"https://api.github.com/users/MorganMaison/followers","following_url":"https://api.github.com/users/MorganMaison/following{/other_user}","gists_url":"https://api.github.com/users/MorganMaison/gists{/gist_id}","starred_url":"https://api.github.com/users/MorganMaison/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MorganMaison/subscriptions","organizations_url":"https://api.github.com/users/MorganMaison/orgs","repos_url":"https://api.github.com/users/MorganMaison/repos","events_url":"https://api.github.com/users/MorganMaison/events{/privacy}","received_events_url":"https://api.github.com/users/MorganMaison/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2017-09-11T07:19:27Z","updated_at":"2017-09-12T16:14:23Z","closed_at":"2017-09-12T16:14:23Z","author_association":"NONE","body":"I may be wrong here but for what I see in your demo, the idea for Snow is to have a generic web.xml and to handle everything down the line with Snow. I'm not saying it is a bad thing _per se_ but it could be quite a burden to be unable to plug 3rd party libs acting as servlet filters.\r\n\r\nIn our case (JWT auth) I would have to use the snow AppAuthRequest to generate the token, instead of simply plugging our usual lib as a filter in the web.xml.\r\n\r\nMore broadly I would say that it’s a fairly common thing to have 3rd party librairies plugging themselves at the servlet entry point level. Is there a way to “bind” a servlet filter class with Snow ?\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/BriteSnow/snow/issues/comments/328903492","html_url":"https://github.com/BriteSnow/snow/issues/53#issuecomment-328903492","issue_url":"https://api.github.com/repos/BriteSnow/snow/issues/53","id":328903492,"user":{"login":"MorganMaison","id":1718074,"avatar_url":"https://avatars0.githubusercontent.com/u/1718074?v=4","gravatar_id":"","url":"https://api.github.com/users/MorganMaison","html_url":"https://github.com/MorganMaison","followers_url":"https://api.github.com/users/MorganMaison/followers","following_url":"https://api.github.com/users/MorganMaison/following{/other_user}","gists_url":"https://api.github.com/users/MorganMaison/gists{/gist_id}","starred_url":"https://api.github.com/users/MorganMaison/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MorganMaison/subscriptions","organizations_url":"https://api.github.com/users/MorganMaison/orgs","repos_url":"https://api.github.com/users/MorganMaison/repos","events_url":"https://api.github.com/users/MorganMaison/events{/privacy}","received_events_url":"https://api.github.com/users/MorganMaison/received_events","type":"User","site_admin":false},"created_at":"2017-09-12T16:14:23Z","updated_at":"2017-09-12T16:14:23Z","author_association":"NONE","body":"@jeremychone You are right, servlet filter are working out of the box. \r\n\r\nI was too quick to blame it on the framework when it didn't work. We were loosing the request informations and I thought that it was because of something going wrong with the way Snow generates its RequestContext from the ServletRequest. It turns out it was due to a conflict between our version of Jackson and the one provided by our 3rd party filter lib. \r\n\r\nSorry about that."}}
{"actor":{"display_login":"MorganMaison"}}