{"action":"created","comment":{"url":"https://api.github.com/repos/piwik/piwik-dotnet-tracker/pulls/comments/96145926","pull_request_review_id":16721781,"id":96145926,"diff_hunk":"@@ -406,8 +406,9 @@ public CustomVar GetCustomVariable(int id, CustomVar.Scopes scope = CustomVar.Sc\n             }\r\n             else if (!scope.Equals(CustomVar.Scopes.Visit))\r\n             {\r\n-                throw new Exception(\"Invalid 'scope' parameter value\");\r\n+                throw new ArgumentException(\"Invalid 'scope' parameter value\", nameof(scope));\r\n             }\r\n+            // todo: unreachable code, this will newer be called since we return before!\r","path":"Piwik.Tracker/PiwikTracker.cs","position":null,"original_position":16,"commit_id":"1e2b6b5ee05c55924944bcd89ce2910bd98b0b8e","original_commit_id":"03d7a431539c628e21f314ea03ffc87aa5f86030","user":{"login":"julienmoumne","id":723165,"avatar_url":"https://avatars.githubusercontent.com/u/723165?v=3","gravatar_id":"","url":"https://api.github.com/users/julienmoumne","html_url":"https://github.com/julienmoumne","followers_url":"https://api.github.com/users/julienmoumne/followers","following_url":"https://api.github.com/users/julienmoumne/following{/other_user}","gists_url":"https://api.github.com/users/julienmoumne/gists{/gist_id}","starred_url":"https://api.github.com/users/julienmoumne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julienmoumne/subscriptions","organizations_url":"https://api.github.com/users/julienmoumne/orgs","repos_url":"https://api.github.com/users/julienmoumne/repos","events_url":"https://api.github.com/users/julienmoumne/events{/privacy}","received_events_url":"https://api.github.com/users/julienmoumne/received_events","type":"User","site_admin":false},"body":"I agree","created_at":"2017-01-15T19:46:33Z","updated_at":"2017-01-15T19:46:33Z","html_url":"https://github.com/piwik/piwik-dotnet-tracker/pull/36#discussion_r96145926","pull_request_url":"https://api.github.com/repos/piwik/piwik-dotnet-tracker/pulls/36","_links":{"self":{"href":"https://api.github.com/repos/piwik/piwik-dotnet-tracker/pulls/comments/96145926"},"html":{"href":"https://github.com/piwik/piwik-dotnet-tracker/pull/36#discussion_r96145926"},"pull_request":{"href":"https://api.github.com/repos/piwik/piwik-dotnet-tracker/pulls/36"}}},"pull_request":{"url":"https://api.github.com/repos/piwik/piwik-dotnet-tracker/pulls/36","id":101592664,"html_url":"https://github.com/piwik/piwik-dotnet-tracker/pull/36","diff_url":"https://github.com/piwik/piwik-dotnet-tracker/pull/36.diff","patch_url":"https://github.com/piwik/piwik-dotnet-tracker/pull/36.patch","issue_url":"https://api.github.com/repos/piwik/piwik-dotnet-tracker/issues/36","number":36,"state":"open","locked":false,"title":"Applied C# coding style","user":{"login":"ptr1120","id":582627,"avatar_url":"https://avatars.githubusercontent.com/u/582627?v=3","gravatar_id":"","url":"https://api.github.com/users/ptr1120","html_url":"https://github.com/ptr1120","followers_url":"https://api.github.com/users/ptr1120/followers","following_url":"https://api.github.com/users/ptr1120/following{/other_user}","gists_url":"https://api.github.com/users/ptr1120/gists{/gist_id}","starred_url":"https://api.github.com/users/ptr1120/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ptr1120/subscriptions","organizations_url":"https://api.github.com/users/ptr1120/orgs","repos_url":"https://api.github.com/users/ptr1120/repos","events_url":"https://api.github.com/users/ptr1120/events{/privacy}","received_events_url":"https://api.github.com/users/ptr1120/received_events","type":"User","site_admin":false},"body":"As discussed in #29, #33, applied C# coding style as described in \r\n[C# Coding style](https://github.com/dotnet/corefx/blob/master/Documentation/coding-guidelines/coding-style.md).\r\n\r\nSome thoughts / information:\r\n* I tried to apply changes as atomar and understandable as possible thats why there are as many commits.\r\n* I think we should stay as close as possible to the Piwik php / js Api (naming and semantic of methods) instead of reinventing the wheel. Therefore I did not introduce many autoproperties for getters / setters. \r\n@julienmoumne: Do you see any further Api Changes? (Maybe remove some public methods or rename them to the  corresponding other clients)\r\n* which Api version of Piwik server do we support? Are there any changes in the newly introduced Piwik server Api version 3.0 (see also: http://developer.piwik.org/api-reference/tracking-api)\r\n* I found some minor issues while refactoring (tagged with \"todo\" @julienmoumne can you have a look on them?\r\n","created_at":"2017-01-15T11:28:48Z","updated_at":"2017-01-15T19:46:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c6f5a7e8fa285bec16284c8971b3b82e279038fd","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/piwik/piwik-dotnet-tracker/pulls/36/commits","review_comments_url":"https://api.github.com/repos/piwik/piwik-dotnet-tracker/pulls/36/comments","review_comment_url":"https://api.github.com/repos/piwik/piwik-dotnet-tracker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/piwik/piwik-dotnet-tracker/issues/36/comments","statuses_url":"https://api.github.com/repos/piwik/piwik-dotnet-tracker/statuses/1e2b6b5ee05c55924944bcd89ce2910bd98b0b8e","head":{"label":"ptr1120:master","ref":"master","sha":"1e2b6b5ee05c55924944bcd89ce2910bd98b0b8e","user":{"login":"ptr1120","id":582627,"avatar_url":"https://avatars.githubusercontent.com/u/582627?v=3","gravatar_id":"","url":"https://api.github.com/users/ptr1120","html_url":"https://github.com/ptr1120","followers_url":"https://api.github.com/users/ptr1120/followers","following_url":"https://api.github.com/users/ptr1120/following{/other_user}","gists_url":"https://api.github.com/users/ptr1120/gists{/gist_id}","starred_url":"https://api.github.com/users/ptr1120/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ptr1120/subscriptions","organizations_url":"https://api.github.com/users/ptr1120/orgs","repos_url":"https://api.github.com/users/ptr1120/repos","events_url":"https://api.github.com/users/ptr1120/events{/privacy}","received_events_url":"https://api.github.com/users/ptr1120/received_events","type":"User","site_admin":false},"repo":{"id":79025529,"name":"piwik-dotnet-tracker","full_name":"ptr1120/piwik-dotnet-tracker","owner":{"login":"ptr1120","id":582627,"avatar_url":"https://avatars.githubusercontent.com/u/582627?v=3","gravatar_id":"","url":"https://api.github.com/users/ptr1120","html_url":"https://github.com/ptr1120","followers_url":"https://api.github.com/users/ptr1120/followers","following_url":"https://api.github.com/users/ptr1120/following{/other_user}","gists_url":"https://api.github.com/users/ptr1120/gists{/gist_id}","starred_url":"https://api.github.com/users/ptr1120/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ptr1120/subscriptions","organizations_url":"https://api.github.com/users/ptr1120/orgs","repos_url":"https://api.github.com/users/ptr1120/repos","events_url":"https://api.github.com/users/ptr1120/events{/privacy}","received_events_url":"https://api.github.com/users/ptr1120/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ptr1120/piwik-dotnet-tracker","description":"C# API client SDK for the Piwik Tracking API","fork":true,"url":"https://api.github.com/repos/ptr1120/piwik-dotnet-tracker","forks_url":"https://api.github.com/repos/ptr1120/piwik-dotnet-tracker/forks","keys_url":"https://api.github.com/repos/ptr1120/piwik-dotnet-tracker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ptr1120/piwik-dotnet-tracker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ptr1120/piwik-dotnet-tracker/teams","hooks_url":"https://api.github.com/repos/ptr1120/piwik-dotnet-tracker/hooks","issue_events_url":"https://api.github.com/repos/ptr1120/piwik-dotnet-tracker/issues/events{/number}","events_url":"https://api.github.com/repos/ptr1120/piwik-dotnet-tracker/events","assignees_url":"https://api.github.com/repos/ptr1120/piwik-dotnet-tracker/assignees{/user}","branches_url":"https://api.github.com/repos/ptr1120/piwik-dotnet-tracker/branches{/branch}","tags_url":"https://api.github.com/repos/ptr1120/piwik-dotnet-tracker/tags","blobs_url":"https://api.github.com/repos/ptr1120/piwik-dotnet-tracker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ptr1120/piwik-dotnet-tracker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ptr1120/piwik-dotnet-tracker/git/refs{/sha}","trees_url":"https://api.github.com/repos/ptr1120/piwik-dotnet-tracker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ptr1120/piwik-dotnet-tracker/statuses/{sha}","languages_url":"https://api.github.com/repos/ptr1120/piwik-dotnet-tracker/languages","stargazers_url":"https://api.github.com/repos/ptr1120/piwik-dotnet-tracker/stargazers","contributors_url":"https://api.github.com/repos/ptr1120/piwik-dotnet-tracker/contributors","subscribers_url":"https://api.github.com/repos/ptr1120/piwik-dotnet-tracker/subscribers","subscription_url":"https://api.github.com/repos/ptr1120/piwik-dotnet-tracker/subscription","commits_url":"https://api.github.com/repos/ptr1120/piwik-dotnet-tracker/commits{/sha}","git_commits_url":"https://api.github.com/repos/ptr1120/piwik-dotnet-tracker/git/commits{/sha}","comments_url":"https://api.github.com/repos/ptr1120/piwik-dotnet-tracker/comments{/number}","issue_comment_url":"https://api.github.com/repos/ptr1120/piwik-dotnet-tracker/issues/comments{/number}","contents_url":"https://api.github.com/repos/ptr1120/piwik-dotnet-tracker/contents/{+path}","compare_url":"https://api.github.com/repos/ptr1120/piwik-dotnet-tracker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ptr1120/piwik-dotnet-tracker/merges","archive_url":"https://api.github.com/repos/ptr1120/piwik-dotnet-tracker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ptr1120/piwik-dotnet-tracker/downloads","issues_url":"https://api.github.com/repos/ptr1120/piwik-dotnet-tracker/issues{/number}","pulls_url":"https://api.github.com/repos/ptr1120/piwik-dotnet-tracker/pulls{/number}","milestones_url":"https://api.github.com/repos/ptr1120/piwik-dotnet-tracker/milestones{/number}","notifications_url":"https://api.github.com/repos/ptr1120/piwik-dotnet-tracker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ptr1120/piwik-dotnet-tracker/labels{/name}","releases_url":"https://api.github.com/repos/ptr1120/piwik-dotnet-tracker/releases{/id}","deployments_url":"https://api.github.com/repos/ptr1120/piwik-dotnet-tracker/deployments","created_at":"2017-01-15T10:42:16Z","updated_at":"2017-01-15T10:42:19Z","pushed_at":"2017-01-15T11:15:36Z","git_url":"git://github.com/ptr1120/piwik-dotnet-tracker.git","ssh_url":"git@github.com:ptr1120/piwik-dotnet-tracker.git","clone_url":"https://github.com/ptr1120/piwik-dotnet-tracker.git","svn_url":"https://github.com/ptr1120/piwik-dotnet-tracker","homepage":"","size":716,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"piwik:master","ref":"master","sha":"4f0742948b8fb63edb01af55cc8a1236eb8ec189","user":{"login":"piwik","id":698038,"avatar_url":"https://avatars.githubusercontent.com/u/698038?v=3","gravatar_id":"","url":"https://api.github.com/users/piwik","html_url":"https://github.com/piwik","followers_url":"https://api.github.com/users/piwik/followers","following_url":"https://api.github.com/users/piwik/following{/other_user}","gists_url":"https://api.github.com/users/piwik/gists{/gist_id}","starred_url":"https://api.github.com/users/piwik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piwik/subscriptions","organizations_url":"https://api.github.com/users/piwik/orgs","repos_url":"https://api.github.com/users/piwik/repos","events_url":"https://api.github.com/users/piwik/events{/privacy}","received_events_url":"https://api.github.com/users/piwik/received_events","type":"Organization","site_admin":false},"repo":{"id":8464183,"name":"piwik-dotnet-tracker","full_name":"piwik/piwik-dotnet-tracker","owner":{"login":"piwik","id":698038,"avatar_url":"https://avatars.githubusercontent.com/u/698038?v=3","gravatar_id":"","url":"https://api.github.com/users/piwik","html_url":"https://github.com/piwik","followers_url":"https://api.github.com/users/piwik/followers","following_url":"https://api.github.com/users/piwik/following{/other_user}","gists_url":"https://api.github.com/users/piwik/gists{/gist_id}","starred_url":"https://api.github.com/users/piwik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piwik/subscriptions","organizations_url":"https://api.github.com/users/piwik/orgs","repos_url":"https://api.github.com/users/piwik/repos","events_url":"https://api.github.com/users/piwik/events{/privacy}","received_events_url":"https://api.github.com/users/piwik/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/piwik/piwik-dotnet-tracker","description":"C# API client SDK for the Piwik Tracking API","fork":false,"url":"https://api.github.com/repos/piwik/piwik-dotnet-tracker","forks_url":"https://api.github.com/repos/piwik/piwik-dotnet-tracker/forks","keys_url":"https://api.github.com/repos/piwik/piwik-dotnet-tracker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/piwik/piwik-dotnet-tracker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/piwik/piwik-dotnet-tracker/teams","hooks_url":"https://api.github.com/repos/piwik/piwik-dotnet-tracker/hooks","issue_events_url":"https://api.github.com/repos/piwik/piwik-dotnet-tracker/issues/events{/number}","events_url":"https://api.github.com/repos/piwik/piwik-dotnet-tracker/events","assignees_url":"https://api.github.com/repos/piwik/piwik-dotnet-tracker/assignees{/user}","branches_url":"https://api.github.com/repos/piwik/piwik-dotnet-tracker/branches{/branch}","tags_url":"https://api.github.com/repos/piwik/piwik-dotnet-tracker/tags","blobs_url":"https://api.github.com/repos/piwik/piwik-dotnet-tracker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/piwik/piwik-dotnet-tracker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/piwik/piwik-dotnet-tracker/git/refs{/sha}","trees_url":"https://api.github.com/repos/piwik/piwik-dotnet-tracker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/piwik/piwik-dotnet-tracker/statuses/{sha}","languages_url":"https://api.github.com/repos/piwik/piwik-dotnet-tracker/languages","stargazers_url":"https://api.github.com/repos/piwik/piwik-dotnet-tracker/stargazers","contributors_url":"https://api.github.com/repos/piwik/piwik-dotnet-tracker/contributors","subscribers_url":"https://api.github.com/repos/piwik/piwik-dotnet-tracker/subscribers","subscription_url":"https://api.github.com/repos/piwik/piwik-dotnet-tracker/subscription","commits_url":"https://api.github.com/repos/piwik/piwik-dotnet-tracker/commits{/sha}","git_commits_url":"https://api.github.com/repos/piwik/piwik-dotnet-tracker/git/commits{/sha}","comments_url":"https://api.github.com/repos/piwik/piwik-dotnet-tracker/comments{/number}","issue_comment_url":"https://api.github.com/repos/piwik/piwik-dotnet-tracker/issues/comments{/number}","contents_url":"https://api.github.com/repos/piwik/piwik-dotnet-tracker/contents/{+path}","compare_url":"https://api.github.com/repos/piwik/piwik-dotnet-tracker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/piwik/piwik-dotnet-tracker/merges","archive_url":"https://api.github.com/repos/piwik/piwik-dotnet-tracker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/piwik/piwik-dotnet-tracker/downloads","issues_url":"https://api.github.com/repos/piwik/piwik-dotnet-tracker/issues{/number}","pulls_url":"https://api.github.com/repos/piwik/piwik-dotnet-tracker/pulls{/number}","milestones_url":"https://api.github.com/repos/piwik/piwik-dotnet-tracker/milestones{/number}","notifications_url":"https://api.github.com/repos/piwik/piwik-dotnet-tracker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/piwik/piwik-dotnet-tracker/labels{/name}","releases_url":"https://api.github.com/repos/piwik/piwik-dotnet-tracker/releases{/id}","deployments_url":"https://api.github.com/repos/piwik/piwik-dotnet-tracker/deployments","created_at":"2013-02-27T20:02:53Z","updated_at":"2017-01-15T12:51:08Z","pushed_at":"2017-01-15T11:28:49Z","git_url":"git://github.com/piwik/piwik-dotnet-tracker.git","ssh_url":"git@github.com:piwik/piwik-dotnet-tracker.git","clone_url":"https://github.com/piwik/piwik-dotnet-tracker.git","svn_url":"https://github.com/piwik/piwik-dotnet-tracker","homepage":"","size":685,"stargazers_count":33,"watchers_count":33,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":14,"forks":23,"open_issues":14,"watchers":33,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/piwik/piwik-dotnet-tracker/pulls/36"},"html":{"href":"https://github.com/piwik/piwik-dotnet-tracker/pull/36"},"issue":{"href":"https://api.github.com/repos/piwik/piwik-dotnet-tracker/issues/36"},"comments":{"href":"https://api.github.com/repos/piwik/piwik-dotnet-tracker/issues/36/comments"},"review_comments":{"href":"https://api.github.com/repos/piwik/piwik-dotnet-tracker/pulls/36/comments"},"review_comment":{"href":"https://api.github.com/repos/piwik/piwik-dotnet-tracker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/piwik/piwik-dotnet-tracker/pulls/36/commits"},"statuses":{"href":"https://api.github.com/repos/piwik/piwik-dotnet-tracker/statuses/1e2b6b5ee05c55924944bcd89ce2910bd98b0b8e"}}}}
{"actor":{"display_login":"julienmoumne"}}