{"action":"created","issue":{"url":"https://api.github.com/repos/grosser/parallel_tests/issues/562","repository_url":"https://api.github.com/repos/grosser/parallel_tests","labels_url":"https://api.github.com/repos/grosser/parallel_tests/issues/562/labels{/name}","comments_url":"https://api.github.com/repos/grosser/parallel_tests/issues/562/comments","events_url":"https://api.github.com/repos/grosser/parallel_tests/issues/562/events","html_url":"https://github.com/grosser/parallel_tests/pull/562","id":213720212,"number":562,"title":"Remove RSpec 1 compatibility","user":{"login":"bquorning","id":22333,"avatar_url":"https://avatars1.githubusercontent.com/u/22333?v=3","gravatar_id":"","url":"https://api.github.com/users/bquorning","html_url":"https://github.com/bquorning","followers_url":"https://api.github.com/users/bquorning/followers","following_url":"https://api.github.com/users/bquorning/following{/other_user}","gists_url":"https://api.github.com/users/bquorning/gists{/gist_id}","starred_url":"https://api.github.com/users/bquorning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bquorning/subscriptions","organizations_url":"https://api.github.com/users/bquorning/orgs","repos_url":"https://api.github.com/users/bquorning/repos","events_url":"https://api.github.com/users/bquorning/events{/privacy}","received_events_url":"https://api.github.com/users/bquorning/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-03-13T10:01:41Z","updated_at":"2017-03-13T14:48:43Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/grosser/parallel_tests/pulls/562","html_url":"https://github.com/grosser/parallel_tests/pull/562","diff_url":"https://github.com/grosser/parallel_tests/pull/562.diff","patch_url":"https://github.com/grosser/parallel_tests/pull/562.patch"},"body":"I’m not sure how many people still use RSpec 1, but I’m pretty sure the number is low enough to warrant this code cleanup. The idea was discussed already 5 years ago, in #98.\r\n\r\n@grosser, I’m running into an issue with the runner that used to check the `version` based on the name of the executable; if the executable doesn’t contain the word `rspec`, we think (thought) it was RSpec v1. When running the runner_spec.rb there are some tests that set\r\n```\r\nallow(File).to receive(:file?).with('script/spec').and_return true\r\n```\r\neven one that claims to test RSpec 2 behavior: https://github.com/grosser/parallel_tests/blob/b6a2ecec90a7c370d49ee6a10f3b3d747604d61d/spec/parallel_tests/rspec/runner_spec.rb#L68-L69"},"comment":{"url":"https://api.github.com/repos/grosser/parallel_tests/issues/comments/286129565","html_url":"https://github.com/grosser/parallel_tests/pull/562#issuecomment-286129565","issue_url":"https://api.github.com/repos/grosser/parallel_tests/issues/562","id":286129565,"user":{"login":"grosser","id":11367,"avatar_url":"https://avatars0.githubusercontent.com/u/11367?v=3","gravatar_id":"","url":"https://api.github.com/users/grosser","html_url":"https://github.com/grosser","followers_url":"https://api.github.com/users/grosser/followers","following_url":"https://api.github.com/users/grosser/following{/other_user}","gists_url":"https://api.github.com/users/grosser/gists{/gist_id}","starred_url":"https://api.github.com/users/grosser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grosser/subscriptions","organizations_url":"https://api.github.com/users/grosser/orgs","repos_url":"https://api.github.com/users/grosser/repos","events_url":"https://api.github.com/users/grosser/events{/privacy}","received_events_url":"https://api.github.com/users/grosser/received_events","type":"User","site_admin":false},"created_at":"2017-03-13T14:48:43Z","updated_at":"2017-03-13T14:48:43Z","body":"just drop support for ti too ?"}}
{"actor":{"display_login":"grosser"}}