{"action":"closed","number":137,"pull_request":{"url":"https://api.github.com/repos/meetfranz/franz/pulls/137","id":148961096,"html_url":"https://github.com/meetfranz/franz/pull/137","diff_url":"https://github.com/meetfranz/franz/pull/137.diff","patch_url":"https://github.com/meetfranz/franz/pull/137.patch","issue_url":"https://api.github.com/repos/meetfranz/franz/issues/137","number":137,"state":"closed","locked":false,"title":"Bugfix: When reordering make sure the new indexes are applied correctly","user":{"login":"GustavoKatel","id":1891977,"avatar_url":"https://avatars1.githubusercontent.com/u/1891977?v=4","gravatar_id":"","url":"https://api.github.com/users/GustavoKatel","html_url":"https://github.com/GustavoKatel","followers_url":"https://api.github.com/users/GustavoKatel/followers","following_url":"https://api.github.com/users/GustavoKatel/following{/other_user}","gists_url":"https://api.github.com/users/GustavoKatel/gists{/gist_id}","starred_url":"https://api.github.com/users/GustavoKatel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GustavoKatel/subscriptions","organizations_url":"https://api.github.com/users/GustavoKatel/orgs","repos_url":"https://api.github.com/users/GustavoKatel/repos","events_url":"https://api.github.com/users/GustavoKatel/events{/privacy}","received_events_url":"https://api.github.com/users/GustavoKatel/received_events","type":"User","site_admin":false},"body":"<!--- Provide a general summary of your changes in the Title above -->\r\nPatching the cached allServicesRequest to update the order was using old indexes, instead of the new ones updated after the reorder event.\r\n\r\n### Description\r\n<!--- Describe your changes in detail -->\r\n\r\n### Motivation and Context\r\n<!--- Why is this change required? What problem does it solve? -->\r\n<!--- If it fixes an open issue, please link to the issue here. -->\r\nThis resolves #107\r\n\r\n### How Has This Been Tested?\r\n<!--- Please describe in detail how you tested your changes. -->\r\n<!--- Include details of your testing environment, tests ran to see how -->\r\n<!--- your change affects other areas of the code, etc. -->\r\nI could reproduce the bug using: \r\nOS: Linux Mint 18.1 (Ubuntu 16.04)\r\nBase branch: develop (0f8393b009e1de089a350d59ffed59b7dbb48863)\r\n\r\n### Screenshots (if appropriate):\r\n\r\n### Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [x] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)\r\n\r\n### Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] My code follows the code style of this project (run `$ yarn lint`).\r\n<!---- [ ] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly. -->\r\n","created_at":"2017-10-26T15:02:53Z","updated_at":"2017-10-27T09:57:41Z","closed_at":"2017-10-27T09:57:41Z","merged_at":"2017-10-27T09:57:41Z","merge_commit_sha":"58df280305162ba6fe76a6337a10008a2b0093a5","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/meetfranz/franz/pulls/137/commits","review_comments_url":"https://api.github.com/repos/meetfranz/franz/pulls/137/comments","review_comment_url":"https://api.github.com/repos/meetfranz/franz/pulls/comments{/number}","comments_url":"https://api.github.com/repos/meetfranz/franz/issues/137/comments","statuses_url":"https://api.github.com/repos/meetfranz/franz/statuses/dfe93917284bbe1c813a417491cf5a684afceb4c","head":{"label":"GustavoKatel:orderingJumpFix","ref":"orderingJumpFix","sha":"dfe93917284bbe1c813a417491cf5a684afceb4c","user":{"login":"GustavoKatel","id":1891977,"avatar_url":"https://avatars1.githubusercontent.com/u/1891977?v=4","gravatar_id":"","url":"https://api.github.com/users/GustavoKatel","html_url":"https://github.com/GustavoKatel","followers_url":"https://api.github.com/users/GustavoKatel/followers","following_url":"https://api.github.com/users/GustavoKatel/following{/other_user}","gists_url":"https://api.github.com/users/GustavoKatel/gists{/gist_id}","starred_url":"https://api.github.com/users/GustavoKatel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GustavoKatel/subscriptions","organizations_url":"https://api.github.com/users/GustavoKatel/orgs","repos_url":"https://api.github.com/users/GustavoKatel/repos","events_url":"https://api.github.com/users/GustavoKatel/events{/privacy}","received_events_url":"https://api.github.com/users/GustavoKatel/received_events","type":"User","site_admin":false},"repo":{"id":107206920,"name":"franz","full_name":"GustavoKatel/franz","owner":{"login":"GustavoKatel","id":1891977,"avatar_url":"https://avatars1.githubusercontent.com/u/1891977?v=4","gravatar_id":"","url":"https://api.github.com/users/GustavoKatel","html_url":"https://github.com/GustavoKatel","followers_url":"https://api.github.com/users/GustavoKatel/followers","following_url":"https://api.github.com/users/GustavoKatel/following{/other_user}","gists_url":"https://api.github.com/users/GustavoKatel/gists{/gist_id}","starred_url":"https://api.github.com/users/GustavoKatel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GustavoKatel/subscriptions","organizations_url":"https://api.github.com/users/GustavoKatel/orgs","repos_url":"https://api.github.com/users/GustavoKatel/repos","events_url":"https://api.github.com/users/GustavoKatel/events{/privacy}","received_events_url":"https://api.github.com/users/GustavoKatel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/GustavoKatel/franz","description":"Franz is a free messaging app for services like WhatsApp, Slack, Messenger and many more.","fork":true,"url":"https://api.github.com/repos/GustavoKatel/franz","forks_url":"https://api.github.com/repos/GustavoKatel/franz/forks","keys_url":"https://api.github.com/repos/GustavoKatel/franz/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GustavoKatel/franz/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GustavoKatel/franz/teams","hooks_url":"https://api.github.com/repos/GustavoKatel/franz/hooks","issue_events_url":"https://api.github.com/repos/GustavoKatel/franz/issues/events{/number}","events_url":"https://api.github.com/repos/GustavoKatel/franz/events","assignees_url":"https://api.github.com/repos/GustavoKatel/franz/assignees{/user}","branches_url":"https://api.github.com/repos/GustavoKatel/franz/branches{/branch}","tags_url":"https://api.github.com/repos/GustavoKatel/franz/tags","blobs_url":"https://api.github.com/repos/GustavoKatel/franz/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GustavoKatel/franz/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GustavoKatel/franz/git/refs{/sha}","trees_url":"https://api.github.com/repos/GustavoKatel/franz/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GustavoKatel/franz/statuses/{sha}","languages_url":"https://api.github.com/repos/GustavoKatel/franz/languages","stargazers_url":"https://api.github.com/repos/GustavoKatel/franz/stargazers","contributors_url":"https://api.github.com/repos/GustavoKatel/franz/contributors","subscribers_url":"https://api.github.com/repos/GustavoKatel/franz/subscribers","subscription_url":"https://api.github.com/repos/GustavoKatel/franz/subscription","commits_url":"https://api.github.com/repos/GustavoKatel/franz/commits{/sha}","git_commits_url":"https://api.github.com/repos/GustavoKatel/franz/git/commits{/sha}","comments_url":"https://api.github.com/repos/GustavoKatel/franz/comments{/number}","issue_comment_url":"https://api.github.com/repos/GustavoKatel/franz/issues/comments{/number}","contents_url":"https://api.github.com/repos/GustavoKatel/franz/contents/{+path}","compare_url":"https://api.github.com/repos/GustavoKatel/franz/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GustavoKatel/franz/merges","archive_url":"https://api.github.com/repos/GustavoKatel/franz/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GustavoKatel/franz/downloads","issues_url":"https://api.github.com/repos/GustavoKatel/franz/issues{/number}","pulls_url":"https://api.github.com/repos/GustavoKatel/franz/pulls{/number}","milestones_url":"https://api.github.com/repos/GustavoKatel/franz/milestones{/number}","notifications_url":"https://api.github.com/repos/GustavoKatel/franz/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GustavoKatel/franz/labels{/name}","releases_url":"https://api.github.com/repos/GustavoKatel/franz/releases{/id}","deployments_url":"https://api.github.com/repos/GustavoKatel/franz/deployments","created_at":"2017-10-17T02:19:30Z","updated_at":"2017-10-17T15:37:51Z","pushed_at":"2017-10-27T09:57:18Z","git_url":"git://github.com/GustavoKatel/franz.git","ssh_url":"git@github.com:GustavoKatel/franz.git","clone_url":"https://github.com/GustavoKatel/franz.git","svn_url":"https://github.com/GustavoKatel/franz","homepage":"http://meetfranz.com","size":3196,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"meetfranz:develop","ref":"develop","sha":"33ed2f82a04727e75610a8dfd07a66683502da8c","user":{"login":"meetfranz","id":21120259,"avatar_url":"https://avatars0.githubusercontent.com/u/21120259?v=4","gravatar_id":"","url":"https://api.github.com/users/meetfranz","html_url":"https://github.com/meetfranz","followers_url":"https://api.github.com/users/meetfranz/followers","following_url":"https://api.github.com/users/meetfranz/following{/other_user}","gists_url":"https://api.github.com/users/meetfranz/gists{/gist_id}","starred_url":"https://api.github.com/users/meetfranz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meetfranz/subscriptions","organizations_url":"https://api.github.com/users/meetfranz/orgs","repos_url":"https://api.github.com/users/meetfranz/repos","events_url":"https://api.github.com/users/meetfranz/events{/privacy}","received_events_url":"https://api.github.com/users/meetfranz/received_events","type":"Organization","site_admin":false},"repo":{"id":106809903,"name":"franz","full_name":"meetfranz/franz","owner":{"login":"meetfranz","id":21120259,"avatar_url":"https://avatars0.githubusercontent.com/u/21120259?v=4","gravatar_id":"","url":"https://api.github.com/users/meetfranz","html_url":"https://github.com/meetfranz","followers_url":"https://api.github.com/users/meetfranz/followers","following_url":"https://api.github.com/users/meetfranz/following{/other_user}","gists_url":"https://api.github.com/users/meetfranz/gists{/gist_id}","starred_url":"https://api.github.com/users/meetfranz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meetfranz/subscriptions","organizations_url":"https://api.github.com/users/meetfranz/orgs","repos_url":"https://api.github.com/users/meetfranz/repos","events_url":"https://api.github.com/users/meetfranz/events{/privacy}","received_events_url":"https://api.github.com/users/meetfranz/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/meetfranz/franz","description":"Franz is a free messaging app for services like WhatsApp, Slack, Messenger and many more.","fork":false,"url":"https://api.github.com/repos/meetfranz/franz","forks_url":"https://api.github.com/repos/meetfranz/franz/forks","keys_url":"https://api.github.com/repos/meetfranz/franz/keys{/key_id}","collaborators_url":"https://api.github.com/repos/meetfranz/franz/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/meetfranz/franz/teams","hooks_url":"https://api.github.com/repos/meetfranz/franz/hooks","issue_events_url":"https://api.github.com/repos/meetfranz/franz/issues/events{/number}","events_url":"https://api.github.com/repos/meetfranz/franz/events","assignees_url":"https://api.github.com/repos/meetfranz/franz/assignees{/user}","branches_url":"https://api.github.com/repos/meetfranz/franz/branches{/branch}","tags_url":"https://api.github.com/repos/meetfranz/franz/tags","blobs_url":"https://api.github.com/repos/meetfranz/franz/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/meetfranz/franz/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/meetfranz/franz/git/refs{/sha}","trees_url":"https://api.github.com/repos/meetfranz/franz/git/trees{/sha}","statuses_url":"https://api.github.com/repos/meetfranz/franz/statuses/{sha}","languages_url":"https://api.github.com/repos/meetfranz/franz/languages","stargazers_url":"https://api.github.com/repos/meetfranz/franz/stargazers","contributors_url":"https://api.github.com/repos/meetfranz/franz/contributors","subscribers_url":"https://api.github.com/repos/meetfranz/franz/subscribers","subscription_url":"https://api.github.com/repos/meetfranz/franz/subscription","commits_url":"https://api.github.com/repos/meetfranz/franz/commits{/sha}","git_commits_url":"https://api.github.com/repos/meetfranz/franz/git/commits{/sha}","comments_url":"https://api.github.com/repos/meetfranz/franz/comments{/number}","issue_comment_url":"https://api.github.com/repos/meetfranz/franz/issues/comments{/number}","contents_url":"https://api.github.com/repos/meetfranz/franz/contents/{+path}","compare_url":"https://api.github.com/repos/meetfranz/franz/compare/{base}...{head}","merges_url":"https://api.github.com/repos/meetfranz/franz/merges","archive_url":"https://api.github.com/repos/meetfranz/franz/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/meetfranz/franz/downloads","issues_url":"https://api.github.com/repos/meetfranz/franz/issues{/number}","pulls_url":"https://api.github.com/repos/meetfranz/franz/pulls{/number}","milestones_url":"https://api.github.com/repos/meetfranz/franz/milestones{/number}","notifications_url":"https://api.github.com/repos/meetfranz/franz/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/meetfranz/franz/labels{/name}","releases_url":"https://api.github.com/repos/meetfranz/franz/releases{/id}","deployments_url":"https://api.github.com/repos/meetfranz/franz/deployments","created_at":"2017-10-13T10:17:01Z","updated_at":"2017-10-27T09:05:54Z","pushed_at":"2017-10-27T09:57:41Z","git_url":"git://github.com/meetfranz/franz.git","ssh_url":"git@github.com:meetfranz/franz.git","clone_url":"https://github.com/meetfranz/franz.git","svn_url":"https://github.com/meetfranz/franz","homepage":"http://meetfranz.com","size":3230,"stargazers_count":198,"watchers_count":198,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":47,"mirror_url":null,"archived":false,"open_issues_count":42,"forks":47,"open_issues":42,"watchers":198,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/meetfranz/franz/pulls/137"},"html":{"href":"https://github.com/meetfranz/franz/pull/137"},"issue":{"href":"https://api.github.com/repos/meetfranz/franz/issues/137"},"comments":{"href":"https://api.github.com/repos/meetfranz/franz/issues/137/comments"},"review_comments":{"href":"https://api.github.com/repos/meetfranz/franz/pulls/137/comments"},"review_comment":{"href":"https://api.github.com/repos/meetfranz/franz/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/meetfranz/franz/pulls/137/commits"},"statuses":{"href":"https://api.github.com/repos/meetfranz/franz/statuses/dfe93917284bbe1c813a417491cf5a684afceb4c"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"adlk","id":3265004,"avatar_url":"https://avatars1.githubusercontent.com/u/3265004?v=4","gravatar_id":"","url":"https://api.github.com/users/adlk","html_url":"https://github.com/adlk","followers_url":"https://api.github.com/users/adlk/followers","following_url":"https://api.github.com/users/adlk/following{/other_user}","gists_url":"https://api.github.com/users/adlk/gists{/gist_id}","starred_url":"https://api.github.com/users/adlk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adlk/subscriptions","organizations_url":"https://api.github.com/users/adlk/orgs","repos_url":"https://api.github.com/users/adlk/repos","events_url":"https://api.github.com/users/adlk/events{/privacy}","received_events_url":"https://api.github.com/users/adlk/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"adlk"}}