{"action":"created","comment":{"url":"https://api.github.com/repos/YunoHost/yunohost/pulls/comments/114685419","pull_request_review_id":36172793,"id":114685419,"diff_hunk":"@@ -47,7 +47,7 @@ ynh_find_port () {\n # | arg: path - the web path to check the availability of\n ynh_webpath_available () {\n \tlocal domain=$1\n-\tlocal path=$(ynh_normalize_url_path $2)\n+\tlocal path=$2","path":"data/helpers.d/network","position":null,"original_position":5,"commit_id":"89856a3f2ba42acf26a0dc22ad979a26b7e6e11a","original_commit_id":"89856a3f2ba42acf26a0dc22ad979a26b7e6e11a","user":{"login":"alexAubin","id":4533074,"avatar_url":"https://avatars0.githubusercontent.com/u/4533074?v=3","gravatar_id":"","url":"https://api.github.com/users/alexAubin","html_url":"https://github.com/alexAubin","followers_url":"https://api.github.com/users/alexAubin/followers","following_url":"https://api.github.com/users/alexAubin/following{/other_user}","gists_url":"https://api.github.com/users/alexAubin/gists{/gist_id}","starred_url":"https://api.github.com/users/alexAubin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexAubin/subscriptions","organizations_url":"https://api.github.com/users/alexAubin/orgs","repos_url":"https://api.github.com/users/alexAubin/repos","events_url":"https://api.github.com/users/alexAubin/events{/privacy}","received_events_url":"https://api.github.com/users/alexAubin/received_events","type":"User","site_admin":false},"body":"After discussing on the chat, we agreed that :\r\n- the normalizing of the path should be done before the install script ideally, therefore we should remove both `ynh_normalize_url_path` from these helpers\r\n- the availability check should be done before even launching the install script\r\n\r\nBoth these points are implemented in https://github.com/YunoHost/yunohost/pull/304","created_at":"2017-05-04T00:58:48Z","updated_at":"2017-05-04T00:58:48Z","html_url":"https://github.com/YunoHost/yunohost/pull/235#discussion_r114685419","pull_request_url":"https://api.github.com/repos/YunoHost/yunohost/pulls/235","_links":{"self":{"href":"https://api.github.com/repos/YunoHost/yunohost/pulls/comments/114685419"},"html":{"href":"https://github.com/YunoHost/yunohost/pull/235#discussion_r114685419"},"pull_request":{"href":"https://api.github.com/repos/YunoHost/yunohost/pulls/235"}}},"pull_request":{"url":"https://api.github.com/repos/YunoHost/yunohost/pulls/235","id":102636428,"html_url":"https://github.com/YunoHost/yunohost/pull/235","diff_url":"https://github.com/YunoHost/yunohost/pull/235.diff","patch_url":"https://github.com/YunoHost/yunohost/pull/235.patch","issue_url":"https://api.github.com/repos/YunoHost/yunohost/issues/235","number":235,"state":"open","locked":false,"title":"Nouveau helper ynh_webpath_available et ynh_webpath_register","user":{"login":"maniackcrudelis","id":8302225,"avatar_url":"https://avatars1.githubusercontent.com/u/8302225?v=3","gravatar_id":"","url":"https://api.github.com/users/maniackcrudelis","html_url":"https://github.com/maniackcrudelis","followers_url":"https://api.github.com/users/maniackcrudelis/followers","following_url":"https://api.github.com/users/maniackcrudelis/following{/other_user}","gists_url":"https://api.github.com/users/maniackcrudelis/gists{/gist_id}","starred_url":"https://api.github.com/users/maniackcrudelis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maniackcrudelis/subscriptions","organizations_url":"https://api.github.com/users/maniackcrudelis/orgs","repos_url":"https://api.github.com/users/maniackcrudelis/repos","events_url":"https://api.github.com/users/maniackcrudelis/events{/privacy}","received_events_url":"https://api.github.com/users/maniackcrudelis/received_events","type":"User","site_admin":false},"body":"Simplement un wrapper de yunohost app checkurl.\r\n\r\nPeut-être une occasion de lui donner un autre nom plus parlant.\r\nIl me semble justement qu'il en était question.","created_at":"2017-01-22T21:26:04Z","updated_at":"2017-05-04T00:58:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9a5694a0fadf853001c6b4e61bd97b72b7b393c4","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/YunoHost/yunohost/milestones/3","html_url":"https://github.com/YunoHost/yunohost/milestone/3","labels_url":"https://api.github.com/repos/YunoHost/yunohost/milestones/3/labels","id":2190700,"number":3,"title":"2.6.x","description":"","creator":{"login":"M5oul","id":4758871,"avatar_url":"https://avatars2.githubusercontent.com/u/4758871?v=3","gravatar_id":"","url":"https://api.github.com/users/M5oul","html_url":"https://github.com/M5oul","followers_url":"https://api.github.com/users/M5oul/followers","following_url":"https://api.github.com/users/M5oul/following{/other_user}","gists_url":"https://api.github.com/users/M5oul/gists{/gist_id}","starred_url":"https://api.github.com/users/M5oul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/M5oul/subscriptions","organizations_url":"https://api.github.com/users/M5oul/orgs","repos_url":"https://api.github.com/users/M5oul/repos","events_url":"https://api.github.com/users/M5oul/events{/privacy}","received_events_url":"https://api.github.com/users/M5oul/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":52,"state":"open","created_at":"2016-12-12T12:37:56Z","updated_at":"2017-05-03T17:11:02Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/YunoHost/yunohost/pulls/235/commits","review_comments_url":"https://api.github.com/repos/YunoHost/yunohost/pulls/235/comments","review_comment_url":"https://api.github.com/repos/YunoHost/yunohost/pulls/comments{/number}","comments_url":"https://api.github.com/repos/YunoHost/yunohost/issues/235/comments","statuses_url":"https://api.github.com/repos/YunoHost/yunohost/statuses/89856a3f2ba42acf26a0dc22ad979a26b7e6e11a","head":{"label":"YunoHost:ynh_path_validity","ref":"ynh_path_validity","sha":"89856a3f2ba42acf26a0dc22ad979a26b7e6e11a","user":{"login":"YunoHost","id":1519495,"avatar_url":"https://avatars3.githubusercontent.com/u/1519495?v=3","gravatar_id":"","url":"https://api.github.com/users/YunoHost","html_url":"https://github.com/YunoHost","followers_url":"https://api.github.com/users/YunoHost/followers","following_url":"https://api.github.com/users/YunoHost/following{/other_user}","gists_url":"https://api.github.com/users/YunoHost/gists{/gist_id}","starred_url":"https://api.github.com/users/YunoHost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YunoHost/subscriptions","organizations_url":"https://api.github.com/users/YunoHost/orgs","repos_url":"https://api.github.com/users/YunoHost/repos","events_url":"https://api.github.com/users/YunoHost/events{/privacy}","received_events_url":"https://api.github.com/users/YunoHost/received_events","type":"Organization","site_admin":false},"repo":{"id":19854246,"name":"yunohost","full_name":"YunoHost/yunohost","owner":{"login":"YunoHost","id":1519495,"avatar_url":"https://avatars3.githubusercontent.com/u/1519495?v=3","gravatar_id":"","url":"https://api.github.com/users/YunoHost","html_url":"https://github.com/YunoHost","followers_url":"https://api.github.com/users/YunoHost/followers","following_url":"https://api.github.com/users/YunoHost/following{/other_user}","gists_url":"https://api.github.com/users/YunoHost/gists{/gist_id}","starred_url":"https://api.github.com/users/YunoHost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YunoHost/subscriptions","organizations_url":"https://api.github.com/users/YunoHost/orgs","repos_url":"https://api.github.com/users/YunoHost/repos","events_url":"https://api.github.com/users/YunoHost/events{/privacy}","received_events_url":"https://api.github.com/users/YunoHost/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/YunoHost/yunohost","description":"YunoHost Python scripts core","fork":false,"url":"https://api.github.com/repos/YunoHost/yunohost","forks_url":"https://api.github.com/repos/YunoHost/yunohost/forks","keys_url":"https://api.github.com/repos/YunoHost/yunohost/keys{/key_id}","collaborators_url":"https://api.github.com/repos/YunoHost/yunohost/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/YunoHost/yunohost/teams","hooks_url":"https://api.github.com/repos/YunoHost/yunohost/hooks","issue_events_url":"https://api.github.com/repos/YunoHost/yunohost/issues/events{/number}","events_url":"https://api.github.com/repos/YunoHost/yunohost/events","assignees_url":"https://api.github.com/repos/YunoHost/yunohost/assignees{/user}","branches_url":"https://api.github.com/repos/YunoHost/yunohost/branches{/branch}","tags_url":"https://api.github.com/repos/YunoHost/yunohost/tags","blobs_url":"https://api.github.com/repos/YunoHost/yunohost/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/YunoHost/yunohost/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/YunoHost/yunohost/git/refs{/sha}","trees_url":"https://api.github.com/repos/YunoHost/yunohost/git/trees{/sha}","statuses_url":"https://api.github.com/repos/YunoHost/yunohost/statuses/{sha}","languages_url":"https://api.github.com/repos/YunoHost/yunohost/languages","stargazers_url":"https://api.github.com/repos/YunoHost/yunohost/stargazers","contributors_url":"https://api.github.com/repos/YunoHost/yunohost/contributors","subscribers_url":"https://api.github.com/repos/YunoHost/yunohost/subscribers","subscription_url":"https://api.github.com/repos/YunoHost/yunohost/subscription","commits_url":"https://api.github.com/repos/YunoHost/yunohost/commits{/sha}","git_commits_url":"https://api.github.com/repos/YunoHost/yunohost/git/commits{/sha}","comments_url":"https://api.github.com/repos/YunoHost/yunohost/comments{/number}","issue_comment_url":"https://api.github.com/repos/YunoHost/yunohost/issues/comments{/number}","contents_url":"https://api.github.com/repos/YunoHost/yunohost/contents/{+path}","compare_url":"https://api.github.com/repos/YunoHost/yunohost/compare/{base}...{head}","merges_url":"https://api.github.com/repos/YunoHost/yunohost/merges","archive_url":"https://api.github.com/repos/YunoHost/yunohost/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/YunoHost/yunohost/downloads","issues_url":"https://api.github.com/repos/YunoHost/yunohost/issues{/number}","pulls_url":"https://api.github.com/repos/YunoHost/yunohost/pulls{/number}","milestones_url":"https://api.github.com/repos/YunoHost/yunohost/milestones{/number}","notifications_url":"https://api.github.com/repos/YunoHost/yunohost/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/YunoHost/yunohost/labels{/name}","releases_url":"https://api.github.com/repos/YunoHost/yunohost/releases{/id}","deployments_url":"https://api.github.com/repos/YunoHost/yunohost/deployments","created_at":"2014-05-16T11:29:11Z","updated_at":"2017-05-03T16:16:20Z","pushed_at":"2017-05-04T00:55:38Z","git_url":"git://github.com/YunoHost/yunohost.git","ssh_url":"git@github.com:YunoHost/yunohost.git","clone_url":"https://github.com/YunoHost/yunohost.git","svn_url":"https://github.com/YunoHost/yunohost","homepage":"https://yunohost.org","size":2212,"stargazers_count":136,"watchers_count":136,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":48,"mirror_url":null,"open_issues_count":60,"forks":48,"open_issues":60,"watchers":136,"default_branch":"unstable"}},"base":{"label":"YunoHost:unstable","ref":"unstable","sha":"86f0978dfb4c43237e10fd55653bc664ff46eb8d","user":{"login":"YunoHost","id":1519495,"avatar_url":"https://avatars3.githubusercontent.com/u/1519495?v=3","gravatar_id":"","url":"https://api.github.com/users/YunoHost","html_url":"https://github.com/YunoHost","followers_url":"https://api.github.com/users/YunoHost/followers","following_url":"https://api.github.com/users/YunoHost/following{/other_user}","gists_url":"https://api.github.com/users/YunoHost/gists{/gist_id}","starred_url":"https://api.github.com/users/YunoHost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YunoHost/subscriptions","organizations_url":"https://api.github.com/users/YunoHost/orgs","repos_url":"https://api.github.com/users/YunoHost/repos","events_url":"https://api.github.com/users/YunoHost/events{/privacy}","received_events_url":"https://api.github.com/users/YunoHost/received_events","type":"Organization","site_admin":false},"repo":{"id":19854246,"name":"yunohost","full_name":"YunoHost/yunohost","owner":{"login":"YunoHost","id":1519495,"avatar_url":"https://avatars3.githubusercontent.com/u/1519495?v=3","gravatar_id":"","url":"https://api.github.com/users/YunoHost","html_url":"https://github.com/YunoHost","followers_url":"https://api.github.com/users/YunoHost/followers","following_url":"https://api.github.com/users/YunoHost/following{/other_user}","gists_url":"https://api.github.com/users/YunoHost/gists{/gist_id}","starred_url":"https://api.github.com/users/YunoHost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YunoHost/subscriptions","organizations_url":"https://api.github.com/users/YunoHost/orgs","repos_url":"https://api.github.com/users/YunoHost/repos","events_url":"https://api.github.com/users/YunoHost/events{/privacy}","received_events_url":"https://api.github.com/users/YunoHost/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/YunoHost/yunohost","description":"YunoHost Python scripts core","fork":false,"url":"https://api.github.com/repos/YunoHost/yunohost","forks_url":"https://api.github.com/repos/YunoHost/yunohost/forks","keys_url":"https://api.github.com/repos/YunoHost/yunohost/keys{/key_id}","collaborators_url":"https://api.github.com/repos/YunoHost/yunohost/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/YunoHost/yunohost/teams","hooks_url":"https://api.github.com/repos/YunoHost/yunohost/hooks","issue_events_url":"https://api.github.com/repos/YunoHost/yunohost/issues/events{/number}","events_url":"https://api.github.com/repos/YunoHost/yunohost/events","assignees_url":"https://api.github.com/repos/YunoHost/yunohost/assignees{/user}","branches_url":"https://api.github.com/repos/YunoHost/yunohost/branches{/branch}","tags_url":"https://api.github.com/repos/YunoHost/yunohost/tags","blobs_url":"https://api.github.com/repos/YunoHost/yunohost/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/YunoHost/yunohost/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/YunoHost/yunohost/git/refs{/sha}","trees_url":"https://api.github.com/repos/YunoHost/yunohost/git/trees{/sha}","statuses_url":"https://api.github.com/repos/YunoHost/yunohost/statuses/{sha}","languages_url":"https://api.github.com/repos/YunoHost/yunohost/languages","stargazers_url":"https://api.github.com/repos/YunoHost/yunohost/stargazers","contributors_url":"https://api.github.com/repos/YunoHost/yunohost/contributors","subscribers_url":"https://api.github.com/repos/YunoHost/yunohost/subscribers","subscription_url":"https://api.github.com/repos/YunoHost/yunohost/subscription","commits_url":"https://api.github.com/repos/YunoHost/yunohost/commits{/sha}","git_commits_url":"https://api.github.com/repos/YunoHost/yunohost/git/commits{/sha}","comments_url":"https://api.github.com/repos/YunoHost/yunohost/comments{/number}","issue_comment_url":"https://api.github.com/repos/YunoHost/yunohost/issues/comments{/number}","contents_url":"https://api.github.com/repos/YunoHost/yunohost/contents/{+path}","compare_url":"https://api.github.com/repos/YunoHost/yunohost/compare/{base}...{head}","merges_url":"https://api.github.com/repos/YunoHost/yunohost/merges","archive_url":"https://api.github.com/repos/YunoHost/yunohost/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/YunoHost/yunohost/downloads","issues_url":"https://api.github.com/repos/YunoHost/yunohost/issues{/number}","pulls_url":"https://api.github.com/repos/YunoHost/yunohost/pulls{/number}","milestones_url":"https://api.github.com/repos/YunoHost/yunohost/milestones{/number}","notifications_url":"https://api.github.com/repos/YunoHost/yunohost/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/YunoHost/yunohost/labels{/name}","releases_url":"https://api.github.com/repos/YunoHost/yunohost/releases{/id}","deployments_url":"https://api.github.com/repos/YunoHost/yunohost/deployments","created_at":"2014-05-16T11:29:11Z","updated_at":"2017-05-03T16:16:20Z","pushed_at":"2017-05-04T00:55:38Z","git_url":"git://github.com/YunoHost/yunohost.git","ssh_url":"git@github.com:YunoHost/yunohost.git","clone_url":"https://github.com/YunoHost/yunohost.git","svn_url":"https://github.com/YunoHost/yunohost","homepage":"https://yunohost.org","size":2212,"stargazers_count":136,"watchers_count":136,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":48,"mirror_url":null,"open_issues_count":60,"forks":48,"open_issues":60,"watchers":136,"default_branch":"unstable"}},"_links":{"self":{"href":"https://api.github.com/repos/YunoHost/yunohost/pulls/235"},"html":{"href":"https://github.com/YunoHost/yunohost/pull/235"},"issue":{"href":"https://api.github.com/repos/YunoHost/yunohost/issues/235"},"comments":{"href":"https://api.github.com/repos/YunoHost/yunohost/issues/235/comments"},"review_comments":{"href":"https://api.github.com/repos/YunoHost/yunohost/pulls/235/comments"},"review_comment":{"href":"https://api.github.com/repos/YunoHost/yunohost/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/YunoHost/yunohost/pulls/235/commits"},"statuses":{"href":"https://api.github.com/repos/YunoHost/yunohost/statuses/89856a3f2ba42acf26a0dc22ad979a26b7e6e11a"}}}}
{"actor":{"display_login":"alexAubin"}}