{"action":"created","comment":{"url":"https://api.github.com/repos/svenstaro/bvh/pulls/comments/112183225","pull_request_review_id":33161630,"id":112183225,"diff_hunk":"@@ -136,12 +137,46 @@ impl BVH {\n     /// use bvh::bvh::BVH;\n     /// use bvh::nalgebra::{Point3, Vector3};\n     /// use bvh::ray::Ray;\n-    /// # fn create_bounded_shapes() -> Vec<AABB> {\n+    /// # use bvh::bounding_hierarchy::BHShape;\n+    /// # pub struct UnitBox {","path":"src/flat_bvh.rs","position":74,"original_position":74,"commit_id":"590495c29a5734720ce46152fa805b7122cc3a8c","original_commit_id":"590495c29a5734720ce46152fa805b7122cc3a8c","user":{"login":"Prior99","id":1491574,"avatar_url":"https://avatars0.githubusercontent.com/u/1491574?v=3","gravatar_id":"","url":"https://api.github.com/users/Prior99","html_url":"https://github.com/Prior99","followers_url":"https://api.github.com/users/Prior99/followers","following_url":"https://api.github.com/users/Prior99/following{/other_user}","gists_url":"https://api.github.com/users/Prior99/gists{/gist_id}","starred_url":"https://api.github.com/users/Prior99/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Prior99/subscriptions","organizations_url":"https://api.github.com/users/Prior99/orgs","repos_url":"https://api.github.com/users/Prior99/repos","events_url":"https://api.github.com/users/Prior99/events{/privacy}","received_events_url":"https://api.github.com/users/Prior99/received_events","type":"User","site_admin":false},"body":"Maybe move this into `examples/` directory and define a unitbox mod there.","created_at":"2017-04-19T12:05:58Z","updated_at":"2017-04-19T12:08:48Z","html_url":"https://github.com/svenstaro/bvh/pull/14#discussion_r112183225","pull_request_url":"https://api.github.com/repos/svenstaro/bvh/pulls/14","_links":{"self":{"href":"https://api.github.com/repos/svenstaro/bvh/pulls/comments/112183225"},"html":{"href":"https://github.com/svenstaro/bvh/pull/14#discussion_r112183225"},"pull_request":{"href":"https://api.github.com/repos/svenstaro/bvh/pulls/14"}}},"pull_request":{"url":"https://api.github.com/repos/svenstaro/bvh/pulls/14","id":102261930,"html_url":"https://github.com/svenstaro/bvh/pull/14","diff_url":"https://github.com/svenstaro/bvh/pull/14.diff","patch_url":"https://github.com/svenstaro/bvh/pull/14.patch","issue_url":"https://api.github.com/repos/svenstaro/bvh/issues/14","number":14,"state":"open","locked":false,"title":"WIP: Dynamic bvh optimization","user":{"login":"FlaShG","id":2094156,"avatar_url":"https://avatars3.githubusercontent.com/u/2094156?v=3","gravatar_id":"","url":"https://api.github.com/users/FlaShG","html_url":"https://github.com/FlaShG","followers_url":"https://api.github.com/users/FlaShG/followers","following_url":"https://api.github.com/users/FlaShG/following{/other_user}","gists_url":"https://api.github.com/users/FlaShG/gists{/gist_id}","starred_url":"https://api.github.com/users/FlaShG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FlaShG/subscriptions","organizations_url":"https://api.github.com/users/FlaShG/orgs","repos_url":"https://api.github.com/users/FlaShG/repos","events_url":"https://api.github.com/users/FlaShG/events{/privacy}","received_events_url":"https://api.github.com/users/FlaShG/received_events","type":"User","site_admin":false},"body":"The optimization extension is in a working state.\r\nWe're missing tests and benchmarks, but the code itself could use an early review.\r\n\r\nThis pull request is WIP and should not be merged before tests and benchmarks are implemented.","created_at":"2017-01-19T13:00:56Z","updated_at":"2017-04-19T12:08:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9aa242477a748271caf507028f16878b10222380","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/svenstaro/bvh/pulls/14/commits","review_comments_url":"https://api.github.com/repos/svenstaro/bvh/pulls/14/comments","review_comment_url":"https://api.github.com/repos/svenstaro/bvh/pulls/comments{/number}","comments_url":"https://api.github.com/repos/svenstaro/bvh/issues/14/comments","statuses_url":"https://api.github.com/repos/svenstaro/bvh/statuses/590495c29a5734720ce46152fa805b7122cc3a8c","head":{"label":"svenstaro:dynamic-bvh","ref":"dynamic-bvh","sha":"590495c29a5734720ce46152fa805b7122cc3a8c","user":{"login":"svenstaro","id":1664,"avatar_url":"https://avatars3.githubusercontent.com/u/1664?v=3","gravatar_id":"","url":"https://api.github.com/users/svenstaro","html_url":"https://github.com/svenstaro","followers_url":"https://api.github.com/users/svenstaro/followers","following_url":"https://api.github.com/users/svenstaro/following{/other_user}","gists_url":"https://api.github.com/users/svenstaro/gists{/gist_id}","starred_url":"https://api.github.com/users/svenstaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svenstaro/subscriptions","organizations_url":"https://api.github.com/users/svenstaro/orgs","repos_url":"https://api.github.com/users/svenstaro/repos","events_url":"https://api.github.com/users/svenstaro/events{/privacy}","received_events_url":"https://api.github.com/users/svenstaro/received_events","type":"User","site_admin":false},"repo":{"id":68921740,"name":"bvh","full_name":"svenstaro/bvh","owner":{"login":"svenstaro","id":1664,"avatar_url":"https://avatars3.githubusercontent.com/u/1664?v=3","gravatar_id":"","url":"https://api.github.com/users/svenstaro","html_url":"https://github.com/svenstaro","followers_url":"https://api.github.com/users/svenstaro/followers","following_url":"https://api.github.com/users/svenstaro/following{/other_user}","gists_url":"https://api.github.com/users/svenstaro/gists{/gist_id}","starred_url":"https://api.github.com/users/svenstaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svenstaro/subscriptions","organizations_url":"https://api.github.com/users/svenstaro/orgs","repos_url":"https://api.github.com/users/svenstaro/repos","events_url":"https://api.github.com/users/svenstaro/events{/privacy}","received_events_url":"https://api.github.com/users/svenstaro/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/svenstaro/bvh","description":"A fast BVH using SAH in rust","fork":false,"url":"https://api.github.com/repos/svenstaro/bvh","forks_url":"https://api.github.com/repos/svenstaro/bvh/forks","keys_url":"https://api.github.com/repos/svenstaro/bvh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/svenstaro/bvh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/svenstaro/bvh/teams","hooks_url":"https://api.github.com/repos/svenstaro/bvh/hooks","issue_events_url":"https://api.github.com/repos/svenstaro/bvh/issues/events{/number}","events_url":"https://api.github.com/repos/svenstaro/bvh/events","assignees_url":"https://api.github.com/repos/svenstaro/bvh/assignees{/user}","branches_url":"https://api.github.com/repos/svenstaro/bvh/branches{/branch}","tags_url":"https://api.github.com/repos/svenstaro/bvh/tags","blobs_url":"https://api.github.com/repos/svenstaro/bvh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/svenstaro/bvh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/svenstaro/bvh/git/refs{/sha}","trees_url":"https://api.github.com/repos/svenstaro/bvh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/svenstaro/bvh/statuses/{sha}","languages_url":"https://api.github.com/repos/svenstaro/bvh/languages","stargazers_url":"https://api.github.com/repos/svenstaro/bvh/stargazers","contributors_url":"https://api.github.com/repos/svenstaro/bvh/contributors","subscribers_url":"https://api.github.com/repos/svenstaro/bvh/subscribers","subscription_url":"https://api.github.com/repos/svenstaro/bvh/subscription","commits_url":"https://api.github.com/repos/svenstaro/bvh/commits{/sha}","git_commits_url":"https://api.github.com/repos/svenstaro/bvh/git/commits{/sha}","comments_url":"https://api.github.com/repos/svenstaro/bvh/comments{/number}","issue_comment_url":"https://api.github.com/repos/svenstaro/bvh/issues/comments{/number}","contents_url":"https://api.github.com/repos/svenstaro/bvh/contents/{+path}","compare_url":"https://api.github.com/repos/svenstaro/bvh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/svenstaro/bvh/merges","archive_url":"https://api.github.com/repos/svenstaro/bvh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/svenstaro/bvh/downloads","issues_url":"https://api.github.com/repos/svenstaro/bvh/issues{/number}","pulls_url":"https://api.github.com/repos/svenstaro/bvh/pulls{/number}","milestones_url":"https://api.github.com/repos/svenstaro/bvh/milestones{/number}","notifications_url":"https://api.github.com/repos/svenstaro/bvh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/svenstaro/bvh/labels{/name}","releases_url":"https://api.github.com/repos/svenstaro/bvh/releases{/id}","deployments_url":"https://api.github.com/repos/svenstaro/bvh/deployments","created_at":"2016-09-22T13:02:14Z","updated_at":"2016-11-19T21:49:43Z","pushed_at":"2017-02-26T20:14:48Z","git_url":"git://github.com/svenstaro/bvh.git","ssh_url":"git@github.com:svenstaro/bvh.git","clone_url":"https://github.com/svenstaro/bvh.git","svn_url":"https://github.com/svenstaro/bvh","homepage":"","size":215,"stargazers_count":1,"watchers_count":1,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":1,"default_branch":"master"}},"base":{"label":"svenstaro:master","ref":"master","sha":"1b263ee9854bd8d3fc02fee855db8cb19149b257","user":{"login":"svenstaro","id":1664,"avatar_url":"https://avatars3.githubusercontent.com/u/1664?v=3","gravatar_id":"","url":"https://api.github.com/users/svenstaro","html_url":"https://github.com/svenstaro","followers_url":"https://api.github.com/users/svenstaro/followers","following_url":"https://api.github.com/users/svenstaro/following{/other_user}","gists_url":"https://api.github.com/users/svenstaro/gists{/gist_id}","starred_url":"https://api.github.com/users/svenstaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svenstaro/subscriptions","organizations_url":"https://api.github.com/users/svenstaro/orgs","repos_url":"https://api.github.com/users/svenstaro/repos","events_url":"https://api.github.com/users/svenstaro/events{/privacy}","received_events_url":"https://api.github.com/users/svenstaro/received_events","type":"User","site_admin":false},"repo":{"id":68921740,"name":"bvh","full_name":"svenstaro/bvh","owner":{"login":"svenstaro","id":1664,"avatar_url":"https://avatars3.githubusercontent.com/u/1664?v=3","gravatar_id":"","url":"https://api.github.com/users/svenstaro","html_url":"https://github.com/svenstaro","followers_url":"https://api.github.com/users/svenstaro/followers","following_url":"https://api.github.com/users/svenstaro/following{/other_user}","gists_url":"https://api.github.com/users/svenstaro/gists{/gist_id}","starred_url":"https://api.github.com/users/svenstaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svenstaro/subscriptions","organizations_url":"https://api.github.com/users/svenstaro/orgs","repos_url":"https://api.github.com/users/svenstaro/repos","events_url":"https://api.github.com/users/svenstaro/events{/privacy}","received_events_url":"https://api.github.com/users/svenstaro/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/svenstaro/bvh","description":"A fast BVH using SAH in rust","fork":false,"url":"https://api.github.com/repos/svenstaro/bvh","forks_url":"https://api.github.com/repos/svenstaro/bvh/forks","keys_url":"https://api.github.com/repos/svenstaro/bvh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/svenstaro/bvh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/svenstaro/bvh/teams","hooks_url":"https://api.github.com/repos/svenstaro/bvh/hooks","issue_events_url":"https://api.github.com/repos/svenstaro/bvh/issues/events{/number}","events_url":"https://api.github.com/repos/svenstaro/bvh/events","assignees_url":"https://api.github.com/repos/svenstaro/bvh/assignees{/user}","branches_url":"https://api.github.com/repos/svenstaro/bvh/branches{/branch}","tags_url":"https://api.github.com/repos/svenstaro/bvh/tags","blobs_url":"https://api.github.com/repos/svenstaro/bvh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/svenstaro/bvh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/svenstaro/bvh/git/refs{/sha}","trees_url":"https://api.github.com/repos/svenstaro/bvh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/svenstaro/bvh/statuses/{sha}","languages_url":"https://api.github.com/repos/svenstaro/bvh/languages","stargazers_url":"https://api.github.com/repos/svenstaro/bvh/stargazers","contributors_url":"https://api.github.com/repos/svenstaro/bvh/contributors","subscribers_url":"https://api.github.com/repos/svenstaro/bvh/subscribers","subscription_url":"https://api.github.com/repos/svenstaro/bvh/subscription","commits_url":"https://api.github.com/repos/svenstaro/bvh/commits{/sha}","git_commits_url":"https://api.github.com/repos/svenstaro/bvh/git/commits{/sha}","comments_url":"https://api.github.com/repos/svenstaro/bvh/comments{/number}","issue_comment_url":"https://api.github.com/repos/svenstaro/bvh/issues/comments{/number}","contents_url":"https://api.github.com/repos/svenstaro/bvh/contents/{+path}","compare_url":"https://api.github.com/repos/svenstaro/bvh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/svenstaro/bvh/merges","archive_url":"https://api.github.com/repos/svenstaro/bvh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/svenstaro/bvh/downloads","issues_url":"https://api.github.com/repos/svenstaro/bvh/issues{/number}","pulls_url":"https://api.github.com/repos/svenstaro/bvh/pulls{/number}","milestones_url":"https://api.github.com/repos/svenstaro/bvh/milestones{/number}","notifications_url":"https://api.github.com/repos/svenstaro/bvh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/svenstaro/bvh/labels{/name}","releases_url":"https://api.github.com/repos/svenstaro/bvh/releases{/id}","deployments_url":"https://api.github.com/repos/svenstaro/bvh/deployments","created_at":"2016-09-22T13:02:14Z","updated_at":"2016-11-19T21:49:43Z","pushed_at":"2017-02-26T20:14:48Z","git_url":"git://github.com/svenstaro/bvh.git","ssh_url":"git@github.com:svenstaro/bvh.git","clone_url":"https://github.com/svenstaro/bvh.git","svn_url":"https://github.com/svenstaro/bvh","homepage":"","size":215,"stargazers_count":1,"watchers_count":1,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/svenstaro/bvh/pulls/14"},"html":{"href":"https://github.com/svenstaro/bvh/pull/14"},"issue":{"href":"https://api.github.com/repos/svenstaro/bvh/issues/14"},"comments":{"href":"https://api.github.com/repos/svenstaro/bvh/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/svenstaro/bvh/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/svenstaro/bvh/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/svenstaro/bvh/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/svenstaro/bvh/statuses/590495c29a5734720ce46152fa805b7122cc3a8c"}}}}
{"actor":{"display_login":"Prior99"}}