{"action":"created","issue":{"url":"https://api.github.com/repos/lkzhao/Hero/issues/186","repository_url":"https://api.github.com/repos/lkzhao/Hero","labels_url":"https://api.github.com/repos/lkzhao/Hero/issues/186/labels{/name}","comments_url":"https://api.github.com/repos/lkzhao/Hero/issues/186/comments","events_url":"https://api.github.com/repos/lkzhao/Hero/issues/186/events","html_url":"https://github.com/lkzhao/Hero/issues/186","id":221277951,"number":186,"title":"Dismissing transition container background color is same as toViewController background","user":{"login":"ImKcat","id":7700379,"avatar_url":"https://avatars2.githubusercontent.com/u/7700379?v=3","gravatar_id":"","url":"https://api.github.com/users/ImKcat","html_url":"https://github.com/ImKcat","followers_url":"https://api.github.com/users/ImKcat/followers","following_url":"https://api.github.com/users/ImKcat/following{/other_user}","gists_url":"https://api.github.com/users/ImKcat/gists{/gist_id}","starred_url":"https://api.github.com/users/ImKcat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ImKcat/subscriptions","organizations_url":"https://api.github.com/users/ImKcat/orgs","repos_url":"https://api.github.com/users/ImKcat/repos","events_url":"https://api.github.com/users/ImKcat/events{/privacy}","received_events_url":"https://api.github.com/users/ImKcat/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-04-12T14:17:59Z","updated_at":"2017-07-02T16:54:15Z","closed_at":"2017-07-02T16:54:15Z","body":"I don't know whether if I miss something, but dismiss animation just not effect totally anyway :(\r\nLet's check it out, there are three view controller\r\n``` swift\r\n// ViewController A\r\nself.isHeroEnabled = true\r\nbutton.heroID = \"button\"\r\n\r\nself.present(ViewControllerB(), animated: true, completion: nil)  // Animation is normally\r\n\r\n// ViewController B\r\nself.isHeroEnabled = true\r\nbutton.heroID = \"button\"\r\nbutton.heroModifiers = [Whatever]  // Animation is normally\r\n\r\nlet navigationController = NavigationController(rootViewController: ViewControllerC())\r\nnavigationController.isHeroEnabled = true\r\nnavigationController.heroModalAnimationType = .selectBy(presenting: .pageIn(direction: .up), dismissing: .pageOut(direction: .up))\r\nself.present(navigationController, animated: true, completion: nil)   // PageIn animation is normally\r\n\r\n// ViewController C\r\n\r\n// Problem found in here! PageOut animation is effect on UINavigationController, but not effect on ViewController B, animation not perform totally\r\nself.navigationController?.dismiss(animated: true, completion: nil)\r\n```\r\n\r\nDue to time, I haven't read source code yet :), I also keep on trying to figure out it!"},"comment":{"url":"https://api.github.com/repos/lkzhao/Hero/issues/comments/312503374","html_url":"https://github.com/lkzhao/Hero/issues/186#issuecomment-312503374","issue_url":"https://api.github.com/repos/lkzhao/Hero/issues/186","id":312503374,"user":{"login":"lkzhao","id":3359850,"avatar_url":"https://avatars2.githubusercontent.com/u/3359850?v=3","gravatar_id":"","url":"https://api.github.com/users/lkzhao","html_url":"https://github.com/lkzhao","followers_url":"https://api.github.com/users/lkzhao/followers","following_url":"https://api.github.com/users/lkzhao/following{/other_user}","gists_url":"https://api.github.com/users/lkzhao/gists{/gist_id}","starred_url":"https://api.github.com/users/lkzhao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lkzhao/subscriptions","organizations_url":"https://api.github.com/users/lkzhao/orgs","repos_url":"https://api.github.com/users/lkzhao/repos","events_url":"https://api.github.com/users/lkzhao/events{/privacy}","received_events_url":"https://api.github.com/users/lkzhao/received_events","type":"User","site_admin":false},"created_at":"2017-07-02T16:54:15Z","updated_at":"2017-07-02T16:54:15Z","body":"closing out old issues, feel free to reopen"}}
{"actor":{"display_login":"lkzhao"}}