{"push_id":2163759364,"size":11,"distinct_size":0,"ref":"refs/heads/master","head":"3eb840904a088a89d05821d975ed4624962431f3","before":"c703913cc0b675ecea41a239383f09f4291ea9d5","commits":[{"sha":"309cd46b400d80420615b19adfebf7158492ae3b","author":{"name":"Ján Tomko","email":"7cd9998bc81151f045ad70194d5fa375f8e73169@redhat.com"},"message":"Introduce virDomainDeviceAliasIsUserAlias\n\nAllow parts of code outside domain_conf to decide whether the alias\nis user-specified or not.","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/309cd46b400d80420615b19adfebf7158492ae3b"},{"sha":"dacfc6b10bcff1c275d21a37edf0bc83e0947492","author":{"name":"Ján Tomko","email":"7cd9998bc81151f045ad70194d5fa375f8e73169@redhat.com"},"message":"qemu: prefer the PCI bus alias from status XML\n\nFor some corner cases, virQEMUCapsHasPCIMultiBus depends on the QEMU\nversion, which is by design not stored in the status XML and therefore\nit cannot be fixed for all existing running domains.\n\nPrefer the controller alias read from the status XML when formatting\nPCI addresses and only fall back to using virQEMUCapsHasPCIMultiBus\nif the alias is a user alias.\n\nThis fixes hotplug after daemon restart for domains not using user\naliases.\n\nPartially reverts commit 937f3195.\n\nhttps://bugzilla.redhat.com/show_bug.cgi?id=1518148","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/dacfc6b10bcff1c275d21a37edf0bc83e0947492"},{"sha":"fdf354fb51e7f00b582d0daa18961d432155df83","author":{"name":"Ján Tomko","email":"7cd9998bc81151f045ad70194d5fa375f8e73169@redhat.com"},"message":"virQEMUCapsHasPCIMultiBus: use def->os.arch\n\nWe do not fill out qemuCaps->arch when parsing status XML.\n\nUse def->os.arch like we do for PPC.\n\nThis fixes hotplug after daemon restart for domains that use\na user alias for the implicit pci-root on x86.\n\nhttps://bugzilla.redhat.com/show_bug.cgi?id=1518148","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/fdf354fb51e7f00b582d0daa18961d432155df83"},{"sha":"65108d94d093de082dc5a2d4a73844dd569506db","author":{"name":"Ján Tomko","email":"7cd9998bc81151f045ad70194d5fa375f8e73169@redhat.com"},"message":"virQEMUCapsHasPCIMultiBus: assume true if we have no version information\n\nIn status XML, we do not store the QEMU version information, we only\nformat all the capabilities. We dropped QEMU_CAPS_PCI_MULTIBUS\nin commit 5b783379 which was released in libvirt 3.2.0.\n\nTherefore the only way of telling if the already running domain\nat the time of daemon restart has been started with a QEMU that does\nuse 'pci.0' or not on PPC is to look at the pci-root controller's\nalias. This is not an option if the domain has a user-specified alias\nfor the pci-root.\n\nInstead of reintroducing the capability, assume 'pci.0' when we have\nno version information. That way the only left broken use case would\nbe the combination of user aliases and very old QEMU.\n\nPartially reverts commit 3a37af1e4.\n\nhttps://bugzilla.redhat.com/show_bug.cgi?id=1518148","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/65108d94d093de082dc5a2d4a73844dd569506db"},{"sha":"cb06ea57ad80a964028f22fb49d6ab96648ae741","author":{"name":"Pavel Hrdina","email":"ab12192c95093947fa56ccf60770e010465455a4@redhat.com"},"message":"conf: fix migratable XML for graphics if socket is generated based on config\n\nThe graphics code is complex and there are a lot of exceptions and\nbackward compatible combinations.  One of them is the possibility\nto configure \"spice_auto_unix_socket\" in qemu.conf which will convert\nall spice graphics with listen type \"address\" without any address\nspecified to listen type \"socket\" when the guest is started.\n\nWe don't format this generated socket into migratable XML to make\nmigration work with older libvirt.  However, spice has another\nexception that if autoport='no' and there is no port configured\nit is converted to listen type \"none\".  Because of this we need\nto format autoport='yes' to make sure that the listen type will\nbe the same as the offline XML.\n\nResolves: https://bugzilla.redhat.com/show_bug.cgi?id=1511407\n\nReviewed-by: Jiri Denemark <jdenemar@redhat.com>\nSigned-off-by: Pavel Hrdina <phrdina@redhat.com>","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/cb06ea57ad80a964028f22fb49d6ab96648ae741"},{"sha":"b19710b9b6039728620a8d557a322ef139529226","author":{"name":"Peter Krempa","email":"ad550f3a498f24c1804da389934cf0cf16278373@redhat.com"},"message":"qemu: domain: Refactor control flow in qemuDomainDetermineDiskChain\n\nSplit out clearing of the backing chain prior to other code since it\nwill be required later and optimize few layers of nested conditions and\nloops.","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/b19710b9b6039728620a8d557a322ef139529226"},{"sha":"24e47ee2b93312742f73a785b9ca788df4677749","author":{"name":"Peter Krempa","email":"ad550f3a498f24c1804da389934cf0cf16278373@redhat.com"},"message":"qemu: process: Move handling of non-backing files into qemuDomainDetermineDiskChain\n\nUntil now we would skip loading of the backing chain for files which\ndon't support backing chains only when starting up the VM. Move the\ncheck from qemuProcessPrepareHostStorage with some adaptations so that's\nalways applied.","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/24e47ee2b93312742f73a785b9ca788df4677749"},{"sha":"adcc31bb89e47ef642cbcfcff372131db7cd8d8b","author":{"name":"Peter Krempa","email":"ad550f3a498f24c1804da389934cf0cf16278373@redhat.com"},"message":"qemu: domain: Fix backing store terminator for non-backing local files\n\nRaw local files do not pass through the backing store detector and thus\nthe code did not allocate the required backing store terminator for\nthem. Previously the terminating element would be formatted into the XML\nsince the default values used for the metadata allowed that. This is a\nregression since a693fdba0111ff which was not detected in the review.\n\nThis patch also reverts all the changes in the test files.","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/adcc31bb89e47ef642cbcfcff372131db7cd8d8b"},{"sha":"7d7c01b4580f471e1376e30d4092dcf45cfe0ccc","author":{"name":"Michal Privoznik","email":"ff52d8b477e4489d0b3b856d550bc61214c6ad4b@redhat.com"},"message":"virDomainDiskSourceNetworkParse: Don't leak @tlsCfg or @haveTLS\n\n==861== 3 bytes in 1 blocks are definitely lost in loss record 3 of 168\n==861==    at 0x4C2AEDF: malloc (vg_replace_malloc.c:299)\n==861==    by 0x8C7FBC8: xmlStrndup (in /usr/lib64/libxml2.so.2.9.4)\n==861==    by 0x5DCCDC2: virXMLPropString (virxml.c:510)\n==861==    by 0x5DF1232: virDomainDiskSourceNetworkParse (domain_conf.c:8445)\n==861==    by 0x5DF1728: virDomainDiskSourceParse (domain_conf.c:8576)\n==861==    by 0x5DF41A5: virDomainDiskDefParseXML (domain_conf.c:9238)\n==861==    by 0x5E1119F: virDomainDefParseXML (domain_conf.c:19233)\n==861==    by 0x5E146EE: virDomainDefParseNode (domain_conf.c:20083)\n==861==    by 0x5E14540: virDomainDefParse (domain_conf.c:20027)\n==861==    by 0x5E145E6: virDomainDefParseFile (domain_conf.c:20053)\n==861==    by 0x4053CC: testCompareXMLToArgv (qemuxml2argvtest.c:455)\n==861==    by 0x41F135: virTestRun (testutils.c:180)\n\nSigned-off-by: Michal Privoznik <mprivozn@redhat.com>","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/7d7c01b4580f471e1376e30d4092dcf45cfe0ccc"},{"sha":"0fd85b98aee9094bf61a2db86b795421119a41b5","author":{"name":"Michal Privoznik","email":"ff52d8b477e4489d0b3b856d550bc61214c6ad4b@redhat.com"},"message":"virDomainDiskBackingStoreParse: Don't leak @idx\n\n==1277== 8 bytes in 4 blocks are definitely lost in loss record 39 of 131\n==1277==    at 0x4C2AEDF: malloc (vg_replace_malloc.c:299)\n==1277==    by 0x68BBBC8: xmlStrndup (in /usr/lib64/libxml2.so.2.9.4)\n==1277==    by 0x53B1DC2: virXMLPropString (virxml.c:510)\n==1277==    by 0x53D696A: virDomainDiskBackingStoreParse (domain_conf.c:8639)\n==1277==    by 0x53DA684: virDomainDiskDefParseXML (domain_conf.c:9590)\n==1277==    by 0x53F619F: virDomainDefParseXML (domain_conf.c:19233)\n==1277==    by 0x53F96EE: virDomainDefParseNode (domain_conf.c:20083)\n==1277==    by 0x53F9540: virDomainDefParse (domain_conf.c:20027)\n==1277==    by 0x53F95E6: virDomainDefParseFile (domain_conf.c:20053)\n==1277==    by 0x44D1D4: testCompareDomXML2XMLFiles (testutils.c:1265)\n==1277==    by 0x42FC7C: testXML2XMLActive (qemuxml2xmltest.c:71)\n==1277==    by 0x44AD20: virTestRun (testutils.c:180)\n\nSigned-off-by: Michal Privoznik <mprivozn@redhat.com>","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/0fd85b98aee9094bf61a2db86b795421119a41b5"},{"sha":"3eb840904a088a89d05821d975ed4624962431f3","author":{"name":"Michal Privoznik","email":"ff52d8b477e4489d0b3b856d550bc61214c6ad4b@redhat.com"},"message":"qemuStateInitialize: Don't leak @memoryBackingPath\n\n==899== 39 bytes in 1 blocks are definitely lost in loss record 732 of 1,003\n==899==    at 0x4C2AEDF: malloc (vg_replace_malloc.c:299)\n==899==    by 0x8B68CE7: vasprintf (in /lib64/libc-2.25.so)\n==899==    by 0x55498D2: virVasprintfInternal (virstring.c:708)\n==899==    by 0x55499E7: virAsprintfInternal (virstring.c:729)\n==899==    by 0x2BECFFF0: qemuGetMemoryBackingBasePath (qemu_conf.c:1757)\n==899==    by 0x2BF23225: qemuStateInitialize (qemu_driver.c:893)\n==899==    by 0x563073D: virStateInitialize (libvirt.c:770)\n==899==    by 0x124CC4: daemonRunStateInit (libvirtd.c:834)\n==899==    by 0x55521CD: virThreadHelper (virthread.c:206)\n==899==    by 0x88D9686: start_thread (in /lib64/libpthread-2.25.so)\n==899==    by 0x8BEAEFE: clone (in /lib64/libc-2.25.so)\n\nSigned-off-by: Michal Privoznik <mprivozn@redhat.com>","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/3eb840904a088a89d05821d975ed4624962431f3"}]}
{"actor":{"display_login":"zippy2"}}