{"action":"created","comment":{"url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/pulls/comments/136616409","pull_request_review_id":60184862,"id":136616409,"diff_hunk":"@@ -1867,47 +1866,45 @@ func (appMgr *Manager) recordIngressEvent(ing *v1beta1.Ingress,\n func getEndpointsForService(\n \tportName string,\n \teps *v1.Endpoints,\n-) []string {\n-\tvar ipPorts []string\n+) []Member {\n+\tvar members []Member\n \n \tif eps == nil {\n-\t\treturn ipPorts\n+\t\treturn members\n \t}\n \n \tfor _, subset := range eps.Subsets {\n \t\tfor _, p := range subset.Ports {\n \t\t\tif portName == p.Name {\n-\t\t\t\tport := strconv.Itoa(int(p.Port))\n \t\t\t\tfor _, addr := range subset.Addresses {\n-\t\t\t\t\tvar b bytes.Buffer\n-\t\t\t\t\tb.WriteString(addr.IP)\n-\t\t\t\t\tb.WriteRune(':')\n-\t\t\t\t\tb.WriteString(port)\n-\t\t\t\t\tipPorts = append(ipPorts, b.String())\n+\t\t\t\t\tmember := Member{\n+\t\t\t\t\t\tAddress:    addr.IP,\n+\t\t\t\t\t\tPort:       p.Port,\n+\t\t\t\t\t\tSession:   \"user-enabled\",\n+\t\t\t\t\t}\n+\t\t\t\t\tmembers = append(members, member)\n \t\t\t\t}\n \t\t\t}\n \t\t}\n \t}\n-\tif 0 != len(ipPorts) {\n-\t\tsort.Strings(ipPorts)\n-\t}\n-\treturn ipPorts\n+\treturn members","path":"pkg/appmanager/appManager.go","position":73,"original_position":73,"commit_id":"3e00b2335d5ab1f29fc7d676b1b6d3a52ca66bb4","original_commit_id":"6902590aaca8a34fe975961ca4c5019ee188caf7","user":{"login":"edarzins","id":17910357,"avatar_url":"https://avatars3.githubusercontent.com/u/17910357?v=4","gravatar_id":"","url":"https://api.github.com/users/edarzins","html_url":"https://github.com/edarzins","followers_url":"https://api.github.com/users/edarzins/followers","following_url":"https://api.github.com/users/edarzins/following{/other_user}","gists_url":"https://api.github.com/users/edarzins/gists{/gist_id}","starred_url":"https://api.github.com/users/edarzins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edarzins/subscriptions","organizations_url":"https://api.github.com/users/edarzins/orgs","repos_url":"https://api.github.com/users/edarzins/repos","events_url":"https://api.github.com/users/edarzins/events{/privacy}","received_events_url":"https://api.github.com/users/edarzins/received_events","type":"User","site_admin":false},"body":"Removing the sorting was intentional, it does not matter for CCCL.","created_at":"2017-09-01T16:36:21Z","updated_at":"2017-09-01T16:36:21Z","html_url":"https://github.com/F5Networks/k8s-bigip-ctlr/pull/304#discussion_r136616409","pull_request_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/pulls/304","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/pulls/comments/136616409"},"html":{"href":"https://github.com/F5Networks/k8s-bigip-ctlr/pull/304#discussion_r136616409"},"pull_request":{"href":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/pulls/304"}},"in_reply_to_id":136437923},"pull_request":{"url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/pulls/304","id":138473140,"html_url":"https://github.com/F5Networks/k8s-bigip-ctlr/pull/304","diff_url":"https://github.com/F5Networks/k8s-bigip-ctlr/pull/304.diff","patch_url":"https://github.com/F5Networks/k8s-bigip-ctlr/pull/304.patch","issue_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/issues/304","number":304,"state":"open","locked":false,"title":"CCCL Integration","user":{"login":"edarzins","id":17910357,"avatar_url":"https://avatars3.githubusercontent.com/u/17910357?v=4","gravatar_id":"","url":"https://api.github.com/users/edarzins","html_url":"https://github.com/edarzins","followers_url":"https://api.github.com/users/edarzins/followers","following_url":"https://api.github.com/users/edarzins/following{/other_user}","gists_url":"https://api.github.com/users/edarzins/gists{/gist_id}","starred_url":"https://api.github.com/users/edarzins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edarzins/subscriptions","organizations_url":"https://api.github.com/users/edarzins/orgs","repos_url":"https://api.github.com/users/edarzins/repos","events_url":"https://api.github.com/users/edarzins/events{/privacy}","received_events_url":"https://api.github.com/users/edarzins/received_events","type":"User","site_admin":false},"body":"Moved all of the LTM config creation to the golang frontend, therefore\r\nthe python backend is just a pass-through to CCCL. Updated unit tests\r\ntoo.","created_at":"2017-08-30T16:34:25Z","updated_at":"2017-09-01T16:36:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a1d7ccd33dd1c074e9c32a16a607fb69e0cbfd76","assignee":null,"assignees":[],"requested_reviewers":[{"login":"f5yacobucci","id":21113063,"avatar_url":"https://avatars0.githubusercontent.com/u/21113063?v=4","gravatar_id":"","url":"https://api.github.com/users/f5yacobucci","html_url":"https://github.com/f5yacobucci","followers_url":"https://api.github.com/users/f5yacobucci/followers","following_url":"https://api.github.com/users/f5yacobucci/following{/other_user}","gists_url":"https://api.github.com/users/f5yacobucci/gists{/gist_id}","starred_url":"https://api.github.com/users/f5yacobucci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/f5yacobucci/subscriptions","organizations_url":"https://api.github.com/users/f5yacobucci/orgs","repos_url":"https://api.github.com/users/f5yacobucci/repos","events_url":"https://api.github.com/users/f5yacobucci/events{/privacy}","received_events_url":"https://api.github.com/users/f5yacobucci/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/pulls/304/commits","review_comments_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/pulls/304/comments","review_comment_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/issues/304/comments","statuses_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/statuses/3e00b2335d5ab1f29fc7d676b1b6d3a52ca66bb4","head":{"label":"edarzins:cccl-integration","ref":"cccl-integration","sha":"3e00b2335d5ab1f29fc7d676b1b6d3a52ca66bb4","user":{"login":"edarzins","id":17910357,"avatar_url":"https://avatars3.githubusercontent.com/u/17910357?v=4","gravatar_id":"","url":"https://api.github.com/users/edarzins","html_url":"https://github.com/edarzins","followers_url":"https://api.github.com/users/edarzins/followers","following_url":"https://api.github.com/users/edarzins/following{/other_user}","gists_url":"https://api.github.com/users/edarzins/gists{/gist_id}","starred_url":"https://api.github.com/users/edarzins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edarzins/subscriptions","organizations_url":"https://api.github.com/users/edarzins/orgs","repos_url":"https://api.github.com/users/edarzins/repos","events_url":"https://api.github.com/users/edarzins/events{/privacy}","received_events_url":"https://api.github.com/users/edarzins/received_events","type":"User","site_admin":false},"repo":{"id":96579966,"name":"k8s-bigip-ctlr","full_name":"edarzins/k8s-bigip-ctlr","owner":{"login":"edarzins","id":17910357,"avatar_url":"https://avatars3.githubusercontent.com/u/17910357?v=4","gravatar_id":"","url":"https://api.github.com/users/edarzins","html_url":"https://github.com/edarzins","followers_url":"https://api.github.com/users/edarzins/followers","following_url":"https://api.github.com/users/edarzins/following{/other_user}","gists_url":"https://api.github.com/users/edarzins/gists{/gist_id}","starred_url":"https://api.github.com/users/edarzins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edarzins/subscriptions","organizations_url":"https://api.github.com/users/edarzins/orgs","repos_url":"https://api.github.com/users/edarzins/repos","events_url":"https://api.github.com/users/edarzins/events{/privacy}","received_events_url":"https://api.github.com/users/edarzins/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/edarzins/k8s-bigip-ctlr","description":"Repository for F5 Kubernetes BIG-IP Controller.","fork":true,"url":"https://api.github.com/repos/edarzins/k8s-bigip-ctlr","forks_url":"https://api.github.com/repos/edarzins/k8s-bigip-ctlr/forks","keys_url":"https://api.github.com/repos/edarzins/k8s-bigip-ctlr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edarzins/k8s-bigip-ctlr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edarzins/k8s-bigip-ctlr/teams","hooks_url":"https://api.github.com/repos/edarzins/k8s-bigip-ctlr/hooks","issue_events_url":"https://api.github.com/repos/edarzins/k8s-bigip-ctlr/issues/events{/number}","events_url":"https://api.github.com/repos/edarzins/k8s-bigip-ctlr/events","assignees_url":"https://api.github.com/repos/edarzins/k8s-bigip-ctlr/assignees{/user}","branches_url":"https://api.github.com/repos/edarzins/k8s-bigip-ctlr/branches{/branch}","tags_url":"https://api.github.com/repos/edarzins/k8s-bigip-ctlr/tags","blobs_url":"https://api.github.com/repos/edarzins/k8s-bigip-ctlr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edarzins/k8s-bigip-ctlr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edarzins/k8s-bigip-ctlr/git/refs{/sha}","trees_url":"https://api.github.com/repos/edarzins/k8s-bigip-ctlr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edarzins/k8s-bigip-ctlr/statuses/{sha}","languages_url":"https://api.github.com/repos/edarzins/k8s-bigip-ctlr/languages","stargazers_url":"https://api.github.com/repos/edarzins/k8s-bigip-ctlr/stargazers","contributors_url":"https://api.github.com/repos/edarzins/k8s-bigip-ctlr/contributors","subscribers_url":"https://api.github.com/repos/edarzins/k8s-bigip-ctlr/subscribers","subscription_url":"https://api.github.com/repos/edarzins/k8s-bigip-ctlr/subscription","commits_url":"https://api.github.com/repos/edarzins/k8s-bigip-ctlr/commits{/sha}","git_commits_url":"https://api.github.com/repos/edarzins/k8s-bigip-ctlr/git/commits{/sha}","comments_url":"https://api.github.com/repos/edarzins/k8s-bigip-ctlr/comments{/number}","issue_comment_url":"https://api.github.com/repos/edarzins/k8s-bigip-ctlr/issues/comments{/number}","contents_url":"https://api.github.com/repos/edarzins/k8s-bigip-ctlr/contents/{+path}","compare_url":"https://api.github.com/repos/edarzins/k8s-bigip-ctlr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edarzins/k8s-bigip-ctlr/merges","archive_url":"https://api.github.com/repos/edarzins/k8s-bigip-ctlr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edarzins/k8s-bigip-ctlr/downloads","issues_url":"https://api.github.com/repos/edarzins/k8s-bigip-ctlr/issues{/number}","pulls_url":"https://api.github.com/repos/edarzins/k8s-bigip-ctlr/pulls{/number}","milestones_url":"https://api.github.com/repos/edarzins/k8s-bigip-ctlr/milestones{/number}","notifications_url":"https://api.github.com/repos/edarzins/k8s-bigip-ctlr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edarzins/k8s-bigip-ctlr/labels{/name}","releases_url":"https://api.github.com/repos/edarzins/k8s-bigip-ctlr/releases{/id}","deployments_url":"https://api.github.com/repos/edarzins/k8s-bigip-ctlr/deployments","created_at":"2017-07-07T22:06:29Z","updated_at":"2017-07-07T22:06:31Z","pushed_at":"2017-09-01T06:59:43Z","git_url":"git://github.com/edarzins/k8s-bigip-ctlr.git","ssh_url":"git@github.com:edarzins/k8s-bigip-ctlr.git","clone_url":"https://github.com/edarzins/k8s-bigip-ctlr.git","svn_url":"https://github.com/edarzins/k8s-bigip-ctlr","homepage":null,"size":5656,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"F5Networks:master","ref":"master","sha":"f7a56c2d065d5f750c3707bd5b1a0f2509f1dbef","user":{"login":"F5Networks","id":8935905,"avatar_url":"https://avatars2.githubusercontent.com/u/8935905?v=4","gravatar_id":"","url":"https://api.github.com/users/F5Networks","html_url":"https://github.com/F5Networks","followers_url":"https://api.github.com/users/F5Networks/followers","following_url":"https://api.github.com/users/F5Networks/following{/other_user}","gists_url":"https://api.github.com/users/F5Networks/gists{/gist_id}","starred_url":"https://api.github.com/users/F5Networks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/F5Networks/subscriptions","organizations_url":"https://api.github.com/users/F5Networks/orgs","repos_url":"https://api.github.com/users/F5Networks/repos","events_url":"https://api.github.com/users/F5Networks/events{/privacy}","received_events_url":"https://api.github.com/users/F5Networks/received_events","type":"Organization","site_admin":false},"repo":{"id":84464014,"name":"k8s-bigip-ctlr","full_name":"F5Networks/k8s-bigip-ctlr","owner":{"login":"F5Networks","id":8935905,"avatar_url":"https://avatars2.githubusercontent.com/u/8935905?v=4","gravatar_id":"","url":"https://api.github.com/users/F5Networks","html_url":"https://github.com/F5Networks","followers_url":"https://api.github.com/users/F5Networks/followers","following_url":"https://api.github.com/users/F5Networks/following{/other_user}","gists_url":"https://api.github.com/users/F5Networks/gists{/gist_id}","starred_url":"https://api.github.com/users/F5Networks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/F5Networks/subscriptions","organizations_url":"https://api.github.com/users/F5Networks/orgs","repos_url":"https://api.github.com/users/F5Networks/repos","events_url":"https://api.github.com/users/F5Networks/events{/privacy}","received_events_url":"https://api.github.com/users/F5Networks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/F5Networks/k8s-bigip-ctlr","description":"Repository for F5 BIG-IP Controller for Kubernetes.","fork":false,"url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr","forks_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/forks","keys_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/teams","hooks_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/hooks","issue_events_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/issues/events{/number}","events_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/events","assignees_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/assignees{/user}","branches_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/branches{/branch}","tags_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/tags","blobs_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/git/refs{/sha}","trees_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/statuses/{sha}","languages_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/languages","stargazers_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/stargazers","contributors_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/contributors","subscribers_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/subscribers","subscription_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/subscription","commits_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/commits{/sha}","git_commits_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/git/commits{/sha}","comments_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/comments{/number}","issue_comment_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/issues/comments{/number}","contents_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/contents/{+path}","compare_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/merges","archive_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/downloads","issues_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/issues{/number}","pulls_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/pulls{/number}","milestones_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/milestones{/number}","notifications_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/labels{/name}","releases_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/releases{/id}","deployments_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/deployments","created_at":"2017-03-09T16:24:02Z","updated_at":"2017-08-21T18:40:26Z","pushed_at":"2017-09-01T06:59:44Z","git_url":"git://github.com/F5Networks/k8s-bigip-ctlr.git","ssh_url":"git@github.com:F5Networks/k8s-bigip-ctlr.git","clone_url":"https://github.com/F5Networks/k8s-bigip-ctlr.git","svn_url":"https://github.com/F5Networks/k8s-bigip-ctlr","homepage":"","size":5548,"stargazers_count":17,"watchers_count":17,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":10,"forks":18,"open_issues":10,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/pulls/304"},"html":{"href":"https://github.com/F5Networks/k8s-bigip-ctlr/pull/304"},"issue":{"href":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/issues/304"},"comments":{"href":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/issues/304/comments"},"review_comments":{"href":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/pulls/304/comments"},"review_comment":{"href":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/pulls/304/commits"},"statuses":{"href":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/statuses/3e00b2335d5ab1f29fc7d676b1b6d3a52ca66bb4"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"edarzins"}}