{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/110722970","pull_request_review_id":31915959,"id":110722970,"diff_hunk":"@@ -1497,7 +1497,7 @@ If such a class is used as a base class and if the deriving class defines a dest\n     <value>'{0}' in explicit interface declaration is not an interface</value>\n   </data>\n   <data name=\"ERR_InterfaceMemberNotFound\" xml:space=\"preserve\">\n-    <value>'{0}' in explicit interface declaration is not a member of interface</value>\n+    <value>'{0}' in explicit interface declaration is not found among members of the interface that can be implemented</value>\n   </data>","path":"src/Compilers/CSharp/Portable/CSharpResources.resx","position":6,"original_position":6,"commit_id":"3ba51876137d9eb71dad5192f67ac05c6f9bf09d","original_commit_id":"be6c5094a7074de78fe27c06959cb75a5934ebc8","user":{"login":"AlekseyTs","id":10522107,"avatar_url":"https://avatars3.githubusercontent.com/u/10522107?v=3","gravatar_id":"","url":"https://api.github.com/users/AlekseyTs","html_url":"https://github.com/AlekseyTs","followers_url":"https://api.github.com/users/AlekseyTs/followers","following_url":"https://api.github.com/users/AlekseyTs/following{/other_user}","gists_url":"https://api.github.com/users/AlekseyTs/gists{/gist_id}","starred_url":"https://api.github.com/users/AlekseyTs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlekseyTs/subscriptions","organizations_url":"https://api.github.com/users/AlekseyTs/orgs","repos_url":"https://api.github.com/users/AlekseyTs/repos","events_url":"https://api.github.com/users/AlekseyTs/events{/privacy}","received_events_url":"https://api.github.com/users/AlekseyTs/received_events","type":"User","site_admin":false},"body":"> I agree, given that you now use the same diagnostic for other situations\r\n\r\nWith regard to this error message, I see very little difference in expanding the situation from just static members to non-virtual members in general. The original message was inaccurate for scenarios that could arise before this feature. I didn't make it vague, I made it more accurate, it simply was incorrect for static members and they were allowed. ","created_at":"2017-04-10T18:03:57Z","updated_at":"2017-04-10T18:03:57Z","html_url":"https://github.com/dotnet/roslyn/pull/18519#discussion_r110722970","pull_request_url":"https://api.github.com/repos/dotnet/roslyn/pulls/18519","_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/110722970"},"html":{"href":"https://github.com/dotnet/roslyn/pull/18519#discussion_r110722970"},"pull_request":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/18519"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/18519","id":114713717,"html_url":"https://github.com/dotnet/roslyn/pull/18519","diff_url":"https://github.com/dotnet/roslyn/pull/18519.diff","patch_url":"https://github.com/dotnet/roslyn/pull/18519.patch","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/18519","number":18519,"state":"open","locked":false,"title":"Support public, internal, private, static, virtual, sealed, abstract, extern and async modifiers with interface methods.","user":{"login":"AlekseyTs","id":10522107,"avatar_url":"https://avatars3.githubusercontent.com/u/10522107?v=3","gravatar_id":"","url":"https://api.github.com/users/AlekseyTs","html_url":"https://github.com/AlekseyTs","followers_url":"https://api.github.com/users/AlekseyTs/followers","following_url":"https://api.github.com/users/AlekseyTs/following{/other_user}","gists_url":"https://api.github.com/users/AlekseyTs/gists{/gist_id}","starred_url":"https://api.github.com/users/AlekseyTs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlekseyTs/subscriptions","organizations_url":"https://api.github.com/users/AlekseyTs/orgs","repos_url":"https://api.github.com/users/AlekseyTs/repos","events_url":"https://api.github.com/users/AlekseyTs/events{/privacy}","received_events_url":"https://api.github.com/users/AlekseyTs/received_events","type":"User","site_admin":false},"body":"@dotnet/roslyn-compiler Please review.","created_at":"2017-04-06T23:03:54Z","updated_at":"2017-04-10T18:03:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"753d154398ce9857699c8ff38f34074f717cb32b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/roslyn/pulls/18519/commits","review_comments_url":"https://api.github.com/repos/dotnet/roslyn/pulls/18519/comments","review_comment_url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/18519/comments","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/3ba51876137d9eb71dad5192f67ac05c6f9bf09d","head":{"label":"AlekseyTs:DII_MethodModifiers","ref":"DII_MethodModifiers","sha":"3ba51876137d9eb71dad5192f67ac05c6f9bf09d","user":{"login":"AlekseyTs","id":10522107,"avatar_url":"https://avatars3.githubusercontent.com/u/10522107?v=3","gravatar_id":"","url":"https://api.github.com/users/AlekseyTs","html_url":"https://github.com/AlekseyTs","followers_url":"https://api.github.com/users/AlekseyTs/followers","following_url":"https://api.github.com/users/AlekseyTs/following{/other_user}","gists_url":"https://api.github.com/users/AlekseyTs/gists{/gist_id}","starred_url":"https://api.github.com/users/AlekseyTs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlekseyTs/subscriptions","organizations_url":"https://api.github.com/users/AlekseyTs/orgs","repos_url":"https://api.github.com/users/AlekseyTs/repos","events_url":"https://api.github.com/users/AlekseyTs/events{/privacy}","received_events_url":"https://api.github.com/users/AlekseyTs/received_events","type":"User","site_admin":false},"repo":{"id":32701567,"name":"roslyn","full_name":"AlekseyTs/roslyn","owner":{"login":"AlekseyTs","id":10522107,"avatar_url":"https://avatars3.githubusercontent.com/u/10522107?v=3","gravatar_id":"","url":"https://api.github.com/users/AlekseyTs","html_url":"https://github.com/AlekseyTs","followers_url":"https://api.github.com/users/AlekseyTs/followers","following_url":"https://api.github.com/users/AlekseyTs/following{/other_user}","gists_url":"https://api.github.com/users/AlekseyTs/gists{/gist_id}","starred_url":"https://api.github.com/users/AlekseyTs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlekseyTs/subscriptions","organizations_url":"https://api.github.com/users/AlekseyTs/orgs","repos_url":"https://api.github.com/users/AlekseyTs/repos","events_url":"https://api.github.com/users/AlekseyTs/events{/privacy}","received_events_url":"https://api.github.com/users/AlekseyTs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AlekseyTs/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":true,"url":"https://api.github.com/repos/AlekseyTs/roslyn","forks_url":"https://api.github.com/repos/AlekseyTs/roslyn/forks","keys_url":"https://api.github.com/repos/AlekseyTs/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AlekseyTs/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AlekseyTs/roslyn/teams","hooks_url":"https://api.github.com/repos/AlekseyTs/roslyn/hooks","issue_events_url":"https://api.github.com/repos/AlekseyTs/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/AlekseyTs/roslyn/events","assignees_url":"https://api.github.com/repos/AlekseyTs/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/AlekseyTs/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/AlekseyTs/roslyn/tags","blobs_url":"https://api.github.com/repos/AlekseyTs/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AlekseyTs/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AlekseyTs/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/AlekseyTs/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AlekseyTs/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/AlekseyTs/roslyn/languages","stargazers_url":"https://api.github.com/repos/AlekseyTs/roslyn/stargazers","contributors_url":"https://api.github.com/repos/AlekseyTs/roslyn/contributors","subscribers_url":"https://api.github.com/repos/AlekseyTs/roslyn/subscribers","subscription_url":"https://api.github.com/repos/AlekseyTs/roslyn/subscription","commits_url":"https://api.github.com/repos/AlekseyTs/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/AlekseyTs/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/AlekseyTs/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/AlekseyTs/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/AlekseyTs/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/AlekseyTs/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AlekseyTs/roslyn/merges","archive_url":"https://api.github.com/repos/AlekseyTs/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AlekseyTs/roslyn/downloads","issues_url":"https://api.github.com/repos/AlekseyTs/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/AlekseyTs/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/AlekseyTs/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/AlekseyTs/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AlekseyTs/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/AlekseyTs/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/AlekseyTs/roslyn/deployments","created_at":"2015-03-22T23:43:35Z","updated_at":"2016-01-27T17:38:54Z","pushed_at":"2017-04-10T17:41:55Z","git_url":"git://github.com/AlekseyTs/roslyn.git","ssh_url":"git@github.com:AlekseyTs/roslyn.git","clone_url":"https://github.com/AlekseyTs/roslyn.git","svn_url":"https://github.com/AlekseyTs/roslyn","homepage":"","size":202286,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:features/DefaultInterfaceImplementation","ref":"features/DefaultInterfaceImplementation","sha":"0814ad1eedd5ab2b92e69e971df8d35f66e6598f","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars3.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":29078997,"name":"roslyn","full_name":"dotnet/roslyn","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars3.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":false,"url":"https://api.github.com/repos/dotnet/roslyn","forks_url":"https://api.github.com/repos/dotnet/roslyn/forks","keys_url":"https://api.github.com/repos/dotnet/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/roslyn/teams","hooks_url":"https://api.github.com/repos/dotnet/roslyn/hooks","issue_events_url":"https://api.github.com/repos/dotnet/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/roslyn/events","assignees_url":"https://api.github.com/repos/dotnet/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/roslyn/tags","blobs_url":"https://api.github.com/repos/dotnet/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/roslyn/languages","stargazers_url":"https://api.github.com/repos/dotnet/roslyn/stargazers","contributors_url":"https://api.github.com/repos/dotnet/roslyn/contributors","subscribers_url":"https://api.github.com/repos/dotnet/roslyn/subscribers","subscription_url":"https://api.github.com/repos/dotnet/roslyn/subscription","commits_url":"https://api.github.com/repos/dotnet/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/roslyn/merges","archive_url":"https://api.github.com/repos/dotnet/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/roslyn/downloads","issues_url":"https://api.github.com/repos/dotnet/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/roslyn/deployments","created_at":"2015-01-11T02:39:03Z","updated_at":"2017-04-10T16:59:32Z","pushed_at":"2017-04-10T18:01:40Z","git_url":"git://github.com/dotnet/roslyn.git","ssh_url":"git@github.com:dotnet/roslyn.git","clone_url":"https://github.com/dotnet/roslyn.git","svn_url":"https://github.com/dotnet/roslyn","homepage":"","size":208950,"stargazers_count":7351,"watchers_count":7351,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1773,"mirror_url":null,"open_issues_count":3482,"forks":1773,"open_issues":3482,"watchers":7351,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/18519"},"html":{"href":"https://github.com/dotnet/roslyn/pull/18519"},"issue":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/18519"},"comments":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/18519/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/18519/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/18519/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/roslyn/statuses/3ba51876137d9eb71dad5192f67ac05c6f9bf09d"}}}}
{"actor":{"display_login":"AlekseyTs"}}