{"action":"created","issue":{"url":"https://api.github.com/repos/guardian/frontend/issues/18262","repository_url":"https://api.github.com/repos/guardian/frontend","labels_url":"https://api.github.com/repos/guardian/frontend/issues/18262/labels{/name}","comments_url":"https://api.github.com/repos/guardian/frontend/issues/18262/comments","events_url":"https://api.github.com/repos/guardian/frontend/issues/18262/events","html_url":"https://github.com/guardian/frontend/pull/18262","id":274849123,"number":18262,"title":"Refactor newsletter switch scala template","user":{"login":"walaura","id":11539094,"avatar_url":"https://avatars1.githubusercontent.com/u/11539094?v=4","gravatar_id":"","url":"https://api.github.com/users/walaura","html_url":"https://github.com/walaura","followers_url":"https://api.github.com/users/walaura/followers","following_url":"https://api.github.com/users/walaura/following{/other_user}","gists_url":"https://api.github.com/users/walaura/gists{/gist_id}","starred_url":"https://api.github.com/users/walaura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/walaura/subscriptions","organizations_url":"https://api.github.com/users/walaura/orgs","repos_url":"https://api.github.com/users/walaura/repos","events_url":"https://api.github.com/users/walaura/events{/privacy}","received_events_url":"https://api.github.com/users/walaura/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-11-17T12:25:25Z","updated_at":"2017-11-17T12:32:24Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/guardian/frontend/pulls/18262","html_url":"https://github.com/guardian/frontend/pull/18262","diff_url":"https://github.com/guardian/frontend/pull/18262.diff","patch_url":"https://github.com/guardian/frontend/pull/18262.patch"},"body":"## What does this change?\r\nSplits newsletter-related `switch.scala.html` functionality into a separate `switchnewsletter.scala.html` view that only takes a newsletter as a parameter, keeping the signature on the main switch cleaner and free of newsletter-related code\r\n\r\n## What is the value of this and can you measure success?\r\nClaner code. Plus, more importantly, fixes a bug where the \"See latest email\" link not working\r\n\r\n## Does this affect other platforms - Amp, Apps, etc?\r\nNo\r\n\r\n## Does this affect GLabs Paid Content Pages? Should it have support for Paid Content?\r\nNo \r\n\r\n## Screenshots\r\nN/A\r\n\r\n## Tested in CODE?\r\nNo\r\n"},"comment":{"url":"https://api.github.com/repos/guardian/frontend/issues/comments/345232169","html_url":"https://github.com/guardian/frontend/pull/18262#issuecomment-345232169","issue_url":"https://api.github.com/repos/guardian/frontend/issues/18262","id":345232169,"user":{"login":"PRBuilds","id":25033946,"avatar_url":"https://avatars2.githubusercontent.com/u/25033946?v=4","gravatar_id":"","url":"https://api.github.com/users/PRBuilds","html_url":"https://github.com/PRBuilds","followers_url":"https://api.github.com/users/PRBuilds/followers","following_url":"https://api.github.com/users/PRBuilds/following{/other_user}","gists_url":"https://api.github.com/users/PRBuilds/gists{/gist_id}","starred_url":"https://api.github.com/users/PRBuilds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PRBuilds/subscriptions","organizations_url":"https://api.github.com/users/PRBuilds/orgs","repos_url":"https://api.github.com/users/PRBuilds/repos","events_url":"https://api.github.com/users/PRBuilds/events{/privacy}","received_events_url":"https://api.github.com/users/PRBuilds/received_events","type":"User","site_admin":false},"created_at":"2017-11-17T12:32:24Z","updated_at":"2017-11-17T12:32:24Z","author_association":"NONE","body":"\n\nPRbuilds results:\n\n\n**Screenshots**\n[desktop.png](https://s3-eu-west-1.amazonaws.com/prbuilds/PR-18262/screenshots/books%252F2014%252Fmay%252F21%252Fguardian-journalists-jonathan-freedland-ghaith-abdul-ahad-win-orwell-prize-journalism/desktop.png) • [tablet.png](https://s3-eu-west-1.amazonaws.com/prbuilds/PR-18262/screenshots/books%252F2014%252Fmay%252F21%252Fguardian-journalists-jonathan-freedland-ghaith-abdul-ahad-win-orwell-prize-journalism/tablet.png) • [mobile.png](https://s3-eu-west-1.amazonaws.com/prbuilds/PR-18262/screenshots/books%252F2014%252Fmay%252F21%252Fguardian-journalists-jonathan-freedland-ghaith-abdul-ahad-win-orwell-prize-journalism/mobile.png) • [wide.png](https://s3-eu-west-1.amazonaws.com/prbuilds/PR-18262/screenshots/books%252F2014%252Fmay%252F21%252Fguardian-journalists-jonathan-freedland-ghaith-abdul-ahad-win-orwell-prize-journalism/wide.png)\n\n\n\n&#x1F49A; **Exceptions**\n[thrown-exceptions.js](https://s3-eu-west-1.amazonaws.com/prbuilds/PR-18262/thrown-exceptions.js)\n\n\n\n\n\n&#x1F49A; **A11y validation**\n[a11y-report.txt](https://s3-eu-west-1.amazonaws.com/prbuilds/PR-18262/a11y-report.txt)\n\n\n\n**Apache Benchmark Load Testing**\n[loadtesting.txt](https://s3-eu-west-1.amazonaws.com/prbuilds/PR-18262/loadtesting.txt)\n\n\n\n&#x1F49A; **Microdata Validation**\n[microdata.txt](https://s3-eu-west-1.amazonaws.com/prbuilds/PR-18262/microdata.txt)\n\n    \n--automated message"}}
{"actor":{"display_login":"PRBuilds"}}