{"action":"created","issue":{"url":"https://api.github.com/repos/elastic/elasticsearch/issues/23884","repository_url":"https://api.github.com/repos/elastic/elasticsearch","labels_url":"https://api.github.com/repos/elastic/elasticsearch/issues/23884/labels{/name}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/issues/23884/comments","events_url":"https://api.github.com/repos/elastic/elasticsearch/issues/23884/events","html_url":"https://github.com/elastic/elasticsearch/pull/23884","id":219041553,"number":23884,"title":"Automatically adjust search threadpool queue_size","user":{"login":"dakrone","id":19060,"avatar_url":"https://avatars0.githubusercontent.com/u/19060?v=3","gravatar_id":"","url":"https://api.github.com/users/dakrone","html_url":"https://github.com/dakrone","followers_url":"https://api.github.com/users/dakrone/followers","following_url":"https://api.github.com/users/dakrone/following{/other_user}","gists_url":"https://api.github.com/users/dakrone/gists{/gist_id}","starred_url":"https://api.github.com/users/dakrone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dakrone/subscriptions","organizations_url":"https://api.github.com/users/dakrone/orgs","repos_url":"https://api.github.com/users/dakrone/repos","events_url":"https://api.github.com/users/dakrone/events{/privacy}","received_events_url":"https://api.github.com/users/dakrone/received_events","type":"User","site_admin":false},"labels":[{"id":184103632,"url":"https://api.github.com/repos/elastic/elasticsearch/labels/:Internal","name":":Internal","color":"009800","default":false},{"id":146832564,"url":"https://api.github.com/repos/elastic/elasticsearch/labels/:Search","name":":Search","color":"009800","default":false},{"id":23172,"url":"https://api.github.com/repos/elastic/elasticsearch/labels/feature","name":"feature","color":"328a58","default":false},{"id":334286612,"url":"https://api.github.com/repos/elastic/elasticsearch/labels/v6.0.0","name":"v6.0.0","color":"dddddd","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":15,"created_at":"2017-04-03T19:47:37Z","updated_at":"2017-05-02T17:09:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/23884","html_url":"https://github.com/elastic/elasticsearch/pull/23884","diff_url":"https://github.com/elastic/elasticsearch/pull/23884.diff","patch_url":"https://github.com/elastic/elasticsearch/pull/23884.patch"},"body":"This PR adds a new thread pool type: `fixed_auto_queue_size`. This thread pool\r\nbehaves like a regular `fixed` threadpool, except that every\r\n`auto_queue_frame_size` operations (default: 10,000) in the thread pool,\r\n[Little's Law](https://en.wikipedia.org/wiki/Little's_law) is calculated and\r\nused to adjust the pool's `queue_size` either up or down by 25. A minimum and\r\nmaximum is taken into account also.\r\n\r\nThe `SEARCH` threadpool is changed to use this new type of thread pool.\r\n\r\nRelates to #3890"},"comment":{"url":"https://api.github.com/repos/elastic/elasticsearch/issues/comments/298698833","html_url":"https://github.com/elastic/elasticsearch/pull/23884#issuecomment-298698833","issue_url":"https://api.github.com/repos/elastic/elasticsearch/issues/23884","id":298698833,"user":{"login":"ppf2","id":7216393,"avatar_url":"https://avatars3.githubusercontent.com/u/7216393?v=3","gravatar_id":"","url":"https://api.github.com/users/ppf2","html_url":"https://github.com/ppf2","followers_url":"https://api.github.com/users/ppf2/followers","following_url":"https://api.github.com/users/ppf2/following{/other_user}","gists_url":"https://api.github.com/users/ppf2/gists{/gist_id}","starred_url":"https://api.github.com/users/ppf2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ppf2/subscriptions","organizations_url":"https://api.github.com/users/ppf2/orgs","repos_url":"https://api.github.com/users/ppf2/repos","events_url":"https://api.github.com/users/ppf2/events{/privacy}","received_events_url":"https://api.github.com/users/ppf2/received_events","type":"User","site_admin":false},"created_at":"2017-05-02T17:09:44Z","updated_at":"2017-05-02T17:09:44Z","body":"Good stuff!  It’s promising that you found an alt-alt implementation that is showing improvements :slightly_smiling_face:  I think the target response rate is a reasonable configuration for those who really want to use it, and since this is intended to address a specific problem for the high volume search use cases only, we can make it an opt-in thing if we can’t find a good default.  What would happen if someone sets an overly aggressive target response rate (much lower than their actual avg query processing time).  I am assuming it will just cause a lot more search rejections than the default queue size?  We may also want to rename the target_response_rate to something else (so we don't have admins set it to a number thinking that it will give them the response rate they are looking for :P)."}}
{"actor":{"display_login":"ppf2"}}