{"action":"created","issue":{"url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/issues/727","repository_url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams","labels_url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/issues/727/labels{/name}","comments_url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/issues/727/comments","events_url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/issues/727/events","html_url":"https://github.com/rails-girls-summer-of-code/rgsoc-teams/pull/727","id":218733070,"number":727,"title":"Refactor ApplicationData","user":{"login":"beanieboi","id":29251,"avatar_url":"https://avatars2.githubusercontent.com/u/29251?v=3","gravatar_id":"","url":"https://api.github.com/users/beanieboi","html_url":"https://github.com/beanieboi","followers_url":"https://api.github.com/users/beanieboi/followers","following_url":"https://api.github.com/users/beanieboi/following{/other_user}","gists_url":"https://api.github.com/users/beanieboi/gists{/gist_id}","starred_url":"https://api.github.com/users/beanieboi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beanieboi/subscriptions","organizations_url":"https://api.github.com/users/beanieboi/orgs","repos_url":"https://api.github.com/users/beanieboi/repos","events_url":"https://api.github.com/users/beanieboi/events{/privacy}","received_events_url":"https://api.github.com/users/beanieboi/received_events","type":"User","site_admin":false},"labels":[{"id":119759525,"url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"state":"open","locked":false,"assignee":{"login":"beanieboi","id":29251,"avatar_url":"https://avatars2.githubusercontent.com/u/29251?v=3","gravatar_id":"","url":"https://api.github.com/users/beanieboi","html_url":"https://github.com/beanieboi","followers_url":"https://api.github.com/users/beanieboi/followers","following_url":"https://api.github.com/users/beanieboi/following{/other_user}","gists_url":"https://api.github.com/users/beanieboi/gists{/gist_id}","starred_url":"https://api.github.com/users/beanieboi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beanieboi/subscriptions","organizations_url":"https://api.github.com/users/beanieboi/orgs","repos_url":"https://api.github.com/users/beanieboi/repos","events_url":"https://api.github.com/users/beanieboi/events{/privacy}","received_events_url":"https://api.github.com/users/beanieboi/received_events","type":"User","site_admin":false},"assignees":[{"login":"beanieboi","id":29251,"avatar_url":"https://avatars2.githubusercontent.com/u/29251?v=3","gravatar_id":"","url":"https://api.github.com/users/beanieboi","html_url":"https://github.com/beanieboi","followers_url":"https://api.github.com/users/beanieboi/followers","following_url":"https://api.github.com/users/beanieboi/following{/other_user}","gists_url":"https://api.github.com/users/beanieboi/gists{/gist_id}","starred_url":"https://api.github.com/users/beanieboi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beanieboi/subscriptions","organizations_url":"https://api.github.com/users/beanieboi/orgs","repos_url":"https://api.github.com/users/beanieboi/repos","events_url":"https://api.github.com/users/beanieboi/events{/privacy}","received_events_url":"https://api.github.com/users/beanieboi/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2017-04-02T00:46:28Z","updated_at":"2017-04-08T10:20:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/pulls/727","html_url":"https://github.com/rails-girls-summer-of-code/rgsoc-teams/pull/727","diff_url":"https://github.com/rails-girls-summer-of-code/rgsoc-teams/pull/727.diff","patch_url":"https://github.com/rails-girls-summer-of-code/rgsoc-teams/pull/727.patch"},"body":"This is meant as proof of concept. I started extracting application_data into it's own class.\r\nRight now we just pass the hash around, which has a couple of drawbacks. We treat it like an AR Model but we are leaking the everywhere.\r\nThis introduce an API for ApplicationData which is easier to extend and maintain. It also brings us halfway to extracting application data into it's own AR model. \r\n\r\nit does not implement the setters yet. if we want to change application data, we still have to use the hash methods. Any input on that is appreciated. \r\n\r\nWhat do you think about the direction we are heading here?"},"comment":{"url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/issues/comments/292708811","html_url":"https://github.com/rails-girls-summer-of-code/rgsoc-teams/pull/727#issuecomment-292708811","issue_url":"https://api.github.com/repos/rails-girls-summer-of-code/rgsoc-teams/issues/727","id":292708811,"user":{"login":"klappradla","id":3491815,"avatar_url":"https://avatars0.githubusercontent.com/u/3491815?v=3","gravatar_id":"","url":"https://api.github.com/users/klappradla","html_url":"https://github.com/klappradla","followers_url":"https://api.github.com/users/klappradla/followers","following_url":"https://api.github.com/users/klappradla/following{/other_user}","gists_url":"https://api.github.com/users/klappradla/gists{/gist_id}","starred_url":"https://api.github.com/users/klappradla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klappradla/subscriptions","organizations_url":"https://api.github.com/users/klappradla/orgs","repos_url":"https://api.github.com/users/klappradla/repos","events_url":"https://api.github.com/users/klappradla/events{/privacy}","received_events_url":"https://api.github.com/users/klappradla/received_events","type":"User","site_admin":false},"created_at":"2017-04-08T10:20:27Z","updated_at":"2017-04-08T10:20:27Z","body":"Any objections for merging this? I think it's a nice improvement _(even reducing technical dept I'd say)_ with no impact on functionality, so I'd go for it 🚢 "}}
{"actor":{"display_login":"klappradla"}}