{"action":"created","comment":{"url":"https://api.github.com/repos/percona/percona-xtradb-cluster/pulls/comments/134138380","pull_request_review_id":57395153,"id":134138380,"diff_hunk":"@@ -1546,6 +1550,33 @@ then\n     parse_sst_info \"$sst_file_info_path\" sst galera-gtid \"\" > \"$XB_GTID_INFO_FILE_PATH\"\n \n     DONOR_BINLOGNAME=$(parse_sst_info \"$sst_file_info_path\" sst binlog-name \"\")\n+    DONOR_MYSQL_VERSION=$(parse_sst_info \"$sst_file_info_path\" sst mysql-version \"\")\n+\n+    if [[ -n \"$DONOR_MYSQL_VERSION\" ]]; then\n+        local_version_str=\"\"\n+        donor_version_str=\"\"\n+\n+        # Truncate the version numbers (we want the major.minor version like \"5.6\", not \"5.6.35-...\")\n+        local_version_str=$(expr match \"$MYSQL_VERSION\" '\\([0-9]\\+\\.[0-9]\\+\\)')\n+        donor_version_str=$(expr match \"$DONOR_MYSQL_VERSION\" '\\([0-9]\\+\\.[0-9]\\+\\)')\n+\n+        # Is this node's pxc version < donor's pxc version?\n+        if ! check_for_version $local_version_str $donor_version_str; then\n+            wsrep_log_error \"******************* FATAL ERROR ********************** \"\n+            wsrep_log_error \"FATAL: PXC is receiving an SST from a node with a higher version.\"\n+            wsrep_log_error \"This node's PXC version is $local_version_str.  The donor's PXC version is $donor_version_str.\"\n+            wsrep_log_error \"Upgrade this node before joining the cluster.\"\n+            wsrep_log_error \"****************************************************** \"\n+            exit 2\n+        fi\n+\n+        # Is the donor's pxc version < this node's pxc version?\n+        if ! check_for_version $donor_version_str $local_version_str; then\n+            wsrep_log_warning \"WARNING: PXC is receiving an SST from a node with a lower version.\"\n+            wsrep_log_warning \"This node's PXC version is $local_version_str. The donor's PXC version is $donor_version_str.\"\n+            wsrep_log_warning \"Run mysql_upgrade to upgrade the data.\"","path":"scripts/wsrep_sst_xtrabackup-v2.sh","position":55,"original_position":55,"commit_id":"f7729e6f1e05e9dcf63aaaf9baa58061ad049101","original_commit_id":"f7729e6f1e05e9dcf63aaaf9baa58061ad049101","user":{"login":"kbauskar","id":14107301,"avatar_url":"https://avatars3.githubusercontent.com/u/14107301?v=4","gravatar_id":"","url":"https://api.github.com/users/kbauskar","html_url":"https://github.com/kbauskar","followers_url":"https://api.github.com/users/kbauskar/followers","following_url":"https://api.github.com/users/kbauskar/following{/other_user}","gists_url":"https://api.github.com/users/kbauskar/gists{/gist_id}","starred_url":"https://api.github.com/users/kbauskar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbauskar/subscriptions","organizations_url":"https://api.github.com/users/kbauskar/orgs","repos_url":"https://api.github.com/users/kbauskar/repos","events_url":"https://api.github.com/users/kbauskar/events{/privacy}","received_events_url":"https://api.github.com/users/kbauskar/received_events","type":"User","site_admin":false},"body":"I assume you have tried the upgrade process manually and ensured that post SST data-dir copy-over mysql_upgrade works ?","created_at":"2017-08-21T02:59:20Z","updated_at":"2017-08-21T02:59:32Z","html_url":"https://github.com/percona/percona-xtradb-cluster/pull/509#discussion_r134138380","pull_request_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/pulls/509","_links":{"self":{"href":"https://api.github.com/repos/percona/percona-xtradb-cluster/pulls/comments/134138380"},"html":{"href":"https://github.com/percona/percona-xtradb-cluster/pull/509#discussion_r134138380"},"pull_request":{"href":"https://api.github.com/repos/percona/percona-xtradb-cluster/pulls/509"}}},"pull_request":{"url":"https://api.github.com/repos/percona/percona-xtradb-cluster/pulls/509","id":136596824,"html_url":"https://github.com/percona/percona-xtradb-cluster/pull/509","diff_url":"https://github.com/percona/percona-xtradb-cluster/pull/509.diff","patch_url":"https://github.com/percona/percona-xtradb-cluster/pull/509.patch","issue_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/issues/509","number":509,"state":"open","locked":false,"title":"PXC-851: Avoid doing SST from lower version (5.7 node trying to get S…","user":{"login":"kennt-percona","id":17353217,"avatar_url":"https://avatars3.githubusercontent.com/u/17353217?v=4","gravatar_id":"","url":"https://api.github.com/users/kennt-percona","html_url":"https://github.com/kennt-percona","followers_url":"https://api.github.com/users/kennt-percona/followers","following_url":"https://api.github.com/users/kennt-percona/following{/other_user}","gists_url":"https://api.github.com/users/kennt-percona/gists{/gist_id}","starred_url":"https://api.github.com/users/kennt-percona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kennt-percona/subscriptions","organizations_url":"https://api.github.com/users/kennt-percona/orgs","repos_url":"https://api.github.com/users/kennt-percona/repos","events_url":"https://api.github.com/users/kennt-percona/events{/privacy}","received_events_url":"https://api.github.com/users/kennt-percona/received_events","type":"User","site_admin":false},"body":"…ST from 5.6)\r\n\r\nIssue:\r\nCurrently, PXC does not check the versions between the donor and the joiner.\r\nThus, we will clean the datadir and then receive the donor's datadir which will\r\nprobably be incompatible (thus erasing the datadir for no good reason).\r\n\r\nSolution:\r\nPass the version from the donor to the joiner and let the joiner reject\r\nthe SST if the version is a higher version.","created_at":"2017-08-19T07:09:24Z","updated_at":"2017-08-21T02:59:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b9ae7cfcf3a8950fd780a74fffd8b1d3d46dffc8","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/pulls/509/commits","review_comments_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/pulls/509/comments","review_comment_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/pulls/comments{/number}","comments_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/issues/509/comments","statuses_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/statuses/f7729e6f1e05e9dcf63aaaf9baa58061ad049101","head":{"label":"kennt-percona:5.7-pxc-851","ref":"5.7-pxc-851","sha":"f7729e6f1e05e9dcf63aaaf9baa58061ad049101","user":{"login":"kennt-percona","id":17353217,"avatar_url":"https://avatars3.githubusercontent.com/u/17353217?v=4","gravatar_id":"","url":"https://api.github.com/users/kennt-percona","html_url":"https://github.com/kennt-percona","followers_url":"https://api.github.com/users/kennt-percona/followers","following_url":"https://api.github.com/users/kennt-percona/following{/other_user}","gists_url":"https://api.github.com/users/kennt-percona/gists{/gist_id}","starred_url":"https://api.github.com/users/kennt-percona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kennt-percona/subscriptions","organizations_url":"https://api.github.com/users/kennt-percona/orgs","repos_url":"https://api.github.com/users/kennt-percona/repos","events_url":"https://api.github.com/users/kennt-percona/events{/privacy}","received_events_url":"https://api.github.com/users/kennt-percona/received_events","type":"User","site_admin":false},"repo":{"id":54433422,"name":"percona-xtradb-cluster","full_name":"kennt-percona/percona-xtradb-cluster","owner":{"login":"kennt-percona","id":17353217,"avatar_url":"https://avatars3.githubusercontent.com/u/17353217?v=4","gravatar_id":"","url":"https://api.github.com/users/kennt-percona","html_url":"https://github.com/kennt-percona","followers_url":"https://api.github.com/users/kennt-percona/followers","following_url":"https://api.github.com/users/kennt-percona/following{/other_user}","gists_url":"https://api.github.com/users/kennt-percona/gists{/gist_id}","starred_url":"https://api.github.com/users/kennt-percona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kennt-percona/subscriptions","organizations_url":"https://api.github.com/users/kennt-percona/orgs","repos_url":"https://api.github.com/users/kennt-percona/repos","events_url":"https://api.github.com/users/kennt-percona/events{/privacy}","received_events_url":"https://api.github.com/users/kennt-percona/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kennt-percona/percona-xtradb-cluster","description":"A High Scalability Solution for MySQL Clustering and High Availability","fork":true,"url":"https://api.github.com/repos/kennt-percona/percona-xtradb-cluster","forks_url":"https://api.github.com/repos/kennt-percona/percona-xtradb-cluster/forks","keys_url":"https://api.github.com/repos/kennt-percona/percona-xtradb-cluster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kennt-percona/percona-xtradb-cluster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kennt-percona/percona-xtradb-cluster/teams","hooks_url":"https://api.github.com/repos/kennt-percona/percona-xtradb-cluster/hooks","issue_events_url":"https://api.github.com/repos/kennt-percona/percona-xtradb-cluster/issues/events{/number}","events_url":"https://api.github.com/repos/kennt-percona/percona-xtradb-cluster/events","assignees_url":"https://api.github.com/repos/kennt-percona/percona-xtradb-cluster/assignees{/user}","branches_url":"https://api.github.com/repos/kennt-percona/percona-xtradb-cluster/branches{/branch}","tags_url":"https://api.github.com/repos/kennt-percona/percona-xtradb-cluster/tags","blobs_url":"https://api.github.com/repos/kennt-percona/percona-xtradb-cluster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kennt-percona/percona-xtradb-cluster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kennt-percona/percona-xtradb-cluster/git/refs{/sha}","trees_url":"https://api.github.com/repos/kennt-percona/percona-xtradb-cluster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kennt-percona/percona-xtradb-cluster/statuses/{sha}","languages_url":"https://api.github.com/repos/kennt-percona/percona-xtradb-cluster/languages","stargazers_url":"https://api.github.com/repos/kennt-percona/percona-xtradb-cluster/stargazers","contributors_url":"https://api.github.com/repos/kennt-percona/percona-xtradb-cluster/contributors","subscribers_url":"https://api.github.com/repos/kennt-percona/percona-xtradb-cluster/subscribers","subscription_url":"https://api.github.com/repos/kennt-percona/percona-xtradb-cluster/subscription","commits_url":"https://api.github.com/repos/kennt-percona/percona-xtradb-cluster/commits{/sha}","git_commits_url":"https://api.github.com/repos/kennt-percona/percona-xtradb-cluster/git/commits{/sha}","comments_url":"https://api.github.com/repos/kennt-percona/percona-xtradb-cluster/comments{/number}","issue_comment_url":"https://api.github.com/repos/kennt-percona/percona-xtradb-cluster/issues/comments{/number}","contents_url":"https://api.github.com/repos/kennt-percona/percona-xtradb-cluster/contents/{+path}","compare_url":"https://api.github.com/repos/kennt-percona/percona-xtradb-cluster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kennt-percona/percona-xtradb-cluster/merges","archive_url":"https://api.github.com/repos/kennt-percona/percona-xtradb-cluster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kennt-percona/percona-xtradb-cluster/downloads","issues_url":"https://api.github.com/repos/kennt-percona/percona-xtradb-cluster/issues{/number}","pulls_url":"https://api.github.com/repos/kennt-percona/percona-xtradb-cluster/pulls{/number}","milestones_url":"https://api.github.com/repos/kennt-percona/percona-xtradb-cluster/milestones{/number}","notifications_url":"https://api.github.com/repos/kennt-percona/percona-xtradb-cluster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kennt-percona/percona-xtradb-cluster/labels{/name}","releases_url":"https://api.github.com/repos/kennt-percona/percona-xtradb-cluster/releases{/id}","deployments_url":"https://api.github.com/repos/kennt-percona/percona-xtradb-cluster/deployments","created_at":"2016-03-22T00:42:34Z","updated_at":"2016-03-22T00:44:07Z","pushed_at":"2017-08-21T01:10:00Z","git_url":"git://github.com/kennt-percona/percona-xtradb-cluster.git","ssh_url":"git@github.com:kennt-percona/percona-xtradb-cluster.git","clone_url":"https://github.com/kennt-percona/percona-xtradb-cluster.git","svn_url":"https://github.com/kennt-percona/percona-xtradb-cluster","homepage":"http://www.percona.com/software/percona-xtradb-cluster","size":560838,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"5.6"}},"base":{"label":"percona:5.7","ref":"5.7","sha":"2cf225b74e6391de97bff922f9853698a03f5af7","user":{"login":"percona","id":1683025,"avatar_url":"https://avatars0.githubusercontent.com/u/1683025?v=4","gravatar_id":"","url":"https://api.github.com/users/percona","html_url":"https://github.com/percona","followers_url":"https://api.github.com/users/percona/followers","following_url":"https://api.github.com/users/percona/following{/other_user}","gists_url":"https://api.github.com/users/percona/gists{/gist_id}","starred_url":"https://api.github.com/users/percona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/percona/subscriptions","organizations_url":"https://api.github.com/users/percona/orgs","repos_url":"https://api.github.com/users/percona/repos","events_url":"https://api.github.com/users/percona/events{/privacy}","received_events_url":"https://api.github.com/users/percona/received_events","type":"Organization","site_admin":false},"repo":{"id":30753937,"name":"percona-xtradb-cluster","full_name":"percona/percona-xtradb-cluster","owner":{"login":"percona","id":1683025,"avatar_url":"https://avatars0.githubusercontent.com/u/1683025?v=4","gravatar_id":"","url":"https://api.github.com/users/percona","html_url":"https://github.com/percona","followers_url":"https://api.github.com/users/percona/followers","following_url":"https://api.github.com/users/percona/following{/other_user}","gists_url":"https://api.github.com/users/percona/gists{/gist_id}","starred_url":"https://api.github.com/users/percona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/percona/subscriptions","organizations_url":"https://api.github.com/users/percona/orgs","repos_url":"https://api.github.com/users/percona/repos","events_url":"https://api.github.com/users/percona/events{/privacy}","received_events_url":"https://api.github.com/users/percona/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/percona/percona-xtradb-cluster","description":"A High Scalability Solution for MySQL Clustering and High Availability","fork":false,"url":"https://api.github.com/repos/percona/percona-xtradb-cluster","forks_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/forks","keys_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/teams","hooks_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/hooks","issue_events_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/issues/events{/number}","events_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/events","assignees_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/assignees{/user}","branches_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/branches{/branch}","tags_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/tags","blobs_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/git/refs{/sha}","trees_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/statuses/{sha}","languages_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/languages","stargazers_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/stargazers","contributors_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/contributors","subscribers_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/subscribers","subscription_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/subscription","commits_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/commits{/sha}","git_commits_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/git/commits{/sha}","comments_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/comments{/number}","issue_comment_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/issues/comments{/number}","contents_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/contents/{+path}","compare_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/merges","archive_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/downloads","issues_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/issues{/number}","pulls_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/pulls{/number}","milestones_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/milestones{/number}","notifications_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/labels{/name}","releases_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/releases{/id}","deployments_url":"https://api.github.com/repos/percona/percona-xtradb-cluster/deployments","created_at":"2015-02-13T11:39:22Z","updated_at":"2017-07-28T19:07:10Z","pushed_at":"2017-08-19T07:09:24Z","git_url":"git://github.com/percona/percona-xtradb-cluster.git","ssh_url":"git@github.com:percona/percona-xtradb-cluster.git","clone_url":"https://github.com/percona/percona-xtradb-cluster.git","svn_url":"https://github.com/percona/percona-xtradb-cluster","homepage":"http://www.percona.com/software/percona-xtradb-cluster","size":560790,"stargazers_count":99,"watchers_count":99,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":49,"mirror_url":null,"open_issues_count":11,"forks":49,"open_issues":11,"watchers":99,"default_branch":"5.7"}},"_links":{"self":{"href":"https://api.github.com/repos/percona/percona-xtradb-cluster/pulls/509"},"html":{"href":"https://github.com/percona/percona-xtradb-cluster/pull/509"},"issue":{"href":"https://api.github.com/repos/percona/percona-xtradb-cluster/issues/509"},"comments":{"href":"https://api.github.com/repos/percona/percona-xtradb-cluster/issues/509/comments"},"review_comments":{"href":"https://api.github.com/repos/percona/percona-xtradb-cluster/pulls/509/comments"},"review_comment":{"href":"https://api.github.com/repos/percona/percona-xtradb-cluster/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/percona/percona-xtradb-cluster/pulls/509/commits"},"statuses":{"href":"https://api.github.com/repos/percona/percona-xtradb-cluster/statuses/f7729e6f1e05e9dcf63aaaf9baa58061ad049101"}}}}
{"actor":{"display_login":"kbauskar"}}