{"action":"created","comment":{"url":"https://api.github.com/repos/unibet/puppet-forge_server/pulls/comments/128973275","pull_request_review_id":51699076,"id":128973275,"diff_hunk":"@@ -35,12 +35,7 @@ export GEM_PATH=/opt/rh/<%= @scl %>/root/usr/local/share/gems:/opt/rh/<%= @scl %\n export PATH=/opt/rh/<%= @scl %>/root/usr/bin:$PATH\n <%- end -%>\n \n-<%- if @provider == \"pe_gem\" then -%>\n-export PATH=/opt/puppet/bin:$PATH\n-<%- end -%>\n-<%- if @provider == \"puppet_gem\" then -%>\n-export PATH=/opt/puppetlabs/puppet/bin:$PATH\n-<%- end -%>\n+<%= if @is_pe == true or @is_pe == 'true' then 'export PATH=/opt/puppet/bin:$PATH' elsif @puppetversion >= '4.2.0' then 'export PATH=/opt/puppetlabs/puppet/bin:$PATH' else '/usr/bin' end %>","path":"templates/RedHat/puppet-forge-server.initd.erb","position":10,"original_position":10,"commit_id":"1a779b41281ced7db20e0da1321e97fd56f071fe","original_commit_id":"1a779b41281ced7db20e0da1321e97fd56f071fe","user":{"login":"simonasr","id":7496885,"avatar_url":"https://avatars0.githubusercontent.com/u/7496885?v=4","gravatar_id":"","url":"https://api.github.com/users/simonasr","html_url":"https://github.com/simonasr","followers_url":"https://api.github.com/users/simonasr/followers","following_url":"https://api.github.com/users/simonasr/following{/other_user}","gists_url":"https://api.github.com/users/simonasr/gists{/gist_id}","starred_url":"https://api.github.com/users/simonasr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonasr/subscriptions","organizations_url":"https://api.github.com/users/simonasr/orgs","repos_url":"https://api.github.com/users/simonasr/repos","events_url":"https://api.github.com/users/simonasr/events{/privacy}","received_events_url":"https://api.github.com/users/simonasr/received_events","type":"User","site_admin":false},"body":"looks nicer :)\r\nanyway, looks like my changes are obsolete comparing to latest release.\r\nI think you can close this PR.\r\n","created_at":"2017-07-24T08:12:16Z","updated_at":"2017-07-24T08:12:16Z","html_url":"https://github.com/unibet/puppet-forge_server/pull/10#discussion_r128973275","pull_request_url":"https://api.github.com/repos/unibet/puppet-forge_server/pulls/10","_links":{"self":{"href":"https://api.github.com/repos/unibet/puppet-forge_server/pulls/comments/128973275"},"html":{"href":"https://github.com/unibet/puppet-forge_server/pull/10#discussion_r128973275"},"pull_request":{"href":"https://api.github.com/repos/unibet/puppet-forge_server/pulls/10"}}},"pull_request":{"url":"https://api.github.com/repos/unibet/puppet-forge_server/pulls/10","id":76747399,"html_url":"https://github.com/unibet/puppet-forge_server/pull/10","diff_url":"https://github.com/unibet/puppet-forge_server/pull/10.diff","patch_url":"https://github.com/unibet/puppet-forge_server/pull/10.patch","issue_url":"https://api.github.com/repos/unibet/puppet-forge_server/issues/10","number":10,"state":"open","locked":false,"title":"Some updates for compatibility with puppet4","user":{"login":"simonasr","id":7496885,"avatar_url":"https://avatars0.githubusercontent.com/u/7496885?v=4","gravatar_id":"","url":"https://api.github.com/users/simonasr","html_url":"https://github.com/simonasr","followers_url":"https://api.github.com/users/simonasr/followers","following_url":"https://api.github.com/users/simonasr/following{/other_user}","gists_url":"https://api.github.com/users/simonasr/gists{/gist_id}","starred_url":"https://api.github.com/users/simonasr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonasr/subscriptions","organizations_url":"https://api.github.com/users/simonasr/orgs","repos_url":"https://api.github.com/users/simonasr/repos","events_url":"https://api.github.com/users/simonasr/events{/privacy}","received_events_url":"https://api.github.com/users/simonasr/received_events","type":"User","site_admin":false},"body":"- fix path selection for gem\n- fix possible resource duplication problem\n- specify 'init' service provider for puppet service resouce\n","created_at":"2016-07-08T12:47:50Z","updated_at":"2017-07-24T08:12:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"57ca1d567a41cd7c7c265bc8f77c05f87e81535a","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/unibet/puppet-forge_server/pulls/10/commits","review_comments_url":"https://api.github.com/repos/unibet/puppet-forge_server/pulls/10/comments","review_comment_url":"https://api.github.com/repos/unibet/puppet-forge_server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/unibet/puppet-forge_server/issues/10/comments","statuses_url":"https://api.github.com/repos/unibet/puppet-forge_server/statuses/1a779b41281ced7db20e0da1321e97fd56f071fe","head":{"label":"simonasr:fix_path","ref":"fix_path","sha":"1a779b41281ced7db20e0da1321e97fd56f071fe","user":{"login":"simonasr","id":7496885,"avatar_url":"https://avatars0.githubusercontent.com/u/7496885?v=4","gravatar_id":"","url":"https://api.github.com/users/simonasr","html_url":"https://github.com/simonasr","followers_url":"https://api.github.com/users/simonasr/followers","following_url":"https://api.github.com/users/simonasr/following{/other_user}","gists_url":"https://api.github.com/users/simonasr/gists{/gist_id}","starred_url":"https://api.github.com/users/simonasr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonasr/subscriptions","organizations_url":"https://api.github.com/users/simonasr/orgs","repos_url":"https://api.github.com/users/simonasr/repos","events_url":"https://api.github.com/users/simonasr/events{/privacy}","received_events_url":"https://api.github.com/users/simonasr/received_events","type":"User","site_admin":false},"repo":{"id":62874562,"name":"puppet-forge_server","full_name":"simonasr/puppet-forge_server","owner":{"login":"simonasr","id":7496885,"avatar_url":"https://avatars0.githubusercontent.com/u/7496885?v=4","gravatar_id":"","url":"https://api.github.com/users/simonasr","html_url":"https://github.com/simonasr","followers_url":"https://api.github.com/users/simonasr/followers","following_url":"https://api.github.com/users/simonasr/following{/other_user}","gists_url":"https://api.github.com/users/simonasr/gists{/gist_id}","starred_url":"https://api.github.com/users/simonasr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonasr/subscriptions","organizations_url":"https://api.github.com/users/simonasr/orgs","repos_url":"https://api.github.com/users/simonasr/repos","events_url":"https://api.github.com/users/simonasr/events{/privacy}","received_events_url":"https://api.github.com/users/simonasr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/simonasr/puppet-forge_server","description":"A Puppet module for managing Puppet Forge Server","fork":true,"url":"https://api.github.com/repos/simonasr/puppet-forge_server","forks_url":"https://api.github.com/repos/simonasr/puppet-forge_server/forks","keys_url":"https://api.github.com/repos/simonasr/puppet-forge_server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/simonasr/puppet-forge_server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/simonasr/puppet-forge_server/teams","hooks_url":"https://api.github.com/repos/simonasr/puppet-forge_server/hooks","issue_events_url":"https://api.github.com/repos/simonasr/puppet-forge_server/issues/events{/number}","events_url":"https://api.github.com/repos/simonasr/puppet-forge_server/events","assignees_url":"https://api.github.com/repos/simonasr/puppet-forge_server/assignees{/user}","branches_url":"https://api.github.com/repos/simonasr/puppet-forge_server/branches{/branch}","tags_url":"https://api.github.com/repos/simonasr/puppet-forge_server/tags","blobs_url":"https://api.github.com/repos/simonasr/puppet-forge_server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/simonasr/puppet-forge_server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/simonasr/puppet-forge_server/git/refs{/sha}","trees_url":"https://api.github.com/repos/simonasr/puppet-forge_server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/simonasr/puppet-forge_server/statuses/{sha}","languages_url":"https://api.github.com/repos/simonasr/puppet-forge_server/languages","stargazers_url":"https://api.github.com/repos/simonasr/puppet-forge_server/stargazers","contributors_url":"https://api.github.com/repos/simonasr/puppet-forge_server/contributors","subscribers_url":"https://api.github.com/repos/simonasr/puppet-forge_server/subscribers","subscription_url":"https://api.github.com/repos/simonasr/puppet-forge_server/subscription","commits_url":"https://api.github.com/repos/simonasr/puppet-forge_server/commits{/sha}","git_commits_url":"https://api.github.com/repos/simonasr/puppet-forge_server/git/commits{/sha}","comments_url":"https://api.github.com/repos/simonasr/puppet-forge_server/comments{/number}","issue_comment_url":"https://api.github.com/repos/simonasr/puppet-forge_server/issues/comments{/number}","contents_url":"https://api.github.com/repos/simonasr/puppet-forge_server/contents/{+path}","compare_url":"https://api.github.com/repos/simonasr/puppet-forge_server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/simonasr/puppet-forge_server/merges","archive_url":"https://api.github.com/repos/simonasr/puppet-forge_server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/simonasr/puppet-forge_server/downloads","issues_url":"https://api.github.com/repos/simonasr/puppet-forge_server/issues{/number}","pulls_url":"https://api.github.com/repos/simonasr/puppet-forge_server/pulls{/number}","milestones_url":"https://api.github.com/repos/simonasr/puppet-forge_server/milestones{/number}","notifications_url":"https://api.github.com/repos/simonasr/puppet-forge_server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/simonasr/puppet-forge_server/labels{/name}","releases_url":"https://api.github.com/repos/simonasr/puppet-forge_server/releases{/id}","deployments_url":"https://api.github.com/repos/simonasr/puppet-forge_server/deployments","created_at":"2016-07-08T08:58:34Z","updated_at":"2016-07-08T08:58:35Z","pushed_at":"2017-07-18T10:59:07Z","git_url":"git://github.com/simonasr/puppet-forge_server.git","ssh_url":"git@github.com:simonasr/puppet-forge_server.git","clone_url":"https://github.com/simonasr/puppet-forge_server.git","svn_url":"https://github.com/simonasr/puppet-forge_server","homepage":null,"size":51,"stargazers_count":0,"watchers_count":0,"language":"Puppet","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"unibet:master","ref":"master","sha":"296e79b7f190a2fd7182ed863b321f65ab3a4e41","user":{"login":"unibet","id":1133639,"avatar_url":"https://avatars2.githubusercontent.com/u/1133639?v=4","gravatar_id":"","url":"https://api.github.com/users/unibet","html_url":"https://github.com/unibet","followers_url":"https://api.github.com/users/unibet/followers","following_url":"https://api.github.com/users/unibet/following{/other_user}","gists_url":"https://api.github.com/users/unibet/gists{/gist_id}","starred_url":"https://api.github.com/users/unibet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unibet/subscriptions","organizations_url":"https://api.github.com/users/unibet/orgs","repos_url":"https://api.github.com/users/unibet/repos","events_url":"https://api.github.com/users/unibet/events{/privacy}","received_events_url":"https://api.github.com/users/unibet/received_events","type":"Organization","site_admin":false},"repo":{"id":27131831,"name":"puppet-forge_server","full_name":"unibet/puppet-forge_server","owner":{"login":"unibet","id":1133639,"avatar_url":"https://avatars2.githubusercontent.com/u/1133639?v=4","gravatar_id":"","url":"https://api.github.com/users/unibet","html_url":"https://github.com/unibet","followers_url":"https://api.github.com/users/unibet/followers","following_url":"https://api.github.com/users/unibet/following{/other_user}","gists_url":"https://api.github.com/users/unibet/gists{/gist_id}","starred_url":"https://api.github.com/users/unibet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unibet/subscriptions","organizations_url":"https://api.github.com/users/unibet/orgs","repos_url":"https://api.github.com/users/unibet/repos","events_url":"https://api.github.com/users/unibet/events{/privacy}","received_events_url":"https://api.github.com/users/unibet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/unibet/puppet-forge_server","description":"A Puppet module for managing Puppet Forge Server","fork":false,"url":"https://api.github.com/repos/unibet/puppet-forge_server","forks_url":"https://api.github.com/repos/unibet/puppet-forge_server/forks","keys_url":"https://api.github.com/repos/unibet/puppet-forge_server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/unibet/puppet-forge_server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/unibet/puppet-forge_server/teams","hooks_url":"https://api.github.com/repos/unibet/puppet-forge_server/hooks","issue_events_url":"https://api.github.com/repos/unibet/puppet-forge_server/issues/events{/number}","events_url":"https://api.github.com/repos/unibet/puppet-forge_server/events","assignees_url":"https://api.github.com/repos/unibet/puppet-forge_server/assignees{/user}","branches_url":"https://api.github.com/repos/unibet/puppet-forge_server/branches{/branch}","tags_url":"https://api.github.com/repos/unibet/puppet-forge_server/tags","blobs_url":"https://api.github.com/repos/unibet/puppet-forge_server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/unibet/puppet-forge_server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/unibet/puppet-forge_server/git/refs{/sha}","trees_url":"https://api.github.com/repos/unibet/puppet-forge_server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/unibet/puppet-forge_server/statuses/{sha}","languages_url":"https://api.github.com/repos/unibet/puppet-forge_server/languages","stargazers_url":"https://api.github.com/repos/unibet/puppet-forge_server/stargazers","contributors_url":"https://api.github.com/repos/unibet/puppet-forge_server/contributors","subscribers_url":"https://api.github.com/repos/unibet/puppet-forge_server/subscribers","subscription_url":"https://api.github.com/repos/unibet/puppet-forge_server/subscription","commits_url":"https://api.github.com/repos/unibet/puppet-forge_server/commits{/sha}","git_commits_url":"https://api.github.com/repos/unibet/puppet-forge_server/git/commits{/sha}","comments_url":"https://api.github.com/repos/unibet/puppet-forge_server/comments{/number}","issue_comment_url":"https://api.github.com/repos/unibet/puppet-forge_server/issues/comments{/number}","contents_url":"https://api.github.com/repos/unibet/puppet-forge_server/contents/{+path}","compare_url":"https://api.github.com/repos/unibet/puppet-forge_server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/unibet/puppet-forge_server/merges","archive_url":"https://api.github.com/repos/unibet/puppet-forge_server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/unibet/puppet-forge_server/downloads","issues_url":"https://api.github.com/repos/unibet/puppet-forge_server/issues{/number}","pulls_url":"https://api.github.com/repos/unibet/puppet-forge_server/pulls{/number}","milestones_url":"https://api.github.com/repos/unibet/puppet-forge_server/milestones{/number}","notifications_url":"https://api.github.com/repos/unibet/puppet-forge_server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/unibet/puppet-forge_server/labels{/name}","releases_url":"https://api.github.com/repos/unibet/puppet-forge_server/releases{/id}","deployments_url":"https://api.github.com/repos/unibet/puppet-forge_server/deployments","created_at":"2014-11-25T15:22:30Z","updated_at":"2017-03-16T16:54:42Z","pushed_at":"2017-07-18T10:59:08Z","git_url":"git://github.com/unibet/puppet-forge_server.git","ssh_url":"git@github.com:unibet/puppet-forge_server.git","clone_url":"https://github.com/unibet/puppet-forge_server.git","svn_url":"https://github.com/unibet/puppet-forge_server","homepage":null,"size":42,"stargazers_count":4,"watchers_count":4,"language":"Puppet","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":4,"forks":18,"open_issues":4,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/unibet/puppet-forge_server/pulls/10"},"html":{"href":"https://github.com/unibet/puppet-forge_server/pull/10"},"issue":{"href":"https://api.github.com/repos/unibet/puppet-forge_server/issues/10"},"comments":{"href":"https://api.github.com/repos/unibet/puppet-forge_server/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/unibet/puppet-forge_server/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/unibet/puppet-forge_server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/unibet/puppet-forge_server/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/unibet/puppet-forge_server/statuses/1a779b41281ced7db20e0da1321e97fd56f071fe"}}}}
{"actor":{"display_login":"simonasr"}}