{"action":"created","comment":{"url":"https://api.github.com/repos/jojojames/evil-collection/pulls/comments/155512899","pull_request_review_id":81842545,"id":155512899,"diff_hunk":"@@ -58,6 +58,12 @@ it does not have a mode.\"\n                      minibuffer-local-isearch-map))\n     (evil-define-key* 'normal map (kbd \"<escape>\") 'abort-recursive-edit)\n     (evil-define-key* 'normal map (kbd \"<return>\") 'exit-minibuffer))\n+\n+  (with-eval-after-load 'ivy\n+    (defvar ivy-minibuffer-map)","path":"evil-collection-minibuffer.el","position":15,"original_position":15,"commit_id":"fdb1c2ff2d5be7baea8f51924a12c49e7362aff4","original_commit_id":"fdb1c2ff2d5be7baea8f51924a12c49e7362aff4","user":{"login":"jojojames","id":1227856,"avatar_url":"https://avatars1.githubusercontent.com/u/1227856?v=4","gravatar_id":"","url":"https://api.github.com/users/jojojames","html_url":"https://github.com/jojojames","followers_url":"https://api.github.com/users/jojojames/followers","following_url":"https://api.github.com/users/jojojames/following{/other_user}","gists_url":"https://api.github.com/users/jojojames/gists{/gist_id}","starred_url":"https://api.github.com/users/jojojames/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jojojames/subscriptions","organizations_url":"https://api.github.com/users/jojojames/orgs","repos_url":"https://api.github.com/users/jojojames/repos","events_url":"https://api.github.com/users/jojojames/events{/privacy}","received_events_url":"https://api.github.com/users/jojojames/received_events","type":"User","site_admin":false},"body":"It might be reasonable to leave it in this file too. It just jumped out when I saw the eval-after-load 'ivy.","created_at":"2017-12-07T12:56:28Z","updated_at":"2017-12-07T12:56:28Z","html_url":"https://github.com/jojojames/evil-collection/pull/55#discussion_r155512899","pull_request_url":"https://api.github.com/repos/jojojames/evil-collection/pulls/55","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/jojojames/evil-collection/pulls/comments/155512899"},"html":{"href":"https://github.com/jojojames/evil-collection/pull/55#discussion_r155512899"},"pull_request":{"href":"https://api.github.com/repos/jojojames/evil-collection/pulls/55"}},"in_reply_to_id":155510746},"pull_request":{"url":"https://api.github.com/repos/jojojames/evil-collection/pulls/55","id":156972148,"html_url":"https://github.com/jojojames/evil-collection/pull/55","diff_url":"https://github.com/jojojames/evil-collection/pull/55.diff","patch_url":"https://github.com/jojojames/evil-collection/pull/55.patch","issue_url":"https://api.github.com/repos/jojojames/evil-collection/issues/55","number":55,"state":"open","locked":false,"title":" Handle ivy in minibuffer and add a defcustom to enable minibuffer","user":{"login":"fbergroth","id":1211003,"avatar_url":"https://avatars3.githubusercontent.com/u/1211003?v=4","gravatar_id":"","url":"https://api.github.com/users/fbergroth","html_url":"https://github.com/fbergroth","followers_url":"https://api.github.com/users/fbergroth/followers","following_url":"https://api.github.com/users/fbergroth/following{/other_user}","gists_url":"https://api.github.com/users/fbergroth/gists{/gist_id}","starred_url":"https://api.github.com/users/fbergroth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbergroth/subscriptions","organizations_url":"https://api.github.com/users/fbergroth/orgs","repos_url":"https://api.github.com/users/fbergroth/repos","events_url":"https://api.github.com/users/fbergroth/events{/privacy}","received_events_url":"https://api.github.com/users/fbergroth/received_events","type":"User","site_admin":false},"body":"`evil-collection-minibuffer-init` had to be renamed as well. You could add an alias if you want to remain backward compatible.","created_at":"2017-12-07T11:42:36Z","updated_at":"2017-12-07T12:56:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c161e25a4d7b9679078754f1fae56112b1ec957b","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/jojojames/evil-collection/pulls/55/commits","review_comments_url":"https://api.github.com/repos/jojojames/evil-collection/pulls/55/comments","review_comment_url":"https://api.github.com/repos/jojojames/evil-collection/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jojojames/evil-collection/issues/55/comments","statuses_url":"https://api.github.com/repos/jojojames/evil-collection/statuses/fdb1c2ff2d5be7baea8f51924a12c49e7362aff4","head":{"label":"fbergroth:ivy-minibuffer","ref":"ivy-minibuffer","sha":"fdb1c2ff2d5be7baea8f51924a12c49e7362aff4","user":{"login":"fbergroth","id":1211003,"avatar_url":"https://avatars3.githubusercontent.com/u/1211003?v=4","gravatar_id":"","url":"https://api.github.com/users/fbergroth","html_url":"https://github.com/fbergroth","followers_url":"https://api.github.com/users/fbergroth/followers","following_url":"https://api.github.com/users/fbergroth/following{/other_user}","gists_url":"https://api.github.com/users/fbergroth/gists{/gist_id}","starred_url":"https://api.github.com/users/fbergroth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbergroth/subscriptions","organizations_url":"https://api.github.com/users/fbergroth/orgs","repos_url":"https://api.github.com/users/fbergroth/repos","events_url":"https://api.github.com/users/fbergroth/events{/privacy}","received_events_url":"https://api.github.com/users/fbergroth/received_events","type":"User","site_admin":false},"repo":{"id":110806824,"name":"evil-collection","full_name":"fbergroth/evil-collection","owner":{"login":"fbergroth","id":1211003,"avatar_url":"https://avatars3.githubusercontent.com/u/1211003?v=4","gravatar_id":"","url":"https://api.github.com/users/fbergroth","html_url":"https://github.com/fbergroth","followers_url":"https://api.github.com/users/fbergroth/followers","following_url":"https://api.github.com/users/fbergroth/following{/other_user}","gists_url":"https://api.github.com/users/fbergroth/gists{/gist_id}","starred_url":"https://api.github.com/users/fbergroth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbergroth/subscriptions","organizations_url":"https://api.github.com/users/fbergroth/orgs","repos_url":"https://api.github.com/users/fbergroth/repos","events_url":"https://api.github.com/users/fbergroth/events{/privacy}","received_events_url":"https://api.github.com/users/fbergroth/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fbergroth/evil-collection","description":"A set of keybindings for evil-mode","fork":true,"url":"https://api.github.com/repos/fbergroth/evil-collection","forks_url":"https://api.github.com/repos/fbergroth/evil-collection/forks","keys_url":"https://api.github.com/repos/fbergroth/evil-collection/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fbergroth/evil-collection/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fbergroth/evil-collection/teams","hooks_url":"https://api.github.com/repos/fbergroth/evil-collection/hooks","issue_events_url":"https://api.github.com/repos/fbergroth/evil-collection/issues/events{/number}","events_url":"https://api.github.com/repos/fbergroth/evil-collection/events","assignees_url":"https://api.github.com/repos/fbergroth/evil-collection/assignees{/user}","branches_url":"https://api.github.com/repos/fbergroth/evil-collection/branches{/branch}","tags_url":"https://api.github.com/repos/fbergroth/evil-collection/tags","blobs_url":"https://api.github.com/repos/fbergroth/evil-collection/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fbergroth/evil-collection/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fbergroth/evil-collection/git/refs{/sha}","trees_url":"https://api.github.com/repos/fbergroth/evil-collection/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fbergroth/evil-collection/statuses/{sha}","languages_url":"https://api.github.com/repos/fbergroth/evil-collection/languages","stargazers_url":"https://api.github.com/repos/fbergroth/evil-collection/stargazers","contributors_url":"https://api.github.com/repos/fbergroth/evil-collection/contributors","subscribers_url":"https://api.github.com/repos/fbergroth/evil-collection/subscribers","subscription_url":"https://api.github.com/repos/fbergroth/evil-collection/subscription","commits_url":"https://api.github.com/repos/fbergroth/evil-collection/commits{/sha}","git_commits_url":"https://api.github.com/repos/fbergroth/evil-collection/git/commits{/sha}","comments_url":"https://api.github.com/repos/fbergroth/evil-collection/comments{/number}","issue_comment_url":"https://api.github.com/repos/fbergroth/evil-collection/issues/comments{/number}","contents_url":"https://api.github.com/repos/fbergroth/evil-collection/contents/{+path}","compare_url":"https://api.github.com/repos/fbergroth/evil-collection/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fbergroth/evil-collection/merges","archive_url":"https://api.github.com/repos/fbergroth/evil-collection/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fbergroth/evil-collection/downloads","issues_url":"https://api.github.com/repos/fbergroth/evil-collection/issues{/number}","pulls_url":"https://api.github.com/repos/fbergroth/evil-collection/pulls{/number}","milestones_url":"https://api.github.com/repos/fbergroth/evil-collection/milestones{/number}","notifications_url":"https://api.github.com/repos/fbergroth/evil-collection/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fbergroth/evil-collection/labels{/name}","releases_url":"https://api.github.com/repos/fbergroth/evil-collection/releases{/id}","deployments_url":"https://api.github.com/repos/fbergroth/evil-collection/deployments","created_at":"2017-11-15T08:37:03Z","updated_at":"2017-11-15T08:37:05Z","pushed_at":"2017-12-07T11:38:05Z","git_url":"git://github.com/fbergroth/evil-collection.git","ssh_url":"git@github.com:fbergroth/evil-collection.git","clone_url":"https://github.com/fbergroth/evil-collection.git","svn_url":"https://github.com/fbergroth/evil-collection","homepage":null,"size":255,"stargazers_count":0,"watchers_count":0,"language":"Emacs Lisp","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jojojames:master","ref":"master","sha":"81923376e2467cbae05b85ba60ee0c539ef54699","user":{"login":"jojojames","id":1227856,"avatar_url":"https://avatars1.githubusercontent.com/u/1227856?v=4","gravatar_id":"","url":"https://api.github.com/users/jojojames","html_url":"https://github.com/jojojames","followers_url":"https://api.github.com/users/jojojames/followers","following_url":"https://api.github.com/users/jojojames/following{/other_user}","gists_url":"https://api.github.com/users/jojojames/gists{/gist_id}","starred_url":"https://api.github.com/users/jojojames/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jojojames/subscriptions","organizations_url":"https://api.github.com/users/jojojames/orgs","repos_url":"https://api.github.com/users/jojojames/repos","events_url":"https://api.github.com/users/jojojames/events{/privacy}","received_events_url":"https://api.github.com/users/jojojames/received_events","type":"User","site_admin":false},"repo":{"id":109591971,"name":"evil-collection","full_name":"jojojames/evil-collection","owner":{"login":"jojojames","id":1227856,"avatar_url":"https://avatars1.githubusercontent.com/u/1227856?v=4","gravatar_id":"","url":"https://api.github.com/users/jojojames","html_url":"https://github.com/jojojames","followers_url":"https://api.github.com/users/jojojames/followers","following_url":"https://api.github.com/users/jojojames/following{/other_user}","gists_url":"https://api.github.com/users/jojojames/gists{/gist_id}","starred_url":"https://api.github.com/users/jojojames/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jojojames/subscriptions","organizations_url":"https://api.github.com/users/jojojames/orgs","repos_url":"https://api.github.com/users/jojojames/repos","events_url":"https://api.github.com/users/jojojames/events{/privacy}","received_events_url":"https://api.github.com/users/jojojames/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jojojames/evil-collection","description":"A set of keybindings for evil-mode","fork":false,"url":"https://api.github.com/repos/jojojames/evil-collection","forks_url":"https://api.github.com/repos/jojojames/evil-collection/forks","keys_url":"https://api.github.com/repos/jojojames/evil-collection/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jojojames/evil-collection/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jojojames/evil-collection/teams","hooks_url":"https://api.github.com/repos/jojojames/evil-collection/hooks","issue_events_url":"https://api.github.com/repos/jojojames/evil-collection/issues/events{/number}","events_url":"https://api.github.com/repos/jojojames/evil-collection/events","assignees_url":"https://api.github.com/repos/jojojames/evil-collection/assignees{/user}","branches_url":"https://api.github.com/repos/jojojames/evil-collection/branches{/branch}","tags_url":"https://api.github.com/repos/jojojames/evil-collection/tags","blobs_url":"https://api.github.com/repos/jojojames/evil-collection/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jojojames/evil-collection/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jojojames/evil-collection/git/refs{/sha}","trees_url":"https://api.github.com/repos/jojojames/evil-collection/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jojojames/evil-collection/statuses/{sha}","languages_url":"https://api.github.com/repos/jojojames/evil-collection/languages","stargazers_url":"https://api.github.com/repos/jojojames/evil-collection/stargazers","contributors_url":"https://api.github.com/repos/jojojames/evil-collection/contributors","subscribers_url":"https://api.github.com/repos/jojojames/evil-collection/subscribers","subscription_url":"https://api.github.com/repos/jojojames/evil-collection/subscription","commits_url":"https://api.github.com/repos/jojojames/evil-collection/commits{/sha}","git_commits_url":"https://api.github.com/repos/jojojames/evil-collection/git/commits{/sha}","comments_url":"https://api.github.com/repos/jojojames/evil-collection/comments{/number}","issue_comment_url":"https://api.github.com/repos/jojojames/evil-collection/issues/comments{/number}","contents_url":"https://api.github.com/repos/jojojames/evil-collection/contents/{+path}","compare_url":"https://api.github.com/repos/jojojames/evil-collection/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jojojames/evil-collection/merges","archive_url":"https://api.github.com/repos/jojojames/evil-collection/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jojojames/evil-collection/downloads","issues_url":"https://api.github.com/repos/jojojames/evil-collection/issues{/number}","pulls_url":"https://api.github.com/repos/jojojames/evil-collection/pulls{/number}","milestones_url":"https://api.github.com/repos/jojojames/evil-collection/milestones{/number}","notifications_url":"https://api.github.com/repos/jojojames/evil-collection/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jojojames/evil-collection/labels{/name}","releases_url":"https://api.github.com/repos/jojojames/evil-collection/releases{/id}","deployments_url":"https://api.github.com/repos/jojojames/evil-collection/deployments","created_at":"2017-11-05T15:35:04Z","updated_at":"2017-12-07T11:16:57Z","pushed_at":"2017-12-07T11:42:37Z","git_url":"git://github.com/jojojames/evil-collection.git","ssh_url":"git@github.com:jojojames/evil-collection.git","clone_url":"https://github.com/jojojames/evil-collection.git","svn_url":"https://github.com/jojojames/evil-collection","homepage":null,"size":245,"stargazers_count":48,"watchers_count":48,"language":"Emacs Lisp","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":19,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":7,"open_issues":19,"watchers":48,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jojojames/evil-collection/pulls/55"},"html":{"href":"https://github.com/jojojames/evil-collection/pull/55"},"issue":{"href":"https://api.github.com/repos/jojojames/evil-collection/issues/55"},"comments":{"href":"https://api.github.com/repos/jojojames/evil-collection/issues/55/comments"},"review_comments":{"href":"https://api.github.com/repos/jojojames/evil-collection/pulls/55/comments"},"review_comment":{"href":"https://api.github.com/repos/jojojames/evil-collection/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jojojames/evil-collection/pulls/55/commits"},"statuses":{"href":"https://api.github.com/repos/jojojames/evil-collection/statuses/fdb1c2ff2d5be7baea8f51924a12c49e7362aff4"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jojojames"}}