{"push_id":1794407413,"size":219,"distinct_size":4,"ref":"refs/heads/master","head":"f8cdecf2800bb4bcba91abc3c8d560d47ecf7e28","before":"acf3a6b8e21ab4d104965057b56a117782ac9658","commits":[{"sha":"e8a6474098a47dff60585093994c8c91c2514df9","author":{"name":"Brian Chan","email":"03f1991d34240e985a132037258562e29f9bb7ff@liferay.com"},"message":"VULCAN-3 avoid chaining, but state the necessity of the redeclaring the same optional twice","distinct":false,"url":"https://api.github.com/repos/robertoDiaz/liferay-portal/commits/e8a6474098a47dff60585093994c8c91c2514df9"},{"sha":"8b05fcb87ba19af3ebd235f2bc5a78131b29b64d","author":{"name":"Brian Chan","email":"03f1991d34240e985a132037258562e29f9bb7ff@liferay.com"},"message":"VULCAN-3 Rename PageJSONMessageMapper to PageMessageMapper, and then prefix the class with either PlainJSON or JSONLD","distinct":false,"url":"https://api.github.com/repos/robertoDiaz/liferay-portal/commits/8b05fcb87ba19af3ebd235f2bc5a78131b29b64d"},{"sha":"85f846ddcc4b006b12271455958ece684745c89f","author":{"name":"Brian Chan","email":"03f1991d34240e985a132037258562e29f9bb7ff@liferay.com"},"message":"VULCAN-3 Rename SingleModelJSONMessageMapper to SingleModelMessageMapper, and then prefix the class with either PlainJSON or JSONLD","distinct":false,"url":"https://api.github.com/repos/robertoDiaz/liferay-portal/commits/85f846ddcc4b006b12271455958ece684745c89f"},{"sha":"2158964fef2764a8102682899ff99c9eec620c39","author":{"name":"Brian Chan","email":"03f1991d34240e985a132037258562e29f9bb7ff@liferay.com"},"message":"VULCAN-3 I always have to weigh when to use a Constants file (we do it in a lot of places), and when not to (most of our request parameter names are in constants). In this case, it's only internal and I find it easier to read and simplifies things if we get rid of the constants. I also cut and paste a lot to ensure there are no errors.","distinct":false,"url":"https://api.github.com/repos/robertoDiaz/liferay-portal/commits/2158964fef2764a8102682899ff99c9eec620c39"},{"sha":"8913b57a3b6a8f15b21e351fc87883f987134505","author":{"name":"Brian Chan","email":"03f1991d34240e985a132037258562e29f9bb7ff@liferay.com"},"message":"VULCAN-3 Apply logic I already applied in vulcan-message-json-plain here","distinct":false,"url":"https://api.github.com/repos/robertoDiaz/liferay-portal/commits/8913b57a3b6a8f15b21e351fc87883f987134505"},{"sha":"ba03634bb87811ed4abc9b1c040c35b7b4f278d2","author":{"name":"Brian Chan","email":"03f1991d34240e985a132037258562e29f9bb7ff@liferay.com"},"message":"VULCAN-3 Apply logic I already applied in vulcan-message-json-plain here","distinct":false,"url":"https://api.github.com/repos/robertoDiaz/liferay-portal/commits/ba03634bb87811ed4abc9b1c040c35b7b4f278d2"},{"sha":"00cef3acd4cb693dc2f2001f45c0b6bc9cb47bb6","author":{"name":"Brian Chan","email":"03f1991d34240e985a132037258562e29f9bb7ff@liferay.com"},"message":"VULCAN-3 Apply logic I already applied in vulcan-message-json-plain here","distinct":false,"url":"https://api.github.com/repos/robertoDiaz/liferay-portal/commits/00cef3acd4cb693dc2f2001f45c0b6bc9cb47bb6"},{"sha":"31b65289b36879e637cbf4a929253b038fff9f6f","author":{"name":"Brian Chan","email":"03f1991d34240e985a132037258562e29f9bb7ff@liferay.com"},"message":"VULCAN-3 Apply logic I already applied in vulcan-message-json-plain here","distinct":false,"url":"https://api.github.com/repos/robertoDiaz/liferay-portal/commits/31b65289b36879e637cbf4a929253b038fff9f6f"},{"sha":"c3d51e8ba29c4d628e36d085d76122cf258e96a5","author":{"name":"Brian Chan","email":"03f1991d34240e985a132037258562e29f9bb7ff@liferay.com"},"message":"VULCAN-3 Hugo SF, can you enforce this Mockito pattern? SF currently complains, so I have to revert this commit. When we do allow chaining for builders/mockito, I would like them not to chain on the same line. Thx","distinct":false,"url":"https://api.github.com/repos/robertoDiaz/liferay-portal/commits/c3d51e8ba29c4d628e36d085d76122cf258e96a5"},{"sha":"b5e9675b687250746b4a9c0b64700c134c386a63","author":{"name":"Brian Chan","email":"03f1991d34240e985a132037258562e29f9bb7ff@liferay.com"},"message":"Revert \"VULCAN-3 Hugo SF, can you enforce this Mockito pattern? SF currently complains, so I have to revert this commit. When we do allow chaining for builders/mockito, I would like them not to chain on the same line. Thx\"\n\nThis reverts commit 07f75effdddeed0313d822501829961e9552c372.","distinct":false,"url":"https://api.github.com/repos/robertoDiaz/liferay-portal/commits/b5e9675b687250746b4a9c0b64700c134c386a63"},{"sha":"79292a1edbbe22049b64c52fcd9cd62f918441b6","author":{"name":"Brian Chan","email":"03f1991d34240e985a132037258562e29f9bb7ff@liferay.com"},"message":"VULCAN-3 I've seen you use \"T model\" and \"T t\". Where you know it is a model, please use the model var.","distinct":false,"url":"https://api.github.com/repos/robertoDiaz/liferay-portal/commits/79292a1edbbe22049b64c52fcd9cd62f918441b6"},{"sha":"a3c17e300bda50e0171e3687c42c9f05520dd4b2","author":{"name":"Brian Chan","email":"03f1991d34240e985a132037258562e29f9bb7ff@liferay.com"},"message":"VULCAN-3 I've seen you use \"T model\" and \"T t\". Where you know it is a model, please use the model var.","distinct":false,"url":"https://api.github.com/repos/robertoDiaz/liferay-portal/commits/a3c17e300bda50e0171e3687c42c9f05520dd4b2"},{"sha":"534f38d1e6cf6cba0275ef8800c72786c7785705","author":{"name":"Brian Chan","email":"03f1991d34240e985a132037258562e29f9bb7ff@liferay.com"},"message":"VULCAN-3 too many things called \"type\". I'm fine with renaming it even though the original API calls it type","distinct":false,"url":"https://api.github.com/repos/robertoDiaz/liferay-portal/commits/534f38d1e6cf6cba0275ef8800c72786c7785705"},{"sha":"c92f55324c07d92c97a6d1cbc7c9448c4f6ab397","author":{"name":"Brian Chan","email":"03f1991d34240e985a132037258562e29f9bb7ff@liferay.com"},"message":"VULCAN-3 Hugo SF","distinct":false,"url":"https://api.github.com/repos/robertoDiaz/liferay-portal/commits/c92f55324c07d92c97a6d1cbc7c9448c4f6ab397"},{"sha":"695406f91f398c14df03ae149d199e942678b6a3","author":{"name":"Brian Chan","email":"03f1991d34240e985a132037258562e29f9bb7ff@liferay.com"},"message":"VULCAN-3 SF and rename","distinct":false,"url":"https://api.github.com/repos/robertoDiaz/liferay-portal/commits/695406f91f398c14df03ae149d199e942678b6a3"},{"sha":"6b777bc88f5c2fc9975f8c62a654cc8772d40a45","author":{"name":"Brian Chan","email":"03f1991d34240e985a132037258562e29f9bb7ff@liferay.com"},"message":"VULCAN-3 Hugo SF - can you allow this (reverting in next commit since it's currently disallowed","distinct":false,"url":"https://api.github.com/repos/robertoDiaz/liferay-portal/commits/6b777bc88f5c2fc9975f8c62a654cc8772d40a45"},{"sha":"ae1aeac006c659dbbc76c9b43d436d73d9d2cf48","author":{"name":"Brian Chan","email":"03f1991d34240e985a132037258562e29f9bb7ff@liferay.com"},"message":"VULCAN-3 Temp until Hugo SF fixes it","distinct":false,"url":"https://api.github.com/repos/robertoDiaz/liferay-portal/commits/ae1aeac006c659dbbc76c9b43d436d73d9d2cf48"},{"sha":"c4f5fac52884096e51b01405b3919c0544301dd8","author":{"name":"Brian Chan","email":"03f1991d34240e985a132037258562e29f9bb7ff@liferay.com"},"message":"VULCAN-3 Hugo SF","distinct":false,"url":"https://api.github.com/repos/robertoDiaz/liferay-portal/commits/c4f5fac52884096e51b01405b3919c0544301dd8"},{"sha":"3e92cabb29baeadc49e9722c7d472392f01e8716","author":{"name":"Brian Chan","email":"03f1991d34240e985a132037258562e29f9bb7ff@liferay.com"},"message":"VULCAN-3 Hugo SF","distinct":false,"url":"https://api.github.com/repos/robertoDiaz/liferay-portal/commits/3e92cabb29baeadc49e9722c7d472392f01e8716"},{"sha":"37935dbf21e3845ffd816f486ae8873ecd731639","author":{"name":"Brian Chan","email":"03f1991d34240e985a132037258562e29f9bb7ff@liferay.com"},"message":"VULCAN-3 Hugo SF","distinct":false,"url":"https://api.github.com/repos/robertoDiaz/liferay-portal/commits/37935dbf21e3845ffd816f486ae8873ecd731639"}]}
{"actor":{"display_login":"robertoDiaz"}}