{"action":"created","comment":{"url":"https://api.github.com/repos/dmlc/tvm/pulls/comments/144601191","pull_request_review_id":69283846,"id":144601191,"diff_hunk":"@@ -44,7 +44,11 @@ class ROCMDeviceAPI final : public DeviceAPI {\n         value = 64;\n         break;\n       }\n-      case kComputeVersion: return;\n+      case kComputeVersion:\n+        hipDeviceProp_t prop;\n+        ROCM_CALL(hipGetDeviceProperties(&prop, ctx.device_id));\n+        value = prop.gcnArch;\n+        return;","path":"src/runtime/rocm/rocm_device_api.cc","position":9,"original_position":9,"commit_id":"32cc82eaff475055144003361eec9a4e9f497a7d","original_commit_id":"32cc82eaff475055144003361eec9a4e9f497a7d","user":{"login":"tqchen","id":2577440,"avatar_url":"https://avatars3.githubusercontent.com/u/2577440?v=4","gravatar_id":"","url":"https://api.github.com/users/tqchen","html_url":"https://github.com/tqchen","followers_url":"https://api.github.com/users/tqchen/followers","following_url":"https://api.github.com/users/tqchen/following{/other_user}","gists_url":"https://api.github.com/users/tqchen/gists{/gist_id}","starred_url":"https://api.github.com/users/tqchen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tqchen/subscriptions","organizations_url":"https://api.github.com/users/tqchen/orgs","repos_url":"https://api.github.com/users/tqchen/repos","events_url":"https://api.github.com/users/tqchen/events{/privacy}","received_events_url":"https://api.github.com/users/tqchen/received_events","type":"User","site_admin":false},"body":"You need break here, note how *rv get assigned in line 53","created_at":"2017-10-13T16:34:28Z","updated_at":"2017-10-13T16:34:28Z","html_url":"https://github.com/dmlc/tvm/pull/549#discussion_r144601191","pull_request_url":"https://api.github.com/repos/dmlc/tvm/pulls/549","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/dmlc/tvm/pulls/comments/144601191"},"html":{"href":"https://github.com/dmlc/tvm/pull/549#discussion_r144601191"},"pull_request":{"href":"https://api.github.com/repos/dmlc/tvm/pulls/549"}}},"pull_request":{"url":"https://api.github.com/repos/dmlc/tvm/pulls/549","id":146493150,"html_url":"https://github.com/dmlc/tvm/pull/549","diff_url":"https://github.com/dmlc/tvm/pull/549.diff","patch_url":"https://github.com/dmlc/tvm/pull/549.patch","issue_url":"https://api.github.com/repos/dmlc/tvm/issues/549","number":549,"state":"open","locked":false,"title":"added support for rocm gpu autodetect","user":{"login":"adityaatluri","id":2188479,"avatar_url":"https://avatars3.githubusercontent.com/u/2188479?v=4","gravatar_id":"","url":"https://api.github.com/users/adityaatluri","html_url":"https://github.com/adityaatluri","followers_url":"https://api.github.com/users/adityaatluri/followers","following_url":"https://api.github.com/users/adityaatluri/following{/other_user}","gists_url":"https://api.github.com/users/adityaatluri/gists{/gist_id}","starred_url":"https://api.github.com/users/adityaatluri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adityaatluri/subscriptions","organizations_url":"https://api.github.com/users/adityaatluri/orgs","repos_url":"https://api.github.com/users/adityaatluri/repos","events_url":"https://api.github.com/users/adityaatluri/events{/privacy}","received_events_url":"https://api.github.com/users/adityaatluri/received_events","type":"User","site_admin":false},"body":"Generates IR and kernel object files depending on the rocm gpu present in the system.","created_at":"2017-10-13T15:54:48Z","updated_at":"2017-10-13T16:34:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9d57d7b58eab43a59fd8034877bcfe720d4bb393","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/dmlc/tvm/pulls/549/commits","review_comments_url":"https://api.github.com/repos/dmlc/tvm/pulls/549/comments","review_comment_url":"https://api.github.com/repos/dmlc/tvm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dmlc/tvm/issues/549/comments","statuses_url":"https://api.github.com/repos/dmlc/tvm/statuses/32cc82eaff475055144003361eec9a4e9f497a7d","head":{"label":"adityaatluri:rocm-autodetect","ref":"rocm-autodetect","sha":"32cc82eaff475055144003361eec9a4e9f497a7d","user":{"login":"adityaatluri","id":2188479,"avatar_url":"https://avatars3.githubusercontent.com/u/2188479?v=4","gravatar_id":"","url":"https://api.github.com/users/adityaatluri","html_url":"https://github.com/adityaatluri","followers_url":"https://api.github.com/users/adityaatluri/followers","following_url":"https://api.github.com/users/adityaatluri/following{/other_user}","gists_url":"https://api.github.com/users/adityaatluri/gists{/gist_id}","starred_url":"https://api.github.com/users/adityaatluri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adityaatluri/subscriptions","organizations_url":"https://api.github.com/users/adityaatluri/orgs","repos_url":"https://api.github.com/users/adityaatluri/repos","events_url":"https://api.github.com/users/adityaatluri/events{/privacy}","received_events_url":"https://api.github.com/users/adityaatluri/received_events","type":"User","site_admin":false},"repo":{"id":101938347,"name":"tvm","full_name":"adityaatluri/tvm","owner":{"login":"adityaatluri","id":2188479,"avatar_url":"https://avatars3.githubusercontent.com/u/2188479?v=4","gravatar_id":"","url":"https://api.github.com/users/adityaatluri","html_url":"https://github.com/adityaatluri","followers_url":"https://api.github.com/users/adityaatluri/followers","following_url":"https://api.github.com/users/adityaatluri/following{/other_user}","gists_url":"https://api.github.com/users/adityaatluri/gists{/gist_id}","starred_url":"https://api.github.com/users/adityaatluri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adityaatluri/subscriptions","organizations_url":"https://api.github.com/users/adityaatluri/orgs","repos_url":"https://api.github.com/users/adityaatluri/repos","events_url":"https://api.github.com/users/adityaatluri/events{/privacy}","received_events_url":"https://api.github.com/users/adityaatluri/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adityaatluri/tvm","description":"End to end Tensor IR/DSL stack for deploying deep learning workloads to hardwares","fork":true,"url":"https://api.github.com/repos/adityaatluri/tvm","forks_url":"https://api.github.com/repos/adityaatluri/tvm/forks","keys_url":"https://api.github.com/repos/adityaatluri/tvm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adityaatluri/tvm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adityaatluri/tvm/teams","hooks_url":"https://api.github.com/repos/adityaatluri/tvm/hooks","issue_events_url":"https://api.github.com/repos/adityaatluri/tvm/issues/events{/number}","events_url":"https://api.github.com/repos/adityaatluri/tvm/events","assignees_url":"https://api.github.com/repos/adityaatluri/tvm/assignees{/user}","branches_url":"https://api.github.com/repos/adityaatluri/tvm/branches{/branch}","tags_url":"https://api.github.com/repos/adityaatluri/tvm/tags","blobs_url":"https://api.github.com/repos/adityaatluri/tvm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adityaatluri/tvm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adityaatluri/tvm/git/refs{/sha}","trees_url":"https://api.github.com/repos/adityaatluri/tvm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adityaatluri/tvm/statuses/{sha}","languages_url":"https://api.github.com/repos/adityaatluri/tvm/languages","stargazers_url":"https://api.github.com/repos/adityaatluri/tvm/stargazers","contributors_url":"https://api.github.com/repos/adityaatluri/tvm/contributors","subscribers_url":"https://api.github.com/repos/adityaatluri/tvm/subscribers","subscription_url":"https://api.github.com/repos/adityaatluri/tvm/subscription","commits_url":"https://api.github.com/repos/adityaatluri/tvm/commits{/sha}","git_commits_url":"https://api.github.com/repos/adityaatluri/tvm/git/commits{/sha}","comments_url":"https://api.github.com/repos/adityaatluri/tvm/comments{/number}","issue_comment_url":"https://api.github.com/repos/adityaatluri/tvm/issues/comments{/number}","contents_url":"https://api.github.com/repos/adityaatluri/tvm/contents/{+path}","compare_url":"https://api.github.com/repos/adityaatluri/tvm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adityaatluri/tvm/merges","archive_url":"https://api.github.com/repos/adityaatluri/tvm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adityaatluri/tvm/downloads","issues_url":"https://api.github.com/repos/adityaatluri/tvm/issues{/number}","pulls_url":"https://api.github.com/repos/adityaatluri/tvm/pulls{/number}","milestones_url":"https://api.github.com/repos/adityaatluri/tvm/milestones{/number}","notifications_url":"https://api.github.com/repos/adityaatluri/tvm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adityaatluri/tvm/labels{/name}","releases_url":"https://api.github.com/repos/adityaatluri/tvm/releases{/id}","deployments_url":"https://api.github.com/repos/adityaatluri/tvm/deployments","created_at":"2017-08-30T23:34:33Z","updated_at":"2017-08-30T23:34:36Z","pushed_at":"2017-10-13T16:02:51Z","git_url":"git://github.com/adityaatluri/tvm.git","ssh_url":"git@github.com:adityaatluri/tvm.git","clone_url":"https://github.com/adityaatluri/tvm.git","svn_url":"https://github.com/adityaatluri/tvm","homepage":"","size":2547,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dmlc:master","ref":"master","sha":"74b0ca8676a3b84771e2ebad35ef7137ec2284c6","user":{"login":"dmlc","id":11508361,"avatar_url":"https://avatars2.githubusercontent.com/u/11508361?v=4","gravatar_id":"","url":"https://api.github.com/users/dmlc","html_url":"https://github.com/dmlc","followers_url":"https://api.github.com/users/dmlc/followers","following_url":"https://api.github.com/users/dmlc/following{/other_user}","gists_url":"https://api.github.com/users/dmlc/gists{/gist_id}","starred_url":"https://api.github.com/users/dmlc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmlc/subscriptions","organizations_url":"https://api.github.com/users/dmlc/orgs","repos_url":"https://api.github.com/users/dmlc/repos","events_url":"https://api.github.com/users/dmlc/events{/privacy}","received_events_url":"https://api.github.com/users/dmlc/received_events","type":"Organization","site_admin":false},"repo":{"id":70746484,"name":"tvm","full_name":"dmlc/tvm","owner":{"login":"dmlc","id":11508361,"avatar_url":"https://avatars2.githubusercontent.com/u/11508361?v=4","gravatar_id":"","url":"https://api.github.com/users/dmlc","html_url":"https://github.com/dmlc","followers_url":"https://api.github.com/users/dmlc/followers","following_url":"https://api.github.com/users/dmlc/following{/other_user}","gists_url":"https://api.github.com/users/dmlc/gists{/gist_id}","starred_url":"https://api.github.com/users/dmlc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmlc/subscriptions","organizations_url":"https://api.github.com/users/dmlc/orgs","repos_url":"https://api.github.com/users/dmlc/repos","events_url":"https://api.github.com/users/dmlc/events{/privacy}","received_events_url":"https://api.github.com/users/dmlc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dmlc/tvm","description":"End to end Tensor IR/DSL stack for deploying deep learning workloads to hardwares","fork":false,"url":"https://api.github.com/repos/dmlc/tvm","forks_url":"https://api.github.com/repos/dmlc/tvm/forks","keys_url":"https://api.github.com/repos/dmlc/tvm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dmlc/tvm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dmlc/tvm/teams","hooks_url":"https://api.github.com/repos/dmlc/tvm/hooks","issue_events_url":"https://api.github.com/repos/dmlc/tvm/issues/events{/number}","events_url":"https://api.github.com/repos/dmlc/tvm/events","assignees_url":"https://api.github.com/repos/dmlc/tvm/assignees{/user}","branches_url":"https://api.github.com/repos/dmlc/tvm/branches{/branch}","tags_url":"https://api.github.com/repos/dmlc/tvm/tags","blobs_url":"https://api.github.com/repos/dmlc/tvm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dmlc/tvm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dmlc/tvm/git/refs{/sha}","trees_url":"https://api.github.com/repos/dmlc/tvm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dmlc/tvm/statuses/{sha}","languages_url":"https://api.github.com/repos/dmlc/tvm/languages","stargazers_url":"https://api.github.com/repos/dmlc/tvm/stargazers","contributors_url":"https://api.github.com/repos/dmlc/tvm/contributors","subscribers_url":"https://api.github.com/repos/dmlc/tvm/subscribers","subscription_url":"https://api.github.com/repos/dmlc/tvm/subscription","commits_url":"https://api.github.com/repos/dmlc/tvm/commits{/sha}","git_commits_url":"https://api.github.com/repos/dmlc/tvm/git/commits{/sha}","comments_url":"https://api.github.com/repos/dmlc/tvm/comments{/number}","issue_comment_url":"https://api.github.com/repos/dmlc/tvm/issues/comments{/number}","contents_url":"https://api.github.com/repos/dmlc/tvm/contents/{+path}","compare_url":"https://api.github.com/repos/dmlc/tvm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dmlc/tvm/merges","archive_url":"https://api.github.com/repos/dmlc/tvm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dmlc/tvm/downloads","issues_url":"https://api.github.com/repos/dmlc/tvm/issues{/number}","pulls_url":"https://api.github.com/repos/dmlc/tvm/pulls{/number}","milestones_url":"https://api.github.com/repos/dmlc/tvm/milestones{/number}","notifications_url":"https://api.github.com/repos/dmlc/tvm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dmlc/tvm/labels{/name}","releases_url":"https://api.github.com/repos/dmlc/tvm/releases{/id}","deployments_url":"https://api.github.com/repos/dmlc/tvm/deployments","created_at":"2016-10-12T22:20:28Z","updated_at":"2017-10-13T15:19:02Z","pushed_at":"2017-10-13T16:28:33Z","git_url":"git://github.com/dmlc/tvm.git","ssh_url":"git@github.com:dmlc/tvm.git","clone_url":"https://github.com/dmlc/tvm.git","svn_url":"https://github.com/dmlc/tvm","homepage":"","size":2556,"stargazers_count":784,"watchers_count":784,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":112,"mirror_url":null,"open_issues_count":22,"forks":112,"open_issues":22,"watchers":784,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dmlc/tvm/pulls/549"},"html":{"href":"https://github.com/dmlc/tvm/pull/549"},"issue":{"href":"https://api.github.com/repos/dmlc/tvm/issues/549"},"comments":{"href":"https://api.github.com/repos/dmlc/tvm/issues/549/comments"},"review_comments":{"href":"https://api.github.com/repos/dmlc/tvm/pulls/549/comments"},"review_comment":{"href":"https://api.github.com/repos/dmlc/tvm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dmlc/tvm/pulls/549/commits"},"statuses":{"href":"https://api.github.com/repos/dmlc/tvm/statuses/32cc82eaff475055144003361eec9a4e9f497a7d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"tqchen"}}