{"action":"created","comment":{"url":"https://api.github.com/repos/apache/zeppelin/pulls/comments/114926875","pull_request_review_id":36429687,"id":114926875,"diff_hunk":"@@ -135,15 +135,18 @@ ldapRealm.contextFactory.environment[ldap.searchBase] = dc=COMPANY,dc=COM\n ldapRealm.contextFactory.url = ldap://ldap.test.com:389\n ldapRealm.userDnTemplate = uid={0},ou=Users,dc=COMPANY,dc=COM\n ldapRealm.contextFactory.authenticationMechanism = SIMPLE\n+ldapRealm.contextFactory.systemUsername = cn=admin,dc=COMPANY,dc=COM\n+ldapRealm.contextFactory.systemPassword = bindPassword\n+securityManager.realms = $ldapRealm","path":"docs/security/shiroauthentication.md","position":6,"original_position":6,"commit_id":"15c22cd5f456e3ef817bcdf0e982b4a87672d599","original_commit_id":"15c22cd5f456e3ef817bcdf0e982b4a87672d599","user":{"login":"felixcheung","id":8969467,"avatar_url":"https://avatars0.githubusercontent.com/u/8969467?v=3","gravatar_id":"","url":"https://api.github.com/users/felixcheung","html_url":"https://github.com/felixcheung","followers_url":"https://api.github.com/users/felixcheung/followers","following_url":"https://api.github.com/users/felixcheung/following{/other_user}","gists_url":"https://api.github.com/users/felixcheung/gists{/gist_id}","starred_url":"https://api.github.com/users/felixcheung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felixcheung/subscriptions","organizations_url":"https://api.github.com/users/felixcheung/orgs","repos_url":"https://api.github.com/users/felixcheung/repos","events_url":"https://api.github.com/users/felixcheung/events{/privacy}","received_events_url":"https://api.github.com/users/felixcheung/received_events","type":"User","site_admin":false},"body":"is there description on when or how to use this?","created_at":"2017-05-05T03:20:36Z","updated_at":"2017-05-05T03:20:39Z","html_url":"https://github.com/apache/zeppelin/pull/2321#discussion_r114926875","pull_request_url":"https://api.github.com/repos/apache/zeppelin/pulls/2321","_links":{"self":{"href":"https://api.github.com/repos/apache/zeppelin/pulls/comments/114926875"},"html":{"href":"https://github.com/apache/zeppelin/pull/2321#discussion_r114926875"},"pull_request":{"href":"https://api.github.com/repos/apache/zeppelin/pulls/2321"}}},"pull_request":{"url":"https://api.github.com/repos/apache/zeppelin/pulls/2321","id":118992438,"html_url":"https://github.com/apache/zeppelin/pull/2321","diff_url":"https://github.com/apache/zeppelin/pull/2321.diff","patch_url":"https://github.com/apache/zeppelin/pull/2321.patch","issue_url":"https://api.github.com/repos/apache/zeppelin/issues/2321","number":2321,"state":"open","locked":false,"title":"[ZEPPELIN-2498] add more info and config for Ldap authentication ","user":{"login":"khalidhuseynov","id":1642088,"avatar_url":"https://avatars2.githubusercontent.com/u/1642088?v=3","gravatar_id":"","url":"https://api.github.com/users/khalidhuseynov","html_url":"https://github.com/khalidhuseynov","followers_url":"https://api.github.com/users/khalidhuseynov/followers","following_url":"https://api.github.com/users/khalidhuseynov/following{/other_user}","gists_url":"https://api.github.com/users/khalidhuseynov/gists{/gist_id}","starred_url":"https://api.github.com/users/khalidhuseynov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khalidhuseynov/subscriptions","organizations_url":"https://api.github.com/users/khalidhuseynov/orgs","repos_url":"https://api.github.com/users/khalidhuseynov/repos","events_url":"https://api.github.com/users/khalidhuseynov/events{/privacy}","received_events_url":"https://api.github.com/users/khalidhuseynov/received_events","type":"User","site_admin":false},"body":"### What is this PR for?\r\nThis is to add some necessary configs for ldap authentication.\r\n\r\n\r\n### What type of PR is it?\r\nImprovement |Documentation\r\n\r\n### Todos\r\n* [x] - add system user and security manager info\r\n* [ ] - address feedback\r\n\r\n### What is the Jira issue?\r\n[ZEPPELIN-2498](https://issues.apache.org/jira/browse/ZEPPELIN-2498)\r\n\r\n### How should this be tested?\r\n1. copy `conf/shiro.ini.template` into `conf/shiro.ini`\r\n2. fill out the fields for `LdapGroupRealm` in `shiro.ini` with info from your ldap server\r\n3. login with your own ldap credentials\r\n\r\n### Screenshots (if appropriate)\r\n\r\n### Questions:\r\n* Does the licenses files need update? no\r\n* Is there breaking changes for older versions? no\r\n* Does this needs documentation? no\r\n","created_at":"2017-05-04T14:52:03Z","updated_at":"2017-05-05T03:20:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"be762f23459d241d7452debb2b49e9304fefb22b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/zeppelin/pulls/2321/commits","review_comments_url":"https://api.github.com/repos/apache/zeppelin/pulls/2321/comments","review_comment_url":"https://api.github.com/repos/apache/zeppelin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/zeppelin/issues/2321/comments","statuses_url":"https://api.github.com/repos/apache/zeppelin/statuses/15c22cd5f456e3ef817bcdf0e982b4a87672d599","head":{"label":"khalidhuseynov:fix/ZEPPELIN-2498","ref":"fix/ZEPPELIN-2498","sha":"15c22cd5f456e3ef817bcdf0e982b4a87672d599","user":{"login":"khalidhuseynov","id":1642088,"avatar_url":"https://avatars2.githubusercontent.com/u/1642088?v=3","gravatar_id":"","url":"https://api.github.com/users/khalidhuseynov","html_url":"https://github.com/khalidhuseynov","followers_url":"https://api.github.com/users/khalidhuseynov/followers","following_url":"https://api.github.com/users/khalidhuseynov/following{/other_user}","gists_url":"https://api.github.com/users/khalidhuseynov/gists{/gist_id}","starred_url":"https://api.github.com/users/khalidhuseynov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khalidhuseynov/subscriptions","organizations_url":"https://api.github.com/users/khalidhuseynov/orgs","repos_url":"https://api.github.com/users/khalidhuseynov/repos","events_url":"https://api.github.com/users/khalidhuseynov/events{/privacy}","received_events_url":"https://api.github.com/users/khalidhuseynov/received_events","type":"User","site_admin":false},"repo":{"id":33517255,"name":"zeppelin","full_name":"khalidhuseynov/zeppelin","owner":{"login":"khalidhuseynov","id":1642088,"avatar_url":"https://avatars2.githubusercontent.com/u/1642088?v=3","gravatar_id":"","url":"https://api.github.com/users/khalidhuseynov","html_url":"https://github.com/khalidhuseynov","followers_url":"https://api.github.com/users/khalidhuseynov/followers","following_url":"https://api.github.com/users/khalidhuseynov/following{/other_user}","gists_url":"https://api.github.com/users/khalidhuseynov/gists{/gist_id}","starred_url":"https://api.github.com/users/khalidhuseynov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khalidhuseynov/subscriptions","organizations_url":"https://api.github.com/users/khalidhuseynov/orgs","repos_url":"https://api.github.com/users/khalidhuseynov/repos","events_url":"https://api.github.com/users/khalidhuseynov/events{/privacy}","received_events_url":"https://api.github.com/users/khalidhuseynov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/khalidhuseynov/zeppelin","description":"Mirror of Apache Zeppelin (Incubating)","fork":true,"url":"https://api.github.com/repos/khalidhuseynov/zeppelin","forks_url":"https://api.github.com/repos/khalidhuseynov/zeppelin/forks","keys_url":"https://api.github.com/repos/khalidhuseynov/zeppelin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/khalidhuseynov/zeppelin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/khalidhuseynov/zeppelin/teams","hooks_url":"https://api.github.com/repos/khalidhuseynov/zeppelin/hooks","issue_events_url":"https://api.github.com/repos/khalidhuseynov/zeppelin/issues/events{/number}","events_url":"https://api.github.com/repos/khalidhuseynov/zeppelin/events","assignees_url":"https://api.github.com/repos/khalidhuseynov/zeppelin/assignees{/user}","branches_url":"https://api.github.com/repos/khalidhuseynov/zeppelin/branches{/branch}","tags_url":"https://api.github.com/repos/khalidhuseynov/zeppelin/tags","blobs_url":"https://api.github.com/repos/khalidhuseynov/zeppelin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/khalidhuseynov/zeppelin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/khalidhuseynov/zeppelin/git/refs{/sha}","trees_url":"https://api.github.com/repos/khalidhuseynov/zeppelin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/khalidhuseynov/zeppelin/statuses/{sha}","languages_url":"https://api.github.com/repos/khalidhuseynov/zeppelin/languages","stargazers_url":"https://api.github.com/repos/khalidhuseynov/zeppelin/stargazers","contributors_url":"https://api.github.com/repos/khalidhuseynov/zeppelin/contributors","subscribers_url":"https://api.github.com/repos/khalidhuseynov/zeppelin/subscribers","subscription_url":"https://api.github.com/repos/khalidhuseynov/zeppelin/subscription","commits_url":"https://api.github.com/repos/khalidhuseynov/zeppelin/commits{/sha}","git_commits_url":"https://api.github.com/repos/khalidhuseynov/zeppelin/git/commits{/sha}","comments_url":"https://api.github.com/repos/khalidhuseynov/zeppelin/comments{/number}","issue_comment_url":"https://api.github.com/repos/khalidhuseynov/zeppelin/issues/comments{/number}","contents_url":"https://api.github.com/repos/khalidhuseynov/zeppelin/contents/{+path}","compare_url":"https://api.github.com/repos/khalidhuseynov/zeppelin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/khalidhuseynov/zeppelin/merges","archive_url":"https://api.github.com/repos/khalidhuseynov/zeppelin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/khalidhuseynov/zeppelin/downloads","issues_url":"https://api.github.com/repos/khalidhuseynov/zeppelin/issues{/number}","pulls_url":"https://api.github.com/repos/khalidhuseynov/zeppelin/pulls{/number}","milestones_url":"https://api.github.com/repos/khalidhuseynov/zeppelin/milestones{/number}","notifications_url":"https://api.github.com/repos/khalidhuseynov/zeppelin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/khalidhuseynov/zeppelin/labels{/name}","releases_url":"https://api.github.com/repos/khalidhuseynov/zeppelin/releases{/id}","deployments_url":"https://api.github.com/repos/khalidhuseynov/zeppelin/deployments","created_at":"2015-04-07T02:23:14Z","updated_at":"2017-03-20T17:22:52Z","pushed_at":"2017-05-04T14:43:05Z","git_url":"git://github.com/khalidhuseynov/zeppelin.git","ssh_url":"git@github.com:khalidhuseynov/zeppelin.git","clone_url":"https://github.com/khalidhuseynov/zeppelin.git","svn_url":"https://github.com/khalidhuseynov/zeppelin","homepage":null,"size":55157,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"bb72b3dea818fdeb3069e497db838d9dbcfd060d","user":{"login":"apache","id":47359,"avatar_url":"https://avatars3.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":32848140,"name":"zeppelin","full_name":"apache/zeppelin","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars3.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/zeppelin","description":"Mirror of Apache Zeppelin","fork":false,"url":"https://api.github.com/repos/apache/zeppelin","forks_url":"https://api.github.com/repos/apache/zeppelin/forks","keys_url":"https://api.github.com/repos/apache/zeppelin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/zeppelin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/zeppelin/teams","hooks_url":"https://api.github.com/repos/apache/zeppelin/hooks","issue_events_url":"https://api.github.com/repos/apache/zeppelin/issues/events{/number}","events_url":"https://api.github.com/repos/apache/zeppelin/events","assignees_url":"https://api.github.com/repos/apache/zeppelin/assignees{/user}","branches_url":"https://api.github.com/repos/apache/zeppelin/branches{/branch}","tags_url":"https://api.github.com/repos/apache/zeppelin/tags","blobs_url":"https://api.github.com/repos/apache/zeppelin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/zeppelin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/zeppelin/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/zeppelin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/zeppelin/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/zeppelin/languages","stargazers_url":"https://api.github.com/repos/apache/zeppelin/stargazers","contributors_url":"https://api.github.com/repos/apache/zeppelin/contributors","subscribers_url":"https://api.github.com/repos/apache/zeppelin/subscribers","subscription_url":"https://api.github.com/repos/apache/zeppelin/subscription","commits_url":"https://api.github.com/repos/apache/zeppelin/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/zeppelin/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/zeppelin/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/zeppelin/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/zeppelin/contents/{+path}","compare_url":"https://api.github.com/repos/apache/zeppelin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/zeppelin/merges","archive_url":"https://api.github.com/repos/apache/zeppelin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/zeppelin/downloads","issues_url":"https://api.github.com/repos/apache/zeppelin/issues{/number}","pulls_url":"https://api.github.com/repos/apache/zeppelin/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/zeppelin/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/zeppelin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/zeppelin/labels{/name}","releases_url":"https://api.github.com/repos/apache/zeppelin/releases{/id}","deployments_url":"https://api.github.com/repos/apache/zeppelin/deployments","created_at":"2015-03-25T07:00:06Z","updated_at":"2017-05-04T23:35:59Z","pushed_at":"2017-05-04T16:58:51Z","git_url":"git://github.com/apache/zeppelin.git","ssh_url":"git@github.com:apache/zeppelin.git","clone_url":"https://github.com/apache/zeppelin.git","svn_url":"https://github.com/apache/zeppelin","homepage":"","size":57572,"stargazers_count":2800,"watchers_count":2800,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1409,"mirror_url":"git://git.apache.org/incubator-zeppelin.git","open_issues_count":128,"forks":1409,"open_issues":128,"watchers":2800,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/zeppelin/pulls/2321"},"html":{"href":"https://github.com/apache/zeppelin/pull/2321"},"issue":{"href":"https://api.github.com/repos/apache/zeppelin/issues/2321"},"comments":{"href":"https://api.github.com/repos/apache/zeppelin/issues/2321/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/zeppelin/pulls/2321/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/zeppelin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/zeppelin/pulls/2321/commits"},"statuses":{"href":"https://api.github.com/repos/apache/zeppelin/statuses/15c22cd5f456e3ef817bcdf0e982b4a87672d599"}}}}
{"actor":{"display_login":"felixcheung"}}