{"action":"created","comment":{"url":"https://api.github.com/repos/electron/native-mate/pulls/comments/147093164","pull_request_review_id":72134160,"id":147093164,"diff_hunk":"@@ -24,8 +24,11 @@ WrappableBase::~WrappableBase() {\n }\n \n v8::Local<v8::Object> WrappableBase::GetWrapper() {\n-  CHECK(!wrapper_.IsEmpty());\n-  return v8::Local<v8::Object>::New(isolate_, wrapper_);\n+  DCHECK(!wrapper_.IsEmpty());\n+  if (!wrapper_.IsEmpty())\n+    return v8::Local<v8::Object>::New(isolate_, wrapper_);\n+  else\n+    return v8::Local<v8::Object>();","path":"native_mate/wrappable.cc","position":10,"original_position":10,"commit_id":"6ea2755095a6d5a73e94da5d4de11214201a1ce7","original_commit_id":"6ea2755095a6d5a73e94da5d4de11214201a1ce7","user":{"login":"zcbenz","id":639601,"avatar_url":"https://avatars0.githubusercontent.com/u/639601?v=4","gravatar_id":"","url":"https://api.github.com/users/zcbenz","html_url":"https://github.com/zcbenz","followers_url":"https://api.github.com/users/zcbenz/followers","following_url":"https://api.github.com/users/zcbenz/following{/other_user}","gists_url":"https://api.github.com/users/zcbenz/gists{/gist_id}","starred_url":"https://api.github.com/users/zcbenz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zcbenz/subscriptions","organizations_url":"https://api.github.com/users/zcbenz/orgs","repos_url":"https://api.github.com/users/zcbenz/repos","events_url":"https://api.github.com/users/zcbenz/events{/privacy}","received_events_url":"https://api.github.com/users/zcbenz/received_events","type":"User","site_admin":true},"body":"Yeah returning `MaybeLocal` would be better, but it requires changes on Electron's side, let's do it in another PR.","created_at":"2017-10-26T09:46:11Z","updated_at":"2017-10-26T09:46:11Z","html_url":"https://github.com/electron/native-mate/pull/15#discussion_r147093164","pull_request_url":"https://api.github.com/repos/electron/native-mate/pulls/15","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/electron/native-mate/pulls/comments/147093164"},"html":{"href":"https://github.com/electron/native-mate/pull/15#discussion_r147093164"},"pull_request":{"href":"https://api.github.com/repos/electron/native-mate/pulls/15"}},"in_reply_to_id":146633364},"pull_request":{"url":"https://api.github.com/repos/electron/native-mate/pulls/15","id":148307366,"html_url":"https://github.com/electron/native-mate/pull/15","diff_url":"https://github.com/electron/native-mate/pull/15.diff","patch_url":"https://github.com/electron/native-mate/pull/15.patch","issue_url":"https://api.github.com/repos/electron/native-mate/issues/15","number":15,"state":"open","locked":false,"title":"Upstream Muon changes to avoid crashing","user":{"login":"mgc","id":66737,"avatar_url":"https://avatars3.githubusercontent.com/u/66737?v=4","gravatar_id":"","url":"https://api.github.com/users/mgc","html_url":"https://github.com/mgc","followers_url":"https://api.github.com/users/mgc/followers","following_url":"https://api.github.com/users/mgc/following{/other_user}","gists_url":"https://api.github.com/users/mgc/gists{/gist_id}","starred_url":"https://api.github.com/users/mgc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgc/subscriptions","organizations_url":"https://api.github.com/users/mgc/orgs","repos_url":"https://api.github.com/users/mgc/repos","events_url":"https://api.github.com/users/mgc/events{/privacy}","received_events_url":"https://api.github.com/users/mgc/received_events","type":"User","site_admin":false},"body":"https://github.com/electron/electron/issues/10527 and possibly https://github.com/electron/electron/issues/10433 make me think something is subtly broken in native-mate.  As a workaround, how about we upstream these changes from Muon: brave/muon@58c0ec0#diff-a31bffb28ca1eed32c06c2d6b8b53f45 brave/muon#323\r\n","created_at":"2017-10-24T06:26:17Z","updated_at":"2017-10-26T09:46:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"282f9ebdcd4f2d19e100f590654e6ba09a05ea7a","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/electron/native-mate/pulls/15/commits","review_comments_url":"https://api.github.com/repos/electron/native-mate/pulls/15/comments","review_comment_url":"https://api.github.com/repos/electron/native-mate/pulls/comments{/number}","comments_url":"https://api.github.com/repos/electron/native-mate/issues/15/comments","statuses_url":"https://api.github.com/repos/electron/native-mate/statuses/6ea2755095a6d5a73e94da5d4de11214201a1ce7","head":{"label":"mgc:muon-crash-workarounds","ref":"muon-crash-workarounds","sha":"6ea2755095a6d5a73e94da5d4de11214201a1ce7","user":{"login":"mgc","id":66737,"avatar_url":"https://avatars3.githubusercontent.com/u/66737?v=4","gravatar_id":"","url":"https://api.github.com/users/mgc","html_url":"https://github.com/mgc","followers_url":"https://api.github.com/users/mgc/followers","following_url":"https://api.github.com/users/mgc/following{/other_user}","gists_url":"https://api.github.com/users/mgc/gists{/gist_id}","starred_url":"https://api.github.com/users/mgc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgc/subscriptions","organizations_url":"https://api.github.com/users/mgc/orgs","repos_url":"https://api.github.com/users/mgc/repos","events_url":"https://api.github.com/users/mgc/events{/privacy}","received_events_url":"https://api.github.com/users/mgc/received_events","type":"User","site_admin":false},"repo":{"id":108085403,"name":"native-mate","full_name":"mgc/native-mate","owner":{"login":"mgc","id":66737,"avatar_url":"https://avatars3.githubusercontent.com/u/66737?v=4","gravatar_id":"","url":"https://api.github.com/users/mgc","html_url":"https://github.com/mgc","followers_url":"https://api.github.com/users/mgc/followers","following_url":"https://api.github.com/users/mgc/following{/other_user}","gists_url":"https://api.github.com/users/mgc/gists{/gist_id}","starred_url":"https://api.github.com/users/mgc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgc/subscriptions","organizations_url":"https://api.github.com/users/mgc/orgs","repos_url":"https://api.github.com/users/mgc/repos","events_url":"https://api.github.com/users/mgc/events{/privacy}","received_events_url":"https://api.github.com/users/mgc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mgc/native-mate","description":"Fork of Chromium's gin library that makes it easier to marshal types between C++ and JavaScript.","fork":true,"url":"https://api.github.com/repos/mgc/native-mate","forks_url":"https://api.github.com/repos/mgc/native-mate/forks","keys_url":"https://api.github.com/repos/mgc/native-mate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mgc/native-mate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mgc/native-mate/teams","hooks_url":"https://api.github.com/repos/mgc/native-mate/hooks","issue_events_url":"https://api.github.com/repos/mgc/native-mate/issues/events{/number}","events_url":"https://api.github.com/repos/mgc/native-mate/events","assignees_url":"https://api.github.com/repos/mgc/native-mate/assignees{/user}","branches_url":"https://api.github.com/repos/mgc/native-mate/branches{/branch}","tags_url":"https://api.github.com/repos/mgc/native-mate/tags","blobs_url":"https://api.github.com/repos/mgc/native-mate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mgc/native-mate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mgc/native-mate/git/refs{/sha}","trees_url":"https://api.github.com/repos/mgc/native-mate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mgc/native-mate/statuses/{sha}","languages_url":"https://api.github.com/repos/mgc/native-mate/languages","stargazers_url":"https://api.github.com/repos/mgc/native-mate/stargazers","contributors_url":"https://api.github.com/repos/mgc/native-mate/contributors","subscribers_url":"https://api.github.com/repos/mgc/native-mate/subscribers","subscription_url":"https://api.github.com/repos/mgc/native-mate/subscription","commits_url":"https://api.github.com/repos/mgc/native-mate/commits{/sha}","git_commits_url":"https://api.github.com/repos/mgc/native-mate/git/commits{/sha}","comments_url":"https://api.github.com/repos/mgc/native-mate/comments{/number}","issue_comment_url":"https://api.github.com/repos/mgc/native-mate/issues/comments{/number}","contents_url":"https://api.github.com/repos/mgc/native-mate/contents/{+path}","compare_url":"https://api.github.com/repos/mgc/native-mate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mgc/native-mate/merges","archive_url":"https://api.github.com/repos/mgc/native-mate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mgc/native-mate/downloads","issues_url":"https://api.github.com/repos/mgc/native-mate/issues{/number}","pulls_url":"https://api.github.com/repos/mgc/native-mate/pulls{/number}","milestones_url":"https://api.github.com/repos/mgc/native-mate/milestones{/number}","notifications_url":"https://api.github.com/repos/mgc/native-mate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mgc/native-mate/labels{/name}","releases_url":"https://api.github.com/repos/mgc/native-mate/releases{/id}","deployments_url":"https://api.github.com/repos/mgc/native-mate/deployments","created_at":"2017-10-24T06:21:21Z","updated_at":"2017-10-24T06:21:23Z","pushed_at":"2017-10-24T06:22:16Z","git_url":"git://github.com/mgc/native-mate.git","ssh_url":"git@github.com:mgc/native-mate.git","clone_url":"https://github.com/mgc/native-mate.git","svn_url":"https://github.com/mgc/native-mate","homepage":"","size":150,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"electron:master","ref":"master","sha":"f047bb61bbd985079dd93e7ed322999550efed1d","user":{"login":"electron","id":13409222,"avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"repo":{"id":18785590,"name":"native-mate","full_name":"electron/native-mate","owner":{"login":"electron","id":13409222,"avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/electron/native-mate","description":"Fork of Chromium's gin library that makes it easier to marshal types between C++ and JavaScript.","fork":false,"url":"https://api.github.com/repos/electron/native-mate","forks_url":"https://api.github.com/repos/electron/native-mate/forks","keys_url":"https://api.github.com/repos/electron/native-mate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/electron/native-mate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/electron/native-mate/teams","hooks_url":"https://api.github.com/repos/electron/native-mate/hooks","issue_events_url":"https://api.github.com/repos/electron/native-mate/issues/events{/number}","events_url":"https://api.github.com/repos/electron/native-mate/events","assignees_url":"https://api.github.com/repos/electron/native-mate/assignees{/user}","branches_url":"https://api.github.com/repos/electron/native-mate/branches{/branch}","tags_url":"https://api.github.com/repos/electron/native-mate/tags","blobs_url":"https://api.github.com/repos/electron/native-mate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/electron/native-mate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/electron/native-mate/git/refs{/sha}","trees_url":"https://api.github.com/repos/electron/native-mate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/electron/native-mate/statuses/{sha}","languages_url":"https://api.github.com/repos/electron/native-mate/languages","stargazers_url":"https://api.github.com/repos/electron/native-mate/stargazers","contributors_url":"https://api.github.com/repos/electron/native-mate/contributors","subscribers_url":"https://api.github.com/repos/electron/native-mate/subscribers","subscription_url":"https://api.github.com/repos/electron/native-mate/subscription","commits_url":"https://api.github.com/repos/electron/native-mate/commits{/sha}","git_commits_url":"https://api.github.com/repos/electron/native-mate/git/commits{/sha}","comments_url":"https://api.github.com/repos/electron/native-mate/comments{/number}","issue_comment_url":"https://api.github.com/repos/electron/native-mate/issues/comments{/number}","contents_url":"https://api.github.com/repos/electron/native-mate/contents/{+path}","compare_url":"https://api.github.com/repos/electron/native-mate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/electron/native-mate/merges","archive_url":"https://api.github.com/repos/electron/native-mate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/electron/native-mate/downloads","issues_url":"https://api.github.com/repos/electron/native-mate/issues{/number}","pulls_url":"https://api.github.com/repos/electron/native-mate/pulls{/number}","milestones_url":"https://api.github.com/repos/electron/native-mate/milestones{/number}","notifications_url":"https://api.github.com/repos/electron/native-mate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/electron/native-mate/labels{/name}","releases_url":"https://api.github.com/repos/electron/native-mate/releases{/id}","deployments_url":"https://api.github.com/repos/electron/native-mate/deployments","created_at":"2014-04-15T03:05:23Z","updated_at":"2017-05-18T12:02:59Z","pushed_at":"2017-10-24T06:26:18Z","git_url":"git://github.com/electron/native-mate.git","ssh_url":"git@github.com:electron/native-mate.git","clone_url":"https://github.com/electron/native-mate.git","svn_url":"https://github.com/electron/native-mate","homepage":"","size":149,"stargazers_count":21,"watchers_count":21,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"archived":false,"open_issues_count":1,"forks":22,"open_issues":1,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/electron/native-mate/pulls/15"},"html":{"href":"https://github.com/electron/native-mate/pull/15"},"issue":{"href":"https://api.github.com/repos/electron/native-mate/issues/15"},"comments":{"href":"https://api.github.com/repos/electron/native-mate/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/electron/native-mate/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/electron/native-mate/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/electron/native-mate/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/electron/native-mate/statuses/6ea2755095a6d5a73e94da5d4de11214201a1ce7"}},"author_association":"NONE"}}
{"actor":{"display_login":"zcbenz"}}