{"action":"created","comment":{"url":"https://api.github.com/repos/percona/percona-xtrabackup/pulls/comments/106304458","pull_request_review_id":27220300,"id":106304458,"diff_hunk":"@@ -4670,9 +4672,14 @@ fil_load_single_table_tablespaces(ibool (*pred)(const char*, const char*))\n \t\t\t    \"%s/%s\", fil_path_to_mysql_datadir, dbinfo.name);\n \t\tsrv_normalize_path_for_win(dbpath);\n \n-\t\t/* We want wrong directory permissions to be a fatal error for\n-\t\tXtraBackup. */\n-\t\tdbdir = os_file_opendir(dbpath, TRUE);\n+\t\tif (check_if_skip_database_by_path(dbpath)) {\n+\t\t\tfprintf(stderr, \"Skipping db: %s\\n\", dbpath);\n+\t\t\tdbdir = NULL;\n+\t\t} else {\n+\t\t\t/* We want wrong directory permissions to be a fatal error for","path":"storage/innobase/fil/fil0fil.cc","position":20,"original_position":20,"commit_id":"e35c56d3e74b781cd993380835e9fa9bc16c557e","original_commit_id":"e35c56d3e74b781cd993380835e9fa9bc16c557e","user":{"login":"gl-sergei","id":371194,"avatar_url":"https://avatars0.githubusercontent.com/u/371194?v=3","gravatar_id":"","url":"https://api.github.com/users/gl-sergei","html_url":"https://github.com/gl-sergei","followers_url":"https://api.github.com/users/gl-sergei/followers","following_url":"https://api.github.com/users/gl-sergei/following{/other_user}","gists_url":"https://api.github.com/users/gl-sergei/gists{/gist_id}","starred_url":"https://api.github.com/users/gl-sergei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gl-sergei/subscriptions","organizations_url":"https://api.github.com/users/gl-sergei/orgs","repos_url":"https://api.github.com/users/gl-sergei/repos","events_url":"https://api.github.com/users/gl-sergei/events{/privacy}","received_events_url":"https://api.github.com/users/gl-sergei/received_events","type":"User","site_admin":false},"body":"too long line","created_at":"2017-03-15T23:03:03Z","updated_at":"2017-03-15T23:21:46Z","html_url":"https://github.com/percona/percona-xtrabackup/pull/331#discussion_r106304458","pull_request_url":"https://api.github.com/repos/percona/percona-xtrabackup/pulls/331","_links":{"self":{"href":"https://api.github.com/repos/percona/percona-xtrabackup/pulls/comments/106304458"},"html":{"href":"https://github.com/percona/percona-xtrabackup/pull/331#discussion_r106304458"},"pull_request":{"href":"https://api.github.com/repos/percona/percona-xtrabackup/pulls/331"}}},"pull_request":{"url":"https://api.github.com/repos/percona/percona-xtrabackup/pulls/331","id":110558017,"html_url":"https://github.com/percona/percona-xtrabackup/pull/331","diff_url":"https://github.com/percona/percona-xtrabackup/pull/331.diff","patch_url":"https://github.com/percona/percona-xtrabackup/pull/331.patch","issue_url":"https://api.github.com/repos/percona/percona-xtrabackup/issues/331","number":331,"state":"open","locked":false,"title":"Bug 1272329: innobackupex dies if a directory is not readable. i.e.: …","user":{"login":"VasilyNemkov","id":25636892,"avatar_url":"https://avatars0.githubusercontent.com/u/25636892?v=3","gravatar_id":"","url":"https://api.github.com/users/VasilyNemkov","html_url":"https://github.com/VasilyNemkov","followers_url":"https://api.github.com/users/VasilyNemkov/followers","following_url":"https://api.github.com/users/VasilyNemkov/following{/other_user}","gists_url":"https://api.github.com/users/VasilyNemkov/gists{/gist_id}","starred_url":"https://api.github.com/users/VasilyNemkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VasilyNemkov/subscriptions","organizations_url":"https://api.github.com/users/VasilyNemkov/orgs","repos_url":"https://api.github.com/users/VasilyNemkov/repos","events_url":"https://api.github.com/users/VasilyNemkov/events{/privacy}","received_events_url":"https://api.github.com/users/VasilyNemkov/received_events","type":"User","site_admin":false},"body":"…lost+found\r\n\r\nIntroducing new options: --tables-exclude and --databases-exclude that work\r\nsimilary to --tables and --databases, but exclude given names/paths from backup.\r\nUpdated a xb_databases_options test to verify new options interoperation with existing ones.\r\n\r\nUnreadable directory can now be excluded with --databases-exclude=path, see test for details.\r\n\r\nParam-build: http://jenkins.percona.com/view/PXB%202.3/job/percona-xtrabackup-2.3-param/245/","created_at":"2017-03-14T06:51:08Z","updated_at":"2017-03-15T23:21:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"259c846ba7ed1a356bf4f52c32e9cb98276e62c3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/percona/percona-xtrabackup/pulls/331/commits","review_comments_url":"https://api.github.com/repos/percona/percona-xtrabackup/pulls/331/comments","review_comment_url":"https://api.github.com/repos/percona/percona-xtrabackup/pulls/comments{/number}","comments_url":"https://api.github.com/repos/percona/percona-xtrabackup/issues/331/comments","statuses_url":"https://api.github.com/repos/percona/percona-xtrabackup/statuses/e35c56d3e74b781cd993380835e9fa9bc16c557e","head":{"label":"VasilyNemkov:2.3-xb-bug1272329","ref":"2.3-xb-bug1272329","sha":"e35c56d3e74b781cd993380835e9fa9bc16c557e","user":{"login":"VasilyNemkov","id":25636892,"avatar_url":"https://avatars0.githubusercontent.com/u/25636892?v=3","gravatar_id":"","url":"https://api.github.com/users/VasilyNemkov","html_url":"https://github.com/VasilyNemkov","followers_url":"https://api.github.com/users/VasilyNemkov/followers","following_url":"https://api.github.com/users/VasilyNemkov/following{/other_user}","gists_url":"https://api.github.com/users/VasilyNemkov/gists{/gist_id}","starred_url":"https://api.github.com/users/VasilyNemkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VasilyNemkov/subscriptions","organizations_url":"https://api.github.com/users/VasilyNemkov/orgs","repos_url":"https://api.github.com/users/VasilyNemkov/repos","events_url":"https://api.github.com/users/VasilyNemkov/events{/privacy}","received_events_url":"https://api.github.com/users/VasilyNemkov/received_events","type":"User","site_admin":false},"repo":{"id":81920080,"name":"percona-xtrabackup","full_name":"VasilyNemkov/percona-xtrabackup","owner":{"login":"VasilyNemkov","id":25636892,"avatar_url":"https://avatars0.githubusercontent.com/u/25636892?v=3","gravatar_id":"","url":"https://api.github.com/users/VasilyNemkov","html_url":"https://github.com/VasilyNemkov","followers_url":"https://api.github.com/users/VasilyNemkov/followers","following_url":"https://api.github.com/users/VasilyNemkov/following{/other_user}","gists_url":"https://api.github.com/users/VasilyNemkov/gists{/gist_id}","starred_url":"https://api.github.com/users/VasilyNemkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VasilyNemkov/subscriptions","organizations_url":"https://api.github.com/users/VasilyNemkov/orgs","repos_url":"https://api.github.com/users/VasilyNemkov/repos","events_url":"https://api.github.com/users/VasilyNemkov/events{/privacy}","received_events_url":"https://api.github.com/users/VasilyNemkov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/VasilyNemkov/percona-xtrabackup","description":"Open source hot backup tool for InnoDB and XtraDB databases","fork":true,"url":"https://api.github.com/repos/VasilyNemkov/percona-xtrabackup","forks_url":"https://api.github.com/repos/VasilyNemkov/percona-xtrabackup/forks","keys_url":"https://api.github.com/repos/VasilyNemkov/percona-xtrabackup/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VasilyNemkov/percona-xtrabackup/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VasilyNemkov/percona-xtrabackup/teams","hooks_url":"https://api.github.com/repos/VasilyNemkov/percona-xtrabackup/hooks","issue_events_url":"https://api.github.com/repos/VasilyNemkov/percona-xtrabackup/issues/events{/number}","events_url":"https://api.github.com/repos/VasilyNemkov/percona-xtrabackup/events","assignees_url":"https://api.github.com/repos/VasilyNemkov/percona-xtrabackup/assignees{/user}","branches_url":"https://api.github.com/repos/VasilyNemkov/percona-xtrabackup/branches{/branch}","tags_url":"https://api.github.com/repos/VasilyNemkov/percona-xtrabackup/tags","blobs_url":"https://api.github.com/repos/VasilyNemkov/percona-xtrabackup/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VasilyNemkov/percona-xtrabackup/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VasilyNemkov/percona-xtrabackup/git/refs{/sha}","trees_url":"https://api.github.com/repos/VasilyNemkov/percona-xtrabackup/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VasilyNemkov/percona-xtrabackup/statuses/{sha}","languages_url":"https://api.github.com/repos/VasilyNemkov/percona-xtrabackup/languages","stargazers_url":"https://api.github.com/repos/VasilyNemkov/percona-xtrabackup/stargazers","contributors_url":"https://api.github.com/repos/VasilyNemkov/percona-xtrabackup/contributors","subscribers_url":"https://api.github.com/repos/VasilyNemkov/percona-xtrabackup/subscribers","subscription_url":"https://api.github.com/repos/VasilyNemkov/percona-xtrabackup/subscription","commits_url":"https://api.github.com/repos/VasilyNemkov/percona-xtrabackup/commits{/sha}","git_commits_url":"https://api.github.com/repos/VasilyNemkov/percona-xtrabackup/git/commits{/sha}","comments_url":"https://api.github.com/repos/VasilyNemkov/percona-xtrabackup/comments{/number}","issue_comment_url":"https://api.github.com/repos/VasilyNemkov/percona-xtrabackup/issues/comments{/number}","contents_url":"https://api.github.com/repos/VasilyNemkov/percona-xtrabackup/contents/{+path}","compare_url":"https://api.github.com/repos/VasilyNemkov/percona-xtrabackup/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VasilyNemkov/percona-xtrabackup/merges","archive_url":"https://api.github.com/repos/VasilyNemkov/percona-xtrabackup/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VasilyNemkov/percona-xtrabackup/downloads","issues_url":"https://api.github.com/repos/VasilyNemkov/percona-xtrabackup/issues{/number}","pulls_url":"https://api.github.com/repos/VasilyNemkov/percona-xtrabackup/pulls{/number}","milestones_url":"https://api.github.com/repos/VasilyNemkov/percona-xtrabackup/milestones{/number}","notifications_url":"https://api.github.com/repos/VasilyNemkov/percona-xtrabackup/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VasilyNemkov/percona-xtrabackup/labels{/name}","releases_url":"https://api.github.com/repos/VasilyNemkov/percona-xtrabackup/releases{/id}","deployments_url":"https://api.github.com/repos/VasilyNemkov/percona-xtrabackup/deployments","created_at":"2017-02-14T07:55:23Z","updated_at":"2017-02-14T07:56:53Z","pushed_at":"2017-03-15T17:55:06Z","git_url":"git://github.com/VasilyNemkov/percona-xtrabackup.git","ssh_url":"git@github.com:VasilyNemkov/percona-xtrabackup.git","clone_url":"https://github.com/VasilyNemkov/percona-xtrabackup.git","svn_url":"https://github.com/VasilyNemkov/percona-xtrabackup","homepage":"","size":522290,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"2.3"}},"base":{"label":"percona:2.3","ref":"2.3","sha":"b376b075481f59370db1dc0e7878221ea2100bd8","user":{"login":"percona","id":1683025,"avatar_url":"https://avatars3.githubusercontent.com/u/1683025?v=3","gravatar_id":"","url":"https://api.github.com/users/percona","html_url":"https://github.com/percona","followers_url":"https://api.github.com/users/percona/followers","following_url":"https://api.github.com/users/percona/following{/other_user}","gists_url":"https://api.github.com/users/percona/gists{/gist_id}","starred_url":"https://api.github.com/users/percona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/percona/subscriptions","organizations_url":"https://api.github.com/users/percona/orgs","repos_url":"https://api.github.com/users/percona/repos","events_url":"https://api.github.com/users/percona/events{/privacy}","received_events_url":"https://api.github.com/users/percona/received_events","type":"Organization","site_admin":false},"repo":{"id":30753970,"name":"percona-xtrabackup","full_name":"percona/percona-xtrabackup","owner":{"login":"percona","id":1683025,"avatar_url":"https://avatars3.githubusercontent.com/u/1683025?v=3","gravatar_id":"","url":"https://api.github.com/users/percona","html_url":"https://github.com/percona","followers_url":"https://api.github.com/users/percona/followers","following_url":"https://api.github.com/users/percona/following{/other_user}","gists_url":"https://api.github.com/users/percona/gists{/gist_id}","starred_url":"https://api.github.com/users/percona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/percona/subscriptions","organizations_url":"https://api.github.com/users/percona/orgs","repos_url":"https://api.github.com/users/percona/repos","events_url":"https://api.github.com/users/percona/events{/privacy}","received_events_url":"https://api.github.com/users/percona/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/percona/percona-xtrabackup","description":"Open source hot backup tool for InnoDB and XtraDB databases","fork":false,"url":"https://api.github.com/repos/percona/percona-xtrabackup","forks_url":"https://api.github.com/repos/percona/percona-xtrabackup/forks","keys_url":"https://api.github.com/repos/percona/percona-xtrabackup/keys{/key_id}","collaborators_url":"https://api.github.com/repos/percona/percona-xtrabackup/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/percona/percona-xtrabackup/teams","hooks_url":"https://api.github.com/repos/percona/percona-xtrabackup/hooks","issue_events_url":"https://api.github.com/repos/percona/percona-xtrabackup/issues/events{/number}","events_url":"https://api.github.com/repos/percona/percona-xtrabackup/events","assignees_url":"https://api.github.com/repos/percona/percona-xtrabackup/assignees{/user}","branches_url":"https://api.github.com/repos/percona/percona-xtrabackup/branches{/branch}","tags_url":"https://api.github.com/repos/percona/percona-xtrabackup/tags","blobs_url":"https://api.github.com/repos/percona/percona-xtrabackup/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/percona/percona-xtrabackup/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/percona/percona-xtrabackup/git/refs{/sha}","trees_url":"https://api.github.com/repos/percona/percona-xtrabackup/git/trees{/sha}","statuses_url":"https://api.github.com/repos/percona/percona-xtrabackup/statuses/{sha}","languages_url":"https://api.github.com/repos/percona/percona-xtrabackup/languages","stargazers_url":"https://api.github.com/repos/percona/percona-xtrabackup/stargazers","contributors_url":"https://api.github.com/repos/percona/percona-xtrabackup/contributors","subscribers_url":"https://api.github.com/repos/percona/percona-xtrabackup/subscribers","subscription_url":"https://api.github.com/repos/percona/percona-xtrabackup/subscription","commits_url":"https://api.github.com/repos/percona/percona-xtrabackup/commits{/sha}","git_commits_url":"https://api.github.com/repos/percona/percona-xtrabackup/git/commits{/sha}","comments_url":"https://api.github.com/repos/percona/percona-xtrabackup/comments{/number}","issue_comment_url":"https://api.github.com/repos/percona/percona-xtrabackup/issues/comments{/number}","contents_url":"https://api.github.com/repos/percona/percona-xtrabackup/contents/{+path}","compare_url":"https://api.github.com/repos/percona/percona-xtrabackup/compare/{base}...{head}","merges_url":"https://api.github.com/repos/percona/percona-xtrabackup/merges","archive_url":"https://api.github.com/repos/percona/percona-xtrabackup/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/percona/percona-xtrabackup/downloads","issues_url":"https://api.github.com/repos/percona/percona-xtrabackup/issues{/number}","pulls_url":"https://api.github.com/repos/percona/percona-xtrabackup/pulls{/number}","milestones_url":"https://api.github.com/repos/percona/percona-xtrabackup/milestones{/number}","notifications_url":"https://api.github.com/repos/percona/percona-xtrabackup/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/percona/percona-xtrabackup/labels{/name}","releases_url":"https://api.github.com/repos/percona/percona-xtrabackup/releases{/id}","deployments_url":"https://api.github.com/repos/percona/percona-xtrabackup/deployments","created_at":"2015-02-13T11:40:22Z","updated_at":"2017-03-15T11:12:55Z","pushed_at":"2017-03-15T16:36:48Z","git_url":"git://github.com/percona/percona-xtrabackup.git","ssh_url":"git@github.com:percona/percona-xtrabackup.git","clone_url":"https://github.com/percona/percona-xtrabackup.git","svn_url":"https://github.com/percona/percona-xtrabackup","homepage":"","size":522317,"stargazers_count":151,"watchers_count":151,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":85,"mirror_url":null,"open_issues_count":10,"forks":85,"open_issues":10,"watchers":151,"default_branch":"2.3"}},"_links":{"self":{"href":"https://api.github.com/repos/percona/percona-xtrabackup/pulls/331"},"html":{"href":"https://github.com/percona/percona-xtrabackup/pull/331"},"issue":{"href":"https://api.github.com/repos/percona/percona-xtrabackup/issues/331"},"comments":{"href":"https://api.github.com/repos/percona/percona-xtrabackup/issues/331/comments"},"review_comments":{"href":"https://api.github.com/repos/percona/percona-xtrabackup/pulls/331/comments"},"review_comment":{"href":"https://api.github.com/repos/percona/percona-xtrabackup/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/percona/percona-xtrabackup/pulls/331/commits"},"statuses":{"href":"https://api.github.com/repos/percona/percona-xtrabackup/statuses/e35c56d3e74b781cd993380835e9fa9bc16c557e"}}}}
{"actor":{"display_login":"gl-sergei"}}