{"action":"created","comment":{"url":"https://api.github.com/repos/PolymerElements/paper-checkbox/pulls/comments/126565550","pull_request_review_id":49062004,"id":126565550,"diff_hunk":"@@ -274,7 +274,17 @@\n           var inkSize = this.getComputedStyleValue('--calculated-paper-checkbox-ink-size').trim();\n           // If unset, compute and set the default `--paper-checkbox-ink-size`.\n           if (inkSize === '-1px') {\n-            var checkboxSize = parseFloat(this.getComputedStyleValue('--calculated-paper-checkbox-size').trim());\n+            var checkboxSizeText = this.getComputedStyleValue('--calculated-paper-checkbox-size').trim();\n+\n+            // Is the value not in units of 'px'?","path":"paper-checkbox.html","position":7,"original_position":7,"commit_id":"69b3c67e479d90af5cba713758ee5ee12c50014d","original_commit_id":"69b3c67e479d90af5cba713758ee5ee12c50014d","user":{"login":"notwaldorf","id":1369170,"avatar_url":"https://avatars2.githubusercontent.com/u/1369170?v=3","gravatar_id":"","url":"https://api.github.com/users/notwaldorf","html_url":"https://github.com/notwaldorf","followers_url":"https://api.github.com/users/notwaldorf/followers","following_url":"https://api.github.com/users/notwaldorf/following{/other_user}","gists_url":"https://api.github.com/users/notwaldorf/gists{/gist_id}","starred_url":"https://api.github.com/users/notwaldorf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/notwaldorf/subscriptions","organizations_url":"https://api.github.com/users/notwaldorf/orgs","repos_url":"https://api.github.com/users/notwaldorf/repos","events_url":"https://api.github.com/users/notwaldorf/events{/privacy}","received_events_url":"https://api.github.com/users/notwaldorf/received_events","type":"User","site_admin":false},"body":"I would explain here _why_ we need to do this, because it's really not obvious why we can't do the `calc` in all cases","created_at":"2017-07-10T23:56:44Z","updated_at":"2017-07-10T23:56:48Z","html_url":"https://github.com/PolymerElements/paper-checkbox/pull/179#discussion_r126565550","pull_request_url":"https://api.github.com/repos/PolymerElements/paper-checkbox/pulls/179","_links":{"self":{"href":"https://api.github.com/repos/PolymerElements/paper-checkbox/pulls/comments/126565550"},"html":{"href":"https://github.com/PolymerElements/paper-checkbox/pull/179#discussion_r126565550"},"pull_request":{"href":"https://api.github.com/repos/PolymerElements/paper-checkbox/pulls/179"}}},"pull_request":{"url":"https://api.github.com/repos/PolymerElements/paper-checkbox/pulls/179","id":129795171,"html_url":"https://github.com/PolymerElements/paper-checkbox/pull/179","diff_url":"https://github.com/PolymerElements/paper-checkbox/pull/179.diff","patch_url":"https://github.com/PolymerElements/paper-checkbox/pull/179.patch","issue_url":"https://api.github.com/repos/PolymerElements/paper-checkbox/issues/179","number":179,"state":"open","locked":false,"title":"Fix ripples for checkboxes with `--paper-checkbox-size` in units other than 'px'.","user":{"login":"bicknellr","id":406614,"avatar_url":"https://avatars2.githubusercontent.com/u/406614?v=3","gravatar_id":"","url":"https://api.github.com/users/bicknellr","html_url":"https://github.com/bicknellr","followers_url":"https://api.github.com/users/bicknellr/followers","following_url":"https://api.github.com/users/bicknellr/following{/other_user}","gists_url":"https://api.github.com/users/bicknellr/gists{/gist_id}","starred_url":"https://api.github.com/users/bicknellr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bicknellr/subscriptions","organizations_url":"https://api.github.com/users/bicknellr/orgs","repos_url":"https://api.github.com/users/bicknellr/repos","events_url":"https://api.github.com/users/bicknellr/events{/privacy}","received_events_url":"https://api.github.com/users/bicknellr/received_events","type":"User","site_admin":false},"body":"Fixes #178.","created_at":"2017-07-10T23:31:03Z","updated_at":"2017-07-10T23:56:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"73d1b4860cb4621fbe5f1f77fb8ea103880f3d9e","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/PolymerElements/paper-checkbox/pulls/179/commits","review_comments_url":"https://api.github.com/repos/PolymerElements/paper-checkbox/pulls/179/comments","review_comment_url":"https://api.github.com/repos/PolymerElements/paper-checkbox/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PolymerElements/paper-checkbox/issues/179/comments","statuses_url":"https://api.github.com/repos/PolymerElements/paper-checkbox/statuses/69b3c67e479d90af5cba713758ee5ee12c50014d","head":{"label":"PolymerElements:non-px-ripple","ref":"non-px-ripple","sha":"69b3c67e479d90af5cba713758ee5ee12c50014d","user":{"login":"PolymerElements","id":11639138,"avatar_url":"https://avatars2.githubusercontent.com/u/11639138?v=3","gravatar_id":"","url":"https://api.github.com/users/PolymerElements","html_url":"https://github.com/PolymerElements","followers_url":"https://api.github.com/users/PolymerElements/followers","following_url":"https://api.github.com/users/PolymerElements/following{/other_user}","gists_url":"https://api.github.com/users/PolymerElements/gists{/gist_id}","starred_url":"https://api.github.com/users/PolymerElements/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolymerElements/subscriptions","organizations_url":"https://api.github.com/users/PolymerElements/orgs","repos_url":"https://api.github.com/users/PolymerElements/repos","events_url":"https://api.github.com/users/PolymerElements/events{/privacy}","received_events_url":"https://api.github.com/users/PolymerElements/received_events","type":"Organization","site_admin":false},"repo":{"id":33902006,"name":"paper-checkbox","full_name":"PolymerElements/paper-checkbox","owner":{"login":"PolymerElements","id":11639138,"avatar_url":"https://avatars2.githubusercontent.com/u/11639138?v=3","gravatar_id":"","url":"https://api.github.com/users/PolymerElements","html_url":"https://github.com/PolymerElements","followers_url":"https://api.github.com/users/PolymerElements/followers","following_url":"https://api.github.com/users/PolymerElements/following{/other_user}","gists_url":"https://api.github.com/users/PolymerElements/gists{/gist_id}","starred_url":"https://api.github.com/users/PolymerElements/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolymerElements/subscriptions","organizations_url":"https://api.github.com/users/PolymerElements/orgs","repos_url":"https://api.github.com/users/PolymerElements/repos","events_url":"https://api.github.com/users/PolymerElements/events{/privacy}","received_events_url":"https://api.github.com/users/PolymerElements/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PolymerElements/paper-checkbox","description":"A Material Design checkbox","fork":false,"url":"https://api.github.com/repos/PolymerElements/paper-checkbox","forks_url":"https://api.github.com/repos/PolymerElements/paper-checkbox/forks","keys_url":"https://api.github.com/repos/PolymerElements/paper-checkbox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PolymerElements/paper-checkbox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PolymerElements/paper-checkbox/teams","hooks_url":"https://api.github.com/repos/PolymerElements/paper-checkbox/hooks","issue_events_url":"https://api.github.com/repos/PolymerElements/paper-checkbox/issues/events{/number}","events_url":"https://api.github.com/repos/PolymerElements/paper-checkbox/events","assignees_url":"https://api.github.com/repos/PolymerElements/paper-checkbox/assignees{/user}","branches_url":"https://api.github.com/repos/PolymerElements/paper-checkbox/branches{/branch}","tags_url":"https://api.github.com/repos/PolymerElements/paper-checkbox/tags","blobs_url":"https://api.github.com/repos/PolymerElements/paper-checkbox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PolymerElements/paper-checkbox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PolymerElements/paper-checkbox/git/refs{/sha}","trees_url":"https://api.github.com/repos/PolymerElements/paper-checkbox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PolymerElements/paper-checkbox/statuses/{sha}","languages_url":"https://api.github.com/repos/PolymerElements/paper-checkbox/languages","stargazers_url":"https://api.github.com/repos/PolymerElements/paper-checkbox/stargazers","contributors_url":"https://api.github.com/repos/PolymerElements/paper-checkbox/contributors","subscribers_url":"https://api.github.com/repos/PolymerElements/paper-checkbox/subscribers","subscription_url":"https://api.github.com/repos/PolymerElements/paper-checkbox/subscription","commits_url":"https://api.github.com/repos/PolymerElements/paper-checkbox/commits{/sha}","git_commits_url":"https://api.github.com/repos/PolymerElements/paper-checkbox/git/commits{/sha}","comments_url":"https://api.github.com/repos/PolymerElements/paper-checkbox/comments{/number}","issue_comment_url":"https://api.github.com/repos/PolymerElements/paper-checkbox/issues/comments{/number}","contents_url":"https://api.github.com/repos/PolymerElements/paper-checkbox/contents/{+path}","compare_url":"https://api.github.com/repos/PolymerElements/paper-checkbox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PolymerElements/paper-checkbox/merges","archive_url":"https://api.github.com/repos/PolymerElements/paper-checkbox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PolymerElements/paper-checkbox/downloads","issues_url":"https://api.github.com/repos/PolymerElements/paper-checkbox/issues{/number}","pulls_url":"https://api.github.com/repos/PolymerElements/paper-checkbox/pulls{/number}","milestones_url":"https://api.github.com/repos/PolymerElements/paper-checkbox/milestones{/number}","notifications_url":"https://api.github.com/repos/PolymerElements/paper-checkbox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PolymerElements/paper-checkbox/labels{/name}","releases_url":"https://api.github.com/repos/PolymerElements/paper-checkbox/releases{/id}","deployments_url":"https://api.github.com/repos/PolymerElements/paper-checkbox/deployments","created_at":"2015-04-14T00:42:12Z","updated_at":"2017-07-03T10:00:43Z","pushed_at":"2017-07-10T23:31:03Z","git_url":"git://github.com/PolymerElements/paper-checkbox.git","ssh_url":"git@github.com:PolymerElements/paper-checkbox.git","clone_url":"https://github.com/PolymerElements/paper-checkbox.git","svn_url":"https://github.com/PolymerElements/paper-checkbox","homepage":"https://www.webcomponents.org/element/PolymerElements/paper-checkbox","size":181,"stargazers_count":44,"watchers_count":44,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":47,"mirror_url":null,"open_issues_count":38,"forks":47,"open_issues":38,"watchers":44,"default_branch":"master"}},"base":{"label":"PolymerElements:master","ref":"master","sha":"82512b7187a905d2b92401ad479f2930fe8ed38b","user":{"login":"PolymerElements","id":11639138,"avatar_url":"https://avatars2.githubusercontent.com/u/11639138?v=3","gravatar_id":"","url":"https://api.github.com/users/PolymerElements","html_url":"https://github.com/PolymerElements","followers_url":"https://api.github.com/users/PolymerElements/followers","following_url":"https://api.github.com/users/PolymerElements/following{/other_user}","gists_url":"https://api.github.com/users/PolymerElements/gists{/gist_id}","starred_url":"https://api.github.com/users/PolymerElements/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolymerElements/subscriptions","organizations_url":"https://api.github.com/users/PolymerElements/orgs","repos_url":"https://api.github.com/users/PolymerElements/repos","events_url":"https://api.github.com/users/PolymerElements/events{/privacy}","received_events_url":"https://api.github.com/users/PolymerElements/received_events","type":"Organization","site_admin":false},"repo":{"id":33902006,"name":"paper-checkbox","full_name":"PolymerElements/paper-checkbox","owner":{"login":"PolymerElements","id":11639138,"avatar_url":"https://avatars2.githubusercontent.com/u/11639138?v=3","gravatar_id":"","url":"https://api.github.com/users/PolymerElements","html_url":"https://github.com/PolymerElements","followers_url":"https://api.github.com/users/PolymerElements/followers","following_url":"https://api.github.com/users/PolymerElements/following{/other_user}","gists_url":"https://api.github.com/users/PolymerElements/gists{/gist_id}","starred_url":"https://api.github.com/users/PolymerElements/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolymerElements/subscriptions","organizations_url":"https://api.github.com/users/PolymerElements/orgs","repos_url":"https://api.github.com/users/PolymerElements/repos","events_url":"https://api.github.com/users/PolymerElements/events{/privacy}","received_events_url":"https://api.github.com/users/PolymerElements/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PolymerElements/paper-checkbox","description":"A Material Design checkbox","fork":false,"url":"https://api.github.com/repos/PolymerElements/paper-checkbox","forks_url":"https://api.github.com/repos/PolymerElements/paper-checkbox/forks","keys_url":"https://api.github.com/repos/PolymerElements/paper-checkbox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PolymerElements/paper-checkbox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PolymerElements/paper-checkbox/teams","hooks_url":"https://api.github.com/repos/PolymerElements/paper-checkbox/hooks","issue_events_url":"https://api.github.com/repos/PolymerElements/paper-checkbox/issues/events{/number}","events_url":"https://api.github.com/repos/PolymerElements/paper-checkbox/events","assignees_url":"https://api.github.com/repos/PolymerElements/paper-checkbox/assignees{/user}","branches_url":"https://api.github.com/repos/PolymerElements/paper-checkbox/branches{/branch}","tags_url":"https://api.github.com/repos/PolymerElements/paper-checkbox/tags","blobs_url":"https://api.github.com/repos/PolymerElements/paper-checkbox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PolymerElements/paper-checkbox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PolymerElements/paper-checkbox/git/refs{/sha}","trees_url":"https://api.github.com/repos/PolymerElements/paper-checkbox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PolymerElements/paper-checkbox/statuses/{sha}","languages_url":"https://api.github.com/repos/PolymerElements/paper-checkbox/languages","stargazers_url":"https://api.github.com/repos/PolymerElements/paper-checkbox/stargazers","contributors_url":"https://api.github.com/repos/PolymerElements/paper-checkbox/contributors","subscribers_url":"https://api.github.com/repos/PolymerElements/paper-checkbox/subscribers","subscription_url":"https://api.github.com/repos/PolymerElements/paper-checkbox/subscription","commits_url":"https://api.github.com/repos/PolymerElements/paper-checkbox/commits{/sha}","git_commits_url":"https://api.github.com/repos/PolymerElements/paper-checkbox/git/commits{/sha}","comments_url":"https://api.github.com/repos/PolymerElements/paper-checkbox/comments{/number}","issue_comment_url":"https://api.github.com/repos/PolymerElements/paper-checkbox/issues/comments{/number}","contents_url":"https://api.github.com/repos/PolymerElements/paper-checkbox/contents/{+path}","compare_url":"https://api.github.com/repos/PolymerElements/paper-checkbox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PolymerElements/paper-checkbox/merges","archive_url":"https://api.github.com/repos/PolymerElements/paper-checkbox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PolymerElements/paper-checkbox/downloads","issues_url":"https://api.github.com/repos/PolymerElements/paper-checkbox/issues{/number}","pulls_url":"https://api.github.com/repos/PolymerElements/paper-checkbox/pulls{/number}","milestones_url":"https://api.github.com/repos/PolymerElements/paper-checkbox/milestones{/number}","notifications_url":"https://api.github.com/repos/PolymerElements/paper-checkbox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PolymerElements/paper-checkbox/labels{/name}","releases_url":"https://api.github.com/repos/PolymerElements/paper-checkbox/releases{/id}","deployments_url":"https://api.github.com/repos/PolymerElements/paper-checkbox/deployments","created_at":"2015-04-14T00:42:12Z","updated_at":"2017-07-03T10:00:43Z","pushed_at":"2017-07-10T23:31:03Z","git_url":"git://github.com/PolymerElements/paper-checkbox.git","ssh_url":"git@github.com:PolymerElements/paper-checkbox.git","clone_url":"https://github.com/PolymerElements/paper-checkbox.git","svn_url":"https://github.com/PolymerElements/paper-checkbox","homepage":"https://www.webcomponents.org/element/PolymerElements/paper-checkbox","size":181,"stargazers_count":44,"watchers_count":44,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":47,"mirror_url":null,"open_issues_count":38,"forks":47,"open_issues":38,"watchers":44,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PolymerElements/paper-checkbox/pulls/179"},"html":{"href":"https://github.com/PolymerElements/paper-checkbox/pull/179"},"issue":{"href":"https://api.github.com/repos/PolymerElements/paper-checkbox/issues/179"},"comments":{"href":"https://api.github.com/repos/PolymerElements/paper-checkbox/issues/179/comments"},"review_comments":{"href":"https://api.github.com/repos/PolymerElements/paper-checkbox/pulls/179/comments"},"review_comment":{"href":"https://api.github.com/repos/PolymerElements/paper-checkbox/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PolymerElements/paper-checkbox/pulls/179/commits"},"statuses":{"href":"https://api.github.com/repos/PolymerElements/paper-checkbox/statuses/69b3c67e479d90af5cba713758ee5ee12c50014d"}}}}
{"actor":{"display_login":"notwaldorf"}}