{"action":"created","comment":{"url":"https://api.github.com/repos/silverstripe/silverstripe-cms/pulls/comments/130218657","pull_request_review_id":53074343,"id":130218657,"diff_hunk":"@@ -1604,6 +1604,21 @@ public function generateURLSegment($title)\n         // Hook for extensions\n         $this->extend('updateURLSegment', $t, $title);\n \n+        $excludes = Director::config()->get('rules');\n+        $excludes = array_keys($excludes);\n+        $disallowed = array_map(function ($key) {","path":"code/Model/SiteTree.php","position":null,"original_position":6,"commit_id":"041b3bf8c9ffe449d4d6f8d3b1275a0a8ef10d2b","original_commit_id":"5301485bf382dc7a5ec2d05286e3295c6e8b0b8c","user":{"login":"Firesphere","id":680570,"avatar_url":"https://avatars3.githubusercontent.com/u/680570?v=4","gravatar_id":"","url":"https://api.github.com/users/Firesphere","html_url":"https://github.com/Firesphere","followers_url":"https://api.github.com/users/Firesphere/followers","following_url":"https://api.github.com/users/Firesphere/following{/other_user}","gists_url":"https://api.github.com/users/Firesphere/gists{/gist_id}","starred_url":"https://api.github.com/users/Firesphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Firesphere/subscriptions","organizations_url":"https://api.github.com/users/Firesphere/orgs","repos_url":"https://api.github.com/users/Firesphere/repos","events_url":"https://api.github.com/users/Firesphere/events{/privacy}","received_events_url":"https://api.github.com/users/Firesphere/received_events","type":"User","site_admin":false},"body":"`strto()` is pretty neat! But it fails if there's no slash in the segment, so I'm sticking to the explode :D ","created_at":"2017-07-29T10:58:35Z","updated_at":"2017-07-29T10:58:35Z","html_url":"https://github.com/silverstripe/silverstripe-cms/pull/1886#discussion_r130218657","pull_request_url":"https://api.github.com/repos/silverstripe/silverstripe-cms/pulls/1886","_links":{"self":{"href":"https://api.github.com/repos/silverstripe/silverstripe-cms/pulls/comments/130218657"},"html":{"href":"https://github.com/silverstripe/silverstripe-cms/pull/1886#discussion_r130218657"},"pull_request":{"href":"https://api.github.com/repos/silverstripe/silverstripe-cms/pulls/1886"}}},"pull_request":{"url":"https://api.github.com/repos/silverstripe/silverstripe-cms/pulls/1886","id":129552754,"html_url":"https://github.com/silverstripe/silverstripe-cms/pull/1886","diff_url":"https://github.com/silverstripe/silverstripe-cms/pull/1886.diff","patch_url":"https://github.com/silverstripe/silverstripe-cms/pull/1886.patch","issue_url":"https://api.github.com/repos/silverstripe/silverstripe-cms/issues/1886","number":1886,"state":"open","locked":false,"title":"Disable the ability to use reserved URL's","user":{"login":"Firesphere","id":680570,"avatar_url":"https://avatars3.githubusercontent.com/u/680570?v=4","gravatar_id":"","url":"https://api.github.com/users/Firesphere","html_url":"https://github.com/Firesphere","followers_url":"https://api.github.com/users/Firesphere/followers","following_url":"https://api.github.com/users/Firesphere/following{/other_user}","gists_url":"https://api.github.com/users/Firesphere/gists{/gist_id}","starred_url":"https://api.github.com/users/Firesphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Firesphere/subscriptions","organizations_url":"https://api.github.com/users/Firesphere/orgs","repos_url":"https://api.github.com/users/Firesphere/repos","events_url":"https://api.github.com/users/Firesphere/events{/privacy}","received_events_url":"https://api.github.com/users/Firesphere/received_events","type":"User","site_admin":false},"body":"Fixes https://github.com/silverstripe/silverstripe-framework/issues/7139","created_at":"2017-07-09T05:43:21Z","updated_at":"2017-07-29T10:58:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1ab15cbe989850a7b8fa92942a72ab10e9713216","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/silverstripe/silverstripe-cms/pulls/1886/commits","review_comments_url":"https://api.github.com/repos/silverstripe/silverstripe-cms/pulls/1886/comments","review_comment_url":"https://api.github.com/repos/silverstripe/silverstripe-cms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/silverstripe/silverstripe-cms/issues/1886/comments","statuses_url":"https://api.github.com/repos/silverstripe/silverstripe-cms/statuses/041b3bf8c9ffe449d4d6f8d3b1275a0a8ef10d2b","head":{"label":"Firesphere:disallow-fixed-routes","ref":"disallow-fixed-routes","sha":"041b3bf8c9ffe449d4d6f8d3b1275a0a8ef10d2b","user":{"login":"Firesphere","id":680570,"avatar_url":"https://avatars3.githubusercontent.com/u/680570?v=4","gravatar_id":"","url":"https://api.github.com/users/Firesphere","html_url":"https://github.com/Firesphere","followers_url":"https://api.github.com/users/Firesphere/followers","following_url":"https://api.github.com/users/Firesphere/following{/other_user}","gists_url":"https://api.github.com/users/Firesphere/gists{/gist_id}","starred_url":"https://api.github.com/users/Firesphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Firesphere/subscriptions","organizations_url":"https://api.github.com/users/Firesphere/orgs","repos_url":"https://api.github.com/users/Firesphere/repos","events_url":"https://api.github.com/users/Firesphere/events{/privacy}","received_events_url":"https://api.github.com/users/Firesphere/received_events","type":"User","site_admin":false},"repo":{"id":66037764,"name":"silverstripe-cms","full_name":"Firesphere/silverstripe-cms","owner":{"login":"Firesphere","id":680570,"avatar_url":"https://avatars3.githubusercontent.com/u/680570?v=4","gravatar_id":"","url":"https://api.github.com/users/Firesphere","html_url":"https://github.com/Firesphere","followers_url":"https://api.github.com/users/Firesphere/followers","following_url":"https://api.github.com/users/Firesphere/following{/other_user}","gists_url":"https://api.github.com/users/Firesphere/gists{/gist_id}","starred_url":"https://api.github.com/users/Firesphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Firesphere/subscriptions","organizations_url":"https://api.github.com/users/Firesphere/orgs","repos_url":"https://api.github.com/users/Firesphere/repos","events_url":"https://api.github.com/users/Firesphere/events{/privacy}","received_events_url":"https://api.github.com/users/Firesphere/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Firesphere/silverstripe-cms","description":"SilverStripe CMS - this is a module for SilverStripe Framework rather than a standalone app. Use https://github.com/silverstripe/silverstripe-installer/ to set this up.","fork":true,"url":"https://api.github.com/repos/Firesphere/silverstripe-cms","forks_url":"https://api.github.com/repos/Firesphere/silverstripe-cms/forks","keys_url":"https://api.github.com/repos/Firesphere/silverstripe-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Firesphere/silverstripe-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Firesphere/silverstripe-cms/teams","hooks_url":"https://api.github.com/repos/Firesphere/silverstripe-cms/hooks","issue_events_url":"https://api.github.com/repos/Firesphere/silverstripe-cms/issues/events{/number}","events_url":"https://api.github.com/repos/Firesphere/silverstripe-cms/events","assignees_url":"https://api.github.com/repos/Firesphere/silverstripe-cms/assignees{/user}","branches_url":"https://api.github.com/repos/Firesphere/silverstripe-cms/branches{/branch}","tags_url":"https://api.github.com/repos/Firesphere/silverstripe-cms/tags","blobs_url":"https://api.github.com/repos/Firesphere/silverstripe-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Firesphere/silverstripe-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Firesphere/silverstripe-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/Firesphere/silverstripe-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Firesphere/silverstripe-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/Firesphere/silverstripe-cms/languages","stargazers_url":"https://api.github.com/repos/Firesphere/silverstripe-cms/stargazers","contributors_url":"https://api.github.com/repos/Firesphere/silverstripe-cms/contributors","subscribers_url":"https://api.github.com/repos/Firesphere/silverstripe-cms/subscribers","subscription_url":"https://api.github.com/repos/Firesphere/silverstripe-cms/subscription","commits_url":"https://api.github.com/repos/Firesphere/silverstripe-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/Firesphere/silverstripe-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/Firesphere/silverstripe-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/Firesphere/silverstripe-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/Firesphere/silverstripe-cms/contents/{+path}","compare_url":"https://api.github.com/repos/Firesphere/silverstripe-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Firesphere/silverstripe-cms/merges","archive_url":"https://api.github.com/repos/Firesphere/silverstripe-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Firesphere/silverstripe-cms/downloads","issues_url":"https://api.github.com/repos/Firesphere/silverstripe-cms/issues{/number}","pulls_url":"https://api.github.com/repos/Firesphere/silverstripe-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/Firesphere/silverstripe-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/Firesphere/silverstripe-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Firesphere/silverstripe-cms/labels{/name}","releases_url":"https://api.github.com/repos/Firesphere/silverstripe-cms/releases{/id}","deployments_url":"https://api.github.com/repos/Firesphere/silverstripe-cms/deployments","created_at":"2016-08-18T23:41:05Z","updated_at":"2016-08-18T23:41:08Z","pushed_at":"2017-07-29T04:45:48Z","git_url":"git://github.com/Firesphere/silverstripe-cms.git","ssh_url":"git@github.com:Firesphere/silverstripe-cms.git","clone_url":"https://github.com/Firesphere/silverstripe-cms.git","svn_url":"https://github.com/Firesphere/silverstripe-cms","homepage":"http://silverstripe.org/","size":15456,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"silverstripe:4","ref":"4","sha":"a92261cc9bf9eae467494490f2d7ee21dc6e4666","user":{"login":"silverstripe","id":379348,"avatar_url":"https://avatars0.githubusercontent.com/u/379348?v=4","gravatar_id":"","url":"https://api.github.com/users/silverstripe","html_url":"https://github.com/silverstripe","followers_url":"https://api.github.com/users/silverstripe/followers","following_url":"https://api.github.com/users/silverstripe/following{/other_user}","gists_url":"https://api.github.com/users/silverstripe/gists{/gist_id}","starred_url":"https://api.github.com/users/silverstripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silverstripe/subscriptions","organizations_url":"https://api.github.com/users/silverstripe/orgs","repos_url":"https://api.github.com/users/silverstripe/repos","events_url":"https://api.github.com/users/silverstripe/events{/privacy}","received_events_url":"https://api.github.com/users/silverstripe/received_events","type":"Organization","site_admin":false},"repo":{"id":1319183,"name":"silverstripe-cms","full_name":"silverstripe/silverstripe-cms","owner":{"login":"silverstripe","id":379348,"avatar_url":"https://avatars0.githubusercontent.com/u/379348?v=4","gravatar_id":"","url":"https://api.github.com/users/silverstripe","html_url":"https://github.com/silverstripe","followers_url":"https://api.github.com/users/silverstripe/followers","following_url":"https://api.github.com/users/silverstripe/following{/other_user}","gists_url":"https://api.github.com/users/silverstripe/gists{/gist_id}","starred_url":"https://api.github.com/users/silverstripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silverstripe/subscriptions","organizations_url":"https://api.github.com/users/silverstripe/orgs","repos_url":"https://api.github.com/users/silverstripe/repos","events_url":"https://api.github.com/users/silverstripe/events{/privacy}","received_events_url":"https://api.github.com/users/silverstripe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/silverstripe/silverstripe-cms","description":"SilverStripe CMS - this is a module for SilverStripe Framework rather than a standalone app. Use https://github.com/silverstripe/silverstripe-installer/ to set this up.","fork":false,"url":"https://api.github.com/repos/silverstripe/silverstripe-cms","forks_url":"https://api.github.com/repos/silverstripe/silverstripe-cms/forks","keys_url":"https://api.github.com/repos/silverstripe/silverstripe-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/silverstripe/silverstripe-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/silverstripe/silverstripe-cms/teams","hooks_url":"https://api.github.com/repos/silverstripe/silverstripe-cms/hooks","issue_events_url":"https://api.github.com/repos/silverstripe/silverstripe-cms/issues/events{/number}","events_url":"https://api.github.com/repos/silverstripe/silverstripe-cms/events","assignees_url":"https://api.github.com/repos/silverstripe/silverstripe-cms/assignees{/user}","branches_url":"https://api.github.com/repos/silverstripe/silverstripe-cms/branches{/branch}","tags_url":"https://api.github.com/repos/silverstripe/silverstripe-cms/tags","blobs_url":"https://api.github.com/repos/silverstripe/silverstripe-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/silverstripe/silverstripe-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/silverstripe/silverstripe-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/silverstripe/silverstripe-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/silverstripe/silverstripe-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/silverstripe/silverstripe-cms/languages","stargazers_url":"https://api.github.com/repos/silverstripe/silverstripe-cms/stargazers","contributors_url":"https://api.github.com/repos/silverstripe/silverstripe-cms/contributors","subscribers_url":"https://api.github.com/repos/silverstripe/silverstripe-cms/subscribers","subscription_url":"https://api.github.com/repos/silverstripe/silverstripe-cms/subscription","commits_url":"https://api.github.com/repos/silverstripe/silverstripe-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/silverstripe/silverstripe-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/silverstripe/silverstripe-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/silverstripe/silverstripe-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/silverstripe/silverstripe-cms/contents/{+path}","compare_url":"https://api.github.com/repos/silverstripe/silverstripe-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/silverstripe/silverstripe-cms/merges","archive_url":"https://api.github.com/repos/silverstripe/silverstripe-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/silverstripe/silverstripe-cms/downloads","issues_url":"https://api.github.com/repos/silverstripe/silverstripe-cms/issues{/number}","pulls_url":"https://api.github.com/repos/silverstripe/silverstripe-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/silverstripe/silverstripe-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/silverstripe/silverstripe-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/silverstripe/silverstripe-cms/labels{/name}","releases_url":"https://api.github.com/repos/silverstripe/silverstripe-cms/releases{/id}","deployments_url":"https://api.github.com/repos/silverstripe/silverstripe-cms/deployments","created_at":"2011-02-02T04:01:36Z","updated_at":"2017-06-30T00:07:46Z","pushed_at":"2017-07-29T04:45:50Z","git_url":"git://github.com/silverstripe/silverstripe-cms.git","ssh_url":"git@github.com:silverstripe/silverstripe-cms.git","clone_url":"https://github.com/silverstripe/silverstripe-cms.git","svn_url":"https://github.com/silverstripe/silverstripe-cms","homepage":"http://silverstripe.org/","size":15457,"stargazers_count":429,"watchers_count":429,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":299,"mirror_url":null,"open_issues_count":174,"forks":299,"open_issues":174,"watchers":429,"default_branch":"4"}},"_links":{"self":{"href":"https://api.github.com/repos/silverstripe/silverstripe-cms/pulls/1886"},"html":{"href":"https://github.com/silverstripe/silverstripe-cms/pull/1886"},"issue":{"href":"https://api.github.com/repos/silverstripe/silverstripe-cms/issues/1886"},"comments":{"href":"https://api.github.com/repos/silverstripe/silverstripe-cms/issues/1886/comments"},"review_comments":{"href":"https://api.github.com/repos/silverstripe/silverstripe-cms/pulls/1886/comments"},"review_comment":{"href":"https://api.github.com/repos/silverstripe/silverstripe-cms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/silverstripe/silverstripe-cms/pulls/1886/commits"},"statuses":{"href":"https://api.github.com/repos/silverstripe/silverstripe-cms/statuses/041b3bf8c9ffe449d4d6f8d3b1275a0a8ef10d2b"}}}}
{"actor":{"display_login":"Firesphere"}}