{"action":"created","comment":{"url":"https://api.github.com/repos/Mirantis/kubeadm-dind-cluster/pulls/comments/144925551","pull_request_review_id":69646332,"id":144925551,"diff_hunk":"@@ -607,7 +734,7 @@ function dind::join {\n }\n \n function dind::escape-e2e-name {\n-    sed 's/[]\\$*.^|()[]/\\\\&/g; s/\\s\\+/\\\\s+/g' <<< \"$1\" | tr -d '\\n'","path":"dind-cluster.sh","position":248,"original_position":248,"commit_id":"3ae59de70b303996eb1006bdf57a5fa1445d4cff","original_commit_id":"3ae59de70b303996eb1006bdf57a5fa1445d4cff","user":{"login":"pmichali","id":2787783,"avatar_url":"https://avatars1.githubusercontent.com/u/2787783?v=4","gravatar_id":"","url":"https://api.github.com/users/pmichali","html_url":"https://github.com/pmichali","followers_url":"https://api.github.com/users/pmichali/followers","following_url":"https://api.github.com/users/pmichali/following{/other_user}","gists_url":"https://api.github.com/users/pmichali/gists{/gist_id}","starred_url":"https://api.github.com/users/pmichali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmichali/subscriptions","organizations_url":"https://api.github.com/users/pmichali/orgs","repos_url":"https://api.github.com/users/pmichali/repos","events_url":"https://api.github.com/users/pmichali/events{/privacy}","received_events_url":"https://api.github.com/users/pmichali/received_events","type":"User","site_admin":false},"body":"We wanted to run a test like this, and with the escaping, it was not forming the right focus/skip in the underlying test run AFAICT:\r\n\r\n```\r\n../dind-cluster.sh e2e \"Networking|Services\" \"IPv4|Networking-Performance|Federation|preserve source pod\"\r\n```\r\n","created_at":"2017-10-16T18:14:20Z","updated_at":"2017-10-16T18:22:38Z","html_url":"https://github.com/Mirantis/kubeadm-dind-cluster/pull/42#discussion_r144925551","pull_request_url":"https://api.github.com/repos/Mirantis/kubeadm-dind-cluster/pulls/42","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Mirantis/kubeadm-dind-cluster/pulls/comments/144925551"},"html":{"href":"https://github.com/Mirantis/kubeadm-dind-cluster/pull/42#discussion_r144925551"},"pull_request":{"href":"https://api.github.com/repos/Mirantis/kubeadm-dind-cluster/pulls/42"}},"in_reply_to_id":144905274},"pull_request":{"url":"https://api.github.com/repos/Mirantis/kubeadm-dind-cluster/pulls/42","id":144526364,"html_url":"https://github.com/Mirantis/kubeadm-dind-cluster/pull/42","diff_url":"https://github.com/Mirantis/kubeadm-dind-cluster/pull/42.diff","patch_url":"https://github.com/Mirantis/kubeadm-dind-cluster/pull/42.patch","issue_url":"https://api.github.com/repos/Mirantis/kubeadm-dind-cluster/issues/42","number":42,"state":"open","locked":false,"title":"WIP: Provide IPv6 support","user":{"login":"pmichali","id":2787783,"avatar_url":"https://avatars1.githubusercontent.com/u/2787783?v=4","gravatar_id":"","url":"https://api.github.com/users/pmichali","html_url":"https://github.com/pmichali","followers_url":"https://api.github.com/users/pmichali/followers","following_url":"https://api.github.com/users/pmichali/following{/other_user}","gists_url":"https://api.github.com/users/pmichali/gists{/gist_id}","starred_url":"https://api.github.com/users/pmichali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmichali/subscriptions","organizations_url":"https://api.github.com/users/pmichali/orgs","repos_url":"https://api.github.com/users/pmichali/repos","events_url":"https://api.github.com/users/pmichali/events{/privacy}","received_events_url":"https://api.github.com/users/pmichali/received_events","type":"User","site_admin":false},"body":"Adding a WIP change (on top of the fix-1.8+ branch) that will allow DinD to be used on an IPv6 only Kubernetes cluster.\r\n\r\nThis uses IPv6 addresses for all pods, and makes use of DNS64 and NAT64 containers, to convert external IPs to IPv4 embedded IPv6 addresses.\r\n\r\nAn IP_MODE environment variable is added to select between IPv4 (default) and IPv6. Additional environment variables can be set to customize DinD subnet, service subnet CIDR, and prefix to use for DNS64.\r\n\r\nTo use, must use the customer Kubernetes repo in the README.md, as it has IPv6 patches that are in-flight (or fixing bugs).\r\n\r\nNotes:\r\n- Uses /80 for pod subnet size.\r\n- Requires building local copy, due to changes to DinD code.\r\n- All pod subnets are \"inside\" of the DinD /64 subnet (same as what IPv4 does).\r\n- Includes fix to restore controller manifest, when failure to shutdown controller/proxy pods during snapshot.\r\n- Relies on both a custom Kubernetes repo (until commits are upstreamed), and kube-dns image (referenced in manifest of custom Kubernetes repo).\r\n- Could be customized to use NAT66 container as an option to allow access to external IPv6 IPs.\r\n- Future could add dual-stack support.\r\n","created_at":"2017-10-03T20:54:36Z","updated_at":"2017-10-16T18:22:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1989713808e5f701ddeaaf6414cf145de7a189d9","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Mirantis/kubeadm-dind-cluster/pulls/42/commits","review_comments_url":"https://api.github.com/repos/Mirantis/kubeadm-dind-cluster/pulls/42/comments","review_comment_url":"https://api.github.com/repos/Mirantis/kubeadm-dind-cluster/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Mirantis/kubeadm-dind-cluster/issues/42/comments","statuses_url":"https://api.github.com/repos/Mirantis/kubeadm-dind-cluster/statuses/3ae59de70b303996eb1006bdf57a5fa1445d4cff","head":{"label":"pmichali:ipv4-ipv6","ref":"ipv4-ipv6","sha":"3ae59de70b303996eb1006bdf57a5fa1445d4cff","user":{"login":"pmichali","id":2787783,"avatar_url":"https://avatars1.githubusercontent.com/u/2787783?v=4","gravatar_id":"","url":"https://api.github.com/users/pmichali","html_url":"https://github.com/pmichali","followers_url":"https://api.github.com/users/pmichali/followers","following_url":"https://api.github.com/users/pmichali/following{/other_user}","gists_url":"https://api.github.com/users/pmichali/gists{/gist_id}","starred_url":"https://api.github.com/users/pmichali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmichali/subscriptions","organizations_url":"https://api.github.com/users/pmichali/orgs","repos_url":"https://api.github.com/users/pmichali/repos","events_url":"https://api.github.com/users/pmichali/events{/privacy}","received_events_url":"https://api.github.com/users/pmichali/received_events","type":"User","site_admin":false},"repo":{"id":97855864,"name":"kubeadm-dind-cluster","full_name":"pmichali/kubeadm-dind-cluster","owner":{"login":"pmichali","id":2787783,"avatar_url":"https://avatars1.githubusercontent.com/u/2787783?v=4","gravatar_id":"","url":"https://api.github.com/users/pmichali","html_url":"https://github.com/pmichali","followers_url":"https://api.github.com/users/pmichali/followers","following_url":"https://api.github.com/users/pmichali/following{/other_user}","gists_url":"https://api.github.com/users/pmichali/gists{/gist_id}","starred_url":"https://api.github.com/users/pmichali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmichali/subscriptions","organizations_url":"https://api.github.com/users/pmichali/orgs","repos_url":"https://api.github.com/users/pmichali/repos","events_url":"https://api.github.com/users/pmichali/events{/privacy}","received_events_url":"https://api.github.com/users/pmichali/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pmichali/kubeadm-dind-cluster","description":"A Kubernetes multi-node test cluster based on kubeadm","fork":true,"url":"https://api.github.com/repos/pmichali/kubeadm-dind-cluster","forks_url":"https://api.github.com/repos/pmichali/kubeadm-dind-cluster/forks","keys_url":"https://api.github.com/repos/pmichali/kubeadm-dind-cluster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pmichali/kubeadm-dind-cluster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pmichali/kubeadm-dind-cluster/teams","hooks_url":"https://api.github.com/repos/pmichali/kubeadm-dind-cluster/hooks","issue_events_url":"https://api.github.com/repos/pmichali/kubeadm-dind-cluster/issues/events{/number}","events_url":"https://api.github.com/repos/pmichali/kubeadm-dind-cluster/events","assignees_url":"https://api.github.com/repos/pmichali/kubeadm-dind-cluster/assignees{/user}","branches_url":"https://api.github.com/repos/pmichali/kubeadm-dind-cluster/branches{/branch}","tags_url":"https://api.github.com/repos/pmichali/kubeadm-dind-cluster/tags","blobs_url":"https://api.github.com/repos/pmichali/kubeadm-dind-cluster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pmichali/kubeadm-dind-cluster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pmichali/kubeadm-dind-cluster/git/refs{/sha}","trees_url":"https://api.github.com/repos/pmichali/kubeadm-dind-cluster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pmichali/kubeadm-dind-cluster/statuses/{sha}","languages_url":"https://api.github.com/repos/pmichali/kubeadm-dind-cluster/languages","stargazers_url":"https://api.github.com/repos/pmichali/kubeadm-dind-cluster/stargazers","contributors_url":"https://api.github.com/repos/pmichali/kubeadm-dind-cluster/contributors","subscribers_url":"https://api.github.com/repos/pmichali/kubeadm-dind-cluster/subscribers","subscription_url":"https://api.github.com/repos/pmichali/kubeadm-dind-cluster/subscription","commits_url":"https://api.github.com/repos/pmichali/kubeadm-dind-cluster/commits{/sha}","git_commits_url":"https://api.github.com/repos/pmichali/kubeadm-dind-cluster/git/commits{/sha}","comments_url":"https://api.github.com/repos/pmichali/kubeadm-dind-cluster/comments{/number}","issue_comment_url":"https://api.github.com/repos/pmichali/kubeadm-dind-cluster/issues/comments{/number}","contents_url":"https://api.github.com/repos/pmichali/kubeadm-dind-cluster/contents/{+path}","compare_url":"https://api.github.com/repos/pmichali/kubeadm-dind-cluster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pmichali/kubeadm-dind-cluster/merges","archive_url":"https://api.github.com/repos/pmichali/kubeadm-dind-cluster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pmichali/kubeadm-dind-cluster/downloads","issues_url":"https://api.github.com/repos/pmichali/kubeadm-dind-cluster/issues{/number}","pulls_url":"https://api.github.com/repos/pmichali/kubeadm-dind-cluster/pulls{/number}","milestones_url":"https://api.github.com/repos/pmichali/kubeadm-dind-cluster/milestones{/number}","notifications_url":"https://api.github.com/repos/pmichali/kubeadm-dind-cluster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pmichali/kubeadm-dind-cluster/labels{/name}","releases_url":"https://api.github.com/repos/pmichali/kubeadm-dind-cluster/releases{/id}","deployments_url":"https://api.github.com/repos/pmichali/kubeadm-dind-cluster/deployments","created_at":"2017-07-20T16:19:40Z","updated_at":"2017-07-20T16:19:41Z","pushed_at":"2017-10-16T15:18:02Z","git_url":"git://github.com/pmichali/kubeadm-dind-cluster.git","ssh_url":"git@github.com:pmichali/kubeadm-dind-cluster.git","clone_url":"https://github.com/pmichali/kubeadm-dind-cluster.git","svn_url":"https://github.com/pmichali/kubeadm-dind-cluster","homepage":"","size":324,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Mirantis:fix-1.8+","ref":"fix-1.8+","sha":"2de3b18bac97d502199f70f9c11b7a8908df06b5","user":{"login":"Mirantis","id":609319,"avatar_url":"https://avatars2.githubusercontent.com/u/609319?v=4","gravatar_id":"","url":"https://api.github.com/users/Mirantis","html_url":"https://github.com/Mirantis","followers_url":"https://api.github.com/users/Mirantis/followers","following_url":"https://api.github.com/users/Mirantis/following{/other_user}","gists_url":"https://api.github.com/users/Mirantis/gists{/gist_id}","starred_url":"https://api.github.com/users/Mirantis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mirantis/subscriptions","organizations_url":"https://api.github.com/users/Mirantis/orgs","repos_url":"https://api.github.com/users/Mirantis/repos","events_url":"https://api.github.com/users/Mirantis/events{/privacy}","received_events_url":"https://api.github.com/users/Mirantis/received_events","type":"Organization","site_admin":false},"repo":{"id":72643691,"name":"kubeadm-dind-cluster","full_name":"Mirantis/kubeadm-dind-cluster","owner":{"login":"Mirantis","id":609319,"avatar_url":"https://avatars2.githubusercontent.com/u/609319?v=4","gravatar_id":"","url":"https://api.github.com/users/Mirantis","html_url":"https://github.com/Mirantis","followers_url":"https://api.github.com/users/Mirantis/followers","following_url":"https://api.github.com/users/Mirantis/following{/other_user}","gists_url":"https://api.github.com/users/Mirantis/gists{/gist_id}","starred_url":"https://api.github.com/users/Mirantis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mirantis/subscriptions","organizations_url":"https://api.github.com/users/Mirantis/orgs","repos_url":"https://api.github.com/users/Mirantis/repos","events_url":"https://api.github.com/users/Mirantis/events{/privacy}","received_events_url":"https://api.github.com/users/Mirantis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Mirantis/kubeadm-dind-cluster","description":"A Kubernetes multi-node test cluster based on kubeadm","fork":false,"url":"https://api.github.com/repos/Mirantis/kubeadm-dind-cluster","forks_url":"https://api.github.com/repos/Mirantis/kubeadm-dind-cluster/forks","keys_url":"https://api.github.com/repos/Mirantis/kubeadm-dind-cluster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Mirantis/kubeadm-dind-cluster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Mirantis/kubeadm-dind-cluster/teams","hooks_url":"https://api.github.com/repos/Mirantis/kubeadm-dind-cluster/hooks","issue_events_url":"https://api.github.com/repos/Mirantis/kubeadm-dind-cluster/issues/events{/number}","events_url":"https://api.github.com/repos/Mirantis/kubeadm-dind-cluster/events","assignees_url":"https://api.github.com/repos/Mirantis/kubeadm-dind-cluster/assignees{/user}","branches_url":"https://api.github.com/repos/Mirantis/kubeadm-dind-cluster/branches{/branch}","tags_url":"https://api.github.com/repos/Mirantis/kubeadm-dind-cluster/tags","blobs_url":"https://api.github.com/repos/Mirantis/kubeadm-dind-cluster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Mirantis/kubeadm-dind-cluster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Mirantis/kubeadm-dind-cluster/git/refs{/sha}","trees_url":"https://api.github.com/repos/Mirantis/kubeadm-dind-cluster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Mirantis/kubeadm-dind-cluster/statuses/{sha}","languages_url":"https://api.github.com/repos/Mirantis/kubeadm-dind-cluster/languages","stargazers_url":"https://api.github.com/repos/Mirantis/kubeadm-dind-cluster/stargazers","contributors_url":"https://api.github.com/repos/Mirantis/kubeadm-dind-cluster/contributors","subscribers_url":"https://api.github.com/repos/Mirantis/kubeadm-dind-cluster/subscribers","subscription_url":"https://api.github.com/repos/Mirantis/kubeadm-dind-cluster/subscription","commits_url":"https://api.github.com/repos/Mirantis/kubeadm-dind-cluster/commits{/sha}","git_commits_url":"https://api.github.com/repos/Mirantis/kubeadm-dind-cluster/git/commits{/sha}","comments_url":"https://api.github.com/repos/Mirantis/kubeadm-dind-cluster/comments{/number}","issue_comment_url":"https://api.github.com/repos/Mirantis/kubeadm-dind-cluster/issues/comments{/number}","contents_url":"https://api.github.com/repos/Mirantis/kubeadm-dind-cluster/contents/{+path}","compare_url":"https://api.github.com/repos/Mirantis/kubeadm-dind-cluster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Mirantis/kubeadm-dind-cluster/merges","archive_url":"https://api.github.com/repos/Mirantis/kubeadm-dind-cluster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Mirantis/kubeadm-dind-cluster/downloads","issues_url":"https://api.github.com/repos/Mirantis/kubeadm-dind-cluster/issues{/number}","pulls_url":"https://api.github.com/repos/Mirantis/kubeadm-dind-cluster/pulls{/number}","milestones_url":"https://api.github.com/repos/Mirantis/kubeadm-dind-cluster/milestones{/number}","notifications_url":"https://api.github.com/repos/Mirantis/kubeadm-dind-cluster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Mirantis/kubeadm-dind-cluster/labels{/name}","releases_url":"https://api.github.com/repos/Mirantis/kubeadm-dind-cluster/releases{/id}","deployments_url":"https://api.github.com/repos/Mirantis/kubeadm-dind-cluster/deployments","created_at":"2016-11-02T13:42:23Z","updated_at":"2017-10-16T12:04:16Z","pushed_at":"2017-10-16T15:18:03Z","git_url":"git://github.com/Mirantis/kubeadm-dind-cluster.git","ssh_url":"git@github.com:Mirantis/kubeadm-dind-cluster.git","clone_url":"https://github.com/Mirantis/kubeadm-dind-cluster.git","svn_url":"https://github.com/Mirantis/kubeadm-dind-cluster","homepage":"","size":273,"stargazers_count":142,"watchers_count":142,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"open_issues_count":16,"forks":34,"open_issues":16,"watchers":142,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Mirantis/kubeadm-dind-cluster/pulls/42"},"html":{"href":"https://github.com/Mirantis/kubeadm-dind-cluster/pull/42"},"issue":{"href":"https://api.github.com/repos/Mirantis/kubeadm-dind-cluster/issues/42"},"comments":{"href":"https://api.github.com/repos/Mirantis/kubeadm-dind-cluster/issues/42/comments"},"review_comments":{"href":"https://api.github.com/repos/Mirantis/kubeadm-dind-cluster/pulls/42/comments"},"review_comment":{"href":"https://api.github.com/repos/Mirantis/kubeadm-dind-cluster/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Mirantis/kubeadm-dind-cluster/pulls/42/commits"},"statuses":{"href":"https://api.github.com/repos/Mirantis/kubeadm-dind-cluster/statuses/3ae59de70b303996eb1006bdf57a5fa1445d4cff"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"pmichali"}}