{"action":"created","comment":{"url":"https://api.github.com/repos/z3t0/Arduino-IRremote/pulls/comments/111670617","pull_request_review_id":32931978,"id":111670617,"diff_hunk":"@@ -574,4 +639,13 @@\n #\terror \"Internal code configuration error, no known IR_USE_TIMER# defined\\n\"\n #endif\n \n+// Provide default definitions, portable but possibly slower than necessary.","path":"boarddefs.h","position":247,"original_position":247,"commit_id":"94e8423ba5ea77833c53c1601b07231c9e0f7a0b","original_commit_id":"94e8423ba5ea77833c53c1601b07231c9e0f7a0b","user":{"login":"z3t0","id":9000061,"avatar_url":"https://avatars0.githubusercontent.com/u/9000061?v=3","gravatar_id":"","url":"https://api.github.com/users/z3t0","html_url":"https://github.com/z3t0","followers_url":"https://api.github.com/users/z3t0/followers","following_url":"https://api.github.com/users/z3t0/following{/other_user}","gists_url":"https://api.github.com/users/z3t0/gists{/gist_id}","starred_url":"https://api.github.com/users/z3t0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/z3t0/subscriptions","organizations_url":"https://api.github.com/users/z3t0/orgs","repos_url":"https://api.github.com/users/z3t0/repos","events_url":"https://api.github.com/users/z3t0/events{/privacy}","received_events_url":"https://api.github.com/users/z3t0/received_events","type":"User","site_admin":false},"body":"I think this is a great idea! Should we add something like \r\n\r\n```c\r\n#warn Defaulting to software implemented send may be imperfect. See SOME_LINK\r\n```\r\n\r\nOr some other disclaimer so that while potentially supporting _unsupported_ platforms we also prevent issues from being created for _bad_ signals being produced?","created_at":"2017-04-15T18:22:45Z","updated_at":"2017-04-15T18:22:45Z","html_url":"https://github.com/z3t0/Arduino-IRremote/pull/437#discussion_r111670617","pull_request_url":"https://api.github.com/repos/z3t0/Arduino-IRremote/pulls/437","_links":{"self":{"href":"https://api.github.com/repos/z3t0/Arduino-IRremote/pulls/comments/111670617"},"html":{"href":"https://github.com/z3t0/Arduino-IRremote/pull/437#discussion_r111670617"},"pull_request":{"href":"https://api.github.com/repos/z3t0/Arduino-IRremote/pulls/437"}}},"pull_request":{"url":"https://api.github.com/repos/z3t0/Arduino-IRremote/pulls/437","id":115613518,"html_url":"https://github.com/z3t0/Arduino-IRremote/pull/437","diff_url":"https://github.com/z3t0/Arduino-IRremote/pull/437.diff","patch_url":"https://github.com/z3t0/Arduino-IRremote/pull/437.patch","issue_url":"https://api.github.com/repos/z3t0/Arduino-IRremote/issues/437","number":437,"state":"open","locked":false,"title":"Cleanup of hardware dependencies. Merge in SAM support. ","user":{"login":"bengtmartensson","id":11508922,"avatar_url":"https://avatars1.githubusercontent.com/u/11508922?v=3","gravatar_id":"","url":"https://api.github.com/users/bengtmartensson","html_url":"https://github.com/bengtmartensson","followers_url":"https://api.github.com/users/bengtmartensson/followers","following_url":"https://api.github.com/users/bengtmartensson/following{/other_user}","gists_url":"https://api.github.com/users/bengtmartensson/gists{/gist_id}","starred_url":"https://api.github.com/users/bengtmartensson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bengtmartensson/subscriptions","organizations_url":"https://api.github.com/users/bengtmartensson/orgs","repos_url":"https://api.github.com/users/bengtmartensson/repos","events_url":"https://api.github.com/users/bengtmartensson/events{/privacy}","received_events_url":"https://api.github.com/users/bengtmartensson/received_events","type":"User","site_admin":false},"body":"This PR attempts to clean up the low-level hardware dependencies. This problem was made glaring by  #425 and its implementation by @marcmerlin. Later, the changes for SAM boards (see #390), first by @MrBryonMiller, later fixed by @ladyada, https://github.com/adafruit/Arduino-IRremote. These changes have been \"cleaned\" in the same sense.\r\n\r\nAll explicit hardware dependencies are now either in `boarddefs.h`, or in a board-specific file. Conditional compilation in the other files are now exclusively governed by \"high-level\" properties. Soft carrier (which sometimes is called \"bit-banging\") have been implemented hardware-independent. \r\n\r\n","created_at":"2017-04-12T19:06:37Z","updated_at":"2017-04-15T18:22:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6084ba90f66ba8cec347e3da720d06d179fe82eb","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/z3t0/Arduino-IRremote/pulls/437/commits","review_comments_url":"https://api.github.com/repos/z3t0/Arduino-IRremote/pulls/437/comments","review_comment_url":"https://api.github.com/repos/z3t0/Arduino-IRremote/pulls/comments{/number}","comments_url":"https://api.github.com/repos/z3t0/Arduino-IRremote/issues/437/comments","statuses_url":"https://api.github.com/repos/z3t0/Arduino-IRremote/statuses/94e8423ba5ea77833c53c1601b07231c9e0f7a0b","head":{"label":"bengtmartensson:master","ref":"master","sha":"94e8423ba5ea77833c53c1601b07231c9e0f7a0b","user":{"login":"bengtmartensson","id":11508922,"avatar_url":"https://avatars1.githubusercontent.com/u/11508922?v=3","gravatar_id":"","url":"https://api.github.com/users/bengtmartensson","html_url":"https://github.com/bengtmartensson","followers_url":"https://api.github.com/users/bengtmartensson/followers","following_url":"https://api.github.com/users/bengtmartensson/following{/other_user}","gists_url":"https://api.github.com/users/bengtmartensson/gists{/gist_id}","starred_url":"https://api.github.com/users/bengtmartensson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bengtmartensson/subscriptions","organizations_url":"https://api.github.com/users/bengtmartensson/orgs","repos_url":"https://api.github.com/users/bengtmartensson/repos","events_url":"https://api.github.com/users/bengtmartensson/events{/privacy}","received_events_url":"https://api.github.com/users/bengtmartensson/received_events","type":"User","site_admin":false},"repo":{"id":66367734,"name":"Arduino-IRremote","full_name":"bengtmartensson/Arduino-IRremote","owner":{"login":"bengtmartensson","id":11508922,"avatar_url":"https://avatars1.githubusercontent.com/u/11508922?v=3","gravatar_id":"","url":"https://api.github.com/users/bengtmartensson","html_url":"https://github.com/bengtmartensson","followers_url":"https://api.github.com/users/bengtmartensson/followers","following_url":"https://api.github.com/users/bengtmartensson/following{/other_user}","gists_url":"https://api.github.com/users/bengtmartensson/gists{/gist_id}","starred_url":"https://api.github.com/users/bengtmartensson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bengtmartensson/subscriptions","organizations_url":"https://api.github.com/users/bengtmartensson/orgs","repos_url":"https://api.github.com/users/bengtmartensson/repos","events_url":"https://api.github.com/users/bengtmartensson/events{/privacy}","received_events_url":"https://api.github.com/users/bengtmartensson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bengtmartensson/Arduino-IRremote","description":"Infrared remote library for Arduino: send and receive infrared signals with multiple protocols","fork":true,"url":"https://api.github.com/repos/bengtmartensson/Arduino-IRremote","forks_url":"https://api.github.com/repos/bengtmartensson/Arduino-IRremote/forks","keys_url":"https://api.github.com/repos/bengtmartensson/Arduino-IRremote/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bengtmartensson/Arduino-IRremote/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bengtmartensson/Arduino-IRremote/teams","hooks_url":"https://api.github.com/repos/bengtmartensson/Arduino-IRremote/hooks","issue_events_url":"https://api.github.com/repos/bengtmartensson/Arduino-IRremote/issues/events{/number}","events_url":"https://api.github.com/repos/bengtmartensson/Arduino-IRremote/events","assignees_url":"https://api.github.com/repos/bengtmartensson/Arduino-IRremote/assignees{/user}","branches_url":"https://api.github.com/repos/bengtmartensson/Arduino-IRremote/branches{/branch}","tags_url":"https://api.github.com/repos/bengtmartensson/Arduino-IRremote/tags","blobs_url":"https://api.github.com/repos/bengtmartensson/Arduino-IRremote/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bengtmartensson/Arduino-IRremote/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bengtmartensson/Arduino-IRremote/git/refs{/sha}","trees_url":"https://api.github.com/repos/bengtmartensson/Arduino-IRremote/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bengtmartensson/Arduino-IRremote/statuses/{sha}","languages_url":"https://api.github.com/repos/bengtmartensson/Arduino-IRremote/languages","stargazers_url":"https://api.github.com/repos/bengtmartensson/Arduino-IRremote/stargazers","contributors_url":"https://api.github.com/repos/bengtmartensson/Arduino-IRremote/contributors","subscribers_url":"https://api.github.com/repos/bengtmartensson/Arduino-IRremote/subscribers","subscription_url":"https://api.github.com/repos/bengtmartensson/Arduino-IRremote/subscription","commits_url":"https://api.github.com/repos/bengtmartensson/Arduino-IRremote/commits{/sha}","git_commits_url":"https://api.github.com/repos/bengtmartensson/Arduino-IRremote/git/commits{/sha}","comments_url":"https://api.github.com/repos/bengtmartensson/Arduino-IRremote/comments{/number}","issue_comment_url":"https://api.github.com/repos/bengtmartensson/Arduino-IRremote/issues/comments{/number}","contents_url":"https://api.github.com/repos/bengtmartensson/Arduino-IRremote/contents/{+path}","compare_url":"https://api.github.com/repos/bengtmartensson/Arduino-IRremote/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bengtmartensson/Arduino-IRremote/merges","archive_url":"https://api.github.com/repos/bengtmartensson/Arduino-IRremote/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bengtmartensson/Arduino-IRremote/downloads","issues_url":"https://api.github.com/repos/bengtmartensson/Arduino-IRremote/issues{/number}","pulls_url":"https://api.github.com/repos/bengtmartensson/Arduino-IRremote/pulls{/number}","milestones_url":"https://api.github.com/repos/bengtmartensson/Arduino-IRremote/milestones{/number}","notifications_url":"https://api.github.com/repos/bengtmartensson/Arduino-IRremote/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bengtmartensson/Arduino-IRremote/labels{/name}","releases_url":"https://api.github.com/repos/bengtmartensson/Arduino-IRremote/releases{/id}","deployments_url":"https://api.github.com/repos/bengtmartensson/Arduino-IRremote/deployments","created_at":"2016-08-23T13:07:03Z","updated_at":"2016-08-23T13:07:04Z","pushed_at":"2017-04-15T10:55:49Z","git_url":"git://github.com/bengtmartensson/Arduino-IRremote.git","ssh_url":"git@github.com:bengtmartensson/Arduino-IRremote.git","clone_url":"https://github.com/bengtmartensson/Arduino-IRremote.git","svn_url":"https://github.com/bengtmartensson/Arduino-IRremote","homepage":"http://z3t0.github.io/Arduino-IRremote/","size":881,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"z3t0:master","ref":"master","sha":"f0aa48a4d134999f94b636dc0fa9be45cc093fbe","user":{"login":"z3t0","id":9000061,"avatar_url":"https://avatars0.githubusercontent.com/u/9000061?v=3","gravatar_id":"","url":"https://api.github.com/users/z3t0","html_url":"https://github.com/z3t0","followers_url":"https://api.github.com/users/z3t0/followers","following_url":"https://api.github.com/users/z3t0/following{/other_user}","gists_url":"https://api.github.com/users/z3t0/gists{/gist_id}","starred_url":"https://api.github.com/users/z3t0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/z3t0/subscriptions","organizations_url":"https://api.github.com/users/z3t0/orgs","repos_url":"https://api.github.com/users/z3t0/repos","events_url":"https://api.github.com/users/z3t0/events{/privacy}","received_events_url":"https://api.github.com/users/z3t0/received_events","type":"User","site_admin":false},"repo":{"id":484788,"name":"Arduino-IRremote","full_name":"z3t0/Arduino-IRremote","owner":{"login":"z3t0","id":9000061,"avatar_url":"https://avatars0.githubusercontent.com/u/9000061?v=3","gravatar_id":"","url":"https://api.github.com/users/z3t0","html_url":"https://github.com/z3t0","followers_url":"https://api.github.com/users/z3t0/followers","following_url":"https://api.github.com/users/z3t0/following{/other_user}","gists_url":"https://api.github.com/users/z3t0/gists{/gist_id}","starred_url":"https://api.github.com/users/z3t0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/z3t0/subscriptions","organizations_url":"https://api.github.com/users/z3t0/orgs","repos_url":"https://api.github.com/users/z3t0/repos","events_url":"https://api.github.com/users/z3t0/events{/privacy}","received_events_url":"https://api.github.com/users/z3t0/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/z3t0/Arduino-IRremote","description":"Infrared remote library for Arduino: send and receive infrared signals with multiple protocols","fork":false,"url":"https://api.github.com/repos/z3t0/Arduino-IRremote","forks_url":"https://api.github.com/repos/z3t0/Arduino-IRremote/forks","keys_url":"https://api.github.com/repos/z3t0/Arduino-IRremote/keys{/key_id}","collaborators_url":"https://api.github.com/repos/z3t0/Arduino-IRremote/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/z3t0/Arduino-IRremote/teams","hooks_url":"https://api.github.com/repos/z3t0/Arduino-IRremote/hooks","issue_events_url":"https://api.github.com/repos/z3t0/Arduino-IRremote/issues/events{/number}","events_url":"https://api.github.com/repos/z3t0/Arduino-IRremote/events","assignees_url":"https://api.github.com/repos/z3t0/Arduino-IRremote/assignees{/user}","branches_url":"https://api.github.com/repos/z3t0/Arduino-IRremote/branches{/branch}","tags_url":"https://api.github.com/repos/z3t0/Arduino-IRremote/tags","blobs_url":"https://api.github.com/repos/z3t0/Arduino-IRremote/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/z3t0/Arduino-IRremote/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/z3t0/Arduino-IRremote/git/refs{/sha}","trees_url":"https://api.github.com/repos/z3t0/Arduino-IRremote/git/trees{/sha}","statuses_url":"https://api.github.com/repos/z3t0/Arduino-IRremote/statuses/{sha}","languages_url":"https://api.github.com/repos/z3t0/Arduino-IRremote/languages","stargazers_url":"https://api.github.com/repos/z3t0/Arduino-IRremote/stargazers","contributors_url":"https://api.github.com/repos/z3t0/Arduino-IRremote/contributors","subscribers_url":"https://api.github.com/repos/z3t0/Arduino-IRremote/subscribers","subscription_url":"https://api.github.com/repos/z3t0/Arduino-IRremote/subscription","commits_url":"https://api.github.com/repos/z3t0/Arduino-IRremote/commits{/sha}","git_commits_url":"https://api.github.com/repos/z3t0/Arduino-IRremote/git/commits{/sha}","comments_url":"https://api.github.com/repos/z3t0/Arduino-IRremote/comments{/number}","issue_comment_url":"https://api.github.com/repos/z3t0/Arduino-IRremote/issues/comments{/number}","contents_url":"https://api.github.com/repos/z3t0/Arduino-IRremote/contents/{+path}","compare_url":"https://api.github.com/repos/z3t0/Arduino-IRremote/compare/{base}...{head}","merges_url":"https://api.github.com/repos/z3t0/Arduino-IRremote/merges","archive_url":"https://api.github.com/repos/z3t0/Arduino-IRremote/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/z3t0/Arduino-IRremote/downloads","issues_url":"https://api.github.com/repos/z3t0/Arduino-IRremote/issues{/number}","pulls_url":"https://api.github.com/repos/z3t0/Arduino-IRremote/pulls{/number}","milestones_url":"https://api.github.com/repos/z3t0/Arduino-IRremote/milestones{/number}","notifications_url":"https://api.github.com/repos/z3t0/Arduino-IRremote/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/z3t0/Arduino-IRremote/labels{/name}","releases_url":"https://api.github.com/repos/z3t0/Arduino-IRremote/releases{/id}","deployments_url":"https://api.github.com/repos/z3t0/Arduino-IRremote/deployments","created_at":"2010-01-23T04:37:22Z","updated_at":"2017-04-15T00:44:13Z","pushed_at":"2017-04-15T10:55:51Z","git_url":"git://github.com/z3t0/Arduino-IRremote.git","ssh_url":"git@github.com:z3t0/Arduino-IRremote.git","clone_url":"https://github.com/z3t0/Arduino-IRremote.git","svn_url":"https://github.com/z3t0/Arduino-IRremote","homepage":"http://z3t0.github.io/Arduino-IRremote/","size":863,"stargazers_count":1724,"watchers_count":1724,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":911,"mirror_url":null,"open_issues_count":147,"forks":911,"open_issues":147,"watchers":1724,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/z3t0/Arduino-IRremote/pulls/437"},"html":{"href":"https://github.com/z3t0/Arduino-IRremote/pull/437"},"issue":{"href":"https://api.github.com/repos/z3t0/Arduino-IRremote/issues/437"},"comments":{"href":"https://api.github.com/repos/z3t0/Arduino-IRremote/issues/437/comments"},"review_comments":{"href":"https://api.github.com/repos/z3t0/Arduino-IRremote/pulls/437/comments"},"review_comment":{"href":"https://api.github.com/repos/z3t0/Arduino-IRremote/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/z3t0/Arduino-IRremote/pulls/437/commits"},"statuses":{"href":"https://api.github.com/repos/z3t0/Arduino-IRremote/statuses/94e8423ba5ea77833c53c1601b07231c9e0f7a0b"}}}}
{"actor":{"display_login":"z3t0"}}