{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/origin/issues/17012","repository_url":"https://api.github.com/repos/openshift/origin","labels_url":"https://api.github.com/repos/openshift/origin/issues/17012/labels{/name}","comments_url":"https://api.github.com/repos/openshift/origin/issues/17012/comments","events_url":"https://api.github.com/repos/openshift/origin/issues/17012/events","html_url":"https://github.com/openshift/origin/pull/17012","id":267852763,"number":17012,"title":"Router: Changed default resource resync interval from 10mins to 30mins","user":{"login":"pravisankar","id":1258630,"avatar_url":"https://avatars0.githubusercontent.com/u/1258630?v=4","gravatar_id":"","url":"https://api.github.com/users/pravisankar","html_url":"https://github.com/pravisankar","followers_url":"https://api.github.com/users/pravisankar/followers","following_url":"https://api.github.com/users/pravisankar/following{/other_user}","gists_url":"https://api.github.com/users/pravisankar/gists{/gist_id}","starred_url":"https://api.github.com/users/pravisankar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pravisankar/subscriptions","organizations_url":"https://api.github.com/users/pravisankar/orgs","repos_url":"https://api.github.com/users/pravisankar/repos","events_url":"https://api.github.com/users/pravisankar/events{/privacy}","received_events_url":"https://api.github.com/users/pravisankar/received_events","type":"User","site_admin":false},"labels":[{"id":223051294,"url":"https://api.github.com/repos/openshift/origin/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":210156239,"url":"https://api.github.com/repos/openshift/origin/labels/component/routing","name":"component/routing","color":"0052cc","default":false},{"id":223479084,"url":"https://api.github.com/repos/openshift/origin/labels/lgtm","name":"lgtm","color":"15dd18","default":false},{"id":657292400,"url":"https://api.github.com/repos/openshift/origin/labels/sig/networking","name":"sig/networking","color":"f9d0c4","default":false},{"id":640547984,"url":"https://api.github.com/repos/openshift/origin/labels/size/S","name":"size/S","color":"77bb00","default":false}],"state":"open","locked":false,"assignee":{"login":"pecameron","id":13967482,"avatar_url":"https://avatars1.githubusercontent.com/u/13967482?v=4","gravatar_id":"","url":"https://api.github.com/users/pecameron","html_url":"https://github.com/pecameron","followers_url":"https://api.github.com/users/pecameron/followers","following_url":"https://api.github.com/users/pecameron/following{/other_user}","gists_url":"https://api.github.com/users/pecameron/gists{/gist_id}","starred_url":"https://api.github.com/users/pecameron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pecameron/subscriptions","organizations_url":"https://api.github.com/users/pecameron/orgs","repos_url":"https://api.github.com/users/pecameron/repos","events_url":"https://api.github.com/users/pecameron/events{/privacy}","received_events_url":"https://api.github.com/users/pecameron/received_events","type":"User","site_admin":false},"assignees":[{"login":"eparis","id":8093535,"avatar_url":"https://avatars3.githubusercontent.com/u/8093535?v=4","gravatar_id":"","url":"https://api.github.com/users/eparis","html_url":"https://github.com/eparis","followers_url":"https://api.github.com/users/eparis/followers","following_url":"https://api.github.com/users/eparis/following{/other_user}","gists_url":"https://api.github.com/users/eparis/gists{/gist_id}","starred_url":"https://api.github.com/users/eparis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eparis/subscriptions","organizations_url":"https://api.github.com/users/eparis/orgs","repos_url":"https://api.github.com/users/eparis/repos","events_url":"https://api.github.com/users/eparis/events{/privacy}","received_events_url":"https://api.github.com/users/eparis/received_events","type":"User","site_admin":false},{"login":"pecameron","id":13967482,"avatar_url":"https://avatars1.githubusercontent.com/u/13967482?v=4","gravatar_id":"","url":"https://api.github.com/users/pecameron","html_url":"https://github.com/pecameron","followers_url":"https://api.github.com/users/pecameron/followers","following_url":"https://api.github.com/users/pecameron/following{/other_user}","gists_url":"https://api.github.com/users/pecameron/gists{/gist_id}","starred_url":"https://api.github.com/users/pecameron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pecameron/subscriptions","organizations_url":"https://api.github.com/users/pecameron/orgs","repos_url":"https://api.github.com/users/pecameron/repos","events_url":"https://api.github.com/users/pecameron/events{/privacy}","received_events_url":"https://api.github.com/users/pecameron/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/openshift/origin/milestones/23","html_url":"https://github.com/openshift/origin/milestone/23","labels_url":"https://api.github.com/repos/openshift/origin/milestones/23/labels","id":2559115,"number":23,"title":"3.8.0","description":"","creator":{"login":"smarterclayton","id":1163175,"avatar_url":"https://avatars0.githubusercontent.com/u/1163175?v=4","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false},"open_issues":22,"closed_issues":7,"state":"open","created_at":"2017-06-02T19:45:49Z","updated_at":"2017-11-16T11:48:18Z","due_on":"2017-12-09T08:00:00Z","closed_at":null},"comments":11,"created_at":"2017-10-23T23:49:57Z","updated_at":"2017-11-18T03:13:31Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/17012","html_url":"https://github.com/openshift/origin/pull/17012","diff_url":"https://github.com/openshift/origin/pull/17012.diff","patch_url":"https://github.com/openshift/origin/pull/17012.patch"},"body":"- Resyncs are mainly intended for robustness. Mainly to handle the case\r\nwhere the resource handler failed to process the item and we hope this\r\nwill be fixed if we process the item again after sometime(resync interval).\r\nYes, this may fix some transient errors but if we resync frequently then\r\nthere could be big penalities.\r\n\r\n- Currently router watches these resources: routes, endpoints, nodes,\r\nnamespaces, ingresses and secrets. When we have many routes\r\n(like several thousand in online case), processing these items takes\r\nlong time, router reload itself takes few seconds (not milliseconds).\r\nDue to short resync interval there will be constant churn of reprocessing\r\nof all the items for all these resources.\r\n\r\n- Earlier we needed shorter resync interval because sharded router was depending\r\non this interval but with #16039 that limitation is removed.\r\n\r\n10 mins seems aggressive for some rare transient errors, changed defaults\r\nto 30 mins. Admin can edit router deployment config if they need custom resync interval.\r\n\r\nFixed project sync interval in router"},"comment":{"url":"https://api.github.com/repos/openshift/origin/issues/comments/345414325","html_url":"https://github.com/openshift/origin/pull/17012#issuecomment-345414325","issue_url":"https://api.github.com/repos/openshift/origin/issues/17012","id":345414325,"user":{"login":"openshift-merge-robot","id":30189218,"avatar_url":"https://avatars0.githubusercontent.com/u/30189218?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift-merge-robot","html_url":"https://github.com/openshift-merge-robot","followers_url":"https://api.github.com/users/openshift-merge-robot/followers","following_url":"https://api.github.com/users/openshift-merge-robot/following{/other_user}","gists_url":"https://api.github.com/users/openshift-merge-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift-merge-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift-merge-robot/subscriptions","organizations_url":"https://api.github.com/users/openshift-merge-robot/orgs","repos_url":"https://api.github.com/users/openshift-merge-robot/repos","events_url":"https://api.github.com/users/openshift-merge-robot/events{/privacy}","received_events_url":"https://api.github.com/users/openshift-merge-robot/received_events","type":"User","site_admin":false},"created_at":"2017-11-18T03:13:31Z","updated_at":"2017-11-18T03:13:31Z","author_association":"CONTRIBUTOR","body":"/test all [submit-queue is verifying that this PR is safe to merge]"}}
{"actor":{"display_login":"openshift-merge-robot"}}