{"action":"created","comment":{"url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/pulls/comments/158510360","pull_request_review_id":85336892,"id":158510360,"diff_hunk":"@@ -269,6 +269,39 @@ def get_port\n     end\n   end\n \n+  it \"should flush codec after client disconnects\" do\n+    # verifies fix for https://github.com/logstash-plugins/logstash-input-tcp/issues/90\n+    conf = <<-CONFIG\n+      input {\n+        tcp {\n+          port => #{port}\n+          codec => multiline {\n+              pattern => \"^\\s\"\n+              what => \"previous\"\n+          }\n+        }\n+      }\n+    CONFIG\n+\n+    data = \"a\\n 1\\n 2\\nb\\n 1\"\n+    event_count = 2\n+\n+    events = input(conf) do |pipeline, queue|\n+      socket = Stud::try(5.times) { TCPSocket.new(\"127.0.0.1\", port) }\n+      socket.puts(data)\n+      socket.close\n+\n+      event_count.times.collect {","path":"spec/inputs/tcp_spec.rb","position":26,"original_position":26,"commit_id":"481099a3e30f62b0f2ec6af9dbacf5ae6431cf65","original_commit_id":"481099a3e30f62b0f2ec6af9dbacf5ae6431cf65","user":{"login":"colinsurprenant","id":2010,"avatar_url":"https://avatars1.githubusercontent.com/u/2010?v=4","gravatar_id":"","url":"https://api.github.com/users/colinsurprenant","html_url":"https://github.com/colinsurprenant","followers_url":"https://api.github.com/users/colinsurprenant/followers","following_url":"https://api.github.com/users/colinsurprenant/following{/other_user}","gists_url":"https://api.github.com/users/colinsurprenant/gists{/gist_id}","starred_url":"https://api.github.com/users/colinsurprenant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colinsurprenant/subscriptions","organizations_url":"https://api.github.com/users/colinsurprenant/orgs","repos_url":"https://api.github.com/users/colinsurprenant/repos","events_url":"https://api.github.com/users/colinsurprenant/events{/privacy}","received_events_url":"https://api.github.com/users/colinsurprenant/received_events","type":"User","site_admin":false},"body":"nit: multi-lines blocks should use `do` ... `end`. we try to use `{` ...  `}` for single-line blocks.","created_at":"2017-12-22T15:25:11Z","updated_at":"2017-12-22T15:25:11Z","html_url":"https://github.com/logstash-plugins/logstash-input-tcp/pull/101#discussion_r158510360","pull_request_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/pulls/101","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/pulls/comments/158510360"},"html":{"href":"https://github.com/logstash-plugins/logstash-input-tcp/pull/101#discussion_r158510360"},"pull_request":{"href":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/pulls/101"}}},"pull_request":{"url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/pulls/101","id":159037718,"html_url":"https://github.com/logstash-plugins/logstash-input-tcp/pull/101","diff_url":"https://github.com/logstash-plugins/logstash-input-tcp/pull/101.diff","patch_url":"https://github.com/logstash-plugins/logstash-input-tcp/pull/101.patch","issue_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/issues/101","number":101,"state":"open","locked":false,"title":"Flush codec after TCP client disconnects.","user":{"login":"danhermann","id":22777892,"avatar_url":"https://avatars0.githubusercontent.com/u/22777892?v=4","gravatar_id":"","url":"https://api.github.com/users/danhermann","html_url":"https://github.com/danhermann","followers_url":"https://api.github.com/users/danhermann/followers","following_url":"https://api.github.com/users/danhermann/following{/other_user}","gists_url":"https://api.github.com/users/danhermann/gists{/gist_id}","starred_url":"https://api.github.com/users/danhermann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danhermann/subscriptions","organizations_url":"https://api.github.com/users/danhermann/orgs","repos_url":"https://api.github.com/users/danhermann/repos","events_url":"https://api.github.com/users/danhermann/events{/privacy}","received_events_url":"https://api.github.com/users/danhermann/received_events","type":"User","site_admin":false},"body":"Relates to #95 and #99\r\n\r\nFixes #90 \r\n\r\n","created_at":"2017-12-18T22:51:14Z","updated_at":"2017-12-22T15:25:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dec4c8f2d8a97b4f5fc99cb8ea0f276144f94004","assignee":{"login":"jordansissel","id":131818,"avatar_url":"https://avatars1.githubusercontent.com/u/131818?v=4","gravatar_id":"","url":"https://api.github.com/users/jordansissel","html_url":"https://github.com/jordansissel","followers_url":"https://api.github.com/users/jordansissel/followers","following_url":"https://api.github.com/users/jordansissel/following{/other_user}","gists_url":"https://api.github.com/users/jordansissel/gists{/gist_id}","starred_url":"https://api.github.com/users/jordansissel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jordansissel/subscriptions","organizations_url":"https://api.github.com/users/jordansissel/orgs","repos_url":"https://api.github.com/users/jordansissel/repos","events_url":"https://api.github.com/users/jordansissel/events{/privacy}","received_events_url":"https://api.github.com/users/jordansissel/received_events","type":"User","site_admin":false},"assignees":[{"login":"jordansissel","id":131818,"avatar_url":"https://avatars1.githubusercontent.com/u/131818?v=4","gravatar_id":"","url":"https://api.github.com/users/jordansissel","html_url":"https://github.com/jordansissel","followers_url":"https://api.github.com/users/jordansissel/followers","following_url":"https://api.github.com/users/jordansissel/following{/other_user}","gists_url":"https://api.github.com/users/jordansissel/gists{/gist_id}","starred_url":"https://api.github.com/users/jordansissel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jordansissel/subscriptions","organizations_url":"https://api.github.com/users/jordansissel/orgs","repos_url":"https://api.github.com/users/jordansissel/repos","events_url":"https://api.github.com/users/jordansissel/events{/privacy}","received_events_url":"https://api.github.com/users/jordansissel/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/pulls/101/commits","review_comments_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/pulls/101/comments","review_comment_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/issues/101/comments","statuses_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/statuses/481099a3e30f62b0f2ec6af9dbacf5ae6431cf65","head":{"label":"danhermann:90_missing_tcp_input","ref":"90_missing_tcp_input","sha":"481099a3e30f62b0f2ec6af9dbacf5ae6431cf65","user":{"login":"danhermann","id":22777892,"avatar_url":"https://avatars0.githubusercontent.com/u/22777892?v=4","gravatar_id":"","url":"https://api.github.com/users/danhermann","html_url":"https://github.com/danhermann","followers_url":"https://api.github.com/users/danhermann/followers","following_url":"https://api.github.com/users/danhermann/following{/other_user}","gists_url":"https://api.github.com/users/danhermann/gists{/gist_id}","starred_url":"https://api.github.com/users/danhermann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danhermann/subscriptions","organizations_url":"https://api.github.com/users/danhermann/orgs","repos_url":"https://api.github.com/users/danhermann/repos","events_url":"https://api.github.com/users/danhermann/events{/privacy}","received_events_url":"https://api.github.com/users/danhermann/received_events","type":"User","site_admin":false},"repo":{"id":113909850,"name":"logstash-input-tcp","full_name":"danhermann/logstash-input-tcp","owner":{"login":"danhermann","id":22777892,"avatar_url":"https://avatars0.githubusercontent.com/u/22777892?v=4","gravatar_id":"","url":"https://api.github.com/users/danhermann","html_url":"https://github.com/danhermann","followers_url":"https://api.github.com/users/danhermann/followers","following_url":"https://api.github.com/users/danhermann/following{/other_user}","gists_url":"https://api.github.com/users/danhermann/gists{/gist_id}","starred_url":"https://api.github.com/users/danhermann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danhermann/subscriptions","organizations_url":"https://api.github.com/users/danhermann/orgs","repos_url":"https://api.github.com/users/danhermann/repos","events_url":"https://api.github.com/users/danhermann/events{/privacy}","received_events_url":"https://api.github.com/users/danhermann/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danhermann/logstash-input-tcp","description":null,"fork":true,"url":"https://api.github.com/repos/danhermann/logstash-input-tcp","forks_url":"https://api.github.com/repos/danhermann/logstash-input-tcp/forks","keys_url":"https://api.github.com/repos/danhermann/logstash-input-tcp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danhermann/logstash-input-tcp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danhermann/logstash-input-tcp/teams","hooks_url":"https://api.github.com/repos/danhermann/logstash-input-tcp/hooks","issue_events_url":"https://api.github.com/repos/danhermann/logstash-input-tcp/issues/events{/number}","events_url":"https://api.github.com/repos/danhermann/logstash-input-tcp/events","assignees_url":"https://api.github.com/repos/danhermann/logstash-input-tcp/assignees{/user}","branches_url":"https://api.github.com/repos/danhermann/logstash-input-tcp/branches{/branch}","tags_url":"https://api.github.com/repos/danhermann/logstash-input-tcp/tags","blobs_url":"https://api.github.com/repos/danhermann/logstash-input-tcp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danhermann/logstash-input-tcp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danhermann/logstash-input-tcp/git/refs{/sha}","trees_url":"https://api.github.com/repos/danhermann/logstash-input-tcp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danhermann/logstash-input-tcp/statuses/{sha}","languages_url":"https://api.github.com/repos/danhermann/logstash-input-tcp/languages","stargazers_url":"https://api.github.com/repos/danhermann/logstash-input-tcp/stargazers","contributors_url":"https://api.github.com/repos/danhermann/logstash-input-tcp/contributors","subscribers_url":"https://api.github.com/repos/danhermann/logstash-input-tcp/subscribers","subscription_url":"https://api.github.com/repos/danhermann/logstash-input-tcp/subscription","commits_url":"https://api.github.com/repos/danhermann/logstash-input-tcp/commits{/sha}","git_commits_url":"https://api.github.com/repos/danhermann/logstash-input-tcp/git/commits{/sha}","comments_url":"https://api.github.com/repos/danhermann/logstash-input-tcp/comments{/number}","issue_comment_url":"https://api.github.com/repos/danhermann/logstash-input-tcp/issues/comments{/number}","contents_url":"https://api.github.com/repos/danhermann/logstash-input-tcp/contents/{+path}","compare_url":"https://api.github.com/repos/danhermann/logstash-input-tcp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danhermann/logstash-input-tcp/merges","archive_url":"https://api.github.com/repos/danhermann/logstash-input-tcp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danhermann/logstash-input-tcp/downloads","issues_url":"https://api.github.com/repos/danhermann/logstash-input-tcp/issues{/number}","pulls_url":"https://api.github.com/repos/danhermann/logstash-input-tcp/pulls{/number}","milestones_url":"https://api.github.com/repos/danhermann/logstash-input-tcp/milestones{/number}","notifications_url":"https://api.github.com/repos/danhermann/logstash-input-tcp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danhermann/logstash-input-tcp/labels{/name}","releases_url":"https://api.github.com/repos/danhermann/logstash-input-tcp/releases{/id}","deployments_url":"https://api.github.com/repos/danhermann/logstash-input-tcp/deployments","created_at":"2017-12-11T21:21:32Z","updated_at":"2017-12-11T21:21:34Z","pushed_at":"2017-12-20T22:35:19Z","git_url":"git://github.com/danhermann/logstash-input-tcp.git","ssh_url":"git@github.com:danhermann/logstash-input-tcp.git","clone_url":"https://github.com/danhermann/logstash-input-tcp.git","svn_url":"https://github.com/danhermann/logstash-input-tcp","homepage":null,"size":178,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"logstash-plugins:master","ref":"master","sha":"d8e79f881bc74185d11557e0877e1c16977e2095","user":{"login":"logstash-plugins","id":8961934,"avatar_url":"https://avatars1.githubusercontent.com/u/8961934?v=4","gravatar_id":"","url":"https://api.github.com/users/logstash-plugins","html_url":"https://github.com/logstash-plugins","followers_url":"https://api.github.com/users/logstash-plugins/followers","following_url":"https://api.github.com/users/logstash-plugins/following{/other_user}","gists_url":"https://api.github.com/users/logstash-plugins/gists{/gist_id}","starred_url":"https://api.github.com/users/logstash-plugins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/logstash-plugins/subscriptions","organizations_url":"https://api.github.com/users/logstash-plugins/orgs","repos_url":"https://api.github.com/users/logstash-plugins/repos","events_url":"https://api.github.com/users/logstash-plugins/events{/privacy}","received_events_url":"https://api.github.com/users/logstash-plugins/received_events","type":"Organization","site_admin":false},"repo":{"id":25312507,"name":"logstash-input-tcp","full_name":"logstash-plugins/logstash-input-tcp","owner":{"login":"logstash-plugins","id":8961934,"avatar_url":"https://avatars1.githubusercontent.com/u/8961934?v=4","gravatar_id":"","url":"https://api.github.com/users/logstash-plugins","html_url":"https://github.com/logstash-plugins","followers_url":"https://api.github.com/users/logstash-plugins/followers","following_url":"https://api.github.com/users/logstash-plugins/following{/other_user}","gists_url":"https://api.github.com/users/logstash-plugins/gists{/gist_id}","starred_url":"https://api.github.com/users/logstash-plugins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/logstash-plugins/subscriptions","organizations_url":"https://api.github.com/users/logstash-plugins/orgs","repos_url":"https://api.github.com/users/logstash-plugins/repos","events_url":"https://api.github.com/users/logstash-plugins/events{/privacy}","received_events_url":"https://api.github.com/users/logstash-plugins/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/logstash-plugins/logstash-input-tcp","description":null,"fork":false,"url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp","forks_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/forks","keys_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/teams","hooks_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/hooks","issue_events_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/issues/events{/number}","events_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/events","assignees_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/assignees{/user}","branches_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/branches{/branch}","tags_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/tags","blobs_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/git/refs{/sha}","trees_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/statuses/{sha}","languages_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/languages","stargazers_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/stargazers","contributors_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/contributors","subscribers_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/subscribers","subscription_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/subscription","commits_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/commits{/sha}","git_commits_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/git/commits{/sha}","comments_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/comments{/number}","issue_comment_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/issues/comments{/number}","contents_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/contents/{+path}","compare_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/merges","archive_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/downloads","issues_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/issues{/number}","pulls_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/pulls{/number}","milestones_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/milestones{/number}","notifications_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/labels{/name}","releases_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/releases{/id}","deployments_url":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/deployments","created_at":"2014-10-16T17:03:48Z","updated_at":"2017-10-21T20:43:47Z","pushed_at":"2017-12-20T22:35:20Z","git_url":"git://github.com/logstash-plugins/logstash-input-tcp.git","ssh_url":"git@github.com:logstash-plugins/logstash-input-tcp.git","clone_url":"https://github.com/logstash-plugins/logstash-input-tcp.git","svn_url":"https://github.com/logstash-plugins/logstash-input-tcp","homepage":null,"size":174,"stargazers_count":10,"watchers_count":10,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"archived":false,"open_issues_count":35,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":34,"open_issues":35,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/pulls/101"},"html":{"href":"https://github.com/logstash-plugins/logstash-input-tcp/pull/101"},"issue":{"href":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/issues/101"},"comments":{"href":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/issues/101/comments"},"review_comments":{"href":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/pulls/101/comments"},"review_comment":{"href":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/pulls/101/commits"},"statuses":{"href":"https://api.github.com/repos/logstash-plugins/logstash-input-tcp/statuses/481099a3e30f62b0f2ec6af9dbacf5ae6431cf65"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"colinsurprenant"}}