{"action":"created","issue":{"url":"https://api.github.com/repos/tabakg/potapov_interpolation/issues/11","repository_url":"https://api.github.com/repos/tabakg/potapov_interpolation","labels_url":"https://api.github.com/repos/tabakg/potapov_interpolation/issues/11/labels{/name}","comments_url":"https://api.github.com/repos/tabakg/potapov_interpolation/issues/11/comments","events_url":"https://api.github.com/repos/tabakg/potapov_interpolation/issues/11/events","html_url":"https://github.com/tabakg/potapov_interpolation/issues/11","id":265921614,"number":11,"title":"get_roots_rect returns multiple (and sometimes inaccurate) variations of the same root.","user":{"login":"petersbingham","id":13222776,"avatar_url":"https://avatars2.githubusercontent.com/u/13222776?v=4","gravatar_id":"","url":"https://api.github.com/users/petersbingham","html_url":"https://github.com/petersbingham","followers_url":"https://api.github.com/users/petersbingham/followers","following_url":"https://api.github.com/users/petersbingham/following{/other_user}","gists_url":"https://api.github.com/users/petersbingham/gists{/gist_id}","starred_url":"https://api.github.com/users/petersbingham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petersbingham/subscriptions","organizations_url":"https://api.github.com/users/petersbingham/orgs","repos_url":"https://api.github.com/users/petersbingham/repos","events_url":"https://api.github.com/users/petersbingham/events{/privacy}","received_events_url":"https://api.github.com/users/petersbingham/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-10-16T21:25:27Z","updated_at":"2017-10-17T23:44:47Z","closed_at":null,"author_association":"NONE","body":"The issue can be demonstrated using the additional test cases added to the fork here:\r\nhttps://github.com/petersbingham/potapov_interpolation/blob/Potapov_PolyRootTests/Potapov_Code/tests/tests_Roots.py \r\n\r\neg:\r\n\r\n`test_Poly_Roots(11, printRoots=True, printPolys=False, printParams=False, doubleOnWarning=False)`\r\n\r\nWhen running this example some stats are printed and then a list of roots (in the left column) obtained using numpy.roots and then another list obtained using get_roots_rect. The numbers in the right column (beside the roots) are the results of plugging the root back into the function (so obviously expect to be close to zero).\r\n\r\nThis is a 10th order polynomial, so expect 10 roots. The numpy in the test code does return the correct number of roots but get_roots_rect returns 22. The roots returned with get_roots_rect all appear clustered around the numpy root values. \r\n\r\nI've had a brief look at this and it appears to arise from applying muller to the outliers. This may therefore apply more accurately to the muller function or may be a numerical limitation of the routine,"},"comment":{"url":"https://api.github.com/repos/tabakg/potapov_interpolation/issues/comments/337411611","html_url":"https://github.com/tabakg/potapov_interpolation/issues/11#issuecomment-337411611","issue_url":"https://api.github.com/repos/tabakg/potapov_interpolation/issues/11","id":337411611,"user":{"login":"petersbingham","id":13222776,"avatar_url":"https://avatars2.githubusercontent.com/u/13222776?v=4","gravatar_id":"","url":"https://api.github.com/users/petersbingham","html_url":"https://github.com/petersbingham","followers_url":"https://api.github.com/users/petersbingham/followers","following_url":"https://api.github.com/users/petersbingham/following{/other_user}","gists_url":"https://api.github.com/users/petersbingham/gists{/gist_id}","starred_url":"https://api.github.com/users/petersbingham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petersbingham/subscriptions","organizations_url":"https://api.github.com/users/petersbingham/orgs","repos_url":"https://api.github.com/users/petersbingham/repos","events_url":"https://api.github.com/users/petersbingham/events{/privacy}","received_events_url":"https://api.github.com/users/petersbingham/received_events","type":"User","site_admin":false},"created_at":"2017-10-17T23:44:47Z","updated_at":"2017-10-17T23:44:47Z","author_association":"NONE","body":"I believe that I have this fixed. The issue was that the muller verbose parameter was overriding the default tol."}}
{"actor":{"display_login":"petersbingham"}}