{"action":"created","comment":{"url":"https://api.github.com/repos/Godlike/Unicorn/pulls/comments/155966326","pull_request_review_id":82358367,"id":155966326,"diff_hunk":"@@ -0,0 +1,54 @@\n+/*\n+* Copyright (C) 2017 by Godlike\n+* This code is licensed under the MIT license (MIT)\n+* (http://opensource.org/licenses/MIT)\n+*/\n+\n+#include <unicorn/video/OrthographicCamera.hpp>\n+\n+#include <glm/gtc/matrix_transform.hpp>\n+\n+namespace unicorn\n+{\n+namespace video\n+{\n+\n+OrthographicCamera::OrthographicCamera(system::Window& window, glm::mat4& cameraProj)\n+    : CameraProjection(window, cameraProj)\n+    , m_orthoScale(100.f)\n+    , m_scaledAspect(m_aspect / m_orthoScale)\n+    , m_right(static_cast<float>(m_pWindow->GetSize().first) / 2)\n+    , m_top(static_cast<float>(m_pWindow->GetSize().second) / 2)\n+    , m_back(-1000.f)\n+    , m_front(1000.f)","path":"UnicornRender/video/source/OrthographicCamera.cpp","position":23,"original_position":23,"commit_id":"33fa6fd014d8be83982a1eff4012f2668c6ea685","original_commit_id":"33fa6fd014d8be83982a1eff4012f2668c6ea685","user":{"login":"dsodintsov","id":4486547,"avatar_url":"https://avatars1.githubusercontent.com/u/4486547?v=4","gravatar_id":"","url":"https://api.github.com/users/dsodintsov","html_url":"https://github.com/dsodintsov","followers_url":"https://api.github.com/users/dsodintsov/followers","following_url":"https://api.github.com/users/dsodintsov/following{/other_user}","gists_url":"https://api.github.com/users/dsodintsov/gists{/gist_id}","starred_url":"https://api.github.com/users/dsodintsov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsodintsov/subscriptions","organizations_url":"https://api.github.com/users/dsodintsov/orgs","repos_url":"https://api.github.com/users/dsodintsov/repos","events_url":"https://api.github.com/users/dsodintsov/events{/privacy}","received_events_url":"https://api.github.com/users/dsodintsov/received_events","type":"User","site_admin":false},"body":"please move constants to header file to avoid magic numbers","created_at":"2017-12-11T00:36:21Z","updated_at":"2017-12-11T00:41:55Z","html_url":"https://github.com/Godlike/Unicorn/pull/110#discussion_r155966326","pull_request_url":"https://api.github.com/repos/Godlike/Unicorn/pulls/110","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/Godlike/Unicorn/pulls/comments/155966326"},"html":{"href":"https://github.com/Godlike/Unicorn/pull/110#discussion_r155966326"},"pull_request":{"href":"https://api.github.com/repos/Godlike/Unicorn/pulls/110"}}},"pull_request":{"url":"https://api.github.com/repos/Godlike/Unicorn/pulls/110","id":151426902,"html_url":"https://github.com/Godlike/Unicorn/pull/110","diff_url":"https://github.com/Godlike/Unicorn/pull/110.diff","patch_url":"https://github.com/Godlike/Unicorn/pull/110.patch","issue_url":"https://api.github.com/repos/Godlike/Unicorn/issues/110","number":110,"state":"open","locked":false,"title":"Task 86/orthographic camera","user":{"login":"Warezovvv","id":5683877,"avatar_url":"https://avatars2.githubusercontent.com/u/5683877?v=4","gravatar_id":"","url":"https://api.github.com/users/Warezovvv","html_url":"https://github.com/Warezovvv","followers_url":"https://api.github.com/users/Warezovvv/followers","following_url":"https://api.github.com/users/Warezovvv/following{/other_user}","gists_url":"https://api.github.com/users/Warezovvv/gists{/gist_id}","starred_url":"https://api.github.com/users/Warezovvv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Warezovvv/subscriptions","organizations_url":"https://api.github.com/users/Warezovvv/orgs","repos_url":"https://api.github.com/users/Warezovvv/repos","events_url":"https://api.github.com/users/Warezovvv/events{/privacy}","received_events_url":"https://api.github.com/users/Warezovvv/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-11-08T16:16:55Z","updated_at":"2017-12-11T00:41:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"354129e762d5157d9bc46eba5daf53ff3b26f5c9","assignee":{"login":"Warezovvv","id":5683877,"avatar_url":"https://avatars2.githubusercontent.com/u/5683877?v=4","gravatar_id":"","url":"https://api.github.com/users/Warezovvv","html_url":"https://github.com/Warezovvv","followers_url":"https://api.github.com/users/Warezovvv/followers","following_url":"https://api.github.com/users/Warezovvv/following{/other_user}","gists_url":"https://api.github.com/users/Warezovvv/gists{/gist_id}","starred_url":"https://api.github.com/users/Warezovvv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Warezovvv/subscriptions","organizations_url":"https://api.github.com/users/Warezovvv/orgs","repos_url":"https://api.github.com/users/Warezovvv/repos","events_url":"https://api.github.com/users/Warezovvv/events{/privacy}","received_events_url":"https://api.github.com/users/Warezovvv/received_events","type":"User","site_admin":false},"assignees":[{"login":"Warezovvv","id":5683877,"avatar_url":"https://avatars2.githubusercontent.com/u/5683877?v=4","gravatar_id":"","url":"https://api.github.com/users/Warezovvv","html_url":"https://github.com/Warezovvv","followers_url":"https://api.github.com/users/Warezovvv/followers","following_url":"https://api.github.com/users/Warezovvv/following{/other_user}","gists_url":"https://api.github.com/users/Warezovvv/gists{/gist_id}","starred_url":"https://api.github.com/users/Warezovvv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Warezovvv/subscriptions","organizations_url":"https://api.github.com/users/Warezovvv/orgs","repos_url":"https://api.github.com/users/Warezovvv/repos","events_url":"https://api.github.com/users/Warezovvv/events{/privacy}","received_events_url":"https://api.github.com/users/Warezovvv/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/Godlike/Unicorn/milestones/2","html_url":"https://github.com/Godlike/Unicorn/milestone/2","labels_url":"https://api.github.com/repos/Godlike/Unicorn/milestones/2/labels","id":2427502,"number":2,"title":"Rendering","description":"","creator":{"login":"Warezovvv","id":5683877,"avatar_url":"https://avatars2.githubusercontent.com/u/5683877?v=4","gravatar_id":"","url":"https://api.github.com/users/Warezovvv","html_url":"https://github.com/Warezovvv","followers_url":"https://api.github.com/users/Warezovvv/followers","following_url":"https://api.github.com/users/Warezovvv/following{/other_user}","gists_url":"https://api.github.com/users/Warezovvv/gists{/gist_id}","starred_url":"https://api.github.com/users/Warezovvv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Warezovvv/subscriptions","organizations_url":"https://api.github.com/users/Warezovvv/orgs","repos_url":"https://api.github.com/users/Warezovvv/repos","events_url":"https://api.github.com/users/Warezovvv/events{/privacy}","received_events_url":"https://api.github.com/users/Warezovvv/received_events","type":"User","site_admin":false},"open_issues":26,"closed_issues":8,"state":"open","created_at":"2017-04-01T19:31:29Z","updated_at":"2017-11-08T16:34:31Z","due_on":"2017-12-31T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/Godlike/Unicorn/pulls/110/commits","review_comments_url":"https://api.github.com/repos/Godlike/Unicorn/pulls/110/comments","review_comment_url":"https://api.github.com/repos/Godlike/Unicorn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Godlike/Unicorn/issues/110/comments","statuses_url":"https://api.github.com/repos/Godlike/Unicorn/statuses/33fa6fd014d8be83982a1eff4012f2668c6ea685","head":{"label":"Godlike:task_86/orthographic_camera","ref":"task_86/orthographic_camera","sha":"33fa6fd014d8be83982a1eff4012f2668c6ea685","user":{"login":"Godlike","id":9056024,"avatar_url":"https://avatars1.githubusercontent.com/u/9056024?v=4","gravatar_id":"","url":"https://api.github.com/users/Godlike","html_url":"https://github.com/Godlike","followers_url":"https://api.github.com/users/Godlike/followers","following_url":"https://api.github.com/users/Godlike/following{/other_user}","gists_url":"https://api.github.com/users/Godlike/gists{/gist_id}","starred_url":"https://api.github.com/users/Godlike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Godlike/subscriptions","organizations_url":"https://api.github.com/users/Godlike/orgs","repos_url":"https://api.github.com/users/Godlike/repos","events_url":"https://api.github.com/users/Godlike/events{/privacy}","received_events_url":"https://api.github.com/users/Godlike/received_events","type":"Organization","site_admin":false},"repo":{"id":77059529,"name":"Unicorn","full_name":"Godlike/Unicorn","owner":{"login":"Godlike","id":9056024,"avatar_url":"https://avatars1.githubusercontent.com/u/9056024?v=4","gravatar_id":"","url":"https://api.github.com/users/Godlike","html_url":"https://github.com/Godlike","followers_url":"https://api.github.com/users/Godlike/followers","following_url":"https://api.github.com/users/Godlike/following{/other_user}","gists_url":"https://api.github.com/users/Godlike/gists{/gist_id}","starred_url":"https://api.github.com/users/Godlike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Godlike/subscriptions","organizations_url":"https://api.github.com/users/Godlike/orgs","repos_url":"https://api.github.com/users/Godlike/repos","events_url":"https://api.github.com/users/Godlike/events{/privacy}","received_events_url":"https://api.github.com/users/Godlike/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Godlike/Unicorn","description":"Render engine developed by mythical beings.","fork":false,"url":"https://api.github.com/repos/Godlike/Unicorn","forks_url":"https://api.github.com/repos/Godlike/Unicorn/forks","keys_url":"https://api.github.com/repos/Godlike/Unicorn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Godlike/Unicorn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Godlike/Unicorn/teams","hooks_url":"https://api.github.com/repos/Godlike/Unicorn/hooks","issue_events_url":"https://api.github.com/repos/Godlike/Unicorn/issues/events{/number}","events_url":"https://api.github.com/repos/Godlike/Unicorn/events","assignees_url":"https://api.github.com/repos/Godlike/Unicorn/assignees{/user}","branches_url":"https://api.github.com/repos/Godlike/Unicorn/branches{/branch}","tags_url":"https://api.github.com/repos/Godlike/Unicorn/tags","blobs_url":"https://api.github.com/repos/Godlike/Unicorn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Godlike/Unicorn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Godlike/Unicorn/git/refs{/sha}","trees_url":"https://api.github.com/repos/Godlike/Unicorn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Godlike/Unicorn/statuses/{sha}","languages_url":"https://api.github.com/repos/Godlike/Unicorn/languages","stargazers_url":"https://api.github.com/repos/Godlike/Unicorn/stargazers","contributors_url":"https://api.github.com/repos/Godlike/Unicorn/contributors","subscribers_url":"https://api.github.com/repos/Godlike/Unicorn/subscribers","subscription_url":"https://api.github.com/repos/Godlike/Unicorn/subscription","commits_url":"https://api.github.com/repos/Godlike/Unicorn/commits{/sha}","git_commits_url":"https://api.github.com/repos/Godlike/Unicorn/git/commits{/sha}","comments_url":"https://api.github.com/repos/Godlike/Unicorn/comments{/number}","issue_comment_url":"https://api.github.com/repos/Godlike/Unicorn/issues/comments{/number}","contents_url":"https://api.github.com/repos/Godlike/Unicorn/contents/{+path}","compare_url":"https://api.github.com/repos/Godlike/Unicorn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Godlike/Unicorn/merges","archive_url":"https://api.github.com/repos/Godlike/Unicorn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Godlike/Unicorn/downloads","issues_url":"https://api.github.com/repos/Godlike/Unicorn/issues{/number}","pulls_url":"https://api.github.com/repos/Godlike/Unicorn/pulls{/number}","milestones_url":"https://api.github.com/repos/Godlike/Unicorn/milestones{/number}","notifications_url":"https://api.github.com/repos/Godlike/Unicorn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Godlike/Unicorn/labels{/name}","releases_url":"https://api.github.com/repos/Godlike/Unicorn/releases{/id}","deployments_url":"https://api.github.com/repos/Godlike/Unicorn/deployments","created_at":"2016-12-21T14:39:53Z","updated_at":"2017-12-04T10:21:07Z","pushed_at":"2017-12-10T17:34:09Z","git_url":"git://github.com/Godlike/Unicorn.git","ssh_url":"git@github.com:Godlike/Unicorn.git","clone_url":"https://github.com/Godlike/Unicorn.git","svn_url":"https://github.com/Godlike/Unicorn","homepage":"","size":147857,"stargazers_count":5,"watchers_count":5,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":28,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":28,"watchers":5,"default_branch":"master"}},"base":{"label":"Godlike:master","ref":"master","sha":"aaf7333d126289f772db8fd1531d36343e4f500a","user":{"login":"Godlike","id":9056024,"avatar_url":"https://avatars1.githubusercontent.com/u/9056024?v=4","gravatar_id":"","url":"https://api.github.com/users/Godlike","html_url":"https://github.com/Godlike","followers_url":"https://api.github.com/users/Godlike/followers","following_url":"https://api.github.com/users/Godlike/following{/other_user}","gists_url":"https://api.github.com/users/Godlike/gists{/gist_id}","starred_url":"https://api.github.com/users/Godlike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Godlike/subscriptions","organizations_url":"https://api.github.com/users/Godlike/orgs","repos_url":"https://api.github.com/users/Godlike/repos","events_url":"https://api.github.com/users/Godlike/events{/privacy}","received_events_url":"https://api.github.com/users/Godlike/received_events","type":"Organization","site_admin":false},"repo":{"id":77059529,"name":"Unicorn","full_name":"Godlike/Unicorn","owner":{"login":"Godlike","id":9056024,"avatar_url":"https://avatars1.githubusercontent.com/u/9056024?v=4","gravatar_id":"","url":"https://api.github.com/users/Godlike","html_url":"https://github.com/Godlike","followers_url":"https://api.github.com/users/Godlike/followers","following_url":"https://api.github.com/users/Godlike/following{/other_user}","gists_url":"https://api.github.com/users/Godlike/gists{/gist_id}","starred_url":"https://api.github.com/users/Godlike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Godlike/subscriptions","organizations_url":"https://api.github.com/users/Godlike/orgs","repos_url":"https://api.github.com/users/Godlike/repos","events_url":"https://api.github.com/users/Godlike/events{/privacy}","received_events_url":"https://api.github.com/users/Godlike/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Godlike/Unicorn","description":"Render engine developed by mythical beings.","fork":false,"url":"https://api.github.com/repos/Godlike/Unicorn","forks_url":"https://api.github.com/repos/Godlike/Unicorn/forks","keys_url":"https://api.github.com/repos/Godlike/Unicorn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Godlike/Unicorn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Godlike/Unicorn/teams","hooks_url":"https://api.github.com/repos/Godlike/Unicorn/hooks","issue_events_url":"https://api.github.com/repos/Godlike/Unicorn/issues/events{/number}","events_url":"https://api.github.com/repos/Godlike/Unicorn/events","assignees_url":"https://api.github.com/repos/Godlike/Unicorn/assignees{/user}","branches_url":"https://api.github.com/repos/Godlike/Unicorn/branches{/branch}","tags_url":"https://api.github.com/repos/Godlike/Unicorn/tags","blobs_url":"https://api.github.com/repos/Godlike/Unicorn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Godlike/Unicorn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Godlike/Unicorn/git/refs{/sha}","trees_url":"https://api.github.com/repos/Godlike/Unicorn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Godlike/Unicorn/statuses/{sha}","languages_url":"https://api.github.com/repos/Godlike/Unicorn/languages","stargazers_url":"https://api.github.com/repos/Godlike/Unicorn/stargazers","contributors_url":"https://api.github.com/repos/Godlike/Unicorn/contributors","subscribers_url":"https://api.github.com/repos/Godlike/Unicorn/subscribers","subscription_url":"https://api.github.com/repos/Godlike/Unicorn/subscription","commits_url":"https://api.github.com/repos/Godlike/Unicorn/commits{/sha}","git_commits_url":"https://api.github.com/repos/Godlike/Unicorn/git/commits{/sha}","comments_url":"https://api.github.com/repos/Godlike/Unicorn/comments{/number}","issue_comment_url":"https://api.github.com/repos/Godlike/Unicorn/issues/comments{/number}","contents_url":"https://api.github.com/repos/Godlike/Unicorn/contents/{+path}","compare_url":"https://api.github.com/repos/Godlike/Unicorn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Godlike/Unicorn/merges","archive_url":"https://api.github.com/repos/Godlike/Unicorn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Godlike/Unicorn/downloads","issues_url":"https://api.github.com/repos/Godlike/Unicorn/issues{/number}","pulls_url":"https://api.github.com/repos/Godlike/Unicorn/pulls{/number}","milestones_url":"https://api.github.com/repos/Godlike/Unicorn/milestones{/number}","notifications_url":"https://api.github.com/repos/Godlike/Unicorn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Godlike/Unicorn/labels{/name}","releases_url":"https://api.github.com/repos/Godlike/Unicorn/releases{/id}","deployments_url":"https://api.github.com/repos/Godlike/Unicorn/deployments","created_at":"2016-12-21T14:39:53Z","updated_at":"2017-12-04T10:21:07Z","pushed_at":"2017-12-10T17:34:09Z","git_url":"git://github.com/Godlike/Unicorn.git","ssh_url":"git@github.com:Godlike/Unicorn.git","clone_url":"https://github.com/Godlike/Unicorn.git","svn_url":"https://github.com/Godlike/Unicorn","homepage":"","size":147857,"stargazers_count":5,"watchers_count":5,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":28,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":28,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Godlike/Unicorn/pulls/110"},"html":{"href":"https://github.com/Godlike/Unicorn/pull/110"},"issue":{"href":"https://api.github.com/repos/Godlike/Unicorn/issues/110"},"comments":{"href":"https://api.github.com/repos/Godlike/Unicorn/issues/110/comments"},"review_comments":{"href":"https://api.github.com/repos/Godlike/Unicorn/pulls/110/comments"},"review_comment":{"href":"https://api.github.com/repos/Godlike/Unicorn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Godlike/Unicorn/pulls/110/commits"},"statuses":{"href":"https://api.github.com/repos/Godlike/Unicorn/statuses/33fa6fd014d8be83982a1eff4012f2668c6ea685"}},"author_association":"OWNER"}}
{"actor":{"display_login":"dsodintsov"}}