{"action":"created","issue":{"url":"https://api.github.com/repos/p4lang/p4-spec/issues/286","repository_url":"https://api.github.com/repos/p4lang/p4-spec","labels_url":"https://api.github.com/repos/p4lang/p4-spec/issues/286/labels{/name}","comments_url":"https://api.github.com/repos/p4lang/p4-spec/issues/286/comments","events_url":"https://api.github.com/repos/p4lang/p4-spec/issues/286/events","html_url":"https://github.com/p4lang/p4-spec/issues/286","id":234793885,"number":286,"title":"Question: P4-16 headerUnionDeclaration: definition / appearance","user":{"login":"SmartHoneybee","id":18035422,"avatar_url":"https://avatars0.githubusercontent.com/u/18035422?v=3","gravatar_id":"","url":"https://api.github.com/users/SmartHoneybee","html_url":"https://github.com/SmartHoneybee","followers_url":"https://api.github.com/users/SmartHoneybee/followers","following_url":"https://api.github.com/users/SmartHoneybee/following{/other_user}","gists_url":"https://api.github.com/users/SmartHoneybee/gists{/gist_id}","starred_url":"https://api.github.com/users/SmartHoneybee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SmartHoneybee/subscriptions","organizations_url":"https://api.github.com/users/SmartHoneybee/orgs","repos_url":"https://api.github.com/users/SmartHoneybee/repos","events_url":"https://api.github.com/users/SmartHoneybee/events{/privacy}","received_events_url":"https://api.github.com/users/SmartHoneybee/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2017-06-09T11:03:27Z","updated_at":"2017-06-23T11:51:15Z","closed_at":null,"body":"The definition of `derivedTypeDeclaration` in `p4-16/spec/P4-16-spec.mdk` mentions `headerUnionDeclaration` twice, the definition in `p4-16/spec/grammar.mdk` only once. Why?\r\n\r\nIn `p4-16/spec/P4-16-spec.mdk`  `headerUnionDeclaration` is defined as:\r\n```\r\nheaderUnionDeclaration\r\n    : optAnnotations HEADER_UNION name { structure.declareType(*$3); }\r\n      '{' structFieldList '}'          { $$ = new IR::Type_Union(@3, *$3, $1, *$6); }\r\n    ;\r\n```\r\nbut in `p4-16/spec/grammar.mdk` as:\r\n```\r\nheaderUnionDeclaration\r\n    : optAnnotations HEADER_UNION name\r\n      '{' structFieldList '}'\r\n    ;\r\n```\r\nI'm guessing that the latter is the \"correct definition\". Is that correct?\r\n\r\nThanks."},"comment":{"url":"https://api.github.com/repos/p4lang/p4-spec/issues/comments/310645953","html_url":"https://github.com/p4lang/p4-spec/issues/286#issuecomment-310645953","issue_url":"https://api.github.com/repos/p4lang/p4-spec/issues/286","id":310645953,"user":{"login":"SmartHoneybee","id":18035422,"avatar_url":"https://avatars0.githubusercontent.com/u/18035422?v=3","gravatar_id":"","url":"https://api.github.com/users/SmartHoneybee","html_url":"https://github.com/SmartHoneybee","followers_url":"https://api.github.com/users/SmartHoneybee/followers","following_url":"https://api.github.com/users/SmartHoneybee/following{/other_user}","gists_url":"https://api.github.com/users/SmartHoneybee/gists{/gist_id}","starred_url":"https://api.github.com/users/SmartHoneybee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SmartHoneybee/subscriptions","organizations_url":"https://api.github.com/users/SmartHoneybee/orgs","repos_url":"https://api.github.com/users/SmartHoneybee/repos","events_url":"https://api.github.com/users/SmartHoneybee/events{/privacy}","received_events_url":"https://api.github.com/users/SmartHoneybee/received_events","type":"User","site_admin":false},"created_at":"2017-06-23T11:51:15Z","updated_at":"2017-06-23T11:51:15Z","body":"`entryList` in `entriesList` does not exists. (I guess this is supposed to be `entriesList` as well.)\r\n\r\nBy the way: fell free to close if you think all issues addressed here are fixed.\r\n\r\nThanks for your work."}}
{"actor":{"display_login":"SmartHoneybee"}}