{"action":"opened","number":1447,"pull_request":{"url":"https://api.github.com/repos/OpenMW/openmw/pulls/1447","id":140387875,"html_url":"https://github.com/OpenMW/openmw/pull/1447","diff_url":"https://github.com/OpenMW/openmw/pull/1447.diff","patch_url":"https://github.com/OpenMW/openmw/pull/1447.patch","issue_url":"https://api.github.com/repos/OpenMW/openmw/issues/1447","number":1447,"state":"open","locked":false,"title":"Reset attacking flag for player on reload (bug #2639)","user":{"login":"akortunov","id":26434804,"avatar_url":"https://avatars2.githubusercontent.com/u/26434804?v=4","gravatar_id":"","url":"https://api.github.com/users/akortunov","html_url":"https://github.com/akortunov","followers_url":"https://api.github.com/users/akortunov/followers","following_url":"https://api.github.com/users/akortunov/following{/other_user}","gists_url":"https://api.github.com/users/akortunov/gists{/gist_id}","starred_url":"https://api.github.com/users/akortunov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akortunov/subscriptions","organizations_url":"https://api.github.com/users/akortunov/orgs","repos_url":"https://api.github.com/users/akortunov/repos","events_url":"https://api.github.com/users/akortunov/events{/privacy}","received_events_url":"https://api.github.com/users/akortunov/received_events","type":"User","site_admin":false},"body":"Should fix [bug #2639](https://bugs.openmw.org/issues/2639), if it still exists.\r\n\r\nWhat's wrong here:\r\n1. We keep mAttackingOrSpell flag between reloads.\r\n2. With mAttackingOrSpell == true an engine treats a player as aiming.\r\n3. This can lead to unintended behaviour, such as animation bugs, accidental spellcasting, etc.\r\n\r\nSo I suggest just ensure that mAttackingOrSpell will be resetted after reload.","created_at":"2017-09-11T17:08:52Z","updated_at":"2017-09-11T17:08:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/OpenMW/openmw/pulls/1447/commits","review_comments_url":"https://api.github.com/repos/OpenMW/openmw/pulls/1447/comments","review_comment_url":"https://api.github.com/repos/OpenMW/openmw/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenMW/openmw/issues/1447/comments","statuses_url":"https://api.github.com/repos/OpenMW/openmw/statuses/30ca326bd5c66811c4f63ee1e05843a3e0580235","head":{"label":"akortunov:stancechangefixes","ref":"stancechangefixes","sha":"30ca326bd5c66811c4f63ee1e05843a3e0580235","user":{"login":"akortunov","id":26434804,"avatar_url":"https://avatars2.githubusercontent.com/u/26434804?v=4","gravatar_id":"","url":"https://api.github.com/users/akortunov","html_url":"https://github.com/akortunov","followers_url":"https://api.github.com/users/akortunov/followers","following_url":"https://api.github.com/users/akortunov/following{/other_user}","gists_url":"https://api.github.com/users/akortunov/gists{/gist_id}","starred_url":"https://api.github.com/users/akortunov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akortunov/subscriptions","organizations_url":"https://api.github.com/users/akortunov/orgs","repos_url":"https://api.github.com/users/akortunov/repos","events_url":"https://api.github.com/users/akortunov/events{/privacy}","received_events_url":"https://api.github.com/users/akortunov/received_events","type":"User","site_admin":false},"repo":{"id":85070122,"name":"openmw","full_name":"akortunov/openmw","owner":{"login":"akortunov","id":26434804,"avatar_url":"https://avatars2.githubusercontent.com/u/26434804?v=4","gravatar_id":"","url":"https://api.github.com/users/akortunov","html_url":"https://github.com/akortunov","followers_url":"https://api.github.com/users/akortunov/followers","following_url":"https://api.github.com/users/akortunov/following{/other_user}","gists_url":"https://api.github.com/users/akortunov/gists{/gist_id}","starred_url":"https://api.github.com/users/akortunov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akortunov/subscriptions","organizations_url":"https://api.github.com/users/akortunov/orgs","repos_url":"https://api.github.com/users/akortunov/repos","events_url":"https://api.github.com/users/akortunov/events{/privacy}","received_events_url":"https://api.github.com/users/akortunov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/akortunov/openmw","description":"OpenMW is an unofficial open source engine reimplementation of the game Morrowind.","fork":true,"url":"https://api.github.com/repos/akortunov/openmw","forks_url":"https://api.github.com/repos/akortunov/openmw/forks","keys_url":"https://api.github.com/repos/akortunov/openmw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akortunov/openmw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akortunov/openmw/teams","hooks_url":"https://api.github.com/repos/akortunov/openmw/hooks","issue_events_url":"https://api.github.com/repos/akortunov/openmw/issues/events{/number}","events_url":"https://api.github.com/repos/akortunov/openmw/events","assignees_url":"https://api.github.com/repos/akortunov/openmw/assignees{/user}","branches_url":"https://api.github.com/repos/akortunov/openmw/branches{/branch}","tags_url":"https://api.github.com/repos/akortunov/openmw/tags","blobs_url":"https://api.github.com/repos/akortunov/openmw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akortunov/openmw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akortunov/openmw/git/refs{/sha}","trees_url":"https://api.github.com/repos/akortunov/openmw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akortunov/openmw/statuses/{sha}","languages_url":"https://api.github.com/repos/akortunov/openmw/languages","stargazers_url":"https://api.github.com/repos/akortunov/openmw/stargazers","contributors_url":"https://api.github.com/repos/akortunov/openmw/contributors","subscribers_url":"https://api.github.com/repos/akortunov/openmw/subscribers","subscription_url":"https://api.github.com/repos/akortunov/openmw/subscription","commits_url":"https://api.github.com/repos/akortunov/openmw/commits{/sha}","git_commits_url":"https://api.github.com/repos/akortunov/openmw/git/commits{/sha}","comments_url":"https://api.github.com/repos/akortunov/openmw/comments{/number}","issue_comment_url":"https://api.github.com/repos/akortunov/openmw/issues/comments{/number}","contents_url":"https://api.github.com/repos/akortunov/openmw/contents/{+path}","compare_url":"https://api.github.com/repos/akortunov/openmw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akortunov/openmw/merges","archive_url":"https://api.github.com/repos/akortunov/openmw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akortunov/openmw/downloads","issues_url":"https://api.github.com/repos/akortunov/openmw/issues{/number}","pulls_url":"https://api.github.com/repos/akortunov/openmw/pulls{/number}","milestones_url":"https://api.github.com/repos/akortunov/openmw/milestones{/number}","notifications_url":"https://api.github.com/repos/akortunov/openmw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akortunov/openmw/labels{/name}","releases_url":"https://api.github.com/repos/akortunov/openmw/releases{/id}","deployments_url":"https://api.github.com/repos/akortunov/openmw/deployments","created_at":"2017-03-15T12:32:34Z","updated_at":"2017-03-15T12:32:41Z","pushed_at":"2017-09-11T16:49:36Z","git_url":"git://github.com/akortunov/openmw.git","ssh_url":"git@github.com:akortunov/openmw.git","clone_url":"https://github.com/akortunov/openmw.git","svn_url":"https://github.com/akortunov/openmw","homepage":"http://www.openmw.org/","size":49563,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OpenMW:master","ref":"master","sha":"bd667c3847c9879552b6c6b3d802018ff75a3738","user":{"login":"OpenMW","id":6727417,"avatar_url":"https://avatars0.githubusercontent.com/u/6727417?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenMW","html_url":"https://github.com/OpenMW","followers_url":"https://api.github.com/users/OpenMW/followers","following_url":"https://api.github.com/users/OpenMW/following{/other_user}","gists_url":"https://api.github.com/users/OpenMW/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenMW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenMW/subscriptions","organizations_url":"https://api.github.com/users/OpenMW/orgs","repos_url":"https://api.github.com/users/OpenMW/repos","events_url":"https://api.github.com/users/OpenMW/events{/privacy}","received_events_url":"https://api.github.com/users/OpenMW/received_events","type":"Organization","site_admin":false},"repo":{"id":285722,"name":"openmw","full_name":"OpenMW/openmw","owner":{"login":"OpenMW","id":6727417,"avatar_url":"https://avatars0.githubusercontent.com/u/6727417?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenMW","html_url":"https://github.com/OpenMW","followers_url":"https://api.github.com/users/OpenMW/followers","following_url":"https://api.github.com/users/OpenMW/following{/other_user}","gists_url":"https://api.github.com/users/OpenMW/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenMW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenMW/subscriptions","organizations_url":"https://api.github.com/users/OpenMW/orgs","repos_url":"https://api.github.com/users/OpenMW/repos","events_url":"https://api.github.com/users/OpenMW/events{/privacy}","received_events_url":"https://api.github.com/users/OpenMW/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenMW/openmw","description":"OpenMW is an unofficial open source engine reimplementation of the game Morrowind.","fork":false,"url":"https://api.github.com/repos/OpenMW/openmw","forks_url":"https://api.github.com/repos/OpenMW/openmw/forks","keys_url":"https://api.github.com/repos/OpenMW/openmw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenMW/openmw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenMW/openmw/teams","hooks_url":"https://api.github.com/repos/OpenMW/openmw/hooks","issue_events_url":"https://api.github.com/repos/OpenMW/openmw/issues/events{/number}","events_url":"https://api.github.com/repos/OpenMW/openmw/events","assignees_url":"https://api.github.com/repos/OpenMW/openmw/assignees{/user}","branches_url":"https://api.github.com/repos/OpenMW/openmw/branches{/branch}","tags_url":"https://api.github.com/repos/OpenMW/openmw/tags","blobs_url":"https://api.github.com/repos/OpenMW/openmw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenMW/openmw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenMW/openmw/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenMW/openmw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenMW/openmw/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenMW/openmw/languages","stargazers_url":"https://api.github.com/repos/OpenMW/openmw/stargazers","contributors_url":"https://api.github.com/repos/OpenMW/openmw/contributors","subscribers_url":"https://api.github.com/repos/OpenMW/openmw/subscribers","subscription_url":"https://api.github.com/repos/OpenMW/openmw/subscription","commits_url":"https://api.github.com/repos/OpenMW/openmw/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenMW/openmw/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenMW/openmw/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenMW/openmw/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenMW/openmw/contents/{+path}","compare_url":"https://api.github.com/repos/OpenMW/openmw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenMW/openmw/merges","archive_url":"https://api.github.com/repos/OpenMW/openmw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenMW/openmw/downloads","issues_url":"https://api.github.com/repos/OpenMW/openmw/issues{/number}","pulls_url":"https://api.github.com/repos/OpenMW/openmw/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenMW/openmw/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenMW/openmw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenMW/openmw/labels{/name}","releases_url":"https://api.github.com/repos/OpenMW/openmw/releases{/id}","deployments_url":"https://api.github.com/repos/OpenMW/openmw/deployments","created_at":"2009-08-23T14:46:21Z","updated_at":"2017-09-11T14:55:12Z","pushed_at":"2017-09-11T11:05:18Z","git_url":"git://github.com/OpenMW/openmw.git","ssh_url":"git@github.com:OpenMW/openmw.git","clone_url":"https://github.com/OpenMW/openmw.git","svn_url":"https://github.com/OpenMW/openmw","homepage":"http://www.openmw.org/","size":49581,"stargazers_count":1797,"watchers_count":1797,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":594,"mirror_url":null,"open_issues_count":18,"forks":594,"open_issues":18,"watchers":1797,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenMW/openmw/pulls/1447"},"html":{"href":"https://github.com/OpenMW/openmw/pull/1447"},"issue":{"href":"https://api.github.com/repos/OpenMW/openmw/issues/1447"},"comments":{"href":"https://api.github.com/repos/OpenMW/openmw/issues/1447/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenMW/openmw/pulls/1447/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenMW/openmw/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenMW/openmw/pulls/1447/commits"},"statuses":{"href":"https://api.github.com/repos/OpenMW/openmw/statuses/30ca326bd5c66811c4f63ee1e05843a3e0580235"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":3,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"akortunov"}}