{"action":"created","comment":{"url":"https://api.github.com/repos/wireapp/wire-webapp/pulls/comments/158065888","pull_request_review_id":84812355,"id":158065888,"diff_hunk":"@@ -41,7 +41,7 @@ z.components.DeviceCard = class DeviceCard {\n       this.data_uie_name += '-current';\n     }\n \n-    this.activated_in = ko.observable();\n+    this.activated_in = ko.observable(z.l10n.text(z.string.preferences_devices_activated_in));","path":"app/script/components/deviceCard.js","position":5,"original_position":5,"commit_id":"953b342796fe2f012f5f5b58cfdfe6d93c0a07e1","original_commit_id":"953b342796fe2f012f5f5b58cfdfe6d93c0a07e1","user":{"login":"gregor","id":10243309,"avatar_url":"https://avatars1.githubusercontent.com/u/10243309?v=4","gravatar_id":"","url":"https://api.github.com/users/gregor","html_url":"https://github.com/gregor","followers_url":"https://api.github.com/users/gregor/followers","following_url":"https://api.github.com/users/gregor/following{/other_user}","gists_url":"https://api.github.com/users/gregor/gists{/gist_id}","starred_url":"https://api.github.com/users/gregor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregor/subscriptions","organizations_url":"https://api.github.com/users/gregor/orgs","repos_url":"https://api.github.com/users/gregor/repos","events_url":"https://api.github.com/users/gregor/events{/privacy}","received_events_url":"https://api.github.com/users/gregor/received_events","type":"User","site_admin":false},"body":"Doesn't this need to be an observableArray with a default value of an array as well?","created_at":"2017-12-20T16:10:53Z","updated_at":"2017-12-20T16:13:18Z","html_url":"https://github.com/wireapp/wire-webapp/pull/2134#discussion_r158065888","pull_request_url":"https://api.github.com/repos/wireapp/wire-webapp/pulls/2134","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/wireapp/wire-webapp/pulls/comments/158065888"},"html":{"href":"https://github.com/wireapp/wire-webapp/pull/2134#discussion_r158065888"},"pull_request":{"href":"https://api.github.com/repos/wireapp/wire-webapp/pulls/2134"}}},"pull_request":{"url":"https://api.github.com/repos/wireapp/wire-webapp/pulls/2134","id":159442848,"html_url":"https://github.com/wireapp/wire-webapp/pull/2134","diff_url":"https://github.com/wireapp/wire-webapp/pull/2134.diff","patch_url":"https://github.com/wireapp/wire-webapp/pull/2134.patch","issue_url":"https://api.github.com/repos/wireapp/wire-webapp/issues/2134","number":2134,"state":"open","locked":false,"title":"refactor: Replaced Knockout html bindings","user":{"login":"bennyn","id":469989,"avatar_url":"https://avatars3.githubusercontent.com/u/469989?v=4","gravatar_id":"","url":"https://api.github.com/users/bennyn","html_url":"https://github.com/bennyn","followers_url":"https://api.github.com/users/bennyn/followers","following_url":"https://api.github.com/users/bennyn/following{/other_user}","gists_url":"https://api.github.com/users/bennyn/gists{/gist_id}","starred_url":"https://api.github.com/users/bennyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bennyn/subscriptions","organizations_url":"https://api.github.com/users/bennyn/orgs","repos_url":"https://api.github.com/users/bennyn/repos","events_url":"https://api.github.com/users/bennyn/events{/privacy}","received_events_url":"https://api.github.com/users/bennyn/received_events","type":"User","site_admin":false},"body":"## Type of change\r\n\r\n<!--- Please describe what your code improves. -->\r\n\r\n## Screenshot\r\n\r\n<!--- Please add a screenshot if it's a design change. -->\r\n\r\n<!--- Info: https://help.github.com/articles/file-attachments-on-issues-and-pull-requests/ -->\r\n","created_at":"2017-12-20T15:20:11Z","updated_at":"2017-12-20T16:13:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f4be5bbca4529674b0b4546c7a61266df9665396","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/wireapp/wire-webapp/pulls/2134/commits","review_comments_url":"https://api.github.com/repos/wireapp/wire-webapp/pulls/2134/comments","review_comment_url":"https://api.github.com/repos/wireapp/wire-webapp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wireapp/wire-webapp/issues/2134/comments","statuses_url":"https://api.github.com/repos/wireapp/wire-webapp/statuses/953b342796fe2f012f5f5b58cfdfe6d93c0a07e1","head":{"label":"wireapp:refactor-html-bindings","ref":"refactor-html-bindings","sha":"953b342796fe2f012f5f5b58cfdfe6d93c0a07e1","user":{"login":"wireapp","id":16047324,"avatar_url":"https://avatars3.githubusercontent.com/u/16047324?v=4","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"repo":{"id":63881328,"name":"wire-webapp","full_name":"wireapp/wire-webapp","owner":{"login":"wireapp","id":16047324,"avatar_url":"https://avatars3.githubusercontent.com/u/16047324?v=4","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wireapp/wire-webapp","description":"👽 Wire for web","fork":false,"url":"https://api.github.com/repos/wireapp/wire-webapp","forks_url":"https://api.github.com/repos/wireapp/wire-webapp/forks","keys_url":"https://api.github.com/repos/wireapp/wire-webapp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wireapp/wire-webapp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wireapp/wire-webapp/teams","hooks_url":"https://api.github.com/repos/wireapp/wire-webapp/hooks","issue_events_url":"https://api.github.com/repos/wireapp/wire-webapp/issues/events{/number}","events_url":"https://api.github.com/repos/wireapp/wire-webapp/events","assignees_url":"https://api.github.com/repos/wireapp/wire-webapp/assignees{/user}","branches_url":"https://api.github.com/repos/wireapp/wire-webapp/branches{/branch}","tags_url":"https://api.github.com/repos/wireapp/wire-webapp/tags","blobs_url":"https://api.github.com/repos/wireapp/wire-webapp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wireapp/wire-webapp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wireapp/wire-webapp/git/refs{/sha}","trees_url":"https://api.github.com/repos/wireapp/wire-webapp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wireapp/wire-webapp/statuses/{sha}","languages_url":"https://api.github.com/repos/wireapp/wire-webapp/languages","stargazers_url":"https://api.github.com/repos/wireapp/wire-webapp/stargazers","contributors_url":"https://api.github.com/repos/wireapp/wire-webapp/contributors","subscribers_url":"https://api.github.com/repos/wireapp/wire-webapp/subscribers","subscription_url":"https://api.github.com/repos/wireapp/wire-webapp/subscription","commits_url":"https://api.github.com/repos/wireapp/wire-webapp/commits{/sha}","git_commits_url":"https://api.github.com/repos/wireapp/wire-webapp/git/commits{/sha}","comments_url":"https://api.github.com/repos/wireapp/wire-webapp/comments{/number}","issue_comment_url":"https://api.github.com/repos/wireapp/wire-webapp/issues/comments{/number}","contents_url":"https://api.github.com/repos/wireapp/wire-webapp/contents/{+path}","compare_url":"https://api.github.com/repos/wireapp/wire-webapp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wireapp/wire-webapp/merges","archive_url":"https://api.github.com/repos/wireapp/wire-webapp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wireapp/wire-webapp/downloads","issues_url":"https://api.github.com/repos/wireapp/wire-webapp/issues{/number}","pulls_url":"https://api.github.com/repos/wireapp/wire-webapp/pulls{/number}","milestones_url":"https://api.github.com/repos/wireapp/wire-webapp/milestones{/number}","notifications_url":"https://api.github.com/repos/wireapp/wire-webapp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wireapp/wire-webapp/labels{/name}","releases_url":"https://api.github.com/repos/wireapp/wire-webapp/releases{/id}","deployments_url":"https://api.github.com/repos/wireapp/wire-webapp/deployments","created_at":"2016-07-21T15:34:05Z","updated_at":"2017-12-19T07:28:24Z","pushed_at":"2017-12-20T15:56:56Z","git_url":"git://github.com/wireapp/wire-webapp.git","ssh_url":"git@github.com:wireapp/wire-webapp.git","clone_url":"https://github.com/wireapp/wire-webapp.git","svn_url":"https://github.com/wireapp/wire-webapp","homepage":"https://app.wire.com","size":17236,"stargazers_count":752,"watchers_count":752,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":151,"mirror_url":null,"archived":false,"open_issues_count":28,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":151,"open_issues":28,"watchers":752,"default_branch":"dev"}},"base":{"label":"wireapp:dev","ref":"dev","sha":"3630cd14b4a21226895d3133cf3e9ab56582ce45","user":{"login":"wireapp","id":16047324,"avatar_url":"https://avatars3.githubusercontent.com/u/16047324?v=4","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"repo":{"id":63881328,"name":"wire-webapp","full_name":"wireapp/wire-webapp","owner":{"login":"wireapp","id":16047324,"avatar_url":"https://avatars3.githubusercontent.com/u/16047324?v=4","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wireapp/wire-webapp","description":"👽 Wire for web","fork":false,"url":"https://api.github.com/repos/wireapp/wire-webapp","forks_url":"https://api.github.com/repos/wireapp/wire-webapp/forks","keys_url":"https://api.github.com/repos/wireapp/wire-webapp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wireapp/wire-webapp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wireapp/wire-webapp/teams","hooks_url":"https://api.github.com/repos/wireapp/wire-webapp/hooks","issue_events_url":"https://api.github.com/repos/wireapp/wire-webapp/issues/events{/number}","events_url":"https://api.github.com/repos/wireapp/wire-webapp/events","assignees_url":"https://api.github.com/repos/wireapp/wire-webapp/assignees{/user}","branches_url":"https://api.github.com/repos/wireapp/wire-webapp/branches{/branch}","tags_url":"https://api.github.com/repos/wireapp/wire-webapp/tags","blobs_url":"https://api.github.com/repos/wireapp/wire-webapp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wireapp/wire-webapp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wireapp/wire-webapp/git/refs{/sha}","trees_url":"https://api.github.com/repos/wireapp/wire-webapp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wireapp/wire-webapp/statuses/{sha}","languages_url":"https://api.github.com/repos/wireapp/wire-webapp/languages","stargazers_url":"https://api.github.com/repos/wireapp/wire-webapp/stargazers","contributors_url":"https://api.github.com/repos/wireapp/wire-webapp/contributors","subscribers_url":"https://api.github.com/repos/wireapp/wire-webapp/subscribers","subscription_url":"https://api.github.com/repos/wireapp/wire-webapp/subscription","commits_url":"https://api.github.com/repos/wireapp/wire-webapp/commits{/sha}","git_commits_url":"https://api.github.com/repos/wireapp/wire-webapp/git/commits{/sha}","comments_url":"https://api.github.com/repos/wireapp/wire-webapp/comments{/number}","issue_comment_url":"https://api.github.com/repos/wireapp/wire-webapp/issues/comments{/number}","contents_url":"https://api.github.com/repos/wireapp/wire-webapp/contents/{+path}","compare_url":"https://api.github.com/repos/wireapp/wire-webapp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wireapp/wire-webapp/merges","archive_url":"https://api.github.com/repos/wireapp/wire-webapp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wireapp/wire-webapp/downloads","issues_url":"https://api.github.com/repos/wireapp/wire-webapp/issues{/number}","pulls_url":"https://api.github.com/repos/wireapp/wire-webapp/pulls{/number}","milestones_url":"https://api.github.com/repos/wireapp/wire-webapp/milestones{/number}","notifications_url":"https://api.github.com/repos/wireapp/wire-webapp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wireapp/wire-webapp/labels{/name}","releases_url":"https://api.github.com/repos/wireapp/wire-webapp/releases{/id}","deployments_url":"https://api.github.com/repos/wireapp/wire-webapp/deployments","created_at":"2016-07-21T15:34:05Z","updated_at":"2017-12-19T07:28:24Z","pushed_at":"2017-12-20T15:56:56Z","git_url":"git://github.com/wireapp/wire-webapp.git","ssh_url":"git@github.com:wireapp/wire-webapp.git","clone_url":"https://github.com/wireapp/wire-webapp.git","svn_url":"https://github.com/wireapp/wire-webapp","homepage":"https://app.wire.com","size":17236,"stargazers_count":752,"watchers_count":752,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":151,"mirror_url":null,"archived":false,"open_issues_count":28,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":151,"open_issues":28,"watchers":752,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/wireapp/wire-webapp/pulls/2134"},"html":{"href":"https://github.com/wireapp/wire-webapp/pull/2134"},"issue":{"href":"https://api.github.com/repos/wireapp/wire-webapp/issues/2134"},"comments":{"href":"https://api.github.com/repos/wireapp/wire-webapp/issues/2134/comments"},"review_comments":{"href":"https://api.github.com/repos/wireapp/wire-webapp/pulls/2134/comments"},"review_comment":{"href":"https://api.github.com/repos/wireapp/wire-webapp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wireapp/wire-webapp/pulls/2134/commits"},"statuses":{"href":"https://api.github.com/repos/wireapp/wire-webapp/statuses/953b342796fe2f012f5f5b58cfdfe6d93c0a07e1"}},"author_association":"OWNER"}}
{"actor":{"display_login":"gregor"}}