{"action":"created","issue":{"url":"https://api.github.com/repos/tensorflow/tensorboard/issues/312","repository_url":"https://api.github.com/repos/tensorflow/tensorboard","labels_url":"https://api.github.com/repos/tensorflow/tensorboard/issues/312/labels{/name}","comments_url":"https://api.github.com/repos/tensorflow/tensorboard/issues/312/comments","events_url":"https://api.github.com/repos/tensorflow/tensorboard/issues/312/events","html_url":"https://github.com/tensorflow/tensorboard/issues/312","id":247228736,"number":312,"title":"Modify TensorBoard to support plugin_data as an optional field.","user":{"login":"chihuahua","id":4221553,"avatar_url":"https://avatars0.githubusercontent.com/u/4221553?v=4","gravatar_id":"","url":"https://api.github.com/users/chihuahua","html_url":"https://github.com/chihuahua","followers_url":"https://api.github.com/users/chihuahua/followers","following_url":"https://api.github.com/users/chihuahua/following{/other_user}","gists_url":"https://api.github.com/users/chihuahua/gists{/gist_id}","starred_url":"https://api.github.com/users/chihuahua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chihuahua/subscriptions","organizations_url":"https://api.github.com/users/chihuahua/orgs","repos_url":"https://api.github.com/users/chihuahua/repos","events_url":"https://api.github.com/users/chihuahua/events{/privacy}","received_events_url":"https://api.github.com/users/chihuahua/received_events","type":"User","site_admin":false},"labels":[{"id":628354849,"url":"https://api.github.com/repos/tensorflow/tensorboard/labels/core:summaries","name":"core:summaries","color":"795548","default":false}],"state":"open","locked":false,"assignee":{"login":"chihuahua","id":4221553,"avatar_url":"https://avatars0.githubusercontent.com/u/4221553?v=4","gravatar_id":"","url":"https://api.github.com/users/chihuahua","html_url":"https://github.com/chihuahua","followers_url":"https://api.github.com/users/chihuahua/followers","following_url":"https://api.github.com/users/chihuahua/following{/other_user}","gists_url":"https://api.github.com/users/chihuahua/gists{/gist_id}","starred_url":"https://api.github.com/users/chihuahua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chihuahua/subscriptions","organizations_url":"https://api.github.com/users/chihuahua/orgs","repos_url":"https://api.github.com/users/chihuahua/repos","events_url":"https://api.github.com/users/chihuahua/events{/privacy}","received_events_url":"https://api.github.com/users/chihuahua/received_events","type":"User","site_admin":false},"assignees":[{"login":"chihuahua","id":4221553,"avatar_url":"https://avatars0.githubusercontent.com/u/4221553?v=4","gravatar_id":"","url":"https://api.github.com/users/chihuahua","html_url":"https://github.com/chihuahua","followers_url":"https://api.github.com/users/chihuahua/followers","following_url":"https://api.github.com/users/chihuahua/following{/other_user}","gists_url":"https://api.github.com/users/chihuahua/gists{/gist_id}","starred_url":"https://api.github.com/users/chihuahua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chihuahua/subscriptions","organizations_url":"https://api.github.com/users/chihuahua/orgs","repos_url":"https://api.github.com/users/chihuahua/repos","events_url":"https://api.github.com/users/chihuahua/events{/privacy}","received_events_url":"https://api.github.com/users/chihuahua/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2017-08-01T23:11:40Z","updated_at":"2017-08-03T17:47:46Z","closed_at":null,"body":"After PR https://github.com/tensorflow/tensorflow/pull/11952 goes in, the `plugin_data` field will be optional instead of repeated (for the motivation on why we made this change, see the TensorFlow PR). \r\n\r\nAfter that change enters nightly TensorFlow (and TF r1.3), we should change this line in the event accumulator to read 1 single plugin data proto.\r\nhttps://github.com/tensorflow/tensorboard/blob/da8db355b64a0954342a0af56fe6eaad2542a203/tensorboard/backend/event_processing/event_accumulator.py#L372\r\n\r\nas well as a couple of other places such as this line in a test that indexes into plugin_data:\r\nhttps://github.com/tensorflow/tensorboard/blob/cb929ed7653a3a58333c63ccaeab7a700c5448c6/tensorboard/plugins/histogram/summary_test.py#L81\r\n\r\nOther than those lines, as @jart noticed, TensorBoard will still be able to read pre-existing protobufs that contain summaries, which is nice. We should also update TensorFlow master as well as internal logic to reflect this change."},"comment":{"url":"https://api.github.com/repos/tensorflow/tensorboard/issues/comments/320041461","html_url":"https://github.com/tensorflow/tensorboard/issues/312#issuecomment-320041461","issue_url":"https://api.github.com/repos/tensorflow/tensorboard/issues/312","id":320041461,"user":{"login":"chihuahua","id":4221553,"avatar_url":"https://avatars0.githubusercontent.com/u/4221553?v=4","gravatar_id":"","url":"https://api.github.com/users/chihuahua","html_url":"https://github.com/chihuahua","followers_url":"https://api.github.com/users/chihuahua/followers","following_url":"https://api.github.com/users/chihuahua/following{/other_user}","gists_url":"https://api.github.com/users/chihuahua/gists{/gist_id}","starred_url":"https://api.github.com/users/chihuahua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chihuahua/subscriptions","organizations_url":"https://api.github.com/users/chihuahua/orgs","repos_url":"https://api.github.com/users/chihuahua/repos","events_url":"https://api.github.com/users/chihuahua/events{/privacy}","received_events_url":"https://api.github.com/users/chihuahua/received_events","type":"User","site_admin":false},"created_at":"2017-08-03T17:47:46Z","updated_at":"2017-08-03T17:47:46Z","body":"+1, tensorflow/tensorflow#12012 modifies master."}}
{"actor":{"display_login":"chihuahua"}}