{"action":"created","comment":{"url":"https://api.github.com/repos/openhab/openhab2-addons/pulls/comments/116807642","pull_request_review_id":38458563,"id":116807642,"diff_hunk":"@@ -0,0 +1,126 @@\n+/**\n+ * Copyright (c) 2010-2017 by the respective copyright holders.\n+ *\n+ * All rights reserved. This program and the accompanying materials\n+ * are made available under the terms of the Eclipse Public License v1.0\n+ * which accompanies this distribution, and is available at\n+ * http://www.eclipse.org/legal/epl-v10.html\n+ */\n+package org.openhab.binding.rfxcom.internal.messages;\n+\n+import java.util.List;\n+\n+import org.eclipse.smarthome.core.types.State;\n+import org.eclipse.smarthome.core.types.Type;\n+import org.openhab.binding.rfxcom.internal.config.RFXComBridgeConfiguration;\n+import org.openhab.binding.rfxcom.RFXComValueSelector;\n+import org.openhab.binding.rfxcom.internal.exceptions.RFXComException;\n+\n+/**\n+ * RFXCOM data class for control message.\n+ *\n+ * @author Pauli Anttila - Initial contribution\n+ */\n+public class RFXComInterfaceControlMessage extends RFXComBaseMessage {\n+\n+    private byte[] data = new byte[14];\n+\n+\n+    public RFXComInterfaceControlMessage(RFXComInterfaceMessage.TransceiverType transceiverType, RFXComBridgeConfiguration configuration) {\n+        data[0] = 0x0D;\n+        data[1] = RFXComBaseMessage.PacketType.INTERFACE_CONTROL.toByte();\n+        data[2] = 0;\n+        data[3] = 2;\n+        data[4] = RFXComInterfaceMessage.Commands.SET_MODE.toByte();\n+        data[5] = transceiverType.toByte();\n+        data[6] = 0;","path":"addons/binding/org.openhab.binding.rfxcom/src/main/java/org/openhab/binding/rfxcom/internal/messages/RFXComInterfaceControlMessage.java","position":null,"original_position":36,"commit_id":"84074cbbf10300c3f8186b49136602a0415fac3e","original_commit_id":"bb5166bab6158fa3aef1ea35b95224af91d326eb","user":{"login":"mjagdis","id":856286,"avatar_url":"https://avatars0.githubusercontent.com/u/856286?v=3","gravatar_id":"","url":"https://api.github.com/users/mjagdis","html_url":"https://github.com/mjagdis","followers_url":"https://api.github.com/users/mjagdis/followers","following_url":"https://api.github.com/users/mjagdis/following{/other_user}","gists_url":"https://api.github.com/users/mjagdis/gists{/gist_id}","starred_url":"https://api.github.com/users/mjagdis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjagdis/subscriptions","organizations_url":"https://api.github.com/users/mjagdis/orgs","repos_url":"https://api.github.com/users/mjagdis/repos","events_url":"https://api.github.com/users/mjagdis/events{/privacy}","received_events_url":"https://api.github.com/users/mjagdis/received_events","type":"User","site_admin":false},"body":"In RF it is *never* right to blindly default to max power. That simply increases the noise floor over the widest possible area for no reason. Let's put a stake in the ground. I've added xmit power as a config option so it can be increased if necessary. Most hex mode strings floating around the net seem to set 0 anyway. I can't remember ever seeing one with a non-zero value, never mind anyone actually mentioning that setting xmit power was an option.","created_at":"2017-05-16T17:33:34Z","updated_at":"2017-05-16T17:33:34Z","html_url":"https://github.com/openhab/openhab2-addons/pull/2127#discussion_r116807642","pull_request_url":"https://api.github.com/repos/openhab/openhab2-addons/pulls/2127","_links":{"self":{"href":"https://api.github.com/repos/openhab/openhab2-addons/pulls/comments/116807642"},"html":{"href":"https://github.com/openhab/openhab2-addons/pull/2127#discussion_r116807642"},"pull_request":{"href":"https://api.github.com/repos/openhab/openhab2-addons/pulls/2127"}}},"pull_request":{"url":"https://api.github.com/repos/openhab/openhab2-addons/pulls/2127","id":114423415,"html_url":"https://github.com/openhab/openhab2-addons/pull/2127","diff_url":"https://github.com/openhab/openhab2-addons/pull/2127.diff","patch_url":"https://github.com/openhab/openhab2-addons/pull/2127.patch","issue_url":"https://api.github.com/repos/openhab/openhab2-addons/issues/2127","number":2127,"state":"open","locked":false,"title":"[RFXCOM] fix mode setting","user":{"login":"mjagdis","id":856286,"avatar_url":"https://avatars0.githubusercontent.com/u/856286?v=3","gravatar_id":"","url":"https://api.github.com/users/mjagdis","html_url":"https://github.com/mjagdis","followers_url":"https://api.github.com/users/mjagdis/followers","following_url":"https://api.github.com/users/mjagdis/following{/other_user}","gists_url":"https://api.github.com/users/mjagdis/gists{/gist_id}","starred_url":"https://api.github.com/users/mjagdis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjagdis/subscriptions","organizations_url":"https://api.github.com/users/mjagdis/orgs","repos_url":"https://api.github.com/users/mjagdis/repos","events_url":"https://api.github.com/users/mjagdis/events{/privacy}","received_events_url":"https://api.github.com/users/mjagdis/received_events","type":"User","site_admin":false},"body":"Send the right packet type for SET_MODE. Use the transceiver type we get from GET_STATUS in the SET_MODE request. Only put the bridge online once the RFXCOM has acknowledged our START_RECEIVER request.\r\n\r\nCloses #2125\r\n\r\nSigned-off-by: Mike Jagdis mjagdis@eris-associates.co.uk (github: mjagdis)","created_at":"2017-04-05T16:50:07Z","updated_at":"2017-05-16T17:33:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d6a211f800f26346ca6f6b7caf4c7596c0fa999b","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/openhab/openhab2-addons/pulls/2127/commits","review_comments_url":"https://api.github.com/repos/openhab/openhab2-addons/pulls/2127/comments","review_comment_url":"https://api.github.com/repos/openhab/openhab2-addons/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openhab/openhab2-addons/issues/2127/comments","statuses_url":"https://api.github.com/repos/openhab/openhab2-addons/statuses/84074cbbf10300c3f8186b49136602a0415fac3e","head":{"label":"mjagdis:2125-rfxcom-modes","ref":"2125-rfxcom-modes","sha":"84074cbbf10300c3f8186b49136602a0415fac3e","user":{"login":"mjagdis","id":856286,"avatar_url":"https://avatars0.githubusercontent.com/u/856286?v=3","gravatar_id":"","url":"https://api.github.com/users/mjagdis","html_url":"https://github.com/mjagdis","followers_url":"https://api.github.com/users/mjagdis/followers","following_url":"https://api.github.com/users/mjagdis/following{/other_user}","gists_url":"https://api.github.com/users/mjagdis/gists{/gist_id}","starred_url":"https://api.github.com/users/mjagdis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjagdis/subscriptions","organizations_url":"https://api.github.com/users/mjagdis/orgs","repos_url":"https://api.github.com/users/mjagdis/repos","events_url":"https://api.github.com/users/mjagdis/events{/privacy}","received_events_url":"https://api.github.com/users/mjagdis/received_events","type":"User","site_admin":false},"repo":{"id":86806383,"name":"openhab2-addons","full_name":"mjagdis/openhab2-addons","owner":{"login":"mjagdis","id":856286,"avatar_url":"https://avatars0.githubusercontent.com/u/856286?v=3","gravatar_id":"","url":"https://api.github.com/users/mjagdis","html_url":"https://github.com/mjagdis","followers_url":"https://api.github.com/users/mjagdis/followers","following_url":"https://api.github.com/users/mjagdis/following{/other_user}","gists_url":"https://api.github.com/users/mjagdis/gists{/gist_id}","starred_url":"https://api.github.com/users/mjagdis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjagdis/subscriptions","organizations_url":"https://api.github.com/users/mjagdis/orgs","repos_url":"https://api.github.com/users/mjagdis/repos","events_url":"https://api.github.com/users/mjagdis/events{/privacy}","received_events_url":"https://api.github.com/users/mjagdis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mjagdis/openhab2-addons","description":"Add-ons for openHAB 2.x","fork":true,"url":"https://api.github.com/repos/mjagdis/openhab2-addons","forks_url":"https://api.github.com/repos/mjagdis/openhab2-addons/forks","keys_url":"https://api.github.com/repos/mjagdis/openhab2-addons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mjagdis/openhab2-addons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mjagdis/openhab2-addons/teams","hooks_url":"https://api.github.com/repos/mjagdis/openhab2-addons/hooks","issue_events_url":"https://api.github.com/repos/mjagdis/openhab2-addons/issues/events{/number}","events_url":"https://api.github.com/repos/mjagdis/openhab2-addons/events","assignees_url":"https://api.github.com/repos/mjagdis/openhab2-addons/assignees{/user}","branches_url":"https://api.github.com/repos/mjagdis/openhab2-addons/branches{/branch}","tags_url":"https://api.github.com/repos/mjagdis/openhab2-addons/tags","blobs_url":"https://api.github.com/repos/mjagdis/openhab2-addons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mjagdis/openhab2-addons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mjagdis/openhab2-addons/git/refs{/sha}","trees_url":"https://api.github.com/repos/mjagdis/openhab2-addons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mjagdis/openhab2-addons/statuses/{sha}","languages_url":"https://api.github.com/repos/mjagdis/openhab2-addons/languages","stargazers_url":"https://api.github.com/repos/mjagdis/openhab2-addons/stargazers","contributors_url":"https://api.github.com/repos/mjagdis/openhab2-addons/contributors","subscribers_url":"https://api.github.com/repos/mjagdis/openhab2-addons/subscribers","subscription_url":"https://api.github.com/repos/mjagdis/openhab2-addons/subscription","commits_url":"https://api.github.com/repos/mjagdis/openhab2-addons/commits{/sha}","git_commits_url":"https://api.github.com/repos/mjagdis/openhab2-addons/git/commits{/sha}","comments_url":"https://api.github.com/repos/mjagdis/openhab2-addons/comments{/number}","issue_comment_url":"https://api.github.com/repos/mjagdis/openhab2-addons/issues/comments{/number}","contents_url":"https://api.github.com/repos/mjagdis/openhab2-addons/contents/{+path}","compare_url":"https://api.github.com/repos/mjagdis/openhab2-addons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mjagdis/openhab2-addons/merges","archive_url":"https://api.github.com/repos/mjagdis/openhab2-addons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mjagdis/openhab2-addons/downloads","issues_url":"https://api.github.com/repos/mjagdis/openhab2-addons/issues{/number}","pulls_url":"https://api.github.com/repos/mjagdis/openhab2-addons/pulls{/number}","milestones_url":"https://api.github.com/repos/mjagdis/openhab2-addons/milestones{/number}","notifications_url":"https://api.github.com/repos/mjagdis/openhab2-addons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mjagdis/openhab2-addons/labels{/name}","releases_url":"https://api.github.com/repos/mjagdis/openhab2-addons/releases{/id}","deployments_url":"https://api.github.com/repos/mjagdis/openhab2-addons/deployments","created_at":"2017-03-31T10:13:39Z","updated_at":"2017-03-31T10:13:46Z","pushed_at":"2017-05-16T17:25:45Z","git_url":"git://github.com/mjagdis/openhab2-addons.git","ssh_url":"git@github.com:mjagdis/openhab2-addons.git","clone_url":"https://github.com/mjagdis/openhab2-addons.git","svn_url":"https://github.com/mjagdis/openhab2-addons","homepage":"","size":78205,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openhab:master","ref":"master","sha":"974f83fa275c8b01c019e410db7498fac141d9e7","user":{"login":"openhab","id":1007353,"avatar_url":"https://avatars3.githubusercontent.com/u/1007353?v=3","gravatar_id":"","url":"https://api.github.com/users/openhab","html_url":"https://github.com/openhab","followers_url":"https://api.github.com/users/openhab/followers","following_url":"https://api.github.com/users/openhab/following{/other_user}","gists_url":"https://api.github.com/users/openhab/gists{/gist_id}","starred_url":"https://api.github.com/users/openhab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openhab/subscriptions","organizations_url":"https://api.github.com/users/openhab/orgs","repos_url":"https://api.github.com/users/openhab/repos","events_url":"https://api.github.com/users/openhab/events{/privacy}","received_events_url":"https://api.github.com/users/openhab/received_events","type":"Organization","site_admin":false},"repo":{"id":19753195,"name":"openhab2-addons","full_name":"openhab/openhab2-addons","owner":{"login":"openhab","id":1007353,"avatar_url":"https://avatars3.githubusercontent.com/u/1007353?v=3","gravatar_id":"","url":"https://api.github.com/users/openhab","html_url":"https://github.com/openhab","followers_url":"https://api.github.com/users/openhab/followers","following_url":"https://api.github.com/users/openhab/following{/other_user}","gists_url":"https://api.github.com/users/openhab/gists{/gist_id}","starred_url":"https://api.github.com/users/openhab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openhab/subscriptions","organizations_url":"https://api.github.com/users/openhab/orgs","repos_url":"https://api.github.com/users/openhab/repos","events_url":"https://api.github.com/users/openhab/events{/privacy}","received_events_url":"https://api.github.com/users/openhab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openhab/openhab2-addons","description":"Add-ons for openHAB 2.x","fork":false,"url":"https://api.github.com/repos/openhab/openhab2-addons","forks_url":"https://api.github.com/repos/openhab/openhab2-addons/forks","keys_url":"https://api.github.com/repos/openhab/openhab2-addons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openhab/openhab2-addons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openhab/openhab2-addons/teams","hooks_url":"https://api.github.com/repos/openhab/openhab2-addons/hooks","issue_events_url":"https://api.github.com/repos/openhab/openhab2-addons/issues/events{/number}","events_url":"https://api.github.com/repos/openhab/openhab2-addons/events","assignees_url":"https://api.github.com/repos/openhab/openhab2-addons/assignees{/user}","branches_url":"https://api.github.com/repos/openhab/openhab2-addons/branches{/branch}","tags_url":"https://api.github.com/repos/openhab/openhab2-addons/tags","blobs_url":"https://api.github.com/repos/openhab/openhab2-addons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openhab/openhab2-addons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openhab/openhab2-addons/git/refs{/sha}","trees_url":"https://api.github.com/repos/openhab/openhab2-addons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openhab/openhab2-addons/statuses/{sha}","languages_url":"https://api.github.com/repos/openhab/openhab2-addons/languages","stargazers_url":"https://api.github.com/repos/openhab/openhab2-addons/stargazers","contributors_url":"https://api.github.com/repos/openhab/openhab2-addons/contributors","subscribers_url":"https://api.github.com/repos/openhab/openhab2-addons/subscribers","subscription_url":"https://api.github.com/repos/openhab/openhab2-addons/subscription","commits_url":"https://api.github.com/repos/openhab/openhab2-addons/commits{/sha}","git_commits_url":"https://api.github.com/repos/openhab/openhab2-addons/git/commits{/sha}","comments_url":"https://api.github.com/repos/openhab/openhab2-addons/comments{/number}","issue_comment_url":"https://api.github.com/repos/openhab/openhab2-addons/issues/comments{/number}","contents_url":"https://api.github.com/repos/openhab/openhab2-addons/contents/{+path}","compare_url":"https://api.github.com/repos/openhab/openhab2-addons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openhab/openhab2-addons/merges","archive_url":"https://api.github.com/repos/openhab/openhab2-addons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openhab/openhab2-addons/downloads","issues_url":"https://api.github.com/repos/openhab/openhab2-addons/issues{/number}","pulls_url":"https://api.github.com/repos/openhab/openhab2-addons/pulls{/number}","milestones_url":"https://api.github.com/repos/openhab/openhab2-addons/milestones{/number}","notifications_url":"https://api.github.com/repos/openhab/openhab2-addons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openhab/openhab2-addons/labels{/name}","releases_url":"https://api.github.com/repos/openhab/openhab2-addons/releases{/id}","deployments_url":"https://api.github.com/repos/openhab/openhab2-addons/deployments","created_at":"2014-05-13T19:41:58Z","updated_at":"2017-05-16T03:50:43Z","pushed_at":"2017-05-16T17:32:32Z","git_url":"git://github.com/openhab/openhab2-addons.git","ssh_url":"git@github.com:openhab/openhab2-addons.git","clone_url":"https://github.com/openhab/openhab2-addons.git","svn_url":"https://github.com/openhab/openhab2-addons","homepage":"","size":252981,"stargazers_count":579,"watchers_count":579,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":979,"mirror_url":null,"open_issues_count":322,"forks":979,"open_issues":322,"watchers":579,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openhab/openhab2-addons/pulls/2127"},"html":{"href":"https://github.com/openhab/openhab2-addons/pull/2127"},"issue":{"href":"https://api.github.com/repos/openhab/openhab2-addons/issues/2127"},"comments":{"href":"https://api.github.com/repos/openhab/openhab2-addons/issues/2127/comments"},"review_comments":{"href":"https://api.github.com/repos/openhab/openhab2-addons/pulls/2127/comments"},"review_comment":{"href":"https://api.github.com/repos/openhab/openhab2-addons/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openhab/openhab2-addons/pulls/2127/commits"},"statuses":{"href":"https://api.github.com/repos/openhab/openhab2-addons/statuses/84074cbbf10300c3f8186b49136602a0415fac3e"}}}}
{"actor":{"display_login":"mjagdis"}}