{"action":"closed","number":81,"pull_request":{"url":"https://api.github.com/repos/MartijnHols/WoWAnalyzer/pulls/81","id":125248406,"html_url":"https://github.com/MartijnHols/WoWAnalyzer/pull/81","diff_url":"https://github.com/MartijnHols/WoWAnalyzer/pull/81.diff","patch_url":"https://github.com/MartijnHols/WoWAnalyzer/pull/81.patch","issue_url":"https://api.github.com/repos/MartijnHols/WoWAnalyzer/issues/81","number":81,"state":"closed","locked":false,"title":"7.2.5 Discipline","user":{"login":"rp4rk","id":8212881,"avatar_url":"https://avatars0.githubusercontent.com/u/8212881?v=3","gravatar_id":"","url":"https://api.github.com/users/rp4rk","html_url":"https://github.com/rp4rk","followers_url":"https://api.github.com/users/rp4rk/followers","following_url":"https://api.github.com/users/rp4rk/following{/other_user}","gists_url":"https://api.github.com/users/rp4rk/gists{/gist_id}","starred_url":"https://api.github.com/users/rp4rk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rp4rk/subscriptions","organizations_url":"https://api.github.com/users/rp4rk/orgs","repos_url":"https://api.github.com/users/rp4rk/repos","events_url":"https://api.github.com/users/rp4rk/events{/privacy}","received_events_url":"https://api.github.com/users/rp4rk/received_events","type":"User","site_admin":false},"body":"This PR includes solutions for the majority of the compatibility changes noted [here](https://github.com/MartijnHols/WoWAnalyzer/issues/58#issuecomment-307476285).\r\n\r\n## Main Changes\r\n* Removed all references to contrition, but left the duration methods in the event of another Atonement duration buff.\r\n* Added support for the new legendary, Soul of the High Priest.\r\n* Added basic support for Power Word: Radiance CPM.\r\n* Added in depth support for Evangelism analysis.\r\n* Atonement tracking now also tracks the previous atonement applicator that was cast.\r\n* Atonement duration is now dependent on the applicator it came from.\r\n\r\nThis PR will put Discipline in a working state for 7.2.5.\r\n\r\n## Also Features\r\nExpandable statistic box, looks ugly at the moment but can be improved fairly easily with more time:\r\n\r\n\r\n![before](https://user-images.githubusercontent.com/8212881/27059013-42b641f2-4fcc-11e7-8e27-57050bc841c8.png)\r\n![after](https://user-images.githubusercontent.com/8212881/27059014-42b69a12-4fcc-11e7-8b3d-9e7b70ee0a4d.png)\r\n","created_at":"2017-06-12T23:07:25Z","updated_at":"2017-06-13T21:54:56Z","closed_at":"2017-06-13T21:54:56Z","merged_at":"2017-06-13T21:54:56Z","merge_commit_sha":"84218762f82b3d782e58ce424b4c527dbaae2268","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/MartijnHols/WoWAnalyzer/pulls/81/commits","review_comments_url":"https://api.github.com/repos/MartijnHols/WoWAnalyzer/pulls/81/comments","review_comment_url":"https://api.github.com/repos/MartijnHols/WoWAnalyzer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MartijnHols/WoWAnalyzer/issues/81/comments","statuses_url":"https://api.github.com/repos/MartijnHols/WoWAnalyzer/statuses/851cac72a5c33e9eed5e5800c77bac40d6e0a53f","head":{"label":"rp4rk:feature/discipline-7.2.5","ref":"feature/discipline-7.2.5","sha":"851cac72a5c33e9eed5e5800c77bac40d6e0a53f","user":{"login":"rp4rk","id":8212881,"avatar_url":"https://avatars0.githubusercontent.com/u/8212881?v=3","gravatar_id":"","url":"https://api.github.com/users/rp4rk","html_url":"https://github.com/rp4rk","followers_url":"https://api.github.com/users/rp4rk/followers","following_url":"https://api.github.com/users/rp4rk/following{/other_user}","gists_url":"https://api.github.com/users/rp4rk/gists{/gist_id}","starred_url":"https://api.github.com/users/rp4rk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rp4rk/subscriptions","organizations_url":"https://api.github.com/users/rp4rk/orgs","repos_url":"https://api.github.com/users/rp4rk/repos","events_url":"https://api.github.com/users/rp4rk/events{/privacy}","received_events_url":"https://api.github.com/users/rp4rk/received_events","type":"User","site_admin":false},"repo":{"id":93247555,"name":"WoWAnalyzer","full_name":"rp4rk/WoWAnalyzer","owner":{"login":"rp4rk","id":8212881,"avatar_url":"https://avatars0.githubusercontent.com/u/8212881?v=3","gravatar_id":"","url":"https://api.github.com/users/rp4rk","html_url":"https://github.com/rp4rk","followers_url":"https://api.github.com/users/rp4rk/followers","following_url":"https://api.github.com/users/rp4rk/following{/other_user}","gists_url":"https://api.github.com/users/rp4rk/gists{/gist_id}","starred_url":"https://api.github.com/users/rp4rk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rp4rk/subscriptions","organizations_url":"https://api.github.com/users/rp4rk/orgs","repos_url":"https://api.github.com/users/rp4rk/repos","events_url":"https://api.github.com/users/rp4rk/events{/privacy}","received_events_url":"https://api.github.com/users/rp4rk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rp4rk/WoWAnalyzer","description":"A WCL log analyzer.","fork":true,"url":"https://api.github.com/repos/rp4rk/WoWAnalyzer","forks_url":"https://api.github.com/repos/rp4rk/WoWAnalyzer/forks","keys_url":"https://api.github.com/repos/rp4rk/WoWAnalyzer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rp4rk/WoWAnalyzer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rp4rk/WoWAnalyzer/teams","hooks_url":"https://api.github.com/repos/rp4rk/WoWAnalyzer/hooks","issue_events_url":"https://api.github.com/repos/rp4rk/WoWAnalyzer/issues/events{/number}","events_url":"https://api.github.com/repos/rp4rk/WoWAnalyzer/events","assignees_url":"https://api.github.com/repos/rp4rk/WoWAnalyzer/assignees{/user}","branches_url":"https://api.github.com/repos/rp4rk/WoWAnalyzer/branches{/branch}","tags_url":"https://api.github.com/repos/rp4rk/WoWAnalyzer/tags","blobs_url":"https://api.github.com/repos/rp4rk/WoWAnalyzer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rp4rk/WoWAnalyzer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rp4rk/WoWAnalyzer/git/refs{/sha}","trees_url":"https://api.github.com/repos/rp4rk/WoWAnalyzer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rp4rk/WoWAnalyzer/statuses/{sha}","languages_url":"https://api.github.com/repos/rp4rk/WoWAnalyzer/languages","stargazers_url":"https://api.github.com/repos/rp4rk/WoWAnalyzer/stargazers","contributors_url":"https://api.github.com/repos/rp4rk/WoWAnalyzer/contributors","subscribers_url":"https://api.github.com/repos/rp4rk/WoWAnalyzer/subscribers","subscription_url":"https://api.github.com/repos/rp4rk/WoWAnalyzer/subscription","commits_url":"https://api.github.com/repos/rp4rk/WoWAnalyzer/commits{/sha}","git_commits_url":"https://api.github.com/repos/rp4rk/WoWAnalyzer/git/commits{/sha}","comments_url":"https://api.github.com/repos/rp4rk/WoWAnalyzer/comments{/number}","issue_comment_url":"https://api.github.com/repos/rp4rk/WoWAnalyzer/issues/comments{/number}","contents_url":"https://api.github.com/repos/rp4rk/WoWAnalyzer/contents/{+path}","compare_url":"https://api.github.com/repos/rp4rk/WoWAnalyzer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rp4rk/WoWAnalyzer/merges","archive_url":"https://api.github.com/repos/rp4rk/WoWAnalyzer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rp4rk/WoWAnalyzer/downloads","issues_url":"https://api.github.com/repos/rp4rk/WoWAnalyzer/issues{/number}","pulls_url":"https://api.github.com/repos/rp4rk/WoWAnalyzer/pulls{/number}","milestones_url":"https://api.github.com/repos/rp4rk/WoWAnalyzer/milestones{/number}","notifications_url":"https://api.github.com/repos/rp4rk/WoWAnalyzer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rp4rk/WoWAnalyzer/labels{/name}","releases_url":"https://api.github.com/repos/rp4rk/WoWAnalyzer/releases{/id}","deployments_url":"https://api.github.com/repos/rp4rk/WoWAnalyzer/deployments","created_at":"2017-06-03T12:44:32Z","updated_at":"2017-06-03T12:44:34Z","pushed_at":"2017-06-13T19:02:47Z","git_url":"git://github.com/rp4rk/WoWAnalyzer.git","ssh_url":"git@github.com:rp4rk/WoWAnalyzer.git","clone_url":"https://github.com/rp4rk/WoWAnalyzer.git","svn_url":"https://github.com/rp4rk/WoWAnalyzer","homepage":"http://wowanalyzer.com/","size":31205,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"MartijnHols:master","ref":"master","sha":"e9147cee245e2ae77c63008138fdea4e010367ba","user":{"login":"MartijnHols","id":4565223,"avatar_url":"https://avatars2.githubusercontent.com/u/4565223?v=3","gravatar_id":"","url":"https://api.github.com/users/MartijnHols","html_url":"https://github.com/MartijnHols","followers_url":"https://api.github.com/users/MartijnHols/followers","following_url":"https://api.github.com/users/MartijnHols/following{/other_user}","gists_url":"https://api.github.com/users/MartijnHols/gists{/gist_id}","starred_url":"https://api.github.com/users/MartijnHols/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MartijnHols/subscriptions","organizations_url":"https://api.github.com/users/MartijnHols/orgs","repos_url":"https://api.github.com/users/MartijnHols/repos","events_url":"https://api.github.com/users/MartijnHols/events{/privacy}","received_events_url":"https://api.github.com/users/MartijnHols/received_events","type":"User","site_admin":false},"repo":{"id":80472692,"name":"WoWAnalyzer","full_name":"MartijnHols/WoWAnalyzer","owner":{"login":"MartijnHols","id":4565223,"avatar_url":"https://avatars2.githubusercontent.com/u/4565223?v=3","gravatar_id":"","url":"https://api.github.com/users/MartijnHols","html_url":"https://github.com/MartijnHols","followers_url":"https://api.github.com/users/MartijnHols/followers","following_url":"https://api.github.com/users/MartijnHols/following{/other_user}","gists_url":"https://api.github.com/users/MartijnHols/gists{/gist_id}","starred_url":"https://api.github.com/users/MartijnHols/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MartijnHols/subscriptions","organizations_url":"https://api.github.com/users/MartijnHols/orgs","repos_url":"https://api.github.com/users/MartijnHols/repos","events_url":"https://api.github.com/users/MartijnHols/events{/privacy}","received_events_url":"https://api.github.com/users/MartijnHols/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MartijnHols/WoWAnalyzer","description":"A WCL log analyzer.","fork":false,"url":"https://api.github.com/repos/MartijnHols/WoWAnalyzer","forks_url":"https://api.github.com/repos/MartijnHols/WoWAnalyzer/forks","keys_url":"https://api.github.com/repos/MartijnHols/WoWAnalyzer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MartijnHols/WoWAnalyzer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MartijnHols/WoWAnalyzer/teams","hooks_url":"https://api.github.com/repos/MartijnHols/WoWAnalyzer/hooks","issue_events_url":"https://api.github.com/repos/MartijnHols/WoWAnalyzer/issues/events{/number}","events_url":"https://api.github.com/repos/MartijnHols/WoWAnalyzer/events","assignees_url":"https://api.github.com/repos/MartijnHols/WoWAnalyzer/assignees{/user}","branches_url":"https://api.github.com/repos/MartijnHols/WoWAnalyzer/branches{/branch}","tags_url":"https://api.github.com/repos/MartijnHols/WoWAnalyzer/tags","blobs_url":"https://api.github.com/repos/MartijnHols/WoWAnalyzer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MartijnHols/WoWAnalyzer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MartijnHols/WoWAnalyzer/git/refs{/sha}","trees_url":"https://api.github.com/repos/MartijnHols/WoWAnalyzer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MartijnHols/WoWAnalyzer/statuses/{sha}","languages_url":"https://api.github.com/repos/MartijnHols/WoWAnalyzer/languages","stargazers_url":"https://api.github.com/repos/MartijnHols/WoWAnalyzer/stargazers","contributors_url":"https://api.github.com/repos/MartijnHols/WoWAnalyzer/contributors","subscribers_url":"https://api.github.com/repos/MartijnHols/WoWAnalyzer/subscribers","subscription_url":"https://api.github.com/repos/MartijnHols/WoWAnalyzer/subscription","commits_url":"https://api.github.com/repos/MartijnHols/WoWAnalyzer/commits{/sha}","git_commits_url":"https://api.github.com/repos/MartijnHols/WoWAnalyzer/git/commits{/sha}","comments_url":"https://api.github.com/repos/MartijnHols/WoWAnalyzer/comments{/number}","issue_comment_url":"https://api.github.com/repos/MartijnHols/WoWAnalyzer/issues/comments{/number}","contents_url":"https://api.github.com/repos/MartijnHols/WoWAnalyzer/contents/{+path}","compare_url":"https://api.github.com/repos/MartijnHols/WoWAnalyzer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MartijnHols/WoWAnalyzer/merges","archive_url":"https://api.github.com/repos/MartijnHols/WoWAnalyzer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MartijnHols/WoWAnalyzer/downloads","issues_url":"https://api.github.com/repos/MartijnHols/WoWAnalyzer/issues{/number}","pulls_url":"https://api.github.com/repos/MartijnHols/WoWAnalyzer/pulls{/number}","milestones_url":"https://api.github.com/repos/MartijnHols/WoWAnalyzer/milestones{/number}","notifications_url":"https://api.github.com/repos/MartijnHols/WoWAnalyzer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MartijnHols/WoWAnalyzer/labels{/name}","releases_url":"https://api.github.com/repos/MartijnHols/WoWAnalyzer/releases{/id}","deployments_url":"https://api.github.com/repos/MartijnHols/WoWAnalyzer/deployments","created_at":"2017-01-30T23:02:17Z","updated_at":"2017-06-10T02:58:58Z","pushed_at":"2017-06-13T21:54:56Z","git_url":"git://github.com/MartijnHols/WoWAnalyzer.git","ssh_url":"git@github.com:MartijnHols/WoWAnalyzer.git","clone_url":"https://github.com/MartijnHols/WoWAnalyzer.git","svn_url":"https://github.com/MartijnHols/WoWAnalyzer","homepage":"http://wowanalyzer.com/","size":31192,"stargazers_count":21,"watchers_count":21,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":18,"mirror_url":null,"open_issues_count":22,"forks":18,"open_issues":22,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MartijnHols/WoWAnalyzer/pulls/81"},"html":{"href":"https://github.com/MartijnHols/WoWAnalyzer/pull/81"},"issue":{"href":"https://api.github.com/repos/MartijnHols/WoWAnalyzer/issues/81"},"comments":{"href":"https://api.github.com/repos/MartijnHols/WoWAnalyzer/issues/81/comments"},"review_comments":{"href":"https://api.github.com/repos/MartijnHols/WoWAnalyzer/pulls/81/comments"},"review_comment":{"href":"https://api.github.com/repos/MartijnHols/WoWAnalyzer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MartijnHols/WoWAnalyzer/pulls/81/commits"},"statuses":{"href":"https://api.github.com/repos/MartijnHols/WoWAnalyzer/statuses/851cac72a5c33e9eed5e5800c77bac40d6e0a53f"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"MartijnHols","id":4565223,"avatar_url":"https://avatars2.githubusercontent.com/u/4565223?v=3","gravatar_id":"","url":"https://api.github.com/users/MartijnHols","html_url":"https://github.com/MartijnHols","followers_url":"https://api.github.com/users/MartijnHols/followers","following_url":"https://api.github.com/users/MartijnHols/following{/other_user}","gists_url":"https://api.github.com/users/MartijnHols/gists{/gist_id}","starred_url":"https://api.github.com/users/MartijnHols/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MartijnHols/subscriptions","organizations_url":"https://api.github.com/users/MartijnHols/orgs","repos_url":"https://api.github.com/users/MartijnHols/repos","events_url":"https://api.github.com/users/MartijnHols/events{/privacy}","received_events_url":"https://api.github.com/users/MartijnHols/received_events","type":"User","site_admin":false},"comments":0,"review_comments":4,"maintainer_can_modify":false,"commits":12,"additions":500,"deletions":88,"changed_files":20}}
{"actor":{"display_login":"MartijnHols"}}