{"action":"closed","number":25,"pull_request":{"url":"https://api.github.com/repos/rollerworks/RollerworksSearchBundle/pulls/25","id":107957249,"html_url":"https://github.com/rollerworks/RollerworksSearchBundle/pull/25","diff_url":"https://github.com/rollerworks/RollerworksSearchBundle/pull/25.diff","patch_url":"https://github.com/rollerworks/RollerworksSearchBundle/pull/25.patch","issue_url":"https://api.github.com/repos/rollerworks/RollerworksSearchBundle/issues/25","number":25,"state":"closed","locked":false,"title":"Update API for RollerworksSearch v2.0","user":{"login":"sstok","id":904790,"avatar_url":"https://avatars.githubusercontent.com/u/904790?v=3","gravatar_id":"","url":"https://api.github.com/users/sstok","html_url":"https://github.com/sstok","followers_url":"https://api.github.com/users/sstok/followers","following_url":"https://api.github.com/users/sstok/following{/other_user}","gists_url":"https://api.github.com/users/sstok/gists{/gist_id}","starred_url":"https://api.github.com/users/sstok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sstok/subscriptions","organizations_url":"https://api.github.com/users/sstok/orgs","repos_url":"https://api.github.com/users/sstok/repos","events_url":"https://api.github.com/users/sstok/events{/privacy}","received_events_url":"https://api.github.com/users/sstok/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Bug fix?      | no\r\n| New feature?  | yes\r\n| BC breaks?    | yes\r\n| Deprecations? | no\r\n| Tests pass?   | yes\r\n| Fixed tickets | \r\n| License       | MIT\r\n\r\nThis pull-request contains a combined commit of all the changes required to make this bundle work with RollerworksSearch 2.0, plus some additional improvements to make sharing code with the core component easier.\r\n\r\nThe `rollerworks/search-symfony-di` is no longer used and all contents have moved here, the old library is hereby deprecated.\r\n\r\n## Removed\r\n- Removed the Metadata system, use the new FieldSet configurator system instead.\r\n  FieldSetConfigurator can be registered as services\r\n- Remove registering of loose SearchExtension's, only types and type-extensions will now be registered. This change was needed to improve lazy loading.\r\n- Support for Symfony 2 was dropped, at least Symfony 3.3 is now required (not released at this moment) [1]\r\n- The SearchForm type has been removed, as this is incompatible with the new SearchProcessor and will actually hurt performance when used this way. Instead I have some idea's for a new Form based processor (with limited functionality) that will replace this old functionality in the future (_it will not replace the SearchProcessor_).\r\n\r\n## Changes\r\n- The SearchProcessor has moved to it's own component [rollerworks/search-processor](https://github.com/rollerworks/search-processor) and now requires PSR-7 to be installed. Note: The processor is optional, it's automatically enabled when possible\r\n- Types and Type extensions can now be registered as private services (highly recommended)\r\n- Translations are no longer mirrored, but are properly registered with the Translator paths\r\n\r\n## Lazy loading and automatic enabling\r\n\r\nFollowing the Symfony Flex approach, the integration bundle no longer requires/loads everything.\r\nInstead optional functionality is automatically enabled when it's detected to be installed, else the bundle will function as normal.\r\n\r\nThe Input validator, SearchProcessor, SearchQuery alias-provider, are all optional now and will be enabled when there requirements are meant. Else you will get an error informing which dependencies are missing.\r\n\r\n[1]: Symfony 3.3 introduced a number of really powerful improvements to the DependencyInjection component and added support for PSR-16 (SimpleCache) and therefor I decided to target this newly planned release rather then a stable release.\r\n\r\nTodo:\r\n\r\n- StringQuery translator based alias-resolver.","created_at":"2017-02-25T11:11:57Z","updated_at":"2017-02-26T11:07:09Z","closed_at":"2017-02-26T11:07:09Z","merged_at":"2017-02-26T11:07:09Z","merge_commit_sha":"4dfa52d7bea5c529e9a1c673490ae62d1b27e1c4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/rollerworks/RollerworksSearchBundle/pulls/25/commits","review_comments_url":"https://api.github.com/repos/rollerworks/RollerworksSearchBundle/pulls/25/comments","review_comment_url":"https://api.github.com/repos/rollerworks/RollerworksSearchBundle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rollerworks/RollerworksSearchBundle/issues/25/comments","statuses_url":"https://api.github.com/repos/rollerworks/RollerworksSearchBundle/statuses/fe3c9edc4285aae7fc8697df96e41f4361d7e2eb","head":{"label":"sstok:refactor-2.0","ref":"refactor-2.0","sha":"fe3c9edc4285aae7fc8697df96e41f4361d7e2eb","user":{"login":"sstok","id":904790,"avatar_url":"https://avatars.githubusercontent.com/u/904790?v=3","gravatar_id":"","url":"https://api.github.com/users/sstok","html_url":"https://github.com/sstok","followers_url":"https://api.github.com/users/sstok/followers","following_url":"https://api.github.com/users/sstok/following{/other_user}","gists_url":"https://api.github.com/users/sstok/gists{/gist_id}","starred_url":"https://api.github.com/users/sstok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sstok/subscriptions","organizations_url":"https://api.github.com/users/sstok/orgs","repos_url":"https://api.github.com/users/sstok/repos","events_url":"https://api.github.com/users/sstok/events{/privacy}","received_events_url":"https://api.github.com/users/sstok/received_events","type":"User","site_admin":false},"repo":{"id":29685376,"name":"RollerworksSearchBundle","full_name":"sstok/RollerworksSearchBundle","owner":{"login":"sstok","id":904790,"avatar_url":"https://avatars.githubusercontent.com/u/904790?v=3","gravatar_id":"","url":"https://api.github.com/users/sstok","html_url":"https://github.com/sstok","followers_url":"https://api.github.com/users/sstok/followers","following_url":"https://api.github.com/users/sstok/following{/other_user}","gists_url":"https://api.github.com/users/sstok/gists{/gist_id}","starred_url":"https://api.github.com/users/sstok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sstok/subscriptions","organizations_url":"https://api.github.com/users/sstok/orgs","repos_url":"https://api.github.com/users/sstok/repos","events_url":"https://api.github.com/users/sstok/events{/privacy}","received_events_url":"https://api.github.com/users/sstok/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sstok/RollerworksSearchBundle","description":"Integrate the Rollerworks Search Component with any Symfony2 based application","fork":true,"url":"https://api.github.com/repos/sstok/RollerworksSearchBundle","forks_url":"https://api.github.com/repos/sstok/RollerworksSearchBundle/forks","keys_url":"https://api.github.com/repos/sstok/RollerworksSearchBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sstok/RollerworksSearchBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sstok/RollerworksSearchBundle/teams","hooks_url":"https://api.github.com/repos/sstok/RollerworksSearchBundle/hooks","issue_events_url":"https://api.github.com/repos/sstok/RollerworksSearchBundle/issues/events{/number}","events_url":"https://api.github.com/repos/sstok/RollerworksSearchBundle/events","assignees_url":"https://api.github.com/repos/sstok/RollerworksSearchBundle/assignees{/user}","branches_url":"https://api.github.com/repos/sstok/RollerworksSearchBundle/branches{/branch}","tags_url":"https://api.github.com/repos/sstok/RollerworksSearchBundle/tags","blobs_url":"https://api.github.com/repos/sstok/RollerworksSearchBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sstok/RollerworksSearchBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sstok/RollerworksSearchBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/sstok/RollerworksSearchBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sstok/RollerworksSearchBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/sstok/RollerworksSearchBundle/languages","stargazers_url":"https://api.github.com/repos/sstok/RollerworksSearchBundle/stargazers","contributors_url":"https://api.github.com/repos/sstok/RollerworksSearchBundle/contributors","subscribers_url":"https://api.github.com/repos/sstok/RollerworksSearchBundle/subscribers","subscription_url":"https://api.github.com/repos/sstok/RollerworksSearchBundle/subscription","commits_url":"https://api.github.com/repos/sstok/RollerworksSearchBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/sstok/RollerworksSearchBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/sstok/RollerworksSearchBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/sstok/RollerworksSearchBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/sstok/RollerworksSearchBundle/contents/{+path}","compare_url":"https://api.github.com/repos/sstok/RollerworksSearchBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sstok/RollerworksSearchBundle/merges","archive_url":"https://api.github.com/repos/sstok/RollerworksSearchBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sstok/RollerworksSearchBundle/downloads","issues_url":"https://api.github.com/repos/sstok/RollerworksSearchBundle/issues{/number}","pulls_url":"https://api.github.com/repos/sstok/RollerworksSearchBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/sstok/RollerworksSearchBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/sstok/RollerworksSearchBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sstok/RollerworksSearchBundle/labels{/name}","releases_url":"https://api.github.com/repos/sstok/RollerworksSearchBundle/releases{/id}","deployments_url":"https://api.github.com/repos/sstok/RollerworksSearchBundle/deployments","created_at":"2015-01-22T15:31:06Z","updated_at":"2015-01-24T12:03:09Z","pushed_at":"2017-02-26T11:04:18Z","git_url":"git://github.com/sstok/RollerworksSearchBundle.git","ssh_url":"git@github.com:sstok/RollerworksSearchBundle.git","clone_url":"https://github.com/sstok/RollerworksSearchBundle.git","svn_url":"https://github.com/sstok/RollerworksSearchBundle","homepage":"","size":161,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rollerworks:master","ref":"master","sha":"8f4203fa1cf7ab7e452b88053d2d6588a305d7a5","user":{"login":"rollerworks","id":1769921,"avatar_url":"https://avatars.githubusercontent.com/u/1769921?v=3","gravatar_id":"","url":"https://api.github.com/users/rollerworks","html_url":"https://github.com/rollerworks","followers_url":"https://api.github.com/users/rollerworks/followers","following_url":"https://api.github.com/users/rollerworks/following{/other_user}","gists_url":"https://api.github.com/users/rollerworks/gists{/gist_id}","starred_url":"https://api.github.com/users/rollerworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rollerworks/subscriptions","organizations_url":"https://api.github.com/users/rollerworks/orgs","repos_url":"https://api.github.com/users/rollerworks/repos","events_url":"https://api.github.com/users/rollerworks/events{/privacy}","received_events_url":"https://api.github.com/users/rollerworks/received_events","type":"Organization","site_admin":false},"repo":{"id":11895252,"name":"RollerworksSearchBundle","full_name":"rollerworks/RollerworksSearchBundle","owner":{"login":"rollerworks","id":1769921,"avatar_url":"https://avatars.githubusercontent.com/u/1769921?v=3","gravatar_id":"","url":"https://api.github.com/users/rollerworks","html_url":"https://github.com/rollerworks","followers_url":"https://api.github.com/users/rollerworks/followers","following_url":"https://api.github.com/users/rollerworks/following{/other_user}","gists_url":"https://api.github.com/users/rollerworks/gists{/gist_id}","starred_url":"https://api.github.com/users/rollerworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rollerworks/subscriptions","organizations_url":"https://api.github.com/users/rollerworks/orgs","repos_url":"https://api.github.com/users/rollerworks/repos","events_url":"https://api.github.com/users/rollerworks/events{/privacy}","received_events_url":"https://api.github.com/users/rollerworks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rollerworks/RollerworksSearchBundle","description":"Integrate the Rollerworks Search Component with any Symfony based application","fork":false,"url":"https://api.github.com/repos/rollerworks/RollerworksSearchBundle","forks_url":"https://api.github.com/repos/rollerworks/RollerworksSearchBundle/forks","keys_url":"https://api.github.com/repos/rollerworks/RollerworksSearchBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rollerworks/RollerworksSearchBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rollerworks/RollerworksSearchBundle/teams","hooks_url":"https://api.github.com/repos/rollerworks/RollerworksSearchBundle/hooks","issue_events_url":"https://api.github.com/repos/rollerworks/RollerworksSearchBundle/issues/events{/number}","events_url":"https://api.github.com/repos/rollerworks/RollerworksSearchBundle/events","assignees_url":"https://api.github.com/repos/rollerworks/RollerworksSearchBundle/assignees{/user}","branches_url":"https://api.github.com/repos/rollerworks/RollerworksSearchBundle/branches{/branch}","tags_url":"https://api.github.com/repos/rollerworks/RollerworksSearchBundle/tags","blobs_url":"https://api.github.com/repos/rollerworks/RollerworksSearchBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rollerworks/RollerworksSearchBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rollerworks/RollerworksSearchBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/rollerworks/RollerworksSearchBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rollerworks/RollerworksSearchBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/rollerworks/RollerworksSearchBundle/languages","stargazers_url":"https://api.github.com/repos/rollerworks/RollerworksSearchBundle/stargazers","contributors_url":"https://api.github.com/repos/rollerworks/RollerworksSearchBundle/contributors","subscribers_url":"https://api.github.com/repos/rollerworks/RollerworksSearchBundle/subscribers","subscription_url":"https://api.github.com/repos/rollerworks/RollerworksSearchBundle/subscription","commits_url":"https://api.github.com/repos/rollerworks/RollerworksSearchBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/rollerworks/RollerworksSearchBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/rollerworks/RollerworksSearchBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/rollerworks/RollerworksSearchBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/rollerworks/RollerworksSearchBundle/contents/{+path}","compare_url":"https://api.github.com/repos/rollerworks/RollerworksSearchBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rollerworks/RollerworksSearchBundle/merges","archive_url":"https://api.github.com/repos/rollerworks/RollerworksSearchBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rollerworks/RollerworksSearchBundle/downloads","issues_url":"https://api.github.com/repos/rollerworks/RollerworksSearchBundle/issues{/number}","pulls_url":"https://api.github.com/repos/rollerworks/RollerworksSearchBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/rollerworks/RollerworksSearchBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/rollerworks/RollerworksSearchBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rollerworks/RollerworksSearchBundle/labels{/name}","releases_url":"https://api.github.com/repos/rollerworks/RollerworksSearchBundle/releases{/id}","deployments_url":"https://api.github.com/repos/rollerworks/RollerworksSearchBundle/deployments","created_at":"2013-08-05T10:00:56Z","updated_at":"2017-02-13T13:58:30Z","pushed_at":"2017-02-26T11:07:09Z","git_url":"git://github.com/rollerworks/RollerworksSearchBundle.git","ssh_url":"git@github.com:rollerworks/RollerworksSearchBundle.git","clone_url":"https://github.com/rollerworks/RollerworksSearchBundle.git","svn_url":"https://github.com/rollerworks/RollerworksSearchBundle","homepage":"","size":145,"stargazers_count":5,"watchers_count":5,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rollerworks/RollerworksSearchBundle/pulls/25"},"html":{"href":"https://github.com/rollerworks/RollerworksSearchBundle/pull/25"},"issue":{"href":"https://api.github.com/repos/rollerworks/RollerworksSearchBundle/issues/25"},"comments":{"href":"https://api.github.com/repos/rollerworks/RollerworksSearchBundle/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/rollerworks/RollerworksSearchBundle/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/rollerworks/RollerworksSearchBundle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rollerworks/RollerworksSearchBundle/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/rollerworks/RollerworksSearchBundle/statuses/fe3c9edc4285aae7fc8697df96e41f4361d7e2eb"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"sstok","id":904790,"avatar_url":"https://avatars.githubusercontent.com/u/904790?v=3","gravatar_id":"","url":"https://api.github.com/users/sstok","html_url":"https://github.com/sstok","followers_url":"https://api.github.com/users/sstok/followers","following_url":"https://api.github.com/users/sstok/following{/other_user}","gists_url":"https://api.github.com/users/sstok/gists{/gist_id}","starred_url":"https://api.github.com/users/sstok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sstok/subscriptions","organizations_url":"https://api.github.com/users/sstok/orgs","repos_url":"https://api.github.com/users/sstok/repos","events_url":"https://api.github.com/users/sstok/events{/privacy}","received_events_url":"https://api.github.com/users/sstok/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1186,"deletions":3719,"changed_files":77}}
{"actor":{"display_login":"sstok"}}