{"action":"closed","issue":{"url":"https://api.github.com/repos/qiime2/q2-longitudinal/issues/9","repository_url":"https://api.github.com/repos/qiime2/q2-longitudinal","labels_url":"https://api.github.com/repos/qiime2/q2-longitudinal/issues/9/labels{/name}","comments_url":"https://api.github.com/repos/qiime2/q2-longitudinal/issues/9/comments","events_url":"https://api.github.com/repos/qiime2/q2-longitudinal/issues/9/events","html_url":"https://github.com/qiime2/q2-longitudinal/issues/9","id":248518184,"number":9,"title":"suggestions for visualizations","user":{"login":"gregcaporaso","id":192372,"avatar_url":"https://avatars2.githubusercontent.com/u/192372?v=4","gravatar_id":"","url":"https://api.github.com/users/gregcaporaso","html_url":"https://github.com/gregcaporaso","followers_url":"https://api.github.com/users/gregcaporaso/followers","following_url":"https://api.github.com/users/gregcaporaso/following{/other_user}","gists_url":"https://api.github.com/users/gregcaporaso/gists{/gist_id}","starred_url":"https://api.github.com/users/gregcaporaso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregcaporaso/subscriptions","organizations_url":"https://api.github.com/users/gregcaporaso/orgs","repos_url":"https://api.github.com/users/gregcaporaso/repos","events_url":"https://api.github.com/users/gregcaporaso/events{/privacy}","received_events_url":"https://api.github.com/users/gregcaporaso/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-08-07T20:13:24Z","updated_at":"2017-08-18T17:12:45Z","closed_at":"2017-08-18T17:12:45Z","body":"In the `paired-differences` boxplot, the y-axis label should be `Difference in {metric} (state 2 - state 1)`, or you could get more fancy with it and actually use the `state_column`, `state1` and `state2` variables, in which case it could be: `Difference in {metric} ({state_column} {state2} - {state_column} {state2})` (e.g., _Difference in shannon (month 12 - month 0)_)\r\n\r\nIn _Paired difference tests_ table, can you include the test name and the test statistic name (currently it just says _stat_, but you should be able to keep a dict mapping test name to test statistic name so that this label could be more informative. See [here](https://github.com/qiime2/q2-diversity/blob/2a7f3efb9bcab255129b0b225793e984f4b81185/q2_diversity/_beta/_visualizer.py#L242) for an example. Also, please make the _P_ column label say _P value_ and _FDR P_ -> _FDR P-value_.\r\n\r\nCan the _Multiple group tests_ table be transposed so it matches the others? \r\n\r\nI'm confused about what the difference is between the  _Multiple group tests_ and _Pairwise comparison tests_ tables when there are only two groups. It might help to have a brief description of what each test is (and including the test name in each would help with this). When there are only two groups, should the results of these tests be different (they are in the README example, so just confirming that that is expected). \r\n\r\nThese should also be applied to the `pairwise-distances` visualization."}}
{"actor":{"display_login":"gregcaporaso"}}