{"action":"created","comment":{"url":"https://api.github.com/repos/bblfsh/sdk/pulls/comments/112154633","pull_request_review_id":33446298,"id":112154633,"diff_hunk":"@@ -12,7 +12,13 @@ $(shell mkdir -p $(tmplocation))\n \n bblfsh-sdk := $(shell command -v bblfsh-sdk 2> /dev/null)\n bblfsh-tools := $(shell command -v bblfsh-tools 2> /dev/null)\n-ifdef bblfsh-tools\n+in-container := $(shell echo $$ENVIRONMENT)\n+\n+# TODO(bzz) ideal: `go run` ONLY inside container, started from non-linux host\n+ifdef bblfsh-tools # with Golang","path":"etc/build/Makefile","position":8,"original_position":8,"commit_id":"4653ff9516fc2d460c21292b9647c9f95ac85c34","original_commit_id":"4653ff9516fc2d460c21292b9647c9f95ac85c34","user":{"login":"smola","id":23248,"avatar_url":"https://avatars2.githubusercontent.com/u/23248?v=3","gravatar_id":"","url":"https://api.github.com/users/smola","html_url":"https://github.com/smola","followers_url":"https://api.github.com/users/smola/followers","following_url":"https://api.github.com/users/smola/following{/other_user}","gists_url":"https://api.github.com/users/smola/gists{/gist_id}","starred_url":"https://api.github.com/users/smola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smola/subscriptions","organizations_url":"https://api.github.com/users/smola/orgs","repos_url":"https://api.github.com/users/smola/repos","events_url":"https://api.github.com/users/smola/events{/privacy}","received_events_url":"https://api.github.com/users/smola/received_events","type":"User","site_admin":false},"body":"Maybe this outer ifdef is not needed?","created_at":"2017-04-19T09:24:00Z","updated_at":"2017-04-19T09:27:30Z","html_url":"https://github.com/bblfsh/sdk/pull/87#discussion_r112154633","pull_request_url":"https://api.github.com/repos/bblfsh/sdk/pulls/87","_links":{"self":{"href":"https://api.github.com/repos/bblfsh/sdk/pulls/comments/112154633"},"html":{"href":"https://github.com/bblfsh/sdk/pull/87#discussion_r112154633"},"pull_request":{"href":"https://api.github.com/repos/bblfsh/sdk/pulls/87"}}},"pull_request":{"url":"https://api.github.com/repos/bblfsh/sdk/pulls/87","id":116376235,"html_url":"https://github.com/bblfsh/sdk/pull/87","diff_url":"https://github.com/bblfsh/sdk/pull/87.diff","patch_url":"https://github.com/bblfsh/sdk/pull/87.patch","issue_url":"https://api.github.com/repos/bblfsh/sdk/issues/87","number":87,"state":"open","locked":false,"title":"bblfsh-tools do not fail inside a container, started from macOS","user":{"login":"bzz","id":5582506,"avatar_url":"https://avatars0.githubusercontent.com/u/5582506?v=3","gravatar_id":"","url":"https://api.github.com/users/bzz","html_url":"https://github.com/bzz","followers_url":"https://api.github.com/users/bzz/followers","following_url":"https://api.github.com/users/bzz/following{/other_user}","gists_url":"https://api.github.com/users/bzz/gists{/gist_id}","starred_url":"https://api.github.com/users/bzz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bzz/subscriptions","organizations_url":"https://api.github.com/users/bzz/orgs","repos_url":"https://api.github.com/users/bzz/repos","events_url":"https://api.github.com/users/bzz/events{/privacy}","received_events_url":"https://api.github.com/users/bzz/received_events","type":"User","site_admin":false},"body":"`make test` pass, but though the process `bblfsh-tools` fail to run properly inside the container, when started from macOS host.\r\n\r\n```\r\n+ docker run --rm -t -u bblfsh:501 -v /Users/alex/go/src/github.com/bblfsh/java-driver:/opt/driver/src/ -v /Users/alex/go:/go -e ENVIRONMENT=bblfsh/java-driver-build-with-go bblfsh/java-driver-build-with-go make test-driver-internal\r\n/go/bin/bblfsh-tools: line 1: ����: not found\r\n/go/bin/bblfsh-tools: line 2: H__PAGEZEROx__TEXT�__text__TEXT: not found\r\n/go/bin/bblfsh-tools: line 1: syntax error: unexpected end of file (expecting \")\")\r\ncd native; \\\r\nmvn package\r\nWarning: JAVA_HOME environment variable is not set.\r\n[INFO] Scanning for projects...\r\n[INFO]\r\n[INFO] ------------------------------------------------------------------------\r\n[INFO] Building javaparser 1.0-SNAPSHOT\r\n[INFO] ------------------------------------------------------------------------\r\n```\r\n\r\nAs `bblfsh-tools` are used from Makefile in both, inside and outside of a build container, but are compiled once under the host architecture - it results in obscure failure to run MarchO binary on Linux. \r\n\r\nAfter more testing, this seems to not fail `make test` though, so not sure if this fix worth merging.","created_at":"2017-04-18T17:08:56Z","updated_at":"2017-04-19T09:27:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6ad654f38cbf8308fa412e93754caa6893f3c2ac","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/bblfsh/sdk/pulls/87/commits","review_comments_url":"https://api.github.com/repos/bblfsh/sdk/pulls/87/comments","review_comment_url":"https://api.github.com/repos/bblfsh/sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bblfsh/sdk/issues/87/comments","statuses_url":"https://api.github.com/repos/bblfsh/sdk/statuses/4653ff9516fc2d460c21292b9647c9f95ac85c34","head":{"label":"bzz:make-docker-build-work-on-macos","ref":"make-docker-build-work-on-macos","sha":"4653ff9516fc2d460c21292b9647c9f95ac85c34","user":{"login":"bzz","id":5582506,"avatar_url":"https://avatars0.githubusercontent.com/u/5582506?v=3","gravatar_id":"","url":"https://api.github.com/users/bzz","html_url":"https://github.com/bzz","followers_url":"https://api.github.com/users/bzz/followers","following_url":"https://api.github.com/users/bzz/following{/other_user}","gists_url":"https://api.github.com/users/bzz/gists{/gist_id}","starred_url":"https://api.github.com/users/bzz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bzz/subscriptions","organizations_url":"https://api.github.com/users/bzz/orgs","repos_url":"https://api.github.com/users/bzz/repos","events_url":"https://api.github.com/users/bzz/events{/privacy}","received_events_url":"https://api.github.com/users/bzz/received_events","type":"User","site_admin":false},"repo":{"id":88647863,"name":"sdk","full_name":"bzz/sdk","owner":{"login":"bzz","id":5582506,"avatar_url":"https://avatars0.githubusercontent.com/u/5582506?v=3","gravatar_id":"","url":"https://api.github.com/users/bzz","html_url":"https://github.com/bzz","followers_url":"https://api.github.com/users/bzz/followers","following_url":"https://api.github.com/users/bzz/following{/other_user}","gists_url":"https://api.github.com/users/bzz/gists{/gist_id}","starred_url":"https://api.github.com/users/bzz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bzz/subscriptions","organizations_url":"https://api.github.com/users/bzz/orgs","repos_url":"https://api.github.com/users/bzz/repos","events_url":"https://api.github.com/users/bzz/events{/privacy}","received_events_url":"https://api.github.com/users/bzz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bzz/sdk","description":"Babelfish driver SDK ","fork":true,"url":"https://api.github.com/repos/bzz/sdk","forks_url":"https://api.github.com/repos/bzz/sdk/forks","keys_url":"https://api.github.com/repos/bzz/sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bzz/sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bzz/sdk/teams","hooks_url":"https://api.github.com/repos/bzz/sdk/hooks","issue_events_url":"https://api.github.com/repos/bzz/sdk/issues/events{/number}","events_url":"https://api.github.com/repos/bzz/sdk/events","assignees_url":"https://api.github.com/repos/bzz/sdk/assignees{/user}","branches_url":"https://api.github.com/repos/bzz/sdk/branches{/branch}","tags_url":"https://api.github.com/repos/bzz/sdk/tags","blobs_url":"https://api.github.com/repos/bzz/sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bzz/sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bzz/sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/bzz/sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bzz/sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/bzz/sdk/languages","stargazers_url":"https://api.github.com/repos/bzz/sdk/stargazers","contributors_url":"https://api.github.com/repos/bzz/sdk/contributors","subscribers_url":"https://api.github.com/repos/bzz/sdk/subscribers","subscription_url":"https://api.github.com/repos/bzz/sdk/subscription","commits_url":"https://api.github.com/repos/bzz/sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/bzz/sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/bzz/sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/bzz/sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/bzz/sdk/contents/{+path}","compare_url":"https://api.github.com/repos/bzz/sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bzz/sdk/merges","archive_url":"https://api.github.com/repos/bzz/sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bzz/sdk/downloads","issues_url":"https://api.github.com/repos/bzz/sdk/issues{/number}","pulls_url":"https://api.github.com/repos/bzz/sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/bzz/sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/bzz/sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bzz/sdk/labels{/name}","releases_url":"https://api.github.com/repos/bzz/sdk/releases{/id}","deployments_url":"https://api.github.com/repos/bzz/sdk/deployments","created_at":"2017-04-18T16:38:30Z","updated_at":"2017-04-18T16:38:31Z","pushed_at":"2017-04-18T16:45:01Z","git_url":"git://github.com/bzz/sdk.git","ssh_url":"git@github.com:bzz/sdk.git","clone_url":"https://github.com/bzz/sdk.git","svn_url":"https://github.com/bzz/sdk","homepage":"","size":357,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bblfsh:master","ref":"master","sha":"e47f27e3e30f90158955f140e8c357d177647571","user":{"login":"bblfsh","id":25795418,"avatar_url":"https://avatars3.githubusercontent.com/u/25795418?v=3","gravatar_id":"","url":"https://api.github.com/users/bblfsh","html_url":"https://github.com/bblfsh","followers_url":"https://api.github.com/users/bblfsh/followers","following_url":"https://api.github.com/users/bblfsh/following{/other_user}","gists_url":"https://api.github.com/users/bblfsh/gists{/gist_id}","starred_url":"https://api.github.com/users/bblfsh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bblfsh/subscriptions","organizations_url":"https://api.github.com/users/bblfsh/orgs","repos_url":"https://api.github.com/users/bblfsh/repos","events_url":"https://api.github.com/users/bblfsh/events{/privacy}","received_events_url":"https://api.github.com/users/bblfsh/received_events","type":"Organization","site_admin":false},"repo":{"id":82719719,"name":"sdk","full_name":"bblfsh/sdk","owner":{"login":"bblfsh","id":25795418,"avatar_url":"https://avatars3.githubusercontent.com/u/25795418?v=3","gravatar_id":"","url":"https://api.github.com/users/bblfsh","html_url":"https://github.com/bblfsh","followers_url":"https://api.github.com/users/bblfsh/followers","following_url":"https://api.github.com/users/bblfsh/following{/other_user}","gists_url":"https://api.github.com/users/bblfsh/gists{/gist_id}","starred_url":"https://api.github.com/users/bblfsh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bblfsh/subscriptions","organizations_url":"https://api.github.com/users/bblfsh/orgs","repos_url":"https://api.github.com/users/bblfsh/repos","events_url":"https://api.github.com/users/bblfsh/events{/privacy}","received_events_url":"https://api.github.com/users/bblfsh/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bblfsh/sdk","description":"Babelfish driver SDK ","fork":false,"url":"https://api.github.com/repos/bblfsh/sdk","forks_url":"https://api.github.com/repos/bblfsh/sdk/forks","keys_url":"https://api.github.com/repos/bblfsh/sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bblfsh/sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bblfsh/sdk/teams","hooks_url":"https://api.github.com/repos/bblfsh/sdk/hooks","issue_events_url":"https://api.github.com/repos/bblfsh/sdk/issues/events{/number}","events_url":"https://api.github.com/repos/bblfsh/sdk/events","assignees_url":"https://api.github.com/repos/bblfsh/sdk/assignees{/user}","branches_url":"https://api.github.com/repos/bblfsh/sdk/branches{/branch}","tags_url":"https://api.github.com/repos/bblfsh/sdk/tags","blobs_url":"https://api.github.com/repos/bblfsh/sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bblfsh/sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bblfsh/sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/bblfsh/sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bblfsh/sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/bblfsh/sdk/languages","stargazers_url":"https://api.github.com/repos/bblfsh/sdk/stargazers","contributors_url":"https://api.github.com/repos/bblfsh/sdk/contributors","subscribers_url":"https://api.github.com/repos/bblfsh/sdk/subscribers","subscription_url":"https://api.github.com/repos/bblfsh/sdk/subscription","commits_url":"https://api.github.com/repos/bblfsh/sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/bblfsh/sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/bblfsh/sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/bblfsh/sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/bblfsh/sdk/contents/{+path}","compare_url":"https://api.github.com/repos/bblfsh/sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bblfsh/sdk/merges","archive_url":"https://api.github.com/repos/bblfsh/sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bblfsh/sdk/downloads","issues_url":"https://api.github.com/repos/bblfsh/sdk/issues{/number}","pulls_url":"https://api.github.com/repos/bblfsh/sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/bblfsh/sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/bblfsh/sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bblfsh/sdk/labels{/name}","releases_url":"https://api.github.com/repos/bblfsh/sdk/releases{/id}","deployments_url":"https://api.github.com/repos/bblfsh/sdk/deployments","created_at":"2017-02-21T19:41:42Z","updated_at":"2017-03-03T11:55:26Z","pushed_at":"2017-04-18T17:08:57Z","git_url":"git://github.com/bblfsh/sdk.git","ssh_url":"git@github.com:bblfsh/sdk.git","clone_url":"https://github.com/bblfsh/sdk.git","svn_url":"https://github.com/bblfsh/sdk","homepage":"","size":355,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":22,"forks":7,"open_issues":22,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bblfsh/sdk/pulls/87"},"html":{"href":"https://github.com/bblfsh/sdk/pull/87"},"issue":{"href":"https://api.github.com/repos/bblfsh/sdk/issues/87"},"comments":{"href":"https://api.github.com/repos/bblfsh/sdk/issues/87/comments"},"review_comments":{"href":"https://api.github.com/repos/bblfsh/sdk/pulls/87/comments"},"review_comment":{"href":"https://api.github.com/repos/bblfsh/sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bblfsh/sdk/pulls/87/commits"},"statuses":{"href":"https://api.github.com/repos/bblfsh/sdk/statuses/4653ff9516fc2d460c21292b9647c9f95ac85c34"}}}}
{"actor":{"display_login":"smola"}}