{"action":"created","comment":{"url":"https://api.github.com/repos/apple/swift-llbuild/pulls/comments/112336832","pull_request_review_id":33644081,"id":112336832,"diff_hunk":"@@ -319,6 +319,15 @@ typedef struct llb_buildsystem_delegate_t_ {\n                                    llb_buildsystem_process_t* process,\n                                    llb_buildsystem_command_result_t result,\n                                    int exit_status);\n+\n+  /// Called when a cycle is detected by the build engine and it cannot make\n+  /// forward progress.\n+  ///\n+  /// Xparam rules The ordered list of items comprising the cycle, starting from\n+  /// the node which was requested to build and ending with the first node in\n+  /// the cycle (i.e., the node participating in the cycle will appear twice).\n+  /// Xparam ruleCount The number of rules comprising the cycle.\n+  void (*cycleDetected)(void* context, llb_data_t* rules, uint64_t ruleCount);","path":"products/libllbuild/public-api/llbuild/buildsystem.h","position":12,"original_position":12,"commit_id":"f5dcc943dbc8bbd2ef806a12e8745a8bfe65b684","original_commit_id":"f5dcc943dbc8bbd2ef806a12e8745a8bfe65b684","user":{"login":"ddunbar","id":106625,"avatar_url":"https://avatars0.githubusercontent.com/u/106625?v=3","gravatar_id":"","url":"https://api.github.com/users/ddunbar","html_url":"https://github.com/ddunbar","followers_url":"https://api.github.com/users/ddunbar/followers","following_url":"https://api.github.com/users/ddunbar/following{/other_user}","gists_url":"https://api.github.com/users/ddunbar/gists{/gist_id}","starred_url":"https://api.github.com/users/ddunbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddunbar/subscriptions","organizations_url":"https://api.github.com/users/ddunbar/orgs","repos_url":"https://api.github.com/users/ddunbar/repos","events_url":"https://api.github.com/users/ddunbar/events{/privacy}","received_events_url":"https://api.github.com/users/ddunbar/received_events","type":"User","site_admin":false},"body":"s/cycleDetected/cycle_detected/, s/ruleCount/rule_count/ -- the C API uses traditional C / POSIX style naming.","created_at":"2017-04-19T23:27:21Z","updated_at":"2017-04-19T23:27:26Z","html_url":"https://github.com/apple/swift-llbuild/pull/143#discussion_r112336832","pull_request_url":"https://api.github.com/repos/apple/swift-llbuild/pulls/143","_links":{"self":{"href":"https://api.github.com/repos/apple/swift-llbuild/pulls/comments/112336832"},"html":{"href":"https://github.com/apple/swift-llbuild/pull/143#discussion_r112336832"},"pull_request":{"href":"https://api.github.com/repos/apple/swift-llbuild/pulls/143"}}},"pull_request":{"url":"https://api.github.com/repos/apple/swift-llbuild/pulls/143","id":116575653,"html_url":"https://github.com/apple/swift-llbuild/pull/143","diff_url":"https://github.com/apple/swift-llbuild/pull/143.diff","patch_url":"https://github.com/apple/swift-llbuild/pull/143.patch","issue_url":"https://api.github.com/repos/apple/swift-llbuild/issues/143","number":143,"state":"open","locked":false,"title":"Make cycle information available to the client","user":{"login":"neonichu","id":118992,"avatar_url":"https://avatars3.githubusercontent.com/u/118992?v=3","gravatar_id":"","url":"https://api.github.com/users/neonichu","html_url":"https://github.com/neonichu","followers_url":"https://api.github.com/users/neonichu/followers","following_url":"https://api.github.com/users/neonichu/following{/other_user}","gists_url":"https://api.github.com/users/neonichu/gists{/gist_id}","starred_url":"https://api.github.com/users/neonichu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neonichu/subscriptions","organizations_url":"https://api.github.com/users/neonichu/orgs","repos_url":"https://api.github.com/users/neonichu/repos","events_url":"https://api.github.com/users/neonichu/events{/privacy}","received_events_url":"https://api.github.com/users/neonichu/received_events","type":"User","site_admin":false},"body":"This allows the clients of llbuild to decide how to present cycle diagnostics instead of doing this internally. When using the llbuild CLI, the previous way of reporting cycles is retained.","created_at":"2017-04-19T15:26:18Z","updated_at":"2017-04-19T23:27:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cbce82f77acc16d323d71db2682abbc7f62e05e8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift-llbuild/pulls/143/commits","review_comments_url":"https://api.github.com/repos/apple/swift-llbuild/pulls/143/comments","review_comment_url":"https://api.github.com/repos/apple/swift-llbuild/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift-llbuild/issues/143/comments","statuses_url":"https://api.github.com/repos/apple/swift-llbuild/statuses/f5dcc943dbc8bbd2ef806a12e8745a8bfe65b684","head":{"label":"neonichu:better-diagnostics-for-dependency-cycles","ref":"better-diagnostics-for-dependency-cycles","sha":"f5dcc943dbc8bbd2ef806a12e8745a8bfe65b684","user":{"login":"neonichu","id":118992,"avatar_url":"https://avatars3.githubusercontent.com/u/118992?v=3","gravatar_id":"","url":"https://api.github.com/users/neonichu","html_url":"https://github.com/neonichu","followers_url":"https://api.github.com/users/neonichu/followers","following_url":"https://api.github.com/users/neonichu/following{/other_user}","gists_url":"https://api.github.com/users/neonichu/gists{/gist_id}","starred_url":"https://api.github.com/users/neonichu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neonichu/subscriptions","organizations_url":"https://api.github.com/users/neonichu/orgs","repos_url":"https://api.github.com/users/neonichu/repos","events_url":"https://api.github.com/users/neonichu/events{/privacy}","received_events_url":"https://api.github.com/users/neonichu/received_events","type":"User","site_admin":false},"repo":{"id":71408294,"name":"swift-llbuild","full_name":"neonichu/swift-llbuild","owner":{"login":"neonichu","id":118992,"avatar_url":"https://avatars3.githubusercontent.com/u/118992?v=3","gravatar_id":"","url":"https://api.github.com/users/neonichu","html_url":"https://github.com/neonichu","followers_url":"https://api.github.com/users/neonichu/followers","following_url":"https://api.github.com/users/neonichu/following{/other_user}","gists_url":"https://api.github.com/users/neonichu/gists{/gist_id}","starred_url":"https://api.github.com/users/neonichu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neonichu/subscriptions","organizations_url":"https://api.github.com/users/neonichu/orgs","repos_url":"https://api.github.com/users/neonichu/repos","events_url":"https://api.github.com/users/neonichu/events{/privacy}","received_events_url":"https://api.github.com/users/neonichu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/neonichu/swift-llbuild","description":"A low-level build system, used by the Swift Package Manager","fork":true,"url":"https://api.github.com/repos/neonichu/swift-llbuild","forks_url":"https://api.github.com/repos/neonichu/swift-llbuild/forks","keys_url":"https://api.github.com/repos/neonichu/swift-llbuild/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neonichu/swift-llbuild/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neonichu/swift-llbuild/teams","hooks_url":"https://api.github.com/repos/neonichu/swift-llbuild/hooks","issue_events_url":"https://api.github.com/repos/neonichu/swift-llbuild/issues/events{/number}","events_url":"https://api.github.com/repos/neonichu/swift-llbuild/events","assignees_url":"https://api.github.com/repos/neonichu/swift-llbuild/assignees{/user}","branches_url":"https://api.github.com/repos/neonichu/swift-llbuild/branches{/branch}","tags_url":"https://api.github.com/repos/neonichu/swift-llbuild/tags","blobs_url":"https://api.github.com/repos/neonichu/swift-llbuild/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neonichu/swift-llbuild/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neonichu/swift-llbuild/git/refs{/sha}","trees_url":"https://api.github.com/repos/neonichu/swift-llbuild/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neonichu/swift-llbuild/statuses/{sha}","languages_url":"https://api.github.com/repos/neonichu/swift-llbuild/languages","stargazers_url":"https://api.github.com/repos/neonichu/swift-llbuild/stargazers","contributors_url":"https://api.github.com/repos/neonichu/swift-llbuild/contributors","subscribers_url":"https://api.github.com/repos/neonichu/swift-llbuild/subscribers","subscription_url":"https://api.github.com/repos/neonichu/swift-llbuild/subscription","commits_url":"https://api.github.com/repos/neonichu/swift-llbuild/commits{/sha}","git_commits_url":"https://api.github.com/repos/neonichu/swift-llbuild/git/commits{/sha}","comments_url":"https://api.github.com/repos/neonichu/swift-llbuild/comments{/number}","issue_comment_url":"https://api.github.com/repos/neonichu/swift-llbuild/issues/comments{/number}","contents_url":"https://api.github.com/repos/neonichu/swift-llbuild/contents/{+path}","compare_url":"https://api.github.com/repos/neonichu/swift-llbuild/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neonichu/swift-llbuild/merges","archive_url":"https://api.github.com/repos/neonichu/swift-llbuild/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neonichu/swift-llbuild/downloads","issues_url":"https://api.github.com/repos/neonichu/swift-llbuild/issues{/number}","pulls_url":"https://api.github.com/repos/neonichu/swift-llbuild/pulls{/number}","milestones_url":"https://api.github.com/repos/neonichu/swift-llbuild/milestones{/number}","notifications_url":"https://api.github.com/repos/neonichu/swift-llbuild/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neonichu/swift-llbuild/labels{/name}","releases_url":"https://api.github.com/repos/neonichu/swift-llbuild/releases{/id}","deployments_url":"https://api.github.com/repos/neonichu/swift-llbuild/deployments","created_at":"2016-10-19T23:36:02Z","updated_at":"2016-10-19T23:36:04Z","pushed_at":"2017-04-19T15:25:26Z","git_url":"git://github.com/neonichu/swift-llbuild.git","ssh_url":"git@github.com:neonichu/swift-llbuild.git","clone_url":"https://github.com/neonichu/swift-llbuild.git","svn_url":"https://github.com/neonichu/swift-llbuild","homepage":"","size":7548,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"fd26be23dc90d0e2b9deb19433012a1a313ebee4","user":{"login":"apple","id":10639145,"avatar_url":"https://avatars3.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838988,"name":"swift-llbuild","full_name":"apple/swift-llbuild","owner":{"login":"apple","id":10639145,"avatar_url":"https://avatars3.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/swift-llbuild","description":"A low-level build system, used by the Swift Package Manager","fork":false,"url":"https://api.github.com/repos/apple/swift-llbuild","forks_url":"https://api.github.com/repos/apple/swift-llbuild/forks","keys_url":"https://api.github.com/repos/apple/swift-llbuild/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift-llbuild/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift-llbuild/teams","hooks_url":"https://api.github.com/repos/apple/swift-llbuild/hooks","issue_events_url":"https://api.github.com/repos/apple/swift-llbuild/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift-llbuild/events","assignees_url":"https://api.github.com/repos/apple/swift-llbuild/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift-llbuild/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift-llbuild/tags","blobs_url":"https://api.github.com/repos/apple/swift-llbuild/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift-llbuild/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift-llbuild/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift-llbuild/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift-llbuild/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift-llbuild/languages","stargazers_url":"https://api.github.com/repos/apple/swift-llbuild/stargazers","contributors_url":"https://api.github.com/repos/apple/swift-llbuild/contributors","subscribers_url":"https://api.github.com/repos/apple/swift-llbuild/subscribers","subscription_url":"https://api.github.com/repos/apple/swift-llbuild/subscription","commits_url":"https://api.github.com/repos/apple/swift-llbuild/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift-llbuild/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift-llbuild/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift-llbuild/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift-llbuild/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift-llbuild/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift-llbuild/merges","archive_url":"https://api.github.com/repos/apple/swift-llbuild/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift-llbuild/downloads","issues_url":"https://api.github.com/repos/apple/swift-llbuild/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift-llbuild/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift-llbuild/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift-llbuild/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift-llbuild/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift-llbuild/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift-llbuild/deployments","created_at":"2015-10-23T21:15:45Z","updated_at":"2017-04-17T04:59:14Z","pushed_at":"2017-04-19T22:16:00Z","git_url":"git://github.com/apple/swift-llbuild.git","ssh_url":"git@github.com:apple/swift-llbuild.git","clone_url":"https://github.com/apple/swift-llbuild.git","svn_url":"https://github.com/apple/swift-llbuild","homepage":"","size":7557,"stargazers_count":373,"watchers_count":373,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":69,"mirror_url":null,"open_issues_count":7,"forks":69,"open_issues":7,"watchers":373,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift-llbuild/pulls/143"},"html":{"href":"https://github.com/apple/swift-llbuild/pull/143"},"issue":{"href":"https://api.github.com/repos/apple/swift-llbuild/issues/143"},"comments":{"href":"https://api.github.com/repos/apple/swift-llbuild/issues/143/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift-llbuild/pulls/143/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift-llbuild/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift-llbuild/pulls/143/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift-llbuild/statuses/f5dcc943dbc8bbd2ef806a12e8745a8bfe65b684"}}}}
{"actor":{"display_login":"ddunbar"}}