{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kops/pulls/comments/148970732","pull_request_review_id":74293364,"id":148970732,"diff_hunk":"@@ -36,22 +36,38 @@ type CopyFile struct {\n \tName       *string\n \tSourceFile *string\n \tTargetFile *string\n-\t// @justinsb not sure I like this but the problem is knowing if the sha is a file or a string\n-\t// so I did a location or a sha.  We have both SHAs in remote file locations, and SHAs in strings\n-\tSourceShaLocation *string\n-\tSourceSha         *string\n-\tTargetSha         *string\n-\tLifecycle         *fi.Lifecycle\n+\tSourceSha  *string\n+\tTargetSha  *string","path":"upup/pkg/fi/assettasks/copyfile.go","position":11,"original_position":11,"commit_id":"141f194fd0d265c0cbad6ee37ad0b7085dd937d5","original_commit_id":"141f194fd0d265c0cbad6ee37ad0b7085dd937d5","user":{"login":"justinsb","id":100893,"avatar_url":"https://avatars2.githubusercontent.com/u/100893?v=4","gravatar_id":"","url":"https://api.github.com/users/justinsb","html_url":"https://github.com/justinsb","followers_url":"https://api.github.com/users/justinsb/followers","following_url":"https://api.github.com/users/justinsb/following{/other_user}","gists_url":"https://api.github.com/users/justinsb/gists{/gist_id}","starred_url":"https://api.github.com/users/justinsb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinsb/subscriptions","organizations_url":"https://api.github.com/users/justinsb/orgs","repos_url":"https://api.github.com/users/justinsb/repos","events_url":"https://api.github.com/users/justinsb/events{/privacy}","received_events_url":"https://api.github.com/users/justinsb/received_events","type":"User","site_admin":false},"body":"So I think just `Hash *string` or `SHA *string`","created_at":"2017-11-05T21:07:24Z","updated_at":"2017-11-05T21:32:01Z","html_url":"https://github.com/kubernetes/kops/pull/3254#discussion_r148970732","pull_request_url":"https://api.github.com/repos/kubernetes/kops/pulls/3254","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kops/pulls/comments/148970732"},"html":{"href":"https://github.com/kubernetes/kops/pull/3254#discussion_r148970732"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kops/pulls/3254"}},"in_reply_to_id":148970727},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kops/pulls/3254","id":137054035,"html_url":"https://github.com/kubernetes/kops/pull/3254","diff_url":"https://github.com/kubernetes/kops/pull/3254.diff","patch_url":"https://github.com/kubernetes/kops/pull/3254.patch","issue_url":"https://api.github.com/repos/kubernetes/kops/issues/3254","number":3254,"state":"open","locked":false,"title":"work on using files assets","user":{"login":"chrislovecnm","id":335402,"avatar_url":"https://avatars2.githubusercontent.com/u/335402?v=4","gravatar_id":"","url":"https://api.github.com/users/chrislovecnm","html_url":"https://github.com/chrislovecnm","followers_url":"https://api.github.com/users/chrislovecnm/followers","following_url":"https://api.github.com/users/chrislovecnm/following{/other_user}","gists_url":"https://api.github.com/users/chrislovecnm/gists{/gist_id}","starred_url":"https://api.github.com/users/chrislovecnm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrislovecnm/subscriptions","organizations_url":"https://api.github.com/users/chrislovecnm/orgs","repos_url":"https://api.github.com/users/chrislovecnm/repos","events_url":"https://api.github.com/users/chrislovecnm/events{/privacy}","received_events_url":"https://api.github.com/users/chrislovecnm/received_events","type":"User","site_admin":false},"body":"Basic MVP for file assests.\r\n\r\n- using file assest builder\r\n- able to upload files\r\n- using URL structs instead of strings everywhere","created_at":"2017-08-22T18:54:43Z","updated_at":"2017-11-05T21:32:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5d9e6844c54bae1e07fca73d8473b4127fdec8a4","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/kubernetes/kops/milestones/3","html_url":"https://github.com/kubernetes/kops/milestone/3","labels_url":"https://api.github.com/repos/kubernetes/kops/milestones/3/labels","id":1919771,"number":3,"title":"backlog","description":"Issues in the backlog aren't targeted for a particular release, but if a PR comes in it will be very welcome.","creator":{"login":"justinsb","id":100893,"avatar_url":"https://avatars2.githubusercontent.com/u/100893?v=4","gravatar_id":"","url":"https://api.github.com/users/justinsb","html_url":"https://github.com/justinsb","followers_url":"https://api.github.com/users/justinsb/followers","following_url":"https://api.github.com/users/justinsb/following{/other_user}","gists_url":"https://api.github.com/users/justinsb/gists{/gist_id}","starred_url":"https://api.github.com/users/justinsb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinsb/subscriptions","organizations_url":"https://api.github.com/users/justinsb/orgs","repos_url":"https://api.github.com/users/justinsb/repos","events_url":"https://api.github.com/users/justinsb/events{/privacy}","received_events_url":"https://api.github.com/users/justinsb/received_events","type":"User","site_admin":false},"open_issues":89,"closed_issues":94,"state":"open","created_at":"2016-08-03T03:09:45Z","updated_at":"2017-11-05T04:38:22Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/kubernetes/kops/pulls/3254/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kops/pulls/3254/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kops/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kops/issues/3254/comments","statuses_url":"https://api.github.com/repos/kubernetes/kops/statuses/141f194fd0d265c0cbad6ee37ad0b7085dd937d5","head":{"label":"chrislovecnm:file-assets","ref":"file-assets","sha":"141f194fd0d265c0cbad6ee37ad0b7085dd937d5","user":{"login":"chrislovecnm","id":335402,"avatar_url":"https://avatars2.githubusercontent.com/u/335402?v=4","gravatar_id":"","url":"https://api.github.com/users/chrislovecnm","html_url":"https://github.com/chrislovecnm","followers_url":"https://api.github.com/users/chrislovecnm/followers","following_url":"https://api.github.com/users/chrislovecnm/following{/other_user}","gists_url":"https://api.github.com/users/chrislovecnm/gists{/gist_id}","starred_url":"https://api.github.com/users/chrislovecnm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrislovecnm/subscriptions","organizations_url":"https://api.github.com/users/chrislovecnm/orgs","repos_url":"https://api.github.com/users/chrislovecnm/repos","events_url":"https://api.github.com/users/chrislovecnm/events{/privacy}","received_events_url":"https://api.github.com/users/chrislovecnm/received_events","type":"User","site_admin":false},"repo":{"id":64396897,"name":"kops","full_name":"chrislovecnm/kops","owner":{"login":"chrislovecnm","id":335402,"avatar_url":"https://avatars2.githubusercontent.com/u/335402?v=4","gravatar_id":"","url":"https://api.github.com/users/chrislovecnm","html_url":"https://github.com/chrislovecnm","followers_url":"https://api.github.com/users/chrislovecnm/followers","following_url":"https://api.github.com/users/chrislovecnm/following{/other_user}","gists_url":"https://api.github.com/users/chrislovecnm/gists{/gist_id}","starred_url":"https://api.github.com/users/chrislovecnm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrislovecnm/subscriptions","organizations_url":"https://api.github.com/users/chrislovecnm/orgs","repos_url":"https://api.github.com/users/chrislovecnm/repos","events_url":"https://api.github.com/users/chrislovecnm/events{/privacy}","received_events_url":"https://api.github.com/users/chrislovecnm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chrislovecnm/kops","description":"kops deployment","fork":true,"url":"https://api.github.com/repos/chrislovecnm/kops","forks_url":"https://api.github.com/repos/chrislovecnm/kops/forks","keys_url":"https://api.github.com/repos/chrislovecnm/kops/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chrislovecnm/kops/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chrislovecnm/kops/teams","hooks_url":"https://api.github.com/repos/chrislovecnm/kops/hooks","issue_events_url":"https://api.github.com/repos/chrislovecnm/kops/issues/events{/number}","events_url":"https://api.github.com/repos/chrislovecnm/kops/events","assignees_url":"https://api.github.com/repos/chrislovecnm/kops/assignees{/user}","branches_url":"https://api.github.com/repos/chrislovecnm/kops/branches{/branch}","tags_url":"https://api.github.com/repos/chrislovecnm/kops/tags","blobs_url":"https://api.github.com/repos/chrislovecnm/kops/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chrislovecnm/kops/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chrislovecnm/kops/git/refs{/sha}","trees_url":"https://api.github.com/repos/chrislovecnm/kops/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chrislovecnm/kops/statuses/{sha}","languages_url":"https://api.github.com/repos/chrislovecnm/kops/languages","stargazers_url":"https://api.github.com/repos/chrislovecnm/kops/stargazers","contributors_url":"https://api.github.com/repos/chrislovecnm/kops/contributors","subscribers_url":"https://api.github.com/repos/chrislovecnm/kops/subscribers","subscription_url":"https://api.github.com/repos/chrislovecnm/kops/subscription","commits_url":"https://api.github.com/repos/chrislovecnm/kops/commits{/sha}","git_commits_url":"https://api.github.com/repos/chrislovecnm/kops/git/commits{/sha}","comments_url":"https://api.github.com/repos/chrislovecnm/kops/comments{/number}","issue_comment_url":"https://api.github.com/repos/chrislovecnm/kops/issues/comments{/number}","contents_url":"https://api.github.com/repos/chrislovecnm/kops/contents/{+path}","compare_url":"https://api.github.com/repos/chrislovecnm/kops/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chrislovecnm/kops/merges","archive_url":"https://api.github.com/repos/chrislovecnm/kops/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chrislovecnm/kops/downloads","issues_url":"https://api.github.com/repos/chrislovecnm/kops/issues{/number}","pulls_url":"https://api.github.com/repos/chrislovecnm/kops/pulls{/number}","milestones_url":"https://api.github.com/repos/chrislovecnm/kops/milestones{/number}","notifications_url":"https://api.github.com/repos/chrislovecnm/kops/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chrislovecnm/kops/labels{/name}","releases_url":"https://api.github.com/repos/chrislovecnm/kops/releases{/id}","deployments_url":"https://api.github.com/repos/chrislovecnm/kops/deployments","created_at":"2016-07-28T13:14:34Z","updated_at":"2016-07-28T13:14:37Z","pushed_at":"2017-11-05T04:20:31Z","git_url":"git://github.com/chrislovecnm/kops.git","ssh_url":"git@github.com:chrislovecnm/kops.git","clone_url":"https://github.com/chrislovecnm/kops.git","svn_url":"https://github.com/chrislovecnm/kops","homepage":"","size":157169,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"3d0c46f45db3f0c7581c2d9b366ccb4a295bc671","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":62091339,"name":"kops","full_name":"kubernetes/kops","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kops","description":"Kubernetes Operations (kops) - Production Grade K8s Installation, Upgrades, and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kops","forks_url":"https://api.github.com/repos/kubernetes/kops/forks","keys_url":"https://api.github.com/repos/kubernetes/kops/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kops/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kops/teams","hooks_url":"https://api.github.com/repos/kubernetes/kops/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kops/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kops/events","assignees_url":"https://api.github.com/repos/kubernetes/kops/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kops/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kops/tags","blobs_url":"https://api.github.com/repos/kubernetes/kops/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kops/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kops/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kops/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kops/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kops/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kops/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kops/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kops/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kops/subscription","commits_url":"https://api.github.com/repos/kubernetes/kops/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kops/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kops/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kops/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kops/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kops/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kops/merges","archive_url":"https://api.github.com/repos/kubernetes/kops/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kops/downloads","issues_url":"https://api.github.com/repos/kubernetes/kops/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kops/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kops/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kops/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kops/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kops/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kops/deployments","created_at":"2016-06-27T22:01:15Z","updated_at":"2017-11-05T20:39:00Z","pushed_at":"2017-11-05T21:11:22Z","git_url":"git://github.com/kubernetes/kops.git","ssh_url":"git@github.com:kubernetes/kops.git","clone_url":"https://github.com/kubernetes/kops.git","svn_url":"https://github.com/kubernetes/kops","homepage":"","size":168714,"stargazers_count":3301,"watchers_count":3301,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":859,"mirror_url":null,"archived":false,"open_issues_count":751,"forks":859,"open_issues":751,"watchers":3301,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kops/pulls/3254"},"html":{"href":"https://github.com/kubernetes/kops/pull/3254"},"issue":{"href":"https://api.github.com/repos/kubernetes/kops/issues/3254"},"comments":{"href":"https://api.github.com/repos/kubernetes/kops/issues/3254/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kops/pulls/3254/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kops/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kops/pulls/3254/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kops/statuses/141f194fd0d265c0cbad6ee37ad0b7085dd937d5"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"justinsb"}}