{"action":"created","comment":{"url":"https://api.github.com/repos/Scan-o-Matic/scanomatic/pulls/comments/153130220","pull_request_review_id":79088721,"id":153130220,"diff_hunk":"@@ -6,9 +6,12 @@ import PolynomialConstruction from\n     '../../ccc/components/PolynomialConstruction';\n \n describe('<PolynomialConstruction />', () => {\n+    const onDegreeOfPolynomialChange = jasmine.createSpy('onDegreeOfPolynomialChange');\n     const props = {\n+        degreeOfPolynomial: 3,\n         onConstruction: jasmine.createSpy('onConstruction'),\n         onClearError: () => {},\n+        onDegreeOfPolynomialChange,\n         polynomial: {\n             power: -7,","path":"scanomatic/ui_server_data/js/specs/components/PolynomialConstruction.spec.js","position":11,"original_position":11,"commit_id":"3d1502c1b3b3335c8782b27cb67230c777cdd307","original_commit_id":"3d1502c1b3b3335c8782b27cb67230c777cdd307","user":{"login":"local-minimum","id":8041100,"avatar_url":"https://avatars0.githubusercontent.com/u/8041100?v=4","gravatar_id":"","url":"https://api.github.com/users/local-minimum","html_url":"https://github.com/local-minimum","followers_url":"https://api.github.com/users/local-minimum/followers","following_url":"https://api.github.com/users/local-minimum/following{/other_user}","gists_url":"https://api.github.com/users/local-minimum/gists{/gist_id}","starred_url":"https://api.github.com/users/local-minimum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/local-minimum/subscriptions","organizations_url":"https://api.github.com/users/local-minimum/orgs","repos_url":"https://api.github.com/users/local-minimum/repos","events_url":"https://api.github.com/users/local-minimum/events{/privacy}","received_events_url":"https://api.github.com/users/local-minimum/received_events","type":"User","site_admin":false},"body":"I have a knack for mixing `power` and `degree` as if they were the same word. That may not be very good. But I also wonder if we're starting (mostly my fault) make things confusing.\r\n\r\nThe `degreeOfPolynomial` refers to how the next polynomial will be constructed, while `polynomial.power` is a convenience field for the degree of the polynomial defined by `polynomial.coefficients`.\r\n\r\nAt least, it would probably be good here if the test data was updated to have `polynomial.power` equal `2`, which is what the coefficients reflect.","created_at":"2017-11-27T08:29:11Z","updated_at":"2017-11-27T08:31:00Z","html_url":"https://github.com/Scan-o-Matic/scanomatic/pull/229#discussion_r153130220","pull_request_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic/pulls/229","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/Scan-o-Matic/scanomatic/pulls/comments/153130220"},"html":{"href":"https://github.com/Scan-o-Matic/scanomatic/pull/229#discussion_r153130220"},"pull_request":{"href":"https://api.github.com/repos/Scan-o-Matic/scanomatic/pulls/229"}}},"pull_request":{"url":"https://api.github.com/repos/Scan-o-Matic/scanomatic/pulls/229","id":154555272,"html_url":"https://github.com/Scan-o-Matic/scanomatic/pull/229","diff_url":"https://github.com/Scan-o-Matic/scanomatic/pull/229.diff","patch_url":"https://github.com/Scan-o-Matic/scanomatic/pull/229.patch","issue_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic/issues/229","number":229,"state":"open","locked":false,"title":"Add a <select /> to choose the degree of the polynomial","user":{"login":"gdetrez","id":38019,"avatar_url":"https://avatars2.githubusercontent.com/u/38019?v=4","gravatar_id":"","url":"https://api.github.com/users/gdetrez","html_url":"https://github.com/gdetrez","followers_url":"https://api.github.com/users/gdetrez/followers","following_url":"https://api.github.com/users/gdetrez/following{/other_user}","gists_url":"https://api.github.com/users/gdetrez/gists{/gist_id}","starred_url":"https://api.github.com/users/gdetrez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gdetrez/subscriptions","organizations_url":"https://api.github.com/users/gdetrez/orgs","repos_url":"https://api.github.com/users/gdetrez/repos","events_url":"https://api.github.com/users/gdetrez/events{/privacy}","received_events_url":"https://api.github.com/users/gdetrez/received_events","type":"User","site_admin":false},"body":"- Use bootstrap inline form to arrange the select and the button\r\n- Add a \"degree of polynomial\" label\r\n- pass the selected degree to the api\r\n- available values are 1 to 5 but that's easy to change\r\n","created_at":"2017-11-24T14:04:44Z","updated_at":"2017-11-27T08:31:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cbcd2f8a1b9e8348af474a7638bf771411ceaa6f","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic/pulls/229/commits","review_comments_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic/pulls/229/comments","review_comment_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic/issues/229/comments","statuses_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic/statuses/3d1502c1b3b3335c8782b27cb67230c777cdd307","head":{"label":"gdetrez:polynomial-degree","ref":"polynomial-degree","sha":"3d1502c1b3b3335c8782b27cb67230c777cdd307","user":{"login":"gdetrez","id":38019,"avatar_url":"https://avatars2.githubusercontent.com/u/38019?v=4","gravatar_id":"","url":"https://api.github.com/users/gdetrez","html_url":"https://github.com/gdetrez","followers_url":"https://api.github.com/users/gdetrez/followers","following_url":"https://api.github.com/users/gdetrez/following{/other_user}","gists_url":"https://api.github.com/users/gdetrez/gists{/gist_id}","starred_url":"https://api.github.com/users/gdetrez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gdetrez/subscriptions","organizations_url":"https://api.github.com/users/gdetrez/orgs","repos_url":"https://api.github.com/users/gdetrez/repos","events_url":"https://api.github.com/users/gdetrez/events{/privacy}","received_events_url":"https://api.github.com/users/gdetrez/received_events","type":"User","site_admin":false},"repo":{"id":93157275,"name":"scanomatic","full_name":"gdetrez/scanomatic","owner":{"login":"gdetrez","id":38019,"avatar_url":"https://avatars2.githubusercontent.com/u/38019?v=4","gravatar_id":"","url":"https://api.github.com/users/gdetrez","html_url":"https://github.com/gdetrez","followers_url":"https://api.github.com/users/gdetrez/followers","following_url":"https://api.github.com/users/gdetrez/following{/other_user}","gists_url":"https://api.github.com/users/gdetrez/gists{/gist_id}","starred_url":"https://api.github.com/users/gdetrez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gdetrez/subscriptions","organizations_url":"https://api.github.com/users/gdetrez/orgs","repos_url":"https://api.github.com/users/gdetrez/repos","events_url":"https://api.github.com/users/gdetrez/events{/privacy}","received_events_url":"https://api.github.com/users/gdetrez/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gdetrez/scanomatic","description":"Scanomatic","fork":true,"url":"https://api.github.com/repos/gdetrez/scanomatic","forks_url":"https://api.github.com/repos/gdetrez/scanomatic/forks","keys_url":"https://api.github.com/repos/gdetrez/scanomatic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gdetrez/scanomatic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gdetrez/scanomatic/teams","hooks_url":"https://api.github.com/repos/gdetrez/scanomatic/hooks","issue_events_url":"https://api.github.com/repos/gdetrez/scanomatic/issues/events{/number}","events_url":"https://api.github.com/repos/gdetrez/scanomatic/events","assignees_url":"https://api.github.com/repos/gdetrez/scanomatic/assignees{/user}","branches_url":"https://api.github.com/repos/gdetrez/scanomatic/branches{/branch}","tags_url":"https://api.github.com/repos/gdetrez/scanomatic/tags","blobs_url":"https://api.github.com/repos/gdetrez/scanomatic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gdetrez/scanomatic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gdetrez/scanomatic/git/refs{/sha}","trees_url":"https://api.github.com/repos/gdetrez/scanomatic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gdetrez/scanomatic/statuses/{sha}","languages_url":"https://api.github.com/repos/gdetrez/scanomatic/languages","stargazers_url":"https://api.github.com/repos/gdetrez/scanomatic/stargazers","contributors_url":"https://api.github.com/repos/gdetrez/scanomatic/contributors","subscribers_url":"https://api.github.com/repos/gdetrez/scanomatic/subscribers","subscription_url":"https://api.github.com/repos/gdetrez/scanomatic/subscription","commits_url":"https://api.github.com/repos/gdetrez/scanomatic/commits{/sha}","git_commits_url":"https://api.github.com/repos/gdetrez/scanomatic/git/commits{/sha}","comments_url":"https://api.github.com/repos/gdetrez/scanomatic/comments{/number}","issue_comment_url":"https://api.github.com/repos/gdetrez/scanomatic/issues/comments{/number}","contents_url":"https://api.github.com/repos/gdetrez/scanomatic/contents/{+path}","compare_url":"https://api.github.com/repos/gdetrez/scanomatic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gdetrez/scanomatic/merges","archive_url":"https://api.github.com/repos/gdetrez/scanomatic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gdetrez/scanomatic/downloads","issues_url":"https://api.github.com/repos/gdetrez/scanomatic/issues{/number}","pulls_url":"https://api.github.com/repos/gdetrez/scanomatic/pulls{/number}","milestones_url":"https://api.github.com/repos/gdetrez/scanomatic/milestones{/number}","notifications_url":"https://api.github.com/repos/gdetrez/scanomatic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gdetrez/scanomatic/labels{/name}","releases_url":"https://api.github.com/repos/gdetrez/scanomatic/releases{/id}","deployments_url":"https://api.github.com/repos/gdetrez/scanomatic/deployments","created_at":"2017-06-02T10:59:28Z","updated_at":"2017-06-02T10:59:30Z","pushed_at":"2017-11-24T16:19:16Z","git_url":"git://github.com/gdetrez/scanomatic.git","ssh_url":"git@github.com:gdetrez/scanomatic.git","clone_url":"https://github.com/gdetrez/scanomatic.git","svn_url":"https://github.com/gdetrez/scanomatic","homepage":null,"size":40601,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Scan-o-Matic:master","ref":"master","sha":"98207ba80163acc47dddc9a46a0c3348d3c1e931","user":{"login":"Scan-o-Matic","id":29565481,"avatar_url":"https://avatars2.githubusercontent.com/u/29565481?v=4","gravatar_id":"","url":"https://api.github.com/users/Scan-o-Matic","html_url":"https://github.com/Scan-o-Matic","followers_url":"https://api.github.com/users/Scan-o-Matic/followers","following_url":"https://api.github.com/users/Scan-o-Matic/following{/other_user}","gists_url":"https://api.github.com/users/Scan-o-Matic/gists{/gist_id}","starred_url":"https://api.github.com/users/Scan-o-Matic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Scan-o-Matic/subscriptions","organizations_url":"https://api.github.com/users/Scan-o-Matic/orgs","repos_url":"https://api.github.com/users/Scan-o-Matic/repos","events_url":"https://api.github.com/users/Scan-o-Matic/events{/privacy}","received_events_url":"https://api.github.com/users/Scan-o-Matic/received_events","type":"Organization","site_admin":false},"repo":{"id":33122681,"name":"scanomatic","full_name":"Scan-o-Matic/scanomatic","owner":{"login":"Scan-o-Matic","id":29565481,"avatar_url":"https://avatars2.githubusercontent.com/u/29565481?v=4","gravatar_id":"","url":"https://api.github.com/users/Scan-o-Matic","html_url":"https://github.com/Scan-o-Matic","followers_url":"https://api.github.com/users/Scan-o-Matic/followers","following_url":"https://api.github.com/users/Scan-o-Matic/following{/other_user}","gists_url":"https://api.github.com/users/Scan-o-Matic/gists{/gist_id}","starred_url":"https://api.github.com/users/Scan-o-Matic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Scan-o-Matic/subscriptions","organizations_url":"https://api.github.com/users/Scan-o-Matic/orgs","repos_url":"https://api.github.com/users/Scan-o-Matic/repos","events_url":"https://api.github.com/users/Scan-o-Matic/events{/privacy}","received_events_url":"https://api.github.com/users/Scan-o-Matic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Scan-o-Matic/scanomatic","description":"Scanomatic","fork":false,"url":"https://api.github.com/repos/Scan-o-Matic/scanomatic","forks_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic/forks","keys_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic/teams","hooks_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic/hooks","issue_events_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic/issues/events{/number}","events_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic/events","assignees_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic/assignees{/user}","branches_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic/branches{/branch}","tags_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic/tags","blobs_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic/git/refs{/sha}","trees_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic/statuses/{sha}","languages_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic/languages","stargazers_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic/stargazers","contributors_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic/contributors","subscribers_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic/subscribers","subscription_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic/subscription","commits_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic/commits{/sha}","git_commits_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic/git/commits{/sha}","comments_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic/comments{/number}","issue_comment_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic/issues/comments{/number}","contents_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic/contents/{+path}","compare_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic/merges","archive_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic/downloads","issues_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic/issues{/number}","pulls_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic/pulls{/number}","milestones_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic/milestones{/number}","notifications_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic/labels{/name}","releases_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic/releases{/id}","deployments_url":"https://api.github.com/repos/Scan-o-Matic/scanomatic/deployments","created_at":"2015-03-30T12:48:19Z","updated_at":"2017-09-22T12:23:55Z","pushed_at":"2017-11-24T14:04:45Z","git_url":"git://github.com/Scan-o-Matic/scanomatic.git","ssh_url":"git@github.com:Scan-o-Matic/scanomatic.git","clone_url":"https://github.com/Scan-o-Matic/scanomatic.git","svn_url":"https://github.com/Scan-o-Matic/scanomatic","homepage":null,"size":41294,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":28,"forks":3,"open_issues":28,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Scan-o-Matic/scanomatic/pulls/229"},"html":{"href":"https://github.com/Scan-o-Matic/scanomatic/pull/229"},"issue":{"href":"https://api.github.com/repos/Scan-o-Matic/scanomatic/issues/229"},"comments":{"href":"https://api.github.com/repos/Scan-o-Matic/scanomatic/issues/229/comments"},"review_comments":{"href":"https://api.github.com/repos/Scan-o-Matic/scanomatic/pulls/229/comments"},"review_comment":{"href":"https://api.github.com/repos/Scan-o-Matic/scanomatic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Scan-o-Matic/scanomatic/pulls/229/commits"},"statuses":{"href":"https://api.github.com/repos/Scan-o-Matic/scanomatic/statuses/3d1502c1b3b3335c8782b27cb67230c777cdd307"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"local-minimum"}}