{"action":"created","comment":{"url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/pulls/comments/121932006","pull_request_review_id":43999243,"id":121932006,"diff_hunk":"@@ -0,0 +1,52 @@\n+/*global JSON: false, angular: false */\n+","path":"content/src/main/content/jcr_root/apps/acs-commons/components/utilities/qr-code-generator/clientlibs/js/script.js","position":2,"original_position":2,"commit_id":"b274515b0e716020eb90f3968bcd4848e30c8d2e","original_commit_id":"b274515b0e716020eb90f3968bcd4848e30c8d2e","user":{"login":"davidjgonzalez","id":1451868,"avatar_url":"https://avatars0.githubusercontent.com/u/1451868?v=3","gravatar_id":"","url":"https://api.github.com/users/davidjgonzalez","html_url":"https://github.com/davidjgonzalez","followers_url":"https://api.github.com/users/davidjgonzalez/followers","following_url":"https://api.github.com/users/davidjgonzalez/following{/other_user}","gists_url":"https://api.github.com/users/davidjgonzalez/gists{/gist_id}","starred_url":"https://api.github.com/users/davidjgonzalez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidjgonzalez/subscriptions","organizations_url":"https://api.github.com/users/davidjgonzalez/orgs","repos_url":"https://api.github.com/users/davidjgonzalez/repos","events_url":"https://api.github.com/users/davidjgonzalez/events{/privacy}","received_events_url":"https://api.github.com/users/davidjgonzalez/received_events","type":"User","site_admin":false},"body":"could this all be wrapped in an anonymous namespace? doubt well collide with another `qrCode` var, but its within the real of possibility\r\n\r\n`$(function() { .... the contents of script.js });`","created_at":"2017-06-14T12:30:06Z","updated_at":"2017-06-14T12:33:03Z","html_url":"https://github.com/Adobe-Consulting-Services/acs-aem-commons/pull/1017#discussion_r121932006","pull_request_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/pulls/1017","_links":{"self":{"href":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/pulls/comments/121932006"},"html":{"href":"https://github.com/Adobe-Consulting-Services/acs-aem-commons/pull/1017#discussion_r121932006"},"pull_request":{"href":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/pulls/1017"}}},"pull_request":{"url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/pulls/1017","id":124200264,"html_url":"https://github.com/Adobe-Consulting-Services/acs-aem-commons/pull/1017","diff_url":"https://github.com/Adobe-Consulting-Services/acs-aem-commons/pull/1017.diff","patch_url":"https://github.com/Adobe-Consulting-Services/acs-aem-commons/pull/1017.patch","issue_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/issues/1017","number":1017,"state":"open","locked":false,"title":"QR Code for an AEM Page URL","user":{"login":"edubey1","id":6499027,"avatar_url":"https://avatars2.githubusercontent.com/u/6499027?v=3","gravatar_id":"","url":"https://api.github.com/users/edubey1","html_url":"https://github.com/edubey1","followers_url":"https://api.github.com/users/edubey1/followers","following_url":"https://api.github.com/users/edubey1/following{/other_user}","gists_url":"https://api.github.com/users/edubey1/gists{/gist_id}","starred_url":"https://api.github.com/users/edubey1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edubey1/subscriptions","organizations_url":"https://api.github.com/users/edubey1/orgs","repos_url":"https://api.github.com/users/edubey1/repos","events_url":"https://api.github.com/users/edubey1/events{/privacy}","received_events_url":"https://api.github.com/users/edubey1/received_events","type":"User","site_admin":false},"body":"Hi,\r\n\r\nIt provides a feature to get the QR Code of page user in authoring. It can be enabled / disabled and configured from ACS Commons configuration page.\r\nI have moved it from ACS tools to ACS commons, \r\n@davidjgonzalez  please review it.","created_at":"2017-06-06T14:10:18Z","updated_at":"2017-06-14T12:33:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"459715fcc410989ae4f9cddcdb52a06f7d64730c","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/pulls/1017/commits","review_comments_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/pulls/1017/comments","review_comment_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/issues/1017/comments","statuses_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/statuses/b274515b0e716020eb90f3968bcd4848e30c8d2e","head":{"label":"edubey1:feature/qrcode","ref":"feature/qrcode","sha":"b274515b0e716020eb90f3968bcd4848e30c8d2e","user":{"login":"edubey1","id":6499027,"avatar_url":"https://avatars2.githubusercontent.com/u/6499027?v=3","gravatar_id":"","url":"https://api.github.com/users/edubey1","html_url":"https://github.com/edubey1","followers_url":"https://api.github.com/users/edubey1/followers","following_url":"https://api.github.com/users/edubey1/following{/other_user}","gists_url":"https://api.github.com/users/edubey1/gists{/gist_id}","starred_url":"https://api.github.com/users/edubey1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edubey1/subscriptions","organizations_url":"https://api.github.com/users/edubey1/orgs","repos_url":"https://api.github.com/users/edubey1/repos","events_url":"https://api.github.com/users/edubey1/events{/privacy}","received_events_url":"https://api.github.com/users/edubey1/received_events","type":"User","site_admin":false},"repo":{"id":93482941,"name":"acs-aem-commons","full_name":"edubey1/acs-aem-commons","owner":{"login":"edubey1","id":6499027,"avatar_url":"https://avatars2.githubusercontent.com/u/6499027?v=3","gravatar_id":"","url":"https://api.github.com/users/edubey1","html_url":"https://github.com/edubey1","followers_url":"https://api.github.com/users/edubey1/followers","following_url":"https://api.github.com/users/edubey1/following{/other_user}","gists_url":"https://api.github.com/users/edubey1/gists{/gist_id}","starred_url":"https://api.github.com/users/edubey1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edubey1/subscriptions","organizations_url":"https://api.github.com/users/edubey1/orgs","repos_url":"https://api.github.com/users/edubey1/repos","events_url":"https://api.github.com/users/edubey1/events{/privacy}","received_events_url":"https://api.github.com/users/edubey1/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/edubey1/acs-aem-commons","description":null,"fork":true,"url":"https://api.github.com/repos/edubey1/acs-aem-commons","forks_url":"https://api.github.com/repos/edubey1/acs-aem-commons/forks","keys_url":"https://api.github.com/repos/edubey1/acs-aem-commons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edubey1/acs-aem-commons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edubey1/acs-aem-commons/teams","hooks_url":"https://api.github.com/repos/edubey1/acs-aem-commons/hooks","issue_events_url":"https://api.github.com/repos/edubey1/acs-aem-commons/issues/events{/number}","events_url":"https://api.github.com/repos/edubey1/acs-aem-commons/events","assignees_url":"https://api.github.com/repos/edubey1/acs-aem-commons/assignees{/user}","branches_url":"https://api.github.com/repos/edubey1/acs-aem-commons/branches{/branch}","tags_url":"https://api.github.com/repos/edubey1/acs-aem-commons/tags","blobs_url":"https://api.github.com/repos/edubey1/acs-aem-commons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edubey1/acs-aem-commons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edubey1/acs-aem-commons/git/refs{/sha}","trees_url":"https://api.github.com/repos/edubey1/acs-aem-commons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edubey1/acs-aem-commons/statuses/{sha}","languages_url":"https://api.github.com/repos/edubey1/acs-aem-commons/languages","stargazers_url":"https://api.github.com/repos/edubey1/acs-aem-commons/stargazers","contributors_url":"https://api.github.com/repos/edubey1/acs-aem-commons/contributors","subscribers_url":"https://api.github.com/repos/edubey1/acs-aem-commons/subscribers","subscription_url":"https://api.github.com/repos/edubey1/acs-aem-commons/subscription","commits_url":"https://api.github.com/repos/edubey1/acs-aem-commons/commits{/sha}","git_commits_url":"https://api.github.com/repos/edubey1/acs-aem-commons/git/commits{/sha}","comments_url":"https://api.github.com/repos/edubey1/acs-aem-commons/comments{/number}","issue_comment_url":"https://api.github.com/repos/edubey1/acs-aem-commons/issues/comments{/number}","contents_url":"https://api.github.com/repos/edubey1/acs-aem-commons/contents/{+path}","compare_url":"https://api.github.com/repos/edubey1/acs-aem-commons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edubey1/acs-aem-commons/merges","archive_url":"https://api.github.com/repos/edubey1/acs-aem-commons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edubey1/acs-aem-commons/downloads","issues_url":"https://api.github.com/repos/edubey1/acs-aem-commons/issues{/number}","pulls_url":"https://api.github.com/repos/edubey1/acs-aem-commons/pulls{/number}","milestones_url":"https://api.github.com/repos/edubey1/acs-aem-commons/milestones{/number}","notifications_url":"https://api.github.com/repos/edubey1/acs-aem-commons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edubey1/acs-aem-commons/labels{/name}","releases_url":"https://api.github.com/repos/edubey1/acs-aem-commons/releases{/id}","deployments_url":"https://api.github.com/repos/edubey1/acs-aem-commons/deployments","created_at":"2017-06-06T06:15:26Z","updated_at":"2017-06-06T06:15:31Z","pushed_at":"2017-06-06T09:18:15Z","git_url":"git://github.com/edubey1/acs-aem-commons.git","ssh_url":"git@github.com:edubey1/acs-aem-commons.git","clone_url":"https://github.com/edubey1/acs-aem-commons.git","svn_url":"https://github.com/edubey1/acs-aem-commons","homepage":"http://adobe-consulting-services.github.io/acs-aem-commons/","size":12747,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Adobe-Consulting-Services:master","ref":"master","sha":"dc491d8392ac3341396e420b1dddd7bac7d56224","user":{"login":"Adobe-Consulting-Services","id":5420974,"avatar_url":"https://avatars1.githubusercontent.com/u/5420974?v=3","gravatar_id":"","url":"https://api.github.com/users/Adobe-Consulting-Services","html_url":"https://github.com/Adobe-Consulting-Services","followers_url":"https://api.github.com/users/Adobe-Consulting-Services/followers","following_url":"https://api.github.com/users/Adobe-Consulting-Services/following{/other_user}","gists_url":"https://api.github.com/users/Adobe-Consulting-Services/gists{/gist_id}","starred_url":"https://api.github.com/users/Adobe-Consulting-Services/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Adobe-Consulting-Services/subscriptions","organizations_url":"https://api.github.com/users/Adobe-Consulting-Services/orgs","repos_url":"https://api.github.com/users/Adobe-Consulting-Services/repos","events_url":"https://api.github.com/users/Adobe-Consulting-Services/events{/privacy}","received_events_url":"https://api.github.com/users/Adobe-Consulting-Services/received_events","type":"Organization","site_admin":false},"repo":{"id":13325401,"name":"acs-aem-commons","full_name":"Adobe-Consulting-Services/acs-aem-commons","owner":{"login":"Adobe-Consulting-Services","id":5420974,"avatar_url":"https://avatars1.githubusercontent.com/u/5420974?v=3","gravatar_id":"","url":"https://api.github.com/users/Adobe-Consulting-Services","html_url":"https://github.com/Adobe-Consulting-Services","followers_url":"https://api.github.com/users/Adobe-Consulting-Services/followers","following_url":"https://api.github.com/users/Adobe-Consulting-Services/following{/other_user}","gists_url":"https://api.github.com/users/Adobe-Consulting-Services/gists{/gist_id}","starred_url":"https://api.github.com/users/Adobe-Consulting-Services/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Adobe-Consulting-Services/subscriptions","organizations_url":"https://api.github.com/users/Adobe-Consulting-Services/orgs","repos_url":"https://api.github.com/users/Adobe-Consulting-Services/repos","events_url":"https://api.github.com/users/Adobe-Consulting-Services/events{/privacy}","received_events_url":"https://api.github.com/users/Adobe-Consulting-Services/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Adobe-Consulting-Services/acs-aem-commons","description":null,"fork":false,"url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons","forks_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/forks","keys_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/teams","hooks_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/hooks","issue_events_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/issues/events{/number}","events_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/events","assignees_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/assignees{/user}","branches_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/branches{/branch}","tags_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/tags","blobs_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/git/refs{/sha}","trees_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/statuses/{sha}","languages_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/languages","stargazers_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/stargazers","contributors_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/contributors","subscribers_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/subscribers","subscription_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/subscription","commits_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/commits{/sha}","git_commits_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/git/commits{/sha}","comments_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/comments{/number}","issue_comment_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/issues/comments{/number}","contents_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/contents/{+path}","compare_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/merges","archive_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/downloads","issues_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/issues{/number}","pulls_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/pulls{/number}","milestones_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/milestones{/number}","notifications_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/labels{/name}","releases_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/releases{/id}","deployments_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/deployments","created_at":"2013-10-04T13:50:05Z","updated_at":"2017-06-05T18:59:19Z","pushed_at":"2017-06-13T09:02:40Z","git_url":"git://github.com/Adobe-Consulting-Services/acs-aem-commons.git","ssh_url":"git@github.com:Adobe-Consulting-Services/acs-aem-commons.git","clone_url":"https://github.com/Adobe-Consulting-Services/acs-aem-commons.git","svn_url":"https://github.com/Adobe-Consulting-Services/acs-aem-commons","homepage":"http://adobe-consulting-services.github.io/acs-aem-commons/","size":12733,"stargazers_count":217,"watchers_count":217,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":265,"mirror_url":null,"open_issues_count":160,"forks":265,"open_issues":160,"watchers":217,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/pulls/1017"},"html":{"href":"https://github.com/Adobe-Consulting-Services/acs-aem-commons/pull/1017"},"issue":{"href":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/issues/1017"},"comments":{"href":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/issues/1017/comments"},"review_comments":{"href":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/pulls/1017/comments"},"review_comment":{"href":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/pulls/1017/commits"},"statuses":{"href":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/statuses/b274515b0e716020eb90f3968bcd4848e30c8d2e"}}}}
{"actor":{"display_login":"davidjgonzalez"}}