{"action":"created","issue":{"url":"https://api.github.com/repos/nilearn/nilearn/issues/1536","repository_url":"https://api.github.com/repos/nilearn/nilearn","labels_url":"https://api.github.com/repos/nilearn/nilearn/issues/1536/labels{/name}","comments_url":"https://api.github.com/repos/nilearn/nilearn/issues/1536/comments","events_url":"https://api.github.com/repos/nilearn/nilearn/issues/1536/events","html_url":"https://github.com/nilearn/nilearn/pull/1536","id":270956870,"number":1536,"title":"ENH: Refactor & Documentation in Decomposition module","user":{"login":"KamalakerDadi","id":11410385,"avatar_url":"https://avatars2.githubusercontent.com/u/11410385?v=4","gravatar_id":"","url":"https://api.github.com/users/KamalakerDadi","html_url":"https://github.com/KamalakerDadi","followers_url":"https://api.github.com/users/KamalakerDadi/followers","following_url":"https://api.github.com/users/KamalakerDadi/following{/other_user}","gists_url":"https://api.github.com/users/KamalakerDadi/gists{/gist_id}","starred_url":"https://api.github.com/users/KamalakerDadi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KamalakerDadi/subscriptions","organizations_url":"https://api.github.com/users/KamalakerDadi/orgs","repos_url":"https://api.github.com/users/KamalakerDadi/repos","events_url":"https://api.github.com/users/KamalakerDadi/events{/privacy}","received_events_url":"https://api.github.com/users/KamalakerDadi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-11-03T12:06:28Z","updated_at":"2017-11-06T16:18:20Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/nilearn/nilearn/pulls/1536","html_url":"https://github.com/nilearn/nilearn/pull/1536","diff_url":"https://github.com/nilearn/nilearn/pull/1536.diff","patch_url":"https://github.com/nilearn/nilearn/pull/1536.patch"},"body":" - Made ```fit()``` usable from BaseDecomposition module for all decomposition estimators.\r\n- This ```fit()``` can also be adapted to Parcellations object which is almost in ready in PR #1370 \r\n- Added documentation for missing attributes in ```CanICA``` and ```DictLearning```.\r\n- Added documentation for ```Returns``` in ```BaseDecomposition``` ```fit()```.\r\n\r\nCan I have your opinions on this ?"},"comment":{"url":"https://api.github.com/repos/nilearn/nilearn/issues/comments/342200165","html_url":"https://github.com/nilearn/nilearn/pull/1536#issuecomment-342200165","issue_url":"https://api.github.com/repos/nilearn/nilearn/issues/1536","id":342200165,"user":{"login":"GaelVaroquaux","id":208217,"avatar_url":"https://avatars3.githubusercontent.com/u/208217?v=4","gravatar_id":"","url":"https://api.github.com/users/GaelVaroquaux","html_url":"https://github.com/GaelVaroquaux","followers_url":"https://api.github.com/users/GaelVaroquaux/followers","following_url":"https://api.github.com/users/GaelVaroquaux/following{/other_user}","gists_url":"https://api.github.com/users/GaelVaroquaux/gists{/gist_id}","starred_url":"https://api.github.com/users/GaelVaroquaux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GaelVaroquaux/subscriptions","organizations_url":"https://api.github.com/users/GaelVaroquaux/orgs","repos_url":"https://api.github.com/users/GaelVaroquaux/repos","events_url":"https://api.github.com/users/GaelVaroquaux/events{/privacy}","received_events_url":"https://api.github.com/users/GaelVaroquaux/received_events","type":"User","site_admin":false},"created_at":"2017-11-06T16:18:20Z","updated_at":"2017-11-06T16:18:20Z","author_association":"CONTRIBUTOR","body":"> tests will fail because BaseDecomposition has no _raw_fit method implemented.\n\nDo tests run BaseDecomposition.fit? They shouldn't\n"}}
{"actor":{"display_login":"GaelVaroquaux"}}