{"action":"created","comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/141166057","pull_request_review_id":65341105,"id":141166057,"diff_hunk":"@@ -47,18 +45,18 @@ friend struct InputChunk;\n \n public:\n   explicit FedRawDataInputSource(edm::ParameterSet const&,edm::InputSourceDescription const&);\n-  virtual ~FedRawDataInputSource();\n+  ~FedRawDataInputSource() override;\n   static void fillDescriptions(edm::ConfigurationDescriptions& descriptions);\n \n   std::pair<bool,unsigned int> getEventReport(unsigned int lumi, bool erase);\n protected:\n-  virtual bool checkNextEvent() override;\n-  virtual void read(edm::EventPrincipal& eventPrincipal) override;\n+  bool checkNextEvent() override;\n+  void read(edm::EventPrincipal& eventPrincipal) override;\n \n private:\n-  virtual void preForkReleaseResources() override;\n-  virtual void postForkReacquireResources(std::shared_ptr<edm::multicore::MessageReceiverForSource>) override;\n-  virtual void rewind_() override;\n+  void preForkReleaseResources() override;\n+  void postForkReacquireResources(std::shared_ptr<edm::multicore::MessageReceiverForSource>) override;","path":"EventFilter/Utilities/interface/FedRawDataInputSource.h","position":38,"original_position":38,"commit_id":"40cf84a3dd5435d9efd520338a6921dd10063d91","original_commit_id":"40cf84a3dd5435d9efd520338a6921dd10063d91","user":{"login":"perrotta","id":4069749,"avatar_url":"https://avatars1.githubusercontent.com/u/4069749?v=4","gravatar_id":"","url":"https://api.github.com/users/perrotta","html_url":"https://github.com/perrotta","followers_url":"https://api.github.com/users/perrotta/followers","following_url":"https://api.github.com/users/perrotta/following{/other_user}","gists_url":"https://api.github.com/users/perrotta/gists{/gist_id}","starred_url":"https://api.github.com/users/perrotta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/perrotta/subscriptions","organizations_url":"https://api.github.com/users/perrotta/orgs","repos_url":"https://api.github.com/users/perrotta/repos","events_url":"https://api.github.com/users/perrotta/events{/privacy}","received_events_url":"https://api.github.com/users/perrotta/received_events","type":"User","site_admin":false},"body":"This method is not there in 94X: is it correct to have it here? Or, alternatively, to have it removed in 94X?","created_at":"2017-09-26T19:56:40Z","updated_at":"2017-09-26T19:57:13Z","html_url":"https://github.com/cms-sw/cmssw/pull/20513#discussion_r141166057","pull_request_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/20513","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/141166057"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/20513#discussion_r141166057"},"pull_request":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/20513"}}},"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/20513","id":141068956,"html_url":"https://github.com/cms-sw/cmssw/pull/20513","diff_url":"https://github.com/cms-sw/cmssw/pull/20513.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/20513.patch","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/20513","number":20513,"state":"open","locked":false,"title":"Persist TCDS FED payload - Version of 9_2_X","user":{"login":"mommsen","id":4116620,"avatar_url":"https://avatars2.githubusercontent.com/u/4116620?v=4","gravatar_id":"","url":"https://api.github.com/users/mommsen","html_url":"https://github.com/mommsen","followers_url":"https://api.github.com/users/mommsen/followers","following_url":"https://api.github.com/users/mommsen/following{/other_user}","gists_url":"https://api.github.com/users/mommsen/gists{/gist_id}","starred_url":"https://api.github.com/users/mommsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mommsen/subscriptions","organizations_url":"https://api.github.com/users/mommsen/orgs","repos_url":"https://api.github.com/users/mommsen/repos","events_url":"https://api.github.com/users/mommsen/events{/privacy}","received_events_url":"https://api.github.com/users/mommsen/received_events","type":"User","site_admin":false},"body":"This pull request provides a proper unpacker for the TCDS payload and persists the relevant quantities from the TCDS FED in the TCDSRecord. This code resides in a new package DataFormats/TCDS. It replaces the FED1024 class which exposes direct access to the underlying data structure, and incorporates the separate BSTRecord. I also changed the code using the old accessors to the new ones, as far as I could find them. In addition, the EventAuxiliary is now filled with the current fill (store) number instead of 'edm::EventAuxiliary::invalidStoreNumber'.\r\n\r\nThis PR corresponds to PR #20471, but targets the 9_2_X release cycle.","created_at":"2017-09-14T13:04:44Z","updated_at":"2017-09-26T19:57:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2e9449df4a793996b8afa7993ad7599ba9e19891","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/66","html_url":"https://github.com/cms-sw/cmssw/milestone/66","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/66/labels","id":2497352,"number":66,"title":"CMSSW_9_2_X","description":"","creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars3.githubusercontent.com/u/4115138?v=4","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":55,"closed_issues":853,"state":"open","created_at":"2017-05-03T13:18:43Z","updated_at":"2017-09-25T17:05:50Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/20513/commits","review_comments_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/20513/comments","review_comment_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/20513/comments","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/40cf84a3dd5435d9efd520338a6921dd10063d91","head":{"label":"mommsen:TCDSunpacker_92X","ref":"TCDSunpacker_92X","sha":"40cf84a3dd5435d9efd520338a6921dd10063d91","user":{"login":"mommsen","id":4116620,"avatar_url":"https://avatars2.githubusercontent.com/u/4116620?v=4","gravatar_id":"","url":"https://api.github.com/users/mommsen","html_url":"https://github.com/mommsen","followers_url":"https://api.github.com/users/mommsen/followers","following_url":"https://api.github.com/users/mommsen/following{/other_user}","gists_url":"https://api.github.com/users/mommsen/gists{/gist_id}","starred_url":"https://api.github.com/users/mommsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mommsen/subscriptions","organizations_url":"https://api.github.com/users/mommsen/orgs","repos_url":"https://api.github.com/users/mommsen/repos","events_url":"https://api.github.com/users/mommsen/events{/privacy}","received_events_url":"https://api.github.com/users/mommsen/received_events","type":"User","site_admin":false},"repo":{"id":15317256,"name":"cmssw","full_name":"mommsen/cmssw","owner":{"login":"mommsen","id":4116620,"avatar_url":"https://avatars2.githubusercontent.com/u/4116620?v=4","gravatar_id":"","url":"https://api.github.com/users/mommsen","html_url":"https://github.com/mommsen","followers_url":"https://api.github.com/users/mommsen/followers","following_url":"https://api.github.com/users/mommsen/following{/other_user}","gists_url":"https://api.github.com/users/mommsen/gists{/gist_id}","starred_url":"https://api.github.com/users/mommsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mommsen/subscriptions","organizations_url":"https://api.github.com/users/mommsen/orgs","repos_url":"https://api.github.com/users/mommsen/repos","events_url":"https://api.github.com/users/mommsen/events{/privacy}","received_events_url":"https://api.github.com/users/mommsen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mommsen/cmssw","description":"CMS Offline Software","fork":true,"url":"https://api.github.com/repos/mommsen/cmssw","forks_url":"https://api.github.com/repos/mommsen/cmssw/forks","keys_url":"https://api.github.com/repos/mommsen/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mommsen/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mommsen/cmssw/teams","hooks_url":"https://api.github.com/repos/mommsen/cmssw/hooks","issue_events_url":"https://api.github.com/repos/mommsen/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/mommsen/cmssw/events","assignees_url":"https://api.github.com/repos/mommsen/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/mommsen/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/mommsen/cmssw/tags","blobs_url":"https://api.github.com/repos/mommsen/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mommsen/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mommsen/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/mommsen/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mommsen/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/mommsen/cmssw/languages","stargazers_url":"https://api.github.com/repos/mommsen/cmssw/stargazers","contributors_url":"https://api.github.com/repos/mommsen/cmssw/contributors","subscribers_url":"https://api.github.com/repos/mommsen/cmssw/subscribers","subscription_url":"https://api.github.com/repos/mommsen/cmssw/subscription","commits_url":"https://api.github.com/repos/mommsen/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/mommsen/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/mommsen/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/mommsen/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/mommsen/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/mommsen/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mommsen/cmssw/merges","archive_url":"https://api.github.com/repos/mommsen/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mommsen/cmssw/downloads","issues_url":"https://api.github.com/repos/mommsen/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/mommsen/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/mommsen/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/mommsen/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mommsen/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/mommsen/cmssw/releases{/id}","deployments_url":"https://api.github.com/repos/mommsen/cmssw/deployments","created_at":"2013-12-19T16:49:01Z","updated_at":"2014-11-07T14:21:17Z","pushed_at":"2017-09-26T13:26:55Z","git_url":"git://github.com/mommsen/cmssw.git","ssh_url":"git@github.com:mommsen/cmssw.git","clone_url":"https://github.com/mommsen/cmssw.git","svn_url":"https://github.com/mommsen/cmssw","homepage":"cms-sw.github.io/cmssw","size":946561,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"CMSSW_9_3_X"}},"base":{"label":"cms-sw:CMSSW_9_2_X","ref":"CMSSW_9_2_X","sha":"46c23e1cb39d92935cf5b532617757fc8c5de9fa","user":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars0.githubusercontent.com/u/3863500?v=4","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"repo":{"id":10969551,"name":"cmssw","full_name":"cms-sw/cmssw","owner":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars0.githubusercontent.com/u/3863500?v=4","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cms-sw/cmssw","description":"CMS Offline Software","fork":false,"url":"https://api.github.com/repos/cms-sw/cmssw","forks_url":"https://api.github.com/repos/cms-sw/cmssw/forks","keys_url":"https://api.github.com/repos/cms-sw/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cms-sw/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cms-sw/cmssw/teams","hooks_url":"https://api.github.com/repos/cms-sw/cmssw/hooks","issue_events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/cms-sw/cmssw/events","assignees_url":"https://api.github.com/repos/cms-sw/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/cms-sw/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/cms-sw/cmssw/tags","blobs_url":"https://api.github.com/repos/cms-sw/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cms-sw/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cms-sw/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/cms-sw/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/cms-sw/cmssw/languages","stargazers_url":"https://api.github.com/repos/cms-sw/cmssw/stargazers","contributors_url":"https://api.github.com/repos/cms-sw/cmssw/contributors","subscribers_url":"https://api.github.com/repos/cms-sw/cmssw/subscribers","subscription_url":"https://api.github.com/repos/cms-sw/cmssw/subscription","commits_url":"https://api.github.com/repos/cms-sw/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/cms-sw/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/cms-sw/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/cms-sw/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cms-sw/cmssw/merges","archive_url":"https://api.github.com/repos/cms-sw/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cms-sw/cmssw/downloads","issues_url":"https://api.github.com/repos/cms-sw/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/cms-sw/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/cms-sw/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/cms-sw/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cms-sw/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/cms-sw/cmssw/releases{/id}","deployments_url":"https://api.github.com/repos/cms-sw/cmssw/deployments","created_at":"2013-06-26T14:09:07Z","updated_at":"2017-09-26T18:32:56Z","pushed_at":"2017-09-26T19:00:32Z","git_url":"git://github.com/cms-sw/cmssw.git","ssh_url":"git@github.com:cms-sw/cmssw.git","clone_url":"https://github.com/cms-sw/cmssw.git","svn_url":"https://github.com/cms-sw/cmssw","homepage":"http://cms-sw.github.io/","size":971556,"stargazers_count":442,"watchers_count":442,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2330,"mirror_url":null,"open_issues_count":426,"forks":2330,"open_issues":426,"watchers":442,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/20513"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/20513"},"issue":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/20513"},"comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/20513/comments"},"review_comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/20513/comments"},"review_comment":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/20513/commits"},"statuses":{"href":"https://api.github.com/repos/cms-sw/cmssw/statuses/40cf84a3dd5435d9efd520338a6921dd10063d91"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"perrotta"}}