{"action":"created","issue":{"url":"https://api.github.com/repos/spring-projects/spring-boot/issues/8099","repository_url":"https://api.github.com/repos/spring-projects/spring-boot","labels_url":"https://api.github.com/repos/spring-projects/spring-boot/issues/8099/labels{/name}","comments_url":"https://api.github.com/repos/spring-projects/spring-boot/issues/8099/comments","events_url":"https://api.github.com/repos/spring-projects/spring-boot/issues/8099/events","html_url":"https://github.com/spring-projects/spring-boot/issues/8099","id":202934670,"number":8099,"title":"bootRepackage up-to-date checks should work when configured inside the model block","user":{"login":"mkobit","id":1447148,"avatar_url":"https://avatars0.githubusercontent.com/u/1447148?v=3","gravatar_id":"","url":"https://api.github.com/users/mkobit","html_url":"https://github.com/mkobit","followers_url":"https://api.github.com/users/mkobit/followers","following_url":"https://api.github.com/users/mkobit/following{/other_user}","gists_url":"https://api.github.com/users/mkobit/gists{/gist_id}","starred_url":"https://api.github.com/users/mkobit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkobit/subscriptions","organizations_url":"https://api.github.com/users/mkobit/orgs","repos_url":"https://api.github.com/users/mkobit/repos","events_url":"https://api.github.com/users/mkobit/events{/privacy}","received_events_url":"https://api.github.com/users/mkobit/received_events","type":"User","site_admin":false},"labels":[{"id":514595556,"url":"https://api.github.com/repos/spring-projects/spring-boot/labels/priority:%20high","name":"priority: high","color":"c2e0c6","default":false},{"id":516339495,"url":"https://api.github.com/repos/spring-projects/spring-boot/labels/theme:%20gradle-plugin","name":"theme: gradle-plugin","color":"f9d0c4","default":false},{"id":16916893,"url":"https://api.github.com/repos/spring-projects/spring-boot/labels/type:%20enhancement","name":"type: enhancement","color":"d4c5f9","default":false}],"state":"open","locked":false,"assignee":{"login":"wilkinsona","id":914682,"avatar_url":"https://avatars0.githubusercontent.com/u/914682?v=3","gravatar_id":"","url":"https://api.github.com/users/wilkinsona","html_url":"https://github.com/wilkinsona","followers_url":"https://api.github.com/users/wilkinsona/followers","following_url":"https://api.github.com/users/wilkinsona/following{/other_user}","gists_url":"https://api.github.com/users/wilkinsona/gists{/gist_id}","starred_url":"https://api.github.com/users/wilkinsona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilkinsona/subscriptions","organizations_url":"https://api.github.com/users/wilkinsona/orgs","repos_url":"https://api.github.com/users/wilkinsona/repos","events_url":"https://api.github.com/users/wilkinsona/events{/privacy}","received_events_url":"https://api.github.com/users/wilkinsona/received_events","type":"User","site_admin":false},"assignees":[{"login":"wilkinsona","id":914682,"avatar_url":"https://avatars0.githubusercontent.com/u/914682?v=3","gravatar_id":"","url":"https://api.github.com/users/wilkinsona","html_url":"https://github.com/wilkinsona","followers_url":"https://api.github.com/users/wilkinsona/followers","following_url":"https://api.github.com/users/wilkinsona/following{/other_user}","gists_url":"https://api.github.com/users/wilkinsona/gists{/gist_id}","starred_url":"https://api.github.com/users/wilkinsona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilkinsona/subscriptions","organizations_url":"https://api.github.com/users/wilkinsona/orgs","repos_url":"https://api.github.com/users/wilkinsona/repos","events_url":"https://api.github.com/users/wilkinsona/events{/privacy}","received_events_url":"https://api.github.com/users/wilkinsona/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/spring-projects/spring-boot/milestones/53","html_url":"https://github.com/spring-projects/spring-boot/milestone/53","labels_url":"https://api.github.com/repos/spring-projects/spring-boot/milestones/53/labels","id":1489601,"number":53,"title":"2.0.0.M1","description":"","creator":{"login":"philwebb","id":519772,"avatar_url":"https://avatars2.githubusercontent.com/u/519772?v=3","gravatar_id":"","url":"https://api.github.com/users/philwebb","html_url":"https://github.com/philwebb","followers_url":"https://api.github.com/users/philwebb/followers","following_url":"https://api.github.com/users/philwebb/following{/other_user}","gists_url":"https://api.github.com/users/philwebb/gists{/gist_id}","starred_url":"https://api.github.com/users/philwebb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philwebb/subscriptions","organizations_url":"https://api.github.com/users/philwebb/orgs","repos_url":"https://api.github.com/users/philwebb/repos","events_url":"https://api.github.com/users/philwebb/events{/privacy}","received_events_url":"https://api.github.com/users/philwebb/received_events","type":"User","site_admin":false},"open_issues":52,"closed_issues":98,"state":"open","created_at":"2016-01-07T14:19:29Z","updated_at":"2017-03-11T15:49:44Z","due_on":"2017-04-06T07:00:00Z","closed_at":null},"comments":1,"created_at":"2017-01-24T20:43:46Z","updated_at":"2017-03-11T16:06:17Z","closed_at":null,"body":"Spring Boot Gradle plugin `1.4.2.RELEASE` does not correctly do `UP-TO-DATE` checks when configured in the `model` block.\r\n\r\nI expect that when `bootRepackage` is configured with the `model` that the second execution is `UP-TO-DATE`.\r\n\r\n### Example\r\n\r\n#### `UP-TO-DATE` when outside `model`\r\n\r\n```groovy\r\nplugins {\r\n  id 'org.springframework.boot' version '1.4.2.RELEASE'\r\n}\r\n\r\nbootRepackage {\r\n  classifier = 'myclassifier'\r\n  mainClass = 'MainClass`\r\n}\r\n```\r\n\r\nRunning `./gradlew build` with Gradle 3.3 results in the first build succeeding, second build skips tasks with `UP-TO-DATE`.\r\n\r\n#### `UP-TO-DATE` when inside `model`\r\n\r\n```groovy\r\nplugins {\r\n  id 'org.springframework.boot' version '1.4.2.RELEASE'\r\n}\r\n\r\nmodel {\r\n  bootRepackage {\r\n    classifier = 'myclassifier'\r\n    mainClass = 'MainClass`\r\n  }\r\n}\r\n```\r\n\r\nRunning `./gradlew build` with Gradle 3.3 results both `bootRepackage` executing."},"comment":{"url":"https://api.github.com/repos/spring-projects/spring-boot/issues/comments/285877458","html_url":"https://github.com/spring-projects/spring-boot/issues/8099#issuecomment-285877458","issue_url":"https://api.github.com/repos/spring-projects/spring-boot/issues/8099","id":285877458,"user":{"login":"wilkinsona","id":914682,"avatar_url":"https://avatars0.githubusercontent.com/u/914682?v=3","gravatar_id":"","url":"https://api.github.com/users/wilkinsona","html_url":"https://github.com/wilkinsona","followers_url":"https://api.github.com/users/wilkinsona/followers","following_url":"https://api.github.com/users/wilkinsona/following{/other_user}","gists_url":"https://api.github.com/users/wilkinsona/gists{/gist_id}","starred_url":"https://api.github.com/users/wilkinsona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilkinsona/subscriptions","organizations_url":"https://api.github.com/users/wilkinsona/orgs","repos_url":"https://api.github.com/users/wilkinsona/repos","events_url":"https://api.github.com/users/wilkinsona/events{/privacy}","received_events_url":"https://api.github.com/users/wilkinsona/received_events","type":"User","site_admin":false},"created_at":"2017-03-11T16:06:17Z","updated_at":"2017-03-11T16:06:17Z","body":"I can't reproduce this. The second example fails for me with Gradle 3.3 (and other versions too):\r\n\r\n```\r\n> The following model rules could not be applied due to unbound inputs and/or subjects:\r\n\r\n    bootRepackage { ... } @ build.gradle line 6, column 3\r\n      subject:\r\n        - bootRepackage Object [*]\r\n\r\n  [*] - indicates that a model item could not be found for the path or type.\r\n```\r\n\r\n`bootRepackage` is going to be replaced in #5861 with `bootJar` and `bootWar` tasks that are subclasses of Gradle's `Jar` and `War` tasks respectively so this should already have been taken care of.\r\n\r\n@mkobit that said, it would be nice to have a sample that can reproduce the problem you were seeing so that I can verify that it doesn't happen with the new tasks."}}
{"actor":{"display_login":"wilkinsona"}}