{"action":"created","comment":{"url":"https://api.github.com/repos/intel-analytics/BigDL/pulls/comments/151622901","pull_request_review_id":77361016,"id":151622901,"diff_hunk":"@@ -1099,11 +1383,11 @@ def to_bigdl_init(self, kinit_method): # kinit_method is a string\n \n     def to_bigdl_reg(self, reg):  # reg is a dict\n         if reg:\n-           raise Exception(\"will support reg very soon\")\n+            return BRegularizer(reg['l1'], reg['l2'])","path":"pyspark/bigdl/keras1/converter.py","position":640,"original_position":640,"commit_id":"f7139d64f4cea148b5ec3de4e700e0e32529b471","original_commit_id":"f7139d64f4cea148b5ec3de4e700e0e32529b471","user":{"login":"hkvision","id":21994046,"avatar_url":"https://avatars2.githubusercontent.com/u/21994046?v=4","gravatar_id":"","url":"https://api.github.com/users/hkvision","html_url":"https://github.com/hkvision","followers_url":"https://api.github.com/users/hkvision/followers","following_url":"https://api.github.com/users/hkvision/following{/other_user}","gists_url":"https://api.github.com/users/hkvision/gists{/gist_id}","starred_url":"https://api.github.com/users/hkvision/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hkvision/subscriptions","organizations_url":"https://api.github.com/users/hkvision/orgs","repos_url":"https://api.github.com/users/hkvision/repos","events_url":"https://api.github.com/users/hkvision/events{/privacy}","received_events_url":"https://api.github.com/users/hkvision/received_events","type":"User","site_admin":false},"body":"For the `reg` dict, if `l2` doesn't exist, it is `0`. In other words, no matter what regularizer passed in to a keras layer (l1, l2 or l1l2), in the dictionary, it will always have {l1: x; l2:y}. ","created_at":"2017-11-17T08:06:40Z","updated_at":"2017-11-17T08:06:40Z","html_url":"https://github.com/intel-analytics/BigDL/pull/1891#discussion_r151622901","pull_request_url":"https://api.github.com/repos/intel-analytics/BigDL/pulls/1891","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/intel-analytics/BigDL/pulls/comments/151622901"},"html":{"href":"https://github.com/intel-analytics/BigDL/pull/1891#discussion_r151622901"},"pull_request":{"href":"https://api.github.com/repos/intel-analytics/BigDL/pulls/1891"}},"in_reply_to_id":151620562},"pull_request":{"url":"https://api.github.com/repos/intel-analytics/BigDL/pulls/1891","id":152959628,"html_url":"https://github.com/intel-analytics/BigDL/pull/1891","diff_url":"https://github.com/intel-analytics/BigDL/pull/1891.diff","patch_url":"https://github.com/intel-analytics/BigDL/pull/1891.patch","issue_url":"https://api.github.com/repos/intel-analytics/BigDL/issues/1891","number":1891,"state":"open","locked":false,"title":"Add keras layers and test","user":{"login":"hkvision","id":21994046,"avatar_url":"https://avatars2.githubusercontent.com/u/21994046?v=4","gravatar_id":"","url":"https://api.github.com/users/hkvision","html_url":"https://github.com/hkvision","followers_url":"https://api.github.com/users/hkvision/followers","following_url":"https://api.github.com/users/hkvision/following{/other_user}","gists_url":"https://api.github.com/users/hkvision/gists{/gist_id}","starred_url":"https://api.github.com/users/hkvision/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hkvision/subscriptions","organizations_url":"https://api.github.com/users/hkvision/orgs","repos_url":"https://api.github.com/users/hkvision/repos","events_url":"https://api.github.com/users/hkvision/events{/privacy}","received_events_url":"https://api.github.com/users/hkvision/received_events","type":"User","site_admin":false},"body":"## What changes were proposed in this pull request?\r\n\r\nAdd keras layers and test\r\n\r\nSupport more keras layers:\r\natrousconvolution1d, atrousconvolution2d, deconvolution2d, convolution3d\r\npermute, merge-dot (update), maxpooling3d, globalmaxpooling3d\r\n\r\nNew layers: CAveTable -> merge ave; VolumetricAveragePooling -> AveragePooling3D & GlobalAveragePooling3D\r\n\r\nMore activations; Add regularizer.\r\n\r\nMinor update on code and doc. Add random weights for tests.\r\n\r\n## How was this patch tested?\r\n\r\nJenkins.\r\n\r\n","created_at":"2017-11-16T06:17:12Z","updated_at":"2017-11-17T08:06:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"deeeed3fccf5738c8dd5818d2e4351b4e1644f48","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/intel-analytics/BigDL/pulls/1891/commits","review_comments_url":"https://api.github.com/repos/intel-analytics/BigDL/pulls/1891/comments","review_comment_url":"https://api.github.com/repos/intel-analytics/BigDL/pulls/comments{/number}","comments_url":"https://api.github.com/repos/intel-analytics/BigDL/issues/1891/comments","statuses_url":"https://api.github.com/repos/intel-analytics/BigDL/statuses/f7139d64f4cea148b5ec3de4e700e0e32529b471","head":{"label":"hkvision:keras_support","ref":"keras_support","sha":"f7139d64f4cea148b5ec3de4e700e0e32529b471","user":{"login":"hkvision","id":21994046,"avatar_url":"https://avatars2.githubusercontent.com/u/21994046?v=4","gravatar_id":"","url":"https://api.github.com/users/hkvision","html_url":"https://github.com/hkvision","followers_url":"https://api.github.com/users/hkvision/followers","following_url":"https://api.github.com/users/hkvision/following{/other_user}","gists_url":"https://api.github.com/users/hkvision/gists{/gist_id}","starred_url":"https://api.github.com/users/hkvision/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hkvision/subscriptions","organizations_url":"https://api.github.com/users/hkvision/orgs","repos_url":"https://api.github.com/users/hkvision/repos","events_url":"https://api.github.com/users/hkvision/events{/privacy}","received_events_url":"https://api.github.com/users/hkvision/received_events","type":"User","site_admin":false},"repo":{"id":102826764,"name":"BigDL","full_name":"hkvision/BigDL","owner":{"login":"hkvision","id":21994046,"avatar_url":"https://avatars2.githubusercontent.com/u/21994046?v=4","gravatar_id":"","url":"https://api.github.com/users/hkvision","html_url":"https://github.com/hkvision","followers_url":"https://api.github.com/users/hkvision/followers","following_url":"https://api.github.com/users/hkvision/following{/other_user}","gists_url":"https://api.github.com/users/hkvision/gists{/gist_id}","starred_url":"https://api.github.com/users/hkvision/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hkvision/subscriptions","organizations_url":"https://api.github.com/users/hkvision/orgs","repos_url":"https://api.github.com/users/hkvision/repos","events_url":"https://api.github.com/users/hkvision/events{/privacy}","received_events_url":"https://api.github.com/users/hkvision/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hkvision/BigDL","description":"BigDL: Distributed Deep Learning Library for Apache Spark","fork":true,"url":"https://api.github.com/repos/hkvision/BigDL","forks_url":"https://api.github.com/repos/hkvision/BigDL/forks","keys_url":"https://api.github.com/repos/hkvision/BigDL/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hkvision/BigDL/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hkvision/BigDL/teams","hooks_url":"https://api.github.com/repos/hkvision/BigDL/hooks","issue_events_url":"https://api.github.com/repos/hkvision/BigDL/issues/events{/number}","events_url":"https://api.github.com/repos/hkvision/BigDL/events","assignees_url":"https://api.github.com/repos/hkvision/BigDL/assignees{/user}","branches_url":"https://api.github.com/repos/hkvision/BigDL/branches{/branch}","tags_url":"https://api.github.com/repos/hkvision/BigDL/tags","blobs_url":"https://api.github.com/repos/hkvision/BigDL/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hkvision/BigDL/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hkvision/BigDL/git/refs{/sha}","trees_url":"https://api.github.com/repos/hkvision/BigDL/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hkvision/BigDL/statuses/{sha}","languages_url":"https://api.github.com/repos/hkvision/BigDL/languages","stargazers_url":"https://api.github.com/repos/hkvision/BigDL/stargazers","contributors_url":"https://api.github.com/repos/hkvision/BigDL/contributors","subscribers_url":"https://api.github.com/repos/hkvision/BigDL/subscribers","subscription_url":"https://api.github.com/repos/hkvision/BigDL/subscription","commits_url":"https://api.github.com/repos/hkvision/BigDL/commits{/sha}","git_commits_url":"https://api.github.com/repos/hkvision/BigDL/git/commits{/sha}","comments_url":"https://api.github.com/repos/hkvision/BigDL/comments{/number}","issue_comment_url":"https://api.github.com/repos/hkvision/BigDL/issues/comments{/number}","contents_url":"https://api.github.com/repos/hkvision/BigDL/contents/{+path}","compare_url":"https://api.github.com/repos/hkvision/BigDL/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hkvision/BigDL/merges","archive_url":"https://api.github.com/repos/hkvision/BigDL/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hkvision/BigDL/downloads","issues_url":"https://api.github.com/repos/hkvision/BigDL/issues{/number}","pulls_url":"https://api.github.com/repos/hkvision/BigDL/pulls{/number}","milestones_url":"https://api.github.com/repos/hkvision/BigDL/milestones{/number}","notifications_url":"https://api.github.com/repos/hkvision/BigDL/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hkvision/BigDL/labels{/name}","releases_url":"https://api.github.com/repos/hkvision/BigDL/releases{/id}","deployments_url":"https://api.github.com/repos/hkvision/BigDL/deployments","created_at":"2017-09-08T06:36:00Z","updated_at":"2017-09-08T06:36:04Z","pushed_at":"2017-11-16T07:27:48Z","git_url":"git://github.com/hkvision/BigDL.git","ssh_url":"git@github.com:hkvision/BigDL.git","clone_url":"https://github.com/hkvision/BigDL.git","svn_url":"https://github.com/hkvision/BigDL","homepage":"https://bigdl-project.github.io/","size":76745,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"intel-analytics:master","ref":"master","sha":"6412bc805e684d4019a2a5bb93f7b7058d9e307f","user":{"login":"intel-analytics","id":10941215,"avatar_url":"https://avatars3.githubusercontent.com/u/10941215?v=4","gravatar_id":"","url":"https://api.github.com/users/intel-analytics","html_url":"https://github.com/intel-analytics","followers_url":"https://api.github.com/users/intel-analytics/followers","following_url":"https://api.github.com/users/intel-analytics/following{/other_user}","gists_url":"https://api.github.com/users/intel-analytics/gists{/gist_id}","starred_url":"https://api.github.com/users/intel-analytics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/intel-analytics/subscriptions","organizations_url":"https://api.github.com/users/intel-analytics/orgs","repos_url":"https://api.github.com/users/intel-analytics/repos","events_url":"https://api.github.com/users/intel-analytics/events{/privacy}","received_events_url":"https://api.github.com/users/intel-analytics/received_events","type":"Organization","site_admin":false},"repo":{"id":66823715,"name":"BigDL","full_name":"intel-analytics/BigDL","owner":{"login":"intel-analytics","id":10941215,"avatar_url":"https://avatars3.githubusercontent.com/u/10941215?v=4","gravatar_id":"","url":"https://api.github.com/users/intel-analytics","html_url":"https://github.com/intel-analytics","followers_url":"https://api.github.com/users/intel-analytics/followers","following_url":"https://api.github.com/users/intel-analytics/following{/other_user}","gists_url":"https://api.github.com/users/intel-analytics/gists{/gist_id}","starred_url":"https://api.github.com/users/intel-analytics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/intel-analytics/subscriptions","organizations_url":"https://api.github.com/users/intel-analytics/orgs","repos_url":"https://api.github.com/users/intel-analytics/repos","events_url":"https://api.github.com/users/intel-analytics/events{/privacy}","received_events_url":"https://api.github.com/users/intel-analytics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/intel-analytics/BigDL","description":"BigDL: Distributed Deep Learning Library for Apache Spark","fork":false,"url":"https://api.github.com/repos/intel-analytics/BigDL","forks_url":"https://api.github.com/repos/intel-analytics/BigDL/forks","keys_url":"https://api.github.com/repos/intel-analytics/BigDL/keys{/key_id}","collaborators_url":"https://api.github.com/repos/intel-analytics/BigDL/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/intel-analytics/BigDL/teams","hooks_url":"https://api.github.com/repos/intel-analytics/BigDL/hooks","issue_events_url":"https://api.github.com/repos/intel-analytics/BigDL/issues/events{/number}","events_url":"https://api.github.com/repos/intel-analytics/BigDL/events","assignees_url":"https://api.github.com/repos/intel-analytics/BigDL/assignees{/user}","branches_url":"https://api.github.com/repos/intel-analytics/BigDL/branches{/branch}","tags_url":"https://api.github.com/repos/intel-analytics/BigDL/tags","blobs_url":"https://api.github.com/repos/intel-analytics/BigDL/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/intel-analytics/BigDL/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/intel-analytics/BigDL/git/refs{/sha}","trees_url":"https://api.github.com/repos/intel-analytics/BigDL/git/trees{/sha}","statuses_url":"https://api.github.com/repos/intel-analytics/BigDL/statuses/{sha}","languages_url":"https://api.github.com/repos/intel-analytics/BigDL/languages","stargazers_url":"https://api.github.com/repos/intel-analytics/BigDL/stargazers","contributors_url":"https://api.github.com/repos/intel-analytics/BigDL/contributors","subscribers_url":"https://api.github.com/repos/intel-analytics/BigDL/subscribers","subscription_url":"https://api.github.com/repos/intel-analytics/BigDL/subscription","commits_url":"https://api.github.com/repos/intel-analytics/BigDL/commits{/sha}","git_commits_url":"https://api.github.com/repos/intel-analytics/BigDL/git/commits{/sha}","comments_url":"https://api.github.com/repos/intel-analytics/BigDL/comments{/number}","issue_comment_url":"https://api.github.com/repos/intel-analytics/BigDL/issues/comments{/number}","contents_url":"https://api.github.com/repos/intel-analytics/BigDL/contents/{+path}","compare_url":"https://api.github.com/repos/intel-analytics/BigDL/compare/{base}...{head}","merges_url":"https://api.github.com/repos/intel-analytics/BigDL/merges","archive_url":"https://api.github.com/repos/intel-analytics/BigDL/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/intel-analytics/BigDL/downloads","issues_url":"https://api.github.com/repos/intel-analytics/BigDL/issues{/number}","pulls_url":"https://api.github.com/repos/intel-analytics/BigDL/pulls{/number}","milestones_url":"https://api.github.com/repos/intel-analytics/BigDL/milestones{/number}","notifications_url":"https://api.github.com/repos/intel-analytics/BigDL/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/intel-analytics/BigDL/labels{/name}","releases_url":"https://api.github.com/repos/intel-analytics/BigDL/releases{/id}","deployments_url":"https://api.github.com/repos/intel-analytics/BigDL/deployments","created_at":"2016-08-29T07:59:50Z","updated_at":"2017-11-16T09:20:23Z","pushed_at":"2017-11-17T08:00:11Z","git_url":"git://github.com/intel-analytics/BigDL.git","ssh_url":"git@github.com:intel-analytics/BigDL.git","clone_url":"https://github.com/intel-analytics/BigDL.git","svn_url":"https://github.com/intel-analytics/BigDL","homepage":"https://bigdl-project.github.io/","size":16405,"stargazers_count":2108,"watchers_count":2108,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":445,"mirror_url":null,"archived":false,"open_issues_count":155,"forks":445,"open_issues":155,"watchers":2108,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/intel-analytics/BigDL/pulls/1891"},"html":{"href":"https://github.com/intel-analytics/BigDL/pull/1891"},"issue":{"href":"https://api.github.com/repos/intel-analytics/BigDL/issues/1891"},"comments":{"href":"https://api.github.com/repos/intel-analytics/BigDL/issues/1891/comments"},"review_comments":{"href":"https://api.github.com/repos/intel-analytics/BigDL/pulls/1891/comments"},"review_comment":{"href":"https://api.github.com/repos/intel-analytics/BigDL/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/intel-analytics/BigDL/pulls/1891/commits"},"statuses":{"href":"https://api.github.com/repos/intel-analytics/BigDL/statuses/f7139d64f4cea148b5ec3de4e700e0e32529b471"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"hkvision"}}