{"action":"created","issue":{"url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/4061","repository_url":"https://api.github.com/repos/ARMmbed/mbed-os","labels_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/4061/labels{/name}","comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/4061/comments","events_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/4061/events","html_url":"https://github.com/ARMmbed/mbed-os/pull/4061","id":217663792,"number":4061,"title":"Improve error messages for bootloader build errors","user":{"login":"theotherjimmy","id":685409,"avatar_url":"https://avatars1.githubusercontent.com/u/685409?v=3","gravatar_id":"","url":"https://api.github.com/users/theotherjimmy","html_url":"https://github.com/theotherjimmy","followers_url":"https://api.github.com/users/theotherjimmy/followers","following_url":"https://api.github.com/users/theotherjimmy/following{/other_user}","gists_url":"https://api.github.com/users/theotherjimmy/gists{/gist_id}","starred_url":"https://api.github.com/users/theotherjimmy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theotherjimmy/subscriptions","organizations_url":"https://api.github.com/users/theotherjimmy/orgs","repos_url":"https://api.github.com/users/theotherjimmy/repos","events_url":"https://api.github.com/users/theotherjimmy/events{/privacy}","received_events_url":"https://api.github.com/users/theotherjimmy/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-03-28T19:15:00Z","updated_at":"2017-03-28T19:24:06Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/4061","html_url":"https://github.com/ARMmbed/mbed-os/pull/4061","diff_url":"https://github.com/ARMmbed/mbed-os/pull/4061.diff","patch_url":"https://github.com/ARMmbed/mbed-os/pull/4061.patch"},"body":"The error messages related to missing or broken device names in the\r\ntargets.json file were bad/just python tracebacks. This PR changes that\r\nbehavior, by having the Config object raise ConfigExceptions for those\r\nmis-configurations.\r\n\r\nResolves #4057\r\n\r\n## Testing\r\n - [ ] Normal /morph test\r\n - [x] Manual exercise of each corner case and verification that the\r\n messages seen are good.\r\n\r\n### Manual testing\r\n - `mbed_app.json`\r\n```\r\n{\r\n    \"target_overrides\":{\r\n        \"NCS36510\":{\r\n            \"target.restrict_size\": \"0x40000\"\r\n        }\r\n    }\r\n}\r\n```\r\n- `mbed compile -m NCS36510`\r\n```\r\n[ERROR] Bootloader not supported on this target.\r\n```\r\n- add `\"bootloader_supported\": true` to `targets.json`\r\n- `mbed compile -m NCS36510`\r\n```\r\n[ERROR] Bootloader not supported on this target: targets.json `device_name` not specified.\r\n```\r\n- add `\"device_name\": \"NCS36510\"` to `targets.json`\r\n- `mbed compile -m NCS36510`\r\n```\r\n[ERROR] Bootloader not supported on this target: targets.json `device_name` not found in arm_pack_manager index.\r\n```"},"comment":{"url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/comments/289877441","html_url":"https://github.com/ARMmbed/mbed-os/pull/4061#issuecomment-289877441","issue_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/4061","id":289877441,"user":{"login":"theotherjimmy","id":685409,"avatar_url":"https://avatars1.githubusercontent.com/u/685409?v=3","gravatar_id":"","url":"https://api.github.com/users/theotherjimmy","html_url":"https://github.com/theotherjimmy","followers_url":"https://api.github.com/users/theotherjimmy/followers","following_url":"https://api.github.com/users/theotherjimmy/following{/other_user}","gists_url":"https://api.github.com/users/theotherjimmy/gists{/gist_id}","starred_url":"https://api.github.com/users/theotherjimmy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theotherjimmy/subscriptions","organizations_url":"https://api.github.com/users/theotherjimmy/orgs","repos_url":"https://api.github.com/users/theotherjimmy/repos","events_url":"https://api.github.com/users/theotherjimmy/events{/privacy}","received_events_url":"https://api.github.com/users/theotherjimmy/received_events","type":"User","site_admin":false},"created_at":"2017-03-28T19:24:06Z","updated_at":"2017-03-28T19:24:06Z","body":"/morph test"}}
{"actor":{"display_login":"theotherjimmy"}}