{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/42176","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/42176/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/42176/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/42176/events","html_url":"https://github.com/kubernetes/kubernetes/pull/42176","id":210563466,"number":42176,"title":"Job: Respect ControllerRef","user":{"login":"enisoc","id":6733629,"avatar_url":"https://avatars0.githubusercontent.com/u/6733629?v=3","gravatar_id":"","url":"https://api.github.com/users/enisoc","html_url":"https://github.com/enisoc","followers_url":"https://api.github.com/users/enisoc/followers","following_url":"https://api.github.com/users/enisoc/following{/other_user}","gists_url":"https://api.github.com/users/enisoc/gists{/gist_id}","starred_url":"https://api.github.com/users/enisoc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enisoc/subscriptions","organizations_url":"https://api.github.com/users/enisoc/orgs","repos_url":"https://api.github.com/users/enisoc/repos","events_url":"https://api.github.com/users/enisoc/events{/privacy}","received_events_url":"https://api.github.com/users/enisoc/received_events","type":"User","site_admin":false},"labels":[{"id":414883982,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":477397086,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":335674843,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/do-not-merge","name":"do-not-merge","color":"e11d21","default":false},{"id":105146071,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/bug","name":"kind/bug","color":"e11d21","default":false},{"id":148225179,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/lgtm","name":"lgtm","color":"15dd18","default":false},{"id":200149833,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note","name":"release-note","color":"c2e0c6","default":false},{"id":253451057,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/XL","name":"size/XL","color":"ee5500","default":false}],"state":"open","locked":false,"assignee":{"login":"soltysh","id":576341,"avatar_url":"https://avatars1.githubusercontent.com/u/576341?v=3","gravatar_id":"","url":"https://api.github.com/users/soltysh","html_url":"https://github.com/soltysh","followers_url":"https://api.github.com/users/soltysh/followers","following_url":"https://api.github.com/users/soltysh/following{/other_user}","gists_url":"https://api.github.com/users/soltysh/gists{/gist_id}","starred_url":"https://api.github.com/users/soltysh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soltysh/subscriptions","organizations_url":"https://api.github.com/users/soltysh/orgs","repos_url":"https://api.github.com/users/soltysh/repos","events_url":"https://api.github.com/users/soltysh/events{/privacy}","received_events_url":"https://api.github.com/users/soltysh/received_events","type":"User","site_admin":false},"assignees":[{"login":"soltysh","id":576341,"avatar_url":"https://avatars1.githubusercontent.com/u/576341?v=3","gravatar_id":"","url":"https://api.github.com/users/soltysh","html_url":"https://github.com/soltysh","followers_url":"https://api.github.com/users/soltysh/followers","following_url":"https://api.github.com/users/soltysh/following{/other_user}","gists_url":"https://api.github.com/users/soltysh/gists{/gist_id}","starred_url":"https://api.github.com/users/soltysh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soltysh/subscriptions","organizations_url":"https://api.github.com/users/soltysh/orgs","repos_url":"https://api.github.com/users/soltysh/repos","events_url":"https://api.github.com/users/soltysh/events{/privacy}","received_events_url":"https://api.github.com/users/soltysh/received_events","type":"User","site_admin":false},{"login":"caesarxuchao","id":2823529,"avatar_url":"https://avatars1.githubusercontent.com/u/2823529?v=3","gravatar_id":"","url":"https://api.github.com/users/caesarxuchao","html_url":"https://github.com/caesarxuchao","followers_url":"https://api.github.com/users/caesarxuchao/followers","following_url":"https://api.github.com/users/caesarxuchao/following{/other_user}","gists_url":"https://api.github.com/users/caesarxuchao/gists{/gist_id}","starred_url":"https://api.github.com/users/caesarxuchao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caesarxuchao/subscriptions","organizations_url":"https://api.github.com/users/caesarxuchao/orgs","repos_url":"https://api.github.com/users/caesarxuchao/repos","events_url":"https://api.github.com/users/caesarxuchao/events{/privacy}","received_events_url":"https://api.github.com/users/caesarxuchao/received_events","type":"User","site_admin":false},{"login":"janetkuo","id":4876867,"avatar_url":"https://avatars2.githubusercontent.com/u/4876867?v=3","gravatar_id":"","url":"https://api.github.com/users/janetkuo","html_url":"https://github.com/janetkuo","followers_url":"https://api.github.com/users/janetkuo/followers","following_url":"https://api.github.com/users/janetkuo/following{/other_user}","gists_url":"https://api.github.com/users/janetkuo/gists{/gist_id}","starred_url":"https://api.github.com/users/janetkuo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janetkuo/subscriptions","organizations_url":"https://api.github.com/users/janetkuo/orgs","repos_url":"https://api.github.com/users/janetkuo/repos","events_url":"https://api.github.com/users/janetkuo/events{/privacy}","received_events_url":"https://api.github.com/users/janetkuo/received_events","type":"User","site_admin":false},{"login":"kow3ns","id":11380896,"avatar_url":"https://avatars0.githubusercontent.com/u/11380896?v=3","gravatar_id":"","url":"https://api.github.com/users/kow3ns","html_url":"https://github.com/kow3ns","followers_url":"https://api.github.com/users/kow3ns/followers","following_url":"https://api.github.com/users/kow3ns/following{/other_user}","gists_url":"https://api.github.com/users/kow3ns/gists{/gist_id}","starred_url":"https://api.github.com/users/kow3ns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kow3ns/subscriptions","organizations_url":"https://api.github.com/users/kow3ns/orgs","repos_url":"https://api.github.com/users/kow3ns/repos","events_url":"https://api.github.com/users/kow3ns/events{/privacy}","received_events_url":"https://api.github.com/users/kow3ns/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/32","html_url":"https://github.com/kubernetes/kubernetes/milestone/32","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/32/labels","id":2264750,"number":32,"title":"v1.7","description":"","creator":{"login":"pwittrock","id":7882754,"avatar_url":"https://avatars3.githubusercontent.com/u/7882754?v=3","gravatar_id":"","url":"https://api.github.com/users/pwittrock","html_url":"https://github.com/pwittrock","followers_url":"https://api.github.com/users/pwittrock/followers","following_url":"https://api.github.com/users/pwittrock/following{/other_user}","gists_url":"https://api.github.com/users/pwittrock/gists{/gist_id}","starred_url":"https://api.github.com/users/pwittrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pwittrock/subscriptions","organizations_url":"https://api.github.com/users/pwittrock/orgs","repos_url":"https://api.github.com/users/pwittrock/repos","events_url":"https://api.github.com/users/pwittrock/events{/privacy}","received_events_url":"https://api.github.com/users/pwittrock/received_events","type":"User","site_admin":false},"open_issues":369,"closed_issues":24,"state":"open","created_at":"2017-01-19T17:41:27Z","updated_at":"2017-03-23T20:50:30Z","due_on":null,"closed_at":null},"comments":12,"created_at":"2017-02-27T18:15:07Z","updated_at":"2017-03-24T00:02:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/42176","html_url":"https://github.com/kubernetes/kubernetes/pull/42176","diff_url":"https://github.com/kubernetes/kubernetes/pull/42176.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/42176.patch"},"body":"**What this PR does / why we need it**:\r\n\r\nThis is part of the completion of the [ControllerRef](https://github.com/kubernetes/community/blob/master/contributors/design-proposals/controller-ref.md) proposal. It brings Job into full compliance with ControllerRef. See the individual commit messages for details.\r\n\r\n**Which issue this PR fixes**:\r\n\r\nThis ensures that Job does not fight with other controllers over control of Pods.\r\n\r\nRef: #24433\r\n\r\n**Special notes for your reviewer**:\r\n\r\nThis branch is based on #41984. Please look only at the commits labeled `Job:`. I will rebase once the base PR is merged.\r\n\r\n**Release note**:\r\n\r\n```release-note\r\nJob controller now respects ControllerRef to avoid fighting over Pods.\r\n```\r\ncc @erictune @kubernetes/sig-apps-pr-reviews "},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/288896248","html_url":"https://github.com/kubernetes/kubernetes/pull/42176#issuecomment-288896248","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/42176","id":288896248,"user":{"login":"k8s-ci-robot","id":20407524,"avatar_url":"https://avatars3.githubusercontent.com/u/20407524?v=3","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2017-03-24T00:02:00Z","updated_at":"2017-03-24T00:02:00Z","body":"@enisoc: The following test(s) **failed**:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\nJenkins Bazel Build | 37f804b2b3e4611cd94063fe2af15bab9adfc9d2 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/42176/pull-kubernetes-bazel/10944/) | `@k8s-bot bazel test this`\nJenkins Kubemark GCE e2e | 37f804b2b3e4611cd94063fe2af15bab9adfc9d2 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/42176/pull-kubernetes-kubemark-e2e-gce/23107/) | `@k8s-bot kubemark e2e test this`\nJenkins kops AWS e2e | 37f804b2b3e4611cd94063fe2af15bab9adfc9d2 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/42176/pull-kubernetes-e2e-kops-aws/18197/) | `@k8s-bot kops aws e2e test this`\nJenkins unit/integration | 37f804b2b3e4611cd94063fe2af15bab9adfc9d2 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/42176/pull-kubernetes-unit/23779/) | `@k8s-bot unit test this`\nJenkins non-CRI GCE e2e | 37f804b2b3e4611cd94063fe2af15bab9adfc9d2 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/42176/pull-kubernetes-e2e-gce-non-cri/5016/) | `@k8s-bot non-cri e2e test this`\nJenkins verification | 37f804b2b3e4611cd94063fe2af15bab9adfc9d2 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/42176/pull-kubernetes-verify/23036/) | `@k8s-bot verify test this`\n\n[Full PR test history](https://k8s-gubernator.appspot.com/pr/42176). [Your PR dashboard](https://k8s-gubernator.appspot.com/pr/enisoc). Please help us cut down on flakes by linking to an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://github.com/kubernetes/community/blob/master/contributors/devel/pull-request-commands.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://github.com/kubernetes/test-infra/blob/master/prow/commands.md).\n</details>\n<!-- test report -->"}}
{"actor":{"display_login":"k8s-ci-robot"}}