{"action":"created","issue":{"url":"https://api.github.com/repos/mixxxdj/mixxx/issues/953","repository_url":"https://api.github.com/repos/mixxxdj/mixxx","labels_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/953/labels{/name}","comments_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/953/comments","events_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/953/events","html_url":"https://github.com/mixxxdj/mixxx/pull/953","id":156149603,"number":953,"title":"Library navigation controls","user":{"login":"timrae","id":2818274,"avatar_url":"https://avatars.githubusercontent.com/u/2818274?v=3","gravatar_id":"","url":"https://api.github.com/users/timrae","html_url":"https://github.com/timrae","followers_url":"https://api.github.com/users/timrae/followers","following_url":"https://api.github.com/users/timrae/following{/other_user}","gists_url":"https://api.github.com/users/timrae/gists{/gist_id}","starred_url":"https://api.github.com/users/timrae/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timrae/subscriptions","organizations_url":"https://api.github.com/users/timrae/orgs","repos_url":"https://api.github.com/users/timrae/repos","events_url":"https://api.github.com/users/timrae/events{/privacy}","received_events_url":"https://api.github.com/users/timrae/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":55,"created_at":"2016-05-22T12:22:23Z","updated_at":"2017-01-09T00:02:58Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/953","html_url":"https://github.com/mixxxdj/mixxx/pull/953","diff_url":"https://github.com/mixxxdj/mixxx/pull/953.diff","patch_url":"https://github.com/mixxxdj/mixxx/pull/953.patch"},"body":"Added three new controls that make it a lot easier to use the library encoder on DJ controllers by allowing the following functionality:\n- `SelectItemKnob` allows the library encoder to scroll through sidebar items when the sidebar has focus, as opposed to `SelectTrackKnob` which only scans through the library and `SelectPlaylist` which only scans through the sidebar items.\n- `ToggleFocusWidget` allows users to toggle the focus between the sidebar and the library.\n- `ChooseItem` allows the library encoder push button to either expand a sidebar item if sidebar has focus, or load a track into first stopped deck if library has focus. This is intuitive as it's the same behavior as a double click.\n"},"comment":{"url":"https://api.github.com/repos/mixxxdj/mixxx/issues/comments/271190641","html_url":"https://github.com/mixxxdj/mixxx/pull/953#issuecomment-271190641","issue_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/953","id":271190641,"user":{"login":"rryan","id":26527,"avatar_url":"https://avatars.githubusercontent.com/u/26527?v=3","gravatar_id":"","url":"https://api.github.com/users/rryan","html_url":"https://github.com/rryan","followers_url":"https://api.github.com/users/rryan/followers","following_url":"https://api.github.com/users/rryan/following{/other_user}","gists_url":"https://api.github.com/users/rryan/gists{/gist_id}","starred_url":"https://api.github.com/users/rryan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rryan/subscriptions","organizations_url":"https://api.github.com/users/rryan/orgs","repos_url":"https://api.github.com/users/rryan/repos","events_url":"https://api.github.com/users/rryan/events{/privacy}","received_events_url":"https://api.github.com/users/rryan/received_events","type":"User","site_admin":false},"created_at":"2017-01-09T00:02:58Z","updated_at":"2017-01-09T00:02:58Z","body":"> IMHO we should prefer Qt classes in our Qt code, if there is no reason for other classes.\r\n\r\n:+1: to continuing to prefer Qt classes as the default, unless there's a good reason otherwise (such as here). \r\n\r\nOne benefit I see is that Qt uses the same implementation on all platforms, while the C++ standard library implementation changes per-platform. So using Qt classes we can make slightly stronger assumptions about the implementation we're getting for a given class.\r\n\r\nOne small benefit to using QSharedPointer is that you get little integrations with QObjects (the pointer automatically goes null when a QObject is deleted by another means, which is a nice safeguard against bugs).\r\n\r\nstd::unique_ptr seems strictly better than QScopedPointer and I think we should continue to replace it everywhere."}}
{"actor":{"display_login":"rryan"}}