{"action":"created","issue":{"url":"https://api.github.com/repos/landlab/landlab/issues/422","repository_url":"https://api.github.com/repos/landlab/landlab","labels_url":"https://api.github.com/repos/landlab/landlab/issues/422/labels{/name}","comments_url":"https://api.github.com/repos/landlab/landlab/issues/422/comments","events_url":"https://api.github.com/repos/landlab/landlab/issues/422/events","html_url":"https://github.com/landlab/landlab/pull/422","id":198018851,"number":422,"title":"Commit for discussion: initial draft of new flow directors and accumulators","user":{"login":"kbarnhart","id":6589339,"avatar_url":"https://avatars.githubusercontent.com/u/6589339?v=3","gravatar_id":"","url":"https://api.github.com/users/kbarnhart","html_url":"https://github.com/kbarnhart","followers_url":"https://api.github.com/users/kbarnhart/followers","following_url":"https://api.github.com/users/kbarnhart/following{/other_user}","gists_url":"https://api.github.com/users/kbarnhart/gists{/gist_id}","starred_url":"https://api.github.com/users/kbarnhart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbarnhart/subscriptions","organizations_url":"https://api.github.com/users/kbarnhart/orgs","repos_url":"https://api.github.com/users/kbarnhart/repos","events_url":"https://api.github.com/users/kbarnhart/events{/privacy}","received_events_url":"https://api.github.com/users/kbarnhart/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"kbarnhart","id":6589339,"avatar_url":"https://avatars.githubusercontent.com/u/6589339?v=3","gravatar_id":"","url":"https://api.github.com/users/kbarnhart","html_url":"https://github.com/kbarnhart","followers_url":"https://api.github.com/users/kbarnhart/followers","following_url":"https://api.github.com/users/kbarnhart/following{/other_user}","gists_url":"https://api.github.com/users/kbarnhart/gists{/gist_id}","starred_url":"https://api.github.com/users/kbarnhart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbarnhart/subscriptions","organizations_url":"https://api.github.com/users/kbarnhart/orgs","repos_url":"https://api.github.com/users/kbarnhart/repos","events_url":"https://api.github.com/users/kbarnhart/events{/privacy}","received_events_url":"https://api.github.com/users/kbarnhart/received_events","type":"User","site_admin":false},"assignees":[{"login":"kbarnhart","id":6589339,"avatar_url":"https://avatars.githubusercontent.com/u/6589339?v=3","gravatar_id":"","url":"https://api.github.com/users/kbarnhart","html_url":"https://github.com/kbarnhart","followers_url":"https://api.github.com/users/kbarnhart/followers","following_url":"https://api.github.com/users/kbarnhart/following{/other_user}","gists_url":"https://api.github.com/users/kbarnhart/gists{/gist_id}","starred_url":"https://api.github.com/users/kbarnhart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbarnhart/subscriptions","organizations_url":"https://api.github.com/users/kbarnhart/orgs","repos_url":"https://api.github.com/users/kbarnhart/repos","events_url":"https://api.github.com/users/kbarnhart/events{/privacy}","received_events_url":"https://api.github.com/users/kbarnhart/received_events","type":"User","site_admin":false},{"login":"mcflugen","id":6618196,"avatar_url":"https://avatars.githubusercontent.com/u/6618196?v=3","gravatar_id":"","url":"https://api.github.com/users/mcflugen","html_url":"https://github.com/mcflugen","followers_url":"https://api.github.com/users/mcflugen/followers","following_url":"https://api.github.com/users/mcflugen/following{/other_user}","gists_url":"https://api.github.com/users/mcflugen/gists{/gist_id}","starred_url":"https://api.github.com/users/mcflugen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcflugen/subscriptions","organizations_url":"https://api.github.com/users/mcflugen/orgs","repos_url":"https://api.github.com/users/mcflugen/repos","events_url":"https://api.github.com/users/mcflugen/events{/privacy}","received_events_url":"https://api.github.com/users/mcflugen/received_events","type":"User","site_admin":false},{"login":"SiccarPoint","id":6867260,"avatar_url":"https://avatars.githubusercontent.com/u/6867260?v=3","gravatar_id":"","url":"https://api.github.com/users/SiccarPoint","html_url":"https://github.com/SiccarPoint","followers_url":"https://api.github.com/users/SiccarPoint/followers","following_url":"https://api.github.com/users/SiccarPoint/following{/other_user}","gists_url":"https://api.github.com/users/SiccarPoint/gists{/gist_id}","starred_url":"https://api.github.com/users/SiccarPoint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SiccarPoint/subscriptions","organizations_url":"https://api.github.com/users/SiccarPoint/orgs","repos_url":"https://api.github.com/users/SiccarPoint/repos","events_url":"https://api.github.com/users/SiccarPoint/events{/privacy}","received_events_url":"https://api.github.com/users/SiccarPoint/received_events","type":"User","site_admin":false},{"login":"gregtucker","id":7528207,"avatar_url":"https://avatars.githubusercontent.com/u/7528207?v=3","gravatar_id":"","url":"https://api.github.com/users/gregtucker","html_url":"https://github.com/gregtucker","followers_url":"https://api.github.com/users/gregtucker/followers","following_url":"https://api.github.com/users/gregtucker/following{/other_user}","gists_url":"https://api.github.com/users/gregtucker/gists{/gist_id}","starred_url":"https://api.github.com/users/gregtucker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregtucker/subscriptions","organizations_url":"https://api.github.com/users/gregtucker/orgs","repos_url":"https://api.github.com/users/gregtucker/repos","events_url":"https://api.github.com/users/gregtucker/events{/privacy}","received_events_url":"https://api.github.com/users/gregtucker/received_events","type":"User","site_admin":false}],"milestone":null,"comments":49,"created_at":"2016-12-29T14:51:42Z","updated_at":"2017-01-04T23:28:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/landlab/landlab/pulls/422","html_url":"https://github.com/landlab/landlab/pull/422","diff_url":"https://github.com/landlab/landlab/pull/422.diff","patch_url":"https://github.com/landlab/landlab/pull/422.patch"},"body":"New components for review listed below(_italic indicates planned but not yet implemented)_. The goal of this pull request is to get feedback regarding the structure on the first drafts these new components which split apart the FlowRouter component into FlowDirectors and FlowAccumulators. Once I get this feedback, I will finish the planned but not implemented components so all new components can join the master branch at the same time. \r\n\r\nNew components presently documented and tested in the docstrings ONLY. I will make **tests** folder and associated files once the structure of the components is quasi-finalized. \r\n\r\nOne added bit of functionality is that FlowAccumulators can now call a provided DepressionFinder instance from within the `run_one_step()` call. At the moment this does not provide any computational gains - however when combined with planned improvements to the DepressionFinder, this should result in computational gains.  \r\n\r\n\r\n\r\n**Directors**\r\n\r\n- **Base classes**\r\n\r\n  - FlowDirector (base class)\r\n  - FlowDirectorToOne (intermediate base class)\r\n  - _FlowDirectorToMany_ (intermediate base class)\r\n\r\n- **Flow-To-One**\r\n\r\n  - FlowDirectorD4 (raster)\r\n  - FlowDirectorD8 (raster)\r\n  - FlowDirectorSteepestDescent (voroni)\r\n  \r\n- **Flow-To-Multiple**\r\n\r\n   - FlowDirectorDinfinity (raster)\r\n   - _FlowDirectorDtrig_ (raster)\r\n   - _Various MFD flow directors_ (see #421 for notes)\r\n \r\n\r\n**Accumulators**\r\n\r\n- **Base Class**\r\n  - FlowAccumulator (base class)\r\n\r\n- **Flow-To-One**\r\n\r\n  - FlowAccumulatorD4 (raster)\r\n  - FlowAccumulatorD8 (raster)\r\n  - FlowAccumulatorSteepestDescent (voroni)\r\n\r\n- **Flow-To-Multiple**\r\n\r\n  - _FlowAccumulatorDinfinity_(raster)\r\n  - _FlowAccumulatorDtrig_\r\n  - _Various MFD flow accumulators_\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/landlab/landlab/issues/comments/270517781","html_url":"https://github.com/landlab/landlab/pull/422#issuecomment-270517781","issue_url":"https://api.github.com/repos/landlab/landlab/issues/422","id":270517781,"user":{"login":"kbarnhart","id":6589339,"avatar_url":"https://avatars.githubusercontent.com/u/6589339?v=3","gravatar_id":"","url":"https://api.github.com/users/kbarnhart","html_url":"https://github.com/kbarnhart","followers_url":"https://api.github.com/users/kbarnhart/followers","following_url":"https://api.github.com/users/kbarnhart/following{/other_user}","gists_url":"https://api.github.com/users/kbarnhart/gists{/gist_id}","starred_url":"https://api.github.com/users/kbarnhart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbarnhart/subscriptions","organizations_url":"https://api.github.com/users/kbarnhart/orgs","repos_url":"https://api.github.com/users/kbarnhart/repos","events_url":"https://api.github.com/users/kbarnhart/events{/privacy}","received_events_url":"https://api.github.com/users/kbarnhart/received_events","type":"User","site_admin":false},"created_at":"2017-01-04T23:28:09Z","updated_at":"2017-01-04T23:28:09Z","body":"Also, I'll work on implementing some of these changes for your review. Likely early next week as I have a proposal due on Tuesday. "}}
{"actor":{"display_login":"kbarnhart"}}