{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/pulls/comments/94465152","pull_request_review_id":14992935,"id":94465152,"diff_hunk":"@@ -251,12 +228,46 @@\n                 <goals>\r\n                   <goal>deploy</goal>\r\n                 </goals>\r\n+              </execution>\r\n+            </executions>\r\n+          </plugin>\r\n+          <plugin>\r\n+            <groupId>com.spotify</groupId>\r\n+            <artifactId>docker-maven-plugin</artifactId>\r\n+            <executions>\r\n+              <execution>\r\n+                <id>tag-image</id>\r\n+                <phase>package</phase>\r\n+                <goals>\r\n+                  <goal>tag</goal>\r\n+                </goals>\r\n+                <configuration>\r\n+                  <image>jetty:${docker.tag.short}</image>\r\n+                  <newName>${jetty.test.image}</newName>\r\n+                </configuration>\r\n+              </execution>\r\n+            </executions>\r\n+          </plugin>\r\n+          <plugin>\r\n+            <groupId>org.codehaus.mojo</groupId>\r\n+            <artifactId>exec-maven-plugin</artifactId>\r\n+            <version>1.5.0</version>\r\n+            <executions>\r\n+              <execution>\r\n+                <id>deploy-remote-docker</id>\r\n+                <phase>package</phase>\r\n+                <goals>\r\n+                  <goal>exec</goal>\r\n+                </goals>\r\n                 <configuration>\r\n-                  <deploy.project>${app.deploy.project}</deploy.project>\r\n-                  <deploy.version>${maven.build.timestamp}</deploy.version>\r\n-                  <deploy.promote>false</deploy.promote>\r\n-                  <dockerDirectory>${project.build.directory}/docker\r\n-                  </dockerDirectory>\r\n+                  <executable>gcloud</executable>\r\n+                  <arguments>\r\n+                    <argument>docker</argument>\r\n+                    <argument>-q</argument>\r\n+                    <argument>--</argument>\r\n+                    <argument>push</argument>\r","path":"tests/test-war-smoke/pom.xml","position":192,"original_position":192,"commit_id":"a5fa8be4471c8855ca85f462ba8f4218891d6128","original_commit_id":"a5fa8be4471c8855ca85f462ba8f4218891d6128","user":{"login":"meltsufin","id":17732492,"avatar_url":"https://avatars.githubusercontent.com/u/17732492?v=3","gravatar_id":"","url":"https://api.github.com/users/meltsufin","html_url":"https://github.com/meltsufin","followers_url":"https://api.github.com/users/meltsufin/followers","following_url":"https://api.github.com/users/meltsufin/following{/other_user}","gists_url":"https://api.github.com/users/meltsufin/gists{/gist_id}","starred_url":"https://api.github.com/users/meltsufin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meltsufin/subscriptions","organizations_url":"https://api.github.com/users/meltsufin/orgs","repos_url":"https://api.github.com/users/meltsufin/repos","events_url":"https://api.github.com/users/meltsufin/events{/privacy}","received_events_url":"https://api.github.com/users/meltsufin/received_events","type":"User","site_admin":false},"body":"Does `<inherited>false</inherited>` on the plugin help here at all to avoid re-running it in the child modules?","created_at":"2017-01-03T19:18:56Z","updated_at":"2017-01-03T19:18:56Z","html_url":"https://github.com/GoogleCloudPlatform/jetty-runtime/pull/117#discussion_r94465152","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/pulls/117","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/pulls/comments/94465152"},"html":{"href":"https://github.com/GoogleCloudPlatform/jetty-runtime/pull/117#discussion_r94465152"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/pulls/117"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/pulls/117","id":99982384,"html_url":"https://github.com/GoogleCloudPlatform/jetty-runtime/pull/117","diff_url":"https://github.com/GoogleCloudPlatform/jetty-runtime/pull/117.diff","patch_url":"https://github.com/GoogleCloudPlatform/jetty-runtime/pull/117.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/issues/117","number":117,"state":"open","locked":false,"title":"Resolve #109 local and remote testing works, -Ptest.remote,test.local","user":{"login":"jmcc0nn3ll","id":273327,"avatar_url":"https://avatars.githubusercontent.com/u/273327?v=3","gravatar_id":"","url":"https://api.github.com/users/jmcc0nn3ll","html_url":"https://github.com/jmcc0nn3ll","followers_url":"https://api.github.com/users/jmcc0nn3ll/followers","following_url":"https://api.github.com/users/jmcc0nn3ll/following{/other_user}","gists_url":"https://api.github.com/users/jmcc0nn3ll/gists{/gist_id}","starred_url":"https://api.github.com/users/jmcc0nn3ll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmcc0nn3ll/subscriptions","organizations_url":"https://api.github.com/users/jmcc0nn3ll/orgs","repos_url":"https://api.github.com/users/jmcc0nn3ll/repos","events_url":"https://api.github.com/users/jmcc0nn3ll/events{/privacy}","received_events_url":"https://api.github.com/users/jmcc0nn3ll/received_events","type":"User","site_admin":false},"body":"local is default\r\nremote can be activated with -Ptest.remote\r\nboth with -Ptest.remote,test.local\r\n\r\nfigured out part of what is bothersome, the appengine-maven-plugin seems to force a complete new lifecycle so most all the plugins run twice","created_at":"2017-01-03T16:37:12Z","updated_at":"2017-01-03T19:18:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"989b90b489afa6f5d6e74d4398b58e326943ebcb","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/pulls/117/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/pulls/117/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/issues/117/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/statuses/a5fa8be4471c8855ca85f462ba8f4218891d6128","head":{"label":"GoogleCloudPlatform:local-and-remote","ref":"local-and-remote","sha":"a5fa8be4471c8855ca85f462ba8f4218891d6128","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":66016354,"name":"jetty-runtime","full_name":"GoogleCloudPlatform/jetty-runtime","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/jetty-runtime","description":null,"fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/deployments","created_at":"2016-08-18T17:14:04Z","updated_at":"2016-12-13T16:05:11Z","pushed_at":"2017-01-03T16:37:13Z","git_url":"git://github.com/GoogleCloudPlatform/jetty-runtime.git","ssh_url":"git@github.com:GoogleCloudPlatform/jetty-runtime.git","clone_url":"https://github.com/GoogleCloudPlatform/jetty-runtime.git","svn_url":"https://github.com/GoogleCloudPlatform/jetty-runtime","homepage":null,"size":5820,"stargazers_count":6,"watchers_count":6,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":31,"forks":5,"open_issues":31,"watchers":6,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"60c6d33141676aea8d655f11659c0e6b0f295aa3","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":66016354,"name":"jetty-runtime","full_name":"GoogleCloudPlatform/jetty-runtime","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/jetty-runtime","description":null,"fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/deployments","created_at":"2016-08-18T17:14:04Z","updated_at":"2016-12-13T16:05:11Z","pushed_at":"2017-01-03T16:37:13Z","git_url":"git://github.com/GoogleCloudPlatform/jetty-runtime.git","ssh_url":"git@github.com:GoogleCloudPlatform/jetty-runtime.git","clone_url":"https://github.com/GoogleCloudPlatform/jetty-runtime.git","svn_url":"https://github.com/GoogleCloudPlatform/jetty-runtime","homepage":null,"size":5820,"stargazers_count":6,"watchers_count":6,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":31,"forks":5,"open_issues":31,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/pulls/117"},"html":{"href":"https://github.com/GoogleCloudPlatform/jetty-runtime/pull/117"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/issues/117"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/issues/117/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/pulls/117/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/pulls/117/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/jetty-runtime/statuses/a5fa8be4471c8855ca85f462ba8f4218891d6128"}}}}
{"actor":{"display_login":"meltsufin"}}