{"action":"closed","number":12387,"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/12387","id":145971283,"html_url":"https://github.com/apple/swift/pull/12387","diff_url":"https://github.com/apple/swift/pull/12387.diff","patch_url":"https://github.com/apple/swift/pull/12387.patch","issue_url":"https://api.github.com/repos/apple/swift/issues/12387","number":12387,"state":"closed","locked":false,"title":"Fixes overflow trap when creating DispatchTime objects with large upt…","user":{"login":"ktopley-apple","id":25260843,"avatar_url":"https://avatars3.githubusercontent.com/u/25260843?v=4","gravatar_id":"","url":"https://api.github.com/users/ktopley-apple","html_url":"https://github.com/ktopley-apple","followers_url":"https://api.github.com/users/ktopley-apple/followers","following_url":"https://api.github.com/users/ktopley-apple/following{/other_user}","gists_url":"https://api.github.com/users/ktopley-apple/gists{/gist_id}","starred_url":"https://api.github.com/users/ktopley-apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ktopley-apple/subscriptions","organizations_url":"https://api.github.com/users/ktopley-apple/orgs","repos_url":"https://api.github.com/users/ktopley-apple/repos","events_url":"https://api.github.com/users/ktopley-apple/events{/privacy}","received_events_url":"https://api.github.com/users/ktopley-apple/received_events","type":"User","site_admin":false},"body":"…imeNanoseconds values and re-enables the tests that failed.\r\n\r\nAdds some additional tests.\r\n\r\n(rdar://problem/34751238)\r\n\r\n\r\nThe change is in three parts:\r\n\r\n1. The value UInt64.max passed to the DispatchTime initializer means DISPATCH_TIME_FOREVER and should not be scaled using the Mach timebase.\r\n2. The scaling calculations need to detect overflow and clamp to UInt64.max if this occurs, making the value equal to DISPATCH_TIME_FOREVER\r\n3. The getter for the uptimeNanoseconds also needs to be protected against overflow and return UInt64.max if it occurs.","created_at":"2017-10-11T14:46:58Z","updated_at":"2017-10-16T14:37:34Z","closed_at":"2017-10-16T14:37:34Z","merged_at":"2017-10-16T14:37:34Z","merge_commit_sha":"95564f24fa11bb79431602cd67fcf6de231ff7b6","assignee":{"login":"ktopley-apple","id":25260843,"avatar_url":"https://avatars3.githubusercontent.com/u/25260843?v=4","gravatar_id":"","url":"https://api.github.com/users/ktopley-apple","html_url":"https://github.com/ktopley-apple","followers_url":"https://api.github.com/users/ktopley-apple/followers","following_url":"https://api.github.com/users/ktopley-apple/following{/other_user}","gists_url":"https://api.github.com/users/ktopley-apple/gists{/gist_id}","starred_url":"https://api.github.com/users/ktopley-apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ktopley-apple/subscriptions","organizations_url":"https://api.github.com/users/ktopley-apple/orgs","repos_url":"https://api.github.com/users/ktopley-apple/repos","events_url":"https://api.github.com/users/ktopley-apple/events{/privacy}","received_events_url":"https://api.github.com/users/ktopley-apple/received_events","type":"User","site_admin":false},"assignees":[{"login":"ktopley-apple","id":25260843,"avatar_url":"https://avatars3.githubusercontent.com/u/25260843?v=4","gravatar_id":"","url":"https://api.github.com/users/ktopley-apple","html_url":"https://github.com/ktopley-apple","followers_url":"https://api.github.com/users/ktopley-apple/followers","following_url":"https://api.github.com/users/ktopley-apple/following{/other_user}","gists_url":"https://api.github.com/users/ktopley-apple/gists{/gist_id}","starred_url":"https://api.github.com/users/ktopley-apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ktopley-apple/subscriptions","organizations_url":"https://api.github.com/users/ktopley-apple/orgs","repos_url":"https://api.github.com/users/ktopley-apple/repos","events_url":"https://api.github.com/users/ktopley-apple/events{/privacy}","received_events_url":"https://api.github.com/users/ktopley-apple/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"moiseev","id":64011,"avatar_url":"https://avatars3.githubusercontent.com/u/64011?v=4","gravatar_id":"","url":"https://api.github.com/users/moiseev","html_url":"https://github.com/moiseev","followers_url":"https://api.github.com/users/moiseev/followers","following_url":"https://api.github.com/users/moiseev/following{/other_user}","gists_url":"https://api.github.com/users/moiseev/gists{/gist_id}","starred_url":"https://api.github.com/users/moiseev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moiseev/subscriptions","organizations_url":"https://api.github.com/users/moiseev/orgs","repos_url":"https://api.github.com/users/moiseev/repos","events_url":"https://api.github.com/users/moiseev/events{/privacy}","received_events_url":"https://api.github.com/users/moiseev/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift/pulls/12387/commits","review_comments_url":"https://api.github.com/repos/apple/swift/pulls/12387/comments","review_comment_url":"https://api.github.com/repos/apple/swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift/issues/12387/comments","statuses_url":"https://api.github.com/repos/apple/swift/statuses/1da4b04d9992fd9a27881e2a7fea7d6be3182269","head":{"label":"ktopley-apple:dispatch-timebase-overflow","ref":"dispatch-timebase-overflow","sha":"1da4b04d9992fd9a27881e2a7fea7d6be3182269","user":{"login":"ktopley-apple","id":25260843,"avatar_url":"https://avatars3.githubusercontent.com/u/25260843?v=4","gravatar_id":"","url":"https://api.github.com/users/ktopley-apple","html_url":"https://github.com/ktopley-apple","followers_url":"https://api.github.com/users/ktopley-apple/followers","following_url":"https://api.github.com/users/ktopley-apple/following{/other_user}","gists_url":"https://api.github.com/users/ktopley-apple/gists{/gist_id}","starred_url":"https://api.github.com/users/ktopley-apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ktopley-apple/subscriptions","organizations_url":"https://api.github.com/users/ktopley-apple/orgs","repos_url":"https://api.github.com/users/ktopley-apple/repos","events_url":"https://api.github.com/users/ktopley-apple/events{/privacy}","received_events_url":"https://api.github.com/users/ktopley-apple/received_events","type":"User","site_admin":false},"repo":{"id":89265980,"name":"swift","full_name":"ktopley-apple/swift","owner":{"login":"ktopley-apple","id":25260843,"avatar_url":"https://avatars3.githubusercontent.com/u/25260843?v=4","gravatar_id":"","url":"https://api.github.com/users/ktopley-apple","html_url":"https://github.com/ktopley-apple","followers_url":"https://api.github.com/users/ktopley-apple/followers","following_url":"https://api.github.com/users/ktopley-apple/following{/other_user}","gists_url":"https://api.github.com/users/ktopley-apple/gists{/gist_id}","starred_url":"https://api.github.com/users/ktopley-apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ktopley-apple/subscriptions","organizations_url":"https://api.github.com/users/ktopley-apple/orgs","repos_url":"https://api.github.com/users/ktopley-apple/repos","events_url":"https://api.github.com/users/ktopley-apple/events{/privacy}","received_events_url":"https://api.github.com/users/ktopley-apple/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ktopley-apple/swift","description":"The Swift Programming Language","fork":true,"url":"https://api.github.com/repos/ktopley-apple/swift","forks_url":"https://api.github.com/repos/ktopley-apple/swift/forks","keys_url":"https://api.github.com/repos/ktopley-apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ktopley-apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ktopley-apple/swift/teams","hooks_url":"https://api.github.com/repos/ktopley-apple/swift/hooks","issue_events_url":"https://api.github.com/repos/ktopley-apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/ktopley-apple/swift/events","assignees_url":"https://api.github.com/repos/ktopley-apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/ktopley-apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/ktopley-apple/swift/tags","blobs_url":"https://api.github.com/repos/ktopley-apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ktopley-apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ktopley-apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/ktopley-apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ktopley-apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/ktopley-apple/swift/languages","stargazers_url":"https://api.github.com/repos/ktopley-apple/swift/stargazers","contributors_url":"https://api.github.com/repos/ktopley-apple/swift/contributors","subscribers_url":"https://api.github.com/repos/ktopley-apple/swift/subscribers","subscription_url":"https://api.github.com/repos/ktopley-apple/swift/subscription","commits_url":"https://api.github.com/repos/ktopley-apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/ktopley-apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/ktopley-apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/ktopley-apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/ktopley-apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/ktopley-apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ktopley-apple/swift/merges","archive_url":"https://api.github.com/repos/ktopley-apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ktopley-apple/swift/downloads","issues_url":"https://api.github.com/repos/ktopley-apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/ktopley-apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/ktopley-apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/ktopley-apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ktopley-apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/ktopley-apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/ktopley-apple/swift/deployments","created_at":"2017-04-24T17:02:02Z","updated_at":"2017-04-24T17:02:29Z","pushed_at":"2017-10-16T14:09:24Z","git_url":"git://github.com/ktopley-apple/swift.git","ssh_url":"git@github.com:ktopley-apple/swift.git","clone_url":"https://github.com/ktopley-apple/swift.git","svn_url":"https://github.com/ktopley-apple/swift","homepage":"https://swift.org/","size":230833,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"a9a477a99f2907f56b2786779b742ab0cfecf828","user":{"login":"apple","id":10639145,"avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838949,"name":"swift","full_name":"apple/swift","owner":{"login":"apple","id":10639145,"avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/swift","description":"The Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift","forks_url":"https://api.github.com/repos/apple/swift/forks","keys_url":"https://api.github.com/repos/apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift/teams","hooks_url":"https://api.github.com/repos/apple/swift/hooks","issue_events_url":"https://api.github.com/repos/apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift/events","assignees_url":"https://api.github.com/repos/apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift/tags","blobs_url":"https://api.github.com/repos/apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift/languages","stargazers_url":"https://api.github.com/repos/apple/swift/stargazers","contributors_url":"https://api.github.com/repos/apple/swift/contributors","subscribers_url":"https://api.github.com/repos/apple/swift/subscribers","subscription_url":"https://api.github.com/repos/apple/swift/subscription","commits_url":"https://api.github.com/repos/apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift/merges","archive_url":"https://api.github.com/repos/apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift/downloads","issues_url":"https://api.github.com/repos/apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift/deployments","created_at":"2015-10-23T21:15:07Z","updated_at":"2017-10-16T14:17:00Z","pushed_at":"2017-10-16T14:37:34Z","git_url":"git://github.com/apple/swift.git","ssh_url":"git@github.com:apple/swift.git","clone_url":"https://github.com/apple/swift.git","svn_url":"https://github.com/apple/swift","homepage":"https://swift.org/","size":232565,"stargazers_count":41082,"watchers_count":41082,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6363,"mirror_url":null,"open_issues_count":179,"forks":6363,"open_issues":179,"watchers":41082,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/12387"},"html":{"href":"https://github.com/apple/swift/pull/12387"},"issue":{"href":"https://api.github.com/repos/apple/swift/issues/12387"},"comments":{"href":"https://api.github.com/repos/apple/swift/issues/12387/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift/pulls/12387/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift/pulls/12387/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift/statuses/1da4b04d9992fd9a27881e2a7fea7d6be3182269"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"ktopley-apple","id":25260843,"avatar_url":"https://avatars3.githubusercontent.com/u/25260843?v=4","gravatar_id":"","url":"https://api.github.com/users/ktopley-apple","html_url":"https://github.com/ktopley-apple","followers_url":"https://api.github.com/users/ktopley-apple/followers","following_url":"https://api.github.com/users/ktopley-apple/following{/other_user}","gists_url":"https://api.github.com/users/ktopley-apple/gists{/gist_id}","starred_url":"https://api.github.com/users/ktopley-apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ktopley-apple/subscriptions","organizations_url":"https://api.github.com/users/ktopley-apple/orgs","repos_url":"https://api.github.com/users/ktopley-apple/repos","events_url":"https://api.github.com/users/ktopley-apple/events{/privacy}","received_events_url":"https://api.github.com/users/ktopley-apple/received_events","type":"User","site_admin":false},"comments":5,"review_comments":6,"maintainer_can_modify":false,"commits":1,"additions":39,"deletions":9,"changed_files":2}}
{"actor":{"display_login":"ktopley-apple"}}