{"action":"created","comment":{"url":"https://api.github.com/repos/huningxin/ORB_SLAM2/pulls/comments/149879579","pull_request_review_id":75343758,"id":149879579,"diff_hunk":"@@ -1451,6 +1463,78 @@ void TemplatedVocabulary<TDescriptor,F>::saveToTextFile(const std::string &filen\n // --------------------------------------------------------------------------\n \n template<class TDescriptor, class F>\n+bool TemplatedVocabulary<TDescriptor,F>::loadFromBinaryFile(const std::string &filename) {","path":"Thirdparty/DBoW2/DBoW2/TemplatedVocabulary.h","position":23,"original_position":23,"commit_id":"6a0ce411096b501130ee3544d9db9b3c843b251f","original_commit_id":"6a0ce411096b501130ee3544d9db9b3c843b251f","user":{"login":"pancx","id":16699894,"avatar_url":"https://avatars0.githubusercontent.com/u/16699894?v=4","gravatar_id":"","url":"https://api.github.com/users/pancx","html_url":"https://github.com/pancx","followers_url":"https://api.github.com/users/pancx/followers","following_url":"https://api.github.com/users/pancx/following{/other_user}","gists_url":"https://api.github.com/users/pancx/gists{/gist_id}","starred_url":"https://api.github.com/users/pancx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pancx/subscriptions","organizations_url":"https://api.github.com/users/pancx/orgs","repos_url":"https://api.github.com/users/pancx/repos","events_url":"https://api.github.com/users/pancx/events{/privacy}","received_events_url":"https://api.github.com/users/pancx/received_events","type":"User","site_admin":false},"body":"It is from https://github.com/raulmur/ORB_SLAM2/pull/21. But it hasn't been accepted and now the branch has conflicts. So I change the code manually.","created_at":"2017-11-09T07:02:14Z","updated_at":"2017-11-09T07:02:15Z","html_url":"https://github.com/huningxin/ORB_SLAM2/pull/1#discussion_r149879579","pull_request_url":"https://api.github.com/repos/huningxin/ORB_SLAM2/pulls/1","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/huningxin/ORB_SLAM2/pulls/comments/149879579"},"html":{"href":"https://github.com/huningxin/ORB_SLAM2/pull/1#discussion_r149879579"},"pull_request":{"href":"https://api.github.com/repos/huningxin/ORB_SLAM2/pulls/1"}},"in_reply_to_id":149875805},"pull_request":{"url":"https://api.github.com/repos/huningxin/ORB_SLAM2/pulls/1","id":151570739,"html_url":"https://github.com/huningxin/ORB_SLAM2/pull/1","diff_url":"https://github.com/huningxin/ORB_SLAM2/pull/1.diff","patch_url":"https://github.com/huningxin/ORB_SLAM2/pull/1.patch","issue_url":"https://api.github.com/repos/huningxin/ORB_SLAM2/issues/1","number":1,"state":"open","locked":false,"title":"add ORBvoc.bin to speed up the voc file loading","user":{"login":"pancx","id":16699894,"avatar_url":"https://avatars0.githubusercontent.com/u/16699894?v=4","gravatar_id":"","url":"https://api.github.com/users/pancx","html_url":"https://github.com/pancx","followers_url":"https://api.github.com/users/pancx/followers","following_url":"https://api.github.com/users/pancx/following{/other_user}","gists_url":"https://api.github.com/users/pancx/gists{/gist_id}","starred_url":"https://api.github.com/users/pancx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pancx/subscriptions","organizations_url":"https://api.github.com/users/pancx/orgs","repos_url":"https://api.github.com/users/pancx/repos","events_url":"https://api.github.com/users/pancx/events{/privacy}","received_events_url":"https://api.github.com/users/pancx/received_events","type":"User","site_admin":false},"body":"1. add ORBvoc.bin to speed up the voc file loading\r\n2. Replace cv to Module in js sample.","created_at":"2017-11-09T06:24:51Z","updated_at":"2017-11-09T07:02:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fb7d6880519d1dc40379306dfacbea43da2998b7","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/huningxin/ORB_SLAM2/pulls/1/commits","review_comments_url":"https://api.github.com/repos/huningxin/ORB_SLAM2/pulls/1/comments","review_comment_url":"https://api.github.com/repos/huningxin/ORB_SLAM2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/huningxin/ORB_SLAM2/issues/1/comments","statuses_url":"https://api.github.com/repos/huningxin/ORB_SLAM2/statuses/6a0ce411096b501130ee3544d9db9b3c843b251f","head":{"label":"pancx:js","ref":"js","sha":"6a0ce411096b501130ee3544d9db9b3c843b251f","user":{"login":"pancx","id":16699894,"avatar_url":"https://avatars0.githubusercontent.com/u/16699894?v=4","gravatar_id":"","url":"https://api.github.com/users/pancx","html_url":"https://github.com/pancx","followers_url":"https://api.github.com/users/pancx/followers","following_url":"https://api.github.com/users/pancx/following{/other_user}","gists_url":"https://api.github.com/users/pancx/gists{/gist_id}","starred_url":"https://api.github.com/users/pancx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pancx/subscriptions","organizations_url":"https://api.github.com/users/pancx/orgs","repos_url":"https://api.github.com/users/pancx/repos","events_url":"https://api.github.com/users/pancx/events{/privacy}","received_events_url":"https://api.github.com/users/pancx/received_events","type":"User","site_admin":false},"repo":{"id":110060034,"name":"ORB_SLAM2","full_name":"pancx/ORB_SLAM2","owner":{"login":"pancx","id":16699894,"avatar_url":"https://avatars0.githubusercontent.com/u/16699894?v=4","gravatar_id":"","url":"https://api.github.com/users/pancx","html_url":"https://github.com/pancx","followers_url":"https://api.github.com/users/pancx/followers","following_url":"https://api.github.com/users/pancx/following{/other_user}","gists_url":"https://api.github.com/users/pancx/gists{/gist_id}","starred_url":"https://api.github.com/users/pancx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pancx/subscriptions","organizations_url":"https://api.github.com/users/pancx/orgs","repos_url":"https://api.github.com/users/pancx/repos","events_url":"https://api.github.com/users/pancx/events{/privacy}","received_events_url":"https://api.github.com/users/pancx/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pancx/ORB_SLAM2","description":"Real-Time SLAM for Monocular, Stereo and RGB-D Cameras, with Loop Detection and Relocalization Capabilities","fork":true,"url":"https://api.github.com/repos/pancx/ORB_SLAM2","forks_url":"https://api.github.com/repos/pancx/ORB_SLAM2/forks","keys_url":"https://api.github.com/repos/pancx/ORB_SLAM2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pancx/ORB_SLAM2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pancx/ORB_SLAM2/teams","hooks_url":"https://api.github.com/repos/pancx/ORB_SLAM2/hooks","issue_events_url":"https://api.github.com/repos/pancx/ORB_SLAM2/issues/events{/number}","events_url":"https://api.github.com/repos/pancx/ORB_SLAM2/events","assignees_url":"https://api.github.com/repos/pancx/ORB_SLAM2/assignees{/user}","branches_url":"https://api.github.com/repos/pancx/ORB_SLAM2/branches{/branch}","tags_url":"https://api.github.com/repos/pancx/ORB_SLAM2/tags","blobs_url":"https://api.github.com/repos/pancx/ORB_SLAM2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pancx/ORB_SLAM2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pancx/ORB_SLAM2/git/refs{/sha}","trees_url":"https://api.github.com/repos/pancx/ORB_SLAM2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pancx/ORB_SLAM2/statuses/{sha}","languages_url":"https://api.github.com/repos/pancx/ORB_SLAM2/languages","stargazers_url":"https://api.github.com/repos/pancx/ORB_SLAM2/stargazers","contributors_url":"https://api.github.com/repos/pancx/ORB_SLAM2/contributors","subscribers_url":"https://api.github.com/repos/pancx/ORB_SLAM2/subscribers","subscription_url":"https://api.github.com/repos/pancx/ORB_SLAM2/subscription","commits_url":"https://api.github.com/repos/pancx/ORB_SLAM2/commits{/sha}","git_commits_url":"https://api.github.com/repos/pancx/ORB_SLAM2/git/commits{/sha}","comments_url":"https://api.github.com/repos/pancx/ORB_SLAM2/comments{/number}","issue_comment_url":"https://api.github.com/repos/pancx/ORB_SLAM2/issues/comments{/number}","contents_url":"https://api.github.com/repos/pancx/ORB_SLAM2/contents/{+path}","compare_url":"https://api.github.com/repos/pancx/ORB_SLAM2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pancx/ORB_SLAM2/merges","archive_url":"https://api.github.com/repos/pancx/ORB_SLAM2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pancx/ORB_SLAM2/downloads","issues_url":"https://api.github.com/repos/pancx/ORB_SLAM2/issues{/number}","pulls_url":"https://api.github.com/repos/pancx/ORB_SLAM2/pulls{/number}","milestones_url":"https://api.github.com/repos/pancx/ORB_SLAM2/milestones{/number}","notifications_url":"https://api.github.com/repos/pancx/ORB_SLAM2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pancx/ORB_SLAM2/labels{/name}","releases_url":"https://api.github.com/repos/pancx/ORB_SLAM2/releases{/id}","deployments_url":"https://api.github.com/repos/pancx/ORB_SLAM2/deployments","created_at":"2017-11-09T03:00:19Z","updated_at":"2017-11-09T03:00:22Z","pushed_at":"2017-11-09T03:07:48Z","git_url":"git://github.com/pancx/ORB_SLAM2.git","ssh_url":"git@github.com:pancx/ORB_SLAM2.git","clone_url":"https://github.com/pancx/ORB_SLAM2.git","svn_url":"https://github.com/pancx/ORB_SLAM2","homepage":null,"size":77183,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"huningxin:js","ref":"js","sha":"88911e9b78bed4f84f1ebbcddcc9b01692e4493e","user":{"login":"huningxin","id":1005673,"avatar_url":"https://avatars1.githubusercontent.com/u/1005673?v=4","gravatar_id":"","url":"https://api.github.com/users/huningxin","html_url":"https://github.com/huningxin","followers_url":"https://api.github.com/users/huningxin/followers","following_url":"https://api.github.com/users/huningxin/following{/other_user}","gists_url":"https://api.github.com/users/huningxin/gists{/gist_id}","starred_url":"https://api.github.com/users/huningxin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huningxin/subscriptions","organizations_url":"https://api.github.com/users/huningxin/orgs","repos_url":"https://api.github.com/users/huningxin/repos","events_url":"https://api.github.com/users/huningxin/events{/privacy}","received_events_url":"https://api.github.com/users/huningxin/received_events","type":"User","site_admin":false},"repo":{"id":101962413,"name":"ORB_SLAM2","full_name":"huningxin/ORB_SLAM2","owner":{"login":"huningxin","id":1005673,"avatar_url":"https://avatars1.githubusercontent.com/u/1005673?v=4","gravatar_id":"","url":"https://api.github.com/users/huningxin","html_url":"https://github.com/huningxin","followers_url":"https://api.github.com/users/huningxin/followers","following_url":"https://api.github.com/users/huningxin/following{/other_user}","gists_url":"https://api.github.com/users/huningxin/gists{/gist_id}","starred_url":"https://api.github.com/users/huningxin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huningxin/subscriptions","organizations_url":"https://api.github.com/users/huningxin/orgs","repos_url":"https://api.github.com/users/huningxin/repos","events_url":"https://api.github.com/users/huningxin/events{/privacy}","received_events_url":"https://api.github.com/users/huningxin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/huningxin/ORB_SLAM2","description":"Real-Time SLAM for Monocular, Stereo and RGB-D Cameras, with Loop Detection and Relocalization Capabilities","fork":true,"url":"https://api.github.com/repos/huningxin/ORB_SLAM2","forks_url":"https://api.github.com/repos/huningxin/ORB_SLAM2/forks","keys_url":"https://api.github.com/repos/huningxin/ORB_SLAM2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/huningxin/ORB_SLAM2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/huningxin/ORB_SLAM2/teams","hooks_url":"https://api.github.com/repos/huningxin/ORB_SLAM2/hooks","issue_events_url":"https://api.github.com/repos/huningxin/ORB_SLAM2/issues/events{/number}","events_url":"https://api.github.com/repos/huningxin/ORB_SLAM2/events","assignees_url":"https://api.github.com/repos/huningxin/ORB_SLAM2/assignees{/user}","branches_url":"https://api.github.com/repos/huningxin/ORB_SLAM2/branches{/branch}","tags_url":"https://api.github.com/repos/huningxin/ORB_SLAM2/tags","blobs_url":"https://api.github.com/repos/huningxin/ORB_SLAM2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/huningxin/ORB_SLAM2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/huningxin/ORB_SLAM2/git/refs{/sha}","trees_url":"https://api.github.com/repos/huningxin/ORB_SLAM2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/huningxin/ORB_SLAM2/statuses/{sha}","languages_url":"https://api.github.com/repos/huningxin/ORB_SLAM2/languages","stargazers_url":"https://api.github.com/repos/huningxin/ORB_SLAM2/stargazers","contributors_url":"https://api.github.com/repos/huningxin/ORB_SLAM2/contributors","subscribers_url":"https://api.github.com/repos/huningxin/ORB_SLAM2/subscribers","subscription_url":"https://api.github.com/repos/huningxin/ORB_SLAM2/subscription","commits_url":"https://api.github.com/repos/huningxin/ORB_SLAM2/commits{/sha}","git_commits_url":"https://api.github.com/repos/huningxin/ORB_SLAM2/git/commits{/sha}","comments_url":"https://api.github.com/repos/huningxin/ORB_SLAM2/comments{/number}","issue_comment_url":"https://api.github.com/repos/huningxin/ORB_SLAM2/issues/comments{/number}","contents_url":"https://api.github.com/repos/huningxin/ORB_SLAM2/contents/{+path}","compare_url":"https://api.github.com/repos/huningxin/ORB_SLAM2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/huningxin/ORB_SLAM2/merges","archive_url":"https://api.github.com/repos/huningxin/ORB_SLAM2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/huningxin/ORB_SLAM2/downloads","issues_url":"https://api.github.com/repos/huningxin/ORB_SLAM2/issues{/number}","pulls_url":"https://api.github.com/repos/huningxin/ORB_SLAM2/pulls{/number}","milestones_url":"https://api.github.com/repos/huningxin/ORB_SLAM2/milestones{/number}","notifications_url":"https://api.github.com/repos/huningxin/ORB_SLAM2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/huningxin/ORB_SLAM2/labels{/name}","releases_url":"https://api.github.com/repos/huningxin/ORB_SLAM2/releases{/id}","deployments_url":"https://api.github.com/repos/huningxin/ORB_SLAM2/deployments","created_at":"2017-08-31T05:21:43Z","updated_at":"2017-08-31T05:21:45Z","pushed_at":"2017-11-09T06:24:51Z","git_url":"git://github.com/huningxin/ORB_SLAM2.git","ssh_url":"git@github.com:huningxin/ORB_SLAM2.git","clone_url":"https://github.com/huningxin/ORB_SLAM2.git","svn_url":"https://github.com/huningxin/ORB_SLAM2","homepage":null,"size":44936,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/huningxin/ORB_SLAM2/pulls/1"},"html":{"href":"https://github.com/huningxin/ORB_SLAM2/pull/1"},"issue":{"href":"https://api.github.com/repos/huningxin/ORB_SLAM2/issues/1"},"comments":{"href":"https://api.github.com/repos/huningxin/ORB_SLAM2/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/huningxin/ORB_SLAM2/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/huningxin/ORB_SLAM2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/huningxin/ORB_SLAM2/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/huningxin/ORB_SLAM2/statuses/6a0ce411096b501130ee3544d9db9b3c843b251f"}},"author_association":"NONE"}}
{"actor":{"display_login":"pancx"}}