{"action":"created","issue":{"url":"https://api.github.com/repos/mixxxdj/mixxx/issues/1207","repository_url":"https://api.github.com/repos/mixxxdj/mixxx","labels_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/1207/labels{/name}","comments_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/1207/comments","events_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/1207/events","html_url":"https://github.com/mixxxdj/mixxx/pull/1207","id":212019406,"number":1207,"title":"Cover art UX improvements","user":{"login":"Be-ing","id":9455094,"avatar_url":"https://avatars0.githubusercontent.com/u/9455094?v=3","gravatar_id":"","url":"https://api.github.com/users/Be-ing","html_url":"https://github.com/Be-ing","followers_url":"https://api.github.com/users/Be-ing/followers","following_url":"https://api.github.com/users/Be-ing/following{/other_user}","gists_url":"https://api.github.com/users/Be-ing/gists{/gist_id}","starred_url":"https://api.github.com/users/Be-ing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Be-ing/subscriptions","organizations_url":"https://api.github.com/users/Be-ing/orgs","repos_url":"https://api.github.com/users/Be-ing/repos","events_url":"https://api.github.com/users/Be-ing/events{/privacy}","received_events_url":"https://api.github.com/users/Be-ing/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2017-03-06T04:05:44Z","updated_at":"2017-03-28T19:14:56Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1207","html_url":"https://github.com/mixxxdj/mixxx/pull/1207","diff_url":"https://github.com/mixxxdj/mixxx/pull/1207.diff","patch_url":"https://github.com/mixxxdj/mixxx/pull/1207.patch"},"body":"Rework the UX for showing DlgCoverArtFullSize:\r\n  * don't close DlgCoverArtFullSize when moving cursor off WCoverArt. IMO this was surprising and confusing.\r\n  * close DlgCoverArtFullSize when clicked\r\n  * show DlgCoverArtFullSize when right clicking WSpinny. Before, right clicking on WSpinny paused the track and enabled slip mode. I can't think of a use case for that behavior. The change allows skins to show only WSpinny with cover art but without taking space with a redundant WCoverArt and still make DlgCoverArtFullSize available."},"comment":{"url":"https://api.github.com/repos/mixxxdj/mixxx/issues/comments/289874994","html_url":"https://github.com/mixxxdj/mixxx/pull/1207#issuecomment-289874994","issue_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/1207","id":289874994,"user":{"login":"Be-ing","id":9455094,"avatar_url":"https://avatars0.githubusercontent.com/u/9455094?v=3","gravatar_id":"","url":"https://api.github.com/users/Be-ing","html_url":"https://github.com/Be-ing","followers_url":"https://api.github.com/users/Be-ing/followers","following_url":"https://api.github.com/users/Be-ing/following{/other_user}","gists_url":"https://api.github.com/users/Be-ing/gists{/gist_id}","starred_url":"https://api.github.com/users/Be-ing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Be-ing/subscriptions","organizations_url":"https://api.github.com/users/Be-ing/orgs","repos_url":"https://api.github.com/users/Be-ing/repos","events_url":"https://api.github.com/users/Be-ing/events{/privacy}","received_events_url":"https://api.github.com/users/Be-ing/received_events","type":"User","site_admin":false},"created_at":"2017-03-28T19:14:56Z","updated_at":"2017-03-28T19:14:56Z","body":"I made DlgCoverArtFullSize a normal window with a border. I think this obviates making only one DlgCoverArtFullSize show at a time, which would be quite complicated to implement. It can now be resized by dragging the window border or by using a mouse scroll wheel. Unfortunately Qt does not make it easy to preserve the aspect ratio of a widget, so the graphic is scaled proportional to its aspect ratio, but there can be blank space on the sides of the window if it is stretched outside of the cover's aspect ratio. Also, right clicking on DlgCoverArtFullSize brings up the cover art context menu. Right clicking on a WSpinny with a track loaded that does not have cover art set also brings up the cover art context menu. DlgCoverArtFullSize responds to changing the cover art and loading new tracks too."}}
{"actor":{"display_login":"Be-ing"}}