{"action":"created","comment":{"url":"https://api.github.com/repos/livecode/livecode/pulls/comments/118693860","pull_request_review_id":40511930,"id":118693860,"diff_hunk":"@@ -918,3 +918,37 @@ repeat with i = 1 to 10\n end repeat\n \n end TestMathArrayWrapArray\n+\n+on _RandomMaxLimitTestThrows\n+\n+\tlocal tN1, tN2\n+\n+\tput 2^53 into tN1","path":"tests/lcs/core/math/math.livecodescript","position":9,"original_position":9,"commit_id":"5c59889d8add4d8cc240e2f17ecbb555e48ccd63","original_commit_id":"5c59889d8add4d8cc240e2f17ecbb555e48ccd63","user":{"login":"runrevmark","id":3985298,"avatar_url":"https://avatars3.githubusercontent.com/u/3985298?v=3","gravatar_id":"","url":"https://api.github.com/users/runrevmark","html_url":"https://github.com/runrevmark","followers_url":"https://api.github.com/users/runrevmark/followers","following_url":"https://api.github.com/users/runrevmark/following{/other_user}","gists_url":"https://api.github.com/users/runrevmark/gists{/gist_id}","starred_url":"https://api.github.com/users/runrevmark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runrevmark/subscriptions","organizations_url":"https://api.github.com/users/runrevmark/orgs","repos_url":"https://api.github.com/users/runrevmark/repos","events_url":"https://api.github.com/users/runrevmark/events{/privacy}","received_events_url":"https://api.github.com/users/runrevmark/received_events","type":"User","site_admin":false},"body":"I think 2^53 should be fine as that is the maximum number we can represent - so you need to use the next representable double *after* 2^53 to trigger a throw.","created_at":"2017-05-26T12:45:09Z","updated_at":"2017-05-26T12:45:09Z","html_url":"https://github.com/livecode/livecode/pull/5473#discussion_r118693860","pull_request_url":"https://api.github.com/repos/livecode/livecode/pulls/5473","_links":{"self":{"href":"https://api.github.com/repos/livecode/livecode/pulls/comments/118693860"},"html":{"href":"https://github.com/livecode/livecode/pull/5473#discussion_r118693860"},"pull_request":{"href":"https://api.github.com/repos/livecode/livecode/pulls/5473"}}},"pull_request":{"url":"https://api.github.com/repos/livecode/livecode/pulls/5473","id":120856192,"html_url":"https://github.com/livecode/livecode/pull/5473","diff_url":"https://github.com/livecode/livecode/pull/5473.diff","patch_url":"https://github.com/livecode/livecode/pull/5473.patch","issue_url":"https://api.github.com/repos/livecode/livecode/issues/5473","number":5473,"state":"open","locked":false,"title":"[[ Bug 19271 ]] Expand range of 'random()' to 53-bits","user":{"login":"livecodealex","id":15053373,"avatar_url":"https://avatars3.githubusercontent.com/u/15053373?v=3","gravatar_id":"","url":"https://api.github.com/users/livecodealex","html_url":"https://github.com/livecodealex","followers_url":"https://api.github.com/users/livecodealex/followers","following_url":"https://api.github.com/users/livecodealex/following{/other_user}","gists_url":"https://api.github.com/users/livecodealex/gists{/gist_id}","starred_url":"https://api.github.com/users/livecodealex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/livecodealex/subscriptions","organizations_url":"https://api.github.com/users/livecodealex/orgs","repos_url":"https://api.github.com/users/livecodealex/repos","events_url":"https://api.github.com/users/livecodealex/events{/privacy}","received_events_url":"https://api.github.com/users/livecodealex/received_events","type":"User","site_admin":false},"body":"Defined constants for limits of integer representation as double and increased input limit of random function to 2^53 - 1","created_at":"2017-05-16T15:25:27Z","updated_at":"2017-05-26T12:45:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5769a72e7cd9ca8886867f22ea7a9f924ddeb89e","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/livecode/livecode/milestones/136","html_url":"https://github.com/livecode/livecode/milestone/136","labels_url":"https://api.github.com/repos/livecode/livecode/milestones/136/labels","id":2355885,"number":136,"title":"9.0.0-dp-7","description":null,"creator":{"login":"livecodeali","id":3985854,"avatar_url":"https://avatars3.githubusercontent.com/u/3985854?v=3","gravatar_id":"","url":"https://api.github.com/users/livecodeali","html_url":"https://github.com/livecodeali","followers_url":"https://api.github.com/users/livecodeali/followers","following_url":"https://api.github.com/users/livecodeali/following{/other_user}","gists_url":"https://api.github.com/users/livecodeali/gists{/gist_id}","starred_url":"https://api.github.com/users/livecodeali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/livecodeali/subscriptions","organizations_url":"https://api.github.com/users/livecodeali/orgs","repos_url":"https://api.github.com/users/livecodeali/repos","events_url":"https://api.github.com/users/livecodeali/events{/privacy}","received_events_url":"https://api.github.com/users/livecodeali/received_events","type":"User","site_admin":false},"open_issues":24,"closed_issues":111,"state":"open","created_at":"2017-03-01T11:58:49Z","updated_at":"2017-05-26T10:57:05Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/livecode/livecode/pulls/5473/commits","review_comments_url":"https://api.github.com/repos/livecode/livecode/pulls/5473/comments","review_comment_url":"https://api.github.com/repos/livecode/livecode/pulls/comments{/number}","comments_url":"https://api.github.com/repos/livecode/livecode/issues/5473/comments","statuses_url":"https://api.github.com/repos/livecode/livecode/statuses/5c59889d8add4d8cc240e2f17ecbb555e48ccd63","head":{"label":"livecodealex:bugfix-19271","ref":"bugfix-19271","sha":"5c59889d8add4d8cc240e2f17ecbb555e48ccd63","user":{"login":"livecodealex","id":15053373,"avatar_url":"https://avatars3.githubusercontent.com/u/15053373?v=3","gravatar_id":"","url":"https://api.github.com/users/livecodealex","html_url":"https://github.com/livecodealex","followers_url":"https://api.github.com/users/livecodealex/followers","following_url":"https://api.github.com/users/livecodealex/following{/other_user}","gists_url":"https://api.github.com/users/livecodealex/gists{/gist_id}","starred_url":"https://api.github.com/users/livecodealex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/livecodealex/subscriptions","organizations_url":"https://api.github.com/users/livecodealex/orgs","repos_url":"https://api.github.com/users/livecodealex/repos","events_url":"https://api.github.com/users/livecodealex/events{/privacy}","received_events_url":"https://api.github.com/users/livecodealex/received_events","type":"User","site_admin":false},"repo":{"id":91338883,"name":"livecode","full_name":"livecodealex/livecode","owner":{"login":"livecodealex","id":15053373,"avatar_url":"https://avatars3.githubusercontent.com/u/15053373?v=3","gravatar_id":"","url":"https://api.github.com/users/livecodealex","html_url":"https://github.com/livecodealex","followers_url":"https://api.github.com/users/livecodealex/followers","following_url":"https://api.github.com/users/livecodealex/following{/other_user}","gists_url":"https://api.github.com/users/livecodealex/gists{/gist_id}","starred_url":"https://api.github.com/users/livecodealex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/livecodealex/subscriptions","organizations_url":"https://api.github.com/users/livecodealex/orgs","repos_url":"https://api.github.com/users/livecodealex/repos","events_url":"https://api.github.com/users/livecodealex/events{/privacy}","received_events_url":"https://api.github.com/users/livecodealex/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/livecodealex/livecode","description":"LiveCode cross-platform development environment (engine)","fork":true,"url":"https://api.github.com/repos/livecodealex/livecode","forks_url":"https://api.github.com/repos/livecodealex/livecode/forks","keys_url":"https://api.github.com/repos/livecodealex/livecode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/livecodealex/livecode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/livecodealex/livecode/teams","hooks_url":"https://api.github.com/repos/livecodealex/livecode/hooks","issue_events_url":"https://api.github.com/repos/livecodealex/livecode/issues/events{/number}","events_url":"https://api.github.com/repos/livecodealex/livecode/events","assignees_url":"https://api.github.com/repos/livecodealex/livecode/assignees{/user}","branches_url":"https://api.github.com/repos/livecodealex/livecode/branches{/branch}","tags_url":"https://api.github.com/repos/livecodealex/livecode/tags","blobs_url":"https://api.github.com/repos/livecodealex/livecode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/livecodealex/livecode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/livecodealex/livecode/git/refs{/sha}","trees_url":"https://api.github.com/repos/livecodealex/livecode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/livecodealex/livecode/statuses/{sha}","languages_url":"https://api.github.com/repos/livecodealex/livecode/languages","stargazers_url":"https://api.github.com/repos/livecodealex/livecode/stargazers","contributors_url":"https://api.github.com/repos/livecodealex/livecode/contributors","subscribers_url":"https://api.github.com/repos/livecodealex/livecode/subscribers","subscription_url":"https://api.github.com/repos/livecodealex/livecode/subscription","commits_url":"https://api.github.com/repos/livecodealex/livecode/commits{/sha}","git_commits_url":"https://api.github.com/repos/livecodealex/livecode/git/commits{/sha}","comments_url":"https://api.github.com/repos/livecodealex/livecode/comments{/number}","issue_comment_url":"https://api.github.com/repos/livecodealex/livecode/issues/comments{/number}","contents_url":"https://api.github.com/repos/livecodealex/livecode/contents/{+path}","compare_url":"https://api.github.com/repos/livecodealex/livecode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/livecodealex/livecode/merges","archive_url":"https://api.github.com/repos/livecodealex/livecode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/livecodealex/livecode/downloads","issues_url":"https://api.github.com/repos/livecodealex/livecode/issues{/number}","pulls_url":"https://api.github.com/repos/livecodealex/livecode/pulls{/number}","milestones_url":"https://api.github.com/repos/livecodealex/livecode/milestones{/number}","notifications_url":"https://api.github.com/repos/livecodealex/livecode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/livecodealex/livecode/labels{/name}","releases_url":"https://api.github.com/repos/livecodealex/livecode/releases{/id}","deployments_url":"https://api.github.com/repos/livecodealex/livecode/deployments","created_at":"2017-05-15T13:06:02Z","updated_at":"2017-05-15T13:06:16Z","pushed_at":"2017-05-26T11:57:35Z","git_url":"git://github.com/livecodealex/livecode.git","ssh_url":"git@github.com:livecodealex/livecode.git","clone_url":"https://github.com/livecodealex/livecode.git","svn_url":"https://github.com/livecodealex/livecode","homepage":"https://livecode.com/","size":138931,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"livecode:develop","ref":"develop","sha":"9a364b67d301084d38faa6bdc9f8733e6f64e3f4","user":{"login":"livecode","id":3985749,"avatar_url":"https://avatars2.githubusercontent.com/u/3985749?v=3","gravatar_id":"","url":"https://api.github.com/users/livecode","html_url":"https://github.com/livecode","followers_url":"https://api.github.com/users/livecode/followers","following_url":"https://api.github.com/users/livecode/following{/other_user}","gists_url":"https://api.github.com/users/livecode/gists{/gist_id}","starred_url":"https://api.github.com/users/livecode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/livecode/subscriptions","organizations_url":"https://api.github.com/users/livecode/orgs","repos_url":"https://api.github.com/users/livecode/repos","events_url":"https://api.github.com/users/livecode/events{/privacy}","received_events_url":"https://api.github.com/users/livecode/received_events","type":"Organization","site_admin":false},"repo":{"id":9334445,"name":"livecode","full_name":"livecode/livecode","owner":{"login":"livecode","id":3985749,"avatar_url":"https://avatars2.githubusercontent.com/u/3985749?v=3","gravatar_id":"","url":"https://api.github.com/users/livecode","html_url":"https://github.com/livecode","followers_url":"https://api.github.com/users/livecode/followers","following_url":"https://api.github.com/users/livecode/following{/other_user}","gists_url":"https://api.github.com/users/livecode/gists{/gist_id}","starred_url":"https://api.github.com/users/livecode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/livecode/subscriptions","organizations_url":"https://api.github.com/users/livecode/orgs","repos_url":"https://api.github.com/users/livecode/repos","events_url":"https://api.github.com/users/livecode/events{/privacy}","received_events_url":"https://api.github.com/users/livecode/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/livecode/livecode","description":"LiveCode cross-platform development environment (engine)","fork":false,"url":"https://api.github.com/repos/livecode/livecode","forks_url":"https://api.github.com/repos/livecode/livecode/forks","keys_url":"https://api.github.com/repos/livecode/livecode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/livecode/livecode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/livecode/livecode/teams","hooks_url":"https://api.github.com/repos/livecode/livecode/hooks","issue_events_url":"https://api.github.com/repos/livecode/livecode/issues/events{/number}","events_url":"https://api.github.com/repos/livecode/livecode/events","assignees_url":"https://api.github.com/repos/livecode/livecode/assignees{/user}","branches_url":"https://api.github.com/repos/livecode/livecode/branches{/branch}","tags_url":"https://api.github.com/repos/livecode/livecode/tags","blobs_url":"https://api.github.com/repos/livecode/livecode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/livecode/livecode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/livecode/livecode/git/refs{/sha}","trees_url":"https://api.github.com/repos/livecode/livecode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/livecode/livecode/statuses/{sha}","languages_url":"https://api.github.com/repos/livecode/livecode/languages","stargazers_url":"https://api.github.com/repos/livecode/livecode/stargazers","contributors_url":"https://api.github.com/repos/livecode/livecode/contributors","subscribers_url":"https://api.github.com/repos/livecode/livecode/subscribers","subscription_url":"https://api.github.com/repos/livecode/livecode/subscription","commits_url":"https://api.github.com/repos/livecode/livecode/commits{/sha}","git_commits_url":"https://api.github.com/repos/livecode/livecode/git/commits{/sha}","comments_url":"https://api.github.com/repos/livecode/livecode/comments{/number}","issue_comment_url":"https://api.github.com/repos/livecode/livecode/issues/comments{/number}","contents_url":"https://api.github.com/repos/livecode/livecode/contents/{+path}","compare_url":"https://api.github.com/repos/livecode/livecode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/livecode/livecode/merges","archive_url":"https://api.github.com/repos/livecode/livecode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/livecode/livecode/downloads","issues_url":"https://api.github.com/repos/livecode/livecode/issues{/number}","pulls_url":"https://api.github.com/repos/livecode/livecode/pulls{/number}","milestones_url":"https://api.github.com/repos/livecode/livecode/milestones{/number}","notifications_url":"https://api.github.com/repos/livecode/livecode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/livecode/livecode/labels{/name}","releases_url":"https://api.github.com/repos/livecode/livecode/releases{/id}","deployments_url":"https://api.github.com/repos/livecode/livecode/deployments","created_at":"2013-04-10T00:15:57Z","updated_at":"2017-05-23T15:49:37Z","pushed_at":"2017-05-26T12:05:45Z","git_url":"git://github.com/livecode/livecode.git","ssh_url":"git@github.com:livecode/livecode.git","clone_url":"https://github.com/livecode/livecode.git","svn_url":"https://github.com/livecode/livecode","homepage":"https://livecode.com/","size":139491,"stargazers_count":171,"watchers_count":171,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":120,"mirror_url":null,"open_issues_count":89,"forks":120,"open_issues":89,"watchers":171,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/livecode/livecode/pulls/5473"},"html":{"href":"https://github.com/livecode/livecode/pull/5473"},"issue":{"href":"https://api.github.com/repos/livecode/livecode/issues/5473"},"comments":{"href":"https://api.github.com/repos/livecode/livecode/issues/5473/comments"},"review_comments":{"href":"https://api.github.com/repos/livecode/livecode/pulls/5473/comments"},"review_comment":{"href":"https://api.github.com/repos/livecode/livecode/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/livecode/livecode/pulls/5473/commits"},"statuses":{"href":"https://api.github.com/repos/livecode/livecode/statuses/5c59889d8add4d8cc240e2f17ecbb555e48ccd63"}}}}
{"actor":{"display_login":"runrevmark"}}