{"action":"created","comment":{"url":"https://api.github.com/repos/kiibohd/kll/pulls/comments/126317005","pull_request_review_id":48788580,"id":126317005,"diff_hunk":"@@ -460,7 +479,188 @@ def seed_context( self, kll_file ):\n \t\t'''\n \t\tkll_file.context.initial_context( kll_file.lines, kll_file.data, kll_file )\n \n-\tdef process( self ):\n+\tdef process_connect_ids(self, kll_file, apply_offsets):\n+\t\tlines = kll_file.data.splitlines()\n+\n+\t\t# Basic Tokens Spec\n+\t\t# TODO Storing these somewhere central might be a reasonable idea","path":"common/stage.py","position":57,"original_position":57,"commit_id":"e70f165fddfd23de5638adb988ee0e57ddaf2516","original_commit_id":"e70f165fddfd23de5638adb988ee0e57ddaf2516","user":{"login":"JoonasMelin","id":1955817,"avatar_url":"https://avatars3.githubusercontent.com/u/1955817?v=3","gravatar_id":"","url":"https://api.github.com/users/JoonasMelin","html_url":"https://github.com/JoonasMelin","followers_url":"https://api.github.com/users/JoonasMelin/followers","following_url":"https://api.github.com/users/JoonasMelin/following{/other_user}","gists_url":"https://api.github.com/users/JoonasMelin/gists{/gist_id}","starred_url":"https://api.github.com/users/JoonasMelin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoonasMelin/subscriptions","organizations_url":"https://api.github.com/users/JoonasMelin/orgs","repos_url":"https://api.github.com/users/JoonasMelin/repos","events_url":"https://api.github.com/users/JoonasMelin/events{/privacy}","received_events_url":"https://api.github.com/users/JoonasMelin/received_events","type":"User","site_admin":false},"body":"Is there some plans for storing the specs somewhere as there is a danger that they start diverging at some point and that can be a bit of a pain.","created_at":"2017-07-09T22:20:36Z","updated_at":"2017-07-09T22:20:36Z","html_url":"https://github.com/kiibohd/kll/pull/20#discussion_r126317005","pull_request_url":"https://api.github.com/repos/kiibohd/kll/pulls/20","_links":{"self":{"href":"https://api.github.com/repos/kiibohd/kll/pulls/comments/126317005"},"html":{"href":"https://github.com/kiibohd/kll/pull/20#discussion_r126317005"},"pull_request":{"href":"https://api.github.com/repos/kiibohd/kll/pulls/20"}}},"pull_request":{"url":"https://api.github.com/repos/kiibohd/kll/pulls/20","id":129580421,"html_url":"https://github.com/kiibohd/kll/pull/20","diff_url":"https://github.com/kiibohd/kll/pull/20.diff","patch_url":"https://github.com/kiibohd/kll/pull/20.patch","issue_url":"https://api.github.com/repos/kiibohd/kll/issues/20","number":20,"state":"open","locked":false,"title":"Feature/preprocess scancodes","user":{"login":"JoonasMelin","id":1955817,"avatar_url":"https://avatars3.githubusercontent.com/u/1955817?v=3","gravatar_id":"","url":"https://api.github.com/users/JoonasMelin","html_url":"https://github.com/JoonasMelin","followers_url":"https://api.github.com/users/JoonasMelin/followers","following_url":"https://api.github.com/users/JoonasMelin/following{/other_user}","gists_url":"https://api.github.com/users/JoonasMelin/gists{/gist_id}","starred_url":"https://api.github.com/users/JoonasMelin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoonasMelin/subscriptions","organizations_url":"https://api.github.com/users/JoonasMelin/orgs","repos_url":"https://api.github.com/users/JoonasMelin/repos","events_url":"https://api.github.com/users/JoonasMelin/events{/privacy}","received_events_url":"https://api.github.com/users/JoonasMelin/received_events","type":"User","site_admin":false},"body":"This adds in the scancode offsets preprocessor feature.\r\n\r\n I will address few issues before this is good for merging, including comments inline.","created_at":"2017-07-09T22:16:13Z","updated_at":"2017-07-09T22:20:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"50c9812fd76d5d6570c63745df087fa03e461983","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/kiibohd/kll/pulls/20/commits","review_comments_url":"https://api.github.com/repos/kiibohd/kll/pulls/20/comments","review_comment_url":"https://api.github.com/repos/kiibohd/kll/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kiibohd/kll/issues/20/comments","statuses_url":"https://api.github.com/repos/kiibohd/kll/statuses/e70f165fddfd23de5638adb988ee0e57ddaf2516","head":{"label":"JoonasMelin:feature/preprocess-scancodes","ref":"feature/preprocess-scancodes","sha":"e70f165fddfd23de5638adb988ee0e57ddaf2516","user":{"login":"JoonasMelin","id":1955817,"avatar_url":"https://avatars3.githubusercontent.com/u/1955817?v=3","gravatar_id":"","url":"https://api.github.com/users/JoonasMelin","html_url":"https://github.com/JoonasMelin","followers_url":"https://api.github.com/users/JoonasMelin/followers","following_url":"https://api.github.com/users/JoonasMelin/following{/other_user}","gists_url":"https://api.github.com/users/JoonasMelin/gists{/gist_id}","starred_url":"https://api.github.com/users/JoonasMelin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoonasMelin/subscriptions","organizations_url":"https://api.github.com/users/JoonasMelin/orgs","repos_url":"https://api.github.com/users/JoonasMelin/repos","events_url":"https://api.github.com/users/JoonasMelin/events{/privacy}","received_events_url":"https://api.github.com/users/JoonasMelin/received_events","type":"User","site_admin":false},"repo":{"id":95483197,"name":"kll","full_name":"JoonasMelin/kll","owner":{"login":"JoonasMelin","id":1955817,"avatar_url":"https://avatars3.githubusercontent.com/u/1955817?v=3","gravatar_id":"","url":"https://api.github.com/users/JoonasMelin","html_url":"https://github.com/JoonasMelin","followers_url":"https://api.github.com/users/JoonasMelin/followers","following_url":"https://api.github.com/users/JoonasMelin/following{/other_user}","gists_url":"https://api.github.com/users/JoonasMelin/gists{/gist_id}","starred_url":"https://api.github.com/users/JoonasMelin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoonasMelin/subscriptions","organizations_url":"https://api.github.com/users/JoonasMelin/orgs","repos_url":"https://api.github.com/users/JoonasMelin/repos","events_url":"https://api.github.com/users/JoonasMelin/events{/privacy}","received_events_url":"https://api.github.com/users/JoonasMelin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JoonasMelin/kll","description":"KLL Compiler","fork":true,"url":"https://api.github.com/repos/JoonasMelin/kll","forks_url":"https://api.github.com/repos/JoonasMelin/kll/forks","keys_url":"https://api.github.com/repos/JoonasMelin/kll/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JoonasMelin/kll/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JoonasMelin/kll/teams","hooks_url":"https://api.github.com/repos/JoonasMelin/kll/hooks","issue_events_url":"https://api.github.com/repos/JoonasMelin/kll/issues/events{/number}","events_url":"https://api.github.com/repos/JoonasMelin/kll/events","assignees_url":"https://api.github.com/repos/JoonasMelin/kll/assignees{/user}","branches_url":"https://api.github.com/repos/JoonasMelin/kll/branches{/branch}","tags_url":"https://api.github.com/repos/JoonasMelin/kll/tags","blobs_url":"https://api.github.com/repos/JoonasMelin/kll/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JoonasMelin/kll/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JoonasMelin/kll/git/refs{/sha}","trees_url":"https://api.github.com/repos/JoonasMelin/kll/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JoonasMelin/kll/statuses/{sha}","languages_url":"https://api.github.com/repos/JoonasMelin/kll/languages","stargazers_url":"https://api.github.com/repos/JoonasMelin/kll/stargazers","contributors_url":"https://api.github.com/repos/JoonasMelin/kll/contributors","subscribers_url":"https://api.github.com/repos/JoonasMelin/kll/subscribers","subscription_url":"https://api.github.com/repos/JoonasMelin/kll/subscription","commits_url":"https://api.github.com/repos/JoonasMelin/kll/commits{/sha}","git_commits_url":"https://api.github.com/repos/JoonasMelin/kll/git/commits{/sha}","comments_url":"https://api.github.com/repos/JoonasMelin/kll/comments{/number}","issue_comment_url":"https://api.github.com/repos/JoonasMelin/kll/issues/comments{/number}","contents_url":"https://api.github.com/repos/JoonasMelin/kll/contents/{+path}","compare_url":"https://api.github.com/repos/JoonasMelin/kll/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JoonasMelin/kll/merges","archive_url":"https://api.github.com/repos/JoonasMelin/kll/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JoonasMelin/kll/downloads","issues_url":"https://api.github.com/repos/JoonasMelin/kll/issues{/number}","pulls_url":"https://api.github.com/repos/JoonasMelin/kll/pulls{/number}","milestones_url":"https://api.github.com/repos/JoonasMelin/kll/milestones{/number}","notifications_url":"https://api.github.com/repos/JoonasMelin/kll/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JoonasMelin/kll/labels{/name}","releases_url":"https://api.github.com/repos/JoonasMelin/kll/releases{/id}","deployments_url":"https://api.github.com/repos/JoonasMelin/kll/deployments","created_at":"2017-06-26T19:44:14Z","updated_at":"2017-06-26T19:44:16Z","pushed_at":"2017-07-09T22:09:16Z","git_url":"git://github.com/JoonasMelin/kll.git","ssh_url":"git@github.com:JoonasMelin/kll.git","clone_url":"https://github.com/JoonasMelin/kll.git","svn_url":"https://github.com/JoonasMelin/kll","homepage":null,"size":476,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kiibohd:master","ref":"master","sha":"c57bf5d4d3cf270826ef01f7d082df8cfbd4d162","user":{"login":"kiibohd","id":8341393,"avatar_url":"https://avatars1.githubusercontent.com/u/8341393?v=3","gravatar_id":"","url":"https://api.github.com/users/kiibohd","html_url":"https://github.com/kiibohd","followers_url":"https://api.github.com/users/kiibohd/followers","following_url":"https://api.github.com/users/kiibohd/following{/other_user}","gists_url":"https://api.github.com/users/kiibohd/gists{/gist_id}","starred_url":"https://api.github.com/users/kiibohd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiibohd/subscriptions","organizations_url":"https://api.github.com/users/kiibohd/orgs","repos_url":"https://api.github.com/users/kiibohd/repos","events_url":"https://api.github.com/users/kiibohd/events{/privacy}","received_events_url":"https://api.github.com/users/kiibohd/received_events","type":"Organization","site_admin":false},"repo":{"id":23587004,"name":"kll","full_name":"kiibohd/kll","owner":{"login":"kiibohd","id":8341393,"avatar_url":"https://avatars1.githubusercontent.com/u/8341393?v=3","gravatar_id":"","url":"https://api.github.com/users/kiibohd","html_url":"https://github.com/kiibohd","followers_url":"https://api.github.com/users/kiibohd/followers","following_url":"https://api.github.com/users/kiibohd/following{/other_user}","gists_url":"https://api.github.com/users/kiibohd/gists{/gist_id}","starred_url":"https://api.github.com/users/kiibohd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiibohd/subscriptions","organizations_url":"https://api.github.com/users/kiibohd/orgs","repos_url":"https://api.github.com/users/kiibohd/repos","events_url":"https://api.github.com/users/kiibohd/events{/privacy}","received_events_url":"https://api.github.com/users/kiibohd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kiibohd/kll","description":"KLL Compiler","fork":false,"url":"https://api.github.com/repos/kiibohd/kll","forks_url":"https://api.github.com/repos/kiibohd/kll/forks","keys_url":"https://api.github.com/repos/kiibohd/kll/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kiibohd/kll/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kiibohd/kll/teams","hooks_url":"https://api.github.com/repos/kiibohd/kll/hooks","issue_events_url":"https://api.github.com/repos/kiibohd/kll/issues/events{/number}","events_url":"https://api.github.com/repos/kiibohd/kll/events","assignees_url":"https://api.github.com/repos/kiibohd/kll/assignees{/user}","branches_url":"https://api.github.com/repos/kiibohd/kll/branches{/branch}","tags_url":"https://api.github.com/repos/kiibohd/kll/tags","blobs_url":"https://api.github.com/repos/kiibohd/kll/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kiibohd/kll/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kiibohd/kll/git/refs{/sha}","trees_url":"https://api.github.com/repos/kiibohd/kll/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kiibohd/kll/statuses/{sha}","languages_url":"https://api.github.com/repos/kiibohd/kll/languages","stargazers_url":"https://api.github.com/repos/kiibohd/kll/stargazers","contributors_url":"https://api.github.com/repos/kiibohd/kll/contributors","subscribers_url":"https://api.github.com/repos/kiibohd/kll/subscribers","subscription_url":"https://api.github.com/repos/kiibohd/kll/subscription","commits_url":"https://api.github.com/repos/kiibohd/kll/commits{/sha}","git_commits_url":"https://api.github.com/repos/kiibohd/kll/git/commits{/sha}","comments_url":"https://api.github.com/repos/kiibohd/kll/comments{/number}","issue_comment_url":"https://api.github.com/repos/kiibohd/kll/issues/comments{/number}","contents_url":"https://api.github.com/repos/kiibohd/kll/contents/{+path}","compare_url":"https://api.github.com/repos/kiibohd/kll/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kiibohd/kll/merges","archive_url":"https://api.github.com/repos/kiibohd/kll/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kiibohd/kll/downloads","issues_url":"https://api.github.com/repos/kiibohd/kll/issues{/number}","pulls_url":"https://api.github.com/repos/kiibohd/kll/pulls{/number}","milestones_url":"https://api.github.com/repos/kiibohd/kll/milestones{/number}","notifications_url":"https://api.github.com/repos/kiibohd/kll/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kiibohd/kll/labels{/name}","releases_url":"https://api.github.com/repos/kiibohd/kll/releases{/id}","deployments_url":"https://api.github.com/repos/kiibohd/kll/deployments","created_at":"2014-09-02T16:49:11Z","updated_at":"2017-06-20T15:29:45Z","pushed_at":"2017-07-09T22:16:13Z","git_url":"git://github.com/kiibohd/kll.git","ssh_url":"git@github.com:kiibohd/kll.git","clone_url":"https://github.com/kiibohd/kll.git","svn_url":"https://github.com/kiibohd/kll","homepage":null,"size":376,"stargazers_count":62,"watchers_count":62,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":61,"mirror_url":null,"open_issues_count":11,"forks":61,"open_issues":11,"watchers":62,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kiibohd/kll/pulls/20"},"html":{"href":"https://github.com/kiibohd/kll/pull/20"},"issue":{"href":"https://api.github.com/repos/kiibohd/kll/issues/20"},"comments":{"href":"https://api.github.com/repos/kiibohd/kll/issues/20/comments"},"review_comments":{"href":"https://api.github.com/repos/kiibohd/kll/pulls/20/comments"},"review_comment":{"href":"https://api.github.com/repos/kiibohd/kll/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kiibohd/kll/pulls/20/commits"},"statuses":{"href":"https://api.github.com/repos/kiibohd/kll/statuses/e70f165fddfd23de5638adb988ee0e57ddaf2516"}}}}
{"actor":{"display_login":"JoonasMelin"}}