{"action":"created","comment":{"url":"https://api.github.com/repos/pytest-dev/pluggy/pulls/comments/100234852","pull_request_review_id":20934111,"id":100234852,"diff_hunk":"@@ -724,6 +745,8 @@ def remove(wrappers):\n                 raise ValueError(\"plugin %r not found\" % (plugin,))\n \n     def _add_hookimpl(self, hookimpl):\n+        \"\"\"A an implementation to the callback chain.","path":"pluggy.py","position":211,"original_position":164,"commit_id":"178ffdf280d404e7ebbe7aebab3354318a8cb4b1","original_commit_id":"f84955310c2aae13d1760948cd85afee3787ee2a","user":{"login":"tgoodlet","id":291685,"avatar_url":"https://avatars.githubusercontent.com/u/291685?v=3","gravatar_id":"","url":"https://api.github.com/users/tgoodlet","html_url":"https://github.com/tgoodlet","followers_url":"https://api.github.com/users/tgoodlet/followers","following_url":"https://api.github.com/users/tgoodlet/following{/other_user}","gists_url":"https://api.github.com/users/tgoodlet/gists{/gist_id}","starred_url":"https://api.github.com/users/tgoodlet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgoodlet/subscriptions","organizations_url":"https://api.github.com/users/tgoodlet/orgs","repos_url":"https://api.github.com/users/tgoodlet/repos","events_url":"https://api.github.com/users/tgoodlet/events{/privacy}","received_events_url":"https://api.github.com/users/tgoodlet/received_events","type":"User","site_admin":false},"body":"s/A/Add","created_at":"2017-02-09T05:49:53Z","updated_at":"2017-02-09T05:50:35Z","html_url":"https://github.com/pytest-dev/pluggy/pull/34#discussion_r100234852","pull_request_url":"https://api.github.com/repos/pytest-dev/pluggy/pulls/34","_links":{"self":{"href":"https://api.github.com/repos/pytest-dev/pluggy/pulls/comments/100234852"},"html":{"href":"https://github.com/pytest-dev/pluggy/pull/34#discussion_r100234852"},"pull_request":{"href":"https://api.github.com/repos/pytest-dev/pluggy/pulls/34"}}},"pull_request":{"url":"https://api.github.com/repos/pytest-dev/pluggy/pulls/34","id":93644686,"html_url":"https://github.com/pytest-dev/pluggy/pull/34","diff_url":"https://github.com/pytest-dev/pluggy/pull/34.diff","patch_url":"https://github.com/pytest-dev/pluggy/pull/34.patch","issue_url":"https://api.github.com/repos/pytest-dev/pluggy/issues/34","number":34,"state":"open","locked":false,"title":"Future warnings for hookspec changes","user":{"login":"tgoodlet","id":291685,"avatar_url":"https://avatars.githubusercontent.com/u/291685?v=3","gravatar_id":"","url":"https://api.github.com/users/tgoodlet","html_url":"https://github.com/tgoodlet","followers_url":"https://api.github.com/users/tgoodlet/followers","following_url":"https://api.github.com/users/tgoodlet/following{/other_user}","gists_url":"https://api.github.com/users/tgoodlet/gists{/gist_id}","starred_url":"https://api.github.com/users/tgoodlet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgoodlet/subscriptions","organizations_url":"https://api.github.com/users/tgoodlet/orgs","repos_url":"https://api.github.com/users/tgoodlet/repos","events_url":"https://api.github.com/users/tgoodlet/events{/privacy}","received_events_url":"https://api.github.com/users/tgoodlet/received_events","type":"User","site_admin":false},"body":"As per discussion with @RonnyPfannschmidt I'm putting this draft up to start looking at dealing with #15. \r\n\r\nI've broke some of the tests due to a change to `varnames()` which now returns both the `arg` and `kwarg` names for a function.\r\n\r\nThere's also some other changes that I didn't fully revert that pertained to trying to validate `kwargs` that we might decide to declare in `hookspecs` as a way to define defaults when a hook call doesn't provide them. ","created_at":"2016-11-14T20:46:33Z","updated_at":"2017-02-09T05:50:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2f7efb5e82b0b154000ab3284953c431958fda65","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/pytest-dev/pluggy/pulls/34/commits","review_comments_url":"https://api.github.com/repos/pytest-dev/pluggy/pulls/34/comments","review_comment_url":"https://api.github.com/repos/pytest-dev/pluggy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pytest-dev/pluggy/issues/34/comments","statuses_url":"https://api.github.com/repos/pytest-dev/pluggy/statuses/178ffdf280d404e7ebbe7aebab3354318a8cb4b1","head":{"label":"tgoodlet:master","ref":"master","sha":"178ffdf280d404e7ebbe7aebab3354318a8cb4b1","user":{"login":"tgoodlet","id":291685,"avatar_url":"https://avatars.githubusercontent.com/u/291685?v=3","gravatar_id":"","url":"https://api.github.com/users/tgoodlet","html_url":"https://github.com/tgoodlet","followers_url":"https://api.github.com/users/tgoodlet/followers","following_url":"https://api.github.com/users/tgoodlet/following{/other_user}","gists_url":"https://api.github.com/users/tgoodlet/gists{/gist_id}","starred_url":"https://api.github.com/users/tgoodlet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgoodlet/subscriptions","organizations_url":"https://api.github.com/users/tgoodlet/orgs","repos_url":"https://api.github.com/users/tgoodlet/repos","events_url":"https://api.github.com/users/tgoodlet/events{/privacy}","received_events_url":"https://api.github.com/users/tgoodlet/received_events","type":"User","site_admin":false},"repo":{"id":59961468,"name":"pluggy","full_name":"tgoodlet/pluggy","owner":{"login":"tgoodlet","id":291685,"avatar_url":"https://avatars.githubusercontent.com/u/291685?v=3","gravatar_id":"","url":"https://api.github.com/users/tgoodlet","html_url":"https://github.com/tgoodlet","followers_url":"https://api.github.com/users/tgoodlet/followers","following_url":"https://api.github.com/users/tgoodlet/following{/other_user}","gists_url":"https://api.github.com/users/tgoodlet/gists{/gist_id}","starred_url":"https://api.github.com/users/tgoodlet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgoodlet/subscriptions","organizations_url":"https://api.github.com/users/tgoodlet/orgs","repos_url":"https://api.github.com/users/tgoodlet/repos","events_url":"https://api.github.com/users/tgoodlet/events{/privacy}","received_events_url":"https://api.github.com/users/tgoodlet/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tgoodlet/pluggy","description":"Plugin management and hook calling for Python","fork":true,"url":"https://api.github.com/repos/tgoodlet/pluggy","forks_url":"https://api.github.com/repos/tgoodlet/pluggy/forks","keys_url":"https://api.github.com/repos/tgoodlet/pluggy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tgoodlet/pluggy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tgoodlet/pluggy/teams","hooks_url":"https://api.github.com/repos/tgoodlet/pluggy/hooks","issue_events_url":"https://api.github.com/repos/tgoodlet/pluggy/issues/events{/number}","events_url":"https://api.github.com/repos/tgoodlet/pluggy/events","assignees_url":"https://api.github.com/repos/tgoodlet/pluggy/assignees{/user}","branches_url":"https://api.github.com/repos/tgoodlet/pluggy/branches{/branch}","tags_url":"https://api.github.com/repos/tgoodlet/pluggy/tags","blobs_url":"https://api.github.com/repos/tgoodlet/pluggy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tgoodlet/pluggy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tgoodlet/pluggy/git/refs{/sha}","trees_url":"https://api.github.com/repos/tgoodlet/pluggy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tgoodlet/pluggy/statuses/{sha}","languages_url":"https://api.github.com/repos/tgoodlet/pluggy/languages","stargazers_url":"https://api.github.com/repos/tgoodlet/pluggy/stargazers","contributors_url":"https://api.github.com/repos/tgoodlet/pluggy/contributors","subscribers_url":"https://api.github.com/repos/tgoodlet/pluggy/subscribers","subscription_url":"https://api.github.com/repos/tgoodlet/pluggy/subscription","commits_url":"https://api.github.com/repos/tgoodlet/pluggy/commits{/sha}","git_commits_url":"https://api.github.com/repos/tgoodlet/pluggy/git/commits{/sha}","comments_url":"https://api.github.com/repos/tgoodlet/pluggy/comments{/number}","issue_comment_url":"https://api.github.com/repos/tgoodlet/pluggy/issues/comments{/number}","contents_url":"https://api.github.com/repos/tgoodlet/pluggy/contents/{+path}","compare_url":"https://api.github.com/repos/tgoodlet/pluggy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tgoodlet/pluggy/merges","archive_url":"https://api.github.com/repos/tgoodlet/pluggy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tgoodlet/pluggy/downloads","issues_url":"https://api.github.com/repos/tgoodlet/pluggy/issues{/number}","pulls_url":"https://api.github.com/repos/tgoodlet/pluggy/pulls{/number}","milestones_url":"https://api.github.com/repos/tgoodlet/pluggy/milestones{/number}","notifications_url":"https://api.github.com/repos/tgoodlet/pluggy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tgoodlet/pluggy/labels{/name}","releases_url":"https://api.github.com/repos/tgoodlet/pluggy/releases{/id}","deployments_url":"https://api.github.com/repos/tgoodlet/pluggy/deployments","created_at":"2016-05-29T20:02:58Z","updated_at":"2016-05-29T20:02:58Z","pushed_at":"2017-02-05T22:36:34Z","git_url":"git://github.com/tgoodlet/pluggy.git","ssh_url":"git@github.com:tgoodlet/pluggy.git","clone_url":"https://github.com/tgoodlet/pluggy.git","svn_url":"https://github.com/tgoodlet/pluggy","homepage":null,"size":118,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pytest-dev:master","ref":"master","sha":"51825821f6e27024310483fbbf592c7700987357","user":{"login":"pytest-dev","id":8897583,"avatar_url":"https://avatars.githubusercontent.com/u/8897583?v=3","gravatar_id":"","url":"https://api.github.com/users/pytest-dev","html_url":"https://github.com/pytest-dev","followers_url":"https://api.github.com/users/pytest-dev/followers","following_url":"https://api.github.com/users/pytest-dev/following{/other_user}","gists_url":"https://api.github.com/users/pytest-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pytest-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytest-dev/subscriptions","organizations_url":"https://api.github.com/users/pytest-dev/orgs","repos_url":"https://api.github.com/users/pytest-dev/repos","events_url":"https://api.github.com/users/pytest-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pytest-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":34739117,"name":"pluggy","full_name":"pytest-dev/pluggy","owner":{"login":"pytest-dev","id":8897583,"avatar_url":"https://avatars.githubusercontent.com/u/8897583?v=3","gravatar_id":"","url":"https://api.github.com/users/pytest-dev","html_url":"https://github.com/pytest-dev","followers_url":"https://api.github.com/users/pytest-dev/followers","following_url":"https://api.github.com/users/pytest-dev/following{/other_user}","gists_url":"https://api.github.com/users/pytest-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pytest-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytest-dev/subscriptions","organizations_url":"https://api.github.com/users/pytest-dev/orgs","repos_url":"https://api.github.com/users/pytest-dev/repos","events_url":"https://api.github.com/users/pytest-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pytest-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pytest-dev/pluggy","description":"Plugin management and hook calling for Python","fork":false,"url":"https://api.github.com/repos/pytest-dev/pluggy","forks_url":"https://api.github.com/repos/pytest-dev/pluggy/forks","keys_url":"https://api.github.com/repos/pytest-dev/pluggy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pytest-dev/pluggy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pytest-dev/pluggy/teams","hooks_url":"https://api.github.com/repos/pytest-dev/pluggy/hooks","issue_events_url":"https://api.github.com/repos/pytest-dev/pluggy/issues/events{/number}","events_url":"https://api.github.com/repos/pytest-dev/pluggy/events","assignees_url":"https://api.github.com/repos/pytest-dev/pluggy/assignees{/user}","branches_url":"https://api.github.com/repos/pytest-dev/pluggy/branches{/branch}","tags_url":"https://api.github.com/repos/pytest-dev/pluggy/tags","blobs_url":"https://api.github.com/repos/pytest-dev/pluggy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pytest-dev/pluggy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pytest-dev/pluggy/git/refs{/sha}","trees_url":"https://api.github.com/repos/pytest-dev/pluggy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pytest-dev/pluggy/statuses/{sha}","languages_url":"https://api.github.com/repos/pytest-dev/pluggy/languages","stargazers_url":"https://api.github.com/repos/pytest-dev/pluggy/stargazers","contributors_url":"https://api.github.com/repos/pytest-dev/pluggy/contributors","subscribers_url":"https://api.github.com/repos/pytest-dev/pluggy/subscribers","subscription_url":"https://api.github.com/repos/pytest-dev/pluggy/subscription","commits_url":"https://api.github.com/repos/pytest-dev/pluggy/commits{/sha}","git_commits_url":"https://api.github.com/repos/pytest-dev/pluggy/git/commits{/sha}","comments_url":"https://api.github.com/repos/pytest-dev/pluggy/comments{/number}","issue_comment_url":"https://api.github.com/repos/pytest-dev/pluggy/issues/comments{/number}","contents_url":"https://api.github.com/repos/pytest-dev/pluggy/contents/{+path}","compare_url":"https://api.github.com/repos/pytest-dev/pluggy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pytest-dev/pluggy/merges","archive_url":"https://api.github.com/repos/pytest-dev/pluggy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pytest-dev/pluggy/downloads","issues_url":"https://api.github.com/repos/pytest-dev/pluggy/issues{/number}","pulls_url":"https://api.github.com/repos/pytest-dev/pluggy/pulls{/number}","milestones_url":"https://api.github.com/repos/pytest-dev/pluggy/milestones{/number}","notifications_url":"https://api.github.com/repos/pytest-dev/pluggy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pytest-dev/pluggy/labels{/name}","releases_url":"https://api.github.com/repos/pytest-dev/pluggy/releases{/id}","deployments_url":"https://api.github.com/repos/pytest-dev/pluggy/deployments","created_at":"2015-04-28T15:32:26Z","updated_at":"2017-02-06T23:27:11Z","pushed_at":"2017-02-08T08:26:08Z","git_url":"git://github.com/pytest-dev/pluggy.git","ssh_url":"git@github.com:pytest-dev/pluggy.git","clone_url":"https://github.com/pytest-dev/pluggy.git","svn_url":"https://github.com/pytest-dev/pluggy","homepage":null,"size":114,"stargazers_count":56,"watchers_count":56,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":4,"forks":19,"open_issues":4,"watchers":56,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pytest-dev/pluggy/pulls/34"},"html":{"href":"https://github.com/pytest-dev/pluggy/pull/34"},"issue":{"href":"https://api.github.com/repos/pytest-dev/pluggy/issues/34"},"comments":{"href":"https://api.github.com/repos/pytest-dev/pluggy/issues/34/comments"},"review_comments":{"href":"https://api.github.com/repos/pytest-dev/pluggy/pulls/34/comments"},"review_comment":{"href":"https://api.github.com/repos/pytest-dev/pluggy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pytest-dev/pluggy/pulls/34/commits"},"statuses":{"href":"https://api.github.com/repos/pytest-dev/pluggy/statuses/178ffdf280d404e7ebbe7aebab3354318a8cb4b1"}}}}
{"actor":{"display_login":"tgoodlet"}}