{"action":"closed","number":1273,"pull_request":{"url":"https://api.github.com/repos/cilium/cilium/pulls/1273","id":134465022,"html_url":"https://github.com/cilium/cilium/pull/1273","diff_url":"https://github.com/cilium/cilium/pull/1273.diff","patch_url":"https://github.com/cilium/cilium/pull/1273.patch","issue_url":"https://api.github.com/repos/cilium/cilium/issues/1273","number":1273,"state":"closed","locked":false,"title":"common/logging: handle errors from net.SplitHostPort","user":{"login":"tklauser","id":539708,"avatar_url":"https://avatars2.githubusercontent.com/u/539708?v=4","gravatar_id":"","url":"https://api.github.com/users/tklauser","html_url":"https://github.com/tklauser","followers_url":"https://api.github.com/users/tklauser/followers","following_url":"https://api.github.com/users/tklauser/following{/other_user}","gists_url":"https://api.github.com/users/tklauser/gists{/gist_id}","starred_url":"https://api.github.com/users/tklauser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tklauser/subscriptions","organizations_url":"https://api.github.com/users/tklauser/orgs","repos_url":"https://api.github.com/users/tklauser/repos","events_url":"https://api.github.com/users/tklauser/events{/privacy}","received_events_url":"https://api.github.com/users/tklauser/received_events","type":"User","site_admin":false},"body":"When starting cilium-agent with an ill-formatted host/port combination,\r\nwe get the following:\r\n\r\n  $ cilium-agent --log-driver fluentd --log-opt fluentd.address=192.168.4.42-24224\r\n  [...]\r\n  strconv.Atoi: parsing \\\"\\\": invalid syntax\r\n\r\nFix it by checking the err return value of net.SplitHostPort and calling\r\nlogrus.Fatal accordingly. Now we get:\r\n\r\n  $ cilium-agent --log-driver fluentd --log-opt fluentd.address=192.168.4.42-24224\r\n  address 192.168.4.42-24224: missing port in address\r\n\r\nSigned-off-by: Tobias Klauser <tklauser@distanz.ch>","created_at":"2017-08-07T15:28:25Z","updated_at":"2017-08-07T19:17:10Z","closed_at":"2017-08-07T19:17:10Z","merged_at":"2017-08-07T19:17:10Z","merge_commit_sha":"fb89383a6ae48f66f27273acdb7f2f412b152c4a","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/cilium/cilium/pulls/1273/commits","review_comments_url":"https://api.github.com/repos/cilium/cilium/pulls/1273/comments","review_comment_url":"https://api.github.com/repos/cilium/cilium/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cilium/cilium/issues/1273/comments","statuses_url":"https://api.github.com/repos/cilium/cilium/statuses/06ae08ec5660d52e63079f1b3e912b5c3287eab1","head":{"label":"tklauser:splithostport-err","ref":"splithostport-err","sha":"06ae08ec5660d52e63079f1b3e912b5c3287eab1","user":{"login":"tklauser","id":539708,"avatar_url":"https://avatars2.githubusercontent.com/u/539708?v=4","gravatar_id":"","url":"https://api.github.com/users/tklauser","html_url":"https://github.com/tklauser","followers_url":"https://api.github.com/users/tklauser/followers","following_url":"https://api.github.com/users/tklauser/following{/other_user}","gists_url":"https://api.github.com/users/tklauser/gists{/gist_id}","starred_url":"https://api.github.com/users/tklauser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tklauser/subscriptions","organizations_url":"https://api.github.com/users/tklauser/orgs","repos_url":"https://api.github.com/users/tklauser/repos","events_url":"https://api.github.com/users/tklauser/events{/privacy}","received_events_url":"https://api.github.com/users/tklauser/received_events","type":"User","site_admin":false},"repo":{"id":80004286,"name":"cilium","full_name":"tklauser/cilium","owner":{"login":"tklauser","id":539708,"avatar_url":"https://avatars2.githubusercontent.com/u/539708?v=4","gravatar_id":"","url":"https://api.github.com/users/tklauser","html_url":"https://github.com/tklauser","followers_url":"https://api.github.com/users/tklauser/followers","following_url":"https://api.github.com/users/tklauser/following{/other_user}","gists_url":"https://api.github.com/users/tklauser/gists{/gist_id}","starred_url":"https://api.github.com/users/tklauser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tklauser/subscriptions","organizations_url":"https://api.github.com/users/tklauser/orgs","repos_url":"https://api.github.com/users/tklauser/repos","events_url":"https://api.github.com/users/tklauser/events{/privacy}","received_events_url":"https://api.github.com/users/tklauser/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tklauser/cilium","description":"BPF & XDP for containers","fork":true,"url":"https://api.github.com/repos/tklauser/cilium","forks_url":"https://api.github.com/repos/tklauser/cilium/forks","keys_url":"https://api.github.com/repos/tklauser/cilium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tklauser/cilium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tklauser/cilium/teams","hooks_url":"https://api.github.com/repos/tklauser/cilium/hooks","issue_events_url":"https://api.github.com/repos/tklauser/cilium/issues/events{/number}","events_url":"https://api.github.com/repos/tklauser/cilium/events","assignees_url":"https://api.github.com/repos/tklauser/cilium/assignees{/user}","branches_url":"https://api.github.com/repos/tklauser/cilium/branches{/branch}","tags_url":"https://api.github.com/repos/tklauser/cilium/tags","blobs_url":"https://api.github.com/repos/tklauser/cilium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tklauser/cilium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tklauser/cilium/git/refs{/sha}","trees_url":"https://api.github.com/repos/tklauser/cilium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tklauser/cilium/statuses/{sha}","languages_url":"https://api.github.com/repos/tklauser/cilium/languages","stargazers_url":"https://api.github.com/repos/tklauser/cilium/stargazers","contributors_url":"https://api.github.com/repos/tklauser/cilium/contributors","subscribers_url":"https://api.github.com/repos/tklauser/cilium/subscribers","subscription_url":"https://api.github.com/repos/tklauser/cilium/subscription","commits_url":"https://api.github.com/repos/tklauser/cilium/commits{/sha}","git_commits_url":"https://api.github.com/repos/tklauser/cilium/git/commits{/sha}","comments_url":"https://api.github.com/repos/tklauser/cilium/comments{/number}","issue_comment_url":"https://api.github.com/repos/tklauser/cilium/issues/comments{/number}","contents_url":"https://api.github.com/repos/tklauser/cilium/contents/{+path}","compare_url":"https://api.github.com/repos/tklauser/cilium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tklauser/cilium/merges","archive_url":"https://api.github.com/repos/tklauser/cilium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tklauser/cilium/downloads","issues_url":"https://api.github.com/repos/tklauser/cilium/issues{/number}","pulls_url":"https://api.github.com/repos/tklauser/cilium/pulls{/number}","milestones_url":"https://api.github.com/repos/tklauser/cilium/milestones{/number}","notifications_url":"https://api.github.com/repos/tklauser/cilium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tklauser/cilium/labels{/name}","releases_url":"https://api.github.com/repos/tklauser/cilium/releases{/id}","deployments_url":"https://api.github.com/repos/tklauser/cilium/deployments","created_at":"2017-01-25T10:27:33Z","updated_at":"2017-01-25T10:27:36Z","pushed_at":"2017-08-07T15:28:07Z","git_url":"git://github.com/tklauser/cilium.git","ssh_url":"git@github.com:tklauser/cilium.git","clone_url":"https://github.com/tklauser/cilium.git","svn_url":"https://github.com/tklauser/cilium","homepage":"","size":30472,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cilium:master","ref":"master","sha":"ab799cfef0d4e2d80b174d2046e6d84bef662d85","user":{"login":"cilium","id":21054566,"avatar_url":"https://avatars0.githubusercontent.com/u/21054566?v=4","gravatar_id":"","url":"https://api.github.com/users/cilium","html_url":"https://github.com/cilium","followers_url":"https://api.github.com/users/cilium/followers","following_url":"https://api.github.com/users/cilium/following{/other_user}","gists_url":"https://api.github.com/users/cilium/gists{/gist_id}","starred_url":"https://api.github.com/users/cilium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cilium/subscriptions","organizations_url":"https://api.github.com/users/cilium/orgs","repos_url":"https://api.github.com/users/cilium/repos","events_url":"https://api.github.com/users/cilium/events{/privacy}","received_events_url":"https://api.github.com/users/cilium/received_events","type":"Organization","site_admin":false},"repo":{"id":48109239,"name":"cilium","full_name":"cilium/cilium","owner":{"login":"cilium","id":21054566,"avatar_url":"https://avatars0.githubusercontent.com/u/21054566?v=4","gravatar_id":"","url":"https://api.github.com/users/cilium","html_url":"https://github.com/cilium","followers_url":"https://api.github.com/users/cilium/followers","following_url":"https://api.github.com/users/cilium/following{/other_user}","gists_url":"https://api.github.com/users/cilium/gists{/gist_id}","starred_url":"https://api.github.com/users/cilium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cilium/subscriptions","organizations_url":"https://api.github.com/users/cilium/orgs","repos_url":"https://api.github.com/users/cilium/repos","events_url":"https://api.github.com/users/cilium/events{/privacy}","received_events_url":"https://api.github.com/users/cilium/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cilium/cilium","description":"Linux Native, HTTP Aware Networking and Security for Containers","fork":false,"url":"https://api.github.com/repos/cilium/cilium","forks_url":"https://api.github.com/repos/cilium/cilium/forks","keys_url":"https://api.github.com/repos/cilium/cilium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cilium/cilium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cilium/cilium/teams","hooks_url":"https://api.github.com/repos/cilium/cilium/hooks","issue_events_url":"https://api.github.com/repos/cilium/cilium/issues/events{/number}","events_url":"https://api.github.com/repos/cilium/cilium/events","assignees_url":"https://api.github.com/repos/cilium/cilium/assignees{/user}","branches_url":"https://api.github.com/repos/cilium/cilium/branches{/branch}","tags_url":"https://api.github.com/repos/cilium/cilium/tags","blobs_url":"https://api.github.com/repos/cilium/cilium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cilium/cilium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cilium/cilium/git/refs{/sha}","trees_url":"https://api.github.com/repos/cilium/cilium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cilium/cilium/statuses/{sha}","languages_url":"https://api.github.com/repos/cilium/cilium/languages","stargazers_url":"https://api.github.com/repos/cilium/cilium/stargazers","contributors_url":"https://api.github.com/repos/cilium/cilium/contributors","subscribers_url":"https://api.github.com/repos/cilium/cilium/subscribers","subscription_url":"https://api.github.com/repos/cilium/cilium/subscription","commits_url":"https://api.github.com/repos/cilium/cilium/commits{/sha}","git_commits_url":"https://api.github.com/repos/cilium/cilium/git/commits{/sha}","comments_url":"https://api.github.com/repos/cilium/cilium/comments{/number}","issue_comment_url":"https://api.github.com/repos/cilium/cilium/issues/comments{/number}","contents_url":"https://api.github.com/repos/cilium/cilium/contents/{+path}","compare_url":"https://api.github.com/repos/cilium/cilium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cilium/cilium/merges","archive_url":"https://api.github.com/repos/cilium/cilium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cilium/cilium/downloads","issues_url":"https://api.github.com/repos/cilium/cilium/issues{/number}","pulls_url":"https://api.github.com/repos/cilium/cilium/pulls{/number}","milestones_url":"https://api.github.com/repos/cilium/cilium/milestones{/number}","notifications_url":"https://api.github.com/repos/cilium/cilium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cilium/cilium/labels{/name}","releases_url":"https://api.github.com/repos/cilium/cilium/releases{/id}","deployments_url":"https://api.github.com/repos/cilium/cilium/deployments","created_at":"2015-12-16T12:33:31Z","updated_at":"2017-08-07T14:38:19Z","pushed_at":"2017-08-07T19:17:10Z","git_url":"git://github.com/cilium/cilium.git","ssh_url":"git@github.com:cilium/cilium.git","clone_url":"https://github.com/cilium/cilium.git","svn_url":"https://github.com/cilium/cilium","homepage":"","size":30925,"stargazers_count":717,"watchers_count":717,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":88,"mirror_url":null,"open_issues_count":141,"forks":88,"open_issues":141,"watchers":717,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cilium/cilium/pulls/1273"},"html":{"href":"https://github.com/cilium/cilium/pull/1273"},"issue":{"href":"https://api.github.com/repos/cilium/cilium/issues/1273"},"comments":{"href":"https://api.github.com/repos/cilium/cilium/issues/1273/comments"},"review_comments":{"href":"https://api.github.com/repos/cilium/cilium/pulls/1273/comments"},"review_comment":{"href":"https://api.github.com/repos/cilium/cilium/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cilium/cilium/pulls/1273/commits"},"statuses":{"href":"https://api.github.com/repos/cilium/cilium/statuses/06ae08ec5660d52e63079f1b3e912b5c3287eab1"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"tgraf","id":1417913,"avatar_url":"https://avatars1.githubusercontent.com/u/1417913?v=4","gravatar_id":"","url":"https://api.github.com/users/tgraf","html_url":"https://github.com/tgraf","followers_url":"https://api.github.com/users/tgraf/followers","following_url":"https://api.github.com/users/tgraf/following{/other_user}","gists_url":"https://api.github.com/users/tgraf/gists{/gist_id}","starred_url":"https://api.github.com/users/tgraf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgraf/subscriptions","organizations_url":"https://api.github.com/users/tgraf/orgs","repos_url":"https://api.github.com/users/tgraf/repos","events_url":"https://api.github.com/users/tgraf/events{/privacy}","received_events_url":"https://api.github.com/users/tgraf/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":3,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"tgraf"}}