{"action":"created","issue":{"url":"https://api.github.com/repos/zotonic/zotonic/issues/1717","repository_url":"https://api.github.com/repos/zotonic/zotonic","labels_url":"https://api.github.com/repos/zotonic/zotonic/issues/1717/labels{/name}","comments_url":"https://api.github.com/repos/zotonic/zotonic/issues/1717/comments","events_url":"https://api.github.com/repos/zotonic/zotonic/issues/1717/events","html_url":"https://github.com/zotonic/zotonic/pull/1717","id":232381901,"number":1717,"title":"[WIP] Turn Zotonic components into OTP applications","user":{"login":"ddeboer","id":89267,"avatar_url":"https://avatars2.githubusercontent.com/u/89267?v=3","gravatar_id":"","url":"https://api.github.com/users/ddeboer","html_url":"https://github.com/ddeboer","followers_url":"https://api.github.com/users/ddeboer/followers","following_url":"https://api.github.com/users/ddeboer/following{/other_user}","gists_url":"https://api.github.com/users/ddeboer/gists{/gist_id}","starred_url":"https://api.github.com/users/ddeboer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddeboer/subscriptions","organizations_url":"https://api.github.com/users/ddeboer/orgs","repos_url":"https://api.github.com/users/ddeboer/repos","events_url":"https://api.github.com/users/ddeboer/events{/privacy}","received_events_url":"https://api.github.com/users/ddeboer/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/zotonic/zotonic/milestones/3","html_url":"https://github.com/zotonic/zotonic/milestone/3","labels_url":"https://api.github.com/repos/zotonic/zotonic/milestones/3/labels","id":115630,"number":3,"title":"1.0","description":"Issues that result in BC breaks that need to done before 1.0\r\n\r\nCelebration. :fireworks:","creator":{"login":"mworrell","id":38268,"avatar_url":"https://avatars0.githubusercontent.com/u/38268?v=3","gravatar_id":"","url":"https://api.github.com/users/mworrell","html_url":"https://github.com/mworrell","followers_url":"https://api.github.com/users/mworrell/followers","following_url":"https://api.github.com/users/mworrell/following{/other_user}","gists_url":"https://api.github.com/users/mworrell/gists{/gist_id}","starred_url":"https://api.github.com/users/mworrell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mworrell/subscriptions","organizations_url":"https://api.github.com/users/mworrell/orgs","repos_url":"https://api.github.com/users/mworrell/repos","events_url":"https://api.github.com/users/mworrell/events{/privacy}","received_events_url":"https://api.github.com/users/mworrell/received_events","type":"User","site_admin":false},"open_issues":16,"closed_issues":115,"state":"open","created_at":"2012-05-04T16:17:10Z","updated_at":"2017-06-21T07:23:33Z","due_on":null,"closed_at":null},"comments":11,"created_at":"2017-05-30T21:05:44Z","updated_at":"2017-06-23T20:48:25Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/zotonic/zotonic/pulls/1717","html_url":"https://github.com/zotonic/zotonic/pull/1717","diff_url":"https://github.com/zotonic/zotonic/pull/1717.diff","patch_url":"https://github.com/zotonic/zotonic/pull/1717.patch"},"body":"### Description\r\n\r\nFix #834.\r\n\r\n* Turn this repository into a Rebar ‘umbrella’ app, with all components under `apps/`.\r\n* Make all Zotonic modules library applications and move them into `apps/`.\r\n* Add `rebar.config` and `...app.src` definitions to each module so each module can be published as a separate package to Hex.pm. This will be done on Travis, when a version of Zotonic has been tagged. When this is done, all modules get the same version number. This is not completely correct semantic versioning (as a module’s version could change from say 1.1 to 1.2 even though changes were only made to _other_ modules), but the pragmatic thing to do since we have a large number of modules. \r\n* Move Zotonic status site to `apps/`. This will _not_ be published to Hex.\r\n* Create a new `apps/zotonic_core` and move `src/` etc. there. The `zotonic_core` directory will be published to Hex as `zotonic_core`.\r\n* **BC break**: rename the `zotonic` config key (in `zotonic.config`) to `zotonic_core` to match the app name.\r\n\r\n#### TODO\r\n\r\nProposal: add your initials behind the issue if you started working on it\r\n\r\n - [x] new main zotonic.app file in umbrella\r\n - [x] rename parts in zotonic_core (.app etc)\r\n - [ ] change startup of zotonic_core (use supplied args / config files)\r\n - [x] module indexer\r\n - [ ] sites scanner\r\n - [ ] (dynamic) module installation in _checkouts, soft links?\r\n - [ ] (dynamic) site installation in _checkouts, soft links?\r\n - [ ] use hex for module repo\r\n\r\n### Checklist\r\n\r\n- [x] documentation updated\r\n- [ ] tests added\r\n- [ ] no BC breaks"},"comment":{"url":"https://api.github.com/repos/zotonic/zotonic/issues/comments/310769439","html_url":"https://github.com/zotonic/zotonic/pull/1717#issuecomment-310769439","issue_url":"https://api.github.com/repos/zotonic/zotonic/issues/1717","id":310769439,"user":{"login":"ddeboer","id":89267,"avatar_url":"https://avatars2.githubusercontent.com/u/89267?v=3","gravatar_id":"","url":"https://api.github.com/users/ddeboer","html_url":"https://github.com/ddeboer","followers_url":"https://api.github.com/users/ddeboer/followers","following_url":"https://api.github.com/users/ddeboer/following{/other_user}","gists_url":"https://api.github.com/users/ddeboer/gists{/gist_id}","starred_url":"https://api.github.com/users/ddeboer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddeboer/subscriptions","organizations_url":"https://api.github.com/users/ddeboer/orgs","repos_url":"https://api.github.com/users/ddeboer/repos","events_url":"https://api.github.com/users/ddeboer/events{/privacy}","received_events_url":"https://api.github.com/users/ddeboer/received_events","type":"User","site_admin":false},"created_at":"2017-06-23T20:48:25Z","updated_at":"2017-06-23T20:48:25Z","body":"Yep, that's what I was thinking about too. You may want to use zotonic_core as a dependency in your project, without the rest of the main Zotknic repository. I'm not sure if you would then want Zotonic to start HTTP listeners etc. Anyway, perhaps it's better to just change the config key to match the app name (zotonic_core), as already done in this PR. "}}
{"actor":{"display_login":"ddeboer"}}