{"action":"created","comment":{"url":"https://api.github.com/repos/civicrm/civihr/pulls/comments/155659356","pull_request_review_id":82007281,"id":155659356,"diff_hunk":"@@ -177,7 +173,7 @@ define([\n      * @return {Promise}\n      */\n     function initChildController () {\n-      vm.request.to_date_type = vm.request.from_date_type = '1';\n+      parentCtrl.request.to_date_type = parentCtrl.request.from_date_type = '1';\n \n       return initRequestCanExpire()\n         .then(function () {","path":"uk.co.compucorp.civicrm.hrleaveandabsences/js/angular/src/leave-absences/shared/controllers/sub-controllers/toil-request.controller.js","position":191,"original_position":191,"commit_id":"8dd824b7e4cf2a7c7c54579e665af7c3c11e10d7","original_commit_id":"8dd824b7e4cf2a7c7c54579e665af7c3c11e10d7","user":{"login":"AkA84","id":6400898,"avatar_url":"https://avatars0.githubusercontent.com/u/6400898?v=4","gravatar_id":"","url":"https://api.github.com/users/AkA84","html_url":"https://github.com/AkA84","followers_url":"https://api.github.com/users/AkA84/followers","following_url":"https://api.github.com/users/AkA84/following{/other_user}","gists_url":"https://api.github.com/users/AkA84/gists{/gist_id}","starred_url":"https://api.github.com/users/AkA84/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AkA84/subscriptions","organizations_url":"https://api.github.com/users/AkA84/orgs","repos_url":"https://api.github.com/users/AkA84/repos","events_url":"https://api.github.com/users/AkA84/events{/privacy}","received_events_url":"https://api.github.com/users/AkA84/received_events","type":"User","site_admin":false},"body":"it's currently\r\n```js\r\nreturn initRequestCanExpire()\r\n  .then(function () {\r\n    initExpiryDate();\r\n\r\n    return loadToilAmounts();\r\n  });\r\n```\r\n\r\nwhy not\r\n```js\r\nreturn initRequestCanExpire()\r\n  .then(initExpiryDate)\r\n  .then(loadToilAmounts);\r\n```","created_at":"2017-12-07T22:27:46Z","updated_at":"2017-12-07T22:29:54Z","html_url":"https://github.com/civicrm/civihr/pull/2338#discussion_r155659356","pull_request_url":"https://api.github.com/repos/civicrm/civihr/pulls/2338","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/civicrm/civihr/pulls/comments/155659356"},"html":{"href":"https://github.com/civicrm/civihr/pull/2338#discussion_r155659356"},"pull_request":{"href":"https://api.github.com/repos/civicrm/civihr/pulls/2338"}}},"pull_request":{"url":"https://api.github.com/repos/civicrm/civihr/pulls/2338","id":155330049,"html_url":"https://github.com/civicrm/civihr/pull/2338","diff_url":"https://github.com/civicrm/civihr/pull/2338.diff","patch_url":"https://github.com/civicrm/civihr/pull/2338.patch","issue_url":"https://api.github.com/repos/civicrm/civihr/issues/2338","number":2338,"state":"open","locked":false,"title":"PCHR-2814: Fix opening balance update on Absence Period change in Leave Request Modal","user":{"login":"igorpavlov","id":3973243,"avatar_url":"https://avatars1.githubusercontent.com/u/3973243?v=4","gravatar_id":"","url":"https://api.github.com/users/igorpavlov","html_url":"https://github.com/igorpavlov","followers_url":"https://api.github.com/users/igorpavlov/followers","following_url":"https://api.github.com/users/igorpavlov/following{/other_user}","gists_url":"https://api.github.com/users/igorpavlov/gists{/gist_id}","starred_url":"https://api.github.com/users/igorpavlov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igorpavlov/subscriptions","organizations_url":"https://api.github.com/users/igorpavlov/orgs","repos_url":"https://api.github.com/users/igorpavlov/repos","events_url":"https://api.github.com/users/igorpavlov/events{/privacy}","received_events_url":"https://api.github.com/users/igorpavlov/received_events","type":"User","site_admin":false},"body":"## Overview\r\n\r\nThe issue is that Absence period is not taken into account when start date is changed or set in all Leave Request Modals. This PR fixes this issue.\r\n\r\n## Before\r\n\r\n![1](https://user-images.githubusercontent.com/3973243/33686077-89955c36-dacb-11e7-9adb-64b6e6b61b52.gif)\r\n\r\n## After\r\n\r\n![2](https://user-images.githubusercontent.com/3973243/33685954-23654840-dacb-11e7-83f4-68a65af1456f.gif)\r\n\r\n## Technical Details\r\n\r\n### Absence Period in edit mode\r\n\r\nAt first, show the Absence Period belonging to the request in edit mode.\r\n\r\n```js\r\nfunction doesRequestBelongToPeriod (request, period) {\r\n  return (moment(request.from_date).isSameOrAfter(moment(period.start_date)) &&\r\n    moment(request.to_date).isSameOrBefore(moment(period.end_date)));\r\n```\r\n\r\n### Flow refactoring\r\n\r\nIn order to properly accomplish the original task the flow refactoring has to be performed.\r\n\r\n⚠️ Please note, the amount of changes in `leave-request-popup-details-tab.component.js` file makes it collapsed by default by git. Please expand it to view.\r\n\r\n**Previous flow**\r\n\r\n![image](https://user-images.githubusercontent.com/3973243/33713221-3b37ec8a-db42-11e7-81d1-d1393e081a52.png)\r\n\r\n\r\n**Enhanced flow**\r\n\r\n![image](https://user-images.githubusercontent.com/3973243/33713235-471dcbd2-db42-11e7-890a-0eab89dbc3f8.png)\r\n\r\n\r\n### Abstract functions\r\n\r\nSome functions are *not* common and should belong the controllers for each request type. For example, the `calculateBalanceChange` function is different for TOIL. This function does not exist anymore in the `leave-request-popup-details-tab.component.js`. Same for `checkSubmitConditions` function.\r\n\r\nNote: Leave and Sick requests have same `calculateBalanceChange` logic, so `calculateBalanceChange` is defined in Leave child controller and is imported in Sick child controller from the Leave one.\r\n\r\n**components/leave-request-popup-details-tab.component.js**\r\n```js\r\nfunction attemptCalculateBalanceChange () {\r\n  // ... some code omitted from the snippet\r\n\r\n  return vm.calculateBalanceChange() // <-- the actual balance calculation call, note `vm.`\r\n    .then(...)\r\n}\r\n```\r\n**controllers/sub-controllers/leave-request.controller.js**\r\n```js\r\nparentCtrl.calculateBalanceChange = calculateBalanceChange;\r\n// ...\r\n// Calculation requires back-end\r\nfunction calculateBalanceChange () {\r\n  return parentCtrl.request.calculateBalanceChange(parentCtrl.selectedAbsenceType.calculation_unit_name);\r\n}\r\n```\r\n**controllers/sub-controllers/sick-request.controller.js**\r\n```js\r\n// We need to extend parent controller with\r\n// calculateBalanceChange() function from Leave Request Controller\r\n$controller('LeaveRequestCtrl', { parentCtrl: parentCtrl });\r\n}\r\n```\r\n**controllers/sub-controllers/toil-request.controller.js**\r\n```js\r\nparentCtrl.calculateBalanceChange = calculateBalanceChange;\r\n// A completely different logic does not even requiring back-end\r\nfunction calculateBalanceChange () {\r\n  parentCtrl.balance.change.amount = +parentCtrl.request.toil_to_accrue;\r\n\r\n  return $q.resolve(parentCtrl.balance.change);\r\n}\r\n```\r\n\r\n### Extended functions\r\n\r\nSometimes there are function that need to be simply extended. This is a different approach from Abstract functions, since some leave requests types do not need the common function to be extended. Here is an example:\r\n\r\n**leave-request-popup-details-tab.component.js**\r\n```js\r\n// .. this function reacts to changes in from/to dates in UI\r\nfunction setDatesFromUI (dateType) {\r\n  // ... some code was omitted from the snippet\r\n\r\n  return $q.resolve()\r\n    .then(vm.setDatesFromUIExtended ? vm.setDatesFromUIExtended : _.noop) // <-- extension\r\n    .then(function () {\r\n      return checkAbsencePeriod(dateType);\r\n    });\r\n}\r\n```\r\n**controllers/sub-controllers/toil-request.controller.js**\r\n```js\r\nparentCtrl.setDatesFromUIExtended = setDatesFromUIExtended;\r\n// ...\r\n// This function populates the promise chain in the component\r\nfunction setDatesFromUIExtended () {\r\n  return parentCtrl.calculateToilExpiryDate().catch($q.resolve);\r\n}\r\n```\r\n\r\n## Comments\r\n\r\nApart from the code manipulation described in the Technical Description section, some bugs were also fixed:\r\n\r\n1) TOIL balance is now not re-calculated on Edit.\r\n\r\n2) Day Type selector improved - now a label is shown instead of a selector if only one option is presented. This is good for UX if the selected day is a weekend or a non-working day. Also, this is now consistent with Leave in Hours.\r\n\r\n    **components/leave-request-popup/details-tab/common.html**\r\n    ```html\r\n    <crm-loading ...\r\n      ...\r\n      ng-switch=\"!detailsTab.isNotWorkingDay(detailsTab.requestFromDayTypes[0].name)\">\r\n      <div\r\n        ...\r\n        ng-switch-when=\"true\">\r\n        <select\r\n          ...\r\n          ng-model=\"detailsTab.uiOptions.times.from.time\"\r\n          timepicker-select\r\n        ></select>\r\n        <span class=\"crm_custom-select__arrow\"></span>\r\n      </div>\r\n      <div ng-switch-when=\"false\" ...>\r\n        {{ detailsTab.requestFromDayTypes[0].label }}\r\n      </div>\r\n    </crm-loading>\r\n    ```\r\n\r\n3) There was a bug. If you create a leave request in hours, lets say, for Friday, 6h deduction. Then you change the work pattern to a Weekend, or simply reduce the hours amount to lets say, 4h. Now deduction values are set improperly since the existing value (6h) is actually greater than the maximum allowed value (4h).\r\n\r\n    ```js\r\n    function initTimes () {\r\n      // ...\r\n\r\n      if (!vm.isMode('create') && isCalculationUnit('hours')) {\r\n        return $q.all(['from', 'to'].map(function (type) {\r\n          return loadAndSetTimeRangesFromWorkPattern(vm.uiOptions[type + 'Date'], type, true)\r\n            .then(function () {\r\n              var amount = request[type + '_date_amount'];\r\n\r\n              times[type].time = extractTimeFromServerDate(request[type + '_date']);\r\n              // This!\r\n              times[type].amount = Math.min(request[type + '_date_amount'], times[type].maxAmount).toString();\r\n            });\r\n        })).then(setHoursDeductionsToRequest);\r\n      }\r\n    }\r\n    ```\r\n\r\n4) Now original balance breakdown is also shown in the view mode. A bug fixed when in View mode on opening the Modal the re-calculation still happened. It shouldn't. Now in all modes except \"Create\" the **original** balance (the one that is not affected by changing work pattern in the middle) is shown.\r\n\r\n    **components/leave-request-popup-details-tab.component.js**\r\n    ```js\r\n    // was\r\n    function initBalanceChange () {\r\n      return (vm.isMode('edit') ? getOriginalBalanceChange() : attemptCalculateBalanceChange());\r\n    }\r\n    // now\r\n    function initBalanceChange () {\r\n      return (!vm.isMode('create') ? getOriginalBalanceChange() : attemptCalculateBalanceChange());\r\n    }\r\n    ```\r\n----------\r\n✅ Manual Tests - passed\r\n✅ Jasmine Tests - augmented and passed\r\n✅ JS distributive files - included\r\n⏹ CSS distributive files - not needed\r\n⏹ Backstop Tests - omitted\r\n⏹ PHP Unit Tests - not needed\r\n\r\n","created_at":"2017-11-29T12:44:25Z","updated_at":"2017-12-07T22:29:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fbfe3e8517d46884dedd550a3a6df3b9f5ea8224","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/civicrm/civihr/pulls/2338/commits","review_comments_url":"https://api.github.com/repos/civicrm/civihr/pulls/2338/comments","review_comment_url":"https://api.github.com/repos/civicrm/civihr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/civicrm/civihr/issues/2338/comments","statuses_url":"https://api.github.com/repos/civicrm/civihr/statuses/8dd824b7e4cf2a7c7c54579e665af7c3c11e10d7","head":{"label":"civicrm:PCHR-2814-absence-period-is-not-changed-when-date-is-changed","ref":"PCHR-2814-absence-period-is-not-changed-when-date-is-changed","sha":"8dd824b7e4cf2a7c7c54579e665af7c3c11e10d7","user":{"login":"civicrm","id":136373,"avatar_url":"https://avatars2.githubusercontent.com/u/136373?v=4","gravatar_id":"","url":"https://api.github.com/users/civicrm","html_url":"https://github.com/civicrm","followers_url":"https://api.github.com/users/civicrm/followers","following_url":"https://api.github.com/users/civicrm/following{/other_user}","gists_url":"https://api.github.com/users/civicrm/gists{/gist_id}","starred_url":"https://api.github.com/users/civicrm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/civicrm/subscriptions","organizations_url":"https://api.github.com/users/civicrm/orgs","repos_url":"https://api.github.com/users/civicrm/repos","events_url":"https://api.github.com/users/civicrm/events{/privacy}","received_events_url":"https://api.github.com/users/civicrm/received_events","type":"Organization","site_admin":false},"repo":{"id":10086903,"name":"civihr","full_name":"civicrm/civihr","owner":{"login":"civicrm","id":136373,"avatar_url":"https://avatars2.githubusercontent.com/u/136373?v=4","gravatar_id":"","url":"https://api.github.com/users/civicrm","html_url":"https://github.com/civicrm","followers_url":"https://api.github.com/users/civicrm/followers","following_url":"https://api.github.com/users/civicrm/following{/other_user}","gists_url":"https://api.github.com/users/civicrm/gists{/gist_id}","starred_url":"https://api.github.com/users/civicrm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/civicrm/subscriptions","organizations_url":"https://api.github.com/users/civicrm/orgs","repos_url":"https://api.github.com/users/civicrm/repos","events_url":"https://api.github.com/users/civicrm/events{/privacy}","received_events_url":"https://api.github.com/users/civicrm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/civicrm/civihr","description":"CiviHR","fork":false,"url":"https://api.github.com/repos/civicrm/civihr","forks_url":"https://api.github.com/repos/civicrm/civihr/forks","keys_url":"https://api.github.com/repos/civicrm/civihr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/civicrm/civihr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/civicrm/civihr/teams","hooks_url":"https://api.github.com/repos/civicrm/civihr/hooks","issue_events_url":"https://api.github.com/repos/civicrm/civihr/issues/events{/number}","events_url":"https://api.github.com/repos/civicrm/civihr/events","assignees_url":"https://api.github.com/repos/civicrm/civihr/assignees{/user}","branches_url":"https://api.github.com/repos/civicrm/civihr/branches{/branch}","tags_url":"https://api.github.com/repos/civicrm/civihr/tags","blobs_url":"https://api.github.com/repos/civicrm/civihr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/civicrm/civihr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/civicrm/civihr/git/refs{/sha}","trees_url":"https://api.github.com/repos/civicrm/civihr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/civicrm/civihr/statuses/{sha}","languages_url":"https://api.github.com/repos/civicrm/civihr/languages","stargazers_url":"https://api.github.com/repos/civicrm/civihr/stargazers","contributors_url":"https://api.github.com/repos/civicrm/civihr/contributors","subscribers_url":"https://api.github.com/repos/civicrm/civihr/subscribers","subscription_url":"https://api.github.com/repos/civicrm/civihr/subscription","commits_url":"https://api.github.com/repos/civicrm/civihr/commits{/sha}","git_commits_url":"https://api.github.com/repos/civicrm/civihr/git/commits{/sha}","comments_url":"https://api.github.com/repos/civicrm/civihr/comments{/number}","issue_comment_url":"https://api.github.com/repos/civicrm/civihr/issues/comments{/number}","contents_url":"https://api.github.com/repos/civicrm/civihr/contents/{+path}","compare_url":"https://api.github.com/repos/civicrm/civihr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/civicrm/civihr/merges","archive_url":"https://api.github.com/repos/civicrm/civihr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/civicrm/civihr/downloads","issues_url":"https://api.github.com/repos/civicrm/civihr/issues{/number}","pulls_url":"https://api.github.com/repos/civicrm/civihr/pulls{/number}","milestones_url":"https://api.github.com/repos/civicrm/civihr/milestones{/number}","notifications_url":"https://api.github.com/repos/civicrm/civihr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/civicrm/civihr/labels{/name}","releases_url":"https://api.github.com/repos/civicrm/civihr/releases{/id}","deployments_url":"https://api.github.com/repos/civicrm/civihr/deployments","created_at":"2013-05-15T20:06:06Z","updated_at":"2017-12-06T02:33:23Z","pushed_at":"2017-12-07T17:44:32Z","git_url":"git://github.com/civicrm/civihr.git","ssh_url":"git@github.com:civicrm/civihr.git","clone_url":"https://github.com/civicrm/civihr.git","svn_url":"https://github.com/civicrm/civihr","homepage":null,"size":57601,"stargazers_count":22,"watchers_count":22,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":37,"mirror_url":null,"archived":false,"open_issues_count":21,"license":null,"forks":37,"open_issues":21,"watchers":22,"default_branch":"staging"}},"base":{"label":"civicrm:staging","ref":"staging","sha":"7f396a07085710feed73e345ad3734a82e954130","user":{"login":"civicrm","id":136373,"avatar_url":"https://avatars2.githubusercontent.com/u/136373?v=4","gravatar_id":"","url":"https://api.github.com/users/civicrm","html_url":"https://github.com/civicrm","followers_url":"https://api.github.com/users/civicrm/followers","following_url":"https://api.github.com/users/civicrm/following{/other_user}","gists_url":"https://api.github.com/users/civicrm/gists{/gist_id}","starred_url":"https://api.github.com/users/civicrm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/civicrm/subscriptions","organizations_url":"https://api.github.com/users/civicrm/orgs","repos_url":"https://api.github.com/users/civicrm/repos","events_url":"https://api.github.com/users/civicrm/events{/privacy}","received_events_url":"https://api.github.com/users/civicrm/received_events","type":"Organization","site_admin":false},"repo":{"id":10086903,"name":"civihr","full_name":"civicrm/civihr","owner":{"login":"civicrm","id":136373,"avatar_url":"https://avatars2.githubusercontent.com/u/136373?v=4","gravatar_id":"","url":"https://api.github.com/users/civicrm","html_url":"https://github.com/civicrm","followers_url":"https://api.github.com/users/civicrm/followers","following_url":"https://api.github.com/users/civicrm/following{/other_user}","gists_url":"https://api.github.com/users/civicrm/gists{/gist_id}","starred_url":"https://api.github.com/users/civicrm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/civicrm/subscriptions","organizations_url":"https://api.github.com/users/civicrm/orgs","repos_url":"https://api.github.com/users/civicrm/repos","events_url":"https://api.github.com/users/civicrm/events{/privacy}","received_events_url":"https://api.github.com/users/civicrm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/civicrm/civihr","description":"CiviHR","fork":false,"url":"https://api.github.com/repos/civicrm/civihr","forks_url":"https://api.github.com/repos/civicrm/civihr/forks","keys_url":"https://api.github.com/repos/civicrm/civihr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/civicrm/civihr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/civicrm/civihr/teams","hooks_url":"https://api.github.com/repos/civicrm/civihr/hooks","issue_events_url":"https://api.github.com/repos/civicrm/civihr/issues/events{/number}","events_url":"https://api.github.com/repos/civicrm/civihr/events","assignees_url":"https://api.github.com/repos/civicrm/civihr/assignees{/user}","branches_url":"https://api.github.com/repos/civicrm/civihr/branches{/branch}","tags_url":"https://api.github.com/repos/civicrm/civihr/tags","blobs_url":"https://api.github.com/repos/civicrm/civihr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/civicrm/civihr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/civicrm/civihr/git/refs{/sha}","trees_url":"https://api.github.com/repos/civicrm/civihr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/civicrm/civihr/statuses/{sha}","languages_url":"https://api.github.com/repos/civicrm/civihr/languages","stargazers_url":"https://api.github.com/repos/civicrm/civihr/stargazers","contributors_url":"https://api.github.com/repos/civicrm/civihr/contributors","subscribers_url":"https://api.github.com/repos/civicrm/civihr/subscribers","subscription_url":"https://api.github.com/repos/civicrm/civihr/subscription","commits_url":"https://api.github.com/repos/civicrm/civihr/commits{/sha}","git_commits_url":"https://api.github.com/repos/civicrm/civihr/git/commits{/sha}","comments_url":"https://api.github.com/repos/civicrm/civihr/comments{/number}","issue_comment_url":"https://api.github.com/repos/civicrm/civihr/issues/comments{/number}","contents_url":"https://api.github.com/repos/civicrm/civihr/contents/{+path}","compare_url":"https://api.github.com/repos/civicrm/civihr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/civicrm/civihr/merges","archive_url":"https://api.github.com/repos/civicrm/civihr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/civicrm/civihr/downloads","issues_url":"https://api.github.com/repos/civicrm/civihr/issues{/number}","pulls_url":"https://api.github.com/repos/civicrm/civihr/pulls{/number}","milestones_url":"https://api.github.com/repos/civicrm/civihr/milestones{/number}","notifications_url":"https://api.github.com/repos/civicrm/civihr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/civicrm/civihr/labels{/name}","releases_url":"https://api.github.com/repos/civicrm/civihr/releases{/id}","deployments_url":"https://api.github.com/repos/civicrm/civihr/deployments","created_at":"2013-05-15T20:06:06Z","updated_at":"2017-12-06T02:33:23Z","pushed_at":"2017-12-07T17:44:32Z","git_url":"git://github.com/civicrm/civihr.git","ssh_url":"git@github.com:civicrm/civihr.git","clone_url":"https://github.com/civicrm/civihr.git","svn_url":"https://github.com/civicrm/civihr","homepage":null,"size":57601,"stargazers_count":22,"watchers_count":22,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":37,"mirror_url":null,"archived":false,"open_issues_count":21,"license":null,"forks":37,"open_issues":21,"watchers":22,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/civicrm/civihr/pulls/2338"},"html":{"href":"https://github.com/civicrm/civihr/pull/2338"},"issue":{"href":"https://api.github.com/repos/civicrm/civihr/issues/2338"},"comments":{"href":"https://api.github.com/repos/civicrm/civihr/issues/2338/comments"},"review_comments":{"href":"https://api.github.com/repos/civicrm/civihr/pulls/2338/comments"},"review_comment":{"href":"https://api.github.com/repos/civicrm/civihr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/civicrm/civihr/pulls/2338/commits"},"statuses":{"href":"https://api.github.com/repos/civicrm/civihr/statuses/8dd824b7e4cf2a7c7c54579e665af7c3c11e10d7"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"AkA84"}}