{"action":"created","comment":{"url":"https://api.github.com/repos/hyperledger/iroha/pulls/comments/150772998","pull_request_review_id":76369404,"id":150772998,"diff_hunk":"@@ -138,85 +138,101 @@ namespace iroha {\n \n       void Yac::closeRound() { timer_->deny(); }\n \n+      nonstd::optional<model::Peer> Yac::findPeer(const VoteMessage &vote) {\n+        auto peers = cluster_order_.getPeers();\n+        auto it =\n+            std::find_if(peers.begin(), peers.end(), [&](const auto &peer) {\n+              return peer.pubkey == vote.signature.pubkey;\n+            });\n+        return it != peers.end() ? nonstd::make_optional(*it) : nonstd::nullopt;\n+      }\n+\n       // ------|Apply data|------\n \n-      void Yac::applyCommit(model::Peer from, CommitMessage commit) {\n+      void Yac::applyCommit(nonstd::optional<model::Peer> from,","path":"irohad/consensus/yac/impl/yac.cpp","position":98,"original_position":98,"commit_id":"2f625c1c2e0463da2edea4c17b8d32b61ae2c986","original_commit_id":"2f625c1c2e0463da2edea4c17b8d32b61ae2c986","user":{"login":"l4l","id":5658339,"avatar_url":"https://avatars2.githubusercontent.com/u/5658339?v=4","gravatar_id":"","url":"https://api.github.com/users/l4l","html_url":"https://github.com/l4l","followers_url":"https://api.github.com/users/l4l/followers","following_url":"https://api.github.com/users/l4l/following{/other_user}","gists_url":"https://api.github.com/users/l4l/gists{/gist_id}","starred_url":"https://api.github.com/users/l4l/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/l4l/subscriptions","organizations_url":"https://api.github.com/users/l4l/orgs","repos_url":"https://api.github.com/users/l4l/repos","events_url":"https://api.github.com/users/l4l/events{/privacy}","received_events_url":"https://api.github.com/users/l4l/received_events","type":"User","site_admin":false},"body":"Is from unused?","created_at":"2017-11-14T09:09:20Z","updated_at":"2017-11-14T09:20:23Z","html_url":"https://github.com/hyperledger/iroha/pull/673#discussion_r150772998","pull_request_url":"https://api.github.com/repos/hyperledger/iroha/pulls/673","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/comments/150772998"},"html":{"href":"https://github.com/hyperledger/iroha/pull/673#discussion_r150772998"},"pull_request":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/673"}}},"pull_request":{"url":"https://api.github.com/repos/hyperledger/iroha/pulls/673","id":150483787,"html_url":"https://github.com/hyperledger/iroha/pull/673","diff_url":"https://github.com/hyperledger/iroha/pull/673.diff","patch_url":"https://github.com/hyperledger/iroha/pull/673.patch","issue_url":"https://api.github.com/repos/hyperledger/iroha/issues/673","number":673,"state":"open","locked":false,"title":"Fix/consensus network unknown peer","user":{"login":"lebdron","id":14347159,"avatar_url":"https://avatars1.githubusercontent.com/u/14347159?v=4","gravatar_id":"","url":"https://api.github.com/users/lebdron","html_url":"https://github.com/lebdron","followers_url":"https://api.github.com/users/lebdron/followers","following_url":"https://api.github.com/users/lebdron/following{/other_user}","gists_url":"https://api.github.com/users/lebdron/gists{/gist_id}","starred_url":"https://api.github.com/users/lebdron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lebdron/subscriptions","organizations_url":"https://api.github.com/users/lebdron/orgs","repos_url":"https://api.github.com/users/lebdron/repos","events_url":"https://api.github.com/users/lebdron/events{/privacy}","received_events_url":"https://api.github.com/users/lebdron/received_events","type":"User","site_admin":false},"body":"## What is this pull request?\r\nFix issue with crash when consensus message is received from unknown peer.\r\n\r\n## Details/Features\r\n- YacNetwork is now unaware of peers in the ledger\r\n- YacNetworkNotifications handle querying peers in the ledger\r\n","created_at":"2017-11-03T09:32:39Z","updated_at":"2017-11-14T09:20:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"958f74d71ab3102b8e316d0a47933655b8f5db97","assignee":null,"assignees":[],"requested_reviewers":[{"login":"grimadas","id":5897440,"avatar_url":"https://avatars2.githubusercontent.com/u/5897440?v=4","gravatar_id":"","url":"https://api.github.com/users/grimadas","html_url":"https://github.com/grimadas","followers_url":"https://api.github.com/users/grimadas/followers","following_url":"https://api.github.com/users/grimadas/following{/other_user}","gists_url":"https://api.github.com/users/grimadas/gists{/gist_id}","starred_url":"https://api.github.com/users/grimadas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grimadas/subscriptions","organizations_url":"https://api.github.com/users/grimadas/orgs","repos_url":"https://api.github.com/users/grimadas/repos","events_url":"https://api.github.com/users/grimadas/events{/privacy}","received_events_url":"https://api.github.com/users/grimadas/received_events","type":"User","site_admin":false},{"login":"kamilsa","id":9370151,"avatar_url":"https://avatars3.githubusercontent.com/u/9370151?v=4","gravatar_id":"","url":"https://api.github.com/users/kamilsa","html_url":"https://github.com/kamilsa","followers_url":"https://api.github.com/users/kamilsa/followers","following_url":"https://api.github.com/users/kamilsa/following{/other_user}","gists_url":"https://api.github.com/users/kamilsa/gists{/gist_id}","starred_url":"https://api.github.com/users/kamilsa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kamilsa/subscriptions","organizations_url":"https://api.github.com/users/kamilsa/orgs","repos_url":"https://api.github.com/users/kamilsa/repos","events_url":"https://api.github.com/users/kamilsa/events{/privacy}","received_events_url":"https://api.github.com/users/kamilsa/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/hyperledger/iroha/pulls/673/commits","review_comments_url":"https://api.github.com/repos/hyperledger/iroha/pulls/673/comments","review_comment_url":"https://api.github.com/repos/hyperledger/iroha/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hyperledger/iroha/issues/673/comments","statuses_url":"https://api.github.com/repos/hyperledger/iroha/statuses/2f625c1c2e0463da2edea4c17b8d32b61ae2c986","head":{"label":"hyperledger:fix/consensus-network-unknown-peer","ref":"fix/consensus-network-unknown-peer","sha":"2f625c1c2e0463da2edea4c17b8d32b61ae2c986","user":{"login":"hyperledger","id":7657900,"avatar_url":"https://avatars2.githubusercontent.com/u/7657900?v=4","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"repo":{"id":67340575,"name":"iroha","full_name":"hyperledger/iroha","owner":{"login":"hyperledger","id":7657900,"avatar_url":"https://avatars2.githubusercontent.com/u/7657900?v=4","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hyperledger/iroha","description":"Iroha - A simple, decentralized ledger","fork":false,"url":"https://api.github.com/repos/hyperledger/iroha","forks_url":"https://api.github.com/repos/hyperledger/iroha/forks","keys_url":"https://api.github.com/repos/hyperledger/iroha/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyperledger/iroha/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyperledger/iroha/teams","hooks_url":"https://api.github.com/repos/hyperledger/iroha/hooks","issue_events_url":"https://api.github.com/repos/hyperledger/iroha/issues/events{/number}","events_url":"https://api.github.com/repos/hyperledger/iroha/events","assignees_url":"https://api.github.com/repos/hyperledger/iroha/assignees{/user}","branches_url":"https://api.github.com/repos/hyperledger/iroha/branches{/branch}","tags_url":"https://api.github.com/repos/hyperledger/iroha/tags","blobs_url":"https://api.github.com/repos/hyperledger/iroha/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyperledger/iroha/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyperledger/iroha/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyperledger/iroha/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyperledger/iroha/statuses/{sha}","languages_url":"https://api.github.com/repos/hyperledger/iroha/languages","stargazers_url":"https://api.github.com/repos/hyperledger/iroha/stargazers","contributors_url":"https://api.github.com/repos/hyperledger/iroha/contributors","subscribers_url":"https://api.github.com/repos/hyperledger/iroha/subscribers","subscription_url":"https://api.github.com/repos/hyperledger/iroha/subscription","commits_url":"https://api.github.com/repos/hyperledger/iroha/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyperledger/iroha/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyperledger/iroha/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyperledger/iroha/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyperledger/iroha/contents/{+path}","compare_url":"https://api.github.com/repos/hyperledger/iroha/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyperledger/iroha/merges","archive_url":"https://api.github.com/repos/hyperledger/iroha/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyperledger/iroha/downloads","issues_url":"https://api.github.com/repos/hyperledger/iroha/issues{/number}","pulls_url":"https://api.github.com/repos/hyperledger/iroha/pulls{/number}","milestones_url":"https://api.github.com/repos/hyperledger/iroha/milestones{/number}","notifications_url":"https://api.github.com/repos/hyperledger/iroha/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyperledger/iroha/labels{/name}","releases_url":"https://api.github.com/repos/hyperledger/iroha/releases{/id}","deployments_url":"https://api.github.com/repos/hyperledger/iroha/deployments","created_at":"2016-09-04T11:17:53Z","updated_at":"2017-11-13T14:06:02Z","pushed_at":"2017-11-14T08:30:15Z","git_url":"git://github.com/hyperledger/iroha.git","ssh_url":"git@github.com:hyperledger/iroha.git","clone_url":"https://github.com/hyperledger/iroha.git","svn_url":"https://github.com/hyperledger/iroha","homepage":"http://iroha.tech","size":37362,"stargazers_count":395,"watchers_count":395,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":135,"mirror_url":null,"archived":false,"open_issues_count":20,"forks":135,"open_issues":20,"watchers":395,"default_branch":"master"}},"base":{"label":"hyperledger:develop","ref":"develop","sha":"3fef80087584591e919af699df12b5dc4a8a1f66","user":{"login":"hyperledger","id":7657900,"avatar_url":"https://avatars2.githubusercontent.com/u/7657900?v=4","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"repo":{"id":67340575,"name":"iroha","full_name":"hyperledger/iroha","owner":{"login":"hyperledger","id":7657900,"avatar_url":"https://avatars2.githubusercontent.com/u/7657900?v=4","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hyperledger/iroha","description":"Iroha - A simple, decentralized ledger","fork":false,"url":"https://api.github.com/repos/hyperledger/iroha","forks_url":"https://api.github.com/repos/hyperledger/iroha/forks","keys_url":"https://api.github.com/repos/hyperledger/iroha/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyperledger/iroha/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyperledger/iroha/teams","hooks_url":"https://api.github.com/repos/hyperledger/iroha/hooks","issue_events_url":"https://api.github.com/repos/hyperledger/iroha/issues/events{/number}","events_url":"https://api.github.com/repos/hyperledger/iroha/events","assignees_url":"https://api.github.com/repos/hyperledger/iroha/assignees{/user}","branches_url":"https://api.github.com/repos/hyperledger/iroha/branches{/branch}","tags_url":"https://api.github.com/repos/hyperledger/iroha/tags","blobs_url":"https://api.github.com/repos/hyperledger/iroha/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyperledger/iroha/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyperledger/iroha/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyperledger/iroha/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyperledger/iroha/statuses/{sha}","languages_url":"https://api.github.com/repos/hyperledger/iroha/languages","stargazers_url":"https://api.github.com/repos/hyperledger/iroha/stargazers","contributors_url":"https://api.github.com/repos/hyperledger/iroha/contributors","subscribers_url":"https://api.github.com/repos/hyperledger/iroha/subscribers","subscription_url":"https://api.github.com/repos/hyperledger/iroha/subscription","commits_url":"https://api.github.com/repos/hyperledger/iroha/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyperledger/iroha/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyperledger/iroha/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyperledger/iroha/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyperledger/iroha/contents/{+path}","compare_url":"https://api.github.com/repos/hyperledger/iroha/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyperledger/iroha/merges","archive_url":"https://api.github.com/repos/hyperledger/iroha/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyperledger/iroha/downloads","issues_url":"https://api.github.com/repos/hyperledger/iroha/issues{/number}","pulls_url":"https://api.github.com/repos/hyperledger/iroha/pulls{/number}","milestones_url":"https://api.github.com/repos/hyperledger/iroha/milestones{/number}","notifications_url":"https://api.github.com/repos/hyperledger/iroha/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyperledger/iroha/labels{/name}","releases_url":"https://api.github.com/repos/hyperledger/iroha/releases{/id}","deployments_url":"https://api.github.com/repos/hyperledger/iroha/deployments","created_at":"2016-09-04T11:17:53Z","updated_at":"2017-11-13T14:06:02Z","pushed_at":"2017-11-14T08:30:15Z","git_url":"git://github.com/hyperledger/iroha.git","ssh_url":"git@github.com:hyperledger/iroha.git","clone_url":"https://github.com/hyperledger/iroha.git","svn_url":"https://github.com/hyperledger/iroha","homepage":"http://iroha.tech","size":37362,"stargazers_count":395,"watchers_count":395,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":135,"mirror_url":null,"archived":false,"open_issues_count":20,"forks":135,"open_issues":20,"watchers":395,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/673"},"html":{"href":"https://github.com/hyperledger/iroha/pull/673"},"issue":{"href":"https://api.github.com/repos/hyperledger/iroha/issues/673"},"comments":{"href":"https://api.github.com/repos/hyperledger/iroha/issues/673/comments"},"review_comments":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/673/comments"},"review_comment":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/673/commits"},"statuses":{"href":"https://api.github.com/repos/hyperledger/iroha/statuses/2f625c1c2e0463da2edea4c17b8d32b61ae2c986"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"l4l"}}