{"action":"created","issue":{"url":"https://api.github.com/repos/Shopify/graphql-batch/issues/68","repository_url":"https://api.github.com/repos/Shopify/graphql-batch","labels_url":"https://api.github.com/repos/Shopify/graphql-batch/issues/68/labels{/name}","comments_url":"https://api.github.com/repos/Shopify/graphql-batch/issues/68/comments","events_url":"https://api.github.com/repos/Shopify/graphql-batch/issues/68/events","html_url":"https://github.com/Shopify/graphql-batch/pull/68","id":271648034,"number":68,"title":"Allow custom executors","user":{"login":"chrisbutcher","id":1916444,"avatar_url":"https://avatars0.githubusercontent.com/u/1916444?v=4","gravatar_id":"","url":"https://api.github.com/users/chrisbutcher","html_url":"https://github.com/chrisbutcher","followers_url":"https://api.github.com/users/chrisbutcher/followers","following_url":"https://api.github.com/users/chrisbutcher/following{/other_user}","gists_url":"https://api.github.com/users/chrisbutcher/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisbutcher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisbutcher/subscriptions","organizations_url":"https://api.github.com/users/chrisbutcher/orgs","repos_url":"https://api.github.com/users/chrisbutcher/repos","events_url":"https://api.github.com/users/chrisbutcher/events{/privacy}","received_events_url":"https://api.github.com/users/chrisbutcher/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-11-06T22:45:50Z","updated_at":"2017-11-07T15:59:56Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/Shopify/graphql-batch/pulls/68","html_url":"https://github.com/Shopify/graphql-batch/pull/68","diff_url":"https://github.com/Shopify/graphql-batch/pull/68.diff","patch_url":"https://github.com/Shopify/graphql-batch/pull/68.patch"},"body":"* Changed: GraphQL::Batch.use can take optional `custom_executor`\r\n  * `GraphQL::Batch::Setup` and `GraphQL::Batch::SetupMultiplex` updated to hold reference to the executor class (defaults to GraphQL::Batch::Executor) as instance variables.\r\n\r\n@dylanahsmith @eapache @swalkinshaw 👋 ~~I'm looking to verify my approach here before continuing. See the linked Shopify/shopify PR for more context.~~ Updated according PR review comments so far."},"comment":{"url":"https://api.github.com/repos/Shopify/graphql-batch/issues/comments/342529373","html_url":"https://github.com/Shopify/graphql-batch/pull/68#issuecomment-342529373","issue_url":"https://api.github.com/repos/Shopify/graphql-batch/issues/68","id":342529373,"user":{"login":"chrisbutcher","id":1916444,"avatar_url":"https://avatars0.githubusercontent.com/u/1916444?v=4","gravatar_id":"","url":"https://api.github.com/users/chrisbutcher","html_url":"https://github.com/chrisbutcher","followers_url":"https://api.github.com/users/chrisbutcher/followers","following_url":"https://api.github.com/users/chrisbutcher/following{/other_user}","gists_url":"https://api.github.com/users/chrisbutcher/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisbutcher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisbutcher/subscriptions","organizations_url":"https://api.github.com/users/chrisbutcher/orgs","repos_url":"https://api.github.com/users/chrisbutcher/repos","events_url":"https://api.github.com/users/chrisbutcher/events{/privacy}","received_events_url":"https://api.github.com/users/chrisbutcher/received_events","type":"User","site_admin":false},"created_at":"2017-11-07T15:59:56Z","updated_at":"2017-11-07T15:59:56Z","author_association":"NONE","body":"Thanks @dylanahsmith ! I've updated the PR in response to your suggestions. Any suggestions on how/if we should unit test this change? We don't have a SetupTest, nor coverage on `GraphQL::Batch.use`.\r\n\r\nThe only testable changes appear to be in `GraphQL::Batch.use`'s forwarding of `executor_class`, and the expectation in `start_batching` that the passed-in Executor class instantiated. "}}
{"actor":{"display_login":"chrisbutcher"}}