{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/141090082","pull_request_review_id":65254365,"id":141090082,"diff_hunk":"@@ -722,75 +640,215 @@ private[history] class FsHistoryProvider(conf: SparkConf, clock: Clock)\n       appId: String,\n       attemptId: Option[String],\n       prevFileSize: Long)(): Boolean = {\n-    lookup(appId, attemptId) match {\n-      case None =>\n+    try {\n+      val attempt = getAttempt(appId, attemptId)\n+      val logPath = fs.makeQualified(new Path(logDir, attempt.logPath))\n+      recordedFileSize(logPath) > prevFileSize\n+    } catch {\n+      case _: NoSuchElementException =>\n         logDebug(s\"Application Attempt $appId/$attemptId not found\")\n         false\n-      case Some(latest) =>\n-        prevFileSize < latest.fileSize\n     }\n   }\n-}\n \n-private[history] object FsHistoryProvider {\n-  val DEFAULT_LOG_DIR = \"file:/tmp/spark-events\"\n+  /**\n+   * Return the last known size of the given event log, recorded the last time the file\n+   * system scanner detected a change in the file.\n+   */\n+  private def recordedFileSize(log: Path): Long = {\n+    try {\n+      listing.read(classOf[LogInfo], log.toString()).fileSize\n+    } catch {\n+      case _: NoSuchElementException => 0L\n+    }\n+  }\n+\n+  private def load(appId: String): ApplicationInfoWrapper = {\n+    listing.read(classOf[ApplicationInfoWrapper], appId)\n+  }\n+\n+  /**\n+   * Write the app's information to the given store. Serialized to avoid the (notedly rare) case\n+   * where two threads are processing separate attempts of the same application.\n+   */\n+  private def addListing(app: ApplicationInfoWrapper): Unit = listing.synchronized {\n+    val attempt = app.attempts.head\n+\n+    val oldApp = try {\n+      listing.read(classOf[ApplicationInfoWrapper], app.id)\n+    } catch {\n+      case _: NoSuchElementException =>\n+        app\n+    }\n+\n+    def compareAttemptInfo(a1: AttemptInfoWrapper, a2: AttemptInfoWrapper): Boolean = {","path":"core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala","position":626,"original_position":626,"commit_id":"cd2172a027cba92755c89dbaa5f010917749a98a","original_commit_id":"cd2172a027cba92755c89dbaa5f010917749a98a","user":{"login":"cloud-fan","id":3182036,"avatar_url":"https://avatars3.githubusercontent.com/u/3182036?v=4","gravatar_id":"","url":"https://api.github.com/users/cloud-fan","html_url":"https://github.com/cloud-fan","followers_url":"https://api.github.com/users/cloud-fan/followers","following_url":"https://api.github.com/users/cloud-fan/following{/other_user}","gists_url":"https://api.github.com/users/cloud-fan/gists{/gist_id}","starred_url":"https://api.github.com/users/cloud-fan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloud-fan/subscriptions","organizations_url":"https://api.github.com/users/cloud-fan/orgs","repos_url":"https://api.github.com/users/cloud-fan/repos","events_url":"https://api.github.com/users/cloud-fan/events{/privacy}","received_events_url":"https://api.github.com/users/cloud-fan/received_events","type":"User","site_admin":false},"body":"can we add a `isStartedEarlierThan(other)` method in `AttemptInfoWrapper`?","created_at":"2017-09-26T15:19:37Z","updated_at":"2017-09-26T15:19:37Z","html_url":"https://github.com/apache/spark/pull/18887#discussion_r141090082","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/18887","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/141090082"},"html":{"href":"https://github.com/apache/spark/pull/18887#discussion_r141090082"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/18887"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/18887","id":134770641,"html_url":"https://github.com/apache/spark/pull/18887","diff_url":"https://github.com/apache/spark/pull/18887.diff","patch_url":"https://github.com/apache/spark/pull/18887.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/18887","number":18887,"state":"open","locked":false,"title":"[SPARK-20642][core] Store FsHistoryProvider listing data in a KVStore.","user":{"login":"vanzin","id":1694083,"avatar_url":"https://avatars0.githubusercontent.com/u/1694083?v=4","gravatar_id":"","url":"https://api.github.com/users/vanzin","html_url":"https://github.com/vanzin","followers_url":"https://api.github.com/users/vanzin/followers","following_url":"https://api.github.com/users/vanzin/following{/other_user}","gists_url":"https://api.github.com/users/vanzin/gists{/gist_id}","starred_url":"https://api.github.com/users/vanzin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vanzin/subscriptions","organizations_url":"https://api.github.com/users/vanzin/orgs","repos_url":"https://api.github.com/users/vanzin/repos","events_url":"https://api.github.com/users/vanzin/events{/privacy}","received_events_url":"https://api.github.com/users/vanzin/received_events","type":"User","site_admin":false},"body":"The application listing is still generated from event logs, but is now stored\r\nin a KVStore instance. By default an in-memory store is used, but a new config\r\nallows setting a local disk path to store the data, in which case a LevelDB\r\nstore will be created.\r\n\r\nThe provider stores things internally using the public REST API types; I believe\r\nthis is better going forward since it will make it easier to get rid of the\r\ninternal history server API which is mostly redundant at this point.\r\n\r\nI also added a finalizer to LevelDBIterator, to make sure that resources are\r\neventually released. This helps when code iterates but does not exhaust the\r\niterator, thus not triggering the auto-close code.\r\n\r\nHistoryServerSuite was modified to not re-start the history server unnecessarily;\r\nthis makes the json validation tests run more quickly.","created_at":"2017-08-08T22:14:16Z","updated_at":"2017-09-26T15:19:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"367a2ab77867abeb315865292d36f21627b2ff45","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/18887/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/18887/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/18887/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/cd2172a027cba92755c89dbaa5f010917749a98a","head":{"label":"vanzin:SPARK-20642","ref":"SPARK-20642","sha":"cd2172a027cba92755c89dbaa5f010917749a98a","user":{"login":"vanzin","id":1694083,"avatar_url":"https://avatars0.githubusercontent.com/u/1694083?v=4","gravatar_id":"","url":"https://api.github.com/users/vanzin","html_url":"https://github.com/vanzin","followers_url":"https://api.github.com/users/vanzin/followers","following_url":"https://api.github.com/users/vanzin/following{/other_user}","gists_url":"https://api.github.com/users/vanzin/gists{/gist_id}","starred_url":"https://api.github.com/users/vanzin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vanzin/subscriptions","organizations_url":"https://api.github.com/users/vanzin/orgs","repos_url":"https://api.github.com/users/vanzin/repos","events_url":"https://api.github.com/users/vanzin/events{/privacy}","received_events_url":"https://api.github.com/users/vanzin/received_events","type":"User","site_admin":false},"repo":{"id":18302272,"name":"spark","full_name":"vanzin/spark","owner":{"login":"vanzin","id":1694083,"avatar_url":"https://avatars0.githubusercontent.com/u/1694083?v=4","gravatar_id":"","url":"https://api.github.com/users/vanzin","html_url":"https://github.com/vanzin","followers_url":"https://api.github.com/users/vanzin/followers","following_url":"https://api.github.com/users/vanzin/following{/other_user}","gists_url":"https://api.github.com/users/vanzin/gists{/gist_id}","starred_url":"https://api.github.com/users/vanzin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vanzin/subscriptions","organizations_url":"https://api.github.com/users/vanzin/orgs","repos_url":"https://api.github.com/users/vanzin/repos","events_url":"https://api.github.com/users/vanzin/events{/privacy}","received_events_url":"https://api.github.com/users/vanzin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vanzin/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/vanzin/spark","forks_url":"https://api.github.com/repos/vanzin/spark/forks","keys_url":"https://api.github.com/repos/vanzin/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vanzin/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vanzin/spark/teams","hooks_url":"https://api.github.com/repos/vanzin/spark/hooks","issue_events_url":"https://api.github.com/repos/vanzin/spark/issues/events{/number}","events_url":"https://api.github.com/repos/vanzin/spark/events","assignees_url":"https://api.github.com/repos/vanzin/spark/assignees{/user}","branches_url":"https://api.github.com/repos/vanzin/spark/branches{/branch}","tags_url":"https://api.github.com/repos/vanzin/spark/tags","blobs_url":"https://api.github.com/repos/vanzin/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vanzin/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vanzin/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/vanzin/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vanzin/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/vanzin/spark/languages","stargazers_url":"https://api.github.com/repos/vanzin/spark/stargazers","contributors_url":"https://api.github.com/repos/vanzin/spark/contributors","subscribers_url":"https://api.github.com/repos/vanzin/spark/subscribers","subscription_url":"https://api.github.com/repos/vanzin/spark/subscription","commits_url":"https://api.github.com/repos/vanzin/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/vanzin/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/vanzin/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/vanzin/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/vanzin/spark/contents/{+path}","compare_url":"https://api.github.com/repos/vanzin/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vanzin/spark/merges","archive_url":"https://api.github.com/repos/vanzin/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vanzin/spark/downloads","issues_url":"https://api.github.com/repos/vanzin/spark/issues{/number}","pulls_url":"https://api.github.com/repos/vanzin/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/vanzin/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/vanzin/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vanzin/spark/labels{/name}","releases_url":"https://api.github.com/repos/vanzin/spark/releases{/id}","deployments_url":"https://api.github.com/repos/vanzin/spark/deployments","created_at":"2014-03-31T17:49:25Z","updated_at":"2015-09-23T22:03:10Z","pushed_at":"2017-09-25T17:05:30Z","git_url":"git://github.com/vanzin/spark.git","ssh_url":"git@github.com:vanzin/spark.git","clone_url":"https://github.com/vanzin/spark.git","svn_url":"https://github.com/vanzin/spark","homepage":null,"size":240530,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":13,"forks":0,"open_issues":13,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"365a29bdbfd18aae4b5374157dc1d2abfc64eb0e","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","deployments_url":"https://api.github.com/repos/apache/spark/deployments","created_at":"2014-02-25T08:00:08Z","updated_at":"2017-09-26T14:45:07Z","pushed_at":"2017-09-26T14:55:48Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":263397,"stargazers_count":14436,"watchers_count":14436,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13499,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":396,"forks":13499,"open_issues":396,"watchers":14436,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/18887"},"html":{"href":"https://github.com/apache/spark/pull/18887"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/18887"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/18887/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/18887/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/18887/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/cd2172a027cba92755c89dbaa5f010917749a98a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"cloud-fan"}}