{"action":"created","comment":{"url":"https://api.github.com/repos/ligato/cn-infra/pulls/comments/139653314","pull_request_review_id":63614262,"id":139653314,"diff_hunk":"@@ -280,9 +286,9 @@ func (logger *Logger) GetLevel() logging.LogLevel {\n \n // AddHook adds a hook to the standard logger hooks.\n func (logger *Logger) AddHook(hook lg.Hook) {\n-\tlogger.access.Lock()\n-\tdefer logger.access.Unlock()\n+\tstd := logger.stdStore.Load().(*lg.Logger)","path":"logging/logrus/logger.go","position":188,"original_position":188,"commit_id":"479057483903c2d7fd3c7b86f3f9ae42de5a548b","original_commit_id":"479057483903c2d7fd3c7b86f3f9ae42de5a548b","user":{"login":"jozef-slezak","id":16844103,"avatar_url":"https://avatars2.githubusercontent.com/u/16844103?v=4","gravatar_id":"","url":"https://api.github.com/users/jozef-slezak","html_url":"https://github.com/jozef-slezak","followers_url":"https://api.github.com/users/jozef-slezak/followers","following_url":"https://api.github.com/users/jozef-slezak/following{/other_user}","gists_url":"https://api.github.com/users/jozef-slezak/gists{/gist_id}","starred_url":"https://api.github.com/users/jozef-slezak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jozef-slezak/subscriptions","organizations_url":"https://api.github.com/users/jozef-slezak/orgs","repos_url":"https://api.github.com/users/jozef-slezak/repos","events_url":"https://api.github.com/users/jozef-slezak/events{/privacy}","received_events_url":"https://api.github.com/users/jozef-slezak/received_events","type":"User","site_admin":false},"body":"It is not probable to add too many hooks therefore you can apply same solution as for Formatter - think about making the Hooks effectively immutable (that it will be same situation as for the Formatter).\r\n\r\nhttps://stackoverflow.com/questions/16678416/different-between-immutable-and-effectively-immutable-objects","created_at":"2017-09-19T10:28:13Z","updated_at":"2017-09-19T10:28:13Z","html_url":"https://github.com/ligato/cn-infra/pull/150#discussion_r139653314","pull_request_url":"https://api.github.com/repos/ligato/cn-infra/pulls/150","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ligato/cn-infra/pulls/comments/139653314"},"html":{"href":"https://github.com/ligato/cn-infra/pull/150#discussion_r139653314"},"pull_request":{"href":"https://api.github.com/repos/ligato/cn-infra/pulls/150"}}},"pull_request":{"url":"https://api.github.com/repos/ligato/cn-infra/pulls/150","id":141562799,"html_url":"https://github.com/ligato/cn-infra/pull/150","diff_url":"https://github.com/ligato/cn-infra/pull/150.diff","patch_url":"https://github.com/ligato/cn-infra/pull/150.patch","issue_url":"https://api.github.com/repos/ligato/cn-infra/issues/150","number":150,"state":"open","locked":false,"title":"ODPM-449: mutex replaced for atomic.Value","user":{"login":"VladoLavor","id":15376606,"avatar_url":"https://avatars2.githubusercontent.com/u/15376606?v=4","gravatar_id":"","url":"https://api.github.com/users/VladoLavor","html_url":"https://github.com/VladoLavor","followers_url":"https://api.github.com/users/VladoLavor/followers","following_url":"https://api.github.com/users/VladoLavor/following{/other_user}","gists_url":"https://api.github.com/users/VladoLavor/gists{/gist_id}","starred_url":"https://api.github.com/users/VladoLavor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VladoLavor/subscriptions","organizations_url":"https://api.github.com/users/VladoLavor/orgs","repos_url":"https://api.github.com/users/VladoLavor/repos","events_url":"https://api.github.com/users/VladoLavor/events{/privacy}","received_events_url":"https://api.github.com/users/VladoLavor/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-09-18T10:03:32Z","updated_at":"2017-09-19T10:28:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"49d97834adf06837576eda5e40c7f87fb9383b47","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ligato/cn-infra/pulls/150/commits","review_comments_url":"https://api.github.com/repos/ligato/cn-infra/pulls/150/comments","review_comment_url":"https://api.github.com/repos/ligato/cn-infra/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ligato/cn-infra/issues/150/comments","statuses_url":"https://api.github.com/repos/ligato/cn-infra/statuses/479057483903c2d7fd3c7b86f3f9ae42de5a548b","head":{"label":"VladoLavor:master","ref":"master","sha":"479057483903c2d7fd3c7b86f3f9ae42de5a548b","user":{"login":"VladoLavor","id":15376606,"avatar_url":"https://avatars2.githubusercontent.com/u/15376606?v=4","gravatar_id":"","url":"https://api.github.com/users/VladoLavor","html_url":"https://github.com/VladoLavor","followers_url":"https://api.github.com/users/VladoLavor/followers","following_url":"https://api.github.com/users/VladoLavor/following{/other_user}","gists_url":"https://api.github.com/users/VladoLavor/gists{/gist_id}","starred_url":"https://api.github.com/users/VladoLavor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VladoLavor/subscriptions","organizations_url":"https://api.github.com/users/VladoLavor/orgs","repos_url":"https://api.github.com/users/VladoLavor/repos","events_url":"https://api.github.com/users/VladoLavor/events{/privacy}","received_events_url":"https://api.github.com/users/VladoLavor/received_events","type":"User","site_admin":false},"repo":{"id":98873097,"name":"cn-infra","full_name":"VladoLavor/cn-infra","owner":{"login":"VladoLavor","id":15376606,"avatar_url":"https://avatars2.githubusercontent.com/u/15376606?v=4","gravatar_id":"","url":"https://api.github.com/users/VladoLavor","html_url":"https://github.com/VladoLavor","followers_url":"https://api.github.com/users/VladoLavor/followers","following_url":"https://api.github.com/users/VladoLavor/following{/other_user}","gists_url":"https://api.github.com/users/VladoLavor/gists{/gist_id}","starred_url":"https://api.github.com/users/VladoLavor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VladoLavor/subscriptions","organizations_url":"https://api.github.com/users/VladoLavor/orgs","repos_url":"https://api.github.com/users/VladoLavor/repos","events_url":"https://api.github.com/users/VladoLavor/events{/privacy}","received_events_url":"https://api.github.com/users/VladoLavor/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/VladoLavor/cn-infra","description":"Cloud-native Virtual Network Function (VNF) framework","fork":true,"url":"https://api.github.com/repos/VladoLavor/cn-infra","forks_url":"https://api.github.com/repos/VladoLavor/cn-infra/forks","keys_url":"https://api.github.com/repos/VladoLavor/cn-infra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VladoLavor/cn-infra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VladoLavor/cn-infra/teams","hooks_url":"https://api.github.com/repos/VladoLavor/cn-infra/hooks","issue_events_url":"https://api.github.com/repos/VladoLavor/cn-infra/issues/events{/number}","events_url":"https://api.github.com/repos/VladoLavor/cn-infra/events","assignees_url":"https://api.github.com/repos/VladoLavor/cn-infra/assignees{/user}","branches_url":"https://api.github.com/repos/VladoLavor/cn-infra/branches{/branch}","tags_url":"https://api.github.com/repos/VladoLavor/cn-infra/tags","blobs_url":"https://api.github.com/repos/VladoLavor/cn-infra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VladoLavor/cn-infra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VladoLavor/cn-infra/git/refs{/sha}","trees_url":"https://api.github.com/repos/VladoLavor/cn-infra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VladoLavor/cn-infra/statuses/{sha}","languages_url":"https://api.github.com/repos/VladoLavor/cn-infra/languages","stargazers_url":"https://api.github.com/repos/VladoLavor/cn-infra/stargazers","contributors_url":"https://api.github.com/repos/VladoLavor/cn-infra/contributors","subscribers_url":"https://api.github.com/repos/VladoLavor/cn-infra/subscribers","subscription_url":"https://api.github.com/repos/VladoLavor/cn-infra/subscription","commits_url":"https://api.github.com/repos/VladoLavor/cn-infra/commits{/sha}","git_commits_url":"https://api.github.com/repos/VladoLavor/cn-infra/git/commits{/sha}","comments_url":"https://api.github.com/repos/VladoLavor/cn-infra/comments{/number}","issue_comment_url":"https://api.github.com/repos/VladoLavor/cn-infra/issues/comments{/number}","contents_url":"https://api.github.com/repos/VladoLavor/cn-infra/contents/{+path}","compare_url":"https://api.github.com/repos/VladoLavor/cn-infra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VladoLavor/cn-infra/merges","archive_url":"https://api.github.com/repos/VladoLavor/cn-infra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VladoLavor/cn-infra/downloads","issues_url":"https://api.github.com/repos/VladoLavor/cn-infra/issues{/number}","pulls_url":"https://api.github.com/repos/VladoLavor/cn-infra/pulls{/number}","milestones_url":"https://api.github.com/repos/VladoLavor/cn-infra/milestones{/number}","notifications_url":"https://api.github.com/repos/VladoLavor/cn-infra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VladoLavor/cn-infra/labels{/name}","releases_url":"https://api.github.com/repos/VladoLavor/cn-infra/releases{/id}","deployments_url":"https://api.github.com/repos/VladoLavor/cn-infra/deployments","created_at":"2017-07-31T09:40:33Z","updated_at":"2017-07-31T09:40:35Z","pushed_at":"2017-09-19T08:43:06Z","git_url":"git://github.com/VladoLavor/cn-infra.git","ssh_url":"git@github.com:VladoLavor/cn-infra.git","clone_url":"https://github.com/VladoLavor/cn-infra.git","svn_url":"https://github.com/VladoLavor/cn-infra","homepage":"","size":40060,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ligato:master","ref":"master","sha":"75e47347c6df026dcea84fb1509c04dda359fd73","user":{"login":"ligato","id":28989152,"avatar_url":"https://avatars0.githubusercontent.com/u/28989152?v=4","gravatar_id":"","url":"https://api.github.com/users/ligato","html_url":"https://github.com/ligato","followers_url":"https://api.github.com/users/ligato/followers","following_url":"https://api.github.com/users/ligato/following{/other_user}","gists_url":"https://api.github.com/users/ligato/gists{/gist_id}","starred_url":"https://api.github.com/users/ligato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ligato/subscriptions","organizations_url":"https://api.github.com/users/ligato/orgs","repos_url":"https://api.github.com/users/ligato/repos","events_url":"https://api.github.com/users/ligato/events{/privacy}","received_events_url":"https://api.github.com/users/ligato/received_events","type":"Organization","site_admin":false},"repo":{"id":94889501,"name":"cn-infra","full_name":"ligato/cn-infra","owner":{"login":"ligato","id":28989152,"avatar_url":"https://avatars0.githubusercontent.com/u/28989152?v=4","gravatar_id":"","url":"https://api.github.com/users/ligato","html_url":"https://github.com/ligato","followers_url":"https://api.github.com/users/ligato/followers","following_url":"https://api.github.com/users/ligato/following{/other_user}","gists_url":"https://api.github.com/users/ligato/gists{/gist_id}","starred_url":"https://api.github.com/users/ligato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ligato/subscriptions","organizations_url":"https://api.github.com/users/ligato/orgs","repos_url":"https://api.github.com/users/ligato/repos","events_url":"https://api.github.com/users/ligato/events{/privacy}","received_events_url":"https://api.github.com/users/ligato/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ligato/cn-infra","description":"Cloud-native Virtual Network Function (VNF) platform","fork":false,"url":"https://api.github.com/repos/ligato/cn-infra","forks_url":"https://api.github.com/repos/ligato/cn-infra/forks","keys_url":"https://api.github.com/repos/ligato/cn-infra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ligato/cn-infra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ligato/cn-infra/teams","hooks_url":"https://api.github.com/repos/ligato/cn-infra/hooks","issue_events_url":"https://api.github.com/repos/ligato/cn-infra/issues/events{/number}","events_url":"https://api.github.com/repos/ligato/cn-infra/events","assignees_url":"https://api.github.com/repos/ligato/cn-infra/assignees{/user}","branches_url":"https://api.github.com/repos/ligato/cn-infra/branches{/branch}","tags_url":"https://api.github.com/repos/ligato/cn-infra/tags","blobs_url":"https://api.github.com/repos/ligato/cn-infra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ligato/cn-infra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ligato/cn-infra/git/refs{/sha}","trees_url":"https://api.github.com/repos/ligato/cn-infra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ligato/cn-infra/statuses/{sha}","languages_url":"https://api.github.com/repos/ligato/cn-infra/languages","stargazers_url":"https://api.github.com/repos/ligato/cn-infra/stargazers","contributors_url":"https://api.github.com/repos/ligato/cn-infra/contributors","subscribers_url":"https://api.github.com/repos/ligato/cn-infra/subscribers","subscription_url":"https://api.github.com/repos/ligato/cn-infra/subscription","commits_url":"https://api.github.com/repos/ligato/cn-infra/commits{/sha}","git_commits_url":"https://api.github.com/repos/ligato/cn-infra/git/commits{/sha}","comments_url":"https://api.github.com/repos/ligato/cn-infra/comments{/number}","issue_comment_url":"https://api.github.com/repos/ligato/cn-infra/issues/comments{/number}","contents_url":"https://api.github.com/repos/ligato/cn-infra/contents/{+path}","compare_url":"https://api.github.com/repos/ligato/cn-infra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ligato/cn-infra/merges","archive_url":"https://api.github.com/repos/ligato/cn-infra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ligato/cn-infra/downloads","issues_url":"https://api.github.com/repos/ligato/cn-infra/issues{/number}","pulls_url":"https://api.github.com/repos/ligato/cn-infra/pulls{/number}","milestones_url":"https://api.github.com/repos/ligato/cn-infra/milestones{/number}","notifications_url":"https://api.github.com/repos/ligato/cn-infra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ligato/cn-infra/labels{/name}","releases_url":"https://api.github.com/repos/ligato/cn-infra/releases{/id}","deployments_url":"https://api.github.com/repos/ligato/cn-infra/deployments","created_at":"2017-06-20T12:37:37Z","updated_at":"2017-09-07T19:58:06Z","pushed_at":"2017-09-19T08:43:58Z","git_url":"git://github.com/ligato/cn-infra.git","ssh_url":"git@github.com:ligato/cn-infra.git","clone_url":"https://github.com/ligato/cn-infra.git","svn_url":"https://github.com/ligato/cn-infra","homepage":"","size":54571,"stargazers_count":6,"watchers_count":6,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":3,"forks":12,"open_issues":3,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ligato/cn-infra/pulls/150"},"html":{"href":"https://github.com/ligato/cn-infra/pull/150"},"issue":{"href":"https://api.github.com/repos/ligato/cn-infra/issues/150"},"comments":{"href":"https://api.github.com/repos/ligato/cn-infra/issues/150/comments"},"review_comments":{"href":"https://api.github.com/repos/ligato/cn-infra/pulls/150/comments"},"review_comment":{"href":"https://api.github.com/repos/ligato/cn-infra/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ligato/cn-infra/pulls/150/commits"},"statuses":{"href":"https://api.github.com/repos/ligato/cn-infra/statuses/479057483903c2d7fd3c7b86f3f9ae42de5a548b"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"jozef-slezak"}}