{"action":"created","comment":{"url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/comments/149563319","pull_request_review_id":74977313,"id":149563319,"diff_hunk":"@@ -101,6 +105,17 @@\n \n \t\tmoving_status = SHUTTLE_IDLE\n \n+/datum/shuttle/proc/fuel_check()\n+\tif(istype(src,/datum/shuttle/autodock/overmap))","path":"code/modules/shuttles/shuttle.dm","position":29,"original_position":27,"commit_id":"4b2f4df29fa1ab880838ac7d601c2092e71c074b","original_commit_id":"fb928a18a68234b849d9eebf014a88cb3b1b4823","user":{"login":"ninjanomnom","id":1234602,"avatar_url":"https://avatars3.githubusercontent.com/u/1234602?v=4","gravatar_id":"","url":"https://api.github.com/users/ninjanomnom","html_url":"https://github.com/ninjanomnom","followers_url":"https://api.github.com/users/ninjanomnom/followers","following_url":"https://api.github.com/users/ninjanomnom/following{/other_user}","gists_url":"https://api.github.com/users/ninjanomnom/gists{/gist_id}","starred_url":"https://api.github.com/users/ninjanomnom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ninjanomnom/subscriptions","organizations_url":"https://api.github.com/users/ninjanomnom/orgs","repos_url":"https://api.github.com/users/ninjanomnom/repos","events_url":"https://api.github.com/users/ninjanomnom/events{/privacy}","received_events_url":"https://api.github.com/users/ninjanomnom/received_events","type":"User","site_admin":false},"body":"yes you have \r\n```\r\n/datum/shuttle/proc/fuel_check()\r\n   return FALSE\r\n```\r\nthen override it in the later type\r\n","created_at":"2017-11-08T02:49:11Z","updated_at":"2017-11-08T02:49:11Z","html_url":"https://github.com/Baystation12/Baystation12/pull/19243#discussion_r149563319","pull_request_url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/19243","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/comments/149563319"},"html":{"href":"https://github.com/Baystation12/Baystation12/pull/19243#discussion_r149563319"},"pull_request":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/19243"}},"in_reply_to_id":148187379},"pull_request":{"url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/19243","id":149438963,"html_url":"https://github.com/Baystation12/Baystation12/pull/19243","diff_url":"https://github.com/Baystation12/Baystation12/pull/19243.diff","patch_url":"https://github.com/Baystation12/Baystation12/pull/19243.patch","issue_url":"https://api.github.com/repos/Baystation12/Baystation12/issues/19243","number":19243,"state":"open","locked":false,"title":"Added shuttle fuel consumption functionality (WIP; not mapped in yet)","user":{"login":"dryerlint","id":30705790,"avatar_url":"https://avatars3.githubusercontent.com/u/30705790?v=4","gravatar_id":"","url":"https://api.github.com/users/dryerlint","html_url":"https://github.com/dryerlint","followers_url":"https://api.github.com/users/dryerlint/followers","following_url":"https://api.github.com/users/dryerlint/following{/other_user}","gists_url":"https://api.github.com/users/dryerlint/gists{/gist_id}","starred_url":"https://api.github.com/users/dryerlint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dryerlint/subscriptions","organizations_url":"https://api.github.com/users/dryerlint/orgs","repos_url":"https://api.github.com/users/dryerlint/repos","events_url":"https://api.github.com/users/dryerlint/events{/privacy}","received_events_url":"https://api.github.com/users/dryerlint/received_events","type":"User","site_admin":false},"body":"This PR just adds the functionality. It doesn't actually map in any fuel ports, so none of the shuttles will be affected... yet.\r\n\r\n![image](https://user-images.githubusercontent.com/30705790/32155873-8851379c-bd10-11e7-82d5-3f9475b92563.png)\r\n\r\n![image](https://user-images.githubusercontent.com/30705790/32156081-927d605a-bd11-11e7-8adc-237358821f38.png)\r\n\r\nShuttles can now have a \"fuel consumption\" setting. Fuel (phoron, or any flammable gas) is supplied via the mapped-in \"fuel port\" object. At game start, the port contains one 303kPa phoron tank, enough fuel for two trips (one round-trip). I plan to have each trip consume 4 moles of phoron, but this can be changed in the shuttle variables.\r\n\r\nMy intention is to have the Supply team in charge of refueling the hangar's shuttles (Charon and GUP), hopefully making that job a bit more interesting and interactive.\r\n\r\n(Note: I know the code is pretty sloppy right now. This PR was put up for Travis, and also to see if people actually like the idea.)\r\n(Edited 11/7/2017)","created_at":"2017-10-30T05:28:29Z","updated_at":"2017-11-08T02:49:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"952c74f76162825cc16aed98e63677cd1e7edda6","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/19243/commits","review_comments_url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/19243/comments","review_comment_url":"https://api.github.com/repos/Baystation12/Baystation12/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Baystation12/Baystation12/issues/19243/comments","statuses_url":"https://api.github.com/repos/Baystation12/Baystation12/statuses/4b2f4df29fa1ab880838ac7d601c2092e71c074b","head":{"label":"dryerlint:30-10-2017-shuttlefueltanks","ref":"30-10-2017-shuttlefueltanks","sha":"4b2f4df29fa1ab880838ac7d601c2092e71c074b","user":{"login":"dryerlint","id":30705790,"avatar_url":"https://avatars3.githubusercontent.com/u/30705790?v=4","gravatar_id":"","url":"https://api.github.com/users/dryerlint","html_url":"https://github.com/dryerlint","followers_url":"https://api.github.com/users/dryerlint/followers","following_url":"https://api.github.com/users/dryerlint/following{/other_user}","gists_url":"https://api.github.com/users/dryerlint/gists{/gist_id}","starred_url":"https://api.github.com/users/dryerlint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dryerlint/subscriptions","organizations_url":"https://api.github.com/users/dryerlint/orgs","repos_url":"https://api.github.com/users/dryerlint/repos","events_url":"https://api.github.com/users/dryerlint/events{/privacy}","received_events_url":"https://api.github.com/users/dryerlint/received_events","type":"User","site_admin":false},"repo":{"id":100133130,"name":"Baystation12","full_name":"dryerlint/Baystation12","owner":{"login":"dryerlint","id":30705790,"avatar_url":"https://avatars3.githubusercontent.com/u/30705790?v=4","gravatar_id":"","url":"https://api.github.com/users/dryerlint","html_url":"https://github.com/dryerlint","followers_url":"https://api.github.com/users/dryerlint/followers","following_url":"https://api.github.com/users/dryerlint/following{/other_user}","gists_url":"https://api.github.com/users/dryerlint/gists{/gist_id}","starred_url":"https://api.github.com/users/dryerlint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dryerlint/subscriptions","organizations_url":"https://api.github.com/users/dryerlint/orgs","repos_url":"https://api.github.com/users/dryerlint/repos","events_url":"https://api.github.com/users/dryerlint/events{/privacy}","received_events_url":"https://api.github.com/users/dryerlint/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dryerlint/Baystation12","description":"The code for Baystation12's branch of SS13","fork":true,"url":"https://api.github.com/repos/dryerlint/Baystation12","forks_url":"https://api.github.com/repos/dryerlint/Baystation12/forks","keys_url":"https://api.github.com/repos/dryerlint/Baystation12/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dryerlint/Baystation12/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dryerlint/Baystation12/teams","hooks_url":"https://api.github.com/repos/dryerlint/Baystation12/hooks","issue_events_url":"https://api.github.com/repos/dryerlint/Baystation12/issues/events{/number}","events_url":"https://api.github.com/repos/dryerlint/Baystation12/events","assignees_url":"https://api.github.com/repos/dryerlint/Baystation12/assignees{/user}","branches_url":"https://api.github.com/repos/dryerlint/Baystation12/branches{/branch}","tags_url":"https://api.github.com/repos/dryerlint/Baystation12/tags","blobs_url":"https://api.github.com/repos/dryerlint/Baystation12/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dryerlint/Baystation12/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dryerlint/Baystation12/git/refs{/sha}","trees_url":"https://api.github.com/repos/dryerlint/Baystation12/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dryerlint/Baystation12/statuses/{sha}","languages_url":"https://api.github.com/repos/dryerlint/Baystation12/languages","stargazers_url":"https://api.github.com/repos/dryerlint/Baystation12/stargazers","contributors_url":"https://api.github.com/repos/dryerlint/Baystation12/contributors","subscribers_url":"https://api.github.com/repos/dryerlint/Baystation12/subscribers","subscription_url":"https://api.github.com/repos/dryerlint/Baystation12/subscription","commits_url":"https://api.github.com/repos/dryerlint/Baystation12/commits{/sha}","git_commits_url":"https://api.github.com/repos/dryerlint/Baystation12/git/commits{/sha}","comments_url":"https://api.github.com/repos/dryerlint/Baystation12/comments{/number}","issue_comment_url":"https://api.github.com/repos/dryerlint/Baystation12/issues/comments{/number}","contents_url":"https://api.github.com/repos/dryerlint/Baystation12/contents/{+path}","compare_url":"https://api.github.com/repos/dryerlint/Baystation12/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dryerlint/Baystation12/merges","archive_url":"https://api.github.com/repos/dryerlint/Baystation12/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dryerlint/Baystation12/downloads","issues_url":"https://api.github.com/repos/dryerlint/Baystation12/issues{/number}","pulls_url":"https://api.github.com/repos/dryerlint/Baystation12/pulls{/number}","milestones_url":"https://api.github.com/repos/dryerlint/Baystation12/milestones{/number}","notifications_url":"https://api.github.com/repos/dryerlint/Baystation12/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dryerlint/Baystation12/labels{/name}","releases_url":"https://api.github.com/repos/dryerlint/Baystation12/releases{/id}","deployments_url":"https://api.github.com/repos/dryerlint/Baystation12/deployments","created_at":"2017-08-12T19:17:57Z","updated_at":"2017-08-12T19:18:09Z","pushed_at":"2017-11-08T02:30:05Z","git_url":"git://github.com/dryerlint/Baystation12.git","ssh_url":"git@github.com:dryerlint/Baystation12.git","clone_url":"https://github.com/dryerlint/Baystation12.git","svn_url":"https://github.com/dryerlint/Baystation12","homepage":"http://baystation12.net/","size":718902,"stargazers_count":0,"watchers_count":0,"language":"DM","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"Baystation12:dev","ref":"dev","sha":"32cfa69c7d9de90dd944acda9e0757985d771c7f","user":{"login":"Baystation12","id":1174322,"avatar_url":"https://avatars0.githubusercontent.com/u/1174322?v=4","gravatar_id":"","url":"https://api.github.com/users/Baystation12","html_url":"https://github.com/Baystation12","followers_url":"https://api.github.com/users/Baystation12/followers","following_url":"https://api.github.com/users/Baystation12/following{/other_user}","gists_url":"https://api.github.com/users/Baystation12/gists{/gist_id}","starred_url":"https://api.github.com/users/Baystation12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Baystation12/subscriptions","organizations_url":"https://api.github.com/users/Baystation12/orgs","repos_url":"https://api.github.com/users/Baystation12/repos","events_url":"https://api.github.com/users/Baystation12/events{/privacy}","received_events_url":"https://api.github.com/users/Baystation12/received_events","type":"Organization","site_admin":false},"repo":{"id":2715933,"name":"Baystation12","full_name":"Baystation12/Baystation12","owner":{"login":"Baystation12","id":1174322,"avatar_url":"https://avatars0.githubusercontent.com/u/1174322?v=4","gravatar_id":"","url":"https://api.github.com/users/Baystation12","html_url":"https://github.com/Baystation12","followers_url":"https://api.github.com/users/Baystation12/followers","following_url":"https://api.github.com/users/Baystation12/following{/other_user}","gists_url":"https://api.github.com/users/Baystation12/gists{/gist_id}","starred_url":"https://api.github.com/users/Baystation12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Baystation12/subscriptions","organizations_url":"https://api.github.com/users/Baystation12/orgs","repos_url":"https://api.github.com/users/Baystation12/repos","events_url":"https://api.github.com/users/Baystation12/events{/privacy}","received_events_url":"https://api.github.com/users/Baystation12/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Baystation12/Baystation12","description":"The code for Baystation12's branch of SS13","fork":false,"url":"https://api.github.com/repos/Baystation12/Baystation12","forks_url":"https://api.github.com/repos/Baystation12/Baystation12/forks","keys_url":"https://api.github.com/repos/Baystation12/Baystation12/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Baystation12/Baystation12/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Baystation12/Baystation12/teams","hooks_url":"https://api.github.com/repos/Baystation12/Baystation12/hooks","issue_events_url":"https://api.github.com/repos/Baystation12/Baystation12/issues/events{/number}","events_url":"https://api.github.com/repos/Baystation12/Baystation12/events","assignees_url":"https://api.github.com/repos/Baystation12/Baystation12/assignees{/user}","branches_url":"https://api.github.com/repos/Baystation12/Baystation12/branches{/branch}","tags_url":"https://api.github.com/repos/Baystation12/Baystation12/tags","blobs_url":"https://api.github.com/repos/Baystation12/Baystation12/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Baystation12/Baystation12/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Baystation12/Baystation12/git/refs{/sha}","trees_url":"https://api.github.com/repos/Baystation12/Baystation12/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Baystation12/Baystation12/statuses/{sha}","languages_url":"https://api.github.com/repos/Baystation12/Baystation12/languages","stargazers_url":"https://api.github.com/repos/Baystation12/Baystation12/stargazers","contributors_url":"https://api.github.com/repos/Baystation12/Baystation12/contributors","subscribers_url":"https://api.github.com/repos/Baystation12/Baystation12/subscribers","subscription_url":"https://api.github.com/repos/Baystation12/Baystation12/subscription","commits_url":"https://api.github.com/repos/Baystation12/Baystation12/commits{/sha}","git_commits_url":"https://api.github.com/repos/Baystation12/Baystation12/git/commits{/sha}","comments_url":"https://api.github.com/repos/Baystation12/Baystation12/comments{/number}","issue_comment_url":"https://api.github.com/repos/Baystation12/Baystation12/issues/comments{/number}","contents_url":"https://api.github.com/repos/Baystation12/Baystation12/contents/{+path}","compare_url":"https://api.github.com/repos/Baystation12/Baystation12/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Baystation12/Baystation12/merges","archive_url":"https://api.github.com/repos/Baystation12/Baystation12/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Baystation12/Baystation12/downloads","issues_url":"https://api.github.com/repos/Baystation12/Baystation12/issues{/number}","pulls_url":"https://api.github.com/repos/Baystation12/Baystation12/pulls{/number}","milestones_url":"https://api.github.com/repos/Baystation12/Baystation12/milestones{/number}","notifications_url":"https://api.github.com/repos/Baystation12/Baystation12/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Baystation12/Baystation12/labels{/name}","releases_url":"https://api.github.com/repos/Baystation12/Baystation12/releases{/id}","deployments_url":"https://api.github.com/repos/Baystation12/Baystation12/deployments","created_at":"2011-11-05T16:12:41Z","updated_at":"2017-11-07T12:06:01Z","pushed_at":"2017-11-08T02:30:07Z","git_url":"git://github.com/Baystation12/Baystation12.git","ssh_url":"git@github.com:Baystation12/Baystation12.git","clone_url":"https://github.com/Baystation12/Baystation12.git","svn_url":"https://github.com/Baystation12/Baystation12","homepage":"http://baystation12.net/","size":733253,"stargazers_count":269,"watchers_count":269,"language":"DM","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":877,"mirror_url":null,"archived":false,"open_issues_count":1474,"forks":877,"open_issues":1474,"watchers":269,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/19243"},"html":{"href":"https://github.com/Baystation12/Baystation12/pull/19243"},"issue":{"href":"https://api.github.com/repos/Baystation12/Baystation12/issues/19243"},"comments":{"href":"https://api.github.com/repos/Baystation12/Baystation12/issues/19243/comments"},"review_comments":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/19243/comments"},"review_comment":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Baystation12/Baystation12/pulls/19243/commits"},"statuses":{"href":"https://api.github.com/repos/Baystation12/Baystation12/statuses/4b2f4df29fa1ab880838ac7d601c2092e71c074b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ninjanomnom"}}