{"action":"created","comment":{"url":"https://api.github.com/repos/diffblue/cbmc/pulls/comments/146238501","pull_request_review_id":71150065,"id":146238501,"diff_hunk":"@@ -3,20 +3,24 @@ generic_flex(ansi_c)\n \n add_executable(converter library/converter.cpp)\n \n+file(GLOB ansi_c_library_sources \"library/*.c\")\n+\n add_custom_command(OUTPUT converter_input.txt\n-    COMMAND cat ${CMAKE_CURRENT_SOURCE_DIR}/library/*.c > converter_input.txt\n+    COMMAND cat ${ansi_c_library_sources} > converter_input.txt\n+    DEPENDS ${ansi_c_library_sources}\n )\n \n-add_custom_command(OUTPUT ${CMAKE_CURRENT_BINARY_DIR}/cprover_library.inc\n-    COMMAND converter < converter_input.txt > ${CMAKE_CURRENT_BINARY_DIR}/cprover_library.inc\n-    DEPENDS converter_input.txt\n+add_custom_command(OUTPUT \"${CMAKE_CURRENT_BINARY_DIR}/cprover_library.inc\"\n+    COMMAND converter < \"converter_input.txt\" > \"${CMAKE_CURRENT_BINARY_DIR}/cprover_library.inc\"\n+    DEPENDS \"converter_input.txt\"","path":"src/ansi-c/CMakeLists.txt","position":17,"original_position":17,"commit_id":"771186f004df54fa7c344ebe016c6aa13e0769f4","original_commit_id":"771186f004df54fa7c344ebe016c6aa13e0769f4","user":{"login":"chrisr-diffblue","id":32060010,"avatar_url":"https://avatars2.githubusercontent.com/u/32060010?v=4","gravatar_id":"","url":"https://api.github.com/users/chrisr-diffblue","html_url":"https://github.com/chrisr-diffblue","followers_url":"https://api.github.com/users/chrisr-diffblue/followers","following_url":"https://api.github.com/users/chrisr-diffblue/following{/other_user}","gists_url":"https://api.github.com/users/chrisr-diffblue/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisr-diffblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisr-diffblue/subscriptions","organizations_url":"https://api.github.com/users/chrisr-diffblue/orgs","repos_url":"https://api.github.com/users/chrisr-diffblue/repos","events_url":"https://api.github.com/users/chrisr-diffblue/events{/privacy}","received_events_url":"https://api.github.com/users/chrisr-diffblue/received_events","type":"User","site_admin":false},"body":"It's probably sensible to quote wrap some of those to handle path names with spaces - fairly common on OS X builds, for instance, I suspect.","created_at":"2017-10-23T11:39:48Z","updated_at":"2017-10-23T11:39:48Z","html_url":"https://github.com/diffblue/cbmc/pull/1503#discussion_r146238501","pull_request_url":"https://api.github.com/repos/diffblue/cbmc/pulls/1503","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/diffblue/cbmc/pulls/comments/146238501"},"html":{"href":"https://github.com/diffblue/cbmc/pull/1503#discussion_r146238501"},"pull_request":{"href":"https://api.github.com/repos/diffblue/cbmc/pulls/1503"}},"in_reply_to_id":146235100},"pull_request":{"url":"https://api.github.com/repos/diffblue/cbmc/pulls/1503","id":147768737,"html_url":"https://github.com/diffblue/cbmc/pull/1503","diff_url":"https://github.com/diffblue/cbmc/pull/1503.diff","patch_url":"https://github.com/diffblue/cbmc/pull/1503.patch","issue_url":"https://api.github.com/repos/diffblue/cbmc/issues/1503","number":1503,"state":"open","locked":false,"title":"Rebuild ansi c when necessary","user":{"login":"reuk","id":3016418,"avatar_url":"https://avatars1.githubusercontent.com/u/3016418?v=4","gravatar_id":"","url":"https://api.github.com/users/reuk","html_url":"https://github.com/reuk","followers_url":"https://api.github.com/users/reuk/followers","following_url":"https://api.github.com/users/reuk/following{/other_user}","gists_url":"https://api.github.com/users/reuk/gists{/gist_id}","starred_url":"https://api.github.com/users/reuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reuk/subscriptions","organizations_url":"https://api.github.com/users/reuk/orgs","repos_url":"https://api.github.com/users/reuk/repos","events_url":"https://api.github.com/users/reuk/events{/privacy}","received_events_url":"https://api.github.com/users/reuk/received_events","type":"User","site_admin":false},"body":"@smowton noticed that in the CMake build, the ansi-c target wasn't being rebuilt when files in `library/ansi-c` were changed. This patch should ensure that changes to files in `library/ansi-c` cause a rebuild of the library.","created_at":"2017-10-20T10:33:11Z","updated_at":"2017-10-23T11:39:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"920322f07901a82b1cb0a056952a7f79b257dcb9","assignee":null,"assignees":[],"requested_reviewers":[{"login":"chrisr-diffblue","id":32060010,"avatar_url":"https://avatars2.githubusercontent.com/u/32060010?v=4","gravatar_id":"","url":"https://api.github.com/users/chrisr-diffblue","html_url":"https://github.com/chrisr-diffblue","followers_url":"https://api.github.com/users/chrisr-diffblue/followers","following_url":"https://api.github.com/users/chrisr-diffblue/following{/other_user}","gists_url":"https://api.github.com/users/chrisr-diffblue/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisr-diffblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisr-diffblue/subscriptions","organizations_url":"https://api.github.com/users/chrisr-diffblue/orgs","repos_url":"https://api.github.com/users/chrisr-diffblue/repos","events_url":"https://api.github.com/users/chrisr-diffblue/events{/privacy}","received_events_url":"https://api.github.com/users/chrisr-diffblue/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/diffblue/cbmc/pulls/1503/commits","review_comments_url":"https://api.github.com/repos/diffblue/cbmc/pulls/1503/comments","review_comment_url":"https://api.github.com/repos/diffblue/cbmc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/diffblue/cbmc/issues/1503/comments","statuses_url":"https://api.github.com/repos/diffblue/cbmc/statuses/771186f004df54fa7c344ebe016c6aa13e0769f4","head":{"label":"reuk:reuk/rebuild-ansi-c-when-necessary","ref":"reuk/rebuild-ansi-c-when-necessary","sha":"771186f004df54fa7c344ebe016c6aa13e0769f4","user":{"login":"reuk","id":3016418,"avatar_url":"https://avatars1.githubusercontent.com/u/3016418?v=4","gravatar_id":"","url":"https://api.github.com/users/reuk","html_url":"https://github.com/reuk","followers_url":"https://api.github.com/users/reuk/followers","following_url":"https://api.github.com/users/reuk/following{/other_user}","gists_url":"https://api.github.com/users/reuk/gists{/gist_id}","starred_url":"https://api.github.com/users/reuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reuk/subscriptions","organizations_url":"https://api.github.com/users/reuk/orgs","repos_url":"https://api.github.com/users/reuk/repos","events_url":"https://api.github.com/users/reuk/events{/privacy}","received_events_url":"https://api.github.com/users/reuk/received_events","type":"User","site_admin":false},"repo":{"id":81323882,"name":"cbmc","full_name":"reuk/cbmc","owner":{"login":"reuk","id":3016418,"avatar_url":"https://avatars1.githubusercontent.com/u/3016418?v=4","gravatar_id":"","url":"https://api.github.com/users/reuk","html_url":"https://github.com/reuk","followers_url":"https://api.github.com/users/reuk/followers","following_url":"https://api.github.com/users/reuk/following{/other_user}","gists_url":"https://api.github.com/users/reuk/gists{/gist_id}","starred_url":"https://api.github.com/users/reuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reuk/subscriptions","organizations_url":"https://api.github.com/users/reuk/orgs","repos_url":"https://api.github.com/users/reuk/repos","events_url":"https://api.github.com/users/reuk/events{/privacy}","received_events_url":"https://api.github.com/users/reuk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/reuk/cbmc","description":"C Bounded Model Checker","fork":true,"url":"https://api.github.com/repos/reuk/cbmc","forks_url":"https://api.github.com/repos/reuk/cbmc/forks","keys_url":"https://api.github.com/repos/reuk/cbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reuk/cbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reuk/cbmc/teams","hooks_url":"https://api.github.com/repos/reuk/cbmc/hooks","issue_events_url":"https://api.github.com/repos/reuk/cbmc/issues/events{/number}","events_url":"https://api.github.com/repos/reuk/cbmc/events","assignees_url":"https://api.github.com/repos/reuk/cbmc/assignees{/user}","branches_url":"https://api.github.com/repos/reuk/cbmc/branches{/branch}","tags_url":"https://api.github.com/repos/reuk/cbmc/tags","blobs_url":"https://api.github.com/repos/reuk/cbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reuk/cbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reuk/cbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/reuk/cbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reuk/cbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/reuk/cbmc/languages","stargazers_url":"https://api.github.com/repos/reuk/cbmc/stargazers","contributors_url":"https://api.github.com/repos/reuk/cbmc/contributors","subscribers_url":"https://api.github.com/repos/reuk/cbmc/subscribers","subscription_url":"https://api.github.com/repos/reuk/cbmc/subscription","commits_url":"https://api.github.com/repos/reuk/cbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/reuk/cbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/reuk/cbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/reuk/cbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/reuk/cbmc/contents/{+path}","compare_url":"https://api.github.com/repos/reuk/cbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reuk/cbmc/merges","archive_url":"https://api.github.com/repos/reuk/cbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reuk/cbmc/downloads","issues_url":"https://api.github.com/repos/reuk/cbmc/issues{/number}","pulls_url":"https://api.github.com/repos/reuk/cbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/reuk/cbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/reuk/cbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reuk/cbmc/labels{/name}","releases_url":"https://api.github.com/repos/reuk/cbmc/releases{/id}","deployments_url":"https://api.github.com/repos/reuk/cbmc/deployments","created_at":"2017-02-08T11:40:17Z","updated_at":"2017-02-08T11:40:27Z","pushed_at":"2017-10-22T21:20:45Z","git_url":"git://github.com/reuk/cbmc.git","ssh_url":"git@github.com:reuk/cbmc.git","clone_url":"https://github.com/reuk/cbmc.git","svn_url":"https://github.com/reuk/cbmc","homepage":"http://www.cprover.org/cbmc","size":26997,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"diffblue:develop","ref":"develop","sha":"49554177f8f467ea0bbbf9185ab68739694e8013","user":{"login":"diffblue","id":17216098,"avatar_url":"https://avatars0.githubusercontent.com/u/17216098?v=4","gravatar_id":"","url":"https://api.github.com/users/diffblue","html_url":"https://github.com/diffblue","followers_url":"https://api.github.com/users/diffblue/followers","following_url":"https://api.github.com/users/diffblue/following{/other_user}","gists_url":"https://api.github.com/users/diffblue/gists{/gist_id}","starred_url":"https://api.github.com/users/diffblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diffblue/subscriptions","organizations_url":"https://api.github.com/users/diffblue/orgs","repos_url":"https://api.github.com/users/diffblue/repos","events_url":"https://api.github.com/users/diffblue/events{/privacy}","received_events_url":"https://api.github.com/users/diffblue/received_events","type":"Organization","site_admin":false},"repo":{"id":51877056,"name":"cbmc","full_name":"diffblue/cbmc","owner":{"login":"diffblue","id":17216098,"avatar_url":"https://avatars0.githubusercontent.com/u/17216098?v=4","gravatar_id":"","url":"https://api.github.com/users/diffblue","html_url":"https://github.com/diffblue","followers_url":"https://api.github.com/users/diffblue/followers","following_url":"https://api.github.com/users/diffblue/following{/other_user}","gists_url":"https://api.github.com/users/diffblue/gists{/gist_id}","starred_url":"https://api.github.com/users/diffblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diffblue/subscriptions","organizations_url":"https://api.github.com/users/diffblue/orgs","repos_url":"https://api.github.com/users/diffblue/repos","events_url":"https://api.github.com/users/diffblue/events{/privacy}","received_events_url":"https://api.github.com/users/diffblue/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/diffblue/cbmc","description":"C Bounded Model Checker","fork":false,"url":"https://api.github.com/repos/diffblue/cbmc","forks_url":"https://api.github.com/repos/diffblue/cbmc/forks","keys_url":"https://api.github.com/repos/diffblue/cbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/diffblue/cbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/diffblue/cbmc/teams","hooks_url":"https://api.github.com/repos/diffblue/cbmc/hooks","issue_events_url":"https://api.github.com/repos/diffblue/cbmc/issues/events{/number}","events_url":"https://api.github.com/repos/diffblue/cbmc/events","assignees_url":"https://api.github.com/repos/diffblue/cbmc/assignees{/user}","branches_url":"https://api.github.com/repos/diffblue/cbmc/branches{/branch}","tags_url":"https://api.github.com/repos/diffblue/cbmc/tags","blobs_url":"https://api.github.com/repos/diffblue/cbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/diffblue/cbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/diffblue/cbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/diffblue/cbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/diffblue/cbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/diffblue/cbmc/languages","stargazers_url":"https://api.github.com/repos/diffblue/cbmc/stargazers","contributors_url":"https://api.github.com/repos/diffblue/cbmc/contributors","subscribers_url":"https://api.github.com/repos/diffblue/cbmc/subscribers","subscription_url":"https://api.github.com/repos/diffblue/cbmc/subscription","commits_url":"https://api.github.com/repos/diffblue/cbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/diffblue/cbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/diffblue/cbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/diffblue/cbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/diffblue/cbmc/contents/{+path}","compare_url":"https://api.github.com/repos/diffblue/cbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/diffblue/cbmc/merges","archive_url":"https://api.github.com/repos/diffblue/cbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/diffblue/cbmc/downloads","issues_url":"https://api.github.com/repos/diffblue/cbmc/issues{/number}","pulls_url":"https://api.github.com/repos/diffblue/cbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/diffblue/cbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/diffblue/cbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/diffblue/cbmc/labels{/name}","releases_url":"https://api.github.com/repos/diffblue/cbmc/releases{/id}","deployments_url":"https://api.github.com/repos/diffblue/cbmc/deployments","created_at":"2016-02-16T23:03:52Z","updated_at":"2017-10-21T10:30:34Z","pushed_at":"2017-10-23T11:25:48Z","git_url":"git://github.com/diffblue/cbmc.git","ssh_url":"git@github.com:diffblue/cbmc.git","clone_url":"https://github.com/diffblue/cbmc.git","svn_url":"https://github.com/diffblue/cbmc","homepage":"http://www.cprover.org/cbmc","size":25630,"stargazers_count":77,"watchers_count":77,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":74,"mirror_url":null,"archived":false,"open_issues_count":261,"forks":74,"open_issues":261,"watchers":77,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/diffblue/cbmc/pulls/1503"},"html":{"href":"https://github.com/diffblue/cbmc/pull/1503"},"issue":{"href":"https://api.github.com/repos/diffblue/cbmc/issues/1503"},"comments":{"href":"https://api.github.com/repos/diffblue/cbmc/issues/1503/comments"},"review_comments":{"href":"https://api.github.com/repos/diffblue/cbmc/pulls/1503/comments"},"review_comment":{"href":"https://api.github.com/repos/diffblue/cbmc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/diffblue/cbmc/pulls/1503/commits"},"statuses":{"href":"https://api.github.com/repos/diffblue/cbmc/statuses/771186f004df54fa7c344ebe016c6aa13e0769f4"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"chrisr-diffblue"}}