{"action":"reopened","number":523,"pull_request":{"url":"https://api.github.com/repos/riganti/dotvvm/pulls/523","id":159397764,"html_url":"https://github.com/riganti/dotvvm/pull/523","diff_url":"https://github.com/riganti/dotvvm/pull/523.diff","patch_url":"https://github.com/riganti/dotvvm/pull/523.patch","issue_url":"https://api.github.com/repos/riganti/dotvvm/issues/523","number":523,"state":"open","locked":false,"title":"Fixed generation of url with optional parameter and without default value","user":{"login":"adamjez","id":656406,"avatar_url":"https://avatars3.githubusercontent.com/u/656406?v=4","gravatar_id":"","url":"https://api.github.com/users/adamjez","html_url":"https://github.com/adamjez","followers_url":"https://api.github.com/users/adamjez/followers","following_url":"https://api.github.com/users/adamjez/following{/other_user}","gists_url":"https://api.github.com/users/adamjez/gists{/gist_id}","starred_url":"https://api.github.com/users/adamjez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamjez/subscriptions","organizations_url":"https://api.github.com/users/adamjez/orgs","repos_url":"https://api.github.com/users/adamjez/repos","events_url":"https://api.github.com/users/adamjez/events{/privacy}","received_events_url":"https://api.github.com/users/adamjez/received_events","type":"User","site_admin":false},"body":"**Fixed bug in generating url and added UI tests**.\r\n\r\nCurrently there is a **bug** with generating url with optional parameter and without specifying default values\r\n(client side rendering)\r\n\r\ne.g. Url `ControlSamples/Repeater/RouteLink/{Id?}` generates `/ControlSamples/Repeater/RouteLink/%7BId?}`\r\n\r\nThere is still different behavior when rendering at client/server side:\r\n* client: `ControlSamples/Repeater/RouteLink/`\r\n* server: `ControlSamples/Repeater/RouteLink`","created_at":"2017-12-20T11:51:23Z","updated_at":"2017-12-27T13:37:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e08f6506f85ff5ffd3d859530fe7c2c6c921297e","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/riganti/dotvvm/pulls/523/commits","review_comments_url":"https://api.github.com/repos/riganti/dotvvm/pulls/523/comments","review_comment_url":"https://api.github.com/repos/riganti/dotvvm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/riganti/dotvvm/issues/523/comments","statuses_url":"https://api.github.com/repos/riganti/dotvvm/statuses/e4b9bd3704dcf5d089bd3c42a65cfb1de68af747","head":{"label":"adamjez:fix/optional-param-url-builder","ref":"fix/optional-param-url-builder","sha":"e4b9bd3704dcf5d089bd3c42a65cfb1de68af747","user":{"login":"adamjez","id":656406,"avatar_url":"https://avatars3.githubusercontent.com/u/656406?v=4","gravatar_id":"","url":"https://api.github.com/users/adamjez","html_url":"https://github.com/adamjez","followers_url":"https://api.github.com/users/adamjez/followers","following_url":"https://api.github.com/users/adamjez/following{/other_user}","gists_url":"https://api.github.com/users/adamjez/gists{/gist_id}","starred_url":"https://api.github.com/users/adamjez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamjez/subscriptions","organizations_url":"https://api.github.com/users/adamjez/orgs","repos_url":"https://api.github.com/users/adamjez/repos","events_url":"https://api.github.com/users/adamjez/events{/privacy}","received_events_url":"https://api.github.com/users/adamjez/received_events","type":"User","site_admin":false},"repo":{"id":39081705,"name":"dotvvm","full_name":"adamjez/dotvvm","owner":{"login":"adamjez","id":656406,"avatar_url":"https://avatars3.githubusercontent.com/u/656406?v=4","gravatar_id":"","url":"https://api.github.com/users/adamjez","html_url":"https://github.com/adamjez","followers_url":"https://api.github.com/users/adamjez/followers","following_url":"https://api.github.com/users/adamjez/following{/other_user}","gists_url":"https://api.github.com/users/adamjez/gists{/gist_id}","starred_url":"https://api.github.com/users/adamjez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamjez/subscriptions","organizations_url":"https://api.github.com/users/adamjez/orgs","repos_url":"https://api.github.com/users/adamjez/repos","events_url":"https://api.github.com/users/adamjez/events{/privacy}","received_events_url":"https://api.github.com/users/adamjez/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adamjez/dotvvm","description":"ASP.NET MVVM Framework","fork":true,"url":"https://api.github.com/repos/adamjez/dotvvm","forks_url":"https://api.github.com/repos/adamjez/dotvvm/forks","keys_url":"https://api.github.com/repos/adamjez/dotvvm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adamjez/dotvvm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adamjez/dotvvm/teams","hooks_url":"https://api.github.com/repos/adamjez/dotvvm/hooks","issue_events_url":"https://api.github.com/repos/adamjez/dotvvm/issues/events{/number}","events_url":"https://api.github.com/repos/adamjez/dotvvm/events","assignees_url":"https://api.github.com/repos/adamjez/dotvvm/assignees{/user}","branches_url":"https://api.github.com/repos/adamjez/dotvvm/branches{/branch}","tags_url":"https://api.github.com/repos/adamjez/dotvvm/tags","blobs_url":"https://api.github.com/repos/adamjez/dotvvm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adamjez/dotvvm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adamjez/dotvvm/git/refs{/sha}","trees_url":"https://api.github.com/repos/adamjez/dotvvm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adamjez/dotvvm/statuses/{sha}","languages_url":"https://api.github.com/repos/adamjez/dotvvm/languages","stargazers_url":"https://api.github.com/repos/adamjez/dotvvm/stargazers","contributors_url":"https://api.github.com/repos/adamjez/dotvvm/contributors","subscribers_url":"https://api.github.com/repos/adamjez/dotvvm/subscribers","subscription_url":"https://api.github.com/repos/adamjez/dotvvm/subscription","commits_url":"https://api.github.com/repos/adamjez/dotvvm/commits{/sha}","git_commits_url":"https://api.github.com/repos/adamjez/dotvvm/git/commits{/sha}","comments_url":"https://api.github.com/repos/adamjez/dotvvm/comments{/number}","issue_comment_url":"https://api.github.com/repos/adamjez/dotvvm/issues/comments{/number}","contents_url":"https://api.github.com/repos/adamjez/dotvvm/contents/{+path}","compare_url":"https://api.github.com/repos/adamjez/dotvvm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adamjez/dotvvm/merges","archive_url":"https://api.github.com/repos/adamjez/dotvvm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adamjez/dotvvm/downloads","issues_url":"https://api.github.com/repos/adamjez/dotvvm/issues{/number}","pulls_url":"https://api.github.com/repos/adamjez/dotvvm/pulls{/number}","milestones_url":"https://api.github.com/repos/adamjez/dotvvm/milestones{/number}","notifications_url":"https://api.github.com/repos/adamjez/dotvvm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adamjez/dotvvm/labels{/name}","releases_url":"https://api.github.com/repos/adamjez/dotvvm/releases{/id}","deployments_url":"https://api.github.com/repos/adamjez/dotvvm/deployments","created_at":"2015-07-14T15:00:59Z","updated_at":"2017-07-19T20:46:12Z","pushed_at":"2017-12-27T11:05:27Z","git_url":"git://github.com/adamjez/dotvvm.git","ssh_url":"git@github.com:adamjez/dotvvm.git","clone_url":"https://github.com/adamjez/dotvvm.git","svn_url":"https://github.com/adamjez/dotvvm","homepage":null,"size":24720,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"riganti:master","ref":"master","sha":"60feace279afb3e27f402b3522f9353dd8b461ae","user":{"login":"riganti","id":9575026,"avatar_url":"https://avatars0.githubusercontent.com/u/9575026?v=4","gravatar_id":"","url":"https://api.github.com/users/riganti","html_url":"https://github.com/riganti","followers_url":"https://api.github.com/users/riganti/followers","following_url":"https://api.github.com/users/riganti/following{/other_user}","gists_url":"https://api.github.com/users/riganti/gists{/gist_id}","starred_url":"https://api.github.com/users/riganti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riganti/subscriptions","organizations_url":"https://api.github.com/users/riganti/orgs","repos_url":"https://api.github.com/users/riganti/repos","events_url":"https://api.github.com/users/riganti/events{/privacy}","received_events_url":"https://api.github.com/users/riganti/received_events","type":"Organization","site_admin":false},"repo":{"id":26230481,"name":"dotvvm","full_name":"riganti/dotvvm","owner":{"login":"riganti","id":9575026,"avatar_url":"https://avatars0.githubusercontent.com/u/9575026?v=4","gravatar_id":"","url":"https://api.github.com/users/riganti","html_url":"https://github.com/riganti","followers_url":"https://api.github.com/users/riganti/followers","following_url":"https://api.github.com/users/riganti/following{/other_user}","gists_url":"https://api.github.com/users/riganti/gists{/gist_id}","starred_url":"https://api.github.com/users/riganti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riganti/subscriptions","organizations_url":"https://api.github.com/users/riganti/orgs","repos_url":"https://api.github.com/users/riganti/repos","events_url":"https://api.github.com/users/riganti/events{/privacy}","received_events_url":"https://api.github.com/users/riganti/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/riganti/dotvvm","description":"Open source MVVM framework for Web Apps","fork":false,"url":"https://api.github.com/repos/riganti/dotvvm","forks_url":"https://api.github.com/repos/riganti/dotvvm/forks","keys_url":"https://api.github.com/repos/riganti/dotvvm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/riganti/dotvvm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/riganti/dotvvm/teams","hooks_url":"https://api.github.com/repos/riganti/dotvvm/hooks","issue_events_url":"https://api.github.com/repos/riganti/dotvvm/issues/events{/number}","events_url":"https://api.github.com/repos/riganti/dotvvm/events","assignees_url":"https://api.github.com/repos/riganti/dotvvm/assignees{/user}","branches_url":"https://api.github.com/repos/riganti/dotvvm/branches{/branch}","tags_url":"https://api.github.com/repos/riganti/dotvvm/tags","blobs_url":"https://api.github.com/repos/riganti/dotvvm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/riganti/dotvvm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/riganti/dotvvm/git/refs{/sha}","trees_url":"https://api.github.com/repos/riganti/dotvvm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/riganti/dotvvm/statuses/{sha}","languages_url":"https://api.github.com/repos/riganti/dotvvm/languages","stargazers_url":"https://api.github.com/repos/riganti/dotvvm/stargazers","contributors_url":"https://api.github.com/repos/riganti/dotvvm/contributors","subscribers_url":"https://api.github.com/repos/riganti/dotvvm/subscribers","subscription_url":"https://api.github.com/repos/riganti/dotvvm/subscription","commits_url":"https://api.github.com/repos/riganti/dotvvm/commits{/sha}","git_commits_url":"https://api.github.com/repos/riganti/dotvvm/git/commits{/sha}","comments_url":"https://api.github.com/repos/riganti/dotvvm/comments{/number}","issue_comment_url":"https://api.github.com/repos/riganti/dotvvm/issues/comments{/number}","contents_url":"https://api.github.com/repos/riganti/dotvvm/contents/{+path}","compare_url":"https://api.github.com/repos/riganti/dotvvm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/riganti/dotvvm/merges","archive_url":"https://api.github.com/repos/riganti/dotvvm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/riganti/dotvvm/downloads","issues_url":"https://api.github.com/repos/riganti/dotvvm/issues{/number}","pulls_url":"https://api.github.com/repos/riganti/dotvvm/pulls{/number}","milestones_url":"https://api.github.com/repos/riganti/dotvvm/milestones{/number}","notifications_url":"https://api.github.com/repos/riganti/dotvvm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/riganti/dotvvm/labels{/name}","releases_url":"https://api.github.com/repos/riganti/dotvvm/releases{/id}","deployments_url":"https://api.github.com/repos/riganti/dotvvm/deployments","created_at":"2014-11-05T17:14:34Z","updated_at":"2017-12-25T10:13:57Z","pushed_at":"2017-12-27T13:21:08Z","git_url":"git://github.com/riganti/dotvvm.git","ssh_url":"git@github.com:riganti/dotvvm.git","clone_url":"https://github.com/riganti/dotvvm.git","svn_url":"https://github.com/riganti/dotvvm","homepage":"https://www.dotvvm.com","size":20035,"stargazers_count":209,"watchers_count":209,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":54,"mirror_url":null,"archived":false,"open_issues_count":97,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":54,"open_issues":97,"watchers":209,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/riganti/dotvvm/pulls/523"},"html":{"href":"https://github.com/riganti/dotvvm/pull/523"},"issue":{"href":"https://api.github.com/repos/riganti/dotvvm/issues/523"},"comments":{"href":"https://api.github.com/repos/riganti/dotvvm/issues/523/comments"},"review_comments":{"href":"https://api.github.com/repos/riganti/dotvvm/pulls/523/comments"},"review_comment":{"href":"https://api.github.com/repos/riganti/dotvvm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/riganti/dotvvm/pulls/523/commits"},"statuses":{"href":"https://api.github.com/repos/riganti/dotvvm/statuses/e4b9bd3704dcf5d089bd3c42a65cfb1de68af747"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":4,"review_comments":0,"maintainer_can_modify":true,"commits":5,"additions":136,"deletions":30,"changed_files":10}}
{"actor":{"display_login":"exyi"}}