{"action":"created","comment":{"url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/comments/121091536","pull_request_review_id":43114713,"id":121091536,"diff_hunk":"@@ -15,8 +15,6 @@\n \talong with cpp-ethereum.  If not, see <http://www.gnu.org/licenses/>.\n */\n /** @file VM.cpp","path":"libevm/VM.cpp","position":3,"original_position":3,"commit_id":"892d96ac9dad2508099db8febe7dc6ba94030f63","original_commit_id":"892d96ac9dad2508099db8febe7dc6ba94030f63","user":{"login":"chfast","id":573380,"avatar_url":"https://avatars2.githubusercontent.com/u/573380?v=3","gravatar_id":"","url":"https://api.github.com/users/chfast","html_url":"https://github.com/chfast","followers_url":"https://api.github.com/users/chfast/followers","following_url":"https://api.github.com/users/chfast/following{/other_user}","gists_url":"https://api.github.com/users/chfast/gists{/gist_id}","starred_url":"https://api.github.com/users/chfast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chfast/subscriptions","organizations_url":"https://api.github.com/users/chfast/orgs","repos_url":"https://api.github.com/users/chfast/repos","events_url":"https://api.github.com/users/chfast/events{/privacy}","received_events_url":"https://api.github.com/users/chfast/received_events","type":"User","site_admin":false},"body":"Remove the full comment section.","created_at":"2017-06-09T09:58:57Z","updated_at":"2017-06-09T10:03:01Z","html_url":"https://github.com/ethereum/cpp-ethereum/pull/4106#discussion_r121091536","pull_request_url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/4106","_links":{"self":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/comments/121091536"},"html":{"href":"https://github.com/ethereum/cpp-ethereum/pull/4106#discussion_r121091536"},"pull_request":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/4106"}}},"pull_request":{"url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/4106","id":123648308,"html_url":"https://github.com/ethereum/cpp-ethereum/pull/4106","diff_url":"https://github.com/ethereum/cpp-ethereum/pull/4106.diff","patch_url":"https://github.com/ethereum/cpp-ethereum/pull/4106.patch","issue_url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/4106","number":4106,"state":"open","locked":false,"title":"reimplement const pool and reenable const jumps and jump dispatch opt.","user":{"login":"gcolvin","id":16827129,"avatar_url":"https://avatars2.githubusercontent.com/u/16827129?v=3","gravatar_id":"","url":"https://api.github.com/users/gcolvin","html_url":"https://github.com/gcolvin","followers_url":"https://api.github.com/users/gcolvin/followers","following_url":"https://api.github.com/users/gcolvin/following{/other_user}","gists_url":"https://api.github.com/users/gcolvin/gists{/gist_id}","starred_url":"https://api.github.com/users/gcolvin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gcolvin/subscriptions","organizations_url":"https://api.github.com/users/gcolvin/orgs","repos_url":"https://api.github.com/users/gcolvin/repos","events_url":"https://api.github.com/users/gcolvin/events{/privacy}","received_events_url":"https://api.github.com/users/gcolvin/received_events","type":"User","site_admin":false},"body":"With a maximum size on code the constant pool can now be a vector of all constants, quickly constructed and not exploitable at runtime - unlike the previous small table and hash table.  Also turned back on the other optimizations, and added new opcodes to the dispatch table and debugged it.","created_at":"2017-06-02T06:11:35Z","updated_at":"2017-06-09T10:03:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1be59fcf547324f5870122412b0e6953123f256d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"chriseth","id":9073706,"avatar_url":"https://avatars1.githubusercontent.com/u/9073706?v=3","gravatar_id":"","url":"https://api.github.com/users/chriseth","html_url":"https://github.com/chriseth","followers_url":"https://api.github.com/users/chriseth/followers","following_url":"https://api.github.com/users/chriseth/following{/other_user}","gists_url":"https://api.github.com/users/chriseth/gists{/gist_id}","starred_url":"https://api.github.com/users/chriseth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chriseth/subscriptions","organizations_url":"https://api.github.com/users/chriseth/orgs","repos_url":"https://api.github.com/users/chriseth/repos","events_url":"https://api.github.com/users/chriseth/events{/privacy}","received_events_url":"https://api.github.com/users/chriseth/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/4106/commits","review_comments_url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/4106/comments","review_comment_url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/4106/comments","statuses_url":"https://api.github.com/repos/ethereum/cpp-ethereum/statuses/892d96ac9dad2508099db8febe7dc6ba94030f63","head":{"label":"gcolvin:enable-ops","ref":"enable-ops","sha":"892d96ac9dad2508099db8febe7dc6ba94030f63","user":{"login":"gcolvin","id":16827129,"avatar_url":"https://avatars2.githubusercontent.com/u/16827129?v=3","gravatar_id":"","url":"https://api.github.com/users/gcolvin","html_url":"https://github.com/gcolvin","followers_url":"https://api.github.com/users/gcolvin/followers","following_url":"https://api.github.com/users/gcolvin/following{/other_user}","gists_url":"https://api.github.com/users/gcolvin/gists{/gist_id}","starred_url":"https://api.github.com/users/gcolvin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gcolvin/subscriptions","organizations_url":"https://api.github.com/users/gcolvin/orgs","repos_url":"https://api.github.com/users/gcolvin/repos","events_url":"https://api.github.com/users/gcolvin/events{/privacy}","received_events_url":"https://api.github.com/users/gcolvin/received_events","type":"User","site_admin":false},"repo":{"id":92106216,"name":"cpp-ethereum","full_name":"gcolvin/cpp-ethereum","owner":{"login":"gcolvin","id":16827129,"avatar_url":"https://avatars2.githubusercontent.com/u/16827129?v=3","gravatar_id":"","url":"https://api.github.com/users/gcolvin","html_url":"https://github.com/gcolvin","followers_url":"https://api.github.com/users/gcolvin/followers","following_url":"https://api.github.com/users/gcolvin/following{/other_user}","gists_url":"https://api.github.com/users/gcolvin/gists{/gist_id}","starred_url":"https://api.github.com/users/gcolvin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gcolvin/subscriptions","organizations_url":"https://api.github.com/users/gcolvin/orgs","repos_url":"https://api.github.com/users/gcolvin/repos","events_url":"https://api.github.com/users/gcolvin/events{/privacy}","received_events_url":"https://api.github.com/users/gcolvin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gcolvin/cpp-ethereum","description":"Ethereum C++ client","fork":true,"url":"https://api.github.com/repos/gcolvin/cpp-ethereum","forks_url":"https://api.github.com/repos/gcolvin/cpp-ethereum/forks","keys_url":"https://api.github.com/repos/gcolvin/cpp-ethereum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gcolvin/cpp-ethereum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gcolvin/cpp-ethereum/teams","hooks_url":"https://api.github.com/repos/gcolvin/cpp-ethereum/hooks","issue_events_url":"https://api.github.com/repos/gcolvin/cpp-ethereum/issues/events{/number}","events_url":"https://api.github.com/repos/gcolvin/cpp-ethereum/events","assignees_url":"https://api.github.com/repos/gcolvin/cpp-ethereum/assignees{/user}","branches_url":"https://api.github.com/repos/gcolvin/cpp-ethereum/branches{/branch}","tags_url":"https://api.github.com/repos/gcolvin/cpp-ethereum/tags","blobs_url":"https://api.github.com/repos/gcolvin/cpp-ethereum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gcolvin/cpp-ethereum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gcolvin/cpp-ethereum/git/refs{/sha}","trees_url":"https://api.github.com/repos/gcolvin/cpp-ethereum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gcolvin/cpp-ethereum/statuses/{sha}","languages_url":"https://api.github.com/repos/gcolvin/cpp-ethereum/languages","stargazers_url":"https://api.github.com/repos/gcolvin/cpp-ethereum/stargazers","contributors_url":"https://api.github.com/repos/gcolvin/cpp-ethereum/contributors","subscribers_url":"https://api.github.com/repos/gcolvin/cpp-ethereum/subscribers","subscription_url":"https://api.github.com/repos/gcolvin/cpp-ethereum/subscription","commits_url":"https://api.github.com/repos/gcolvin/cpp-ethereum/commits{/sha}","git_commits_url":"https://api.github.com/repos/gcolvin/cpp-ethereum/git/commits{/sha}","comments_url":"https://api.github.com/repos/gcolvin/cpp-ethereum/comments{/number}","issue_comment_url":"https://api.github.com/repos/gcolvin/cpp-ethereum/issues/comments{/number}","contents_url":"https://api.github.com/repos/gcolvin/cpp-ethereum/contents/{+path}","compare_url":"https://api.github.com/repos/gcolvin/cpp-ethereum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gcolvin/cpp-ethereum/merges","archive_url":"https://api.github.com/repos/gcolvin/cpp-ethereum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gcolvin/cpp-ethereum/downloads","issues_url":"https://api.github.com/repos/gcolvin/cpp-ethereum/issues{/number}","pulls_url":"https://api.github.com/repos/gcolvin/cpp-ethereum/pulls{/number}","milestones_url":"https://api.github.com/repos/gcolvin/cpp-ethereum/milestones{/number}","notifications_url":"https://api.github.com/repos/gcolvin/cpp-ethereum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gcolvin/cpp-ethereum/labels{/name}","releases_url":"https://api.github.com/repos/gcolvin/cpp-ethereum/releases{/id}","deployments_url":"https://api.github.com/repos/gcolvin/cpp-ethereum/deployments","created_at":"2017-05-22T22:51:54Z","updated_at":"2017-05-27T20:40:35Z","pushed_at":"2017-06-08T23:16:25Z","git_url":"git://github.com/gcolvin/cpp-ethereum.git","ssh_url":"git@github.com:gcolvin/cpp-ethereum.git","clone_url":"https://github.com/gcolvin/cpp-ethereum.git","svn_url":"https://github.com/gcolvin/cpp-ethereum","homepage":"http://cpp-ethereum.org","size":51195,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"develop"}},"base":{"label":"ethereum:develop","ref":"develop","sha":"4b555c7cf63e828cf2b6f64e3253eff8610d1288","user":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars0.githubusercontent.com/u/6250754?v=3","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":15460666,"name":"cpp-ethereum","full_name":"ethereum/cpp-ethereum","owner":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars0.githubusercontent.com/u/6250754?v=3","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethereum/cpp-ethereum","description":"Ethereum C++ client","fork":false,"url":"https://api.github.com/repos/ethereum/cpp-ethereum","forks_url":"https://api.github.com/repos/ethereum/cpp-ethereum/forks","keys_url":"https://api.github.com/repos/ethereum/cpp-ethereum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/cpp-ethereum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/cpp-ethereum/teams","hooks_url":"https://api.github.com/repos/ethereum/cpp-ethereum/hooks","issue_events_url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/cpp-ethereum/events","assignees_url":"https://api.github.com/repos/ethereum/cpp-ethereum/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/cpp-ethereum/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/cpp-ethereum/tags","blobs_url":"https://api.github.com/repos/ethereum/cpp-ethereum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/cpp-ethereum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/cpp-ethereum/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/cpp-ethereum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/cpp-ethereum/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/cpp-ethereum/languages","stargazers_url":"https://api.github.com/repos/ethereum/cpp-ethereum/stargazers","contributors_url":"https://api.github.com/repos/ethereum/cpp-ethereum/contributors","subscribers_url":"https://api.github.com/repos/ethereum/cpp-ethereum/subscribers","subscription_url":"https://api.github.com/repos/ethereum/cpp-ethereum/subscription","commits_url":"https://api.github.com/repos/ethereum/cpp-ethereum/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/cpp-ethereum/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/cpp-ethereum/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/cpp-ethereum/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/cpp-ethereum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/cpp-ethereum/merges","archive_url":"https://api.github.com/repos/ethereum/cpp-ethereum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/cpp-ethereum/downloads","issues_url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/cpp-ethereum/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/cpp-ethereum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/cpp-ethereum/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/cpp-ethereum/releases{/id}","deployments_url":"https://api.github.com/repos/ethereum/cpp-ethereum/deployments","created_at":"2013-12-26T21:26:06Z","updated_at":"2017-06-09T04:20:40Z","pushed_at":"2017-06-09T09:19:10Z","git_url":"git://github.com/ethereum/cpp-ethereum.git","ssh_url":"git@github.com:ethereum/cpp-ethereum.git","clone_url":"https://github.com/ethereum/cpp-ethereum.git","svn_url":"https://github.com/ethereum/cpp-ethereum","homepage":"http://cpp-ethereum.org","size":51241,"stargazers_count":1115,"watchers_count":1115,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":724,"mirror_url":null,"open_issues_count":245,"forks":724,"open_issues":245,"watchers":1115,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/4106"},"html":{"href":"https://github.com/ethereum/cpp-ethereum/pull/4106"},"issue":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/4106"},"comments":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/4106/comments"},"review_comments":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/4106/comments"},"review_comment":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/4106/commits"},"statuses":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/statuses/892d96ac9dad2508099db8febe7dc6ba94030f63"}}}}
{"actor":{"display_login":"chfast"}}