{"action":"created","comment":{"url":"https://api.github.com/repos/w3c/web-platform-tests/pulls/comments/99649922","pull_request_review_id":20333159,"id":99649922,"diff_hunk":"@@ -0,0 +1,77 @@\n+<!DOCTYPE HTML>\n+<head>\n+<meta charset=\"utf-8\">\n+<title>PerformanceObservers: getEntries* sort order</title>\n+<meta name=\"author\" title=\"JosephPecoraro\" href=\"mailto:joepeck@webkit.org\">\n+<meta name=\"assert\" content=\"PerformanceObserverEntryList entries are sorted correctly\">\n+<link rel=\"help\" href=\"https://w3c.github.io/performance-timeline/#filter-performance-entry-buffer-by-name-and-type\">\n+<script src=\"/resources/testharness.js\"></script>\n+<script src=\"/resources/testharnessreport.js\"></script>\n+<script src=\"performanceobservers.js\"></script>\n+</head>\n+<h1>PerformanceObservers: getEntries* sort order</h1>\n+<p>getEntries, getEntriesByType and getEntriesByName sort order</p>\n+<div id=\"log\"></div>\n+<script>\n+  async_test(function (t) {\n+    var stored_entries = [];\n+    var stored_entries_by_type = [];\n+    var observer = new PerformanceObserver(\n+        t.step_func(function (entryList, obs) {\n+\n+          stored_entries = entryList.getEntries();\n+          stored_entries_by_type = entryList.getEntriesByType(\"mark\");\n+          stored_entries_by_name = entryList.getEntriesByName(\"name-repeat\");\n+\n+          checkSorted(stored_entries);\n+          checkEntriesInOrder(stored_entries, [","path":"performance-timeline/po-entries-sort.html","position":27,"original_position":27,"commit_id":"7dd4034fbc47b2230d7870837b101e0f89f77738","original_commit_id":"7dd4034fbc47b2230d7870837b101e0f89f77738","user":{"login":"spanicker","id":4945616,"avatar_url":"https://avatars.githubusercontent.com/u/4945616?v=3","gravatar_id":"","url":"https://api.github.com/users/spanicker","html_url":"https://github.com/spanicker","followers_url":"https://api.github.com/users/spanicker/followers","following_url":"https://api.github.com/users/spanicker/following{/other_user}","gists_url":"https://api.github.com/users/spanicker/gists{/gist_id}","starred_url":"https://api.github.com/users/spanicker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spanicker/subscriptions","organizations_url":"https://api.github.com/users/spanicker/orgs","repos_url":"https://api.github.com/users/spanicker/repos","events_url":"https://api.github.com/users/spanicker/events{/privacy}","received_events_url":"https://api.github.com/users/spanicker/received_events","type":"User","site_admin":false},"body":"wouldn't checkEntries suffice here? whether the set of entries is sorted by startTime was already checked in checkSorted. In terms of ordering - ordering by startTime is the only guarantee that Performance Observer makes AFAICT.","created_at":"2017-02-06T18:24:01Z","updated_at":"2017-02-06T18:24:01Z","html_url":"https://github.com/w3c/web-platform-tests/pull/4660#discussion_r99649922","pull_request_url":"https://api.github.com/repos/w3c/web-platform-tests/pulls/4660","_links":{"self":{"href":"https://api.github.com/repos/w3c/web-platform-tests/pulls/comments/99649922"},"html":{"href":"https://github.com/w3c/web-platform-tests/pull/4660#discussion_r99649922"},"pull_request":{"href":"https://api.github.com/repos/w3c/web-platform-tests/pulls/4660"}}},"pull_request":{"url":"https://api.github.com/repos/w3c/web-platform-tests/pulls/4660","id":103857009,"html_url":"https://github.com/w3c/web-platform-tests/pull/4660","diff_url":"https://github.com/w3c/web-platform-tests/pull/4660.diff","patch_url":"https://github.com/w3c/web-platform-tests/pull/4660.patch","issue_url":"https://api.github.com/repos/w3c/web-platform-tests/issues/4660","number":4660,"state":"open","locked":false,"title":"New PerformanceObserver tests","user":{"login":"JosephPecoraro","id":11351,"avatar_url":"https://avatars.githubusercontent.com/u/11351?v=3","gravatar_id":"","url":"https://api.github.com/users/JosephPecoraro","html_url":"https://github.com/JosephPecoraro","followers_url":"https://api.github.com/users/JosephPecoraro/followers","following_url":"https://api.github.com/users/JosephPecoraro/following{/other_user}","gists_url":"https://api.github.com/users/JosephPecoraro/gists{/gist_id}","starred_url":"https://api.github.com/users/JosephPecoraro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JosephPecoraro/subscriptions","organizations_url":"https://api.github.com/users/JosephPecoraro/orgs","repos_url":"https://api.github.com/users/JosephPecoraro/repos","events_url":"https://api.github.com/users/JosephPecoraro/events{/privacy}","received_events_url":"https://api.github.com/users/JosephPecoraro/received_events","type":"User","site_admin":false},"body":"- Test sort order of entries in PerformanceObserverEntryList\r\n- Test behavior of disconnect on observer with entries in buffer\r\n- Test behavior of modifying an Observer in its callback\r\n- Test types of parameters and this value in callback","created_at":"2017-01-31T01:33:58Z","updated_at":"2017-02-06T18:24:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8deedab7996bd7ef46d379b998bb8019bd67a63b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/w3c/web-platform-tests/pulls/4660/commits","review_comments_url":"https://api.github.com/repos/w3c/web-platform-tests/pulls/4660/comments","review_comment_url":"https://api.github.com/repos/w3c/web-platform-tests/pulls/comments{/number}","comments_url":"https://api.github.com/repos/w3c/web-platform-tests/issues/4660/comments","statuses_url":"https://api.github.com/repos/w3c/web-platform-tests/statuses/7dd4034fbc47b2230d7870837b101e0f89f77738","head":{"label":"JosephPecoraro:new-performance-observer-tests","ref":"new-performance-observer-tests","sha":"7dd4034fbc47b2230d7870837b101e0f89f77738","user":{"login":"JosephPecoraro","id":11351,"avatar_url":"https://avatars.githubusercontent.com/u/11351?v=3","gravatar_id":"","url":"https://api.github.com/users/JosephPecoraro","html_url":"https://github.com/JosephPecoraro","followers_url":"https://api.github.com/users/JosephPecoraro/followers","following_url":"https://api.github.com/users/JosephPecoraro/following{/other_user}","gists_url":"https://api.github.com/users/JosephPecoraro/gists{/gist_id}","starred_url":"https://api.github.com/users/JosephPecoraro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JosephPecoraro/subscriptions","organizations_url":"https://api.github.com/users/JosephPecoraro/orgs","repos_url":"https://api.github.com/users/JosephPecoraro/repos","events_url":"https://api.github.com/users/JosephPecoraro/events{/privacy}","received_events_url":"https://api.github.com/users/JosephPecoraro/received_events","type":"User","site_admin":false},"repo":{"id":80082619,"name":"web-platform-tests","full_name":"JosephPecoraro/web-platform-tests","owner":{"login":"JosephPecoraro","id":11351,"avatar_url":"https://avatars.githubusercontent.com/u/11351?v=3","gravatar_id":"","url":"https://api.github.com/users/JosephPecoraro","html_url":"https://github.com/JosephPecoraro","followers_url":"https://api.github.com/users/JosephPecoraro/followers","following_url":"https://api.github.com/users/JosephPecoraro/following{/other_user}","gists_url":"https://api.github.com/users/JosephPecoraro/gists{/gist_id}","starred_url":"https://api.github.com/users/JosephPecoraro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JosephPecoraro/subscriptions","organizations_url":"https://api.github.com/users/JosephPecoraro/orgs","repos_url":"https://api.github.com/users/JosephPecoraro/repos","events_url":"https://api.github.com/users/JosephPecoraro/events{/privacy}","received_events_url":"https://api.github.com/users/JosephPecoraro/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JosephPecoraro/web-platform-tests","description":"Test Suites for Web Platform specifications—including WHATWG, W3C and others","fork":true,"url":"https://api.github.com/repos/JosephPecoraro/web-platform-tests","forks_url":"https://api.github.com/repos/JosephPecoraro/web-platform-tests/forks","keys_url":"https://api.github.com/repos/JosephPecoraro/web-platform-tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JosephPecoraro/web-platform-tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JosephPecoraro/web-platform-tests/teams","hooks_url":"https://api.github.com/repos/JosephPecoraro/web-platform-tests/hooks","issue_events_url":"https://api.github.com/repos/JosephPecoraro/web-platform-tests/issues/events{/number}","events_url":"https://api.github.com/repos/JosephPecoraro/web-platform-tests/events","assignees_url":"https://api.github.com/repos/JosephPecoraro/web-platform-tests/assignees{/user}","branches_url":"https://api.github.com/repos/JosephPecoraro/web-platform-tests/branches{/branch}","tags_url":"https://api.github.com/repos/JosephPecoraro/web-platform-tests/tags","blobs_url":"https://api.github.com/repos/JosephPecoraro/web-platform-tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JosephPecoraro/web-platform-tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JosephPecoraro/web-platform-tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/JosephPecoraro/web-platform-tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JosephPecoraro/web-platform-tests/statuses/{sha}","languages_url":"https://api.github.com/repos/JosephPecoraro/web-platform-tests/languages","stargazers_url":"https://api.github.com/repos/JosephPecoraro/web-platform-tests/stargazers","contributors_url":"https://api.github.com/repos/JosephPecoraro/web-platform-tests/contributors","subscribers_url":"https://api.github.com/repos/JosephPecoraro/web-platform-tests/subscribers","subscription_url":"https://api.github.com/repos/JosephPecoraro/web-platform-tests/subscription","commits_url":"https://api.github.com/repos/JosephPecoraro/web-platform-tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/JosephPecoraro/web-platform-tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/JosephPecoraro/web-platform-tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/JosephPecoraro/web-platform-tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/JosephPecoraro/web-platform-tests/contents/{+path}","compare_url":"https://api.github.com/repos/JosephPecoraro/web-platform-tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JosephPecoraro/web-platform-tests/merges","archive_url":"https://api.github.com/repos/JosephPecoraro/web-platform-tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JosephPecoraro/web-platform-tests/downloads","issues_url":"https://api.github.com/repos/JosephPecoraro/web-platform-tests/issues{/number}","pulls_url":"https://api.github.com/repos/JosephPecoraro/web-platform-tests/pulls{/number}","milestones_url":"https://api.github.com/repos/JosephPecoraro/web-platform-tests/milestones{/number}","notifications_url":"https://api.github.com/repos/JosephPecoraro/web-platform-tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JosephPecoraro/web-platform-tests/labels{/name}","releases_url":"https://api.github.com/repos/JosephPecoraro/web-platform-tests/releases{/id}","deployments_url":"https://api.github.com/repos/JosephPecoraro/web-platform-tests/deployments","created_at":"2017-01-26T03:26:13Z","updated_at":"2017-01-26T03:26:44Z","pushed_at":"2017-02-03T23:36:26Z","git_url":"git://github.com/JosephPecoraro/web-platform-tests.git","ssh_url":"git@github.com:JosephPecoraro/web-platform-tests.git","clone_url":"https://github.com/JosephPecoraro/web-platform-tests.git","svn_url":"https://github.com/JosephPecoraro/web-platform-tests","homepage":"http://irc.w3.org/?channels=testing","size":170292,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"w3c:master","ref":"master","sha":"6d8f461eb1d2e5b26ba7f08e8d21906d54440306","user":{"login":"w3c","id":379216,"avatar_url":"https://avatars.githubusercontent.com/u/379216?v=3","gravatar_id":"","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"repo":{"id":3618133,"name":"web-platform-tests","full_name":"w3c/web-platform-tests","owner":{"login":"w3c","id":379216,"avatar_url":"https://avatars.githubusercontent.com/u/379216?v=3","gravatar_id":"","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/w3c/web-platform-tests","description":"Test Suites for Web Platform specifications—including WHATWG, W3C and others","fork":false,"url":"https://api.github.com/repos/w3c/web-platform-tests","forks_url":"https://api.github.com/repos/w3c/web-platform-tests/forks","keys_url":"https://api.github.com/repos/w3c/web-platform-tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/w3c/web-platform-tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/w3c/web-platform-tests/teams","hooks_url":"https://api.github.com/repos/w3c/web-platform-tests/hooks","issue_events_url":"https://api.github.com/repos/w3c/web-platform-tests/issues/events{/number}","events_url":"https://api.github.com/repos/w3c/web-platform-tests/events","assignees_url":"https://api.github.com/repos/w3c/web-platform-tests/assignees{/user}","branches_url":"https://api.github.com/repos/w3c/web-platform-tests/branches{/branch}","tags_url":"https://api.github.com/repos/w3c/web-platform-tests/tags","blobs_url":"https://api.github.com/repos/w3c/web-platform-tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/w3c/web-platform-tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/w3c/web-platform-tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/w3c/web-platform-tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/w3c/web-platform-tests/statuses/{sha}","languages_url":"https://api.github.com/repos/w3c/web-platform-tests/languages","stargazers_url":"https://api.github.com/repos/w3c/web-platform-tests/stargazers","contributors_url":"https://api.github.com/repos/w3c/web-platform-tests/contributors","subscribers_url":"https://api.github.com/repos/w3c/web-platform-tests/subscribers","subscription_url":"https://api.github.com/repos/w3c/web-platform-tests/subscription","commits_url":"https://api.github.com/repos/w3c/web-platform-tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/w3c/web-platform-tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/w3c/web-platform-tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/w3c/web-platform-tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/w3c/web-platform-tests/contents/{+path}","compare_url":"https://api.github.com/repos/w3c/web-platform-tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/w3c/web-platform-tests/merges","archive_url":"https://api.github.com/repos/w3c/web-platform-tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/w3c/web-platform-tests/downloads","issues_url":"https://api.github.com/repos/w3c/web-platform-tests/issues{/number}","pulls_url":"https://api.github.com/repos/w3c/web-platform-tests/pulls{/number}","milestones_url":"https://api.github.com/repos/w3c/web-platform-tests/milestones{/number}","notifications_url":"https://api.github.com/repos/w3c/web-platform-tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/w3c/web-platform-tests/labels{/name}","releases_url":"https://api.github.com/repos/w3c/web-platform-tests/releases{/id}","deployments_url":"https://api.github.com/repos/w3c/web-platform-tests/deployments","created_at":"2012-03-04T12:58:11Z","updated_at":"2017-02-06T17:31:05Z","pushed_at":"2017-02-06T18:23:27Z","git_url":"git://github.com/w3c/web-platform-tests.git","ssh_url":"git@github.com:w3c/web-platform-tests.git","clone_url":"https://github.com/w3c/web-platform-tests.git","svn_url":"https://github.com/w3c/web-platform-tests","homepage":"http://irc.w3.org/?channels=testing","size":170998,"stargazers_count":950,"watchers_count":950,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1026,"mirror_url":null,"open_issues_count":461,"forks":1026,"open_issues":461,"watchers":950,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/w3c/web-platform-tests/pulls/4660"},"html":{"href":"https://github.com/w3c/web-platform-tests/pull/4660"},"issue":{"href":"https://api.github.com/repos/w3c/web-platform-tests/issues/4660"},"comments":{"href":"https://api.github.com/repos/w3c/web-platform-tests/issues/4660/comments"},"review_comments":{"href":"https://api.github.com/repos/w3c/web-platform-tests/pulls/4660/comments"},"review_comment":{"href":"https://api.github.com/repos/w3c/web-platform-tests/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/w3c/web-platform-tests/pulls/4660/commits"},"statuses":{"href":"https://api.github.com/repos/w3c/web-platform-tests/statuses/7dd4034fbc47b2230d7870837b101e0f89f77738"}}}}
{"actor":{"display_login":"spanicker"}}