{"action":"created","issue":{"url":"https://api.github.com/repos/dashbase/jaeger/issues/2","repository_url":"https://api.github.com/repos/dashbase/jaeger","labels_url":"https://api.github.com/repos/dashbase/jaeger/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/dashbase/jaeger/issues/2/comments","events_url":"https://api.github.com/repos/dashbase/jaeger/issues/2/events","html_url":"https://github.com/dashbase/jaeger/pull/2","id":278778085,"number":2,"title":"Build docker image","user":{"login":"PureWhiteWu","id":3314335,"avatar_url":"https://avatars3.githubusercontent.com/u/3314335?v=4","gravatar_id":"","url":"https://api.github.com/users/PureWhiteWu","html_url":"https://github.com/PureWhiteWu","followers_url":"https://api.github.com/users/PureWhiteWu/followers","following_url":"https://api.github.com/users/PureWhiteWu/following{/other_user}","gists_url":"https://api.github.com/users/PureWhiteWu/gists{/gist_id}","starred_url":"https://api.github.com/users/PureWhiteWu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PureWhiteWu/subscriptions","organizations_url":"https://api.github.com/users/PureWhiteWu/orgs","repos_url":"https://api.github.com/users/PureWhiteWu/repos","events_url":"https://api.github.com/users/PureWhiteWu/events{/privacy}","received_events_url":"https://api.github.com/users/PureWhiteWu/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"PureWhiteWu","id":3314335,"avatar_url":"https://avatars3.githubusercontent.com/u/3314335?v=4","gravatar_id":"","url":"https://api.github.com/users/PureWhiteWu","html_url":"https://github.com/PureWhiteWu","followers_url":"https://api.github.com/users/PureWhiteWu/followers","following_url":"https://api.github.com/users/PureWhiteWu/following{/other_user}","gists_url":"https://api.github.com/users/PureWhiteWu/gists{/gist_id}","starred_url":"https://api.github.com/users/PureWhiteWu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PureWhiteWu/subscriptions","organizations_url":"https://api.github.com/users/PureWhiteWu/orgs","repos_url":"https://api.github.com/users/PureWhiteWu/repos","events_url":"https://api.github.com/users/PureWhiteWu/events{/privacy}","received_events_url":"https://api.github.com/users/PureWhiteWu/received_events","type":"User","site_admin":false},"assignees":[{"login":"PureWhiteWu","id":3314335,"avatar_url":"https://avatars3.githubusercontent.com/u/3314335?v=4","gravatar_id":"","url":"https://api.github.com/users/PureWhiteWu","html_url":"https://github.com/PureWhiteWu","followers_url":"https://api.github.com/users/PureWhiteWu/followers","following_url":"https://api.github.com/users/PureWhiteWu/following{/other_user}","gists_url":"https://api.github.com/users/PureWhiteWu/gists{/gist_id}","starred_url":"https://api.github.com/users/PureWhiteWu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PureWhiteWu/subscriptions","organizations_url":"https://api.github.com/users/PureWhiteWu/orgs","repos_url":"https://api.github.com/users/PureWhiteWu/repos","events_url":"https://api.github.com/users/PureWhiteWu/events{/privacy}","received_events_url":"https://api.github.com/users/PureWhiteWu/received_events","type":"User","site_admin":false}],"milestone":null,"comments":7,"created_at":"2017-12-03T13:49:02Z","updated_at":"2017-12-03T14:13:09Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/dashbase/jaeger/pulls/2","html_url":"https://github.com/dashbase/jaeger/pull/2","diff_url":"https://github.com/dashbase/jaeger/pull/2.diff","patch_url":"https://github.com/dashbase/jaeger/pull/2.patch"},"body":"1. 修改了所有的 `jaegertracing/jaeger` 为 `dashbase/jaeger`\r\n2. 经测试，从目前的修改后的要merge upstream最新的（12个commit behind），大概会产生4个conflict，由于路径变更导致的conflict修改耗时大约2分钟。修改前的要merge upstream大概会有2个conflict是由于代码变更导致的。\r\n3. 支持build all in one docker 命令 `docker build -t dashbase/jaeger:tag .`\r\n\r\n修改所有jaegertracing为dashbase好处：\r\n1. 不然的话，我们import的还是原来jaegertracing的包，本地必须有，要解决这个问题可以选择把我们clone下来的目录名就改为 jaegertracing/jaeger 但是这样太hack，不符合go目录管理的标准，而且也不能让我们的版本和原版共存。\r\n2. 如果jaegertracing/jaeger的commit和我们dashbase/jaeger的commit不同的话，会build出错，比如我本地现在是最新的jaegertracing/jaeger，配上旧的dashbase/jaeger build，报错。\r\n3. 既然是fork了别人的代码，就应该所有代码我们自己维护，而不应该再去依赖原有的代码。如果import不修改，实际上我们import的是另一个仓库里面的代码，而不是我们自己的。\r\n\r\n坏处：\r\n在和upstream sync的时候，会产生conflict，不过经测试conflict并不多（12个commit导致了4个import的conflict），import的conflict修复起来比较简单，耗时很少。\r\n\r\n综上，我认为修改import的路径名会给我们带来很多益处，利大于弊。"},"comment":{"url":"https://api.github.com/repos/dashbase/jaeger/issues/comments/348773613","html_url":"https://github.com/dashbase/jaeger/pull/2#issuecomment-348773613","issue_url":"https://api.github.com/repos/dashbase/jaeger/issues/2","id":348773613,"user":{"login":"PureWhiteWu","id":3314335,"avatar_url":"https://avatars3.githubusercontent.com/u/3314335?v=4","gravatar_id":"","url":"https://api.github.com/users/PureWhiteWu","html_url":"https://github.com/PureWhiteWu","followers_url":"https://api.github.com/users/PureWhiteWu/followers","following_url":"https://api.github.com/users/PureWhiteWu/following{/other_user}","gists_url":"https://api.github.com/users/PureWhiteWu/gists{/gist_id}","starred_url":"https://api.github.com/users/PureWhiteWu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PureWhiteWu/subscriptions","organizations_url":"https://api.github.com/users/PureWhiteWu/orgs","repos_url":"https://api.github.com/users/PureWhiteWu/repos","events_url":"https://api.github.com/users/PureWhiteWu/events{/privacy}","received_events_url":"https://api.github.com/users/PureWhiteWu/received_events","type":"User","site_admin":false},"created_at":"2017-12-03T14:13:09Z","updated_at":"2017-12-03T14:13:09Z","author_association":"NONE","body":"![image](https://user-images.githubusercontent.com/3314335/33526124-054288e2-d877-11e7-918c-c184ac1cb541.png)\r\n\r\n虽然看我是修改了200多个文件，但是在merge上游的时候，也就4个文件有冲突，不修改import也会冲突两个文件。而且import的冲突应该很容易进行手动解决conflict吧？"}}
{"actor":{"display_login":"PureWhiteWu"}}