{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/12484","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/12484/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/12484/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/12484/events","html_url":"https://github.com/nodejs/node/pull/12484","id":222361202,"number":12484,"title":"build: fix ninja build failure","user":{"login":"danbev","id":432351,"avatar_url":"https://avatars0.githubusercontent.com/u/432351?v=3","gravatar_id":"","url":"https://api.github.com/users/danbev","html_url":"https://github.com/danbev","followers_url":"https://api.github.com/users/danbev/followers","following_url":"https://api.github.com/users/danbev/following{/other_user}","gists_url":"https://api.github.com/users/danbev/gists{/gist_id}","starred_url":"https://api.github.com/users/danbev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danbev/subscriptions","organizations_url":"https://api.github.com/users/danbev/orgs","repos_url":"https://api.github.com/users/danbev/repos","events_url":"https://api.github.com/users/danbev/events{/privacy}","received_events_url":"https://api.github.com/users/danbev/received_events","type":"User","site_admin":false},"labels":[{"id":171787391,"url":"https://api.github.com/repos/nodejs/node/labels/build","name":"build","color":"eb6420","default":false},{"id":237979054,"url":"https://api.github.com/repos/nodejs/node/labels/tools","name":"tools","color":"d4c5f9","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":31,"created_at":"2017-04-18T09:52:02Z","updated_at":"2017-05-11T12:13:06Z","closed_at":"2017-05-11T12:13:06Z","pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/12484","html_url":"https://github.com/nodejs/node/pull/12484","diff_url":"https://github.com/nodejs/node/pull/12484.diff","patch_url":"https://github.com/nodejs/node/pull/12484.patch"},"body":"When working on commit 6a09a69\r\n(\"build: enable cctest to use generated objects\") I did not take into\r\naccount building with ninja:\r\n```console\r\n$ ./configure\r\n$ tools/gyp_node.py -f ninja\r\n$ ninja -C out/Release\r\n$ ln -fs out/Release/node node\r\n```\r\nWhen ninja generated the ninja build files, src files that are\r\nrelative to the src directory will be named with a dot instead of a\r\npath separator, for example:\r\n```console\r\nout/Release/obj/src/node/node.o\r\n```\r\nwould instead become:\r\n```console\r\nout/Release/obj/src/node.node.o\r\n```\r\nThis commit adds an additional variable for the typ of object separator\r\nused for this case.\r\n\r\nAlso, the LIBS specified in the 'libraries' section are not\r\nbeing included in the --start-group --end-group section which\r\nmeans that these libraries will not be searched causing issue\r\nwith linkers where the order matters.\r\n\r\nFixes: https://github.com/nodejs/node/issues/12448\r\n\r\n<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-guidelines)\r\n\r\n##### Affected core subsystem(s)\r\n<!-- Provide affected core subsystem(s) (like doc, cluster, crypto, etc). -->\r\nbuild"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/300770780","html_url":"https://github.com/nodejs/node/pull/12484#issuecomment-300770780","issue_url":"https://api.github.com/repos/nodejs/node/issues/12484","id":300770780,"user":{"login":"refack","id":96947,"avatar_url":"https://avatars0.githubusercontent.com/u/96947?v=3","gravatar_id":"","url":"https://api.github.com/users/refack","html_url":"https://github.com/refack","followers_url":"https://api.github.com/users/refack/followers","following_url":"https://api.github.com/users/refack/following{/other_user}","gists_url":"https://api.github.com/users/refack/gists{/gist_id}","starred_url":"https://api.github.com/users/refack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/refack/subscriptions","organizations_url":"https://api.github.com/users/refack/orgs","repos_url":"https://api.github.com/users/refack/repos","events_url":"https://api.github.com/users/refack/events{/privacy}","received_events_url":"https://api.github.com/users/refack/received_events","type":"User","site_admin":false},"created_at":"2017-05-11T12:13:06Z","updated_at":"2017-05-11T12:13:06Z","body":"Landed in: 9fd22bc4d4"}}
{"actor":{"display_login":"refack"}}