{"action":"opened","number":2006,"pull_request":{"url":"https://api.github.com/repos/percona/percona-server/pulls/2006","id":156950871,"html_url":"https://github.com/percona/percona-server/pull/2006","diff_url":"https://github.com/percona/percona-server/pull/2006.diff","patch_url":"https://github.com/percona/percona-server/pull/2006.patch","issue_url":"https://api.github.com/repos/percona/percona-server/issues/2006","number":2006,"state":"open","locked":false,"title":"lp1736905: Remove additional assertions added during the artful fix.","user":{"login":"dutow","id":489009,"avatar_url":"https://avatars3.githubusercontent.com/u/489009?v=4","gravatar_id":"","url":"https://api.github.com/users/dutow","html_url":"https://github.com/dutow","followers_url":"https://api.github.com/users/dutow/followers","following_url":"https://api.github.com/users/dutow/following{/other_user}","gists_url":"https://api.github.com/users/dutow/gists{/gist_id}","starred_url":"https://api.github.com/users/dutow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dutow/subscriptions","organizations_url":"https://api.github.com/users/dutow/orgs","repos_url":"https://api.github.com/users/dutow/repos","events_url":"https://api.github.com/users/dutow/events{/privacy}","received_events_url":"https://api.github.com/users/dutow/received_events","type":"User","site_admin":false},"body":"During the artful compilation fixes, an assertion checking that some pointers aren't equal to an empty string were corrected:\r\nthese asserts now checked that the pointers aren't NULL pointers and that they do not point to an empty string.\r\n\r\nThis more restrictive address caused assertation violations where it shouldn't be. This commit changes them back to the more relaxed behaviors of the original code: it only checks that the pointers aren't NULL pointers.","created_at":"2017-12-07T10:05:13Z","updated_at":"2017-12-07T10:05:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/percona/percona-server/pulls/2006/commits","review_comments_url":"https://api.github.com/repos/percona/percona-server/pulls/2006/comments","review_comment_url":"https://api.github.com/repos/percona/percona-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/percona/percona-server/issues/2006/comments","statuses_url":"https://api.github.com/repos/percona/percona-server/statuses/975df8fac136b1a1db83ec8c679412904170ccdf","head":{"label":"dutow:ps-56-assert-fix","ref":"ps-56-assert-fix","sha":"975df8fac136b1a1db83ec8c679412904170ccdf","user":{"login":"dutow","id":489009,"avatar_url":"https://avatars3.githubusercontent.com/u/489009?v=4","gravatar_id":"","url":"https://api.github.com/users/dutow","html_url":"https://github.com/dutow","followers_url":"https://api.github.com/users/dutow/followers","following_url":"https://api.github.com/users/dutow/following{/other_user}","gists_url":"https://api.github.com/users/dutow/gists{/gist_id}","starred_url":"https://api.github.com/users/dutow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dutow/subscriptions","organizations_url":"https://api.github.com/users/dutow/orgs","repos_url":"https://api.github.com/users/dutow/repos","events_url":"https://api.github.com/users/dutow/events{/privacy}","received_events_url":"https://api.github.com/users/dutow/received_events","type":"User","site_admin":false},"repo":{"id":111694230,"name":"percona-server","full_name":"dutow/percona-server","owner":{"login":"dutow","id":489009,"avatar_url":"https://avatars3.githubusercontent.com/u/489009?v=4","gravatar_id":"","url":"https://api.github.com/users/dutow","html_url":"https://github.com/dutow","followers_url":"https://api.github.com/users/dutow/followers","following_url":"https://api.github.com/users/dutow/following{/other_user}","gists_url":"https://api.github.com/users/dutow/gists{/gist_id}","starred_url":"https://api.github.com/users/dutow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dutow/subscriptions","organizations_url":"https://api.github.com/users/dutow/orgs","repos_url":"https://api.github.com/users/dutow/repos","events_url":"https://api.github.com/users/dutow/events{/privacy}","received_events_url":"https://api.github.com/users/dutow/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dutow/percona-server","description":"Percona Server","fork":true,"url":"https://api.github.com/repos/dutow/percona-server","forks_url":"https://api.github.com/repos/dutow/percona-server/forks","keys_url":"https://api.github.com/repos/dutow/percona-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dutow/percona-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dutow/percona-server/teams","hooks_url":"https://api.github.com/repos/dutow/percona-server/hooks","issue_events_url":"https://api.github.com/repos/dutow/percona-server/issues/events{/number}","events_url":"https://api.github.com/repos/dutow/percona-server/events","assignees_url":"https://api.github.com/repos/dutow/percona-server/assignees{/user}","branches_url":"https://api.github.com/repos/dutow/percona-server/branches{/branch}","tags_url":"https://api.github.com/repos/dutow/percona-server/tags","blobs_url":"https://api.github.com/repos/dutow/percona-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dutow/percona-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dutow/percona-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/dutow/percona-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dutow/percona-server/statuses/{sha}","languages_url":"https://api.github.com/repos/dutow/percona-server/languages","stargazers_url":"https://api.github.com/repos/dutow/percona-server/stargazers","contributors_url":"https://api.github.com/repos/dutow/percona-server/contributors","subscribers_url":"https://api.github.com/repos/dutow/percona-server/subscribers","subscription_url":"https://api.github.com/repos/dutow/percona-server/subscription","commits_url":"https://api.github.com/repos/dutow/percona-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/dutow/percona-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/dutow/percona-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/dutow/percona-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/dutow/percona-server/contents/{+path}","compare_url":"https://api.github.com/repos/dutow/percona-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dutow/percona-server/merges","archive_url":"https://api.github.com/repos/dutow/percona-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dutow/percona-server/downloads","issues_url":"https://api.github.com/repos/dutow/percona-server/issues{/number}","pulls_url":"https://api.github.com/repos/dutow/percona-server/pulls{/number}","milestones_url":"https://api.github.com/repos/dutow/percona-server/milestones{/number}","notifications_url":"https://api.github.com/repos/dutow/percona-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dutow/percona-server/labels{/name}","releases_url":"https://api.github.com/repos/dutow/percona-server/releases{/id}","deployments_url":"https://api.github.com/repos/dutow/percona-server/deployments","created_at":"2017-11-22T14:27:07Z","updated_at":"2017-11-22T14:28:36Z","pushed_at":"2017-12-07T10:05:03Z","git_url":"git://github.com/dutow/percona-server.git","ssh_url":"git@github.com:dutow/percona-server.git","clone_url":"https://github.com/dutow/percona-server.git","svn_url":"https://github.com/dutow/percona-server","homepage":"https://www.percona.com/software/mysql-database/percona-server","size":572251,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"5.7"}},"base":{"label":"percona:5.6","ref":"5.6","sha":"b2e2ede8d62650f2413688e5e10ab4679c8f55a2","user":{"login":"percona","id":1683025,"avatar_url":"https://avatars0.githubusercontent.com/u/1683025?v=4","gravatar_id":"","url":"https://api.github.com/users/percona","html_url":"https://github.com/percona","followers_url":"https://api.github.com/users/percona/followers","following_url":"https://api.github.com/users/percona/following{/other_user}","gists_url":"https://api.github.com/users/percona/gists{/gist_id}","starred_url":"https://api.github.com/users/percona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/percona/subscriptions","organizations_url":"https://api.github.com/users/percona/orgs","repos_url":"https://api.github.com/users/percona/repos","events_url":"https://api.github.com/users/percona/events{/privacy}","received_events_url":"https://api.github.com/users/percona/received_events","type":"Organization","site_admin":false},"repo":{"id":30753733,"name":"percona-server","full_name":"percona/percona-server","owner":{"login":"percona","id":1683025,"avatar_url":"https://avatars0.githubusercontent.com/u/1683025?v=4","gravatar_id":"","url":"https://api.github.com/users/percona","html_url":"https://github.com/percona","followers_url":"https://api.github.com/users/percona/followers","following_url":"https://api.github.com/users/percona/following{/other_user}","gists_url":"https://api.github.com/users/percona/gists{/gist_id}","starred_url":"https://api.github.com/users/percona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/percona/subscriptions","organizations_url":"https://api.github.com/users/percona/orgs","repos_url":"https://api.github.com/users/percona/repos","events_url":"https://api.github.com/users/percona/events{/privacy}","received_events_url":"https://api.github.com/users/percona/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/percona/percona-server","description":"Percona Server","fork":false,"url":"https://api.github.com/repos/percona/percona-server","forks_url":"https://api.github.com/repos/percona/percona-server/forks","keys_url":"https://api.github.com/repos/percona/percona-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/percona/percona-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/percona/percona-server/teams","hooks_url":"https://api.github.com/repos/percona/percona-server/hooks","issue_events_url":"https://api.github.com/repos/percona/percona-server/issues/events{/number}","events_url":"https://api.github.com/repos/percona/percona-server/events","assignees_url":"https://api.github.com/repos/percona/percona-server/assignees{/user}","branches_url":"https://api.github.com/repos/percona/percona-server/branches{/branch}","tags_url":"https://api.github.com/repos/percona/percona-server/tags","blobs_url":"https://api.github.com/repos/percona/percona-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/percona/percona-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/percona/percona-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/percona/percona-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/percona/percona-server/statuses/{sha}","languages_url":"https://api.github.com/repos/percona/percona-server/languages","stargazers_url":"https://api.github.com/repos/percona/percona-server/stargazers","contributors_url":"https://api.github.com/repos/percona/percona-server/contributors","subscribers_url":"https://api.github.com/repos/percona/percona-server/subscribers","subscription_url":"https://api.github.com/repos/percona/percona-server/subscription","commits_url":"https://api.github.com/repos/percona/percona-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/percona/percona-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/percona/percona-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/percona/percona-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/percona/percona-server/contents/{+path}","compare_url":"https://api.github.com/repos/percona/percona-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/percona/percona-server/merges","archive_url":"https://api.github.com/repos/percona/percona-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/percona/percona-server/downloads","issues_url":"https://api.github.com/repos/percona/percona-server/issues{/number}","pulls_url":"https://api.github.com/repos/percona/percona-server/pulls{/number}","milestones_url":"https://api.github.com/repos/percona/percona-server/milestones{/number}","notifications_url":"https://api.github.com/repos/percona/percona-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/percona/percona-server/labels{/name}","releases_url":"https://api.github.com/repos/percona/percona-server/releases{/id}","deployments_url":"https://api.github.com/repos/percona/percona-server/deployments","created_at":"2015-02-13T11:32:01Z","updated_at":"2017-12-05T07:35:24Z","pushed_at":"2017-12-07T10:01:14Z","git_url":"git://github.com/percona/percona-server.git","ssh_url":"git@github.com:percona/percona-server.git","clone_url":"https://github.com/percona/percona-server.git","svn_url":"https://github.com/percona/percona-server","homepage":"https://www.percona.com/software/mysql-database/percona-server","size":572253,"stargazers_count":374,"watchers_count":374,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":154,"mirror_url":null,"archived":false,"open_issues_count":51,"license":null,"forks":154,"open_issues":51,"watchers":374,"default_branch":"5.7"}},"_links":{"self":{"href":"https://api.github.com/repos/percona/percona-server/pulls/2006"},"html":{"href":"https://github.com/percona/percona-server/pull/2006"},"issue":{"href":"https://api.github.com/repos/percona/percona-server/issues/2006"},"comments":{"href":"https://api.github.com/repos/percona/percona-server/issues/2006/comments"},"review_comments":{"href":"https://api.github.com/repos/percona/percona-server/pulls/2006/comments"},"review_comment":{"href":"https://api.github.com/repos/percona/percona-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/percona/percona-server/pulls/2006/commits"},"statuses":{"href":"https://api.github.com/repos/percona/percona-server/statuses/975df8fac136b1a1db83ec8c679412904170ccdf"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":3,"deletions":3,"changed_files":1}}
{"actor":{"display_login":"dutow"}}