{"action":"created","comment":{"url":"https://api.github.com/repos/Clever/workflow-manager/pulls/comments/154505856","pull_request_review_id":80683947,"id":154505856,"diff_hunk":"@@ -412,6 +450,8 @@ definitions:\n       input:\n         # format: json\n         type: string\n+      resolvedByUser:\n+        type: boolean","path":"swagger.yml","position":103,"original_position":103,"commit_id":"53f1e4b4ba04a86f3c7d6fee12296c4b3b04f280","original_commit_id":"53f1e4b4ba04a86f3c7d6fee12296c4b3b04f280","user":{"login":"bgveenstra","id":3254910,"avatar_url":"https://avatars0.githubusercontent.com/u/3254910?v=4","gravatar_id":"","url":"https://api.github.com/users/bgveenstra","html_url":"https://github.com/bgveenstra","followers_url":"https://api.github.com/users/bgveenstra/followers","following_url":"https://api.github.com/users/bgveenstra/following{/other_user}","gists_url":"https://api.github.com/users/bgveenstra/gists{/gist_id}","starred_url":"https://api.github.com/users/bgveenstra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgveenstra/subscriptions","organizations_url":"https://api.github.com/users/bgveenstra/orgs","repos_url":"https://api.github.com/users/bgveenstra/repos","events_url":"https://api.github.com/users/bgveenstra/events{/privacy}","received_events_url":"https://api.github.com/users/bgveenstra/received_events","type":"User","site_admin":false},"body":"I don't think we should expose this in ark @xavi-. It's not really a property inherent in the workflow and might not always live in workflow-manager.","created_at":"2017-12-02T20:21:22Z","updated_at":"2017-12-02T20:21:22Z","html_url":"https://github.com/Clever/workflow-manager/pull/101#discussion_r154505856","pull_request_url":"https://api.github.com/repos/Clever/workflow-manager/pulls/101","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Clever/workflow-manager/pulls/comments/154505856"},"html":{"href":"https://github.com/Clever/workflow-manager/pull/101#discussion_r154505856"},"pull_request":{"href":"https://api.github.com/repos/Clever/workflow-manager/pulls/101"}},"in_reply_to_id":154468555},"pull_request":{"url":"https://api.github.com/repos/Clever/workflow-manager/pulls/101","id":155975061,"html_url":"https://github.com/Clever/workflow-manager/pull/101","diff_url":"https://github.com/Clever/workflow-manager/pull/101.diff","patch_url":"https://github.com/Clever/workflow-manager/pull/101.patch","issue_url":"https://api.github.com/repos/Clever/workflow-manager/issues/101","number":101,"state":"open","locked":false,"title":"[Infra-2652] add ResolvedByUser to workflow summary","user":{"login":"bgveenstra","id":3254910,"avatar_url":"https://avatars0.githubusercontent.com/u/3254910?v=4","gravatar_id":"","url":"https://api.github.com/users/bgveenstra","html_url":"https://github.com/bgveenstra","followers_url":"https://api.github.com/users/bgveenstra/followers","following_url":"https://api.github.com/users/bgveenstra/following{/other_user}","gists_url":"https://api.github.com/users/bgveenstra/gists{/gist_id}","starred_url":"https://api.github.com/users/bgveenstra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgveenstra/subscriptions","organizations_url":"https://api.github.com/users/bgveenstra/orgs","repos_url":"https://api.github.com/users/bgveenstra/repos","events_url":"https://api.github.com/users/bgveenstra/events{/privacy}","received_events_url":"https://api.github.com/users/bgveenstra/received_events","type":"User","site_admin":false},"body":"Jira: [INFRA-2652](https://clever.atlassian.net/browse/INFRA-2652)\r\n\r\nTo support the use case of tracking which workflows have been investigated by a human, this PR adds a boolean `ResolvedByUser` field to the workflow model. Endpoint updates:\r\n\r\n- a new `POST /workflows/{workflowID}/resolved` endpoint that sets the target workflow's `ResolvedByUser` to `true` if it is `false` but returns a `409 Conflict` if it's already `true`\r\n- ability to send an optional `ResolvedByUser` boolean parameter to the `GET /workflows` endpoint that filters the results\r\n\r\n**Open questions:**\r\n- `ResolvedByUser` was intended to be used to mark that someone has checked on the reason for failure of a workflow.  Should we prevent users from \"resolving\" workflows that have certain (other) statuses?\r\n\r\n**Other notes:**\r\n- `ResolvedByUser` is an optional boolean parameter.  The `ResolvedByUserWrapper` allows us to distinguish between a `false` value was passed into a `GetWorkflows` request and a `false` default value that wasn't part of the request.  This is invisible to the client.\r\n- The `GET /workflows` endpoint accepts a `status` parameter or a `resolvedByUser` parameter, but not at once. This should be clear in the documentation. \r\n\r\n**Pre-deploy checklist:**\r\n- [x] Update swagger.yml version (to 0.7.1)\r\n- [x] Run \"make generate\"\r\n","created_at":"2017-12-01T22:49:21Z","updated_at":"2017-12-02T20:21:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5e8b2a83014893bb6435c6bf970bef4dad912a9e","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Clever/workflow-manager/pulls/101/commits","review_comments_url":"https://api.github.com/repos/Clever/workflow-manager/pulls/101/comments","review_comment_url":"https://api.github.com/repos/Clever/workflow-manager/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Clever/workflow-manager/issues/101/comments","statuses_url":"https://api.github.com/repos/Clever/workflow-manager/statuses/53f1e4b4ba04a86f3c7d6fee12296c4b3b04f280","head":{"label":"Clever:INFRA-2652-resolvedByUser-workflow-field","ref":"INFRA-2652-resolvedByUser-workflow-field","sha":"53f1e4b4ba04a86f3c7d6fee12296c4b3b04f280","user":{"login":"Clever","id":1885509,"avatar_url":"https://avatars1.githubusercontent.com/u/1885509?v=4","gravatar_id":"","url":"https://api.github.com/users/Clever","html_url":"https://github.com/Clever","followers_url":"https://api.github.com/users/Clever/followers","following_url":"https://api.github.com/users/Clever/following{/other_user}","gists_url":"https://api.github.com/users/Clever/gists{/gist_id}","starred_url":"https://api.github.com/users/Clever/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Clever/subscriptions","organizations_url":"https://api.github.com/users/Clever/orgs","repos_url":"https://api.github.com/users/Clever/repos","events_url":"https://api.github.com/users/Clever/events{/privacy}","received_events_url":"https://api.github.com/users/Clever/received_events","type":"Organization","site_admin":false},"repo":{"id":83012245,"name":"workflow-manager","full_name":"Clever/workflow-manager","owner":{"login":"Clever","id":1885509,"avatar_url":"https://avatars1.githubusercontent.com/u/1885509?v=4","gravatar_id":"","url":"https://api.github.com/users/Clever","html_url":"https://github.com/Clever","followers_url":"https://api.github.com/users/Clever/followers","following_url":"https://api.github.com/users/Clever/following{/other_user}","gists_url":"https://api.github.com/users/Clever/gists{/gist_id}","starred_url":"https://api.github.com/users/Clever/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Clever/subscriptions","organizations_url":"https://api.github.com/users/Clever/orgs","repos_url":"https://api.github.com/users/Clever/repos","events_url":"https://api.github.com/users/Clever/events{/privacy}","received_events_url":"https://api.github.com/users/Clever/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Clever/workflow-manager","description":"Minimal Workflow orchestrator for AWS Step Functions","fork":false,"url":"https://api.github.com/repos/Clever/workflow-manager","forks_url":"https://api.github.com/repos/Clever/workflow-manager/forks","keys_url":"https://api.github.com/repos/Clever/workflow-manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Clever/workflow-manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Clever/workflow-manager/teams","hooks_url":"https://api.github.com/repos/Clever/workflow-manager/hooks","issue_events_url":"https://api.github.com/repos/Clever/workflow-manager/issues/events{/number}","events_url":"https://api.github.com/repos/Clever/workflow-manager/events","assignees_url":"https://api.github.com/repos/Clever/workflow-manager/assignees{/user}","branches_url":"https://api.github.com/repos/Clever/workflow-manager/branches{/branch}","tags_url":"https://api.github.com/repos/Clever/workflow-manager/tags","blobs_url":"https://api.github.com/repos/Clever/workflow-manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Clever/workflow-manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Clever/workflow-manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/Clever/workflow-manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Clever/workflow-manager/statuses/{sha}","languages_url":"https://api.github.com/repos/Clever/workflow-manager/languages","stargazers_url":"https://api.github.com/repos/Clever/workflow-manager/stargazers","contributors_url":"https://api.github.com/repos/Clever/workflow-manager/contributors","subscribers_url":"https://api.github.com/repos/Clever/workflow-manager/subscribers","subscription_url":"https://api.github.com/repos/Clever/workflow-manager/subscription","commits_url":"https://api.github.com/repos/Clever/workflow-manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/Clever/workflow-manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/Clever/workflow-manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/Clever/workflow-manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/Clever/workflow-manager/contents/{+path}","compare_url":"https://api.github.com/repos/Clever/workflow-manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Clever/workflow-manager/merges","archive_url":"https://api.github.com/repos/Clever/workflow-manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Clever/workflow-manager/downloads","issues_url":"https://api.github.com/repos/Clever/workflow-manager/issues{/number}","pulls_url":"https://api.github.com/repos/Clever/workflow-manager/pulls{/number}","milestones_url":"https://api.github.com/repos/Clever/workflow-manager/milestones{/number}","notifications_url":"https://api.github.com/repos/Clever/workflow-manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Clever/workflow-manager/labels{/name}","releases_url":"https://api.github.com/repos/Clever/workflow-manager/releases{/id}","deployments_url":"https://api.github.com/repos/Clever/workflow-manager/deployments","created_at":"2017-02-24T07:05:50Z","updated_at":"2017-11-10T04:40:33Z","pushed_at":"2017-12-01T22:49:22Z","git_url":"git://github.com/Clever/workflow-manager.git","ssh_url":"git@github.com:Clever/workflow-manager.git","clone_url":"https://github.com/Clever/workflow-manager.git","svn_url":"https://github.com/Clever/workflow-manager","homepage":"","size":617,"stargazers_count":8,"watchers_count":8,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":8,"default_branch":"master"}},"base":{"label":"Clever:master","ref":"master","sha":"0f787146de4dba8bc26db60ff5b5f3054dd93553","user":{"login":"Clever","id":1885509,"avatar_url":"https://avatars1.githubusercontent.com/u/1885509?v=4","gravatar_id":"","url":"https://api.github.com/users/Clever","html_url":"https://github.com/Clever","followers_url":"https://api.github.com/users/Clever/followers","following_url":"https://api.github.com/users/Clever/following{/other_user}","gists_url":"https://api.github.com/users/Clever/gists{/gist_id}","starred_url":"https://api.github.com/users/Clever/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Clever/subscriptions","organizations_url":"https://api.github.com/users/Clever/orgs","repos_url":"https://api.github.com/users/Clever/repos","events_url":"https://api.github.com/users/Clever/events{/privacy}","received_events_url":"https://api.github.com/users/Clever/received_events","type":"Organization","site_admin":false},"repo":{"id":83012245,"name":"workflow-manager","full_name":"Clever/workflow-manager","owner":{"login":"Clever","id":1885509,"avatar_url":"https://avatars1.githubusercontent.com/u/1885509?v=4","gravatar_id":"","url":"https://api.github.com/users/Clever","html_url":"https://github.com/Clever","followers_url":"https://api.github.com/users/Clever/followers","following_url":"https://api.github.com/users/Clever/following{/other_user}","gists_url":"https://api.github.com/users/Clever/gists{/gist_id}","starred_url":"https://api.github.com/users/Clever/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Clever/subscriptions","organizations_url":"https://api.github.com/users/Clever/orgs","repos_url":"https://api.github.com/users/Clever/repos","events_url":"https://api.github.com/users/Clever/events{/privacy}","received_events_url":"https://api.github.com/users/Clever/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Clever/workflow-manager","description":"Minimal Workflow orchestrator for AWS Step Functions","fork":false,"url":"https://api.github.com/repos/Clever/workflow-manager","forks_url":"https://api.github.com/repos/Clever/workflow-manager/forks","keys_url":"https://api.github.com/repos/Clever/workflow-manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Clever/workflow-manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Clever/workflow-manager/teams","hooks_url":"https://api.github.com/repos/Clever/workflow-manager/hooks","issue_events_url":"https://api.github.com/repos/Clever/workflow-manager/issues/events{/number}","events_url":"https://api.github.com/repos/Clever/workflow-manager/events","assignees_url":"https://api.github.com/repos/Clever/workflow-manager/assignees{/user}","branches_url":"https://api.github.com/repos/Clever/workflow-manager/branches{/branch}","tags_url":"https://api.github.com/repos/Clever/workflow-manager/tags","blobs_url":"https://api.github.com/repos/Clever/workflow-manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Clever/workflow-manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Clever/workflow-manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/Clever/workflow-manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Clever/workflow-manager/statuses/{sha}","languages_url":"https://api.github.com/repos/Clever/workflow-manager/languages","stargazers_url":"https://api.github.com/repos/Clever/workflow-manager/stargazers","contributors_url":"https://api.github.com/repos/Clever/workflow-manager/contributors","subscribers_url":"https://api.github.com/repos/Clever/workflow-manager/subscribers","subscription_url":"https://api.github.com/repos/Clever/workflow-manager/subscription","commits_url":"https://api.github.com/repos/Clever/workflow-manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/Clever/workflow-manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/Clever/workflow-manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/Clever/workflow-manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/Clever/workflow-manager/contents/{+path}","compare_url":"https://api.github.com/repos/Clever/workflow-manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Clever/workflow-manager/merges","archive_url":"https://api.github.com/repos/Clever/workflow-manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Clever/workflow-manager/downloads","issues_url":"https://api.github.com/repos/Clever/workflow-manager/issues{/number}","pulls_url":"https://api.github.com/repos/Clever/workflow-manager/pulls{/number}","milestones_url":"https://api.github.com/repos/Clever/workflow-manager/milestones{/number}","notifications_url":"https://api.github.com/repos/Clever/workflow-manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Clever/workflow-manager/labels{/name}","releases_url":"https://api.github.com/repos/Clever/workflow-manager/releases{/id}","deployments_url":"https://api.github.com/repos/Clever/workflow-manager/deployments","created_at":"2017-02-24T07:05:50Z","updated_at":"2017-11-10T04:40:33Z","pushed_at":"2017-12-01T22:49:22Z","git_url":"git://github.com/Clever/workflow-manager.git","ssh_url":"git@github.com:Clever/workflow-manager.git","clone_url":"https://github.com/Clever/workflow-manager.git","svn_url":"https://github.com/Clever/workflow-manager","homepage":"","size":617,"stargazers_count":8,"watchers_count":8,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Clever/workflow-manager/pulls/101"},"html":{"href":"https://github.com/Clever/workflow-manager/pull/101"},"issue":{"href":"https://api.github.com/repos/Clever/workflow-manager/issues/101"},"comments":{"href":"https://api.github.com/repos/Clever/workflow-manager/issues/101/comments"},"review_comments":{"href":"https://api.github.com/repos/Clever/workflow-manager/pulls/101/comments"},"review_comment":{"href":"https://api.github.com/repos/Clever/workflow-manager/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Clever/workflow-manager/pulls/101/commits"},"statuses":{"href":"https://api.github.com/repos/Clever/workflow-manager/statuses/53f1e4b4ba04a86f3c7d6fee12296c4b3b04f280"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"bgveenstra"}}