{"action":"created","comment":{"url":"https://api.github.com/repos/DynamoRIO/drmemory/pulls/comments/123876407","pull_request_review_id":46125423,"id":123876407,"diff_hunk":"@@ -64,6 +64,12 @@ static droption_t<int> op_max_args\n  \"Maximum number of arguments to print.  This option allows to limit the number of \"\n  \"arguments to be printed.  Specify 0 to disable args printing (including unknown).\");\n \n+static droption_t<std::string> op_config_file\n+(DROPTION_SCOPE_CLIENT, \"config\", \"./drltrace.config\", \"A path to drltrace's config file\",\n+ \"Specify a path where config is located. The default value is \\\"./drltrace.conf\\\"\"\n+ \"(current dir).  Config file describes a prototype of library functions to be able\"","path":"drltrace/drltrace_options.h","position":7,"original_position":7,"commit_id":"2ea1ef99194cdd7a45b3814a7d7fc6da2a9140ef","original_commit_id":"2ea1ef99194cdd7a45b3814a7d7fc6da2a9140ef","user":{"login":"mxmssh","id":6836706,"avatar_url":"https://avatars3.githubusercontent.com/u/6836706?v=3","gravatar_id":"","url":"https://api.github.com/users/mxmssh","html_url":"https://github.com/mxmssh","followers_url":"https://api.github.com/users/mxmssh/followers","following_url":"https://api.github.com/users/mxmssh/following{/other_user}","gists_url":"https://api.github.com/users/mxmssh/gists{/gist_id}","starred_url":"https://api.github.com/users/mxmssh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mxmssh/subscriptions","organizations_url":"https://api.github.com/users/mxmssh/orgs","repos_url":"https://api.github.com/users/mxmssh/repos","events_url":"https://api.github.com/users/mxmssh/events{/privacy}","received_events_url":"https://api.github.com/users/mxmssh/received_events","type":"User","site_admin":false},"body":"Done","created_at":"2017-06-24T12:35:05Z","updated_at":"2017-06-24T12:35:05Z","html_url":"https://github.com/DynamoRIO/drmemory/pull/2001#discussion_r123876407","pull_request_url":"https://api.github.com/repos/DynamoRIO/drmemory/pulls/2001","_links":{"self":{"href":"https://api.github.com/repos/DynamoRIO/drmemory/pulls/comments/123876407"},"html":{"href":"https://github.com/DynamoRIO/drmemory/pull/2001#discussion_r123876407"},"pull_request":{"href":"https://api.github.com/repos/DynamoRIO/drmemory/pulls/2001"}}},"pull_request":{"url":"https://api.github.com/repos/DynamoRIO/drmemory/pulls/2001","id":125679858,"html_url":"https://github.com/DynamoRIO/drmemory/pull/2001","diff_url":"https://github.com/DynamoRIO/drmemory/pull/2001.diff","patch_url":"https://github.com/DynamoRIO/drmemory/pull/2001.patch","issue_url":"https://api.github.com/repos/DynamoRIO/drmemory/issues/2001","number":2001,"state":"open","locked":false,"title":"i#1948 drltrace libcall args printing: config file init","user":{"login":"mxmssh","id":6836706,"avatar_url":"https://avatars3.githubusercontent.com/u/6836706?v=3","gravatar_id":"","url":"https://api.github.com/users/mxmssh","html_url":"https://github.com/mxmssh","followers_url":"https://api.github.com/users/mxmssh/followers","following_url":"https://api.github.com/users/mxmssh/following{/other_user}","gists_url":"https://api.github.com/users/mxmssh/gists{/gist_id}","starred_url":"https://api.github.com/users/mxmssh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mxmssh/subscriptions","organizations_url":"https://api.github.com/users/mxmssh/orgs","repos_url":"https://api.github.com/users/mxmssh/repos","events_url":"https://api.github.com/users/mxmssh/events{/privacy}","received_events_url":"https://api.github.com/users/mxmssh/received_events","type":"User","site_admin":false},"body":"Implemented simplified language for function prototypes description\r\nto provide an external source where user can define custom libcalls\r\nto be able to print arguments.\r\n\r\nAdded config file parsing routines\r\nAdded hashtable to store libcalls info\r\nAdded strings printing routine\r\nAdded a third way to print arguments\r\nAdded simplified config file with strcmp/wcscmp/printf/puts prototypes\r\nAdded tests for Windows and Linux","created_at":"2017-06-14T19:57:58Z","updated_at":"2017-06-24T12:35:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2a4bf2651c2aa8178596cb41e1e9dd60ec6480aa","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/DynamoRIO/drmemory/pulls/2001/commits","review_comments_url":"https://api.github.com/repos/DynamoRIO/drmemory/pulls/2001/comments","review_comment_url":"https://api.github.com/repos/DynamoRIO/drmemory/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DynamoRIO/drmemory/issues/2001/comments","statuses_url":"https://api.github.com/repos/DynamoRIO/drmemory/statuses/2ea1ef99194cdd7a45b3814a7d7fc6da2a9140ef","head":{"label":"DynamoRIO:i1948-conf-init","ref":"i1948-conf-init","sha":"2ea1ef99194cdd7a45b3814a7d7fc6da2a9140ef","user":{"login":"DynamoRIO","id":9010155,"avatar_url":"https://avatars1.githubusercontent.com/u/9010155?v=3","gravatar_id":"","url":"https://api.github.com/users/DynamoRIO","html_url":"https://github.com/DynamoRIO","followers_url":"https://api.github.com/users/DynamoRIO/followers","following_url":"https://api.github.com/users/DynamoRIO/following{/other_user}","gists_url":"https://api.github.com/users/DynamoRIO/gists{/gist_id}","starred_url":"https://api.github.com/users/DynamoRIO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DynamoRIO/subscriptions","organizations_url":"https://api.github.com/users/DynamoRIO/orgs","repos_url":"https://api.github.com/users/DynamoRIO/repos","events_url":"https://api.github.com/users/DynamoRIO/events{/privacy}","received_events_url":"https://api.github.com/users/DynamoRIO/received_events","type":"Organization","site_admin":false},"repo":{"id":27244181,"name":"drmemory","full_name":"DynamoRIO/drmemory","owner":{"login":"DynamoRIO","id":9010155,"avatar_url":"https://avatars1.githubusercontent.com/u/9010155?v=3","gravatar_id":"","url":"https://api.github.com/users/DynamoRIO","html_url":"https://github.com/DynamoRIO","followers_url":"https://api.github.com/users/DynamoRIO/followers","following_url":"https://api.github.com/users/DynamoRIO/following{/other_user}","gists_url":"https://api.github.com/users/DynamoRIO/gists{/gist_id}","starred_url":"https://api.github.com/users/DynamoRIO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DynamoRIO/subscriptions","organizations_url":"https://api.github.com/users/DynamoRIO/orgs","repos_url":"https://api.github.com/users/DynamoRIO/repos","events_url":"https://api.github.com/users/DynamoRIO/events{/privacy}","received_events_url":"https://api.github.com/users/DynamoRIO/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DynamoRIO/drmemory","description":"Memory Debugger for Windows, Linux, Mac, and Android","fork":false,"url":"https://api.github.com/repos/DynamoRIO/drmemory","forks_url":"https://api.github.com/repos/DynamoRIO/drmemory/forks","keys_url":"https://api.github.com/repos/DynamoRIO/drmemory/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DynamoRIO/drmemory/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DynamoRIO/drmemory/teams","hooks_url":"https://api.github.com/repos/DynamoRIO/drmemory/hooks","issue_events_url":"https://api.github.com/repos/DynamoRIO/drmemory/issues/events{/number}","events_url":"https://api.github.com/repos/DynamoRIO/drmemory/events","assignees_url":"https://api.github.com/repos/DynamoRIO/drmemory/assignees{/user}","branches_url":"https://api.github.com/repos/DynamoRIO/drmemory/branches{/branch}","tags_url":"https://api.github.com/repos/DynamoRIO/drmemory/tags","blobs_url":"https://api.github.com/repos/DynamoRIO/drmemory/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DynamoRIO/drmemory/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DynamoRIO/drmemory/git/refs{/sha}","trees_url":"https://api.github.com/repos/DynamoRIO/drmemory/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DynamoRIO/drmemory/statuses/{sha}","languages_url":"https://api.github.com/repos/DynamoRIO/drmemory/languages","stargazers_url":"https://api.github.com/repos/DynamoRIO/drmemory/stargazers","contributors_url":"https://api.github.com/repos/DynamoRIO/drmemory/contributors","subscribers_url":"https://api.github.com/repos/DynamoRIO/drmemory/subscribers","subscription_url":"https://api.github.com/repos/DynamoRIO/drmemory/subscription","commits_url":"https://api.github.com/repos/DynamoRIO/drmemory/commits{/sha}","git_commits_url":"https://api.github.com/repos/DynamoRIO/drmemory/git/commits{/sha}","comments_url":"https://api.github.com/repos/DynamoRIO/drmemory/comments{/number}","issue_comment_url":"https://api.github.com/repos/DynamoRIO/drmemory/issues/comments{/number}","contents_url":"https://api.github.com/repos/DynamoRIO/drmemory/contents/{+path}","compare_url":"https://api.github.com/repos/DynamoRIO/drmemory/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DynamoRIO/drmemory/merges","archive_url":"https://api.github.com/repos/DynamoRIO/drmemory/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DynamoRIO/drmemory/downloads","issues_url":"https://api.github.com/repos/DynamoRIO/drmemory/issues{/number}","pulls_url":"https://api.github.com/repos/DynamoRIO/drmemory/pulls{/number}","milestones_url":"https://api.github.com/repos/DynamoRIO/drmemory/milestones{/number}","notifications_url":"https://api.github.com/repos/DynamoRIO/drmemory/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DynamoRIO/drmemory/labels{/name}","releases_url":"https://api.github.com/repos/DynamoRIO/drmemory/releases{/id}","deployments_url":"https://api.github.com/repos/DynamoRIO/drmemory/deployments","created_at":"2014-11-27T23:02:28Z","updated_at":"2017-06-23T19:49:09Z","pushed_at":"2017-06-14T19:57:58Z","git_url":"git://github.com/DynamoRIO/drmemory.git","ssh_url":"git@github.com:DynamoRIO/drmemory.git","clone_url":"https://github.com/DynamoRIO/drmemory.git","svn_url":"https://github.com/DynamoRIO/drmemory","homepage":"","size":5919,"stargazers_count":752,"watchers_count":752,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":95,"mirror_url":null,"open_issues_count":854,"forks":95,"open_issues":854,"watchers":752,"default_branch":"master"}},"base":{"label":"DynamoRIO:master","ref":"master","sha":"202ce254ada4227c26634d24221afad3d27b078b","user":{"login":"DynamoRIO","id":9010155,"avatar_url":"https://avatars1.githubusercontent.com/u/9010155?v=3","gravatar_id":"","url":"https://api.github.com/users/DynamoRIO","html_url":"https://github.com/DynamoRIO","followers_url":"https://api.github.com/users/DynamoRIO/followers","following_url":"https://api.github.com/users/DynamoRIO/following{/other_user}","gists_url":"https://api.github.com/users/DynamoRIO/gists{/gist_id}","starred_url":"https://api.github.com/users/DynamoRIO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DynamoRIO/subscriptions","organizations_url":"https://api.github.com/users/DynamoRIO/orgs","repos_url":"https://api.github.com/users/DynamoRIO/repos","events_url":"https://api.github.com/users/DynamoRIO/events{/privacy}","received_events_url":"https://api.github.com/users/DynamoRIO/received_events","type":"Organization","site_admin":false},"repo":{"id":27244181,"name":"drmemory","full_name":"DynamoRIO/drmemory","owner":{"login":"DynamoRIO","id":9010155,"avatar_url":"https://avatars1.githubusercontent.com/u/9010155?v=3","gravatar_id":"","url":"https://api.github.com/users/DynamoRIO","html_url":"https://github.com/DynamoRIO","followers_url":"https://api.github.com/users/DynamoRIO/followers","following_url":"https://api.github.com/users/DynamoRIO/following{/other_user}","gists_url":"https://api.github.com/users/DynamoRIO/gists{/gist_id}","starred_url":"https://api.github.com/users/DynamoRIO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DynamoRIO/subscriptions","organizations_url":"https://api.github.com/users/DynamoRIO/orgs","repos_url":"https://api.github.com/users/DynamoRIO/repos","events_url":"https://api.github.com/users/DynamoRIO/events{/privacy}","received_events_url":"https://api.github.com/users/DynamoRIO/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DynamoRIO/drmemory","description":"Memory Debugger for Windows, Linux, Mac, and Android","fork":false,"url":"https://api.github.com/repos/DynamoRIO/drmemory","forks_url":"https://api.github.com/repos/DynamoRIO/drmemory/forks","keys_url":"https://api.github.com/repos/DynamoRIO/drmemory/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DynamoRIO/drmemory/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DynamoRIO/drmemory/teams","hooks_url":"https://api.github.com/repos/DynamoRIO/drmemory/hooks","issue_events_url":"https://api.github.com/repos/DynamoRIO/drmemory/issues/events{/number}","events_url":"https://api.github.com/repos/DynamoRIO/drmemory/events","assignees_url":"https://api.github.com/repos/DynamoRIO/drmemory/assignees{/user}","branches_url":"https://api.github.com/repos/DynamoRIO/drmemory/branches{/branch}","tags_url":"https://api.github.com/repos/DynamoRIO/drmemory/tags","blobs_url":"https://api.github.com/repos/DynamoRIO/drmemory/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DynamoRIO/drmemory/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DynamoRIO/drmemory/git/refs{/sha}","trees_url":"https://api.github.com/repos/DynamoRIO/drmemory/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DynamoRIO/drmemory/statuses/{sha}","languages_url":"https://api.github.com/repos/DynamoRIO/drmemory/languages","stargazers_url":"https://api.github.com/repos/DynamoRIO/drmemory/stargazers","contributors_url":"https://api.github.com/repos/DynamoRIO/drmemory/contributors","subscribers_url":"https://api.github.com/repos/DynamoRIO/drmemory/subscribers","subscription_url":"https://api.github.com/repos/DynamoRIO/drmemory/subscription","commits_url":"https://api.github.com/repos/DynamoRIO/drmemory/commits{/sha}","git_commits_url":"https://api.github.com/repos/DynamoRIO/drmemory/git/commits{/sha}","comments_url":"https://api.github.com/repos/DynamoRIO/drmemory/comments{/number}","issue_comment_url":"https://api.github.com/repos/DynamoRIO/drmemory/issues/comments{/number}","contents_url":"https://api.github.com/repos/DynamoRIO/drmemory/contents/{+path}","compare_url":"https://api.github.com/repos/DynamoRIO/drmemory/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DynamoRIO/drmemory/merges","archive_url":"https://api.github.com/repos/DynamoRIO/drmemory/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DynamoRIO/drmemory/downloads","issues_url":"https://api.github.com/repos/DynamoRIO/drmemory/issues{/number}","pulls_url":"https://api.github.com/repos/DynamoRIO/drmemory/pulls{/number}","milestones_url":"https://api.github.com/repos/DynamoRIO/drmemory/milestones{/number}","notifications_url":"https://api.github.com/repos/DynamoRIO/drmemory/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DynamoRIO/drmemory/labels{/name}","releases_url":"https://api.github.com/repos/DynamoRIO/drmemory/releases{/id}","deployments_url":"https://api.github.com/repos/DynamoRIO/drmemory/deployments","created_at":"2014-11-27T23:02:28Z","updated_at":"2017-06-23T19:49:09Z","pushed_at":"2017-06-14T19:57:58Z","git_url":"git://github.com/DynamoRIO/drmemory.git","ssh_url":"git@github.com:DynamoRIO/drmemory.git","clone_url":"https://github.com/DynamoRIO/drmemory.git","svn_url":"https://github.com/DynamoRIO/drmemory","homepage":"","size":5919,"stargazers_count":752,"watchers_count":752,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":95,"mirror_url":null,"open_issues_count":854,"forks":95,"open_issues":854,"watchers":752,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DynamoRIO/drmemory/pulls/2001"},"html":{"href":"https://github.com/DynamoRIO/drmemory/pull/2001"},"issue":{"href":"https://api.github.com/repos/DynamoRIO/drmemory/issues/2001"},"comments":{"href":"https://api.github.com/repos/DynamoRIO/drmemory/issues/2001/comments"},"review_comments":{"href":"https://api.github.com/repos/DynamoRIO/drmemory/pulls/2001/comments"},"review_comment":{"href":"https://api.github.com/repos/DynamoRIO/drmemory/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DynamoRIO/drmemory/pulls/2001/commits"},"statuses":{"href":"https://api.github.com/repos/DynamoRIO/drmemory/statuses/2ea1ef99194cdd7a45b3814a7d7fc6da2a9140ef"}}}}
{"actor":{"display_login":"mxmssh"}}