{"action":"created","issue":{"url":"https://api.github.com/repos/hashicorp/consul/issues/3480","repository_url":"https://api.github.com/repos/hashicorp/consul","labels_url":"https://api.github.com/repos/hashicorp/consul/issues/3480/labels{/name}","comments_url":"https://api.github.com/repos/hashicorp/consul/issues/3480/comments","events_url":"https://api.github.com/repos/hashicorp/consul/issues/3480/events","html_url":"https://github.com/hashicorp/consul/pull/3480","id":258632620,"number":3480,"title":"New config parser, HCL support, multiple bind addrs","user":{"login":"magiconair","id":229005,"avatar_url":"https://avatars3.githubusercontent.com/u/229005?v=4","gravatar_id":"","url":"https://api.github.com/users/magiconair","html_url":"https://github.com/magiconair","followers_url":"https://api.github.com/users/magiconair/followers","following_url":"https://api.github.com/users/magiconair/following{/other_user}","gists_url":"https://api.github.com/users/magiconair/gists{/gist_id}","starred_url":"https://api.github.com/users/magiconair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magiconair/subscriptions","organizations_url":"https://api.github.com/users/magiconair/orgs","repos_url":"https://api.github.com/users/magiconair/repos","events_url":"https://api.github.com/users/magiconair/events{/privacy}","received_events_url":"https://api.github.com/users/magiconair/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"magiconair","id":229005,"avatar_url":"https://avatars3.githubusercontent.com/u/229005?v=4","gravatar_id":"","url":"https://api.github.com/users/magiconair","html_url":"https://github.com/magiconair","followers_url":"https://api.github.com/users/magiconair/followers","following_url":"https://api.github.com/users/magiconair/following{/other_user}","gists_url":"https://api.github.com/users/magiconair/gists{/gist_id}","starred_url":"https://api.github.com/users/magiconair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magiconair/subscriptions","organizations_url":"https://api.github.com/users/magiconair/orgs","repos_url":"https://api.github.com/users/magiconair/repos","events_url":"https://api.github.com/users/magiconair/events{/privacy}","received_events_url":"https://api.github.com/users/magiconair/received_events","type":"User","site_admin":false},"assignees":[{"login":"magiconair","id":229005,"avatar_url":"https://avatars3.githubusercontent.com/u/229005?v=4","gravatar_id":"","url":"https://api.github.com/users/magiconair","html_url":"https://github.com/magiconair","followers_url":"https://api.github.com/users/magiconair/followers","following_url":"https://api.github.com/users/magiconair/following{/other_user}","gists_url":"https://api.github.com/users/magiconair/gists{/gist_id}","starred_url":"https://api.github.com/users/magiconair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magiconair/subscriptions","organizations_url":"https://api.github.com/users/magiconair/orgs","repos_url":"https://api.github.com/users/magiconair/repos","events_url":"https://api.github.com/users/magiconair/events{/privacy}","received_events_url":"https://api.github.com/users/magiconair/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2017-09-18T21:51:24Z","updated_at":"2017-09-24T11:14:24Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/hashicorp/consul/pulls/3480","html_url":"https://github.com/hashicorp/consul/pull/3480","diff_url":"https://github.com/hashicorp/consul/pull/3480.diff","patch_url":"https://github.com/hashicorp/consul/pull/3480.patch"},"body":"This patch implements a new config parser for the consul agent which\r\nmakes the following changes to the previous implementation:\r\n\r\n * add HCL support\r\n * all configuration fragments in tests and for default config are\r\n   expressed as HCL fragments\r\n * HCL fragments can be provided on the command line so that they\r\n   can eventually replace the command line flags.\r\n * HCL/JSON fragments are parsed into a temporary Config structure\r\n   which can be merged using reflection (all values are pointers).\r\n   The existing merge logic of overwrite for values and append\r\n   for slices has been preserved.\r\n * A single builder process generates a typed runtime configuration\r\n   for the agent.\r\n\r\nThe new implementation is more strict and fails in the builder process if no\r\nvalid runtime configuration can be generated. Therefore, additional\r\nvalidations in other parts of the code should be removed.\r\n\r\nThe builder also pre-computes all required network addresses so that no\r\naddress/port magic should be required where the configuration is used and\r\nshould therefore be removed.\r\n\r\nAs a side effect the code also supports multiple bind addresses for HTTP,\r\nHTTPS and DNS via go-sockaddr and static ip addresses.\r\n\r\nFixes #895\r\nFixes #2217 \r\nFixes #2825"},"comment":{"url":"https://api.github.com/repos/hashicorp/consul/issues/comments/331703019","html_url":"https://github.com/hashicorp/consul/pull/3480#issuecomment-331703019","issue_url":"https://api.github.com/repos/hashicorp/consul/issues/3480","id":331703019,"user":{"login":"magiconair","id":229005,"avatar_url":"https://avatars3.githubusercontent.com/u/229005?v=4","gravatar_id":"","url":"https://api.github.com/users/magiconair","html_url":"https://github.com/magiconair","followers_url":"https://api.github.com/users/magiconair/followers","following_url":"https://api.github.com/users/magiconair/following{/other_user}","gists_url":"https://api.github.com/users/magiconair/gists{/gist_id}","starred_url":"https://api.github.com/users/magiconair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magiconair/subscriptions","organizations_url":"https://api.github.com/users/magiconair/orgs","repos_url":"https://api.github.com/users/magiconair/repos","events_url":"https://api.github.com/users/magiconair/events{/privacy}","received_events_url":"https://api.github.com/users/magiconair/received_events","type":"User","site_admin":false},"created_at":"2017-09-24T11:14:24Z","updated_at":"2017-09-24T11:14:24Z","author_association":"CONTRIBUTOR","body":"I've pushed a change which removes all deprecated fields and flags and keeps a list in `agent/config/doc.go` The last remaining thing is `recursor` since we have both `recursor` and `recursors` and usually merge the single recursor into the list. "}}
{"actor":{"display_login":"magiconair"}}