{"action":"created","issue":{"url":"https://api.github.com/repos/lime-rt/lime/issues/208","repository_url":"https://api.github.com/repos/lime-rt/lime","labels_url":"https://api.github.com/repos/lime-rt/lime/issues/208/labels{/name}","comments_url":"https://api.github.com/repos/lime-rt/lime/issues/208/comments","events_url":"https://api.github.com/repos/lime-rt/lime/issues/208/events","html_url":"https://github.com/lime-rt/lime/pull/208","id":201535268,"number":208,"title":"Fixes the data race in raytracing (#203)","user":{"login":"allegroLeiden","id":10670238,"avatar_url":"https://avatars.githubusercontent.com/u/10670238?v=3","gravatar_id":"","url":"https://api.github.com/users/allegroLeiden","html_url":"https://github.com/allegroLeiden","followers_url":"https://api.github.com/users/allegroLeiden/followers","following_url":"https://api.github.com/users/allegroLeiden/following{/other_user}","gists_url":"https://api.github.com/users/allegroLeiden/gists{/gist_id}","starred_url":"https://api.github.com/users/allegroLeiden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allegroLeiden/subscriptions","organizations_url":"https://api.github.com/users/allegroLeiden/orgs","repos_url":"https://api.github.com/users/allegroLeiden/repos","events_url":"https://api.github.com/users/allegroLeiden/events{/privacy}","received_events_url":"https://api.github.com/users/allegroLeiden/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-01-18T10:35:52Z","updated_at":"2017-01-18T11:16:56Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/lime-rt/lime/pulls/208","html_url":"https://github.com/lime-rt/lime/pull/208","diff_url":"https://github.com/lime-rt/lime/pull/208.diff","patch_url":"https://github.com/lime-rt/lime/pull/208.patch"},"body":"I should make the caveat that the valgrind tool DRD still reports problems; however since these all occur outside the parallel section of raytrace.c, I don't understand what is going on. I attach the log file. Any ideas @tlunttil, or anybody else?\r\n\r\n[dlog.txt](https://github.com/lime-rt/lime/files/713608/dlog.txt)\r\n\r\nTo generate this I did\r\n```\r\n  cd example\r\n  ../lime -n -t -p 4 model_lte.c\r\n  ^c\r\n  valgrind --tool=drd --log-file=dlog.txt lime_<whatever>.x\r\n```\r\n\r\nBTW I was not able to squash the 'Minor' commit message via rebasing. Git seems to get confused after a merge.\r\n"},"comment":{"url":"https://api.github.com/repos/lime-rt/lime/issues/comments/273449730","html_url":"https://github.com/lime-rt/lime/pull/208#issuecomment-273449730","issue_url":"https://api.github.com/repos/lime-rt/lime/issues/208","id":273449730,"user":{"login":"tlunttil","id":12169106,"avatar_url":"https://avatars.githubusercontent.com/u/12169106?v=3","gravatar_id":"","url":"https://api.github.com/users/tlunttil","html_url":"https://github.com/tlunttil","followers_url":"https://api.github.com/users/tlunttil/followers","following_url":"https://api.github.com/users/tlunttil/following{/other_user}","gists_url":"https://api.github.com/users/tlunttil/gists{/gist_id}","starred_url":"https://api.github.com/users/tlunttil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tlunttil/subscriptions","organizations_url":"https://api.github.com/users/tlunttil/orgs","repos_url":"https://api.github.com/users/tlunttil/repos","events_url":"https://api.github.com/users/tlunttil/events{/privacy}","received_events_url":"https://api.github.com/users/tlunttil/received_events","type":"User","site_admin":false},"created_at":"2017-01-18T11:16:56Z","updated_at":"2017-01-18T11:16:56Z","body":"Maybe there are some dangling pointers from earlier parts which then confuse valgrind? Does memcheck complain about anything? On the other hand spurious error messages are not unheard of.\r\n\r\nIf you run with -DTEST a few times, are the results identical on bit-level? If so, there's probably no error.\r\n\r\nBTW, it could be worth looking at parallelising the (unparallelised) regions that drd complained about. At least that interpolation part sometimes takes a non-negligible amount of time. (There's also a cosmetic issue that the progress bar/percentage doesn't take into account time spent there, so it may get stuck at near 1005 for a while.)"}}
{"actor":{"display_login":"tlunttil"}}