{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/minikube/issues/1164","repository_url":"https://api.github.com/repos/kubernetes/minikube","labels_url":"https://api.github.com/repos/kubernetes/minikube/issues/1164/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/minikube/issues/1164/comments","events_url":"https://api.github.com/repos/kubernetes/minikube/issues/1164/events","html_url":"https://github.com/kubernetes/minikube/pull/1164","id":209183907,"number":1164,"title":"vendor: Better deal with failures under golang 1.8","user":{"login":"dongsupark","id":10096906,"avatar_url":"https://avatars.githubusercontent.com/u/10096906?v=3","gravatar_id":"","url":"https://api.github.com/users/dongsupark","html_url":"https://github.com/dongsupark","followers_url":"https://api.github.com/users/dongsupark/followers","following_url":"https://api.github.com/users/dongsupark/following{/other_user}","gists_url":"https://api.github.com/users/dongsupark/gists{/gist_id}","starred_url":"https://api.github.com/users/dongsupark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dongsupark/subscriptions","organizations_url":"https://api.github.com/users/dongsupark/orgs","repos_url":"https://api.github.com/users/dongsupark/repos","events_url":"https://api.github.com/users/dongsupark/events{/privacy}","received_events_url":"https://api.github.com/users/dongsupark/received_events","type":"User","site_admin":false},"labels":[{"id":364063829,"url":"https://api.github.com/repos/kubernetes/minikube/labels/cla:%20yes","name":"cla: yes","color":"bfe5bf","default":false},{"id":484585353,"url":"https://api.github.com/repos/kubernetes/minikube/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-02-21T15:43:50Z","updated_at":"2017-02-21T15:54:18Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/minikube/pulls/1164","html_url":"https://github.com/kubernetes/minikube/pull/1164","diff_url":"https://github.com/kubernetes/minikube/pull/1164.diff","patch_url":"https://github.com/kubernetes/minikube/pull/1164.patch"},"body":"If minikube is built with go 1.8 or newer, localkube panics immediately with the following message:\r\n\r\n```\r\nFeb 21 15:04:05 minikube localkube[3566]: I0221 15:04:05.712095    3566 services.go:51] Setting service IP to \"10.0.0.1\" (read-write).\r\nFeb 21 15:04:05 minikube localkube[3566]: panic: parse 127.0.0.1:8080: first path segment in URL cannot contain colon\r\nFeb 21 15:04:05 minikube localkube[3566]: goroutine 151 [running]:\r\nFeb 21 15:04:05 minikube localkube[3566]: k8s.io/minikube/vendor/k8s.io/kubernetes/pkg/client/clientset_generated/internalclientset/typed/core/internalversion.NewForConfigOrDie(0xc420c75380, 0xc420d04d40)\r\n```\r\n\r\nThis issue was already reported to Kubernetes, https://github.com/kubernetes/kubernetes/issues/38380. That was already fixed in Kubernetes, but it's not included in Minikube yet.\r\nSo let's cherry-pick the commit to minikube, to avoid the panic.\r\n\r\nOriginal commit message from https://github.com/kubernetes/kubernetes/pull/38519\r\n\r\n```\r\nIf there is any error in the initial parsing then we should just try adding the scheme.\r\n\r\nurl.Parse(base) has changed in 1.8. Please see the following change https://github.com/golang/go/commit/c5ccbdd22bdbdc43d541b7e7d4ed66ceb559030e\r\n\r\nFixes https://github.com/kubernetes/kubernetes/issues/38380\r\n```\r\n\r\n/cc @dims "},"comment":{"url":"https://api.github.com/repos/kubernetes/minikube/issues/comments/281385160","html_url":"https://github.com/kubernetes/minikube/pull/1164#issuecomment-281385160","issue_url":"https://api.github.com/repos/kubernetes/minikube/issues/1164","id":281385160,"user":{"login":"dims","id":23304,"avatar_url":"https://avatars.githubusercontent.com/u/23304?v=3","gravatar_id":"","url":"https://api.github.com/users/dims","html_url":"https://github.com/dims","followers_url":"https://api.github.com/users/dims/followers","following_url":"https://api.github.com/users/dims/following{/other_user}","gists_url":"https://api.github.com/users/dims/gists{/gist_id}","starred_url":"https://api.github.com/users/dims/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dims/subscriptions","organizations_url":"https://api.github.com/users/dims/orgs","repos_url":"https://api.github.com/users/dims/repos","events_url":"https://api.github.com/users/dims/events{/privacy}","received_events_url":"https://api.github.com/users/dims/received_events","type":"User","site_admin":false},"created_at":"2017-02-21T15:54:18Z","updated_at":"2017-02-21T15:54:18Z","body":"LGTM :) thanks, i was just about to do that late last week "}}
{"actor":{"display_login":"dims"}}