{"push_id":1842569939,"size":2,"distinct_size":1,"ref":"refs/heads/repo_dir","head":"200f4659b84d36fb3e5d68ddd3ec044d1fc9128a","before":"af105990f170eb5fafe2fca0499ba55d56dc4497","commits":[{"sha":"092b015ce3009e9be4c8601958201765e9f7927d","author":{"name":"Joshua Spence","email":"2d27c8320aa3eefe09ead96ce62c361629bc5ad6@joshuaspence.com"},"message":"Advertise support for Puppet 5","distinct":false,"url":"https://api.github.com/repos/joshuaspence/puppet-phabricator/commits/092b015ce3009e9be4c8601958201765e9f7927d"},{"sha":"200f4659b84d36fb3e5d68ddd3ec044d1fc9128a","author":{"name":"Joshua Spence","email":"2d27c8320aa3eefe09ead96ce62c361629bc5ad6@joshuaspence.com"},"message":"Don't create the repository directory\n\nThere's no need to create the repository directory (`/var/repo`) in Puppet, because the repository-pull daemon will create the directory itself:\n\n```\ntry {\n  $dirname = dirname($local_path);\n  if (!Filesystem::pathExists($dirname)) {\n    Filesystem::createDirectory($dirname, 0755, $recursive = true);\n  }\n\n  if (!Filesystem::pathExists($local_path)) {\n    $this->logPull(\n      pht(\n        'Creating a new working copy for repository \"%s\".',\n        $repository->getDisplayName()));\n    if ($is_git) {\n      $this->executeGitCreate();\n    } else if ($is_hg) {\n      $this->executeMercurialCreate();\n    } else {\n      $this->executeSubversionCreate();\n    }\n  }\n\n  // ...\n}\n```","distinct":true,"url":"https://api.github.com/repos/joshuaspence/puppet-phabricator/commits/200f4659b84d36fb3e5d68ddd3ec044d1fc9128a"}]}
{"actor":{"display_login":"joshuaspence"}}