{"action":"created","comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/96546818","pull_request_review_id":17131198,"id":96546818,"diff_hunk":"@@ -272,6 +271,10 @@ HitPairEDProducer::HitPairEDProducer(const edm::ParameterSet& iConfig):\n   else\n     throw cms::Exception(\"Configuration\") << \"HitPairEDProducer requires either produceIntermediateHitDoublets or produceSeedingHitSets to be True. If neither are needed, just remove this module from your sequence/path as it doesn't do anything useful\";\n \n+  auto clusterCheckTag = iConfig.getParameter<edm::InputTag>(\"clusterCheck\");\n+  if(clusterCheckTag.label() != \"\")\n+    clusterCheckToken_ = consumes<bool>(clusterCheckTag);","path":"RecoTracker/TkHitPairs/plugins/HitPairEDProducer.cc","position":16,"original_position":16,"commit_id":"8f717e9e66fcc3f6a40c13cbe784b0ea5e345dc6","original_commit_id":"8f717e9e66fcc3f6a40c13cbe784b0ea5e345dc6","user":{"login":"slava77","id":4676718,"avatar_url":"https://avatars.githubusercontent.com/u/4676718?v=3","gravatar_id":"","url":"https://api.github.com/users/slava77","html_url":"https://github.com/slava77","followers_url":"https://api.github.com/users/slava77/followers","following_url":"https://api.github.com/users/slava77/following{/other_user}","gists_url":"https://api.github.com/users/slava77/gists{/gist_id}","starred_url":"https://api.github.com/users/slava77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slava77/subscriptions","organizations_url":"https://api.github.com/users/slava77/orgs","repos_url":"https://api.github.com/users/slava77/repos","events_url":"https://api.github.com/users/slava77/events{/privacy}","received_events_url":"https://api.github.com/users/slava77/received_events","type":"User","site_admin":false},"body":"isn't this technically equivalent to what it was before? \r\nThat is, if the label is empty, you get an uninitialized token.","created_at":"2017-01-18T00:49:59Z","updated_at":"2017-01-18T00:49:59Z","html_url":"https://github.com/cms-sw/cmssw/pull/17170#discussion_r96546818","pull_request_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/17170","_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/96546818"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/17170#discussion_r96546818"},"pull_request":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/17170"}}},"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/17170","id":101423134,"html_url":"https://github.com/cms-sw/cmssw/pull/17170","diff_url":"https://github.com/cms-sw/cmssw/pull/17170.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/17170.patch","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/17170","number":17170,"state":"open","locked":false,"title":"Migrate PixelTrackProducer and HLT to new seeding framework","user":{"login":"makortel","id":33993,"avatar_url":"https://avatars.githubusercontent.com/u/33993?v=3","gravatar_id":"","url":"https://api.github.com/users/makortel","html_url":"https://github.com/makortel","followers_url":"https://api.github.com/users/makortel/followers","following_url":"https://api.github.com/users/makortel/following{/other_user}","gists_url":"https://api.github.com/users/makortel/gists{/gist_id}","starred_url":"https://api.github.com/users/makortel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/makortel/subscriptions","organizations_url":"https://api.github.com/users/makortel/orgs","repos_url":"https://api.github.com/users/makortel/repos","events_url":"https://api.github.com/users/makortel/events{/privacy}","received_events_url":"https://api.github.com/users/makortel/received_events","type":"User","site_admin":false},"body":"This PR is a continuation of #16792 and #16635. It migrates the `PixelTrackProducer` to the new seeding framework, and migrates all instances of it and `SeedGeneratorFromRegionHitsEDProducer` in the HLT (with `customizeHLTforCMSSW.py`).\r\n\r\nTested in CMSSW_9_0_X_2017-01-11-2300, no changes expected.\r\n\r\n@rovere @VinInn @felicepantaleo @mtosi @JanFSchulte ","created_at":"2017-01-13T10:32:04Z","updated_at":"2017-01-18T00:49:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7d97203e1d607f67f71c75a72e95846a6e64e824","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/64","html_url":"https://github.com/cms-sw/cmssw/milestone/64","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/64/labels","id":2138657,"number":64,"title":"Next CMSSW_9_0_X","description":null,"creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars.githubusercontent.com/u/4115138?v=3","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":58,"closed_issues":375,"state":"open","created_at":"2016-11-16T08:55:18Z","updated_at":"2017-01-17T20:32:28Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/17170/commits","review_comments_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/17170/comments","review_comment_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/17170/comments","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/8f717e9e66fcc3f6a40c13cbe784b0ea5e345dc6","head":{"label":"makortel:reworkSeeding_pixelTracks_lastpiece","ref":"reworkSeeding_pixelTracks_lastpiece","sha":"8f717e9e66fcc3f6a40c13cbe784b0ea5e345dc6","user":{"login":"makortel","id":33993,"avatar_url":"https://avatars.githubusercontent.com/u/33993?v=3","gravatar_id":"","url":"https://api.github.com/users/makortel","html_url":"https://github.com/makortel","followers_url":"https://api.github.com/users/makortel/followers","following_url":"https://api.github.com/users/makortel/following{/other_user}","gists_url":"https://api.github.com/users/makortel/gists{/gist_id}","starred_url":"https://api.github.com/users/makortel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/makortel/subscriptions","organizations_url":"https://api.github.com/users/makortel/orgs","repos_url":"https://api.github.com/users/makortel/repos","events_url":"https://api.github.com/users/makortel/events{/privacy}","received_events_url":"https://api.github.com/users/makortel/received_events","type":"User","site_admin":false},"repo":{"id":11017982,"name":"cmssw","full_name":"makortel/cmssw","owner":{"login":"makortel","id":33993,"avatar_url":"https://avatars.githubusercontent.com/u/33993?v=3","gravatar_id":"","url":"https://api.github.com/users/makortel","html_url":"https://github.com/makortel","followers_url":"https://api.github.com/users/makortel/followers","following_url":"https://api.github.com/users/makortel/following{/other_user}","gists_url":"https://api.github.com/users/makortel/gists{/gist_id}","starred_url":"https://api.github.com/users/makortel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/makortel/subscriptions","organizations_url":"https://api.github.com/users/makortel/orgs","repos_url":"https://api.github.com/users/makortel/repos","events_url":"https://api.github.com/users/makortel/events{/privacy}","received_events_url":"https://api.github.com/users/makortel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/makortel/cmssw","description":"CMS Offline Software","fork":true,"url":"https://api.github.com/repos/makortel/cmssw","forks_url":"https://api.github.com/repos/makortel/cmssw/forks","keys_url":"https://api.github.com/repos/makortel/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/makortel/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/makortel/cmssw/teams","hooks_url":"https://api.github.com/repos/makortel/cmssw/hooks","issue_events_url":"https://api.github.com/repos/makortel/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/makortel/cmssw/events","assignees_url":"https://api.github.com/repos/makortel/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/makortel/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/makortel/cmssw/tags","blobs_url":"https://api.github.com/repos/makortel/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/makortel/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/makortel/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/makortel/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/makortel/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/makortel/cmssw/languages","stargazers_url":"https://api.github.com/repos/makortel/cmssw/stargazers","contributors_url":"https://api.github.com/repos/makortel/cmssw/contributors","subscribers_url":"https://api.github.com/repos/makortel/cmssw/subscribers","subscription_url":"https://api.github.com/repos/makortel/cmssw/subscription","commits_url":"https://api.github.com/repos/makortel/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/makortel/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/makortel/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/makortel/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/makortel/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/makortel/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/makortel/cmssw/merges","archive_url":"https://api.github.com/repos/makortel/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/makortel/cmssw/downloads","issues_url":"https://api.github.com/repos/makortel/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/makortel/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/makortel/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/makortel/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/makortel/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/makortel/cmssw/releases{/id}","deployments_url":"https://api.github.com/repos/makortel/cmssw/deployments","created_at":"2013-06-28T06:39:15Z","updated_at":"2014-06-24T14:24:59Z","pushed_at":"2017-01-15T13:04:40Z","git_url":"git://github.com/makortel/cmssw.git","ssh_url":"git@github.com:makortel/cmssw.git","clone_url":"https://github.com/makortel/cmssw.git","svn_url":"https://github.com/makortel/cmssw","homepage":null,"size":900027,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"CMSSW_7_0_X"}},"base":{"label":"cms-sw:CMSSW_9_0_X","ref":"CMSSW_9_0_X","sha":"251d6303a1ea1bf54c2d305e7feaa348c2081dd3","user":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars.githubusercontent.com/u/3863500?v=3","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"repo":{"id":10969551,"name":"cmssw","full_name":"cms-sw/cmssw","owner":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars.githubusercontent.com/u/3863500?v=3","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cms-sw/cmssw","description":"CMS Offline Software","fork":false,"url":"https://api.github.com/repos/cms-sw/cmssw","forks_url":"https://api.github.com/repos/cms-sw/cmssw/forks","keys_url":"https://api.github.com/repos/cms-sw/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cms-sw/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cms-sw/cmssw/teams","hooks_url":"https://api.github.com/repos/cms-sw/cmssw/hooks","issue_events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/cms-sw/cmssw/events","assignees_url":"https://api.github.com/repos/cms-sw/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/cms-sw/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/cms-sw/cmssw/tags","blobs_url":"https://api.github.com/repos/cms-sw/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cms-sw/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cms-sw/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/cms-sw/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/cms-sw/cmssw/languages","stargazers_url":"https://api.github.com/repos/cms-sw/cmssw/stargazers","contributors_url":"https://api.github.com/repos/cms-sw/cmssw/contributors","subscribers_url":"https://api.github.com/repos/cms-sw/cmssw/subscribers","subscription_url":"https://api.github.com/repos/cms-sw/cmssw/subscription","commits_url":"https://api.github.com/repos/cms-sw/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/cms-sw/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/cms-sw/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/cms-sw/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cms-sw/cmssw/merges","archive_url":"https://api.github.com/repos/cms-sw/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cms-sw/cmssw/downloads","issues_url":"https://api.github.com/repos/cms-sw/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/cms-sw/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/cms-sw/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/cms-sw/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cms-sw/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/cms-sw/cmssw/releases{/id}","deployments_url":"https://api.github.com/repos/cms-sw/cmssw/deployments","created_at":"2013-06-26T14:09:07Z","updated_at":"2017-01-17T10:10:39Z","pushed_at":"2017-01-17T23:31:15Z","git_url":"git://github.com/cms-sw/cmssw.git","ssh_url":"git@github.com:cms-sw/cmssw.git","clone_url":"https://github.com/cms-sw/cmssw.git","svn_url":"https://github.com/cms-sw/cmssw","homepage":"http://cms-sw.github.io/","size":921144,"stargazers_count":380,"watchers_count":380,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2067,"mirror_url":null,"open_issues_count":336,"forks":2067,"open_issues":336,"watchers":380,"default_branch":"CMSSW_9_0_X"}},"_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/17170"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/17170"},"issue":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/17170"},"comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/17170/comments"},"review_comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/17170/comments"},"review_comment":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/17170/commits"},"statuses":{"href":"https://api.github.com/repos/cms-sw/cmssw/statuses/8f717e9e66fcc3f6a40c13cbe784b0ea5e345dc6"}}}}
{"actor":{"display_login":"slava77"}}