{"action":"created","comment":{"url":"https://api.github.com/repos/sky-uk/feed/pulls/comments/153448842","pull_request_review_id":79453114,"id":153448842,"diff_hunk":"@@ -250,8 +259,13 @@ func main() {\n }\n \n func createIngressUpdaters() ([]controller.Updater, error) {\n-\tnginxConfig.IngressPort = ingressPort\n+\tnginxConfig.IngressPorts = append(nginxConfig.IngressPorts, nginx.IngressPortConf{Name: \"http\", Port: ingressPort})","path":"cmd/feed-ingress/main.go","position":56,"original_position":56,"commit_id":"5d1d6dc53ec19221550310534ca6059687f1e516","original_commit_id":"5d1d6dc53ec19221550310534ca6059687f1e516","user":{"login":"jsravn","id":522123,"avatar_url":"https://avatars3.githubusercontent.com/u/522123?v=4","gravatar_id":"","url":"https://api.github.com/users/jsravn","html_url":"https://github.com/jsravn","followers_url":"https://api.github.com/users/jsravn/followers","following_url":"https://api.github.com/users/jsravn/following{/other_user}","gists_url":"https://api.github.com/users/jsravn/gists{/gist_id}","starred_url":"https://api.github.com/users/jsravn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsravn/subscriptions","organizations_url":"https://api.github.com/users/jsravn/orgs","repos_url":"https://api.github.com/users/jsravn/repos","events_url":"https://api.github.com/users/jsravn/events{/privacy}","received_events_url":"https://api.github.com/users/jsravn/received_events","type":"User","site_admin":false},"body":"The append is unnecessary here. Just do `nginxConfig.IngressPorts := []IngressPortConf{{Name: \"http\", Port: port}}`.","created_at":"2017-11-28T10:21:48Z","updated_at":"2017-11-28T10:48:03Z","html_url":"https://github.com/sky-uk/feed/pull/162#discussion_r153448842","pull_request_url":"https://api.github.com/repos/sky-uk/feed/pulls/162","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/sky-uk/feed/pulls/comments/153448842"},"html":{"href":"https://github.com/sky-uk/feed/pull/162#discussion_r153448842"},"pull_request":{"href":"https://api.github.com/repos/sky-uk/feed/pulls/162"}}},"pull_request":{"url":"https://api.github.com/repos/sky-uk/feed/pulls/162","id":154861337,"html_url":"https://github.com/sky-uk/feed/pull/162","diff_url":"https://github.com/sky-uk/feed/pull/162.diff","patch_url":"https://github.com/sky-uk/feed/pull/162.patch","issue_url":"https://api.github.com/repos/sky-uk/feed/issues/162","number":162,"state":"open","locked":false,"title":"Add https parameter + ssl termination","user":{"login":"rewiko","id":1068444,"avatar_url":"https://avatars1.githubusercontent.com/u/1068444?v=4","gravatar_id":"","url":"https://api.github.com/users/rewiko","html_url":"https://github.com/rewiko","followers_url":"https://api.github.com/users/rewiko/followers","following_url":"https://api.github.com/users/rewiko/following{/other_user}","gists_url":"https://api.github.com/users/rewiko/gists{/gist_id}","starred_url":"https://api.github.com/users/rewiko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rewiko/subscriptions","organizations_url":"https://api.github.com/users/rewiko/orgs","repos_url":"https://api.github.com/users/rewiko/repos","events_url":"https://api.github.com/users/rewiko/events{/privacy}","received_events_url":"https://api.github.com/users/rewiko/received_events","type":"User","site_admin":false},"body":"Give the ability to feed-ingress to handle ssl traffic.","created_at":"2017-11-27T16:51:04Z","updated_at":"2017-11-28T10:48:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1d032c604d685754ff98053eb574e42eba9fc3cf","assignee":{"login":"rewiko","id":1068444,"avatar_url":"https://avatars1.githubusercontent.com/u/1068444?v=4","gravatar_id":"","url":"https://api.github.com/users/rewiko","html_url":"https://github.com/rewiko","followers_url":"https://api.github.com/users/rewiko/followers","following_url":"https://api.github.com/users/rewiko/following{/other_user}","gists_url":"https://api.github.com/users/rewiko/gists{/gist_id}","starred_url":"https://api.github.com/users/rewiko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rewiko/subscriptions","organizations_url":"https://api.github.com/users/rewiko/orgs","repos_url":"https://api.github.com/users/rewiko/repos","events_url":"https://api.github.com/users/rewiko/events{/privacy}","received_events_url":"https://api.github.com/users/rewiko/received_events","type":"User","site_admin":false},"assignees":[{"login":"rewiko","id":1068444,"avatar_url":"https://avatars1.githubusercontent.com/u/1068444?v=4","gravatar_id":"","url":"https://api.github.com/users/rewiko","html_url":"https://github.com/rewiko","followers_url":"https://api.github.com/users/rewiko/followers","following_url":"https://api.github.com/users/rewiko/following{/other_user}","gists_url":"https://api.github.com/users/rewiko/gists{/gist_id}","starred_url":"https://api.github.com/users/rewiko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rewiko/subscriptions","organizations_url":"https://api.github.com/users/rewiko/orgs","repos_url":"https://api.github.com/users/rewiko/repos","events_url":"https://api.github.com/users/rewiko/events{/privacy}","received_events_url":"https://api.github.com/users/rewiko/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/sky-uk/feed/pulls/162/commits","review_comments_url":"https://api.github.com/repos/sky-uk/feed/pulls/162/comments","review_comment_url":"https://api.github.com/repos/sky-uk/feed/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sky-uk/feed/issues/162/comments","statuses_url":"https://api.github.com/repos/sky-uk/feed/statuses/5d1d6dc53ec19221550310534ca6059687f1e516","head":{"label":"sky-uk:feature/add-ssl-endpoint","ref":"feature/add-ssl-endpoint","sha":"5d1d6dc53ec19221550310534ca6059687f1e516","user":{"login":"sky-uk","id":1391938,"avatar_url":"https://avatars1.githubusercontent.com/u/1391938?v=4","gravatar_id":"","url":"https://api.github.com/users/sky-uk","html_url":"https://github.com/sky-uk","followers_url":"https://api.github.com/users/sky-uk/followers","following_url":"https://api.github.com/users/sky-uk/following{/other_user}","gists_url":"https://api.github.com/users/sky-uk/gists{/gist_id}","starred_url":"https://api.github.com/users/sky-uk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sky-uk/subscriptions","organizations_url":"https://api.github.com/users/sky-uk/orgs","repos_url":"https://api.github.com/users/sky-uk/repos","events_url":"https://api.github.com/users/sky-uk/events{/privacy}","received_events_url":"https://api.github.com/users/sky-uk/received_events","type":"Organization","site_admin":false},"repo":{"id":58119137,"name":"feed","full_name":"sky-uk/feed","owner":{"login":"sky-uk","id":1391938,"avatar_url":"https://avatars1.githubusercontent.com/u/1391938?v=4","gravatar_id":"","url":"https://api.github.com/users/sky-uk","html_url":"https://github.com/sky-uk","followers_url":"https://api.github.com/users/sky-uk/followers","following_url":"https://api.github.com/users/sky-uk/following{/other_user}","gists_url":"https://api.github.com/users/sky-uk/gists{/gist_id}","starred_url":"https://api.github.com/users/sky-uk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sky-uk/subscriptions","organizations_url":"https://api.github.com/users/sky-uk/orgs","repos_url":"https://api.github.com/users/sky-uk/repos","events_url":"https://api.github.com/users/sky-uk/events{/privacy}","received_events_url":"https://api.github.com/users/sky-uk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sky-uk/feed","description":"Nginx based Kubernetes ingress controller for AWS","fork":false,"url":"https://api.github.com/repos/sky-uk/feed","forks_url":"https://api.github.com/repos/sky-uk/feed/forks","keys_url":"https://api.github.com/repos/sky-uk/feed/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sky-uk/feed/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sky-uk/feed/teams","hooks_url":"https://api.github.com/repos/sky-uk/feed/hooks","issue_events_url":"https://api.github.com/repos/sky-uk/feed/issues/events{/number}","events_url":"https://api.github.com/repos/sky-uk/feed/events","assignees_url":"https://api.github.com/repos/sky-uk/feed/assignees{/user}","branches_url":"https://api.github.com/repos/sky-uk/feed/branches{/branch}","tags_url":"https://api.github.com/repos/sky-uk/feed/tags","blobs_url":"https://api.github.com/repos/sky-uk/feed/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sky-uk/feed/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sky-uk/feed/git/refs{/sha}","trees_url":"https://api.github.com/repos/sky-uk/feed/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sky-uk/feed/statuses/{sha}","languages_url":"https://api.github.com/repos/sky-uk/feed/languages","stargazers_url":"https://api.github.com/repos/sky-uk/feed/stargazers","contributors_url":"https://api.github.com/repos/sky-uk/feed/contributors","subscribers_url":"https://api.github.com/repos/sky-uk/feed/subscribers","subscription_url":"https://api.github.com/repos/sky-uk/feed/subscription","commits_url":"https://api.github.com/repos/sky-uk/feed/commits{/sha}","git_commits_url":"https://api.github.com/repos/sky-uk/feed/git/commits{/sha}","comments_url":"https://api.github.com/repos/sky-uk/feed/comments{/number}","issue_comment_url":"https://api.github.com/repos/sky-uk/feed/issues/comments{/number}","contents_url":"https://api.github.com/repos/sky-uk/feed/contents/{+path}","compare_url":"https://api.github.com/repos/sky-uk/feed/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sky-uk/feed/merges","archive_url":"https://api.github.com/repos/sky-uk/feed/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sky-uk/feed/downloads","issues_url":"https://api.github.com/repos/sky-uk/feed/issues{/number}","pulls_url":"https://api.github.com/repos/sky-uk/feed/pulls{/number}","milestones_url":"https://api.github.com/repos/sky-uk/feed/milestones{/number}","notifications_url":"https://api.github.com/repos/sky-uk/feed/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sky-uk/feed/labels{/name}","releases_url":"https://api.github.com/repos/sky-uk/feed/releases{/id}","deployments_url":"https://api.github.com/repos/sky-uk/feed/deployments","created_at":"2016-05-05T09:14:33Z","updated_at":"2017-11-02T16:26:56Z","pushed_at":"2017-11-27T16:51:04Z","git_url":"git://github.com/sky-uk/feed.git","ssh_url":"git@github.com:sky-uk/feed.git","clone_url":"https://github.com/sky-uk/feed.git","svn_url":"https://github.com/sky-uk/feed","homepage":"","size":5005,"stargazers_count":43,"watchers_count":43,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":2,"forks":3,"open_issues":2,"watchers":43,"default_branch":"master"}},"base":{"label":"sky-uk:master","ref":"master","sha":"f42179cbb335506080ad0e8941172b0eea7426cc","user":{"login":"sky-uk","id":1391938,"avatar_url":"https://avatars1.githubusercontent.com/u/1391938?v=4","gravatar_id":"","url":"https://api.github.com/users/sky-uk","html_url":"https://github.com/sky-uk","followers_url":"https://api.github.com/users/sky-uk/followers","following_url":"https://api.github.com/users/sky-uk/following{/other_user}","gists_url":"https://api.github.com/users/sky-uk/gists{/gist_id}","starred_url":"https://api.github.com/users/sky-uk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sky-uk/subscriptions","organizations_url":"https://api.github.com/users/sky-uk/orgs","repos_url":"https://api.github.com/users/sky-uk/repos","events_url":"https://api.github.com/users/sky-uk/events{/privacy}","received_events_url":"https://api.github.com/users/sky-uk/received_events","type":"Organization","site_admin":false},"repo":{"id":58119137,"name":"feed","full_name":"sky-uk/feed","owner":{"login":"sky-uk","id":1391938,"avatar_url":"https://avatars1.githubusercontent.com/u/1391938?v=4","gravatar_id":"","url":"https://api.github.com/users/sky-uk","html_url":"https://github.com/sky-uk","followers_url":"https://api.github.com/users/sky-uk/followers","following_url":"https://api.github.com/users/sky-uk/following{/other_user}","gists_url":"https://api.github.com/users/sky-uk/gists{/gist_id}","starred_url":"https://api.github.com/users/sky-uk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sky-uk/subscriptions","organizations_url":"https://api.github.com/users/sky-uk/orgs","repos_url":"https://api.github.com/users/sky-uk/repos","events_url":"https://api.github.com/users/sky-uk/events{/privacy}","received_events_url":"https://api.github.com/users/sky-uk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sky-uk/feed","description":"Nginx based Kubernetes ingress controller for AWS","fork":false,"url":"https://api.github.com/repos/sky-uk/feed","forks_url":"https://api.github.com/repos/sky-uk/feed/forks","keys_url":"https://api.github.com/repos/sky-uk/feed/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sky-uk/feed/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sky-uk/feed/teams","hooks_url":"https://api.github.com/repos/sky-uk/feed/hooks","issue_events_url":"https://api.github.com/repos/sky-uk/feed/issues/events{/number}","events_url":"https://api.github.com/repos/sky-uk/feed/events","assignees_url":"https://api.github.com/repos/sky-uk/feed/assignees{/user}","branches_url":"https://api.github.com/repos/sky-uk/feed/branches{/branch}","tags_url":"https://api.github.com/repos/sky-uk/feed/tags","blobs_url":"https://api.github.com/repos/sky-uk/feed/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sky-uk/feed/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sky-uk/feed/git/refs{/sha}","trees_url":"https://api.github.com/repos/sky-uk/feed/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sky-uk/feed/statuses/{sha}","languages_url":"https://api.github.com/repos/sky-uk/feed/languages","stargazers_url":"https://api.github.com/repos/sky-uk/feed/stargazers","contributors_url":"https://api.github.com/repos/sky-uk/feed/contributors","subscribers_url":"https://api.github.com/repos/sky-uk/feed/subscribers","subscription_url":"https://api.github.com/repos/sky-uk/feed/subscription","commits_url":"https://api.github.com/repos/sky-uk/feed/commits{/sha}","git_commits_url":"https://api.github.com/repos/sky-uk/feed/git/commits{/sha}","comments_url":"https://api.github.com/repos/sky-uk/feed/comments{/number}","issue_comment_url":"https://api.github.com/repos/sky-uk/feed/issues/comments{/number}","contents_url":"https://api.github.com/repos/sky-uk/feed/contents/{+path}","compare_url":"https://api.github.com/repos/sky-uk/feed/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sky-uk/feed/merges","archive_url":"https://api.github.com/repos/sky-uk/feed/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sky-uk/feed/downloads","issues_url":"https://api.github.com/repos/sky-uk/feed/issues{/number}","pulls_url":"https://api.github.com/repos/sky-uk/feed/pulls{/number}","milestones_url":"https://api.github.com/repos/sky-uk/feed/milestones{/number}","notifications_url":"https://api.github.com/repos/sky-uk/feed/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sky-uk/feed/labels{/name}","releases_url":"https://api.github.com/repos/sky-uk/feed/releases{/id}","deployments_url":"https://api.github.com/repos/sky-uk/feed/deployments","created_at":"2016-05-05T09:14:33Z","updated_at":"2017-11-02T16:26:56Z","pushed_at":"2017-11-27T16:51:04Z","git_url":"git://github.com/sky-uk/feed.git","ssh_url":"git@github.com:sky-uk/feed.git","clone_url":"https://github.com/sky-uk/feed.git","svn_url":"https://github.com/sky-uk/feed","homepage":"","size":5005,"stargazers_count":43,"watchers_count":43,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":2,"forks":3,"open_issues":2,"watchers":43,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sky-uk/feed/pulls/162"},"html":{"href":"https://github.com/sky-uk/feed/pull/162"},"issue":{"href":"https://api.github.com/repos/sky-uk/feed/issues/162"},"comments":{"href":"https://api.github.com/repos/sky-uk/feed/issues/162/comments"},"review_comments":{"href":"https://api.github.com/repos/sky-uk/feed/pulls/162/comments"},"review_comment":{"href":"https://api.github.com/repos/sky-uk/feed/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sky-uk/feed/pulls/162/commits"},"statuses":{"href":"https://api.github.com/repos/sky-uk/feed/statuses/5d1d6dc53ec19221550310534ca6059687f1e516"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jsravn"}}