{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/6876","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/6876/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/6876/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/6876/events","html_url":"https://github.com/nodejs/node/pull/6876","id":155734604,"number":6876,"title":"build: fix cross-compile issue for Android","user":{"login":"robertchiras","id":6917800,"avatar_url":"https://avatars0.githubusercontent.com/u/6917800?v=3","gravatar_id":"","url":"https://api.github.com/users/robertchiras","html_url":"https://github.com/robertchiras","followers_url":"https://api.github.com/users/robertchiras/followers","following_url":"https://api.github.com/users/robertchiras/following{/other_user}","gists_url":"https://api.github.com/users/robertchiras/gists{/gist_id}","starred_url":"https://api.github.com/users/robertchiras/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertchiras/subscriptions","organizations_url":"https://api.github.com/users/robertchiras/orgs","repos_url":"https://api.github.com/users/robertchiras/repos","events_url":"https://api.github.com/users/robertchiras/events{/privacy}","received_events_url":"https://api.github.com/users/robertchiras/received_events","type":"User","site_admin":false},"labels":[{"id":235882965,"url":"https://api.github.com/repos/nodejs/node/labels/arm","name":"arm","color":"9944dd","default":false},{"id":171787391,"url":"https://api.github.com/repos/nodejs/node/labels/build","name":"build","color":"eb6420","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2016-05-19T13:18:48Z","updated_at":"2017-03-01T01:26:03Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/6876","html_url":"https://github.com/nodejs/node/pull/6876","diff_url":"https://github.com/nodejs/node/pull/6876.diff","patch_url":"https://github.com/nodejs/node/pull/6876.patch"},"body":"<!--\nThank you for your pull request. Please review below requirements and walk\nthrough the checklist. You can 'tick' a box by using the letter \"x\": [x].\n\nRun the test suite with: `make -j4 test` on UNIX or `vcbuild test nosign` on\nWindows.\n\nIf this aims to fix a regression or you’re adding a feature, make sure you also\nwrite a test. If possible, include a benchmark that quantifies your changes.\n\nFinally, read through our contributors guide and make adjustments as necessary:\nhttps://github.com/nodejs/node/blob/master/CONTRIBUTING.md\n-->\n##### Checklist\n\n<!-- remove lines that do not apply to you -->\n- [x] tests and code linting passes\n- [ ] a test and/or benchmark is included\n- [ ] documentation is changed or added\n- [x] the commit message follows commit guidelines\n##### Affected core subsystem(s)\n\n<!-- provide affected core subsystem(s) (like doc, cluster, crypto, etc) -->\n\nbuild\n##### Description of change\n\n<!-- provide a description of the change below this comment -->\n\nSome tools from icu are building host binaries, which are failing\nbecause the current logic is using the target_arch.\nSo, I added _host exports to local build tools in order to use them,\nwhen building host binaries.\nAlso, in the commin.gypi file, we need to take care of the current\ntoolset used when generating makefiles. This needs to be done, so that\nwe will use the host_arch when generating makefiles for host and\ntarget_arch when generating makefiles for target.\nAlso, removed the unnecessary define '_GLIBCXX_USE_C99_MATH'.\n\nSigned-off-by: Robert Chiras robert.chiras@intel.com\n"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/283216026","html_url":"https://github.com/nodejs/node/pull/6876#issuecomment-283216026","issue_url":"https://api.github.com/repos/nodejs/node/issues/6876","id":283216026,"user":{"login":"jasnell","id":439929,"avatar_url":"https://avatars1.githubusercontent.com/u/439929?v=3","gravatar_id":"","url":"https://api.github.com/users/jasnell","html_url":"https://github.com/jasnell","followers_url":"https://api.github.com/users/jasnell/followers","following_url":"https://api.github.com/users/jasnell/following{/other_user}","gists_url":"https://api.github.com/users/jasnell/gists{/gist_id}","starred_url":"https://api.github.com/users/jasnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasnell/subscriptions","organizations_url":"https://api.github.com/users/jasnell/orgs","repos_url":"https://api.github.com/users/jasnell/repos","events_url":"https://api.github.com/users/jasnell/events{/privacy}","received_events_url":"https://api.github.com/users/jasnell/received_events","type":"User","site_admin":false},"created_at":"2017-03-01T01:26:03Z","updated_at":"2017-03-01T01:26:03Z","body":"Is this still necessary?"}}
{"actor":{"display_login":"jasnell"}}