{"action":"created","comment":{"url":"https://api.github.com/repos/prestodb/presto/pulls/comments/101805368","pull_request_review_id":22542111,"id":101805368,"diff_hunk":"@@ -1457,6 +1462,93 @@ protected Node aggregateResult(Node aggregate, Node nextResult)\n         throw new UnsupportedOperationException(\"not yet implemented\");\n     }\n \n+    private static String decodeString(SqlBaseParser.UnicodeStringContext context)\n+    {\n+        final char delimiter;\n+        if (context.UESCAPE() != null) {\n+            String delimiterString = context.BASIC_STRING().getText();\n+            if (delimiterString.length() != 3) {\n+                throw parseError(\"Invalid escaped delimiter: \" + delimiterString, context);\n+            }\n+            delimiter = unquote(delimiterString).charAt(0);\n+            if (isHexDigit(delimiter) || delimiter == '\"' || delimiter == '+' || delimiter == ' ') {","path":"presto-parser/src/main/java/com/facebook/presto/sql/parser/AstBuilder.java","position":84,"original_position":84,"commit_id":"d033403df552d3efbe46865d4af2f150a9020049","original_commit_id":"d033403df552d3efbe46865d4af2f150a9020049","user":{"login":"electrum","id":9230,"avatar_url":"https://avatars.githubusercontent.com/u/9230?v=3","gravatar_id":"","url":"https://api.github.com/users/electrum","html_url":"https://github.com/electrum","followers_url":"https://api.github.com/users/electrum/followers","following_url":"https://api.github.com/users/electrum/following{/other_user}","gists_url":"https://api.github.com/users/electrum/gists{/gist_id}","starred_url":"https://api.github.com/users/electrum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electrum/subscriptions","organizations_url":"https://api.github.com/users/electrum/orgs","repos_url":"https://api.github.com/users/electrum/repos","events_url":"https://api.github.com/users/electrum/events{/privacy}","received_events_url":"https://api.github.com/users/electrum/received_events","type":"User","site_admin":false},"body":"Let's also check for `Character.isISOControl()`","created_at":"2017-02-17T17:27:07Z","updated_at":"2017-02-17T17:55:35Z","html_url":"https://github.com/prestodb/presto/pull/7357#discussion_r101805368","pull_request_url":"https://api.github.com/repos/prestodb/presto/pulls/7357","_links":{"self":{"href":"https://api.github.com/repos/prestodb/presto/pulls/comments/101805368"},"html":{"href":"https://github.com/prestodb/presto/pull/7357#discussion_r101805368"},"pull_request":{"href":"https://api.github.com/repos/prestodb/presto/pulls/7357"}}},"pull_request":{"url":"https://api.github.com/repos/prestodb/presto/pulls/7357","id":105964703,"html_url":"https://github.com/prestodb/presto/pull/7357","diff_url":"https://github.com/prestodb/presto/pull/7357.diff","patch_url":"https://github.com/prestodb/presto/pull/7357.patch","issue_url":"https://api.github.com/repos/prestodb/presto/issues/7357","number":7357,"state":"open","locked":false,"title":"Support Unicode escaped strings","user":{"login":"highker","id":2192913,"avatar_url":"https://avatars.githubusercontent.com/u/2192913?v=3","gravatar_id":"","url":"https://api.github.com/users/highker","html_url":"https://github.com/highker","followers_url":"https://api.github.com/users/highker/followers","following_url":"https://api.github.com/users/highker/following{/other_user}","gists_url":"https://api.github.com/users/highker/gists{/gist_id}","starred_url":"https://api.github.com/users/highker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highker/subscriptions","organizations_url":"https://api.github.com/users/highker/orgs","repos_url":"https://api.github.com/users/highker/repos","events_url":"https://api.github.com/users/highker/events{/privacy}","received_events_url":"https://api.github.com/users/highker/received_events","type":"User","site_admin":false},"body":"Incorporate strings with escaped unicode characters. The string can be a\r\nmix of escaped characters and normal unicode characters. An escaped\r\ncharacter can be either of length 4 or 6 in hex. No surrogate pairs are\r\nsupported at this point.","created_at":"2017-02-13T19:42:47Z","updated_at":"2017-02-17T17:55:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2571f3b2b336b205c2337a35afc63f78bd09a891","assignee":{"login":"haozhun","id":2020503,"avatar_url":"https://avatars.githubusercontent.com/u/2020503?v=3","gravatar_id":"","url":"https://api.github.com/users/haozhun","html_url":"https://github.com/haozhun","followers_url":"https://api.github.com/users/haozhun/followers","following_url":"https://api.github.com/users/haozhun/following{/other_user}","gists_url":"https://api.github.com/users/haozhun/gists{/gist_id}","starred_url":"https://api.github.com/users/haozhun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haozhun/subscriptions","organizations_url":"https://api.github.com/users/haozhun/orgs","repos_url":"https://api.github.com/users/haozhun/repos","events_url":"https://api.github.com/users/haozhun/events{/privacy}","received_events_url":"https://api.github.com/users/haozhun/received_events","type":"User","site_admin":false},"assignees":[{"login":"haozhun","id":2020503,"avatar_url":"https://avatars.githubusercontent.com/u/2020503?v=3","gravatar_id":"","url":"https://api.github.com/users/haozhun","html_url":"https://github.com/haozhun","followers_url":"https://api.github.com/users/haozhun/followers","following_url":"https://api.github.com/users/haozhun/following{/other_user}","gists_url":"https://api.github.com/users/haozhun/gists{/gist_id}","starred_url":"https://api.github.com/users/haozhun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haozhun/subscriptions","organizations_url":"https://api.github.com/users/haozhun/orgs","repos_url":"https://api.github.com/users/haozhun/repos","events_url":"https://api.github.com/users/haozhun/events{/privacy}","received_events_url":"https://api.github.com/users/haozhun/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/prestodb/presto/pulls/7357/commits","review_comments_url":"https://api.github.com/repos/prestodb/presto/pulls/7357/comments","review_comment_url":"https://api.github.com/repos/prestodb/presto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/prestodb/presto/issues/7357/comments","statuses_url":"https://api.github.com/repos/prestodb/presto/statuses/d033403df552d3efbe46865d4af2f150a9020049","head":{"label":"highker:escUni","ref":"escUni","sha":"d033403df552d3efbe46865d4af2f150a9020049","user":{"login":"highker","id":2192913,"avatar_url":"https://avatars.githubusercontent.com/u/2192913?v=3","gravatar_id":"","url":"https://api.github.com/users/highker","html_url":"https://github.com/highker","followers_url":"https://api.github.com/users/highker/followers","following_url":"https://api.github.com/users/highker/following{/other_user}","gists_url":"https://api.github.com/users/highker/gists{/gist_id}","starred_url":"https://api.github.com/users/highker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highker/subscriptions","organizations_url":"https://api.github.com/users/highker/orgs","repos_url":"https://api.github.com/users/highker/repos","events_url":"https://api.github.com/users/highker/events{/privacy}","received_events_url":"https://api.github.com/users/highker/received_events","type":"User","site_admin":false},"repo":{"id":80803020,"name":"presto","full_name":"highker/presto","owner":{"login":"highker","id":2192913,"avatar_url":"https://avatars.githubusercontent.com/u/2192913?v=3","gravatar_id":"","url":"https://api.github.com/users/highker","html_url":"https://github.com/highker","followers_url":"https://api.github.com/users/highker/followers","following_url":"https://api.github.com/users/highker/following{/other_user}","gists_url":"https://api.github.com/users/highker/gists{/gist_id}","starred_url":"https://api.github.com/users/highker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highker/subscriptions","organizations_url":"https://api.github.com/users/highker/orgs","repos_url":"https://api.github.com/users/highker/repos","events_url":"https://api.github.com/users/highker/events{/privacy}","received_events_url":"https://api.github.com/users/highker/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/highker/presto","description":"Distributed SQL query engine for big data","fork":true,"url":"https://api.github.com/repos/highker/presto","forks_url":"https://api.github.com/repos/highker/presto/forks","keys_url":"https://api.github.com/repos/highker/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/highker/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/highker/presto/teams","hooks_url":"https://api.github.com/repos/highker/presto/hooks","issue_events_url":"https://api.github.com/repos/highker/presto/issues/events{/number}","events_url":"https://api.github.com/repos/highker/presto/events","assignees_url":"https://api.github.com/repos/highker/presto/assignees{/user}","branches_url":"https://api.github.com/repos/highker/presto/branches{/branch}","tags_url":"https://api.github.com/repos/highker/presto/tags","blobs_url":"https://api.github.com/repos/highker/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/highker/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/highker/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/highker/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/highker/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/highker/presto/languages","stargazers_url":"https://api.github.com/repos/highker/presto/stargazers","contributors_url":"https://api.github.com/repos/highker/presto/contributors","subscribers_url":"https://api.github.com/repos/highker/presto/subscribers","subscription_url":"https://api.github.com/repos/highker/presto/subscription","commits_url":"https://api.github.com/repos/highker/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/highker/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/highker/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/highker/presto/issues/comments{/number}","contents_url":"https://api.github.com/repos/highker/presto/contents/{+path}","compare_url":"https://api.github.com/repos/highker/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/highker/presto/merges","archive_url":"https://api.github.com/repos/highker/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/highker/presto/downloads","issues_url":"https://api.github.com/repos/highker/presto/issues{/number}","pulls_url":"https://api.github.com/repos/highker/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/highker/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/highker/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/highker/presto/labels{/name}","releases_url":"https://api.github.com/repos/highker/presto/releases{/id}","deployments_url":"https://api.github.com/repos/highker/presto/deployments","created_at":"2017-02-03T06:22:03Z","updated_at":"2017-02-03T06:22:18Z","pushed_at":"2017-02-17T01:58:32Z","git_url":"git://github.com/highker/presto.git","ssh_url":"git@github.com:highker/presto.git","clone_url":"https://github.com/highker/presto.git","svn_url":"https://github.com/highker/presto","homepage":"https://prestodb.io","size":67181,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"prestodb:master","ref":"master","sha":"15451da30a53865812ed14feaa82ee37d231e471","user":{"login":"prestodb","id":6882181,"avatar_url":"https://avatars.githubusercontent.com/u/6882181?v=3","gravatar_id":"","url":"https://api.github.com/users/prestodb","html_url":"https://github.com/prestodb","followers_url":"https://api.github.com/users/prestodb/followers","following_url":"https://api.github.com/users/prestodb/following{/other_user}","gists_url":"https://api.github.com/users/prestodb/gists{/gist_id}","starred_url":"https://api.github.com/users/prestodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prestodb/subscriptions","organizations_url":"https://api.github.com/users/prestodb/orgs","repos_url":"https://api.github.com/users/prestodb/repos","events_url":"https://api.github.com/users/prestodb/events{/privacy}","received_events_url":"https://api.github.com/users/prestodb/received_events","type":"Organization","site_admin":false},"repo":{"id":5349565,"name":"presto","full_name":"prestodb/presto","owner":{"login":"prestodb","id":6882181,"avatar_url":"https://avatars.githubusercontent.com/u/6882181?v=3","gravatar_id":"","url":"https://api.github.com/users/prestodb","html_url":"https://github.com/prestodb","followers_url":"https://api.github.com/users/prestodb/followers","following_url":"https://api.github.com/users/prestodb/following{/other_user}","gists_url":"https://api.github.com/users/prestodb/gists{/gist_id}","starred_url":"https://api.github.com/users/prestodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prestodb/subscriptions","organizations_url":"https://api.github.com/users/prestodb/orgs","repos_url":"https://api.github.com/users/prestodb/repos","events_url":"https://api.github.com/users/prestodb/events{/privacy}","received_events_url":"https://api.github.com/users/prestodb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/prestodb/presto","description":"Distributed SQL query engine for big data","fork":false,"url":"https://api.github.com/repos/prestodb/presto","forks_url":"https://api.github.com/repos/prestodb/presto/forks","keys_url":"https://api.github.com/repos/prestodb/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prestodb/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prestodb/presto/teams","hooks_url":"https://api.github.com/repos/prestodb/presto/hooks","issue_events_url":"https://api.github.com/repos/prestodb/presto/issues/events{/number}","events_url":"https://api.github.com/repos/prestodb/presto/events","assignees_url":"https://api.github.com/repos/prestodb/presto/assignees{/user}","branches_url":"https://api.github.com/repos/prestodb/presto/branches{/branch}","tags_url":"https://api.github.com/repos/prestodb/presto/tags","blobs_url":"https://api.github.com/repos/prestodb/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prestodb/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prestodb/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/prestodb/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prestodb/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/prestodb/presto/languages","stargazers_url":"https://api.github.com/repos/prestodb/presto/stargazers","contributors_url":"https://api.github.com/repos/prestodb/presto/contributors","subscribers_url":"https://api.github.com/repos/prestodb/presto/subscribers","subscription_url":"https://api.github.com/repos/prestodb/presto/subscription","commits_url":"https://api.github.com/repos/prestodb/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/prestodb/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/prestodb/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/prestodb/presto/issues/comments{/number}","contents_url":"https://api.github.com/repos/prestodb/presto/contents/{+path}","compare_url":"https://api.github.com/repos/prestodb/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prestodb/presto/merges","archive_url":"https://api.github.com/repos/prestodb/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prestodb/presto/downloads","issues_url":"https://api.github.com/repos/prestodb/presto/issues{/number}","pulls_url":"https://api.github.com/repos/prestodb/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/prestodb/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/prestodb/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prestodb/presto/labels{/name}","releases_url":"https://api.github.com/repos/prestodb/presto/releases{/id}","deployments_url":"https://api.github.com/repos/prestodb/presto/deployments","created_at":"2012-08-09T01:03:37Z","updated_at":"2017-02-17T11:54:47Z","pushed_at":"2017-02-17T16:57:46Z","git_url":"git://github.com/prestodb/presto.git","ssh_url":"git@github.com:prestodb/presto.git","clone_url":"https://github.com/prestodb/presto.git","svn_url":"https://github.com/prestodb/presto","homepage":"https://prestodb.io","size":67341,"stargazers_count":5620,"watchers_count":5620,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1796,"mirror_url":null,"open_issues_count":917,"forks":1796,"open_issues":917,"watchers":5620,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prestodb/presto/pulls/7357"},"html":{"href":"https://github.com/prestodb/presto/pull/7357"},"issue":{"href":"https://api.github.com/repos/prestodb/presto/issues/7357"},"comments":{"href":"https://api.github.com/repos/prestodb/presto/issues/7357/comments"},"review_comments":{"href":"https://api.github.com/repos/prestodb/presto/pulls/7357/comments"},"review_comment":{"href":"https://api.github.com/repos/prestodb/presto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/prestodb/presto/pulls/7357/commits"},"statuses":{"href":"https://api.github.com/repos/prestodb/presto/statuses/d033403df552d3efbe46865d4af2f150a9020049"}}}}
{"actor":{"display_login":"electrum"}}