{"action":"created","comment":{"url":"https://api.github.com/repos/solidusio/solidus/pulls/comments/126769935","pull_request_review_id":49286461,"id":126769935,"diff_hunk":"@@ -189,8 +189,12 @@ var ShipmentSplitItemView = Backbone.View.extend({\n     }\n     jqXHR.error(function(msg) {\n       alert(Spree.t(\"split_failed\"));\n-    }).done(function() {\n-      window.Spree.advanceOrder();\n+    }).done(function(response) {\n+      if (response.success) {\n+        window.Spree.advanceOrder();\n+      } else {\n+        alert(response.message);","path":"backend/app/assets/javascripts/spree/backend/shipments.js","position":10,"original_position":10,"commit_id":"7adba794fa0b640a09246a1f9d8fe8f8150ea0ac","original_commit_id":"80132ab4c26c429b8fa9d7117c1899b5aa87b0ef","user":{"login":"tvdeyen","id":42868,"avatar_url":"https://avatars3.githubusercontent.com/u/42868?v=3","gravatar_id":"","url":"https://api.github.com/users/tvdeyen","html_url":"https://github.com/tvdeyen","followers_url":"https://api.github.com/users/tvdeyen/followers","following_url":"https://api.github.com/users/tvdeyen/following{/other_user}","gists_url":"https://api.github.com/users/tvdeyen/gists{/gist_id}","starred_url":"https://api.github.com/users/tvdeyen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tvdeyen/subscriptions","organizations_url":"https://api.github.com/users/tvdeyen/orgs","repos_url":"https://api.github.com/users/tvdeyen/repos","events_url":"https://api.github.com/users/tvdeyen/events{/privacy}","received_events_url":"https://api.github.com/users/tvdeyen/received_events","type":"User","site_admin":false},"body":"Sure","created_at":"2017-07-11T18:22:59Z","updated_at":"2017-07-11T18:22:59Z","html_url":"https://github.com/solidusio/solidus/pull/2070#discussion_r126769935","pull_request_url":"https://api.github.com/repos/solidusio/solidus/pulls/2070","_links":{"self":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/comments/126769935"},"html":{"href":"https://github.com/solidusio/solidus/pull/2070#discussion_r126769935"},"pull_request":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/2070"}}},"pull_request":{"url":"https://api.github.com/repos/solidusio/solidus/pulls/2070","id":129420433,"html_url":"https://github.com/solidusio/solidus/pull/2070","diff_url":"https://github.com/solidusio/solidus/pull/2070.diff","patch_url":"https://github.com/solidusio/solidus/pull/2070.patch","issue_url":"https://api.github.com/repos/solidusio/solidus/issues/2070","number":2070,"state":"open","locked":false,"title":"[RfC] Add FulfillmentChanger","user":{"login":"mamhoff","id":703401,"avatar_url":"https://avatars1.githubusercontent.com/u/703401?v=3","gravatar_id":"","url":"https://api.github.com/users/mamhoff","html_url":"https://github.com/mamhoff","followers_url":"https://api.github.com/users/mamhoff/followers","following_url":"https://api.github.com/users/mamhoff/following{/other_user}","gists_url":"https://api.github.com/users/mamhoff/gists{/gist_id}","starred_url":"https://api.github.com/users/mamhoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mamhoff/subscriptions","organizations_url":"https://api.github.com/users/mamhoff/orgs","repos_url":"https://api.github.com/users/mamhoff/repos","events_url":"https://api.github.com/users/mamhoff/events{/privacy}","received_events_url":"https://api.github.com/users/mamhoff/received_events","type":"User","site_admin":false},"body":"(built on top of #1906, without which this does not work either)\r\n\r\nThis class takes two shipments and moves a certain amount of stuff\r\nbetween them. This used to be called \"splitting\" a shipment, but really we\r\nare changing fulfillment for those variants, hence the name.\r\n\r\nThis will replace the `transfer_to_*` methods on `Spree::Shipment`. \r\n\r\nIt is designed to be quite a bit faster, since it does not move inventory units one by one, but in bulk.\r\n\r\nThere's a slight change in behaviour: When splitting a shipment such that the new shipment would have more inventory than the original one, that's not possible anymore, because I can't imagine a situation where that would be beneficial. \r\n\r\nI had to adjust one spec for the aforementioned change in behaviour. I also had to amend one spec so that the order starts out with only on_hand inventory units.","created_at":"2017-07-07T14:44:27Z","updated_at":"2017-07-11T18:22:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5241264675dac463242f2cce2e2bb7f8f293ad63","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/solidusio/solidus/pulls/2070/commits","review_comments_url":"https://api.github.com/repos/solidusio/solidus/pulls/2070/comments","review_comment_url":"https://api.github.com/repos/solidusio/solidus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/solidusio/solidus/issues/2070/comments","statuses_url":"https://api.github.com/repos/solidusio/solidus/statuses/7adba794fa0b640a09246a1f9d8fe8f8150ea0ac","head":{"label":"mamhoff:introduce-fulfilment-changer","ref":"introduce-fulfilment-changer","sha":"7adba794fa0b640a09246a1f9d8fe8f8150ea0ac","user":{"login":"mamhoff","id":703401,"avatar_url":"https://avatars1.githubusercontent.com/u/703401?v=3","gravatar_id":"","url":"https://api.github.com/users/mamhoff","html_url":"https://github.com/mamhoff","followers_url":"https://api.github.com/users/mamhoff/followers","following_url":"https://api.github.com/users/mamhoff/following{/other_user}","gists_url":"https://api.github.com/users/mamhoff/gists{/gist_id}","starred_url":"https://api.github.com/users/mamhoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mamhoff/subscriptions","organizations_url":"https://api.github.com/users/mamhoff/orgs","repos_url":"https://api.github.com/users/mamhoff/repos","events_url":"https://api.github.com/users/mamhoff/events{/privacy}","received_events_url":"https://api.github.com/users/mamhoff/received_events","type":"User","site_admin":false},"repo":{"id":53340856,"name":"solidus","full_name":"mamhoff/solidus","owner":{"login":"mamhoff","id":703401,"avatar_url":"https://avatars1.githubusercontent.com/u/703401?v=3","gravatar_id":"","url":"https://api.github.com/users/mamhoff","html_url":"https://github.com/mamhoff","followers_url":"https://api.github.com/users/mamhoff/followers","following_url":"https://api.github.com/users/mamhoff/following{/other_user}","gists_url":"https://api.github.com/users/mamhoff/gists{/gist_id}","starred_url":"https://api.github.com/users/mamhoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mamhoff/subscriptions","organizations_url":"https://api.github.com/users/mamhoff/orgs","repos_url":"https://api.github.com/users/mamhoff/repos","events_url":"https://api.github.com/users/mamhoff/events{/privacy}","received_events_url":"https://api.github.com/users/mamhoff/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mamhoff/solidus","description":"Solidus, Rails eCommerce System","fork":true,"url":"https://api.github.com/repos/mamhoff/solidus","forks_url":"https://api.github.com/repos/mamhoff/solidus/forks","keys_url":"https://api.github.com/repos/mamhoff/solidus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mamhoff/solidus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mamhoff/solidus/teams","hooks_url":"https://api.github.com/repos/mamhoff/solidus/hooks","issue_events_url":"https://api.github.com/repos/mamhoff/solidus/issues/events{/number}","events_url":"https://api.github.com/repos/mamhoff/solidus/events","assignees_url":"https://api.github.com/repos/mamhoff/solidus/assignees{/user}","branches_url":"https://api.github.com/repos/mamhoff/solidus/branches{/branch}","tags_url":"https://api.github.com/repos/mamhoff/solidus/tags","blobs_url":"https://api.github.com/repos/mamhoff/solidus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mamhoff/solidus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mamhoff/solidus/git/refs{/sha}","trees_url":"https://api.github.com/repos/mamhoff/solidus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mamhoff/solidus/statuses/{sha}","languages_url":"https://api.github.com/repos/mamhoff/solidus/languages","stargazers_url":"https://api.github.com/repos/mamhoff/solidus/stargazers","contributors_url":"https://api.github.com/repos/mamhoff/solidus/contributors","subscribers_url":"https://api.github.com/repos/mamhoff/solidus/subscribers","subscription_url":"https://api.github.com/repos/mamhoff/solidus/subscription","commits_url":"https://api.github.com/repos/mamhoff/solidus/commits{/sha}","git_commits_url":"https://api.github.com/repos/mamhoff/solidus/git/commits{/sha}","comments_url":"https://api.github.com/repos/mamhoff/solidus/comments{/number}","issue_comment_url":"https://api.github.com/repos/mamhoff/solidus/issues/comments{/number}","contents_url":"https://api.github.com/repos/mamhoff/solidus/contents/{+path}","compare_url":"https://api.github.com/repos/mamhoff/solidus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mamhoff/solidus/merges","archive_url":"https://api.github.com/repos/mamhoff/solidus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mamhoff/solidus/downloads","issues_url":"https://api.github.com/repos/mamhoff/solidus/issues{/number}","pulls_url":"https://api.github.com/repos/mamhoff/solidus/pulls{/number}","milestones_url":"https://api.github.com/repos/mamhoff/solidus/milestones{/number}","notifications_url":"https://api.github.com/repos/mamhoff/solidus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mamhoff/solidus/labels{/name}","releases_url":"https://api.github.com/repos/mamhoff/solidus/releases{/id}","deployments_url":"https://api.github.com/repos/mamhoff/solidus/deployments","created_at":"2016-03-07T16:34:34Z","updated_at":"2016-03-07T16:34:40Z","pushed_at":"2017-07-11T12:35:21Z","git_url":"git://github.com/mamhoff/solidus.git","ssh_url":"git@github.com:mamhoff/solidus.git","clone_url":"https://github.com/mamhoff/solidus.git","svn_url":"https://github.com/mamhoff/solidus","homepage":"http://solidus.io/","size":66462,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"solidusio:master","ref":"master","sha":"b8b2ccbcceae4c2166044a357abd447e51a68f2c","user":{"login":"solidusio","id":11045486,"avatar_url":"https://avatars2.githubusercontent.com/u/11045486?v=3","gravatar_id":"","url":"https://api.github.com/users/solidusio","html_url":"https://github.com/solidusio","followers_url":"https://api.github.com/users/solidusio/followers","following_url":"https://api.github.com/users/solidusio/following{/other_user}","gists_url":"https://api.github.com/users/solidusio/gists{/gist_id}","starred_url":"https://api.github.com/users/solidusio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solidusio/subscriptions","organizations_url":"https://api.github.com/users/solidusio/orgs","repos_url":"https://api.github.com/users/solidusio/repos","events_url":"https://api.github.com/users/solidusio/events{/privacy}","received_events_url":"https://api.github.com/users/solidusio/received_events","type":"Organization","site_admin":false},"repo":{"id":30985840,"name":"solidus","full_name":"solidusio/solidus","owner":{"login":"solidusio","id":11045486,"avatar_url":"https://avatars2.githubusercontent.com/u/11045486?v=3","gravatar_id":"","url":"https://api.github.com/users/solidusio","html_url":"https://github.com/solidusio","followers_url":"https://api.github.com/users/solidusio/followers","following_url":"https://api.github.com/users/solidusio/following{/other_user}","gists_url":"https://api.github.com/users/solidusio/gists{/gist_id}","starred_url":"https://api.github.com/users/solidusio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solidusio/subscriptions","organizations_url":"https://api.github.com/users/solidusio/orgs","repos_url":"https://api.github.com/users/solidusio/repos","events_url":"https://api.github.com/users/solidusio/events{/privacy}","received_events_url":"https://api.github.com/users/solidusio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/solidusio/solidus","description":"Solidus, Rails eCommerce System","fork":false,"url":"https://api.github.com/repos/solidusio/solidus","forks_url":"https://api.github.com/repos/solidusio/solidus/forks","keys_url":"https://api.github.com/repos/solidusio/solidus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/solidusio/solidus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/solidusio/solidus/teams","hooks_url":"https://api.github.com/repos/solidusio/solidus/hooks","issue_events_url":"https://api.github.com/repos/solidusio/solidus/issues/events{/number}","events_url":"https://api.github.com/repos/solidusio/solidus/events","assignees_url":"https://api.github.com/repos/solidusio/solidus/assignees{/user}","branches_url":"https://api.github.com/repos/solidusio/solidus/branches{/branch}","tags_url":"https://api.github.com/repos/solidusio/solidus/tags","blobs_url":"https://api.github.com/repos/solidusio/solidus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/solidusio/solidus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/solidusio/solidus/git/refs{/sha}","trees_url":"https://api.github.com/repos/solidusio/solidus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/solidusio/solidus/statuses/{sha}","languages_url":"https://api.github.com/repos/solidusio/solidus/languages","stargazers_url":"https://api.github.com/repos/solidusio/solidus/stargazers","contributors_url":"https://api.github.com/repos/solidusio/solidus/contributors","subscribers_url":"https://api.github.com/repos/solidusio/solidus/subscribers","subscription_url":"https://api.github.com/repos/solidusio/solidus/subscription","commits_url":"https://api.github.com/repos/solidusio/solidus/commits{/sha}","git_commits_url":"https://api.github.com/repos/solidusio/solidus/git/commits{/sha}","comments_url":"https://api.github.com/repos/solidusio/solidus/comments{/number}","issue_comment_url":"https://api.github.com/repos/solidusio/solidus/issues/comments{/number}","contents_url":"https://api.github.com/repos/solidusio/solidus/contents/{+path}","compare_url":"https://api.github.com/repos/solidusio/solidus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/solidusio/solidus/merges","archive_url":"https://api.github.com/repos/solidusio/solidus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/solidusio/solidus/downloads","issues_url":"https://api.github.com/repos/solidusio/solidus/issues{/number}","pulls_url":"https://api.github.com/repos/solidusio/solidus/pulls{/number}","milestones_url":"https://api.github.com/repos/solidusio/solidus/milestones{/number}","notifications_url":"https://api.github.com/repos/solidusio/solidus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/solidusio/solidus/labels{/name}","releases_url":"https://api.github.com/repos/solidusio/solidus/releases{/id}","deployments_url":"https://api.github.com/repos/solidusio/solidus/deployments","created_at":"2015-02-18T20:41:58Z","updated_at":"2017-07-10T09:22:52Z","pushed_at":"2017-07-11T17:33:08Z","git_url":"git://github.com/solidusio/solidus.git","ssh_url":"git@github.com:solidusio/solidus.git","clone_url":"https://github.com/solidusio/solidus.git","svn_url":"https://github.com/solidusio/solidus","homepage":"https://solidus.io/","size":66642,"stargazers_count":1452,"watchers_count":1452,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":468,"mirror_url":null,"open_issues_count":190,"forks":468,"open_issues":190,"watchers":1452,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/2070"},"html":{"href":"https://github.com/solidusio/solidus/pull/2070"},"issue":{"href":"https://api.github.com/repos/solidusio/solidus/issues/2070"},"comments":{"href":"https://api.github.com/repos/solidusio/solidus/issues/2070/comments"},"review_comments":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/2070/comments"},"review_comment":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/solidusio/solidus/pulls/2070/commits"},"statuses":{"href":"https://api.github.com/repos/solidusio/solidus/statuses/7adba794fa0b640a09246a1f9d8fe8f8150ea0ac"}}}}
{"actor":{"display_login":"tvdeyen"}}