{"action":"created","issue":{"url":"https://api.github.com/repos/semsol/arc2/issues/83","repository_url":"https://api.github.com/repos/semsol/arc2","labels_url":"https://api.github.com/repos/semsol/arc2/issues/83/labels{/name}","comments_url":"https://api.github.com/repos/semsol/arc2/issues/83/comments","events_url":"https://api.github.com/repos/semsol/arc2/issues/83/events","html_url":"https://github.com/semsol/arc2/pull/83","id":234530242,"number":83,"title":"Setup PHPUnit environment and fixed tests","user":{"login":"k00ni","id":381727,"avatar_url":"https://avatars0.githubusercontent.com/u/381727?v=3","gravatar_id":"","url":"https://api.github.com/users/k00ni","html_url":"https://github.com/k00ni","followers_url":"https://api.github.com/users/k00ni/followers","following_url":"https://api.github.com/users/k00ni/following{/other_user}","gists_url":"https://api.github.com/users/k00ni/gists{/gist_id}","starred_url":"https://api.github.com/users/k00ni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k00ni/subscriptions","organizations_url":"https://api.github.com/users/k00ni/orgs","repos_url":"https://api.github.com/users/k00ni/repos","events_url":"https://api.github.com/users/k00ni/events{/privacy}","received_events_url":"https://api.github.com/users/k00ni/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-06-08T13:37:50Z","updated_at":"2017-06-08T15:26:03Z","closed_at":"2017-06-08T15:03:04Z","pull_request":{"url":"https://api.github.com/repos/semsol/arc2/pulls/83","html_url":"https://github.com/semsol/arc2/pull/83","diff_url":"https://github.com/semsol/arc2/pull/83.diff","patch_url":"https://github.com/semsol/arc2/pull/83.patch"},"body":"**Summary:**\r\nI reworked the PHPUnit setup by first, adding it to composer.json and secondly, added a bootstrap.php in the test folder with basic includes.\r\n\r\nAfterwards i adapted some test classes to get the test suite going. From now on, to run the test suite, just install vendors using `composer update` and run `vendor/bin/phpunit` in the terminal:\r\n\r\n```\r\nbash-4.3# vendor/bin/phpunit\r\nPHPUnit 6.2.1 by Sebastian Bergmann and contributors.\r\n\r\nRuntime:       PHP 7.0.17 with Xdebug 2.5.4\r\nConfiguration: /var/www/html/phpunit.xml\r\n\r\n........................................                          40 / 40 (100%)\r\n\r\nTime: 93 ms, Memory: 6.00MB\r\n\r\nOK (40 tests, 114 assertions)\r\n```\r\n\r\n**Highlights:**\r\n\r\n* removed warnings like Notice: Only variables should be passed by reference in\r\n/var/www/html/tests/unit/ARC2_ClassTest.php on line 8\r\n* fixed problem Warning: array_merge(): Argument \\#1 is not an array in\r\n/var/www/html/vendor/phpunit/phpunit/src/Framework/TestCase.php on line 1064 for\r\nevery test case"},"comment":{"url":"https://api.github.com/repos/semsol/arc2/issues/comments/307138233","html_url":"https://github.com/semsol/arc2/pull/83#issuecomment-307138233","issue_url":"https://api.github.com/repos/semsol/arc2/issues/83","id":307138233,"user":{"login":"bnowack","id":893242,"avatar_url":"https://avatars3.githubusercontent.com/u/893242?v=3","gravatar_id":"","url":"https://api.github.com/users/bnowack","html_url":"https://github.com/bnowack","followers_url":"https://api.github.com/users/bnowack/followers","following_url":"https://api.github.com/users/bnowack/following{/other_user}","gists_url":"https://api.github.com/users/bnowack/gists{/gist_id}","starred_url":"https://api.github.com/users/bnowack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bnowack/subscriptions","organizations_url":"https://api.github.com/users/bnowack/orgs","repos_url":"https://api.github.com/users/bnowack/repos","events_url":"https://api.github.com/users/bnowack/events{/privacy}","received_events_url":"https://api.github.com/users/bnowack/received_events","type":"User","site_admin":false},"created_at":"2017-06-08T15:26:03Z","updated_at":"2017-06-08T15:26:03Z","body":"Awesome stuff, thank you. Must be a pain with all that outdated code..."}}
{"actor":{"display_login":"bnowack"}}