{"action":"opened","number":5177,"pull_request":{"url":"https://api.github.com/repos/qgis/QGIS/pulls/5177","id":140534492,"html_url":"https://github.com/qgis/QGIS/pull/5177","diff_url":"https://github.com/qgis/QGIS/pull/5177.diff","patch_url":"https://github.com/qgis/QGIS/pull/5177.patch","issue_url":"https://api.github.com/repos/qgis/QGIS/issues/5177","number":5177,"state":"open","locked":false,"title":"[processing] prevent float division by zero in QGIS algorithms","user":{"login":"alexbruy","id":776954,"avatar_url":"https://avatars0.githubusercontent.com/u/776954?v=4","gravatar_id":"","url":"https://api.github.com/users/alexbruy","html_url":"https://github.com/alexbruy","followers_url":"https://api.github.com/users/alexbruy/followers","following_url":"https://api.github.com/users/alexbruy/following{/other_user}","gists_url":"https://api.github.com/users/alexbruy/gists{/gist_id}","starred_url":"https://api.github.com/users/alexbruy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexbruy/subscriptions","organizations_url":"https://api.github.com/users/alexbruy/orgs","repos_url":"https://api.github.com/users/alexbruy/repos","events_url":"https://api.github.com/users/alexbruy/events{/privacy}","received_events_url":"https://api.github.com/users/alexbruy/received_events","type":"User","site_admin":false},"body":"## Description\r\nPrevent \"float division by zero\" errors in native QGIS algorithms when calculating progress. This fix for QGIS 2.18, as in maste these errors were fixed during Processing overhaul.\r\n\r\n## Checklist\r\n\r\n> Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.\r\n\r\n- [x] Commit messages are descriptive and explain the rationale for changes\r\n- [ ] Commits which fix bugs include `fixes #11111` in the commit message next to the description\r\n- [ ] Commits which add new features are tagged with `[FEATURE]` in the commit message\r\n- [ ] Commits which change the UI or existing user workflows are tagged with `[needs-docs]` in the commit message and containt sufficient information in the commit message to be documented\r\n- [x] I have read the [QGIS Coding Standards](https://docs.qgis.org/testing/en/docs/developers_guide/codingstandards.html) and this PR complies with them\r\n- [ ] This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)\r\n- [ ] New unit tests have been added for core changes\r\n- [x] I have run [the `scripts/prepare-commit.sh` script](https://github.com/qgis/QGIS/blob/master/.github/CONTRIBUTE.md#contributing-to-qgis) before each commit\r\n","created_at":"2017-09-12T09:49:25Z","updated_at":"2017-09-12T09:49:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/qgis/QGIS/pulls/5177/commits","review_comments_url":"https://api.github.com/repos/qgis/QGIS/pulls/5177/comments","review_comment_url":"https://api.github.com/repos/qgis/QGIS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/qgis/QGIS/issues/5177/comments","statuses_url":"https://api.github.com/repos/qgis/QGIS/statuses/8c46e4be740fa6d937e987dd4c553cf16344893a","head":{"label":"alexbruy:fix-zero-division","ref":"fix-zero-division","sha":"8c46e4be740fa6d937e987dd4c553cf16344893a","user":{"login":"alexbruy","id":776954,"avatar_url":"https://avatars0.githubusercontent.com/u/776954?v=4","gravatar_id":"","url":"https://api.github.com/users/alexbruy","html_url":"https://github.com/alexbruy","followers_url":"https://api.github.com/users/alexbruy/followers","following_url":"https://api.github.com/users/alexbruy/following{/other_user}","gists_url":"https://api.github.com/users/alexbruy/gists{/gist_id}","starred_url":"https://api.github.com/users/alexbruy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexbruy/subscriptions","organizations_url":"https://api.github.com/users/alexbruy/orgs","repos_url":"https://api.github.com/users/alexbruy/repos","events_url":"https://api.github.com/users/alexbruy/events{/privacy}","received_events_url":"https://api.github.com/users/alexbruy/received_events","type":"User","site_admin":false},"repo":{"id":18325972,"name":"QGIS","full_name":"alexbruy/QGIS","owner":{"login":"alexbruy","id":776954,"avatar_url":"https://avatars0.githubusercontent.com/u/776954?v=4","gravatar_id":"","url":"https://api.github.com/users/alexbruy","html_url":"https://github.com/alexbruy","followers_url":"https://api.github.com/users/alexbruy/followers","following_url":"https://api.github.com/users/alexbruy/following{/other_user}","gists_url":"https://api.github.com/users/alexbruy/gists{/gist_id}","starred_url":"https://api.github.com/users/alexbruy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexbruy/subscriptions","organizations_url":"https://api.github.com/users/alexbruy/orgs","repos_url":"https://api.github.com/users/alexbruy/repos","events_url":"https://api.github.com/users/alexbruy/events{/privacy}","received_events_url":"https://api.github.com/users/alexbruy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alexbruy/QGIS","description":"QGIS is a free, open source, cross platform (lin/win/mac) geographical information system (GIS)","fork":true,"url":"https://api.github.com/repos/alexbruy/QGIS","forks_url":"https://api.github.com/repos/alexbruy/QGIS/forks","keys_url":"https://api.github.com/repos/alexbruy/QGIS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alexbruy/QGIS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alexbruy/QGIS/teams","hooks_url":"https://api.github.com/repos/alexbruy/QGIS/hooks","issue_events_url":"https://api.github.com/repos/alexbruy/QGIS/issues/events{/number}","events_url":"https://api.github.com/repos/alexbruy/QGIS/events","assignees_url":"https://api.github.com/repos/alexbruy/QGIS/assignees{/user}","branches_url":"https://api.github.com/repos/alexbruy/QGIS/branches{/branch}","tags_url":"https://api.github.com/repos/alexbruy/QGIS/tags","blobs_url":"https://api.github.com/repos/alexbruy/QGIS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alexbruy/QGIS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alexbruy/QGIS/git/refs{/sha}","trees_url":"https://api.github.com/repos/alexbruy/QGIS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alexbruy/QGIS/statuses/{sha}","languages_url":"https://api.github.com/repos/alexbruy/QGIS/languages","stargazers_url":"https://api.github.com/repos/alexbruy/QGIS/stargazers","contributors_url":"https://api.github.com/repos/alexbruy/QGIS/contributors","subscribers_url":"https://api.github.com/repos/alexbruy/QGIS/subscribers","subscription_url":"https://api.github.com/repos/alexbruy/QGIS/subscription","commits_url":"https://api.github.com/repos/alexbruy/QGIS/commits{/sha}","git_commits_url":"https://api.github.com/repos/alexbruy/QGIS/git/commits{/sha}","comments_url":"https://api.github.com/repos/alexbruy/QGIS/comments{/number}","issue_comment_url":"https://api.github.com/repos/alexbruy/QGIS/issues/comments{/number}","contents_url":"https://api.github.com/repos/alexbruy/QGIS/contents/{+path}","compare_url":"https://api.github.com/repos/alexbruy/QGIS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alexbruy/QGIS/merges","archive_url":"https://api.github.com/repos/alexbruy/QGIS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alexbruy/QGIS/downloads","issues_url":"https://api.github.com/repos/alexbruy/QGIS/issues{/number}","pulls_url":"https://api.github.com/repos/alexbruy/QGIS/pulls{/number}","milestones_url":"https://api.github.com/repos/alexbruy/QGIS/milestones{/number}","notifications_url":"https://api.github.com/repos/alexbruy/QGIS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alexbruy/QGIS/labels{/name}","releases_url":"https://api.github.com/repos/alexbruy/QGIS/releases{/id}","deployments_url":"https://api.github.com/repos/alexbruy/QGIS/deployments","created_at":"2014-04-01T10:38:48Z","updated_at":"2016-04-01T08:27:38Z","pushed_at":"2017-09-12T09:46:31Z","git_url":"git://github.com/alexbruy/QGIS.git","ssh_url":"git@github.com:alexbruy/QGIS.git","clone_url":"https://github.com/alexbruy/QGIS.git","svn_url":"https://github.com/alexbruy/QGIS","homepage":"http://qgis.org","size":1240123,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"qgis:release-2_18","ref":"release-2_18","sha":"592151f0b76dc4c4f365dbad3a3a1eab95f1fb8b","user":{"login":"qgis","id":483444,"avatar_url":"https://avatars3.githubusercontent.com/u/483444?v=4","gravatar_id":"","url":"https://api.github.com/users/qgis","html_url":"https://github.com/qgis","followers_url":"https://api.github.com/users/qgis/followers","following_url":"https://api.github.com/users/qgis/following{/other_user}","gists_url":"https://api.github.com/users/qgis/gists{/gist_id}","starred_url":"https://api.github.com/users/qgis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qgis/subscriptions","organizations_url":"https://api.github.com/users/qgis/orgs","repos_url":"https://api.github.com/users/qgis/repos","events_url":"https://api.github.com/users/qgis/events{/privacy}","received_events_url":"https://api.github.com/users/qgis/received_events","type":"Organization","site_admin":false},"repo":{"id":1690480,"name":"QGIS","full_name":"qgis/QGIS","owner":{"login":"qgis","id":483444,"avatar_url":"https://avatars3.githubusercontent.com/u/483444?v=4","gravatar_id":"","url":"https://api.github.com/users/qgis","html_url":"https://github.com/qgis","followers_url":"https://api.github.com/users/qgis/followers","following_url":"https://api.github.com/users/qgis/following{/other_user}","gists_url":"https://api.github.com/users/qgis/gists{/gist_id}","starred_url":"https://api.github.com/users/qgis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qgis/subscriptions","organizations_url":"https://api.github.com/users/qgis/orgs","repos_url":"https://api.github.com/users/qgis/repos","events_url":"https://api.github.com/users/qgis/events{/privacy}","received_events_url":"https://api.github.com/users/qgis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/qgis/QGIS","description":"QGIS is a free, open source, cross platform (lin/win/mac) geographical information system (GIS)","fork":false,"url":"https://api.github.com/repos/qgis/QGIS","forks_url":"https://api.github.com/repos/qgis/QGIS/forks","keys_url":"https://api.github.com/repos/qgis/QGIS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qgis/QGIS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qgis/QGIS/teams","hooks_url":"https://api.github.com/repos/qgis/QGIS/hooks","issue_events_url":"https://api.github.com/repos/qgis/QGIS/issues/events{/number}","events_url":"https://api.github.com/repos/qgis/QGIS/events","assignees_url":"https://api.github.com/repos/qgis/QGIS/assignees{/user}","branches_url":"https://api.github.com/repos/qgis/QGIS/branches{/branch}","tags_url":"https://api.github.com/repos/qgis/QGIS/tags","blobs_url":"https://api.github.com/repos/qgis/QGIS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qgis/QGIS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qgis/QGIS/git/refs{/sha}","trees_url":"https://api.github.com/repos/qgis/QGIS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qgis/QGIS/statuses/{sha}","languages_url":"https://api.github.com/repos/qgis/QGIS/languages","stargazers_url":"https://api.github.com/repos/qgis/QGIS/stargazers","contributors_url":"https://api.github.com/repos/qgis/QGIS/contributors","subscribers_url":"https://api.github.com/repos/qgis/QGIS/subscribers","subscription_url":"https://api.github.com/repos/qgis/QGIS/subscription","commits_url":"https://api.github.com/repos/qgis/QGIS/commits{/sha}","git_commits_url":"https://api.github.com/repos/qgis/QGIS/git/commits{/sha}","comments_url":"https://api.github.com/repos/qgis/QGIS/comments{/number}","issue_comment_url":"https://api.github.com/repos/qgis/QGIS/issues/comments{/number}","contents_url":"https://api.github.com/repos/qgis/QGIS/contents/{+path}","compare_url":"https://api.github.com/repos/qgis/QGIS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qgis/QGIS/merges","archive_url":"https://api.github.com/repos/qgis/QGIS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qgis/QGIS/downloads","issues_url":"https://api.github.com/repos/qgis/QGIS/issues{/number}","pulls_url":"https://api.github.com/repos/qgis/QGIS/pulls{/number}","milestones_url":"https://api.github.com/repos/qgis/QGIS/milestones{/number}","notifications_url":"https://api.github.com/repos/qgis/QGIS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qgis/QGIS/labels{/name}","releases_url":"https://api.github.com/repos/qgis/QGIS/releases{/id}","deployments_url":"https://api.github.com/repos/qgis/QGIS/deployments","created_at":"2011-05-02T08:06:26Z","updated_at":"2017-09-11T03:59:49Z","pushed_at":"2017-09-12T09:46:27Z","git_url":"git://github.com/qgis/QGIS.git","ssh_url":"git@github.com:qgis/QGIS.git","clone_url":"https://github.com/qgis/QGIS.git","svn_url":"https://github.com/qgis/QGIS","homepage":"http://qgis.org","size":1314314,"stargazers_count":1534,"watchers_count":1534,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1111,"mirror_url":null,"open_issues_count":96,"forks":1111,"open_issues":96,"watchers":1534,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/5177"},"html":{"href":"https://github.com/qgis/QGIS/pull/5177"},"issue":{"href":"https://api.github.com/repos/qgis/QGIS/issues/5177"},"comments":{"href":"https://api.github.com/repos/qgis/QGIS/issues/5177/comments"},"review_comments":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/5177/comments"},"review_comment":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/5177/commits"},"statuses":{"href":"https://api.github.com/repos/qgis/QGIS/statuses/8c46e4be740fa6d937e987dd4c553cf16344893a"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":100,"deletions":100,"changed_files":86}}
{"actor":{"display_login":"alexbruy"}}