{"action":"created","comment":{"url":"https://api.github.com/repos/mono/monodevelop/pulls/comments/118674154","pull_request_review_id":40483009,"id":118674154,"diff_hunk":"@@ -878,100 +708,36 @@ public Task<IEnumerable<AssemblyReference>> GetReferencedAssemblies (Configurati\n \t\t\t});\n \t\t}\n \n+\t\tpublic Task<List<AssemblyReference>> GetReferences (ConfigurationSelector configuration)\n+\t\t{\n+\t\t\treturn BindTask (async ct => {\n+\t\t\t\treturn await ProjectExtension.OnGetReferences (configuration, ct);\n+\t\t\t});\n+\t\t}\n+\n+\t\tpublic Task<List<AssemblyReference>> GetReferences (ConfigurationSelector configuration, CancellationToken token)\n+\t\t{\n+\t\t\treturn ProjectExtension.OnGetReferences (configuration, token);\n+\t\t}\n+\n \t\t/// <summary>\n \t\t/// Gets the referenced assembly projects, but only projects which output are actually referenced\n \t\t/// for example references with ReferenceOutputAssembly=false are excluded\n \t\t/// </summary>\n \t\t/// <param name=\"configuration\">Configuration.</param>\n+\t\t[Obsolete(\"Use GetReferences\")]\n \t\tpublic IEnumerable<DotNetProject> GetReferencedAssemblyProjects (ConfigurationSelector configuration)","path":"main/src/core/MonoDevelop.Core/MonoDevelop.Projects/DotNetProject.cs","position":292,"original_position":292,"commit_id":"0b0e01cbb5cd27e0d5c272a7b3042d646bd93d0c","original_commit_id":"0b0e01cbb5cd27e0d5c272a7b3042d646bd93d0c","user":{"login":"slluis","id":260349,"avatar_url":"https://avatars1.githubusercontent.com/u/260349?v=3","gravatar_id":"","url":"https://api.github.com/users/slluis","html_url":"https://github.com/slluis","followers_url":"https://api.github.com/users/slluis/followers","following_url":"https://api.github.com/users/slluis/following{/other_user}","gists_url":"https://api.github.com/users/slluis/gists{/gist_id}","starred_url":"https://api.github.com/users/slluis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slluis/subscriptions","organizations_url":"https://api.github.com/users/slluis/orgs","repos_url":"https://api.github.com/users/slluis/repos","events_url":"https://api.github.com/users/slluis/events{/privacy}","received_events_url":"https://api.github.com/users/slluis/received_events","type":"User","site_admin":false},"body":"There is really no need to obsolete this method. GetReferences can also be used for getting referenced projects, but GetReferencedAssemblyProjects is more specific.","created_at":"2017-05-26T10:19:48Z","updated_at":"2017-05-26T10:46:53Z","html_url":"https://github.com/mono/monodevelop/pull/2445#discussion_r118674154","pull_request_url":"https://api.github.com/repos/mono/monodevelop/pulls/2445","_links":{"self":{"href":"https://api.github.com/repos/mono/monodevelop/pulls/comments/118674154"},"html":{"href":"https://github.com/mono/monodevelop/pull/2445#discussion_r118674154"},"pull_request":{"href":"https://api.github.com/repos/mono/monodevelop/pulls/2445"}}},"pull_request":{"url":"https://api.github.com/repos/mono/monodevelop/pulls/2445","id":120940486,"html_url":"https://github.com/mono/monodevelop/pull/2445","diff_url":"https://github.com/mono/monodevelop/pull/2445.diff","patch_url":"https://github.com/mono/monodevelop/pull/2445.patch","issue_url":"https://api.github.com/repos/mono/monodevelop/issues/2445","number":2445,"state":"open","locked":false,"title":"Unify project & assembly ref resolution","user":{"login":"mhutch","id":183285,"avatar_url":"https://avatars1.githubusercontent.com/u/183285?v=3","gravatar_id":"","url":"https://api.github.com/users/mhutch","html_url":"https://github.com/mhutch","followers_url":"https://api.github.com/users/mhutch/followers","following_url":"https://api.github.com/users/mhutch/following{/other_user}","gists_url":"https://api.github.com/users/mhutch/gists{/gist_id}","starred_url":"https://api.github.com/users/mhutch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhutch/subscriptions","organizations_url":"https://api.github.com/users/mhutch/orgs","repos_url":"https://api.github.com/users/mhutch/repos","events_url":"https://api.github.com/users/mhutch/events{/privacy}","received_events_url":"https://api.github.com/users/mhutch/received_events","type":"User","site_admin":false},"body":"For early feedback.\r\n\r\n* We now call the ResolveReference target instead of ResolveAssemblyReferences. This means that the resultant set of ReferencePath items is more complete.\r\n\r\n* Project references are now resolved from ReferencePath items.\r\n\r\n* Resolved AssemblyReference items have full metadata. This means, for example, that we can identify which references are implicit, which come from the framework, which come from specific PackageReferences, etc. This should allow the Dependencies node to be more accurate.\r\n\r\n* Since xbuild doesn't have this metadata, I also removed support for xbuild.\r\n\r\n* I also removed support for MD1 projects as it resulted in a lot of code not-quite-accurately duplicating MSBuild. This means ilasm projects will no longer build.","created_at":"2017-05-16T22:37:20Z","updated_at":"2017-05-26T10:46:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d3349f028221aead8ad0615dd10ffefab8d9ecd7","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mrward","id":372361,"avatar_url":"https://avatars3.githubusercontent.com/u/372361?v=3","gravatar_id":"","url":"https://api.github.com/users/mrward","html_url":"https://github.com/mrward","followers_url":"https://api.github.com/users/mrward/followers","following_url":"https://api.github.com/users/mrward/following{/other_user}","gists_url":"https://api.github.com/users/mrward/gists{/gist_id}","starred_url":"https://api.github.com/users/mrward/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrward/subscriptions","organizations_url":"https://api.github.com/users/mrward/orgs","repos_url":"https://api.github.com/users/mrward/repos","events_url":"https://api.github.com/users/mrward/events{/privacy}","received_events_url":"https://api.github.com/users/mrward/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/mono/monodevelop/pulls/2445/commits","review_comments_url":"https://api.github.com/repos/mono/monodevelop/pulls/2445/comments","review_comment_url":"https://api.github.com/repos/mono/monodevelop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mono/monodevelop/issues/2445/comments","statuses_url":"https://api.github.com/repos/mono/monodevelop/statuses/0b0e01cbb5cd27e0d5c272a7b3042d646bd93d0c","head":{"label":"mhutch:unified-refs","ref":"unified-refs","sha":"0b0e01cbb5cd27e0d5c272a7b3042d646bd93d0c","user":{"login":"mhutch","id":183285,"avatar_url":"https://avatars1.githubusercontent.com/u/183285?v=3","gravatar_id":"","url":"https://api.github.com/users/mhutch","html_url":"https://github.com/mhutch","followers_url":"https://api.github.com/users/mhutch/followers","following_url":"https://api.github.com/users/mhutch/following{/other_user}","gists_url":"https://api.github.com/users/mhutch/gists{/gist_id}","starred_url":"https://api.github.com/users/mhutch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhutch/subscriptions","organizations_url":"https://api.github.com/users/mhutch/orgs","repos_url":"https://api.github.com/users/mhutch/repos","events_url":"https://api.github.com/users/mhutch/events{/privacy}","received_events_url":"https://api.github.com/users/mhutch/received_events","type":"User","site_admin":false},"repo":{"id":793994,"name":"monodevelop","full_name":"mhutch/monodevelop","owner":{"login":"mhutch","id":183285,"avatar_url":"https://avatars1.githubusercontent.com/u/183285?v=3","gravatar_id":"","url":"https://api.github.com/users/mhutch","html_url":"https://github.com/mhutch","followers_url":"https://api.github.com/users/mhutch/followers","following_url":"https://api.github.com/users/mhutch/following{/other_user}","gists_url":"https://api.github.com/users/mhutch/gists{/gist_id}","starred_url":"https://api.github.com/users/mhutch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhutch/subscriptions","organizations_url":"https://api.github.com/users/mhutch/orgs","repos_url":"https://api.github.com/users/mhutch/repos","events_url":"https://api.github.com/users/mhutch/events{/privacy}","received_events_url":"https://api.github.com/users/mhutch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mhutch/monodevelop","description":"MonoDevelop is a cross platform IDE mostly aimed at Mono/.NET developers","fork":true,"url":"https://api.github.com/repos/mhutch/monodevelop","forks_url":"https://api.github.com/repos/mhutch/monodevelop/forks","keys_url":"https://api.github.com/repos/mhutch/monodevelop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mhutch/monodevelop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mhutch/monodevelop/teams","hooks_url":"https://api.github.com/repos/mhutch/monodevelop/hooks","issue_events_url":"https://api.github.com/repos/mhutch/monodevelop/issues/events{/number}","events_url":"https://api.github.com/repos/mhutch/monodevelop/events","assignees_url":"https://api.github.com/repos/mhutch/monodevelop/assignees{/user}","branches_url":"https://api.github.com/repos/mhutch/monodevelop/branches{/branch}","tags_url":"https://api.github.com/repos/mhutch/monodevelop/tags","blobs_url":"https://api.github.com/repos/mhutch/monodevelop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mhutch/monodevelop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mhutch/monodevelop/git/refs{/sha}","trees_url":"https://api.github.com/repos/mhutch/monodevelop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mhutch/monodevelop/statuses/{sha}","languages_url":"https://api.github.com/repos/mhutch/monodevelop/languages","stargazers_url":"https://api.github.com/repos/mhutch/monodevelop/stargazers","contributors_url":"https://api.github.com/repos/mhutch/monodevelop/contributors","subscribers_url":"https://api.github.com/repos/mhutch/monodevelop/subscribers","subscription_url":"https://api.github.com/repos/mhutch/monodevelop/subscription","commits_url":"https://api.github.com/repos/mhutch/monodevelop/commits{/sha}","git_commits_url":"https://api.github.com/repos/mhutch/monodevelop/git/commits{/sha}","comments_url":"https://api.github.com/repos/mhutch/monodevelop/comments{/number}","issue_comment_url":"https://api.github.com/repos/mhutch/monodevelop/issues/comments{/number}","contents_url":"https://api.github.com/repos/mhutch/monodevelop/contents/{+path}","compare_url":"https://api.github.com/repos/mhutch/monodevelop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mhutch/monodevelop/merges","archive_url":"https://api.github.com/repos/mhutch/monodevelop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mhutch/monodevelop/downloads","issues_url":"https://api.github.com/repos/mhutch/monodevelop/issues{/number}","pulls_url":"https://api.github.com/repos/mhutch/monodevelop/pulls{/number}","milestones_url":"https://api.github.com/repos/mhutch/monodevelop/milestones{/number}","notifications_url":"https://api.github.com/repos/mhutch/monodevelop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mhutch/monodevelop/labels{/name}","releases_url":"https://api.github.com/repos/mhutch/monodevelop/releases{/id}","deployments_url":"https://api.github.com/repos/mhutch/monodevelop/deployments","created_at":"2010-07-23T20:05:02Z","updated_at":"2015-07-28T13:03:02Z","pushed_at":"2017-05-26T00:58:45Z","git_url":"git://github.com/mhutch/monodevelop.git","ssh_url":"git@github.com:mhutch/monodevelop.git","clone_url":"https://github.com/mhutch/monodevelop.git","svn_url":"https://github.com/mhutch/monodevelop","homepage":"http://www.monodevelop.com","size":310973,"stargazers_count":5,"watchers_count":5,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":5,"default_branch":"master"}},"base":{"label":"mono:master","ref":"master","sha":"dada3ae5b09d86066ac663427a762f19474c5804","user":{"login":"mono","id":53395,"avatar_url":"https://avatars0.githubusercontent.com/u/53395?v=3","gravatar_id":"","url":"https://api.github.com/users/mono","html_url":"https://github.com/mono","followers_url":"https://api.github.com/users/mono/followers","following_url":"https://api.github.com/users/mono/following{/other_user}","gists_url":"https://api.github.com/users/mono/gists{/gist_id}","starred_url":"https://api.github.com/users/mono/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mono/subscriptions","organizations_url":"https://api.github.com/users/mono/orgs","repos_url":"https://api.github.com/users/mono/repos","events_url":"https://api.github.com/users/mono/events{/privacy}","received_events_url":"https://api.github.com/users/mono/received_events","type":"Organization","site_admin":false},"repo":{"id":791299,"name":"monodevelop","full_name":"mono/monodevelop","owner":{"login":"mono","id":53395,"avatar_url":"https://avatars0.githubusercontent.com/u/53395?v=3","gravatar_id":"","url":"https://api.github.com/users/mono","html_url":"https://github.com/mono","followers_url":"https://api.github.com/users/mono/followers","following_url":"https://api.github.com/users/mono/following{/other_user}","gists_url":"https://api.github.com/users/mono/gists{/gist_id}","starred_url":"https://api.github.com/users/mono/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mono/subscriptions","organizations_url":"https://api.github.com/users/mono/orgs","repos_url":"https://api.github.com/users/mono/repos","events_url":"https://api.github.com/users/mono/events{/privacy}","received_events_url":"https://api.github.com/users/mono/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mono/monodevelop","description":"MonoDevelop is a cross platform IDE mostly aimed at Mono/.NET developers","fork":false,"url":"https://api.github.com/repos/mono/monodevelop","forks_url":"https://api.github.com/repos/mono/monodevelop/forks","keys_url":"https://api.github.com/repos/mono/monodevelop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mono/monodevelop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mono/monodevelop/teams","hooks_url":"https://api.github.com/repos/mono/monodevelop/hooks","issue_events_url":"https://api.github.com/repos/mono/monodevelop/issues/events{/number}","events_url":"https://api.github.com/repos/mono/monodevelop/events","assignees_url":"https://api.github.com/repos/mono/monodevelop/assignees{/user}","branches_url":"https://api.github.com/repos/mono/monodevelop/branches{/branch}","tags_url":"https://api.github.com/repos/mono/monodevelop/tags","blobs_url":"https://api.github.com/repos/mono/monodevelop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mono/monodevelop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mono/monodevelop/git/refs{/sha}","trees_url":"https://api.github.com/repos/mono/monodevelop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mono/monodevelop/statuses/{sha}","languages_url":"https://api.github.com/repos/mono/monodevelop/languages","stargazers_url":"https://api.github.com/repos/mono/monodevelop/stargazers","contributors_url":"https://api.github.com/repos/mono/monodevelop/contributors","subscribers_url":"https://api.github.com/repos/mono/monodevelop/subscribers","subscription_url":"https://api.github.com/repos/mono/monodevelop/subscription","commits_url":"https://api.github.com/repos/mono/monodevelop/commits{/sha}","git_commits_url":"https://api.github.com/repos/mono/monodevelop/git/commits{/sha}","comments_url":"https://api.github.com/repos/mono/monodevelop/comments{/number}","issue_comment_url":"https://api.github.com/repos/mono/monodevelop/issues/comments{/number}","contents_url":"https://api.github.com/repos/mono/monodevelop/contents/{+path}","compare_url":"https://api.github.com/repos/mono/monodevelop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mono/monodevelop/merges","archive_url":"https://api.github.com/repos/mono/monodevelop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mono/monodevelop/downloads","issues_url":"https://api.github.com/repos/mono/monodevelop/issues{/number}","pulls_url":"https://api.github.com/repos/mono/monodevelop/pulls{/number}","milestones_url":"https://api.github.com/repos/mono/monodevelop/milestones{/number}","notifications_url":"https://api.github.com/repos/mono/monodevelop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mono/monodevelop/labels{/name}","releases_url":"https://api.github.com/repos/mono/monodevelop/releases{/id}","deployments_url":"https://api.github.com/repos/mono/monodevelop/deployments","created_at":"2010-07-22T16:09:08Z","updated_at":"2017-05-25T00:27:56Z","pushed_at":"2017-05-26T09:10:24Z","git_url":"git://github.com/mono/monodevelop.git","ssh_url":"git@github.com:mono/monodevelop.git","clone_url":"https://github.com/mono/monodevelop.git","svn_url":"https://github.com/mono/monodevelop","homepage":"http://www.monodevelop.com","size":308723,"stargazers_count":1855,"watchers_count":1855,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":744,"mirror_url":null,"open_issues_count":41,"forks":744,"open_issues":41,"watchers":1855,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mono/monodevelop/pulls/2445"},"html":{"href":"https://github.com/mono/monodevelop/pull/2445"},"issue":{"href":"https://api.github.com/repos/mono/monodevelop/issues/2445"},"comments":{"href":"https://api.github.com/repos/mono/monodevelop/issues/2445/comments"},"review_comments":{"href":"https://api.github.com/repos/mono/monodevelop/pulls/2445/comments"},"review_comment":{"href":"https://api.github.com/repos/mono/monodevelop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mono/monodevelop/pulls/2445/commits"},"statuses":{"href":"https://api.github.com/repos/mono/monodevelop/statuses/0b0e01cbb5cd27e0d5c272a7b3042d646bd93d0c"}}}}
{"actor":{"display_login":"slluis"}}