{"action":"closed","number":413,"pull_request":{"url":"https://api.github.com/repos/TextureGroup/Texture/pulls/413","id":128713791,"html_url":"https://github.com/TextureGroup/Texture/pull/413","diff_url":"https://github.com/TextureGroup/Texture/pull/413.diff","patch_url":"https://github.com/TextureGroup/Texture/pull/413.patch","issue_url":"https://api.github.com/repos/TextureGroup/Texture/issues/413","number":413,"state":"closed","locked":false,"title":"[ASDisplayNode+Layout] In layoutThatFits:, check and use _pending layout if valid.","user":{"login":"appleguy","id":565251,"avatar_url":"https://avatars0.githubusercontent.com/u/565251?v=3","gravatar_id":"","url":"https://api.github.com/users/appleguy","html_url":"https://github.com/appleguy","followers_url":"https://api.github.com/users/appleguy/followers","following_url":"https://api.github.com/users/appleguy/following{/other_user}","gists_url":"https://api.github.com/users/appleguy/gists{/gist_id}","starred_url":"https://api.github.com/users/appleguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appleguy/subscriptions","organizations_url":"https://api.github.com/users/appleguy/orgs","repos_url":"https://api.github.com/users/appleguy/repos","events_url":"https://api.github.com/users/appleguy/events{/privacy}","received_events_url":"https://api.github.com/users/appleguy/received_events","type":"User","site_admin":false},"body":"I believe this check is supposed to be here. Unit tests pass with it in place.\r\nWithout it, calling layoutThatFits: (as ASDataController does) and then calling\r\nit again later (as ASCollectionNode does when answering the sizeForItem: call)\r\nwill recompute the layout, potentially on main.\r\n\r\nThis seems to have more of an impact / benefit for Yoga layouts, but I don't think\r\nits benefit is exclusive to them.","created_at":"2017-07-04T02:02:22Z","updated_at":"2017-07-05T10:02:38Z","closed_at":"2017-07-05T10:02:38Z","merged_at":"2017-07-05T10:02:38Z","merge_commit_sha":"fb6cad941fac2382d251260a16cb2ef5aa728c3c","assignee":{"login":"appleguy","id":565251,"avatar_url":"https://avatars0.githubusercontent.com/u/565251?v=3","gravatar_id":"","url":"https://api.github.com/users/appleguy","html_url":"https://github.com/appleguy","followers_url":"https://api.github.com/users/appleguy/followers","following_url":"https://api.github.com/users/appleguy/following{/other_user}","gists_url":"https://api.github.com/users/appleguy/gists{/gist_id}","starred_url":"https://api.github.com/users/appleguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appleguy/subscriptions","organizations_url":"https://api.github.com/users/appleguy/orgs","repos_url":"https://api.github.com/users/appleguy/repos","events_url":"https://api.github.com/users/appleguy/events{/privacy}","received_events_url":"https://api.github.com/users/appleguy/received_events","type":"User","site_admin":false},"assignees":[{"login":"appleguy","id":565251,"avatar_url":"https://avatars0.githubusercontent.com/u/565251?v=3","gravatar_id":"","url":"https://api.github.com/users/appleguy","html_url":"https://github.com/appleguy","followers_url":"https://api.github.com/users/appleguy/followers","following_url":"https://api.github.com/users/appleguy/following{/other_user}","gists_url":"https://api.github.com/users/appleguy/gists{/gist_id}","starred_url":"https://api.github.com/users/appleguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appleguy/subscriptions","organizations_url":"https://api.github.com/users/appleguy/orgs","repos_url":"https://api.github.com/users/appleguy/repos","events_url":"https://api.github.com/users/appleguy/events{/privacy}","received_events_url":"https://api.github.com/users/appleguy/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/TextureGroup/Texture/pulls/413/commits","review_comments_url":"https://api.github.com/repos/TextureGroup/Texture/pulls/413/comments","review_comment_url":"https://api.github.com/repos/TextureGroup/Texture/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TextureGroup/Texture/issues/413/comments","statuses_url":"https://api.github.com/repos/TextureGroup/Texture/statuses/088c7d8edc1c9fe524f68c4f8c2e08ef2cb32b78","head":{"label":"TextureGroup:PendingLayout","ref":"PendingLayout","sha":"088c7d8edc1c9fe524f68c4f8c2e08ef2cb32b78","user":{"login":"TextureGroup","id":25676156,"avatar_url":"https://avatars0.githubusercontent.com/u/25676156?v=3","gravatar_id":"","url":"https://api.github.com/users/TextureGroup","html_url":"https://github.com/TextureGroup","followers_url":"https://api.github.com/users/TextureGroup/followers","following_url":"https://api.github.com/users/TextureGroup/following{/other_user}","gists_url":"https://api.github.com/users/TextureGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/TextureGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TextureGroup/subscriptions","organizations_url":"https://api.github.com/users/TextureGroup/orgs","repos_url":"https://api.github.com/users/TextureGroup/repos","events_url":"https://api.github.com/users/TextureGroup/events{/privacy}","received_events_url":"https://api.github.com/users/TextureGroup/received_events","type":"Organization","site_admin":false},"repo":{"id":81514066,"name":"Texture","full_name":"TextureGroup/Texture","owner":{"login":"TextureGroup","id":25676156,"avatar_url":"https://avatars0.githubusercontent.com/u/25676156?v=3","gravatar_id":"","url":"https://api.github.com/users/TextureGroup","html_url":"https://github.com/TextureGroup","followers_url":"https://api.github.com/users/TextureGroup/followers","following_url":"https://api.github.com/users/TextureGroup/following{/other_user}","gists_url":"https://api.github.com/users/TextureGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/TextureGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TextureGroup/subscriptions","organizations_url":"https://api.github.com/users/TextureGroup/orgs","repos_url":"https://api.github.com/users/TextureGroup/repos","events_url":"https://api.github.com/users/TextureGroup/events{/privacy}","received_events_url":"https://api.github.com/users/TextureGroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TextureGroup/Texture","description":"Smooth asynchronous user interfaces for iOS apps.","fork":false,"url":"https://api.github.com/repos/TextureGroup/Texture","forks_url":"https://api.github.com/repos/TextureGroup/Texture/forks","keys_url":"https://api.github.com/repos/TextureGroup/Texture/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TextureGroup/Texture/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TextureGroup/Texture/teams","hooks_url":"https://api.github.com/repos/TextureGroup/Texture/hooks","issue_events_url":"https://api.github.com/repos/TextureGroup/Texture/issues/events{/number}","events_url":"https://api.github.com/repos/TextureGroup/Texture/events","assignees_url":"https://api.github.com/repos/TextureGroup/Texture/assignees{/user}","branches_url":"https://api.github.com/repos/TextureGroup/Texture/branches{/branch}","tags_url":"https://api.github.com/repos/TextureGroup/Texture/tags","blobs_url":"https://api.github.com/repos/TextureGroup/Texture/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TextureGroup/Texture/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TextureGroup/Texture/git/refs{/sha}","trees_url":"https://api.github.com/repos/TextureGroup/Texture/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TextureGroup/Texture/statuses/{sha}","languages_url":"https://api.github.com/repos/TextureGroup/Texture/languages","stargazers_url":"https://api.github.com/repos/TextureGroup/Texture/stargazers","contributors_url":"https://api.github.com/repos/TextureGroup/Texture/contributors","subscribers_url":"https://api.github.com/repos/TextureGroup/Texture/subscribers","subscription_url":"https://api.github.com/repos/TextureGroup/Texture/subscription","commits_url":"https://api.github.com/repos/TextureGroup/Texture/commits{/sha}","git_commits_url":"https://api.github.com/repos/TextureGroup/Texture/git/commits{/sha}","comments_url":"https://api.github.com/repos/TextureGroup/Texture/comments{/number}","issue_comment_url":"https://api.github.com/repos/TextureGroup/Texture/issues/comments{/number}","contents_url":"https://api.github.com/repos/TextureGroup/Texture/contents/{+path}","compare_url":"https://api.github.com/repos/TextureGroup/Texture/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TextureGroup/Texture/merges","archive_url":"https://api.github.com/repos/TextureGroup/Texture/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TextureGroup/Texture/downloads","issues_url":"https://api.github.com/repos/TextureGroup/Texture/issues{/number}","pulls_url":"https://api.github.com/repos/TextureGroup/Texture/pulls{/number}","milestones_url":"https://api.github.com/repos/TextureGroup/Texture/milestones{/number}","notifications_url":"https://api.github.com/repos/TextureGroup/Texture/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TextureGroup/Texture/labels{/name}","releases_url":"https://api.github.com/repos/TextureGroup/Texture/releases{/id}","deployments_url":"https://api.github.com/repos/TextureGroup/Texture/deployments","created_at":"2017-02-10T01:44:38Z","updated_at":"2017-07-05T07:32:49Z","pushed_at":"2017-07-05T10:02:38Z","git_url":"git://github.com/TextureGroup/Texture.git","ssh_url":"git@github.com:TextureGroup/Texture.git","clone_url":"https://github.com/TextureGroup/Texture.git","svn_url":"https://github.com/TextureGroup/Texture","homepage":"http://texturegroup.org","size":121402,"stargazers_count":1420,"watchers_count":1420,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":135,"mirror_url":null,"open_issues_count":178,"forks":135,"open_issues":178,"watchers":1420,"default_branch":"master"}},"base":{"label":"TextureGroup:master","ref":"master","sha":"8ec4b312cf8758d34858b249d4e6b11ba5a1b931","user":{"login":"TextureGroup","id":25676156,"avatar_url":"https://avatars0.githubusercontent.com/u/25676156?v=3","gravatar_id":"","url":"https://api.github.com/users/TextureGroup","html_url":"https://github.com/TextureGroup","followers_url":"https://api.github.com/users/TextureGroup/followers","following_url":"https://api.github.com/users/TextureGroup/following{/other_user}","gists_url":"https://api.github.com/users/TextureGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/TextureGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TextureGroup/subscriptions","organizations_url":"https://api.github.com/users/TextureGroup/orgs","repos_url":"https://api.github.com/users/TextureGroup/repos","events_url":"https://api.github.com/users/TextureGroup/events{/privacy}","received_events_url":"https://api.github.com/users/TextureGroup/received_events","type":"Organization","site_admin":false},"repo":{"id":81514066,"name":"Texture","full_name":"TextureGroup/Texture","owner":{"login":"TextureGroup","id":25676156,"avatar_url":"https://avatars0.githubusercontent.com/u/25676156?v=3","gravatar_id":"","url":"https://api.github.com/users/TextureGroup","html_url":"https://github.com/TextureGroup","followers_url":"https://api.github.com/users/TextureGroup/followers","following_url":"https://api.github.com/users/TextureGroup/following{/other_user}","gists_url":"https://api.github.com/users/TextureGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/TextureGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TextureGroup/subscriptions","organizations_url":"https://api.github.com/users/TextureGroup/orgs","repos_url":"https://api.github.com/users/TextureGroup/repos","events_url":"https://api.github.com/users/TextureGroup/events{/privacy}","received_events_url":"https://api.github.com/users/TextureGroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TextureGroup/Texture","description":"Smooth asynchronous user interfaces for iOS apps.","fork":false,"url":"https://api.github.com/repos/TextureGroup/Texture","forks_url":"https://api.github.com/repos/TextureGroup/Texture/forks","keys_url":"https://api.github.com/repos/TextureGroup/Texture/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TextureGroup/Texture/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TextureGroup/Texture/teams","hooks_url":"https://api.github.com/repos/TextureGroup/Texture/hooks","issue_events_url":"https://api.github.com/repos/TextureGroup/Texture/issues/events{/number}","events_url":"https://api.github.com/repos/TextureGroup/Texture/events","assignees_url":"https://api.github.com/repos/TextureGroup/Texture/assignees{/user}","branches_url":"https://api.github.com/repos/TextureGroup/Texture/branches{/branch}","tags_url":"https://api.github.com/repos/TextureGroup/Texture/tags","blobs_url":"https://api.github.com/repos/TextureGroup/Texture/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TextureGroup/Texture/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TextureGroup/Texture/git/refs{/sha}","trees_url":"https://api.github.com/repos/TextureGroup/Texture/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TextureGroup/Texture/statuses/{sha}","languages_url":"https://api.github.com/repos/TextureGroup/Texture/languages","stargazers_url":"https://api.github.com/repos/TextureGroup/Texture/stargazers","contributors_url":"https://api.github.com/repos/TextureGroup/Texture/contributors","subscribers_url":"https://api.github.com/repos/TextureGroup/Texture/subscribers","subscription_url":"https://api.github.com/repos/TextureGroup/Texture/subscription","commits_url":"https://api.github.com/repos/TextureGroup/Texture/commits{/sha}","git_commits_url":"https://api.github.com/repos/TextureGroup/Texture/git/commits{/sha}","comments_url":"https://api.github.com/repos/TextureGroup/Texture/comments{/number}","issue_comment_url":"https://api.github.com/repos/TextureGroup/Texture/issues/comments{/number}","contents_url":"https://api.github.com/repos/TextureGroup/Texture/contents/{+path}","compare_url":"https://api.github.com/repos/TextureGroup/Texture/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TextureGroup/Texture/merges","archive_url":"https://api.github.com/repos/TextureGroup/Texture/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TextureGroup/Texture/downloads","issues_url":"https://api.github.com/repos/TextureGroup/Texture/issues{/number}","pulls_url":"https://api.github.com/repos/TextureGroup/Texture/pulls{/number}","milestones_url":"https://api.github.com/repos/TextureGroup/Texture/milestones{/number}","notifications_url":"https://api.github.com/repos/TextureGroup/Texture/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TextureGroup/Texture/labels{/name}","releases_url":"https://api.github.com/repos/TextureGroup/Texture/releases{/id}","deployments_url":"https://api.github.com/repos/TextureGroup/Texture/deployments","created_at":"2017-02-10T01:44:38Z","updated_at":"2017-07-05T07:32:49Z","pushed_at":"2017-07-05T10:02:38Z","git_url":"git://github.com/TextureGroup/Texture.git","ssh_url":"git@github.com:TextureGroup/Texture.git","clone_url":"https://github.com/TextureGroup/Texture.git","svn_url":"https://github.com/TextureGroup/Texture","homepage":"http://texturegroup.org","size":121402,"stargazers_count":1420,"watchers_count":1420,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":135,"mirror_url":null,"open_issues_count":178,"forks":135,"open_issues":178,"watchers":1420,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TextureGroup/Texture/pulls/413"},"html":{"href":"https://github.com/TextureGroup/Texture/pull/413"},"issue":{"href":"https://api.github.com/repos/TextureGroup/Texture/issues/413"},"comments":{"href":"https://api.github.com/repos/TextureGroup/Texture/issues/413/comments"},"review_comments":{"href":"https://api.github.com/repos/TextureGroup/Texture/pulls/413/comments"},"review_comment":{"href":"https://api.github.com/repos/TextureGroup/Texture/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TextureGroup/Texture/pulls/413/commits"},"statuses":{"href":"https://api.github.com/repos/TextureGroup/Texture/statuses/088c7d8edc1c9fe524f68c4f8c2e08ef2cb32b78"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"nguyenhuy","id":587874,"avatar_url":"https://avatars2.githubusercontent.com/u/587874?v=3","gravatar_id":"","url":"https://api.github.com/users/nguyenhuy","html_url":"https://github.com/nguyenhuy","followers_url":"https://api.github.com/users/nguyenhuy/followers","following_url":"https://api.github.com/users/nguyenhuy/following{/other_user}","gists_url":"https://api.github.com/users/nguyenhuy/gists{/gist_id}","starred_url":"https://api.github.com/users/nguyenhuy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nguyenhuy/subscriptions","organizations_url":"https://api.github.com/users/nguyenhuy/orgs","repos_url":"https://api.github.com/users/nguyenhuy/repos","events_url":"https://api.github.com/users/nguyenhuy/events{/privacy}","received_events_url":"https://api.github.com/users/nguyenhuy/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":14,"deletions":11,"changed_files":1}}
{"actor":{"display_login":"nguyenhuy"}}