{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/logstash/pulls/comments/149110223","pull_request_review_id":74453068,"id":149110223,"diff_hunk":"@@ -1,7 +1,9 @@\n # encoding: utf-8\n \n-require \"jruby_acked_queue_ext\"\n-require \"jruby_acked_batch_ext\"\n+# Force loading the RubyUtil to ensure its loaded before the WrappedAckedQueue class is set up in\n+# Ruby since WrappedAckedQueue depends on Ruby classes that are dynamically set up by Java code.\n+java_import org.logstash.RubyUtil","path":"logstash-core/lib/logstash/util/wrapped_acked_queue.rb","position":7,"original_position":7,"commit_id":"19de2aef68d8d574629316756d81a6aa8d250a55","original_commit_id":"19de2aef68d8d574629316756d81a6aa8d250a55","user":{"login":"original-brownbear","id":6490959,"avatar_url":"https://avatars0.githubusercontent.com/u/6490959?v=4","gravatar_id":"","url":"https://api.github.com/users/original-brownbear","html_url":"https://github.com/original-brownbear","followers_url":"https://api.github.com/users/original-brownbear/followers","following_url":"https://api.github.com/users/original-brownbear/following{/other_user}","gists_url":"https://api.github.com/users/original-brownbear/gists{/gist_id}","starred_url":"https://api.github.com/users/original-brownbear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/original-brownbear/subscriptions","organizations_url":"https://api.github.com/users/original-brownbear/orgs","repos_url":"https://api.github.com/users/original-brownbear/repos","events_url":"https://api.github.com/users/original-brownbear/events{/privacy}","received_events_url":"https://api.github.com/users/original-brownbear/received_events","type":"User","site_admin":false},"body":"@jakelandis you're 100% correct here imo (this is stable though, I promise :D it triggers classloading `RubyUtil` in 100% of cases). The thing is we're already doing exactly this in `event.rb`, so I'd rather not mix in drying this up here.\r\n\r\n**BUT** come to think of it, life might be even better here in the next step :) You know, I think we should simply put this line into just `environment.rb` and it will work 100% fine (provided https://github.com/elastic/logstash/pull/8594 is in).\r\n\r\nIt's probably not worth it cleaning this up now when https://github.com/elastic/logstash/pull/8594 is just around the corner and we can simply move this to `environment.rb` then right?","created_at":"2017-11-06T15:29:58Z","updated_at":"2017-11-06T15:29:58Z","html_url":"https://github.com/elastic/logstash/pull/8593#discussion_r149110223","pull_request_url":"https://api.github.com/repos/elastic/logstash/pulls/8593","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/elastic/logstash/pulls/comments/149110223"},"html":{"href":"https://github.com/elastic/logstash/pull/8593#discussion_r149110223"},"pull_request":{"href":"https://api.github.com/repos/elastic/logstash/pulls/8593"}},"in_reply_to_id":149104561},"pull_request":{"url":"https://api.github.com/repos/elastic/logstash/pulls/8593","id":150852227,"html_url":"https://github.com/elastic/logstash/pull/8593","diff_url":"https://github.com/elastic/logstash/pull/8593.diff","patch_url":"https://github.com/elastic/logstash/pull/8593.patch","issue_url":"https://api.github.com/repos/elastic/logstash/issues/8593","number":8593,"state":"open","locked":false,"title":"MINOR: Cleanup RubyClass loading some more","user":{"login":"original-brownbear","id":6490959,"avatar_url":"https://avatars0.githubusercontent.com/u/6490959?v=4","gravatar_id":"","url":"https://api.github.com/users/original-brownbear","html_url":"https://github.com/original-brownbear","followers_url":"https://api.github.com/users/original-brownbear/followers","following_url":"https://api.github.com/users/original-brownbear/following{/other_user}","gists_url":"https://api.github.com/users/original-brownbear/gists{/gist_id}","starred_url":"https://api.github.com/users/original-brownbear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/original-brownbear/subscriptions","organizations_url":"https://api.github.com/users/original-brownbear/orgs","repos_url":"https://api.github.com/users/original-brownbear/repos","events_url":"https://api.github.com/users/original-brownbear/events{/privacy}","received_events_url":"https://api.github.com/users/original-brownbear/received_events","type":"User","site_admin":false},"body":"Same approach as in #8529, make classloading explicit to avoid circular dependencies + get full control over the load order (important for writing more JUnit tests that involve Ruby functionality).\r\n\r\nAs in other PRs like this before, not that the outer classes for some Ruby class definitions now become redundant. I left them in this PR to not mix a logical change with a huge formatting change and also to not break binary compatibility.","created_at":"2017-11-06T13:28:30Z","updated_at":"2017-11-06T15:29:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2ed3dcf6d6e7f7df130f91a9c0adddb5c5c34bd8","assignee":null,"assignees":[],"requested_reviewers":[{"login":"andrewvc","id":131427,"avatar_url":"https://avatars2.githubusercontent.com/u/131427?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewvc","html_url":"https://github.com/andrewvc","followers_url":"https://api.github.com/users/andrewvc/followers","following_url":"https://api.github.com/users/andrewvc/following{/other_user}","gists_url":"https://api.github.com/users/andrewvc/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewvc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewvc/subscriptions","organizations_url":"https://api.github.com/users/andrewvc/orgs","repos_url":"https://api.github.com/users/andrewvc/repos","events_url":"https://api.github.com/users/andrewvc/events{/privacy}","received_events_url":"https://api.github.com/users/andrewvc/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/logstash/pulls/8593/commits","review_comments_url":"https://api.github.com/repos/elastic/logstash/pulls/8593/comments","review_comment_url":"https://api.github.com/repos/elastic/logstash/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/logstash/issues/8593/comments","statuses_url":"https://api.github.com/repos/elastic/logstash/statuses/19de2aef68d8d574629316756d81a6aa8d250a55","head":{"label":"original-brownbear:explicit-load-remaining-ruby-classes","ref":"explicit-load-remaining-ruby-classes","sha":"19de2aef68d8d574629316756d81a6aa8d250a55","user":{"login":"original-brownbear","id":6490959,"avatar_url":"https://avatars0.githubusercontent.com/u/6490959?v=4","gravatar_id":"","url":"https://api.github.com/users/original-brownbear","html_url":"https://github.com/original-brownbear","followers_url":"https://api.github.com/users/original-brownbear/followers","following_url":"https://api.github.com/users/original-brownbear/following{/other_user}","gists_url":"https://api.github.com/users/original-brownbear/gists{/gist_id}","starred_url":"https://api.github.com/users/original-brownbear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/original-brownbear/subscriptions","organizations_url":"https://api.github.com/users/original-brownbear/orgs","repos_url":"https://api.github.com/users/original-brownbear/repos","events_url":"https://api.github.com/users/original-brownbear/events{/privacy}","received_events_url":"https://api.github.com/users/original-brownbear/received_events","type":"User","site_admin":false},"repo":{"id":88715786,"name":"logstash","full_name":"original-brownbear/logstash","owner":{"login":"original-brownbear","id":6490959,"avatar_url":"https://avatars0.githubusercontent.com/u/6490959?v=4","gravatar_id":"","url":"https://api.github.com/users/original-brownbear","html_url":"https://github.com/original-brownbear","followers_url":"https://api.github.com/users/original-brownbear/followers","following_url":"https://api.github.com/users/original-brownbear/following{/other_user}","gists_url":"https://api.github.com/users/original-brownbear/gists{/gist_id}","starred_url":"https://api.github.com/users/original-brownbear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/original-brownbear/subscriptions","organizations_url":"https://api.github.com/users/original-brownbear/orgs","repos_url":"https://api.github.com/users/original-brownbear/repos","events_url":"https://api.github.com/users/original-brownbear/events{/privacy}","received_events_url":"https://api.github.com/users/original-brownbear/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/original-brownbear/logstash","description":"Logstash - transport and process your logs, events, or other data","fork":true,"url":"https://api.github.com/repos/original-brownbear/logstash","forks_url":"https://api.github.com/repos/original-brownbear/logstash/forks","keys_url":"https://api.github.com/repos/original-brownbear/logstash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/original-brownbear/logstash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/original-brownbear/logstash/teams","hooks_url":"https://api.github.com/repos/original-brownbear/logstash/hooks","issue_events_url":"https://api.github.com/repos/original-brownbear/logstash/issues/events{/number}","events_url":"https://api.github.com/repos/original-brownbear/logstash/events","assignees_url":"https://api.github.com/repos/original-brownbear/logstash/assignees{/user}","branches_url":"https://api.github.com/repos/original-brownbear/logstash/branches{/branch}","tags_url":"https://api.github.com/repos/original-brownbear/logstash/tags","blobs_url":"https://api.github.com/repos/original-brownbear/logstash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/original-brownbear/logstash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/original-brownbear/logstash/git/refs{/sha}","trees_url":"https://api.github.com/repos/original-brownbear/logstash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/original-brownbear/logstash/statuses/{sha}","languages_url":"https://api.github.com/repos/original-brownbear/logstash/languages","stargazers_url":"https://api.github.com/repos/original-brownbear/logstash/stargazers","contributors_url":"https://api.github.com/repos/original-brownbear/logstash/contributors","subscribers_url":"https://api.github.com/repos/original-brownbear/logstash/subscribers","subscription_url":"https://api.github.com/repos/original-brownbear/logstash/subscription","commits_url":"https://api.github.com/repos/original-brownbear/logstash/commits{/sha}","git_commits_url":"https://api.github.com/repos/original-brownbear/logstash/git/commits{/sha}","comments_url":"https://api.github.com/repos/original-brownbear/logstash/comments{/number}","issue_comment_url":"https://api.github.com/repos/original-brownbear/logstash/issues/comments{/number}","contents_url":"https://api.github.com/repos/original-brownbear/logstash/contents/{+path}","compare_url":"https://api.github.com/repos/original-brownbear/logstash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/original-brownbear/logstash/merges","archive_url":"https://api.github.com/repos/original-brownbear/logstash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/original-brownbear/logstash/downloads","issues_url":"https://api.github.com/repos/original-brownbear/logstash/issues{/number}","pulls_url":"https://api.github.com/repos/original-brownbear/logstash/pulls{/number}","milestones_url":"https://api.github.com/repos/original-brownbear/logstash/milestones{/number}","notifications_url":"https://api.github.com/repos/original-brownbear/logstash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/original-brownbear/logstash/labels{/name}","releases_url":"https://api.github.com/repos/original-brownbear/logstash/releases{/id}","deployments_url":"https://api.github.com/repos/original-brownbear/logstash/deployments","created_at":"2017-04-19T07:40:07Z","updated_at":"2017-04-19T07:40:11Z","pushed_at":"2017-11-06T15:18:43Z","git_url":"git://github.com/original-brownbear/logstash.git","ssh_url":"git@github.com:original-brownbear/logstash.git","clone_url":"https://github.com/original-brownbear/logstash.git","svn_url":"https://github.com/original-brownbear/logstash","homepage":"https://www.elastic.co/products/logstash","size":98231,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"e6b81e665b0ae76fbbddc687f4056aea18eb7229","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":1090311,"name":"logstash","full_name":"elastic/logstash","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/logstash","description":"Logstash - transport and process your logs, events, or other data","fork":false,"url":"https://api.github.com/repos/elastic/logstash","forks_url":"https://api.github.com/repos/elastic/logstash/forks","keys_url":"https://api.github.com/repos/elastic/logstash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/logstash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/logstash/teams","hooks_url":"https://api.github.com/repos/elastic/logstash/hooks","issue_events_url":"https://api.github.com/repos/elastic/logstash/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/logstash/events","assignees_url":"https://api.github.com/repos/elastic/logstash/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/logstash/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/logstash/tags","blobs_url":"https://api.github.com/repos/elastic/logstash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/logstash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/logstash/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/logstash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/logstash/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/logstash/languages","stargazers_url":"https://api.github.com/repos/elastic/logstash/stargazers","contributors_url":"https://api.github.com/repos/elastic/logstash/contributors","subscribers_url":"https://api.github.com/repos/elastic/logstash/subscribers","subscription_url":"https://api.github.com/repos/elastic/logstash/subscription","commits_url":"https://api.github.com/repos/elastic/logstash/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/logstash/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/logstash/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/logstash/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/logstash/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/logstash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/logstash/merges","archive_url":"https://api.github.com/repos/elastic/logstash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/logstash/downloads","issues_url":"https://api.github.com/repos/elastic/logstash/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/logstash/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/logstash/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/logstash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/logstash/labels{/name}","releases_url":"https://api.github.com/repos/elastic/logstash/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/logstash/deployments","created_at":"2010-11-18T01:31:50Z","updated_at":"2017-11-06T14:17:29Z","pushed_at":"2017-11-06T15:18:48Z","git_url":"git://github.com/elastic/logstash.git","ssh_url":"git@github.com:elastic/logstash.git","clone_url":"https://github.com/elastic/logstash.git","svn_url":"https://github.com/elastic/logstash","homepage":"https://www.elastic.co/products/logstash","size":97478,"stargazers_count":8167,"watchers_count":8167,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2288,"mirror_url":null,"archived":false,"open_issues_count":1027,"forks":2288,"open_issues":1027,"watchers":8167,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/logstash/pulls/8593"},"html":{"href":"https://github.com/elastic/logstash/pull/8593"},"issue":{"href":"https://api.github.com/repos/elastic/logstash/issues/8593"},"comments":{"href":"https://api.github.com/repos/elastic/logstash/issues/8593/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/logstash/pulls/8593/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/logstash/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/logstash/pulls/8593/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/logstash/statuses/19de2aef68d8d574629316756d81a6aa8d250a55"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"original-brownbear"}}