{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/kibana/pulls/comments/100873850","pull_request_review_id":21590272,"id":100873850,"diff_hunk":"@@ -0,0 +1,6 @@\n+import React from 'react';\n+import { KuiIcon } from './kui_icon';\n+\n+export function DeleteIcon() {\n+  return <KuiIcon className=\"fa-trash\"/>;","path":"ui_framework/components/icon/delete_icon.js","position":5,"original_position":5,"commit_id":"77b49dccdee3f1e791e774c442888002dc02b1b8","original_commit_id":"77b49dccdee3f1e791e774c442888002dc02b1b8","user":{"login":"Stacey-Gammon","id":16563603,"avatar_url":"https://avatars.githubusercontent.com/u/16563603?v=3","gravatar_id":"","url":"https://api.github.com/users/Stacey-Gammon","html_url":"https://github.com/Stacey-Gammon","followers_url":"https://api.github.com/users/Stacey-Gammon/followers","following_url":"https://api.github.com/users/Stacey-Gammon/following{/other_user}","gists_url":"https://api.github.com/users/Stacey-Gammon/gists{/gist_id}","starred_url":"https://api.github.com/users/Stacey-Gammon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stacey-Gammon/subscriptions","organizations_url":"https://api.github.com/users/Stacey-Gammon/orgs","repos_url":"https://api.github.com/users/Stacey-Gammon/repos","events_url":"https://api.github.com/users/Stacey-Gammon/events{/privacy}","received_events_url":"https://api.github.com/users/Stacey-Gammon/received_events","type":"User","site_admin":false},"body":"> Also, I wonder if we should use CamelCasing for the component file names (will clearly indicate that a file contains a component). In this example, DeleteIcon.js, CreateIcon.js, KuiIcon.js, etc...\r\n\r\nI **much** prefer CamelCasing file names, but I think there may have been a reason we use underscore?  I was chatting with... I think @cjcenizal about this.  Case sensitivity on different OS's or something?  Anyway I am totally in favor of that, if there are no relevant objections.  Just want to pull the right people in who have more background then me.  @spalger?\r\n\r\n++ @kjbekkelund on the exports suggestion.","created_at":"2017-02-13T19:18:27Z","updated_at":"2017-02-13T19:18:27Z","html_url":"https://github.com/elastic/kibana/pull/10247#discussion_r100873850","pull_request_url":"https://api.github.com/repos/elastic/kibana/pulls/10247","_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments/100873850"},"html":{"href":"https://github.com/elastic/kibana/pull/10247#discussion_r100873850"},"pull_request":{"href":"https://api.github.com/repos/elastic/kibana/pulls/10247"}}},"pull_request":{"url":"https://api.github.com/repos/elastic/kibana/pulls/10247","id":105266904,"html_url":"https://github.com/elastic/kibana/pull/10247","diff_url":"https://github.com/elastic/kibana/pull/10247.diff","patch_url":"https://github.com/elastic/kibana/pull/10247.patch","issue_url":"https://api.github.com/repos/elastic/kibana/issues/10247","number":10247,"state":"open","locked":false,"title":"Introducing react icons!","user":{"login":"Stacey-Gammon","id":16563603,"avatar_url":"https://avatars.githubusercontent.com/u/16563603?v=3","gravatar_id":"","url":"https://api.github.com/users/Stacey-Gammon","html_url":"https://github.com/Stacey-Gammon","followers_url":"https://api.github.com/users/Stacey-Gammon/followers","following_url":"https://api.github.com/users/Stacey-Gammon/following{/other_user}","gists_url":"https://api.github.com/users/Stacey-Gammon/gists{/gist_id}","starred_url":"https://api.github.com/users/Stacey-Gammon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stacey-Gammon/subscriptions","organizations_url":"https://api.github.com/users/Stacey-Gammon/orgs","repos_url":"https://api.github.com/users/Stacey-Gammon/repos","events_url":"https://api.github.com/users/Stacey-Gammon/events{/privacy}","received_events_url":"https://api.github.com/users/Stacey-Gammon/received_events","type":"User","site_admin":false},"body":"The very first introduction of embedded react in our angular apps.\r\n\r\nStarting very simple with components that have no props passed from angular, or state.  I've confirmed it's possible, just decided to start very small.","created_at":"2017-02-08T17:38:48Z","updated_at":"2017-02-13T19:18:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"118754c8857ea068c7fb834eab9d0589ff19238c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/kibana/pulls/10247/commits","review_comments_url":"https://api.github.com/repos/elastic/kibana/pulls/10247/comments","review_comment_url":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/kibana/issues/10247/comments","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/77b49dccdee3f1e791e774c442888002dc02b1b8","head":{"label":"Stacey-Gammon:react-icons","ref":"react-icons","sha":"77b49dccdee3f1e791e774c442888002dc02b1b8","user":{"login":"Stacey-Gammon","id":16563603,"avatar_url":"https://avatars.githubusercontent.com/u/16563603?v=3","gravatar_id":"","url":"https://api.github.com/users/Stacey-Gammon","html_url":"https://github.com/Stacey-Gammon","followers_url":"https://api.github.com/users/Stacey-Gammon/followers","following_url":"https://api.github.com/users/Stacey-Gammon/following{/other_user}","gists_url":"https://api.github.com/users/Stacey-Gammon/gists{/gist_id}","starred_url":"https://api.github.com/users/Stacey-Gammon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stacey-Gammon/subscriptions","organizations_url":"https://api.github.com/users/Stacey-Gammon/orgs","repos_url":"https://api.github.com/users/Stacey-Gammon/repos","events_url":"https://api.github.com/users/Stacey-Gammon/events{/privacy}","received_events_url":"https://api.github.com/users/Stacey-Gammon/received_events","type":"User","site_admin":false},"repo":{"id":68325068,"name":"kibana","full_name":"Stacey-Gammon/kibana","owner":{"login":"Stacey-Gammon","id":16563603,"avatar_url":"https://avatars.githubusercontent.com/u/16563603?v=3","gravatar_id":"","url":"https://api.github.com/users/Stacey-Gammon","html_url":"https://github.com/Stacey-Gammon","followers_url":"https://api.github.com/users/Stacey-Gammon/followers","following_url":"https://api.github.com/users/Stacey-Gammon/following{/other_user}","gists_url":"https://api.github.com/users/Stacey-Gammon/gists{/gist_id}","starred_url":"https://api.github.com/users/Stacey-Gammon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stacey-Gammon/subscriptions","organizations_url":"https://api.github.com/users/Stacey-Gammon/orgs","repos_url":"https://api.github.com/users/Stacey-Gammon/repos","events_url":"https://api.github.com/users/Stacey-Gammon/events{/privacy}","received_events_url":"https://api.github.com/users/Stacey-Gammon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Stacey-Gammon/kibana","description":":bar_chart: Kibana analytics and search dashboard for Elasticsearch","fork":true,"url":"https://api.github.com/repos/Stacey-Gammon/kibana","forks_url":"https://api.github.com/repos/Stacey-Gammon/kibana/forks","keys_url":"https://api.github.com/repos/Stacey-Gammon/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Stacey-Gammon/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Stacey-Gammon/kibana/teams","hooks_url":"https://api.github.com/repos/Stacey-Gammon/kibana/hooks","issue_events_url":"https://api.github.com/repos/Stacey-Gammon/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/Stacey-Gammon/kibana/events","assignees_url":"https://api.github.com/repos/Stacey-Gammon/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/Stacey-Gammon/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/Stacey-Gammon/kibana/tags","blobs_url":"https://api.github.com/repos/Stacey-Gammon/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Stacey-Gammon/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Stacey-Gammon/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/Stacey-Gammon/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Stacey-Gammon/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/Stacey-Gammon/kibana/languages","stargazers_url":"https://api.github.com/repos/Stacey-Gammon/kibana/stargazers","contributors_url":"https://api.github.com/repos/Stacey-Gammon/kibana/contributors","subscribers_url":"https://api.github.com/repos/Stacey-Gammon/kibana/subscribers","subscription_url":"https://api.github.com/repos/Stacey-Gammon/kibana/subscription","commits_url":"https://api.github.com/repos/Stacey-Gammon/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/Stacey-Gammon/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/Stacey-Gammon/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/Stacey-Gammon/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/Stacey-Gammon/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/Stacey-Gammon/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Stacey-Gammon/kibana/merges","archive_url":"https://api.github.com/repos/Stacey-Gammon/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Stacey-Gammon/kibana/downloads","issues_url":"https://api.github.com/repos/Stacey-Gammon/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/Stacey-Gammon/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/Stacey-Gammon/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/Stacey-Gammon/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Stacey-Gammon/kibana/labels{/name}","releases_url":"https://api.github.com/repos/Stacey-Gammon/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/Stacey-Gammon/kibana/deployments","created_at":"2016-09-15T19:33:24Z","updated_at":"2016-09-15T19:33:30Z","pushed_at":"2017-02-13T19:11:26Z","git_url":"git://github.com/Stacey-Gammon/kibana.git","ssh_url":"git@github.com:Stacey-Gammon/kibana.git","clone_url":"https://github.com/Stacey-Gammon/kibana.git","svn_url":"https://github.com/Stacey-Gammon/kibana","homepage":"https://www.elastic.co/products/kibana","size":224688,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"133e1607ff76f80008db8eabe46e36e02e67ab9f","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":7833168,"name":"kibana","full_name":"elastic/kibana","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/kibana","description":":bar_chart: Kibana analytics and search dashboard for Elasticsearch","fork":false,"url":"https://api.github.com/repos/elastic/kibana","forks_url":"https://api.github.com/repos/elastic/kibana/forks","keys_url":"https://api.github.com/repos/elastic/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/kibana/teams","hooks_url":"https://api.github.com/repos/elastic/kibana/hooks","issue_events_url":"https://api.github.com/repos/elastic/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/kibana/events","assignees_url":"https://api.github.com/repos/elastic/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/kibana/tags","blobs_url":"https://api.github.com/repos/elastic/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/kibana/languages","stargazers_url":"https://api.github.com/repos/elastic/kibana/stargazers","contributors_url":"https://api.github.com/repos/elastic/kibana/contributors","subscribers_url":"https://api.github.com/repos/elastic/kibana/subscribers","subscription_url":"https://api.github.com/repos/elastic/kibana/subscription","commits_url":"https://api.github.com/repos/elastic/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/kibana/merges","archive_url":"https://api.github.com/repos/elastic/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/kibana/downloads","issues_url":"https://api.github.com/repos/elastic/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/kibana/labels{/name}","releases_url":"https://api.github.com/repos/elastic/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/kibana/deployments","created_at":"2013-01-26T04:00:59Z","updated_at":"2017-02-13T17:27:22Z","pushed_at":"2017-02-13T19:12:27Z","git_url":"git://github.com/elastic/kibana.git","ssh_url":"git@github.com:elastic/kibana.git","clone_url":"https://github.com/elastic/kibana.git","svn_url":"https://github.com/elastic/kibana","homepage":"https://www.elastic.co/products/kibana","size":224837,"stargazers_count":6748,"watchers_count":6748,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2533,"mirror_url":null,"open_issues_count":1466,"forks":2533,"open_issues":1466,"watchers":6748,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/10247"},"html":{"href":"https://github.com/elastic/kibana/pull/10247"},"issue":{"href":"https://api.github.com/repos/elastic/kibana/issues/10247"},"comments":{"href":"https://api.github.com/repos/elastic/kibana/issues/10247/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/kibana/pulls/10247/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/kibana/pulls/10247/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/kibana/statuses/77b49dccdee3f1e791e774c442888002dc02b1b8"}}}}
{"actor":{"display_login":"Stacey-Gammon"}}