{"action":"created","comment":{"url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/pulls/comments/112919327","pull_request_review_id":34267226,"id":112919327,"diff_hunk":"@@ -231,6 +158,8 @@ runTheOpenJDKConfigureCommandAndUseThePrebuildConfigParams()\n \n buildOpenJDK()\n {\n+  cd \"$OPEN_JDK_DIR\" || exit","path":"sbin/build.sh","position":136,"original_position":136,"commit_id":"956492c9664e887393490862475e3b9ce0922049","original_commit_id":"956492c9664e887393490862475e3b9ce0922049","user":{"login":"gdams","id":20224954,"avatar_url":"https://avatars1.githubusercontent.com/u/20224954?v=3","gravatar_id":"","url":"https://api.github.com/users/gdams","html_url":"https://github.com/gdams","followers_url":"https://api.github.com/users/gdams/followers","following_url":"https://api.github.com/users/gdams/following{/other_user}","gists_url":"https://api.github.com/users/gdams/gists{/gist_id}","starred_url":"https://api.github.com/users/gdams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gdams/subscriptions","organizations_url":"https://api.github.com/users/gdams/orgs","repos_url":"https://api.github.com/users/gdams/repos","events_url":"https://api.github.com/users/gdams/events{/privacy}","received_events_url":"https://api.github.com/users/gdams/received_events","type":"User","site_admin":false},"body":"see above","created_at":"2017-04-24T11:09:52Z","updated_at":"2017-04-24T11:11:57Z","html_url":"https://github.com/AdoptOpenJDK/openjdk-build/pull/82#discussion_r112919327","pull_request_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/pulls/82","_links":{"self":{"href":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/pulls/comments/112919327"},"html":{"href":"https://github.com/AdoptOpenJDK/openjdk-build/pull/82#discussion_r112919327"},"pull_request":{"href":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/pulls/82"}}},"pull_request":{"url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/pulls/82","id":117230757,"html_url":"https://github.com/AdoptOpenJDK/openjdk-build/pull/82","diff_url":"https://github.com/AdoptOpenJDK/openjdk-build/pull/82.diff","patch_url":"https://github.com/AdoptOpenJDK/openjdk-build/pull/82.patch","issue_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/issues/82","number":82,"state":"open","locked":false,"title":"Fix docker build (Work In Progress)","user":{"login":"johnoliver","id":1615532,"avatar_url":"https://avatars1.githubusercontent.com/u/1615532?v=3","gravatar_id":"","url":"https://api.github.com/users/johnoliver","html_url":"https://github.com/johnoliver","followers_url":"https://api.github.com/users/johnoliver/followers","following_url":"https://api.github.com/users/johnoliver/following{/other_user}","gists_url":"https://api.github.com/users/johnoliver/gists{/gist_id}","starred_url":"https://api.github.com/users/johnoliver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnoliver/subscriptions","organizations_url":"https://api.github.com/users/johnoliver/orgs","repos_url":"https://api.github.com/users/johnoliver/repos","events_url":"https://api.github.com/users/johnoliver/events{/privacy}","received_events_url":"https://api.github.com/users/johnoliver/received_events","type":"User","site_admin":false},"body":"Creating PR so people can comment on it. \r\n\r\nNot totally happy with this solution. At the moment I am not sure it is worth trying to keep the docker and native builds in the same script, may be cleaner to have separate build scripts and then extract the common parts of each.\r\n\r\nI also cannot guarantee that this does not break the native build as the native build did not work for me to start with...will look into the issues with that separately.","created_at":"2017-04-24T10:12:19Z","updated_at":"2017-04-24T11:11:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4bc5cf2ac1f3c39a62bacb5c6d29ebcaba7f1fdc","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/milestones/3","html_url":"https://github.com/AdoptOpenJDK/openjdk-build/milestone/3","labels_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/milestones/3/labels","id":2429486,"number":3,"title":"1.x.x","description":"","creator":{"login":"karianna","id":180840,"avatar_url":"https://avatars3.githubusercontent.com/u/180840?v=3","gravatar_id":"","url":"https://api.github.com/users/karianna","html_url":"https://github.com/karianna","followers_url":"https://api.github.com/users/karianna/followers","following_url":"https://api.github.com/users/karianna/following{/other_user}","gists_url":"https://api.github.com/users/karianna/gists{/gist_id}","starred_url":"https://api.github.com/users/karianna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karianna/subscriptions","organizations_url":"https://api.github.com/users/karianna/orgs","repos_url":"https://api.github.com/users/karianna/repos","events_url":"https://api.github.com/users/karianna/events{/privacy}","received_events_url":"https://api.github.com/users/karianna/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":2,"state":"open","created_at":"2017-04-03T10:02:41Z","updated_at":"2017-04-24T10:50:18Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/pulls/82/commits","review_comments_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/pulls/82/comments","review_comment_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/issues/82/comments","statuses_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/statuses/956492c9664e887393490862475e3b9ce0922049","head":{"label":"johnoliver:wip","ref":"wip","sha":"956492c9664e887393490862475e3b9ce0922049","user":{"login":"johnoliver","id":1615532,"avatar_url":"https://avatars1.githubusercontent.com/u/1615532?v=3","gravatar_id":"","url":"https://api.github.com/users/johnoliver","html_url":"https://github.com/johnoliver","followers_url":"https://api.github.com/users/johnoliver/followers","following_url":"https://api.github.com/users/johnoliver/following{/other_user}","gists_url":"https://api.github.com/users/johnoliver/gists{/gist_id}","starred_url":"https://api.github.com/users/johnoliver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnoliver/subscriptions","organizations_url":"https://api.github.com/users/johnoliver/orgs","repos_url":"https://api.github.com/users/johnoliver/repos","events_url":"https://api.github.com/users/johnoliver/events{/privacy}","received_events_url":"https://api.github.com/users/johnoliver/received_events","type":"User","site_admin":false},"repo":{"id":89095221,"name":"openjdk-build","full_name":"johnoliver/openjdk-build","owner":{"login":"johnoliver","id":1615532,"avatar_url":"https://avatars1.githubusercontent.com/u/1615532?v=3","gravatar_id":"","url":"https://api.github.com/users/johnoliver","html_url":"https://github.com/johnoliver","followers_url":"https://api.github.com/users/johnoliver/followers","following_url":"https://api.github.com/users/johnoliver/following{/other_user}","gists_url":"https://api.github.com/users/johnoliver/gists{/gist_id}","starred_url":"https://api.github.com/users/johnoliver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnoliver/subscriptions","organizations_url":"https://api.github.com/users/johnoliver/orgs","repos_url":"https://api.github.com/users/johnoliver/repos","events_url":"https://api.github.com/users/johnoliver/events{/privacy}","received_events_url":"https://api.github.com/users/johnoliver/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/johnoliver/openjdk-build","description":"AdoptOpenJDK community common OpenJDK build scripts","fork":true,"url":"https://api.github.com/repos/johnoliver/openjdk-build","forks_url":"https://api.github.com/repos/johnoliver/openjdk-build/forks","keys_url":"https://api.github.com/repos/johnoliver/openjdk-build/keys{/key_id}","collaborators_url":"https://api.github.com/repos/johnoliver/openjdk-build/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/johnoliver/openjdk-build/teams","hooks_url":"https://api.github.com/repos/johnoliver/openjdk-build/hooks","issue_events_url":"https://api.github.com/repos/johnoliver/openjdk-build/issues/events{/number}","events_url":"https://api.github.com/repos/johnoliver/openjdk-build/events","assignees_url":"https://api.github.com/repos/johnoliver/openjdk-build/assignees{/user}","branches_url":"https://api.github.com/repos/johnoliver/openjdk-build/branches{/branch}","tags_url":"https://api.github.com/repos/johnoliver/openjdk-build/tags","blobs_url":"https://api.github.com/repos/johnoliver/openjdk-build/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/johnoliver/openjdk-build/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/johnoliver/openjdk-build/git/refs{/sha}","trees_url":"https://api.github.com/repos/johnoliver/openjdk-build/git/trees{/sha}","statuses_url":"https://api.github.com/repos/johnoliver/openjdk-build/statuses/{sha}","languages_url":"https://api.github.com/repos/johnoliver/openjdk-build/languages","stargazers_url":"https://api.github.com/repos/johnoliver/openjdk-build/stargazers","contributors_url":"https://api.github.com/repos/johnoliver/openjdk-build/contributors","subscribers_url":"https://api.github.com/repos/johnoliver/openjdk-build/subscribers","subscription_url":"https://api.github.com/repos/johnoliver/openjdk-build/subscription","commits_url":"https://api.github.com/repos/johnoliver/openjdk-build/commits{/sha}","git_commits_url":"https://api.github.com/repos/johnoliver/openjdk-build/git/commits{/sha}","comments_url":"https://api.github.com/repos/johnoliver/openjdk-build/comments{/number}","issue_comment_url":"https://api.github.com/repos/johnoliver/openjdk-build/issues/comments{/number}","contents_url":"https://api.github.com/repos/johnoliver/openjdk-build/contents/{+path}","compare_url":"https://api.github.com/repos/johnoliver/openjdk-build/compare/{base}...{head}","merges_url":"https://api.github.com/repos/johnoliver/openjdk-build/merges","archive_url":"https://api.github.com/repos/johnoliver/openjdk-build/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/johnoliver/openjdk-build/downloads","issues_url":"https://api.github.com/repos/johnoliver/openjdk-build/issues{/number}","pulls_url":"https://api.github.com/repos/johnoliver/openjdk-build/pulls{/number}","milestones_url":"https://api.github.com/repos/johnoliver/openjdk-build/milestones{/number}","notifications_url":"https://api.github.com/repos/johnoliver/openjdk-build/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/johnoliver/openjdk-build/labels{/name}","releases_url":"https://api.github.com/repos/johnoliver/openjdk-build/releases{/id}","deployments_url":"https://api.github.com/repos/johnoliver/openjdk-build/deployments","created_at":"2017-04-22T19:50:09Z","updated_at":"2017-04-22T19:50:10Z","pushed_at":"2017-04-23T17:24:13Z","git_url":"git://github.com/johnoliver/openjdk-build.git","ssh_url":"git@github.com:johnoliver/openjdk-build.git","clone_url":"https://github.com/johnoliver/openjdk-build.git","svn_url":"https://github.com/johnoliver/openjdk-build","homepage":"","size":294,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"AdoptOpenJDK:master","ref":"master","sha":"bbbe453eefc74d4a5471868f1257038b5b86aab6","user":{"login":"AdoptOpenJDK","id":1673867,"avatar_url":"https://avatars3.githubusercontent.com/u/1673867?v=3","gravatar_id":"","url":"https://api.github.com/users/AdoptOpenJDK","html_url":"https://github.com/AdoptOpenJDK","followers_url":"https://api.github.com/users/AdoptOpenJDK/followers","following_url":"https://api.github.com/users/AdoptOpenJDK/following{/other_user}","gists_url":"https://api.github.com/users/AdoptOpenJDK/gists{/gist_id}","starred_url":"https://api.github.com/users/AdoptOpenJDK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AdoptOpenJDK/subscriptions","organizations_url":"https://api.github.com/users/AdoptOpenJDK/orgs","repos_url":"https://api.github.com/users/AdoptOpenJDK/repos","events_url":"https://api.github.com/users/AdoptOpenJDK/events{/privacy}","received_events_url":"https://api.github.com/users/AdoptOpenJDK/received_events","type":"Organization","site_admin":false},"repo":{"id":85294562,"name":"openjdk-build","full_name":"AdoptOpenJDK/openjdk-build","owner":{"login":"AdoptOpenJDK","id":1673867,"avatar_url":"https://avatars3.githubusercontent.com/u/1673867?v=3","gravatar_id":"","url":"https://api.github.com/users/AdoptOpenJDK","html_url":"https://github.com/AdoptOpenJDK","followers_url":"https://api.github.com/users/AdoptOpenJDK/followers","following_url":"https://api.github.com/users/AdoptOpenJDK/following{/other_user}","gists_url":"https://api.github.com/users/AdoptOpenJDK/gists{/gist_id}","starred_url":"https://api.github.com/users/AdoptOpenJDK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AdoptOpenJDK/subscriptions","organizations_url":"https://api.github.com/users/AdoptOpenJDK/orgs","repos_url":"https://api.github.com/users/AdoptOpenJDK/repos","events_url":"https://api.github.com/users/AdoptOpenJDK/events{/privacy}","received_events_url":"https://api.github.com/users/AdoptOpenJDK/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AdoptOpenJDK/openjdk-build","description":"AdoptOpenJDK community common OpenJDK build scripts","fork":false,"url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build","forks_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/forks","keys_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/teams","hooks_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/hooks","issue_events_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/issues/events{/number}","events_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/events","assignees_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/assignees{/user}","branches_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/branches{/branch}","tags_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/tags","blobs_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/git/refs{/sha}","trees_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/statuses/{sha}","languages_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/languages","stargazers_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/stargazers","contributors_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/contributors","subscribers_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/subscribers","subscription_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/subscription","commits_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/commits{/sha}","git_commits_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/git/commits{/sha}","comments_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/comments{/number}","issue_comment_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/issues/comments{/number}","contents_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/contents/{+path}","compare_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/merges","archive_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/downloads","issues_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/issues{/number}","pulls_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/pulls{/number}","milestones_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/milestones{/number}","notifications_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/labels{/name}","releases_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/releases{/id}","deployments_url":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/deployments","created_at":"2017-03-17T09:31:50Z","updated_at":"2017-04-19T13:50:31Z","pushed_at":"2017-04-24T10:12:20Z","git_url":"git://github.com/AdoptOpenJDK/openjdk-build.git","ssh_url":"git@github.com:AdoptOpenJDK/openjdk-build.git","clone_url":"https://github.com/AdoptOpenJDK/openjdk-build.git","svn_url":"https://github.com/AdoptOpenJDK/openjdk-build","homepage":"","size":287,"stargazers_count":4,"watchers_count":4,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":30,"forks":7,"open_issues":30,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/pulls/82"},"html":{"href":"https://github.com/AdoptOpenJDK/openjdk-build/pull/82"},"issue":{"href":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/issues/82"},"comments":{"href":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/issues/82/comments"},"review_comments":{"href":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/pulls/82/comments"},"review_comment":{"href":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/pulls/82/commits"},"statuses":{"href":"https://api.github.com/repos/AdoptOpenJDK/openjdk-build/statuses/956492c9664e887393490862475e3b9ce0922049"}}}}
{"actor":{"display_login":"gdams"}}