{"action":"created","comment":{"url":"https://api.github.com/repos/translate/pootle/pulls/comments/97621918","pull_request_review_id":18237660,"id":97621918,"diff_hunk":"@@ -90,15 +90,13 @@ def revision(self):\n         return revision.get(self.context.__class__)(\n             self.context.directory).get(key=\"stats\")[:10] or \"0\"\n \n-    @property\n-    def relative_path(self):\n-        return \"offline_tm/%s/%s\" % (\n-            self.context.language.code,\n-            self.filename)\n-\n     def get_url(self):\n         if self.exported_revision:\n-            return urljoin(settings.MEDIA_URL, self.relative_path)\n+            relative_path = \"offline_tm/%s/%s\" % (\n+                self.context.language.code,\n+                self.get_filename(self.exported_revision)\n+            )\n+            return urljoin(settings.MEDIA_URL, relative_path)","path":"pootle/apps/import_export/utils.py","position":17,"original_position":17,"commit_id":"ebedb7221dd78d60659c50228b5cbb0dd36c6570","original_commit_id":"ebedb7221dd78d60659c50228b5cbb0dd36c6570","user":{"login":"phlax","id":454682,"avatar_url":"https://avatars.githubusercontent.com/u/454682?v=3","gravatar_id":"","url":"https://api.github.com/users/phlax","html_url":"https://github.com/phlax","followers_url":"https://api.github.com/users/phlax/followers","following_url":"https://api.github.com/users/phlax/following{/other_user}","gists_url":"https://api.github.com/users/phlax/gists{/gist_id}","starred_url":"https://api.github.com/users/phlax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phlax/subscriptions","organizations_url":"https://api.github.com/users/phlax/orgs","repos_url":"https://api.github.com/users/phlax/repos","events_url":"https://api.github.com/users/phlax/events{/privacy}","received_events_url":"https://api.github.com/users/phlax/received_events","type":"User","site_admin":false},"body":"im wondering if this wants to use urlparse.urljoin https://docs.python.org/2/library/urlparse.html#urlparse.urljoin","created_at":"2017-01-24T18:53:57Z","updated_at":"2017-01-24T18:53:57Z","html_url":"https://github.com/translate/pootle/pull/5880#discussion_r97621918","pull_request_url":"https://api.github.com/repos/translate/pootle/pulls/5880","_links":{"self":{"href":"https://api.github.com/repos/translate/pootle/pulls/comments/97621918"},"html":{"href":"https://github.com/translate/pootle/pull/5880#discussion_r97621918"},"pull_request":{"href":"https://api.github.com/repos/translate/pootle/pulls/5880"}}},"pull_request":{"url":"https://api.github.com/repos/translate/pootle/pulls/5880","id":102980137,"html_url":"https://github.com/translate/pootle/pull/5880","diff_url":"https://github.com/translate/pootle/pull/5880.diff","patch_url":"https://github.com/translate/pootle/pull/5880.patch","issue_url":"https://api.github.com/repos/translate/pootle/issues/5880","number":5880,"state":"open","locked":false,"title":"Fix exported tmx url","user":{"login":"ta2-1","id":682845,"avatar_url":"https://avatars.githubusercontent.com/u/682845?v=3","gravatar_id":"","url":"https://api.github.com/users/ta2-1","html_url":"https://github.com/ta2-1","followers_url":"https://api.github.com/users/ta2-1/followers","following_url":"https://api.github.com/users/ta2-1/following{/other_user}","gists_url":"https://api.github.com/users/ta2-1/gists{/gist_id}","starred_url":"https://api.github.com/users/ta2-1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ta2-1/subscriptions","organizations_url":"https://api.github.com/users/ta2-1/orgs","repos_url":"https://api.github.com/users/ta2-1/repos","events_url":"https://api.github.com/users/ta2-1/events{/privacy}","received_events_url":"https://api.github.com/users/ta2-1/received_events","type":"User","site_admin":false},"body":"Use last_exported_revision for generating exported TMX url.","created_at":"2017-01-24T18:51:12Z","updated_at":"2017-01-24T18:53:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8ad4d3788357f2a668c751011afa7b6d0e2b6d7d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/translate/pootle/pulls/5880/commits","review_comments_url":"https://api.github.com/repos/translate/pootle/pulls/5880/comments","review_comment_url":"https://api.github.com/repos/translate/pootle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/translate/pootle/issues/5880/comments","statuses_url":"https://api.github.com/repos/translate/pootle/statuses/ebedb7221dd78d60659c50228b5cbb0dd36c6570","head":{"label":"ta2-1:fix-exported-tmx-url","ref":"fix-exported-tmx-url","sha":"ebedb7221dd78d60659c50228b5cbb0dd36c6570","user":{"login":"ta2-1","id":682845,"avatar_url":"https://avatars.githubusercontent.com/u/682845?v=3","gravatar_id":"","url":"https://api.github.com/users/ta2-1","html_url":"https://github.com/ta2-1","followers_url":"https://api.github.com/users/ta2-1/followers","following_url":"https://api.github.com/users/ta2-1/following{/other_user}","gists_url":"https://api.github.com/users/ta2-1/gists{/gist_id}","starred_url":"https://api.github.com/users/ta2-1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ta2-1/subscriptions","organizations_url":"https://api.github.com/users/ta2-1/orgs","repos_url":"https://api.github.com/users/ta2-1/repos","events_url":"https://api.github.com/users/ta2-1/events{/privacy}","received_events_url":"https://api.github.com/users/ta2-1/received_events","type":"User","site_admin":false},"repo":{"id":8358664,"name":"pootle","full_name":"ta2-1/pootle","owner":{"login":"ta2-1","id":682845,"avatar_url":"https://avatars.githubusercontent.com/u/682845?v=3","gravatar_id":"","url":"https://api.github.com/users/ta2-1","html_url":"https://github.com/ta2-1","followers_url":"https://api.github.com/users/ta2-1/followers","following_url":"https://api.github.com/users/ta2-1/following{/other_user}","gists_url":"https://api.github.com/users/ta2-1/gists{/gist_id}","starred_url":"https://api.github.com/users/ta2-1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ta2-1/subscriptions","organizations_url":"https://api.github.com/users/ta2-1/orgs","repos_url":"https://api.github.com/users/ta2-1/repos","events_url":"https://api.github.com/users/ta2-1/events{/privacy}","received_events_url":"https://api.github.com/users/ta2-1/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ta2-1/pootle","description":"Online translation tool","fork":true,"url":"https://api.github.com/repos/ta2-1/pootle","forks_url":"https://api.github.com/repos/ta2-1/pootle/forks","keys_url":"https://api.github.com/repos/ta2-1/pootle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ta2-1/pootle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ta2-1/pootle/teams","hooks_url":"https://api.github.com/repos/ta2-1/pootle/hooks","issue_events_url":"https://api.github.com/repos/ta2-1/pootle/issues/events{/number}","events_url":"https://api.github.com/repos/ta2-1/pootle/events","assignees_url":"https://api.github.com/repos/ta2-1/pootle/assignees{/user}","branches_url":"https://api.github.com/repos/ta2-1/pootle/branches{/branch}","tags_url":"https://api.github.com/repos/ta2-1/pootle/tags","blobs_url":"https://api.github.com/repos/ta2-1/pootle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ta2-1/pootle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ta2-1/pootle/git/refs{/sha}","trees_url":"https://api.github.com/repos/ta2-1/pootle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ta2-1/pootle/statuses/{sha}","languages_url":"https://api.github.com/repos/ta2-1/pootle/languages","stargazers_url":"https://api.github.com/repos/ta2-1/pootle/stargazers","contributors_url":"https://api.github.com/repos/ta2-1/pootle/contributors","subscribers_url":"https://api.github.com/repos/ta2-1/pootle/subscribers","subscription_url":"https://api.github.com/repos/ta2-1/pootle/subscription","commits_url":"https://api.github.com/repos/ta2-1/pootle/commits{/sha}","git_commits_url":"https://api.github.com/repos/ta2-1/pootle/git/commits{/sha}","comments_url":"https://api.github.com/repos/ta2-1/pootle/comments{/number}","issue_comment_url":"https://api.github.com/repos/ta2-1/pootle/issues/comments{/number}","contents_url":"https://api.github.com/repos/ta2-1/pootle/contents/{+path}","compare_url":"https://api.github.com/repos/ta2-1/pootle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ta2-1/pootle/merges","archive_url":"https://api.github.com/repos/ta2-1/pootle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ta2-1/pootle/downloads","issues_url":"https://api.github.com/repos/ta2-1/pootle/issues{/number}","pulls_url":"https://api.github.com/repos/ta2-1/pootle/pulls{/number}","milestones_url":"https://api.github.com/repos/ta2-1/pootle/milestones{/number}","notifications_url":"https://api.github.com/repos/ta2-1/pootle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ta2-1/pootle/labels{/name}","releases_url":"https://api.github.com/repos/ta2-1/pootle/releases{/id}","deployments_url":"https://api.github.com/repos/ta2-1/pootle/deployments","created_at":"2013-02-22T14:19:00Z","updated_at":"2015-02-04T13:34:18Z","pushed_at":"2017-01-24T18:47:15Z","git_url":"git://github.com/ta2-1/pootle.git","ssh_url":"git@github.com:ta2-1/pootle.git","clone_url":"https://github.com/ta2-1/pootle.git","svn_url":"https://github.com/ta2-1/pootle","homepage":"http://pootle.translatehouse.org","size":102528,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"translate:master","ref":"master","sha":"25a13f7ad0ff918a49108ce21517baedd87534aa","user":{"login":"translate","id":1538178,"avatar_url":"https://avatars.githubusercontent.com/u/1538178?v=3","gravatar_id":"","url":"https://api.github.com/users/translate","html_url":"https://github.com/translate","followers_url":"https://api.github.com/users/translate/followers","following_url":"https://api.github.com/users/translate/following{/other_user}","gists_url":"https://api.github.com/users/translate/gists{/gist_id}","starred_url":"https://api.github.com/users/translate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/translate/subscriptions","organizations_url":"https://api.github.com/users/translate/orgs","repos_url":"https://api.github.com/users/translate/repos","events_url":"https://api.github.com/users/translate/events{/privacy}","received_events_url":"https://api.github.com/users/translate/received_events","type":"Organization","site_admin":false},"repo":{"id":3769702,"name":"pootle","full_name":"translate/pootle","owner":{"login":"translate","id":1538178,"avatar_url":"https://avatars.githubusercontent.com/u/1538178?v=3","gravatar_id":"","url":"https://api.github.com/users/translate","html_url":"https://github.com/translate","followers_url":"https://api.github.com/users/translate/followers","following_url":"https://api.github.com/users/translate/following{/other_user}","gists_url":"https://api.github.com/users/translate/gists{/gist_id}","starred_url":"https://api.github.com/users/translate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/translate/subscriptions","organizations_url":"https://api.github.com/users/translate/orgs","repos_url":"https://api.github.com/users/translate/repos","events_url":"https://api.github.com/users/translate/events{/privacy}","received_events_url":"https://api.github.com/users/translate/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/translate/pootle","description":"Online translation tool","fork":false,"url":"https://api.github.com/repos/translate/pootle","forks_url":"https://api.github.com/repos/translate/pootle/forks","keys_url":"https://api.github.com/repos/translate/pootle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/translate/pootle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/translate/pootle/teams","hooks_url":"https://api.github.com/repos/translate/pootle/hooks","issue_events_url":"https://api.github.com/repos/translate/pootle/issues/events{/number}","events_url":"https://api.github.com/repos/translate/pootle/events","assignees_url":"https://api.github.com/repos/translate/pootle/assignees{/user}","branches_url":"https://api.github.com/repos/translate/pootle/branches{/branch}","tags_url":"https://api.github.com/repos/translate/pootle/tags","blobs_url":"https://api.github.com/repos/translate/pootle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/translate/pootle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/translate/pootle/git/refs{/sha}","trees_url":"https://api.github.com/repos/translate/pootle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/translate/pootle/statuses/{sha}","languages_url":"https://api.github.com/repos/translate/pootle/languages","stargazers_url":"https://api.github.com/repos/translate/pootle/stargazers","contributors_url":"https://api.github.com/repos/translate/pootle/contributors","subscribers_url":"https://api.github.com/repos/translate/pootle/subscribers","subscription_url":"https://api.github.com/repos/translate/pootle/subscription","commits_url":"https://api.github.com/repos/translate/pootle/commits{/sha}","git_commits_url":"https://api.github.com/repos/translate/pootle/git/commits{/sha}","comments_url":"https://api.github.com/repos/translate/pootle/comments{/number}","issue_comment_url":"https://api.github.com/repos/translate/pootle/issues/comments{/number}","contents_url":"https://api.github.com/repos/translate/pootle/contents/{+path}","compare_url":"https://api.github.com/repos/translate/pootle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/translate/pootle/merges","archive_url":"https://api.github.com/repos/translate/pootle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/translate/pootle/downloads","issues_url":"https://api.github.com/repos/translate/pootle/issues{/number}","pulls_url":"https://api.github.com/repos/translate/pootle/pulls{/number}","milestones_url":"https://api.github.com/repos/translate/pootle/milestones{/number}","notifications_url":"https://api.github.com/repos/translate/pootle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/translate/pootle/labels{/name}","releases_url":"https://api.github.com/repos/translate/pootle/releases{/id}","deployments_url":"https://api.github.com/repos/translate/pootle/deployments","created_at":"2012-03-19T23:06:03Z","updated_at":"2017-01-24T17:21:48Z","pushed_at":"2017-01-24T18:51:13Z","git_url":"git://github.com/translate/pootle.git","ssh_url":"git@github.com:translate/pootle.git","clone_url":"https://github.com/translate/pootle.git","svn_url":"https://github.com/translate/pootle","homepage":"http://pootle.translatehouse.org","size":109924,"stargazers_count":780,"watchers_count":780,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":213,"mirror_url":null,"open_issues_count":490,"forks":213,"open_issues":490,"watchers":780,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/translate/pootle/pulls/5880"},"html":{"href":"https://github.com/translate/pootle/pull/5880"},"issue":{"href":"https://api.github.com/repos/translate/pootle/issues/5880"},"comments":{"href":"https://api.github.com/repos/translate/pootle/issues/5880/comments"},"review_comments":{"href":"https://api.github.com/repos/translate/pootle/pulls/5880/comments"},"review_comment":{"href":"https://api.github.com/repos/translate/pootle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/translate/pootle/pulls/5880/commits"},"statuses":{"href":"https://api.github.com/repos/translate/pootle/statuses/ebedb7221dd78d60659c50228b5cbb0dd36c6570"}}}}
{"actor":{"display_login":"phlax"}}