{"action":"opened","number":3446,"pull_request":{"url":"https://api.github.com/repos/r888888888/danbooru/pulls/3446","id":159719941,"html_url":"https://github.com/r888888888/danbooru/pull/3446","diff_url":"https://github.com/r888888888/danbooru/pull/3446.diff","patch_url":"https://github.com/r888888888/danbooru/pull/3446.patch","issue_url":"https://api.github.com/repos/r888888888/danbooru/issues/3446","number":3446,"state":"open","locked":false,"title":"Fix cutoff for what is considered an added tag","user":{"login":"BrokenEagle","id":21149935,"avatar_url":"https://avatars3.githubusercontent.com/u/21149935?v=4","gravatar_id":"","url":"https://api.github.com/users/BrokenEagle","html_url":"https://github.com/BrokenEagle","followers_url":"https://api.github.com/users/BrokenEagle/followers","following_url":"https://api.github.com/users/BrokenEagle/following{/other_user}","gists_url":"https://api.github.com/users/BrokenEagle/gists{/gist_id}","starred_url":"https://api.github.com/users/BrokenEagle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrokenEagle/subscriptions","organizations_url":"https://api.github.com/users/BrokenEagle/orgs","repos_url":"https://api.github.com/users/BrokenEagle/repos","events_url":"https://api.github.com/users/BrokenEagle/events{/privacy}","received_events_url":"https://api.github.com/users/BrokenEagle/received_events","type":"User","site_admin":false},"body":"@nonamethanks noticed this issue and brought it up on Discord.  Basically, Danbooru was considering all tags with a post count of 1 to still be new tags by the tag validator.  This caused the notice to appear when incrementing the post count from 1 to 2.\r\n\r\nThis is because at the time that the validator function is running, the delayed job which increments the post count has not yet run.  Therefore, it should only accept tags that have a post count of 0 and below.\r\n\r\nI checked this pull on both new and existing empty tags, and it worked for both cases.","created_at":"2017-12-21T18:17:21Z","updated_at":"2017-12-21T18:17:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/r888888888/danbooru/pulls/3446/commits","review_comments_url":"https://api.github.com/repos/r888888888/danbooru/pulls/3446/comments","review_comment_url":"https://api.github.com/repos/r888888888/danbooru/pulls/comments{/number}","comments_url":"https://api.github.com/repos/r888888888/danbooru/issues/3446/comments","statuses_url":"https://api.github.com/repos/r888888888/danbooru/statuses/a9734151397b2b6b219d353a79f252697fa00bcb","head":{"label":"BrokenEagle:fix-validator-addtag-cutoffs","ref":"fix-validator-addtag-cutoffs","sha":"a9734151397b2b6b219d353a79f252697fa00bcb","user":{"login":"BrokenEagle","id":21149935,"avatar_url":"https://avatars3.githubusercontent.com/u/21149935?v=4","gravatar_id":"","url":"https://api.github.com/users/BrokenEagle","html_url":"https://github.com/BrokenEagle","followers_url":"https://api.github.com/users/BrokenEagle/followers","following_url":"https://api.github.com/users/BrokenEagle/following{/other_user}","gists_url":"https://api.github.com/users/BrokenEagle/gists{/gist_id}","starred_url":"https://api.github.com/users/BrokenEagle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrokenEagle/subscriptions","organizations_url":"https://api.github.com/users/BrokenEagle/orgs","repos_url":"https://api.github.com/users/BrokenEagle/repos","events_url":"https://api.github.com/users/BrokenEagle/events{/privacy}","received_events_url":"https://api.github.com/users/BrokenEagle/received_events","type":"User","site_admin":false},"repo":{"id":90932116,"name":"danbooru","full_name":"BrokenEagle/danbooru","owner":{"login":"BrokenEagle","id":21149935,"avatar_url":"https://avatars3.githubusercontent.com/u/21149935?v=4","gravatar_id":"","url":"https://api.github.com/users/BrokenEagle","html_url":"https://github.com/BrokenEagle","followers_url":"https://api.github.com/users/BrokenEagle/followers","following_url":"https://api.github.com/users/BrokenEagle/following{/other_user}","gists_url":"https://api.github.com/users/BrokenEagle/gists{/gist_id}","starred_url":"https://api.github.com/users/BrokenEagle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrokenEagle/subscriptions","organizations_url":"https://api.github.com/users/BrokenEagle/orgs","repos_url":"https://api.github.com/users/BrokenEagle/repos","events_url":"https://api.github.com/users/BrokenEagle/events{/privacy}","received_events_url":"https://api.github.com/users/BrokenEagle/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/BrokenEagle/danbooru","description":"Danbooru is a taggable image board written in Rails 4.","fork":true,"url":"https://api.github.com/repos/BrokenEagle/danbooru","forks_url":"https://api.github.com/repos/BrokenEagle/danbooru/forks","keys_url":"https://api.github.com/repos/BrokenEagle/danbooru/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BrokenEagle/danbooru/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BrokenEagle/danbooru/teams","hooks_url":"https://api.github.com/repos/BrokenEagle/danbooru/hooks","issue_events_url":"https://api.github.com/repos/BrokenEagle/danbooru/issues/events{/number}","events_url":"https://api.github.com/repos/BrokenEagle/danbooru/events","assignees_url":"https://api.github.com/repos/BrokenEagle/danbooru/assignees{/user}","branches_url":"https://api.github.com/repos/BrokenEagle/danbooru/branches{/branch}","tags_url":"https://api.github.com/repos/BrokenEagle/danbooru/tags","blobs_url":"https://api.github.com/repos/BrokenEagle/danbooru/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BrokenEagle/danbooru/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BrokenEagle/danbooru/git/refs{/sha}","trees_url":"https://api.github.com/repos/BrokenEagle/danbooru/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BrokenEagle/danbooru/statuses/{sha}","languages_url":"https://api.github.com/repos/BrokenEagle/danbooru/languages","stargazers_url":"https://api.github.com/repos/BrokenEagle/danbooru/stargazers","contributors_url":"https://api.github.com/repos/BrokenEagle/danbooru/contributors","subscribers_url":"https://api.github.com/repos/BrokenEagle/danbooru/subscribers","subscription_url":"https://api.github.com/repos/BrokenEagle/danbooru/subscription","commits_url":"https://api.github.com/repos/BrokenEagle/danbooru/commits{/sha}","git_commits_url":"https://api.github.com/repos/BrokenEagle/danbooru/git/commits{/sha}","comments_url":"https://api.github.com/repos/BrokenEagle/danbooru/comments{/number}","issue_comment_url":"https://api.github.com/repos/BrokenEagle/danbooru/issues/comments{/number}","contents_url":"https://api.github.com/repos/BrokenEagle/danbooru/contents/{+path}","compare_url":"https://api.github.com/repos/BrokenEagle/danbooru/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BrokenEagle/danbooru/merges","archive_url":"https://api.github.com/repos/BrokenEagle/danbooru/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BrokenEagle/danbooru/downloads","issues_url":"https://api.github.com/repos/BrokenEagle/danbooru/issues{/number}","pulls_url":"https://api.github.com/repos/BrokenEagle/danbooru/pulls{/number}","milestones_url":"https://api.github.com/repos/BrokenEagle/danbooru/milestones{/number}","notifications_url":"https://api.github.com/repos/BrokenEagle/danbooru/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BrokenEagle/danbooru/labels{/name}","releases_url":"https://api.github.com/repos/BrokenEagle/danbooru/releases{/id}","deployments_url":"https://api.github.com/repos/BrokenEagle/danbooru/deployments","created_at":"2017-05-11T03:13:11Z","updated_at":"2017-10-14T17:44:31Z","pushed_at":"2017-12-21T18:11:20Z","git_url":"git://github.com/BrokenEagle/danbooru.git","ssh_url":"git@github.com:BrokenEagle/danbooru.git","clone_url":"https://github.com/BrokenEagle/danbooru.git","svn_url":"https://github.com/BrokenEagle/danbooru","homepage":"http://testbooru.donmai.us","size":45046,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"r888888888:master","ref":"master","sha":"b48d5e59ad6fd8a54f9ba7cdc2fb706c8eaef7c6","user":{"login":"r888888888","id":197031,"avatar_url":"https://avatars1.githubusercontent.com/u/197031?v=4","gravatar_id":"","url":"https://api.github.com/users/r888888888","html_url":"https://github.com/r888888888","followers_url":"https://api.github.com/users/r888888888/followers","following_url":"https://api.github.com/users/r888888888/following{/other_user}","gists_url":"https://api.github.com/users/r888888888/gists{/gist_id}","starred_url":"https://api.github.com/users/r888888888/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/r888888888/subscriptions","organizations_url":"https://api.github.com/users/r888888888/orgs","repos_url":"https://api.github.com/users/r888888888/repos","events_url":"https://api.github.com/users/r888888888/events{/privacy}","received_events_url":"https://api.github.com/users/r888888888/received_events","type":"User","site_admin":false},"repo":{"id":502760,"name":"danbooru","full_name":"r888888888/danbooru","owner":{"login":"r888888888","id":197031,"avatar_url":"https://avatars1.githubusercontent.com/u/197031?v=4","gravatar_id":"","url":"https://api.github.com/users/r888888888","html_url":"https://github.com/r888888888","followers_url":"https://api.github.com/users/r888888888/followers","following_url":"https://api.github.com/users/r888888888/following{/other_user}","gists_url":"https://api.github.com/users/r888888888/gists{/gist_id}","starred_url":"https://api.github.com/users/r888888888/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/r888888888/subscriptions","organizations_url":"https://api.github.com/users/r888888888/orgs","repos_url":"https://api.github.com/users/r888888888/repos","events_url":"https://api.github.com/users/r888888888/events{/privacy}","received_events_url":"https://api.github.com/users/r888888888/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/r888888888/danbooru","description":"Danbooru is a taggable image board written in Rails 4.","fork":false,"url":"https://api.github.com/repos/r888888888/danbooru","forks_url":"https://api.github.com/repos/r888888888/danbooru/forks","keys_url":"https://api.github.com/repos/r888888888/danbooru/keys{/key_id}","collaborators_url":"https://api.github.com/repos/r888888888/danbooru/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/r888888888/danbooru/teams","hooks_url":"https://api.github.com/repos/r888888888/danbooru/hooks","issue_events_url":"https://api.github.com/repos/r888888888/danbooru/issues/events{/number}","events_url":"https://api.github.com/repos/r888888888/danbooru/events","assignees_url":"https://api.github.com/repos/r888888888/danbooru/assignees{/user}","branches_url":"https://api.github.com/repos/r888888888/danbooru/branches{/branch}","tags_url":"https://api.github.com/repos/r888888888/danbooru/tags","blobs_url":"https://api.github.com/repos/r888888888/danbooru/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/r888888888/danbooru/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/r888888888/danbooru/git/refs{/sha}","trees_url":"https://api.github.com/repos/r888888888/danbooru/git/trees{/sha}","statuses_url":"https://api.github.com/repos/r888888888/danbooru/statuses/{sha}","languages_url":"https://api.github.com/repos/r888888888/danbooru/languages","stargazers_url":"https://api.github.com/repos/r888888888/danbooru/stargazers","contributors_url":"https://api.github.com/repos/r888888888/danbooru/contributors","subscribers_url":"https://api.github.com/repos/r888888888/danbooru/subscribers","subscription_url":"https://api.github.com/repos/r888888888/danbooru/subscription","commits_url":"https://api.github.com/repos/r888888888/danbooru/commits{/sha}","git_commits_url":"https://api.github.com/repos/r888888888/danbooru/git/commits{/sha}","comments_url":"https://api.github.com/repos/r888888888/danbooru/comments{/number}","issue_comment_url":"https://api.github.com/repos/r888888888/danbooru/issues/comments{/number}","contents_url":"https://api.github.com/repos/r888888888/danbooru/contents/{+path}","compare_url":"https://api.github.com/repos/r888888888/danbooru/compare/{base}...{head}","merges_url":"https://api.github.com/repos/r888888888/danbooru/merges","archive_url":"https://api.github.com/repos/r888888888/danbooru/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/r888888888/danbooru/downloads","issues_url":"https://api.github.com/repos/r888888888/danbooru/issues{/number}","pulls_url":"https://api.github.com/repos/r888888888/danbooru/pulls{/number}","milestones_url":"https://api.github.com/repos/r888888888/danbooru/milestones{/number}","notifications_url":"https://api.github.com/repos/r888888888/danbooru/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/r888888888/danbooru/labels{/name}","releases_url":"https://api.github.com/repos/r888888888/danbooru/releases{/id}","deployments_url":"https://api.github.com/repos/r888888888/danbooru/deployments","created_at":"2010-02-04T19:59:27Z","updated_at":"2017-12-20T16:18:12Z","pushed_at":"2017-12-21T01:45:06Z","git_url":"git://github.com/r888888888/danbooru.git","ssh_url":"git@github.com:r888888888/danbooru.git","clone_url":"https://github.com/r888888888/danbooru.git","svn_url":"https://github.com/r888888888/danbooru","homepage":"http://testbooru.donmai.us","size":45104,"stargazers_count":525,"watchers_count":525,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":138,"mirror_url":null,"archived":false,"open_issues_count":219,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":138,"open_issues":219,"watchers":525,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/r888888888/danbooru/pulls/3446"},"html":{"href":"https://github.com/r888888888/danbooru/pull/3446"},"issue":{"href":"https://api.github.com/repos/r888888888/danbooru/issues/3446"},"comments":{"href":"https://api.github.com/repos/r888888888/danbooru/issues/3446/comments"},"review_comments":{"href":"https://api.github.com/repos/r888888888/danbooru/pulls/3446/comments"},"review_comment":{"href":"https://api.github.com/repos/r888888888/danbooru/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/r888888888/danbooru/pulls/3446/commits"},"statuses":{"href":"https://api.github.com/repos/r888888888/danbooru/statuses/a9734151397b2b6b219d353a79f252697fa00bcb"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"BrokenEagle"}}