{"push_id":1808321756,"size":84,"distinct_size":5,"ref":"refs/heads/th/master-no-ignore-carrier-pr18","head":"deff2d80f458f8ba6c52ef8eded871b3d62966ce","before":"3ba0ef6a14898d5d4a1e8bf11fe19b4be6930e46","commits":[{"sha":"74335004f37bb554facc8394a5eb7d05e30f97d8","author":{"name":"Thomas Haller","email":"9d2a1d242d3f6644641a729c1b364077592f4cb6@redhat.com"},"message":"wifi: exclude AP mode wifi connection from hidden-scan list\n\nIt makes no sense to scan for those.","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/74335004f37bb554facc8394a5eb7d05e30f97d8"},{"sha":"c5fb410998b395e0a0fb9e0c22e86befa69b7599","author":{"name":"Thomas Haller","email":"9d2a1d242d3f6644641a729c1b364077592f4cb6@redhat.com"},"message":"wifi: fix completing Wi-Fi connection for AP mode\n\nIn AP mode we should not look up an access point. It is wrong to\ndo, and it ends up marking the connection as hidden.\n\nIt seems wrong to me that if the client explicitly set\nhidden=FALSE before AddAndActivate(), that complete_connection()\nwould still set it to TRUE if it cannot find the access\npoint. That is, because complete_connection() does not know\nwhether hidden was omitted or set intentionally by the user.","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/c5fb410998b395e0a0fb9e0c22e86befa69b7599"},{"sha":"8870b7ab129463f10bd34da71555ff19ecdb307f","author":{"name":"Thomas Haller","email":"9d2a1d242d3f6644641a729c1b364077592f4cb6@redhat.com"},"message":"wifi: change logging about probe-scanning SSIDs\n\nThe SSID is not \"hidden\". It is the wildcard SSID.\n\nSee build_hidden_probe_list().","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/8870b7ab129463f10bd34da71555ff19ecdb307f"},{"sha":"14529f5b4635f8b856b7698a2eebc687b31c516e","author":{"name":"Thomas Haller","email":"9d2a1d242d3f6644641a729c1b364077592f4cb6@redhat.com"},"message":"wifi: merge branch 'th/wifi-ap-hidden'\n\nhttps://github.com/NetworkManager/NetworkManager/pull/22","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/14529f5b4635f8b856b7698a2eebc687b31c516e"},{"sha":"f25e008e2fe655bbddbb8a66612a9d141e982049","author":{"name":"Beniamino Galvani","email":"517b181d73f6c621ed1e08338a8189fe733e83b8@redhat.com"},"message":"libnm-core: remove unsupported bond options during normalization\n\nIn an ideal world, we should not validate connections containing\noptions not valid for the current bond mode. However adding such\nrestriction now means that during an upgrade to the new NM version\nsome connections that were valid before become invalid, possibly\ndisrupting connectivity.\n\nInstead, consider invalid options as a normalizable error and remove\nthem during normalization.\n\nConverting the setting to a \"canonical\" form without invalid options\nis important for the connection matching logic, where such invalid\noptions can cause false mismatches.","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/f25e008e2fe655bbddbb8a66612a9d141e982049"},{"sha":"056a973a4fdb68abe8bc7bfc5f31250345d71f21","author":{"name":"Beniamino Galvani","email":"517b181d73f6c621ed1e08338a8189fe733e83b8@redhat.com"},"message":"bond: add only supported options to the generated connection\n\nUpstream commit [1] changed in the kernel the default value of\ntlb_dynamic_lb bond from 1 to 0 when the mode is not tlb. This is not\nwrong, as the option value doesn't really matter for other modes, but\nit breaks the connection matching because we read back a 0 value when\nwe expect a default of 1.\n\nFix this in a generic way by ignoring altogether options that are not\nrelevant for the current bond mode, because they are removed from the\nconnection during normalization.\n\n[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=8b426dc54cf4056984bab7dfa48c92ee79a46434\n\nhttps://bugzilla.redhat.com/show_bug.cgi?id=1457909","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/056a973a4fdb68abe8bc7bfc5f31250345d71f21"},{"sha":"4be0cdd358a9253e874eaaf9e244339d8fc6aa33","author":{"name":"Beniamino Galvani","email":"517b181d73f6c621ed1e08338a8189fe733e83b8@redhat.com"},"message":"bond: merge branch 'bg/bond-option-normalize-rh1457909'\n\nNormalize bond options to ensure a correct connection matching upon\ndaemon restart.\n\nhttps://bugzilla.redhat.com/show_bug.cgi?id=1457909","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/4be0cdd358a9253e874eaaf9e244339d8fc6aa33"},{"sha":"02e7476e9fd0f4248009ce8eaa7870ba05e2504e","author":{"name":"Thomas Haller","email":"9d2a1d242d3f6644641a729c1b364077592f4cb6@redhat.com"},"message":"device: mark device as sys-iface-state=external when assuming connection\n\nSince commit 74dac5f (nm-manager: try assuming connections on managed devices),\nand commit f4226e7 (manager: avoid generating in memory connections\nduring startup for managed devices), recheck_assume_connection() also\nassumes connections on devices that are currently not in sys-iface-state\n\"external\".\n\nThat is correct, as also for fully managed devices (which are currently\nin disconnected state), we want to assume external connections. However,\nwhen doing that, we must reset the sys-iface-state to external.\n\nhttps://bugzilla.redhat.com/show_bug.cgi?id=1457242","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/02e7476e9fd0f4248009ce8eaa7870ba05e2504e"},{"sha":"7415ad778eb00903a666ac1302c941e4ab2e267b","author":{"name":"Beniamino Galvani","email":"517b181d73f6c621ed1e08338a8189fe733e83b8@redhat.com"},"message":"libnm-core: fix typo in 802.1x doc comment","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/7415ad778eb00903a666ac1302c941e4ab2e267b"},{"sha":"f387614b918a3ce4315176e8f82bbb3bd7f8b405","author":{"name":"Thomas Haller","email":"9d2a1d242d3f6644641a729c1b364077592f4cb6@redhat.com"},"message":"core: print the connection.type in nm_utils_log_connection_diff()","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/f387614b918a3ce4315176e8f82bbb3bd7f8b405"},{"sha":"11d852a14895404f1a954b55674353a14c1b35a2","author":{"name":"Thomas Haller","email":"9d2a1d242d3f6644641a729c1b364077592f4cb6@redhat.com"},"message":"core: minor refactoring condition in validate_activation_request()","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/11d852a14895404f1a954b55674353a14c1b35a2"},{"sha":"c7e9f97800ed350340e38371ac38cad590136516","author":{"name":"Thomas Haller","email":"9d2a1d242d3f6644641a729c1b364077592f4cb6@redhat.com"},"message":"libnm/trivial: rename _nm_register_setting function to _nm_register_setting_impl\n\nAvoid having the function _nm_register_setting() shadowed by a macro\nof the same name, but different behavior/arguments.","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/c7e9f97800ed350340e38371ac38cad590136516"},{"sha":"a973eacb3b2811ba977f1d2b36633a5c814b74e8","author":{"name":"Thomas Haller","email":"9d2a1d242d3f6644641a729c1b364077592f4cb6@redhat.com"},"message":"libnm: add enum for setting priorities\n\nUsing plain numbers make it cumbersome to grep for\nsetting types by priority.\n\nThe only downside is, that with the enum values it\nis no longer obvious which value has higher or lower\npriority.\n\nAlso, introduce NM_SETTING_PRIORITY_INVALID. This is what\n_nm_setting_type_get_base_type_priority() returns. For the moment\nit still has the same numerical value 0 as before. Later, that\nshall be distinct from NM_SETTING_PRIORITY_CONNECTION.","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/a973eacb3b2811ba977f1d2b36633a5c814b74e8"},{"sha":"488029d74b6d25abc857e46067cf63588a5dbbe5","author":{"name":"Thomas Haller","email":"9d2a1d242d3f6644641a729c1b364077592f4cb6@redhat.com"},"message":"libnm: use enum for setting priorities","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/488029d74b6d25abc857e46067cf63588a5dbbe5"},{"sha":"837a8c1ca5bd3ec391d228c6a5725c85bc4a1c55","author":{"name":"Thomas Haller","email":"9d2a1d242d3f6644641a729c1b364077592f4cb6@redhat.com"},"message":"libnm: distinguish INVALID priority setting from NM_SETTING_PRIORITY_CONNECTION","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/837a8c1ca5bd3ec391d228c6a5725c85bc4a1c55"},{"sha":"1d6b717401e42f3cc96e08e7e7ca807e90f73135","author":{"name":"Thomas Haller","email":"9d2a1d242d3f6644641a729c1b364077592f4cb6@redhat.com"},"message":"libnm: downgrade assertions in _nm_register_setting_impl() to nm_assert()\n\nThis is entirely internal API. We have unit tests that execute these\ncode paths. No need to have these assertions in production code.","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/1d6b717401e42f3cc96e08e7e7ca807e90f73135"},{"sha":"88c2ccfb4c20cd1b4e34b31991f446b2f052478a","author":{"name":"Thomas Haller","email":"9d2a1d242d3f6644641a729c1b364077592f4cb6@redhat.com"},"message":"libnm: avoid assertion with invalid connections in _nm_connection_find_base_type_setting()\n\nFunctions should behave gracefully with connections that don't verify.\nEspecially, as _normalize_connection_type() calls\n_nm_connection_find_base_type_setting() precisely with an unknown\nconnection.type.","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/88c2ccfb4c20cd1b4e34b31991f446b2f052478a"},{"sha":"c292f3ed859b0e57a6d52d066c7068f567c570fd","author":{"name":"Thomas Haller","email":"9d2a1d242d3f6644641a729c1b364077592f4cb6@redhat.com"},"message":"device: hide nm_device_factory_get_supported_types() function\n\nThe simple link-types/setting-types mechanism doesn't really cut it\nbecause for the bluetooth NAP connection.type is \"bluetooth\", but\nit shall be primarily handled by the bridge factory.\n\nIt's internal API that allows for a basic matching of the factory.\nIt is however not sophisticated enough for the full complexity.\nMake it as internal API only.","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/c292f3ed859b0e57a6d52d066c7068f567c570fd"},{"sha":"c74a6b305c30f573e264da6c24c88faa75e9f584","author":{"name":"Thomas Haller","email":"9d2a1d242d3f6644641a729c1b364077592f4cb6@redhat.com"},"message":"device: remove duplicate check for NMDeviceFactory's _add_factory()\n\nThe duplicate check is based only on the link-types and setting-types.\nHowever, that doesn't really cut it because in case of bluetooth\nNAP connections, NMBridgeDeviceFactory is responsible for the connection,\nalthough connection.type is \"bluetooth\".\n\nThis is only here to catch loading invalid plugins. But at the point\nwhere we load an invalid plugin, the process is hosed. This is at best\nan assertion, but rather pointless really.","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/c74a6b305c30f573e264da6c24c88faa75e9f584"},{"sha":"abdf9a3673657bc543f8f454b51ac35c7d6a44c5","author":{"name":"Thomas Haller","email":"9d2a1d242d3f6644641a729c1b364077592f4cb6@redhat.com"},"message":"all: change handling of connection.type for bluetooth NAP and in general\n\nBranch f9b1bc16e9e691ab89caf883f33d94be72364671 added bluetooth NAP\nsupport. A NAP connection is of connection.type \"bluetooth\", but it\nalso has a \"bridge\" setting. Also, it is primarily handled by NMDeviceBridge\nand NMBridgeDeviceFactory (with help from NMBluezManager).\n\nHowever, don't let nm_connection_get_connection_type() and\nnm_connnection_is_type() lie about what the connection.type is.\nThe type is \"bluetooth\" for most purposes -- at least, as far as\nthe client is concerned (and the public API of libnm). This restores\nprevious API behavior, where nm_connection_get_connection_type()\nand nm_connection_is_type() would be simple accessors to the\n\"connection.type\" property.\n\nOnly a few places care about the bridge aspect, and those places need special\ntreatment. For example NMDeviceBridge needs to be fully aware that it can\nhandle bluetooth NAP connection. That is nothing new: if you handle a\nconnection of any type, you must know which fields matter and what they\nmean. It's not enough that nm_connection_get_connection_type() for bluetooth\nNAP connectins is claiming to be a bridge.\n\nCounter examples, where the original behavior is right:\n\nsrc/nm-manager.c-        g_set_error (error,\nsrc/nm-manager.c-                     NM_MANAGER_ERROR,\nsrc/nm-manager.c-                     NM_MANAGER_ERROR_FAILED,\nsrc/nm-manager.c-                     \"NetworkManager plugin for '%s' unavailable\",\nsrc/nm-manager.c:                     nm_connection_get_connection_type (connection));\n\nthe correct message is: \"no bluetooth plugin available\", not \"bridge\".\n\nsrc/settings/plugins/ifcfg-rh/nms-ifcfg-rh-writer.c:   if (   (   nm_connection_is_type (connection, NM_SETTING_WIRED_SETTING_NAME)\nsrc/settings/plugins/ifcfg-rh/nms-ifcfg-rh-writer.c:           && !nm_connection_get_setting_pppoe (connection))\nsrc/settings/plugins/ifcfg-rh/nms-ifcfg-rh-writer.c:       || nm_connection_is_type (connection, NM_SETTING_VLAN_SETTING_NAME)\nsrc/settings/plugins/ifcfg-rh/nms-ifcfg-rh-writer.c:       || nm_connection_is_type (connection, NM_SETTING_WIRELESS_SETTING_NAME)\nsrc/settings/plugins/ifcfg-rh/nms-ifcfg-rh-writer.c:       || nm_connection_is_type (connection, NM_SETTING_INFINIBAND_SETTING_NAME)\nsrc/settings/plugins/ifcfg-rh/nms-ifcfg-rh-writer.c:       || nm_connection_is_type (connection, NM_SETTING_BOND_SETTING_NAME)\nsrc/settings/plugins/ifcfg-rh/nms-ifcfg-rh-writer.c:       || nm_connection_is_type (connection, NM_SETTING_TEAM_SETTING_NAME)\nsrc/settings/plugins/ifcfg-rh/nms-ifcfg-rh-writer.c:       || nm_connection_is_type (connection, NM_SETTING_BRIDGE_SETTING_NAME))\nsrc/settings/plugins/ifcfg-rh/nms-ifcfg-rh-writer.c-        return TRUE;\n\nthe correct behavior is for ifcfg-rh plugin to reject bluetooth NAP\nconnections, not proceed and store it.","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/abdf9a3673657bc543f8f454b51ac35c7d6a44c5"}]}
{"actor":{"display_login":"lkundrak"}}