{"action":"created","comment":{"url":"https://api.github.com/repos/enthought/pyql/pulls/comments/102478598","pull_request_review_id":23234247,"id":102478598,"diff_hunk":"@@ -178,7 +179,13 @@ cdef class CreditDefaultSwap(Instrument):\n \n     @property\n     def coupons(self):\n-        return cashflow.leg_items(_get_cds(self).coupons())\n+        cdef vector[shared_ptr[_cf.CashFlow]] coupons = _get_cds(self).coupons()\n+        cdef vector[shared_ptr[_cf.CashFlow]].iterator it = coupons.begin()\n+        cdef _cf.CashFlow* _thiscf\n+        while it != coupons.end():\n+            _thiscf = deref(it).get()\n+            yield (_thiscf.amount(), _pydate_from_qldate(_thiscf.date()))","path":"quantlib/instruments/credit_default_swap.pyx","position":33,"original_position":33,"commit_id":"81cb42d8f838e3166e491993af555b2a22c87515","original_commit_id":"81cb42d8f838e3166e491993af555b2a22c87515","user":{"login":"dpinte","id":538104,"avatar_url":"https://avatars.githubusercontent.com/u/538104?v=3","gravatar_id":"","url":"https://api.github.com/users/dpinte","html_url":"https://github.com/dpinte","followers_url":"https://api.github.com/users/dpinte/followers","following_url":"https://api.github.com/users/dpinte/following{/other_user}","gists_url":"https://api.github.com/users/dpinte/gists{/gist_id}","starred_url":"https://api.github.com/users/dpinte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpinte/subscriptions","organizations_url":"https://api.github.com/users/dpinte/orgs","repos_url":"https://api.github.com/users/dpinte/repos","events_url":"https://api.github.com/users/dpinte/events{/privacy}","received_events_url":"https://api.github.com/users/dpinte/received_events","type":"User","site_admin":false},"body":":+1: ","created_at":"2017-02-22T14:47:31Z","updated_at":"2017-02-22T14:47:49Z","html_url":"https://github.com/enthought/pyql/pull/174#discussion_r102478598","pull_request_url":"https://api.github.com/repos/enthought/pyql/pulls/174","_links":{"self":{"href":"https://api.github.com/repos/enthought/pyql/pulls/comments/102478598"},"html":{"href":"https://github.com/enthought/pyql/pull/174#discussion_r102478598"},"pull_request":{"href":"https://api.github.com/repos/enthought/pyql/pulls/174"}}},"pull_request":{"url":"https://api.github.com/repos/enthought/pyql/pulls/174","id":107291708,"html_url":"https://github.com/enthought/pyql/pull/174","diff_url":"https://github.com/enthought/pyql/pull/174.diff","patch_url":"https://github.com/enthought/pyql/pull/174.patch","issue_url":"https://api.github.com/repos/enthought/pyql/issues/174","number":174,"state":"open","locked":false,"title":"Better Leg class","user":{"login":"thrasibule","id":494248,"avatar_url":"https://avatars.githubusercontent.com/u/494248?v=3","gravatar_id":"","url":"https://api.github.com/users/thrasibule","html_url":"https://github.com/thrasibule","followers_url":"https://api.github.com/users/thrasibule/followers","following_url":"https://api.github.com/users/thrasibule/following{/other_user}","gists_url":"https://api.github.com/users/thrasibule/gists{/gist_id}","starred_url":"https://api.github.com/users/thrasibule/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thrasibule/subscriptions","organizations_url":"https://api.github.com/users/thrasibule/orgs","repos_url":"https://api.github.com/users/thrasibule/repos","events_url":"https://api.github.com/users/thrasibule/events{/privacy}","received_events_url":"https://api.github.com/users/thrasibule/received_events","type":"User","site_admin":false},"body":"Cleanup the code and add a couple more pythonic methods (__len__, __iter__)","created_at":"2017-02-21T22:18:58Z","updated_at":"2017-02-22T14:47:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"efbdc81b04ca226b5f0538b4ffe6005c21ae2dbc","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/enthought/pyql/pulls/174/commits","review_comments_url":"https://api.github.com/repos/enthought/pyql/pulls/174/comments","review_comment_url":"https://api.github.com/repos/enthought/pyql/pulls/comments{/number}","comments_url":"https://api.github.com/repos/enthought/pyql/issues/174/comments","statuses_url":"https://api.github.com/repos/enthought/pyql/statuses/81cb42d8f838e3166e491993af555b2a22c87515","head":{"label":"thrasibule:better_leg","ref":"better_leg","sha":"81cb42d8f838e3166e491993af555b2a22c87515","user":{"login":"thrasibule","id":494248,"avatar_url":"https://avatars.githubusercontent.com/u/494248?v=3","gravatar_id":"","url":"https://api.github.com/users/thrasibule","html_url":"https://github.com/thrasibule","followers_url":"https://api.github.com/users/thrasibule/followers","following_url":"https://api.github.com/users/thrasibule/following{/other_user}","gists_url":"https://api.github.com/users/thrasibule/gists{/gist_id}","starred_url":"https://api.github.com/users/thrasibule/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thrasibule/subscriptions","organizations_url":"https://api.github.com/users/thrasibule/orgs","repos_url":"https://api.github.com/users/thrasibule/repos","events_url":"https://api.github.com/users/thrasibule/events{/privacy}","received_events_url":"https://api.github.com/users/thrasibule/received_events","type":"User","site_admin":false},"repo":{"id":16602617,"name":"pyql","full_name":"thrasibule/pyql","owner":{"login":"thrasibule","id":494248,"avatar_url":"https://avatars.githubusercontent.com/u/494248?v=3","gravatar_id":"","url":"https://api.github.com/users/thrasibule","html_url":"https://github.com/thrasibule","followers_url":"https://api.github.com/users/thrasibule/followers","following_url":"https://api.github.com/users/thrasibule/following{/other_user}","gists_url":"https://api.github.com/users/thrasibule/gists{/gist_id}","starred_url":"https://api.github.com/users/thrasibule/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thrasibule/subscriptions","organizations_url":"https://api.github.com/users/thrasibule/orgs","repos_url":"https://api.github.com/users/thrasibule/repos","events_url":"https://api.github.com/users/thrasibule/events{/privacy}","received_events_url":"https://api.github.com/users/thrasibule/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thrasibule/pyql","description":"Cython QuantLib wrappers","fork":true,"url":"https://api.github.com/repos/thrasibule/pyql","forks_url":"https://api.github.com/repos/thrasibule/pyql/forks","keys_url":"https://api.github.com/repos/thrasibule/pyql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thrasibule/pyql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thrasibule/pyql/teams","hooks_url":"https://api.github.com/repos/thrasibule/pyql/hooks","issue_events_url":"https://api.github.com/repos/thrasibule/pyql/issues/events{/number}","events_url":"https://api.github.com/repos/thrasibule/pyql/events","assignees_url":"https://api.github.com/repos/thrasibule/pyql/assignees{/user}","branches_url":"https://api.github.com/repos/thrasibule/pyql/branches{/branch}","tags_url":"https://api.github.com/repos/thrasibule/pyql/tags","blobs_url":"https://api.github.com/repos/thrasibule/pyql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thrasibule/pyql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thrasibule/pyql/git/refs{/sha}","trees_url":"https://api.github.com/repos/thrasibule/pyql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thrasibule/pyql/statuses/{sha}","languages_url":"https://api.github.com/repos/thrasibule/pyql/languages","stargazers_url":"https://api.github.com/repos/thrasibule/pyql/stargazers","contributors_url":"https://api.github.com/repos/thrasibule/pyql/contributors","subscribers_url":"https://api.github.com/repos/thrasibule/pyql/subscribers","subscription_url":"https://api.github.com/repos/thrasibule/pyql/subscription","commits_url":"https://api.github.com/repos/thrasibule/pyql/commits{/sha}","git_commits_url":"https://api.github.com/repos/thrasibule/pyql/git/commits{/sha}","comments_url":"https://api.github.com/repos/thrasibule/pyql/comments{/number}","issue_comment_url":"https://api.github.com/repos/thrasibule/pyql/issues/comments{/number}","contents_url":"https://api.github.com/repos/thrasibule/pyql/contents/{+path}","compare_url":"https://api.github.com/repos/thrasibule/pyql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thrasibule/pyql/merges","archive_url":"https://api.github.com/repos/thrasibule/pyql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thrasibule/pyql/downloads","issues_url":"https://api.github.com/repos/thrasibule/pyql/issues{/number}","pulls_url":"https://api.github.com/repos/thrasibule/pyql/pulls{/number}","milestones_url":"https://api.github.com/repos/thrasibule/pyql/milestones{/number}","notifications_url":"https://api.github.com/repos/thrasibule/pyql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thrasibule/pyql/labels{/name}","releases_url":"https://api.github.com/repos/thrasibule/pyql/releases{/id}","deployments_url":"https://api.github.com/repos/thrasibule/pyql/deployments","created_at":"2014-02-07T02:55:20Z","updated_at":"2016-12-10T04:12:09Z","pushed_at":"2017-02-21T20:52:37Z","git_url":"git://github.com/thrasibule/pyql.git","ssh_url":"git@github.com:thrasibule/pyql.git","clone_url":"https://github.com/thrasibule/pyql.git","svn_url":"https://github.com/thrasibule/pyql","homepage":"","size":14613,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"enthought:master","ref":"master","sha":"60daa13d525854aa6a7bedeef8edda36e1431b17","user":{"login":"enthought","id":539651,"avatar_url":"https://avatars.githubusercontent.com/u/539651?v=3","gravatar_id":"","url":"https://api.github.com/users/enthought","html_url":"https://github.com/enthought","followers_url":"https://api.github.com/users/enthought/followers","following_url":"https://api.github.com/users/enthought/following{/other_user}","gists_url":"https://api.github.com/users/enthought/gists{/gist_id}","starred_url":"https://api.github.com/users/enthought/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enthought/subscriptions","organizations_url":"https://api.github.com/users/enthought/orgs","repos_url":"https://api.github.com/users/enthought/repos","events_url":"https://api.github.com/users/enthought/events{/privacy}","received_events_url":"https://api.github.com/users/enthought/received_events","type":"Organization","site_admin":false},"repo":{"id":3665229,"name":"pyql","full_name":"enthought/pyql","owner":{"login":"enthought","id":539651,"avatar_url":"https://avatars.githubusercontent.com/u/539651?v=3","gravatar_id":"","url":"https://api.github.com/users/enthought","html_url":"https://github.com/enthought","followers_url":"https://api.github.com/users/enthought/followers","following_url":"https://api.github.com/users/enthought/following{/other_user}","gists_url":"https://api.github.com/users/enthought/gists{/gist_id}","starred_url":"https://api.github.com/users/enthought/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enthought/subscriptions","organizations_url":"https://api.github.com/users/enthought/orgs","repos_url":"https://api.github.com/users/enthought/repos","events_url":"https://api.github.com/users/enthought/events{/privacy}","received_events_url":"https://api.github.com/users/enthought/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/enthought/pyql","description":"Cython QuantLib wrappers","fork":false,"url":"https://api.github.com/repos/enthought/pyql","forks_url":"https://api.github.com/repos/enthought/pyql/forks","keys_url":"https://api.github.com/repos/enthought/pyql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/enthought/pyql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/enthought/pyql/teams","hooks_url":"https://api.github.com/repos/enthought/pyql/hooks","issue_events_url":"https://api.github.com/repos/enthought/pyql/issues/events{/number}","events_url":"https://api.github.com/repos/enthought/pyql/events","assignees_url":"https://api.github.com/repos/enthought/pyql/assignees{/user}","branches_url":"https://api.github.com/repos/enthought/pyql/branches{/branch}","tags_url":"https://api.github.com/repos/enthought/pyql/tags","blobs_url":"https://api.github.com/repos/enthought/pyql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/enthought/pyql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/enthought/pyql/git/refs{/sha}","trees_url":"https://api.github.com/repos/enthought/pyql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/enthought/pyql/statuses/{sha}","languages_url":"https://api.github.com/repos/enthought/pyql/languages","stargazers_url":"https://api.github.com/repos/enthought/pyql/stargazers","contributors_url":"https://api.github.com/repos/enthought/pyql/contributors","subscribers_url":"https://api.github.com/repos/enthought/pyql/subscribers","subscription_url":"https://api.github.com/repos/enthought/pyql/subscription","commits_url":"https://api.github.com/repos/enthought/pyql/commits{/sha}","git_commits_url":"https://api.github.com/repos/enthought/pyql/git/commits{/sha}","comments_url":"https://api.github.com/repos/enthought/pyql/comments{/number}","issue_comment_url":"https://api.github.com/repos/enthought/pyql/issues/comments{/number}","contents_url":"https://api.github.com/repos/enthought/pyql/contents/{+path}","compare_url":"https://api.github.com/repos/enthought/pyql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/enthought/pyql/merges","archive_url":"https://api.github.com/repos/enthought/pyql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/enthought/pyql/downloads","issues_url":"https://api.github.com/repos/enthought/pyql/issues{/number}","pulls_url":"https://api.github.com/repos/enthought/pyql/pulls{/number}","milestones_url":"https://api.github.com/repos/enthought/pyql/milestones{/number}","notifications_url":"https://api.github.com/repos/enthought/pyql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/enthought/pyql/labels{/name}","releases_url":"https://api.github.com/repos/enthought/pyql/releases{/id}","deployments_url":"https://api.github.com/repos/enthought/pyql/deployments","created_at":"2012-03-08T22:44:35Z","updated_at":"2017-02-19T03:28:35Z","pushed_at":"2017-02-21T22:18:59Z","git_url":"git://github.com/enthought/pyql.git","ssh_url":"git@github.com:enthought/pyql.git","clone_url":"https://github.com/enthought/pyql.git","svn_url":"https://github.com/enthought/pyql","homepage":"","size":14211,"stargazers_count":186,"watchers_count":186,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":99,"mirror_url":null,"open_issues_count":12,"forks":99,"open_issues":12,"watchers":186,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/enthought/pyql/pulls/174"},"html":{"href":"https://github.com/enthought/pyql/pull/174"},"issue":{"href":"https://api.github.com/repos/enthought/pyql/issues/174"},"comments":{"href":"https://api.github.com/repos/enthought/pyql/issues/174/comments"},"review_comments":{"href":"https://api.github.com/repos/enthought/pyql/pulls/174/comments"},"review_comment":{"href":"https://api.github.com/repos/enthought/pyql/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/enthought/pyql/pulls/174/commits"},"statuses":{"href":"https://api.github.com/repos/enthought/pyql/statuses/81cb42d8f838e3166e491993af555b2a22c87515"}}}}
{"actor":{"display_login":"dpinte"}}