{"action":"created","comment":{"url":"https://api.github.com/repos/f5devcentral/f5-puppet/pulls/comments/152673461","pull_request_review_id":78572490,"id":152673461,"diff_hunk":"@@ -0,0 +1,53 @@\n+require File.expand_path(File.join(File.dirname(__FILE__),'..','..','puppet/parameter/f5_name.rb'))\n+require File.expand_path(File.join(File.dirname(__FILE__),'..','..','puppet/property/f5_address.rb'))\n+require File.expand_path(File.join(File.dirname(__FILE__),'..','..','puppet/property/f5_availability_requirement.rb'))\n+require File.expand_path(File.join(File.dirname(__FILE__),'..','..','puppet/property/f5_connection_limit.rb'))\n+require File.expand_path(File.join(File.dirname(__FILE__),'..','..','puppet/property/f5_connection_rate_limit.rb'))\n+require File.expand_path(File.join(File.dirname(__FILE__),'..','..','puppet/property/f5_description.rb'))\n+require File.expand_path(File.join(File.dirname(__FILE__),'..','..','puppet/property/f5_health_monitors.rb'))\n+require File.expand_path(File.join(File.dirname(__FILE__),'..','..','puppet/property/f5_ratio.rb'))\n+require File.expand_path(File.join(File.dirname(__FILE__),'..','..','puppet/property/f5_state.rb'))\n+\n+require File.expand_path(File.join(File.dirname(__FILE__),'..','..','puppet/property/f5_truthy.rb'))\n+\n+\n+Puppet::Type.newtype(:f5_persistencedestaddr) do\n+  @doc = 'Manage f5_persistencedestaddr persistence objects'\n+\n+  apply_to_device\n+  ensurable\n+\n+  newparam(:name, :parent => Puppet::Parameter::F5Name, :namevar => true)\n+\n+  newproperty(:description, :parent => Puppet::Property::F5Description)\n+\n+  newproperty(:match_across_services, :parent => Puppet::Property::F5truthy) do\n+    truthy_property(\"Valid values are 'enabled' or 'disabled'.\")\n+  end\n+\n+  newproperty(:match_across_virtuals, :parent => Puppet::Property::F5truthy) do\n+    truthy_property(\"Valid values are 'enabled' or 'disabled'.\")\n+  end\n+\n+  newproperty(:match_across_pools, :parent => Puppet::Property::F5truthy) do\n+    truthy_property(\"Valid values are 'enabled' or 'disabled'.\")\n+  end\n+\n+  newproperty(:hash_algorithm) do\n+    desc \"hash_algorithm.\"\n+    newvalues(:default, :'carp')","path":"lib/puppet/type/f5_persistencedestaddr.rb","position":38,"original_position":38,"commit_id":"7ee2e6561f1dff46408d8ca8eb0b58f5f0d72f77","original_commit_id":"2f2cdd48f578f0abdac57d81b9dba24052090a60","user":{"login":"ericzji","id":26015473,"avatar_url":"https://avatars0.githubusercontent.com/u/26015473?v=4","gravatar_id":"","url":"https://api.github.com/users/ericzji","html_url":"https://github.com/ericzji","followers_url":"https://api.github.com/users/ericzji/followers","following_url":"https://api.github.com/users/ericzji/following{/other_user}","gists_url":"https://api.github.com/users/ericzji/gists{/gist_id}","starred_url":"https://api.github.com/users/ericzji/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericzji/subscriptions","organizations_url":"https://api.github.com/users/ericzji/orgs","repos_url":"https://api.github.com/users/ericzji/repos","events_url":"https://api.github.com/users/ericzji/events{/privacy}","received_events_url":"https://api.github.com/users/ericzji/received_events","type":"User","site_admin":false},"body":"it's string","created_at":"2017-11-22T20:36:57Z","updated_at":"2017-11-22T20:36:58Z","html_url":"https://github.com/f5devcentral/f5-puppet/pull/18#discussion_r152673461","pull_request_url":"https://api.github.com/repos/f5devcentral/f5-puppet/pulls/18","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/f5devcentral/f5-puppet/pulls/comments/152673461"},"html":{"href":"https://github.com/f5devcentral/f5-puppet/pull/18#discussion_r152673461"},"pull_request":{"href":"https://api.github.com/repos/f5devcentral/f5-puppet/pulls/18"}},"in_reply_to_id":152526842},"pull_request":{"url":"https://api.github.com/repos/f5devcentral/f5-puppet/pulls/18","id":153974958,"html_url":"https://github.com/f5devcentral/f5-puppet/pull/18","diff_url":"https://github.com/f5devcentral/f5-puppet/pull/18.diff","patch_url":"https://github.com/f5devcentral/f5-puppet/pull/18.patch","issue_url":"https://api.github.com/repos/f5devcentral/f5-puppet/issues/18","number":18,"state":"open","locked":false,"title":"Development for new feature types and providers","user":{"login":"ericzji","id":26015473,"avatar_url":"https://avatars0.githubusercontent.com/u/26015473?v=4","gravatar_id":"","url":"https://api.github.com/users/ericzji","html_url":"https://github.com/ericzji","followers_url":"https://api.github.com/users/ericzji/followers","following_url":"https://api.github.com/users/ericzji/following{/other_user}","gists_url":"https://api.github.com/users/ericzji/gists{/gist_id}","starred_url":"https://api.github.com/users/ericzji/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericzji/subscriptions","organizations_url":"https://api.github.com/users/ericzji/orgs","repos_url":"https://api.github.com/users/ericzji/repos","events_url":"https://api.github.com/users/ericzji/events{/privacy}","received_events_url":"https://api.github.com/users/ericzji/received_events","type":"User","site_admin":false},"body":"The new types and providers added: \r\n- f5_persistencecookie\r\n- f5_persistencedestaddr\r\n- f5_persistencehash\r\n- f5_persistencesourceaddr\r\n- f5_persistencessl\r\n- f5_persistenceuniversal\r\n- f5_profilehttp\r\n- f5_profileclientssl\r\n- f5_profileserverssl\r\n- f5_sslkey\r\n- f5_sslcertificate\r\n- f5_snat\r\n- f5_snatpool\r\n- f5_datagroup\r\n- f5_datagroupexternal\r\n","created_at":"2017-11-21T19:03:08Z","updated_at":"2017-11-22T20:36:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2963274de7410f5076ca34eb9244cea83f703709","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/f5devcentral/f5-puppet/pulls/18/commits","review_comments_url":"https://api.github.com/repos/f5devcentral/f5-puppet/pulls/18/comments","review_comment_url":"https://api.github.com/repos/f5devcentral/f5-puppet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/f5devcentral/f5-puppet/issues/18/comments","statuses_url":"https://api.github.com/repos/f5devcentral/f5-puppet/statuses/7ee2e6561f1dff46408d8ca8eb0b58f5f0d72f77","head":{"label":"f5devcentral:development","ref":"development","sha":"7ee2e6561f1dff46408d8ca8eb0b58f5f0d72f77","user":{"login":"f5devcentral","id":18314976,"avatar_url":"https://avatars3.githubusercontent.com/u/18314976?v=4","gravatar_id":"","url":"https://api.github.com/users/f5devcentral","html_url":"https://github.com/f5devcentral","followers_url":"https://api.github.com/users/f5devcentral/followers","following_url":"https://api.github.com/users/f5devcentral/following{/other_user}","gists_url":"https://api.github.com/users/f5devcentral/gists{/gist_id}","starred_url":"https://api.github.com/users/f5devcentral/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/f5devcentral/subscriptions","organizations_url":"https://api.github.com/users/f5devcentral/orgs","repos_url":"https://api.github.com/users/f5devcentral/repos","events_url":"https://api.github.com/users/f5devcentral/events{/privacy}","received_events_url":"https://api.github.com/users/f5devcentral/received_events","type":"Organization","site_admin":false},"repo":{"id":99969210,"name":"f5-puppet","full_name":"f5devcentral/f5-puppet","owner":{"login":"f5devcentral","id":18314976,"avatar_url":"https://avatars3.githubusercontent.com/u/18314976?v=4","gravatar_id":"","url":"https://api.github.com/users/f5devcentral","html_url":"https://github.com/f5devcentral","followers_url":"https://api.github.com/users/f5devcentral/followers","following_url":"https://api.github.com/users/f5devcentral/following{/other_user}","gists_url":"https://api.github.com/users/f5devcentral/gists{/gist_id}","starred_url":"https://api.github.com/users/f5devcentral/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/f5devcentral/subscriptions","organizations_url":"https://api.github.com/users/f5devcentral/orgs","repos_url":"https://api.github.com/users/f5devcentral/repos","events_url":"https://api.github.com/users/f5devcentral/events{/privacy}","received_events_url":"https://api.github.com/users/f5devcentral/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/f5devcentral/f5-puppet","description":null,"fork":false,"url":"https://api.github.com/repos/f5devcentral/f5-puppet","forks_url":"https://api.github.com/repos/f5devcentral/f5-puppet/forks","keys_url":"https://api.github.com/repos/f5devcentral/f5-puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/f5devcentral/f5-puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/f5devcentral/f5-puppet/teams","hooks_url":"https://api.github.com/repos/f5devcentral/f5-puppet/hooks","issue_events_url":"https://api.github.com/repos/f5devcentral/f5-puppet/issues/events{/number}","events_url":"https://api.github.com/repos/f5devcentral/f5-puppet/events","assignees_url":"https://api.github.com/repos/f5devcentral/f5-puppet/assignees{/user}","branches_url":"https://api.github.com/repos/f5devcentral/f5-puppet/branches{/branch}","tags_url":"https://api.github.com/repos/f5devcentral/f5-puppet/tags","blobs_url":"https://api.github.com/repos/f5devcentral/f5-puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/f5devcentral/f5-puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/f5devcentral/f5-puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/f5devcentral/f5-puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/f5devcentral/f5-puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/f5devcentral/f5-puppet/languages","stargazers_url":"https://api.github.com/repos/f5devcentral/f5-puppet/stargazers","contributors_url":"https://api.github.com/repos/f5devcentral/f5-puppet/contributors","subscribers_url":"https://api.github.com/repos/f5devcentral/f5-puppet/subscribers","subscription_url":"https://api.github.com/repos/f5devcentral/f5-puppet/subscription","commits_url":"https://api.github.com/repos/f5devcentral/f5-puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/f5devcentral/f5-puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/f5devcentral/f5-puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/f5devcentral/f5-puppet/issues/comments{/number}","contents_url":"https://api.github.com/repos/f5devcentral/f5-puppet/contents/{+path}","compare_url":"https://api.github.com/repos/f5devcentral/f5-puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/f5devcentral/f5-puppet/merges","archive_url":"https://api.github.com/repos/f5devcentral/f5-puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/f5devcentral/f5-puppet/downloads","issues_url":"https://api.github.com/repos/f5devcentral/f5-puppet/issues{/number}","pulls_url":"https://api.github.com/repos/f5devcentral/f5-puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/f5devcentral/f5-puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/f5devcentral/f5-puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/f5devcentral/f5-puppet/labels{/name}","releases_url":"https://api.github.com/repos/f5devcentral/f5-puppet/releases{/id}","deployments_url":"https://api.github.com/repos/f5devcentral/f5-puppet/deployments","created_at":"2017-08-10T22:19:47Z","updated_at":"2017-11-14T19:29:16Z","pushed_at":"2017-11-22T19:39:13Z","git_url":"git://github.com/f5devcentral/f5-puppet.git","ssh_url":"git@github.com:f5devcentral/f5-puppet.git","clone_url":"https://github.com/f5devcentral/f5-puppet.git","svn_url":"https://github.com/f5devcentral/f5-puppet","homepage":null,"size":1301,"stargazers_count":4,"watchers_count":4,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":8,"forks":4,"open_issues":8,"watchers":4,"default_branch":"master"}},"base":{"label":"f5devcentral:master","ref":"master","sha":"255f0b717fc0220ec1f5032ab335bcd1595bd177","user":{"login":"f5devcentral","id":18314976,"avatar_url":"https://avatars3.githubusercontent.com/u/18314976?v=4","gravatar_id":"","url":"https://api.github.com/users/f5devcentral","html_url":"https://github.com/f5devcentral","followers_url":"https://api.github.com/users/f5devcentral/followers","following_url":"https://api.github.com/users/f5devcentral/following{/other_user}","gists_url":"https://api.github.com/users/f5devcentral/gists{/gist_id}","starred_url":"https://api.github.com/users/f5devcentral/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/f5devcentral/subscriptions","organizations_url":"https://api.github.com/users/f5devcentral/orgs","repos_url":"https://api.github.com/users/f5devcentral/repos","events_url":"https://api.github.com/users/f5devcentral/events{/privacy}","received_events_url":"https://api.github.com/users/f5devcentral/received_events","type":"Organization","site_admin":false},"repo":{"id":99969210,"name":"f5-puppet","full_name":"f5devcentral/f5-puppet","owner":{"login":"f5devcentral","id":18314976,"avatar_url":"https://avatars3.githubusercontent.com/u/18314976?v=4","gravatar_id":"","url":"https://api.github.com/users/f5devcentral","html_url":"https://github.com/f5devcentral","followers_url":"https://api.github.com/users/f5devcentral/followers","following_url":"https://api.github.com/users/f5devcentral/following{/other_user}","gists_url":"https://api.github.com/users/f5devcentral/gists{/gist_id}","starred_url":"https://api.github.com/users/f5devcentral/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/f5devcentral/subscriptions","organizations_url":"https://api.github.com/users/f5devcentral/orgs","repos_url":"https://api.github.com/users/f5devcentral/repos","events_url":"https://api.github.com/users/f5devcentral/events{/privacy}","received_events_url":"https://api.github.com/users/f5devcentral/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/f5devcentral/f5-puppet","description":null,"fork":false,"url":"https://api.github.com/repos/f5devcentral/f5-puppet","forks_url":"https://api.github.com/repos/f5devcentral/f5-puppet/forks","keys_url":"https://api.github.com/repos/f5devcentral/f5-puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/f5devcentral/f5-puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/f5devcentral/f5-puppet/teams","hooks_url":"https://api.github.com/repos/f5devcentral/f5-puppet/hooks","issue_events_url":"https://api.github.com/repos/f5devcentral/f5-puppet/issues/events{/number}","events_url":"https://api.github.com/repos/f5devcentral/f5-puppet/events","assignees_url":"https://api.github.com/repos/f5devcentral/f5-puppet/assignees{/user}","branches_url":"https://api.github.com/repos/f5devcentral/f5-puppet/branches{/branch}","tags_url":"https://api.github.com/repos/f5devcentral/f5-puppet/tags","blobs_url":"https://api.github.com/repos/f5devcentral/f5-puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/f5devcentral/f5-puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/f5devcentral/f5-puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/f5devcentral/f5-puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/f5devcentral/f5-puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/f5devcentral/f5-puppet/languages","stargazers_url":"https://api.github.com/repos/f5devcentral/f5-puppet/stargazers","contributors_url":"https://api.github.com/repos/f5devcentral/f5-puppet/contributors","subscribers_url":"https://api.github.com/repos/f5devcentral/f5-puppet/subscribers","subscription_url":"https://api.github.com/repos/f5devcentral/f5-puppet/subscription","commits_url":"https://api.github.com/repos/f5devcentral/f5-puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/f5devcentral/f5-puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/f5devcentral/f5-puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/f5devcentral/f5-puppet/issues/comments{/number}","contents_url":"https://api.github.com/repos/f5devcentral/f5-puppet/contents/{+path}","compare_url":"https://api.github.com/repos/f5devcentral/f5-puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/f5devcentral/f5-puppet/merges","archive_url":"https://api.github.com/repos/f5devcentral/f5-puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/f5devcentral/f5-puppet/downloads","issues_url":"https://api.github.com/repos/f5devcentral/f5-puppet/issues{/number}","pulls_url":"https://api.github.com/repos/f5devcentral/f5-puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/f5devcentral/f5-puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/f5devcentral/f5-puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/f5devcentral/f5-puppet/labels{/name}","releases_url":"https://api.github.com/repos/f5devcentral/f5-puppet/releases{/id}","deployments_url":"https://api.github.com/repos/f5devcentral/f5-puppet/deployments","created_at":"2017-08-10T22:19:47Z","updated_at":"2017-11-14T19:29:16Z","pushed_at":"2017-11-22T19:39:13Z","git_url":"git://github.com/f5devcentral/f5-puppet.git","ssh_url":"git@github.com:f5devcentral/f5-puppet.git","clone_url":"https://github.com/f5devcentral/f5-puppet.git","svn_url":"https://github.com/f5devcentral/f5-puppet","homepage":null,"size":1301,"stargazers_count":4,"watchers_count":4,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":8,"forks":4,"open_issues":8,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/f5devcentral/f5-puppet/pulls/18"},"html":{"href":"https://github.com/f5devcentral/f5-puppet/pull/18"},"issue":{"href":"https://api.github.com/repos/f5devcentral/f5-puppet/issues/18"},"comments":{"href":"https://api.github.com/repos/f5devcentral/f5-puppet/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/f5devcentral/f5-puppet/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/f5devcentral/f5-puppet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/f5devcentral/f5-puppet/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/f5devcentral/f5-puppet/statuses/7ee2e6561f1dff46408d8ca8eb0b58f5f0d72f77"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"ericzji"}}