{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/roslyn/issues/18928","repository_url":"https://api.github.com/repos/dotnet/roslyn","labels_url":"https://api.github.com/repos/dotnet/roslyn/issues/18928/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/18928/comments","events_url":"https://api.github.com/repos/dotnet/roslyn/issues/18928/events","html_url":"https://github.com/dotnet/roslyn/pull/18928","id":223605085,"number":18928,"title":"Fix setup authoring for Microsoft.DiaSymReader.Native","user":{"login":"tmat","id":41759,"avatar_url":"https://avatars3.githubusercontent.com/u/41759?v=3","gravatar_id":"","url":"https://api.github.com/users/tmat","html_url":"https://github.com/tmat","followers_url":"https://api.github.com/users/tmat/followers","following_url":"https://api.github.com/users/tmat/following{/other_user}","gists_url":"https://api.github.com/users/tmat/gists{/gist_id}","starred_url":"https://api.github.com/users/tmat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmat/subscriptions","organizations_url":"https://api.github.com/users/tmat/orgs","repos_url":"https://api.github.com/users/tmat/repos","events_url":"https://api.github.com/users/tmat/events{/privacy}","received_events_url":"https://api.github.com/users/tmat/received_events","type":"User","site_admin":false},"labels":[{"id":197452922,"url":"https://api.github.com/repos/dotnet/roslyn/labels/cla-already-signed","name":"cla-already-signed","color":"009800","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-04-23T01:29:36Z","updated_at":"2017-04-24T22:47:05Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/18928","html_url":"https://github.com/dotnet/roslyn/pull/18928","diff_url":"https://github.com/dotnet/roslyn/pull/18928.diff","patch_url":"https://github.com/dotnet/roslyn/pull/18928.patch"},"body":"Needs to be inserted into vsuml branch along with VSO PR 65254\r\n\r\n**Customer scenario**\r\n\r\nNot observable to customer.\r\n\r\nThis change addresses two issues with Microsoft.DiaSymReader.Native:\r\n\r\n1) Microsoft.DiaSymReader.Native is built from WinC TFS branch and inserted into redist directory of a VS release branch by C++ team. Currently these bits are not directly picked up by the VS setup. Instead we first package them to nupkg and then insert them during Roslyn insertion process as a Roslyn dependency. This leads to a problem when finalizing a release -- if C++ team inserts their final binaries after we insert ours we are gonna end up with non-final binaries in the shipping layout. To avoid this race the setup authoring should pick the binaries up directly from the redist directory without going thru Roslyn.\r\n\r\n2) VS components other than Roslyn that might potentially use Microsoft.DiaSymReader.Native can't currently do so without taking a dependency on Roslyn.\r\n\r\nThe binaries are now inserted into ```msbuild\\Bin\\Roslyn``` directory by msbuild setup package and to ```Common7\\IDE``` directory by a new Willow package built in VS branch. This change removes the binaries from Roslyn Willow setup authoring. \r\n\r\n**Bugs this fixes:**\r\n\r\n(either VSO or GitHub links)\r\n\r\n**Workarounds, if any**\r\n\r\nNone.\r\n\r\n**Risk**\r\n\r\nSmall.\r\n\r\n**Performance impact**\r\n\r\nNone.\r\n\r\n**Is this a regression from a previous update?**\r\n\r\nSetup authoring was incorrect in Dev15 RTM, we shipped wrong build of Microsoft.DiaSymReader.Native binaries.\r\n\r\n**Root cause analysis:**\r\n\r\n**How was the bug found?**\r\n"},"comment":{"url":"https://api.github.com/repos/dotnet/roslyn/issues/comments/296843272","html_url":"https://github.com/dotnet/roslyn/pull/18928#issuecomment-296843272","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/18928","id":296843272,"user":{"login":"tmat","id":41759,"avatar_url":"https://avatars3.githubusercontent.com/u/41759?v=3","gravatar_id":"","url":"https://api.github.com/users/tmat","html_url":"https://github.com/tmat","followers_url":"https://api.github.com/users/tmat/followers","following_url":"https://api.github.com/users/tmat/following{/other_user}","gists_url":"https://api.github.com/users/tmat/gists{/gist_id}","starred_url":"https://api.github.com/users/tmat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmat/subscriptions","organizations_url":"https://api.github.com/users/tmat/orgs","repos_url":"https://api.github.com/users/tmat/repos","events_url":"https://api.github.com/users/tmat/events{/privacy}","received_events_url":"https://api.github.com/users/tmat/received_events","type":"User","site_admin":false},"created_at":"2017-04-24T22:47:05Z","updated_at":"2017-04-24T22:47:05Z","body":"@jinujoseph "}}
{"actor":{"display_login":"tmat"}}