{"action":"closed","number":53,"pull_request":{"url":"https://api.github.com/repos/openzim/libzim/pulls/53","id":142898025,"html_url":"https://github.com/openzim/libzim/pull/53","diff_url":"https://github.com/openzim/libzim/pull/53.diff","patch_url":"https://github.com/openzim/libzim/pull/53.patch","issue_url":"https://api.github.com/repos/openzim/libzim/issues/53","number":53,"state":"closed","locked":false,"title":"Use the correct type to store size/offset.","user":{"login":"mgautierfr","id":86161,"avatar_url":"https://avatars0.githubusercontent.com/u/86161?v=4","gravatar_id":"","url":"https://api.github.com/users/mgautierfr","html_url":"https://github.com/mgautierfr","followers_url":"https://api.github.com/users/mgautierfr/followers","following_url":"https://api.github.com/users/mgautierfr/following{/other_user}","gists_url":"https://api.github.com/users/mgautierfr/gists{/gist_id}","starred_url":"https://api.github.com/users/mgautierfr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgautierfr/subscriptions","organizations_url":"https://api.github.com/users/mgautierfr/orgs","repos_url":"https://api.github.com/users/mgautierfr/repos","events_url":"https://api.github.com/users/mgautierfr/events{/privacy}","received_events_url":"https://api.github.com/users/mgautierfr/received_events","type":"User","site_admin":false},"body":"As a zim files may be larger than 4GB, we need 8 bytes len integer\r\nto store size or offset in a zim file.\r\n\r\n`std::size_t` is not the same depending if the architecture is\r\n32 bits (4 bytes) or 64 bits (8 bytes).\r\n\r\nOn the other side, we are properly declaring `offset_type` in zim.h to\r\nalways be 8 bytes whatever the architecture is.\r\n\r\nSo, let's use `offset_type` instead of `std::size_t`.\r\n\r\nFixes kiwix/kiwix-tools#76","created_at":"2017-09-25T14:29:30Z","updated_at":"2017-09-25T15:10:13Z","closed_at":"2017-09-25T15:10:13Z","merged_at":"2017-09-25T15:10:13Z","merge_commit_sha":"1e08f5bf8b934543594b6bc302b8300c3a9a305c","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/openzim/libzim/pulls/53/commits","review_comments_url":"https://api.github.com/repos/openzim/libzim/pulls/53/comments","review_comment_url":"https://api.github.com/repos/openzim/libzim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openzim/libzim/issues/53/comments","statuses_url":"https://api.github.com/repos/openzim/libzim/statuses/b8915e2b6791d7c0afc5f326dab662c02870910e","head":{"label":"openzim:correct_size","ref":"correct_size","sha":"b8915e2b6791d7c0afc5f326dab662c02870910e","user":{"login":"openzim","id":26540839,"avatar_url":"https://avatars0.githubusercontent.com/u/26540839?v=4","gravatar_id":"","url":"https://api.github.com/users/openzim","html_url":"https://github.com/openzim","followers_url":"https://api.github.com/users/openzim/followers","following_url":"https://api.github.com/users/openzim/following{/other_user}","gists_url":"https://api.github.com/users/openzim/gists{/gist_id}","starred_url":"https://api.github.com/users/openzim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openzim/subscriptions","organizations_url":"https://api.github.com/users/openzim/orgs","repos_url":"https://api.github.com/users/openzim/repos","events_url":"https://api.github.com/users/openzim/events{/privacy}","received_events_url":"https://api.github.com/users/openzim/received_events","type":"Organization","site_admin":false},"repo":{"id":87638778,"name":"libzim","full_name":"openzim/libzim","owner":{"login":"openzim","id":26540839,"avatar_url":"https://avatars0.githubusercontent.com/u/26540839?v=4","gravatar_id":"","url":"https://api.github.com/users/openzim","html_url":"https://github.com/openzim","followers_url":"https://api.github.com/users/openzim/followers","following_url":"https://api.github.com/users/openzim/following{/other_user}","gists_url":"https://api.github.com/users/openzim/gists{/gist_id}","starred_url":"https://api.github.com/users/openzim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openzim/subscriptions","organizations_url":"https://api.github.com/users/openzim/orgs","repos_url":"https://api.github.com/users/openzim/repos","events_url":"https://api.github.com/users/openzim/events{/privacy}","received_events_url":"https://api.github.com/users/openzim/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openzim/libzim","description":"Reference implementation of the ZIM specification","fork":false,"url":"https://api.github.com/repos/openzim/libzim","forks_url":"https://api.github.com/repos/openzim/libzim/forks","keys_url":"https://api.github.com/repos/openzim/libzim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openzim/libzim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openzim/libzim/teams","hooks_url":"https://api.github.com/repos/openzim/libzim/hooks","issue_events_url":"https://api.github.com/repos/openzim/libzim/issues/events{/number}","events_url":"https://api.github.com/repos/openzim/libzim/events","assignees_url":"https://api.github.com/repos/openzim/libzim/assignees{/user}","branches_url":"https://api.github.com/repos/openzim/libzim/branches{/branch}","tags_url":"https://api.github.com/repos/openzim/libzim/tags","blobs_url":"https://api.github.com/repos/openzim/libzim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openzim/libzim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openzim/libzim/git/refs{/sha}","trees_url":"https://api.github.com/repos/openzim/libzim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openzim/libzim/statuses/{sha}","languages_url":"https://api.github.com/repos/openzim/libzim/languages","stargazers_url":"https://api.github.com/repos/openzim/libzim/stargazers","contributors_url":"https://api.github.com/repos/openzim/libzim/contributors","subscribers_url":"https://api.github.com/repos/openzim/libzim/subscribers","subscription_url":"https://api.github.com/repos/openzim/libzim/subscription","commits_url":"https://api.github.com/repos/openzim/libzim/commits{/sha}","git_commits_url":"https://api.github.com/repos/openzim/libzim/git/commits{/sha}","comments_url":"https://api.github.com/repos/openzim/libzim/comments{/number}","issue_comment_url":"https://api.github.com/repos/openzim/libzim/issues/comments{/number}","contents_url":"https://api.github.com/repos/openzim/libzim/contents/{+path}","compare_url":"https://api.github.com/repos/openzim/libzim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openzim/libzim/merges","archive_url":"https://api.github.com/repos/openzim/libzim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openzim/libzim/downloads","issues_url":"https://api.github.com/repos/openzim/libzim/issues{/number}","pulls_url":"https://api.github.com/repos/openzim/libzim/pulls{/number}","milestones_url":"https://api.github.com/repos/openzim/libzim/milestones{/number}","notifications_url":"https://api.github.com/repos/openzim/libzim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openzim/libzim/labels{/name}","releases_url":"https://api.github.com/repos/openzim/libzim/releases{/id}","deployments_url":"https://api.github.com/repos/openzim/libzim/deployments","created_at":"2017-04-08T14:15:14Z","updated_at":"2017-09-12T19:05:34Z","pushed_at":"2017-09-25T15:10:13Z","git_url":"git://github.com/openzim/libzim.git","ssh_url":"git@github.com:openzim/libzim.git","clone_url":"https://github.com/openzim/libzim.git","svn_url":"https://github.com/openzim/libzim","homepage":null,"size":590,"stargazers_count":8,"watchers_count":8,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":13,"forks":2,"open_issues":13,"watchers":8,"default_branch":"master"}},"base":{"label":"openzim:master","ref":"master","sha":"f3f14c4c09ca3df2465312c85b892912fcf627b2","user":{"login":"openzim","id":26540839,"avatar_url":"https://avatars0.githubusercontent.com/u/26540839?v=4","gravatar_id":"","url":"https://api.github.com/users/openzim","html_url":"https://github.com/openzim","followers_url":"https://api.github.com/users/openzim/followers","following_url":"https://api.github.com/users/openzim/following{/other_user}","gists_url":"https://api.github.com/users/openzim/gists{/gist_id}","starred_url":"https://api.github.com/users/openzim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openzim/subscriptions","organizations_url":"https://api.github.com/users/openzim/orgs","repos_url":"https://api.github.com/users/openzim/repos","events_url":"https://api.github.com/users/openzim/events{/privacy}","received_events_url":"https://api.github.com/users/openzim/received_events","type":"Organization","site_admin":false},"repo":{"id":87638778,"name":"libzim","full_name":"openzim/libzim","owner":{"login":"openzim","id":26540839,"avatar_url":"https://avatars0.githubusercontent.com/u/26540839?v=4","gravatar_id":"","url":"https://api.github.com/users/openzim","html_url":"https://github.com/openzim","followers_url":"https://api.github.com/users/openzim/followers","following_url":"https://api.github.com/users/openzim/following{/other_user}","gists_url":"https://api.github.com/users/openzim/gists{/gist_id}","starred_url":"https://api.github.com/users/openzim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openzim/subscriptions","organizations_url":"https://api.github.com/users/openzim/orgs","repos_url":"https://api.github.com/users/openzim/repos","events_url":"https://api.github.com/users/openzim/events{/privacy}","received_events_url":"https://api.github.com/users/openzim/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openzim/libzim","description":"Reference implementation of the ZIM specification","fork":false,"url":"https://api.github.com/repos/openzim/libzim","forks_url":"https://api.github.com/repos/openzim/libzim/forks","keys_url":"https://api.github.com/repos/openzim/libzim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openzim/libzim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openzim/libzim/teams","hooks_url":"https://api.github.com/repos/openzim/libzim/hooks","issue_events_url":"https://api.github.com/repos/openzim/libzim/issues/events{/number}","events_url":"https://api.github.com/repos/openzim/libzim/events","assignees_url":"https://api.github.com/repos/openzim/libzim/assignees{/user}","branches_url":"https://api.github.com/repos/openzim/libzim/branches{/branch}","tags_url":"https://api.github.com/repos/openzim/libzim/tags","blobs_url":"https://api.github.com/repos/openzim/libzim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openzim/libzim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openzim/libzim/git/refs{/sha}","trees_url":"https://api.github.com/repos/openzim/libzim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openzim/libzim/statuses/{sha}","languages_url":"https://api.github.com/repos/openzim/libzim/languages","stargazers_url":"https://api.github.com/repos/openzim/libzim/stargazers","contributors_url":"https://api.github.com/repos/openzim/libzim/contributors","subscribers_url":"https://api.github.com/repos/openzim/libzim/subscribers","subscription_url":"https://api.github.com/repos/openzim/libzim/subscription","commits_url":"https://api.github.com/repos/openzim/libzim/commits{/sha}","git_commits_url":"https://api.github.com/repos/openzim/libzim/git/commits{/sha}","comments_url":"https://api.github.com/repos/openzim/libzim/comments{/number}","issue_comment_url":"https://api.github.com/repos/openzim/libzim/issues/comments{/number}","contents_url":"https://api.github.com/repos/openzim/libzim/contents/{+path}","compare_url":"https://api.github.com/repos/openzim/libzim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openzim/libzim/merges","archive_url":"https://api.github.com/repos/openzim/libzim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openzim/libzim/downloads","issues_url":"https://api.github.com/repos/openzim/libzim/issues{/number}","pulls_url":"https://api.github.com/repos/openzim/libzim/pulls{/number}","milestones_url":"https://api.github.com/repos/openzim/libzim/milestones{/number}","notifications_url":"https://api.github.com/repos/openzim/libzim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openzim/libzim/labels{/name}","releases_url":"https://api.github.com/repos/openzim/libzim/releases{/id}","deployments_url":"https://api.github.com/repos/openzim/libzim/deployments","created_at":"2017-04-08T14:15:14Z","updated_at":"2017-09-12T19:05:34Z","pushed_at":"2017-09-25T15:10:13Z","git_url":"git://github.com/openzim/libzim.git","ssh_url":"git@github.com:openzim/libzim.git","clone_url":"https://github.com/openzim/libzim.git","svn_url":"https://github.com/openzim/libzim","homepage":null,"size":590,"stargazers_count":8,"watchers_count":8,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":13,"forks":2,"open_issues":13,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openzim/libzim/pulls/53"},"html":{"href":"https://github.com/openzim/libzim/pull/53"},"issue":{"href":"https://api.github.com/repos/openzim/libzim/issues/53"},"comments":{"href":"https://api.github.com/repos/openzim/libzim/issues/53/comments"},"review_comments":{"href":"https://api.github.com/repos/openzim/libzim/pulls/53/comments"},"review_comment":{"href":"https://api.github.com/repos/openzim/libzim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openzim/libzim/pulls/53/commits"},"statuses":{"href":"https://api.github.com/repos/openzim/libzim/statuses/b8915e2b6791d7c0afc5f326dab662c02870910e"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"mgautierfr","id":86161,"avatar_url":"https://avatars0.githubusercontent.com/u/86161?v=4","gravatar_id":"","url":"https://api.github.com/users/mgautierfr","html_url":"https://github.com/mgautierfr","followers_url":"https://api.github.com/users/mgautierfr/followers","following_url":"https://api.github.com/users/mgautierfr/following{/other_user}","gists_url":"https://api.github.com/users/mgautierfr/gists{/gist_id}","starred_url":"https://api.github.com/users/mgautierfr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgautierfr/subscriptions","organizations_url":"https://api.github.com/users/mgautierfr/orgs","repos_url":"https://api.github.com/users/mgautierfr/repos","events_url":"https://api.github.com/users/mgautierfr/events{/privacy}","received_events_url":"https://api.github.com/users/mgautierfr/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":102,"deletions":98,"changed_files":10}}
{"actor":{"display_login":"mgautierfr"}}