{"action":"created","issue":{"url":"https://api.github.com/repos/explosion/spaCy/issues/1276","repository_url":"https://api.github.com/repos/explosion/spaCy","labels_url":"https://api.github.com/repos/explosion/spaCy/issues/1276/labels{/name}","comments_url":"https://api.github.com/repos/explosion/spaCy/issues/1276/comments","events_url":"https://api.github.com/repos/explosion/spaCy/issues/1276/events","html_url":"https://github.com/explosion/spaCy/pull/1276","id":251446257,"number":1276,"title":"Ported model cli from v1","user":{"login":"oroszgy","id":145334,"avatar_url":"https://avatars2.githubusercontent.com/u/145334?v=4","gravatar_id":"","url":"https://api.github.com/users/oroszgy","html_url":"https://github.com/oroszgy","followers_url":"https://api.github.com/users/oroszgy/followers","following_url":"https://api.github.com/users/oroszgy/following{/other_user}","gists_url":"https://api.github.com/users/oroszgy/gists{/gist_id}","starred_url":"https://api.github.com/users/oroszgy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oroszgy/subscriptions","organizations_url":"https://api.github.com/users/oroszgy/orgs","repos_url":"https://api.github.com/users/oroszgy/repos","events_url":"https://api.github.com/users/oroszgy/events{/privacy}","received_events_url":"https://api.github.com/users/oroszgy/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-08-19T19:51:03Z","updated_at":"2017-08-20T09:52:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/explosion/spaCy/pulls/1276","html_url":"https://github.com/explosion/spaCy/pull/1276","diff_url":"https://github.com/explosion/spaCy/pull/1276.diff","patch_url":"https://github.com/explosion/spaCy/pull/1276.patch"},"body":"Ported Model CLI for v2\r\n\r\n## Description\r\nTook the model cli from the master branch, and adapted it for the v2 workflow. (Probably needs to be reviewed)\r\n\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all applicable boxes.: -->\r\n- [ ] **Bug fix** (non-breaking change fixing an issue)\r\n- [X] **New feature** (non-breaking change adding functionality to spaCy)\r\n- [ ] **Breaking change** (fix or feature causing change to spaCy's existing functionality)\r\n- [ ] **Documentation** (addition to documentation of spaCy)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all applicable boxes.: -->\r\n- [X] My change requires a change to spaCy's documentation.\r\n- [ ] I have updated the documentation accordingly.\r\n- [ ] I have added tests to cover my changes.\r\n- [ ] All new and existing tests passed.\r\n"},"comment":{"url":"https://api.github.com/repos/explosion/spaCy/issues/comments/323574989","html_url":"https://github.com/explosion/spaCy/pull/1276#issuecomment-323574989","issue_url":"https://api.github.com/repos/explosion/spaCy/issues/1276","id":323574989,"user":{"login":"ines","id":13643239,"avatar_url":"https://avatars0.githubusercontent.com/u/13643239?v=4","gravatar_id":"","url":"https://api.github.com/users/ines","html_url":"https://github.com/ines","followers_url":"https://api.github.com/users/ines/followers","following_url":"https://api.github.com/users/ines/following{/other_user}","gists_url":"https://api.github.com/users/ines/gists{/gist_id}","starred_url":"https://api.github.com/users/ines/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ines/subscriptions","organizations_url":"https://api.github.com/users/ines/orgs","repos_url":"https://api.github.com/users/ines/repos","events_url":"https://api.github.com/users/ines/events{/privacy}","received_events_url":"https://api.github.com/users/ines/received_events","type":"User","site_admin":false},"created_at":"2017-08-20T09:52:49Z","updated_at":"2017-08-20T09:52:49Z","body":"Thanks!  👍 If I remember correctly, we originally didn't include it because we thought it'd require too many changes and that it'd be redundant now that the serialisation is fixed. But of course, the frequencies etc. are still relevant. So thanks for taking this on!\r\n\r\nNow that I look at it again, maybe we should consider renaming the command? `spacy model` is a bit vague and possibly confusing to users. What do you think? I don't immediately have an idea, so we're open for suggestions!"}}
{"actor":{"display_login":"ines"}}