{"action":"created","issue":{"url":"https://api.github.com/repos/8thlight/cob_spec/issues/48","repository_url":"https://api.github.com/repos/8thlight/cob_spec","labels_url":"https://api.github.com/repos/8thlight/cob_spec/issues/48/labels{/name}","comments_url":"https://api.github.com/repos/8thlight/cob_spec/issues/48/comments","events_url":"https://api.github.com/repos/8thlight/cob_spec/issues/48/events","html_url":"https://github.com/8thlight/cob_spec/pull/48","id":180345747,"number":48,"title":"Add test to check when etag doesn't match file","user":{"login":"hnlee","id":4315162,"avatar_url":"https://avatars3.githubusercontent.com/u/4315162?v=3","gravatar_id":"","url":"https://api.github.com/users/hnlee","html_url":"https://github.com/hnlee","followers_url":"https://api.github.com/users/hnlee/followers","following_url":"https://api.github.com/users/hnlee/following{/other_user}","gists_url":"https://api.github.com/users/hnlee/gists{/gist_id}","starred_url":"https://api.github.com/users/hnlee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hnlee/subscriptions","organizations_url":"https://api.github.com/users/hnlee/orgs","repos_url":"https://api.github.com/users/hnlee/repos","events_url":"https://api.github.com/users/hnlee/events{/privacy}","received_events_url":"https://api.github.com/users/hnlee/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-09-30T16:23:17Z","updated_at":"2017-04-27T23:54:08Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/8thlight/cob_spec/pulls/48","html_url":"https://github.com/8thlight/cob_spec/pull/48","diff_url":"https://github.com/8thlight/cob_spec/pull/48.diff","patch_url":"https://github.com/8thlight/cob_spec/pull/48.patch"},"body":"Add a test to the current Patch With Etag to handle case when etag doesn't match file. Expected behavior is that server will return 409 response.\n"},"comment":{"url":"https://api.github.com/repos/8thlight/cob_spec/issues/comments/297870474","html_url":"https://github.com/8thlight/cob_spec/pull/48#issuecomment-297870474","issue_url":"https://api.github.com/repos/8thlight/cob_spec/issues/48","id":297870474,"user":{"login":"jdesrosiers","id":716571,"avatar_url":"https://avatars2.githubusercontent.com/u/716571?v=3","gravatar_id":"","url":"https://api.github.com/users/jdesrosiers","html_url":"https://github.com/jdesrosiers","followers_url":"https://api.github.com/users/jdesrosiers/followers","following_url":"https://api.github.com/users/jdesrosiers/following{/other_user}","gists_url":"https://api.github.com/users/jdesrosiers/gists{/gist_id}","starred_url":"https://api.github.com/users/jdesrosiers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdesrosiers/subscriptions","organizations_url":"https://api.github.com/users/jdesrosiers/orgs","repos_url":"https://api.github.com/users/jdesrosiers/repos","events_url":"https://api.github.com/users/jdesrosiers/events{/privacy}","received_events_url":"https://api.github.com/users/jdesrosiers/received_events","type":"User","site_admin":false},"created_at":"2017-04-27T23:54:08Z","updated_at":"2017-04-27T23:54:08Z","body":"I hate to bump an issue that has been dormant for months, but I wanted to point out that the proper response when ETags don't match is 412 Precondition Failed, not 409 Conflict.\r\n\r\nFrom RFC 5789 https://tools.ietf.org/html/rfc5789\r\n> When a client uses either the If-Match or If-Unmodified-Since header to define a precondition, and that precondition failed, then the 412 (Precondition Failed) error is most helpful to the client.  However, that response makes no sense if there was no precondition on the request.  In cases when the server detects a possible conflicting modification and no precondition was defined in the request, the server can return a 409 (Conflict) response."}}
{"actor":{"display_login":"jdesrosiers"}}