{"action":"created","issue":{"url":"https://api.github.com/repos/oscarbranson/cbsyst/issues/14","repository_url":"https://api.github.com/repos/oscarbranson/cbsyst","labels_url":"https://api.github.com/repos/oscarbranson/cbsyst/issues/14/labels{/name}","comments_url":"https://api.github.com/repos/oscarbranson/cbsyst/issues/14/comments","events_url":"https://api.github.com/repos/oscarbranson/cbsyst/issues/14/events","html_url":"https://github.com/oscarbranson/cbsyst/issues/14","id":239915318,"number":14,"title":"Alternative Constants?","user":{"login":"oscarbranson","id":3931960,"avatar_url":"https://avatars2.githubusercontent.com/u/3931960?v=3","gravatar_id":"","url":"https://api.github.com/users/oscarbranson","html_url":"https://github.com/oscarbranson","followers_url":"https://api.github.com/users/oscarbranson/followers","following_url":"https://api.github.com/users/oscarbranson/following{/other_user}","gists_url":"https://api.github.com/users/oscarbranson/gists{/gist_id}","starred_url":"https://api.github.com/users/oscarbranson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oscarbranson/subscriptions","organizations_url":"https://api.github.com/users/oscarbranson/orgs","repos_url":"https://api.github.com/users/oscarbranson/repos","events_url":"https://api.github.com/users/oscarbranson/events{/privacy}","received_events_url":"https://api.github.com/users/oscarbranson/received_events","type":"User","site_admin":false},"labels":[{"id":622162568,"url":"https://api.github.com/repos/oscarbranson/cbsyst/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-07-01T00:33:39Z","updated_at":"2017-07-01T21:33:36Z","closed_at":null,"body":"## Would other constants be useful?\r\nAt present, there are no options for different constants in cbsyst. Do people want/need choices?\r\n\r\nRequest constants in the comments below. If they get traction (i.e. lots of +1's), we'll implement them.\r\n\r\n## At present:\r\n**Constants as a function of Temperature and Salinity:**\r\n- K<sub>0</sub>, K<sub>1</sub>, K<sub>2</sub>, K<sub>B</sub>, K<sub>W</sub>, K<sub>SO4</sub> from Chapter 5 of [Dickson, Sabine and Christian (2007)](http://cdiac.ornl.gov/oceans/Handbook_2007.html), corrected for [Mg] and [Ca] after [Hain et al (2015)](http://dx.doi.org/10.1002/2014GB004986)\r\n- K<sub>sp</sub>(arag) and K<sub>sp</sub>(cal) from [Zeebe and Wolf-Gladrow (2001)](https://www.elsevier.com/books/co2-in-seawater-equilibrium-kinetics-isotopes/zeebe/978-0-444-50946-8)\r\n- K<sub>P1</sub>, K<sub>P2</sub>, K<sub>P3</sub>, K<sub>Si</sub> from from Chapter 5 of [Dickson, Sabine and Christian (2007)](http://cdiac.ornl.gov/oceans/Handbook_2007.html) ***not*** corrected for [Mg] and [Ca].\r\n- K<sub>F</sub> from [Dickson and Riley (1979)](http://dx.doi.org/10.1016/0304-4203(79)90001-x)\r\n\r\n**Pressure Corrections**\r\nAll pressure correction parameters from [Millero (2007)](http://dx.doi.org/10.1021/cr0503557), *with modifications*:\r\n- TYPO: Third parameter for K<sub>B</sub> was positive, should have been negative\r\n- TYPO: All 'b' parameters were missing a factor of 10<sup>-3</sup>\r\n- TYPO: K<sub>W</sub> parameters in original were for fresh water - replaced with seawater values from [Millero (1979)](https://doi.org/10.1016/B978-0-12-588608-6.50007-9)\r\n\r\n**Conserved Seawater Compositions:**\r\nAs a function of salinity:\r\n- TS of [Morris and Riley (1966)](https://doi.org/10.1016/0011-7471(66)90601-2)\r\n- TB of [Lee et al (2010)](https://doi.org/10.1016/j.gca.2009.12.027) *IF no value provided*. You can specify BT at S=35, and it scales with salinity.\r\n- TF of [Riley (1965)](https://doi.org/10.1016/0011-7471(65)90027-6)"},"comment":{"url":"https://api.github.com/repos/oscarbranson/cbsyst/issues/comments/312456752","html_url":"https://github.com/oscarbranson/cbsyst/issues/14#issuecomment-312456752","issue_url":"https://api.github.com/repos/oscarbranson/cbsyst/issues/14","id":312456752,"user":{"login":"oscarbranson","id":3931960,"avatar_url":"https://avatars2.githubusercontent.com/u/3931960?v=3","gravatar_id":"","url":"https://api.github.com/users/oscarbranson","html_url":"https://github.com/oscarbranson","followers_url":"https://api.github.com/users/oscarbranson/followers","following_url":"https://api.github.com/users/oscarbranson/following{/other_user}","gists_url":"https://api.github.com/users/oscarbranson/gists{/gist_id}","starred_url":"https://api.github.com/users/oscarbranson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oscarbranson/subscriptions","organizations_url":"https://api.github.com/users/oscarbranson/orgs","repos_url":"https://api.github.com/users/oscarbranson/repos","events_url":"https://api.github.com/users/oscarbranson/events{/privacy}","received_events_url":"https://api.github.com/users/oscarbranson/received_events","type":"User","site_admin":false},"created_at":"2017-07-01T21:33:36Z","updated_at":"2017-07-01T21:33:36Z","body":"Good thoughts @tompc35. Briefly:\r\n\r\n1. TB: You can also specify BT at S=35 manually, and it scales it with salinity. Falls back on Lee value *IF* not value is provided. Although in testing against GLODAPv2 I found the Lee value messed up Alkalinity, so I might switch the default back to Uppstrom.\r\n\r\n2. I originally used the KF described in the 2007 handbook, but found that it gave quite different results to Dickson and Riley, and didn't fit the GLODAPv2 data as well (possibly b/c typos?). Happy to revisit this."}}
{"actor":{"display_login":"oscarbranson"}}