{"action":"created","comment":{"url":"https://api.github.com/repos/caskdata/cdap/pulls/comments/99901631","pull_request_review_id":20591488,"id":99901631,"diff_hunk":"@@ -1479,4 +1492,16 @@ private void resetLogLevels(HttpRequest request, HttpResponder responder, String\n     }\n     return result;\n   }\n+\n+  private NamespaceId validateAndGetNamespace(String namespace) throws NamespaceNotFoundException {\n+    NamespaceId namespaceId = Ids.namespace(namespace);\n+    try {\n+      namespaceQueryAdmin.get(namespaceId);\n+    } catch (NamespaceNotFoundException e) {\n+      throw e;\n+    } catch (Exception e) {\n+      throw Throwables.propagate(e);","path":"cdap-app-fabric/src/main/java/co/cask/cdap/gateway/handlers/ProgramLifecycleHttpHandler.java","position":161,"original_position":161,"commit_id":"b95f7a941419e0b3258ada33e19d86aff8d9212d","original_commit_id":"b95f7a941419e0b3258ada33e19d86aff8d9212d","user":{"login":"Denton-L","id":9620836,"avatar_url":"https://avatars.githubusercontent.com/u/9620836?v=3","gravatar_id":"","url":"https://api.github.com/users/Denton-L","html_url":"https://github.com/Denton-L","followers_url":"https://api.github.com/users/Denton-L/followers","following_url":"https://api.github.com/users/Denton-L/following{/other_user}","gists_url":"https://api.github.com/users/Denton-L/gists{/gist_id}","starred_url":"https://api.github.com/users/Denton-L/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Denton-L/subscriptions","organizations_url":"https://api.github.com/users/Denton-L/orgs","repos_url":"https://api.github.com/users/Denton-L/repos","events_url":"https://api.github.com/users/Denton-L/events{/privacy}","received_events_url":"https://api.github.com/users/Denton-L/received_events","type":"User","site_admin":false},"body":"I was just copying from `ArtifactHttpHandler`. Do you think it would be worth it to refactor this stuff out later?","created_at":"2017-02-07T19:05:21Z","updated_at":"2017-02-07T19:05:21Z","html_url":"https://github.com/caskdata/cdap/pull/7842#discussion_r99901631","pull_request_url":"https://api.github.com/repos/caskdata/cdap/pulls/7842","_links":{"self":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/comments/99901631"},"html":{"href":"https://github.com/caskdata/cdap/pull/7842#discussion_r99901631"},"pull_request":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/7842"}}},"pull_request":{"url":"https://api.github.com/repos/caskdata/cdap/pulls/7842","id":104915832,"html_url":"https://github.com/caskdata/cdap/pull/7842","diff_url":"https://github.com/caskdata/cdap/pull/7842.diff","patch_url":"https://github.com/caskdata/cdap/pull/7842.patch","issue_url":"https://api.github.com/repos/caskdata/cdap/issues/7842","number":7842,"state":"open","locked":false,"title":"CDAP-6641 Return 404 when namespace doesn't exist","user":{"login":"Denton-L","id":9620836,"avatar_url":"https://avatars.githubusercontent.com/u/9620836?v=3","gravatar_id":"","url":"https://api.github.com/users/Denton-L","html_url":"https://github.com/Denton-L","followers_url":"https://api.github.com/users/Denton-L/followers","following_url":"https://api.github.com/users/Denton-L/following{/other_user}","gists_url":"https://api.github.com/users/Denton-L/gists{/gist_id}","starred_url":"https://api.github.com/users/Denton-L/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Denton-L/subscriptions","organizations_url":"https://api.github.com/users/Denton-L/orgs","repos_url":"https://api.github.com/users/Denton-L/repos","events_url":"https://api.github.com/users/Denton-L/events{/privacy}","received_events_url":"https://api.github.com/users/Denton-L/received_events","type":"User","site_admin":false},"body":"Prior to this, attempting to get items in a non-existant namespace would\r\nreturn a 200. This change forces a 404 to be returned instead.\r\n\r\nJIRA: https://issues.cask.co/browse/CDAP-6641\r\nBamboo: http://builds.cask.co/browse/CDAP-DUT5430","created_at":"2017-02-07T00:59:25Z","updated_at":"2017-02-07T19:05:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9e252a84c675d353c54184ac650dee58355579b4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/caskdata/cdap/pulls/7842/commits","review_comments_url":"https://api.github.com/repos/caskdata/cdap/pulls/7842/comments","review_comment_url":"https://api.github.com/repos/caskdata/cdap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/caskdata/cdap/issues/7842/comments","statuses_url":"https://api.github.com/repos/caskdata/cdap/statuses/b95f7a941419e0b3258ada33e19d86aff8d9212d","head":{"label":"caskdata:bugfix/CDAP-6641-404-on-no-namespace","ref":"bugfix/CDAP-6641-404-on-no-namespace","sha":"b95f7a941419e0b3258ada33e19d86aff8d9212d","user":{"login":"caskdata","id":8123023,"avatar_url":"https://avatars.githubusercontent.com/u/8123023?v=3","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"repo":{"id":22542759,"name":"cdap","full_name":"caskdata/cdap","owner":{"login":"caskdata","id":8123023,"avatar_url":"https://avatars.githubusercontent.com/u/8123023?v=3","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/caskdata/cdap","description":"Cask Data Application Platform (CDAP)","fork":false,"url":"https://api.github.com/repos/caskdata/cdap","forks_url":"https://api.github.com/repos/caskdata/cdap/forks","keys_url":"https://api.github.com/repos/caskdata/cdap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caskdata/cdap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caskdata/cdap/teams","hooks_url":"https://api.github.com/repos/caskdata/cdap/hooks","issue_events_url":"https://api.github.com/repos/caskdata/cdap/issues/events{/number}","events_url":"https://api.github.com/repos/caskdata/cdap/events","assignees_url":"https://api.github.com/repos/caskdata/cdap/assignees{/user}","branches_url":"https://api.github.com/repos/caskdata/cdap/branches{/branch}","tags_url":"https://api.github.com/repos/caskdata/cdap/tags","blobs_url":"https://api.github.com/repos/caskdata/cdap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caskdata/cdap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caskdata/cdap/git/refs{/sha}","trees_url":"https://api.github.com/repos/caskdata/cdap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caskdata/cdap/statuses/{sha}","languages_url":"https://api.github.com/repos/caskdata/cdap/languages","stargazers_url":"https://api.github.com/repos/caskdata/cdap/stargazers","contributors_url":"https://api.github.com/repos/caskdata/cdap/contributors","subscribers_url":"https://api.github.com/repos/caskdata/cdap/subscribers","subscription_url":"https://api.github.com/repos/caskdata/cdap/subscription","commits_url":"https://api.github.com/repos/caskdata/cdap/commits{/sha}","git_commits_url":"https://api.github.com/repos/caskdata/cdap/git/commits{/sha}","comments_url":"https://api.github.com/repos/caskdata/cdap/comments{/number}","issue_comment_url":"https://api.github.com/repos/caskdata/cdap/issues/comments{/number}","contents_url":"https://api.github.com/repos/caskdata/cdap/contents/{+path}","compare_url":"https://api.github.com/repos/caskdata/cdap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caskdata/cdap/merges","archive_url":"https://api.github.com/repos/caskdata/cdap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caskdata/cdap/downloads","issues_url":"https://api.github.com/repos/caskdata/cdap/issues{/number}","pulls_url":"https://api.github.com/repos/caskdata/cdap/pulls{/number}","milestones_url":"https://api.github.com/repos/caskdata/cdap/milestones{/number}","notifications_url":"https://api.github.com/repos/caskdata/cdap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caskdata/cdap/labels{/name}","releases_url":"https://api.github.com/repos/caskdata/cdap/releases{/id}","deployments_url":"https://api.github.com/repos/caskdata/cdap/deployments","created_at":"2014-08-02T09:00:10Z","updated_at":"2017-02-02T15:54:27Z","pushed_at":"2017-02-07T19:02:28Z","git_url":"git://github.com/caskdata/cdap.git","ssh_url":"git@github.com:caskdata/cdap.git","clone_url":"https://github.com/caskdata/cdap.git","svn_url":"https://github.com/caskdata/cdap","homepage":"http://cdap.io","size":483017,"stargazers_count":157,"watchers_count":157,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":75,"mirror_url":null,"open_issues_count":31,"forks":75,"open_issues":31,"watchers":157,"default_branch":"release/4.1"}},"base":{"label":"caskdata:develop","ref":"develop","sha":"2821b1e4ecd640f614cc553bed963b854bb6a28e","user":{"login":"caskdata","id":8123023,"avatar_url":"https://avatars.githubusercontent.com/u/8123023?v=3","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"repo":{"id":22542759,"name":"cdap","full_name":"caskdata/cdap","owner":{"login":"caskdata","id":8123023,"avatar_url":"https://avatars.githubusercontent.com/u/8123023?v=3","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/caskdata/cdap","description":"Cask Data Application Platform (CDAP)","fork":false,"url":"https://api.github.com/repos/caskdata/cdap","forks_url":"https://api.github.com/repos/caskdata/cdap/forks","keys_url":"https://api.github.com/repos/caskdata/cdap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caskdata/cdap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caskdata/cdap/teams","hooks_url":"https://api.github.com/repos/caskdata/cdap/hooks","issue_events_url":"https://api.github.com/repos/caskdata/cdap/issues/events{/number}","events_url":"https://api.github.com/repos/caskdata/cdap/events","assignees_url":"https://api.github.com/repos/caskdata/cdap/assignees{/user}","branches_url":"https://api.github.com/repos/caskdata/cdap/branches{/branch}","tags_url":"https://api.github.com/repos/caskdata/cdap/tags","blobs_url":"https://api.github.com/repos/caskdata/cdap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caskdata/cdap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caskdata/cdap/git/refs{/sha}","trees_url":"https://api.github.com/repos/caskdata/cdap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caskdata/cdap/statuses/{sha}","languages_url":"https://api.github.com/repos/caskdata/cdap/languages","stargazers_url":"https://api.github.com/repos/caskdata/cdap/stargazers","contributors_url":"https://api.github.com/repos/caskdata/cdap/contributors","subscribers_url":"https://api.github.com/repos/caskdata/cdap/subscribers","subscription_url":"https://api.github.com/repos/caskdata/cdap/subscription","commits_url":"https://api.github.com/repos/caskdata/cdap/commits{/sha}","git_commits_url":"https://api.github.com/repos/caskdata/cdap/git/commits{/sha}","comments_url":"https://api.github.com/repos/caskdata/cdap/comments{/number}","issue_comment_url":"https://api.github.com/repos/caskdata/cdap/issues/comments{/number}","contents_url":"https://api.github.com/repos/caskdata/cdap/contents/{+path}","compare_url":"https://api.github.com/repos/caskdata/cdap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caskdata/cdap/merges","archive_url":"https://api.github.com/repos/caskdata/cdap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caskdata/cdap/downloads","issues_url":"https://api.github.com/repos/caskdata/cdap/issues{/number}","pulls_url":"https://api.github.com/repos/caskdata/cdap/pulls{/number}","milestones_url":"https://api.github.com/repos/caskdata/cdap/milestones{/number}","notifications_url":"https://api.github.com/repos/caskdata/cdap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caskdata/cdap/labels{/name}","releases_url":"https://api.github.com/repos/caskdata/cdap/releases{/id}","deployments_url":"https://api.github.com/repos/caskdata/cdap/deployments","created_at":"2014-08-02T09:00:10Z","updated_at":"2017-02-02T15:54:27Z","pushed_at":"2017-02-07T19:02:28Z","git_url":"git://github.com/caskdata/cdap.git","ssh_url":"git@github.com:caskdata/cdap.git","clone_url":"https://github.com/caskdata/cdap.git","svn_url":"https://github.com/caskdata/cdap","homepage":"http://cdap.io","size":483017,"stargazers_count":157,"watchers_count":157,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":75,"mirror_url":null,"open_issues_count":31,"forks":75,"open_issues":31,"watchers":157,"default_branch":"release/4.1"}},"_links":{"self":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/7842"},"html":{"href":"https://github.com/caskdata/cdap/pull/7842"},"issue":{"href":"https://api.github.com/repos/caskdata/cdap/issues/7842"},"comments":{"href":"https://api.github.com/repos/caskdata/cdap/issues/7842/comments"},"review_comments":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/7842/comments"},"review_comment":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/7842/commits"},"statuses":{"href":"https://api.github.com/repos/caskdata/cdap/statuses/b95f7a941419e0b3258ada33e19d86aff8d9212d"}}}}
{"actor":{"display_login":"Denton-L"}}