{"action":"created","issue":{"url":"https://api.github.com/repos/vpulim/node-soap/issues/887","repository_url":"https://api.github.com/repos/vpulim/node-soap","labels_url":"https://api.github.com/repos/vpulim/node-soap/issues/887/labels{/name}","comments_url":"https://api.github.com/repos/vpulim/node-soap/issues/887/comments","events_url":"https://api.github.com/repos/vpulim/node-soap/issues/887/events","html_url":"https://github.com/vpulim/node-soap/pull/887","id":182564589,"number":887,"title":"Adding initial NTLM support (from https://github.com/vision10/node-soap)","user":{"login":"insanityinside","id":652759,"avatar_url":"https://avatars2.githubusercontent.com/u/652759?v=4","gravatar_id":"","url":"https://api.github.com/users/insanityinside","html_url":"https://github.com/insanityinside","followers_url":"https://api.github.com/users/insanityinside/followers","following_url":"https://api.github.com/users/insanityinside/following{/other_user}","gists_url":"https://api.github.com/users/insanityinside/gists{/gist_id}","starred_url":"https://api.github.com/users/insanityinside/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/insanityinside/subscriptions","organizations_url":"https://api.github.com/users/insanityinside/orgs","repos_url":"https://api.github.com/users/insanityinside/repos","events_url":"https://api.github.com/users/insanityinside/events{/privacy}","received_events_url":"https://api.github.com/users/insanityinside/received_events","type":"User","site_admin":false},"labels":[{"id":81197185,"url":"https://api.github.com/repos/vpulim/node-soap/labels/needs%20tests","name":"needs tests","color":"eb6420","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":20,"created_at":"2016-10-12T15:58:07Z","updated_at":"2017-10-05T11:32:16Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/vpulim/node-soap/pulls/887","html_url":"https://github.com/vpulim/node-soap/pull/887","diff_url":"https://github.com/vpulim/node-soap/pull/887.diff","patch_url":"https://github.com/vpulim/node-soap/pull/887.patch"},"body":"Pulling in changes from @vision10 https://github.com/vision10/node-soap (via @r24y https://github.com/r24y/node-soap/ who did some cleanup) into one clean package for a pull request.\n\nThis is a revised version of pull #885.\n\nCleaned up version of #776 and #741, syntax altered to match project. I've tested it against a live NTLM SOAP server, and it seems to work perfectly. Added basic instructions to the README with respect to syntax usage with the other security types, and regenerated TOC.\n\nThere is currently a check in http.js in HttpClient.prototype.request which has an if/else for the ntlm property. I suspect there's a better way to do this, but it's how it was done in the original code. Suggestions and pointers welcome, or move code around as appropriate. The code may need refactoring, but it seems reasonable enough to work with for now, and does seem to be functioning correctly.\n\nAlso requires tests implementing.\n"},"comment":{"url":"https://api.github.com/repos/vpulim/node-soap/issues/comments/334438121","html_url":"https://github.com/vpulim/node-soap/pull/887#issuecomment-334438121","issue_url":"https://api.github.com/repos/vpulim/node-soap/issues/887","id":334438121,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars1.githubusercontent.com/u/2354108?v=4","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2017-10-05T11:32:16Z","updated_at":"2017-10-05T11:32:16Z","author_association":"NONE","body":"\n[![Coverage Status](https://coveralls.io/builds/13582170/badge)](https://coveralls.io/builds/13582170)\n\nCoverage decreased (-0.7%) to 92.934% when pulling **6681e482dbac0853579abe532f2c91424313b520 on insanityinside:master** into **c94cc1cc63c152a70f7ad9fc4f4940ab163f6114 on vpulim:master**.\n"}}
{"actor":{"display_login":"coveralls"}}