{"action":"created","comment":{"url":"https://api.github.com/repos/beevik/ntp/pulls/comments/141498146","pull_request_review_id":65721806,"id":141498146,"diff_hunk":"@@ -407,78 +409,57 @@ func parseTime(m *msg, recvTime ntpTime) *Response {\n \n \t// Calculate values depending on other calculated values\n \tr.RootDistance = rootDistance(r.RTT, r.RootDelay, r.RootDispersion)\n-\tr.CausalityViolation = causalityViolation(r.RTT, r.ClockOffset)","path":"ntp.go","position":203,"original_position":207,"commit_id":"26f01f5d4f113a11716ca9a7e4dac4a82c17410c","original_commit_id":"f2cc06751273051e690823bdfb609c5161869b87","user":{"login":"beevik","id":466481,"avatar_url":"https://avatars2.githubusercontent.com/u/466481?v=4","gravatar_id":"","url":"https://api.github.com/users/beevik","html_url":"https://github.com/beevik","followers_url":"https://api.github.com/users/beevik/followers","following_url":"https://api.github.com/users/beevik/following{/other_user}","gists_url":"https://api.github.com/users/beevik/gists{/gist_id}","starred_url":"https://api.github.com/users/beevik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beevik/subscriptions","organizations_url":"https://api.github.com/users/beevik/orgs","repos_url":"https://api.github.com/users/beevik/repos","events_url":"https://api.github.com/users/beevik/events{/privacy}","received_events_url":"https://api.github.com/users/beevik/received_events","type":"User","site_admin":false},"body":"Thanks for putting up with all my questions.\r\n\r\nAfter your most recent example, I understand better the meaning of \"causality violation\" and how it can be greater than zero in realistic scenarios.  Maybe the name \"causality violation\" is what is throwing me off, because it implies something that should be impossible.  There are no physical phenomena that violate the principle of causality. \r\n\r\nWhat this really is is a lower bound on the clock offset.  Once you know this value, how is it useful?  What can you do with it?","created_at":"2017-09-28T00:07:12Z","updated_at":"2017-09-28T00:07:12Z","html_url":"https://github.com/beevik/ntp/pull/22#discussion_r141498146","pull_request_url":"https://api.github.com/repos/beevik/ntp/pulls/22","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/beevik/ntp/pulls/comments/141498146"},"html":{"href":"https://github.com/beevik/ntp/pull/22#discussion_r141498146"},"pull_request":{"href":"https://api.github.com/repos/beevik/ntp/pulls/22"}},"in_reply_to_id":140879325},"pull_request":{"url":"https://api.github.com/repos/beevik/ntp/pulls/22","id":142773070,"html_url":"https://github.com/beevik/ntp/pull/22","diff_url":"https://github.com/beevik/ntp/pull/22.diff","patch_url":"https://github.com/beevik/ntp/pull/22.patch","issue_url":"https://api.github.com/repos/beevik/ntp/issues/22","number":22,"state":"open","locked":false,"title":"Bring calculations into better alignment with RFC.","user":{"login":"beevik","id":466481,"avatar_url":"https://avatars2.githubusercontent.com/u/466481?v=4","gravatar_id":"","url":"https://api.github.com/users/beevik","html_url":"https://github.com/beevik","followers_url":"https://api.github.com/users/beevik/followers","following_url":"https://api.github.com/users/beevik/following{/other_user}","gists_url":"https://api.github.com/users/beevik/gists{/gist_id}","starred_url":"https://api.github.com/users/beevik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beevik/subscriptions","organizations_url":"https://api.github.com/users/beevik/orgs","repos_url":"https://api.github.com/users/beevik/repos","events_url":"https://api.github.com/users/beevik/events{/privacy}","received_events_url":"https://api.github.com/users/beevik/received_events","type":"User","site_admin":false},"body":"RTT calculation can no longer yield a result less than the precision value.\r\nAccount for minimum dispersion in the calculation of the root distance.\r\nUpdated the comments for all calculated fields to better match the RFC.\r\nRemoved casuality violation until I have a better understanding of how it's useful.","created_at":"2017-09-24T22:05:41Z","updated_at":"2017-09-28T00:07:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1a2a5f6ede5d1dee2175ff10d815e00a966dc795","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/beevik/ntp/pulls/22/commits","review_comments_url":"https://api.github.com/repos/beevik/ntp/pulls/22/comments","review_comment_url":"https://api.github.com/repos/beevik/ntp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/beevik/ntp/issues/22/comments","statuses_url":"https://api.github.com/repos/beevik/ntp/statuses/26f01f5d4f113a11716ca9a7e4dac4a82c17410c","head":{"label":"beevik:refactor","ref":"refactor","sha":"26f01f5d4f113a11716ca9a7e4dac4a82c17410c","user":{"login":"beevik","id":466481,"avatar_url":"https://avatars2.githubusercontent.com/u/466481?v=4","gravatar_id":"","url":"https://api.github.com/users/beevik","html_url":"https://github.com/beevik","followers_url":"https://api.github.com/users/beevik/followers","following_url":"https://api.github.com/users/beevik/following{/other_user}","gists_url":"https://api.github.com/users/beevik/gists{/gist_id}","starred_url":"https://api.github.com/users/beevik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beevik/subscriptions","organizations_url":"https://api.github.com/users/beevik/orgs","repos_url":"https://api.github.com/users/beevik/repos","events_url":"https://api.github.com/users/beevik/events{/privacy}","received_events_url":"https://api.github.com/users/beevik/received_events","type":"User","site_admin":false},"repo":{"id":11237307,"name":"ntp","full_name":"beevik/ntp","owner":{"login":"beevik","id":466481,"avatar_url":"https://avatars2.githubusercontent.com/u/466481?v=4","gravatar_id":"","url":"https://api.github.com/users/beevik","html_url":"https://github.com/beevik","followers_url":"https://api.github.com/users/beevik/followers","following_url":"https://api.github.com/users/beevik/following{/other_user}","gists_url":"https://api.github.com/users/beevik/gists{/gist_id}","starred_url":"https://api.github.com/users/beevik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beevik/subscriptions","organizations_url":"https://api.github.com/users/beevik/orgs","repos_url":"https://api.github.com/users/beevik/repos","events_url":"https://api.github.com/users/beevik/events{/privacy}","received_events_url":"https://api.github.com/users/beevik/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/beevik/ntp","description":"a simple ntp client written in go","fork":false,"url":"https://api.github.com/repos/beevik/ntp","forks_url":"https://api.github.com/repos/beevik/ntp/forks","keys_url":"https://api.github.com/repos/beevik/ntp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/beevik/ntp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/beevik/ntp/teams","hooks_url":"https://api.github.com/repos/beevik/ntp/hooks","issue_events_url":"https://api.github.com/repos/beevik/ntp/issues/events{/number}","events_url":"https://api.github.com/repos/beevik/ntp/events","assignees_url":"https://api.github.com/repos/beevik/ntp/assignees{/user}","branches_url":"https://api.github.com/repos/beevik/ntp/branches{/branch}","tags_url":"https://api.github.com/repos/beevik/ntp/tags","blobs_url":"https://api.github.com/repos/beevik/ntp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/beevik/ntp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/beevik/ntp/git/refs{/sha}","trees_url":"https://api.github.com/repos/beevik/ntp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/beevik/ntp/statuses/{sha}","languages_url":"https://api.github.com/repos/beevik/ntp/languages","stargazers_url":"https://api.github.com/repos/beevik/ntp/stargazers","contributors_url":"https://api.github.com/repos/beevik/ntp/contributors","subscribers_url":"https://api.github.com/repos/beevik/ntp/subscribers","subscription_url":"https://api.github.com/repos/beevik/ntp/subscription","commits_url":"https://api.github.com/repos/beevik/ntp/commits{/sha}","git_commits_url":"https://api.github.com/repos/beevik/ntp/git/commits{/sha}","comments_url":"https://api.github.com/repos/beevik/ntp/comments{/number}","issue_comment_url":"https://api.github.com/repos/beevik/ntp/issues/comments{/number}","contents_url":"https://api.github.com/repos/beevik/ntp/contents/{+path}","compare_url":"https://api.github.com/repos/beevik/ntp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/beevik/ntp/merges","archive_url":"https://api.github.com/repos/beevik/ntp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/beevik/ntp/downloads","issues_url":"https://api.github.com/repos/beevik/ntp/issues{/number}","pulls_url":"https://api.github.com/repos/beevik/ntp/pulls{/number}","milestones_url":"https://api.github.com/repos/beevik/ntp/milestones{/number}","notifications_url":"https://api.github.com/repos/beevik/ntp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/beevik/ntp/labels{/name}","releases_url":"https://api.github.com/repos/beevik/ntp/releases{/id}","deployments_url":"https://api.github.com/repos/beevik/ntp/deployments","created_at":"2013-07-07T17:48:24Z","updated_at":"2017-09-20T07:35:55Z","pushed_at":"2017-09-27T16:12:32Z","git_url":"git://github.com/beevik/ntp.git","ssh_url":"git@github.com:beevik/ntp.git","clone_url":"https://github.com/beevik/ntp.git","svn_url":"https://github.com/beevik/ntp","homepage":"","size":71,"stargazers_count":48,"watchers_count":48,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"open_issues_count":1,"forks":22,"open_issues":1,"watchers":48,"default_branch":"master"}},"base":{"label":"beevik:master","ref":"master","sha":"53e7ec2b0576f52183754995dcf7795f9f835d5b","user":{"login":"beevik","id":466481,"avatar_url":"https://avatars2.githubusercontent.com/u/466481?v=4","gravatar_id":"","url":"https://api.github.com/users/beevik","html_url":"https://github.com/beevik","followers_url":"https://api.github.com/users/beevik/followers","following_url":"https://api.github.com/users/beevik/following{/other_user}","gists_url":"https://api.github.com/users/beevik/gists{/gist_id}","starred_url":"https://api.github.com/users/beevik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beevik/subscriptions","organizations_url":"https://api.github.com/users/beevik/orgs","repos_url":"https://api.github.com/users/beevik/repos","events_url":"https://api.github.com/users/beevik/events{/privacy}","received_events_url":"https://api.github.com/users/beevik/received_events","type":"User","site_admin":false},"repo":{"id":11237307,"name":"ntp","full_name":"beevik/ntp","owner":{"login":"beevik","id":466481,"avatar_url":"https://avatars2.githubusercontent.com/u/466481?v=4","gravatar_id":"","url":"https://api.github.com/users/beevik","html_url":"https://github.com/beevik","followers_url":"https://api.github.com/users/beevik/followers","following_url":"https://api.github.com/users/beevik/following{/other_user}","gists_url":"https://api.github.com/users/beevik/gists{/gist_id}","starred_url":"https://api.github.com/users/beevik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beevik/subscriptions","organizations_url":"https://api.github.com/users/beevik/orgs","repos_url":"https://api.github.com/users/beevik/repos","events_url":"https://api.github.com/users/beevik/events{/privacy}","received_events_url":"https://api.github.com/users/beevik/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/beevik/ntp","description":"a simple ntp client written in go","fork":false,"url":"https://api.github.com/repos/beevik/ntp","forks_url":"https://api.github.com/repos/beevik/ntp/forks","keys_url":"https://api.github.com/repos/beevik/ntp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/beevik/ntp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/beevik/ntp/teams","hooks_url":"https://api.github.com/repos/beevik/ntp/hooks","issue_events_url":"https://api.github.com/repos/beevik/ntp/issues/events{/number}","events_url":"https://api.github.com/repos/beevik/ntp/events","assignees_url":"https://api.github.com/repos/beevik/ntp/assignees{/user}","branches_url":"https://api.github.com/repos/beevik/ntp/branches{/branch}","tags_url":"https://api.github.com/repos/beevik/ntp/tags","blobs_url":"https://api.github.com/repos/beevik/ntp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/beevik/ntp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/beevik/ntp/git/refs{/sha}","trees_url":"https://api.github.com/repos/beevik/ntp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/beevik/ntp/statuses/{sha}","languages_url":"https://api.github.com/repos/beevik/ntp/languages","stargazers_url":"https://api.github.com/repos/beevik/ntp/stargazers","contributors_url":"https://api.github.com/repos/beevik/ntp/contributors","subscribers_url":"https://api.github.com/repos/beevik/ntp/subscribers","subscription_url":"https://api.github.com/repos/beevik/ntp/subscription","commits_url":"https://api.github.com/repos/beevik/ntp/commits{/sha}","git_commits_url":"https://api.github.com/repos/beevik/ntp/git/commits{/sha}","comments_url":"https://api.github.com/repos/beevik/ntp/comments{/number}","issue_comment_url":"https://api.github.com/repos/beevik/ntp/issues/comments{/number}","contents_url":"https://api.github.com/repos/beevik/ntp/contents/{+path}","compare_url":"https://api.github.com/repos/beevik/ntp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/beevik/ntp/merges","archive_url":"https://api.github.com/repos/beevik/ntp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/beevik/ntp/downloads","issues_url":"https://api.github.com/repos/beevik/ntp/issues{/number}","pulls_url":"https://api.github.com/repos/beevik/ntp/pulls{/number}","milestones_url":"https://api.github.com/repos/beevik/ntp/milestones{/number}","notifications_url":"https://api.github.com/repos/beevik/ntp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/beevik/ntp/labels{/name}","releases_url":"https://api.github.com/repos/beevik/ntp/releases{/id}","deployments_url":"https://api.github.com/repos/beevik/ntp/deployments","created_at":"2013-07-07T17:48:24Z","updated_at":"2017-09-20T07:35:55Z","pushed_at":"2017-09-27T16:12:32Z","git_url":"git://github.com/beevik/ntp.git","ssh_url":"git@github.com:beevik/ntp.git","clone_url":"https://github.com/beevik/ntp.git","svn_url":"https://github.com/beevik/ntp","homepage":"","size":71,"stargazers_count":48,"watchers_count":48,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"open_issues_count":1,"forks":22,"open_issues":1,"watchers":48,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/beevik/ntp/pulls/22"},"html":{"href":"https://github.com/beevik/ntp/pull/22"},"issue":{"href":"https://api.github.com/repos/beevik/ntp/issues/22"},"comments":{"href":"https://api.github.com/repos/beevik/ntp/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/beevik/ntp/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/beevik/ntp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/beevik/ntp/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/beevik/ntp/statuses/26f01f5d4f113a11716ca9a7e4dac4a82c17410c"}},"author_association":"OWNER"}}
{"actor":{"display_login":"beevik"}}