{"action":"created","issue":{"url":"https://api.github.com/repos/airbnb/sparsam/issues/11","repository_url":"https://api.github.com/repos/airbnb/sparsam","labels_url":"https://api.github.com/repos/airbnb/sparsam/issues/11/labels{/name}","comments_url":"https://api.github.com/repos/airbnb/sparsam/issues/11/comments","events_url":"https://api.github.com/repos/airbnb/sparsam/issues/11/events","html_url":"https://github.com/airbnb/sparsam/pull/11","id":263222085,"number":11,"title":"Bring back the namespaced option","user":{"login":"jack2684","id":1225301,"avatar_url":"https://avatars1.githubusercontent.com/u/1225301?v=4","gravatar_id":"","url":"https://api.github.com/users/jack2684","html_url":"https://github.com/jack2684","followers_url":"https://api.github.com/users/jack2684/followers","following_url":"https://api.github.com/users/jack2684/following{/other_user}","gists_url":"https://api.github.com/users/jack2684/gists{/gist_id}","starred_url":"https://api.github.com/users/jack2684/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jack2684/subscriptions","organizations_url":"https://api.github.com/users/jack2684/orgs","repos_url":"https://api.github.com/users/jack2684/repos","events_url":"https://api.github.com/users/jack2684/events{/privacy}","received_events_url":"https://api.github.com/users/jack2684/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-10-05T18:28:43Z","updated_at":"2017-10-05T18:47:11Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/airbnb/sparsam/pulls/11","html_url":"https://github.com/airbnb/sparsam/pull/11","diff_url":"https://github.com/airbnb/sparsam/pull/11.diff","patch_url":"https://github.com/airbnb/sparsam/pull/11.patch"},"body":"### About\r\n`namespaced` is a useful feature to generate Ruby files in idiomatic namespaced directories. I believe it was removed unintentionally when removing the `--gen` option.\r\n\r\n```\r\n./sparsam-gen -help\r\nAvailable generators (and options):\r\n  ruby (Ruby Sparsam bindings):\r\n    namespaced:      Generate files in idiomatic namespaced directories.\r\n```\r\n\r\nThis PR bring back the `--gen`, while not enforcing it.\r\n\r\n### Test\r\nTest that both following command work. The later one is able to generate files in idiomatic namespaced directories.\r\n```\r\n./sparsam-gen test.thrift\r\n```\r\n```\r\n./sparsam-gen --gen ruby:namespaced test.thrift\r\n```\r\n\r\n### Next step\r\nUpdate doc accordingly\r\n\r\n@AngerM "},"comment":{"url":"https://api.github.com/repos/airbnb/sparsam/issues/comments/334556971","html_url":"https://github.com/airbnb/sparsam/pull/11#issuecomment-334556971","issue_url":"https://api.github.com/repos/airbnb/sparsam/issues/11","id":334556971,"user":{"login":"jack2684","id":1225301,"avatar_url":"https://avatars1.githubusercontent.com/u/1225301?v=4","gravatar_id":"","url":"https://api.github.com/users/jack2684","html_url":"https://github.com/jack2684","followers_url":"https://api.github.com/users/jack2684/followers","following_url":"https://api.github.com/users/jack2684/following{/other_user}","gists_url":"https://api.github.com/users/jack2684/gists{/gist_id}","starred_url":"https://api.github.com/users/jack2684/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jack2684/subscriptions","organizations_url":"https://api.github.com/users/jack2684/orgs","repos_url":"https://api.github.com/users/jack2684/repos","events_url":"https://api.github.com/users/jack2684/events{/privacy}","received_events_url":"https://api.github.com/users/jack2684/received_events","type":"User","site_admin":false},"created_at":"2017-10-05T18:47:11Z","updated_at":"2017-10-05T18:47:11Z","author_association":"NONE","body":"@AngerM Either way is easy in terms of implementation. My intention is to make the usage consistent with original Apache Thrfit compiler, such that existing Apache Thrift compiler users know how to use it without any friction.\r\n\r\nBut if you insist on making it `-namespaced`, I don't have objection either. 🙂 "}}
{"actor":{"display_login":"jack2684"}}