{"action":"created","comment":{"url":"https://api.github.com/repos/rabernat/xrft/pulls/comments/117381249","pull_request_review_id":39085075,"id":117381249,"diff_hunk":"@@ -1,12 +1,15 @@\n import numpy as np\n import xarray as xr\n import pandas as pd\n+import functools as ft\n import dask.array as dsar\n \n-__all__ = [\"dft\"]\n+__all__ = [\"dft\",\"power_spectrum\",\"cross_spectrum\",\n+            \"isotropic_powerspectrum\",\"isotropic_crossspectrum\",\n+            \"fit_loglog\"]\n \n \n-def dft(da, dim=None, shift=True, remove_mean=True, density=False):\n+def dft(da, dim=None, shift=True, remove_mean=True):\n     \"\"\"\n     Perform discrete Fourier transform of xarray data-array `da` along the\n     specified dimensions.","path":"xrft/xrft.py","position":17,"original_position":17,"commit_id":"dc9d230c97ee02b59dc1cecf84864f3fc21c278a","original_commit_id":"dc9d230c97ee02b59dc1cecf84864f3fc21c278a","user":{"login":"rabernat","id":1197350,"avatar_url":"https://avatars2.githubusercontent.com/u/1197350?v=3","gravatar_id":"","url":"https://api.github.com/users/rabernat","html_url":"https://github.com/rabernat","followers_url":"https://api.github.com/users/rabernat/followers","following_url":"https://api.github.com/users/rabernat/following{/other_user}","gists_url":"https://api.github.com/users/rabernat/gists{/gist_id}","starred_url":"https://api.github.com/users/rabernat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rabernat/subscriptions","organizations_url":"https://api.github.com/users/rabernat/orgs","repos_url":"https://api.github.com/users/rabernat/repos","events_url":"https://api.github.com/users/rabernat/events{/privacy}","received_events_url":"https://api.github.com/users/rabernat/received_events","type":"User","site_admin":false},"body":"I recommend including the mathematical expression for what is calculated directly in the docstring. See [numpydoc documenation](https://github.com/numpy/numpy/blob/master/doc/HOWTO_DOCUMENT.rst.txt) for info on how to do this.","created_at":"2017-05-19T00:10:23Z","updated_at":"2017-05-19T00:14:40Z","html_url":"https://github.com/rabernat/xrft/pull/4#discussion_r117381249","pull_request_url":"https://api.github.com/repos/rabernat/xrft/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/rabernat/xrft/pulls/comments/117381249"},"html":{"href":"https://github.com/rabernat/xrft/pull/4#discussion_r117381249"},"pull_request":{"href":"https://api.github.com/repos/rabernat/xrft/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/rabernat/xrft/pulls/4","id":118789671,"html_url":"https://github.com/rabernat/xrft/pull/4","diff_url":"https://github.com/rabernat/xrft/pull/4.diff","patch_url":"https://github.com/rabernat/xrft/pull/4.patch","issue_url":"https://api.github.com/repos/rabernat/xrft/issues/4","number":4,"state":"open","locked":false,"title":"Isotropic","user":{"login":"roxyboy","id":8934026,"avatar_url":"https://avatars3.githubusercontent.com/u/8934026?v=3","gravatar_id":"","url":"https://api.github.com/users/roxyboy","html_url":"https://github.com/roxyboy","followers_url":"https://api.github.com/users/roxyboy/followers","following_url":"https://api.github.com/users/roxyboy/following{/other_user}","gists_url":"https://api.github.com/users/roxyboy/gists{/gist_id}","starred_url":"https://api.github.com/users/roxyboy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roxyboy/subscriptions","organizations_url":"https://api.github.com/users/roxyboy/orgs","repos_url":"https://api.github.com/users/roxyboy/repos","events_url":"https://api.github.com/users/roxyboy/events{/privacy}","received_events_url":"https://api.github.com/users/roxyboy/received_events","type":"User","site_admin":false},"body":"added isotropic PSD calculation in `xrft.py` and example notebook under scripts/","created_at":"2017-05-03T15:29:47Z","updated_at":"2017-05-19T00:14:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8c49f949f24106c49822a8dad1c4603945b45b5a","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/rabernat/xrft/pulls/4/commits","review_comments_url":"https://api.github.com/repos/rabernat/xrft/pulls/4/comments","review_comment_url":"https://api.github.com/repos/rabernat/xrft/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rabernat/xrft/issues/4/comments","statuses_url":"https://api.github.com/repos/rabernat/xrft/statuses/dc9d230c97ee02b59dc1cecf84864f3fc21c278a","head":{"label":"roxyboy:isotropic","ref":"isotropic","sha":"dc9d230c97ee02b59dc1cecf84864f3fc21c278a","user":{"login":"roxyboy","id":8934026,"avatar_url":"https://avatars3.githubusercontent.com/u/8934026?v=3","gravatar_id":"","url":"https://api.github.com/users/roxyboy","html_url":"https://github.com/roxyboy","followers_url":"https://api.github.com/users/roxyboy/followers","following_url":"https://api.github.com/users/roxyboy/following{/other_user}","gists_url":"https://api.github.com/users/roxyboy/gists{/gist_id}","starred_url":"https://api.github.com/users/roxyboy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roxyboy/subscriptions","organizations_url":"https://api.github.com/users/roxyboy/orgs","repos_url":"https://api.github.com/users/roxyboy/repos","events_url":"https://api.github.com/users/roxyboy/events{/privacy}","received_events_url":"https://api.github.com/users/roxyboy/received_events","type":"User","site_admin":false},"repo":{"id":89723965,"name":"xrft","full_name":"roxyboy/xrft","owner":{"login":"roxyboy","id":8934026,"avatar_url":"https://avatars3.githubusercontent.com/u/8934026?v=3","gravatar_id":"","url":"https://api.github.com/users/roxyboy","html_url":"https://github.com/roxyboy","followers_url":"https://api.github.com/users/roxyboy/followers","following_url":"https://api.github.com/users/roxyboy/following{/other_user}","gists_url":"https://api.github.com/users/roxyboy/gists{/gist_id}","starred_url":"https://api.github.com/users/roxyboy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roxyboy/subscriptions","organizations_url":"https://api.github.com/users/roxyboy/orgs","repos_url":"https://api.github.com/users/roxyboy/repos","events_url":"https://api.github.com/users/roxyboy/events{/privacy}","received_events_url":"https://api.github.com/users/roxyboy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/roxyboy/xrft","description":"Fourier transforms on xarray data structures","fork":true,"url":"https://api.github.com/repos/roxyboy/xrft","forks_url":"https://api.github.com/repos/roxyboy/xrft/forks","keys_url":"https://api.github.com/repos/roxyboy/xrft/keys{/key_id}","collaborators_url":"https://api.github.com/repos/roxyboy/xrft/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/roxyboy/xrft/teams","hooks_url":"https://api.github.com/repos/roxyboy/xrft/hooks","issue_events_url":"https://api.github.com/repos/roxyboy/xrft/issues/events{/number}","events_url":"https://api.github.com/repos/roxyboy/xrft/events","assignees_url":"https://api.github.com/repos/roxyboy/xrft/assignees{/user}","branches_url":"https://api.github.com/repos/roxyboy/xrft/branches{/branch}","tags_url":"https://api.github.com/repos/roxyboy/xrft/tags","blobs_url":"https://api.github.com/repos/roxyboy/xrft/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/roxyboy/xrft/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/roxyboy/xrft/git/refs{/sha}","trees_url":"https://api.github.com/repos/roxyboy/xrft/git/trees{/sha}","statuses_url":"https://api.github.com/repos/roxyboy/xrft/statuses/{sha}","languages_url":"https://api.github.com/repos/roxyboy/xrft/languages","stargazers_url":"https://api.github.com/repos/roxyboy/xrft/stargazers","contributors_url":"https://api.github.com/repos/roxyboy/xrft/contributors","subscribers_url":"https://api.github.com/repos/roxyboy/xrft/subscribers","subscription_url":"https://api.github.com/repos/roxyboy/xrft/subscription","commits_url":"https://api.github.com/repos/roxyboy/xrft/commits{/sha}","git_commits_url":"https://api.github.com/repos/roxyboy/xrft/git/commits{/sha}","comments_url":"https://api.github.com/repos/roxyboy/xrft/comments{/number}","issue_comment_url":"https://api.github.com/repos/roxyboy/xrft/issues/comments{/number}","contents_url":"https://api.github.com/repos/roxyboy/xrft/contents/{+path}","compare_url":"https://api.github.com/repos/roxyboy/xrft/compare/{base}...{head}","merges_url":"https://api.github.com/repos/roxyboy/xrft/merges","archive_url":"https://api.github.com/repos/roxyboy/xrft/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/roxyboy/xrft/downloads","issues_url":"https://api.github.com/repos/roxyboy/xrft/issues{/number}","pulls_url":"https://api.github.com/repos/roxyboy/xrft/pulls{/number}","milestones_url":"https://api.github.com/repos/roxyboy/xrft/milestones{/number}","notifications_url":"https://api.github.com/repos/roxyboy/xrft/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/roxyboy/xrft/labels{/name}","releases_url":"https://api.github.com/repos/roxyboy/xrft/releases{/id}","deployments_url":"https://api.github.com/repos/roxyboy/xrft/deployments","created_at":"2017-04-28T16:22:21Z","updated_at":"2017-04-28T16:22:23Z","pushed_at":"2017-05-18T21:16:06Z","git_url":"git://github.com/roxyboy/xrft.git","ssh_url":"git@github.com:roxyboy/xrft.git","clone_url":"https://github.com/roxyboy/xrft.git","svn_url":"https://github.com/roxyboy/xrft","homepage":null,"size":1693,"stargazers_count":0,"watchers_count":0,"language":"Jupyter Notebook","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rabernat:master","ref":"master","sha":"e05a90da5410e50ed6defe180ff7cd335c29167a","user":{"login":"rabernat","id":1197350,"avatar_url":"https://avatars2.githubusercontent.com/u/1197350?v=3","gravatar_id":"","url":"https://api.github.com/users/rabernat","html_url":"https://github.com/rabernat","followers_url":"https://api.github.com/users/rabernat/followers","following_url":"https://api.github.com/users/rabernat/following{/other_user}","gists_url":"https://api.github.com/users/rabernat/gists{/gist_id}","starred_url":"https://api.github.com/users/rabernat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rabernat/subscriptions","organizations_url":"https://api.github.com/users/rabernat/orgs","repos_url":"https://api.github.com/users/rabernat/repos","events_url":"https://api.github.com/users/rabernat/events{/privacy}","received_events_url":"https://api.github.com/users/rabernat/received_events","type":"User","site_admin":false},"repo":{"id":60866797,"name":"xrft","full_name":"rabernat/xrft","owner":{"login":"rabernat","id":1197350,"avatar_url":"https://avatars2.githubusercontent.com/u/1197350?v=3","gravatar_id":"","url":"https://api.github.com/users/rabernat","html_url":"https://github.com/rabernat","followers_url":"https://api.github.com/users/rabernat/followers","following_url":"https://api.github.com/users/rabernat/following{/other_user}","gists_url":"https://api.github.com/users/rabernat/gists{/gist_id}","starred_url":"https://api.github.com/users/rabernat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rabernat/subscriptions","organizations_url":"https://api.github.com/users/rabernat/orgs","repos_url":"https://api.github.com/users/rabernat/repos","events_url":"https://api.github.com/users/rabernat/events{/privacy}","received_events_url":"https://api.github.com/users/rabernat/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rabernat/xrft","description":"Fourier transforms on xarray data structures","fork":false,"url":"https://api.github.com/repos/rabernat/xrft","forks_url":"https://api.github.com/repos/rabernat/xrft/forks","keys_url":"https://api.github.com/repos/rabernat/xrft/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rabernat/xrft/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rabernat/xrft/teams","hooks_url":"https://api.github.com/repos/rabernat/xrft/hooks","issue_events_url":"https://api.github.com/repos/rabernat/xrft/issues/events{/number}","events_url":"https://api.github.com/repos/rabernat/xrft/events","assignees_url":"https://api.github.com/repos/rabernat/xrft/assignees{/user}","branches_url":"https://api.github.com/repos/rabernat/xrft/branches{/branch}","tags_url":"https://api.github.com/repos/rabernat/xrft/tags","blobs_url":"https://api.github.com/repos/rabernat/xrft/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rabernat/xrft/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rabernat/xrft/git/refs{/sha}","trees_url":"https://api.github.com/repos/rabernat/xrft/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rabernat/xrft/statuses/{sha}","languages_url":"https://api.github.com/repos/rabernat/xrft/languages","stargazers_url":"https://api.github.com/repos/rabernat/xrft/stargazers","contributors_url":"https://api.github.com/repos/rabernat/xrft/contributors","subscribers_url":"https://api.github.com/repos/rabernat/xrft/subscribers","subscription_url":"https://api.github.com/repos/rabernat/xrft/subscription","commits_url":"https://api.github.com/repos/rabernat/xrft/commits{/sha}","git_commits_url":"https://api.github.com/repos/rabernat/xrft/git/commits{/sha}","comments_url":"https://api.github.com/repos/rabernat/xrft/comments{/number}","issue_comment_url":"https://api.github.com/repos/rabernat/xrft/issues/comments{/number}","contents_url":"https://api.github.com/repos/rabernat/xrft/contents/{+path}","compare_url":"https://api.github.com/repos/rabernat/xrft/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rabernat/xrft/merges","archive_url":"https://api.github.com/repos/rabernat/xrft/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rabernat/xrft/downloads","issues_url":"https://api.github.com/repos/rabernat/xrft/issues{/number}","pulls_url":"https://api.github.com/repos/rabernat/xrft/pulls{/number}","milestones_url":"https://api.github.com/repos/rabernat/xrft/milestones{/number}","notifications_url":"https://api.github.com/repos/rabernat/xrft/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rabernat/xrft/labels{/name}","releases_url":"https://api.github.com/repos/rabernat/xrft/releases{/id}","deployments_url":"https://api.github.com/repos/rabernat/xrft/deployments","created_at":"2016-06-10T17:53:28Z","updated_at":"2017-03-08T12:19:33Z","pushed_at":"2017-05-18T21:16:08Z","git_url":"git://github.com/rabernat/xrft.git","ssh_url":"git@github.com:rabernat/xrft.git","clone_url":"https://github.com/rabernat/xrft.git","svn_url":"https://github.com/rabernat/xrft","homepage":null,"size":1524,"stargazers_count":4,"watchers_count":4,"language":"Jupyter Notebook","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rabernat/xrft/pulls/4"},"html":{"href":"https://github.com/rabernat/xrft/pull/4"},"issue":{"href":"https://api.github.com/repos/rabernat/xrft/issues/4"},"comments":{"href":"https://api.github.com/repos/rabernat/xrft/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/rabernat/xrft/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/rabernat/xrft/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rabernat/xrft/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/rabernat/xrft/statuses/dc9d230c97ee02b59dc1cecf84864f3fc21c278a"}}}}
{"actor":{"display_login":"rabernat"}}