{"comment":{"url":"https://api.github.com/repos/NoCheatPlus/NoCheatPlus/comments/23896088","html_url":"https://github.com/NoCheatPlus/NoCheatPlus/commit/7e43deaa28fb66a7b8273eed8d9dfa8956e97d62#commitcomment-23896088","id":23896088,"user":{"login":"omnivion","id":13528675,"avatar_url":"https://avatars3.githubusercontent.com/u/13528675?v=4","gravatar_id":"","url":"https://api.github.com/users/omnivion","html_url":"https://github.com/omnivion","followers_url":"https://api.github.com/users/omnivion/followers","following_url":"https://api.github.com/users/omnivion/following{/other_user}","gists_url":"https://api.github.com/users/omnivion/gists{/gist_id}","starred_url":"https://api.github.com/users/omnivion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omnivion/subscriptions","organizations_url":"https://api.github.com/users/omnivion/orgs","repos_url":"https://api.github.com/users/omnivion/repos","events_url":"https://api.github.com/users/omnivion/events{/privacy}","received_events_url":"https://api.github.com/users/omnivion/received_events","type":"User","site_admin":false},"position":null,"line":null,"path":null,"commit_id":"7e43deaa28fb66a7b8273eed8d9dfa8956e97d62","created_at":"2017-08-26T19:47:22Z","updated_at":"2017-08-26T19:47:22Z","body":"The only thing isOnline() does is it checks if the player's uuid is in the uuid map in net.minecraft.server.PlayerList.\r\n\r\nI'm basing this off of paperspigot 1.7, but it should still be the same as of 1.12 -- not much code has changed in these parts: PlayerInteractEvent is called in PlayerConnection on PacketPlayInBlockDig, PacketPlayInBlockPlace, and PacketPlayInArmAnimation. Most PacketPlayIn handlers (those included) call a boolean check, isFrozen. In the standard paper 1.7, this could be an issue, but later versions all do the following for isFrozen:\r\n\r\n- isDisconnected() - checks if the playerConnection in EntityPlayer is null and\r\n- playerconnection.isDisconnected() - whether or not processedDisconnect is true, OR if the player is NOT joining AND they are NOT connected\r\n- !isAlive() - checks if the dead flag is true, OR if the health is > 0.0F\r\n- isSleaping() - checks if the player is in a bed\r\n\r\nAs you can see, that's quite an extensive set of checks in place already -- this addition to NCP should therefore do nothing."}}
{"actor":{"display_login":"omnivion"}}