{"action":"created","comment":{"url":"https://api.github.com/repos/palantir/atlasdb/pulls/comments/138883483","pull_request_review_id":62737821,"id":138883483,"diff_hunk":"@@ -211,7 +211,8 @@ private static void attemptToCreateKeyspaceOnHost(InetSocketAddress host, Cassan\n         CassandraKeyValueServices.waitForSchemaVersions(\n                 client,\n                 \"(adding the initial empty keyspace)\",\n-                config.schemaMutationTimeoutMillis());\n+                config.schemaMutationTimeoutMillis(),\n+                true);","path":"atlasdb-cassandra/src/main/java/com/palantir/atlasdb/keyvalue/cassandra/CassandraVerifier.java","position":6,"original_position":6,"commit_id":"c8ce82064b401e5e042aa18ae6ebda5b1768bcc2","original_commit_id":"c8ce82064b401e5e042aa18ae6ebda5b1768bcc2","user":{"login":"fsamuel-bs","id":2558069,"avatar_url":"https://avatars0.githubusercontent.com/u/2558069?v=4","gravatar_id":"","url":"https://api.github.com/users/fsamuel-bs","html_url":"https://github.com/fsamuel-bs","followers_url":"https://api.github.com/users/fsamuel-bs/followers","following_url":"https://api.github.com/users/fsamuel-bs/following{/other_user}","gists_url":"https://api.github.com/users/fsamuel-bs/gists{/gist_id}","starred_url":"https://api.github.com/users/fsamuel-bs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fsamuel-bs/subscriptions","organizations_url":"https://api.github.com/users/fsamuel-bs/orgs","repos_url":"https://api.github.com/users/fsamuel-bs/repos","events_url":"https://api.github.com/users/fsamuel-bs/events{/privacy}","received_events_url":"https://api.github.com/users/fsamuel-bs/received_events","type":"User","site_admin":false},"body":"This is needed to allow our ETE tests to run with 2 C* nodes up on a 3 node C* cluster. Partially fixes https://github.com/palantir/atlasdb/issues/1705.","created_at":"2017-09-14T12:51:04Z","updated_at":"2017-09-14T12:51:04Z","html_url":"https://github.com/palantir/atlasdb/pull/2300#discussion_r138883483","pull_request_url":"https://api.github.com/repos/palantir/atlasdb/pulls/2300","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/palantir/atlasdb/pulls/comments/138883483"},"html":{"href":"https://github.com/palantir/atlasdb/pull/2300#discussion_r138883483"},"pull_request":{"href":"https://api.github.com/repos/palantir/atlasdb/pulls/2300"}}},"pull_request":{"url":"https://api.github.com/repos/palantir/atlasdb/pulls/2300","id":138890752,"html_url":"https://github.com/palantir/atlasdb/pull/2300","diff_url":"https://github.com/palantir/atlasdb/pull/2300.diff","patch_url":"https://github.com/palantir/atlasdb/pull/2300.patch","issue_url":"https://api.github.com/repos/palantir/atlasdb/issues/2300","number":2300,"state":"open","locked":false,"title":"[Startup Independence] Part 2: Failing Tests Fixes","user":{"login":"gmaretic","id":23168027,"avatar_url":"https://avatars0.githubusercontent.com/u/23168027?v=4","gravatar_id":"","url":"https://api.github.com/users/gmaretic","html_url":"https://github.com/gmaretic","followers_url":"https://api.github.com/users/gmaretic/followers","following_url":"https://api.github.com/users/gmaretic/following{/other_user}","gists_url":"https://api.github.com/users/gmaretic/gists{/gist_id}","starred_url":"https://api.github.com/users/gmaretic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmaretic/subscriptions","organizations_url":"https://api.github.com/users/gmaretic/orgs","repos_url":"https://api.github.com/users/gmaretic/repos","events_url":"https://api.github.com/users/gmaretic/events{/privacy}","received_events_url":"https://api.github.com/users/gmaretic/received_events","type":"User","site_admin":false},"body":"**Goals (and why)**:\r\nFixed missing initialization and removed the initialization check from the method that is supposed to be idempotent.\r\n\r\n**Implementation Description (bullets)**:\r\nPretty straightforward\r\n\r\n**Concerns (what feedback would you like?)**:\r\nThe table creation that happens in TransactionManagers.create is idempotent. However, the state can change, as we can actually delete some of the tables in between two calls to TransactionManagers.create. Therefore, a second call to TM.create has to attempt to recreate tables regardless of whether it has been initialized or not.\r\nNeed to check that the initialization check is correct in all other classes that use async initialization, but this is out of the scope of this fix. \r\n\r\n**Where should we start reviewing?**:\r\nWherever\r\n\r\n**Priority (whenever / two weeks / yesterday)**:\r\nSoonish\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/palantir/atlasdb/2300)\n<!-- Reviewable:end -->\n","created_at":"2017-09-01T13:27:56Z","updated_at":"2017-09-14T12:51:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"779f49971fb91bff390966eecf834cf787fec9d3","assignee":null,"assignees":[],"requested_reviewers":[{"login":"hsaraogi","id":20421615,"avatar_url":"https://avatars2.githubusercontent.com/u/20421615?v=4","gravatar_id":"","url":"https://api.github.com/users/hsaraogi","html_url":"https://github.com/hsaraogi","followers_url":"https://api.github.com/users/hsaraogi/followers","following_url":"https://api.github.com/users/hsaraogi/following{/other_user}","gists_url":"https://api.github.com/users/hsaraogi/gists{/gist_id}","starred_url":"https://api.github.com/users/hsaraogi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hsaraogi/subscriptions","organizations_url":"https://api.github.com/users/hsaraogi/orgs","repos_url":"https://api.github.com/users/hsaraogi/repos","events_url":"https://api.github.com/users/hsaraogi/events{/privacy}","received_events_url":"https://api.github.com/users/hsaraogi/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/palantir/atlasdb/pulls/2300/commits","review_comments_url":"https://api.github.com/repos/palantir/atlasdb/pulls/2300/comments","review_comment_url":"https://api.github.com/repos/palantir/atlasdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/palantir/atlasdb/issues/2300/comments","statuses_url":"https://api.github.com/repos/palantir/atlasdb/statuses/c8ce82064b401e5e042aa18ae6ebda5b1768bcc2","head":{"label":"palantir:fix/startup-independence-tests","ref":"fix/startup-independence-tests","sha":"c8ce82064b401e5e042aa18ae6ebda5b1768bcc2","user":{"login":"palantir","id":303157,"avatar_url":"https://avatars0.githubusercontent.com/u/303157?v=4","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"repo":{"id":36960637,"name":"atlasdb","full_name":"palantir/atlasdb","owner":{"login":"palantir","id":303157,"avatar_url":"https://avatars0.githubusercontent.com/u/303157?v=4","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/palantir/atlasdb","description":"Transactional Distributed Database Layer","fork":false,"url":"https://api.github.com/repos/palantir/atlasdb","forks_url":"https://api.github.com/repos/palantir/atlasdb/forks","keys_url":"https://api.github.com/repos/palantir/atlasdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/palantir/atlasdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/palantir/atlasdb/teams","hooks_url":"https://api.github.com/repos/palantir/atlasdb/hooks","issue_events_url":"https://api.github.com/repos/palantir/atlasdb/issues/events{/number}","events_url":"https://api.github.com/repos/palantir/atlasdb/events","assignees_url":"https://api.github.com/repos/palantir/atlasdb/assignees{/user}","branches_url":"https://api.github.com/repos/palantir/atlasdb/branches{/branch}","tags_url":"https://api.github.com/repos/palantir/atlasdb/tags","blobs_url":"https://api.github.com/repos/palantir/atlasdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/palantir/atlasdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/palantir/atlasdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/palantir/atlasdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/palantir/atlasdb/statuses/{sha}","languages_url":"https://api.github.com/repos/palantir/atlasdb/languages","stargazers_url":"https://api.github.com/repos/palantir/atlasdb/stargazers","contributors_url":"https://api.github.com/repos/palantir/atlasdb/contributors","subscribers_url":"https://api.github.com/repos/palantir/atlasdb/subscribers","subscription_url":"https://api.github.com/repos/palantir/atlasdb/subscription","commits_url":"https://api.github.com/repos/palantir/atlasdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/palantir/atlasdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/palantir/atlasdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/palantir/atlasdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/palantir/atlasdb/contents/{+path}","compare_url":"https://api.github.com/repos/palantir/atlasdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/palantir/atlasdb/merges","archive_url":"https://api.github.com/repos/palantir/atlasdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/palantir/atlasdb/downloads","issues_url":"https://api.github.com/repos/palantir/atlasdb/issues{/number}","pulls_url":"https://api.github.com/repos/palantir/atlasdb/pulls{/number}","milestones_url":"https://api.github.com/repos/palantir/atlasdb/milestones{/number}","notifications_url":"https://api.github.com/repos/palantir/atlasdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/palantir/atlasdb/labels{/name}","releases_url":"https://api.github.com/repos/palantir/atlasdb/releases{/id}","deployments_url":"https://api.github.com/repos/palantir/atlasdb/deployments","created_at":"2015-06-05T23:42:44Z","updated_at":"2017-09-14T05:15:01Z","pushed_at":"2017-09-14T12:46:08Z","git_url":"git://github.com/palantir/atlasdb.git","ssh_url":"git@github.com:palantir/atlasdb.git","clone_url":"https://github.com/palantir/atlasdb.git","svn_url":"https://github.com/palantir/atlasdb","homepage":"http://palantir.github.io/atlasdb/","size":45468,"stargazers_count":506,"watchers_count":506,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":89,"mirror_url":null,"open_issues_count":206,"forks":89,"open_issues":206,"watchers":506,"default_branch":"develop"}},"base":{"label":"palantir:feature/startup-ordering","ref":"feature/startup-ordering","sha":"236ec0a094b32ba40da55df2296c4d884f64d531","user":{"login":"palantir","id":303157,"avatar_url":"https://avatars0.githubusercontent.com/u/303157?v=4","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"repo":{"id":36960637,"name":"atlasdb","full_name":"palantir/atlasdb","owner":{"login":"palantir","id":303157,"avatar_url":"https://avatars0.githubusercontent.com/u/303157?v=4","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/palantir/atlasdb","description":"Transactional Distributed Database Layer","fork":false,"url":"https://api.github.com/repos/palantir/atlasdb","forks_url":"https://api.github.com/repos/palantir/atlasdb/forks","keys_url":"https://api.github.com/repos/palantir/atlasdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/palantir/atlasdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/palantir/atlasdb/teams","hooks_url":"https://api.github.com/repos/palantir/atlasdb/hooks","issue_events_url":"https://api.github.com/repos/palantir/atlasdb/issues/events{/number}","events_url":"https://api.github.com/repos/palantir/atlasdb/events","assignees_url":"https://api.github.com/repos/palantir/atlasdb/assignees{/user}","branches_url":"https://api.github.com/repos/palantir/atlasdb/branches{/branch}","tags_url":"https://api.github.com/repos/palantir/atlasdb/tags","blobs_url":"https://api.github.com/repos/palantir/atlasdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/palantir/atlasdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/palantir/atlasdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/palantir/atlasdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/palantir/atlasdb/statuses/{sha}","languages_url":"https://api.github.com/repos/palantir/atlasdb/languages","stargazers_url":"https://api.github.com/repos/palantir/atlasdb/stargazers","contributors_url":"https://api.github.com/repos/palantir/atlasdb/contributors","subscribers_url":"https://api.github.com/repos/palantir/atlasdb/subscribers","subscription_url":"https://api.github.com/repos/palantir/atlasdb/subscription","commits_url":"https://api.github.com/repos/palantir/atlasdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/palantir/atlasdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/palantir/atlasdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/palantir/atlasdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/palantir/atlasdb/contents/{+path}","compare_url":"https://api.github.com/repos/palantir/atlasdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/palantir/atlasdb/merges","archive_url":"https://api.github.com/repos/palantir/atlasdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/palantir/atlasdb/downloads","issues_url":"https://api.github.com/repos/palantir/atlasdb/issues{/number}","pulls_url":"https://api.github.com/repos/palantir/atlasdb/pulls{/number}","milestones_url":"https://api.github.com/repos/palantir/atlasdb/milestones{/number}","notifications_url":"https://api.github.com/repos/palantir/atlasdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/palantir/atlasdb/labels{/name}","releases_url":"https://api.github.com/repos/palantir/atlasdb/releases{/id}","deployments_url":"https://api.github.com/repos/palantir/atlasdb/deployments","created_at":"2015-06-05T23:42:44Z","updated_at":"2017-09-14T05:15:01Z","pushed_at":"2017-09-14T12:46:08Z","git_url":"git://github.com/palantir/atlasdb.git","ssh_url":"git@github.com:palantir/atlasdb.git","clone_url":"https://github.com/palantir/atlasdb.git","svn_url":"https://github.com/palantir/atlasdb","homepage":"http://palantir.github.io/atlasdb/","size":45468,"stargazers_count":506,"watchers_count":506,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":89,"mirror_url":null,"open_issues_count":206,"forks":89,"open_issues":206,"watchers":506,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/palantir/atlasdb/pulls/2300"},"html":{"href":"https://github.com/palantir/atlasdb/pull/2300"},"issue":{"href":"https://api.github.com/repos/palantir/atlasdb/issues/2300"},"comments":{"href":"https://api.github.com/repos/palantir/atlasdb/issues/2300/comments"},"review_comments":{"href":"https://api.github.com/repos/palantir/atlasdb/pulls/2300/comments"},"review_comment":{"href":"https://api.github.com/repos/palantir/atlasdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/palantir/atlasdb/pulls/2300/commits"},"statuses":{"href":"https://api.github.com/repos/palantir/atlasdb/statuses/c8ce82064b401e5e042aa18ae6ebda5b1768bcc2"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"fsamuel-bs"}}