{"action":"created","comment":{"url":"https://api.github.com/repos/sindresorhus/refined-github/pulls/comments/116378800","pull_request_review_id":37998085,"id":116378800,"diff_hunk":"@@ -281,22 +281,23 @@ function addDiffViewWithoutWhitespaceOption(type) {\n \tif (urlParams.get('w') === '1') {\n \t\toptionIsSet = true;\n \t\turlParams.delete('w');\n-\t\toptionElementObject.addClass('selected');\n \t} else {\n \t\turlParams.set('w', 1);\n \t}\n \n-\tconst optionElementContent = `${optionIsSet ? svgIcon : ''} Ignore whitespace`;\n+\tconst optionElementContent = `${optionIsSet ? svgIcon + ' ' : ''}No Whitespace`;\n \tconst optionHref = `${window.location.origin + window.location.pathname}?${urlParams.toString() + urlHash}`;\n \n-\toptionElementObject.html(optionElementContent).attr('href', optionHref).attr('data-hotkey', 'd w').attr('class', 'refined-github-toggle-whitespace');\n+\toptionElementObject.html(optionElementContent).attr('href', optionHref).attr('data-hotkey', 'd w').attr('class', 'refined-github-toggle-whitespace').attr('title', `Click here to turn whitespace in diffs ${optionIsSet ? 'on' : 'off'}`);","path":"extension/content.js","position":25,"original_position":25,"commit_id":"6ac7a068ff9fa1439b30f9953bc73c2ae0342ef6","original_commit_id":"6ac7a068ff9fa1439b30f9953bc73c2ae0342ef6","user":{"login":"jgierer12","id":4331946,"avatar_url":"https://avatars3.githubusercontent.com/u/4331946?v=3","gravatar_id":"","url":"https://api.github.com/users/jgierer12","html_url":"https://github.com/jgierer12","followers_url":"https://api.github.com/users/jgierer12/followers","following_url":"https://api.github.com/users/jgierer12/following{/other_user}","gists_url":"https://api.github.com/users/jgierer12/gists{/gist_id}","starred_url":"https://api.github.com/users/jgierer12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgierer12/subscriptions","organizations_url":"https://api.github.com/users/jgierer12/orgs","repos_url":"https://api.github.com/users/jgierer12/repos","events_url":"https://api.github.com/users/jgierer12/events{/privacy}","received_events_url":"https://api.github.com/users/jgierer12/received_events","type":"User","site_admin":false},"body":"I'd prefer to build the element using a template string (e.g. https://github.com/sindresorhus/refined-github/blob/master/extension/content.js#L328-L332)","created_at":"2017-05-14T11:45:19Z","updated_at":"2017-05-14T12:03:45Z","html_url":"https://github.com/sindresorhus/refined-github/pull/425#discussion_r116378800","pull_request_url":"https://api.github.com/repos/sindresorhus/refined-github/pulls/425","_links":{"self":{"href":"https://api.github.com/repos/sindresorhus/refined-github/pulls/comments/116378800"},"html":{"href":"https://github.com/sindresorhus/refined-github/pull/425#discussion_r116378800"},"pull_request":{"href":"https://api.github.com/repos/sindresorhus/refined-github/pulls/425"}}},"pull_request":{"url":"https://api.github.com/repos/sindresorhus/refined-github/pulls/425","id":120452199,"html_url":"https://github.com/sindresorhus/refined-github/pull/425","diff_url":"https://github.com/sindresorhus/refined-github/pull/425.diff","patch_url":"https://github.com/sindresorhus/refined-github/pull/425.patch","issue_url":"https://api.github.com/repos/sindresorhus/refined-github/issues/425","number":425,"state":"open","locked":false,"title":"Fix whitespace diff option button.","user":{"login":"anselmh","id":399345,"avatar_url":"https://avatars0.githubusercontent.com/u/399345?v=3","gravatar_id":"","url":"https://api.github.com/users/anselmh","html_url":"https://github.com/anselmh","followers_url":"https://api.github.com/users/anselmh/followers","following_url":"https://api.github.com/users/anselmh/following{/other_user}","gists_url":"https://api.github.com/users/anselmh/gists{/gist_id}","starred_url":"https://api.github.com/users/anselmh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anselmh/subscriptions","organizations_url":"https://api.github.com/users/anselmh/orgs","repos_url":"https://api.github.com/users/anselmh/repos","events_url":"https://api.github.com/users/anselmh/events{/privacy}","received_events_url":"https://api.github.com/users/anselmh/received_events","type":"User","site_admin":false},"body":"This fixes #322.\r\n\r\nTL;DR: Github changed the markup from a select optionbox\r\nto a tablist. This change re-implements the whitespace\r\ndiff toggle option as third tab-item on diff view pages.\r\n\r\n## Screenshots of new layout:\r\n![screen shot 2017-05-13 at 17 20 39](https://cloud.githubusercontent.com/assets/399345/26026728/6562ee1a-37f0-11e7-9605-59f210e1a5ad.png)\r\n![screen shot 2017-05-13 at 17 20 47](https://cloud.githubusercontent.com/assets/399345/26026729/6565b30c-37f0-11e7-8e76-8e13801fbe53.png)\r\n","created_at":"2017-05-13T15:25:34Z","updated_at":"2017-05-14T12:03:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b057457b9bc20cdd9378564de7733d1bf4b99c84","assignee":null,"assignees":[],"requested_reviewers":[{"login":"hkdobrev","id":506129,"avatar_url":"https://avatars1.githubusercontent.com/u/506129?v=3","gravatar_id":"","url":"https://api.github.com/users/hkdobrev","html_url":"https://github.com/hkdobrev","followers_url":"https://api.github.com/users/hkdobrev/followers","following_url":"https://api.github.com/users/hkdobrev/following{/other_user}","gists_url":"https://api.github.com/users/hkdobrev/gists{/gist_id}","starred_url":"https://api.github.com/users/hkdobrev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hkdobrev/subscriptions","organizations_url":"https://api.github.com/users/hkdobrev/orgs","repos_url":"https://api.github.com/users/hkdobrev/repos","events_url":"https://api.github.com/users/hkdobrev/events{/privacy}","received_events_url":"https://api.github.com/users/hkdobrev/received_events","type":"User","site_admin":false},{"login":"sindresorhus","id":170270,"avatar_url":"https://avatars2.githubusercontent.com/u/170270?v=3","gravatar_id":"","url":"https://api.github.com/users/sindresorhus","html_url":"https://github.com/sindresorhus","followers_url":"https://api.github.com/users/sindresorhus/followers","following_url":"https://api.github.com/users/sindresorhus/following{/other_user}","gists_url":"https://api.github.com/users/sindresorhus/gists{/gist_id}","starred_url":"https://api.github.com/users/sindresorhus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sindresorhus/subscriptions","organizations_url":"https://api.github.com/users/sindresorhus/orgs","repos_url":"https://api.github.com/users/sindresorhus/repos","events_url":"https://api.github.com/users/sindresorhus/events{/privacy}","received_events_url":"https://api.github.com/users/sindresorhus/received_events","type":"User","site_admin":false},{"login":"paulmolluzzo","id":737065,"avatar_url":"https://avatars0.githubusercontent.com/u/737065?v=3","gravatar_id":"","url":"https://api.github.com/users/paulmolluzzo","html_url":"https://github.com/paulmolluzzo","followers_url":"https://api.github.com/users/paulmolluzzo/followers","following_url":"https://api.github.com/users/paulmolluzzo/following{/other_user}","gists_url":"https://api.github.com/users/paulmolluzzo/gists{/gist_id}","starred_url":"https://api.github.com/users/paulmolluzzo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulmolluzzo/subscriptions","organizations_url":"https://api.github.com/users/paulmolluzzo/orgs","repos_url":"https://api.github.com/users/paulmolluzzo/repos","events_url":"https://api.github.com/users/paulmolluzzo/events{/privacy}","received_events_url":"https://api.github.com/users/paulmolluzzo/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/sindresorhus/refined-github/pulls/425/commits","review_comments_url":"https://api.github.com/repos/sindresorhus/refined-github/pulls/425/comments","review_comment_url":"https://api.github.com/repos/sindresorhus/refined-github/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sindresorhus/refined-github/issues/425/comments","statuses_url":"https://api.github.com/repos/sindresorhus/refined-github/statuses/6ac7a068ff9fa1439b30f9953bc73c2ae0342ef6","head":{"label":"anselmh:bugfix/whitespace-option-toggle-button-fix","ref":"bugfix/whitespace-option-toggle-button-fix","sha":"6ac7a068ff9fa1439b30f9953bc73c2ae0342ef6","user":{"login":"anselmh","id":399345,"avatar_url":"https://avatars0.githubusercontent.com/u/399345?v=3","gravatar_id":"","url":"https://api.github.com/users/anselmh","html_url":"https://github.com/anselmh","followers_url":"https://api.github.com/users/anselmh/followers","following_url":"https://api.github.com/users/anselmh/following{/other_user}","gists_url":"https://api.github.com/users/anselmh/gists{/gist_id}","starred_url":"https://api.github.com/users/anselmh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anselmh/subscriptions","organizations_url":"https://api.github.com/users/anselmh/orgs","repos_url":"https://api.github.com/users/anselmh/repos","events_url":"https://api.github.com/users/anselmh/events{/privacy}","received_events_url":"https://api.github.com/users/anselmh/received_events","type":"User","site_admin":false},"repo":{"id":91181032,"name":"refined-github","full_name":"anselmh/refined-github","owner":{"login":"anselmh","id":399345,"avatar_url":"https://avatars0.githubusercontent.com/u/399345?v=3","gravatar_id":"","url":"https://api.github.com/users/anselmh","html_url":"https://github.com/anselmh","followers_url":"https://api.github.com/users/anselmh/followers","following_url":"https://api.github.com/users/anselmh/following{/other_user}","gists_url":"https://api.github.com/users/anselmh/gists{/gist_id}","starred_url":"https://api.github.com/users/anselmh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anselmh/subscriptions","organizations_url":"https://api.github.com/users/anselmh/orgs","repos_url":"https://api.github.com/users/anselmh/repos","events_url":"https://api.github.com/users/anselmh/events{/privacy}","received_events_url":"https://api.github.com/users/anselmh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/anselmh/refined-github","description":"Chrome extension that simplifies the GitHub interface and adds useful features","fork":true,"url":"https://api.github.com/repos/anselmh/refined-github","forks_url":"https://api.github.com/repos/anselmh/refined-github/forks","keys_url":"https://api.github.com/repos/anselmh/refined-github/keys{/key_id}","collaborators_url":"https://api.github.com/repos/anselmh/refined-github/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/anselmh/refined-github/teams","hooks_url":"https://api.github.com/repos/anselmh/refined-github/hooks","issue_events_url":"https://api.github.com/repos/anselmh/refined-github/issues/events{/number}","events_url":"https://api.github.com/repos/anselmh/refined-github/events","assignees_url":"https://api.github.com/repos/anselmh/refined-github/assignees{/user}","branches_url":"https://api.github.com/repos/anselmh/refined-github/branches{/branch}","tags_url":"https://api.github.com/repos/anselmh/refined-github/tags","blobs_url":"https://api.github.com/repos/anselmh/refined-github/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/anselmh/refined-github/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/anselmh/refined-github/git/refs{/sha}","trees_url":"https://api.github.com/repos/anselmh/refined-github/git/trees{/sha}","statuses_url":"https://api.github.com/repos/anselmh/refined-github/statuses/{sha}","languages_url":"https://api.github.com/repos/anselmh/refined-github/languages","stargazers_url":"https://api.github.com/repos/anselmh/refined-github/stargazers","contributors_url":"https://api.github.com/repos/anselmh/refined-github/contributors","subscribers_url":"https://api.github.com/repos/anselmh/refined-github/subscribers","subscription_url":"https://api.github.com/repos/anselmh/refined-github/subscription","commits_url":"https://api.github.com/repos/anselmh/refined-github/commits{/sha}","git_commits_url":"https://api.github.com/repos/anselmh/refined-github/git/commits{/sha}","comments_url":"https://api.github.com/repos/anselmh/refined-github/comments{/number}","issue_comment_url":"https://api.github.com/repos/anselmh/refined-github/issues/comments{/number}","contents_url":"https://api.github.com/repos/anselmh/refined-github/contents/{+path}","compare_url":"https://api.github.com/repos/anselmh/refined-github/compare/{base}...{head}","merges_url":"https://api.github.com/repos/anselmh/refined-github/merges","archive_url":"https://api.github.com/repos/anselmh/refined-github/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/anselmh/refined-github/downloads","issues_url":"https://api.github.com/repos/anselmh/refined-github/issues{/number}","pulls_url":"https://api.github.com/repos/anselmh/refined-github/pulls{/number}","milestones_url":"https://api.github.com/repos/anselmh/refined-github/milestones{/number}","notifications_url":"https://api.github.com/repos/anselmh/refined-github/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/anselmh/refined-github/labels{/name}","releases_url":"https://api.github.com/repos/anselmh/refined-github/releases{/id}","deployments_url":"https://api.github.com/repos/anselmh/refined-github/deployments","created_at":"2017-05-13T14:47:00Z","updated_at":"2017-05-13T14:47:01Z","pushed_at":"2017-05-14T09:14:55Z","git_url":"git://github.com/anselmh/refined-github.git","ssh_url":"git@github.com:anselmh/refined-github.git","clone_url":"https://github.com/anselmh/refined-github.git","svn_url":"https://github.com/anselmh/refined-github","homepage":"https://chrome.google.com/webstore/detail/refined-github/hlepfoohegkhhmjieoechaddaejaokhf","size":1662,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sindresorhus:master","ref":"master","sha":"ba65f8f844edfd21e92fc4855e9023512e3eea8b","user":{"login":"sindresorhus","id":170270,"avatar_url":"https://avatars2.githubusercontent.com/u/170270?v=3","gravatar_id":"","url":"https://api.github.com/users/sindresorhus","html_url":"https://github.com/sindresorhus","followers_url":"https://api.github.com/users/sindresorhus/followers","following_url":"https://api.github.com/users/sindresorhus/following{/other_user}","gists_url":"https://api.github.com/users/sindresorhus/gists{/gist_id}","starred_url":"https://api.github.com/users/sindresorhus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sindresorhus/subscriptions","organizations_url":"https://api.github.com/users/sindresorhus/orgs","repos_url":"https://api.github.com/users/sindresorhus/repos","events_url":"https://api.github.com/users/sindresorhus/events{/privacy}","received_events_url":"https://api.github.com/users/sindresorhus/received_events","type":"User","site_admin":false},"repo":{"id":51769689,"name":"refined-github","full_name":"sindresorhus/refined-github","owner":{"login":"sindresorhus","id":170270,"avatar_url":"https://avatars2.githubusercontent.com/u/170270?v=3","gravatar_id":"","url":"https://api.github.com/users/sindresorhus","html_url":"https://github.com/sindresorhus","followers_url":"https://api.github.com/users/sindresorhus/followers","following_url":"https://api.github.com/users/sindresorhus/following{/other_user}","gists_url":"https://api.github.com/users/sindresorhus/gists{/gist_id}","starred_url":"https://api.github.com/users/sindresorhus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sindresorhus/subscriptions","organizations_url":"https://api.github.com/users/sindresorhus/orgs","repos_url":"https://api.github.com/users/sindresorhus/repos","events_url":"https://api.github.com/users/sindresorhus/events{/privacy}","received_events_url":"https://api.github.com/users/sindresorhus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sindresorhus/refined-github","description":"Chrome extension that simplifies the GitHub interface and adds useful features","fork":false,"url":"https://api.github.com/repos/sindresorhus/refined-github","forks_url":"https://api.github.com/repos/sindresorhus/refined-github/forks","keys_url":"https://api.github.com/repos/sindresorhus/refined-github/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sindresorhus/refined-github/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sindresorhus/refined-github/teams","hooks_url":"https://api.github.com/repos/sindresorhus/refined-github/hooks","issue_events_url":"https://api.github.com/repos/sindresorhus/refined-github/issues/events{/number}","events_url":"https://api.github.com/repos/sindresorhus/refined-github/events","assignees_url":"https://api.github.com/repos/sindresorhus/refined-github/assignees{/user}","branches_url":"https://api.github.com/repos/sindresorhus/refined-github/branches{/branch}","tags_url":"https://api.github.com/repos/sindresorhus/refined-github/tags","blobs_url":"https://api.github.com/repos/sindresorhus/refined-github/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sindresorhus/refined-github/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sindresorhus/refined-github/git/refs{/sha}","trees_url":"https://api.github.com/repos/sindresorhus/refined-github/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sindresorhus/refined-github/statuses/{sha}","languages_url":"https://api.github.com/repos/sindresorhus/refined-github/languages","stargazers_url":"https://api.github.com/repos/sindresorhus/refined-github/stargazers","contributors_url":"https://api.github.com/repos/sindresorhus/refined-github/contributors","subscribers_url":"https://api.github.com/repos/sindresorhus/refined-github/subscribers","subscription_url":"https://api.github.com/repos/sindresorhus/refined-github/subscription","commits_url":"https://api.github.com/repos/sindresorhus/refined-github/commits{/sha}","git_commits_url":"https://api.github.com/repos/sindresorhus/refined-github/git/commits{/sha}","comments_url":"https://api.github.com/repos/sindresorhus/refined-github/comments{/number}","issue_comment_url":"https://api.github.com/repos/sindresorhus/refined-github/issues/comments{/number}","contents_url":"https://api.github.com/repos/sindresorhus/refined-github/contents/{+path}","compare_url":"https://api.github.com/repos/sindresorhus/refined-github/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sindresorhus/refined-github/merges","archive_url":"https://api.github.com/repos/sindresorhus/refined-github/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sindresorhus/refined-github/downloads","issues_url":"https://api.github.com/repos/sindresorhus/refined-github/issues{/number}","pulls_url":"https://api.github.com/repos/sindresorhus/refined-github/pulls{/number}","milestones_url":"https://api.github.com/repos/sindresorhus/refined-github/milestones{/number}","notifications_url":"https://api.github.com/repos/sindresorhus/refined-github/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sindresorhus/refined-github/labels{/name}","releases_url":"https://api.github.com/repos/sindresorhus/refined-github/releases{/id}","deployments_url":"https://api.github.com/repos/sindresorhus/refined-github/deployments","created_at":"2016-02-15T16:45:02Z","updated_at":"2017-05-13T19:50:20Z","pushed_at":"2017-05-14T10:07:49Z","git_url":"git://github.com/sindresorhus/refined-github.git","ssh_url":"git@github.com:sindresorhus/refined-github.git","clone_url":"https://github.com/sindresorhus/refined-github.git","svn_url":"https://github.com/sindresorhus/refined-github","homepage":"https://chrome.google.com/webstore/detail/refined-github/hlepfoohegkhhmjieoechaddaejaokhf","size":1653,"stargazers_count":1354,"watchers_count":1354,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":129,"mirror_url":null,"open_issues_count":61,"forks":129,"open_issues":61,"watchers":1354,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sindresorhus/refined-github/pulls/425"},"html":{"href":"https://github.com/sindresorhus/refined-github/pull/425"},"issue":{"href":"https://api.github.com/repos/sindresorhus/refined-github/issues/425"},"comments":{"href":"https://api.github.com/repos/sindresorhus/refined-github/issues/425/comments"},"review_comments":{"href":"https://api.github.com/repos/sindresorhus/refined-github/pulls/425/comments"},"review_comment":{"href":"https://api.github.com/repos/sindresorhus/refined-github/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sindresorhus/refined-github/pulls/425/commits"},"statuses":{"href":"https://api.github.com/repos/sindresorhus/refined-github/statuses/6ac7a068ff9fa1439b30f9953bc73c2ae0342ef6"}}}}
{"actor":{"display_login":"jgierer12"}}