{"action":"closed","number":3,"pull_request":{"url":"https://api.github.com/repos/andersnm/ExcelNumberFormat/pulls/3","id":149328622,"html_url":"https://github.com/andersnm/ExcelNumberFormat/pull/3","diff_url":"https://github.com/andersnm/ExcelNumberFormat/pull/3.diff","patch_url":"https://github.com/andersnm/ExcelNumberFormat/pull/3.patch","issue_url":"https://api.github.com/repos/andersnm/ExcelNumberFormat/issues/3","number":3,"state":"closed","locked":false,"title":"For empty format strings, default to built-in .NET formatter","user":{"login":"igitur","id":145854,"avatar_url":"https://avatars1.githubusercontent.com/u/145854?v=4","gravatar_id":"","url":"https://api.github.com/users/igitur","html_url":"https://github.com/igitur","followers_url":"https://api.github.com/users/igitur/followers","following_url":"https://api.github.com/users/igitur/following{/other_user}","gists_url":"https://api.github.com/users/igitur/gists{/gist_id}","starred_url":"https://api.github.com/users/igitur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igitur/subscriptions","organizations_url":"https://api.github.com/users/igitur/orgs","repos_url":"https://api.github.com/users/igitur/repos","events_url":"https://api.github.com/users/igitur/events{/privacy}","received_events_url":"https://api.github.com/users/igitur/received_events","type":"User","site_admin":false},"body":"Currently, if you pass an empty format string, an exception is raised. I would expect that some default format would be used. I don't think this should necessarily be what Excel would use as a default. I think the build-in .NET `ToString()` method is just fine, but you'll have to say whether this fits in with what you expect.\r\n\r\nSo this PR:\r\n- returns default .NET format of value\r\n- reworks the logic a bit from multiple `if` statements to a `switch` statement.","created_at":"2017-10-28T10:10:37Z","updated_at":"2017-10-31T12:24:45Z","closed_at":"2017-10-31T12:24:45Z","merged_at":"2017-10-31T12:24:45Z","merge_commit_sha":"89fe9f833462348ae1af1c26c0e1847b18c188b7","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/andersnm/ExcelNumberFormat/pulls/3/commits","review_comments_url":"https://api.github.com/repos/andersnm/ExcelNumberFormat/pulls/3/comments","review_comment_url":"https://api.github.com/repos/andersnm/ExcelNumberFormat/pulls/comments{/number}","comments_url":"https://api.github.com/repos/andersnm/ExcelNumberFormat/issues/3/comments","statuses_url":"https://api.github.com/repos/andersnm/ExcelNumberFormat/statuses/f06fc725b451c4edb2f9de3050bd9d3bc41391f6","head":{"label":"ClosedXML:empty-format-string","ref":"empty-format-string","sha":"f06fc725b451c4edb2f9de3050bd9d3bc41391f6","user":{"login":"ClosedXML","id":21276615,"avatar_url":"https://avatars3.githubusercontent.com/u/21276615?v=4","gravatar_id":"","url":"https://api.github.com/users/ClosedXML","html_url":"https://github.com/ClosedXML","followers_url":"https://api.github.com/users/ClosedXML/followers","following_url":"https://api.github.com/users/ClosedXML/following{/other_user}","gists_url":"https://api.github.com/users/ClosedXML/gists{/gist_id}","starred_url":"https://api.github.com/users/ClosedXML/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ClosedXML/subscriptions","organizations_url":"https://api.github.com/users/ClosedXML/orgs","repos_url":"https://api.github.com/users/ClosedXML/repos","events_url":"https://api.github.com/users/ClosedXML/events{/privacy}","received_events_url":"https://api.github.com/users/ClosedXML/received_events","type":"Organization","site_admin":false},"repo":{"id":108635406,"name":"ExcelNumberFormat","full_name":"ClosedXML/ExcelNumberFormat","owner":{"login":"ClosedXML","id":21276615,"avatar_url":"https://avatars3.githubusercontent.com/u/21276615?v=4","gravatar_id":"","url":"https://api.github.com/users/ClosedXML","html_url":"https://github.com/ClosedXML","followers_url":"https://api.github.com/users/ClosedXML/followers","following_url":"https://api.github.com/users/ClosedXML/following{/other_user}","gists_url":"https://api.github.com/users/ClosedXML/gists{/gist_id}","starred_url":"https://api.github.com/users/ClosedXML/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ClosedXML/subscriptions","organizations_url":"https://api.github.com/users/ClosedXML/orgs","repos_url":"https://api.github.com/users/ClosedXML/repos","events_url":"https://api.github.com/users/ClosedXML/events{/privacy}","received_events_url":"https://api.github.com/users/ClosedXML/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ClosedXML/ExcelNumberFormat","description":"Parse and render Excel number format strings","fork":true,"url":"https://api.github.com/repos/ClosedXML/ExcelNumberFormat","forks_url":"https://api.github.com/repos/ClosedXML/ExcelNumberFormat/forks","keys_url":"https://api.github.com/repos/ClosedXML/ExcelNumberFormat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ClosedXML/ExcelNumberFormat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ClosedXML/ExcelNumberFormat/teams","hooks_url":"https://api.github.com/repos/ClosedXML/ExcelNumberFormat/hooks","issue_events_url":"https://api.github.com/repos/ClosedXML/ExcelNumberFormat/issues/events{/number}","events_url":"https://api.github.com/repos/ClosedXML/ExcelNumberFormat/events","assignees_url":"https://api.github.com/repos/ClosedXML/ExcelNumberFormat/assignees{/user}","branches_url":"https://api.github.com/repos/ClosedXML/ExcelNumberFormat/branches{/branch}","tags_url":"https://api.github.com/repos/ClosedXML/ExcelNumberFormat/tags","blobs_url":"https://api.github.com/repos/ClosedXML/ExcelNumberFormat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ClosedXML/ExcelNumberFormat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ClosedXML/ExcelNumberFormat/git/refs{/sha}","trees_url":"https://api.github.com/repos/ClosedXML/ExcelNumberFormat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ClosedXML/ExcelNumberFormat/statuses/{sha}","languages_url":"https://api.github.com/repos/ClosedXML/ExcelNumberFormat/languages","stargazers_url":"https://api.github.com/repos/ClosedXML/ExcelNumberFormat/stargazers","contributors_url":"https://api.github.com/repos/ClosedXML/ExcelNumberFormat/contributors","subscribers_url":"https://api.github.com/repos/ClosedXML/ExcelNumberFormat/subscribers","subscription_url":"https://api.github.com/repos/ClosedXML/ExcelNumberFormat/subscription","commits_url":"https://api.github.com/repos/ClosedXML/ExcelNumberFormat/commits{/sha}","git_commits_url":"https://api.github.com/repos/ClosedXML/ExcelNumberFormat/git/commits{/sha}","comments_url":"https://api.github.com/repos/ClosedXML/ExcelNumberFormat/comments{/number}","issue_comment_url":"https://api.github.com/repos/ClosedXML/ExcelNumberFormat/issues/comments{/number}","contents_url":"https://api.github.com/repos/ClosedXML/ExcelNumberFormat/contents/{+path}","compare_url":"https://api.github.com/repos/ClosedXML/ExcelNumberFormat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ClosedXML/ExcelNumberFormat/merges","archive_url":"https://api.github.com/repos/ClosedXML/ExcelNumberFormat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ClosedXML/ExcelNumberFormat/downloads","issues_url":"https://api.github.com/repos/ClosedXML/ExcelNumberFormat/issues{/number}","pulls_url":"https://api.github.com/repos/ClosedXML/ExcelNumberFormat/pulls{/number}","milestones_url":"https://api.github.com/repos/ClosedXML/ExcelNumberFormat/milestones{/number}","notifications_url":"https://api.github.com/repos/ClosedXML/ExcelNumberFormat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ClosedXML/ExcelNumberFormat/labels{/name}","releases_url":"https://api.github.com/repos/ClosedXML/ExcelNumberFormat/releases{/id}","deployments_url":"https://api.github.com/repos/ClosedXML/ExcelNumberFormat/deployments","created_at":"2017-10-28T09:12:19Z","updated_at":"2017-10-28T09:12:21Z","pushed_at":"2017-10-31T12:05:36Z","git_url":"git://github.com/ClosedXML/ExcelNumberFormat.git","ssh_url":"git@github.com:ClosedXML/ExcelNumberFormat.git","clone_url":"https://github.com/ClosedXML/ExcelNumberFormat.git","svn_url":"https://github.com/ClosedXML/ExcelNumberFormat","homepage":"","size":36,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"andersnm:master","ref":"master","sha":"fe71baf44d9c3e4955df2a1cca62845b03b821dc","user":{"login":"andersnm","id":16575282,"avatar_url":"https://avatars1.githubusercontent.com/u/16575282?v=4","gravatar_id":"","url":"https://api.github.com/users/andersnm","html_url":"https://github.com/andersnm","followers_url":"https://api.github.com/users/andersnm/followers","following_url":"https://api.github.com/users/andersnm/following{/other_user}","gists_url":"https://api.github.com/users/andersnm/gists{/gist_id}","starred_url":"https://api.github.com/users/andersnm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andersnm/subscriptions","organizations_url":"https://api.github.com/users/andersnm/orgs","repos_url":"https://api.github.com/users/andersnm/repos","events_url":"https://api.github.com/users/andersnm/events{/privacy}","received_events_url":"https://api.github.com/users/andersnm/received_events","type":"User","site_admin":false},"repo":{"id":96682073,"name":"ExcelNumberFormat","full_name":"andersnm/ExcelNumberFormat","owner":{"login":"andersnm","id":16575282,"avatar_url":"https://avatars1.githubusercontent.com/u/16575282?v=4","gravatar_id":"","url":"https://api.github.com/users/andersnm","html_url":"https://github.com/andersnm","followers_url":"https://api.github.com/users/andersnm/followers","following_url":"https://api.github.com/users/andersnm/following{/other_user}","gists_url":"https://api.github.com/users/andersnm/gists{/gist_id}","starred_url":"https://api.github.com/users/andersnm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andersnm/subscriptions","organizations_url":"https://api.github.com/users/andersnm/orgs","repos_url":"https://api.github.com/users/andersnm/repos","events_url":"https://api.github.com/users/andersnm/events{/privacy}","received_events_url":"https://api.github.com/users/andersnm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andersnm/ExcelNumberFormat","description":"Parse and render Excel number format strings","fork":false,"url":"https://api.github.com/repos/andersnm/ExcelNumberFormat","forks_url":"https://api.github.com/repos/andersnm/ExcelNumberFormat/forks","keys_url":"https://api.github.com/repos/andersnm/ExcelNumberFormat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andersnm/ExcelNumberFormat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andersnm/ExcelNumberFormat/teams","hooks_url":"https://api.github.com/repos/andersnm/ExcelNumberFormat/hooks","issue_events_url":"https://api.github.com/repos/andersnm/ExcelNumberFormat/issues/events{/number}","events_url":"https://api.github.com/repos/andersnm/ExcelNumberFormat/events","assignees_url":"https://api.github.com/repos/andersnm/ExcelNumberFormat/assignees{/user}","branches_url":"https://api.github.com/repos/andersnm/ExcelNumberFormat/branches{/branch}","tags_url":"https://api.github.com/repos/andersnm/ExcelNumberFormat/tags","blobs_url":"https://api.github.com/repos/andersnm/ExcelNumberFormat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andersnm/ExcelNumberFormat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andersnm/ExcelNumberFormat/git/refs{/sha}","trees_url":"https://api.github.com/repos/andersnm/ExcelNumberFormat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andersnm/ExcelNumberFormat/statuses/{sha}","languages_url":"https://api.github.com/repos/andersnm/ExcelNumberFormat/languages","stargazers_url":"https://api.github.com/repos/andersnm/ExcelNumberFormat/stargazers","contributors_url":"https://api.github.com/repos/andersnm/ExcelNumberFormat/contributors","subscribers_url":"https://api.github.com/repos/andersnm/ExcelNumberFormat/subscribers","subscription_url":"https://api.github.com/repos/andersnm/ExcelNumberFormat/subscription","commits_url":"https://api.github.com/repos/andersnm/ExcelNumberFormat/commits{/sha}","git_commits_url":"https://api.github.com/repos/andersnm/ExcelNumberFormat/git/commits{/sha}","comments_url":"https://api.github.com/repos/andersnm/ExcelNumberFormat/comments{/number}","issue_comment_url":"https://api.github.com/repos/andersnm/ExcelNumberFormat/issues/comments{/number}","contents_url":"https://api.github.com/repos/andersnm/ExcelNumberFormat/contents/{+path}","compare_url":"https://api.github.com/repos/andersnm/ExcelNumberFormat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andersnm/ExcelNumberFormat/merges","archive_url":"https://api.github.com/repos/andersnm/ExcelNumberFormat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andersnm/ExcelNumberFormat/downloads","issues_url":"https://api.github.com/repos/andersnm/ExcelNumberFormat/issues{/number}","pulls_url":"https://api.github.com/repos/andersnm/ExcelNumberFormat/pulls{/number}","milestones_url":"https://api.github.com/repos/andersnm/ExcelNumberFormat/milestones{/number}","notifications_url":"https://api.github.com/repos/andersnm/ExcelNumberFormat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andersnm/ExcelNumberFormat/labels{/name}","releases_url":"https://api.github.com/repos/andersnm/ExcelNumberFormat/releases{/id}","deployments_url":"https://api.github.com/repos/andersnm/ExcelNumberFormat/deployments","created_at":"2017-07-09T12:12:43Z","updated_at":"2017-07-09T12:21:28Z","pushed_at":"2017-10-31T12:24:45Z","git_url":"git://github.com/andersnm/ExcelNumberFormat.git","ssh_url":"git@github.com:andersnm/ExcelNumberFormat.git","clone_url":"https://github.com/andersnm/ExcelNumberFormat.git","svn_url":"https://github.com/andersnm/ExcelNumberFormat","homepage":"","size":24,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/andersnm/ExcelNumberFormat/pulls/3"},"html":{"href":"https://github.com/andersnm/ExcelNumberFormat/pull/3"},"issue":{"href":"https://api.github.com/repos/andersnm/ExcelNumberFormat/issues/3"},"comments":{"href":"https://api.github.com/repos/andersnm/ExcelNumberFormat/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/andersnm/ExcelNumberFormat/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/andersnm/ExcelNumberFormat/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/andersnm/ExcelNumberFormat/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/andersnm/ExcelNumberFormat/statuses/f06fc725b451c4edb2f9de3050bd9d3bc41391f6"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"andersnm","id":16575282,"avatar_url":"https://avatars1.githubusercontent.com/u/16575282?v=4","gravatar_id":"","url":"https://api.github.com/users/andersnm","html_url":"https://github.com/andersnm","followers_url":"https://api.github.com/users/andersnm/followers","following_url":"https://api.github.com/users/andersnm/following{/other_user}","gists_url":"https://api.github.com/users/andersnm/gists{/gist_id}","starred_url":"https://api.github.com/users/andersnm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andersnm/subscriptions","organizations_url":"https://api.github.com/users/andersnm/orgs","repos_url":"https://api.github.com/users/andersnm/repos","events_url":"https://api.github.com/users/andersnm/events{/privacy}","received_events_url":"https://api.github.com/users/andersnm/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":40,"deletions":19,"changed_files":2}}
{"actor":{"display_login":"andersnm"}}