{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/119429776","pull_request_review_id":41308879,"id":119429776,"diff_hunk":"@@ -194,7 +194,7 @@ func (o *Resources) parseDefinition(name string, s spec.Schema) Kind {\n \t\tFields:           map[string]Type{},\n \t}\n \tif err != nil {\n-\t\tglog.Warning(err)\n+\t\tglog.V(2).Info(err)","path":"pkg/kubectl/cmd/util/openapi/openapi.go","position":5,"original_position":5,"commit_id":"0e83d2a729ccd7411c27598aa05634111aa01c3c","original_commit_id":"0e83d2a729ccd7411c27598aa05634111aa01c3c","user":{"login":"droot","id":172029,"avatar_url":"https://avatars0.githubusercontent.com/u/172029?v=3","gravatar_id":"","url":"https://api.github.com/users/droot","html_url":"https://github.com/droot","followers_url":"https://api.github.com/users/droot/followers","following_url":"https://api.github.com/users/droot/following{/other_user}","gists_url":"https://api.github.com/users/droot/gists{/gist_id}","starred_url":"https://api.github.com/users/droot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/droot/subscriptions","organizations_url":"https://api.github.com/users/droot/orgs","repos_url":"https://api.github.com/users/droot/repos","events_url":"https://api.github.com/users/droot/events{/privacy}","received_events_url":"https://api.github.com/users/droot/received_events","type":"User","site_admin":false},"body":"During testing I discovered for some types, GVK metadata is not defined, so emit this error on stdout which is bad. So didn't have an option but to bump it to higher verbosity.","created_at":"2017-05-31T18:01:24Z","updated_at":"2017-05-31T18:01:24Z","html_url":"https://github.com/kubernetes/kubernetes/pull/46235#discussion_r119429776","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/46235","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/119429776"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/46235#discussion_r119429776"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/46235"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/46235","id":121838791,"html_url":"https://github.com/kubernetes/kubernetes/pull/46235","diff_url":"https://github.com/kubernetes/kubernetes/pull/46235.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/46235.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/46235","number":46235,"state":"open","locked":false,"title":"[WIP] print-column support in Get command in kubectl","user":{"login":"droot","id":172029,"avatar_url":"https://avatars0.githubusercontent.com/u/172029?v=3","gravatar_id":"","url":"https://api.github.com/users/droot","html_url":"https://github.com/droot","followers_url":"https://api.github.com/users/droot/followers","following_url":"https://api.github.com/users/droot/following{/other_user}","gists_url":"https://api.github.com/users/droot/gists{/gist_id}","starred_url":"https://api.github.com/users/droot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/droot/subscriptions","organizations_url":"https://api.github.com/users/droot/orgs","repos_url":"https://api.github.com/users/droot/repos","events_url":"https://api.github.com/users/droot/events{/privacy}","received_events_url":"https://api.github.com/users/droot/received_events","type":"User","site_admin":false},"body":"**What this PR does / why we need it**:\r\n\r\nKubectl Get command now uses metadata 'x-kubernetes-print-column' from Openapi schema to display a resource. This is to enable richer experience for non-compiled types (like service catalog API resources) in Kubectl. This functionality is currently guarded by a boolean flag \"use-openapi-print-columns\". \r\n\r\n**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #\r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Release note**:\r\n<!--  Steps to write your release note:\r\n1. Use the release-note-* labels to set the release note state (if you have access)\r\n2. Enter your extended release note in the below block; leaving it blank means using the PR title as the release note. If no release note is required, just write `NONE`.\r\n-->\r\n```release-note\r\nGet command uses OpenAPI schema to enhance display for a resource if run with flag 'use-openapi-print-columns'. \r\nAn example command:\r\nkubectl get pods --use-openapi-print-columns \r\n```\r\n","created_at":"2017-05-22T18:31:31Z","updated_at":"2017-05-31T18:01:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b44c6db74a6f65494b2c52578848a5cd189286c3","assignee":{"login":"soltysh","id":576341,"avatar_url":"https://avatars1.githubusercontent.com/u/576341?v=3","gravatar_id":"","url":"https://api.github.com/users/soltysh","html_url":"https://github.com/soltysh","followers_url":"https://api.github.com/users/soltysh/followers","following_url":"https://api.github.com/users/soltysh/following{/other_user}","gists_url":"https://api.github.com/users/soltysh/gists{/gist_id}","starred_url":"https://api.github.com/users/soltysh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soltysh/subscriptions","organizations_url":"https://api.github.com/users/soltysh/orgs","repos_url":"https://api.github.com/users/soltysh/repos","events_url":"https://api.github.com/users/soltysh/events{/privacy}","received_events_url":"https://api.github.com/users/soltysh/received_events","type":"User","site_admin":false},"assignees":[{"login":"fabianofranz","id":158611,"avatar_url":"https://avatars3.githubusercontent.com/u/158611?v=3","gravatar_id":"","url":"https://api.github.com/users/fabianofranz","html_url":"https://github.com/fabianofranz","followers_url":"https://api.github.com/users/fabianofranz/followers","following_url":"https://api.github.com/users/fabianofranz/following{/other_user}","gists_url":"https://api.github.com/users/fabianofranz/gists{/gist_id}","starred_url":"https://api.github.com/users/fabianofranz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabianofranz/subscriptions","organizations_url":"https://api.github.com/users/fabianofranz/orgs","repos_url":"https://api.github.com/users/fabianofranz/repos","events_url":"https://api.github.com/users/fabianofranz/events{/privacy}","received_events_url":"https://api.github.com/users/fabianofranz/received_events","type":"User","site_admin":false},{"login":"soltysh","id":576341,"avatar_url":"https://avatars1.githubusercontent.com/u/576341?v=3","gravatar_id":"","url":"https://api.github.com/users/soltysh","html_url":"https://github.com/soltysh","followers_url":"https://api.github.com/users/soltysh/followers","following_url":"https://api.github.com/users/soltysh/following{/other_user}","gists_url":"https://api.github.com/users/soltysh/gists{/gist_id}","starred_url":"https://api.github.com/users/soltysh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soltysh/subscriptions","organizations_url":"https://api.github.com/users/soltysh/orgs","repos_url":"https://api.github.com/users/soltysh/repos","events_url":"https://api.github.com/users/soltysh/events{/privacy}","received_events_url":"https://api.github.com/users/soltysh/received_events","type":"User","site_admin":false},{"login":"janetkuo","id":4876867,"avatar_url":"https://avatars2.githubusercontent.com/u/4876867?v=3","gravatar_id":"","url":"https://api.github.com/users/janetkuo","html_url":"https://github.com/janetkuo","followers_url":"https://api.github.com/users/janetkuo/followers","following_url":"https://api.github.com/users/janetkuo/following{/other_user}","gists_url":"https://api.github.com/users/janetkuo/gists{/gist_id}","starred_url":"https://api.github.com/users/janetkuo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janetkuo/subscriptions","organizations_url":"https://api.github.com/users/janetkuo/orgs","repos_url":"https://api.github.com/users/janetkuo/repos","events_url":"https://api.github.com/users/janetkuo/events{/privacy}","received_events_url":"https://api.github.com/users/janetkuo/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/46235/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/46235/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/46235/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/0e83d2a729ccd7411c27598aa05634111aa01c3c","head":{"label":"droot:cmd-printer-refactor","ref":"cmd-printer-refactor","sha":"0e83d2a729ccd7411c27598aa05634111aa01c3c","user":{"login":"droot","id":172029,"avatar_url":"https://avatars0.githubusercontent.com/u/172029?v=3","gravatar_id":"","url":"https://api.github.com/users/droot","html_url":"https://github.com/droot","followers_url":"https://api.github.com/users/droot/followers","following_url":"https://api.github.com/users/droot/following{/other_user}","gists_url":"https://api.github.com/users/droot/gists{/gist_id}","starred_url":"https://api.github.com/users/droot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/droot/subscriptions","organizations_url":"https://api.github.com/users/droot/orgs","repos_url":"https://api.github.com/users/droot/repos","events_url":"https://api.github.com/users/droot/events{/privacy}","received_events_url":"https://api.github.com/users/droot/received_events","type":"User","site_admin":false},"repo":{"id":90658452,"name":"kubernetes","full_name":"droot/kubernetes","owner":{"login":"droot","id":172029,"avatar_url":"https://avatars0.githubusercontent.com/u/172029?v=3","gravatar_id":"","url":"https://api.github.com/users/droot","html_url":"https://github.com/droot","followers_url":"https://api.github.com/users/droot/followers","following_url":"https://api.github.com/users/droot/following{/other_user}","gists_url":"https://api.github.com/users/droot/gists{/gist_id}","starred_url":"https://api.github.com/users/droot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/droot/subscriptions","organizations_url":"https://api.github.com/users/droot/orgs","repos_url":"https://api.github.com/users/droot/repos","events_url":"https://api.github.com/users/droot/events{/privacy}","received_events_url":"https://api.github.com/users/droot/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/droot/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/droot/kubernetes","forks_url":"https://api.github.com/repos/droot/kubernetes/forks","keys_url":"https://api.github.com/repos/droot/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/droot/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/droot/kubernetes/teams","hooks_url":"https://api.github.com/repos/droot/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/droot/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/droot/kubernetes/events","assignees_url":"https://api.github.com/repos/droot/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/droot/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/droot/kubernetes/tags","blobs_url":"https://api.github.com/repos/droot/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/droot/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/droot/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/droot/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/droot/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/droot/kubernetes/languages","stargazers_url":"https://api.github.com/repos/droot/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/droot/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/droot/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/droot/kubernetes/subscription","commits_url":"https://api.github.com/repos/droot/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/droot/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/droot/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/droot/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/droot/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/droot/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/droot/kubernetes/merges","archive_url":"https://api.github.com/repos/droot/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/droot/kubernetes/downloads","issues_url":"https://api.github.com/repos/droot/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/droot/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/droot/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/droot/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/droot/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/droot/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/droot/kubernetes/deployments","created_at":"2017-05-08T18:11:48Z","updated_at":"2017-05-08T18:12:23Z","pushed_at":"2017-05-31T00:19:32Z","git_url":"git://github.com/droot/kubernetes.git","ssh_url":"git@github.com:droot/kubernetes.git","clone_url":"https://github.com/droot/kubernetes.git","svn_url":"https://github.com/droot/kubernetes","homepage":"http://kubernetes.io","size":435413,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"e0a6cde6f43e5c628395f8f9b5589c5d6298ec8e","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars1.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars1.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2017-05-31T16:15:07Z","pushed_at":"2017-05-31T17:52:16Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":654506,"stargazers_count":23603,"watchers_count":23603,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8349,"mirror_url":null,"open_issues_count":5477,"forks":8349,"open_issues":5477,"watchers":23603,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/46235"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/46235"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/46235"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/46235/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/46235/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/46235/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/0e83d2a729ccd7411c27598aa05634111aa01c3c"}}}}
{"actor":{"display_login":"droot"}}