{"action":"created","issue":{"url":"https://api.github.com/repos/intelsdi-x/swan/issues/745","repository_url":"https://api.github.com/repos/intelsdi-x/swan","labels_url":"https://api.github.com/repos/intelsdi-x/swan/issues/745/labels{/name}","comments_url":"https://api.github.com/repos/intelsdi-x/swan/issues/745/comments","events_url":"https://api.github.com/repos/intelsdi-x/swan/issues/745/events","html_url":"https://github.com/intelsdi-x/swan/pull/745","id":237520934,"number":745,"title":"Dropped SessionLauncherPair & refactored experiment helpers","user":{"login":"skonefal","id":10141081,"avatar_url":"https://avatars1.githubusercontent.com/u/10141081?v=3","gravatar_id":"","url":"https://api.github.com/users/skonefal","html_url":"https://github.com/skonefal","followers_url":"https://api.github.com/users/skonefal/followers","following_url":"https://api.github.com/users/skonefal/following{/other_user}","gists_url":"https://api.github.com/users/skonefal/gists{/gist_id}","starred_url":"https://api.github.com/users/skonefal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skonefal/subscriptions","organizations_url":"https://api.github.com/users/skonefal/orgs","repos_url":"https://api.github.com/users/skonefal/repos","events_url":"https://api.github.com/users/skonefal/events{/privacy}","received_events_url":"https://api.github.com/users/skonefal/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-06-21T12:43:59Z","updated_at":"2017-06-21T12:46:58Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/intelsdi-x/swan/pulls/745","html_url":"https://github.com/intelsdi-x/swan/pull/745","diff_url":"https://github.com/intelsdi-x/swan/pull/745.diff","patch_url":"https://github.com/intelsdi-x/swan/pull/745.patch"},"body":"This PR removes unnecessary SessionLauncherPair abstraction and merges multiple _helper_ methods from pkg/experiment/sensitivity package to composite objects that have single responsibilities.\r\nThis unification was necessary, because multiple experiments generated and used SessionLauncherPair in different way which was starting to be unmaintainable.\r\n\r\nMost of the code in this PR is copied-and-pasted in different place.\r\n\r\nSummary of changes:\r\n\r\nPlease see commit messages for detailed changes.\r\nFirst three commits are small code cleanings.\r\n- Small improvements in SPECjbb workload and experiment code\r\n- Small update in PrepareLoadGenerator and executor\r\n- Moved topology helpers from experiment to threadset package\r\n\r\nNext one adds Caffe metrics collection to Caffe Launcher. One should note that this is temporary solution required to drop SessionLauncherPair. Final solution will be described in _Next Steps_.\r\n- Caffe Launcher starts Snap APM metrics collection\r\n\r\nFirst two commits removes code that will be refactored and adds it in third commit.\r\n- Removed code that will be reintroduced in next commit\r\n- Removed CLI notions from workloads\r\n- Introducing new Sensitivity helpers\r\n\r\nLast commit show how new helpers work in action.\r\n- All experiments now use the same abstractions in the same way\r\n\r\n**Next Steps**\r\nSnap Launcher interface should be the same as workload's Launcher interface (`Launch() (TaskHandle, err)`). To make this happen, Caffe Metrics Collector Launcher will wrap Caffe Workload launcher and control it's lifecle. Snap Tags will be supplied to Caffe metrics collector.\r\n\r\nFor Mutilate, Mutilate metrics collector will have LoadGenerator interface and wrap Mutilate Load Generator.\r\n"},"comment":{"url":"https://api.github.com/repos/intelsdi-x/swan/issues/comments/310067451","html_url":"https://github.com/intelsdi-x/swan/pull/745#issuecomment-310067451","issue_url":"https://api.github.com/repos/intelsdi-x/swan/issues/745","id":310067451,"user":{"login":"skonefal","id":10141081,"avatar_url":"https://avatars1.githubusercontent.com/u/10141081?v=3","gravatar_id":"","url":"https://api.github.com/users/skonefal","html_url":"https://github.com/skonefal","followers_url":"https://api.github.com/users/skonefal/followers","following_url":"https://api.github.com/users/skonefal/following{/other_user}","gists_url":"https://api.github.com/users/skonefal/gists{/gist_id}","starred_url":"https://api.github.com/users/skonefal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skonefal/subscriptions","organizations_url":"https://api.github.com/users/skonefal/orgs","repos_url":"https://api.github.com/users/skonefal/repos","events_url":"https://api.github.com/users/skonefal/events{/privacy}","received_events_url":"https://api.github.com/users/skonefal/received_events","type":"User","site_admin":false},"created_at":"2017-06-21T12:46:58Z","updated_at":"2017-06-21T12:46:58Z","body":"run integration tests"}}
{"actor":{"display_login":"skonefal"}}