{"action":"created","comment":{"url":"https://api.github.com/repos/triplea-game/triplea/pulls/comments/95482617","pull_request_review_id":16039017,"id":95482617,"diff_hunk":"@@ -355,8 +355,8 @@ public String toString() {\n    *         the route consists of only a starting territory\n    */\n   public Territory getEnd() {\n-    if (m_steps.size() == 0) {\n-      return null;\n+    if (m_steps.isEmpty()) {\n+      return m_start;","path":"src/games/strategy/engine/data/Route.java","position":81,"original_position":7,"commit_id":"185fa7b22781723c5d91bd97f6c88c8abc36d3de","original_commit_id":"9a1cb4dc42fa2d3d8b15eabcc50acf3b606dbb20","user":{"login":"ron-murhammer","id":1427689,"avatar_url":"https://avatars.githubusercontent.com/u/1427689?v=3","gravatar_id":"","url":"https://api.github.com/users/ron-murhammer","html_url":"https://github.com/ron-murhammer","followers_url":"https://api.github.com/users/ron-murhammer/followers","following_url":"https://api.github.com/users/ron-murhammer/following{/other_user}","gists_url":"https://api.github.com/users/ron-murhammer/gists{/gist_id}","starred_url":"https://api.github.com/users/ron-murhammer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ron-murhammer/subscriptions","organizations_url":"https://api.github.com/users/ron-murhammer/orgs","repos_url":"https://api.github.com/users/ron-murhammer/repos","events_url":"https://api.github.com/users/ron-murhammer/events{/privacy}","received_events_url":"https://api.github.com/users/ron-murhammer/received_events","type":"User","site_admin":false},"body":"Alright. I'm ok moving forward with the change. I'd prefer changes like this in separate PRs or if in a PR like this then definitely commented since its pretty unclear why the change is being made.","created_at":"2017-01-10T23:34:38Z","updated_at":"2017-01-10T23:34:38Z","html_url":"https://github.com/triplea-game/triplea/pull/1433#discussion_r95482617","pull_request_url":"https://api.github.com/repos/triplea-game/triplea/pulls/1433","_links":{"self":{"href":"https://api.github.com/repos/triplea-game/triplea/pulls/comments/95482617"},"html":{"href":"https://github.com/triplea-game/triplea/pull/1433#discussion_r95482617"},"pull_request":{"href":"https://api.github.com/repos/triplea-game/triplea/pulls/1433"}}},"pull_request":{"url":"https://api.github.com/repos/triplea-game/triplea/pulls/1433","id":100625716,"html_url":"https://github.com/triplea-game/triplea/pull/1433","diff_url":"https://github.com/triplea-game/triplea/pull/1433.diff","patch_url":"https://github.com/triplea-game/triplea/pull/1433.patch","issue_url":"https://api.github.com/repos/triplea-game/triplea/issues/1433","number":1433,"state":"open","locked":false,"title":"Automatic air raids","user":{"login":"DanVanAtta","id":12397753,"avatar_url":"https://avatars.githubusercontent.com/u/12397753?v=3","gravatar_id":"","url":"https://api.github.com/users/DanVanAtta","html_url":"https://github.com/DanVanAtta","followers_url":"https://api.github.com/users/DanVanAtta/followers","following_url":"https://api.github.com/users/DanVanAtta/following{/other_user}","gists_url":"https://api.github.com/users/DanVanAtta/gists{/gist_id}","starred_url":"https://api.github.com/users/DanVanAtta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanVanAtta/subscriptions","organizations_url":"https://api.github.com/users/DanVanAtta/orgs","repos_url":"https://api.github.com/users/DanVanAtta/repos","events_url":"https://api.github.com/users/DanVanAtta/events{/privacy}","received_events_url":"https://api.github.com/users/DanVanAtta/received_events","type":"User","site_admin":false},"body":"Builds on top of: https://github.com/triplea-game/triplea/pull/1426\r\n\r\nIncluded:\r\n- Bombing and air raids are \"auto-selected\"\r\n  - This reduces clicks in the game flow, these battles have to be fought\r\n  - Game rules would have these battles fought first, then amphib. We are for now forcing that these battles be fought first. See #1426 for more discussion on purpose\r\n\r\nTest notes:\r\n@simon33-2  - quite right to point out that possible to test is not the same as easy to test. There are a number of scaffolding changes included just to make testing easier to write. \r\n\r\nEnhancements on #1426 \r\n- added checks for SBR in addition to Air raids, and will fight those first as well\r\n- added unit test + scaffolding\r\n\r\nNow that we auto-fight SBR's, a few integration tests broke. I removed rather than fixing them since they can no longer test anything. They were dependent on battles still existing after calling BattleDelegate.start(), which is now no longer the case. With the unit test in place we have test coverage, so we can remove the integration tests.","created_at":"2017-01-09T01:40:48Z","updated_at":"2017-01-10T23:34:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"782d05192c29a8511a97c5cb313911fc79487013","assignee":{"login":"ron-murhammer","id":1427689,"avatar_url":"https://avatars.githubusercontent.com/u/1427689?v=3","gravatar_id":"","url":"https://api.github.com/users/ron-murhammer","html_url":"https://github.com/ron-murhammer","followers_url":"https://api.github.com/users/ron-murhammer/followers","following_url":"https://api.github.com/users/ron-murhammer/following{/other_user}","gists_url":"https://api.github.com/users/ron-murhammer/gists{/gist_id}","starred_url":"https://api.github.com/users/ron-murhammer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ron-murhammer/subscriptions","organizations_url":"https://api.github.com/users/ron-murhammer/orgs","repos_url":"https://api.github.com/users/ron-murhammer/repos","events_url":"https://api.github.com/users/ron-murhammer/events{/privacy}","received_events_url":"https://api.github.com/users/ron-murhammer/received_events","type":"User","site_admin":false},"assignees":[{"login":"ron-murhammer","id":1427689,"avatar_url":"https://avatars.githubusercontent.com/u/1427689?v=3","gravatar_id":"","url":"https://api.github.com/users/ron-murhammer","html_url":"https://github.com/ron-murhammer","followers_url":"https://api.github.com/users/ron-murhammer/followers","following_url":"https://api.github.com/users/ron-murhammer/following{/other_user}","gists_url":"https://api.github.com/users/ron-murhammer/gists{/gist_id}","starred_url":"https://api.github.com/users/ron-murhammer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ron-murhammer/subscriptions","organizations_url":"https://api.github.com/users/ron-murhammer/orgs","repos_url":"https://api.github.com/users/ron-murhammer/repos","events_url":"https://api.github.com/users/ron-murhammer/events{/privacy}","received_events_url":"https://api.github.com/users/ron-murhammer/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/triplea-game/triplea/pulls/1433/commits","review_comments_url":"https://api.github.com/repos/triplea-game/triplea/pulls/1433/comments","review_comment_url":"https://api.github.com/repos/triplea-game/triplea/pulls/comments{/number}","comments_url":"https://api.github.com/repos/triplea-game/triplea/issues/1433/comments","statuses_url":"https://api.github.com/repos/triplea-game/triplea/statuses/185fa7b22781723c5d91bd97f6c88c8abc36d3de","head":{"label":"DanVanAtta:auto_combat","ref":"auto_combat","sha":"185fa7b22781723c5d91bd97f6c88c8abc36d3de","user":{"login":"DanVanAtta","id":12397753,"avatar_url":"https://avatars.githubusercontent.com/u/12397753?v=3","gravatar_id":"","url":"https://api.github.com/users/DanVanAtta","html_url":"https://github.com/DanVanAtta","followers_url":"https://api.github.com/users/DanVanAtta/followers","following_url":"https://api.github.com/users/DanVanAtta/following{/other_user}","gists_url":"https://api.github.com/users/DanVanAtta/gists{/gist_id}","starred_url":"https://api.github.com/users/DanVanAtta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanVanAtta/subscriptions","organizations_url":"https://api.github.com/users/DanVanAtta/orgs","repos_url":"https://api.github.com/users/DanVanAtta/repos","events_url":"https://api.github.com/users/DanVanAtta/events{/privacy}","received_events_url":"https://api.github.com/users/DanVanAtta/received_events","type":"User","site_admin":false},"repo":{"id":39811826,"name":"triplea","full_name":"DanVanAtta/triplea","owner":{"login":"DanVanAtta","id":12397753,"avatar_url":"https://avatars.githubusercontent.com/u/12397753?v=3","gravatar_id":"","url":"https://api.github.com/users/DanVanAtta","html_url":"https://github.com/DanVanAtta","followers_url":"https://api.github.com/users/DanVanAtta/followers","following_url":"https://api.github.com/users/DanVanAtta/following{/other_user}","gists_url":"https://api.github.com/users/DanVanAtta/gists{/gist_id}","starred_url":"https://api.github.com/users/DanVanAtta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanVanAtta/subscriptions","organizations_url":"https://api.github.com/users/DanVanAtta/orgs","repos_url":"https://api.github.com/users/DanVanAtta/repos","events_url":"https://api.github.com/users/DanVanAtta/events{/privacy}","received_events_url":"https://api.github.com/users/DanVanAtta/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DanVanAtta/triplea","description":"TripleA is a turn based strategy game and board game engine, similar to Axis & Allies or Risk.","fork":true,"url":"https://api.github.com/repos/DanVanAtta/triplea","forks_url":"https://api.github.com/repos/DanVanAtta/triplea/forks","keys_url":"https://api.github.com/repos/DanVanAtta/triplea/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DanVanAtta/triplea/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DanVanAtta/triplea/teams","hooks_url":"https://api.github.com/repos/DanVanAtta/triplea/hooks","issue_events_url":"https://api.github.com/repos/DanVanAtta/triplea/issues/events{/number}","events_url":"https://api.github.com/repos/DanVanAtta/triplea/events","assignees_url":"https://api.github.com/repos/DanVanAtta/triplea/assignees{/user}","branches_url":"https://api.github.com/repos/DanVanAtta/triplea/branches{/branch}","tags_url":"https://api.github.com/repos/DanVanAtta/triplea/tags","blobs_url":"https://api.github.com/repos/DanVanAtta/triplea/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DanVanAtta/triplea/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DanVanAtta/triplea/git/refs{/sha}","trees_url":"https://api.github.com/repos/DanVanAtta/triplea/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DanVanAtta/triplea/statuses/{sha}","languages_url":"https://api.github.com/repos/DanVanAtta/triplea/languages","stargazers_url":"https://api.github.com/repos/DanVanAtta/triplea/stargazers","contributors_url":"https://api.github.com/repos/DanVanAtta/triplea/contributors","subscribers_url":"https://api.github.com/repos/DanVanAtta/triplea/subscribers","subscription_url":"https://api.github.com/repos/DanVanAtta/triplea/subscription","commits_url":"https://api.github.com/repos/DanVanAtta/triplea/commits{/sha}","git_commits_url":"https://api.github.com/repos/DanVanAtta/triplea/git/commits{/sha}","comments_url":"https://api.github.com/repos/DanVanAtta/triplea/comments{/number}","issue_comment_url":"https://api.github.com/repos/DanVanAtta/triplea/issues/comments{/number}","contents_url":"https://api.github.com/repos/DanVanAtta/triplea/contents/{+path}","compare_url":"https://api.github.com/repos/DanVanAtta/triplea/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DanVanAtta/triplea/merges","archive_url":"https://api.github.com/repos/DanVanAtta/triplea/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DanVanAtta/triplea/downloads","issues_url":"https://api.github.com/repos/DanVanAtta/triplea/issues{/number}","pulls_url":"https://api.github.com/repos/DanVanAtta/triplea/pulls{/number}","milestones_url":"https://api.github.com/repos/DanVanAtta/triplea/milestones{/number}","notifications_url":"https://api.github.com/repos/DanVanAtta/triplea/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DanVanAtta/triplea/labels{/name}","releases_url":"https://api.github.com/repos/DanVanAtta/triplea/releases{/id}","deployments_url":"https://api.github.com/repos/DanVanAtta/triplea/deployments","created_at":"2015-07-28T03:48:44Z","updated_at":"2016-12-18T20:47:08Z","pushed_at":"2017-01-10T08:35:59Z","git_url":"git://github.com/DanVanAtta/triplea.git","ssh_url":"git@github.com:DanVanAtta/triplea.git","clone_url":"https://github.com/DanVanAtta/triplea.git","svn_url":"https://github.com/DanVanAtta/triplea","homepage":null,"size":706914,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"triplea-game:master","ref":"master","sha":"03fcf7041d5db7e50d3423f7d2a58b1778b09344","user":{"login":"triplea-game","id":13318615,"avatar_url":"https://avatars.githubusercontent.com/u/13318615?v=3","gravatar_id":"","url":"https://api.github.com/users/triplea-game","html_url":"https://github.com/triplea-game","followers_url":"https://api.github.com/users/triplea-game/followers","following_url":"https://api.github.com/users/triplea-game/following{/other_user}","gists_url":"https://api.github.com/users/triplea-game/gists{/gist_id}","starred_url":"https://api.github.com/users/triplea-game/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/triplea-game/subscriptions","organizations_url":"https://api.github.com/users/triplea-game/orgs","repos_url":"https://api.github.com/users/triplea-game/repos","events_url":"https://api.github.com/users/triplea-game/events{/privacy}","received_events_url":"https://api.github.com/users/triplea-game/received_events","type":"Organization","site_admin":false},"repo":{"id":39766308,"name":"triplea","full_name":"triplea-game/triplea","owner":{"login":"triplea-game","id":13318615,"avatar_url":"https://avatars.githubusercontent.com/u/13318615?v=3","gravatar_id":"","url":"https://api.github.com/users/triplea-game","html_url":"https://github.com/triplea-game","followers_url":"https://api.github.com/users/triplea-game/followers","following_url":"https://api.github.com/users/triplea-game/following{/other_user}","gists_url":"https://api.github.com/users/triplea-game/gists{/gist_id}","starred_url":"https://api.github.com/users/triplea-game/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/triplea-game/subscriptions","organizations_url":"https://api.github.com/users/triplea-game/orgs","repos_url":"https://api.github.com/users/triplea-game/repos","events_url":"https://api.github.com/users/triplea-game/events{/privacy}","received_events_url":"https://api.github.com/users/triplea-game/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/triplea-game/triplea","description":"TripleA is a turn based strategy game and board game engine, similar to Axis & Allies or Risk.","fork":false,"url":"https://api.github.com/repos/triplea-game/triplea","forks_url":"https://api.github.com/repos/triplea-game/triplea/forks","keys_url":"https://api.github.com/repos/triplea-game/triplea/keys{/key_id}","collaborators_url":"https://api.github.com/repos/triplea-game/triplea/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/triplea-game/triplea/teams","hooks_url":"https://api.github.com/repos/triplea-game/triplea/hooks","issue_events_url":"https://api.github.com/repos/triplea-game/triplea/issues/events{/number}","events_url":"https://api.github.com/repos/triplea-game/triplea/events","assignees_url":"https://api.github.com/repos/triplea-game/triplea/assignees{/user}","branches_url":"https://api.github.com/repos/triplea-game/triplea/branches{/branch}","tags_url":"https://api.github.com/repos/triplea-game/triplea/tags","blobs_url":"https://api.github.com/repos/triplea-game/triplea/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/triplea-game/triplea/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/triplea-game/triplea/git/refs{/sha}","trees_url":"https://api.github.com/repos/triplea-game/triplea/git/trees{/sha}","statuses_url":"https://api.github.com/repos/triplea-game/triplea/statuses/{sha}","languages_url":"https://api.github.com/repos/triplea-game/triplea/languages","stargazers_url":"https://api.github.com/repos/triplea-game/triplea/stargazers","contributors_url":"https://api.github.com/repos/triplea-game/triplea/contributors","subscribers_url":"https://api.github.com/repos/triplea-game/triplea/subscribers","subscription_url":"https://api.github.com/repos/triplea-game/triplea/subscription","commits_url":"https://api.github.com/repos/triplea-game/triplea/commits{/sha}","git_commits_url":"https://api.github.com/repos/triplea-game/triplea/git/commits{/sha}","comments_url":"https://api.github.com/repos/triplea-game/triplea/comments{/number}","issue_comment_url":"https://api.github.com/repos/triplea-game/triplea/issues/comments{/number}","contents_url":"https://api.github.com/repos/triplea-game/triplea/contents/{+path}","compare_url":"https://api.github.com/repos/triplea-game/triplea/compare/{base}...{head}","merges_url":"https://api.github.com/repos/triplea-game/triplea/merges","archive_url":"https://api.github.com/repos/triplea-game/triplea/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/triplea-game/triplea/downloads","issues_url":"https://api.github.com/repos/triplea-game/triplea/issues{/number}","pulls_url":"https://api.github.com/repos/triplea-game/triplea/pulls{/number}","milestones_url":"https://api.github.com/repos/triplea-game/triplea/milestones{/number}","notifications_url":"https://api.github.com/repos/triplea-game/triplea/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/triplea-game/triplea/labels{/name}","releases_url":"https://api.github.com/repos/triplea-game/triplea/releases{/id}","deployments_url":"https://api.github.com/repos/triplea-game/triplea/deployments","created_at":"2015-07-27T09:32:58Z","updated_at":"2017-01-04T06:51:46Z","pushed_at":"2017-01-10T20:25:31Z","git_url":"git://github.com/triplea-game/triplea.git","ssh_url":"git@github.com:triplea-game/triplea.git","clone_url":"https://github.com/triplea-game/triplea.git","svn_url":"https://github.com/triplea-game/triplea","homepage":null,"size":714829,"stargazers_count":37,"watchers_count":37,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"open_issues_count":121,"forks":28,"open_issues":121,"watchers":37,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/triplea-game/triplea/pulls/1433"},"html":{"href":"https://github.com/triplea-game/triplea/pull/1433"},"issue":{"href":"https://api.github.com/repos/triplea-game/triplea/issues/1433"},"comments":{"href":"https://api.github.com/repos/triplea-game/triplea/issues/1433/comments"},"review_comments":{"href":"https://api.github.com/repos/triplea-game/triplea/pulls/1433/comments"},"review_comment":{"href":"https://api.github.com/repos/triplea-game/triplea/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/triplea-game/triplea/pulls/1433/commits"},"statuses":{"href":"https://api.github.com/repos/triplea-game/triplea/statuses/185fa7b22781723c5d91bd97f6c88c8abc36d3de"}}}}
{"actor":{"display_login":"ron-murhammer"}}