{"action":"closed","number":630,"pull_request":{"url":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws/pulls/630","id":145116097,"html_url":"https://github.com/zalando-incubator/kubernetes-on-aws/pull/630","diff_url":"https://github.com/zalando-incubator/kubernetes-on-aws/pull/630.diff","patch_url":"https://github.com/zalando-incubator/kubernetes-on-aws/pull/630.patch","issue_url":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws/issues/630","number":630,"state":"closed","locked":false,"title":"Label node role with well-known labels","user":{"login":"linki","id":36162,"avatar_url":"https://avatars1.githubusercontent.com/u/36162?v=4","gravatar_id":"","url":"https://api.github.com/users/linki","html_url":"https://github.com/linki","followers_url":"https://api.github.com/users/linki/followers","following_url":"https://api.github.com/users/linki/following{/other_user}","gists_url":"https://api.github.com/users/linki/gists{/gist_id}","starred_url":"https://api.github.com/users/linki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linki/subscriptions","organizations_url":"https://api.github.com/users/linki/orgs","repos_url":"https://api.github.com/users/linki/repos","events_url":"https://api.github.com/users/linki/events{/privacy}","received_events_url":"https://api.github.com/users/linki/received_events","type":"User","site_admin":false},"body":"There's now a well-known label for the node role (actually it's two):\r\n* `kubernetes.io/role=theRole`\r\n* `node-role.kubernetes.io/theRole=true`\r\n\r\nhttps://github.com/kubernetes/kubernetes/blob/v1.8.0/pkg/printers/internalversion/printers.go#L70\r\n\r\nBoth annotations are supported in `kubectl get nodes` beginning with 1.8 (see the ROLES column):\r\n\r\n```console\r\n$ kubectl get nodes\r\nNAME                                             STATUS                     ROLES     AGE       VERSION\r\nip-172-31-0-28.eu-central-1.compute.internal     Ready,SchedulingDisabled   master    19h       v1.7.7+coreos.0\r\nip-172-31-20-163.eu-central-1.compute.internal   Ready                      worker    18h       v1.7.7+coreos.0\r\n```\r\n\r\nKeeping the old label for backwards-compatibility.","created_at":"2017-10-06T10:09:25Z","updated_at":"2017-10-06T14:37:24Z","closed_at":"2017-10-06T14:37:24Z","merged_at":"2017-10-06T14:37:23Z","merge_commit_sha":"647c8c403049fe85294bc3881e4229811a0afa7b","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws/pulls/630/commits","review_comments_url":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws/pulls/630/comments","review_comment_url":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws/issues/630/comments","statuses_url":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws/statuses/be5a2cb6b3b9fafd5554259834d47767ac221be4","head":{"label":"zalando-incubator:node-role","ref":"node-role","sha":"be5a2cb6b3b9fafd5554259834d47767ac221be4","user":{"login":"zalando-incubator","id":18533786,"avatar_url":"https://avatars3.githubusercontent.com/u/18533786?v=4","gravatar_id":"","url":"https://api.github.com/users/zalando-incubator","html_url":"https://github.com/zalando-incubator","followers_url":"https://api.github.com/users/zalando-incubator/followers","following_url":"https://api.github.com/users/zalando-incubator/following{/other_user}","gists_url":"https://api.github.com/users/zalando-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/zalando-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalando-incubator/subscriptions","organizations_url":"https://api.github.com/users/zalando-incubator/orgs","repos_url":"https://api.github.com/users/zalando-incubator/repos","events_url":"https://api.github.com/users/zalando-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/zalando-incubator/received_events","type":"Organization","site_admin":false},"repo":{"id":70882616,"name":"kubernetes-on-aws","full_name":"zalando-incubator/kubernetes-on-aws","owner":{"login":"zalando-incubator","id":18533786,"avatar_url":"https://avatars3.githubusercontent.com/u/18533786?v=4","gravatar_id":"","url":"https://api.github.com/users/zalando-incubator","html_url":"https://github.com/zalando-incubator","followers_url":"https://api.github.com/users/zalando-incubator/followers","following_url":"https://api.github.com/users/zalando-incubator/following{/other_user}","gists_url":"https://api.github.com/users/zalando-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/zalando-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalando-incubator/subscriptions","organizations_url":"https://api.github.com/users/zalando-incubator/orgs","repos_url":"https://api.github.com/users/zalando-incubator/repos","events_url":"https://api.github.com/users/zalando-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/zalando-incubator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zalando-incubator/kubernetes-on-aws","description":"Deploying Kubernetes on AWS with CloudFormation and Container Linux","fork":false,"url":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws","forks_url":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws/forks","keys_url":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws/teams","hooks_url":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws/hooks","issue_events_url":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws/issues/events{/number}","events_url":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws/events","assignees_url":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws/assignees{/user}","branches_url":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws/branches{/branch}","tags_url":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws/tags","blobs_url":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws/git/refs{/sha}","trees_url":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws/statuses/{sha}","languages_url":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws/languages","stargazers_url":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws/stargazers","contributors_url":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws/contributors","subscribers_url":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws/subscribers","subscription_url":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws/subscription","commits_url":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws/commits{/sha}","git_commits_url":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws/git/commits{/sha}","comments_url":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws/comments{/number}","issue_comment_url":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws/issues/comments{/number}","contents_url":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws/contents/{+path}","compare_url":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws/merges","archive_url":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws/downloads","issues_url":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws/issues{/number}","pulls_url":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws/pulls{/number}","milestones_url":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws/milestones{/number}","notifications_url":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws/labels{/name}","releases_url":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws/releases{/id}","deployments_url":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws/deployments","created_at":"2016-10-14T06:55:28Z","updated_at":"2017-10-05T10:14:05Z","pushed_at":"2017-10-06T14:37:24Z","git_url":"git://github.com/zalando-incubator/kubernetes-on-aws.git","ssh_url":"git@github.com:zalando-incubator/kubernetes-on-aws.git","clone_url":"https://github.com/zalando-incubator/kubernetes-on-aws.git","svn_url":"https://github.com/zalando-incubator/kubernetes-on-aws","homepage":"https://kubernetes-on-aws.readthedocs.io/","size":2476,"stargazers_count":98,"watchers_count":98,"language":"Shell","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":26,"mirror_url":null,"open_issues_count":21,"forks":26,"open_issues":21,"watchers":98,"default_branch":"dev"}},"base":{"label":"zalando-incubator:dev","ref":"dev","sha":"ce54c97355aeaa2f7e7e0d2d7761dd4b618dbfaf","user":{"login":"zalando-incubator","id":18533786,"avatar_url":"https://avatars3.githubusercontent.com/u/18533786?v=4","gravatar_id":"","url":"https://api.github.com/users/zalando-incubator","html_url":"https://github.com/zalando-incubator","followers_url":"https://api.github.com/users/zalando-incubator/followers","following_url":"https://api.github.com/users/zalando-incubator/following{/other_user}","gists_url":"https://api.github.com/users/zalando-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/zalando-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalando-incubator/subscriptions","organizations_url":"https://api.github.com/users/zalando-incubator/orgs","repos_url":"https://api.github.com/users/zalando-incubator/repos","events_url":"https://api.github.com/users/zalando-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/zalando-incubator/received_events","type":"Organization","site_admin":false},"repo":{"id":70882616,"name":"kubernetes-on-aws","full_name":"zalando-incubator/kubernetes-on-aws","owner":{"login":"zalando-incubator","id":18533786,"avatar_url":"https://avatars3.githubusercontent.com/u/18533786?v=4","gravatar_id":"","url":"https://api.github.com/users/zalando-incubator","html_url":"https://github.com/zalando-incubator","followers_url":"https://api.github.com/users/zalando-incubator/followers","following_url":"https://api.github.com/users/zalando-incubator/following{/other_user}","gists_url":"https://api.github.com/users/zalando-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/zalando-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalando-incubator/subscriptions","organizations_url":"https://api.github.com/users/zalando-incubator/orgs","repos_url":"https://api.github.com/users/zalando-incubator/repos","events_url":"https://api.github.com/users/zalando-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/zalando-incubator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zalando-incubator/kubernetes-on-aws","description":"Deploying Kubernetes on AWS with CloudFormation and Container Linux","fork":false,"url":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws","forks_url":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws/forks","keys_url":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws/teams","hooks_url":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws/hooks","issue_events_url":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws/issues/events{/number}","events_url":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws/events","assignees_url":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws/assignees{/user}","branches_url":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws/branches{/branch}","tags_url":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws/tags","blobs_url":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws/git/refs{/sha}","trees_url":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws/statuses/{sha}","languages_url":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws/languages","stargazers_url":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws/stargazers","contributors_url":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws/contributors","subscribers_url":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws/subscribers","subscription_url":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws/subscription","commits_url":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws/commits{/sha}","git_commits_url":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws/git/commits{/sha}","comments_url":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws/comments{/number}","issue_comment_url":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws/issues/comments{/number}","contents_url":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws/contents/{+path}","compare_url":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws/merges","archive_url":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws/downloads","issues_url":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws/issues{/number}","pulls_url":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws/pulls{/number}","milestones_url":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws/milestones{/number}","notifications_url":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws/labels{/name}","releases_url":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws/releases{/id}","deployments_url":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws/deployments","created_at":"2016-10-14T06:55:28Z","updated_at":"2017-10-05T10:14:05Z","pushed_at":"2017-10-06T14:37:24Z","git_url":"git://github.com/zalando-incubator/kubernetes-on-aws.git","ssh_url":"git@github.com:zalando-incubator/kubernetes-on-aws.git","clone_url":"https://github.com/zalando-incubator/kubernetes-on-aws.git","svn_url":"https://github.com/zalando-incubator/kubernetes-on-aws","homepage":"https://kubernetes-on-aws.readthedocs.io/","size":2476,"stargazers_count":98,"watchers_count":98,"language":"Shell","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":26,"mirror_url":null,"open_issues_count":21,"forks":26,"open_issues":21,"watchers":98,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws/pulls/630"},"html":{"href":"https://github.com/zalando-incubator/kubernetes-on-aws/pull/630"},"issue":{"href":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws/issues/630"},"comments":{"href":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws/issues/630/comments"},"review_comments":{"href":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws/pulls/630/comments"},"review_comment":{"href":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws/pulls/630/commits"},"statuses":{"href":"https://api.github.com/repos/zalando-incubator/kubernetes-on-aws/statuses/be5a2cb6b3b9fafd5554259834d47767ac221be4"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"mikkeloscar","id":128566,"avatar_url":"https://avatars0.githubusercontent.com/u/128566?v=4","gravatar_id":"","url":"https://api.github.com/users/mikkeloscar","html_url":"https://github.com/mikkeloscar","followers_url":"https://api.github.com/users/mikkeloscar/followers","following_url":"https://api.github.com/users/mikkeloscar/following{/other_user}","gists_url":"https://api.github.com/users/mikkeloscar/gists{/gist_id}","starred_url":"https://api.github.com/users/mikkeloscar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikkeloscar/subscriptions","organizations_url":"https://api.github.com/users/mikkeloscar/orgs","repos_url":"https://api.github.com/users/mikkeloscar/repos","events_url":"https://api.github.com/users/mikkeloscar/events{/privacy}","received_events_url":"https://api.github.com/users/mikkeloscar/received_events","type":"User","site_admin":false},"comments":4,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":2,"deletions":1,"changed_files":2}}
{"actor":{"display_login":"mikkeloscar"}}