{"action":"created","comment":{"url":"https://api.github.com/repos/openucx/ucx/pulls/comments/154621004","pull_request_review_id":80576880,"id":154621004,"diff_hunk":"@@ -44,26 +126,77 @@ static void ucp_rndv_rma_request_send_buffer_dereg(ucp_request_t *sreq)\n \n static size_t ucp_tag_rndv_pack_send_rkey(ucp_request_t *sreq, void *rkey_buf, uint16_t *flags)\n {\n-    ucp_ep_h ep = sreq->send.ep;\n-    ucp_lane_index_t lane = ucp_ep_get_rndv_get_lane(ep, 0);\n+    ucp_ep_h ep           = sreq->send.ep;\n+    uint8_t *buf          = rkey_buf;\n+    uint8_t *cnt          = buf;\n+    size_t packet;\n+    ucp_lane_index_t lane;\n     ucs_status_t status;\n+    int i;\n+    ucp_rndv_rkey_data_t *rkey;\n \n     ucs_assert(UCP_DT_IS_CONTIG(sreq->send.datatype));\n \n-    /* Check if the sender needs to register the send buffer -\n-     * is its datatype contiguous and does the receive side need it */\n-    if (ucp_ep_rndv_md_flags(ep, 0) & UCT_MD_FLAG_NEED_RKEY) {\n-        status = ucp_request_rndv_buffer_reg(sreq);\n-        ucs_assert_always(status == UCS_OK);\n+    *cnt   = 0;\n+    packet = 1; /* packet at least counter */","path":"src/ucp/tag/rndv.c","position":123,"original_position":123,"commit_id":"9d4a3a8f3155a9b5c20d3c9a5f8948e09ba59301","original_commit_id":"9d4a3a8f3155a9b5c20d3c9a5f8948e09ba59301","user":{"login":"brminich","id":14221180,"avatar_url":"https://avatars1.githubusercontent.com/u/14221180?v=4","gravatar_id":"","url":"https://api.github.com/users/brminich","html_url":"https://github.com/brminich","followers_url":"https://api.github.com/users/brminich/followers","following_url":"https://api.github.com/users/brminich/following{/other_user}","gists_url":"https://api.github.com/users/brminich/gists{/gist_id}","starred_url":"https://api.github.com/users/brminich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brminich/subscriptions","organizations_url":"https://api.github.com/users/brminich/orgs","repos_url":"https://api.github.com/users/brminich/repos","events_url":"https://api.github.com/users/brminich/events{/privacy}","received_events_url":"https://api.github.com/users/brminich/received_events","type":"User","site_admin":false},"body":"do you mean `packet_len` or `packed`? Just `packet` looks misleading","created_at":"2017-12-04T11:20:56Z","updated_at":"2017-12-04T11:46:04Z","html_url":"https://github.com/openucx/ucx/pull/2010#discussion_r154621004","pull_request_url":"https://api.github.com/repos/openucx/ucx/pulls/2010","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/openucx/ucx/pulls/comments/154621004"},"html":{"href":"https://github.com/openucx/ucx/pull/2010#discussion_r154621004"},"pull_request":{"href":"https://api.github.com/repos/openucx/ucx/pulls/2010"}}},"pull_request":{"url":"https://api.github.com/repos/openucx/ucx/pulls/2010","id":154855380,"html_url":"https://github.com/openucx/ucx/pull/2010","diff_url":"https://github.com/openucx/ucx/pull/2010.diff","patch_url":"https://github.com/openucx/ucx/pull/2010.patch","issue_url":"https://api.github.com/repos/openucx/ucx/issues/2010","number":2010,"state":"open","locked":false,"title":"UCP/RNDV: pack rkey together with memory domain id","user":{"login":"hoopoepg","id":2535990,"avatar_url":"https://avatars0.githubusercontent.com/u/2535990?v=4","gravatar_id":"","url":"https://api.github.com/users/hoopoepg","html_url":"https://github.com/hoopoepg","followers_url":"https://api.github.com/users/hoopoepg/followers","following_url":"https://api.github.com/users/hoopoepg/following{/other_user}","gists_url":"https://api.github.com/users/hoopoepg/gists{/gist_id}","starred_url":"https://api.github.com/users/hoopoepg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hoopoepg/subscriptions","organizations_url":"https://api.github.com/users/hoopoepg/orgs","repos_url":"https://api.github.com/users/hoopoepg/repos","events_url":"https://api.github.com/users/hoopoepg/events{/privacy}","received_events_url":"https://api.github.com/users/hoopoepg/received_events","type":"User","site_admin":false},"body":"- added info about memory domain & rkey size\r\n- update fallback from HW tag offloading to SW rndv\r\n- updated is_get_op_possible calls to check ability\r\n  to rndv/get more accurate\r\n\r\nNOTE: this PR will conflict with https://github.com/openucx/ucx/pull/2008, let's merge https://github.com/openucx/ucx/pull/2008 first\r\n","created_at":"2017-11-27T16:28:48Z","updated_at":"2017-12-04T11:46:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e84de482ab896081cd11bd4e751167157da69c9c","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/openucx/ucx/pulls/2010/commits","review_comments_url":"https://api.github.com/repos/openucx/ucx/pulls/2010/comments","review_comment_url":"https://api.github.com/repos/openucx/ucx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openucx/ucx/issues/2010/comments","statuses_url":"https://api.github.com/repos/openucx/ucx/statuses/9d4a3a8f3155a9b5c20d3c9a5f8948e09ba59301","head":{"label":"hoopoepg:topic/is-op-possible","ref":"topic/is-op-possible","sha":"9d4a3a8f3155a9b5c20d3c9a5f8948e09ba59301","user":{"login":"hoopoepg","id":2535990,"avatar_url":"https://avatars0.githubusercontent.com/u/2535990?v=4","gravatar_id":"","url":"https://api.github.com/users/hoopoepg","html_url":"https://github.com/hoopoepg","followers_url":"https://api.github.com/users/hoopoepg/followers","following_url":"https://api.github.com/users/hoopoepg/following{/other_user}","gists_url":"https://api.github.com/users/hoopoepg/gists{/gist_id}","starred_url":"https://api.github.com/users/hoopoepg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hoopoepg/subscriptions","organizations_url":"https://api.github.com/users/hoopoepg/orgs","repos_url":"https://api.github.com/users/hoopoepg/repos","events_url":"https://api.github.com/users/hoopoepg/events{/privacy}","received_events_url":"https://api.github.com/users/hoopoepg/received_events","type":"User","site_admin":false},"repo":{"id":101608204,"name":"ucx","full_name":"hoopoepg/ucx","owner":{"login":"hoopoepg","id":2535990,"avatar_url":"https://avatars0.githubusercontent.com/u/2535990?v=4","gravatar_id":"","url":"https://api.github.com/users/hoopoepg","html_url":"https://github.com/hoopoepg","followers_url":"https://api.github.com/users/hoopoepg/followers","following_url":"https://api.github.com/users/hoopoepg/following{/other_user}","gists_url":"https://api.github.com/users/hoopoepg/gists{/gist_id}","starred_url":"https://api.github.com/users/hoopoepg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hoopoepg/subscriptions","organizations_url":"https://api.github.com/users/hoopoepg/orgs","repos_url":"https://api.github.com/users/hoopoepg/repos","events_url":"https://api.github.com/users/hoopoepg/events{/privacy}","received_events_url":"https://api.github.com/users/hoopoepg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hoopoepg/ucx","description":"Unified Communication X  (mailing list - https://elist.ornl.gov/mailman/listinfo/ucx-group): ","fork":true,"url":"https://api.github.com/repos/hoopoepg/ucx","forks_url":"https://api.github.com/repos/hoopoepg/ucx/forks","keys_url":"https://api.github.com/repos/hoopoepg/ucx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hoopoepg/ucx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hoopoepg/ucx/teams","hooks_url":"https://api.github.com/repos/hoopoepg/ucx/hooks","issue_events_url":"https://api.github.com/repos/hoopoepg/ucx/issues/events{/number}","events_url":"https://api.github.com/repos/hoopoepg/ucx/events","assignees_url":"https://api.github.com/repos/hoopoepg/ucx/assignees{/user}","branches_url":"https://api.github.com/repos/hoopoepg/ucx/branches{/branch}","tags_url":"https://api.github.com/repos/hoopoepg/ucx/tags","blobs_url":"https://api.github.com/repos/hoopoepg/ucx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hoopoepg/ucx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hoopoepg/ucx/git/refs{/sha}","trees_url":"https://api.github.com/repos/hoopoepg/ucx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hoopoepg/ucx/statuses/{sha}","languages_url":"https://api.github.com/repos/hoopoepg/ucx/languages","stargazers_url":"https://api.github.com/repos/hoopoepg/ucx/stargazers","contributors_url":"https://api.github.com/repos/hoopoepg/ucx/contributors","subscribers_url":"https://api.github.com/repos/hoopoepg/ucx/subscribers","subscription_url":"https://api.github.com/repos/hoopoepg/ucx/subscription","commits_url":"https://api.github.com/repos/hoopoepg/ucx/commits{/sha}","git_commits_url":"https://api.github.com/repos/hoopoepg/ucx/git/commits{/sha}","comments_url":"https://api.github.com/repos/hoopoepg/ucx/comments{/number}","issue_comment_url":"https://api.github.com/repos/hoopoepg/ucx/issues/comments{/number}","contents_url":"https://api.github.com/repos/hoopoepg/ucx/contents/{+path}","compare_url":"https://api.github.com/repos/hoopoepg/ucx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hoopoepg/ucx/merges","archive_url":"https://api.github.com/repos/hoopoepg/ucx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hoopoepg/ucx/downloads","issues_url":"https://api.github.com/repos/hoopoepg/ucx/issues{/number}","pulls_url":"https://api.github.com/repos/hoopoepg/ucx/pulls{/number}","milestones_url":"https://api.github.com/repos/hoopoepg/ucx/milestones{/number}","notifications_url":"https://api.github.com/repos/hoopoepg/ucx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hoopoepg/ucx/labels{/name}","releases_url":"https://api.github.com/repos/hoopoepg/ucx/releases{/id}","deployments_url":"https://api.github.com/repos/hoopoepg/ucx/deployments","created_at":"2017-08-28T05:48:53Z","updated_at":"2017-08-28T05:48:57Z","pushed_at":"2017-12-01T09:42:48Z","git_url":"git://github.com/hoopoepg/ucx.git","ssh_url":"git@github.com:hoopoepg/ucx.git","clone_url":"https://github.com/hoopoepg/ucx.git","svn_url":"https://github.com/hoopoepg/ucx","homepage":"http://www.openucx.org","size":10247,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openucx:master","ref":"master","sha":"101cc6a726584f493ca5f88ff03ebdc2866e45bb","user":{"login":"openucx","id":13118737,"avatar_url":"https://avatars2.githubusercontent.com/u/13118737?v=4","gravatar_id":"","url":"https://api.github.com/users/openucx","html_url":"https://github.com/openucx","followers_url":"https://api.github.com/users/openucx/followers","following_url":"https://api.github.com/users/openucx/following{/other_user}","gists_url":"https://api.github.com/users/openucx/gists{/gist_id}","starred_url":"https://api.github.com/users/openucx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openucx/subscriptions","organizations_url":"https://api.github.com/users/openucx/orgs","repos_url":"https://api.github.com/users/openucx/repos","events_url":"https://api.github.com/users/openucx/events{/privacy}","received_events_url":"https://api.github.com/users/openucx/received_events","type":"Organization","site_admin":false},"repo":{"id":25379390,"name":"ucx","full_name":"openucx/ucx","owner":{"login":"openucx","id":13118737,"avatar_url":"https://avatars2.githubusercontent.com/u/13118737?v=4","gravatar_id":"","url":"https://api.github.com/users/openucx","html_url":"https://github.com/openucx","followers_url":"https://api.github.com/users/openucx/followers","following_url":"https://api.github.com/users/openucx/following{/other_user}","gists_url":"https://api.github.com/users/openucx/gists{/gist_id}","starred_url":"https://api.github.com/users/openucx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openucx/subscriptions","organizations_url":"https://api.github.com/users/openucx/orgs","repos_url":"https://api.github.com/users/openucx/repos","events_url":"https://api.github.com/users/openucx/events{/privacy}","received_events_url":"https://api.github.com/users/openucx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openucx/ucx","description":"Unified Communication X  (mailing list - https://elist.ornl.gov/mailman/listinfo/ucx-group): ","fork":false,"url":"https://api.github.com/repos/openucx/ucx","forks_url":"https://api.github.com/repos/openucx/ucx/forks","keys_url":"https://api.github.com/repos/openucx/ucx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openucx/ucx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openucx/ucx/teams","hooks_url":"https://api.github.com/repos/openucx/ucx/hooks","issue_events_url":"https://api.github.com/repos/openucx/ucx/issues/events{/number}","events_url":"https://api.github.com/repos/openucx/ucx/events","assignees_url":"https://api.github.com/repos/openucx/ucx/assignees{/user}","branches_url":"https://api.github.com/repos/openucx/ucx/branches{/branch}","tags_url":"https://api.github.com/repos/openucx/ucx/tags","blobs_url":"https://api.github.com/repos/openucx/ucx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openucx/ucx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openucx/ucx/git/refs{/sha}","trees_url":"https://api.github.com/repos/openucx/ucx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openucx/ucx/statuses/{sha}","languages_url":"https://api.github.com/repos/openucx/ucx/languages","stargazers_url":"https://api.github.com/repos/openucx/ucx/stargazers","contributors_url":"https://api.github.com/repos/openucx/ucx/contributors","subscribers_url":"https://api.github.com/repos/openucx/ucx/subscribers","subscription_url":"https://api.github.com/repos/openucx/ucx/subscription","commits_url":"https://api.github.com/repos/openucx/ucx/commits{/sha}","git_commits_url":"https://api.github.com/repos/openucx/ucx/git/commits{/sha}","comments_url":"https://api.github.com/repos/openucx/ucx/comments{/number}","issue_comment_url":"https://api.github.com/repos/openucx/ucx/issues/comments{/number}","contents_url":"https://api.github.com/repos/openucx/ucx/contents/{+path}","compare_url":"https://api.github.com/repos/openucx/ucx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openucx/ucx/merges","archive_url":"https://api.github.com/repos/openucx/ucx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openucx/ucx/downloads","issues_url":"https://api.github.com/repos/openucx/ucx/issues{/number}","pulls_url":"https://api.github.com/repos/openucx/ucx/pulls{/number}","milestones_url":"https://api.github.com/repos/openucx/ucx/milestones{/number}","notifications_url":"https://api.github.com/repos/openucx/ucx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openucx/ucx/labels{/name}","releases_url":"https://api.github.com/repos/openucx/ucx/releases{/id}","deployments_url":"https://api.github.com/repos/openucx/ucx/deployments","created_at":"2014-10-17T22:17:24Z","updated_at":"2017-11-30T04:59:33Z","pushed_at":"2017-12-04T07:34:26Z","git_url":"git://github.com/openucx/ucx.git","ssh_url":"git@github.com:openucx/ucx.git","clone_url":"https://github.com/openucx/ucx.git","svn_url":"https://github.com/openucx/ucx","homepage":"http://www.openucx.org","size":10258,"stargazers_count":88,"watchers_count":88,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":65,"mirror_url":null,"archived":false,"open_issues_count":143,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":65,"open_issues":143,"watchers":88,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openucx/ucx/pulls/2010"},"html":{"href":"https://github.com/openucx/ucx/pull/2010"},"issue":{"href":"https://api.github.com/repos/openucx/ucx/issues/2010"},"comments":{"href":"https://api.github.com/repos/openucx/ucx/issues/2010/comments"},"review_comments":{"href":"https://api.github.com/repos/openucx/ucx/pulls/2010/comments"},"review_comment":{"href":"https://api.github.com/repos/openucx/ucx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openucx/ucx/pulls/2010/commits"},"statuses":{"href":"https://api.github.com/repos/openucx/ucx/statuses/9d4a3a8f3155a9b5c20d3c9a5f8948e09ba59301"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"brminich"}}