{"action":"created","comment":{"url":"https://api.github.com/repos/hyperoslo/Spots/pulls/comments/116420690","pull_request_review_id":38039712,"id":116420690,"diff_hunk":"@@ -2,6 +2,8 @@ import Foundation\n \n public class ComponentManager {\n \n+  var itemManager: ItemManager = ItemManager()","path":"Sources/Shared/Classes/ComponentManager.swift","position":4,"original_position":4,"commit_id":"c297e4471103c959ba1df242e1f3fc903e3ae3c6","original_commit_id":"c297e4471103c959ba1df242e1f3fc903e3ae3c6","user":{"login":"onmyway133","id":2284279,"avatar_url":"https://avatars2.githubusercontent.com/u/2284279?v=3","gravatar_id":"","url":"https://api.github.com/users/onmyway133","html_url":"https://github.com/onmyway133","followers_url":"https://api.github.com/users/onmyway133/followers","following_url":"https://api.github.com/users/onmyway133/following{/other_user}","gists_url":"https://api.github.com/users/onmyway133/gists{/gist_id}","starred_url":"https://api.github.com/users/onmyway133/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onmyway133/subscriptions","organizations_url":"https://api.github.com/users/onmyway133/orgs","repos_url":"https://api.github.com/users/onmyway133/repos","events_url":"https://api.github.com/users/onmyway133/events{/privacy}","received_events_url":"https://api.github.com/users/onmyway133/received_events","type":"User","site_admin":false},"body":"why `var` 🤔 ","created_at":"2017-05-15T06:53:31Z","updated_at":"2017-05-15T06:53:31Z","html_url":"https://github.com/hyperoslo/Spots/pull/610#discussion_r116420690","pull_request_url":"https://api.github.com/repos/hyperoslo/Spots/pulls/610","_links":{"self":{"href":"https://api.github.com/repos/hyperoslo/Spots/pulls/comments/116420690"},"html":{"href":"https://github.com/hyperoslo/Spots/pull/610#discussion_r116420690"},"pull_request":{"href":"https://api.github.com/repos/hyperoslo/Spots/pulls/610"}}},"pull_request":{"url":"https://api.github.com/repos/hyperoslo/Spots/pulls/610","id":120440975,"html_url":"https://github.com/hyperoslo/Spots/pull/610","diff_url":"https://github.com/hyperoslo/Spots/pull/610.diff","patch_url":"https://github.com/hyperoslo/Spots/pull/610.patch","issue_url":"https://api.github.com/repos/hyperoslo/Spots/issues/610","number":610,"state":"open","locked":false,"title":"Move item preparation methods into a new ItemManager class","user":{"login":"zenangst","id":57446,"avatar_url":"https://avatars2.githubusercontent.com/u/57446?v=3","gravatar_id":"","url":"https://api.github.com/users/zenangst","html_url":"https://github.com/zenangst","followers_url":"https://api.github.com/users/zenangst/followers","following_url":"https://api.github.com/users/zenangst/following{/other_user}","gists_url":"https://api.github.com/users/zenangst/gists{/gist_id}","starred_url":"https://api.github.com/users/zenangst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zenangst/subscriptions","organizations_url":"https://api.github.com/users/zenangst/orgs","repos_url":"https://api.github.com/users/zenangst/repos","events_url":"https://api.github.com/users/zenangst/events{/privacy}","received_events_url":"https://api.github.com/users/zenangst/received_events","type":"User","site_admin":false},"body":"Reduces the magic located on the Component+Core protocol extension by moving all item preparation and size calculation methods into a new class called `ItemManager`. It resides on `ComponentManager` and is used to set sizes on component model items.","created_at":"2017-05-13T08:55:10Z","updated_at":"2017-05-15T06:53:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f3a25bd6086b35b503e88a47d2b32fea5befa8cb","assignee":null,"assignees":[],"requested_reviewers":[{"login":"JohnSundell","id":2466701,"avatar_url":"https://avatars0.githubusercontent.com/u/2466701?v=3","gravatar_id":"","url":"https://api.github.com/users/JohnSundell","html_url":"https://github.com/JohnSundell","followers_url":"https://api.github.com/users/JohnSundell/followers","following_url":"https://api.github.com/users/JohnSundell/following{/other_user}","gists_url":"https://api.github.com/users/JohnSundell/gists{/gist_id}","starred_url":"https://api.github.com/users/JohnSundell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohnSundell/subscriptions","organizations_url":"https://api.github.com/users/JohnSundell/orgs","repos_url":"https://api.github.com/users/JohnSundell/repos","events_url":"https://api.github.com/users/JohnSundell/events{/privacy}","received_events_url":"https://api.github.com/users/JohnSundell/received_events","type":"User","site_admin":false},{"login":"vadymmarkov","id":10529867,"avatar_url":"https://avatars3.githubusercontent.com/u/10529867?v=3","gravatar_id":"","url":"https://api.github.com/users/vadymmarkov","html_url":"https://github.com/vadymmarkov","followers_url":"https://api.github.com/users/vadymmarkov/followers","following_url":"https://api.github.com/users/vadymmarkov/following{/other_user}","gists_url":"https://api.github.com/users/vadymmarkov/gists{/gist_id}","starred_url":"https://api.github.com/users/vadymmarkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vadymmarkov/subscriptions","organizations_url":"https://api.github.com/users/vadymmarkov/orgs","repos_url":"https://api.github.com/users/vadymmarkov/repos","events_url":"https://api.github.com/users/vadymmarkov/events{/privacy}","received_events_url":"https://api.github.com/users/vadymmarkov/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/hyperoslo/Spots/pulls/610/commits","review_comments_url":"https://api.github.com/repos/hyperoslo/Spots/pulls/610/comments","review_comment_url":"https://api.github.com/repos/hyperoslo/Spots/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hyperoslo/Spots/issues/610/comments","statuses_url":"https://api.github.com/repos/hyperoslo/Spots/statuses/c297e4471103c959ba1df242e1f3fc903e3ae3c6","head":{"label":"zenangst:refactor/component-extension-into-item-manager","ref":"refactor/component-extension-into-item-manager","sha":"c297e4471103c959ba1df242e1f3fc903e3ae3c6","user":{"login":"zenangst","id":57446,"avatar_url":"https://avatars2.githubusercontent.com/u/57446?v=3","gravatar_id":"","url":"https://api.github.com/users/zenangst","html_url":"https://github.com/zenangst","followers_url":"https://api.github.com/users/zenangst/followers","following_url":"https://api.github.com/users/zenangst/following{/other_user}","gists_url":"https://api.github.com/users/zenangst/gists{/gist_id}","starred_url":"https://api.github.com/users/zenangst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zenangst/subscriptions","organizations_url":"https://api.github.com/users/zenangst/orgs","repos_url":"https://api.github.com/users/zenangst/repos","events_url":"https://api.github.com/users/zenangst/events{/privacy}","received_events_url":"https://api.github.com/users/zenangst/received_events","type":"User","site_admin":false},"repo":{"id":81560557,"name":"Spots","full_name":"zenangst/Spots","owner":{"login":"zenangst","id":57446,"avatar_url":"https://avatars2.githubusercontent.com/u/57446?v=3","gravatar_id":"","url":"https://api.github.com/users/zenangst","html_url":"https://github.com/zenangst","followers_url":"https://api.github.com/users/zenangst/followers","following_url":"https://api.github.com/users/zenangst/following{/other_user}","gists_url":"https://api.github.com/users/zenangst/gists{/gist_id}","starred_url":"https://api.github.com/users/zenangst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zenangst/subscriptions","organizations_url":"https://api.github.com/users/zenangst/orgs","repos_url":"https://api.github.com/users/zenangst/repos","events_url":"https://api.github.com/users/zenangst/events{/privacy}","received_events_url":"https://api.github.com/users/zenangst/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zenangst/Spots","description":":bamboo: Spots is a cross-platform view controller framework for building component-based UIs","fork":true,"url":"https://api.github.com/repos/zenangst/Spots","forks_url":"https://api.github.com/repos/zenangst/Spots/forks","keys_url":"https://api.github.com/repos/zenangst/Spots/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zenangst/Spots/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zenangst/Spots/teams","hooks_url":"https://api.github.com/repos/zenangst/Spots/hooks","issue_events_url":"https://api.github.com/repos/zenangst/Spots/issues/events{/number}","events_url":"https://api.github.com/repos/zenangst/Spots/events","assignees_url":"https://api.github.com/repos/zenangst/Spots/assignees{/user}","branches_url":"https://api.github.com/repos/zenangst/Spots/branches{/branch}","tags_url":"https://api.github.com/repos/zenangst/Spots/tags","blobs_url":"https://api.github.com/repos/zenangst/Spots/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zenangst/Spots/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zenangst/Spots/git/refs{/sha}","trees_url":"https://api.github.com/repos/zenangst/Spots/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zenangst/Spots/statuses/{sha}","languages_url":"https://api.github.com/repos/zenangst/Spots/languages","stargazers_url":"https://api.github.com/repos/zenangst/Spots/stargazers","contributors_url":"https://api.github.com/repos/zenangst/Spots/contributors","subscribers_url":"https://api.github.com/repos/zenangst/Spots/subscribers","subscription_url":"https://api.github.com/repos/zenangst/Spots/subscription","commits_url":"https://api.github.com/repos/zenangst/Spots/commits{/sha}","git_commits_url":"https://api.github.com/repos/zenangst/Spots/git/commits{/sha}","comments_url":"https://api.github.com/repos/zenangst/Spots/comments{/number}","issue_comment_url":"https://api.github.com/repos/zenangst/Spots/issues/comments{/number}","contents_url":"https://api.github.com/repos/zenangst/Spots/contents/{+path}","compare_url":"https://api.github.com/repos/zenangst/Spots/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zenangst/Spots/merges","archive_url":"https://api.github.com/repos/zenangst/Spots/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zenangst/Spots/downloads","issues_url":"https://api.github.com/repos/zenangst/Spots/issues{/number}","pulls_url":"https://api.github.com/repos/zenangst/Spots/pulls{/number}","milestones_url":"https://api.github.com/repos/zenangst/Spots/milestones{/number}","notifications_url":"https://api.github.com/repos/zenangst/Spots/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zenangst/Spots/labels{/name}","releases_url":"https://api.github.com/repos/zenangst/Spots/releases{/id}","deployments_url":"https://api.github.com/repos/zenangst/Spots/deployments","created_at":"2017-02-10T11:51:01Z","updated_at":"2017-02-10T11:51:03Z","pushed_at":"2017-05-13T08:54:32Z","git_url":"git://github.com/zenangst/Spots.git","ssh_url":"git@github.com:zenangst/Spots.git","clone_url":"https://github.com/zenangst/Spots.git","svn_url":"https://github.com/zenangst/Spots","homepage":"","size":34315,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hyperoslo:master","ref":"master","sha":"064376dda32028ab304fd4d3cf1d899fc3914da9","user":{"login":"hyperoslo","id":1340892,"avatar_url":"https://avatars0.githubusercontent.com/u/1340892?v=3","gravatar_id":"","url":"https://api.github.com/users/hyperoslo","html_url":"https://github.com/hyperoslo","followers_url":"https://api.github.com/users/hyperoslo/followers","following_url":"https://api.github.com/users/hyperoslo/following{/other_user}","gists_url":"https://api.github.com/users/hyperoslo/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperoslo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperoslo/subscriptions","organizations_url":"https://api.github.com/users/hyperoslo/orgs","repos_url":"https://api.github.com/users/hyperoslo/repos","events_url":"https://api.github.com/users/hyperoslo/events{/privacy}","received_events_url":"https://api.github.com/users/hyperoslo/received_events","type":"Organization","site_admin":false},"repo":{"id":43603611,"name":"Spots","full_name":"hyperoslo/Spots","owner":{"login":"hyperoslo","id":1340892,"avatar_url":"https://avatars0.githubusercontent.com/u/1340892?v=3","gravatar_id":"","url":"https://api.github.com/users/hyperoslo","html_url":"https://github.com/hyperoslo","followers_url":"https://api.github.com/users/hyperoslo/followers","following_url":"https://api.github.com/users/hyperoslo/following{/other_user}","gists_url":"https://api.github.com/users/hyperoslo/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperoslo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperoslo/subscriptions","organizations_url":"https://api.github.com/users/hyperoslo/orgs","repos_url":"https://api.github.com/users/hyperoslo/repos","events_url":"https://api.github.com/users/hyperoslo/events{/privacy}","received_events_url":"https://api.github.com/users/hyperoslo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hyperoslo/Spots","description":":bamboo: Spots is a cross-platform view controller framework for building component-based UIs","fork":false,"url":"https://api.github.com/repos/hyperoslo/Spots","forks_url":"https://api.github.com/repos/hyperoslo/Spots/forks","keys_url":"https://api.github.com/repos/hyperoslo/Spots/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyperoslo/Spots/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyperoslo/Spots/teams","hooks_url":"https://api.github.com/repos/hyperoslo/Spots/hooks","issue_events_url":"https://api.github.com/repos/hyperoslo/Spots/issues/events{/number}","events_url":"https://api.github.com/repos/hyperoslo/Spots/events","assignees_url":"https://api.github.com/repos/hyperoslo/Spots/assignees{/user}","branches_url":"https://api.github.com/repos/hyperoslo/Spots/branches{/branch}","tags_url":"https://api.github.com/repos/hyperoslo/Spots/tags","blobs_url":"https://api.github.com/repos/hyperoslo/Spots/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyperoslo/Spots/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyperoslo/Spots/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyperoslo/Spots/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyperoslo/Spots/statuses/{sha}","languages_url":"https://api.github.com/repos/hyperoslo/Spots/languages","stargazers_url":"https://api.github.com/repos/hyperoslo/Spots/stargazers","contributors_url":"https://api.github.com/repos/hyperoslo/Spots/contributors","subscribers_url":"https://api.github.com/repos/hyperoslo/Spots/subscribers","subscription_url":"https://api.github.com/repos/hyperoslo/Spots/subscription","commits_url":"https://api.github.com/repos/hyperoslo/Spots/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyperoslo/Spots/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyperoslo/Spots/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyperoslo/Spots/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyperoslo/Spots/contents/{+path}","compare_url":"https://api.github.com/repos/hyperoslo/Spots/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyperoslo/Spots/merges","archive_url":"https://api.github.com/repos/hyperoslo/Spots/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyperoslo/Spots/downloads","issues_url":"https://api.github.com/repos/hyperoslo/Spots/issues{/number}","pulls_url":"https://api.github.com/repos/hyperoslo/Spots/pulls{/number}","milestones_url":"https://api.github.com/repos/hyperoslo/Spots/milestones{/number}","notifications_url":"https://api.github.com/repos/hyperoslo/Spots/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyperoslo/Spots/labels{/name}","releases_url":"https://api.github.com/repos/hyperoslo/Spots/releases{/id}","deployments_url":"https://api.github.com/repos/hyperoslo/Spots/deployments","created_at":"2015-10-03T15:28:33Z","updated_at":"2017-05-15T03:33:58Z","pushed_at":"2017-05-13T08:55:11Z","git_url":"git://github.com/hyperoslo/Spots.git","ssh_url":"git@github.com:hyperoslo/Spots.git","clone_url":"https://github.com/hyperoslo/Spots.git","svn_url":"https://github.com/hyperoslo/Spots","homepage":"","size":34214,"stargazers_count":1077,"watchers_count":1077,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":49,"mirror_url":null,"open_issues_count":9,"forks":49,"open_issues":9,"watchers":1077,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hyperoslo/Spots/pulls/610"},"html":{"href":"https://github.com/hyperoslo/Spots/pull/610"},"issue":{"href":"https://api.github.com/repos/hyperoslo/Spots/issues/610"},"comments":{"href":"https://api.github.com/repos/hyperoslo/Spots/issues/610/comments"},"review_comments":{"href":"https://api.github.com/repos/hyperoslo/Spots/pulls/610/comments"},"review_comment":{"href":"https://api.github.com/repos/hyperoslo/Spots/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hyperoslo/Spots/pulls/610/commits"},"statuses":{"href":"https://api.github.com/repos/hyperoslo/Spots/statuses/c297e4471103c959ba1df242e1f3fc903e3ae3c6"}}}}
{"actor":{"display_login":"onmyway133"}}