{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/pulls/comments/130703007","pull_request_review_id":53608154,"id":130703007,"diff_hunk":"@@ -32,10 +32,15 @@ class BrowserTests: KIFTestCase {\n         \n         // Show share sheet and wait for the JS prompt to fire\n         EarlGrey.select(elementWithMatcher: grey_accessibilityLabel(\"Share\")).perform(grey_tap())\n-        let matcher = grey_allOf([grey_accessibilityLabel(\"Cancel\"),\n-                                          grey_accessibilityTrait(UIAccessibilityTraitButton),\n-                                          grey_sufficientlyVisible()])\n-        EarlGrey.select(elementWithMatcher: matcher).perform(grey_tap())\n+        \n+        if BrowserUtils.iPad() {\n+            EarlGrey.select(elementWithMatcher: grey_accessibilityLabel(\"Share\")).perform(grey_tap())","path":"UITests/BrowserTests.swift","position":10,"original_position":10,"commit_id":"dd96531b31a7e0c43f4484526cd499ba35035a37","original_commit_id":"dd96531b31a7e0c43f4484526cd499ba35035a37","user":{"login":"npark-mozilla","id":6930774,"avatar_url":"https://avatars1.githubusercontent.com/u/6930774?v=4","gravatar_id":"","url":"https://api.github.com/users/npark-mozilla","html_url":"https://github.com/npark-mozilla","followers_url":"https://api.github.com/users/npark-mozilla/followers","following_url":"https://api.github.com/users/npark-mozilla/following{/other_user}","gists_url":"https://api.github.com/users/npark-mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/npark-mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/npark-mozilla/subscriptions","organizations_url":"https://api.github.com/users/npark-mozilla/orgs","repos_url":"https://api.github.com/users/npark-mozilla/repos","events_url":"https://api.github.com/users/npark-mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/npark-mozilla/received_events","type":"User","site_admin":false},"body":"Oh, it's because there is no cancel button on ipad, simplest way to get rid of the menu was to tap it again","created_at":"2017-08-01T19:21:31Z","updated_at":"2017-08-01T19:21:31Z","html_url":"https://github.com/mozilla-mobile/firefox-ios/pull/2990#discussion_r130703007","pull_request_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/pulls/2990","_links":{"self":{"href":"https://api.github.com/repos/mozilla-mobile/firefox-ios/pulls/comments/130703007"},"html":{"href":"https://github.com/mozilla-mobile/firefox-ios/pull/2990#discussion_r130703007"},"pull_request":{"href":"https://api.github.com/repos/mozilla-mobile/firefox-ios/pulls/2990"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/pulls/2990","id":133116549,"html_url":"https://github.com/mozilla-mobile/firefox-ios/pull/2990","diff_url":"https://github.com/mozilla-mobile/firefox-ios/pull/2990.diff","patch_url":"https://github.com/mozilla-mobile/firefox-ios/pull/2990.patch","issue_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/issues/2990","number":2990,"state":"open","locked":false,"title":"Bug 1385663 - Make UITest run on iPad as well","user":{"login":"npark-mozilla","id":6930774,"avatar_url":"https://avatars1.githubusercontent.com/u/6930774?v=4","gravatar_id":"","url":"https://api.github.com/users/npark-mozilla","html_url":"https://github.com/npark-mozilla","followers_url":"https://api.github.com/users/npark-mozilla/followers","following_url":"https://api.github.com/users/npark-mozilla/following{/other_user}","gists_url":"https://api.github.com/users/npark-mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/npark-mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/npark-mozilla/subscriptions","organizations_url":"https://api.github.com/users/npark-mozilla/orgs","repos_url":"https://api.github.com/users/npark-mozilla/repos","events_url":"https://api.github.com/users/npark-mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/npark-mozilla/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-07-30T05:07:18Z","updated_at":"2017-08-01T19:21:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0a27cf6d558e4d63568770a2723832152ee38630","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/pulls/2990/commits","review_comments_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/pulls/2990/comments","review_comment_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/issues/2990/comments","statuses_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/statuses/dd96531b31a7e0c43f4484526cd499ba35035a37","head":{"label":"mozilla-mobile:npark-mozilla/tryipad","ref":"npark-mozilla/tryipad","sha":"dd96531b31a7e0c43f4484526cd499ba35035a37","user":{"login":"mozilla-mobile","id":22351667,"avatar_url":"https://avatars3.githubusercontent.com/u/22351667?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla-mobile","html_url":"https://github.com/mozilla-mobile","followers_url":"https://api.github.com/users/mozilla-mobile/followers","following_url":"https://api.github.com/users/mozilla-mobile/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-mobile/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-mobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-mobile/subscriptions","organizations_url":"https://api.github.com/users/mozilla-mobile/orgs","repos_url":"https://api.github.com/users/mozilla-mobile/repos","events_url":"https://api.github.com/users/mozilla-mobile/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-mobile/received_events","type":"Organization","site_admin":false},"repo":{"id":26133979,"name":"firefox-ios","full_name":"mozilla-mobile/firefox-ios","owner":{"login":"mozilla-mobile","id":22351667,"avatar_url":"https://avatars3.githubusercontent.com/u/22351667?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla-mobile","html_url":"https://github.com/mozilla-mobile","followers_url":"https://api.github.com/users/mozilla-mobile/followers","following_url":"https://api.github.com/users/mozilla-mobile/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-mobile/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-mobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-mobile/subscriptions","organizations_url":"https://api.github.com/users/mozilla-mobile/orgs","repos_url":"https://api.github.com/users/mozilla-mobile/repos","events_url":"https://api.github.com/users/mozilla-mobile/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-mobile/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-mobile/firefox-ios","description":"Firefox for iOS","fork":false,"url":"https://api.github.com/repos/mozilla-mobile/firefox-ios","forks_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/forks","keys_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/teams","hooks_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/hooks","issue_events_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/events","assignees_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/tags","blobs_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/languages","stargazers_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/stargazers","contributors_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/contributors","subscribers_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/subscribers","subscription_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/subscription","commits_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/merges","archive_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/downloads","issues_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/deployments","created_at":"2014-11-03T19:07:02Z","updated_at":"2017-08-01T17:34:21Z","pushed_at":"2017-08-01T18:49:10Z","git_url":"git://github.com/mozilla-mobile/firefox-ios.git","ssh_url":"git@github.com:mozilla-mobile/firefox-ios.git","clone_url":"https://github.com/mozilla-mobile/firefox-ios.git","svn_url":"https://github.com/mozilla-mobile/firefox-ios","homepage":"","size":443272,"stargazers_count":7322,"watchers_count":7322,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1547,"mirror_url":null,"open_issues_count":49,"forks":1547,"open_issues":49,"watchers":7322,"default_branch":"master"}},"base":{"label":"mozilla-mobile:master","ref":"master","sha":"6736009d74e91bb8837ce81016b622e814c9a0b8","user":{"login":"mozilla-mobile","id":22351667,"avatar_url":"https://avatars3.githubusercontent.com/u/22351667?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla-mobile","html_url":"https://github.com/mozilla-mobile","followers_url":"https://api.github.com/users/mozilla-mobile/followers","following_url":"https://api.github.com/users/mozilla-mobile/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-mobile/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-mobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-mobile/subscriptions","organizations_url":"https://api.github.com/users/mozilla-mobile/orgs","repos_url":"https://api.github.com/users/mozilla-mobile/repos","events_url":"https://api.github.com/users/mozilla-mobile/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-mobile/received_events","type":"Organization","site_admin":false},"repo":{"id":26133979,"name":"firefox-ios","full_name":"mozilla-mobile/firefox-ios","owner":{"login":"mozilla-mobile","id":22351667,"avatar_url":"https://avatars3.githubusercontent.com/u/22351667?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla-mobile","html_url":"https://github.com/mozilla-mobile","followers_url":"https://api.github.com/users/mozilla-mobile/followers","following_url":"https://api.github.com/users/mozilla-mobile/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-mobile/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-mobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-mobile/subscriptions","organizations_url":"https://api.github.com/users/mozilla-mobile/orgs","repos_url":"https://api.github.com/users/mozilla-mobile/repos","events_url":"https://api.github.com/users/mozilla-mobile/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-mobile/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-mobile/firefox-ios","description":"Firefox for iOS","fork":false,"url":"https://api.github.com/repos/mozilla-mobile/firefox-ios","forks_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/forks","keys_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/teams","hooks_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/hooks","issue_events_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/events","assignees_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/tags","blobs_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/languages","stargazers_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/stargazers","contributors_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/contributors","subscribers_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/subscribers","subscription_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/subscription","commits_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/merges","archive_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/downloads","issues_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla-mobile/firefox-ios/deployments","created_at":"2014-11-03T19:07:02Z","updated_at":"2017-08-01T17:34:21Z","pushed_at":"2017-08-01T18:49:10Z","git_url":"git://github.com/mozilla-mobile/firefox-ios.git","ssh_url":"git@github.com:mozilla-mobile/firefox-ios.git","clone_url":"https://github.com/mozilla-mobile/firefox-ios.git","svn_url":"https://github.com/mozilla-mobile/firefox-ios","homepage":"","size":443272,"stargazers_count":7322,"watchers_count":7322,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1547,"mirror_url":null,"open_issues_count":49,"forks":1547,"open_issues":49,"watchers":7322,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-mobile/firefox-ios/pulls/2990"},"html":{"href":"https://github.com/mozilla-mobile/firefox-ios/pull/2990"},"issue":{"href":"https://api.github.com/repos/mozilla-mobile/firefox-ios/issues/2990"},"comments":{"href":"https://api.github.com/repos/mozilla-mobile/firefox-ios/issues/2990/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-mobile/firefox-ios/pulls/2990/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-mobile/firefox-ios/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla-mobile/firefox-ios/pulls/2990/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-mobile/firefox-ios/statuses/dd96531b31a7e0c43f4484526cd499ba35035a37"}}}}
{"actor":{"display_login":"npark-mozilla"}}