{"action":"created","comment":{"url":"https://api.github.com/repos/apache/metamodel/pulls/comments/132087025","pull_request_review_id":55130210,"id":132087025,"diff_hunk":"@@ -18,29 +18,47 @@ specific language governing permissions and limitations\n under the License.\n -->\n <!DOCTYPE module PUBLIC\n-    \"-//Puppy Crawl//DTD Check Configuration 1.2//EN\"\n-    \"http://www.puppycrawl.com/dtds/configuration_1_2.dtd\">\n+        \"-//Puppy Crawl//DTD Check Configuration 1.2//EN\"\n+        \"http://www.puppycrawl.com/dtds/configuration_1_2.dtd\">\n \n <module name=\"Checker\">\n-\t<module name=\"SuppressionFilter\">\n-    <property name=\"file\" value=\"style/checkstyle_suppressions.xml\"/>\n-\t</module>\n+    <module name=\"SuppressionFilter\">\n+        <property name=\"file\" value=\"style/checkstyle_suppressions.xml\"/>\n+    </module>\n \n-\t<module name=\"Header\">\n-\t    <property name=\"headerFile\" value=\"style/licence_header.txt\"/>\n-\t    <property name=\"fileExtensions\" value=\"java\"/>\n-\t</module>\n+    <module name=\"Header\">\n+        <property name=\"headerFile\" value=\"style/licence_header.txt\"/>\n+        <property name=\"fileExtensions\" value=\"java\"/>\n+    </module>\n+    \n+    <module name=\"FileTabCharacter\">","path":"style/checkstyle.xml","position":34,"original_position":26,"commit_id":"23a7ad378aa115d2a95758a322b6235f228e629b","original_commit_id":"23a7ad378aa115d2a95758a322b6235f228e629b","user":{"login":"kaspersorensen","id":291450,"avatar_url":"https://avatars3.githubusercontent.com/u/291450?v=4","gravatar_id":"","url":"https://api.github.com/users/kaspersorensen","html_url":"https://github.com/kaspersorensen","followers_url":"https://api.github.com/users/kaspersorensen/followers","following_url":"https://api.github.com/users/kaspersorensen/following{/other_user}","gists_url":"https://api.github.com/users/kaspersorensen/gists{/gist_id}","starred_url":"https://api.github.com/users/kaspersorensen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaspersorensen/subscriptions","organizations_url":"https://api.github.com/users/kaspersorensen/orgs","repos_url":"https://api.github.com/users/kaspersorensen/repos","events_url":"https://api.github.com/users/kaspersorensen/events{/privacy}","received_events_url":"https://api.github.com/users/kaspersorensen/received_events","type":"User","site_admin":false},"body":"Cool, but now the build fails then so somehow we need to fix it. Either you go ahead and fix it (you certainly have my blessing) or we comment out this rule and make it a separate issue to fix.","created_at":"2017-08-09T04:12:30Z","updated_at":"2017-08-09T04:12:30Z","html_url":"https://github.com/apache/metamodel/pull/156#discussion_r132087025","pull_request_url":"https://api.github.com/repos/apache/metamodel/pulls/156","_links":{"self":{"href":"https://api.github.com/repos/apache/metamodel/pulls/comments/132087025"},"html":{"href":"https://github.com/apache/metamodel/pull/156#discussion_r132087025"},"pull_request":{"href":"https://api.github.com/repos/apache/metamodel/pulls/156"}}},"pull_request":{"url":"https://api.github.com/repos/apache/metamodel/pulls/156","id":134424295,"html_url":"https://github.com/apache/metamodel/pull/156","diff_url":"https://github.com/apache/metamodel/pull/156.diff","patch_url":"https://github.com/apache/metamodel/pull/156.patch","issue_url":"https://api.github.com/repos/apache/metamodel/issues/156","number":156,"state":"open","locked":false,"title":"Checkstyle integration","user":{"login":"tomatophantastico","id":1636462,"avatar_url":"https://avatars0.githubusercontent.com/u/1636462?v=4","gravatar_id":"","url":"https://api.github.com/users/tomatophantastico","html_url":"https://github.com/tomatophantastico","followers_url":"https://api.github.com/users/tomatophantastico/followers","following_url":"https://api.github.com/users/tomatophantastico/following{/other_user}","gists_url":"https://api.github.com/users/tomatophantastico/gists{/gist_id}","starred_url":"https://api.github.com/users/tomatophantastico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomatophantastico/subscriptions","organizations_url":"https://api.github.com/users/tomatophantastico/orgs","repos_url":"https://api.github.com/users/tomatophantastico/repos","events_url":"https://api.github.com/users/tomatophantastico/events{/privacy}","received_events_url":"https://api.github.com/users/tomatophantastico/received_events","type":"User","site_admin":false},"body":"Integrates checkstyle into the maven test phase: so when ever mvn test is called, checkstyle is run and fails on violations.\r\n\r\nThis should be subject to discussion, especially with more controversial code styling rules (tabs/spaces anyone?)\r\n\r\nI only activated three rules:\r\n\r\nunused imports -> self-explanatory\r\nimport order -> enforce eclipse ordering, therefore smaller commits, when using different IDEs\r\nlicence -> rat checks if present, this one however enforces 1:1 identity with the context of the text file. I found and corrected some deviations","created_at":"2017-08-07T12:16:10Z","updated_at":"2017-08-09T04:12:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8bd60b976cb3b25d211d44505cef44cefde1efa2","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/metamodel/pulls/156/commits","review_comments_url":"https://api.github.com/repos/apache/metamodel/pulls/156/comments","review_comment_url":"https://api.github.com/repos/apache/metamodel/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/metamodel/issues/156/comments","statuses_url":"https://api.github.com/repos/apache/metamodel/statuses/23a7ad378aa115d2a95758a322b6235f228e629b","head":{"label":"tomatophantastico:feature/checkstyle","ref":"feature/checkstyle","sha":"23a7ad378aa115d2a95758a322b6235f228e629b","user":{"login":"tomatophantastico","id":1636462,"avatar_url":"https://avatars0.githubusercontent.com/u/1636462?v=4","gravatar_id":"","url":"https://api.github.com/users/tomatophantastico","html_url":"https://github.com/tomatophantastico","followers_url":"https://api.github.com/users/tomatophantastico/followers","following_url":"https://api.github.com/users/tomatophantastico/following{/other_user}","gists_url":"https://api.github.com/users/tomatophantastico/gists{/gist_id}","starred_url":"https://api.github.com/users/tomatophantastico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomatophantastico/subscriptions","organizations_url":"https://api.github.com/users/tomatophantastico/orgs","repos_url":"https://api.github.com/users/tomatophantastico/repos","events_url":"https://api.github.com/users/tomatophantastico/events{/privacy}","received_events_url":"https://api.github.com/users/tomatophantastico/received_events","type":"User","site_admin":false},"repo":{"id":56676905,"name":"metamodel","full_name":"tomatophantastico/metamodel","owner":{"login":"tomatophantastico","id":1636462,"avatar_url":"https://avatars0.githubusercontent.com/u/1636462?v=4","gravatar_id":"","url":"https://api.github.com/users/tomatophantastico","html_url":"https://github.com/tomatophantastico","followers_url":"https://api.github.com/users/tomatophantastico/followers","following_url":"https://api.github.com/users/tomatophantastico/following{/other_user}","gists_url":"https://api.github.com/users/tomatophantastico/gists{/gist_id}","starred_url":"https://api.github.com/users/tomatophantastico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomatophantastico/subscriptions","organizations_url":"https://api.github.com/users/tomatophantastico/orgs","repos_url":"https://api.github.com/users/tomatophantastico/repos","events_url":"https://api.github.com/users/tomatophantastico/events{/privacy}","received_events_url":"https://api.github.com/users/tomatophantastico/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tomatophantastico/metamodel","description":"Mirror of Apache Metamodel","fork":true,"url":"https://api.github.com/repos/tomatophantastico/metamodel","forks_url":"https://api.github.com/repos/tomatophantastico/metamodel/forks","keys_url":"https://api.github.com/repos/tomatophantastico/metamodel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tomatophantastico/metamodel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tomatophantastico/metamodel/teams","hooks_url":"https://api.github.com/repos/tomatophantastico/metamodel/hooks","issue_events_url":"https://api.github.com/repos/tomatophantastico/metamodel/issues/events{/number}","events_url":"https://api.github.com/repos/tomatophantastico/metamodel/events","assignees_url":"https://api.github.com/repos/tomatophantastico/metamodel/assignees{/user}","branches_url":"https://api.github.com/repos/tomatophantastico/metamodel/branches{/branch}","tags_url":"https://api.github.com/repos/tomatophantastico/metamodel/tags","blobs_url":"https://api.github.com/repos/tomatophantastico/metamodel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tomatophantastico/metamodel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tomatophantastico/metamodel/git/refs{/sha}","trees_url":"https://api.github.com/repos/tomatophantastico/metamodel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tomatophantastico/metamodel/statuses/{sha}","languages_url":"https://api.github.com/repos/tomatophantastico/metamodel/languages","stargazers_url":"https://api.github.com/repos/tomatophantastico/metamodel/stargazers","contributors_url":"https://api.github.com/repos/tomatophantastico/metamodel/contributors","subscribers_url":"https://api.github.com/repos/tomatophantastico/metamodel/subscribers","subscription_url":"https://api.github.com/repos/tomatophantastico/metamodel/subscription","commits_url":"https://api.github.com/repos/tomatophantastico/metamodel/commits{/sha}","git_commits_url":"https://api.github.com/repos/tomatophantastico/metamodel/git/commits{/sha}","comments_url":"https://api.github.com/repos/tomatophantastico/metamodel/comments{/number}","issue_comment_url":"https://api.github.com/repos/tomatophantastico/metamodel/issues/comments{/number}","contents_url":"https://api.github.com/repos/tomatophantastico/metamodel/contents/{+path}","compare_url":"https://api.github.com/repos/tomatophantastico/metamodel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tomatophantastico/metamodel/merges","archive_url":"https://api.github.com/repos/tomatophantastico/metamodel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tomatophantastico/metamodel/downloads","issues_url":"https://api.github.com/repos/tomatophantastico/metamodel/issues{/number}","pulls_url":"https://api.github.com/repos/tomatophantastico/metamodel/pulls{/number}","milestones_url":"https://api.github.com/repos/tomatophantastico/metamodel/milestones{/number}","notifications_url":"https://api.github.com/repos/tomatophantastico/metamodel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tomatophantastico/metamodel/labels{/name}","releases_url":"https://api.github.com/repos/tomatophantastico/metamodel/releases{/id}","deployments_url":"https://api.github.com/repos/tomatophantastico/metamodel/deployments","created_at":"2016-04-20T10:12:39Z","updated_at":"2016-04-20T10:12:41Z","pushed_at":"2017-08-08T12:20:28Z","git_url":"git://github.com/tomatophantastico/metamodel.git","ssh_url":"git@github.com:tomatophantastico/metamodel.git","clone_url":"https://github.com/tomatophantastico/metamodel.git","svn_url":"https://github.com/tomatophantastico/metamodel","homepage":null,"size":4861,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"57e48be23844537690bdd6191ceb78adb4266e92","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":11943595,"name":"metamodel","full_name":"apache/metamodel","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/metamodel","description":"Mirror of Apache Metamodel","fork":false,"url":"https://api.github.com/repos/apache/metamodel","forks_url":"https://api.github.com/repos/apache/metamodel/forks","keys_url":"https://api.github.com/repos/apache/metamodel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/metamodel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/metamodel/teams","hooks_url":"https://api.github.com/repos/apache/metamodel/hooks","issue_events_url":"https://api.github.com/repos/apache/metamodel/issues/events{/number}","events_url":"https://api.github.com/repos/apache/metamodel/events","assignees_url":"https://api.github.com/repos/apache/metamodel/assignees{/user}","branches_url":"https://api.github.com/repos/apache/metamodel/branches{/branch}","tags_url":"https://api.github.com/repos/apache/metamodel/tags","blobs_url":"https://api.github.com/repos/apache/metamodel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/metamodel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/metamodel/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/metamodel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/metamodel/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/metamodel/languages","stargazers_url":"https://api.github.com/repos/apache/metamodel/stargazers","contributors_url":"https://api.github.com/repos/apache/metamodel/contributors","subscribers_url":"https://api.github.com/repos/apache/metamodel/subscribers","subscription_url":"https://api.github.com/repos/apache/metamodel/subscription","commits_url":"https://api.github.com/repos/apache/metamodel/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/metamodel/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/metamodel/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/metamodel/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/metamodel/contents/{+path}","compare_url":"https://api.github.com/repos/apache/metamodel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/metamodel/merges","archive_url":"https://api.github.com/repos/apache/metamodel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/metamodel/downloads","issues_url":"https://api.github.com/repos/apache/metamodel/issues{/number}","pulls_url":"https://api.github.com/repos/apache/metamodel/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/metamodel/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/metamodel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/metamodel/labels{/name}","releases_url":"https://api.github.com/repos/apache/metamodel/releases{/id}","deployments_url":"https://api.github.com/repos/apache/metamodel/deployments","created_at":"2013-08-07T07:00:14Z","updated_at":"2017-08-08T13:50:05Z","pushed_at":"2017-08-09T04:06:09Z","git_url":"git://github.com/apache/metamodel.git","ssh_url":"git@github.com:apache/metamodel.git","clone_url":"https://github.com/apache/metamodel.git","svn_url":"https://github.com/apache/metamodel","homepage":null,"size":4865,"stargazers_count":68,"watchers_count":68,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":74,"mirror_url":"git://git.apache.org/metamodel.git","open_issues_count":4,"forks":74,"open_issues":4,"watchers":68,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/metamodel/pulls/156"},"html":{"href":"https://github.com/apache/metamodel/pull/156"},"issue":{"href":"https://api.github.com/repos/apache/metamodel/issues/156"},"comments":{"href":"https://api.github.com/repos/apache/metamodel/issues/156/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/metamodel/pulls/156/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/metamodel/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/metamodel/pulls/156/commits"},"statuses":{"href":"https://api.github.com/repos/apache/metamodel/statuses/23a7ad378aa115d2a95758a322b6235f228e629b"}}}}
{"actor":{"display_login":"kaspersorensen"}}