{"action":"created","issue":{"url":"https://api.github.com/repos/electron-userland/electron-builder/issues/1045","repository_url":"https://api.github.com/repos/electron-userland/electron-builder","labels_url":"https://api.github.com/repos/electron-userland/electron-builder/issues/1045/labels{/name}","comments_url":"https://api.github.com/repos/electron-userland/electron-builder/issues/1045/comments","events_url":"https://api.github.com/repos/electron-userland/electron-builder/issues/1045/events","html_url":"https://github.com/electron-userland/electron-builder/issues/1045","id":197441512,"number":1045,"title":"Checksum mismatch on Windows NSIS","user":{"login":"Daymannovaes","id":3648665,"avatar_url":"https://avatars.githubusercontent.com/u/3648665?v=3","gravatar_id":"","url":"https://api.github.com/users/Daymannovaes","html_url":"https://github.com/Daymannovaes","followers_url":"https://api.github.com/users/Daymannovaes/followers","following_url":"https://api.github.com/users/Daymannovaes/following{/other_user}","gists_url":"https://api.github.com/users/Daymannovaes/gists{/gist_id}","starred_url":"https://api.github.com/users/Daymannovaes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Daymannovaes/subscriptions","organizations_url":"https://api.github.com/users/Daymannovaes/orgs","repos_url":"https://api.github.com/users/Daymannovaes/repos","events_url":"https://api.github.com/users/Daymannovaes/events{/privacy}","received_events_url":"https://api.github.com/users/Daymannovaes/received_events","type":"User","site_admin":false},"labels":[{"id":214243367,"url":"https://api.github.com/repos/electron-userland/electron-builder/labels/bug","name":"bug","color":"fc2929","default":true}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-12-24T01:08:17Z","updated_at":"2017-01-03T08:02:25Z","closed_at":"2016-12-26T18:16:57Z","body":"<!-- Which version of electron-builder are you using? -->\r\n* **Version**: 10.8.1\r\n\r\n<!-- What target are you building for? -->\r\n* **Target**: NSIS\r\n(building from windows too)\r\n\r\n* **Node version**: 6.9.1\r\n* **npm version**: 4.0.3\r\n\r\n<!-- Enter your issue details below this comment. -->\r\nI'm getting checksum mismatch, like following in the screenshot\r\n\r\n![screenshot 18](https://cloud.githubusercontent.com/assets/3648665/21464447/0b89b716-c964-11e6-9988-cd59709bfed1.png)\r\n\r\nI uploaded the executables with `--publish=always` at github and didn't change anything.\r\nThe fact that I'm checking for updates a lot of times even ater the download starts, can affect this?\r\n\r\nBecause just for test purpose, I put the check interval to 30 seconds, so I get `update-available` a bunch of times.\r\n\r\nPlus, I'm getting everytime a different checksum. What's going on?\r\n\r\nMy autoupdater module is very simple:\r\n\r\n```\r\nautoUpdater.addListener('update-available', () => {\r\n  logger.info('update-available');\r\n});\r\nautoUpdater.addListener('update-downloaded', (event, releaseNotes, releaseName, releaseDate, updateURL) => {\r\n  autoUpdater.quitAndInstall();\r\n});\r\nautoUpdater.addListener('error', (error) => {\r\n  logger.error('error when trying to check for update');\r\n  logger.error(error);\r\n});\r\nautoUpdater.addListener('checking-for-update', () => {\r\n  logger.info('checking-for-update');\r\n});\r\nautoUpdater.addListener('update-not-available', () => {\r\n  logger.info('update-not-available');\r\n});\r\n\r\nasync function setup() {\r\n  autoUpdater.checkForUpdates();\r\n\r\n  await sleep(30 * 1000);\r\n  setup();\r\n}\r\nsetup();\r\n```\r\n\r\nAnd but package config is simple too:\r\n\r\n```\r\n\"build\": {\r\n    \"appId\": \"some-id\",\r\n    \"files\": [\r\n      \"node_modules/**/*\",\r\n      \".env\",\r\n      \"app/**/*\"\r\n    ],\r\n    \"publish\": [\r\n      {\r\n        \"provider\": \"github\",\r\n        \"repo\": \"some-repo\"\r\n      }\r\n    ],\r\n    \"win\": {\r\n      \"certificateFile\": \"./certs/my_signing_key.pfx\",\r\n      \"certificatePassword\": \"\"\r\n    }\r\n  }\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/electron-userland/electron-builder/issues/comments/270065491","html_url":"https://github.com/electron-userland/electron-builder/issues/1045#issuecomment-270065491","issue_url":"https://api.github.com/repos/electron-userland/electron-builder/issues/1045","id":270065491,"user":{"login":"tvanro","id":4425891,"avatar_url":"https://avatars.githubusercontent.com/u/4425891?v=3","gravatar_id":"","url":"https://api.github.com/users/tvanro","html_url":"https://github.com/tvanro","followers_url":"https://api.github.com/users/tvanro/followers","following_url":"https://api.github.com/users/tvanro/following{/other_user}","gists_url":"https://api.github.com/users/tvanro/gists{/gist_id}","starred_url":"https://api.github.com/users/tvanro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tvanro/subscriptions","organizations_url":"https://api.github.com/users/tvanro/orgs","repos_url":"https://api.github.com/users/tvanro/repos","events_url":"https://api.github.com/users/tvanro/events{/privacy}","received_events_url":"https://api.github.com/users/tvanro/received_events","type":"User","site_admin":false},"created_at":"2017-01-03T08:02:25Z","updated_at":"2017-01-03T08:02:25Z","body":"**electron-builder**: 10.16.0\r\n**electron-auto-updater**: 0.9.0\r\n\r\n**Target**: NSIS\r\n(building from docker on Linux)\r\n\r\nI'm receiving the exact same error so there's still something going on I'm afraid.\r\nLike with @Daymannovaes, the second checksum is different on each check from electron-builder. My guess is that it's doing the check on a whole file-download request instead of only the file."}}
{"actor":{"display_login":"tvanro"}}