{"action":"created","comment":{"url":"https://api.github.com/repos/palantir/gradle-baseline/pulls/comments/122820515","pull_request_review_id":44969168,"id":122820515,"diff_hunk":"@@ -45,6 +46,19 @@\n     private static final Matcher<ExpressionTree> VALIDATE_METHODS =\n             MethodMatchers.staticMethod()\n                     .onClassAny(\"org.apache.commons.lang3.Validate\", \"org.apache.commons.lang.Validate\");\n+    private static final Matcher<ExpressionTree> VALIDATE_METHODS_MESSAGE_THIRD_PARAM =\n+            Matchers.anyOf(\n+                    MethodMatchers.staticMethod()\n+                            // all org.apache.commons.lang.Validate methods have the message as the second arg","path":"baseline-error-prone/src/main/java/com/palantir/baseline/errorprone/ValidateConstantMessage.java","position":22,"original_position":22,"commit_id":"2da024da7499608e3b0ee070248e9dd656a72039","original_commit_id":"2da024da7499608e3b0ee070248e9dd656a72039","user":{"login":"uschi2000","id":6528449,"avatar_url":"https://avatars0.githubusercontent.com/u/6528449?v=3","gravatar_id":"","url":"https://api.github.com/users/uschi2000","html_url":"https://github.com/uschi2000","followers_url":"https://api.github.com/users/uschi2000/followers","following_url":"https://api.github.com/users/uschi2000/following{/other_user}","gists_url":"https://api.github.com/users/uschi2000/gists{/gist_id}","starred_url":"https://api.github.com/users/uschi2000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uschi2000/subscriptions","organizations_url":"https://api.github.com/users/uschi2000/orgs","repos_url":"https://api.github.com/users/uschi2000/repos","events_url":"https://api.github.com/users/uschi2000/events{/privacy}","received_events_url":"https://api.github.com/users/uschi2000/received_events","type":"User","site_admin":false},"body":"i don't quite understand how this comment relevant here","created_at":"2017-06-19T20:48:56Z","updated_at":"2017-06-19T20:48:56Z","html_url":"https://github.com/palantir/gradle-baseline/pull/175#discussion_r122820515","pull_request_url":"https://api.github.com/repos/palantir/gradle-baseline/pulls/175","_links":{"self":{"href":"https://api.github.com/repos/palantir/gradle-baseline/pulls/comments/122820515"},"html":{"href":"https://github.com/palantir/gradle-baseline/pull/175#discussion_r122820515"},"pull_request":{"href":"https://api.github.com/repos/palantir/gradle-baseline/pulls/175"}}},"pull_request":{"url":"https://api.github.com/repos/palantir/gradle-baseline/pulls/175","id":122688808,"html_url":"https://github.com/palantir/gradle-baseline/pull/175","diff_url":"https://github.com/palantir/gradle-baseline/pull/175.diff","patch_url":"https://github.com/palantir/gradle-baseline/pull/175.patch","issue_url":"https://api.github.com/repos/palantir/gradle-baseline/issues/175","number":175,"state":"open","locked":false,"title":"fix assumption in ValidateConstantMessage that message is latest string arg","user":{"login":"gracew","id":1057120,"avatar_url":"https://avatars1.githubusercontent.com/u/1057120?v=3","gravatar_id":"","url":"https://api.github.com/users/gracew","html_url":"https://github.com/gracew","followers_url":"https://api.github.com/users/gracew/followers","following_url":"https://api.github.com/users/gracew/following{/other_user}","gists_url":"https://api.github.com/users/gracew/gists{/gist_id}","starred_url":"https://api.github.com/users/gracew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gracew/subscriptions","organizations_url":"https://api.github.com/users/gracew/orgs","repos_url":"https://api.github.com/users/gracew/repos","events_url":"https://api.github.com/users/gracew/events{/privacy}","received_events_url":"https://api.github.com/users/gracew/received_events","type":"User","site_admin":false},"body":"will try to submit a fix -- hopefully easy, as the PreconditionsConstantMessage check doesn't seem to exhibit this behavior.","created_at":"2017-05-26T17:40:16Z","updated_at":"2017-06-19T20:48:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4aa8429e59315d501f6dfc71ce980f6912797138","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/palantir/gradle-baseline/pulls/175/commits","review_comments_url":"https://api.github.com/repos/palantir/gradle-baseline/pulls/175/comments","review_comment_url":"https://api.github.com/repos/palantir/gradle-baseline/pulls/comments{/number}","comments_url":"https://api.github.com/repos/palantir/gradle-baseline/issues/175/comments","statuses_url":"https://api.github.com/repos/palantir/gradle-baseline/statuses/2da024da7499608e3b0ee070248e9dd656a72039","head":{"label":"gracew:gw/validate-constant-message","ref":"gw/validate-constant-message","sha":"2da024da7499608e3b0ee070248e9dd656a72039","user":{"login":"gracew","id":1057120,"avatar_url":"https://avatars1.githubusercontent.com/u/1057120?v=3","gravatar_id":"","url":"https://api.github.com/users/gracew","html_url":"https://github.com/gracew","followers_url":"https://api.github.com/users/gracew/followers","following_url":"https://api.github.com/users/gracew/following{/other_user}","gists_url":"https://api.github.com/users/gracew/gists{/gist_id}","starred_url":"https://api.github.com/users/gracew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gracew/subscriptions","organizations_url":"https://api.github.com/users/gracew/orgs","repos_url":"https://api.github.com/users/gracew/repos","events_url":"https://api.github.com/users/gracew/events{/privacy}","received_events_url":"https://api.github.com/users/gracew/received_events","type":"User","site_admin":false},"repo":{"id":52840348,"name":"gradle-baseline","full_name":"gracew/gradle-baseline","owner":{"login":"gracew","id":1057120,"avatar_url":"https://avatars1.githubusercontent.com/u/1057120?v=3","gravatar_id":"","url":"https://api.github.com/users/gracew","html_url":"https://github.com/gracew","followers_url":"https://api.github.com/users/gracew/followers","following_url":"https://api.github.com/users/gracew/following{/other_user}","gists_url":"https://api.github.com/users/gracew/gists{/gist_id}","starred_url":"https://api.github.com/users/gracew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gracew/subscriptions","organizations_url":"https://api.github.com/users/gracew/orgs","repos_url":"https://api.github.com/users/gracew/repos","events_url":"https://api.github.com/users/gracew/events{/privacy}","received_events_url":"https://api.github.com/users/gracew/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gracew/gradle-baseline","description":"A set of Gradle plugins that configure default code quality tools for developers.","fork":true,"url":"https://api.github.com/repos/gracew/gradle-baseline","forks_url":"https://api.github.com/repos/gracew/gradle-baseline/forks","keys_url":"https://api.github.com/repos/gracew/gradle-baseline/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gracew/gradle-baseline/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gracew/gradle-baseline/teams","hooks_url":"https://api.github.com/repos/gracew/gradle-baseline/hooks","issue_events_url":"https://api.github.com/repos/gracew/gradle-baseline/issues/events{/number}","events_url":"https://api.github.com/repos/gracew/gradle-baseline/events","assignees_url":"https://api.github.com/repos/gracew/gradle-baseline/assignees{/user}","branches_url":"https://api.github.com/repos/gracew/gradle-baseline/branches{/branch}","tags_url":"https://api.github.com/repos/gracew/gradle-baseline/tags","blobs_url":"https://api.github.com/repos/gracew/gradle-baseline/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gracew/gradle-baseline/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gracew/gradle-baseline/git/refs{/sha}","trees_url":"https://api.github.com/repos/gracew/gradle-baseline/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gracew/gradle-baseline/statuses/{sha}","languages_url":"https://api.github.com/repos/gracew/gradle-baseline/languages","stargazers_url":"https://api.github.com/repos/gracew/gradle-baseline/stargazers","contributors_url":"https://api.github.com/repos/gracew/gradle-baseline/contributors","subscribers_url":"https://api.github.com/repos/gracew/gradle-baseline/subscribers","subscription_url":"https://api.github.com/repos/gracew/gradle-baseline/subscription","commits_url":"https://api.github.com/repos/gracew/gradle-baseline/commits{/sha}","git_commits_url":"https://api.github.com/repos/gracew/gradle-baseline/git/commits{/sha}","comments_url":"https://api.github.com/repos/gracew/gradle-baseline/comments{/number}","issue_comment_url":"https://api.github.com/repos/gracew/gradle-baseline/issues/comments{/number}","contents_url":"https://api.github.com/repos/gracew/gradle-baseline/contents/{+path}","compare_url":"https://api.github.com/repos/gracew/gradle-baseline/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gracew/gradle-baseline/merges","archive_url":"https://api.github.com/repos/gracew/gradle-baseline/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gracew/gradle-baseline/downloads","issues_url":"https://api.github.com/repos/gracew/gradle-baseline/issues{/number}","pulls_url":"https://api.github.com/repos/gracew/gradle-baseline/pulls{/number}","milestones_url":"https://api.github.com/repos/gracew/gradle-baseline/milestones{/number}","notifications_url":"https://api.github.com/repos/gracew/gradle-baseline/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gracew/gradle-baseline/labels{/name}","releases_url":"https://api.github.com/repos/gracew/gradle-baseline/releases{/id}","deployments_url":"https://api.github.com/repos/gracew/gradle-baseline/deployments","created_at":"2016-03-01T02:06:08Z","updated_at":"2016-03-01T02:06:08Z","pushed_at":"2017-06-19T20:40:37Z","git_url":"git://github.com/gracew/gradle-baseline.git","ssh_url":"git@github.com:gracew/gradle-baseline.git","clone_url":"https://github.com/gracew/gradle-baseline.git","svn_url":"https://github.com/gracew/gradle-baseline","homepage":null,"size":472,"stargazers_count":0,"watchers_count":0,"language":"Groovy","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"palantir:develop","ref":"develop","sha":"ae01f01beba93966f675f4eb97588bcc673ee825","user":{"login":"palantir","id":303157,"avatar_url":"https://avatars3.githubusercontent.com/u/303157?v=3","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"repo":{"id":39910458,"name":"gradle-baseline","full_name":"palantir/gradle-baseline","owner":{"login":"palantir","id":303157,"avatar_url":"https://avatars3.githubusercontent.com/u/303157?v=3","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/palantir/gradle-baseline","description":"A set of Gradle plugins that configure default code quality tools for developers.","fork":false,"url":"https://api.github.com/repos/palantir/gradle-baseline","forks_url":"https://api.github.com/repos/palantir/gradle-baseline/forks","keys_url":"https://api.github.com/repos/palantir/gradle-baseline/keys{/key_id}","collaborators_url":"https://api.github.com/repos/palantir/gradle-baseline/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/palantir/gradle-baseline/teams","hooks_url":"https://api.github.com/repos/palantir/gradle-baseline/hooks","issue_events_url":"https://api.github.com/repos/palantir/gradle-baseline/issues/events{/number}","events_url":"https://api.github.com/repos/palantir/gradle-baseline/events","assignees_url":"https://api.github.com/repos/palantir/gradle-baseline/assignees{/user}","branches_url":"https://api.github.com/repos/palantir/gradle-baseline/branches{/branch}","tags_url":"https://api.github.com/repos/palantir/gradle-baseline/tags","blobs_url":"https://api.github.com/repos/palantir/gradle-baseline/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/palantir/gradle-baseline/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/palantir/gradle-baseline/git/refs{/sha}","trees_url":"https://api.github.com/repos/palantir/gradle-baseline/git/trees{/sha}","statuses_url":"https://api.github.com/repos/palantir/gradle-baseline/statuses/{sha}","languages_url":"https://api.github.com/repos/palantir/gradle-baseline/languages","stargazers_url":"https://api.github.com/repos/palantir/gradle-baseline/stargazers","contributors_url":"https://api.github.com/repos/palantir/gradle-baseline/contributors","subscribers_url":"https://api.github.com/repos/palantir/gradle-baseline/subscribers","subscription_url":"https://api.github.com/repos/palantir/gradle-baseline/subscription","commits_url":"https://api.github.com/repos/palantir/gradle-baseline/commits{/sha}","git_commits_url":"https://api.github.com/repos/palantir/gradle-baseline/git/commits{/sha}","comments_url":"https://api.github.com/repos/palantir/gradle-baseline/comments{/number}","issue_comment_url":"https://api.github.com/repos/palantir/gradle-baseline/issues/comments{/number}","contents_url":"https://api.github.com/repos/palantir/gradle-baseline/contents/{+path}","compare_url":"https://api.github.com/repos/palantir/gradle-baseline/compare/{base}...{head}","merges_url":"https://api.github.com/repos/palantir/gradle-baseline/merges","archive_url":"https://api.github.com/repos/palantir/gradle-baseline/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/palantir/gradle-baseline/downloads","issues_url":"https://api.github.com/repos/palantir/gradle-baseline/issues{/number}","pulls_url":"https://api.github.com/repos/palantir/gradle-baseline/pulls{/number}","milestones_url":"https://api.github.com/repos/palantir/gradle-baseline/milestones{/number}","notifications_url":"https://api.github.com/repos/palantir/gradle-baseline/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/palantir/gradle-baseline/labels{/name}","releases_url":"https://api.github.com/repos/palantir/gradle-baseline/releases{/id}","deployments_url":"https://api.github.com/repos/palantir/gradle-baseline/deployments","created_at":"2015-07-29T18:49:11Z","updated_at":"2017-06-17T05:27:47Z","pushed_at":"2017-06-19T20:40:39Z","git_url":"git://github.com/palantir/gradle-baseline.git","ssh_url":"git@github.com:palantir/gradle-baseline.git","clone_url":"https://github.com/palantir/gradle-baseline.git","svn_url":"https://github.com/palantir/gradle-baseline","homepage":null,"size":497,"stargazers_count":37,"watchers_count":37,"language":"Groovy","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":29,"mirror_url":null,"open_issues_count":23,"forks":29,"open_issues":23,"watchers":37,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/palantir/gradle-baseline/pulls/175"},"html":{"href":"https://github.com/palantir/gradle-baseline/pull/175"},"issue":{"href":"https://api.github.com/repos/palantir/gradle-baseline/issues/175"},"comments":{"href":"https://api.github.com/repos/palantir/gradle-baseline/issues/175/comments"},"review_comments":{"href":"https://api.github.com/repos/palantir/gradle-baseline/pulls/175/comments"},"review_comment":{"href":"https://api.github.com/repos/palantir/gradle-baseline/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/palantir/gradle-baseline/pulls/175/commits"},"statuses":{"href":"https://api.github.com/repos/palantir/gradle-baseline/statuses/2da024da7499608e3b0ee070248e9dd656a72039"}}}}
{"actor":{"display_login":"uschi2000"}}