{"action":"created","comment":{"url":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/pulls/comments/129386212","pull_request_review_id":52135010,"id":129386212,"diff_hunk":"@@ -1,30 +1,45 @@\n {% trans_default_domain \"locationview\" %}\n {{ form_start(actionsForm, {'action': path('ez_hybrid_platform_ui_translation_actions', {'contentId': content.id, 'redirectLocationId': location.id})}) }}\n \n-<div class=\"ez-list-toolbar\">\n-    <h2 class=\"ez-list-toolbar-label\">{{ 'locationview.translations.title'|trans|desc('Translation manager') }}</h2>\n-    <div class=\"container-buttons\">\n-        {{ form_widget(actionsForm.delete, {'label': 'locationview.translations.delete.translations'|trans()|desc('Delete selected translations'), 'attr': {'class': 'ez-button ez-button-negative'}}) }}\n-    </div>\n-</div>\n+{% set dialogId = 'confirm-translations-removal-' ~ location.id %}\n+{{\n+    include('@EzSystemsHybridPlatformUi/components/confirm_delete_dialog.html.twig', {","path":"src/bundle/Resources/views/content/tabs/translations.html.twig","position":12,"original_position":12,"commit_id":"16d0555cb0e5dcc4f3bccc57298f1d6242822453","original_commit_id":"16d0555cb0e5dcc4f3bccc57298f1d6242822453","user":{"login":"bdunogier","id":235928,"avatar_url":"https://avatars2.githubusercontent.com/u/235928?v=4","gravatar_id":"","url":"https://api.github.com/users/bdunogier","html_url":"https://github.com/bdunogier","followers_url":"https://api.github.com/users/bdunogier/followers","following_url":"https://api.github.com/users/bdunogier/following{/other_user}","gists_url":"https://api.github.com/users/bdunogier/gists{/gist_id}","starred_url":"https://api.github.com/users/bdunogier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdunogier/subscriptions","organizations_url":"https://api.github.com/users/bdunogier/orgs","repos_url":"https://api.github.com/users/bdunogier/repos","events_url":"https://api.github.com/users/bdunogier/events{/privacy}","received_events_url":"https://api.github.com/users/bdunogier/received_events","type":"User","site_admin":false},"body":"We should considering replacing/completing this with a twig function. Something like:\r\n\r\n```jinja2\r\n{{ ez_confirm_dialog(\r\n  dialogId=dialogId,\r\n  message='confirm.remove.translations'|trans()|desc('Are you sure you want to remove selected translations?'),\r\n  confirmButton: actionsForm.delete\r\n) }}\r\n```\r\n\r\nIt would ease backward compatibility (but could still use the template of course).\r\n\r\nI'll try it here to validate that it works as expected.","created_at":"2017-07-25T18:24:35Z","updated_at":"2017-07-25T18:31:27Z","html_url":"https://github.com/ezsystems/hybrid-platform-ui/pull/83#discussion_r129386212","pull_request_url":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/pulls/83","_links":{"self":{"href":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/pulls/comments/129386212"},"html":{"href":"https://github.com/ezsystems/hybrid-platform-ui/pull/83#discussion_r129386212"},"pull_request":{"href":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/pulls/83"}}},"pull_request":{"url":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/pulls/83","id":130868974,"html_url":"https://github.com/ezsystems/hybrid-platform-ui/pull/83","diff_url":"https://github.com/ezsystems/hybrid-platform-ui/pull/83.diff","patch_url":"https://github.com/ezsystems/hybrid-platform-ui/pull/83.patch","issue_url":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/issues/83","number":83,"state":"open","locked":false,"title":"EZP-27572: Enable buttons only when something is selected","user":{"login":"StephaneDiot","id":5558766,"avatar_url":"https://avatars0.githubusercontent.com/u/5558766?v=4","gravatar_id":"","url":"https://api.github.com/users/StephaneDiot","html_url":"https://github.com/StephaneDiot","followers_url":"https://api.github.com/users/StephaneDiot/followers","following_url":"https://api.github.com/users/StephaneDiot/following{/other_user}","gists_url":"https://api.github.com/users/StephaneDiot/gists{/gist_id}","starred_url":"https://api.github.com/users/StephaneDiot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StephaneDiot/subscriptions","organizations_url":"https://api.github.com/users/StephaneDiot/orgs","repos_url":"https://api.github.com/users/StephaneDiot/repos","events_url":"https://api.github.com/users/StephaneDiot/events{/privacy}","received_events_url":"https://api.github.com/users/StephaneDiot/received_events","type":"User","site_admin":false},"body":"JIRA: https://jira.ez.no/browse/EZP-27572\r\nRequires: https://github.com/ezsystems/hybrid-platform-ui-core-components/pull/30\r\n\r\n# Description\r\n\r\nUse the `<ez-selection-activate-element>` component in Locations, Versions and Translations tabs to enable buttons only when something is selected.\r\n\r\nscreencast: https://youtu.be/whZ4s7zKQqs\r\n\r\n# Test\r\n\r\nmanual tests","created_at":"2017-07-17T14:26:44Z","updated_at":"2017-07-25T18:31:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1ed441e2719f77728810b2272a042656d9373e59","assignee":null,"assignees":[],"requested_reviewers":[{"login":"yannickroger","id":4035241,"avatar_url":"https://avatars3.githubusercontent.com/u/4035241?v=4","gravatar_id":"","url":"https://api.github.com/users/yannickroger","html_url":"https://github.com/yannickroger","followers_url":"https://api.github.com/users/yannickroger/followers","following_url":"https://api.github.com/users/yannickroger/following{/other_user}","gists_url":"https://api.github.com/users/yannickroger/gists{/gist_id}","starred_url":"https://api.github.com/users/yannickroger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yannickroger/subscriptions","organizations_url":"https://api.github.com/users/yannickroger/orgs","repos_url":"https://api.github.com/users/yannickroger/repos","events_url":"https://api.github.com/users/yannickroger/events{/privacy}","received_events_url":"https://api.github.com/users/yannickroger/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/pulls/83/commits","review_comments_url":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/pulls/83/comments","review_comment_url":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/issues/83/comments","statuses_url":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/statuses/16d0555cb0e5dcc4f3bccc57298f1d6242822453","head":{"label":"ezsystems:EZP-27572_Implement_ez-selection-activate-element_component","ref":"EZP-27572_Implement_ez-selection-activate-element_component","sha":"16d0555cb0e5dcc4f3bccc57298f1d6242822453","user":{"login":"ezsystems","id":295311,"avatar_url":"https://avatars1.githubusercontent.com/u/295311?v=4","gravatar_id":"","url":"https://api.github.com/users/ezsystems","html_url":"https://github.com/ezsystems","followers_url":"https://api.github.com/users/ezsystems/followers","following_url":"https://api.github.com/users/ezsystems/following{/other_user}","gists_url":"https://api.github.com/users/ezsystems/gists{/gist_id}","starred_url":"https://api.github.com/users/ezsystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezsystems/subscriptions","organizations_url":"https://api.github.com/users/ezsystems/orgs","repos_url":"https://api.github.com/users/ezsystems/repos","events_url":"https://api.github.com/users/ezsystems/events{/privacy}","received_events_url":"https://api.github.com/users/ezsystems/received_events","type":"Organization","site_admin":false},"repo":{"id":87083975,"name":"hybrid-platform-ui","full_name":"ezsystems/hybrid-platform-ui","owner":{"login":"ezsystems","id":295311,"avatar_url":"https://avatars1.githubusercontent.com/u/295311?v=4","gravatar_id":"","url":"https://api.github.com/users/ezsystems","html_url":"https://github.com/ezsystems","followers_url":"https://api.github.com/users/ezsystems/followers","following_url":"https://api.github.com/users/ezsystems/following{/other_user}","gists_url":"https://api.github.com/users/ezsystems/gists{/gist_id}","starred_url":"https://api.github.com/users/ezsystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezsystems/subscriptions","organizations_url":"https://api.github.com/users/ezsystems/orgs","repos_url":"https://api.github.com/users/ezsystems/repos","events_url":"https://api.github.com/users/ezsystems/events{/privacy}","received_events_url":"https://api.github.com/users/ezsystems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ezsystems/hybrid-platform-ui","description":null,"fork":false,"url":"https://api.github.com/repos/ezsystems/hybrid-platform-ui","forks_url":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/forks","keys_url":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/teams","hooks_url":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/hooks","issue_events_url":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/issues/events{/number}","events_url":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/events","assignees_url":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/assignees{/user}","branches_url":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/branches{/branch}","tags_url":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/tags","blobs_url":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/languages","stargazers_url":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/stargazers","contributors_url":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/contributors","subscribers_url":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/subscribers","subscription_url":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/subscription","commits_url":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/contents/{+path}","compare_url":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/merges","archive_url":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/downloads","issues_url":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/issues{/number}","pulls_url":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/labels{/name}","releases_url":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/releases{/id}","deployments_url":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/deployments","created_at":"2017-04-03T14:32:58Z","updated_at":"2017-07-18T07:18:55Z","pushed_at":"2017-07-25T16:15:58Z","git_url":"git://github.com/ezsystems/hybrid-platform-ui.git","ssh_url":"git@github.com:ezsystems/hybrid-platform-ui.git","clone_url":"https://github.com/ezsystems/hybrid-platform-ui.git","svn_url":"https://github.com/ezsystems/hybrid-platform-ui","homepage":null,"size":399,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":9,"forks":3,"open_issues":9,"watchers":1,"default_branch":"master"}},"base":{"label":"ezsystems:master","ref":"master","sha":"517e0df1c893d182b172f46c4e19b5a10040839c","user":{"login":"ezsystems","id":295311,"avatar_url":"https://avatars1.githubusercontent.com/u/295311?v=4","gravatar_id":"","url":"https://api.github.com/users/ezsystems","html_url":"https://github.com/ezsystems","followers_url":"https://api.github.com/users/ezsystems/followers","following_url":"https://api.github.com/users/ezsystems/following{/other_user}","gists_url":"https://api.github.com/users/ezsystems/gists{/gist_id}","starred_url":"https://api.github.com/users/ezsystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezsystems/subscriptions","organizations_url":"https://api.github.com/users/ezsystems/orgs","repos_url":"https://api.github.com/users/ezsystems/repos","events_url":"https://api.github.com/users/ezsystems/events{/privacy}","received_events_url":"https://api.github.com/users/ezsystems/received_events","type":"Organization","site_admin":false},"repo":{"id":87083975,"name":"hybrid-platform-ui","full_name":"ezsystems/hybrid-platform-ui","owner":{"login":"ezsystems","id":295311,"avatar_url":"https://avatars1.githubusercontent.com/u/295311?v=4","gravatar_id":"","url":"https://api.github.com/users/ezsystems","html_url":"https://github.com/ezsystems","followers_url":"https://api.github.com/users/ezsystems/followers","following_url":"https://api.github.com/users/ezsystems/following{/other_user}","gists_url":"https://api.github.com/users/ezsystems/gists{/gist_id}","starred_url":"https://api.github.com/users/ezsystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezsystems/subscriptions","organizations_url":"https://api.github.com/users/ezsystems/orgs","repos_url":"https://api.github.com/users/ezsystems/repos","events_url":"https://api.github.com/users/ezsystems/events{/privacy}","received_events_url":"https://api.github.com/users/ezsystems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ezsystems/hybrid-platform-ui","description":null,"fork":false,"url":"https://api.github.com/repos/ezsystems/hybrid-platform-ui","forks_url":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/forks","keys_url":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/teams","hooks_url":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/hooks","issue_events_url":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/issues/events{/number}","events_url":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/events","assignees_url":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/assignees{/user}","branches_url":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/branches{/branch}","tags_url":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/tags","blobs_url":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/languages","stargazers_url":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/stargazers","contributors_url":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/contributors","subscribers_url":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/subscribers","subscription_url":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/subscription","commits_url":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/contents/{+path}","compare_url":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/merges","archive_url":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/downloads","issues_url":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/issues{/number}","pulls_url":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/labels{/name}","releases_url":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/releases{/id}","deployments_url":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/deployments","created_at":"2017-04-03T14:32:58Z","updated_at":"2017-07-18T07:18:55Z","pushed_at":"2017-07-25T16:15:58Z","git_url":"git://github.com/ezsystems/hybrid-platform-ui.git","ssh_url":"git@github.com:ezsystems/hybrid-platform-ui.git","clone_url":"https://github.com/ezsystems/hybrid-platform-ui.git","svn_url":"https://github.com/ezsystems/hybrid-platform-ui","homepage":null,"size":399,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":9,"forks":3,"open_issues":9,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/pulls/83"},"html":{"href":"https://github.com/ezsystems/hybrid-platform-ui/pull/83"},"issue":{"href":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/issues/83"},"comments":{"href":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/issues/83/comments"},"review_comments":{"href":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/pulls/83/comments"},"review_comment":{"href":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/pulls/83/commits"},"statuses":{"href":"https://api.github.com/repos/ezsystems/hybrid-platform-ui/statuses/16d0555cb0e5dcc4f3bccc57298f1d6242822453"}}}}
{"actor":{"display_login":"bdunogier"}}