{"action":"created","issue":{"url":"https://api.github.com/repos/KhronosGroup/glslang/issues/690","repository_url":"https://api.github.com/repos/KhronosGroup/glslang","labels_url":"https://api.github.com/repos/KhronosGroup/glslang/issues/690/labels{/name}","comments_url":"https://api.github.com/repos/KhronosGroup/glslang/issues/690/comments","events_url":"https://api.github.com/repos/KhronosGroup/glslang/issues/690/events","html_url":"https://github.com/KhronosGroup/glslang/pull/690","id":202333547,"number":690,"title":"CMake: add target_link_libraries internally","user":{"login":"ligfx","id":594093,"avatar_url":"https://avatars.githubusercontent.com/u/594093?v=3","gravatar_id":"","url":"https://api.github.com/users/ligfx","html_url":"https://github.com/ligfx","followers_url":"https://api.github.com/users/ligfx/followers","following_url":"https://api.github.com/users/ligfx/following{/other_user}","gists_url":"https://api.github.com/users/ligfx/gists{/gist_id}","starred_url":"https://api.github.com/users/ligfx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ligfx/subscriptions","organizations_url":"https://api.github.com/users/ligfx/orgs","repos_url":"https://api.github.com/users/ligfx/repos","events_url":"https://api.github.com/users/ligfx/events{/privacy}","received_events_url":"https://api.github.com/users/ligfx/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-01-21T19:03:19Z","updated_at":"2017-01-26T21:07:03Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/KhronosGroup/glslang/pulls/690","html_url":"https://github.com/KhronosGroup/glslang/pull/690","diff_url":"https://github.com/KhronosGroup/glslang/pull/690.diff","patch_url":"https://github.com/KhronosGroup/glslang/pull/690.patch"},"body":"Makes it easier to include glslang in a larger CMake project: instead of having to call `target_link_libraries(glslang OSDependent OGLCompiler HLSL)`, for example, you only need to call `target_link_libraries(glslang)` and it will pull in the helpers it needs.\r\n\r\nThis is also better in terms of cleaning up the \"public interface\", of sorts, for building glslang: end-users probably shouldn't need to know or be explicitly dependent on internal targets."},"comment":{"url":"https://api.github.com/repos/KhronosGroup/glslang/issues/comments/275513799","html_url":"https://github.com/KhronosGroup/glslang/pull/690#issuecomment-275513799","issue_url":"https://api.github.com/repos/KhronosGroup/glslang/issues/690","id":275513799,"user":{"login":"ligfx","id":594093,"avatar_url":"https://avatars.githubusercontent.com/u/594093?v=3","gravatar_id":"","url":"https://api.github.com/users/ligfx","html_url":"https://github.com/ligfx","followers_url":"https://api.github.com/users/ligfx/followers","following_url":"https://api.github.com/users/ligfx/following{/other_user}","gists_url":"https://api.github.com/users/ligfx/gists{/gist_id}","starred_url":"https://api.github.com/users/ligfx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ligfx/subscriptions","organizations_url":"https://api.github.com/users/ligfx/orgs","repos_url":"https://api.github.com/users/ligfx/repos","events_url":"https://api.github.com/users/ligfx/events{/privacy}","received_events_url":"https://api.github.com/users/ligfx/received_events","type":"User","site_admin":false},"created_at":"2017-01-26T21:07:03Z","updated_at":"2017-01-26T21:07:03Z","body":"It shouldn't, since those targets still exist. Either the compiler or CMake will notice that you're linking to the same library twice and deal with it appropriately."}}
{"actor":{"display_login":"ligfx"}}