{"action":"created","comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments/111028952","pull_request_review_id":32244408,"id":111028952,"diff_hunk":"@@ -670,6 +670,16 @@ public function createDatabase($options, $utf = true)\n \t}\n \n \t/**\n+\t * Destructor.\n+\t *\n+\t * @since   CMS 3.6","path":"libraries/joomla/database/driver.php","position":6,"original_position":6,"commit_id":"834a8eb31b2e5e239c667d3650fedc8789da5c9e","original_commit_id":"834a8eb31b2e5e239c667d3650fedc8789da5c9e","user":{"login":"izharaazmi","id":6706189,"avatar_url":"https://avatars1.githubusercontent.com/u/6706189?v=3","gravatar_id":"","url":"https://api.github.com/users/izharaazmi","html_url":"https://github.com/izharaazmi","followers_url":"https://api.github.com/users/izharaazmi/followers","following_url":"https://api.github.com/users/izharaazmi/following{/other_user}","gists_url":"https://api.github.com/users/izharaazmi/gists{/gist_id}","starred_url":"https://api.github.com/users/izharaazmi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/izharaazmi/subscriptions","organizations_url":"https://api.github.com/users/izharaazmi/orgs","repos_url":"https://api.github.com/users/izharaazmi/repos","events_url":"https://api.github.com/users/izharaazmi/events{/privacy}","received_events_url":"https://api.github.com/users/izharaazmi/received_events","type":"User","site_admin":false},"body":"Sure, I noticed this. Probably those days this macro wasn't born yet ;-) \r\n\r\nI'll fix it when on desk.","created_at":"2017-04-11T22:30:01Z","updated_at":"2017-04-11T22:30:02Z","html_url":"https://github.com/joomla/joomla-cms/pull/10962#discussion_r111028952","pull_request_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/10962","_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments/111028952"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/10962#discussion_r111028952"},"pull_request":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/10962"}}},"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/10962","id":75640116,"html_url":"https://github.com/joomla/joomla-cms/pull/10962","diff_url":"https://github.com/joomla/joomla-cms/pull/10962.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/10962.patch","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/10962","number":10962,"state":"open","locked":false,"title":"Refactor database drivers - push up desctructor","user":{"login":"izharaazmi","id":6706189,"avatar_url":"https://avatars1.githubusercontent.com/u/6706189?v=3","gravatar_id":"","url":"https://api.github.com/users/izharaazmi","html_url":"https://github.com/izharaazmi","followers_url":"https://api.github.com/users/izharaazmi/followers","following_url":"https://api.github.com/users/izharaazmi/following{/other_user}","gists_url":"https://api.github.com/users/izharaazmi/gists{/gist_id}","starred_url":"https://api.github.com/users/izharaazmi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/izharaazmi/subscriptions","organizations_url":"https://api.github.com/users/izharaazmi/orgs","repos_url":"https://api.github.com/users/izharaazmi/repos","events_url":"https://api.github.com/users/izharaazmi/events{/privacy}","received_events_url":"https://api.github.com/users/izharaazmi/received_events","type":"User","site_admin":false},"body":"#### Summary of Changes\n1. Push up the destructor from various database drivers to their parent abstract class JDatabaseDriver as it almost every time just does one thing viz `disconnect()`. Otherwise it can always be overridden.\n2. Never `unset` class property. `$this->connection` set to null in disconnect methods of the db drivers.\n3. Nosql connect return type is void not bool.\n#### Testing Instructions\n\nMake sure the disconnect / connect using all the database drivers work correctly without any warning/notice.\n\nWithout this patch calling disconnect followed by connect will raise PHP warning. After this patch it should work fine.\n","created_at":"2016-06-29T12:37:06Z","updated_at":"2017-04-11T22:30:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f5da45257b34457a1075f651b021fa894e6463bb","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/10962/commits","review_comments_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/10962/comments","review_comment_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/10962/comments","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/834a8eb31b2e5e239c667d3650fedc8789da5c9e","head":{"label":"izharaazmi:dbdrivers","ref":"dbdrivers","sha":"834a8eb31b2e5e239c667d3650fedc8789da5c9e","user":{"login":"izharaazmi","id":6706189,"avatar_url":"https://avatars1.githubusercontent.com/u/6706189?v=3","gravatar_id":"","url":"https://api.github.com/users/izharaazmi","html_url":"https://github.com/izharaazmi","followers_url":"https://api.github.com/users/izharaazmi/followers","following_url":"https://api.github.com/users/izharaazmi/following{/other_user}","gists_url":"https://api.github.com/users/izharaazmi/gists{/gist_id}","starred_url":"https://api.github.com/users/izharaazmi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/izharaazmi/subscriptions","organizations_url":"https://api.github.com/users/izharaazmi/orgs","repos_url":"https://api.github.com/users/izharaazmi/repos","events_url":"https://api.github.com/users/izharaazmi/events{/privacy}","received_events_url":"https://api.github.com/users/izharaazmi/received_events","type":"User","site_admin":false},"repo":{"id":17852054,"name":"joomla-cms","full_name":"izharaazmi/joomla-cms","owner":{"login":"izharaazmi","id":6706189,"avatar_url":"https://avatars1.githubusercontent.com/u/6706189?v=3","gravatar_id":"","url":"https://api.github.com/users/izharaazmi","html_url":"https://github.com/izharaazmi","followers_url":"https://api.github.com/users/izharaazmi/followers","following_url":"https://api.github.com/users/izharaazmi/following{/other_user}","gists_url":"https://api.github.com/users/izharaazmi/gists{/gist_id}","starred_url":"https://api.github.com/users/izharaazmi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/izharaazmi/subscriptions","organizations_url":"https://api.github.com/users/izharaazmi/orgs","repos_url":"https://api.github.com/users/izharaazmi/repos","events_url":"https://api.github.com/users/izharaazmi/events{/privacy}","received_events_url":"https://api.github.com/users/izharaazmi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/izharaazmi/joomla-cms","description":"Home of the Joomla! Content Management System","fork":true,"url":"https://api.github.com/repos/izharaazmi/joomla-cms","forks_url":"https://api.github.com/repos/izharaazmi/joomla-cms/forks","keys_url":"https://api.github.com/repos/izharaazmi/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/izharaazmi/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/izharaazmi/joomla-cms/teams","hooks_url":"https://api.github.com/repos/izharaazmi/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/izharaazmi/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/izharaazmi/joomla-cms/events","assignees_url":"https://api.github.com/repos/izharaazmi/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/izharaazmi/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/izharaazmi/joomla-cms/tags","blobs_url":"https://api.github.com/repos/izharaazmi/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/izharaazmi/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/izharaazmi/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/izharaazmi/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/izharaazmi/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/izharaazmi/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/izharaazmi/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/izharaazmi/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/izharaazmi/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/izharaazmi/joomla-cms/subscription","commits_url":"https://api.github.com/repos/izharaazmi/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/izharaazmi/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/izharaazmi/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/izharaazmi/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/izharaazmi/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/izharaazmi/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/izharaazmi/joomla-cms/merges","archive_url":"https://api.github.com/repos/izharaazmi/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/izharaazmi/joomla-cms/downloads","issues_url":"https://api.github.com/repos/izharaazmi/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/izharaazmi/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/izharaazmi/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/izharaazmi/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/izharaazmi/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/izharaazmi/joomla-cms/releases{/id}","deployments_url":"https://api.github.com/repos/izharaazmi/joomla-cms/deployments","created_at":"2014-03-18T03:09:04Z","updated_at":"2016-10-18T15:02:22Z","pushed_at":"2017-04-11T15:20:53Z","git_url":"git://github.com/izharaazmi/joomla-cms.git","ssh_url":"git@github.com:izharaazmi/joomla-cms.git","clone_url":"https://github.com/izharaazmi/joomla-cms.git","svn_url":"https://github.com/izharaazmi/joomla-cms","homepage":"http://joomla.org","size":174509,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"staging"}},"base":{"label":"joomla:staging","ref":"staging","sha":"06d664054f0ca4394ce2c7d2c7c91887510a3f6d","user":{"login":"joomla","id":751633,"avatar_url":"https://avatars0.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"repo":{"id":2464908,"name":"joomla-cms","full_name":"joomla/joomla-cms","owner":{"login":"joomla","id":751633,"avatar_url":"https://avatars0.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/joomla/joomla-cms","description":"Home of the Joomla! Content Management System","fork":false,"url":"https://api.github.com/repos/joomla/joomla-cms","forks_url":"https://api.github.com/repos/joomla/joomla-cms/forks","keys_url":"https://api.github.com/repos/joomla/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joomla/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joomla/joomla-cms/teams","hooks_url":"https://api.github.com/repos/joomla/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/joomla/joomla-cms/events","assignees_url":"https://api.github.com/repos/joomla/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/joomla/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/joomla/joomla-cms/tags","blobs_url":"https://api.github.com/repos/joomla/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joomla/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joomla/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/joomla/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/joomla/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/joomla/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/joomla/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/joomla/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/joomla/joomla-cms/subscription","commits_url":"https://api.github.com/repos/joomla/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/joomla/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/joomla/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/joomla/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joomla/joomla-cms/merges","archive_url":"https://api.github.com/repos/joomla/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joomla/joomla-cms/downloads","issues_url":"https://api.github.com/repos/joomla/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/joomla/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/joomla/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/joomla/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joomla/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/joomla/joomla-cms/releases{/id}","deployments_url":"https://api.github.com/repos/joomla/joomla-cms/deployments","created_at":"2011-09-27T02:07:38Z","updated_at":"2017-04-11T21:27:48Z","pushed_at":"2017-04-11T21:55:31Z","git_url":"git://github.com/joomla/joomla-cms.git","ssh_url":"git@github.com:joomla/joomla-cms.git","clone_url":"https://github.com/joomla/joomla-cms.git","svn_url":"https://github.com/joomla/joomla-cms","homepage":"https://www.joomla.org","size":187795,"stargazers_count":2311,"watchers_count":2311,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2462,"mirror_url":null,"open_issues_count":750,"forks":2462,"open_issues":750,"watchers":2311,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/10962"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/10962"},"issue":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/10962"},"comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/10962/comments"},"review_comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/10962/comments"},"review_comment":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/10962/commits"},"statuses":{"href":"https://api.github.com/repos/joomla/joomla-cms/statuses/834a8eb31b2e5e239c667d3650fedc8789da5c9e"}}}}
{"actor":{"display_login":"izharaazmi"}}