{"action":"closed","number":12023,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/12023","id":112494295,"html_url":"https://github.com/nodejs/node/pull/12023","diff_url":"https://github.com/nodejs/node/pull/12023.diff","patch_url":"https://github.com/nodejs/node/pull/12023.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/12023","number":12023,"state":"closed","locked":false,"title":"lib: remove an unnecessary coverage check","user":{"login":"Fishrock123","id":1093990,"avatar_url":"https://avatars3.githubusercontent.com/u/1093990?v=3","gravatar_id":"","url":"https://api.github.com/users/Fishrock123","html_url":"https://github.com/Fishrock123","followers_url":"https://api.github.com/users/Fishrock123/followers","following_url":"https://api.github.com/users/Fishrock123/following{/other_user}","gists_url":"https://api.github.com/users/Fishrock123/gists{/gist_id}","starred_url":"https://api.github.com/users/Fishrock123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fishrock123/subscriptions","organizations_url":"https://api.github.com/users/Fishrock123/orgs","repos_url":"https://api.github.com/users/Fishrock123/repos","events_url":"https://api.github.com/users/Fishrock123/events{/privacy}","received_events_url":"https://api.github.com/users/Fishrock123/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [ ] tests and/or benchmarks are included\r\n- [ ] documentation is changed or added\r\n- [x] commit message follows [commit guidelines][]\r\n\r\n##### Affected core subsystem(s)\r\n<!-- Provide affected core subsystem(s) (like doc, cluster, crypto, etc). -->\r\ncoverage\r\n\r\n[commit guidelines]: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-guidelines\r\n\r\nFixes: https://github.com/nodejs/node/issues/11445\r\nRefs: f65a48fc8f89071dc326e4d84646b5cbcfa8eca7\r\n\r\nBased on @addaleax's [comment here](https://github.com/nodejs/node/issues/11445#issuecomment-280765078).\r\n\r\n## Before (coverage.nodejs.org, `master`)\r\n\r\n<img width=\"785\" alt=\"screen shot 2017-03-24 at 12 15 20 pm\" src=\"https://cloud.githubusercontent.com/assets/1093990/24303643/23f5275c-108d-11e7-9bfc-ab522985411b.png\">\r\n\r\n## After\r\n\r\n<img width=\"792\" alt=\"screen shot 2017-03-24 at 12 15 27 pm\" src=\"https://cloud.githubusercontent.com/assets/1093990/24303654/2c60f074-108d-11e7-9669-53c82781c0e7.png\">\r\n\r\nAnd the specific `process._exiting` lines that f65a48fc8f89071dc326e4d84646b5cbcfa8eca7 was supposed to hit are indeed hit with this change:\r\n\r\n<img width=\"583\" alt=\"screen shot 2017-03-24 at 12 25 52 pm\" src=\"https://cloud.githubusercontent.com/assets/1093990/24303688/42095f24-108d-11e7-9330-27a8d1f6c9b2.png\">\r\n\r\ncc @addaleax, @mhdawson @CurryKitten \r\n","created_at":"2017-03-24T16:27:57Z","updated_at":"2017-03-26T09:34:05Z","closed_at":"2017-03-26T09:34:05Z","merged_at":null,"merge_commit_sha":"a9b80a6d3ef95c0dece31a50dd01a1d6e3243b76","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/12023/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/12023/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/12023/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/4b7132cf5b71924e966d9c56bdc17497071031a4","head":{"label":"Fishrock123:coverage-remove-unnecessary-check","ref":"coverage-remove-unnecessary-check","sha":"4b7132cf5b71924e966d9c56bdc17497071031a4","user":{"login":"Fishrock123","id":1093990,"avatar_url":"https://avatars3.githubusercontent.com/u/1093990?v=3","gravatar_id":"","url":"https://api.github.com/users/Fishrock123","html_url":"https://github.com/Fishrock123","followers_url":"https://api.github.com/users/Fishrock123/followers","following_url":"https://api.github.com/users/Fishrock123/following{/other_user}","gists_url":"https://api.github.com/users/Fishrock123/gists{/gist_id}","starred_url":"https://api.github.com/users/Fishrock123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fishrock123/subscriptions","organizations_url":"https://api.github.com/users/Fishrock123/orgs","repos_url":"https://api.github.com/users/Fishrock123/repos","events_url":"https://api.github.com/users/Fishrock123/events{/privacy}","received_events_url":"https://api.github.com/users/Fishrock123/received_events","type":"User","site_admin":false},"repo":{"id":29684638,"name":"node","full_name":"Fishrock123/node","owner":{"login":"Fishrock123","id":1093990,"avatar_url":"https://avatars3.githubusercontent.com/u/1093990?v=3","gravatar_id":"","url":"https://api.github.com/users/Fishrock123","html_url":"https://github.com/Fishrock123","followers_url":"https://api.github.com/users/Fishrock123/followers","following_url":"https://api.github.com/users/Fishrock123/following{/other_user}","gists_url":"https://api.github.com/users/Fishrock123/gists{/gist_id}","starred_url":"https://api.github.com/users/Fishrock123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fishrock123/subscriptions","organizations_url":"https://api.github.com/users/Fishrock123/orgs","repos_url":"https://api.github.com/users/Fishrock123/repos","events_url":"https://api.github.com/users/Fishrock123/events{/privacy}","received_events_url":"https://api.github.com/users/Fishrock123/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Fishrock123/node","description":"My personal clone of Node. Currently active major branches are maintained.","fork":true,"url":"https://api.github.com/repos/Fishrock123/node","forks_url":"https://api.github.com/repos/Fishrock123/node/forks","keys_url":"https://api.github.com/repos/Fishrock123/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Fishrock123/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Fishrock123/node/teams","hooks_url":"https://api.github.com/repos/Fishrock123/node/hooks","issue_events_url":"https://api.github.com/repos/Fishrock123/node/issues/events{/number}","events_url":"https://api.github.com/repos/Fishrock123/node/events","assignees_url":"https://api.github.com/repos/Fishrock123/node/assignees{/user}","branches_url":"https://api.github.com/repos/Fishrock123/node/branches{/branch}","tags_url":"https://api.github.com/repos/Fishrock123/node/tags","blobs_url":"https://api.github.com/repos/Fishrock123/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Fishrock123/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Fishrock123/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/Fishrock123/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Fishrock123/node/statuses/{sha}","languages_url":"https://api.github.com/repos/Fishrock123/node/languages","stargazers_url":"https://api.github.com/repos/Fishrock123/node/stargazers","contributors_url":"https://api.github.com/repos/Fishrock123/node/contributors","subscribers_url":"https://api.github.com/repos/Fishrock123/node/subscribers","subscription_url":"https://api.github.com/repos/Fishrock123/node/subscription","commits_url":"https://api.github.com/repos/Fishrock123/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/Fishrock123/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/Fishrock123/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/Fishrock123/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/Fishrock123/node/contents/{+path}","compare_url":"https://api.github.com/repos/Fishrock123/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Fishrock123/node/merges","archive_url":"https://api.github.com/repos/Fishrock123/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Fishrock123/node/downloads","issues_url":"https://api.github.com/repos/Fishrock123/node/issues{/number}","pulls_url":"https://api.github.com/repos/Fishrock123/node/pulls{/number}","milestones_url":"https://api.github.com/repos/Fishrock123/node/milestones{/number}","notifications_url":"https://api.github.com/repos/Fishrock123/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Fishrock123/node/labels{/name}","releases_url":"https://api.github.com/repos/Fishrock123/node/releases{/id}","deployments_url":"https://api.github.com/repos/Fishrock123/node/deployments","created_at":"2015-01-22T15:15:17Z","updated_at":"2016-10-24T07:06:57Z","pushed_at":"2017-03-24T16:30:00Z","git_url":"git://github.com/Fishrock123/node.git","ssh_url":"git@github.com:Fishrock123/node.git","clone_url":"https://github.com/Fishrock123/node.git","svn_url":"https://github.com/Fishrock123/node","homepage":"https://nodejs.org","size":286761,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"9ff7ed23cd822dc810ddd99d63d4e2ca68635474","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars0.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars0.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2017-03-26T08:11:31Z","pushed_at":"2017-03-26T09:33:53Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":277444,"stargazers_count":33166,"watchers_count":33166,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6250,"mirror_url":null,"open_issues_count":1009,"forks":6250,"open_issues":1009,"watchers":33166,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/12023"},"html":{"href":"https://github.com/nodejs/node/pull/12023"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/12023"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/12023/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/12023/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/12023/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/4b7132cf5b71924e966d9c56bdc17497071031a4"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1,"deletions":3,"changed_files":1}}
{"actor":{"display_login":"fhinkel"}}