{"action":"created","issue":{"url":"https://api.github.com/repos/unitsofmeasurement/uom-systems/issues/81","repository_url":"https://api.github.com/repos/unitsofmeasurement/uom-systems","labels_url":"https://api.github.com/repos/unitsofmeasurement/uom-systems/issues/81/labels{/name}","comments_url":"https://api.github.com/repos/unitsofmeasurement/uom-systems/issues/81/comments","events_url":"https://api.github.com/repos/unitsofmeasurement/uom-systems/issues/81/events","html_url":"https://github.com/unitsofmeasurement/uom-systems/issues/81","id":216179409,"number":81,"title":"Create unit tests for UCUM formatter","user":{"login":"magnonasc","id":26474587,"avatar_url":"https://avatars0.githubusercontent.com/u/26474587?v=3","gravatar_id":"","url":"https://api.github.com/users/magnonasc","html_url":"https://github.com/magnonasc","followers_url":"https://api.github.com/users/magnonasc/followers","following_url":"https://api.github.com/users/magnonasc/following{/other_user}","gists_url":"https://api.github.com/users/magnonasc/gists{/gist_id}","starred_url":"https://api.github.com/users/magnonasc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magnonasc/subscriptions","organizations_url":"https://api.github.com/users/magnonasc/orgs","repos_url":"https://api.github.com/users/magnonasc/repos","events_url":"https://api.github.com/users/magnonasc/events{/privacy}","received_events_url":"https://api.github.com/users/magnonasc/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"magnonasc","id":26474587,"avatar_url":"https://avatars0.githubusercontent.com/u/26474587?v=3","gravatar_id":"","url":"https://api.github.com/users/magnonasc","html_url":"https://github.com/magnonasc","followers_url":"https://api.github.com/users/magnonasc/followers","following_url":"https://api.github.com/users/magnonasc/following{/other_user}","gists_url":"https://api.github.com/users/magnonasc/gists{/gist_id}","starred_url":"https://api.github.com/users/magnonasc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magnonasc/subscriptions","organizations_url":"https://api.github.com/users/magnonasc/orgs","repos_url":"https://api.github.com/users/magnonasc/repos","events_url":"https://api.github.com/users/magnonasc/events{/privacy}","received_events_url":"https://api.github.com/users/magnonasc/received_events","type":"User","site_admin":false},"assignees":[{"login":"magnonasc","id":26474587,"avatar_url":"https://avatars0.githubusercontent.com/u/26474587?v=3","gravatar_id":"","url":"https://api.github.com/users/magnonasc","html_url":"https://github.com/magnonasc","followers_url":"https://api.github.com/users/magnonasc/followers","following_url":"https://api.github.com/users/magnonasc/following{/other_user}","gists_url":"https://api.github.com/users/magnonasc/gists{/gist_id}","starred_url":"https://api.github.com/users/magnonasc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magnonasc/subscriptions","organizations_url":"https://api.github.com/users/magnonasc/orgs","repos_url":"https://api.github.com/users/magnonasc/repos","events_url":"https://api.github.com/users/magnonasc/events{/privacy}","received_events_url":"https://api.github.com/users/magnonasc/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2017-03-22T19:18:28Z","updated_at":"2017-03-22T20:23:57Z","closed_at":null,"body":"After fixing the problem with the formatter in #21 for the specific `m/s` case we need to create tests to make sure that it works for every other different format possible"},"comment":{"url":"https://api.github.com/repos/unitsofmeasurement/uom-systems/issues/comments/288527444","html_url":"https://github.com/unitsofmeasurement/uom-systems/issues/81#issuecomment-288527444","issue_url":"https://api.github.com/repos/unitsofmeasurement/uom-systems/issues/81","id":288527444,"user":{"login":"magnonasc","id":26474587,"avatar_url":"https://avatars0.githubusercontent.com/u/26474587?v=3","gravatar_id":"","url":"https://api.github.com/users/magnonasc","html_url":"https://github.com/magnonasc","followers_url":"https://api.github.com/users/magnonasc/followers","following_url":"https://api.github.com/users/magnonasc/following{/other_user}","gists_url":"https://api.github.com/users/magnonasc/gists{/gist_id}","starred_url":"https://api.github.com/users/magnonasc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magnonasc/subscriptions","organizations_url":"https://api.github.com/users/magnonasc/orgs","repos_url":"https://api.github.com/users/magnonasc/repos","events_url":"https://api.github.com/users/magnonasc/events{/privacy}","received_events_url":"https://api.github.com/users/magnonasc/received_events","type":"User","site_admin":false},"created_at":"2017-03-22T20:23:57Z","updated_at":"2017-03-22T20:23:57Z","body":"But talking within the scope of `UCUM`, we should only test their units... For example, if you have:\r\n```\r\n\t@Test\r\n\tpublic void testFormat4() {\r\n\t\tUnit<Speed> kph = Unit.KILOMETRE_PER_HOUR;\r\n\t\tassertEquals(\"km/h\", kph.toString());\r\n\t}\r\n```\r\nin `systems.uom.ucum.format.UnitFormatTest`\r\nand\r\n```\r\n\t@Test\r\n\tpublic void testFormat2() {\r\n\t\tUnit<Speed> kph = Unit.KILOMETRE_PER_HOUR;\r\n\t\tassertEquals(\"km/h\", kph.toString());\r\n\t}\r\n```\r\nin `si.uom.UnitFormatTest`, where both are the same unit, what are you really testing from `UCUM`? That's what I'm saying, although we have tests for that in other modules, we need to test in `UCUM` the units of `UCUM` only."}}
{"actor":{"display_login":"magnonasc"}}