{"action":"created","issue":{"url":"https://api.github.com/repos/elastic/elasticsearch/issues/20301","repository_url":"https://api.github.com/repos/elastic/elasticsearch","labels_url":"https://api.github.com/repos/elastic/elasticsearch/issues/20301/labels{/name}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/issues/20301/comments","events_url":"https://api.github.com/repos/elastic/elasticsearch/issues/20301/events","html_url":"https://github.com/elastic/elasticsearch/pull/20301","id":174782116,"number":20301,"title":"Remove specialized timeValueField() methods in XContentBuilder","user":{"login":"tlrx","id":642733,"avatar_url":"https://avatars2.githubusercontent.com/u/642733?v=3","gravatar_id":"","url":"https://api.github.com/users/tlrx","html_url":"https://github.com/tlrx","followers_url":"https://api.github.com/users/tlrx/followers","following_url":"https://api.github.com/users/tlrx/following{/other_user}","gists_url":"https://api.github.com/users/tlrx/gists{/gist_id}","starred_url":"https://api.github.com/users/tlrx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tlrx/subscriptions","organizations_url":"https://api.github.com/users/tlrx/orgs","repos_url":"https://api.github.com/users/tlrx/repos","events_url":"https://api.github.com/users/tlrx/events{/privacy}","received_events_url":"https://api.github.com/users/tlrx/received_events","type":"User","site_admin":false},"labels":[{"id":152517143,"url":"https://api.github.com/repos/elastic/elasticsearch/labels/:REST","name":":REST","color":"009800","default":false},{"id":73544,"url":"https://api.github.com/repos/elastic/elasticsearch/labels/non-issue","name":"non-issue","color":"cfcfcf","default":false},{"id":94283388,"url":"https://api.github.com/repos/elastic/elasticsearch/labels/review","name":"review","color":"0052cc","default":false},{"id":605514703,"url":"https://api.github.com/repos/elastic/elasticsearch/labels/v5.4.2","name":"v5.4.2","color":"dddddd","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-09-02T15:08:56Z","updated_at":"2017-06-09T05:56:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/20301","html_url":"https://github.com/elastic/elasticsearch/pull/20301","diff_url":"https://github.com/elastic/elasticsearch/pull/20301.diff","patch_url":"https://github.com/elastic/elasticsearch/pull/20301.patch"},"body":"This PR renames some specialized method like \n\n`timeValueField(String rawFieldName, String readableFieldName, TimeValue timeValue)`\n\nin favor of a bit more concise method:\n\n`field(String name, TimeValue timeValue)`\n\nThe method takes care of writing the human readable field and also the time value field using a default `TimeUnit` configured at the `XContentBuilder` level. This ensures that human readable field and time value fields share the exact same prefix and allows to build objects using a specific time unit.\n\nNote: this PR breaks some field names that were not fully coherent. If agreed, I'll document them as breaking change before merging.\n"},"comment":{"url":"https://api.github.com/repos/elastic/elasticsearch/issues/comments/307302316","html_url":"https://github.com/elastic/elasticsearch/pull/20301#issuecomment-307302316","issue_url":"https://api.github.com/repos/elastic/elasticsearch/issues/20301","id":307302316,"user":{"login":"rjernst","id":289412,"avatar_url":"https://avatars0.githubusercontent.com/u/289412?v=3","gravatar_id":"","url":"https://api.github.com/users/rjernst","html_url":"https://github.com/rjernst","followers_url":"https://api.github.com/users/rjernst/followers","following_url":"https://api.github.com/users/rjernst/following{/other_user}","gists_url":"https://api.github.com/users/rjernst/gists{/gist_id}","starred_url":"https://api.github.com/users/rjernst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjernst/subscriptions","organizations_url":"https://api.github.com/users/rjernst/orgs","repos_url":"https://api.github.com/users/rjernst/repos","events_url":"https://api.github.com/users/rjernst/events{/privacy}","received_events_url":"https://api.github.com/users/rjernst/received_events","type":"User","site_admin":false},"created_at":"2017-06-09T05:56:37Z","updated_at":"2017-06-09T05:56:37Z","body":"@tlrx Do you want to bring this PR up to date with master?"}}
{"actor":{"display_login":"rjernst"}}