{"action":"closed","number":337,"pull_request":{"url":"https://api.github.com/repos/stripe/stripe-android/pulls/337","id":136575548,"html_url":"https://github.com/stripe/stripe-android/pull/337","diff_url":"https://github.com/stripe/stripe-android/pull/337.diff","patch_url":"https://github.com/stripe/stripe-android/pull/337.patch","issue_url":"https://api.github.com/repos/stripe/stripe-android/issues/337","number":337,"state":"closed","locked":false,"title":"Stripe Activity to reuse UI code","user":{"login":"ksun-stripe","id":30061905,"avatar_url":"https://avatars3.githubusercontent.com/u/30061905?v=4","gravatar_id":"","url":"https://api.github.com/users/ksun-stripe","html_url":"https://github.com/ksun-stripe","followers_url":"https://api.github.com/users/ksun-stripe/followers","following_url":"https://api.github.com/users/ksun-stripe/following{/other_user}","gists_url":"https://api.github.com/users/ksun-stripe/gists{/gist_id}","starred_url":"https://api.github.com/users/ksun-stripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ksun-stripe/subscriptions","organizations_url":"https://api.github.com/users/ksun-stripe/orgs","repos_url":"https://api.github.com/users/ksun-stripe/repos","events_url":"https://api.github.com/users/ksun-stripe/events{/privacy}","received_events_url":"https://api.github.com/users/ksun-stripe/received_events","type":"User","site_admin":false},"body":"Changes:\r\nCreated a StripeActivity that allows up to reuse UI code. I pulled the header into it but not the error rendering. \r\n\r\nAlso:\r\n-Old AddAddressActivity is replaced with AddAddressActivityExample. AddAddressExample be will added back in the example app before merging into master. New AddAddressActivity around to test UI.\r\n- Reformatted Manifest\r\n- Ported AddSourcesActivity to StripeActivity\r\n\r\n\r\nr? @mrmcduff-stripe \r\n\r\n![screen shot 2017-08-18 at 1 55 36 pm](https://user-images.githubusercontent.com/30061905/29479969-ff2f9f2c-8429-11e7-8509-a0db5a17a4e4.png)\r\n\r\n![screen shot 2017-08-18 at 3 30 27 pm](https://user-images.githubusercontent.com/30061905/29480009-410d3d64-842a-11e7-84ff-265228985671.png)\r\n![screen shot 2017-08-18 at 3 30 20 pm](https://user-images.githubusercontent.com/30061905/29480010-42d3f6c4-842a-11e7-92f8-9369496c4ff7.png)\r\n\r\nUI tests continue to pass? LMK if you have good ideas for things in the StripeActivity to test","created_at":"2017-08-18T22:29:04Z","updated_at":"2017-08-21T21:12:15Z","closed_at":"2017-08-21T21:12:15Z","merged_at":"2017-08-21T21:12:15Z","merge_commit_sha":"02f0da78bc121964e98ec2559f3873b3f442e2d7","assignee":{"login":"ksun-stripe","id":30061905,"avatar_url":"https://avatars3.githubusercontent.com/u/30061905?v=4","gravatar_id":"","url":"https://api.github.com/users/ksun-stripe","html_url":"https://github.com/ksun-stripe","followers_url":"https://api.github.com/users/ksun-stripe/followers","following_url":"https://api.github.com/users/ksun-stripe/following{/other_user}","gists_url":"https://api.github.com/users/ksun-stripe/gists{/gist_id}","starred_url":"https://api.github.com/users/ksun-stripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ksun-stripe/subscriptions","organizations_url":"https://api.github.com/users/ksun-stripe/orgs","repos_url":"https://api.github.com/users/ksun-stripe/repos","events_url":"https://api.github.com/users/ksun-stripe/events{/privacy}","received_events_url":"https://api.github.com/users/ksun-stripe/received_events","type":"User","site_admin":false},"assignees":[{"login":"ksun-stripe","id":30061905,"avatar_url":"https://avatars3.githubusercontent.com/u/30061905?v=4","gravatar_id":"","url":"https://api.github.com/users/ksun-stripe","html_url":"https://github.com/ksun-stripe","followers_url":"https://api.github.com/users/ksun-stripe/followers","following_url":"https://api.github.com/users/ksun-stripe/following{/other_user}","gists_url":"https://api.github.com/users/ksun-stripe/gists{/gist_id}","starred_url":"https://api.github.com/users/ksun-stripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ksun-stripe/subscriptions","organizations_url":"https://api.github.com/users/ksun-stripe/orgs","repos_url":"https://api.github.com/users/ksun-stripe/repos","events_url":"https://api.github.com/users/ksun-stripe/events{/privacy}","received_events_url":"https://api.github.com/users/ksun-stripe/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/stripe/stripe-android/pulls/337/commits","review_comments_url":"https://api.github.com/repos/stripe/stripe-android/pulls/337/comments","review_comment_url":"https://api.github.com/repos/stripe/stripe-android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/stripe/stripe-android/issues/337/comments","statuses_url":"https://api.github.com/repos/stripe/stripe-android/statuses/04a5ad260328c759ad69dc61460aa38d7de216bd","head":{"label":"stripe:ksun-stripe-activity","ref":"ksun-stripe-activity","sha":"04a5ad260328c759ad69dc61460aa38d7de216bd","user":{"login":"stripe","id":856813,"avatar_url":"https://avatars1.githubusercontent.com/u/856813?v=4","gravatar_id":"","url":"https://api.github.com/users/stripe","html_url":"https://github.com/stripe","followers_url":"https://api.github.com/users/stripe/followers","following_url":"https://api.github.com/users/stripe/following{/other_user}","gists_url":"https://api.github.com/users/stripe/gists{/gist_id}","starred_url":"https://api.github.com/users/stripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stripe/subscriptions","organizations_url":"https://api.github.com/users/stripe/orgs","repos_url":"https://api.github.com/users/stripe/repos","events_url":"https://api.github.com/users/stripe/events{/privacy}","received_events_url":"https://api.github.com/users/stripe/received_events","type":"Organization","site_admin":false},"repo":{"id":6926049,"name":"stripe-android","full_name":"stripe/stripe-android","owner":{"login":"stripe","id":856813,"avatar_url":"https://avatars1.githubusercontent.com/u/856813?v=4","gravatar_id":"","url":"https://api.github.com/users/stripe","html_url":"https://github.com/stripe","followers_url":"https://api.github.com/users/stripe/followers","following_url":"https://api.github.com/users/stripe/following{/other_user}","gists_url":"https://api.github.com/users/stripe/gists{/gist_id}","starred_url":"https://api.github.com/users/stripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stripe/subscriptions","organizations_url":"https://api.github.com/users/stripe/orgs","repos_url":"https://api.github.com/users/stripe/repos","events_url":"https://api.github.com/users/stripe/events{/privacy}","received_events_url":"https://api.github.com/users/stripe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/stripe/stripe-android","description":"Stripe Android SDK    ","fork":false,"url":"https://api.github.com/repos/stripe/stripe-android","forks_url":"https://api.github.com/repos/stripe/stripe-android/forks","keys_url":"https://api.github.com/repos/stripe/stripe-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stripe/stripe-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stripe/stripe-android/teams","hooks_url":"https://api.github.com/repos/stripe/stripe-android/hooks","issue_events_url":"https://api.github.com/repos/stripe/stripe-android/issues/events{/number}","events_url":"https://api.github.com/repos/stripe/stripe-android/events","assignees_url":"https://api.github.com/repos/stripe/stripe-android/assignees{/user}","branches_url":"https://api.github.com/repos/stripe/stripe-android/branches{/branch}","tags_url":"https://api.github.com/repos/stripe/stripe-android/tags","blobs_url":"https://api.github.com/repos/stripe/stripe-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stripe/stripe-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stripe/stripe-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/stripe/stripe-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stripe/stripe-android/statuses/{sha}","languages_url":"https://api.github.com/repos/stripe/stripe-android/languages","stargazers_url":"https://api.github.com/repos/stripe/stripe-android/stargazers","contributors_url":"https://api.github.com/repos/stripe/stripe-android/contributors","subscribers_url":"https://api.github.com/repos/stripe/stripe-android/subscribers","subscription_url":"https://api.github.com/repos/stripe/stripe-android/subscription","commits_url":"https://api.github.com/repos/stripe/stripe-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/stripe/stripe-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/stripe/stripe-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/stripe/stripe-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/stripe/stripe-android/contents/{+path}","compare_url":"https://api.github.com/repos/stripe/stripe-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stripe/stripe-android/merges","archive_url":"https://api.github.com/repos/stripe/stripe-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stripe/stripe-android/downloads","issues_url":"https://api.github.com/repos/stripe/stripe-android/issues{/number}","pulls_url":"https://api.github.com/repos/stripe/stripe-android/pulls{/number}","milestones_url":"https://api.github.com/repos/stripe/stripe-android/milestones{/number}","notifications_url":"https://api.github.com/repos/stripe/stripe-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stripe/stripe-android/labels{/name}","releases_url":"https://api.github.com/repos/stripe/stripe-android/releases{/id}","deployments_url":"https://api.github.com/repos/stripe/stripe-android/deployments","created_at":"2012-11-29T18:11:30Z","updated_at":"2017-08-09T09:45:58Z","pushed_at":"2017-08-21T21:12:15Z","git_url":"git://github.com/stripe/stripe-android.git","ssh_url":"git@github.com:stripe/stripe-android.git","clone_url":"https://github.com/stripe/stripe-android.git","svn_url":"https://github.com/stripe/stripe-android","homepage":"https://stripe.com","size":9369,"stargazers_count":293,"watchers_count":293,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":200,"mirror_url":null,"open_issues_count":1,"forks":200,"open_issues":1,"watchers":293,"default_branch":"master"}},"base":{"label":"stripe:ksun-address","ref":"ksun-address","sha":"727c3fbe7fe0d8e18643a7d985f1209985ea7db6","user":{"login":"stripe","id":856813,"avatar_url":"https://avatars1.githubusercontent.com/u/856813?v=4","gravatar_id":"","url":"https://api.github.com/users/stripe","html_url":"https://github.com/stripe","followers_url":"https://api.github.com/users/stripe/followers","following_url":"https://api.github.com/users/stripe/following{/other_user}","gists_url":"https://api.github.com/users/stripe/gists{/gist_id}","starred_url":"https://api.github.com/users/stripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stripe/subscriptions","organizations_url":"https://api.github.com/users/stripe/orgs","repos_url":"https://api.github.com/users/stripe/repos","events_url":"https://api.github.com/users/stripe/events{/privacy}","received_events_url":"https://api.github.com/users/stripe/received_events","type":"Organization","site_admin":false},"repo":{"id":6926049,"name":"stripe-android","full_name":"stripe/stripe-android","owner":{"login":"stripe","id":856813,"avatar_url":"https://avatars1.githubusercontent.com/u/856813?v=4","gravatar_id":"","url":"https://api.github.com/users/stripe","html_url":"https://github.com/stripe","followers_url":"https://api.github.com/users/stripe/followers","following_url":"https://api.github.com/users/stripe/following{/other_user}","gists_url":"https://api.github.com/users/stripe/gists{/gist_id}","starred_url":"https://api.github.com/users/stripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stripe/subscriptions","organizations_url":"https://api.github.com/users/stripe/orgs","repos_url":"https://api.github.com/users/stripe/repos","events_url":"https://api.github.com/users/stripe/events{/privacy}","received_events_url":"https://api.github.com/users/stripe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/stripe/stripe-android","description":"Stripe Android SDK    ","fork":false,"url":"https://api.github.com/repos/stripe/stripe-android","forks_url":"https://api.github.com/repos/stripe/stripe-android/forks","keys_url":"https://api.github.com/repos/stripe/stripe-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stripe/stripe-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stripe/stripe-android/teams","hooks_url":"https://api.github.com/repos/stripe/stripe-android/hooks","issue_events_url":"https://api.github.com/repos/stripe/stripe-android/issues/events{/number}","events_url":"https://api.github.com/repos/stripe/stripe-android/events","assignees_url":"https://api.github.com/repos/stripe/stripe-android/assignees{/user}","branches_url":"https://api.github.com/repos/stripe/stripe-android/branches{/branch}","tags_url":"https://api.github.com/repos/stripe/stripe-android/tags","blobs_url":"https://api.github.com/repos/stripe/stripe-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stripe/stripe-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stripe/stripe-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/stripe/stripe-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stripe/stripe-android/statuses/{sha}","languages_url":"https://api.github.com/repos/stripe/stripe-android/languages","stargazers_url":"https://api.github.com/repos/stripe/stripe-android/stargazers","contributors_url":"https://api.github.com/repos/stripe/stripe-android/contributors","subscribers_url":"https://api.github.com/repos/stripe/stripe-android/subscribers","subscription_url":"https://api.github.com/repos/stripe/stripe-android/subscription","commits_url":"https://api.github.com/repos/stripe/stripe-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/stripe/stripe-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/stripe/stripe-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/stripe/stripe-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/stripe/stripe-android/contents/{+path}","compare_url":"https://api.github.com/repos/stripe/stripe-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stripe/stripe-android/merges","archive_url":"https://api.github.com/repos/stripe/stripe-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stripe/stripe-android/downloads","issues_url":"https://api.github.com/repos/stripe/stripe-android/issues{/number}","pulls_url":"https://api.github.com/repos/stripe/stripe-android/pulls{/number}","milestones_url":"https://api.github.com/repos/stripe/stripe-android/milestones{/number}","notifications_url":"https://api.github.com/repos/stripe/stripe-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stripe/stripe-android/labels{/name}","releases_url":"https://api.github.com/repos/stripe/stripe-android/releases{/id}","deployments_url":"https://api.github.com/repos/stripe/stripe-android/deployments","created_at":"2012-11-29T18:11:30Z","updated_at":"2017-08-09T09:45:58Z","pushed_at":"2017-08-21T21:12:15Z","git_url":"git://github.com/stripe/stripe-android.git","ssh_url":"git@github.com:stripe/stripe-android.git","clone_url":"https://github.com/stripe/stripe-android.git","svn_url":"https://github.com/stripe/stripe-android","homepage":"https://stripe.com","size":9369,"stargazers_count":293,"watchers_count":293,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":200,"mirror_url":null,"open_issues_count":1,"forks":200,"open_issues":1,"watchers":293,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/stripe/stripe-android/pulls/337"},"html":{"href":"https://github.com/stripe/stripe-android/pull/337"},"issue":{"href":"https://api.github.com/repos/stripe/stripe-android/issues/337"},"comments":{"href":"https://api.github.com/repos/stripe/stripe-android/issues/337/comments"},"review_comments":{"href":"https://api.github.com/repos/stripe/stripe-android/pulls/337/comments"},"review_comment":{"href":"https://api.github.com/repos/stripe/stripe-android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/stripe/stripe-android/pulls/337/commits"},"statuses":{"href":"https://api.github.com/repos/stripe/stripe-android/statuses/04a5ad260328c759ad69dc61460aa38d7de216bd"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"ksun-stripe","id":30061905,"avatar_url":"https://avatars3.githubusercontent.com/u/30061905?v=4","gravatar_id":"","url":"https://api.github.com/users/ksun-stripe","html_url":"https://github.com/ksun-stripe","followers_url":"https://api.github.com/users/ksun-stripe/followers","following_url":"https://api.github.com/users/ksun-stripe/following{/other_user}","gists_url":"https://api.github.com/users/ksun-stripe/gists{/gist_id}","starred_url":"https://api.github.com/users/ksun-stripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ksun-stripe/subscriptions","organizations_url":"https://api.github.com/users/ksun-stripe/orgs","repos_url":"https://api.github.com/users/ksun-stripe/repos","events_url":"https://api.github.com/users/ksun-stripe/events{/privacy}","received_events_url":"https://api.github.com/users/ksun-stripe/received_events","type":"User","site_admin":false},"comments":1,"review_comments":5,"maintainer_can_modify":false,"commits":2,"additions":226,"deletions":116,"changed_files":14}}
{"actor":{"display_login":"ksun-stripe"}}