{"action":"created","issue":{"url":"https://api.github.com/repos/ocaml/ocaml/issues/1463","repository_url":"https://api.github.com/repos/ocaml/ocaml","labels_url":"https://api.github.com/repos/ocaml/ocaml/issues/1463/labels{/name}","comments_url":"https://api.github.com/repos/ocaml/ocaml/issues/1463/comments","events_url":"https://api.github.com/repos/ocaml/ocaml/issues/1463/events","html_url":"https://github.com/ocaml/ocaml/pull/1463","id":270930535,"number":1463,"title":"Let ocamltest use other runtime variants","user":{"login":"shindere","id":5877758,"avatar_url":"https://avatars1.githubusercontent.com/u/5877758?v=4","gravatar_id":"","url":"https://api.github.com/users/shindere","html_url":"https://github.com/shindere","followers_url":"https://api.github.com/users/shindere/followers","following_url":"https://api.github.com/users/shindere/following{/other_user}","gists_url":"https://api.github.com/users/shindere/gists{/gist_id}","starred_url":"https://api.github.com/users/shindere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shindere/subscriptions","organizations_url":"https://api.github.com/users/shindere/orgs","repos_url":"https://api.github.com/users/shindere/repos","events_url":"https://api.github.com/users/shindere/events{/privacy}","received_events_url":"https://api.github.com/users/shindere/received_events","type":"User","site_admin":false},"labels":[{"id":489423308,"url":"https://api.github.com/repos/ocaml/ocaml/labels/no-change-entry-needed","name":"no-change-entry-needed","color":"FFFFFF","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2017-11-03T10:18:04Z","updated_at":"2017-11-11T17:49:29Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ocaml/ocaml/pulls/1463","html_url":"https://github.com/ocaml/ocaml/pull/1463","diff_url":"https://github.com/ocaml/ocaml/pull/1463.diff","patch_url":"https://github.com/ocaml/ocaml/pull/1463.patch"},"body":"Before this PR, ocamltest was not able to run either the debug or the\ninstrumented runtime.\n\nIn particular, when Travis was running the testsuite with the debug-runtime\nby setting the USE_RUNTIME environment variable, the tests that had\nalready been migrated to be run by ocamltest were still run with the\n\"normal\" runtime, so the test was actually not testing anything new in that\ncase.\n\nThis PR fixes this and makes sure ocamltest runs the runtime variants\nproperly when instructed to do so.\n\nThe first commit of the PR which gets rid of the UNIXLIBVAR build variable\nin the testsuite is not directly related but it does improve the\nreadability of the makefiles and looks really harmless."},"comment":{"url":"https://api.github.com/repos/ocaml/ocaml/issues/comments/343681782","html_url":"https://github.com/ocaml/ocaml/pull/1463#issuecomment-343681782","issue_url":"https://api.github.com/repos/ocaml/ocaml/issues/1463","id":343681782,"user":{"login":"gasche","id":426238,"avatar_url":"https://avatars2.githubusercontent.com/u/426238?v=4","gravatar_id":"","url":"https://api.github.com/users/gasche","html_url":"https://github.com/gasche","followers_url":"https://api.github.com/users/gasche/followers","following_url":"https://api.github.com/users/gasche/following{/other_user}","gists_url":"https://api.github.com/users/gasche/gists{/gist_id}","starred_url":"https://api.github.com/users/gasche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gasche/subscriptions","organizations_url":"https://api.github.com/users/gasche/orgs","repos_url":"https://api.github.com/users/gasche/repos","events_url":"https://api.github.com/users/gasche/events{/privacy}","received_events_url":"https://api.github.com/users/gasche/received_events","type":"User","site_admin":false},"created_at":"2017-11-11T17:49:29Z","updated_at":"2017-11-11T17:49:29Z","author_association":"MEMBER","body":"I see, thanks for the explanation."}}
{"actor":{"display_login":"gasche"}}