{"action":"created","issue":{"url":"https://api.github.com/repos/sunscrapers/djoser/issues/203","repository_url":"https://api.github.com/repos/sunscrapers/djoser","labels_url":"https://api.github.com/repos/sunscrapers/djoser/issues/203/labels{/name}","comments_url":"https://api.github.com/repos/sunscrapers/djoser/issues/203/comments","events_url":"https://api.github.com/repos/sunscrapers/djoser/issues/203/events","html_url":"https://github.com/sunscrapers/djoser/pull/203","id":237524196,"number":203,"title":"Kn/settings rewrite","user":{"login":"KaczuH","id":6073498,"avatar_url":"https://avatars3.githubusercontent.com/u/6073498?v=3","gravatar_id":"","url":"https://api.github.com/users/KaczuH","html_url":"https://github.com/KaczuH","followers_url":"https://api.github.com/users/KaczuH/followers","following_url":"https://api.github.com/users/KaczuH/following{/other_user}","gists_url":"https://api.github.com/users/KaczuH/gists{/gist_id}","starred_url":"https://api.github.com/users/KaczuH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KaczuH/subscriptions","organizations_url":"https://api.github.com/users/KaczuH/orgs","repos_url":"https://api.github.com/users/KaczuH/repos","events_url":"https://api.github.com/users/KaczuH/events{/privacy}","received_events_url":"https://api.github.com/users/KaczuH/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2017-06-21T12:55:46Z","updated_at":"2017-06-23T09:12:12Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/sunscrapers/djoser/pulls/203","html_url":"https://github.com/sunscrapers/djoser/pull/203","diff_url":"https://github.com/sunscrapers/djoser/pull/203.diff","patch_url":"https://github.com/sunscrapers/djoser/pull/203.patch"},"body":"I saw a few problems with how we handle settings in Djoser. And decided to try solve some of them.\r\n\r\n- `settings.get(\"SEND_ACTIVATION_EMAIL\")` is cumbersome interface and it is used a lot across the code. We should look for more clear and simpler way. Thats why I decided to use `config.SEND_ACTIVATION_EMAIL` somewhat resembling how Django does.\r\n- `merge_settings_dicts` was invoked every time an setting value is looked up. This is not optimal. Additionaly djoser settings aren't so complex so why to use this recursive function? I removed it and replaced with simple approach: instantiate default djoser settings and override anything that user customized in django settings.\r\n\r\nThere is some work to do but i want to show this idea for consideration."},"comment":{"url":"https://api.github.com/repos/sunscrapers/djoser/issues/comments/310614879","html_url":"https://github.com/sunscrapers/djoser/pull/203#issuecomment-310614879","issue_url":"https://api.github.com/repos/sunscrapers/djoser/issues/203","id":310614879,"user":{"login":"mcgeeco","id":5881581,"avatar_url":"https://avatars2.githubusercontent.com/u/5881581?v=3","gravatar_id":"","url":"https://api.github.com/users/mcgeeco","html_url":"https://github.com/mcgeeco","followers_url":"https://api.github.com/users/mcgeeco/followers","following_url":"https://api.github.com/users/mcgeeco/following{/other_user}","gists_url":"https://api.github.com/users/mcgeeco/gists{/gist_id}","starred_url":"https://api.github.com/users/mcgeeco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcgeeco/subscriptions","organizations_url":"https://api.github.com/users/mcgeeco/orgs","repos_url":"https://api.github.com/users/mcgeeco/repos","events_url":"https://api.github.com/users/mcgeeco/events{/privacy}","received_events_url":"https://api.github.com/users/mcgeeco/received_events","type":"User","site_admin":false},"created_at":"2017-06-23T09:12:12Z","updated_at":"2017-06-23T09:12:12Z","body":"@piotr-szpetkowski No I see what the idea is now, it makes sense - I mainly thought it wasn't useful to go from `settings` to `config` as people might be used to looking for `settings` when they're overriding things."}}
{"actor":{"display_login":"mcgeeco"}}