{"push_id":1804155468,"size":92,"distinct_size":92,"ref":"refs/heads/gradle-plugin-3","head":"4679815dd1020187e28e381a1a2a53df235ec640","before":"45802773df57367fd00e98b8e6e20a64e93ae582","commits":[{"sha":"a349b2679ca86588b918c7bd05079ea4d6282380","author":{"name":"Aziz Murtazaev","email":"e94892160eaaf5c84c52de1ed43d476ea9324b8a@users.noreply.github.com"},"message":"Add missing `ComponentContext` param in `onCreateInitialState()` method\n\n`onCreateInitialState()` requires first param to be `ComponentContext`","distinct":true,"url":"https://api.github.com/repos/passy/litho/commits/a349b2679ca86588b918c7bd05079ea4d6282380"},{"sha":"0b295b32e2bf7a4f06b886af7f6625fd5cf6172c","author":{"name":"Sushrut Shringarputale","email":"2040e329be3593268404af602ac0ee8d4211a695@gmail.com"},"message":"Spelling correction on Litho Best Practices doc\n\nSummary:\nThe *ComponentContext* argument should be simply called `c` to make your layout code less verbose and more [NOT move] readable.\nCloses https://github.com/facebook/litho/pull/193\n\nReviewed By: IanChilds\n\nDifferential Revision:\nD5137046\n\nTags: accept2ship\n\nPulled By: passy\n\nfbshipit-source-id: 496fc2e572dfbe86c2769d2770ba4d9a6759c77d","distinct":true,"url":"https://api.github.com/repos/passy/litho/commits/0b295b32e2bf7a4f06b886af7f6625fd5cf6172c"},{"sha":"1028cbcaf33054afa52a45a28b80c4ec99ec897b","author":{"name":"Pascal Hartig","email":"89261ef73920f4eda09dbb3d5bd4204953de8413@fb.com"},"message":"Bump stable gradle plugin version\n\nSummary:\nYou get an annoying prompt from Android Studio every time you open the project.\n\nFrom the changelog:\n\n> This is a minor update that adds compatibility with Android Studio 2.3.2.\n\nReviewed By: IanChilds\n\nDifferential Revision: D5136959\n\nfbshipit-source-id: eea5714fb98c772fc6db1b326bb14a292b0b1160","distinct":true,"url":"https://api.github.com/repos/passy/litho/commits/1028cbcaf33054afa52a45a28b80c4ec99ec897b"},{"sha":"d7615f4ae457feb1c5f02c57e16e20edef0a3ee7","author":{"name":"Pascal Hartig","email":"89261ef73920f4eda09dbb3d5bd4204953de8413@fb.com"},"message":"Set up instrumentation test runner\n\nSummary:\nOoph, it's been a while that I touched a vanilla test runner. So we needed\nsomething to set up SoLoader before running our tests.\n\nThis is also meant as a template for others who want to run instrumentation\ntests for Litho. Yes, I'll write docs for it too.\n\nReviewed By: IanChilds\n\nDifferential Revision: D5137054\n\nfbshipit-source-id: 83e6597ff1157652314df12b658d7fad68ea2ca8","distinct":true,"url":"https://api.github.com/repos/passy/litho/commits/d7615f4ae457feb1c5f02c57e16e20edef0a3ee7"},{"sha":"6131e0ca92560109da2e391a7b5a911d8c9abc9c","author":{"name":"Mihaela Ogrezeanu","email":"875d19be0b233db1cc638a6f8cdc96f33bdb8233@fb.com"},"message":"Scroll to position in section hierarchy\n\nSummary: expose an api for scrolling to a position in a SectionTree given a local index of a section.\n\nReviewed By: pasqualeanatriello\n\nDifferential Revision: D5103923\n\nfbshipit-source-id: fa408e29f7985cd0d7cc70123128e3560237692f","distinct":true,"url":"https://api.github.com/repos/passy/litho/commits/6131e0ca92560109da2e391a7b5a911d8c9abc9c"},{"sha":"ce23ce424900650b840bb82ec03e68a92a6cf882","author":{"name":"Pasquale Anatriello","email":"c8b9a350bedb15a1c36a5d57a9ecf98ef7abfebf@fb.com"},"message":"Introduce Default range ratio in RecyclerBinder\n\nSummary: We were using a magic number here instead\n\nReviewed By: mihaelao\n\nDifferential Revision: D5137196\n\nfbshipit-source-id: fe40fd2d9d212383a4e66b5acbc69c4c264f825a","distinct":true,"url":"https://api.github.com/repos/passy/litho/commits/ce23ce424900650b840bb82ec03e68a92a6cf882"},{"sha":"190198d109e685ed97da98bf883d17d898f22326","author":{"name":"Hilal Alsibai","email":"09fe5b1fa42f2fd8ae17031a1fb1ec0fe91ae79e@fb.com"},"message":"Fix visibility handling example syntax errors\n\nSummary: There were a few small errors in the given example code. This fixes them.\n\nReviewed By: mihaelao\n\nDifferential Revision: D5121915\n\nfbshipit-source-id: 224c934176beb99e538cdc274b018c4afeed7419","distinct":true,"url":"https://api.github.com/repos/passy/litho/commits/190198d109e685ed97da98bf883d17d898f22326"},{"sha":"ea6f72cae77d825dba225002ca6ae2e7dabba542","author":{"name":"Georgiy Kassabli","email":"2270dbc054de5ac1b6f45b0da628f171d38a5aae@fb.com"},"message":"Changed pointScaleFactor usage to avoid accumulating error\n\nSummary: Previously pointScaleFactor was stored as a divider that opened way to accumulating difference. For instance in ScreenScale=3, pointScaleFactor = 0.3333343 (0.000001 error). When used for width = 300 that error was multiplied by the number of times pointScale contained in width (300 *3 = 900) and we had almost 0.001 error accumulated. With this change Yoga will avoid such issue\n\nReviewed By: shergin\n\nDifferential Revision: D5137923\n\nfbshipit-source-id: 652b59bc3da3f35ee93ffa3695936f623298a023","distinct":true,"url":"https://api.github.com/repos/passy/litho/commits/ea6f72cae77d825dba225002ca6ae2e7dabba542"},{"sha":"fb6e5665e96fee3912982ac5b094c4c5dd17f0a5","author":{"name":"Jason Sendros-Keshka","email":"d637605e4f1e841e4bdc4b14e225e37757e501b5@fb.com"},"message":"Fix incremental mount for LithoViews with children with Transient State\n\nSummary:\nLithoView is a ViewGroup. ViewGroups have transient state if they directly have transient state or if any of their children have transient state. This applies the same incremental mount fix to children updating transient state as the LithoView directly updating transient state.\n\nNote: I think this fix kinda sucks, because it means we mount the whole thing immediately if any child in the hierarchy has transient state at any point. We should try to figure out something nicer. This is a decent fix for now.\n\nReviewed By: pasqualeanatriello\n\nDifferential Revision: D5139234\n\nfbshipit-source-id: 5d1f399607176bb90ed96e916ebe9b8015b0e075","distinct":true,"url":"https://api.github.com/repos/passy/litho/commits/fb6e5665e96fee3912982ac5b094c4c5dd17f0a5"},{"sha":"7a16af78ad2aa660bb8af5016860d1120f332b11","author":{"name":"Pasquale Anatriello","email":"c8b9a350bedb15a1c36a5d57a9ecf98ef7abfebf@fb.com"},"message":"Revert D5139234: Fix incremental mount for LithoViews with children with Transient State\n\nSummary: This reverts commit 5d1f399607176bb90ed96e916ebe9b8015b0e075\n\nDifferential Revision: D5139234\n\nfbshipit-source-id: f27636904986f0e219d7f19c005837110b7c913d","distinct":true,"url":"https://api.github.com/repos/passy/litho/commits/7a16af78ad2aa660bb8af5016860d1120f332b11"},{"sha":"f0e5dd2c3937acb44b7f9c99d2073cd0059454d2","author":{"name":"Aziz Murtazaev","email":"ddd28ae92e97b0083f9cc236b6ba275b234f92c3@fb.com"},"message":"Always hide sticky header when there are two sticky items stacked\n\nSummary: In some cases when there are stacked sticky items the overlay sticky header is not hidden.\n\nReviewed By: pasqualeanatriello\n\nDifferential Revision: D5137349\n\nfbshipit-source-id: 3a7b4c8b4dcfbaec0bf9787b0ca7cc198634a4c7","distinct":true,"url":"https://api.github.com/repos/passy/litho/commits/f0e5dd2c3937acb44b7f9c99d2073cd0059454d2"},{"sha":"d504faca525f4943f8d00d8c0120ddd1a99644c9","author":{"name":"Pasquale Anatriello","email":"c8b9a350bedb15a1c36a5d57a9ecf98ef7abfebf@fb.com"},"message":"Don't force layout params on the LithoView in RecyclerBinder\n\nSummary: This was creating problems on rotations in Messenger\n\nReviewed By: emilsjolander\n\nDifferential Revision: D5144606\n\nfbshipit-source-id: 80451ee030f7c2400525cb6979d414db566de32a","distinct":true,"url":"https://api.github.com/repos/passy/litho/commits/d504faca525f4943f8d00d8c0120ddd1a99644c9"},{"sha":"9cec7ef5848227b71a7a0521b731b9035fab3b8e","author":{"name":"Aziz Murtazaev","email":"ddd28ae92e97b0083f9cc236b6ba275b234f92c3@fb.com"},"message":"Restore state of scrolling of HorizontalScrollSpec when detaching/attaching component from/to views\n\nSummary: When `HorizontalScrollSpec` is used as sticky header the scroll position is lost when the component is transferred from recyclerview to stickyheader. This diff makes sure to record scroll position in a state and restore scroll position when component is mounted.\n\nReviewed By: pasqualeanatriello\n\nDifferential Revision: D5137459\n\nfbshipit-source-id: a254a460ff3c2d94553442e06d454c0badbbaa3a","distinct":true,"url":"https://api.github.com/repos/passy/litho/commits/9cec7ef5848227b71a7a0521b731b9035fab3b8e"},{"sha":"da7e1d52385d19b5593be465586989f888d7ea40","author":{"name":"Emil Sjolander","email":"fd01956b6f7ea3f89c72dc9353cbe274f619cc70@fb.com"},"message":"DebugComponent can only mount one view OR have component children\n\nSummary: Components can only have one mounted view so lets not return a list. Also components can not have both child components and a mounted view.\n\nReviewed By: kittens\n\nDifferential Revision: D5144915\n\nfbshipit-source-id: 3fa091fdcfef15aaa74846ae229052505a9e45d0","distinct":true,"url":"https://api.github.com/repos/passy/litho/commits/da7e1d52385d19b5593be465586989f888d7ea40"},{"sha":"f5e7bb9482585132c11792acd0660eb81cebf9a2","author":{"name":"Emil Sjolander","email":"fd01956b6f7ea3f89c72dc9353cbe274f619cc70@fb.com"},"message":"Show mounted drawwable\n\nSummary: Drawable are important as well. Let's show them!\n\nReviewed By: kittens\n\nDifferential Revision: D5144935\n\nfbshipit-source-id: 18959069ce2eb356f166c415b7f2cd08db2b129e","distinct":true,"url":"https://api.github.com/repos/passy/litho/commits/f5e7bb9482585132c11792acd0660eb81cebf9a2"},{"sha":"d68d3c3345c105daea745b6dc9aed889edfb6529","author":{"name":"Emil Sjolander","email":"fd01956b6f7ea3f89c72dc9353cbe274f619cc70@fb.com"},"message":"Fix absolute positioning in reverse wrapping container\n\nSummary: aligning with odd web behaviour\n\nReviewed By: gkassabli\n\nDifferential Revision: D5144145\n\nfbshipit-source-id: da6ef999ec0aabacf499017d1cfa81fc8f66e4bd","distinct":true,"url":"https://api.github.com/repos/passy/litho/commits/d68d3c3345c105daea745b6dc9aed889edfb6529"},{"sha":"a7d412a9527647d90a322285f8f15245367b7e77","author":{"name":"Emil Sjolander","email":"fd01956b6f7ea3f89c72dc9353cbe274f619cc70@fb.com"},"message":"Fix confusing variable name\n\nSummary: Variable name suggest it does not constrain to min dimension but it did indeed. Changing that to match variable name. This required updating code to use fully constraint value again. gkassabli this seems wrong, do you know what is going on?\n\nReviewed By: gkassabli\n\nDifferential Revision: D5144146\n\nfbshipit-source-id: a5d711f8ad7049b0d96ee0f0f3eef1165ab3b4e8","distinct":true,"url":"https://api.github.com/repos/passy/litho/commits/a7d412a9527647d90a322285f8f15245367b7e77"},{"sha":"a42ac822f4ea995377a2d20e55fc48af537f7929","author":{"name":"Pasquale Anatriello","email":"c8b9a350bedb15a1c36a5d57a9ecf98ef7abfebf@fb.com"},"message":"Fix snap to center for RecyclerBinder\n\nSummary: Snap to center was not working correctly for RecyclerBinder. This was the last(?) blocker to move all RecyclerCollectionComponents to use the new binder.\n\nReviewed By: mihaelao\n\nDifferential Revision: D5129155\n\nfbshipit-source-id: 21fd83e802c61446c7ed1e8b2f50a9517358cbba","distinct":true,"url":"https://api.github.com/repos/passy/litho/commits/a42ac822f4ea995377a2d20e55fc48af537f7929"},{"sha":"450ad610d76f676a551c81d54543458e130355c5","author":{"name":"Pasquale Anatriello","email":"c8b9a350bedb15a1c36a5d57a9ecf98ef7abfebf@fb.com"},"message":"Keep track of local transient state to decide when to disable incremental mount\n\nSummary:\nchecking ViewCompat.hasTransientState will also track transient state for children of the LithoView. We are only really interested in knowing if transient state was set directly on the LithoView.\nBefore this diff if transient state was set on an inner child of a LithoView we would stop doing incremental mount without fully mounting the LithoView.\n\nReviewed By: IanChilds\n\nDifferential Revision: D5144937\n\nfbshipit-source-id: a950ff4fe368fee1b2444e2c7939a4a337b2cc04","distinct":true,"url":"https://api.github.com/repos/passy/litho/commits/450ad610d76f676a551c81d54543458e130355c5"},{"sha":"ae3251623769af047faa65e69893ddcf5c113166","author":{"name":"Pascal Hartig","email":"89261ef73920f4eda09dbb3d5bd4204953de8413@fb.com"},"message":"Add basic espresso tests\n\nSummary: Add some very basic Espresso tests that utilize the litho matchers.\n\nReviewed By: IanChilds\n\nDifferential Revision: D5137841\n\nfbshipit-source-id: ef1f22d38ea9da6172000da5fc476678ca034a45","distinct":true,"url":"https://api.github.com/repos/passy/litho/commits/ae3251623769af047faa65e69893ddcf5c113166"}]}
{"actor":{"display_login":"passy"}}