{"push_id":2126012365,"size":3,"distinct_size":3,"ref":"refs/heads/master","head":"a9379f7f55effbd00a81de471786ddb9a1a7ab6c","before":"7d511631770e734fb2cab90513a62231a60dc3d3","commits":[{"sha":"c5e04d1ecd9d065926ed8f017b0b457c02e16a81","author":{"name":"Atsushi Eno","email":"f63ecc1f0c2cde37bdb6d4b59274a415b09dc690@gmail.com"},"message":"[class-parse] Fix JavaDocletType.JavaApiParameterNamesXml detection (#212)\n\nContext: https://github.com/xamarin/xamarin-android/pull/982\r\n\r\nThe `api-*.params.txt` files within [xamarin-android PR #982][pr982]\r\nstart with a blank line. Unfortunately, the\r\n`JavaDocletType.JavaApiParameterNamesXml` detection logic didn't\r\nsupport leading blank lines, which prevented the `api-*.params.txt`\r\nfiles from being properly detected.\r\n\r\n[pr982]: https://github.com/xamarin/xamarin-android/pull/982\r\n\r\nRemove all leading and trailing whitespace from `rawXML` so that we\r\nsupport leading blank lines.","distinct":true,"url":"https://api.github.com/repos/jonpryor/java.interop/commits/c5e04d1ecd9d065926ed8f017b0b457c02e16a81"},{"sha":"f90f00629a912f149c9b25c65bd14e98649d669a","author":{"name":"Jonathan Peppers","email":"dbfc4ffbdba47e822227046ebfe86da4b9927317@gmail.com"},"message":"[tests] fix for ANDROID_SDK_PATH (#211)\n\nContext: https://github.com/xamarin/xamarin-android/blob/f56ca4ab05471bcea8225f348c6cbd793ccbe9cb/build-tools/scripts/RunTests.targets#L50\r\nContext: https://devdiv.visualstudio.com/DevDiv/Default/_build/index?buildId=1138588&_a=summary&tab=ms.vss-test-web.test-result-details\r\n\r\nOn Windows, the Java.Interop tests are not getting the `$ANDROID_SDK_PATH`\r\nenvironment variable set. This is somehow working on macOS, but I think\r\nit might be simpler in this case to pass in the `$(AndroidSdkDirectory)`\r\nproperty from `RunTests.targets` in xamarin-android.\r\n\r\nThis approach worked when testing locally. I will need to bump Java.Interop\r\nand make one further change in xamarin-android to pass in\r\n`$(AndroidSdkDirectory)`. This will get a few skipped tests in Java.Interop\r\nrunning and passing on Windows.","distinct":true,"url":"https://api.github.com/repos/jonpryor/java.interop/commits/f90f00629a912f149c9b25c65bd14e98649d669a"},{"sha":"a9379f7f55effbd00a81de471786ddb9a1a7ab6c","author":{"name":"Atsushi Eno","email":"f63ecc1f0c2cde37bdb6d4b59274a415b09dc690@gmail.com"},"message":"[class-parse] JavaApiParameterNames use `;` for comments (#213)\n\nChange the `JavaDocletType.JavaApiParameterNamesXml` comment\r\ncharacter from `#` to `;`. This is because the parameter description\r\nfile format uses `#ctor` for constructors, which obviously interacts\r\nvery badly when \"`#` until end of line\" is a comment.\r\n\r\n(Constructors can't be expressed!)\r\n  \r\nThis issue was uncovered at API Level 26 which started to contain\r\ngeneric constructors.","distinct":true,"url":"https://api.github.com/repos/jonpryor/java.interop/commits/a9379f7f55effbd00a81de471786ddb9a1a7ab6c"}]}
{"actor":{"display_login":"jonpryor"}}