{"action":"created","comment":{"url":"https://api.github.com/repos/xapi-project/xen-api/pulls/comments/145351904","pull_request_review_id":70137410,"id":145351904,"diff_hunk":"@@ -1508,6 +1508,8 @@ let _ =\n     ~doc:\"The USB device is currently attached to a VM.\" ();\n   error Api_errors.passthrough_not_enabled [ \"PUSB\"]\n     ~doc:\"The passthrough_enabled must be true before passthrough usb to vm.\" ();\n+  error Api_errors.pusb_vdi_conflict [ \"PUSB\"; \"VDI\" ]\n+    ~doc:\"The PUSB and corresponding VDI conflicts as this vdi has vdb bound.\" ();","path":"ocaml/idl/datamodel.ml","position":null,"original_position":5,"commit_id":"179032d780ca6653f819244103ab1de956bc908d","original_commit_id":"41eef3909323fd552620eb96499fd4ebcc546b06","user":{"login":"taoyongd","id":20807635,"avatar_url":"https://avatars2.githubusercontent.com/u/20807635?v=4","gravatar_id":"","url":"https://api.github.com/users/taoyongd","html_url":"https://github.com/taoyongd","followers_url":"https://api.github.com/users/taoyongd/followers","following_url":"https://api.github.com/users/taoyongd/following{/other_user}","gists_url":"https://api.github.com/users/taoyongd/gists{/gist_id}","starred_url":"https://api.github.com/users/taoyongd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taoyongd/subscriptions","organizations_url":"https://api.github.com/users/taoyongd/orgs","repos_url":"https://api.github.com/users/taoyongd/repos","events_url":"https://api.github.com/users/taoyongd/events{/privacy}","received_events_url":"https://api.github.com/users/taoyongd/received_events","type":"User","site_admin":false},"body":"ok , error message refined.","created_at":"2017-10-18T08:53:41Z","updated_at":"2017-10-18T08:53:41Z","html_url":"https://github.com/xapi-project/xen-api/pull/3293#discussion_r145351904","pull_request_url":"https://api.github.com/repos/xapi-project/xen-api/pulls/3293","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/xapi-project/xen-api/pulls/comments/145351904"},"html":{"href":"https://github.com/xapi-project/xen-api/pull/3293#discussion_r145351904"},"pull_request":{"href":"https://api.github.com/repos/xapi-project/xen-api/pulls/3293"}},"in_reply_to_id":145350216},"pull_request":{"url":"https://api.github.com/repos/xapi-project/xen-api/pulls/3293","id":146767927,"html_url":"https://github.com/xapi-project/xen-api/pull/3293","diff_url":"https://github.com/xapi-project/xen-api/pull/3293.diff","patch_url":"https://github.com/xapi-project/xen-api/pull/3293.patch","issue_url":"https://api.github.com/repos/xapi-project/xen-api/issues/3293","number":3293,"state":"open","locked":false,"title":"CP-25174: Handle VDI and PUSB conflict","user":{"login":"taoyongd","id":20807635,"avatar_url":"https://avatars2.githubusercontent.com/u/20807635?v=4","gravatar_id":"","url":"https://api.github.com/users/taoyongd","html_url":"https://github.com/taoyongd","followers_url":"https://api.github.com/users/taoyongd/followers","following_url":"https://api.github.com/users/taoyongd/following{/other_user}","gists_url":"https://api.github.com/users/taoyongd/gists{/gist_id}","starred_url":"https://api.github.com/users/taoyongd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taoyongd/subscriptions","organizations_url":"https://api.github.com/users/taoyongd/orgs","repos_url":"https://api.github.com/users/taoyongd/repos","events_url":"https://api.github.com/users/taoyongd/events{/privacy}","received_events_url":"https://api.github.com/users/taoyongd/received_events","type":"User","site_admin":false},"body":"1. When we enable the PUSB for passthrough, we need to\r\n   check if the correponding VDI has a vbd bound, as\r\n   this will cause conflict when we attach vdi to vm and\r\n   also passthrough the usb to vm.\r\n\r\nSigned-off-by: Taoyong Ding <taoyong.ding@citrix.com>","created_at":"2017-10-16T12:10:39Z","updated_at":"2017-10-18T08:53:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9f0a07096ad81f0f7223e89038e4d6d74d748a51","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/xapi-project/xen-api/pulls/3293/commits","review_comments_url":"https://api.github.com/repos/xapi-project/xen-api/pulls/3293/comments","review_comment_url":"https://api.github.com/repos/xapi-project/xen-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xapi-project/xen-api/issues/3293/comments","statuses_url":"https://api.github.com/repos/xapi-project/xen-api/statuses/179032d780ca6653f819244103ab1de956bc908d","head":{"label":"taoyongd:CP-25174","ref":"CP-25174","sha":"179032d780ca6653f819244103ab1de956bc908d","user":{"login":"taoyongd","id":20807635,"avatar_url":"https://avatars2.githubusercontent.com/u/20807635?v=4","gravatar_id":"","url":"https://api.github.com/users/taoyongd","html_url":"https://github.com/taoyongd","followers_url":"https://api.github.com/users/taoyongd/followers","following_url":"https://api.github.com/users/taoyongd/following{/other_user}","gists_url":"https://api.github.com/users/taoyongd/gists{/gist_id}","starred_url":"https://api.github.com/users/taoyongd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taoyongd/subscriptions","organizations_url":"https://api.github.com/users/taoyongd/orgs","repos_url":"https://api.github.com/users/taoyongd/repos","events_url":"https://api.github.com/users/taoyongd/events{/privacy}","received_events_url":"https://api.github.com/users/taoyongd/received_events","type":"User","site_admin":false},"repo":{"id":78195925,"name":"xen-api","full_name":"taoyongd/xen-api","owner":{"login":"taoyongd","id":20807635,"avatar_url":"https://avatars2.githubusercontent.com/u/20807635?v=4","gravatar_id":"","url":"https://api.github.com/users/taoyongd","html_url":"https://github.com/taoyongd","followers_url":"https://api.github.com/users/taoyongd/followers","following_url":"https://api.github.com/users/taoyongd/following{/other_user}","gists_url":"https://api.github.com/users/taoyongd/gists{/gist_id}","starred_url":"https://api.github.com/users/taoyongd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taoyongd/subscriptions","organizations_url":"https://api.github.com/users/taoyongd/orgs","repos_url":"https://api.github.com/users/taoyongd/repos","events_url":"https://api.github.com/users/taoyongd/events{/privacy}","received_events_url":"https://api.github.com/users/taoyongd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/taoyongd/xen-api","description":"The Xapi Project's XenAPI Server","fork":true,"url":"https://api.github.com/repos/taoyongd/xen-api","forks_url":"https://api.github.com/repos/taoyongd/xen-api/forks","keys_url":"https://api.github.com/repos/taoyongd/xen-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/taoyongd/xen-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/taoyongd/xen-api/teams","hooks_url":"https://api.github.com/repos/taoyongd/xen-api/hooks","issue_events_url":"https://api.github.com/repos/taoyongd/xen-api/issues/events{/number}","events_url":"https://api.github.com/repos/taoyongd/xen-api/events","assignees_url":"https://api.github.com/repos/taoyongd/xen-api/assignees{/user}","branches_url":"https://api.github.com/repos/taoyongd/xen-api/branches{/branch}","tags_url":"https://api.github.com/repos/taoyongd/xen-api/tags","blobs_url":"https://api.github.com/repos/taoyongd/xen-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/taoyongd/xen-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/taoyongd/xen-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/taoyongd/xen-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/taoyongd/xen-api/statuses/{sha}","languages_url":"https://api.github.com/repos/taoyongd/xen-api/languages","stargazers_url":"https://api.github.com/repos/taoyongd/xen-api/stargazers","contributors_url":"https://api.github.com/repos/taoyongd/xen-api/contributors","subscribers_url":"https://api.github.com/repos/taoyongd/xen-api/subscribers","subscription_url":"https://api.github.com/repos/taoyongd/xen-api/subscription","commits_url":"https://api.github.com/repos/taoyongd/xen-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/taoyongd/xen-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/taoyongd/xen-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/taoyongd/xen-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/taoyongd/xen-api/contents/{+path}","compare_url":"https://api.github.com/repos/taoyongd/xen-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/taoyongd/xen-api/merges","archive_url":"https://api.github.com/repos/taoyongd/xen-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/taoyongd/xen-api/downloads","issues_url":"https://api.github.com/repos/taoyongd/xen-api/issues{/number}","pulls_url":"https://api.github.com/repos/taoyongd/xen-api/pulls{/number}","milestones_url":"https://api.github.com/repos/taoyongd/xen-api/milestones{/number}","notifications_url":"https://api.github.com/repos/taoyongd/xen-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/taoyongd/xen-api/labels{/name}","releases_url":"https://api.github.com/repos/taoyongd/xen-api/releases{/id}","deployments_url":"https://api.github.com/repos/taoyongd/xen-api/deployments","created_at":"2017-01-06T10:04:58Z","updated_at":"2017-01-06T10:05:03Z","pushed_at":"2017-10-18T08:53:31Z","git_url":"git://github.com/taoyongd/xen-api.git","ssh_url":"git@github.com:taoyongd/xen-api.git","clone_url":"https://github.com/taoyongd/xen-api.git","svn_url":"https://github.com/taoyongd/xen-api","homepage":"http://xenproject.org/developers/teams/xapi.html","size":28806,"stargazers_count":0,"watchers_count":0,"language":"OCaml","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xapi-project:usb-passthrough","ref":"usb-passthrough","sha":"00878c11e0668510f36cb02dde2252920c326933","user":{"login":"xapi-project","id":317268,"avatar_url":"https://avatars3.githubusercontent.com/u/317268?v=4","gravatar_id":"","url":"https://api.github.com/users/xapi-project","html_url":"https://github.com/xapi-project","followers_url":"https://api.github.com/users/xapi-project/followers","following_url":"https://api.github.com/users/xapi-project/following{/other_user}","gists_url":"https://api.github.com/users/xapi-project/gists{/gist_id}","starred_url":"https://api.github.com/users/xapi-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xapi-project/subscriptions","organizations_url":"https://api.github.com/users/xapi-project/orgs","repos_url":"https://api.github.com/users/xapi-project/repos","events_url":"https://api.github.com/users/xapi-project/events{/privacy}","received_events_url":"https://api.github.com/users/xapi-project/received_events","type":"Organization","site_admin":false},"repo":{"id":960233,"name":"xen-api","full_name":"xapi-project/xen-api","owner":{"login":"xapi-project","id":317268,"avatar_url":"https://avatars3.githubusercontent.com/u/317268?v=4","gravatar_id":"","url":"https://api.github.com/users/xapi-project","html_url":"https://github.com/xapi-project","followers_url":"https://api.github.com/users/xapi-project/followers","following_url":"https://api.github.com/users/xapi-project/following{/other_user}","gists_url":"https://api.github.com/users/xapi-project/gists{/gist_id}","starred_url":"https://api.github.com/users/xapi-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xapi-project/subscriptions","organizations_url":"https://api.github.com/users/xapi-project/orgs","repos_url":"https://api.github.com/users/xapi-project/repos","events_url":"https://api.github.com/users/xapi-project/events{/privacy}","received_events_url":"https://api.github.com/users/xapi-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xapi-project/xen-api","description":"The Xapi Project's XenAPI Server","fork":false,"url":"https://api.github.com/repos/xapi-project/xen-api","forks_url":"https://api.github.com/repos/xapi-project/xen-api/forks","keys_url":"https://api.github.com/repos/xapi-project/xen-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xapi-project/xen-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xapi-project/xen-api/teams","hooks_url":"https://api.github.com/repos/xapi-project/xen-api/hooks","issue_events_url":"https://api.github.com/repos/xapi-project/xen-api/issues/events{/number}","events_url":"https://api.github.com/repos/xapi-project/xen-api/events","assignees_url":"https://api.github.com/repos/xapi-project/xen-api/assignees{/user}","branches_url":"https://api.github.com/repos/xapi-project/xen-api/branches{/branch}","tags_url":"https://api.github.com/repos/xapi-project/xen-api/tags","blobs_url":"https://api.github.com/repos/xapi-project/xen-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xapi-project/xen-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xapi-project/xen-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/xapi-project/xen-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xapi-project/xen-api/statuses/{sha}","languages_url":"https://api.github.com/repos/xapi-project/xen-api/languages","stargazers_url":"https://api.github.com/repos/xapi-project/xen-api/stargazers","contributors_url":"https://api.github.com/repos/xapi-project/xen-api/contributors","subscribers_url":"https://api.github.com/repos/xapi-project/xen-api/subscribers","subscription_url":"https://api.github.com/repos/xapi-project/xen-api/subscription","commits_url":"https://api.github.com/repos/xapi-project/xen-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/xapi-project/xen-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/xapi-project/xen-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/xapi-project/xen-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/xapi-project/xen-api/contents/{+path}","compare_url":"https://api.github.com/repos/xapi-project/xen-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xapi-project/xen-api/merges","archive_url":"https://api.github.com/repos/xapi-project/xen-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xapi-project/xen-api/downloads","issues_url":"https://api.github.com/repos/xapi-project/xen-api/issues{/number}","pulls_url":"https://api.github.com/repos/xapi-project/xen-api/pulls{/number}","milestones_url":"https://api.github.com/repos/xapi-project/xen-api/milestones{/number}","notifications_url":"https://api.github.com/repos/xapi-project/xen-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xapi-project/xen-api/labels{/name}","releases_url":"https://api.github.com/repos/xapi-project/xen-api/releases{/id}","deployments_url":"https://api.github.com/repos/xapi-project/xen-api/deployments","created_at":"2010-10-04T10:52:57Z","updated_at":"2017-10-04T19:19:11Z","pushed_at":"2017-10-18T08:53:32Z","git_url":"git://github.com/xapi-project/xen-api.git","ssh_url":"git@github.com:xapi-project/xen-api.git","clone_url":"https://github.com/xapi-project/xen-api.git","svn_url":"https://github.com/xapi-project/xen-api","homepage":"http://xenproject.org/developers/teams/xapi.html","size":29025,"stargazers_count":243,"watchers_count":243,"language":"OCaml","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":189,"mirror_url":null,"open_issues_count":25,"forks":189,"open_issues":25,"watchers":243,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xapi-project/xen-api/pulls/3293"},"html":{"href":"https://github.com/xapi-project/xen-api/pull/3293"},"issue":{"href":"https://api.github.com/repos/xapi-project/xen-api/issues/3293"},"comments":{"href":"https://api.github.com/repos/xapi-project/xen-api/issues/3293/comments"},"review_comments":{"href":"https://api.github.com/repos/xapi-project/xen-api/pulls/3293/comments"},"review_comment":{"href":"https://api.github.com/repos/xapi-project/xen-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xapi-project/xen-api/pulls/3293/commits"},"statuses":{"href":"https://api.github.com/repos/xapi-project/xen-api/statuses/179032d780ca6653f819244103ab1de956bc908d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"taoyongd"}}