{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/pulls/comments/155426882","pull_request_review_id":81743437,"id":155426882,"diff_hunk":"@@ -1102,5 +1103,71 @@ private void devicesGridViewContextMenu_Opened(object sender, EventArgs e)\n                 showDevicePropertiesToolStripMenuItem.Enabled = false;\n             }\n         }\n+\n+        #region Device Filtering\n+        private void filterDevicesTextBox_TextChanged(object sender, EventArgs e)\n+        {\n+            filterDevices();\n+        }\n+\n+        private void filterDevices() { filterDevices(filterDevicesTextBox.Text); }","path":"tools/DeviceExplorer/DeviceExplorer/MainForm.cs","position":85,"original_position":85,"commit_id":"61f4445a78223417056656e43541e99f10b7528b","original_commit_id":"61f4445a78223417056656e43541e99f10b7528b","user":{"login":"CIPop","id":8635911,"avatar_url":"https://avatars2.githubusercontent.com/u/8635911?v=4","gravatar_id":"","url":"https://api.github.com/users/CIPop","html_url":"https://github.com/CIPop","followers_url":"https://api.github.com/users/CIPop/followers","following_url":"https://api.github.com/users/CIPop/following{/other_user}","gists_url":"https://api.github.com/users/CIPop/gists{/gist_id}","starred_url":"https://api.github.com/users/CIPop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CIPop/subscriptions","organizations_url":"https://api.github.com/users/CIPop/orgs","repos_url":"https://api.github.com/users/CIPop/repos","events_url":"https://api.github.com/users/CIPop/events{/privacy}","received_events_url":"https://api.github.com/users/CIPop/received_events","type":"User","site_admin":false},"body":"Nit: please start function names with caps. `FilterDevices()`. (See coding standards.)\r\n\r\nI would not change the above function though since that is prefixed by the name of the textbox.\r\n","created_at":"2017-12-07T04:10:41Z","updated_at":"2017-12-07T04:27:18Z","html_url":"https://github.com/Azure/azure-iot-sdk-csharp/pull/241#discussion_r155426882","pull_request_url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/pulls/241","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/pulls/comments/155426882"},"html":{"href":"https://github.com/Azure/azure-iot-sdk-csharp/pull/241#discussion_r155426882"},"pull_request":{"href":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/pulls/241"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/pulls/241","id":153944335,"html_url":"https://github.com/Azure/azure-iot-sdk-csharp/pull/241","diff_url":"https://github.com/Azure/azure-iot-sdk-csharp/pull/241.diff","patch_url":"https://github.com/Azure/azure-iot-sdk-csharp/pull/241.patch","issue_url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/issues/241","number":241,"state":"open","locked":false,"title":"Add filtering capability to the Device Explorer","user":{"login":"zposten","id":13950246,"avatar_url":"https://avatars0.githubusercontent.com/u/13950246?v=4","gravatar_id":"","url":"https://api.github.com/users/zposten","html_url":"https://github.com/zposten","followers_url":"https://api.github.com/users/zposten/followers","following_url":"https://api.github.com/users/zposten/following{/other_user}","gists_url":"https://api.github.com/users/zposten/gists{/gist_id}","starred_url":"https://api.github.com/users/zposten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zposten/subscriptions","organizations_url":"https://api.github.com/users/zposten/orgs","repos_url":"https://api.github.com/users/zposten/repos","events_url":"https://api.github.com/users/zposten/events{/privacy}","received_events_url":"https://api.github.com/users/zposten/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for helping us improve the Azure IoT C SDK!\r\n\r\nHere's a little checklist of things that will help it make its way to the repository: Note that you don't have to check all the boxes, we can help you with that. \r\nThis being said, the more you do, the quicker it'll go through our gated build! \r\n--> \r\n\r\n# Checklist\r\n- [x] I have read the [contribution guidelines](https://github.com/Azure/azure-iot-sdk-c/blob/master/.github/CONTRIBUTING.md).\r\n- [ ] I added or modified the existing tests to cover the change (we do not allow our test coverage to go down). **<-- Are there tests for the Device Explorer tool?**\r\n- If this is a modification that impacts the behavior of a public API\r\n  - [ ] I edited the corresponding document in the `devdoc` folder and added or modified requirements.\r\n- I submitted this PR against the correct branch: \r\n  - [x] This pull-request is submitted against the `master` branch. \r\n\r\n# Reference/Link to the issue solved with this PR (if any)\r\n\r\n# Description of the problem\r\nWhen an IoT hub has more than 1000 devices, the device explorer can no longer be used to find every device.  Searching for a particular device in such a large IoT hub (a not uncommon use case) is also difficult.\r\n\r\n# Description of the solution\r\n  - Up the max number of devices that the Device Explorer will show, to a value that is unlikely to be exceeded (admittedly, this is akin to delaying the problem, but it keeps closer with the current implementation).   I'm not sure why this arbitrary limit was put in here in the first place, but I'm assuming it was for performance.  However, a user with more than 1000 devices in his IoT hub has a choice between the tool maybe being slow, and not being able to use the tool at all to configure some of their devices.  The choice seems like a simple one for me.\r\n\r\n  - Add a filter text box to the management tab to allow users to search common fields","created_at":"2017-11-21T16:47:32Z","updated_at":"2017-12-07T04:27:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"11566191e5911e457fc8824bbc2e2d50e49889f4","assignee":{"login":"CIPop","id":8635911,"avatar_url":"https://avatars2.githubusercontent.com/u/8635911?v=4","gravatar_id":"","url":"https://api.github.com/users/CIPop","html_url":"https://github.com/CIPop","followers_url":"https://api.github.com/users/CIPop/followers","following_url":"https://api.github.com/users/CIPop/following{/other_user}","gists_url":"https://api.github.com/users/CIPop/gists{/gist_id}","starred_url":"https://api.github.com/users/CIPop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CIPop/subscriptions","organizations_url":"https://api.github.com/users/CIPop/orgs","repos_url":"https://api.github.com/users/CIPop/repos","events_url":"https://api.github.com/users/CIPop/events{/privacy}","received_events_url":"https://api.github.com/users/CIPop/received_events","type":"User","site_admin":false},"assignees":[{"login":"CIPop","id":8635911,"avatar_url":"https://avatars2.githubusercontent.com/u/8635911?v=4","gravatar_id":"","url":"https://api.github.com/users/CIPop","html_url":"https://github.com/CIPop","followers_url":"https://api.github.com/users/CIPop/followers","following_url":"https://api.github.com/users/CIPop/following{/other_user}","gists_url":"https://api.github.com/users/CIPop/gists{/gist_id}","starred_url":"https://api.github.com/users/CIPop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CIPop/subscriptions","organizations_url":"https://api.github.com/users/CIPop/orgs","repos_url":"https://api.github.com/users/CIPop/repos","events_url":"https://api.github.com/users/CIPop/events{/privacy}","received_events_url":"https://api.github.com/users/CIPop/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"tameraw","id":9868777,"avatar_url":"https://avatars3.githubusercontent.com/u/9868777?v=4","gravatar_id":"","url":"https://api.github.com/users/tameraw","html_url":"https://github.com/tameraw","followers_url":"https://api.github.com/users/tameraw/followers","following_url":"https://api.github.com/users/tameraw/following{/other_user}","gists_url":"https://api.github.com/users/tameraw/gists{/gist_id}","starred_url":"https://api.github.com/users/tameraw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tameraw/subscriptions","organizations_url":"https://api.github.com/users/tameraw/orgs","repos_url":"https://api.github.com/users/tameraw/repos","events_url":"https://api.github.com/users/tameraw/events{/privacy}","received_events_url":"https://api.github.com/users/tameraw/received_events","type":"User","site_admin":false},{"login":"ewertons","id":12401690,"avatar_url":"https://avatars0.githubusercontent.com/u/12401690?v=4","gravatar_id":"","url":"https://api.github.com/users/ewertons","html_url":"https://github.com/ewertons","followers_url":"https://api.github.com/users/ewertons/followers","following_url":"https://api.github.com/users/ewertons/following{/other_user}","gists_url":"https://api.github.com/users/ewertons/gists{/gist_id}","starred_url":"https://api.github.com/users/ewertons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ewertons/subscriptions","organizations_url":"https://api.github.com/users/ewertons/orgs","repos_url":"https://api.github.com/users/ewertons/repos","events_url":"https://api.github.com/users/ewertons/events{/privacy}","received_events_url":"https://api.github.com/users/ewertons/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/pulls/241/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/pulls/241/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/issues/241/comments","statuses_url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/statuses/61f4445a78223417056656e43541e99f10b7528b","head":{"label":"zposten:filter","ref":"filter","sha":"61f4445a78223417056656e43541e99f10b7528b","user":{"login":"zposten","id":13950246,"avatar_url":"https://avatars0.githubusercontent.com/u/13950246?v=4","gravatar_id":"","url":"https://api.github.com/users/zposten","html_url":"https://github.com/zposten","followers_url":"https://api.github.com/users/zposten/followers","following_url":"https://api.github.com/users/zposten/following{/other_user}","gists_url":"https://api.github.com/users/zposten/gists{/gist_id}","starred_url":"https://api.github.com/users/zposten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zposten/subscriptions","organizations_url":"https://api.github.com/users/zposten/orgs","repos_url":"https://api.github.com/users/zposten/repos","events_url":"https://api.github.com/users/zposten/events{/privacy}","received_events_url":"https://api.github.com/users/zposten/received_events","type":"User","site_admin":false},"repo":{"id":111574436,"name":"azure-iot-sdk-csharp","full_name":"zposten/azure-iot-sdk-csharp","owner":{"login":"zposten","id":13950246,"avatar_url":"https://avatars0.githubusercontent.com/u/13950246?v=4","gravatar_id":"","url":"https://api.github.com/users/zposten","html_url":"https://github.com/zposten","followers_url":"https://api.github.com/users/zposten/followers","following_url":"https://api.github.com/users/zposten/following{/other_user}","gists_url":"https://api.github.com/users/zposten/gists{/gist_id}","starred_url":"https://api.github.com/users/zposten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zposten/subscriptions","organizations_url":"https://api.github.com/users/zposten/orgs","repos_url":"https://api.github.com/users/zposten/repos","events_url":"https://api.github.com/users/zposten/events{/privacy}","received_events_url":"https://api.github.com/users/zposten/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zposten/azure-iot-sdk-csharp","description":"A C# SDK for connecting devices to Microsoft Azure IoT services","fork":true,"url":"https://api.github.com/repos/zposten/azure-iot-sdk-csharp","forks_url":"https://api.github.com/repos/zposten/azure-iot-sdk-csharp/forks","keys_url":"https://api.github.com/repos/zposten/azure-iot-sdk-csharp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zposten/azure-iot-sdk-csharp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zposten/azure-iot-sdk-csharp/teams","hooks_url":"https://api.github.com/repos/zposten/azure-iot-sdk-csharp/hooks","issue_events_url":"https://api.github.com/repos/zposten/azure-iot-sdk-csharp/issues/events{/number}","events_url":"https://api.github.com/repos/zposten/azure-iot-sdk-csharp/events","assignees_url":"https://api.github.com/repos/zposten/azure-iot-sdk-csharp/assignees{/user}","branches_url":"https://api.github.com/repos/zposten/azure-iot-sdk-csharp/branches{/branch}","tags_url":"https://api.github.com/repos/zposten/azure-iot-sdk-csharp/tags","blobs_url":"https://api.github.com/repos/zposten/azure-iot-sdk-csharp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zposten/azure-iot-sdk-csharp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zposten/azure-iot-sdk-csharp/git/refs{/sha}","trees_url":"https://api.github.com/repos/zposten/azure-iot-sdk-csharp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zposten/azure-iot-sdk-csharp/statuses/{sha}","languages_url":"https://api.github.com/repos/zposten/azure-iot-sdk-csharp/languages","stargazers_url":"https://api.github.com/repos/zposten/azure-iot-sdk-csharp/stargazers","contributors_url":"https://api.github.com/repos/zposten/azure-iot-sdk-csharp/contributors","subscribers_url":"https://api.github.com/repos/zposten/azure-iot-sdk-csharp/subscribers","subscription_url":"https://api.github.com/repos/zposten/azure-iot-sdk-csharp/subscription","commits_url":"https://api.github.com/repos/zposten/azure-iot-sdk-csharp/commits{/sha}","git_commits_url":"https://api.github.com/repos/zposten/azure-iot-sdk-csharp/git/commits{/sha}","comments_url":"https://api.github.com/repos/zposten/azure-iot-sdk-csharp/comments{/number}","issue_comment_url":"https://api.github.com/repos/zposten/azure-iot-sdk-csharp/issues/comments{/number}","contents_url":"https://api.github.com/repos/zposten/azure-iot-sdk-csharp/contents/{+path}","compare_url":"https://api.github.com/repos/zposten/azure-iot-sdk-csharp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zposten/azure-iot-sdk-csharp/merges","archive_url":"https://api.github.com/repos/zposten/azure-iot-sdk-csharp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zposten/azure-iot-sdk-csharp/downloads","issues_url":"https://api.github.com/repos/zposten/azure-iot-sdk-csharp/issues{/number}","pulls_url":"https://api.github.com/repos/zposten/azure-iot-sdk-csharp/pulls{/number}","milestones_url":"https://api.github.com/repos/zposten/azure-iot-sdk-csharp/milestones{/number}","notifications_url":"https://api.github.com/repos/zposten/azure-iot-sdk-csharp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zposten/azure-iot-sdk-csharp/labels{/name}","releases_url":"https://api.github.com/repos/zposten/azure-iot-sdk-csharp/releases{/id}","deployments_url":"https://api.github.com/repos/zposten/azure-iot-sdk-csharp/deployments","created_at":"2017-11-21T16:34:38Z","updated_at":"2017-11-21T16:34:42Z","pushed_at":"2017-11-27T20:17:04Z","git_url":"git://github.com/zposten/azure-iot-sdk-csharp.git","ssh_url":"git@github.com:zposten/azure-iot-sdk-csharp.git","clone_url":"https://github.com/zposten/azure-iot-sdk-csharp.git","svn_url":"https://github.com/zposten/azure-iot-sdk-csharp","homepage":null,"size":42189,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"3baa8915e28b93dda86404652a54e89d2c70e719","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":70936151,"name":"azure-iot-sdk-csharp","full_name":"Azure/azure-iot-sdk-csharp","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/azure-iot-sdk-csharp","description":"A C# SDK for connecting devices to Microsoft Azure IoT services","fork":false,"url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp","forks_url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/forks","keys_url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/teams","hooks_url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/events","assignees_url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/tags","blobs_url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/subscription","commits_url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/merges","archive_url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/downloads","issues_url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/deployments","created_at":"2016-10-14T18:18:23Z","updated_at":"2017-12-06T07:32:01Z","pushed_at":"2017-12-07T04:18:31Z","git_url":"git://github.com/Azure/azure-iot-sdk-csharp.git","ssh_url":"git@github.com:Azure/azure-iot-sdk-csharp.git","clone_url":"https://github.com/Azure/azure-iot-sdk-csharp.git","svn_url":"https://github.com/Azure/azure-iot-sdk-csharp","homepage":null,"size":42391,"stargazers_count":104,"watchers_count":104,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":164,"mirror_url":null,"archived":false,"open_issues_count":58,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":164,"open_issues":58,"watchers":104,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/pulls/241"},"html":{"href":"https://github.com/Azure/azure-iot-sdk-csharp/pull/241"},"issue":{"href":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/issues/241"},"comments":{"href":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/issues/241/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/pulls/241/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/pulls/241/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/statuses/61f4445a78223417056656e43541e99f10b7528b"}},"author_association":"NONE"}}
{"actor":{"display_login":"CIPop"}}