{"action":"created","issue":{"url":"https://api.github.com/repos/aodn/imos-toolbox/issues/451","repository_url":"https://api.github.com/repos/aodn/imos-toolbox","labels_url":"https://api.github.com/repos/aodn/imos-toolbox/issues/451/labels{/name}","comments_url":"https://api.github.com/repos/aodn/imos-toolbox/issues/451/comments","events_url":"https://api.github.com/repos/aodn/imos-toolbox/issues/451/events","html_url":"https://github.com/aodn/imos-toolbox/pull/451","id":240827363,"number":451,"title":"Fix incorrect qcParam selection","user":{"login":"sspagnol","id":2917450,"avatar_url":"https://avatars1.githubusercontent.com/u/2917450?v=3","gravatar_id":"","url":"https://api.github.com/users/sspagnol","html_url":"https://github.com/sspagnol","followers_url":"https://api.github.com/users/sspagnol/followers","following_url":"https://api.github.com/users/sspagnol/following{/other_user}","gists_url":"https://api.github.com/users/sspagnol/gists{/gist_id}","starred_url":"https://api.github.com/users/sspagnol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sspagnol/subscriptions","organizations_url":"https://api.github.com/users/sspagnol/orgs","repos_url":"https://api.github.com/users/sspagnol/repos","events_url":"https://api.github.com/users/sspagnol/events{/privacy}","received_events_url":"https://api.github.com/users/sspagnol/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-07-06T02:29:26Z","updated_at":"2017-07-10T05:29:12Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/aodn/imos-toolbox/pulls/451","html_url":"https://github.com/aodn/imos-toolbox/pull/451","diff_url":"https://github.com/aodn/imos-toolbox/pull/451.diff","patch_url":"https://github.com/aodn/imos-toolbox/pull/451.patch"},"body":"Previous logic iSample obtained from list of filenames (equivalent to number of elements in sample_data structure) and this is used to index into qcParam. Elements in qcParam are only calculated (and each element uniquely identified) by filename. But some parsers can return  more than one structure (eg awacParse). So eg load awac file numel(sample_data) ==2, but numel(qcParam) == 1. Change logic to just find the index into qcParam using passed in sample_data.toolbox_input_file"},"comment":{"url":"https://api.github.com/repos/aodn/imos-toolbox/issues/comments/314009407","html_url":"https://github.com/aodn/imos-toolbox/pull/451#issuecomment-314009407","issue_url":"https://api.github.com/repos/aodn/imos-toolbox/issues/451","id":314009407,"user":{"login":"ggalibert","id":3498686,"avatar_url":"https://avatars2.githubusercontent.com/u/3498686?v=3","gravatar_id":"","url":"https://api.github.com/users/ggalibert","html_url":"https://github.com/ggalibert","followers_url":"https://api.github.com/users/ggalibert/followers","following_url":"https://api.github.com/users/ggalibert/following{/other_user}","gists_url":"https://api.github.com/users/ggalibert/gists{/gist_id}","starred_url":"https://api.github.com/users/ggalibert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ggalibert/subscriptions","organizations_url":"https://api.github.com/users/ggalibert/orgs","repos_url":"https://api.github.com/users/ggalibert/repos","events_url":"https://api.github.com/users/ggalibert/events{/privacy}","received_events_url":"https://api.github.com/users/ggalibert/received_events","type":"User","site_admin":false},"created_at":"2017-07-10T05:29:12Z","updated_at":"2017-07-10T05:29:12Z","body":"I cannot re-create such a problem with Awac velocity (.wpr) and wave data (.wap): numel(sample_data) ==2, and numel(qcParam) == 2 too. While I can see your code is valid and equivalent, I would to understand your motivations."}}
{"actor":{"display_login":"ggalibert"}}