{"action":"created","comment":{"url":"https://api.github.com/repos/sofa-framework/sofa/pulls/comments/122922665","pull_request_review_id":45077589,"id":122922665,"diff_hunk":"@@ -42,7 +42,7 @@ namespace behavior\n  * Interface of user interaction on SOFA Components.\n  * Empty class to provide an interface for the Factory\n  */\n-class BaseController : public virtual core::objectmodel::BaseObject\n+class BaseController : public core::objectmodel::BaseObject","path":"SofaKernel/framework/sofa/core/behavior/BaseController.h","position":5,"original_position":5,"commit_id":"f919b4de610847506ff9d0e461e3302938cba76c","original_commit_id":"f919b4de610847506ff9d0e461e3302938cba76c","user":{"login":"maxime-tournier","id":3356385,"avatar_url":"https://avatars2.githubusercontent.com/u/3356385?v=3","gravatar_id":"","url":"https://api.github.com/users/maxime-tournier","html_url":"https://github.com/maxime-tournier","followers_url":"https://api.github.com/users/maxime-tournier/followers","following_url":"https://api.github.com/users/maxime-tournier/following{/other_user}","gists_url":"https://api.github.com/users/maxime-tournier/gists{/gist_id}","starred_url":"https://api.github.com/users/maxime-tournier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxime-tournier/subscriptions","organizations_url":"https://api.github.com/users/maxime-tournier/orgs","repos_url":"https://api.github.com/users/maxime-tournier/repos","events_url":"https://api.github.com/users/maxime-tournier/events{/privacy}","received_events_url":"https://api.github.com/users/maxime-tournier/received_events","type":"User","site_admin":false},"body":"\\o/","created_at":"2017-06-20T09:21:00Z","updated_at":"2017-06-20T09:51:29Z","html_url":"https://github.com/sofa-framework/sofa/pull/304#discussion_r122922665","pull_request_url":"https://api.github.com/repos/sofa-framework/sofa/pulls/304","_links":{"self":{"href":"https://api.github.com/repos/sofa-framework/sofa/pulls/comments/122922665"},"html":{"href":"https://github.com/sofa-framework/sofa/pull/304#discussion_r122922665"},"pull_request":{"href":"https://api.github.com/repos/sofa-framework/sofa/pulls/304"}}},"pull_request":{"url":"https://api.github.com/repos/sofa-framework/sofa/pulls/304","id":125548607,"html_url":"https://github.com/sofa-framework/sofa/pull/304","diff_url":"https://github.com/sofa-framework/sofa/pull/304.diff","patch_url":"https://github.com/sofa-framework/sofa/pull/304.patch","issue_url":"https://api.github.com/repos/sofa-framework/sofa/issues/304","number":304,"state":"open","locked":false,"title":"[SofaPython] cleaning","user":{"login":"matthieu-nesme","id":7704097,"avatar_url":"https://avatars0.githubusercontent.com/u/7704097?v=3","gravatar_id":"","url":"https://api.github.com/users/matthieu-nesme","html_url":"https://github.com/matthieu-nesme","followers_url":"https://api.github.com/users/matthieu-nesme/followers","following_url":"https://api.github.com/users/matthieu-nesme/following{/other_user}","gists_url":"https://api.github.com/users/matthieu-nesme/gists{/gist_id}","starred_url":"https://api.github.com/users/matthieu-nesme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthieu-nesme/subscriptions","organizations_url":"https://api.github.com/users/matthieu-nesme/orgs","repos_url":"https://api.github.com/users/matthieu-nesme/repos","events_url":"https://api.github.com/users/matthieu-nesme/events{/privacy}","received_events_url":"https://api.github.com/users/matthieu-nesme/received_events","type":"User","site_admin":false},"body":"This WIP PR intends to clean SofaPython.\r\n\r\n- fix returns on errors (return NULL rather than Py_RETURN_NONE, so the python interpreter can catch it)\r\n- replacing static functions rather than extern C\r\n- fixing memory leaks\r\n...\r\n\r\n(sorry I notice that I created the branch in the main sofa repo...)\r\n______________________________________________________\r\n<!--- Please leave this at the end of your message -->\r\nThis PR: \r\n- [ ] builds with SUCCESS for all platforms on the CI.\r\n- [ ] does not generate new warnings.\r\n- [ ] does not generate new unit test failures.\r\n- [ ] does not generate new scene test failures.\r\n- [ ] does not break API compatibility.\r\n- [ ] is more than 1 week old (or has fast-merge label).\r\n\r\n**Reviewers will merge only if all these checks are true.**\r\n","created_at":"2017-06-14T09:23:49Z","updated_at":"2017-06-20T09:51:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6e87ba8ea525854e995291564d427764a299cc06","assignee":{"login":"maxime-tournier","id":3356385,"avatar_url":"https://avatars2.githubusercontent.com/u/3356385?v=3","gravatar_id":"","url":"https://api.github.com/users/maxime-tournier","html_url":"https://github.com/maxime-tournier","followers_url":"https://api.github.com/users/maxime-tournier/followers","following_url":"https://api.github.com/users/maxime-tournier/following{/other_user}","gists_url":"https://api.github.com/users/maxime-tournier/gists{/gist_id}","starred_url":"https://api.github.com/users/maxime-tournier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxime-tournier/subscriptions","organizations_url":"https://api.github.com/users/maxime-tournier/orgs","repos_url":"https://api.github.com/users/maxime-tournier/repos","events_url":"https://api.github.com/users/maxime-tournier/events{/privacy}","received_events_url":"https://api.github.com/users/maxime-tournier/received_events","type":"User","site_admin":false},"assignees":[{"login":"maxime-tournier","id":3356385,"avatar_url":"https://avatars2.githubusercontent.com/u/3356385?v=3","gravatar_id":"","url":"https://api.github.com/users/maxime-tournier","html_url":"https://github.com/maxime-tournier","followers_url":"https://api.github.com/users/maxime-tournier/followers","following_url":"https://api.github.com/users/maxime-tournier/following{/other_user}","gists_url":"https://api.github.com/users/maxime-tournier/gists{/gist_id}","starred_url":"https://api.github.com/users/maxime-tournier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxime-tournier/subscriptions","organizations_url":"https://api.github.com/users/maxime-tournier/orgs","repos_url":"https://api.github.com/users/maxime-tournier/repos","events_url":"https://api.github.com/users/maxime-tournier/events{/privacy}","received_events_url":"https://api.github.com/users/maxime-tournier/received_events","type":"User","site_admin":false},{"login":"matthieu-nesme","id":7704097,"avatar_url":"https://avatars0.githubusercontent.com/u/7704097?v=3","gravatar_id":"","url":"https://api.github.com/users/matthieu-nesme","html_url":"https://github.com/matthieu-nesme","followers_url":"https://api.github.com/users/matthieu-nesme/followers","following_url":"https://api.github.com/users/matthieu-nesme/following{/other_user}","gists_url":"https://api.github.com/users/matthieu-nesme/gists{/gist_id}","starred_url":"https://api.github.com/users/matthieu-nesme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthieu-nesme/subscriptions","organizations_url":"https://api.github.com/users/matthieu-nesme/orgs","repos_url":"https://api.github.com/users/matthieu-nesme/repos","events_url":"https://api.github.com/users/matthieu-nesme/events{/privacy}","received_events_url":"https://api.github.com/users/matthieu-nesme/received_events","type":"User","site_admin":false},{"login":"damienmarchal","id":12644882,"avatar_url":"https://avatars2.githubusercontent.com/u/12644882?v=3","gravatar_id":"","url":"https://api.github.com/users/damienmarchal","html_url":"https://github.com/damienmarchal","followers_url":"https://api.github.com/users/damienmarchal/followers","following_url":"https://api.github.com/users/damienmarchal/following{/other_user}","gists_url":"https://api.github.com/users/damienmarchal/gists{/gist_id}","starred_url":"https://api.github.com/users/damienmarchal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damienmarchal/subscriptions","organizations_url":"https://api.github.com/users/damienmarchal/orgs","repos_url":"https://api.github.com/users/damienmarchal/repos","events_url":"https://api.github.com/users/damienmarchal/events{/privacy}","received_events_url":"https://api.github.com/users/damienmarchal/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"bcarrez","id":18696238,"avatar_url":"https://avatars0.githubusercontent.com/u/18696238?v=3","gravatar_id":"","url":"https://api.github.com/users/bcarrez","html_url":"https://github.com/bcarrez","followers_url":"https://api.github.com/users/bcarrez/followers","following_url":"https://api.github.com/users/bcarrez/following{/other_user}","gists_url":"https://api.github.com/users/bcarrez/gists{/gist_id}","starred_url":"https://api.github.com/users/bcarrez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcarrez/subscriptions","organizations_url":"https://api.github.com/users/bcarrez/orgs","repos_url":"https://api.github.com/users/bcarrez/repos","events_url":"https://api.github.com/users/bcarrez/events{/privacy}","received_events_url":"https://api.github.com/users/bcarrez/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/sofa-framework/sofa/pulls/304/commits","review_comments_url":"https://api.github.com/repos/sofa-framework/sofa/pulls/304/comments","review_comment_url":"https://api.github.com/repos/sofa-framework/sofa/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sofa-framework/sofa/issues/304/comments","statuses_url":"https://api.github.com/repos/sofa-framework/sofa/statuses/f919b4de610847506ff9d0e461e3302938cba76c","head":{"label":"sofa-framework:sofapython_clean","ref":"sofapython_clean","sha":"f919b4de610847506ff9d0e461e3302938cba76c","user":{"login":"sofa-framework","id":11028508,"avatar_url":"https://avatars1.githubusercontent.com/u/11028508?v=3","gravatar_id":"","url":"https://api.github.com/users/sofa-framework","html_url":"https://github.com/sofa-framework","followers_url":"https://api.github.com/users/sofa-framework/followers","following_url":"https://api.github.com/users/sofa-framework/following{/other_user}","gists_url":"https://api.github.com/users/sofa-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/sofa-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sofa-framework/subscriptions","organizations_url":"https://api.github.com/users/sofa-framework/orgs","repos_url":"https://api.github.com/users/sofa-framework/repos","events_url":"https://api.github.com/users/sofa-framework/events{/privacy}","received_events_url":"https://api.github.com/users/sofa-framework/received_events","type":"Organization","site_admin":false},"repo":{"id":60089478,"name":"sofa","full_name":"sofa-framework/sofa","owner":{"login":"sofa-framework","id":11028508,"avatar_url":"https://avatars1.githubusercontent.com/u/11028508?v=3","gravatar_id":"","url":"https://api.github.com/users/sofa-framework","html_url":"https://github.com/sofa-framework","followers_url":"https://api.github.com/users/sofa-framework/followers","following_url":"https://api.github.com/users/sofa-framework/following{/other_user}","gists_url":"https://api.github.com/users/sofa-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/sofa-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sofa-framework/subscriptions","organizations_url":"https://api.github.com/users/sofa-framework/orgs","repos_url":"https://api.github.com/users/sofa-framework/repos","events_url":"https://api.github.com/users/sofa-framework/events{/privacy}","received_events_url":"https://api.github.com/users/sofa-framework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sofa-framework/sofa","description":"Real-time multi-physics simulation with an emphasis on medical simulation.","fork":false,"url":"https://api.github.com/repos/sofa-framework/sofa","forks_url":"https://api.github.com/repos/sofa-framework/sofa/forks","keys_url":"https://api.github.com/repos/sofa-framework/sofa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sofa-framework/sofa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sofa-framework/sofa/teams","hooks_url":"https://api.github.com/repos/sofa-framework/sofa/hooks","issue_events_url":"https://api.github.com/repos/sofa-framework/sofa/issues/events{/number}","events_url":"https://api.github.com/repos/sofa-framework/sofa/events","assignees_url":"https://api.github.com/repos/sofa-framework/sofa/assignees{/user}","branches_url":"https://api.github.com/repos/sofa-framework/sofa/branches{/branch}","tags_url":"https://api.github.com/repos/sofa-framework/sofa/tags","blobs_url":"https://api.github.com/repos/sofa-framework/sofa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sofa-framework/sofa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sofa-framework/sofa/git/refs{/sha}","trees_url":"https://api.github.com/repos/sofa-framework/sofa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sofa-framework/sofa/statuses/{sha}","languages_url":"https://api.github.com/repos/sofa-framework/sofa/languages","stargazers_url":"https://api.github.com/repos/sofa-framework/sofa/stargazers","contributors_url":"https://api.github.com/repos/sofa-framework/sofa/contributors","subscribers_url":"https://api.github.com/repos/sofa-framework/sofa/subscribers","subscription_url":"https://api.github.com/repos/sofa-framework/sofa/subscription","commits_url":"https://api.github.com/repos/sofa-framework/sofa/commits{/sha}","git_commits_url":"https://api.github.com/repos/sofa-framework/sofa/git/commits{/sha}","comments_url":"https://api.github.com/repos/sofa-framework/sofa/comments{/number}","issue_comment_url":"https://api.github.com/repos/sofa-framework/sofa/issues/comments{/number}","contents_url":"https://api.github.com/repos/sofa-framework/sofa/contents/{+path}","compare_url":"https://api.github.com/repos/sofa-framework/sofa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sofa-framework/sofa/merges","archive_url":"https://api.github.com/repos/sofa-framework/sofa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sofa-framework/sofa/downloads","issues_url":"https://api.github.com/repos/sofa-framework/sofa/issues{/number}","pulls_url":"https://api.github.com/repos/sofa-framework/sofa/pulls{/number}","milestones_url":"https://api.github.com/repos/sofa-framework/sofa/milestones{/number}","notifications_url":"https://api.github.com/repos/sofa-framework/sofa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sofa-framework/sofa/labels{/name}","releases_url":"https://api.github.com/repos/sofa-framework/sofa/releases{/id}","deployments_url":"https://api.github.com/repos/sofa-framework/sofa/deployments","created_at":"2016-05-31T12:57:59Z","updated_at":"2017-06-18T00:39:07Z","pushed_at":"2017-06-20T09:34:35Z","git_url":"git://github.com/sofa-framework/sofa.git","ssh_url":"git@github.com:sofa-framework/sofa.git","clone_url":"https://github.com/sofa-framework/sofa.git","svn_url":"https://github.com/sofa-framework/sofa","homepage":"https://www.sofa-framework.org","size":304816,"stargazers_count":82,"watchers_count":82,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":56,"mirror_url":null,"open_issues_count":76,"forks":56,"open_issues":76,"watchers":82,"default_branch":"master"}},"base":{"label":"sofa-framework:master","ref":"master","sha":"03ac52b4115c2b2766bd4249bd6db39b910cd53f","user":{"login":"sofa-framework","id":11028508,"avatar_url":"https://avatars1.githubusercontent.com/u/11028508?v=3","gravatar_id":"","url":"https://api.github.com/users/sofa-framework","html_url":"https://github.com/sofa-framework","followers_url":"https://api.github.com/users/sofa-framework/followers","following_url":"https://api.github.com/users/sofa-framework/following{/other_user}","gists_url":"https://api.github.com/users/sofa-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/sofa-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sofa-framework/subscriptions","organizations_url":"https://api.github.com/users/sofa-framework/orgs","repos_url":"https://api.github.com/users/sofa-framework/repos","events_url":"https://api.github.com/users/sofa-framework/events{/privacy}","received_events_url":"https://api.github.com/users/sofa-framework/received_events","type":"Organization","site_admin":false},"repo":{"id":60089478,"name":"sofa","full_name":"sofa-framework/sofa","owner":{"login":"sofa-framework","id":11028508,"avatar_url":"https://avatars1.githubusercontent.com/u/11028508?v=3","gravatar_id":"","url":"https://api.github.com/users/sofa-framework","html_url":"https://github.com/sofa-framework","followers_url":"https://api.github.com/users/sofa-framework/followers","following_url":"https://api.github.com/users/sofa-framework/following{/other_user}","gists_url":"https://api.github.com/users/sofa-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/sofa-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sofa-framework/subscriptions","organizations_url":"https://api.github.com/users/sofa-framework/orgs","repos_url":"https://api.github.com/users/sofa-framework/repos","events_url":"https://api.github.com/users/sofa-framework/events{/privacy}","received_events_url":"https://api.github.com/users/sofa-framework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sofa-framework/sofa","description":"Real-time multi-physics simulation with an emphasis on medical simulation.","fork":false,"url":"https://api.github.com/repos/sofa-framework/sofa","forks_url":"https://api.github.com/repos/sofa-framework/sofa/forks","keys_url":"https://api.github.com/repos/sofa-framework/sofa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sofa-framework/sofa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sofa-framework/sofa/teams","hooks_url":"https://api.github.com/repos/sofa-framework/sofa/hooks","issue_events_url":"https://api.github.com/repos/sofa-framework/sofa/issues/events{/number}","events_url":"https://api.github.com/repos/sofa-framework/sofa/events","assignees_url":"https://api.github.com/repos/sofa-framework/sofa/assignees{/user}","branches_url":"https://api.github.com/repos/sofa-framework/sofa/branches{/branch}","tags_url":"https://api.github.com/repos/sofa-framework/sofa/tags","blobs_url":"https://api.github.com/repos/sofa-framework/sofa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sofa-framework/sofa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sofa-framework/sofa/git/refs{/sha}","trees_url":"https://api.github.com/repos/sofa-framework/sofa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sofa-framework/sofa/statuses/{sha}","languages_url":"https://api.github.com/repos/sofa-framework/sofa/languages","stargazers_url":"https://api.github.com/repos/sofa-framework/sofa/stargazers","contributors_url":"https://api.github.com/repos/sofa-framework/sofa/contributors","subscribers_url":"https://api.github.com/repos/sofa-framework/sofa/subscribers","subscription_url":"https://api.github.com/repos/sofa-framework/sofa/subscription","commits_url":"https://api.github.com/repos/sofa-framework/sofa/commits{/sha}","git_commits_url":"https://api.github.com/repos/sofa-framework/sofa/git/commits{/sha}","comments_url":"https://api.github.com/repos/sofa-framework/sofa/comments{/number}","issue_comment_url":"https://api.github.com/repos/sofa-framework/sofa/issues/comments{/number}","contents_url":"https://api.github.com/repos/sofa-framework/sofa/contents/{+path}","compare_url":"https://api.github.com/repos/sofa-framework/sofa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sofa-framework/sofa/merges","archive_url":"https://api.github.com/repos/sofa-framework/sofa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sofa-framework/sofa/downloads","issues_url":"https://api.github.com/repos/sofa-framework/sofa/issues{/number}","pulls_url":"https://api.github.com/repos/sofa-framework/sofa/pulls{/number}","milestones_url":"https://api.github.com/repos/sofa-framework/sofa/milestones{/number}","notifications_url":"https://api.github.com/repos/sofa-framework/sofa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sofa-framework/sofa/labels{/name}","releases_url":"https://api.github.com/repos/sofa-framework/sofa/releases{/id}","deployments_url":"https://api.github.com/repos/sofa-framework/sofa/deployments","created_at":"2016-05-31T12:57:59Z","updated_at":"2017-06-18T00:39:07Z","pushed_at":"2017-06-20T09:34:35Z","git_url":"git://github.com/sofa-framework/sofa.git","ssh_url":"git@github.com:sofa-framework/sofa.git","clone_url":"https://github.com/sofa-framework/sofa.git","svn_url":"https://github.com/sofa-framework/sofa","homepage":"https://www.sofa-framework.org","size":304816,"stargazers_count":82,"watchers_count":82,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":56,"mirror_url":null,"open_issues_count":76,"forks":56,"open_issues":76,"watchers":82,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sofa-framework/sofa/pulls/304"},"html":{"href":"https://github.com/sofa-framework/sofa/pull/304"},"issue":{"href":"https://api.github.com/repos/sofa-framework/sofa/issues/304"},"comments":{"href":"https://api.github.com/repos/sofa-framework/sofa/issues/304/comments"},"review_comments":{"href":"https://api.github.com/repos/sofa-framework/sofa/pulls/304/comments"},"review_comment":{"href":"https://api.github.com/repos/sofa-framework/sofa/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sofa-framework/sofa/pulls/304/commits"},"statuses":{"href":"https://api.github.com/repos/sofa-framework/sofa/statuses/f919b4de610847506ff9d0e461e3302938cba76c"}}}}
{"actor":{"display_login":"maxime-tournier"}}