{"action":"created","issue":{"url":"https://api.github.com/repos/dsmith-projects/net-bootcamp/issues/2","repository_url":"https://api.github.com/repos/dsmith-projects/net-bootcamp","labels_url":"https://api.github.com/repos/dsmith-projects/net-bootcamp/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/dsmith-projects/net-bootcamp/issues/2/comments","events_url":"https://api.github.com/repos/dsmith-projects/net-bootcamp/issues/2/events","html_url":"https://github.com/dsmith-projects/net-bootcamp/issues/2","id":267542452,"number":2,"title":"Inventory app issues","user":{"login":"fcu423","id":5819170,"avatar_url":"https://avatars1.githubusercontent.com/u/5819170?v=4","gravatar_id":"","url":"https://api.github.com/users/fcu423","html_url":"https://github.com/fcu423","followers_url":"https://api.github.com/users/fcu423/followers","following_url":"https://api.github.com/users/fcu423/following{/other_user}","gists_url":"https://api.github.com/users/fcu423/gists{/gist_id}","starred_url":"https://api.github.com/users/fcu423/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fcu423/subscriptions","organizations_url":"https://api.github.com/users/fcu423/orgs","repos_url":"https://api.github.com/users/fcu423/repos","events_url":"https://api.github.com/users/fcu423/events{/privacy}","received_events_url":"https://api.github.com/users/fcu423/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"dsmith-projects","id":23016444,"avatar_url":"https://avatars3.githubusercontent.com/u/23016444?v=4","gravatar_id":"","url":"https://api.github.com/users/dsmith-projects","html_url":"https://github.com/dsmith-projects","followers_url":"https://api.github.com/users/dsmith-projects/followers","following_url":"https://api.github.com/users/dsmith-projects/following{/other_user}","gists_url":"https://api.github.com/users/dsmith-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/dsmith-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsmith-projects/subscriptions","organizations_url":"https://api.github.com/users/dsmith-projects/orgs","repos_url":"https://api.github.com/users/dsmith-projects/repos","events_url":"https://api.github.com/users/dsmith-projects/events{/privacy}","received_events_url":"https://api.github.com/users/dsmith-projects/received_events","type":"User","site_admin":false},"assignees":[{"login":"dsmith-projects","id":23016444,"avatar_url":"https://avatars3.githubusercontent.com/u/23016444?v=4","gravatar_id":"","url":"https://api.github.com/users/dsmith-projects","html_url":"https://github.com/dsmith-projects","followers_url":"https://api.github.com/users/dsmith-projects/followers","following_url":"https://api.github.com/users/dsmith-projects/following{/other_user}","gists_url":"https://api.github.com/users/dsmith-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/dsmith-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsmith-projects/subscriptions","organizations_url":"https://api.github.com/users/dsmith-projects/orgs","repos_url":"https://api.github.com/users/dsmith-projects/repos","events_url":"https://api.github.com/users/dsmith-projects/events{/privacy}","received_events_url":"https://api.github.com/users/dsmith-projects/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2017-10-23T05:04:38Z","updated_at":"2017-10-23T19:57:59Z","closed_at":null,"author_association":"COLLABORATOR","body":"- `ReadWriteFiles` es un nombre de clase muy genérico que no representa el contenido de las funciones\r\n\t- Separar las funciones lógicamente de acuerdo a la entidad con la que están relacionadas: Funciones relacionadas con artículos en una clase, las de facturas en otra o mínimamente separadas entre lectura y escritura.\r\n\r\n- El `StringBuilder` solo debe ser usado cuando se va a construir un `String` haciendo uso de algún ciclo o cuando las concatenaciones usando `+=` son demasiadas. En estos casos resulta útil pues hace un mejor manejo de memoria y tiene buen impacto en el código. Usarlo en casos donde solo es para concatenar unas pocas líneas añade carga innecesaria al programa y puede tener impacto negativo en el desempeño del programa de ser usado mucho sin necesidad. Debe ser removido de donde no sea estrictamente necesario en el código.\r\n\r\n- Refactorizar funciones largas como `CreateNewInvoice`. Se debe mantener el principio de \"Single Reponsability\" y separar partes del código en otras funciones. Funciones así de largas son difíciles de leer/entender/depurar. \r\n\t- Lo recomendado es mantener las funciones con un máximo de 10 líneas en lo posible\r\n\t- A la hora de refactorizar se debe tener en cuenta que puede ser necesario crear nuevas clases para mantener el código bien estructurado y entendible\r\n\t\r\n- El nombre de usuario y la contraseña del admin están quemadas en el código. Estás se deben validar contra el archivo de configuración de la aplicación: `App.config`, no contra valores quemados en el código.\r\n\r\n- Al seleccionar una opción inexistente en la consola en el modo usuario, esta vuelve a pintar el menú sin limpiar la consola lo que hace difícil de usar la aplicación\r\n\r\n- La aplicación me deja ingresar elementos diferentes con el mismo ID\r\n\r\n- La aplicación solo imprime el reporte correctamente para las facturas creadas durante la ejecución del programa. \r\n\t- El reporte debe ser generado siempre basado en todas las facturas creadas en el sistema (Leyendo los archivos).\r\n"},"comment":{"url":"https://api.github.com/repos/dsmith-projects/net-bootcamp/issues/comments/338778243","html_url":"https://github.com/dsmith-projects/net-bootcamp/issues/2#issuecomment-338778243","issue_url":"https://api.github.com/repos/dsmith-projects/net-bootcamp/issues/2","id":338778243,"user":{"login":"dsmith-projects","id":23016444,"avatar_url":"https://avatars3.githubusercontent.com/u/23016444?v=4","gravatar_id":"","url":"https://api.github.com/users/dsmith-projects","html_url":"https://github.com/dsmith-projects","followers_url":"https://api.github.com/users/dsmith-projects/followers","following_url":"https://api.github.com/users/dsmith-projects/following{/other_user}","gists_url":"https://api.github.com/users/dsmith-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/dsmith-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsmith-projects/subscriptions","organizations_url":"https://api.github.com/users/dsmith-projects/orgs","repos_url":"https://api.github.com/users/dsmith-projects/repos","events_url":"https://api.github.com/users/dsmith-projects/events{/privacy}","received_events_url":"https://api.github.com/users/dsmith-projects/received_events","type":"User","site_admin":false},"created_at":"2017-10-23T19:57:59Z","updated_at":"2017-10-23T19:57:59Z","author_association":"OWNER","body":"Hola. Ya estoy trabajando en estas correcciones."}}
{"actor":{"display_login":"dsmith-projects"}}