{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/comments/138785342","pull_request_review_id":62627098,"id":138785342,"diff_hunk":"@@ -0,0 +1,565 @@\n+{\n+  \"$schema\": \"https://schema.management.azure.com/schemas/2015-01-01/deploymentTemplate.json#\",\n+  \"contentVersion\": \"1.0.0.0\",\n+  \"parameters\": {\n+      \"clusterName\": {\n+          \"type\": \"string\",\n+          \"defaultValue\": \"sfcluster\",\n+          \"metadata\": {\n+              \"description\": \"Name of your cluster - Between 3 and 23 characters. Letters and numbers only\"\n+          }\n+      },\n+      \"adminUserName\": {\n+          \"type\": \"string\",\n+          \"metadata\": {\n+              \"description\": \"Remote desktop user Id\"\n+          }\n+      },\n+      \"adminPassword\": {\n+          \"type\": \"securestring\",\n+          \"metadata\": {\n+              \"description\": \"Remote desktop user password. Must be a strong password\"\n+          }\n+      },\n+      \"vmImagePublisher\": {","path":"301-sf-preview-windows-containers/azuredeploy.json","position":24,"original_position":24,"commit_id":"55ef2d84f91ee9ef25629bedf06e30fdc7b722b1","original_commit_id":"55ef2d84f91ee9ef25629bedf06e30fdc7b722b1","user":{"login":"bmoore-msft","id":10090014,"avatar_url":"https://avatars1.githubusercontent.com/u/10090014?v=4","gravatar_id":"","url":"https://api.github.com/users/bmoore-msft","html_url":"https://github.com/bmoore-msft","followers_url":"https://api.github.com/users/bmoore-msft/followers","following_url":"https://api.github.com/users/bmoore-msft/following{/other_user}","gists_url":"https://api.github.com/users/bmoore-msft/gists{/gist_id}","starred_url":"https://api.github.com/users/bmoore-msft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmoore-msft/subscriptions","organizations_url":"https://api.github.com/users/bmoore-msft/orgs","repos_url":"https://api.github.com/users/bmoore-msft/repos","events_url":"https://api.github.com/users/bmoore-msft/events{/privacy}","received_events_url":"https://api.github.com/users/bmoore-msft/received_events","type":"User","site_admin":false},"body":"move all the VM image params to variables or just use literal values if used only once","created_at":"2017-09-14T02:39:04Z","updated_at":"2017-09-14T02:45:59Z","html_url":"https://github.com/Azure/azure-quickstart-templates/pull/3861#discussion_r138785342","pull_request_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/3861","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/comments/138785342"},"html":{"href":"https://github.com/Azure/azure-quickstart-templates/pull/3861#discussion_r138785342"},"pull_request":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/3861"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/3861","id":139434712,"html_url":"https://github.com/Azure/azure-quickstart-templates/pull/3861","diff_url":"https://github.com/Azure/azure-quickstart-templates/pull/3861.diff","patch_url":"https://github.com/Azure/azure-quickstart-templates/pull/3861.patch","issue_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues/3861","number":3861,"state":"open","locked":false,"title":"Adding a service fabric with windows containers and managed disks exa…","user":{"login":"jwendl","id":1068431,"avatar_url":"https://avatars1.githubusercontent.com/u/1068431?v=4","gravatar_id":"","url":"https://api.github.com/users/jwendl","html_url":"https://github.com/jwendl","followers_url":"https://api.github.com/users/jwendl/followers","following_url":"https://api.github.com/users/jwendl/following{/other_user}","gists_url":"https://api.github.com/users/jwendl/gists{/gist_id}","starred_url":"https://api.github.com/users/jwendl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwendl/subscriptions","organizations_url":"https://api.github.com/users/jwendl/orgs","repos_url":"https://api.github.com/users/jwendl/repos","events_url":"https://api.github.com/users/jwendl/events{/privacy}","received_events_url":"https://api.github.com/users/jwendl/received_events","type":"User","site_admin":false},"body":"### Best Practice Checklist\r\nCheck these items before submitting a PR... See the Contribution Guide for the full detail: https://github.com/Azure/azure-quickstart-templates/blob/master/1-CONTRIBUTION-GUIDE/README.md \r\n\r\n\r\nFor details: https://github.com/Azure/azure-quickstart-templates/blob/master/1-CONTRIBUTION-GUIDE/bp-checklist.md\r\n\r\n- [x] - Please check this box once you've submitted the PR if you've read through the Contribution Guide and best practices checklist.\r\n\r\n### Changelog\r\n\r\n* Initial submission for PR for Service Fabric with Windows Containers example (with managed disks)\r\n*\r\n*\r\n\r\n","created_at":"2017-09-05T22:26:20Z","updated_at":"2017-09-14T02:45:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a14b7e4016f937fc36dc3e909c0e2d8d8ae0e005","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/3861/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/3861/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues/3861/comments","statuses_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/statuses/55ef2d84f91ee9ef25629bedf06e30fdc7b722b1","head":{"label":"jwendl:master","ref":"master","sha":"55ef2d84f91ee9ef25629bedf06e30fdc7b722b1","user":{"login":"jwendl","id":1068431,"avatar_url":"https://avatars1.githubusercontent.com/u/1068431?v=4","gravatar_id":"","url":"https://api.github.com/users/jwendl","html_url":"https://github.com/jwendl","followers_url":"https://api.github.com/users/jwendl/followers","following_url":"https://api.github.com/users/jwendl/following{/other_user}","gists_url":"https://api.github.com/users/jwendl/gists{/gist_id}","starred_url":"https://api.github.com/users/jwendl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwendl/subscriptions","organizations_url":"https://api.github.com/users/jwendl/orgs","repos_url":"https://api.github.com/users/jwendl/repos","events_url":"https://api.github.com/users/jwendl/events{/privacy}","received_events_url":"https://api.github.com/users/jwendl/received_events","type":"User","site_admin":false},"repo":{"id":102533988,"name":"azure-quickstart-templates","full_name":"jwendl/azure-quickstart-templates","owner":{"login":"jwendl","id":1068431,"avatar_url":"https://avatars1.githubusercontent.com/u/1068431?v=4","gravatar_id":"","url":"https://api.github.com/users/jwendl","html_url":"https://github.com/jwendl","followers_url":"https://api.github.com/users/jwendl/followers","following_url":"https://api.github.com/users/jwendl/following{/other_user}","gists_url":"https://api.github.com/users/jwendl/gists{/gist_id}","starred_url":"https://api.github.com/users/jwendl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwendl/subscriptions","organizations_url":"https://api.github.com/users/jwendl/orgs","repos_url":"https://api.github.com/users/jwendl/repos","events_url":"https://api.github.com/users/jwendl/events{/privacy}","received_events_url":"https://api.github.com/users/jwendl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jwendl/azure-quickstart-templates","description":"Azure Quickstart Templates","fork":true,"url":"https://api.github.com/repos/jwendl/azure-quickstart-templates","forks_url":"https://api.github.com/repos/jwendl/azure-quickstart-templates/forks","keys_url":"https://api.github.com/repos/jwendl/azure-quickstart-templates/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jwendl/azure-quickstart-templates/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jwendl/azure-quickstart-templates/teams","hooks_url":"https://api.github.com/repos/jwendl/azure-quickstart-templates/hooks","issue_events_url":"https://api.github.com/repos/jwendl/azure-quickstart-templates/issues/events{/number}","events_url":"https://api.github.com/repos/jwendl/azure-quickstart-templates/events","assignees_url":"https://api.github.com/repos/jwendl/azure-quickstart-templates/assignees{/user}","branches_url":"https://api.github.com/repos/jwendl/azure-quickstart-templates/branches{/branch}","tags_url":"https://api.github.com/repos/jwendl/azure-quickstart-templates/tags","blobs_url":"https://api.github.com/repos/jwendl/azure-quickstart-templates/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jwendl/azure-quickstart-templates/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jwendl/azure-quickstart-templates/git/refs{/sha}","trees_url":"https://api.github.com/repos/jwendl/azure-quickstart-templates/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jwendl/azure-quickstart-templates/statuses/{sha}","languages_url":"https://api.github.com/repos/jwendl/azure-quickstart-templates/languages","stargazers_url":"https://api.github.com/repos/jwendl/azure-quickstart-templates/stargazers","contributors_url":"https://api.github.com/repos/jwendl/azure-quickstart-templates/contributors","subscribers_url":"https://api.github.com/repos/jwendl/azure-quickstart-templates/subscribers","subscription_url":"https://api.github.com/repos/jwendl/azure-quickstart-templates/subscription","commits_url":"https://api.github.com/repos/jwendl/azure-quickstart-templates/commits{/sha}","git_commits_url":"https://api.github.com/repos/jwendl/azure-quickstart-templates/git/commits{/sha}","comments_url":"https://api.github.com/repos/jwendl/azure-quickstart-templates/comments{/number}","issue_comment_url":"https://api.github.com/repos/jwendl/azure-quickstart-templates/issues/comments{/number}","contents_url":"https://api.github.com/repos/jwendl/azure-quickstart-templates/contents/{+path}","compare_url":"https://api.github.com/repos/jwendl/azure-quickstart-templates/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jwendl/azure-quickstart-templates/merges","archive_url":"https://api.github.com/repos/jwendl/azure-quickstart-templates/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jwendl/azure-quickstart-templates/downloads","issues_url":"https://api.github.com/repos/jwendl/azure-quickstart-templates/issues{/number}","pulls_url":"https://api.github.com/repos/jwendl/azure-quickstart-templates/pulls{/number}","milestones_url":"https://api.github.com/repos/jwendl/azure-quickstart-templates/milestones{/number}","notifications_url":"https://api.github.com/repos/jwendl/azure-quickstart-templates/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jwendl/azure-quickstart-templates/labels{/name}","releases_url":"https://api.github.com/repos/jwendl/azure-quickstart-templates/releases{/id}","deployments_url":"https://api.github.com/repos/jwendl/azure-quickstart-templates/deployments","created_at":"2017-09-05T22:02:45Z","updated_at":"2017-09-05T22:02:53Z","pushed_at":"2017-09-06T00:51:47Z","git_url":"git://github.com/jwendl/azure-quickstart-templates.git","ssh_url":"git@github.com:jwendl/azure-quickstart-templates.git","clone_url":"https://github.com/jwendl/azure-quickstart-templates.git","svn_url":"https://github.com/jwendl/azure-quickstart-templates","homepage":"https://azure.microsoft.com/en-us/documentation/templates","size":205515,"stargazers_count":0,"watchers_count":0,"language":"PowerShell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"6cedb2c090855f52b6d50f97395fdf4295a4517c","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":34407651,"name":"azure-quickstart-templates","full_name":"Azure/azure-quickstart-templates","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/azure-quickstart-templates","description":"Azure Quickstart Templates","fork":false,"url":"https://api.github.com/repos/Azure/azure-quickstart-templates","forks_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/forks","keys_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/teams","hooks_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/events","assignees_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/tags","blobs_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/subscription","commits_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/merges","archive_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/downloads","issues_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/deployments","created_at":"2015-04-22T18:19:03Z","updated_at":"2017-09-13T22:04:14Z","pushed_at":"2017-09-14T02:34:38Z","git_url":"git://github.com/Azure/azure-quickstart-templates.git","ssh_url":"git@github.com:Azure/azure-quickstart-templates.git","clone_url":"https://github.com/Azure/azure-quickstart-templates.git","svn_url":"https://github.com/Azure/azure-quickstart-templates","homepage":"https://azure.microsoft.com/en-us/documentation/templates","size":219343,"stargazers_count":2727,"watchers_count":2727,"language":"PowerShell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3892,"mirror_url":null,"open_issues_count":366,"forks":3892,"open_issues":366,"watchers":2727,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/3861"},"html":{"href":"https://github.com/Azure/azure-quickstart-templates/pull/3861"},"issue":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues/3861"},"comments":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues/3861/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/3861/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/3861/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/statuses/55ef2d84f91ee9ef25629bedf06e30fdc7b722b1"}},"author_association":"NONE"}}
{"actor":{"display_login":"bmoore-msft"}}