{"action":"created","comment":{"url":"https://api.github.com/repos/TEAMMATES/teammates/pulls/comments/123876134","pull_request_review_id":46125039,"id":123876134,"diff_hunk":"@@ -36,36 +41,37 @@\n     private boolean isInstructorAllowedToDelete;\n     private boolean isInstructorAllowedToEdit;\n \n-    public FeedbackResponseCommentRow(FeedbackResponseCommentAttributes frc, String giverDisplay) {\n+    public FeedbackResponseCommentRow(FeedbackResponseCommentAttributes frc, String giverDisplay,\n+            Map<String, String> instructorEmailNameTable) {\n+        this.instructorEmailNameTable = instructorEmailNameTable;\n         this.commentId = frc.getId();\n         this.giverDisplay = giverDisplay;\n         this.createdAt = TimeHelper.formatDateTimeForComments(frc.createdAt);\n-        this.editedAt = frc.getEditedAtText(\"Anonymous\".equals(giverDisplay));\n         this.commentText = frc.commentText.getValue();\n+        setCommentGiverNameFromEmail(giverDisplay);\n+        setCommentLastEditorNameFromEmail(frc.lastEditorEmail);","path":"src/main/java/teammates/ui/template/FeedbackResponseCommentRow.java","position":43,"original_position":43,"commit_id":"83b1b6b6daad929d66050c4cb0a74ff2dc723fa3","original_commit_id":"83b1b6b6daad929d66050c4cb0a74ff2dc723fa3","user":{"login":"wkurniawan07","id":7261051,"avatar_url":"https://avatars1.githubusercontent.com/u/7261051?v=3","gravatar_id":"","url":"https://api.github.com/users/wkurniawan07","html_url":"https://github.com/wkurniawan07","followers_url":"https://api.github.com/users/wkurniawan07/followers","following_url":"https://api.github.com/users/wkurniawan07/following{/other_user}","gists_url":"https://api.github.com/users/wkurniawan07/gists{/gist_id}","starred_url":"https://api.github.com/users/wkurniawan07/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wkurniawan07/subscriptions","organizations_url":"https://api.github.com/users/wkurniawan07/orgs","repos_url":"https://api.github.com/users/wkurniawan07/repos","events_url":"https://api.github.com/users/wkurniawan07/events{/privacy}","received_events_url":"https://api.github.com/users/wkurniawan07/received_events","type":"User","site_admin":false},"body":"These two lines should be:\r\n```\r\nthis.commentGiverName = get...;\r\nthis.commentLast = get...;\r\n```","created_at":"2017-06-24T12:15:27Z","updated_at":"2017-06-24T12:18:25Z","html_url":"https://github.com/TEAMMATES/teammates/pull/7551#discussion_r123876134","pull_request_url":"https://api.github.com/repos/TEAMMATES/teammates/pulls/7551","_links":{"self":{"href":"https://api.github.com/repos/TEAMMATES/teammates/pulls/comments/123876134"},"html":{"href":"https://github.com/TEAMMATES/teammates/pull/7551#discussion_r123876134"},"pull_request":{"href":"https://api.github.com/repos/TEAMMATES/teammates/pulls/7551"}}},"pull_request":{"url":"https://api.github.com/repos/TEAMMATES/teammates/pulls/7551","id":126512587,"html_url":"https://github.com/TEAMMATES/teammates/pull/7551","diff_url":"https://github.com/TEAMMATES/teammates/pull/7551.diff","patch_url":"https://github.com/TEAMMATES/teammates/pull/7551.patch","issue_url":"https://api.github.com/repos/TEAMMATES/teammates/issues/7551","number":7551,"state":"open","locked":false,"title":"Show user's name (not email) in comments. #4522","user":{"login":"Mynk96","id":17481466,"avatar_url":"https://avatars1.githubusercontent.com/u/17481466?v=3","gravatar_id":"","url":"https://api.github.com/users/Mynk96","html_url":"https://github.com/Mynk96","followers_url":"https://api.github.com/users/Mynk96/followers","following_url":"https://api.github.com/users/Mynk96/following{/other_user}","gists_url":"https://api.github.com/users/Mynk96/gists{/gist_id}","starred_url":"https://api.github.com/users/Mynk96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mynk96/subscriptions","organizations_url":"https://api.github.com/users/Mynk96/orgs","repos_url":"https://api.github.com/users/Mynk96/repos","events_url":"https://api.github.com/users/Mynk96/events{/privacy}","received_events_url":"https://api.github.com/users/Mynk96/received_events","type":"User","site_admin":false},"body":"Fixes #4522 \r\n\r\nLogic used:-\r\nFor InstructorFeedbackResultsPage, InstructorStudentRecordsPage and StudentFeedbackResultsPage created a map with instructor email(key) and instructor name(value) in feedbackSessionResultsBundle using courseRoster.\r\nFor InstructorSearchPage created the map using available data in FeedbackResponseCommentSearchDocument.java","created_at":"2017-06-20T11:47:18Z","updated_at":"2017-06-24T12:18:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6907cfd17c2d25628c06e97d229466d999ff51f3","assignee":{"login":"chowyb","id":7546744,"avatar_url":"https://avatars0.githubusercontent.com/u/7546744?v=3","gravatar_id":"","url":"https://api.github.com/users/chowyb","html_url":"https://github.com/chowyb","followers_url":"https://api.github.com/users/chowyb/followers","following_url":"https://api.github.com/users/chowyb/following{/other_user}","gists_url":"https://api.github.com/users/chowyb/gists{/gist_id}","starred_url":"https://api.github.com/users/chowyb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chowyb/subscriptions","organizations_url":"https://api.github.com/users/chowyb/orgs","repos_url":"https://api.github.com/users/chowyb/repos","events_url":"https://api.github.com/users/chowyb/events{/privacy}","received_events_url":"https://api.github.com/users/chowyb/received_events","type":"User","site_admin":false},"assignees":[{"login":"chowyb","id":7546744,"avatar_url":"https://avatars0.githubusercontent.com/u/7546744?v=3","gravatar_id":"","url":"https://api.github.com/users/chowyb","html_url":"https://github.com/chowyb","followers_url":"https://api.github.com/users/chowyb/followers","following_url":"https://api.github.com/users/chowyb/following{/other_user}","gists_url":"https://api.github.com/users/chowyb/gists{/gist_id}","starred_url":"https://api.github.com/users/chowyb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chowyb/subscriptions","organizations_url":"https://api.github.com/users/chowyb/orgs","repos_url":"https://api.github.com/users/chowyb/repos","events_url":"https://api.github.com/users/chowyb/events{/privacy}","received_events_url":"https://api.github.com/users/chowyb/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/TEAMMATES/teammates/pulls/7551/commits","review_comments_url":"https://api.github.com/repos/TEAMMATES/teammates/pulls/7551/comments","review_comment_url":"https://api.github.com/repos/TEAMMATES/teammates/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TEAMMATES/teammates/issues/7551/comments","statuses_url":"https://api.github.com/repos/TEAMMATES/teammates/statuses/83b1b6b6daad929d66050c4cb0a74ff2dc723fa3","head":{"label":"Mynk96:4522-Show-users-name-not-email-in-comments","ref":"4522-Show-users-name-not-email-in-comments","sha":"83b1b6b6daad929d66050c4cb0a74ff2dc723fa3","user":{"login":"Mynk96","id":17481466,"avatar_url":"https://avatars1.githubusercontent.com/u/17481466?v=3","gravatar_id":"","url":"https://api.github.com/users/Mynk96","html_url":"https://github.com/Mynk96","followers_url":"https://api.github.com/users/Mynk96/followers","following_url":"https://api.github.com/users/Mynk96/following{/other_user}","gists_url":"https://api.github.com/users/Mynk96/gists{/gist_id}","starred_url":"https://api.github.com/users/Mynk96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mynk96/subscriptions","organizations_url":"https://api.github.com/users/Mynk96/orgs","repos_url":"https://api.github.com/users/Mynk96/repos","events_url":"https://api.github.com/users/Mynk96/events{/privacy}","received_events_url":"https://api.github.com/users/Mynk96/received_events","type":"User","site_admin":false},"repo":{"id":88467207,"name":"teammates","full_name":"Mynk96/teammates","owner":{"login":"Mynk96","id":17481466,"avatar_url":"https://avatars1.githubusercontent.com/u/17481466?v=3","gravatar_id":"","url":"https://api.github.com/users/Mynk96","html_url":"https://github.com/Mynk96","followers_url":"https://api.github.com/users/Mynk96/followers","following_url":"https://api.github.com/users/Mynk96/following{/other_user}","gists_url":"https://api.github.com/users/Mynk96/gists{/gist_id}","starred_url":"https://api.github.com/users/Mynk96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mynk96/subscriptions","organizations_url":"https://api.github.com/users/Mynk96/orgs","repos_url":"https://api.github.com/users/Mynk96/repos","events_url":"https://api.github.com/users/Mynk96/events{/privacy}","received_events_url":"https://api.github.com/users/Mynk96/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Mynk96/teammates","description":"This is the project website for the TEAMMATES feedback management tool for education","fork":true,"url":"https://api.github.com/repos/Mynk96/teammates","forks_url":"https://api.github.com/repos/Mynk96/teammates/forks","keys_url":"https://api.github.com/repos/Mynk96/teammates/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Mynk96/teammates/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Mynk96/teammates/teams","hooks_url":"https://api.github.com/repos/Mynk96/teammates/hooks","issue_events_url":"https://api.github.com/repos/Mynk96/teammates/issues/events{/number}","events_url":"https://api.github.com/repos/Mynk96/teammates/events","assignees_url":"https://api.github.com/repos/Mynk96/teammates/assignees{/user}","branches_url":"https://api.github.com/repos/Mynk96/teammates/branches{/branch}","tags_url":"https://api.github.com/repos/Mynk96/teammates/tags","blobs_url":"https://api.github.com/repos/Mynk96/teammates/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Mynk96/teammates/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Mynk96/teammates/git/refs{/sha}","trees_url":"https://api.github.com/repos/Mynk96/teammates/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Mynk96/teammates/statuses/{sha}","languages_url":"https://api.github.com/repos/Mynk96/teammates/languages","stargazers_url":"https://api.github.com/repos/Mynk96/teammates/stargazers","contributors_url":"https://api.github.com/repos/Mynk96/teammates/contributors","subscribers_url":"https://api.github.com/repos/Mynk96/teammates/subscribers","subscription_url":"https://api.github.com/repos/Mynk96/teammates/subscription","commits_url":"https://api.github.com/repos/Mynk96/teammates/commits{/sha}","git_commits_url":"https://api.github.com/repos/Mynk96/teammates/git/commits{/sha}","comments_url":"https://api.github.com/repos/Mynk96/teammates/comments{/number}","issue_comment_url":"https://api.github.com/repos/Mynk96/teammates/issues/comments{/number}","contents_url":"https://api.github.com/repos/Mynk96/teammates/contents/{+path}","compare_url":"https://api.github.com/repos/Mynk96/teammates/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Mynk96/teammates/merges","archive_url":"https://api.github.com/repos/Mynk96/teammates/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Mynk96/teammates/downloads","issues_url":"https://api.github.com/repos/Mynk96/teammates/issues{/number}","pulls_url":"https://api.github.com/repos/Mynk96/teammates/pulls{/number}","milestones_url":"https://api.github.com/repos/Mynk96/teammates/milestones{/number}","notifications_url":"https://api.github.com/repos/Mynk96/teammates/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Mynk96/teammates/labels{/name}","releases_url":"https://api.github.com/repos/Mynk96/teammates/releases{/id}","deployments_url":"https://api.github.com/repos/Mynk96/teammates/deployments","created_at":"2017-04-17T04:13:06Z","updated_at":"2017-04-17T04:13:12Z","pushed_at":"2017-06-24T12:08:31Z","git_url":"git://github.com/Mynk96/teammates.git","ssh_url":"git@github.com:Mynk96/teammates.git","clone_url":"https://github.com/Mynk96/teammates.git","svn_url":"https://github.com/Mynk96/teammates","homepage":"http://teammatesv4.appspot.com/","size":185728,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"TEAMMATES:master","ref":"master","sha":"54228a83d6ab6bda3ce4c1e36a3ddefb56b6c438","user":{"login":"TEAMMATES","id":7374810,"avatar_url":"https://avatars1.githubusercontent.com/u/7374810?v=3","gravatar_id":"","url":"https://api.github.com/users/TEAMMATES","html_url":"https://github.com/TEAMMATES","followers_url":"https://api.github.com/users/TEAMMATES/followers","following_url":"https://api.github.com/users/TEAMMATES/following{/other_user}","gists_url":"https://api.github.com/users/TEAMMATES/gists{/gist_id}","starred_url":"https://api.github.com/users/TEAMMATES/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TEAMMATES/subscriptions","organizations_url":"https://api.github.com/users/TEAMMATES/orgs","repos_url":"https://api.github.com/users/TEAMMATES/repos","events_url":"https://api.github.com/users/TEAMMATES/events{/privacy}","received_events_url":"https://api.github.com/users/TEAMMATES/received_events","type":"Organization","site_admin":false},"repo":{"id":19369035,"name":"teammates","full_name":"TEAMMATES/teammates","owner":{"login":"TEAMMATES","id":7374810,"avatar_url":"https://avatars1.githubusercontent.com/u/7374810?v=3","gravatar_id":"","url":"https://api.github.com/users/TEAMMATES","html_url":"https://github.com/TEAMMATES","followers_url":"https://api.github.com/users/TEAMMATES/followers","following_url":"https://api.github.com/users/TEAMMATES/following{/other_user}","gists_url":"https://api.github.com/users/TEAMMATES/gists{/gist_id}","starred_url":"https://api.github.com/users/TEAMMATES/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TEAMMATES/subscriptions","organizations_url":"https://api.github.com/users/TEAMMATES/orgs","repos_url":"https://api.github.com/users/TEAMMATES/repos","events_url":"https://api.github.com/users/TEAMMATES/events{/privacy}","received_events_url":"https://api.github.com/users/TEAMMATES/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TEAMMATES/teammates","description":"This is the project website for the TEAMMATES feedback management tool for education","fork":false,"url":"https://api.github.com/repos/TEAMMATES/teammates","forks_url":"https://api.github.com/repos/TEAMMATES/teammates/forks","keys_url":"https://api.github.com/repos/TEAMMATES/teammates/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TEAMMATES/teammates/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TEAMMATES/teammates/teams","hooks_url":"https://api.github.com/repos/TEAMMATES/teammates/hooks","issue_events_url":"https://api.github.com/repos/TEAMMATES/teammates/issues/events{/number}","events_url":"https://api.github.com/repos/TEAMMATES/teammates/events","assignees_url":"https://api.github.com/repos/TEAMMATES/teammates/assignees{/user}","branches_url":"https://api.github.com/repos/TEAMMATES/teammates/branches{/branch}","tags_url":"https://api.github.com/repos/TEAMMATES/teammates/tags","blobs_url":"https://api.github.com/repos/TEAMMATES/teammates/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TEAMMATES/teammates/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TEAMMATES/teammates/git/refs{/sha}","trees_url":"https://api.github.com/repos/TEAMMATES/teammates/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TEAMMATES/teammates/statuses/{sha}","languages_url":"https://api.github.com/repos/TEAMMATES/teammates/languages","stargazers_url":"https://api.github.com/repos/TEAMMATES/teammates/stargazers","contributors_url":"https://api.github.com/repos/TEAMMATES/teammates/contributors","subscribers_url":"https://api.github.com/repos/TEAMMATES/teammates/subscribers","subscription_url":"https://api.github.com/repos/TEAMMATES/teammates/subscription","commits_url":"https://api.github.com/repos/TEAMMATES/teammates/commits{/sha}","git_commits_url":"https://api.github.com/repos/TEAMMATES/teammates/git/commits{/sha}","comments_url":"https://api.github.com/repos/TEAMMATES/teammates/comments{/number}","issue_comment_url":"https://api.github.com/repos/TEAMMATES/teammates/issues/comments{/number}","contents_url":"https://api.github.com/repos/TEAMMATES/teammates/contents/{+path}","compare_url":"https://api.github.com/repos/TEAMMATES/teammates/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TEAMMATES/teammates/merges","archive_url":"https://api.github.com/repos/TEAMMATES/teammates/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TEAMMATES/teammates/downloads","issues_url":"https://api.github.com/repos/TEAMMATES/teammates/issues{/number}","pulls_url":"https://api.github.com/repos/TEAMMATES/teammates/pulls{/number}","milestones_url":"https://api.github.com/repos/TEAMMATES/teammates/milestones{/number}","notifications_url":"https://api.github.com/repos/TEAMMATES/teammates/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TEAMMATES/teammates/labels{/name}","releases_url":"https://api.github.com/repos/TEAMMATES/teammates/releases{/id}","deployments_url":"https://api.github.com/repos/TEAMMATES/teammates/deployments","created_at":"2014-05-02T07:43:00Z","updated_at":"2017-06-23T02:14:25Z","pushed_at":"2017-06-24T12:08:33Z","git_url":"git://github.com/TEAMMATES/teammates.git","ssh_url":"git@github.com:TEAMMATES/teammates.git","clone_url":"https://github.com/TEAMMATES/teammates.git","svn_url":"https://github.com/TEAMMATES/teammates","homepage":"https://teammatesv4.appspot.com/","size":187845,"stargazers_count":360,"watchers_count":360,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":826,"mirror_url":null,"open_issues_count":301,"forks":826,"open_issues":301,"watchers":360,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TEAMMATES/teammates/pulls/7551"},"html":{"href":"https://github.com/TEAMMATES/teammates/pull/7551"},"issue":{"href":"https://api.github.com/repos/TEAMMATES/teammates/issues/7551"},"comments":{"href":"https://api.github.com/repos/TEAMMATES/teammates/issues/7551/comments"},"review_comments":{"href":"https://api.github.com/repos/TEAMMATES/teammates/pulls/7551/comments"},"review_comment":{"href":"https://api.github.com/repos/TEAMMATES/teammates/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TEAMMATES/teammates/pulls/7551/commits"},"statuses":{"href":"https://api.github.com/repos/TEAMMATES/teammates/statuses/83b1b6b6daad929d66050c4cb0a74ff2dc723fa3"}}}}
{"actor":{"display_login":"wkurniawan07"}}