{"action":"created","issue":{"url":"https://api.github.com/repos/decred/dcrutil/issues/64","repository_url":"https://api.github.com/repos/decred/dcrutil","labels_url":"https://api.github.com/repos/decred/dcrutil/issues/64/labels{/name}","comments_url":"https://api.github.com/repos/decred/dcrutil/issues/64/comments","events_url":"https://api.github.com/repos/decred/dcrutil/issues/64/events","html_url":"https://github.com/decred/dcrutil/issues/64","id":264302837,"number":64,"title":"Remove cyclic dependency with dcrd repo","user":{"login":"jrick","id":1420313,"avatar_url":"https://avatars3.githubusercontent.com/u/1420313?v=4","gravatar_id":"","url":"https://api.github.com/users/jrick","html_url":"https://github.com/jrick","followers_url":"https://api.github.com/users/jrick/followers","following_url":"https://api.github.com/users/jrick/following{/other_user}","gists_url":"https://api.github.com/users/jrick/gists{/gist_id}","starred_url":"https://api.github.com/users/jrick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrick/subscriptions","organizations_url":"https://api.github.com/users/jrick/orgs","repos_url":"https://api.github.com/users/jrick/repos","events_url":"https://api.github.com/users/jrick/events{/privacy}","received_events_url":"https://api.github.com/users/jrick/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-10-10T16:58:24Z","updated_at":"2017-10-10T16:59:36Z","closed_at":null,"author_association":"MEMBER","body":"Any packages from this repo that depend on dcrd that dcrd is also importing need to be moved into the dcrd repo.  This prevents a cyclic repo dependency structure.\r\n\r\nThe following packages/code from this repo do not need to be moved to dcrd (but some will need to be moved to their own repos):\r\n\r\n* base58 (after removing the dependency on chainhash)\r\n* bloom (bloom filters are not supported and this code can be removed)\r\n* coinset (depends on dcrd packages but dcrd packages do not depend on it)\r\n* dcrutil (TLS certificate generation and WIF private keys do not cause a cyclic dependency)\r\n\r\nAny packages that remain that depend on dcrd packages can stay in this repo, but it is important that the rest which do not import dcrd (but which dcrd imports) are moved to their own repos, or else the cycle will remain.\r\n\r\nThese packages/code do need to be moved to the dcrd repo:\r\n\r\n* hdkeychain (import many dcrd packages and dcrd imports it for the rpc test harness)\r\n* dcrutil (Address, Amount, Block, TLS certificate generation, Hash160, and Tx all cause cyclic dependencies with dcrd)"},"comment":{"url":"https://api.github.com/repos/decred/dcrutil/issues/comments/335540213","html_url":"https://github.com/decred/dcrutil/issues/64#issuecomment-335540213","issue_url":"https://api.github.com/repos/decred/dcrutil/issues/64","id":335540213,"user":{"login":"davecgh","id":2115102,"avatar_url":"https://avatars3.githubusercontent.com/u/2115102?v=4","gravatar_id":"","url":"https://api.github.com/users/davecgh","html_url":"https://github.com/davecgh","followers_url":"https://api.github.com/users/davecgh/followers","following_url":"https://api.github.com/users/davecgh/following{/other_user}","gists_url":"https://api.github.com/users/davecgh/gists{/gist_id}","starred_url":"https://api.github.com/users/davecgh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davecgh/subscriptions","organizations_url":"https://api.github.com/users/davecgh/orgs","repos_url":"https://api.github.com/users/davecgh/repos","events_url":"https://api.github.com/users/davecgh/events{/privacy}","received_events_url":"https://api.github.com/users/davecgh/received_events","type":"User","site_admin":false},"created_at":"2017-10-10T16:59:36Z","updated_at":"2017-10-10T16:59:36Z","author_association":"OWNER","body":"The bit about bloom filters is not true.  There is code for bloom filters in dcrd including serving them and the ability to disable them."}}
{"actor":{"display_login":"davecgh"}}