{"action":"closed","number":1211,"pull_request":{"url":"https://api.github.com/repos/mercadopago/px-ios/pulls/1211","id":144415177,"html_url":"https://github.com/mercadopago/px-ios/pull/1211","diff_url":"https://github.com/mercadopago/px-ios/pull/1211.diff","patch_url":"https://github.com/mercadopago/px-ios/pull/1211.patch","issue_url":"https://api.github.com/repos/mercadopago/px-ios/issues/1211","number":1211,"state":"closed","locked":false,"title":"[Fix] Instructions View Controller Refactor","user":{"login":"edentorres","id":9399970,"avatar_url":"https://avatars2.githubusercontent.com/u/9399970?v=4","gravatar_id":"","url":"https://api.github.com/users/edentorres","html_url":"https://github.com/edentorres","followers_url":"https://api.github.com/users/edentorres/followers","following_url":"https://api.github.com/users/edentorres/following{/other_user}","gists_url":"https://api.github.com/users/edentorres/gists{/gist_id}","starred_url":"https://api.github.com/users/edentorres/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edentorres/subscriptions","organizations_url":"https://api.github.com/users/edentorres/orgs","repos_url":"https://api.github.com/users/edentorres/repos","events_url":"https://api.github.com/users/edentorres/events{/privacy}","received_events_url":"https://api.github.com/users/edentorres/received_events","type":"User","site_admin":false},"body":"Fix #1208 \r\n\r\n##  Cambios introducidos : \r\n- Se termina de implementar un view Model en la pantalla de intrucciones\r\n- Se corrigen algunas cosas del PR #1205\r\n- Se cambian traducciones en el boton de continuar de instrucciones\r\n\r\n### Revisión\r\n- [X] Todos los textos se encuentran localizables\r\n- [X] No se introducen warnings al proyecto\r\n- [X] Se incluyen cambios de UX ? se verificó que se vean bien tanto en iPhone SE y S6 : NA\r\n- [X] No se agregan logs / prints innecesarios\r\n- [X] No se agregan comentarios basura\r\n- [X] Correr Swiftlint\r\n\r\n### Testeo\r\n- [X] Testeado en BETA con emulador\r\n- [ ] Testeado en BETA con dispositivo\r\n- [X] Test unitarios OK\r\n- [ ] Test funcionales OK\r\n- [ ] Documentación actualizada\r\n","created_at":"2017-10-03T12:59:31Z","updated_at":"2017-10-04T14:21:19Z","closed_at":"2017-10-04T14:21:19Z","merged_at":"2017-10-04T14:21:19Z","merge_commit_sha":"1aabf1f02f3432a4b6e858e9fc3c530184eec5d3","assignee":null,"assignees":[],"requested_reviewers":[{"login":"demtej","id":16452193,"avatar_url":"https://avatars0.githubusercontent.com/u/16452193?v=4","gravatar_id":"","url":"https://api.github.com/users/demtej","html_url":"https://github.com/demtej","followers_url":"https://api.github.com/users/demtej/followers","following_url":"https://api.github.com/users/demtej/following{/other_user}","gists_url":"https://api.github.com/users/demtej/gists{/gist_id}","starred_url":"https://api.github.com/users/demtej/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/demtej/subscriptions","organizations_url":"https://api.github.com/users/demtej/orgs","repos_url":"https://api.github.com/users/demtej/repos","events_url":"https://api.github.com/users/demtej/events{/privacy}","received_events_url":"https://api.github.com/users/demtej/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/mercadopago/px-ios/pulls/1211/commits","review_comments_url":"https://api.github.com/repos/mercadopago/px-ios/pulls/1211/comments","review_comment_url":"https://api.github.com/repos/mercadopago/px-ios/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mercadopago/px-ios/issues/1211/comments","statuses_url":"https://api.github.com/repos/mercadopago/px-ios/statuses/e96bd9599e58adfce0633d99544f8de58613c379","head":{"label":"mercadopago:fix/instructions","ref":"fix/instructions","sha":"e96bd9599e58adfce0633d99544f8de58613c379","user":{"login":"mercadopago","id":900583,"avatar_url":"https://avatars3.githubusercontent.com/u/900583?v=4","gravatar_id":"","url":"https://api.github.com/users/mercadopago","html_url":"https://github.com/mercadopago","followers_url":"https://api.github.com/users/mercadopago/followers","following_url":"https://api.github.com/users/mercadopago/following{/other_user}","gists_url":"https://api.github.com/users/mercadopago/gists{/gist_id}","starred_url":"https://api.github.com/users/mercadopago/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mercadopago/subscriptions","organizations_url":"https://api.github.com/users/mercadopago/orgs","repos_url":"https://api.github.com/users/mercadopago/repos","events_url":"https://api.github.com/users/mercadopago/events{/privacy}","received_events_url":"https://api.github.com/users/mercadopago/received_events","type":"Organization","site_admin":false},"repo":{"id":49529165,"name":"px-ios","full_name":"mercadopago/px-ios","owner":{"login":"mercadopago","id":900583,"avatar_url":"https://avatars3.githubusercontent.com/u/900583?v=4","gravatar_id":"","url":"https://api.github.com/users/mercadopago","html_url":"https://github.com/mercadopago","followers_url":"https://api.github.com/users/mercadopago/followers","following_url":"https://api.github.com/users/mercadopago/following{/other_user}","gists_url":"https://api.github.com/users/mercadopago/gists{/gist_id}","starred_url":"https://api.github.com/users/mercadopago/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mercadopago/subscriptions","organizations_url":"https://api.github.com/users/mercadopago/orgs","repos_url":"https://api.github.com/users/mercadopago/repos","events_url":"https://api.github.com/users/mercadopago/events{/privacy}","received_events_url":"https://api.github.com/users/mercadopago/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mercadopago/px-ios","description":"MercadoPago SDK iOS","fork":false,"url":"https://api.github.com/repos/mercadopago/px-ios","forks_url":"https://api.github.com/repos/mercadopago/px-ios/forks","keys_url":"https://api.github.com/repos/mercadopago/px-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mercadopago/px-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mercadopago/px-ios/teams","hooks_url":"https://api.github.com/repos/mercadopago/px-ios/hooks","issue_events_url":"https://api.github.com/repos/mercadopago/px-ios/issues/events{/number}","events_url":"https://api.github.com/repos/mercadopago/px-ios/events","assignees_url":"https://api.github.com/repos/mercadopago/px-ios/assignees{/user}","branches_url":"https://api.github.com/repos/mercadopago/px-ios/branches{/branch}","tags_url":"https://api.github.com/repos/mercadopago/px-ios/tags","blobs_url":"https://api.github.com/repos/mercadopago/px-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mercadopago/px-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mercadopago/px-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/mercadopago/px-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mercadopago/px-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/mercadopago/px-ios/languages","stargazers_url":"https://api.github.com/repos/mercadopago/px-ios/stargazers","contributors_url":"https://api.github.com/repos/mercadopago/px-ios/contributors","subscribers_url":"https://api.github.com/repos/mercadopago/px-ios/subscribers","subscription_url":"https://api.github.com/repos/mercadopago/px-ios/subscription","commits_url":"https://api.github.com/repos/mercadopago/px-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/mercadopago/px-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/mercadopago/px-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/mercadopago/px-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/mercadopago/px-ios/contents/{+path}","compare_url":"https://api.github.com/repos/mercadopago/px-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mercadopago/px-ios/merges","archive_url":"https://api.github.com/repos/mercadopago/px-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mercadopago/px-ios/downloads","issues_url":"https://api.github.com/repos/mercadopago/px-ios/issues{/number}","pulls_url":"https://api.github.com/repos/mercadopago/px-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/mercadopago/px-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/mercadopago/px-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mercadopago/px-ios/labels{/name}","releases_url":"https://api.github.com/repos/mercadopago/px-ios/releases{/id}","deployments_url":"https://api.github.com/repos/mercadopago/px-ios/deployments","created_at":"2016-01-12T21:12:32Z","updated_at":"2017-08-21T13:36:36Z","pushed_at":"2017-10-04T14:21:19Z","git_url":"git://github.com/mercadopago/px-ios.git","ssh_url":"git@github.com:mercadopago/px-ios.git","clone_url":"https://github.com/mercadopago/px-ios.git","svn_url":"https://github.com/mercadopago/px-ios","homepage":"http://mercadopago.github.io/px-ios","size":324760,"stargazers_count":13,"watchers_count":13,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":14,"mirror_url":null,"open_issues_count":20,"forks":14,"open_issues":20,"watchers":13,"default_branch":"master"}},"base":{"label":"mercadopago:feature/pm_bolbradesco","ref":"feature/pm_bolbradesco","sha":"41564bb9261b4bb8d48752ef397a906a85407da1","user":{"login":"mercadopago","id":900583,"avatar_url":"https://avatars3.githubusercontent.com/u/900583?v=4","gravatar_id":"","url":"https://api.github.com/users/mercadopago","html_url":"https://github.com/mercadopago","followers_url":"https://api.github.com/users/mercadopago/followers","following_url":"https://api.github.com/users/mercadopago/following{/other_user}","gists_url":"https://api.github.com/users/mercadopago/gists{/gist_id}","starred_url":"https://api.github.com/users/mercadopago/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mercadopago/subscriptions","organizations_url":"https://api.github.com/users/mercadopago/orgs","repos_url":"https://api.github.com/users/mercadopago/repos","events_url":"https://api.github.com/users/mercadopago/events{/privacy}","received_events_url":"https://api.github.com/users/mercadopago/received_events","type":"Organization","site_admin":false},"repo":{"id":49529165,"name":"px-ios","full_name":"mercadopago/px-ios","owner":{"login":"mercadopago","id":900583,"avatar_url":"https://avatars3.githubusercontent.com/u/900583?v=4","gravatar_id":"","url":"https://api.github.com/users/mercadopago","html_url":"https://github.com/mercadopago","followers_url":"https://api.github.com/users/mercadopago/followers","following_url":"https://api.github.com/users/mercadopago/following{/other_user}","gists_url":"https://api.github.com/users/mercadopago/gists{/gist_id}","starred_url":"https://api.github.com/users/mercadopago/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mercadopago/subscriptions","organizations_url":"https://api.github.com/users/mercadopago/orgs","repos_url":"https://api.github.com/users/mercadopago/repos","events_url":"https://api.github.com/users/mercadopago/events{/privacy}","received_events_url":"https://api.github.com/users/mercadopago/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mercadopago/px-ios","description":"MercadoPago SDK iOS","fork":false,"url":"https://api.github.com/repos/mercadopago/px-ios","forks_url":"https://api.github.com/repos/mercadopago/px-ios/forks","keys_url":"https://api.github.com/repos/mercadopago/px-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mercadopago/px-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mercadopago/px-ios/teams","hooks_url":"https://api.github.com/repos/mercadopago/px-ios/hooks","issue_events_url":"https://api.github.com/repos/mercadopago/px-ios/issues/events{/number}","events_url":"https://api.github.com/repos/mercadopago/px-ios/events","assignees_url":"https://api.github.com/repos/mercadopago/px-ios/assignees{/user}","branches_url":"https://api.github.com/repos/mercadopago/px-ios/branches{/branch}","tags_url":"https://api.github.com/repos/mercadopago/px-ios/tags","blobs_url":"https://api.github.com/repos/mercadopago/px-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mercadopago/px-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mercadopago/px-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/mercadopago/px-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mercadopago/px-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/mercadopago/px-ios/languages","stargazers_url":"https://api.github.com/repos/mercadopago/px-ios/stargazers","contributors_url":"https://api.github.com/repos/mercadopago/px-ios/contributors","subscribers_url":"https://api.github.com/repos/mercadopago/px-ios/subscribers","subscription_url":"https://api.github.com/repos/mercadopago/px-ios/subscription","commits_url":"https://api.github.com/repos/mercadopago/px-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/mercadopago/px-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/mercadopago/px-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/mercadopago/px-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/mercadopago/px-ios/contents/{+path}","compare_url":"https://api.github.com/repos/mercadopago/px-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mercadopago/px-ios/merges","archive_url":"https://api.github.com/repos/mercadopago/px-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mercadopago/px-ios/downloads","issues_url":"https://api.github.com/repos/mercadopago/px-ios/issues{/number}","pulls_url":"https://api.github.com/repos/mercadopago/px-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/mercadopago/px-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/mercadopago/px-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mercadopago/px-ios/labels{/name}","releases_url":"https://api.github.com/repos/mercadopago/px-ios/releases{/id}","deployments_url":"https://api.github.com/repos/mercadopago/px-ios/deployments","created_at":"2016-01-12T21:12:32Z","updated_at":"2017-08-21T13:36:36Z","pushed_at":"2017-10-04T14:21:19Z","git_url":"git://github.com/mercadopago/px-ios.git","ssh_url":"git@github.com:mercadopago/px-ios.git","clone_url":"https://github.com/mercadopago/px-ios.git","svn_url":"https://github.com/mercadopago/px-ios","homepage":"http://mercadopago.github.io/px-ios","size":324760,"stargazers_count":13,"watchers_count":13,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":14,"mirror_url":null,"open_issues_count":20,"forks":14,"open_issues":20,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mercadopago/px-ios/pulls/1211"},"html":{"href":"https://github.com/mercadopago/px-ios/pull/1211"},"issue":{"href":"https://api.github.com/repos/mercadopago/px-ios/issues/1211"},"comments":{"href":"https://api.github.com/repos/mercadopago/px-ios/issues/1211/comments"},"review_comments":{"href":"https://api.github.com/repos/mercadopago/px-ios/pulls/1211/comments"},"review_comment":{"href":"https://api.github.com/repos/mercadopago/px-ios/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mercadopago/px-ios/pulls/1211/commits"},"statuses":{"href":"https://api.github.com/repos/mercadopago/px-ios/statuses/e96bd9599e58adfce0633d99544f8de58613c379"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"augustocollerone","id":23138661,"avatar_url":"https://avatars3.githubusercontent.com/u/23138661?v=4","gravatar_id":"","url":"https://api.github.com/users/augustocollerone","html_url":"https://github.com/augustocollerone","followers_url":"https://api.github.com/users/augustocollerone/followers","following_url":"https://api.github.com/users/augustocollerone/following{/other_user}","gists_url":"https://api.github.com/users/augustocollerone/gists{/gist_id}","starred_url":"https://api.github.com/users/augustocollerone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/augustocollerone/subscriptions","organizations_url":"https://api.github.com/users/augustocollerone/orgs","repos_url":"https://api.github.com/users/augustocollerone/repos","events_url":"https://api.github.com/users/augustocollerone/events{/privacy}","received_events_url":"https://api.github.com/users/augustocollerone/received_events","type":"User","site_admin":false},"comments":0,"review_comments":1,"maintainer_can_modify":false,"commits":9,"additions":3612,"deletions":10301,"changed_files":48}}
{"actor":{"display_login":"augustocollerone"}}