{"action":"created","issue":{"url":"https://api.github.com/repos/tipsi/tipsi-stripe/issues/115","repository_url":"https://api.github.com/repos/tipsi/tipsi-stripe","labels_url":"https://api.github.com/repos/tipsi/tipsi-stripe/issues/115/labels{/name}","comments_url":"https://api.github.com/repos/tipsi/tipsi-stripe/issues/115/comments","events_url":"https://api.github.com/repos/tipsi/tipsi-stripe/issues/115/events","html_url":"https://github.com/tipsi/tipsi-stripe/pull/115","id":256780938,"number":115,"title":"Feature/bitcoin alipay sources","user":{"login":"santiagofm","id":6749415,"avatar_url":"https://avatars0.githubusercontent.com/u/6749415?v=4","gravatar_id":"","url":"https://api.github.com/users/santiagofm","html_url":"https://github.com/santiagofm","followers_url":"https://api.github.com/users/santiagofm/followers","following_url":"https://api.github.com/users/santiagofm/following{/other_user}","gists_url":"https://api.github.com/users/santiagofm/gists{/gist_id}","starred_url":"https://api.github.com/users/santiagofm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/santiagofm/subscriptions","organizations_url":"https://api.github.com/users/santiagofm/orgs","repos_url":"https://api.github.com/users/santiagofm/repos","events_url":"https://api.github.com/users/santiagofm/events{/privacy}","received_events_url":"https://api.github.com/users/santiagofm/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2017-09-11T17:23:25Z","updated_at":"2017-10-09T14:53:16Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/tipsi/tipsi-stripe/pulls/115","html_url":"https://github.com/tipsi/tipsi-stripe/pull/115","diff_url":"https://github.com/tipsi/tipsi-stripe/pull/115.diff","patch_url":"https://github.com/tipsi/tipsi-stripe/pull/115.patch"},"body":"- Updates Stripe to latest release\r\n- Adds support for Bitcoin & AliPay payments in both platform Android & iOS"},"comment":{"url":"https://api.github.com/repos/tipsi/tipsi-stripe/issues/comments/335182471","html_url":"https://github.com/tipsi/tipsi-stripe/pull/115#issuecomment-335182471","issue_url":"https://api.github.com/repos/tipsi/tipsi-stripe/issues/115","id":335182471,"user":{"login":"isnifer","id":1788245,"avatar_url":"https://avatars0.githubusercontent.com/u/1788245?v=4","gravatar_id":"","url":"https://api.github.com/users/isnifer","html_url":"https://github.com/isnifer","followers_url":"https://api.github.com/users/isnifer/followers","following_url":"https://api.github.com/users/isnifer/following{/other_user}","gists_url":"https://api.github.com/users/isnifer/gists{/gist_id}","starred_url":"https://api.github.com/users/isnifer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isnifer/subscriptions","organizations_url":"https://api.github.com/users/isnifer/orgs","repos_url":"https://api.github.com/users/isnifer/repos","events_url":"https://api.github.com/users/isnifer/events{/privacy}","received_events_url":"https://api.github.com/users/isnifer/received_events","type":"User","site_admin":false},"created_at":"2017-10-09T14:53:16Z","updated_at":"2017-10-09T14:53:16Z","author_association":"MEMBER","body":"So, @santiagofm @m-revetria I looked into your PR today and I want to say:\r\n1. We don't need separate methods for bitcoin or Alipay, but we need common method `createSourceWithParams` like in https://github.com/tipsi/tipsi-stripe/pull/113. @flavordaaave did a good example in iOS how it looks like.\r\n2. We have already the tests in his branch and we're planning to merge it into master today or tomorrow (depends on a free time of @cybergrind).\r\n3. So, what you can do before rebase from `master`? Implement one method  `createSourceWithParams` instead of two for bitcoins and Alipay. Remove all iOS code, cause we have it already.\r\n4. After rebase from `master` we can check e2e-tests for android too.\r\n"}}
{"actor":{"display_login":"isnifer"}}