{"action":"created","issue":{"url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/8562","repository_url":"https://api.github.com/repos/PrestaShop/PrestaShop","labels_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/8562/labels{/name}","comments_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/8562/comments","events_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/8562/events","html_url":"https://github.com/PrestaShop/PrestaShop/pull/8562","id":277684876,"number":8562,"title":"Fix alert boxes using bulleted lists","user":{"login":"eternoendless","id":1009343,"avatar_url":"https://avatars3.githubusercontent.com/u/1009343?v=4","gravatar_id":"","url":"https://api.github.com/users/eternoendless","html_url":"https://github.com/eternoendless","followers_url":"https://api.github.com/users/eternoendless/followers","following_url":"https://api.github.com/users/eternoendless/following{/other_user}","gists_url":"https://api.github.com/users/eternoendless/gists{/gist_id}","starred_url":"https://api.github.com/users/eternoendless/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eternoendless/subscriptions","organizations_url":"https://api.github.com/users/eternoendless/orgs","repos_url":"https://api.github.com/users/eternoendless/repos","events_url":"https://api.github.com/users/eternoendless/events{/privacy}","received_events_url":"https://api.github.com/users/eternoendless/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/PrestaShop/PrestaShop/milestones/29","html_url":"https://github.com/PrestaShop/PrestaShop/milestone/29","labels_url":"https://api.github.com/repos/PrestaShop/PrestaShop/milestones/29/labels","id":2600773,"number":29,"title":"1.7.3.0","description":null,"creator":{"login":"vincentbz","id":7567060,"avatar_url":"https://avatars2.githubusercontent.com/u/7567060?v=4","gravatar_id":"","url":"https://api.github.com/users/vincentbz","html_url":"https://github.com/vincentbz","followers_url":"https://api.github.com/users/vincentbz/followers","following_url":"https://api.github.com/users/vincentbz/following{/other_user}","gists_url":"https://api.github.com/users/vincentbz/gists{/gist_id}","starred_url":"https://api.github.com/users/vincentbz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vincentbz/subscriptions","organizations_url":"https://api.github.com/users/vincentbz/orgs","repos_url":"https://api.github.com/users/vincentbz/repos","events_url":"https://api.github.com/users/vincentbz/events{/privacy}","received_events_url":"https://api.github.com/users/vincentbz/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":179,"state":"open","created_at":"2017-06-23T13:40:47Z","updated_at":"2017-11-29T10:28:37Z","due_on":null,"closed_at":null},"comments":10,"created_at":"2017-11-29T09:33:45Z","updated_at":"2017-11-29T13:08:52Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/8562","html_url":"https://github.com/PrestaShop/PrestaShop/pull/8562","diff_url":"https://github.com/PrestaShop/PrestaShop/pull/8562.diff","patch_url":"https://github.com/PrestaShop/PrestaShop/pull/8562.patch"},"body":"| Questions     | Answers\r\n| ------------- | -------------------------------------------------------\r\n| Branch?       | 1.7.3.x\r\n| Description?  | Alert boxes were using bulleted lists for content, which produced a visual glitch in symfony pages on Firefox where half a bullet point was visible.<br>This PR replaces bulleted lists by paragraphs on symfony pages.\r\n| Type?         | bug fix\r\n| Category?     | BO\r\n| BC breaks?    | no\r\n| Deprecations? | no\r\n| Fixed ticket? | http://forge.prestashop.com/browse/BOOM-4327\r\n| How to test?  | Look at alert boxes in symfony pages using Firefox\r\n\r\nYou can check out what alert boxes are supposed to look like here: https://cdn.rawgit.com/PrestaShop/prestashop-ui-kit/master/index.html#alerts\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/prestashop/prestashop/8562)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/comments/347855301","html_url":"https://github.com/PrestaShop/PrestaShop/pull/8562#issuecomment-347855301","issue_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/8562","id":347855301,"user":{"login":"LittleBigDev","id":6631597,"avatar_url":"https://avatars3.githubusercontent.com/u/6631597?v=4","gravatar_id":"","url":"https://api.github.com/users/LittleBigDev","html_url":"https://github.com/LittleBigDev","followers_url":"https://api.github.com/users/LittleBigDev/followers","following_url":"https://api.github.com/users/LittleBigDev/following{/other_user}","gists_url":"https://api.github.com/users/LittleBigDev/gists{/gist_id}","starred_url":"https://api.github.com/users/LittleBigDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LittleBigDev/subscriptions","organizations_url":"https://api.github.com/users/LittleBigDev/orgs","repos_url":"https://api.github.com/users/LittleBigDev/repos","events_url":"https://api.github.com/users/LittleBigDev/events{/privacy}","received_events_url":"https://api.github.com/users/LittleBigDev/received_events","type":"User","site_admin":false},"created_at":"2017-11-29T13:08:52Z","updated_at":"2017-11-29T13:08:52Z","author_association":"CONTRIBUTOR","body":"\n\n\n\nReviewed 7 of 7 files at r3.\nReview status: all files reviewed at latest revision, 3 unresolved discussions.\n\n---\n\n*[src/PrestaShopBundle/Resources/views/Admin/TwigTemplateForm/bootstrap_3_layout.html.twig, line 397 at r3](https://reviewable.io:443/reviews/prestashop/prestashop/8562#-L-6svE1uni-rYGaQDF2:-L-6svE1uni-rYGaQDF3:bfaadk) ([raw file](https://github.com/prestashop/prestashop/blob/dd260c52c7d6fff4a28ca8589b073c9c45f95722/src/PrestaShopBundle/Resources/views/Admin/TwigTemplateForm/bootstrap_3_layout.html.twig#L397)):*\n> ```Twig\n>         {%- else -%}\n>             <div class=\"alert-text\">\n>             {%- for error in errors -%}\n> ```\n\nNo need to loop through it, as there is only 1 element (or maybe the `for` is still more elegant ?)\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/prestashop/prestashop/8562)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"LittleBigDev"}}