{"action":"created","comment":{"url":"https://api.github.com/repos/aparkins/verbose-carnival/pulls/comments/139312669","pull_request_review_id":63229092,"id":139312669,"diff_hunk":"@@ -169,6 +193,38 @@ def build_pydip_retreat_command(retreat_map, player, unit_map, command_data):\n     raise ValueError\n \n \n+def build_pydip_adjustment_command(ownership_map, player, unit_map, command_data):\n+    \"\"\"\n+    ownership_map -- PyDip OwnershipMap representing current owned territories\n+    player -- PyDip Player issuing the command\n+    unit_map -- Territory Name to PyDip Unit object in that territory\n+    command_data -- {\n+        type -- Type of command being issued (dictates other parameters)","path":"dip_server/dip_platform/logic/game/resolution/transform_logic.py","position":202,"original_position":74,"commit_id":"6087f812102ffd3d897682593bc22cc0dd2c5faf","original_commit_id":"6087f812102ffd3d897682593bc22cc0dd2c5faf","user":{"login":"aparkins","id":5503524,"avatar_url":"https://avatars2.githubusercontent.com/u/5503524?v=4","gravatar_id":"","url":"https://api.github.com/users/aparkins","html_url":"https://github.com/aparkins","followers_url":"https://api.github.com/users/aparkins/followers","following_url":"https://api.github.com/users/aparkins/following{/other_user}","gists_url":"https://api.github.com/users/aparkins/gists{/gist_id}","starred_url":"https://api.github.com/users/aparkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aparkins/subscriptions","organizations_url":"https://api.github.com/users/aparkins/orgs","repos_url":"https://api.github.com/users/aparkins/repos","events_url":"https://api.github.com/users/aparkins/events{/privacy}","received_events_url":"https://api.github.com/users/aparkins/received_events","type":"User","site_admin":false},"body":"Ah, yeah should be updated.\r\n\r\n`type` is still in there (that's the type of command), but `unitType` is necessary for the create command to know which kind of unit is being created. Thanks for catching that.","created_at":"2017-09-17T14:58:19Z","updated_at":"2017-09-17T14:58:20Z","html_url":"https://github.com/aparkins/verbose-carnival/pull/3#discussion_r139312669","pull_request_url":"https://api.github.com/repos/aparkins/verbose-carnival/pulls/3","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/aparkins/verbose-carnival/pulls/comments/139312669"},"html":{"href":"https://github.com/aparkins/verbose-carnival/pull/3#discussion_r139312669"},"pull_request":{"href":"https://api.github.com/repos/aparkins/verbose-carnival/pulls/3"}},"in_reply_to_id":139311456},"pull_request":{"url":"https://api.github.com/repos/aparkins/verbose-carnival/pulls/3","id":141476044,"html_url":"https://github.com/aparkins/verbose-carnival/pull/3","diff_url":"https://github.com/aparkins/verbose-carnival/pull/3.diff","patch_url":"https://github.com/aparkins/verbose-carnival/pull/3.patch","issue_url":"https://api.github.com/repos/aparkins/verbose-carnival/issues/3","number":3,"state":"open","locked":false,"title":"Finish adjudication endpoint","user":{"login":"aparkins","id":5503524,"avatar_url":"https://avatars2.githubusercontent.com/u/5503524?v=4","gravatar_id":"","url":"https://api.github.com/users/aparkins","html_url":"https://github.com/aparkins","followers_url":"https://api.github.com/users/aparkins/followers","following_url":"https://api.github.com/users/aparkins/following{/other_user}","gists_url":"https://api.github.com/users/aparkins/gists{/gist_id}","starred_url":"https://api.github.com/users/aparkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aparkins/subscriptions","organizations_url":"https://api.github.com/users/aparkins/orgs","repos_url":"https://api.github.com/users/aparkins/repos","events_url":"https://api.github.com/users/aparkins/events{/privacy}","received_events_url":"https://api.github.com/users/aparkins/received_events","type":"User","site_admin":false},"body":"- Much refactoring / cleanup for existing adjudication logic to make it easier to add two other adjudication types\r\n\r\n- Logic for Retreat adjudication\r\n\r\n- Logic for Adjustment adjudication\r\n\r\n- Updating pydip dependency, because there were a few bugs discovered while working on finishing this up","created_at":"2017-09-17T07:23:17Z","updated_at":"2017-09-17T14:58:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"50d252ea5c1483c2153d87f31f730e3c809ffb4b","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/aparkins/verbose-carnival/pulls/3/commits","review_comments_url":"https://api.github.com/repos/aparkins/verbose-carnival/pulls/3/comments","review_comment_url":"https://api.github.com/repos/aparkins/verbose-carnival/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aparkins/verbose-carnival/issues/3/comments","statuses_url":"https://api.github.com/repos/aparkins/verbose-carnival/statuses/6087f812102ffd3d897682593bc22cc0dd2c5faf","head":{"label":"aparkins:cleanup_adjudication","ref":"cleanup_adjudication","sha":"6087f812102ffd3d897682593bc22cc0dd2c5faf","user":{"login":"aparkins","id":5503524,"avatar_url":"https://avatars2.githubusercontent.com/u/5503524?v=4","gravatar_id":"","url":"https://api.github.com/users/aparkins","html_url":"https://github.com/aparkins","followers_url":"https://api.github.com/users/aparkins/followers","following_url":"https://api.github.com/users/aparkins/following{/other_user}","gists_url":"https://api.github.com/users/aparkins/gists{/gist_id}","starred_url":"https://api.github.com/users/aparkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aparkins/subscriptions","organizations_url":"https://api.github.com/users/aparkins/orgs","repos_url":"https://api.github.com/users/aparkins/repos","events_url":"https://api.github.com/users/aparkins/events{/privacy}","received_events_url":"https://api.github.com/users/aparkins/received_events","type":"User","site_admin":false},"repo":{"id":77243169,"name":"verbose-carnival","full_name":"aparkins/verbose-carnival","owner":{"login":"aparkins","id":5503524,"avatar_url":"https://avatars2.githubusercontent.com/u/5503524?v=4","gravatar_id":"","url":"https://api.github.com/users/aparkins","html_url":"https://github.com/aparkins","followers_url":"https://api.github.com/users/aparkins/followers","following_url":"https://api.github.com/users/aparkins/following{/other_user}","gists_url":"https://api.github.com/users/aparkins/gists{/gist_id}","starred_url":"https://api.github.com/users/aparkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aparkins/subscriptions","organizations_url":"https://api.github.com/users/aparkins/orgs","repos_url":"https://api.github.com/users/aparkins/repos","events_url":"https://api.github.com/users/aparkins/events{/privacy}","received_events_url":"https://api.github.com/users/aparkins/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aparkins/verbose-carnival","description":null,"fork":false,"url":"https://api.github.com/repos/aparkins/verbose-carnival","forks_url":"https://api.github.com/repos/aparkins/verbose-carnival/forks","keys_url":"https://api.github.com/repos/aparkins/verbose-carnival/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aparkins/verbose-carnival/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aparkins/verbose-carnival/teams","hooks_url":"https://api.github.com/repos/aparkins/verbose-carnival/hooks","issue_events_url":"https://api.github.com/repos/aparkins/verbose-carnival/issues/events{/number}","events_url":"https://api.github.com/repos/aparkins/verbose-carnival/events","assignees_url":"https://api.github.com/repos/aparkins/verbose-carnival/assignees{/user}","branches_url":"https://api.github.com/repos/aparkins/verbose-carnival/branches{/branch}","tags_url":"https://api.github.com/repos/aparkins/verbose-carnival/tags","blobs_url":"https://api.github.com/repos/aparkins/verbose-carnival/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aparkins/verbose-carnival/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aparkins/verbose-carnival/git/refs{/sha}","trees_url":"https://api.github.com/repos/aparkins/verbose-carnival/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aparkins/verbose-carnival/statuses/{sha}","languages_url":"https://api.github.com/repos/aparkins/verbose-carnival/languages","stargazers_url":"https://api.github.com/repos/aparkins/verbose-carnival/stargazers","contributors_url":"https://api.github.com/repos/aparkins/verbose-carnival/contributors","subscribers_url":"https://api.github.com/repos/aparkins/verbose-carnival/subscribers","subscription_url":"https://api.github.com/repos/aparkins/verbose-carnival/subscription","commits_url":"https://api.github.com/repos/aparkins/verbose-carnival/commits{/sha}","git_commits_url":"https://api.github.com/repos/aparkins/verbose-carnival/git/commits{/sha}","comments_url":"https://api.github.com/repos/aparkins/verbose-carnival/comments{/number}","issue_comment_url":"https://api.github.com/repos/aparkins/verbose-carnival/issues/comments{/number}","contents_url":"https://api.github.com/repos/aparkins/verbose-carnival/contents/{+path}","compare_url":"https://api.github.com/repos/aparkins/verbose-carnival/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aparkins/verbose-carnival/merges","archive_url":"https://api.github.com/repos/aparkins/verbose-carnival/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aparkins/verbose-carnival/downloads","issues_url":"https://api.github.com/repos/aparkins/verbose-carnival/issues{/number}","pulls_url":"https://api.github.com/repos/aparkins/verbose-carnival/pulls{/number}","milestones_url":"https://api.github.com/repos/aparkins/verbose-carnival/milestones{/number}","notifications_url":"https://api.github.com/repos/aparkins/verbose-carnival/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aparkins/verbose-carnival/labels{/name}","releases_url":"https://api.github.com/repos/aparkins/verbose-carnival/releases{/id}","deployments_url":"https://api.github.com/repos/aparkins/verbose-carnival/deployments","created_at":"2016-12-23T18:17:00Z","updated_at":"2016-12-25T23:07:00Z","pushed_at":"2017-09-17T07:23:17Z","git_url":"git://github.com/aparkins/verbose-carnival.git","ssh_url":"git@github.com:aparkins/verbose-carnival.git","clone_url":"https://github.com/aparkins/verbose-carnival.git","svn_url":"https://github.com/aparkins/verbose-carnival","homepage":null,"size":258,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"aparkins:master","ref":"master","sha":"a555c902745d7dcf5d939dea9bfddf46abfdc0c6","user":{"login":"aparkins","id":5503524,"avatar_url":"https://avatars2.githubusercontent.com/u/5503524?v=4","gravatar_id":"","url":"https://api.github.com/users/aparkins","html_url":"https://github.com/aparkins","followers_url":"https://api.github.com/users/aparkins/followers","following_url":"https://api.github.com/users/aparkins/following{/other_user}","gists_url":"https://api.github.com/users/aparkins/gists{/gist_id}","starred_url":"https://api.github.com/users/aparkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aparkins/subscriptions","organizations_url":"https://api.github.com/users/aparkins/orgs","repos_url":"https://api.github.com/users/aparkins/repos","events_url":"https://api.github.com/users/aparkins/events{/privacy}","received_events_url":"https://api.github.com/users/aparkins/received_events","type":"User","site_admin":false},"repo":{"id":77243169,"name":"verbose-carnival","full_name":"aparkins/verbose-carnival","owner":{"login":"aparkins","id":5503524,"avatar_url":"https://avatars2.githubusercontent.com/u/5503524?v=4","gravatar_id":"","url":"https://api.github.com/users/aparkins","html_url":"https://github.com/aparkins","followers_url":"https://api.github.com/users/aparkins/followers","following_url":"https://api.github.com/users/aparkins/following{/other_user}","gists_url":"https://api.github.com/users/aparkins/gists{/gist_id}","starred_url":"https://api.github.com/users/aparkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aparkins/subscriptions","organizations_url":"https://api.github.com/users/aparkins/orgs","repos_url":"https://api.github.com/users/aparkins/repos","events_url":"https://api.github.com/users/aparkins/events{/privacy}","received_events_url":"https://api.github.com/users/aparkins/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aparkins/verbose-carnival","description":null,"fork":false,"url":"https://api.github.com/repos/aparkins/verbose-carnival","forks_url":"https://api.github.com/repos/aparkins/verbose-carnival/forks","keys_url":"https://api.github.com/repos/aparkins/verbose-carnival/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aparkins/verbose-carnival/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aparkins/verbose-carnival/teams","hooks_url":"https://api.github.com/repos/aparkins/verbose-carnival/hooks","issue_events_url":"https://api.github.com/repos/aparkins/verbose-carnival/issues/events{/number}","events_url":"https://api.github.com/repos/aparkins/verbose-carnival/events","assignees_url":"https://api.github.com/repos/aparkins/verbose-carnival/assignees{/user}","branches_url":"https://api.github.com/repos/aparkins/verbose-carnival/branches{/branch}","tags_url":"https://api.github.com/repos/aparkins/verbose-carnival/tags","blobs_url":"https://api.github.com/repos/aparkins/verbose-carnival/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aparkins/verbose-carnival/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aparkins/verbose-carnival/git/refs{/sha}","trees_url":"https://api.github.com/repos/aparkins/verbose-carnival/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aparkins/verbose-carnival/statuses/{sha}","languages_url":"https://api.github.com/repos/aparkins/verbose-carnival/languages","stargazers_url":"https://api.github.com/repos/aparkins/verbose-carnival/stargazers","contributors_url":"https://api.github.com/repos/aparkins/verbose-carnival/contributors","subscribers_url":"https://api.github.com/repos/aparkins/verbose-carnival/subscribers","subscription_url":"https://api.github.com/repos/aparkins/verbose-carnival/subscription","commits_url":"https://api.github.com/repos/aparkins/verbose-carnival/commits{/sha}","git_commits_url":"https://api.github.com/repos/aparkins/verbose-carnival/git/commits{/sha}","comments_url":"https://api.github.com/repos/aparkins/verbose-carnival/comments{/number}","issue_comment_url":"https://api.github.com/repos/aparkins/verbose-carnival/issues/comments{/number}","contents_url":"https://api.github.com/repos/aparkins/verbose-carnival/contents/{+path}","compare_url":"https://api.github.com/repos/aparkins/verbose-carnival/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aparkins/verbose-carnival/merges","archive_url":"https://api.github.com/repos/aparkins/verbose-carnival/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aparkins/verbose-carnival/downloads","issues_url":"https://api.github.com/repos/aparkins/verbose-carnival/issues{/number}","pulls_url":"https://api.github.com/repos/aparkins/verbose-carnival/pulls{/number}","milestones_url":"https://api.github.com/repos/aparkins/verbose-carnival/milestones{/number}","notifications_url":"https://api.github.com/repos/aparkins/verbose-carnival/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aparkins/verbose-carnival/labels{/name}","releases_url":"https://api.github.com/repos/aparkins/verbose-carnival/releases{/id}","deployments_url":"https://api.github.com/repos/aparkins/verbose-carnival/deployments","created_at":"2016-12-23T18:17:00Z","updated_at":"2016-12-25T23:07:00Z","pushed_at":"2017-09-17T07:23:17Z","git_url":"git://github.com/aparkins/verbose-carnival.git","ssh_url":"git@github.com:aparkins/verbose-carnival.git","clone_url":"https://github.com/aparkins/verbose-carnival.git","svn_url":"https://github.com/aparkins/verbose-carnival","homepage":null,"size":258,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aparkins/verbose-carnival/pulls/3"},"html":{"href":"https://github.com/aparkins/verbose-carnival/pull/3"},"issue":{"href":"https://api.github.com/repos/aparkins/verbose-carnival/issues/3"},"comments":{"href":"https://api.github.com/repos/aparkins/verbose-carnival/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/aparkins/verbose-carnival/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/aparkins/verbose-carnival/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aparkins/verbose-carnival/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/aparkins/verbose-carnival/statuses/6087f812102ffd3d897682593bc22cc0dd2c5faf"}},"author_association":"OWNER"}}
{"actor":{"display_login":"aparkins"}}