{"action":"created","issue":{"url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/10055","repository_url":"https://api.github.com/repos/mapbox/mapbox-gl-native","labels_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/10055/labels{/name}","comments_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/10055/comments","events_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/10055/events","html_url":"https://github.com/mapbox/mapbox-gl-native/pull/10055","id":260242694,"number":10055,"title":"[ios] Various Xcode 9 fixes","user":{"login":"frederoni","id":764476,"avatar_url":"https://avatars1.githubusercontent.com/u/764476?v=4","gravatar_id":"","url":"https://api.github.com/users/frederoni","html_url":"https://github.com/frederoni","followers_url":"https://api.github.com/users/frederoni/followers","following_url":"https://api.github.com/users/frederoni/following{/other_user}","gists_url":"https://api.github.com/users/frederoni/gists{/gist_id}","starred_url":"https://api.github.com/users/frederoni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frederoni/subscriptions","organizations_url":"https://api.github.com/users/frederoni/orgs","repos_url":"https://api.github.com/users/frederoni/repos","events_url":"https://api.github.com/users/frederoni/events{/privacy}","received_events_url":"https://api.github.com/users/frederoni/received_events","type":"User","site_admin":false},"labels":[{"id":94203800,"url":"https://api.github.com/repos/mapbox/mapbox-gl-native/labels/build","name":"build","color":"0052cc","default":false},{"id":92400707,"url":"https://api.github.com/repos/mapbox/mapbox-gl-native/labels/iOS","name":"iOS","color":"000000","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-09-25T11:30:24Z","updated_at":"2017-09-26T14:38:21Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/mapbox/mapbox-gl-native/pulls/10055","html_url":"https://github.com/mapbox/mapbox-gl-native/pull/10055","diff_url":"https://github.com/mapbox/mapbox-gl-native/pull/10055.diff","patch_url":"https://github.com/mapbox/mapbox-gl-native/pull/10055.patch"},"body":"Fixes compilation for Xcode 9\r\n\r\n- Replaced deprecated method\r\n- Obj-C method description name is optional in Swift as of Xcode 9.\r\n- Stricter indirect values (Color.getRed:green:blue)\r\n - [x] Fix backwards compatibility\r\n\r\n@kkaefer @boundsj 👀 "},"comment":{"url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/comments/332219865","html_url":"https://github.com/mapbox/mapbox-gl-native/pull/10055#issuecomment-332219865","issue_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/10055","id":332219865,"user":{"login":"friedbunny","id":1198851,"avatar_url":"https://avatars3.githubusercontent.com/u/1198851?v=4","gravatar_id":"","url":"https://api.github.com/users/friedbunny","html_url":"https://github.com/friedbunny","followers_url":"https://api.github.com/users/friedbunny/followers","following_url":"https://api.github.com/users/friedbunny/following{/other_user}","gists_url":"https://api.github.com/users/friedbunny/gists{/gist_id}","starred_url":"https://api.github.com/users/friedbunny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/friedbunny/subscriptions","organizations_url":"https://api.github.com/users/friedbunny/orgs","repos_url":"https://api.github.com/users/friedbunny/repos","events_url":"https://api.github.com/users/friedbunny/events{/privacy}","received_events_url":"https://api.github.com/users/friedbunny/received_events","type":"User","site_admin":false},"created_at":"2017-09-26T14:38:21Z","updated_at":"2017-09-26T14:38:21Z","author_association":"MEMBER","body":"There are still a couple failures locally for me under Xcode 9:\r\n\r\n```\r\nTest Case '-[MGLStyleValueTests testFunctionsWithDataDrivenProperties]' started.\r\n/mapbox-gl-native/platform/darwin/test/MGLStyleValueTests.swift:270: error: -[MGLStyleValueTests testFunctionsWithDataDrivenProperties] : XCTAssertEqual failed: (\"Optional(<MGLCompositeStyleFunction: 0x7ffbd9ddd2b0,             interpolationMode = 2,             stops = {\r\n    0 =     {\r\n        green = 5;\r\n    };\r\n    10 =     {\r\n        green = 5;\r\n    };\r\n    20 =     {\r\n        green = 20;\r\n    };\r\n    15 =     {\r\n        green = 20;\r\n    };\r\n},             attributeName = color,             defaultValue = 2,             interpolationBase = 1.000000>)\") is not equal to (\"Optional(<MGLCompositeStyleFunction: 0x7ffbd9dd4cf0,             interpolationMode = 2,             stops = {\r\n    20 = (null);\r\n    0 =     {\r\n        green = 5;\r\n    };\r\n    10 = (null);\r\n    15 = (null);\r\n},             attributeName = color,             defaultValue = 2,             interpolationBase = 1.000000>)\") - \r\n```\r\n\r\n> XCTAssertEqual failed: (\"Optional(<MGLCompositeStyleFunction: 0x7ffbd9ddd2b0,             interpolationMode = 2,             stops = {\r\nhttps://github.com/mapbox/mapbox-gl-native/blob/4fcdb391a82d41985b32bfa50c34c744af888be4/platform/darwin/test/MGLStyleValueTests.swift#L270\r\n\r\n_______\r\n\r\n```\r\n*** Assertion failure in NSObject *MGLStyleValueTransformer<float, NSNumber *, float, NSNumber *>::toRawStyleSpecValue(MGLStyleFunction<ObjCType> *__strong) [MBGLType = float, ObjCType = NSNumber *, MBGLElement = float, ObjCEnum = NSNumber *]_block_invoke(), /mapbox-gl-native/platform/darwin/src/MGLStyleValue_Private.h:289\r\n/mapbox-gl-native/platform/darwin/test/MGLStyleValueTests.swift:284: error: -[MGLStyleValueTests testFunctionsWithDataDrivenProperties] : failed: caught \"NSInternalInconsistencyException\", \"Stop outputs should be MGLConstantStyleValues”\r\n```\r\n\r\nhttps://github.com/mapbox/mapbox-gl-native/blob/4fcdb391a82d41985b32bfa50c34c744af888be4/platform/darwin/test/MGLStyleValueTests.swift#L284"}}
{"actor":{"display_login":"friedbunny"}}