{"action":"created","issue":{"url":"https://api.github.com/repos/buildbot/buildbot/issues/3095","repository_url":"https://api.github.com/repos/buildbot/buildbot","labels_url":"https://api.github.com/repos/buildbot/buildbot/issues/3095/labels{/name}","comments_url":"https://api.github.com/repos/buildbot/buildbot/issues/3095/comments","events_url":"https://api.github.com/repos/buildbot/buildbot/issues/3095/events","html_url":"https://github.com/buildbot/buildbot/pull/3095","id":218984675,"number":3095,"title":"fixed pattern-based authz check; fixed case when defaultDeny=False gives access if access should not be given","user":{"login":"MikeAlexeev","id":13168423,"avatar_url":"https://avatars0.githubusercontent.com/u/13168423?v=3","gravatar_id":"","url":"https://api.github.com/users/MikeAlexeev","html_url":"https://github.com/MikeAlexeev","followers_url":"https://api.github.com/users/MikeAlexeev/followers","following_url":"https://api.github.com/users/MikeAlexeev/following{/other_user}","gists_url":"https://api.github.com/users/MikeAlexeev/gists{/gist_id}","starred_url":"https://api.github.com/users/MikeAlexeev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikeAlexeev/subscriptions","organizations_url":"https://api.github.com/users/MikeAlexeev/orgs","repos_url":"https://api.github.com/users/MikeAlexeev/repos","events_url":"https://api.github.com/users/MikeAlexeev/events{/privacy}","received_events_url":"https://api.github.com/users/MikeAlexeev/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-04-03T16:11:03Z","updated_at":"2017-04-03T16:11:04Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/buildbot/buildbot/pulls/3095","html_url":"https://github.com/buildbot/buildbot/pull/3095","diff_url":"https://github.com/buildbot/buildbot/pull/3095.diff","patch_url":"https://github.com/buildbot/buildbot/pull/3095.patch"},"body":"Hello.\r\n\r\nIt seems that I have found couple of bugs in authz.\r\nFirst, pattern-based roles checking didn't work as described in doc.\r\nThere was only simple check if rule's role in user's list of roles.\r\n\r\nSecond, authz check finished successfully if role had defaultDeny=False.\r\nFor example in tests ( buildbot.test.unit.test_www_authz ) all checks returned success.\r\nBecause first role to compare was\r\nAnyEndpointMatcher(role=\"admins\", defaultDeny=False)\r\nSo if user has not \"admins\" in his roles this check was successful too.\r\n\r\nPlease correct me if I'm wrong."},"comment":{"url":"https://api.github.com/repos/buildbot/buildbot/issues/comments/291191491","html_url":"https://github.com/buildbot/buildbot/pull/3095#issuecomment-291191491","issue_url":"https://api.github.com/repos/buildbot/buildbot/issues/3095","id":291191491,"user":{"login":"mention-bot","id":15710697,"avatar_url":"https://avatars2.githubusercontent.com/u/15710697?v=3","gravatar_id":"","url":"https://api.github.com/users/mention-bot","html_url":"https://github.com/mention-bot","followers_url":"https://api.github.com/users/mention-bot/followers","following_url":"https://api.github.com/users/mention-bot/following{/other_user}","gists_url":"https://api.github.com/users/mention-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/mention-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mention-bot/subscriptions","organizations_url":"https://api.github.com/users/mention-bot/orgs","repos_url":"https://api.github.com/users/mention-bot/repos","events_url":"https://api.github.com/users/mention-bot/events{/privacy}","received_events_url":"https://api.github.com/users/mention-bot/received_events","type":"User","site_admin":false},"created_at":"2017-04-03T16:11:04Z","updated_at":"2017-04-03T16:11:04Z","body":"@MikeAlexeev, thanks for your PR! By analyzing the history of the files in this pull request, we identified @tardyp, @sa2ajj and @rodrigc to be potential reviewers."}}
{"actor":{"display_login":"mention-bot"}}