{"action":"created","comment":{"url":"https://api.github.com/repos/Wikia/app/pulls/comments/140720165","pull_request_review_id":64830949,"id":140720165,"diff_hunk":"@@ -61,18 +63,17 @@ public static function onOasisSkinAssetGroups( &$jsAssets ) {\n \t/**\n \t * Return whether we're on one of the pages where we want to show the Recirculation widgets,\n \t * specifically File pages, Article pages, and Main pages\n+\t *\n \t * @return bool\n \t */\n \tstatic public function isCorrectPageType() {\n \t\t$wg = F::app()->wg;\n \n-\t\t$showableNameSpaces = array_merge( $wg->ContentNamespaces, [ NS_FILE ] );\n+\t\t$showableNameSpaces = array_merge( $wg->ContentNamespaces, [ NS_FILE, NS_BLOG_ARTICLE ] );\n \n-\t\tif ( $wg->Title->exists() &&\n-\t\t     in_array( $wg->Title->getNamespace(), $showableNameSpaces ) &&\n-\t\t     $wg->request->getVal( 'action', 'view' ) === 'view' &&\n-\t\t     $wg->request->getVal( 'diff' ) === null &&\n-\t\t     !WikiaPageType::isCorporatePage()\n+\t\tif ( ( $wg->Title->exists() && in_array( $wg->Title->getNamespace(), $showableNameSpaces ) ) &&","path":"extensions/wikia/Recirculation/RecirculationHooks.class.php","position":37,"original_position":37,"commit_id":"90e2154052417d693f9082d88b92ff8960dfc3b5","original_commit_id":"90e2154052417d693f9082d88b92ff8960dfc3b5","user":{"login":"bkoval","id":2035428,"avatar_url":"https://avatars2.githubusercontent.com/u/2035428?v=4","gravatar_id":"","url":"https://api.github.com/users/bkoval","html_url":"https://github.com/bkoval","followers_url":"https://api.github.com/users/bkoval/followers","following_url":"https://api.github.com/users/bkoval/following{/other_user}","gists_url":"https://api.github.com/users/bkoval/gists{/gist_id}","starred_url":"https://api.github.com/users/bkoval/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bkoval/subscriptions","organizations_url":"https://api.github.com/users/bkoval/orgs","repos_url":"https://api.github.com/users/bkoval/repos","events_url":"https://api.github.com/users/bkoval/events{/privacy}","received_events_url":"https://api.github.com/users/bkoval/received_events","type":"User","site_admin":false},"body":"Agreed.\r\n\r\nFor the first variable, I'd go with isInShowableNamespace or something similar.\r\nFor the second variable, I'd consider naming it something like isPureViewAction so that we know we're targetting requests in viewing mode with no diff.","created_at":"2017-09-25T08:54:45Z","updated_at":"2017-09-25T08:56:14Z","html_url":"https://github.com/Wikia/app/pull/13807#discussion_r140720165","pull_request_url":"https://api.github.com/repos/Wikia/app/pulls/13807","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Wikia/app/pulls/comments/140720165"},"html":{"href":"https://github.com/Wikia/app/pull/13807#discussion_r140720165"},"pull_request":{"href":"https://api.github.com/repos/Wikia/app/pulls/13807"}},"in_reply_to_id":140667626},"pull_request":{"url":"https://api.github.com/repos/Wikia/app/pulls/13807","id":142564053,"html_url":"https://github.com/Wikia/app/pull/13807","diff_url":"https://github.com/Wikia/app/pull/13807.diff","patch_url":"https://github.com/Wikia/app/pull/13807.patch","issue_url":"https://api.github.com/repos/Wikia/app/issues/13807","number":13807,"state":"open","locked":false,"title":"XW-4012 | Index blog posts that are on LI Metadata service","user":{"login":"JamesHawking","id":6508830,"avatar_url":"https://avatars0.githubusercontent.com/u/6508830?v=4","gravatar_id":"","url":"https://api.github.com/users/JamesHawking","html_url":"https://github.com/JamesHawking","followers_url":"https://api.github.com/users/JamesHawking/followers","following_url":"https://api.github.com/users/JamesHawking/following{/other_user}","gists_url":"https://api.github.com/users/JamesHawking/gists{/gist_id}","starred_url":"https://api.github.com/users/JamesHawking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JamesHawking/subscriptions","organizations_url":"https://api.github.com/users/JamesHawking/orgs","repos_url":"https://api.github.com/users/JamesHawking/repos","events_url":"https://api.github.com/users/JamesHawking/events{/privacy}","received_events_url":"https://api.github.com/users/JamesHawking/received_events","type":"User","site_admin":false},"body":"Index blog posts that are on LI Metadata service, code refactor.\r\n\r\n[Ticket](https://wikia-inc.atlassian.net/browse/XW-4012)","created_at":"2017-09-22T12:10:02Z","updated_at":"2017-09-25T08:56:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"09c2afd1f3a6231fa836e24609d65ed118276317","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Wikia/app/pulls/13807/commits","review_comments_url":"https://api.github.com/repos/Wikia/app/pulls/13807/comments","review_comment_url":"https://api.github.com/repos/Wikia/app/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Wikia/app/issues/13807/comments","statuses_url":"https://api.github.com/repos/Wikia/app/statuses/90e2154052417d693f9082d88b92ff8960dfc3b5","head":{"label":"Wikia:XW-4012","ref":"XW-4012","sha":"90e2154052417d693f9082d88b92ff8960dfc3b5","user":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars3.githubusercontent.com/u/1171011?v=4","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"repo":{"id":5532313,"name":"app","full_name":"Wikia/app","owner":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars3.githubusercontent.com/u/1171011?v=4","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Wikia/app","description":"Wikia Application Code","fork":false,"url":"https://api.github.com/repos/Wikia/app","forks_url":"https://api.github.com/repos/Wikia/app/forks","keys_url":"https://api.github.com/repos/Wikia/app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wikia/app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wikia/app/teams","hooks_url":"https://api.github.com/repos/Wikia/app/hooks","issue_events_url":"https://api.github.com/repos/Wikia/app/issues/events{/number}","events_url":"https://api.github.com/repos/Wikia/app/events","assignees_url":"https://api.github.com/repos/Wikia/app/assignees{/user}","branches_url":"https://api.github.com/repos/Wikia/app/branches{/branch}","tags_url":"https://api.github.com/repos/Wikia/app/tags","blobs_url":"https://api.github.com/repos/Wikia/app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wikia/app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wikia/app/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wikia/app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wikia/app/statuses/{sha}","languages_url":"https://api.github.com/repos/Wikia/app/languages","stargazers_url":"https://api.github.com/repos/Wikia/app/stargazers","contributors_url":"https://api.github.com/repos/Wikia/app/contributors","subscribers_url":"https://api.github.com/repos/Wikia/app/subscribers","subscription_url":"https://api.github.com/repos/Wikia/app/subscription","commits_url":"https://api.github.com/repos/Wikia/app/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wikia/app/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wikia/app/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wikia/app/issues/comments{/number}","contents_url":"https://api.github.com/repos/Wikia/app/contents/{+path}","compare_url":"https://api.github.com/repos/Wikia/app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wikia/app/merges","archive_url":"https://api.github.com/repos/Wikia/app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wikia/app/downloads","issues_url":"https://api.github.com/repos/Wikia/app/issues{/number}","pulls_url":"https://api.github.com/repos/Wikia/app/pulls{/number}","milestones_url":"https://api.github.com/repos/Wikia/app/milestones{/number}","notifications_url":"https://api.github.com/repos/Wikia/app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wikia/app/labels{/name}","releases_url":"https://api.github.com/repos/Wikia/app/releases{/id}","deployments_url":"https://api.github.com/repos/Wikia/app/deployments","created_at":"2012-08-23T20:55:58Z","updated_at":"2017-09-21T18:39:35Z","pushed_at":"2017-09-25T08:49:13Z","git_url":"git://github.com/Wikia/app.git","ssh_url":"git@github.com:Wikia/app.git","clone_url":"https://github.com/Wikia/app.git","svn_url":"https://github.com/Wikia/app","homepage":"http://dev.wikia.com","size":784632,"stargazers_count":125,"watchers_count":125,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":95,"mirror_url":null,"open_issues_count":20,"forks":95,"open_issues":20,"watchers":125,"default_branch":"dev"}},"base":{"label":"Wikia:dev","ref":"dev","sha":"486fd2d81ecd021f2d671b416b54e4704d28f1e8","user":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars3.githubusercontent.com/u/1171011?v=4","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"repo":{"id":5532313,"name":"app","full_name":"Wikia/app","owner":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars3.githubusercontent.com/u/1171011?v=4","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Wikia/app","description":"Wikia Application Code","fork":false,"url":"https://api.github.com/repos/Wikia/app","forks_url":"https://api.github.com/repos/Wikia/app/forks","keys_url":"https://api.github.com/repos/Wikia/app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wikia/app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wikia/app/teams","hooks_url":"https://api.github.com/repos/Wikia/app/hooks","issue_events_url":"https://api.github.com/repos/Wikia/app/issues/events{/number}","events_url":"https://api.github.com/repos/Wikia/app/events","assignees_url":"https://api.github.com/repos/Wikia/app/assignees{/user}","branches_url":"https://api.github.com/repos/Wikia/app/branches{/branch}","tags_url":"https://api.github.com/repos/Wikia/app/tags","blobs_url":"https://api.github.com/repos/Wikia/app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wikia/app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wikia/app/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wikia/app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wikia/app/statuses/{sha}","languages_url":"https://api.github.com/repos/Wikia/app/languages","stargazers_url":"https://api.github.com/repos/Wikia/app/stargazers","contributors_url":"https://api.github.com/repos/Wikia/app/contributors","subscribers_url":"https://api.github.com/repos/Wikia/app/subscribers","subscription_url":"https://api.github.com/repos/Wikia/app/subscription","commits_url":"https://api.github.com/repos/Wikia/app/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wikia/app/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wikia/app/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wikia/app/issues/comments{/number}","contents_url":"https://api.github.com/repos/Wikia/app/contents/{+path}","compare_url":"https://api.github.com/repos/Wikia/app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wikia/app/merges","archive_url":"https://api.github.com/repos/Wikia/app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wikia/app/downloads","issues_url":"https://api.github.com/repos/Wikia/app/issues{/number}","pulls_url":"https://api.github.com/repos/Wikia/app/pulls{/number}","milestones_url":"https://api.github.com/repos/Wikia/app/milestones{/number}","notifications_url":"https://api.github.com/repos/Wikia/app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wikia/app/labels{/name}","releases_url":"https://api.github.com/repos/Wikia/app/releases{/id}","deployments_url":"https://api.github.com/repos/Wikia/app/deployments","created_at":"2012-08-23T20:55:58Z","updated_at":"2017-09-21T18:39:35Z","pushed_at":"2017-09-25T08:49:13Z","git_url":"git://github.com/Wikia/app.git","ssh_url":"git@github.com:Wikia/app.git","clone_url":"https://github.com/Wikia/app.git","svn_url":"https://github.com/Wikia/app","homepage":"http://dev.wikia.com","size":784632,"stargazers_count":125,"watchers_count":125,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":95,"mirror_url":null,"open_issues_count":20,"forks":95,"open_issues":20,"watchers":125,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Wikia/app/pulls/13807"},"html":{"href":"https://github.com/Wikia/app/pull/13807"},"issue":{"href":"https://api.github.com/repos/Wikia/app/issues/13807"},"comments":{"href":"https://api.github.com/repos/Wikia/app/issues/13807/comments"},"review_comments":{"href":"https://api.github.com/repos/Wikia/app/pulls/13807/comments"},"review_comment":{"href":"https://api.github.com/repos/Wikia/app/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Wikia/app/pulls/13807/commits"},"statuses":{"href":"https://api.github.com/repos/Wikia/app/statuses/90e2154052417d693f9082d88b92ff8960dfc3b5"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"bkoval"}}