{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/50332","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/50332/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/50332/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/50332/events","html_url":"https://github.com/kubernetes/kubernetes/pull/50332","id":248821316,"number":50332,"title":"e2e test for local storage mount point","user":{"login":"ianchakeres","id":4367440,"avatar_url":"https://avatars0.githubusercontent.com/u/4367440?v=4","gravatar_id":"","url":"https://api.github.com/users/ianchakeres","html_url":"https://github.com/ianchakeres","followers_url":"https://api.github.com/users/ianchakeres/followers","following_url":"https://api.github.com/users/ianchakeres/following{/other_user}","gists_url":"https://api.github.com/users/ianchakeres/gists{/gist_id}","starred_url":"https://api.github.com/users/ianchakeres/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianchakeres/subscriptions","organizations_url":"https://api.github.com/users/ianchakeres/orgs","repos_url":"https://api.github.com/users/ianchakeres/repos","events_url":"https://api.github.com/users/ianchakeres/events{/privacy}","received_events_url":"https://api.github.com/users/ianchakeres/received_events","type":"User","site_admin":false},"labels":[{"id":477397086,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":349530192,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-label-needed","name":"release-note-label-needed","color":"db5a64","default":false},{"id":169428334,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/storage","name":"sig/storage","color":"d2b48c","default":false},{"id":253450978,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/L","name":"size/L","color":"ee9900","default":false}],"state":"open","locked":false,"assignee":{"login":"jsafrane","id":1745006,"avatar_url":"https://avatars2.githubusercontent.com/u/1745006?v=4","gravatar_id":"","url":"https://api.github.com/users/jsafrane","html_url":"https://github.com/jsafrane","followers_url":"https://api.github.com/users/jsafrane/followers","following_url":"https://api.github.com/users/jsafrane/following{/other_user}","gists_url":"https://api.github.com/users/jsafrane/gists{/gist_id}","starred_url":"https://api.github.com/users/jsafrane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsafrane/subscriptions","organizations_url":"https://api.github.com/users/jsafrane/orgs","repos_url":"https://api.github.com/users/jsafrane/repos","events_url":"https://api.github.com/users/jsafrane/events{/privacy}","received_events_url":"https://api.github.com/users/jsafrane/received_events","type":"User","site_admin":false},"assignees":[{"login":"jsafrane","id":1745006,"avatar_url":"https://avatars2.githubusercontent.com/u/1745006?v=4","gravatar_id":"","url":"https://api.github.com/users/jsafrane","html_url":"https://github.com/jsafrane","followers_url":"https://api.github.com/users/jsafrane/followers","following_url":"https://api.github.com/users/jsafrane/following{/other_user}","gists_url":"https://api.github.com/users/jsafrane/gists{/gist_id}","starred_url":"https://api.github.com/users/jsafrane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsafrane/subscriptions","organizations_url":"https://api.github.com/users/jsafrane/orgs","repos_url":"https://api.github.com/users/jsafrane/repos","events_url":"https://api.github.com/users/jsafrane/events{/privacy}","received_events_url":"https://api.github.com/users/jsafrane/received_events","type":"User","site_admin":false},{"login":"rootfs","id":7062400,"avatar_url":"https://avatars0.githubusercontent.com/u/7062400?v=4","gravatar_id":"","url":"https://api.github.com/users/rootfs","html_url":"https://github.com/rootfs","followers_url":"https://api.github.com/users/rootfs/followers","following_url":"https://api.github.com/users/rootfs/following{/other_user}","gists_url":"https://api.github.com/users/rootfs/gists{/gist_id}","starred_url":"https://api.github.com/users/rootfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rootfs/subscriptions","organizations_url":"https://api.github.com/users/rootfs/orgs","repos_url":"https://api.github.com/users/rootfs/repos","events_url":"https://api.github.com/users/rootfs/events{/privacy}","received_events_url":"https://api.github.com/users/rootfs/received_events","type":"User","site_admin":false},{"login":"msau42","id":24448061,"avatar_url":"https://avatars3.githubusercontent.com/u/24448061?v=4","gravatar_id":"","url":"https://api.github.com/users/msau42","html_url":"https://github.com/msau42","followers_url":"https://api.github.com/users/msau42/followers","following_url":"https://api.github.com/users/msau42/following{/other_user}","gists_url":"https://api.github.com/users/msau42/gists{/gist_id}","starred_url":"https://api.github.com/users/msau42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msau42/subscriptions","organizations_url":"https://api.github.com/users/msau42/orgs","repos_url":"https://api.github.com/users/msau42/repos","events_url":"https://api.github.com/users/msau42/events{/privacy}","received_events_url":"https://api.github.com/users/msau42/received_events","type":"User","site_admin":false}],"milestone":null,"comments":7,"created_at":"2017-08-08T19:30:01Z","updated_at":"2017-08-13T17:12:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/50332","html_url":"https://github.com/kubernetes/kubernetes/pull/50332","diff_url":"https://github.com/kubernetes/kubernetes/pull/50332.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/50332.patch"},"body":"\r\n**What this PR does / why we need it**:\r\n\r\nWe discovered that kubernetes can treat local directories and actual mountpoints differently. For example, https://github.com/kubernetes/kubernetes/issues/48331. The current local storage e2e tests use directories.\r\n\r\nThis PR introduces a test that creates a tmpfs and mounts it, and runs one of the local storage e2e tests.\r\n\r\n**Which issue this PR fixes**: fixes https://github.com/kubernetes/kubernetes/issues/49126\r\n\r\n**Special notes for your reviewer**:\r\n\r\nI cherrypicked PR https://github.com/kubernetes/kubernetes/pull/50177, since local storage e2e tests are broken in master on 2017-08-08 due to \"no such host\" error. This PR replaces NodeExec with SSH commands.\r\n\r\nYou can run the tests using the following commands:\r\n``` \r\n$ NUM_NODES=1 KUBE_FEATURE_GATES=\"PersistentLocalVolumes=true\" go run hack/e2e.go -- -v --up\r\n$ go run hack/e2e.go -- -v --test --test_args=\"--ginkgo.focus=\\[Feature:LocalPersistentVolumes\\]\"\r\n```\r\n\r\nHere are the summary of results from my test run:\r\n```\r\nRan 9 of 651 Specs in 387.905 seconds\r\nSUCCESS! -- 9 Passed | 0 Failed | 0 Pending | 642 Skipped PASS\r\n\r\nGinkgo ran 1 suite in 6m29.369318483s\r\nTest Suite Passed\r\n2017/08/08 11:54:01 util.go:133: Step './hack/ginkgo-e2e.sh --ginkgo.focus=\\[Feature:LocalPersistentVolumes\\]' finished in 6m32.077462612s\r\n```\r\n\r\n**Release note**:\r\n`NONE`"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/322054227","html_url":"https://github.com/kubernetes/kubernetes/pull/50332#issuecomment-322054227","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/50332","id":322054227,"user":{"login":"ianchakeres","id":4367440,"avatar_url":"https://avatars0.githubusercontent.com/u/4367440?v=4","gravatar_id":"","url":"https://api.github.com/users/ianchakeres","html_url":"https://github.com/ianchakeres","followers_url":"https://api.github.com/users/ianchakeres/followers","following_url":"https://api.github.com/users/ianchakeres/following{/other_user}","gists_url":"https://api.github.com/users/ianchakeres/gists{/gist_id}","starred_url":"https://api.github.com/users/ianchakeres/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianchakeres/subscriptions","organizations_url":"https://api.github.com/users/ianchakeres/orgs","repos_url":"https://api.github.com/users/ianchakeres/repos","events_url":"https://api.github.com/users/ianchakeres/events{/privacy}","received_events_url":"https://api.github.com/users/ianchakeres/received_events","type":"User","site_admin":false},"created_at":"2017-08-13T17:12:16Z","updated_at":"2017-08-13T17:12:16Z","body":"/assign @jsafrane - can you please take a look at this PR?"}}
{"actor":{"display_login":"ianchakeres"}}