{"action":"created","comment":{"url":"https://api.github.com/repos/apache/reef/pulls/comments/149443350","pull_request_review_id":74835548,"id":149443350,"diff_hunk":"@@ -109,7 +109,20 @@ private static IConfiguration GetRuntimeConfiguration(string name)\n \n         public static void MainSimple(string[] args)\n         {\n-            TangFactory.GetTang().NewInjector(GetRuntimeConfiguration(args.Length > 0 ? args[0] : Local)).GetInstance<HelloREEF>().Run();\n+            // Get the runtime-specific configuration\n+            var runtimeConfiguration = GetRuntimeConfiguration(args.Length > 0 ? args[0] : Local);\n+\n+            // Specify where to load the assemblies for REEF\n+            var clientConfiguration = ClientParametersConfiguration.Conf\n+                .Set(ClientParametersConfiguration.GlobalAssemblyDirectory, ClientUtilities.GetPathToExecutingAssembly())\n+                .Build();\n+\n+            // Combine the two configurations into one\n+            var configuration = TangFactory.GetTang()","path":"lang/cs/Org.Apache.REEF.Examples.HelloREEF/HelloREEF.cs","position":14,"original_position":14,"commit_id":"d13aefd86739857bbf5f1819997b195a7f13d5df","original_commit_id":"d13aefd86739857bbf5f1819997b195a7f13d5df","user":{"login":"markusweimer","id":502371,"avatar_url":"https://avatars3.githubusercontent.com/u/502371?v=4","gravatar_id":"","url":"https://api.github.com/users/markusweimer","html_url":"https://github.com/markusweimer","followers_url":"https://api.github.com/users/markusweimer/followers","following_url":"https://api.github.com/users/markusweimer/following{/other_user}","gists_url":"https://api.github.com/users/markusweimer/gists{/gist_id}","starred_url":"https://api.github.com/users/markusweimer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markusweimer/subscriptions","organizations_url":"https://api.github.com/users/markusweimer/orgs","repos_url":"https://api.github.com/users/markusweimer/repos","events_url":"https://api.github.com/users/markusweimer/events{/privacy}","received_events_url":"https://api.github.com/users/markusweimer/received_events","type":"User","site_admin":false},"body":"Use `Configurations.Merge()`","created_at":"2017-11-07T17:23:00Z","updated_at":"2017-11-07T17:24:19Z","html_url":"https://github.com/apache/reef/pull/1414#discussion_r149443350","pull_request_url":"https://api.github.com/repos/apache/reef/pulls/1414","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/reef/pulls/comments/149443350"},"html":{"href":"https://github.com/apache/reef/pull/1414#discussion_r149443350"},"pull_request":{"href":"https://api.github.com/repos/apache/reef/pulls/1414"}}},"pull_request":{"url":"https://api.github.com/repos/apache/reef/pulls/1414","id":151024364,"html_url":"https://github.com/apache/reef/pull/1414","diff_url":"https://github.com/apache/reef/pull/1414.diff","patch_url":"https://github.com/apache/reef/pull/1414.patch","issue_url":"https://api.github.com/repos/apache/reef/issues/1414","number":1414,"state":"open","locked":false,"title":"[REEF-1826] REEF_Must_be_Invoked_in_a_Directory_that_Contains_Its_DLLs","user":{"login":"rogancarr","id":19598317,"avatar_url":"https://avatars0.githubusercontent.com/u/19598317?v=4","gravatar_id":"","url":"https://api.github.com/users/rogancarr","html_url":"https://github.com/rogancarr","followers_url":"https://api.github.com/users/rogancarr/followers","following_url":"https://api.github.com/users/rogancarr/following{/other_user}","gists_url":"https://api.github.com/users/rogancarr/gists{/gist_id}","starred_url":"https://api.github.com/users/rogancarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rogancarr/subscriptions","organizations_url":"https://api.github.com/users/rogancarr/orgs","repos_url":"https://api.github.com/users/rogancarr/repos","events_url":"https://api.github.com/users/rogancarr/events{/privacy}","received_events_url":"https://api.github.com/users/rogancarr/received_events","type":"User","site_admin":false},"body":"This addressed the issue by\r\n\r\n  * Adding the directory to use to source assemblies as a parameter to the `REEF Client`\r\n  * Added a helper function to use the directory of the currently-running executable\r\n  * Updated HelloREEF to use the executable directory instead of the current working directory\r\n\r\nJIRA:\r\nREEF-1826\r\n\r\nPull request:\r\nThis closes #1826","created_at":"2017-11-07T04:46:58Z","updated_at":"2017-11-07T17:24:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"10cf7b3b5b29a8696b8ee98a2b3f5b76d6ca1c75","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/reef/pulls/1414/commits","review_comments_url":"https://api.github.com/repos/apache/reef/pulls/1414/comments","review_comment_url":"https://api.github.com/repos/apache/reef/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/reef/issues/1414/comments","statuses_url":"https://api.github.com/repos/apache/reef/statuses/d13aefd86739857bbf5f1819997b195a7f13d5df","head":{"label":"rogancarr:REEF-1826","ref":"REEF-1826","sha":"d13aefd86739857bbf5f1819997b195a7f13d5df","user":{"login":"rogancarr","id":19598317,"avatar_url":"https://avatars0.githubusercontent.com/u/19598317?v=4","gravatar_id":"","url":"https://api.github.com/users/rogancarr","html_url":"https://github.com/rogancarr","followers_url":"https://api.github.com/users/rogancarr/followers","following_url":"https://api.github.com/users/rogancarr/following{/other_user}","gists_url":"https://api.github.com/users/rogancarr/gists{/gist_id}","starred_url":"https://api.github.com/users/rogancarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rogancarr/subscriptions","organizations_url":"https://api.github.com/users/rogancarr/orgs","repos_url":"https://api.github.com/users/rogancarr/repos","events_url":"https://api.github.com/users/rogancarr/events{/privacy}","received_events_url":"https://api.github.com/users/rogancarr/received_events","type":"User","site_admin":false},"repo":{"id":87957451,"name":"reef","full_name":"rogancarr/reef","owner":{"login":"rogancarr","id":19598317,"avatar_url":"https://avatars0.githubusercontent.com/u/19598317?v=4","gravatar_id":"","url":"https://api.github.com/users/rogancarr","html_url":"https://github.com/rogancarr","followers_url":"https://api.github.com/users/rogancarr/followers","following_url":"https://api.github.com/users/rogancarr/following{/other_user}","gists_url":"https://api.github.com/users/rogancarr/gists{/gist_id}","starred_url":"https://api.github.com/users/rogancarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rogancarr/subscriptions","organizations_url":"https://api.github.com/users/rogancarr/orgs","repos_url":"https://api.github.com/users/rogancarr/repos","events_url":"https://api.github.com/users/rogancarr/events{/privacy}","received_events_url":"https://api.github.com/users/rogancarr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rogancarr/reef","description":"Mirror of Apache REEF","fork":true,"url":"https://api.github.com/repos/rogancarr/reef","forks_url":"https://api.github.com/repos/rogancarr/reef/forks","keys_url":"https://api.github.com/repos/rogancarr/reef/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rogancarr/reef/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rogancarr/reef/teams","hooks_url":"https://api.github.com/repos/rogancarr/reef/hooks","issue_events_url":"https://api.github.com/repos/rogancarr/reef/issues/events{/number}","events_url":"https://api.github.com/repos/rogancarr/reef/events","assignees_url":"https://api.github.com/repos/rogancarr/reef/assignees{/user}","branches_url":"https://api.github.com/repos/rogancarr/reef/branches{/branch}","tags_url":"https://api.github.com/repos/rogancarr/reef/tags","blobs_url":"https://api.github.com/repos/rogancarr/reef/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rogancarr/reef/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rogancarr/reef/git/refs{/sha}","trees_url":"https://api.github.com/repos/rogancarr/reef/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rogancarr/reef/statuses/{sha}","languages_url":"https://api.github.com/repos/rogancarr/reef/languages","stargazers_url":"https://api.github.com/repos/rogancarr/reef/stargazers","contributors_url":"https://api.github.com/repos/rogancarr/reef/contributors","subscribers_url":"https://api.github.com/repos/rogancarr/reef/subscribers","subscription_url":"https://api.github.com/repos/rogancarr/reef/subscription","commits_url":"https://api.github.com/repos/rogancarr/reef/commits{/sha}","git_commits_url":"https://api.github.com/repos/rogancarr/reef/git/commits{/sha}","comments_url":"https://api.github.com/repos/rogancarr/reef/comments{/number}","issue_comment_url":"https://api.github.com/repos/rogancarr/reef/issues/comments{/number}","contents_url":"https://api.github.com/repos/rogancarr/reef/contents/{+path}","compare_url":"https://api.github.com/repos/rogancarr/reef/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rogancarr/reef/merges","archive_url":"https://api.github.com/repos/rogancarr/reef/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rogancarr/reef/downloads","issues_url":"https://api.github.com/repos/rogancarr/reef/issues{/number}","pulls_url":"https://api.github.com/repos/rogancarr/reef/pulls{/number}","milestones_url":"https://api.github.com/repos/rogancarr/reef/milestones{/number}","notifications_url":"https://api.github.com/repos/rogancarr/reef/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rogancarr/reef/labels{/name}","releases_url":"https://api.github.com/repos/rogancarr/reef/releases{/id}","deployments_url":"https://api.github.com/repos/rogancarr/reef/deployments","created_at":"2017-04-11T16:42:07Z","updated_at":"2017-04-11T16:42:17Z","pushed_at":"2017-11-07T04:45:52Z","git_url":"git://github.com/rogancarr/reef.git","ssh_url":"git@github.com:rogancarr/reef.git","clone_url":"https://github.com/rogancarr/reef.git","svn_url":"https://github.com/rogancarr/reef","homepage":"","size":39160,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"e36ee921d77ca6b88512ad1b8f3a1ad9752ed939","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":25623941,"name":"reef","full_name":"apache/reef","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/reef","description":"Mirror of Apache REEF","fork":false,"url":"https://api.github.com/repos/apache/reef","forks_url":"https://api.github.com/repos/apache/reef/forks","keys_url":"https://api.github.com/repos/apache/reef/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/reef/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/reef/teams","hooks_url":"https://api.github.com/repos/apache/reef/hooks","issue_events_url":"https://api.github.com/repos/apache/reef/issues/events{/number}","events_url":"https://api.github.com/repos/apache/reef/events","assignees_url":"https://api.github.com/repos/apache/reef/assignees{/user}","branches_url":"https://api.github.com/repos/apache/reef/branches{/branch}","tags_url":"https://api.github.com/repos/apache/reef/tags","blobs_url":"https://api.github.com/repos/apache/reef/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/reef/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/reef/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/reef/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/reef/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/reef/languages","stargazers_url":"https://api.github.com/repos/apache/reef/stargazers","contributors_url":"https://api.github.com/repos/apache/reef/contributors","subscribers_url":"https://api.github.com/repos/apache/reef/subscribers","subscription_url":"https://api.github.com/repos/apache/reef/subscription","commits_url":"https://api.github.com/repos/apache/reef/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/reef/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/reef/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/reef/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/reef/contents/{+path}","compare_url":"https://api.github.com/repos/apache/reef/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/reef/merges","archive_url":"https://api.github.com/repos/apache/reef/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/reef/downloads","issues_url":"https://api.github.com/repos/apache/reef/issues{/number}","pulls_url":"https://api.github.com/repos/apache/reef/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/reef/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/reef/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/reef/labels{/name}","releases_url":"https://api.github.com/repos/apache/reef/releases{/id}","deployments_url":"https://api.github.com/repos/apache/reef/deployments","created_at":"2014-10-23T07:00:10Z","updated_at":"2017-11-01T06:36:03Z","pushed_at":"2017-11-07T05:30:07Z","git_url":"git://github.com/apache/reef.git","ssh_url":"git@github.com:apache/reef.git","clone_url":"https://github.com/apache/reef.git","svn_url":"https://github.com/apache/reef","homepage":"","size":39165,"stargazers_count":73,"watchers_count":73,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":93,"mirror_url":"git://git.apache.org/reef.git","archived":false,"open_issues_count":7,"forks":93,"open_issues":7,"watchers":73,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/reef/pulls/1414"},"html":{"href":"https://github.com/apache/reef/pull/1414"},"issue":{"href":"https://api.github.com/repos/apache/reef/issues/1414"},"comments":{"href":"https://api.github.com/repos/apache/reef/issues/1414/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/reef/pulls/1414/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/reef/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/reef/pulls/1414/commits"},"statuses":{"href":"https://api.github.com/repos/apache/reef/statuses/d13aefd86739857bbf5f1819997b195a7f13d5df"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"markusweimer"}}