{"action":"closed","number":547,"pull_request":{"url":"https://api.github.com/repos/codeforamerica/michigan-benefits/pulls/547","id":155222882,"html_url":"https://github.com/codeforamerica/michigan-benefits/pull/547","diff_url":"https://github.com/codeforamerica/michigan-benefits/pull/547.diff","patch_url":"https://github.com/codeforamerica/michigan-benefits/pull/547.patch","issue_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/issues/547","number":547,"state":"closed","locked":false,"title":"Improve accessibility of radio and checkbox sets","user":{"login":"jessieay","id":601515,"avatar_url":"https://avatars0.githubusercontent.com/u/601515?v=4","gravatar_id":"","url":"https://api.github.com/users/jessieay","html_url":"https://github.com/jessieay","followers_url":"https://api.github.com/users/jessieay/followers","following_url":"https://api.github.com/users/jessieay/following{/other_user}","gists_url":"https://api.github.com/users/jessieay/gists{/gist_id}","starred_url":"https://api.github.com/users/jessieay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jessieay/subscriptions","organizations_url":"https://api.github.com/users/jessieay/orgs","repos_url":"https://api.github.com/users/jessieay/repos","events_url":"https://api.github.com/users/jessieay/events{/privacy}","received_events_url":"https://api.github.com/users/jessieay/received_events","type":"User","site_admin":false},"body":"* Adds `legend` elements on collections via MbFormBuilder\r\n* Some of these collections do not have `label_text`, so the next step\r\nis to add a hidden `label_text` for those cases so that a screenreader\r\nwill have legend text.\r\n* There are still many other fieldsets in the views that do not have\r\nlegends.\r\n* [#152761627]\r\n* Part of https://www.pivotaltracker.com/story/show/152761627\r\n\r\nExample output HTML for radio collection with a label:\r\n\r\n```\r\n<fieldset class=\"form-group\">\r\n              <legend class=\"form-question \">Does your household have ongoing medical expenses?</legend>\r\n        <p class=\"text--help\">This includes health insurance, co-pays, prescriptions, dental,\r\nhospital bills, etc.\r\n</p>\r\n\r\n              <radiogroup class=\"input-group--block\">\r\n        <label class=\"radio-button\">\r\n          <input type=\"radio\" value=\"true\" name=\"step[medical]\" id=\"step_medical_true\">\r\n          Yes\r\n        </label>\r\n        <label class=\"radio-button\">\r\n          <input type=\"radio\" value=\"false\" name=\"step[medical]\" id=\"step_medical_false\">\r\n          No\r\n        </label>\r\n      </radiogroup>\r\n\r\n        \r\n      </fieldset>\r\n```\r\n\r\nExample output for checkbox collection without label (needs value for legend):\r\n```\r\n<fieldset class=\"input-group\">\r\n              <legend class=\"form-question \"></legend>\r\n\r\n                <label class=\"checkbox\">\r\n                <input name=\"step[unemployment_insurance]\" type=\"hidden\" value=\"0\"><input type=\"checkbox\" value=\"1\" name=\"step[unemployment_insurance]\" id=\"step_unemployment_insurance\"> Unemployment Insurance\r\n\r\n        </label>\r\n      \r\n        <label class=\"checkbox\">\r\n                <input name=\"step[ssi_or_disability]\" type=\"hidden\" value=\"0\"><input type=\"checkbox\" value=\"1\" name=\"step[ssi_or_disability]\" id=\"step_ssi_or_disability\"> SSI or Disability\r\n\r\n        </label>\r\n      \r\n        <label class=\"checkbox\">\r\n                <input name=\"step[workers_compensation]\" type=\"hidden\" value=\"0\"><input type=\"checkbox\" value=\"1\" name=\"step[workers_compensation]\" id=\"step_workers_compensation\"> Worker’s Compensation\r\n\r\n        </label>\r\n      \r\n        <label class=\"checkbox\">\r\n                <input name=\"step[pension]\" type=\"hidden\" value=\"0\"><input type=\"checkbox\" value=\"1\" name=\"step[pension]\" id=\"step_pension\"> Pension\r\n\r\n        </label>\r\n      \r\n        <label class=\"checkbox\">\r\n                <input name=\"step[social_security]\" type=\"hidden\" value=\"0\"><input type=\"checkbox\" value=\"1\" name=\"step[social_security]\" id=\"step_social_security\"> Social Security\r\n\r\n        </label>\r\n      \r\n        <label class=\"checkbox\">\r\n                <input name=\"step[child_support]\" type=\"hidden\" value=\"0\"><input type=\"checkbox\" value=\"1\" name=\"step[child_support]\" id=\"step_child_support\"> Child Support\r\n\r\n        </label>\r\n      \r\n        <label class=\"checkbox\">\r\n                <input name=\"step[other]\" type=\"hidden\" value=\"0\"><input type=\"checkbox\" value=\"1\" name=\"step[other]\" id=\"step_other\"> Other Income\r\n\r\n        </label>\r\n      \r\n\r\n      </fieldset>\r\n```","created_at":"2017-11-29T00:50:42Z","updated_at":"2017-11-29T21:34:52Z","closed_at":"2017-11-29T21:34:52Z","merged_at":"2017-11-29T21:34:52Z","merge_commit_sha":"ec45f4305f8425b28e73d62f9a5967221c1e5560","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/pulls/547/commits","review_comments_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/pulls/547/comments","review_comment_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/pulls/comments{/number}","comments_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/issues/547/comments","statuses_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/statuses/2652bc24ac61a5b9e336b6c0156319cfb928d459","head":{"label":"codeforamerica:jy-fieldsets","ref":"jy-fieldsets","sha":"2652bc24ac61a5b9e336b6c0156319cfb928d459","user":{"login":"codeforamerica","id":337792,"avatar_url":"https://avatars2.githubusercontent.com/u/337792?v=4","gravatar_id":"","url":"https://api.github.com/users/codeforamerica","html_url":"https://github.com/codeforamerica","followers_url":"https://api.github.com/users/codeforamerica/followers","following_url":"https://api.github.com/users/codeforamerica/following{/other_user}","gists_url":"https://api.github.com/users/codeforamerica/gists{/gist_id}","starred_url":"https://api.github.com/users/codeforamerica/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codeforamerica/subscriptions","organizations_url":"https://api.github.com/users/codeforamerica/orgs","repos_url":"https://api.github.com/users/codeforamerica/repos","events_url":"https://api.github.com/users/codeforamerica/events{/privacy}","received_events_url":"https://api.github.com/users/codeforamerica/received_events","type":"Organization","site_admin":false},"repo":{"id":83607937,"name":"michigan-benefits","full_name":"codeforamerica/michigan-benefits","owner":{"login":"codeforamerica","id":337792,"avatar_url":"https://avatars2.githubusercontent.com/u/337792?v=4","gravatar_id":"","url":"https://api.github.com/users/codeforamerica","html_url":"https://github.com/codeforamerica","followers_url":"https://api.github.com/users/codeforamerica/followers","following_url":"https://api.github.com/users/codeforamerica/following{/other_user}","gists_url":"https://api.github.com/users/codeforamerica/gists{/gist_id}","starred_url":"https://api.github.com/users/codeforamerica/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codeforamerica/subscriptions","organizations_url":"https://api.github.com/users/codeforamerica/orgs","repos_url":"https://api.github.com/users/codeforamerica/repos","events_url":"https://api.github.com/users/codeforamerica/events{/privacy}","received_events_url":"https://api.github.com/users/codeforamerica/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/codeforamerica/michigan-benefits","description":"Digital Assister for Michigan","fork":false,"url":"https://api.github.com/repos/codeforamerica/michigan-benefits","forks_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/forks","keys_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/teams","hooks_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/hooks","issue_events_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/issues/events{/number}","events_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/events","assignees_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/assignees{/user}","branches_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/branches{/branch}","tags_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/tags","blobs_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/git/refs{/sha}","trees_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/statuses/{sha}","languages_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/languages","stargazers_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/stargazers","contributors_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/contributors","subscribers_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/subscribers","subscription_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/subscription","commits_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/commits{/sha}","git_commits_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/git/commits{/sha}","comments_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/comments{/number}","issue_comment_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/issues/comments{/number}","contents_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/contents/{+path}","compare_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/merges","archive_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/downloads","issues_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/issues{/number}","pulls_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/pulls{/number}","milestones_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/milestones{/number}","notifications_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/labels{/name}","releases_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/releases{/id}","deployments_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/deployments","created_at":"2017-03-01T22:24:46Z","updated_at":"2017-11-07T19:44:15Z","pushed_at":"2017-11-29T21:34:52Z","git_url":"git://github.com/codeforamerica/michigan-benefits.git","ssh_url":"git@github.com:codeforamerica/michigan-benefits.git","clone_url":"https://github.com/codeforamerica/michigan-benefits.git","svn_url":"https://github.com/codeforamerica/michigan-benefits","homepage":"","size":12775,"stargazers_count":9,"watchers_count":9,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":3,"open_issues":3,"watchers":9,"default_branch":"master"}},"base":{"label":"codeforamerica:master","ref":"master","sha":"6f8b1f79fbbdd2be99a2082d81e1c077890b0326","user":{"login":"codeforamerica","id":337792,"avatar_url":"https://avatars2.githubusercontent.com/u/337792?v=4","gravatar_id":"","url":"https://api.github.com/users/codeforamerica","html_url":"https://github.com/codeforamerica","followers_url":"https://api.github.com/users/codeforamerica/followers","following_url":"https://api.github.com/users/codeforamerica/following{/other_user}","gists_url":"https://api.github.com/users/codeforamerica/gists{/gist_id}","starred_url":"https://api.github.com/users/codeforamerica/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codeforamerica/subscriptions","organizations_url":"https://api.github.com/users/codeforamerica/orgs","repos_url":"https://api.github.com/users/codeforamerica/repos","events_url":"https://api.github.com/users/codeforamerica/events{/privacy}","received_events_url":"https://api.github.com/users/codeforamerica/received_events","type":"Organization","site_admin":false},"repo":{"id":83607937,"name":"michigan-benefits","full_name":"codeforamerica/michigan-benefits","owner":{"login":"codeforamerica","id":337792,"avatar_url":"https://avatars2.githubusercontent.com/u/337792?v=4","gravatar_id":"","url":"https://api.github.com/users/codeforamerica","html_url":"https://github.com/codeforamerica","followers_url":"https://api.github.com/users/codeforamerica/followers","following_url":"https://api.github.com/users/codeforamerica/following{/other_user}","gists_url":"https://api.github.com/users/codeforamerica/gists{/gist_id}","starred_url":"https://api.github.com/users/codeforamerica/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codeforamerica/subscriptions","organizations_url":"https://api.github.com/users/codeforamerica/orgs","repos_url":"https://api.github.com/users/codeforamerica/repos","events_url":"https://api.github.com/users/codeforamerica/events{/privacy}","received_events_url":"https://api.github.com/users/codeforamerica/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/codeforamerica/michigan-benefits","description":"Digital Assister for Michigan","fork":false,"url":"https://api.github.com/repos/codeforamerica/michigan-benefits","forks_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/forks","keys_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/teams","hooks_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/hooks","issue_events_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/issues/events{/number}","events_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/events","assignees_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/assignees{/user}","branches_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/branches{/branch}","tags_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/tags","blobs_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/git/refs{/sha}","trees_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/statuses/{sha}","languages_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/languages","stargazers_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/stargazers","contributors_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/contributors","subscribers_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/subscribers","subscription_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/subscription","commits_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/commits{/sha}","git_commits_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/git/commits{/sha}","comments_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/comments{/number}","issue_comment_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/issues/comments{/number}","contents_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/contents/{+path}","compare_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/merges","archive_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/downloads","issues_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/issues{/number}","pulls_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/pulls{/number}","milestones_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/milestones{/number}","notifications_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/labels{/name}","releases_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/releases{/id}","deployments_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/deployments","created_at":"2017-03-01T22:24:46Z","updated_at":"2017-11-07T19:44:15Z","pushed_at":"2017-11-29T21:34:52Z","git_url":"git://github.com/codeforamerica/michigan-benefits.git","ssh_url":"git@github.com:codeforamerica/michigan-benefits.git","clone_url":"https://github.com/codeforamerica/michigan-benefits.git","svn_url":"https://github.com/codeforamerica/michigan-benefits","homepage":"","size":12775,"stargazers_count":9,"watchers_count":9,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":3,"open_issues":3,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/codeforamerica/michigan-benefits/pulls/547"},"html":{"href":"https://github.com/codeforamerica/michigan-benefits/pull/547"},"issue":{"href":"https://api.github.com/repos/codeforamerica/michigan-benefits/issues/547"},"comments":{"href":"https://api.github.com/repos/codeforamerica/michigan-benefits/issues/547/comments"},"review_comments":{"href":"https://api.github.com/repos/codeforamerica/michigan-benefits/pulls/547/comments"},"review_comment":{"href":"https://api.github.com/repos/codeforamerica/michigan-benefits/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/codeforamerica/michigan-benefits/pulls/547/commits"},"statuses":{"href":"https://api.github.com/repos/codeforamerica/michigan-benefits/statuses/2652bc24ac61a5b9e336b6c0156319cfb928d459"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"jessieay","id":601515,"avatar_url":"https://avatars0.githubusercontent.com/u/601515?v=4","gravatar_id":"","url":"https://api.github.com/users/jessieay","html_url":"https://github.com/jessieay","followers_url":"https://api.github.com/users/jessieay/followers","following_url":"https://api.github.com/users/jessieay/following{/other_user}","gists_url":"https://api.github.com/users/jessieay/gists{/gist_id}","starred_url":"https://api.github.com/users/jessieay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jessieay/subscriptions","organizations_url":"https://api.github.com/users/jessieay/orgs","repos_url":"https://api.github.com/users/jessieay/repos","events_url":"https://api.github.com/users/jessieay/events{/privacy}","received_events_url":"https://api.github.com/users/jessieay/received_events","type":"User","site_admin":false},"comments":0,"review_comments":1,"maintainer_can_modify":false,"commits":1,"additions":94,"deletions":65,"changed_files":12}}
{"actor":{"display_login":"jessieay"}}