{"action":"created","comment":{"url":"https://api.github.com/repos/apple/swift/pulls/comments/146119656","pull_request_review_id":71021319,"id":146119656,"diff_hunk":"@@ -172,7 +171,6 @@ KNOWN_SETTINGS=(\n     build-swift-static-sdk-overlay    \"\"         \"set to 1 to build static variants of the Swift SDK overlay\"\n     build-swift-examples        \"1\"              \"set to 1 to build examples\"\n     build-swift-remote-mirror   \"1\"              \"set to 1 to build the Swift Remote Mirror library\"\n-    build-serialized-stdlib-unittest \"0\"         \"set to 1 to build the StdlibUnittest module with -sil-serialize-all\"","path":"utils/build-script-impl","position":12,"original_position":12,"commit_id":"810320c2d04f9d1b9a46a1a4c024aefee3579aff","original_commit_id":"810320c2d04f9d1b9a46a1a4c024aefee3579aff","user":{"login":"slavapestov","id":66486,"avatar_url":"https://avatars1.githubusercontent.com/u/66486?v=4","gravatar_id":"","url":"https://api.github.com/users/slavapestov","html_url":"https://github.com/slavapestov","followers_url":"https://api.github.com/users/slavapestov/followers","following_url":"https://api.github.com/users/slavapestov/following{/other_user}","gists_url":"https://api.github.com/users/slavapestov/gists{/gist_id}","starred_url":"https://api.github.com/users/slavapestov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slavapestov/subscriptions","organizations_url":"https://api.github.com/users/slavapestov/orgs","repos_url":"https://api.github.com/users/slavapestov/repos","events_url":"https://api.github.com/users/slavapestov/events{/privacy}","received_events_url":"https://api.github.com/users/slavapestov/received_events","type":"User","site_admin":false},"body":"This is also mentioned in presets.ini I think","created_at":"2017-10-22T01:27:38Z","updated_at":"2017-10-22T01:27:39Z","html_url":"https://github.com/apple/swift/pull/12549#discussion_r146119656","pull_request_url":"https://api.github.com/repos/apple/swift/pulls/12549","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/comments/146119656"},"html":{"href":"https://github.com/apple/swift/pull/12549#discussion_r146119656"},"pull_request":{"href":"https://api.github.com/repos/apple/swift/pulls/12549"}}},"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/12549","id":147954236,"html_url":"https://github.com/apple/swift/pull/12549","diff_url":"https://github.com/apple/swift/pull/12549.diff","patch_url":"https://github.com/apple/swift/pull/12549.patch","issue_url":"https://api.github.com/repos/apple/swift/issues/12549","number":12549,"state":"open","locked":false,"title":"Enable the serialization of sil_vtables by default and completely remove the -sil-serialize-vtables option","user":{"login":"swiftix","id":15327066,"avatar_url":"https://avatars0.githubusercontent.com/u/15327066?v=4","gravatar_id":"","url":"https://api.github.com/users/swiftix","html_url":"https://github.com/swiftix","followers_url":"https://api.github.com/users/swiftix/followers","following_url":"https://api.github.com/users/swiftix/following{/other_user}","gists_url":"https://api.github.com/users/swiftix/gists{/gist_id}","starred_url":"https://api.github.com/users/swiftix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swiftix/subscriptions","organizations_url":"https://api.github.com/users/swiftix/orgs","repos_url":"https://api.github.com/users/swiftix/repos","events_url":"https://api.github.com/users/swiftix/events{/privacy}","received_events_url":"https://api.github.com/users/swiftix/received_events","type":"User","site_admin":false},"body":"Only sil_vtables of public classes with fixed layout are serialized.","created_at":"2017-10-21T17:36:52Z","updated_at":"2017-10-22T01:27:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"360476991733a30d5ee77b984cd8993288e0f33f","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift/pulls/12549/commits","review_comments_url":"https://api.github.com/repos/apple/swift/pulls/12549/comments","review_comment_url":"https://api.github.com/repos/apple/swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift/issues/12549/comments","statuses_url":"https://api.github.com/repos/apple/swift/statuses/810320c2d04f9d1b9a46a1a4c024aefee3579aff","head":{"label":"swiftix:sil-serialization-before-optimizations5","ref":"sil-serialization-before-optimizations5","sha":"810320c2d04f9d1b9a46a1a4c024aefee3579aff","user":{"login":"swiftix","id":15327066,"avatar_url":"https://avatars0.githubusercontent.com/u/15327066?v=4","gravatar_id":"","url":"https://api.github.com/users/swiftix","html_url":"https://github.com/swiftix","followers_url":"https://api.github.com/users/swiftix/followers","following_url":"https://api.github.com/users/swiftix/following{/other_user}","gists_url":"https://api.github.com/users/swiftix/gists{/gist_id}","starred_url":"https://api.github.com/users/swiftix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swiftix/subscriptions","organizations_url":"https://api.github.com/users/swiftix/orgs","repos_url":"https://api.github.com/users/swiftix/repos","events_url":"https://api.github.com/users/swiftix/events{/privacy}","received_events_url":"https://api.github.com/users/swiftix/received_events","type":"User","site_admin":false},"repo":{"id":47780480,"name":"swift","full_name":"swiftix/swift","owner":{"login":"swiftix","id":15327066,"avatar_url":"https://avatars0.githubusercontent.com/u/15327066?v=4","gravatar_id":"","url":"https://api.github.com/users/swiftix","html_url":"https://github.com/swiftix","followers_url":"https://api.github.com/users/swiftix/followers","following_url":"https://api.github.com/users/swiftix/following{/other_user}","gists_url":"https://api.github.com/users/swiftix/gists{/gist_id}","starred_url":"https://api.github.com/users/swiftix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swiftix/subscriptions","organizations_url":"https://api.github.com/users/swiftix/orgs","repos_url":"https://api.github.com/users/swiftix/repos","events_url":"https://api.github.com/users/swiftix/events{/privacy}","received_events_url":"https://api.github.com/users/swiftix/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/swiftix/swift","description":"The Swift Programming Language","fork":true,"url":"https://api.github.com/repos/swiftix/swift","forks_url":"https://api.github.com/repos/swiftix/swift/forks","keys_url":"https://api.github.com/repos/swiftix/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/swiftix/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/swiftix/swift/teams","hooks_url":"https://api.github.com/repos/swiftix/swift/hooks","issue_events_url":"https://api.github.com/repos/swiftix/swift/issues/events{/number}","events_url":"https://api.github.com/repos/swiftix/swift/events","assignees_url":"https://api.github.com/repos/swiftix/swift/assignees{/user}","branches_url":"https://api.github.com/repos/swiftix/swift/branches{/branch}","tags_url":"https://api.github.com/repos/swiftix/swift/tags","blobs_url":"https://api.github.com/repos/swiftix/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/swiftix/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/swiftix/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/swiftix/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/swiftix/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/swiftix/swift/languages","stargazers_url":"https://api.github.com/repos/swiftix/swift/stargazers","contributors_url":"https://api.github.com/repos/swiftix/swift/contributors","subscribers_url":"https://api.github.com/repos/swiftix/swift/subscribers","subscription_url":"https://api.github.com/repos/swiftix/swift/subscription","commits_url":"https://api.github.com/repos/swiftix/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/swiftix/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/swiftix/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/swiftix/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/swiftix/swift/contents/{+path}","compare_url":"https://api.github.com/repos/swiftix/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/swiftix/swift/merges","archive_url":"https://api.github.com/repos/swiftix/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/swiftix/swift/downloads","issues_url":"https://api.github.com/repos/swiftix/swift/issues{/number}","pulls_url":"https://api.github.com/repos/swiftix/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/swiftix/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/swiftix/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/swiftix/swift/labels{/name}","releases_url":"https://api.github.com/repos/swiftix/swift/releases{/id}","deployments_url":"https://api.github.com/repos/swiftix/swift/deployments","created_at":"2015-12-10T18:41:01Z","updated_at":"2017-01-12T00:00:19Z","pushed_at":"2017-10-21T21:36:22Z","git_url":"git://github.com/swiftix/swift.git","ssh_url":"git@github.com:swiftix/swift.git","clone_url":"https://github.com/swiftix/swift.git","svn_url":"https://github.com/swiftix/swift","homepage":"","size":229594,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"5c8fefc32b5ae8ceaffa6f596f081daba299f5a1","user":{"login":"apple","id":10639145,"avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838949,"name":"swift","full_name":"apple/swift","owner":{"login":"apple","id":10639145,"avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/swift","description":"The Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift","forks_url":"https://api.github.com/repos/apple/swift/forks","keys_url":"https://api.github.com/repos/apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift/teams","hooks_url":"https://api.github.com/repos/apple/swift/hooks","issue_events_url":"https://api.github.com/repos/apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift/events","assignees_url":"https://api.github.com/repos/apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift/tags","blobs_url":"https://api.github.com/repos/apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift/languages","stargazers_url":"https://api.github.com/repos/apple/swift/stargazers","contributors_url":"https://api.github.com/repos/apple/swift/contributors","subscribers_url":"https://api.github.com/repos/apple/swift/subscribers","subscription_url":"https://api.github.com/repos/apple/swift/subscription","commits_url":"https://api.github.com/repos/apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift/merges","archive_url":"https://api.github.com/repos/apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift/downloads","issues_url":"https://api.github.com/repos/apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift/deployments","created_at":"2015-10-23T21:15:07Z","updated_at":"2017-10-21T22:15:02Z","pushed_at":"2017-10-22T01:23:09Z","git_url":"git://github.com/apple/swift.git","ssh_url":"git@github.com:apple/swift.git","clone_url":"https://github.com/apple/swift.git","svn_url":"https://github.com/apple/swift","homepage":"https://swift.org/","size":233537,"stargazers_count":41156,"watchers_count":41156,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6375,"mirror_url":null,"archived":false,"open_issues_count":181,"forks":6375,"open_issues":181,"watchers":41156,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/12549"},"html":{"href":"https://github.com/apple/swift/pull/12549"},"issue":{"href":"https://api.github.com/repos/apple/swift/issues/12549"},"comments":{"href":"https://api.github.com/repos/apple/swift/issues/12549/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift/pulls/12549/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift/pulls/12549/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift/statuses/810320c2d04f9d1b9a46a1a4c024aefee3579aff"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"slavapestov"}}