{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments/119426546","pull_request_review_id":41305305,"id":119426546,"diff_hunk":"@@ -136,6 +148,10 @@ protected void afterExecute(Runnable r, Throwable t) {\n         assert r instanceof TimedRunnable : \"expected only TimedRunnables in queue\";\n         final long taskNanos = ((TimedRunnable) r).getTotalNanos();\n         final long totalNanos = totalTaskNanos.addAndGet(taskNanos);\n+\n+        final long taskExecutionNanos = ((TimedRunnable) r).getTotalExecutionNanos();\n+        executionEWMA.addValue(taskExecutionNanos);","path":"core/src/main/java/org/elasticsearch/common/util/concurrent/QueueResizingEsThreadPoolExecutor.java","position":59,"original_position":59,"commit_id":"154dbac6b6dcbb42dd3488225ba2a61d1193392f","original_commit_id":"154dbac6b6dcbb42dd3488225ba2a61d1193392f","user":{"login":"dakrone","id":19060,"avatar_url":"https://avatars0.githubusercontent.com/u/19060?v=3","gravatar_id":"","url":"https://api.github.com/users/dakrone","html_url":"https://github.com/dakrone","followers_url":"https://api.github.com/users/dakrone/followers","following_url":"https://api.github.com/users/dakrone/following{/other_user}","gists_url":"https://api.github.com/users/dakrone/gists{/gist_id}","starred_url":"https://api.github.com/users/dakrone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dakrone/subscriptions","organizations_url":"https://api.github.com/users/dakrone/orgs","repos_url":"https://api.github.com/users/dakrone/repos","events_url":"https://api.github.com/users/dakrone/events{/privacy}","received_events_url":"https://api.github.com/users/dakrone/received_events","type":"User","site_admin":false},"body":"Even if `t` weren't null, the time should be >= 0; I'll add an assert","created_at":"2017-05-31T17:49:27Z","updated_at":"2017-05-31T17:49:27Z","html_url":"https://github.com/elastic/elasticsearch/pull/24989#discussion_r119426546","pull_request_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/24989","_links":{"self":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments/119426546"},"html":{"href":"https://github.com/elastic/elasticsearch/pull/24989#discussion_r119426546"},"pull_request":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/24989"}}},"pull_request":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/24989","id":123325483,"html_url":"https://github.com/elastic/elasticsearch/pull/24989","diff_url":"https://github.com/elastic/elasticsearch/pull/24989.diff","patch_url":"https://github.com/elastic/elasticsearch/pull/24989.patch","issue_url":"https://api.github.com/repos/elastic/elasticsearch/issues/24989","number":24989,"state":"open","locked":false,"title":"Track EWMA[1] of task execution time in search threadpool executor","user":{"login":"dakrone","id":19060,"avatar_url":"https://avatars0.githubusercontent.com/u/19060?v=3","gravatar_id":"","url":"https://api.github.com/users/dakrone","html_url":"https://github.com/dakrone","followers_url":"https://api.github.com/users/dakrone/followers","following_url":"https://api.github.com/users/dakrone/following{/other_user}","gists_url":"https://api.github.com/users/dakrone/gists{/gist_id}","starred_url":"https://api.github.com/users/dakrone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dakrone/subscriptions","organizations_url":"https://api.github.com/users/dakrone/orgs","repos_url":"https://api.github.com/users/dakrone/repos","events_url":"https://api.github.com/users/dakrone/events{/privacy}","received_events_url":"https://api.github.com/users/dakrone/received_events","type":"User","site_admin":false},"body":"This is the first step towards adaptive replica selection (#24915). This PR\r\ntracks the execution time, also known as the \"service time\" of a task in the\r\nthreadpool. The `QueueResizingEsThreadPoolExecutor` then stores a moving average\r\nof these task times which can be retrieved from the executor.\r\n\r\nCurrently there is no functionality using the EWMA yet (other than tests), this\r\nis only a bite-sized building block so that it's easier to review.\r\n\r\n[1]: EWMA = Exponentially Weighted Moving Average\r\n","created_at":"2017-05-31T17:21:41Z","updated_at":"2017-05-31T17:49:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3b035a70db04bacf13b780bf5d797486e813476d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"s1monw","id":973334,"avatar_url":"https://avatars3.githubusercontent.com/u/973334?v=3","gravatar_id":"","url":"https://api.github.com/users/s1monw","html_url":"https://github.com/s1monw","followers_url":"https://api.github.com/users/s1monw/followers","following_url":"https://api.github.com/users/s1monw/following{/other_user}","gists_url":"https://api.github.com/users/s1monw/gists{/gist_id}","starred_url":"https://api.github.com/users/s1monw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s1monw/subscriptions","organizations_url":"https://api.github.com/users/s1monw/orgs","repos_url":"https://api.github.com/users/s1monw/repos","events_url":"https://api.github.com/users/s1monw/events{/privacy}","received_events_url":"https://api.github.com/users/s1monw/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/24989/commits","review_comments_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/24989/comments","review_comment_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/issues/24989/comments","statuses_url":"https://api.github.com/repos/elastic/elasticsearch/statuses/154dbac6b6dcbb42dd3488225ba2a61d1193392f","head":{"label":"dakrone:capture-task-execution-ewma","ref":"capture-task-execution-ewma","sha":"154dbac6b6dcbb42dd3488225ba2a61d1193392f","user":{"login":"dakrone","id":19060,"avatar_url":"https://avatars0.githubusercontent.com/u/19060?v=3","gravatar_id":"","url":"https://api.github.com/users/dakrone","html_url":"https://github.com/dakrone","followers_url":"https://api.github.com/users/dakrone/followers","following_url":"https://api.github.com/users/dakrone/following{/other_user}","gists_url":"https://api.github.com/users/dakrone/gists{/gist_id}","starred_url":"https://api.github.com/users/dakrone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dakrone/subscriptions","organizations_url":"https://api.github.com/users/dakrone/orgs","repos_url":"https://api.github.com/users/dakrone/repos","events_url":"https://api.github.com/users/dakrone/events{/privacy}","received_events_url":"https://api.github.com/users/dakrone/received_events","type":"User","site_admin":false},"repo":{"id":3037278,"name":"elasticsearch","full_name":"dakrone/elasticsearch","owner":{"login":"dakrone","id":19060,"avatar_url":"https://avatars0.githubusercontent.com/u/19060?v=3","gravatar_id":"","url":"https://api.github.com/users/dakrone","html_url":"https://github.com/dakrone","followers_url":"https://api.github.com/users/dakrone/followers","following_url":"https://api.github.com/users/dakrone/following{/other_user}","gists_url":"https://api.github.com/users/dakrone/gists{/gist_id}","starred_url":"https://api.github.com/users/dakrone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dakrone/subscriptions","organizations_url":"https://api.github.com/users/dakrone/orgs","repos_url":"https://api.github.com/users/dakrone/repos","events_url":"https://api.github.com/users/dakrone/events{/privacy}","received_events_url":"https://api.github.com/users/dakrone/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dakrone/elasticsearch","description":"Open Source, Distributed, RESTful Search Engine","fork":true,"url":"https://api.github.com/repos/dakrone/elasticsearch","forks_url":"https://api.github.com/repos/dakrone/elasticsearch/forks","keys_url":"https://api.github.com/repos/dakrone/elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dakrone/elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dakrone/elasticsearch/teams","hooks_url":"https://api.github.com/repos/dakrone/elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/dakrone/elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/dakrone/elasticsearch/events","assignees_url":"https://api.github.com/repos/dakrone/elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/dakrone/elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/dakrone/elasticsearch/tags","blobs_url":"https://api.github.com/repos/dakrone/elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dakrone/elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dakrone/elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/dakrone/elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dakrone/elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/dakrone/elasticsearch/languages","stargazers_url":"https://api.github.com/repos/dakrone/elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/dakrone/elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/dakrone/elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/dakrone/elasticsearch/subscription","commits_url":"https://api.github.com/repos/dakrone/elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/dakrone/elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/dakrone/elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/dakrone/elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/dakrone/elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/dakrone/elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dakrone/elasticsearch/merges","archive_url":"https://api.github.com/repos/dakrone/elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dakrone/elasticsearch/downloads","issues_url":"https://api.github.com/repos/dakrone/elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/dakrone/elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/dakrone/elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/dakrone/elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dakrone/elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/dakrone/elasticsearch/releases{/id}","deployments_url":"https://api.github.com/repos/dakrone/elasticsearch/deployments","created_at":"2011-12-22T23:14:00Z","updated_at":"2017-02-17T09:39:58Z","pushed_at":"2017-05-31T16:59:49Z","git_url":"git://github.com/dakrone/elasticsearch.git","ssh_url":"git@github.com:dakrone/elasticsearch.git","clone_url":"https://github.com/dakrone/elasticsearch.git","svn_url":"https://github.com/dakrone/elasticsearch","homepage":"http://elasticsearch.org","size":266571,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"b5d62ae74766ff11a739d867192d93dc674cd191","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars3.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":507775,"name":"elasticsearch","full_name":"elastic/elasticsearch","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars3.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/elasticsearch","description":"Open Source, Distributed, RESTful Search Engine","fork":false,"url":"https://api.github.com/repos/elastic/elasticsearch","forks_url":"https://api.github.com/repos/elastic/elasticsearch/forks","keys_url":"https://api.github.com/repos/elastic/elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/elasticsearch/teams","hooks_url":"https://api.github.com/repos/elastic/elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/elastic/elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/elasticsearch/events","assignees_url":"https://api.github.com/repos/elastic/elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/elasticsearch/tags","blobs_url":"https://api.github.com/repos/elastic/elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/elasticsearch/languages","stargazers_url":"https://api.github.com/repos/elastic/elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/elastic/elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/elastic/elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/elastic/elasticsearch/subscription","commits_url":"https://api.github.com/repos/elastic/elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/elasticsearch/merges","archive_url":"https://api.github.com/repos/elastic/elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/elasticsearch/downloads","issues_url":"https://api.github.com/repos/elastic/elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/elastic/elasticsearch/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/elasticsearch/deployments","created_at":"2010-02-08T13:20:56Z","updated_at":"2017-05-31T16:28:54Z","pushed_at":"2017-05-31T17:42:55Z","git_url":"git://github.com/elastic/elasticsearch.git","ssh_url":"git@github.com:elastic/elasticsearch.git","clone_url":"https://github.com/elastic/elasticsearch.git","svn_url":"https://github.com/elastic/elasticsearch","homepage":"https://www.elastic.co/products/elasticsearch","size":344731,"stargazers_count":22969,"watchers_count":22969,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8080,"mirror_url":null,"open_issues_count":1329,"forks":8080,"open_issues":1329,"watchers":22969,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/24989"},"html":{"href":"https://github.com/elastic/elasticsearch/pull/24989"},"issue":{"href":"https://api.github.com/repos/elastic/elasticsearch/issues/24989"},"comments":{"href":"https://api.github.com/repos/elastic/elasticsearch/issues/24989/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/24989/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/24989/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/elasticsearch/statuses/154dbac6b6dcbb42dd3488225ba2a61d1193392f"}}}}
{"actor":{"display_login":"dakrone"}}