{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/102509340","pull_request_review_id":23266915,"id":102509340,"diff_hunk":"@@ -558,12 +558,15 @@ CONFIG_DWORD_INFO_EX(INTERNAL_JitVNMapSelLimit, W(\"JitVNMapSelLimit\"), 0, \"If no\n RETAIL_CONFIG_DWORD_INFO(INTERNAL_JitVNMapSelBudget, W(\"JitVNMapSelBudget\"), 100, \"Max # of MapSelect's considered for a particular top-level invocation.\")\n #if defined(_TARGET_AMD64_) || defined(_TARGET_X86_)\n #define EXTERNAL_FeatureSIMD_Default 1\n+#define EXTERNAL_JitEnableSSE3_4_Default 1\n #define EXTERNAL_JitEnableAVX_Default 1\n #else // !defined(_TARGET_AMD64_) && !defined(_TARGET_X86_)\n #define EXTERNAL_FeatureSIMD_Default 0\n+#define EXTERNAL_JitEnableSSE3_4_Default 0\n #define EXTERNAL_JitEnableAVX_Default 0\n #endif // !defined(_TARGET_AMD64_) && !defined(_TARGET_X86_)\n RETAIL_CONFIG_DWORD_INFO_EX(EXTERNAL_FeatureSIMD, W(\"FeatureSIMD\"), EXTERNAL_FeatureSIMD_Default, \"Enable SIMD support with companion SIMDVector.dll\", CLRConfig::REGUTIL_default)\n+RETAIL_CONFIG_DWORD_INFO_EX(EXTERNAL_EnableSSE3_4, W(\"EnableSSE3_4\"), EXTERNAL_JitEnableSSE3_4_Default, \"Enable SSE3, SSSE3, and SSE4 instruction set for wide operations as default\", CLRConfig::REGUTIL_default)","path":"src/inc/clrconfigvalues.h","position":12,"original_position":12,"commit_id":"6550022abaf7e49cd4dd41a82e9e4953d3cfa85b","original_commit_id":"6550022abaf7e49cd4dd41a82e9e4953d3cfa85b","user":{"login":"sivarv","id":11184808,"avatar_url":"https://avatars.githubusercontent.com/u/11184808?v=3","gravatar_id":"","url":"https://api.github.com/users/sivarv","html_url":"https://github.com/sivarv","followers_url":"https://api.github.com/users/sivarv/followers","following_url":"https://api.github.com/users/sivarv/following{/other_user}","gists_url":"https://api.github.com/users/sivarv/gists{/gist_id}","starred_url":"https://api.github.com/users/sivarv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sivarv/subscriptions","organizations_url":"https://api.github.com/users/sivarv/orgs","repos_url":"https://api.github.com/users/sivarv/repos","events_url":"https://api.github.com/users/sivarv/events{/privacy}","received_events_url":"https://api.github.com/users/sivarv/received_events","type":"User","site_admin":false},"body":"@dotnet/jit-contrib \r\n\r\nInitially only clrconfigvalues.h existed containing both clr-vm and jit specific config knobs.  With jitconfigvalues.h we have separated jit-specific knobs into that file but still kept already existing ones in clrconfigvalues.h because Desktop needs it.  The new jit-specific config values are to be added to jitconfigvalues.h only.  So to generate documentation, I would suggest to take the union of clrconfigvalues.h and jitconfigvalues.h.","created_at":"2017-02-22T16:38:18Z","updated_at":"2017-02-22T16:38:18Z","html_url":"https://github.com/dotnet/coreclr/pull/9710#discussion_r102509340","pull_request_url":"https://api.github.com/repos/dotnet/coreclr/pulls/9710","_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/102509340"},"html":{"href":"https://github.com/dotnet/coreclr/pull/9710#discussion_r102509340"},"pull_request":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/9710"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/9710","id":107308124,"html_url":"https://github.com/dotnet/coreclr/pull/9710","diff_url":"https://github.com/dotnet/coreclr/pull/9710.diff","patch_url":"https://github.com/dotnet/coreclr/pull/9710.patch","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/9710","number":9710,"state":"open","locked":false,"title":"Add EnableSSE3_4 as clr configuration knob in the documentation","user":{"login":"fiigii","id":1263030,"avatar_url":"https://avatars.githubusercontent.com/u/1263030?v=3","gravatar_id":"","url":"https://api.github.com/users/fiigii","html_url":"https://github.com/fiigii","followers_url":"https://api.github.com/users/fiigii/followers","following_url":"https://api.github.com/users/fiigii/following{/other_user}","gists_url":"https://api.github.com/users/fiigii/gists{/gist_id}","starred_url":"https://api.github.com/users/fiigii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fiigii/subscriptions","organizations_url":"https://api.github.com/users/fiigii/orgs","repos_url":"https://api.github.com/users/fiigii/repos","events_url":"https://api.github.com/users/fiigii/events{/privacy}","received_events_url":"https://api.github.com/users/fiigii/received_events","type":"User","site_admin":false},"body":"Fix #9659 ","created_at":"2017-02-22T00:12:36Z","updated_at":"2017-02-22T16:38:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"42075eb674d2934b314c672f5add451e9e9b93ec","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/coreclr/pulls/9710/commits","review_comments_url":"https://api.github.com/repos/dotnet/coreclr/pulls/9710/comments","review_comment_url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/9710/comments","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/6550022abaf7e49cd4dd41a82e9e4953d3cfa85b","head":{"label":"fiigii:sse3_4doc","ref":"sse3_4doc","sha":"6550022abaf7e49cd4dd41a82e9e4953d3cfa85b","user":{"login":"fiigii","id":1263030,"avatar_url":"https://avatars.githubusercontent.com/u/1263030?v=3","gravatar_id":"","url":"https://api.github.com/users/fiigii","html_url":"https://github.com/fiigii","followers_url":"https://api.github.com/users/fiigii/followers","following_url":"https://api.github.com/users/fiigii/following{/other_user}","gists_url":"https://api.github.com/users/fiigii/gists{/gist_id}","starred_url":"https://api.github.com/users/fiigii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fiigii/subscriptions","organizations_url":"https://api.github.com/users/fiigii/orgs","repos_url":"https://api.github.com/users/fiigii/repos","events_url":"https://api.github.com/users/fiigii/events{/privacy}","received_events_url":"https://api.github.com/users/fiigii/received_events","type":"User","site_admin":false},"repo":{"id":81883824,"name":"coreclr","full_name":"fiigii/coreclr","owner":{"login":"fiigii","id":1263030,"avatar_url":"https://avatars.githubusercontent.com/u/1263030?v=3","gravatar_id":"","url":"https://api.github.com/users/fiigii","html_url":"https://github.com/fiigii","followers_url":"https://api.github.com/users/fiigii/followers","following_url":"https://api.github.com/users/fiigii/following{/other_user}","gists_url":"https://api.github.com/users/fiigii/gists{/gist_id}","starred_url":"https://api.github.com/users/fiigii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fiigii/subscriptions","organizations_url":"https://api.github.com/users/fiigii/orgs","repos_url":"https://api.github.com/users/fiigii/repos","events_url":"https://api.github.com/users/fiigii/events{/privacy}","received_events_url":"https://api.github.com/users/fiigii/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fiigii/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called mscorlib. It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes.","fork":true,"url":"https://api.github.com/repos/fiigii/coreclr","forks_url":"https://api.github.com/repos/fiigii/coreclr/forks","keys_url":"https://api.github.com/repos/fiigii/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fiigii/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fiigii/coreclr/teams","hooks_url":"https://api.github.com/repos/fiigii/coreclr/hooks","issue_events_url":"https://api.github.com/repos/fiigii/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/fiigii/coreclr/events","assignees_url":"https://api.github.com/repos/fiigii/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/fiigii/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/fiigii/coreclr/tags","blobs_url":"https://api.github.com/repos/fiigii/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fiigii/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fiigii/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/fiigii/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fiigii/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/fiigii/coreclr/languages","stargazers_url":"https://api.github.com/repos/fiigii/coreclr/stargazers","contributors_url":"https://api.github.com/repos/fiigii/coreclr/contributors","subscribers_url":"https://api.github.com/repos/fiigii/coreclr/subscribers","subscription_url":"https://api.github.com/repos/fiigii/coreclr/subscription","commits_url":"https://api.github.com/repos/fiigii/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/fiigii/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/fiigii/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/fiigii/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/fiigii/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/fiigii/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fiigii/coreclr/merges","archive_url":"https://api.github.com/repos/fiigii/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fiigii/coreclr/downloads","issues_url":"https://api.github.com/repos/fiigii/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/fiigii/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/fiigii/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/fiigii/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fiigii/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/fiigii/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/fiigii/coreclr/deployments","created_at":"2017-02-13T23:46:21Z","updated_at":"2017-02-13T23:48:37Z","pushed_at":"2017-02-18T05:12:51Z","git_url":"git://github.com/fiigii/coreclr.git","ssh_url":"git@github.com:fiigii/coreclr.git","clone_url":"https://github.com/fiigii/coreclr.git","svn_url":"https://github.com/fiigii/coreclr","homepage":"https://docs.microsoft.com/dotnet/","size":140051,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"ccd082706fb108fe813b98a12da46fe551983c71","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":30092893,"name":"coreclr","full_name":"dotnet/coreclr","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called mscorlib. It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes.","fork":false,"url":"https://api.github.com/repos/dotnet/coreclr","forks_url":"https://api.github.com/repos/dotnet/coreclr/forks","keys_url":"https://api.github.com/repos/dotnet/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/coreclr/teams","hooks_url":"https://api.github.com/repos/dotnet/coreclr/hooks","issue_events_url":"https://api.github.com/repos/dotnet/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/coreclr/events","assignees_url":"https://api.github.com/repos/dotnet/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/coreclr/tags","blobs_url":"https://api.github.com/repos/dotnet/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/coreclr/languages","stargazers_url":"https://api.github.com/repos/dotnet/coreclr/stargazers","contributors_url":"https://api.github.com/repos/dotnet/coreclr/contributors","subscribers_url":"https://api.github.com/repos/dotnet/coreclr/subscribers","subscription_url":"https://api.github.com/repos/dotnet/coreclr/subscription","commits_url":"https://api.github.com/repos/dotnet/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/coreclr/merges","archive_url":"https://api.github.com/repos/dotnet/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/coreclr/downloads","issues_url":"https://api.github.com/repos/dotnet/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/coreclr/deployments","created_at":"2015-01-30T22:10:02Z","updated_at":"2017-02-22T15:28:03Z","pushed_at":"2017-02-22T16:29:59Z","git_url":"git://github.com/dotnet/coreclr.git","ssh_url":"git@github.com:dotnet/coreclr.git","clone_url":"https://github.com/dotnet/coreclr.git","svn_url":"https://github.com/dotnet/coreclr","homepage":"https://docs.microsoft.com/dotnet/","size":140604,"stargazers_count":7426,"watchers_count":7426,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1847,"mirror_url":null,"open_issues_count":1190,"forks":1847,"open_issues":1190,"watchers":7426,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/9710"},"html":{"href":"https://github.com/dotnet/coreclr/pull/9710"},"issue":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/9710"},"comments":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/9710/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/9710/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/9710/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/coreclr/statuses/6550022abaf7e49cd4dd41a82e9e4953d3cfa85b"}}}}
{"actor":{"display_login":"sivarv"}}