{"action":"opened","number":7,"pull_request":{"url":"https://api.github.com/repos/lamby/python-gfshare/pulls/7","id":158214469,"html_url":"https://github.com/lamby/python-gfshare/pull/7","diff_url":"https://github.com/lamby/python-gfshare/pull/7.diff","patch_url":"https://github.com/lamby/python-gfshare/pull/7.patch","issue_url":"https://api.github.com/repos/lamby/python-gfshare/issues/7","number":7,"state":"open","locked":false,"title":"gfshare: Fix malloc uses, add one free","user":{"login":"mc10","id":1146876,"avatar_url":"https://avatars1.githubusercontent.com/u/1146876?v=4","gravatar_id":"","url":"https://api.github.com/users/mc10","html_url":"https://github.com/mc10","followers_url":"https://api.github.com/users/mc10/followers","following_url":"https://api.github.com/users/mc10/following{/other_user}","gists_url":"https://api.github.com/users/mc10/gists{/gist_id}","starred_url":"https://api.github.com/users/mc10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mc10/subscriptions","organizations_url":"https://api.github.com/users/mc10/orgs","repos_url":"https://api.github.com/users/mc10/repos","events_url":"https://api.github.com/users/mc10/events{/privacy}","received_events_url":"https://api.github.com/users/mc10/received_events","type":"User","site_admin":false},"body":"`sizeof(*var)` where `var` is a `char *` isn't necessary, but it's nice for consistency. I believe the `malloc` calls for `secret` are missing a `+ 1`, as I noticed the use of `strlen` in one of the cases, but feel free to correct me if I'm wrong.","created_at":"2017-12-13T21:50:54Z","updated_at":"2017-12-13T21:50:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/lamby/python-gfshare/pulls/7/commits","review_comments_url":"https://api.github.com/repos/lamby/python-gfshare/pulls/7/comments","review_comment_url":"https://api.github.com/repos/lamby/python-gfshare/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lamby/python-gfshare/issues/7/comments","statuses_url":"https://api.github.com/repos/lamby/python-gfshare/statuses/662757fbe5e21b096ea286f9847025573c4ee454","head":{"label":"mc10:patch-1","ref":"patch-1","sha":"662757fbe5e21b096ea286f9847025573c4ee454","user":{"login":"mc10","id":1146876,"avatar_url":"https://avatars1.githubusercontent.com/u/1146876?v=4","gravatar_id":"","url":"https://api.github.com/users/mc10","html_url":"https://github.com/mc10","followers_url":"https://api.github.com/users/mc10/followers","following_url":"https://api.github.com/users/mc10/following{/other_user}","gists_url":"https://api.github.com/users/mc10/gists{/gist_id}","starred_url":"https://api.github.com/users/mc10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mc10/subscriptions","organizations_url":"https://api.github.com/users/mc10/orgs","repos_url":"https://api.github.com/users/mc10/repos","events_url":"https://api.github.com/users/mc10/events{/privacy}","received_events_url":"https://api.github.com/users/mc10/received_events","type":"User","site_admin":false},"repo":{"id":114160952,"name":"python-gfshare","full_name":"mc10/python-gfshare","owner":{"login":"mc10","id":1146876,"avatar_url":"https://avatars1.githubusercontent.com/u/1146876?v=4","gravatar_id":"","url":"https://api.github.com/users/mc10","html_url":"https://github.com/mc10","followers_url":"https://api.github.com/users/mc10/followers","following_url":"https://api.github.com/users/mc10/following{/other_user}","gists_url":"https://api.github.com/users/mc10/gists{/gist_id}","starred_url":"https://api.github.com/users/mc10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mc10/subscriptions","organizations_url":"https://api.github.com/users/mc10/orgs","repos_url":"https://api.github.com/users/mc10/repos","events_url":"https://api.github.com/users/mc10/events{/privacy}","received_events_url":"https://api.github.com/users/mc10/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mc10/python-gfshare","description":"Python interface to libgfshare","fork":true,"url":"https://api.github.com/repos/mc10/python-gfshare","forks_url":"https://api.github.com/repos/mc10/python-gfshare/forks","keys_url":"https://api.github.com/repos/mc10/python-gfshare/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mc10/python-gfshare/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mc10/python-gfshare/teams","hooks_url":"https://api.github.com/repos/mc10/python-gfshare/hooks","issue_events_url":"https://api.github.com/repos/mc10/python-gfshare/issues/events{/number}","events_url":"https://api.github.com/repos/mc10/python-gfshare/events","assignees_url":"https://api.github.com/repos/mc10/python-gfshare/assignees{/user}","branches_url":"https://api.github.com/repos/mc10/python-gfshare/branches{/branch}","tags_url":"https://api.github.com/repos/mc10/python-gfshare/tags","blobs_url":"https://api.github.com/repos/mc10/python-gfshare/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mc10/python-gfshare/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mc10/python-gfshare/git/refs{/sha}","trees_url":"https://api.github.com/repos/mc10/python-gfshare/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mc10/python-gfshare/statuses/{sha}","languages_url":"https://api.github.com/repos/mc10/python-gfshare/languages","stargazers_url":"https://api.github.com/repos/mc10/python-gfshare/stargazers","contributors_url":"https://api.github.com/repos/mc10/python-gfshare/contributors","subscribers_url":"https://api.github.com/repos/mc10/python-gfshare/subscribers","subscription_url":"https://api.github.com/repos/mc10/python-gfshare/subscription","commits_url":"https://api.github.com/repos/mc10/python-gfshare/commits{/sha}","git_commits_url":"https://api.github.com/repos/mc10/python-gfshare/git/commits{/sha}","comments_url":"https://api.github.com/repos/mc10/python-gfshare/comments{/number}","issue_comment_url":"https://api.github.com/repos/mc10/python-gfshare/issues/comments{/number}","contents_url":"https://api.github.com/repos/mc10/python-gfshare/contents/{+path}","compare_url":"https://api.github.com/repos/mc10/python-gfshare/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mc10/python-gfshare/merges","archive_url":"https://api.github.com/repos/mc10/python-gfshare/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mc10/python-gfshare/downloads","issues_url":"https://api.github.com/repos/mc10/python-gfshare/issues{/number}","pulls_url":"https://api.github.com/repos/mc10/python-gfshare/pulls{/number}","milestones_url":"https://api.github.com/repos/mc10/python-gfshare/milestones{/number}","notifications_url":"https://api.github.com/repos/mc10/python-gfshare/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mc10/python-gfshare/labels{/name}","releases_url":"https://api.github.com/repos/mc10/python-gfshare/releases{/id}","deployments_url":"https://api.github.com/repos/mc10/python-gfshare/deployments","created_at":"2017-12-13T19:32:11Z","updated_at":"2017-12-13T19:32:14Z","pushed_at":"2017-12-13T19:47:54Z","git_url":"git://github.com/mc10/python-gfshare.git","ssh_url":"git@github.com:mc10/python-gfshare.git","clone_url":"https://github.com/mc10/python-gfshare.git","svn_url":"https://github.com/mc10/python-gfshare","homepage":"https://chris-lamb.co.uk/projects/python-gfshare","size":197,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lamby:master","ref":"master","sha":"3f37565411218de87c2f100eb04a8d85a038e8ca","user":{"login":"lamby","id":133209,"avatar_url":"https://avatars3.githubusercontent.com/u/133209?v=4","gravatar_id":"","url":"https://api.github.com/users/lamby","html_url":"https://github.com/lamby","followers_url":"https://api.github.com/users/lamby/followers","following_url":"https://api.github.com/users/lamby/following{/other_user}","gists_url":"https://api.github.com/users/lamby/gists{/gist_id}","starred_url":"https://api.github.com/users/lamby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lamby/subscriptions","organizations_url":"https://api.github.com/users/lamby/orgs","repos_url":"https://api.github.com/users/lamby/repos","events_url":"https://api.github.com/users/lamby/events{/privacy}","received_events_url":"https://api.github.com/users/lamby/received_events","type":"User","site_admin":false},"repo":{"id":101277427,"name":"python-gfshare","full_name":"lamby/python-gfshare","owner":{"login":"lamby","id":133209,"avatar_url":"https://avatars3.githubusercontent.com/u/133209?v=4","gravatar_id":"","url":"https://api.github.com/users/lamby","html_url":"https://github.com/lamby","followers_url":"https://api.github.com/users/lamby/followers","following_url":"https://api.github.com/users/lamby/following{/other_user}","gists_url":"https://api.github.com/users/lamby/gists{/gist_id}","starred_url":"https://api.github.com/users/lamby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lamby/subscriptions","organizations_url":"https://api.github.com/users/lamby/orgs","repos_url":"https://api.github.com/users/lamby/repos","events_url":"https://api.github.com/users/lamby/events{/privacy}","received_events_url":"https://api.github.com/users/lamby/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lamby/python-gfshare","description":"Python interface to libgfshare","fork":false,"url":"https://api.github.com/repos/lamby/python-gfshare","forks_url":"https://api.github.com/repos/lamby/python-gfshare/forks","keys_url":"https://api.github.com/repos/lamby/python-gfshare/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lamby/python-gfshare/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lamby/python-gfshare/teams","hooks_url":"https://api.github.com/repos/lamby/python-gfshare/hooks","issue_events_url":"https://api.github.com/repos/lamby/python-gfshare/issues/events{/number}","events_url":"https://api.github.com/repos/lamby/python-gfshare/events","assignees_url":"https://api.github.com/repos/lamby/python-gfshare/assignees{/user}","branches_url":"https://api.github.com/repos/lamby/python-gfshare/branches{/branch}","tags_url":"https://api.github.com/repos/lamby/python-gfshare/tags","blobs_url":"https://api.github.com/repos/lamby/python-gfshare/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lamby/python-gfshare/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lamby/python-gfshare/git/refs{/sha}","trees_url":"https://api.github.com/repos/lamby/python-gfshare/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lamby/python-gfshare/statuses/{sha}","languages_url":"https://api.github.com/repos/lamby/python-gfshare/languages","stargazers_url":"https://api.github.com/repos/lamby/python-gfshare/stargazers","contributors_url":"https://api.github.com/repos/lamby/python-gfshare/contributors","subscribers_url":"https://api.github.com/repos/lamby/python-gfshare/subscribers","subscription_url":"https://api.github.com/repos/lamby/python-gfshare/subscription","commits_url":"https://api.github.com/repos/lamby/python-gfshare/commits{/sha}","git_commits_url":"https://api.github.com/repos/lamby/python-gfshare/git/commits{/sha}","comments_url":"https://api.github.com/repos/lamby/python-gfshare/comments{/number}","issue_comment_url":"https://api.github.com/repos/lamby/python-gfshare/issues/comments{/number}","contents_url":"https://api.github.com/repos/lamby/python-gfshare/contents/{+path}","compare_url":"https://api.github.com/repos/lamby/python-gfshare/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lamby/python-gfshare/merges","archive_url":"https://api.github.com/repos/lamby/python-gfshare/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lamby/python-gfshare/downloads","issues_url":"https://api.github.com/repos/lamby/python-gfshare/issues{/number}","pulls_url":"https://api.github.com/repos/lamby/python-gfshare/pulls{/number}","milestones_url":"https://api.github.com/repos/lamby/python-gfshare/milestones{/number}","notifications_url":"https://api.github.com/repos/lamby/python-gfshare/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lamby/python-gfshare/labels{/name}","releases_url":"https://api.github.com/repos/lamby/python-gfshare/releases{/id}","deployments_url":"https://api.github.com/repos/lamby/python-gfshare/deployments","created_at":"2017-08-24T09:24:39Z","updated_at":"2017-10-17T00:06:50Z","pushed_at":"2017-12-09T22:12:14Z","git_url":"git://github.com/lamby/python-gfshare.git","ssh_url":"git@github.com:lamby/python-gfshare.git","clone_url":"https://github.com/lamby/python-gfshare.git","svn_url":"https://github.com/lamby/python-gfshare","homepage":"https://chris-lamb.co.uk/projects/python-gfshare","size":192,"stargazers_count":7,"watchers_count":7,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1,"open_issues":1,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lamby/python-gfshare/pulls/7"},"html":{"href":"https://github.com/lamby/python-gfshare/pull/7"},"issue":{"href":"https://api.github.com/repos/lamby/python-gfshare/issues/7"},"comments":{"href":"https://api.github.com/repos/lamby/python-gfshare/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/lamby/python-gfshare/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/lamby/python-gfshare/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lamby/python-gfshare/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/lamby/python-gfshare/statuses/662757fbe5e21b096ea286f9847025573c4ee454"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":11,"deletions":7,"changed_files":1}}
{"actor":{"display_login":"mc10"}}