{"action":"created","issue":{"url":"https://api.github.com/repos/desktop/desktop/issues/2596","repository_url":"https://api.github.com/repos/desktop/desktop","labels_url":"https://api.github.com/repos/desktop/desktop/issues/2596/labels{/name}","comments_url":"https://api.github.com/repos/desktop/desktop/issues/2596/comments","events_url":"https://api.github.com/repos/desktop/desktop/issues/2596/events","html_url":"https://github.com/desktop/desktop/issues/2596","id":254494958,"number":2596,"title":"introduce some soft limits around diff rendering","user":{"login":"shiftkey","id":359239,"avatar_url":"https://avatars2.githubusercontent.com/u/359239?v=4","gravatar_id":"","url":"https://api.github.com/users/shiftkey","html_url":"https://github.com/shiftkey","followers_url":"https://api.github.com/users/shiftkey/followers","following_url":"https://api.github.com/users/shiftkey/following{/other_user}","gists_url":"https://api.github.com/users/shiftkey/gists{/gist_id}","starred_url":"https://api.github.com/users/shiftkey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shiftkey/subscriptions","organizations_url":"https://api.github.com/users/shiftkey/orgs","repos_url":"https://api.github.com/users/shiftkey/repos","events_url":"https://api.github.com/users/shiftkey/events{/privacy}","received_events_url":"https://api.github.com/users/shiftkey/received_events","type":"User","site_admin":true},"labels":[{"id":374514539,"url":"https://api.github.com/repos/desktop/desktop/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-08-31T23:19:36Z","updated_at":"2017-09-22T14:57:51Z","closed_at":null,"author_association":"OWNER","body":"The client apps have historically been indifferent to large diffs, whereas GitHub the Website is very rigid about some diffs - requiring users to opt-in to view them.\r\n\r\n<img width=\"1117\" alt=\"screen shot 2017-09-01 at 9 14 53 am\" src=\"https://user-images.githubusercontent.com/359239/29949143-0fb79382-8ef6-11e7-8b00-697ca6c86317.png\">\r\n\r\nAs discussed in https://github.com/desktop/desktop/issues/1686#issuecomment-326443927 - there may be some diff sizes and shapes that make the editor cry (ridiculously long lines with wrapping enabled seems to be what currently hurts Codemirror). Until we have time to revisit our choice of diff experience (post 1.0 at least), I'd love to get some feels from @desktop/core on warning users about large diffs to keep things snappy.\r\n\r\nFor sake of simplicity and not using it as crutch, I'd rather not make this configurable at all to the user - for diffs over a certain size, display a message first and require the user to click to see it."},"comment":{"url":"https://api.github.com/repos/desktop/desktop/issues/comments/331471037","html_url":"https://github.com/desktop/desktop/issues/2596#issuecomment-331471037","issue_url":"https://api.github.com/repos/desktop/desktop/issues/2596","id":331471037,"user":{"login":"benrondeau","id":5001219,"avatar_url":"https://avatars2.githubusercontent.com/u/5001219?v=4","gravatar_id":"","url":"https://api.github.com/users/benrondeau","html_url":"https://github.com/benrondeau","followers_url":"https://api.github.com/users/benrondeau/followers","following_url":"https://api.github.com/users/benrondeau/following{/other_user}","gists_url":"https://api.github.com/users/benrondeau/gists{/gist_id}","starred_url":"https://api.github.com/users/benrondeau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benrondeau/subscriptions","organizations_url":"https://api.github.com/users/benrondeau/orgs","repos_url":"https://api.github.com/users/benrondeau/repos","events_url":"https://api.github.com/users/benrondeau/events{/privacy}","received_events_url":"https://api.github.com/users/benrondeau/received_events","type":"User","site_admin":false},"created_at":"2017-09-22T14:57:51Z","updated_at":"2017-09-22T14:57:51Z","author_association":"NONE","body":"Any update on this issue?\r\n"}}
{"actor":{"display_login":"benrondeau"}}