{"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/100668511","pull_request_review_id":21386869,"id":100668511,"diff_hunk":"@@ -0,0 +1,26 @@\n+{ stdenv, fetchFromGitHub, cmake }:","path":"pkgs/development/libraries/range-v3/default.nix","position":null,"original_position":1,"commit_id":"a73f0710dc87eb33ebacc753c9067dded0c3ba85","original_commit_id":"c3fdfb0df339054f65df140b4da32ff4b01ce18a","user":{"login":"xwvvvvwx","id":6689924,"avatar_url":"https://avatars.githubusercontent.com/u/6689924?v=3","gravatar_id":"","url":"https://api.github.com/users/xwvvvvwx","html_url":"https://github.com/xwvvvvwx","followers_url":"https://api.github.com/users/xwvvvvwx/followers","following_url":"https://api.github.com/users/xwvvvvwx/following{/other_user}","gists_url":"https://api.github.com/users/xwvvvvwx/gists{/gist_id}","starred_url":"https://api.github.com/users/xwvvvvwx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xwvvvvwx/subscriptions","organizations_url":"https://api.github.com/users/xwvvvvwx/orgs","repos_url":"https://api.github.com/users/xwvvvvwx/repos","events_url":"https://api.github.com/users/xwvvvvwx/events{/privacy}","received_events_url":"https://api.github.com/users/xwvvvvwx/received_events","type":"User","site_admin":false},"body":"thanks! fixed :)","created_at":"2017-02-11T14:33:38Z","updated_at":"2017-02-11T14:33:38Z","html_url":"https://github.com/NixOS/nixpkgs/pull/22661#discussion_r100668511","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/22661","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/100668511"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/22661#discussion_r100668511"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/22661"}}},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/22661","id":105751689,"html_url":"https://github.com/NixOS/nixpkgs/pull/22661","diff_url":"https://github.com/NixOS/nixpkgs/pull/22661.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/22661.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/22661","number":22661,"state":"open","locked":false,"title":"range-v3: init at 2017-01-30","user":{"login":"xwvvvvwx","id":6689924,"avatar_url":"https://avatars.githubusercontent.com/u/6689924?v=3","gravatar_id":"","url":"https://api.github.com/users/xwvvvvwx","html_url":"https://github.com/xwvvvvwx","followers_url":"https://api.github.com/users/xwvvvvwx/followers","following_url":"https://api.github.com/users/xwvvvvwx/following{/other_user}","gists_url":"https://api.github.com/users/xwvvvvwx/gists{/gist_id}","starred_url":"https://api.github.com/users/xwvvvvwx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xwvvvvwx/subscriptions","organizations_url":"https://api.github.com/users/xwvvvvwx/orgs","repos_url":"https://api.github.com/users/xwvvvvwx/repos","events_url":"https://api.github.com/users/xwvvvvwx/events{/privacy}","received_events_url":"https://api.github.com/users/xwvvvvwx/received_events","type":"User","site_admin":false},"body":"###### Motivation for this change\r\n\r\nAdd the range-v3 c++ library\r\n\r\n###### Things done\r\n\r\n- [x] Tested using sandboxing\r\n  ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS,\r\n    or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file)\r\n    on non-NixOS)\r\n- Built on platform(s)\r\n   - [x] NixOS\r\n   - [ ] macOS\r\n   - [ ] Linux\r\n- [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [x] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\nAs a side note I decided not to run the test suite was that the correct choice? ","created_at":"2017-02-11T12:04:06Z","updated_at":"2017-02-11T14:33:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"40e4d054bdb813713cf598406df6c52b5967a636","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/22661/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/22661/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/22661/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/a73f0710dc87eb33ebacc753c9067dded0c3ba85","head":{"label":"xwvvvvwx:add-range-v3","ref":"add-range-v3","sha":"a73f0710dc87eb33ebacc753c9067dded0c3ba85","user":{"login":"xwvvvvwx","id":6689924,"avatar_url":"https://avatars.githubusercontent.com/u/6689924?v=3","gravatar_id":"","url":"https://api.github.com/users/xwvvvvwx","html_url":"https://github.com/xwvvvvwx","followers_url":"https://api.github.com/users/xwvvvvwx/followers","following_url":"https://api.github.com/users/xwvvvvwx/following{/other_user}","gists_url":"https://api.github.com/users/xwvvvvwx/gists{/gist_id}","starred_url":"https://api.github.com/users/xwvvvvwx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xwvvvvwx/subscriptions","organizations_url":"https://api.github.com/users/xwvvvvwx/orgs","repos_url":"https://api.github.com/users/xwvvvvwx/repos","events_url":"https://api.github.com/users/xwvvvvwx/events{/privacy}","received_events_url":"https://api.github.com/users/xwvvvvwx/received_events","type":"User","site_admin":false},"repo":{"id":75770621,"name":"nixpkgs","full_name":"xwvvvvwx/nixpkgs","owner":{"login":"xwvvvvwx","id":6689924,"avatar_url":"https://avatars.githubusercontent.com/u/6689924?v=3","gravatar_id":"","url":"https://api.github.com/users/xwvvvvwx","html_url":"https://github.com/xwvvvvwx","followers_url":"https://api.github.com/users/xwvvvvwx/followers","following_url":"https://api.github.com/users/xwvvvvwx/following{/other_user}","gists_url":"https://api.github.com/users/xwvvvvwx/gists{/gist_id}","starred_url":"https://api.github.com/users/xwvvvvwx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xwvvvvwx/subscriptions","organizations_url":"https://api.github.com/users/xwvvvvwx/orgs","repos_url":"https://api.github.com/users/xwvvvvwx/repos","events_url":"https://api.github.com/users/xwvvvvwx/events{/privacy}","received_events_url":"https://api.github.com/users/xwvvvvwx/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xwvvvvwx/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/xwvvvvwx/nixpkgs","forks_url":"https://api.github.com/repos/xwvvvvwx/nixpkgs/forks","keys_url":"https://api.github.com/repos/xwvvvvwx/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xwvvvvwx/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xwvvvvwx/nixpkgs/teams","hooks_url":"https://api.github.com/repos/xwvvvvwx/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/xwvvvvwx/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/xwvvvvwx/nixpkgs/events","assignees_url":"https://api.github.com/repos/xwvvvvwx/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/xwvvvvwx/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/xwvvvvwx/nixpkgs/tags","blobs_url":"https://api.github.com/repos/xwvvvvwx/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xwvvvvwx/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xwvvvvwx/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/xwvvvvwx/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xwvvvvwx/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/xwvvvvwx/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/xwvvvvwx/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/xwvvvvwx/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/xwvvvvwx/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/xwvvvvwx/nixpkgs/subscription","commits_url":"https://api.github.com/repos/xwvvvvwx/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/xwvvvvwx/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/xwvvvvwx/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/xwvvvvwx/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/xwvvvvwx/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/xwvvvvwx/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xwvvvvwx/nixpkgs/merges","archive_url":"https://api.github.com/repos/xwvvvvwx/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xwvvvvwx/nixpkgs/downloads","issues_url":"https://api.github.com/repos/xwvvvvwx/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/xwvvvvwx/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/xwvvvvwx/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/xwvvvvwx/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xwvvvvwx/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/xwvvvvwx/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/xwvvvvwx/nixpkgs/deployments","created_at":"2016-12-06T20:54:52Z","updated_at":"2016-12-06T20:55:15Z","pushed_at":"2017-02-11T14:33:16Z","git_url":"git://github.com/xwvvvvwx/nixpkgs.git","ssh_url":"git@github.com:xwvvvvwx/nixpkgs.git","clone_url":"https://github.com/xwvvvvwx/nixpkgs.git","svn_url":"https://github.com/xwvvvvwx/nixpkgs","homepage":null,"size":393222,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"d4bf624f968fa7b94988080be231285a95ea2ce8","user":{"login":"NixOS","id":487568,"avatar_url":"https://avatars.githubusercontent.com/u/487568?v=3","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"name":"nixpkgs","full_name":"NixOS/nixpkgs","owner":{"login":"NixOS","id":487568,"avatar_url":"https://avatars.githubusercontent.com/u/487568?v=3","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2017-02-10T17:20:10Z","pushed_at":"2017-02-11T14:33:19Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":396998,"stargazers_count":1500,"watchers_count":1500,"language":"Nix","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1868,"mirror_url":null,"open_issues_count":1730,"forks":1868,"open_issues":1730,"watchers":1500,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/22661"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/22661"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/22661"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/22661/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/22661/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/22661/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/a73f0710dc87eb33ebacc753c9067dded0c3ba85"}}}}
{"actor":{"display_login":"xwvvvvwx"}}