{"action":"created","comment":{"url":"https://api.github.com/repos/getsentry/sentry/pulls/comments/146877804","pull_request_review_id":71885375,"id":146877804,"diff_hunk":"@@ -8,13 +8,21 @@\n \n from __future__ import absolute_import\n \n+import re\n+import six\n from django.db import models, transaction\n from symbolic import ProcessState\n \n from sentry.constants import LOG_LEVELS_MAP\n from sentry.db.models import FlexibleForeignKey, Model, sane_repr\n from sentry.models.file import File\n \n+_version_re = re.compile(r'(\\d+\\.\\d+\\.\\d+)\\s+(.*)')\n+\n+_minidump_os_mapping = {\n+    'Mac OS X': 'macOS',","path":"src/sentry/models/minidump.py","position":16,"original_position":16,"commit_id":"33a5a7ade8c95f253f15d7aa6e0dc6e522d50cf9","original_commit_id":"33a5a7ade8c95f253f15d7aa6e0dc6e522d50cf9","user":{"login":"jan-auer","id":1433023,"avatar_url":"https://avatars0.githubusercontent.com/u/1433023?v=4","gravatar_id":"","url":"https://api.github.com/users/jan-auer","html_url":"https://github.com/jan-auer","followers_url":"https://api.github.com/users/jan-auer/followers","following_url":"https://api.github.com/users/jan-auer/following{/other_user}","gists_url":"https://api.github.com/users/jan-auer/gists{/gist_id}","starred_url":"https://api.github.com/users/jan-auer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jan-auer/subscriptions","organizations_url":"https://api.github.com/users/jan-auer/orgs","repos_url":"https://api.github.com/users/jan-auer/repos","events_url":"https://api.github.com/users/jan-auer/events{/privacy}","received_events_url":"https://api.github.com/users/jan-auer/received_events","type":"User","site_admin":false},"body":"Breakpad uses a different naming schema for operating systems than what we have hardcoded in the symbolizer. For the sake of keeping this change small, I'm just mapping the names here. However, we should rather try not to use the os name in the pipeline. UI is a separate topic...","created_at":"2017-10-25T14:36:36Z","updated_at":"2017-10-25T14:36:36Z","html_url":"https://github.com/getsentry/sentry/pull/6424#discussion_r146877804","pull_request_url":"https://api.github.com/repos/getsentry/sentry/pulls/6424","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/getsentry/sentry/pulls/comments/146877804"},"html":{"href":"https://github.com/getsentry/sentry/pull/6424#discussion_r146877804"},"pull_request":{"href":"https://api.github.com/repos/getsentry/sentry/pulls/6424"}}},"pull_request":{"url":"https://api.github.com/repos/getsentry/sentry/pulls/6424","id":148684424,"html_url":"https://github.com/getsentry/sentry/pull/6424","diff_url":"https://github.com/getsentry/sentry/pull/6424.diff","patch_url":"https://github.com/getsentry/sentry/pull/6424.patch","issue_url":"https://api.github.com/repos/getsentry/sentry/issues/6424","number":6424,"state":"open","locked":false,"title":"feat: Symbolication of minidump events","user":{"login":"jan-auer","id":1433023,"avatar_url":"https://avatars0.githubusercontent.com/u/1433023?v=4","gravatar_id":"","url":"https://api.github.com/users/jan-auer","html_url":"https://github.com/jan-auer","followers_url":"https://api.github.com/users/jan-auer/followers","following_url":"https://api.github.com/users/jan-auer/following{/other_user}","gists_url":"https://api.github.com/users/jan-auer/gists{/gist_id}","starred_url":"https://api.github.com/users/jan-auer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jan-auer/subscriptions","organizations_url":"https://api.github.com/users/jan-auer/orgs","repos_url":"https://api.github.com/users/jan-auer/repos","events_url":"https://api.github.com/users/jan-auer/events{/privacy}","received_events_url":"https://api.github.com/users/jan-auer/received_events","type":"User","site_admin":false},"body":"This is a followup on #6416 and enables frame symbolication without changing much of the current pipeline. CFI stackwalking is still missing, but the scanned stacktraces have sufficient quality.\r\n\r\nSee comments below for a couple of quirks.\r\n\r\n**NOTE**: Since I changed some of the code determining final frames, we might regress with grouping somewhere.","created_at":"2017-10-25T14:28:32Z","updated_at":"2017-10-25T14:36:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ca569124b9375b09f70568bf7437142c47fa284c","assignee":{"login":"jan-auer","id":1433023,"avatar_url":"https://avatars0.githubusercontent.com/u/1433023?v=4","gravatar_id":"","url":"https://api.github.com/users/jan-auer","html_url":"https://github.com/jan-auer","followers_url":"https://api.github.com/users/jan-auer/followers","following_url":"https://api.github.com/users/jan-auer/following{/other_user}","gists_url":"https://api.github.com/users/jan-auer/gists{/gist_id}","starred_url":"https://api.github.com/users/jan-auer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jan-auer/subscriptions","organizations_url":"https://api.github.com/users/jan-auer/orgs","repos_url":"https://api.github.com/users/jan-auer/repos","events_url":"https://api.github.com/users/jan-auer/events{/privacy}","received_events_url":"https://api.github.com/users/jan-auer/received_events","type":"User","site_admin":false},"assignees":[{"login":"jan-auer","id":1433023,"avatar_url":"https://avatars0.githubusercontent.com/u/1433023?v=4","gravatar_id":"","url":"https://api.github.com/users/jan-auer","html_url":"https://github.com/jan-auer","followers_url":"https://api.github.com/users/jan-auer/followers","following_url":"https://api.github.com/users/jan-auer/following{/other_user}","gists_url":"https://api.github.com/users/jan-auer/gists{/gist_id}","starred_url":"https://api.github.com/users/jan-auer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jan-auer/subscriptions","organizations_url":"https://api.github.com/users/jan-auer/orgs","repos_url":"https://api.github.com/users/jan-auer/repos","events_url":"https://api.github.com/users/jan-auer/events{/privacy}","received_events_url":"https://api.github.com/users/jan-auer/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"mitsuhiko","id":7396,"avatar_url":"https://avatars1.githubusercontent.com/u/7396?v=4","gravatar_id":"","url":"https://api.github.com/users/mitsuhiko","html_url":"https://github.com/mitsuhiko","followers_url":"https://api.github.com/users/mitsuhiko/followers","following_url":"https://api.github.com/users/mitsuhiko/following{/other_user}","gists_url":"https://api.github.com/users/mitsuhiko/gists{/gist_id}","starred_url":"https://api.github.com/users/mitsuhiko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitsuhiko/subscriptions","organizations_url":"https://api.github.com/users/mitsuhiko/orgs","repos_url":"https://api.github.com/users/mitsuhiko/repos","events_url":"https://api.github.com/users/mitsuhiko/events{/privacy}","received_events_url":"https://api.github.com/users/mitsuhiko/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/getsentry/sentry/pulls/6424/commits","review_comments_url":"https://api.github.com/repos/getsentry/sentry/pulls/6424/comments","review_comment_url":"https://api.github.com/repos/getsentry/sentry/pulls/comments{/number}","comments_url":"https://api.github.com/repos/getsentry/sentry/issues/6424/comments","statuses_url":"https://api.github.com/repos/getsentry/sentry/statuses/33a5a7ade8c95f253f15d7aa6e0dc6e522d50cf9","head":{"label":"getsentry:feat/minidump-symbolication","ref":"feat/minidump-symbolication","sha":"33a5a7ade8c95f253f15d7aa6e0dc6e522d50cf9","user":{"login":"getsentry","id":1396951,"avatar_url":"https://avatars0.githubusercontent.com/u/1396951?v=4","gravatar_id":"","url":"https://api.github.com/users/getsentry","html_url":"https://github.com/getsentry","followers_url":"https://api.github.com/users/getsentry/followers","following_url":"https://api.github.com/users/getsentry/following{/other_user}","gists_url":"https://api.github.com/users/getsentry/gists{/gist_id}","starred_url":"https://api.github.com/users/getsentry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getsentry/subscriptions","organizations_url":"https://api.github.com/users/getsentry/orgs","repos_url":"https://api.github.com/users/getsentry/repos","events_url":"https://api.github.com/users/getsentry/events{/privacy}","received_events_url":"https://api.github.com/users/getsentry/received_events","type":"Organization","site_admin":false},"repo":{"id":873328,"name":"sentry","full_name":"getsentry/sentry","owner":{"login":"getsentry","id":1396951,"avatar_url":"https://avatars0.githubusercontent.com/u/1396951?v=4","gravatar_id":"","url":"https://api.github.com/users/getsentry","html_url":"https://github.com/getsentry","followers_url":"https://api.github.com/users/getsentry/followers","following_url":"https://api.github.com/users/getsentry/following{/other_user}","gists_url":"https://api.github.com/users/getsentry/gists{/gist_id}","starred_url":"https://api.github.com/users/getsentry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getsentry/subscriptions","organizations_url":"https://api.github.com/users/getsentry/orgs","repos_url":"https://api.github.com/users/getsentry/repos","events_url":"https://api.github.com/users/getsentry/events{/privacy}","received_events_url":"https://api.github.com/users/getsentry/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/getsentry/sentry","description":"Sentry is a cross-platform crash reporting and aggregation platform.","fork":false,"url":"https://api.github.com/repos/getsentry/sentry","forks_url":"https://api.github.com/repos/getsentry/sentry/forks","keys_url":"https://api.github.com/repos/getsentry/sentry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/getsentry/sentry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/getsentry/sentry/teams","hooks_url":"https://api.github.com/repos/getsentry/sentry/hooks","issue_events_url":"https://api.github.com/repos/getsentry/sentry/issues/events{/number}","events_url":"https://api.github.com/repos/getsentry/sentry/events","assignees_url":"https://api.github.com/repos/getsentry/sentry/assignees{/user}","branches_url":"https://api.github.com/repos/getsentry/sentry/branches{/branch}","tags_url":"https://api.github.com/repos/getsentry/sentry/tags","blobs_url":"https://api.github.com/repos/getsentry/sentry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/getsentry/sentry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/getsentry/sentry/git/refs{/sha}","trees_url":"https://api.github.com/repos/getsentry/sentry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/getsentry/sentry/statuses/{sha}","languages_url":"https://api.github.com/repos/getsentry/sentry/languages","stargazers_url":"https://api.github.com/repos/getsentry/sentry/stargazers","contributors_url":"https://api.github.com/repos/getsentry/sentry/contributors","subscribers_url":"https://api.github.com/repos/getsentry/sentry/subscribers","subscription_url":"https://api.github.com/repos/getsentry/sentry/subscription","commits_url":"https://api.github.com/repos/getsentry/sentry/commits{/sha}","git_commits_url":"https://api.github.com/repos/getsentry/sentry/git/commits{/sha}","comments_url":"https://api.github.com/repos/getsentry/sentry/comments{/number}","issue_comment_url":"https://api.github.com/repos/getsentry/sentry/issues/comments{/number}","contents_url":"https://api.github.com/repos/getsentry/sentry/contents/{+path}","compare_url":"https://api.github.com/repos/getsentry/sentry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/getsentry/sentry/merges","archive_url":"https://api.github.com/repos/getsentry/sentry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/getsentry/sentry/downloads","issues_url":"https://api.github.com/repos/getsentry/sentry/issues{/number}","pulls_url":"https://api.github.com/repos/getsentry/sentry/pulls{/number}","milestones_url":"https://api.github.com/repos/getsentry/sentry/milestones{/number}","notifications_url":"https://api.github.com/repos/getsentry/sentry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/getsentry/sentry/labels{/name}","releases_url":"https://api.github.com/repos/getsentry/sentry/releases{/id}","deployments_url":"https://api.github.com/repos/getsentry/sentry/deployments","created_at":"2010-08-30T22:06:41Z","updated_at":"2017-10-25T14:23:48Z","pushed_at":"2017-10-25T14:28:33Z","git_url":"git://github.com/getsentry/sentry.git","ssh_url":"git@github.com:getsentry/sentry.git","clone_url":"https://github.com/getsentry/sentry.git","svn_url":"https://github.com/getsentry/sentry","homepage":"https://sentry.io","size":73393,"stargazers_count":14296,"watchers_count":14296,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1736,"mirror_url":null,"archived":false,"open_issues_count":669,"forks":1736,"open_issues":669,"watchers":14296,"default_branch":"master"}},"base":{"label":"getsentry:master","ref":"master","sha":"8f9648df60040b89c1c95ca07b70b1007e5ed31b","user":{"login":"getsentry","id":1396951,"avatar_url":"https://avatars0.githubusercontent.com/u/1396951?v=4","gravatar_id":"","url":"https://api.github.com/users/getsentry","html_url":"https://github.com/getsentry","followers_url":"https://api.github.com/users/getsentry/followers","following_url":"https://api.github.com/users/getsentry/following{/other_user}","gists_url":"https://api.github.com/users/getsentry/gists{/gist_id}","starred_url":"https://api.github.com/users/getsentry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getsentry/subscriptions","organizations_url":"https://api.github.com/users/getsentry/orgs","repos_url":"https://api.github.com/users/getsentry/repos","events_url":"https://api.github.com/users/getsentry/events{/privacy}","received_events_url":"https://api.github.com/users/getsentry/received_events","type":"Organization","site_admin":false},"repo":{"id":873328,"name":"sentry","full_name":"getsentry/sentry","owner":{"login":"getsentry","id":1396951,"avatar_url":"https://avatars0.githubusercontent.com/u/1396951?v=4","gravatar_id":"","url":"https://api.github.com/users/getsentry","html_url":"https://github.com/getsentry","followers_url":"https://api.github.com/users/getsentry/followers","following_url":"https://api.github.com/users/getsentry/following{/other_user}","gists_url":"https://api.github.com/users/getsentry/gists{/gist_id}","starred_url":"https://api.github.com/users/getsentry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getsentry/subscriptions","organizations_url":"https://api.github.com/users/getsentry/orgs","repos_url":"https://api.github.com/users/getsentry/repos","events_url":"https://api.github.com/users/getsentry/events{/privacy}","received_events_url":"https://api.github.com/users/getsentry/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/getsentry/sentry","description":"Sentry is a cross-platform crash reporting and aggregation platform.","fork":false,"url":"https://api.github.com/repos/getsentry/sentry","forks_url":"https://api.github.com/repos/getsentry/sentry/forks","keys_url":"https://api.github.com/repos/getsentry/sentry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/getsentry/sentry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/getsentry/sentry/teams","hooks_url":"https://api.github.com/repos/getsentry/sentry/hooks","issue_events_url":"https://api.github.com/repos/getsentry/sentry/issues/events{/number}","events_url":"https://api.github.com/repos/getsentry/sentry/events","assignees_url":"https://api.github.com/repos/getsentry/sentry/assignees{/user}","branches_url":"https://api.github.com/repos/getsentry/sentry/branches{/branch}","tags_url":"https://api.github.com/repos/getsentry/sentry/tags","blobs_url":"https://api.github.com/repos/getsentry/sentry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/getsentry/sentry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/getsentry/sentry/git/refs{/sha}","trees_url":"https://api.github.com/repos/getsentry/sentry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/getsentry/sentry/statuses/{sha}","languages_url":"https://api.github.com/repos/getsentry/sentry/languages","stargazers_url":"https://api.github.com/repos/getsentry/sentry/stargazers","contributors_url":"https://api.github.com/repos/getsentry/sentry/contributors","subscribers_url":"https://api.github.com/repos/getsentry/sentry/subscribers","subscription_url":"https://api.github.com/repos/getsentry/sentry/subscription","commits_url":"https://api.github.com/repos/getsentry/sentry/commits{/sha}","git_commits_url":"https://api.github.com/repos/getsentry/sentry/git/commits{/sha}","comments_url":"https://api.github.com/repos/getsentry/sentry/comments{/number}","issue_comment_url":"https://api.github.com/repos/getsentry/sentry/issues/comments{/number}","contents_url":"https://api.github.com/repos/getsentry/sentry/contents/{+path}","compare_url":"https://api.github.com/repos/getsentry/sentry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/getsentry/sentry/merges","archive_url":"https://api.github.com/repos/getsentry/sentry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/getsentry/sentry/downloads","issues_url":"https://api.github.com/repos/getsentry/sentry/issues{/number}","pulls_url":"https://api.github.com/repos/getsentry/sentry/pulls{/number}","milestones_url":"https://api.github.com/repos/getsentry/sentry/milestones{/number}","notifications_url":"https://api.github.com/repos/getsentry/sentry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/getsentry/sentry/labels{/name}","releases_url":"https://api.github.com/repos/getsentry/sentry/releases{/id}","deployments_url":"https://api.github.com/repos/getsentry/sentry/deployments","created_at":"2010-08-30T22:06:41Z","updated_at":"2017-10-25T14:23:48Z","pushed_at":"2017-10-25T14:28:33Z","git_url":"git://github.com/getsentry/sentry.git","ssh_url":"git@github.com:getsentry/sentry.git","clone_url":"https://github.com/getsentry/sentry.git","svn_url":"https://github.com/getsentry/sentry","homepage":"https://sentry.io","size":73393,"stargazers_count":14296,"watchers_count":14296,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1736,"mirror_url":null,"archived":false,"open_issues_count":669,"forks":1736,"open_issues":669,"watchers":14296,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/getsentry/sentry/pulls/6424"},"html":{"href":"https://github.com/getsentry/sentry/pull/6424"},"issue":{"href":"https://api.github.com/repos/getsentry/sentry/issues/6424"},"comments":{"href":"https://api.github.com/repos/getsentry/sentry/issues/6424/comments"},"review_comments":{"href":"https://api.github.com/repos/getsentry/sentry/pulls/6424/comments"},"review_comment":{"href":"https://api.github.com/repos/getsentry/sentry/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/getsentry/sentry/pulls/6424/commits"},"statuses":{"href":"https://api.github.com/repos/getsentry/sentry/statuses/33a5a7ade8c95f253f15d7aa6e0dc6e522d50cf9"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jan-auer"}}