{"action":"created","issue":{"url":"https://api.github.com/repos/apache/spark/issues/17603","repository_url":"https://api.github.com/repos/apache/spark","labels_url":"https://api.github.com/repos/apache/spark/issues/17603/labels{/name}","comments_url":"https://api.github.com/repos/apache/spark/issues/17603/comments","events_url":"https://api.github.com/repos/apache/spark/issues/17603/events","html_url":"https://github.com/apache/spark/pull/17603","id":220850577,"number":17603,"title":"[SPARK-20288] Avoid generating the MapStatus by stageId in BasicSchedulerIntegrationSuite","user":{"login":"jinxing64","id":4058918,"avatar_url":"https://avatars3.githubusercontent.com/u/4058918?v=3","gravatar_id":"","url":"https://api.github.com/users/jinxing64","html_url":"https://github.com/jinxing64","followers_url":"https://api.github.com/users/jinxing64/followers","following_url":"https://api.github.com/users/jinxing64/following{/other_user}","gists_url":"https://api.github.com/users/jinxing64/gists{/gist_id}","starred_url":"https://api.github.com/users/jinxing64/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jinxing64/subscriptions","organizations_url":"https://api.github.com/users/jinxing64/orgs","repos_url":"https://api.github.com/users/jinxing64/repos","events_url":"https://api.github.com/users/jinxing64/events{/privacy}","received_events_url":"https://api.github.com/users/jinxing64/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-04-11T06:21:14Z","updated_at":"2017-04-11T06:25:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/17603","html_url":"https://github.com/apache/spark/pull/17603","diff_url":"https://github.com/apache/spark/pull/17603.diff","patch_url":"https://github.com/apache/spark/pull/17603.patch"},"body":"## What changes were proposed in this pull request?\r\n\r\nShuffleId is determined before job submitted. But it's hard to predict stageId by shuffleId.\r\nStage is created in DAGScheduler(\r\nhttps://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala#L381), but the order is n\r\not determined.\r\nI added a log(println(s\"Creating ShufflMapStage-$id on shuffle-${shuffleDep.shuffleId}\")) after (https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala#L331), when testing BasicSchedulerIntegrationSuite:\"multi-stage job\". It will print:\r\nCreating ShufflMapStage-0 on shuffle-0\r\nCreating ShufflMapStage-1 on shuffle-2\r\nCreating ShufflMapStage-2 on shuffle-1\r\nCreating ShufflMapStage-3 on shuffle-3\r\nor\r\nCreating ShufflMapStage-0 on shuffle-1\r\nCreating ShufflMapStage-1 on shuffle-3\r\nCreating ShufflMapStage-2 on shuffle-0\r\nCreating ShufflMapStage-3 on shuffle-2\r\nIt might be better to avoid generating the MapStatus by stageId.\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/apache/spark/issues/comments/293163266","html_url":"https://github.com/apache/spark/pull/17603#issuecomment-293163266","issue_url":"https://api.github.com/repos/apache/spark/issues/17603","id":293163266,"user":{"login":"jinxing64","id":4058918,"avatar_url":"https://avatars3.githubusercontent.com/u/4058918?v=3","gravatar_id":"","url":"https://api.github.com/users/jinxing64","html_url":"https://github.com/jinxing64","followers_url":"https://api.github.com/users/jinxing64/followers","following_url":"https://api.github.com/users/jinxing64/following{/other_user}","gists_url":"https://api.github.com/users/jinxing64/gists{/gist_id}","starred_url":"https://api.github.com/users/jinxing64/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jinxing64/subscriptions","organizations_url":"https://api.github.com/users/jinxing64/orgs","repos_url":"https://api.github.com/users/jinxing64/repos","events_url":"https://api.github.com/users/jinxing64/events{/privacy}","received_events_url":"https://api.github.com/users/jinxing64/received_events","type":"User","site_admin":false},"created_at":"2017-04-11T06:25:37Z","updated_at":"2017-04-11T06:25:37Z","body":"I found this when test https://github.com/apache/spark/pull/17533. It failed now and then when try to get size of reduce from `MapStatus`.\r\n\r\nI'm not sure how to make it better: \r\nModify the test as this pr \r\nor\r\nChange https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala#L380"}}
{"actor":{"display_login":"jinxing64"}}