{"action":"opened","number":300,"pull_request":{"url":"https://api.github.com/repos/nextic/IC/pulls/300","id":137407669,"html_url":"https://github.com/nextic/IC/pull/300","diff_url":"https://github.com/nextic/IC/pull/300.diff","patch_url":"https://github.com/nextic/IC/pull/300.patch","issue_url":"https://api.github.com/repos/nextic/IC/issues/300","number":300,"state":"open","locked":false,"title":"Xy algos","user":{"login":"jjgomezcadenas","id":8070159,"avatar_url":"https://avatars1.githubusercontent.com/u/8070159?v=4","gravatar_id":"","url":"https://api.github.com/users/jjgomezcadenas","html_url":"https://github.com/jjgomezcadenas","followers_url":"https://api.github.com/users/jjgomezcadenas/followers","following_url":"https://api.github.com/users/jjgomezcadenas/following{/other_user}","gists_url":"https://api.github.com/users/jjgomezcadenas/gists{/gist_id}","starred_url":"https://api.github.com/users/jjgomezcadenas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjgomezcadenas/subscriptions","organizations_url":"https://api.github.com/users/jjgomezcadenas/orgs","repos_url":"https://api.github.com/users/jjgomezcadenas/repos","events_url":"https://api.github.com/users/jjgomezcadenas/events{/privacy}","received_events_url":"https://api.github.com/users/jjgomezcadenas/received_events","type":"User","site_admin":false},"body":"This PR refactors the XY reconstruction algorithms.\r\n\r\n\r\n1.- The code no longer calls two algorithms (barycenter or corona)\r\nwhich had to be selected by config, but a single algorithm (corona) with\r\na number of parameters. In particular, lm_radius can be set to a\r\nnegative number in which case corona will return an overall\r\nbarycenter (using all SiPms above Qthr threshold).\r\n\r\n2. The condition imposing a single cluster when filling a kr_event has\r\nbeen removed. That condition assumed that an overall barycenter\r\nreturning a single cluster *had to be used* in kr_city (e.g, to\r\ncompute KDSTs and maps). However, this is not a must and in fact,\r\nbetter (less biased) results can in principle be obtained using a\r\ncorona algorithm which uses a limited number of SiPms around the local\r\nmaximum. On the other hand, the use of a corona may result in more\r\nthan one cluster in the tracking plane, even in the case of\r\nsingle-particles (e.g, X-rays or Krypton), due, for example, to noisiy\r\nSiPMs. In this case the physical cluster is expected to have more energy than the satellite and this is the criterium used to choose.\r\n\r\n3. In the case of hit_city, if there is a reconstruction failure a hit\r\nis still formed using a \"NN cluster\" (a Non-Numeric cluster). This\r\nallows to keep track of the energy of the slice that failed to produce\r\na cluster. \r\n\r\nThe new code passes all the tests. In addition, we have run many events using Penthesilea to check that there are no running failures. Since there is no new functionality (no new algorithms) but a refactor of existing ones, new tests do not appear to be a must (in fact, existing tests caught a bug introduced by accident when refactoring and allowed for immediate correction).\r\n\r\n\r\n","created_at":"2017-08-24T09:26:42Z","updated_at":"2017-08-24T09:26:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/nextic/IC/pulls/300/commits","review_comments_url":"https://api.github.com/repos/nextic/IC/pulls/300/comments","review_comment_url":"https://api.github.com/repos/nextic/IC/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nextic/IC/issues/300/comments","statuses_url":"https://api.github.com/repos/nextic/IC/statuses/4d08d66f8404178f15849b9e140ff357f9239758","head":{"label":"jjgomezcadenas:xy-algos","ref":"xy-algos","sha":"4d08d66f8404178f15849b9e140ff357f9239758","user":{"login":"jjgomezcadenas","id":8070159,"avatar_url":"https://avatars1.githubusercontent.com/u/8070159?v=4","gravatar_id":"","url":"https://api.github.com/users/jjgomezcadenas","html_url":"https://github.com/jjgomezcadenas","followers_url":"https://api.github.com/users/jjgomezcadenas/followers","following_url":"https://api.github.com/users/jjgomezcadenas/following{/other_user}","gists_url":"https://api.github.com/users/jjgomezcadenas/gists{/gist_id}","starred_url":"https://api.github.com/users/jjgomezcadenas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjgomezcadenas/subscriptions","organizations_url":"https://api.github.com/users/jjgomezcadenas/orgs","repos_url":"https://api.github.com/users/jjgomezcadenas/repos","events_url":"https://api.github.com/users/jjgomezcadenas/events{/privacy}","received_events_url":"https://api.github.com/users/jjgomezcadenas/received_events","type":"User","site_admin":false},"repo":{"id":77236002,"name":"IC-1","full_name":"jjgomezcadenas/IC-1","owner":{"login":"jjgomezcadenas","id":8070159,"avatar_url":"https://avatars1.githubusercontent.com/u/8070159?v=4","gravatar_id":"","url":"https://api.github.com/users/jjgomezcadenas","html_url":"https://github.com/jjgomezcadenas","followers_url":"https://api.github.com/users/jjgomezcadenas/followers","following_url":"https://api.github.com/users/jjgomezcadenas/following{/other_user}","gists_url":"https://api.github.com/users/jjgomezcadenas/gists{/gist_id}","starred_url":"https://api.github.com/users/jjgomezcadenas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjgomezcadenas/subscriptions","organizations_url":"https://api.github.com/users/jjgomezcadenas/orgs","repos_url":"https://api.github.com/users/jjgomezcadenas/repos","events_url":"https://api.github.com/users/jjgomezcadenas/events{/privacy}","received_events_url":"https://api.github.com/users/jjgomezcadenas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jjgomezcadenas/IC-1","description":null,"fork":true,"url":"https://api.github.com/repos/jjgomezcadenas/IC-1","forks_url":"https://api.github.com/repos/jjgomezcadenas/IC-1/forks","keys_url":"https://api.github.com/repos/jjgomezcadenas/IC-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jjgomezcadenas/IC-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jjgomezcadenas/IC-1/teams","hooks_url":"https://api.github.com/repos/jjgomezcadenas/IC-1/hooks","issue_events_url":"https://api.github.com/repos/jjgomezcadenas/IC-1/issues/events{/number}","events_url":"https://api.github.com/repos/jjgomezcadenas/IC-1/events","assignees_url":"https://api.github.com/repos/jjgomezcadenas/IC-1/assignees{/user}","branches_url":"https://api.github.com/repos/jjgomezcadenas/IC-1/branches{/branch}","tags_url":"https://api.github.com/repos/jjgomezcadenas/IC-1/tags","blobs_url":"https://api.github.com/repos/jjgomezcadenas/IC-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jjgomezcadenas/IC-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jjgomezcadenas/IC-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/jjgomezcadenas/IC-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jjgomezcadenas/IC-1/statuses/{sha}","languages_url":"https://api.github.com/repos/jjgomezcadenas/IC-1/languages","stargazers_url":"https://api.github.com/repos/jjgomezcadenas/IC-1/stargazers","contributors_url":"https://api.github.com/repos/jjgomezcadenas/IC-1/contributors","subscribers_url":"https://api.github.com/repos/jjgomezcadenas/IC-1/subscribers","subscription_url":"https://api.github.com/repos/jjgomezcadenas/IC-1/subscription","commits_url":"https://api.github.com/repos/jjgomezcadenas/IC-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/jjgomezcadenas/IC-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/jjgomezcadenas/IC-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/jjgomezcadenas/IC-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/jjgomezcadenas/IC-1/contents/{+path}","compare_url":"https://api.github.com/repos/jjgomezcadenas/IC-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jjgomezcadenas/IC-1/merges","archive_url":"https://api.github.com/repos/jjgomezcadenas/IC-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jjgomezcadenas/IC-1/downloads","issues_url":"https://api.github.com/repos/jjgomezcadenas/IC-1/issues{/number}","pulls_url":"https://api.github.com/repos/jjgomezcadenas/IC-1/pulls{/number}","milestones_url":"https://api.github.com/repos/jjgomezcadenas/IC-1/milestones{/number}","notifications_url":"https://api.github.com/repos/jjgomezcadenas/IC-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jjgomezcadenas/IC-1/labels{/name}","releases_url":"https://api.github.com/repos/jjgomezcadenas/IC-1/releases{/id}","deployments_url":"https://api.github.com/repos/jjgomezcadenas/IC-1/deployments","created_at":"2016-12-23T16:01:26Z","updated_at":"2016-12-23T16:01:28Z","pushed_at":"2017-08-23T21:48:29Z","git_url":"git://github.com/jjgomezcadenas/IC-1.git","ssh_url":"git@github.com:jjgomezcadenas/IC-1.git","clone_url":"https://github.com/jjgomezcadenas/IC-1.git","svn_url":"https://github.com/jjgomezcadenas/IC-1","homepage":null,"size":19309,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nextic:master","ref":"master","sha":"a51516173a710461fb26c21266179958e3fcc9e9","user":{"login":"nextic","id":23397670,"avatar_url":"https://avatars1.githubusercontent.com/u/23397670?v=4","gravatar_id":"","url":"https://api.github.com/users/nextic","html_url":"https://github.com/nextic","followers_url":"https://api.github.com/users/nextic/followers","following_url":"https://api.github.com/users/nextic/following{/other_user}","gists_url":"https://api.github.com/users/nextic/gists{/gist_id}","starred_url":"https://api.github.com/users/nextic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nextic/subscriptions","organizations_url":"https://api.github.com/users/nextic/orgs","repos_url":"https://api.github.com/users/nextic/repos","events_url":"https://api.github.com/users/nextic/events{/privacy}","received_events_url":"https://api.github.com/users/nextic/received_events","type":"Organization","site_admin":false},"repo":{"id":76445486,"name":"IC","full_name":"nextic/IC","owner":{"login":"nextic","id":23397670,"avatar_url":"https://avatars1.githubusercontent.com/u/23397670?v=4","gravatar_id":"","url":"https://api.github.com/users/nextic","html_url":"https://github.com/nextic","followers_url":"https://api.github.com/users/nextic/followers","following_url":"https://api.github.com/users/nextic/following{/other_user}","gists_url":"https://api.github.com/users/nextic/gists{/gist_id}","starred_url":"https://api.github.com/users/nextic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nextic/subscriptions","organizations_url":"https://api.github.com/users/nextic/orgs","repos_url":"https://api.github.com/users/nextic/repos","events_url":"https://api.github.com/users/nextic/events{/privacy}","received_events_url":"https://api.github.com/users/nextic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nextic/IC","description":null,"fork":false,"url":"https://api.github.com/repos/nextic/IC","forks_url":"https://api.github.com/repos/nextic/IC/forks","keys_url":"https://api.github.com/repos/nextic/IC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nextic/IC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nextic/IC/teams","hooks_url":"https://api.github.com/repos/nextic/IC/hooks","issue_events_url":"https://api.github.com/repos/nextic/IC/issues/events{/number}","events_url":"https://api.github.com/repos/nextic/IC/events","assignees_url":"https://api.github.com/repos/nextic/IC/assignees{/user}","branches_url":"https://api.github.com/repos/nextic/IC/branches{/branch}","tags_url":"https://api.github.com/repos/nextic/IC/tags","blobs_url":"https://api.github.com/repos/nextic/IC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nextic/IC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nextic/IC/git/refs{/sha}","trees_url":"https://api.github.com/repos/nextic/IC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nextic/IC/statuses/{sha}","languages_url":"https://api.github.com/repos/nextic/IC/languages","stargazers_url":"https://api.github.com/repos/nextic/IC/stargazers","contributors_url":"https://api.github.com/repos/nextic/IC/contributors","subscribers_url":"https://api.github.com/repos/nextic/IC/subscribers","subscription_url":"https://api.github.com/repos/nextic/IC/subscription","commits_url":"https://api.github.com/repos/nextic/IC/commits{/sha}","git_commits_url":"https://api.github.com/repos/nextic/IC/git/commits{/sha}","comments_url":"https://api.github.com/repos/nextic/IC/comments{/number}","issue_comment_url":"https://api.github.com/repos/nextic/IC/issues/comments{/number}","contents_url":"https://api.github.com/repos/nextic/IC/contents/{+path}","compare_url":"https://api.github.com/repos/nextic/IC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nextic/IC/merges","archive_url":"https://api.github.com/repos/nextic/IC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nextic/IC/downloads","issues_url":"https://api.github.com/repos/nextic/IC/issues{/number}","pulls_url":"https://api.github.com/repos/nextic/IC/pulls{/number}","milestones_url":"https://api.github.com/repos/nextic/IC/milestones{/number}","notifications_url":"https://api.github.com/repos/nextic/IC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nextic/IC/labels{/name}","releases_url":"https://api.github.com/repos/nextic/IC/releases{/id}","deployments_url":"https://api.github.com/repos/nextic/IC/deployments","created_at":"2016-12-14T09:37:40Z","updated_at":"2017-07-12T14:13:39Z","pushed_at":"2017-08-23T16:55:50Z","git_url":"git://github.com/nextic/IC.git","ssh_url":"git@github.com:nextic/IC.git","clone_url":"https://github.com/nextic/IC.git","svn_url":"https://github.com/nextic/IC","homepage":null,"size":19300,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":25,"forks":13,"open_issues":25,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nextic/IC/pulls/300"},"html":{"href":"https://github.com/nextic/IC/pull/300"},"issue":{"href":"https://api.github.com/repos/nextic/IC/issues/300"},"comments":{"href":"https://api.github.com/repos/nextic/IC/issues/300/comments"},"review_comments":{"href":"https://api.github.com/repos/nextic/IC/pulls/300/comments"},"review_comment":{"href":"https://api.github.com/repos/nextic/IC/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nextic/IC/pulls/300/commits"},"statuses":{"href":"https://api.github.com/repos/nextic/IC/statuses/4d08d66f8404178f15849b9e140ff357f9239758"}},"merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":6,"additions":157,"deletions":55,"changed_files":8}}
{"actor":{"display_login":"jjgomezcadenas"}}