{"action":"created","comment":{"url":"https://api.github.com/repos/intel-analytics/BigDL/pulls/comments/109274584","pull_request_review_id":30371720,"id":109274584,"diff_hunk":"@@ -71,7 +71,15 @@ class ModelBroadcast[T: ClassTag](implicit ev: TensorNumeric[T]) extends Seriali\n         val wb = parameters._1(i)\n         weightsBias(i) = Tensor[T](Storage(wb.storage().array()),","path":"spark/dl/src/main/scala/com/intel/analytics/bigdl/models/utils/ModelBroadcast.scala","position":2,"original_position":2,"commit_id":"7e9aef7cea7a75a20c0f9a6e1b8be0a0984e6012","original_commit_id":"7e9aef7cea7a75a20c0f9a6e1b8be0a0984e6012","user":{"login":"yiheng","id":1297418,"avatar_url":"https://avatars0.githubusercontent.com/u/1297418?v=3","gravatar_id":"","url":"https://api.github.com/users/yiheng","html_url":"https://github.com/yiheng","followers_url":"https://api.github.com/users/yiheng/followers","following_url":"https://api.github.com/users/yiheng/following{/other_user}","gists_url":"https://api.github.com/users/yiheng/gists{/gist_id}","starred_url":"https://api.github.com/users/yiheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yiheng/subscriptions","organizations_url":"https://api.github.com/users/yiheng/orgs","repos_url":"https://api.github.com/users/yiheng/repos","events_url":"https://api.github.com/users/yiheng/events{/privacy}","received_events_url":"https://api.github.com/users/yiheng/received_events","type":"User","site_admin":false},"body":"The weights are shared among models when prediction.","created_at":"2017-04-01T02:06:03Z","updated_at":"2017-04-01T02:06:03Z","html_url":"https://github.com/intel-analytics/BigDL/pull/705#discussion_r109274584","pull_request_url":"https://api.github.com/repos/intel-analytics/BigDL/pulls/705","_links":{"self":{"href":"https://api.github.com/repos/intel-analytics/BigDL/pulls/comments/109274584"},"html":{"href":"https://github.com/intel-analytics/BigDL/pull/705#discussion_r109274584"},"pull_request":{"href":"https://api.github.com/repos/intel-analytics/BigDL/pulls/705"}}},"pull_request":{"url":"https://api.github.com/repos/intel-analytics/BigDL/pulls/705","id":113373536,"html_url":"https://github.com/intel-analytics/BigDL/pull/705","diff_url":"https://github.com/intel-analytics/BigDL/pull/705.diff","patch_url":"https://github.com/intel-analytics/BigDL/pull/705.patch","issue_url":"https://api.github.com/repos/intel-analytics/BigDL/issues/705","number":705,"state":"closed","locked":false,"title":"[Issue #704] fix the bug of modelbroadcast when all weights and biases share the one storage","user":{"login":"SeaOfOcean","id":10606312,"avatar_url":"https://avatars0.githubusercontent.com/u/10606312?v=3","gravatar_id":"","url":"https://api.github.com/users/SeaOfOcean","html_url":"https://github.com/SeaOfOcean","followers_url":"https://api.github.com/users/SeaOfOcean/followers","following_url":"https://api.github.com/users/SeaOfOcean/following{/other_user}","gists_url":"https://api.github.com/users/SeaOfOcean/gists{/gist_id}","starred_url":"https://api.github.com/users/SeaOfOcean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SeaOfOcean/subscriptions","organizations_url":"https://api.github.com/users/SeaOfOcean/orgs","repos_url":"https://api.github.com/users/SeaOfOcean/repos","events_url":"https://api.github.com/users/SeaOfOcean/events{/privacy}","received_events_url":"https://api.github.com/users/SeaOfOcean/received_events","type":"User","site_admin":false},"body":"\r\n## What changes were proposed in this pull request?\r\n\r\nfix the bug of modelbroadcast when all weights and biases share the one storage\r\n\r\n## How was this patch tested?\r\n\r\nunit test\r\n\r\n## Related links or issues (optional)\r\nfixed https://github.com/intel-analytics/BigDL/issues/704\r\n\r\n","created_at":"2017-03-30T08:36:01Z","updated_at":"2017-04-01T02:06:03Z","closed_at":"2017-03-31T08:16:33Z","merged_at":"2017-03-31T08:16:33Z","merge_commit_sha":"3c0abd604574b6ea2271d535e96c8d62597ee9cb","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/intel-analytics/BigDL/pulls/705/commits","review_comments_url":"https://api.github.com/repos/intel-analytics/BigDL/pulls/705/comments","review_comment_url":"https://api.github.com/repos/intel-analytics/BigDL/pulls/comments{/number}","comments_url":"https://api.github.com/repos/intel-analytics/BigDL/issues/705/comments","statuses_url":"https://api.github.com/repos/intel-analytics/BigDL/statuses/7e9aef7cea7a75a20c0f9a6e1b8be0a0984e6012","head":{"label":"SeaOfOcean:modelbroadcast","ref":"modelbroadcast","sha":"7e9aef7cea7a75a20c0f9a6e1b8be0a0984e6012","user":{"login":"SeaOfOcean","id":10606312,"avatar_url":"https://avatars0.githubusercontent.com/u/10606312?v=3","gravatar_id":"","url":"https://api.github.com/users/SeaOfOcean","html_url":"https://github.com/SeaOfOcean","followers_url":"https://api.github.com/users/SeaOfOcean/followers","following_url":"https://api.github.com/users/SeaOfOcean/following{/other_user}","gists_url":"https://api.github.com/users/SeaOfOcean/gists{/gist_id}","starred_url":"https://api.github.com/users/SeaOfOcean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SeaOfOcean/subscriptions","organizations_url":"https://api.github.com/users/SeaOfOcean/orgs","repos_url":"https://api.github.com/users/SeaOfOcean/repos","events_url":"https://api.github.com/users/SeaOfOcean/events{/privacy}","received_events_url":"https://api.github.com/users/SeaOfOcean/received_events","type":"User","site_admin":false},"repo":{"id":77887710,"name":"BigDL","full_name":"SeaOfOcean/BigDL","owner":{"login":"SeaOfOcean","id":10606312,"avatar_url":"https://avatars0.githubusercontent.com/u/10606312?v=3","gravatar_id":"","url":"https://api.github.com/users/SeaOfOcean","html_url":"https://github.com/SeaOfOcean","followers_url":"https://api.github.com/users/SeaOfOcean/followers","following_url":"https://api.github.com/users/SeaOfOcean/following{/other_user}","gists_url":"https://api.github.com/users/SeaOfOcean/gists{/gist_id}","starred_url":"https://api.github.com/users/SeaOfOcean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SeaOfOcean/subscriptions","organizations_url":"https://api.github.com/users/SeaOfOcean/orgs","repos_url":"https://api.github.com/users/SeaOfOcean/repos","events_url":"https://api.github.com/users/SeaOfOcean/events{/privacy}","received_events_url":"https://api.github.com/users/SeaOfOcean/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SeaOfOcean/BigDL","description":"BigDL: Distributed Deep learning Library for Apache Spark","fork":true,"url":"https://api.github.com/repos/SeaOfOcean/BigDL","forks_url":"https://api.github.com/repos/SeaOfOcean/BigDL/forks","keys_url":"https://api.github.com/repos/SeaOfOcean/BigDL/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SeaOfOcean/BigDL/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SeaOfOcean/BigDL/teams","hooks_url":"https://api.github.com/repos/SeaOfOcean/BigDL/hooks","issue_events_url":"https://api.github.com/repos/SeaOfOcean/BigDL/issues/events{/number}","events_url":"https://api.github.com/repos/SeaOfOcean/BigDL/events","assignees_url":"https://api.github.com/repos/SeaOfOcean/BigDL/assignees{/user}","branches_url":"https://api.github.com/repos/SeaOfOcean/BigDL/branches{/branch}","tags_url":"https://api.github.com/repos/SeaOfOcean/BigDL/tags","blobs_url":"https://api.github.com/repos/SeaOfOcean/BigDL/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SeaOfOcean/BigDL/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SeaOfOcean/BigDL/git/refs{/sha}","trees_url":"https://api.github.com/repos/SeaOfOcean/BigDL/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SeaOfOcean/BigDL/statuses/{sha}","languages_url":"https://api.github.com/repos/SeaOfOcean/BigDL/languages","stargazers_url":"https://api.github.com/repos/SeaOfOcean/BigDL/stargazers","contributors_url":"https://api.github.com/repos/SeaOfOcean/BigDL/contributors","subscribers_url":"https://api.github.com/repos/SeaOfOcean/BigDL/subscribers","subscription_url":"https://api.github.com/repos/SeaOfOcean/BigDL/subscription","commits_url":"https://api.github.com/repos/SeaOfOcean/BigDL/commits{/sha}","git_commits_url":"https://api.github.com/repos/SeaOfOcean/BigDL/git/commits{/sha}","comments_url":"https://api.github.com/repos/SeaOfOcean/BigDL/comments{/number}","issue_comment_url":"https://api.github.com/repos/SeaOfOcean/BigDL/issues/comments{/number}","contents_url":"https://api.github.com/repos/SeaOfOcean/BigDL/contents/{+path}","compare_url":"https://api.github.com/repos/SeaOfOcean/BigDL/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SeaOfOcean/BigDL/merges","archive_url":"https://api.github.com/repos/SeaOfOcean/BigDL/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SeaOfOcean/BigDL/downloads","issues_url":"https://api.github.com/repos/SeaOfOcean/BigDL/issues{/number}","pulls_url":"https://api.github.com/repos/SeaOfOcean/BigDL/pulls{/number}","milestones_url":"https://api.github.com/repos/SeaOfOcean/BigDL/milestones{/number}","notifications_url":"https://api.github.com/repos/SeaOfOcean/BigDL/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SeaOfOcean/BigDL/labels{/name}","releases_url":"https://api.github.com/repos/SeaOfOcean/BigDL/releases{/id}","deployments_url":"https://api.github.com/repos/SeaOfOcean/BigDL/deployments","created_at":"2017-01-03T05:47:50Z","updated_at":"2017-01-03T05:47:55Z","pushed_at":"2017-03-31T07:08:53Z","git_url":"git://github.com/SeaOfOcean/BigDL.git","ssh_url":"git@github.com:SeaOfOcean/BigDL.git","clone_url":"https://github.com/SeaOfOcean/BigDL.git","svn_url":"https://github.com/SeaOfOcean/BigDL","homepage":"","size":13311,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"intel-analytics:master","ref":"master","sha":"1ad2ed13a30d799e0b55dbf8d765f16ab3f48b6d","user":{"login":"intel-analytics","id":10941215,"avatar_url":"https://avatars0.githubusercontent.com/u/10941215?v=3","gravatar_id":"","url":"https://api.github.com/users/intel-analytics","html_url":"https://github.com/intel-analytics","followers_url":"https://api.github.com/users/intel-analytics/followers","following_url":"https://api.github.com/users/intel-analytics/following{/other_user}","gists_url":"https://api.github.com/users/intel-analytics/gists{/gist_id}","starred_url":"https://api.github.com/users/intel-analytics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/intel-analytics/subscriptions","organizations_url":"https://api.github.com/users/intel-analytics/orgs","repos_url":"https://api.github.com/users/intel-analytics/repos","events_url":"https://api.github.com/users/intel-analytics/events{/privacy}","received_events_url":"https://api.github.com/users/intel-analytics/received_events","type":"Organization","site_admin":false},"repo":{"id":66823715,"name":"BigDL","full_name":"intel-analytics/BigDL","owner":{"login":"intel-analytics","id":10941215,"avatar_url":"https://avatars0.githubusercontent.com/u/10941215?v=3","gravatar_id":"","url":"https://api.github.com/users/intel-analytics","html_url":"https://github.com/intel-analytics","followers_url":"https://api.github.com/users/intel-analytics/followers","following_url":"https://api.github.com/users/intel-analytics/following{/other_user}","gists_url":"https://api.github.com/users/intel-analytics/gists{/gist_id}","starred_url":"https://api.github.com/users/intel-analytics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/intel-analytics/subscriptions","organizations_url":"https://api.github.com/users/intel-analytics/orgs","repos_url":"https://api.github.com/users/intel-analytics/repos","events_url":"https://api.github.com/users/intel-analytics/events{/privacy}","received_events_url":"https://api.github.com/users/intel-analytics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/intel-analytics/BigDL","description":"BigDL: Distributed Deep Learning Library for Apache Spark","fork":false,"url":"https://api.github.com/repos/intel-analytics/BigDL","forks_url":"https://api.github.com/repos/intel-analytics/BigDL/forks","keys_url":"https://api.github.com/repos/intel-analytics/BigDL/keys{/key_id}","collaborators_url":"https://api.github.com/repos/intel-analytics/BigDL/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/intel-analytics/BigDL/teams","hooks_url":"https://api.github.com/repos/intel-analytics/BigDL/hooks","issue_events_url":"https://api.github.com/repos/intel-analytics/BigDL/issues/events{/number}","events_url":"https://api.github.com/repos/intel-analytics/BigDL/events","assignees_url":"https://api.github.com/repos/intel-analytics/BigDL/assignees{/user}","branches_url":"https://api.github.com/repos/intel-analytics/BigDL/branches{/branch}","tags_url":"https://api.github.com/repos/intel-analytics/BigDL/tags","blobs_url":"https://api.github.com/repos/intel-analytics/BigDL/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/intel-analytics/BigDL/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/intel-analytics/BigDL/git/refs{/sha}","trees_url":"https://api.github.com/repos/intel-analytics/BigDL/git/trees{/sha}","statuses_url":"https://api.github.com/repos/intel-analytics/BigDL/statuses/{sha}","languages_url":"https://api.github.com/repos/intel-analytics/BigDL/languages","stargazers_url":"https://api.github.com/repos/intel-analytics/BigDL/stargazers","contributors_url":"https://api.github.com/repos/intel-analytics/BigDL/contributors","subscribers_url":"https://api.github.com/repos/intel-analytics/BigDL/subscribers","subscription_url":"https://api.github.com/repos/intel-analytics/BigDL/subscription","commits_url":"https://api.github.com/repos/intel-analytics/BigDL/commits{/sha}","git_commits_url":"https://api.github.com/repos/intel-analytics/BigDL/git/commits{/sha}","comments_url":"https://api.github.com/repos/intel-analytics/BigDL/comments{/number}","issue_comment_url":"https://api.github.com/repos/intel-analytics/BigDL/issues/comments{/number}","contents_url":"https://api.github.com/repos/intel-analytics/BigDL/contents/{+path}","compare_url":"https://api.github.com/repos/intel-analytics/BigDL/compare/{base}...{head}","merges_url":"https://api.github.com/repos/intel-analytics/BigDL/merges","archive_url":"https://api.github.com/repos/intel-analytics/BigDL/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/intel-analytics/BigDL/downloads","issues_url":"https://api.github.com/repos/intel-analytics/BigDL/issues{/number}","pulls_url":"https://api.github.com/repos/intel-analytics/BigDL/pulls{/number}","milestones_url":"https://api.github.com/repos/intel-analytics/BigDL/milestones{/number}","notifications_url":"https://api.github.com/repos/intel-analytics/BigDL/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/intel-analytics/BigDL/labels{/name}","releases_url":"https://api.github.com/repos/intel-analytics/BigDL/releases{/id}","deployments_url":"https://api.github.com/repos/intel-analytics/BigDL/deployments","created_at":"2016-08-29T07:59:50Z","updated_at":"2017-03-31T20:16:37Z","pushed_at":"2017-04-01T01:59:35Z","git_url":"git://github.com/intel-analytics/BigDL.git","ssh_url":"git@github.com:intel-analytics/BigDL.git","clone_url":"https://github.com/intel-analytics/BigDL.git","svn_url":"https://github.com/intel-analytics/BigDL","homepage":"","size":10486,"stargazers_count":1618,"watchers_count":1618,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":292,"mirror_url":null,"open_issues_count":90,"forks":292,"open_issues":90,"watchers":1618,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/intel-analytics/BigDL/pulls/705"},"html":{"href":"https://github.com/intel-analytics/BigDL/pull/705"},"issue":{"href":"https://api.github.com/repos/intel-analytics/BigDL/issues/705"},"comments":{"href":"https://api.github.com/repos/intel-analytics/BigDL/issues/705/comments"},"review_comments":{"href":"https://api.github.com/repos/intel-analytics/BigDL/pulls/705/comments"},"review_comment":{"href":"https://api.github.com/repos/intel-analytics/BigDL/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/intel-analytics/BigDL/pulls/705/commits"},"statuses":{"href":"https://api.github.com/repos/intel-analytics/BigDL/statuses/7e9aef7cea7a75a20c0f9a6e1b8be0a0984e6012"}}}}
{"actor":{"display_login":"yiheng"}}