{"action":"created","issue":{"url":"https://api.github.com/repos/taf3/taf/issues/33","repository_url":"https://api.github.com/repos/taf3/taf","labels_url":"https://api.github.com/repos/taf3/taf/issues/33/labels{/name}","comments_url":"https://api.github.com/repos/taf3/taf/issues/33/comments","events_url":"https://api.github.com/repos/taf3/taf/issues/33/events","html_url":"https://github.com/taf3/taf/pull/33","id":216916490,"number":33,"title":"External network creation changes","user":{"login":"mskrocki","id":10943937,"avatar_url":"https://avatars0.githubusercontent.com/u/10943937?v=3","gravatar_id":"","url":"https://api.github.com/users/mskrocki","html_url":"https://github.com/mskrocki","followers_url":"https://api.github.com/users/mskrocki/followers","following_url":"https://api.github.com/users/mskrocki/following{/other_user}","gists_url":"https://api.github.com/users/mskrocki/gists{/gist_id}","starred_url":"https://api.github.com/users/mskrocki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mskrocki/subscriptions","organizations_url":"https://api.github.com/users/mskrocki/orgs","repos_url":"https://api.github.com/users/mskrocki/repos","events_url":"https://api.github.com/users/mskrocki/events{/privacy}","received_events_url":"https://api.github.com/users/mskrocki/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-03-24T22:07:09Z","updated_at":"2017-03-29T11:18:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/taf3/taf/pulls/33","html_url":"https://github.com/taf3/taf/pull/33","diff_url":"https://github.com/taf3/taf/pull/33.diff","patch_url":"https://github.com/taf3/taf/pull/33.patch"},"body":"- Removed external router creation\r\n- fixed external networks detection - removed router lookup\r\n- If external network present: deleting floating IPs, unbinding from any router and deleting that network\r\n- if more than one external network -> deleting all\r\n- cleaned up passed clients -> external should always be handled by admin project\r\n\r\nSigned-off-by: Maciej Skrocki <maciej.skrocki@intel.com>\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/taf3/taf/33)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/taf3/taf/issues/comments/290059686","html_url":"https://github.com/taf3/taf/pull/33#issuecomment-290059686","issue_url":"https://api.github.com/repos/taf3/taf/issues/33","id":290059686,"user":{"login":"jiriproX","id":13276164,"avatar_url":"https://avatars3.githubusercontent.com/u/13276164?v=3","gravatar_id":"","url":"https://api.github.com/users/jiriproX","html_url":"https://github.com/jiriproX","followers_url":"https://api.github.com/users/jiriproX/followers","following_url":"https://api.github.com/users/jiriproX/following{/other_user}","gists_url":"https://api.github.com/users/jiriproX/gists{/gist_id}","starred_url":"https://api.github.com/users/jiriproX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jiriproX/subscriptions","organizations_url":"https://api.github.com/users/jiriproX/orgs","repos_url":"https://api.github.com/users/jiriproX/repos","events_url":"https://api.github.com/users/jiriproX/events{/privacy}","received_events_url":"https://api.github.com/users/jiriproX/received_events","type":"User","site_admin":false},"created_at":"2017-03-29T11:18:20Z","updated_at":"2017-03-29T11:18:20Z","body":"\n\n\n\nReview status: 0 of 1 files reviewed at latest revision, 4 unresolved discussions.\n\n---\n\n*[taf/testlib/virtual_env.py, line 382 at r1](https://reviewable.io:443/reviews/taf3/taf/33#-Kg1LzLWAvvOJ2pfTPRJ-r1-382:-KgOFPBCMY-BcGaNw1qt:b-51sxls) ([raw file](https://github.com/taf3/taf/blob/b9c4f3faa2dab4c329e9dfdd8fc4e118411a3d1d/taf/testlib/virtual_env.py#L382)):*\n<details><summary><i>Previously, mskrocki (Maciej Skrocki) wrote…</i></summary><blockquote>\n\nThe main reason we clean is to make sure we can run our tests in ANY case, even when someone did a mess in OpenStack manually. So it is not only to support deployment misconfigurations.\n</blockquote></details>\n\nYes, I understand that. So default behavior can be that delete is done. Nevertheless taf is used for development testing as well. In such cases we need to preserve current setup.\n\n---\n\n*[taf/testlib/virtual_env.py, line 597 at r1](https://reviewable.io:443/reviews/taf3/taf/33#-Kg1LzLWAvvOJ2pfTPRJ-r1-597:-KgOg-IsLcOS-g1vNjyg:b-vdj6sx) ([raw file](https://github.com/taf3/taf/blob/b9c4f3faa2dab4c329e9dfdd8fc4e118411a3d1d/taf/testlib/virtual_env.py#L597)):*\n<details><summary><i>Previously, mskrocki (Maciej Skrocki) wrote…</i></summary><blockquote>\n\nthere is no delete_external flag anymore, and currently it is not needed.\n</blockquote></details>\n\nSee previous two comments.\n\n---\n\n*[taf/testlib/virtual_env.py, line 130 at r2](https://reviewable.io:443/reviews/taf3/taf/33#-KgOkQKWscruMVc1Hd9R:-KgOkQKXe1YhaPUWmU_D:b-ida6oh) ([raw file](https://github.com/taf3/taf/blob/273cae05869140ccbf16e8f2f724cc2cdae021cd/taf/testlib/virtual_env.py#L130)):*\n> ```Python\n>         self.env_settings = self._get_settings(self.opts.env)\n>         self.tempest_path = self.opts.tempest_path\n>         self.reuse_venv = self.opts.reuse_venv\n> ```\n\nReuse parameter does not work, following should be used here:\n     self.reuse_venv = ast.literal_eval(self.opts.reuse_venv)\n\nOne more file needs to be updated:\ntaf/plugins/pytest_tempest.py\n\n         '--reuse_venv': {\n             'action': 'store',\n+           'default': 'True',\n+           'choices': ['True', 'False'],\n-            'default': True,\n             'help': \"Reuse(=True) or Delete(=False) existing public networks/routers\\\n+            , '%default' by default.\",\n-            , '%default' by default.\"\n         }\n\n---\n\n*[taf/testlib/virtual_env.py, line 350 at r2](https://reviewable.io:443/reviews/taf3/taf/33#-KgOH3l_BXyDBTamrvC6:-KgOH3l_BXyDBTamrvC7:b-kv397u) ([raw file](https://github.com/taf3/taf/blob/273cae05869140ccbf16e8f2f724cc2cdae021cd/taf/testlib/virtual_env.py#L350)):*\n> ```Python\n>             return True\n> \n>         self.class_logger.debug('No reuse')\n> ```\n\nDelete external elements should be move here. If you do not want additional command line option e.g.: \"cleanup_public_network\" then existing \"reuse\" option can be used:\n# delete public network if required\nif not try_reuse:\n    self._delete_external_elements()\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/taf3/taf/33)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"jiriproX"}}