{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/52760","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/52760/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/52760/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/52760/events","html_url":"https://github.com/kubernetes/kubernetes/pull/52760","id":259029476,"number":52760,"title":"Add UT for DefaultServiceIPRange","user":{"login":"wackxu","id":30396467,"avatar_url":"https://avatars1.githubusercontent.com/u/30396467?v=4","gravatar_id":"","url":"https://api.github.com/users/wackxu","html_url":"https://github.com/wackxu","followers_url":"https://api.github.com/users/wackxu/followers","following_url":"https://api.github.com/users/wackxu/following{/other_user}","gists_url":"https://api.github.com/users/wackxu/gists{/gist_id}","starred_url":"https://api.github.com/users/wackxu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wackxu/subscriptions","organizations_url":"https://api.github.com/users/wackxu/orgs","repos_url":"https://api.github.com/users/wackxu/repos","events_url":"https://api.github.com/users/wackxu/events{/privacy}","received_events_url":"https://api.github.com/users/wackxu/received_events","type":"User","site_admin":false},"labels":[{"id":477397086,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":573014062,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/needs-ok-to-test","name":"needs-ok-to-test","color":"b60205","default":false},{"id":349530249,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":253450934,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/M","name":"size/M","color":"eebb00","default":false}],"state":"open","locked":false,"assignee":{"login":"justinsb","id":100893,"avatar_url":"https://avatars2.githubusercontent.com/u/100893?v=4","gravatar_id":"","url":"https://api.github.com/users/justinsb","html_url":"https://github.com/justinsb","followers_url":"https://api.github.com/users/justinsb/followers","following_url":"https://api.github.com/users/justinsb/following{/other_user}","gists_url":"https://api.github.com/users/justinsb/gists{/gist_id}","starred_url":"https://api.github.com/users/justinsb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinsb/subscriptions","organizations_url":"https://api.github.com/users/justinsb/orgs","repos_url":"https://api.github.com/users/justinsb/repos","events_url":"https://api.github.com/users/justinsb/events{/privacy}","received_events_url":"https://api.github.com/users/justinsb/received_events","type":"User","site_admin":false},"assignees":[{"login":"justinsb","id":100893,"avatar_url":"https://avatars2.githubusercontent.com/u/100893?v=4","gravatar_id":"","url":"https://api.github.com/users/justinsb","html_url":"https://github.com/justinsb","followers_url":"https://api.github.com/users/justinsb/followers","following_url":"https://api.github.com/users/justinsb/following{/other_user}","gists_url":"https://api.github.com/users/justinsb/gists{/gist_id}","starred_url":"https://api.github.com/users/justinsb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinsb/subscriptions","organizations_url":"https://api.github.com/users/justinsb/orgs","repos_url":"https://api.github.com/users/justinsb/repos","events_url":"https://api.github.com/users/justinsb/events{/privacy}","received_events_url":"https://api.github.com/users/justinsb/received_events","type":"User","site_admin":false},{"login":"janetkuo","id":4876867,"avatar_url":"https://avatars1.githubusercontent.com/u/4876867?v=4","gravatar_id":"","url":"https://api.github.com/users/janetkuo","html_url":"https://github.com/janetkuo","followers_url":"https://api.github.com/users/janetkuo/followers","following_url":"https://api.github.com/users/janetkuo/following{/other_user}","gists_url":"https://api.github.com/users/janetkuo/gists{/gist_id}","starred_url":"https://api.github.com/users/janetkuo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janetkuo/subscriptions","organizations_url":"https://api.github.com/users/janetkuo/orgs","repos_url":"https://api.github.com/users/janetkuo/repos","events_url":"https://api.github.com/users/janetkuo/events{/privacy}","received_events_url":"https://api.github.com/users/janetkuo/received_events","type":"User","site_admin":false},{"login":"derekwaynecarr","id":6233452,"avatar_url":"https://avatars3.githubusercontent.com/u/6233452?v=4","gravatar_id":"","url":"https://api.github.com/users/derekwaynecarr","html_url":"https://github.com/derekwaynecarr","followers_url":"https://api.github.com/users/derekwaynecarr/followers","following_url":"https://api.github.com/users/derekwaynecarr/following{/other_user}","gists_url":"https://api.github.com/users/derekwaynecarr/gists{/gist_id}","starred_url":"https://api.github.com/users/derekwaynecarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derekwaynecarr/subscriptions","organizations_url":"https://api.github.com/users/derekwaynecarr/orgs","repos_url":"https://api.github.com/users/derekwaynecarr/repos","events_url":"https://api.github.com/users/derekwaynecarr/events{/privacy}","received_events_url":"https://api.github.com/users/derekwaynecarr/received_events","type":"User","site_admin":false}],"milestone":null,"comments":6,"created_at":"2017-09-20T03:34:31Z","updated_at":"2017-11-17T03:36:39Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/52760","html_url":"https://github.com/kubernetes/kubernetes/pull/52760","diff_url":"https://github.com/kubernetes/kubernetes/pull/52760.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/52760.patch"},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/devel/pull-requests.md#the-pr-submit-process and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/devel/pull-requests.md#best-practices-for-faster-reviews\r\n3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/devel/pull-requests.md#write-release-notes-if-needed\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\n1. Add UT for DefaultServiceIPRange\r\n2. Remove unused TODO  because the code has already move out of the genericapiserver package\r\n\r\n**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #\r\n\r\n**Release note**:\r\n<!--  Steps to write your release note:\r\n1. Use the release-note-* labels to set the release note state (if you have access)\r\n2. Enter your extended release note in the below block; leaving it blank means using the PR title as the release note. If no release note is required, just write `NONE`.\r\n-->\r\n```release-note\r\nNONE\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/345136430","html_url":"https://github.com/kubernetes/kubernetes/pull/52760#issuecomment-345136430","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/52760","id":345136430,"user":{"login":"wackxu","id":30396467,"avatar_url":"https://avatars1.githubusercontent.com/u/30396467?v=4","gravatar_id":"","url":"https://api.github.com/users/wackxu","html_url":"https://github.com/wackxu","followers_url":"https://api.github.com/users/wackxu/followers","following_url":"https://api.github.com/users/wackxu/following{/other_user}","gists_url":"https://api.github.com/users/wackxu/gists{/gist_id}","starred_url":"https://api.github.com/users/wackxu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wackxu/subscriptions","organizations_url":"https://api.github.com/users/wackxu/orgs","repos_url":"https://api.github.com/users/wackxu/repos","events_url":"https://api.github.com/users/wackxu/events{/privacy}","received_events_url":"https://api.github.com/users/wackxu/received_events","type":"User","site_admin":false},"created_at":"2017-11-17T03:36:39Z","updated_at":"2017-11-17T03:36:39Z","author_association":"CONTRIBUTOR","body":"@justinsb Thanks for your review. Done, PTAL"}}
{"actor":{"display_login":"wackxu"}}