{"action":"created","issue":{"url":"https://api.github.com/repos/golang/go/issues/18952","repository_url":"https://api.github.com/repos/golang/go","labels_url":"https://api.github.com/repos/golang/go/issues/18952/labels{/name}","comments_url":"https://api.github.com/repos/golang/go/issues/18952/comments","events_url":"https://api.github.com/repos/golang/go/issues/18952/events","html_url":"https://github.com/golang/go/issues/18952","id":205467933,"number":18952,"title":"net/http: Unclear if modifying http.Request.URL in ServeHTTP is legal.","user":{"login":"shurcooL","id":1924134,"avatar_url":"https://avatars.githubusercontent.com/u/1924134?v=3","gravatar_id":"","url":"https://api.github.com/users/shurcooL","html_url":"https://github.com/shurcooL","followers_url":"https://api.github.com/users/shurcooL/followers","following_url":"https://api.github.com/users/shurcooL/following{/other_user}","gists_url":"https://api.github.com/users/shurcooL/gists{/gist_id}","starred_url":"https://api.github.com/users/shurcooL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shurcooL/subscriptions","organizations_url":"https://api.github.com/users/shurcooL/orgs","repos_url":"https://api.github.com/users/shurcooL/repos","events_url":"https://api.github.com/users/shurcooL/events{/privacy}","received_events_url":"https://api.github.com/users/shurcooL/received_events","type":"User","site_admin":false},"labels":[{"id":373399998,"url":"https://api.github.com/repos/golang/go/labels/NeedsFix","name":"NeedsFix","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/golang/go/milestones/49","html_url":"https://github.com/golang/go/milestone/49","labels_url":"https://api.github.com/repos/golang/go/milestones/49/labels","id":2053058,"number":49,"title":"Go1.9","description":"","creator":{"login":"rsc","id":104030,"avatar_url":"https://avatars.githubusercontent.com/u/104030?v=3","gravatar_id":"","url":"https://api.github.com/users/rsc","html_url":"https://github.com/rsc","followers_url":"https://api.github.com/users/rsc/followers","following_url":"https://api.github.com/users/rsc/following{/other_user}","gists_url":"https://api.github.com/users/rsc/gists{/gist_id}","starred_url":"https://api.github.com/users/rsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsc/subscriptions","organizations_url":"https://api.github.com/users/rsc/orgs","repos_url":"https://api.github.com/users/rsc/repos","events_url":"https://api.github.com/users/rsc/events{/privacy}","received_events_url":"https://api.github.com/users/rsc/received_events","type":"User","site_admin":false},"open_issues":471,"closed_issues":83,"state":"open","created_at":"2016-10-06T18:17:55Z","updated_at":"2017-02-07T15:38:42Z","due_on":"2017-07-31T07:00:00Z","closed_at":null},"comments":4,"created_at":"2017-02-06T00:48:44Z","updated_at":"2017-02-07T16:10:40Z","closed_at":null,"body":"As of https://golang.org/cl/21530 (/cc @bradfitz), which resolved #14940, `http.Handler` doc says about `ServeHTTP(http.ResponseWriter, *http.Request)`:\r\n\r\n```\r\n// Except for reading the body, handlers should not modify the\r\n// provided Request.\r\n```\r\n\r\nYet here's what `http.StripPrefix` does:\r\n\r\n```Go\r\nreturn HandlerFunc(func(w ResponseWriter, r *Request) {\r\n...\r\n\tr.URL.Path = p\r\n```\r\n\r\nIs modifying `http.Request.URL` not considered as modifying `http.Request` itself? If so, I believe the documentation needs to be more clear about that.\r\n\r\nOr is there a bug in `http.StripPrefix`?"},"comment":{"url":"https://api.github.com/repos/golang/go/issues/comments/278047658","html_url":"https://github.com/golang/go/issues/18952#issuecomment-278047658","issue_url":"https://api.github.com/repos/golang/go/issues/18952","id":278047658,"user":{"login":"gopherbot","id":8566911,"avatar_url":"https://avatars.githubusercontent.com/u/8566911?v=3","gravatar_id":"","url":"https://api.github.com/users/gopherbot","html_url":"https://github.com/gopherbot","followers_url":"https://api.github.com/users/gopherbot/followers","following_url":"https://api.github.com/users/gopherbot/following{/other_user}","gists_url":"https://api.github.com/users/gopherbot/gists{/gist_id}","starred_url":"https://api.github.com/users/gopherbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gopherbot/subscriptions","organizations_url":"https://api.github.com/users/gopherbot/orgs","repos_url":"https://api.github.com/users/gopherbot/repos","events_url":"https://api.github.com/users/gopherbot/events{/privacy}","received_events_url":"https://api.github.com/users/gopherbot/received_events","type":"User","site_admin":false},"created_at":"2017-02-07T16:10:40Z","updated_at":"2017-02-07T16:10:40Z","body":"CL https://golang.org/cl/36483 mentions this issue."}}
{"actor":{"display_login":"gopherbot"}}