{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/112506225","pull_request_review_id":33827529,"id":112506225,"diff_hunk":"@@ -46,7 +46,8 @@ type MasterConfiguration struct {\n \t// SelfHosted enables an alpha deployment type where the apiserver, scheduler, and\n \t// controller manager are managed by Kubernetes itself. This option is likely to\n \t// become the default in the future.\n-\tSelfHosted bool\n+\tSelfHosted     bool\n+\tSkipTokenPrint bool","path":"cmd/kubeadm/app/apis/kubeadm/types.go","position":6,"original_position":6,"commit_id":"a85e1b209fe6e4409072f30d3def3881b96736c9","original_commit_id":"a85e1b209fe6e4409072f30d3def3881b96736c9","user":{"login":"luxas","id":5442475,"avatar_url":"https://avatars2.githubusercontent.com/u/5442475?v=3","gravatar_id":"","url":"https://api.github.com/users/luxas","html_url":"https://github.com/luxas","followers_url":"https://api.github.com/users/luxas/followers","following_url":"https://api.github.com/users/luxas/following{/other_user}","gists_url":"https://api.github.com/users/luxas/gists{/gist_id}","starred_url":"https://api.github.com/users/luxas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luxas/subscriptions","organizations_url":"https://api.github.com/users/luxas/orgs","repos_url":"https://api.github.com/users/luxas/repos","events_url":"https://api.github.com/users/luxas/events{/privacy}","received_events_url":"https://api.github.com/users/luxas/received_events","type":"User","site_admin":false},"body":"I still don't think this should be in the API.\r\nIt should be Init struct that's for CLI params\r\n\r\nThis is a CLI-specific thing, not something that should be a part of an API","created_at":"2017-04-20T17:02:16Z","updated_at":"2017-04-20T17:02:19Z","html_url":"https://github.com/kubernetes/kubernetes/pull/44588#discussion_r112506225","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/44588","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/112506225"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/44588#discussion_r112506225"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/44588"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/44588","id":116221898,"html_url":"https://github.com/kubernetes/kubernetes/pull/44588","diff_url":"https://github.com/kubernetes/kubernetes/pull/44588.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/44588.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/44588","number":44588,"state":"open","locked":false,"title":"kubeadm: add flag to skip token print out","user":{"login":"dmmcquay","id":1700422,"avatar_url":"https://avatars1.githubusercontent.com/u/1700422?v=3","gravatar_id":"","url":"https://api.github.com/users/dmmcquay","html_url":"https://github.com/dmmcquay","followers_url":"https://api.github.com/users/dmmcquay/followers","following_url":"https://api.github.com/users/dmmcquay/following{/other_user}","gists_url":"https://api.github.com/users/dmmcquay/gists{/gist_id}","starred_url":"https://api.github.com/users/dmmcquay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmmcquay/subscriptions","organizations_url":"https://api.github.com/users/dmmcquay/orgs","repos_url":"https://api.github.com/users/dmmcquay/repos","events_url":"https://api.github.com/users/dmmcquay/events{/privacy}","received_events_url":"https://api.github.com/users/dmmcquay/received_events","type":"User","site_admin":false},"body":"**What this PR does / why we need it**: When kubeadm init is used in an automated context, it still prints the token to standard out. When standard output ends up in a log file, it can be considered that the token is leaked there and can be compromised. This PR adds a flag you can select to not have it print out and explicitly disable this behavior.\r\n\r\nThis is a continuation from https://github.com/kubernetes/kubernetes/pull/42823 since it had to be closed.\r\n\r\n**Which issue this PR fixes** : fixes #https://github.com/kubernetes/kubeadm/issues/160\r\n\r\n**Special notes for your reviewer**: /cc @luxas @errordeveloper \r\n\r\n**Release note**:\r\n```release-note\r\nNONE\r\n```","created_at":"2017-04-17T23:18:24Z","updated_at":"2017-04-20T17:02:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"88799c0b864fc9220333378538630e3120fab89c","assignee":{"login":"luxas","id":5442475,"avatar_url":"https://avatars2.githubusercontent.com/u/5442475?v=3","gravatar_id":"","url":"https://api.github.com/users/luxas","html_url":"https://github.com/luxas","followers_url":"https://api.github.com/users/luxas/followers","following_url":"https://api.github.com/users/luxas/following{/other_user}","gists_url":"https://api.github.com/users/luxas/gists{/gist_id}","starred_url":"https://api.github.com/users/luxas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luxas/subscriptions","organizations_url":"https://api.github.com/users/luxas/orgs","repos_url":"https://api.github.com/users/luxas/repos","events_url":"https://api.github.com/users/luxas/events{/privacy}","received_events_url":"https://api.github.com/users/luxas/received_events","type":"User","site_admin":false},"assignees":[{"login":"mikedanese","id":1787169,"avatar_url":"https://avatars0.githubusercontent.com/u/1787169?v=3","gravatar_id":"","url":"https://api.github.com/users/mikedanese","html_url":"https://github.com/mikedanese","followers_url":"https://api.github.com/users/mikedanese/followers","following_url":"https://api.github.com/users/mikedanese/following{/other_user}","gists_url":"https://api.github.com/users/mikedanese/gists{/gist_id}","starred_url":"https://api.github.com/users/mikedanese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikedanese/subscriptions","organizations_url":"https://api.github.com/users/mikedanese/orgs","repos_url":"https://api.github.com/users/mikedanese/repos","events_url":"https://api.github.com/users/mikedanese/events{/privacy}","received_events_url":"https://api.github.com/users/mikedanese/received_events","type":"User","site_admin":false},{"login":"luxas","id":5442475,"avatar_url":"https://avatars2.githubusercontent.com/u/5442475?v=3","gravatar_id":"","url":"https://api.github.com/users/luxas","html_url":"https://github.com/luxas","followers_url":"https://api.github.com/users/luxas/followers","following_url":"https://api.github.com/users/luxas/following{/other_user}","gists_url":"https://api.github.com/users/luxas/gists{/gist_id}","starred_url":"https://api.github.com/users/luxas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luxas/subscriptions","organizations_url":"https://api.github.com/users/luxas/orgs","repos_url":"https://api.github.com/users/luxas/repos","events_url":"https://api.github.com/users/luxas/events{/privacy}","received_events_url":"https://api.github.com/users/luxas/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/44588/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/44588/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/44588/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/a85e1b209fe6e4409072f30d3def3881b96736c9","head":{"label":"dmmcquay:kubeadm_skip_token_print","ref":"kubeadm_skip_token_print","sha":"a85e1b209fe6e4409072f30d3def3881b96736c9","user":{"login":"dmmcquay","id":1700422,"avatar_url":"https://avatars1.githubusercontent.com/u/1700422?v=3","gravatar_id":"","url":"https://api.github.com/users/dmmcquay","html_url":"https://github.com/dmmcquay","followers_url":"https://api.github.com/users/dmmcquay/followers","following_url":"https://api.github.com/users/dmmcquay/following{/other_user}","gists_url":"https://api.github.com/users/dmmcquay/gists{/gist_id}","starred_url":"https://api.github.com/users/dmmcquay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmmcquay/subscriptions","organizations_url":"https://api.github.com/users/dmmcquay/orgs","repos_url":"https://api.github.com/users/dmmcquay/repos","events_url":"https://api.github.com/users/dmmcquay/events{/privacy}","received_events_url":"https://api.github.com/users/dmmcquay/received_events","type":"User","site_admin":false},"repo":{"id":86831657,"name":"kubernetes","full_name":"dmmcquay/kubernetes","owner":{"login":"dmmcquay","id":1700422,"avatar_url":"https://avatars1.githubusercontent.com/u/1700422?v=3","gravatar_id":"","url":"https://api.github.com/users/dmmcquay","html_url":"https://github.com/dmmcquay","followers_url":"https://api.github.com/users/dmmcquay/followers","following_url":"https://api.github.com/users/dmmcquay/following{/other_user}","gists_url":"https://api.github.com/users/dmmcquay/gists{/gist_id}","starred_url":"https://api.github.com/users/dmmcquay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmmcquay/subscriptions","organizations_url":"https://api.github.com/users/dmmcquay/orgs","repos_url":"https://api.github.com/users/dmmcquay/repos","events_url":"https://api.github.com/users/dmmcquay/events{/privacy}","received_events_url":"https://api.github.com/users/dmmcquay/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dmmcquay/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/dmmcquay/kubernetes","forks_url":"https://api.github.com/repos/dmmcquay/kubernetes/forks","keys_url":"https://api.github.com/repos/dmmcquay/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dmmcquay/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dmmcquay/kubernetes/teams","hooks_url":"https://api.github.com/repos/dmmcquay/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/dmmcquay/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/dmmcquay/kubernetes/events","assignees_url":"https://api.github.com/repos/dmmcquay/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/dmmcquay/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/dmmcquay/kubernetes/tags","blobs_url":"https://api.github.com/repos/dmmcquay/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dmmcquay/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dmmcquay/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/dmmcquay/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dmmcquay/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/dmmcquay/kubernetes/languages","stargazers_url":"https://api.github.com/repos/dmmcquay/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/dmmcquay/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/dmmcquay/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/dmmcquay/kubernetes/subscription","commits_url":"https://api.github.com/repos/dmmcquay/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/dmmcquay/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/dmmcquay/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/dmmcquay/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/dmmcquay/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/dmmcquay/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dmmcquay/kubernetes/merges","archive_url":"https://api.github.com/repos/dmmcquay/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dmmcquay/kubernetes/downloads","issues_url":"https://api.github.com/repos/dmmcquay/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/dmmcquay/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/dmmcquay/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/dmmcquay/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dmmcquay/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/dmmcquay/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/dmmcquay/kubernetes/deployments","created_at":"2017-03-31T15:04:57Z","updated_at":"2017-03-31T15:05:31Z","pushed_at":"2017-04-20T16:47:22Z","git_url":"git://github.com/dmmcquay/kubernetes.git","ssh_url":"git@github.com:dmmcquay/kubernetes.git","clone_url":"https://github.com/dmmcquay/kubernetes.git","svn_url":"https://github.com/dmmcquay/kubernetes","homepage":"http://kubernetes.io","size":424399,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"2e677a5f800b315aafa12b7752756495ee749528","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars1.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars1.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2017-04-20T16:40:34Z","pushed_at":"2017-04-20T16:58:41Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":625212,"stargazers_count":22511,"watchers_count":22511,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":7844,"mirror_url":null,"open_issues_count":5706,"forks":7844,"open_issues":5706,"watchers":22511,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/44588"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/44588"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/44588"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/44588/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/44588/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/44588/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/a85e1b209fe6e4409072f30d3def3881b96736c9"}}}}
{"actor":{"display_login":"luxas"}}