{"action":"created","comment":{"url":"https://api.github.com/repos/trill-lang/LLVMSwift/pulls/comments/117382989","pull_request_review_id":39087640,"id":117382989,"diff_hunk":"@@ -24,6 +24,12 @@ public struct PointerType: IRType {\n   /// - parameter addressSpace: The optional address space where the pointed-to\n   ///   object resides.\n   public init(pointee: IRType, addressSpace: Int = 0) {\n+    // FIXME: This class of invalid reference is not caught by Module.verify(),\n+    // only `lli`.\n+    if LLVMGetTypeKind(pointee.asLLVM()) == LLVMVoidTypeKind {","path":"Sources/LLVM/PointerType.swift","position":6,"original_position":6,"commit_id":"7d7fea1e6b9fa9cfe2e5d1fad3450b3dfde528fa","original_commit_id":"7d7fea1e6b9fa9cfe2e5d1fad3450b3dfde528fa","user":{"login":"harlanhaskins","id":853032,"avatar_url":"https://avatars2.githubusercontent.com/u/853032?v=3","gravatar_id":"","url":"https://api.github.com/users/harlanhaskins","html_url":"https://github.com/harlanhaskins","followers_url":"https://api.github.com/users/harlanhaskins/followers","following_url":"https://api.github.com/users/harlanhaskins/following{/other_user}","gists_url":"https://api.github.com/users/harlanhaskins/gists{/gist_id}","starred_url":"https://api.github.com/users/harlanhaskins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harlanhaskins/subscriptions","organizations_url":"https://api.github.com/users/harlanhaskins/orgs","repos_url":"https://api.github.com/users/harlanhaskins/repos","events_url":"https://api.github.com/users/harlanhaskins/events{/privacy}","received_events_url":"https://api.github.com/users/harlanhaskins/received_events","type":"User","site_admin":false},"body":"`pointee is VoidType`, no? `LLVMTypeRef` doesn't conform to `IRType` and it's guaranteed that an `IRType` with kind `LLVMVoidTypeKind` is going to be `VoidType`","created_at":"2017-05-19T00:29:04Z","updated_at":"2017-05-19T00:29:41Z","html_url":"https://github.com/trill-lang/LLVMSwift/pull/90#discussion_r117382989","pull_request_url":"https://api.github.com/repos/trill-lang/LLVMSwift/pulls/90","_links":{"self":{"href":"https://api.github.com/repos/trill-lang/LLVMSwift/pulls/comments/117382989"},"html":{"href":"https://github.com/trill-lang/LLVMSwift/pull/90#discussion_r117382989"},"pull_request":{"href":"https://api.github.com/repos/trill-lang/LLVMSwift/pulls/90"}}},"pull_request":{"url":"https://api.github.com/repos/trill-lang/LLVMSwift/pulls/90","id":121356164,"html_url":"https://github.com/trill-lang/LLVMSwift/pull/90","diff_url":"https://github.com/trill-lang/LLVMSwift/pull/90.diff","patch_url":"https://github.com/trill-lang/LLVMSwift/pull/90.patch","issue_url":"https://api.github.com/repos/trill-lang/LLVMSwift/issues/90","number":90,"state":"open","locked":false,"title":"[WIP] Lift some lli verification checks","user":{"login":"CodaFi","id":1896383,"avatar_url":"https://avatars0.githubusercontent.com/u/1896383?v=3","gravatar_id":"","url":"https://api.github.com/users/CodaFi","html_url":"https://github.com/CodaFi","followers_url":"https://api.github.com/users/CodaFi/followers","following_url":"https://api.github.com/users/CodaFi/following{/other_user}","gists_url":"https://api.github.com/users/CodaFi/gists{/gist_id}","starred_url":"https://api.github.com/users/CodaFi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CodaFi/subscriptions","organizations_url":"https://api.github.com/users/CodaFi/orgs","repos_url":"https://api.github.com/users/CodaFi/repos","events_url":"https://api.github.com/users/CodaFi/events{/privacy}","received_events_url":"https://api.github.com/users/CodaFi/received_events","type":"User","site_admin":false},"body":"Some temporary fixes for lli being stricter than the LLVM verifier.\r\n\r\n- [x] Disallow formation of pointers to void\r\n","created_at":"2017-05-18T19:09:39Z","updated_at":"2017-05-19T00:29:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4ec338908ede6be6e83ea3b236ed2ac186db4e0f","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/trill-lang/LLVMSwift/pulls/90/commits","review_comments_url":"https://api.github.com/repos/trill-lang/LLVMSwift/pulls/90/comments","review_comment_url":"https://api.github.com/repos/trill-lang/LLVMSwift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/trill-lang/LLVMSwift/issues/90/comments","statuses_url":"https://api.github.com/repos/trill-lang/LLVMSwift/statuses/7d7fea1e6b9fa9cfe2e5d1fad3450b3dfde528fa","head":{"label":"CodaFi:low-level-verified-module","ref":"low-level-verified-module","sha":"7d7fea1e6b9fa9cfe2e5d1fad3450b3dfde528fa","user":{"login":"CodaFi","id":1896383,"avatar_url":"https://avatars0.githubusercontent.com/u/1896383?v=3","gravatar_id":"","url":"https://api.github.com/users/CodaFi","html_url":"https://github.com/CodaFi","followers_url":"https://api.github.com/users/CodaFi/followers","following_url":"https://api.github.com/users/CodaFi/following{/other_user}","gists_url":"https://api.github.com/users/CodaFi/gists{/gist_id}","starred_url":"https://api.github.com/users/CodaFi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CodaFi/subscriptions","organizations_url":"https://api.github.com/users/CodaFi/orgs","repos_url":"https://api.github.com/users/CodaFi/repos","events_url":"https://api.github.com/users/CodaFi/events{/privacy}","received_events_url":"https://api.github.com/users/CodaFi/received_events","type":"User","site_admin":false},"repo":{"id":78398191,"name":"LLVMSwift","full_name":"CodaFi/LLVMSwift","owner":{"login":"CodaFi","id":1896383,"avatar_url":"https://avatars0.githubusercontent.com/u/1896383?v=3","gravatar_id":"","url":"https://api.github.com/users/CodaFi","html_url":"https://github.com/CodaFi","followers_url":"https://api.github.com/users/CodaFi/followers","following_url":"https://api.github.com/users/CodaFi/following{/other_user}","gists_url":"https://api.github.com/users/CodaFi/gists{/gist_id}","starred_url":"https://api.github.com/users/CodaFi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CodaFi/subscriptions","organizations_url":"https://api.github.com/users/CodaFi/orgs","repos_url":"https://api.github.com/users/CodaFi/repos","events_url":"https://api.github.com/users/CodaFi/events{/privacy}","received_events_url":"https://api.github.com/users/CodaFi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/CodaFi/LLVMSwift","description":"A Swifty wrapper for the LLVM C API version 3.9.1","fork":true,"url":"https://api.github.com/repos/CodaFi/LLVMSwift","forks_url":"https://api.github.com/repos/CodaFi/LLVMSwift/forks","keys_url":"https://api.github.com/repos/CodaFi/LLVMSwift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CodaFi/LLVMSwift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CodaFi/LLVMSwift/teams","hooks_url":"https://api.github.com/repos/CodaFi/LLVMSwift/hooks","issue_events_url":"https://api.github.com/repos/CodaFi/LLVMSwift/issues/events{/number}","events_url":"https://api.github.com/repos/CodaFi/LLVMSwift/events","assignees_url":"https://api.github.com/repos/CodaFi/LLVMSwift/assignees{/user}","branches_url":"https://api.github.com/repos/CodaFi/LLVMSwift/branches{/branch}","tags_url":"https://api.github.com/repos/CodaFi/LLVMSwift/tags","blobs_url":"https://api.github.com/repos/CodaFi/LLVMSwift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CodaFi/LLVMSwift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CodaFi/LLVMSwift/git/refs{/sha}","trees_url":"https://api.github.com/repos/CodaFi/LLVMSwift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CodaFi/LLVMSwift/statuses/{sha}","languages_url":"https://api.github.com/repos/CodaFi/LLVMSwift/languages","stargazers_url":"https://api.github.com/repos/CodaFi/LLVMSwift/stargazers","contributors_url":"https://api.github.com/repos/CodaFi/LLVMSwift/contributors","subscribers_url":"https://api.github.com/repos/CodaFi/LLVMSwift/subscribers","subscription_url":"https://api.github.com/repos/CodaFi/LLVMSwift/subscription","commits_url":"https://api.github.com/repos/CodaFi/LLVMSwift/commits{/sha}","git_commits_url":"https://api.github.com/repos/CodaFi/LLVMSwift/git/commits{/sha}","comments_url":"https://api.github.com/repos/CodaFi/LLVMSwift/comments{/number}","issue_comment_url":"https://api.github.com/repos/CodaFi/LLVMSwift/issues/comments{/number}","contents_url":"https://api.github.com/repos/CodaFi/LLVMSwift/contents/{+path}","compare_url":"https://api.github.com/repos/CodaFi/LLVMSwift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CodaFi/LLVMSwift/merges","archive_url":"https://api.github.com/repos/CodaFi/LLVMSwift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CodaFi/LLVMSwift/downloads","issues_url":"https://api.github.com/repos/CodaFi/LLVMSwift/issues{/number}","pulls_url":"https://api.github.com/repos/CodaFi/LLVMSwift/pulls{/number}","milestones_url":"https://api.github.com/repos/CodaFi/LLVMSwift/milestones{/number}","notifications_url":"https://api.github.com/repos/CodaFi/LLVMSwift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CodaFi/LLVMSwift/labels{/name}","releases_url":"https://api.github.com/repos/CodaFi/LLVMSwift/releases{/id}","deployments_url":"https://api.github.com/repos/CodaFi/LLVMSwift/deployments","created_at":"2017-01-09T05:55:13Z","updated_at":"2017-01-09T05:55:14Z","pushed_at":"2017-05-18T19:01:53Z","git_url":"git://github.com/CodaFi/LLVMSwift.git","ssh_url":"git@github.com:CodaFi/LLVMSwift.git","clone_url":"https://github.com/CodaFi/LLVMSwift.git","svn_url":"https://github.com/CodaFi/LLVMSwift","homepage":null,"size":2577,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"trill-lang:master","ref":"master","sha":"ca83e1c6025ea5244add9aee16b6dc470358153c","user":{"login":"trill-lang","id":25160735,"avatar_url":"https://avatars2.githubusercontent.com/u/25160735?v=3","gravatar_id":"","url":"https://api.github.com/users/trill-lang","html_url":"https://github.com/trill-lang","followers_url":"https://api.github.com/users/trill-lang/followers","following_url":"https://api.github.com/users/trill-lang/following{/other_user}","gists_url":"https://api.github.com/users/trill-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/trill-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trill-lang/subscriptions","organizations_url":"https://api.github.com/users/trill-lang/orgs","repos_url":"https://api.github.com/users/trill-lang/repos","events_url":"https://api.github.com/users/trill-lang/events{/privacy}","received_events_url":"https://api.github.com/users/trill-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":78325183,"name":"LLVMSwift","full_name":"trill-lang/LLVMSwift","owner":{"login":"trill-lang","id":25160735,"avatar_url":"https://avatars2.githubusercontent.com/u/25160735?v=3","gravatar_id":"","url":"https://api.github.com/users/trill-lang","html_url":"https://github.com/trill-lang","followers_url":"https://api.github.com/users/trill-lang/followers","following_url":"https://api.github.com/users/trill-lang/following{/other_user}","gists_url":"https://api.github.com/users/trill-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/trill-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trill-lang/subscriptions","organizations_url":"https://api.github.com/users/trill-lang/orgs","repos_url":"https://api.github.com/users/trill-lang/repos","events_url":"https://api.github.com/users/trill-lang/events{/privacy}","received_events_url":"https://api.github.com/users/trill-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/trill-lang/LLVMSwift","description":"A Swift wrapper for the LLVM C API (version 4.0)","fork":false,"url":"https://api.github.com/repos/trill-lang/LLVMSwift","forks_url":"https://api.github.com/repos/trill-lang/LLVMSwift/forks","keys_url":"https://api.github.com/repos/trill-lang/LLVMSwift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trill-lang/LLVMSwift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trill-lang/LLVMSwift/teams","hooks_url":"https://api.github.com/repos/trill-lang/LLVMSwift/hooks","issue_events_url":"https://api.github.com/repos/trill-lang/LLVMSwift/issues/events{/number}","events_url":"https://api.github.com/repos/trill-lang/LLVMSwift/events","assignees_url":"https://api.github.com/repos/trill-lang/LLVMSwift/assignees{/user}","branches_url":"https://api.github.com/repos/trill-lang/LLVMSwift/branches{/branch}","tags_url":"https://api.github.com/repos/trill-lang/LLVMSwift/tags","blobs_url":"https://api.github.com/repos/trill-lang/LLVMSwift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trill-lang/LLVMSwift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trill-lang/LLVMSwift/git/refs{/sha}","trees_url":"https://api.github.com/repos/trill-lang/LLVMSwift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trill-lang/LLVMSwift/statuses/{sha}","languages_url":"https://api.github.com/repos/trill-lang/LLVMSwift/languages","stargazers_url":"https://api.github.com/repos/trill-lang/LLVMSwift/stargazers","contributors_url":"https://api.github.com/repos/trill-lang/LLVMSwift/contributors","subscribers_url":"https://api.github.com/repos/trill-lang/LLVMSwift/subscribers","subscription_url":"https://api.github.com/repos/trill-lang/LLVMSwift/subscription","commits_url":"https://api.github.com/repos/trill-lang/LLVMSwift/commits{/sha}","git_commits_url":"https://api.github.com/repos/trill-lang/LLVMSwift/git/commits{/sha}","comments_url":"https://api.github.com/repos/trill-lang/LLVMSwift/comments{/number}","issue_comment_url":"https://api.github.com/repos/trill-lang/LLVMSwift/issues/comments{/number}","contents_url":"https://api.github.com/repos/trill-lang/LLVMSwift/contents/{+path}","compare_url":"https://api.github.com/repos/trill-lang/LLVMSwift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trill-lang/LLVMSwift/merges","archive_url":"https://api.github.com/repos/trill-lang/LLVMSwift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trill-lang/LLVMSwift/downloads","issues_url":"https://api.github.com/repos/trill-lang/LLVMSwift/issues{/number}","pulls_url":"https://api.github.com/repos/trill-lang/LLVMSwift/pulls{/number}","milestones_url":"https://api.github.com/repos/trill-lang/LLVMSwift/milestones{/number}","notifications_url":"https://api.github.com/repos/trill-lang/LLVMSwift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trill-lang/LLVMSwift/labels{/name}","releases_url":"https://api.github.com/repos/trill-lang/LLVMSwift/releases{/id}","deployments_url":"https://api.github.com/repos/trill-lang/LLVMSwift/deployments","created_at":"2017-01-08T06:10:37Z","updated_at":"2017-05-15T01:59:18Z","pushed_at":"2017-05-18T19:09:40Z","git_url":"git://github.com/trill-lang/LLVMSwift.git","ssh_url":"git@github.com:trill-lang/LLVMSwift.git","clone_url":"https://github.com/trill-lang/LLVMSwift.git","svn_url":"https://github.com/trill-lang/LLVMSwift","homepage":"","size":2800,"stargazers_count":214,"watchers_count":214,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5,"mirror_url":null,"open_issues_count":7,"forks":5,"open_issues":7,"watchers":214,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/trill-lang/LLVMSwift/pulls/90"},"html":{"href":"https://github.com/trill-lang/LLVMSwift/pull/90"},"issue":{"href":"https://api.github.com/repos/trill-lang/LLVMSwift/issues/90"},"comments":{"href":"https://api.github.com/repos/trill-lang/LLVMSwift/issues/90/comments"},"review_comments":{"href":"https://api.github.com/repos/trill-lang/LLVMSwift/pulls/90/comments"},"review_comment":{"href":"https://api.github.com/repos/trill-lang/LLVMSwift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/trill-lang/LLVMSwift/pulls/90/commits"},"statuses":{"href":"https://api.github.com/repos/trill-lang/LLVMSwift/statuses/7d7fea1e6b9fa9cfe2e5d1fad3450b3dfde528fa"}}}}
{"actor":{"display_login":"harlanhaskins"}}