{"action":"created","issue":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/8542","repository_url":"https://api.github.com/repos/scikit-learn/scikit-learn","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/8542/labels{/name}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/8542/comments","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/8542/events","html_url":"https://github.com/scikit-learn/scikit-learn/pull/8542","id":212139947,"number":8542,"title":"[MRG+1] Added v2 Custom Search API and fixed css placement for search box","user":{"login":"Trion129","id":8445249,"avatar_url":"https://avatars1.githubusercontent.com/u/8445249?v=3","gravatar_id":"","url":"https://api.github.com/users/Trion129","html_url":"https://github.com/Trion129","followers_url":"https://api.github.com/users/Trion129/followers","following_url":"https://api.github.com/users/Trion129/following{/other_user}","gists_url":"https://api.github.com/users/Trion129/gists{/gist_id}","starred_url":"https://api.github.com/users/Trion129/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Trion129/subscriptions","organizations_url":"https://api.github.com/users/Trion129/orgs","repos_url":"https://api.github.com/users/Trion129/repos","events_url":"https://api.github.com/users/Trion129/events{/privacy}","received_events_url":"https://api.github.com/users/Trion129/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-03-06T14:34:40Z","updated_at":"2017-03-06T21:52:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/8542","html_url":"https://github.com/scikit-learn/scikit-learn/pull/8542","diff_url":"https://github.com/scikit-learn/scikit-learn/pull/8542.diff","patch_url":"https://github.com/scikit-learn/scikit-learn/pull/8542.patch"},"body":"<!--\r\nThanks for contributing a pull request! Please ensure you have taken a look at\r\nthe contribution guidelines: https://github.com/scikit-learn/scikit-learn/blob/master/CONTRIBUTING.md#Contributing-Pull-Requests\r\n-->\r\n#### Reference Issue\r\nFixes #8388\r\n\r\n\r\n#### What does this implement/fix? Explain your changes.\r\nI changed the old Custom Search API with v2 as the one used currently was deprecated. That fixed the Powered by Google. This caused wrong placement of search box though, so I changed the earlier value in css to fix the positioning. \r\n\r\n<!--\r\nPlease be aware that we are a loose team of volunteers so patience is\r\nnecessary; assistance handling other issues is very welcome. We value\r\nall user contributions, no matter how minor they are. If we are slow to\r\nreview, either the pull request needs some benchmarking, tinkering,\r\nconvincing, etc. or more likely the reviewers are simply busy. In either\r\ncase, we ask for your understanding during the review process.\r\nFor more information, see our FAQ on this topic:\r\nhttp://scikit-learn.org/dev/faq.html#why-is-my-pull-request-not-getting-any-attention.\r\n\r\nThanks for contributing!\r\n-->\r\n"},"comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments/284545450","html_url":"https://github.com/scikit-learn/scikit-learn/pull/8542#issuecomment-284545450","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/8542","id":284545450,"user":{"login":"GaelVaroquaux","id":208217,"avatar_url":"https://avatars0.githubusercontent.com/u/208217?v=3","gravatar_id":"","url":"https://api.github.com/users/GaelVaroquaux","html_url":"https://github.com/GaelVaroquaux","followers_url":"https://api.github.com/users/GaelVaroquaux/followers","following_url":"https://api.github.com/users/GaelVaroquaux/following{/other_user}","gists_url":"https://api.github.com/users/GaelVaroquaux/gists{/gist_id}","starred_url":"https://api.github.com/users/GaelVaroquaux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GaelVaroquaux/subscriptions","organizations_url":"https://api.github.com/users/GaelVaroquaux/orgs","repos_url":"https://api.github.com/users/GaelVaroquaux/repos","events_url":"https://api.github.com/users/GaelVaroquaux/events{/privacy}","received_events_url":"https://api.github.com/users/GaelVaroquaux/received_events","type":"User","site_admin":false},"created_at":"2017-03-06T21:52:55Z","updated_at":"2017-03-06T21:52:55Z","body":"I am seeing the same now. Strangely, I am pretty that I did not see this when I did the initial review.\r\n\r\nI am removing my +1 until we figure out what is happening."}}
{"actor":{"display_login":"GaelVaroquaux"}}