{"action":"opened","number":1,"pull_request":{"url":"https://api.github.com/repos/odopod/code-library/pulls/1","id":134009502,"html_url":"https://github.com/odopod/code-library/pull/1","diff_url":"https://github.com/odopod/code-library/pull/1.diff","patch_url":"https://github.com/odopod/code-library/pull/1.patch","issue_url":"https://api.github.com/repos/odopod/code-library/issues/1","number":1,"state":"open","locked":false,"title":"Switch to Karma","user":{"login":"Vestride","id":963921,"avatar_url":"https://avatars0.githubusercontent.com/u/963921?v=4","gravatar_id":"","url":"https://api.github.com/users/Vestride","html_url":"https://github.com/Vestride","followers_url":"https://api.github.com/users/Vestride/followers","following_url":"https://api.github.com/users/Vestride/following{/other_user}","gists_url":"https://api.github.com/users/Vestride/gists{/gist_id}","starred_url":"https://api.github.com/users/Vestride/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vestride/subscriptions","organizations_url":"https://api.github.com/users/Vestride/orgs","repos_url":"https://api.github.com/users/Vestride/repos","events_url":"https://api.github.com/users/Vestride/events{/privacy}","received_events_url":"https://api.github.com/users/Vestride/received_events","type":"User","site_admin":false},"body":"Motivations:\r\n\r\n* PhantomJS [will no longer be maintained](https://groups.google.com/forum/#!topic/phantomjs/9aI5d-LDuNE) in favor of headless Chrome.\r\n* `karma-coverage` uses istanbul 0.4.5 (although the [istanbul package is now deprecated](https://github.com/gotwarlost/istanbul)). We were using `gulp-istanbul-report` which uses 0.3.5 and has a pull request open from more than a year ago to update it.\r\n* Testing in headless Chrome is better than testing in PhantomJS because Phantom is an old version of webkit.\r\n* Tests now run much faster locally. From ~4.5 minutes to ~2.5 minutes for me.\r\n* We can test in other browsers too if we want (but will obviously make test/build times longer).\r\n\r\nDownsides:\r\n\r\n* It's no longer as easy to debug the test runner in browsers. You can, however, switch the `browsers` field in the top-level `karma.conf.js` from `['ChromeHeadless']` to `['Chrome']`, then use the gulp `test-watch` task to keep the browser open between tests, and finally click the \"debug\" button which will open the test runner in a new tab.\r\n* Karma needs more support than it's getting (see issue 2474).\r\n* Karma doesn't support multiple `files` configs, so we're still running all tests sequentially in new instances of Karma instead of all at once.\r\n* Karma runs the entire test suite when a single test changes (same as we had before) (whereas AVA and Jest are smart enough to only run what's needed).\r\n* Speaking of AVA and Jest, they still don't support testing in-browser. JSDom doesn't count.\r\n","created_at":"2017-08-03T18:19:54Z","updated_at":"2017-08-03T18:19:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/odopod/code-library/pulls/1/commits","review_comments_url":"https://api.github.com/repos/odopod/code-library/pulls/1/comments","review_comment_url":"https://api.github.com/repos/odopod/code-library/pulls/comments{/number}","comments_url":"https://api.github.com/repos/odopod/code-library/issues/1/comments","statuses_url":"https://api.github.com/repos/odopod/code-library/statuses/73ff17c6c1ef18ea9b12407544554e323b770580","head":{"label":"odopod:karma","ref":"karma","sha":"73ff17c6c1ef18ea9b12407544554e323b770580","user":{"login":"odopod","id":2158422,"avatar_url":"https://avatars2.githubusercontent.com/u/2158422?v=4","gravatar_id":"","url":"https://api.github.com/users/odopod","html_url":"https://github.com/odopod","followers_url":"https://api.github.com/users/odopod/followers","following_url":"https://api.github.com/users/odopod/following{/other_user}","gists_url":"https://api.github.com/users/odopod/gists{/gist_id}","starred_url":"https://api.github.com/users/odopod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odopod/subscriptions","organizations_url":"https://api.github.com/users/odopod/orgs","repos_url":"https://api.github.com/users/odopod/repos","events_url":"https://api.github.com/users/odopod/events{/privacy}","received_events_url":"https://api.github.com/users/odopod/received_events","type":"Organization","site_admin":false},"repo":{"id":97986488,"name":"code-library","full_name":"odopod/code-library","owner":{"login":"odopod","id":2158422,"avatar_url":"https://avatars2.githubusercontent.com/u/2158422?v=4","gravatar_id":"","url":"https://api.github.com/users/odopod","html_url":"https://github.com/odopod","followers_url":"https://api.github.com/users/odopod/followers","following_url":"https://api.github.com/users/odopod/following{/other_user}","gists_url":"https://api.github.com/users/odopod/gists{/gist_id}","starred_url":"https://api.github.com/users/odopod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odopod/subscriptions","organizations_url":"https://api.github.com/users/odopod/orgs","repos_url":"https://api.github.com/users/odopod/repos","events_url":"https://api.github.com/users/odopod/events{/privacy}","received_events_url":"https://api.github.com/users/odopod/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/odopod/code-library","description":"A collection of vanilla JavaScript components used in Odopod projects.","fork":false,"url":"https://api.github.com/repos/odopod/code-library","forks_url":"https://api.github.com/repos/odopod/code-library/forks","keys_url":"https://api.github.com/repos/odopod/code-library/keys{/key_id}","collaborators_url":"https://api.github.com/repos/odopod/code-library/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/odopod/code-library/teams","hooks_url":"https://api.github.com/repos/odopod/code-library/hooks","issue_events_url":"https://api.github.com/repos/odopod/code-library/issues/events{/number}","events_url":"https://api.github.com/repos/odopod/code-library/events","assignees_url":"https://api.github.com/repos/odopod/code-library/assignees{/user}","branches_url":"https://api.github.com/repos/odopod/code-library/branches{/branch}","tags_url":"https://api.github.com/repos/odopod/code-library/tags","blobs_url":"https://api.github.com/repos/odopod/code-library/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/odopod/code-library/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/odopod/code-library/git/refs{/sha}","trees_url":"https://api.github.com/repos/odopod/code-library/git/trees{/sha}","statuses_url":"https://api.github.com/repos/odopod/code-library/statuses/{sha}","languages_url":"https://api.github.com/repos/odopod/code-library/languages","stargazers_url":"https://api.github.com/repos/odopod/code-library/stargazers","contributors_url":"https://api.github.com/repos/odopod/code-library/contributors","subscribers_url":"https://api.github.com/repos/odopod/code-library/subscribers","subscription_url":"https://api.github.com/repos/odopod/code-library/subscription","commits_url":"https://api.github.com/repos/odopod/code-library/commits{/sha}","git_commits_url":"https://api.github.com/repos/odopod/code-library/git/commits{/sha}","comments_url":"https://api.github.com/repos/odopod/code-library/comments{/number}","issue_comment_url":"https://api.github.com/repos/odopod/code-library/issues/comments{/number}","contents_url":"https://api.github.com/repos/odopod/code-library/contents/{+path}","compare_url":"https://api.github.com/repos/odopod/code-library/compare/{base}...{head}","merges_url":"https://api.github.com/repos/odopod/code-library/merges","archive_url":"https://api.github.com/repos/odopod/code-library/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/odopod/code-library/downloads","issues_url":"https://api.github.com/repos/odopod/code-library/issues{/number}","pulls_url":"https://api.github.com/repos/odopod/code-library/pulls{/number}","milestones_url":"https://api.github.com/repos/odopod/code-library/milestones{/number}","notifications_url":"https://api.github.com/repos/odopod/code-library/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/odopod/code-library/labels{/name}","releases_url":"https://api.github.com/repos/odopod/code-library/releases{/id}","deployments_url":"https://api.github.com/repos/odopod/code-library/deployments","created_at":"2017-07-21T21:05:07Z","updated_at":"2017-07-26T00:45:52Z","pushed_at":"2017-08-03T17:44:53Z","git_url":"git://github.com/odopod/code-library.git","ssh_url":"git@github.com:odopod/code-library.git","clone_url":"https://github.com/odopod/code-library.git","svn_url":"https://github.com/odopod/code-library","homepage":"http://code.odopod.com","size":1476,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":5,"default_branch":"master"}},"base":{"label":"odopod:master","ref":"master","sha":"14dc5086e2d545f7f6141c63f4077a1c57cc2e93","user":{"login":"odopod","id":2158422,"avatar_url":"https://avatars2.githubusercontent.com/u/2158422?v=4","gravatar_id":"","url":"https://api.github.com/users/odopod","html_url":"https://github.com/odopod","followers_url":"https://api.github.com/users/odopod/followers","following_url":"https://api.github.com/users/odopod/following{/other_user}","gists_url":"https://api.github.com/users/odopod/gists{/gist_id}","starred_url":"https://api.github.com/users/odopod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odopod/subscriptions","organizations_url":"https://api.github.com/users/odopod/orgs","repos_url":"https://api.github.com/users/odopod/repos","events_url":"https://api.github.com/users/odopod/events{/privacy}","received_events_url":"https://api.github.com/users/odopod/received_events","type":"Organization","site_admin":false},"repo":{"id":97986488,"name":"code-library","full_name":"odopod/code-library","owner":{"login":"odopod","id":2158422,"avatar_url":"https://avatars2.githubusercontent.com/u/2158422?v=4","gravatar_id":"","url":"https://api.github.com/users/odopod","html_url":"https://github.com/odopod","followers_url":"https://api.github.com/users/odopod/followers","following_url":"https://api.github.com/users/odopod/following{/other_user}","gists_url":"https://api.github.com/users/odopod/gists{/gist_id}","starred_url":"https://api.github.com/users/odopod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odopod/subscriptions","organizations_url":"https://api.github.com/users/odopod/orgs","repos_url":"https://api.github.com/users/odopod/repos","events_url":"https://api.github.com/users/odopod/events{/privacy}","received_events_url":"https://api.github.com/users/odopod/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/odopod/code-library","description":"A collection of vanilla JavaScript components used in Odopod projects.","fork":false,"url":"https://api.github.com/repos/odopod/code-library","forks_url":"https://api.github.com/repos/odopod/code-library/forks","keys_url":"https://api.github.com/repos/odopod/code-library/keys{/key_id}","collaborators_url":"https://api.github.com/repos/odopod/code-library/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/odopod/code-library/teams","hooks_url":"https://api.github.com/repos/odopod/code-library/hooks","issue_events_url":"https://api.github.com/repos/odopod/code-library/issues/events{/number}","events_url":"https://api.github.com/repos/odopod/code-library/events","assignees_url":"https://api.github.com/repos/odopod/code-library/assignees{/user}","branches_url":"https://api.github.com/repos/odopod/code-library/branches{/branch}","tags_url":"https://api.github.com/repos/odopod/code-library/tags","blobs_url":"https://api.github.com/repos/odopod/code-library/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/odopod/code-library/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/odopod/code-library/git/refs{/sha}","trees_url":"https://api.github.com/repos/odopod/code-library/git/trees{/sha}","statuses_url":"https://api.github.com/repos/odopod/code-library/statuses/{sha}","languages_url":"https://api.github.com/repos/odopod/code-library/languages","stargazers_url":"https://api.github.com/repos/odopod/code-library/stargazers","contributors_url":"https://api.github.com/repos/odopod/code-library/contributors","subscribers_url":"https://api.github.com/repos/odopod/code-library/subscribers","subscription_url":"https://api.github.com/repos/odopod/code-library/subscription","commits_url":"https://api.github.com/repos/odopod/code-library/commits{/sha}","git_commits_url":"https://api.github.com/repos/odopod/code-library/git/commits{/sha}","comments_url":"https://api.github.com/repos/odopod/code-library/comments{/number}","issue_comment_url":"https://api.github.com/repos/odopod/code-library/issues/comments{/number}","contents_url":"https://api.github.com/repos/odopod/code-library/contents/{+path}","compare_url":"https://api.github.com/repos/odopod/code-library/compare/{base}...{head}","merges_url":"https://api.github.com/repos/odopod/code-library/merges","archive_url":"https://api.github.com/repos/odopod/code-library/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/odopod/code-library/downloads","issues_url":"https://api.github.com/repos/odopod/code-library/issues{/number}","pulls_url":"https://api.github.com/repos/odopod/code-library/pulls{/number}","milestones_url":"https://api.github.com/repos/odopod/code-library/milestones{/number}","notifications_url":"https://api.github.com/repos/odopod/code-library/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/odopod/code-library/labels{/name}","releases_url":"https://api.github.com/repos/odopod/code-library/releases{/id}","deployments_url":"https://api.github.com/repos/odopod/code-library/deployments","created_at":"2017-07-21T21:05:07Z","updated_at":"2017-07-26T00:45:52Z","pushed_at":"2017-08-03T17:44:53Z","git_url":"git://github.com/odopod/code-library.git","ssh_url":"git@github.com:odopod/code-library.git","clone_url":"https://github.com/odopod/code-library.git","svn_url":"https://github.com/odopod/code-library","homepage":"http://code.odopod.com","size":1476,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/odopod/code-library/pulls/1"},"html":{"href":"https://github.com/odopod/code-library/pull/1"},"issue":{"href":"https://api.github.com/repos/odopod/code-library/issues/1"},"comments":{"href":"https://api.github.com/repos/odopod/code-library/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/odopod/code-library/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/odopod/code-library/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/odopod/code-library/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/odopod/code-library/statuses/73ff17c6c1ef18ea9b12407544554e323b770580"}},"merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":7,"additions":2731,"deletions":3410,"changed_files":199}}
{"actor":{"display_login":"Vestride"}}