{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/12030","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/12030/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/12030/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/12030/events","html_url":"https://github.com/nodejs/node/pull/12030","id":216927814,"number":12030,"title":"benchmark: check end() argument to be > 0","user":{"login":"vsemozhetbyt","id":10393198,"avatar_url":"https://avatars2.githubusercontent.com/u/10393198?v=3","gravatar_id":"","url":"https://api.github.com/users/vsemozhetbyt","html_url":"https://github.com/vsemozhetbyt","followers_url":"https://api.github.com/users/vsemozhetbyt/followers","following_url":"https://api.github.com/users/vsemozhetbyt/following{/other_user}","gists_url":"https://api.github.com/users/vsemozhetbyt/gists{/gist_id}","starred_url":"https://api.github.com/users/vsemozhetbyt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vsemozhetbyt/subscriptions","organizations_url":"https://api.github.com/users/vsemozhetbyt/orgs","repos_url":"https://api.github.com/users/vsemozhetbyt/repos","events_url":"https://api.github.com/users/vsemozhetbyt/events{/privacy}","received_events_url":"https://api.github.com/users/vsemozhetbyt/received_events","type":"User","site_admin":false},"labels":[{"id":191708559,"url":"https://api.github.com/repos/nodejs/node/labels/benchmark","name":"benchmark","color":"009800","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":24,"created_at":"2017-03-24T23:24:24Z","updated_at":"2017-03-26T13:19:35Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/12030","html_url":"https://github.com/nodejs/node/pull/12030","diff_url":"https://github.com/nodejs/node/pull/12030.diff","patch_url":"https://github.com/nodejs/node/pull/12030.patch"},"body":"##### Checklist\r\n- [x] commit message follows [commit guidelines][]\r\n\r\n##### Affected core subsystem(s)\r\nbenchmark\r\n\r\nRefs: https://github.com/nodejs/node/issues/11972\r\n\r\n~~If https://github.com/nodejs/node/issues/11972 is not only my issue, CI should fail due to https://github.com/nodejs/node/commit/0d000ca51f4c274a4786f28019032eca9b74146f~~ (see https://github.com/nodejs/node/pull/12030#issuecomment-289212219)\r\n\r\n[commit guidelines]: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-guidelines\r\n"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/289283458","html_url":"https://github.com/nodejs/node/pull/12030#issuecomment-289283458","issue_url":"https://api.github.com/repos/nodejs/node/issues/12030","id":289283458,"user":{"login":"vsemozhetbyt","id":10393198,"avatar_url":"https://avatars2.githubusercontent.com/u/10393198?v=3","gravatar_id":"","url":"https://api.github.com/users/vsemozhetbyt","html_url":"https://github.com/vsemozhetbyt","followers_url":"https://api.github.com/users/vsemozhetbyt/followers","following_url":"https://api.github.com/users/vsemozhetbyt/following{/other_user}","gists_url":"https://api.github.com/users/vsemozhetbyt/gists{/gist_id}","starred_url":"https://api.github.com/users/vsemozhetbyt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vsemozhetbyt/subscriptions","organizations_url":"https://api.github.com/users/vsemozhetbyt/orgs","repos_url":"https://api.github.com/users/vsemozhetbyt/repos","events_url":"https://api.github.com/users/vsemozhetbyt/events{/privacy}","received_events_url":"https://api.github.com/users/vsemozhetbyt/received_events","type":"User","site_admin":false},"created_at":"2017-03-26T13:19:35Z","updated_at":"2017-03-26T13:19:35Z","body":"@AndreasMadsen\r\nIf I get it all right, `end(0)` is a bug in `tcp-raw-pipe.js` (it seems only in Windows), but unit tests like `test/sequential/test-benchmark-net.js` are not intended to catch such bugs. On the contrary, they intentionally produce the cases when `end(0)` happens. For these tests `NODEJS_BENCHMARK_ZERO_ALLOWED` is set."}}
{"actor":{"display_login":"vsemozhetbyt"}}