{"action":"created","comment":{"url":"https://api.github.com/repos/conan-io/conan/pulls/comments/154605696","pull_request_review_id":80790238,"id":154605696,"diff_hunk":"@@ -18,8 +18,9 @@ def basic_test(self):\n class ConanLib(ConanFile):\n     name = \"zlib\"\n     version = \"0.1\"\n-    options = {\"shared\": [True, False]}\n-    default_options= \"shared=False\"\n+    \n+    def options(self, config):\n+        config.add_shared()","path":"conans/test/options_in_requirements_test.py","position":8,"original_position":8,"commit_id":"87772dcfc454783fba2345532df955020bc4b67d","original_commit_id":"87772dcfc454783fba2345532df955020bc4b67d","user":{"login":"lasote","id":3807515,"avatar_url":"https://avatars1.githubusercontent.com/u/3807515?v=4","gravatar_id":"","url":"https://api.github.com/users/lasote","html_url":"https://github.com/lasote","followers_url":"https://api.github.com/users/lasote/followers","following_url":"https://api.github.com/users/lasote/following{/other_user}","gists_url":"https://api.github.com/users/lasote/gists{/gist_id}","starred_url":"https://api.github.com/users/lasote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lasote/subscriptions","organizations_url":"https://api.github.com/users/lasote/orgs","repos_url":"https://api.github.com/users/lasote/repos","events_url":"https://api.github.com/users/lasote/events{/privacy}","received_events_url":"https://api.github.com/users/lasote/received_events","type":"User","site_admin":false},"body":"`self.options.add_option(\"flavour\", [\"choco\", \"strawberry\", \"orange\"], \"orange\")`\r\nIt has to be added to the docs, of course","created_at":"2017-12-04T10:12:05Z","updated_at":"2017-12-04T10:12:05Z","html_url":"https://github.com/conan-io/conan/pull/2042#discussion_r154605696","pull_request_url":"https://api.github.com/repos/conan-io/conan/pulls/2042","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/conan-io/conan/pulls/comments/154605696"},"html":{"href":"https://github.com/conan-io/conan/pull/2042#discussion_r154605696"},"pull_request":{"href":"https://api.github.com/repos/conan-io/conan/pulls/2042"}},"in_reply_to_id":153156440},"pull_request":{"url":"https://api.github.com/repos/conan-io/conan/pulls/2042","id":153305925,"html_url":"https://github.com/conan-io/conan/pull/2042","diff_url":"https://github.com/conan-io/conan/pull/2042.diff","patch_url":"https://github.com/conan-io/conan/pull/2042.patch","issue_url":"https://api.github.com/repos/conan-io/conan/issues/2042","number":2042,"state":"open","locked":false,"title":"Standard as an option","user":{"login":"lasote","id":3807515,"avatar_url":"https://avatars1.githubusercontent.com/u/3807515?v=4","gravatar_id":"","url":"https://api.github.com/users/lasote","html_url":"https://github.com/lasote","followers_url":"https://api.github.com/users/lasote/followers","following_url":"https://api.github.com/users/lasote/following{/other_user}","gists_url":"https://api.github.com/users/lasote/gists{/gist_id}","starred_url":"https://api.github.com/users/lasote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lasote/subscriptions","organizations_url":"https://api.github.com/users/lasote/orgs","repos_url":"https://api.github.com/users/lasote/repos","events_url":"https://api.github.com/users/lasote/events{/privacy}","received_events_url":"https://api.github.com/users/lasote/received_events","type":"User","site_admin":false},"body":"#1799 (part of #2033, but can be completed later)\r\n- Very similar to #2030 but using options instead.\r\n- Added new mechanism (to discuss) to add programmatically common options like \"shared\" or now the standard. `def options(self, config)` method instead of `options` attribute. Look at the tests.\r\n- Removed deprecated helpers\r\n- Added MSBuild() helper that uses VisualStudioBuildEnvironment and the tools to build a vs project.\r\n- I think this approach is cleaner, with fewer side effects and given that has not been a massive demanded feature, maybe it's reasonable to manage it as an option, only in the packages that declare it. To study (can be done later) if we want to add it somehow to the \"conan new\" templates.\r\n- VS14 not forced in test suite, working with 2017","created_at":"2017-11-17T14:09:04Z","updated_at":"2017-12-04T10:12:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"342dd98ce2396bf95cd2554e8ea55579f5d72c3a","assignee":{"login":"memsharded","id":15367152,"avatar_url":"https://avatars2.githubusercontent.com/u/15367152?v=4","gravatar_id":"","url":"https://api.github.com/users/memsharded","html_url":"https://github.com/memsharded","followers_url":"https://api.github.com/users/memsharded/followers","following_url":"https://api.github.com/users/memsharded/following{/other_user}","gists_url":"https://api.github.com/users/memsharded/gists{/gist_id}","starred_url":"https://api.github.com/users/memsharded/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/memsharded/subscriptions","organizations_url":"https://api.github.com/users/memsharded/orgs","repos_url":"https://api.github.com/users/memsharded/repos","events_url":"https://api.github.com/users/memsharded/events{/privacy}","received_events_url":"https://api.github.com/users/memsharded/received_events","type":"User","site_admin":false},"assignees":[{"login":"memsharded","id":15367152,"avatar_url":"https://avatars2.githubusercontent.com/u/15367152?v=4","gravatar_id":"","url":"https://api.github.com/users/memsharded","html_url":"https://github.com/memsharded","followers_url":"https://api.github.com/users/memsharded/followers","following_url":"https://api.github.com/users/memsharded/following{/other_user}","gists_url":"https://api.github.com/users/memsharded/gists{/gist_id}","starred_url":"https://api.github.com/users/memsharded/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/memsharded/subscriptions","organizations_url":"https://api.github.com/users/memsharded/orgs","repos_url":"https://api.github.com/users/memsharded/repos","events_url":"https://api.github.com/users/memsharded/events{/privacy}","received_events_url":"https://api.github.com/users/memsharded/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/conan-io/conan/milestones/29","html_url":"https://github.com/conan-io/conan/milestone/29","labels_url":"https://api.github.com/repos/conan-io/conan/milestones/29/labels","id":2926004,"number":29,"title":"0.30","description":"","creator":{"login":"lasote","id":3807515,"avatar_url":"https://avatars1.githubusercontent.com/u/3807515?v=4","gravatar_id":"","url":"https://api.github.com/users/lasote","html_url":"https://github.com/lasote","followers_url":"https://api.github.com/users/lasote/followers","following_url":"https://api.github.com/users/lasote/following{/other_user}","gists_url":"https://api.github.com/users/lasote/gists{/gist_id}","starred_url":"https://api.github.com/users/lasote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lasote/subscriptions","organizations_url":"https://api.github.com/users/lasote/orgs","repos_url":"https://api.github.com/users/lasote/repos","events_url":"https://api.github.com/users/lasote/events{/privacy}","received_events_url":"https://api.github.com/users/lasote/received_events","type":"User","site_admin":false},"open_issues":25,"closed_issues":20,"state":"open","created_at":"2017-11-20T17:30:11Z","updated_at":"2017-12-04T08:48:30Z","due_on":"2017-11-28T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/conan-io/conan/pulls/2042/commits","review_comments_url":"https://api.github.com/repos/conan-io/conan/pulls/2042/comments","review_comment_url":"https://api.github.com/repos/conan-io/conan/pulls/comments{/number}","comments_url":"https://api.github.com/repos/conan-io/conan/issues/2042/comments","statuses_url":"https://api.github.com/repos/conan-io/conan/statuses/87772dcfc454783fba2345532df955020bc4b67d","head":{"label":"lasote:feature/standard_as_option","ref":"feature/standard_as_option","sha":"87772dcfc454783fba2345532df955020bc4b67d","user":{"login":"lasote","id":3807515,"avatar_url":"https://avatars1.githubusercontent.com/u/3807515?v=4","gravatar_id":"","url":"https://api.github.com/users/lasote","html_url":"https://github.com/lasote","followers_url":"https://api.github.com/users/lasote/followers","following_url":"https://api.github.com/users/lasote/following{/other_user}","gists_url":"https://api.github.com/users/lasote/gists{/gist_id}","starred_url":"https://api.github.com/users/lasote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lasote/subscriptions","organizations_url":"https://api.github.com/users/lasote/orgs","repos_url":"https://api.github.com/users/lasote/repos","events_url":"https://api.github.com/users/lasote/events{/privacy}","received_events_url":"https://api.github.com/users/lasote/received_events","type":"User","site_admin":false},"repo":{"id":47204017,"name":"conan","full_name":"lasote/conan","owner":{"login":"lasote","id":3807515,"avatar_url":"https://avatars1.githubusercontent.com/u/3807515?v=4","gravatar_id":"","url":"https://api.github.com/users/lasote","html_url":"https://github.com/lasote","followers_url":"https://api.github.com/users/lasote/followers","following_url":"https://api.github.com/users/lasote/following{/other_user}","gists_url":"https://api.github.com/users/lasote/gists{/gist_id}","starred_url":"https://api.github.com/users/lasote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lasote/subscriptions","organizations_url":"https://api.github.com/users/lasote/orgs","repos_url":"https://api.github.com/users/lasote/repos","events_url":"https://api.github.com/users/lasote/events{/privacy}","received_events_url":"https://api.github.com/users/lasote/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lasote/conan","description":"Conan.io - The open-source C/C++ package manager","fork":true,"url":"https://api.github.com/repos/lasote/conan","forks_url":"https://api.github.com/repos/lasote/conan/forks","keys_url":"https://api.github.com/repos/lasote/conan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lasote/conan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lasote/conan/teams","hooks_url":"https://api.github.com/repos/lasote/conan/hooks","issue_events_url":"https://api.github.com/repos/lasote/conan/issues/events{/number}","events_url":"https://api.github.com/repos/lasote/conan/events","assignees_url":"https://api.github.com/repos/lasote/conan/assignees{/user}","branches_url":"https://api.github.com/repos/lasote/conan/branches{/branch}","tags_url":"https://api.github.com/repos/lasote/conan/tags","blobs_url":"https://api.github.com/repos/lasote/conan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lasote/conan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lasote/conan/git/refs{/sha}","trees_url":"https://api.github.com/repos/lasote/conan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lasote/conan/statuses/{sha}","languages_url":"https://api.github.com/repos/lasote/conan/languages","stargazers_url":"https://api.github.com/repos/lasote/conan/stargazers","contributors_url":"https://api.github.com/repos/lasote/conan/contributors","subscribers_url":"https://api.github.com/repos/lasote/conan/subscribers","subscription_url":"https://api.github.com/repos/lasote/conan/subscription","commits_url":"https://api.github.com/repos/lasote/conan/commits{/sha}","git_commits_url":"https://api.github.com/repos/lasote/conan/git/commits{/sha}","comments_url":"https://api.github.com/repos/lasote/conan/comments{/number}","issue_comment_url":"https://api.github.com/repos/lasote/conan/issues/comments{/number}","contents_url":"https://api.github.com/repos/lasote/conan/contents/{+path}","compare_url":"https://api.github.com/repos/lasote/conan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lasote/conan/merges","archive_url":"https://api.github.com/repos/lasote/conan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lasote/conan/downloads","issues_url":"https://api.github.com/repos/lasote/conan/issues{/number}","pulls_url":"https://api.github.com/repos/lasote/conan/pulls{/number}","milestones_url":"https://api.github.com/repos/lasote/conan/milestones{/number}","notifications_url":"https://api.github.com/repos/lasote/conan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lasote/conan/labels{/name}","releases_url":"https://api.github.com/repos/lasote/conan/releases{/id}","deployments_url":"https://api.github.com/repos/lasote/conan/deployments","created_at":"2015-12-01T16:56:42Z","updated_at":"2017-07-19T13:30:17Z","pushed_at":"2017-12-02T08:16:22Z","git_url":"git://github.com/lasote/conan.git","ssh_url":"git@github.com:lasote/conan.git","clone_url":"https://github.com/lasote/conan.git","svn_url":"https://github.com/lasote/conan","homepage":"https://conan.io","size":4024,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":0,"watchers":2,"default_branch":"develop"}},"base":{"label":"conan-io:develop","ref":"develop","sha":"b4d3ffc596d5ceade8ddd033803af5f36c8b3b74","user":{"login":"conan-io","id":15212165,"avatar_url":"https://avatars3.githubusercontent.com/u/15212165?v=4","gravatar_id":"","url":"https://api.github.com/users/conan-io","html_url":"https://github.com/conan-io","followers_url":"https://api.github.com/users/conan-io/followers","following_url":"https://api.github.com/users/conan-io/following{/other_user}","gists_url":"https://api.github.com/users/conan-io/gists{/gist_id}","starred_url":"https://api.github.com/users/conan-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conan-io/subscriptions","organizations_url":"https://api.github.com/users/conan-io/orgs","repos_url":"https://api.github.com/users/conan-io/repos","events_url":"https://api.github.com/users/conan-io/events{/privacy}","received_events_url":"https://api.github.com/users/conan-io/received_events","type":"Organization","site_admin":false},"repo":{"id":47190624,"name":"conan","full_name":"conan-io/conan","owner":{"login":"conan-io","id":15212165,"avatar_url":"https://avatars3.githubusercontent.com/u/15212165?v=4","gravatar_id":"","url":"https://api.github.com/users/conan-io","html_url":"https://github.com/conan-io","followers_url":"https://api.github.com/users/conan-io/followers","following_url":"https://api.github.com/users/conan-io/following{/other_user}","gists_url":"https://api.github.com/users/conan-io/gists{/gist_id}","starred_url":"https://api.github.com/users/conan-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conan-io/subscriptions","organizations_url":"https://api.github.com/users/conan-io/orgs","repos_url":"https://api.github.com/users/conan-io/repos","events_url":"https://api.github.com/users/conan-io/events{/privacy}","received_events_url":"https://api.github.com/users/conan-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/conan-io/conan","description":"Conan.io - The open-source C/C++ package manager","fork":false,"url":"https://api.github.com/repos/conan-io/conan","forks_url":"https://api.github.com/repos/conan-io/conan/forks","keys_url":"https://api.github.com/repos/conan-io/conan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/conan-io/conan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/conan-io/conan/teams","hooks_url":"https://api.github.com/repos/conan-io/conan/hooks","issue_events_url":"https://api.github.com/repos/conan-io/conan/issues/events{/number}","events_url":"https://api.github.com/repos/conan-io/conan/events","assignees_url":"https://api.github.com/repos/conan-io/conan/assignees{/user}","branches_url":"https://api.github.com/repos/conan-io/conan/branches{/branch}","tags_url":"https://api.github.com/repos/conan-io/conan/tags","blobs_url":"https://api.github.com/repos/conan-io/conan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/conan-io/conan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/conan-io/conan/git/refs{/sha}","trees_url":"https://api.github.com/repos/conan-io/conan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/conan-io/conan/statuses/{sha}","languages_url":"https://api.github.com/repos/conan-io/conan/languages","stargazers_url":"https://api.github.com/repos/conan-io/conan/stargazers","contributors_url":"https://api.github.com/repos/conan-io/conan/contributors","subscribers_url":"https://api.github.com/repos/conan-io/conan/subscribers","subscription_url":"https://api.github.com/repos/conan-io/conan/subscription","commits_url":"https://api.github.com/repos/conan-io/conan/commits{/sha}","git_commits_url":"https://api.github.com/repos/conan-io/conan/git/commits{/sha}","comments_url":"https://api.github.com/repos/conan-io/conan/comments{/number}","issue_comment_url":"https://api.github.com/repos/conan-io/conan/issues/comments{/number}","contents_url":"https://api.github.com/repos/conan-io/conan/contents/{+path}","compare_url":"https://api.github.com/repos/conan-io/conan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/conan-io/conan/merges","archive_url":"https://api.github.com/repos/conan-io/conan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/conan-io/conan/downloads","issues_url":"https://api.github.com/repos/conan-io/conan/issues{/number}","pulls_url":"https://api.github.com/repos/conan-io/conan/pulls{/number}","milestones_url":"https://api.github.com/repos/conan-io/conan/milestones{/number}","notifications_url":"https://api.github.com/repos/conan-io/conan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/conan-io/conan/labels{/name}","releases_url":"https://api.github.com/repos/conan-io/conan/releases{/id}","deployments_url":"https://api.github.com/repos/conan-io/conan/deployments","created_at":"2015-12-01T13:17:02Z","updated_at":"2017-12-02T23:23:39Z","pushed_at":"2017-12-04T08:34:45Z","git_url":"git://github.com/conan-io/conan.git","ssh_url":"git@github.com:conan-io/conan.git","clone_url":"https://github.com/conan-io/conan.git","svn_url":"https://github.com/conan-io/conan","homepage":"https://conan.io","size":3412,"stargazers_count":1289,"watchers_count":1289,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":191,"mirror_url":null,"archived":false,"open_issues_count":254,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":191,"open_issues":254,"watchers":1289,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/conan-io/conan/pulls/2042"},"html":{"href":"https://github.com/conan-io/conan/pull/2042"},"issue":{"href":"https://api.github.com/repos/conan-io/conan/issues/2042"},"comments":{"href":"https://api.github.com/repos/conan-io/conan/issues/2042/comments"},"review_comments":{"href":"https://api.github.com/repos/conan-io/conan/pulls/2042/comments"},"review_comment":{"href":"https://api.github.com/repos/conan-io/conan/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/conan-io/conan/pulls/2042/commits"},"statuses":{"href":"https://api.github.com/repos/conan-io/conan/statuses/87772dcfc454783fba2345532df955020bc4b67d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"lasote"}}