{"action":"closed","number":1106,"pull_request":{"url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/pulls/1106","id":131798398,"html_url":"https://github.com/Squirrel/Squirrel.Windows/pull/1106","diff_url":"https://github.com/Squirrel/Squirrel.Windows/pull/1106.diff","patch_url":"https://github.com/Squirrel/Squirrel.Windows/pull/1106.patch","issue_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/issues/1106","number":1106,"state":"closed","locked":false,"title":"Validate update package signature","user":{"login":"arul-gupta","id":2143807,"avatar_url":"https://avatars0.githubusercontent.com/u/2143807?v=4","gravatar_id":"","url":"https://api.github.com/users/arul-gupta","html_url":"https://github.com/arul-gupta","followers_url":"https://api.github.com/users/arul-gupta/followers","following_url":"https://api.github.com/users/arul-gupta/following{/other_user}","gists_url":"https://api.github.com/users/arul-gupta/gists{/gist_id}","starred_url":"https://api.github.com/users/arul-gupta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arul-gupta/subscriptions","organizations_url":"https://api.github.com/users/arul-gupta/orgs","repos_url":"https://api.github.com/users/arul-gupta/repos","events_url":"https://api.github.com/users/arul-gupta/events{/privacy}","received_events_url":"https://api.github.com/users/arul-gupta/received_events","type":"User","site_admin":false},"body":"I've added an option to validate the packages before applying the update.\r\nIf signature verification is requested, it will continue with update only if the update package is signed and the Subject property of the certificate matches the one from the current executable.\r\nIf current app is not signed, it will skip the validation check even if user requests signature validation.\r\n\r\nThis fix was needed to restrict app updates to only trusted sources.","created_at":"2017-07-21T15:20:57Z","updated_at":"2017-07-26T11:02:02Z","closed_at":"2017-07-26T11:02:02Z","merged_at":null,"merge_commit_sha":"b999bd37e3b35aa2b57494a8dd8d44ee17f85c29","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/pulls/1106/commits","review_comments_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/pulls/1106/comments","review_comment_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/issues/1106/comments","statuses_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/statuses/c239a061d287f64a57ef4578905b3fa40f4a4790","head":{"label":"arul-gupta:verify_update_package_signature","ref":"verify_update_package_signature","sha":"c239a061d287f64a57ef4578905b3fa40f4a4790","user":{"login":"arul-gupta","id":2143807,"avatar_url":"https://avatars0.githubusercontent.com/u/2143807?v=4","gravatar_id":"","url":"https://api.github.com/users/arul-gupta","html_url":"https://github.com/arul-gupta","followers_url":"https://api.github.com/users/arul-gupta/followers","following_url":"https://api.github.com/users/arul-gupta/following{/other_user}","gists_url":"https://api.github.com/users/arul-gupta/gists{/gist_id}","starred_url":"https://api.github.com/users/arul-gupta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arul-gupta/subscriptions","organizations_url":"https://api.github.com/users/arul-gupta/orgs","repos_url":"https://api.github.com/users/arul-gupta/repos","events_url":"https://api.github.com/users/arul-gupta/events{/privacy}","received_events_url":"https://api.github.com/users/arul-gupta/received_events","type":"User","site_admin":false},"repo":{"id":82068856,"name":"Squirrel.Windows","full_name":"arul-gupta/Squirrel.Windows","owner":{"login":"arul-gupta","id":2143807,"avatar_url":"https://avatars0.githubusercontent.com/u/2143807?v=4","gravatar_id":"","url":"https://api.github.com/users/arul-gupta","html_url":"https://github.com/arul-gupta","followers_url":"https://api.github.com/users/arul-gupta/followers","following_url":"https://api.github.com/users/arul-gupta/following{/other_user}","gists_url":"https://api.github.com/users/arul-gupta/gists{/gist_id}","starred_url":"https://api.github.com/users/arul-gupta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arul-gupta/subscriptions","organizations_url":"https://api.github.com/users/arul-gupta/orgs","repos_url":"https://api.github.com/users/arul-gupta/repos","events_url":"https://api.github.com/users/arul-gupta/events{/privacy}","received_events_url":"https://api.github.com/users/arul-gupta/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/arul-gupta/Squirrel.Windows","description":"An installation and update framework for Windows desktop apps","fork":true,"url":"https://api.github.com/repos/arul-gupta/Squirrel.Windows","forks_url":"https://api.github.com/repos/arul-gupta/Squirrel.Windows/forks","keys_url":"https://api.github.com/repos/arul-gupta/Squirrel.Windows/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arul-gupta/Squirrel.Windows/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arul-gupta/Squirrel.Windows/teams","hooks_url":"https://api.github.com/repos/arul-gupta/Squirrel.Windows/hooks","issue_events_url":"https://api.github.com/repos/arul-gupta/Squirrel.Windows/issues/events{/number}","events_url":"https://api.github.com/repos/arul-gupta/Squirrel.Windows/events","assignees_url":"https://api.github.com/repos/arul-gupta/Squirrel.Windows/assignees{/user}","branches_url":"https://api.github.com/repos/arul-gupta/Squirrel.Windows/branches{/branch}","tags_url":"https://api.github.com/repos/arul-gupta/Squirrel.Windows/tags","blobs_url":"https://api.github.com/repos/arul-gupta/Squirrel.Windows/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arul-gupta/Squirrel.Windows/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arul-gupta/Squirrel.Windows/git/refs{/sha}","trees_url":"https://api.github.com/repos/arul-gupta/Squirrel.Windows/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arul-gupta/Squirrel.Windows/statuses/{sha}","languages_url":"https://api.github.com/repos/arul-gupta/Squirrel.Windows/languages","stargazers_url":"https://api.github.com/repos/arul-gupta/Squirrel.Windows/stargazers","contributors_url":"https://api.github.com/repos/arul-gupta/Squirrel.Windows/contributors","subscribers_url":"https://api.github.com/repos/arul-gupta/Squirrel.Windows/subscribers","subscription_url":"https://api.github.com/repos/arul-gupta/Squirrel.Windows/subscription","commits_url":"https://api.github.com/repos/arul-gupta/Squirrel.Windows/commits{/sha}","git_commits_url":"https://api.github.com/repos/arul-gupta/Squirrel.Windows/git/commits{/sha}","comments_url":"https://api.github.com/repos/arul-gupta/Squirrel.Windows/comments{/number}","issue_comment_url":"https://api.github.com/repos/arul-gupta/Squirrel.Windows/issues/comments{/number}","contents_url":"https://api.github.com/repos/arul-gupta/Squirrel.Windows/contents/{+path}","compare_url":"https://api.github.com/repos/arul-gupta/Squirrel.Windows/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arul-gupta/Squirrel.Windows/merges","archive_url":"https://api.github.com/repos/arul-gupta/Squirrel.Windows/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arul-gupta/Squirrel.Windows/downloads","issues_url":"https://api.github.com/repos/arul-gupta/Squirrel.Windows/issues{/number}","pulls_url":"https://api.github.com/repos/arul-gupta/Squirrel.Windows/pulls{/number}","milestones_url":"https://api.github.com/repos/arul-gupta/Squirrel.Windows/milestones{/number}","notifications_url":"https://api.github.com/repos/arul-gupta/Squirrel.Windows/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arul-gupta/Squirrel.Windows/labels{/name}","releases_url":"https://api.github.com/repos/arul-gupta/Squirrel.Windows/releases{/id}","deployments_url":"https://api.github.com/repos/arul-gupta/Squirrel.Windows/deployments","created_at":"2017-02-15T14:24:15Z","updated_at":"2017-02-15T14:24:18Z","pushed_at":"2017-07-21T14:29:48Z","git_url":"git://github.com/arul-gupta/Squirrel.Windows.git","ssh_url":"git@github.com:arul-gupta/Squirrel.Windows.git","clone_url":"https://github.com/arul-gupta/Squirrel.Windows.git","svn_url":"https://github.com/arul-gupta/Squirrel.Windows","homepage":"","size":81731,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Squirrel:master","ref":"master","sha":"5cf5ad36abd0dbbda8b210bdbd89dc8208c0dc90","user":{"login":"Squirrel","id":5743792,"avatar_url":"https://avatars1.githubusercontent.com/u/5743792?v=4","gravatar_id":"","url":"https://api.github.com/users/Squirrel","html_url":"https://github.com/Squirrel","followers_url":"https://api.github.com/users/Squirrel/followers","following_url":"https://api.github.com/users/Squirrel/following{/other_user}","gists_url":"https://api.github.com/users/Squirrel/gists{/gist_id}","starred_url":"https://api.github.com/users/Squirrel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Squirrel/subscriptions","organizations_url":"https://api.github.com/users/Squirrel/orgs","repos_url":"https://api.github.com/users/Squirrel/repos","events_url":"https://api.github.com/users/Squirrel/events{/privacy}","received_events_url":"https://api.github.com/users/Squirrel/received_events","type":"Organization","site_admin":false},"repo":{"id":22338518,"name":"Squirrel.Windows","full_name":"Squirrel/Squirrel.Windows","owner":{"login":"Squirrel","id":5743792,"avatar_url":"https://avatars1.githubusercontent.com/u/5743792?v=4","gravatar_id":"","url":"https://api.github.com/users/Squirrel","html_url":"https://github.com/Squirrel","followers_url":"https://api.github.com/users/Squirrel/followers","following_url":"https://api.github.com/users/Squirrel/following{/other_user}","gists_url":"https://api.github.com/users/Squirrel/gists{/gist_id}","starred_url":"https://api.github.com/users/Squirrel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Squirrel/subscriptions","organizations_url":"https://api.github.com/users/Squirrel/orgs","repos_url":"https://api.github.com/users/Squirrel/repos","events_url":"https://api.github.com/users/Squirrel/events{/privacy}","received_events_url":"https://api.github.com/users/Squirrel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Squirrel/Squirrel.Windows","description":"An installation and update framework for Windows desktop apps","fork":false,"url":"https://api.github.com/repos/Squirrel/Squirrel.Windows","forks_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/forks","keys_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/teams","hooks_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/hooks","issue_events_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/issues/events{/number}","events_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/events","assignees_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/assignees{/user}","branches_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/branches{/branch}","tags_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/tags","blobs_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/git/refs{/sha}","trees_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/statuses/{sha}","languages_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/languages","stargazers_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/stargazers","contributors_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/contributors","subscribers_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/subscribers","subscription_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/subscription","commits_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/commits{/sha}","git_commits_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/git/commits{/sha}","comments_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/comments{/number}","issue_comment_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/issues/comments{/number}","contents_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/contents/{+path}","compare_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/merges","archive_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/downloads","issues_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/issues{/number}","pulls_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/pulls{/number}","milestones_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/milestones{/number}","notifications_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/labels{/name}","releases_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/releases{/id}","deployments_url":"https://api.github.com/repos/Squirrel/Squirrel.Windows/deployments","created_at":"2014-07-28T10:10:39Z","updated_at":"2017-07-26T07:11:50Z","pushed_at":"2017-07-21T15:20:58Z","git_url":"git://github.com/Squirrel/Squirrel.Windows.git","ssh_url":"git@github.com:Squirrel/Squirrel.Windows.git","clone_url":"https://github.com/Squirrel/Squirrel.Windows.git","svn_url":"https://github.com/Squirrel/Squirrel.Windows","homepage":"","size":82706,"stargazers_count":3033,"watchers_count":3033,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":459,"mirror_url":null,"open_issues_count":369,"forks":459,"open_issues":369,"watchers":3033,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Squirrel/Squirrel.Windows/pulls/1106"},"html":{"href":"https://github.com/Squirrel/Squirrel.Windows/pull/1106"},"issue":{"href":"https://api.github.com/repos/Squirrel/Squirrel.Windows/issues/1106"},"comments":{"href":"https://api.github.com/repos/Squirrel/Squirrel.Windows/issues/1106/comments"},"review_comments":{"href":"https://api.github.com/repos/Squirrel/Squirrel.Windows/pulls/1106/comments"},"review_comment":{"href":"https://api.github.com/repos/Squirrel/Squirrel.Windows/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Squirrel/Squirrel.Windows/pulls/1106/commits"},"statuses":{"href":"https://api.github.com/repos/Squirrel/Squirrel.Windows/statuses/c239a061d287f64a57ef4578905b3fa40f4a4790"}},"merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":71,"deletions":0,"changed_files":2}}
{"actor":{"display_login":"arul-gupta"}}