{"action":"created","comment":{"url":"https://api.github.com/repos/apple/swift/pulls/comments/98343730","pull_request_review_id":18985261,"id":98343730,"diff_hunk":"@@ -395,6 +395,14 @@ public protocol ExpressibleByExtendedGraphemeClusterLiteral\n   init(extendedGraphemeClusterLiteral value: ExtendedGraphemeClusterLiteralType)\n }\n \n+extension ExpressibleByExtendedGraphemeClusterLiteral\n+    where Self.ExtendedGraphemeClusterLiteralType == Character","path":"stdlib/public/core/CompilerProtocols.swift","position":14,"original_position":14,"commit_id":"f55b0b129d413174a13bf02a7cda948f341f1e7f","original_commit_id":"f55b0b129d413174a13bf02a7cda948f341f1e7f","user":{"login":"xwu","id":13952,"avatar_url":"https://avatars.githubusercontent.com/u/13952?v=3","gravatar_id":"","url":"https://api.github.com/users/xwu","html_url":"https://github.com/xwu","followers_url":"https://api.github.com/users/xwu/followers","following_url":"https://api.github.com/users/xwu/following{/other_user}","gists_url":"https://api.github.com/users/xwu/gists{/gist_id}","starred_url":"https://api.github.com/users/xwu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xwu/subscriptions","organizations_url":"https://api.github.com/users/xwu/orgs","repos_url":"https://api.github.com/users/xwu/repos","events_url":"https://api.github.com/users/xwu/events{/privacy}","received_events_url":"https://api.github.com/users/xwu/received_events","type":"User","site_admin":false},"body":"Drive-by nit: indents are two spaces in this file; otherwise a delightful addition!","created_at":"2017-01-29T02:52:28Z","updated_at":"2017-01-29T02:52:28Z","html_url":"https://github.com/apple/swift/pull/7125#discussion_r98343730","pull_request_url":"https://api.github.com/repos/apple/swift/pulls/7125","_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/comments/98343730"},"html":{"href":"https://github.com/apple/swift/pull/7125#discussion_r98343730"},"pull_request":{"href":"https://api.github.com/repos/apple/swift/pulls/7125"}}},"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/7125","id":103603213,"html_url":"https://github.com/apple/swift/pull/7125","diff_url":"https://github.com/apple/swift/pull/7125.diff","patch_url":"https://github.com/apple/swift/pull/7125.patch","issue_url":"https://api.github.com/repos/apple/swift/issues/7125","number":7125,"state":"open","locked":false,"title":"Simplifying implementation of `ExpressibleByStringLiteral`","user":{"login":"therealbnut","id":635596,"avatar_url":"https://avatars.githubusercontent.com/u/635596?v=3","gravatar_id":"","url":"https://api.github.com/users/therealbnut","html_url":"https://github.com/therealbnut","followers_url":"https://api.github.com/users/therealbnut/followers","following_url":"https://api.github.com/users/therealbnut/following{/other_user}","gists_url":"https://api.github.com/users/therealbnut/gists{/gist_id}","starred_url":"https://api.github.com/users/therealbnut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/therealbnut/subscriptions","organizations_url":"https://api.github.com/users/therealbnut/orgs","repos_url":"https://api.github.com/users/therealbnut/repos","events_url":"https://api.github.com/users/therealbnut/events{/privacy}","received_events_url":"https://api.github.com/users/therealbnut/received_events","type":"User","site_admin":false},"body":"<!-- What's in this pull request? -->\r\n\r\n**Added default implementations for `ExpressibleByUnicodeScalarLiteral` and `ExpressibleByExtendedGraphemeClusterLiteral`**\r\n```swift\r\ninit(unicodeScalarLiteral value: UnicodeScalar)\r\ninit(extendedGraphemeClusterLiteral value: Character)\r\n```\r\n\r\nNow implementing `ExpressibleByStringLiteral` is as simple as:\r\n```swift\r\nextension Example: ExpressibleByStringLiteral {\r\n    init(stringLiteral value: String) {\r\n        self.string = value\r\n    }\r\n}\r\n```\r\n\r\nPreviously you would have to implement something like this:\r\n```swift\r\nextension Example: ExpressibleByStringLiteral {\r\n    init(stringLiteral value: String) {\r\n        self.string = value\r\n    }\r\n    init(extendedGraphemeClusterLiteral value: Character) {\r\n        self.string = String(describing: value)\r\n    }\r\n    init(unicodeScalarLiteral value: UnicodeScalar) {\r\n        self.string = String(describing: Character(value))\r\n    }\r\n}\r\n```\r\nAs well as understand what each of these meant, and which types can be used.\r\n\r\n**Changed `Character`'s implementation of `ExpressibleByUnicodeScalarLiteral`**\r\n```diff\r\n-  public init(unicodeScalarLiteral value: Character) {\r\n+  public init(unicodeScalarLiteral value: UnicodeScalar) {\r\n```\r\nThe documentation states:\r\n```swift\r\n/// Valid types for `UnicodeScalarLiteralType` are `UnicodeScalar`,\r\n/// `String`, and `StaticString`.\r\n```\r\n\r\n<!-- If this pull request resolves any bugs in the Swift bug tracker, provide a link: -->\r\n<!-- Resolves [SR-NNNN](https://bugs.swift.org/browse/SR-NNNN). -->\r\n\r\n<!--\r\nBefore merging this pull request, you must run the Swift continuous integration tests.\r\nFor information about triggering CI builds via @swift-ci, see:\r\nhttps://github.com/apple/swift/blob/master/docs/ContinuousIntegration.md#swift-ci\r\n\r\nThank you for your contribution to Swift!\r\n-->","created_at":"2017-01-28T06:52:40Z","updated_at":"2017-01-29T02:52:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"261ebd04b21e04a5be599d8d0ea6b79847ec00bb","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift/pulls/7125/commits","review_comments_url":"https://api.github.com/repos/apple/swift/pulls/7125/comments","review_comment_url":"https://api.github.com/repos/apple/swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift/issues/7125/comments","statuses_url":"https://api.github.com/repos/apple/swift/statuses/f55b0b129d413174a13bf02a7cda948f341f1e7f","head":{"label":"therealbnut:therealbnut-string-expressible-extensions","ref":"therealbnut-string-expressible-extensions","sha":"f55b0b129d413174a13bf02a7cda948f341f1e7f","user":{"login":"therealbnut","id":635596,"avatar_url":"https://avatars.githubusercontent.com/u/635596?v=3","gravatar_id":"","url":"https://api.github.com/users/therealbnut","html_url":"https://github.com/therealbnut","followers_url":"https://api.github.com/users/therealbnut/followers","following_url":"https://api.github.com/users/therealbnut/following{/other_user}","gists_url":"https://api.github.com/users/therealbnut/gists{/gist_id}","starred_url":"https://api.github.com/users/therealbnut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/therealbnut/subscriptions","organizations_url":"https://api.github.com/users/therealbnut/orgs","repos_url":"https://api.github.com/users/therealbnut/repos","events_url":"https://api.github.com/users/therealbnut/events{/privacy}","received_events_url":"https://api.github.com/users/therealbnut/received_events","type":"User","site_admin":false},"repo":{"id":47446950,"name":"swift","full_name":"therealbnut/swift","owner":{"login":"therealbnut","id":635596,"avatar_url":"https://avatars.githubusercontent.com/u/635596?v=3","gravatar_id":"","url":"https://api.github.com/users/therealbnut","html_url":"https://github.com/therealbnut","followers_url":"https://api.github.com/users/therealbnut/followers","following_url":"https://api.github.com/users/therealbnut/following{/other_user}","gists_url":"https://api.github.com/users/therealbnut/gists{/gist_id}","starred_url":"https://api.github.com/users/therealbnut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/therealbnut/subscriptions","organizations_url":"https://api.github.com/users/therealbnut/orgs","repos_url":"https://api.github.com/users/therealbnut/repos","events_url":"https://api.github.com/users/therealbnut/events{/privacy}","received_events_url":"https://api.github.com/users/therealbnut/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/therealbnut/swift","description":"The Swift Programming Language","fork":true,"url":"https://api.github.com/repos/therealbnut/swift","forks_url":"https://api.github.com/repos/therealbnut/swift/forks","keys_url":"https://api.github.com/repos/therealbnut/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/therealbnut/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/therealbnut/swift/teams","hooks_url":"https://api.github.com/repos/therealbnut/swift/hooks","issue_events_url":"https://api.github.com/repos/therealbnut/swift/issues/events{/number}","events_url":"https://api.github.com/repos/therealbnut/swift/events","assignees_url":"https://api.github.com/repos/therealbnut/swift/assignees{/user}","branches_url":"https://api.github.com/repos/therealbnut/swift/branches{/branch}","tags_url":"https://api.github.com/repos/therealbnut/swift/tags","blobs_url":"https://api.github.com/repos/therealbnut/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/therealbnut/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/therealbnut/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/therealbnut/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/therealbnut/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/therealbnut/swift/languages","stargazers_url":"https://api.github.com/repos/therealbnut/swift/stargazers","contributors_url":"https://api.github.com/repos/therealbnut/swift/contributors","subscribers_url":"https://api.github.com/repos/therealbnut/swift/subscribers","subscription_url":"https://api.github.com/repos/therealbnut/swift/subscription","commits_url":"https://api.github.com/repos/therealbnut/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/therealbnut/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/therealbnut/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/therealbnut/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/therealbnut/swift/contents/{+path}","compare_url":"https://api.github.com/repos/therealbnut/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/therealbnut/swift/merges","archive_url":"https://api.github.com/repos/therealbnut/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/therealbnut/swift/downloads","issues_url":"https://api.github.com/repos/therealbnut/swift/issues{/number}","pulls_url":"https://api.github.com/repos/therealbnut/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/therealbnut/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/therealbnut/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/therealbnut/swift/labels{/name}","releases_url":"https://api.github.com/repos/therealbnut/swift/releases{/id}","deployments_url":"https://api.github.com/repos/therealbnut/swift/deployments","created_at":"2015-12-05T07:33:02Z","updated_at":"2016-01-23T23:43:07Z","pushed_at":"2017-01-29T02:29:54Z","git_url":"git://github.com/therealbnut/swift.git","ssh_url":"git@github.com:therealbnut/swift.git","clone_url":"https://github.com/therealbnut/swift.git","svn_url":"https://github.com/therealbnut/swift","homepage":"","size":145016,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"ea94be6f90449b30c1ba7a6a9c02f7c0ad5e52f5","user":{"login":"apple","id":10639145,"avatar_url":"https://avatars.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838949,"name":"swift","full_name":"apple/swift","owner":{"login":"apple","id":10639145,"avatar_url":"https://avatars.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/swift","description":"The Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift","forks_url":"https://api.github.com/repos/apple/swift/forks","keys_url":"https://api.github.com/repos/apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift/teams","hooks_url":"https://api.github.com/repos/apple/swift/hooks","issue_events_url":"https://api.github.com/repos/apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift/events","assignees_url":"https://api.github.com/repos/apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift/tags","blobs_url":"https://api.github.com/repos/apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift/languages","stargazers_url":"https://api.github.com/repos/apple/swift/stargazers","contributors_url":"https://api.github.com/repos/apple/swift/contributors","subscribers_url":"https://api.github.com/repos/apple/swift/subscribers","subscription_url":"https://api.github.com/repos/apple/swift/subscription","commits_url":"https://api.github.com/repos/apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift/merges","archive_url":"https://api.github.com/repos/apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift/downloads","issues_url":"https://api.github.com/repos/apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift/deployments","created_at":"2015-10-23T21:15:07Z","updated_at":"2017-01-29T02:39:09Z","pushed_at":"2017-01-29T02:35:54Z","git_url":"git://github.com/apple/swift.git","ssh_url":"git@github.com:apple/swift.git","clone_url":"https://github.com/apple/swift.git","svn_url":"https://github.com/apple/swift","homepage":"https://swift.org/","size":158872,"stargazers_count":36425,"watchers_count":36425,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5309,"mirror_url":null,"open_issues_count":112,"forks":5309,"open_issues":112,"watchers":36425,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/7125"},"html":{"href":"https://github.com/apple/swift/pull/7125"},"issue":{"href":"https://api.github.com/repos/apple/swift/issues/7125"},"comments":{"href":"https://api.github.com/repos/apple/swift/issues/7125/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift/pulls/7125/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift/pulls/7125/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift/statuses/f55b0b129d413174a13bf02a7cda948f341f1e7f"}}}}
{"actor":{"display_login":"xwu"}}