{"action":"created","issue":{"url":"https://api.github.com/repos/pure-data/pure-data/issues/205","repository_url":"https://api.github.com/repos/pure-data/pure-data","labels_url":"https://api.github.com/repos/pure-data/pure-data/issues/205/labels{/name}","comments_url":"https://api.github.com/repos/pure-data/pure-data/issues/205/comments","events_url":"https://api.github.com/repos/pure-data/pure-data/issues/205/events","html_url":"https://github.com/pure-data/pure-data/pull/205","id":251778533,"number":205,"title":"declare -path & -lib flags now search user search paths","user":{"login":"danomatika","id":480637,"avatar_url":"https://avatars1.githubusercontent.com/u/480637?v=4","gravatar_id":"","url":"https://api.github.com/users/danomatika","html_url":"https://github.com/danomatika","followers_url":"https://api.github.com/users/danomatika/followers","following_url":"https://api.github.com/users/danomatika/following{/other_user}","gists_url":"https://api.github.com/users/danomatika/gists{/gist_id}","starred_url":"https://api.github.com/users/danomatika/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danomatika/subscriptions","organizations_url":"https://api.github.com/users/danomatika/orgs","repos_url":"https://api.github.com/users/danomatika/repos","events_url":"https://api.github.com/users/danomatika/events{/privacy}","received_events_url":"https://api.github.com/users/danomatika/received_events","type":"User","site_admin":false},"labels":[{"id":122642816,"url":"https://api.github.com/repos/pure-data/pure-data/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":29,"created_at":"2017-08-21T21:39:25Z","updated_at":"2017-09-02T14:39:00Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/pure-data/pure-data/pulls/205","html_url":"https://github.com/pure-data/pure-data/pull/205","diff_url":"https://github.com/pure-data/pure-data/pull/205.diff","patch_url":"https://github.com/pure-data/pure-data/pull/205.patch"},"body":"This PR adds adds st_searchpath checking for the [declare] -path & -lib flags. This provides similar functionality to how -stdpath & -stdlib work, but searches one level into st_searchpath instead of st_staticpath.\r\n\r\nI'm not sure if this is a good fix or opens a host of new problems. It was, however, easy to implement (mostly via copy/paste/edit), so here you go.\r\n\r\nEDIT: This update favors relative paths by first checking for a preceding \"./\" and then checking if a subdirectory of the canvas dir exists or the library was loaded. It then falls back to checking st_searchpath. If the path/lib is an explicit relative path (starts with \"./\"), the st_searchpath checks are omitted.\r\n\r\nThis is in response to #184 and would negate the need for deken to suggest adding to search paths."},"comment":{"url":"https://api.github.com/repos/pure-data/pure-data/issues/comments/326747942","html_url":"https://github.com/pure-data/pure-data/pull/205#issuecomment-326747942","issue_url":"https://api.github.com/repos/pure-data/pure-data/issues/205","id":326747942,"user":{"login":"danomatika","id":480637,"avatar_url":"https://avatars1.githubusercontent.com/u/480637?v=4","gravatar_id":"","url":"https://api.github.com/users/danomatika","html_url":"https://github.com/danomatika","followers_url":"https://api.github.com/users/danomatika/followers","following_url":"https://api.github.com/users/danomatika/following{/other_user}","gists_url":"https://api.github.com/users/danomatika/gists{/gist_id}","starred_url":"https://api.github.com/users/danomatika/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danomatika/subscriptions","organizations_url":"https://api.github.com/users/danomatika/orgs","repos_url":"https://api.github.com/users/danomatika/repos","events_url":"https://api.github.com/users/danomatika/events{/privacy}","received_events_url":"https://api.github.com/users/danomatika/received_events","type":"User","site_admin":false},"created_at":"2017-09-02T14:39:00Z","updated_at":"2017-09-02T14:39:00Z","author_association":"CONTRIBUTOR","body":"-lib already works this way and it will be easy to add st_staticpath support to -path.\n\nenohp ym morf tnes\n-----------\nDan Wilcox\ndanomatika.com\nrobotcowboy.com\n\n\n> On Sep 2, 2017, at 4:12 PM, Antoine Rousseau <notifications@github.com> wrote:\n> \n> So you're suggesting -path and -lib should always end up looking relative to Pd as well if all else fails?\n> \n> I also think that it would be a valuable simplification:\n> \n> 1: search relatively to the calling patch\n> 2: search the user's global paths\n> 3: search Pd's system paths\n> —\n> You are receiving this because you authored the thread.\n> Reply to this email directly, view it on GitHub, or mute the thread.\n> \n"}}
{"actor":{"display_login":"danomatika"}}