{"action":"created","comment":{"url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/comments/124372152","pull_request_review_id":46651455,"id":124372152,"diff_hunk":"@@ -0,0 +1,50 @@\n+// Distributed under the MIT License.\n+// See LICENSE.txt for details.\n+\n+#include <catch.hpp>\n+\n+#include \"Domain/Direction.hpp\"\n+\n+TEST_CASE(\"Unit.Domain.Direction\", \"[Domain][Unit]\") {\n+  Direction<3> upper_xi = Direction<3>::upper_xi();\n+  CHECK(upper_xi.opposite() == Direction<3>::lower_xi());\n+  CHECK(upper_xi.opposite().sign() == -1.0);","path":"tests/Unit/Domain/Test_Direction.cpp","position":11,"original_position":11,"commit_id":"e8e27311fbdc6ac1b55c64a3b8242f99b00d7db4","original_commit_id":"e8e27311fbdc6ac1b55c64a3b8242f99b00d7db4","user":{"login":"fmahebert","id":881747,"avatar_url":"https://avatars2.githubusercontent.com/u/881747?v=3","gravatar_id":"","url":"https://api.github.com/users/fmahebert","html_url":"https://github.com/fmahebert","followers_url":"https://api.github.com/users/fmahebert/followers","following_url":"https://api.github.com/users/fmahebert/following{/other_user}","gists_url":"https://api.github.com/users/fmahebert/gists{/gist_id}","starred_url":"https://api.github.com/users/fmahebert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fmahebert/subscriptions","organizations_url":"https://api.github.com/users/fmahebert/orgs","repos_url":"https://api.github.com/users/fmahebert/repos","events_url":"https://api.github.com/users/fmahebert/events{/privacy}","received_events_url":"https://api.github.com/users/fmahebert/received_events","type":"User","site_admin":false},"body":"Is there any reason not to explicitly check all coordinates in all dims?","created_at":"2017-06-27T19:26:45Z","updated_at":"2017-06-27T19:31:08Z","html_url":"https://github.com/sxs-collaboration/spectre/pull/60#discussion_r124372152","pull_request_url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/60","_links":{"self":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/comments/124372152"},"html":{"href":"https://github.com/sxs-collaboration/spectre/pull/60#discussion_r124372152"},"pull_request":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/60"}}},"pull_request":{"url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/60","id":127731745,"html_url":"https://github.com/sxs-collaboration/spectre/pull/60","diff_url":"https://github.com/sxs-collaboration/spectre/pull/60.diff","patch_url":"https://github.com/sxs-collaboration/spectre/pull/60.patch","issue_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues/60","number":60,"state":"open","locked":false,"title":"Addition of Direction and Direction test","user":{"login":"gsb76","id":27026354,"avatar_url":"https://avatars0.githubusercontent.com/u/27026354?v=3","gravatar_id":"","url":"https://api.github.com/users/gsb76","html_url":"https://github.com/gsb76","followers_url":"https://api.github.com/users/gsb76/followers","following_url":"https://api.github.com/users/gsb76/following{/other_user}","gists_url":"https://api.github.com/users/gsb76/gists{/gist_id}","starred_url":"https://api.github.com/users/gsb76/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gsb76/subscriptions","organizations_url":"https://api.github.com/users/gsb76/orgs","repos_url":"https://api.github.com/users/gsb76/repos","events_url":"https://api.github.com/users/gsb76/events{/privacy}","received_events_url":"https://api.github.com/users/gsb76/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-06-27T15:59:41Z","updated_at":"2017-06-27T19:31:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"81176bd30685fd036685fce447f04f0565fc2590","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/60/commits","review_comments_url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/60/comments","review_comment_url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues/60/comments","statuses_url":"https://api.github.com/repos/sxs-collaboration/spectre/statuses/e8e27311fbdc6ac1b55c64a3b8242f99b00d7db4","head":{"label":"gsb76:gab_direction_addition","ref":"gab_direction_addition","sha":"e8e27311fbdc6ac1b55c64a3b8242f99b00d7db4","user":{"login":"gsb76","id":27026354,"avatar_url":"https://avatars0.githubusercontent.com/u/27026354?v=3","gravatar_id":"","url":"https://api.github.com/users/gsb76","html_url":"https://github.com/gsb76","followers_url":"https://api.github.com/users/gsb76/followers","following_url":"https://api.github.com/users/gsb76/following{/other_user}","gists_url":"https://api.github.com/users/gsb76/gists{/gist_id}","starred_url":"https://api.github.com/users/gsb76/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gsb76/subscriptions","organizations_url":"https://api.github.com/users/gsb76/orgs","repos_url":"https://api.github.com/users/gsb76/repos","events_url":"https://api.github.com/users/gsb76/events{/privacy}","received_events_url":"https://api.github.com/users/gsb76/received_events","type":"User","site_admin":false},"repo":{"id":94911327,"name":"spectre","full_name":"gsb76/spectre","owner":{"login":"gsb76","id":27026354,"avatar_url":"https://avatars0.githubusercontent.com/u/27026354?v=3","gravatar_id":"","url":"https://api.github.com/users/gsb76","html_url":"https://github.com/gsb76","followers_url":"https://api.github.com/users/gsb76/followers","following_url":"https://api.github.com/users/gsb76/following{/other_user}","gists_url":"https://api.github.com/users/gsb76/gists{/gist_id}","starred_url":"https://api.github.com/users/gsb76/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gsb76/subscriptions","organizations_url":"https://api.github.com/users/gsb76/orgs","repos_url":"https://api.github.com/users/gsb76/repos","events_url":"https://api.github.com/users/gsb76/events{/privacy}","received_events_url":"https://api.github.com/users/gsb76/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gsb76/spectre","description":null,"fork":true,"url":"https://api.github.com/repos/gsb76/spectre","forks_url":"https://api.github.com/repos/gsb76/spectre/forks","keys_url":"https://api.github.com/repos/gsb76/spectre/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gsb76/spectre/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gsb76/spectre/teams","hooks_url":"https://api.github.com/repos/gsb76/spectre/hooks","issue_events_url":"https://api.github.com/repos/gsb76/spectre/issues/events{/number}","events_url":"https://api.github.com/repos/gsb76/spectre/events","assignees_url":"https://api.github.com/repos/gsb76/spectre/assignees{/user}","branches_url":"https://api.github.com/repos/gsb76/spectre/branches{/branch}","tags_url":"https://api.github.com/repos/gsb76/spectre/tags","blobs_url":"https://api.github.com/repos/gsb76/spectre/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gsb76/spectre/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gsb76/spectre/git/refs{/sha}","trees_url":"https://api.github.com/repos/gsb76/spectre/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gsb76/spectre/statuses/{sha}","languages_url":"https://api.github.com/repos/gsb76/spectre/languages","stargazers_url":"https://api.github.com/repos/gsb76/spectre/stargazers","contributors_url":"https://api.github.com/repos/gsb76/spectre/contributors","subscribers_url":"https://api.github.com/repos/gsb76/spectre/subscribers","subscription_url":"https://api.github.com/repos/gsb76/spectre/subscription","commits_url":"https://api.github.com/repos/gsb76/spectre/commits{/sha}","git_commits_url":"https://api.github.com/repos/gsb76/spectre/git/commits{/sha}","comments_url":"https://api.github.com/repos/gsb76/spectre/comments{/number}","issue_comment_url":"https://api.github.com/repos/gsb76/spectre/issues/comments{/number}","contents_url":"https://api.github.com/repos/gsb76/spectre/contents/{+path}","compare_url":"https://api.github.com/repos/gsb76/spectre/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gsb76/spectre/merges","archive_url":"https://api.github.com/repos/gsb76/spectre/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gsb76/spectre/downloads","issues_url":"https://api.github.com/repos/gsb76/spectre/issues{/number}","pulls_url":"https://api.github.com/repos/gsb76/spectre/pulls{/number}","milestones_url":"https://api.github.com/repos/gsb76/spectre/milestones{/number}","notifications_url":"https://api.github.com/repos/gsb76/spectre/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gsb76/spectre/labels{/name}","releases_url":"https://api.github.com/repos/gsb76/spectre/releases{/id}","deployments_url":"https://api.github.com/repos/gsb76/spectre/deployments","created_at":"2017-06-20T16:16:01Z","updated_at":"2017-06-20T16:16:03Z","pushed_at":"2017-06-27T17:12:05Z","git_url":"git://github.com/gsb76/spectre.git","ssh_url":"git@github.com:gsb76/spectre.git","clone_url":"https://github.com/gsb76/spectre.git","svn_url":"https://github.com/gsb76/spectre","homepage":null,"size":2788,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"sxs-collaboration:develop","ref":"develop","sha":"4ffdce72d0ef483ec80fe51966b9a10b34b0e13e","user":{"login":"sxs-collaboration","id":26882595,"avatar_url":"https://avatars1.githubusercontent.com/u/26882595?v=3","gravatar_id":"","url":"https://api.github.com/users/sxs-collaboration","html_url":"https://github.com/sxs-collaboration","followers_url":"https://api.github.com/users/sxs-collaboration/followers","following_url":"https://api.github.com/users/sxs-collaboration/following{/other_user}","gists_url":"https://api.github.com/users/sxs-collaboration/gists{/gist_id}","starred_url":"https://api.github.com/users/sxs-collaboration/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sxs-collaboration/subscriptions","organizations_url":"https://api.github.com/users/sxs-collaboration/orgs","repos_url":"https://api.github.com/users/sxs-collaboration/repos","events_url":"https://api.github.com/users/sxs-collaboration/events{/privacy}","received_events_url":"https://api.github.com/users/sxs-collaboration/received_events","type":"Organization","site_admin":false},"repo":{"id":87570510,"name":"spectre","full_name":"sxs-collaboration/spectre","owner":{"login":"sxs-collaboration","id":26882595,"avatar_url":"https://avatars1.githubusercontent.com/u/26882595?v=3","gravatar_id":"","url":"https://api.github.com/users/sxs-collaboration","html_url":"https://github.com/sxs-collaboration","followers_url":"https://api.github.com/users/sxs-collaboration/followers","following_url":"https://api.github.com/users/sxs-collaboration/following{/other_user}","gists_url":"https://api.github.com/users/sxs-collaboration/gists{/gist_id}","starred_url":"https://api.github.com/users/sxs-collaboration/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sxs-collaboration/subscriptions","organizations_url":"https://api.github.com/users/sxs-collaboration/orgs","repos_url":"https://api.github.com/users/sxs-collaboration/repos","events_url":"https://api.github.com/users/sxs-collaboration/events{/privacy}","received_events_url":"https://api.github.com/users/sxs-collaboration/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sxs-collaboration/spectre","description":null,"fork":false,"url":"https://api.github.com/repos/sxs-collaboration/spectre","forks_url":"https://api.github.com/repos/sxs-collaboration/spectre/forks","keys_url":"https://api.github.com/repos/sxs-collaboration/spectre/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sxs-collaboration/spectre/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sxs-collaboration/spectre/teams","hooks_url":"https://api.github.com/repos/sxs-collaboration/spectre/hooks","issue_events_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues/events{/number}","events_url":"https://api.github.com/repos/sxs-collaboration/spectre/events","assignees_url":"https://api.github.com/repos/sxs-collaboration/spectre/assignees{/user}","branches_url":"https://api.github.com/repos/sxs-collaboration/spectre/branches{/branch}","tags_url":"https://api.github.com/repos/sxs-collaboration/spectre/tags","blobs_url":"https://api.github.com/repos/sxs-collaboration/spectre/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sxs-collaboration/spectre/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sxs-collaboration/spectre/git/refs{/sha}","trees_url":"https://api.github.com/repos/sxs-collaboration/spectre/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sxs-collaboration/spectre/statuses/{sha}","languages_url":"https://api.github.com/repos/sxs-collaboration/spectre/languages","stargazers_url":"https://api.github.com/repos/sxs-collaboration/spectre/stargazers","contributors_url":"https://api.github.com/repos/sxs-collaboration/spectre/contributors","subscribers_url":"https://api.github.com/repos/sxs-collaboration/spectre/subscribers","subscription_url":"https://api.github.com/repos/sxs-collaboration/spectre/subscription","commits_url":"https://api.github.com/repos/sxs-collaboration/spectre/commits{/sha}","git_commits_url":"https://api.github.com/repos/sxs-collaboration/spectre/git/commits{/sha}","comments_url":"https://api.github.com/repos/sxs-collaboration/spectre/comments{/number}","issue_comment_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues/comments{/number}","contents_url":"https://api.github.com/repos/sxs-collaboration/spectre/contents/{+path}","compare_url":"https://api.github.com/repos/sxs-collaboration/spectre/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sxs-collaboration/spectre/merges","archive_url":"https://api.github.com/repos/sxs-collaboration/spectre/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sxs-collaboration/spectre/downloads","issues_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues{/number}","pulls_url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls{/number}","milestones_url":"https://api.github.com/repos/sxs-collaboration/spectre/milestones{/number}","notifications_url":"https://api.github.com/repos/sxs-collaboration/spectre/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sxs-collaboration/spectre/labels{/name}","releases_url":"https://api.github.com/repos/sxs-collaboration/spectre/releases{/id}","deployments_url":"https://api.github.com/repos/sxs-collaboration/spectre/deployments","created_at":"2017-04-07T17:28:20Z","updated_at":"2017-06-16T03:48:37Z","pushed_at":"2017-06-27T19:29:11Z","git_url":"git://github.com/sxs-collaboration/spectre.git","ssh_url":"git@github.com:sxs-collaboration/spectre.git","clone_url":"https://github.com/sxs-collaboration/spectre.git","svn_url":"https://github.com/sxs-collaboration/spectre","homepage":null,"size":4574,"stargazers_count":4,"watchers_count":4,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":5,"mirror_url":null,"open_issues_count":5,"forks":5,"open_issues":5,"watchers":4,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/60"},"html":{"href":"https://github.com/sxs-collaboration/spectre/pull/60"},"issue":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/issues/60"},"comments":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/issues/60/comments"},"review_comments":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/60/comments"},"review_comment":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/60/commits"},"statuses":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/statuses/e8e27311fbdc6ac1b55c64a3b8242f99b00d7db4"}}}}
{"actor":{"display_login":"fmahebert"}}