{"action":"created","comment":{"url":"https://api.github.com/repos/RocketMap/RocketMap/pulls/comments/117221056","pull_request_review_id":38907467,"id":117221056,"diff_hunk":"@@ -777,11 +777,17 @@ function playPokemonSound(pokemonID) {\n     if (!Store.get('playCries')) {\n         audio.play()\n     } else {\n-        var audioCry = new Audio('static/sounds/cries/' + pokemonID + '.wav')\n+        var audioCry = new Audio('static/sounds/cries/' + pokemonID + '.mp3')\n         audioCry.play().catch(function (err) {\n             if (err) {\n-                console.log('Sound for Pokémon ' + pokemonID + ' is missing, using generic sound instead.')\n-                audio.play()\n+                console.log('MP3 Sound for Pokémon ' + pokemonID + ' is missing, checking for Wav.')","path":"static/js/map.js","position":10,"original_position":10,"commit_id":"5db8c3dd3267d152c2f748331f0216667952f0a3","original_commit_id":"5db8c3dd3267d152c2f748331f0216667952f0a3","user":{"login":"sebastienvercammen","id":4874269,"avatar_url":"https://avatars0.githubusercontent.com/u/4874269?v=3","gravatar_id":"","url":"https://api.github.com/users/sebastienvercammen","html_url":"https://github.com/sebastienvercammen","followers_url":"https://api.github.com/users/sebastienvercammen/followers","following_url":"https://api.github.com/users/sebastienvercammen/following{/other_user}","gists_url":"https://api.github.com/users/sebastienvercammen/gists{/gist_id}","starred_url":"https://api.github.com/users/sebastienvercammen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebastienvercammen/subscriptions","organizations_url":"https://api.github.com/users/sebastienvercammen/orgs","repos_url":"https://api.github.com/users/sebastienvercammen/repos","events_url":"https://api.github.com/users/sebastienvercammen/events{/privacy}","received_events_url":"https://api.github.com/users/sebastienvercammen/received_events","type":"User","site_admin":false},"body":"`wav`, not `Wav`.","created_at":"2017-05-18T11:16:08Z","updated_at":"2017-05-18T11:16:11Z","html_url":"https://github.com/RocketMap/RocketMap/pull/2048#discussion_r117221056","pull_request_url":"https://api.github.com/repos/RocketMap/RocketMap/pulls/2048","_links":{"self":{"href":"https://api.github.com/repos/RocketMap/RocketMap/pulls/comments/117221056"},"html":{"href":"https://github.com/RocketMap/RocketMap/pull/2048#discussion_r117221056"},"pull_request":{"href":"https://api.github.com/repos/RocketMap/RocketMap/pulls/2048"}}},"pull_request":{"url":"https://api.github.com/repos/RocketMap/RocketMap/pulls/2048","id":121032367,"html_url":"https://github.com/RocketMap/RocketMap/pull/2048","diff_url":"https://github.com/RocketMap/RocketMap/pull/2048.diff","patch_url":"https://github.com/RocketMap/RocketMap/pull/2048.patch","issue_url":"https://api.github.com/repos/RocketMap/RocketMap/issues/2048","number":2048,"state":"open","locked":false,"title":"add mp3 support for cries","user":{"login":"BrownSlaughter","id":8204684,"avatar_url":"https://avatars1.githubusercontent.com/u/8204684?v=3","gravatar_id":"","url":"https://api.github.com/users/BrownSlaughter","html_url":"https://github.com/BrownSlaughter","followers_url":"https://api.github.com/users/BrownSlaughter/followers","following_url":"https://api.github.com/users/BrownSlaughter/following{/other_user}","gists_url":"https://api.github.com/users/BrownSlaughter/gists{/gist_id}","starred_url":"https://api.github.com/users/BrownSlaughter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrownSlaughter/subscriptions","organizations_url":"https://api.github.com/users/BrownSlaughter/orgs","repos_url":"https://api.github.com/users/BrownSlaughter/repos","events_url":"https://api.github.com/users/BrownSlaughter/events{/privacy}","received_events_url":"https://api.github.com/users/BrownSlaughter/received_events","type":"User","site_admin":false},"body":"<!--- Provide a general summary of your changes in the Title above -->\r\ncheck for mp3 format cries\r\n<!--- Describe your changes in detail -->\r\nfirst it checks for mp3, then Wav and then default ding\r\n## Motivation and Context\r\nDue to wav file sizes of voices it was better to convert to mp3 to save bandwith.\r\nThis also gives more choice to the user without having to convert sounds.\r\nAlso explorer can't play wav files\r\n\r\n## How Has This Been Tested?\r\non a map playing mp3 sounds and wav for notifications\r\n\r\n## Screenshots (if appropriate):\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [x ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n<!--  NOTE: In order to check code style locally and avoid having your build rejected by Travis, -->\r\n<!--  run the following commands before you commit: `flake8 .` and `npm run lint`. Fix any -->\r\n<!--  issues they point out. Note also that flake's NOQA is disabled on Travis. -->\r\n- [ x] My code follows the code style of this project.\r\n- [ ] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\n","created_at":"2017-05-17T11:18:15Z","updated_at":"2017-05-18T11:16:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"65e1c2b0a7741509de2f49d2588243104acfad98","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/RocketMap/RocketMap/pulls/2048/commits","review_comments_url":"https://api.github.com/repos/RocketMap/RocketMap/pulls/2048/comments","review_comment_url":"https://api.github.com/repos/RocketMap/RocketMap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RocketMap/RocketMap/issues/2048/comments","statuses_url":"https://api.github.com/repos/RocketMap/RocketMap/statuses/5db8c3dd3267d152c2f748331f0216667952f0a3","head":{"label":"BrownSlaughter:patch-1","ref":"patch-1","sha":"5db8c3dd3267d152c2f748331f0216667952f0a3","user":{"login":"BrownSlaughter","id":8204684,"avatar_url":"https://avatars1.githubusercontent.com/u/8204684?v=3","gravatar_id":"","url":"https://api.github.com/users/BrownSlaughter","html_url":"https://github.com/BrownSlaughter","followers_url":"https://api.github.com/users/BrownSlaughter/followers","following_url":"https://api.github.com/users/BrownSlaughter/following{/other_user}","gists_url":"https://api.github.com/users/BrownSlaughter/gists{/gist_id}","starred_url":"https://api.github.com/users/BrownSlaughter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrownSlaughter/subscriptions","organizations_url":"https://api.github.com/users/BrownSlaughter/orgs","repos_url":"https://api.github.com/users/BrownSlaughter/repos","events_url":"https://api.github.com/users/BrownSlaughter/events{/privacy}","received_events_url":"https://api.github.com/users/BrownSlaughter/received_events","type":"User","site_admin":false},"repo":{"id":90791805,"name":"RocketMap","full_name":"BrownSlaughter/RocketMap","owner":{"login":"BrownSlaughter","id":8204684,"avatar_url":"https://avatars1.githubusercontent.com/u/8204684?v=3","gravatar_id":"","url":"https://api.github.com/users/BrownSlaughter","html_url":"https://github.com/BrownSlaughter","followers_url":"https://api.github.com/users/BrownSlaughter/followers","following_url":"https://api.github.com/users/BrownSlaughter/following{/other_user}","gists_url":"https://api.github.com/users/BrownSlaughter/gists{/gist_id}","starred_url":"https://api.github.com/users/BrownSlaughter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrownSlaughter/subscriptions","organizations_url":"https://api.github.com/users/BrownSlaughter/orgs","repos_url":"https://api.github.com/users/BrownSlaughter/repos","events_url":"https://api.github.com/users/BrownSlaughter/events{/privacy}","received_events_url":"https://api.github.com/users/BrownSlaughter/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/BrownSlaughter/RocketMap","description":"🌏 Live visualization of all the pokemon in your area... and more!","fork":true,"url":"https://api.github.com/repos/BrownSlaughter/RocketMap","forks_url":"https://api.github.com/repos/BrownSlaughter/RocketMap/forks","keys_url":"https://api.github.com/repos/BrownSlaughter/RocketMap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BrownSlaughter/RocketMap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BrownSlaughter/RocketMap/teams","hooks_url":"https://api.github.com/repos/BrownSlaughter/RocketMap/hooks","issue_events_url":"https://api.github.com/repos/BrownSlaughter/RocketMap/issues/events{/number}","events_url":"https://api.github.com/repos/BrownSlaughter/RocketMap/events","assignees_url":"https://api.github.com/repos/BrownSlaughter/RocketMap/assignees{/user}","branches_url":"https://api.github.com/repos/BrownSlaughter/RocketMap/branches{/branch}","tags_url":"https://api.github.com/repos/BrownSlaughter/RocketMap/tags","blobs_url":"https://api.github.com/repos/BrownSlaughter/RocketMap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BrownSlaughter/RocketMap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BrownSlaughter/RocketMap/git/refs{/sha}","trees_url":"https://api.github.com/repos/BrownSlaughter/RocketMap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BrownSlaughter/RocketMap/statuses/{sha}","languages_url":"https://api.github.com/repos/BrownSlaughter/RocketMap/languages","stargazers_url":"https://api.github.com/repos/BrownSlaughter/RocketMap/stargazers","contributors_url":"https://api.github.com/repos/BrownSlaughter/RocketMap/contributors","subscribers_url":"https://api.github.com/repos/BrownSlaughter/RocketMap/subscribers","subscription_url":"https://api.github.com/repos/BrownSlaughter/RocketMap/subscription","commits_url":"https://api.github.com/repos/BrownSlaughter/RocketMap/commits{/sha}","git_commits_url":"https://api.github.com/repos/BrownSlaughter/RocketMap/git/commits{/sha}","comments_url":"https://api.github.com/repos/BrownSlaughter/RocketMap/comments{/number}","issue_comment_url":"https://api.github.com/repos/BrownSlaughter/RocketMap/issues/comments{/number}","contents_url":"https://api.github.com/repos/BrownSlaughter/RocketMap/contents/{+path}","compare_url":"https://api.github.com/repos/BrownSlaughter/RocketMap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BrownSlaughter/RocketMap/merges","archive_url":"https://api.github.com/repos/BrownSlaughter/RocketMap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BrownSlaughter/RocketMap/downloads","issues_url":"https://api.github.com/repos/BrownSlaughter/RocketMap/issues{/number}","pulls_url":"https://api.github.com/repos/BrownSlaughter/RocketMap/pulls{/number}","milestones_url":"https://api.github.com/repos/BrownSlaughter/RocketMap/milestones{/number}","notifications_url":"https://api.github.com/repos/BrownSlaughter/RocketMap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BrownSlaughter/RocketMap/labels{/name}","releases_url":"https://api.github.com/repos/BrownSlaughter/RocketMap/releases{/id}","deployments_url":"https://api.github.com/repos/BrownSlaughter/RocketMap/deployments","created_at":"2017-05-09T21:05:27Z","updated_at":"2017-05-09T21:05:29Z","pushed_at":"2017-05-17T22:14:56Z","git_url":"git://github.com/BrownSlaughter/RocketMap.git","ssh_url":"git@github.com:BrownSlaughter/RocketMap.git","clone_url":"https://github.com/BrownSlaughter/RocketMap.git","svn_url":"https://github.com/BrownSlaughter/RocketMap","homepage":"","size":30649,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"RocketMap:develop","ref":"develop","sha":"3a9ef78baaf6e813d57e4afb248a6c4c53b4be40","user":{"login":"RocketMap","id":20848202,"avatar_url":"https://avatars0.githubusercontent.com/u/20848202?v=3","gravatar_id":"","url":"https://api.github.com/users/RocketMap","html_url":"https://github.com/RocketMap","followers_url":"https://api.github.com/users/RocketMap/followers","following_url":"https://api.github.com/users/RocketMap/following{/other_user}","gists_url":"https://api.github.com/users/RocketMap/gists{/gist_id}","starred_url":"https://api.github.com/users/RocketMap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RocketMap/subscriptions","organizations_url":"https://api.github.com/users/RocketMap/orgs","repos_url":"https://api.github.com/users/RocketMap/repos","events_url":"https://api.github.com/users/RocketMap/events{/privacy}","received_events_url":"https://api.github.com/users/RocketMap/received_events","type":"Organization","site_admin":false},"repo":{"id":64970925,"name":"RocketMap","full_name":"RocketMap/RocketMap","owner":{"login":"RocketMap","id":20848202,"avatar_url":"https://avatars0.githubusercontent.com/u/20848202?v=3","gravatar_id":"","url":"https://api.github.com/users/RocketMap","html_url":"https://github.com/RocketMap","followers_url":"https://api.github.com/users/RocketMap/followers","following_url":"https://api.github.com/users/RocketMap/following{/other_user}","gists_url":"https://api.github.com/users/RocketMap/gists{/gist_id}","starred_url":"https://api.github.com/users/RocketMap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RocketMap/subscriptions","organizations_url":"https://api.github.com/users/RocketMap/orgs","repos_url":"https://api.github.com/users/RocketMap/repos","events_url":"https://api.github.com/users/RocketMap/events{/privacy}","received_events_url":"https://api.github.com/users/RocketMap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RocketMap/RocketMap","description":"🌏 Live visualization of all the pokemon in your area... and more!","fork":false,"url":"https://api.github.com/repos/RocketMap/RocketMap","forks_url":"https://api.github.com/repos/RocketMap/RocketMap/forks","keys_url":"https://api.github.com/repos/RocketMap/RocketMap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RocketMap/RocketMap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RocketMap/RocketMap/teams","hooks_url":"https://api.github.com/repos/RocketMap/RocketMap/hooks","issue_events_url":"https://api.github.com/repos/RocketMap/RocketMap/issues/events{/number}","events_url":"https://api.github.com/repos/RocketMap/RocketMap/events","assignees_url":"https://api.github.com/repos/RocketMap/RocketMap/assignees{/user}","branches_url":"https://api.github.com/repos/RocketMap/RocketMap/branches{/branch}","tags_url":"https://api.github.com/repos/RocketMap/RocketMap/tags","blobs_url":"https://api.github.com/repos/RocketMap/RocketMap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RocketMap/RocketMap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RocketMap/RocketMap/git/refs{/sha}","trees_url":"https://api.github.com/repos/RocketMap/RocketMap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RocketMap/RocketMap/statuses/{sha}","languages_url":"https://api.github.com/repos/RocketMap/RocketMap/languages","stargazers_url":"https://api.github.com/repos/RocketMap/RocketMap/stargazers","contributors_url":"https://api.github.com/repos/RocketMap/RocketMap/contributors","subscribers_url":"https://api.github.com/repos/RocketMap/RocketMap/subscribers","subscription_url":"https://api.github.com/repos/RocketMap/RocketMap/subscription","commits_url":"https://api.github.com/repos/RocketMap/RocketMap/commits{/sha}","git_commits_url":"https://api.github.com/repos/RocketMap/RocketMap/git/commits{/sha}","comments_url":"https://api.github.com/repos/RocketMap/RocketMap/comments{/number}","issue_comment_url":"https://api.github.com/repos/RocketMap/RocketMap/issues/comments{/number}","contents_url":"https://api.github.com/repos/RocketMap/RocketMap/contents/{+path}","compare_url":"https://api.github.com/repos/RocketMap/RocketMap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RocketMap/RocketMap/merges","archive_url":"https://api.github.com/repos/RocketMap/RocketMap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RocketMap/RocketMap/downloads","issues_url":"https://api.github.com/repos/RocketMap/RocketMap/issues{/number}","pulls_url":"https://api.github.com/repos/RocketMap/RocketMap/pulls{/number}","milestones_url":"https://api.github.com/repos/RocketMap/RocketMap/milestones{/number}","notifications_url":"https://api.github.com/repos/RocketMap/RocketMap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RocketMap/RocketMap/labels{/name}","releases_url":"https://api.github.com/repos/RocketMap/RocketMap/releases{/id}","deployments_url":"https://api.github.com/repos/RocketMap/RocketMap/deployments","created_at":"2016-08-04T22:18:49Z","updated_at":"2017-05-17T19:52:16Z","pushed_at":"2017-05-18T10:48:35Z","git_url":"git://github.com/RocketMap/RocketMap.git","ssh_url":"git@github.com:RocketMap/RocketMap.git","clone_url":"https://github.com/RocketMap/RocketMap.git","svn_url":"https://github.com/RocketMap/RocketMap","homepage":"","size":30625,"stargazers_count":2716,"watchers_count":2716,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1612,"mirror_url":null,"open_issues_count":117,"forks":1612,"open_issues":117,"watchers":2716,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/RocketMap/RocketMap/pulls/2048"},"html":{"href":"https://github.com/RocketMap/RocketMap/pull/2048"},"issue":{"href":"https://api.github.com/repos/RocketMap/RocketMap/issues/2048"},"comments":{"href":"https://api.github.com/repos/RocketMap/RocketMap/issues/2048/comments"},"review_comments":{"href":"https://api.github.com/repos/RocketMap/RocketMap/pulls/2048/comments"},"review_comment":{"href":"https://api.github.com/repos/RocketMap/RocketMap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RocketMap/RocketMap/pulls/2048/commits"},"statuses":{"href":"https://api.github.com/repos/RocketMap/RocketMap/statuses/5db8c3dd3267d152c2f748331f0216667952f0a3"}}}}
{"actor":{"display_login":"sebastienvercammen"}}