{"action":"closed","number":1,"pull_request":{"url":"https://api.github.com/repos/chaimleib/repoactions/pulls/1","id":138993029,"html_url":"https://github.com/chaimleib/repoactions/pull/1","diff_url":"https://github.com/chaimleib/repoactions/pull/1.diff","patch_url":"https://github.com/chaimleib/repoactions/pull/1.patch","issue_url":"https://api.github.com/repos/chaimleib/repoactions/issues/1","number":1,"state":"closed","locked":false,"title":"0.0.10 - fix uninstall.sh","user":{"login":"chaimleib","id":7785285,"avatar_url":"https://avatars1.githubusercontent.com/u/7785285?v=4","gravatar_id":"","url":"https://api.github.com/users/chaimleib","html_url":"https://github.com/chaimleib","followers_url":"https://api.github.com/users/chaimleib/followers","following_url":"https://api.github.com/users/chaimleib/following{/other_user}","gists_url":"https://api.github.com/users/chaimleib/gists{/gist_id}","starred_url":"https://api.github.com/users/chaimleib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chaimleib/subscriptions","organizations_url":"https://api.github.com/users/chaimleib/orgs","repos_url":"https://api.github.com/users/chaimleib/repos","events_url":"https://api.github.com/users/chaimleib/events{/privacy}","received_events_url":"https://api.github.com/users/chaimleib/received_events","type":"User","site_admin":false},"body":"The last line in `uninstall.sh` used `&&` with short-circuiting instead of an if statement to modify the `~/.profile` if it was present. If that file was missing, the test would return an error code, and since this was the last line in the program, the entire program would fail.\r\n\r\nThis caused `make uninstall` to fail. It also caused `make install` to fail, because on every install, it attempts to uninstall any previous version of repoactions.","created_at":"2017-09-02T00:36:08Z","updated_at":"2017-09-02T00:53:33Z","closed_at":"2017-09-02T00:53:33Z","merged_at":"2017-09-02T00:53:33Z","merge_commit_sha":"51846953e0101b513a0a376883fcd5108c146836","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/chaimleib/repoactions/pulls/1/commits","review_comments_url":"https://api.github.com/repos/chaimleib/repoactions/pulls/1/comments","review_comment_url":"https://api.github.com/repos/chaimleib/repoactions/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chaimleib/repoactions/issues/1/comments","statuses_url":"https://api.github.com/repos/chaimleib/repoactions/statuses/51846953e0101b513a0a376883fcd5108c146836","head":{"label":"chaimleib:dev","ref":"dev","sha":"51846953e0101b513a0a376883fcd5108c146836","user":{"login":"chaimleib","id":7785285,"avatar_url":"https://avatars1.githubusercontent.com/u/7785285?v=4","gravatar_id":"","url":"https://api.github.com/users/chaimleib","html_url":"https://github.com/chaimleib","followers_url":"https://api.github.com/users/chaimleib/followers","following_url":"https://api.github.com/users/chaimleib/following{/other_user}","gists_url":"https://api.github.com/users/chaimleib/gists{/gist_id}","starred_url":"https://api.github.com/users/chaimleib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chaimleib/subscriptions","organizations_url":"https://api.github.com/users/chaimleib/orgs","repos_url":"https://api.github.com/users/chaimleib/repos","events_url":"https://api.github.com/users/chaimleib/events{/privacy}","received_events_url":"https://api.github.com/users/chaimleib/received_events","type":"User","site_admin":false},"repo":{"id":74411019,"name":"repoactions","full_name":"chaimleib/repoactions","owner":{"login":"chaimleib","id":7785285,"avatar_url":"https://avatars1.githubusercontent.com/u/7785285?v=4","gravatar_id":"","url":"https://api.github.com/users/chaimleib","html_url":"https://github.com/chaimleib","followers_url":"https://api.github.com/users/chaimleib/followers","following_url":"https://api.github.com/users/chaimleib/following{/other_user}","gists_url":"https://api.github.com/users/chaimleib/gists{/gist_id}","starred_url":"https://api.github.com/users/chaimleib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chaimleib/subscriptions","organizations_url":"https://api.github.com/users/chaimleib/orgs","repos_url":"https://api.github.com/users/chaimleib/repos","events_url":"https://api.github.com/users/chaimleib/events{/privacy}","received_events_url":"https://api.github.com/users/chaimleib/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chaimleib/repoactions","description":"Run a script whenever you enter a git repo","fork":false,"url":"https://api.github.com/repos/chaimleib/repoactions","forks_url":"https://api.github.com/repos/chaimleib/repoactions/forks","keys_url":"https://api.github.com/repos/chaimleib/repoactions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chaimleib/repoactions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chaimleib/repoactions/teams","hooks_url":"https://api.github.com/repos/chaimleib/repoactions/hooks","issue_events_url":"https://api.github.com/repos/chaimleib/repoactions/issues/events{/number}","events_url":"https://api.github.com/repos/chaimleib/repoactions/events","assignees_url":"https://api.github.com/repos/chaimleib/repoactions/assignees{/user}","branches_url":"https://api.github.com/repos/chaimleib/repoactions/branches{/branch}","tags_url":"https://api.github.com/repos/chaimleib/repoactions/tags","blobs_url":"https://api.github.com/repos/chaimleib/repoactions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chaimleib/repoactions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chaimleib/repoactions/git/refs{/sha}","trees_url":"https://api.github.com/repos/chaimleib/repoactions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chaimleib/repoactions/statuses/{sha}","languages_url":"https://api.github.com/repos/chaimleib/repoactions/languages","stargazers_url":"https://api.github.com/repos/chaimleib/repoactions/stargazers","contributors_url":"https://api.github.com/repos/chaimleib/repoactions/contributors","subscribers_url":"https://api.github.com/repos/chaimleib/repoactions/subscribers","subscription_url":"https://api.github.com/repos/chaimleib/repoactions/subscription","commits_url":"https://api.github.com/repos/chaimleib/repoactions/commits{/sha}","git_commits_url":"https://api.github.com/repos/chaimleib/repoactions/git/commits{/sha}","comments_url":"https://api.github.com/repos/chaimleib/repoactions/comments{/number}","issue_comment_url":"https://api.github.com/repos/chaimleib/repoactions/issues/comments{/number}","contents_url":"https://api.github.com/repos/chaimleib/repoactions/contents/{+path}","compare_url":"https://api.github.com/repos/chaimleib/repoactions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chaimleib/repoactions/merges","archive_url":"https://api.github.com/repos/chaimleib/repoactions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chaimleib/repoactions/downloads","issues_url":"https://api.github.com/repos/chaimleib/repoactions/issues{/number}","pulls_url":"https://api.github.com/repos/chaimleib/repoactions/pulls{/number}","milestones_url":"https://api.github.com/repos/chaimleib/repoactions/milestones{/number}","notifications_url":"https://api.github.com/repos/chaimleib/repoactions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chaimleib/repoactions/labels{/name}","releases_url":"https://api.github.com/repos/chaimleib/repoactions/releases{/id}","deployments_url":"https://api.github.com/repos/chaimleib/repoactions/deployments","created_at":"2016-11-21T22:20:55Z","updated_at":"2016-11-22T21:15:37Z","pushed_at":"2017-09-02T00:53:32Z","git_url":"git://github.com/chaimleib/repoactions.git","ssh_url":"git@github.com:chaimleib/repoactions.git","clone_url":"https://github.com/chaimleib/repoactions.git","svn_url":"https://github.com/chaimleib/repoactions","homepage":"","size":55,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"chaimleib:master","ref":"master","sha":"f030399aa47e0115f238e1a5c88f5b9cc485144c","user":{"login":"chaimleib","id":7785285,"avatar_url":"https://avatars1.githubusercontent.com/u/7785285?v=4","gravatar_id":"","url":"https://api.github.com/users/chaimleib","html_url":"https://github.com/chaimleib","followers_url":"https://api.github.com/users/chaimleib/followers","following_url":"https://api.github.com/users/chaimleib/following{/other_user}","gists_url":"https://api.github.com/users/chaimleib/gists{/gist_id}","starred_url":"https://api.github.com/users/chaimleib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chaimleib/subscriptions","organizations_url":"https://api.github.com/users/chaimleib/orgs","repos_url":"https://api.github.com/users/chaimleib/repos","events_url":"https://api.github.com/users/chaimleib/events{/privacy}","received_events_url":"https://api.github.com/users/chaimleib/received_events","type":"User","site_admin":false},"repo":{"id":74411019,"name":"repoactions","full_name":"chaimleib/repoactions","owner":{"login":"chaimleib","id":7785285,"avatar_url":"https://avatars1.githubusercontent.com/u/7785285?v=4","gravatar_id":"","url":"https://api.github.com/users/chaimleib","html_url":"https://github.com/chaimleib","followers_url":"https://api.github.com/users/chaimleib/followers","following_url":"https://api.github.com/users/chaimleib/following{/other_user}","gists_url":"https://api.github.com/users/chaimleib/gists{/gist_id}","starred_url":"https://api.github.com/users/chaimleib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chaimleib/subscriptions","organizations_url":"https://api.github.com/users/chaimleib/orgs","repos_url":"https://api.github.com/users/chaimleib/repos","events_url":"https://api.github.com/users/chaimleib/events{/privacy}","received_events_url":"https://api.github.com/users/chaimleib/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chaimleib/repoactions","description":"Run a script whenever you enter a git repo","fork":false,"url":"https://api.github.com/repos/chaimleib/repoactions","forks_url":"https://api.github.com/repos/chaimleib/repoactions/forks","keys_url":"https://api.github.com/repos/chaimleib/repoactions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chaimleib/repoactions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chaimleib/repoactions/teams","hooks_url":"https://api.github.com/repos/chaimleib/repoactions/hooks","issue_events_url":"https://api.github.com/repos/chaimleib/repoactions/issues/events{/number}","events_url":"https://api.github.com/repos/chaimleib/repoactions/events","assignees_url":"https://api.github.com/repos/chaimleib/repoactions/assignees{/user}","branches_url":"https://api.github.com/repos/chaimleib/repoactions/branches{/branch}","tags_url":"https://api.github.com/repos/chaimleib/repoactions/tags","blobs_url":"https://api.github.com/repos/chaimleib/repoactions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chaimleib/repoactions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chaimleib/repoactions/git/refs{/sha}","trees_url":"https://api.github.com/repos/chaimleib/repoactions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chaimleib/repoactions/statuses/{sha}","languages_url":"https://api.github.com/repos/chaimleib/repoactions/languages","stargazers_url":"https://api.github.com/repos/chaimleib/repoactions/stargazers","contributors_url":"https://api.github.com/repos/chaimleib/repoactions/contributors","subscribers_url":"https://api.github.com/repos/chaimleib/repoactions/subscribers","subscription_url":"https://api.github.com/repos/chaimleib/repoactions/subscription","commits_url":"https://api.github.com/repos/chaimleib/repoactions/commits{/sha}","git_commits_url":"https://api.github.com/repos/chaimleib/repoactions/git/commits{/sha}","comments_url":"https://api.github.com/repos/chaimleib/repoactions/comments{/number}","issue_comment_url":"https://api.github.com/repos/chaimleib/repoactions/issues/comments{/number}","contents_url":"https://api.github.com/repos/chaimleib/repoactions/contents/{+path}","compare_url":"https://api.github.com/repos/chaimleib/repoactions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chaimleib/repoactions/merges","archive_url":"https://api.github.com/repos/chaimleib/repoactions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chaimleib/repoactions/downloads","issues_url":"https://api.github.com/repos/chaimleib/repoactions/issues{/number}","pulls_url":"https://api.github.com/repos/chaimleib/repoactions/pulls{/number}","milestones_url":"https://api.github.com/repos/chaimleib/repoactions/milestones{/number}","notifications_url":"https://api.github.com/repos/chaimleib/repoactions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chaimleib/repoactions/labels{/name}","releases_url":"https://api.github.com/repos/chaimleib/repoactions/releases{/id}","deployments_url":"https://api.github.com/repos/chaimleib/repoactions/deployments","created_at":"2016-11-21T22:20:55Z","updated_at":"2016-11-22T21:15:37Z","pushed_at":"2017-09-02T00:53:32Z","git_url":"git://github.com/chaimleib/repoactions.git","ssh_url":"git@github.com:chaimleib/repoactions.git","clone_url":"https://github.com/chaimleib/repoactions.git","svn_url":"https://github.com/chaimleib/repoactions","homepage":"","size":55,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chaimleib/repoactions/pulls/1"},"html":{"href":"https://github.com/chaimleib/repoactions/pull/1"},"issue":{"href":"https://api.github.com/repos/chaimleib/repoactions/issues/1"},"comments":{"href":"https://api.github.com/repos/chaimleib/repoactions/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/chaimleib/repoactions/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/chaimleib/repoactions/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chaimleib/repoactions/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/chaimleib/repoactions/statuses/51846953e0101b513a0a376883fcd5108c146836"}},"author_association":"OWNER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"chaimleib","id":7785285,"avatar_url":"https://avatars1.githubusercontent.com/u/7785285?v=4","gravatar_id":"","url":"https://api.github.com/users/chaimleib","html_url":"https://github.com/chaimleib","followers_url":"https://api.github.com/users/chaimleib/followers","following_url":"https://api.github.com/users/chaimleib/following{/other_user}","gists_url":"https://api.github.com/users/chaimleib/gists{/gist_id}","starred_url":"https://api.github.com/users/chaimleib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chaimleib/subscriptions","organizations_url":"https://api.github.com/users/chaimleib/orgs","repos_url":"https://api.github.com/users/chaimleib/repos","events_url":"https://api.github.com/users/chaimleib/events{/privacy}","received_events_url":"https://api.github.com/users/chaimleib/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":5,"additions":68,"deletions":47,"changed_files":13}}
{"actor":{"display_login":"chaimleib"}}