{"action":"created","comment":{"url":"https://api.github.com/repos/openzipkin/zipkin-go/pulls/comments/155389358","pull_request_review_id":81701160,"id":155389358,"diff_hunk":"@@ -0,0 +1,116 @@\n+/*\n+Package idgenerator contains several Span and Trace ID generators which can be\n+used by the Zipkin tracer. Additional third party generators can be plugged in\n+if they adhere to the IDGenerator interface.\n+*/\n+package idgenerator\n+\n+import (\n+\t\"math/rand\"\n+\t\"sync\"\n+\t\"time\"\n+\n+\t\"github.com/openzipkin/zipkin-go/model\"\n+)\n+\n+var (\n+\tseededIDGen = rand.New(rand.NewSource(time.Now().UnixNano()))","path":"idgenerator/idgenerator.go","position":17,"original_position":17,"commit_id":"0c4fc66ac9358e343cd042ed16e60d9748c58738","original_commit_id":"0c4fc66ac9358e343cd042ed16e60d9748c58738","user":{"login":"jcchavezs","id":3075074,"avatar_url":"https://avatars3.githubusercontent.com/u/3075074?v=4","gravatar_id":"","url":"https://api.github.com/users/jcchavezs","html_url":"https://github.com/jcchavezs","followers_url":"https://api.github.com/users/jcchavezs/followers","following_url":"https://api.github.com/users/jcchavezs/following{/other_user}","gists_url":"https://api.github.com/users/jcchavezs/gists{/gist_id}","starred_url":"https://api.github.com/users/jcchavezs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcchavezs/subscriptions","organizations_url":"https://api.github.com/users/jcchavezs/orgs","repos_url":"https://api.github.com/users/jcchavezs/repos","events_url":"https://api.github.com/users/jcchavezs/events{/privacy}","received_events_url":"https://api.github.com/users/jcchavezs/received_events","type":"User","site_admin":false},"body":"I do agree, I was more thinking as this as a function instead of a variable but as I said, not a strong opinion about it.","created_at":"2017-12-06T23:11:44Z","updated_at":"2017-12-06T23:11:44Z","html_url":"https://github.com/openzipkin/zipkin-go/pull/10#discussion_r155389358","pull_request_url":"https://api.github.com/repos/openzipkin/zipkin-go/pulls/10","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/openzipkin/zipkin-go/pulls/comments/155389358"},"html":{"href":"https://github.com/openzipkin/zipkin-go/pull/10#discussion_r155389358"},"pull_request":{"href":"https://api.github.com/repos/openzipkin/zipkin-go/pulls/10"}},"in_reply_to_id":155384381},"pull_request":{"url":"https://api.github.com/repos/openzipkin/zipkin-go/pulls/10","id":156392117,"html_url":"https://github.com/openzipkin/zipkin-go/pull/10","diff_url":"https://github.com/openzipkin/zipkin-go/pull/10.diff","patch_url":"https://github.com/openzipkin/zipkin-go/pull/10.patch","issue_url":"https://api.github.com/repos/openzipkin/zipkin-go/issues/10","number":10,"state":"open","locked":false,"title":"Updates to API and documentation","user":{"login":"basvanbeek","id":7205296,"avatar_url":"https://avatars0.githubusercontent.com/u/7205296?v=4","gravatar_id":"","url":"https://api.github.com/users/basvanbeek","html_url":"https://github.com/basvanbeek","followers_url":"https://api.github.com/users/basvanbeek/followers","following_url":"https://api.github.com/users/basvanbeek/following{/other_user}","gists_url":"https://api.github.com/users/basvanbeek/gists{/gist_id}","starred_url":"https://api.github.com/users/basvanbeek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basvanbeek/subscriptions","organizations_url":"https://api.github.com/users/basvanbeek/orgs","repos_url":"https://api.github.com/users/basvanbeek/repos","events_url":"https://api.github.com/users/basvanbeek/events{/privacy}","received_events_url":"https://api.github.com/users/basvanbeek/received_events","type":"User","site_admin":false},"body":"Cleaning up documentation and trying to clean up API","created_at":"2017-12-05T07:45:50Z","updated_at":"2017-12-06T23:11:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3d8963d975db92f7b1a436d2f4c657bbce57b413","assignee":{"login":"basvanbeek","id":7205296,"avatar_url":"https://avatars0.githubusercontent.com/u/7205296?v=4","gravatar_id":"","url":"https://api.github.com/users/basvanbeek","html_url":"https://github.com/basvanbeek","followers_url":"https://api.github.com/users/basvanbeek/followers","following_url":"https://api.github.com/users/basvanbeek/following{/other_user}","gists_url":"https://api.github.com/users/basvanbeek/gists{/gist_id}","starred_url":"https://api.github.com/users/basvanbeek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basvanbeek/subscriptions","organizations_url":"https://api.github.com/users/basvanbeek/orgs","repos_url":"https://api.github.com/users/basvanbeek/repos","events_url":"https://api.github.com/users/basvanbeek/events{/privacy}","received_events_url":"https://api.github.com/users/basvanbeek/received_events","type":"User","site_admin":false},"assignees":[{"login":"basvanbeek","id":7205296,"avatar_url":"https://avatars0.githubusercontent.com/u/7205296?v=4","gravatar_id":"","url":"https://api.github.com/users/basvanbeek","html_url":"https://github.com/basvanbeek","followers_url":"https://api.github.com/users/basvanbeek/followers","following_url":"https://api.github.com/users/basvanbeek/following{/other_user}","gists_url":"https://api.github.com/users/basvanbeek/gists{/gist_id}","starred_url":"https://api.github.com/users/basvanbeek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basvanbeek/subscriptions","organizations_url":"https://api.github.com/users/basvanbeek/orgs","repos_url":"https://api.github.com/users/basvanbeek/repos","events_url":"https://api.github.com/users/basvanbeek/events{/privacy}","received_events_url":"https://api.github.com/users/basvanbeek/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/openzipkin/zipkin-go/pulls/10/commits","review_comments_url":"https://api.github.com/repos/openzipkin/zipkin-go/pulls/10/comments","review_comment_url":"https://api.github.com/repos/openzipkin/zipkin-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openzipkin/zipkin-go/issues/10/comments","statuses_url":"https://api.github.com/repos/openzipkin/zipkin-go/statuses/0c4fc66ac9358e343cd042ed16e60d9748c58738","head":{"label":"basvanbeek:master","ref":"master","sha":"0c4fc66ac9358e343cd042ed16e60d9748c58738","user":{"login":"basvanbeek","id":7205296,"avatar_url":"https://avatars0.githubusercontent.com/u/7205296?v=4","gravatar_id":"","url":"https://api.github.com/users/basvanbeek","html_url":"https://github.com/basvanbeek","followers_url":"https://api.github.com/users/basvanbeek/followers","following_url":"https://api.github.com/users/basvanbeek/following{/other_user}","gists_url":"https://api.github.com/users/basvanbeek/gists{/gist_id}","starred_url":"https://api.github.com/users/basvanbeek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basvanbeek/subscriptions","organizations_url":"https://api.github.com/users/basvanbeek/orgs","repos_url":"https://api.github.com/users/basvanbeek/repos","events_url":"https://api.github.com/users/basvanbeek/events{/privacy}","received_events_url":"https://api.github.com/users/basvanbeek/received_events","type":"User","site_admin":false},"repo":{"id":108853174,"name":"zipkin-go","full_name":"basvanbeek/zipkin-go","owner":{"login":"basvanbeek","id":7205296,"avatar_url":"https://avatars0.githubusercontent.com/u/7205296?v=4","gravatar_id":"","url":"https://api.github.com/users/basvanbeek","html_url":"https://github.com/basvanbeek","followers_url":"https://api.github.com/users/basvanbeek/followers","following_url":"https://api.github.com/users/basvanbeek/following{/other_user}","gists_url":"https://api.github.com/users/basvanbeek/gists{/gist_id}","starred_url":"https://api.github.com/users/basvanbeek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basvanbeek/subscriptions","organizations_url":"https://api.github.com/users/basvanbeek/orgs","repos_url":"https://api.github.com/users/basvanbeek/repos","events_url":"https://api.github.com/users/basvanbeek/events{/privacy}","received_events_url":"https://api.github.com/users/basvanbeek/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/basvanbeek/zipkin-go","description":"Zipkin tracer library for go","fork":true,"url":"https://api.github.com/repos/basvanbeek/zipkin-go","forks_url":"https://api.github.com/repos/basvanbeek/zipkin-go/forks","keys_url":"https://api.github.com/repos/basvanbeek/zipkin-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/basvanbeek/zipkin-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/basvanbeek/zipkin-go/teams","hooks_url":"https://api.github.com/repos/basvanbeek/zipkin-go/hooks","issue_events_url":"https://api.github.com/repos/basvanbeek/zipkin-go/issues/events{/number}","events_url":"https://api.github.com/repos/basvanbeek/zipkin-go/events","assignees_url":"https://api.github.com/repos/basvanbeek/zipkin-go/assignees{/user}","branches_url":"https://api.github.com/repos/basvanbeek/zipkin-go/branches{/branch}","tags_url":"https://api.github.com/repos/basvanbeek/zipkin-go/tags","blobs_url":"https://api.github.com/repos/basvanbeek/zipkin-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/basvanbeek/zipkin-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/basvanbeek/zipkin-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/basvanbeek/zipkin-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/basvanbeek/zipkin-go/statuses/{sha}","languages_url":"https://api.github.com/repos/basvanbeek/zipkin-go/languages","stargazers_url":"https://api.github.com/repos/basvanbeek/zipkin-go/stargazers","contributors_url":"https://api.github.com/repos/basvanbeek/zipkin-go/contributors","subscribers_url":"https://api.github.com/repos/basvanbeek/zipkin-go/subscribers","subscription_url":"https://api.github.com/repos/basvanbeek/zipkin-go/subscription","commits_url":"https://api.github.com/repos/basvanbeek/zipkin-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/basvanbeek/zipkin-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/basvanbeek/zipkin-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/basvanbeek/zipkin-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/basvanbeek/zipkin-go/contents/{+path}","compare_url":"https://api.github.com/repos/basvanbeek/zipkin-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/basvanbeek/zipkin-go/merges","archive_url":"https://api.github.com/repos/basvanbeek/zipkin-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/basvanbeek/zipkin-go/downloads","issues_url":"https://api.github.com/repos/basvanbeek/zipkin-go/issues{/number}","pulls_url":"https://api.github.com/repos/basvanbeek/zipkin-go/pulls{/number}","milestones_url":"https://api.github.com/repos/basvanbeek/zipkin-go/milestones{/number}","notifications_url":"https://api.github.com/repos/basvanbeek/zipkin-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/basvanbeek/zipkin-go/labels{/name}","releases_url":"https://api.github.com/repos/basvanbeek/zipkin-go/releases{/id}","deployments_url":"https://api.github.com/repos/basvanbeek/zipkin-go/deployments","created_at":"2017-10-30T13:15:16Z","updated_at":"2017-11-06T15:09:30Z","pushed_at":"2017-12-06T18:13:45Z","git_url":"git://github.com/basvanbeek/zipkin-go.git","ssh_url":"git@github.com:basvanbeek/zipkin-go.git","clone_url":"https://github.com/basvanbeek/zipkin-go.git","svn_url":"https://github.com/basvanbeek/zipkin-go","homepage":null,"size":80,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"openzipkin:master","ref":"master","sha":"ed92b62a33798909db3bb8520fc29908556c38a6","user":{"login":"openzipkin","id":11860887,"avatar_url":"https://avatars3.githubusercontent.com/u/11860887?v=4","gravatar_id":"","url":"https://api.github.com/users/openzipkin","html_url":"https://github.com/openzipkin","followers_url":"https://api.github.com/users/openzipkin/followers","following_url":"https://api.github.com/users/openzipkin/following{/other_user}","gists_url":"https://api.github.com/users/openzipkin/gists{/gist_id}","starred_url":"https://api.github.com/users/openzipkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openzipkin/subscriptions","organizations_url":"https://api.github.com/users/openzipkin/orgs","repos_url":"https://api.github.com/users/openzipkin/repos","events_url":"https://api.github.com/users/openzipkin/events{/privacy}","received_events_url":"https://api.github.com/users/openzipkin/received_events","type":"Organization","site_admin":false},"repo":{"id":69353600,"name":"zipkin-go","full_name":"openzipkin/zipkin-go","owner":{"login":"openzipkin","id":11860887,"avatar_url":"https://avatars3.githubusercontent.com/u/11860887?v=4","gravatar_id":"","url":"https://api.github.com/users/openzipkin","html_url":"https://github.com/openzipkin","followers_url":"https://api.github.com/users/openzipkin/followers","following_url":"https://api.github.com/users/openzipkin/following{/other_user}","gists_url":"https://api.github.com/users/openzipkin/gists{/gist_id}","starred_url":"https://api.github.com/users/openzipkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openzipkin/subscriptions","organizations_url":"https://api.github.com/users/openzipkin/orgs","repos_url":"https://api.github.com/users/openzipkin/repos","events_url":"https://api.github.com/users/openzipkin/events{/privacy}","received_events_url":"https://api.github.com/users/openzipkin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openzipkin/zipkin-go","description":"Zipkin tracer library for go","fork":false,"url":"https://api.github.com/repos/openzipkin/zipkin-go","forks_url":"https://api.github.com/repos/openzipkin/zipkin-go/forks","keys_url":"https://api.github.com/repos/openzipkin/zipkin-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openzipkin/zipkin-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openzipkin/zipkin-go/teams","hooks_url":"https://api.github.com/repos/openzipkin/zipkin-go/hooks","issue_events_url":"https://api.github.com/repos/openzipkin/zipkin-go/issues/events{/number}","events_url":"https://api.github.com/repos/openzipkin/zipkin-go/events","assignees_url":"https://api.github.com/repos/openzipkin/zipkin-go/assignees{/user}","branches_url":"https://api.github.com/repos/openzipkin/zipkin-go/branches{/branch}","tags_url":"https://api.github.com/repos/openzipkin/zipkin-go/tags","blobs_url":"https://api.github.com/repos/openzipkin/zipkin-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openzipkin/zipkin-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openzipkin/zipkin-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/openzipkin/zipkin-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openzipkin/zipkin-go/statuses/{sha}","languages_url":"https://api.github.com/repos/openzipkin/zipkin-go/languages","stargazers_url":"https://api.github.com/repos/openzipkin/zipkin-go/stargazers","contributors_url":"https://api.github.com/repos/openzipkin/zipkin-go/contributors","subscribers_url":"https://api.github.com/repos/openzipkin/zipkin-go/subscribers","subscription_url":"https://api.github.com/repos/openzipkin/zipkin-go/subscription","commits_url":"https://api.github.com/repos/openzipkin/zipkin-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/openzipkin/zipkin-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/openzipkin/zipkin-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/openzipkin/zipkin-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/openzipkin/zipkin-go/contents/{+path}","compare_url":"https://api.github.com/repos/openzipkin/zipkin-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openzipkin/zipkin-go/merges","archive_url":"https://api.github.com/repos/openzipkin/zipkin-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openzipkin/zipkin-go/downloads","issues_url":"https://api.github.com/repos/openzipkin/zipkin-go/issues{/number}","pulls_url":"https://api.github.com/repos/openzipkin/zipkin-go/pulls{/number}","milestones_url":"https://api.github.com/repos/openzipkin/zipkin-go/milestones{/number}","notifications_url":"https://api.github.com/repos/openzipkin/zipkin-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openzipkin/zipkin-go/labels{/name}","releases_url":"https://api.github.com/repos/openzipkin/zipkin-go/releases{/id}","deployments_url":"https://api.github.com/repos/openzipkin/zipkin-go/deployments","created_at":"2016-09-27T12:19:53Z","updated_at":"2017-12-06T11:11:16Z","pushed_at":"2017-12-06T18:13:46Z","git_url":"git://github.com/openzipkin/zipkin-go.git","ssh_url":"git@github.com:openzipkin/zipkin-go.git","clone_url":"https://github.com/openzipkin/zipkin-go.git","svn_url":"https://github.com/openzipkin/zipkin-go","homepage":null,"size":42,"stargazers_count":5,"watchers_count":5,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":2,"open_issues":2,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openzipkin/zipkin-go/pulls/10"},"html":{"href":"https://github.com/openzipkin/zipkin-go/pull/10"},"issue":{"href":"https://api.github.com/repos/openzipkin/zipkin-go/issues/10"},"comments":{"href":"https://api.github.com/repos/openzipkin/zipkin-go/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/openzipkin/zipkin-go/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/openzipkin/zipkin-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openzipkin/zipkin-go/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/openzipkin/zipkin-go/statuses/0c4fc66ac9358e343cd042ed16e60d9748c58738"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"jcchavezs"}}