{"action":"created","issue":{"url":"https://api.github.com/repos/KAIST-IS521/Scanner/issues/1","repository_url":"https://api.github.com/repos/KAIST-IS521/Scanner","labels_url":"https://api.github.com/repos/KAIST-IS521/Scanner/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/KAIST-IS521/Scanner/issues/1/comments","events_url":"https://api.github.com/repos/KAIST-IS521/Scanner/issues/1/events","html_url":"https://github.com/KAIST-IS521/Scanner/pull/1","id":217823508,"number":1,"title":"Fix overflow vulnerability in rule-file argument","user":{"login":"mfaerevaag","id":1221244,"avatar_url":"https://avatars2.githubusercontent.com/u/1221244?v=3","gravatar_id":"","url":"https://api.github.com/users/mfaerevaag","html_url":"https://github.com/mfaerevaag","followers_url":"https://api.github.com/users/mfaerevaag/followers","following_url":"https://api.github.com/users/mfaerevaag/following{/other_user}","gists_url":"https://api.github.com/users/mfaerevaag/gists{/gist_id}","starred_url":"https://api.github.com/users/mfaerevaag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfaerevaag/subscriptions","organizations_url":"https://api.github.com/users/mfaerevaag/orgs","repos_url":"https://api.github.com/users/mfaerevaag/repos","events_url":"https://api.github.com/users/mfaerevaag/events{/privacy}","received_events_url":"https://api.github.com/users/mfaerevaag/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-03-29T09:54:44Z","updated_at":"2017-03-30T07:03:14Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/KAIST-IS521/Scanner/pulls/1","html_url":"https://github.com/KAIST-IS521/Scanner/pull/1","diff_url":"https://github.com/KAIST-IS521/Scanner/pull/1.diff","patch_url":"https://github.com/KAIST-IS521/Scanner/pull/1.patch"},"body":"~~Stack~~ overflow vulnerability when doing `strdup` of argument. \r\n\r\nExploited by doing something like `build/scanner -r $(python -c \"print('a' * 9999999)\")`\r\n\r\nFixed with `strndup`, giving it linux's max length of a file's path (4096 on my system), found in `linux/limits.h`. \r\n\r\nEDIT: Not stack, of course. `strdup` allocates to heap"},"comment":{"url":"https://api.github.com/repos/KAIST-IS521/Scanner/issues/comments/290320909","html_url":"https://github.com/KAIST-IS521/Scanner/pull/1#issuecomment-290320909","issue_url":"https://api.github.com/repos/KAIST-IS521/Scanner/issues/1","id":290320909,"user":{"login":"mfaerevaag","id":1221244,"avatar_url":"https://avatars2.githubusercontent.com/u/1221244?v=3","gravatar_id":"","url":"https://api.github.com/users/mfaerevaag","html_url":"https://github.com/mfaerevaag","followers_url":"https://api.github.com/users/mfaerevaag/followers","following_url":"https://api.github.com/users/mfaerevaag/following{/other_user}","gists_url":"https://api.github.com/users/mfaerevaag/gists{/gist_id}","starred_url":"https://api.github.com/users/mfaerevaag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfaerevaag/subscriptions","organizations_url":"https://api.github.com/users/mfaerevaag/orgs","repos_url":"https://api.github.com/users/mfaerevaag/repos","events_url":"https://api.github.com/users/mfaerevaag/events{/privacy}","received_events_url":"https://api.github.com/users/mfaerevaag/received_events","type":"User","site_admin":false},"created_at":"2017-03-30T07:03:14Z","updated_at":"2017-03-30T07:03:14Z","body":"I think I was unclear in saying \"wreaking havoc\". I only meant using a lot of resources and in a bad way, as these resources are being wasted since their exceeding the maximum length for a path.\r\n\r\nI also read the Stack Overflow after your critique. Good discussion!"}}
{"actor":{"display_login":"mfaerevaag"}}