{"push_id":1812359168,"size":8,"distinct_size":4,"ref":"refs/heads/try","head":"248702c9e3e8d7290661d9e6cd612ef8d13f045c","before":"2f035cbbca99c8f296f9d00a8d46f333e8625564","commits":[{"sha":"be60c6d7f6a0759a5360bef6f7e5db21e07234f0","author":{"name":"Jack Grigg","email":"7bb7087018cc5fef3c041f6f038f586664845dbf@z.cash"},"message":"Rename FALLBACK_DOWNLOAD_PATH to PRIORITY_DOWNLOAD_PATH\n\nCloses #1621.","distinct":false,"url":"https://api.github.com/repos/zcash/zcash/commits/be60c6d7f6a0759a5360bef6f7e5db21e07234f0"},{"sha":"26d27a15ceb495d3c70365b8b0495bde3afe7902","author":{"name":"Kevin Pan","email":"9c55bffb86dd8100fa65d8609a7f479cf078c960@gmail.com"},"message":"\"getblocktemplate\" could work without wallet","distinct":false,"url":"https://api.github.com/repos/zcash/zcash/commits/26d27a15ceb495d3c70365b8b0495bde3afe7902"},{"sha":"00fd23930b166ad6773d9420c704265d9d056a7e","author":{"name":"Homu","email":"7d03543b17a2d89359d427833d12a69e3b5a84a7@z.cash"},"message":"Auto merge of #2443 - str4d:1621-priority-download-path, r=str4d\n\nRename FALLBACK_DOWNLOAD_PATH to PRIORITY_DOWNLOAD_PATH\n\nCloses #1621.","distinct":false,"url":"https://api.github.com/repos/zcash/zcash/commits/00fd23930b166ad6773d9420c704265d9d056a7e"},{"sha":"c050b9946975a16d12dd5ae1b163a388e594da4b","author":{"name":"Homu","email":"7d03543b17a2d89359d427833d12a69e3b5a84a7@z.cash"},"message":"Auto merge of #2456 - btccom:master, r=str4d\n\n[mining] let \"getblocktemplate\" work when disable wallet\n\nwe already support GetBlockTemplate without build wallet, see:\n\nhttps://github.com/zcash/zcash/blob/master/src/rpcmining.cpp\n\n```\n    // Wallet or miner address is required because we support coinbasetxn\n    if (GetArg(\"-mineraddress\", \"\").empty()) {\n#ifdef ENABLE_WALLET\n        if (!pwalletMain) {\n            throw JSONRPCError(RPC_METHOD_NOT_FOUND, \"Wallet disabled and -mineraddress not set\");\n        }\n#else\n        throw JSONRPCError(RPC_METHOD_NOT_FOUND, \"zcashd compiled without wallet and -mineraddress not set\");\n#endif\n    }\n```\n\nso the macro should be removed from `src/rpcserver.cpp`, otherwise you can't call `getblocktemplate` when you disable wallet.","distinct":false,"url":"https://api.github.com/repos/zcash/zcash/commits/c050b9946975a16d12dd5ae1b163a388e594da4b"},{"sha":"b2712ab9a89e0d60ff705edd2ae0d39665a53f99","author":{"name":"Daira Hopwood","email":"ac2a10971ee5748959a9bbe2e61ffe4e75315ce0@jacaranda.org"},"message":"Clean up imports to be pyflakes-checkable. fixes #2450\n\nSigned-off-by: Daira Hopwood <daira@jacaranda.org>","distinct":true,"url":"https://api.github.com/repos/zcash/zcash/commits/b2712ab9a89e0d60ff705edd2ae0d39665a53f99"},{"sha":"0fa02c82ae314af765f2e0db77fbaa876cbb5d07","author":{"name":"Daira Hopwood","email":"ac2a10971ee5748959a9bbe2e61ffe4e75315ce0@jacaranda.org"},"message":"For unused variables reported by pyflakes, either remove the variable,\nsuppress the warning, or fix a bug (if the wrong variable was used).\nrefs #2450\n\nSigned-off-by: Daira Hopwood <daira@jacaranda.org>","distinct":true,"url":"https://api.github.com/repos/zcash/zcash/commits/0fa02c82ae314af765f2e0db77fbaa876cbb5d07"},{"sha":"9c7dc58245d48a6918026db9cf9b8ba159ed5d5d","author":{"name":"Daira Hopwood","email":"ac2a10971ee5748959a9bbe2e61ffe4e75315ce0@jacaranda.org"},"message":"Cosmetics (trailing whitespace, comment conventions, etc.)\n\nSigned-off-by: Daira Hopwood <daira@jacaranda.org>","distinct":true,"url":"https://api.github.com/repos/zcash/zcash/commits/9c7dc58245d48a6918026db9cf9b8ba159ed5d5d"},{"sha":"248702c9e3e8d7290661d9e6cd612ef8d13f045c","author":{"name":"Homu","email":"7d03543b17a2d89359d427833d12a69e3b5a84a7@z.cash"},"message":"Auto merge of #2458 - daira:2450.pyflakes-cleanup, r=<try>\n\n2450.pyflakes cleanup\n\nMake the RPC tests pyflakes-clean. fixes #2450","distinct":true,"url":"https://api.github.com/repos/zcash/zcash/commits/248702c9e3e8d7290661d9e6cd612ef8d13f045c"}]}
{"actor":{"display_login":"zkbot"}}