{"action":"created","issue":{"url":"https://api.github.com/repos/cucumber/cucumber-ruby/issues/1136","repository_url":"https://api.github.com/repos/cucumber/cucumber-ruby","labels_url":"https://api.github.com/repos/cucumber/cucumber-ruby/issues/1136/labels{/name}","comments_url":"https://api.github.com/repos/cucumber/cucumber-ruby/issues/1136/comments","events_url":"https://api.github.com/repos/cucumber/cucumber-ruby/issues/1136/events","html_url":"https://github.com/cucumber/cucumber-ruby/pull/1136","id":239126558,"number":1136,"title":"Frozen-string-literal fixes in eval'd code.","user":{"login":"pat","id":4183,"avatar_url":"https://avatars1.githubusercontent.com/u/4183?v=3","gravatar_id":"","url":"https://api.github.com/users/pat","html_url":"https://github.com/pat","followers_url":"https://api.github.com/users/pat/followers","following_url":"https://api.github.com/users/pat/following{/other_user}","gists_url":"https://api.github.com/users/pat/gists{/gist_id}","starred_url":"https://api.github.com/users/pat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pat/subscriptions","organizations_url":"https://api.github.com/users/pat/orgs","repos_url":"https://api.github.com/users/pat/repos","events_url":"https://api.github.com/users/pat/events{/privacy}","received_events_url":"https://api.github.com/users/pat/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-06-28T10:55:33Z","updated_at":"2017-07-05T22:31:02Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cucumber/cucumber-ruby/pulls/1136","html_url":"https://github.com/cucumber/cucumber-ruby/pull/1136","diff_url":"https://github.com/cucumber/cucumber-ruby/pull/1136.diff","patch_url":"https://github.com/cucumber/cucumber-ruby/pull/1136.patch"},"body":"## Summary\r\n\r\nThe pragma comment doesn't pick up these uses because the code is eval'd on the fly.\r\n\r\nRelated:\r\n* https://github.com/dblock/syntax/pull/6\r\n* https://github.com/cucumber/aruba/pull/436\r\n* https://github.com/rspec/rspec-core/pull/2437\r\n\r\n## How Has This Been Tested?\r\n\r\nI've managed to get the test suite passing locally with the `--enable-frozen-string-literal` `RUBYOPT` flag, using my own copy of Aruba plus some related upgrading changes because Cucumber's been locked to an old Aruba version for quite some time. I've also used the rspec-core test suite (which makes use of Cucumber) and my local cucumber copy to confirm their test suite is green as well.\r\n\r\n## Types of changes\r\n\r\n- [x] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)\r\n\r\nGiven the pragma comments, I'm presuming being frozen-string-literal-friendly is a goal of Cucumber, hence pretty confident in labelling this a bug fix :)\r\n\r\n## Checklist:\r\n\r\n- [ ] I've added tests for my code\r\n- [ ] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\n\r\nNone of the checklist items here apply."},"comment":{"url":"https://api.github.com/repos/cucumber/cucumber-ruby/issues/comments/313244865","html_url":"https://github.com/cucumber/cucumber-ruby/pull/1136#issuecomment-313244865","issue_url":"https://api.github.com/repos/cucumber/cucumber-ruby/issues/1136","id":313244865,"user":{"login":"danascheider","id":5115928,"avatar_url":"https://avatars2.githubusercontent.com/u/5115928?v=3","gravatar_id":"","url":"https://api.github.com/users/danascheider","html_url":"https://github.com/danascheider","followers_url":"https://api.github.com/users/danascheider/followers","following_url":"https://api.github.com/users/danascheider/following{/other_user}","gists_url":"https://api.github.com/users/danascheider/gists{/gist_id}","starred_url":"https://api.github.com/users/danascheider/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danascheider/subscriptions","organizations_url":"https://api.github.com/users/danascheider/orgs","repos_url":"https://api.github.com/users/danascheider/repos","events_url":"https://api.github.com/users/danascheider/events{/privacy}","received_events_url":"https://api.github.com/users/danascheider/received_events","type":"User","site_admin":false},"created_at":"2017-07-05T22:31:02Z","updated_at":"2017-07-05T22:31:02Z","body":"@pat Some of the AppVeyor failures are fixed on master now - if you can rebase we can see if that fixes everything. Thanks for your help!"}}
{"actor":{"display_login":"danascheider"}}