{"action":"created","comment":{"url":"https://api.github.com/repos/ska-sa/casperfpga/pulls/comments/110639783","pull_request_review_id":31825496,"id":110639783,"diff_hunk":"@@ -285,6 +289,56 @@ def read(self, device_name, size, offset=0):\n         # return the number of bytes requested\n         return data[offset: offset + size]\n \n+    def bulk_read(self, device_name, size, offset=0):\n+        \"\"\"\n+        Return size_bytes of binary data with carriage-return escape-sequenced.\n+        :param device_name: name of memory device from which to read\n+        :param size: how many bytes to read\n+        :param offset: start at this offset, offset in bytes\n+        :return: binary data string\n+        \"\"\"\n+\n+        # map device name to address, if can't find, bail\n+        if device_name in self.memory_devices.keys():\n+            addr = self.memory_devices[device_name].address\n+        elif type(device_name) == int and 0 <= device_name < 2 ** 32:","path":"src/skarab_fpga.py","position":27,"original_position":27,"commit_id":"b5b821f0e17ddfa3772499b4d196868b3c9b016d","original_commit_id":"b5b821f0e17ddfa3772499b4d196868b3c9b016d","user":{"login":"paulprozesky","id":1320992,"avatar_url":"https://avatars2.githubusercontent.com/u/1320992?v=3","gravatar_id":"","url":"https://api.github.com/users/paulprozesky","html_url":"https://github.com/paulprozesky","followers_url":"https://api.github.com/users/paulprozesky/followers","following_url":"https://api.github.com/users/paulprozesky/following{/other_user}","gists_url":"https://api.github.com/users/paulprozesky/gists{/gist_id}","starred_url":"https://api.github.com/users/paulprozesky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulprozesky/subscriptions","organizations_url":"https://api.github.com/users/paulprozesky/orgs","repos_url":"https://api.github.com/users/paulprozesky/repos","events_url":"https://api.github.com/users/paulprozesky/events{/privacy}","received_events_url":"https://api.github.com/users/paulprozesky/received_events","type":"User","site_admin":false},"body":"@tyronevb - why the test for is-an-int if you are checking the size anyway?","created_at":"2017-04-10T12:20:01Z","updated_at":"2017-04-10T12:36:05Z","html_url":"https://github.com/ska-sa/casperfpga/pull/59#discussion_r110639783","pull_request_url":"https://api.github.com/repos/ska-sa/casperfpga/pulls/59","_links":{"self":{"href":"https://api.github.com/repos/ska-sa/casperfpga/pulls/comments/110639783"},"html":{"href":"https://github.com/ska-sa/casperfpga/pull/59#discussion_r110639783"},"pull_request":{"href":"https://api.github.com/repos/ska-sa/casperfpga/pulls/59"}}},"pull_request":{"url":"https://api.github.com/repos/ska-sa/casperfpga/pulls/59","id":115084323,"html_url":"https://github.com/ska-sa/casperfpga/pull/59","diff_url":"https://github.com/ska-sa/casperfpga/pull/59.diff","patch_url":"https://github.com/ska-sa/casperfpga/pull/59.patch","issue_url":"https://api.github.com/repos/ska-sa/casperfpga/issues/59","number":59,"state":"open","locked":false,"title":"Skarab big rw","user":{"login":"tyronevb","id":13017945,"avatar_url":"https://avatars2.githubusercontent.com/u/13017945?v=3","gravatar_id":"","url":"https://api.github.com/users/tyronevb","html_url":"https://github.com/tyronevb","followers_url":"https://api.github.com/users/tyronevb/followers","following_url":"https://api.github.com/users/tyronevb/following{/other_user}","gists_url":"https://api.github.com/users/tyronevb/gists{/gist_id}","starred_url":"https://api.github.com/users/tyronevb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tyronevb/subscriptions","organizations_url":"https://api.github.com/users/tyronevb/orgs","repos_url":"https://api.github.com/users/tyronevb/repos","events_url":"https://api.github.com/users/tyronevb/events{/privacy}","received_events_url":"https://api.github.com/users/tyronevb/received_events","type":"User","site_admin":false},"body":"@paulprozesky I've added support for bulk read operations from the SKARAB. Also addressed the issue regarding mismatching opcodes in skarab_definitions versus the microblaze source code.","created_at":"2017-04-10T11:57:40Z","updated_at":"2017-04-10T12:36:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"26c19b653b83f3c3cdcdbc8c3a280a5afe27cc5c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ska-sa/casperfpga/pulls/59/commits","review_comments_url":"https://api.github.com/repos/ska-sa/casperfpga/pulls/59/comments","review_comment_url":"https://api.github.com/repos/ska-sa/casperfpga/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ska-sa/casperfpga/issues/59/comments","statuses_url":"https://api.github.com/repos/ska-sa/casperfpga/statuses/b5b821f0e17ddfa3772499b4d196868b3c9b016d","head":{"label":"ska-sa:skarab_big_rw","ref":"skarab_big_rw","sha":"b5b821f0e17ddfa3772499b4d196868b3c9b016d","user":{"login":"ska-sa","id":1210238,"avatar_url":"https://avatars0.githubusercontent.com/u/1210238?v=3","gravatar_id":"","url":"https://api.github.com/users/ska-sa","html_url":"https://github.com/ska-sa","followers_url":"https://api.github.com/users/ska-sa/followers","following_url":"https://api.github.com/users/ska-sa/following{/other_user}","gists_url":"https://api.github.com/users/ska-sa/gists{/gist_id}","starred_url":"https://api.github.com/users/ska-sa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ska-sa/subscriptions","organizations_url":"https://api.github.com/users/ska-sa/orgs","repos_url":"https://api.github.com/users/ska-sa/repos","events_url":"https://api.github.com/users/ska-sa/events{/privacy}","received_events_url":"https://api.github.com/users/ska-sa/received_events","type":"Organization","site_admin":false},"repo":{"id":20776716,"name":"casperfpga","full_name":"ska-sa/casperfpga","owner":{"login":"ska-sa","id":1210238,"avatar_url":"https://avatars0.githubusercontent.com/u/1210238?v=3","gravatar_id":"","url":"https://api.github.com/users/ska-sa","html_url":"https://github.com/ska-sa","followers_url":"https://api.github.com/users/ska-sa/followers","following_url":"https://api.github.com/users/ska-sa/following{/other_user}","gists_url":"https://api.github.com/users/ska-sa/gists{/gist_id}","starred_url":"https://api.github.com/users/ska-sa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ska-sa/subscriptions","organizations_url":"https://api.github.com/users/ska-sa/orgs","repos_url":"https://api.github.com/users/ska-sa/repos","events_url":"https://api.github.com/users/ska-sa/events{/privacy}","received_events_url":"https://api.github.com/users/ska-sa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ska-sa/casperfpga","description":"Software control for CASPER FPGAs","fork":false,"url":"https://api.github.com/repos/ska-sa/casperfpga","forks_url":"https://api.github.com/repos/ska-sa/casperfpga/forks","keys_url":"https://api.github.com/repos/ska-sa/casperfpga/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ska-sa/casperfpga/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ska-sa/casperfpga/teams","hooks_url":"https://api.github.com/repos/ska-sa/casperfpga/hooks","issue_events_url":"https://api.github.com/repos/ska-sa/casperfpga/issues/events{/number}","events_url":"https://api.github.com/repos/ska-sa/casperfpga/events","assignees_url":"https://api.github.com/repos/ska-sa/casperfpga/assignees{/user}","branches_url":"https://api.github.com/repos/ska-sa/casperfpga/branches{/branch}","tags_url":"https://api.github.com/repos/ska-sa/casperfpga/tags","blobs_url":"https://api.github.com/repos/ska-sa/casperfpga/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ska-sa/casperfpga/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ska-sa/casperfpga/git/refs{/sha}","trees_url":"https://api.github.com/repos/ska-sa/casperfpga/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ska-sa/casperfpga/statuses/{sha}","languages_url":"https://api.github.com/repos/ska-sa/casperfpga/languages","stargazers_url":"https://api.github.com/repos/ska-sa/casperfpga/stargazers","contributors_url":"https://api.github.com/repos/ska-sa/casperfpga/contributors","subscribers_url":"https://api.github.com/repos/ska-sa/casperfpga/subscribers","subscription_url":"https://api.github.com/repos/ska-sa/casperfpga/subscription","commits_url":"https://api.github.com/repos/ska-sa/casperfpga/commits{/sha}","git_commits_url":"https://api.github.com/repos/ska-sa/casperfpga/git/commits{/sha}","comments_url":"https://api.github.com/repos/ska-sa/casperfpga/comments{/number}","issue_comment_url":"https://api.github.com/repos/ska-sa/casperfpga/issues/comments{/number}","contents_url":"https://api.github.com/repos/ska-sa/casperfpga/contents/{+path}","compare_url":"https://api.github.com/repos/ska-sa/casperfpga/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ska-sa/casperfpga/merges","archive_url":"https://api.github.com/repos/ska-sa/casperfpga/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ska-sa/casperfpga/downloads","issues_url":"https://api.github.com/repos/ska-sa/casperfpga/issues{/number}","pulls_url":"https://api.github.com/repos/ska-sa/casperfpga/pulls{/number}","milestones_url":"https://api.github.com/repos/ska-sa/casperfpga/milestones{/number}","notifications_url":"https://api.github.com/repos/ska-sa/casperfpga/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ska-sa/casperfpga/labels{/name}","releases_url":"https://api.github.com/repos/ska-sa/casperfpga/releases{/id}","deployments_url":"https://api.github.com/repos/ska-sa/casperfpga/deployments","created_at":"2014-06-12T17:34:39Z","updated_at":"2016-01-20T06:42:13Z","pushed_at":"2017-04-10T11:57:41Z","git_url":"git://github.com/ska-sa/casperfpga.git","ssh_url":"git@github.com:ska-sa/casperfpga.git","clone_url":"https://github.com/ska-sa/casperfpga.git","svn_url":"https://github.com/ska-sa/casperfpga","homepage":null,"size":637,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":2,"default_branch":"master"}},"base":{"label":"ska-sa:devel","ref":"devel","sha":"7f876094fe4a1d5a1d5f3a8c287f5a807e3f3641","user":{"login":"ska-sa","id":1210238,"avatar_url":"https://avatars0.githubusercontent.com/u/1210238?v=3","gravatar_id":"","url":"https://api.github.com/users/ska-sa","html_url":"https://github.com/ska-sa","followers_url":"https://api.github.com/users/ska-sa/followers","following_url":"https://api.github.com/users/ska-sa/following{/other_user}","gists_url":"https://api.github.com/users/ska-sa/gists{/gist_id}","starred_url":"https://api.github.com/users/ska-sa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ska-sa/subscriptions","organizations_url":"https://api.github.com/users/ska-sa/orgs","repos_url":"https://api.github.com/users/ska-sa/repos","events_url":"https://api.github.com/users/ska-sa/events{/privacy}","received_events_url":"https://api.github.com/users/ska-sa/received_events","type":"Organization","site_admin":false},"repo":{"id":20776716,"name":"casperfpga","full_name":"ska-sa/casperfpga","owner":{"login":"ska-sa","id":1210238,"avatar_url":"https://avatars0.githubusercontent.com/u/1210238?v=3","gravatar_id":"","url":"https://api.github.com/users/ska-sa","html_url":"https://github.com/ska-sa","followers_url":"https://api.github.com/users/ska-sa/followers","following_url":"https://api.github.com/users/ska-sa/following{/other_user}","gists_url":"https://api.github.com/users/ska-sa/gists{/gist_id}","starred_url":"https://api.github.com/users/ska-sa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ska-sa/subscriptions","organizations_url":"https://api.github.com/users/ska-sa/orgs","repos_url":"https://api.github.com/users/ska-sa/repos","events_url":"https://api.github.com/users/ska-sa/events{/privacy}","received_events_url":"https://api.github.com/users/ska-sa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ska-sa/casperfpga","description":"Software control for CASPER FPGAs","fork":false,"url":"https://api.github.com/repos/ska-sa/casperfpga","forks_url":"https://api.github.com/repos/ska-sa/casperfpga/forks","keys_url":"https://api.github.com/repos/ska-sa/casperfpga/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ska-sa/casperfpga/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ska-sa/casperfpga/teams","hooks_url":"https://api.github.com/repos/ska-sa/casperfpga/hooks","issue_events_url":"https://api.github.com/repos/ska-sa/casperfpga/issues/events{/number}","events_url":"https://api.github.com/repos/ska-sa/casperfpga/events","assignees_url":"https://api.github.com/repos/ska-sa/casperfpga/assignees{/user}","branches_url":"https://api.github.com/repos/ska-sa/casperfpga/branches{/branch}","tags_url":"https://api.github.com/repos/ska-sa/casperfpga/tags","blobs_url":"https://api.github.com/repos/ska-sa/casperfpga/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ska-sa/casperfpga/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ska-sa/casperfpga/git/refs{/sha}","trees_url":"https://api.github.com/repos/ska-sa/casperfpga/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ska-sa/casperfpga/statuses/{sha}","languages_url":"https://api.github.com/repos/ska-sa/casperfpga/languages","stargazers_url":"https://api.github.com/repos/ska-sa/casperfpga/stargazers","contributors_url":"https://api.github.com/repos/ska-sa/casperfpga/contributors","subscribers_url":"https://api.github.com/repos/ska-sa/casperfpga/subscribers","subscription_url":"https://api.github.com/repos/ska-sa/casperfpga/subscription","commits_url":"https://api.github.com/repos/ska-sa/casperfpga/commits{/sha}","git_commits_url":"https://api.github.com/repos/ska-sa/casperfpga/git/commits{/sha}","comments_url":"https://api.github.com/repos/ska-sa/casperfpga/comments{/number}","issue_comment_url":"https://api.github.com/repos/ska-sa/casperfpga/issues/comments{/number}","contents_url":"https://api.github.com/repos/ska-sa/casperfpga/contents/{+path}","compare_url":"https://api.github.com/repos/ska-sa/casperfpga/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ska-sa/casperfpga/merges","archive_url":"https://api.github.com/repos/ska-sa/casperfpga/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ska-sa/casperfpga/downloads","issues_url":"https://api.github.com/repos/ska-sa/casperfpga/issues{/number}","pulls_url":"https://api.github.com/repos/ska-sa/casperfpga/pulls{/number}","milestones_url":"https://api.github.com/repos/ska-sa/casperfpga/milestones{/number}","notifications_url":"https://api.github.com/repos/ska-sa/casperfpga/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ska-sa/casperfpga/labels{/name}","releases_url":"https://api.github.com/repos/ska-sa/casperfpga/releases{/id}","deployments_url":"https://api.github.com/repos/ska-sa/casperfpga/deployments","created_at":"2014-06-12T17:34:39Z","updated_at":"2016-01-20T06:42:13Z","pushed_at":"2017-04-10T11:57:41Z","git_url":"git://github.com/ska-sa/casperfpga.git","ssh_url":"git@github.com:ska-sa/casperfpga.git","clone_url":"https://github.com/ska-sa/casperfpga.git","svn_url":"https://github.com/ska-sa/casperfpga","homepage":null,"size":637,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ska-sa/casperfpga/pulls/59"},"html":{"href":"https://github.com/ska-sa/casperfpga/pull/59"},"issue":{"href":"https://api.github.com/repos/ska-sa/casperfpga/issues/59"},"comments":{"href":"https://api.github.com/repos/ska-sa/casperfpga/issues/59/comments"},"review_comments":{"href":"https://api.github.com/repos/ska-sa/casperfpga/pulls/59/comments"},"review_comment":{"href":"https://api.github.com/repos/ska-sa/casperfpga/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ska-sa/casperfpga/pulls/59/commits"},"statuses":{"href":"https://api.github.com/repos/ska-sa/casperfpga/statuses/b5b821f0e17ddfa3772499b4d196868b3c9b016d"}}}}
{"actor":{"display_login":"paulprozesky"}}