{"action":"created","comment":{"url":"https://api.github.com/repos/facebookresearch/ParlAI/pulls/comments/154205115","pull_request_review_id":80333263,"id":154205115,"diff_hunk":"@@ -242,6 +239,13 @@ def num_episodes(self):\n         except Exception:\n             raise RuntimeError('\"num_episodes\" must be overriden by children.')\n \n+    def num_examples(self):","path":"parlai/core/teachers.py","position":14,"original_position":14,"commit_id":"dda1423848c4b29efc4212e98aeb8aa51a11818f","original_commit_id":"dda1423848c4b29efc4212e98aeb8aa51a11818f","user":{"login":"klshuster","id":8562788,"avatar_url":"https://avatars3.githubusercontent.com/u/8562788?v=4","gravatar_id":"","url":"https://api.github.com/users/klshuster","html_url":"https://github.com/klshuster","followers_url":"https://api.github.com/users/klshuster/followers","following_url":"https://api.github.com/users/klshuster/following{/other_user}","gists_url":"https://api.github.com/users/klshuster/gists{/gist_id}","starred_url":"https://api.github.com/users/klshuster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klshuster/subscriptions","organizations_url":"https://api.github.com/users/klshuster/orgs","repos_url":"https://api.github.com/users/klshuster/repos","events_url":"https://api.github.com/users/klshuster/events{/privacy}","received_events_url":"https://api.github.com/users/klshuster/received_events","type":"User","site_admin":false},"body":"Currently, any subclass of `FixedDialogTeacher` that does not have `self.episodes` and `self.examples`, and does not override `num_episodes` or `num_examples`, will get a runtime error. However, `DialogTeacher` has these functions implemented, and all of the teachers that subclass `FixedDialogTeacher` (in this repo) have these functions implemented as well","created_at":"2017-11-30T21:22:57Z","updated_at":"2017-11-30T21:24:26Z","html_url":"https://github.com/facebookresearch/ParlAI/pull/422#discussion_r154205115","pull_request_url":"https://api.github.com/repos/facebookresearch/ParlAI/pulls/422","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/facebookresearch/ParlAI/pulls/comments/154205115"},"html":{"href":"https://github.com/facebookresearch/ParlAI/pull/422#discussion_r154205115"},"pull_request":{"href":"https://api.github.com/repos/facebookresearch/ParlAI/pulls/422"}},"in_reply_to_id":154201316},"pull_request":{"url":"https://api.github.com/repos/facebookresearch/ParlAI/pulls/422","id":155716692,"html_url":"https://github.com/facebookresearch/ParlAI/pull/422","diff_url":"https://github.com/facebookresearch/ParlAI/pull/422.diff","patch_url":"https://github.com/facebookresearch/ParlAI/pull/422.patch","issue_url":"https://api.github.com/repos/facebookresearch/ParlAI/issues/422","number":422,"state":"open","locked":false,"title":"Remove world iters, get rid of len, etc.","user":{"login":"klshuster","id":8562788,"avatar_url":"https://avatars3.githubusercontent.com/u/8562788?v=4","gravatar_id":"","url":"https://api.github.com/users/klshuster","html_url":"https://github.com/klshuster","followers_url":"https://api.github.com/users/klshuster/followers","following_url":"https://api.github.com/users/klshuster/following{/other_user}","gists_url":"https://api.github.com/users/klshuster/gists{/gist_id}","starred_url":"https://api.github.com/users/klshuster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klshuster/subscriptions","organizations_url":"https://api.github.com/users/klshuster/orgs","repos_url":"https://api.github.com/users/klshuster/repos","events_url":"https://api.github.com/users/klshuster/events{/privacy}","received_events_url":"https://api.github.com/users/klshuster/received_events","type":"User","site_admin":false},"body":"This PR includes the following:\r\n\r\n- remove `__iter__`, `__next__`, and `__len__` from worlds and agents\r\n- adds `num_examples` and `num_episodes` to all worlds, as well as agents in `teachers.py`\r\n- converts vqa_v2 teacher to a `FixedDialogTeacher`\r\n- misc changes to other agents to deal with removing `__len__`","created_at":"2017-11-30T20:55:18Z","updated_at":"2017-11-30T21:24:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"01ffb8732a0a9d851f24081ec54873cb9c9cc61a","assignee":null,"assignees":[],"requested_reviewers":[{"login":"alexholdenmiller","id":1141354,"avatar_url":"https://avatars1.githubusercontent.com/u/1141354?v=4","gravatar_id":"","url":"https://api.github.com/users/alexholdenmiller","html_url":"https://github.com/alexholdenmiller","followers_url":"https://api.github.com/users/alexholdenmiller/followers","following_url":"https://api.github.com/users/alexholdenmiller/following{/other_user}","gists_url":"https://api.github.com/users/alexholdenmiller/gists{/gist_id}","starred_url":"https://api.github.com/users/alexholdenmiller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexholdenmiller/subscriptions","organizations_url":"https://api.github.com/users/alexholdenmiller/orgs","repos_url":"https://api.github.com/users/alexholdenmiller/repos","events_url":"https://api.github.com/users/alexholdenmiller/events{/privacy}","received_events_url":"https://api.github.com/users/alexholdenmiller/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/facebookresearch/ParlAI/pulls/422/commits","review_comments_url":"https://api.github.com/repos/facebookresearch/ParlAI/pulls/422/comments","review_comment_url":"https://api.github.com/repos/facebookresearch/ParlAI/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebookresearch/ParlAI/issues/422/comments","statuses_url":"https://api.github.com/repos/facebookresearch/ParlAI/statuses/dda1423848c4b29efc4212e98aeb8aa51a11818f","head":{"label":"klshuster:remove_world_iters","ref":"remove_world_iters","sha":"dda1423848c4b29efc4212e98aeb8aa51a11818f","user":{"login":"klshuster","id":8562788,"avatar_url":"https://avatars3.githubusercontent.com/u/8562788?v=4","gravatar_id":"","url":"https://api.github.com/users/klshuster","html_url":"https://github.com/klshuster","followers_url":"https://api.github.com/users/klshuster/followers","following_url":"https://api.github.com/users/klshuster/following{/other_user}","gists_url":"https://api.github.com/users/klshuster/gists{/gist_id}","starred_url":"https://api.github.com/users/klshuster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klshuster/subscriptions","organizations_url":"https://api.github.com/users/klshuster/orgs","repos_url":"https://api.github.com/users/klshuster/repos","events_url":"https://api.github.com/users/klshuster/events{/privacy}","received_events_url":"https://api.github.com/users/klshuster/received_events","type":"User","site_admin":false},"repo":{"id":104381545,"name":"ParlAI","full_name":"klshuster/ParlAI","owner":{"login":"klshuster","id":8562788,"avatar_url":"https://avatars3.githubusercontent.com/u/8562788?v=4","gravatar_id":"","url":"https://api.github.com/users/klshuster","html_url":"https://github.com/klshuster","followers_url":"https://api.github.com/users/klshuster/followers","following_url":"https://api.github.com/users/klshuster/following{/other_user}","gists_url":"https://api.github.com/users/klshuster/gists{/gist_id}","starred_url":"https://api.github.com/users/klshuster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klshuster/subscriptions","organizations_url":"https://api.github.com/users/klshuster/orgs","repos_url":"https://api.github.com/users/klshuster/repos","events_url":"https://api.github.com/users/klshuster/events{/privacy}","received_events_url":"https://api.github.com/users/klshuster/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/klshuster/ParlAI","description":"A framework for training and evaluating AI models on a variety of openly available dialog datasets.","fork":true,"url":"https://api.github.com/repos/klshuster/ParlAI","forks_url":"https://api.github.com/repos/klshuster/ParlAI/forks","keys_url":"https://api.github.com/repos/klshuster/ParlAI/keys{/key_id}","collaborators_url":"https://api.github.com/repos/klshuster/ParlAI/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/klshuster/ParlAI/teams","hooks_url":"https://api.github.com/repos/klshuster/ParlAI/hooks","issue_events_url":"https://api.github.com/repos/klshuster/ParlAI/issues/events{/number}","events_url":"https://api.github.com/repos/klshuster/ParlAI/events","assignees_url":"https://api.github.com/repos/klshuster/ParlAI/assignees{/user}","branches_url":"https://api.github.com/repos/klshuster/ParlAI/branches{/branch}","tags_url":"https://api.github.com/repos/klshuster/ParlAI/tags","blobs_url":"https://api.github.com/repos/klshuster/ParlAI/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/klshuster/ParlAI/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/klshuster/ParlAI/git/refs{/sha}","trees_url":"https://api.github.com/repos/klshuster/ParlAI/git/trees{/sha}","statuses_url":"https://api.github.com/repos/klshuster/ParlAI/statuses/{sha}","languages_url":"https://api.github.com/repos/klshuster/ParlAI/languages","stargazers_url":"https://api.github.com/repos/klshuster/ParlAI/stargazers","contributors_url":"https://api.github.com/repos/klshuster/ParlAI/contributors","subscribers_url":"https://api.github.com/repos/klshuster/ParlAI/subscribers","subscription_url":"https://api.github.com/repos/klshuster/ParlAI/subscription","commits_url":"https://api.github.com/repos/klshuster/ParlAI/commits{/sha}","git_commits_url":"https://api.github.com/repos/klshuster/ParlAI/git/commits{/sha}","comments_url":"https://api.github.com/repos/klshuster/ParlAI/comments{/number}","issue_comment_url":"https://api.github.com/repos/klshuster/ParlAI/issues/comments{/number}","contents_url":"https://api.github.com/repos/klshuster/ParlAI/contents/{+path}","compare_url":"https://api.github.com/repos/klshuster/ParlAI/compare/{base}...{head}","merges_url":"https://api.github.com/repos/klshuster/ParlAI/merges","archive_url":"https://api.github.com/repos/klshuster/ParlAI/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/klshuster/ParlAI/downloads","issues_url":"https://api.github.com/repos/klshuster/ParlAI/issues{/number}","pulls_url":"https://api.github.com/repos/klshuster/ParlAI/pulls{/number}","milestones_url":"https://api.github.com/repos/klshuster/ParlAI/milestones{/number}","notifications_url":"https://api.github.com/repos/klshuster/ParlAI/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/klshuster/ParlAI/labels{/name}","releases_url":"https://api.github.com/repos/klshuster/ParlAI/releases{/id}","deployments_url":"https://api.github.com/repos/klshuster/ParlAI/deployments","created_at":"2017-09-21T18:03:42Z","updated_at":"2017-09-21T18:03:44Z","pushed_at":"2017-11-30T20:38:57Z","git_url":"git://github.com/klshuster/ParlAI.git","ssh_url":"git@github.com:klshuster/ParlAI.git","clone_url":"https://github.com/klshuster/ParlAI.git","svn_url":"https://github.com/klshuster/ParlAI","homepage":"parl.ai","size":5953,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebookresearch:master","ref":"master","sha":"ed306b4f9095d77da8da4195fa1bc0fcefc437c7","user":{"login":"facebookresearch","id":16943930,"avatar_url":"https://avatars0.githubusercontent.com/u/16943930?v=4","gravatar_id":"","url":"https://api.github.com/users/facebookresearch","html_url":"https://github.com/facebookresearch","followers_url":"https://api.github.com/users/facebookresearch/followers","following_url":"https://api.github.com/users/facebookresearch/following{/other_user}","gists_url":"https://api.github.com/users/facebookresearch/gists{/gist_id}","starred_url":"https://api.github.com/users/facebookresearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebookresearch/subscriptions","organizations_url":"https://api.github.com/users/facebookresearch/orgs","repos_url":"https://api.github.com/users/facebookresearch/repos","events_url":"https://api.github.com/users/facebookresearch/events{/privacy}","received_events_url":"https://api.github.com/users/facebookresearch/received_events","type":"Organization","site_admin":false},"repo":{"id":89266735,"name":"ParlAI","full_name":"facebookresearch/ParlAI","owner":{"login":"facebookresearch","id":16943930,"avatar_url":"https://avatars0.githubusercontent.com/u/16943930?v=4","gravatar_id":"","url":"https://api.github.com/users/facebookresearch","html_url":"https://github.com/facebookresearch","followers_url":"https://api.github.com/users/facebookresearch/followers","following_url":"https://api.github.com/users/facebookresearch/following{/other_user}","gists_url":"https://api.github.com/users/facebookresearch/gists{/gist_id}","starred_url":"https://api.github.com/users/facebookresearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebookresearch/subscriptions","organizations_url":"https://api.github.com/users/facebookresearch/orgs","repos_url":"https://api.github.com/users/facebookresearch/repos","events_url":"https://api.github.com/users/facebookresearch/events{/privacy}","received_events_url":"https://api.github.com/users/facebookresearch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebookresearch/ParlAI","description":"A framework for training and evaluating AI models on a variety of openly available dialog datasets.","fork":false,"url":"https://api.github.com/repos/facebookresearch/ParlAI","forks_url":"https://api.github.com/repos/facebookresearch/ParlAI/forks","keys_url":"https://api.github.com/repos/facebookresearch/ParlAI/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebookresearch/ParlAI/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebookresearch/ParlAI/teams","hooks_url":"https://api.github.com/repos/facebookresearch/ParlAI/hooks","issue_events_url":"https://api.github.com/repos/facebookresearch/ParlAI/issues/events{/number}","events_url":"https://api.github.com/repos/facebookresearch/ParlAI/events","assignees_url":"https://api.github.com/repos/facebookresearch/ParlAI/assignees{/user}","branches_url":"https://api.github.com/repos/facebookresearch/ParlAI/branches{/branch}","tags_url":"https://api.github.com/repos/facebookresearch/ParlAI/tags","blobs_url":"https://api.github.com/repos/facebookresearch/ParlAI/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebookresearch/ParlAI/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebookresearch/ParlAI/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebookresearch/ParlAI/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebookresearch/ParlAI/statuses/{sha}","languages_url":"https://api.github.com/repos/facebookresearch/ParlAI/languages","stargazers_url":"https://api.github.com/repos/facebookresearch/ParlAI/stargazers","contributors_url":"https://api.github.com/repos/facebookresearch/ParlAI/contributors","subscribers_url":"https://api.github.com/repos/facebookresearch/ParlAI/subscribers","subscription_url":"https://api.github.com/repos/facebookresearch/ParlAI/subscription","commits_url":"https://api.github.com/repos/facebookresearch/ParlAI/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebookresearch/ParlAI/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebookresearch/ParlAI/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebookresearch/ParlAI/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebookresearch/ParlAI/contents/{+path}","compare_url":"https://api.github.com/repos/facebookresearch/ParlAI/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebookresearch/ParlAI/merges","archive_url":"https://api.github.com/repos/facebookresearch/ParlAI/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebookresearch/ParlAI/downloads","issues_url":"https://api.github.com/repos/facebookresearch/ParlAI/issues{/number}","pulls_url":"https://api.github.com/repos/facebookresearch/ParlAI/pulls{/number}","milestones_url":"https://api.github.com/repos/facebookresearch/ParlAI/milestones{/number}","notifications_url":"https://api.github.com/repos/facebookresearch/ParlAI/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebookresearch/ParlAI/labels{/name}","releases_url":"https://api.github.com/repos/facebookresearch/ParlAI/releases{/id}","deployments_url":"https://api.github.com/repos/facebookresearch/ParlAI/deployments","created_at":"2017-04-24T17:10:44Z","updated_at":"2017-11-30T20:28:31Z","pushed_at":"2017-11-30T20:55:19Z","git_url":"git://github.com/facebookresearch/ParlAI.git","ssh_url":"git@github.com:facebookresearch/ParlAI.git","clone_url":"https://github.com/facebookresearch/ParlAI.git","svn_url":"https://github.com/facebookresearch/ParlAI","homepage":"parl.ai","size":5990,"stargazers_count":2456,"watchers_count":2456,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":383,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"bsd-3-clause","name":"BSD 3-clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":383,"open_issues":14,"watchers":2456,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebookresearch/ParlAI/pulls/422"},"html":{"href":"https://github.com/facebookresearch/ParlAI/pull/422"},"issue":{"href":"https://api.github.com/repos/facebookresearch/ParlAI/issues/422"},"comments":{"href":"https://api.github.com/repos/facebookresearch/ParlAI/issues/422/comments"},"review_comments":{"href":"https://api.github.com/repos/facebookresearch/ParlAI/pulls/422/comments"},"review_comment":{"href":"https://api.github.com/repos/facebookresearch/ParlAI/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebookresearch/ParlAI/pulls/422/commits"},"statuses":{"href":"https://api.github.com/repos/facebookresearch/ParlAI/statuses/dda1423848c4b29efc4212e98aeb8aa51a11818f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"klshuster"}}