{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/corefx/issues/18743","repository_url":"https://api.github.com/repos/dotnet/corefx","labels_url":"https://api.github.com/repos/dotnet/corefx/issues/18743/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/18743/comments","events_url":"https://api.github.com/repos/dotnet/corefx/issues/18743/events","html_url":"https://github.com/dotnet/corefx/pull/18743","id":223450045,"number":18743,"title":"Add netfx configuration to XmlSerialization tests","user":{"login":"safern","id":22899328,"avatar_url":"https://avatars2.githubusercontent.com/u/22899328?v=3","gravatar_id":"","url":"https://api.github.com/users/safern","html_url":"https://github.com/safern","followers_url":"https://api.github.com/users/safern/followers","following_url":"https://api.github.com/users/safern/following{/other_user}","gists_url":"https://api.github.com/users/safern/gists{/gist_id}","starred_url":"https://api.github.com/users/safern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/safern/subscriptions","organizations_url":"https://api.github.com/users/safern/orgs","repos_url":"https://api.github.com/users/safern/repos","events_url":"https://api.github.com/users/safern/events{/privacy}","received_events_url":"https://api.github.com/users/safern/received_events","type":"User","site_admin":false},"labels":[{"id":192063576,"url":"https://api.github.com/repos/dotnet/corefx/labels/area-Serialization","name":"area-Serialization","color":"d4c5f9","default":false},{"id":197706871,"url":"https://api.github.com/repos/dotnet/corefx/labels/cla-already-signed","name":"cla-already-signed","color":"009800","default":false},{"id":469563451,"url":"https://api.github.com/repos/dotnet/corefx/labels/test-run-desktop","name":"test-run-desktop","color":"b60205","default":false}],"state":"open","locked":false,"assignee":{"login":"safern","id":22899328,"avatar_url":"https://avatars2.githubusercontent.com/u/22899328?v=3","gravatar_id":"","url":"https://api.github.com/users/safern","html_url":"https://github.com/safern","followers_url":"https://api.github.com/users/safern/followers","following_url":"https://api.github.com/users/safern/following{/other_user}","gists_url":"https://api.github.com/users/safern/gists{/gist_id}","starred_url":"https://api.github.com/users/safern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/safern/subscriptions","organizations_url":"https://api.github.com/users/safern/orgs","repos_url":"https://api.github.com/users/safern/repos","events_url":"https://api.github.com/users/safern/events{/privacy}","received_events_url":"https://api.github.com/users/safern/received_events","type":"User","site_admin":false},"assignees":[{"login":"safern","id":22899328,"avatar_url":"https://avatars2.githubusercontent.com/u/22899328?v=3","gravatar_id":"","url":"https://api.github.com/users/safern","html_url":"https://github.com/safern","followers_url":"https://api.github.com/users/safern/followers","following_url":"https://api.github.com/users/safern/following{/other_user}","gists_url":"https://api.github.com/users/safern/gists{/gist_id}","starred_url":"https://api.github.com/users/safern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/safern/subscriptions","organizations_url":"https://api.github.com/users/safern/orgs","repos_url":"https://api.github.com/users/safern/repos","events_url":"https://api.github.com/users/safern/events{/privacy}","received_events_url":"https://api.github.com/users/safern/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/dotnet/corefx/milestones/4","html_url":"https://github.com/dotnet/corefx/milestone/4","labels_url":"https://api.github.com/repos/dotnet/corefx/milestones/4/labels","id":1248719,"number":4,"title":"2.0.0","description":".NET Core 2.0, next major release. The due date 5/10 is [ZBB](https://github.com/dotnet/corefx/issues/17619) and expected time of last FI from master into release branch. See [official release dates](https://github.com/dotnet/core/blob/master/roadmap.md) for details.","creator":{"login":"joshfree","id":1302850,"avatar_url":"https://avatars2.githubusercontent.com/u/1302850?v=3","gravatar_id":"","url":"https://api.github.com/users/joshfree","html_url":"https://github.com/joshfree","followers_url":"https://api.github.com/users/joshfree/followers","following_url":"https://api.github.com/users/joshfree/following{/other_user}","gists_url":"https://api.github.com/users/joshfree/gists{/gist_id}","starred_url":"https://api.github.com/users/joshfree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshfree/subscriptions","organizations_url":"https://api.github.com/users/joshfree/orgs","repos_url":"https://api.github.com/users/joshfree/repos","events_url":"https://api.github.com/users/joshfree/events{/privacy}","received_events_url":"https://api.github.com/users/joshfree/received_events","type":"User","site_admin":false},"open_issues":190,"closed_issues":7003,"state":"open","created_at":"2015-08-10T18:04:00Z","updated_at":"2017-04-21T18:04:21Z","due_on":"2017-05-10T07:00:00Z","closed_at":null},"comments":11,"created_at":"2017-04-21T17:39:48Z","updated_at":"2017-04-21T18:57:22Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/18743","html_url":"https://github.com/dotnet/corefx/pull/18743","diff_url":"https://github.com/dotnet/corefx/pull/18743.diff","patch_url":"https://github.com/dotnet/corefx/pull/18743.patch"},"body":"System.Runtime.Serialization.Xml src and ref contracts are built against netfx not netstandard so the test need to be built against netfx as well to find its correct dependencies in runtime. Now since we are building them against netstandard and run them on netfx it will not find System dependencies as it doesn't have a reference to netstandard. So we should build them against netfx so that it loads it dependencies from mscorlib as it is the ones included from src and ref. \r\n\r\nFixes: https://github.com/dotnet/corefx/issues/18660\r\n\r\ncc: @weshaggard @danmosemsft "},"comment":{"url":"https://api.github.com/repos/dotnet/corefx/issues/comments/296277091","html_url":"https://github.com/dotnet/corefx/pull/18743#issuecomment-296277091","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/18743","id":296277091,"user":{"login":"weshaggard","id":9010698,"avatar_url":"https://avatars1.githubusercontent.com/u/9010698?v=3","gravatar_id":"","url":"https://api.github.com/users/weshaggard","html_url":"https://github.com/weshaggard","followers_url":"https://api.github.com/users/weshaggard/followers","following_url":"https://api.github.com/users/weshaggard/following{/other_user}","gists_url":"https://api.github.com/users/weshaggard/gists{/gist_id}","starred_url":"https://api.github.com/users/weshaggard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weshaggard/subscriptions","organizations_url":"https://api.github.com/users/weshaggard/orgs","repos_url":"https://api.github.com/users/weshaggard/repos","events_url":"https://api.github.com/users/weshaggard/events{/privacy}","received_events_url":"https://api.github.com/users/weshaggard/received_events","type":"User","site_admin":false},"created_at":"2017-04-21T18:57:22Z","updated_at":"2017-04-21T18:57:22Z","body":">@weshaggard We recently enabled XmlSerializer to support soap encoded messages using reflection. The failing tests are all soap encoded serialization related. On Desktop, XmlSerializer uses CodeGen to support soap encoded serialization. I think that's the reason the tests are failing on Desktop.\r\n\r\nIf that is the case then we should consider partitioning those tests in someway as opposed to moving everything to a netfx configuration. We eventually plan to run all netstandard configurations on all platforms as well, even if there is a platform specific configuration, so in those runs these tests will still fail. Therefore we need to correctly partition them."}}
{"actor":{"display_login":"weshaggard"}}