{"action":"created","issue":{"url":"https://api.github.com/repos/jhipster/generator-jhipster/issues/5718","repository_url":"https://api.github.com/repos/jhipster/generator-jhipster","labels_url":"https://api.github.com/repos/jhipster/generator-jhipster/issues/5718/labels{/name}","comments_url":"https://api.github.com/repos/jhipster/generator-jhipster/issues/5718/comments","events_url":"https://api.github.com/repos/jhipster/generator-jhipster/issues/5718/events","html_url":"https://github.com/jhipster/generator-jhipster/issues/5718","id":226581469,"number":5718,"title":"Rename \"javascript\" into \"typescript\" for test folder","user":{"login":"wmarques","id":1577727,"avatar_url":"https://avatars1.githubusercontent.com/u/1577727?v=3","gravatar_id":"","url":"https://api.github.com/users/wmarques","html_url":"https://github.com/wmarques","followers_url":"https://api.github.com/users/wmarques/followers","following_url":"https://api.github.com/users/wmarques/following{/other_user}","gists_url":"https://api.github.com/users/wmarques/gists{/gist_id}","starred_url":"https://api.github.com/users/wmarques/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmarques/subscriptions","organizations_url":"https://api.github.com/users/wmarques/orgs","repos_url":"https://api.github.com/users/wmarques/repos","events_url":"https://api.github.com/users/wmarques/events{/privacy}","received_events_url":"https://api.github.com/users/wmarques/received_events","type":"User","site_admin":false},"labels":[{"id":528053281,"url":"https://api.github.com/repos/jhipster/generator-jhipster/labels/angular-4","name":"angular-4","color":"b60205","default":false},{"id":61979573,"url":"https://api.github.com/repos/jhipster/generator-jhipster/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-05-05T13:57:07Z","updated_at":"2017-05-17T17:00:36Z","closed_at":null,"body":"##### **Overview of the issue**\r\n\r\nThe folder containing front end tests should be named typescript when we use Angular, and javascript when we use AngularJS\r\n\r\n##### **Motivation for or Use Case**\r\n\r\nIt can be confusing to see \"javascript\" in a typescript app 😄 \r\n\r\n##### **Reproduce the error**\r\n\r\nGenerate an app and choose Angular 4\r\n\r\n##### **JHipster Version(s)**\r\n\r\nmaster\r\n\r\n- [x] Checking this box is mandatory (this is just to show you read everything)\r\n"},"comment":{"url":"https://api.github.com/repos/jhipster/generator-jhipster/issues/comments/302154359","html_url":"https://github.com/jhipster/generator-jhipster/issues/5718#issuecomment-302154359","issue_url":"https://api.github.com/repos/jhipster/generator-jhipster/issues/5718","id":302154359,"user":{"login":"pascalgrimaud","id":9156882,"avatar_url":"https://avatars1.githubusercontent.com/u/9156882?v=3","gravatar_id":"","url":"https://api.github.com/users/pascalgrimaud","html_url":"https://github.com/pascalgrimaud","followers_url":"https://api.github.com/users/pascalgrimaud/followers","following_url":"https://api.github.com/users/pascalgrimaud/following{/other_user}","gists_url":"https://api.github.com/users/pascalgrimaud/gists{/gist_id}","starred_url":"https://api.github.com/users/pascalgrimaud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pascalgrimaud/subscriptions","organizations_url":"https://api.github.com/users/pascalgrimaud/orgs","repos_url":"https://api.github.com/users/pascalgrimaud/repos","events_url":"https://api.github.com/users/pascalgrimaud/events{/privacy}","received_events_url":"https://api.github.com/users/pascalgrimaud/received_events","type":"User","site_admin":false},"created_at":"2017-05-17T17:00:36Z","updated_at":"2017-05-17T17:00:36Z","body":"Just look for this change:\r\n- it will impact a lot of files (package.json, tsconfig.json, README.md, .angular-cli.json, .gitignore)\r\n- then, in our generator, we use this constant [CLIENT_TEST_SRC_DIR](https://github.com/jhipster/generator-jhipster/blob/master/generators/generator-constants.js#L76), so we need to add another one specific for Angular2, which impact again a lot of files\r\n\r\nSo, it makes sense but I change my mind as there is no real value to do this and it's a lot of work.\r\nWhat do you think @wmarques ? Maybe do this later ?"}}
{"actor":{"display_login":"pascalgrimaud"}}