{"action":"created","issue":{"url":"https://api.github.com/repos/LateStartStudio/Hero6/issues/125","repository_url":"https://api.github.com/repos/LateStartStudio/Hero6","labels_url":"https://api.github.com/repos/LateStartStudio/Hero6/issues/125/labels{/name}","comments_url":"https://api.github.com/repos/LateStartStudio/Hero6/issues/125/comments","events_url":"https://api.github.com/repos/LateStartStudio/Hero6/issues/125/events","html_url":"https://github.com/LateStartStudio/Hero6/pull/125","id":213502364,"number":125,"title":"Upgrade StyleCop [WORK IN PROGRESS - DO NOT MERGE]","user":{"login":"persn","id":1510803,"avatar_url":"https://avatars0.githubusercontent.com/u/1510803?v=3","gravatar_id":"","url":"https://api.github.com/users/persn","html_url":"https://github.com/persn","followers_url":"https://api.github.com/users/persn/followers","following_url":"https://api.github.com/users/persn/following{/other_user}","gists_url":"https://api.github.com/users/persn/gists{/gist_id}","starred_url":"https://api.github.com/users/persn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/persn/subscriptions","organizations_url":"https://api.github.com/users/persn/orgs","repos_url":"https://api.github.com/users/persn/repos","events_url":"https://api.github.com/users/persn/events{/privacy}","received_events_url":"https://api.github.com/users/persn/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2017-03-11T03:38:05Z","updated_at":"2017-03-12T19:10:12Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/LateStartStudio/Hero6/pulls/125","html_url":"https://github.com/LateStartStudio/Hero6/pull/125","diff_url":"https://github.com/LateStartStudio/Hero6/pull/125.diff","patch_url":"https://github.com/LateStartStudio/Hero6/pull/125.patch"},"body":"The following PR demonstrates how to integrate DotNetAnalyzers/StyleCopAnalyzers into Hero6. #109 I removed the old obsolete StyleCop files, added new ones, I made a minor work-around but I'd rather not discuss until we've discussed everything else in this PR, as the work-around may become obsolete if EmptyKeys gets a patch.\r\n\r\nMost of the commits in this PR are fixing code style stuff, as new StyleCop is new and improved and all that it uncovers loads of stuff the old StyleCop was unable to. I've organized the commits so that I resolve each code style issue in each commits, so we can use this opportunity to decide our stance on some rules, and how we should weight them to our preferences as by #121.\r\n\r\nTODO:\r\n- [x] Discuss SA1101\r\n- [x] Discuss SA1028\r\n- [x] Discuss SA1116\r\n- [x] Discuss SA1118\r\n- [x] Discuss SA1127\r\n- [x] Discuss SA1128\r\n- [x] Discuss SA1600\r\n- [x] Discuss SA1642\r\n- [x] Discuss SA1636, SA1638, SA1641\r\n- [x] Update PR according to discussions of rules"},"comment":{"url":"https://api.github.com/repos/LateStartStudio/Hero6/issues/comments/285967094","html_url":"https://github.com/LateStartStudio/Hero6/pull/125#issuecomment-285967094","issue_url":"https://api.github.com/repos/LateStartStudio/Hero6/issues/125","id":285967094,"user":{"login":"persn","id":1510803,"avatar_url":"https://avatars0.githubusercontent.com/u/1510803?v=3","gravatar_id":"","url":"https://api.github.com/users/persn","html_url":"https://github.com/persn","followers_url":"https://api.github.com/users/persn/followers","following_url":"https://api.github.com/users/persn/following{/other_user}","gists_url":"https://api.github.com/users/persn/gists{/gist_id}","starred_url":"https://api.github.com/users/persn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/persn/subscriptions","organizations_url":"https://api.github.com/users/persn/orgs","repos_url":"https://api.github.com/users/persn/repos","events_url":"https://api.github.com/users/persn/events{/privacy}","received_events_url":"https://api.github.com/users/persn/received_events","type":"User","site_admin":false},"created_at":"2017-03-12T19:10:12Z","updated_at":"2017-03-12T19:10:12Z","body":"I somehow linked to the wrong commit, I mean this one d14ed77ea0fca21226676e267355e2cda860206b. RootView.xaml.cs is auto-generated by EmptyKeys from the file RootView.xaml, the tag you see in the commit is how StyleCop ignores auto-generated files, however that does us no good since the tag disappears into the ether every time the EmptyKeys generator is triggered."}}
{"actor":{"display_login":"persn"}}