{"action":"created","issue":{"url":"https://api.github.com/repos/typesupply/defcon/issues/110","repository_url":"https://api.github.com/repos/typesupply/defcon","labels_url":"https://api.github.com/repos/typesupply/defcon/issues/110/labels{/name}","comments_url":"https://api.github.com/repos/typesupply/defcon/issues/110/comments","events_url":"https://api.github.com/repos/typesupply/defcon/issues/110/events","html_url":"https://github.com/typesupply/defcon/pull/110","id":215188460,"number":110,"title":"Font: make rename an atomic glyphOrder op","user":{"login":"adrientetar","id":1250894,"avatar_url":"https://avatars1.githubusercontent.com/u/1250894?v=3","gravatar_id":"","url":"https://api.github.com/users/adrientetar","html_url":"https://github.com/adrientetar","followers_url":"https://api.github.com/users/adrientetar/followers","following_url":"https://api.github.com/users/adrientetar/following{/other_user}","gists_url":"https://api.github.com/users/adrientetar/gists{/gist_id}","starred_url":"https://api.github.com/users/adrientetar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrientetar/subscriptions","organizations_url":"https://api.github.com/users/adrientetar/orgs","repos_url":"https://api.github.com/users/adrientetar/repos","events_url":"https://api.github.com/users/adrientetar/events{/privacy}","received_events_url":"https://api.github.com/users/adrientetar/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-03-18T11:53:56Z","updated_at":"2017-03-18T12:21:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/typesupply/defcon/pulls/110","html_url":"https://github.com/typesupply/defcon/pull/110","diff_url":"https://github.com/typesupply/defcon/pull/110.diff","patch_url":"https://github.com/typesupply/defcon/pull/110.patch"},"body":"Previously when a glyph was renamed, defcon would first remove the old name from the glyphOrder then append the new one. This makes rename a single operation so that **a renamed glyph keeps the same position in the glyphOrder.**\r\n\r\nNote: this drops the multiple removal passes from removed glyph name, as it's not necessary. The adding code checks that the glyph name isn't already in the glyph order.\r\n\r\nFixes trufont/trufont#314.\r\n\r\nr? @anthrotype "},"comment":{"url":"https://api.github.com/repos/typesupply/defcon/issues/comments/287541963","html_url":"https://github.com/typesupply/defcon/pull/110#issuecomment-287541963","issue_url":"https://api.github.com/repos/typesupply/defcon/issues/110","id":287541963,"user":{"login":"anthrotype","id":6939968,"avatar_url":"https://avatars0.githubusercontent.com/u/6939968?v=3","gravatar_id":"","url":"https://api.github.com/users/anthrotype","html_url":"https://github.com/anthrotype","followers_url":"https://api.github.com/users/anthrotype/followers","following_url":"https://api.github.com/users/anthrotype/following{/other_user}","gists_url":"https://api.github.com/users/anthrotype/gists{/gist_id}","starred_url":"https://api.github.com/users/anthrotype/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthrotype/subscriptions","organizations_url":"https://api.github.com/users/anthrotype/orgs","repos_url":"https://api.github.com/users/anthrotype/repos","events_url":"https://api.github.com/users/anthrotype/events{/privacy}","received_events_url":"https://api.github.com/users/anthrotype/received_events","type":"User","site_admin":false},"created_at":"2017-03-18T12:21:47Z","updated_at":"2017-03-18T12:21:47Z","body":"thanks. there are also specific unit tests for that `updateGlyphOrder` function. mind adding a case with both `addedGlyph` and `removedGlyph`?"}}
{"actor":{"display_login":"anthrotype"}}