{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/pulls/comments/134746082","pull_request_review_id":58072901,"id":134746082,"diff_hunk":"@@ -221,6 +221,7 @@ def delete_pod\n   end\n \n   def cleanup(*args)\n+    unqueue_all_signals","path":"app/models/manageiq/providers/kubernetes/container_manager/scanning/job.rb","position":4,"original_position":4,"commit_id":"6bf8ad2a024c430207085e481c8e7c87643ed613","original_commit_id":"6bf8ad2a024c430207085e481c8e7c87643ed613","user":{"login":"moolitayer","id":3010449,"avatar_url":"https://avatars1.githubusercontent.com/u/3010449?v=4","gravatar_id":"","url":"https://api.github.com/users/moolitayer","html_url":"https://github.com/moolitayer","followers_url":"https://api.github.com/users/moolitayer/followers","following_url":"https://api.github.com/users/moolitayer/following{/other_user}","gists_url":"https://api.github.com/users/moolitayer/gists{/gist_id}","starred_url":"https://api.github.com/users/moolitayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moolitayer/subscriptions","organizations_url":"https://api.github.com/users/moolitayer/orgs","repos_url":"https://api.github.com/users/moolitayer/repos","events_url":"https://api.github.com/users/moolitayer/events{/privacy}","received_events_url":"https://api.github.com/users/moolitayer/received_events","type":"User","site_admin":false},"body":"interesting, makes sense.\r\nThere should not be a race since in cancel you force the state to be `cancel` and a state change from `cancel` to `pod_wait` is not allowed - but now I see the bug you are fixing is the logging of an invalid state change so :+1: ","created_at":"2017-08-23T13:09:37Z","updated_at":"2017-08-23T13:09:37Z","html_url":"https://github.com/ManageIQ/manageiq-providers-kubernetes/pull/99#discussion_r134746082","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/pulls/99","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/pulls/comments/134746082"},"html":{"href":"https://github.com/ManageIQ/manageiq-providers-kubernetes/pull/99#discussion_r134746082"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/pulls/99"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/pulls/99","id":137142754,"html_url":"https://github.com/ManageIQ/manageiq-providers-kubernetes/pull/99","diff_url":"https://github.com/ManageIQ/manageiq-providers-kubernetes/pull/99.diff","patch_url":"https://github.com/ManageIQ/manageiq-providers-kubernetes/pull/99.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/issues/99","number":99,"state":"open","locked":false,"title":"Scanning::Job always cleanup all signals in cleanup","user":{"login":"enoodle","id":3123328,"avatar_url":"https://avatars2.githubusercontent.com/u/3123328?v=4","gravatar_id":"","url":"https://api.github.com/users/enoodle","html_url":"https://github.com/enoodle","followers_url":"https://api.github.com/users/enoodle/followers","following_url":"https://api.github.com/users/enoodle/following{/other_user}","gists_url":"https://api.github.com/users/enoodle/gists{/gist_id}","starred_url":"https://api.github.com/users/enoodle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enoodle/subscriptions","organizations_url":"https://api.github.com/users/enoodle/orgs","repos_url":"https://api.github.com/users/enoodle/repos","events_url":"https://api.github.com/users/enoodle/events{/privacy}","received_events_url":"https://api.github.com/users/enoodle/received_events","type":"User","site_admin":false},"body":"BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1481230","created_at":"2017-08-23T06:55:14Z","updated_at":"2017-08-23T13:09:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"027f64c66922797a782f711f0a200ca482c76414","assignee":null,"assignees":[],"requested_reviewers":[{"login":"cben","id":273688,"avatar_url":"https://avatars2.githubusercontent.com/u/273688?v=4","gravatar_id":"","url":"https://api.github.com/users/cben","html_url":"https://github.com/cben","followers_url":"https://api.github.com/users/cben/followers","following_url":"https://api.github.com/users/cben/following{/other_user}","gists_url":"https://api.github.com/users/cben/gists{/gist_id}","starred_url":"https://api.github.com/users/cben/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cben/subscriptions","organizations_url":"https://api.github.com/users/cben/orgs","repos_url":"https://api.github.com/users/cben/repos","events_url":"https://api.github.com/users/cben/events{/privacy}","received_events_url":"https://api.github.com/users/cben/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/pulls/99/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/pulls/99/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/issues/99/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/statuses/6bf8ad2a024c430207085e481c8e7c87643ed613","head":{"label":"enoodle:scanning_job_cleanup_unqueue_signals","ref":"scanning_job_cleanup_unqueue_signals","sha":"6bf8ad2a024c430207085e481c8e7c87643ed613","user":{"login":"enoodle","id":3123328,"avatar_url":"https://avatars2.githubusercontent.com/u/3123328?v=4","gravatar_id":"","url":"https://api.github.com/users/enoodle","html_url":"https://github.com/enoodle","followers_url":"https://api.github.com/users/enoodle/followers","following_url":"https://api.github.com/users/enoodle/following{/other_user}","gists_url":"https://api.github.com/users/enoodle/gists{/gist_id}","starred_url":"https://api.github.com/users/enoodle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enoodle/subscriptions","organizations_url":"https://api.github.com/users/enoodle/orgs","repos_url":"https://api.github.com/users/enoodle/repos","events_url":"https://api.github.com/users/enoodle/events{/privacy}","received_events_url":"https://api.github.com/users/enoodle/received_events","type":"User","site_admin":false},"repo":{"id":89223650,"name":"manageiq-providers-kubernetes","full_name":"enoodle/manageiq-providers-kubernetes","owner":{"login":"enoodle","id":3123328,"avatar_url":"https://avatars2.githubusercontent.com/u/3123328?v=4","gravatar_id":"","url":"https://api.github.com/users/enoodle","html_url":"https://github.com/enoodle","followers_url":"https://api.github.com/users/enoodle/followers","following_url":"https://api.github.com/users/enoodle/following{/other_user}","gists_url":"https://api.github.com/users/enoodle/gists{/gist_id}","starred_url":"https://api.github.com/users/enoodle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enoodle/subscriptions","organizations_url":"https://api.github.com/users/enoodle/orgs","repos_url":"https://api.github.com/users/enoodle/repos","events_url":"https://api.github.com/users/enoodle/events{/privacy}","received_events_url":"https://api.github.com/users/enoodle/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/enoodle/manageiq-providers-kubernetes","description":"ManageIQ plugin for the Kubernetes provider","fork":true,"url":"https://api.github.com/repos/enoodle/manageiq-providers-kubernetes","forks_url":"https://api.github.com/repos/enoodle/manageiq-providers-kubernetes/forks","keys_url":"https://api.github.com/repos/enoodle/manageiq-providers-kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/enoodle/manageiq-providers-kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/enoodle/manageiq-providers-kubernetes/teams","hooks_url":"https://api.github.com/repos/enoodle/manageiq-providers-kubernetes/hooks","issue_events_url":"https://api.github.com/repos/enoodle/manageiq-providers-kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/enoodle/manageiq-providers-kubernetes/events","assignees_url":"https://api.github.com/repos/enoodle/manageiq-providers-kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/enoodle/manageiq-providers-kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/enoodle/manageiq-providers-kubernetes/tags","blobs_url":"https://api.github.com/repos/enoodle/manageiq-providers-kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/enoodle/manageiq-providers-kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/enoodle/manageiq-providers-kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/enoodle/manageiq-providers-kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/enoodle/manageiq-providers-kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/enoodle/manageiq-providers-kubernetes/languages","stargazers_url":"https://api.github.com/repos/enoodle/manageiq-providers-kubernetes/stargazers","contributors_url":"https://api.github.com/repos/enoodle/manageiq-providers-kubernetes/contributors","subscribers_url":"https://api.github.com/repos/enoodle/manageiq-providers-kubernetes/subscribers","subscription_url":"https://api.github.com/repos/enoodle/manageiq-providers-kubernetes/subscription","commits_url":"https://api.github.com/repos/enoodle/manageiq-providers-kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/enoodle/manageiq-providers-kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/enoodle/manageiq-providers-kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/enoodle/manageiq-providers-kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/enoodle/manageiq-providers-kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/enoodle/manageiq-providers-kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/enoodle/manageiq-providers-kubernetes/merges","archive_url":"https://api.github.com/repos/enoodle/manageiq-providers-kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/enoodle/manageiq-providers-kubernetes/downloads","issues_url":"https://api.github.com/repos/enoodle/manageiq-providers-kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/enoodle/manageiq-providers-kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/enoodle/manageiq-providers-kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/enoodle/manageiq-providers-kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/enoodle/manageiq-providers-kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/enoodle/manageiq-providers-kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/enoodle/manageiq-providers-kubernetes/deployments","created_at":"2017-04-24T09:44:34Z","updated_at":"2017-04-24T09:44:36Z","pushed_at":"2017-08-23T12:20:19Z","git_url":"git://github.com/enoodle/manageiq-providers-kubernetes.git","ssh_url":"git@github.com:enoodle/manageiq-providers-kubernetes.git","clone_url":"https://github.com/enoodle/manageiq-providers-kubernetes.git","svn_url":"https://github.com/enoodle/manageiq-providers-kubernetes","homepage":null,"size":1974,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"264e7a6ad8e9c3b7976adf509bf5703ff9b63042","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars0.githubusercontent.com/u/1125575?v=4","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":87439629,"name":"manageiq-providers-kubernetes","full_name":"ManageIQ/manageiq-providers-kubernetes","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars0.githubusercontent.com/u/1125575?v=4","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq-providers-kubernetes","description":"ManageIQ plugin for the Kubernetes provider","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes","forks_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/deployments","created_at":"2017-04-06T14:37:31Z","updated_at":"2017-05-23T13:57:18Z","pushed_at":"2017-08-23T12:28:47Z","git_url":"git://github.com/ManageIQ/manageiq-providers-kubernetes.git","ssh_url":"git@github.com:ManageIQ/manageiq-providers-kubernetes.git","clone_url":"https://github.com/ManageIQ/manageiq-providers-kubernetes.git","svn_url":"https://github.com/ManageIQ/manageiq-providers-kubernetes","homepage":null,"size":1978,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":28,"mirror_url":null,"open_issues_count":25,"forks":28,"open_issues":25,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/pulls/99"},"html":{"href":"https://github.com/ManageIQ/manageiq-providers-kubernetes/pull/99"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/issues/99"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/issues/99/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/pulls/99/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/pulls/99/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq-providers-kubernetes/statuses/6bf8ad2a024c430207085e481c8e7c87643ed613"}}}}
{"actor":{"display_login":"moolitayer"}}