{"action":"created","comment":{"url":"https://api.github.com/repos/StrangeZak/Handmade-Math/pulls/comments/96129391","pull_request_review_id":16706871,"id":96129391,"diff_hunk":"@@ -2643,4 +2645,8 @@ operator*=(hmm_quaternion &Left, float Right)\n \n #endif /* HANDMADE_MATH_CPP_MODE */\n \n+#ifdef __clang__\n+#pragma GCC diagnostic pop","path":"HandmadeMath.h","position":32,"original_position":32,"commit_id":"70dcecc042439961983eacd11f2fbfbdadda0724","original_commit_id":"70dcecc042439961983eacd11f2fbfbdadda0724","user":{"login":"bvisness","id":4707402,"avatar_url":"https://avatars.githubusercontent.com/u/4707402?v=3","gravatar_id":"","url":"https://api.github.com/users/bvisness","html_url":"https://github.com/bvisness","followers_url":"https://api.github.com/users/bvisness/followers","following_url":"https://api.github.com/users/bvisness/following{/other_user}","gists_url":"https://api.github.com/users/bvisness/gists{/gist_id}","starred_url":"https://api.github.com/users/bvisness/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bvisness/subscriptions","organizations_url":"https://api.github.com/users/bvisness/orgs","repos_url":"https://api.github.com/users/bvisness/repos","events_url":"https://api.github.com/users/bvisness/events{/privacy}","received_events_url":"https://api.github.com/users/bvisness/received_events","type":"User","site_admin":false},"body":"Argh, yes. I am clearly too tired for this tonight...","created_at":"2017-01-15T03:36:23Z","updated_at":"2017-01-15T03:36:23Z","html_url":"https://github.com/StrangeZak/Handmade-Math/pull/50#discussion_r96129391","pull_request_url":"https://api.github.com/repos/StrangeZak/Handmade-Math/pulls/50","_links":{"self":{"href":"https://api.github.com/repos/StrangeZak/Handmade-Math/pulls/comments/96129391"},"html":{"href":"https://github.com/StrangeZak/Handmade-Math/pull/50#discussion_r96129391"},"pull_request":{"href":"https://api.github.com/repos/StrangeZak/Handmade-Math/pulls/50"}}},"pull_request":{"url":"https://api.github.com/repos/StrangeZak/Handmade-Math/pulls/50","id":101583309,"html_url":"https://github.com/StrangeZak/Handmade-Math/pull/50","diff_url":"https://github.com/StrangeZak/Handmade-Math/pull/50.diff","patch_url":"https://github.com/StrangeZak/Handmade-Math/pull/50.patch","issue_url":"https://api.github.com/repos/StrangeZak/Handmade-Math/issues/50","number":50,"state":"open","locked":false,"title":"Restrict struct warning suppression to clang only","user":{"login":"bvisness","id":4707402,"avatar_url":"https://avatars.githubusercontent.com/u/4707402?v=3","gravatar_id":"","url":"https://api.github.com/users/bvisness","html_url":"https://github.com/bvisness","followers_url":"https://api.github.com/users/bvisness/followers","following_url":"https://api.github.com/users/bvisness/following{/other_user}","gists_url":"https://api.github.com/users/bvisness/gists{/gist_id}","starred_url":"https://api.github.com/users/bvisness/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bvisness/subscriptions","organizations_url":"https://api.github.com/users/bvisness/orgs","repos_url":"https://api.github.com/users/bvisness/repos","events_url":"https://api.github.com/users/bvisness/events{/privacy}","received_events_url":"https://api.github.com/users/bvisness/received_events","type":"User","site_admin":false},"body":"Fixes the warnings recently reported by @DanielGibson in #45. It seems that `-Wgnu-anonymous-struct` is a flag for clang only, since gcc and g++ apparently support anonymous structs out of the box.\r\n\r\nAs a side note, our Travis is set up to build in both clang and g++, and the clang build showed no warnings even before #45 was merged. (And this is with `-Wall` enabled.)","created_at":"2017-01-15T03:23:30Z","updated_at":"2017-01-15T03:36:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c8fa5417bb17783647507f5ab2c45a98825d5e72","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/StrangeZak/Handmade-Math/pulls/50/commits","review_comments_url":"https://api.github.com/repos/StrangeZak/Handmade-Math/pulls/50/comments","review_comment_url":"https://api.github.com/repos/StrangeZak/Handmade-Math/pulls/comments{/number}","comments_url":"https://api.github.com/repos/StrangeZak/Handmade-Math/issues/50/comments","statuses_url":"https://api.github.com/repos/StrangeZak/Handmade-Math/statuses/70dcecc042439961983eacd11f2fbfbdadda0724","head":{"label":"StrangeZak:struct-error-clang","ref":"struct-error-clang","sha":"70dcecc042439961983eacd11f2fbfbdadda0724","user":{"login":"StrangeZak","id":8273141,"avatar_url":"https://avatars.githubusercontent.com/u/8273141?v=3","gravatar_id":"","url":"https://api.github.com/users/StrangeZak","html_url":"https://github.com/StrangeZak","followers_url":"https://api.github.com/users/StrangeZak/followers","following_url":"https://api.github.com/users/StrangeZak/following{/other_user}","gists_url":"https://api.github.com/users/StrangeZak/gists{/gist_id}","starred_url":"https://api.github.com/users/StrangeZak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StrangeZak/subscriptions","organizations_url":"https://api.github.com/users/StrangeZak/orgs","repos_url":"https://api.github.com/users/StrangeZak/repos","events_url":"https://api.github.com/users/StrangeZak/events{/privacy}","received_events_url":"https://api.github.com/users/StrangeZak/received_events","type":"User","site_admin":false},"repo":{"id":49993383,"name":"Handmade-Math","full_name":"StrangeZak/Handmade-Math","owner":{"login":"StrangeZak","id":8273141,"avatar_url":"https://avatars.githubusercontent.com/u/8273141?v=3","gravatar_id":"","url":"https://api.github.com/users/StrangeZak","html_url":"https://github.com/StrangeZak","followers_url":"https://api.github.com/users/StrangeZak/followers","following_url":"https://api.github.com/users/StrangeZak/following{/other_user}","gists_url":"https://api.github.com/users/StrangeZak/gists{/gist_id}","starred_url":"https://api.github.com/users/StrangeZak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StrangeZak/subscriptions","organizations_url":"https://api.github.com/users/StrangeZak/orgs","repos_url":"https://api.github.com/users/StrangeZak/repos","events_url":"https://api.github.com/users/StrangeZak/events{/privacy}","received_events_url":"https://api.github.com/users/StrangeZak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/StrangeZak/Handmade-Math","description":"A simple game math library.","fork":false,"url":"https://api.github.com/repos/StrangeZak/Handmade-Math","forks_url":"https://api.github.com/repos/StrangeZak/Handmade-Math/forks","keys_url":"https://api.github.com/repos/StrangeZak/Handmade-Math/keys{/key_id}","collaborators_url":"https://api.github.com/repos/StrangeZak/Handmade-Math/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/StrangeZak/Handmade-Math/teams","hooks_url":"https://api.github.com/repos/StrangeZak/Handmade-Math/hooks","issue_events_url":"https://api.github.com/repos/StrangeZak/Handmade-Math/issues/events{/number}","events_url":"https://api.github.com/repos/StrangeZak/Handmade-Math/events","assignees_url":"https://api.github.com/repos/StrangeZak/Handmade-Math/assignees{/user}","branches_url":"https://api.github.com/repos/StrangeZak/Handmade-Math/branches{/branch}","tags_url":"https://api.github.com/repos/StrangeZak/Handmade-Math/tags","blobs_url":"https://api.github.com/repos/StrangeZak/Handmade-Math/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/StrangeZak/Handmade-Math/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/StrangeZak/Handmade-Math/git/refs{/sha}","trees_url":"https://api.github.com/repos/StrangeZak/Handmade-Math/git/trees{/sha}","statuses_url":"https://api.github.com/repos/StrangeZak/Handmade-Math/statuses/{sha}","languages_url":"https://api.github.com/repos/StrangeZak/Handmade-Math/languages","stargazers_url":"https://api.github.com/repos/StrangeZak/Handmade-Math/stargazers","contributors_url":"https://api.github.com/repos/StrangeZak/Handmade-Math/contributors","subscribers_url":"https://api.github.com/repos/StrangeZak/Handmade-Math/subscribers","subscription_url":"https://api.github.com/repos/StrangeZak/Handmade-Math/subscription","commits_url":"https://api.github.com/repos/StrangeZak/Handmade-Math/commits{/sha}","git_commits_url":"https://api.github.com/repos/StrangeZak/Handmade-Math/git/commits{/sha}","comments_url":"https://api.github.com/repos/StrangeZak/Handmade-Math/comments{/number}","issue_comment_url":"https://api.github.com/repos/StrangeZak/Handmade-Math/issues/comments{/number}","contents_url":"https://api.github.com/repos/StrangeZak/Handmade-Math/contents/{+path}","compare_url":"https://api.github.com/repos/StrangeZak/Handmade-Math/compare/{base}...{head}","merges_url":"https://api.github.com/repos/StrangeZak/Handmade-Math/merges","archive_url":"https://api.github.com/repos/StrangeZak/Handmade-Math/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/StrangeZak/Handmade-Math/downloads","issues_url":"https://api.github.com/repos/StrangeZak/Handmade-Math/issues{/number}","pulls_url":"https://api.github.com/repos/StrangeZak/Handmade-Math/pulls{/number}","milestones_url":"https://api.github.com/repos/StrangeZak/Handmade-Math/milestones{/number}","notifications_url":"https://api.github.com/repos/StrangeZak/Handmade-Math/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/StrangeZak/Handmade-Math/labels{/name}","releases_url":"https://api.github.com/repos/StrangeZak/Handmade-Math/releases{/id}","deployments_url":"https://api.github.com/repos/StrangeZak/Handmade-Math/deployments","created_at":"2016-01-20T00:38:28Z","updated_at":"2017-01-09T02:30:21Z","pushed_at":"2017-01-15T03:33:08Z","git_url":"git://github.com/StrangeZak/Handmade-Math.git","ssh_url":"git@github.com:StrangeZak/Handmade-Math.git","clone_url":"https://github.com/StrangeZak/Handmade-Math.git","svn_url":"https://github.com/StrangeZak/Handmade-Math","homepage":null,"size":136,"stargazers_count":52,"watchers_count":52,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":2,"forks":9,"open_issues":2,"watchers":52,"default_branch":"master"}},"base":{"label":"StrangeZak:master","ref":"master","sha":"ad3039186d3a48caeff99fdd3a148e6bfdcfa78e","user":{"login":"StrangeZak","id":8273141,"avatar_url":"https://avatars.githubusercontent.com/u/8273141?v=3","gravatar_id":"","url":"https://api.github.com/users/StrangeZak","html_url":"https://github.com/StrangeZak","followers_url":"https://api.github.com/users/StrangeZak/followers","following_url":"https://api.github.com/users/StrangeZak/following{/other_user}","gists_url":"https://api.github.com/users/StrangeZak/gists{/gist_id}","starred_url":"https://api.github.com/users/StrangeZak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StrangeZak/subscriptions","organizations_url":"https://api.github.com/users/StrangeZak/orgs","repos_url":"https://api.github.com/users/StrangeZak/repos","events_url":"https://api.github.com/users/StrangeZak/events{/privacy}","received_events_url":"https://api.github.com/users/StrangeZak/received_events","type":"User","site_admin":false},"repo":{"id":49993383,"name":"Handmade-Math","full_name":"StrangeZak/Handmade-Math","owner":{"login":"StrangeZak","id":8273141,"avatar_url":"https://avatars.githubusercontent.com/u/8273141?v=3","gravatar_id":"","url":"https://api.github.com/users/StrangeZak","html_url":"https://github.com/StrangeZak","followers_url":"https://api.github.com/users/StrangeZak/followers","following_url":"https://api.github.com/users/StrangeZak/following{/other_user}","gists_url":"https://api.github.com/users/StrangeZak/gists{/gist_id}","starred_url":"https://api.github.com/users/StrangeZak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StrangeZak/subscriptions","organizations_url":"https://api.github.com/users/StrangeZak/orgs","repos_url":"https://api.github.com/users/StrangeZak/repos","events_url":"https://api.github.com/users/StrangeZak/events{/privacy}","received_events_url":"https://api.github.com/users/StrangeZak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/StrangeZak/Handmade-Math","description":"A simple game math library.","fork":false,"url":"https://api.github.com/repos/StrangeZak/Handmade-Math","forks_url":"https://api.github.com/repos/StrangeZak/Handmade-Math/forks","keys_url":"https://api.github.com/repos/StrangeZak/Handmade-Math/keys{/key_id}","collaborators_url":"https://api.github.com/repos/StrangeZak/Handmade-Math/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/StrangeZak/Handmade-Math/teams","hooks_url":"https://api.github.com/repos/StrangeZak/Handmade-Math/hooks","issue_events_url":"https://api.github.com/repos/StrangeZak/Handmade-Math/issues/events{/number}","events_url":"https://api.github.com/repos/StrangeZak/Handmade-Math/events","assignees_url":"https://api.github.com/repos/StrangeZak/Handmade-Math/assignees{/user}","branches_url":"https://api.github.com/repos/StrangeZak/Handmade-Math/branches{/branch}","tags_url":"https://api.github.com/repos/StrangeZak/Handmade-Math/tags","blobs_url":"https://api.github.com/repos/StrangeZak/Handmade-Math/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/StrangeZak/Handmade-Math/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/StrangeZak/Handmade-Math/git/refs{/sha}","trees_url":"https://api.github.com/repos/StrangeZak/Handmade-Math/git/trees{/sha}","statuses_url":"https://api.github.com/repos/StrangeZak/Handmade-Math/statuses/{sha}","languages_url":"https://api.github.com/repos/StrangeZak/Handmade-Math/languages","stargazers_url":"https://api.github.com/repos/StrangeZak/Handmade-Math/stargazers","contributors_url":"https://api.github.com/repos/StrangeZak/Handmade-Math/contributors","subscribers_url":"https://api.github.com/repos/StrangeZak/Handmade-Math/subscribers","subscription_url":"https://api.github.com/repos/StrangeZak/Handmade-Math/subscription","commits_url":"https://api.github.com/repos/StrangeZak/Handmade-Math/commits{/sha}","git_commits_url":"https://api.github.com/repos/StrangeZak/Handmade-Math/git/commits{/sha}","comments_url":"https://api.github.com/repos/StrangeZak/Handmade-Math/comments{/number}","issue_comment_url":"https://api.github.com/repos/StrangeZak/Handmade-Math/issues/comments{/number}","contents_url":"https://api.github.com/repos/StrangeZak/Handmade-Math/contents/{+path}","compare_url":"https://api.github.com/repos/StrangeZak/Handmade-Math/compare/{base}...{head}","merges_url":"https://api.github.com/repos/StrangeZak/Handmade-Math/merges","archive_url":"https://api.github.com/repos/StrangeZak/Handmade-Math/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/StrangeZak/Handmade-Math/downloads","issues_url":"https://api.github.com/repos/StrangeZak/Handmade-Math/issues{/number}","pulls_url":"https://api.github.com/repos/StrangeZak/Handmade-Math/pulls{/number}","milestones_url":"https://api.github.com/repos/StrangeZak/Handmade-Math/milestones{/number}","notifications_url":"https://api.github.com/repos/StrangeZak/Handmade-Math/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/StrangeZak/Handmade-Math/labels{/name}","releases_url":"https://api.github.com/repos/StrangeZak/Handmade-Math/releases{/id}","deployments_url":"https://api.github.com/repos/StrangeZak/Handmade-Math/deployments","created_at":"2016-01-20T00:38:28Z","updated_at":"2017-01-09T02:30:21Z","pushed_at":"2017-01-15T03:33:08Z","git_url":"git://github.com/StrangeZak/Handmade-Math.git","ssh_url":"git@github.com:StrangeZak/Handmade-Math.git","clone_url":"https://github.com/StrangeZak/Handmade-Math.git","svn_url":"https://github.com/StrangeZak/Handmade-Math","homepage":null,"size":136,"stargazers_count":52,"watchers_count":52,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":2,"forks":9,"open_issues":2,"watchers":52,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/StrangeZak/Handmade-Math/pulls/50"},"html":{"href":"https://github.com/StrangeZak/Handmade-Math/pull/50"},"issue":{"href":"https://api.github.com/repos/StrangeZak/Handmade-Math/issues/50"},"comments":{"href":"https://api.github.com/repos/StrangeZak/Handmade-Math/issues/50/comments"},"review_comments":{"href":"https://api.github.com/repos/StrangeZak/Handmade-Math/pulls/50/comments"},"review_comment":{"href":"https://api.github.com/repos/StrangeZak/Handmade-Math/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/StrangeZak/Handmade-Math/pulls/50/commits"},"statuses":{"href":"https://api.github.com/repos/StrangeZak/Handmade-Math/statuses/70dcecc042439961983eacd11f2fbfbdadda0724"}}}}
{"actor":{"display_login":"bvisness"}}