{"action":"closed","number":38,"pull_request":{"url":"https://api.github.com/repos/ArkEcosystem/ark-explorer/pulls/38","id":156550258,"html_url":"https://github.com/ArkEcosystem/ark-explorer/pull/38","diff_url":"https://github.com/ArkEcosystem/ark-explorer/pull/38.diff","patch_url":"https://github.com/ArkEcosystem/ark-explorer/pull/38.patch","issue_url":"https://api.github.com/repos/ArkEcosystem/ark-explorer/issues/38","number":38,"state":"closed","locked":false,"title":"Fix bug \"Cannot read property 'price' of undefined\" (CNY exception)","user":{"login":"Nasicus","id":1086065,"avatar_url":"https://avatars1.githubusercontent.com/u/1086065?v=4","gravatar_id":"","url":"https://api.github.com/users/Nasicus","html_url":"https://github.com/Nasicus","followers_url":"https://api.github.com/users/Nasicus/followers","following_url":"https://api.github.com/users/Nasicus/following{/other_user}","gists_url":"https://api.github.com/users/Nasicus/gists{/gist_id}","starred_url":"https://api.github.com/users/Nasicus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nasicus/subscriptions","organizations_url":"https://api.github.com/users/Nasicus/orgs","repos_url":"https://api.github.com/users/Nasicus/repos","events_url":"https://api.github.com/users/Nasicus/events{/privacy}","received_events_url":"https://api.github.com/users/Nasicus/received_events","type":"User","site_admin":false},"body":"I saw this exception while developing another feature (also visible on the productive ark explorer, if you open the developer console):\r\n\r\n```\r\ncore.es5.js:1020 ERROR TypeError: Cannot read property 'price' of undefined\r\n    at SafeSubscriber._next (header.component.ts:69)\r\n    at SafeSubscriber.webpackJsonp.../../../../rxjs/Subscriber.js.SafeSubscriber.__tryOrUnsub (Subscriber.js:238)\r\n    at SafeSubscriber.webpackJsonp.../../../../rxjs/Subscriber.js.SafeSubscriber.next (Subscriber.js:185)\r\n    at Subscriber.webpackJsonp.../../../../rxjs/Subscriber.js.Subscriber._next (Subscriber.js:125)\r\n    at Subscriber.webpackJsonp.../../../../rxjs/Subscriber.js.Subscriber.next (Subscriber.js:89)\r\n    at CatchSubscriber.webpackJsonp.../../../../rxjs/Subscriber.js.Subscriber._next (Subscriber.js:125)\r\n    at CatchSubscriber.webpackJsonp.../../../../rxjs/Subscriber.js.Subscriber.next (Subscriber.js:89)\r\n    at MapSubscriber.webpackJsonp.../../../../rxjs/operator/map.js.MapSubscriber._next (map.js:83)\r\n    at MapSubscriber.webpackJsonp.../../../../rxjs/Subscriber.js.Subscriber.next (Subscriber.js:89)\r\n    at XMLHttpRequest.onLoad (http.es5.js:1226)\r\n```\r\nThe fix was easy (see commit 5e238a7).\r\nHowever I realized that `cryptonator.com` doesn't support `CNY` anymore (see https://www.cryptonator.com/api/currencies). So I removed `CNY` completely from the code (21701d1). Obviously another solution would be to find and use another API for it.\r\n\r\nWhat do you prefer / want?","created_at":"2017-12-05T19:17:14Z","updated_at":"2017-12-28T10:42:15Z","closed_at":"2017-12-28T10:42:15Z","merged_at":"2017-12-28T10:42:15Z","merge_commit_sha":"59d7d45e13fb765328e3fbf3c694cf79db53d8ab","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ArkEcosystem/ark-explorer/pulls/38/commits","review_comments_url":"https://api.github.com/repos/ArkEcosystem/ark-explorer/pulls/38/comments","review_comment_url":"https://api.github.com/repos/ArkEcosystem/ark-explorer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ArkEcosystem/ark-explorer/issues/38/comments","statuses_url":"https://api.github.com/repos/ArkEcosystem/ark-explorer/statuses/21701d1bb5e550cb89c7b71c3d1bc564004d119a","head":{"label":"Nasicus:bug/cny-exception","ref":"bug/cny-exception","sha":"21701d1bb5e550cb89c7b71c3d1bc564004d119a","user":{"login":"Nasicus","id":1086065,"avatar_url":"https://avatars1.githubusercontent.com/u/1086065?v=4","gravatar_id":"","url":"https://api.github.com/users/Nasicus","html_url":"https://github.com/Nasicus","followers_url":"https://api.github.com/users/Nasicus/followers","following_url":"https://api.github.com/users/Nasicus/following{/other_user}","gists_url":"https://api.github.com/users/Nasicus/gists{/gist_id}","starred_url":"https://api.github.com/users/Nasicus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nasicus/subscriptions","organizations_url":"https://api.github.com/users/Nasicus/orgs","repos_url":"https://api.github.com/users/Nasicus/repos","events_url":"https://api.github.com/users/Nasicus/events{/privacy}","received_events_url":"https://api.github.com/users/Nasicus/received_events","type":"User","site_admin":false},"repo":{"id":113209988,"name":"ark-explorer","full_name":"Nasicus/ark-explorer","owner":{"login":"Nasicus","id":1086065,"avatar_url":"https://avatars1.githubusercontent.com/u/1086065?v=4","gravatar_id":"","url":"https://api.github.com/users/Nasicus","html_url":"https://github.com/Nasicus","followers_url":"https://api.github.com/users/Nasicus/followers","following_url":"https://api.github.com/users/Nasicus/following{/other_user}","gists_url":"https://api.github.com/users/Nasicus/gists{/gist_id}","starred_url":"https://api.github.com/users/Nasicus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nasicus/subscriptions","organizations_url":"https://api.github.com/users/Nasicus/orgs","repos_url":"https://api.github.com/users/Nasicus/repos","events_url":"https://api.github.com/users/Nasicus/events{/privacy}","received_events_url":"https://api.github.com/users/Nasicus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Nasicus/ark-explorer","description":"A redesigned frontend of ARK Blockchain Explorer using AngularJS and TypeScript.","fork":true,"url":"https://api.github.com/repos/Nasicus/ark-explorer","forks_url":"https://api.github.com/repos/Nasicus/ark-explorer/forks","keys_url":"https://api.github.com/repos/Nasicus/ark-explorer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Nasicus/ark-explorer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Nasicus/ark-explorer/teams","hooks_url":"https://api.github.com/repos/Nasicus/ark-explorer/hooks","issue_events_url":"https://api.github.com/repos/Nasicus/ark-explorer/issues/events{/number}","events_url":"https://api.github.com/repos/Nasicus/ark-explorer/events","assignees_url":"https://api.github.com/repos/Nasicus/ark-explorer/assignees{/user}","branches_url":"https://api.github.com/repos/Nasicus/ark-explorer/branches{/branch}","tags_url":"https://api.github.com/repos/Nasicus/ark-explorer/tags","blobs_url":"https://api.github.com/repos/Nasicus/ark-explorer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Nasicus/ark-explorer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Nasicus/ark-explorer/git/refs{/sha}","trees_url":"https://api.github.com/repos/Nasicus/ark-explorer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Nasicus/ark-explorer/statuses/{sha}","languages_url":"https://api.github.com/repos/Nasicus/ark-explorer/languages","stargazers_url":"https://api.github.com/repos/Nasicus/ark-explorer/stargazers","contributors_url":"https://api.github.com/repos/Nasicus/ark-explorer/contributors","subscribers_url":"https://api.github.com/repos/Nasicus/ark-explorer/subscribers","subscription_url":"https://api.github.com/repos/Nasicus/ark-explorer/subscription","commits_url":"https://api.github.com/repos/Nasicus/ark-explorer/commits{/sha}","git_commits_url":"https://api.github.com/repos/Nasicus/ark-explorer/git/commits{/sha}","comments_url":"https://api.github.com/repos/Nasicus/ark-explorer/comments{/number}","issue_comment_url":"https://api.github.com/repos/Nasicus/ark-explorer/issues/comments{/number}","contents_url":"https://api.github.com/repos/Nasicus/ark-explorer/contents/{+path}","compare_url":"https://api.github.com/repos/Nasicus/ark-explorer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Nasicus/ark-explorer/merges","archive_url":"https://api.github.com/repos/Nasicus/ark-explorer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Nasicus/ark-explorer/downloads","issues_url":"https://api.github.com/repos/Nasicus/ark-explorer/issues{/number}","pulls_url":"https://api.github.com/repos/Nasicus/ark-explorer/pulls{/number}","milestones_url":"https://api.github.com/repos/Nasicus/ark-explorer/milestones{/number}","notifications_url":"https://api.github.com/repos/Nasicus/ark-explorer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Nasicus/ark-explorer/labels{/name}","releases_url":"https://api.github.com/repos/Nasicus/ark-explorer/releases{/id}","deployments_url":"https://api.github.com/repos/Nasicus/ark-explorer/deployments","created_at":"2017-12-05T17:03:41Z","updated_at":"2017-12-05T17:03:43Z","pushed_at":"2017-12-17T13:01:30Z","git_url":"git://github.com/Nasicus/ark-explorer.git","ssh_url":"git@github.com:Nasicus/ark-explorer.git","clone_url":"https://github.com/Nasicus/ark-explorer.git","svn_url":"https://github.com/Nasicus/ark-explorer","homepage":"","size":775,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ArkEcosystem:master","ref":"master","sha":"66a622e3713e2b880cf7945884f556ab6e268ef3","user":{"login":"ArkEcosystem","id":22457396,"avatar_url":"https://avatars3.githubusercontent.com/u/22457396?v=4","gravatar_id":"","url":"https://api.github.com/users/ArkEcosystem","html_url":"https://github.com/ArkEcosystem","followers_url":"https://api.github.com/users/ArkEcosystem/followers","following_url":"https://api.github.com/users/ArkEcosystem/following{/other_user}","gists_url":"https://api.github.com/users/ArkEcosystem/gists{/gist_id}","starred_url":"https://api.github.com/users/ArkEcosystem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArkEcosystem/subscriptions","organizations_url":"https://api.github.com/users/ArkEcosystem/orgs","repos_url":"https://api.github.com/users/ArkEcosystem/repos","events_url":"https://api.github.com/users/ArkEcosystem/events{/privacy}","received_events_url":"https://api.github.com/users/ArkEcosystem/received_events","type":"Organization","site_admin":false},"repo":{"id":105805172,"name":"ark-explorer","full_name":"ArkEcosystem/ark-explorer","owner":{"login":"ArkEcosystem","id":22457396,"avatar_url":"https://avatars3.githubusercontent.com/u/22457396?v=4","gravatar_id":"","url":"https://api.github.com/users/ArkEcosystem","html_url":"https://github.com/ArkEcosystem","followers_url":"https://api.github.com/users/ArkEcosystem/followers","following_url":"https://api.github.com/users/ArkEcosystem/following{/other_user}","gists_url":"https://api.github.com/users/ArkEcosystem/gists{/gist_id}","starred_url":"https://api.github.com/users/ArkEcosystem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArkEcosystem/subscriptions","organizations_url":"https://api.github.com/users/ArkEcosystem/orgs","repos_url":"https://api.github.com/users/ArkEcosystem/repos","events_url":"https://api.github.com/users/ArkEcosystem/events{/privacy}","received_events_url":"https://api.github.com/users/ArkEcosystem/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ArkEcosystem/ark-explorer","description":"A redesigned frontend of ARK Blockchain Explorer using AngularJS and TypeScript.","fork":false,"url":"https://api.github.com/repos/ArkEcosystem/ark-explorer","forks_url":"https://api.github.com/repos/ArkEcosystem/ark-explorer/forks","keys_url":"https://api.github.com/repos/ArkEcosystem/ark-explorer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ArkEcosystem/ark-explorer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ArkEcosystem/ark-explorer/teams","hooks_url":"https://api.github.com/repos/ArkEcosystem/ark-explorer/hooks","issue_events_url":"https://api.github.com/repos/ArkEcosystem/ark-explorer/issues/events{/number}","events_url":"https://api.github.com/repos/ArkEcosystem/ark-explorer/events","assignees_url":"https://api.github.com/repos/ArkEcosystem/ark-explorer/assignees{/user}","branches_url":"https://api.github.com/repos/ArkEcosystem/ark-explorer/branches{/branch}","tags_url":"https://api.github.com/repos/ArkEcosystem/ark-explorer/tags","blobs_url":"https://api.github.com/repos/ArkEcosystem/ark-explorer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ArkEcosystem/ark-explorer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ArkEcosystem/ark-explorer/git/refs{/sha}","trees_url":"https://api.github.com/repos/ArkEcosystem/ark-explorer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ArkEcosystem/ark-explorer/statuses/{sha}","languages_url":"https://api.github.com/repos/ArkEcosystem/ark-explorer/languages","stargazers_url":"https://api.github.com/repos/ArkEcosystem/ark-explorer/stargazers","contributors_url":"https://api.github.com/repos/ArkEcosystem/ark-explorer/contributors","subscribers_url":"https://api.github.com/repos/ArkEcosystem/ark-explorer/subscribers","subscription_url":"https://api.github.com/repos/ArkEcosystem/ark-explorer/subscription","commits_url":"https://api.github.com/repos/ArkEcosystem/ark-explorer/commits{/sha}","git_commits_url":"https://api.github.com/repos/ArkEcosystem/ark-explorer/git/commits{/sha}","comments_url":"https://api.github.com/repos/ArkEcosystem/ark-explorer/comments{/number}","issue_comment_url":"https://api.github.com/repos/ArkEcosystem/ark-explorer/issues/comments{/number}","contents_url":"https://api.github.com/repos/ArkEcosystem/ark-explorer/contents/{+path}","compare_url":"https://api.github.com/repos/ArkEcosystem/ark-explorer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ArkEcosystem/ark-explorer/merges","archive_url":"https://api.github.com/repos/ArkEcosystem/ark-explorer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ArkEcosystem/ark-explorer/downloads","issues_url":"https://api.github.com/repos/ArkEcosystem/ark-explorer/issues{/number}","pulls_url":"https://api.github.com/repos/ArkEcosystem/ark-explorer/pulls{/number}","milestones_url":"https://api.github.com/repos/ArkEcosystem/ark-explorer/milestones{/number}","notifications_url":"https://api.github.com/repos/ArkEcosystem/ark-explorer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ArkEcosystem/ark-explorer/labels{/name}","releases_url":"https://api.github.com/repos/ArkEcosystem/ark-explorer/releases{/id}","deployments_url":"https://api.github.com/repos/ArkEcosystem/ark-explorer/deployments","created_at":"2017-10-04T18:46:58Z","updated_at":"2017-11-15T23:43:30Z","pushed_at":"2017-12-28T10:42:15Z","git_url":"git://github.com/ArkEcosystem/ark-explorer.git","ssh_url":"git@github.com:ArkEcosystem/ark-explorer.git","clone_url":"https://github.com/ArkEcosystem/ark-explorer.git","svn_url":"https://github.com/ArkEcosystem/ark-explorer","homepage":"","size":727,"stargazers_count":8,"watchers_count":8,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":24,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":14,"open_issues":24,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ArkEcosystem/ark-explorer/pulls/38"},"html":{"href":"https://github.com/ArkEcosystem/ark-explorer/pull/38"},"issue":{"href":"https://api.github.com/repos/ArkEcosystem/ark-explorer/issues/38"},"comments":{"href":"https://api.github.com/repos/ArkEcosystem/ark-explorer/issues/38/comments"},"review_comments":{"href":"https://api.github.com/repos/ArkEcosystem/ark-explorer/pulls/38/comments"},"review_comment":{"href":"https://api.github.com/repos/ArkEcosystem/ark-explorer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ArkEcosystem/ark-explorer/pulls/38/commits"},"statuses":{"href":"https://api.github.com/repos/ArkEcosystem/ark-explorer/statuses/21701d1bb5e550cb89c7b71c3d1bc564004d119a"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"faustbrian","id":22145591,"avatar_url":"https://avatars3.githubusercontent.com/u/22145591?v=4","gravatar_id":"","url":"https://api.github.com/users/faustbrian","html_url":"https://github.com/faustbrian","followers_url":"https://api.github.com/users/faustbrian/followers","following_url":"https://api.github.com/users/faustbrian/following{/other_user}","gists_url":"https://api.github.com/users/faustbrian/gists{/gist_id}","starred_url":"https://api.github.com/users/faustbrian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/faustbrian/subscriptions","organizations_url":"https://api.github.com/users/faustbrian/orgs","repos_url":"https://api.github.com/users/faustbrian/repos","events_url":"https://api.github.com/users/faustbrian/events{/privacy}","received_events_url":"https://api.github.com/users/faustbrian/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":12,"deletions":23,"changed_files":3}}
{"actor":{"display_login":"faustbrian"}}