{"action":"created","issue":{"url":"https://api.github.com/repos/nipy/nibabel/issues/562","repository_url":"https://api.github.com/repos/nipy/nibabel","labels_url":"https://api.github.com/repos/nipy/nibabel/issues/562/labels{/name}","comments_url":"https://api.github.com/repos/nipy/nibabel/issues/562/comments","events_url":"https://api.github.com/repos/nipy/nibabel/issues/562/events","html_url":"https://github.com/nipy/nibabel/pull/562","id":262095799,"number":562,"title":"Only use `indexed_gzip` when explicitly requested","user":{"login":"pauldmccarthy","id":236128,"avatar_url":"https://avatars2.githubusercontent.com/u/236128?v=4","gravatar_id":"","url":"https://api.github.com/users/pauldmccarthy","html_url":"https://github.com/pauldmccarthy","followers_url":"https://api.github.com/users/pauldmccarthy/followers","following_url":"https://api.github.com/users/pauldmccarthy/following{/other_user}","gists_url":"https://api.github.com/users/pauldmccarthy/gists{/gist_id}","starred_url":"https://api.github.com/users/pauldmccarthy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pauldmccarthy/subscriptions","organizations_url":"https://api.github.com/users/pauldmccarthy/orgs","repos_url":"https://api.github.com/users/pauldmccarthy/repos","events_url":"https://api.github.com/users/pauldmccarthy/events{/privacy}","received_events_url":"https://api.github.com/users/pauldmccarthy/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":17,"created_at":"2017-10-02T14:03:33Z","updated_at":"2017-10-06T10:25:09Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/nipy/nibabel/pulls/562","html_url":"https://github.com/nipy/nibabel/pull/562","diff_url":"https://github.com/nipy/nibabel/pull/562.diff","patch_url":"https://github.com/nipy/nibabel/pull/562.patch"},"body":"This PR aims to address issue #558 - it should have been a part of PR #552 \r\n\r\nFor small files, the current version of `indexed_gzip` is much slower to use than the built-in `GzipFile` class. Therefore, `indexed_gzip` should not be used unless it is requested (via the `keep_file_open` flag, which is interpreted by the `nibabel.arrayproxy.ArrayProxy` class). In all other circumstances, the built-in `gzip.GzipFile` class should be used instead.\r\n\r\nI have made this change by having the `ArrayProxy` pass a \"hint\" to the `Opener` class, indicating whether the file handle is going to be kept open for multiple accesses, or whether it is just for a one-time access. The `Opener` class (actually, the `nibabel.openers._gzip_open` function) then decides whether or not to use `indexed_gzip`."},"comment":{"url":"https://api.github.com/repos/nipy/nibabel/issues/comments/334717783","html_url":"https://github.com/nipy/nibabel/pull/562#issuecomment-334717783","issue_url":"https://api.github.com/repos/nipy/nibabel/issues/562","id":334717783,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars1.githubusercontent.com/u/2354108?v=4","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2017-10-06T10:25:09Z","updated_at":"2017-10-06T10:25:09Z","author_association":"NONE","body":"\n[![Coverage Status](https://coveralls.io/builds/13598230/badge)](https://coveralls.io/builds/13598230)\n\nCoverage decreased (-0.01%) to 96.253% when pulling **cc724ef89beb4d9eac7241445942d703da9c04e4 on pauldmccarthy:indexed_gzip_usage** into **fa761417c3ed6af9bbda448b13318ea794736352 on nipy:master**.\n"}}
{"actor":{"display_login":"coveralls"}}