{"action":"created","comment":{"url":"https://api.github.com/repos/webdevwilson/terraform-provider-artifactory/pulls/comments/146113887","pull_request_review_id":71015613,"id":146113887,"diff_hunk":"@@ -2,12 +2,12 @@\n \n # Check gofmt\n echo \"==> Checking that code complies with gofmt requirements...\"\n-gofmt_files=$(gofmt -l `find . -name '*.go' | grep -v vendor`)","path":"scripts/gofmtcheck.sh","position":4,"original_position":4,"commit_id":"d7990bb2f92ab5f024a793894cac2150adf26cf2","original_commit_id":"d7990bb2f92ab5f024a793894cac2150adf26cf2","user":{"login":"puneetk","id":528061,"avatar_url":"https://avatars1.githubusercontent.com/u/528061?v=4","gravatar_id":"","url":"https://api.github.com/users/puneetk","html_url":"https://github.com/puneetk","followers_url":"https://api.github.com/users/puneetk/followers","following_url":"https://api.github.com/users/puneetk/following{/other_user}","gists_url":"https://api.github.com/users/puneetk/gists{/gist_id}","starred_url":"https://api.github.com/users/puneetk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puneetk/subscriptions","organizations_url":"https://api.github.com/users/puneetk/orgs","repos_url":"https://api.github.com/users/puneetk/repos","events_url":"https://api.github.com/users/puneetk/events{/privacy}","received_events_url":"https://api.github.com/users/puneetk/received_events","type":"User","site_admin":false},"body":"Well `die` is a strong word, but especially in cases where we are nesting bash executions $() is preferred to backticks. Its more deterministic execution, and one does not have to worry about escaping and such. Ref http://mywiki.wooledge.org/BashFAQ/082 ","created_at":"2017-10-21T19:40:14Z","updated_at":"2017-10-21T19:40:14Z","html_url":"https://github.com/webdevwilson/terraform-provider-artifactory/pull/10#discussion_r146113887","pull_request_url":"https://api.github.com/repos/webdevwilson/terraform-provider-artifactory/pulls/10","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/webdevwilson/terraform-provider-artifactory/pulls/comments/146113887"},"html":{"href":"https://github.com/webdevwilson/terraform-provider-artifactory/pull/10#discussion_r146113887"},"pull_request":{"href":"https://api.github.com/repos/webdevwilson/terraform-provider-artifactory/pulls/10"}},"in_reply_to_id":146107116},"pull_request":{"url":"https://api.github.com/repos/webdevwilson/terraform-provider-artifactory/pulls/10","id":147943190,"html_url":"https://github.com/webdevwilson/terraform-provider-artifactory/pull/10","diff_url":"https://github.com/webdevwilson/terraform-provider-artifactory/pull/10.diff","patch_url":"https://github.com/webdevwilson/terraform-provider-artifactory/pull/10.patch","issue_url":"https://api.github.com/repos/webdevwilson/terraform-provider-artifactory/issues/10","number":10,"state":"open","locked":false,"title":" Add in errcheck, changelog-links from upstream terraform ","user":{"login":"puneetk","id":528061,"avatar_url":"https://avatars1.githubusercontent.com/u/528061?v=4","gravatar_id":"","url":"https://api.github.com/users/puneetk","html_url":"https://github.com/puneetk","followers_url":"https://api.github.com/users/puneetk/followers","following_url":"https://api.github.com/users/puneetk/following{/other_user}","gists_url":"https://api.github.com/users/puneetk/gists{/gist_id}","starred_url":"https://api.github.com/users/puneetk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puneetk/subscriptions","organizations_url":"https://api.github.com/users/puneetk/orgs","repos_url":"https://api.github.com/users/puneetk/repos","events_url":"https://api.github.com/users/puneetk/events{/privacy}","received_events_url":"https://api.github.com/users/puneetk/received_events","type":"User","site_admin":false},"body":"**Summary of Changes** \r\n* BackTicks Must Die\r\n* Add in go errcheck script from terraform-provider-null\r\n* Add in changelog script from terraform-provider-null \r\n","created_at":"2017-10-21T13:02:38Z","updated_at":"2017-10-21T19:40:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"54e25415efb5a5c138ec4a110b68cc29e6a17c24","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/webdevwilson/terraform-provider-artifactory/pulls/10/commits","review_comments_url":"https://api.github.com/repos/webdevwilson/terraform-provider-artifactory/pulls/10/comments","review_comment_url":"https://api.github.com/repos/webdevwilson/terraform-provider-artifactory/pulls/comments{/number}","comments_url":"https://api.github.com/repos/webdevwilson/terraform-provider-artifactory/issues/10/comments","statuses_url":"https://api.github.com/repos/webdevwilson/terraform-provider-artifactory/statuses/d7990bb2f92ab5f024a793894cac2150adf26cf2","head":{"label":"puneetk:master","ref":"master","sha":"d7990bb2f92ab5f024a793894cac2150adf26cf2","user":{"login":"puneetk","id":528061,"avatar_url":"https://avatars1.githubusercontent.com/u/528061?v=4","gravatar_id":"","url":"https://api.github.com/users/puneetk","html_url":"https://github.com/puneetk","followers_url":"https://api.github.com/users/puneetk/followers","following_url":"https://api.github.com/users/puneetk/following{/other_user}","gists_url":"https://api.github.com/users/puneetk/gists{/gist_id}","starred_url":"https://api.github.com/users/puneetk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puneetk/subscriptions","organizations_url":"https://api.github.com/users/puneetk/orgs","repos_url":"https://api.github.com/users/puneetk/repos","events_url":"https://api.github.com/users/puneetk/events{/privacy}","received_events_url":"https://api.github.com/users/puneetk/received_events","type":"User","site_admin":false},"repo":{"id":107501113,"name":"terraform-provider-artifactory","full_name":"puneetk/terraform-provider-artifactory","owner":{"login":"puneetk","id":528061,"avatar_url":"https://avatars1.githubusercontent.com/u/528061?v=4","gravatar_id":"","url":"https://api.github.com/users/puneetk","html_url":"https://github.com/puneetk","followers_url":"https://api.github.com/users/puneetk/followers","following_url":"https://api.github.com/users/puneetk/following{/other_user}","gists_url":"https://api.github.com/users/puneetk/gists{/gist_id}","starred_url":"https://api.github.com/users/puneetk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puneetk/subscriptions","organizations_url":"https://api.github.com/users/puneetk/orgs","repos_url":"https://api.github.com/users/puneetk/repos","events_url":"https://api.github.com/users/puneetk/events{/privacy}","received_events_url":"https://api.github.com/users/puneetk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/puneetk/terraform-provider-artifactory","description":"Terraform provider for managing Artifactory","fork":true,"url":"https://api.github.com/repos/puneetk/terraform-provider-artifactory","forks_url":"https://api.github.com/repos/puneetk/terraform-provider-artifactory/forks","keys_url":"https://api.github.com/repos/puneetk/terraform-provider-artifactory/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puneetk/terraform-provider-artifactory/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puneetk/terraform-provider-artifactory/teams","hooks_url":"https://api.github.com/repos/puneetk/terraform-provider-artifactory/hooks","issue_events_url":"https://api.github.com/repos/puneetk/terraform-provider-artifactory/issues/events{/number}","events_url":"https://api.github.com/repos/puneetk/terraform-provider-artifactory/events","assignees_url":"https://api.github.com/repos/puneetk/terraform-provider-artifactory/assignees{/user}","branches_url":"https://api.github.com/repos/puneetk/terraform-provider-artifactory/branches{/branch}","tags_url":"https://api.github.com/repos/puneetk/terraform-provider-artifactory/tags","blobs_url":"https://api.github.com/repos/puneetk/terraform-provider-artifactory/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puneetk/terraform-provider-artifactory/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puneetk/terraform-provider-artifactory/git/refs{/sha}","trees_url":"https://api.github.com/repos/puneetk/terraform-provider-artifactory/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puneetk/terraform-provider-artifactory/statuses/{sha}","languages_url":"https://api.github.com/repos/puneetk/terraform-provider-artifactory/languages","stargazers_url":"https://api.github.com/repos/puneetk/terraform-provider-artifactory/stargazers","contributors_url":"https://api.github.com/repos/puneetk/terraform-provider-artifactory/contributors","subscribers_url":"https://api.github.com/repos/puneetk/terraform-provider-artifactory/subscribers","subscription_url":"https://api.github.com/repos/puneetk/terraform-provider-artifactory/subscription","commits_url":"https://api.github.com/repos/puneetk/terraform-provider-artifactory/commits{/sha}","git_commits_url":"https://api.github.com/repos/puneetk/terraform-provider-artifactory/git/commits{/sha}","comments_url":"https://api.github.com/repos/puneetk/terraform-provider-artifactory/comments{/number}","issue_comment_url":"https://api.github.com/repos/puneetk/terraform-provider-artifactory/issues/comments{/number}","contents_url":"https://api.github.com/repos/puneetk/terraform-provider-artifactory/contents/{+path}","compare_url":"https://api.github.com/repos/puneetk/terraform-provider-artifactory/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puneetk/terraform-provider-artifactory/merges","archive_url":"https://api.github.com/repos/puneetk/terraform-provider-artifactory/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puneetk/terraform-provider-artifactory/downloads","issues_url":"https://api.github.com/repos/puneetk/terraform-provider-artifactory/issues{/number}","pulls_url":"https://api.github.com/repos/puneetk/terraform-provider-artifactory/pulls{/number}","milestones_url":"https://api.github.com/repos/puneetk/terraform-provider-artifactory/milestones{/number}","notifications_url":"https://api.github.com/repos/puneetk/terraform-provider-artifactory/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puneetk/terraform-provider-artifactory/labels{/name}","releases_url":"https://api.github.com/repos/puneetk/terraform-provider-artifactory/releases{/id}","deployments_url":"https://api.github.com/repos/puneetk/terraform-provider-artifactory/deployments","created_at":"2017-10-19T05:15:17Z","updated_at":"2017-10-19T05:15:19Z","pushed_at":"2017-10-21T12:59:15Z","git_url":"git://github.com/puneetk/terraform-provider-artifactory.git","ssh_url":"git@github.com:puneetk/terraform-provider-artifactory.git","clone_url":"https://github.com/puneetk/terraform-provider-artifactory.git","svn_url":"https://github.com/puneetk/terraform-provider-artifactory","homepage":"","size":2409,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"webdevwilson:master","ref":"master","sha":"0053fd81588a77a489039eee478f41404d17d84b","user":{"login":"webdevwilson","id":183272,"avatar_url":"https://avatars3.githubusercontent.com/u/183272?v=4","gravatar_id":"","url":"https://api.github.com/users/webdevwilson","html_url":"https://github.com/webdevwilson","followers_url":"https://api.github.com/users/webdevwilson/followers","following_url":"https://api.github.com/users/webdevwilson/following{/other_user}","gists_url":"https://api.github.com/users/webdevwilson/gists{/gist_id}","starred_url":"https://api.github.com/users/webdevwilson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webdevwilson/subscriptions","organizations_url":"https://api.github.com/users/webdevwilson/orgs","repos_url":"https://api.github.com/users/webdevwilson/repos","events_url":"https://api.github.com/users/webdevwilson/events{/privacy}","received_events_url":"https://api.github.com/users/webdevwilson/received_events","type":"User","site_admin":false},"repo":{"id":88810849,"name":"terraform-provider-artifactory","full_name":"webdevwilson/terraform-provider-artifactory","owner":{"login":"webdevwilson","id":183272,"avatar_url":"https://avatars3.githubusercontent.com/u/183272?v=4","gravatar_id":"","url":"https://api.github.com/users/webdevwilson","html_url":"https://github.com/webdevwilson","followers_url":"https://api.github.com/users/webdevwilson/followers","following_url":"https://api.github.com/users/webdevwilson/following{/other_user}","gists_url":"https://api.github.com/users/webdevwilson/gists{/gist_id}","starred_url":"https://api.github.com/users/webdevwilson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webdevwilson/subscriptions","organizations_url":"https://api.github.com/users/webdevwilson/orgs","repos_url":"https://api.github.com/users/webdevwilson/repos","events_url":"https://api.github.com/users/webdevwilson/events{/privacy}","received_events_url":"https://api.github.com/users/webdevwilson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/webdevwilson/terraform-provider-artifactory","description":"Terraform provider for managing Artifactory","fork":false,"url":"https://api.github.com/repos/webdevwilson/terraform-provider-artifactory","forks_url":"https://api.github.com/repos/webdevwilson/terraform-provider-artifactory/forks","keys_url":"https://api.github.com/repos/webdevwilson/terraform-provider-artifactory/keys{/key_id}","collaborators_url":"https://api.github.com/repos/webdevwilson/terraform-provider-artifactory/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/webdevwilson/terraform-provider-artifactory/teams","hooks_url":"https://api.github.com/repos/webdevwilson/terraform-provider-artifactory/hooks","issue_events_url":"https://api.github.com/repos/webdevwilson/terraform-provider-artifactory/issues/events{/number}","events_url":"https://api.github.com/repos/webdevwilson/terraform-provider-artifactory/events","assignees_url":"https://api.github.com/repos/webdevwilson/terraform-provider-artifactory/assignees{/user}","branches_url":"https://api.github.com/repos/webdevwilson/terraform-provider-artifactory/branches{/branch}","tags_url":"https://api.github.com/repos/webdevwilson/terraform-provider-artifactory/tags","blobs_url":"https://api.github.com/repos/webdevwilson/terraform-provider-artifactory/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/webdevwilson/terraform-provider-artifactory/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/webdevwilson/terraform-provider-artifactory/git/refs{/sha}","trees_url":"https://api.github.com/repos/webdevwilson/terraform-provider-artifactory/git/trees{/sha}","statuses_url":"https://api.github.com/repos/webdevwilson/terraform-provider-artifactory/statuses/{sha}","languages_url":"https://api.github.com/repos/webdevwilson/terraform-provider-artifactory/languages","stargazers_url":"https://api.github.com/repos/webdevwilson/terraform-provider-artifactory/stargazers","contributors_url":"https://api.github.com/repos/webdevwilson/terraform-provider-artifactory/contributors","subscribers_url":"https://api.github.com/repos/webdevwilson/terraform-provider-artifactory/subscribers","subscription_url":"https://api.github.com/repos/webdevwilson/terraform-provider-artifactory/subscription","commits_url":"https://api.github.com/repos/webdevwilson/terraform-provider-artifactory/commits{/sha}","git_commits_url":"https://api.github.com/repos/webdevwilson/terraform-provider-artifactory/git/commits{/sha}","comments_url":"https://api.github.com/repos/webdevwilson/terraform-provider-artifactory/comments{/number}","issue_comment_url":"https://api.github.com/repos/webdevwilson/terraform-provider-artifactory/issues/comments{/number}","contents_url":"https://api.github.com/repos/webdevwilson/terraform-provider-artifactory/contents/{+path}","compare_url":"https://api.github.com/repos/webdevwilson/terraform-provider-artifactory/compare/{base}...{head}","merges_url":"https://api.github.com/repos/webdevwilson/terraform-provider-artifactory/merges","archive_url":"https://api.github.com/repos/webdevwilson/terraform-provider-artifactory/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/webdevwilson/terraform-provider-artifactory/downloads","issues_url":"https://api.github.com/repos/webdevwilson/terraform-provider-artifactory/issues{/number}","pulls_url":"https://api.github.com/repos/webdevwilson/terraform-provider-artifactory/pulls{/number}","milestones_url":"https://api.github.com/repos/webdevwilson/terraform-provider-artifactory/milestones{/number}","notifications_url":"https://api.github.com/repos/webdevwilson/terraform-provider-artifactory/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/webdevwilson/terraform-provider-artifactory/labels{/name}","releases_url":"https://api.github.com/repos/webdevwilson/terraform-provider-artifactory/releases{/id}","deployments_url":"https://api.github.com/repos/webdevwilson/terraform-provider-artifactory/deployments","created_at":"2017-04-20T02:16:21Z","updated_at":"2017-09-19T20:04:51Z","pushed_at":"2017-10-21T13:02:38Z","git_url":"git://github.com/webdevwilson/terraform-provider-artifactory.git","ssh_url":"git@github.com:webdevwilson/terraform-provider-artifactory.git","clone_url":"https://github.com/webdevwilson/terraform-provider-artifactory.git","svn_url":"https://github.com/webdevwilson/terraform-provider-artifactory","homepage":"","size":2407,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":3,"forks":4,"open_issues":3,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/webdevwilson/terraform-provider-artifactory/pulls/10"},"html":{"href":"https://github.com/webdevwilson/terraform-provider-artifactory/pull/10"},"issue":{"href":"https://api.github.com/repos/webdevwilson/terraform-provider-artifactory/issues/10"},"comments":{"href":"https://api.github.com/repos/webdevwilson/terraform-provider-artifactory/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/webdevwilson/terraform-provider-artifactory/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/webdevwilson/terraform-provider-artifactory/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/webdevwilson/terraform-provider-artifactory/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/webdevwilson/terraform-provider-artifactory/statuses/d7990bb2f92ab5f024a793894cac2150adf26cf2"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"puneetk"}}