{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/core-setup/issues/1723","repository_url":"https://api.github.com/repos/dotnet/core-setup","labels_url":"https://api.github.com/repos/dotnet/core-setup/issues/1723/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/core-setup/issues/1723/comments","events_url":"https://api.github.com/repos/dotnet/core-setup/issues/1723/events","html_url":"https://github.com/dotnet/core-setup/pull/1723","id":213880397,"number":1723,"title":"Include symbols in core-setup zip / tarballs","user":{"login":"chcosta","id":10092143,"avatar_url":"https://avatars0.githubusercontent.com/u/10092143?v=3","gravatar_id":"","url":"https://api.github.com/users/chcosta","html_url":"https://github.com/chcosta","followers_url":"https://api.github.com/users/chcosta/followers","following_url":"https://api.github.com/users/chcosta/following{/other_user}","gists_url":"https://api.github.com/users/chcosta/gists{/gist_id}","starred_url":"https://api.github.com/users/chcosta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chcosta/subscriptions","organizations_url":"https://api.github.com/users/chcosta/orgs","repos_url":"https://api.github.com/users/chcosta/repos","events_url":"https://api.github.com/users/chcosta/events{/privacy}","received_events_url":"https://api.github.com/users/chcosta/received_events","type":"User","site_admin":false},"labels":[{"id":384082403,"url":"https://api.github.com/repos/dotnet/core-setup/labels/cla-already-signed","name":"cla-already-signed","color":"009800","default":false}],"state":"open","locked":false,"assignee":{"login":"chcosta","id":10092143,"avatar_url":"https://avatars0.githubusercontent.com/u/10092143?v=3","gravatar_id":"","url":"https://api.github.com/users/chcosta","html_url":"https://github.com/chcosta","followers_url":"https://api.github.com/users/chcosta/followers","following_url":"https://api.github.com/users/chcosta/following{/other_user}","gists_url":"https://api.github.com/users/chcosta/gists{/gist_id}","starred_url":"https://api.github.com/users/chcosta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chcosta/subscriptions","organizations_url":"https://api.github.com/users/chcosta/orgs","repos_url":"https://api.github.com/users/chcosta/repos","events_url":"https://api.github.com/users/chcosta/events{/privacy}","received_events_url":"https://api.github.com/users/chcosta/received_events","type":"User","site_admin":false},"assignees":[{"login":"chcosta","id":10092143,"avatar_url":"https://avatars0.githubusercontent.com/u/10092143?v=3","gravatar_id":"","url":"https://api.github.com/users/chcosta","html_url":"https://github.com/chcosta","followers_url":"https://api.github.com/users/chcosta/followers","following_url":"https://api.github.com/users/chcosta/following{/other_user}","gists_url":"https://api.github.com/users/chcosta/gists{/gist_id}","starred_url":"https://api.github.com/users/chcosta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chcosta/subscriptions","organizations_url":"https://api.github.com/users/chcosta/orgs","repos_url":"https://api.github.com/users/chcosta/repos","events_url":"https://api.github.com/users/chcosta/events{/privacy}","received_events_url":"https://api.github.com/users/chcosta/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2017-03-13T19:59:57Z","updated_at":"2017-03-14T16:21:08Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dotnet/core-setup/pulls/1723","html_url":"https://github.com/dotnet/core-setup/pull/1723","diff_url":"https://github.com/dotnet/core-setup/pull/1723.diff","patch_url":"https://github.com/dotnet/core-setup/pull/1723.patch"},"body":"This change preserves symbols from packages which are re-packaged into Microsoft.NETCore.App so that we can later include those symbols when producing zip / tarballs which include the shared framework.\r\n\r\nI'm also updating buildtools in this change.  I could decouple that if it's a concern, but I updated the branch because I played around with producing a packed Microsoft.NETCore.App package before deciding it was cleaner to simply preserve the symbols outside of the package creation / publish process.\r\n\r\n/cc @ellismg @weshaggard @ericstj"},"comment":{"url":"https://api.github.com/repos/dotnet/core-setup/issues/comments/286475408","html_url":"https://github.com/dotnet/core-setup/pull/1723#issuecomment-286475408","issue_url":"https://api.github.com/repos/dotnet/core-setup/issues/1723","id":286475408,"user":{"login":"qizhanMS","id":22175571,"avatar_url":"https://avatars1.githubusercontent.com/u/22175571?v=3","gravatar_id":"","url":"https://api.github.com/users/qizhanMS","html_url":"https://github.com/qizhanMS","followers_url":"https://api.github.com/users/qizhanMS/followers","following_url":"https://api.github.com/users/qizhanMS/following{/other_user}","gists_url":"https://api.github.com/users/qizhanMS/gists{/gist_id}","starred_url":"https://api.github.com/users/qizhanMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qizhanMS/subscriptions","organizations_url":"https://api.github.com/users/qizhanMS/orgs","repos_url":"https://api.github.com/users/qizhanMS/repos","events_url":"https://api.github.com/users/qizhanMS/events{/privacy}","received_events_url":"https://api.github.com/users/qizhanMS/received_events","type":"User","site_admin":false},"created_at":"2017-03-14T16:21:08Z","updated_at":"2017-03-14T16:21:08Z","body":"For System.Transactions, System.Transactions.dll is used for \"netfx\" only. For .Net core, we use System.Transactions.Local.dll. We need to know which platform the SymChk is running. Also in corefx, we don't generate System.Transactions.dll. Therefore, need to find symbol from external for netfx."}}
{"actor":{"display_login":"qizhanMS"}}