{"action":"opened","number":14,"pull_request":{"url":"https://api.github.com/repos/NCAR/NWS_hydro_models/pulls/14","id":107256027,"html_url":"https://github.com/NCAR/NWS_hydro_models/pull/14","diff_url":"https://github.com/NCAR/NWS_hydro_models/pull/14.diff","patch_url":"https://github.com/NCAR/NWS_hydro_models/pull/14.patch","issue_url":"https://api.github.com/repos/NCAR/NWS_hydro_models/issues/14","number":14,"state":"open","locked":false,"title":"Simplified and clarified makefile","user":{"login":"lizaclark","id":5132040,"avatar_url":"https://avatars.githubusercontent.com/u/5132040?v=3","gravatar_id":"","url":"https://api.github.com/users/lizaclark","html_url":"https://github.com/lizaclark","followers_url":"https://api.github.com/users/lizaclark/followers","following_url":"https://api.github.com/users/lizaclark/following{/other_user}","gists_url":"https://api.github.com/users/lizaclark/gists{/gist_id}","starred_url":"https://api.github.com/users/lizaclark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lizaclark/subscriptions","organizations_url":"https://api.github.com/users/lizaclark/orgs","repos_url":"https://api.github.com/users/lizaclark/repos","events_url":"https://api.github.com/users/lizaclark/events{/privacy}","received_events_url":"https://api.github.com/users/lizaclark/received_events","type":"User","site_admin":false},"body":"This PR has 3 primary changes:\r\n1. Following on issue #13, this PR removes the options to use `-autodouble` with `ifort`, `-r8` with PGI compilers, and `-fdefault-real-8` with `gfortran` because results are only reproducible between compilers without these flags.\r\n2. If the `FC` and `FC77` variables were set to a full executable in original Makefile, the `if` statements would not be triggered and compiler flags would not be assigned. To get around this, this PR sets separate variables `FCEXE` and `FC77EXE` to allow user to set a compiler executable path without impacting flag definitions. I moved these variable definitions to the top of the Makefile so that users will be more likely to see that they need to set these values.\r\n3. General clean-up, removal of commented code, addition of documentation.","created_at":"2017-02-21T19:02:55Z","updated_at":"2017-02-21T19:02:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/NCAR/NWS_hydro_models/pulls/14/commits","review_comments_url":"https://api.github.com/repos/NCAR/NWS_hydro_models/pulls/14/comments","review_comment_url":"https://api.github.com/repos/NCAR/NWS_hydro_models/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NCAR/NWS_hydro_models/issues/14/comments","statuses_url":"https://api.github.com/repos/NCAR/NWS_hydro_models/statuses/bc1682f73c261893f1a8a1b78e952d07f393edca","head":{"label":"lizaclark:feature/exe_in_make","ref":"feature/exe_in_make","sha":"bc1682f73c261893f1a8a1b78e952d07f393edca","user":{"login":"lizaclark","id":5132040,"avatar_url":"https://avatars.githubusercontent.com/u/5132040?v=3","gravatar_id":"","url":"https://api.github.com/users/lizaclark","html_url":"https://github.com/lizaclark","followers_url":"https://api.github.com/users/lizaclark/followers","following_url":"https://api.github.com/users/lizaclark/following{/other_user}","gists_url":"https://api.github.com/users/lizaclark/gists{/gist_id}","starred_url":"https://api.github.com/users/lizaclark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lizaclark/subscriptions","organizations_url":"https://api.github.com/users/lizaclark/orgs","repos_url":"https://api.github.com/users/lizaclark/repos","events_url":"https://api.github.com/users/lizaclark/events{/privacy}","received_events_url":"https://api.github.com/users/lizaclark/received_events","type":"User","site_admin":false},"repo":{"id":82234954,"name":"NWS_hydro_models","full_name":"lizaclark/NWS_hydro_models","owner":{"login":"lizaclark","id":5132040,"avatar_url":"https://avatars.githubusercontent.com/u/5132040?v=3","gravatar_id":"","url":"https://api.github.com/users/lizaclark","html_url":"https://github.com/lizaclark","followers_url":"https://api.github.com/users/lizaclark/followers","following_url":"https://api.github.com/users/lizaclark/following{/other_user}","gists_url":"https://api.github.com/users/lizaclark/gists{/gist_id}","starred_url":"https://api.github.com/users/lizaclark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lizaclark/subscriptions","organizations_url":"https://api.github.com/users/lizaclark/orgs","repos_url":"https://api.github.com/users/lizaclark/repos","events_url":"https://api.github.com/users/lizaclark/events{/privacy}","received_events_url":"https://api.github.com/users/lizaclark/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lizaclark/NWS_hydro_models","description":"Hydrology models adapted from NWS conceptual modeling approaches and code. ","fork":true,"url":"https://api.github.com/repos/lizaclark/NWS_hydro_models","forks_url":"https://api.github.com/repos/lizaclark/NWS_hydro_models/forks","keys_url":"https://api.github.com/repos/lizaclark/NWS_hydro_models/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lizaclark/NWS_hydro_models/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lizaclark/NWS_hydro_models/teams","hooks_url":"https://api.github.com/repos/lizaclark/NWS_hydro_models/hooks","issue_events_url":"https://api.github.com/repos/lizaclark/NWS_hydro_models/issues/events{/number}","events_url":"https://api.github.com/repos/lizaclark/NWS_hydro_models/events","assignees_url":"https://api.github.com/repos/lizaclark/NWS_hydro_models/assignees{/user}","branches_url":"https://api.github.com/repos/lizaclark/NWS_hydro_models/branches{/branch}","tags_url":"https://api.github.com/repos/lizaclark/NWS_hydro_models/tags","blobs_url":"https://api.github.com/repos/lizaclark/NWS_hydro_models/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lizaclark/NWS_hydro_models/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lizaclark/NWS_hydro_models/git/refs{/sha}","trees_url":"https://api.github.com/repos/lizaclark/NWS_hydro_models/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lizaclark/NWS_hydro_models/statuses/{sha}","languages_url":"https://api.github.com/repos/lizaclark/NWS_hydro_models/languages","stargazers_url":"https://api.github.com/repos/lizaclark/NWS_hydro_models/stargazers","contributors_url":"https://api.github.com/repos/lizaclark/NWS_hydro_models/contributors","subscribers_url":"https://api.github.com/repos/lizaclark/NWS_hydro_models/subscribers","subscription_url":"https://api.github.com/repos/lizaclark/NWS_hydro_models/subscription","commits_url":"https://api.github.com/repos/lizaclark/NWS_hydro_models/commits{/sha}","git_commits_url":"https://api.github.com/repos/lizaclark/NWS_hydro_models/git/commits{/sha}","comments_url":"https://api.github.com/repos/lizaclark/NWS_hydro_models/comments{/number}","issue_comment_url":"https://api.github.com/repos/lizaclark/NWS_hydro_models/issues/comments{/number}","contents_url":"https://api.github.com/repos/lizaclark/NWS_hydro_models/contents/{+path}","compare_url":"https://api.github.com/repos/lizaclark/NWS_hydro_models/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lizaclark/NWS_hydro_models/merges","archive_url":"https://api.github.com/repos/lizaclark/NWS_hydro_models/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lizaclark/NWS_hydro_models/downloads","issues_url":"https://api.github.com/repos/lizaclark/NWS_hydro_models/issues{/number}","pulls_url":"https://api.github.com/repos/lizaclark/NWS_hydro_models/pulls{/number}","milestones_url":"https://api.github.com/repos/lizaclark/NWS_hydro_models/milestones{/number}","notifications_url":"https://api.github.com/repos/lizaclark/NWS_hydro_models/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lizaclark/NWS_hydro_models/labels{/name}","releases_url":"https://api.github.com/repos/lizaclark/NWS_hydro_models/releases{/id}","deployments_url":"https://api.github.com/repos/lizaclark/NWS_hydro_models/deployments","created_at":"2017-02-16T23:07:26Z","updated_at":"2017-02-16T23:07:28Z","pushed_at":"2017-02-21T18:56:37Z","git_url":"git://github.com/lizaclark/NWS_hydro_models.git","ssh_url":"git@github.com:lizaclark/NWS_hydro_models.git","clone_url":"https://github.com/lizaclark/NWS_hydro_models.git","svn_url":"https://github.com/lizaclark/NWS_hydro_models","homepage":null,"size":18654,"stargazers_count":0,"watchers_count":0,"language":"Fortran","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NCAR:SHARP","ref":"SHARP","sha":"0aab025697c4d92dc22e59b89820f2e4de767291","user":{"login":"NCAR","id":2007542,"avatar_url":"https://avatars.githubusercontent.com/u/2007542?v=3","gravatar_id":"","url":"https://api.github.com/users/NCAR","html_url":"https://github.com/NCAR","followers_url":"https://api.github.com/users/NCAR/followers","following_url":"https://api.github.com/users/NCAR/following{/other_user}","gists_url":"https://api.github.com/users/NCAR/gists{/gist_id}","starred_url":"https://api.github.com/users/NCAR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NCAR/subscriptions","organizations_url":"https://api.github.com/users/NCAR/orgs","repos_url":"https://api.github.com/users/NCAR/repos","events_url":"https://api.github.com/users/NCAR/events{/privacy}","received_events_url":"https://api.github.com/users/NCAR/received_events","type":"Organization","site_admin":false},"repo":{"id":68627818,"name":"NWS_hydro_models","full_name":"NCAR/NWS_hydro_models","owner":{"login":"NCAR","id":2007542,"avatar_url":"https://avatars.githubusercontent.com/u/2007542?v=3","gravatar_id":"","url":"https://api.github.com/users/NCAR","html_url":"https://github.com/NCAR","followers_url":"https://api.github.com/users/NCAR/followers","following_url":"https://api.github.com/users/NCAR/following{/other_user}","gists_url":"https://api.github.com/users/NCAR/gists{/gist_id}","starred_url":"https://api.github.com/users/NCAR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NCAR/subscriptions","organizations_url":"https://api.github.com/users/NCAR/orgs","repos_url":"https://api.github.com/users/NCAR/repos","events_url":"https://api.github.com/users/NCAR/events{/privacy}","received_events_url":"https://api.github.com/users/NCAR/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NCAR/NWS_hydro_models","description":"Hydrology models adapted from NWS conceptual modeling approaches and code. ","fork":false,"url":"https://api.github.com/repos/NCAR/NWS_hydro_models","forks_url":"https://api.github.com/repos/NCAR/NWS_hydro_models/forks","keys_url":"https://api.github.com/repos/NCAR/NWS_hydro_models/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NCAR/NWS_hydro_models/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NCAR/NWS_hydro_models/teams","hooks_url":"https://api.github.com/repos/NCAR/NWS_hydro_models/hooks","issue_events_url":"https://api.github.com/repos/NCAR/NWS_hydro_models/issues/events{/number}","events_url":"https://api.github.com/repos/NCAR/NWS_hydro_models/events","assignees_url":"https://api.github.com/repos/NCAR/NWS_hydro_models/assignees{/user}","branches_url":"https://api.github.com/repos/NCAR/NWS_hydro_models/branches{/branch}","tags_url":"https://api.github.com/repos/NCAR/NWS_hydro_models/tags","blobs_url":"https://api.github.com/repos/NCAR/NWS_hydro_models/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NCAR/NWS_hydro_models/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NCAR/NWS_hydro_models/git/refs{/sha}","trees_url":"https://api.github.com/repos/NCAR/NWS_hydro_models/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NCAR/NWS_hydro_models/statuses/{sha}","languages_url":"https://api.github.com/repos/NCAR/NWS_hydro_models/languages","stargazers_url":"https://api.github.com/repos/NCAR/NWS_hydro_models/stargazers","contributors_url":"https://api.github.com/repos/NCAR/NWS_hydro_models/contributors","subscribers_url":"https://api.github.com/repos/NCAR/NWS_hydro_models/subscribers","subscription_url":"https://api.github.com/repos/NCAR/NWS_hydro_models/subscription","commits_url":"https://api.github.com/repos/NCAR/NWS_hydro_models/commits{/sha}","git_commits_url":"https://api.github.com/repos/NCAR/NWS_hydro_models/git/commits{/sha}","comments_url":"https://api.github.com/repos/NCAR/NWS_hydro_models/comments{/number}","issue_comment_url":"https://api.github.com/repos/NCAR/NWS_hydro_models/issues/comments{/number}","contents_url":"https://api.github.com/repos/NCAR/NWS_hydro_models/contents/{+path}","compare_url":"https://api.github.com/repos/NCAR/NWS_hydro_models/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NCAR/NWS_hydro_models/merges","archive_url":"https://api.github.com/repos/NCAR/NWS_hydro_models/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NCAR/NWS_hydro_models/downloads","issues_url":"https://api.github.com/repos/NCAR/NWS_hydro_models/issues{/number}","pulls_url":"https://api.github.com/repos/NCAR/NWS_hydro_models/pulls{/number}","milestones_url":"https://api.github.com/repos/NCAR/NWS_hydro_models/milestones{/number}","notifications_url":"https://api.github.com/repos/NCAR/NWS_hydro_models/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NCAR/NWS_hydro_models/labels{/name}","releases_url":"https://api.github.com/repos/NCAR/NWS_hydro_models/releases{/id}","deployments_url":"https://api.github.com/repos/NCAR/NWS_hydro_models/deployments","created_at":"2016-09-19T17:10:34Z","updated_at":"2016-11-19T15:17:04Z","pushed_at":"2017-02-17T19:39:55Z","git_url":"git://github.com/NCAR/NWS_hydro_models.git","ssh_url":"git@github.com:NCAR/NWS_hydro_models.git","clone_url":"https://github.com/NCAR/NWS_hydro_models.git","svn_url":"https://github.com/NCAR/NWS_hydro_models","homepage":null,"size":18655,"stargazers_count":1,"watchers_count":1,"language":"FORTRAN","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":5,"forks":3,"open_issues":5,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NCAR/NWS_hydro_models/pulls/14"},"html":{"href":"https://github.com/NCAR/NWS_hydro_models/pull/14"},"issue":{"href":"https://api.github.com/repos/NCAR/NWS_hydro_models/issues/14"},"comments":{"href":"https://api.github.com/repos/NCAR/NWS_hydro_models/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/NCAR/NWS_hydro_models/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/NCAR/NWS_hydro_models/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NCAR/NWS_hydro_models/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/NCAR/NWS_hydro_models/statuses/bc1682f73c261893f1a8a1b78e952d07f393edca"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":54,"deletions":40,"changed_files":1}}
{"actor":{"display_login":"lizaclark"}}