{"action":"created","comment":{"url":"https://api.github.com/repos/d2si-oss/terraform-modules/pulls/comments/152687476","pull_request_review_id":78588211,"id":152687476,"diff_hunk":"@@ -52,6 +52,18 @@ This module sets up an AWS backbone base infrastructure.\n   VPC CIDR block.\n   - default: none\n \n+- `vgw_id` (string)\n+\n+  Id ot the virtual gateway to attach to the VPC (`\"\"`: no VGW)","path":"aws/backbone/README.md","position":6,"original_position":6,"commit_id":"5c6c8c021c1ef0ea7b08a036c226da1d8f2086d5","original_commit_id":"5c6c8c021c1ef0ea7b08a036c226da1d8f2086d5","user":{"login":"lbernail","id":5391707,"avatar_url":"https://avatars1.githubusercontent.com/u/5391707?v=4","gravatar_id":"","url":"https://api.github.com/users/lbernail","html_url":"https://github.com/lbernail","followers_url":"https://api.github.com/users/lbernail/followers","following_url":"https://api.github.com/users/lbernail/following{/other_user}","gists_url":"https://api.github.com/users/lbernail/gists{/gist_id}","starred_url":"https://api.github.com/users/lbernail/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lbernail/subscriptions","organizations_url":"https://api.github.com/users/lbernail/orgs","repos_url":"https://api.github.com/users/lbernail/repos","events_url":"https://api.github.com/users/lbernail/events{/privacy}","received_events_url":"https://api.github.com/users/lbernail/received_events","type":"User","site_admin":false},"body":"Yes sure","created_at":"2017-11-22T21:56:45Z","updated_at":"2017-11-22T21:56:45Z","html_url":"https://github.com/d2si-oss/terraform-modules/pull/12#discussion_r152687476","pull_request_url":"https://api.github.com/repos/d2si-oss/terraform-modules/pulls/12","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/d2si-oss/terraform-modules/pulls/comments/152687476"},"html":{"href":"https://github.com/d2si-oss/terraform-modules/pull/12#discussion_r152687476"},"pull_request":{"href":"https://api.github.com/repos/d2si-oss/terraform-modules/pulls/12"}},"in_reply_to_id":152646810},"pull_request":{"url":"https://api.github.com/repos/d2si-oss/terraform-modules/pulls/12","id":152273023,"html_url":"https://github.com/d2si-oss/terraform-modules/pull/12","diff_url":"https://github.com/d2si-oss/terraform-modules/pull/12.diff","patch_url":"https://github.com/d2si-oss/terraform-modules/pull/12.patch","issue_url":"https://api.github.com/repos/d2si-oss/terraform-modules/issues/12","number":12,"state":"open","locked":false,"title":"Option to manage VGW","user":{"login":"lbernail","id":5391707,"avatar_url":"https://avatars1.githubusercontent.com/u/5391707?v=4","gravatar_id":"","url":"https://api.github.com/users/lbernail","html_url":"https://github.com/lbernail","followers_url":"https://api.github.com/users/lbernail/followers","following_url":"https://api.github.com/users/lbernail/following{/other_user}","gists_url":"https://api.github.com/users/lbernail/gists{/gist_id}","starred_url":"https://api.github.com/users/lbernail/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lbernail/subscriptions","organizations_url":"https://api.github.com/users/lbernail/orgs","repos_url":"https://api.github.com/users/lbernail/repos","events_url":"https://api.github.com/users/lbernail/events{/privacy}","received_events_url":"https://api.github.com/users/lbernail/received_events","type":"User","site_admin":false},"body":"Add possibility to attach a VGW and configure route propagation\r\n\r\nThe VGW itself is not managed by terraform because of VPN/Directconnect lifecycles (destroying a VGW would mean destroying VPN connections and VIF, which is usually not wanted). The idea is to create and configure the VGW outside of this stack and to reference it (directly or using a datasource).\r\n\r\nTwo configuration options:\r\n\r\n- vgw_id: id of the vgw to attach (default=\"\" => no vgw)\r\n- vgw_prop: configuration of route propagation (all, private or none, default=all)","created_at":"2017-11-13T15:48:27Z","updated_at":"2017-11-22T21:56:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9fe36fbada572295aef72b8f60e13b9073268af5","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/d2si-oss/terraform-modules/pulls/12/commits","review_comments_url":"https://api.github.com/repos/d2si-oss/terraform-modules/pulls/12/comments","review_comment_url":"https://api.github.com/repos/d2si-oss/terraform-modules/pulls/comments{/number}","comments_url":"https://api.github.com/repos/d2si-oss/terraform-modules/issues/12/comments","statuses_url":"https://api.github.com/repos/d2si-oss/terraform-modules/statuses/5c6c8c021c1ef0ea7b08a036c226da1d8f2086d5","head":{"label":"d2si-oss:features/vgw","ref":"features/vgw","sha":"5c6c8c021c1ef0ea7b08a036c226da1d8f2086d5","user":{"login":"d2si-oss","id":25930129,"avatar_url":"https://avatars0.githubusercontent.com/u/25930129?v=4","gravatar_id":"","url":"https://api.github.com/users/d2si-oss","html_url":"https://github.com/d2si-oss","followers_url":"https://api.github.com/users/d2si-oss/followers","following_url":"https://api.github.com/users/d2si-oss/following{/other_user}","gists_url":"https://api.github.com/users/d2si-oss/gists{/gist_id}","starred_url":"https://api.github.com/users/d2si-oss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d2si-oss/subscriptions","organizations_url":"https://api.github.com/users/d2si-oss/orgs","repos_url":"https://api.github.com/users/d2si-oss/repos","events_url":"https://api.github.com/users/d2si-oss/events{/privacy}","received_events_url":"https://api.github.com/users/d2si-oss/received_events","type":"Organization","site_admin":false},"repo":{"id":83289165,"name":"terraform-modules","full_name":"d2si-oss/terraform-modules","owner":{"login":"d2si-oss","id":25930129,"avatar_url":"https://avatars0.githubusercontent.com/u/25930129?v=4","gravatar_id":"","url":"https://api.github.com/users/d2si-oss","html_url":"https://github.com/d2si-oss","followers_url":"https://api.github.com/users/d2si-oss/followers","following_url":"https://api.github.com/users/d2si-oss/following{/other_user}","gists_url":"https://api.github.com/users/d2si-oss/gists{/gist_id}","starred_url":"https://api.github.com/users/d2si-oss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d2si-oss/subscriptions","organizations_url":"https://api.github.com/users/d2si-oss/orgs","repos_url":"https://api.github.com/users/d2si-oss/repos","events_url":"https://api.github.com/users/d2si-oss/events{/privacy}","received_events_url":"https://api.github.com/users/d2si-oss/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/d2si-oss/terraform-modules","description":"Reusable Terraform modules","fork":false,"url":"https://api.github.com/repos/d2si-oss/terraform-modules","forks_url":"https://api.github.com/repos/d2si-oss/terraform-modules/forks","keys_url":"https://api.github.com/repos/d2si-oss/terraform-modules/keys{/key_id}","collaborators_url":"https://api.github.com/repos/d2si-oss/terraform-modules/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/d2si-oss/terraform-modules/teams","hooks_url":"https://api.github.com/repos/d2si-oss/terraform-modules/hooks","issue_events_url":"https://api.github.com/repos/d2si-oss/terraform-modules/issues/events{/number}","events_url":"https://api.github.com/repos/d2si-oss/terraform-modules/events","assignees_url":"https://api.github.com/repos/d2si-oss/terraform-modules/assignees{/user}","branches_url":"https://api.github.com/repos/d2si-oss/terraform-modules/branches{/branch}","tags_url":"https://api.github.com/repos/d2si-oss/terraform-modules/tags","blobs_url":"https://api.github.com/repos/d2si-oss/terraform-modules/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/d2si-oss/terraform-modules/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/d2si-oss/terraform-modules/git/refs{/sha}","trees_url":"https://api.github.com/repos/d2si-oss/terraform-modules/git/trees{/sha}","statuses_url":"https://api.github.com/repos/d2si-oss/terraform-modules/statuses/{sha}","languages_url":"https://api.github.com/repos/d2si-oss/terraform-modules/languages","stargazers_url":"https://api.github.com/repos/d2si-oss/terraform-modules/stargazers","contributors_url":"https://api.github.com/repos/d2si-oss/terraform-modules/contributors","subscribers_url":"https://api.github.com/repos/d2si-oss/terraform-modules/subscribers","subscription_url":"https://api.github.com/repos/d2si-oss/terraform-modules/subscription","commits_url":"https://api.github.com/repos/d2si-oss/terraform-modules/commits{/sha}","git_commits_url":"https://api.github.com/repos/d2si-oss/terraform-modules/git/commits{/sha}","comments_url":"https://api.github.com/repos/d2si-oss/terraform-modules/comments{/number}","issue_comment_url":"https://api.github.com/repos/d2si-oss/terraform-modules/issues/comments{/number}","contents_url":"https://api.github.com/repos/d2si-oss/terraform-modules/contents/{+path}","compare_url":"https://api.github.com/repos/d2si-oss/terraform-modules/compare/{base}...{head}","merges_url":"https://api.github.com/repos/d2si-oss/terraform-modules/merges","archive_url":"https://api.github.com/repos/d2si-oss/terraform-modules/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/d2si-oss/terraform-modules/downloads","issues_url":"https://api.github.com/repos/d2si-oss/terraform-modules/issues{/number}","pulls_url":"https://api.github.com/repos/d2si-oss/terraform-modules/pulls{/number}","milestones_url":"https://api.github.com/repos/d2si-oss/terraform-modules/milestones{/number}","notifications_url":"https://api.github.com/repos/d2si-oss/terraform-modules/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/d2si-oss/terraform-modules/labels{/name}","releases_url":"https://api.github.com/repos/d2si-oss/terraform-modules/releases{/id}","deployments_url":"https://api.github.com/repos/d2si-oss/terraform-modules/deployments","created_at":"2017-02-27T08:55:43Z","updated_at":"2017-10-27T09:31:57Z","pushed_at":"2017-11-22T14:56:09Z","git_url":"git://github.com/d2si-oss/terraform-modules.git","ssh_url":"git@github.com:d2si-oss/terraform-modules.git","clone_url":"https://github.com/d2si-oss/terraform-modules.git","svn_url":"https://github.com/d2si-oss/terraform-modules","homepage":null,"size":32,"stargazers_count":9,"watchers_count":9,"language":"HCL","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":2,"forks":3,"open_issues":2,"watchers":9,"default_branch":"master"}},"base":{"label":"d2si-oss:master","ref":"master","sha":"59d8180ee232a662a967b6a58f3bc519f0fb9cfb","user":{"login":"d2si-oss","id":25930129,"avatar_url":"https://avatars0.githubusercontent.com/u/25930129?v=4","gravatar_id":"","url":"https://api.github.com/users/d2si-oss","html_url":"https://github.com/d2si-oss","followers_url":"https://api.github.com/users/d2si-oss/followers","following_url":"https://api.github.com/users/d2si-oss/following{/other_user}","gists_url":"https://api.github.com/users/d2si-oss/gists{/gist_id}","starred_url":"https://api.github.com/users/d2si-oss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d2si-oss/subscriptions","organizations_url":"https://api.github.com/users/d2si-oss/orgs","repos_url":"https://api.github.com/users/d2si-oss/repos","events_url":"https://api.github.com/users/d2si-oss/events{/privacy}","received_events_url":"https://api.github.com/users/d2si-oss/received_events","type":"Organization","site_admin":false},"repo":{"id":83289165,"name":"terraform-modules","full_name":"d2si-oss/terraform-modules","owner":{"login":"d2si-oss","id":25930129,"avatar_url":"https://avatars0.githubusercontent.com/u/25930129?v=4","gravatar_id":"","url":"https://api.github.com/users/d2si-oss","html_url":"https://github.com/d2si-oss","followers_url":"https://api.github.com/users/d2si-oss/followers","following_url":"https://api.github.com/users/d2si-oss/following{/other_user}","gists_url":"https://api.github.com/users/d2si-oss/gists{/gist_id}","starred_url":"https://api.github.com/users/d2si-oss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d2si-oss/subscriptions","organizations_url":"https://api.github.com/users/d2si-oss/orgs","repos_url":"https://api.github.com/users/d2si-oss/repos","events_url":"https://api.github.com/users/d2si-oss/events{/privacy}","received_events_url":"https://api.github.com/users/d2si-oss/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/d2si-oss/terraform-modules","description":"Reusable Terraform modules","fork":false,"url":"https://api.github.com/repos/d2si-oss/terraform-modules","forks_url":"https://api.github.com/repos/d2si-oss/terraform-modules/forks","keys_url":"https://api.github.com/repos/d2si-oss/terraform-modules/keys{/key_id}","collaborators_url":"https://api.github.com/repos/d2si-oss/terraform-modules/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/d2si-oss/terraform-modules/teams","hooks_url":"https://api.github.com/repos/d2si-oss/terraform-modules/hooks","issue_events_url":"https://api.github.com/repos/d2si-oss/terraform-modules/issues/events{/number}","events_url":"https://api.github.com/repos/d2si-oss/terraform-modules/events","assignees_url":"https://api.github.com/repos/d2si-oss/terraform-modules/assignees{/user}","branches_url":"https://api.github.com/repos/d2si-oss/terraform-modules/branches{/branch}","tags_url":"https://api.github.com/repos/d2si-oss/terraform-modules/tags","blobs_url":"https://api.github.com/repos/d2si-oss/terraform-modules/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/d2si-oss/terraform-modules/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/d2si-oss/terraform-modules/git/refs{/sha}","trees_url":"https://api.github.com/repos/d2si-oss/terraform-modules/git/trees{/sha}","statuses_url":"https://api.github.com/repos/d2si-oss/terraform-modules/statuses/{sha}","languages_url":"https://api.github.com/repos/d2si-oss/terraform-modules/languages","stargazers_url":"https://api.github.com/repos/d2si-oss/terraform-modules/stargazers","contributors_url":"https://api.github.com/repos/d2si-oss/terraform-modules/contributors","subscribers_url":"https://api.github.com/repos/d2si-oss/terraform-modules/subscribers","subscription_url":"https://api.github.com/repos/d2si-oss/terraform-modules/subscription","commits_url":"https://api.github.com/repos/d2si-oss/terraform-modules/commits{/sha}","git_commits_url":"https://api.github.com/repos/d2si-oss/terraform-modules/git/commits{/sha}","comments_url":"https://api.github.com/repos/d2si-oss/terraform-modules/comments{/number}","issue_comment_url":"https://api.github.com/repos/d2si-oss/terraform-modules/issues/comments{/number}","contents_url":"https://api.github.com/repos/d2si-oss/terraform-modules/contents/{+path}","compare_url":"https://api.github.com/repos/d2si-oss/terraform-modules/compare/{base}...{head}","merges_url":"https://api.github.com/repos/d2si-oss/terraform-modules/merges","archive_url":"https://api.github.com/repos/d2si-oss/terraform-modules/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/d2si-oss/terraform-modules/downloads","issues_url":"https://api.github.com/repos/d2si-oss/terraform-modules/issues{/number}","pulls_url":"https://api.github.com/repos/d2si-oss/terraform-modules/pulls{/number}","milestones_url":"https://api.github.com/repos/d2si-oss/terraform-modules/milestones{/number}","notifications_url":"https://api.github.com/repos/d2si-oss/terraform-modules/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/d2si-oss/terraform-modules/labels{/name}","releases_url":"https://api.github.com/repos/d2si-oss/terraform-modules/releases{/id}","deployments_url":"https://api.github.com/repos/d2si-oss/terraform-modules/deployments","created_at":"2017-02-27T08:55:43Z","updated_at":"2017-10-27T09:31:57Z","pushed_at":"2017-11-22T14:56:09Z","git_url":"git://github.com/d2si-oss/terraform-modules.git","ssh_url":"git@github.com:d2si-oss/terraform-modules.git","clone_url":"https://github.com/d2si-oss/terraform-modules.git","svn_url":"https://github.com/d2si-oss/terraform-modules","homepage":null,"size":32,"stargazers_count":9,"watchers_count":9,"language":"HCL","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":2,"forks":3,"open_issues":2,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/d2si-oss/terraform-modules/pulls/12"},"html":{"href":"https://github.com/d2si-oss/terraform-modules/pull/12"},"issue":{"href":"https://api.github.com/repos/d2si-oss/terraform-modules/issues/12"},"comments":{"href":"https://api.github.com/repos/d2si-oss/terraform-modules/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/d2si-oss/terraform-modules/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/d2si-oss/terraform-modules/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/d2si-oss/terraform-modules/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/d2si-oss/terraform-modules/statuses/5c6c8c021c1ef0ea7b08a036c226da1d8f2086d5"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"lbernail"}}