{"action":"created","comment":{"url":"https://api.github.com/repos/LLNL/spack/pulls/comments/145792968","pull_request_review_id":70646338,"id":145792968,"diff_hunk":"@@ -241,7 +241,11 @@ def link_one(spec, path, link=os.symlink, verbose=False):\n                     continue    # silence these\n                 tty.warn(\"Skipping existing file: %s\" % dst)\n                 continue\n-            link(src, dst)\n+            if os.path.islink(src):\n+                linkto = os.readlink(src)","path":"lib/spack/spack/cmd/view.py","position":6,"original_position":6,"commit_id":"5c194f10ac2f5ed4e877df31b4b2a23c78f4fa3b","original_commit_id":"5c194f10ac2f5ed4e877df31b4b2a23c78f4fa3b","user":{"login":"mathstuf","id":97253,"avatar_url":"https://avatars2.githubusercontent.com/u/97253?v=4","gravatar_id":"","url":"https://api.github.com/users/mathstuf","html_url":"https://github.com/mathstuf","followers_url":"https://api.github.com/users/mathstuf/followers","following_url":"https://api.github.com/users/mathstuf/following{/other_user}","gists_url":"https://api.github.com/users/mathstuf/gists{/gist_id}","starred_url":"https://api.github.com/users/mathstuf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mathstuf/subscriptions","organizations_url":"https://api.github.com/users/mathstuf/orgs","repos_url":"https://api.github.com/users/mathstuf/repos","events_url":"https://api.github.com/users/mathstuf/events{/privacy}","received_events_url":"https://api.github.com/users/mathstuf/received_events","type":"User","site_admin":false},"body":"Should we resolve the path that is returned here? Or are we trusting that the path it points to will be linked locally as well?","created_at":"2017-10-19T18:57:30Z","updated_at":"2017-10-19T18:58:35Z","html_url":"https://github.com/LLNL/spack/pull/5823#discussion_r145792968","pull_request_url":"https://api.github.com/repos/LLNL/spack/pulls/5823","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/LLNL/spack/pulls/comments/145792968"},"html":{"href":"https://github.com/LLNL/spack/pull/5823#discussion_r145792968"},"pull_request":{"href":"https://api.github.com/repos/LLNL/spack/pulls/5823"}}},"pull_request":{"url":"https://api.github.com/repos/LLNL/spack/pulls/5823","id":147624146,"html_url":"https://github.com/LLNL/spack/pull/5823","diff_url":"https://github.com/LLNL/spack/pull/5823.diff","patch_url":"https://github.com/LLNL/spack/pull/5823.patch","issue_url":"https://api.github.com/repos/LLNL/spack/issues/5823","number":5823,"state":"closed","locked":false,"title":"Update view command to create symbolic links when the source itself is a symbolic link.","user":{"login":"gartung","id":4292184,"avatar_url":"https://avatars3.githubusercontent.com/u/4292184?v=4","gravatar_id":"","url":"https://api.github.com/users/gartung","html_url":"https://github.com/gartung","followers_url":"https://api.github.com/users/gartung/followers","following_url":"https://api.github.com/users/gartung/following{/other_user}","gists_url":"https://api.github.com/users/gartung/gists{/gist_id}","starred_url":"https://api.github.com/users/gartung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gartung/subscriptions","organizations_url":"https://api.github.com/users/gartung/orgs","repos_url":"https://api.github.com/users/gartung/repos","events_url":"https://api.github.com/users/gartung/events{/privacy}","received_events_url":"https://api.github.com/users/gartung/received_events","type":"User","site_admin":false},"body":"Update view command to create symbolic links when the source itself is a symbolic link. This avoids duplicate copied of libraries when the symbolic link is the shortened version of the library name.","created_at":"2017-10-19T17:57:07Z","updated_at":"2017-10-19T18:58:35Z","closed_at":"2017-10-19T18:57:33Z","merged_at":null,"merge_commit_sha":"27611f2c57b35b96670d38832b397a5a65ea065e","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/LLNL/spack/pulls/5823/commits","review_comments_url":"https://api.github.com/repos/LLNL/spack/pulls/5823/comments","review_comment_url":"https://api.github.com/repos/LLNL/spack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LLNL/spack/issues/5823/comments","statuses_url":"https://api.github.com/repos/LLNL/spack/statuses/5c194f10ac2f5ed4e877df31b4b2a23c78f4fa3b","head":{"label":"gartung:update-view-cmd","ref":"update-view-cmd","sha":"5c194f10ac2f5ed4e877df31b4b2a23c78f4fa3b","user":{"login":"gartung","id":4292184,"avatar_url":"https://avatars3.githubusercontent.com/u/4292184?v=4","gravatar_id":"","url":"https://api.github.com/users/gartung","html_url":"https://github.com/gartung","followers_url":"https://api.github.com/users/gartung/followers","following_url":"https://api.github.com/users/gartung/following{/other_user}","gists_url":"https://api.github.com/users/gartung/gists{/gist_id}","starred_url":"https://api.github.com/users/gartung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gartung/subscriptions","organizations_url":"https://api.github.com/users/gartung/orgs","repos_url":"https://api.github.com/users/gartung/repos","events_url":"https://api.github.com/users/gartung/events{/privacy}","received_events_url":"https://api.github.com/users/gartung/received_events","type":"User","site_admin":false},"repo":{"id":48127611,"name":"spack","full_name":"gartung/spack","owner":{"login":"gartung","id":4292184,"avatar_url":"https://avatars3.githubusercontent.com/u/4292184?v=4","gravatar_id":"","url":"https://api.github.com/users/gartung","html_url":"https://github.com/gartung","followers_url":"https://api.github.com/users/gartung/followers","following_url":"https://api.github.com/users/gartung/following{/other_user}","gists_url":"https://api.github.com/users/gartung/gists{/gist_id}","starred_url":"https://api.github.com/users/gartung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gartung/subscriptions","organizations_url":"https://api.github.com/users/gartung/orgs","repos_url":"https://api.github.com/users/gartung/repos","events_url":"https://api.github.com/users/gartung/events{/privacy}","received_events_url":"https://api.github.com/users/gartung/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gartung/spack","description":"A flexible package manager designed to support multiple versions, configurations, platforms, and compilers.","fork":true,"url":"https://api.github.com/repos/gartung/spack","forks_url":"https://api.github.com/repos/gartung/spack/forks","keys_url":"https://api.github.com/repos/gartung/spack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gartung/spack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gartung/spack/teams","hooks_url":"https://api.github.com/repos/gartung/spack/hooks","issue_events_url":"https://api.github.com/repos/gartung/spack/issues/events{/number}","events_url":"https://api.github.com/repos/gartung/spack/events","assignees_url":"https://api.github.com/repos/gartung/spack/assignees{/user}","branches_url":"https://api.github.com/repos/gartung/spack/branches{/branch}","tags_url":"https://api.github.com/repos/gartung/spack/tags","blobs_url":"https://api.github.com/repos/gartung/spack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gartung/spack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gartung/spack/git/refs{/sha}","trees_url":"https://api.github.com/repos/gartung/spack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gartung/spack/statuses/{sha}","languages_url":"https://api.github.com/repos/gartung/spack/languages","stargazers_url":"https://api.github.com/repos/gartung/spack/stargazers","contributors_url":"https://api.github.com/repos/gartung/spack/contributors","subscribers_url":"https://api.github.com/repos/gartung/spack/subscribers","subscription_url":"https://api.github.com/repos/gartung/spack/subscription","commits_url":"https://api.github.com/repos/gartung/spack/commits{/sha}","git_commits_url":"https://api.github.com/repos/gartung/spack/git/commits{/sha}","comments_url":"https://api.github.com/repos/gartung/spack/comments{/number}","issue_comment_url":"https://api.github.com/repos/gartung/spack/issues/comments{/number}","contents_url":"https://api.github.com/repos/gartung/spack/contents/{+path}","compare_url":"https://api.github.com/repos/gartung/spack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gartung/spack/merges","archive_url":"https://api.github.com/repos/gartung/spack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gartung/spack/downloads","issues_url":"https://api.github.com/repos/gartung/spack/issues{/number}","pulls_url":"https://api.github.com/repos/gartung/spack/pulls{/number}","milestones_url":"https://api.github.com/repos/gartung/spack/milestones{/number}","notifications_url":"https://api.github.com/repos/gartung/spack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gartung/spack/labels{/name}","releases_url":"https://api.github.com/repos/gartung/spack/releases{/id}","deployments_url":"https://api.github.com/repos/gartung/spack/deployments","created_at":"2015-12-16T18:25:55Z","updated_at":"2016-02-11T16:11:43Z","pushed_at":"2017-10-19T17:59:09Z","git_url":"git://github.com/gartung/spack.git","ssh_url":"git@github.com:gartung/spack.git","clone_url":"https://github.com/gartung/spack.git","svn_url":"https://github.com/gartung/spack","homepage":"http://scalability-llnl.github.io/spack","size":34811,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"LLNL:develop","ref":"develop","sha":"a1c19f8389aa5135330042c72df36e603c1645db","user":{"login":"LLNL","id":5921419,"avatar_url":"https://avatars0.githubusercontent.com/u/5921419?v=4","gravatar_id":"","url":"https://api.github.com/users/LLNL","html_url":"https://github.com/LLNL","followers_url":"https://api.github.com/users/LLNL/followers","following_url":"https://api.github.com/users/LLNL/following{/other_user}","gists_url":"https://api.github.com/users/LLNL/gists{/gist_id}","starred_url":"https://api.github.com/users/LLNL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LLNL/subscriptions","organizations_url":"https://api.github.com/users/LLNL/orgs","repos_url":"https://api.github.com/users/LLNL/repos","events_url":"https://api.github.com/users/LLNL/events{/privacy}","received_events_url":"https://api.github.com/users/LLNL/received_events","type":"Organization","site_admin":false},"repo":{"id":15730865,"name":"spack","full_name":"LLNL/spack","owner":{"login":"LLNL","id":5921419,"avatar_url":"https://avatars0.githubusercontent.com/u/5921419?v=4","gravatar_id":"","url":"https://api.github.com/users/LLNL","html_url":"https://github.com/LLNL","followers_url":"https://api.github.com/users/LLNL/followers","following_url":"https://api.github.com/users/LLNL/following{/other_user}","gists_url":"https://api.github.com/users/LLNL/gists{/gist_id}","starred_url":"https://api.github.com/users/LLNL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LLNL/subscriptions","organizations_url":"https://api.github.com/users/LLNL/orgs","repos_url":"https://api.github.com/users/LLNL/repos","events_url":"https://api.github.com/users/LLNL/events{/privacy}","received_events_url":"https://api.github.com/users/LLNL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LLNL/spack","description":"A flexible package manager that supports multiple versions, configurations, platforms, and compilers.","fork":false,"url":"https://api.github.com/repos/LLNL/spack","forks_url":"https://api.github.com/repos/LLNL/spack/forks","keys_url":"https://api.github.com/repos/LLNL/spack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LLNL/spack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LLNL/spack/teams","hooks_url":"https://api.github.com/repos/LLNL/spack/hooks","issue_events_url":"https://api.github.com/repos/LLNL/spack/issues/events{/number}","events_url":"https://api.github.com/repos/LLNL/spack/events","assignees_url":"https://api.github.com/repos/LLNL/spack/assignees{/user}","branches_url":"https://api.github.com/repos/LLNL/spack/branches{/branch}","tags_url":"https://api.github.com/repos/LLNL/spack/tags","blobs_url":"https://api.github.com/repos/LLNL/spack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LLNL/spack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LLNL/spack/git/refs{/sha}","trees_url":"https://api.github.com/repos/LLNL/spack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LLNL/spack/statuses/{sha}","languages_url":"https://api.github.com/repos/LLNL/spack/languages","stargazers_url":"https://api.github.com/repos/LLNL/spack/stargazers","contributors_url":"https://api.github.com/repos/LLNL/spack/contributors","subscribers_url":"https://api.github.com/repos/LLNL/spack/subscribers","subscription_url":"https://api.github.com/repos/LLNL/spack/subscription","commits_url":"https://api.github.com/repos/LLNL/spack/commits{/sha}","git_commits_url":"https://api.github.com/repos/LLNL/spack/git/commits{/sha}","comments_url":"https://api.github.com/repos/LLNL/spack/comments{/number}","issue_comment_url":"https://api.github.com/repos/LLNL/spack/issues/comments{/number}","contents_url":"https://api.github.com/repos/LLNL/spack/contents/{+path}","compare_url":"https://api.github.com/repos/LLNL/spack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LLNL/spack/merges","archive_url":"https://api.github.com/repos/LLNL/spack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LLNL/spack/downloads","issues_url":"https://api.github.com/repos/LLNL/spack/issues{/number}","pulls_url":"https://api.github.com/repos/LLNL/spack/pulls{/number}","milestones_url":"https://api.github.com/repos/LLNL/spack/milestones{/number}","notifications_url":"https://api.github.com/repos/LLNL/spack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LLNL/spack/labels{/name}","releases_url":"https://api.github.com/repos/LLNL/spack/releases{/id}","deployments_url":"https://api.github.com/repos/LLNL/spack/deployments","created_at":"2014-01-08T09:22:12Z","updated_at":"2017-10-19T05:56:42Z","pushed_at":"2017-10-19T18:50:16Z","git_url":"git://github.com/LLNL/spack.git","ssh_url":"git@github.com:LLNL/spack.git","clone_url":"https://github.com/LLNL/spack.git","svn_url":"https://github.com/LLNL/spack","homepage":"https://spack.io","size":31176,"stargazers_count":378,"watchers_count":378,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":313,"mirror_url":null,"open_issues_count":772,"forks":313,"open_issues":772,"watchers":378,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/LLNL/spack/pulls/5823"},"html":{"href":"https://github.com/LLNL/spack/pull/5823"},"issue":{"href":"https://api.github.com/repos/LLNL/spack/issues/5823"},"comments":{"href":"https://api.github.com/repos/LLNL/spack/issues/5823/comments"},"review_comments":{"href":"https://api.github.com/repos/LLNL/spack/pulls/5823/comments"},"review_comment":{"href":"https://api.github.com/repos/LLNL/spack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LLNL/spack/pulls/5823/commits"},"statuses":{"href":"https://api.github.com/repos/LLNL/spack/statuses/5c194f10ac2f5ed4e877df31b4b2a23c78f4fa3b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mathstuf"}}