{"action":"created","comment":{"url":"https://api.github.com/repos/idyll-lang/idyll-default-components/pulls/comments/118711248","pull_request_review_id":40531429,"id":118711248,"diff_hunk":"@@ -0,0 +1,3 @@\n+components/","path":".npmignore","position":1,"original_position":1,"commit_id":"5d1fdf5acc02a23e90229e11653a72086b2981f8","original_commit_id":"5d1fdf5acc02a23e90229e11653a72086b2981f8","user":{"login":"rreusser","id":572717,"avatar_url":"https://avatars3.githubusercontent.com/u/572717?v=3","gravatar_id":"","url":"https://api.github.com/users/rreusser","html_url":"https://github.com/rreusser","followers_url":"https://api.github.com/users/rreusser/followers","following_url":"https://api.github.com/users/rreusser/following{/other_user}","gists_url":"https://api.github.com/users/rreusser/gists{/gist_id}","starred_url":"https://api.github.com/users/rreusser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rreusser/subscriptions","organizations_url":"https://api.github.com/users/rreusser/orgs","repos_url":"https://api.github.com/users/rreusser/repos","events_url":"https://api.github.com/users/rreusser/events{/privacy}","received_events_url":"https://api.github.com/users/rreusser/received_events","type":"User","site_admin":false},"body":"What are your feelings on leaving `components` *in* the npm directory? The source is pretty small, and to me an advantage is that you can go digging in `node_modules` and find the original source instead of just build files—which I actually do surprisingly often. Apologies that this was originally my suggestion, but upon thinking further, I've heard complaints of unnecessarily `.npmignored` files making things difficult, particularly for people who may work offline or with a sketchy connection.","created_at":"2017-05-26T14:14:18Z","updated_at":"2017-05-26T14:14:18Z","html_url":"https://github.com/idyll-lang/idyll-default-components/pull/5#discussion_r118711248","pull_request_url":"https://api.github.com/repos/idyll-lang/idyll-default-components/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/idyll-lang/idyll-default-components/pulls/comments/118711248"},"html":{"href":"https://github.com/idyll-lang/idyll-default-components/pull/5#discussion_r118711248"},"pull_request":{"href":"https://api.github.com/repos/idyll-lang/idyll-default-components/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/idyll-lang/idyll-default-components/pulls/5","id":122648242,"html_url":"https://github.com/idyll-lang/idyll-default-components/pull/5","diff_url":"https://github.com/idyll-lang/idyll-default-components/pull/5.diff","patch_url":"https://github.com/idyll-lang/idyll-default-components/pull/5.patch","issue_url":"https://api.github.com/repos/idyll-lang/idyll-default-components/issues/5","number":5,"state":"open","locked":false,"title":"Initial stab at generating built components at publish time","user":{"login":"bclinkinbeard","id":140343,"avatar_url":"https://avatars1.githubusercontent.com/u/140343?v=3","gravatar_id":"","url":"https://api.github.com/users/bclinkinbeard","html_url":"https://github.com/bclinkinbeard","followers_url":"https://api.github.com/users/bclinkinbeard/followers","following_url":"https://api.github.com/users/bclinkinbeard/following{/other_user}","gists_url":"https://api.github.com/users/bclinkinbeard/gists{/gist_id}","starred_url":"https://api.github.com/users/bclinkinbeard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bclinkinbeard/subscriptions","organizations_url":"https://api.github.com/users/bclinkinbeard/orgs","repos_url":"https://api.github.com/users/bclinkinbeard/repos","events_url":"https://api.github.com/users/bclinkinbeard/events{/privacy}","received_events_url":"https://api.github.com/users/bclinkinbeard/received_events","type":"User","site_admin":false},"body":"This probably isn't exactly right but it should be close. One thing to look at is what including a component would look like. I think other projects would have to do `require('idyll-default-components/lib/range')`, which is maybe OK but maybe could be improved?","created_at":"2017-05-26T13:57:09Z","updated_at":"2017-05-26T14:14:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f6b422219603302208bb25d520698cf59bd2bc94","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/idyll-lang/idyll-default-components/pulls/5/commits","review_comments_url":"https://api.github.com/repos/idyll-lang/idyll-default-components/pulls/5/comments","review_comment_url":"https://api.github.com/repos/idyll-lang/idyll-default-components/pulls/comments{/number}","comments_url":"https://api.github.com/repos/idyll-lang/idyll-default-components/issues/5/comments","statuses_url":"https://api.github.com/repos/idyll-lang/idyll-default-components/statuses/5d1fdf5acc02a23e90229e11653a72086b2981f8","head":{"label":"idyll-lang:prepublish","ref":"prepublish","sha":"5d1fdf5acc02a23e90229e11653a72086b2981f8","user":{"login":"idyll-lang","id":25518453,"avatar_url":"https://avatars0.githubusercontent.com/u/25518453?v=3","gravatar_id":"","url":"https://api.github.com/users/idyll-lang","html_url":"https://github.com/idyll-lang","followers_url":"https://api.github.com/users/idyll-lang/followers","following_url":"https://api.github.com/users/idyll-lang/following{/other_user}","gists_url":"https://api.github.com/users/idyll-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/idyll-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/idyll-lang/subscriptions","organizations_url":"https://api.github.com/users/idyll-lang/orgs","repos_url":"https://api.github.com/users/idyll-lang/repos","events_url":"https://api.github.com/users/idyll-lang/events{/privacy}","received_events_url":"https://api.github.com/users/idyll-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":89316153,"name":"idyll-default-components","full_name":"idyll-lang/idyll-default-components","owner":{"login":"idyll-lang","id":25518453,"avatar_url":"https://avatars0.githubusercontent.com/u/25518453?v=3","gravatar_id":"","url":"https://api.github.com/users/idyll-lang","html_url":"https://github.com/idyll-lang","followers_url":"https://api.github.com/users/idyll-lang/followers","following_url":"https://api.github.com/users/idyll-lang/following{/other_user}","gists_url":"https://api.github.com/users/idyll-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/idyll-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/idyll-lang/subscriptions","organizations_url":"https://api.github.com/users/idyll-lang/orgs","repos_url":"https://api.github.com/users/idyll-lang/repos","events_url":"https://api.github.com/users/idyll-lang/events{/privacy}","received_events_url":"https://api.github.com/users/idyll-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/idyll-lang/idyll-default-components","description":"Components that ship by default in new idyll projects","fork":false,"url":"https://api.github.com/repos/idyll-lang/idyll-default-components","forks_url":"https://api.github.com/repos/idyll-lang/idyll-default-components/forks","keys_url":"https://api.github.com/repos/idyll-lang/idyll-default-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/idyll-lang/idyll-default-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/idyll-lang/idyll-default-components/teams","hooks_url":"https://api.github.com/repos/idyll-lang/idyll-default-components/hooks","issue_events_url":"https://api.github.com/repos/idyll-lang/idyll-default-components/issues/events{/number}","events_url":"https://api.github.com/repos/idyll-lang/idyll-default-components/events","assignees_url":"https://api.github.com/repos/idyll-lang/idyll-default-components/assignees{/user}","branches_url":"https://api.github.com/repos/idyll-lang/idyll-default-components/branches{/branch}","tags_url":"https://api.github.com/repos/idyll-lang/idyll-default-components/tags","blobs_url":"https://api.github.com/repos/idyll-lang/idyll-default-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/idyll-lang/idyll-default-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/idyll-lang/idyll-default-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/idyll-lang/idyll-default-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/idyll-lang/idyll-default-components/statuses/{sha}","languages_url":"https://api.github.com/repos/idyll-lang/idyll-default-components/languages","stargazers_url":"https://api.github.com/repos/idyll-lang/idyll-default-components/stargazers","contributors_url":"https://api.github.com/repos/idyll-lang/idyll-default-components/contributors","subscribers_url":"https://api.github.com/repos/idyll-lang/idyll-default-components/subscribers","subscription_url":"https://api.github.com/repos/idyll-lang/idyll-default-components/subscription","commits_url":"https://api.github.com/repos/idyll-lang/idyll-default-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/idyll-lang/idyll-default-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/idyll-lang/idyll-default-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/idyll-lang/idyll-default-components/issues/comments{/number}","contents_url":"https://api.github.com/repos/idyll-lang/idyll-default-components/contents/{+path}","compare_url":"https://api.github.com/repos/idyll-lang/idyll-default-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/idyll-lang/idyll-default-components/merges","archive_url":"https://api.github.com/repos/idyll-lang/idyll-default-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/idyll-lang/idyll-default-components/downloads","issues_url":"https://api.github.com/repos/idyll-lang/idyll-default-components/issues{/number}","pulls_url":"https://api.github.com/repos/idyll-lang/idyll-default-components/pulls{/number}","milestones_url":"https://api.github.com/repos/idyll-lang/idyll-default-components/milestones{/number}","notifications_url":"https://api.github.com/repos/idyll-lang/idyll-default-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/idyll-lang/idyll-default-components/labels{/name}","releases_url":"https://api.github.com/repos/idyll-lang/idyll-default-components/releases{/id}","deployments_url":"https://api.github.com/repos/idyll-lang/idyll-default-components/deployments","created_at":"2017-04-25T04:05:35Z","updated_at":"2017-04-25T06:06:21Z","pushed_at":"2017-05-26T13:57:09Z","git_url":"git://github.com/idyll-lang/idyll-default-components.git","ssh_url":"git@github.com:idyll-lang/idyll-default-components.git","clone_url":"https://github.com/idyll-lang/idyll-default-components.git","svn_url":"https://github.com/idyll-lang/idyll-default-components","homepage":null,"size":92,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"idyll-lang:add-main-file","ref":"add-main-file","sha":"09ee7ee05c8213d088de5d078fbceb934d5d4d32","user":{"login":"idyll-lang","id":25518453,"avatar_url":"https://avatars0.githubusercontent.com/u/25518453?v=3","gravatar_id":"","url":"https://api.github.com/users/idyll-lang","html_url":"https://github.com/idyll-lang","followers_url":"https://api.github.com/users/idyll-lang/followers","following_url":"https://api.github.com/users/idyll-lang/following{/other_user}","gists_url":"https://api.github.com/users/idyll-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/idyll-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/idyll-lang/subscriptions","organizations_url":"https://api.github.com/users/idyll-lang/orgs","repos_url":"https://api.github.com/users/idyll-lang/repos","events_url":"https://api.github.com/users/idyll-lang/events{/privacy}","received_events_url":"https://api.github.com/users/idyll-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":89316153,"name":"idyll-default-components","full_name":"idyll-lang/idyll-default-components","owner":{"login":"idyll-lang","id":25518453,"avatar_url":"https://avatars0.githubusercontent.com/u/25518453?v=3","gravatar_id":"","url":"https://api.github.com/users/idyll-lang","html_url":"https://github.com/idyll-lang","followers_url":"https://api.github.com/users/idyll-lang/followers","following_url":"https://api.github.com/users/idyll-lang/following{/other_user}","gists_url":"https://api.github.com/users/idyll-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/idyll-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/idyll-lang/subscriptions","organizations_url":"https://api.github.com/users/idyll-lang/orgs","repos_url":"https://api.github.com/users/idyll-lang/repos","events_url":"https://api.github.com/users/idyll-lang/events{/privacy}","received_events_url":"https://api.github.com/users/idyll-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/idyll-lang/idyll-default-components","description":"Components that ship by default in new idyll projects","fork":false,"url":"https://api.github.com/repos/idyll-lang/idyll-default-components","forks_url":"https://api.github.com/repos/idyll-lang/idyll-default-components/forks","keys_url":"https://api.github.com/repos/idyll-lang/idyll-default-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/idyll-lang/idyll-default-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/idyll-lang/idyll-default-components/teams","hooks_url":"https://api.github.com/repos/idyll-lang/idyll-default-components/hooks","issue_events_url":"https://api.github.com/repos/idyll-lang/idyll-default-components/issues/events{/number}","events_url":"https://api.github.com/repos/idyll-lang/idyll-default-components/events","assignees_url":"https://api.github.com/repos/idyll-lang/idyll-default-components/assignees{/user}","branches_url":"https://api.github.com/repos/idyll-lang/idyll-default-components/branches{/branch}","tags_url":"https://api.github.com/repos/idyll-lang/idyll-default-components/tags","blobs_url":"https://api.github.com/repos/idyll-lang/idyll-default-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/idyll-lang/idyll-default-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/idyll-lang/idyll-default-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/idyll-lang/idyll-default-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/idyll-lang/idyll-default-components/statuses/{sha}","languages_url":"https://api.github.com/repos/idyll-lang/idyll-default-components/languages","stargazers_url":"https://api.github.com/repos/idyll-lang/idyll-default-components/stargazers","contributors_url":"https://api.github.com/repos/idyll-lang/idyll-default-components/contributors","subscribers_url":"https://api.github.com/repos/idyll-lang/idyll-default-components/subscribers","subscription_url":"https://api.github.com/repos/idyll-lang/idyll-default-components/subscription","commits_url":"https://api.github.com/repos/idyll-lang/idyll-default-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/idyll-lang/idyll-default-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/idyll-lang/idyll-default-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/idyll-lang/idyll-default-components/issues/comments{/number}","contents_url":"https://api.github.com/repos/idyll-lang/idyll-default-components/contents/{+path}","compare_url":"https://api.github.com/repos/idyll-lang/idyll-default-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/idyll-lang/idyll-default-components/merges","archive_url":"https://api.github.com/repos/idyll-lang/idyll-default-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/idyll-lang/idyll-default-components/downloads","issues_url":"https://api.github.com/repos/idyll-lang/idyll-default-components/issues{/number}","pulls_url":"https://api.github.com/repos/idyll-lang/idyll-default-components/pulls{/number}","milestones_url":"https://api.github.com/repos/idyll-lang/idyll-default-components/milestones{/number}","notifications_url":"https://api.github.com/repos/idyll-lang/idyll-default-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/idyll-lang/idyll-default-components/labels{/name}","releases_url":"https://api.github.com/repos/idyll-lang/idyll-default-components/releases{/id}","deployments_url":"https://api.github.com/repos/idyll-lang/idyll-default-components/deployments","created_at":"2017-04-25T04:05:35Z","updated_at":"2017-04-25T06:06:21Z","pushed_at":"2017-05-26T13:57:09Z","git_url":"git://github.com/idyll-lang/idyll-default-components.git","ssh_url":"git@github.com:idyll-lang/idyll-default-components.git","clone_url":"https://github.com/idyll-lang/idyll-default-components.git","svn_url":"https://github.com/idyll-lang/idyll-default-components","homepage":null,"size":92,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/idyll-lang/idyll-default-components/pulls/5"},"html":{"href":"https://github.com/idyll-lang/idyll-default-components/pull/5"},"issue":{"href":"https://api.github.com/repos/idyll-lang/idyll-default-components/issues/5"},"comments":{"href":"https://api.github.com/repos/idyll-lang/idyll-default-components/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/idyll-lang/idyll-default-components/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/idyll-lang/idyll-default-components/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/idyll-lang/idyll-default-components/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/idyll-lang/idyll-default-components/statuses/5d1fdf5acc02a23e90229e11653a72086b2981f8"}}}}
{"actor":{"display_login":"rreusser"}}