{"action":"created","comment":{"url":"https://api.github.com/repos/apprenda/kismatic/pulls/comments/150030885","pull_request_review_id":75520381,"id":150030885,"diff_hunk":"@@ -212,10 +212,20 @@ type CloudProvider struct {\n \n // Docker includes the configuration for the docker installation owned by KET.\n type Docker struct {\n+\t// Log configuration for the docker engine\n+\tLogs DockerLogs\n \t// Storage configuration for the docker engine\n \tStorage DockerStorage\n }\n \n+// DockerLogs includes the log-specific configuration for docker.\n+type DockerLogs struct {","path":"pkg/install/plan_types.go","position":11,"original_position":11,"commit_id":"fd69498d335ba637124ceca2a3215615e296f18d","original_commit_id":"fd69498d335ba637124ceca2a3215615e296f18d","user":{"login":"willvrny","id":1245610,"avatar_url":"https://avatars1.githubusercontent.com/u/1245610?v=4","gravatar_id":"","url":"https://api.github.com/users/willvrny","html_url":"https://github.com/willvrny","followers_url":"https://api.github.com/users/willvrny/followers","following_url":"https://api.github.com/users/willvrny/following{/other_user}","gists_url":"https://api.github.com/users/willvrny/gists{/gist_id}","starred_url":"https://api.github.com/users/willvrny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willvrny/subscriptions","organizations_url":"https://api.github.com/users/willvrny/orgs","repos_url":"https://api.github.com/users/willvrny/repos","events_url":"https://api.github.com/users/willvrny/events{/privacy}","received_events_url":"https://api.github.com/users/willvrny/received_events","type":"User","site_admin":false},"body":"This could couple us tightly to docker changes as when we change a version we'd need to check for new or deprecated log opts. Should we leave out the validation or perform minimal validation?","created_at":"2017-11-09T17:26:36Z","updated_at":"2017-11-09T17:26:36Z","html_url":"https://github.com/apprenda/kismatic/pull/903#discussion_r150030885","pull_request_url":"https://api.github.com/repos/apprenda/kismatic/pulls/903","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apprenda/kismatic/pulls/comments/150030885"},"html":{"href":"https://github.com/apprenda/kismatic/pull/903#discussion_r150030885"},"pull_request":{"href":"https://api.github.com/repos/apprenda/kismatic/pulls/903"}},"in_reply_to_id":149404639},"pull_request":{"url":"https://api.github.com/repos/apprenda/kismatic/pulls/903","id":150819540,"html_url":"https://github.com/apprenda/kismatic/pull/903","diff_url":"https://github.com/apprenda/kismatic/pull/903.diff","patch_url":"https://github.com/apprenda/kismatic/pull/903.patch","issue_url":"https://api.github.com/repos/apprenda/kismatic/issues/903","number":903,"state":"open","locked":false,"title":"Configure docker log rotation","user":{"login":"willvrny","id":1245610,"avatar_url":"https://avatars1.githubusercontent.com/u/1245610?v=4","gravatar_id":"","url":"https://api.github.com/users/willvrny","html_url":"https://github.com/willvrny","followers_url":"https://api.github.com/users/willvrny/followers","following_url":"https://api.github.com/users/willvrny/following{/other_user}","gists_url":"https://api.github.com/users/willvrny/gists{/gist_id}","starred_url":"https://api.github.com/users/willvrny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willvrny/subscriptions","organizations_url":"https://api.github.com/users/willvrny/orgs","repos_url":"https://api.github.com/users/willvrny/repos","events_url":"https://api.github.com/users/willvrny/events{/privacy}","received_events_url":"https://api.github.com/users/willvrny/received_events","type":"User","site_admin":false},"body":"Allows the user to configure the settings in the plan file to fix issue: #674 \r\n\r\n```\r\nlogs:\r\n    max_size: 10m\r\n    max_file: 1\r\n```\r\n\r\nTo keep the implementation simpler only two options are exposed with the assumption the user will always use the \"json-file\" logging driver. This is the driver Kismatic is currently using.\r\n\r\nA docker daemon.json file is now always created to persist settings with the minimum content being:\r\n\r\n```\r\n\"log-driver\": \"json-file\",\r\n```\r\nI've also added a test assertion library to make the unit tests easier to write.","created_at":"2017-11-06T10:43:16Z","updated_at":"2017-11-09T17:26:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fec323f19b6c94fc7fdb24e8d51ddcf9ee56e5e8","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/apprenda/kismatic/pulls/903/commits","review_comments_url":"https://api.github.com/repos/apprenda/kismatic/pulls/903/comments","review_comment_url":"https://api.github.com/repos/apprenda/kismatic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apprenda/kismatic/issues/903/comments","statuses_url":"https://api.github.com/repos/apprenda/kismatic/statuses/fd69498d335ba637124ceca2a3215615e296f18d","head":{"label":"willvrny:docker-log-rotation","ref":"docker-log-rotation","sha":"fd69498d335ba637124ceca2a3215615e296f18d","user":{"login":"willvrny","id":1245610,"avatar_url":"https://avatars1.githubusercontent.com/u/1245610?v=4","gravatar_id":"","url":"https://api.github.com/users/willvrny","html_url":"https://github.com/willvrny","followers_url":"https://api.github.com/users/willvrny/followers","following_url":"https://api.github.com/users/willvrny/following{/other_user}","gists_url":"https://api.github.com/users/willvrny/gists{/gist_id}","starred_url":"https://api.github.com/users/willvrny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willvrny/subscriptions","organizations_url":"https://api.github.com/users/willvrny/orgs","repos_url":"https://api.github.com/users/willvrny/repos","events_url":"https://api.github.com/users/willvrny/events{/privacy}","received_events_url":"https://api.github.com/users/willvrny/received_events","type":"User","site_admin":false},"repo":{"id":102844504,"name":"kismatic","full_name":"willvrny/kismatic","owner":{"login":"willvrny","id":1245610,"avatar_url":"https://avatars1.githubusercontent.com/u/1245610?v=4","gravatar_id":"","url":"https://api.github.com/users/willvrny","html_url":"https://github.com/willvrny","followers_url":"https://api.github.com/users/willvrny/followers","following_url":"https://api.github.com/users/willvrny/following{/other_user}","gists_url":"https://api.github.com/users/willvrny/gists{/gist_id}","starred_url":"https://api.github.com/users/willvrny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willvrny/subscriptions","organizations_url":"https://api.github.com/users/willvrny/orgs","repos_url":"https://api.github.com/users/willvrny/repos","events_url":"https://api.github.com/users/willvrny/events{/privacy}","received_events_url":"https://api.github.com/users/willvrny/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/willvrny/kismatic","description":"Kismatic Enterprise Toolkit: Fully-Automated, Production-Grade Kubernetes Operations","fork":true,"url":"https://api.github.com/repos/willvrny/kismatic","forks_url":"https://api.github.com/repos/willvrny/kismatic/forks","keys_url":"https://api.github.com/repos/willvrny/kismatic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/willvrny/kismatic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/willvrny/kismatic/teams","hooks_url":"https://api.github.com/repos/willvrny/kismatic/hooks","issue_events_url":"https://api.github.com/repos/willvrny/kismatic/issues/events{/number}","events_url":"https://api.github.com/repos/willvrny/kismatic/events","assignees_url":"https://api.github.com/repos/willvrny/kismatic/assignees{/user}","branches_url":"https://api.github.com/repos/willvrny/kismatic/branches{/branch}","tags_url":"https://api.github.com/repos/willvrny/kismatic/tags","blobs_url":"https://api.github.com/repos/willvrny/kismatic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/willvrny/kismatic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/willvrny/kismatic/git/refs{/sha}","trees_url":"https://api.github.com/repos/willvrny/kismatic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/willvrny/kismatic/statuses/{sha}","languages_url":"https://api.github.com/repos/willvrny/kismatic/languages","stargazers_url":"https://api.github.com/repos/willvrny/kismatic/stargazers","contributors_url":"https://api.github.com/repos/willvrny/kismatic/contributors","subscribers_url":"https://api.github.com/repos/willvrny/kismatic/subscribers","subscription_url":"https://api.github.com/repos/willvrny/kismatic/subscription","commits_url":"https://api.github.com/repos/willvrny/kismatic/commits{/sha}","git_commits_url":"https://api.github.com/repos/willvrny/kismatic/git/commits{/sha}","comments_url":"https://api.github.com/repos/willvrny/kismatic/comments{/number}","issue_comment_url":"https://api.github.com/repos/willvrny/kismatic/issues/comments{/number}","contents_url":"https://api.github.com/repos/willvrny/kismatic/contents/{+path}","compare_url":"https://api.github.com/repos/willvrny/kismatic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/willvrny/kismatic/merges","archive_url":"https://api.github.com/repos/willvrny/kismatic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/willvrny/kismatic/downloads","issues_url":"https://api.github.com/repos/willvrny/kismatic/issues{/number}","pulls_url":"https://api.github.com/repos/willvrny/kismatic/pulls{/number}","milestones_url":"https://api.github.com/repos/willvrny/kismatic/milestones{/number}","notifications_url":"https://api.github.com/repos/willvrny/kismatic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/willvrny/kismatic/labels{/name}","releases_url":"https://api.github.com/repos/willvrny/kismatic/releases{/id}","deployments_url":"https://api.github.com/repos/willvrny/kismatic/deployments","created_at":"2017-09-08T09:30:43Z","updated_at":"2017-09-08T09:30:46Z","pushed_at":"2017-11-06T10:37:45Z","git_url":"git://github.com/willvrny/kismatic.git","ssh_url":"git@github.com:willvrny/kismatic.git","clone_url":"https://github.com/willvrny/kismatic.git","svn_url":"https://github.com/willvrny/kismatic","homepage":"","size":6816,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apprenda:master","ref":"master","sha":"5db4d6b5681258067a9150530b39d31735a58dd8","user":{"login":"apprenda","id":6901411,"avatar_url":"https://avatars2.githubusercontent.com/u/6901411?v=4","gravatar_id":"","url":"https://api.github.com/users/apprenda","html_url":"https://github.com/apprenda","followers_url":"https://api.github.com/users/apprenda/followers","following_url":"https://api.github.com/users/apprenda/following{/other_user}","gists_url":"https://api.github.com/users/apprenda/gists{/gist_id}","starred_url":"https://api.github.com/users/apprenda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apprenda/subscriptions","organizations_url":"https://api.github.com/users/apprenda/orgs","repos_url":"https://api.github.com/users/apprenda/repos","events_url":"https://api.github.com/users/apprenda/events{/privacy}","received_events_url":"https://api.github.com/users/apprenda/received_events","type":"Organization","site_admin":false},"repo":{"id":64937285,"name":"kismatic","full_name":"apprenda/kismatic","owner":{"login":"apprenda","id":6901411,"avatar_url":"https://avatars2.githubusercontent.com/u/6901411?v=4","gravatar_id":"","url":"https://api.github.com/users/apprenda","html_url":"https://github.com/apprenda","followers_url":"https://api.github.com/users/apprenda/followers","following_url":"https://api.github.com/users/apprenda/following{/other_user}","gists_url":"https://api.github.com/users/apprenda/gists{/gist_id}","starred_url":"https://api.github.com/users/apprenda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apprenda/subscriptions","organizations_url":"https://api.github.com/users/apprenda/orgs","repos_url":"https://api.github.com/users/apprenda/repos","events_url":"https://api.github.com/users/apprenda/events{/privacy}","received_events_url":"https://api.github.com/users/apprenda/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apprenda/kismatic","description":"Kismatic Enterprise Toolkit: Fully-Automated, Production-Grade Kubernetes Operations","fork":false,"url":"https://api.github.com/repos/apprenda/kismatic","forks_url":"https://api.github.com/repos/apprenda/kismatic/forks","keys_url":"https://api.github.com/repos/apprenda/kismatic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apprenda/kismatic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apprenda/kismatic/teams","hooks_url":"https://api.github.com/repos/apprenda/kismatic/hooks","issue_events_url":"https://api.github.com/repos/apprenda/kismatic/issues/events{/number}","events_url":"https://api.github.com/repos/apprenda/kismatic/events","assignees_url":"https://api.github.com/repos/apprenda/kismatic/assignees{/user}","branches_url":"https://api.github.com/repos/apprenda/kismatic/branches{/branch}","tags_url":"https://api.github.com/repos/apprenda/kismatic/tags","blobs_url":"https://api.github.com/repos/apprenda/kismatic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apprenda/kismatic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apprenda/kismatic/git/refs{/sha}","trees_url":"https://api.github.com/repos/apprenda/kismatic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apprenda/kismatic/statuses/{sha}","languages_url":"https://api.github.com/repos/apprenda/kismatic/languages","stargazers_url":"https://api.github.com/repos/apprenda/kismatic/stargazers","contributors_url":"https://api.github.com/repos/apprenda/kismatic/contributors","subscribers_url":"https://api.github.com/repos/apprenda/kismatic/subscribers","subscription_url":"https://api.github.com/repos/apprenda/kismatic/subscription","commits_url":"https://api.github.com/repos/apprenda/kismatic/commits{/sha}","git_commits_url":"https://api.github.com/repos/apprenda/kismatic/git/commits{/sha}","comments_url":"https://api.github.com/repos/apprenda/kismatic/comments{/number}","issue_comment_url":"https://api.github.com/repos/apprenda/kismatic/issues/comments{/number}","contents_url":"https://api.github.com/repos/apprenda/kismatic/contents/{+path}","compare_url":"https://api.github.com/repos/apprenda/kismatic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apprenda/kismatic/merges","archive_url":"https://api.github.com/repos/apprenda/kismatic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apprenda/kismatic/downloads","issues_url":"https://api.github.com/repos/apprenda/kismatic/issues{/number}","pulls_url":"https://api.github.com/repos/apprenda/kismatic/pulls{/number}","milestones_url":"https://api.github.com/repos/apprenda/kismatic/milestones{/number}","notifications_url":"https://api.github.com/repos/apprenda/kismatic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apprenda/kismatic/labels{/name}","releases_url":"https://api.github.com/repos/apprenda/kismatic/releases{/id}","deployments_url":"https://api.github.com/repos/apprenda/kismatic/deployments","created_at":"2016-08-04T13:33:36Z","updated_at":"2017-11-09T09:32:15Z","pushed_at":"2017-11-09T16:11:09Z","git_url":"git://github.com/apprenda/kismatic.git","ssh_url":"git@github.com:apprenda/kismatic.git","clone_url":"https://github.com/apprenda/kismatic.git","svn_url":"https://github.com/apprenda/kismatic","homepage":"","size":6930,"stargazers_count":557,"watchers_count":557,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":91,"mirror_url":null,"archived":false,"open_issues_count":76,"forks":91,"open_issues":76,"watchers":557,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apprenda/kismatic/pulls/903"},"html":{"href":"https://github.com/apprenda/kismatic/pull/903"},"issue":{"href":"https://api.github.com/repos/apprenda/kismatic/issues/903"},"comments":{"href":"https://api.github.com/repos/apprenda/kismatic/issues/903/comments"},"review_comments":{"href":"https://api.github.com/repos/apprenda/kismatic/pulls/903/comments"},"review_comment":{"href":"https://api.github.com/repos/apprenda/kismatic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apprenda/kismatic/pulls/903/commits"},"statuses":{"href":"https://api.github.com/repos/apprenda/kismatic/statuses/fd69498d335ba637124ceca2a3215615e296f18d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"willvrny"}}