{"action":"created","issue":{"url":"https://api.github.com/repos/openssl/openssl/issues/4994","repository_url":"https://api.github.com/repos/openssl/openssl","labels_url":"https://api.github.com/repos/openssl/openssl/issues/4994/labels{/name}","comments_url":"https://api.github.com/repos/openssl/openssl/issues/4994/comments","events_url":"https://api.github.com/repos/openssl/openssl/issues/4994/events","html_url":"https://github.com/openssl/openssl/pull/4994","id":284936574,"number":4994,"title":"Various build improvements, e.g., on mkdef.pl and progs.pl and Windows compatibility","user":{"login":"DDvO","id":4600384,"avatar_url":"https://avatars2.githubusercontent.com/u/4600384?v=4","gravatar_id":"","url":"https://api.github.com/users/DDvO","html_url":"https://github.com/DDvO","followers_url":"https://api.github.com/users/DDvO/followers","following_url":"https://api.github.com/users/DDvO/following{/other_user}","gists_url":"https://api.github.com/users/DDvO/gists{/gist_id}","starred_url":"https://api.github.com/users/DDvO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DDvO/subscriptions","organizations_url":"https://api.github.com/users/DDvO/orgs","repos_url":"https://api.github.com/users/DDvO/repos","events_url":"https://api.github.com/users/DDvO/events{/privacy}","received_events_url":"https://api.github.com/users/DDvO/received_events","type":"User","site_admin":false},"labels":[{"id":441165399,"url":"https://api.github.com/repos/openssl/openssl/labels/1.1.0","name":"1.1.0","color":"bfdadc","default":false},{"id":441165144,"url":"https://api.github.com/repos/openssl/openssl/labels/master","name":"master","color":"bfdadc","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-12-28T15:28:14Z","updated_at":"2017-12-30T13:49:10Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/openssl/openssl/pulls/4994","html_url":"https://github.com/openssl/openssl/pull/4994","diff_url":"https://github.com/openssl/openssl/pull/4994.diff","patch_url":"https://github.com/openssl/openssl/pull/4994.patch"},"body":"As requested in https://github.com/openssl/openssl/pull/4992#issuecomment-354289718\r\nhere are five commits with various small corrections for shortcomings in the build machinery of OpenSSL I recently came across while preparing https://github.com/openssl/openssl/pull/4992\r\n- a bug fixed in `util/mkdef.pl`, which caused a loop handling declarations like `void fn()`\r\n- a more practically useful trace option for `util/mkdef.pl`\r\n- a new option for mkdef.pl for warning about incomplete handling of `#if` expressions\r\n- a POSIX/ANSI compatibility warning issue with `crypto/mem.c` and Visual C fixed in `e_os.h`\r\n- a correction of `OPENSSL_EXPORT` and `OPENSSL_EXTERN` in `e_os2.h` for native Windows builds \r\n- a bug fixed in a file open error message in `apps/progs.pl`\r\n\r\nPlus one commit of the same category that is also part of https://github.com/openssl/openssl/pull/4930\r\n- avoiding an unused `glock_once` variable in case `OPENSSL_SYS_UNIX `not defined"},"comment":{"url":"https://api.github.com/repos/openssl/openssl/issues/comments/354547163","html_url":"https://github.com/openssl/openssl/pull/4994#issuecomment-354547163","issue_url":"https://api.github.com/repos/openssl/openssl/issues/4994","id":354547163,"user":{"login":"levitte","id":698918,"avatar_url":"https://avatars1.githubusercontent.com/u/698918?v=4","gravatar_id":"","url":"https://api.github.com/users/levitte","html_url":"https://github.com/levitte","followers_url":"https://api.github.com/users/levitte/followers","following_url":"https://api.github.com/users/levitte/following{/other_user}","gists_url":"https://api.github.com/users/levitte/gists{/gist_id}","starred_url":"https://api.github.com/users/levitte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/levitte/subscriptions","organizations_url":"https://api.github.com/users/levitte/orgs","repos_url":"https://api.github.com/users/levitte/repos","events_url":"https://api.github.com/users/levitte/events{/privacy}","received_events_url":"https://api.github.com/users/levitte/received_events","type":"User","site_admin":false},"created_at":"2017-12-30T13:49:10Z","updated_at":"2017-12-30T13:49:10Z","author_association":"OWNER","body":"I'd say this should go to 1.1.0 as much as master.  Labeled accordingly"}}
{"actor":{"display_login":"levitte"}}