{"action":"closed","issue":{"url":"https://api.github.com/repos/18F/fec-style/issues/373","repository_url":"https://api.github.com/repos/18F/fec-style","labels_url":"https://api.github.com/repos/18F/fec-style/issues/373/labels{/name}","comments_url":"https://api.github.com/repos/18F/fec-style/issues/373/comments","events_url":"https://api.github.com/repos/18F/fec-style/issues/373/events","html_url":"https://github.com/18F/fec-style/issues/373","id":157284359,"number":373,"title":"fec-style depends on hbsfy but doesn't package it","user":{"login":"adborden","id":509703,"avatar_url":"https://avatars2.githubusercontent.com/u/509703?v=4","gravatar_id":"","url":"https://api.github.com/users/adborden","html_url":"https://github.com/adborden","followers_url":"https://api.github.com/users/adborden/followers","following_url":"https://api.github.com/users/adborden/following{/other_user}","gists_url":"https://api.github.com/users/adborden/gists{/gist_id}","starred_url":"https://api.github.com/users/adborden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adborden/subscriptions","organizations_url":"https://api.github.com/users/adborden/orgs","repos_url":"https://api.github.com/users/adborden/repos","events_url":"https://api.github.com/users/adborden/events{/privacy}","received_events_url":"https://api.github.com/users/adborden/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-05-27T20:25:05Z","updated_at":"2017-10-11T17:33:36Z","closed_at":"2017-10-11T17:33:36Z","author_association":"MEMBER","body":"Using fec-style in another project and running into an error with browserify.\n\nMy code:\n\n``` javascript\nvar SiteNav = require('fec-style/js/site-nav').SiteNav;\n```\n\nError:\n\n```\nRunning \"browserify:dev\" (browserify) task\n>> /home/adborden/projects/fec/fec-eregs/node_modules/fec-style/js/templates/nav-data.hbs:1\n>> <div class=\"mega\">\n>> ^\n>> ParseError: Unexpected token\n```\n\nThe issue is that the fec-style build depends on hbsfy to bundle the handlebar templates, but this is not  documented.\n\nEither we should document the dependencies that your app must install (maybe via peerDeps) or bundle the dependencies in fec-style. I'm not sure of a good way to bundle build plugins like this.\n\nIt kind of reminds me of my coffeescript days, where we built the npm package to export the compiled javascript. So in this case, the npm package would have already browserified the handlebar templates,  and just export a template function or the handlebar template string itself.\n"}}
{"actor":{"display_login":"xtine"}}