{"action":"created","issue":{"url":"https://api.github.com/repos/tananaev/traccar-client-android/issues/300","repository_url":"https://api.github.com/repos/tananaev/traccar-client-android","labels_url":"https://api.github.com/repos/tananaev/traccar-client-android/issues/300/labels{/name}","comments_url":"https://api.github.com/repos/tananaev/traccar-client-android/issues/300/comments","events_url":"https://api.github.com/repos/tananaev/traccar-client-android/issues/300/events","html_url":"https://github.com/tananaev/traccar-client-android/pull/300","id":281636920,"number":300,"title":"Get service notification to show. Tweek settings.","user":{"login":"garyvdm","id":352175,"avatar_url":"https://avatars2.githubusercontent.com/u/352175?v=4","gravatar_id":"","url":"https://api.github.com/users/garyvdm","html_url":"https://github.com/garyvdm","followers_url":"https://api.github.com/users/garyvdm/followers","following_url":"https://api.github.com/users/garyvdm/following{/other_user}","gists_url":"https://api.github.com/users/garyvdm/gists{/gist_id}","starred_url":"https://api.github.com/users/garyvdm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garyvdm/subscriptions","organizations_url":"https://api.github.com/users/garyvdm/orgs","repos_url":"https://api.github.com/users/garyvdm/repos","events_url":"https://api.github.com/users/garyvdm/events{/privacy}","received_events_url":"https://api.github.com/users/garyvdm/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-12-13T06:18:38Z","updated_at":"2017-12-13T09:32:27Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/tananaev/traccar-client-android/pulls/300","html_url":"https://github.com/tananaev/traccar-client-android/pull/300","diff_url":"https://github.com/tananaev/traccar-client-android/pull/300.diff","patch_url":"https://github.com/tananaev/traccar-client-android/pull/300.patch"},"body":"Fixes #299 \r\n\r\nThis gets the foreground service notification to show correctly. With a bit of playing, discovered that to get the notification to work, `setSmallIcon` must be called, and `setPriority` needs `PRIORITY_LOW` or higher.\r\n\r\nI also tweaked some of the parameters for notification to try follow the design guidelines.\r\n\r\nClicking on the notification now takes you to the `MainActivity`.\r\n\r\n![screenshot_20171213-081400](https://user-images.githubusercontent.com/352175/33924289-10e73684-dfde-11e7-8063-1e9026ac06f6.png)\r\n"},"comment":{"url":"https://api.github.com/repos/tananaev/traccar-client-android/issues/comments/351334779","html_url":"https://github.com/tananaev/traccar-client-android/pull/300#issuecomment-351334779","issue_url":"https://api.github.com/repos/tananaev/traccar-client-android/issues/300","id":351334779,"user":{"login":"garyvdm","id":352175,"avatar_url":"https://avatars2.githubusercontent.com/u/352175?v=4","gravatar_id":"","url":"https://api.github.com/users/garyvdm","html_url":"https://github.com/garyvdm","followers_url":"https://api.github.com/users/garyvdm/followers","following_url":"https://api.github.com/users/garyvdm/following{/other_user}","gists_url":"https://api.github.com/users/garyvdm/gists{/gist_id}","starred_url":"https://api.github.com/users/garyvdm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garyvdm/subscriptions","organizations_url":"https://api.github.com/users/garyvdm/orgs","repos_url":"https://api.github.com/users/garyvdm/repos","events_url":"https://api.github.com/users/garyvdm/events{/privacy}","received_events_url":"https://api.github.com/users/garyvdm/received_events","type":"User","site_admin":false},"created_at":"2017-12-13T09:32:27Z","updated_at":"2017-12-13T09:32:27Z","author_association":"NONE","body":"The notification only shows from API 25 onwards.  \r\n\r\nIf I remove the use of the `HideNotificationService`, and use `TrackingService` instead, then the notification shows for all versions (styling needs to changes for some of the older apis.)\r\n\r\nFor my use cases hiding the notification does not make sense, but I know my use cases are not the same as others. \r\n\r\nWould you consider a patch that disables use use of `HideNotificationService` in the `regular`/`google` product flavours, and enables it for the `hidden` flavour?"}}
{"actor":{"display_login":"garyvdm"}}