{"action":"created","issue":{"url":"https://api.github.com/repos/nkbt/react-collapse/issues/166","repository_url":"https://api.github.com/repos/nkbt/react-collapse","labels_url":"https://api.github.com/repos/nkbt/react-collapse/issues/166/labels{/name}","comments_url":"https://api.github.com/repos/nkbt/react-collapse/issues/166/comments","events_url":"https://api.github.com/repos/nkbt/react-collapse/issues/166/events","html_url":"https://github.com/nkbt/react-collapse/pull/166","id":223017148,"number":166,"title":"Prevent set WAITING state if isOpened doesnt change","user":{"login":"meriadec","id":315259,"avatar_url":"https://avatars3.githubusercontent.com/u/315259?v=3","gravatar_id":"","url":"https://api.github.com/users/meriadec","html_url":"https://github.com/meriadec","followers_url":"https://api.github.com/users/meriadec/followers","following_url":"https://api.github.com/users/meriadec/following{/other_user}","gists_url":"https://api.github.com/users/meriadec/gists{/gist_id}","starred_url":"https://api.github.com/users/meriadec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meriadec/subscriptions","organizations_url":"https://api.github.com/users/meriadec/orgs","repos_url":"https://api.github.com/users/meriadec/repos","events_url":"https://api.github.com/users/meriadec/events{/privacy}","received_events_url":"https://api.github.com/users/meriadec/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2017-04-20T10:15:13Z","updated_at":"2017-05-05T09:16:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nkbt/react-collapse/pulls/166","html_url":"https://github.com/nkbt/react-collapse/pull/166","diff_url":"https://github.com/nkbt/react-collapse/pull/166.diff","patch_url":"https://github.com/nkbt/react-collapse/pull/166.patch"},"body":"*EDIT* outdated: removed the \"\"\"fix\"\"\"\r\n\r\nRelated to [#163](https://github.com/nkbt/react-collapse/issues/163).\r\n\r\nThis commit prevent setting `overflow: hidden` when a new render occur, and the `isOpened` prop is still the same (because Collapse move to WAITING state). Now, it pass to WAITING only if `isOpened` has changed. To explain better here is an animated explanation of the problem:\r\n\r\n*before:*\r\n![before](https://cloud.githubusercontent.com/assets/315259/25225647/77e4fe10-25c2-11e7-81d6-6a2618a2794a.gif)\r\n\r\n*after:*\r\n![after](https://cloud.githubusercontent.com/assets/315259/25225678/981a3ab0-25c2-11e7-8349-21992b1f89fd.gif)\r\n\r\nI didn't understand the reason why the state is reset to WAITING either `isOpened` **OR** `nextProps.isOpened` is true, so correct me if I break something.\r\n\r\nThanks for the package, by the way! :smile:"},"comment":{"url":"https://api.github.com/repos/nkbt/react-collapse/issues/comments/299419091","html_url":"https://github.com/nkbt/react-collapse/pull/166#issuecomment-299419091","issue_url":"https://api.github.com/repos/nkbt/react-collapse/issues/166","id":299419091,"user":{"login":"meriadec","id":315259,"avatar_url":"https://avatars3.githubusercontent.com/u/315259?v=3","gravatar_id":"","url":"https://api.github.com/users/meriadec","html_url":"https://github.com/meriadec","followers_url":"https://api.github.com/users/meriadec/followers","following_url":"https://api.github.com/users/meriadec/following{/other_user}","gists_url":"https://api.github.com/users/meriadec/gists{/gist_id}","starred_url":"https://api.github.com/users/meriadec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meriadec/subscriptions","organizations_url":"https://api.github.com/users/meriadec/orgs","repos_url":"https://api.github.com/users/meriadec/repos","events_url":"https://api.github.com/users/meriadec/events{/privacy}","received_events_url":"https://api.github.com/users/meriadec/received_events","type":"User","site_admin":false},"created_at":"2017-05-05T09:16:47Z","updated_at":"2017-05-05T09:16:47Z","body":"It gets to `overflow: auto` when animation is finished, which is totally fine.\r\nThe problem is when it set `overflow: hidden` when **another render occurs** (in my example when I toggle `Overflow opened`), and that overflow hidden is never put back to `auto`."}}
{"actor":{"display_login":"meriadec"}}