{"action":"created","comment":{"url":"https://api.github.com/repos/MYOB-Technology/konfigurator/pulls/comments/135949865","pull_request_review_id":59423424,"id":135949865,"diff_hunk":"@@ -28,7 +28,7 @@ type Konfigurator struct {\n }\n \n // NewKonfigurator creates a file and a uuid to use as a state to check MITM attacks and returns a new Konfigurator struct.\n-func NewKonfigurator(oidcHost, oidcClientID, oidcClientPort, oidcClientRedirectEndpoint, kubeCa, kubeAPIURL, outputFilePath string) (*Konfigurator, error) {\n+func NewKonfigurator(oidcHost, oidcClientID, oidcClientPort, oidcClientRedirectEndpoint, kubeCa, kubeAPIURL, kubeNamespace, outputFilePath string) (*Konfigurator, error) {","path":"konfigurator/konfigurator.go","position":5,"original_position":5,"commit_id":"ef41947af8b9485fc98c8b7fd98298b3eec6a1e6","original_commit_id":"ef41947af8b9485fc98c8b7fd98298b3eec6a1e6","user":{"login":"gugahoi","id":355877,"avatar_url":"https://avatars0.githubusercontent.com/u/355877?v=4","gravatar_id":"","url":"https://api.github.com/users/gugahoi","html_url":"https://github.com/gugahoi","followers_url":"https://api.github.com/users/gugahoi/followers","following_url":"https://api.github.com/users/gugahoi/following{/other_user}","gists_url":"https://api.github.com/users/gugahoi/gists{/gist_id}","starred_url":"https://api.github.com/users/gugahoi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gugahoi/subscriptions","organizations_url":"https://api.github.com/users/gugahoi/orgs","repos_url":"https://api.github.com/users/gugahoi/repos","events_url":"https://api.github.com/users/gugahoi/events{/privacy}","received_events_url":"https://api.github.com/users/gugahoi/received_events","type":"User","site_admin":false},"body":"Will try to come up with a more manageable approach for next version","created_at":"2017-08-30T01:11:47Z","updated_at":"2017-08-30T01:11:47Z","html_url":"https://github.com/MYOB-Technology/konfigurator/pull/7#discussion_r135949865","pull_request_url":"https://api.github.com/repos/MYOB-Technology/konfigurator/pulls/7","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/MYOB-Technology/konfigurator/pulls/comments/135949865"},"html":{"href":"https://github.com/MYOB-Technology/konfigurator/pull/7#discussion_r135949865"},"pull_request":{"href":"https://api.github.com/repos/MYOB-Technology/konfigurator/pulls/7"}},"in_reply_to_id":135948348},"pull_request":{"url":"https://api.github.com/repos/MYOB-Technology/konfigurator/pulls/7","id":136146060,"html_url":"https://github.com/MYOB-Technology/konfigurator/pull/7","diff_url":"https://github.com/MYOB-Technology/konfigurator/pull/7.diff","patch_url":"https://github.com/MYOB-Technology/konfigurator/pull/7.patch","issue_url":"https://api.github.com/repos/MYOB-Technology/konfigurator/issues/7","number":7,"state":"open","locked":false,"title":"Added an option to select namespace","user":{"login":"gugahoi","id":355877,"avatar_url":"https://avatars0.githubusercontent.com/u/355877?v=4","gravatar_id":"","url":"https://api.github.com/users/gugahoi","html_url":"https://github.com/gugahoi","followers_url":"https://api.github.com/users/gugahoi/followers","following_url":"https://api.github.com/users/gugahoi/following{/other_user}","gists_url":"https://api.github.com/users/gugahoi/gists{/gist_id}","starred_url":"https://api.github.com/users/gugahoi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gugahoi/subscriptions","organizations_url":"https://api.github.com/users/gugahoi/orgs","repos_url":"https://api.github.com/users/gugahoi/repos","events_url":"https://api.github.com/users/gugahoi/events{/privacy}","received_events_url":"https://api.github.com/users/gugahoi/received_events","type":"User","site_admin":false},"body":"this PR adds a new flag so that a namespace is defined in the config yaml:\r\n\r\n```\r\n--namespace dev-1\r\n```\r\nor \r\n```\r\n-n dev-1\r\n```","created_at":"2017-08-16T23:44:22Z","updated_at":"2017-08-30T01:11:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c3eebf92b9f220e8bbe685f7331d947c5c6f3833","assignee":null,"assignees":[],"requested_reviewers":[{"login":"prateek-1708","id":6571322,"avatar_url":"https://avatars1.githubusercontent.com/u/6571322?v=4","gravatar_id":"","url":"https://api.github.com/users/prateek-1708","html_url":"https://github.com/prateek-1708","followers_url":"https://api.github.com/users/prateek-1708/followers","following_url":"https://api.github.com/users/prateek-1708/following{/other_user}","gists_url":"https://api.github.com/users/prateek-1708/gists{/gist_id}","starred_url":"https://api.github.com/users/prateek-1708/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prateek-1708/subscriptions","organizations_url":"https://api.github.com/users/prateek-1708/orgs","repos_url":"https://api.github.com/users/prateek-1708/repos","events_url":"https://api.github.com/users/prateek-1708/events{/privacy}","received_events_url":"https://api.github.com/users/prateek-1708/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/MYOB-Technology/konfigurator/pulls/7/commits","review_comments_url":"https://api.github.com/repos/MYOB-Technology/konfigurator/pulls/7/comments","review_comment_url":"https://api.github.com/repos/MYOB-Technology/konfigurator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MYOB-Technology/konfigurator/issues/7/comments","statuses_url":"https://api.github.com/repos/MYOB-Technology/konfigurator/statuses/ef41947af8b9485fc98c8b7fd98298b3eec6a1e6","head":{"label":"MYOB-Technology:namespace","ref":"namespace","sha":"ef41947af8b9485fc98c8b7fd98298b3eec6a1e6","user":{"login":"MYOB-Technology","id":1910591,"avatar_url":"https://avatars1.githubusercontent.com/u/1910591?v=4","gravatar_id":"","url":"https://api.github.com/users/MYOB-Technology","html_url":"https://github.com/MYOB-Technology","followers_url":"https://api.github.com/users/MYOB-Technology/followers","following_url":"https://api.github.com/users/MYOB-Technology/following{/other_user}","gists_url":"https://api.github.com/users/MYOB-Technology/gists{/gist_id}","starred_url":"https://api.github.com/users/MYOB-Technology/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MYOB-Technology/subscriptions","organizations_url":"https://api.github.com/users/MYOB-Technology/orgs","repos_url":"https://api.github.com/users/MYOB-Technology/repos","events_url":"https://api.github.com/users/MYOB-Technology/events{/privacy}","received_events_url":"https://api.github.com/users/MYOB-Technology/received_events","type":"Organization","site_admin":false},"repo":{"id":98254617,"name":"konfigurator","full_name":"MYOB-Technology/konfigurator","owner":{"login":"MYOB-Technology","id":1910591,"avatar_url":"https://avatars1.githubusercontent.com/u/1910591?v=4","gravatar_id":"","url":"https://api.github.com/users/MYOB-Technology","html_url":"https://github.com/MYOB-Technology","followers_url":"https://api.github.com/users/MYOB-Technology/followers","following_url":"https://api.github.com/users/MYOB-Technology/following{/other_user}","gists_url":"https://api.github.com/users/MYOB-Technology/gists{/gist_id}","starred_url":"https://api.github.com/users/MYOB-Technology/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MYOB-Technology/subscriptions","organizations_url":"https://api.github.com/users/MYOB-Technology/orgs","repos_url":"https://api.github.com/users/MYOB-Technology/repos","events_url":"https://api.github.com/users/MYOB-Technology/events{/privacy}","received_events_url":"https://api.github.com/users/MYOB-Technology/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MYOB-Technology/konfigurator","description":"CLI Tool to generate Kubernetes kubeconfig files using oidc tokens","fork":false,"url":"https://api.github.com/repos/MYOB-Technology/konfigurator","forks_url":"https://api.github.com/repos/MYOB-Technology/konfigurator/forks","keys_url":"https://api.github.com/repos/MYOB-Technology/konfigurator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MYOB-Technology/konfigurator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MYOB-Technology/konfigurator/teams","hooks_url":"https://api.github.com/repos/MYOB-Technology/konfigurator/hooks","issue_events_url":"https://api.github.com/repos/MYOB-Technology/konfigurator/issues/events{/number}","events_url":"https://api.github.com/repos/MYOB-Technology/konfigurator/events","assignees_url":"https://api.github.com/repos/MYOB-Technology/konfigurator/assignees{/user}","branches_url":"https://api.github.com/repos/MYOB-Technology/konfigurator/branches{/branch}","tags_url":"https://api.github.com/repos/MYOB-Technology/konfigurator/tags","blobs_url":"https://api.github.com/repos/MYOB-Technology/konfigurator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MYOB-Technology/konfigurator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MYOB-Technology/konfigurator/git/refs{/sha}","trees_url":"https://api.github.com/repos/MYOB-Technology/konfigurator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MYOB-Technology/konfigurator/statuses/{sha}","languages_url":"https://api.github.com/repos/MYOB-Technology/konfigurator/languages","stargazers_url":"https://api.github.com/repos/MYOB-Technology/konfigurator/stargazers","contributors_url":"https://api.github.com/repos/MYOB-Technology/konfigurator/contributors","subscribers_url":"https://api.github.com/repos/MYOB-Technology/konfigurator/subscribers","subscription_url":"https://api.github.com/repos/MYOB-Technology/konfigurator/subscription","commits_url":"https://api.github.com/repos/MYOB-Technology/konfigurator/commits{/sha}","git_commits_url":"https://api.github.com/repos/MYOB-Technology/konfigurator/git/commits{/sha}","comments_url":"https://api.github.com/repos/MYOB-Technology/konfigurator/comments{/number}","issue_comment_url":"https://api.github.com/repos/MYOB-Technology/konfigurator/issues/comments{/number}","contents_url":"https://api.github.com/repos/MYOB-Technology/konfigurator/contents/{+path}","compare_url":"https://api.github.com/repos/MYOB-Technology/konfigurator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MYOB-Technology/konfigurator/merges","archive_url":"https://api.github.com/repos/MYOB-Technology/konfigurator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MYOB-Technology/konfigurator/downloads","issues_url":"https://api.github.com/repos/MYOB-Technology/konfigurator/issues{/number}","pulls_url":"https://api.github.com/repos/MYOB-Technology/konfigurator/pulls{/number}","milestones_url":"https://api.github.com/repos/MYOB-Technology/konfigurator/milestones{/number}","notifications_url":"https://api.github.com/repos/MYOB-Technology/konfigurator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MYOB-Technology/konfigurator/labels{/name}","releases_url":"https://api.github.com/repos/MYOB-Technology/konfigurator/releases{/id}","deployments_url":"https://api.github.com/repos/MYOB-Technology/konfigurator/deployments","created_at":"2017-07-25T02:22:32Z","updated_at":"2017-08-07T05:33:30Z","pushed_at":"2017-08-29T23:43:23Z","git_url":"git://github.com/MYOB-Technology/konfigurator.git","ssh_url":"git@github.com:MYOB-Technology/konfigurator.git","clone_url":"https://github.com/MYOB-Technology/konfigurator.git","svn_url":"https://github.com/MYOB-Technology/konfigurator","homepage":"","size":30,"stargazers_count":2,"watchers_count":2,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":2,"default_branch":"master"}},"base":{"label":"MYOB-Technology:master","ref":"master","sha":"86807b855046d5deb154d338cb27cc2a40754fed","user":{"login":"MYOB-Technology","id":1910591,"avatar_url":"https://avatars1.githubusercontent.com/u/1910591?v=4","gravatar_id":"","url":"https://api.github.com/users/MYOB-Technology","html_url":"https://github.com/MYOB-Technology","followers_url":"https://api.github.com/users/MYOB-Technology/followers","following_url":"https://api.github.com/users/MYOB-Technology/following{/other_user}","gists_url":"https://api.github.com/users/MYOB-Technology/gists{/gist_id}","starred_url":"https://api.github.com/users/MYOB-Technology/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MYOB-Technology/subscriptions","organizations_url":"https://api.github.com/users/MYOB-Technology/orgs","repos_url":"https://api.github.com/users/MYOB-Technology/repos","events_url":"https://api.github.com/users/MYOB-Technology/events{/privacy}","received_events_url":"https://api.github.com/users/MYOB-Technology/received_events","type":"Organization","site_admin":false},"repo":{"id":98254617,"name":"konfigurator","full_name":"MYOB-Technology/konfigurator","owner":{"login":"MYOB-Technology","id":1910591,"avatar_url":"https://avatars1.githubusercontent.com/u/1910591?v=4","gravatar_id":"","url":"https://api.github.com/users/MYOB-Technology","html_url":"https://github.com/MYOB-Technology","followers_url":"https://api.github.com/users/MYOB-Technology/followers","following_url":"https://api.github.com/users/MYOB-Technology/following{/other_user}","gists_url":"https://api.github.com/users/MYOB-Technology/gists{/gist_id}","starred_url":"https://api.github.com/users/MYOB-Technology/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MYOB-Technology/subscriptions","organizations_url":"https://api.github.com/users/MYOB-Technology/orgs","repos_url":"https://api.github.com/users/MYOB-Technology/repos","events_url":"https://api.github.com/users/MYOB-Technology/events{/privacy}","received_events_url":"https://api.github.com/users/MYOB-Technology/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MYOB-Technology/konfigurator","description":"CLI Tool to generate Kubernetes kubeconfig files using oidc tokens","fork":false,"url":"https://api.github.com/repos/MYOB-Technology/konfigurator","forks_url":"https://api.github.com/repos/MYOB-Technology/konfigurator/forks","keys_url":"https://api.github.com/repos/MYOB-Technology/konfigurator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MYOB-Technology/konfigurator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MYOB-Technology/konfigurator/teams","hooks_url":"https://api.github.com/repos/MYOB-Technology/konfigurator/hooks","issue_events_url":"https://api.github.com/repos/MYOB-Technology/konfigurator/issues/events{/number}","events_url":"https://api.github.com/repos/MYOB-Technology/konfigurator/events","assignees_url":"https://api.github.com/repos/MYOB-Technology/konfigurator/assignees{/user}","branches_url":"https://api.github.com/repos/MYOB-Technology/konfigurator/branches{/branch}","tags_url":"https://api.github.com/repos/MYOB-Technology/konfigurator/tags","blobs_url":"https://api.github.com/repos/MYOB-Technology/konfigurator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MYOB-Technology/konfigurator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MYOB-Technology/konfigurator/git/refs{/sha}","trees_url":"https://api.github.com/repos/MYOB-Technology/konfigurator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MYOB-Technology/konfigurator/statuses/{sha}","languages_url":"https://api.github.com/repos/MYOB-Technology/konfigurator/languages","stargazers_url":"https://api.github.com/repos/MYOB-Technology/konfigurator/stargazers","contributors_url":"https://api.github.com/repos/MYOB-Technology/konfigurator/contributors","subscribers_url":"https://api.github.com/repos/MYOB-Technology/konfigurator/subscribers","subscription_url":"https://api.github.com/repos/MYOB-Technology/konfigurator/subscription","commits_url":"https://api.github.com/repos/MYOB-Technology/konfigurator/commits{/sha}","git_commits_url":"https://api.github.com/repos/MYOB-Technology/konfigurator/git/commits{/sha}","comments_url":"https://api.github.com/repos/MYOB-Technology/konfigurator/comments{/number}","issue_comment_url":"https://api.github.com/repos/MYOB-Technology/konfigurator/issues/comments{/number}","contents_url":"https://api.github.com/repos/MYOB-Technology/konfigurator/contents/{+path}","compare_url":"https://api.github.com/repos/MYOB-Technology/konfigurator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MYOB-Technology/konfigurator/merges","archive_url":"https://api.github.com/repos/MYOB-Technology/konfigurator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MYOB-Technology/konfigurator/downloads","issues_url":"https://api.github.com/repos/MYOB-Technology/konfigurator/issues{/number}","pulls_url":"https://api.github.com/repos/MYOB-Technology/konfigurator/pulls{/number}","milestones_url":"https://api.github.com/repos/MYOB-Technology/konfigurator/milestones{/number}","notifications_url":"https://api.github.com/repos/MYOB-Technology/konfigurator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MYOB-Technology/konfigurator/labels{/name}","releases_url":"https://api.github.com/repos/MYOB-Technology/konfigurator/releases{/id}","deployments_url":"https://api.github.com/repos/MYOB-Technology/konfigurator/deployments","created_at":"2017-07-25T02:22:32Z","updated_at":"2017-08-07T05:33:30Z","pushed_at":"2017-08-29T23:43:23Z","git_url":"git://github.com/MYOB-Technology/konfigurator.git","ssh_url":"git@github.com:MYOB-Technology/konfigurator.git","clone_url":"https://github.com/MYOB-Technology/konfigurator.git","svn_url":"https://github.com/MYOB-Technology/konfigurator","homepage":"","size":30,"stargazers_count":2,"watchers_count":2,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MYOB-Technology/konfigurator/pulls/7"},"html":{"href":"https://github.com/MYOB-Technology/konfigurator/pull/7"},"issue":{"href":"https://api.github.com/repos/MYOB-Technology/konfigurator/issues/7"},"comments":{"href":"https://api.github.com/repos/MYOB-Technology/konfigurator/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/MYOB-Technology/konfigurator/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/MYOB-Technology/konfigurator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MYOB-Technology/konfigurator/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/MYOB-Technology/konfigurator/statuses/ef41947af8b9485fc98c8b7fd98298b3eec6a1e6"}},"author_association":"OWNER"}}
{"actor":{"display_login":"gugahoi"}}