{"action":"closed","number":1415,"pull_request":{"url":"https://api.github.com/repos/fatih/vim-go/pulls/1415","id":136408700,"html_url":"https://github.com/fatih/vim-go/pull/1415","diff_url":"https://github.com/fatih/vim-go/pull/1415.diff","patch_url":"https://github.com/fatih/vim-go/pull/1415.patch","issue_url":"https://api.github.com/repos/fatih/vim-go/issues/1415","number":1415,"state":"closed","locked":false,"title":"support for customizable lists types","user":{"login":"bhcleek","id":1958864,"avatar_url":"https://avatars1.githubusercontent.com/u/1958864?v=4","gravatar_id":"","url":"https://api.github.com/users/bhcleek","html_url":"https://github.com/bhcleek","followers_url":"https://api.github.com/users/bhcleek/followers","following_url":"https://api.github.com/users/bhcleek/following{/other_user}","gists_url":"https://api.github.com/users/bhcleek/gists{/gist_id}","starred_url":"https://api.github.com/users/bhcleek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bhcleek/subscriptions","organizations_url":"https://api.github.com/users/bhcleek/orgs","repos_url":"https://api.github.com/users/bhcleek/repos","events_url":"https://api.github.com/users/bhcleek/events{/privacy}","received_events_url":"https://api.github.com/users/bhcleek/received_events","type":"User","site_admin":false},"body":"Add a new setting, `g:go_list_type_commands`: a dictionary\r\nwhose entries allows users to customize whether to use the quickfix list\r\nor the location list for each command. The dictionary does not require\r\nan entry for every command; only those the user wants to specify.\r\n\r\nWhen g:go_list_type is set and g:go_list_type_commands contains an entry\r\nfor a command, go:go_list_type_commands takes precedence.\r\n\r\nI'm not totally happy with the keys for the commands in the `g:go_list_type_commands` dictionary. Currently the entries map very closely to the commands (e.g. `:GoBuild`), providing an easy to understand set of keys for most users. Unfortunately, the `GoModifyTags` entry applies to both `:GoRemoveTags` and `:GoAddTags` commands, because the way those two commands are implemented makes it a little difficult to vary the key used and also because it seemed strange to allow those two commands to use different lists since they are each other's inverse.\r\n\r\nI considered using a smaller set of keys that are more closely aligned with the general class of command that needs to use the key (e.g. `build`, `install`, `fmt`, `lint`, `modifytags`) instead of the specific command that needs to use the key. Such a scheme would use a single key, `lint`, for all linting commands (e.g. `:GoMetaLinter`, `:GoLint`, `:GoErrCheck`)...\r\n\r\nI'm open to suggestions on the key names and how much documentation there should be for them.\r\n\r\nI could also use some help testing this, since there's different code paths for Vim 7, Vim 8, and Neovim.\r\n\r\nFixes #1408","created_at":"2017-08-18T06:15:31Z","updated_at":"2017-09-12T08:15:35Z","closed_at":"2017-09-12T08:15:35Z","merged_at":"2017-09-12T08:15:34Z","merge_commit_sha":"df60f2652d2d85058cb46a5be6d5e933ebaded4b","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/fatih/vim-go/pulls/1415/commits","review_comments_url":"https://api.github.com/repos/fatih/vim-go/pulls/1415/comments","review_comment_url":"https://api.github.com/repos/fatih/vim-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fatih/vim-go/issues/1415/comments","statuses_url":"https://api.github.com/repos/fatih/vim-go/statuses/4d3a52ed7d370d8a03644370248dfa263945e9bb","head":{"label":"bhcleek:customizable-lists","ref":"customizable-lists","sha":"4d3a52ed7d370d8a03644370248dfa263945e9bb","user":{"login":"bhcleek","id":1958864,"avatar_url":"https://avatars1.githubusercontent.com/u/1958864?v=4","gravatar_id":"","url":"https://api.github.com/users/bhcleek","html_url":"https://github.com/bhcleek","followers_url":"https://api.github.com/users/bhcleek/followers","following_url":"https://api.github.com/users/bhcleek/following{/other_user}","gists_url":"https://api.github.com/users/bhcleek/gists{/gist_id}","starred_url":"https://api.github.com/users/bhcleek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bhcleek/subscriptions","organizations_url":"https://api.github.com/users/bhcleek/orgs","repos_url":"https://api.github.com/users/bhcleek/repos","events_url":"https://api.github.com/users/bhcleek/events{/privacy}","received_events_url":"https://api.github.com/users/bhcleek/received_events","type":"User","site_admin":false},"repo":{"id":18502669,"name":"vim-go","full_name":"bhcleek/vim-go","owner":{"login":"bhcleek","id":1958864,"avatar_url":"https://avatars1.githubusercontent.com/u/1958864?v=4","gravatar_id":"","url":"https://api.github.com/users/bhcleek","html_url":"https://github.com/bhcleek","followers_url":"https://api.github.com/users/bhcleek/followers","following_url":"https://api.github.com/users/bhcleek/following{/other_user}","gists_url":"https://api.github.com/users/bhcleek/gists{/gist_id}","starred_url":"https://api.github.com/users/bhcleek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bhcleek/subscriptions","organizations_url":"https://api.github.com/users/bhcleek/orgs","repos_url":"https://api.github.com/users/bhcleek/repos","events_url":"https://api.github.com/users/bhcleek/events{/privacy}","received_events_url":"https://api.github.com/users/bhcleek/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bhcleek/vim-go","description":"Go development plugin for Vim","fork":true,"url":"https://api.github.com/repos/bhcleek/vim-go","forks_url":"https://api.github.com/repos/bhcleek/vim-go/forks","keys_url":"https://api.github.com/repos/bhcleek/vim-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bhcleek/vim-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bhcleek/vim-go/teams","hooks_url":"https://api.github.com/repos/bhcleek/vim-go/hooks","issue_events_url":"https://api.github.com/repos/bhcleek/vim-go/issues/events{/number}","events_url":"https://api.github.com/repos/bhcleek/vim-go/events","assignees_url":"https://api.github.com/repos/bhcleek/vim-go/assignees{/user}","branches_url":"https://api.github.com/repos/bhcleek/vim-go/branches{/branch}","tags_url":"https://api.github.com/repos/bhcleek/vim-go/tags","blobs_url":"https://api.github.com/repos/bhcleek/vim-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bhcleek/vim-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bhcleek/vim-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/bhcleek/vim-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bhcleek/vim-go/statuses/{sha}","languages_url":"https://api.github.com/repos/bhcleek/vim-go/languages","stargazers_url":"https://api.github.com/repos/bhcleek/vim-go/stargazers","contributors_url":"https://api.github.com/repos/bhcleek/vim-go/contributors","subscribers_url":"https://api.github.com/repos/bhcleek/vim-go/subscribers","subscription_url":"https://api.github.com/repos/bhcleek/vim-go/subscription","commits_url":"https://api.github.com/repos/bhcleek/vim-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/bhcleek/vim-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/bhcleek/vim-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/bhcleek/vim-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/bhcleek/vim-go/contents/{+path}","compare_url":"https://api.github.com/repos/bhcleek/vim-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bhcleek/vim-go/merges","archive_url":"https://api.github.com/repos/bhcleek/vim-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bhcleek/vim-go/downloads","issues_url":"https://api.github.com/repos/bhcleek/vim-go/issues{/number}","pulls_url":"https://api.github.com/repos/bhcleek/vim-go/pulls{/number}","milestones_url":"https://api.github.com/repos/bhcleek/vim-go/milestones{/number}","notifications_url":"https://api.github.com/repos/bhcleek/vim-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bhcleek/vim-go/labels{/name}","releases_url":"https://api.github.com/repos/bhcleek/vim-go/releases{/id}","deployments_url":"https://api.github.com/repos/bhcleek/vim-go/deployments","created_at":"2014-04-07T00:26:54Z","updated_at":"2017-09-09T19:08:54Z","pushed_at":"2017-09-09T19:08:28Z","git_url":"git://github.com/bhcleek/vim-go.git","ssh_url":"git@github.com:bhcleek/vim-go.git","clone_url":"https://github.com/bhcleek/vim-go.git","svn_url":"https://github.com/bhcleek/vim-go","homepage":"","size":2871,"stargazers_count":0,"watchers_count":0,"language":"Vim script","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fatih:master","ref":"master","sha":"52c5b1f74dade7ef21b34675751cd4a7b3ee2d03","user":{"login":"fatih","id":438920,"avatar_url":"https://avatars1.githubusercontent.com/u/438920?v=4","gravatar_id":"","url":"https://api.github.com/users/fatih","html_url":"https://github.com/fatih","followers_url":"https://api.github.com/users/fatih/followers","following_url":"https://api.github.com/users/fatih/following{/other_user}","gists_url":"https://api.github.com/users/fatih/gists{/gist_id}","starred_url":"https://api.github.com/users/fatih/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fatih/subscriptions","organizations_url":"https://api.github.com/users/fatih/orgs","repos_url":"https://api.github.com/users/fatih/repos","events_url":"https://api.github.com/users/fatih/events{/privacy}","received_events_url":"https://api.github.com/users/fatih/received_events","type":"User","site_admin":false},"repo":{"id":18062944,"name":"vim-go","full_name":"fatih/vim-go","owner":{"login":"fatih","id":438920,"avatar_url":"https://avatars1.githubusercontent.com/u/438920?v=4","gravatar_id":"","url":"https://api.github.com/users/fatih","html_url":"https://github.com/fatih","followers_url":"https://api.github.com/users/fatih/followers","following_url":"https://api.github.com/users/fatih/following{/other_user}","gists_url":"https://api.github.com/users/fatih/gists{/gist_id}","starred_url":"https://api.github.com/users/fatih/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fatih/subscriptions","organizations_url":"https://api.github.com/users/fatih/orgs","repos_url":"https://api.github.com/users/fatih/repos","events_url":"https://api.github.com/users/fatih/events{/privacy}","received_events_url":"https://api.github.com/users/fatih/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fatih/vim-go","description":"Go development plugin for Vim","fork":false,"url":"https://api.github.com/repos/fatih/vim-go","forks_url":"https://api.github.com/repos/fatih/vim-go/forks","keys_url":"https://api.github.com/repos/fatih/vim-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fatih/vim-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fatih/vim-go/teams","hooks_url":"https://api.github.com/repos/fatih/vim-go/hooks","issue_events_url":"https://api.github.com/repos/fatih/vim-go/issues/events{/number}","events_url":"https://api.github.com/repos/fatih/vim-go/events","assignees_url":"https://api.github.com/repos/fatih/vim-go/assignees{/user}","branches_url":"https://api.github.com/repos/fatih/vim-go/branches{/branch}","tags_url":"https://api.github.com/repos/fatih/vim-go/tags","blobs_url":"https://api.github.com/repos/fatih/vim-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fatih/vim-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fatih/vim-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/fatih/vim-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fatih/vim-go/statuses/{sha}","languages_url":"https://api.github.com/repos/fatih/vim-go/languages","stargazers_url":"https://api.github.com/repos/fatih/vim-go/stargazers","contributors_url":"https://api.github.com/repos/fatih/vim-go/contributors","subscribers_url":"https://api.github.com/repos/fatih/vim-go/subscribers","subscription_url":"https://api.github.com/repos/fatih/vim-go/subscription","commits_url":"https://api.github.com/repos/fatih/vim-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/fatih/vim-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/fatih/vim-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/fatih/vim-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/fatih/vim-go/contents/{+path}","compare_url":"https://api.github.com/repos/fatih/vim-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fatih/vim-go/merges","archive_url":"https://api.github.com/repos/fatih/vim-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fatih/vim-go/downloads","issues_url":"https://api.github.com/repos/fatih/vim-go/issues{/number}","pulls_url":"https://api.github.com/repos/fatih/vim-go/pulls{/number}","milestones_url":"https://api.github.com/repos/fatih/vim-go/milestones{/number}","notifications_url":"https://api.github.com/repos/fatih/vim-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fatih/vim-go/labels{/name}","releases_url":"https://api.github.com/repos/fatih/vim-go/releases{/id}","deployments_url":"https://api.github.com/repos/fatih/vim-go/deployments","created_at":"2014-03-24T13:12:26Z","updated_at":"2017-09-12T07:47:21Z","pushed_at":"2017-09-12T08:15:34Z","git_url":"git://github.com/fatih/vim-go.git","ssh_url":"git@github.com:fatih/vim-go.git","clone_url":"https://github.com/fatih/vim-go.git","svn_url":"https://github.com/fatih/vim-go","homepage":"https://patreon.com/fatih","size":2921,"stargazers_count":7137,"watchers_count":7137,"language":"Vim script","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":714,"mirror_url":null,"open_issues_count":24,"forks":714,"open_issues":24,"watchers":7137,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fatih/vim-go/pulls/1415"},"html":{"href":"https://github.com/fatih/vim-go/pull/1415"},"issue":{"href":"https://api.github.com/repos/fatih/vim-go/issues/1415"},"comments":{"href":"https://api.github.com/repos/fatih/vim-go/issues/1415/comments"},"review_comments":{"href":"https://api.github.com/repos/fatih/vim-go/pulls/1415/comments"},"review_comment":{"href":"https://api.github.com/repos/fatih/vim-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fatih/vim-go/pulls/1415/commits"},"statuses":{"href":"https://api.github.com/repos/fatih/vim-go/statuses/4d3a52ed7d370d8a03644370248dfa263945e9bb"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"fatih","id":438920,"avatar_url":"https://avatars1.githubusercontent.com/u/438920?v=4","gravatar_id":"","url":"https://api.github.com/users/fatih","html_url":"https://github.com/fatih","followers_url":"https://api.github.com/users/fatih/followers","following_url":"https://api.github.com/users/fatih/following{/other_user}","gists_url":"https://api.github.com/users/fatih/gists{/gist_id}","starred_url":"https://api.github.com/users/fatih/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fatih/subscriptions","organizations_url":"https://api.github.com/users/fatih/orgs","repos_url":"https://api.github.com/users/fatih/repos","events_url":"https://api.github.com/users/fatih/events{/privacy}","received_events_url":"https://api.github.com/users/fatih/received_events","type":"User","site_admin":false},"comments":12,"review_comments":5,"maintainer_can_modify":false,"commits":4,"additions":86,"deletions":61,"changed_files":13}}
{"actor":{"display_login":"fatih"}}