{"action":"opened","issue":{"url":"https://api.github.com/repos/rathena/rathena/issues/1922","repository_url":"https://api.github.com/repos/rathena/rathena","labels_url":"https://api.github.com/repos/rathena/rathena/issues/1922/labels{/name}","comments_url":"https://api.github.com/repos/rathena/rathena/issues/1922/comments","events_url":"https://api.github.com/repos/rathena/rathena/issues/1922/events","html_url":"https://github.com/rathena/rathena/issues/1922","id":203756791,"number":1922,"title":"import folder itemdb_read_combos will overwrite entries in the db/x-re/combo dbs!!","user":{"login":"mrjnumber1","id":8746741,"avatar_url":"https://avatars.githubusercontent.com/u/8746741?v=3","gravatar_id":"","url":"https://api.github.com/users/mrjnumber1","html_url":"https://github.com/mrjnumber1","followers_url":"https://api.github.com/users/mrjnumber1/followers","following_url":"https://api.github.com/users/mrjnumber1/following{/other_user}","gists_url":"https://api.github.com/users/mrjnumber1/gists{/gist_id}","starred_url":"https://api.github.com/users/mrjnumber1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrjnumber1/subscriptions","organizations_url":"https://api.github.com/users/mrjnumber1/orgs","repos_url":"https://api.github.com/users/mrjnumber1/repos","events_url":"https://api.github.com/users/mrjnumber1/events{/privacy}","received_events_url":"https://api.github.com/users/mrjnumber1/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-01-27T22:31:14Z","updated_at":"2017-01-27T22:31:14Z","closed_at":null,"body":"* **rAthena Hash**: \r\n\r\ncurrent\r\n\r\n* **Server Mode**: \r\n\r\nshould apply for either\r\n\r\n* **Description of Issue**: \r\n\r\nwhen an entry is placed in db/import/item_combo_db.txt it overwrites the first entries of db/(pre-)?re/item_combo_db.txt because of how itemdb_read_combos is coded. accidentally this means that people's custom combos are breaking default combos! oops...\r\n\r\nsee here https://github.com/rathena/rathena/blob/master/src/map/itemdb.c#L1027-L1052\r\nto match with other readdb loads, we'd need a static combos_count variables that is added to the id->combos[idx]->id, or before parsing we use a size = uidb_size(item_combo...) and add that to id->combos[idx]->id for every entry loaded.\r\n\r\n\r\nthere may be other imported files overwriting defaults, please investigate the others!!"}}
{"actor":{"display_login":"mrjnumber1"}}