{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/openj9/pulls/comments/152821632","pull_request_review_id":78742609,"id":152821632,"diff_hunk":"@@ -883,6 +883,24 @@ sendFromMethodDescriptorString(J9VMThread *currentThread, J9UTF8 *descriptor, J9\n \t\t\t\tcurrentThread->returnValue2 = (UDATA)J9VMJAVALANGINVOKEMETHODTYPE_FROMMETHODDESCRIPTORSTRINGAPPENDARG_METHOD(vm);\n \t\t\t}\n \t\t\tc_cInterpreter(currentThread);\n+\t\t\tif (VM_VMHelpers::exceptionPending(currentThread)) {","path":"runtime/vm/callin.cpp","position":null,"original_position":4,"commit_id":"8f427bdbfa07cffc3eb52d71eb01982d6dc8f04c","original_commit_id":"3f6b771de676548a89b49c2a7383bef8049045e4","user":{"login":"babsingh","id":8634038,"avatar_url":"https://avatars1.githubusercontent.com/u/8634038?v=4","gravatar_id":"","url":"https://api.github.com/users/babsingh","html_url":"https://github.com/babsingh","followers_url":"https://api.github.com/users/babsingh/followers","following_url":"https://api.github.com/users/babsingh/following{/other_user}","gists_url":"https://api.github.com/users/babsingh/gists{/gist_id}","starred_url":"https://api.github.com/users/babsingh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/babsingh/subscriptions","organizations_url":"https://api.github.com/users/babsingh/orgs","repos_url":"https://api.github.com/users/babsingh/repos","events_url":"https://api.github.com/users/babsingh/events{/privacy}","received_events_url":"https://api.github.com/users/babsingh/received_events","type":"User","site_admin":false},"body":"completed.","created_at":"2017-11-23T15:02:30Z","updated_at":"2017-11-23T15:02:30Z","html_url":"https://github.com/eclipse/openj9/pull/610#discussion_r152821632","pull_request_url":"https://api.github.com/repos/eclipse/openj9/pulls/610","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/comments/152821632"},"html":{"href":"https://github.com/eclipse/openj9/pull/610#discussion_r152821632"},"pull_request":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/610"}},"in_reply_to_id":152463559},"pull_request":{"url":"https://api.github.com/repos/eclipse/openj9/pulls/610","id":153134523,"html_url":"https://github.com/eclipse/openj9/pull/610","diff_url":"https://github.com/eclipse/openj9/pull/610.diff","patch_url":"https://github.com/eclipse/openj9/pull/610.patch","issue_url":"https://api.github.com/repos/eclipse/openj9/issues/610","number":610,"state":"open","locked":false,"title":"Throw NoClassDefFoundError instead of TypeNotPresentException","user":{"login":"babsingh","id":8634038,"avatar_url":"https://avatars1.githubusercontent.com/u/8634038?v=4","gravatar_id":"","url":"https://api.github.com/users/babsingh","html_url":"https://github.com/babsingh","followers_url":"https://api.github.com/users/babsingh/followers","following_url":"https://api.github.com/users/babsingh/following{/other_user}","gists_url":"https://api.github.com/users/babsingh/gists{/gist_id}","starred_url":"https://api.github.com/users/babsingh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/babsingh/subscriptions","organizations_url":"https://api.github.com/users/babsingh/orgs","repos_url":"https://api.github.com/users/babsingh/repos","events_url":"https://api.github.com/users/babsingh/events{/privacy}","received_events_url":"https://api.github.com/users/babsingh/received_events","type":"User","site_admin":false},"body":"Change 1:\r\n\r\nWhen the VM is resolving a `MethodType`, `NoClassDefFoundError` should be thrown instead of `TypeNotPresentException`.\r\n\r\n\r\nChange 2:\r\n\r\nRenamed `test_indyn_ldc_invalid_type` to `test_indyn_ldc_non_existent_class_methodtype`. Updated test to check for `NoClassDefFoundError` instead of `TypeNotPresentException`.\r\n\r\nSigned-off-by: Babneet Singh <sbabneet@ca.ibm.com>\r\n","created_at":"2017-11-16T19:52:25Z","updated_at":"2017-11-23T15:02:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9727e2894e2713bcecc779112fe32bc3f7ad810c","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/openj9/pulls/610/commits","review_comments_url":"https://api.github.com/repos/eclipse/openj9/pulls/610/comments","review_comment_url":"https://api.github.com/repos/eclipse/openj9/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/openj9/issues/610/comments","statuses_url":"https://api.github.com/repos/eclipse/openj9/statuses/8f427bdbfa07cffc3eb52d71eb01982d6dc8f04c","head":{"label":"babsingh:fix_noclassdeferror","ref":"fix_noclassdeferror","sha":"8f427bdbfa07cffc3eb52d71eb01982d6dc8f04c","user":{"login":"babsingh","id":8634038,"avatar_url":"https://avatars1.githubusercontent.com/u/8634038?v=4","gravatar_id":"","url":"https://api.github.com/users/babsingh","html_url":"https://github.com/babsingh","followers_url":"https://api.github.com/users/babsingh/followers","following_url":"https://api.github.com/users/babsingh/following{/other_user}","gists_url":"https://api.github.com/users/babsingh/gists{/gist_id}","starred_url":"https://api.github.com/users/babsingh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/babsingh/subscriptions","organizations_url":"https://api.github.com/users/babsingh/orgs","repos_url":"https://api.github.com/users/babsingh/repos","events_url":"https://api.github.com/users/babsingh/events{/privacy}","received_events_url":"https://api.github.com/users/babsingh/received_events","type":"User","site_admin":false},"repo":{"id":103547656,"name":"openj9","full_name":"babsingh/openj9","owner":{"login":"babsingh","id":8634038,"avatar_url":"https://avatars1.githubusercontent.com/u/8634038?v=4","gravatar_id":"","url":"https://api.github.com/users/babsingh","html_url":"https://github.com/babsingh","followers_url":"https://api.github.com/users/babsingh/followers","following_url":"https://api.github.com/users/babsingh/following{/other_user}","gists_url":"https://api.github.com/users/babsingh/gists{/gist_id}","starred_url":"https://api.github.com/users/babsingh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/babsingh/subscriptions","organizations_url":"https://api.github.com/users/babsingh/orgs","repos_url":"https://api.github.com/users/babsingh/repos","events_url":"https://api.github.com/users/babsingh/events{/privacy}","received_events_url":"https://api.github.com/users/babsingh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/babsingh/openj9","description":"OpenJ9","fork":true,"url":"https://api.github.com/repos/babsingh/openj9","forks_url":"https://api.github.com/repos/babsingh/openj9/forks","keys_url":"https://api.github.com/repos/babsingh/openj9/keys{/key_id}","collaborators_url":"https://api.github.com/repos/babsingh/openj9/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/babsingh/openj9/teams","hooks_url":"https://api.github.com/repos/babsingh/openj9/hooks","issue_events_url":"https://api.github.com/repos/babsingh/openj9/issues/events{/number}","events_url":"https://api.github.com/repos/babsingh/openj9/events","assignees_url":"https://api.github.com/repos/babsingh/openj9/assignees{/user}","branches_url":"https://api.github.com/repos/babsingh/openj9/branches{/branch}","tags_url":"https://api.github.com/repos/babsingh/openj9/tags","blobs_url":"https://api.github.com/repos/babsingh/openj9/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/babsingh/openj9/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/babsingh/openj9/git/refs{/sha}","trees_url":"https://api.github.com/repos/babsingh/openj9/git/trees{/sha}","statuses_url":"https://api.github.com/repos/babsingh/openj9/statuses/{sha}","languages_url":"https://api.github.com/repos/babsingh/openj9/languages","stargazers_url":"https://api.github.com/repos/babsingh/openj9/stargazers","contributors_url":"https://api.github.com/repos/babsingh/openj9/contributors","subscribers_url":"https://api.github.com/repos/babsingh/openj9/subscribers","subscription_url":"https://api.github.com/repos/babsingh/openj9/subscription","commits_url":"https://api.github.com/repos/babsingh/openj9/commits{/sha}","git_commits_url":"https://api.github.com/repos/babsingh/openj9/git/commits{/sha}","comments_url":"https://api.github.com/repos/babsingh/openj9/comments{/number}","issue_comment_url":"https://api.github.com/repos/babsingh/openj9/issues/comments{/number}","contents_url":"https://api.github.com/repos/babsingh/openj9/contents/{+path}","compare_url":"https://api.github.com/repos/babsingh/openj9/compare/{base}...{head}","merges_url":"https://api.github.com/repos/babsingh/openj9/merges","archive_url":"https://api.github.com/repos/babsingh/openj9/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/babsingh/openj9/downloads","issues_url":"https://api.github.com/repos/babsingh/openj9/issues{/number}","pulls_url":"https://api.github.com/repos/babsingh/openj9/pulls{/number}","milestones_url":"https://api.github.com/repos/babsingh/openj9/milestones{/number}","notifications_url":"https://api.github.com/repos/babsingh/openj9/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/babsingh/openj9/labels{/name}","releases_url":"https://api.github.com/repos/babsingh/openj9/releases{/id}","deployments_url":"https://api.github.com/repos/babsingh/openj9/deployments","created_at":"2017-09-14T15:12:26Z","updated_at":"2017-09-14T15:12:55Z","pushed_at":"2017-11-23T08:45:29Z","git_url":"git://github.com/babsingh/openj9.git","ssh_url":"git@github.com:babsingh/openj9.git","clone_url":"https://github.com/babsingh/openj9.git","svn_url":"https://github.com/babsingh/openj9","homepage":null,"size":21590,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"d406f2b948ecd6445c0183d0792faeae9c8d4085","user":{"login":"eclipse","id":56974,"avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":101408117,"name":"openj9","full_name":"eclipse/openj9","owner":{"login":"eclipse","id":56974,"avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/openj9","description":"Eclipse OpenJ9: A Java Virtual Machine for OpenJDK that's optimized for small footprint, fast start-up, and high throughput.   Builds on Eclipse OMR (https://github.com/eclipse/omr) and combines with the Extensions for OpenJDK for OpenJ9 repo.","fork":false,"url":"https://api.github.com/repos/eclipse/openj9","forks_url":"https://api.github.com/repos/eclipse/openj9/forks","keys_url":"https://api.github.com/repos/eclipse/openj9/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/openj9/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/openj9/teams","hooks_url":"https://api.github.com/repos/eclipse/openj9/hooks","issue_events_url":"https://api.github.com/repos/eclipse/openj9/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/openj9/events","assignees_url":"https://api.github.com/repos/eclipse/openj9/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/openj9/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/openj9/tags","blobs_url":"https://api.github.com/repos/eclipse/openj9/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/openj9/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/openj9/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/openj9/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/openj9/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/openj9/languages","stargazers_url":"https://api.github.com/repos/eclipse/openj9/stargazers","contributors_url":"https://api.github.com/repos/eclipse/openj9/contributors","subscribers_url":"https://api.github.com/repos/eclipse/openj9/subscribers","subscription_url":"https://api.github.com/repos/eclipse/openj9/subscription","commits_url":"https://api.github.com/repos/eclipse/openj9/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/openj9/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/openj9/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/openj9/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/openj9/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/openj9/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/openj9/merges","archive_url":"https://api.github.com/repos/eclipse/openj9/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/openj9/downloads","issues_url":"https://api.github.com/repos/eclipse/openj9/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/openj9/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/openj9/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/openj9/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/openj9/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/openj9/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/openj9/deployments","created_at":"2017-08-25T13:46:07Z","updated_at":"2017-11-22T19:28:43Z","pushed_at":"2017-11-23T14:54:33Z","git_url":"git://github.com/eclipse/openj9.git","ssh_url":"git@github.com:eclipse/openj9.git","clone_url":"https://github.com/eclipse/openj9.git","svn_url":"https://github.com/eclipse/openj9","homepage":"","size":21569,"stargazers_count":1089,"watchers_count":1089,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":194,"mirror_url":null,"archived":false,"open_issues_count":201,"forks":194,"open_issues":201,"watchers":1089,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/610"},"html":{"href":"https://github.com/eclipse/openj9/pull/610"},"issue":{"href":"https://api.github.com/repos/eclipse/openj9/issues/610"},"comments":{"href":"https://api.github.com/repos/eclipse/openj9/issues/610/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/610/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/610/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/openj9/statuses/8f427bdbfa07cffc3eb52d71eb01982d6dc8f04c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"babsingh"}}