{"action":"created","comment":{"url":"https://api.github.com/repos/Project-OSRM/osrm-backend/pulls/comments/132688108","pull_request_review_id":55798502,"id":132688108,"diff_hunk":"@@ -180,7 +180,9 @@ class QueryHeap\n     {\n         BOOST_ASSERT(WasInserted(node));\n         const Key index = node_index.peek_index(node);\n-        return inserted_nodes[index].handle == HeapHandle{};\n+        auto const end_it = const_cast<HeapContainer&>(heap).end(); // non-const iterator","path":"include/util/query_heap.hpp","position":5,"original_position":5,"commit_id":"306324bca9b04b1260a0956d8e1a7ca1a9240d89","original_commit_id":"306324bca9b04b1260a0956d8e1a7ca1a9240d89","user":{"login":"oxidase","id":4421046,"avatar_url":"https://avatars1.githubusercontent.com/u/4421046?v=4","gravatar_id":"","url":"https://api.github.com/users/oxidase","html_url":"https://github.com/oxidase","followers_url":"https://api.github.com/users/oxidase/followers","following_url":"https://api.github.com/users/oxidase/following{/other_user}","gists_url":"https://api.github.com/users/oxidase/gists{/gist_id}","starred_url":"https://api.github.com/users/oxidase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oxidase/subscriptions","organizations_url":"https://api.github.com/users/oxidase/orgs","repos_url":"https://api.github.com/users/oxidase/repos","events_url":"https://api.github.com/users/oxidase/events{/privacy}","received_events_url":"https://api.github.com/users/oxidase/received_events","type":"User","site_admin":false},"body":"interestingly this method is used only in `DecreaseKey` in assertion. \r\nI guess  it can be removed here and in the tests,\r\nand in `DecreaseKey` \r\n`BOOST_ASSERT(reference.handle != HeapContainer::s_handle_from_iterator(heap.end())); // was not removed` ","created_at":"2017-08-11T13:42:30Z","updated_at":"2017-08-11T13:42:37Z","html_url":"https://github.com/Project-OSRM/osrm-backend/pull/4396#discussion_r132688108","pull_request_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/pulls/4396","_links":{"self":{"href":"https://api.github.com/repos/Project-OSRM/osrm-backend/pulls/comments/132688108"},"html":{"href":"https://github.com/Project-OSRM/osrm-backend/pull/4396#discussion_r132688108"},"pull_request":{"href":"https://api.github.com/repos/Project-OSRM/osrm-backend/pulls/4396"}}},"pull_request":{"url":"https://api.github.com/repos/Project-OSRM/osrm-backend/pulls/4396","id":135243007,"html_url":"https://github.com/Project-OSRM/osrm-backend/pull/4396","diff_url":"https://github.com/Project-OSRM/osrm-backend/pull/4396.diff","patch_url":"https://github.com/Project-OSRM/osrm-backend/pull/4396.patch","issue_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/issues/4396","number":4396,"state":"open","locked":false,"title":"Switch to reliable non-existent handle for QueryHeap items","user":{"login":"mloskot","id":80741,"avatar_url":"https://avatars2.githubusercontent.com/u/80741?v=4","gravatar_id":"","url":"https://api.github.com/users/mloskot","html_url":"https://github.com/mloskot","followers_url":"https://api.github.com/users/mloskot/followers","following_url":"https://api.github.com/users/mloskot/following{/other_user}","gists_url":"https://api.github.com/users/mloskot/gists{/gist_id}","starred_url":"https://api.github.com/users/mloskot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mloskot/subscriptions","organizations_url":"https://api.github.com/users/mloskot/orgs","repos_url":"https://api.github.com/users/mloskot/repos","events_url":"https://api.github.com/users/mloskot/events{/privacy}","received_events_url":"https://api.github.com/users/mloskot/received_events","type":"User","site_admin":false},"body":"# Issue\r\n\r\nDefault-constructed objects of (`boost::heap`) `handle_type` are singular, including the wrapped `handle_type::iterator`.\r\n\r\nApparently, MSVC iterator debug facilities strictly require that one singular instance is compared to another singular instance.\r\n\r\nIt is not possible to get check-comparabe iterators of non-singular and singular instances as owning container will always mismatch.\r\n\r\nInitially investigated at Boost ML (https://lists.boost.org/boost-users/2017/08/87787.php), eventually received confirmation via SO (https://stackoverflow.com/a/45622940/151641)\r\n\r\n## Tasklist\r\n - [x] review\r\n - [ ] adjust for comments\r\n","created_at":"2017-08-10T23:24:43Z","updated_at":"2017-08-11T13:42:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"141e66f745d4e702cb7da9a9ddcff28939a68a24","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/pulls/4396/commits","review_comments_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/pulls/4396/comments","review_comment_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/issues/4396/comments","statuses_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/statuses/306324bca9b04b1260a0956d8e1a7ca1a9240d89","head":{"label":"mloskot:ml/queryheap-none-handle","ref":"ml/queryheap-none-handle","sha":"306324bca9b04b1260a0956d8e1a7ca1a9240d89","user":{"login":"mloskot","id":80741,"avatar_url":"https://avatars2.githubusercontent.com/u/80741?v=4","gravatar_id":"","url":"https://api.github.com/users/mloskot","html_url":"https://github.com/mloskot","followers_url":"https://api.github.com/users/mloskot/followers","following_url":"https://api.github.com/users/mloskot/following{/other_user}","gists_url":"https://api.github.com/users/mloskot/gists{/gist_id}","starred_url":"https://api.github.com/users/mloskot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mloskot/subscriptions","organizations_url":"https://api.github.com/users/mloskot/orgs","repos_url":"https://api.github.com/users/mloskot/repos","events_url":"https://api.github.com/users/mloskot/events{/privacy}","received_events_url":"https://api.github.com/users/mloskot/received_events","type":"User","site_admin":false},"repo":{"id":81460580,"name":"osrm-backend","full_name":"mloskot/osrm-backend","owner":{"login":"mloskot","id":80741,"avatar_url":"https://avatars2.githubusercontent.com/u/80741?v=4","gravatar_id":"","url":"https://api.github.com/users/mloskot","html_url":"https://github.com/mloskot","followers_url":"https://api.github.com/users/mloskot/followers","following_url":"https://api.github.com/users/mloskot/following{/other_user}","gists_url":"https://api.github.com/users/mloskot/gists{/gist_id}","starred_url":"https://api.github.com/users/mloskot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mloskot/subscriptions","organizations_url":"https://api.github.com/users/mloskot/orgs","repos_url":"https://api.github.com/users/mloskot/repos","events_url":"https://api.github.com/users/mloskot/events{/privacy}","received_events_url":"https://api.github.com/users/mloskot/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mloskot/osrm-backend","description":"Open Source Routing Machine - C++ backend","fork":true,"url":"https://api.github.com/repos/mloskot/osrm-backend","forks_url":"https://api.github.com/repos/mloskot/osrm-backend/forks","keys_url":"https://api.github.com/repos/mloskot/osrm-backend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mloskot/osrm-backend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mloskot/osrm-backend/teams","hooks_url":"https://api.github.com/repos/mloskot/osrm-backend/hooks","issue_events_url":"https://api.github.com/repos/mloskot/osrm-backend/issues/events{/number}","events_url":"https://api.github.com/repos/mloskot/osrm-backend/events","assignees_url":"https://api.github.com/repos/mloskot/osrm-backend/assignees{/user}","branches_url":"https://api.github.com/repos/mloskot/osrm-backend/branches{/branch}","tags_url":"https://api.github.com/repos/mloskot/osrm-backend/tags","blobs_url":"https://api.github.com/repos/mloskot/osrm-backend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mloskot/osrm-backend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mloskot/osrm-backend/git/refs{/sha}","trees_url":"https://api.github.com/repos/mloskot/osrm-backend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mloskot/osrm-backend/statuses/{sha}","languages_url":"https://api.github.com/repos/mloskot/osrm-backend/languages","stargazers_url":"https://api.github.com/repos/mloskot/osrm-backend/stargazers","contributors_url":"https://api.github.com/repos/mloskot/osrm-backend/contributors","subscribers_url":"https://api.github.com/repos/mloskot/osrm-backend/subscribers","subscription_url":"https://api.github.com/repos/mloskot/osrm-backend/subscription","commits_url":"https://api.github.com/repos/mloskot/osrm-backend/commits{/sha}","git_commits_url":"https://api.github.com/repos/mloskot/osrm-backend/git/commits{/sha}","comments_url":"https://api.github.com/repos/mloskot/osrm-backend/comments{/number}","issue_comment_url":"https://api.github.com/repos/mloskot/osrm-backend/issues/comments{/number}","contents_url":"https://api.github.com/repos/mloskot/osrm-backend/contents/{+path}","compare_url":"https://api.github.com/repos/mloskot/osrm-backend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mloskot/osrm-backend/merges","archive_url":"https://api.github.com/repos/mloskot/osrm-backend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mloskot/osrm-backend/downloads","issues_url":"https://api.github.com/repos/mloskot/osrm-backend/issues{/number}","pulls_url":"https://api.github.com/repos/mloskot/osrm-backend/pulls{/number}","milestones_url":"https://api.github.com/repos/mloskot/osrm-backend/milestones{/number}","notifications_url":"https://api.github.com/repos/mloskot/osrm-backend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mloskot/osrm-backend/labels{/name}","releases_url":"https://api.github.com/repos/mloskot/osrm-backend/releases{/id}","deployments_url":"https://api.github.com/repos/mloskot/osrm-backend/deployments","created_at":"2017-02-09T14:49:44Z","updated_at":"2017-03-07T18:37:31Z","pushed_at":"2017-08-10T23:20:52Z","git_url":"git://github.com/mloskot/osrm-backend.git","ssh_url":"git@github.com:mloskot/osrm-backend.git","clone_url":"https://github.com/mloskot/osrm-backend.git","svn_url":"https://github.com/mloskot/osrm-backend","homepage":"http://map.project-osrm.org","size":23123,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Project-OSRM:master","ref":"master","sha":"3a01ba52efe9be6acbd2ec16c8ea4971deff62ca","user":{"login":"Project-OSRM","id":8207060,"avatar_url":"https://avatars3.githubusercontent.com/u/8207060?v=4","gravatar_id":"","url":"https://api.github.com/users/Project-OSRM","html_url":"https://github.com/Project-OSRM","followers_url":"https://api.github.com/users/Project-OSRM/followers","following_url":"https://api.github.com/users/Project-OSRM/following{/other_user}","gists_url":"https://api.github.com/users/Project-OSRM/gists{/gist_id}","starred_url":"https://api.github.com/users/Project-OSRM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Project-OSRM/subscriptions","organizations_url":"https://api.github.com/users/Project-OSRM/orgs","repos_url":"https://api.github.com/users/Project-OSRM/repos","events_url":"https://api.github.com/users/Project-OSRM/events{/privacy}","received_events_url":"https://api.github.com/users/Project-OSRM/received_events","type":"Organization","site_admin":false},"repo":{"id":2436255,"name":"osrm-backend","full_name":"Project-OSRM/osrm-backend","owner":{"login":"Project-OSRM","id":8207060,"avatar_url":"https://avatars3.githubusercontent.com/u/8207060?v=4","gravatar_id":"","url":"https://api.github.com/users/Project-OSRM","html_url":"https://github.com/Project-OSRM","followers_url":"https://api.github.com/users/Project-OSRM/followers","following_url":"https://api.github.com/users/Project-OSRM/following{/other_user}","gists_url":"https://api.github.com/users/Project-OSRM/gists{/gist_id}","starred_url":"https://api.github.com/users/Project-OSRM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Project-OSRM/subscriptions","organizations_url":"https://api.github.com/users/Project-OSRM/orgs","repos_url":"https://api.github.com/users/Project-OSRM/repos","events_url":"https://api.github.com/users/Project-OSRM/events{/privacy}","received_events_url":"https://api.github.com/users/Project-OSRM/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Project-OSRM/osrm-backend","description":"Open Source Routing Machine - C++ backend","fork":false,"url":"https://api.github.com/repos/Project-OSRM/osrm-backend","forks_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/forks","keys_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/teams","hooks_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/hooks","issue_events_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/issues/events{/number}","events_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/events","assignees_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/assignees{/user}","branches_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/branches{/branch}","tags_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/tags","blobs_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/git/refs{/sha}","trees_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/statuses/{sha}","languages_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/languages","stargazers_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/stargazers","contributors_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/contributors","subscribers_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/subscribers","subscription_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/subscription","commits_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/commits{/sha}","git_commits_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/git/commits{/sha}","comments_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/comments{/number}","issue_comment_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/issues/comments{/number}","contents_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/contents/{+path}","compare_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/merges","archive_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/downloads","issues_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/issues{/number}","pulls_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/pulls{/number}","milestones_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/milestones{/number}","notifications_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/labels{/name}","releases_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/releases{/id}","deployments_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/deployments","created_at":"2011-09-22T10:05:08Z","updated_at":"2017-08-10T17:49:25Z","pushed_at":"2017-08-11T13:27:04Z","git_url":"git://github.com/Project-OSRM/osrm-backend.git","ssh_url":"git@github.com:Project-OSRM/osrm-backend.git","clone_url":"https://github.com/Project-OSRM/osrm-backend.git","svn_url":"https://github.com/Project-OSRM/osrm-backend","homepage":"http://map.project-osrm.org","size":40245,"stargazers_count":1852,"watchers_count":1852,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1051,"mirror_url":null,"open_issues_count":402,"forks":1051,"open_issues":402,"watchers":1852,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Project-OSRM/osrm-backend/pulls/4396"},"html":{"href":"https://github.com/Project-OSRM/osrm-backend/pull/4396"},"issue":{"href":"https://api.github.com/repos/Project-OSRM/osrm-backend/issues/4396"},"comments":{"href":"https://api.github.com/repos/Project-OSRM/osrm-backend/issues/4396/comments"},"review_comments":{"href":"https://api.github.com/repos/Project-OSRM/osrm-backend/pulls/4396/comments"},"review_comment":{"href":"https://api.github.com/repos/Project-OSRM/osrm-backend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Project-OSRM/osrm-backend/pulls/4396/commits"},"statuses":{"href":"https://api.github.com/repos/Project-OSRM/osrm-backend/statuses/306324bca9b04b1260a0956d8e1a7ca1a9240d89"}}}}
{"actor":{"display_login":"oxidase"}}