{"action":"created","comment":{"url":"https://api.github.com/repos/samsung-cnct/k2/pulls/comments/133715290","pull_request_review_id":56927949,"id":133715290,"diff_hunk":"@@ -365,6 +381,7 @@ definitions:\n       kind: provider\n       provider: aws\n       type: cloudinit\n+      networkTopology: private","path":"ansible/roles/kraken.config/files/config-private-topology.yaml","position":69,"original_position":69,"commit_id":"4d477fb943ae92d6dd3c4a026efbacd043e0c8e0","original_commit_id":"4d477fb943ae92d6dd3c4a026efbacd043e0c8e0","user":{"login":"alejandroEsc","id":20777618,"avatar_url":"https://avatars0.githubusercontent.com/u/20777618?v=4","gravatar_id":"","url":"https://api.github.com/users/alejandroEsc","html_url":"https://github.com/alejandroEsc","followers_url":"https://api.github.com/users/alejandroEsc/followers","following_url":"https://api.github.com/users/alejandroEsc/following{/other_user}","gists_url":"https://api.github.com/users/alejandroEsc/gists{/gist_id}","starred_url":"https://api.github.com/users/alejandroEsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alejandroEsc/subscriptions","organizations_url":"https://api.github.com/users/alejandroEsc/orgs","repos_url":"https://api.github.com/users/alejandroEsc/repos","events_url":"https://api.github.com/users/alejandroEsc/events{/privacy}","received_events_url":"https://api.github.com/users/alejandroEsc/received_events","type":"User","site_admin":false},"body":"it defaults to public, its not changing anything at the moment, but later i want to use it to check if the vpc should include a natted subnets. ","created_at":"2017-08-17T13:40:20Z","updated_at":"2017-08-17T13:40:20Z","html_url":"https://github.com/samsung-cnct/k2/pull/759#discussion_r133715290","pull_request_url":"https://api.github.com/repos/samsung-cnct/k2/pulls/759","_links":{"self":{"href":"https://api.github.com/repos/samsung-cnct/k2/pulls/comments/133715290"},"html":{"href":"https://github.com/samsung-cnct/k2/pull/759#discussion_r133715290"},"pull_request":{"href":"https://api.github.com/repos/samsung-cnct/k2/pulls/759"}}},"pull_request":{"url":"https://api.github.com/repos/samsung-cnct/k2/pulls/759","id":135939302,"html_url":"https://github.com/samsung-cnct/k2/pull/759","diff_url":"https://github.com/samsung-cnct/k2/pull/759.diff","patch_url":"https://github.com/samsung-cnct/k2/pull/759.patch","issue_url":"https://api.github.com/repos/samsung-cnct/k2/issues/759","number":759,"state":"open","locked":false,"title":"Added Bastion-ELB support, includes security enhancements to bastion nodes.","user":{"login":"alejandroEsc","id":20777618,"avatar_url":"https://avatars0.githubusercontent.com/u/20777618?v=4","gravatar_id":"","url":"https://api.github.com/users/alejandroEsc","html_url":"https://github.com/alejandroEsc","followers_url":"https://api.github.com/users/alejandroEsc/followers","following_url":"https://api.github.com/users/alejandroEsc/following{/other_user}","gists_url":"https://api.github.com/users/alejandroEsc/gists{/gist_id}","starred_url":"https://api.github.com/users/alejandroEsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alejandroEsc/subscriptions","organizations_url":"https://api.github.com/users/alejandroEsc/orgs","repos_url":"https://api.github.com/users/alejandroEsc/repos","events_url":"https://api.github.com/users/alejandroEsc/events{/privacy}","received_events_url":"https://api.github.com/users/alejandroEsc/received_events","type":"User","site_admin":false},"body":"resolves: https://github.com/samsung-cnct/k2/issues/735\r\n\r\n- ELB created pointing to each bastion\r\n- Cleaned cloud init for bastion node, should only contain bastion info and nothing else\r\n- Bastions are more configurable, now you can change ssh port, changes occur on each node and elb configured correctly\r\n- Bastion has been promoted to be a type of node, allowing us to configure it further for security concerns. \r\n- ELB can be launched at specific subnets that are in the same subnet as bastions, or not. \r\n\r\nexample output of this:\r\n\r\nssh_config\r\n```\r\nHost etcd-1\r\n  User core\r\n  StrictHostKeyChecking no\r\n  UserKnownHostsFile=/dev/null\r\n  ProxyCommand ssh core@ae-private-bastion-elb-2108550406.us-west-2.elb.amazonaws.com -p 22 -W 10.7.128.118:22\r\nHost etcdEvents-1\r\n  User core\r\n  StrictHostKeyChecking no\r\n  UserKnownHostsFile=/dev/null\r\n  ProxyCommand ssh core@ae-private-bastion-elb-2108550406.us-west-2.elb.amazonaws.com -p 22 -W 10.7.128.119:22\r\nHost master-1\r\n  User core\r\n  StrictHostKeyChecking no\r\n  UserKnownHostsFile=/dev/null\r\n  ProxyCommand ssh core@ae-private-bastion-elb-2108550406.us-west-2.elb.amazonaws.com -p 22 -W 10.7.128.33:22\r\nHost clusterNodes-1\r\n  User core\r\n  StrictHostKeyChecking no\r\n  UserKnownHostsFile=/dev/null\r\n  ProxyCommand ssh core@ae-private-bastion-elb-2108550406.us-west-2.elb.amazonaws.com -p 22 -W 10.7.128.145:22\r\n```\r\n\r\nbastion_ssh_config (in each bastion node)\r\n```\r\nHost etcd-1\r\n  HostName ip-10-7-128-118.us-west-2.compute.internal\r\n  User core\r\n  Port 22\r\n  StrictHostKeyChecking no\r\n  UserKnownHostsFile=/dev/null\r\nHost etcdEvents-1\r\n  HostName ip-10-7-128-119.us-west-2.compute.internal\r\n  User core\r\n  Port 22\r\n  StrictHostKeyChecking no\r\n  UserKnownHostsFile=/dev/null\r\nHost master-1\r\n  HostName ip-10-7-128-33.us-west-2.compute.internal\r\n  User core\r\n  Port 22\r\n  StrictHostKeyChecking no\r\n  UserKnownHostsFile=/dev/null\r\nHost clusterNodes-1\r\n  HostName ip-10-7-128-145.us-west-2.compute.internal\r\n  User core\r\n  Port 22\r\n  StrictHostKeyChecking no\r\n  UserKnownHostsFile=/dev/null\r\nHost bastion-1\r\n  HostName ip-10-7-1-81.us-west-2.compute.internal\r\n  User core\r\n  Port 22\r\n  StrictHostKeyChecking no\r\n  UserKnownHostsFile=/dev/null\r\n```","created_at":"2017-08-16T04:34:57Z","updated_at":"2017-08-17T13:40:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c442cf6d986405d7c5903722a421067075a1cd9a","assignee":{"login":"alejandroEsc","id":20777618,"avatar_url":"https://avatars0.githubusercontent.com/u/20777618?v=4","gravatar_id":"","url":"https://api.github.com/users/alejandroEsc","html_url":"https://github.com/alejandroEsc","followers_url":"https://api.github.com/users/alejandroEsc/followers","following_url":"https://api.github.com/users/alejandroEsc/following{/other_user}","gists_url":"https://api.github.com/users/alejandroEsc/gists{/gist_id}","starred_url":"https://api.github.com/users/alejandroEsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alejandroEsc/subscriptions","organizations_url":"https://api.github.com/users/alejandroEsc/orgs","repos_url":"https://api.github.com/users/alejandroEsc/repos","events_url":"https://api.github.com/users/alejandroEsc/events{/privacy}","received_events_url":"https://api.github.com/users/alejandroEsc/received_events","type":"User","site_admin":false},"assignees":[{"login":"alejandroEsc","id":20777618,"avatar_url":"https://avatars0.githubusercontent.com/u/20777618?v=4","gravatar_id":"","url":"https://api.github.com/users/alejandroEsc","html_url":"https://github.com/alejandroEsc","followers_url":"https://api.github.com/users/alejandroEsc/followers","following_url":"https://api.github.com/users/alejandroEsc/following{/other_user}","gists_url":"https://api.github.com/users/alejandroEsc/gists{/gist_id}","starred_url":"https://api.github.com/users/alejandroEsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alejandroEsc/subscriptions","organizations_url":"https://api.github.com/users/alejandroEsc/orgs","repos_url":"https://api.github.com/users/alejandroEsc/repos","events_url":"https://api.github.com/users/alejandroEsc/events{/privacy}","received_events_url":"https://api.github.com/users/alejandroEsc/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"joejulian","id":952828,"avatar_url":"https://avatars2.githubusercontent.com/u/952828?v=4","gravatar_id":"","url":"https://api.github.com/users/joejulian","html_url":"https://github.com/joejulian","followers_url":"https://api.github.com/users/joejulian/followers","following_url":"https://api.github.com/users/joejulian/following{/other_user}","gists_url":"https://api.github.com/users/joejulian/gists{/gist_id}","starred_url":"https://api.github.com/users/joejulian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joejulian/subscriptions","organizations_url":"https://api.github.com/users/joejulian/orgs","repos_url":"https://api.github.com/users/joejulian/repos","events_url":"https://api.github.com/users/joejulian/events{/privacy}","received_events_url":"https://api.github.com/users/joejulian/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/samsung-cnct/k2/pulls/759/commits","review_comments_url":"https://api.github.com/repos/samsung-cnct/k2/pulls/759/comments","review_comment_url":"https://api.github.com/repos/samsung-cnct/k2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/samsung-cnct/k2/issues/759/comments","statuses_url":"https://api.github.com/repos/samsung-cnct/k2/statuses/4d477fb943ae92d6dd3c4a026efbacd043e0c8e0","head":{"label":"alejandroEsc:ae/issues/735","ref":"ae/issues/735","sha":"4d477fb943ae92d6dd3c4a026efbacd043e0c8e0","user":{"login":"alejandroEsc","id":20777618,"avatar_url":"https://avatars0.githubusercontent.com/u/20777618?v=4","gravatar_id":"","url":"https://api.github.com/users/alejandroEsc","html_url":"https://github.com/alejandroEsc","followers_url":"https://api.github.com/users/alejandroEsc/followers","following_url":"https://api.github.com/users/alejandroEsc/following{/other_user}","gists_url":"https://api.github.com/users/alejandroEsc/gists{/gist_id}","starred_url":"https://api.github.com/users/alejandroEsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alejandroEsc/subscriptions","organizations_url":"https://api.github.com/users/alejandroEsc/orgs","repos_url":"https://api.github.com/users/alejandroEsc/repos","events_url":"https://api.github.com/users/alejandroEsc/events{/privacy}","received_events_url":"https://api.github.com/users/alejandroEsc/received_events","type":"User","site_admin":false},"repo":{"id":69294024,"name":"k2","full_name":"alejandroEsc/k2","owner":{"login":"alejandroEsc","id":20777618,"avatar_url":"https://avatars0.githubusercontent.com/u/20777618?v=4","gravatar_id":"","url":"https://api.github.com/users/alejandroEsc","html_url":"https://github.com/alejandroEsc","followers_url":"https://api.github.com/users/alejandroEsc/followers","following_url":"https://api.github.com/users/alejandroEsc/following{/other_user}","gists_url":"https://api.github.com/users/alejandroEsc/gists{/gist_id}","starred_url":"https://api.github.com/users/alejandroEsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alejandroEsc/subscriptions","organizations_url":"https://api.github.com/users/alejandroEsc/orgs","repos_url":"https://api.github.com/users/alejandroEsc/repos","events_url":"https://api.github.com/users/alejandroEsc/events{/privacy}","received_events_url":"https://api.github.com/users/alejandroEsc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alejandroEsc/k2","description":"K2 (Kraken 2)","fork":true,"url":"https://api.github.com/repos/alejandroEsc/k2","forks_url":"https://api.github.com/repos/alejandroEsc/k2/forks","keys_url":"https://api.github.com/repos/alejandroEsc/k2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alejandroEsc/k2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alejandroEsc/k2/teams","hooks_url":"https://api.github.com/repos/alejandroEsc/k2/hooks","issue_events_url":"https://api.github.com/repos/alejandroEsc/k2/issues/events{/number}","events_url":"https://api.github.com/repos/alejandroEsc/k2/events","assignees_url":"https://api.github.com/repos/alejandroEsc/k2/assignees{/user}","branches_url":"https://api.github.com/repos/alejandroEsc/k2/branches{/branch}","tags_url":"https://api.github.com/repos/alejandroEsc/k2/tags","blobs_url":"https://api.github.com/repos/alejandroEsc/k2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alejandroEsc/k2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alejandroEsc/k2/git/refs{/sha}","trees_url":"https://api.github.com/repos/alejandroEsc/k2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alejandroEsc/k2/statuses/{sha}","languages_url":"https://api.github.com/repos/alejandroEsc/k2/languages","stargazers_url":"https://api.github.com/repos/alejandroEsc/k2/stargazers","contributors_url":"https://api.github.com/repos/alejandroEsc/k2/contributors","subscribers_url":"https://api.github.com/repos/alejandroEsc/k2/subscribers","subscription_url":"https://api.github.com/repos/alejandroEsc/k2/subscription","commits_url":"https://api.github.com/repos/alejandroEsc/k2/commits{/sha}","git_commits_url":"https://api.github.com/repos/alejandroEsc/k2/git/commits{/sha}","comments_url":"https://api.github.com/repos/alejandroEsc/k2/comments{/number}","issue_comment_url":"https://api.github.com/repos/alejandroEsc/k2/issues/comments{/number}","contents_url":"https://api.github.com/repos/alejandroEsc/k2/contents/{+path}","compare_url":"https://api.github.com/repos/alejandroEsc/k2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alejandroEsc/k2/merges","archive_url":"https://api.github.com/repos/alejandroEsc/k2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alejandroEsc/k2/downloads","issues_url":"https://api.github.com/repos/alejandroEsc/k2/issues{/number}","pulls_url":"https://api.github.com/repos/alejandroEsc/k2/pulls{/number}","milestones_url":"https://api.github.com/repos/alejandroEsc/k2/milestones{/number}","notifications_url":"https://api.github.com/repos/alejandroEsc/k2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alejandroEsc/k2/labels{/name}","releases_url":"https://api.github.com/repos/alejandroEsc/k2/releases{/id}","deployments_url":"https://api.github.com/repos/alejandroEsc/k2/deployments","created_at":"2016-09-26T21:22:58Z","updated_at":"2017-01-10T04:29:45Z","pushed_at":"2017-08-16T05:34:47Z","git_url":"git://github.com/alejandroEsc/k2.git","ssh_url":"git@github.com:alejandroEsc/k2.git","clone_url":"https://github.com/alejandroEsc/k2.git","svn_url":"https://github.com/alejandroEsc/k2","homepage":null,"size":2814,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"samsung-cnct:master","ref":"master","sha":"a8dda6e291c78e3bf088028a51efcb2a6fc69e42","user":{"login":"samsung-cnct","id":11511065,"avatar_url":"https://avatars3.githubusercontent.com/u/11511065?v=4","gravatar_id":"","url":"https://api.github.com/users/samsung-cnct","html_url":"https://github.com/samsung-cnct","followers_url":"https://api.github.com/users/samsung-cnct/followers","following_url":"https://api.github.com/users/samsung-cnct/following{/other_user}","gists_url":"https://api.github.com/users/samsung-cnct/gists{/gist_id}","starred_url":"https://api.github.com/users/samsung-cnct/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samsung-cnct/subscriptions","organizations_url":"https://api.github.com/users/samsung-cnct/orgs","repos_url":"https://api.github.com/users/samsung-cnct/repos","events_url":"https://api.github.com/users/samsung-cnct/events{/privacy}","received_events_url":"https://api.github.com/users/samsung-cnct/received_events","type":"Organization","site_admin":false},"repo":{"id":68646823,"name":"k2","full_name":"samsung-cnct/k2","owner":{"login":"samsung-cnct","id":11511065,"avatar_url":"https://avatars3.githubusercontent.com/u/11511065?v=4","gravatar_id":"","url":"https://api.github.com/users/samsung-cnct","html_url":"https://github.com/samsung-cnct","followers_url":"https://api.github.com/users/samsung-cnct/followers","following_url":"https://api.github.com/users/samsung-cnct/following{/other_user}","gists_url":"https://api.github.com/users/samsung-cnct/gists{/gist_id}","starred_url":"https://api.github.com/users/samsung-cnct/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samsung-cnct/subscriptions","organizations_url":"https://api.github.com/users/samsung-cnct/orgs","repos_url":"https://api.github.com/users/samsung-cnct/repos","events_url":"https://api.github.com/users/samsung-cnct/events{/privacy}","received_events_url":"https://api.github.com/users/samsung-cnct/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/samsung-cnct/k2","description":"K2 (Kraken 2)","fork":false,"url":"https://api.github.com/repos/samsung-cnct/k2","forks_url":"https://api.github.com/repos/samsung-cnct/k2/forks","keys_url":"https://api.github.com/repos/samsung-cnct/k2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/samsung-cnct/k2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/samsung-cnct/k2/teams","hooks_url":"https://api.github.com/repos/samsung-cnct/k2/hooks","issue_events_url":"https://api.github.com/repos/samsung-cnct/k2/issues/events{/number}","events_url":"https://api.github.com/repos/samsung-cnct/k2/events","assignees_url":"https://api.github.com/repos/samsung-cnct/k2/assignees{/user}","branches_url":"https://api.github.com/repos/samsung-cnct/k2/branches{/branch}","tags_url":"https://api.github.com/repos/samsung-cnct/k2/tags","blobs_url":"https://api.github.com/repos/samsung-cnct/k2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/samsung-cnct/k2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/samsung-cnct/k2/git/refs{/sha}","trees_url":"https://api.github.com/repos/samsung-cnct/k2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/samsung-cnct/k2/statuses/{sha}","languages_url":"https://api.github.com/repos/samsung-cnct/k2/languages","stargazers_url":"https://api.github.com/repos/samsung-cnct/k2/stargazers","contributors_url":"https://api.github.com/repos/samsung-cnct/k2/contributors","subscribers_url":"https://api.github.com/repos/samsung-cnct/k2/subscribers","subscription_url":"https://api.github.com/repos/samsung-cnct/k2/subscription","commits_url":"https://api.github.com/repos/samsung-cnct/k2/commits{/sha}","git_commits_url":"https://api.github.com/repos/samsung-cnct/k2/git/commits{/sha}","comments_url":"https://api.github.com/repos/samsung-cnct/k2/comments{/number}","issue_comment_url":"https://api.github.com/repos/samsung-cnct/k2/issues/comments{/number}","contents_url":"https://api.github.com/repos/samsung-cnct/k2/contents/{+path}","compare_url":"https://api.github.com/repos/samsung-cnct/k2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/samsung-cnct/k2/merges","archive_url":"https://api.github.com/repos/samsung-cnct/k2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/samsung-cnct/k2/downloads","issues_url":"https://api.github.com/repos/samsung-cnct/k2/issues{/number}","pulls_url":"https://api.github.com/repos/samsung-cnct/k2/pulls{/number}","milestones_url":"https://api.github.com/repos/samsung-cnct/k2/milestones{/number}","notifications_url":"https://api.github.com/repos/samsung-cnct/k2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/samsung-cnct/k2/labels{/name}","releases_url":"https://api.github.com/repos/samsung-cnct/k2/releases{/id}","deployments_url":"https://api.github.com/repos/samsung-cnct/k2/deployments","created_at":"2016-09-19T21:07:47Z","updated_at":"2017-08-16T15:50:27Z","pushed_at":"2017-08-17T06:15:59Z","git_url":"git://github.com/samsung-cnct/k2.git","ssh_url":"git@github.com:samsung-cnct/k2.git","clone_url":"https://github.com/samsung-cnct/k2.git","svn_url":"https://github.com/samsung-cnct/k2","homepage":null,"size":2806,"stargazers_count":74,"watchers_count":74,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":31,"mirror_url":null,"open_issues_count":145,"forks":31,"open_issues":145,"watchers":74,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/samsung-cnct/k2/pulls/759"},"html":{"href":"https://github.com/samsung-cnct/k2/pull/759"},"issue":{"href":"https://api.github.com/repos/samsung-cnct/k2/issues/759"},"comments":{"href":"https://api.github.com/repos/samsung-cnct/k2/issues/759/comments"},"review_comments":{"href":"https://api.github.com/repos/samsung-cnct/k2/pulls/759/comments"},"review_comment":{"href":"https://api.github.com/repos/samsung-cnct/k2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/samsung-cnct/k2/pulls/759/commits"},"statuses":{"href":"https://api.github.com/repos/samsung-cnct/k2/statuses/4d477fb943ae92d6dd3c4a026efbacd043e0c8e0"}}}}
{"actor":{"display_login":"alejandroEsc"}}