{"action":"closed","number":3940,"pull_request":{"url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/3940","id":123234927,"html_url":"https://github.com/MinecraftForge/MinecraftForge/pull/3940","diff_url":"https://github.com/MinecraftForge/MinecraftForge/pull/3940.diff","patch_url":"https://github.com/MinecraftForge/MinecraftForge/pull/3940.patch","issue_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/3940","number":3940,"state":"closed","locked":false,"title":"Save/restore dormant chunk entity data from NBT","user":{"login":"bs2609","id":1447117,"avatar_url":"https://avatars1.githubusercontent.com/u/1447117?v=4","gravatar_id":"","url":"https://api.github.com/users/bs2609","html_url":"https://github.com/bs2609","followers_url":"https://api.github.com/users/bs2609/followers","following_url":"https://api.github.com/users/bs2609/following{/other_user}","gists_url":"https://api.github.com/users/bs2609/gists{/gist_id}","starred_url":"https://api.github.com/users/bs2609/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bs2609/subscriptions","organizations_url":"https://api.github.com/users/bs2609/orgs","repos_url":"https://api.github.com/users/bs2609/repos","events_url":"https://api.github.com/users/bs2609/events{/privacy}","received_events_url":"https://api.github.com/users/bs2609/received_events","type":"User","site_admin":false},"body":"This is another possible fix for #3897, and an alternative to #3914.\r\n\r\nThe dormant chunk handling is modified to save entities as NBT data. On load, the entities are recreated using the same process as in vanilla.\r\n\r\nIn order to do this, the call to `putDormantChunk()` is made earlier (before the chunk is saved to NBT), and a call to the new `storeChunkNBT()` method is patched in to `AnvilChunkLoader`. This allows us to use the vanilla entity serialisation that already occurs.\r\nAfter the entity data has been associated with the chunk in the cache, the original entities are cleared from the chunk's data structures,\r\n\r\nWhen a dormant chunk is fetched, it is repopulated with entities from the associated NBT data before being returned.\r\n\r\nThe advantage of this approach is that it is much closer to vanilla. The tradeoff is the added performance cost.","created_at":"2017-05-31T09:50:26Z","updated_at":"2017-10-15T01:34:21Z","closed_at":"2017-10-15T01:34:21Z","merged_at":"2017-10-15T01:34:21Z","merge_commit_sha":"7d60ce788bc1e953c7bf3aeb71f1d8c577d00d6e","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/3940/commits","review_comments_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/3940/comments","review_comment_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/3940/comments","statuses_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/statuses/1bcd6078dd497991a3b06024646fa64fc962f632","head":{"label":"bs2609:dormant-chunk-entity-fix","ref":"dormant-chunk-entity-fix","sha":"1bcd6078dd497991a3b06024646fa64fc962f632","user":{"login":"bs2609","id":1447117,"avatar_url":"https://avatars1.githubusercontent.com/u/1447117?v=4","gravatar_id":"","url":"https://api.github.com/users/bs2609","html_url":"https://github.com/bs2609","followers_url":"https://api.github.com/users/bs2609/followers","following_url":"https://api.github.com/users/bs2609/following{/other_user}","gists_url":"https://api.github.com/users/bs2609/gists{/gist_id}","starred_url":"https://api.github.com/users/bs2609/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bs2609/subscriptions","organizations_url":"https://api.github.com/users/bs2609/orgs","repos_url":"https://api.github.com/users/bs2609/repos","events_url":"https://api.github.com/users/bs2609/events{/privacy}","received_events_url":"https://api.github.com/users/bs2609/received_events","type":"User","site_admin":false},"repo":{"id":69063094,"name":"MinecraftForge","full_name":"bs2609/MinecraftForge","owner":{"login":"bs2609","id":1447117,"avatar_url":"https://avatars1.githubusercontent.com/u/1447117?v=4","gravatar_id":"","url":"https://api.github.com/users/bs2609","html_url":"https://github.com/bs2609","followers_url":"https://api.github.com/users/bs2609/followers","following_url":"https://api.github.com/users/bs2609/following{/other_user}","gists_url":"https://api.github.com/users/bs2609/gists{/gist_id}","starred_url":"https://api.github.com/users/bs2609/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bs2609/subscriptions","organizations_url":"https://api.github.com/users/bs2609/orgs","repos_url":"https://api.github.com/users/bs2609/repos","events_url":"https://api.github.com/users/bs2609/events{/privacy}","received_events_url":"https://api.github.com/users/bs2609/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bs2609/MinecraftForge","description":"Modifications to the Minecraft base files to assist in compatibility between mods.","fork":true,"url":"https://api.github.com/repos/bs2609/MinecraftForge","forks_url":"https://api.github.com/repos/bs2609/MinecraftForge/forks","keys_url":"https://api.github.com/repos/bs2609/MinecraftForge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bs2609/MinecraftForge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bs2609/MinecraftForge/teams","hooks_url":"https://api.github.com/repos/bs2609/MinecraftForge/hooks","issue_events_url":"https://api.github.com/repos/bs2609/MinecraftForge/issues/events{/number}","events_url":"https://api.github.com/repos/bs2609/MinecraftForge/events","assignees_url":"https://api.github.com/repos/bs2609/MinecraftForge/assignees{/user}","branches_url":"https://api.github.com/repos/bs2609/MinecraftForge/branches{/branch}","tags_url":"https://api.github.com/repos/bs2609/MinecraftForge/tags","blobs_url":"https://api.github.com/repos/bs2609/MinecraftForge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bs2609/MinecraftForge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bs2609/MinecraftForge/git/refs{/sha}","trees_url":"https://api.github.com/repos/bs2609/MinecraftForge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bs2609/MinecraftForge/statuses/{sha}","languages_url":"https://api.github.com/repos/bs2609/MinecraftForge/languages","stargazers_url":"https://api.github.com/repos/bs2609/MinecraftForge/stargazers","contributors_url":"https://api.github.com/repos/bs2609/MinecraftForge/contributors","subscribers_url":"https://api.github.com/repos/bs2609/MinecraftForge/subscribers","subscription_url":"https://api.github.com/repos/bs2609/MinecraftForge/subscription","commits_url":"https://api.github.com/repos/bs2609/MinecraftForge/commits{/sha}","git_commits_url":"https://api.github.com/repos/bs2609/MinecraftForge/git/commits{/sha}","comments_url":"https://api.github.com/repos/bs2609/MinecraftForge/comments{/number}","issue_comment_url":"https://api.github.com/repos/bs2609/MinecraftForge/issues/comments{/number}","contents_url":"https://api.github.com/repos/bs2609/MinecraftForge/contents/{+path}","compare_url":"https://api.github.com/repos/bs2609/MinecraftForge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bs2609/MinecraftForge/merges","archive_url":"https://api.github.com/repos/bs2609/MinecraftForge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bs2609/MinecraftForge/downloads","issues_url":"https://api.github.com/repos/bs2609/MinecraftForge/issues{/number}","pulls_url":"https://api.github.com/repos/bs2609/MinecraftForge/pulls{/number}","milestones_url":"https://api.github.com/repos/bs2609/MinecraftForge/milestones{/number}","notifications_url":"https://api.github.com/repos/bs2609/MinecraftForge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bs2609/MinecraftForge/labels{/name}","releases_url":"https://api.github.com/repos/bs2609/MinecraftForge/releases{/id}","deployments_url":"https://api.github.com/repos/bs2609/MinecraftForge/deployments","created_at":"2016-09-23T21:50:44Z","updated_at":"2016-09-23T21:50:49Z","pushed_at":"2017-10-11T23:47:57Z","git_url":"git://github.com/bs2609/MinecraftForge.git","ssh_url":"git@github.com:bs2609/MinecraftForge.git","clone_url":"https://github.com/bs2609/MinecraftForge.git","svn_url":"https://github.com/bs2609/MinecraftForge","homepage":"","size":91040,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"1.11.x"}},"base":{"label":"MinecraftForge:1.11.x","ref":"1.11.x","sha":"4b0dbdb19b720c31736d096f126aab527843a20f","user":{"login":"MinecraftForge","id":1390178,"avatar_url":"https://avatars2.githubusercontent.com/u/1390178?v=4","gravatar_id":"","url":"https://api.github.com/users/MinecraftForge","html_url":"https://github.com/MinecraftForge","followers_url":"https://api.github.com/users/MinecraftForge/followers","following_url":"https://api.github.com/users/MinecraftForge/following{/other_user}","gists_url":"https://api.github.com/users/MinecraftForge/gists{/gist_id}","starred_url":"https://api.github.com/users/MinecraftForge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MinecraftForge/subscriptions","organizations_url":"https://api.github.com/users/MinecraftForge/orgs","repos_url":"https://api.github.com/users/MinecraftForge/repos","events_url":"https://api.github.com/users/MinecraftForge/events{/privacy}","received_events_url":"https://api.github.com/users/MinecraftForge/received_events","type":"Organization","site_admin":false},"repo":{"id":3301400,"name":"MinecraftForge","full_name":"MinecraftForge/MinecraftForge","owner":{"login":"MinecraftForge","id":1390178,"avatar_url":"https://avatars2.githubusercontent.com/u/1390178?v=4","gravatar_id":"","url":"https://api.github.com/users/MinecraftForge","html_url":"https://github.com/MinecraftForge","followers_url":"https://api.github.com/users/MinecraftForge/followers","following_url":"https://api.github.com/users/MinecraftForge/following{/other_user}","gists_url":"https://api.github.com/users/MinecraftForge/gists{/gist_id}","starred_url":"https://api.github.com/users/MinecraftForge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MinecraftForge/subscriptions","organizations_url":"https://api.github.com/users/MinecraftForge/orgs","repos_url":"https://api.github.com/users/MinecraftForge/repos","events_url":"https://api.github.com/users/MinecraftForge/events{/privacy}","received_events_url":"https://api.github.com/users/MinecraftForge/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MinecraftForge/MinecraftForge","description":"Modifications to the Minecraft base files to assist in compatibility between mods.","fork":false,"url":"https://api.github.com/repos/MinecraftForge/MinecraftForge","forks_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/forks","keys_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/teams","hooks_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/hooks","issue_events_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/events{/number}","events_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/events","assignees_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/assignees{/user}","branches_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/branches{/branch}","tags_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/tags","blobs_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/git/refs{/sha}","trees_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/statuses/{sha}","languages_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/languages","stargazers_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/stargazers","contributors_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/contributors","subscribers_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/subscribers","subscription_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/subscription","commits_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/commits{/sha}","git_commits_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/git/commits{/sha}","comments_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/comments{/number}","issue_comment_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/comments{/number}","contents_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/contents/{+path}","compare_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/merges","archive_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/downloads","issues_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues{/number}","pulls_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls{/number}","milestones_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/milestones{/number}","notifications_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/labels{/name}","releases_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/releases{/id}","deployments_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/deployments","created_at":"2012-01-30T01:35:01Z","updated_at":"2017-10-14T22:23:07Z","pushed_at":"2017-10-15T01:34:21Z","git_url":"git://github.com/MinecraftForge/MinecraftForge.git","ssh_url":"git@github.com:MinecraftForge/MinecraftForge.git","clone_url":"https://github.com/MinecraftForge/MinecraftForge.git","svn_url":"https://github.com/MinecraftForge/MinecraftForge","homepage":"","size":91031,"stargazers_count":2024,"watchers_count":2024,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":979,"mirror_url":null,"open_issues_count":346,"forks":979,"open_issues":346,"watchers":2024,"default_branch":"1.12.x"}},"_links":{"self":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/3940"},"html":{"href":"https://github.com/MinecraftForge/MinecraftForge/pull/3940"},"issue":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/3940"},"comments":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/3940/comments"},"review_comments":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/3940/comments"},"review_comment":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/3940/commits"},"statuses":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/statuses/1bcd6078dd497991a3b06024646fa64fc962f632"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"mezz","id":916092,"avatar_url":"https://avatars1.githubusercontent.com/u/916092?v=4","gravatar_id":"","url":"https://api.github.com/users/mezz","html_url":"https://github.com/mezz","followers_url":"https://api.github.com/users/mezz/followers","following_url":"https://api.github.com/users/mezz/following{/other_user}","gists_url":"https://api.github.com/users/mezz/gists{/gist_id}","starred_url":"https://api.github.com/users/mezz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mezz/subscriptions","organizations_url":"https://api.github.com/users/mezz/orgs","repos_url":"https://api.github.com/users/mezz/repos","events_url":"https://api.github.com/users/mezz/events{/privacy}","received_events_url":"https://api.github.com/users/mezz/received_events","type":"User","site_admin":false},"comments":8,"review_comments":0,"maintainer_can_modify":false,"commits":5,"additions":77,"deletions":26,"changed_files":4}}
{"actor":{"display_login":"mezz"}}