{"action":"created","comment":{"url":"https://api.github.com/repos/civicrm/civihr/pulls/comments/120380038","pull_request_review_id":42331239,"id":120380038,"diff_hunk":"@@ -2654,6 +2693,11 @@ public function testLeaveRequestIsValidShouldNotReturnErrorWhenValidationsPass()\n       'end_date'   => CRM_Utils_Date::processDate('2016-12-31'),\n     ]);\n \n+    HRJobContractFabricator::fabricate(\n+      ['contact_id' => $contactID],\n+      ['period_start_date' => '2016-01-01']\n+    );\n+","path":"uk.co.compucorp.civicrm.hrleaveandabsences/tests/phpunit/api/v3/LeaveRequestTest.php","position":399,"original_position":399,"commit_id":"59d558e9e04eb9caa8c58a7b069166991448b4b9","original_commit_id":"59d558e9e04eb9caa8c58a7b069166991448b4b9","user":{"login":"mickadoo","id":6374064,"avatar_url":"https://avatars2.githubusercontent.com/u/6374064?v=3","gravatar_id":"","url":"https://api.github.com/users/mickadoo","html_url":"https://github.com/mickadoo","followers_url":"https://api.github.com/users/mickadoo/followers","following_url":"https://api.github.com/users/mickadoo/following{/other_user}","gists_url":"https://api.github.com/users/mickadoo/gists{/gist_id}","starred_url":"https://api.github.com/users/mickadoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mickadoo/subscriptions","organizations_url":"https://api.github.com/users/mickadoo/orgs","repos_url":"https://api.github.com/users/mickadoo/repos","events_url":"https://api.github.com/users/mickadoo/events{/privacy}","received_events_url":"https://api.github.com/users/mickadoo/received_events","type":"User","site_admin":false},"body":"Wow, this class is very long. I think we should impose some sort of limit in the future sometime. It could be split into separate test classes.","created_at":"2017-06-06T14:40:15Z","updated_at":"2017-06-06T14:40:29Z","html_url":"https://github.com/civicrm/civihr/pull/1921#discussion_r120380038","pull_request_url":"https://api.github.com/repos/civicrm/civihr/pulls/1921","_links":{"self":{"href":"https://api.github.com/repos/civicrm/civihr/pulls/comments/120380038"},"html":{"href":"https://github.com/civicrm/civihr/pull/1921#discussion_r120380038"},"pull_request":{"href":"https://api.github.com/repos/civicrm/civihr/pulls/1921"}}},"pull_request":{"url":"https://api.github.com/repos/civicrm/civihr/pulls/1921","id":124180479,"html_url":"https://github.com/civicrm/civihr/pull/1921","diff_url":"https://github.com/civicrm/civihr/pull/1921.diff","patch_url":"https://github.com/civicrm/civihr/pull/1921.patch","issue_url":"https://api.github.com/repos/civicrm/civihr/issues/1921","number":1921,"state":"open","locked":false,"title":"PCHR-2275: Modify Leave And Absence Alerts To Conform to What is in WireFrame","user":{"login":"tunbola","id":6951813,"avatar_url":"https://avatars2.githubusercontent.com/u/6951813?v=3","gravatar_id":"","url":"https://api.github.com/users/tunbola","html_url":"https://github.com/tunbola","followers_url":"https://api.github.com/users/tunbola/followers","following_url":"https://api.github.com/users/tunbola/following{/other_user}","gists_url":"https://api.github.com/users/tunbola/gists{/gist_id}","starred_url":"https://api.github.com/users/tunbola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tunbola/subscriptions","organizations_url":"https://api.github.com/users/tunbola/orgs","repos_url":"https://api.github.com/users/tunbola/repos","events_url":"https://api.github.com/users/tunbola/events{/privacy}","received_events_url":"https://api.github.com/users/tunbola/received_events","type":"User","site_admin":false},"body":"## Overview\r\nWhen a  Leave request is to be created/updated and It fails validation, the error message is displayed as an alert in the Leave Request Modal. This PR modifies the error message sent from the back end for these validations to conform to that described in the L&A Wireframe document. \r\n\r\n## Before\r\nThe L&A leave request validation alerts does not conform to that described in the L&A Wireframe document.\r\n\r\n## After\r\nThe L&A leave request validation alerts conforms to that described in the L&A Wireframe document.\r\n\r\n## Technical Details\r\nInstead of the error code being sent to the Frontend, the Back end now sends the Error message, also the error message is sent after passing it through the translate function.\r\n\r\n## Comments\r\nThere is no validation for one of the alerts described in the ticket:  _If the user requests the leave with end date >= contract end date please display the alert \"This leave request is after your contract end date. Please modify dates of this request.\"_ \r\nThe previous existing validation on contract was modified to accommodate for this new scenario.\r\n\r\n---\r\n\r\n- [X] Tests Pass\r\n","created_at":"2017-06-06T12:39:13Z","updated_at":"2017-06-06T14:40:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"97134c04a4796f9c50bf0a3ecbad7d64c05d9cb0","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/civicrm/civihr/pulls/1921/commits","review_comments_url":"https://api.github.com/repos/civicrm/civihr/pulls/1921/comments","review_comment_url":"https://api.github.com/repos/civicrm/civihr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/civicrm/civihr/issues/1921/comments","statuses_url":"https://api.github.com/repos/civicrm/civihr/statuses/59d558e9e04eb9caa8c58a7b069166991448b4b9","head":{"label":"civicrm:PCHR-2275-leave-and-absence-alerts","ref":"PCHR-2275-leave-and-absence-alerts","sha":"59d558e9e04eb9caa8c58a7b069166991448b4b9","user":{"login":"civicrm","id":136373,"avatar_url":"https://avatars1.githubusercontent.com/u/136373?v=3","gravatar_id":"","url":"https://api.github.com/users/civicrm","html_url":"https://github.com/civicrm","followers_url":"https://api.github.com/users/civicrm/followers","following_url":"https://api.github.com/users/civicrm/following{/other_user}","gists_url":"https://api.github.com/users/civicrm/gists{/gist_id}","starred_url":"https://api.github.com/users/civicrm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/civicrm/subscriptions","organizations_url":"https://api.github.com/users/civicrm/orgs","repos_url":"https://api.github.com/users/civicrm/repos","events_url":"https://api.github.com/users/civicrm/events{/privacy}","received_events_url":"https://api.github.com/users/civicrm/received_events","type":"Organization","site_admin":false},"repo":{"id":10086903,"name":"civihr","full_name":"civicrm/civihr","owner":{"login":"civicrm","id":136373,"avatar_url":"https://avatars1.githubusercontent.com/u/136373?v=3","gravatar_id":"","url":"https://api.github.com/users/civicrm","html_url":"https://github.com/civicrm","followers_url":"https://api.github.com/users/civicrm/followers","following_url":"https://api.github.com/users/civicrm/following{/other_user}","gists_url":"https://api.github.com/users/civicrm/gists{/gist_id}","starred_url":"https://api.github.com/users/civicrm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/civicrm/subscriptions","organizations_url":"https://api.github.com/users/civicrm/orgs","repos_url":"https://api.github.com/users/civicrm/repos","events_url":"https://api.github.com/users/civicrm/events{/privacy}","received_events_url":"https://api.github.com/users/civicrm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/civicrm/civihr","description":"CiviHR","fork":false,"url":"https://api.github.com/repos/civicrm/civihr","forks_url":"https://api.github.com/repos/civicrm/civihr/forks","keys_url":"https://api.github.com/repos/civicrm/civihr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/civicrm/civihr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/civicrm/civihr/teams","hooks_url":"https://api.github.com/repos/civicrm/civihr/hooks","issue_events_url":"https://api.github.com/repos/civicrm/civihr/issues/events{/number}","events_url":"https://api.github.com/repos/civicrm/civihr/events","assignees_url":"https://api.github.com/repos/civicrm/civihr/assignees{/user}","branches_url":"https://api.github.com/repos/civicrm/civihr/branches{/branch}","tags_url":"https://api.github.com/repos/civicrm/civihr/tags","blobs_url":"https://api.github.com/repos/civicrm/civihr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/civicrm/civihr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/civicrm/civihr/git/refs{/sha}","trees_url":"https://api.github.com/repos/civicrm/civihr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/civicrm/civihr/statuses/{sha}","languages_url":"https://api.github.com/repos/civicrm/civihr/languages","stargazers_url":"https://api.github.com/repos/civicrm/civihr/stargazers","contributors_url":"https://api.github.com/repos/civicrm/civihr/contributors","subscribers_url":"https://api.github.com/repos/civicrm/civihr/subscribers","subscription_url":"https://api.github.com/repos/civicrm/civihr/subscription","commits_url":"https://api.github.com/repos/civicrm/civihr/commits{/sha}","git_commits_url":"https://api.github.com/repos/civicrm/civihr/git/commits{/sha}","comments_url":"https://api.github.com/repos/civicrm/civihr/comments{/number}","issue_comment_url":"https://api.github.com/repos/civicrm/civihr/issues/comments{/number}","contents_url":"https://api.github.com/repos/civicrm/civihr/contents/{+path}","compare_url":"https://api.github.com/repos/civicrm/civihr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/civicrm/civihr/merges","archive_url":"https://api.github.com/repos/civicrm/civihr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/civicrm/civihr/downloads","issues_url":"https://api.github.com/repos/civicrm/civihr/issues{/number}","pulls_url":"https://api.github.com/repos/civicrm/civihr/pulls{/number}","milestones_url":"https://api.github.com/repos/civicrm/civihr/milestones{/number}","notifications_url":"https://api.github.com/repos/civicrm/civihr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/civicrm/civihr/labels{/name}","releases_url":"https://api.github.com/repos/civicrm/civihr/releases{/id}","deployments_url":"https://api.github.com/repos/civicrm/civihr/deployments","created_at":"2013-05-15T20:06:06Z","updated_at":"2017-06-02T23:57:41Z","pushed_at":"2017-06-06T14:14:22Z","git_url":"git://github.com/civicrm/civihr.git","ssh_url":"git@github.com:civicrm/civihr.git","clone_url":"https://github.com/civicrm/civihr.git","svn_url":"https://github.com/civicrm/civihr","homepage":null,"size":47302,"stargazers_count":11,"watchers_count":11,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":32,"mirror_url":null,"open_issues_count":18,"forks":32,"open_issues":18,"watchers":11,"default_branch":"staging"}},"base":{"label":"civicrm:la-milestone-3","ref":"la-milestone-3","sha":"f32a11c7f9aade10f50035745237d74e1c674dbb","user":{"login":"civicrm","id":136373,"avatar_url":"https://avatars1.githubusercontent.com/u/136373?v=3","gravatar_id":"","url":"https://api.github.com/users/civicrm","html_url":"https://github.com/civicrm","followers_url":"https://api.github.com/users/civicrm/followers","following_url":"https://api.github.com/users/civicrm/following{/other_user}","gists_url":"https://api.github.com/users/civicrm/gists{/gist_id}","starred_url":"https://api.github.com/users/civicrm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/civicrm/subscriptions","organizations_url":"https://api.github.com/users/civicrm/orgs","repos_url":"https://api.github.com/users/civicrm/repos","events_url":"https://api.github.com/users/civicrm/events{/privacy}","received_events_url":"https://api.github.com/users/civicrm/received_events","type":"Organization","site_admin":false},"repo":{"id":10086903,"name":"civihr","full_name":"civicrm/civihr","owner":{"login":"civicrm","id":136373,"avatar_url":"https://avatars1.githubusercontent.com/u/136373?v=3","gravatar_id":"","url":"https://api.github.com/users/civicrm","html_url":"https://github.com/civicrm","followers_url":"https://api.github.com/users/civicrm/followers","following_url":"https://api.github.com/users/civicrm/following{/other_user}","gists_url":"https://api.github.com/users/civicrm/gists{/gist_id}","starred_url":"https://api.github.com/users/civicrm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/civicrm/subscriptions","organizations_url":"https://api.github.com/users/civicrm/orgs","repos_url":"https://api.github.com/users/civicrm/repos","events_url":"https://api.github.com/users/civicrm/events{/privacy}","received_events_url":"https://api.github.com/users/civicrm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/civicrm/civihr","description":"CiviHR","fork":false,"url":"https://api.github.com/repos/civicrm/civihr","forks_url":"https://api.github.com/repos/civicrm/civihr/forks","keys_url":"https://api.github.com/repos/civicrm/civihr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/civicrm/civihr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/civicrm/civihr/teams","hooks_url":"https://api.github.com/repos/civicrm/civihr/hooks","issue_events_url":"https://api.github.com/repos/civicrm/civihr/issues/events{/number}","events_url":"https://api.github.com/repos/civicrm/civihr/events","assignees_url":"https://api.github.com/repos/civicrm/civihr/assignees{/user}","branches_url":"https://api.github.com/repos/civicrm/civihr/branches{/branch}","tags_url":"https://api.github.com/repos/civicrm/civihr/tags","blobs_url":"https://api.github.com/repos/civicrm/civihr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/civicrm/civihr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/civicrm/civihr/git/refs{/sha}","trees_url":"https://api.github.com/repos/civicrm/civihr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/civicrm/civihr/statuses/{sha}","languages_url":"https://api.github.com/repos/civicrm/civihr/languages","stargazers_url":"https://api.github.com/repos/civicrm/civihr/stargazers","contributors_url":"https://api.github.com/repos/civicrm/civihr/contributors","subscribers_url":"https://api.github.com/repos/civicrm/civihr/subscribers","subscription_url":"https://api.github.com/repos/civicrm/civihr/subscription","commits_url":"https://api.github.com/repos/civicrm/civihr/commits{/sha}","git_commits_url":"https://api.github.com/repos/civicrm/civihr/git/commits{/sha}","comments_url":"https://api.github.com/repos/civicrm/civihr/comments{/number}","issue_comment_url":"https://api.github.com/repos/civicrm/civihr/issues/comments{/number}","contents_url":"https://api.github.com/repos/civicrm/civihr/contents/{+path}","compare_url":"https://api.github.com/repos/civicrm/civihr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/civicrm/civihr/merges","archive_url":"https://api.github.com/repos/civicrm/civihr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/civicrm/civihr/downloads","issues_url":"https://api.github.com/repos/civicrm/civihr/issues{/number}","pulls_url":"https://api.github.com/repos/civicrm/civihr/pulls{/number}","milestones_url":"https://api.github.com/repos/civicrm/civihr/milestones{/number}","notifications_url":"https://api.github.com/repos/civicrm/civihr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/civicrm/civihr/labels{/name}","releases_url":"https://api.github.com/repos/civicrm/civihr/releases{/id}","deployments_url":"https://api.github.com/repos/civicrm/civihr/deployments","created_at":"2013-05-15T20:06:06Z","updated_at":"2017-06-02T23:57:41Z","pushed_at":"2017-06-06T14:14:22Z","git_url":"git://github.com/civicrm/civihr.git","ssh_url":"git@github.com:civicrm/civihr.git","clone_url":"https://github.com/civicrm/civihr.git","svn_url":"https://github.com/civicrm/civihr","homepage":null,"size":47302,"stargazers_count":11,"watchers_count":11,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":32,"mirror_url":null,"open_issues_count":18,"forks":32,"open_issues":18,"watchers":11,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/civicrm/civihr/pulls/1921"},"html":{"href":"https://github.com/civicrm/civihr/pull/1921"},"issue":{"href":"https://api.github.com/repos/civicrm/civihr/issues/1921"},"comments":{"href":"https://api.github.com/repos/civicrm/civihr/issues/1921/comments"},"review_comments":{"href":"https://api.github.com/repos/civicrm/civihr/pulls/1921/comments"},"review_comment":{"href":"https://api.github.com/repos/civicrm/civihr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/civicrm/civihr/pulls/1921/commits"},"statuses":{"href":"https://api.github.com/repos/civicrm/civihr/statuses/59d558e9e04eb9caa8c58a7b069166991448b4b9"}}}}
{"actor":{"display_login":"mickadoo"}}