{"action":"created","issue":{"url":"https://api.github.com/repos/uber/cherami-server/issues/32","repository_url":"https://api.github.com/repos/uber/cherami-server","labels_url":"https://api.github.com/repos/uber/cherami-server/issues/32/labels{/name}","comments_url":"https://api.github.com/repos/uber/cherami-server/issues/32/comments","events_url":"https://api.github.com/repos/uber/cherami-server/issues/32/events","html_url":"https://github.com/uber/cherami-server/pull/32","id":202591663,"number":32,"title":"Output leak fixes","user":{"login":"aravindvs","id":13004672,"avatar_url":"https://avatars.githubusercontent.com/u/13004672?v=3","gravatar_id":"","url":"https://api.github.com/users/aravindvs","html_url":"https://github.com/aravindvs","followers_url":"https://api.github.com/users/aravindvs/followers","following_url":"https://api.github.com/users/aravindvs/following{/other_user}","gists_url":"https://api.github.com/users/aravindvs/gists{/gist_id}","starred_url":"https://api.github.com/users/aravindvs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aravindvs/subscriptions","organizations_url":"https://api.github.com/users/aravindvs/orgs","repos_url":"https://api.github.com/users/aravindvs/repos","events_url":"https://api.github.com/users/aravindvs/events{/privacy}","received_events_url":"https://api.github.com/users/aravindvs/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-01-23T17:01:27Z","updated_at":"2017-01-23T22:52:18Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/uber/cherami-server/pulls/32","html_url":"https://github.com/uber/cherami-server/pull/32","diff_url":"https://github.com/uber/cherami-server/pull/32.diff","patch_url":"https://github.com/uber/cherami-server/pull/32.patch"},"body":"This is the corresponding equivalent of the input leak fixes. Stress tests over the weekend looks good. \r\n\r\nThis makes sure:\r\n(1) we cleanup all connections/extents properly by making sure we wait appropriately before breaking the manageRoutine\r\n(2) make sure all the buffered channels are closed\r\n(3) make sure the message cache entries are cleaned up during shutdown so that we don't keep any existing references.\r\n\r\nThe only remaining leak is this known leak with maps in go which will be fixed in 1.8:\r\nhttps://github.com/golang/go/issues/16070"},"comment":{"url":"https://api.github.com/repos/uber/cherami-server/issues/comments/274643785","html_url":"https://github.com/uber/cherami-server/pull/32#issuecomment-274643785","issue_url":"https://api.github.com/repos/uber/cherami-server/issues/32","id":274643785,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars.githubusercontent.com/u/2354108?v=3","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2017-01-23T22:52:18Z","updated_at":"2017-01-23T22:52:18Z","body":"\n[![Coverage Status](https://coveralls.io/builds/9807472/badge)](https://coveralls.io/builds/9807472)\n\nCoverage increased (+0.4%) to 54.779% when pulling **1d4881aa4304269a5a2527f842c12456a219390a on output_leak_fixes** into **f0355ed6e83964e5bd65f4816407e45b27b02d83 on master**.\n"}}
{"actor":{"display_login":"coveralls"}}