{"action":"created","issue":{"url":"https://api.github.com/repos/Automattic/wp-calypso/issues/17539","repository_url":"https://api.github.com/repos/Automattic/wp-calypso","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/17539/labels{/name}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/17539/comments","events_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/17539/events","html_url":"https://github.com/Automattic/wp-calypso/pull/17539","id":252970404,"number":17539,"title":"Update Social Login UI","user":{"login":"Tug","id":230230,"avatar_url":"https://avatars0.githubusercontent.com/u/230230?v=4","gravatar_id":"","url":"https://api.github.com/users/Tug","html_url":"https://github.com/Tug","followers_url":"https://api.github.com/users/Tug/followers","following_url":"https://api.github.com/users/Tug/following{/other_user}","gists_url":"https://api.github.com/users/Tug/gists{/gist_id}","starred_url":"https://api.github.com/users/Tug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tug/subscriptions","organizations_url":"https://api.github.com/users/Tug/orgs","repos_url":"https://api.github.com/users/Tug/repos","events_url":"https://api.github.com/users/Tug/events{/privacy}","received_events_url":"https://api.github.com/users/Tug/received_events","type":"User","site_admin":false},"labels":[{"id":285010028,"url":"https://api.github.com/repos/Automattic/wp-calypso/labels/Me","name":"Me","color":"006b75","default":false},{"id":542883719,"url":"https://api.github.com/repos/Automattic/wp-calypso/labels/[Size]%20XL","name":"[Size] XL","color":"390036","default":false},{"id":285010018,"url":"https://api.github.com/repos/Automattic/wp-calypso/labels/[Status]%20Needs%20Review","name":"[Status] Needs Review","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":{"login":"Tug","id":230230,"avatar_url":"https://avatars0.githubusercontent.com/u/230230?v=4","gravatar_id":"","url":"https://api.github.com/users/Tug","html_url":"https://github.com/Tug","followers_url":"https://api.github.com/users/Tug/followers","following_url":"https://api.github.com/users/Tug/following{/other_user}","gists_url":"https://api.github.com/users/Tug/gists{/gist_id}","starred_url":"https://api.github.com/users/Tug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tug/subscriptions","organizations_url":"https://api.github.com/users/Tug/orgs","repos_url":"https://api.github.com/users/Tug/repos","events_url":"https://api.github.com/users/Tug/events{/privacy}","received_events_url":"https://api.github.com/users/Tug/received_events","type":"User","site_admin":false},"assignees":[{"login":"Tug","id":230230,"avatar_url":"https://avatars0.githubusercontent.com/u/230230?v=4","gravatar_id":"","url":"https://api.github.com/users/Tug","html_url":"https://github.com/Tug","followers_url":"https://api.github.com/users/Tug/followers","following_url":"https://api.github.com/users/Tug/following{/other_user}","gists_url":"https://api.github.com/users/Tug/gists{/gist_id}","starred_url":"https://api.github.com/users/Tug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tug/subscriptions","organizations_url":"https://api.github.com/users/Tug/orgs","repos_url":"https://api.github.com/users/Tug/repos","events_url":"https://api.github.com/users/Tug/events{/privacy}","received_events_url":"https://api.github.com/users/Tug/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2017-08-25T17:36:04Z","updated_at":"2017-08-28T20:44:42Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/17539","html_url":"https://github.com/Automattic/wp-calypso/pull/17539","diff_url":"https://github.com/Automattic/wp-calypso/pull/17539.diff","patch_url":"https://github.com/Automattic/wp-calypso/pull/17539.patch"},"body":"Requires server patch D7035.\r\n\r\nThis PR updates the Social Login screen to show the Google social login option and make the Connect/Disconnect button work.\r\n\r\nIt will need another PR to:\r\n- handle errors from the server\r\n- refactor the social login option into a new component, make it generic (works with any kind of social network we might want to add) \r\n- take into account the user fetching time before setting the button to enabled again\r\n\r\n### Testing Instructions\r\n- Boot up this branch\r\n- Navigate to http://calypso.localhost:3000/me/security/social-login\r\n- Try the Google connect/disconnect button, assert that you can log in when you are connected and that you are redirected to the social-connect flow when disconnected.\r\n\r\n### Reviews\r\n- [ ] Code\r\n- [ ] Product\r\n"},"comment":{"url":"https://api.github.com/repos/Automattic/wp-calypso/issues/comments/325475883","html_url":"https://github.com/Automattic/wp-calypso/pull/17539#issuecomment-325475883","issue_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/17539","id":325475883,"user":{"login":"jsnmoon","id":4044428,"avatar_url":"https://avatars2.githubusercontent.com/u/4044428?v=4","gravatar_id":"","url":"https://api.github.com/users/jsnmoon","html_url":"https://github.com/jsnmoon","followers_url":"https://api.github.com/users/jsnmoon/followers","following_url":"https://api.github.com/users/jsnmoon/following{/other_user}","gists_url":"https://api.github.com/users/jsnmoon/gists{/gist_id}","starred_url":"https://api.github.com/users/jsnmoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsnmoon/subscriptions","organizations_url":"https://api.github.com/users/jsnmoon/orgs","repos_url":"https://api.github.com/users/jsnmoon/repos","events_url":"https://api.github.com/users/jsnmoon/events{/privacy}","received_events_url":"https://api.github.com/users/jsnmoon/received_events","type":"User","site_admin":false},"created_at":"2017-08-28T20:44:42Z","updated_at":"2017-08-28T20:44:42Z","body":"> @jsnmoon Could you try again with D7035?\r\n\r\nHa! I knew there was something missing ;)\r\n\r\nConnections and disconnections seem to work as intended with the patch. Some comments on the product:\r\n\r\n- As noted in #16690, we must have a flow for how a user might log in after disconnecting their sole social login. Currently, we don't advise the user about what they should do after disconnecting. Maybe we should trigger something in the backend and show a notice on the UI? (e.g. Email them a magic login link, email them a password reset, etc.)\r\n\r\n- As you already noted in the original post, we should consider disabling the `Connect`/`Disconnect` buttons while the following are in progress:\r\n    - Initial page load\r\n    - Fetching user's social login information\r\n    - Connecting/disconnecting social logins\r\n\r\n- This is unrelated to this PR, but something to think about: How would a user go about linking both a Google and Facebook social logins to a single account? Should we offer a way to merge newly created accounts somehow?\r\n\r\nGreat work, by the way! 👏 👏 👏 "}}
{"actor":{"display_login":"jsnmoon"}}