{"action":"created","comment":{"url":"https://api.github.com/repos/cbm755/octsympy/pulls/comments/129176883","pull_request_review_id":51922331,"id":129176883,"diff_hunk":"@@ -277,7 +277,6 @@\n   end\n \n   asm = {};\n-  check = true;","path":"inst/@sym/sym.m","position":17,"original_position":17,"commit_id":"8b11cc58e4c7ff174ca201409795451ecd8bf43f","original_commit_id":"4b0201686f50c9cfb3460a5790a460f67880636a","user":{"login":"cbm755","id":818622,"avatar_url":"https://avatars0.githubusercontent.com/u/818622?v=4","gravatar_id":"","url":"https://api.github.com/users/cbm755","html_url":"https://github.com/cbm755","followers_url":"https://api.github.com/users/cbm755/followers","following_url":"https://api.github.com/users/cbm755/following{/other_user}","gists_url":"https://api.github.com/users/cbm755/gists{/gist_id}","starred_url":"https://api.github.com/users/cbm755/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbm755/subscriptions","organizations_url":"https://api.github.com/users/cbm755/orgs","repos_url":"https://api.github.com/users/cbm755/repos","events_url":"https://api.github.com/users/cbm755/events{/privacy}","received_events_url":"https://api.github.com/users/cbm755/received_events","type":"User","site_admin":false},"body":"Ok, I think I see, thank you.\r\n\r\nThere are paths in #590 that end early with `s = meh...; return`, so I don't see this PR's code as being much worse.  I will merge for now, fight with classdef when we get there ;-)","created_at":"2017-07-24T23:04:02Z","updated_at":"2017-07-24T23:04:02Z","html_url":"https://github.com/cbm755/octsympy/pull/804#discussion_r129176883","pull_request_url":"https://api.github.com/repos/cbm755/octsympy/pulls/804","_links":{"self":{"href":"https://api.github.com/repos/cbm755/octsympy/pulls/comments/129176883"},"html":{"href":"https://github.com/cbm755/octsympy/pull/804#discussion_r129176883"},"pull_request":{"href":"https://api.github.com/repos/cbm755/octsympy/pulls/804"}}},"pull_request":{"url":"https://api.github.com/repos/cbm755/octsympy/pulls/804","id":121389205,"html_url":"https://github.com/cbm755/octsympy/pull/804","diff_url":"https://github.com/cbm755/octsympy/pull/804.diff","patch_url":"https://github.com/cbm755/octsympy/pull/804.patch","issue_url":"https://api.github.com/repos/cbm755/octsympy/issues/804","number":804,"state":"open","locked":false,"title":"sym() and vpa() refactor","user":{"login":"cbm755","id":818622,"avatar_url":"https://avatars0.githubusercontent.com/u/818622?v=4","gravatar_id":"","url":"https://api.github.com/users/cbm755","html_url":"https://github.com/cbm755","followers_url":"https://api.github.com/users/cbm755/followers","following_url":"https://api.github.com/users/cbm755/following{/other_user}","gists_url":"https://api.github.com/users/cbm755/gists{/gist_id}","starred_url":"https://api.github.com/users/cbm755/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbm755/subscriptions","organizations_url":"https://api.github.com/users/cbm755/orgs","repos_url":"https://api.github.com/users/cbm755/repos","events_url":"https://api.github.com/users/cbm755/events{/privacy}","received_events_url":"https://api.github.com/users/cbm755/received_events","type":"User","site_admin":false},"body":"I feel like I could tweak this forever, so here's some progress anyway.  I've taken apart from of @latot's work to centralize `const_to_python_str` (which dealt with doubles *and* strings).  That logic is a little more spread out now, but IMHO its clearly to understand `@sym/sym` which is the code that matters.\r\n\r\nThere were also sublte differences between what should happen with e.g., `pi` in `sym(pi, 'f')`, `sym(pi, 'r')` and `vpa(pi)`.\r\n\r\nThis also fixes a bug I introduces where `sym(inf, 'f')` was zero.`\r\n\r\nFinally, it fixes #604 by allowing `sym('i')` to make a variable named `i` rather than imaginary unit, which is for SMT compatibility.","created_at":"2017-05-18T22:14:13Z","updated_at":"2017-07-24T23:04:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"14e3a0c76f191a3d36707787e1a317ebab171201","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/cbm755/octsympy/pulls/804/commits","review_comments_url":"https://api.github.com/repos/cbm755/octsympy/pulls/804/comments","review_comment_url":"https://api.github.com/repos/cbm755/octsympy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cbm755/octsympy/issues/804/comments","statuses_url":"https://api.github.com/repos/cbm755/octsympy/statuses/8b11cc58e4c7ff174ca201409795451ecd8bf43f","head":{"label":"cbm755:sym_vpa_refactor","ref":"sym_vpa_refactor","sha":"8b11cc58e4c7ff174ca201409795451ecd8bf43f","user":{"login":"cbm755","id":818622,"avatar_url":"https://avatars0.githubusercontent.com/u/818622?v=4","gravatar_id":"","url":"https://api.github.com/users/cbm755","html_url":"https://github.com/cbm755","followers_url":"https://api.github.com/users/cbm755/followers","following_url":"https://api.github.com/users/cbm755/following{/other_user}","gists_url":"https://api.github.com/users/cbm755/gists{/gist_id}","starred_url":"https://api.github.com/users/cbm755/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbm755/subscriptions","organizations_url":"https://api.github.com/users/cbm755/orgs","repos_url":"https://api.github.com/users/cbm755/repos","events_url":"https://api.github.com/users/cbm755/events{/privacy}","received_events_url":"https://api.github.com/users/cbm755/received_events","type":"User","site_admin":false},"repo":{"id":18641463,"name":"octsympy","full_name":"cbm755/octsympy","owner":{"login":"cbm755","id":818622,"avatar_url":"https://avatars0.githubusercontent.com/u/818622?v=4","gravatar_id":"","url":"https://api.github.com/users/cbm755","html_url":"https://github.com/cbm755","followers_url":"https://api.github.com/users/cbm755/followers","following_url":"https://api.github.com/users/cbm755/following{/other_user}","gists_url":"https://api.github.com/users/cbm755/gists{/gist_id}","starred_url":"https://api.github.com/users/cbm755/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbm755/subscriptions","organizations_url":"https://api.github.com/users/cbm755/orgs","repos_url":"https://api.github.com/users/cbm755/repos","events_url":"https://api.github.com/users/cbm755/events{/privacy}","received_events_url":"https://api.github.com/users/cbm755/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cbm755/octsympy","description":"A Symbolic Package for Octave using SymPy","fork":false,"url":"https://api.github.com/repos/cbm755/octsympy","forks_url":"https://api.github.com/repos/cbm755/octsympy/forks","keys_url":"https://api.github.com/repos/cbm755/octsympy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cbm755/octsympy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cbm755/octsympy/teams","hooks_url":"https://api.github.com/repos/cbm755/octsympy/hooks","issue_events_url":"https://api.github.com/repos/cbm755/octsympy/issues/events{/number}","events_url":"https://api.github.com/repos/cbm755/octsympy/events","assignees_url":"https://api.github.com/repos/cbm755/octsympy/assignees{/user}","branches_url":"https://api.github.com/repos/cbm755/octsympy/branches{/branch}","tags_url":"https://api.github.com/repos/cbm755/octsympy/tags","blobs_url":"https://api.github.com/repos/cbm755/octsympy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cbm755/octsympy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cbm755/octsympy/git/refs{/sha}","trees_url":"https://api.github.com/repos/cbm755/octsympy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cbm755/octsympy/statuses/{sha}","languages_url":"https://api.github.com/repos/cbm755/octsympy/languages","stargazers_url":"https://api.github.com/repos/cbm755/octsympy/stargazers","contributors_url":"https://api.github.com/repos/cbm755/octsympy/contributors","subscribers_url":"https://api.github.com/repos/cbm755/octsympy/subscribers","subscription_url":"https://api.github.com/repos/cbm755/octsympy/subscription","commits_url":"https://api.github.com/repos/cbm755/octsympy/commits{/sha}","git_commits_url":"https://api.github.com/repos/cbm755/octsympy/git/commits{/sha}","comments_url":"https://api.github.com/repos/cbm755/octsympy/comments{/number}","issue_comment_url":"https://api.github.com/repos/cbm755/octsympy/issues/comments{/number}","contents_url":"https://api.github.com/repos/cbm755/octsympy/contents/{+path}","compare_url":"https://api.github.com/repos/cbm755/octsympy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cbm755/octsympy/merges","archive_url":"https://api.github.com/repos/cbm755/octsympy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cbm755/octsympy/downloads","issues_url":"https://api.github.com/repos/cbm755/octsympy/issues{/number}","pulls_url":"https://api.github.com/repos/cbm755/octsympy/pulls{/number}","milestones_url":"https://api.github.com/repos/cbm755/octsympy/milestones{/number}","notifications_url":"https://api.github.com/repos/cbm755/octsympy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cbm755/octsympy/labels{/name}","releases_url":"https://api.github.com/repos/cbm755/octsympy/releases{/id}","deployments_url":"https://api.github.com/repos/cbm755/octsympy/deployments","created_at":"2014-04-10T15:25:39Z","updated_at":"2017-07-17T11:58:48Z","pushed_at":"2017-07-24T22:42:42Z","git_url":"git://github.com/cbm755/octsympy.git","ssh_url":"git@github.com:cbm755/octsympy.git","clone_url":"https://github.com/cbm755/octsympy.git","svn_url":"https://github.com/cbm755/octsympy","homepage":"","size":3454,"stargazers_count":36,"watchers_count":36,"language":"Matlab","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":130,"forks":16,"open_issues":130,"watchers":36,"default_branch":"master"}},"base":{"label":"cbm755:master","ref":"master","sha":"a279c2b0c0d7329b813c44b11db15ea1cc26aa2d","user":{"login":"cbm755","id":818622,"avatar_url":"https://avatars0.githubusercontent.com/u/818622?v=4","gravatar_id":"","url":"https://api.github.com/users/cbm755","html_url":"https://github.com/cbm755","followers_url":"https://api.github.com/users/cbm755/followers","following_url":"https://api.github.com/users/cbm755/following{/other_user}","gists_url":"https://api.github.com/users/cbm755/gists{/gist_id}","starred_url":"https://api.github.com/users/cbm755/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbm755/subscriptions","organizations_url":"https://api.github.com/users/cbm755/orgs","repos_url":"https://api.github.com/users/cbm755/repos","events_url":"https://api.github.com/users/cbm755/events{/privacy}","received_events_url":"https://api.github.com/users/cbm755/received_events","type":"User","site_admin":false},"repo":{"id":18641463,"name":"octsympy","full_name":"cbm755/octsympy","owner":{"login":"cbm755","id":818622,"avatar_url":"https://avatars0.githubusercontent.com/u/818622?v=4","gravatar_id":"","url":"https://api.github.com/users/cbm755","html_url":"https://github.com/cbm755","followers_url":"https://api.github.com/users/cbm755/followers","following_url":"https://api.github.com/users/cbm755/following{/other_user}","gists_url":"https://api.github.com/users/cbm755/gists{/gist_id}","starred_url":"https://api.github.com/users/cbm755/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbm755/subscriptions","organizations_url":"https://api.github.com/users/cbm755/orgs","repos_url":"https://api.github.com/users/cbm755/repos","events_url":"https://api.github.com/users/cbm755/events{/privacy}","received_events_url":"https://api.github.com/users/cbm755/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cbm755/octsympy","description":"A Symbolic Package for Octave using SymPy","fork":false,"url":"https://api.github.com/repos/cbm755/octsympy","forks_url":"https://api.github.com/repos/cbm755/octsympy/forks","keys_url":"https://api.github.com/repos/cbm755/octsympy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cbm755/octsympy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cbm755/octsympy/teams","hooks_url":"https://api.github.com/repos/cbm755/octsympy/hooks","issue_events_url":"https://api.github.com/repos/cbm755/octsympy/issues/events{/number}","events_url":"https://api.github.com/repos/cbm755/octsympy/events","assignees_url":"https://api.github.com/repos/cbm755/octsympy/assignees{/user}","branches_url":"https://api.github.com/repos/cbm755/octsympy/branches{/branch}","tags_url":"https://api.github.com/repos/cbm755/octsympy/tags","blobs_url":"https://api.github.com/repos/cbm755/octsympy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cbm755/octsympy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cbm755/octsympy/git/refs{/sha}","trees_url":"https://api.github.com/repos/cbm755/octsympy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cbm755/octsympy/statuses/{sha}","languages_url":"https://api.github.com/repos/cbm755/octsympy/languages","stargazers_url":"https://api.github.com/repos/cbm755/octsympy/stargazers","contributors_url":"https://api.github.com/repos/cbm755/octsympy/contributors","subscribers_url":"https://api.github.com/repos/cbm755/octsympy/subscribers","subscription_url":"https://api.github.com/repos/cbm755/octsympy/subscription","commits_url":"https://api.github.com/repos/cbm755/octsympy/commits{/sha}","git_commits_url":"https://api.github.com/repos/cbm755/octsympy/git/commits{/sha}","comments_url":"https://api.github.com/repos/cbm755/octsympy/comments{/number}","issue_comment_url":"https://api.github.com/repos/cbm755/octsympy/issues/comments{/number}","contents_url":"https://api.github.com/repos/cbm755/octsympy/contents/{+path}","compare_url":"https://api.github.com/repos/cbm755/octsympy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cbm755/octsympy/merges","archive_url":"https://api.github.com/repos/cbm755/octsympy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cbm755/octsympy/downloads","issues_url":"https://api.github.com/repos/cbm755/octsympy/issues{/number}","pulls_url":"https://api.github.com/repos/cbm755/octsympy/pulls{/number}","milestones_url":"https://api.github.com/repos/cbm755/octsympy/milestones{/number}","notifications_url":"https://api.github.com/repos/cbm755/octsympy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cbm755/octsympy/labels{/name}","releases_url":"https://api.github.com/repos/cbm755/octsympy/releases{/id}","deployments_url":"https://api.github.com/repos/cbm755/octsympy/deployments","created_at":"2014-04-10T15:25:39Z","updated_at":"2017-07-17T11:58:48Z","pushed_at":"2017-07-24T22:42:42Z","git_url":"git://github.com/cbm755/octsympy.git","ssh_url":"git@github.com:cbm755/octsympy.git","clone_url":"https://github.com/cbm755/octsympy.git","svn_url":"https://github.com/cbm755/octsympy","homepage":"","size":3454,"stargazers_count":36,"watchers_count":36,"language":"Matlab","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":130,"forks":16,"open_issues":130,"watchers":36,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cbm755/octsympy/pulls/804"},"html":{"href":"https://github.com/cbm755/octsympy/pull/804"},"issue":{"href":"https://api.github.com/repos/cbm755/octsympy/issues/804"},"comments":{"href":"https://api.github.com/repos/cbm755/octsympy/issues/804/comments"},"review_comments":{"href":"https://api.github.com/repos/cbm755/octsympy/pulls/804/comments"},"review_comment":{"href":"https://api.github.com/repos/cbm755/octsympy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cbm755/octsympy/pulls/804/commits"},"statuses":{"href":"https://api.github.com/repos/cbm755/octsympy/statuses/8b11cc58e4c7ff174ca201409795451ecd8bf43f"}}}}
{"actor":{"display_login":"cbm755"}}