{"action":"created","issue":{"url":"https://api.github.com/repos/Azure/acs-engine/issues/918","repository_url":"https://api.github.com/repos/Azure/acs-engine","labels_url":"https://api.github.com/repos/Azure/acs-engine/issues/918/labels{/name}","comments_url":"https://api.github.com/repos/Azure/acs-engine/issues/918/comments","events_url":"https://api.github.com/repos/Azure/acs-engine/issues/918/events","html_url":"https://github.com/Azure/acs-engine/pull/918","id":240963429,"number":918,"title":"Activate k8s rbac","user":{"login":"Globegitter","id":2580254,"avatar_url":"https://avatars0.githubusercontent.com/u/2580254?v=4","gravatar_id":"","url":"https://api.github.com/users/Globegitter","html_url":"https://github.com/Globegitter","followers_url":"https://api.github.com/users/Globegitter/followers","following_url":"https://api.github.com/users/Globegitter/following{/other_user}","gists_url":"https://api.github.com/users/Globegitter/gists{/gist_id}","starred_url":"https://api.github.com/users/Globegitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Globegitter/subscriptions","organizations_url":"https://api.github.com/users/Globegitter/orgs","repos_url":"https://api.github.com/users/Globegitter/repos","events_url":"https://api.github.com/users/Globegitter/events{/privacy}","received_events_url":"https://api.github.com/users/Globegitter/received_events","type":"User","site_admin":false},"labels":[{"id":482553560,"url":"https://api.github.com/repos/Azure/acs-engine/labels/cla-already-signed","name":"cla-already-signed","color":"009800","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":36,"created_at":"2017-07-06T13:51:05Z","updated_at":"2017-07-28T21:18:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Azure/acs-engine/pulls/918","html_url":"https://github.com/Azure/acs-engine/pull/918","diff_url":"https://github.com/Azure/acs-engine/pull/918.diff","patch_url":"https://github.com/Azure/acs-engine/pull/918.patch"},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If you want *faster* PR reviews, read how: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#best-practices-for-faster-reviews\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\nActivates RBAC - this seems to be the way forward with k8s.\r\n\r\n**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #\r\n\r\nPartially fixes #680 as it enables RBAC per default but does not help for upgrading existing clusters.\r\n\r\n**Special notes for your reviewer**:\r\nThis haven't spent too much time to check that this is the most ideal way to set RBAC up, but it gets it working for now in our test cluster and thought I would share that work.\r\n\r\nThis depends on #909 which upgrades heapster to v1.4.0\r\n\r\nI tested this on Azure on northeurope with a few of our services and seems to be all working.\r\n\r\n\r\n##\r\n**Release note**:\r\n<!--  Steps to write your release note:\r\n1. Use the release-note-* labels to set the release note state (if you have access)\r\n2. Enter your extended release note in the below block; leaving it blank means using the PR title as the release note. If no release note is required, just write `NONE`.\r\n-->\r\n```release-note\r\n```\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/azure/acs-engine/918)\r\n<!-- Reviewable:end -->\r\n"},"comment":{"url":"https://api.github.com/repos/Azure/acs-engine/issues/comments/318764223","html_url":"https://github.com/Azure/acs-engine/pull/918#issuecomment-318764223","issue_url":"https://api.github.com/repos/Azure/acs-engine/issues/918","id":318764223,"user":{"login":"lachie83","id":6912984,"avatar_url":"https://avatars2.githubusercontent.com/u/6912984?v=4","gravatar_id":"","url":"https://api.github.com/users/lachie83","html_url":"https://github.com/lachie83","followers_url":"https://api.github.com/users/lachie83/followers","following_url":"https://api.github.com/users/lachie83/following{/other_user}","gists_url":"https://api.github.com/users/lachie83/gists{/gist_id}","starred_url":"https://api.github.com/users/lachie83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lachie83/subscriptions","organizations_url":"https://api.github.com/users/lachie83/orgs","repos_url":"https://api.github.com/users/lachie83/repos","events_url":"https://api.github.com/users/lachie83/events{/privacy}","received_events_url":"https://api.github.com/users/lachie83/received_events","type":"User","site_admin":false},"created_at":"2017-07-28T21:18:09Z","updated_at":"2017-07-28T21:18:09Z","body":"From my branch which should be in-sync with your branch I see -- https://github.com/Azure/acs-engine/compare/master...lachie83:k8s-rbac-updates?expand=1"}}
{"actor":{"display_login":"lachie83"}}