{"action":"created","comment":{"url":"https://api.github.com/repos/AugurProject/augur-core/pulls/comments/146759875","pull_request_review_id":71747208,"id":146759875,"diff_hunk":"@@ -51,11 +56,19 @@ contract ClaimProceeds is CashAutoConverter, ReentrancyGuard, IClaimProceeds {\n             if (_reporterShare > 0) {\n                 require(_denominationToken.transferFrom(_market, _market.getUniverse().getNextReportingWindow(), _reporterShare));\n             }\n+            ","path":"source/contracts/trading/ClaimProceeds.sol","position":32,"original_position":32,"commit_id":"1d60b14cc0066d516182832311ba5a6aac12e38c","original_commit_id":"1d60b14cc0066d516182832311ba5a6aac12e38c","user":{"login":"nuevoalex","id":3839700,"avatar_url":"https://avatars2.githubusercontent.com/u/3839700?v=4","gravatar_id":"","url":"https://api.github.com/users/nuevoalex","html_url":"https://github.com/nuevoalex","followers_url":"https://api.github.com/users/nuevoalex/followers","following_url":"https://api.github.com/users/nuevoalex/following{/other_user}","gists_url":"https://api.github.com/users/nuevoalex/gists{/gist_id}","starred_url":"https://api.github.com/users/nuevoalex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nuevoalex/subscriptions","organizations_url":"https://api.github.com/users/nuevoalex/orgs","repos_url":"https://api.github.com/users/nuevoalex/repos","events_url":"https://api.github.com/users/nuevoalex/events{/privacy}","received_events_url":"https://api.github.com/users/nuevoalex/received_events","type":"User","site_admin":false},"body":"Hm I must not have the right setting in vscode. Will add and correct","created_at":"2017-10-25T05:47:39Z","updated_at":"2017-10-25T05:47:39Z","html_url":"https://github.com/AugurProject/augur-core/pull/404#discussion_r146759875","pull_request_url":"https://api.github.com/repos/AugurProject/augur-core/pulls/404","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/AugurProject/augur-core/pulls/comments/146759875"},"html":{"href":"https://github.com/AugurProject/augur-core/pull/404#discussion_r146759875"},"pull_request":{"href":"https://api.github.com/repos/AugurProject/augur-core/pulls/404"}},"in_reply_to_id":146759813},"pull_request":{"url":"https://api.github.com/repos/AugurProject/augur-core/pulls/404","id":148277152,"html_url":"https://github.com/AugurProject/augur-core/pull/404","diff_url":"https://github.com/AugurProject/augur-core/pull/404.diff","patch_url":"https://github.com/AugurProject/augur-core/pull/404.patch","issue_url":"https://api.github.com/repos/AugurProject/augur-core/issues/404","number":404,"state":"open","locked":false,"title":"Event logging","user":{"login":"nuevoalex","id":3839700,"avatar_url":"https://avatars2.githubusercontent.com/u/3839700?v=4","gravatar_id":"","url":"https://api.github.com/users/nuevoalex","html_url":"https://github.com/nuevoalex","followers_url":"https://api.github.com/users/nuevoalex/followers","following_url":"https://api.github.com/users/nuevoalex/following{/other_user}","gists_url":"https://api.github.com/users/nuevoalex/gists{/gist_id}","starred_url":"https://api.github.com/users/nuevoalex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nuevoalex/subscriptions","organizations_url":"https://api.github.com/users/nuevoalex/orgs","repos_url":"https://api.github.com/users/nuevoalex/repos","events_url":"https://api.github.com/users/nuevoalex/events{/privacy}","received_events_url":"https://api.github.com/users/nuevoalex/received_events","type":"User","site_admin":false},"body":"Adding multiple people to this to make sure the event data we're sending is adequate and correct.\r\n\r\nNOTE: we went back to using a centralized Augur contract to send all logs and are sending the universe in all logs as well. This was after Jack was filled in on the previous implementation and noted that too much currently depends on the centralized Augur contract being the source of events to change that behavior. Filtering the Universe is a simple addition in comparison.","created_at":"2017-10-24T01:25:07Z","updated_at":"2017-10-25T05:47:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b69e36a90fd61629104c0f30fd582e107a0b7edd","assignee":null,"assignees":[],"requested_reviewers":[{"login":"tinybike","id":2637020,"avatar_url":"https://avatars2.githubusercontent.com/u/2637020?v=4","gravatar_id":"","url":"https://api.github.com/users/tinybike","html_url":"https://github.com/tinybike","followers_url":"https://api.github.com/users/tinybike/followers","following_url":"https://api.github.com/users/tinybike/following{/other_user}","gists_url":"https://api.github.com/users/tinybike/gists{/gist_id}","starred_url":"https://api.github.com/users/tinybike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tinybike/subscriptions","organizations_url":"https://api.github.com/users/tinybike/orgs","repos_url":"https://api.github.com/users/tinybike/repos","events_url":"https://api.github.com/users/tinybike/events{/privacy}","received_events_url":"https://api.github.com/users/tinybike/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/AugurProject/augur-core/pulls/404/commits","review_comments_url":"https://api.github.com/repos/AugurProject/augur-core/pulls/404/comments","review_comment_url":"https://api.github.com/repos/AugurProject/augur-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AugurProject/augur-core/issues/404/comments","statuses_url":"https://api.github.com/repos/AugurProject/augur-core/statuses/1d60b14cc0066d516182832311ba5a6aac12e38c","head":{"label":"AugurProject:event_logging","ref":"event_logging","sha":"1d60b14cc0066d516182832311ba5a6aac12e38c","user":{"login":"AugurProject","id":9636524,"avatar_url":"https://avatars3.githubusercontent.com/u/9636524?v=4","gravatar_id":"","url":"https://api.github.com/users/AugurProject","html_url":"https://github.com/AugurProject","followers_url":"https://api.github.com/users/AugurProject/followers","following_url":"https://api.github.com/users/AugurProject/following{/other_user}","gists_url":"https://api.github.com/users/AugurProject/gists{/gist_id}","starred_url":"https://api.github.com/users/AugurProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AugurProject/subscriptions","organizations_url":"https://api.github.com/users/AugurProject/orgs","repos_url":"https://api.github.com/users/AugurProject/repos","events_url":"https://api.github.com/users/AugurProject/events{/privacy}","received_events_url":"https://api.github.com/users/AugurProject/received_events","type":"Organization","site_admin":false},"repo":{"id":27623806,"name":"augur-core","full_name":"AugurProject/augur-core","owner":{"login":"AugurProject","id":9636524,"avatar_url":"https://avatars3.githubusercontent.com/u/9636524?v=4","gravatar_id":"","url":"https://api.github.com/users/AugurProject","html_url":"https://github.com/AugurProject","followers_url":"https://api.github.com/users/AugurProject/followers","following_url":"https://api.github.com/users/AugurProject/following{/other_user}","gists_url":"https://api.github.com/users/AugurProject/gists{/gist_id}","starred_url":"https://api.github.com/users/AugurProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AugurProject/subscriptions","organizations_url":"https://api.github.com/users/AugurProject/orgs","repos_url":"https://api.github.com/users/AugurProject/repos","events_url":"https://api.github.com/users/AugurProject/events{/privacy}","received_events_url":"https://api.github.com/users/AugurProject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AugurProject/augur-core","description":"Augur back-end (Ethereum contracts)","fork":false,"url":"https://api.github.com/repos/AugurProject/augur-core","forks_url":"https://api.github.com/repos/AugurProject/augur-core/forks","keys_url":"https://api.github.com/repos/AugurProject/augur-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AugurProject/augur-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AugurProject/augur-core/teams","hooks_url":"https://api.github.com/repos/AugurProject/augur-core/hooks","issue_events_url":"https://api.github.com/repos/AugurProject/augur-core/issues/events{/number}","events_url":"https://api.github.com/repos/AugurProject/augur-core/events","assignees_url":"https://api.github.com/repos/AugurProject/augur-core/assignees{/user}","branches_url":"https://api.github.com/repos/AugurProject/augur-core/branches{/branch}","tags_url":"https://api.github.com/repos/AugurProject/augur-core/tags","blobs_url":"https://api.github.com/repos/AugurProject/augur-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AugurProject/augur-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AugurProject/augur-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/AugurProject/augur-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AugurProject/augur-core/statuses/{sha}","languages_url":"https://api.github.com/repos/AugurProject/augur-core/languages","stargazers_url":"https://api.github.com/repos/AugurProject/augur-core/stargazers","contributors_url":"https://api.github.com/repos/AugurProject/augur-core/contributors","subscribers_url":"https://api.github.com/repos/AugurProject/augur-core/subscribers","subscription_url":"https://api.github.com/repos/AugurProject/augur-core/subscription","commits_url":"https://api.github.com/repos/AugurProject/augur-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/AugurProject/augur-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/AugurProject/augur-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/AugurProject/augur-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/AugurProject/augur-core/contents/{+path}","compare_url":"https://api.github.com/repos/AugurProject/augur-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AugurProject/augur-core/merges","archive_url":"https://api.github.com/repos/AugurProject/augur-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AugurProject/augur-core/downloads","issues_url":"https://api.github.com/repos/AugurProject/augur-core/issues{/number}","pulls_url":"https://api.github.com/repos/AugurProject/augur-core/pulls{/number}","milestones_url":"https://api.github.com/repos/AugurProject/augur-core/milestones{/number}","notifications_url":"https://api.github.com/repos/AugurProject/augur-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AugurProject/augur-core/labels{/name}","releases_url":"https://api.github.com/repos/AugurProject/augur-core/releases{/id}","deployments_url":"https://api.github.com/repos/AugurProject/augur-core/deployments","created_at":"2014-12-06T05:42:19Z","updated_at":"2017-10-24T01:50:53Z","pushed_at":"2017-10-25T03:06:35Z","git_url":"git://github.com/AugurProject/augur-core.git","ssh_url":"git@github.com:AugurProject/augur-core.git","clone_url":"https://github.com/AugurProject/augur-core.git","svn_url":"https://github.com/AugurProject/augur-core","homepage":"https://www.augur.net","size":12981,"stargazers_count":267,"watchers_count":267,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":58,"mirror_url":null,"archived":false,"open_issues_count":8,"forks":58,"open_issues":8,"watchers":267,"default_branch":"develop"}},"base":{"label":"AugurProject:develop","ref":"develop","sha":"aaaaba7f01a78cf01790464a8a26c0f651cc2bee","user":{"login":"AugurProject","id":9636524,"avatar_url":"https://avatars3.githubusercontent.com/u/9636524?v=4","gravatar_id":"","url":"https://api.github.com/users/AugurProject","html_url":"https://github.com/AugurProject","followers_url":"https://api.github.com/users/AugurProject/followers","following_url":"https://api.github.com/users/AugurProject/following{/other_user}","gists_url":"https://api.github.com/users/AugurProject/gists{/gist_id}","starred_url":"https://api.github.com/users/AugurProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AugurProject/subscriptions","organizations_url":"https://api.github.com/users/AugurProject/orgs","repos_url":"https://api.github.com/users/AugurProject/repos","events_url":"https://api.github.com/users/AugurProject/events{/privacy}","received_events_url":"https://api.github.com/users/AugurProject/received_events","type":"Organization","site_admin":false},"repo":{"id":27623806,"name":"augur-core","full_name":"AugurProject/augur-core","owner":{"login":"AugurProject","id":9636524,"avatar_url":"https://avatars3.githubusercontent.com/u/9636524?v=4","gravatar_id":"","url":"https://api.github.com/users/AugurProject","html_url":"https://github.com/AugurProject","followers_url":"https://api.github.com/users/AugurProject/followers","following_url":"https://api.github.com/users/AugurProject/following{/other_user}","gists_url":"https://api.github.com/users/AugurProject/gists{/gist_id}","starred_url":"https://api.github.com/users/AugurProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AugurProject/subscriptions","organizations_url":"https://api.github.com/users/AugurProject/orgs","repos_url":"https://api.github.com/users/AugurProject/repos","events_url":"https://api.github.com/users/AugurProject/events{/privacy}","received_events_url":"https://api.github.com/users/AugurProject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AugurProject/augur-core","description":"Augur back-end (Ethereum contracts)","fork":false,"url":"https://api.github.com/repos/AugurProject/augur-core","forks_url":"https://api.github.com/repos/AugurProject/augur-core/forks","keys_url":"https://api.github.com/repos/AugurProject/augur-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AugurProject/augur-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AugurProject/augur-core/teams","hooks_url":"https://api.github.com/repos/AugurProject/augur-core/hooks","issue_events_url":"https://api.github.com/repos/AugurProject/augur-core/issues/events{/number}","events_url":"https://api.github.com/repos/AugurProject/augur-core/events","assignees_url":"https://api.github.com/repos/AugurProject/augur-core/assignees{/user}","branches_url":"https://api.github.com/repos/AugurProject/augur-core/branches{/branch}","tags_url":"https://api.github.com/repos/AugurProject/augur-core/tags","blobs_url":"https://api.github.com/repos/AugurProject/augur-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AugurProject/augur-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AugurProject/augur-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/AugurProject/augur-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AugurProject/augur-core/statuses/{sha}","languages_url":"https://api.github.com/repos/AugurProject/augur-core/languages","stargazers_url":"https://api.github.com/repos/AugurProject/augur-core/stargazers","contributors_url":"https://api.github.com/repos/AugurProject/augur-core/contributors","subscribers_url":"https://api.github.com/repos/AugurProject/augur-core/subscribers","subscription_url":"https://api.github.com/repos/AugurProject/augur-core/subscription","commits_url":"https://api.github.com/repos/AugurProject/augur-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/AugurProject/augur-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/AugurProject/augur-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/AugurProject/augur-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/AugurProject/augur-core/contents/{+path}","compare_url":"https://api.github.com/repos/AugurProject/augur-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AugurProject/augur-core/merges","archive_url":"https://api.github.com/repos/AugurProject/augur-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AugurProject/augur-core/downloads","issues_url":"https://api.github.com/repos/AugurProject/augur-core/issues{/number}","pulls_url":"https://api.github.com/repos/AugurProject/augur-core/pulls{/number}","milestones_url":"https://api.github.com/repos/AugurProject/augur-core/milestones{/number}","notifications_url":"https://api.github.com/repos/AugurProject/augur-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AugurProject/augur-core/labels{/name}","releases_url":"https://api.github.com/repos/AugurProject/augur-core/releases{/id}","deployments_url":"https://api.github.com/repos/AugurProject/augur-core/deployments","created_at":"2014-12-06T05:42:19Z","updated_at":"2017-10-24T01:50:53Z","pushed_at":"2017-10-25T03:06:35Z","git_url":"git://github.com/AugurProject/augur-core.git","ssh_url":"git@github.com:AugurProject/augur-core.git","clone_url":"https://github.com/AugurProject/augur-core.git","svn_url":"https://github.com/AugurProject/augur-core","homepage":"https://www.augur.net","size":12981,"stargazers_count":267,"watchers_count":267,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":58,"mirror_url":null,"archived":false,"open_issues_count":8,"forks":58,"open_issues":8,"watchers":267,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/AugurProject/augur-core/pulls/404"},"html":{"href":"https://github.com/AugurProject/augur-core/pull/404"},"issue":{"href":"https://api.github.com/repos/AugurProject/augur-core/issues/404"},"comments":{"href":"https://api.github.com/repos/AugurProject/augur-core/issues/404/comments"},"review_comments":{"href":"https://api.github.com/repos/AugurProject/augur-core/pulls/404/comments"},"review_comment":{"href":"https://api.github.com/repos/AugurProject/augur-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AugurProject/augur-core/pulls/404/commits"},"statuses":{"href":"https://api.github.com/repos/AugurProject/augur-core/statuses/1d60b14cc0066d516182832311ba5a6aac12e38c"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"nuevoalex"}}