{"action":"created","comment":{"url":"https://api.github.com/repos/davodey/pearson-glp-pl/pulls/comments/130254122","pull_request_review_id":53107358,"id":130254122,"diff_hunk":"@@ -0,0 +1,24 @@\n+{{#calendar}}\n+<div class=\"calendar\">\n+\t<div class=\"header\">\n+\t\t<span class=\"pe-title pe-title--small neutral-two\">{{month}} {{year}}</span>\n+\t\t<div class=\"button-group\">\n+\t\t\t{{#buttons}}\n+\t\t\t\t{{> ui-kit-icon}}\n+\t\t\t{{/buttons}}\n+\t\t</div>\n+\t</div>\n+\t<div class=\"days-of-week\">\n+\t\t{{#days}}\n+\t\t\t<span class=\"pe-label pe-label--small neutral-three\">{{day}}</span>","path":"pattern-lab/source/_patterns/00-ui-kit/14-datepicker/00-calendar.mustache","position":13,"original_position":13,"commit_id":"fcd293609ef94bd2a8b6d162b90684385fa49271","original_commit_id":"858e302fda6b1354764928889e9afefc71085f01","user":{"login":"StommePoes","id":136210,"avatar_url":"https://avatars3.githubusercontent.com/u/136210?v=4","gravatar_id":"","url":"https://api.github.com/users/StommePoes","html_url":"https://github.com/StommePoes","followers_url":"https://api.github.com/users/StommePoes/followers","following_url":"https://api.github.com/users/StommePoes/following{/other_user}","gists_url":"https://api.github.com/users/StommePoes/gists{/gist_id}","starred_url":"https://api.github.com/users/StommePoes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StommePoes/subscriptions","organizations_url":"https://api.github.com/users/StommePoes/orgs","repos_url":"https://api.github.com/users/StommePoes/repos","events_url":"https://api.github.com/users/StommePoes/events{/privacy}","received_events_url":"https://api.github.com/users/StommePoes/received_events","type":"User","site_admin":false},"body":"I don't like a pile of buttons for calendars, I tend to like them as grids plus we have [a grid pattern](https://www.w3.org/TR/wai-aria-practices-1.1/#grid) we can use (sucks in NVDA but that is the screen reader, not the code). One of the benefits of a calendar popping up somewhere (whether in a date picker or just an assignments list) is that through the calendar structure you get an idea of what day of the week it is; how close are you to a weekend, how far away from Today is it, etc. This is why it gets added to date pickers where the textual inputting of the date is already pretty accessible, but cognitively the visual version is really helpful to many people.\r\n\r\nThe \"empty\" days at the end of the October example have the aria'd name of October which isn't super helpful-- but I dunno if the actual component version would have switched into November at this point and those are just filler? And the tabs mean I do have a pile of tab stops wherever on the page this gets set.\r\n\r\nI like abbrs on my days (esp when l10n comes along) even though not all screen reader/browser combos will read out the full day names... moving from letter to letter, we need a lot of context to get the day right (this goes away if we go to 3 letter day abbrs).","created_at":"2017-07-30T22:07:53Z","updated_at":"2017-07-30T22:07:53Z","html_url":"https://github.com/davodey/pearson-glp-pl/pull/36#discussion_r130254122","pull_request_url":"https://api.github.com/repos/davodey/pearson-glp-pl/pulls/36","_links":{"self":{"href":"https://api.github.com/repos/davodey/pearson-glp-pl/pulls/comments/130254122"},"html":{"href":"https://github.com/davodey/pearson-glp-pl/pull/36#discussion_r130254122"},"pull_request":{"href":"https://api.github.com/repos/davodey/pearson-glp-pl/pulls/36"}}},"pull_request":{"url":"https://api.github.com/repos/davodey/pearson-glp-pl/pulls/36","id":132801692,"html_url":"https://github.com/davodey/pearson-glp-pl/pull/36","diff_url":"https://github.com/davodey/pearson-glp-pl/pull/36.diff","patch_url":"https://github.com/davodey/pearson-glp-pl/pull/36.patch","issue_url":"https://api.github.com/repos/davodey/pearson-glp-pl/issues/36","number":36,"state":"open","locked":false,"title":"Timepicker & Datepicker","user":{"login":"davodey","id":5407196,"avatar_url":"https://avatars2.githubusercontent.com/u/5407196?v=4","gravatar_id":"","url":"https://api.github.com/users/davodey","html_url":"https://github.com/davodey","followers_url":"https://api.github.com/users/davodey/followers","following_url":"https://api.github.com/users/davodey/following{/other_user}","gists_url":"https://api.github.com/users/davodey/gists{/gist_id}","starred_url":"https://api.github.com/users/davodey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davodey/subscriptions","organizations_url":"https://api.github.com/users/davodey/orgs","repos_url":"https://api.github.com/users/davodey/repos","events_url":"https://api.github.com/users/davodey/events{/privacy}","received_events_url":"https://api.github.com/users/davodey/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-07-27T17:20:41Z","updated_at":"2017-07-30T22:07:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ed38056fed5d0a39b6f8415104ba5c40bf10c4a5","assignee":null,"assignees":[],"requested_reviewers":[{"login":"StommePoes","id":136210,"avatar_url":"https://avatars3.githubusercontent.com/u/136210?v=4","gravatar_id":"","url":"https://api.github.com/users/StommePoes","html_url":"https://github.com/StommePoes","followers_url":"https://api.github.com/users/StommePoes/followers","following_url":"https://api.github.com/users/StommePoes/following{/other_user}","gists_url":"https://api.github.com/users/StommePoes/gists{/gist_id}","starred_url":"https://api.github.com/users/StommePoes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StommePoes/subscriptions","organizations_url":"https://api.github.com/users/StommePoes/orgs","repos_url":"https://api.github.com/users/StommePoes/repos","events_url":"https://api.github.com/users/StommePoes/events{/privacy}","received_events_url":"https://api.github.com/users/StommePoes/received_events","type":"User","site_admin":false},{"login":"jackiejakob","id":30183956,"avatar_url":"https://avatars1.githubusercontent.com/u/30183956?v=4","gravatar_id":"","url":"https://api.github.com/users/jackiejakob","html_url":"https://github.com/jackiejakob","followers_url":"https://api.github.com/users/jackiejakob/followers","following_url":"https://api.github.com/users/jackiejakob/following{/other_user}","gists_url":"https://api.github.com/users/jackiejakob/gists{/gist_id}","starred_url":"https://api.github.com/users/jackiejakob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackiejakob/subscriptions","organizations_url":"https://api.github.com/users/jackiejakob/orgs","repos_url":"https://api.github.com/users/jackiejakob/repos","events_url":"https://api.github.com/users/jackiejakob/events{/privacy}","received_events_url":"https://api.github.com/users/jackiejakob/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/davodey/pearson-glp-pl/pulls/36/commits","review_comments_url":"https://api.github.com/repos/davodey/pearson-glp-pl/pulls/36/comments","review_comment_url":"https://api.github.com/repos/davodey/pearson-glp-pl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/davodey/pearson-glp-pl/issues/36/comments","statuses_url":"https://api.github.com/repos/davodey/pearson-glp-pl/statuses/fcd293609ef94bd2a8b6d162b90684385fa49271","head":{"label":"davodey:timepicker","ref":"timepicker","sha":"fcd293609ef94bd2a8b6d162b90684385fa49271","user":{"login":"davodey","id":5407196,"avatar_url":"https://avatars2.githubusercontent.com/u/5407196?v=4","gravatar_id":"","url":"https://api.github.com/users/davodey","html_url":"https://github.com/davodey","followers_url":"https://api.github.com/users/davodey/followers","following_url":"https://api.github.com/users/davodey/following{/other_user}","gists_url":"https://api.github.com/users/davodey/gists{/gist_id}","starred_url":"https://api.github.com/users/davodey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davodey/subscriptions","organizations_url":"https://api.github.com/users/davodey/orgs","repos_url":"https://api.github.com/users/davodey/repos","events_url":"https://api.github.com/users/davodey/events{/privacy}","received_events_url":"https://api.github.com/users/davodey/received_events","type":"User","site_admin":false},"repo":{"id":97171231,"name":"pearson-glp-pl","full_name":"davodey/pearson-glp-pl","owner":{"login":"davodey","id":5407196,"avatar_url":"https://avatars2.githubusercontent.com/u/5407196?v=4","gravatar_id":"","url":"https://api.github.com/users/davodey","html_url":"https://github.com/davodey","followers_url":"https://api.github.com/users/davodey/followers","following_url":"https://api.github.com/users/davodey/following{/other_user}","gists_url":"https://api.github.com/users/davodey/gists{/gist_id}","starred_url":"https://api.github.com/users/davodey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davodey/subscriptions","organizations_url":"https://api.github.com/users/davodey/orgs","repos_url":"https://api.github.com/users/davodey/repos","events_url":"https://api.github.com/users/davodey/events{/privacy}","received_events_url":"https://api.github.com/users/davodey/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/davodey/pearson-glp-pl","description":"Pearson GLP Patternlab - Front end components for prototyping based off the UI Style kit","fork":false,"url":"https://api.github.com/repos/davodey/pearson-glp-pl","forks_url":"https://api.github.com/repos/davodey/pearson-glp-pl/forks","keys_url":"https://api.github.com/repos/davodey/pearson-glp-pl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davodey/pearson-glp-pl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davodey/pearson-glp-pl/teams","hooks_url":"https://api.github.com/repos/davodey/pearson-glp-pl/hooks","issue_events_url":"https://api.github.com/repos/davodey/pearson-glp-pl/issues/events{/number}","events_url":"https://api.github.com/repos/davodey/pearson-glp-pl/events","assignees_url":"https://api.github.com/repos/davodey/pearson-glp-pl/assignees{/user}","branches_url":"https://api.github.com/repos/davodey/pearson-glp-pl/branches{/branch}","tags_url":"https://api.github.com/repos/davodey/pearson-glp-pl/tags","blobs_url":"https://api.github.com/repos/davodey/pearson-glp-pl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davodey/pearson-glp-pl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davodey/pearson-glp-pl/git/refs{/sha}","trees_url":"https://api.github.com/repos/davodey/pearson-glp-pl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davodey/pearson-glp-pl/statuses/{sha}","languages_url":"https://api.github.com/repos/davodey/pearson-glp-pl/languages","stargazers_url":"https://api.github.com/repos/davodey/pearson-glp-pl/stargazers","contributors_url":"https://api.github.com/repos/davodey/pearson-glp-pl/contributors","subscribers_url":"https://api.github.com/repos/davodey/pearson-glp-pl/subscribers","subscription_url":"https://api.github.com/repos/davodey/pearson-glp-pl/subscription","commits_url":"https://api.github.com/repos/davodey/pearson-glp-pl/commits{/sha}","git_commits_url":"https://api.github.com/repos/davodey/pearson-glp-pl/git/commits{/sha}","comments_url":"https://api.github.com/repos/davodey/pearson-glp-pl/comments{/number}","issue_comment_url":"https://api.github.com/repos/davodey/pearson-glp-pl/issues/comments{/number}","contents_url":"https://api.github.com/repos/davodey/pearson-glp-pl/contents/{+path}","compare_url":"https://api.github.com/repos/davodey/pearson-glp-pl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davodey/pearson-glp-pl/merges","archive_url":"https://api.github.com/repos/davodey/pearson-glp-pl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davodey/pearson-glp-pl/downloads","issues_url":"https://api.github.com/repos/davodey/pearson-glp-pl/issues{/number}","pulls_url":"https://api.github.com/repos/davodey/pearson-glp-pl/pulls{/number}","milestones_url":"https://api.github.com/repos/davodey/pearson-glp-pl/milestones{/number}","notifications_url":"https://api.github.com/repos/davodey/pearson-glp-pl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davodey/pearson-glp-pl/labels{/name}","releases_url":"https://api.github.com/repos/davodey/pearson-glp-pl/releases{/id}","deployments_url":"https://api.github.com/repos/davodey/pearson-glp-pl/deployments","created_at":"2017-07-13T22:57:38Z","updated_at":"2017-07-20T17:11:28Z","pushed_at":"2017-07-28T18:25:21Z","git_url":"git://github.com/davodey/pearson-glp-pl.git","ssh_url":"git@github.com:davodey/pearson-glp-pl.git","clone_url":"https://github.com/davodey/pearson-glp-pl.git","svn_url":"https://github.com/davodey/pearson-glp-pl","homepage":"https://pearson.invisionapp.com/boards/7T37VMSCQS3R4/","size":1821,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":20,"forks":0,"open_issues":20,"watchers":0,"default_branch":"master"}},"base":{"label":"davodey:master","ref":"master","sha":"1fded907be3297d1fa8b332efb30140ac785babb","user":{"login":"davodey","id":5407196,"avatar_url":"https://avatars2.githubusercontent.com/u/5407196?v=4","gravatar_id":"","url":"https://api.github.com/users/davodey","html_url":"https://github.com/davodey","followers_url":"https://api.github.com/users/davodey/followers","following_url":"https://api.github.com/users/davodey/following{/other_user}","gists_url":"https://api.github.com/users/davodey/gists{/gist_id}","starred_url":"https://api.github.com/users/davodey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davodey/subscriptions","organizations_url":"https://api.github.com/users/davodey/orgs","repos_url":"https://api.github.com/users/davodey/repos","events_url":"https://api.github.com/users/davodey/events{/privacy}","received_events_url":"https://api.github.com/users/davodey/received_events","type":"User","site_admin":false},"repo":{"id":97171231,"name":"pearson-glp-pl","full_name":"davodey/pearson-glp-pl","owner":{"login":"davodey","id":5407196,"avatar_url":"https://avatars2.githubusercontent.com/u/5407196?v=4","gravatar_id":"","url":"https://api.github.com/users/davodey","html_url":"https://github.com/davodey","followers_url":"https://api.github.com/users/davodey/followers","following_url":"https://api.github.com/users/davodey/following{/other_user}","gists_url":"https://api.github.com/users/davodey/gists{/gist_id}","starred_url":"https://api.github.com/users/davodey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davodey/subscriptions","organizations_url":"https://api.github.com/users/davodey/orgs","repos_url":"https://api.github.com/users/davodey/repos","events_url":"https://api.github.com/users/davodey/events{/privacy}","received_events_url":"https://api.github.com/users/davodey/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/davodey/pearson-glp-pl","description":"Pearson GLP Patternlab - Front end components for prototyping based off the UI Style kit","fork":false,"url":"https://api.github.com/repos/davodey/pearson-glp-pl","forks_url":"https://api.github.com/repos/davodey/pearson-glp-pl/forks","keys_url":"https://api.github.com/repos/davodey/pearson-glp-pl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davodey/pearson-glp-pl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davodey/pearson-glp-pl/teams","hooks_url":"https://api.github.com/repos/davodey/pearson-glp-pl/hooks","issue_events_url":"https://api.github.com/repos/davodey/pearson-glp-pl/issues/events{/number}","events_url":"https://api.github.com/repos/davodey/pearson-glp-pl/events","assignees_url":"https://api.github.com/repos/davodey/pearson-glp-pl/assignees{/user}","branches_url":"https://api.github.com/repos/davodey/pearson-glp-pl/branches{/branch}","tags_url":"https://api.github.com/repos/davodey/pearson-glp-pl/tags","blobs_url":"https://api.github.com/repos/davodey/pearson-glp-pl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davodey/pearson-glp-pl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davodey/pearson-glp-pl/git/refs{/sha}","trees_url":"https://api.github.com/repos/davodey/pearson-glp-pl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davodey/pearson-glp-pl/statuses/{sha}","languages_url":"https://api.github.com/repos/davodey/pearson-glp-pl/languages","stargazers_url":"https://api.github.com/repos/davodey/pearson-glp-pl/stargazers","contributors_url":"https://api.github.com/repos/davodey/pearson-glp-pl/contributors","subscribers_url":"https://api.github.com/repos/davodey/pearson-glp-pl/subscribers","subscription_url":"https://api.github.com/repos/davodey/pearson-glp-pl/subscription","commits_url":"https://api.github.com/repos/davodey/pearson-glp-pl/commits{/sha}","git_commits_url":"https://api.github.com/repos/davodey/pearson-glp-pl/git/commits{/sha}","comments_url":"https://api.github.com/repos/davodey/pearson-glp-pl/comments{/number}","issue_comment_url":"https://api.github.com/repos/davodey/pearson-glp-pl/issues/comments{/number}","contents_url":"https://api.github.com/repos/davodey/pearson-glp-pl/contents/{+path}","compare_url":"https://api.github.com/repos/davodey/pearson-glp-pl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davodey/pearson-glp-pl/merges","archive_url":"https://api.github.com/repos/davodey/pearson-glp-pl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davodey/pearson-glp-pl/downloads","issues_url":"https://api.github.com/repos/davodey/pearson-glp-pl/issues{/number}","pulls_url":"https://api.github.com/repos/davodey/pearson-glp-pl/pulls{/number}","milestones_url":"https://api.github.com/repos/davodey/pearson-glp-pl/milestones{/number}","notifications_url":"https://api.github.com/repos/davodey/pearson-glp-pl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davodey/pearson-glp-pl/labels{/name}","releases_url":"https://api.github.com/repos/davodey/pearson-glp-pl/releases{/id}","deployments_url":"https://api.github.com/repos/davodey/pearson-glp-pl/deployments","created_at":"2017-07-13T22:57:38Z","updated_at":"2017-07-20T17:11:28Z","pushed_at":"2017-07-28T18:25:21Z","git_url":"git://github.com/davodey/pearson-glp-pl.git","ssh_url":"git@github.com:davodey/pearson-glp-pl.git","clone_url":"https://github.com/davodey/pearson-glp-pl.git","svn_url":"https://github.com/davodey/pearson-glp-pl","homepage":"https://pearson.invisionapp.com/boards/7T37VMSCQS3R4/","size":1821,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":20,"forks":0,"open_issues":20,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/davodey/pearson-glp-pl/pulls/36"},"html":{"href":"https://github.com/davodey/pearson-glp-pl/pull/36"},"issue":{"href":"https://api.github.com/repos/davodey/pearson-glp-pl/issues/36"},"comments":{"href":"https://api.github.com/repos/davodey/pearson-glp-pl/issues/36/comments"},"review_comments":{"href":"https://api.github.com/repos/davodey/pearson-glp-pl/pulls/36/comments"},"review_comment":{"href":"https://api.github.com/repos/davodey/pearson-glp-pl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/davodey/pearson-glp-pl/pulls/36/commits"},"statuses":{"href":"https://api.github.com/repos/davodey/pearson-glp-pl/statuses/fcd293609ef94bd2a8b6d162b90684385fa49271"}}}}
{"actor":{"display_login":"StommePoes"}}