{"action":"closed","number":1,"pull_request":{"url":"https://api.github.com/repos/device42/d42_saltstack_external_pillar/pulls/1","id":155459273,"html_url":"https://github.com/device42/d42_saltstack_external_pillar/pull/1","diff_url":"https://github.com/device42/d42_saltstack_external_pillar/pull/1.diff","patch_url":"https://github.com/device42/d42_saltstack_external_pillar/pull/1.patch","issue_url":"https://api.github.com/repos/device42/d42_saltstack_external_pillar/issues/1","number":1,"state":"closed","locked":false,"title":"Add some debugging and error checking to the scripts","user":{"login":"agbrook","id":8880960,"avatar_url":"https://avatars0.githubusercontent.com/u/8880960?v=4","gravatar_id":"","url":"https://api.github.com/users/agbrook","html_url":"https://github.com/agbrook","followers_url":"https://api.github.com/users/agbrook/followers","following_url":"https://api.github.com/users/agbrook/following{/other_user}","gists_url":"https://api.github.com/users/agbrook/gists{/gist_id}","starred_url":"https://api.github.com/users/agbrook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agbrook/subscriptions","organizations_url":"https://api.github.com/users/agbrook/orgs","repos_url":"https://api.github.com/users/agbrook/repos","events_url":"https://api.github.com/users/agbrook/events{/privacy}","received_events_url":"https://api.github.com/users/agbrook/received_events","type":"User","site_admin":false},"body":"While trying to debug a separate issue with permissions on d42, I found that I wasn't getting enough data from the script to get started. This led me to making these changes to the script to handle error codes from d42 properly and putting them in the log. Also, adding some debug logging to get more information from the salt debug logs if that were necessary. \r\n\r\nThis pull request also adds in a setting in the settings file to determine if the SSL certificate should be checked. In my environment, I want the certificate to be checked, but I know not all of environments need that. This setting should be clear in the settings file instead of having to modify the script to change that. ","created_at":"2017-11-29T21:37:44Z","updated_at":"2017-11-29T23:06:27Z","closed_at":"2017-11-29T23:06:27Z","merged_at":"2017-11-29T23:06:27Z","merge_commit_sha":"3c95e50ee1e74870f5ba31192b310b6282120d11","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/device42/d42_saltstack_external_pillar/pulls/1/commits","review_comments_url":"https://api.github.com/repos/device42/d42_saltstack_external_pillar/pulls/1/comments","review_comment_url":"https://api.github.com/repos/device42/d42_saltstack_external_pillar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/device42/d42_saltstack_external_pillar/issues/1/comments","statuses_url":"https://api.github.com/repos/device42/d42_saltstack_external_pillar/statuses/ba0b59c5a2b152da00766b5a691d2ad0525a21fc","head":{"label":"agbrook:master","ref":"master","sha":"ba0b59c5a2b152da00766b5a691d2ad0525a21fc","user":{"login":"agbrook","id":8880960,"avatar_url":"https://avatars0.githubusercontent.com/u/8880960?v=4","gravatar_id":"","url":"https://api.github.com/users/agbrook","html_url":"https://github.com/agbrook","followers_url":"https://api.github.com/users/agbrook/followers","following_url":"https://api.github.com/users/agbrook/following{/other_user}","gists_url":"https://api.github.com/users/agbrook/gists{/gist_id}","starred_url":"https://api.github.com/users/agbrook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agbrook/subscriptions","organizations_url":"https://api.github.com/users/agbrook/orgs","repos_url":"https://api.github.com/users/agbrook/repos","events_url":"https://api.github.com/users/agbrook/events{/privacy}","received_events_url":"https://api.github.com/users/agbrook/received_events","type":"User","site_admin":false},"repo":{"id":112488272,"name":"d42_saltstack_external_pillar","full_name":"agbrook/d42_saltstack_external_pillar","owner":{"login":"agbrook","id":8880960,"avatar_url":"https://avatars0.githubusercontent.com/u/8880960?v=4","gravatar_id":"","url":"https://api.github.com/users/agbrook","html_url":"https://github.com/agbrook","followers_url":"https://api.github.com/users/agbrook/followers","following_url":"https://api.github.com/users/agbrook/following{/other_user}","gists_url":"https://api.github.com/users/agbrook/gists{/gist_id}","starred_url":"https://api.github.com/users/agbrook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agbrook/subscriptions","organizations_url":"https://api.github.com/users/agbrook/orgs","repos_url":"https://api.github.com/users/agbrook/repos","events_url":"https://api.github.com/users/agbrook/events{/privacy}","received_events_url":"https://api.github.com/users/agbrook/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/agbrook/d42_saltstack_external_pillar","description":"External Pillar Script for SaltStack that loads the Salt Pillar with data from Device42.","fork":true,"url":"https://api.github.com/repos/agbrook/d42_saltstack_external_pillar","forks_url":"https://api.github.com/repos/agbrook/d42_saltstack_external_pillar/forks","keys_url":"https://api.github.com/repos/agbrook/d42_saltstack_external_pillar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/agbrook/d42_saltstack_external_pillar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/agbrook/d42_saltstack_external_pillar/teams","hooks_url":"https://api.github.com/repos/agbrook/d42_saltstack_external_pillar/hooks","issue_events_url":"https://api.github.com/repos/agbrook/d42_saltstack_external_pillar/issues/events{/number}","events_url":"https://api.github.com/repos/agbrook/d42_saltstack_external_pillar/events","assignees_url":"https://api.github.com/repos/agbrook/d42_saltstack_external_pillar/assignees{/user}","branches_url":"https://api.github.com/repos/agbrook/d42_saltstack_external_pillar/branches{/branch}","tags_url":"https://api.github.com/repos/agbrook/d42_saltstack_external_pillar/tags","blobs_url":"https://api.github.com/repos/agbrook/d42_saltstack_external_pillar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/agbrook/d42_saltstack_external_pillar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/agbrook/d42_saltstack_external_pillar/git/refs{/sha}","trees_url":"https://api.github.com/repos/agbrook/d42_saltstack_external_pillar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/agbrook/d42_saltstack_external_pillar/statuses/{sha}","languages_url":"https://api.github.com/repos/agbrook/d42_saltstack_external_pillar/languages","stargazers_url":"https://api.github.com/repos/agbrook/d42_saltstack_external_pillar/stargazers","contributors_url":"https://api.github.com/repos/agbrook/d42_saltstack_external_pillar/contributors","subscribers_url":"https://api.github.com/repos/agbrook/d42_saltstack_external_pillar/subscribers","subscription_url":"https://api.github.com/repos/agbrook/d42_saltstack_external_pillar/subscription","commits_url":"https://api.github.com/repos/agbrook/d42_saltstack_external_pillar/commits{/sha}","git_commits_url":"https://api.github.com/repos/agbrook/d42_saltstack_external_pillar/git/commits{/sha}","comments_url":"https://api.github.com/repos/agbrook/d42_saltstack_external_pillar/comments{/number}","issue_comment_url":"https://api.github.com/repos/agbrook/d42_saltstack_external_pillar/issues/comments{/number}","contents_url":"https://api.github.com/repos/agbrook/d42_saltstack_external_pillar/contents/{+path}","compare_url":"https://api.github.com/repos/agbrook/d42_saltstack_external_pillar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/agbrook/d42_saltstack_external_pillar/merges","archive_url":"https://api.github.com/repos/agbrook/d42_saltstack_external_pillar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/agbrook/d42_saltstack_external_pillar/downloads","issues_url":"https://api.github.com/repos/agbrook/d42_saltstack_external_pillar/issues{/number}","pulls_url":"https://api.github.com/repos/agbrook/d42_saltstack_external_pillar/pulls{/number}","milestones_url":"https://api.github.com/repos/agbrook/d42_saltstack_external_pillar/milestones{/number}","notifications_url":"https://api.github.com/repos/agbrook/d42_saltstack_external_pillar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/agbrook/d42_saltstack_external_pillar/labels{/name}","releases_url":"https://api.github.com/repos/agbrook/d42_saltstack_external_pillar/releases{/id}","deployments_url":"https://api.github.com/repos/agbrook/d42_saltstack_external_pillar/deployments","created_at":"2017-11-29T14:52:19Z","updated_at":"2017-11-29T14:52:21Z","pushed_at":"2017-11-29T21:17:48Z","git_url":"git://github.com/agbrook/d42_saltstack_external_pillar.git","ssh_url":"git@github.com:agbrook/d42_saltstack_external_pillar.git","clone_url":"https://github.com/agbrook/d42_saltstack_external_pillar.git","svn_url":"https://github.com/agbrook/d42_saltstack_external_pillar","homepage":"https://www.device42.com/blog/2017/10/using-device42-with-salt-external-pillar/","size":18,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"device42:master","ref":"master","sha":"c93864e66a7dd14c3a29427f8cde630abf82544a","user":{"login":"device42","id":1425105,"avatar_url":"https://avatars3.githubusercontent.com/u/1425105?v=4","gravatar_id":"","url":"https://api.github.com/users/device42","html_url":"https://github.com/device42","followers_url":"https://api.github.com/users/device42/followers","following_url":"https://api.github.com/users/device42/following{/other_user}","gists_url":"https://api.github.com/users/device42/gists{/gist_id}","starred_url":"https://api.github.com/users/device42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/device42/subscriptions","organizations_url":"https://api.github.com/users/device42/orgs","repos_url":"https://api.github.com/users/device42/repos","events_url":"https://api.github.com/users/device42/events{/privacy}","received_events_url":"https://api.github.com/users/device42/received_events","type":"Organization","site_admin":false},"repo":{"id":108277467,"name":"d42_saltstack_external_pillar","full_name":"device42/d42_saltstack_external_pillar","owner":{"login":"device42","id":1425105,"avatar_url":"https://avatars3.githubusercontent.com/u/1425105?v=4","gravatar_id":"","url":"https://api.github.com/users/device42","html_url":"https://github.com/device42","followers_url":"https://api.github.com/users/device42/followers","following_url":"https://api.github.com/users/device42/following{/other_user}","gists_url":"https://api.github.com/users/device42/gists{/gist_id}","starred_url":"https://api.github.com/users/device42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/device42/subscriptions","organizations_url":"https://api.github.com/users/device42/orgs","repos_url":"https://api.github.com/users/device42/repos","events_url":"https://api.github.com/users/device42/events{/privacy}","received_events_url":"https://api.github.com/users/device42/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/device42/d42_saltstack_external_pillar","description":"External Pillar Script for SaltStack that loads the Salt Pillar with data from Device42.","fork":false,"url":"https://api.github.com/repos/device42/d42_saltstack_external_pillar","forks_url":"https://api.github.com/repos/device42/d42_saltstack_external_pillar/forks","keys_url":"https://api.github.com/repos/device42/d42_saltstack_external_pillar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/device42/d42_saltstack_external_pillar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/device42/d42_saltstack_external_pillar/teams","hooks_url":"https://api.github.com/repos/device42/d42_saltstack_external_pillar/hooks","issue_events_url":"https://api.github.com/repos/device42/d42_saltstack_external_pillar/issues/events{/number}","events_url":"https://api.github.com/repos/device42/d42_saltstack_external_pillar/events","assignees_url":"https://api.github.com/repos/device42/d42_saltstack_external_pillar/assignees{/user}","branches_url":"https://api.github.com/repos/device42/d42_saltstack_external_pillar/branches{/branch}","tags_url":"https://api.github.com/repos/device42/d42_saltstack_external_pillar/tags","blobs_url":"https://api.github.com/repos/device42/d42_saltstack_external_pillar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/device42/d42_saltstack_external_pillar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/device42/d42_saltstack_external_pillar/git/refs{/sha}","trees_url":"https://api.github.com/repos/device42/d42_saltstack_external_pillar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/device42/d42_saltstack_external_pillar/statuses/{sha}","languages_url":"https://api.github.com/repos/device42/d42_saltstack_external_pillar/languages","stargazers_url":"https://api.github.com/repos/device42/d42_saltstack_external_pillar/stargazers","contributors_url":"https://api.github.com/repos/device42/d42_saltstack_external_pillar/contributors","subscribers_url":"https://api.github.com/repos/device42/d42_saltstack_external_pillar/subscribers","subscription_url":"https://api.github.com/repos/device42/d42_saltstack_external_pillar/subscription","commits_url":"https://api.github.com/repos/device42/d42_saltstack_external_pillar/commits{/sha}","git_commits_url":"https://api.github.com/repos/device42/d42_saltstack_external_pillar/git/commits{/sha}","comments_url":"https://api.github.com/repos/device42/d42_saltstack_external_pillar/comments{/number}","issue_comment_url":"https://api.github.com/repos/device42/d42_saltstack_external_pillar/issues/comments{/number}","contents_url":"https://api.github.com/repos/device42/d42_saltstack_external_pillar/contents/{+path}","compare_url":"https://api.github.com/repos/device42/d42_saltstack_external_pillar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/device42/d42_saltstack_external_pillar/merges","archive_url":"https://api.github.com/repos/device42/d42_saltstack_external_pillar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/device42/d42_saltstack_external_pillar/downloads","issues_url":"https://api.github.com/repos/device42/d42_saltstack_external_pillar/issues{/number}","pulls_url":"https://api.github.com/repos/device42/d42_saltstack_external_pillar/pulls{/number}","milestones_url":"https://api.github.com/repos/device42/d42_saltstack_external_pillar/milestones{/number}","notifications_url":"https://api.github.com/repos/device42/d42_saltstack_external_pillar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/device42/d42_saltstack_external_pillar/labels{/name}","releases_url":"https://api.github.com/repos/device42/d42_saltstack_external_pillar/releases{/id}","deployments_url":"https://api.github.com/repos/device42/d42_saltstack_external_pillar/deployments","created_at":"2017-10-25T13:55:33Z","updated_at":"2017-11-16T17:29:52Z","pushed_at":"2017-11-29T23:06:27Z","git_url":"git://github.com/device42/d42_saltstack_external_pillar.git","ssh_url":"git@github.com:device42/d42_saltstack_external_pillar.git","clone_url":"https://github.com/device42/d42_saltstack_external_pillar.git","svn_url":"https://github.com/device42/d42_saltstack_external_pillar","homepage":"https://www.device42.com/blog/2017/10/using-device42-with-salt-external-pillar/","size":12,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/device42/d42_saltstack_external_pillar/pulls/1"},"html":{"href":"https://github.com/device42/d42_saltstack_external_pillar/pull/1"},"issue":{"href":"https://api.github.com/repos/device42/d42_saltstack_external_pillar/issues/1"},"comments":{"href":"https://api.github.com/repos/device42/d42_saltstack_external_pillar/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/device42/d42_saltstack_external_pillar/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/device42/d42_saltstack_external_pillar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/device42/d42_saltstack_external_pillar/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/device42/d42_saltstack_external_pillar/statuses/ba0b59c5a2b152da00766b5a691d2ad0525a21fc"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"deusofnull","id":3485446,"avatar_url":"https://avatars1.githubusercontent.com/u/3485446?v=4","gravatar_id":"","url":"https://api.github.com/users/deusofnull","html_url":"https://github.com/deusofnull","followers_url":"https://api.github.com/users/deusofnull/followers","following_url":"https://api.github.com/users/deusofnull/following{/other_user}","gists_url":"https://api.github.com/users/deusofnull/gists{/gist_id}","starred_url":"https://api.github.com/users/deusofnull/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deusofnull/subscriptions","organizations_url":"https://api.github.com/users/deusofnull/orgs","repos_url":"https://api.github.com/users/deusofnull/repos","events_url":"https://api.github.com/users/deusofnull/events{/privacy}","received_events_url":"https://api.github.com/users/deusofnull/received_events","type":"User","site_admin":false},"comments":0,"review_comments":1,"maintainer_can_modify":false,"commits":10,"additions":73,"deletions":38,"changed_files":3}}
{"actor":{"display_login":"deusofnull"}}