{"action":"created","issue":{"url":"https://api.github.com/repos/phpbb/phpbb/issues/4698","repository_url":"https://api.github.com/repos/phpbb/phpbb","labels_url":"https://api.github.com/repos/phpbb/phpbb/issues/4698/labels{/name}","comments_url":"https://api.github.com/repos/phpbb/phpbb/issues/4698/comments","events_url":"https://api.github.com/repos/phpbb/phpbb/issues/4698/events","html_url":"https://github.com/phpbb/phpbb/pull/4698","id":207059534,"number":4698,"title":"[ticket/15087] Optimize creation of metadata objects by caching","user":{"login":"javiexin","id":11807050,"avatar_url":"https://avatars2.githubusercontent.com/u/11807050?v=3","gravatar_id":"","url":"https://api.github.com/users/javiexin","html_url":"https://github.com/javiexin","followers_url":"https://api.github.com/users/javiexin/followers","following_url":"https://api.github.com/users/javiexin/following{/other_user}","gists_url":"https://api.github.com/users/javiexin/gists{/gist_id}","starred_url":"https://api.github.com/users/javiexin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javiexin/subscriptions","organizations_url":"https://api.github.com/users/javiexin/orgs","repos_url":"https://api.github.com/users/javiexin/repos","events_url":"https://api.github.com/users/javiexin/events{/privacy}","received_events_url":"https://api.github.com/users/javiexin/received_events","type":"User","site_admin":false},"labels":[{"id":118148851,"url":"https://api.github.com/repos/phpbb/phpbb/labels/3.2%20(Rhea)","name":"3.2 (Rhea)","color":"c7def8","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/phpbb/phpbb/milestones/23","html_url":"https://github.com/phpbb/phpbb/milestone/23","labels_url":"https://api.github.com/repos/phpbb/phpbb/milestones/23/labels","id":2223136,"number":23,"title":"3.2.1","description":"","creator":{"login":"marc1706","id":394418,"avatar_url":"https://avatars1.githubusercontent.com/u/394418?v=3","gravatar_id":"","url":"https://api.github.com/users/marc1706","html_url":"https://github.com/marc1706","followers_url":"https://api.github.com/users/marc1706/followers","following_url":"https://api.github.com/users/marc1706/following{/other_user}","gists_url":"https://api.github.com/users/marc1706/gists{/gist_id}","starred_url":"https://api.github.com/users/marc1706/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marc1706/subscriptions","organizations_url":"https://api.github.com/users/marc1706/orgs","repos_url":"https://api.github.com/users/marc1706/repos","events_url":"https://api.github.com/users/marc1706/events{/privacy}","received_events_url":"https://api.github.com/users/marc1706/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":57,"state":"open","created_at":"2017-01-02T11:13:59Z","updated_at":"2017-04-17T10:03:21Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2017-02-12T16:05:08Z","updated_at":"2017-04-17T10:29:01Z","closed_at":"2017-04-16T09:43:56Z","pull_request":{"url":"https://api.github.com/repos/phpbb/phpbb/pulls/4698","html_url":"https://github.com/phpbb/phpbb/pull/4698","diff_url":"https://github.com/phpbb/phpbb/pull/4698.diff","patch_url":"https://github.com/phpbb/phpbb/pull/4698.patch"},"body":"Caching is done in ext_manager, and metadata_manager is further simplified\r\nby reducing the number of parameters needed.  Also, move template output\r\nfunction from metadata_manager to acp_extensions, where it belongs.\r\n\r\nIncluded here are 3.2 versions of the following PRs:\r\n\r\n- https://github.com/phpbb/phpbb/pull/4581 [ticket/14919] Do not directly use globals in acp_extensions\r\n- https://github.com/phpbb/phpbb/pull/4592 [ticket/14938] Inconsistency in ext_mgr all_available vs is_available\r\n- https://github.com/phpbb/phpbb/pull/4689 [ticket/15080] Save unneeded file loads for extension metadata\r\n\r\nChecklist:\r\n\r\n- [x] Correct branch: master for new features; 3.2.x, 3.1.x for fixes\r\n- [x] Tests pass\r\n- [x] Code follows coding guidelines: [master / 3.2.x](https://area51.phpbb.com/docs/master/coding-guidelines.html), [3.1.x](https://area51.phpbb.com/docs/31x/coding-guidelines.html)\r\n- [x] Commit follows commit message [format](https://wiki.phpbb.com/Git#Commit_Messages)\r\n\r\nTracker ticket:\r\n\r\nhttps://tracker.phpbb.com/browse/PHPBB3-15087\r\n"},"comment":{"url":"https://api.github.com/repos/phpbb/phpbb/issues/comments/294446858","html_url":"https://github.com/phpbb/phpbb/pull/4698#issuecomment-294446858","issue_url":"https://api.github.com/repos/phpbb/phpbb/issues/4698","id":294446858,"user":{"login":"javiexin","id":11807050,"avatar_url":"https://avatars2.githubusercontent.com/u/11807050?v=3","gravatar_id":"","url":"https://api.github.com/users/javiexin","html_url":"https://github.com/javiexin","followers_url":"https://api.github.com/users/javiexin/followers","following_url":"https://api.github.com/users/javiexin/following{/other_user}","gists_url":"https://api.github.com/users/javiexin/gists{/gist_id}","starred_url":"https://api.github.com/users/javiexin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javiexin/subscriptions","organizations_url":"https://api.github.com/users/javiexin/orgs","repos_url":"https://api.github.com/users/javiexin/repos","events_url":"https://api.github.com/users/javiexin/events{/privacy}","received_events_url":"https://api.github.com/users/javiexin/received_events","type":"User","site_admin":false},"created_at":"2017-04-17T10:29:01Z","updated_at":"2017-04-17T10:29:01Z","body":"Thanks a lot, I will do it this way in the future. There might be other issues with other PRs where I did not use this process, so I will review them all to try and save some extra efforts."}}
{"actor":{"display_login":"javiexin"}}