{"action":"created","issue":{"url":"https://api.github.com/repos/petergoldstein/dalli/issues/645","repository_url":"https://api.github.com/repos/petergoldstein/dalli","labels_url":"https://api.github.com/repos/petergoldstein/dalli/issues/645/labels{/name}","comments_url":"https://api.github.com/repos/petergoldstein/dalli/issues/645/comments","events_url":"https://api.github.com/repos/petergoldstein/dalli/issues/645/events","html_url":"https://github.com/petergoldstein/dalli/pull/645","id":198828522,"number":645,"title":"ActiveSupport instrument DalliStore errors","user":{"login":"btatnall","id":10264,"avatar_url":"https://avatars.githubusercontent.com/u/10264?v=3","gravatar_id":"","url":"https://api.github.com/users/btatnall","html_url":"https://github.com/btatnall","followers_url":"https://api.github.com/users/btatnall/followers","following_url":"https://api.github.com/users/btatnall/following{/other_user}","gists_url":"https://api.github.com/users/btatnall/gists{/gist_id}","starred_url":"https://api.github.com/users/btatnall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/btatnall/subscriptions","organizations_url":"https://api.github.com/users/btatnall/orgs","repos_url":"https://api.github.com/users/btatnall/repos","events_url":"https://api.github.com/users/btatnall/events{/privacy}","received_events_url":"https://api.github.com/users/btatnall/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-01-04T22:34:25Z","updated_at":"2017-01-05T17:47:58Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/petergoldstein/dalli/pulls/645","html_url":"https://github.com/petergoldstein/dalli/pull/645","diff_url":"https://github.com/petergoldstein/dalli/pull/645.diff","patch_url":"https://github.com/petergoldstein/dalli/pull/645.patch"},"body":"Previously, one could use raise_errors to either handle execptions\r\nin client code or have them handled by dalli. In the later case,\r\nlogging was the only way to be notified of an exception. This\r\ncommit adds the ability to be notified via active support\r\ninstrumentation via a cache_error.active_support event.\r\n\r\nI've added this code because I want to know when errors are\r\noccuring to trigger external monitoring and I still want\r\ndalli to fail without raising errors so that cached values\r\nare still generated."},"comment":{"url":"https://api.github.com/repos/petergoldstein/dalli/issues/comments/270708779","html_url":"https://github.com/petergoldstein/dalli/pull/645#issuecomment-270708779","issue_url":"https://api.github.com/repos/petergoldstein/dalli/issues/645","id":270708779,"user":{"login":"petergoldstein","id":421488,"avatar_url":"https://avatars.githubusercontent.com/u/421488?v=3","gravatar_id":"","url":"https://api.github.com/users/petergoldstein","html_url":"https://github.com/petergoldstein","followers_url":"https://api.github.com/users/petergoldstein/followers","following_url":"https://api.github.com/users/petergoldstein/following{/other_user}","gists_url":"https://api.github.com/users/petergoldstein/gists{/gist_id}","starred_url":"https://api.github.com/users/petergoldstein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petergoldstein/subscriptions","organizations_url":"https://api.github.com/users/petergoldstein/orgs","repos_url":"https://api.github.com/users/petergoldstein/repos","events_url":"https://api.github.com/users/petergoldstein/events{/privacy}","received_events_url":"https://api.github.com/users/petergoldstein/received_events","type":"User","site_admin":false},"created_at":"2017-01-05T17:47:58Z","updated_at":"2017-01-05T17:47:58Z","body":"@btatnall I agree - looks like it's a Gemfile issue, because the latest Nokogiri no longer supports Ruby 2.0.x.  At first pass this looks good - I'll take a closer look this weekend and merge/reply as needed.\r\n\r\nPer your documentation question, I'd expect this option to be public in the same vein as raise_errors.  So if you haven't already added such documentation as part of the PR, please do."}}
{"actor":{"display_login":"petergoldstein"}}