{"action":"created","issue":{"url":"https://api.github.com/repos/plackemacher/secure_compare/issues/3","repository_url":"https://api.github.com/repos/plackemacher/secure_compare","labels_url":"https://api.github.com/repos/plackemacher/secure_compare/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/plackemacher/secure_compare/issues/3/comments","events_url":"https://api.github.com/repos/plackemacher/secure_compare/issues/3/events","html_url":"https://github.com/plackemacher/secure_compare/pull/3","id":248836872,"number":3,"title":"Address String.to_char_list deprecations","user":{"login":"zfletch","id":3039310,"avatar_url":"https://avatars0.githubusercontent.com/u/3039310?v=4","gravatar_id":"","url":"https://api.github.com/users/zfletch","html_url":"https://github.com/zfletch","followers_url":"https://api.github.com/users/zfletch/followers","following_url":"https://api.github.com/users/zfletch/following{/other_user}","gists_url":"https://api.github.com/users/zfletch/gists{/gist_id}","starred_url":"https://api.github.com/users/zfletch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zfletch/subscriptions","organizations_url":"https://api.github.com/users/zfletch/orgs","repos_url":"https://api.github.com/users/zfletch/repos","events_url":"https://api.github.com/users/zfletch/events{/privacy}","received_events_url":"https://api.github.com/users/zfletch/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-08-08T20:29:39Z","updated_at":"2017-08-15T19:38:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/plackemacher/secure_compare/pulls/3","html_url":"https://github.com/plackemacher/secure_compare/pull/3","diff_url":"https://github.com/plackemacher/secure_compare/pull/3.diff","patch_url":"https://github.com/plackemacher/secure_compare/pull/3.patch"},"body":"When running the code with Elixir version 1.5.1, the following warnings are generated:\r\n\r\n```\r\nwarning: String.to_char_list/1 is deprecated, use String.to_charlist/1\r\n  lib/secure_compare.ex:7\r\n\r\nwarning: String.to_char_list/1 is deprecated, use String.to_charlist/1\r\n  lib/secure_compare.ex:8\r\n```\r\n\r\nThis PR updates the code to use `to_charlist` in order to address the warning.\r\n\r\nThere's some discussion about the two functions [here](https://github.com/elixir-lang/elixir/issues/4909)"},"comment":{"url":"https://api.github.com/repos/plackemacher/secure_compare/issues/comments/322566910","html_url":"https://github.com/plackemacher/secure_compare/pull/3#issuecomment-322566910","issue_url":"https://api.github.com/repos/plackemacher/secure_compare/issues/3","id":322566910,"user":{"login":"plackemacher","id":1130517,"avatar_url":"https://avatars2.githubusercontent.com/u/1130517?v=4","gravatar_id":"","url":"https://api.github.com/users/plackemacher","html_url":"https://github.com/plackemacher","followers_url":"https://api.github.com/users/plackemacher/followers","following_url":"https://api.github.com/users/plackemacher/following{/other_user}","gists_url":"https://api.github.com/users/plackemacher/gists{/gist_id}","starred_url":"https://api.github.com/users/plackemacher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plackemacher/subscriptions","organizations_url":"https://api.github.com/users/plackemacher/orgs","repos_url":"https://api.github.com/users/plackemacher/repos","events_url":"https://api.github.com/users/plackemacher/events{/privacy}","received_events_url":"https://api.github.com/users/plackemacher/received_events","type":"User","site_admin":false},"created_at":"2017-08-15T19:38:32Z","updated_at":"2017-08-15T19:38:32Z","body":"Sorry for the delay on this. I've added some commits to your branch. I'm okay with dropping support for versions of Elixir less than 1.3 and therefore bumping the version up to `0.1.0`. If Travis passes on this, I'll merge it and hopefully do a release today. Thanks for the PR! 👍 "}}
{"actor":{"display_login":"plackemacher"}}