{"action":"created","comment":{"url":"https://api.github.com/repos/QuantConnect/Lean/pulls/comments/134345173","pull_request_review_id":57625675,"id":134345173,"diff_hunk":"@@ -120,6 +126,7 @@ DataNormalizationMode dataNormalizationMode\n             DataType = dataType;\n             IsCustomData = isCustomData;\n             DataNormalizationMode = dataNormalizationMode;\n+            TickType = LeanData.GetCommonTickTypeForCommonDataTypes(DataType, symbol.SecurityType);","path":"Common/Data/HistoryRequest.cs","position":null,"original_position":35,"commit_id":"62324abbdf364d40033901f933f3bdd0e0707abc","original_commit_id":"62324abbdf364d40033901f933f3bdd0e0707abc","user":{"login":"jaredbroad","id":2243225,"avatar_url":"https://avatars2.githubusercontent.com/u/2243225?v=4","gravatar_id":"","url":"https://api.github.com/users/jaredbroad","html_url":"https://github.com/jaredbroad","followers_url":"https://api.github.com/users/jaredbroad/followers","following_url":"https://api.github.com/users/jaredbroad/following{/other_user}","gists_url":"https://api.github.com/users/jaredbroad/gists{/gist_id}","starred_url":"https://api.github.com/users/jaredbroad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaredbroad/subscriptions","organizations_url":"https://api.github.com/users/jaredbroad/orgs","repos_url":"https://api.github.com/users/jaredbroad/repos","events_url":"https://api.github.com/users/jaredbroad/events{/privacy}","received_events_url":"https://api.github.com/users/jaredbroad/received_events","type":"User","site_admin":false},"body":"Passed in then not used","created_at":"2017-08-21T22:20:09Z","updated_at":"2017-08-21T22:20:09Z","html_url":"https://github.com/QuantConnect/Lean/pull/1081#discussion_r134345173","pull_request_url":"https://api.github.com/repos/QuantConnect/Lean/pulls/1081","_links":{"self":{"href":"https://api.github.com/repos/QuantConnect/Lean/pulls/comments/134345173"},"html":{"href":"https://github.com/QuantConnect/Lean/pull/1081#discussion_r134345173"},"pull_request":{"href":"https://api.github.com/repos/QuantConnect/Lean/pulls/1081"}}},"pull_request":{"url":"https://api.github.com/repos/QuantConnect/Lean/pulls/1081","id":136836717,"html_url":"https://github.com/QuantConnect/Lean/pull/1081","diff_url":"https://github.com/QuantConnect/Lean/pull/1081.diff","patch_url":"https://github.com/QuantConnect/Lean/pull/1081.patch","issue_url":"https://api.github.com/repos/QuantConnect/Lean/issues/1081","number":1081,"state":"open","locked":false,"title":"Require specification of DataTimeZone on history requests","user":{"login":"andrewhart098","id":2603162,"avatar_url":"https://avatars3.githubusercontent.com/u/2603162?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewhart098","html_url":"https://github.com/andrewhart098","followers_url":"https://api.github.com/users/andrewhart098/followers","following_url":"https://api.github.com/users/andrewhart098/following{/other_user}","gists_url":"https://api.github.com/users/andrewhart098/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewhart098/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewhart098/subscriptions","organizations_url":"https://api.github.com/users/andrewhart098/orgs","repos_url":"https://api.github.com/users/andrewhart098/repos","events_url":"https://api.github.com/users/andrewhart098/events{/privacy}","received_events_url":"https://api.github.com/users/andrewhart098/received_events","type":"User","site_admin":false},"body":"- Renamed `HistoryRequest.TimeZone` to `HistoryRequest.DataTimeZone` using resharper in order to be clearer on what this timezone is used for.\r\n- Removed the parameterless `HistoryRequest` constructor. Defaults are not assumed by the `HistoryRequest` and must be specified.\r\n- Added new `AddData` method that allows users to specify separate exchange time zones and the data time zones.\r\n- Added new method, `Security.IsCustomData` that determines if the security contains at least one subscription that represents custom data \r\n- Added `HistoryRequest.TickType` to avoid ambiguity between Options/Futures history request with Tick resolution ","created_at":"2017-08-21T20:29:37Z","updated_at":"2017-08-21T22:20:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7f852ae80c2acd0711708ee794c04e9969cef838","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/QuantConnect/Lean/pulls/1081/commits","review_comments_url":"https://api.github.com/repos/QuantConnect/Lean/pulls/1081/comments","review_comment_url":"https://api.github.com/repos/QuantConnect/Lean/pulls/comments{/number}","comments_url":"https://api.github.com/repos/QuantConnect/Lean/issues/1081/comments","statuses_url":"https://api.github.com/repos/QuantConnect/Lean/statuses/62324abbdf364d40033901f933f3bdd0e0707abc","head":{"label":"andrewhart098:history-request-timezone","ref":"history-request-timezone","sha":"62324abbdf364d40033901f933f3bdd0e0707abc","user":{"login":"andrewhart098","id":2603162,"avatar_url":"https://avatars3.githubusercontent.com/u/2603162?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewhart098","html_url":"https://github.com/andrewhart098","followers_url":"https://api.github.com/users/andrewhart098/followers","following_url":"https://api.github.com/users/andrewhart098/following{/other_user}","gists_url":"https://api.github.com/users/andrewhart098/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewhart098/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewhart098/subscriptions","organizations_url":"https://api.github.com/users/andrewhart098/orgs","repos_url":"https://api.github.com/users/andrewhart098/repos","events_url":"https://api.github.com/users/andrewhart098/events{/privacy}","received_events_url":"https://api.github.com/users/andrewhart098/received_events","type":"User","site_admin":false},"repo":{"id":65205707,"name":"Lean","full_name":"andrewhart098/Lean","owner":{"login":"andrewhart098","id":2603162,"avatar_url":"https://avatars3.githubusercontent.com/u/2603162?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewhart098","html_url":"https://github.com/andrewhart098","followers_url":"https://api.github.com/users/andrewhart098/followers","following_url":"https://api.github.com/users/andrewhart098/following{/other_user}","gists_url":"https://api.github.com/users/andrewhart098/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewhart098/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewhart098/subscriptions","organizations_url":"https://api.github.com/users/andrewhart098/orgs","repos_url":"https://api.github.com/users/andrewhart098/repos","events_url":"https://api.github.com/users/andrewhart098/events{/privacy}","received_events_url":"https://api.github.com/users/andrewhart098/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andrewhart098/Lean","description":"Lean Algorithmic Trading Engine by QuantConnect (C#, Python, F#, VB, Java)","fork":true,"url":"https://api.github.com/repos/andrewhart098/Lean","forks_url":"https://api.github.com/repos/andrewhart098/Lean/forks","keys_url":"https://api.github.com/repos/andrewhart098/Lean/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andrewhart098/Lean/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andrewhart098/Lean/teams","hooks_url":"https://api.github.com/repos/andrewhart098/Lean/hooks","issue_events_url":"https://api.github.com/repos/andrewhart098/Lean/issues/events{/number}","events_url":"https://api.github.com/repos/andrewhart098/Lean/events","assignees_url":"https://api.github.com/repos/andrewhart098/Lean/assignees{/user}","branches_url":"https://api.github.com/repos/andrewhart098/Lean/branches{/branch}","tags_url":"https://api.github.com/repos/andrewhart098/Lean/tags","blobs_url":"https://api.github.com/repos/andrewhart098/Lean/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andrewhart098/Lean/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andrewhart098/Lean/git/refs{/sha}","trees_url":"https://api.github.com/repos/andrewhart098/Lean/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andrewhart098/Lean/statuses/{sha}","languages_url":"https://api.github.com/repos/andrewhart098/Lean/languages","stargazers_url":"https://api.github.com/repos/andrewhart098/Lean/stargazers","contributors_url":"https://api.github.com/repos/andrewhart098/Lean/contributors","subscribers_url":"https://api.github.com/repos/andrewhart098/Lean/subscribers","subscription_url":"https://api.github.com/repos/andrewhart098/Lean/subscription","commits_url":"https://api.github.com/repos/andrewhart098/Lean/commits{/sha}","git_commits_url":"https://api.github.com/repos/andrewhart098/Lean/git/commits{/sha}","comments_url":"https://api.github.com/repos/andrewhart098/Lean/comments{/number}","issue_comment_url":"https://api.github.com/repos/andrewhart098/Lean/issues/comments{/number}","contents_url":"https://api.github.com/repos/andrewhart098/Lean/contents/{+path}","compare_url":"https://api.github.com/repos/andrewhart098/Lean/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andrewhart098/Lean/merges","archive_url":"https://api.github.com/repos/andrewhart098/Lean/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andrewhart098/Lean/downloads","issues_url":"https://api.github.com/repos/andrewhart098/Lean/issues{/number}","pulls_url":"https://api.github.com/repos/andrewhart098/Lean/pulls{/number}","milestones_url":"https://api.github.com/repos/andrewhart098/Lean/milestones{/number}","notifications_url":"https://api.github.com/repos/andrewhart098/Lean/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andrewhart098/Lean/labels{/name}","releases_url":"https://api.github.com/repos/andrewhart098/Lean/releases{/id}","deployments_url":"https://api.github.com/repos/andrewhart098/Lean/deployments","created_at":"2016-08-08T13:18:15Z","updated_at":"2016-11-02T17:18:22Z","pushed_at":"2017-08-21T21:46:08Z","git_url":"git://github.com/andrewhart098/Lean.git","ssh_url":"git@github.com:andrewhart098/Lean.git","clone_url":"https://github.com/andrewhart098/Lean.git","svn_url":"https://github.com/andrewhart098/Lean","homepage":"https://lean.quantconnect.com","size":194960,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"QuantConnect:master","ref":"master","sha":"f574bfd7d6ad6007fb36d71c426e9a6a09304d7c","user":{"login":"QuantConnect","id":3912814,"avatar_url":"https://avatars0.githubusercontent.com/u/3912814?v=4","gravatar_id":"","url":"https://api.github.com/users/QuantConnect","html_url":"https://github.com/QuantConnect","followers_url":"https://api.github.com/users/QuantConnect/followers","following_url":"https://api.github.com/users/QuantConnect/following{/other_user}","gists_url":"https://api.github.com/users/QuantConnect/gists{/gist_id}","starred_url":"https://api.github.com/users/QuantConnect/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QuantConnect/subscriptions","organizations_url":"https://api.github.com/users/QuantConnect/orgs","repos_url":"https://api.github.com/users/QuantConnect/repos","events_url":"https://api.github.com/users/QuantConnect/events{/privacy}","received_events_url":"https://api.github.com/users/QuantConnect/received_events","type":"Organization","site_admin":false},"repo":{"id":27251463,"name":"Lean","full_name":"QuantConnect/Lean","owner":{"login":"QuantConnect","id":3912814,"avatar_url":"https://avatars0.githubusercontent.com/u/3912814?v=4","gravatar_id":"","url":"https://api.github.com/users/QuantConnect","html_url":"https://github.com/QuantConnect","followers_url":"https://api.github.com/users/QuantConnect/followers","following_url":"https://api.github.com/users/QuantConnect/following{/other_user}","gists_url":"https://api.github.com/users/QuantConnect/gists{/gist_id}","starred_url":"https://api.github.com/users/QuantConnect/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QuantConnect/subscriptions","organizations_url":"https://api.github.com/users/QuantConnect/orgs","repos_url":"https://api.github.com/users/QuantConnect/repos","events_url":"https://api.github.com/users/QuantConnect/events{/privacy}","received_events_url":"https://api.github.com/users/QuantConnect/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/QuantConnect/Lean","description":"Lean Algorithmic Trading Engine by QuantConnect (C#, Python, F#, VB, Java)","fork":false,"url":"https://api.github.com/repos/QuantConnect/Lean","forks_url":"https://api.github.com/repos/QuantConnect/Lean/forks","keys_url":"https://api.github.com/repos/QuantConnect/Lean/keys{/key_id}","collaborators_url":"https://api.github.com/repos/QuantConnect/Lean/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/QuantConnect/Lean/teams","hooks_url":"https://api.github.com/repos/QuantConnect/Lean/hooks","issue_events_url":"https://api.github.com/repos/QuantConnect/Lean/issues/events{/number}","events_url":"https://api.github.com/repos/QuantConnect/Lean/events","assignees_url":"https://api.github.com/repos/QuantConnect/Lean/assignees{/user}","branches_url":"https://api.github.com/repos/QuantConnect/Lean/branches{/branch}","tags_url":"https://api.github.com/repos/QuantConnect/Lean/tags","blobs_url":"https://api.github.com/repos/QuantConnect/Lean/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/QuantConnect/Lean/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/QuantConnect/Lean/git/refs{/sha}","trees_url":"https://api.github.com/repos/QuantConnect/Lean/git/trees{/sha}","statuses_url":"https://api.github.com/repos/QuantConnect/Lean/statuses/{sha}","languages_url":"https://api.github.com/repos/QuantConnect/Lean/languages","stargazers_url":"https://api.github.com/repos/QuantConnect/Lean/stargazers","contributors_url":"https://api.github.com/repos/QuantConnect/Lean/contributors","subscribers_url":"https://api.github.com/repos/QuantConnect/Lean/subscribers","subscription_url":"https://api.github.com/repos/QuantConnect/Lean/subscription","commits_url":"https://api.github.com/repos/QuantConnect/Lean/commits{/sha}","git_commits_url":"https://api.github.com/repos/QuantConnect/Lean/git/commits{/sha}","comments_url":"https://api.github.com/repos/QuantConnect/Lean/comments{/number}","issue_comment_url":"https://api.github.com/repos/QuantConnect/Lean/issues/comments{/number}","contents_url":"https://api.github.com/repos/QuantConnect/Lean/contents/{+path}","compare_url":"https://api.github.com/repos/QuantConnect/Lean/compare/{base}...{head}","merges_url":"https://api.github.com/repos/QuantConnect/Lean/merges","archive_url":"https://api.github.com/repos/QuantConnect/Lean/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/QuantConnect/Lean/downloads","issues_url":"https://api.github.com/repos/QuantConnect/Lean/issues{/number}","pulls_url":"https://api.github.com/repos/QuantConnect/Lean/pulls{/number}","milestones_url":"https://api.github.com/repos/QuantConnect/Lean/milestones{/number}","notifications_url":"https://api.github.com/repos/QuantConnect/Lean/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/QuantConnect/Lean/labels{/name}","releases_url":"https://api.github.com/repos/QuantConnect/Lean/releases{/id}","deployments_url":"https://api.github.com/repos/QuantConnect/Lean/deployments","created_at":"2014-11-28T04:20:19Z","updated_at":"2017-08-21T16:03:10Z","pushed_at":"2017-08-21T21:46:10Z","git_url":"git://github.com/QuantConnect/Lean.git","ssh_url":"git@github.com:QuantConnect/Lean.git","clone_url":"https://github.com/QuantConnect/Lean.git","svn_url":"https://github.com/QuantConnect/Lean","homepage":"https://lean.quantconnect.com","size":190434,"stargazers_count":996,"watchers_count":996,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":641,"mirror_url":null,"open_issues_count":55,"forks":641,"open_issues":55,"watchers":996,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/QuantConnect/Lean/pulls/1081"},"html":{"href":"https://github.com/QuantConnect/Lean/pull/1081"},"issue":{"href":"https://api.github.com/repos/QuantConnect/Lean/issues/1081"},"comments":{"href":"https://api.github.com/repos/QuantConnect/Lean/issues/1081/comments"},"review_comments":{"href":"https://api.github.com/repos/QuantConnect/Lean/pulls/1081/comments"},"review_comment":{"href":"https://api.github.com/repos/QuantConnect/Lean/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/QuantConnect/Lean/pulls/1081/commits"},"statuses":{"href":"https://api.github.com/repos/QuantConnect/Lean/statuses/62324abbdf364d40033901f933f3bdd0e0707abc"}}}}
{"actor":{"display_login":"jaredbroad"}}