{"action":"created","comment":{"url":"https://api.github.com/repos/fossasia/badgeyay/pulls/comments/148952594","pull_request_review_id":74276640,"id":148952594,"diff_hunk":"@@ -66,67 +66,72 @@ def upload():\n     csv = request.form['csv'].strip()\n     img = request.form['img-default']\n     eventyay_url = request.form['eventyay_url'].strip()\n+    text_on_image = request.form['text_on_image']\n     file = request.files['file']\n     _pdf = True if request.form.get('pdf') == 'on' else False\n     _zip = True if request.form.get('zip') == 'on' else False\n \n     if not _pdf and not _zip:\n         flash('Please select a download filetype!', 'error')\n         return redirect(url_for('index'))\n-    if file.filename == '' and csv == '':\n-            flash('Please select a CSV file to Upload!', 'error')\n-            return redirect(url_for('index'))\n \n     # If default background is selected\n     if img != '':\n         if(img == 'user_defined.png'):\n             bg_color = request.form['bg_color']\n             text_on_image = request.form['text_on_image']\n             do_svg2png(img, 1, bg_color, text_on_image)\n+            filename = img + '.csv'","path":"app/main.py","position":31,"original_position":31,"commit_id":"1958247b9294fbef2c1fe3dca8b533e0fb71ca41","original_commit_id":"1958247b9294fbef2c1fe3dca8b533e0fb71ca41","user":{"login":"jajodiaraghav","id":18749480,"avatar_url":"https://avatars2.githubusercontent.com/u/18749480?v=4","gravatar_id":"","url":"https://api.github.com/users/jajodiaraghav","html_url":"https://github.com/jajodiaraghav","followers_url":"https://api.github.com/users/jajodiaraghav/followers","following_url":"https://api.github.com/users/jajodiaraghav/following{/other_user}","gists_url":"https://api.github.com/users/jajodiaraghav/gists{/gist_id}","starred_url":"https://api.github.com/users/jajodiaraghav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jajodiaraghav/subscriptions","organizations_url":"https://api.github.com/users/jajodiaraghav/orgs","repos_url":"https://api.github.com/users/jajodiaraghav/repos","events_url":"https://api.github.com/users/jajodiaraghav/events{/privacy}","received_events_url":"https://api.github.com/users/jajodiaraghav/received_events","type":"User","site_admin":false},"body":"What is the point of adding this line here? The `filename = img + '.csv'` is going to execute in the next line anyway","created_at":"2017-11-05T09:48:34Z","updated_at":"2017-11-05T09:51:14Z","html_url":"https://github.com/fossasia/badgeyay/pull/316#discussion_r148952594","pull_request_url":"https://api.github.com/repos/fossasia/badgeyay/pulls/316","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/fossasia/badgeyay/pulls/comments/148952594"},"html":{"href":"https://github.com/fossasia/badgeyay/pull/316#discussion_r148952594"},"pull_request":{"href":"https://api.github.com/repos/fossasia/badgeyay/pulls/316"}}},"pull_request":{"url":"https://api.github.com/repos/fossasia/badgeyay/pulls/316","id":150674340,"html_url":"https://github.com/fossasia/badgeyay/pull/316","diff_url":"https://github.com/fossasia/badgeyay/pull/316.diff","patch_url":"https://github.com/fossasia/badgeyay/pull/316.patch","issue_url":"https://api.github.com/repos/fossasia/badgeyay/issues/316","number":316,"state":"open","locked":false,"title":"Generate Badges for Manual Data with pre-selected images","user":{"login":"gabru-md","id":25414121,"avatar_url":"https://avatars1.githubusercontent.com/u/25414121?v=4","gravatar_id":"","url":"https://api.github.com/users/gabru-md","html_url":"https://github.com/gabru-md","followers_url":"https://api.github.com/users/gabru-md/followers","following_url":"https://api.github.com/users/gabru-md/following{/other_user}","gists_url":"https://api.github.com/users/gabru-md/gists{/gist_id}","starred_url":"https://api.github.com/users/gabru-md/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabru-md/subscriptions","organizations_url":"https://api.github.com/users/gabru-md/orgs","repos_url":"https://api.github.com/users/gabru-md/repos","events_url":"https://api.github.com/users/gabru-md/events{/privacy}","received_events_url":"https://api.github.com/users/gabru-md/received_events","type":"User","site_admin":false},"body":"Changed an elif to if so that if a predefined image is used the the CSV is also checked for.\r\nThe error was caused because of the fact that elif was not executed if the if of image was encountered.\r\nI've managed it and fixed the bug. There were several other bugs as well that I've fixed so as to implement proper functionality.\r\nAll the changes can be found in the commit section on thie PR\r\n\r\nFixes : https://github.com/fossasia/badgeyay/issues/314\r\n\r\n\r\n#### Checklist\r\n\r\n- [x] I have read the [Contribution & Best practices Guide](https://blog.fossasia.org/open-source-developer-guide-and-best-practices-at-fossasia) and my PR follows them.\r\n- [x] My branch is up-to-date with the Upstream `development` branch.\r\n- [ ] I have added necessary documentation (if appropriate)\r\n\r\n#### Changes proposed in this pull request:\r\n\r\nFew changes but critical ones.\r\n\r\n\r\n","created_at":"2017-11-04T12:20:06Z","updated_at":"2017-11-05T09:51:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3ec0e38b0927e043c26dacec811a7798b2fbbdb4","assignee":{"login":"gabru-md","id":25414121,"avatar_url":"https://avatars1.githubusercontent.com/u/25414121?v=4","gravatar_id":"","url":"https://api.github.com/users/gabru-md","html_url":"https://github.com/gabru-md","followers_url":"https://api.github.com/users/gabru-md/followers","following_url":"https://api.github.com/users/gabru-md/following{/other_user}","gists_url":"https://api.github.com/users/gabru-md/gists{/gist_id}","starred_url":"https://api.github.com/users/gabru-md/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabru-md/subscriptions","organizations_url":"https://api.github.com/users/gabru-md/orgs","repos_url":"https://api.github.com/users/gabru-md/repos","events_url":"https://api.github.com/users/gabru-md/events{/privacy}","received_events_url":"https://api.github.com/users/gabru-md/received_events","type":"User","site_admin":false},"assignees":[{"login":"gabru-md","id":25414121,"avatar_url":"https://avatars1.githubusercontent.com/u/25414121?v=4","gravatar_id":"","url":"https://api.github.com/users/gabru-md","html_url":"https://github.com/gabru-md","followers_url":"https://api.github.com/users/gabru-md/followers","following_url":"https://api.github.com/users/gabru-md/following{/other_user}","gists_url":"https://api.github.com/users/gabru-md/gists{/gist_id}","starred_url":"https://api.github.com/users/gabru-md/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabru-md/subscriptions","organizations_url":"https://api.github.com/users/gabru-md/orgs","repos_url":"https://api.github.com/users/gabru-md/repos","events_url":"https://api.github.com/users/gabru-md/events{/privacy}","received_events_url":"https://api.github.com/users/gabru-md/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/fossasia/badgeyay/pulls/316/commits","review_comments_url":"https://api.github.com/repos/fossasia/badgeyay/pulls/316/comments","review_comment_url":"https://api.github.com/repos/fossasia/badgeyay/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fossasia/badgeyay/issues/316/comments","statuses_url":"https://api.github.com/repos/fossasia/badgeyay/statuses/1958247b9294fbef2c1fe3dca8b533e0fb71ca41","head":{"label":"gabru-md:development","ref":"development","sha":"1958247b9294fbef2c1fe3dca8b533e0fb71ca41","user":{"login":"gabru-md","id":25414121,"avatar_url":"https://avatars1.githubusercontent.com/u/25414121?v=4","gravatar_id":"","url":"https://api.github.com/users/gabru-md","html_url":"https://github.com/gabru-md","followers_url":"https://api.github.com/users/gabru-md/followers","following_url":"https://api.github.com/users/gabru-md/following{/other_user}","gists_url":"https://api.github.com/users/gabru-md/gists{/gist_id}","starred_url":"https://api.github.com/users/gabru-md/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabru-md/subscriptions","organizations_url":"https://api.github.com/users/gabru-md/orgs","repos_url":"https://api.github.com/users/gabru-md/repos","events_url":"https://api.github.com/users/gabru-md/events{/privacy}","received_events_url":"https://api.github.com/users/gabru-md/received_events","type":"User","site_admin":false},"repo":{"id":103983022,"name":"badgeyay","full_name":"gabru-md/badgeyay","owner":{"login":"gabru-md","id":25414121,"avatar_url":"https://avatars1.githubusercontent.com/u/25414121?v=4","gravatar_id":"","url":"https://api.github.com/users/gabru-md","html_url":"https://github.com/gabru-md","followers_url":"https://api.github.com/users/gabru-md/followers","following_url":"https://api.github.com/users/gabru-md/following{/other_user}","gists_url":"https://api.github.com/users/gabru-md/gists{/gist_id}","starred_url":"https://api.github.com/users/gabru-md/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabru-md/subscriptions","organizations_url":"https://api.github.com/users/gabru-md/orgs","repos_url":"https://api.github.com/users/gabru-md/repos","events_url":"https://api.github.com/users/gabru-md/events{/privacy}","received_events_url":"https://api.github.com/users/gabru-md/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gabru-md/badgeyay","description":"Visitor Badge Generator for Conferences https://badgeyay-dev.herokuapp.com","fork":true,"url":"https://api.github.com/repos/gabru-md/badgeyay","forks_url":"https://api.github.com/repos/gabru-md/badgeyay/forks","keys_url":"https://api.github.com/repos/gabru-md/badgeyay/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gabru-md/badgeyay/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gabru-md/badgeyay/teams","hooks_url":"https://api.github.com/repos/gabru-md/badgeyay/hooks","issue_events_url":"https://api.github.com/repos/gabru-md/badgeyay/issues/events{/number}","events_url":"https://api.github.com/repos/gabru-md/badgeyay/events","assignees_url":"https://api.github.com/repos/gabru-md/badgeyay/assignees{/user}","branches_url":"https://api.github.com/repos/gabru-md/badgeyay/branches{/branch}","tags_url":"https://api.github.com/repos/gabru-md/badgeyay/tags","blobs_url":"https://api.github.com/repos/gabru-md/badgeyay/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gabru-md/badgeyay/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gabru-md/badgeyay/git/refs{/sha}","trees_url":"https://api.github.com/repos/gabru-md/badgeyay/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gabru-md/badgeyay/statuses/{sha}","languages_url":"https://api.github.com/repos/gabru-md/badgeyay/languages","stargazers_url":"https://api.github.com/repos/gabru-md/badgeyay/stargazers","contributors_url":"https://api.github.com/repos/gabru-md/badgeyay/contributors","subscribers_url":"https://api.github.com/repos/gabru-md/badgeyay/subscribers","subscription_url":"https://api.github.com/repos/gabru-md/badgeyay/subscription","commits_url":"https://api.github.com/repos/gabru-md/badgeyay/commits{/sha}","git_commits_url":"https://api.github.com/repos/gabru-md/badgeyay/git/commits{/sha}","comments_url":"https://api.github.com/repos/gabru-md/badgeyay/comments{/number}","issue_comment_url":"https://api.github.com/repos/gabru-md/badgeyay/issues/comments{/number}","contents_url":"https://api.github.com/repos/gabru-md/badgeyay/contents/{+path}","compare_url":"https://api.github.com/repos/gabru-md/badgeyay/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gabru-md/badgeyay/merges","archive_url":"https://api.github.com/repos/gabru-md/badgeyay/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gabru-md/badgeyay/downloads","issues_url":"https://api.github.com/repos/gabru-md/badgeyay/issues{/number}","pulls_url":"https://api.github.com/repos/gabru-md/badgeyay/pulls{/number}","milestones_url":"https://api.github.com/repos/gabru-md/badgeyay/milestones{/number}","notifications_url":"https://api.github.com/repos/gabru-md/badgeyay/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gabru-md/badgeyay/labels{/name}","releases_url":"https://api.github.com/repos/gabru-md/badgeyay/releases{/id}","deployments_url":"https://api.github.com/repos/gabru-md/badgeyay/deployments","created_at":"2017-09-18T19:33:54Z","updated_at":"2017-09-18T19:33:55Z","pushed_at":"2017-11-05T05:54:14Z","git_url":"git://github.com/gabru-md/badgeyay.git","ssh_url":"git@github.com:gabru-md/badgeyay.git","clone_url":"https://github.com/gabru-md/badgeyay.git","svn_url":"https://github.com/gabru-md/badgeyay","homepage":"","size":30166,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"development"}},"base":{"label":"fossasia:development","ref":"development","sha":"1da2578dad04f6abba24460c0bd28903d93ed8f1","user":{"login":"fossasia","id":6295529,"avatar_url":"https://avatars3.githubusercontent.com/u/6295529?v=4","gravatar_id":"","url":"https://api.github.com/users/fossasia","html_url":"https://github.com/fossasia","followers_url":"https://api.github.com/users/fossasia/followers","following_url":"https://api.github.com/users/fossasia/following{/other_user}","gists_url":"https://api.github.com/users/fossasia/gists{/gist_id}","starred_url":"https://api.github.com/users/fossasia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fossasia/subscriptions","organizations_url":"https://api.github.com/users/fossasia/orgs","repos_url":"https://api.github.com/users/fossasia/repos","events_url":"https://api.github.com/users/fossasia/events{/privacy}","received_events_url":"https://api.github.com/users/fossasia/received_events","type":"Organization","site_admin":false},"repo":{"id":93319175,"name":"badgeyay","full_name":"fossasia/badgeyay","owner":{"login":"fossasia","id":6295529,"avatar_url":"https://avatars3.githubusercontent.com/u/6295529?v=4","gravatar_id":"","url":"https://api.github.com/users/fossasia","html_url":"https://github.com/fossasia","followers_url":"https://api.github.com/users/fossasia/followers","following_url":"https://api.github.com/users/fossasia/following{/other_user}","gists_url":"https://api.github.com/users/fossasia/gists{/gist_id}","starred_url":"https://api.github.com/users/fossasia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fossasia/subscriptions","organizations_url":"https://api.github.com/users/fossasia/orgs","repos_url":"https://api.github.com/users/fossasia/repos","events_url":"https://api.github.com/users/fossasia/events{/privacy}","received_events_url":"https://api.github.com/users/fossasia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fossasia/badgeyay","description":"Visitor Badge Generator for Conferences https://badgeyay-dev.herokuapp.com","fork":false,"url":"https://api.github.com/repos/fossasia/badgeyay","forks_url":"https://api.github.com/repos/fossasia/badgeyay/forks","keys_url":"https://api.github.com/repos/fossasia/badgeyay/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fossasia/badgeyay/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fossasia/badgeyay/teams","hooks_url":"https://api.github.com/repos/fossasia/badgeyay/hooks","issue_events_url":"https://api.github.com/repos/fossasia/badgeyay/issues/events{/number}","events_url":"https://api.github.com/repos/fossasia/badgeyay/events","assignees_url":"https://api.github.com/repos/fossasia/badgeyay/assignees{/user}","branches_url":"https://api.github.com/repos/fossasia/badgeyay/branches{/branch}","tags_url":"https://api.github.com/repos/fossasia/badgeyay/tags","blobs_url":"https://api.github.com/repos/fossasia/badgeyay/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fossasia/badgeyay/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fossasia/badgeyay/git/refs{/sha}","trees_url":"https://api.github.com/repos/fossasia/badgeyay/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fossasia/badgeyay/statuses/{sha}","languages_url":"https://api.github.com/repos/fossasia/badgeyay/languages","stargazers_url":"https://api.github.com/repos/fossasia/badgeyay/stargazers","contributors_url":"https://api.github.com/repos/fossasia/badgeyay/contributors","subscribers_url":"https://api.github.com/repos/fossasia/badgeyay/subscribers","subscription_url":"https://api.github.com/repos/fossasia/badgeyay/subscription","commits_url":"https://api.github.com/repos/fossasia/badgeyay/commits{/sha}","git_commits_url":"https://api.github.com/repos/fossasia/badgeyay/git/commits{/sha}","comments_url":"https://api.github.com/repos/fossasia/badgeyay/comments{/number}","issue_comment_url":"https://api.github.com/repos/fossasia/badgeyay/issues/comments{/number}","contents_url":"https://api.github.com/repos/fossasia/badgeyay/contents/{+path}","compare_url":"https://api.github.com/repos/fossasia/badgeyay/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fossasia/badgeyay/merges","archive_url":"https://api.github.com/repos/fossasia/badgeyay/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fossasia/badgeyay/downloads","issues_url":"https://api.github.com/repos/fossasia/badgeyay/issues{/number}","pulls_url":"https://api.github.com/repos/fossasia/badgeyay/pulls{/number}","milestones_url":"https://api.github.com/repos/fossasia/badgeyay/milestones{/number}","notifications_url":"https://api.github.com/repos/fossasia/badgeyay/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fossasia/badgeyay/labels{/name}","releases_url":"https://api.github.com/repos/fossasia/badgeyay/releases{/id}","deployments_url":"https://api.github.com/repos/fossasia/badgeyay/deployments","created_at":"2017-06-04T14:32:49Z","updated_at":"2017-11-01T21:55:34Z","pushed_at":"2017-11-05T09:15:55Z","git_url":"git://github.com/fossasia/badgeyay.git","ssh_url":"git@github.com:fossasia/badgeyay.git","clone_url":"https://github.com/fossasia/badgeyay.git","svn_url":"https://github.com/fossasia/badgeyay","homepage":"","size":30163,"stargazers_count":78,"watchers_count":78,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":100,"mirror_url":null,"archived":false,"open_issues_count":29,"forks":100,"open_issues":29,"watchers":78,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/fossasia/badgeyay/pulls/316"},"html":{"href":"https://github.com/fossasia/badgeyay/pull/316"},"issue":{"href":"https://api.github.com/repos/fossasia/badgeyay/issues/316"},"comments":{"href":"https://api.github.com/repos/fossasia/badgeyay/issues/316/comments"},"review_comments":{"href":"https://api.github.com/repos/fossasia/badgeyay/pulls/316/comments"},"review_comment":{"href":"https://api.github.com/repos/fossasia/badgeyay/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fossasia/badgeyay/pulls/316/commits"},"statuses":{"href":"https://api.github.com/repos/fossasia/badgeyay/statuses/1958247b9294fbef2c1fe3dca8b533e0fb71ca41"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jajodiaraghav"}}