{"push_id":2020729646,"size":3,"distinct_size":1,"ref":"refs/heads/commitfest/15/1303","head":"8e2032d43658a129f898cd321dd988dd88990358","before":"bc335919bbe43a17383d8d5c1a445c1df175343b","commits":[{"sha":"c12d570fa147d0ec273df53de3a2802925d551ba","author":{"name":"Tom Lane","email":"9ca635a44fdf5aa326758d8d245579b9ae84653c@sss.pgh.pa.us"},"message":"Support arrays over domains.\n\nAllowing arrays with a domain type as their element type was left un-done\nin the original domain patch, but not for any very good reason.  This\nomission leads to such surprising results as array_agg() not working on\na domain column, because the parser can't identify a suitable output type\nfor the polymorphic aggregate.\n\nIn order to fix this, first clean up the APIs of coerce_to_domain() and\nsome internal functions in parse_coerce.c so that we consistently pass\naround a CoercionContext along with CoercionForm.  Previously, we sometimes\npassed an \"isExplicit\" boolean flag instead, which is strictly less\ninformation; and coerce_to_domain() didn't even get that, but instead had\nto reverse-engineer isExplicit from CoercionForm.  That's contrary to the\ndocumentation in primnodes.h that says that CoercionForm only affects\ndisplay and not semantics.  I don't think this change fixes any live bugs,\nbut it makes things more consistent.  The main reason for doing it though\nis that now build_coercion_expression() receives ccontext, which it needs\nin order to be able to recursively invoke coerce_to_target_type().\n\nNext, reimplement ArrayCoerceExpr so that the node does not directly know\nany details of what has to be done to the individual array elements while\nperforming the array coercion.  Instead, the per-element processing is\nrepresented by a sub-expression whose input is a source array element and\nwhose output is a target array element.  This simplifies life in\nparse_coerce.c, because it can build that sub-expression by a recursive\ninvocation of coerce_to_target_type().  The executor now handles the\nper-element processing as a compiled expression instead of hard-wired code.\nThe main advantage of this is that we can use a single ArrayCoerceExpr to\nhandle as many as three successive steps per element: base type conversion,\ntypmod coercion, and domain constraint checking.  The old code used two\nstacked ArrayCoerceExprs to handle type + typmod coercion, which was pretty\ninefficient, and adding yet another array deconstruction to do domain\nconstraint checking seemed very unappetizing.\n\nIn the case where we just need a single, very simple coercion function,\ndoing this straightforwardly leads to a noticeable increase in the\nper-array-element runtime cost.  Hence, add an additional shortcut evalfunc\nin execExprInterp.c that skips unnecessary overhead for that specific form\nof expression.  The runtime speed of simple cases is within 1% or so of\nwhere it was before, while cases that previously required two levels of\narray processing are significantly faster.\n\nFinally, create an implicit array type for every domain type, as we do for\nbase types, enums, etc.  Everything except the array-coercion case seems\nto just work without further effort.\n\nTom Lane, reviewed by Andrew Dunstan\n\nDiscussion: https://postgr.es/m/9852.1499791473@sss.pgh.pa.us","distinct":false,"url":"https://api.github.com/repos/postgresql-cfbot/postgresql/commits/c12d570fa147d0ec273df53de3a2802925d551ba"},{"sha":"2632bcce5e767a2b5901bbef54ae52df061eee72","author":{"name":"Tom Lane","email":"9ca635a44fdf5aa326758d8d245579b9ae84653c@sss.pgh.pa.us"},"message":"Fix pg_dump to assign domain array type OIDs during pg_upgrade.\n\nDuring a binary upgrade, all type OIDs are supposed to be assigned by\npg_dump based on their values in the old cluster.  But now that domains\nhave arrays, there's nothing to base the arrays' type OIDs on, if we're\nupgrading from a pre-v11 cluster.  Make pg_dump search for an unused type\nOID to use for this purpose.  Per buildfarm.\n\nDiscussion: https://postgr.es/m/E1dyLlE-0002gT-H5@gemulon.postgresql.org","distinct":false,"url":"https://api.github.com/repos/postgresql-cfbot/postgresql/commits/2632bcce5e767a2b5901bbef54ae52df061eee72"},{"sha":"8e2032d43658a129f898cd321dd988dd88990358","author":{"name":"Commitfest Bot","email":"aab6a594935fe5db0d690bc154b19f642bfbe9d7@cputube.org"},"message":"[CF 15/1303] Regression tests for V2 protocol.\n\nThis commit was automatically generated by cfbot at commitfest.cputube.org.\nIt is based on patches submitted to the PostgreSQL mailing lists and\nregistered in the PostgreSQL Commitfest application.\n\nThis branch will be overwritten each time a new patch version is posted to\nthe email thread or the master branch changes.\n\nCommitfest entry: https://commitfest.postgresql.org/15/1303\nPatch(es): https://www.postgresql.org/message-id/20170920083236.jaoxrffd2bykwftd%40alap3.anarazel.de\nAuthor(s): Andres Freund","distinct":true,"url":"https://api.github.com/repos/postgresql-cfbot/postgresql/commits/8e2032d43658a129f898cd321dd988dd88990358"}]}
{"actor":{"display_login":"postgresql-cfbot"}}