{"action":"created","comment":{"url":"https://api.github.com/repos/projectcalico/libcalico-go/pulls/comments/144460413","pull_request_review_id":69120014,"id":144460413,"diff_hunk":"@@ -0,0 +1,461 @@\n+// Copyright (c) 2017 Tigera, Inc. All rights reserved.","path":"lib/backend/k8sv2/resources/customnoderesource.go","position":1,"original_position":1,"commit_id":"8b6cf5e781ae515167222fb91218951fa800bbbc","original_commit_id":"8b6cf5e781ae515167222fb91218951fa800bbbc","user":{"login":"robbrockbank","id":3227729,"avatar_url":"https://avatars0.githubusercontent.com/u/3227729?v=4","gravatar_id":"","url":"https://api.github.com/users/robbrockbank","html_url":"https://github.com/robbrockbank","followers_url":"https://api.github.com/users/robbrockbank/followers","following_url":"https://api.github.com/users/robbrockbank/following{/other_user}","gists_url":"https://api.github.com/users/robbrockbank/gists{/gist_id}","starred_url":"https://api.github.com/users/robbrockbank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robbrockbank/subscriptions","organizations_url":"https://api.github.com/users/robbrockbank/orgs","repos_url":"https://api.github.com/users/robbrockbank/repos","events_url":"https://api.github.com/users/robbrockbank/events{/privacy}","received_events_url":"https://api.github.com/users/robbrockbank/received_events","type":"User","site_admin":false},"body":"Does anything use this anymore?\r\n\r\nI believe this isn't required now we have FelixConfiguration, BGConfiguration, BGPPeer and ClusterInformation being standard CRDs.","created_at":"2017-10-13T03:45:39Z","updated_at":"2017-10-13T03:45:39Z","html_url":"https://github.com/projectcalico/libcalico-go/pull/564#discussion_r144460413","pull_request_url":"https://api.github.com/repos/projectcalico/libcalico-go/pulls/564","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/projectcalico/libcalico-go/pulls/comments/144460413"},"html":{"href":"https://github.com/projectcalico/libcalico-go/pull/564#discussion_r144460413"},"pull_request":{"href":"https://api.github.com/repos/projectcalico/libcalico-go/pulls/564"}}},"pull_request":{"url":"https://api.github.com/repos/projectcalico/libcalico-go/pulls/564","id":145832862,"html_url":"https://github.com/projectcalico/libcalico-go/pull/564","diff_url":"https://github.com/projectcalico/libcalico-go/pull/564.diff","patch_url":"https://github.com/projectcalico/libcalico-go/pull/564.patch","issue_url":"https://api.github.com/repos/projectcalico/libcalico-go/issues/564","number":564,"state":"open","locked":false,"title":"Support CRUD for v2 client when using KDD backend","user":{"login":"doublek","id":330397,"avatar_url":"https://avatars0.githubusercontent.com/u/330397?v=4","gravatar_id":"","url":"https://api.github.com/users/doublek","html_url":"https://github.com/doublek","followers_url":"https://api.github.com/users/doublek/followers","following_url":"https://api.github.com/users/doublek/following{/other_user}","gists_url":"https://api.github.com/users/doublek/gists{/gist_id}","starred_url":"https://api.github.com/users/doublek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doublek/subscriptions","organizations_url":"https://api.github.com/users/doublek/orgs","repos_url":"https://api.github.com/users/doublek/repos","events_url":"https://api.github.com/users/doublek/events{/privacy}","received_events_url":"https://api.github.com/users/doublek/received_events","type":"User","site_admin":false},"body":"## Description\r\n@robbrockbank, I've created a new directory called k8sv2 and put all the v2 data model relevant code there. Ideally I wanted to remove k8s and have the k8sv2 folder take its place.\r\n\r\nLet me know if there is a way in which you'd like me to move code around to make it better for reviewing.\r\n\r\nIn addition to supporting existing items using v2 data model, compared to the the k8s backend for v1 datamodel, the k8s backend for v2 has the following modifications:\r\n\r\nRenamed CRDs:\r\n- `GlobalBGPConfig` -> `BGPConfig`\r\n- `GlobalFelixConfig` -> `FelixConfig`\r\n\r\nCRDs that stay the same:\r\n\r\n- `BGPPeers` - The resource file is now named `bgppeers.go` instead of `globalbgppeers.go`.\r\n- `GlobalNetworkPolicy`.\r\n- `IPPool`\r\n\r\nNewly created/supported CRDs:\r\n- `ClusterInfo`\r\n\r\n\r\nI haven't updated the syncer yet and is a copy of the v1 datamodel k8s backend implementation.\r\n\r\n## Todos\r\n- [ ] Tests\r\n- [ ] Documentation","created_at":"2017-10-11T00:39:51Z","updated_at":"2017-10-13T03:45:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ff35ae0e8e3c8e72babe06a1fcafc40170defe5f","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/projectcalico/libcalico-go/pulls/564/commits","review_comments_url":"https://api.github.com/repos/projectcalico/libcalico-go/pulls/564/comments","review_comment_url":"https://api.github.com/repos/projectcalico/libcalico-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/projectcalico/libcalico-go/issues/564/comments","statuses_url":"https://api.github.com/repos/projectcalico/libcalico-go/statuses/8b6cf5e781ae515167222fb91218951fa800bbbc","head":{"label":"doublek:v3.0-kdd-client-crud","ref":"v3.0-kdd-client-crud","sha":"8b6cf5e781ae515167222fb91218951fa800bbbc","user":{"login":"doublek","id":330397,"avatar_url":"https://avatars0.githubusercontent.com/u/330397?v=4","gravatar_id":"","url":"https://api.github.com/users/doublek","html_url":"https://github.com/doublek","followers_url":"https://api.github.com/users/doublek/followers","following_url":"https://api.github.com/users/doublek/following{/other_user}","gists_url":"https://api.github.com/users/doublek/gists{/gist_id}","starred_url":"https://api.github.com/users/doublek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doublek/subscriptions","organizations_url":"https://api.github.com/users/doublek/orgs","repos_url":"https://api.github.com/users/doublek/repos","events_url":"https://api.github.com/users/doublek/events{/privacy}","received_events_url":"https://api.github.com/users/doublek/received_events","type":"User","site_admin":false},"repo":{"id":103982704,"name":"libcalico-go","full_name":"doublek/libcalico-go","owner":{"login":"doublek","id":330397,"avatar_url":"https://avatars0.githubusercontent.com/u/330397?v=4","gravatar_id":"","url":"https://api.github.com/users/doublek","html_url":"https://github.com/doublek","followers_url":"https://api.github.com/users/doublek/followers","following_url":"https://api.github.com/users/doublek/following{/other_user}","gists_url":"https://api.github.com/users/doublek/gists{/gist_id}","starred_url":"https://api.github.com/users/doublek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doublek/subscriptions","organizations_url":"https://api.github.com/users/doublek/orgs","repos_url":"https://api.github.com/users/doublek/repos","events_url":"https://api.github.com/users/doublek/events{/privacy}","received_events_url":"https://api.github.com/users/doublek/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/doublek/libcalico-go","description":"Golang Calico library functions:  https://www.projectcalico.org","fork":true,"url":"https://api.github.com/repos/doublek/libcalico-go","forks_url":"https://api.github.com/repos/doublek/libcalico-go/forks","keys_url":"https://api.github.com/repos/doublek/libcalico-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/doublek/libcalico-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/doublek/libcalico-go/teams","hooks_url":"https://api.github.com/repos/doublek/libcalico-go/hooks","issue_events_url":"https://api.github.com/repos/doublek/libcalico-go/issues/events{/number}","events_url":"https://api.github.com/repos/doublek/libcalico-go/events","assignees_url":"https://api.github.com/repos/doublek/libcalico-go/assignees{/user}","branches_url":"https://api.github.com/repos/doublek/libcalico-go/branches{/branch}","tags_url":"https://api.github.com/repos/doublek/libcalico-go/tags","blobs_url":"https://api.github.com/repos/doublek/libcalico-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/doublek/libcalico-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/doublek/libcalico-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/doublek/libcalico-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/doublek/libcalico-go/statuses/{sha}","languages_url":"https://api.github.com/repos/doublek/libcalico-go/languages","stargazers_url":"https://api.github.com/repos/doublek/libcalico-go/stargazers","contributors_url":"https://api.github.com/repos/doublek/libcalico-go/contributors","subscribers_url":"https://api.github.com/repos/doublek/libcalico-go/subscribers","subscription_url":"https://api.github.com/repos/doublek/libcalico-go/subscription","commits_url":"https://api.github.com/repos/doublek/libcalico-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/doublek/libcalico-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/doublek/libcalico-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/doublek/libcalico-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/doublek/libcalico-go/contents/{+path}","compare_url":"https://api.github.com/repos/doublek/libcalico-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/doublek/libcalico-go/merges","archive_url":"https://api.github.com/repos/doublek/libcalico-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/doublek/libcalico-go/downloads","issues_url":"https://api.github.com/repos/doublek/libcalico-go/issues{/number}","pulls_url":"https://api.github.com/repos/doublek/libcalico-go/pulls{/number}","milestones_url":"https://api.github.com/repos/doublek/libcalico-go/milestones{/number}","notifications_url":"https://api.github.com/repos/doublek/libcalico-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/doublek/libcalico-go/labels{/name}","releases_url":"https://api.github.com/repos/doublek/libcalico-go/releases{/id}","deployments_url":"https://api.github.com/repos/doublek/libcalico-go/deployments","created_at":"2017-09-18T19:31:02Z","updated_at":"2017-09-18T19:31:04Z","pushed_at":"2017-10-12T19:58:00Z","git_url":"git://github.com/doublek/libcalico-go.git","ssh_url":"git@github.com:doublek/libcalico-go.git","clone_url":"https://github.com/doublek/libcalico-go.git","svn_url":"https://github.com/doublek/libcalico-go","homepage":null,"size":1838,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"projectcalico:v3.0-integration","ref":"v3.0-integration","sha":"d85e5fe048c4e87e869e382d2d42807532c1950d","user":{"login":"projectcalico","id":12304728,"avatar_url":"https://avatars3.githubusercontent.com/u/12304728?v=4","gravatar_id":"","url":"https://api.github.com/users/projectcalico","html_url":"https://github.com/projectcalico","followers_url":"https://api.github.com/users/projectcalico/followers","following_url":"https://api.github.com/users/projectcalico/following{/other_user}","gists_url":"https://api.github.com/users/projectcalico/gists{/gist_id}","starred_url":"https://api.github.com/users/projectcalico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectcalico/subscriptions","organizations_url":"https://api.github.com/users/projectcalico/orgs","repos_url":"https://api.github.com/users/projectcalico/repos","events_url":"https://api.github.com/users/projectcalico/events{/privacy}","received_events_url":"https://api.github.com/users/projectcalico/received_events","type":"Organization","site_admin":false},"repo":{"id":63438319,"name":"libcalico-go","full_name":"projectcalico/libcalico-go","owner":{"login":"projectcalico","id":12304728,"avatar_url":"https://avatars3.githubusercontent.com/u/12304728?v=4","gravatar_id":"","url":"https://api.github.com/users/projectcalico","html_url":"https://github.com/projectcalico","followers_url":"https://api.github.com/users/projectcalico/followers","following_url":"https://api.github.com/users/projectcalico/following{/other_user}","gists_url":"https://api.github.com/users/projectcalico/gists{/gist_id}","starred_url":"https://api.github.com/users/projectcalico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectcalico/subscriptions","organizations_url":"https://api.github.com/users/projectcalico/orgs","repos_url":"https://api.github.com/users/projectcalico/repos","events_url":"https://api.github.com/users/projectcalico/events{/privacy}","received_events_url":"https://api.github.com/users/projectcalico/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/projectcalico/libcalico-go","description":"Golang Calico library functions:  https://www.projectcalico.org","fork":false,"url":"https://api.github.com/repos/projectcalico/libcalico-go","forks_url":"https://api.github.com/repos/projectcalico/libcalico-go/forks","keys_url":"https://api.github.com/repos/projectcalico/libcalico-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/projectcalico/libcalico-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/projectcalico/libcalico-go/teams","hooks_url":"https://api.github.com/repos/projectcalico/libcalico-go/hooks","issue_events_url":"https://api.github.com/repos/projectcalico/libcalico-go/issues/events{/number}","events_url":"https://api.github.com/repos/projectcalico/libcalico-go/events","assignees_url":"https://api.github.com/repos/projectcalico/libcalico-go/assignees{/user}","branches_url":"https://api.github.com/repos/projectcalico/libcalico-go/branches{/branch}","tags_url":"https://api.github.com/repos/projectcalico/libcalico-go/tags","blobs_url":"https://api.github.com/repos/projectcalico/libcalico-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/projectcalico/libcalico-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/projectcalico/libcalico-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/projectcalico/libcalico-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/projectcalico/libcalico-go/statuses/{sha}","languages_url":"https://api.github.com/repos/projectcalico/libcalico-go/languages","stargazers_url":"https://api.github.com/repos/projectcalico/libcalico-go/stargazers","contributors_url":"https://api.github.com/repos/projectcalico/libcalico-go/contributors","subscribers_url":"https://api.github.com/repos/projectcalico/libcalico-go/subscribers","subscription_url":"https://api.github.com/repos/projectcalico/libcalico-go/subscription","commits_url":"https://api.github.com/repos/projectcalico/libcalico-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/projectcalico/libcalico-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/projectcalico/libcalico-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/projectcalico/libcalico-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/projectcalico/libcalico-go/contents/{+path}","compare_url":"https://api.github.com/repos/projectcalico/libcalico-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/projectcalico/libcalico-go/merges","archive_url":"https://api.github.com/repos/projectcalico/libcalico-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/projectcalico/libcalico-go/downloads","issues_url":"https://api.github.com/repos/projectcalico/libcalico-go/issues{/number}","pulls_url":"https://api.github.com/repos/projectcalico/libcalico-go/pulls{/number}","milestones_url":"https://api.github.com/repos/projectcalico/libcalico-go/milestones{/number}","notifications_url":"https://api.github.com/repos/projectcalico/libcalico-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/projectcalico/libcalico-go/labels{/name}","releases_url":"https://api.github.com/repos/projectcalico/libcalico-go/releases{/id}","deployments_url":"https://api.github.com/repos/projectcalico/libcalico-go/deployments","created_at":"2016-07-15T17:09:40Z","updated_at":"2017-10-10T16:13:08Z","pushed_at":"2017-10-13T01:27:23Z","git_url":"git://github.com/projectcalico/libcalico-go.git","ssh_url":"git@github.com:projectcalico/libcalico-go.git","clone_url":"https://github.com/projectcalico/libcalico-go.git","svn_url":"https://github.com/projectcalico/libcalico-go","homepage":null,"size":1828,"stargazers_count":39,"watchers_count":39,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":47,"mirror_url":null,"open_issues_count":26,"forks":47,"open_issues":26,"watchers":39,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/projectcalico/libcalico-go/pulls/564"},"html":{"href":"https://github.com/projectcalico/libcalico-go/pull/564"},"issue":{"href":"https://api.github.com/repos/projectcalico/libcalico-go/issues/564"},"comments":{"href":"https://api.github.com/repos/projectcalico/libcalico-go/issues/564/comments"},"review_comments":{"href":"https://api.github.com/repos/projectcalico/libcalico-go/pulls/564/comments"},"review_comment":{"href":"https://api.github.com/repos/projectcalico/libcalico-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/projectcalico/libcalico-go/pulls/564/commits"},"statuses":{"href":"https://api.github.com/repos/projectcalico/libcalico-go/statuses/8b6cf5e781ae515167222fb91218951fa800bbbc"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"robbrockbank"}}