{"action":"created","comment":{"url":"https://api.github.com/repos/VIISON/shopware/pulls/comments/147760933","pull_request_review_id":72902206,"id":147760933,"diff_hunk":"@@ -5357,11 +5357,11 @@ INSERT INTO `s_core_detail_states` (`id`, `description`, `position`, `mail`) VAL\n (3, 'Abgeschlossen', 4, 0);\n \n TRUNCATE TABLE `s_core_documents`;\n-INSERT INTO `s_core_documents` (`id`, `name`, `template`, `numbers`, `left`, `right`, `top`, `bottom`, `pagebreak`) VALUES\n-(1, 'Rechnung', 'index.tpl', 'doc_0', 25, 10, 20, 20, 10),\n-(2, 'Lieferschein', 'index_ls.tpl', 'doc_1', 25, 10, 20, 20, 10),\n-(3, 'Gutschrift', 'index_gs.tpl', 'doc_2', 25, 10, 20, 20, 10),\n-(4, 'Stornorechnung', 'index_sr.tpl', 'doc_3', 25, 10, 20, 20, 10);\n+INSERT INTO `s_core_documents` (`id`, `name`, `identifier`, `template`, `numbers`, `left`, `right`, `top`, `bottom`, `pagebreak`) VALUES\n+(1, 'Rechnung', 'invoice', 'index.tpl', 'doc_0', 25, 10, 20, 20, 10),\n+(2, 'Lieferschein', 'note of delivery', 'index_ls.tpl', 'doc_1', 25, 10, 20, 20, 10),","path":"_sql/demo/latest.sql","position":11,"original_position":11,"commit_id":"d45d32fb788c7cf1dbafc139727a7b299de11ff0","original_commit_id":"d45d32fb788c7cf1dbafc139727a7b299de11ff0","user":{"login":"niklasbuechner","id":31041526,"avatar_url":"https://avatars2.githubusercontent.com/u/31041526?v=4","gravatar_id":"","url":"https://api.github.com/users/niklasbuechner","html_url":"https://github.com/niklasbuechner","followers_url":"https://api.github.com/users/niklasbuechner/followers","following_url":"https://api.github.com/users/niklasbuechner/following{/other_user}","gists_url":"https://api.github.com/users/niklasbuechner/gists{/gist_id}","starred_url":"https://api.github.com/users/niklasbuechner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niklasbuechner/subscriptions","organizations_url":"https://api.github.com/users/niklasbuechner/orgs","repos_url":"https://api.github.com/users/niklasbuechner/repos","events_url":"https://api.github.com/users/niklasbuechner/events{/privacy}","received_events_url":"https://api.github.com/users/niklasbuechner/received_events","type":"User","site_admin":false},"body":"The translation was copied directly from the Shopware's translations. (See migration 912 line 74).","created_at":"2017-10-30T16:37:54Z","updated_at":"2017-10-30T16:37:54Z","html_url":"https://github.com/VIISON/shopware/pull/50#discussion_r147760933","pull_request_url":"https://api.github.com/repos/VIISON/shopware/pulls/50","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/VIISON/shopware/pulls/comments/147760933"},"html":{"href":"https://github.com/VIISON/shopware/pull/50#discussion_r147760933"},"pull_request":{"href":"https://api.github.com/repos/VIISON/shopware/pulls/50"}},"in_reply_to_id":145352602},"pull_request":{"url":"https://api.github.com/repos/VIISON/shopware/pulls/50","id":147085388,"html_url":"https://github.com/VIISON/shopware/pull/50","diff_url":"https://github.com/VIISON/shopware/pull/50.diff","patch_url":"https://github.com/VIISON/shopware/pull/50.patch","issue_url":"https://api.github.com/repos/VIISON/shopware/issues/50","number":50,"state":"open","locked":false,"title":"Add document type identifier","user":{"login":"niklasbuechner","id":31041526,"avatar_url":"https://avatars2.githubusercontent.com/u/31041526?v=4","gravatar_id":"","url":"https://api.github.com/users/niklasbuechner","html_url":"https://github.com/niklasbuechner","followers_url":"https://api.github.com/users/niklasbuechner/followers","following_url":"https://api.github.com/users/niklasbuechner/following{/other_user}","gists_url":"https://api.github.com/users/niklasbuechner/gists{/gist_id}","starred_url":"https://api.github.com/users/niklasbuechner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niklasbuechner/subscriptions","organizations_url":"https://api.github.com/users/niklasbuechner/orgs","repos_url":"https://api.github.com/users/niklasbuechner/repos","events_url":"https://api.github.com/users/niklasbuechner/events{/privacy}","received_events_url":"https://api.github.com/users/niklasbuechner/received_events","type":"User","site_admin":false},"body":"### 1. Why is this change necessary?\r\nWhen creating a new document type, plugin developers are depending on users not changing the name of the new document type. This, however, leads users to not being able to change the name of the document without breaking the corresponding plugin. This is cumbersome especially to international customer who have to deal with German names. In order to solve the problem, an identifier for each document type is necessary.\r\n\r\n### 2. What does this change do, exactly?\r\nThis pull request aligns the document types with the payment methods by adding the missing identifier to the document types. Furthermore, it makes sure that the new identifier can be observed as well as edited in the basic settings. Just as the payment methods.\r\n\r\n### 3. Describe each step to reproduce the issue or behaviour.\r\n1. Open the backend.\r\n2. Navigate to the \"Basic settings\".\r\n3. Choose \"PDF document creation\" from the shop's settings.\r\n\r\n### 4. Please link to the relevant issues (if any).\r\nThere are none\r\n\r\n### 5. Which documentation changes (if any) need to be made because of this PR?\r\nNone.\r\n\r\n### 6. Checklist\r\n\r\n- [ ] I have written tests and verified that they fail without my change\r\n- [x] I have squashed any insignificant commits\r\n- [x] This change has comments for package types, values, functions, and non-obvious lines of code\r\n- [x] I have read the contribution requirements and fulfil them.","created_at":"2017-10-17T16:06:38Z","updated_at":"2017-10-30T16:37:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5823d1b6ff78b289dee65a56492cfcfd8bec3560","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/VIISON/shopware/pulls/50/commits","review_comments_url":"https://api.github.com/repos/VIISON/shopware/pulls/50/comments","review_comment_url":"https://api.github.com/repos/VIISON/shopware/pulls/comments{/number}","comments_url":"https://api.github.com/repos/VIISON/shopware/issues/50/comments","statuses_url":"https://api.github.com/repos/VIISON/shopware/statuses/d45d32fb788c7cf1dbafc139727a7b299de11ff0","head":{"label":"VIISON:pickware/document-type-identifier","ref":"pickware/document-type-identifier","sha":"d45d32fb788c7cf1dbafc139727a7b299de11ff0","user":{"login":"VIISON","id":710194,"avatar_url":"https://avatars1.githubusercontent.com/u/710194?v=4","gravatar_id":"","url":"https://api.github.com/users/VIISON","html_url":"https://github.com/VIISON","followers_url":"https://api.github.com/users/VIISON/followers","following_url":"https://api.github.com/users/VIISON/following{/other_user}","gists_url":"https://api.github.com/users/VIISON/gists{/gist_id}","starred_url":"https://api.github.com/users/VIISON/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VIISON/subscriptions","organizations_url":"https://api.github.com/users/VIISON/orgs","repos_url":"https://api.github.com/users/VIISON/repos","events_url":"https://api.github.com/users/VIISON/events{/privacy}","received_events_url":"https://api.github.com/users/VIISON/received_events","type":"Organization","site_admin":false},"repo":{"id":13239451,"name":"shopware","full_name":"VIISON/shopware","owner":{"login":"VIISON","id":710194,"avatar_url":"https://avatars1.githubusercontent.com/u/710194?v=4","gravatar_id":"","url":"https://api.github.com/users/VIISON","html_url":"https://github.com/VIISON","followers_url":"https://api.github.com/users/VIISON/followers","following_url":"https://api.github.com/users/VIISON/following{/other_user}","gists_url":"https://api.github.com/users/VIISON/gists{/gist_id}","starred_url":"https://api.github.com/users/VIISON/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VIISON/subscriptions","organizations_url":"https://api.github.com/users/VIISON/orgs","repos_url":"https://api.github.com/users/VIISON/repos","events_url":"https://api.github.com/users/VIISON/events{/privacy}","received_events_url":"https://api.github.com/users/VIISON/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/VIISON/shopware","description":"Shopware Repository","fork":true,"url":"https://api.github.com/repos/VIISON/shopware","forks_url":"https://api.github.com/repos/VIISON/shopware/forks","keys_url":"https://api.github.com/repos/VIISON/shopware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VIISON/shopware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VIISON/shopware/teams","hooks_url":"https://api.github.com/repos/VIISON/shopware/hooks","issue_events_url":"https://api.github.com/repos/VIISON/shopware/issues/events{/number}","events_url":"https://api.github.com/repos/VIISON/shopware/events","assignees_url":"https://api.github.com/repos/VIISON/shopware/assignees{/user}","branches_url":"https://api.github.com/repos/VIISON/shopware/branches{/branch}","tags_url":"https://api.github.com/repos/VIISON/shopware/tags","blobs_url":"https://api.github.com/repos/VIISON/shopware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VIISON/shopware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VIISON/shopware/git/refs{/sha}","trees_url":"https://api.github.com/repos/VIISON/shopware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VIISON/shopware/statuses/{sha}","languages_url":"https://api.github.com/repos/VIISON/shopware/languages","stargazers_url":"https://api.github.com/repos/VIISON/shopware/stargazers","contributors_url":"https://api.github.com/repos/VIISON/shopware/contributors","subscribers_url":"https://api.github.com/repos/VIISON/shopware/subscribers","subscription_url":"https://api.github.com/repos/VIISON/shopware/subscription","commits_url":"https://api.github.com/repos/VIISON/shopware/commits{/sha}","git_commits_url":"https://api.github.com/repos/VIISON/shopware/git/commits{/sha}","comments_url":"https://api.github.com/repos/VIISON/shopware/comments{/number}","issue_comment_url":"https://api.github.com/repos/VIISON/shopware/issues/comments{/number}","contents_url":"https://api.github.com/repos/VIISON/shopware/contents/{+path}","compare_url":"https://api.github.com/repos/VIISON/shopware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VIISON/shopware/merges","archive_url":"https://api.github.com/repos/VIISON/shopware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VIISON/shopware/downloads","issues_url":"https://api.github.com/repos/VIISON/shopware/issues{/number}","pulls_url":"https://api.github.com/repos/VIISON/shopware/pulls{/number}","milestones_url":"https://api.github.com/repos/VIISON/shopware/milestones{/number}","notifications_url":"https://api.github.com/repos/VIISON/shopware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VIISON/shopware/labels{/name}","releases_url":"https://api.github.com/repos/VIISON/shopware/releases{/id}","deployments_url":"https://api.github.com/repos/VIISON/shopware/deployments","created_at":"2013-10-01T09:15:42Z","updated_at":"2016-11-03T19:11:35Z","pushed_at":"2017-10-25T13:49:23Z","git_url":"git://github.com/VIISON/shopware.git","ssh_url":"git@github.com:VIISON/shopware.git","clone_url":"https://github.com/VIISON/shopware.git","svn_url":"https://github.com/VIISON/shopware","homepage":"http://www.shopware.com","size":171720,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":27,"forks":0,"open_issues":27,"watchers":0,"default_branch":"5.3"}},"base":{"label":"VIISON:5.3","ref":"5.3","sha":"e60a41111cdc6ecec8002ef873c48a98dab2ad5f","user":{"login":"VIISON","id":710194,"avatar_url":"https://avatars1.githubusercontent.com/u/710194?v=4","gravatar_id":"","url":"https://api.github.com/users/VIISON","html_url":"https://github.com/VIISON","followers_url":"https://api.github.com/users/VIISON/followers","following_url":"https://api.github.com/users/VIISON/following{/other_user}","gists_url":"https://api.github.com/users/VIISON/gists{/gist_id}","starred_url":"https://api.github.com/users/VIISON/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VIISON/subscriptions","organizations_url":"https://api.github.com/users/VIISON/orgs","repos_url":"https://api.github.com/users/VIISON/repos","events_url":"https://api.github.com/users/VIISON/events{/privacy}","received_events_url":"https://api.github.com/users/VIISON/received_events","type":"Organization","site_admin":false},"repo":{"id":13239451,"name":"shopware","full_name":"VIISON/shopware","owner":{"login":"VIISON","id":710194,"avatar_url":"https://avatars1.githubusercontent.com/u/710194?v=4","gravatar_id":"","url":"https://api.github.com/users/VIISON","html_url":"https://github.com/VIISON","followers_url":"https://api.github.com/users/VIISON/followers","following_url":"https://api.github.com/users/VIISON/following{/other_user}","gists_url":"https://api.github.com/users/VIISON/gists{/gist_id}","starred_url":"https://api.github.com/users/VIISON/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VIISON/subscriptions","organizations_url":"https://api.github.com/users/VIISON/orgs","repos_url":"https://api.github.com/users/VIISON/repos","events_url":"https://api.github.com/users/VIISON/events{/privacy}","received_events_url":"https://api.github.com/users/VIISON/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/VIISON/shopware","description":"Shopware Repository","fork":true,"url":"https://api.github.com/repos/VIISON/shopware","forks_url":"https://api.github.com/repos/VIISON/shopware/forks","keys_url":"https://api.github.com/repos/VIISON/shopware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VIISON/shopware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VIISON/shopware/teams","hooks_url":"https://api.github.com/repos/VIISON/shopware/hooks","issue_events_url":"https://api.github.com/repos/VIISON/shopware/issues/events{/number}","events_url":"https://api.github.com/repos/VIISON/shopware/events","assignees_url":"https://api.github.com/repos/VIISON/shopware/assignees{/user}","branches_url":"https://api.github.com/repos/VIISON/shopware/branches{/branch}","tags_url":"https://api.github.com/repos/VIISON/shopware/tags","blobs_url":"https://api.github.com/repos/VIISON/shopware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VIISON/shopware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VIISON/shopware/git/refs{/sha}","trees_url":"https://api.github.com/repos/VIISON/shopware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VIISON/shopware/statuses/{sha}","languages_url":"https://api.github.com/repos/VIISON/shopware/languages","stargazers_url":"https://api.github.com/repos/VIISON/shopware/stargazers","contributors_url":"https://api.github.com/repos/VIISON/shopware/contributors","subscribers_url":"https://api.github.com/repos/VIISON/shopware/subscribers","subscription_url":"https://api.github.com/repos/VIISON/shopware/subscription","commits_url":"https://api.github.com/repos/VIISON/shopware/commits{/sha}","git_commits_url":"https://api.github.com/repos/VIISON/shopware/git/commits{/sha}","comments_url":"https://api.github.com/repos/VIISON/shopware/comments{/number}","issue_comment_url":"https://api.github.com/repos/VIISON/shopware/issues/comments{/number}","contents_url":"https://api.github.com/repos/VIISON/shopware/contents/{+path}","compare_url":"https://api.github.com/repos/VIISON/shopware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VIISON/shopware/merges","archive_url":"https://api.github.com/repos/VIISON/shopware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VIISON/shopware/downloads","issues_url":"https://api.github.com/repos/VIISON/shopware/issues{/number}","pulls_url":"https://api.github.com/repos/VIISON/shopware/pulls{/number}","milestones_url":"https://api.github.com/repos/VIISON/shopware/milestones{/number}","notifications_url":"https://api.github.com/repos/VIISON/shopware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VIISON/shopware/labels{/name}","releases_url":"https://api.github.com/repos/VIISON/shopware/releases{/id}","deployments_url":"https://api.github.com/repos/VIISON/shopware/deployments","created_at":"2013-10-01T09:15:42Z","updated_at":"2016-11-03T19:11:35Z","pushed_at":"2017-10-25T13:49:23Z","git_url":"git://github.com/VIISON/shopware.git","ssh_url":"git@github.com:VIISON/shopware.git","clone_url":"https://github.com/VIISON/shopware.git","svn_url":"https://github.com/VIISON/shopware","homepage":"http://www.shopware.com","size":171720,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":27,"forks":0,"open_issues":27,"watchers":0,"default_branch":"5.3"}},"_links":{"self":{"href":"https://api.github.com/repos/VIISON/shopware/pulls/50"},"html":{"href":"https://github.com/VIISON/shopware/pull/50"},"issue":{"href":"https://api.github.com/repos/VIISON/shopware/issues/50"},"comments":{"href":"https://api.github.com/repos/VIISON/shopware/issues/50/comments"},"review_comments":{"href":"https://api.github.com/repos/VIISON/shopware/pulls/50/comments"},"review_comment":{"href":"https://api.github.com/repos/VIISON/shopware/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/VIISON/shopware/pulls/50/commits"},"statuses":{"href":"https://api.github.com/repos/VIISON/shopware/statuses/d45d32fb788c7cf1dbafc139727a7b299de11ff0"}},"author_association":"NONE"}}
{"actor":{"display_login":"niklasbuechner"}}