{"action":"created","comment":{"url":"https://api.github.com/repos/exo-addons/chat-application/pulls/comments/123171089","pull_request_review_id":45346644,"id":123171089,"diff_hunk":"@@ -265,61 +268,37 @@ ChatRoom.prototype.onShowMessages = function(callback) {\n \n ChatRoom.prototype.sendMessage = function(msg, options, isSystemMessage, callback) {\n   if(msg.trim().length != 0 || options.type) {\n-    this.sendFullMessage(this.username, this.token, this.targetUser, this.id, msg, options, isSystemMessage, callback);\n+    var msgObj = {\n+      \"clientId\": 'cId_' + new Date().getTime(),","path":"application/src/main/webapp/js/chat-modules.js","position":47,"original_position":47,"commit_id":"140abbab891710b13f8432f597c7e5037bc564f5","original_commit_id":"140abbab891710b13f8432f597c7e5037bc564f5","user":{"login":"trongtt","id":515969,"avatar_url":"https://avatars0.githubusercontent.com/u/515969?v=3","gravatar_id":"","url":"https://api.github.com/users/trongtt","html_url":"https://github.com/trongtt","followers_url":"https://api.github.com/users/trongtt/followers","following_url":"https://api.github.com/users/trongtt/following{/other_user}","gists_url":"https://api.github.com/users/trongtt/gists{/gist_id}","starred_url":"https://api.github.com/users/trongtt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trongtt/subscriptions","organizations_url":"https://api.github.com/users/trongtt/orgs","repos_url":"https://api.github.com/users/trongtt/repos","events_url":"https://api.github.com/users/trongtt/events{/privacy}","received_events_url":"https://api.github.com/users/trongtt/received_events","type":"User","site_admin":false},"body":"Yes, we had the same issue with msgId indeed. So what should we do finally ? accepting the issue for both msgId and clientId to keep it simple ?","created_at":"2017-06-21T07:25:25Z","updated_at":"2017-06-21T07:25:25Z","html_url":"https://github.com/exo-addons/chat-application/pull/117#discussion_r123171089","pull_request_url":"https://api.github.com/repos/exo-addons/chat-application/pulls/117","_links":{"self":{"href":"https://api.github.com/repos/exo-addons/chat-application/pulls/comments/123171089"},"html":{"href":"https://github.com/exo-addons/chat-application/pull/117#discussion_r123171089"},"pull_request":{"href":"https://api.github.com/repos/exo-addons/chat-application/pulls/117"}}},"pull_request":{"url":"https://api.github.com/repos/exo-addons/chat-application/pulls/117","id":123959542,"html_url":"https://github.com/exo-addons/chat-application/pull/117","diff_url":"https://github.com/exo-addons/chat-application/pull/117.diff","patch_url":"https://github.com/exo-addons/chat-application/pull/117.patch","issue_url":"https://api.github.com/repos/exo-addons/chat-application/issues/117","number":117,"state":"open","locked":false,"title":"CHAT-688 Messages are lost without notice in case of sending error","user":{"login":"trongtt","id":515969,"avatar_url":"https://avatars0.githubusercontent.com/u/515969?v=3","gravatar_id":"","url":"https://api.github.com/users/trongtt","html_url":"https://github.com/trongtt","followers_url":"https://api.github.com/users/trongtt/followers","following_url":"https://api.github.com/users/trongtt/following{/other_user}","gists_url":"https://api.github.com/users/trongtt/gists{/gist_id}","starred_url":"https://api.github.com/users/trongtt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trongtt/subscriptions","organizations_url":"https://api.github.com/users/trongtt/orgs","repos_url":"https://api.github.com/users/trongtt/repos","events_url":"https://api.github.com/users/trongtt/events{/privacy}","received_events_url":"https://api.github.com/users/trongtt/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-06-05T11:24:07Z","updated_at":"2017-06-21T07:25:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eeb31f285c03f8fc2a21535f173aef5bbc2e1b40","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/exo-addons/chat-application/pulls/117/commits","review_comments_url":"https://api.github.com/repos/exo-addons/chat-application/pulls/117/comments","review_comment_url":"https://api.github.com/repos/exo-addons/chat-application/pulls/comments{/number}","comments_url":"https://api.github.com/repos/exo-addons/chat-application/issues/117/comments","statuses_url":"https://api.github.com/repos/exo-addons/chat-application/statuses/140abbab891710b13f8432f597c7e5037bc564f5","head":{"label":"exo-addons:fix/CHAT-688","ref":"fix/CHAT-688","sha":"140abbab891710b13f8432f597c7e5037bc564f5","user":{"login":"exo-addons","id":2581906,"avatar_url":"https://avatars0.githubusercontent.com/u/2581906?v=3","gravatar_id":"","url":"https://api.github.com/users/exo-addons","html_url":"https://github.com/exo-addons","followers_url":"https://api.github.com/users/exo-addons/followers","following_url":"https://api.github.com/users/exo-addons/following{/other_user}","gists_url":"https://api.github.com/users/exo-addons/gists{/gist_id}","starred_url":"https://api.github.com/users/exo-addons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exo-addons/subscriptions","organizations_url":"https://api.github.com/users/exo-addons/orgs","repos_url":"https://api.github.com/users/exo-addons/repos","events_url":"https://api.github.com/users/exo-addons/events{/privacy}","received_events_url":"https://api.github.com/users/exo-addons/received_events","type":"Organization","site_admin":false},"repo":{"id":33261222,"name":"chat-application","full_name":"exo-addons/chat-application","owner":{"login":"exo-addons","id":2581906,"avatar_url":"https://avatars0.githubusercontent.com/u/2581906?v=3","gravatar_id":"","url":"https://api.github.com/users/exo-addons","html_url":"https://github.com/exo-addons","followers_url":"https://api.github.com/users/exo-addons/followers","following_url":"https://api.github.com/users/exo-addons/following{/other_user}","gists_url":"https://api.github.com/users/exo-addons/gists{/gist_id}","starred_url":"https://api.github.com/users/exo-addons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exo-addons/subscriptions","organizations_url":"https://api.github.com/users/exo-addons/orgs","repos_url":"https://api.github.com/users/exo-addons/repos","events_url":"https://api.github.com/users/exo-addons/events{/privacy}","received_events_url":"https://api.github.com/users/exo-addons/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/exo-addons/chat-application","description":"Chat application","fork":true,"url":"https://api.github.com/repos/exo-addons/chat-application","forks_url":"https://api.github.com/repos/exo-addons/chat-application/forks","keys_url":"https://api.github.com/repos/exo-addons/chat-application/keys{/key_id}","collaborators_url":"https://api.github.com/repos/exo-addons/chat-application/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/exo-addons/chat-application/teams","hooks_url":"https://api.github.com/repos/exo-addons/chat-application/hooks","issue_events_url":"https://api.github.com/repos/exo-addons/chat-application/issues/events{/number}","events_url":"https://api.github.com/repos/exo-addons/chat-application/events","assignees_url":"https://api.github.com/repos/exo-addons/chat-application/assignees{/user}","branches_url":"https://api.github.com/repos/exo-addons/chat-application/branches{/branch}","tags_url":"https://api.github.com/repos/exo-addons/chat-application/tags","blobs_url":"https://api.github.com/repos/exo-addons/chat-application/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/exo-addons/chat-application/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/exo-addons/chat-application/git/refs{/sha}","trees_url":"https://api.github.com/repos/exo-addons/chat-application/git/trees{/sha}","statuses_url":"https://api.github.com/repos/exo-addons/chat-application/statuses/{sha}","languages_url":"https://api.github.com/repos/exo-addons/chat-application/languages","stargazers_url":"https://api.github.com/repos/exo-addons/chat-application/stargazers","contributors_url":"https://api.github.com/repos/exo-addons/chat-application/contributors","subscribers_url":"https://api.github.com/repos/exo-addons/chat-application/subscribers","subscription_url":"https://api.github.com/repos/exo-addons/chat-application/subscription","commits_url":"https://api.github.com/repos/exo-addons/chat-application/commits{/sha}","git_commits_url":"https://api.github.com/repos/exo-addons/chat-application/git/commits{/sha}","comments_url":"https://api.github.com/repos/exo-addons/chat-application/comments{/number}","issue_comment_url":"https://api.github.com/repos/exo-addons/chat-application/issues/comments{/number}","contents_url":"https://api.github.com/repos/exo-addons/chat-application/contents/{+path}","compare_url":"https://api.github.com/repos/exo-addons/chat-application/compare/{base}...{head}","merges_url":"https://api.github.com/repos/exo-addons/chat-application/merges","archive_url":"https://api.github.com/repos/exo-addons/chat-application/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/exo-addons/chat-application/downloads","issues_url":"https://api.github.com/repos/exo-addons/chat-application/issues{/number}","pulls_url":"https://api.github.com/repos/exo-addons/chat-application/pulls{/number}","milestones_url":"https://api.github.com/repos/exo-addons/chat-application/milestones{/number}","notifications_url":"https://api.github.com/repos/exo-addons/chat-application/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/exo-addons/chat-application/labels{/name}","releases_url":"https://api.github.com/repos/exo-addons/chat-application/releases{/id}","deployments_url":"https://api.github.com/repos/exo-addons/chat-application/deployments","created_at":"2015-04-01T17:12:47Z","updated_at":"2017-01-24T09:57:40Z","pushed_at":"2017-06-21T03:41:17Z","git_url":"git://github.com/exo-addons/chat-application.git","ssh_url":"git@github.com:exo-addons/chat-application.git","clone_url":"https://github.com/exo-addons/chat-application.git","svn_url":"https://github.com/exo-addons/chat-application","homepage":null,"size":29001,"stargazers_count":7,"watchers_count":7,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":19,"forks":8,"open_issues":19,"watchers":7,"default_branch":"develop"}},"base":{"label":"exo-addons:develop","ref":"develop","sha":"a8bf7e83647c08bad762b5603cfe05e91d83d21e","user":{"login":"exo-addons","id":2581906,"avatar_url":"https://avatars0.githubusercontent.com/u/2581906?v=3","gravatar_id":"","url":"https://api.github.com/users/exo-addons","html_url":"https://github.com/exo-addons","followers_url":"https://api.github.com/users/exo-addons/followers","following_url":"https://api.github.com/users/exo-addons/following{/other_user}","gists_url":"https://api.github.com/users/exo-addons/gists{/gist_id}","starred_url":"https://api.github.com/users/exo-addons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exo-addons/subscriptions","organizations_url":"https://api.github.com/users/exo-addons/orgs","repos_url":"https://api.github.com/users/exo-addons/repos","events_url":"https://api.github.com/users/exo-addons/events{/privacy}","received_events_url":"https://api.github.com/users/exo-addons/received_events","type":"Organization","site_admin":false},"repo":{"id":33261222,"name":"chat-application","full_name":"exo-addons/chat-application","owner":{"login":"exo-addons","id":2581906,"avatar_url":"https://avatars0.githubusercontent.com/u/2581906?v=3","gravatar_id":"","url":"https://api.github.com/users/exo-addons","html_url":"https://github.com/exo-addons","followers_url":"https://api.github.com/users/exo-addons/followers","following_url":"https://api.github.com/users/exo-addons/following{/other_user}","gists_url":"https://api.github.com/users/exo-addons/gists{/gist_id}","starred_url":"https://api.github.com/users/exo-addons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exo-addons/subscriptions","organizations_url":"https://api.github.com/users/exo-addons/orgs","repos_url":"https://api.github.com/users/exo-addons/repos","events_url":"https://api.github.com/users/exo-addons/events{/privacy}","received_events_url":"https://api.github.com/users/exo-addons/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/exo-addons/chat-application","description":"Chat application","fork":true,"url":"https://api.github.com/repos/exo-addons/chat-application","forks_url":"https://api.github.com/repos/exo-addons/chat-application/forks","keys_url":"https://api.github.com/repos/exo-addons/chat-application/keys{/key_id}","collaborators_url":"https://api.github.com/repos/exo-addons/chat-application/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/exo-addons/chat-application/teams","hooks_url":"https://api.github.com/repos/exo-addons/chat-application/hooks","issue_events_url":"https://api.github.com/repos/exo-addons/chat-application/issues/events{/number}","events_url":"https://api.github.com/repos/exo-addons/chat-application/events","assignees_url":"https://api.github.com/repos/exo-addons/chat-application/assignees{/user}","branches_url":"https://api.github.com/repos/exo-addons/chat-application/branches{/branch}","tags_url":"https://api.github.com/repos/exo-addons/chat-application/tags","blobs_url":"https://api.github.com/repos/exo-addons/chat-application/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/exo-addons/chat-application/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/exo-addons/chat-application/git/refs{/sha}","trees_url":"https://api.github.com/repos/exo-addons/chat-application/git/trees{/sha}","statuses_url":"https://api.github.com/repos/exo-addons/chat-application/statuses/{sha}","languages_url":"https://api.github.com/repos/exo-addons/chat-application/languages","stargazers_url":"https://api.github.com/repos/exo-addons/chat-application/stargazers","contributors_url":"https://api.github.com/repos/exo-addons/chat-application/contributors","subscribers_url":"https://api.github.com/repos/exo-addons/chat-application/subscribers","subscription_url":"https://api.github.com/repos/exo-addons/chat-application/subscription","commits_url":"https://api.github.com/repos/exo-addons/chat-application/commits{/sha}","git_commits_url":"https://api.github.com/repos/exo-addons/chat-application/git/commits{/sha}","comments_url":"https://api.github.com/repos/exo-addons/chat-application/comments{/number}","issue_comment_url":"https://api.github.com/repos/exo-addons/chat-application/issues/comments{/number}","contents_url":"https://api.github.com/repos/exo-addons/chat-application/contents/{+path}","compare_url":"https://api.github.com/repos/exo-addons/chat-application/compare/{base}...{head}","merges_url":"https://api.github.com/repos/exo-addons/chat-application/merges","archive_url":"https://api.github.com/repos/exo-addons/chat-application/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/exo-addons/chat-application/downloads","issues_url":"https://api.github.com/repos/exo-addons/chat-application/issues{/number}","pulls_url":"https://api.github.com/repos/exo-addons/chat-application/pulls{/number}","milestones_url":"https://api.github.com/repos/exo-addons/chat-application/milestones{/number}","notifications_url":"https://api.github.com/repos/exo-addons/chat-application/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/exo-addons/chat-application/labels{/name}","releases_url":"https://api.github.com/repos/exo-addons/chat-application/releases{/id}","deployments_url":"https://api.github.com/repos/exo-addons/chat-application/deployments","created_at":"2015-04-01T17:12:47Z","updated_at":"2017-01-24T09:57:40Z","pushed_at":"2017-06-21T03:41:17Z","git_url":"git://github.com/exo-addons/chat-application.git","ssh_url":"git@github.com:exo-addons/chat-application.git","clone_url":"https://github.com/exo-addons/chat-application.git","svn_url":"https://github.com/exo-addons/chat-application","homepage":null,"size":29001,"stargazers_count":7,"watchers_count":7,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":19,"forks":8,"open_issues":19,"watchers":7,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/exo-addons/chat-application/pulls/117"},"html":{"href":"https://github.com/exo-addons/chat-application/pull/117"},"issue":{"href":"https://api.github.com/repos/exo-addons/chat-application/issues/117"},"comments":{"href":"https://api.github.com/repos/exo-addons/chat-application/issues/117/comments"},"review_comments":{"href":"https://api.github.com/repos/exo-addons/chat-application/pulls/117/comments"},"review_comment":{"href":"https://api.github.com/repos/exo-addons/chat-application/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/exo-addons/chat-application/pulls/117/commits"},"statuses":{"href":"https://api.github.com/repos/exo-addons/chat-application/statuses/140abbab891710b13f8432f597c7e5037bc564f5"}}}}
{"actor":{"display_login":"trongtt"}}