{"action":"created","comment":{"url":"https://api.github.com/repos/minio/minio/pulls/comments/130982993","pull_request_review_id":53917745,"id":130982993,"diff_hunk":"@@ -33,18 +34,10 @@ func testAuthenticate(authType string, t *testing.T) {\n \t\tsecretKey   string\n \t\texpectedErr error\n \t}{\n-\t\t// Access key too small.\n-\t\t{\"user\", \"pass\", errInvalidAccessKeyLength},\n-\t\t// Access key too long.\n-\t\t{\"user12345678901234567\", \"pass\", errInvalidAccessKeyLength},\n+\t\t// Access key (less than 5 chrs) too small.\n+\t\t{\"user\", serverCred.SecretKey, errInvalidAccessKeyLength},\n \t\t// Access key contains unsuppported characters.\n-\t\t{\"!@#$\", \"pass\", errInvalidAccessKeyLength},\n-\t\t// Success when access key contains leading/trailing spaces.\n-\t\t{\" \" + serverCred.AccessKey + \" \", serverCred.SecretKey, errInvalidAccessKeyLength},\n-\t\t// Secret key too small.\n-\t\t{\"myuser\", \"pass\", errInvalidSecretKeyLength},\n-\t\t// Secret key too long.\n-\t\t{\"myuser\", \"pass1234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890\", errInvalidSecretKeyLength},\n+\t\t{serverCred.AccessKey, \"pass\", errInvalidSecretKeyLength},","path":"cmd/jwt_test.go","position":null,"original_position":28,"commit_id":"26b84c7c6d0332829be4334a5b794d14f08ebf5e","original_commit_id":"c4a37bf9e8c40d8c35b041ffcec4df4890a3d1ed","user":{"login":"ebozduman","id":24552332,"avatar_url":"https://avatars0.githubusercontent.com/u/24552332?v=4","gravatar_id":"","url":"https://api.github.com/users/ebozduman","html_url":"https://github.com/ebozduman","followers_url":"https://api.github.com/users/ebozduman/followers","following_url":"https://api.github.com/users/ebozduman/following{/other_user}","gists_url":"https://api.github.com/users/ebozduman/gists{/gist_id}","starred_url":"https://api.github.com/users/ebozduman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebozduman/subscriptions","organizations_url":"https://api.github.com/users/ebozduman/orgs","repos_url":"https://api.github.com/users/ebozduman/repos","events_url":"https://api.github.com/users/ebozduman/events{/privacy}","received_events_url":"https://api.github.com/users/ebozduman/received_events","type":"User","site_admin":false},"body":"Done","created_at":"2017-08-02T20:11:20Z","updated_at":"2017-08-02T20:11:20Z","html_url":"https://github.com/minio/minio/pull/4730#discussion_r130982993","pull_request_url":"https://api.github.com/repos/minio/minio/pulls/4730","_links":{"self":{"href":"https://api.github.com/repos/minio/minio/pulls/comments/130982993"},"html":{"href":"https://github.com/minio/minio/pull/4730#discussion_r130982993"},"pull_request":{"href":"https://api.github.com/repos/minio/minio/pulls/4730"}}},"pull_request":{"url":"https://api.github.com/repos/minio/minio/pulls/4730","id":132884390,"html_url":"https://github.com/minio/minio/pull/4730","diff_url":"https://github.com/minio/minio/pull/4730.diff","patch_url":"https://github.com/minio/minio/pull/4730.patch","issue_url":"https://api.github.com/repos/minio/minio/issues/4730","number":4730,"state":"open","locked":false,"title":"Removes max limit requirement on accessKey and secretKey length","user":{"login":"ebozduman","id":24552332,"avatar_url":"https://avatars0.githubusercontent.com/u/24552332?v=4","gravatar_id":"","url":"https://api.github.com/users/ebozduman","html_url":"https://github.com/ebozduman","followers_url":"https://api.github.com/users/ebozduman/followers","following_url":"https://api.github.com/users/ebozduman/following{/other_user}","gists_url":"https://api.github.com/users/ebozduman/gists{/gist_id}","starred_url":"https://api.github.com/users/ebozduman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebozduman/subscriptions","organizations_url":"https://api.github.com/users/ebozduman/orgs","repos_url":"https://api.github.com/users/ebozduman/repos","events_url":"https://api.github.com/users/ebozduman/events{/privacy}","received_events_url":"https://api.github.com/users/ebozduman/received_events","type":"User","site_admin":false},"body":"## Description\r\nFixes Issue #4721 by removing the max limit variable and check \r\nso that there is no max limit on both accessKey and secretKey. \r\nWe are still using minio specific max length to generate accessKey \r\nand secretKey. Corresponding tests and README file are also modified.\r\n\r\n## Motivation and Context\r\nIssue #4721: Increase access key to 24 chars for compatibility with Azure\r\n\r\n## How Has This Been Tested?\r\n- Started minio in gateway (azure) and standalone modes with a 30 byte long accessKey successfully without getting max length error message.\r\n- Ran with less than 4 bytes accessKey and less than 8 secretKey to make sure correct error messages are displayed.\r\n- Ran existing test cases.\r\n\r\n## Types of changes\r\n- [x] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n- [x] My code follows the code style of this project.\r\n- [x] My change requires a change to the documentation.\r\n- [x] I have updated the documentation accordingly.\r\n- [x] I have updated existing tests to cover my changes.\r\n- [x] All new and existing tests passed.","created_at":"2017-07-28T02:44:33Z","updated_at":"2017-08-02T20:11:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7c68c6ffe3ee1c6d983d91c5818f9a753e1f58d3","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/minio/minio/pulls/4730/commits","review_comments_url":"https://api.github.com/repos/minio/minio/pulls/4730/comments","review_comment_url":"https://api.github.com/repos/minio/minio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/minio/minio/issues/4730/comments","statuses_url":"https://api.github.com/repos/minio/minio/statuses/26b84c7c6d0332829be4334a5b794d14f08ebf5e","head":{"label":"ebozduman:accessKeyMaxLimit#4721","ref":"accessKeyMaxLimit#4721","sha":"26b84c7c6d0332829be4334a5b794d14f08ebf5e","user":{"login":"ebozduman","id":24552332,"avatar_url":"https://avatars0.githubusercontent.com/u/24552332?v=4","gravatar_id":"","url":"https://api.github.com/users/ebozduman","html_url":"https://github.com/ebozduman","followers_url":"https://api.github.com/users/ebozduman/followers","following_url":"https://api.github.com/users/ebozduman/following{/other_user}","gists_url":"https://api.github.com/users/ebozduman/gists{/gist_id}","starred_url":"https://api.github.com/users/ebozduman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebozduman/subscriptions","organizations_url":"https://api.github.com/users/ebozduman/orgs","repos_url":"https://api.github.com/users/ebozduman/repos","events_url":"https://api.github.com/users/ebozduman/events{/privacy}","received_events_url":"https://api.github.com/users/ebozduman/received_events","type":"User","site_admin":false},"repo":{"id":95580938,"name":"minio","full_name":"ebozduman/minio","owner":{"login":"ebozduman","id":24552332,"avatar_url":"https://avatars0.githubusercontent.com/u/24552332?v=4","gravatar_id":"","url":"https://api.github.com/users/ebozduman","html_url":"https://github.com/ebozduman","followers_url":"https://api.github.com/users/ebozduman/followers","following_url":"https://api.github.com/users/ebozduman/following{/other_user}","gists_url":"https://api.github.com/users/ebozduman/gists{/gist_id}","starred_url":"https://api.github.com/users/ebozduman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebozduman/subscriptions","organizations_url":"https://api.github.com/users/ebozduman/orgs","repos_url":"https://api.github.com/users/ebozduman/repos","events_url":"https://api.github.com/users/ebozduman/events{/privacy}","received_events_url":"https://api.github.com/users/ebozduman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ebozduman/minio","description":"Minio is an open source object storage server compatible with Amazon S3 APIs","fork":true,"url":"https://api.github.com/repos/ebozduman/minio","forks_url":"https://api.github.com/repos/ebozduman/minio/forks","keys_url":"https://api.github.com/repos/ebozduman/minio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ebozduman/minio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ebozduman/minio/teams","hooks_url":"https://api.github.com/repos/ebozduman/minio/hooks","issue_events_url":"https://api.github.com/repos/ebozduman/minio/issues/events{/number}","events_url":"https://api.github.com/repos/ebozduman/minio/events","assignees_url":"https://api.github.com/repos/ebozduman/minio/assignees{/user}","branches_url":"https://api.github.com/repos/ebozduman/minio/branches{/branch}","tags_url":"https://api.github.com/repos/ebozduman/minio/tags","blobs_url":"https://api.github.com/repos/ebozduman/minio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ebozduman/minio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ebozduman/minio/git/refs{/sha}","trees_url":"https://api.github.com/repos/ebozduman/minio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ebozduman/minio/statuses/{sha}","languages_url":"https://api.github.com/repos/ebozduman/minio/languages","stargazers_url":"https://api.github.com/repos/ebozduman/minio/stargazers","contributors_url":"https://api.github.com/repos/ebozduman/minio/contributors","subscribers_url":"https://api.github.com/repos/ebozduman/minio/subscribers","subscription_url":"https://api.github.com/repos/ebozduman/minio/subscription","commits_url":"https://api.github.com/repos/ebozduman/minio/commits{/sha}","git_commits_url":"https://api.github.com/repos/ebozduman/minio/git/commits{/sha}","comments_url":"https://api.github.com/repos/ebozduman/minio/comments{/number}","issue_comment_url":"https://api.github.com/repos/ebozduman/minio/issues/comments{/number}","contents_url":"https://api.github.com/repos/ebozduman/minio/contents/{+path}","compare_url":"https://api.github.com/repos/ebozduman/minio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ebozduman/minio/merges","archive_url":"https://api.github.com/repos/ebozduman/minio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ebozduman/minio/downloads","issues_url":"https://api.github.com/repos/ebozduman/minio/issues{/number}","pulls_url":"https://api.github.com/repos/ebozduman/minio/pulls{/number}","milestones_url":"https://api.github.com/repos/ebozduman/minio/milestones{/number}","notifications_url":"https://api.github.com/repos/ebozduman/minio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ebozduman/minio/labels{/name}","releases_url":"https://api.github.com/repos/ebozduman/minio/releases{/id}","deployments_url":"https://api.github.com/repos/ebozduman/minio/deployments","created_at":"2017-06-27T16:52:52Z","updated_at":"2017-06-27T16:52:55Z","pushed_at":"2017-08-02T20:09:59Z","git_url":"git://github.com/ebozduman/minio.git","ssh_url":"git@github.com:ebozduman/minio.git","clone_url":"https://github.com/ebozduman/minio.git","svn_url":"https://github.com/ebozduman/minio","homepage":"https://minio.io","size":26756,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"minio:master","ref":"master","sha":"6afbd502e83f13190492105dd5527270c594d309","user":{"login":"minio","id":695951,"avatar_url":"https://avatars3.githubusercontent.com/u/695951?v=4","gravatar_id":"","url":"https://api.github.com/users/minio","html_url":"https://github.com/minio","followers_url":"https://api.github.com/users/minio/followers","following_url":"https://api.github.com/users/minio/following{/other_user}","gists_url":"https://api.github.com/users/minio/gists{/gist_id}","starred_url":"https://api.github.com/users/minio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minio/subscriptions","organizations_url":"https://api.github.com/users/minio/orgs","repos_url":"https://api.github.com/users/minio/repos","events_url":"https://api.github.com/users/minio/events{/privacy}","received_events_url":"https://api.github.com/users/minio/received_events","type":"Organization","site_admin":false},"repo":{"id":29261473,"name":"minio","full_name":"minio/minio","owner":{"login":"minio","id":695951,"avatar_url":"https://avatars3.githubusercontent.com/u/695951?v=4","gravatar_id":"","url":"https://api.github.com/users/minio","html_url":"https://github.com/minio","followers_url":"https://api.github.com/users/minio/followers","following_url":"https://api.github.com/users/minio/following{/other_user}","gists_url":"https://api.github.com/users/minio/gists{/gist_id}","starred_url":"https://api.github.com/users/minio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minio/subscriptions","organizations_url":"https://api.github.com/users/minio/orgs","repos_url":"https://api.github.com/users/minio/repos","events_url":"https://api.github.com/users/minio/events{/privacy}","received_events_url":"https://api.github.com/users/minio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/minio/minio","description":"Minio is an open source object storage server compatible with Amazon S3 APIs","fork":false,"url":"https://api.github.com/repos/minio/minio","forks_url":"https://api.github.com/repos/minio/minio/forks","keys_url":"https://api.github.com/repos/minio/minio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minio/minio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minio/minio/teams","hooks_url":"https://api.github.com/repos/minio/minio/hooks","issue_events_url":"https://api.github.com/repos/minio/minio/issues/events{/number}","events_url":"https://api.github.com/repos/minio/minio/events","assignees_url":"https://api.github.com/repos/minio/minio/assignees{/user}","branches_url":"https://api.github.com/repos/minio/minio/branches{/branch}","tags_url":"https://api.github.com/repos/minio/minio/tags","blobs_url":"https://api.github.com/repos/minio/minio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minio/minio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minio/minio/git/refs{/sha}","trees_url":"https://api.github.com/repos/minio/minio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minio/minio/statuses/{sha}","languages_url":"https://api.github.com/repos/minio/minio/languages","stargazers_url":"https://api.github.com/repos/minio/minio/stargazers","contributors_url":"https://api.github.com/repos/minio/minio/contributors","subscribers_url":"https://api.github.com/repos/minio/minio/subscribers","subscription_url":"https://api.github.com/repos/minio/minio/subscription","commits_url":"https://api.github.com/repos/minio/minio/commits{/sha}","git_commits_url":"https://api.github.com/repos/minio/minio/git/commits{/sha}","comments_url":"https://api.github.com/repos/minio/minio/comments{/number}","issue_comment_url":"https://api.github.com/repos/minio/minio/issues/comments{/number}","contents_url":"https://api.github.com/repos/minio/minio/contents/{+path}","compare_url":"https://api.github.com/repos/minio/minio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minio/minio/merges","archive_url":"https://api.github.com/repos/minio/minio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minio/minio/downloads","issues_url":"https://api.github.com/repos/minio/minio/issues{/number}","pulls_url":"https://api.github.com/repos/minio/minio/pulls{/number}","milestones_url":"https://api.github.com/repos/minio/minio/milestones{/number}","notifications_url":"https://api.github.com/repos/minio/minio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minio/minio/labels{/name}","releases_url":"https://api.github.com/repos/minio/minio/releases{/id}","deployments_url":"https://api.github.com/repos/minio/minio/deployments","created_at":"2015-01-14T19:23:58Z","updated_at":"2017-08-02T19:29:49Z","pushed_at":"2017-08-02T20:10:01Z","git_url":"git://github.com/minio/minio.git","ssh_url":"git@github.com:minio/minio.git","clone_url":"https://github.com/minio/minio.git","svn_url":"https://github.com/minio/minio","homepage":"https://minio.io","size":26622,"stargazers_count":7667,"watchers_count":7667,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":586,"mirror_url":null,"open_issues_count":170,"forks":586,"open_issues":170,"watchers":7667,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/minio/minio/pulls/4730"},"html":{"href":"https://github.com/minio/minio/pull/4730"},"issue":{"href":"https://api.github.com/repos/minio/minio/issues/4730"},"comments":{"href":"https://api.github.com/repos/minio/minio/issues/4730/comments"},"review_comments":{"href":"https://api.github.com/repos/minio/minio/pulls/4730/comments"},"review_comment":{"href":"https://api.github.com/repos/minio/minio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/minio/minio/pulls/4730/commits"},"statuses":{"href":"https://api.github.com/repos/minio/minio/statuses/26b84c7c6d0332829be4334a5b794d14f08ebf5e"}}}}
{"actor":{"display_login":"ebozduman"}}