{"action":"created","issue":{"url":"https://api.github.com/repos/dollarshaveclub/ember-router-scroll/issues/46","repository_url":"https://api.github.com/repos/dollarshaveclub/ember-router-scroll","labels_url":"https://api.github.com/repos/dollarshaveclub/ember-router-scroll/issues/46/labels{/name}","comments_url":"https://api.github.com/repos/dollarshaveclub/ember-router-scroll/issues/46/comments","events_url":"https://api.github.com/repos/dollarshaveclub/ember-router-scroll/issues/46/events","html_url":"https://github.com/dollarshaveclub/ember-router-scroll/pull/46","id":219946829,"number":46,"title":"[RFC] User Ember.set to set previousURL","user":{"login":"mschinis","id":771903,"avatar_url":"https://avatars1.githubusercontent.com/u/771903?v=3","gravatar_id":"","url":"https://api.github.com/users/mschinis","html_url":"https://github.com/mschinis","followers_url":"https://api.github.com/users/mschinis/followers","following_url":"https://api.github.com/users/mschinis/following{/other_user}","gists_url":"https://api.github.com/users/mschinis/gists{/gist_id}","starred_url":"https://api.github.com/users/mschinis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mschinis/subscriptions","organizations_url":"https://api.github.com/users/mschinis/orgs","repos_url":"https://api.github.com/users/mschinis/repos","events_url":"https://api.github.com/users/mschinis/events{/privacy}","received_events_url":"https://api.github.com/users/mschinis/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-04-06T15:56:33Z","updated_at":"2017-04-07T13:47:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dollarshaveclub/ember-router-scroll/pulls/46","html_url":"https://github.com/dollarshaveclub/ember-router-scroll/pull/46","diff_url":"https://github.com/dollarshaveclub/ember-router-scroll/pull/46.diff","patch_url":"https://github.com/dollarshaveclub/ember-router-scroll/pull/46.patch"},"body":"## Why\r\nCreating and clicking the following link `<a href=\"/some-page\"></a>` threw the following error.\r\n\r\n`You must use Ember.set() to set the 'previousURL' property (of <project-name@location:router-scroll::ember369>) to '/category/homewares/home-accessories?p=3'.`\r\n\r\nThis PR uses Ember.set to fix the error."},"comment":{"url":"https://api.github.com/repos/dollarshaveclub/ember-router-scroll/issues/comments/292541033","html_url":"https://github.com/dollarshaveclub/ember-router-scroll/pull/46#issuecomment-292541033","issue_url":"https://api.github.com/repos/dollarshaveclub/ember-router-scroll/issues/46","id":292541033,"user":{"login":"mschinis","id":771903,"avatar_url":"https://avatars1.githubusercontent.com/u/771903?v=3","gravatar_id":"","url":"https://api.github.com/users/mschinis","html_url":"https://github.com/mschinis","followers_url":"https://api.github.com/users/mschinis/followers","following_url":"https://api.github.com/users/mschinis/following{/other_user}","gists_url":"https://api.github.com/users/mschinis/gists{/gist_id}","starred_url":"https://api.github.com/users/mschinis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mschinis/subscriptions","organizations_url":"https://api.github.com/users/mschinis/orgs","repos_url":"https://api.github.com/users/mschinis/repos","events_url":"https://api.github.com/users/mschinis/events{/privacy}","received_events_url":"https://api.github.com/users/mschinis/received_events","type":"User","site_admin":false},"created_at":"2017-04-07T13:47:47Z","updated_at":"2017-04-07T13:47:47Z","body":"@YoranBrondsema I'm on Ember 2.12. I just created the following:\r\n\r\n*some-component.js*\r\n```javascript\r\n\r\nexport default Ember.Component.extend({\r\n    someDynamicUrl: Ember.computed('dependentKey', function () {\r\n        .........\r\n       // Notice url must start with a slash to transition within the app\r\n        return \"/path/to/a/url?with=query-params\";\r\n    })\r\n});```\r\n\r\n*some-component.hbs*\r\n```hbs\r\n<a href={{someDynamicUrl}}>\r\nClick me!\r\n</a>```\r\n\r\nand then just click the link."}}
{"actor":{"display_login":"mschinis"}}