{"action":"created","comment":{"url":"https://api.github.com/repos/w3c/orientation-sensor/pulls/comments/108377582","pull_request_review_id":29402682,"id":108377582,"diff_hunk":"@@ -214,45 +215,56 @@ In other words, this attribute returns [=latest reading=][\"quaternion\"].\n \n ### OrientationSensor.populateMatrix() ### {#orientationsensor-populatematrix}\n \n-The {{OrientationSensor/populateMatrix()}} method  populates the given buffer with WebGL-compatible rotation matrix\n+The {{OrientationSensor/populateMatrix()}} method  populates the given object with rotation matrix\n which is converted from the value of [=latest reading=][\"quaternion\"] [[QUATCONV]], as shown below\n \n <img src=\"quaternion_to_rotation_matrix.png\" style=\"display: block;margin: auto;\" alt=\"Converting quaternion to rotation matrix.\" width=\"50%\" height=\"50%\">\n \n where:\n \n- - W = cos(θ/2).\n- - X = V<sub>x</sub> * sin(θ/2).\n- - Y = V<sub>y</sub> * sin(θ/2).\n- - Z = V<sub>z</sub> * sin(θ/2).\n+ - W = cos(θ/2)\n+ - X = V<sub>x</sub> * sin(θ/2)\n+ - Y = V<sub>y</sub> * sin(θ/2)\n+ - Z = V<sub>z</sub> * sin(θ/2)\n \n-The rotation matrix is flattened in |targetBuffer| according to the column-major order.\n+The rotation matrix is flattened in |targetMatrix| according to the column-major order.","path":"index.bs","position":null,"original_position":43,"commit_id":"f71267aa166eba7101b64ca4d9328904a4ea94f2","original_commit_id":"b99681bdd6c68f7e38686e544b7c6a9688bc349c","user":{"login":"alexshalamov","id":1001009,"avatar_url":"https://avatars3.githubusercontent.com/u/1001009?v=3","gravatar_id":"","url":"https://api.github.com/users/alexshalamov","html_url":"https://github.com/alexshalamov","followers_url":"https://api.github.com/users/alexshalamov/followers","following_url":"https://api.github.com/users/alexshalamov/following{/other_user}","gists_url":"https://api.github.com/users/alexshalamov/gists{/gist_id}","starred_url":"https://api.github.com/users/alexshalamov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexshalamov/subscriptions","organizations_url":"https://api.github.com/users/alexshalamov/orgs","repos_url":"https://api.github.com/users/alexshalamov/repos","events_url":"https://api.github.com/users/alexshalamov/events{/privacy}","received_events_url":"https://api.github.com/users/alexshalamov/received_events","type":"User","site_admin":false},"body":"done","created_at":"2017-03-28T09:41:26Z","updated_at":"2017-03-28T09:41:26Z","html_url":"https://github.com/w3c/orientation-sensor/pull/23#discussion_r108377582","pull_request_url":"https://api.github.com/repos/w3c/orientation-sensor/pulls/23","_links":{"self":{"href":"https://api.github.com/repos/w3c/orientation-sensor/pulls/comments/108377582"},"html":{"href":"https://github.com/w3c/orientation-sensor/pull/23#discussion_r108377582"},"pull_request":{"href":"https://api.github.com/repos/w3c/orientation-sensor/pulls/23"}}},"pull_request":{"url":"https://api.github.com/repos/w3c/orientation-sensor/pulls/23","id":112451672,"html_url":"https://github.com/w3c/orientation-sensor/pull/23","diff_url":"https://github.com/w3c/orientation-sensor/pull/23.diff","patch_url":"https://github.com/w3c/orientation-sensor/pull/23.patch","issue_url":"https://api.github.com/repos/w3c/orientation-sensor/issues/23","number":23,"state":"open","locked":false,"title":"Allow other buffer types to be passed to populateMatrix","user":{"login":"alexshalamov","id":1001009,"avatar_url":"https://avatars3.githubusercontent.com/u/1001009?v=3","gravatar_id":"","url":"https://api.github.com/users/alexshalamov","html_url":"https://github.com/alexshalamov","followers_url":"https://api.github.com/users/alexshalamov/followers","following_url":"https://api.github.com/users/alexshalamov/following{/other_user}","gists_url":"https://api.github.com/users/alexshalamov/gists{/gist_id}","starred_url":"https://api.github.com/users/alexshalamov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexshalamov/subscriptions","organizations_url":"https://api.github.com/users/alexshalamov/orgs","repos_url":"https://api.github.com/users/alexshalamov/repos","events_url":"https://api.github.com/users/alexshalamov/events{/privacy}","received_events_url":"https://api.github.com/users/alexshalamov/received_events","type":"User","site_admin":false},"body":"Fixes #20\nFixes #24\n\n\n<!--\n    This comment and the below content is programatically generated.\n    You may add a comma-separated list of anchors you'd like a\n    direct link to below (e.g. #idl-serializers, #idl-sequence):\n\n    Don't remove this comment or modify anything below this line.\n    If you don't want a preview generated for this pull request,\n    just replace the whole of this comment's content by \"no preview\"\n    and remove what's below.\n-->\n***\n[Preview](https://s3.amazonaws.com/pr-preview/alexshalamov/orientation-sensor/gh-pages.html) | [Diff](https://s3.amazonaws.com/pr-preview/w3c/orientation-sensor/b842f61...alexshalamov:f71267a.html)","created_at":"2017-03-24T13:03:52Z","updated_at":"2017-03-28T09:41:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9bc12dd5efd3a678ec5b0cc1069a84fdb0918283","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/w3c/orientation-sensor/pulls/23/commits","review_comments_url":"https://api.github.com/repos/w3c/orientation-sensor/pulls/23/comments","review_comment_url":"https://api.github.com/repos/w3c/orientation-sensor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/w3c/orientation-sensor/issues/23/comments","statuses_url":"https://api.github.com/repos/w3c/orientation-sensor/statuses/f71267aa166eba7101b64ca4d9328904a4ea94f2","head":{"label":"alexshalamov:gh-pages","ref":"gh-pages","sha":"f71267aa166eba7101b64ca4d9328904a4ea94f2","user":{"login":"alexshalamov","id":1001009,"avatar_url":"https://avatars3.githubusercontent.com/u/1001009?v=3","gravatar_id":"","url":"https://api.github.com/users/alexshalamov","html_url":"https://github.com/alexshalamov","followers_url":"https://api.github.com/users/alexshalamov/followers","following_url":"https://api.github.com/users/alexshalamov/following{/other_user}","gists_url":"https://api.github.com/users/alexshalamov/gists{/gist_id}","starred_url":"https://api.github.com/users/alexshalamov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexshalamov/subscriptions","organizations_url":"https://api.github.com/users/alexshalamov/orgs","repos_url":"https://api.github.com/users/alexshalamov/repos","events_url":"https://api.github.com/users/alexshalamov/events{/privacy}","received_events_url":"https://api.github.com/users/alexshalamov/received_events","type":"User","site_admin":false},"repo":{"id":84084214,"name":"orientation-sensor","full_name":"alexshalamov/orientation-sensor","owner":{"login":"alexshalamov","id":1001009,"avatar_url":"https://avatars3.githubusercontent.com/u/1001009?v=3","gravatar_id":"","url":"https://api.github.com/users/alexshalamov","html_url":"https://github.com/alexshalamov","followers_url":"https://api.github.com/users/alexshalamov/followers","following_url":"https://api.github.com/users/alexshalamov/following{/other_user}","gists_url":"https://api.github.com/users/alexshalamov/gists{/gist_id}","starred_url":"https://api.github.com/users/alexshalamov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexshalamov/subscriptions","organizations_url":"https://api.github.com/users/alexshalamov/orgs","repos_url":"https://api.github.com/users/alexshalamov/repos","events_url":"https://api.github.com/users/alexshalamov/events{/privacy}","received_events_url":"https://api.github.com/users/alexshalamov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alexshalamov/orientation-sensor","description":null,"fork":true,"url":"https://api.github.com/repos/alexshalamov/orientation-sensor","forks_url":"https://api.github.com/repos/alexshalamov/orientation-sensor/forks","keys_url":"https://api.github.com/repos/alexshalamov/orientation-sensor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alexshalamov/orientation-sensor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alexshalamov/orientation-sensor/teams","hooks_url":"https://api.github.com/repos/alexshalamov/orientation-sensor/hooks","issue_events_url":"https://api.github.com/repos/alexshalamov/orientation-sensor/issues/events{/number}","events_url":"https://api.github.com/repos/alexshalamov/orientation-sensor/events","assignees_url":"https://api.github.com/repos/alexshalamov/orientation-sensor/assignees{/user}","branches_url":"https://api.github.com/repos/alexshalamov/orientation-sensor/branches{/branch}","tags_url":"https://api.github.com/repos/alexshalamov/orientation-sensor/tags","blobs_url":"https://api.github.com/repos/alexshalamov/orientation-sensor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alexshalamov/orientation-sensor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alexshalamov/orientation-sensor/git/refs{/sha}","trees_url":"https://api.github.com/repos/alexshalamov/orientation-sensor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alexshalamov/orientation-sensor/statuses/{sha}","languages_url":"https://api.github.com/repos/alexshalamov/orientation-sensor/languages","stargazers_url":"https://api.github.com/repos/alexshalamov/orientation-sensor/stargazers","contributors_url":"https://api.github.com/repos/alexshalamov/orientation-sensor/contributors","subscribers_url":"https://api.github.com/repos/alexshalamov/orientation-sensor/subscribers","subscription_url":"https://api.github.com/repos/alexshalamov/orientation-sensor/subscription","commits_url":"https://api.github.com/repos/alexshalamov/orientation-sensor/commits{/sha}","git_commits_url":"https://api.github.com/repos/alexshalamov/orientation-sensor/git/commits{/sha}","comments_url":"https://api.github.com/repos/alexshalamov/orientation-sensor/comments{/number}","issue_comment_url":"https://api.github.com/repos/alexshalamov/orientation-sensor/issues/comments{/number}","contents_url":"https://api.github.com/repos/alexshalamov/orientation-sensor/contents/{+path}","compare_url":"https://api.github.com/repos/alexshalamov/orientation-sensor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alexshalamov/orientation-sensor/merges","archive_url":"https://api.github.com/repos/alexshalamov/orientation-sensor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alexshalamov/orientation-sensor/downloads","issues_url":"https://api.github.com/repos/alexshalamov/orientation-sensor/issues{/number}","pulls_url":"https://api.github.com/repos/alexshalamov/orientation-sensor/pulls{/number}","milestones_url":"https://api.github.com/repos/alexshalamov/orientation-sensor/milestones{/number}","notifications_url":"https://api.github.com/repos/alexshalamov/orientation-sensor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alexshalamov/orientation-sensor/labels{/name}","releases_url":"https://api.github.com/repos/alexshalamov/orientation-sensor/releases{/id}","deployments_url":"https://api.github.com/repos/alexshalamov/orientation-sensor/deployments","created_at":"2017-03-06T14:42:34Z","updated_at":"2017-03-06T14:42:36Z","pushed_at":"2017-03-28T09:40:54Z","git_url":"git://github.com/alexshalamov/orientation-sensor.git","ssh_url":"git@github.com:alexshalamov/orientation-sensor.git","clone_url":"https://github.com/alexshalamov/orientation-sensor.git","svn_url":"https://github.com/alexshalamov/orientation-sensor","homepage":null,"size":199,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"gh-pages"}},"base":{"label":"w3c:gh-pages","ref":"gh-pages","sha":"b842f614f3aa736c764bb9529a73e1500e51961b","user":{"login":"w3c","id":379216,"avatar_url":"https://avatars1.githubusercontent.com/u/379216?v=3","gravatar_id":"","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"repo":{"id":84074882,"name":"orientation-sensor","full_name":"w3c/orientation-sensor","owner":{"login":"w3c","id":379216,"avatar_url":"https://avatars1.githubusercontent.com/u/379216?v=3","gravatar_id":"","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/w3c/orientation-sensor","description":"Orientation Sensor","fork":false,"url":"https://api.github.com/repos/w3c/orientation-sensor","forks_url":"https://api.github.com/repos/w3c/orientation-sensor/forks","keys_url":"https://api.github.com/repos/w3c/orientation-sensor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/w3c/orientation-sensor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/w3c/orientation-sensor/teams","hooks_url":"https://api.github.com/repos/w3c/orientation-sensor/hooks","issue_events_url":"https://api.github.com/repos/w3c/orientation-sensor/issues/events{/number}","events_url":"https://api.github.com/repos/w3c/orientation-sensor/events","assignees_url":"https://api.github.com/repos/w3c/orientation-sensor/assignees{/user}","branches_url":"https://api.github.com/repos/w3c/orientation-sensor/branches{/branch}","tags_url":"https://api.github.com/repos/w3c/orientation-sensor/tags","blobs_url":"https://api.github.com/repos/w3c/orientation-sensor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/w3c/orientation-sensor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/w3c/orientation-sensor/git/refs{/sha}","trees_url":"https://api.github.com/repos/w3c/orientation-sensor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/w3c/orientation-sensor/statuses/{sha}","languages_url":"https://api.github.com/repos/w3c/orientation-sensor/languages","stargazers_url":"https://api.github.com/repos/w3c/orientation-sensor/stargazers","contributors_url":"https://api.github.com/repos/w3c/orientation-sensor/contributors","subscribers_url":"https://api.github.com/repos/w3c/orientation-sensor/subscribers","subscription_url":"https://api.github.com/repos/w3c/orientation-sensor/subscription","commits_url":"https://api.github.com/repos/w3c/orientation-sensor/commits{/sha}","git_commits_url":"https://api.github.com/repos/w3c/orientation-sensor/git/commits{/sha}","comments_url":"https://api.github.com/repos/w3c/orientation-sensor/comments{/number}","issue_comment_url":"https://api.github.com/repos/w3c/orientation-sensor/issues/comments{/number}","contents_url":"https://api.github.com/repos/w3c/orientation-sensor/contents/{+path}","compare_url":"https://api.github.com/repos/w3c/orientation-sensor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/w3c/orientation-sensor/merges","archive_url":"https://api.github.com/repos/w3c/orientation-sensor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/w3c/orientation-sensor/downloads","issues_url":"https://api.github.com/repos/w3c/orientation-sensor/issues{/number}","pulls_url":"https://api.github.com/repos/w3c/orientation-sensor/pulls{/number}","milestones_url":"https://api.github.com/repos/w3c/orientation-sensor/milestones{/number}","notifications_url":"https://api.github.com/repos/w3c/orientation-sensor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/w3c/orientation-sensor/labels{/name}","releases_url":"https://api.github.com/repos/w3c/orientation-sensor/releases{/id}","deployments_url":"https://api.github.com/repos/w3c/orientation-sensor/deployments","created_at":"2017-03-06T13:14:35Z","updated_at":"2017-03-18T05:41:48Z","pushed_at":"2017-03-28T09:40:55Z","git_url":"git://github.com/w3c/orientation-sensor.git","ssh_url":"git@github.com:w3c/orientation-sensor.git","clone_url":"https://github.com/w3c/orientation-sensor.git","svn_url":"https://github.com/w3c/orientation-sensor","homepage":"https://w3c.github.com/orientation-sensor/","size":170,"stargazers_count":2,"watchers_count":2,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4,"mirror_url":null,"open_issues_count":5,"forks":4,"open_issues":5,"watchers":2,"default_branch":"gh-pages"}},"_links":{"self":{"href":"https://api.github.com/repos/w3c/orientation-sensor/pulls/23"},"html":{"href":"https://github.com/w3c/orientation-sensor/pull/23"},"issue":{"href":"https://api.github.com/repos/w3c/orientation-sensor/issues/23"},"comments":{"href":"https://api.github.com/repos/w3c/orientation-sensor/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/w3c/orientation-sensor/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/w3c/orientation-sensor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/w3c/orientation-sensor/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/w3c/orientation-sensor/statuses/f71267aa166eba7101b64ca4d9328904a4ea94f2"}}}}
{"actor":{"display_login":"alexshalamov"}}