{"action":"created","comment":{"url":"https://api.github.com/repos/apple/swift/pulls/comments/110946181","pull_request_review_id":32154514,"id":110946181,"diff_hunk":"@@ -2988,8 +2988,8 @@ ERROR(invalid_objc_decl,none,\n ERROR(invalid_objc_swift_rooted_class,none,\n       \"only classes that inherit from NSObject can be declared @objc\", ())\n ERROR(invalid_nonobjc_decl,none,\n-      \"only methods, initializers, properties and subscript declarations can \"\n-      \"be declared @nonobjc\", ())\n+      \"@nonobjc can only be used with members of classes, @objc protocols, and \"","path":"include/swift/AST/DiagnosticsSema.def","position":15,"original_position":15,"commit_id":"45426c592679573aa6c5c7e0f4e0cff31a852226","original_commit_id":"45426c592679573aa6c5c7e0f4e0cff31a852226","user":{"login":"jrose-apple","id":15097531,"avatar_url":"https://avatars1.githubusercontent.com/u/15097531?v=3","gravatar_id":"","url":"https://api.github.com/users/jrose-apple","html_url":"https://github.com/jrose-apple","followers_url":"https://api.github.com/users/jrose-apple/followers","following_url":"https://api.github.com/users/jrose-apple/following{/other_user}","gists_url":"https://api.github.com/users/jrose-apple/gists{/gist_id}","starred_url":"https://api.github.com/users/jrose-apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrose-apple/subscriptions","organizations_url":"https://api.github.com/users/jrose-apple/orgs","repos_url":"https://api.github.com/users/jrose-apple/repos","events_url":"https://api.github.com/users/jrose-apple/events{/privacy}","received_events_url":"https://api.github.com/users/jrose-apple/received_events","type":"User","site_admin":false},"body":"Hm. `@nonobjc` can't actually be used with members of `@objc` protocols. It also doesn't quite make sense to note that extensions of classes must be \"concrete\"; for non-concrete extensions, `@nonobjc` is unnecessary because it's the default, not because it's disallowed.\r\n\r\n(In theory you should also be able to put `@nonobjc` on a class that inherits from NSObject, but I don't think we added that feature.)","created_at":"2017-04-11T16:12:44Z","updated_at":"2017-04-11T16:12:44Z","html_url":"https://github.com/apple/swift/pull/8480#discussion_r110946181","pull_request_url":"https://api.github.com/repos/apple/swift/pulls/8480","_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/comments/110946181"},"html":{"href":"https://github.com/apple/swift/pull/8480#discussion_r110946181"},"pull_request":{"href":"https://api.github.com/repos/apple/swift/pulls/8480"}}},"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/8480","id":113782211,"html_url":"https://github.com/apple/swift/pull/8480","diff_url":"https://github.com/apple/swift/pull/8480.diff","patch_url":"https://github.com/apple/swift/pull/8480.patch","issue_url":"https://api.github.com/repos/apple/swift/issues/8480","number":8480,"state":"open","locked":false,"title":"[SEMA][SR4226] Change emitted error for @nonobjc attribute","user":{"login":"JGiola","id":6539031,"avatar_url":"https://avatars3.githubusercontent.com/u/6539031?v=3","gravatar_id":"","url":"https://api.github.com/users/JGiola","html_url":"https://github.com/JGiola","followers_url":"https://api.github.com/users/JGiola/followers","following_url":"https://api.github.com/users/JGiola/following{/other_user}","gists_url":"https://api.github.com/users/JGiola/gists{/gist_id}","starred_url":"https://api.github.com/users/JGiola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JGiola/subscriptions","organizations_url":"https://api.github.com/users/JGiola/orgs","repos_url":"https://api.github.com/users/JGiola/repos","events_url":"https://api.github.com/users/JGiola/events{/privacy}","received_events_url":"https://api.github.com/users/JGiola/received_events","type":"User","site_admin":false},"body":"Resolves [SR-4226](https://bugs.swift.org/browse/SR-4226)\r\n\r\nThe error emitted when the `@nonobjc` attribute is misused was a little bit confusing, I have update it with the similar one used for `@objc`","created_at":"2017-04-01T15:04:09Z","updated_at":"2017-04-11T16:12:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f323698d156c594e58cb5dacba729685c8bb3458","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift/pulls/8480/commits","review_comments_url":"https://api.github.com/repos/apple/swift/pulls/8480/comments","review_comment_url":"https://api.github.com/repos/apple/swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift/issues/8480/comments","statuses_url":"https://api.github.com/repos/apple/swift/statuses/45426c592679573aa6c5c7e0f4e0cff31a852226","head":{"label":"JGiola:fix-sr4226","ref":"fix-sr4226","sha":"45426c592679573aa6c5c7e0f4e0cff31a852226","user":{"login":"JGiola","id":6539031,"avatar_url":"https://avatars3.githubusercontent.com/u/6539031?v=3","gravatar_id":"","url":"https://api.github.com/users/JGiola","html_url":"https://github.com/JGiola","followers_url":"https://api.github.com/users/JGiola/followers","following_url":"https://api.github.com/users/JGiola/following{/other_user}","gists_url":"https://api.github.com/users/JGiola/gists{/gist_id}","starred_url":"https://api.github.com/users/JGiola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JGiola/subscriptions","organizations_url":"https://api.github.com/users/JGiola/orgs","repos_url":"https://api.github.com/users/JGiola/repos","events_url":"https://api.github.com/users/JGiola/events{/privacy}","received_events_url":"https://api.github.com/users/JGiola/received_events","type":"User","site_admin":false},"repo":{"id":47507495,"name":"swift","full_name":"JGiola/swift","owner":{"login":"JGiola","id":6539031,"avatar_url":"https://avatars3.githubusercontent.com/u/6539031?v=3","gravatar_id":"","url":"https://api.github.com/users/JGiola","html_url":"https://github.com/JGiola","followers_url":"https://api.github.com/users/JGiola/followers","following_url":"https://api.github.com/users/JGiola/following{/other_user}","gists_url":"https://api.github.com/users/JGiola/gists{/gist_id}","starred_url":"https://api.github.com/users/JGiola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JGiola/subscriptions","organizations_url":"https://api.github.com/users/JGiola/orgs","repos_url":"https://api.github.com/users/JGiola/repos","events_url":"https://api.github.com/users/JGiola/events{/privacy}","received_events_url":"https://api.github.com/users/JGiola/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JGiola/swift","description":"The Swift Programming Language","fork":true,"url":"https://api.github.com/repos/JGiola/swift","forks_url":"https://api.github.com/repos/JGiola/swift/forks","keys_url":"https://api.github.com/repos/JGiola/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JGiola/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JGiola/swift/teams","hooks_url":"https://api.github.com/repos/JGiola/swift/hooks","issue_events_url":"https://api.github.com/repos/JGiola/swift/issues/events{/number}","events_url":"https://api.github.com/repos/JGiola/swift/events","assignees_url":"https://api.github.com/repos/JGiola/swift/assignees{/user}","branches_url":"https://api.github.com/repos/JGiola/swift/branches{/branch}","tags_url":"https://api.github.com/repos/JGiola/swift/tags","blobs_url":"https://api.github.com/repos/JGiola/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JGiola/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JGiola/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/JGiola/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JGiola/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/JGiola/swift/languages","stargazers_url":"https://api.github.com/repos/JGiola/swift/stargazers","contributors_url":"https://api.github.com/repos/JGiola/swift/contributors","subscribers_url":"https://api.github.com/repos/JGiola/swift/subscribers","subscription_url":"https://api.github.com/repos/JGiola/swift/subscription","commits_url":"https://api.github.com/repos/JGiola/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/JGiola/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/JGiola/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/JGiola/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/JGiola/swift/contents/{+path}","compare_url":"https://api.github.com/repos/JGiola/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JGiola/swift/merges","archive_url":"https://api.github.com/repos/JGiola/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JGiola/swift/downloads","issues_url":"https://api.github.com/repos/JGiola/swift/issues{/number}","pulls_url":"https://api.github.com/repos/JGiola/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/JGiola/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/JGiola/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JGiola/swift/labels{/name}","releases_url":"https://api.github.com/repos/JGiola/swift/releases{/id}","deployments_url":"https://api.github.com/repos/JGiola/swift/deployments","created_at":"2015-12-06T18:03:17Z","updated_at":"2016-01-12T09:03:24Z","pushed_at":"2017-04-11T12:18:23Z","git_url":"git://github.com/JGiola/swift.git","ssh_url":"git@github.com:JGiola/swift.git","clone_url":"https://github.com/JGiola/swift.git","svn_url":"https://github.com/JGiola/swift","homepage":"","size":174072,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"3623d408cab9b22108841984156d1d11f3f19e9a","user":{"login":"apple","id":10639145,"avatar_url":"https://avatars3.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838949,"name":"swift","full_name":"apple/swift","owner":{"login":"apple","id":10639145,"avatar_url":"https://avatars3.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/swift","description":"The Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift","forks_url":"https://api.github.com/repos/apple/swift/forks","keys_url":"https://api.github.com/repos/apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift/teams","hooks_url":"https://api.github.com/repos/apple/swift/hooks","issue_events_url":"https://api.github.com/repos/apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift/events","assignees_url":"https://api.github.com/repos/apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift/tags","blobs_url":"https://api.github.com/repos/apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift/languages","stargazers_url":"https://api.github.com/repos/apple/swift/stargazers","contributors_url":"https://api.github.com/repos/apple/swift/contributors","subscribers_url":"https://api.github.com/repos/apple/swift/subscribers","subscription_url":"https://api.github.com/repos/apple/swift/subscription","commits_url":"https://api.github.com/repos/apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift/merges","archive_url":"https://api.github.com/repos/apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift/downloads","issues_url":"https://api.github.com/repos/apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift/deployments","created_at":"2015-10-23T21:15:07Z","updated_at":"2017-04-11T16:03:49Z","pushed_at":"2017-04-11T15:47:26Z","git_url":"git://github.com/apple/swift.git","ssh_url":"git@github.com:apple/swift.git","clone_url":"https://github.com/apple/swift.git","svn_url":"https://github.com/apple/swift","homepage":"https://swift.org/","size":185071,"stargazers_count":37832,"watchers_count":37832,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5624,"mirror_url":null,"open_issues_count":159,"forks":5624,"open_issues":159,"watchers":37832,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/8480"},"html":{"href":"https://github.com/apple/swift/pull/8480"},"issue":{"href":"https://api.github.com/repos/apple/swift/issues/8480"},"comments":{"href":"https://api.github.com/repos/apple/swift/issues/8480/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift/pulls/8480/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift/pulls/8480/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift/statuses/45426c592679573aa6c5c7e0f4e0cff31a852226"}}}}
{"actor":{"display_login":"jrose-apple"}}