{"action":"created","issue":{"url":"https://api.github.com/repos/emu-rs/rustual-boy/issues/17","repository_url":"https://api.github.com/repos/emu-rs/rustual-boy","labels_url":"https://api.github.com/repos/emu-rs/rustual-boy/issues/17/labels{/name}","comments_url":"https://api.github.com/repos/emu-rs/rustual-boy/issues/17/comments","events_url":"https://api.github.com/repos/emu-rs/rustual-boy/issues/17/events","html_url":"https://github.com/emu-rs/rustual-boy/pull/17","id":206396416,"number":17,"title":"[WIP] Initial implementation of middleware, supporting common mode anaglyph rendering","user":{"login":"bobtwinkles","id":1514748,"avatar_url":"https://avatars.githubusercontent.com/u/1514748?v=3","gravatar_id":"","url":"https://api.github.com/users/bobtwinkles","html_url":"https://github.com/bobtwinkles","followers_url":"https://api.github.com/users/bobtwinkles/followers","following_url":"https://api.github.com/users/bobtwinkles/following{/other_user}","gists_url":"https://api.github.com/users/bobtwinkles/gists{/gist_id}","starred_url":"https://api.github.com/users/bobtwinkles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bobtwinkles/subscriptions","organizations_url":"https://api.github.com/users/bobtwinkles/orgs","repos_url":"https://api.github.com/users/bobtwinkles/repos","events_url":"https://api.github.com/users/bobtwinkles/events{/privacy}","received_events_url":"https://api.github.com/users/bobtwinkles/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":15,"created_at":"2017-02-09T03:47:07Z","updated_at":"2017-02-10T20:59:14Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/emu-rs/rustual-boy/pulls/17","html_url":"https://github.com/emu-rs/rustual-boy/pull/17","diff_url":"https://github.com/emu-rs/rustual-boy/pull/17.diff","patch_url":"https://github.com/emu-rs/rustual-boy/pull/17.patch"},"body":"PR to support common mode anaglyph rendering through an intermediate crate (`rustual-boy-middleware`). Marked as WIP because I'd like I'd like feedback on the anaglyph implementation;\r\n  - The mixing stage is pretty expensive right now (lots of casting to floats and doing math and back to integers) and can probably be \"cuter\" but it'll probably be less clear. It seems fast enough for now, but I haven't run any numbers to see if that's sustainable\r\n  - I'm also not confident that the color mixing is correct because color spaces bend my brain a bit. Additive is probably good enough but I think to be technically correct we should be converting from the response curve of the VB LEDs -> linear, performing the addition, and then converting from linear to sRGB.\r\n  - Not sure how I feel about rolling our own color type. I'm not really sure where we would pull it from without adding a bunch of unnecessary dependencies though."},"comment":{"url":"https://api.github.com/repos/emu-rs/rustual-boy/issues/comments/279064221","html_url":"https://github.com/emu-rs/rustual-boy/pull/17#issuecomment-279064221","issue_url":"https://api.github.com/repos/emu-rs/rustual-boy/issues/17","id":279064221,"user":{"login":"yupferris","id":3166056,"avatar_url":"https://avatars.githubusercontent.com/u/3166056?v=3","gravatar_id":"","url":"https://api.github.com/users/yupferris","html_url":"https://github.com/yupferris","followers_url":"https://api.github.com/users/yupferris/followers","following_url":"https://api.github.com/users/yupferris/following{/other_user}","gists_url":"https://api.github.com/users/yupferris/gists{/gist_id}","starred_url":"https://api.github.com/users/yupferris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yupferris/subscriptions","organizations_url":"https://api.github.com/users/yupferris/orgs","repos_url":"https://api.github.com/users/yupferris/repos","events_url":"https://api.github.com/users/yupferris/events{/privacy}","received_events_url":"https://api.github.com/users/yupferris/received_events","type":"User","site_admin":false},"created_at":"2017-02-10T20:59:14Z","updated_at":"2017-02-10T20:59:14Z","body":"Ah yeah, actually we might not want to move `CpalDriver` at least to keep the middleware dependencies low, but we'll see."}}
{"actor":{"display_login":"yupferris"}}