{"action":"created","issue":{"url":"https://api.github.com/repos/openhab/openhab2-addons/issues/2698","repository_url":"https://api.github.com/repos/openhab/openhab2-addons","labels_url":"https://api.github.com/repos/openhab/openhab2-addons/issues/2698/labels{/name}","comments_url":"https://api.github.com/repos/openhab/openhab2-addons/issues/2698/comments","events_url":"https://api.github.com/repos/openhab/openhab2-addons/issues/2698/events","html_url":"https://github.com/openhab/openhab2-addons/pull/2698","id":256826481,"number":2698,"title":"[WIP] [NEST] Some improvements of NEST binding","user":{"login":"martinvw","id":2625279,"avatar_url":"https://avatars3.githubusercontent.com/u/2625279?v=4","gravatar_id":"","url":"https://api.github.com/users/martinvw","html_url":"https://github.com/martinvw","followers_url":"https://api.github.com/users/martinvw/followers","following_url":"https://api.github.com/users/martinvw/following{/other_user}","gists_url":"https://api.github.com/users/martinvw/gists{/gist_id}","starred_url":"https://api.github.com/users/martinvw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinvw/subscriptions","organizations_url":"https://api.github.com/users/martinvw/orgs","repos_url":"https://api.github.com/users/martinvw/repos","events_url":"https://api.github.com/users/martinvw/events{/privacy}","received_events_url":"https://api.github.com/users/martinvw/received_events","type":"User","site_admin":false},"labels":[{"id":614488707,"url":"https://api.github.com/repos/openhab/openhab2-addons/labels/Work%20in%20progress","name":"Work in progress","color":"bfdadc","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2017-09-11T20:08:33Z","updated_at":"2017-09-12T21:26:06Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/openhab/openhab2-addons/pulls/2698","html_url":"https://github.com/openhab/openhab2-addons/pull/2698","diff_url":"https://github.com/openhab/openhab2-addons/pull/2698.diff","patch_url":"https://github.com/openhab/openhab2-addons/pull/2698.patch"},"body":"* Because of some duplicate channels, I decided to move them to a separate file\r\n* All the channels of the smoke sensor are now read only, as it is according to api docs\r\n* The format of the smoke / co reports in the structure is the same now\r\n* removed duplicate cache (disk and property)\r\n* Added a parent class to the `NestHandlers`\r\n* Moved some files to internal packages\r\n* removed check before publishing the same update\r\n* Removed (now) unused equals methods\r\n* Introduced an InvalidAccessTokenException to wrap the different failure when requesting an access token, also fail when it actually happens\r\n* Put String literals on the left to avoid NPE's\r\n* Add a builder to the NestUpdateRequest\r\n* Use listeners for all data processing so not only for discovery\r\n* Add some `@NonNull`'s to resolve warnings\r\n* Use the SmartHome `HttpUtil`\r\n* Corrected some celcius -> Celsius\r\n* Remove Guava dependency\r\n* Re-use the GSON instances\r\n\r\nWork in progress:\r\n\r\n* allow for actual expiration of the access token, refresh it only in that case\r\n* Validate that we can actually send data to Nest\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/openhab/openhab2-addons/issues/comments/328989068","html_url":"https://github.com/openhab/openhab2-addons/pull/2698#issuecomment-328989068","issue_url":"https://api.github.com/repos/openhab/openhab2-addons/issues/2698","id":328989068,"user":{"login":"pinkfish","id":2549297,"avatar_url":"https://avatars0.githubusercontent.com/u/2549297?v=4","gravatar_id":"","url":"https://api.github.com/users/pinkfish","html_url":"https://github.com/pinkfish","followers_url":"https://api.github.com/users/pinkfish/followers","following_url":"https://api.github.com/users/pinkfish/following{/other_user}","gists_url":"https://api.github.com/users/pinkfish/gists{/gist_id}","starred_url":"https://api.github.com/users/pinkfish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pinkfish/subscriptions","organizations_url":"https://api.github.com/users/pinkfish/orgs","repos_url":"https://api.github.com/users/pinkfish/repos","events_url":"https://api.github.com/users/pinkfish/events{/privacy}","received_events_url":"https://api.github.com/users/pinkfish/received_events","type":"User","site_admin":false},"created_at":"2017-09-12T21:26:06Z","updated_at":"2017-09-12T21:26:06Z","author_association":"CONTRIBUTOR","body":"Yes nest home simulator is extremely useful for testing things outside the\nnormal set\n\nOn Sep 12, 2017 2:19 PM, \"Wouter Born\" <notifications@github.com> wrote:\n\n> Nest Home Simulator\n> <https://developers.nest.com/documentation/cloud/home-simulator>\n>\n> A key part of development is to test your product and try out actual\n> device conditions (situations that may be difficult to create in real\n> life), but we've got you covered. This self-contained application\n> (available from the Chrome Web Store) creates virtual devices that simulate\n> conditions that otherwise would be expensive and time-consuming to\n> replicate.\n>\n> Get the Nest Home Simulator from the Chrome Web Store\n> <https://chrome.google.com/webstore/detail/nest-home-simulator/jmcapoebgeaabepohkchkldlfhchkega>\n>\n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/openhab/openhab2-addons/pull/2698#issuecomment-328987448>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/ACbmMaBGNxyRnl7_SSQJUIgEU-694NGnks5shvVggaJpZM4PTs7g>\n> .\n>\n"}}
{"actor":{"display_login":"pinkfish"}}