{"action":"created","comment":{"url":"https://api.github.com/repos/flutter/flutter/pulls/comments/153565310","pull_request_review_id":79589241,"id":153565310,"diff_hunk":"@@ -177,7 +177,8 @@ class CalculationManager {\n   //\n   // Static and global variables are initialized anew in the spawned isolate,\n   // in a separate memory space.\n-  static void _calculate(CalculationMessage message) {\n+  static void _calculate(Object isolateData) {","path":"examples/layers/services/isolate.dart","position":5,"original_position":5,"commit_id":"c9fc780c5cc5e6f258080853734e7d8d3d380d7c","original_commit_id":"c9fc780c5cc5e6f258080853734e7d8d3d380d7c","user":{"login":"Hixie","id":551196,"avatar_url":"https://avatars2.githubusercontent.com/u/551196?v=4","gravatar_id":"","url":"https://api.github.com/users/Hixie","html_url":"https://github.com/Hixie","followers_url":"https://api.github.com/users/Hixie/followers","following_url":"https://api.github.com/users/Hixie/following{/other_user}","gists_url":"https://api.github.com/users/Hixie/gists{/gist_id}","starred_url":"https://api.github.com/users/Hixie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hixie/subscriptions","organizations_url":"https://api.github.com/users/Hixie/orgs","repos_url":"https://api.github.com/users/Hixie/repos","events_url":"https://api.github.com/users/Hixie/events{/privacy}","received_events_url":"https://api.github.com/users/Hixie/received_events","type":"User","site_admin":false},"body":"This change seems very unfortunate.","created_at":"2017-11-28T17:28:22Z","updated_at":"2017-11-28T17:28:23Z","html_url":"https://github.com/flutter/flutter/pull/13223#discussion_r153565310","pull_request_url":"https://api.github.com/repos/flutter/flutter/pulls/13223","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments/153565310"},"html":{"href":"https://github.com/flutter/flutter/pull/13223#discussion_r153565310"},"pull_request":{"href":"https://api.github.com/repos/flutter/flutter/pulls/13223"}}},"pull_request":{"url":"https://api.github.com/repos/flutter/flutter/pulls/13223","id":154983865,"html_url":"https://github.com/flutter/flutter/pull/13223","diff_url":"https://github.com/flutter/flutter/pull/13223.diff","patch_url":"https://github.com/flutter/flutter/pull/13223.patch","issue_url":"https://api.github.com/repos/flutter/flutter/issues/13223","number":13223,"state":"open","locked":false,"title":"Fix Dart 2.0 related issues in examples, packages/flutter, dev/benchmarks","user":{"login":"leafpetersen","id":8484504,"avatar_url":"https://avatars1.githubusercontent.com/u/8484504?v=4","gravatar_id":"","url":"https://api.github.com/users/leafpetersen","html_url":"https://github.com/leafpetersen","followers_url":"https://api.github.com/users/leafpetersen/followers","following_url":"https://api.github.com/users/leafpetersen/following{/other_user}","gists_url":"https://api.github.com/users/leafpetersen/gists{/gist_id}","starred_url":"https://api.github.com/users/leafpetersen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leafpetersen/subscriptions","organizations_url":"https://api.github.com/users/leafpetersen/orgs","repos_url":"https://api.github.com/users/leafpetersen/repos","events_url":"https://api.github.com/users/leafpetersen/events{/privacy}","received_events_url":"https://api.github.com/users/leafpetersen/received_events","type":"User","site_admin":false},"body":"Not for landing, just for discussion.\r\n\r\ncc @Hixie @mit-mit @a14n @munificent @devoncarew @floitschG \r\n\r\nI took a quick hack at fixing the 2.0 roll related issues just so we'd have something concrete to talk about.\r\n\r\nI believe this fixes all of the errors under the above directories except what look like a bunch of unrelated lints under examples/stock (it's possible I missed something, since I may not be analyzing this code the way it's intended, but I think I caught everything).  \r\n\r\nThoughts?  There are only a couple of fromIterable changes: for those I went with the `for in` solution, but could do something else there as discussed.  The rest is mostly places where a typed callback is passed to an untyped context (a context that is typed to pass `dynamic` to the callback).  Presumably there are invariants that are not caught by the type system as to why these are safe.  I just changed those callbacks to do an implicit downcast from an untyped parameter to a typed local.\r\n","created_at":"2017-11-28T05:39:10Z","updated_at":"2017-11-28T17:28:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c65a5272fa47914378e5d801c0bef31e8d683bfd","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/flutter/flutter/pulls/13223/commits","review_comments_url":"https://api.github.com/repos/flutter/flutter/pulls/13223/comments","review_comment_url":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flutter/flutter/issues/13223/comments","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/c9fc780c5cc5e6f258080853734e7d8d3d380d7c","head":{"label":"leafpetersen:fix_fuzzy_arrows","ref":"fix_fuzzy_arrows","sha":"c9fc780c5cc5e6f258080853734e7d8d3d380d7c","user":{"login":"leafpetersen","id":8484504,"avatar_url":"https://avatars1.githubusercontent.com/u/8484504?v=4","gravatar_id":"","url":"https://api.github.com/users/leafpetersen","html_url":"https://github.com/leafpetersen","followers_url":"https://api.github.com/users/leafpetersen/followers","following_url":"https://api.github.com/users/leafpetersen/following{/other_user}","gists_url":"https://api.github.com/users/leafpetersen/gists{/gist_id}","starred_url":"https://api.github.com/users/leafpetersen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leafpetersen/subscriptions","organizations_url":"https://api.github.com/users/leafpetersen/orgs","repos_url":"https://api.github.com/users/leafpetersen/repos","events_url":"https://api.github.com/users/leafpetersen/events{/privacy}","received_events_url":"https://api.github.com/users/leafpetersen/received_events","type":"User","site_admin":false},"repo":{"id":112289613,"name":"flutter","full_name":"leafpetersen/flutter","owner":{"login":"leafpetersen","id":8484504,"avatar_url":"https://avatars1.githubusercontent.com/u/8484504?v=4","gravatar_id":"","url":"https://api.github.com/users/leafpetersen","html_url":"https://github.com/leafpetersen","followers_url":"https://api.github.com/users/leafpetersen/followers","following_url":"https://api.github.com/users/leafpetersen/following{/other_user}","gists_url":"https://api.github.com/users/leafpetersen/gists{/gist_id}","starred_url":"https://api.github.com/users/leafpetersen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leafpetersen/subscriptions","organizations_url":"https://api.github.com/users/leafpetersen/orgs","repos_url":"https://api.github.com/users/leafpetersen/repos","events_url":"https://api.github.com/users/leafpetersen/events{/privacy}","received_events_url":"https://api.github.com/users/leafpetersen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/leafpetersen/flutter","description":"Flutter makes it easy and fast to build beautiful mobile apps.","fork":true,"url":"https://api.github.com/repos/leafpetersen/flutter","forks_url":"https://api.github.com/repos/leafpetersen/flutter/forks","keys_url":"https://api.github.com/repos/leafpetersen/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/leafpetersen/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/leafpetersen/flutter/teams","hooks_url":"https://api.github.com/repos/leafpetersen/flutter/hooks","issue_events_url":"https://api.github.com/repos/leafpetersen/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/leafpetersen/flutter/events","assignees_url":"https://api.github.com/repos/leafpetersen/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/leafpetersen/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/leafpetersen/flutter/tags","blobs_url":"https://api.github.com/repos/leafpetersen/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/leafpetersen/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/leafpetersen/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/leafpetersen/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/leafpetersen/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/leafpetersen/flutter/languages","stargazers_url":"https://api.github.com/repos/leafpetersen/flutter/stargazers","contributors_url":"https://api.github.com/repos/leafpetersen/flutter/contributors","subscribers_url":"https://api.github.com/repos/leafpetersen/flutter/subscribers","subscription_url":"https://api.github.com/repos/leafpetersen/flutter/subscription","commits_url":"https://api.github.com/repos/leafpetersen/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/leafpetersen/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/leafpetersen/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/leafpetersen/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/leafpetersen/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/leafpetersen/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/leafpetersen/flutter/merges","archive_url":"https://api.github.com/repos/leafpetersen/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/leafpetersen/flutter/downloads","issues_url":"https://api.github.com/repos/leafpetersen/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/leafpetersen/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/leafpetersen/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/leafpetersen/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/leafpetersen/flutter/labels{/name}","releases_url":"https://api.github.com/repos/leafpetersen/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/leafpetersen/flutter/deployments","created_at":"2017-11-28T05:21:37Z","updated_at":"2017-11-28T05:21:43Z","pushed_at":"2017-11-28T05:27:01Z","git_url":"git://github.com/leafpetersen/flutter.git","ssh_url":"git@github.com:leafpetersen/flutter.git","clone_url":"https://github.com/leafpetersen/flutter.git","svn_url":"https://github.com/leafpetersen/flutter","homepage":"https://flutter.io","size":31466,"stargazers_count":0,"watchers_count":0,"language":"Dart","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flutter:master","ref":"master","sha":"c182e0e517cf6da688b3f9ff441341a860374eb8","user":{"login":"flutter","id":14101776,"avatar_url":"https://avatars3.githubusercontent.com/u/14101776?v=4","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"repo":{"id":31792824,"name":"flutter","full_name":"flutter/flutter","owner":{"login":"flutter","id":14101776,"avatar_url":"https://avatars3.githubusercontent.com/u/14101776?v=4","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/flutter/flutter","description":"Flutter makes it easy and fast to build beautiful mobile apps.","fork":false,"url":"https://api.github.com/repos/flutter/flutter","forks_url":"https://api.github.com/repos/flutter/flutter/forks","keys_url":"https://api.github.com/repos/flutter/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flutter/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flutter/flutter/teams","hooks_url":"https://api.github.com/repos/flutter/flutter/hooks","issue_events_url":"https://api.github.com/repos/flutter/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/flutter/flutter/events","assignees_url":"https://api.github.com/repos/flutter/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/flutter/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/flutter/flutter/tags","blobs_url":"https://api.github.com/repos/flutter/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flutter/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flutter/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/flutter/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/flutter/flutter/languages","stargazers_url":"https://api.github.com/repos/flutter/flutter/stargazers","contributors_url":"https://api.github.com/repos/flutter/flutter/contributors","subscribers_url":"https://api.github.com/repos/flutter/flutter/subscribers","subscription_url":"https://api.github.com/repos/flutter/flutter/subscription","commits_url":"https://api.github.com/repos/flutter/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/flutter/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/flutter/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/flutter/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/flutter/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/flutter/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flutter/flutter/merges","archive_url":"https://api.github.com/repos/flutter/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flutter/flutter/downloads","issues_url":"https://api.github.com/repos/flutter/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/flutter/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/flutter/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/flutter/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flutter/flutter/labels{/name}","releases_url":"https://api.github.com/repos/flutter/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/flutter/flutter/deployments","created_at":"2015-03-06T22:54:58Z","updated_at":"2017-11-28T17:22:13Z","pushed_at":"2017-11-28T17:26:06Z","git_url":"git://github.com/flutter/flutter.git","ssh_url":"git@github.com:flutter/flutter.git","clone_url":"https://github.com/flutter/flutter.git","svn_url":"https://github.com/flutter/flutter","homepage":"https://flutter.io","size":31462,"stargazers_count":8700,"watchers_count":8700,"language":"Dart","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":812,"mirror_url":null,"archived":false,"open_issues_count":2016,"forks":812,"open_issues":2016,"watchers":8700,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/13223"},"html":{"href":"https://github.com/flutter/flutter/pull/13223"},"issue":{"href":"https://api.github.com/repos/flutter/flutter/issues/13223"},"comments":{"href":"https://api.github.com/repos/flutter/flutter/issues/13223/comments"},"review_comments":{"href":"https://api.github.com/repos/flutter/flutter/pulls/13223/comments"},"review_comment":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flutter/flutter/pulls/13223/commits"},"statuses":{"href":"https://api.github.com/repos/flutter/flutter/statuses/c9fc780c5cc5e6f258080853734e7d8d3d380d7c"}},"author_association":"NONE"}}
{"actor":{"display_login":"Hixie"}}