{"action":"created","issue":{"url":"https://api.github.com/repos/Minecolonies/minecolonies/issues/1881","repository_url":"https://api.github.com/repos/Minecolonies/minecolonies","labels_url":"https://api.github.com/repos/Minecolonies/minecolonies/issues/1881/labels{/name}","comments_url":"https://api.github.com/repos/Minecolonies/minecolonies/issues/1881/comments","events_url":"https://api.github.com/repos/Minecolonies/minecolonies/issues/1881/events","html_url":"https://github.com/Minecolonies/minecolonies/pull/1881","id":283367119,"number":1881,"title":"Default style setting","user":{"login":"Raycoms","id":6438347,"avatar_url":"https://avatars1.githubusercontent.com/u/6438347?v=4","gravatar_id":"","url":"https://api.github.com/users/Raycoms","html_url":"https://github.com/Raycoms","followers_url":"https://api.github.com/users/Raycoms/followers","following_url":"https://api.github.com/users/Raycoms/following{/other_user}","gists_url":"https://api.github.com/users/Raycoms/gists{/gist_id}","starred_url":"https://api.github.com/users/Raycoms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Raycoms/subscriptions","organizations_url":"https://api.github.com/users/Raycoms/orgs","repos_url":"https://api.github.com/users/Raycoms/repos","events_url":"https://api.github.com/users/Raycoms/events{/privacy}","received_events_url":"https://api.github.com/users/Raycoms/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-12-19T20:57:37Z","updated_at":"2017-12-19T22:52:03Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/Minecolonies/minecolonies/pulls/1881","html_url":"https://github.com/Minecolonies/minecolonies/pull/1881","diff_url":"https://github.com/Minecolonies/minecolonies/pull/1881.diff","patch_url":"https://github.com/Minecolonies/minecolonies/pull/1881.patch"},"body":"Closes #1876\r\n\r\n# Changes proposed in this pull request:\r\n- Store the townhall style in the colony and adapt it as default style to the buildings.\r\n\r\nReview please\r\n"},"comment":{"url":"https://api.github.com/repos/Minecolonies/minecolonies/issues/comments/352911298","html_url":"https://github.com/Minecolonies/minecolonies/pull/1881#issuecomment-352911298","issue_url":"https://api.github.com/repos/Minecolonies/minecolonies/issues/1881","id":352911298,"user":{"login":"BuildTeamLinter","id":30551110,"avatar_url":"https://avatars0.githubusercontent.com/u/30551110?v=4","gravatar_id":"","url":"https://api.github.com/users/BuildTeamLinter","html_url":"https://github.com/BuildTeamLinter","followers_url":"https://api.github.com/users/BuildTeamLinter/followers","following_url":"https://api.github.com/users/BuildTeamLinter/following{/other_user}","gists_url":"https://api.github.com/users/BuildTeamLinter/gists{/gist_id}","starred_url":"https://api.github.com/users/BuildTeamLinter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BuildTeamLinter/subscriptions","organizations_url":"https://api.github.com/users/BuildTeamLinter/orgs","repos_url":"https://api.github.com/users/BuildTeamLinter/repos","events_url":"https://api.github.com/users/BuildTeamLinter/events{/privacy}","received_events_url":"https://api.github.com/users/BuildTeamLinter/received_events","type":"User","site_admin":false},"created_at":"2017-12-19T22:52:03Z","updated_at":"2017-12-19T22:52:03Z","author_association":"NONE","body":"SonarQube analysis reported 71 issues\n* ![MAJOR][MAJOR] 17 major\n* ![MINOR][MINOR] 50 minor\n* ![INFO][INFO] 4 info\n\n#### Top 10 extra issues\n\nNote: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:\n\n1. ![MAJOR][MAJOR] [Colony.java#](https://github.com/Minecolonies/minecolonies/blob/f6b33e6ad9d5ccfc8034ed8324730d48d0ba39dc/src/main/java/com/minecolonies/coremod/colony/Colony.java#): This file has 1.383 lines, which is greater than 1.000 authorized. Split it into smaller files. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonar.minecolonies.com/coding_rules#rule_key=squid%3AS00104)\n1. ![MAJOR][MAJOR] [Colony.java#L60](https://github.com/Minecolonies/minecolonies/blob/f6b33e6ad9d5ccfc8034ed8324730d48d0ba39dc/src/main/java/com/minecolonies/coremod/colony/Colony.java#L60): Split this class into smaller and more specialized ones to reduce its dependencies on other classes from 51 to the maximum authorized 30 or less. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonar.minecolonies.com/coding_rules#rule_key=squid%3AS1200)\n1. ![MAJOR][MAJOR] [Colony.java#L60](https://github.com/Minecolonies/minecolonies/blob/f6b33e6ad9d5ccfc8034ed8324730d48d0ba39dc/src/main/java/com/minecolonies/coremod/colony/Colony.java#L60): class \"Colony\" has 102 methods, which is greater than the 35 authorized. Split it into smaller classes. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonar.minecolonies.com/coding_rules#rule_key=squid%3AS1448)\n1. ![MAJOR][MAJOR] [Colony.java#L350](https://github.com/Minecolonies/minecolonies/blob/f6b33e6ad9d5ccfc8034ed8324730d48d0ba39dc/src/main/java/com/minecolonies/coremod/colony/Colony.java#L350): Remove this useless assignment to local variable \"achievementKey\". [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonar.minecolonies.com/coding_rules#rule_key=squid%3AS1854)\n1. ![MAJOR][MAJOR] [Colony.java#L530](https://github.com/Minecolonies/minecolonies/blob/f6b33e6ad9d5ccfc8034ed8324730d48d0ba39dc/src/main/java/com/minecolonies/coremod/colony/Colony.java#L530): Remove this useless assignment to local variable \"achievementCompound\". [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonar.minecolonies.com/coding_rules#rule_key=squid%3AS1854)\n1. ![MAJOR][MAJOR] [Colony.java#L652](https://github.com/Minecolonies/minecolonies/blob/f6b33e6ad9d5ccfc8034ed8324730d48d0ba39dc/src/main/java/com/minecolonies/coremod/colony/Colony.java#L652): Reduce the number of returns of this method 11, down to the maximum allowed 6. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonar.minecolonies.com/coding_rules#rule_key=squid%3AS1142)\n1. ![MAJOR][MAJOR] [Colony.java#L1103](https://github.com/Minecolonies/minecolonies/blob/f6b33e6ad9d5ccfc8034ed8324730d48d0ba39dc/src/main/java/com/minecolonies/coremod/colony/Colony.java#L1103): The Cyclomatic Complexity of this method \"onWorldTick\" is 20 which is greater than 15 authorized. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonar.minecolonies.com/coding_rules#rule_key=squid%3AMethodCyclomaticComplexity)\n1. ![MAJOR][MAJOR] [Colony.java#L1546](https://github.com/Minecolonies/minecolonies/blob/f6b33e6ad9d5ccfc8034ed8324730d48d0ba39dc/src/main/java/com/minecolonies/coremod/colony/Colony.java#L1546): Assign this magic number 0.5D to a well-named constant, and use the constant instead. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonar.minecolonies.com/coding_rules#rule_key=squid%3AS109)\n1. ![MAJOR][MAJOR] [Colony.java#L1546](https://github.com/Minecolonies/minecolonies/blob/f6b33e6ad9d5ccfc8034ed8324730d48d0ba39dc/src/main/java/com/minecolonies/coremod/colony/Colony.java#L1546): Assign this magic number 0.1D to a well-named constant, and use the constant instead. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonar.minecolonies.com/coding_rules#rule_key=squid%3AS109)\n1. ![MAJOR][MAJOR] [Colony.java#L1546](https://github.com/Minecolonies/minecolonies/blob/f6b33e6ad9d5ccfc8034ed8324730d48d0ba39dc/src/main/java/com/minecolonies/coremod/colony/Colony.java#L1546): Assign this magic number 0.5D to a well-named constant, and use the constant instead. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonar.minecolonies.com/coding_rules#rule_key=squid%3AS109)\n\n[INFO]: https://sonarsource.github.io/sonar-github/severity-info.png 'Severity: INFO'\n[MAJOR]: https://sonarsource.github.io/sonar-github/severity-major.png 'Severity: MAJOR'\n[MINOR]: https://sonarsource.github.io/sonar-github/severity-minor.png 'Severity: MINOR'"}}
{"actor":{"display_login":"BuildTeamLinter"}}