{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/xunit-performance/pulls/comments/100413259","pull_request_review_id":21120741,"id":100413259,"diff_hunk":"@@ -1,36 +1,41 @@\n ﻿<Project ToolsVersion=\"15.0\" xmlns=\"http://schemas.microsoft.com/developer/msbuild/2003\">\n   <Import Project=\"$(MSBuildExtensionsPath)\\$(MSBuildToolsVersion)\\Microsoft.Common.props\" />\n+  <PropertyGroup Label=\"Configuration\">\n+    <TreatWarningsAsErrors>True</TreatWarningsAsErrors>\n+  </PropertyGroup>\n   <PropertyGroup>\n     <VersionPrefix>1.0.0-alpha</VersionPrefix>\n-    <TargetFrameworks>netstandard1.3</TargetFrameworks>\n+    <TargetFrameworks>netstandard1.5</TargetFrameworks>","path":"src/xunit.performance.api/xunit.performance.api.csproj","position":9,"original_position":9,"commit_id":"2f8ff06cd0bdd5cd16023d0acd5ff72aa3a6f073","original_commit_id":"2f8ff06cd0bdd5cd16023d0acd5ff72aa3a6f073","user":{"login":"jorive","id":12551699,"avatar_url":"https://avatars.githubusercontent.com/u/12551699?v=3","gravatar_id":"","url":"https://api.github.com/users/jorive","html_url":"https://github.com/jorive","followers_url":"https://api.github.com/users/jorive/followers","following_url":"https://api.github.com/users/jorive/following{/other_user}","gists_url":"https://api.github.com/users/jorive/gists{/gist_id}","starred_url":"https://api.github.com/users/jorive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jorive/subscriptions","organizations_url":"https://api.github.com/users/jorive/orgs","repos_url":"https://api.github.com/users/jorive/repos","events_url":"https://api.github.com/users/jorive/events{/privacy}","received_events_url":"https://api.github.com/users/jorive/received_events","type":"User","site_admin":false},"body":"From [https://docs.microsoft.com/en-us/dotnet/articles/standard/library](https://docs.microsoft.com/en-us/dotnet/articles/standard/library),\r\n.netstandard1.5 support .NET Framework 4.6.2\r\n\r\n---\r\nIn reply to: [100389083](https://github.com/Microsoft/xunit-performance/pull/183#discussion_r100389083) [](ancestors = 100389083)","created_at":"2017-02-09T21:14:03Z","updated_at":"2017-02-09T21:14:03Z","html_url":"https://github.com/Microsoft/xunit-performance/pull/183#discussion_r100413259","pull_request_url":"https://api.github.com/repos/Microsoft/xunit-performance/pulls/183","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/xunit-performance/pulls/comments/100413259"},"html":{"href":"https://github.com/Microsoft/xunit-performance/pull/183#discussion_r100413259"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/xunit-performance/pulls/183"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/xunit-performance/pulls/183","id":105076145,"html_url":"https://github.com/Microsoft/xunit-performance/pull/183","diff_url":"https://github.com/Microsoft/xunit-performance/pull/183.diff","patch_url":"https://github.com/Microsoft/xunit-performance/pull/183.patch","issue_url":"https://api.github.com/repos/Microsoft/xunit-performance/issues/183","number":183,"state":"open","locked":false,"title":"Adding ETW to xunit-performance API","user":{"login":"jorive","id":12551699,"avatar_url":"https://avatars.githubusercontent.com/u/12551699?v=3","gravatar_id":"","url":"https://api.github.com/users/jorive","html_url":"https://github.com/jorive","followers_url":"https://api.github.com/users/jorive/followers","following_url":"https://api.github.com/users/jorive/following{/other_user}","gists_url":"https://api.github.com/users/jorive/gists{/gist_id}","starred_url":"https://api.github.com/users/jorive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jorive/subscriptions","organizations_url":"https://api.github.com/users/jorive/orgs","repos_url":"https://api.github.com/users/jorive/repos","events_url":"https://api.github.com/users/jorive/events{/privacy}","received_events_url":"https://api.github.com/users/jorive/received_events","type":"User","site_admin":false},"body":"1. This work is based of the .NET Core build of the Microsoft.Diagnostics.Tracing.TraceEvent library.\r\n2. Changed the statistics output to be markdown table (this adds dependency on MarkdownLog library build that was built for .NET Core).\r\n3. Cleanup and refactor the build scripts.\r\n4. Cleanup and refactor the csproj.\r\n5. Added a Kernel32 class that PInvoke methods to determine the Windows version (current .NET API is only available on 1.7 which would not support .NET Core 1.0).\r\n\r\nThis is an example of the markdown text output by the harness:\r\n Test Name                                   | Metric   | Iterations | AVERAGE | STDEV.S |   MIN |   MAX\r\n:------------------------------------------- |:-------- |:----------:| -------:| -------:| -----:| -----:\r\n simpleharness.Program+Type_1.TestBenchmark  | Duration |    101     |   1.686 |   0.248 | 1.493 | 2.981\r\n simpleharness.Program+Type_2.TestBenchmark1 | Duration |    101     |   1.651 |   0.188 | 1.459 | 2.499\r\n simpleharness.Program+Type_2.TestBenchmark2 | Duration |    101     |   1.589 |   0.123 | 1.468 | 2.038","created_at":"2017-02-07T19:29:08Z","updated_at":"2017-02-09T21:14:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"265bed11b99f493e194f1595da6f6d6876417896","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/xunit-performance/pulls/183/commits","review_comments_url":"https://api.github.com/repos/Microsoft/xunit-performance/pulls/183/comments","review_comment_url":"https://api.github.com/repos/Microsoft/xunit-performance/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/xunit-performance/issues/183/comments","statuses_url":"https://api.github.com/repos/Microsoft/xunit-performance/statuses/2f8ff06cd0bdd5cd16023d0acd5ff72aa3a6f073","head":{"label":"jorive:dev/state-machine","ref":"dev/state-machine","sha":"2f8ff06cd0bdd5cd16023d0acd5ff72aa3a6f073","user":{"login":"jorive","id":12551699,"avatar_url":"https://avatars.githubusercontent.com/u/12551699?v=3","gravatar_id":"","url":"https://api.github.com/users/jorive","html_url":"https://github.com/jorive","followers_url":"https://api.github.com/users/jorive/followers","following_url":"https://api.github.com/users/jorive/following{/other_user}","gists_url":"https://api.github.com/users/jorive/gists{/gist_id}","starred_url":"https://api.github.com/users/jorive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jorive/subscriptions","organizations_url":"https://api.github.com/users/jorive/orgs","repos_url":"https://api.github.com/users/jorive/repos","events_url":"https://api.github.com/users/jorive/events{/privacy}","received_events_url":"https://api.github.com/users/jorive/received_events","type":"User","site_admin":false},"repo":{"id":69695066,"name":"xunit-performance","full_name":"jorive/xunit-performance","owner":{"login":"jorive","id":12551699,"avatar_url":"https://avatars.githubusercontent.com/u/12551699?v=3","gravatar_id":"","url":"https://api.github.com/users/jorive","html_url":"https://github.com/jorive","followers_url":"https://api.github.com/users/jorive/followers","following_url":"https://api.github.com/users/jorive/following{/other_user}","gists_url":"https://api.github.com/users/jorive/gists{/gist_id}","starred_url":"https://api.github.com/users/jorive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jorive/subscriptions","organizations_url":"https://api.github.com/users/jorive/orgs","repos_url":"https://api.github.com/users/jorive/repos","events_url":"https://api.github.com/users/jorive/events{/privacy}","received_events_url":"https://api.github.com/users/jorive/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jorive/xunit-performance","description":"Provides extensions over xUnit to author performance tests.","fork":true,"url":"https://api.github.com/repos/jorive/xunit-performance","forks_url":"https://api.github.com/repos/jorive/xunit-performance/forks","keys_url":"https://api.github.com/repos/jorive/xunit-performance/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jorive/xunit-performance/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jorive/xunit-performance/teams","hooks_url":"https://api.github.com/repos/jorive/xunit-performance/hooks","issue_events_url":"https://api.github.com/repos/jorive/xunit-performance/issues/events{/number}","events_url":"https://api.github.com/repos/jorive/xunit-performance/events","assignees_url":"https://api.github.com/repos/jorive/xunit-performance/assignees{/user}","branches_url":"https://api.github.com/repos/jorive/xunit-performance/branches{/branch}","tags_url":"https://api.github.com/repos/jorive/xunit-performance/tags","blobs_url":"https://api.github.com/repos/jorive/xunit-performance/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jorive/xunit-performance/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jorive/xunit-performance/git/refs{/sha}","trees_url":"https://api.github.com/repos/jorive/xunit-performance/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jorive/xunit-performance/statuses/{sha}","languages_url":"https://api.github.com/repos/jorive/xunit-performance/languages","stargazers_url":"https://api.github.com/repos/jorive/xunit-performance/stargazers","contributors_url":"https://api.github.com/repos/jorive/xunit-performance/contributors","subscribers_url":"https://api.github.com/repos/jorive/xunit-performance/subscribers","subscription_url":"https://api.github.com/repos/jorive/xunit-performance/subscription","commits_url":"https://api.github.com/repos/jorive/xunit-performance/commits{/sha}","git_commits_url":"https://api.github.com/repos/jorive/xunit-performance/git/commits{/sha}","comments_url":"https://api.github.com/repos/jorive/xunit-performance/comments{/number}","issue_comment_url":"https://api.github.com/repos/jorive/xunit-performance/issues/comments{/number}","contents_url":"https://api.github.com/repos/jorive/xunit-performance/contents/{+path}","compare_url":"https://api.github.com/repos/jorive/xunit-performance/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jorive/xunit-performance/merges","archive_url":"https://api.github.com/repos/jorive/xunit-performance/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jorive/xunit-performance/downloads","issues_url":"https://api.github.com/repos/jorive/xunit-performance/issues{/number}","pulls_url":"https://api.github.com/repos/jorive/xunit-performance/pulls{/number}","milestones_url":"https://api.github.com/repos/jorive/xunit-performance/milestones{/number}","notifications_url":"https://api.github.com/repos/jorive/xunit-performance/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jorive/xunit-performance/labels{/name}","releases_url":"https://api.github.com/repos/jorive/xunit-performance/releases{/id}","deployments_url":"https://api.github.com/repos/jorive/xunit-performance/deployments","created_at":"2016-09-30T19:17:41Z","updated_at":"2016-09-30T19:17:42Z","pushed_at":"2017-02-08T23:40:41Z","git_url":"git://github.com/jorive/xunit-performance.git","ssh_url":"git@github.com:jorive/xunit-performance.git","clone_url":"https://github.com/jorive/xunit-performance.git","svn_url":"https://github.com/jorive/xunit-performance","homepage":null,"size":1715,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"61b10f5ac06e6bf44a0d79b4d32520ccabd8ca43","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":40019247,"name":"xunit-performance","full_name":"Microsoft/xunit-performance","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/xunit-performance","description":"Provides extensions over xUnit to author performance tests.","fork":false,"url":"https://api.github.com/repos/Microsoft/xunit-performance","forks_url":"https://api.github.com/repos/Microsoft/xunit-performance/forks","keys_url":"https://api.github.com/repos/Microsoft/xunit-performance/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/xunit-performance/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/xunit-performance/teams","hooks_url":"https://api.github.com/repos/Microsoft/xunit-performance/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/xunit-performance/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/xunit-performance/events","assignees_url":"https://api.github.com/repos/Microsoft/xunit-performance/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/xunit-performance/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/xunit-performance/tags","blobs_url":"https://api.github.com/repos/Microsoft/xunit-performance/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/xunit-performance/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/xunit-performance/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/xunit-performance/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/xunit-performance/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/xunit-performance/languages","stargazers_url":"https://api.github.com/repos/Microsoft/xunit-performance/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/xunit-performance/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/xunit-performance/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/xunit-performance/subscription","commits_url":"https://api.github.com/repos/Microsoft/xunit-performance/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/xunit-performance/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/xunit-performance/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/xunit-performance/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/xunit-performance/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/xunit-performance/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/xunit-performance/merges","archive_url":"https://api.github.com/repos/Microsoft/xunit-performance/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/xunit-performance/downloads","issues_url":"https://api.github.com/repos/Microsoft/xunit-performance/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/xunit-performance/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/xunit-performance/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/xunit-performance/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/xunit-performance/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/xunit-performance/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/xunit-performance/deployments","created_at":"2015-07-31T18:29:43Z","updated_at":"2017-02-06T23:55:27Z","pushed_at":"2017-02-08T23:40:43Z","git_url":"git://github.com/Microsoft/xunit-performance.git","ssh_url":"git@github.com:Microsoft/xunit-performance.git","clone_url":"https://github.com/Microsoft/xunit-performance.git","svn_url":"https://github.com/Microsoft/xunit-performance","homepage":null,"size":1681,"stargazers_count":59,"watchers_count":59,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":33,"mirror_url":null,"open_issues_count":26,"forks":33,"open_issues":26,"watchers":59,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/xunit-performance/pulls/183"},"html":{"href":"https://github.com/Microsoft/xunit-performance/pull/183"},"issue":{"href":"https://api.github.com/repos/Microsoft/xunit-performance/issues/183"},"comments":{"href":"https://api.github.com/repos/Microsoft/xunit-performance/issues/183/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/xunit-performance/pulls/183/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/xunit-performance/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/xunit-performance/pulls/183/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/xunit-performance/statuses/2f8ff06cd0bdd5cd16023d0acd5ff72aa3a6f073"}}}}
{"actor":{"display_login":"jorive"}}