{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/134092382","pull_request_review_id":57350702,"id":134092382,"diff_hunk":"@@ -232,6 +241,24 @@ private byte[] GetCipherValue(CipherData cipherData)\n             throw new CryptographicException(SR.Cryptography_Xml_MissingCipherData);\n         }\n \n+        private void DownloadCipherValue(CipherData cipherData, out Stream inputStream, out Stream decInputStream, out WebResponse response)\n+        {\n+            // maybe a network stream, make sure we allow just what is needed!!\n+            PermissionSet ps = SecurityManager.GetStandardSandbox(_evidence);\n+            ps.PermitOnly();","path":"src/System.Security.Cryptography.Xml/src/System/Security/Cryptography/Xml/EncryptedXml.cs","position":68,"original_position":68,"commit_id":"bb3b3c4feee37df7543d48bf7f607e00f5795e61","original_commit_id":"bb3b3c4feee37df7543d48bf7f607e00f5795e61","user":{"login":"ViktorHofer","id":7412651,"avatar_url":"https://avatars1.githubusercontent.com/u/7412651?v=4","gravatar_id":"","url":"https://api.github.com/users/ViktorHofer","html_url":"https://github.com/ViktorHofer","followers_url":"https://api.github.com/users/ViktorHofer/followers","following_url":"https://api.github.com/users/ViktorHofer/following{/other_user}","gists_url":"https://api.github.com/users/ViktorHofer/gists{/gist_id}","starred_url":"https://api.github.com/users/ViktorHofer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ViktorHofer/subscriptions","organizations_url":"https://api.github.com/users/ViktorHofer/orgs","repos_url":"https://api.github.com/users/ViktorHofer/repos","events_url":"https://api.github.com/users/ViktorHofer/events{/privacy}","received_events_url":"https://api.github.com/users/ViktorHofer/received_events","type":"User","site_admin":false},"body":"@danmosemsft what's the strategy for code that checks if permission is granted? I guess it's intentional that PermitOnly wasn't stubbed out silently instead of throwing? Maybe conditional compilation?","created_at":"2017-08-19T13:51:53Z","updated_at":"2017-08-19T13:51:54Z","html_url":"https://github.com/dotnet/corefx/pull/23417#discussion_r134092382","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/23417","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/134092382"},"html":{"href":"https://github.com/dotnet/corefx/pull/23417#discussion_r134092382"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/23417"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/23417","id":136607278,"html_url":"https://github.com/dotnet/corefx/pull/23417","diff_url":"https://github.com/dotnet/corefx/pull/23417.diff","patch_url":"https://github.com/dotnet/corefx/pull/23417.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/23417","number":23417,"state":"open","locked":false,"title":"Add missing members to EncryptedXml.","user":{"login":"vladimir-kazakov","id":3518844,"avatar_url":"https://avatars1.githubusercontent.com/u/3518844?v=4","gravatar_id":"","url":"https://api.github.com/users/vladimir-kazakov","html_url":"https://github.com/vladimir-kazakov","followers_url":"https://api.github.com/users/vladimir-kazakov/followers","following_url":"https://api.github.com/users/vladimir-kazakov/following{/other_user}","gists_url":"https://api.github.com/users/vladimir-kazakov/gists{/gist_id}","starred_url":"https://api.github.com/users/vladimir-kazakov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vladimir-kazakov/subscriptions","organizations_url":"https://api.github.com/users/vladimir-kazakov/orgs","repos_url":"https://api.github.com/users/vladimir-kazakov/repos","events_url":"https://api.github.com/users/vladimir-kazakov/events{/privacy}","received_events_url":"https://api.github.com/users/vladimir-kazakov/received_events","type":"User","site_admin":false},"body":"While importing `EncryptedXml` into Mono (https://github.com/mono/mono/pull/5273), it was noticed that its following members are missing:\r\n\r\n* [The `(XmlDocument, Evidence)` constructor.](https://msdn.microsoft.com/en-us/library/kc1kt87d(v=vs.110).aspx)\r\n* [The `DocumentEvidence` property.](https://msdn.microsoft.com/en-us/library/system.security.cryptography.xml.encryptedxml.documentevidence(v=vs.110).aspx)\r\n\r\nThis PR adds them. The implementation is taken from [.NET Framework](https://referencesource.microsoft.com/#System.Security/system/security/cryptography/xml/encryptedxml.cs).\r\n\r\nThe behavior of the `EncryptedXmlTest.DecryptData_CipherReference_InvalidUri` test was changed. As far as I understand, both .NET Core and .NET Framework must behave the same way. According to [the documentation](https://msdn.microsoft.com/en-us/library/system.security.securitymanager.getstandardsandbox(v=vs.110).aspx), the `SecurityManager.GetStandardSandbox` must throw if the evidence is null. Previously, .NET Core wasn't throwing in this case, so this was changed as well.","created_at":"2017-08-19T13:29:56Z","updated_at":"2017-08-19T13:51:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0ad4bcb0de363bea4f92534aed1906c88554c09b","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/23417/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/23417/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/23417/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/bb3b3c4feee37df7543d48bf7f607e00f5795e61","head":{"label":"vladimir-kazakov:encrypted-xml-missing-apis","ref":"encrypted-xml-missing-apis","sha":"bb3b3c4feee37df7543d48bf7f607e00f5795e61","user":{"login":"vladimir-kazakov","id":3518844,"avatar_url":"https://avatars1.githubusercontent.com/u/3518844?v=4","gravatar_id":"","url":"https://api.github.com/users/vladimir-kazakov","html_url":"https://github.com/vladimir-kazakov","followers_url":"https://api.github.com/users/vladimir-kazakov/followers","following_url":"https://api.github.com/users/vladimir-kazakov/following{/other_user}","gists_url":"https://api.github.com/users/vladimir-kazakov/gists{/gist_id}","starred_url":"https://api.github.com/users/vladimir-kazakov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vladimir-kazakov/subscriptions","organizations_url":"https://api.github.com/users/vladimir-kazakov/orgs","repos_url":"https://api.github.com/users/vladimir-kazakov/repos","events_url":"https://api.github.com/users/vladimir-kazakov/events{/privacy}","received_events_url":"https://api.github.com/users/vladimir-kazakov/received_events","type":"User","site_admin":false},"repo":{"id":96598919,"name":"corefx","full_name":"vladimir-kazakov/corefx","owner":{"login":"vladimir-kazakov","id":3518844,"avatar_url":"https://avatars1.githubusercontent.com/u/3518844?v=4","gravatar_id":"","url":"https://api.github.com/users/vladimir-kazakov","html_url":"https://github.com/vladimir-kazakov","followers_url":"https://api.github.com/users/vladimir-kazakov/followers","following_url":"https://api.github.com/users/vladimir-kazakov/following{/other_user}","gists_url":"https://api.github.com/users/vladimir-kazakov/gists{/gist_id}","starred_url":"https://api.github.com/users/vladimir-kazakov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vladimir-kazakov/subscriptions","organizations_url":"https://api.github.com/users/vladimir-kazakov/orgs","repos_url":"https://api.github.com/users/vladimir-kazakov/repos","events_url":"https://api.github.com/users/vladimir-kazakov/events{/privacy}","received_events_url":"https://api.github.com/users/vladimir-kazakov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vladimir-kazakov/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others. We welcome contributions.","fork":true,"url":"https://api.github.com/repos/vladimir-kazakov/corefx","forks_url":"https://api.github.com/repos/vladimir-kazakov/corefx/forks","keys_url":"https://api.github.com/repos/vladimir-kazakov/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vladimir-kazakov/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vladimir-kazakov/corefx/teams","hooks_url":"https://api.github.com/repos/vladimir-kazakov/corefx/hooks","issue_events_url":"https://api.github.com/repos/vladimir-kazakov/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/vladimir-kazakov/corefx/events","assignees_url":"https://api.github.com/repos/vladimir-kazakov/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/vladimir-kazakov/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/vladimir-kazakov/corefx/tags","blobs_url":"https://api.github.com/repos/vladimir-kazakov/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vladimir-kazakov/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vladimir-kazakov/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/vladimir-kazakov/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vladimir-kazakov/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/vladimir-kazakov/corefx/languages","stargazers_url":"https://api.github.com/repos/vladimir-kazakov/corefx/stargazers","contributors_url":"https://api.github.com/repos/vladimir-kazakov/corefx/contributors","subscribers_url":"https://api.github.com/repos/vladimir-kazakov/corefx/subscribers","subscription_url":"https://api.github.com/repos/vladimir-kazakov/corefx/subscription","commits_url":"https://api.github.com/repos/vladimir-kazakov/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/vladimir-kazakov/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/vladimir-kazakov/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/vladimir-kazakov/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/vladimir-kazakov/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/vladimir-kazakov/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vladimir-kazakov/corefx/merges","archive_url":"https://api.github.com/repos/vladimir-kazakov/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vladimir-kazakov/corefx/downloads","issues_url":"https://api.github.com/repos/vladimir-kazakov/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/vladimir-kazakov/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/vladimir-kazakov/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/vladimir-kazakov/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vladimir-kazakov/corefx/labels{/name}","releases_url":"https://api.github.com/repos/vladimir-kazakov/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/vladimir-kazakov/corefx/deployments","created_at":"2017-07-08T05:48:23Z","updated_at":"2017-07-08T05:49:03Z","pushed_at":"2017-08-19T13:07:17Z","git_url":"git://github.com/vladimir-kazakov/corefx.git","ssh_url":"git@github.com:vladimir-kazakov/corefx.git","clone_url":"https://github.com/vladimir-kazakov/corefx.git","svn_url":"https://github.com/vladimir-kazakov/corefx","homepage":"https://github.com/dotnet/core","size":153962,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"7a673547563dc92f1f4cad802d7b57483cdf7500","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others. We welcome contributions.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefx/deployments","created_at":"2014-11-06T23:42:48Z","updated_at":"2017-08-19T09:27:28Z","pushed_at":"2017-08-19T13:29:56Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"https://github.com/dotnet/core","size":154681,"stargazers_count":12343,"watchers_count":12343,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3397,"mirror_url":null,"open_issues_count":1873,"forks":3397,"open_issues":1873,"watchers":12343,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/23417"},"html":{"href":"https://github.com/dotnet/corefx/pull/23417"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/23417"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/23417/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/23417/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/23417/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/bb3b3c4feee37df7543d48bf7f607e00f5795e61"}}}}
{"actor":{"display_login":"ViktorHofer"}}