{"action":"created","comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/136729714","pull_request_review_id":60308192,"id":136729714,"diff_hunk":"@@ -800,6 +802,16 @@ def _get_args(function, varargs=False):\n         return args\n \n \n+def _get_parent_args(Estimator):\n+    \"\"\"Helper to get list of parents properties\"\"\"","path":"sklearn/utils/testing.py","position":30,"original_position":30,"commit_id":"3637256c3ae67cd4c7337c484410f35498d8525b","original_commit_id":"3637256c3ae67cd4c7337c484410f35498d8525b","user":{"login":"jnothman","id":78827,"avatar_url":"https://avatars2.githubusercontent.com/u/78827?v=4","gravatar_id":"","url":"https://api.github.com/users/jnothman","html_url":"https://github.com/jnothman","followers_url":"https://api.github.com/users/jnothman/followers","following_url":"https://api.github.com/users/jnothman/following{/other_user}","gists_url":"https://api.github.com/users/jnothman/gists{/gist_id}","starred_url":"https://api.github.com/users/jnothman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnothman/subscriptions","organizations_url":"https://api.github.com/users/jnothman/orgs","repos_url":"https://api.github.com/users/jnothman/repos","events_url":"https://api.github.com/users/jnothman/events{/privacy}","received_events_url":"https://api.github.com/users/jnothman/received_events","type":"User","site_admin":false},"body":"parents -> parents'.\r\n\r\nI don't think \"properties\" is correct. You've got a mix of constructor parameter names and class attribute names. I don't think `_get_parent_args` is a sufficient name for this either, given that `_get_args` does not return attributes.","created_at":"2017-09-04T00:04:54Z","updated_at":"2017-09-04T00:20:34Z","html_url":"https://github.com/scikit-learn/scikit-learn/pull/9450#discussion_r136729714","pull_request_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/9450","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/136729714"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/9450#discussion_r136729714"},"pull_request":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/9450"}}},"pull_request":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/9450","id":132368681,"html_url":"https://github.com/scikit-learn/scikit-learn/pull/9450","diff_url":"https://github.com/scikit-learn/scikit-learn/pull/9450.diff","patch_url":"https://github.com/scikit-learn/scikit-learn/pull/9450.patch","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/9450","number":9450,"state":"open","locked":false,"title":"[MRG] - No private setting in __init__ apart from parameters","user":{"login":"herilalaina","id":2856058,"avatar_url":"https://avatars0.githubusercontent.com/u/2856058?v=4","gravatar_id":"","url":"https://api.github.com/users/herilalaina","html_url":"https://github.com/herilalaina","followers_url":"https://api.github.com/users/herilalaina/followers","following_url":"https://api.github.com/users/herilalaina/following{/other_user}","gists_url":"https://api.github.com/users/herilalaina/gists{/gist_id}","starred_url":"https://api.github.com/users/herilalaina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/herilalaina/subscriptions","organizations_url":"https://api.github.com/users/herilalaina/orgs","repos_url":"https://api.github.com/users/herilalaina/repos","events_url":"https://api.github.com/users/herilalaina/events{/privacy}","received_events_url":"https://api.github.com/users/herilalaina/received_events","type":"User","site_admin":false},"body":"<!--\r\nThanks for contributing a pull request! Please ensure you have taken a look at\r\nthe contribution guidelines: https://github.com/scikit-learn/scikit-learn/blob/master/CONTRIBUTING.md#Contributing-Pull-Requests\r\n-->\r\n#### Reference Issue\r\n<!-- Example: Fixes #1234 -->\r\nFixes  #9378\r\n\r\n#### What does this implement/fix? Explain your changes.\r\n`check_no_fit_attributes_set_in_init` : check no private setting in `__init__`\r\n\r\n#### Any other comments?\r\n\r\n\r\n<!--\r\nPlease be aware that we are a loose team of volunteers so patience is\r\nnecessary; assistance handling other issues is very welcome. We value\r\nall user contributions, no matter how minor they are. If we are slow to\r\nreview, either the pull request needs some benchmarking, tinkering,\r\nconvincing, etc. or more likely the reviewers are simply busy. In either\r\ncase, we ask for your understanding during the review process.\r\nFor more information, see our FAQ on this topic:\r\nhttp://scikit-learn.org/dev/faq.html#why-is-my-pull-request-not-getting-any-attention.\r\n\r\nThanks for contributing!\r\n-->\r\n","created_at":"2017-07-25T20:10:10Z","updated_at":"2017-09-04T00:20:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"917758a6192a9af9fb92de069e72c27930793481","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/9450/commits","review_comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/9450/comments","review_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/9450/comments","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/3637256c3ae67cd4c7337c484410f35498d8525b","head":{"label":"herilalaina:check_no_fit_attributes_set_in_init","ref":"check_no_fit_attributes_set_in_init","sha":"3637256c3ae67cd4c7337c484410f35498d8525b","user":{"login":"herilalaina","id":2856058,"avatar_url":"https://avatars0.githubusercontent.com/u/2856058?v=4","gravatar_id":"","url":"https://api.github.com/users/herilalaina","html_url":"https://github.com/herilalaina","followers_url":"https://api.github.com/users/herilalaina/followers","following_url":"https://api.github.com/users/herilalaina/following{/other_user}","gists_url":"https://api.github.com/users/herilalaina/gists{/gist_id}","starred_url":"https://api.github.com/users/herilalaina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/herilalaina/subscriptions","organizations_url":"https://api.github.com/users/herilalaina/orgs","repos_url":"https://api.github.com/users/herilalaina/repos","events_url":"https://api.github.com/users/herilalaina/events{/privacy}","received_events_url":"https://api.github.com/users/herilalaina/received_events","type":"User","site_admin":false},"repo":{"id":83077012,"name":"scikit-learn","full_name":"herilalaina/scikit-learn","owner":{"login":"herilalaina","id":2856058,"avatar_url":"https://avatars0.githubusercontent.com/u/2856058?v=4","gravatar_id":"","url":"https://api.github.com/users/herilalaina","html_url":"https://github.com/herilalaina","followers_url":"https://api.github.com/users/herilalaina/followers","following_url":"https://api.github.com/users/herilalaina/following{/other_user}","gists_url":"https://api.github.com/users/herilalaina/gists{/gist_id}","starred_url":"https://api.github.com/users/herilalaina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/herilalaina/subscriptions","organizations_url":"https://api.github.com/users/herilalaina/orgs","repos_url":"https://api.github.com/users/herilalaina/repos","events_url":"https://api.github.com/users/herilalaina/events{/privacy}","received_events_url":"https://api.github.com/users/herilalaina/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/herilalaina/scikit-learn","description":"scikit-learn: machine learning in Python","fork":true,"url":"https://api.github.com/repos/herilalaina/scikit-learn","forks_url":"https://api.github.com/repos/herilalaina/scikit-learn/forks","keys_url":"https://api.github.com/repos/herilalaina/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/herilalaina/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/herilalaina/scikit-learn/teams","hooks_url":"https://api.github.com/repos/herilalaina/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/herilalaina/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/herilalaina/scikit-learn/events","assignees_url":"https://api.github.com/repos/herilalaina/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/herilalaina/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/herilalaina/scikit-learn/tags","blobs_url":"https://api.github.com/repos/herilalaina/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/herilalaina/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/herilalaina/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/herilalaina/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/herilalaina/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/herilalaina/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/herilalaina/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/herilalaina/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/herilalaina/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/herilalaina/scikit-learn/subscription","commits_url":"https://api.github.com/repos/herilalaina/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/herilalaina/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/herilalaina/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/herilalaina/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/herilalaina/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/herilalaina/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/herilalaina/scikit-learn/merges","archive_url":"https://api.github.com/repos/herilalaina/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/herilalaina/scikit-learn/downloads","issues_url":"https://api.github.com/repos/herilalaina/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/herilalaina/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/herilalaina/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/herilalaina/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/herilalaina/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/herilalaina/scikit-learn/releases{/id}","deployments_url":"https://api.github.com/repos/herilalaina/scikit-learn/deployments","created_at":"2017-02-24T19:46:51Z","updated_at":"2017-02-24T19:47:01Z","pushed_at":"2017-09-03T21:48:31Z","git_url":"git://github.com/herilalaina/scikit-learn.git","ssh_url":"git@github.com:herilalaina/scikit-learn.git","clone_url":"https://github.com/herilalaina/scikit-learn.git","svn_url":"https://github.com/herilalaina/scikit-learn","homepage":"http://scikit-learn.org","size":85030,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scikit-learn:master","ref":"master","sha":"deaa96452a981e3e54dc302fc14cb1c83cb2e399","user":{"login":"scikit-learn","id":365630,"avatar_url":"https://avatars2.githubusercontent.com/u/365630?v=4","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"repo":{"id":843222,"name":"scikit-learn","full_name":"scikit-learn/scikit-learn","owner":{"login":"scikit-learn","id":365630,"avatar_url":"https://avatars2.githubusercontent.com/u/365630?v=4","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scikit-learn/scikit-learn","description":"scikit-learn: machine learning in Python","fork":false,"url":"https://api.github.com/repos/scikit-learn/scikit-learn","forks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/forks","keys_url":"https://api.github.com/repos/scikit-learn/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scikit-learn/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scikit-learn/scikit-learn/teams","hooks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/events","assignees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/scikit-learn/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/tags","blobs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/scikit-learn/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscription","commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/scikit-learn/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scikit-learn/scikit-learn/merges","archive_url":"https://api.github.com/repos/scikit-learn/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scikit-learn/scikit-learn/downloads","issues_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/scikit-learn/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/scikit-learn/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/scikit-learn/scikit-learn/releases{/id}","deployments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/deployments","created_at":"2010-08-17T09:43:38Z","updated_at":"2017-09-03T23:04:59Z","pushed_at":"2017-09-04T00:00:03Z","git_url":"git://github.com/scikit-learn/scikit-learn.git","ssh_url":"git@github.com:scikit-learn/scikit-learn.git","clone_url":"https://github.com/scikit-learn/scikit-learn.git","svn_url":"https://github.com/scikit-learn/scikit-learn","homepage":"http://scikit-learn.org","size":85929,"stargazers_count":20957,"watchers_count":20957,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11251,"mirror_url":null,"open_issues_count":1452,"forks":11251,"open_issues":1452,"watchers":20957,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/9450"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/9450"},"issue":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/9450"},"comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/9450/comments"},"review_comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/9450/comments"},"review_comment":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/9450/commits"},"statuses":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/3637256c3ae67cd4c7337c484410f35498d8525b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jnothman"}}