{"action":"closed","number":1778,"pull_request":{"url":"https://api.github.com/repos/dimagi/commcare-android/pulls/1778","id":133545080,"html_url":"https://github.com/dimagi/commcare-android/pull/1778","diff_url":"https://github.com/dimagi/commcare-android/pull/1778.diff","patch_url":"https://github.com/dimagi/commcare-android/pull/1778.patch","issue_url":"https://api.github.com/repos/dimagi/commcare-android/issues/1778","number":1778,"state":"closed","locked":false,"title":"Don't attempt remote user key management AFTER data pull success","user":{"login":"amstone326","id":3723143,"avatar_url":"https://avatars0.githubusercontent.com/u/3723143?v=4","gravatar_id":"","url":"https://api.github.com/users/amstone326","html_url":"https://github.com/amstone326","followers_url":"https://api.github.com/users/amstone326/followers","following_url":"https://api.github.com/users/amstone326/following{/other_user}","gists_url":"https://api.github.com/users/amstone326/gists{/gist_id}","starred_url":"https://api.github.com/users/amstone326/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amstone326/subscriptions","organizations_url":"https://api.github.com/users/amstone326/orgs","repos_url":"https://api.github.com/users/amstone326/repos","events_url":"https://api.github.com/users/amstone326/events{/privacy}","received_events_url":"https://api.github.com/users/amstone326/received_events","type":"User","site_admin":false},"body":"I think this will fix the current failure of the demo_user_restore_offline test on AWS.\r\n\r\nThe demo user work was already configured to not attempt remote user key management on the _first_ run of `ManageKeyRecordTask`, but apparently not on the one that happens _after_ a successful data pull. This wasn't causing any issues in live usage of the feature, because on that 2nd run of the task, `calloutSuccessRequired` is set to false since there is already a record present at that point (https://github.com/dimagi/commcare-android/blob/master/app/src/org/commcare/tasks/ManageKeyRecordTask.java#L249). I'm not sure what about AWS exactly is making it fail here where nothing else did, but I think Clayton seems right that it has to do with it \"failing\" by waiting for a long time and then timing out.","created_at":"2017-08-01T18:50:28Z","updated_at":"2017-08-01T22:08:42Z","closed_at":"2017-08-01T22:08:42Z","merged_at":"2017-08-01T22:08:42Z","merge_commit_sha":"7da1fbab9ee1ce9c36e5a9fe7d1c77d88e8c8778","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/dimagi/commcare-android/milestones/19","html_url":"https://github.com/dimagi/commcare-android/milestone/19","labels_url":"https://api.github.com/repos/dimagi/commcare-android/milestones/19/labels","id":2600066,"number":19,"title":"commcare_2.38","description":null,"creator":{"login":"amstone326","id":3723143,"avatar_url":"https://avatars0.githubusercontent.com/u/3723143?v=4","gravatar_id":"","url":"https://api.github.com/users/amstone326","html_url":"https://github.com/amstone326","followers_url":"https://api.github.com/users/amstone326/followers","following_url":"https://api.github.com/users/amstone326/following{/other_user}","gists_url":"https://api.github.com/users/amstone326/gists{/gist_id}","starred_url":"https://api.github.com/users/amstone326/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amstone326/subscriptions","organizations_url":"https://api.github.com/users/amstone326/orgs","repos_url":"https://api.github.com/users/amstone326/repos","events_url":"https://api.github.com/users/amstone326/events{/privacy}","received_events_url":"https://api.github.com/users/amstone326/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":9,"state":"open","created_at":"2017-06-23T06:45:37Z","updated_at":"2017-08-01T22:08:42Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/dimagi/commcare-android/pulls/1778/commits","review_comments_url":"https://api.github.com/repos/dimagi/commcare-android/pulls/1778/comments","review_comment_url":"https://api.github.com/repos/dimagi/commcare-android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dimagi/commcare-android/issues/1778/comments","statuses_url":"https://api.github.com/repos/dimagi/commcare-android/statuses/dc5b88f735dc09e0aa139c9d73aea348512f4a56","head":{"label":"dimagi:demo-user-fix-attempt","ref":"demo-user-fix-attempt","sha":"dc5b88f735dc09e0aa139c9d73aea348512f4a56","user":{"login":"dimagi","id":94514,"avatar_url":"https://avatars1.githubusercontent.com/u/94514?v=4","gravatar_id":"","url":"https://api.github.com/users/dimagi","html_url":"https://github.com/dimagi","followers_url":"https://api.github.com/users/dimagi/followers","following_url":"https://api.github.com/users/dimagi/following{/other_user}","gists_url":"https://api.github.com/users/dimagi/gists{/gist_id}","starred_url":"https://api.github.com/users/dimagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimagi/subscriptions","organizations_url":"https://api.github.com/users/dimagi/orgs","repos_url":"https://api.github.com/users/dimagi/repos","events_url":"https://api.github.com/users/dimagi/events{/privacy}","received_events_url":"https://api.github.com/users/dimagi/received_events","type":"Organization","site_admin":false},"repo":{"id":20939877,"name":"commcare-android","full_name":"dimagi/commcare-android","owner":{"login":"dimagi","id":94514,"avatar_url":"https://avatars1.githubusercontent.com/u/94514?v=4","gravatar_id":"","url":"https://api.github.com/users/dimagi","html_url":"https://github.com/dimagi","followers_url":"https://api.github.com/users/dimagi/followers","following_url":"https://api.github.com/users/dimagi/following{/other_user}","gists_url":"https://api.github.com/users/dimagi/gists{/gist_id}","starred_url":"https://api.github.com/users/dimagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimagi/subscriptions","organizations_url":"https://api.github.com/users/dimagi/orgs","repos_url":"https://api.github.com/users/dimagi/repos","events_url":"https://api.github.com/users/dimagi/events{/privacy}","received_events_url":"https://api.github.com/users/dimagi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dimagi/commcare-android","description":"The best open source form management tool in town","fork":false,"url":"https://api.github.com/repos/dimagi/commcare-android","forks_url":"https://api.github.com/repos/dimagi/commcare-android/forks","keys_url":"https://api.github.com/repos/dimagi/commcare-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dimagi/commcare-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dimagi/commcare-android/teams","hooks_url":"https://api.github.com/repos/dimagi/commcare-android/hooks","issue_events_url":"https://api.github.com/repos/dimagi/commcare-android/issues/events{/number}","events_url":"https://api.github.com/repos/dimagi/commcare-android/events","assignees_url":"https://api.github.com/repos/dimagi/commcare-android/assignees{/user}","branches_url":"https://api.github.com/repos/dimagi/commcare-android/branches{/branch}","tags_url":"https://api.github.com/repos/dimagi/commcare-android/tags","blobs_url":"https://api.github.com/repos/dimagi/commcare-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dimagi/commcare-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dimagi/commcare-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/dimagi/commcare-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dimagi/commcare-android/statuses/{sha}","languages_url":"https://api.github.com/repos/dimagi/commcare-android/languages","stargazers_url":"https://api.github.com/repos/dimagi/commcare-android/stargazers","contributors_url":"https://api.github.com/repos/dimagi/commcare-android/contributors","subscribers_url":"https://api.github.com/repos/dimagi/commcare-android/subscribers","subscription_url":"https://api.github.com/repos/dimagi/commcare-android/subscription","commits_url":"https://api.github.com/repos/dimagi/commcare-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/dimagi/commcare-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/dimagi/commcare-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/dimagi/commcare-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/dimagi/commcare-android/contents/{+path}","compare_url":"https://api.github.com/repos/dimagi/commcare-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dimagi/commcare-android/merges","archive_url":"https://api.github.com/repos/dimagi/commcare-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dimagi/commcare-android/downloads","issues_url":"https://api.github.com/repos/dimagi/commcare-android/issues{/number}","pulls_url":"https://api.github.com/repos/dimagi/commcare-android/pulls{/number}","milestones_url":"https://api.github.com/repos/dimagi/commcare-android/milestones{/number}","notifications_url":"https://api.github.com/repos/dimagi/commcare-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dimagi/commcare-android/labels{/name}","releases_url":"https://api.github.com/repos/dimagi/commcare-android/releases{/id}","deployments_url":"https://api.github.com/repos/dimagi/commcare-android/deployments","created_at":"2014-06-17T21:17:26Z","updated_at":"2017-07-23T14:09:40Z","pushed_at":"2017-08-01T22:08:42Z","git_url":"git://github.com/dimagi/commcare-android.git","ssh_url":"git@github.com:dimagi/commcare-android.git","clone_url":"https://github.com/dimagi/commcare-android.git","svn_url":"https://github.com/dimagi/commcare-android","homepage":"https://play.google.com/store/apps/details?id=org.commcare.dalvik&hl=en","size":155851,"stargazers_count":9,"watchers_count":9,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":11,"forks":15,"open_issues":11,"watchers":9,"default_branch":"master"}},"base":{"label":"dimagi:master","ref":"master","sha":"c1cbc7aa926cd44fb51b3b78b7f15e5375dd328b","user":{"login":"dimagi","id":94514,"avatar_url":"https://avatars1.githubusercontent.com/u/94514?v=4","gravatar_id":"","url":"https://api.github.com/users/dimagi","html_url":"https://github.com/dimagi","followers_url":"https://api.github.com/users/dimagi/followers","following_url":"https://api.github.com/users/dimagi/following{/other_user}","gists_url":"https://api.github.com/users/dimagi/gists{/gist_id}","starred_url":"https://api.github.com/users/dimagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimagi/subscriptions","organizations_url":"https://api.github.com/users/dimagi/orgs","repos_url":"https://api.github.com/users/dimagi/repos","events_url":"https://api.github.com/users/dimagi/events{/privacy}","received_events_url":"https://api.github.com/users/dimagi/received_events","type":"Organization","site_admin":false},"repo":{"id":20939877,"name":"commcare-android","full_name":"dimagi/commcare-android","owner":{"login":"dimagi","id":94514,"avatar_url":"https://avatars1.githubusercontent.com/u/94514?v=4","gravatar_id":"","url":"https://api.github.com/users/dimagi","html_url":"https://github.com/dimagi","followers_url":"https://api.github.com/users/dimagi/followers","following_url":"https://api.github.com/users/dimagi/following{/other_user}","gists_url":"https://api.github.com/users/dimagi/gists{/gist_id}","starred_url":"https://api.github.com/users/dimagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimagi/subscriptions","organizations_url":"https://api.github.com/users/dimagi/orgs","repos_url":"https://api.github.com/users/dimagi/repos","events_url":"https://api.github.com/users/dimagi/events{/privacy}","received_events_url":"https://api.github.com/users/dimagi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dimagi/commcare-android","description":"The best open source form management tool in town","fork":false,"url":"https://api.github.com/repos/dimagi/commcare-android","forks_url":"https://api.github.com/repos/dimagi/commcare-android/forks","keys_url":"https://api.github.com/repos/dimagi/commcare-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dimagi/commcare-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dimagi/commcare-android/teams","hooks_url":"https://api.github.com/repos/dimagi/commcare-android/hooks","issue_events_url":"https://api.github.com/repos/dimagi/commcare-android/issues/events{/number}","events_url":"https://api.github.com/repos/dimagi/commcare-android/events","assignees_url":"https://api.github.com/repos/dimagi/commcare-android/assignees{/user}","branches_url":"https://api.github.com/repos/dimagi/commcare-android/branches{/branch}","tags_url":"https://api.github.com/repos/dimagi/commcare-android/tags","blobs_url":"https://api.github.com/repos/dimagi/commcare-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dimagi/commcare-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dimagi/commcare-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/dimagi/commcare-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dimagi/commcare-android/statuses/{sha}","languages_url":"https://api.github.com/repos/dimagi/commcare-android/languages","stargazers_url":"https://api.github.com/repos/dimagi/commcare-android/stargazers","contributors_url":"https://api.github.com/repos/dimagi/commcare-android/contributors","subscribers_url":"https://api.github.com/repos/dimagi/commcare-android/subscribers","subscription_url":"https://api.github.com/repos/dimagi/commcare-android/subscription","commits_url":"https://api.github.com/repos/dimagi/commcare-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/dimagi/commcare-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/dimagi/commcare-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/dimagi/commcare-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/dimagi/commcare-android/contents/{+path}","compare_url":"https://api.github.com/repos/dimagi/commcare-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dimagi/commcare-android/merges","archive_url":"https://api.github.com/repos/dimagi/commcare-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dimagi/commcare-android/downloads","issues_url":"https://api.github.com/repos/dimagi/commcare-android/issues{/number}","pulls_url":"https://api.github.com/repos/dimagi/commcare-android/pulls{/number}","milestones_url":"https://api.github.com/repos/dimagi/commcare-android/milestones{/number}","notifications_url":"https://api.github.com/repos/dimagi/commcare-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dimagi/commcare-android/labels{/name}","releases_url":"https://api.github.com/repos/dimagi/commcare-android/releases{/id}","deployments_url":"https://api.github.com/repos/dimagi/commcare-android/deployments","created_at":"2014-06-17T21:17:26Z","updated_at":"2017-07-23T14:09:40Z","pushed_at":"2017-08-01T22:08:42Z","git_url":"git://github.com/dimagi/commcare-android.git","ssh_url":"git@github.com:dimagi/commcare-android.git","clone_url":"https://github.com/dimagi/commcare-android.git","svn_url":"https://github.com/dimagi/commcare-android","homepage":"https://play.google.com/store/apps/details?id=org.commcare.dalvik&hl=en","size":155851,"stargazers_count":9,"watchers_count":9,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":11,"forks":15,"open_issues":11,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dimagi/commcare-android/pulls/1778"},"html":{"href":"https://github.com/dimagi/commcare-android/pull/1778"},"issue":{"href":"https://api.github.com/repos/dimagi/commcare-android/issues/1778"},"comments":{"href":"https://api.github.com/repos/dimagi/commcare-android/issues/1778/comments"},"review_comments":{"href":"https://api.github.com/repos/dimagi/commcare-android/pulls/1778/comments"},"review_comment":{"href":"https://api.github.com/repos/dimagi/commcare-android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dimagi/commcare-android/pulls/1778/commits"},"statuses":{"href":"https://api.github.com/repos/dimagi/commcare-android/statuses/dc5b88f735dc09e0aa139c9d73aea348512f4a56"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"ctsims","id":155066,"avatar_url":"https://avatars3.githubusercontent.com/u/155066?v=4","gravatar_id":"","url":"https://api.github.com/users/ctsims","html_url":"https://github.com/ctsims","followers_url":"https://api.github.com/users/ctsims/followers","following_url":"https://api.github.com/users/ctsims/following{/other_user}","gists_url":"https://api.github.com/users/ctsims/gists{/gist_id}","starred_url":"https://api.github.com/users/ctsims/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctsims/subscriptions","organizations_url":"https://api.github.com/users/ctsims/orgs","repos_url":"https://api.github.com/users/ctsims/repos","events_url":"https://api.github.com/users/ctsims/events{/privacy}","received_events_url":"https://api.github.com/users/ctsims/received_events","type":"User","site_admin":false},"comments":4,"review_comments":0,"maintainer_can_modify":false,"commits":5,"additions":37,"deletions":21,"changed_files":6}}
{"actor":{"display_login":"ctsims"}}