{"action":"created","comment":{"url":"https://api.github.com/repos/yast/yast-storage-ng/pulls/comments/125853561","pull_request_review_id":48281292,"id":125853561,"diff_hunk":"@@ -68,6 +68,13 @@ def usb?\n       transport.to_sym == :usb\n     end\n \n+    # Checks if it's in network\n+    #\n+    # @return [Boolean]\n+    def network_trasporter?\n+      transport.to_sym == :iscsi or transport.to_sym == :fcoe","path":"src/lib/y2storage/disk.rb","position":8,"original_position":8,"commit_id":"033bfbc17d253f1d67277a5f205db574218a93bc","original_commit_id":"033bfbc17d253f1d67277a5f205db574218a93bc","user":{"login":"ancorgs","id":3638289,"avatar_url":"https://avatars3.githubusercontent.com/u/3638289?v=3","gravatar_id":"","url":"https://api.github.com/users/ancorgs","html_url":"https://github.com/ancorgs","followers_url":"https://api.github.com/users/ancorgs/followers","following_url":"https://api.github.com/users/ancorgs/following{/other_user}","gists_url":"https://api.github.com/users/ancorgs/gists{/gist_id}","starred_url":"https://api.github.com/users/ancorgs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ancorgs/subscriptions","organizations_url":"https://api.github.com/users/ancorgs/orgs","repos_url":"https://api.github.com/users/ancorgs/repos","events_url":"https://api.github.com/users/ancorgs/events{/privacy}","received_events_url":"https://api.github.com/users/ancorgs/received_events","type":"User","site_admin":false},"body":"Please, use `||` instead of `or`. The second one if not an operator, is a control flow sentence.","created_at":"2017-07-06T09:34:08Z","updated_at":"2017-07-06T09:55:49Z","html_url":"https://github.com/yast/yast-storage-ng/pull/297#discussion_r125853561","pull_request_url":"https://api.github.com/repos/yast/yast-storage-ng/pulls/297","_links":{"self":{"href":"https://api.github.com/repos/yast/yast-storage-ng/pulls/comments/125853561"},"html":{"href":"https://github.com/yast/yast-storage-ng/pull/297#discussion_r125853561"},"pull_request":{"href":"https://api.github.com/repos/yast/yast-storage-ng/pulls/297"}}},"pull_request":{"url":"https://api.github.com/repos/yast/yast-storage-ng/pulls/297","id":129129906,"html_url":"https://github.com/yast/yast-storage-ng/pull/297","diff_url":"https://github.com/yast/yast-storage-ng/pull/297.diff","patch_url":"https://github.com/yast/yast-storage-ng/pull/297.patch","issue_url":"https://api.github.com/repos/yast/yast-storage-ng/issues/297","number":297,"state":"open","locked":false,"title":"Adding check for disk in network","user":{"login":"gilsonsouza","id":536990,"avatar_url":"https://avatars1.githubusercontent.com/u/536990?v=3","gravatar_id":"","url":"https://api.github.com/users/gilsonsouza","html_url":"https://github.com/gilsonsouza","followers_url":"https://api.github.com/users/gilsonsouza/followers","following_url":"https://api.github.com/users/gilsonsouza/following{/other_user}","gists_url":"https://api.github.com/users/gilsonsouza/gists{/gist_id}","starred_url":"https://api.github.com/users/gilsonsouza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gilsonsouza/subscriptions","organizations_url":"https://api.github.com/users/gilsonsouza/orgs","repos_url":"https://api.github.com/users/gilsonsouza/repos","events_url":"https://api.github.com/users/gilsonsouza/events{/privacy}","received_events_url":"https://api.github.com/users/gilsonsouza/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-07-06T08:31:56Z","updated_at":"2017-07-06T09:55:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"13ae970fe1176d942caede031d8dddc39ab2d294","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/yast/yast-storage-ng/pulls/297/commits","review_comments_url":"https://api.github.com/repos/yast/yast-storage-ng/pulls/297/comments","review_comment_url":"https://api.github.com/repos/yast/yast-storage-ng/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yast/yast-storage-ng/issues/297/comments","statuses_url":"https://api.github.com/repos/yast/yast-storage-ng/statuses/033bfbc17d253f1d67277a5f205db574218a93bc","head":{"label":"gilsonsouza:master","ref":"master","sha":"033bfbc17d253f1d67277a5f205db574218a93bc","user":{"login":"gilsonsouza","id":536990,"avatar_url":"https://avatars1.githubusercontent.com/u/536990?v=3","gravatar_id":"","url":"https://api.github.com/users/gilsonsouza","html_url":"https://github.com/gilsonsouza","followers_url":"https://api.github.com/users/gilsonsouza/followers","following_url":"https://api.github.com/users/gilsonsouza/following{/other_user}","gists_url":"https://api.github.com/users/gilsonsouza/gists{/gist_id}","starred_url":"https://api.github.com/users/gilsonsouza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gilsonsouza/subscriptions","organizations_url":"https://api.github.com/users/gilsonsouza/orgs","repos_url":"https://api.github.com/users/gilsonsouza/repos","events_url":"https://api.github.com/users/gilsonsouza/events{/privacy}","received_events_url":"https://api.github.com/users/gilsonsouza/received_events","type":"User","site_admin":false},"repo":{"id":96114428,"name":"yast-storage-ng","full_name":"gilsonsouza/yast-storage-ng","owner":{"login":"gilsonsouza","id":536990,"avatar_url":"https://avatars1.githubusercontent.com/u/536990?v=3","gravatar_id":"","url":"https://api.github.com/users/gilsonsouza","html_url":"https://github.com/gilsonsouza","followers_url":"https://api.github.com/users/gilsonsouza/followers","following_url":"https://api.github.com/users/gilsonsouza/following{/other_user}","gists_url":"https://api.github.com/users/gilsonsouza/gists{/gist_id}","starred_url":"https://api.github.com/users/gilsonsouza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gilsonsouza/subscriptions","organizations_url":"https://api.github.com/users/gilsonsouza/orgs","repos_url":"https://api.github.com/users/gilsonsouza/repos","events_url":"https://api.github.com/users/gilsonsouza/events{/privacy}","received_events_url":"https://api.github.com/users/gilsonsouza/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gilsonsouza/yast-storage-ng","description":"Rewrite of https://github.com/yast/yast-storage","fork":true,"url":"https://api.github.com/repos/gilsonsouza/yast-storage-ng","forks_url":"https://api.github.com/repos/gilsonsouza/yast-storage-ng/forks","keys_url":"https://api.github.com/repos/gilsonsouza/yast-storage-ng/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gilsonsouza/yast-storage-ng/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gilsonsouza/yast-storage-ng/teams","hooks_url":"https://api.github.com/repos/gilsonsouza/yast-storage-ng/hooks","issue_events_url":"https://api.github.com/repos/gilsonsouza/yast-storage-ng/issues/events{/number}","events_url":"https://api.github.com/repos/gilsonsouza/yast-storage-ng/events","assignees_url":"https://api.github.com/repos/gilsonsouza/yast-storage-ng/assignees{/user}","branches_url":"https://api.github.com/repos/gilsonsouza/yast-storage-ng/branches{/branch}","tags_url":"https://api.github.com/repos/gilsonsouza/yast-storage-ng/tags","blobs_url":"https://api.github.com/repos/gilsonsouza/yast-storage-ng/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gilsonsouza/yast-storage-ng/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gilsonsouza/yast-storage-ng/git/refs{/sha}","trees_url":"https://api.github.com/repos/gilsonsouza/yast-storage-ng/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gilsonsouza/yast-storage-ng/statuses/{sha}","languages_url":"https://api.github.com/repos/gilsonsouza/yast-storage-ng/languages","stargazers_url":"https://api.github.com/repos/gilsonsouza/yast-storage-ng/stargazers","contributors_url":"https://api.github.com/repos/gilsonsouza/yast-storage-ng/contributors","subscribers_url":"https://api.github.com/repos/gilsonsouza/yast-storage-ng/subscribers","subscription_url":"https://api.github.com/repos/gilsonsouza/yast-storage-ng/subscription","commits_url":"https://api.github.com/repos/gilsonsouza/yast-storage-ng/commits{/sha}","git_commits_url":"https://api.github.com/repos/gilsonsouza/yast-storage-ng/git/commits{/sha}","comments_url":"https://api.github.com/repos/gilsonsouza/yast-storage-ng/comments{/number}","issue_comment_url":"https://api.github.com/repos/gilsonsouza/yast-storage-ng/issues/comments{/number}","contents_url":"https://api.github.com/repos/gilsonsouza/yast-storage-ng/contents/{+path}","compare_url":"https://api.github.com/repos/gilsonsouza/yast-storage-ng/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gilsonsouza/yast-storage-ng/merges","archive_url":"https://api.github.com/repos/gilsonsouza/yast-storage-ng/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gilsonsouza/yast-storage-ng/downloads","issues_url":"https://api.github.com/repos/gilsonsouza/yast-storage-ng/issues{/number}","pulls_url":"https://api.github.com/repos/gilsonsouza/yast-storage-ng/pulls{/number}","milestones_url":"https://api.github.com/repos/gilsonsouza/yast-storage-ng/milestones{/number}","notifications_url":"https://api.github.com/repos/gilsonsouza/yast-storage-ng/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gilsonsouza/yast-storage-ng/labels{/name}","releases_url":"https://api.github.com/repos/gilsonsouza/yast-storage-ng/releases{/id}","deployments_url":"https://api.github.com/repos/gilsonsouza/yast-storage-ng/deployments","created_at":"2017-07-03T13:35:03Z","updated_at":"2017-07-03T13:35:05Z","pushed_at":"2017-07-06T08:49:29Z","git_url":"git://github.com/gilsonsouza/yast-storage-ng.git","ssh_url":"git@github.com:gilsonsouza/yast-storage-ng.git","clone_url":"https://github.com/gilsonsouza/yast-storage-ng.git","svn_url":"https://github.com/gilsonsouza/yast-storage-ng","homepage":"http://yast.github.io/","size":2243,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yast:master","ref":"master","sha":"beb051e2b37fd9faccc47ce1ff69f3f17ef1422d","user":{"login":"yast","id":909990,"avatar_url":"https://avatars2.githubusercontent.com/u/909990?v=3","gravatar_id":"","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"repo":{"id":46064409,"name":"yast-storage-ng","full_name":"yast/yast-storage-ng","owner":{"login":"yast","id":909990,"avatar_url":"https://avatars2.githubusercontent.com/u/909990?v=3","gravatar_id":"","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yast/yast-storage-ng","description":"Rewrite of https://github.com/yast/yast-storage","fork":false,"url":"https://api.github.com/repos/yast/yast-storage-ng","forks_url":"https://api.github.com/repos/yast/yast-storage-ng/forks","keys_url":"https://api.github.com/repos/yast/yast-storage-ng/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yast/yast-storage-ng/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yast/yast-storage-ng/teams","hooks_url":"https://api.github.com/repos/yast/yast-storage-ng/hooks","issue_events_url":"https://api.github.com/repos/yast/yast-storage-ng/issues/events{/number}","events_url":"https://api.github.com/repos/yast/yast-storage-ng/events","assignees_url":"https://api.github.com/repos/yast/yast-storage-ng/assignees{/user}","branches_url":"https://api.github.com/repos/yast/yast-storage-ng/branches{/branch}","tags_url":"https://api.github.com/repos/yast/yast-storage-ng/tags","blobs_url":"https://api.github.com/repos/yast/yast-storage-ng/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yast/yast-storage-ng/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yast/yast-storage-ng/git/refs{/sha}","trees_url":"https://api.github.com/repos/yast/yast-storage-ng/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yast/yast-storage-ng/statuses/{sha}","languages_url":"https://api.github.com/repos/yast/yast-storage-ng/languages","stargazers_url":"https://api.github.com/repos/yast/yast-storage-ng/stargazers","contributors_url":"https://api.github.com/repos/yast/yast-storage-ng/contributors","subscribers_url":"https://api.github.com/repos/yast/yast-storage-ng/subscribers","subscription_url":"https://api.github.com/repos/yast/yast-storage-ng/subscription","commits_url":"https://api.github.com/repos/yast/yast-storage-ng/commits{/sha}","git_commits_url":"https://api.github.com/repos/yast/yast-storage-ng/git/commits{/sha}","comments_url":"https://api.github.com/repos/yast/yast-storage-ng/comments{/number}","issue_comment_url":"https://api.github.com/repos/yast/yast-storage-ng/issues/comments{/number}","contents_url":"https://api.github.com/repos/yast/yast-storage-ng/contents/{+path}","compare_url":"https://api.github.com/repos/yast/yast-storage-ng/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yast/yast-storage-ng/merges","archive_url":"https://api.github.com/repos/yast/yast-storage-ng/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yast/yast-storage-ng/downloads","issues_url":"https://api.github.com/repos/yast/yast-storage-ng/issues{/number}","pulls_url":"https://api.github.com/repos/yast/yast-storage-ng/pulls{/number}","milestones_url":"https://api.github.com/repos/yast/yast-storage-ng/milestones{/number}","notifications_url":"https://api.github.com/repos/yast/yast-storage-ng/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yast/yast-storage-ng/labels{/name}","releases_url":"https://api.github.com/repos/yast/yast-storage-ng/releases{/id}","deployments_url":"https://api.github.com/repos/yast/yast-storage-ng/deployments","created_at":"2015-11-12T16:09:03Z","updated_at":"2017-05-27T15:24:47Z","pushed_at":"2017-07-06T09:26:33Z","git_url":"git://github.com/yast/yast-storage-ng.git","ssh_url":"git@github.com:yast/yast-storage-ng.git","clone_url":"https://github.com/yast/yast-storage-ng.git","svn_url":"https://github.com/yast/yast-storage-ng","homepage":"http://yast.github.io/","size":2219,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":1,"forks":10,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yast/yast-storage-ng/pulls/297"},"html":{"href":"https://github.com/yast/yast-storage-ng/pull/297"},"issue":{"href":"https://api.github.com/repos/yast/yast-storage-ng/issues/297"},"comments":{"href":"https://api.github.com/repos/yast/yast-storage-ng/issues/297/comments"},"review_comments":{"href":"https://api.github.com/repos/yast/yast-storage-ng/pulls/297/comments"},"review_comment":{"href":"https://api.github.com/repos/yast/yast-storage-ng/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yast/yast-storage-ng/pulls/297/commits"},"statuses":{"href":"https://api.github.com/repos/yast/yast-storage-ng/statuses/033bfbc17d253f1d67277a5f205db574218a93bc"}}}}
{"actor":{"display_login":"ancorgs"}}