{"action":"created","issue":{"url":"https://api.github.com/repos/clee-r7/metasploit-framework/issues/3","repository_url":"https://api.github.com/repos/clee-r7/metasploit-framework","labels_url":"https://api.github.com/repos/clee-r7/metasploit-framework/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/clee-r7/metasploit-framework/issues/3/comments","events_url":"https://api.github.com/repos/clee-r7/metasploit-framework/issues/3/events","html_url":"https://github.com/clee-r7/metasploit-framework/pull/3","id":281202709,"number":3,"title":"Move session mdm use","user":{"login":"mkienow-r7","id":33330829,"avatar_url":"https://avatars2.githubusercontent.com/u/33330829?v=4","gravatar_id":"","url":"https://api.github.com/users/mkienow-r7","html_url":"https://github.com/mkienow-r7","followers_url":"https://api.github.com/users/mkienow-r7/followers","following_url":"https://api.github.com/users/mkienow-r7/following{/other_user}","gists_url":"https://api.github.com/users/mkienow-r7/gists{/gist_id}","starred_url":"https://api.github.com/users/mkienow-r7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkienow-r7/subscriptions","organizations_url":"https://api.github.com/users/mkienow-r7/orgs","repos_url":"https://api.github.com/users/mkienow-r7/repos","events_url":"https://api.github.com/users/mkienow-r7/events{/privacy}","received_events_url":"https://api.github.com/users/mkienow-r7/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"jbarnett-r7","id":12236529,"avatar_url":"https://avatars0.githubusercontent.com/u/12236529?v=4","gravatar_id":"","url":"https://api.github.com/users/jbarnett-r7","html_url":"https://github.com/jbarnett-r7","followers_url":"https://api.github.com/users/jbarnett-r7/followers","following_url":"https://api.github.com/users/jbarnett-r7/following{/other_user}","gists_url":"https://api.github.com/users/jbarnett-r7/gists{/gist_id}","starred_url":"https://api.github.com/users/jbarnett-r7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbarnett-r7/subscriptions","organizations_url":"https://api.github.com/users/jbarnett-r7/orgs","repos_url":"https://api.github.com/users/jbarnett-r7/repos","events_url":"https://api.github.com/users/jbarnett-r7/events{/privacy}","received_events_url":"https://api.github.com/users/jbarnett-r7/received_events","type":"User","site_admin":false},"assignees":[{"login":"jbarnett-r7","id":12236529,"avatar_url":"https://avatars0.githubusercontent.com/u/12236529?v=4","gravatar_id":"","url":"https://api.github.com/users/jbarnett-r7","html_url":"https://github.com/jbarnett-r7","followers_url":"https://api.github.com/users/jbarnett-r7/followers","following_url":"https://api.github.com/users/jbarnett-r7/following{/other_user}","gists_url":"https://api.github.com/users/jbarnett-r7/gists{/gist_id}","starred_url":"https://api.github.com/users/jbarnett-r7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbarnett-r7/subscriptions","organizations_url":"https://api.github.com/users/jbarnett-r7/orgs","repos_url":"https://api.github.com/users/jbarnett-r7/repos","events_url":"https://api.github.com/users/jbarnett-r7/events{/privacy}","received_events_url":"https://api.github.com/users/jbarnett-r7/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2017-12-11T23:23:36Z","updated_at":"2017-12-14T19:59:56Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/clee-r7/metasploit-framework/pulls/3","html_url":"https://github.com/clee-r7/metasploit-framework/pull/3","diff_url":"https://github.com/clee-r7/metasploit-framework/pull/3.diff","patch_url":"https://github.com/clee-r7/metasploit-framework/pull/3.patch"},"body":"Move the last Mdm::Session use under db_manager session.\r\n\r\n## Verification\r\n- [x] Start `msfconsole`\r\n- [x] Create one or more sessions\r\n- [x] Exit msfconsole with `exit -y`\r\n- [x] Start `msfconsole`\r\n- [x] Start IRB shell `irb`\r\n- [x] Run `::Mdm::Session.where(closed_at: nil)` and you should note entries for the sessions created above\r\n- [x] **Verify** Mdm::Session records have been marked closed by running the `::Mdm::Session.where(closed_at: nil)` command again in the IRB shell and noting the previous records are no longer returned. Note, you should not have to wait much more than 5 minutes until the `SessionManager` monitor thread calls the `framework.db.remove_stale_sessions` method and successfully cleans up these session DB entries."},"comment":{"url":"https://api.github.com/repos/clee-r7/metasploit-framework/issues/comments/351819786","html_url":"https://github.com/clee-r7/metasploit-framework/pull/3#issuecomment-351819786","issue_url":"https://api.github.com/repos/clee-r7/metasploit-framework/issues/3","id":351819786,"user":{"login":"jbarnett-r7","id":12236529,"avatar_url":"https://avatars0.githubusercontent.com/u/12236529?v=4","gravatar_id":"","url":"https://api.github.com/users/jbarnett-r7","html_url":"https://github.com/jbarnett-r7","followers_url":"https://api.github.com/users/jbarnett-r7/followers","following_url":"https://api.github.com/users/jbarnett-r7/following{/other_user}","gists_url":"https://api.github.com/users/jbarnett-r7/gists{/gist_id}","starred_url":"https://api.github.com/users/jbarnett-r7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbarnett-r7/subscriptions","organizations_url":"https://api.github.com/users/jbarnett-r7/orgs","repos_url":"https://api.github.com/users/jbarnett-r7/repos","events_url":"https://api.github.com/users/jbarnett-r7/events{/privacy}","received_events_url":"https://api.github.com/users/jbarnett-r7/received_events","type":"User","site_admin":false},"created_at":"2017-12-14T19:59:56Z","updated_at":"2017-12-14T19:59:56Z","author_association":"COLLABORATOR","body":"This isn't unexpected, but the sessions do not get marked as orphaned when using a remote data store. This is because the remove_stale_sessions method still doesn't have a proxy. This functionality is eventually going to be moved to the aggregator, so this move to Msf::DBManager is good for now."}}
{"actor":{"display_login":"jbarnett-r7"}}