{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/145947535","pull_request_review_id":70823656,"id":145947535,"diff_hunk":"@@ -10783,7 +10783,23 @@ void LinearScan::resolveEdge(BasicBlock*      fromBlock,\n         regNumber targetReg = genRegNumFromMask(targetRegMask);\n         if (location[targetReg] == REG_NA)\n         {\n-            targetRegsReady |= targetRegMask;\n+#ifdef _TARGET_ARM_\n+            regNumber sourceReg = (regNumber)source[targetReg];\n+            Interval* interval = sourceIntervals[sourceReg];\n+            if (interval->registerType == TYP_DOUBLE)\n+            {\n+                // For ARM32, make sure that two float reigster\n+                // consisting a double register are not used.\n+                assert(genIsValidDoubleReg(targetReg));\n+                regNumber anotherHalfRegNum = REG_NEXT(targetReg);\n+                if (location[anotherHalfRegNum] == REG_NA)\n+                {\n+                    targetRegsReady |= targetRegMask;\n+                }\n+            }\n+            else\n+#endif // _TARGET_ARM_\n+                targetRegsReady |= targetRegMask;","path":"src/jit/lsra.cpp","position":21,"original_position":21,"commit_id":"55043ce016f71edb1a7a4f7d69c6734829b86117","original_commit_id":"55043ce016f71edb1a7a4f7d69c6734829b86117","user":{"login":"hqueue","id":9247907,"avatar_url":"https://avatars1.githubusercontent.com/u/9247907?v=4","gravatar_id":"","url":"https://api.github.com/users/hqueue","html_url":"https://github.com/hqueue","followers_url":"https://api.github.com/users/hqueue/followers","following_url":"https://api.github.com/users/hqueue/following{/other_user}","gists_url":"https://api.github.com/users/hqueue/gists{/gist_id}","starred_url":"https://api.github.com/users/hqueue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hqueue/subscriptions","organizations_url":"https://api.github.com/users/hqueue/orgs","repos_url":"https://api.github.com/users/hqueue/repos","events_url":"https://api.github.com/users/hqueue/events{/privacy}","received_events_url":"https://api.github.com/users/hqueue/received_events","type":"User","site_admin":false},"body":"Is this right place to add logic to handle TYP_DOUBLE ?\r\nBecause I assumes that `targetRegsReady` contains regMask of free registers, I added code to consider two float registers here.\r\n\r\n","created_at":"2017-10-20T12:17:47Z","updated_at":"2017-10-20T12:17:47Z","html_url":"https://github.com/dotnet/coreclr/pull/14614#discussion_r145947535","pull_request_url":"https://api.github.com/repos/dotnet/coreclr/pulls/14614","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/145947535"},"html":{"href":"https://github.com/dotnet/coreclr/pull/14614#discussion_r145947535"},"pull_request":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/14614"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/14614","id":147785320,"html_url":"https://github.com/dotnet/coreclr/pull/14614","diff_url":"https://github.com/dotnet/coreclr/pull/14614.diff","patch_url":"https://github.com/dotnet/coreclr/pull/14614.patch","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/14614","number":14614,"state":"open","locked":false,"title":"[WIP][RyuJIT/ARM32] Fix resolve logic to handle a double register correctly","user":{"login":"hqueue","id":9247907,"avatar_url":"https://avatars1.githubusercontent.com/u/9247907?v=4","gravatar_id":"","url":"https://api.github.com/users/hqueue","html_url":"https://github.com/hqueue","followers_url":"https://api.github.com/users/hqueue/followers","following_url":"https://api.github.com/users/hqueue/following{/other_user}","gists_url":"https://api.github.com/users/hqueue/gists{/gist_id}","starred_url":"https://api.github.com/users/hqueue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hqueue/subscriptions","organizations_url":"https://api.github.com/users/hqueue/orgs","repos_url":"https://api.github.com/users/hqueue/repos","events_url":"https://api.github.com/users/hqueue/events{/privacy}","received_events_url":"https://api.github.com/users/hqueue/received_events","type":"User","site_admin":false},"body":"When generating fromReg to toReg move to resolve edges,\r\nwe have to consider either of fromReg and toReg can contain double type.\r\n\r\nIf TYP_DOUBLE occupies fromReg/toReg, we have to look up two float registers when making decisions.\r\n\r\nThis PR partially resolve an assertion in #14374.\r\n`JIT\\Regression\\CLR-x86-JIT\\V1-M12-Beta2\\b59782\\b59782\\b59782.cmd` is passed with this PR.\r\n\r\nAnd remaining assertion is being previously addressed by PR #14588.","created_at":"2017-10-20T12:12:35Z","updated_at":"2017-10-20T12:17:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"11bf4afcec0f77d71aebc68b0326a4d44d7ffe86","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/coreclr/pulls/14614/commits","review_comments_url":"https://api.github.com/repos/dotnet/coreclr/pulls/14614/comments","review_comment_url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/14614/comments","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/55043ce016f71edb1a7a4f7d69c6734829b86117","head":{"label":"hqueue:arm/ryujit/issue_14374_pr2","ref":"arm/ryujit/issue_14374_pr2","sha":"55043ce016f71edb1a7a4f7d69c6734829b86117","user":{"login":"hqueue","id":9247907,"avatar_url":"https://avatars1.githubusercontent.com/u/9247907?v=4","gravatar_id":"","url":"https://api.github.com/users/hqueue","html_url":"https://github.com/hqueue","followers_url":"https://api.github.com/users/hqueue/followers","following_url":"https://api.github.com/users/hqueue/following{/other_user}","gists_url":"https://api.github.com/users/hqueue/gists{/gist_id}","starred_url":"https://api.github.com/users/hqueue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hqueue/subscriptions","organizations_url":"https://api.github.com/users/hqueue/orgs","repos_url":"https://api.github.com/users/hqueue/repos","events_url":"https://api.github.com/users/hqueue/events{/privacy}","received_events_url":"https://api.github.com/users/hqueue/received_events","type":"User","site_admin":false},"repo":{"id":55405428,"name":"coreclr","full_name":"hqueue/coreclr","owner":{"login":"hqueue","id":9247907,"avatar_url":"https://avatars1.githubusercontent.com/u/9247907?v=4","gravatar_id":"","url":"https://api.github.com/users/hqueue","html_url":"https://github.com/hqueue","followers_url":"https://api.github.com/users/hqueue/followers","following_url":"https://api.github.com/users/hqueue/following{/other_user}","gists_url":"https://api.github.com/users/hqueue/gists{/gist_id}","starred_url":"https://api.github.com/users/hqueue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hqueue/subscriptions","organizations_url":"https://api.github.com/users/hqueue/orgs","repos_url":"https://api.github.com/users/hqueue/repos","events_url":"https://api.github.com/users/hqueue/events{/privacy}","received_events_url":"https://api.github.com/users/hqueue/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hqueue/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called mscorlib. It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes.","fork":true,"url":"https://api.github.com/repos/hqueue/coreclr","forks_url":"https://api.github.com/repos/hqueue/coreclr/forks","keys_url":"https://api.github.com/repos/hqueue/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hqueue/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hqueue/coreclr/teams","hooks_url":"https://api.github.com/repos/hqueue/coreclr/hooks","issue_events_url":"https://api.github.com/repos/hqueue/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/hqueue/coreclr/events","assignees_url":"https://api.github.com/repos/hqueue/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/hqueue/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/hqueue/coreclr/tags","blobs_url":"https://api.github.com/repos/hqueue/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hqueue/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hqueue/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/hqueue/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hqueue/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/hqueue/coreclr/languages","stargazers_url":"https://api.github.com/repos/hqueue/coreclr/stargazers","contributors_url":"https://api.github.com/repos/hqueue/coreclr/contributors","subscribers_url":"https://api.github.com/repos/hqueue/coreclr/subscribers","subscription_url":"https://api.github.com/repos/hqueue/coreclr/subscription","commits_url":"https://api.github.com/repos/hqueue/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/hqueue/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/hqueue/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/hqueue/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/hqueue/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/hqueue/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hqueue/coreclr/merges","archive_url":"https://api.github.com/repos/hqueue/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hqueue/coreclr/downloads","issues_url":"https://api.github.com/repos/hqueue/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/hqueue/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/hqueue/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/hqueue/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hqueue/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/hqueue/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/hqueue/coreclr/deployments","created_at":"2016-04-04T11:20:02Z","updated_at":"2016-04-04T11:21:13Z","pushed_at":"2017-10-20T12:10:12Z","git_url":"git://github.com/hqueue/coreclr.git","ssh_url":"git@github.com:hqueue/coreclr.git","clone_url":"https://github.com/hqueue/coreclr.git","svn_url":"https://github.com/hqueue/coreclr","homepage":"http://dotnet.github.io/","size":185709,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"85819d322a72636eb65128aa2e5dfedc8843e073","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":30092893,"name":"coreclr","full_name":"dotnet/coreclr","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called System.Private.Corelib (or mscorlib). It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes. We welcome contributions.","fork":false,"url":"https://api.github.com/repos/dotnet/coreclr","forks_url":"https://api.github.com/repos/dotnet/coreclr/forks","keys_url":"https://api.github.com/repos/dotnet/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/coreclr/teams","hooks_url":"https://api.github.com/repos/dotnet/coreclr/hooks","issue_events_url":"https://api.github.com/repos/dotnet/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/coreclr/events","assignees_url":"https://api.github.com/repos/dotnet/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/coreclr/tags","blobs_url":"https://api.github.com/repos/dotnet/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/coreclr/languages","stargazers_url":"https://api.github.com/repos/dotnet/coreclr/stargazers","contributors_url":"https://api.github.com/repos/dotnet/coreclr/contributors","subscribers_url":"https://api.github.com/repos/dotnet/coreclr/subscribers","subscription_url":"https://api.github.com/repos/dotnet/coreclr/subscription","commits_url":"https://api.github.com/repos/dotnet/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/coreclr/merges","archive_url":"https://api.github.com/repos/dotnet/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/coreclr/downloads","issues_url":"https://api.github.com/repos/dotnet/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/coreclr/deployments","created_at":"2015-01-30T22:10:02Z","updated_at":"2017-10-20T11:37:26Z","pushed_at":"2017-10-20T12:12:36Z","git_url":"git://github.com/dotnet/coreclr.git","ssh_url":"git@github.com:dotnet/coreclr.git","clone_url":"https://github.com/dotnet/coreclr.git","svn_url":"https://github.com/dotnet/coreclr","homepage":"https://github.com/dotnet/core","size":187433,"stargazers_count":8503,"watchers_count":8503,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2137,"mirror_url":null,"open_issues_count":1499,"forks":2137,"open_issues":1499,"watchers":8503,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/14614"},"html":{"href":"https://github.com/dotnet/coreclr/pull/14614"},"issue":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/14614"},"comments":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/14614/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/14614/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/14614/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/coreclr/statuses/55043ce016f71edb1a7a4f7d69c6734829b86117"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"hqueue"}}