{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/react/pulls/comments/140407997","pull_request_review_id":64477578,"id":140407997,"diff_hunk":"@@ -0,0 +1,33 @@\n+# react-reconciler\n+\n+An npm package to let you create custom reconcilers.\n+\n+## Example Usage\n+\n+```js\n+var createReconciler = require('react-reconciler');\n+\n+var ReconcilerConfig = { /* ... */ };\n+var Reconciler = createReconciler(ReconcilerConfig);\n+var Renderer = {\n+  render(\n+    element: React$Element<any>,\n+    container: DOMContainer,\n+    callback: ?Function,\n+  ) {\n+    let root = container._reactRootContainer;\n+    if (!root) {\n+      const newRoot = Renderer.createContainer(container);","path":"packages/react-reconciler/README.md","position":20,"original_position":20,"commit_id":"6327a0a81589cdb2fd580621a9484e578c911f2d","original_commit_id":"6327a0a81589cdb2fd580621a9484e578c911f2d","user":{"login":"koba04","id":250407,"avatar_url":"https://avatars2.githubusercontent.com/u/250407?v=4","gravatar_id":"","url":"https://api.github.com/users/koba04","html_url":"https://github.com/koba04","followers_url":"https://api.github.com/users/koba04/followers","following_url":"https://api.github.com/users/koba04/following{/other_user}","gists_url":"https://api.github.com/users/koba04/gists{/gist_id}","starred_url":"https://api.github.com/users/koba04/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koba04/subscriptions","organizations_url":"https://api.github.com/users/koba04/orgs","repos_url":"https://api.github.com/users/koba04/repos","events_url":"https://api.github.com/users/koba04/events{/privacy}","received_events_url":"https://api.github.com/users/koba04/received_events","type":"User","site_admin":false},"body":"`Reconciler.createContainer(container);`?","created_at":"2017-09-22T03:55:53Z","updated_at":"2017-09-22T03:55:53Z","html_url":"https://github.com/facebook/react/pull/10758#discussion_r140407997","pull_request_url":"https://api.github.com/repos/facebook/react/pulls/10758","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/facebook/react/pulls/comments/140407997"},"html":{"href":"https://github.com/facebook/react/pull/10758#discussion_r140407997"},"pull_request":{"href":"https://api.github.com/repos/facebook/react/pulls/10758"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/react/pulls/10758","id":142126667,"html_url":"https://github.com/facebook/react/pull/10758","diff_url":"https://github.com/facebook/react/pull/10758.diff","patch_url":"https://github.com/facebook/react/pull/10758.patch","issue_url":"https://api.github.com/repos/facebook/react/issues/10758","number":10758,"state":"open","locked":false,"title":"React reconciler package","user":{"login":"iamdustan","id":227879,"avatar_url":"https://avatars3.githubusercontent.com/u/227879?v=4","gravatar_id":"","url":"https://api.github.com/users/iamdustan","html_url":"https://github.com/iamdustan","followers_url":"https://api.github.com/users/iamdustan/followers","following_url":"https://api.github.com/users/iamdustan/following{/other_user}","gists_url":"https://api.github.com/users/iamdustan/gists{/gist_id}","starred_url":"https://api.github.com/users/iamdustan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iamdustan/subscriptions","organizations_url":"https://api.github.com/users/iamdustan/orgs","repos_url":"https://api.github.com/users/iamdustan/repos","events_url":"https://api.github.com/users/iamdustan/events{/privacy}","received_events_url":"https://api.github.com/users/iamdustan/received_events","type":"User","site_admin":false},"body":"Alternative approach to #10641. Rather than create the entire packaging and bundling script this exposes the React Reconciler as a factory package so all private+global state is unique per reconciler which solves the original concerns raised by @gaearon in https://github.com/facebook/react/issues/9103#issuecomment-319750290.\r\n\r\nI think it also solves the open question *How should we handle React-specific stuff* pretty well since it doesn’t change the current rollup/build script at this point.\r\n\r\nI added a really cheap `fixtures/reconciler/*` directory that requires some manual `node_modules/react-reconciler/cjs/*.js` modifications to test for now, but did test both versions.\r\n\r\nThis also (rather sloppily) modifies the `scripts/rollup` tasks to special case the `react-reconciler` wrapping.\r\n\r\nTODO:\r\n\r\n- [ ] Generate a `react-reconciler.js.flow` file in the output package so external reconcilers can use flow for writing and maintaining reconcilers.\r\n- [x] Versioning scheme? I would suspect this to have separate versioning from React and ReactDOM (https://github.com/facebook/react/pull/10758#discussion_r140011585)\r\n- [x] Change rollup/bundle regex match to a bundle type enum https://github.com/facebook/react/pull/10758#discussion_r140012249\r\n- [x] Unbreak the build\r\n\r\ncc @gaearon  @bvaughn ","created_at":"2017-09-20T15:12:02Z","updated_at":"2017-09-22T03:55:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e25c0f8992edcdb3c09ebabb67519335c4075fcc","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/react/pulls/10758/commits","review_comments_url":"https://api.github.com/repos/facebook/react/pulls/10758/comments","review_comment_url":"https://api.github.com/repos/facebook/react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/react/issues/10758/comments","statuses_url":"https://api.github.com/repos/facebook/react/statuses/6327a0a81589cdb2fd580621a9484e578c911f2d","head":{"label":"iamdustan:react-reconciler-package","ref":"react-reconciler-package","sha":"6327a0a81589cdb2fd580621a9484e578c911f2d","user":{"login":"iamdustan","id":227879,"avatar_url":"https://avatars3.githubusercontent.com/u/227879?v=4","gravatar_id":"","url":"https://api.github.com/users/iamdustan","html_url":"https://github.com/iamdustan","followers_url":"https://api.github.com/users/iamdustan/followers","following_url":"https://api.github.com/users/iamdustan/following{/other_user}","gists_url":"https://api.github.com/users/iamdustan/gists{/gist_id}","starred_url":"https://api.github.com/users/iamdustan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iamdustan/subscriptions","organizations_url":"https://api.github.com/users/iamdustan/orgs","repos_url":"https://api.github.com/users/iamdustan/repos","events_url":"https://api.github.com/users/iamdustan/events{/privacy}","received_events_url":"https://api.github.com/users/iamdustan/received_events","type":"User","site_admin":false},"repo":{"id":30816284,"name":"react","full_name":"iamdustan/react","owner":{"login":"iamdustan","id":227879,"avatar_url":"https://avatars3.githubusercontent.com/u/227879?v=4","gravatar_id":"","url":"https://api.github.com/users/iamdustan","html_url":"https://github.com/iamdustan","followers_url":"https://api.github.com/users/iamdustan/followers","following_url":"https://api.github.com/users/iamdustan/following{/other_user}","gists_url":"https://api.github.com/users/iamdustan/gists{/gist_id}","starred_url":"https://api.github.com/users/iamdustan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iamdustan/subscriptions","organizations_url":"https://api.github.com/users/iamdustan/orgs","repos_url":"https://api.github.com/users/iamdustan/repos","events_url":"https://api.github.com/users/iamdustan/events{/privacy}","received_events_url":"https://api.github.com/users/iamdustan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/iamdustan/react","description":"A declarative, efficient, and flexible JavaScript library for building user interfaces.","fork":true,"url":"https://api.github.com/repos/iamdustan/react","forks_url":"https://api.github.com/repos/iamdustan/react/forks","keys_url":"https://api.github.com/repos/iamdustan/react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iamdustan/react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iamdustan/react/teams","hooks_url":"https://api.github.com/repos/iamdustan/react/hooks","issue_events_url":"https://api.github.com/repos/iamdustan/react/issues/events{/number}","events_url":"https://api.github.com/repos/iamdustan/react/events","assignees_url":"https://api.github.com/repos/iamdustan/react/assignees{/user}","branches_url":"https://api.github.com/repos/iamdustan/react/branches{/branch}","tags_url":"https://api.github.com/repos/iamdustan/react/tags","blobs_url":"https://api.github.com/repos/iamdustan/react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iamdustan/react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iamdustan/react/git/refs{/sha}","trees_url":"https://api.github.com/repos/iamdustan/react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iamdustan/react/statuses/{sha}","languages_url":"https://api.github.com/repos/iamdustan/react/languages","stargazers_url":"https://api.github.com/repos/iamdustan/react/stargazers","contributors_url":"https://api.github.com/repos/iamdustan/react/contributors","subscribers_url":"https://api.github.com/repos/iamdustan/react/subscribers","subscription_url":"https://api.github.com/repos/iamdustan/react/subscription","commits_url":"https://api.github.com/repos/iamdustan/react/commits{/sha}","git_commits_url":"https://api.github.com/repos/iamdustan/react/git/commits{/sha}","comments_url":"https://api.github.com/repos/iamdustan/react/comments{/number}","issue_comment_url":"https://api.github.com/repos/iamdustan/react/issues/comments{/number}","contents_url":"https://api.github.com/repos/iamdustan/react/contents/{+path}","compare_url":"https://api.github.com/repos/iamdustan/react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iamdustan/react/merges","archive_url":"https://api.github.com/repos/iamdustan/react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iamdustan/react/downloads","issues_url":"https://api.github.com/repos/iamdustan/react/issues{/number}","pulls_url":"https://api.github.com/repos/iamdustan/react/pulls{/number}","milestones_url":"https://api.github.com/repos/iamdustan/react/milestones{/number}","notifications_url":"https://api.github.com/repos/iamdustan/react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iamdustan/react/labels{/name}","releases_url":"https://api.github.com/repos/iamdustan/react/releases{/id}","deployments_url":"https://api.github.com/repos/iamdustan/react/deployments","created_at":"2015-02-15T03:06:11Z","updated_at":"2016-05-20T21:20:27Z","pushed_at":"2017-09-21T17:51:23Z","git_url":"git://github.com/iamdustan/react.git","ssh_url":"git@github.com:iamdustan/react.git","clone_url":"https://github.com/iamdustan/react.git","svn_url":"https://github.com/iamdustan/react","homepage":"http://facebook.github.io/react/","size":95378,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"dd00b47e1f3aa0e95047a033786a13a5b0cc064f","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":10270250,"name":"react","full_name":"facebook/react","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/react","description":"A declarative, efficient, and flexible JavaScript library for building user interfaces.","fork":false,"url":"https://api.github.com/repos/facebook/react","forks_url":"https://api.github.com/repos/facebook/react/forks","keys_url":"https://api.github.com/repos/facebook/react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/react/teams","hooks_url":"https://api.github.com/repos/facebook/react/hooks","issue_events_url":"https://api.github.com/repos/facebook/react/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/react/events","assignees_url":"https://api.github.com/repos/facebook/react/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/react/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/react/tags","blobs_url":"https://api.github.com/repos/facebook/react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/react/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/react/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/react/languages","stargazers_url":"https://api.github.com/repos/facebook/react/stargazers","contributors_url":"https://api.github.com/repos/facebook/react/contributors","subscribers_url":"https://api.github.com/repos/facebook/react/subscribers","subscription_url":"https://api.github.com/repos/facebook/react/subscription","commits_url":"https://api.github.com/repos/facebook/react/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/react/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/react/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/react/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/react/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/react/merges","archive_url":"https://api.github.com/repos/facebook/react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/react/downloads","issues_url":"https://api.github.com/repos/facebook/react/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/react/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/react/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/react/labels{/name}","releases_url":"https://api.github.com/repos/facebook/react/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/react/deployments","created_at":"2013-05-24T16:15:54Z","updated_at":"2017-09-22T03:36:12Z","pushed_at":"2017-09-22T01:31:18Z","git_url":"git://github.com/facebook/react.git","ssh_url":"git@github.com:facebook/react.git","clone_url":"https://github.com/facebook/react.git","svn_url":"https://github.com/facebook/react","homepage":"https://facebook.github.io/react/","size":131319,"stargazers_count":76111,"watchers_count":76111,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":14438,"mirror_url":null,"open_issues_count":730,"forks":14438,"open_issues":730,"watchers":76111,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/react/pulls/10758"},"html":{"href":"https://github.com/facebook/react/pull/10758"},"issue":{"href":"https://api.github.com/repos/facebook/react/issues/10758"},"comments":{"href":"https://api.github.com/repos/facebook/react/issues/10758/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/react/pulls/10758/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/react/pulls/10758/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/react/statuses/6327a0a81589cdb2fd580621a9484e578c911f2d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"koba04"}}