{"action":"created","comment":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/103742349","pull_request_review_id":24538455,"id":103742349,"diff_hunk":"@@ -0,0 +1,21 @@\n+/**\n+ * Copyright 2017 The AMP HTML Authors. All Rights Reserved.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ *      http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS-IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+import {ampdocServiceFor} from '../../../src/ampdoc';\n+import {installParallaxForDoc} from '../../../src/service/parallax-impl';\n+\n+const ampdoc = ampdocServiceFor(AMP.win).getAmpDoc();","path":"extensions/amp-fx-parallax/0.1/amp-fx-parallax.js","position":20,"original_position":20,"commit_id":"787b479f7315ee067e4dfb4a62899c57a52ae745","original_commit_id":"787b479f7315ee067e4dfb4a62899c57a52ae745","user":{"login":"aghassemi","id":2099009,"avatar_url":"https://avatars0.githubusercontent.com/u/2099009?v=3","gravatar_id":"","url":"https://api.github.com/users/aghassemi","html_url":"https://github.com/aghassemi","followers_url":"https://api.github.com/users/aghassemi/followers","following_url":"https://api.github.com/users/aghassemi/following{/other_user}","gists_url":"https://api.github.com/users/aghassemi/gists{/gist_id}","starred_url":"https://api.github.com/users/aghassemi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aghassemi/subscriptions","organizations_url":"https://api.github.com/users/aghassemi/orgs","repos_url":"https://api.github.com/users/aghassemi/repos","events_url":"https://api.github.com/users/aghassemi/events{/privacy}","received_events_url":"https://api.github.com/users/aghassemi/received_events","type":"User","site_admin":false},"body":"wrap these in `onDocumentReady`","created_at":"2017-03-01T17:32:57Z","updated_at":"2017-03-01T17:45:36Z","html_url":"https://github.com/ampproject/amphtml/pull/7794#discussion_r103742349","pull_request_url":"https://api.github.com/repos/ampproject/amphtml/pulls/7794","_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/103742349"},"html":{"href":"https://github.com/ampproject/amphtml/pull/7794#discussion_r103742349"},"pull_request":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/7794"}}},"pull_request":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/7794","id":107927483,"html_url":"https://github.com/ampproject/amphtml/pull/7794","diff_url":"https://github.com/ampproject/amphtml/pull/7794.diff","patch_url":"https://github.com/ampproject/amphtml/pull/7794.patch","issue_url":"https://api.github.com/repos/ampproject/amphtml/issues/7794","number":7794,"state":"open","locked":false,"title":"Implement parallax effect extension","user":{"login":"cvializ","id":2363700,"avatar_url":"https://avatars1.githubusercontent.com/u/2363700?v=3","gravatar_id":"","url":"https://api.github.com/users/cvializ","html_url":"https://github.com/cvializ","followers_url":"https://api.github.com/users/cvializ/followers","following_url":"https://api.github.com/users/cvializ/following{/other_user}","gists_url":"https://api.github.com/users/cvializ/gists{/gist_id}","starred_url":"https://api.github.com/users/cvializ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cvializ/subscriptions","organizations_url":"https://api.github.com/users/cvializ/orgs","repos_url":"https://api.github.com/users/cvializ/repos","events_url":"https://api.github.com/users/cvializ/events{/privacy}","received_events_url":"https://api.github.com/users/cvializ/received_events","type":"User","site_admin":false},"body":"- Implements parallax effect extension with tests and usage markdown\r\n- Based on @aghassemi's parallax [deep dive demos](https://ademo-4d170.firebaseapp.com/test/manual/demo/vox.amp.html)\r\n\r\nCloses #1443 ","created_at":"2017-02-24T23:19:18Z","updated_at":"2017-03-01T17:45:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"89e91439f4e9303a74ac35b48f4cc23a44c32779","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ampproject/amphtml/pulls/7794/commits","review_comments_url":"https://api.github.com/repos/ampproject/amphtml/pulls/7794/comments","review_comment_url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ampproject/amphtml/issues/7794/comments","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/787b479f7315ee067e4dfb4a62899c57a52ae745","head":{"label":"cvializ:cv-parallax","ref":"cv-parallax","sha":"787b479f7315ee067e4dfb4a62899c57a52ae745","user":{"login":"cvializ","id":2363700,"avatar_url":"https://avatars1.githubusercontent.com/u/2363700?v=3","gravatar_id":"","url":"https://api.github.com/users/cvializ","html_url":"https://github.com/cvializ","followers_url":"https://api.github.com/users/cvializ/followers","following_url":"https://api.github.com/users/cvializ/following{/other_user}","gists_url":"https://api.github.com/users/cvializ/gists{/gist_id}","starred_url":"https://api.github.com/users/cvializ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cvializ/subscriptions","organizations_url":"https://api.github.com/users/cvializ/orgs","repos_url":"https://api.github.com/users/cvializ/repos","events_url":"https://api.github.com/users/cvializ/events{/privacy}","received_events_url":"https://api.github.com/users/cvializ/received_events","type":"User","site_admin":false},"repo":{"id":81481773,"name":"amphtml","full_name":"cvializ/amphtml","owner":{"login":"cvializ","id":2363700,"avatar_url":"https://avatars1.githubusercontent.com/u/2363700?v=3","gravatar_id":"","url":"https://api.github.com/users/cvializ","html_url":"https://github.com/cvializ","followers_url":"https://api.github.com/users/cvializ/followers","following_url":"https://api.github.com/users/cvializ/following{/other_user}","gists_url":"https://api.github.com/users/cvializ/gists{/gist_id}","starred_url":"https://api.github.com/users/cvializ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cvializ/subscriptions","organizations_url":"https://api.github.com/users/cvializ/orgs","repos_url":"https://api.github.com/users/cvializ/repos","events_url":"https://api.github.com/users/cvializ/events{/privacy}","received_events_url":"https://api.github.com/users/cvializ/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cvializ/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":true,"url":"https://api.github.com/repos/cvializ/amphtml","forks_url":"https://api.github.com/repos/cvializ/amphtml/forks","keys_url":"https://api.github.com/repos/cvializ/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cvializ/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cvializ/amphtml/teams","hooks_url":"https://api.github.com/repos/cvializ/amphtml/hooks","issue_events_url":"https://api.github.com/repos/cvializ/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/cvializ/amphtml/events","assignees_url":"https://api.github.com/repos/cvializ/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/cvializ/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/cvializ/amphtml/tags","blobs_url":"https://api.github.com/repos/cvializ/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cvializ/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cvializ/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/cvializ/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cvializ/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/cvializ/amphtml/languages","stargazers_url":"https://api.github.com/repos/cvializ/amphtml/stargazers","contributors_url":"https://api.github.com/repos/cvializ/amphtml/contributors","subscribers_url":"https://api.github.com/repos/cvializ/amphtml/subscribers","subscription_url":"https://api.github.com/repos/cvializ/amphtml/subscription","commits_url":"https://api.github.com/repos/cvializ/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/cvializ/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/cvializ/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/cvializ/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/cvializ/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/cvializ/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cvializ/amphtml/merges","archive_url":"https://api.github.com/repos/cvializ/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cvializ/amphtml/downloads","issues_url":"https://api.github.com/repos/cvializ/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/cvializ/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/cvializ/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/cvializ/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cvializ/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/cvializ/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/cvializ/amphtml/deployments","created_at":"2017-02-09T18:32:30Z","updated_at":"2017-02-09T18:32:37Z","pushed_at":"2017-03-01T16:57:10Z","git_url":"git://github.com/cvializ/amphtml.git","ssh_url":"git@github.com:cvializ/amphtml.git","clone_url":"https://github.com/cvializ/amphtml.git","svn_url":"https://github.com/cvializ/amphtml","homepage":"https://ampproject.org","size":229590,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ampproject:master","ref":"master","sha":"526173f1d8840cd84ed674befbc54c6c7401632c","user":{"login":"ampproject","id":14114390,"avatar_url":"https://avatars0.githubusercontent.com/u/14114390?v=3","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"repo":{"id":41766002,"name":"amphtml","full_name":"ampproject/amphtml","owner":{"login":"ampproject","id":14114390,"avatar_url":"https://avatars0.githubusercontent.com/u/14114390?v=3","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ampproject/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":false,"url":"https://api.github.com/repos/ampproject/amphtml","forks_url":"https://api.github.com/repos/ampproject/amphtml/forks","keys_url":"https://api.github.com/repos/ampproject/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ampproject/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ampproject/amphtml/teams","hooks_url":"https://api.github.com/repos/ampproject/amphtml/hooks","issue_events_url":"https://api.github.com/repos/ampproject/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/ampproject/amphtml/events","assignees_url":"https://api.github.com/repos/ampproject/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/ampproject/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/ampproject/amphtml/tags","blobs_url":"https://api.github.com/repos/ampproject/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ampproject/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ampproject/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/ampproject/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/ampproject/amphtml/languages","stargazers_url":"https://api.github.com/repos/ampproject/amphtml/stargazers","contributors_url":"https://api.github.com/repos/ampproject/amphtml/contributors","subscribers_url":"https://api.github.com/repos/ampproject/amphtml/subscribers","subscription_url":"https://api.github.com/repos/ampproject/amphtml/subscription","commits_url":"https://api.github.com/repos/ampproject/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/ampproject/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/ampproject/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/ampproject/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/ampproject/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/ampproject/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ampproject/amphtml/merges","archive_url":"https://api.github.com/repos/ampproject/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ampproject/amphtml/downloads","issues_url":"https://api.github.com/repos/ampproject/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/ampproject/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/ampproject/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/ampproject/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ampproject/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/ampproject/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/ampproject/amphtml/deployments","created_at":"2015-09-01T22:10:53Z","updated_at":"2017-03-01T16:17:01Z","pushed_at":"2017-03-01T17:16:25Z","git_url":"git://github.com/ampproject/amphtml.git","ssh_url":"git@github.com:ampproject/amphtml.git","clone_url":"https://github.com/ampproject/amphtml.git","svn_url":"https://github.com/ampproject/amphtml","homepage":"https://ampproject.org","size":229485,"stargazers_count":9669,"watchers_count":9669,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1596,"mirror_url":null,"open_issues_count":644,"forks":1596,"open_issues":644,"watchers":9669,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/7794"},"html":{"href":"https://github.com/ampproject/amphtml/pull/7794"},"issue":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/7794"},"comments":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/7794/comments"},"review_comments":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/7794/comments"},"review_comment":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/7794/commits"},"statuses":{"href":"https://api.github.com/repos/ampproject/amphtml/statuses/787b479f7315ee067e4dfb4a62899c57a52ae745"}}}}
{"actor":{"display_login":"aghassemi"}}