{"action":"closed","number":17,"pull_request":{"url":"https://api.github.com/repos/nunit/vs-project-loader/pulls/17","id":137097565,"html_url":"https://github.com/nunit/vs-project-loader/pull/17","diff_url":"https://github.com/nunit/vs-project-loader/pull/17.diff","patch_url":"https://github.com/nunit/vs-project-loader/pull/17.patch","issue_url":"https://api.github.com/repos/nunit/vs-project-loader/issues/17","number":17,"state":"closed","locked":false,"title":"Fix for issue 16","user":{"login":"ManfredLange","id":1130812,"avatar_url":"https://avatars2.githubusercontent.com/u/1130812?v=4","gravatar_id":"","url":"https://api.github.com/users/ManfredLange","html_url":"https://github.com/ManfredLange","followers_url":"https://api.github.com/users/ManfredLange/followers","following_url":"https://api.github.com/users/ManfredLange/following{/other_user}","gists_url":"https://api.github.com/users/ManfredLange/gists{/gist_id}","starred_url":"https://api.github.com/users/ManfredLange/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManfredLange/subscriptions","organizations_url":"https://api.github.com/users/ManfredLange/orgs","repos_url":"https://api.github.com/users/ManfredLange/repos","events_url":"https://api.github.com/users/ManfredLange/events{/privacy}","received_events_url":"https://api.github.com/users/ManfredLange/received_events","type":"User","site_admin":false},"body":"As per Charlie Poole's suggestion vs-project-loader should not be aware of what unit testing framework is used. This decision is made by the nunit engine and the drivers it uses. As a consequence the method CheckProjectReferencesNunit() has been removed from class VSSolution.\r\n\r\nI added a test including two new files as test resource and then applied this change. Trafis-CI is passing for the linux targets as well. MacOS has been queued but I do not expect any surprises.\r\n\r\nBecause of this change I had to adjust the implementation of test FromSolutionWithNonNunitTestProject() as we no longer let vs-project-loader decide whether or not a project contains tests. Instead this is left to the NUnit engine and the drivers it is using as per @CharliePoole 's suggestion.\r\n\r\nPlease review and comment if you require any further changes for this pull request to be acceptable.","created_at":"2017-08-22T22:59:27Z","updated_at":"2017-08-23T02:07:17Z","closed_at":"2017-08-23T02:07:17Z","merged_at":"2017-08-23T02:07:17Z","merge_commit_sha":"79326f07ccf54e6460bf5f5496f30e804131175f","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/nunit/vs-project-loader/pulls/17/commits","review_comments_url":"https://api.github.com/repos/nunit/vs-project-loader/pulls/17/comments","review_comment_url":"https://api.github.com/repos/nunit/vs-project-loader/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nunit/vs-project-loader/issues/17/comments","statuses_url":"https://api.github.com/repos/nunit/vs-project-loader/statuses/cc81ee49431bc4b9840d394f693ed81b9f92c9a0","head":{"label":"ManfredLange:issue-16","ref":"issue-16","sha":"cc81ee49431bc4b9840d394f693ed81b9f92c9a0","user":{"login":"ManfredLange","id":1130812,"avatar_url":"https://avatars2.githubusercontent.com/u/1130812?v=4","gravatar_id":"","url":"https://api.github.com/users/ManfredLange","html_url":"https://github.com/ManfredLange","followers_url":"https://api.github.com/users/ManfredLange/followers","following_url":"https://api.github.com/users/ManfredLange/following{/other_user}","gists_url":"https://api.github.com/users/ManfredLange/gists{/gist_id}","starred_url":"https://api.github.com/users/ManfredLange/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManfredLange/subscriptions","organizations_url":"https://api.github.com/users/ManfredLange/orgs","repos_url":"https://api.github.com/users/ManfredLange/repos","events_url":"https://api.github.com/users/ManfredLange/events{/privacy}","received_events_url":"https://api.github.com/users/ManfredLange/received_events","type":"User","site_admin":false},"repo":{"id":99209869,"name":"vs-project-loader","full_name":"ManfredLange/vs-project-loader","owner":{"login":"ManfredLange","id":1130812,"avatar_url":"https://avatars2.githubusercontent.com/u/1130812?v=4","gravatar_id":"","url":"https://api.github.com/users/ManfredLange","html_url":"https://github.com/ManfredLange","followers_url":"https://api.github.com/users/ManfredLange/followers","following_url":"https://api.github.com/users/ManfredLange/following{/other_user}","gists_url":"https://api.github.com/users/ManfredLange/gists{/gist_id}","starred_url":"https://api.github.com/users/ManfredLange/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManfredLange/subscriptions","organizations_url":"https://api.github.com/users/ManfredLange/orgs","repos_url":"https://api.github.com/users/ManfredLange/repos","events_url":"https://api.github.com/users/ManfredLange/events{/privacy}","received_events_url":"https://api.github.com/users/ManfredLange/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ManfredLange/vs-project-loader","description":"NUnit engine extension that enables loading of VS projects and solutions","fork":true,"url":"https://api.github.com/repos/ManfredLange/vs-project-loader","forks_url":"https://api.github.com/repos/ManfredLange/vs-project-loader/forks","keys_url":"https://api.github.com/repos/ManfredLange/vs-project-loader/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManfredLange/vs-project-loader/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManfredLange/vs-project-loader/teams","hooks_url":"https://api.github.com/repos/ManfredLange/vs-project-loader/hooks","issue_events_url":"https://api.github.com/repos/ManfredLange/vs-project-loader/issues/events{/number}","events_url":"https://api.github.com/repos/ManfredLange/vs-project-loader/events","assignees_url":"https://api.github.com/repos/ManfredLange/vs-project-loader/assignees{/user}","branches_url":"https://api.github.com/repos/ManfredLange/vs-project-loader/branches{/branch}","tags_url":"https://api.github.com/repos/ManfredLange/vs-project-loader/tags","blobs_url":"https://api.github.com/repos/ManfredLange/vs-project-loader/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManfredLange/vs-project-loader/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManfredLange/vs-project-loader/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManfredLange/vs-project-loader/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManfredLange/vs-project-loader/statuses/{sha}","languages_url":"https://api.github.com/repos/ManfredLange/vs-project-loader/languages","stargazers_url":"https://api.github.com/repos/ManfredLange/vs-project-loader/stargazers","contributors_url":"https://api.github.com/repos/ManfredLange/vs-project-loader/contributors","subscribers_url":"https://api.github.com/repos/ManfredLange/vs-project-loader/subscribers","subscription_url":"https://api.github.com/repos/ManfredLange/vs-project-loader/subscription","commits_url":"https://api.github.com/repos/ManfredLange/vs-project-loader/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManfredLange/vs-project-loader/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManfredLange/vs-project-loader/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManfredLange/vs-project-loader/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManfredLange/vs-project-loader/contents/{+path}","compare_url":"https://api.github.com/repos/ManfredLange/vs-project-loader/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManfredLange/vs-project-loader/merges","archive_url":"https://api.github.com/repos/ManfredLange/vs-project-loader/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManfredLange/vs-project-loader/downloads","issues_url":"https://api.github.com/repos/ManfredLange/vs-project-loader/issues{/number}","pulls_url":"https://api.github.com/repos/ManfredLange/vs-project-loader/pulls{/number}","milestones_url":"https://api.github.com/repos/ManfredLange/vs-project-loader/milestones{/number}","notifications_url":"https://api.github.com/repos/ManfredLange/vs-project-loader/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManfredLange/vs-project-loader/labels{/name}","releases_url":"https://api.github.com/repos/ManfredLange/vs-project-loader/releases{/id}","deployments_url":"https://api.github.com/repos/ManfredLange/vs-project-loader/deployments","created_at":"2017-08-03T08:31:37Z","updated_at":"2017-08-03T08:31:39Z","pushed_at":"2017-08-22T22:16:11Z","git_url":"git://github.com/ManfredLange/vs-project-loader.git","ssh_url":"git@github.com:ManfredLange/vs-project-loader.git","clone_url":"https://github.com/ManfredLange/vs-project-loader.git","svn_url":"https://github.com/ManfredLange/vs-project-loader","homepage":null,"size":60,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nunit:master","ref":"master","sha":"94e0418de688ef59ece06e4729f0ae48ed1cda7a","user":{"login":"nunit","id":2678858,"avatar_url":"https://avatars0.githubusercontent.com/u/2678858?v=4","gravatar_id":"","url":"https://api.github.com/users/nunit","html_url":"https://github.com/nunit","followers_url":"https://api.github.com/users/nunit/followers","following_url":"https://api.github.com/users/nunit/following{/other_user}","gists_url":"https://api.github.com/users/nunit/gists{/gist_id}","starred_url":"https://api.github.com/users/nunit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nunit/subscriptions","organizations_url":"https://api.github.com/users/nunit/orgs","repos_url":"https://api.github.com/users/nunit/repos","events_url":"https://api.github.com/users/nunit/events{/privacy}","received_events_url":"https://api.github.com/users/nunit/received_events","type":"Organization","site_admin":false},"repo":{"id":66984286,"name":"vs-project-loader","full_name":"nunit/vs-project-loader","owner":{"login":"nunit","id":2678858,"avatar_url":"https://avatars0.githubusercontent.com/u/2678858?v=4","gravatar_id":"","url":"https://api.github.com/users/nunit","html_url":"https://github.com/nunit","followers_url":"https://api.github.com/users/nunit/followers","following_url":"https://api.github.com/users/nunit/following{/other_user}","gists_url":"https://api.github.com/users/nunit/gists{/gist_id}","starred_url":"https://api.github.com/users/nunit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nunit/subscriptions","organizations_url":"https://api.github.com/users/nunit/orgs","repos_url":"https://api.github.com/users/nunit/repos","events_url":"https://api.github.com/users/nunit/events{/privacy}","received_events_url":"https://api.github.com/users/nunit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nunit/vs-project-loader","description":"NUnit engine extension that enables loading of VS projects and solutions","fork":false,"url":"https://api.github.com/repos/nunit/vs-project-loader","forks_url":"https://api.github.com/repos/nunit/vs-project-loader/forks","keys_url":"https://api.github.com/repos/nunit/vs-project-loader/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nunit/vs-project-loader/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nunit/vs-project-loader/teams","hooks_url":"https://api.github.com/repos/nunit/vs-project-loader/hooks","issue_events_url":"https://api.github.com/repos/nunit/vs-project-loader/issues/events{/number}","events_url":"https://api.github.com/repos/nunit/vs-project-loader/events","assignees_url":"https://api.github.com/repos/nunit/vs-project-loader/assignees{/user}","branches_url":"https://api.github.com/repos/nunit/vs-project-loader/branches{/branch}","tags_url":"https://api.github.com/repos/nunit/vs-project-loader/tags","blobs_url":"https://api.github.com/repos/nunit/vs-project-loader/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nunit/vs-project-loader/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nunit/vs-project-loader/git/refs{/sha}","trees_url":"https://api.github.com/repos/nunit/vs-project-loader/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nunit/vs-project-loader/statuses/{sha}","languages_url":"https://api.github.com/repos/nunit/vs-project-loader/languages","stargazers_url":"https://api.github.com/repos/nunit/vs-project-loader/stargazers","contributors_url":"https://api.github.com/repos/nunit/vs-project-loader/contributors","subscribers_url":"https://api.github.com/repos/nunit/vs-project-loader/subscribers","subscription_url":"https://api.github.com/repos/nunit/vs-project-loader/subscription","commits_url":"https://api.github.com/repos/nunit/vs-project-loader/commits{/sha}","git_commits_url":"https://api.github.com/repos/nunit/vs-project-loader/git/commits{/sha}","comments_url":"https://api.github.com/repos/nunit/vs-project-loader/comments{/number}","issue_comment_url":"https://api.github.com/repos/nunit/vs-project-loader/issues/comments{/number}","contents_url":"https://api.github.com/repos/nunit/vs-project-loader/contents/{+path}","compare_url":"https://api.github.com/repos/nunit/vs-project-loader/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nunit/vs-project-loader/merges","archive_url":"https://api.github.com/repos/nunit/vs-project-loader/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nunit/vs-project-loader/downloads","issues_url":"https://api.github.com/repos/nunit/vs-project-loader/issues{/number}","pulls_url":"https://api.github.com/repos/nunit/vs-project-loader/pulls{/number}","milestones_url":"https://api.github.com/repos/nunit/vs-project-loader/milestones{/number}","notifications_url":"https://api.github.com/repos/nunit/vs-project-loader/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nunit/vs-project-loader/labels{/name}","releases_url":"https://api.github.com/repos/nunit/vs-project-loader/releases{/id}","deployments_url":"https://api.github.com/repos/nunit/vs-project-loader/deployments","created_at":"2016-08-30T23:10:43Z","updated_at":"2016-09-27T01:16:36Z","pushed_at":"2017-08-23T02:07:17Z","git_url":"git://github.com/nunit/vs-project-loader.git","ssh_url":"git@github.com:nunit/vs-project-loader.git","clone_url":"https://github.com/nunit/vs-project-loader.git","svn_url":"https://github.com/nunit/vs-project-loader","homepage":null,"size":70,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":3,"forks":2,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nunit/vs-project-loader/pulls/17"},"html":{"href":"https://github.com/nunit/vs-project-loader/pull/17"},"issue":{"href":"https://api.github.com/repos/nunit/vs-project-loader/issues/17"},"comments":{"href":"https://api.github.com/repos/nunit/vs-project-loader/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/nunit/vs-project-loader/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/nunit/vs-project-loader/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nunit/vs-project-loader/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/nunit/vs-project-loader/statuses/cc81ee49431bc4b9840d394f693ed81b9f92c9a0"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"CharliePoole","id":2678661,"avatar_url":"https://avatars2.githubusercontent.com/u/2678661?v=4","gravatar_id":"","url":"https://api.github.com/users/CharliePoole","html_url":"https://github.com/CharliePoole","followers_url":"https://api.github.com/users/CharliePoole/followers","following_url":"https://api.github.com/users/CharliePoole/following{/other_user}","gists_url":"https://api.github.com/users/CharliePoole/gists{/gist_id}","starred_url":"https://api.github.com/users/CharliePoole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CharliePoole/subscriptions","organizations_url":"https://api.github.com/users/CharliePoole/orgs","repos_url":"https://api.github.com/users/CharliePoole/repos","events_url":"https://api.github.com/users/CharliePoole/events{/privacy}","received_events_url":"https://api.github.com/users/CharliePoole/received_events","type":"User","site_admin":false},"comments":2,"review_comments":1,"maintainer_can_modify":false,"commits":1,"additions":97,"deletions":33,"changed_files":5}}
{"actor":{"display_login":"CharliePoole"}}