{"action":"created","comment":{"url":"https://api.github.com/repos/rails/webpacker/pulls/comments/133916062","pull_request_review_id":57150956,"id":133916062,"diff_hunk":"@@ -3,14 +3,16 @@ require \"webpacker/configuration\"\n namespace :webpacker do\n   desc \"Verifies if webpacker is installed\"\n   task verify_install: [:check_node, :check_yarn, :check_binstubs] do\n-    if Webpacker.config.config_path.exist?","path":"lib/tasks/webpacker/verify_install.rake","position":null,"original_position":4,"commit_id":"f14935f7d34382ed116dd12bdc60f6b13705bbde","original_commit_id":"ab4eb01755a625fd98a9f3ec1abeae25d958126e","user":{"login":"justin808","id":1118459,"avatar_url":"https://avatars2.githubusercontent.com/u/1118459?v=4","gravatar_id":"","url":"https://api.github.com/users/justin808","html_url":"https://github.com/justin808","followers_url":"https://api.github.com/users/justin808/followers","following_url":"https://api.github.com/users/justin808/following{/other_user}","gists_url":"https://api.github.com/users/justin808/gists{/gist_id}","starred_url":"https://api.github.com/users/justin808/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justin808/subscriptions","organizations_url":"https://api.github.com/users/justin808/orgs","repos_url":"https://api.github.com/users/justin808/repos","events_url":"https://api.github.com/users/justin808/events{/privacy}","received_events_url":"https://api.github.com/users/justin808/received_events","type":"User","site_admin":false},"body":"The :check_binstubs is the issue, not the part below.","created_at":"2017-08-18T09:23:20Z","updated_at":"2017-08-18T09:39:47Z","html_url":"https://github.com/rails/webpacker/pull/656#discussion_r133916062","pull_request_url":"https://api.github.com/repos/rails/webpacker/pulls/656","_links":{"self":{"href":"https://api.github.com/repos/rails/webpacker/pulls/comments/133916062"},"html":{"href":"https://github.com/rails/webpacker/pull/656#discussion_r133916062"},"pull_request":{"href":"https://api.github.com/repos/rails/webpacker/pulls/656"}}},"pull_request":{"url":"https://api.github.com/repos/rails/webpacker/pulls/656","id":135964792,"html_url":"https://github.com/rails/webpacker/pull/656","diff_url":"https://github.com/rails/webpacker/pull/656.diff","patch_url":"https://github.com/rails/webpacker/pull/656.patch","issue_url":"https://api.github.com/repos/rails/webpacker/issues/656","number":656,"state":"open","locked":false,"title":"configuration.rb, manifest.rb to handle no compile","user":{"login":"justin808","id":1118459,"avatar_url":"https://avatars2.githubusercontent.com/u/1118459?v=4","gravatar_id":"","url":"https://api.github.com/users/justin808","html_url":"https://github.com/justin808","followers_url":"https://api.github.com/users/justin808/followers","following_url":"https://api.github.com/users/justin808/following{/other_user}","gists_url":"https://api.github.com/users/justin808/gists{/gist_id}","starred_url":"https://api.github.com/users/justin808/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justin808/subscriptions","organizations_url":"https://api.github.com/users/justin808/orgs","repos_url":"https://api.github.com/users/justin808/repos","events_url":"https://api.github.com/users/justin808/events{/privacy}","received_events_url":"https://api.github.com/users/justin808/received_events","type":"User","site_admin":false},"body":"We need the ability to turn off the default compilation for precompile. \r\n\r\nThis fix addresses the cases where compile is disabled:\r\n\r\n1. If React on Rails depends on Webpacker, but the React on Rails\r\ninstaller has not yet generated a webpacker.yml file or a React on Rails\r\ninstallation is not using Webpacker, then the gem loading of Webpacker\r\nwill crash due to the missing config file.\r\n\r\n2. If React on Rails has its own helper to compile assets for tests,\r\nthen the manifest might need to get reloaded after Webpacker statically\r\nloads.\r\n\r\n","created_at":"2017-08-16T08:12:03Z","updated_at":"2017-08-18T09:39:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"554960dcf311a367396e970f3999ca60ad828288","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/rails/webpacker/pulls/656/commits","review_comments_url":"https://api.github.com/repos/rails/webpacker/pulls/656/comments","review_comment_url":"https://api.github.com/repos/rails/webpacker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rails/webpacker/issues/656/comments","statuses_url":"https://api.github.com/repos/rails/webpacker/statuses/f14935f7d34382ed116dd12bdc60f6b13705bbde","head":{"label":"shakacode:issue-464-merge-webpacker-lite-into-webpacker-v3","ref":"issue-464-merge-webpacker-lite-into-webpacker-v3","sha":"f14935f7d34382ed116dd12bdc60f6b13705bbde","user":{"login":"shakacode","id":13779463,"avatar_url":"https://avatars3.githubusercontent.com/u/13779463?v=4","gravatar_id":"","url":"https://api.github.com/users/shakacode","html_url":"https://github.com/shakacode","followers_url":"https://api.github.com/users/shakacode/followers","following_url":"https://api.github.com/users/shakacode/following{/other_user}","gists_url":"https://api.github.com/users/shakacode/gists{/gist_id}","starred_url":"https://api.github.com/users/shakacode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shakacode/subscriptions","organizations_url":"https://api.github.com/users/shakacode/orgs","repos_url":"https://api.github.com/users/shakacode/repos","events_url":"https://api.github.com/users/shakacode/events{/privacy}","received_events_url":"https://api.github.com/users/shakacode/received_events","type":"Organization","site_admin":false},"repo":{"id":85431399,"name":"webpacker","full_name":"shakacode/webpacker","owner":{"login":"shakacode","id":13779463,"avatar_url":"https://avatars3.githubusercontent.com/u/13779463?v=4","gravatar_id":"","url":"https://api.github.com/users/shakacode","html_url":"https://github.com/shakacode","followers_url":"https://api.github.com/users/shakacode/followers","following_url":"https://api.github.com/users/shakacode/following{/other_user}","gists_url":"https://api.github.com/users/shakacode/gists{/gist_id}","starred_url":"https://api.github.com/users/shakacode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shakacode/subscriptions","organizations_url":"https://api.github.com/users/shakacode/orgs","repos_url":"https://api.github.com/users/shakacode/repos","events_url":"https://api.github.com/users/shakacode/events{/privacy}","received_events_url":"https://api.github.com/users/shakacode/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/shakacode/webpacker","description":"Use Webpack to manage app-like JavaScript modules in Rails","fork":true,"url":"https://api.github.com/repos/shakacode/webpacker","forks_url":"https://api.github.com/repos/shakacode/webpacker/forks","keys_url":"https://api.github.com/repos/shakacode/webpacker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shakacode/webpacker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shakacode/webpacker/teams","hooks_url":"https://api.github.com/repos/shakacode/webpacker/hooks","issue_events_url":"https://api.github.com/repos/shakacode/webpacker/issues/events{/number}","events_url":"https://api.github.com/repos/shakacode/webpacker/events","assignees_url":"https://api.github.com/repos/shakacode/webpacker/assignees{/user}","branches_url":"https://api.github.com/repos/shakacode/webpacker/branches{/branch}","tags_url":"https://api.github.com/repos/shakacode/webpacker/tags","blobs_url":"https://api.github.com/repos/shakacode/webpacker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shakacode/webpacker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shakacode/webpacker/git/refs{/sha}","trees_url":"https://api.github.com/repos/shakacode/webpacker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shakacode/webpacker/statuses/{sha}","languages_url":"https://api.github.com/repos/shakacode/webpacker/languages","stargazers_url":"https://api.github.com/repos/shakacode/webpacker/stargazers","contributors_url":"https://api.github.com/repos/shakacode/webpacker/contributors","subscribers_url":"https://api.github.com/repos/shakacode/webpacker/subscribers","subscription_url":"https://api.github.com/repos/shakacode/webpacker/subscription","commits_url":"https://api.github.com/repos/shakacode/webpacker/commits{/sha}","git_commits_url":"https://api.github.com/repos/shakacode/webpacker/git/commits{/sha}","comments_url":"https://api.github.com/repos/shakacode/webpacker/comments{/number}","issue_comment_url":"https://api.github.com/repos/shakacode/webpacker/issues/comments{/number}","contents_url":"https://api.github.com/repos/shakacode/webpacker/contents/{+path}","compare_url":"https://api.github.com/repos/shakacode/webpacker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shakacode/webpacker/merges","archive_url":"https://api.github.com/repos/shakacode/webpacker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shakacode/webpacker/downloads","issues_url":"https://api.github.com/repos/shakacode/webpacker/issues{/number}","pulls_url":"https://api.github.com/repos/shakacode/webpacker/pulls{/number}","milestones_url":"https://api.github.com/repos/shakacode/webpacker/milestones{/number}","notifications_url":"https://api.github.com/repos/shakacode/webpacker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shakacode/webpacker/labels{/name}","releases_url":"https://api.github.com/repos/shakacode/webpacker/releases{/id}","deployments_url":"https://api.github.com/repos/shakacode/webpacker/deployments","created_at":"2017-03-18T20:53:33Z","updated_at":"2017-03-18T20:53:34Z","pushed_at":"2017-08-18T09:23:06Z","git_url":"git://github.com/shakacode/webpacker.git","ssh_url":"git@github.com:shakacode/webpacker.git","clone_url":"https://github.com/shakacode/webpacker.git","svn_url":"https://github.com/shakacode/webpacker","homepage":null,"size":444,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rails:master","ref":"master","sha":"bd99b3274817e9dde8e2a43b3baf13c4138a07b4","user":{"login":"rails","id":4223,"avatar_url":"https://avatars1.githubusercontent.com/u/4223?v=4","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"repo":{"id":75785147,"name":"webpacker","full_name":"rails/webpacker","owner":{"login":"rails","id":4223,"avatar_url":"https://avatars1.githubusercontent.com/u/4223?v=4","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rails/webpacker","description":"Use Webpack to manage app-like JavaScript modules in Rails","fork":false,"url":"https://api.github.com/repos/rails/webpacker","forks_url":"https://api.github.com/repos/rails/webpacker/forks","keys_url":"https://api.github.com/repos/rails/webpacker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rails/webpacker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rails/webpacker/teams","hooks_url":"https://api.github.com/repos/rails/webpacker/hooks","issue_events_url":"https://api.github.com/repos/rails/webpacker/issues/events{/number}","events_url":"https://api.github.com/repos/rails/webpacker/events","assignees_url":"https://api.github.com/repos/rails/webpacker/assignees{/user}","branches_url":"https://api.github.com/repos/rails/webpacker/branches{/branch}","tags_url":"https://api.github.com/repos/rails/webpacker/tags","blobs_url":"https://api.github.com/repos/rails/webpacker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rails/webpacker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rails/webpacker/git/refs{/sha}","trees_url":"https://api.github.com/repos/rails/webpacker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rails/webpacker/statuses/{sha}","languages_url":"https://api.github.com/repos/rails/webpacker/languages","stargazers_url":"https://api.github.com/repos/rails/webpacker/stargazers","contributors_url":"https://api.github.com/repos/rails/webpacker/contributors","subscribers_url":"https://api.github.com/repos/rails/webpacker/subscribers","subscription_url":"https://api.github.com/repos/rails/webpacker/subscription","commits_url":"https://api.github.com/repos/rails/webpacker/commits{/sha}","git_commits_url":"https://api.github.com/repos/rails/webpacker/git/commits{/sha}","comments_url":"https://api.github.com/repos/rails/webpacker/comments{/number}","issue_comment_url":"https://api.github.com/repos/rails/webpacker/issues/comments{/number}","contents_url":"https://api.github.com/repos/rails/webpacker/contents/{+path}","compare_url":"https://api.github.com/repos/rails/webpacker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rails/webpacker/merges","archive_url":"https://api.github.com/repos/rails/webpacker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rails/webpacker/downloads","issues_url":"https://api.github.com/repos/rails/webpacker/issues{/number}","pulls_url":"https://api.github.com/repos/rails/webpacker/pulls{/number}","milestones_url":"https://api.github.com/repos/rails/webpacker/milestones{/number}","notifications_url":"https://api.github.com/repos/rails/webpacker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rails/webpacker/labels{/name}","releases_url":"https://api.github.com/repos/rails/webpacker/releases{/id}","deployments_url":"https://api.github.com/repos/rails/webpacker/deployments","created_at":"2016-12-07T00:55:03Z","updated_at":"2017-08-18T09:21:13Z","pushed_at":"2017-08-18T09:23:08Z","git_url":"git://github.com/rails/webpacker.git","ssh_url":"git@github.com:rails/webpacker.git","clone_url":"https://github.com/rails/webpacker.git","svn_url":"https://github.com/rails/webpacker","homepage":null,"size":409,"stargazers_count":2004,"watchers_count":2004,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":230,"mirror_url":null,"open_issues_count":26,"forks":230,"open_issues":26,"watchers":2004,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rails/webpacker/pulls/656"},"html":{"href":"https://github.com/rails/webpacker/pull/656"},"issue":{"href":"https://api.github.com/repos/rails/webpacker/issues/656"},"comments":{"href":"https://api.github.com/repos/rails/webpacker/issues/656/comments"},"review_comments":{"href":"https://api.github.com/repos/rails/webpacker/pulls/656/comments"},"review_comment":{"href":"https://api.github.com/repos/rails/webpacker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rails/webpacker/pulls/656/commits"},"statuses":{"href":"https://api.github.com/repos/rails/webpacker/statuses/f14935f7d34382ed116dd12bdc60f6b13705bbde"}}}}
{"actor":{"display_login":"justin808"}}