{"action":"opened","number":31,"pull_request":{"url":"https://api.github.com/repos/Ada-C7/ride-share-two/pulls/31","id":110331967,"html_url":"https://github.com/Ada-C7/ride-share-two/pull/31","diff_url":"https://github.com/Ada-C7/ride-share-two/pull/31.diff","patch_url":"https://github.com/Ada-C7/ride-share-two/pull/31.patch","issue_url":"https://api.github.com/repos/Ada-C7/ride-share-two/issues/31","number":31,"state":"open","locked":false,"title":"Queues - Elizabeth Deutsch - Ride-Share-Two","user":{"login":"edeutschie","id":17891462,"avatar_url":"https://avatars0.githubusercontent.com/u/17891462?v=3","gravatar_id":"","url":"https://api.github.com/users/edeutschie","html_url":"https://github.com/edeutschie","followers_url":"https://api.github.com/users/edeutschie/followers","following_url":"https://api.github.com/users/edeutschie/following{/other_user}","gists_url":"https://api.github.com/users/edeutschie/gists{/gist_id}","starred_url":"https://api.github.com/users/edeutschie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edeutschie/subscriptions","organizations_url":"https://api.github.com/users/edeutschie/orgs","repos_url":"https://api.github.com/users/edeutschie/repos","events_url":"https://api.github.com/users/edeutschie/events{/privacy}","received_events_url":"https://api.github.com/users/edeutschie/received_events","type":"User","site_admin":false},"body":"# Ride Share\r\nCongratulations! You're submitting your assignment!\r\n\r\n## Comprehension Questions\r\n| Question | Answer    |\r\n| :------------- | :------------- |\r\n| Describe a design decision you had to make when working on this project. What options were you considering? What helped you make your final decision? |   One design decision for me was whether or not to use an array or a hash to access the CSV data in the initialize methods.  I chose to go with an array because I had familiarity with that format from the Bank Accounts project.  Arrays seemed to work fine, but if I had time, I would like to refactor it to use hashes so that I could have a better understanding of how to use hashes in a scenario like this.     |\r\n| Describe a concept that you gained more clarity on as you worked on this assignment. | I gained more clarity on how methods can be called across classes and how drawing diagrams like the farmer's market diagram we worked with in class can help me visualize those connections and plan how to write them in code form.   |\r\n| Describe a _nominal test_ that you wrote for this assignment. |  A nominal test I wrote for the Driver class for the find_driver method was to look for a driver with an ID I knew existed and test to make sure an instance of the Driver class was returned when the method was called.    |\r\n| Describe an _edge case test_ that you wrote for this assignment. |  I wrote some edge case tests in the Driver class for the find_driver method.  There were 100 drivers in the CSV file.  I wrote one test to look for the driver with driver_id 100 (to make sure it returned an instance of the Driver class) and one to look for the driver with driver_id 101 (to make sure it returned \"not a driver\").  |\r\n| How do you feel you did in writing pseudocode first, then writing the tests and then the code? |  I am much better at writing tests and then the code.  I still need to work on writing pseudocode first.  It doesn't come as automatically.  |\r\n","created_at":"2017-03-13T03:03:28Z","updated_at":"2017-03-13T03:03:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Ada-C7/ride-share-two/pulls/31/commits","review_comments_url":"https://api.github.com/repos/Ada-C7/ride-share-two/pulls/31/comments","review_comment_url":"https://api.github.com/repos/Ada-C7/ride-share-two/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Ada-C7/ride-share-two/issues/31/comments","statuses_url":"https://api.github.com/repos/Ada-C7/ride-share-two/statuses/f01eb47b444711ed23432f5e0d82548e657307f6","head":{"label":"edeutschie:master","ref":"master","sha":"f01eb47b444711ed23432f5e0d82548e657307f6","user":{"login":"edeutschie","id":17891462,"avatar_url":"https://avatars0.githubusercontent.com/u/17891462?v=3","gravatar_id":"","url":"https://api.github.com/users/edeutschie","html_url":"https://github.com/edeutschie","followers_url":"https://api.github.com/users/edeutschie/followers","following_url":"https://api.github.com/users/edeutschie/following{/other_user}","gists_url":"https://api.github.com/users/edeutschie/gists{/gist_id}","starred_url":"https://api.github.com/users/edeutschie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edeutschie/subscriptions","organizations_url":"https://api.github.com/users/edeutschie/orgs","repos_url":"https://api.github.com/users/edeutschie/repos","events_url":"https://api.github.com/users/edeutschie/events{/privacy}","received_events_url":"https://api.github.com/users/edeutschie/received_events","type":"User","site_admin":false},"repo":{"id":84132385,"name":"ride-share-two","full_name":"edeutschie/ride-share-two","owner":{"login":"edeutschie","id":17891462,"avatar_url":"https://avatars0.githubusercontent.com/u/17891462?v=3","gravatar_id":"","url":"https://api.github.com/users/edeutschie","html_url":"https://github.com/edeutschie","followers_url":"https://api.github.com/users/edeutschie/followers","following_url":"https://api.github.com/users/edeutschie/following{/other_user}","gists_url":"https://api.github.com/users/edeutschie/gists{/gist_id}","starred_url":"https://api.github.com/users/edeutschie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edeutschie/subscriptions","organizations_url":"https://api.github.com/users/edeutschie/orgs","repos_url":"https://api.github.com/users/edeutschie/repos","events_url":"https://api.github.com/users/edeutschie/events{/privacy}","received_events_url":"https://api.github.com/users/edeutschie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/edeutschie/ride-share-two","description":null,"fork":true,"url":"https://api.github.com/repos/edeutschie/ride-share-two","forks_url":"https://api.github.com/repos/edeutschie/ride-share-two/forks","keys_url":"https://api.github.com/repos/edeutschie/ride-share-two/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edeutschie/ride-share-two/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edeutschie/ride-share-two/teams","hooks_url":"https://api.github.com/repos/edeutschie/ride-share-two/hooks","issue_events_url":"https://api.github.com/repos/edeutschie/ride-share-two/issues/events{/number}","events_url":"https://api.github.com/repos/edeutschie/ride-share-two/events","assignees_url":"https://api.github.com/repos/edeutschie/ride-share-two/assignees{/user}","branches_url":"https://api.github.com/repos/edeutschie/ride-share-two/branches{/branch}","tags_url":"https://api.github.com/repos/edeutschie/ride-share-two/tags","blobs_url":"https://api.github.com/repos/edeutschie/ride-share-two/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edeutschie/ride-share-two/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edeutschie/ride-share-two/git/refs{/sha}","trees_url":"https://api.github.com/repos/edeutschie/ride-share-two/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edeutschie/ride-share-two/statuses/{sha}","languages_url":"https://api.github.com/repos/edeutschie/ride-share-two/languages","stargazers_url":"https://api.github.com/repos/edeutschie/ride-share-two/stargazers","contributors_url":"https://api.github.com/repos/edeutschie/ride-share-two/contributors","subscribers_url":"https://api.github.com/repos/edeutschie/ride-share-two/subscribers","subscription_url":"https://api.github.com/repos/edeutschie/ride-share-two/subscription","commits_url":"https://api.github.com/repos/edeutschie/ride-share-two/commits{/sha}","git_commits_url":"https://api.github.com/repos/edeutschie/ride-share-two/git/commits{/sha}","comments_url":"https://api.github.com/repos/edeutschie/ride-share-two/comments{/number}","issue_comment_url":"https://api.github.com/repos/edeutschie/ride-share-two/issues/comments{/number}","contents_url":"https://api.github.com/repos/edeutschie/ride-share-two/contents/{+path}","compare_url":"https://api.github.com/repos/edeutschie/ride-share-two/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edeutschie/ride-share-two/merges","archive_url":"https://api.github.com/repos/edeutschie/ride-share-two/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edeutschie/ride-share-two/downloads","issues_url":"https://api.github.com/repos/edeutschie/ride-share-two/issues{/number}","pulls_url":"https://api.github.com/repos/edeutschie/ride-share-two/pulls{/number}","milestones_url":"https://api.github.com/repos/edeutschie/ride-share-two/milestones{/number}","notifications_url":"https://api.github.com/repos/edeutschie/ride-share-two/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edeutschie/ride-share-two/labels{/name}","releases_url":"https://api.github.com/repos/edeutschie/ride-share-two/releases{/id}","deployments_url":"https://api.github.com/repos/edeutschie/ride-share-two/deployments","created_at":"2017-03-06T23:40:38Z","updated_at":"2017-03-06T23:40:40Z","pushed_at":"2017-03-13T02:40:18Z","git_url":"git://github.com/edeutschie/ride-share-two.git","ssh_url":"git@github.com:edeutschie/ride-share-two.git","clone_url":"https://github.com/edeutschie/ride-share-two.git","svn_url":"https://github.com/edeutschie/ride-share-two","homepage":null,"size":140,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Ada-C7:master","ref":"master","sha":"8a6c58beb2a61de7796c779d6192aa90485fddec","user":{"login":"Ada-C7","id":24881334,"avatar_url":"https://avatars3.githubusercontent.com/u/24881334?v=3","gravatar_id":"","url":"https://api.github.com/users/Ada-C7","html_url":"https://github.com/Ada-C7","followers_url":"https://api.github.com/users/Ada-C7/followers","following_url":"https://api.github.com/users/Ada-C7/following{/other_user}","gists_url":"https://api.github.com/users/Ada-C7/gists{/gist_id}","starred_url":"https://api.github.com/users/Ada-C7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ada-C7/subscriptions","organizations_url":"https://api.github.com/users/Ada-C7/orgs","repos_url":"https://api.github.com/users/Ada-C7/repos","events_url":"https://api.github.com/users/Ada-C7/events{/privacy}","received_events_url":"https://api.github.com/users/Ada-C7/received_events","type":"Organization","site_admin":false},"repo":{"id":84022572,"name":"ride-share-two","full_name":"Ada-C7/ride-share-two","owner":{"login":"Ada-C7","id":24881334,"avatar_url":"https://avatars3.githubusercontent.com/u/24881334?v=3","gravatar_id":"","url":"https://api.github.com/users/Ada-C7","html_url":"https://github.com/Ada-C7","followers_url":"https://api.github.com/users/Ada-C7/followers","following_url":"https://api.github.com/users/Ada-C7/following{/other_user}","gists_url":"https://api.github.com/users/Ada-C7/gists{/gist_id}","starred_url":"https://api.github.com/users/Ada-C7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ada-C7/subscriptions","organizations_url":"https://api.github.com/users/Ada-C7/orgs","repos_url":"https://api.github.com/users/Ada-C7/repos","events_url":"https://api.github.com/users/Ada-C7/events{/privacy}","received_events_url":"https://api.github.com/users/Ada-C7/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Ada-C7/ride-share-two","description":null,"fork":true,"url":"https://api.github.com/repos/Ada-C7/ride-share-two","forks_url":"https://api.github.com/repos/Ada-C7/ride-share-two/forks","keys_url":"https://api.github.com/repos/Ada-C7/ride-share-two/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ada-C7/ride-share-two/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ada-C7/ride-share-two/teams","hooks_url":"https://api.github.com/repos/Ada-C7/ride-share-two/hooks","issue_events_url":"https://api.github.com/repos/Ada-C7/ride-share-two/issues/events{/number}","events_url":"https://api.github.com/repos/Ada-C7/ride-share-two/events","assignees_url":"https://api.github.com/repos/Ada-C7/ride-share-two/assignees{/user}","branches_url":"https://api.github.com/repos/Ada-C7/ride-share-two/branches{/branch}","tags_url":"https://api.github.com/repos/Ada-C7/ride-share-two/tags","blobs_url":"https://api.github.com/repos/Ada-C7/ride-share-two/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ada-C7/ride-share-two/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ada-C7/ride-share-two/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ada-C7/ride-share-two/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ada-C7/ride-share-two/statuses/{sha}","languages_url":"https://api.github.com/repos/Ada-C7/ride-share-two/languages","stargazers_url":"https://api.github.com/repos/Ada-C7/ride-share-two/stargazers","contributors_url":"https://api.github.com/repos/Ada-C7/ride-share-two/contributors","subscribers_url":"https://api.github.com/repos/Ada-C7/ride-share-two/subscribers","subscription_url":"https://api.github.com/repos/Ada-C7/ride-share-two/subscription","commits_url":"https://api.github.com/repos/Ada-C7/ride-share-two/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ada-C7/ride-share-two/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ada-C7/ride-share-two/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ada-C7/ride-share-two/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ada-C7/ride-share-two/contents/{+path}","compare_url":"https://api.github.com/repos/Ada-C7/ride-share-two/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ada-C7/ride-share-two/merges","archive_url":"https://api.github.com/repos/Ada-C7/ride-share-two/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ada-C7/ride-share-two/downloads","issues_url":"https://api.github.com/repos/Ada-C7/ride-share-two/issues{/number}","pulls_url":"https://api.github.com/repos/Ada-C7/ride-share-two/pulls{/number}","milestones_url":"https://api.github.com/repos/Ada-C7/ride-share-two/milestones{/number}","notifications_url":"https://api.github.com/repos/Ada-C7/ride-share-two/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ada-C7/ride-share-two/labels{/name}","releases_url":"https://api.github.com/repos/Ada-C7/ride-share-two/releases{/id}","deployments_url":"https://api.github.com/repos/Ada-C7/ride-share-two/deployments","created_at":"2017-03-06T02:47:33Z","updated_at":"2017-03-06T02:47:34Z","pushed_at":"2017-03-13T03:00:59Z","git_url":"git://github.com/Ada-C7/ride-share-two.git","ssh_url":"git@github.com:Ada-C7/ride-share-two.git","clone_url":"https://github.com/Ada-C7/ride-share-two.git","svn_url":"https://github.com/Ada-C7/ride-share-two","homepage":null,"size":33,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":48,"mirror_url":null,"open_issues_count":30,"forks":48,"open_issues":30,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Ada-C7/ride-share-two/pulls/31"},"html":{"href":"https://github.com/Ada-C7/ride-share-two/pull/31"},"issue":{"href":"https://api.github.com/repos/Ada-C7/ride-share-two/issues/31"},"comments":{"href":"https://api.github.com/repos/Ada-C7/ride-share-two/issues/31/comments"},"review_comments":{"href":"https://api.github.com/repos/Ada-C7/ride-share-two/pulls/31/comments"},"review_comment":{"href":"https://api.github.com/repos/Ada-C7/ride-share-two/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Ada-C7/ride-share-two/pulls/31/commits"},"statuses":{"href":"https://api.github.com/repos/Ada-C7/ride-share-two/statuses/f01eb47b444711ed23432f5e0d82548e657307f6"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":18,"additions":513,"deletions":0,"changed_files":9}}
{"actor":{"display_login":"edeutschie"}}