{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments/134899736","pull_request_review_id":58247605,"id":134899736,"diff_hunk":"@@ -21,7 +21,7 @@ EnvironmentFile=/etc/sysconfig/{{ openshift.common.service_type }}-node-dep\n ExecStartPre=-/usr/bin/docker rm -f {{ openshift.common.service_type }}-node\n ExecStartPre=/usr/bin/cp /etc/origin/node/node-dnsmasq.conf /etc/dnsmasq.d/\n ExecStartPre=/usr/bin/dbus-send --system --dest=uk.org.thekelleys.dnsmasq /uk/org/thekelleys/dnsmasq uk.org.thekelleys.SetDomainServers array:string:/in-addr.arpa/127.0.0.1,/{{ openshift.common.dns_domain }}/127.0.0.1\n-ExecStart=/usr/bin/docker run --name {{ openshift.common.service_type }}-node --rm --privileged --net=host --pid=host --env-file=/etc/sysconfig/{{ openshift.common.service_type }}-node -v /:/rootfs:ro,rslave -e CONFIG_FILE=${CONFIG_FILE} -e OPTIONS=${OPTIONS} -e HOST=/rootfs -e HOST_ETC=/host-etc -v {{ openshift.common.data_dir }}:{{ openshift.common.data_dir }}{{ ':rslave' if openshift.docker.gte_1_10 | default(False) | bool else '' }} -v {{ openshift.common.config_base }}/node:{{ openshift.common.config_base }}/node {% if openshift_cloudprovider_kind | default('') != '' -%} -v {{ openshift.common.config_base }}/cloudprovider:{{ openshift.common.config_base}}/cloudprovider {% endif -%} -v /etc/localtime:/etc/localtime:ro -v /etc/machine-id:/etc/machine-id:ro -v /run:/run -v /sys:/sys:rw -v /sys/fs/cgroup:/sys/fs/cgroup:rw -v /usr/bin/docker:/usr/bin/docker:ro -v /var/lib/docker:/var/lib/docker -v /lib/modules:/lib/modules -v /etc/origin/openvswitch:/etc/openvswitch -v /etc/origin/sdn:/etc/openshift-sdn -v /var/lib/cni:/var/lib/cni -v /etc/systemd/system:/host-etc/systemd/system -v /var/log:/var/log -v /dev:/dev $DOCKER_ADDTL_BIND_MOUNTS -v /etc/pki:/etc/pki:ro {{ openshift.node.node_image }}:${IMAGE_VERSION}","path":"roles/openshift_node/templates/openshift.docker.node.service","position":17,"original_position":17,"commit_id":"15c74e51e5ed88d924243577f62abe36a8cdd85d","original_commit_id":"15c74e51e5ed88d924243577f62abe36a8cdd85d","user":{"login":"sdodson","id":48161,"avatar_url":"https://avatars2.githubusercontent.com/u/48161?v=4","gravatar_id":"","url":"https://api.github.com/users/sdodson","html_url":"https://github.com/sdodson","followers_url":"https://api.github.com/users/sdodson/followers","following_url":"https://api.github.com/users/sdodson/following{/other_user}","gists_url":"https://api.github.com/users/sdodson/gists{/gist_id}","starred_url":"https://api.github.com/users/sdodson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdodson/subscriptions","organizations_url":"https://api.github.com/users/sdodson/orgs","repos_url":"https://api.github.com/users/sdodson/repos","events_url":"https://api.github.com/users/sdodson/events{/privacy}","received_events_url":"https://api.github.com/users/sdodson/received_events","type":"User","site_admin":false},"body":"Yeah safe to remove, we'd never use this codebase on anything older than 3.6 which requires 1.12.","created_at":"2017-08-23T23:58:41Z","updated_at":"2017-08-23T23:58:41Z","html_url":"https://github.com/openshift/openshift-ansible/pull/5165#discussion_r134899736","pull_request_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/5165","_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments/134899736"},"html":{"href":"https://github.com/openshift/openshift-ansible/pull/5165#discussion_r134899736"},"pull_request":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/5165"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/5165","id":137034647,"html_url":"https://github.com/openshift/openshift-ansible/pull/5165","diff_url":"https://github.com/openshift/openshift-ansible/pull/5165.diff","patch_url":"https://github.com/openshift/openshift-ansible/pull/5165.patch","issue_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/5165","number":5165,"state":"open","locked":false,"title":"[WIP] Flatten docker into one role","user":{"login":"michaelgugino","id":6255238,"avatar_url":"https://avatars0.githubusercontent.com/u/6255238?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelgugino","html_url":"https://github.com/michaelgugino","followers_url":"https://api.github.com/users/michaelgugino/followers","following_url":"https://api.github.com/users/michaelgugino/following{/other_user}","gists_url":"https://api.github.com/users/michaelgugino/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelgugino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelgugino/subscriptions","organizations_url":"https://api.github.com/users/michaelgugino/orgs","repos_url":"https://api.github.com/users/michaelgugino/repos","events_url":"https://api.github.com/users/michaelgugino/events{/privacy}","received_events_url":"https://api.github.com/users/michaelgugino/received_events","type":"User","site_admin":false},"body":"This commit is intended to flatten the various docker roles\r\ninto a single docker role and remove all meta-depends of the\r\nvarious docker roles in all other roles.","created_at":"2017-08-22T17:17:34Z","updated_at":"2017-08-23T23:58:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"17f45c11eed727d7093c9470970b4bbe601452a3","assignee":null,"assignees":[],"requested_reviewers":[{"login":"sdodson","id":48161,"avatar_url":"https://avatars2.githubusercontent.com/u/48161?v=4","gravatar_id":"","url":"https://api.github.com/users/sdodson","html_url":"https://github.com/sdodson","followers_url":"https://api.github.com/users/sdodson/followers","following_url":"https://api.github.com/users/sdodson/following{/other_user}","gists_url":"https://api.github.com/users/sdodson/gists{/gist_id}","starred_url":"https://api.github.com/users/sdodson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdodson/subscriptions","organizations_url":"https://api.github.com/users/sdodson/orgs","repos_url":"https://api.github.com/users/sdodson/repos","events_url":"https://api.github.com/users/sdodson/events{/privacy}","received_events_url":"https://api.github.com/users/sdodson/received_events","type":"User","site_admin":false},{"login":"kwoodson","id":1385770,"avatar_url":"https://avatars2.githubusercontent.com/u/1385770?v=4","gravatar_id":"","url":"https://api.github.com/users/kwoodson","html_url":"https://github.com/kwoodson","followers_url":"https://api.github.com/users/kwoodson/followers","following_url":"https://api.github.com/users/kwoodson/following{/other_user}","gists_url":"https://api.github.com/users/kwoodson/gists{/gist_id}","starred_url":"https://api.github.com/users/kwoodson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwoodson/subscriptions","organizations_url":"https://api.github.com/users/kwoodson/orgs","repos_url":"https://api.github.com/users/kwoodson/repos","events_url":"https://api.github.com/users/kwoodson/events{/privacy}","received_events_url":"https://api.github.com/users/kwoodson/received_events","type":"User","site_admin":false},{"login":"mtnbikenc","id":7808636,"avatar_url":"https://avatars1.githubusercontent.com/u/7808636?v=4","gravatar_id":"","url":"https://api.github.com/users/mtnbikenc","html_url":"https://github.com/mtnbikenc","followers_url":"https://api.github.com/users/mtnbikenc/followers","following_url":"https://api.github.com/users/mtnbikenc/following{/other_user}","gists_url":"https://api.github.com/users/mtnbikenc/gists{/gist_id}","starred_url":"https://api.github.com/users/mtnbikenc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtnbikenc/subscriptions","organizations_url":"https://api.github.com/users/mtnbikenc/orgs","repos_url":"https://api.github.com/users/mtnbikenc/repos","events_url":"https://api.github.com/users/mtnbikenc/events{/privacy}","received_events_url":"https://api.github.com/users/mtnbikenc/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/5165/commits","review_comments_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/5165/comments","review_comment_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/5165/comments","statuses_url":"https://api.github.com/repos/openshift/openshift-ansible/statuses/15c74e51e5ed88d924243577f62abe36a8cdd85d","head":{"label":"mgugino-upstream-stage:flatten-docker","ref":"flatten-docker","sha":"15c74e51e5ed88d924243577f62abe36a8cdd85d","user":{"login":"mgugino-upstream-stage","id":21089646,"avatar_url":"https://avatars0.githubusercontent.com/u/21089646?v=4","gravatar_id":"","url":"https://api.github.com/users/mgugino-upstream-stage","html_url":"https://github.com/mgugino-upstream-stage","followers_url":"https://api.github.com/users/mgugino-upstream-stage/followers","following_url":"https://api.github.com/users/mgugino-upstream-stage/following{/other_user}","gists_url":"https://api.github.com/users/mgugino-upstream-stage/gists{/gist_id}","starred_url":"https://api.github.com/users/mgugino-upstream-stage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgugino-upstream-stage/subscriptions","organizations_url":"https://api.github.com/users/mgugino-upstream-stage/orgs","repos_url":"https://api.github.com/users/mgugino-upstream-stage/repos","events_url":"https://api.github.com/users/mgugino-upstream-stage/events{/privacy}","received_events_url":"https://api.github.com/users/mgugino-upstream-stage/received_events","type":"Organization","site_admin":false},"repo":{"id":100063291,"name":"openshift-ansible","full_name":"mgugino-upstream-stage/openshift-ansible","owner":{"login":"mgugino-upstream-stage","id":21089646,"avatar_url":"https://avatars0.githubusercontent.com/u/21089646?v=4","gravatar_id":"","url":"https://api.github.com/users/mgugino-upstream-stage","html_url":"https://github.com/mgugino-upstream-stage","followers_url":"https://api.github.com/users/mgugino-upstream-stage/followers","following_url":"https://api.github.com/users/mgugino-upstream-stage/following{/other_user}","gists_url":"https://api.github.com/users/mgugino-upstream-stage/gists{/gist_id}","starred_url":"https://api.github.com/users/mgugino-upstream-stage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgugino-upstream-stage/subscriptions","organizations_url":"https://api.github.com/users/mgugino-upstream-stage/orgs","repos_url":"https://api.github.com/users/mgugino-upstream-stage/repos","events_url":"https://api.github.com/users/mgugino-upstream-stage/events{/privacy}","received_events_url":"https://api.github.com/users/mgugino-upstream-stage/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mgugino-upstream-stage/openshift-ansible","description":"OpenShift Installation and Configuration Management","fork":true,"url":"https://api.github.com/repos/mgugino-upstream-stage/openshift-ansible","forks_url":"https://api.github.com/repos/mgugino-upstream-stage/openshift-ansible/forks","keys_url":"https://api.github.com/repos/mgugino-upstream-stage/openshift-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mgugino-upstream-stage/openshift-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mgugino-upstream-stage/openshift-ansible/teams","hooks_url":"https://api.github.com/repos/mgugino-upstream-stage/openshift-ansible/hooks","issue_events_url":"https://api.github.com/repos/mgugino-upstream-stage/openshift-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/mgugino-upstream-stage/openshift-ansible/events","assignees_url":"https://api.github.com/repos/mgugino-upstream-stage/openshift-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/mgugino-upstream-stage/openshift-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/mgugino-upstream-stage/openshift-ansible/tags","blobs_url":"https://api.github.com/repos/mgugino-upstream-stage/openshift-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mgugino-upstream-stage/openshift-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mgugino-upstream-stage/openshift-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/mgugino-upstream-stage/openshift-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mgugino-upstream-stage/openshift-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/mgugino-upstream-stage/openshift-ansible/languages","stargazers_url":"https://api.github.com/repos/mgugino-upstream-stage/openshift-ansible/stargazers","contributors_url":"https://api.github.com/repos/mgugino-upstream-stage/openshift-ansible/contributors","subscribers_url":"https://api.github.com/repos/mgugino-upstream-stage/openshift-ansible/subscribers","subscription_url":"https://api.github.com/repos/mgugino-upstream-stage/openshift-ansible/subscription","commits_url":"https://api.github.com/repos/mgugino-upstream-stage/openshift-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/mgugino-upstream-stage/openshift-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/mgugino-upstream-stage/openshift-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/mgugino-upstream-stage/openshift-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/mgugino-upstream-stage/openshift-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/mgugino-upstream-stage/openshift-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mgugino-upstream-stage/openshift-ansible/merges","archive_url":"https://api.github.com/repos/mgugino-upstream-stage/openshift-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mgugino-upstream-stage/openshift-ansible/downloads","issues_url":"https://api.github.com/repos/mgugino-upstream-stage/openshift-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/mgugino-upstream-stage/openshift-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/mgugino-upstream-stage/openshift-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/mgugino-upstream-stage/openshift-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mgugino-upstream-stage/openshift-ansible/labels{/name}","releases_url":"https://api.github.com/repos/mgugino-upstream-stage/openshift-ansible/releases{/id}","deployments_url":"https://api.github.com/repos/mgugino-upstream-stage/openshift-ansible/deployments","created_at":"2017-08-11T19:14:53Z","updated_at":"2017-08-11T19:15:05Z","pushed_at":"2017-08-23T20:24:09Z","git_url":"git://github.com/mgugino-upstream-stage/openshift-ansible.git","ssh_url":"git@github.com:mgugino-upstream-stage/openshift-ansible.git","clone_url":"https://github.com/mgugino-upstream-stage/openshift-ansible.git","svn_url":"https://github.com/mgugino-upstream-stage/openshift-ansible","homepage":"https://install.openshift.com","size":16674,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"b107f677a3563f6db9a1ef17fe10518d321d495c","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":24109199,"name":"openshift-ansible","full_name":"openshift/openshift-ansible","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/openshift-ansible","description":"OpenShift Installation and Configuration Management","fork":false,"url":"https://api.github.com/repos/openshift/openshift-ansible","forks_url":"https://api.github.com/repos/openshift/openshift-ansible/forks","keys_url":"https://api.github.com/repos/openshift/openshift-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/openshift-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/openshift-ansible/teams","hooks_url":"https://api.github.com/repos/openshift/openshift-ansible/hooks","issue_events_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/openshift-ansible/events","assignees_url":"https://api.github.com/repos/openshift/openshift-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/openshift-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/openshift-ansible/tags","blobs_url":"https://api.github.com/repos/openshift/openshift-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/openshift-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/openshift-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/openshift-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/openshift-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/openshift-ansible/languages","stargazers_url":"https://api.github.com/repos/openshift/openshift-ansible/stargazers","contributors_url":"https://api.github.com/repos/openshift/openshift-ansible/contributors","subscribers_url":"https://api.github.com/repos/openshift/openshift-ansible/subscribers","subscription_url":"https://api.github.com/repos/openshift/openshift-ansible/subscription","commits_url":"https://api.github.com/repos/openshift/openshift-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/openshift-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/openshift-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/openshift-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/openshift-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/openshift-ansible/merges","archive_url":"https://api.github.com/repos/openshift/openshift-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/openshift-ansible/downloads","issues_url":"https://api.github.com/repos/openshift/openshift-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/openshift-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/openshift-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/openshift-ansible/labels{/name}","releases_url":"https://api.github.com/repos/openshift/openshift-ansible/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/openshift-ansible/deployments","created_at":"2014-09-16T17:07:51Z","updated_at":"2017-08-23T12:49:13Z","pushed_at":"2017-08-23T23:51:20Z","git_url":"git://github.com/openshift/openshift-ansible.git","ssh_url":"git@github.com:openshift/openshift-ansible.git","clone_url":"https://github.com/openshift/openshift-ansible.git","svn_url":"https://github.com/openshift/openshift-ansible","homepage":"https://install.openshift.com","size":16664,"stargazers_count":530,"watchers_count":530,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":829,"mirror_url":null,"open_issues_count":587,"forks":829,"open_issues":587,"watchers":530,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/5165"},"html":{"href":"https://github.com/openshift/openshift-ansible/pull/5165"},"issue":{"href":"https://api.github.com/repos/openshift/openshift-ansible/issues/5165"},"comments":{"href":"https://api.github.com/repos/openshift/openshift-ansible/issues/5165/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/5165/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/5165/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/openshift-ansible/statuses/15c74e51e5ed88d924243577f62abe36a8cdd85d"}}}}
{"actor":{"display_login":"sdodson"}}