{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/118640680","pull_request_review_id":40452492,"id":118640680,"diff_hunk":"@@ -241,17 +253,60 @@ func newServiceChangeMap() serviceChangeMap {\n \t}\n }\n \n-func (scm *serviceChangeMap) update(namespacedName *types.NamespacedName, previous, current *api.Service) {\n+func (scm *serviceChangeMap) update(namespacedName *types.NamespacedName, previous, current *api.Service) bool {\n \tscm.Lock()\n \tdefer scm.Unlock()\n \n \tchange, exists := scm.items[*namespacedName]\n \tif !exists {\n \t\tchange = &serviceChange{}\n-\t\tchange.previous = previous\n+\t\tchange.previous = serviceToServiceMap(previous)\n \t\tscm.items[*namespacedName] = change\n \t}\n-\tchange.current = current\n+\tchange.current = serviceToServiceMap(current)\n+\tif reflect.DeepEqual(change.previous, change.current) {","path":"pkg/proxy/iptables/proxier.go","position":83,"original_position":83,"commit_id":"c0c41aa083ed490527b94f3cf142f25bb16285d6","original_commit_id":"c0c41aa083ed490527b94f3cf142f25bb16285d6","user":{"login":"wojtek-t","id":10743879,"avatar_url":"https://avatars0.githubusercontent.com/u/10743879?v=3","gravatar_id":"","url":"https://api.github.com/users/wojtek-t","html_url":"https://github.com/wojtek-t","followers_url":"https://api.github.com/users/wojtek-t/followers","following_url":"https://api.github.com/users/wojtek-t/following{/other_user}","gists_url":"https://api.github.com/users/wojtek-t/gists{/gist_id}","starred_url":"https://api.github.com/users/wojtek-t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wojtek-t/subscriptions","organizations_url":"https://api.github.com/users/wojtek-t/orgs","repos_url":"https://api.github.com/users/wojtek-t/repos","events_url":"https://api.github.com/users/wojtek-t/events{/privacy}","received_events_url":"https://api.github.com/users/wojtek-t/received_events","type":"User","site_admin":false},"body":"This is happening once per endpoint/service watch event.\r\nGiven what is happening in syncProxyRules function in terms of both allocations and cpu usage (it's better after recent changes, but it's still a lot), I'm not that surprised.\r\nFYI - 2 weeks ago we used to allocated ~38GB of memory during load test on 100-node clusters - this was significantly more than apiserver was allocating.","created_at":"2017-05-26T06:21:52Z","updated_at":"2017-05-26T06:21:52Z","html_url":"https://github.com/kubernetes/kubernetes/pull/45816#discussion_r118640680","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/45816","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/118640680"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/45816#discussion_r118640680"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/45816"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/45816","id":120569473,"html_url":"https://github.com/kubernetes/kubernetes/pull/45816","diff_url":"https://github.com/kubernetes/kubernetes/pull/45816.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/45816.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/45816","number":45816,"state":"closed","locked":false,"title":"Change kube-proxy so that we won't perform no-op calls","user":{"login":"wojtek-t","id":10743879,"avatar_url":"https://avatars0.githubusercontent.com/u/10743879?v=3","gravatar_id":"","url":"https://api.github.com/users/wojtek-t","html_url":"https://github.com/wojtek-t","followers_url":"https://api.github.com/users/wojtek-t/followers","following_url":"https://api.github.com/users/wojtek-t/following{/other_user}","gists_url":"https://api.github.com/users/wojtek-t/gists{/gist_id}","starred_url":"https://api.github.com/users/wojtek-t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wojtek-t/subscriptions","organizations_url":"https://api.github.com/users/wojtek-t/orgs","repos_url":"https://api.github.com/users/wojtek-t/repos","events_url":"https://api.github.com/users/wojtek-t/events{/privacy}","received_events_url":"https://api.github.com/users/wojtek-t/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-05-15T10:26:09Z","updated_at":"2017-05-26T06:21:52Z","closed_at":"2017-05-20T16:06:59Z","merged_at":"2017-05-20T16:06:59Z","merge_commit_sha":"8b706690fb90c7e0aade244017e8daa9445cb374","assignee":{"login":"thockin","id":5595220,"avatar_url":"https://avatars3.githubusercontent.com/u/5595220?v=3","gravatar_id":"","url":"https://api.github.com/users/thockin","html_url":"https://github.com/thockin","followers_url":"https://api.github.com/users/thockin/followers","following_url":"https://api.github.com/users/thockin/following{/other_user}","gists_url":"https://api.github.com/users/thockin/gists{/gist_id}","starred_url":"https://api.github.com/users/thockin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thockin/subscriptions","organizations_url":"https://api.github.com/users/thockin/orgs","repos_url":"https://api.github.com/users/thockin/repos","events_url":"https://api.github.com/users/thockin/events{/privacy}","received_events_url":"https://api.github.com/users/thockin/received_events","type":"User","site_admin":false},"assignees":[{"login":"thockin","id":5595220,"avatar_url":"https://avatars3.githubusercontent.com/u/5595220?v=3","gravatar_id":"","url":"https://api.github.com/users/thockin","html_url":"https://github.com/thockin","followers_url":"https://api.github.com/users/thockin/followers","following_url":"https://api.github.com/users/thockin/following{/other_user}","gists_url":"https://api.github.com/users/thockin/gists{/gist_id}","starred_url":"https://api.github.com/users/thockin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thockin/subscriptions","organizations_url":"https://api.github.com/users/thockin/orgs","repos_url":"https://api.github.com/users/thockin/repos","events_url":"https://api.github.com/users/thockin/events{/privacy}","received_events_url":"https://api.github.com/users/thockin/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/45816/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/45816/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/45816/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/c0c41aa083ed490527b94f3cf142f25bb16285d6","head":{"label":"wojtek-t:no_early_return_sync_proxy_rules","ref":"no_early_return_sync_proxy_rules","sha":"c0c41aa083ed490527b94f3cf142f25bb16285d6","user":{"login":"wojtek-t","id":10743879,"avatar_url":"https://avatars0.githubusercontent.com/u/10743879?v=3","gravatar_id":"","url":"https://api.github.com/users/wojtek-t","html_url":"https://github.com/wojtek-t","followers_url":"https://api.github.com/users/wojtek-t/followers","following_url":"https://api.github.com/users/wojtek-t/following{/other_user}","gists_url":"https://api.github.com/users/wojtek-t/gists{/gist_id}","starred_url":"https://api.github.com/users/wojtek-t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wojtek-t/subscriptions","organizations_url":"https://api.github.com/users/wojtek-t/orgs","repos_url":"https://api.github.com/users/wojtek-t/repos","events_url":"https://api.github.com/users/wojtek-t/events{/privacy}","received_events_url":"https://api.github.com/users/wojtek-t/received_events","type":"User","site_admin":false},"repo":{"id":30216785,"name":"kubernetes","full_name":"wojtek-t/kubernetes","owner":{"login":"wojtek-t","id":10743879,"avatar_url":"https://avatars0.githubusercontent.com/u/10743879?v=3","gravatar_id":"","url":"https://api.github.com/users/wojtek-t","html_url":"https://github.com/wojtek-t","followers_url":"https://api.github.com/users/wojtek-t/followers","following_url":"https://api.github.com/users/wojtek-t/following{/other_user}","gists_url":"https://api.github.com/users/wojtek-t/gists{/gist_id}","starred_url":"https://api.github.com/users/wojtek-t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wojtek-t/subscriptions","organizations_url":"https://api.github.com/users/wojtek-t/orgs","repos_url":"https://api.github.com/users/wojtek-t/repos","events_url":"https://api.github.com/users/wojtek-t/events{/privacy}","received_events_url":"https://api.github.com/users/wojtek-t/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wojtek-t/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/wojtek-t/kubernetes","forks_url":"https://api.github.com/repos/wojtek-t/kubernetes/forks","keys_url":"https://api.github.com/repos/wojtek-t/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wojtek-t/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wojtek-t/kubernetes/teams","hooks_url":"https://api.github.com/repos/wojtek-t/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/wojtek-t/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/wojtek-t/kubernetes/events","assignees_url":"https://api.github.com/repos/wojtek-t/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/wojtek-t/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/wojtek-t/kubernetes/tags","blobs_url":"https://api.github.com/repos/wojtek-t/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wojtek-t/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wojtek-t/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/wojtek-t/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wojtek-t/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/wojtek-t/kubernetes/languages","stargazers_url":"https://api.github.com/repos/wojtek-t/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/wojtek-t/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/wojtek-t/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/wojtek-t/kubernetes/subscription","commits_url":"https://api.github.com/repos/wojtek-t/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/wojtek-t/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/wojtek-t/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/wojtek-t/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/wojtek-t/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/wojtek-t/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wojtek-t/kubernetes/merges","archive_url":"https://api.github.com/repos/wojtek-t/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wojtek-t/kubernetes/downloads","issues_url":"https://api.github.com/repos/wojtek-t/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/wojtek-t/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/wojtek-t/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/wojtek-t/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wojtek-t/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/wojtek-t/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/wojtek-t/kubernetes/deployments","created_at":"2015-02-03T00:37:55Z","updated_at":"2015-04-30T12:14:58Z","pushed_at":"2017-05-25T18:05:42Z","git_url":"git://github.com/wojtek-t/kubernetes.git","ssh_url":"git@github.com:wojtek-t/kubernetes.git","clone_url":"https://github.com/wojtek-t/kubernetes.git","svn_url":"https://github.com/wojtek-t/kubernetes","homepage":"http://kubernetes.io","size":420361,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"2c2b5f7379a3d349eee892e8925e9b3c814c3503","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars1.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars1.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2017-05-26T06:05:59Z","pushed_at":"2017-05-26T06:15:17Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":651957,"stargazers_count":23504,"watchers_count":23504,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8290,"mirror_url":null,"open_issues_count":5571,"forks":8290,"open_issues":5571,"watchers":23504,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/45816"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/45816"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/45816"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/45816/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/45816/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/45816/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/c0c41aa083ed490527b94f3cf142f25bb16285d6"}}}}
{"actor":{"display_login":"wojtek-t"}}