{"action":"created","issue":{"url":"https://api.github.com/repos/bitcoin-core/secp256k1/issues/463","repository_url":"https://api.github.com/repos/bitcoin-core/secp256k1","labels_url":"https://api.github.com/repos/bitcoin-core/secp256k1/issues/463/labels{/name}","comments_url":"https://api.github.com/repos/bitcoin-core/secp256k1/issues/463/comments","events_url":"https://api.github.com/repos/bitcoin-core/secp256k1/issues/463/events","html_url":"https://github.com/bitcoin-core/secp256k1/pull/463","id":238059118,"number":463,"title":"Reduce usage of hardcoded size constants","user":{"login":"tjps","id":7519582,"avatar_url":"https://avatars2.githubusercontent.com/u/7519582?v=4","gravatar_id":"","url":"https://api.github.com/users/tjps","html_url":"https://github.com/tjps","followers_url":"https://api.github.com/users/tjps/followers","following_url":"https://api.github.com/users/tjps/following{/other_user}","gists_url":"https://api.github.com/users/tjps/gists{/gist_id}","starred_url":"https://api.github.com/users/tjps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tjps/subscriptions","organizations_url":"https://api.github.com/users/tjps/orgs","repos_url":"https://api.github.com/users/tjps/repos","events_url":"https://api.github.com/users/tjps/events{/privacy}","received_events_url":"https://api.github.com/users/tjps/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2017-06-23T07:10:16Z","updated_at":"2017-11-09T01:18:07Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/bitcoin-core/secp256k1/pulls/463","html_url":"https://github.com/bitcoin-core/secp256k1/pull/463","diff_url":"https://github.com/bitcoin-core/secp256k1/pull/463.diff","patch_url":"https://github.com/bitcoin-core/secp256k1/pull/463.patch"},"body":"In particular the usage of keylen in nonce_function_rfc6979 seemed precarious - in one conditional it was unconditionally set, then in the next it was added to.  While it was clearly correct as written, I think this change makes it easier to reason about for new eyes and more resistant to breakage if there is any future change to what gets fed into the PRNG."},"comment":{"url":"https://api.github.com/repos/bitcoin-core/secp256k1/issues/comments/343016085","html_url":"https://github.com/bitcoin-core/secp256k1/pull/463#issuecomment-343016085","issue_url":"https://api.github.com/repos/bitcoin-core/secp256k1/issues/463","id":343016085,"user":{"login":"apoelstra","id":1351933,"avatar_url":"https://avatars0.githubusercontent.com/u/1351933?v=4","gravatar_id":"","url":"https://api.github.com/users/apoelstra","html_url":"https://github.com/apoelstra","followers_url":"https://api.github.com/users/apoelstra/followers","following_url":"https://api.github.com/users/apoelstra/following{/other_user}","gists_url":"https://api.github.com/users/apoelstra/gists{/gist_id}","starred_url":"https://api.github.com/users/apoelstra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apoelstra/subscriptions","organizations_url":"https://api.github.com/users/apoelstra/orgs","repos_url":"https://api.github.com/users/apoelstra/repos","events_url":"https://api.github.com/users/apoelstra/events{/privacy}","received_events_url":"https://api.github.com/users/apoelstra/received_events","type":"User","site_admin":false},"created_at":"2017-11-09T01:18:07Z","updated_at":"2017-11-09T01:18:07Z","author_association":"MEMBER","body":"tACK `https://github.com/bitcoin-core/secp256k1/pull/463/commits/b7593cdb44dd0bdc98e4abe705833552efce6de3`"}}
{"actor":{"display_login":"apoelstra"}}