{"action":"closed","number":235,"pull_request":{"url":"https://api.github.com/repos/GibbonEdu/core/pulls/235","id":121448237,"html_url":"https://github.com/GibbonEdu/core/pull/235","diff_url":"https://github.com/GibbonEdu/core/pull/235.diff","patch_url":"https://github.com/GibbonEdu/core/pull/235.patch","issue_url":"https://api.github.com/repos/GibbonEdu/core/issues/235","number":235,"state":"closed","locked":false,"title":"Additional permissions for Student Profiles and Timetables","user":{"login":"SKuipers","id":897700,"avatar_url":"https://avatars0.githubusercontent.com/u/897700?v=3","gravatar_id":"","url":"https://api.github.com/users/SKuipers","html_url":"https://github.com/SKuipers","followers_url":"https://api.github.com/users/SKuipers/followers","following_url":"https://api.github.com/users/SKuipers/following{/other_user}","gists_url":"https://api.github.com/users/SKuipers/gists{/gist_id}","starred_url":"https://api.github.com/users/SKuipers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SKuipers/subscriptions","organizations_url":"https://api.github.com/users/SKuipers/orgs","repos_url":"https://api.github.com/users/SKuipers/repos","events_url":"https://api.github.com/users/SKuipers/events{/privacy}","received_events_url":"https://api.github.com/users/SKuipers/received_events","type":"User","site_admin":false},"body":"Dusted this one off and cleaned up the code a bit (wrote it a while back for our school), but it's up to you if it's something you'd like to add for v14.\r\n\r\nThe current timetable and profile permissions, when enabled for Students and Parents, allow them to see the timetables and basic profiles of other students in the school. If disabled it prevents them from seeing timetables relevant to them (their own/children's). The three added permissions allow a school to set Students and Parents able to only see their relevant timetables and profiles.\r\n\r\nI've tested it and we've been using it on our system, but still worth testing out a bit locally before pushing to production. I'm also not fond of all the duplicate SQL queries and logic, but those should get tidied up as we move towards gateway classes 😁 \r\n\r\nBest viewed with `?w=1`","created_at":"2017-05-19T08:21:48Z","updated_at":"2017-05-19T12:57:27Z","closed_at":"2017-05-19T12:57:27Z","merged_at":"2017-05-19T12:57:27Z","merge_commit_sha":"1607211378a6e4cd205011d7122d669f020b3a93","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/GibbonEdu/core/pulls/235/commits","review_comments_url":"https://api.github.com/repos/GibbonEdu/core/pulls/235/comments","review_comment_url":"https://api.github.com/repos/GibbonEdu/core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GibbonEdu/core/issues/235/comments","statuses_url":"https://api.github.com/repos/GibbonEdu/core/statuses/6a4bb0a14a7ebb99be51d62db881f131611038fa","head":{"label":"SKuipers:feature/Profile_Permissions","ref":"feature/Profile_Permissions","sha":"6a4bb0a14a7ebb99be51d62db881f131611038fa","user":{"login":"SKuipers","id":897700,"avatar_url":"https://avatars0.githubusercontent.com/u/897700?v=3","gravatar_id":"","url":"https://api.github.com/users/SKuipers","html_url":"https://github.com/SKuipers","followers_url":"https://api.github.com/users/SKuipers/followers","following_url":"https://api.github.com/users/SKuipers/following{/other_user}","gists_url":"https://api.github.com/users/SKuipers/gists{/gist_id}","starred_url":"https://api.github.com/users/SKuipers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SKuipers/subscriptions","organizations_url":"https://api.github.com/users/SKuipers/orgs","repos_url":"https://api.github.com/users/SKuipers/repos","events_url":"https://api.github.com/users/SKuipers/events{/privacy}","received_events_url":"https://api.github.com/users/SKuipers/received_events","type":"User","site_admin":false},"repo":{"id":54351321,"name":"core","full_name":"SKuipers/core","owner":{"login":"SKuipers","id":897700,"avatar_url":"https://avatars0.githubusercontent.com/u/897700?v=3","gravatar_id":"","url":"https://api.github.com/users/SKuipers","html_url":"https://github.com/SKuipers","followers_url":"https://api.github.com/users/SKuipers/followers","following_url":"https://api.github.com/users/SKuipers/following{/other_user}","gists_url":"https://api.github.com/users/SKuipers/gists{/gist_id}","starred_url":"https://api.github.com/users/SKuipers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SKuipers/subscriptions","organizations_url":"https://api.github.com/users/SKuipers/orgs","repos_url":"https://api.github.com/users/SKuipers/repos","events_url":"https://api.github.com/users/SKuipers/events{/privacy}","received_events_url":"https://api.github.com/users/SKuipers/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SKuipers/core","description":"Gibbon is a flexible, open source school management platform designed to make like better for teachers, students, parents and leaders.","fork":true,"url":"https://api.github.com/repos/SKuipers/core","forks_url":"https://api.github.com/repos/SKuipers/core/forks","keys_url":"https://api.github.com/repos/SKuipers/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SKuipers/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SKuipers/core/teams","hooks_url":"https://api.github.com/repos/SKuipers/core/hooks","issue_events_url":"https://api.github.com/repos/SKuipers/core/issues/events{/number}","events_url":"https://api.github.com/repos/SKuipers/core/events","assignees_url":"https://api.github.com/repos/SKuipers/core/assignees{/user}","branches_url":"https://api.github.com/repos/SKuipers/core/branches{/branch}","tags_url":"https://api.github.com/repos/SKuipers/core/tags","blobs_url":"https://api.github.com/repos/SKuipers/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SKuipers/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SKuipers/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/SKuipers/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SKuipers/core/statuses/{sha}","languages_url":"https://api.github.com/repos/SKuipers/core/languages","stargazers_url":"https://api.github.com/repos/SKuipers/core/stargazers","contributors_url":"https://api.github.com/repos/SKuipers/core/contributors","subscribers_url":"https://api.github.com/repos/SKuipers/core/subscribers","subscription_url":"https://api.github.com/repos/SKuipers/core/subscription","commits_url":"https://api.github.com/repos/SKuipers/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/SKuipers/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/SKuipers/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/SKuipers/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/SKuipers/core/contents/{+path}","compare_url":"https://api.github.com/repos/SKuipers/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SKuipers/core/merges","archive_url":"https://api.github.com/repos/SKuipers/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SKuipers/core/downloads","issues_url":"https://api.github.com/repos/SKuipers/core/issues{/number}","pulls_url":"https://api.github.com/repos/SKuipers/core/pulls{/number}","milestones_url":"https://api.github.com/repos/SKuipers/core/milestones{/number}","notifications_url":"https://api.github.com/repos/SKuipers/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SKuipers/core/labels{/name}","releases_url":"https://api.github.com/repos/SKuipers/core/releases{/id}","deployments_url":"https://api.github.com/repos/SKuipers/core/deployments","created_at":"2016-03-21T01:39:12Z","updated_at":"2016-11-23T05:43:46Z","pushed_at":"2017-05-19T08:30:19Z","git_url":"git://github.com/SKuipers/core.git","ssh_url":"git@github.com:SKuipers/core.git","clone_url":"https://github.com/SKuipers/core.git","svn_url":"https://github.com/SKuipers/core","homepage":"  https://gibbonedu.org","size":130586,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"v14.0.00"}},"base":{"label":"GibbonEdu:v14.0.00","ref":"v14.0.00","sha":"ea17a7175a77313d1c9dbf011873d7e9eae940d2","user":{"login":"GibbonEdu","id":5439639,"avatar_url":"https://avatars3.githubusercontent.com/u/5439639?v=3","gravatar_id":"","url":"https://api.github.com/users/GibbonEdu","html_url":"https://github.com/GibbonEdu","followers_url":"https://api.github.com/users/GibbonEdu/followers","following_url":"https://api.github.com/users/GibbonEdu/following{/other_user}","gists_url":"https://api.github.com/users/GibbonEdu/gists{/gist_id}","starred_url":"https://api.github.com/users/GibbonEdu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GibbonEdu/subscriptions","organizations_url":"https://api.github.com/users/GibbonEdu/orgs","repos_url":"https://api.github.com/users/GibbonEdu/repos","events_url":"https://api.github.com/users/GibbonEdu/events{/privacy}","received_events_url":"https://api.github.com/users/GibbonEdu/received_events","type":"Organization","site_admin":false},"repo":{"id":12769307,"name":"core","full_name":"GibbonEdu/core","owner":{"login":"GibbonEdu","id":5439639,"avatar_url":"https://avatars3.githubusercontent.com/u/5439639?v=3","gravatar_id":"","url":"https://api.github.com/users/GibbonEdu","html_url":"https://github.com/GibbonEdu","followers_url":"https://api.github.com/users/GibbonEdu/followers","following_url":"https://api.github.com/users/GibbonEdu/following{/other_user}","gists_url":"https://api.github.com/users/GibbonEdu/gists{/gist_id}","starred_url":"https://api.github.com/users/GibbonEdu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GibbonEdu/subscriptions","organizations_url":"https://api.github.com/users/GibbonEdu/orgs","repos_url":"https://api.github.com/users/GibbonEdu/repos","events_url":"https://api.github.com/users/GibbonEdu/events{/privacy}","received_events_url":"https://api.github.com/users/GibbonEdu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GibbonEdu/core","description":"Gibbon is a flexible, open source school management platform designed to make life better for teachers, students, parents and leaders.","fork":false,"url":"https://api.github.com/repos/GibbonEdu/core","forks_url":"https://api.github.com/repos/GibbonEdu/core/forks","keys_url":"https://api.github.com/repos/GibbonEdu/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GibbonEdu/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GibbonEdu/core/teams","hooks_url":"https://api.github.com/repos/GibbonEdu/core/hooks","issue_events_url":"https://api.github.com/repos/GibbonEdu/core/issues/events{/number}","events_url":"https://api.github.com/repos/GibbonEdu/core/events","assignees_url":"https://api.github.com/repos/GibbonEdu/core/assignees{/user}","branches_url":"https://api.github.com/repos/GibbonEdu/core/branches{/branch}","tags_url":"https://api.github.com/repos/GibbonEdu/core/tags","blobs_url":"https://api.github.com/repos/GibbonEdu/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GibbonEdu/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GibbonEdu/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/GibbonEdu/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GibbonEdu/core/statuses/{sha}","languages_url":"https://api.github.com/repos/GibbonEdu/core/languages","stargazers_url":"https://api.github.com/repos/GibbonEdu/core/stargazers","contributors_url":"https://api.github.com/repos/GibbonEdu/core/contributors","subscribers_url":"https://api.github.com/repos/GibbonEdu/core/subscribers","subscription_url":"https://api.github.com/repos/GibbonEdu/core/subscription","commits_url":"https://api.github.com/repos/GibbonEdu/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/GibbonEdu/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/GibbonEdu/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/GibbonEdu/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/GibbonEdu/core/contents/{+path}","compare_url":"https://api.github.com/repos/GibbonEdu/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GibbonEdu/core/merges","archive_url":"https://api.github.com/repos/GibbonEdu/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GibbonEdu/core/downloads","issues_url":"https://api.github.com/repos/GibbonEdu/core/issues{/number}","pulls_url":"https://api.github.com/repos/GibbonEdu/core/pulls{/number}","milestones_url":"https://api.github.com/repos/GibbonEdu/core/milestones{/number}","notifications_url":"https://api.github.com/repos/GibbonEdu/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GibbonEdu/core/labels{/name}","releases_url":"https://api.github.com/repos/GibbonEdu/core/releases{/id}","deployments_url":"https://api.github.com/repos/GibbonEdu/core/deployments","created_at":"2013-09-11T22:24:34Z","updated_at":"2017-05-04T07:09:05Z","pushed_at":"2017-05-19T12:57:27Z","git_url":"git://github.com/GibbonEdu/core.git","ssh_url":"git@github.com:GibbonEdu/core.git","clone_url":"https://github.com/GibbonEdu/core.git","svn_url":"https://github.com/GibbonEdu/core","homepage":"https://gibbonedu.org","size":130305,"stargazers_count":85,"watchers_count":85,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":77,"mirror_url":null,"open_issues_count":3,"forks":77,"open_issues":3,"watchers":85,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GibbonEdu/core/pulls/235"},"html":{"href":"https://github.com/GibbonEdu/core/pull/235"},"issue":{"href":"https://api.github.com/repos/GibbonEdu/core/issues/235"},"comments":{"href":"https://api.github.com/repos/GibbonEdu/core/issues/235/comments"},"review_comments":{"href":"https://api.github.com/repos/GibbonEdu/core/pulls/235/comments"},"review_comment":{"href":"https://api.github.com/repos/GibbonEdu/core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GibbonEdu/core/pulls/235/commits"},"statuses":{"href":"https://api.github.com/repos/GibbonEdu/core/statuses/6a4bb0a14a7ebb99be51d62db881f131611038fa"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"rossdotparker","id":5436438,"avatar_url":"https://avatars2.githubusercontent.com/u/5436438?v=3","gravatar_id":"","url":"https://api.github.com/users/rossdotparker","html_url":"https://github.com/rossdotparker","followers_url":"https://api.github.com/users/rossdotparker/followers","following_url":"https://api.github.com/users/rossdotparker/following{/other_user}","gists_url":"https://api.github.com/users/rossdotparker/gists{/gist_id}","starred_url":"https://api.github.com/users/rossdotparker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rossdotparker/subscriptions","organizations_url":"https://api.github.com/users/rossdotparker/orgs","repos_url":"https://api.github.com/users/rossdotparker/repos","events_url":"https://api.github.com/users/rossdotparker/events{/privacy}","received_events_url":"https://api.github.com/users/rossdotparker/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":16,"additions":702,"deletions":592,"changed_files":9}}
{"actor":{"display_login":"rossdotparker"}}