{"action":"created","issue":{"url":"https://api.github.com/repos/stan-dev/math/issues/571","repository_url":"https://api.github.com/repos/stan-dev/math","labels_url":"https://api.github.com/repos/stan-dev/math/issues/571/labels{/name}","comments_url":"https://api.github.com/repos/stan-dev/math/issues/571/comments","events_url":"https://api.github.com/repos/stan-dev/math/issues/571/events","html_url":"https://github.com/stan-dev/math/pull/571","id":239804065,"number":571,"title":"Enable C++11 and 14","user":{"login":"seantalts","id":805356,"avatar_url":"https://avatars1.githubusercontent.com/u/805356?v=4","gravatar_id":"","url":"https://api.github.com/users/seantalts","html_url":"https://github.com/seantalts","followers_url":"https://api.github.com/users/seantalts/followers","following_url":"https://api.github.com/users/seantalts/following{/other_user}","gists_url":"https://api.github.com/users/seantalts/gists{/gist_id}","starred_url":"https://api.github.com/users/seantalts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seantalts/subscriptions","organizations_url":"https://api.github.com/users/seantalts/orgs","repos_url":"https://api.github.com/users/seantalts/repos","events_url":"https://api.github.com/users/seantalts/events{/privacy}","received_events_url":"https://api.github.com/users/seantalts/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/stan-dev/math/milestones/15","html_url":"https://github.com/stan-dev/math/milestone/15","labels_url":"https://api.github.com/repos/stan-dev/math/milestones/15/labels","id":2596696,"number":15,"title":"2.16++","description":"","creator":{"login":"bob-carpenter","id":3383807,"avatar_url":"https://avatars1.githubusercontent.com/u/3383807?v=4","gravatar_id":"","url":"https://api.github.com/users/bob-carpenter","html_url":"https://github.com/bob-carpenter","followers_url":"https://api.github.com/users/bob-carpenter/followers","following_url":"https://api.github.com/users/bob-carpenter/following{/other_user}","gists_url":"https://api.github.com/users/bob-carpenter/gists{/gist_id}","starred_url":"https://api.github.com/users/bob-carpenter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bob-carpenter/subscriptions","organizations_url":"https://api.github.com/users/bob-carpenter/orgs","repos_url":"https://api.github.com/users/bob-carpenter/repos","events_url":"https://api.github.com/users/bob-carpenter/events{/privacy}","received_events_url":"https://api.github.com/users/bob-carpenter/received_events","type":"User","site_admin":false},"open_issues":22,"closed_issues":0,"state":"open","created_at":"2017-06-21T17:11:16Z","updated_at":"2017-07-10T17:28:06Z","due_on":null,"closed_at":null},"comments":5,"created_at":"2017-06-30T14:56:34Z","updated_at":"2017-07-17T19:01:40Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/stan-dev/math/pulls/571","html_url":"https://github.com/stan-dev/math/pull/571","diff_url":"https://github.com/stan-dev/math/pull/571.diff","patch_url":"https://github.com/stan-dev/math/pull/571.patch"},"body":"Enable C++11 and available C++14 extensions in the build systems. \r\n#### Copyright and Licensing\r\n\r\nPlease list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Columbia University\r\n\r\nBy submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:\r\n- Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)\r\n- Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)\r\n"},"comment":{"url":"https://api.github.com/repos/stan-dev/math/issues/comments/315849906","html_url":"https://github.com/stan-dev/math/pull/571#issuecomment-315849906","issue_url":"https://api.github.com/repos/stan-dev/math/issues/571","id":315849906,"user":{"login":"syclik","id":425751,"avatar_url":"https://avatars2.githubusercontent.com/u/425751?v=4","gravatar_id":"","url":"https://api.github.com/users/syclik","html_url":"https://github.com/syclik","followers_url":"https://api.github.com/users/syclik/followers","following_url":"https://api.github.com/users/syclik/following{/other_user}","gists_url":"https://api.github.com/users/syclik/gists{/gist_id}","starred_url":"https://api.github.com/users/syclik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syclik/subscriptions","organizations_url":"https://api.github.com/users/syclik/orgs","repos_url":"https://api.github.com/users/syclik/repos","events_url":"https://api.github.com/users/syclik/events{/privacy}","received_events_url":"https://api.github.com/users/syclik/received_events","type":"User","site_admin":false},"created_at":"2017-07-17T19:01:40Z","updated_at":"2017-07-17T19:01:40Z","body":"Ah. I see. I'll fix that.\n\nIt's inconsistent because we're still compiling everything with CC instead\nof CXX. I just created an issue to address it.\n\nFor Stan and CmdStan, they use includes to pull in the math makefiles, so\nfor the most part, we shouldn't need to duplicate.\n\n\nOn Mon, Jul 17, 2017 at 2:53 PM, seantalts <notifications@github.com> wrote:\n\n> Now cvodes is compiling with -stdlib=libc++ on clang, which seems to work\n> but is not ideal. I'm not sure what about using CXXFLAGS with CFLAGS is\n> inconsistent; we'll need both even when we straighten out these makefiles.\n> We'll also likely use a third one called CPPFLAGS that is sent to both C\n> and C++ compilers. Anyway, I'd love to see this merged in. For Stan and\n> CmdStan, would you imagine we just take these same changes and apply them\n> upstream since they don't share the relevant parts of the makefile\n> configuration?\n>\n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/stan-dev/math/pull/571#issuecomment-315847440>, or mute\n> the thread\n> <https://github.com/notifications/unsubscribe-auth/AAZ_F7CAIhOaAE1UkWUpT6Oe_QopcITkks5sO62TgaJpZM4OKsG8>\n> .\n>\n"}}
{"actor":{"display_login":"syclik"}}