{"action":"closed","issue":{"url":"https://api.github.com/repos/Giveth/vaultcontract/issues/10","repository_url":"https://api.github.com/repos/Giveth/vaultcontract","labels_url":"https://api.github.com/repos/Giveth/vaultcontract/issues/10/labels{/name}","comments_url":"https://api.github.com/repos/Giveth/vaultcontract/issues/10/comments","events_url":"https://api.github.com/repos/Giveth/vaultcontract/issues/10/events","html_url":"https://github.com/Giveth/vaultcontract/issues/10","id":201529220,"number":10,"title":"indexed events","user":{"login":"ethers","id":6937903,"avatar_url":"https://avatars.githubusercontent.com/u/6937903?v=3","gravatar_id":"","url":"https://api.github.com/users/ethers","html_url":"https://github.com/ethers","followers_url":"https://api.github.com/users/ethers/followers","following_url":"https://api.github.com/users/ethers/following{/other_user}","gists_url":"https://api.github.com/users/ethers/gists{/gist_id}","starred_url":"https://api.github.com/users/ethers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethers/subscriptions","organizations_url":"https://api.github.com/users/ethers/orgs","repos_url":"https://api.github.com/users/ethers/repos","events_url":"https://api.github.com/users/ethers/events{/privacy}","received_events_url":"https://api.github.com/users/ethers/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-01-18T10:10:15Z","updated_at":"2017-01-18T13:18:39Z","closed_at":"2017-01-18T13:18:39Z","body":"Seems it would be helpful for some of the events to have indexed arguments.\r\n\r\n    event PaymentAuthorized(uint idPayment, address recipient, uint amount);\r\n    event PaymentExecuted(uint idPayment, address recipient, uint amount);\r\n    event PaymentCanceled(uint idPayment);\r\n\r\nIf `idPayment` was indexed it would be easier to answer:\r\n- what happened to a particular payment\r\n\r\nIf `recipient` was indexed it would be easier to answer:\r\n- what are the payments authorized/executed for a recipient?\r\n\r\nWorth considering whether `from` and `spender` should be indexed too.\r\n\r\n    event EtherReceived(address from, uint amount);\r\n    event SpenderAuthorization(address spender, bool authorized);"}}
{"actor":{"display_login":"jbaylina"}}