{"action":"created","issue":{"url":"https://api.github.com/repos/evennia/evennia/issues/1492","repository_url":"https://api.github.com/repos/evennia/evennia","labels_url":"https://api.github.com/repos/evennia/evennia/issues/1492/labels{/name}","comments_url":"https://api.github.com/repos/evennia/evennia/issues/1492/comments","events_url":"https://api.github.com/repos/evennia/evennia/issues/1492/events","html_url":"https://github.com/evennia/evennia/pull/1492","id":268629260,"number":1492,"title":"Add tests for general_context","user":{"login":"TehomCD","id":17857779,"avatar_url":"https://avatars1.githubusercontent.com/u/17857779?v=4","gravatar_id":"","url":"https://api.github.com/users/TehomCD","html_url":"https://github.com/TehomCD","followers_url":"https://api.github.com/users/TehomCD/followers","following_url":"https://api.github.com/users/TehomCD/following{/other_user}","gists_url":"https://api.github.com/users/TehomCD/gists{/gist_id}","starred_url":"https://api.github.com/users/TehomCD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TehomCD/subscriptions","organizations_url":"https://api.github.com/users/TehomCD/orgs","repos_url":"https://api.github.com/users/TehomCD/repos","events_url":"https://api.github.com/users/TehomCD/events{/privacy}","received_events_url":"https://api.github.com/users/TehomCD/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-10-26T04:52:07Z","updated_at":"2017-10-30T19:39:14Z","closed_at":"2017-10-30T19:39:14Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/evennia/evennia/pulls/1492","html_url":"https://github.com/evennia/evennia/pull/1492","diff_url":"https://github.com/evennia/evennia/pull/1492.diff","patch_url":"https://github.com/evennia/evennia/pull/1492.patch"},"body":"#### Brief overview of PR changes/additions\r\nAnother small bit of unit testing, this one for the general_context for the webpage. I struggled a bit with the testing of the global variables that were assigned - while I could mock them, this wouldn't cover testing their actual assignment. So I decided to move them into functions that would be immediately called in the module so that those could have their own separate test methods. If you like the approach, it might be something I'd do when writing unit tests for other modules that use global variables.\r\n\r\n#### Motivation for adding to Evennia\r\nAdd more test coverage.\r\n\r\n#### Other info (issues closed, discussion etc)\r\nYet another #1458 "},"comment":{"url":"https://api.github.com/repos/evennia/evennia/issues/comments/340560433","html_url":"https://github.com/evennia/evennia/pull/1492#issuecomment-340560433","issue_url":"https://api.github.com/repos/evennia/evennia/issues/1492","id":340560433,"user":{"login":"Griatch","id":294267,"avatar_url":"https://avatars3.githubusercontent.com/u/294267?v=4","gravatar_id":"","url":"https://api.github.com/users/Griatch","html_url":"https://github.com/Griatch","followers_url":"https://api.github.com/users/Griatch/followers","following_url":"https://api.github.com/users/Griatch/following{/other_user}","gists_url":"https://api.github.com/users/Griatch/gists{/gist_id}","starred_url":"https://api.github.com/users/Griatch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Griatch/subscriptions","organizations_url":"https://api.github.com/users/Griatch/orgs","repos_url":"https://api.github.com/users/Griatch/repos","events_url":"https://api.github.com/users/Griatch/events{/privacy}","received_events_url":"https://api.github.com/users/Griatch/received_events","type":"User","site_admin":false},"created_at":"2017-10-30T19:39:14Z","updated_at":"2017-10-30T19:39:14Z","author_association":"OWNER","body":"Rebased and squashed, then merged into master branch. Thanks!"}}
{"actor":{"display_login":"Griatch"}}