{"action":"closed","issue":{"url":"https://api.github.com/repos/ngrx/platform/issues/632","repository_url":"https://api.github.com/repos/ngrx/platform","labels_url":"https://api.github.com/repos/ngrx/platform/issues/632/labels{/name}","comments_url":"https://api.github.com/repos/ngrx/platform/issues/632/comments","events_url":"https://api.github.com/repos/ngrx/platform/issues/632/events","html_url":"https://github.com/ngrx/platform/issues/632","id":279509015,"number":632,"title":"Maps/Sets can't be viewed in devtools","user":{"login":"berwyn","id":1403744,"avatar_url":"https://avatars2.githubusercontent.com/u/1403744?v=4","gravatar_id":"","url":"https://api.github.com/users/berwyn","html_url":"https://github.com/berwyn","followers_url":"https://api.github.com/users/berwyn/followers","following_url":"https://api.github.com/users/berwyn/following{/other_user}","gists_url":"https://api.github.com/users/berwyn/gists{/gist_id}","starred_url":"https://api.github.com/users/berwyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/berwyn/subscriptions","organizations_url":"https://api.github.com/users/berwyn/orgs","repos_url":"https://api.github.com/users/berwyn/repos","events_url":"https://api.github.com/users/berwyn/events{/privacy}","received_events_url":"https://api.github.com/users/berwyn/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-12-05T19:55:55Z","updated_at":"2017-12-13T14:49:45Z","closed_at":"2017-12-13T14:49:45Z","author_association":"NONE","body":"<!-- ❤️ ngrx? Please consider supporting our collective: 👉  [donate](https://opencollective.com/ngrx/donate) -->\r\n\r\n## I'm submitting a...\r\n<!-- Check one of the following options with \"x\" -->\r\n<pre><code>\r\n[ ] Regression (a behavior that used to work and stopped working in a new release)\r\n[x] Bug report  <!-- Please search GitHub for a similar issue or PR before submitting -->\r\n[x] Feature request\r\n[ ] Documentation issue or request\r\n</code></pre>\r\n\r\n## What is the current behavior?\r\n<!-- Describe the current behavior. -->\r\nAs noted in ngrx/store-devtools#64 and ngrx/store-devtools#67 using an ES2015 Set or Map works well enough in ngrx, but the devtools won't display the object instead showing an empty object (`{ }`) when it's first set, and omitting the object in diffs. Additionally, when looking at the graph of the store, the Set/Map will show up as a node, but have no associated value.\r\n\r\n## Expected behavior:\r\n<!-- Describe what the desired behavior would be. -->\r\nDevtools should show that a Set/Map was used, and that it was updated as a result of an action.\r\n\r\n## Minimal reproduction of the problem with instructions:\r\n<!--\r\nFor bug reports please provide the *STEPS TO REPRODUCE* and if possible a *MINIMAL DEMO* of the problem via\r\nhttp://plnkr.co/edit/tpl:757r6L\r\n-->\r\ngiven:\r\n```ts\r\nStoreDevtoolsModule.instrument({ maxAge: 50 })\r\n```\r\nand\r\n```ts\r\ninterface MyState {\r\n    data: Map<string, Item>;\r\n}\r\n```\r\nany reducer that updates this field will succeed, however this property will not be displayed correctly in the devtools, and will not exist in diffs.\r\n\r\n## Version of affected browser(s),operating system(s), npm, node and ngrx:\r\n`yarn@1.0.1`\r\n`node@7.10.1`\r\n`@ngrx/store@4.1.1`\r\n`@ngrx/effects@4.1.1`\r\n`@ngrx/store-devtools@4.1.1`\r\n\r\n## Other information:\r\nBased on the other bugs, it seems that the devtools extension may have a `serialize` argument that may alleviate this, however passing this to ngrx doesn't seem to do anything different, so I'm unsure if there's work on the ngrx side to support this.\r\n\r\n\r\n"}}
{"actor":{"display_login":"brandonroberts"}}