{"action":"created","issue":{"url":"https://api.github.com/repos/qgis/QGIS/issues/5048","repository_url":"https://api.github.com/repos/qgis/QGIS","labels_url":"https://api.github.com/repos/qgis/QGIS/issues/5048/labels{/name}","comments_url":"https://api.github.com/repos/qgis/QGIS/issues/5048/comments","events_url":"https://api.github.com/repos/qgis/QGIS/issues/5048/events","html_url":"https://github.com/qgis/QGIS/pull/5048","id":251371366,"number":5048,"title":"[WIP] Moving diagram placement options from combobox to radio buttons","user":{"login":"DelazJ","id":7983394,"avatar_url":"https://avatars0.githubusercontent.com/u/7983394?v=4","gravatar_id":"","url":"https://api.github.com/users/DelazJ","html_url":"https://github.com/DelazJ","followers_url":"https://api.github.com/users/DelazJ/followers","following_url":"https://api.github.com/users/DelazJ/following{/other_user}","gists_url":"https://api.github.com/users/DelazJ/gists{/gist_id}","starred_url":"https://api.github.com/users/DelazJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DelazJ/subscriptions","organizations_url":"https://api.github.com/users/DelazJ/orgs","repos_url":"https://api.github.com/users/DelazJ/repos","events_url":"https://api.github.com/users/DelazJ/events{/privacy}","received_events_url":"https://api.github.com/users/DelazJ/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-08-18T22:16:14Z","updated_at":"2017-09-01T16:41:46Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/qgis/QGIS/pulls/5048","html_url":"https://github.com/qgis/QGIS/pull/5048","diff_url":"https://github.com/qgis/QGIS/pull/5048.diff","patch_url":"https://github.com/qgis/QGIS/pull/5048.patch"},"body":"For consistency with the labeling dialog, this PR reorganizes diagram placement options into radio buttons (instead of combo box) - follow-up https://github.com/qgis/QGIS/pull/4793#issuecomment-314695038\r\n\r\n![image](https://user-images.githubusercontent.com/7983394/29478765-dfc3ff6c-846e-11e7-8771-05a496c92589.png)\r\n\r\n![image](https://user-images.githubusercontent.com/7983394/29478878-7d9e87b6-846f-11e7-9021-fa606954fa6f.png)\r\n\r\n![image](https://user-images.githubusercontent.com/7983394/29478919-cc3e66a2-846f-11e7-978a-781e2a075703.png)\r\n\r\n**TODO**\r\nSome settings related to the mPlacementCombobox widget need to be fixed (reason why the Placement (label and emptied combobox) is still visible in the screenshots). I'm not a C++ guy so i picked inspiration from labeling (qgstextformatwidget) but still wonder whether it's the right thing to do (given how this is tied to gui). I don't have skills to go further.\r\nAnyway, GUI part is almost done (and i hope the config part too). If somebody interested in this issue wants to fix the missing bits, it'd be nice! Thanks\r\n\r\n## Checklist\r\n\r\n> Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.\r\n\r\n- [x] Commit messages are descriptive and explain the rationale for changes\r\n- [ ] Commits which fix bugs include `fixes #11111` in the commit message next to the description\r\n- [ ] Commits which add new features are tagged with `[FEATURE]` in the commit message\r\n- [ ] Commits which change the UI or existing user workflows are tagged with `[needs-docs]` in the commit message and containt sufficient information in the commit message to be documented\r\n- [x] I have read the [QGIS Coding Standards](https://docs.qgis.org/testing/en/docs/developers_guide/codingstandards.html) and this PR complies with them\r\n- [ ] This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)\r\n- [ ] New unit tests have been added for core changes\r\n- [x] I have run [the `scripts/prepare-commit.sh` script](https://github.com/qgis/QGIS/blob/master/.github/CONTRIBUTE.md#contributing-to-qgis) before each commit\r\n"},"comment":{"url":"https://api.github.com/repos/qgis/QGIS/issues/comments/326628355","html_url":"https://github.com/qgis/QGIS/pull/5048#issuecomment-326628355","issue_url":"https://api.github.com/repos/qgis/QGIS/issues/5048","id":326628355,"user":{"login":"m-kuhn","id":588407,"avatar_url":"https://avatars1.githubusercontent.com/u/588407?v=4","gravatar_id":"","url":"https://api.github.com/users/m-kuhn","html_url":"https://github.com/m-kuhn","followers_url":"https://api.github.com/users/m-kuhn/followers","following_url":"https://api.github.com/users/m-kuhn/following{/other_user}","gists_url":"https://api.github.com/users/m-kuhn/gists{/gist_id}","starred_url":"https://api.github.com/users/m-kuhn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-kuhn/subscriptions","organizations_url":"https://api.github.com/users/m-kuhn/orgs","repos_url":"https://api.github.com/users/m-kuhn/repos","events_url":"https://api.github.com/users/m-kuhn/events{/privacy}","received_events_url":"https://api.github.com/users/m-kuhn/received_events","type":"User","site_admin":false},"created_at":"2017-09-01T16:41:46Z","updated_at":"2017-09-01T16:41:46Z","author_association":"MEMBER","body":"@DelazJ do you have plans to continue working on this?"}}
{"actor":{"display_login":"m-kuhn"}}