{"action":"created","issue":{"url":"https://api.github.com/repos/mixu/gr/issues/66","repository_url":"https://api.github.com/repos/mixu/gr","labels_url":"https://api.github.com/repos/mixu/gr/issues/66/labels{/name}","comments_url":"https://api.github.com/repos/mixu/gr/issues/66/comments","events_url":"https://api.github.com/repos/mixu/gr/issues/66/events","html_url":"https://github.com/mixu/gr/issues/66","id":216533493,"number":66,"title":"The current method for detecting submodules does not work in all cases.","user":{"login":"cojomojo","id":5669480,"avatar_url":"https://avatars1.githubusercontent.com/u/5669480?v=4","gravatar_id":"","url":"https://api.github.com/users/cojomojo","html_url":"https://github.com/cojomojo","followers_url":"https://api.github.com/users/cojomojo/followers","following_url":"https://api.github.com/users/cojomojo/following{/other_user}","gists_url":"https://api.github.com/users/cojomojo/gists{/gist_id}","starred_url":"https://api.github.com/users/cojomojo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cojomojo/subscriptions","organizations_url":"https://api.github.com/users/cojomojo/orgs","repos_url":"https://api.github.com/users/cojomojo/repos","events_url":"https://api.github.com/users/cojomojo/events{/privacy}","received_events_url":"https://api.github.com/users/cojomojo/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-03-23T18:45:11Z","updated_at":"2017-09-28T00:17:23Z","closed_at":"2017-09-28T00:17:23Z","author_association":"CONTRIBUTOR","body":"Say the .git directory is in `foo/`, and the submodule path is  `foo/bar/submodule`... then the way we are currently checking for a submodule directory fails as mentioned in #65. \r\n\r\nAlso, I have come across an issue on Windows 7 where the current method fails even when the submodule path is `foo/submodule`. \r\n\r\nOverall, as @bimlas mentions in #54 / #65, it would be much better if we check for git directories by executing a variant of the command 'git rev-parse`.  Specifically, the best command to use is `git rev-parse --is-inside-git-dir', which returns true if the directory is the working tree, false if it is in the .git tree (i.e. untracked, but in a place where git commands are still valid), and throws a fatal error if it is not a git directory.  "},"comment":{"url":"https://api.github.com/repos/mixu/gr/issues/comments/332691279","html_url":"https://github.com/mixu/gr/issues/66#issuecomment-332691279","issue_url":"https://api.github.com/repos/mixu/gr/issues/66","id":332691279,"user":{"login":"mixu","id":398530,"avatar_url":"https://avatars3.githubusercontent.com/u/398530?v=4","gravatar_id":"","url":"https://api.github.com/users/mixu","html_url":"https://github.com/mixu","followers_url":"https://api.github.com/users/mixu/followers","following_url":"https://api.github.com/users/mixu/following{/other_user}","gists_url":"https://api.github.com/users/mixu/gists{/gist_id}","starred_url":"https://api.github.com/users/mixu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixu/subscriptions","organizations_url":"https://api.github.com/users/mixu/orgs","repos_url":"https://api.github.com/users/mixu/repos","events_url":"https://api.github.com/users/mixu/events{/privacy}","received_events_url":"https://api.github.com/users/mixu/received_events","type":"User","site_admin":false},"created_at":"2017-09-28T00:17:23Z","updated_at":"2017-09-28T00:17:23Z","author_association":"OWNER","body":"I have no strong opinions on `git rev-parse --show-prefix` vs `git rev-parse --is-inside-git-dir` since my use case tends to be pretty simple, happy to revisit this but closing for now since #65 landed"}}
{"actor":{"display_login":"mixu"}}