{"action":"created","comment":{"url":"https://api.github.com/repos/RxPHP/RxWebsocket/pulls/comments/138738929","pull_request_review_id":62575936,"id":138738929,"diff_hunk":"@@ -63,31 +68,67 @@ function (FrameInterface $frame) use ($rawDataOut) {\n                             parent::onError($exception);\n                         }\n \n-                        // complete output stream\n-                        $rawDataOut->onCompleted();\n+                        $this->rawDataOut->onCompleted();\n \n-                        // signal subscribers that we are done here\n-                        //parent::onCompleted();\n+                        parent::onCompleted();\n+\n+                        $this->rawDataDisp->dispose();\n                         return;\n                 }\n             },\n             !$this->mask\n         );\n \n-        $this->rawDataDisp = $this->rawDataIn->subscribe(\n-            function ($data) use ($messageBuffer) {","path":"src/MessageSubject.php","position":55,"original_position":55,"commit_id":"14c6fc9f7c8ffabf10939d87ce15f56327cca143","original_commit_id":"14c6fc9f7c8ffabf10939d87ce15f56327cca143","user":{"login":"davidwdan","id":4969183,"avatar_url":"https://avatars3.githubusercontent.com/u/4969183?v=4","gravatar_id":"","url":"https://api.github.com/users/davidwdan","html_url":"https://github.com/davidwdan","followers_url":"https://api.github.com/users/davidwdan/followers","following_url":"https://api.github.com/users/davidwdan/following{/other_user}","gists_url":"https://api.github.com/users/davidwdan/gists{/gist_id}","starred_url":"https://api.github.com/users/davidwdan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidwdan/subscriptions","organizations_url":"https://api.github.com/users/davidwdan/orgs","repos_url":"https://api.github.com/users/davidwdan/repos","events_url":"https://api.github.com/users/davidwdan/events{/privacy}","received_events_url":"https://api.github.com/users/davidwdan/received_events","type":"User","site_admin":false},"body":"Consider using `[$messageBuffer, 'onData']`","created_at":"2017-09-13T21:03:37Z","updated_at":"2017-09-13T21:08:58Z","html_url":"https://github.com/RxPHP/RxWebsocket/pull/14#discussion_r138738929","pull_request_url":"https://api.github.com/repos/RxPHP/RxWebsocket/pulls/14","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/RxPHP/RxWebsocket/pulls/comments/138738929"},"html":{"href":"https://github.com/RxPHP/RxWebsocket/pull/14#discussion_r138738929"},"pull_request":{"href":"https://api.github.com/repos/RxPHP/RxWebsocket/pulls/14"}}},"pull_request":{"url":"https://api.github.com/repos/RxPHP/RxWebsocket/pulls/14","id":140928190,"html_url":"https://github.com/RxPHP/RxWebsocket/pull/14","diff_url":"https://github.com/RxPHP/RxWebsocket/pull/14.diff","patch_url":"https://github.com/RxPHP/RxWebsocket/pull/14.patch","issue_url":"https://api.github.com/repos/RxPHP/RxWebsocket/issues/14","number":14,"state":"open","locked":false,"title":"Add keepalive and some minor fixes with disposables","user":{"login":"mbonneau","id":748287,"avatar_url":"https://avatars3.githubusercontent.com/u/748287?v=4","gravatar_id":"","url":"https://api.github.com/users/mbonneau","html_url":"https://github.com/mbonneau","followers_url":"https://api.github.com/users/mbonneau/followers","following_url":"https://api.github.com/users/mbonneau/following{/other_user}","gists_url":"https://api.github.com/users/mbonneau/gists{/gist_id}","starred_url":"https://api.github.com/users/mbonneau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbonneau/subscriptions","organizations_url":"https://api.github.com/users/mbonneau/orgs","repos_url":"https://api.github.com/users/mbonneau/repos","events_url":"https://api.github.com/users/mbonneau/events{/privacy}","received_events_url":"https://api.github.com/users/mbonneau/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-09-13T20:56:21Z","updated_at":"2017-09-13T21:08:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9c479cc07caee16e54a6884f082bd56f32d1fbe4","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/RxPHP/RxWebsocket/pulls/14/commits","review_comments_url":"https://api.github.com/repos/RxPHP/RxWebsocket/pulls/14/comments","review_comment_url":"https://api.github.com/repos/RxPHP/RxWebsocket/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RxPHP/RxWebsocket/issues/14/comments","statuses_url":"https://api.github.com/repos/RxPHP/RxWebsocket/statuses/14c6fc9f7c8ffabf10939d87ce15f56327cca143","head":{"label":"RxPHP:keepalive","ref":"keepalive","sha":"14c6fc9f7c8ffabf10939d87ce15f56327cca143","user":{"login":"RxPHP","id":16820644,"avatar_url":"https://avatars2.githubusercontent.com/u/16820644?v=4","gravatar_id":"","url":"https://api.github.com/users/RxPHP","html_url":"https://github.com/RxPHP","followers_url":"https://api.github.com/users/RxPHP/followers","following_url":"https://api.github.com/users/RxPHP/following{/other_user}","gists_url":"https://api.github.com/users/RxPHP/gists{/gist_id}","starred_url":"https://api.github.com/users/RxPHP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RxPHP/subscriptions","organizations_url":"https://api.github.com/users/RxPHP/orgs","repos_url":"https://api.github.com/users/RxPHP/repos","events_url":"https://api.github.com/users/RxPHP/events{/privacy}","received_events_url":"https://api.github.com/users/RxPHP/received_events","type":"Organization","site_admin":false},"repo":{"id":50526382,"name":"RxWebsocket","full_name":"RxPHP/RxWebsocket","owner":{"login":"RxPHP","id":16820644,"avatar_url":"https://avatars2.githubusercontent.com/u/16820644?v=4","gravatar_id":"","url":"https://api.github.com/users/RxPHP","html_url":"https://github.com/RxPHP","followers_url":"https://api.github.com/users/RxPHP/followers","following_url":"https://api.github.com/users/RxPHP/following{/other_user}","gists_url":"https://api.github.com/users/RxPHP/gists{/gist_id}","starred_url":"https://api.github.com/users/RxPHP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RxPHP/subscriptions","organizations_url":"https://api.github.com/users/RxPHP/orgs","repos_url":"https://api.github.com/users/RxPHP/repos","events_url":"https://api.github.com/users/RxPHP/events{/privacy}","received_events_url":"https://api.github.com/users/RxPHP/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RxPHP/RxWebsocket","description":"Websockets for PHP using Rx","fork":false,"url":"https://api.github.com/repos/RxPHP/RxWebsocket","forks_url":"https://api.github.com/repos/RxPHP/RxWebsocket/forks","keys_url":"https://api.github.com/repos/RxPHP/RxWebsocket/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RxPHP/RxWebsocket/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RxPHP/RxWebsocket/teams","hooks_url":"https://api.github.com/repos/RxPHP/RxWebsocket/hooks","issue_events_url":"https://api.github.com/repos/RxPHP/RxWebsocket/issues/events{/number}","events_url":"https://api.github.com/repos/RxPHP/RxWebsocket/events","assignees_url":"https://api.github.com/repos/RxPHP/RxWebsocket/assignees{/user}","branches_url":"https://api.github.com/repos/RxPHP/RxWebsocket/branches{/branch}","tags_url":"https://api.github.com/repos/RxPHP/RxWebsocket/tags","blobs_url":"https://api.github.com/repos/RxPHP/RxWebsocket/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RxPHP/RxWebsocket/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RxPHP/RxWebsocket/git/refs{/sha}","trees_url":"https://api.github.com/repos/RxPHP/RxWebsocket/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RxPHP/RxWebsocket/statuses/{sha}","languages_url":"https://api.github.com/repos/RxPHP/RxWebsocket/languages","stargazers_url":"https://api.github.com/repos/RxPHP/RxWebsocket/stargazers","contributors_url":"https://api.github.com/repos/RxPHP/RxWebsocket/contributors","subscribers_url":"https://api.github.com/repos/RxPHP/RxWebsocket/subscribers","subscription_url":"https://api.github.com/repos/RxPHP/RxWebsocket/subscription","commits_url":"https://api.github.com/repos/RxPHP/RxWebsocket/commits{/sha}","git_commits_url":"https://api.github.com/repos/RxPHP/RxWebsocket/git/commits{/sha}","comments_url":"https://api.github.com/repos/RxPHP/RxWebsocket/comments{/number}","issue_comment_url":"https://api.github.com/repos/RxPHP/RxWebsocket/issues/comments{/number}","contents_url":"https://api.github.com/repos/RxPHP/RxWebsocket/contents/{+path}","compare_url":"https://api.github.com/repos/RxPHP/RxWebsocket/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RxPHP/RxWebsocket/merges","archive_url":"https://api.github.com/repos/RxPHP/RxWebsocket/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RxPHP/RxWebsocket/downloads","issues_url":"https://api.github.com/repos/RxPHP/RxWebsocket/issues{/number}","pulls_url":"https://api.github.com/repos/RxPHP/RxWebsocket/pulls{/number}","milestones_url":"https://api.github.com/repos/RxPHP/RxWebsocket/milestones{/number}","notifications_url":"https://api.github.com/repos/RxPHP/RxWebsocket/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RxPHP/RxWebsocket/labels{/name}","releases_url":"https://api.github.com/repos/RxPHP/RxWebsocket/releases{/id}","deployments_url":"https://api.github.com/repos/RxPHP/RxWebsocket/deployments","created_at":"2016-01-27T17:53:14Z","updated_at":"2017-09-11T19:15:54Z","pushed_at":"2017-09-13T20:56:22Z","git_url":"git://github.com/RxPHP/RxWebsocket.git","ssh_url":"git@github.com:RxPHP/RxWebsocket.git","clone_url":"https://github.com/RxPHP/RxWebsocket.git","svn_url":"https://github.com/RxPHP/RxWebsocket","homepage":"","size":57,"stargazers_count":19,"watchers_count":19,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":4,"forks":4,"open_issues":4,"watchers":19,"default_branch":"master"}},"base":{"label":"RxPHP:master","ref":"master","sha":"06680bb1d0ca1b255d8947981e9d5956a074bcce","user":{"login":"RxPHP","id":16820644,"avatar_url":"https://avatars2.githubusercontent.com/u/16820644?v=4","gravatar_id":"","url":"https://api.github.com/users/RxPHP","html_url":"https://github.com/RxPHP","followers_url":"https://api.github.com/users/RxPHP/followers","following_url":"https://api.github.com/users/RxPHP/following{/other_user}","gists_url":"https://api.github.com/users/RxPHP/gists{/gist_id}","starred_url":"https://api.github.com/users/RxPHP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RxPHP/subscriptions","organizations_url":"https://api.github.com/users/RxPHP/orgs","repos_url":"https://api.github.com/users/RxPHP/repos","events_url":"https://api.github.com/users/RxPHP/events{/privacy}","received_events_url":"https://api.github.com/users/RxPHP/received_events","type":"Organization","site_admin":false},"repo":{"id":50526382,"name":"RxWebsocket","full_name":"RxPHP/RxWebsocket","owner":{"login":"RxPHP","id":16820644,"avatar_url":"https://avatars2.githubusercontent.com/u/16820644?v=4","gravatar_id":"","url":"https://api.github.com/users/RxPHP","html_url":"https://github.com/RxPHP","followers_url":"https://api.github.com/users/RxPHP/followers","following_url":"https://api.github.com/users/RxPHP/following{/other_user}","gists_url":"https://api.github.com/users/RxPHP/gists{/gist_id}","starred_url":"https://api.github.com/users/RxPHP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RxPHP/subscriptions","organizations_url":"https://api.github.com/users/RxPHP/orgs","repos_url":"https://api.github.com/users/RxPHP/repos","events_url":"https://api.github.com/users/RxPHP/events{/privacy}","received_events_url":"https://api.github.com/users/RxPHP/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RxPHP/RxWebsocket","description":"Websockets for PHP using Rx","fork":false,"url":"https://api.github.com/repos/RxPHP/RxWebsocket","forks_url":"https://api.github.com/repos/RxPHP/RxWebsocket/forks","keys_url":"https://api.github.com/repos/RxPHP/RxWebsocket/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RxPHP/RxWebsocket/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RxPHP/RxWebsocket/teams","hooks_url":"https://api.github.com/repos/RxPHP/RxWebsocket/hooks","issue_events_url":"https://api.github.com/repos/RxPHP/RxWebsocket/issues/events{/number}","events_url":"https://api.github.com/repos/RxPHP/RxWebsocket/events","assignees_url":"https://api.github.com/repos/RxPHP/RxWebsocket/assignees{/user}","branches_url":"https://api.github.com/repos/RxPHP/RxWebsocket/branches{/branch}","tags_url":"https://api.github.com/repos/RxPHP/RxWebsocket/tags","blobs_url":"https://api.github.com/repos/RxPHP/RxWebsocket/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RxPHP/RxWebsocket/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RxPHP/RxWebsocket/git/refs{/sha}","trees_url":"https://api.github.com/repos/RxPHP/RxWebsocket/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RxPHP/RxWebsocket/statuses/{sha}","languages_url":"https://api.github.com/repos/RxPHP/RxWebsocket/languages","stargazers_url":"https://api.github.com/repos/RxPHP/RxWebsocket/stargazers","contributors_url":"https://api.github.com/repos/RxPHP/RxWebsocket/contributors","subscribers_url":"https://api.github.com/repos/RxPHP/RxWebsocket/subscribers","subscription_url":"https://api.github.com/repos/RxPHP/RxWebsocket/subscription","commits_url":"https://api.github.com/repos/RxPHP/RxWebsocket/commits{/sha}","git_commits_url":"https://api.github.com/repos/RxPHP/RxWebsocket/git/commits{/sha}","comments_url":"https://api.github.com/repos/RxPHP/RxWebsocket/comments{/number}","issue_comment_url":"https://api.github.com/repos/RxPHP/RxWebsocket/issues/comments{/number}","contents_url":"https://api.github.com/repos/RxPHP/RxWebsocket/contents/{+path}","compare_url":"https://api.github.com/repos/RxPHP/RxWebsocket/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RxPHP/RxWebsocket/merges","archive_url":"https://api.github.com/repos/RxPHP/RxWebsocket/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RxPHP/RxWebsocket/downloads","issues_url":"https://api.github.com/repos/RxPHP/RxWebsocket/issues{/number}","pulls_url":"https://api.github.com/repos/RxPHP/RxWebsocket/pulls{/number}","milestones_url":"https://api.github.com/repos/RxPHP/RxWebsocket/milestones{/number}","notifications_url":"https://api.github.com/repos/RxPHP/RxWebsocket/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RxPHP/RxWebsocket/labels{/name}","releases_url":"https://api.github.com/repos/RxPHP/RxWebsocket/releases{/id}","deployments_url":"https://api.github.com/repos/RxPHP/RxWebsocket/deployments","created_at":"2016-01-27T17:53:14Z","updated_at":"2017-09-11T19:15:54Z","pushed_at":"2017-09-13T20:56:22Z","git_url":"git://github.com/RxPHP/RxWebsocket.git","ssh_url":"git@github.com:RxPHP/RxWebsocket.git","clone_url":"https://github.com/RxPHP/RxWebsocket.git","svn_url":"https://github.com/RxPHP/RxWebsocket","homepage":"","size":57,"stargazers_count":19,"watchers_count":19,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":4,"forks":4,"open_issues":4,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RxPHP/RxWebsocket/pulls/14"},"html":{"href":"https://github.com/RxPHP/RxWebsocket/pull/14"},"issue":{"href":"https://api.github.com/repos/RxPHP/RxWebsocket/issues/14"},"comments":{"href":"https://api.github.com/repos/RxPHP/RxWebsocket/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/RxPHP/RxWebsocket/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/RxPHP/RxWebsocket/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RxPHP/RxWebsocket/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/RxPHP/RxWebsocket/statuses/14c6fc9f7c8ffabf10939d87ce15f56327cca143"}},"author_association":"OWNER"}}
{"actor":{"display_login":"davidwdan"}}