{"action":"created","comment":{"url":"https://api.github.com/repos/HumanCellAtlas/metadata-schema/pulls/comments/148732493","pull_request_review_id":74021484,"id":148732493,"diff_hunk":"@@ -23,8 +23,5 @@\n             \"description\": \"If sample was isolated in a well in plate (or fluidics chip), information about that\"\n         }\n      },\n-    \"title\" : \"cell_suspension\",\n-    \"required\":[\n-        \"sample_type\"\n-    ]\n+    \"title\" : \"cell_suspension\"","path":"json_schema/cell_suspension.json","position":8,"original_position":8,"commit_id":"01f6d182bab52cb72d1e5e1dcb6510e56f4e7a48","original_commit_id":"01f6d182bab52cb72d1e5e1dcb6510e56f4e7a48","user":{"login":"malloryfreeberg","id":10993501,"avatar_url":"https://avatars2.githubusercontent.com/u/10993501?v=4","gravatar_id":"","url":"https://api.github.com/users/malloryfreeberg","html_url":"https://github.com/malloryfreeberg","followers_url":"https://api.github.com/users/malloryfreeberg/followers","following_url":"https://api.github.com/users/malloryfreeberg/following{/other_user}","gists_url":"https://api.github.com/users/malloryfreeberg/gists{/gist_id}","starred_url":"https://api.github.com/users/malloryfreeberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/malloryfreeberg/subscriptions","organizations_url":"https://api.github.com/users/malloryfreeberg/orgs","repos_url":"https://api.github.com/users/malloryfreeberg/repos","events_url":"https://api.github.com/users/malloryfreeberg/events{/privacy}","received_events_url":"https://api.github.com/users/malloryfreeberg/received_events","type":"User","site_admin":false},"body":"Looks good.","created_at":"2017-11-03T09:07:02Z","updated_at":"2017-11-03T09:07:02Z","html_url":"https://github.com/HumanCellAtlas/metadata-schema/pull/60#discussion_r148732493","pull_request_url":"https://api.github.com/repos/HumanCellAtlas/metadata-schema/pulls/60","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/HumanCellAtlas/metadata-schema/pulls/comments/148732493"},"html":{"href":"https://github.com/HumanCellAtlas/metadata-schema/pull/60#discussion_r148732493"},"pull_request":{"href":"https://api.github.com/repos/HumanCellAtlas/metadata-schema/pulls/60"}}},"pull_request":{"url":"https://api.github.com/repos/HumanCellAtlas/metadata-schema/pulls/60","id":150402322,"html_url":"https://github.com/HumanCellAtlas/metadata-schema/pull/60","diff_url":"https://github.com/HumanCellAtlas/metadata-schema/pull/60.diff","patch_url":"https://github.com/HumanCellAtlas/metadata-schema/pull/60.patch","issue_url":"https://api.github.com/repos/HumanCellAtlas/metadata-schema/issues/60","number":60,"state":"open","locked":false,"title":"Cleanup","user":{"login":"simonjupp","id":385021,"avatar_url":"https://avatars3.githubusercontent.com/u/385021?v=4","gravatar_id":"","url":"https://api.github.com/users/simonjupp","html_url":"https://github.com/simonjupp","followers_url":"https://api.github.com/users/simonjupp/followers","following_url":"https://api.github.com/users/simonjupp/following{/other_user}","gists_url":"https://api.github.com/users/simonjupp/gists{/gist_id}","starred_url":"https://api.github.com/users/simonjupp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonjupp/subscriptions","organizations_url":"https://api.github.com/users/simonjupp/orgs","repos_url":"https://api.github.com/users/simonjupp/repos","events_url":"https://api.github.com/users/simonjupp/events{/privacy}","received_events_url":"https://api.github.com/users/simonjupp/received_events","type":"User","site_admin":false},"body":"I've done a full pass cleanup. \r\n\r\n- cleanup on required fields that were still type and id\r\n- consistent spelling of immortalized_cell_line (went with US)\r\n- removed type from sample subschemas (type is defined in core and sub type by property key)\r\n- removed donor_id from the donor.json and added generic derived_from in sample.json, this has a comment to make it clear it is a field for spreadsheets and used to link samples\r\n- updated all ingest and bundle schemas and examples files that all now validate ","created_at":"2017-11-02T20:58:23Z","updated_at":"2017-11-03T09:07:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aa918735883e823c98d3b92a8956bfeba3aaa1c6","assignee":null,"assignees":[],"requested_reviewers":[{"login":"dosumis","id":112839,"avatar_url":"https://avatars3.githubusercontent.com/u/112839?v=4","gravatar_id":"","url":"https://api.github.com/users/dosumis","html_url":"https://github.com/dosumis","followers_url":"https://api.github.com/users/dosumis/followers","following_url":"https://api.github.com/users/dosumis/following{/other_user}","gists_url":"https://api.github.com/users/dosumis/gists{/gist_id}","starred_url":"https://api.github.com/users/dosumis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dosumis/subscriptions","organizations_url":"https://api.github.com/users/dosumis/orgs","repos_url":"https://api.github.com/users/dosumis/repos","events_url":"https://api.github.com/users/dosumis/events{/privacy}","received_events_url":"https://api.github.com/users/dosumis/received_events","type":"User","site_admin":false},{"login":"daniwelter","id":1267974,"avatar_url":"https://avatars2.githubusercontent.com/u/1267974?v=4","gravatar_id":"","url":"https://api.github.com/users/daniwelter","html_url":"https://github.com/daniwelter","followers_url":"https://api.github.com/users/daniwelter/followers","following_url":"https://api.github.com/users/daniwelter/following{/other_user}","gists_url":"https://api.github.com/users/daniwelter/gists{/gist_id}","starred_url":"https://api.github.com/users/daniwelter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniwelter/subscriptions","organizations_url":"https://api.github.com/users/daniwelter/orgs","repos_url":"https://api.github.com/users/daniwelter/repos","events_url":"https://api.github.com/users/daniwelter/events{/privacy}","received_events_url":"https://api.github.com/users/daniwelter/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/HumanCellAtlas/metadata-schema/pulls/60/commits","review_comments_url":"https://api.github.com/repos/HumanCellAtlas/metadata-schema/pulls/60/comments","review_comment_url":"https://api.github.com/repos/HumanCellAtlas/metadata-schema/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HumanCellAtlas/metadata-schema/issues/60/comments","statuses_url":"https://api.github.com/repos/HumanCellAtlas/metadata-schema/statuses/01f6d182bab52cb72d1e5e1dcb6510e56f4e7a48","head":{"label":"simonjupp:core_relationships","ref":"core_relationships","sha":"01f6d182bab52cb72d1e5e1dcb6510e56f4e7a48","user":{"login":"simonjupp","id":385021,"avatar_url":"https://avatars3.githubusercontent.com/u/385021?v=4","gravatar_id":"","url":"https://api.github.com/users/simonjupp","html_url":"https://github.com/simonjupp","followers_url":"https://api.github.com/users/simonjupp/followers","following_url":"https://api.github.com/users/simonjupp/following{/other_user}","gists_url":"https://api.github.com/users/simonjupp/gists{/gist_id}","starred_url":"https://api.github.com/users/simonjupp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonjupp/subscriptions","organizations_url":"https://api.github.com/users/simonjupp/orgs","repos_url":"https://api.github.com/users/simonjupp/repos","events_url":"https://api.github.com/users/simonjupp/events{/privacy}","received_events_url":"https://api.github.com/users/simonjupp/received_events","type":"User","site_admin":false},"repo":{"id":109312618,"name":"metadata-schema","full_name":"simonjupp/metadata-schema","owner":{"login":"simonjupp","id":385021,"avatar_url":"https://avatars3.githubusercontent.com/u/385021?v=4","gravatar_id":"","url":"https://api.github.com/users/simonjupp","html_url":"https://github.com/simonjupp","followers_url":"https://api.github.com/users/simonjupp/followers","following_url":"https://api.github.com/users/simonjupp/following{/other_user}","gists_url":"https://api.github.com/users/simonjupp/gists{/gist_id}","starred_url":"https://api.github.com/users/simonjupp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonjupp/subscriptions","organizations_url":"https://api.github.com/users/simonjupp/orgs","repos_url":"https://api.github.com/users/simonjupp/repos","events_url":"https://api.github.com/users/simonjupp/events{/privacy}","received_events_url":"https://api.github.com/users/simonjupp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/simonjupp/metadata-schema","description":"This repo is for the metadata schemas associated with the HCA","fork":true,"url":"https://api.github.com/repos/simonjupp/metadata-schema","forks_url":"https://api.github.com/repos/simonjupp/metadata-schema/forks","keys_url":"https://api.github.com/repos/simonjupp/metadata-schema/keys{/key_id}","collaborators_url":"https://api.github.com/repos/simonjupp/metadata-schema/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/simonjupp/metadata-schema/teams","hooks_url":"https://api.github.com/repos/simonjupp/metadata-schema/hooks","issue_events_url":"https://api.github.com/repos/simonjupp/metadata-schema/issues/events{/number}","events_url":"https://api.github.com/repos/simonjupp/metadata-schema/events","assignees_url":"https://api.github.com/repos/simonjupp/metadata-schema/assignees{/user}","branches_url":"https://api.github.com/repos/simonjupp/metadata-schema/branches{/branch}","tags_url":"https://api.github.com/repos/simonjupp/metadata-schema/tags","blobs_url":"https://api.github.com/repos/simonjupp/metadata-schema/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/simonjupp/metadata-schema/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/simonjupp/metadata-schema/git/refs{/sha}","trees_url":"https://api.github.com/repos/simonjupp/metadata-schema/git/trees{/sha}","statuses_url":"https://api.github.com/repos/simonjupp/metadata-schema/statuses/{sha}","languages_url":"https://api.github.com/repos/simonjupp/metadata-schema/languages","stargazers_url":"https://api.github.com/repos/simonjupp/metadata-schema/stargazers","contributors_url":"https://api.github.com/repos/simonjupp/metadata-schema/contributors","subscribers_url":"https://api.github.com/repos/simonjupp/metadata-schema/subscribers","subscription_url":"https://api.github.com/repos/simonjupp/metadata-schema/subscription","commits_url":"https://api.github.com/repos/simonjupp/metadata-schema/commits{/sha}","git_commits_url":"https://api.github.com/repos/simonjupp/metadata-schema/git/commits{/sha}","comments_url":"https://api.github.com/repos/simonjupp/metadata-schema/comments{/number}","issue_comment_url":"https://api.github.com/repos/simonjupp/metadata-schema/issues/comments{/number}","contents_url":"https://api.github.com/repos/simonjupp/metadata-schema/contents/{+path}","compare_url":"https://api.github.com/repos/simonjupp/metadata-schema/compare/{base}...{head}","merges_url":"https://api.github.com/repos/simonjupp/metadata-schema/merges","archive_url":"https://api.github.com/repos/simonjupp/metadata-schema/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/simonjupp/metadata-schema/downloads","issues_url":"https://api.github.com/repos/simonjupp/metadata-schema/issues{/number}","pulls_url":"https://api.github.com/repos/simonjupp/metadata-schema/pulls{/number}","milestones_url":"https://api.github.com/repos/simonjupp/metadata-schema/milestones{/number}","notifications_url":"https://api.github.com/repos/simonjupp/metadata-schema/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/simonjupp/metadata-schema/labels{/name}","releases_url":"https://api.github.com/repos/simonjupp/metadata-schema/releases{/id}","deployments_url":"https://api.github.com/repos/simonjupp/metadata-schema/deployments","created_at":"2017-11-02T19:58:22Z","updated_at":"2017-11-01T20:14:37Z","pushed_at":"2017-11-03T09:05:48Z","git_url":"git://github.com/simonjupp/metadata-schema.git","ssh_url":"git@github.com:simonjupp/metadata-schema.git","clone_url":"https://github.com/simonjupp/metadata-schema.git","svn_url":"https://github.com/simonjupp/metadata-schema","homepage":null,"size":722,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"HumanCellAtlas:version_4","ref":"version_4","sha":"fe941a7f1fbc0f43e9cf2221507301fb36d57ae1","user":{"login":"HumanCellAtlas","id":26391798,"avatar_url":"https://avatars1.githubusercontent.com/u/26391798?v=4","gravatar_id":"","url":"https://api.github.com/users/HumanCellAtlas","html_url":"https://github.com/HumanCellAtlas","followers_url":"https://api.github.com/users/HumanCellAtlas/followers","following_url":"https://api.github.com/users/HumanCellAtlas/following{/other_user}","gists_url":"https://api.github.com/users/HumanCellAtlas/gists{/gist_id}","starred_url":"https://api.github.com/users/HumanCellAtlas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HumanCellAtlas/subscriptions","organizations_url":"https://api.github.com/users/HumanCellAtlas/orgs","repos_url":"https://api.github.com/users/HumanCellAtlas/repos","events_url":"https://api.github.com/users/HumanCellAtlas/events{/privacy}","received_events_url":"https://api.github.com/users/HumanCellAtlas/received_events","type":"Organization","site_admin":false},"repo":{"id":102351002,"name":"metadata-schema","full_name":"HumanCellAtlas/metadata-schema","owner":{"login":"HumanCellAtlas","id":26391798,"avatar_url":"https://avatars1.githubusercontent.com/u/26391798?v=4","gravatar_id":"","url":"https://api.github.com/users/HumanCellAtlas","html_url":"https://github.com/HumanCellAtlas","followers_url":"https://api.github.com/users/HumanCellAtlas/followers","following_url":"https://api.github.com/users/HumanCellAtlas/following{/other_user}","gists_url":"https://api.github.com/users/HumanCellAtlas/gists{/gist_id}","starred_url":"https://api.github.com/users/HumanCellAtlas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HumanCellAtlas/subscriptions","organizations_url":"https://api.github.com/users/HumanCellAtlas/orgs","repos_url":"https://api.github.com/users/HumanCellAtlas/repos","events_url":"https://api.github.com/users/HumanCellAtlas/events{/privacy}","received_events_url":"https://api.github.com/users/HumanCellAtlas/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HumanCellAtlas/metadata-schema","description":"This repo is for the metadata schemas associated with the HCA","fork":false,"url":"https://api.github.com/repos/HumanCellAtlas/metadata-schema","forks_url":"https://api.github.com/repos/HumanCellAtlas/metadata-schema/forks","keys_url":"https://api.github.com/repos/HumanCellAtlas/metadata-schema/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HumanCellAtlas/metadata-schema/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HumanCellAtlas/metadata-schema/teams","hooks_url":"https://api.github.com/repos/HumanCellAtlas/metadata-schema/hooks","issue_events_url":"https://api.github.com/repos/HumanCellAtlas/metadata-schema/issues/events{/number}","events_url":"https://api.github.com/repos/HumanCellAtlas/metadata-schema/events","assignees_url":"https://api.github.com/repos/HumanCellAtlas/metadata-schema/assignees{/user}","branches_url":"https://api.github.com/repos/HumanCellAtlas/metadata-schema/branches{/branch}","tags_url":"https://api.github.com/repos/HumanCellAtlas/metadata-schema/tags","blobs_url":"https://api.github.com/repos/HumanCellAtlas/metadata-schema/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HumanCellAtlas/metadata-schema/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HumanCellAtlas/metadata-schema/git/refs{/sha}","trees_url":"https://api.github.com/repos/HumanCellAtlas/metadata-schema/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HumanCellAtlas/metadata-schema/statuses/{sha}","languages_url":"https://api.github.com/repos/HumanCellAtlas/metadata-schema/languages","stargazers_url":"https://api.github.com/repos/HumanCellAtlas/metadata-schema/stargazers","contributors_url":"https://api.github.com/repos/HumanCellAtlas/metadata-schema/contributors","subscribers_url":"https://api.github.com/repos/HumanCellAtlas/metadata-schema/subscribers","subscription_url":"https://api.github.com/repos/HumanCellAtlas/metadata-schema/subscription","commits_url":"https://api.github.com/repos/HumanCellAtlas/metadata-schema/commits{/sha}","git_commits_url":"https://api.github.com/repos/HumanCellAtlas/metadata-schema/git/commits{/sha}","comments_url":"https://api.github.com/repos/HumanCellAtlas/metadata-schema/comments{/number}","issue_comment_url":"https://api.github.com/repos/HumanCellAtlas/metadata-schema/issues/comments{/number}","contents_url":"https://api.github.com/repos/HumanCellAtlas/metadata-schema/contents/{+path}","compare_url":"https://api.github.com/repos/HumanCellAtlas/metadata-schema/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HumanCellAtlas/metadata-schema/merges","archive_url":"https://api.github.com/repos/HumanCellAtlas/metadata-schema/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HumanCellAtlas/metadata-schema/downloads","issues_url":"https://api.github.com/repos/HumanCellAtlas/metadata-schema/issues{/number}","pulls_url":"https://api.github.com/repos/HumanCellAtlas/metadata-schema/pulls{/number}","milestones_url":"https://api.github.com/repos/HumanCellAtlas/metadata-schema/milestones{/number}","notifications_url":"https://api.github.com/repos/HumanCellAtlas/metadata-schema/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HumanCellAtlas/metadata-schema/labels{/name}","releases_url":"https://api.github.com/repos/HumanCellAtlas/metadata-schema/releases{/id}","deployments_url":"https://api.github.com/repos/HumanCellAtlas/metadata-schema/deployments","created_at":"2017-09-04T10:48:45Z","updated_at":"2017-11-01T20:14:37Z","pushed_at":"2017-11-03T09:05:49Z","git_url":"git://github.com/HumanCellAtlas/metadata-schema.git","ssh_url":"git@github.com:HumanCellAtlas/metadata-schema.git","clone_url":"https://github.com/HumanCellAtlas/metadata-schema.git","svn_url":"https://github.com/HumanCellAtlas/metadata-schema","homepage":null,"size":717,"stargazers_count":3,"watchers_count":3,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":40,"forks":4,"open_issues":40,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/HumanCellAtlas/metadata-schema/pulls/60"},"html":{"href":"https://github.com/HumanCellAtlas/metadata-schema/pull/60"},"issue":{"href":"https://api.github.com/repos/HumanCellAtlas/metadata-schema/issues/60"},"comments":{"href":"https://api.github.com/repos/HumanCellAtlas/metadata-schema/issues/60/comments"},"review_comments":{"href":"https://api.github.com/repos/HumanCellAtlas/metadata-schema/pulls/60/comments"},"review_comment":{"href":"https://api.github.com/repos/HumanCellAtlas/metadata-schema/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HumanCellAtlas/metadata-schema/pulls/60/commits"},"statuses":{"href":"https://api.github.com/repos/HumanCellAtlas/metadata-schema/statuses/01f6d182bab52cb72d1e5e1dcb6510e56f4e7a48"}},"author_association":"NONE"}}
{"actor":{"display_login":"malloryfreeberg"}}