{"action":"created","comment":{"url":"https://api.github.com/repos/vmware/clarity/pulls/comments/114152046","pull_request_review_id":35595331,"id":114152046,"diff_hunk":"@@ -0,0 +1,306 @@\n+/*\n+ * Copyright (c) 2016-2017 VMware, Inc. All Rights Reserved.\n+ * This software is released under MIT license.\n+ * The full license information can be found in LICENSE in the root directory of this project.\n+ */\n+import { Component, QueryList, TemplateRef, ViewChildren } from \"@angular/core\";\n+import { TestContext } from \"./helpers.spec\";\n+import { HideableColumnService } from \"./providers/hideable-column.service\";\n+import { DatagridColumnToggle } from \"./datagrid-column-toggle\";\n+import { DatagridHideableColumn } from \"./datagrid-hideable-column\";\n+\n+export default function (): void {\n+    describe(\"Datagrid Column Toggle component\", function () {\n+        describe(\"Typescript API\", function () {","path":"src/clarity-angular/datagrid/datagrid-column-toggle.spec.ts","position":14,"original_position":14,"commit_id":"904c12039ecb811626b947fedc3fe3507d5311a4","original_commit_id":"f0188205ea27e4f3660162d7f1f60e1edd8536b4","user":{"login":"hippee-lee","id":433692,"avatar_url":"https://avatars2.githubusercontent.com/u/433692?v=3","gravatar_id":"","url":"https://api.github.com/users/hippee-lee","html_url":"https://github.com/hippee-lee","followers_url":"https://api.github.com/users/hippee-lee/followers","following_url":"https://api.github.com/users/hippee-lee/following{/other_user}","gists_url":"https://api.github.com/users/hippee-lee/gists{/gist_id}","starred_url":"https://api.github.com/users/hippee-lee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hippee-lee/subscriptions","organizations_url":"https://api.github.com/users/hippee-lee/orgs","repos_url":"https://api.github.com/users/hippee-lee/repos","events_url":"https://api.github.com/users/hippee-lee/events{/privacy}","received_events_url":"https://api.github.com/users/hippee-lee/received_events","type":"User","site_admin":false},"body":"Ah, yes, thats using `*ngIf` so the cells are destroyed and recreated. This is still there so I can make sure it works but isn;t part of the feature set to be documented. I'm not sure if it will be a recommended pattern yet either. ","created_at":"2017-05-01T16:40:51Z","updated_at":"2017-05-01T16:40:51Z","html_url":"https://github.com/vmware/clarity/pull/798#discussion_r114152046","pull_request_url":"https://api.github.com/repos/vmware/clarity/pulls/798","_links":{"self":{"href":"https://api.github.com/repos/vmware/clarity/pulls/comments/114152046"},"html":{"href":"https://github.com/vmware/clarity/pull/798#discussion_r114152046"},"pull_request":{"href":"https://api.github.com/repos/vmware/clarity/pulls/798"}}},"pull_request":{"url":"https://api.github.com/repos/vmware/clarity/pulls/798","id":117772110,"html_url":"https://github.com/vmware/clarity/pull/798","diff_url":"https://github.com/vmware/clarity/pull/798.diff","patch_url":"https://github.com/vmware/clarity/pull/798.patch","issue_url":"https://api.github.com/repos/vmware/clarity/issues/798","number":798,"state":"open","locked":false,"title":"[NG] Adds Hide/Unhide capability for columns in Datagrid","user":{"login":"hippee-lee","id":433692,"avatar_url":"https://avatars2.githubusercontent.com/u/433692?v=3","gravatar_id":"","url":"https://api.github.com/users/hippee-lee","html_url":"https://github.com/hippee-lee","followers_url":"https://api.github.com/users/hippee-lee/followers","following_url":"https://api.github.com/users/hippee-lee/following{/other_user}","gists_url":"https://api.github.com/users/hippee-lee/gists{/gist_id}","starred_url":"https://api.github.com/users/hippee-lee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hippee-lee/subscriptions","organizations_url":"https://api.github.com/users/hippee-lee/orgs","repos_url":"https://api.github.com/users/hippee-lee/repos","events_url":"https://api.github.com/users/hippee-lee/events{/privacy}","received_events_url":"https://api.github.com/users/hippee-lee/received_events","type":"User","site_admin":false},"body":"- implements show/hide behavior for both columns and cells\r\n- reuses column templates in the toggle component\r\n- (conditionally) adds the toggle widget to the footer when hideable columns are present\r\n- add the `*clrDgHideableColumn` directive\r\n- closes #401 \r\n\r\nTested in: Chrome, IE11, Edge, Safari & Firefox\r\n\r\n## Toggle UI\r\n<img width=\"1153\" alt=\"hide-show-ui\" src=\"https://cloud.githubusercontent.com/assets/433692/25448411/37666432-2a6d-11e7-89a4-f8cec414e905.png\">\r\n\r\n## Select All is disabled when they are all selected\r\n<img width=\"1166\" alt=\"hide-show-select-all-disabled\" src=\"https://cloud.githubusercontent.com/assets/433692/25448433/50bffd94-2a6d-11e7-8950-e1bb88d4bd19.png\">\r\n\r\n## Last showing column is disabled\r\n<img width=\"1159\" alt=\"hide-show-last-col-disabled\" src=\"https://cloud.githubusercontent.com/assets/433692/25448450/5f75d584-2a6d-11e7-9d6c-13c9f5b9a0d3.png\">\r\n\r\n## Hideable Columns (and Cells) can be used with `*ngIf`\r\n<img width=\"1168\" alt=\"hide-show-no-id-date\" src=\"https://cloud.githubusercontent.com/assets/433692/25448484/7b1f1980-2a6d-11e7-9624-fcb4c18ff3fb.png\">\r\n\r\n\r\nSigned-off-by: Matt Hippely <mhippely@vmware.com>","created_at":"2017-04-26T17:47:40Z","updated_at":"2017-05-01T16:40:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6051e49d6a7e40513b5a4b57a7d1222f074c8692","assignee":{"login":"hippee-lee","id":433692,"avatar_url":"https://avatars2.githubusercontent.com/u/433692?v=3","gravatar_id":"","url":"https://api.github.com/users/hippee-lee","html_url":"https://github.com/hippee-lee","followers_url":"https://api.github.com/users/hippee-lee/followers","following_url":"https://api.github.com/users/hippee-lee/following{/other_user}","gists_url":"https://api.github.com/users/hippee-lee/gists{/gist_id}","starred_url":"https://api.github.com/users/hippee-lee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hippee-lee/subscriptions","organizations_url":"https://api.github.com/users/hippee-lee/orgs","repos_url":"https://api.github.com/users/hippee-lee/repos","events_url":"https://api.github.com/users/hippee-lee/events{/privacy}","received_events_url":"https://api.github.com/users/hippee-lee/received_events","type":"User","site_admin":false},"assignees":[{"login":"hippee-lee","id":433692,"avatar_url":"https://avatars2.githubusercontent.com/u/433692?v=3","gravatar_id":"","url":"https://api.github.com/users/hippee-lee","html_url":"https://github.com/hippee-lee","followers_url":"https://api.github.com/users/hippee-lee/followers","following_url":"https://api.github.com/users/hippee-lee/following{/other_user}","gists_url":"https://api.github.com/users/hippee-lee/gists{/gist_id}","starred_url":"https://api.github.com/users/hippee-lee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hippee-lee/subscriptions","organizations_url":"https://api.github.com/users/hippee-lee/orgs","repos_url":"https://api.github.com/users/hippee-lee/repos","events_url":"https://api.github.com/users/hippee-lee/events{/privacy}","received_events_url":"https://api.github.com/users/hippee-lee/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/vmware/clarity/milestones/31","html_url":"https://github.com/vmware/clarity/milestone/31","labels_url":"https://api.github.com/repos/vmware/clarity/milestones/31/labels","id":2477462,"number":31,"title":"0.9.3","description":"","creator":{"login":"mathisscott","id":2728359,"avatar_url":"https://avatars0.githubusercontent.com/u/2728359?v=3","gravatar_id":"","url":"https://api.github.com/users/mathisscott","html_url":"https://github.com/mathisscott","followers_url":"https://api.github.com/users/mathisscott/followers","following_url":"https://api.github.com/users/mathisscott/following{/other_user}","gists_url":"https://api.github.com/users/mathisscott/gists{/gist_id}","starred_url":"https://api.github.com/users/mathisscott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mathisscott/subscriptions","organizations_url":"https://api.github.com/users/mathisscott/orgs","repos_url":"https://api.github.com/users/mathisscott/repos","events_url":"https://api.github.com/users/mathisscott/events{/privacy}","received_events_url":"https://api.github.com/users/mathisscott/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":1,"state":"open","created_at":"2017-04-24T15:46:25Z","updated_at":"2017-05-01T14:27:39Z","due_on":"2017-05-05T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/vmware/clarity/pulls/798/commits","review_comments_url":"https://api.github.com/repos/vmware/clarity/pulls/798/comments","review_comment_url":"https://api.github.com/repos/vmware/clarity/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vmware/clarity/issues/798/comments","statuses_url":"https://api.github.com/repos/vmware/clarity/statuses/904c12039ecb811626b947fedc3fe3507d5311a4","head":{"label":"hippee-lee:issue/401-hide-show-dg-columns","ref":"issue/401-hide-show-dg-columns","sha":"904c12039ecb811626b947fedc3fe3507d5311a4","user":{"login":"hippee-lee","id":433692,"avatar_url":"https://avatars2.githubusercontent.com/u/433692?v=3","gravatar_id":"","url":"https://api.github.com/users/hippee-lee","html_url":"https://github.com/hippee-lee","followers_url":"https://api.github.com/users/hippee-lee/followers","following_url":"https://api.github.com/users/hippee-lee/following{/other_user}","gists_url":"https://api.github.com/users/hippee-lee/gists{/gist_id}","starred_url":"https://api.github.com/users/hippee-lee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hippee-lee/subscriptions","organizations_url":"https://api.github.com/users/hippee-lee/orgs","repos_url":"https://api.github.com/users/hippee-lee/repos","events_url":"https://api.github.com/users/hippee-lee/events{/privacy}","received_events_url":"https://api.github.com/users/hippee-lee/received_events","type":"User","site_admin":false},"repo":{"id":73741967,"name":"clarity","full_name":"hippee-lee/clarity","owner":{"login":"hippee-lee","id":433692,"avatar_url":"https://avatars2.githubusercontent.com/u/433692?v=3","gravatar_id":"","url":"https://api.github.com/users/hippee-lee","html_url":"https://github.com/hippee-lee","followers_url":"https://api.github.com/users/hippee-lee/followers","following_url":"https://api.github.com/users/hippee-lee/following{/other_user}","gists_url":"https://api.github.com/users/hippee-lee/gists{/gist_id}","starred_url":"https://api.github.com/users/hippee-lee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hippee-lee/subscriptions","organizations_url":"https://api.github.com/users/hippee-lee/orgs","repos_url":"https://api.github.com/users/hippee-lee/repos","events_url":"https://api.github.com/users/hippee-lee/events{/privacy}","received_events_url":"https://api.github.com/users/hippee-lee/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hippee-lee/clarity","description":"Clarity Design System: UX guidelines, HTML/CSS framework, and Angular 2 components working together to craft exceptional experiences","fork":true,"url":"https://api.github.com/repos/hippee-lee/clarity","forks_url":"https://api.github.com/repos/hippee-lee/clarity/forks","keys_url":"https://api.github.com/repos/hippee-lee/clarity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hippee-lee/clarity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hippee-lee/clarity/teams","hooks_url":"https://api.github.com/repos/hippee-lee/clarity/hooks","issue_events_url":"https://api.github.com/repos/hippee-lee/clarity/issues/events{/number}","events_url":"https://api.github.com/repos/hippee-lee/clarity/events","assignees_url":"https://api.github.com/repos/hippee-lee/clarity/assignees{/user}","branches_url":"https://api.github.com/repos/hippee-lee/clarity/branches{/branch}","tags_url":"https://api.github.com/repos/hippee-lee/clarity/tags","blobs_url":"https://api.github.com/repos/hippee-lee/clarity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hippee-lee/clarity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hippee-lee/clarity/git/refs{/sha}","trees_url":"https://api.github.com/repos/hippee-lee/clarity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hippee-lee/clarity/statuses/{sha}","languages_url":"https://api.github.com/repos/hippee-lee/clarity/languages","stargazers_url":"https://api.github.com/repos/hippee-lee/clarity/stargazers","contributors_url":"https://api.github.com/repos/hippee-lee/clarity/contributors","subscribers_url":"https://api.github.com/repos/hippee-lee/clarity/subscribers","subscription_url":"https://api.github.com/repos/hippee-lee/clarity/subscription","commits_url":"https://api.github.com/repos/hippee-lee/clarity/commits{/sha}","git_commits_url":"https://api.github.com/repos/hippee-lee/clarity/git/commits{/sha}","comments_url":"https://api.github.com/repos/hippee-lee/clarity/comments{/number}","issue_comment_url":"https://api.github.com/repos/hippee-lee/clarity/issues/comments{/number}","contents_url":"https://api.github.com/repos/hippee-lee/clarity/contents/{+path}","compare_url":"https://api.github.com/repos/hippee-lee/clarity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hippee-lee/clarity/merges","archive_url":"https://api.github.com/repos/hippee-lee/clarity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hippee-lee/clarity/downloads","issues_url":"https://api.github.com/repos/hippee-lee/clarity/issues{/number}","pulls_url":"https://api.github.com/repos/hippee-lee/clarity/pulls{/number}","milestones_url":"https://api.github.com/repos/hippee-lee/clarity/milestones{/number}","notifications_url":"https://api.github.com/repos/hippee-lee/clarity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hippee-lee/clarity/labels{/name}","releases_url":"https://api.github.com/repos/hippee-lee/clarity/releases{/id}","deployments_url":"https://api.github.com/repos/hippee-lee/clarity/deployments","created_at":"2016-11-14T19:57:54Z","updated_at":"2017-03-02T20:18:48Z","pushed_at":"2017-04-29T01:24:32Z","git_url":"git://github.com/hippee-lee/clarity.git","ssh_url":"git@github.com:hippee-lee/clarity.git","clone_url":"https://github.com/hippee-lee/clarity.git","svn_url":"https://github.com/hippee-lee/clarity","homepage":"https://vmware.github.io/clarity/","size":77067,"stargazers_count":1,"watchers_count":1,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"vmware:master","ref":"master","sha":"fa7fdd999fea132a6e509c277f4d978e323440db","user":{"login":"vmware","id":473334,"avatar_url":"https://avatars3.githubusercontent.com/u/473334?v=3","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"repo":{"id":69590701,"name":"clarity","full_name":"vmware/clarity","owner":{"login":"vmware","id":473334,"avatar_url":"https://avatars3.githubusercontent.com/u/473334?v=3","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vmware/clarity","description":"Clarity Design System: UX guidelines, HTML/CSS framework, and Angular 2 components working together to craft exceptional experiences","fork":false,"url":"https://api.github.com/repos/vmware/clarity","forks_url":"https://api.github.com/repos/vmware/clarity/forks","keys_url":"https://api.github.com/repos/vmware/clarity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vmware/clarity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vmware/clarity/teams","hooks_url":"https://api.github.com/repos/vmware/clarity/hooks","issue_events_url":"https://api.github.com/repos/vmware/clarity/issues/events{/number}","events_url":"https://api.github.com/repos/vmware/clarity/events","assignees_url":"https://api.github.com/repos/vmware/clarity/assignees{/user}","branches_url":"https://api.github.com/repos/vmware/clarity/branches{/branch}","tags_url":"https://api.github.com/repos/vmware/clarity/tags","blobs_url":"https://api.github.com/repos/vmware/clarity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vmware/clarity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vmware/clarity/git/refs{/sha}","trees_url":"https://api.github.com/repos/vmware/clarity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vmware/clarity/statuses/{sha}","languages_url":"https://api.github.com/repos/vmware/clarity/languages","stargazers_url":"https://api.github.com/repos/vmware/clarity/stargazers","contributors_url":"https://api.github.com/repos/vmware/clarity/contributors","subscribers_url":"https://api.github.com/repos/vmware/clarity/subscribers","subscription_url":"https://api.github.com/repos/vmware/clarity/subscription","commits_url":"https://api.github.com/repos/vmware/clarity/commits{/sha}","git_commits_url":"https://api.github.com/repos/vmware/clarity/git/commits{/sha}","comments_url":"https://api.github.com/repos/vmware/clarity/comments{/number}","issue_comment_url":"https://api.github.com/repos/vmware/clarity/issues/comments{/number}","contents_url":"https://api.github.com/repos/vmware/clarity/contents/{+path}","compare_url":"https://api.github.com/repos/vmware/clarity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vmware/clarity/merges","archive_url":"https://api.github.com/repos/vmware/clarity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vmware/clarity/downloads","issues_url":"https://api.github.com/repos/vmware/clarity/issues{/number}","pulls_url":"https://api.github.com/repos/vmware/clarity/pulls{/number}","milestones_url":"https://api.github.com/repos/vmware/clarity/milestones{/number}","notifications_url":"https://api.github.com/repos/vmware/clarity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vmware/clarity/labels{/name}","releases_url":"https://api.github.com/repos/vmware/clarity/releases{/id}","deployments_url":"https://api.github.com/repos/vmware/clarity/deployments","created_at":"2016-09-29T17:24:17Z","updated_at":"2017-04-30T21:59:19Z","pushed_at":"2017-05-01T14:27:34Z","git_url":"git://github.com/vmware/clarity.git","ssh_url":"git@github.com:vmware/clarity.git","clone_url":"https://github.com/vmware/clarity.git","svn_url":"https://github.com/vmware/clarity","homepage":"https://vmware.github.io/clarity/","size":94039,"stargazers_count":1323,"watchers_count":1323,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":128,"mirror_url":null,"open_issues_count":131,"forks":128,"open_issues":131,"watchers":1323,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vmware/clarity/pulls/798"},"html":{"href":"https://github.com/vmware/clarity/pull/798"},"issue":{"href":"https://api.github.com/repos/vmware/clarity/issues/798"},"comments":{"href":"https://api.github.com/repos/vmware/clarity/issues/798/comments"},"review_comments":{"href":"https://api.github.com/repos/vmware/clarity/pulls/798/comments"},"review_comment":{"href":"https://api.github.com/repos/vmware/clarity/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vmware/clarity/pulls/798/commits"},"statuses":{"href":"https://api.github.com/repos/vmware/clarity/statuses/904c12039ecb811626b947fedc3fe3507d5311a4"}}}}
{"actor":{"display_login":"hippee-lee"}}