{"action":"created","issue":{"url":"https://api.github.com/repos/artsy/emission/issues/857","repository_url":"https://api.github.com/repos/artsy/emission","labels_url":"https://api.github.com/repos/artsy/emission/issues/857/labels{/name}","comments_url":"https://api.github.com/repos/artsy/emission/issues/857/comments","events_url":"https://api.github.com/repos/artsy/emission/issues/857/events","html_url":"https://github.com/artsy/emission/pull/857","id":278157366,"number":857,"title":"[inbox] fix for inbox pull-to-refresh","user":{"login":"sarahscott","id":2712962,"avatar_url":"https://avatars3.githubusercontent.com/u/2712962?v=4","gravatar_id":"","url":"https://api.github.com/users/sarahscott","html_url":"https://github.com/sarahscott","followers_url":"https://api.github.com/users/sarahscott/followers","following_url":"https://api.github.com/users/sarahscott/following{/other_user}","gists_url":"https://api.github.com/users/sarahscott/gists{/gist_id}","starred_url":"https://api.github.com/users/sarahscott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarahscott/subscriptions","organizations_url":"https://api.github.com/users/sarahscott/orgs","repos_url":"https://api.github.com/users/sarahscott/repos","events_url":"https://api.github.com/users/sarahscott/events{/privacy}","received_events_url":"https://api.github.com/users/sarahscott/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"alloy","id":2320,"avatar_url":"https://avatars2.githubusercontent.com/u/2320?v=4","gravatar_id":"","url":"https://api.github.com/users/alloy","html_url":"https://github.com/alloy","followers_url":"https://api.github.com/users/alloy/followers","following_url":"https://api.github.com/users/alloy/following{/other_user}","gists_url":"https://api.github.com/users/alloy/gists{/gist_id}","starred_url":"https://api.github.com/users/alloy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alloy/subscriptions","organizations_url":"https://api.github.com/users/alloy/orgs","repos_url":"https://api.github.com/users/alloy/repos","events_url":"https://api.github.com/users/alloy/events{/privacy}","received_events_url":"https://api.github.com/users/alloy/received_events","type":"User","site_admin":false},"assignees":[{"login":"alloy","id":2320,"avatar_url":"https://avatars2.githubusercontent.com/u/2320?v=4","gravatar_id":"","url":"https://api.github.com/users/alloy","html_url":"https://github.com/alloy","followers_url":"https://api.github.com/users/alloy/followers","following_url":"https://api.github.com/users/alloy/following{/other_user}","gists_url":"https://api.github.com/users/alloy/gists{/gist_id}","starred_url":"https://api.github.com/users/alloy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alloy/subscriptions","organizations_url":"https://api.github.com/users/alloy/orgs","repos_url":"https://api.github.com/users/alloy/repos","events_url":"https://api.github.com/users/alloy/events{/privacy}","received_events_url":"https://api.github.com/users/alloy/received_events","type":"User","site_admin":false},{"login":"l2succes","id":296775,"avatar_url":"https://avatars0.githubusercontent.com/u/296775?v=4","gravatar_id":"","url":"https://api.github.com/users/l2succes","html_url":"https://github.com/l2succes","followers_url":"https://api.github.com/users/l2succes/followers","following_url":"https://api.github.com/users/l2succes/following{/other_user}","gists_url":"https://api.github.com/users/l2succes/gists{/gist_id}","starred_url":"https://api.github.com/users/l2succes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/l2succes/subscriptions","organizations_url":"https://api.github.com/users/l2succes/orgs","repos_url":"https://api.github.com/users/l2succes/repos","events_url":"https://api.github.com/users/l2succes/events{/privacy}","received_events_url":"https://api.github.com/users/l2succes/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2017-11-30T15:17:33Z","updated_at":"2017-12-04T15:30:19Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/artsy/emission/pulls/857","html_url":"https://github.com/artsy/emission/pull/857","diff_url":"https://github.com/artsy/emission/pull/857.diff","patch_url":"https://github.com/artsy/emission/pull/857.patch"},"body":"- [x] Refresh conversations\r\n- [x] Refresh active bids\r\n\r\nAs a `RefetchContainer`, the `Inbox` can properly update its Active Bids with the force fetch method [outlined in the Relay Modern docs](https://facebook.github.io/relay/docs/en/api-cheatsheet.html#to-force-fetch-a-component). However, when it tries to update its child `Conversations` container, we get an error related to pagination because `Conversations` is a `PaginationContainer` and [maintains its own cursor](https://github.com/artsy/emission/blob/master/src/lib/Components/Inbox/Conversations/index.tsx#L125).\r\n\r\nI got around this by making a `refreshConversations` method that the `Inbox` can call upon pull-to-refresh. The active bids can be updated with the normal force fetch, although this generates a warning in the simulator. \r\n\r\nHere's a gif of both conversations and active bids properly updating:\r\n\r\n![refresh](https://user-images.githubusercontent.com/2712962/33554967-ff811e68-d8fe-11e7-9972-8b5670dae6e4.gif)\r\n\r\nSkip New Tests"},"comment":{"url":"https://api.github.com/repos/artsy/emission/issues/comments/348996625","html_url":"https://github.com/artsy/emission/pull/857#issuecomment-348996625","issue_url":"https://api.github.com/repos/artsy/emission/issues/857","id":348996625,"user":{"login":"ArtsyOpenSource","id":12397828,"avatar_url":"https://avatars2.githubusercontent.com/u/12397828?v=4","gravatar_id":"","url":"https://api.github.com/users/ArtsyOpenSource","html_url":"https://github.com/ArtsyOpenSource","followers_url":"https://api.github.com/users/ArtsyOpenSource/followers","following_url":"https://api.github.com/users/ArtsyOpenSource/following{/other_user}","gists_url":"https://api.github.com/users/ArtsyOpenSource/gists{/gist_id}","starred_url":"https://api.github.com/users/ArtsyOpenSource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArtsyOpenSource/subscriptions","organizations_url":"https://api.github.com/users/ArtsyOpenSource/orgs","repos_url":"https://api.github.com/users/ArtsyOpenSource/repos","events_url":"https://api.github.com/users/ArtsyOpenSource/events{/privacy}","received_events_url":"https://api.github.com/users/ArtsyOpenSource/received_events","type":"User","site_admin":false},"created_at":"2017-12-04T15:30:19Z","updated_at":"2017-12-04T15:30:19Z","author_association":"NONE","body":"\n<!--\n  0 failure: \n  1 warning:  Missing Test File...\n  \n  \n-->\n\n\n<table>\n  <thead>\n    <tr>\n      <th width=\"50\"></th>\n      <th width=\"100%\" data-danger-table=\"true\">Warnings</th>\n    </tr>\n  </thead>\n  <tbody><tr>\n      <td>:warning:</td>\n      <td>\n\n  Missing Test Files:\n\n- `src/lib/Components/Inbox/Conversations/__tests__/index-tests.tsx`\n\nIf these files are supposed to not exist, please update your PR body to include \"Skip New Tests\".\n  </td>\n    </tr>\n  </tbody>\n</table>\n\n\n\n<p align=\"right\">\n  Generated by :no_entry_sign: <a href=\"http://github.com/danger/danger-js/\">dangerJS</a>\n</p>\n"}}
{"actor":{"display_login":"ArtsyOpenSource"}}