{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/133006474","pull_request_review_id":56141145,"id":133006474,"diff_hunk":"@@ -198,10 +198,77 @@ func TestBatchWebhookStopCh(t *testing.T) {\n \t\twaitForEmptyBuffer(backend)\n \t\tclose(stopCh) // stop channel has stopped\n \t}()\n-\tbackend.sendBatchEvents(stopCh, timer)\n+\tbackend.sendBatchEvents(backend.collectEvents(stopCh, timer))\n \trequire.Equal(t, expected, <-got, \"get queued events after timer expires\")\n }\n \n+func TestBatchWebhookProcessEventsAfterStop(t *testing.T) {\n+\tevents := make([]*auditinternal.Event, 1) // less than max size.\n+\tfor i := range events {\n+\t\tevents[i] = &auditinternal.Event{}\n+\t}\n+\n+\tgot := make(chan struct{})\n+\ts := httptest.NewServer(newWebhookHandler(t, func(events *auditv1alpha1.EventList) {\n+\t\tclose(got)\n+\t}))\n+\tdefer s.Close()\n+\n+\tbackend := newTestBatchWebhook(t, s.URL)\n+\tstopCh := make(chan struct{})\n+\n+\tbackend.Run(stopCh)\n+\tclose(stopCh)\n+\t<-backend.shutdownCh\n+\tbackend.ProcessEvents(events...)\n+\tassert.Equal(t, 0, len(backend.buffer), \"processed events after the backed has been stopped\")\n+}\n+\n+func TestBatchWebhookShutdown(t *testing.T) {\n+\tevents := make([]*auditinternal.Event, 1)\n+\tfor i := range events {\n+\t\tevents[i] = &auditinternal.Event{}\n+\t}\n+\n+\tgot := make(chan struct{})\n+\tcontReqCh := make(chan struct{})\n+\tshutdownCh := make(chan struct{})\n+\ts := httptest.NewServer(newWebhookHandler(t, func(events *auditv1alpha1.EventList) {\n+\t\tclose(got)\n+\t\t<-contReqCh\n+\t}))\n+\tdefer s.Close()\n+\n+\tbackend := newTestBatchWebhook(t, s.URL)\n+\tbackend.ProcessEvents(events...)\n+\n+\tgo func() {\n+\t\t// Assume stopCh was closed.","path":"staging/src/k8s.io/apiserver/plugin/pkg/audit/webhook/webhook_test.go","position":68,"original_position":68,"commit_id":"697ba1e405dcdf698c1a80dca43bccb1cd85e774","original_commit_id":"e249e02f7864b244bb43483342e0e9b210b5d672","user":{"login":"crassirostris","id":1756505,"avatar_url":"https://avatars1.githubusercontent.com/u/1756505?v=4","gravatar_id":"","url":"https://api.github.com/users/crassirostris","html_url":"https://github.com/crassirostris","followers_url":"https://api.github.com/users/crassirostris/followers","following_url":"https://api.github.com/users/crassirostris/following{/other_user}","gists_url":"https://api.github.com/users/crassirostris/gists{/gist_id}","starred_url":"https://api.github.com/users/crassirostris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crassirostris/subscriptions","organizations_url":"https://api.github.com/users/crassirostris/orgs","repos_url":"https://api.github.com/users/crassirostris/repos","events_url":"https://api.github.com/users/crassirostris/events{/privacy}","received_events_url":"https://api.github.com/users/crassirostris/received_events","type":"User","site_admin":false},"body":"Oh, I didn't understand your comment, sorry\r\n\r\nBy \"assume\" I mean the reference to the Shutdown method description in the Backend interface, where it's assumed that the method is called after the Run has been stopped by closing `stopCh` passed to it. Otherwise `collectLastEvents` method will hang forever. If we use `collectEvents` method instead, there's a race, b/c the order is not guaranteed in `select` clause and we can exit before collecting all events\r\n\r\nThe whole idea of `collectLastEvents` method is to overcome this race and collect all events, even if the `stopCh` was closed","created_at":"2017-08-14T17:11:46Z","updated_at":"2017-08-14T17:11:46Z","html_url":"https://github.com/kubernetes/kubernetes/pull/50577#discussion_r133006474","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/50577","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/133006474"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/50577#discussion_r133006474"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/50577"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/50577","id":135499274,"html_url":"https://github.com/kubernetes/kubernetes/pull/50577","diff_url":"https://github.com/kubernetes/kubernetes/pull/50577.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/50577.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/50577","number":50577,"state":"open","locked":false,"title":"audit: shutdown batching audit webhook gracefully","user":{"login":"crassirostris","id":1756505,"avatar_url":"https://avatars1.githubusercontent.com/u/1756505?v=4","gravatar_id":"","url":"https://api.github.com/users/crassirostris","html_url":"https://github.com/crassirostris","followers_url":"https://api.github.com/users/crassirostris/followers","following_url":"https://api.github.com/users/crassirostris/following{/other_user}","gists_url":"https://api.github.com/users/crassirostris/gists{/gist_id}","starred_url":"https://api.github.com/users/crassirostris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crassirostris/subscriptions","organizations_url":"https://api.github.com/users/crassirostris/orgs","repos_url":"https://api.github.com/users/crassirostris/repos","events_url":"https://api.github.com/users/crassirostris/events{/privacy}","received_events_url":"https://api.github.com/users/crassirostris/received_events","type":"User","site_admin":false},"body":"Follow-up of https://github.com/kubernetes/kubernetes/pull/50439\r\n\r\nWhen the `stopCh` passed to the batching audit webhook is closed, it stops accepting new events and when `Shutdown` method is called afterwards, it blocks until the last request to the webhook has finished.\r\n\r\n/cc @tallclair @soltysh ","created_at":"2017-08-13T16:15:55Z","updated_at":"2017-08-14T17:11:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"43ffa32df4202caf1ee378196b6caa2656941796","assignee":{"login":"sttts","id":730123,"avatar_url":"https://avatars0.githubusercontent.com/u/730123?v=4","gravatar_id":"","url":"https://api.github.com/users/sttts","html_url":"https://github.com/sttts","followers_url":"https://api.github.com/users/sttts/followers","following_url":"https://api.github.com/users/sttts/following{/other_user}","gists_url":"https://api.github.com/users/sttts/gists{/gist_id}","starred_url":"https://api.github.com/users/sttts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sttts/subscriptions","organizations_url":"https://api.github.com/users/sttts/orgs","repos_url":"https://api.github.com/users/sttts/repos","events_url":"https://api.github.com/users/sttts/events{/privacy}","received_events_url":"https://api.github.com/users/sttts/received_events","type":"User","site_admin":false},"assignees":[{"login":"sttts","id":730123,"avatar_url":"https://avatars0.githubusercontent.com/u/730123?v=4","gravatar_id":"","url":"https://api.github.com/users/sttts","html_url":"https://github.com/sttts","followers_url":"https://api.github.com/users/sttts/followers","following_url":"https://api.github.com/users/sttts/following{/other_user}","gists_url":"https://api.github.com/users/sttts/gists{/gist_id}","starred_url":"https://api.github.com/users/sttts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sttts/subscriptions","organizations_url":"https://api.github.com/users/sttts/orgs","repos_url":"https://api.github.com/users/sttts/repos","events_url":"https://api.github.com/users/sttts/events{/privacy}","received_events_url":"https://api.github.com/users/sttts/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"soltysh","id":576341,"avatar_url":"https://avatars2.githubusercontent.com/u/576341?v=4","gravatar_id":"","url":"https://api.github.com/users/soltysh","html_url":"https://github.com/soltysh","followers_url":"https://api.github.com/users/soltysh/followers","following_url":"https://api.github.com/users/soltysh/following{/other_user}","gists_url":"https://api.github.com/users/soltysh/gists{/gist_id}","starred_url":"https://api.github.com/users/soltysh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soltysh/subscriptions","organizations_url":"https://api.github.com/users/soltysh/orgs","repos_url":"https://api.github.com/users/soltysh/repos","events_url":"https://api.github.com/users/soltysh/events{/privacy}","received_events_url":"https://api.github.com/users/soltysh/received_events","type":"User","site_admin":false},{"login":"tallclair","id":29742491,"avatar_url":"https://avatars1.githubusercontent.com/u/29742491?v=4","gravatar_id":"","url":"https://api.github.com/users/tallclair","html_url":"https://github.com/tallclair","followers_url":"https://api.github.com/users/tallclair/followers","following_url":"https://api.github.com/users/tallclair/following{/other_user}","gists_url":"https://api.github.com/users/tallclair/gists{/gist_id}","starred_url":"https://api.github.com/users/tallclair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tallclair/subscriptions","organizations_url":"https://api.github.com/users/tallclair/orgs","repos_url":"https://api.github.com/users/tallclair/repos","events_url":"https://api.github.com/users/tallclair/events{/privacy}","received_events_url":"https://api.github.com/users/tallclair/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/36","html_url":"https://github.com/kubernetes/kubernetes/milestone/36","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/36/labels","id":2545392,"number":36,"title":"v1.8","description":"Kubernetes 1.8 release milestone, date is TBD.","creator":{"login":"timothysc","id":169553,"avatar_url":"https://avatars0.githubusercontent.com/u/169553?v=4","gravatar_id":"","url":"https://api.github.com/users/timothysc","html_url":"https://github.com/timothysc","followers_url":"https://api.github.com/users/timothysc/followers","following_url":"https://api.github.com/users/timothysc/following{/other_user}","gists_url":"https://api.github.com/users/timothysc/gists{/gist_id}","starred_url":"https://api.github.com/users/timothysc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timothysc/subscriptions","organizations_url":"https://api.github.com/users/timothysc/orgs","repos_url":"https://api.github.com/users/timothysc/repos","events_url":"https://api.github.com/users/timothysc/events{/privacy}","received_events_url":"https://api.github.com/users/timothysc/received_events","type":"User","site_admin":false},"open_issues":221,"closed_issues":173,"state":"open","created_at":"2017-05-26T17:18:43Z","updated_at":"2017-08-14T16:42:21Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/50577/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/50577/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/50577/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/697ba1e405dcdf698c1a80dca43bccb1cd85e774","head":{"label":"crassirostris:audit-graceful-shotdown","ref":"audit-graceful-shotdown","sha":"697ba1e405dcdf698c1a80dca43bccb1cd85e774","user":{"login":"crassirostris","id":1756505,"avatar_url":"https://avatars1.githubusercontent.com/u/1756505?v=4","gravatar_id":"","url":"https://api.github.com/users/crassirostris","html_url":"https://github.com/crassirostris","followers_url":"https://api.github.com/users/crassirostris/followers","following_url":"https://api.github.com/users/crassirostris/following{/other_user}","gists_url":"https://api.github.com/users/crassirostris/gists{/gist_id}","starred_url":"https://api.github.com/users/crassirostris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crassirostris/subscriptions","organizations_url":"https://api.github.com/users/crassirostris/orgs","repos_url":"https://api.github.com/users/crassirostris/repos","events_url":"https://api.github.com/users/crassirostris/events{/privacy}","received_events_url":"https://api.github.com/users/crassirostris/received_events","type":"User","site_admin":false},"repo":{"id":68590036,"name":"kubernetes","full_name":"crassirostris/kubernetes","owner":{"login":"crassirostris","id":1756505,"avatar_url":"https://avatars1.githubusercontent.com/u/1756505?v=4","gravatar_id":"","url":"https://api.github.com/users/crassirostris","html_url":"https://github.com/crassirostris","followers_url":"https://api.github.com/users/crassirostris/followers","following_url":"https://api.github.com/users/crassirostris/following{/other_user}","gists_url":"https://api.github.com/users/crassirostris/gists{/gist_id}","starred_url":"https://api.github.com/users/crassirostris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crassirostris/subscriptions","organizations_url":"https://api.github.com/users/crassirostris/orgs","repos_url":"https://api.github.com/users/crassirostris/repos","events_url":"https://api.github.com/users/crassirostris/events{/privacy}","received_events_url":"https://api.github.com/users/crassirostris/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/crassirostris/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/crassirostris/kubernetes","forks_url":"https://api.github.com/repos/crassirostris/kubernetes/forks","keys_url":"https://api.github.com/repos/crassirostris/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crassirostris/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crassirostris/kubernetes/teams","hooks_url":"https://api.github.com/repos/crassirostris/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/crassirostris/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/crassirostris/kubernetes/events","assignees_url":"https://api.github.com/repos/crassirostris/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/crassirostris/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/crassirostris/kubernetes/tags","blobs_url":"https://api.github.com/repos/crassirostris/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crassirostris/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crassirostris/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/crassirostris/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crassirostris/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/crassirostris/kubernetes/languages","stargazers_url":"https://api.github.com/repos/crassirostris/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/crassirostris/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/crassirostris/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/crassirostris/kubernetes/subscription","commits_url":"https://api.github.com/repos/crassirostris/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/crassirostris/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/crassirostris/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/crassirostris/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/crassirostris/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/crassirostris/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crassirostris/kubernetes/merges","archive_url":"https://api.github.com/repos/crassirostris/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crassirostris/kubernetes/downloads","issues_url":"https://api.github.com/repos/crassirostris/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/crassirostris/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/crassirostris/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/crassirostris/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crassirostris/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/crassirostris/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/crassirostris/kubernetes/deployments","created_at":"2016-09-19T09:23:31Z","updated_at":"2016-09-19T09:24:05Z","pushed_at":"2017-08-14T16:43:47Z","git_url":"git://github.com/crassirostris/kubernetes.git","ssh_url":"git@github.com:crassirostris/kubernetes.git","clone_url":"https://github.com/crassirostris/kubernetes.git","svn_url":"https://github.com/crassirostris/kubernetes","homepage":"http://kubernetes.io","size":460342,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"5e0a539cf116529607506379b2b4bf875191b2e3","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2017-08-14T13:25:35Z","pushed_at":"2017-08-14T17:03:33Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":676293,"stargazers_count":25863,"watchers_count":25863,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9217,"mirror_url":null,"open_issues_count":5207,"forks":9217,"open_issues":5207,"watchers":25863,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/50577"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/50577"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/50577"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/50577/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/50577/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/50577/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/697ba1e405dcdf698c1a80dca43bccb1cd85e774"}}}}
{"actor":{"display_login":"crassirostris"}}