{"push_id":1871355578,"size":8,"distinct_size":1,"ref":"refs/heads/master","head":"35e39eb45b07623a3c347a4f5ad51ffe1f01972e","before":"34db44a96a2229b85b354f5f47f4db89141e6125","commits":[{"sha":"ddeed88210052644f77c3f138ca1574dd7349e19","author":{"name":"Chris Hill-Scott","email":"b4a5ea001e047040e8c9075b67a268293138da2c@quis.cc"},"message":"Refactor check page into 3 separate templates\n\nThe check page is a very complex Jinja template. It needs breaking up\nto make it easier to understand what’s going on.\n\nI think there are three di","distinct":false,"url":"https://api.github.com/repos/alphagov/notifications-admin/commits/ddeed88210052644f77c3f138ca1574dd7349e19"},{"sha":"5a9f817e52c8ec24a358003713b198203d479283","author":{"name":"Chris Hill-Scott","email":"b4a5ea001e047040e8c9075b67a268293138da2c@quis.cc"},"message":"Remove anything error-related from the OK view\n\nIf you’ve uploaded a file and everything is OK, the page that you see\ndoesn’t need to look at any errors (because there won’t be any).","distinct":false,"url":"https://api.github.com/repos/alphagov/notifications-admin/commits/5a9f817e52c8ec24a358003713b198203d479283"},{"sha":"94bc8191aec3fc5ab1a71fd815fd83cc236ae91c","author":{"name":"Chris Hill-Scott","email":"b4a5ea001e047040e8c9075b67a268293138da2c@quis.cc"},"message":"Remove irrelevant stuff from error check pages\n\nIf you have errors in your file then there’s stuff you’re not going to\nsee on the page. So this doesn’t need to be in the Jinja templates that\nare only used when there are errors.\n\nBasically the conditional stuff is moving up to the level above these\ntemplates.","distinct":false,"url":"https://api.github.com/repos/alphagov/notifications-admin/commits/94bc8191aec3fc5ab1a71fd815fd83cc236ae91c"},{"sha":"8e947f315d9b864f79ffd8771b36cd0061eacc3d","author":{"name":"Chris Hill-Scott","email":"b4a5ea001e047040e8c9075b67a268293138da2c@quis.cc"},"message":"Refactor check error templates to repeat less\n\nThere was a lot of repetetive wrapping code being repeated for every\nconditional block in these files. Let’s wrap it around the whole\nconditional bit once instead.","distinct":false,"url":"https://api.github.com/repos/alphagov/notifications-admin/commits/8e947f315d9b864f79ffd8771b36cd0061eacc3d"},{"sha":"56945565ba8aa4fc32f8e3b1f121ef2cc83eec25","author":{"name":"Chris Hill-Scott","email":"b4a5ea001e047040e8c9075b67a268293138da2c@quis.cc"},"message":"Don’t indent column headings if no row errors\n\nThe reason to indent the first column heading is so that the number 1\nlines up with the numbers of subsequent rows.\n\nThis only happens when the subsequent rows are indented because of the\nred bars. This is only when there are row errors, not when there are\nmore general errors.","distinct":false,"url":"https://api.github.com/repos/alphagov/notifications-admin/commits/56945565ba8aa4fc32f8e3b1f121ef2cc83eec25"},{"sha":"eb264f34b766d92ce79cb116b6093698de593caf","author":{"name":"Chris Hill-Scott","email":"b4a5ea001e047040e8c9075b67a268293138da2c@quis.cc"},"message":"Add a little JS module to track events\n\nGoogle analytics lets you send:\n- pageviews\n- events\n\nPage views are used by default. But sometimes you wanna count something\nwhich isn’t the user navigating to a new page, or you wanna track\nsomething which isn’t just what page they were looking it. This is where\nevents are useful.\n\nThis commit adds a small JS module that lets us fire off an event when\nthe presence of an element with the right data attributes are present on\nthe page.","distinct":false,"url":"https://api.github.com/repos/alphagov/notifications-admin/commits/eb264f34b766d92ce79cb116b6093698de593caf"},{"sha":"82233340b63b524785cb2d2c19af10fd4c815be0","author":{"name":"Chris Hill-Scott","email":"b4a5ea001e047040e8c9075b67a268293138da2c@quis.cc"},"message":"Track errors when uploading spreadsheets\n\nUses the new javascript event tracking stuff so that we can see what\nerrors people are getting when they upload spreadsheets.","distinct":false,"url":"https://api.github.com/repos/alphagov/notifications-admin/commits/82233340b63b524785cb2d2c19af10fd4c815be0"},{"sha":"35e39eb45b07623a3c347a4f5ad51ffe1f01972e","author":{"name":"Chris Hill-Scott","email":"b4a5ea001e047040e8c9075b67a268293138da2c@quis.cc"},"message":"Merge pull request #1374 from alphagov/split-the-check\n\nSplit the ‘check’ template into three separate templates, add error tracking","distinct":true,"url":"https://api.github.com/repos/alphagov/notifications-admin/commits/35e39eb45b07623a3c347a4f5ad51ffe1f01972e"}]}
{"actor":{"display_login":"quis"}}