{"action":"created","comment":{"url":"https://api.github.com/repos/google/oboe/pulls/comments/157081322","pull_request_review_id":83666046,"id":157081322,"diff_hunk":"@@ -0,0 +1,102 @@\n+/*\n+ * Copyright 2017 The Android Open Source Project\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ *      http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+#include \"common/OboeDebug.h\"\n+#include \"EngineOpenSLES.h\"\n+#include \"OpenSLESUtilities.h\"\n+\n+using namespace oboe;\n+\n+EngineOpenSLES *EngineOpenSLES::getInstance() {\n+    static EngineOpenSLES sInstance;\n+    return &sInstance;","path":"src/opensles/EngineOpenSLES.cpp","position":25,"original_position":25,"commit_id":"d9703b0b72d1f26207a2b313768cb335d3e0fc9a","original_commit_id":"d9703b0b72d1f26207a2b313768cb335d3e0fc9a","user":{"login":"mnaganov","id":61981,"avatar_url":"https://avatars0.githubusercontent.com/u/61981?v=4","gravatar_id":"","url":"https://api.github.com/users/mnaganov","html_url":"https://github.com/mnaganov","followers_url":"https://api.github.com/users/mnaganov/followers","following_url":"https://api.github.com/users/mnaganov/following{/other_user}","gists_url":"https://api.github.com/users/mnaganov/gists{/gist_id}","starred_url":"https://api.github.com/users/mnaganov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mnaganov/subscriptions","organizations_url":"https://api.github.com/users/mnaganov/orgs","repos_url":"https://api.github.com/users/mnaganov/repos","events_url":"https://api.github.com/users/mnaganov/events{/privacy}","received_events_url":"https://api.github.com/users/mnaganov/received_events","type":"User","site_admin":false},"body":"It is preferred to return a reference (EngineOpenSLES&) rather than pointer for preventing clients from attempting to calling 'delete' on it or putting it into a smart pointer.\r\n\r\nAlso, references can't be null which makes caller's life easier.","created_at":"2017-12-14T22:36:52Z","updated_at":"2017-12-14T22:53:41Z","html_url":"https://github.com/google/oboe/pull/26#discussion_r157081322","pull_request_url":"https://api.github.com/repos/google/oboe/pulls/26","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/google/oboe/pulls/comments/157081322"},"html":{"href":"https://github.com/google/oboe/pull/26#discussion_r157081322"},"pull_request":{"href":"https://api.github.com/repos/google/oboe/pulls/26"}}},"pull_request":{"url":"https://api.github.com/repos/google/oboe/pulls/26","id":158458293,"html_url":"https://github.com/google/oboe/pull/26","diff_url":"https://github.com/google/oboe/pull/26.diff","patch_url":"https://github.com/google/oboe/pull/26.patch","issue_url":"https://api.github.com/repos/google/oboe/issues/26","number":26,"state":"open","locked":false,"title":"add input capture support to OpenSL wrapper","user":{"login":"philburk","id":5175913,"avatar_url":"https://avatars0.githubusercontent.com/u/5175913?v=4","gravatar_id":"","url":"https://api.github.com/users/philburk","html_url":"https://github.com/philburk","followers_url":"https://api.github.com/users/philburk/followers","following_url":"https://api.github.com/users/philburk/following{/other_user}","gists_url":"https://api.github.com/users/philburk/gists{/gist_id}","starred_url":"https://api.github.com/users/philburk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philburk/subscriptions","organizations_url":"https://api.github.com/users/philburk/orgs","repos_url":"https://api.github.com/users/philburk/repos","events_url":"https://api.github.com/users/philburk/events{/privacy}","received_events_url":"https://api.github.com/users/philburk/received_events","type":"User","site_admin":false},"body":"Refactored the OpenSL ES code.\r\nMoved static functions into classes.\r\nSplit into an Input and Output stream.\r\nAdded RECORD support.\r\nAdded some thread safety to EngineOpenSLES.\r\nFixed some bugs and removed asserts.\r\n","created_at":"2017-12-14T20:44:05Z","updated_at":"2017-12-14T22:53:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"65d9b22f2f372ce7efb3ccd09468530fb9a49255","assignee":null,"assignees":[],"requested_reviewers":[{"login":"dturner","id":873212,"avatar_url":"https://avatars1.githubusercontent.com/u/873212?v=4","gravatar_id":"","url":"https://api.github.com/users/dturner","html_url":"https://github.com/dturner","followers_url":"https://api.github.com/users/dturner/followers","following_url":"https://api.github.com/users/dturner/following{/other_user}","gists_url":"https://api.github.com/users/dturner/gists{/gist_id}","starred_url":"https://api.github.com/users/dturner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dturner/subscriptions","organizations_url":"https://api.github.com/users/dturner/orgs","repos_url":"https://api.github.com/users/dturner/repos","events_url":"https://api.github.com/users/dturner/events{/privacy}","received_events_url":"https://api.github.com/users/dturner/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/google/oboe/pulls/26/commits","review_comments_url":"https://api.github.com/repos/google/oboe/pulls/26/comments","review_comment_url":"https://api.github.com/repos/google/oboe/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/oboe/issues/26/comments","statuses_url":"https://api.github.com/repos/google/oboe/statuses/d9703b0b72d1f26207a2b313768cb335d3e0fc9a","head":{"label":"google:addinput","ref":"addinput","sha":"d9703b0b72d1f26207a2b313768cb335d3e0fc9a","user":{"login":"google","id":1342004,"avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":105566333,"name":"oboe","full_name":"google/oboe","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/oboe","description":"Oboe is a C++ library which makes it easy to build high-performance audio apps on Android.","fork":false,"url":"https://api.github.com/repos/google/oboe","forks_url":"https://api.github.com/repos/google/oboe/forks","keys_url":"https://api.github.com/repos/google/oboe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/oboe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/oboe/teams","hooks_url":"https://api.github.com/repos/google/oboe/hooks","issue_events_url":"https://api.github.com/repos/google/oboe/issues/events{/number}","events_url":"https://api.github.com/repos/google/oboe/events","assignees_url":"https://api.github.com/repos/google/oboe/assignees{/user}","branches_url":"https://api.github.com/repos/google/oboe/branches{/branch}","tags_url":"https://api.github.com/repos/google/oboe/tags","blobs_url":"https://api.github.com/repos/google/oboe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/oboe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/oboe/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/oboe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/oboe/statuses/{sha}","languages_url":"https://api.github.com/repos/google/oboe/languages","stargazers_url":"https://api.github.com/repos/google/oboe/stargazers","contributors_url":"https://api.github.com/repos/google/oboe/contributors","subscribers_url":"https://api.github.com/repos/google/oboe/subscribers","subscription_url":"https://api.github.com/repos/google/oboe/subscription","commits_url":"https://api.github.com/repos/google/oboe/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/oboe/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/oboe/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/oboe/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/oboe/contents/{+path}","compare_url":"https://api.github.com/repos/google/oboe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/oboe/merges","archive_url":"https://api.github.com/repos/google/oboe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/oboe/downloads","issues_url":"https://api.github.com/repos/google/oboe/issues{/number}","pulls_url":"https://api.github.com/repos/google/oboe/pulls{/number}","milestones_url":"https://api.github.com/repos/google/oboe/milestones{/number}","notifications_url":"https://api.github.com/repos/google/oboe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/oboe/labels{/name}","releases_url":"https://api.github.com/repos/google/oboe/releases{/id}","deployments_url":"https://api.github.com/repos/google/oboe/deployments","created_at":"2017-10-02T17:56:48Z","updated_at":"2017-12-12T20:16:13Z","pushed_at":"2017-12-14T20:44:06Z","git_url":"git://github.com/google/oboe.git","ssh_url":"git@github.com:google/oboe.git","clone_url":"https://github.com/google/oboe.git","svn_url":"https://github.com/google/oboe","homepage":"","size":334,"stargazers_count":52,"watchers_count":52,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":4,"open_issues":6,"watchers":52,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"ca64ea1d9086448b456049aa81340d88621c0664","user":{"login":"google","id":1342004,"avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":105566333,"name":"oboe","full_name":"google/oboe","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/oboe","description":"Oboe is a C++ library which makes it easy to build high-performance audio apps on Android.","fork":false,"url":"https://api.github.com/repos/google/oboe","forks_url":"https://api.github.com/repos/google/oboe/forks","keys_url":"https://api.github.com/repos/google/oboe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/oboe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/oboe/teams","hooks_url":"https://api.github.com/repos/google/oboe/hooks","issue_events_url":"https://api.github.com/repos/google/oboe/issues/events{/number}","events_url":"https://api.github.com/repos/google/oboe/events","assignees_url":"https://api.github.com/repos/google/oboe/assignees{/user}","branches_url":"https://api.github.com/repos/google/oboe/branches{/branch}","tags_url":"https://api.github.com/repos/google/oboe/tags","blobs_url":"https://api.github.com/repos/google/oboe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/oboe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/oboe/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/oboe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/oboe/statuses/{sha}","languages_url":"https://api.github.com/repos/google/oboe/languages","stargazers_url":"https://api.github.com/repos/google/oboe/stargazers","contributors_url":"https://api.github.com/repos/google/oboe/contributors","subscribers_url":"https://api.github.com/repos/google/oboe/subscribers","subscription_url":"https://api.github.com/repos/google/oboe/subscription","commits_url":"https://api.github.com/repos/google/oboe/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/oboe/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/oboe/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/oboe/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/oboe/contents/{+path}","compare_url":"https://api.github.com/repos/google/oboe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/oboe/merges","archive_url":"https://api.github.com/repos/google/oboe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/oboe/downloads","issues_url":"https://api.github.com/repos/google/oboe/issues{/number}","pulls_url":"https://api.github.com/repos/google/oboe/pulls{/number}","milestones_url":"https://api.github.com/repos/google/oboe/milestones{/number}","notifications_url":"https://api.github.com/repos/google/oboe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/oboe/labels{/name}","releases_url":"https://api.github.com/repos/google/oboe/releases{/id}","deployments_url":"https://api.github.com/repos/google/oboe/deployments","created_at":"2017-10-02T17:56:48Z","updated_at":"2017-12-12T20:16:13Z","pushed_at":"2017-12-14T20:44:06Z","git_url":"git://github.com/google/oboe.git","ssh_url":"git@github.com:google/oboe.git","clone_url":"https://github.com/google/oboe.git","svn_url":"https://github.com/google/oboe","homepage":"","size":334,"stargazers_count":52,"watchers_count":52,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":4,"open_issues":6,"watchers":52,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/oboe/pulls/26"},"html":{"href":"https://github.com/google/oboe/pull/26"},"issue":{"href":"https://api.github.com/repos/google/oboe/issues/26"},"comments":{"href":"https://api.github.com/repos/google/oboe/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/google/oboe/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/google/oboe/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/oboe/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/google/oboe/statuses/d9703b0b72d1f26207a2b313768cb335d3e0fc9a"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"mnaganov"}}