{"action":"closed","number":4010,"pull_request":{"url":"https://api.github.com/repos/DarkstarProject/darkstar/pulls/4010","id":137327047,"html_url":"https://github.com/DarkstarProject/darkstar/pull/4010","diff_url":"https://github.com/DarkstarProject/darkstar/pull/4010.diff","patch_url":"https://github.com/DarkstarProject/darkstar/pull/4010.patch","issue_url":"https://api.github.com/repos/DarkstarProject/darkstar/issues/4010","number":4010,"state":"closed","locked":false,"title":"Eliminate NPC/Mob IDs from Lua","user":{"login":"ymkc","id":16548266,"avatar_url":"https://avatars1.githubusercontent.com/u/16548266?v=4","gravatar_id":"","url":"https://api.github.com/users/ymkc","html_url":"https://github.com/ymkc","followers_url":"https://api.github.com/users/ymkc/followers","following_url":"https://api.github.com/users/ymkc/following{/other_user}","gists_url":"https://api.github.com/users/ymkc/gists{/gist_id}","starred_url":"https://api.github.com/users/ymkc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ymkc/subscriptions","organizations_url":"https://api.github.com/users/ymkc/orgs","repos_url":"https://api.github.com/users/ymkc/repos","events_url":"https://api.github.com/users/ymkc/events{/privacy}","received_events_url":"https://api.github.com/users/ymkc/received_events","type":"User","site_admin":false},"body":"This is just a suggestion and kind of a proof of concept.\r\n\r\nIn the long run, it could simplify keeping up with the ever changing IDs and reduce the \"ID out of sync\" bugs.","created_at":"2017-08-23T21:54:56Z","updated_at":"2017-12-30T20:49:38Z","closed_at":"2017-12-30T20:49:38Z","merged_at":null,"merge_commit_sha":"1f62a6f2d512cf37d89b6b5ee31c7cbf3f2885ff","assignee":{"login":"teschnei","id":1149183,"avatar_url":"https://avatars3.githubusercontent.com/u/1149183?v=4","gravatar_id":"","url":"https://api.github.com/users/teschnei","html_url":"https://github.com/teschnei","followers_url":"https://api.github.com/users/teschnei/followers","following_url":"https://api.github.com/users/teschnei/following{/other_user}","gists_url":"https://api.github.com/users/teschnei/gists{/gist_id}","starred_url":"https://api.github.com/users/teschnei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teschnei/subscriptions","organizations_url":"https://api.github.com/users/teschnei/orgs","repos_url":"https://api.github.com/users/teschnei/repos","events_url":"https://api.github.com/users/teschnei/events{/privacy}","received_events_url":"https://api.github.com/users/teschnei/received_events","type":"User","site_admin":false},"assignees":[{"login":"teschnei","id":1149183,"avatar_url":"https://avatars3.githubusercontent.com/u/1149183?v=4","gravatar_id":"","url":"https://api.github.com/users/teschnei","html_url":"https://github.com/teschnei","followers_url":"https://api.github.com/users/teschnei/followers","following_url":"https://api.github.com/users/teschnei/following{/other_user}","gists_url":"https://api.github.com/users/teschnei/gists{/gist_id}","starred_url":"https://api.github.com/users/teschnei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teschnei/subscriptions","organizations_url":"https://api.github.com/users/teschnei/orgs","repos_url":"https://api.github.com/users/teschnei/repos","events_url":"https://api.github.com/users/teschnei/events{/privacy}","received_events_url":"https://api.github.com/users/teschnei/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/DarkstarProject/darkstar/pulls/4010/commits","review_comments_url":"https://api.github.com/repos/DarkstarProject/darkstar/pulls/4010/comments","review_comment_url":"https://api.github.com/repos/DarkstarProject/darkstar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DarkstarProject/darkstar/issues/4010/comments","statuses_url":"https://api.github.com/repos/DarkstarProject/darkstar/statuses/7668c10bce7292e1b0d73462531f5727d73c24d8","head":{"label":"ymkc:getnpcid","ref":"getnpcid","sha":"7668c10bce7292e1b0d73462531f5727d73c24d8","user":{"login":"ymkc","id":16548266,"avatar_url":"https://avatars1.githubusercontent.com/u/16548266?v=4","gravatar_id":"","url":"https://api.github.com/users/ymkc","html_url":"https://github.com/ymkc","followers_url":"https://api.github.com/users/ymkc/followers","following_url":"https://api.github.com/users/ymkc/following{/other_user}","gists_url":"https://api.github.com/users/ymkc/gists{/gist_id}","starred_url":"https://api.github.com/users/ymkc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ymkc/subscriptions","organizations_url":"https://api.github.com/users/ymkc/orgs","repos_url":"https://api.github.com/users/ymkc/repos","events_url":"https://api.github.com/users/ymkc/events{/privacy}","received_events_url":"https://api.github.com/users/ymkc/received_events","type":"User","site_admin":false},"repo":{"id":55918659,"name":"darkstar","full_name":"ymkc/darkstar","owner":{"login":"ymkc","id":16548266,"avatar_url":"https://avatars1.githubusercontent.com/u/16548266?v=4","gravatar_id":"","url":"https://api.github.com/users/ymkc","html_url":"https://github.com/ymkc","followers_url":"https://api.github.com/users/ymkc/followers","following_url":"https://api.github.com/users/ymkc/following{/other_user}","gists_url":"https://api.github.com/users/ymkc/gists{/gist_id}","starred_url":"https://api.github.com/users/ymkc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ymkc/subscriptions","organizations_url":"https://api.github.com/users/ymkc/orgs","repos_url":"https://api.github.com/users/ymkc/repos","events_url":"https://api.github.com/users/ymkc/events{/privacy}","received_events_url":"https://api.github.com/users/ymkc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ymkc/darkstar","description":"FFXI Server Emulator","fork":true,"url":"https://api.github.com/repos/ymkc/darkstar","forks_url":"https://api.github.com/repos/ymkc/darkstar/forks","keys_url":"https://api.github.com/repos/ymkc/darkstar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ymkc/darkstar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ymkc/darkstar/teams","hooks_url":"https://api.github.com/repos/ymkc/darkstar/hooks","issue_events_url":"https://api.github.com/repos/ymkc/darkstar/issues/events{/number}","events_url":"https://api.github.com/repos/ymkc/darkstar/events","assignees_url":"https://api.github.com/repos/ymkc/darkstar/assignees{/user}","branches_url":"https://api.github.com/repos/ymkc/darkstar/branches{/branch}","tags_url":"https://api.github.com/repos/ymkc/darkstar/tags","blobs_url":"https://api.github.com/repos/ymkc/darkstar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ymkc/darkstar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ymkc/darkstar/git/refs{/sha}","trees_url":"https://api.github.com/repos/ymkc/darkstar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ymkc/darkstar/statuses/{sha}","languages_url":"https://api.github.com/repos/ymkc/darkstar/languages","stargazers_url":"https://api.github.com/repos/ymkc/darkstar/stargazers","contributors_url":"https://api.github.com/repos/ymkc/darkstar/contributors","subscribers_url":"https://api.github.com/repos/ymkc/darkstar/subscribers","subscription_url":"https://api.github.com/repos/ymkc/darkstar/subscription","commits_url":"https://api.github.com/repos/ymkc/darkstar/commits{/sha}","git_commits_url":"https://api.github.com/repos/ymkc/darkstar/git/commits{/sha}","comments_url":"https://api.github.com/repos/ymkc/darkstar/comments{/number}","issue_comment_url":"https://api.github.com/repos/ymkc/darkstar/issues/comments{/number}","contents_url":"https://api.github.com/repos/ymkc/darkstar/contents/{+path}","compare_url":"https://api.github.com/repos/ymkc/darkstar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ymkc/darkstar/merges","archive_url":"https://api.github.com/repos/ymkc/darkstar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ymkc/darkstar/downloads","issues_url":"https://api.github.com/repos/ymkc/darkstar/issues{/number}","pulls_url":"https://api.github.com/repos/ymkc/darkstar/pulls{/number}","milestones_url":"https://api.github.com/repos/ymkc/darkstar/milestones{/number}","notifications_url":"https://api.github.com/repos/ymkc/darkstar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ymkc/darkstar/labels{/name}","releases_url":"https://api.github.com/repos/ymkc/darkstar/releases{/id}","deployments_url":"https://api.github.com/repos/ymkc/darkstar/deployments","created_at":"2016-04-10T19:38:40Z","updated_at":"2016-04-10T19:38:52Z","pushed_at":"2017-12-30T20:49:38Z","git_url":"git://github.com/ymkc/darkstar.git","ssh_url":"git@github.com:ymkc/darkstar.git","clone_url":"https://github.com/ymkc/darkstar.git","svn_url":"https://github.com/ymkc/darkstar","homepage":"https://forums.dspt.info/index.php","size":190695,"stargazers_count":0,"watchers_count":0,"language":"Lua","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DarkstarProject:master","ref":"master","sha":"1440703f760fab90a77e58ce434a3be12034077c","user":{"login":"DarkstarProject","id":6373714,"avatar_url":"https://avatars2.githubusercontent.com/u/6373714?v=4","gravatar_id":"","url":"https://api.github.com/users/DarkstarProject","html_url":"https://github.com/DarkstarProject","followers_url":"https://api.github.com/users/DarkstarProject/followers","following_url":"https://api.github.com/users/DarkstarProject/following{/other_user}","gists_url":"https://api.github.com/users/DarkstarProject/gists{/gist_id}","starred_url":"https://api.github.com/users/DarkstarProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DarkstarProject/subscriptions","organizations_url":"https://api.github.com/users/DarkstarProject/orgs","repos_url":"https://api.github.com/users/DarkstarProject/repos","events_url":"https://api.github.com/users/DarkstarProject/events{/privacy}","received_events_url":"https://api.github.com/users/DarkstarProject/received_events","type":"Organization","site_admin":false},"repo":{"id":15814642,"name":"darkstar","full_name":"DarkstarProject/darkstar","owner":{"login":"DarkstarProject","id":6373714,"avatar_url":"https://avatars2.githubusercontent.com/u/6373714?v=4","gravatar_id":"","url":"https://api.github.com/users/DarkstarProject","html_url":"https://github.com/DarkstarProject","followers_url":"https://api.github.com/users/DarkstarProject/followers","following_url":"https://api.github.com/users/DarkstarProject/following{/other_user}","gists_url":"https://api.github.com/users/DarkstarProject/gists{/gist_id}","starred_url":"https://api.github.com/users/DarkstarProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DarkstarProject/subscriptions","organizations_url":"https://api.github.com/users/DarkstarProject/orgs","repos_url":"https://api.github.com/users/DarkstarProject/repos","events_url":"https://api.github.com/users/DarkstarProject/events{/privacy}","received_events_url":"https://api.github.com/users/DarkstarProject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DarkstarProject/darkstar","description":"FFXI Server Emulator","fork":false,"url":"https://api.github.com/repos/DarkstarProject/darkstar","forks_url":"https://api.github.com/repos/DarkstarProject/darkstar/forks","keys_url":"https://api.github.com/repos/DarkstarProject/darkstar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DarkstarProject/darkstar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DarkstarProject/darkstar/teams","hooks_url":"https://api.github.com/repos/DarkstarProject/darkstar/hooks","issue_events_url":"https://api.github.com/repos/DarkstarProject/darkstar/issues/events{/number}","events_url":"https://api.github.com/repos/DarkstarProject/darkstar/events","assignees_url":"https://api.github.com/repos/DarkstarProject/darkstar/assignees{/user}","branches_url":"https://api.github.com/repos/DarkstarProject/darkstar/branches{/branch}","tags_url":"https://api.github.com/repos/DarkstarProject/darkstar/tags","blobs_url":"https://api.github.com/repos/DarkstarProject/darkstar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DarkstarProject/darkstar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DarkstarProject/darkstar/git/refs{/sha}","trees_url":"https://api.github.com/repos/DarkstarProject/darkstar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DarkstarProject/darkstar/statuses/{sha}","languages_url":"https://api.github.com/repos/DarkstarProject/darkstar/languages","stargazers_url":"https://api.github.com/repos/DarkstarProject/darkstar/stargazers","contributors_url":"https://api.github.com/repos/DarkstarProject/darkstar/contributors","subscribers_url":"https://api.github.com/repos/DarkstarProject/darkstar/subscribers","subscription_url":"https://api.github.com/repos/DarkstarProject/darkstar/subscription","commits_url":"https://api.github.com/repos/DarkstarProject/darkstar/commits{/sha}","git_commits_url":"https://api.github.com/repos/DarkstarProject/darkstar/git/commits{/sha}","comments_url":"https://api.github.com/repos/DarkstarProject/darkstar/comments{/number}","issue_comment_url":"https://api.github.com/repos/DarkstarProject/darkstar/issues/comments{/number}","contents_url":"https://api.github.com/repos/DarkstarProject/darkstar/contents/{+path}","compare_url":"https://api.github.com/repos/DarkstarProject/darkstar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DarkstarProject/darkstar/merges","archive_url":"https://api.github.com/repos/DarkstarProject/darkstar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DarkstarProject/darkstar/downloads","issues_url":"https://api.github.com/repos/DarkstarProject/darkstar/issues{/number}","pulls_url":"https://api.github.com/repos/DarkstarProject/darkstar/pulls{/number}","milestones_url":"https://api.github.com/repos/DarkstarProject/darkstar/milestones{/number}","notifications_url":"https://api.github.com/repos/DarkstarProject/darkstar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DarkstarProject/darkstar/labels{/name}","releases_url":"https://api.github.com/repos/DarkstarProject/darkstar/releases{/id}","deployments_url":"https://api.github.com/repos/DarkstarProject/darkstar/deployments","created_at":"2014-01-11T01:31:17Z","updated_at":"2017-12-26T15:47:55Z","pushed_at":"2017-12-30T18:12:47Z","git_url":"git://github.com/DarkstarProject/darkstar.git","ssh_url":"git@github.com:DarkstarProject/darkstar.git","clone_url":"https://github.com/DarkstarProject/darkstar.git","svn_url":"https://github.com/DarkstarProject/darkstar","homepage":"https://forums.dspt.info/index.php","size":191926,"stargazers_count":276,"watchers_count":276,"language":"Lua","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":476,"mirror_url":null,"archived":false,"open_issues_count":408,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":476,"open_issues":408,"watchers":276,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DarkstarProject/darkstar/pulls/4010"},"html":{"href":"https://github.com/DarkstarProject/darkstar/pull/4010"},"issue":{"href":"https://api.github.com/repos/DarkstarProject/darkstar/issues/4010"},"comments":{"href":"https://api.github.com/repos/DarkstarProject/darkstar/issues/4010/comments"},"review_comments":{"href":"https://api.github.com/repos/DarkstarProject/darkstar/pulls/4010/comments"},"review_comment":{"href":"https://api.github.com/repos/DarkstarProject/darkstar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DarkstarProject/darkstar/pulls/4010/commits"},"statuses":{"href":"https://api.github.com/repos/DarkstarProject/darkstar/statuses/7668c10bce7292e1b0d73462531f5727d73c24d8"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":11,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":163,"deletions":46,"changed_files":13}}
{"actor":{"display_login":"ymkc"}}