{"action":"created","comment":{"url":"https://api.github.com/repos/furlongm/openvpn-monitor/pulls/comments/107063034","pull_request_review_id":28013000,"id":107063034,"diff_hunk":"@@ -0,0 +1,203 @@\n+(function () {\n+\n+L.Control.FullScreen = L.Control.extend({\n+\toptions: {\n+\t\tposition: 'topleft',\n+\t\ttitle: 'Full Screen',\n+\t\ttitleCancel: 'Exit Full Screen',\n+\t\tforceSeparateButton: false,\n+\t\tforcePseudoFullscreen: false,\n+\t\tfullscreenElement: false\n+\t},\n+\t\n+\tonAdd: function (map) {\n+\t\tvar className = 'leaflet-control-zoom-fullscreen', container, content = '';\n+\t\t\n+\t\tif (map.zoomControl && !this.options.forceSeparateButton) {\n+\t\t\tcontainer = map.zoomControl._container;\n+\t\t} else {\n+\t\t\tcontainer = L.DomUtil.create('div', 'leaflet-bar');\n+\t\t}\n+\t\t\n+\t\tif (this.options.content) {\n+\t\t\tcontent = this.options.content;\n+\t\t} else {\n+\t\t\tclassName += ' fullscreen-icon';\n+\t\t}\n+\n+\t\tthis._createButton(this.options.title, className, content, container, this.toggleFullScreen, this);\n+\n+\t\tthis._map.on('enterFullscreen exitFullscreen', this._toggleTitle, this);\n+\n+\t\treturn container;\n+\t},\n+\t\n+\t_createButton: function (title, className, content, container, fn, context) {\n+\t\tthis.link = L.DomUtil.create('a', className, container);\n+\t\tthis.link.href = '#';\n+\t\tthis.link.title = title;\n+\t\tthis.link.innerHTML = content;\n+\n+\t\tL.DomEvent\n+\t\t\t.addListener(this.link, 'click', L.DomEvent.stopPropagation)\n+\t\t\t.addListener(this.link, 'click', L.DomEvent.preventDefault)\n+\t\t\t.addListener(this.link, 'click', fn, context);\n+\t\t\n+\t\tL.DomEvent\n+\t\t\t.addListener(container, fullScreenApi.fullScreenEventName, L.DomEvent.stopPropagation)\n+\t\t\t.addListener(container, fullScreenApi.fullScreenEventName, L.DomEvent.preventDefault)","path":"js/Control.FullScreen.js","position":48,"original_position":48,"commit_id":"90c15333a19afc4b35666b3e147d1aa0e0e60663","original_commit_id":"90c15333a19afc4b35666b3e147d1aa0e0e60663","user":{"login":"codacy-bot","id":19940114,"avatar_url":"https://avatars2.githubusercontent.com/u/19940114?v=3","gravatar_id":"","url":"https://api.github.com/users/codacy-bot","html_url":"https://github.com/codacy-bot","followers_url":"https://api.github.com/users/codacy-bot/followers","following_url":"https://api.github.com/users/codacy-bot/following{/other_user}","gists_url":"https://api.github.com/users/codacy-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/codacy-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codacy-bot/subscriptions","organizations_url":"https://api.github.com/users/codacy-bot/orgs","repos_url":"https://api.github.com/users/codacy-bot/repos","events_url":"https://api.github.com/users/codacy-bot/events{/privacy}","received_events_url":"https://api.github.com/users/codacy-bot/received_events","type":"User","site_admin":false},"body":"![Codacy](https://www.codacy.com/assets/images/favicon.png) Issue found: ['fullScreenApi' was used before it was defined. (no-use-before-define)](https://www.codacy.com/app/furlongm/openvpn-monitor/pullRequest?prid=567646)","created_at":"2017-03-21T02:49:46Z","updated_at":"2017-03-21T02:49:46Z","html_url":"https://github.com/furlongm/openvpn-monitor/pull/41#discussion_r107063034","pull_request_url":"https://api.github.com/repos/furlongm/openvpn-monitor/pulls/41","_links":{"self":{"href":"https://api.github.com/repos/furlongm/openvpn-monitor/pulls/comments/107063034"},"html":{"href":"https://github.com/furlongm/openvpn-monitor/pull/41#discussion_r107063034"},"pull_request":{"href":"https://api.github.com/repos/furlongm/openvpn-monitor/pulls/41"}}},"pull_request":{"url":"https://api.github.com/repos/furlongm/openvpn-monitor/pulls/41","id":111543815,"html_url":"https://github.com/furlongm/openvpn-monitor/pull/41","diff_url":"https://github.com/furlongm/openvpn-monitor/pull/41.diff","patch_url":"https://github.com/furlongm/openvpn-monitor/pull/41.patch","issue_url":"https://api.github.com/repos/furlongm/openvpn-monitor/issues/41","number":41,"state":"open","locked":false,"title":"OpenVPN Monitor Enhancements","user":{"login":"kingy444","id":7148670,"avatar_url":"https://avatars2.githubusercontent.com/u/7148670?v=3","gravatar_id":"","url":"https://api.github.com/users/kingy444","html_url":"https://github.com/kingy444","followers_url":"https://api.github.com/users/kingy444/followers","following_url":"https://api.github.com/users/kingy444/following{/other_user}","gists_url":"https://api.github.com/users/kingy444/gists{/gist_id}","starred_url":"https://api.github.com/users/kingy444/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kingy444/subscriptions","organizations_url":"https://api.github.com/users/kingy444/orgs","repos_url":"https://api.github.com/users/kingy444/repos","events_url":"https://api.github.com/users/kingy444/events{/privacy}","received_events_url":"https://api.github.com/users/kingy444/received_events","type":"User","site_admin":false},"body":"Thanks for all the work in initial config of site.\r\n\r\nI have made a few enhancements to further improve it. I have listed them below and could have missed something as i was surprised at how quickly development moved. Everything i have added in follows your coding model, and I have set off by default and on by choice.\r\n\r\nObviously ask any questions, just enjoyed the base product and wanted to enhance it. Hoping your comfortable with enhancements. While i only just forked the project, i've been running the enhancements for the last week.\r\n\r\nSummarised changes follow:\r\n- Added markers for both VPN connections and the Monitor box itself.  (This addresses https://github.com/furlongm/openvpn-monitor/issues/39)\r\n- Added Route lines between VPN Server and VPN Client\r\n- Added Layer control to turn items off based on type and per vpn\r\n- Added Fullscreen map capability\r\n- Added Legend to the map for new icons (dynamic based on enabled icons)\r\n![map](https://cloud.githubusercontent.com/assets/7148670/24099814/53939450-0dc5-11e7-8191-f6dea9f4f981.JPG)\r\n- Added ability to manage icons that appear too close together (spiderfy)\r\n![spiderfy](https://cloud.githubusercontent.com/assets/7148670/24099875/9adb25ee-0dc5-11e7-84fd-a441cba8facb.JPG)\r\n- Changed the version label to a panel footer with custom css to allow it to work better in a responsive environment. (Label was offscreen)\r\n![version](https://cloud.githubusercontent.com/assets/7148670/24100065/7f07c178-0dc6-11e7-863e-9539072973e2.JPG)\r\n- Corrected usage of 'table-responsive'. Should be used on a div and not the table itself. Responsive now working on mobile. \r\n- Added openvpn-monitor.conf.example (Addressing https://github.com/furlongm/openvpn-monitor/issues/33). If you agree with that request you will need to remove openvpn-monitor.conf, and add a step to 'cp /var/www/html/openvpn-monitor/openvpn-monitor.conf.example /var/www/html/openvpn-monitor/openvpn-monitor.conf' on initial download\r\n- Updated the ReadME to include relevant info on the changes and recognition of plugins\r\n- Added FavIcon\r\n- Updated PopUps to work with spiderfy and contain more info on multiple markers","created_at":"2017-03-20T12:42:07Z","updated_at":"2017-03-21T02:49:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5b53b85765e7303a77af4517b1559ac26122abd3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/furlongm/openvpn-monitor/pulls/41/commits","review_comments_url":"https://api.github.com/repos/furlongm/openvpn-monitor/pulls/41/comments","review_comment_url":"https://api.github.com/repos/furlongm/openvpn-monitor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/furlongm/openvpn-monitor/issues/41/comments","statuses_url":"https://api.github.com/repos/furlongm/openvpn-monitor/statuses/90c15333a19afc4b35666b3e147d1aa0e0e60663","head":{"label":"kingy444:master","ref":"master","sha":"90c15333a19afc4b35666b3e147d1aa0e0e60663","user":{"login":"kingy444","id":7148670,"avatar_url":"https://avatars2.githubusercontent.com/u/7148670?v=3","gravatar_id":"","url":"https://api.github.com/users/kingy444","html_url":"https://github.com/kingy444","followers_url":"https://api.github.com/users/kingy444/followers","following_url":"https://api.github.com/users/kingy444/following{/other_user}","gists_url":"https://api.github.com/users/kingy444/gists{/gist_id}","starred_url":"https://api.github.com/users/kingy444/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kingy444/subscriptions","organizations_url":"https://api.github.com/users/kingy444/orgs","repos_url":"https://api.github.com/users/kingy444/repos","events_url":"https://api.github.com/users/kingy444/events{/privacy}","received_events_url":"https://api.github.com/users/kingy444/received_events","type":"User","site_admin":false},"repo":{"id":85563291,"name":"openvpn-monitor","full_name":"kingy444/openvpn-monitor","owner":{"login":"kingy444","id":7148670,"avatar_url":"https://avatars2.githubusercontent.com/u/7148670?v=3","gravatar_id":"","url":"https://api.github.com/users/kingy444","html_url":"https://github.com/kingy444","followers_url":"https://api.github.com/users/kingy444/followers","following_url":"https://api.github.com/users/kingy444/following{/other_user}","gists_url":"https://api.github.com/users/kingy444/gists{/gist_id}","starred_url":"https://api.github.com/users/kingy444/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kingy444/subscriptions","organizations_url":"https://api.github.com/users/kingy444/orgs","repos_url":"https://api.github.com/users/kingy444/repos","events_url":"https://api.github.com/users/kingy444/events{/privacy}","received_events_url":"https://api.github.com/users/kingy444/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kingy444/openvpn-monitor","description":"openvpn-monitor is a web based OpenVPN monitor, that shows current connection information, such as users, location and data transferred.","fork":true,"url":"https://api.github.com/repos/kingy444/openvpn-monitor","forks_url":"https://api.github.com/repos/kingy444/openvpn-monitor/forks","keys_url":"https://api.github.com/repos/kingy444/openvpn-monitor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kingy444/openvpn-monitor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kingy444/openvpn-monitor/teams","hooks_url":"https://api.github.com/repos/kingy444/openvpn-monitor/hooks","issue_events_url":"https://api.github.com/repos/kingy444/openvpn-monitor/issues/events{/number}","events_url":"https://api.github.com/repos/kingy444/openvpn-monitor/events","assignees_url":"https://api.github.com/repos/kingy444/openvpn-monitor/assignees{/user}","branches_url":"https://api.github.com/repos/kingy444/openvpn-monitor/branches{/branch}","tags_url":"https://api.github.com/repos/kingy444/openvpn-monitor/tags","blobs_url":"https://api.github.com/repos/kingy444/openvpn-monitor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kingy444/openvpn-monitor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kingy444/openvpn-monitor/git/refs{/sha}","trees_url":"https://api.github.com/repos/kingy444/openvpn-monitor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kingy444/openvpn-monitor/statuses/{sha}","languages_url":"https://api.github.com/repos/kingy444/openvpn-monitor/languages","stargazers_url":"https://api.github.com/repos/kingy444/openvpn-monitor/stargazers","contributors_url":"https://api.github.com/repos/kingy444/openvpn-monitor/contributors","subscribers_url":"https://api.github.com/repos/kingy444/openvpn-monitor/subscribers","subscription_url":"https://api.github.com/repos/kingy444/openvpn-monitor/subscription","commits_url":"https://api.github.com/repos/kingy444/openvpn-monitor/commits{/sha}","git_commits_url":"https://api.github.com/repos/kingy444/openvpn-monitor/git/commits{/sha}","comments_url":"https://api.github.com/repos/kingy444/openvpn-monitor/comments{/number}","issue_comment_url":"https://api.github.com/repos/kingy444/openvpn-monitor/issues/comments{/number}","contents_url":"https://api.github.com/repos/kingy444/openvpn-monitor/contents/{+path}","compare_url":"https://api.github.com/repos/kingy444/openvpn-monitor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kingy444/openvpn-monitor/merges","archive_url":"https://api.github.com/repos/kingy444/openvpn-monitor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kingy444/openvpn-monitor/downloads","issues_url":"https://api.github.com/repos/kingy444/openvpn-monitor/issues{/number}","pulls_url":"https://api.github.com/repos/kingy444/openvpn-monitor/pulls{/number}","milestones_url":"https://api.github.com/repos/kingy444/openvpn-monitor/milestones{/number}","notifications_url":"https://api.github.com/repos/kingy444/openvpn-monitor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kingy444/openvpn-monitor/labels{/name}","releases_url":"https://api.github.com/repos/kingy444/openvpn-monitor/releases{/id}","deployments_url":"https://api.github.com/repos/kingy444/openvpn-monitor/deployments","created_at":"2017-03-20T10:22:17Z","updated_at":"2017-03-20T10:22:19Z","pushed_at":"2017-03-21T02:44:39Z","git_url":"git://github.com/kingy444/openvpn-monitor.git","ssh_url":"git@github.com:kingy444/openvpn-monitor.git","clone_url":"https://github.com/kingy444/openvpn-monitor.git","svn_url":"https://github.com/kingy444/openvpn-monitor","homepage":"http://openvpn-monitor.openbytes.ie","size":1127,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"furlongm:master","ref":"master","sha":"4127f2f103550bb75d481bee8074043fbe8103b4","user":{"login":"furlongm","id":114803,"avatar_url":"https://avatars0.githubusercontent.com/u/114803?v=3","gravatar_id":"","url":"https://api.github.com/users/furlongm","html_url":"https://github.com/furlongm","followers_url":"https://api.github.com/users/furlongm/followers","following_url":"https://api.github.com/users/furlongm/following{/other_user}","gists_url":"https://api.github.com/users/furlongm/gists{/gist_id}","starred_url":"https://api.github.com/users/furlongm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/furlongm/subscriptions","organizations_url":"https://api.github.com/users/furlongm/orgs","repos_url":"https://api.github.com/users/furlongm/repos","events_url":"https://api.github.com/users/furlongm/events{/privacy}","received_events_url":"https://api.github.com/users/furlongm/received_events","type":"User","site_admin":false},"repo":{"id":5448538,"name":"openvpn-monitor","full_name":"furlongm/openvpn-monitor","owner":{"login":"furlongm","id":114803,"avatar_url":"https://avatars0.githubusercontent.com/u/114803?v=3","gravatar_id":"","url":"https://api.github.com/users/furlongm","html_url":"https://github.com/furlongm","followers_url":"https://api.github.com/users/furlongm/followers","following_url":"https://api.github.com/users/furlongm/following{/other_user}","gists_url":"https://api.github.com/users/furlongm/gists{/gist_id}","starred_url":"https://api.github.com/users/furlongm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/furlongm/subscriptions","organizations_url":"https://api.github.com/users/furlongm/orgs","repos_url":"https://api.github.com/users/furlongm/repos","events_url":"https://api.github.com/users/furlongm/events{/privacy}","received_events_url":"https://api.github.com/users/furlongm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/furlongm/openvpn-monitor","description":"openvpn-monitor is a web based OpenVPN monitor, that shows current connection information, such as users, location and data transferred.","fork":false,"url":"https://api.github.com/repos/furlongm/openvpn-monitor","forks_url":"https://api.github.com/repos/furlongm/openvpn-monitor/forks","keys_url":"https://api.github.com/repos/furlongm/openvpn-monitor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/furlongm/openvpn-monitor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/furlongm/openvpn-monitor/teams","hooks_url":"https://api.github.com/repos/furlongm/openvpn-monitor/hooks","issue_events_url":"https://api.github.com/repos/furlongm/openvpn-monitor/issues/events{/number}","events_url":"https://api.github.com/repos/furlongm/openvpn-monitor/events","assignees_url":"https://api.github.com/repos/furlongm/openvpn-monitor/assignees{/user}","branches_url":"https://api.github.com/repos/furlongm/openvpn-monitor/branches{/branch}","tags_url":"https://api.github.com/repos/furlongm/openvpn-monitor/tags","blobs_url":"https://api.github.com/repos/furlongm/openvpn-monitor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/furlongm/openvpn-monitor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/furlongm/openvpn-monitor/git/refs{/sha}","trees_url":"https://api.github.com/repos/furlongm/openvpn-monitor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/furlongm/openvpn-monitor/statuses/{sha}","languages_url":"https://api.github.com/repos/furlongm/openvpn-monitor/languages","stargazers_url":"https://api.github.com/repos/furlongm/openvpn-monitor/stargazers","contributors_url":"https://api.github.com/repos/furlongm/openvpn-monitor/contributors","subscribers_url":"https://api.github.com/repos/furlongm/openvpn-monitor/subscribers","subscription_url":"https://api.github.com/repos/furlongm/openvpn-monitor/subscription","commits_url":"https://api.github.com/repos/furlongm/openvpn-monitor/commits{/sha}","git_commits_url":"https://api.github.com/repos/furlongm/openvpn-monitor/git/commits{/sha}","comments_url":"https://api.github.com/repos/furlongm/openvpn-monitor/comments{/number}","issue_comment_url":"https://api.github.com/repos/furlongm/openvpn-monitor/issues/comments{/number}","contents_url":"https://api.github.com/repos/furlongm/openvpn-monitor/contents/{+path}","compare_url":"https://api.github.com/repos/furlongm/openvpn-monitor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/furlongm/openvpn-monitor/merges","archive_url":"https://api.github.com/repos/furlongm/openvpn-monitor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/furlongm/openvpn-monitor/downloads","issues_url":"https://api.github.com/repos/furlongm/openvpn-monitor/issues{/number}","pulls_url":"https://api.github.com/repos/furlongm/openvpn-monitor/pulls{/number}","milestones_url":"https://api.github.com/repos/furlongm/openvpn-monitor/milestones{/number}","notifications_url":"https://api.github.com/repos/furlongm/openvpn-monitor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/furlongm/openvpn-monitor/labels{/name}","releases_url":"https://api.github.com/repos/furlongm/openvpn-monitor/releases{/id}","deployments_url":"https://api.github.com/repos/furlongm/openvpn-monitor/deployments","created_at":"2012-08-17T05:42:42Z","updated_at":"2017-03-20T10:22:13Z","pushed_at":"2017-03-21T02:44:40Z","git_url":"git://github.com/furlongm/openvpn-monitor.git","ssh_url":"git@github.com:furlongm/openvpn-monitor.git","clone_url":"https://github.com/furlongm/openvpn-monitor.git","svn_url":"https://github.com/furlongm/openvpn-monitor","homepage":"http://openvpn-monitor.openbytes.ie","size":1011,"stargazers_count":104,"watchers_count":104,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":43,"mirror_url":null,"open_issues_count":11,"forks":43,"open_issues":11,"watchers":104,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/furlongm/openvpn-monitor/pulls/41"},"html":{"href":"https://github.com/furlongm/openvpn-monitor/pull/41"},"issue":{"href":"https://api.github.com/repos/furlongm/openvpn-monitor/issues/41"},"comments":{"href":"https://api.github.com/repos/furlongm/openvpn-monitor/issues/41/comments"},"review_comments":{"href":"https://api.github.com/repos/furlongm/openvpn-monitor/pulls/41/comments"},"review_comment":{"href":"https://api.github.com/repos/furlongm/openvpn-monitor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/furlongm/openvpn-monitor/pulls/41/commits"},"statuses":{"href":"https://api.github.com/repos/furlongm/openvpn-monitor/statuses/90c15333a19afc4b35666b3e147d1aa0e0e60663"}}}}
{"actor":{"display_login":"codacy-bot"}}