{"action":"created","issue":{"url":"https://api.github.com/repos/prometheus/tsdb/issues/41","repository_url":"https://api.github.com/repos/prometheus/tsdb","labels_url":"https://api.github.com/repos/prometheus/tsdb/issues/41/labels{/name}","comments_url":"https://api.github.com/repos/prometheus/tsdb/issues/41/comments","events_url":"https://api.github.com/repos/prometheus/tsdb/issues/41/events","html_url":"https://github.com/prometheus/tsdb/issues/41","id":221004161,"number":41,"title":"Collisions are likely in headAppender.Add's ref logic","user":{"login":"brian-brazil","id":7115638,"avatar_url":"https://avatars3.githubusercontent.com/u/7115638?v=3","gravatar_id":"","url":"https://api.github.com/users/brian-brazil","html_url":"https://github.com/brian-brazil","followers_url":"https://api.github.com/users/brian-brazil/followers","following_url":"https://api.github.com/users/brian-brazil/following{/other_user}","gists_url":"https://api.github.com/users/brian-brazil/gists{/gist_id}","starred_url":"https://api.github.com/users/brian-brazil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brian-brazil/subscriptions","organizations_url":"https://api.github.com/users/brian-brazil/orgs","repos_url":"https://api.github.com/users/brian-brazil/repos","events_url":"https://api.github.com/users/brian-brazil/events{/privacy}","received_events_url":"https://api.github.com/users/brian-brazil/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-04-11T16:11:58Z","updated_at":"2017-04-17T12:23:53Z","closed_at":null,"body":"https://github.com/prometheus/tsdb/blob/778103b45060697e8452f3d00a6e8fe1f11306da/head.go#L308\r\n\r\nheadAppender.Add uses a 31bit random number to generate refs. A collision is likely at about 64k new series from a target/rule, which is almost certainly going to happen.\r\n\r\nAn approach such as a central counter would be safer, though 31 bits still feels a tad small."},"comment":{"url":"https://api.github.com/repos/prometheus/tsdb/issues/comments/294474704","html_url":"https://github.com/prometheus/tsdb/issues/41#issuecomment-294474704","issue_url":"https://api.github.com/repos/prometheus/tsdb/issues/41","id":294474704,"user":{"login":"brian-brazil","id":7115638,"avatar_url":"https://avatars3.githubusercontent.com/u/7115638?v=3","gravatar_id":"","url":"https://api.github.com/users/brian-brazil","html_url":"https://github.com/brian-brazil","followers_url":"https://api.github.com/users/brian-brazil/followers","following_url":"https://api.github.com/users/brian-brazil/following{/other_user}","gists_url":"https://api.github.com/users/brian-brazil/gists{/gist_id}","starred_url":"https://api.github.com/users/brian-brazil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brian-brazil/subscriptions","organizations_url":"https://api.github.com/users/brian-brazil/orgs","repos_url":"https://api.github.com/users/brian-brazil/repos","events_url":"https://api.github.com/users/brian-brazil/events{/privacy}","received_events_url":"https://api.github.com/users/brian-brazil/received_events","type":"User","site_admin":false},"created_at":"2017-04-17T12:23:53Z","updated_at":"2017-04-17T12:23:53Z","body":"How bad is it just to do the `Add` every time?"}}
{"actor":{"display_login":"brian-brazil"}}