{"action":"opened","number":10,"pull_request":{"url":"https://api.github.com/repos/GlitchCog/ChatGameFontificator/pulls/10","id":122777462,"html_url":"https://github.com/GlitchCog/ChatGameFontificator/pull/10","diff_url":"https://github.com/GlitchCog/ChatGameFontificator/pull/10.diff","patch_url":"https://github.com/GlitchCog/ChatGameFontificator/pull/10.patch","issue_url":"https://api.github.com/repos/GlitchCog/ChatGameFontificator/issues/10","number":10,"state":"open","locked":false,"title":"Fix emoji and supplementary plane display","user":{"login":"broadstone","id":1326425,"avatar_url":"https://avatars2.githubusercontent.com/u/1326425?v=3","gravatar_id":"","url":"https://api.github.com/users/broadstone","html_url":"https://github.com/broadstone","followers_url":"https://api.github.com/users/broadstone/followers","following_url":"https://api.github.com/users/broadstone/following{/other_user}","gists_url":"https://api.github.com/users/broadstone/gists{/gist_id}","starred_url":"https://api.github.com/users/broadstone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadstone/subscriptions","organizations_url":"https://api.github.com/users/broadstone/orgs","repos_url":"https://api.github.com/users/broadstone/repos","events_url":"https://api.github.com/users/broadstone/events{/privacy}","received_events_url":"https://api.github.com/users/broadstone/received_events","type":"User","site_admin":false},"body":"A streamer I watch was getting corrupted output when they had \"<twitchemote><unicode_emoji> \r\n<twitchemote>\" in their chat, but it is actually just a unicode emoji and a twitch emote on the same line.\r\nAs an example, if ⚙️ were a twitch emote named \"cog\", then \"⌨️ cog\" would render as \"￼￼ ️⚙️cog\" \r\n\r\nFirst I wanted to just fix the counting so at least \"⌨️ cog\" would be \"￼￼ ⚙️\".  At least then the output would look OK, just with missing characters.\r\n@growf and I looked at this and @growf contributed a lot of diagnosis.\r\n\r\nThis was the result of unicode emoji being outside the Basic Multilingual Plane.  Also had it happen with some esoteric CJK characters in testing.  Java treats them as two 'chars', a surrogate pair, which threw everything off.\r\n\r\nThis change's goal is to treat stuff as code points as often as possible to make it so we can track things in code point.  So this change draws emoji now too, but also acts better in general.\r\n\r\nTesting is still ongoing to look for more edge cases, but so far this is looking pretty promising.\r\n\r\nCommit message:\r\n=====\r\nThis fixes the display of unicode emoji and other code points living\r\noutside the basic multilingual plane.\r\n\r\nThis is implemented by converting the Sprite Font and Characters to\r\nmostly run on integer code points.\r\n======\r\n","created_at":"2017-05-27T23:07:38Z","updated_at":"2017-05-27T23:07:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/GlitchCog/ChatGameFontificator/pulls/10/commits","review_comments_url":"https://api.github.com/repos/GlitchCog/ChatGameFontificator/pulls/10/comments","review_comment_url":"https://api.github.com/repos/GlitchCog/ChatGameFontificator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GlitchCog/ChatGameFontificator/issues/10/comments","statuses_url":"https://api.github.com/repos/GlitchCog/ChatGameFontificator/statuses/9567e04e7416302b63f2c391607656c3b3e01ec3","head":{"label":"broadstone:unicode_fix","ref":"unicode_fix","sha":"9567e04e7416302b63f2c391607656c3b3e01ec3","user":{"login":"broadstone","id":1326425,"avatar_url":"https://avatars2.githubusercontent.com/u/1326425?v=3","gravatar_id":"","url":"https://api.github.com/users/broadstone","html_url":"https://github.com/broadstone","followers_url":"https://api.github.com/users/broadstone/followers","following_url":"https://api.github.com/users/broadstone/following{/other_user}","gists_url":"https://api.github.com/users/broadstone/gists{/gist_id}","starred_url":"https://api.github.com/users/broadstone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadstone/subscriptions","organizations_url":"https://api.github.com/users/broadstone/orgs","repos_url":"https://api.github.com/users/broadstone/repos","events_url":"https://api.github.com/users/broadstone/events{/privacy}","received_events_url":"https://api.github.com/users/broadstone/received_events","type":"User","site_admin":false},"repo":{"id":91912837,"name":"ChatGameFontificator","full_name":"broadstone/ChatGameFontificator","owner":{"login":"broadstone","id":1326425,"avatar_url":"https://avatars2.githubusercontent.com/u/1326425?v=3","gravatar_id":"","url":"https://api.github.com/users/broadstone","html_url":"https://github.com/broadstone","followers_url":"https://api.github.com/users/broadstone/followers","following_url":"https://api.github.com/users/broadstone/following{/other_user}","gists_url":"https://api.github.com/users/broadstone/gists{/gist_id}","starred_url":"https://api.github.com/users/broadstone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadstone/subscriptions","organizations_url":"https://api.github.com/users/broadstone/orgs","repos_url":"https://api.github.com/users/broadstone/repos","events_url":"https://api.github.com/users/broadstone/events{/privacy}","received_events_url":"https://api.github.com/users/broadstone/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/broadstone/ChatGameFontificator","description":"A Twitch chat display that uses the fonts of various video games","fork":true,"url":"https://api.github.com/repos/broadstone/ChatGameFontificator","forks_url":"https://api.github.com/repos/broadstone/ChatGameFontificator/forks","keys_url":"https://api.github.com/repos/broadstone/ChatGameFontificator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/broadstone/ChatGameFontificator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/broadstone/ChatGameFontificator/teams","hooks_url":"https://api.github.com/repos/broadstone/ChatGameFontificator/hooks","issue_events_url":"https://api.github.com/repos/broadstone/ChatGameFontificator/issues/events{/number}","events_url":"https://api.github.com/repos/broadstone/ChatGameFontificator/events","assignees_url":"https://api.github.com/repos/broadstone/ChatGameFontificator/assignees{/user}","branches_url":"https://api.github.com/repos/broadstone/ChatGameFontificator/branches{/branch}","tags_url":"https://api.github.com/repos/broadstone/ChatGameFontificator/tags","blobs_url":"https://api.github.com/repos/broadstone/ChatGameFontificator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/broadstone/ChatGameFontificator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/broadstone/ChatGameFontificator/git/refs{/sha}","trees_url":"https://api.github.com/repos/broadstone/ChatGameFontificator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/broadstone/ChatGameFontificator/statuses/{sha}","languages_url":"https://api.github.com/repos/broadstone/ChatGameFontificator/languages","stargazers_url":"https://api.github.com/repos/broadstone/ChatGameFontificator/stargazers","contributors_url":"https://api.github.com/repos/broadstone/ChatGameFontificator/contributors","subscribers_url":"https://api.github.com/repos/broadstone/ChatGameFontificator/subscribers","subscription_url":"https://api.github.com/repos/broadstone/ChatGameFontificator/subscription","commits_url":"https://api.github.com/repos/broadstone/ChatGameFontificator/commits{/sha}","git_commits_url":"https://api.github.com/repos/broadstone/ChatGameFontificator/git/commits{/sha}","comments_url":"https://api.github.com/repos/broadstone/ChatGameFontificator/comments{/number}","issue_comment_url":"https://api.github.com/repos/broadstone/ChatGameFontificator/issues/comments{/number}","contents_url":"https://api.github.com/repos/broadstone/ChatGameFontificator/contents/{+path}","compare_url":"https://api.github.com/repos/broadstone/ChatGameFontificator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/broadstone/ChatGameFontificator/merges","archive_url":"https://api.github.com/repos/broadstone/ChatGameFontificator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/broadstone/ChatGameFontificator/downloads","issues_url":"https://api.github.com/repos/broadstone/ChatGameFontificator/issues{/number}","pulls_url":"https://api.github.com/repos/broadstone/ChatGameFontificator/pulls{/number}","milestones_url":"https://api.github.com/repos/broadstone/ChatGameFontificator/milestones{/number}","notifications_url":"https://api.github.com/repos/broadstone/ChatGameFontificator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/broadstone/ChatGameFontificator/labels{/name}","releases_url":"https://api.github.com/repos/broadstone/ChatGameFontificator/releases{/id}","deployments_url":"https://api.github.com/repos/broadstone/ChatGameFontificator/deployments","created_at":"2017-05-20T19:53:16Z","updated_at":"2017-05-20T19:53:18Z","pushed_at":"2017-05-27T22:47:25Z","git_url":"git://github.com/broadstone/ChatGameFontificator.git","ssh_url":"git@github.com:broadstone/ChatGameFontificator.git","clone_url":"https://github.com/broadstone/ChatGameFontificator.git","svn_url":"https://github.com/broadstone/ChatGameFontificator","homepage":"","size":21213,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GlitchCog:master","ref":"master","sha":"546ecd8d19c2eec1760abc64a204d10118474ee9","user":{"login":"GlitchCog","id":3694723,"avatar_url":"https://avatars2.githubusercontent.com/u/3694723?v=3","gravatar_id":"","url":"https://api.github.com/users/GlitchCog","html_url":"https://github.com/GlitchCog","followers_url":"https://api.github.com/users/GlitchCog/followers","following_url":"https://api.github.com/users/GlitchCog/following{/other_user}","gists_url":"https://api.github.com/users/GlitchCog/gists{/gist_id}","starred_url":"https://api.github.com/users/GlitchCog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GlitchCog/subscriptions","organizations_url":"https://api.github.com/users/GlitchCog/orgs","repos_url":"https://api.github.com/users/GlitchCog/repos","events_url":"https://api.github.com/users/GlitchCog/events{/privacy}","received_events_url":"https://api.github.com/users/GlitchCog/received_events","type":"User","site_admin":false},"repo":{"id":36542287,"name":"ChatGameFontificator","full_name":"GlitchCog/ChatGameFontificator","owner":{"login":"GlitchCog","id":3694723,"avatar_url":"https://avatars2.githubusercontent.com/u/3694723?v=3","gravatar_id":"","url":"https://api.github.com/users/GlitchCog","html_url":"https://github.com/GlitchCog","followers_url":"https://api.github.com/users/GlitchCog/followers","following_url":"https://api.github.com/users/GlitchCog/following{/other_user}","gists_url":"https://api.github.com/users/GlitchCog/gists{/gist_id}","starred_url":"https://api.github.com/users/GlitchCog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GlitchCog/subscriptions","organizations_url":"https://api.github.com/users/GlitchCog/orgs","repos_url":"https://api.github.com/users/GlitchCog/repos","events_url":"https://api.github.com/users/GlitchCog/events{/privacy}","received_events_url":"https://api.github.com/users/GlitchCog/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/GlitchCog/ChatGameFontificator","description":"A Twitch chat display that uses the fonts of various video games","fork":false,"url":"https://api.github.com/repos/GlitchCog/ChatGameFontificator","forks_url":"https://api.github.com/repos/GlitchCog/ChatGameFontificator/forks","keys_url":"https://api.github.com/repos/GlitchCog/ChatGameFontificator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GlitchCog/ChatGameFontificator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GlitchCog/ChatGameFontificator/teams","hooks_url":"https://api.github.com/repos/GlitchCog/ChatGameFontificator/hooks","issue_events_url":"https://api.github.com/repos/GlitchCog/ChatGameFontificator/issues/events{/number}","events_url":"https://api.github.com/repos/GlitchCog/ChatGameFontificator/events","assignees_url":"https://api.github.com/repos/GlitchCog/ChatGameFontificator/assignees{/user}","branches_url":"https://api.github.com/repos/GlitchCog/ChatGameFontificator/branches{/branch}","tags_url":"https://api.github.com/repos/GlitchCog/ChatGameFontificator/tags","blobs_url":"https://api.github.com/repos/GlitchCog/ChatGameFontificator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GlitchCog/ChatGameFontificator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GlitchCog/ChatGameFontificator/git/refs{/sha}","trees_url":"https://api.github.com/repos/GlitchCog/ChatGameFontificator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GlitchCog/ChatGameFontificator/statuses/{sha}","languages_url":"https://api.github.com/repos/GlitchCog/ChatGameFontificator/languages","stargazers_url":"https://api.github.com/repos/GlitchCog/ChatGameFontificator/stargazers","contributors_url":"https://api.github.com/repos/GlitchCog/ChatGameFontificator/contributors","subscribers_url":"https://api.github.com/repos/GlitchCog/ChatGameFontificator/subscribers","subscription_url":"https://api.github.com/repos/GlitchCog/ChatGameFontificator/subscription","commits_url":"https://api.github.com/repos/GlitchCog/ChatGameFontificator/commits{/sha}","git_commits_url":"https://api.github.com/repos/GlitchCog/ChatGameFontificator/git/commits{/sha}","comments_url":"https://api.github.com/repos/GlitchCog/ChatGameFontificator/comments{/number}","issue_comment_url":"https://api.github.com/repos/GlitchCog/ChatGameFontificator/issues/comments{/number}","contents_url":"https://api.github.com/repos/GlitchCog/ChatGameFontificator/contents/{+path}","compare_url":"https://api.github.com/repos/GlitchCog/ChatGameFontificator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GlitchCog/ChatGameFontificator/merges","archive_url":"https://api.github.com/repos/GlitchCog/ChatGameFontificator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GlitchCog/ChatGameFontificator/downloads","issues_url":"https://api.github.com/repos/GlitchCog/ChatGameFontificator/issues{/number}","pulls_url":"https://api.github.com/repos/GlitchCog/ChatGameFontificator/pulls{/number}","milestones_url":"https://api.github.com/repos/GlitchCog/ChatGameFontificator/milestones{/number}","notifications_url":"https://api.github.com/repos/GlitchCog/ChatGameFontificator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GlitchCog/ChatGameFontificator/labels{/name}","releases_url":"https://api.github.com/repos/GlitchCog/ChatGameFontificator/releases{/id}","deployments_url":"https://api.github.com/repos/GlitchCog/ChatGameFontificator/deployments","created_at":"2015-05-30T03:59:04Z","updated_at":"2017-04-08T20:57:41Z","pushed_at":"2017-05-07T11:47:43Z","git_url":"git://github.com/GlitchCog/ChatGameFontificator.git","ssh_url":"git@github.com:GlitchCog/ChatGameFontificator.git","clone_url":"https://github.com/GlitchCog/ChatGameFontificator.git","svn_url":"https://github.com/GlitchCog/ChatGameFontificator","homepage":"","size":21213,"stargazers_count":21,"watchers_count":21,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GlitchCog/ChatGameFontificator/pulls/10"},"html":{"href":"https://github.com/GlitchCog/ChatGameFontificator/pull/10"},"issue":{"href":"https://api.github.com/repos/GlitchCog/ChatGameFontificator/issues/10"},"comments":{"href":"https://api.github.com/repos/GlitchCog/ChatGameFontificator/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/GlitchCog/ChatGameFontificator/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/GlitchCog/ChatGameFontificator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GlitchCog/ChatGameFontificator/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/GlitchCog/ChatGameFontificator/statuses/9567e04e7416302b63f2c391607656c3b3e01ec3"}},"merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":52,"deletions":30,"changed_files":3}}
{"actor":{"display_login":"broadstone"}}