{"action":"reopened","number":20306,"pull_request":{"url":"https://api.github.com/repos/angular/angular/pulls/20306","id":151733885,"html_url":"https://github.com/angular/angular/pull/20306","diff_url":"https://github.com/angular/angular/pull/20306.diff","patch_url":"https://github.com/angular/angular/pull/20306.patch","issue_url":"https://api.github.com/repos/angular/angular/issues/20306","number":20306,"state":"open","locked":false,"title":"[WIP]docs(aio): add NgModule docs","user":{"login":"kapunahelewong","id":4116963,"avatar_url":"https://avatars1.githubusercontent.com/u/4116963?v=4","gravatar_id":"","url":"https://api.github.com/users/kapunahelewong","html_url":"https://github.com/kapunahelewong","followers_url":"https://api.github.com/users/kapunahelewong/followers","following_url":"https://api.github.com/users/kapunahelewong/following{/other_user}","gists_url":"https://api.github.com/users/kapunahelewong/gists{/gist_id}","starred_url":"https://api.github.com/users/kapunahelewong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kapunahelewong/subscriptions","organizations_url":"https://api.github.com/users/kapunahelewong/orgs","repos_url":"https://api.github.com/users/kapunahelewong/repos","events_url":"https://api.github.com/users/kapunahelewong/events{/privacy}","received_events_url":"https://api.github.com/users/kapunahelewong/received_events","type":"User","site_admin":false},"body":"## PR Checklist\r\nPlease check if your PR fulfills the following requirements:\r\n\r\n- [x] The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit\r\n- [ ] Tests for the changes have been added (for bug fixes / features)\r\n- [x] Docs have been added / updated (for bug fixes / features)\r\n\r\n\r\n## PR Type\r\nWhat kind of change does this PR introduce?\r\n\r\n<!-- Please check the one that applies to this PR using \"x\". -->\r\n```\r\n[ ] Bugfix\r\n[ ] Feature\r\n[ ] Code style update (formatting, local variables)\r\n[ ] Refactoring (no functional changes, no api changes)\r\n[ ] Build related changes\r\n[ ] CI related changes\r\n[x] Documentation content changes\r\n[ ] angular.io application / infrastructure changes\r\n[ ] Other... Please describe:\r\n```\r\n\r\n## What is the current behavior?\r\n<!-- Please describe the current behavior that you are modifying, or link to a relevant issue. -->\r\nNgModules info is in two docs.\r\nIssue Number: N/A\r\n\r\n\r\n## What is the new behavior?\r\nNgModules is broken up by topic.\r\n\r\n## Does this PR introduce a breaking change?\r\n```\r\n[ ] Yes\r\n[x] No\r\n```\r\n\r\n<!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. -->\r\n\r\n\r\n## Other information\r\nStill have to do the e2e tests for the examples.","created_at":"2017-11-09T18:55:40Z","updated_at":"2017-11-28T13:05:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4ca04a2233c54e2c7914fb2bded9f83e6b9d3079","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/angular/angular/pulls/20306/commits","review_comments_url":"https://api.github.com/repos/angular/angular/pulls/20306/comments","review_comment_url":"https://api.github.com/repos/angular/angular/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/angular/issues/20306/comments","statuses_url":"https://api.github.com/repos/angular/angular/statuses/6a8e69fdb0ffce7969cdac5a065bac3868a0253a","head":{"label":"ExpertSupport:wong-ngmodules","ref":"wong-ngmodules","sha":"6a8e69fdb0ffce7969cdac5a065bac3868a0253a","user":{"login":"ExpertSupport","id":32309326,"avatar_url":"https://avatars3.githubusercontent.com/u/32309326?v=4","gravatar_id":"","url":"https://api.github.com/users/ExpertSupport","html_url":"https://github.com/ExpertSupport","followers_url":"https://api.github.com/users/ExpertSupport/followers","following_url":"https://api.github.com/users/ExpertSupport/following{/other_user}","gists_url":"https://api.github.com/users/ExpertSupport/gists{/gist_id}","starred_url":"https://api.github.com/users/ExpertSupport/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ExpertSupport/subscriptions","organizations_url":"https://api.github.com/users/ExpertSupport/orgs","repos_url":"https://api.github.com/users/ExpertSupport/repos","events_url":"https://api.github.com/users/ExpertSupport/events{/privacy}","received_events_url":"https://api.github.com/users/ExpertSupport/received_events","type":"Organization","site_admin":false},"repo":{"id":104923967,"name":"angular","full_name":"ExpertSupport/angular","owner":{"login":"ExpertSupport","id":32309326,"avatar_url":"https://avatars3.githubusercontent.com/u/32309326?v=4","gravatar_id":"","url":"https://api.github.com/users/ExpertSupport","html_url":"https://github.com/ExpertSupport","followers_url":"https://api.github.com/users/ExpertSupport/followers","following_url":"https://api.github.com/users/ExpertSupport/following{/other_user}","gists_url":"https://api.github.com/users/ExpertSupport/gists{/gist_id}","starred_url":"https://api.github.com/users/ExpertSupport/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ExpertSupport/subscriptions","organizations_url":"https://api.github.com/users/ExpertSupport/orgs","repos_url":"https://api.github.com/users/ExpertSupport/repos","events_url":"https://api.github.com/users/ExpertSupport/events{/privacy}","received_events_url":"https://api.github.com/users/ExpertSupport/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ExpertSupport/angular","description":"One framework. Mobile & desktop.","fork":true,"url":"https://api.github.com/repos/ExpertSupport/angular","forks_url":"https://api.github.com/repos/ExpertSupport/angular/forks","keys_url":"https://api.github.com/repos/ExpertSupport/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ExpertSupport/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ExpertSupport/angular/teams","hooks_url":"https://api.github.com/repos/ExpertSupport/angular/hooks","issue_events_url":"https://api.github.com/repos/ExpertSupport/angular/issues/events{/number}","events_url":"https://api.github.com/repos/ExpertSupport/angular/events","assignees_url":"https://api.github.com/repos/ExpertSupport/angular/assignees{/user}","branches_url":"https://api.github.com/repos/ExpertSupport/angular/branches{/branch}","tags_url":"https://api.github.com/repos/ExpertSupport/angular/tags","blobs_url":"https://api.github.com/repos/ExpertSupport/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ExpertSupport/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ExpertSupport/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/ExpertSupport/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ExpertSupport/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/ExpertSupport/angular/languages","stargazers_url":"https://api.github.com/repos/ExpertSupport/angular/stargazers","contributors_url":"https://api.github.com/repos/ExpertSupport/angular/contributors","subscribers_url":"https://api.github.com/repos/ExpertSupport/angular/subscribers","subscription_url":"https://api.github.com/repos/ExpertSupport/angular/subscription","commits_url":"https://api.github.com/repos/ExpertSupport/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/ExpertSupport/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/ExpertSupport/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/ExpertSupport/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/ExpertSupport/angular/contents/{+path}","compare_url":"https://api.github.com/repos/ExpertSupport/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ExpertSupport/angular/merges","archive_url":"https://api.github.com/repos/ExpertSupport/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ExpertSupport/angular/downloads","issues_url":"https://api.github.com/repos/ExpertSupport/angular/issues{/number}","pulls_url":"https://api.github.com/repos/ExpertSupport/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/ExpertSupport/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/ExpertSupport/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ExpertSupport/angular/labels{/name}","releases_url":"https://api.github.com/repos/ExpertSupport/angular/releases{/id}","deployments_url":"https://api.github.com/repos/ExpertSupport/angular/deployments","created_at":"2017-09-26T18:39:15Z","updated_at":"2017-10-30T20:07:04Z","pushed_at":"2017-11-27T23:33:58Z","git_url":"git://github.com/ExpertSupport/angular.git","ssh_url":"git@github.com:ExpertSupport/angular.git","clone_url":"https://github.com/ExpertSupport/angular.git","svn_url":"https://github.com/ExpertSupport/angular","homepage":"https://angular.io","size":69747,"stargazers_count":1,"watchers_count":1,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"6e83204238952dca1092d0d87f110dbd680ee16e","user":{"login":"angular","id":139426,"avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":24195339,"name":"angular","full_name":"angular/angular","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/angular","description":"One framework. Mobile & desktop.","fork":false,"url":"https://api.github.com/repos/angular/angular","forks_url":"https://api.github.com/repos/angular/angular/forks","keys_url":"https://api.github.com/repos/angular/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/angular/teams","hooks_url":"https://api.github.com/repos/angular/angular/hooks","issue_events_url":"https://api.github.com/repos/angular/angular/issues/events{/number}","events_url":"https://api.github.com/repos/angular/angular/events","assignees_url":"https://api.github.com/repos/angular/angular/assignees{/user}","branches_url":"https://api.github.com/repos/angular/angular/branches{/branch}","tags_url":"https://api.github.com/repos/angular/angular/tags","blobs_url":"https://api.github.com/repos/angular/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/angular/languages","stargazers_url":"https://api.github.com/repos/angular/angular/stargazers","contributors_url":"https://api.github.com/repos/angular/angular/contributors","subscribers_url":"https://api.github.com/repos/angular/angular/subscribers","subscription_url":"https://api.github.com/repos/angular/angular/subscription","commits_url":"https://api.github.com/repos/angular/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/angular/contents/{+path}","compare_url":"https://api.github.com/repos/angular/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/angular/merges","archive_url":"https://api.github.com/repos/angular/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/angular/downloads","issues_url":"https://api.github.com/repos/angular/angular/issues{/number}","pulls_url":"https://api.github.com/repos/angular/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/angular/labels{/name}","releases_url":"https://api.github.com/repos/angular/angular/releases{/id}","deployments_url":"https://api.github.com/repos/angular/angular/deployments","created_at":"2014-09-18T16:12:01Z","updated_at":"2017-11-28T12:56:57Z","pushed_at":"2017-11-28T12:39:38Z","git_url":"git://github.com/angular/angular.git","ssh_url":"git@github.com:angular/angular.git","clone_url":"https://github.com/angular/angular.git","svn_url":"https://github.com/angular/angular","homepage":"https://angular.io","size":69377,"stargazers_count":30479,"watchers_count":30479,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7575,"mirror_url":null,"archived":false,"open_issues_count":2266,"forks":7575,"open_issues":2266,"watchers":30479,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/20306"},"html":{"href":"https://github.com/angular/angular/pull/20306"},"issue":{"href":"https://api.github.com/repos/angular/angular/issues/20306"},"comments":{"href":"https://api.github.com/repos/angular/angular/issues/20306/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/angular/pulls/20306/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/angular/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/angular/pulls/20306/commits"},"statuses":{"href":"https://api.github.com/repos/angular/angular/statuses/6a8e69fdb0ffce7969cdac5a065bac3868a0253a"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":26,"maintainer_can_modify":true,"commits":1,"additions":3343,"deletions":3909,"changed_files":182}}
{"actor":{"display_login":"gkalpak"}}