{"action":"created","comment":{"url":"https://api.github.com/repos/product-definition-center/pdc-client/pulls/comments/141545049","pull_request_review_id":65773333,"id":141545049,"diff_hunk":"@@ -110,14 +110,19 @@ def load_plugins(self):\n             for name in os.listdir(dir):\n                 if not name.endswith('.py') or name not in plugins_set:\n                     continue\n-                file, pathname, description = imp.find_module(name[:-3], [dir])\n-                plugin = imp.load_module(name[:-3], file, pathname, description)\n-                self.logger.debug('Loaded plugin {0}'.format(name[:-3]))\n-                self.raw_plugins.append(plugin)\n-                if hasattr(plugin, 'PLUGIN_CLASSES'):\n-                    for p in plugin.PLUGIN_CLASSES:\n-                        self.logger.debug('Instantiating {0}'.format(p.__name__))\n-                        self.plugins.append(p(self))\n+                try:\n+                    file, pathname, description = imp.find_module(name[:-3], [dir])\n+                    plugin = imp.load_module(name[:-3], file, pathname, description)\n+                    self.logger.debug('Loaded plugin {0}'.format(name[:-3]))\n+                    self.raw_plugins.append(plugin)\n+                    if hasattr(plugin, 'PLUGIN_CLASSES'):\n+                        for p in plugin.PLUGIN_CLASSES:\n+                            self.logger.debug('Instantiating {0}'.format(p.__name__))\n+                            self.plugins.append(p(self))\n+                except:\n+                    print('Failed to init plugin %s.' % name[:-3])","path":"pdc_client/runner.py","position":22,"original_position":22,"commit_id":"455e1ac317bbe4054a2bf56e7f2341a0594402bb","original_commit_id":"455e1ac317bbe4054a2bf56e7f2341a0594402bb","user":{"login":"simozhan","id":1744192,"avatar_url":"https://avatars0.githubusercontent.com/u/1744192?v=4","gravatar_id":"","url":"https://api.github.com/users/simozhan","html_url":"https://github.com/simozhan","followers_url":"https://api.github.com/users/simozhan/followers","following_url":"https://api.github.com/users/simozhan/following{/other_user}","gists_url":"https://api.github.com/users/simozhan/gists{/gist_id}","starred_url":"https://api.github.com/users/simozhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simozhan/subscriptions","organizations_url":"https://api.github.com/users/simozhan/orgs","repos_url":"https://api.github.com/users/simozhan/repos","events_url":"https://api.github.com/users/simozhan/events{/privacy}","received_events_url":"https://api.github.com/users/simozhan/received_events","type":"User","site_admin":false},"body":"1. Maybe 'Failed to load plugin'\r\n2. Is it ok to make consistent style with other log, like 'Loaded plugin {0}'.format...","created_at":"2017-09-28T07:35:50Z","updated_at":"2017-09-28T07:36:00Z","html_url":"https://github.com/product-definition-center/pdc-client/pull/131#discussion_r141545049","pull_request_url":"https://api.github.com/repos/product-definition-center/pdc-client/pulls/131","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/product-definition-center/pdc-client/pulls/comments/141545049"},"html":{"href":"https://github.com/product-definition-center/pdc-client/pull/131#discussion_r141545049"},"pull_request":{"href":"https://api.github.com/repos/product-definition-center/pdc-client/pulls/131"}}},"pull_request":{"url":"https://api.github.com/repos/product-definition-center/pdc-client/pulls/131","id":143565019,"html_url":"https://github.com/product-definition-center/pdc-client/pull/131","diff_url":"https://github.com/product-definition-center/pdc-client/pull/131.diff","patch_url":"https://github.com/product-definition-center/pdc-client/pull/131.patch","issue_url":"https://api.github.com/repos/product-definition-center/pdc-client/issues/131","number":131,"state":"open","locked":false,"title":"Add the close function when load plugins","user":{"login":"xiangge","id":2434694,"avatar_url":"https://avatars1.githubusercontent.com/u/2434694?v=4","gravatar_id":"","url":"https://api.github.com/users/xiangge","html_url":"https://github.com/xiangge","followers_url":"https://api.github.com/users/xiangge/followers","following_url":"https://api.github.com/users/xiangge/following{/other_user}","gists_url":"https://api.github.com/users/xiangge/gists{/gist_id}","starred_url":"https://api.github.com/users/xiangge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiangge/subscriptions","organizations_url":"https://api.github.com/users/xiangge/orgs","repos_url":"https://api.github.com/users/xiangge/repos","events_url":"https://api.github.com/users/xiangge/events{/privacy}","received_events_url":"https://api.github.com/users/xiangge/received_events","type":"User","site_admin":false},"body":"Add the close function when load plugins\r\nJIRA: PDC-2235","created_at":"2017-09-28T06:30:05Z","updated_at":"2017-09-28T07:36:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"456ade19b61f7b89460720d10301c20267d9d284","assignee":null,"assignees":[],"requested_reviewers":[{"login":"hluk","id":38054,"avatar_url":"https://avatars1.githubusercontent.com/u/38054?v=4","gravatar_id":"","url":"https://api.github.com/users/hluk","html_url":"https://github.com/hluk","followers_url":"https://api.github.com/users/hluk/followers","following_url":"https://api.github.com/users/hluk/following{/other_user}","gists_url":"https://api.github.com/users/hluk/gists{/gist_id}","starred_url":"https://api.github.com/users/hluk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hluk/subscriptions","organizations_url":"https://api.github.com/users/hluk/orgs","repos_url":"https://api.github.com/users/hluk/repos","events_url":"https://api.github.com/users/hluk/events{/privacy}","received_events_url":"https://api.github.com/users/hluk/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/product-definition-center/pdc-client/pulls/131/commits","review_comments_url":"https://api.github.com/repos/product-definition-center/pdc-client/pulls/131/comments","review_comment_url":"https://api.github.com/repos/product-definition-center/pdc-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/product-definition-center/pdc-client/issues/131/comments","statuses_url":"https://api.github.com/repos/product-definition-center/pdc-client/statuses/455e1ac317bbe4054a2bf56e7f2341a0594402bb","head":{"label":"product-definition-center:pdc-client-2235","ref":"pdc-client-2235","sha":"455e1ac317bbe4054a2bf56e7f2341a0594402bb","user":{"login":"product-definition-center","id":15812210,"avatar_url":"https://avatars3.githubusercontent.com/u/15812210?v=4","gravatar_id":"","url":"https://api.github.com/users/product-definition-center","html_url":"https://github.com/product-definition-center","followers_url":"https://api.github.com/users/product-definition-center/followers","following_url":"https://api.github.com/users/product-definition-center/following{/other_user}","gists_url":"https://api.github.com/users/product-definition-center/gists{/gist_id}","starred_url":"https://api.github.com/users/product-definition-center/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/product-definition-center/subscriptions","organizations_url":"https://api.github.com/users/product-definition-center/orgs","repos_url":"https://api.github.com/users/product-definition-center/repos","events_url":"https://api.github.com/users/product-definition-center/events{/privacy}","received_events_url":"https://api.github.com/users/product-definition-center/received_events","type":"Organization","site_admin":false},"repo":{"id":46246883,"name":"pdc-client","full_name":"product-definition-center/pdc-client","owner":{"login":"product-definition-center","id":15812210,"avatar_url":"https://avatars3.githubusercontent.com/u/15812210?v=4","gravatar_id":"","url":"https://api.github.com/users/product-definition-center","html_url":"https://github.com/product-definition-center","followers_url":"https://api.github.com/users/product-definition-center/followers","following_url":"https://api.github.com/users/product-definition-center/following{/other_user}","gists_url":"https://api.github.com/users/product-definition-center/gists{/gist_id}","starred_url":"https://api.github.com/users/product-definition-center/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/product-definition-center/subscriptions","organizations_url":"https://api.github.com/users/product-definition-center/orgs","repos_url":"https://api.github.com/users/product-definition-center/repos","events_url":"https://api.github.com/users/product-definition-center/events{/privacy}","received_events_url":"https://api.github.com/users/product-definition-center/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/product-definition-center/pdc-client","description":"Client for Product Definition Center (PDC) in Python","fork":false,"url":"https://api.github.com/repos/product-definition-center/pdc-client","forks_url":"https://api.github.com/repos/product-definition-center/pdc-client/forks","keys_url":"https://api.github.com/repos/product-definition-center/pdc-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/product-definition-center/pdc-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/product-definition-center/pdc-client/teams","hooks_url":"https://api.github.com/repos/product-definition-center/pdc-client/hooks","issue_events_url":"https://api.github.com/repos/product-definition-center/pdc-client/issues/events{/number}","events_url":"https://api.github.com/repos/product-definition-center/pdc-client/events","assignees_url":"https://api.github.com/repos/product-definition-center/pdc-client/assignees{/user}","branches_url":"https://api.github.com/repos/product-definition-center/pdc-client/branches{/branch}","tags_url":"https://api.github.com/repos/product-definition-center/pdc-client/tags","blobs_url":"https://api.github.com/repos/product-definition-center/pdc-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/product-definition-center/pdc-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/product-definition-center/pdc-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/product-definition-center/pdc-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/product-definition-center/pdc-client/statuses/{sha}","languages_url":"https://api.github.com/repos/product-definition-center/pdc-client/languages","stargazers_url":"https://api.github.com/repos/product-definition-center/pdc-client/stargazers","contributors_url":"https://api.github.com/repos/product-definition-center/pdc-client/contributors","subscribers_url":"https://api.github.com/repos/product-definition-center/pdc-client/subscribers","subscription_url":"https://api.github.com/repos/product-definition-center/pdc-client/subscription","commits_url":"https://api.github.com/repos/product-definition-center/pdc-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/product-definition-center/pdc-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/product-definition-center/pdc-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/product-definition-center/pdc-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/product-definition-center/pdc-client/contents/{+path}","compare_url":"https://api.github.com/repos/product-definition-center/pdc-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/product-definition-center/pdc-client/merges","archive_url":"https://api.github.com/repos/product-definition-center/pdc-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/product-definition-center/pdc-client/downloads","issues_url":"https://api.github.com/repos/product-definition-center/pdc-client/issues{/number}","pulls_url":"https://api.github.com/repos/product-definition-center/pdc-client/pulls{/number}","milestones_url":"https://api.github.com/repos/product-definition-center/pdc-client/milestones{/number}","notifications_url":"https://api.github.com/repos/product-definition-center/pdc-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/product-definition-center/pdc-client/labels{/name}","releases_url":"https://api.github.com/repos/product-definition-center/pdc-client/releases{/id}","deployments_url":"https://api.github.com/repos/product-definition-center/pdc-client/deployments","created_at":"2015-11-16T02:23:01Z","updated_at":"2017-04-04T19:38:22Z","pushed_at":"2017-09-28T06:30:06Z","git_url":"git://github.com/product-definition-center/pdc-client.git","ssh_url":"git@github.com:product-definition-center/pdc-client.git","clone_url":"https://github.com/product-definition-center/pdc-client.git","svn_url":"https://github.com/product-definition-center/pdc-client","homepage":"","size":780,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":14,"mirror_url":null,"open_issues_count":6,"forks":14,"open_issues":6,"watchers":4,"default_branch":"master"}},"base":{"label":"product-definition-center:master","ref":"master","sha":"1616a5a666f588a46f86b55b458a9d057d7f2cbe","user":{"login":"product-definition-center","id":15812210,"avatar_url":"https://avatars3.githubusercontent.com/u/15812210?v=4","gravatar_id":"","url":"https://api.github.com/users/product-definition-center","html_url":"https://github.com/product-definition-center","followers_url":"https://api.github.com/users/product-definition-center/followers","following_url":"https://api.github.com/users/product-definition-center/following{/other_user}","gists_url":"https://api.github.com/users/product-definition-center/gists{/gist_id}","starred_url":"https://api.github.com/users/product-definition-center/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/product-definition-center/subscriptions","organizations_url":"https://api.github.com/users/product-definition-center/orgs","repos_url":"https://api.github.com/users/product-definition-center/repos","events_url":"https://api.github.com/users/product-definition-center/events{/privacy}","received_events_url":"https://api.github.com/users/product-definition-center/received_events","type":"Organization","site_admin":false},"repo":{"id":46246883,"name":"pdc-client","full_name":"product-definition-center/pdc-client","owner":{"login":"product-definition-center","id":15812210,"avatar_url":"https://avatars3.githubusercontent.com/u/15812210?v=4","gravatar_id":"","url":"https://api.github.com/users/product-definition-center","html_url":"https://github.com/product-definition-center","followers_url":"https://api.github.com/users/product-definition-center/followers","following_url":"https://api.github.com/users/product-definition-center/following{/other_user}","gists_url":"https://api.github.com/users/product-definition-center/gists{/gist_id}","starred_url":"https://api.github.com/users/product-definition-center/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/product-definition-center/subscriptions","organizations_url":"https://api.github.com/users/product-definition-center/orgs","repos_url":"https://api.github.com/users/product-definition-center/repos","events_url":"https://api.github.com/users/product-definition-center/events{/privacy}","received_events_url":"https://api.github.com/users/product-definition-center/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/product-definition-center/pdc-client","description":"Client for Product Definition Center (PDC) in Python","fork":false,"url":"https://api.github.com/repos/product-definition-center/pdc-client","forks_url":"https://api.github.com/repos/product-definition-center/pdc-client/forks","keys_url":"https://api.github.com/repos/product-definition-center/pdc-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/product-definition-center/pdc-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/product-definition-center/pdc-client/teams","hooks_url":"https://api.github.com/repos/product-definition-center/pdc-client/hooks","issue_events_url":"https://api.github.com/repos/product-definition-center/pdc-client/issues/events{/number}","events_url":"https://api.github.com/repos/product-definition-center/pdc-client/events","assignees_url":"https://api.github.com/repos/product-definition-center/pdc-client/assignees{/user}","branches_url":"https://api.github.com/repos/product-definition-center/pdc-client/branches{/branch}","tags_url":"https://api.github.com/repos/product-definition-center/pdc-client/tags","blobs_url":"https://api.github.com/repos/product-definition-center/pdc-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/product-definition-center/pdc-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/product-definition-center/pdc-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/product-definition-center/pdc-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/product-definition-center/pdc-client/statuses/{sha}","languages_url":"https://api.github.com/repos/product-definition-center/pdc-client/languages","stargazers_url":"https://api.github.com/repos/product-definition-center/pdc-client/stargazers","contributors_url":"https://api.github.com/repos/product-definition-center/pdc-client/contributors","subscribers_url":"https://api.github.com/repos/product-definition-center/pdc-client/subscribers","subscription_url":"https://api.github.com/repos/product-definition-center/pdc-client/subscription","commits_url":"https://api.github.com/repos/product-definition-center/pdc-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/product-definition-center/pdc-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/product-definition-center/pdc-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/product-definition-center/pdc-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/product-definition-center/pdc-client/contents/{+path}","compare_url":"https://api.github.com/repos/product-definition-center/pdc-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/product-definition-center/pdc-client/merges","archive_url":"https://api.github.com/repos/product-definition-center/pdc-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/product-definition-center/pdc-client/downloads","issues_url":"https://api.github.com/repos/product-definition-center/pdc-client/issues{/number}","pulls_url":"https://api.github.com/repos/product-definition-center/pdc-client/pulls{/number}","milestones_url":"https://api.github.com/repos/product-definition-center/pdc-client/milestones{/number}","notifications_url":"https://api.github.com/repos/product-definition-center/pdc-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/product-definition-center/pdc-client/labels{/name}","releases_url":"https://api.github.com/repos/product-definition-center/pdc-client/releases{/id}","deployments_url":"https://api.github.com/repos/product-definition-center/pdc-client/deployments","created_at":"2015-11-16T02:23:01Z","updated_at":"2017-04-04T19:38:22Z","pushed_at":"2017-09-28T06:30:06Z","git_url":"git://github.com/product-definition-center/pdc-client.git","ssh_url":"git@github.com:product-definition-center/pdc-client.git","clone_url":"https://github.com/product-definition-center/pdc-client.git","svn_url":"https://github.com/product-definition-center/pdc-client","homepage":"","size":780,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":14,"mirror_url":null,"open_issues_count":6,"forks":14,"open_issues":6,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/product-definition-center/pdc-client/pulls/131"},"html":{"href":"https://github.com/product-definition-center/pdc-client/pull/131"},"issue":{"href":"https://api.github.com/repos/product-definition-center/pdc-client/issues/131"},"comments":{"href":"https://api.github.com/repos/product-definition-center/pdc-client/issues/131/comments"},"review_comments":{"href":"https://api.github.com/repos/product-definition-center/pdc-client/pulls/131/comments"},"review_comment":{"href":"https://api.github.com/repos/product-definition-center/pdc-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/product-definition-center/pdc-client/pulls/131/commits"},"statuses":{"href":"https://api.github.com/repos/product-definition-center/pdc-client/statuses/455e1ac317bbe4054a2bf56e7f2341a0594402bb"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"simozhan"}}