{"action":"created","comment":{"url":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls/comments/146299903","pull_request_review_id":71221495,"id":146299903,"diff_hunk":"@@ -25,17 +25,29 @@ def _normalize_log_level(level):\n         raise ConfigurationError('Log level must be a string!') from exc\n \n \n-def setup_pub_logger():\n+def setup_pub_logger(logging_port=None):\n+    if logging_port is None:\n+        logging_port = DEFAULT_SOCKET_LOGGING_PORT\n+\n     dictConfig(PUBLISHER_LOGGING_CONFIG)\n     socket_handler = logging.handlers.SocketHandler(\n-        DEFAULT_SOCKET_LOGGING_HOST, DEFAULT_SOCKET_LOGGING_PORT)\n+        DEFAULT_SOCKET_LOGGING_HOST, logging_port)\n     socket_handler.setLevel(logging.DEBUG)\n     logger = logging.getLogger()\n     logger.addHandler(socket_handler)\n \n \n def setup_sub_logger(*, user_log_config=None):\n-    server = LogRecordSocketServer()\n+    kwargs = {}\n+    logging_port = None","path":"bigchaindb/log/setup.py","position":21,"original_position":21,"commit_id":"6f5eef97a7e000502434522a9401b8b39b4c583b","original_commit_id":"6f5eef97a7e000502434522a9401b8b39b4c583b","user":{"login":"r-marques","id":1793187,"avatar_url":"https://avatars3.githubusercontent.com/u/1793187?v=4","gravatar_id":"","url":"https://api.github.com/users/r-marques","html_url":"https://github.com/r-marques","followers_url":"https://api.github.com/users/r-marques/followers","following_url":"https://api.github.com/users/r-marques/following{/other_user}","gists_url":"https://api.github.com/users/r-marques/gists{/gist_id}","starred_url":"https://api.github.com/users/r-marques/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/r-marques/subscriptions","organizations_url":"https://api.github.com/users/r-marques/orgs","repos_url":"https://api.github.com/users/r-marques/repos","events_url":"https://api.github.com/users/r-marques/events{/privacy}","received_events_url":"https://api.github.com/users/r-marques/received_events","type":"User","site_admin":false},"body":"`logging_port` could be initialized the same way you did in https://github.com/bigchaindb/bigchaindb/pull/1796/files#diff-30313dc6455cdf917cde64a230c4ec99R60 this way the code would be more consistent.","created_at":"2017-10-23T15:15:06Z","updated_at":"2017-10-23T15:15:06Z","html_url":"https://github.com/bigchaindb/bigchaindb/pull/1796#discussion_r146299903","pull_request_url":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls/1796","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls/comments/146299903"},"html":{"href":"https://github.com/bigchaindb/bigchaindb/pull/1796#discussion_r146299903"},"pull_request":{"href":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls/1796"}}},"pull_request":{"url":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls/1796","id":148037611,"html_url":"https://github.com/bigchaindb/bigchaindb/pull/1796","diff_url":"https://github.com/bigchaindb/bigchaindb/pull/1796.diff","patch_url":"https://github.com/bigchaindb/bigchaindb/pull/1796.patch","issue_url":"https://api.github.com/repos/bigchaindb/bigchaindb/issues/1796","number":1796,"state":"open","locked":false,"title":"Provide log server port as config parameter","user":{"login":"kansi","id":4709940,"avatar_url":"https://avatars2.githubusercontent.com/u/4709940?v=4","gravatar_id":"","url":"https://api.github.com/users/kansi","html_url":"https://github.com/kansi","followers_url":"https://api.github.com/users/kansi/followers","following_url":"https://api.github.com/users/kansi/following{/other_user}","gists_url":"https://api.github.com/users/kansi/gists{/gist_id}","starred_url":"https://api.github.com/users/kansi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kansi/subscriptions","organizations_url":"https://api.github.com/users/kansi/orgs","repos_url":"https://api.github.com/users/kansi/repos","events_url":"https://api.github.com/users/kansi/events{/privacy}","received_events_url":"https://api.github.com/users/kansi/received_events","type":"User","site_admin":false},"body":"Converted log server's binding port as a parameter in `.bigchaindb` config file\r\nFixes #1660 ","created_at":"2017-10-23T04:22:32Z","updated_at":"2017-10-23T15:15:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e7c320603fdb8db815e4a331651d862b648dfd8c","assignee":null,"assignees":[],"requested_reviewers":[{"login":"sbellem","id":125458,"avatar_url":"https://avatars2.githubusercontent.com/u/125458?v=4","gravatar_id":"","url":"https://api.github.com/users/sbellem","html_url":"https://github.com/sbellem","followers_url":"https://api.github.com/users/sbellem/followers","following_url":"https://api.github.com/users/sbellem/following{/other_user}","gists_url":"https://api.github.com/users/sbellem/gists{/gist_id}","starred_url":"https://api.github.com/users/sbellem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbellem/subscriptions","organizations_url":"https://api.github.com/users/sbellem/orgs","repos_url":"https://api.github.com/users/sbellem/repos","events_url":"https://api.github.com/users/sbellem/events{/privacy}","received_events_url":"https://api.github.com/users/sbellem/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls/1796/commits","review_comments_url":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls/1796/comments","review_comment_url":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bigchaindb/bigchaindb/issues/1796/comments","statuses_url":"https://api.github.com/repos/bigchaindb/bigchaindb/statuses/6f5eef97a7e000502434522a9401b8b39b4c583b","head":{"label":"bigchaindb:bug/1660/logging-server-port-config","ref":"bug/1660/logging-server-port-config","sha":"6f5eef97a7e000502434522a9401b8b39b4c583b","user":{"login":"bigchaindb","id":17097586,"avatar_url":"https://avatars0.githubusercontent.com/u/17097586?v=4","gravatar_id":"","url":"https://api.github.com/users/bigchaindb","html_url":"https://github.com/bigchaindb","followers_url":"https://api.github.com/users/bigchaindb/followers","following_url":"https://api.github.com/users/bigchaindb/following{/other_user}","gists_url":"https://api.github.com/users/bigchaindb/gists{/gist_id}","starred_url":"https://api.github.com/users/bigchaindb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigchaindb/subscriptions","organizations_url":"https://api.github.com/users/bigchaindb/orgs","repos_url":"https://api.github.com/users/bigchaindb/repos","events_url":"https://api.github.com/users/bigchaindb/events{/privacy}","received_events_url":"https://api.github.com/users/bigchaindb/received_events","type":"Organization","site_admin":false},"repo":{"id":51290852,"name":"bigchaindb","full_name":"bigchaindb/bigchaindb","owner":{"login":"bigchaindb","id":17097586,"avatar_url":"https://avatars0.githubusercontent.com/u/17097586?v=4","gravatar_id":"","url":"https://api.github.com/users/bigchaindb","html_url":"https://github.com/bigchaindb","followers_url":"https://api.github.com/users/bigchaindb/followers","following_url":"https://api.github.com/users/bigchaindb/following{/other_user}","gists_url":"https://api.github.com/users/bigchaindb/gists{/gist_id}","starred_url":"https://api.github.com/users/bigchaindb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigchaindb/subscriptions","organizations_url":"https://api.github.com/users/bigchaindb/orgs","repos_url":"https://api.github.com/users/bigchaindb/repos","events_url":"https://api.github.com/users/bigchaindb/events{/privacy}","received_events_url":"https://api.github.com/users/bigchaindb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bigchaindb/bigchaindb","description":"BigchainDB is a scalable blockchain database","fork":false,"url":"https://api.github.com/repos/bigchaindb/bigchaindb","forks_url":"https://api.github.com/repos/bigchaindb/bigchaindb/forks","keys_url":"https://api.github.com/repos/bigchaindb/bigchaindb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bigchaindb/bigchaindb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bigchaindb/bigchaindb/teams","hooks_url":"https://api.github.com/repos/bigchaindb/bigchaindb/hooks","issue_events_url":"https://api.github.com/repos/bigchaindb/bigchaindb/issues/events{/number}","events_url":"https://api.github.com/repos/bigchaindb/bigchaindb/events","assignees_url":"https://api.github.com/repos/bigchaindb/bigchaindb/assignees{/user}","branches_url":"https://api.github.com/repos/bigchaindb/bigchaindb/branches{/branch}","tags_url":"https://api.github.com/repos/bigchaindb/bigchaindb/tags","blobs_url":"https://api.github.com/repos/bigchaindb/bigchaindb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bigchaindb/bigchaindb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bigchaindb/bigchaindb/git/refs{/sha}","trees_url":"https://api.github.com/repos/bigchaindb/bigchaindb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bigchaindb/bigchaindb/statuses/{sha}","languages_url":"https://api.github.com/repos/bigchaindb/bigchaindb/languages","stargazers_url":"https://api.github.com/repos/bigchaindb/bigchaindb/stargazers","contributors_url":"https://api.github.com/repos/bigchaindb/bigchaindb/contributors","subscribers_url":"https://api.github.com/repos/bigchaindb/bigchaindb/subscribers","subscription_url":"https://api.github.com/repos/bigchaindb/bigchaindb/subscription","commits_url":"https://api.github.com/repos/bigchaindb/bigchaindb/commits{/sha}","git_commits_url":"https://api.github.com/repos/bigchaindb/bigchaindb/git/commits{/sha}","comments_url":"https://api.github.com/repos/bigchaindb/bigchaindb/comments{/number}","issue_comment_url":"https://api.github.com/repos/bigchaindb/bigchaindb/issues/comments{/number}","contents_url":"https://api.github.com/repos/bigchaindb/bigchaindb/contents/{+path}","compare_url":"https://api.github.com/repos/bigchaindb/bigchaindb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bigchaindb/bigchaindb/merges","archive_url":"https://api.github.com/repos/bigchaindb/bigchaindb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bigchaindb/bigchaindb/downloads","issues_url":"https://api.github.com/repos/bigchaindb/bigchaindb/issues{/number}","pulls_url":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls{/number}","milestones_url":"https://api.github.com/repos/bigchaindb/bigchaindb/milestones{/number}","notifications_url":"https://api.github.com/repos/bigchaindb/bigchaindb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bigchaindb/bigchaindb/labels{/name}","releases_url":"https://api.github.com/repos/bigchaindb/bigchaindb/releases{/id}","deployments_url":"https://api.github.com/repos/bigchaindb/bigchaindb/deployments","created_at":"2016-02-08T10:12:58Z","updated_at":"2017-10-23T09:06:16Z","pushed_at":"2017-10-23T12:37:17Z","git_url":"git://github.com/bigchaindb/bigchaindb.git","ssh_url":"git@github.com:bigchaindb/bigchaindb.git","clone_url":"https://github.com/bigchaindb/bigchaindb.git","svn_url":"https://github.com/bigchaindb/bigchaindb","homepage":"https://www.bigchaindb.com/","size":8617,"stargazers_count":1563,"watchers_count":1563,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":300,"mirror_url":null,"archived":false,"open_issues_count":239,"forks":300,"open_issues":239,"watchers":1563,"default_branch":"master"}},"base":{"label":"bigchaindb:master","ref":"master","sha":"788f2f7277f871df9c165ca7464260185a5fb895","user":{"login":"bigchaindb","id":17097586,"avatar_url":"https://avatars0.githubusercontent.com/u/17097586?v=4","gravatar_id":"","url":"https://api.github.com/users/bigchaindb","html_url":"https://github.com/bigchaindb","followers_url":"https://api.github.com/users/bigchaindb/followers","following_url":"https://api.github.com/users/bigchaindb/following{/other_user}","gists_url":"https://api.github.com/users/bigchaindb/gists{/gist_id}","starred_url":"https://api.github.com/users/bigchaindb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigchaindb/subscriptions","organizations_url":"https://api.github.com/users/bigchaindb/orgs","repos_url":"https://api.github.com/users/bigchaindb/repos","events_url":"https://api.github.com/users/bigchaindb/events{/privacy}","received_events_url":"https://api.github.com/users/bigchaindb/received_events","type":"Organization","site_admin":false},"repo":{"id":51290852,"name":"bigchaindb","full_name":"bigchaindb/bigchaindb","owner":{"login":"bigchaindb","id":17097586,"avatar_url":"https://avatars0.githubusercontent.com/u/17097586?v=4","gravatar_id":"","url":"https://api.github.com/users/bigchaindb","html_url":"https://github.com/bigchaindb","followers_url":"https://api.github.com/users/bigchaindb/followers","following_url":"https://api.github.com/users/bigchaindb/following{/other_user}","gists_url":"https://api.github.com/users/bigchaindb/gists{/gist_id}","starred_url":"https://api.github.com/users/bigchaindb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigchaindb/subscriptions","organizations_url":"https://api.github.com/users/bigchaindb/orgs","repos_url":"https://api.github.com/users/bigchaindb/repos","events_url":"https://api.github.com/users/bigchaindb/events{/privacy}","received_events_url":"https://api.github.com/users/bigchaindb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bigchaindb/bigchaindb","description":"BigchainDB is a scalable blockchain database","fork":false,"url":"https://api.github.com/repos/bigchaindb/bigchaindb","forks_url":"https://api.github.com/repos/bigchaindb/bigchaindb/forks","keys_url":"https://api.github.com/repos/bigchaindb/bigchaindb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bigchaindb/bigchaindb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bigchaindb/bigchaindb/teams","hooks_url":"https://api.github.com/repos/bigchaindb/bigchaindb/hooks","issue_events_url":"https://api.github.com/repos/bigchaindb/bigchaindb/issues/events{/number}","events_url":"https://api.github.com/repos/bigchaindb/bigchaindb/events","assignees_url":"https://api.github.com/repos/bigchaindb/bigchaindb/assignees{/user}","branches_url":"https://api.github.com/repos/bigchaindb/bigchaindb/branches{/branch}","tags_url":"https://api.github.com/repos/bigchaindb/bigchaindb/tags","blobs_url":"https://api.github.com/repos/bigchaindb/bigchaindb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bigchaindb/bigchaindb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bigchaindb/bigchaindb/git/refs{/sha}","trees_url":"https://api.github.com/repos/bigchaindb/bigchaindb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bigchaindb/bigchaindb/statuses/{sha}","languages_url":"https://api.github.com/repos/bigchaindb/bigchaindb/languages","stargazers_url":"https://api.github.com/repos/bigchaindb/bigchaindb/stargazers","contributors_url":"https://api.github.com/repos/bigchaindb/bigchaindb/contributors","subscribers_url":"https://api.github.com/repos/bigchaindb/bigchaindb/subscribers","subscription_url":"https://api.github.com/repos/bigchaindb/bigchaindb/subscription","commits_url":"https://api.github.com/repos/bigchaindb/bigchaindb/commits{/sha}","git_commits_url":"https://api.github.com/repos/bigchaindb/bigchaindb/git/commits{/sha}","comments_url":"https://api.github.com/repos/bigchaindb/bigchaindb/comments{/number}","issue_comment_url":"https://api.github.com/repos/bigchaindb/bigchaindb/issues/comments{/number}","contents_url":"https://api.github.com/repos/bigchaindb/bigchaindb/contents/{+path}","compare_url":"https://api.github.com/repos/bigchaindb/bigchaindb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bigchaindb/bigchaindb/merges","archive_url":"https://api.github.com/repos/bigchaindb/bigchaindb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bigchaindb/bigchaindb/downloads","issues_url":"https://api.github.com/repos/bigchaindb/bigchaindb/issues{/number}","pulls_url":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls{/number}","milestones_url":"https://api.github.com/repos/bigchaindb/bigchaindb/milestones{/number}","notifications_url":"https://api.github.com/repos/bigchaindb/bigchaindb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bigchaindb/bigchaindb/labels{/name}","releases_url":"https://api.github.com/repos/bigchaindb/bigchaindb/releases{/id}","deployments_url":"https://api.github.com/repos/bigchaindb/bigchaindb/deployments","created_at":"2016-02-08T10:12:58Z","updated_at":"2017-10-23T09:06:16Z","pushed_at":"2017-10-23T12:37:17Z","git_url":"git://github.com/bigchaindb/bigchaindb.git","ssh_url":"git@github.com:bigchaindb/bigchaindb.git","clone_url":"https://github.com/bigchaindb/bigchaindb.git","svn_url":"https://github.com/bigchaindb/bigchaindb","homepage":"https://www.bigchaindb.com/","size":8617,"stargazers_count":1563,"watchers_count":1563,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":300,"mirror_url":null,"archived":false,"open_issues_count":239,"forks":300,"open_issues":239,"watchers":1563,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls/1796"},"html":{"href":"https://github.com/bigchaindb/bigchaindb/pull/1796"},"issue":{"href":"https://api.github.com/repos/bigchaindb/bigchaindb/issues/1796"},"comments":{"href":"https://api.github.com/repos/bigchaindb/bigchaindb/issues/1796/comments"},"review_comments":{"href":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls/1796/comments"},"review_comment":{"href":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls/1796/commits"},"statuses":{"href":"https://api.github.com/repos/bigchaindb/bigchaindb/statuses/6f5eef97a7e000502434522a9401b8b39b4c583b"}},"author_association":"NONE"}}
{"actor":{"display_login":"r-marques"}}